]> code.delx.au - gnu-emacs-elpa/blobdiff - multishell-list.el
multishell - 1.1.5, preserve listing recency, increment multishell-version
[gnu-emacs-elpa] / multishell-list.el
index 4ac2a312a62c24245619c64bacb09d83d9b09cda..dc7529b6ae237d6219e8425f2e6cb8dcc7faff98 100644 (file)
@@ -3,7 +3,7 @@
 ;; Copyright (C) 2016 Free Software Foundation, Inc. and Ken Manheimer
 
 ;; Author: Ken Manheimer <ken.manheimer@gmail.com>
-;; Version: 1.1.2
+;; Version: 1.1.5
 ;; Created: 2016 -- first public availability
 ;; Keywords: processes
 ;; URL: https://github.com/kenmanheimer/EmacsMultishell
 
 (require 'tabulated-list)
 
+(defgroup multishell-list nil
+  "Show a menu of all shell buffers in a buffer."
+  :group 'multishell)
+
+(defface multishell-list-name
+  '((t (:weight bold)))
+  "Face for shell names in the Multishell List."
+  :group 'multishell-list)
+
 (defun multishell-list-open-pop (&optional arg)
   "Pop to current entry's shell in separate window.
 
@@ -24,17 +33,22 @@ pop to the buffer but don't change its run state."
     (if arg
         (pop-to-buffer
          (multishell-bracket (multishell-name-from-entry entry)))
-      (multishell-pop-to-shell nil entry))
+      (multishell-list-dispatch-selected entry t))
     (with-current-buffer list-buffer
-      (revert-buffer))))
+      (revert-buffer)
+      (multishell-list-goto-item-by-entry entry))))
+
 (defun multishell-list-open-as-default ()
   "Pop to current entry's shell, and set as the default shell."
   (interactive)
-  (let ((list-buffer (current-buffer)))
-    (message "%s <==" (multishell-name-from-entry (tabulated-list-get-id)))
-    (multishell-pop-to-shell '(16) (tabulated-list-get-id))
+  (let ((list-buffer (current-buffer))
+        (entry (tabulated-list-get-id)))
+    (message "%s <==" (multishell-name-from-entry entry))
+    (multishell-list-dispatch-selected entry t t)
     (with-current-buffer list-buffer
-      (revert-buffer))))
+      (revert-buffer)
+      (multishell-list-goto-item-by-entry entry))))
+
 (defun multishell-list-open-here (&optional arg)
   "Switch to current entry's shell buffer.
 
@@ -47,7 +61,7 @@ switch to the buffer but don't activate (or deactivate) it it."
     (if arg
         (switch-to-buffer
          (multishell-bracket (multishell-name-from-entry entry)))
-      (multishell-pop-to-shell nil entry 'here))
+      (multishell-list-dispatch-selected entry nil))
     (with-current-buffer list-buffer
       (revert-buffer))))
 
@@ -75,8 +89,7 @@ submitting the entry will pop to the shell in a new window,
 starting it if it's not already going."
 
   (interactive "P")
-  (let* ((where (save-excursion (beginning-of-line) (point)))
-         (list-buffer (current-buffer))
+  (let* ((list-buffer (current-buffer))
          (entry (tabulated-list-get-id))
          (name (multishell-name-from-entry entry))
          (revised (multishell-read-unbracketed-entry
@@ -92,10 +105,10 @@ starting it if it's not already going."
         (with-current-buffer buffer
           (rename-buffer (multishell-bracket revised-name)))))
     (when arg
-      (multishell-pop-to-shell nil revised-name))
+      (multishell-list-dispatch-selected revised-name t))
     (with-current-buffer list-buffer
       (revert-buffer)
-      (goto-char where))))
+      (multishell-list-goto-item-by-entry revised))))
 
 (defun multishell-list-clone-entry (&optional arg)
   "Create a new list entry, edited from the current one, ready to launch.
@@ -118,7 +131,26 @@ The already existing original entry is left untouched."
       (revert-buffer)
       (multishell-list-goto-item-by-entry new)
       (when arg
-        (multishell-pop-to-shell nil new-name)))))
+        (multishell-list-dispatch-selected new-name t)))))
+
+(defun multishell-list-mouse-select (event)
+  "Select the shell whose line is clicked."
+  (interactive "e")
+  (select-window (posn-window (event-end event)))
+  (let ((entry (tabulated-list-get-id (posn-point (event-end event)))))
+    (multishell-list-dispatch-selected entry nil)))
+
+(defun multishell-list-dispatch-selected (entry pop &optional set-primary)
+  "Go to multishell ENTRY, popping to window if POP is non-nil.
+
+Optional arg SET-PRIMARY non-nil sets `multishell-primary-name' to entry.
+
+Provide for concluding minibuffer interaction if we're in completing mode."
+  (let ((set-primary-as-arg (and set-primary '(16))))
+    (if multishell-completing-read
+        ;; In multishell completing-read, arrange to conclude minibuffer input:
+        (throw 'multishell-minibuffer-exit (list entry pop set-primary-as-arg))
+      (multishell-pop-to-shell set-primary-as-arg entry (not pop)))))
 
 (defun multishell-list-placeholder (value default)
   "Return VALUE if non-empty string, else DEFAULT."
@@ -145,9 +177,10 @@ The already existing original entry is left untouched."
                                       multishell-list-active-flag)
                                      (t multishell-list-inactive-flag)))
                        (rest (cadr splat))
-                       (dir (or (file-remote-p rest 'localname)
-                                rest))
-                       (hops (and (file-remote-p rest 'localname)
+                       (dir (and rest (or (file-remote-p rest 'localname)
+                                          rest)))
+                       (hops (and dir
+                                  (file-remote-p rest 'localname)
                                   (substring
                                    rest 0 (- (length rest) (length dir))))))
                   (when (not name)
@@ -155,7 +188,7 @@ The already existing original entry is left untouched."
                   (list entry
                         (vector (format "%d" recency)
                                 status
-                                name
+                                (multishell-list--decorate-name name)
                                 (multishell-list-placeholder hops "-")
                                 (multishell-list-placeholder dir "~")))))
             (multishell-all-entries))))
@@ -167,13 +200,19 @@ The already existing original entry is left untouched."
               (not (string= (tabulated-list-get-id) entry)))
     (forward-line 1)))
 
-(defun compare-strings-as-numbers (a b)
+(defun multishell-collate-row-strings-as-numbers (a b)
   (let ((a (aref (cadr a) 0))
         (b (aref (cadr b) 0)))
     (> (string-to-number a) (string-to-number b))))
 
+(defun multishell-list--decorate-name (name)
+  (propertize name
+              'font-lock-face 'multishell-list-name
+              'mouse-face 'highlight))
+
 (defvar multishell-list-mode-map
   (let ((map (make-sparse-keymap)))
+    (set-keymap-parent map tabulated-list-mode-map)
     (define-key map (kbd "c") 'multishell-list-clone-entry)
     (define-key map (kbd "d") 'multishell-list-delete)
     (define-key map (kbd "\C-k") 'multishell-list-delete)
@@ -183,6 +222,8 @@ The already existing original entry is left untouched."
     (define-key map (kbd " ") 'multishell-list-open-pop)
     (define-key map (kbd "O") 'multishell-list-open-as-default)
     (define-key map (kbd "RET") 'multishell-list-open-here)
+    (define-key map [mouse-2] 'multishell-list-mouse-select)
+    (define-key map [follow-link] 'mouse-face)
     map))
 (define-derived-mode multishell-list-mode
     tabulated-list-mode "Shells"
@@ -197,7 +238,7 @@ Initial sort is from most to least recently used:
 \\{multishell-list-mode-map\}"
   (setq tabulated-list-format
         [;; (name width sort '(:right-align nil :pad-right nil))
-         ("#" 0 compare-strings-as-numbers :pad-right 1)
+         ("#" 0 multishell-collate-row-strings-as-numbers :pad-right 1)
          ("! " 1 t :pad-right 1)
          ("Name" 15 t)
          ("Hops" 30 t)
@@ -206,20 +247,64 @@ Initial sort is from most to least recently used:
         tabulated-list-entries #'multishell-list-entries)
   (tabulated-list-init-header))
 
+(defun multishell-list-cull-dups (entries)
+  "Return list of multishell ENTRIES sans ones with duplicate names.
+
+For duplicates, we prefer the ones that have paths."
+  (let ((tally (make-hash-table :test #'equal))
+        got name name-order-reversed already)
+    (mapcar #'(lambda (entry)
+                (setq name (multishell-name-from-entry entry)
+                      already (gethash name tally nil))
+                (when (not already)
+                  (push name name-order-reversed))
+                (when (or (not already) (< (length already) (length entry)))
+                  ;; Add new or replace shorter prior entry for name:
+                  (puthash name entry tally)))
+            entries)
+    (dolist (name name-order-reversed)
+      (push (gethash name tally) got))
+    got))
+
 ;;;###autoload
-(defun multishell-list ()
+(defun multishell-list (&optional completing)
   "Edit your current and historic list of shell buffers.
 
-Hit ? for a list of commands.
+If optional COMPLETING is nil, we present the full
+`multishell-history' list in a popped buffer named '*Shells*'.
+
+In the buffer, hit ? or h for a list of commands.
+
+When optional COMPLETING is non-nil, it must be a list of
+multishell-history completion candidate entries, as provided by
+`completing-read'. Then we present the list as a part of
+minibuffer completion.
 
-You can get to this shell listing manager by
-recursively invoking \\[multishell-pop-to-shell] at either of the
-`multishell-pop-to-shell' universal argument prompts."
+You can get to the shells listing by recursively invoking
+\\[multishell-pop-to-shell] at the `multishell-pop-to-shell'
+`universal-argument' prompts."
   (interactive)
-  (let ((buffer (get-buffer-create "*Shells*")))
-    (pop-to-buffer buffer)
+  (let ((from-entry (car (multishell-history-entries
+                          (multishell-unbracket (buffer-name
+                                                 (current-buffer))))))
+        (buffer (get-buffer-create (if completing
+                                       "*Completions*"
+                                     "*Shells*"))))
+    (if completing
+        (set-buffer buffer)
+      (pop-to-buffer buffer))
     (multishell-list-mode)
-    (tabulated-list-print)))
+    (progv
+        ;; Temporarily assign multishell-history only when completing:
+        (when completing '(multishell-history))
+        (when completing
+          (list (multishell-list-cull-dups (mapcar 'substring-no-properties
+                                                   completing))))
+      (tabulated-list-print))
+    (when completing
+      )
+    (when from-entry
+      (multishell-list-goto-item-by-entry from-entry))))
 
 (provide 'multishell-list)
 (require 'multishell)