From 12586e57f6c2ee480a5fbb4beee3919aadf32ad3 Mon Sep 17 00:00:00 2001 From: Brandon Olivier Date: Mon, 2 May 2016 14:14:06 -0500 Subject: [PATCH] Allow space before global declaration --- js2-mode.el | 2 +- tests/externs.el | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/js2-mode.el b/js2-mode.el index b2efce007..e804fbbb1 100644 --- a/js2-mode.el +++ b/js2-mode.el @@ -7264,7 +7264,7 @@ are ignored." when (and (eq 'block (js2-comment-node-format node)) (save-excursion (goto-char (js2-node-abs-pos node)) - (looking-at "/\\*global "))) + (looking-at "/\\* *global "))) append (js2-get-jslint-globals-in (match-end 0) (js2-node-abs-end node)))) diff --git a/tests/externs.el b/tests/externs.el index 40957f600..09a60a9d3 100644 --- a/tests/externs.el +++ b/tests/externs.el @@ -42,6 +42,13 @@ (should (equal (js2-get-jslint-globals) '("quux" "tee" "$"))))) +(ert-deftest js2-finds-jslint-globals-with-space () + (with-temp-buffer + (insert "/* global foo, bar:false, baz:true") + (js2-mode) + (should (equal (js2-get-jslint-globals) + '("foo" "bar" "baz"))))) + ;;;TODO ;; ensure that any symbols bound with the import syntax are added to the extern list ;; ensure that any symbols bound with the export syntax exist in the file scope -- 2.39.2