1 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3 * window.c (syms_of_window) <window-combination-limit>: Fix typo.
5 2011-11-16 Martin Rudalics <rudalics@gmx.at>
7 * window.h (window): Rename slot "nest" to "combination_limit".
8 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9 (Fset_window_nest): Rename to Fset_window_combination_limit.
10 (Vwindow_nest): Rename to Vwindow_combination_limit.
11 (recombine_windows, make_parent_window, make_window)
12 (Fsplit_window_internal, saved_window)
13 (Fset_window_configuration, save_window_save): Rename all
14 occurrences of window_nest to window_combination_limit.
16 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
18 * image.c (imagemagick_load_image): Fix typo.
20 2011-11-14 Eli Zaretskii <eliz@gnu.org>
22 * xdisp.c (display_line): Move the call to
23 highlight_trailing_whitespace before the call to
24 compute_line_metrics, since the latter needs to see the final
25 faces of all the glyphs to compute ROW's hash value. Fixes
26 assertion violations in row_equal_p. (Bug#10035)
28 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
30 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
31 just return (bug#10044).
33 2011-11-12 Eli Zaretskii <eliz@gnu.org>
35 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
36 with user-defined heap size. Bump the default size of the temacs
37 heap to 27MB, to avoid memory warning when running temacs.
38 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
40 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
41 current_matrix and desired_matrix. (Bug#9990)
42 (verify_row_hash) [XASSERTS]: New function.
43 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
44 that the hash value of glyph rows is correct.
46 2011-11-12 Martin Rudalics <rudalics@gmx.at>
48 * window.h (window): Remove splits slot.
49 * window.c (Fwindow_splits, Fset_window_splits): Remove.
50 (Fdelete_other_windows_internal, make_parent_window)
51 (make_window, Fsplit_window_internal, Fdelete_window_internal)
52 (Fset_window_configuration, save_window_save): Don't deal with
53 split status of windows.
54 (saved_window): Remove splits slot.
55 (Vwindow_splits): Rewrite doc-string.
57 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
59 * xfns.c (unwind_create_frame):
60 * nsfns.m (unwind_create_frame):
61 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
62 Vframe_list (Bug#9999).
64 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
66 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
68 2011-11-11 Kenichi Handa <handa@m17n.org>
70 * callproc.c (Fcall_process): Set the member dst_multibyte of
73 2011-11-11 Johan Bockgård <bojohan@gnu.org>
75 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
76 avoid a crash (bug#9496).
78 2011-11-09 Chong Yidong <cyd@gnu.org>
80 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
81 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
83 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
85 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
87 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
89 Avoid some portability problems by eschewing 'extern inline' functions.
90 The trivial performance wins aren't worth the portability hassles; see
91 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
93 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
94 (window_box_width, window_box_left, window_box_left_offset)
95 (window_box_right, window_box_right_offset): Undo previous change,
96 by removing the "extern"s.
97 * intervals.c (adjust_intervals_for_insertion)
98 (adjust_intervals_for_deletion): Undo previous change,
99 making these static again.
100 (offset_intervals, temp_set_point_both, temp_set_point)
101 (copy_intervals_to_string): No longer inline.
102 * xdisp.c (window_text_bottom_y, window_box_width)
103 (window_box_height, window_box_left_offset)
104 (window_box_right_offset, window_box_left, window_box_right)
105 (window_box): No longer inline.
107 2011-11-08 Chong Yidong <cyd@gnu.org>
109 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
110 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
111 an error if not a live window.
112 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
113 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
115 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
117 * lisp.h (syms_of_abbrev): Remove declaration.
118 Reported by CHENG Gao <chenggao@royau.me>.
120 2011-11-07 Eli Zaretskii <eliz@gnu.org>
122 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
123 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
124 of temacs in GUI mode.
126 2011-11-07 Martin Rudalics <rudalics@gmx.at>
128 * window.h: Declare delete_all_child_windows instead of
129 delete_all_subwindows.
130 * window.c (Fwindow_nest, Fset_window_nest)
131 (Fset_window_new_total, Fset_window_new_normal)
132 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
133 (delete_all_subwindows): Rename to delete_all_child_windows.
134 (Fdelete_other_windows_internal, Fset_window_configuration):
135 Call delete_all_child_windows instead of delete_all_subwindows.
136 * frame.c (delete_frame): Call delete_all_child_windows instead
137 of delete_all_subwindows.
139 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
141 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
142 This is also needed for porting to any host where GC_MARK_STACK is
143 not GC_MAKE_GCPROS_NOOPS.
144 (which_symbols): Use it.
146 2011-11-07 Kenichi Handa <handa@m17n.org>
148 * coding.c (coding_set_destination): Check coding->src_pos only
149 when coding->src_object is a buffer (bug#9910).
151 * process.c (send_process): Set the member src_multibyte of coding
152 to 0 (bug#9911) when sending a unibyte text.
154 * callproc.c (Fcall_process): Set the member src_multibyte of
155 process_coding to 0 (bug#9912).
157 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
159 * xmenu.c (cleanup_widget_value_tree): New function.
160 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
161 calling free_menubar_widget_value_tree directly (Bug#9830).
163 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
165 Fix some portability problems with 'inline'.
166 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
167 (window_box_width, window_box_left, window_box_left_offset)
168 (window_box_right, window_box_right_offset): Declare extern.
169 Otherwise, these inline functions do not conform to C99 and
170 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
171 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
172 * intervals.c (adjust_intervals_for_insertion)
173 (adjust_intervals_for_deletion): Now extern, because otherwise the
174 extern inline functions 'offset_intervals' couldn't refer to it.
175 (static_offset_intervals): Remove.
176 (offset_intervals): Rewrite using the old contents of
177 static_offset_intervals. The old version didn't conform to C99
178 because an extern inline function contained a reference to an
179 identifier with static linkage.
181 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
183 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
186 2011-11-06 Eli Zaretskii <eliz@gnu.org>
188 * xdisp.c (init_iterator, reseat_to_string): Don't set the
189 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
190 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
191 return Qleft_to_right.
193 2011-11-06 Chong Yidong <cyd@gnu.org>
195 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
196 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
197 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
198 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
199 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
200 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
201 (Fwindow_vscroll): Doc fix.
202 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
203 argument, since it makes no sense to pass a live window and for
204 consistency with window-child.
206 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
208 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
211 2011-11-05 Jason Rumney <jasonr@gnu.org>
213 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
214 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
216 (add_font_entity_to_list): Fix logic errors in mixed boolean and
217 bitwise arithmetic preventing use of unicode-sip and non-truetype
220 2011-11-05 Eli Zaretskii <eliz@gnu.org>
222 * s/ms-w32.h (fstat, stat, utime): Move redirections to
225 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
226 initialization code to keep similarity to xfns.c after changes
229 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
231 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
232 (unwind_create_frame): New function (Bug#9943).
233 (Fx_create_frame): Restructure code to be more similar to the one in
234 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
235 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
236 Move terminal->reference_count++ just before making the frame official
239 * nsterm.m (x_free_frame_resources): New function.
240 (x_destroy_window): Move code to x_free_frame_resources.
242 * xfns.c (unwind_create_frame): Fix comment.
243 (Fx_create_frame, x_create_tip_frame): Move
244 terminal->reference_count++ just before making the frame
245 official. Move initialization of image_cache_refcount and
246 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
248 2011-11-05 Eli Zaretskii <eliz@gnu.org>
250 Support MSVC build with newer versions of Visual Studio.
251 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
252 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
255 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
256 which are not supported by MSVC.
257 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
258 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
260 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
262 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
264 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
266 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
268 Support MSVC build with newer versions of Visual Studio.
269 * w32.c: Don't include w32api.h for MSVC.
270 (init_environment) [_MSC_VER]: Call sys_access, not _access.
272 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
273 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
274 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
275 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
277 (alloca) [_MSC_VER]: Define to _alloca.
279 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
281 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
283 2011-11-04 Eli Zaretskii <eliz@gnu.org>
285 * xdisp.c (note_mouse_highlight): If either of
286 previous/next-single-property-change returns nil, treat that as
287 the beginning or the end of the buffer. (Bug#9955)
289 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
291 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
292 label is not null (Bug#9951).
293 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
296 2011-11-04 Eli Zaretskii <eliz@gnu.org>
298 * window.c (Fwindow_body_size): Mention in the doc string that the
299 return value is in frame's canonical units. (Bug#9949)
301 2011-11-03 Eli Zaretskii <eliz@gnu.org>
303 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
305 * w32fns.c (unwind_create_frame): If needed, free the glyph
306 matrices of the partially constructed frame. (Bug#9943)
307 * xfns.c (unwind_create_frame): Likewise.
309 2011-11-01 Eli Zaretskii <eliz@gnu.org>
311 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
312 Don't stop backward scan on the continuation glyph, even though
313 its CHARPOS is positive.
314 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
315 cover_string to disp_string.
317 2011-11-01 Martin Rudalics <rudalics@gmx.at>
319 * window.c (temp_output_buffer_show): Don't use
320 Vtemp_buffer_show_specifiers.
321 (Vtemp_buffer_show_specifiers): Remove unused variable.
323 2011-10-30 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
326 past the beginning of the current glyph matrix.
328 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
330 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
331 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
332 HAVE_GTK3 (Bug#9869).
334 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
335 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
337 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
339 * xterm.c: Declare x_handle_net_wm_state to return int.
340 (handle_one_xevent): Check if we are iconified but don't have
341 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
342 (get_current_wm_state): Return non-zero if not hidden,
343 check for _NET_WM_STATE_HIDDEN (Bug#9893).
344 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
345 (x_handle_net_wm_state): Return what get_current_wm_state returns.
346 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
348 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
350 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
351 so that this new function doesn't get optimized away by a
352 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
354 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
356 * frame.h (MOUSE_HL_INFO): Remove excess parens.
358 2011-10-29 Eli Zaretskii <eliz@gnu.org>
360 Fix the `xbytecode' command.
361 * .gdbinit (xprintbytestr): New command.
362 (xwhichsymbols): Renamed from `which'; all callers changed.
363 (xbytecode): Print the byte-code string as well.
365 2011-10-29 Kim Storm <storm@cua.dk>
367 * alloc.c (which_symbols): New function.
369 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
371 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
374 2011-10-29 Glenn Morris <rgm@gnu.org>
376 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
377 Not clear what it was for, and it causes various bugs. (Bug#9839)
379 2011-10-28 Eli Zaretskii <eliz@gnu.org>
381 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
382 possible random value that matches one of those tested as
383 condition to clear the mouse face.
385 2011-10-28 Chong Yidong <cyd@gnu.org>
387 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
389 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
391 * window.c (make_window): Initialize phys_cursor_on_p.
393 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
395 * lisp.h (struct Lisp_Symbol): Update comments.
397 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
399 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
401 2011-10-28 Eli Zaretskii <eliz@gnu.org>
403 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
404 <oslsachem@gmail.com> for helping to debug this.
406 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
407 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
408 (g_b_init_get_glyph_outline_w): New static variables.
409 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
410 (GetGlyphOutlineW_Proc): New typedefs.
411 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
412 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
414 (w32font_open_internal, compute_metrics):
415 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
416 instead of calling the "wide" APIs directly.
418 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
420 * w32.h (syms_of_w32font): Add prototype.
422 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
424 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
425 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
426 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
427 (Fmove_to_window_line): Doc fix.
429 2011-10-27 Chong Yidong <cyd@gnu.org>
431 * process.c (make_process): Set gnutls_state to NULL.
433 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
434 non-NULL, regardless of GNUTLS_INITSTAGE.
435 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
436 an error. Set process slots as soon as we allocate them.
438 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
440 2011-10-27 Chong Yidong <cyd@gnu.org>
442 * gnutls.c (emacs_gnutls_deinit): New function.
443 Deallocate credentials structures as well as calling gnutls_deinit.
444 (Fgnutls_deinit, Fgnutls_boot): Use it.
446 * process.c (make_process): Initialize GnuTLS credentials to NULL.
447 (deactivate_process): Call emacs_gnutls_deinit.
449 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
451 * image.c (x_create_x_image_and_pixmap):
452 * w32.c (sys_rename, w32_delayed_load):
453 * w32font.c (fill_in_logfont):
454 * w32reg.c (x_get_string_resource): Silence compiler warnings.
456 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
458 * w32fns.c (w32_default_color_map): New function,
459 extracted from Fw32_default_color_map.
460 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
462 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
464 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
466 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
468 * keyboard.c (test_undefined): New function (bug#9751).
469 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
471 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
473 * sysdep.c (init_sys_modes): Fix the check for the controlling
476 2011-10-20 Eli Zaretskii <eliz@gnu.org>
478 * dispextern.h (struct bidi_it): New member next_en_type.
480 * bidi.c (bidi_line_init): Initialize the next_en_type member.
481 (bidi_resolve_explicit_1): When next_en_pos is valid for the
482 current character, check also for next_en_type being WEAK_EN.
483 (bidi_resolve_weak): Don't enter the expensive loop if the current
484 position is before next_en_pos. Record the bidi type of the first
485 non-ET, non-BN character we find, in addition to its position.
486 (bidi_level_of_next_char): Invalidate next_en_type when
487 next_en_pos is over-stepped.
489 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
491 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
492 * editfns.c: Rewrite current-time-zone so that it invokes
493 the equivalent of (format-time-string "%Z") to get the time zone name.
494 This fixes a bug when the time zone name contains characters that
495 need converting from the system time locale to Emacs internal format.
496 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
497 that patch fixed format-time-string to do the conversion, but
498 I forgot to fix current-time-zone.
499 (format_time_string): New function, containing most of
500 what Fformat_time_string used to contain.
501 (Fformat_time_string): Rewrite in terms of format_time_string.
502 This doesn't change this function's behavior.
503 (current-time-zone): Rewrite to use format_time_string.
504 This fixes the bug reported by Michael Schierl in
505 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
506 Jason Rumney's 2007-06-07 change worked around this bug, but
508 * systime.h (tzname, timezone): Remove no-longer-used declarations.
510 2011-10-19 Eli Zaretskii <eliz@gnu.org>
512 * xdisp.c (start_display): If the character at POS is displayed
513 via a display vector, reset IT->current.dpvec_index to zero.
514 (try_window_reusing_current_matrix): If a line ends in a display
515 vector or the next line starts in a display vector, continue
516 redrawing the window even though the character position of
517 start_row was reached.
520 2011-10-18 Chong Yidong <cyd@gnu.org>
522 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
523 with nobreak-char-display too.
525 2011-10-18 Eli Zaretskii <eliz@gnu.org>
527 Fix part 3 of bug#9771.
528 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
529 (bidi_resolve_neutral): Don't enter the expensive loop looking for
530 non-neutral characters if the current character is a paragraph
531 separator (a.k.a. Newline). This avoids running the same
532 expensive loop twice, once when we consume the preceding newline
533 and the other time when the line actually needs to be displayed.
534 Avoid the loop when we see neutrals on the base embedding level
535 following a character whose directionality is the same as the
536 paragraph's. This avoids running the expensive loop when a line
537 ends in a long sequence of neutrals, like control characters.
538 Add assertion against STRONG_AL type. Slightly rearrange code
539 that determines the type of a neutral given the first non-neutral
541 (bidi_level_of_next_char): Set next_en_pos to zero when
542 invalidating its info.
544 2011-10-17 Eli Zaretskii <eliz@gnu.org>
546 * xdisp.c (push_display_prop): Determine whether to record string
547 or buffer position by IT->string, not by IT->method. Allow
548 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
549 (move_it_vertically_backward): Don't look for character position
550 immediately after the newline when in a continuation line.
553 2011-10-15 Martin Rudalics <rudalics@gmx.at>
555 * window.c (coordinates_in_window): Rewrite and delabelize
556 vertical border check. (Bug#5357) (Bug#9618)
558 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
560 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
561 errors in XSetWindowBorder (bug#9310).
563 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
565 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
566 avoid crash when xmalloc overrun checking is enabled.
568 2011-10-13 Eli Zaretskii <eliz@gnu.org>
570 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
571 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
572 cursor motion with <left> and <right> arrow keys.
574 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
575 some callers set that themselves.
577 2011-10-12 Eli Zaretskii <eliz@gnu.org>
579 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
580 display string and the previous row comes from the same string and
581 is empty. (Bug#9739) (Bug#9738)
583 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
585 * doc.c (get_doc_string): Encode file name (bug#9735).
587 2011-10-12 Eli Zaretskii <eliz@gnu.org>
589 * bidi.c (bidi_level_of_next_char):
590 * xdisp.c (get_visually_first_element): Remove old incorrect
591 comments regarding the Unicode Line Separator character.
593 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
595 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
597 * alloc.c (Fgc_status): Do not access beyond zombies array
598 boundary if nzombies > MAX_ZOMBIES.
599 * alloc.c (dump_zombies): Add missing format specifier.
601 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
603 * xdisp.c (set_cursor_from_row): Simplify conditionals,
604 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
606 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
607 Some packages use them to denote characters with modifiers.
609 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
611 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
612 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
613 matching a pp-number. Rename parameter var to var1.
615 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
617 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
619 2011-10-08 Glenn Morris <rgm@gnu.org>
621 * callint.c (Fcall_interactively): Give a more explicit error for the
622 'c' case with a non-character input. (Bug#8479)
624 2011-10-08 Eli Zaretskii <eliz@gnu.org>
626 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
628 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
629 lines that are hscrolled on the left.
631 * dispnew.c (buffer_posn_from_coords): Account for a possible
632 presence of header-line. (Bug#4426)
634 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
636 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
637 Don't advertise functionality which we discourage or doesn't work.
639 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
641 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
642 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
643 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
644 this makes Emacs dump core during garbage collection on rare
645 occasions. sizeof is obviously inferior to offsetof here, so
647 (GC_POINTER_ALIGNMENT): New macro.
648 (mark_memory): Omit 3rd (offset) arg; caller changed.
649 Don't assume EMACS_INT alignment is the same as pointer alignment.
651 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
653 * keyboard.c (read_key_sequence_remapped): New var.
654 (read_key_sequence): Compute remapping in the right buffer.
655 (command_loop_1): Use read_key_sequence's remapping directly.
657 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
659 * dired.c (file_name_completion): Don't expand file name.
660 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
661 before checking file name handler.
663 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
664 they've been requested explicitly (bug#9591).
666 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
668 * keymap.c (Fsingle_key_description): Use make_specified_string
669 instead of build_string to build string from push_key_description.
672 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
674 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
675 This fixes a Y2038 bug on 64-bit hosts.
676 * buffer.c (reset_buffer):
677 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
678 (Fclear_buffer_auto_save_failure):
679 Use 0, not -1, to represent an unset failure time, since time_t
682 Remove dependency on glibc malloc internals.
683 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
684 Move back here from lisp.h, but with their new implementations.
685 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
686 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
687 * charset.c (charset_table_init): New static var.
688 (syms_of_charset): Use it instead of xmalloc. This removes a
689 dependency on glibc malloc internals. See Eli Zaretskii's comment in
690 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
691 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
692 Move back to alloc.c.
693 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
694 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
696 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
698 * nsterm.m (windowDidResize): Call x_set_window_size only when
699 ns_in_resize is true. Otherwise set pixelwidth/height and
700 call change_frame_size (Bug#9628).
702 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
704 Port --enable-checking=all to Fedora 14 x86-64.
705 * charset.c (syms_of_charset): Also account for glibc malloc's
706 internal overhead when calculating the initial malloc maximum.
708 Port --enable-checking=all to Fedora 14 x86.
709 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
711 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
712 (overrun_check_realloc, overrun_check_free):
713 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
714 That way, xmalloc returns a properly-aligned pointer even if
715 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
716 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
717 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
718 into account when calculating the initial malloc maximum.
719 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
720 Move here from alloc.c, so that charset.c can use it too.
721 Properly align; the old code wasn't right for common 32-bit hosts
722 when configured with --enable-checking=all.
723 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
724 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
726 2011-09-29 Eli Zaretskii <eliz@gnu.org>
728 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
731 2011-09-28 Eli Zaretskii <eliz@gnu.org>
733 * xdisp.c (compute_display_string_end): If there's no display
734 string at CHARPOS, return -1.
736 * bidi.c (bidi_fetch_char): When compute_display_string_end
737 returns a negative value, treat the character as a normal
738 character not covered by a display string. (Bug#9624)
740 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
742 * lread.c (Fread_from_string): Fix typo in docstring.
744 2011-09-27 Eli Zaretskii <eliz@gnu.org>
746 * xdisp.c (handle_invisible_prop): If invisible text ends on a
747 newline, reseat the iterator instead of bidi-iterating there one
748 character at a time. (Bug#9610)
749 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
750 TO_CHARPOS if the bidi iterator is at base embedding level.
752 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
754 * lread.c (readevalloop): Use correct code for NBSP.
755 (read1): Likewise. (Bug#9608)
757 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
759 * dbusbind.c (Fdbus_register_signal): When service is not
760 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
762 2011-09-25 Glenn Morris <rgm@gnu.org>
764 * buffer.c (truncate-lines): Doc fix.
766 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
768 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
769 (Fset_window_next_buffers): Doc fix.
771 2011-09-24 Glenn Morris <rgm@gnu.org>
773 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
775 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
777 Fix minor problems found by static checking.
778 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
779 * indent.c (Fvertical_motion): Fix == vs = typo.
781 2011-09-24 Eli Zaretskii <eliz@gnu.org>
783 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
784 Default value is now t. Doc fix.
786 * indent.c (Fvertical_motion): Compute and apply the overshoot
787 logic when moving up, not only when moving down. Fix the
788 confusing name and values of the it_overshoot_expected variable;
789 logic changes accordingly. (Bug#9254) (Bug#9549)
791 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
792 CHARPOS is covered by a display string which includes newlines.
793 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
794 is covered by a display string with embedded newlines.
796 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
798 * dbusbind.c (Fdbus_register_signal): Add match rule to
799 Vdbus_registered_objects_table. (Bug#9581)
800 (Fdbus_register_method, Vdbus_registered_objects_table):
803 2011-09-24 Jim Meyering <meyering@redhat.com>
805 do not ignore write error for any output size
806 The previous change was incomplete.
807 While it makes emacs --batch detect the vast majority of stdout
808 write failures, errors were still ignored whenever the output size is
809 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
810 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
811 && echo FAIL: ignored write error
812 FAIL: ignored write error
813 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
814 && echo FAIL: ignored write error
815 FAIL: ignored write error
816 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
818 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
820 * emacs.c (Fkill_emacs): In noninteractive mode exit
821 non-successfully if a write error occurred on stdout. (Bug#9574)
823 2011-09-21 Eli Zaretskii <eliz@gnu.org>
825 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
828 * dispextern.h (struct it): Update the comment documenting what
831 2011-09-20 Eli Zaretskii <eliz@gnu.org>
833 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
834 a display string, extend search for cursor position to end of row.
835 (find_row_edges): If the row ends in a newline from a display
836 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
837 Handle the case of a display string with multiple newlines.
838 (Fcurrent_bidi_paragraph_direction): Fix search for previous
839 non-empty line. Fixes confusing cursor motion with arrow keys at
840 the beginning of a line that starts with whitespace.
842 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
844 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
847 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
849 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
852 2011-09-18 Eli Zaretskii <eliz@gnu.org>
854 * xdisp.c (display_line): Record maximum and minimum buffer
855 positions even if no glyphs were produced (e.g., by a zero-width
856 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
857 buffer positions that will be removed from the glyph row because
859 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
860 column is beyond frame width: don't subtract 1 "pixel" when
861 computing width of the stretch.
862 (reseat_at_next_visible_line_start): Undo the change made on
863 2011-09-17 that saved paragraph information and restored it after
864 the call to `reseat'. (Bug#9545)
866 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
868 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
869 and turn window cursor on if cleared (Bug#9415).
871 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
873 * search.c (boyer_moore): Take unibyte characters from pattern
874 literally. (Bug#9458)
876 2011-09-18 Eli Zaretskii <eliz@gnu.org>
878 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
880 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
882 Fix minor problem found by static checking.
883 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
884 initialized, to pacify gcc -Wuninitialized.
886 * fileio.c: Report proper errno when syscall falls.
887 (Finsert_file_contents): Save and restore errno,
888 so that report_file_error outputs the correct diagnostic.
889 (Fwrite_region) [CLASH_DETECTION]: Likewise.
891 2011-09-18 Eli Zaretskii <eliz@gnu.org>
893 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
895 2011-09-17 Eli Zaretskii <eliz@gnu.org>
897 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
898 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
900 2011-09-17 Eli Zaretskii <eliz@gnu.org>
902 * xdisp.c (reseat_at_next_visible_line_start): Keep information
903 about the current paragraph and restore it after the call to reseat.
905 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
906 (bidi_find_paragraph_start): Search back for paragraph beginning
907 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
908 (bidi_move_to_visually_next): Only trigger paragraph-related
909 computations when the last character is a newline or at EOB, not
910 just any NEUTRAL_B. (Bug#9470)
912 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
913 truncated lines if point is covered by a display string. (Bug#9524)
915 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
917 * xselect.c: Relax test for outgoing X longs (Bug#9498).
918 (cons_to_x_long): New function.
919 (lisp_data_to_selection_data): Use it. Correct the test for
920 short-versus-long data; it was negated. Break out of vector
921 loop, for efficiency, when a long datum is discovered.
923 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
925 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
927 2011-09-16 Eli Zaretskii <eliz@gnu.org>
929 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
930 GCC PR/17406) by declaring this function with external scope.
932 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
934 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
935 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
937 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
939 * editfns.c (Fformat): Correctly handle text properties on "%%".
941 2011-09-15 Eli Zaretskii <eliz@gnu.org>
943 * xterm.c (x_draw_composite_glyph_string_foreground):
944 * w32term.c (x_draw_composite_glyph_string_foreground):
945 * term.c (encode_terminal_code):
946 * composite.c (composition_update_it, get_composition_id):
947 * xdisp.c (get_next_display_element)
948 (fill_composite_glyph_string): Add comments about special meaning
949 of TAB characters in a composition.
951 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
953 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
954 This occurs when processing a multibyte format.
955 Problem reported by Wolfgang Jenker.
957 2011-09-15 Johan Bockgård <bojohan@gnu.org>
959 * xdisp.c (try_cursor_movement): Only check for exact match if
960 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
962 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
964 Remove unused external symbols.
965 * dispextern.h (calc_pixel_width_or_height): Remove decl.
966 * xdisp.c (calc_pixel_width_or_height): Now static.
967 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
968 * indent.c (check_display_width):
969 * w32term.c: Fix comment to match code.
970 * xterm.c, xterm.h (x_catching_errors): Remove.
972 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
974 * xselect.c: Use signed conversions more consistently (Bug#9498).
975 (selection_data_to_lisp_data): Assume incoming selection data are
976 signed integers, not unsigned. This is to be consistent with
977 outgoing selection data, which was modified to use signed integers
978 in as part of the fix to Bug#9196 in response to Jan D.'s comment
979 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
980 expects long, not unsigned long.
982 2011-09-14 Eli Zaretskii <eliz@gnu.org>
984 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
985 computation of loop end. Reported by Johan Bockgård
988 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
990 * frame.c (Fother_visible_frames_p): Function deleted.
992 2011-09-12 Eli Zaretskii <eliz@gnu.org>
994 * indent.c (compute_motion): Process display vector front to back
995 rather than the other way around. (Bug#2496)
997 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
999 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1001 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1003 * minibuf.c (Fread_from_minibuffer): Doc fix.
1005 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1007 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1008 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1010 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1012 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1013 value for non-existent files.
1015 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1017 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1018 set its "size" to -1. This will set the modtime_size field of
1019 the corresponding buffer to -1, which is what
1020 verify-visited-file-modtime expects for files that do not exist.
1023 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1025 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1027 * lisp.h: ... from here. push_key_description is no longer
1028 defined in keyboard.c, so its declaration should not be in
1029 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1030 logically belongs with push_key_description.
1032 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1034 * buffer.h: Include <sys/types.h> instead of <time.h>.
1035 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1036 Problem reported by Herbert J. Skuhra.
1038 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040 * xml.c (parse_region): Make the parsing work for
1041 non-comment-starting XML files again (bug#9144).
1043 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1045 * image.c (gif_load): Fix calculation of bottom and right corner.
1048 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1050 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1051 redisplay in small windows.
1053 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1055 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1057 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1059 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1060 Operate on live windows only.
1062 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1064 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1066 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1069 only under bidi iteration.
1071 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1073 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1075 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1077 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1078 Without this fix, the command to link temacs failed due to an
1079 undefined symbol __builtin_isnan. This is because
1080 /usr/include/iso/math_c99.h #defines isnan(x) to
1081 __builtin_isnan(x), but the bundled gcc, which identifies itself
1082 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1084 * floatfns.c (isnan): #undef, and then #define to a clone of
1086 (Fisnan): Always define, since it's always available now.
1087 (syms_of_floatfns): Always define isnan at the Lisp level.
1089 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1091 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1093 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1095 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1096 The previous code assumed that file offsets (off_t values) fit in
1097 EMACS_INT variables, which is not true on typical 32-bit hosts.
1098 The code messed up by falsely reporting buffer overflow in cases
1099 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1100 when "big" contains more than 2**29 bytes, even though this
1101 inserts just one byte and does not overflow the buffer.
1102 (Finsert_file_contents): Store file offsets as off_t
1103 values, not as EMACS_INT values. Check for overflow when
1104 converting between EMACS_INT and off_t. When checking for
1105 buffer overflow or for overlap, take the offsets into account.
1106 Don't use EMACS_INT for small values where int suffices.
1107 When checking for overlap, fix a typo: ZV was used where
1108 ZV_BYTE was intended.
1109 (Fwrite_region): Don't assume off_t fits into 'long'.
1110 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1112 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1114 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1116 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1118 sprintf-related integer and memory overflow issues (Bug#9412).
1120 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1121 (esprintf, exprintf, evxprintf): New functions.
1122 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1123 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1124 (modify_event_symbol): Do not assume that the length of
1125 name_alist_or_stem is safe to alloca and fits in int.
1126 (Fexecute_extended_command): Likewise for function name and binding.
1127 (Frecursion_depth): Wrap around reliably on integer overflow.
1128 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1129 since some callers pass EMACS_INT values.
1130 (Fsingle_key_description): Don't crash if symbol name contains more
1131 than MAX_ALLOCA bytes.
1132 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1133 (get_minibuffer): Arg is now EMACS_INT, not int.
1134 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1135 (esprintf, exprintf, evxprintf): New decls.
1136 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1138 * dbusbind.c (signature_cat): New function.
1139 (xd_signature, Fdbus_register_signal):
1140 Do not overrun buffer; instead, report string overflow.
1142 * dispnew.c (add_window_display_history): Don't overrun buffer.
1143 Truncate instead; this is OK since it's just a log.
1145 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1146 even if the time zone offset is outlandishly large.
1147 Don't mishandle offset == INT_MIN.
1149 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1150 when creating daemon; the previous buffer-overflow check was incorrect.
1152 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1153 which has the guts of the old verror function.
1155 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1156 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1158 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1159 (font_unparse_xlfd): Don't blindly alloca long strings.
1160 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1161 fits in int, when using sprintf. Use single snprintf to count
1162 length of string rather than counting it via multiple sprintfs;
1163 that's simpler and more reliable.
1164 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1165 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1166 sprintf, in case result does not fit in int.
1168 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1169 (fontset_from_font): Print it.
1171 * frame.c (tty_frame_count): Now printmax_t, not int.
1172 (make_terminal_frame, set_term_frame_name): Print it.
1173 (x_report_frame_params): In X, window IDs are unsigned long,
1174 not signed long, so print them as unsigned.
1175 (validate_x_resource_name): Check for implausibly long names,
1176 and don't assume name length fits in 'int'.
1177 (x_get_resource_string): Don't blindly alloca invocation name;
1178 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1181 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1182 (xg_check_special_colors, xg_set_geometry):
1183 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1185 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1186 Use esprintf, not sprintf, in case result does not fit in int.
1188 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1189 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1190 it as a large positive number.
1191 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1192 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1194 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1195 in case result does not fit in int.
1197 * print.c (float_to_string): Detect width overflow more reliably.
1198 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1199 buffer overrun. Don't assume list length fits in 'int'. Treat
1200 print length of 0 as 0, not as infinity; to be consistent with other
1201 uses of print length in this function. Don't overflow print length
1202 index. Don't assume hash table size fits in 'long', or that
1203 vectorlike size fits in 'unsigned long'.
1205 * process.c (make_process): Use printmax_t, not int, to format
1206 process-name gensyms.
1208 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1210 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1211 to avoid potential buffer overrun.
1213 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1214 if X resource line is longer than 512 bytes.
1216 * xfns.c (x_window): Make sprintf buffer a bit bigger
1217 to avoid potential buffer overrun.
1219 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1221 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1223 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1225 Integer overflow fixes for scrolling, etc.
1226 Without these, Emacs silently mishandles large integers sometimes.
1227 For example, "C-u 4294967297 M-x recenter" was treated as if
1228 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1230 * xdisp.c (try_window_id): Check Emacs fixnum range before
1231 converting to 'int'.
1233 * window.c (window_scroll_line_based, Frecenter):
1234 Check that an Emacs fixnum is in range before assigning it to 'int'.
1235 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1236 values converted from Emacs fixnums.
1237 (Frecenter): Don't wrap around a line count if it is out of 'int'
1238 range; instead, treat it as an extreme value.
1239 (Fset_window_configuration, compare_window_configurations):
1240 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1242 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1243 that can exceed INT_MAX. Check that EMACS_INT value is in range
1244 before assigning it to the (possibly-narrower) index.
1245 (match_limit): Don't assume that a fixnum can fit in 'int'.
1247 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1250 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1251 (Fvertical_motion): Don't wrap around LINES values that don't fit
1252 in 'int'. Instead, treat them as extreme values. This is good
1253 enough for windows, which can't have more than INT_MAX lines anyway.
1255 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1257 * Require libxml/parser.h to avoid compilation warning.
1259 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1261 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1262 since this reportedly can destroy thread storage.
1264 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1266 * syntax.c (find_defun_start): Update all cache variables if
1267 exiting early (Bug#9401).
1269 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1271 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1273 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1274 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1275 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1277 * term.c (tty_append_glyph): New function.
1278 (produce_stretch_glyph): Static function and its prototype deleted.
1280 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1283 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1285 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1286 when checking :margin (Bug#9390).
1287 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1288 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1289 so that the name doesn't mislead. All uses changed.
1291 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1293 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1296 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1298 * xdisp.c (move_it_to): Don't bail out early when reaching
1299 position beyond to_charpos, if we are scanning backwards.
1300 (move_it_vertically_backward): When DY == 0, make sure we get to
1301 the first character in the line after the newline.
1303 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1305 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1306 (ccl_driver): Do not generate an out-of-range pointer.
1307 (Fccl_execute_on_string): Remove unnecessary check for
1308 integer overflow, noted by Stefan Monnier in
1309 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1310 Remove a FIXME that didn't need fixing.
1311 Simplify the newly-introduced buffer reallocation code.
1313 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1315 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1317 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1319 Integer and memory overflow issues (Bug#9196).
1321 * doc.c (get_doc_string): Rework so that
1322 get_doc_string_buffer_size is the actual buffer size, rather than
1323 being 1 less than the actual buffer size; this makes xpalloc more
1326 * image.c (x_allocate_bitmap_record, cache_image):
1327 * xselect.c (Fx_register_dnd_atom):
1328 Simplify previous changes by using xpalloc.
1330 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1331 since either will do and ptrdiff_t is convenient with xpalloc.
1333 * charset.c (charset_table_size)
1334 (struct charset_sort_data.priority): Now ptrdiff_t.
1335 (charset_compare): Don't overflow if priorities differ greatly.
1336 (Fsort_charsets): Don't assume list length fits in int.
1337 Check for size-calculation overflow when allocating sort data.
1338 (syms_of_charset): Allocate an initial charset table that is
1339 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1341 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1343 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1344 The actual value is always <= INT_MAX, and leaving it unsigned made
1345 overflow checking harder.
1347 * dispextern.h (struct glyph_matrix.rows_allocated)
1348 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1349 with xpalloc. The values are still always <= INT_MAX.
1351 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1353 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1354 (SAFE_NALLOCA): New macro.
1356 * region-cache.c (struct boundary.pos, find_cache_boundary)
1357 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1358 (set_cache_region, invalidate_region_cache)
1359 (revalidate_region_cache, know_region_cache, region_cache_forward)
1360 (region_cache_backward, pp_cache):
1361 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1362 so that ptrdiff_t * can be passed to xpalloc.
1363 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1364 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1365 (pp_cache): Don't assume cache_len fits in int.
1366 * region-cache.h: Adjust extern decls to match.
1368 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1369 EMACS_INT, since either will do, for xpalloc.
1371 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1372 (xnmalloc, xnrealloc, xpalloc): New functions.
1374 * bidi.c (bidi_shelve_header_size): New constant.
1375 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1376 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1378 * bidi.c (bidi_cache_shrink):
1379 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1381 Don't update size of array until after memory allocation succeeds,
1382 because xmalloc/xrealloc may not return.
1383 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1384 now that we have proper integer overflow checking.
1385 (record_overlay_string, overlay_strings): Catch overflows when
1386 calculating size of overlay_str_buf.
1388 * callproc.c (Fcall_process): Check for size overflow when
1389 calculating size of args2.
1390 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1391 Normally we prefer signed values, but sticking with ptrdiff_t would
1392 require adding more-complicated checks.
1394 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1395 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1396 Redo buffer-overflow calculations to avoid integer overflow.
1397 Add a FIXME comment where memory seems to be over-allocated.
1399 * character.c (Fstring): Check for size-calculation overflow.
1401 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1402 unnecessary integer overflow. Check for size overflow.
1403 (encode_coding_object): Don't update size until xmalloc succeeds.
1405 * composite.c (get_composition_id): Check for overflow in glyph
1406 length calculations.
1408 Integer and memory overflow fixes for display code.
1409 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1410 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1411 (scrolling_window): Check for overflow in size calculations.
1412 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1413 Don't assume glyph table len fits in int.
1414 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1415 (row_table_size): Now ptrdiff_t, not int.
1416 (scrolling_window): Avoid overflow in size calculations.
1417 Don't update size until allocation succeeds.
1418 * fns.c (concat): Check for overflow in size calculations.
1419 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1420 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1421 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1423 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1424 (get_doc_string): Check for size calculation overflow.
1425 Don't update size until allocation succeeds.
1426 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1427 EMACS_INT, where ptrdiff_t will do.
1428 (Fsubstitute_command_keys): Check for string overflow.
1430 * editfns.c (set_time_zone_rule): Don't assume environment length
1432 (message_length): Now ptrdiff_t, not int.
1433 (Fmessage_box): Don't update size until allocation succeeds.
1434 Don't assume message length fits in int.
1435 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1437 * emacs.c (main): Do not reallocate argv, since there is a null at
1438 the end that can be overwritten, and this way there's no need to
1439 worry about size-calculation overflow.
1440 (sort_args): Check for size-calculation overflow.
1442 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1444 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1446 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1447 (x_set_scroll_bar_width, x_figure_window_size):
1448 Check for integer overflow.
1449 (x_set_alpha): Do not assume XINT fits in int.
1451 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1452 This is for the members text_lines, text_cols, total_lines, total_cols,
1453 where the system imposes an 'int' limit.
1455 * fringe.c (Fdefine_fringe_bitmap):
1456 Don't update size until alloc works.
1458 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1459 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1461 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1462 Check for size-calculation overflow.
1463 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1464 do, as we prefer signed integers.
1465 (id_to_widget.max_size, id_to_widget.used)
1466 (xg_store_widget_in_map, xg_remove_widget_from_map)
1467 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1468 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1469 Use and return ptrdiff_t, not int.
1470 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1471 * gtkutil.h: Change prototypes to match the above.
1473 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1474 are duplicate now that they've been promoted to lisp.h.
1475 (x_allocate_bitmap_record, x_alloc_image_color)
1476 (make_image_cache, cache_image, xpm_load):
1477 Don't update size until alloc is done.
1478 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1480 Check for size calculation overflow.
1481 (ct_colors_allocated_max): New constant.
1482 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1485 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1486 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1487 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1488 Use ptrdiff_t, not int, to count maps.
1489 (read_char_minibuf_menu_prompt): Check for overflow in size
1490 calculations. Don't update size until allocation succeeds.
1491 Redo calculations to avoid overflow.
1492 * keyboard.h: Change prototypes to match the above.
1494 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1496 (current_minor_maps): Check for size calculation overflow.
1497 * keymap.h: Change prototypes to match the above.
1499 * lread.c (read1, init_obarray): Don't update size until alloc done.
1501 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1502 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1504 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1505 Now ptrdiff_t, not int.
1506 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1507 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1509 * process.c (Fnetwork_interface_list): Check for overflow
1510 in size calculation.
1512 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1514 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1515 overflow. Don't bother calling xmalloc when xrealloc will do.
1517 * search.c (Freplace_match): Check for size calculation overflow.
1518 (Fset_match_data): Don't assume list lengths fit in 'int'.
1520 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1521 for command line length. Do not attempt to address one before the
1522 beginning of an array, as that's not portable.
1524 * term.c (max_frame_lines): Remove; unused.
1525 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1527 (encode_terminal_code, calculate_costs): Check for size
1528 calculation overflow.
1529 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1530 table lengths and related sizes. Don't update size until alloc
1531 done. Redo calculations to avoid overflow.
1532 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1534 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1535 subtracting pointers.
1536 (gobble_line): Check for overflow more carefully. Don't update size
1539 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1540 Don't update size until alloc done.
1541 Redo size calculations to avoid overflow.
1542 Check for size calculation overflow.
1543 (main) [DEBUG]: Fix typo in invoking tparam1.
1545 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1546 Use ptrdiff_t, not int, for sizes.
1547 (store_mode_line_noprop_char): Don't update size until alloc done.
1549 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1550 Use ptrdiff_t, not int, for sizes.
1551 (Finternal_make_lisp_face, cache_face):
1552 Check for size calculation overflow.
1553 (cache_face): Treat size calculation overflows as if they were
1554 memory exhaustion (the usual treatment), rather than aborting.
1556 * xfns.c (x_encode_text, x_set_name_internal)
1557 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1558 sizes, since they can exceed INT_MAX in size. Check for size
1559 calculation overflow.
1561 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1562 (xg_select): Check for size calculation overflow.
1563 Don't update size until alloc done.
1565 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1566 as sprintf is limited to int lengths.
1568 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1569 (X_LONG_MIN): New macros.
1570 Use them to make the following changes clearer.
1571 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1572 This change doesn't affect the value now, but it may help remind
1573 future maintainers not to raise the value too much later.
1574 (SELECTION_QUANTUM): Remove, replacing with ...
1575 (selection_quantum): ... new function, which avoids overflow.
1577 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1578 assumption that selection length fits in 'int'.
1579 (x_reply_selection_request, x_handle_selection_request)
1580 (x_get_window_property, receive_incremental_selection)
1581 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1582 (lisp_data_to_selection_data, clean_local_selection_data):
1583 Use ptrdiff_t, not int, to record length of selection.
1584 (x_reply_selection_request, x_get_window_property)
1585 (receive_incremental_selection, x_property_data_to_lisp):
1586 Redo calculations to avoid overflow.
1587 (x_reply_selection_request): When sending hint, ceiling it at
1588 X_LONG_MAX rather than relying on wraparound overflow to send
1590 (x_get_window_property, receive_incremental_selection)
1591 (lisp_data_to_selection_data, x_property_data_to_lisp):
1592 Check for size-calculation overflow.
1593 (x_get_window_property, receive_incremental_selection)
1594 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1595 Don't store size until memory allocation succeeds.
1596 (x_get_window_property): Plug memory leak on memory exhaustion.
1597 Don't double-block input; malloc is safe here. Don't assume 2**34
1598 - 4 fits in unsigned long. Add an xassert to check
1599 XGetWindowProperty overflow. Be more careful about overflow
1600 calculations, and distinguish size from memory overflow better.
1601 (receive_incremental_selection): When tracing, don't assume
1602 unsigned int is less than INT_MAX.
1603 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1604 harmful) conversions of unsigned short to int.
1605 (lisp_data_to_selection_data): Don't assume that integers
1606 in the range -65535 through -1 fit in an X unsigned short.
1607 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1608 result parameters unless successful. Rely on cons_to_unsigned
1609 to report problems with elements; the old code wasn't right anyway.
1610 (x_check_property_data): Check for int overflow; we cannot use
1611 a wider type due to X limits.
1612 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1614 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1616 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1617 (x_term_init): Check for size calculation overflow.
1618 (x_color_cells): Don't store size until memory allocation succeeds.
1619 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1620 Don't assume alloca size is less than MAX_ALLOCA.
1621 (x_term_init): Don't assume length fits in int (sprintf is limited
1624 Use ptrdiff_t for composition IDs.
1625 * character.c (lisp_string_width):
1626 * composite.c (composition_table_size, n_compositions)
1627 (get_composition_id, composition_gstring_from_id):
1628 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1629 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1630 * window.c (Frecenter):
1631 Use ptrdiff_t, not int, for composition IDs.
1632 * composite.c (get_composition_id): Check for integer overflow.
1633 * composite.h: Adjust prototypes to match the above changes.
1635 Use ptrdiff_t for hash table indexes.
1636 * category.c (hash_get_category_set):
1637 * ccl.c (ccl_driver):
1638 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1639 * coding.c (coding_system_charset_list, detect_coding_system):
1640 * coding.h (struct coding_system.id):
1641 * composite.c (get_composition_id, gstring_lookup_cache):
1642 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1643 * image.c (xpm_get_color_table_h):
1644 * lisp.h (hash_lookup, hash_put):
1645 * minibuf.c (Ftest_completion):
1646 Use ptrdiff_t for hash table indexes, not int (which is too
1647 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1648 32-bit --with-wide-int hosts).
1650 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1651 Add a FIXME comment about memory leaks.
1652 (syms_of_charset): Don't assume xmalloc returns.
1654 Don't assume that stated character widths fit in int.
1655 * character.c (Fchar_width, c_string_width, lisp_string_width):
1656 * character.h (CHAR_WIDTH):
1657 * indent.c (MULTIBYTE_BYTES_WIDTH):
1658 Use sanitize_char_width to avoid undefined and/or bad behavior
1659 with outlandish widths.
1660 * character.h (sanitize_tab_width): Rename from sanitize_width,
1661 now that we have two such functions. All uses changed.
1662 (sanitize_char_width): New inline function.
1664 Don't assume that tab-width fits in int.
1665 * character.h (sanitize_width): New inline function.
1666 (SANE_TAB_WIDTH): New macro.
1667 (ASCII_CHAR_WIDTH): Use it.
1668 * indent.c (sane_tab_width): Remove. All uses replaced by
1669 SANE_TAB_WIDTH (current_buffer).
1670 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1672 * fileio.c: Integer overflow issues with file modes.
1673 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1675 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1676 Remove unreachable code.
1677 (read_hex, load_charset_map_from_file): Check for integer overflow.
1679 * xterm.c: don't go over XClientMessageEvent limit
1680 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1681 (x_send_scroll_bar_event): Likewise. Check that the size does not
1682 exceed limits imposed by XClientMessageEvent, as well as the usual
1683 ptrdiff_t and size_t limits.
1685 * keyboard.c: Overflow, signedness and related fixes.
1686 (make_lispy_movement): Use same integer type in forward decl
1687 that is used in the definition.
1688 (read_key_sequence, keyremap_step):
1689 Change bufsize argument back to int, undoing my 2011-03-30 change.
1690 We prefer signed types, and int is wide enough here.
1691 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1692 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1693 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1694 length, not size_t. Use ptrdiff_t for index, not int.
1695 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1696 possibility of integer overflow.
1698 Overflow, signedness and related fixes for images.
1700 * dispextern.h (struct it.stack[0].u.image.image_id)
1701 (struct_it.image_id, struct image.id, struct image_cache.size)
1702 (struct image_cache.used, struct image_cache.ref_count):
1703 * gtkutil.c (update_frame_tool_bar):
1704 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1705 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1706 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1707 * nsmenu.m (update_frame_tool_bar):
1708 * xdisp.c (calc_pixel_width_or_height):
1709 * xfns.c (image_cache_refcount):
1710 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1711 on typical 64-bit hosts.
1713 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1714 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1715 Omit unnecessary casts to int.
1716 (parse_image_spec): Check that integers fall into 'int' range
1717 when the callers expect that.
1718 (image_ascent): Redo ascent calculation to avoid int overflow.
1719 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1720 (lookup_image): Remove unnecessary tests.
1721 (xbm_image_p): Locals are now of int, not EMACS_INT,
1722 since parse_image_check makes sure they fit into int.
1723 (png_load, gif_load, svg_load_image):
1724 Prefer int to unsigned where either will do.
1725 (tiff_handler): New function, combining the cores of the
1726 old tiff_error_handler and tiff_warning_handler.
1727 This function is rewritten to use vsnprintf and thereby avoid
1728 stack buffer overflows. It uses only the features of vsnprintf
1729 that are common to both POSIX and native Microsoft.
1730 (tiff_error_handler, tiff_warning_handler): Use it.
1731 (tiff_load, gif_load, imagemagick_load_image):
1732 Don't assume :index value fits in 'int'.
1733 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1734 (imagemagick_load_image): Check that crop parameters fit into
1735 the integer types that MagickCropImage accepts. Don't assume
1736 Vimagemagick_render_type has a nonnegative value. Don't assume
1737 size_t fits in 'long'.
1738 (gs_load): Use printmax_t to print the widest integers possible.
1739 Check for integer overflow when computing image height and width.
1741 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1743 * xdisp.c (redisplay_window): Don't force window start if point
1744 will be invisible in the resulting window. (Bug#9324)
1746 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1748 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1749 the display spec is of the form `(space ...)'.
1750 (handle_display_spec): Return the value returned by
1751 handle_single_display_spec, not just 1 or zero.
1752 (handle_single_display_spec): If the display spec is of the form
1753 `(space ...)', and specifies display in the text area, return 2
1755 (try_cursor_movement): Check for the need to scroll more
1756 accurately, and prefer exact match for point under bidi.
1757 Don't advance `row' beyond the last row of the window.
1759 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1760 into disp_prop; all users changed.
1762 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1763 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1764 for the text covered by the display property.
1766 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1768 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1769 Change return value to nil.
1770 (Frecord_buffer): Delete unused function.
1772 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1774 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1775 buffers, return left-to-right.
1776 (set_cursor_from_row): Consider candidate row a win if its glyph
1777 represents a newline and point is on that newline. Fixes cursor
1778 positioning on the newline at EOL of R2L text within L2R
1779 paragraph, and vice versa.
1780 (try_cursor_movement): Check continued rows, in addition to
1781 continuation rows. Fixes unwarranted scroll when point enters a
1782 continued line of R2L text within an L2R paragraph, or vice versa.
1783 (cursor_row_p): Consider the case of point being equal to
1784 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1785 from the end of a short line to the beginning of a continued line
1786 of R2L text within L2R paragraph.
1787 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1788 composed characters.
1790 * bidi.c (bidi_check_type): Use xassert.
1791 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1794 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1796 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1799 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1801 * nsfont.m (ns_otf_to_script): Fix typo.
1803 2011-08-22 Kenichi Handa <handa@m17n.org>
1805 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1806 extra slot even if the purpose is char-code-property-table.
1808 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1810 * xdisp.c (redisplay_window): When computing centering_position,
1811 account for the height of the header line. (Bug#8874)
1813 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1814 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1815 candidate is selected by the mouse, and that candidate has a
1816 composed character under the mouse.
1818 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1819 coordinates reported by pos-visible-in-window-p for a composed
1820 character in column zero.
1822 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1824 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1826 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1828 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1829 consider it a hit if to_charpos is anywhere in the range of the
1830 composed buffer positions.
1832 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1834 * image.c (gif_load): Don't assume that each subimage has the same
1835 dimensions as the base image. Handle disposal method that is
1836 "undefined" by the gif spec (Bug#9335).
1838 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1840 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1841 (Fcondition_case): Document `debug' symbol in error handler.
1843 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1845 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1846 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1847 from an Org mode buffer to a Speedbar frame.
1849 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1850 a composition, take its buffer position from IT->cmp_it.charpos.
1851 Fixes cursor positioning at the beginning of a line that begins
1852 with a composed character.
1854 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1856 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1857 character bidirectional type, use STRONG_L instead. Fixes crashes
1858 in a buffer produced by `describe-categories'.
1860 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1861 members before the level stack, so they would be saved and
1862 restored when copying iterator state. Fixes incorrect reordering
1863 around TABs covered by display properties.
1865 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1867 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1869 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1871 * eval.c (internal_condition_case, internal_condition_case_1)
1872 (internal_condition_case_2, internal_condition_case_n):
1873 Remove unnecessary aborts (Bug#9081).
1875 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1877 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1878 has no `load' handler, try opening the file locally. (Bug#9311)
1880 2011-08-16 Ken Brown <kbrown@cornell.edu>
1882 * gmalloc.c: Expand comment.
1884 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1886 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1887 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1889 2011-08-16 Ken Brown <kbrown@cornell.edu>
1891 Fix memory allocation problems in Cygwin build (Bug#9273).
1893 * unexcw.c ( __malloc_initialized): Declare external variable.
1894 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1896 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1898 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1900 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1902 [CYGWIN] (special_realloc): New function.
1903 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1904 requests to realloc storage in the static heap.
1906 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1908 * bidi.c (bidi_initialize): Remove unused local.
1910 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1913 * biditype.h: Remove file.
1914 * makefile.w32-in ($(BLD)/bidi.$(O)):
1915 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1917 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1919 * chartab.c: Improve commentary for the uniprop_table API.
1921 * bidi.c (bidi_paragraph_init): Support zero value of
1922 bidi_ignore_explicit_marks_for_paragraph_level.
1923 (bidi_initialize): Use uniprop_table instead of including
1924 biditype.h and bidimirror.h.
1926 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1927 coordinates of the iterator when restoring from ppos_it.
1930 2011-08-14 Kenichi Handa <handa@m17n.org>
1932 * process.c (create_process): Call setup_process_coding_systems
1933 after the pid of the process is set to -1 (Bug#8162).
1935 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1937 * xdisp.c (move_it_in_display_line_to): Don't invoke
1938 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1939 ppos_it. Fixes vertical cursor motion when line beginning is
1940 covered by an image. (Bug#9296)
1942 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1944 * nsterm.h (ns_run_ascript): Declare.
1945 (NSAPP_DATA2_RUNASSCRIPT): Define.
1947 * nsfns.m (as_script, as_result, as_status): New static variables.
1948 (ns_run_ascript): New function.
1949 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1950 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1951 the event loop. Get status from as_status (Bug#7276).
1953 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1954 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1955 the event loop (Bug#7276).
1957 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1959 * gnutls.c (QCgnutls_bootprop_priority)
1960 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1961 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1962 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1963 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1964 (QCgnutls_bootprop_verify_hostname_error)
1965 (QCgnutls_bootprop_callbacks_verify): Rename from
1966 Qgnutls_bootprop_..., all uses changed.
1968 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1971 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1973 * xfaces.c (Qframe_set_background_mode): Now static.
1974 * dispextern.h (Qframe_set_background_mode): Remove decl.
1976 * process.c (Fnetwork_interface_info): Declare local only if needed.
1978 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1980 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1981 (Fnetwork_interface_list): Allocate in increments of bytes instead
1982 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1983 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1985 (struct ifflag_def): notrailers is smart on OSX.
1986 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1987 Get hardware address with getifaddrs if available.
1989 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1991 * xdisp.c (iterate_out_of_display_property): xassert that
1992 IT->position is set to within IT->object's boundaries. Break from
1993 the loop as soon as EOB is reached; avoids infloops in redisplay
1994 when IT->position is set up wrongly due to some bug.
1995 Set IT->current to match the bidi iterator unconditionally.
1996 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1997 entry. Force push_it to save on the stack the current
1998 buffer/string position, to be restored by pop_it. Fix flags in
1999 the iterator structure wrt the object coming from a display
2000 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2001 properties. (Bug#9284)
2003 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2005 * fontset.c (fontset_get_font_group): Add proper type checks.
2008 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2010 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2011 and LC_VERSION_MIN_MACOSX.
2012 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2013 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2015 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2017 * xdisp.c (forward_to_next_line_start): Allow to use the
2018 no-display-properties-and-no-overlays under bidi display.
2019 Set disp_pos in the bidi iterator to avoid searches for display
2020 properties and overlays.
2022 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2024 * editfns.c (Fset_time_zone_rule): Document relationship with the
2027 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2028 the font entity extracted from the cache (Bug#8109).
2030 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2032 * composite.c (autocmp_chars): Don't reset point. That is done by
2033 restore_point_unwind (Bug#5984).
2035 2011-08-07 Juri Linkov <juri@jurta.org>
2037 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2038 to show the arg `TIME' instead of `TIMEVAL'.
2040 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2043 display property strides EOL and includes a newline, as in
2044 longlines-mode. (Bug#9254)
2045 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2046 word-wrap under bidirectional display. (Bug#9224)
2048 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2049 is non-zero, even if the data buffer is NULL. Fixes a crash in
2050 vertical-motion with longlines-mode. (Bug#9254)
2052 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2054 * bidi.c <bidi_cache_total_alloc>: Now static.
2055 (bidi_initialize): Initialize bidi_cache_total_alloc.
2057 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2060 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2061 amount allocated this far in `bidi_cache_total_alloc'.
2062 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2063 non-zero, only free the data buffer without restoring the cache
2064 contents. All callers changed.
2066 * dispextern.h (bidi_unshelve_cache): Update prototype.
2068 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2069 (move_it_in_display_line, move_it_to)
2070 (move_it_vertically_backward, move_it_by_lines): Replace the call
2071 to xfree to an equivalent call to bidi_unshelve_cache.
2072 (move_it_in_display_line_to): Fix logic of returning
2073 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2075 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2078 came from a string character with a `cursor' property. (Bug#9229)
2080 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2082 * Makefile.in (LIB_PTHREAD): New variable.
2083 (LIBES): Add LIB_PTHREAD (Bug#9216).
2085 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2086 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2088 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2090 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2092 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2094 * xterm.c (x_find_topmost_parent): New function.
2095 (x_set_frame_alpha): Find topmost parent window with
2096 x_find_topmost_parent and set the property there also (bug#9181).
2097 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2099 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2101 * callproc.c (Fcall_process): Avoid vfork clobbering
2102 the local vars buffer, coding_systems, current_dir.
2104 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2106 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2108 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2110 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2111 so that it is not optimized away.
2113 * xdisp.c (compute_display_string_pos): Remove unused local.
2115 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2117 Fix slow cursor motion and scrolling in large buffers with
2118 selective display, like Org Mode buffers. (Bug#9218)
2120 * dispextern.h (struct bidi_it): New member disp_prop_p.
2122 * xdisp.c: Remove one-slot cache of display string positions.
2123 (compute_display_string_pos): Accept an additional argument
2124 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2125 for a display string or property. If found, set DISP_PROP_P
2128 * bidi.c (bidi_fetch_char): Accept an additional argument
2129 DISP_PROP_P, and pass it to compute_display_string_pos.
2130 Only handle text covered by a display string if DISP_PROP_P is returned
2131 non-zero. All callers of bidi_fetch_char changed.
2133 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2135 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2137 2010-12-03 Don March <don@ohspite.net>
2139 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2140 last character M-[char] is translated to ESC [char] (bug#7541).
2142 2011-08-02 Kenichi Handa <handa@m17n.org>
2144 * lisp.h (uniprop_table): Extern it.
2146 * chartab.c (uniprop_table): Make it non-static.
2148 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2150 * xdisp.c (forward_to_next_line_start): Accept additional argument
2151 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2153 (reseat_at_next_visible_line_start): Use the bidi iterator state
2154 returned by forward_to_next_line_start to restore the state of
2155 it->bidi_it after backing up to previous newline. (Bug#9212)
2157 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2159 * regex.c (re_comp): Protoize.
2160 (re_exec): Fix return type.
2161 (regexec): Fix type of `ret'. (Bug#9203)
2163 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2165 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2166 This is needed if max-image-size is a floating-point number.
2168 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2170 * print.c (print_object): Print empty symbol as ##.
2172 * lread.c (read1): Read ## as empty symbol.
2174 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2176 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2177 setting frame foreground color (Bug#9175).
2178 (x_set_background_color): Likewise.
2180 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2181 contents (Bug#9176).
2182 (EmacsTooltip -init): Remove bezels and add shadows to
2185 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2186 or scroll bar (Bug#8470).
2188 * nsfont.m (nsfont_open): Remove assignment to voffset and
2189 unnecessary vars hshink, expand, hd, full_height, min_height.
2190 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2192 * nsterm.h (nsfont_info): Remove voffset field.
2194 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2196 Implement strike-through and overline on NextStep (Bug#8863).
2198 * nsfont.m (nsfont_open): Use underline position provided by font,
2199 instead of hard-coded value of 2.
2200 (nsfont_draw): Call ns_draw_text_decoration instead.
2202 * nsterm.h: Add declaration for ns_draw_text_decoration.
2204 * nsterm.m (ns_draw_text_decoration): New function for drawing
2205 underline, overline, and strike-through.
2206 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2207 ns_draw_text_decoration. Change treatment of cursor drawing to
2208 accommodate underlining, etc.
2210 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2212 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2215 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2217 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2218 Without this fix, if a signal arrives just after memory fills up,
2219 'malloc' might be invoked reentrantly.
2221 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2222 In other words, assume that every image size is allowed, on non-X
2223 hosts. This assumption is probably wrong, but it lets Emacs compile.
2225 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2227 * regex.c (re_iswctype): Convert return values to boolean.
2229 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2231 * xdisp.c (compute_display_string_pos): Don't use cached display
2232 string position if the buffer had its restriction changed.
2235 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2237 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2239 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2241 Integer signedness and overflow and related fixes. (Bug#9079)
2243 * bidi.c: Integer size and overflow fixes.
2244 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2245 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2246 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2247 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2248 (bidi_find_other_level_edge):
2249 Use ptrdiff_t instead of EMACS_INT where either will do.
2250 This works better on 32-bit hosts configured --with-wide-int.
2251 (bidi_cache_ensure_space): Check for size-calculation overflow.
2252 Use % rather than repeated addition, for better worst-case speed.
2253 Don't set bidi_cache_size until after xrealloc returns, because it
2255 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2256 (bidi_cache_ensure_space): Also check that the bidi cache size
2257 does not exceed that of the largest Lisp string or buffer. See Eli
2258 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2260 * alloc.c (__malloc_size_t): Remove.
2261 All uses replaced by size_t. See Andreas Schwab's note
2262 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2264 * image.c: Improve checking for integer overflow.
2265 (check_image_size): Assume that f is nonnull, since
2266 it is always nonnull in practice. This is one less thing to
2267 worry about when checking for integer overflow later.
2268 (x_check_image_size): New function, which checks for integer
2269 overflow issues inside X.
2270 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2271 This removes the need for a memory_full check.
2272 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2273 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2274 (xbm_read_bitmap_data): Change locals back to 'int', since
2275 their values must fit in 'int'.
2276 (xpm_load_image, png_load, tiff_load):
2277 Invoke x_create_x_image_and_pixmap earlier,
2278 to avoid much needless work if the image is too large.
2279 (tiff_load): Treat overly large images as if
2280 x_create_x_image_and_pixmap failed, not as malloc failures.
2281 (gs_load): Use x_check_image_size.
2283 * gtkutil.c: Omit integer casts.
2284 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2285 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2287 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2289 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2290 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2291 would wrongly return t on a 64-bit host.
2293 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2294 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2295 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2296 and therefore cause GCC to emit a bogus diagnostic in some cases.
2298 * image.c: Integer signedness and overflow and related fixes.
2299 This is not an exhaustive set of fixes, but it's time to
2300 record what I've got.
2301 (lookup_pixel_color, check_image_size): Remove redundant decls.
2302 (check_image_size): Don't assume that arbitrary EMACS_INT values
2303 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2304 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2305 (tiff_load, imagemagick_load_image):
2306 Check for overflow in size calculations.
2307 (x_create_x_image_and_pixmap): Remove unnecessary test for
2308 xmalloc returning NULL; that can't happen.
2309 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2310 (xpm_color_bucket): Use better integer hashing function.
2311 (xpm_cache_color): Don't possibly over-allocate memory.
2312 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2313 (gif_memory_source):
2314 Use ptrdiff_t, not int or size_t, to record sizes.
2315 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2316 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2317 either works, as we prefer signed integers.
2318 (tiff_read_from_memory, tiff_write_from_memory):
2319 Return tsize_t, not size_t, since that's what the TIFF API wants.
2320 (tiff_read_from_memory): Don't fail simply because the read would
2321 go past EOF; instead, return a short read.
2322 (tiff_load): Omit no-longer-needed casts.
2323 (Fimagemagick_types): Don't assume size fits into 'int'.
2325 Improve hashing quality when configured --with-wide-int.
2326 * fns.c (hash_string): New function, taken from sxhash_string.
2327 Do not discard information about ASCII character case; this
2328 discarding is no longer needed.
2329 (sxhash-string): Use it. Change sig to match it. Caller changed.
2330 * lisp.h: Declare it.
2331 * lread.c (hash_string): Remove, since we now use fns.c's version.
2332 The fns.c version returns a wider integer if --with-wide-int is
2333 specified, so this should help the quality of the hashing a bit.
2335 * emacs.c: Integer overflow minor fix.
2336 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2337 Define only if GNU_LINUX.
2338 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2340 * dispnew.c: Integer signedness and overflow fixes.
2341 Remove unnecessary forward decls, that were a maintenance hassle.
2342 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2344 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2345 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2346 (prepare_desired_row, line_draw_cost):
2347 Use int, not unsigned, where either works.
2348 (save_current_matrix, restore_current_matrix):
2349 Use ptrdiff_t, not size_t, where either works.
2350 (init_display): Check for overflow more accurately, and without
2351 relying on undefined behavior.
2353 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2354 Remove, replacing with the new symbols in lisp.h. All uses changed.
2355 * fileio.c (make_temp_name):
2356 * filelock.c (lock_file_1, lock_file):
2357 * xdisp.c (message_dolog):
2358 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2359 Use pMd etc. instead.
2360 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2361 replacing the pWIDE etc. symbols removed from editfns.c.
2363 * keyboard.h (num_input_events): Now uintmax_t.
2364 This is (very slightly) less likely to mess up due to wraparound.
2367 * buffer.c: Integer signedness fixes.
2368 (alloc_buffer_text, enlarge_buffer_text):
2369 Use ptrdiff_t rather than size_t when either will do, as we prefer
2372 * alloc.c: Integer signedness and overflow fixes.
2373 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2374 (__malloc_size_t): Default to size_t, not to int.
2375 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2376 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2377 Prefer ptrdiff_t to size_t when either would do, as we prefer
2379 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2380 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2381 Now const. Initialize with values that are in range even if char
2383 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2384 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2385 These functions do the right thing with sizes > 2**32.
2386 (check_depth): Now ptrdiff_t, not int.
2387 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2388 Adjust to new way of storing sizes. Check for size overflow bugs
2390 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2391 slightly wrong anyway, as it missed one instance of
2392 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2393 (refill_memory_reserve): Omit needless cast to size_t.
2394 (mark_object_loop_halt): Mark as externally visible.
2396 * xselect.c: Integer signedness and overflow fixes.
2397 (Fx_register_dnd_atom, x_handle_dnd_message):
2398 Use ptrdiff_t, not size_t, since we prefer signed.
2399 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2400 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2401 x_dnd_atoms_size and x_dnd_atoms_length.
2403 * doprnt.c: Prefer signed to unsigned when either works.
2405 * doprnt.c (doprnt):
2407 * xdisp.c (vmessage):
2408 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2409 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2410 prefer signed arithmetic to avoid comparison confusion.
2411 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2412 but is a bit tricky.
2414 Assume freestanding C89 headers, string.h, stdlib.h.
2415 * data.c, doprnt.c, floatfns.c, print.c:
2416 Include float.h unconditionally.
2417 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2418 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2419 * regex.c: Likewise for stddef.h, string.h.
2420 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2421 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2422 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2423 (STDC_HEADERS): Remove obsolete defines.
2424 * sysdep.c: Include limits.h unconditionally.
2426 Assume support for memcmp, memcpy, memmove, memset.
2427 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2428 * regex.c (memcmp, memcpy):
2429 Remove; we assume C89 now.
2431 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2432 (__malloc_safe_bcopy): Remove; no longer needed.
2434 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2435 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2436 well either way, and we prefer signed to unsigned.
2438 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2440 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2441 closes the connection while we're reading (bug#9182).
2443 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2445 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2446 are specified (Bug#9168).
2448 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2450 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2451 Found by GCC static checking and --with-wide-int on a 32-bit host.
2453 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2455 * xdisp.c (compute_display_string_pos): Fix logic of caching
2456 previous display string position. Initialize cached_prev_pos to
2457 -1. Fixes slow-down at the beginning of a buffer.
2459 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2461 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2462 for attrs[LFACE_FONTSET_INDEX].
2464 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2466 * xml.c (parse_region): Remove unused local
2467 that was recently introduced.
2469 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2471 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2472 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2474 * xdisp.c (move_it_in_display_line_to): Record the best matching
2475 position for TO_CHARPOS while scanning the line, and restore it on
2476 exit if none of the characters scanned was an exact match.
2477 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2478 when exact match is impossible due to invisible text, and the
2479 lines are truncated.
2481 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2483 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2486 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2488 Fix a significant slow-down of cursor motion with C-n, C-p,
2489 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2490 auto-repeat under bidi redisplay in fontified buffers.
2491 * xdisp.c (compute_stop_pos_backwards): New function.
2492 (next_element_from_buffer): Call compute_stop_pos_backwards to
2493 find a suitable prev_stop when we find ourselves before
2495 (reseat): Don't look for prev_stop, as that could mean a very long
2497 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2498 <cached_disp_overlay_modiff>: Cache for last found display string
2500 (compute_display_string_pos): Return the cached position if asked
2501 about the same buffer in the same area of character positions, and
2502 the buffer wasn't changed since the time the display string
2503 position was cached.
2505 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2508 is an integer, which is important for empty lines. (Bug#9149)
2510 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2512 * frame.c (Fmodify_frame_parameters): In tty case, update the
2513 default face if necessary (Bug#4238).
2515 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2517 * editfns.c (Fstring_to_char): No need to explain what a character
2518 is in the docstring (Bug#6576).
2520 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2522 * xml.c (parse_region): Make sure we always return a tree.
2524 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2526 * xml.c (parse_region): If a document contains only comments,
2529 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531 * xml.c (make_dom): Return comments, too.
2533 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2536 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2537 and the surrounding thread.
2538 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2539 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2540 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2542 * s/openbsd.h (BROKEN_SIGIO): Define.
2543 * unexelf.c (unexec) [__OpenBSD__]:
2544 Don't update the .mdebug section of the Alpha COFF symbol table.
2546 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2548 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2551 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2553 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2554 This fixes some race conditions on the permissions of any newly
2557 * alloc.c (valid_pointer_p): Use pipe, not open.
2558 This fixes some permissions issues when debugging.
2560 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2561 If fchown fails to set both uid and gid, try to set just gid,
2562 as that is sometimes allowed. Adjust the file's mode to eliminate
2563 setuid or setgid bits that are inappropriate if fchown fails.
2565 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2567 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2568 to compare Lisp_Objects.
2569 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2570 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2571 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2573 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2575 * lread.c (read_integer): Unread even EOF character.
2576 (read1): Likewise. Properly record start position of symbol.
2578 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2579 symbol character follows.
2581 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2583 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2584 This works around a problem with the previous change to Fcopy_file.
2585 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2586 and without this change, GCC might complain about discarding
2587 fchown's return value.
2589 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2591 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2593 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2595 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2597 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2599 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2600 it's used from the C level.
2602 * process.c: Use the same condition for POLL_FOR_INPUT in both
2603 keyboard.c and process.c (bug#1858).
2605 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2607 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2608 (Fgnutls_boot): Use it.
2610 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2612 * doc.c (Fsubstitute_command_keys): Revert last change.
2614 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2616 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2617 quotes the next character, and doesn't affect other longer
2618 sequences (bug#8935).
2620 * lread.c (syms_of_lread): Clarify that is isn't only
2621 `eval-buffer' and `eval-defun' that's affected by
2622 `lexical-binding' (bug#8460).
2624 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2626 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2627 bidi redisplay when a line includes both an image and is truncated.
2629 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2631 Fix minor problems found by static checking.
2632 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2633 (elsz): Now a signed constant, not a size_t var. We prefer signed
2634 types to unsigned, to avoid integer comparison confusion. Without
2635 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2636 "cannot optimize loop, the loop counter may overflow", a symptom
2638 * indent.c (Fvertical_motion): Mark locals as initialized.
2639 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2641 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2643 * search.c (Fre_search_backward): Mention `case-fold-search' in
2644 all the re_search_* functions (bug#8138).
2646 * keyboard.c (Fopen_dribble_file): Document when the file is
2649 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2651 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2654 Support bidi reordering of display and overlay strings.
2655 * xdisp.c (compute_display_string_pos)
2656 (compute_display_string_end): Accept additional argument STRING.
2657 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2658 (reseat_to_string): Initialize bidi_it->string.s and
2659 bidi_it->string.schars.
2660 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2661 NULL (avoids a crash in bidi_paragraph_init).
2662 Initialize itb.string.lstring.
2663 (init_iterator): Call bidi_init_it only of a valid
2664 buffer position was specified. Initialize paragraph_embedding to
2666 (reseat_to_string): Initialize the bidi iterator.
2667 (display_string): If we need to ignore text properties of
2668 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2669 original value of -1 will not work with bidi.)
2670 (compute_display_string_pos): First arg is now struct
2671 `text_pos *'; all callers changed. Support display properties on
2673 (compute_display_string_end): Support display properties on Lisp
2675 (init_iterator, reseat_1, reseat_to_string): Initialize the
2676 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2677 when iterating on a string not from display properties).
2678 (compute_display_string_pos, compute_display_string_end):
2679 Fix calculation of the object to scan. Fixes an error when using
2681 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2682 base_level_stop; instead, set base_level_stop to BEGV.
2683 Fixes crashes in vertical-motion.
2684 (next_element_from_buffer): Improve commentary for when
2685 the iterator is before prev_stop.
2686 (init_iterator): Initialize bidi_p from the default value of
2687 bidi-display-reordering, not from buffer-local value. Use the
2688 buffer-local value only if initializing for buffer iteration.
2689 (handle_invisible_prop): Support invisible properties on strings
2690 that are being bidi-reordered.
2691 (set_iterator_to_next): Support bidi reordering of C strings and
2693 (next_element_from_string): Support bidi reordering of Lisp
2695 (handle_stop_backwards): Support Lisp strings as well.
2696 (display_string): Support display of R2L glyph rows.
2697 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2698 (init_iterator): Don't initialize it->bidi_p for strings
2700 (reseat_to_string): Initialize it->bidi_p for strings here.
2701 (next_element_from_string, next_element_from_c_string)
2702 (next_element_from_buffer): Add xassert's for correspondence
2703 between IT's object being iterated and it->bidi_it.string
2705 (face_before_or_after_it_pos): Support bidi iteration.
2706 (next_element_from_c_string): Handle the case of the first string
2707 character that is not the first one in the visual order.
2708 (get_visually_first_element): New function, refactored from common
2709 parts of next_element_from_buffer, next_element_from_string, and
2710 next_element_from_c_string.
2711 (tool_bar_lines_needed, redisplay_tool_bar)
2712 (display_menu_bar): Force left-to-right direction. Add a FIXME
2713 comment for making that be controlled by a user option.
2714 (push_it, pop_it): Save and restore the state of the
2715 bidi iterator. Save and restore the bidi_p flag.
2716 (pop_it): Iterate out of display property for string iteration as
2718 (iterate_out_of_display_property): Support iteration over strings.
2719 (handle_single_display_spec): Set up it->bidi_it for iteration
2720 over a display string, and call bidi_init_it.
2721 (handle_single_display_spec, next_overlay_string)
2722 (get_overlay_strings_1, push_display_prop): Set up the bidi
2723 iterator for displaying display or overlay strings.
2724 (forward_to_next_line_start): Don't use the shortcut if
2726 (back_to_previous_visible_line_start): If handle_display_prop
2727 pushed the iterator stack, restore the internal state of the bidi
2728 iterator by calling bidi_pop_it same number of times.
2729 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2730 and we are bidi-iterating, don't decrement the iterator position;
2731 instead, set the first_elt flag in the bidi iterator, to produce
2733 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2734 (push_display_prop): xassert that we are iterating a buffer.
2735 (push_it, pop_it): Save and restore paragraph_embedding member.
2736 (handle_single_display_spec, next_overlay_string)
2737 (get_overlay_strings_1, reseat_1, reseat_to_string)
2738 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2739 correctly. Don't assume unibyte strings are not bidi-reordered.
2740 (compute_display_string_pos)
2741 (compute_display_string_end): Fix handling the case of C string.
2742 (push_it, pop_it): Save and restore from_disp_prop_p.
2743 (handle_single_display_spec, push_display_prop): Set the
2744 from_disp_prop_p flag.
2745 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2746 (pop_it): Call iterate_out_of_display_property only if we are
2747 popping after iteration over a string that came from a display
2748 property. Fix a typo in popping stretch info. Add an assertion
2749 for verifying that the iterator position is in sync with the bidi
2751 (handle_single_display_spec, get_overlay_strings_1)
2752 (push_display_prop): Fix initialization of paragraph direction for
2753 string when that of the parent object is not yet determined.
2754 (reseat_1): Call bidi_init_it to resync the bidi
2755 iterator with IT's position. (Bug#7616)
2756 (find_row_edges): If ROW->start.pos gives position
2757 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2758 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2759 Reset the from_disp_prop_p flag.
2760 (SAVE_IT, RESTORE_IT): New macros.
2761 (pos_visible_p, face_before_or_after_it_pos)
2762 (back_to_previous_visible_line_start)
2763 (move_it_in_display_line_to, move_it_in_display_line)
2764 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2765 (try_scrolling, redisplay_window, display_line): Use them when
2766 saving a temporary copy of the iterator and restoring it back.
2767 (back_to_previous_visible_line_start, reseat_1)
2768 (init_iterator): Empty the bidi cache "stack".
2769 (move_it_in_display_line_to): If iterator ended up at
2770 EOL, but we never saw any buffer positions smaller than
2771 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2772 motion in bidi-reordered lines.
2773 (move_it_in_display_line_to): Record prev_method and prev_pos
2774 immediately before the call to set_iterator_to_next. Fixes cursor
2775 motion in bidi-reordered lines with stretch glyphs and strings
2776 displayed in margins. (Bug#8133) (Bug#8867)
2777 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2779 (pos_visible_p): Support positions in bidi-reordered lines.
2780 Save and restore bidi cache.
2782 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2783 (bidi_paragraph_info): Delete unused struct.
2784 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2785 (bidi_cache_start): New variable.
2786 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2788 (bidi_cache_fetch_state, bidi_cache_search)
2789 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2790 (bidi_cache_find, bidi_peek_at_next_level)
2791 (bidi_level_of_next_char, bidi_find_other_level_edge)
2792 (bidi_move_to_visually_next): Compare cache index with
2793 bidi_cache_start rather than with zero.
2794 (bidi_fetch_char): Accept new argument STRING; all callers
2795 changed. Support iteration over a string. Support strings with
2796 display properties. Support unibyte strings. Fix the type of
2797 `len' according to what STRING_CHAR_AND_LENGTH expects.
2798 (bidi_paragraph_init, bidi_resolve_explicit_1)
2799 (bidi_resolve_explicit, bidi_resolve_weak)
2800 (bidi_level_of_next_char, bidi_move_to_visually_next):
2801 Support iteration over a string.
2802 (bidi_set_sor_type, bidi_resolve_explicit_1)
2803 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2804 can now be zero (for strings); special values 0 and -1 were
2805 changed to -1 and -2, respectively.
2806 (bidi_char_at_pos): New function.
2807 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2808 Call it instead of FETCH_MULTIBYTE_CHAR.
2809 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2810 initialized to valid values.
2811 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2813 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2814 the test for valid cached positions. Fix the logic for looking up
2815 the sentinel state in the cache. GCPRO the Lisp string we are
2817 (bidi_push_it, bidi_pop_it): New functions.
2818 (bidi_initialize): Initialize the bidi cache start stack pointer.
2819 (bidi_cache_ensure_space): New function, refactored from part of
2820 bidi_cache_iterator_state. Don't assume the required size is just
2821 one BIDI_CACHE_CHUNK away.
2822 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2823 (bidi_count_bytes, bidi_char_at_pos): New functions.
2824 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2825 always valid if bidi_cache_idx is valid.
2826 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2827 is valid if it's going to be used.
2828 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2829 (bidi_cache_fetch_state, bidi_cache_search)
2830 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2831 (bidi_cache_iterator_state, bidi_cache_find)
2832 (bidi_find_other_level_edge, bidi_cache_start_stack):
2833 All variables related to cache indices are now EMACS_INT.
2835 * dispextern.h (struct bidi_string_data): New structure.
2836 (struct bidi_it): New member `string'. Make flag members be 1-bit
2837 fields, and put them last in the struct.
2838 (compute_display_string_pos, compute_display_string_end):
2840 (bidi_push_it, bidi_pop_it): Add prototypes.
2841 (struct iterator_stack_entry): New members bidi_p,
2842 paragraph_embedding, and from_disp_prop_p.
2843 (struct it): Member bidi_p is now a bit field 1 bit wide.
2844 (bidi_shelve_cache, bidi_unshelve_cache):
2847 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2848 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2849 and vector-like objects.
2851 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2852 cache around display iteration.
2854 * window.c (Fwindow_end, window_scroll_pixel_based)
2855 (displayed_window_lines, Frecenter): Save and restore the bidi
2856 cache around display iteration.
2858 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2860 * editfns.c (Fdelete_region): Clarify the use of the named
2861 parameters (bug#6788).
2863 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2865 * indent.c (Fvertical_motion): Set and restore w->pointm when
2866 saving and restoring the window's buffer (Bug#9006).
2868 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870 * editfns.c (Fstring_to_char): Clarify just what is returned
2871 (bug#6576). Text by Eli Zaretskii.
2873 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2875 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2877 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2879 * buffer.c (mmap_find): Fix a typo.
2881 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2883 Fix execution of x selection hooks.
2884 * xselect.c (Qx_lost_selection_functions)
2885 (Qx_sent_selection_functions): New vars.
2886 (syms_of_xselect): DEFSYM them.
2887 (x_handle_selection_request): Pass Qx_sent_selection_functions
2888 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2889 (x_handle_selection_clear,x_clear_frame_selections):
2890 Pass Qx_lost_selection_functions rather than
2891 Vx_lost_selection_functions to Frun_hook_with_args.
2893 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2895 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2896 The old code sometimes used this field without initializing it.
2898 * alloc.c (gc_sweep): Don't read past end of array.
2899 In theory, the old code could also have corrupted Emacs internals,
2900 though it'd be very unlikely.
2902 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2904 * character.c (Fcharacterp): Don't advertise optional ignored
2905 argument. (Bug#4026)
2907 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2909 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2912 * window.c (Fset_window_start): Doc fix (bug#4199).
2913 (Fset_window_hscroll): Ditto.
2915 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2917 Fix minor new problems caught by GCC 4.6.1.
2918 * term.c (init_tty): Remove unused local.
2919 * xsettings.c (store_monospaced_changed): Define this function only
2920 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2923 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2925 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2927 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2929 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2930 are the mini-buffer and the echo area (bug#3320).
2932 * term.c (init_tty): Remove support for supdup, c10 and perq
2933 terminals, which are no longer supported (bug#1482).
2935 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2937 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2939 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2941 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2942 for non-popups (Bug#3642).
2944 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2946 * alloc.c (reset_malloc_hooks): Protoize.
2947 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2948 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2949 * cm.c (losecursor): Likewise.
2950 * data.c (fmod): Likewise.
2951 * dispnew.c (swap_glyphs_in_rows): Likewise.
2952 * emacs.c (memory_warning_signal): Likewise.
2953 * floatfns.c (float_error): Likewise.
2954 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2955 (otf_open, font_otf_capability, generate_otf_features)
2956 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2958 * image.c (pbm_read_file): Likewise.
2959 * indent.c (string_display_width): Likewise.
2960 * intervals.c (check_for_interval, search_for_interval)
2961 (inc_interval_count, count_intervals, root_interval)
2962 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2963 * lread.c (defalias): Likewise.
2964 * ralloc.c (r_alloc_check): Likewise.
2965 * regex.c (set_image_of_range_1, set_image_of_range)
2966 (regex_grow_registers): Likewise.
2967 * sysdep.c (strerror): Likewise.
2968 * termcap.c (valid_filename_p, tprint, main): Likewise.
2969 * tparam.c (main): Likewise.
2970 * unexhp9k800.c (run_time_remap, save_data_space)
2971 (update_file_ptrs, read_header, write_header, calculate_checksum)
2972 (copy_file, copy_rest, display_header): Likewise.
2973 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2975 * xdisp.c (check_it): Likewise.
2976 * xfaces.c (register_color, unregister_color, unregister_colors):
2978 * xfns.c (print_fontset_result): Likewise.
2979 * xrdb.c (member, fatal, main): Likewise.
2981 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2983 Fix minor problems found by static checking (Bug#9031).
2984 * chartab.c (char_table_set_range, map_sub_char_table):
2985 Remove unused locals.
2986 (uniprop_table): Now static.
2987 * composite.c (_work_char): Remove unused static var.
2989 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2991 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2993 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2995 * gtkutil.c (qttip_cb): Remove code without function.
2997 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2999 * w32.c (pthread_sigmask): New stub.
3001 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3003 Use pthread_sigmask, not sigprocmask (Bug#9010).
3004 sigprocmask is portable only for single-threaded applications, and
3005 Emacs can be multi-threaded when it uses GTK.
3006 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3008 * callproc.c (Fcall_process):
3009 * process.c (create_process):
3010 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3011 Use pthread_sigmask, not sigprocmask.
3013 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3015 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3016 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3019 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3021 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3022 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3023 (xg_hide_tooltip): Fix comment.
3025 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3026 in registerServicesMenuSendTypes.
3027 (validRequestorForSendType): Don't check ns_return_types.
3029 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3032 2011-07-08 Jason Rumney <jasonr@gnu.org>
3034 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3035 SH_SHOW for hidden windows (Bug#5482).
3037 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3038 frame struct members of non-existent frames (Bug#6284).
3040 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3042 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3043 variable firstTime not needed on OSX >= 10.6.
3044 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3045 >= 10.5. Use setKnobProportion, setDoubleValue.
3047 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3048 (MAC_OS_X_VERSION_10_5): Define if not defined.
3049 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3050 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3051 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3053 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3054 cString and lossyCString on OSX >= 10.4
3056 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3057 sizeToFit on OSX >= 10.2.
3059 * nsimage.m (allocInitFromFile): Don't use deprecated method
3060 bestRepresentationForDevice on OSX >= 10.6.
3062 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3065 * emacs.c: Declare unexec_init_emacs_zone.
3067 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3069 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3071 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3072 on svcsMenu (Bug#8842).
3074 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3076 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3078 * nsterm.m (QUTF8_STRING): Declare.
3079 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3080 (validRequestorForSendType): Return type is (id).
3081 Change indexOfObjectIdenticalTo to indexOfObject.
3082 Check if we have local selection before returning self (Bug#8842).
3083 (writeSelectionToPasteboard): Put local selection into paste board
3084 if we have a local selection (Bug#8842).
3085 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3087 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3088 (ns_get_local_selection): Declare.
3090 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3092 * keymap.c (describe_map_tree): Don't insert a double newline at
3093 the end of the buffer (bug#1169) and return whether we inserted
3096 * callint.c (Fcall_interactively): Change "reading args" to
3097 "providing args" to try to clarify what it does (bug#1010).
3099 2011-07-07 Kenichi Handa <handa@m17n.org>
3101 * composite.c (composition_compute_stop_pos): Ignore a static
3102 composition starting before CHARPOS (Bug#8915).
3104 * xdisp.c (handle_composition_prop): Likewise.
3106 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3108 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3111 2011-07-07 Kenichi Handa <handa@m17n.org>
3113 * character.h (unicode_category_t): New enum type.
3115 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3116 (Qchar_code_property_table): New variable.
3117 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3118 (UNIPROP_COMPRESSED_FORM_P): New macros.
3119 (char_table_ascii): Uncompress the compressed values.
3120 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3121 Uncompress the compressed values.
3122 (sub_char_table_ref_and_range): Likewise.
3123 (char_table_ref_and_range): Uncompress the compressed values.
3124 (sub_char_table_set): New arg is_uniprop. Callers changed.
3125 Uncompress the compressed values.
3126 (sub_char_table_set_range): Args changed. Callers changed.
3127 (char_table_set_range): Adjuted for the above change.
3128 (map_sub_char_table): Delete args default_val and parent. Add arg
3129 top. Give decoded values to a Lisp function.
3130 (map_char_table): Adjust for the above change. Give decoded
3131 values to a Lisp function. Gcpro more variables.
3132 (uniprop_table_uncompress)
3133 (uniprop_decode_value_run_length): New functions.
3134 (uniprop_decoder, uniprop_decoder_count): New variables.
3135 (uniprop_get_decoder, uniprop_encode_value_character)
3136 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3138 (uniprop_encoder, uniprop_encoder_count): New variables.
3139 (uniprop_get_encoder, uniprop_table)
3140 (Funicode_property_table_internal, Fget_unicode_property_internal)
3141 (Fput_unicode_property_internal): New functions.
3142 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3143 Sunicode_property_table_internal, Sget_unicode_property_internal,
3144 and Sput_unicode_property_internal. Defvar_lisp
3145 char-code-property-alist.
3147 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3148 Vunicode_category_table.
3150 * font.c (font_range): Adjust for the change of
3151 Vunicode_category_table.
3153 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3155 * m/iris4d.h: Remove file, move contents ...
3156 * s/irix6-5.h: ... here.
3158 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3160 Remove unportable assumption about struct layout (Bug#8884).
3161 * alloc.c (mark_buffer):
3162 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3163 (clone_per_buffer_values): Don't assume that
3164 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3165 This isn't true in general, and it's particularly not true
3166 if Emacs is configured with --with-wide-int.
3167 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3168 New macros, used in the buffer.c change.
3170 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3172 * xsettings.c: Use both GConf and GSettings if both are available.
3173 (store_config_changed_event): Add comment.
3174 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3175 (store_tool_bar_style_changed): New functions.
3176 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3177 (struct xsettings): Move font inside HAVE_XFT.
3178 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3179 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3180 Move inside HAVE_XFT.
3181 (something_changed_gsettingsCB): Rename from something_changedCB.
3182 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3184 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3185 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3186 (something_changed_gconfCB): Rename from something_changedCB.
3187 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3188 (parse_settings): Move check for font inside HAVE_XFT.
3189 (read_settings, apply_xft_settings): Add comment.
3190 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3191 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3192 call store_font_name_changed.
3193 (xft_settings_event): Add comment.
3194 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3195 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3196 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3197 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3198 (xsettings_initialize): Call init_gsettings last.
3199 (xsettings_get_system_font, xsettings_get_system_normal_font):
3202 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3204 Random fixes. E.g., (random) never returned negative values.
3205 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3206 subseconds part to the entropy, as that's a bit more random.
3207 Prefer signed to unsigned, since the signedness doesn't matter and
3208 in general we prefer signed. When given a limit, use a
3209 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3210 latter isn't right if USE_2_TAGS_FOR_INTS.
3211 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3212 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3214 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3216 * textprop.c (text_property_stickiness):
3217 Obey Vtext_property_default_nonsticky.
3218 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3219 * w32fns.c (syms_of_w32fns):
3220 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3222 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3224 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3225 This is more efficient than Ffile_directory_p and avoids a minor race.
3227 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3229 * buffer.c (Foverlay_put): Say what the return value is
3232 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3233 is a directory before asking whether to use the file name
3235 (barf_or_query_if_file_exists): Make the "File is a directory"
3236 error be more correct.
3238 * fns.c (Frequire): Remove the mention of the .gz files, since
3239 that's installation-specific, but keep the mention of
3240 `get-load-suffixes'.
3242 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3244 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3245 Report string overflow if the output is too long.
3247 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3249 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3250 (syms_of_gnutls): Remove duplicate DEFSYM for
3251 Qgnutls_bootprop_verify_hostname_error, an error for
3252 Qgnutls_bootprop_verify_error (which is no longer used).
3254 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3255 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3256 Also (re)move comments that are misplaced or no longer relevant.
3258 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3262 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3264 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3265 and background color parameters if they have been changed.
3267 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3269 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3271 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3273 * xsettings.c (SYSTEM_FONT): Define only when used.
3274 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3276 * keymap.c (access_keymap_1): Now static.
3278 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3280 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3281 leave any prefix arg for the up event (Bug#1586).
3283 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3285 * lread.c (syms_of_lread): Mention single symbols defined by
3286 `defvar' or `defconst' (bug#7154).
3288 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3289 (Frequire): Mention get-load-suffixes.
3291 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3293 * window.h (window): Remove clone_number slot.
3294 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3296 (make_parent_window, make_window, saved_window)
3297 (Fset_window_configuration, save_window_save): Don't deal with
3299 * buffer.c (Qclone_number): Remove declaration.
3300 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3302 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3304 Add multiple inheritance to keymaps.
3305 * keymap.c (Fmake_composed_keymap): New function.
3306 (Fset_keymap_parent): Simplify.
3307 (fix_submap_inheritance): Remove.
3308 (access_keymap_1): New function extracted from access_keymap to handle
3309 embedded parents and handle lists of maps.
3310 (access_keymap): Use it.
3311 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3312 (Fcopy_keymap): Handle embedded parents.
3313 (Fcommand_remapping, define_as_prefix): Simplify.
3314 (Fkey_binding): Simplify.
3315 (syms_of_keymap): Move minibuffer-local-completion-map,
3316 minibuffer-local-filename-completion-map,
3317 minibuffer-local-must-match-map, and
3318 minibuffer-local-filename-must-match-map to Elisp.
3319 (syms_of_keymap): Defsubr make-composed-keymap.
3320 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3321 (parse_menu_item): Trivial simplification.
3323 2011-07-01 Glenn Morris <rgm@gnu.org>
3325 * Makefile.in (SETTINGS_LIBS): Fix typo.
3327 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3329 * coding.c (Fencode_coding_string): Record the last coding system
3330 used, as the function doc string says (bug#8738).
3332 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3334 * xsettings.c (store_monospaced_changed): Take new font as arg and
3335 check for change against current_mono_font.
3336 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3337 (emacs_settings_constructor, emacs_settings_get_property)
3338 (emacs_settings_set_property, emacs_settings_class_init)
3339 (emacs_settings_init, gsettings_obj): Remove.
3340 (something_changedCB): New function for HAVE_GSETTINGS.
3341 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3342 with value as argument.
3343 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3344 g_settings_new (Bug#8967). Do not create gsettings_obj.
3345 Remove calls to g_settings_bind. Connect something_changedCB to
3348 * xgselect.c: Add defined (HAVE_GSETTINGS).
3349 (xgselect_initialize): Ditto.
3351 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3352 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3355 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3357 * eval.c (struct backtrace): Simplify and port the data structure.
3358 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3359 signed bit field, as this assumption is not portable and it makes
3360 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3361 "char debug_on_exit : 1" as this is not portable either; instead,
3362 use the portable "unsigned int debug_on_exit : 1". Remove unused
3363 member evalargs. Remove obsolete comments about cc bombing out.
3365 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3367 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3368 Let HAVE_GSETTINGS override HAVE_GCONF.
3369 (store_monospaced_changed): New function.
3370 (EMACS_SETTINGS): A new type derived from GObject to handle
3371 GSettings notifications.
3372 (emacs_settings_constructor, emacs_settings_get_property)
3373 (emacs_settings_set_property, emacs_settings_class_init):
3375 (gsettings_client, gsettings_obj): New variables.
3376 (GSETTINGS_SCHEMA): New define.
3377 (something_changedCB): Call store_monospaced_changed.
3378 (init_gsettings): New function.
3379 (xsettings_initialize): Call init_gsettings.
3380 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3383 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3386 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3388 * window.c (resize_root_window, grow_mini_window)
3389 (shrink_mini_window): Rename Qresize_root_window to
3390 Qwindow_resize_root_window and Qresize_root_window_vertically to
3391 Qwindow_resize_root_window_vertically.
3393 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3395 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3397 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3399 * makefile.w32-in: Redesign dependencies so they reflect more
3400 clearly which files are directly included by each source file,
3401 and not through other includes.
3403 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3405 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3406 (sort_overlays, overlay_strings): When an overlay's clone number
3407 matches the window's clone number process the overlay even if
3408 the overlay's window property doesn't match the current window.
3410 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3411 (Fwindow_hchild): Rename to Fwindow_left_child.
3412 (Fwindow_next): Rename to Fwindow_next_sibling.
3413 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3414 (resize_window_check): Rename to window_resize_check.
3415 (resize_window_apply): Rename to window_resize_apply.
3416 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3417 (Fdelete_other_windows_internal, resize_frame_windows)
3418 (Fsplit_window_internal, Fdelete_window_internal)
3419 (grow_mini_window, shrink_mini_window)
3420 (Fresize_mini_window_internal): Fix callers accordingly.
3422 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3424 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3425 (emacs_fixed_set_min_size): Remove.
3426 (emacs_fixed_new): Take frame as argument.
3428 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3429 (_EmacsFixedPrivate): Remove minwidth/height.
3430 Add struct frame *f.
3431 (emacs_fixed_init): Initialize priv->f.
3432 (get_parent_class, emacs_fixed_set_min_size): Remove.
3433 (emacs_fixed_new): Set priv->f to argument.
3434 (emacs_fixed_get_preferred_width)
3435 (emacs_fixed_get_preferred_height): Use min_width/height from
3436 frames size_hint to set minimum and natural (Bug#8919).
3437 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3438 and use min_width/height from frames size_hint to set
3439 min_width/height (Bug#8919).
3441 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3442 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3445 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3447 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3448 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3451 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3453 * process.c (wait_reading_process_output): Bypass select if
3454 waiting for a cell while ignoring keyboard input, and input is
3455 pending. Suggested by Jan Djärv (Bug#8869).
3457 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3459 Use gnulib's dup2 module instead of rolling our own.
3460 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3462 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3464 * dispnew.c (scrolling_window): Before scrolling, turn off a
3465 mouse-highlight in the window being scrolled.
3467 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3469 Move DEFSYM to lisp.h and use everywhere.
3471 * character.h (DEFSYM): Move declaration...
3472 * lisp.h (DEFSYM): ...here.
3478 * w32select.c: Don't include character.h.
3480 * alloc.c (syms_of_alloc):
3481 * buffer.c (syms_of_buffer):
3482 * bytecode.c (syms_of_bytecode):
3483 * callint.c (syms_of_callint):
3484 * casefiddle.c (syms_of_casefiddle):
3485 * casetab.c (init_casetab_once):
3486 * category.c (init_category_once, syms_of_category):
3487 * ccl.c (syms_of_ccl):
3488 * cmds.c (syms_of_cmds):
3489 * composite.c (syms_of_composite):
3490 * dbusbind.c (syms_of_dbusbind):
3491 * dired.c (syms_of_dired):
3492 * dispnew.c (syms_of_display):
3493 * doc.c (syms_of_doc):
3494 * editfns.c (syms_of_editfns):
3495 * emacs.c (syms_of_emacs):
3496 * eval.c (syms_of_eval):
3497 * fileio.c (syms_of_fileio):
3498 * fns.c (syms_of_fns):
3499 * frame.c (syms_of_frame):
3500 * fringe.c (syms_of_fringe):
3501 * insdel.c (syms_of_insdel):
3502 * keymap.c (syms_of_keymap):
3503 * lread.c (init_obarray, syms_of_lread):
3504 * macros.c (syms_of_macros):
3505 * msdos.c (syms_of_msdos):
3506 * print.c (syms_of_print):
3507 * process.c (syms_of_process):
3508 * search.c (syms_of_search):
3509 * sound.c (syms_of_sound):
3510 * syntax.c (init_syntax_once, syms_of_syntax):
3511 * terminal.c (syms_of_terminal):
3512 * textprop.c (syms_of_textprop):
3513 * undo.c (syms_of_undo):
3514 * w32.c (globals_of_w32):
3515 * window.c (syms_of_window):
3516 * xdisp.c (syms_of_xdisp):
3517 * xfaces.c (syms_of_xfaces):
3518 * xfns.c (syms_of_xfns):
3519 * xmenu.c (syms_of_xmenu):
3520 * xsettings.c (syms_of_xsettings):
3521 * xterm.c (syms_of_xterm): Use DEFSYM.
3523 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3525 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3527 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3529 Integer and buffer overflow fixes (Bug#8873).
3531 * print.c (printchar, strout): Check for string overflow.
3532 (PRINTPREPARE, printchar, strout):
3533 Don't set size unless allocation succeeds.
3535 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3536 for sizes. Check for string overflow more accurately.
3537 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3539 * macros.c: Integer and buffer overflow fixes.
3540 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3541 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3542 Use ptrdiff_t, not int, for sizes.
3543 Don't increment bufsize until after realloc succeeds.
3544 Check for size-calculation overflow.
3545 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3547 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3549 * lread.c: Integer overflow fixes.
3550 (read_integer): Radix is now EMACS_INT, not int,
3551 to improve quality of diagnostics for out-of-range radices.
3552 Calculate buffer size correctly for out-of-range radices.
3553 (read1): Check for integer overflow in radices, and in
3554 read-circle numbers.
3555 (read_escape): Avoid int overflow.
3556 (Fload, openp, read_buffer_size, read1)
3557 (substitute_object_recurse, read_vector, read_list, map_obarray):
3558 Use ptrdiff_t, not int, for sizes.
3559 (read1): Use EMACS_INT, not int, for sizes.
3560 Check for size overflow.
3562 * image.c (cache_image): Check for size arithmetic overflow.
3564 * lread.c: Integer overflow issues.
3565 (saved_doc_string_size, saved_doc_string_length)
3566 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3567 Now ptrdiff_t, not int.
3568 (read1): Don't assume doc string length fits in int. Check for
3569 out-of-range doc string lengths.
3570 (read_list): Don't assume file position fits in int.
3571 (read_escape): Check for hex character overflow.
3573 2011-06-22 Leo Liu <sdl.web@gmail.com>
3575 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3576 Move to minibuffer.el.
3578 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3580 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3581 The following patches are for when GLYPH_DEBUG && !XASSERT.
3582 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3583 * dispnew.c (flush_stdout):
3584 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3585 Mark as externally visible.
3586 * dispnew.c (check_window_matrix_pointers): Now static.
3587 * dispnew.c (window_to_frame_vpos):
3588 * xfns.c (unwind_create_frame):
3589 * xterm.c (x_check_font): Remove unused local.
3590 * scroll.c (CHECK_BOUNDS):
3591 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3592 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3593 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3594 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3595 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3597 (debug_method_add): Use va_list and vsprintf rather than relying
3598 on undefined behavior with wrong number of arguments.
3599 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3600 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3601 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3602 since we're not interested in debugging glyphs with old libraries.
3603 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3604 GCC 4.6.0's static checking.
3606 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3608 Integer overflow and signedness fixes (Bug#8873).
3609 A few related buffer overrun fixes, too.
3611 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3613 * dispextern.h (struct face.stipple):
3614 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3615 (x_bitmap_mask, x_allocate_bitmap_record)
3616 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3617 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3618 (x_create_bitmap_from_xpm_data):
3619 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3620 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3622 * xfaces.c (load_pixmap):
3623 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3624 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3625 (.bitmaps_last, struct x_output.icon_bitmap):
3626 Use ptrdiff_t, not int, for bitmap indexes.
3627 (x_allocate_bitmap_record): Check for size overflow.
3628 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3630 Use ptrdiff_t, not int, for overlay counts.
3631 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3632 * editfns.c (overlays_around, get_pos_property):
3633 * textprop.c (get_char_property_and_overlay):
3634 * xdisp.c (next_overlay_change, note_mouse_highlight):
3635 * xfaces.c (face_at_buffer_position):
3636 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3637 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3638 (Fnext_overlay_change, Fprevious_overlay_change)
3639 (mouse_face_overlay_overlaps, Foverlays_in):
3640 Use ptrdiff_t, not int, for sizes.
3641 (overlays_at, overlays_in): Check for size-calculation overflow.
3643 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3645 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3646 (x_session_initialize): Do not assume string length fits in int.
3648 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3649 This is unlikely, but can occur if DPI is outlandish.
3651 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3652 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3654 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3655 * xrdb.c (magic_file_p, search_magic_path):
3656 Omit last arg SUFFIX; it was always 0. All callers changed.
3657 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3659 * xfont.c (xfont_match): Avoid need for strlen.
3661 * xfns.c: Don't assume strlen fits in int.
3662 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3664 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3665 not unsigned long, as we prefer signed integers. All callers changed.
3666 Detect integer overflow in repeat count.
3667 (message_dolog): Don't assume print length fits in 39 bytes.
3668 (display_mode_element): Don't assume strlen fits in int.
3670 * termcap.c: Don't assume sizes fit in int and never overflow.
3671 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3672 (gobble_line): Check for size-calculation overflow.
3674 * minibuf.c (Fread_buffer):
3675 * lread.c (intern, intern_c_string):
3676 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3677 Don't assume string length fits in int.
3679 * keyboard.c (parse_tool_bar_item):
3680 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3682 * font.c: Don't assume string length fits in int.
3683 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3684 Use ptrdiff_t, not int.
3685 (font_intern_prop): Don't assume string length fits in int.
3686 Don't assume integer property fits in fixnum.
3687 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3689 * filelock.c: Fix some buffer overrun and integer overflow issues.
3690 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3691 Reformulate so as not to need the command string.
3692 Invoke gzip -cd rather than gunzip, as it's more portable.
3693 (lock_info_type, lock_file_1, lock_file):
3694 Don't assume pid_t and time_t fit in unsigned long.
3695 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3696 (current_lock_owner): Prefer signed type for sizes.
3697 Use memcpy, not strncpy, where memcpy is what is really wanted.
3698 Don't assume (via atoi) that time_t and pid_t fit in int.
3699 Check for time_t and/or pid_t out of range, e.g., via a network share.
3700 Don't alloca where an auto var works fine.
3702 * fileio.c: Fix some integer overflow issues.
3703 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3704 Don't assume string length fits in int.
3705 (directory_file_name): Don't assume string length fits in long.
3706 (make_temp_name): Don't assume pid fits in int, or that its print
3707 length is less than 20.
3709 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3711 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3713 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3715 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3716 We prefer signed integers, even for size calculations.
3718 * emacs.c: Don't assume string length fits in 'int'.
3719 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3720 (main): Don't invoke strlen when not needed.
3722 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3723 (XD_DEBUG_MESSAGE): Don't waste a byte.
3725 * callproc.c (getenv_internal_1, getenv_internal)
3727 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3729 * lread.c (invalid_syntax): Omit length argument.
3730 All uses changed. This doesn't fix a bug, but it simplifies the
3731 code away from its former Hollerith-constant appearance, and it's
3732 one less 'int' to worry about when looking at integer-overflow issues.
3733 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3735 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3736 This didn't break anything, but it didn't help either.
3737 It's confusing to put a bogus integer in a place where the actual
3738 value does not matter.
3739 (LIST_END_P): Remove unused macro and its bogus comment.
3740 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3742 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3743 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3745 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3746 We prefer signed types, and the value cannot exceed the EMACS_INT
3747 range anyway (because otherwise the length would not be representable).
3748 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3749 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3750 This avoids a GCC warning when WIDE_EMACS_INT.
3752 * indent.c (sane_tab_width): New function.
3753 (current_column, scan_for_column, Findent_to, position_indentation)
3754 (compute_motion): Use it. This is just for clarity.
3755 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3757 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3759 * lisp.h (lint_assume): New macro.
3760 * composite.c (composition_gstring_put_cache):
3761 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3763 * editfns.c, insdel.c:
3764 Omit unnecessary forward decls, to simplify future changes.
3766 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3768 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3770 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3771 Use much-faster test for byte-length change.
3772 Don't assume string byte-length fits in 'int'.
3773 Check that character arg fits in 'int'.
3774 (mapcar1): Declare byte as byte, for clarity.
3776 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3778 * fns.c (concat): Catch string overflow earlier.
3779 Do not rely on integer wraparound.
3781 * dispextern.h (struct it.overlay_strings_charpos)
3782 (struct it.selective): Now EMACS_INT, not int.
3783 * xdisp.c (forward_to_next_line_start)
3784 (back_to_previous_visible_line_start)
3785 (reseat_at_next_visible_line_start, next_element_from_buffer):
3786 Don't arbitrarily truncate the value of 'selective' to int.
3788 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3790 * composite.c: Don't truncate sizes to 'int'.
3791 (composition_gstring_p, composition_reseat_it)
3792 (composition_adjust_point): Use EMACS_INT, not int.
3793 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3794 not EMACS_UINT, for indexes.
3796 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3798 * buffer.c: Include <verify.h>.
3799 (struct sortvec.priority, struct sortstr.priority):
3800 Now EMACS_INT, not int.
3801 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3802 (struct sortstr.size, record_overlay_string)
3803 (struct sortstrlist.size, struct sortlist.used):
3804 Don't truncate size to int.
3805 (record_overlay_string): Check for size-calculation overflow.
3806 (init_buffer_once): Check at compile-time, not run-time.
3808 2011-06-22 Jim Meyering <meyering@redhat.com>
3810 Don't leak an XBM-image-sized buffer
3811 * image.c (xbm_load): Free the image buffer after using it.
3813 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3816 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3817 that Sun C diagnosed.
3818 * fns.c (secure_hash): Fix pointer signedness issue.
3819 * intervals.c (static_offset_intervals): New function.
3820 (offset_intervals): Use it.
3822 2011-06-21 Leo Liu <sdl.web@gmail.com>
3825 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3828 * fns.c (secure_hash): Rename from crypto_hash_function and change
3829 the first arg to accept symbols.
3830 (Fsecure_hash): New primitive.
3831 (syms_of_fns): New symbols.
3833 2011-06-20 Deniz Dogan <deniz@dogan.se>
3835 * process.c (Fset_process_buffer): Clarify return value in
3838 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3840 * dispnew.c (add_window_display_history): Use BVAR.
3842 * xdisp.c (debug_method_add): Use BVAR.
3843 (check_window_end, dump_glyph_matrix, dump_glyph)
3844 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3846 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3849 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3850 check till after the cache is created in init_frame_faces.
3852 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3854 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3856 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3858 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3859 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3860 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3862 Improve buffer-overflow checking (Bug#8873).
3863 * fileio.c (Finsert_file_contents):
3864 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3865 Remove the old (too-loose) buffer overflow checks.
3866 They weren't needed, since make_gap checks for buffer overflow.
3867 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3868 The old code merely checked for Emacs fixnum overflow, and relied
3869 on undefined (wraparound) behavior. The new code avoids undefined
3870 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3872 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3873 Tune. Don't use wider integers than needed. Don't use alloca.
3874 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3876 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3878 * insdel.c, lisp.h (buffer_overflow): New function.
3879 (insert_from_buffer_1, replace_range, replace_range_2):
3880 * insdel.c (make_gap_larger):
3881 * editfns.c (Finsert_char):
3882 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3884 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3886 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3888 Integer overflow and signedness fixes (Bug#8873).
3890 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3891 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3893 * fileio.c: Don't assume EMACS_INT fits in off_t.
3894 (emacs_lseek): New static function.
3895 (Finsert_file_contents, Fwrite_region): Use it.
3896 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3898 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3900 * fns.c: Don't overflow int when computing a list length.
3901 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3902 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3903 truncation on 64-bit hosts. Check for QUIT every
3904 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3905 faster and is responsive enough.
3906 (Flength): Report an error instead of overflowing an integer.
3907 (Fsafe_length): Return a float if the value is not representable
3908 as a fixnum. This shouldn't happen except in contrived situations.
3909 (Fnthcdr, Fsort): Don't assume list length fits in int.
3910 (Fcopy_sequence): Don't assume vector length fits in int.
3912 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3913 (header_size, word_size): New constants.
3914 (allocate_vectorlike): Don't check size overflow here.
3915 (allocate_vector): Check it here instead, since this is the only
3916 caller of allocate_vectorlike that could cause overflow.
3917 Check that the new vector's length is representable as a fixnum.
3919 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3920 The previous code was bogus. For example, next_almost_prime (32)
3921 returned 39, which is undesirable as it is a multiple of 3; and
3922 next_almost_prime (24) returned 25, which is a multiple of 5 so
3923 why was the code bothering to check for multiples of 7?
3925 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3927 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3929 Variadic C functions now count arguments with ptrdiff_t.
3930 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3931 Back then I didn't know that the Emacs coding style prefers signed int.
3932 Also, in the meantime I found a few more instances where arguments
3933 were being counted with int, which may truncate counts on 64-bit
3934 machines, or EMACS_INT, which may be unnecessarily wide.
3935 * lisp.h (struct Lisp_Subr.function.aMANY)
3936 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3937 Arg counts are now ptrdiff_t, not size_t.
3938 All variadic functions and their callers changed accordingly.
3939 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3940 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3941 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3942 * callint.c (Fcall_interactively): Check arg count for overflow,
3943 to avoid potential buffer overrun. Use signed char, not 'int',
3944 for 'varies' array, so that we needn't bother to check its size
3945 calculation for overflow.
3946 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3947 * eval.c (apply_lambda):
3948 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3949 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3950 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3952 * callint.c (Fcall_interactively): Don't use index var as event count.
3954 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3955 * mem-limits.h (SIZE): Remove; no longer used.
3957 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3959 Remove unnecessary casts.
3960 * xterm.c (x_term_init):
3961 * xfns.c (x_set_border_pixel):
3962 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3963 These aren't needed now that we assume ANSI C.
3965 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3966 It's more likely to cause problems (due to unsigned overflow)
3969 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3971 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3973 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3975 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3977 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3979 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3981 GLYPH_CODE_FACE returns EMACS_INT, not int.
3982 * dispextern.h (merge_faces):
3983 * xfaces.c (merge_faces):
3984 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3985 Don't assume EMACS_INT fits in int.
3987 * character.h (CHAR_VALID_P): Remove unused parameter.
3988 * fontset.c, lisp.h, xdisp.c: All uses changed.
3990 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3992 * fns.c (concat): Minor tuning based on overflow analysis.
3993 This doesn't fix any bugs. Use int to hold character, instead
3994 of constantly refetching from Emacs object. Use XFASTINT, not
3995 XINT, for value known to be a character. Don't bother comparing
3996 a single byte to 0400, as it's always less.
3998 * floatfns.c (Fexpt):
3999 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4001 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4004 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4006 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4007 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4008 incorrectly succeed when S was a string, because 4294967386 was
4009 truncated before it was used.
4011 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4012 Otherwise, an out-of-range integer could cause undefined behavior
4015 * composite.c: Use int, not EMACS_INT, for characters.
4016 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4017 EMACS_INT, for values that are known to be in character range.
4018 This doesn't fix any bugs but is the usual style inside Emacs and
4019 may generate better code on 32-bit machines.
4021 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4022 This is for reasons similar to the recent CHAR_STRING fix.
4023 * charset.c (Fencode_char): Check that character arg is actually
4024 a character. Pass an int to ENCODE_CHAR.
4025 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4026 wider than 'int', as a compile-time check to prevent future regressions
4029 * character.c (char_string): Remove unnecessary casts.
4031 Make sure a 64-bit char is never passed to CHAR_STRING.
4032 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4033 by silently ignoring the top 32 bits, allowing some values
4034 that were far too large to be valid characters.
4035 * character.h: Include <verify.h>.
4036 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4037 arguments are no wider than unsigned, as a compile-time check
4038 to prevent future regressions in this area.
4040 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4041 (Fsubst_char_in_region):
4043 * xdisp.c (decode_mode_spec_coding):
4044 Adjust to CHAR_STRING's new requirement.
4045 * editfns.c (Finsert_char, Fsubst_char_in_region):
4046 * fns.c (concat): Check that character args are actually
4047 characters. Without this test, these functions did the wrong
4048 thing with wildly out-of-range values on 64-bit hosts.
4050 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4051 These casts should not be needed on 32-bit hosts, either.
4052 * keyboard.c (read_char):
4053 * lread.c (Fload): Remove casts to unsigned.
4055 * lisp.h (UNSIGNED_CMP): New macro.
4056 This fixes comparison bugs on 64-bit hosts.
4057 (ASCII_CHAR_P): Use it.
4058 * casefiddle.c (casify_object):
4059 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4060 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4061 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4062 * dispextern.h (FACE_FROM_ID):
4063 * keyboard.c (read_char): Use UNSIGNED_CMP.
4065 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4066 not to EMACS_INT, to avoid GCC warning.
4068 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4070 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4071 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4072 isn't needed on 32-bit machines.
4074 * buffer.c (Fgenerate_new_buffer_name):
4075 Use EMACS_INT for count, not int.
4076 (advance_to_char_boundary): Return EMACS_INT, not int.
4078 * data.c (Qcompiled_function): Now static.
4080 * window.c (window_body_lines): Now static.
4082 * image.c (gif_load): Rename local to avoid shadowing.
4084 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4085 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4086 * alloc.c (make_save_value): Integer argument is now of type
4088 (mark_object): Use ptrdiff_t, not int.
4089 * lisp.h (pD): New macro.
4090 * print.c (print_object): Use it.
4092 * alloc.c: Use EMACS_INT, not int, to count objects.
4093 (total_conses, total_markers, total_symbols, total_vector_size)
4094 (total_free_conses, total_free_markers, total_free_symbols)
4095 (total_free_floats, total_floats, total_free_intervals)
4096 (total_intervals, total_strings, total_free_strings):
4097 Now EMACS_INT, not int. All uses changed.
4098 (Fgarbage_collect): Compute overall total using a double, so that
4099 integer overflow is less likely to be a problem. Check for overflow
4100 when converting back to an integer.
4101 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4102 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4103 These were 'int' variables that could overflow on 64-bit hosts;
4104 they were never used, so remove them instead of repairing them.
4105 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4106 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4107 Previously, this ceilinged at INT_MAX, but that doesn't work on
4109 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4111 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4112 (allocate_vectorlike): Check for ptrdiff_t overflow.
4113 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4114 when a (possibly-narrower) signed value would do just as well.
4115 We prefer using signed arithmetic, to avoid comparison confusion.
4117 * alloc.c: Catch some string size overflows that we were missing.
4118 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4119 for convenience in STRING_BYTES_MAX.
4120 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4121 The definition here is exact; the one in lisp.h was approximate.
4122 (allocate_string_data): Check for string overflow. This catches
4123 some instances we weren't catching before. Also, it catches
4124 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4125 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4126 and ptrdiff_t and EMACS_INT are both 64 bits.
4128 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4129 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4130 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4132 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4134 * alloc.c (Fmake_string): Check for out-of-range init.
4136 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4138 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4140 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4142 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4143 xg_get_default_scrollbar_width.
4145 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4146 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4147 (style_changed_cb): Call update_theme_scrollbar_width and call
4148 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4149 all frames (Bug#8505).
4150 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4151 Call gtk_window_set_resizable if HAVE_GTK3.
4152 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4153 and height if HAVE_GTK3 (Bug#8505).
4154 (scroll_bar_width_for_theme): New variable.
4155 (update_theme_scrollbar_width): New function.
4156 (xg_get_default_scrollbar_width): Move code to
4157 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4158 (xg_initialize): Call update_theme_scrollbar_width.
4160 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4162 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4164 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4166 * frame.c (make_frame): Call other_buffer_safely instead of
4169 * window.c (temp_output_buffer_show): Call display_buffer with
4170 second argument Vtemp_buffer_show_specifiers and reset latter
4171 immediately after the call.
4172 (Vtemp_buffer_show_specifiers): New variable.
4173 (auto_window_vscroll_p, next_screen_context_lines)
4174 (Vscroll_preserve_screen_position): Remove leading asterisks from
4177 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4179 Fix minor problems found by GCC 4.6.0 static checking.
4180 * buffer.c (Qclone_number): Remove for now, as it's unused.
4181 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4182 (record_buffer): Remove unused local.
4183 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4184 (set_frame_buffer_list): Remove; unused.
4185 * frame.h (other_visible_frames): Remove decl.
4186 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4187 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4188 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4190 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4191 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4192 Define only if HAVE_GPM.
4193 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4194 (update_hints_inhibit): Remove; never set. All uses removed.
4195 * widgetprv.h (emacsFrameClassRec): Remove decl.
4196 * window.c (delete_deletable_window): Now returns void, since it
4197 wasn't returning anything.
4198 (compare_window_configurations): Remove unused locals.
4199 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4200 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4201 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4202 the same widths as pointers. This follows up on the 2011-05-06 patch.
4203 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4204 * xterm.h: Likewise.
4205 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4207 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4209 * makefile.w32-in: Update dependencies.
4210 (LISP_H): Add lib/intprops.h.
4212 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4214 * image.c (gif_load): Add animation frame delay to the metadata.
4215 (syms_of_image): Use DEFSYM. New symbol `delay'.
4217 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4219 * window.c (delete_deletable_window): Re-add.
4220 (Fset_window_configuration): Rewrite to handle dead buffers and
4221 consequently deletable windows.
4222 (window_tree, Fwindow_tree): Remove. Supply functionality in
4224 (compare_window_configurations): Simplify code.
4226 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4228 * image.c (imagemagick_load_image): Fix type mismatch.
4229 (Fimagemagick_types): Likewise.
4231 * window.h (replace_buffer_in_windows): Declare.
4233 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4235 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4236 Qclone_number. Remove external declaration of Qdelete_window.
4237 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4239 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4240 Run Qbuffer_list_update_hook if allowed.
4241 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4242 buffer list implementation.
4243 (other_buffer_safely): New function.
4244 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4245 calls to replace_buffer_in_windows and
4246 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4248 (record_buffer): Inhibit quitting and rewrite using quittable
4249 functions. Run Qbuffer_list_update_hook if allowed.
4250 (Frecord_buffer, Funrecord_buffer): New functions.
4251 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4252 Move switch-to-buffer to window.el.
4253 (bury-buffer): Move to window.el.
4254 (Vbuffer_list_update_hook): New variable.
4256 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4259 * window.h (resize_frame_windows): Move up in code.
4260 (Fwindow_frame): Remove EXFUN.
4261 (replace_buffer_in_all_windows): Remove prototype.
4262 (replace_buffer_in_windows_safely): Add prototype.
4264 * window.c: Declare Qdelete_window static again. Move down
4265 declaration of select_count.
4266 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4267 (Fother_window): Move to window.el.
4268 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4269 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4270 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4272 (replace_buffer_in_windows): Implement by calling
4273 Qreplace_buffer_in_windows.
4274 (replace_buffer_in_all_windows): Remove with some functionality
4275 moved into replace_buffer_in_windows_safely.
4276 (replace_buffer_in_windows_safely): New function.
4277 (select_window_norecord, select_frame_norecord): Move in front
4278 of run_window_configuration_change_hook. Remove now obsolete
4280 (Fset_window_buffer): Rewrite doc-string.
4281 Call Qrecord_window_buffer.
4282 (keys_of_window): Move binding for other-window to window.el.
4284 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4286 * dispextern.h (struct image): Replace data member, whose int_val
4287 and ptr_val fields were not used by anything, with a single
4290 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4291 (gif_clear_image, gif_load, imagemagick_load_image)
4292 (gs_clear_image, gs_load): Callers changed.
4294 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4296 * buffer.h: Include <time.h>, for time_t.
4297 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4299 Fix minor problems found by static checking.
4301 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4303 Make identifiers static if they are not used in other modules.
4304 * data.c (Qcompiled_function, Qframe, Qvector):
4305 * image.c (QimageMagick, Qsvg):
4306 * minibuf.c (Qmetadata):
4307 * window.c (resize_window_check, resize_root_window): Now static.
4308 * window.h (resize_window_check, resize_root_window): Remove decls.
4310 * window.c (window_deletion_count, delete_deletable_window):
4312 (window_body_lines): Now static.
4313 (Fdelete_other_windows_internal): Mark vars as initialized.
4314 Make sure 'resize_failed' is initialized.
4315 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4316 (resize_window_apply): Remove unused local.
4317 * window.h (delete_deletable_window): Remove decl.
4319 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4320 (imagemagick_load_image): Fix pointer signedness problem by changing
4321 last arg from unsigned char * to char *. All uses changed.
4322 Also, fix a local for similar reasons.
4323 Remove unused locals. Remove locals to avoid shadowing.
4324 (fn_rsvg_handle_free): Remove; unused.
4325 (svg_load, svg_load_image): Fix pointer signedness problem.
4326 (imagemagick_load_image): Don't use garbage pointer image_wand.
4328 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4330 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4332 * image.c (gif_load): Fix omitted cast error introduced by
4335 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4337 * window.h (resize_proportionally, orig_total_lines)
4338 (orig_top_line): Remove from window structure.
4339 (set_window_height, set_window_width, change_window_heights)
4340 (Fdelete_window): Remove prototypes.
4341 (resize_frame_windows): Remove duplicate declaration.
4343 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4345 * window.h (resize_frame_windows, resize_window_check)
4346 (delete_deletable_window, resize_root_window)
4347 (resize_frame_windows): Declare prototypes.
4349 * window.c (resize_window_apply): Make definition be "static" to
4350 match the prototype.
4352 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4354 * window.c: Remove declarations of Qwindow_size_fixed,
4355 window_min_size_1, window_min_size_2, window_min_size,
4356 size_window, window_fixed_size_p, enlarge_window, delete_window.
4357 Remove static from declaration of Qdelete_window, it's
4358 temporarily needed by Fbury_buffer.
4359 (replace_window): Don't assign orig_top_line and
4361 (Fdelete_window, delete_window): Remove. Window deletion is
4362 handled by window.el.
4363 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4364 Replace Fdelete_window calls with calls to Qdelete_window.
4365 (Fdelete_other_windows): Remove. Deleting other windows is
4366 handled by window.el.
4367 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4368 handled in window.el.
4369 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4370 Window minimum sizes are handled in window.el.
4371 (shrink_windows, size_window, set_window_height)
4372 (set_window_width, change_window_heights, window_height)
4373 (window_width, CURBEG, CURSIZE, enlarge_window)
4374 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4375 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4376 handled in window.el.
4377 (make_dummy_parent): Rename to make_parent_window and give it a
4378 second argument horflag.
4379 (make_window): Don't set resize_proportionally any more.
4380 (Fsplit_window): Remove. Windows are split in window.el.
4381 (save_restore_action, save_restore_orig_size)
4382 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4383 Resize mini windows in window.el.
4384 (grow_mini_window, shrink_mini_window): Implement by calling
4385 Qresize_root_window_vertically, resize_window_check and
4386 resize_window_apply.
4387 (saved_window, Fset_window_configuration, save_window_save):
4388 Do not handle orig_top_line, orig_total_lines, and
4389 resize_proportionally.
4390 (window_min_height, window_min_width): Move to window.el.
4391 (keys_of_window): Move bindings for delete-other-windows,
4392 split-window, delete-window and enlarge-window to window.el.
4394 * buffer.c: Temporarily extern Qdelete_window.
4395 (Fbury_buffer): Temporarily call Qdelete_window instead of
4396 Fdelete_window (Fbury_buffer will move to window.el soon).
4398 * frame.c (set_menu_bar_lines_1): Remove code handling
4399 orig_top_line and orig_total_lines.
4401 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4402 set_window_height but set heights directly.
4403 (change_frame_size_1): Use resize_frame_windows.
4405 * xdisp.c (init_xdisp): Don't use set_window_height but set
4408 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4409 Use resize_frame_windows instead of change_window_heights and run
4410 run_window_configuration_change_hook.
4412 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4413 instead of change_window_heights and run
4414 run_window_configuration_change_hook.
4416 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4418 * window.c (replace_window): Rename second argument REPLACEMENT to
4419 NEW. New third argument SETFLAG. Rewrite.
4420 (delete_window, make_dummy_parent): Call replace_window with
4422 (window_list_1): Move down in code.
4423 (run_window_configuration_change_hook): Move set_buffer part
4424 before select_frame_norecord part in order to unwind correctly.
4425 Rename count1 to count.
4426 (recombine_windows, delete_deletable_window, resize_root_window)
4427 (Fdelete_other_windows_internal)
4428 (Frun_window_configuration_change_hook, make_parent_window)
4429 (resize_window_check, resize_window_apply, Fresize_window_apply)
4430 (resize_frame_windows, Fsplit_window_internal)
4431 (Fdelete_window_internal, Fresize_mini_window_internal):
4433 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4435 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4437 * window.h (window): Add some new members to window structure -
4438 normal_lines, normal_cols, new_total, new_normal, clone_number,
4439 splits, nest, prev_buffers, next_buffers.
4440 (WINDOW_TOTAL_SIZE): Move here from window.c.
4441 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4443 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4445 (make_dummy_parent): Set new members of windows structure.
4446 (make_window): Move down in code. Handle new members of window
4448 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4449 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4450 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4451 (Fset_window_prev_buffers, Fwindow_next_buffers)
4452 (Fset_window_next_buffers, Fset_window_clone_number):
4454 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4455 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4457 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4458 Argument WINDOW can be now internal window too.
4459 (Fwindow_use_time): Move up in code.
4460 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4462 (Fset_window_configuration, saved_window)
4463 (Fcurrent_window_configuration, save_window_save): Handle new
4464 members of window structure.
4465 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4466 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4467 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4468 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4469 Qget_mru_window, Qresize_root_window,
4470 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4471 Qauto_buffer_name; staticpro them.
4473 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4475 * window.c (Fwindow_total_size, Fwindow_left_column)
4476 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4477 (Fwindow_list_1): New functions.
4478 (window_box_text_cols): Replace with window_body_cols.
4479 (Fwindow_width, Fscroll_left, Fscroll_right):
4480 Use window_body_cols instead of window_box_text_cols.
4481 (delete_window, Fset_window_configuration):
4482 Call delete_all_subwindows with window as argument.
4483 (delete_all_subwindows): Take a window as argument and not a
4485 (window_loop): Remove handling of GET_LRU_WINDOW and
4487 (Fget_lru_window, Fget_largest_window): Move to window.el.
4489 * window.h: Extern window_body_cols instead of
4490 window_box_text_cols. delete_all_subwindows now takes a
4491 Lisp_Object as argument.
4493 * indent.c (compute_motion, Fcompute_motion):
4494 Use window_body_cols instead of window_box_text_cols.
4496 * frame.c (delete_frame): Call delete_all_subwindows with root
4499 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4501 * fns.c (Fputhash): Document return value.
4503 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4505 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4507 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4509 Cons<->int and similar integer overflow fixes (Bug#8794).
4511 Check for overflow when converting integer to cons and back.
4512 * charset.c (Fdefine_charset_internal, Fdecode_char):
4513 Use cons_to_unsigned to catch overflow.
4514 (Fencode_char): Use INTEGER_TO_CONS.
4515 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4516 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4517 * data.c (long_to_cons, cons_to_long): Remove.
4518 (cons_to_unsigned, cons_to_signed): New functions.
4519 These signal an error for invalid or out-of-range values.
4520 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4521 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4522 * font.c (Ffont_variation_glyphs):
4523 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4524 * lisp.h: Include <intprops.h>.
4525 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4526 (cons_to_signed, cons_to_unsigned): New decls.
4527 (long_to_cons, cons_to_long): Remove decls.
4528 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4529 (Fprimitive_undo): Use CONS_TO_INTEGER.
4530 * xfns.c (Fx_window_property): Likewise.
4531 * xselect.c: Include <limits.h>.
4532 (x_own_selection, selection_data_to_lisp_data):
4533 Use INTEGER_TO_CONS.
4534 (x_handle_selection_request, x_handle_selection_clear)
4535 (x_get_foreign_selection, Fx_disown_selection_internal)
4536 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4537 (lisp_data_to_selection_data): Use cons_to_unsigned.
4538 (x_fill_property_data): Use cons_to_signed.
4539 Report values out of range.
4541 Check for buffer and string overflow more precisely.
4542 * buffer.h (BUF_BYTES_MAX): New macro.
4543 * lisp.h (STRING_BYTES_MAX): New macro.
4544 * alloc.c (Fmake_string):
4545 * character.c (string_escape_byte8):
4546 * coding.c (coding_alloc_by_realloc):
4547 * doprnt.c (doprnt):
4548 * editfns.c (Fformat):
4550 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4551 since they may not be the same number.
4552 * editfns.c (Finsert_char):
4553 * fileio.c (Finsert_file_contents):
4554 Likewise for BUF_BYTES_MAX.
4556 * image.c: Use ptrdiff_t, not int, for sizes.
4557 (slurp_file): Switch from int to ptrdiff_t.
4559 (slurp_file): Check that file size fits in both size_t (for
4560 malloc) and ptrdiff_t (for sanity and safety).
4562 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4563 if b->modtime has its maximal value.
4565 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4567 Don't assume time_t can fit into int.
4568 * buffer.h (struct buffer.modtime): Now time_t, not int.
4569 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4570 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4572 Minor fixes for signed vs unsigned integers.
4573 * character.h (MAYBE_UNIFY_CHAR):
4574 * charset.c (maybe_unify_char):
4575 * keyboard.c (read_char, reorder_modifiers):
4576 XINT -> XFASTINT, since the integer must be nonnegative.
4577 * ftfont.c (ftfont_spec_pattern):
4578 * keymap.c (access_keymap, silly_event_symbol_error):
4579 XUINT -> XFASTINT, since the integer must be nonnegative.
4580 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4581 since it makes no difference and we prefer signed.
4582 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4583 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4586 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4588 * window.h (Fwindow_frame): Declare.
4590 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4592 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4593 (SPARE_MEMORY): Always define.
4594 (LARGE_REQUEST): Remove.
4595 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4597 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4599 * lisp.h: Move EXFUNS for Fframe_root_window,
4600 Fframe_first_window and Fset_frame_selected_window to window.h.
4602 * window.h: Move EXFUNS for Fframe_root_window,
4603 Fframe_first_window and Fset_frame_selected_window here from
4606 * frame.c (Fwindow_frame, Fframe_first_window)
4607 (Fframe_root_window, Fframe_selected_window)
4608 (Fset_frame_selected_window): Move to window.c.
4609 (Factive_minibuffer_window): Move to minibuf.c.
4610 (Fother_visible_frames_p): New function.
4612 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4614 * window.c (decode_window, decode_any_window): Move up in code.
4615 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4616 (inhibit_frame_unsplittable): Remove unused variable.
4617 (Fwindow_buffer): Move up and rewrite doc-string.
4618 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4619 (Fwindow_prev): New functions.
4620 (Fwindow_frame): Move here from frame.c. Accept any window as
4622 (Fframe_root_window, Fframe_first_window)
4623 (Fframe_selected_window): Move here from frame.c. Accept frame
4624 or arbitrary window as argument. Update doc-strings.
4625 (Fminibuffer_window): Move up in code.
4626 (Fwindow_minibuffer_p): Move up in code and simplify.
4627 (Fset_frame_selected_window): Move here from frame.c.
4629 (Fselected_window, select_window, Fselect_window): Move up in
4630 code. Minor doc-string fixes.
4632 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4634 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4635 Do not assume that spare memory exists; that assumption is valid
4636 only if SYSTEM_MALLOC.
4637 (LARGE_REQUEST): New macro, so that the issue of large requests
4638 is separated from the issue of spare memory.
4640 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4642 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4645 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4647 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4650 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4652 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4654 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4656 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4657 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4659 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4661 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4663 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4665 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4666 (x_clipboard_manager_save): Add return value.
4667 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4669 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4670 Obey Vx_select_enable_clipboard_manager. Catch errors in
4671 x_clipboard_manager_save (Bug#8779).
4672 (Vx_select_enable_clipboard_manager): New variable.
4673 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4675 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4677 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4679 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4681 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4682 in the current matrix if keep_current_p is non-zero.
4684 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4686 * bidi.c (bidi_level_of_next_char): Fix last change.
4688 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4690 Support bidi reordering of text covered by display properties.
4692 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4693 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4694 (bidi_cache_search, bidi_cache_iterator_state)
4695 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4696 (bidi_level_of_next_char, bidi_move_to_visually_next):
4697 Support character positions inside a run of characters covered by a
4699 (bidi_paragraph_init, bidi_resolve_explicit_1)
4700 (bidi_level_of_next_char): Call bidi_fetch_char and
4701 bidi_fetch_char_advance instead of FETCH_CHAR and
4703 (bidi_init_it): Initialize new members.
4704 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4706 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4707 instead of using explicit *_CHAR codes.
4708 (bidi_resolve_explicit, bidi_resolve_weak):
4709 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4710 bidirectional text is supported only in multibyte buffers.
4711 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4712 it to initialize the frame_window_p member of struct bidi_it.
4713 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4714 (bidi_resolve_explicit, bidi_resolve_weak)
4715 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4716 bidi_it->nchars is non-positive.
4717 (bidi_level_of_next_char): Don't try to lookup the cache for the
4718 next/previous character if nothing is cached there yet, or if we
4719 were just reseat()'ed to a new position.
4721 * xdisp.c (set_cursor_from_row): Set start and stop points
4722 according to the row's direction when priming the loop that looks
4723 for the glyph on which to display cursor.
4724 (single_display_spec_intangible_p): Function deleted.
4725 (display_prop_intangible_p): Reimplement to call
4726 handle_display_spec instead of single_display_spec_intangible_p.
4727 Accept 3 additional arguments needed by handle_display_spec.
4728 This fixes incorrect cursor motion across display property with complex
4729 values: lists, `(when COND...)' forms, etc.
4730 (single_display_spec_string_p): Support property values that are
4731 lists with the argument STRING its top-level element.
4732 (display_prop_string_p): Fix the condition for processing a
4733 property that is a list to be consistent with handle_display_spec.
4734 (handle_display_spec): New function, refactored from the
4735 last portion of handle_display_prop.
4736 (compute_display_string_pos): Accept additional argument
4737 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4738 value of a `display' property is a "replacing spec".
4739 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4740 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4741 the display property, but just return a value indicating whether
4742 the display property will replace the characters it covers.
4743 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4744 frame_window_p members of struct bidi_it.
4745 (compute_display_string_pos, compute_display_string_end):
4747 (push_it): Accept second argument POSITION, where pop_it should
4748 jump to continue iteration.
4749 (reseat_1): Initialize bidi_it.disp_pos.
4751 * keyboard.c (adjust_point_for_property): Adjust the call to
4752 display_prop_intangible_p to its new signature.
4754 * dispextern.h (struct bidi_it): New member frame_window_p.
4755 (bidi_init_it): Update prototypes.
4756 (display_prop_intangible_p): Update prototype.
4757 (compute_display_string_pos, compute_display_string_end):
4759 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4762 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4764 Malloc failure behavior now depends on size of allocation.
4765 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4766 * lisp.h: Change signatures accordingly.
4767 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4768 All callers changed. (Bug#8762)
4770 * gnutls.c: Use Emacs's memory allocators.
4771 Without this change, the gnutls library would invoke malloc etc.
4772 directly, which causes problems on non-SYNC_INPUT hosts, and which
4773 runs afoul of improving memory_full behavior. (Bug#8761)
4774 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4775 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4776 xfree instead of the default malloc, realloc, free.
4777 (Fgnutls_boot): No need to check for memory allocation failure,
4778 since xmalloc does that for us.
4780 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4781 * category.c (hash_get_category_set):
4782 * ccl.c (ccl_driver):
4783 * charset.c (Fdefine_charset_internal):
4784 * charset.h (struct charset.hash_index):
4785 * composite.c (get_composition_id, gstring_lookup_cache)
4786 (composition_gstring_put_cache):
4787 * composite.h (struct composition.hash_index):
4788 * dispextern.h (struct image.hash):
4789 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4790 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4791 (hashfn_equal, hashfn_user_defined, make_hash_table)
4792 (maybe_resize_hash_table, hash_lookup, hash_put)
4793 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4794 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4795 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4796 * image.c (make_image, search_image_cache, lookup_image)
4797 (xpm_put_color_table_h):
4798 * lisp.h (struct Lisp_Hash_Table):
4799 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4800 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4801 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4802 * alloc.c (allocate_vectorlike):
4803 Check for overflow in vector size calculations.
4804 * ccl.c (ccl_driver):
4805 Check for overflow when converting EMACS_INT to int.
4806 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4807 need to be updated by these changes.
4808 * fns.c (make_hash_table, maybe_resize_hash_table):
4809 Check for integer overflow with large hash tables.
4810 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4811 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4812 (SXHASH_REDUCE): New macro.
4813 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4814 Use it instead of discarding useful hash info with large hash values.
4815 (sxhash_float): New function.
4816 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4817 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4818 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4819 Rewrite to use FIXNUM_BITS, as this simplifies things.
4820 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4821 Adjust signatures to match updated version of code.
4822 (consing_since_gc): Now EMACS_INT, since a single hash table can
4823 use more than INT_MAX bytes.
4825 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4827 Make it possible to build with GCC-4.6+ -O2 -flto.
4829 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4831 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4833 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4834 Call minibuffer-inactive-mode.
4836 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4838 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4839 Update dependencies.
4841 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4843 * data.c (init_data): Remove code for UTS, this system is not
4846 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4848 Don't force ./temacs to start in terminal mode.
4850 * frame.c (make_initial_frame): Initialize faces in all cases, not
4851 only when CANNOT_DUMP is defined.
4852 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4854 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4856 * dispnew.c (add_window_display_history): Use const for the string
4857 pointer. Remove declaration, not needed.
4859 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4861 Use 'inline', not 'INLINE'.
4862 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4863 * alloc.c, fontset.c (INLINE): Remove.
4864 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4865 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4866 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4867 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4868 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4870 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4872 Make it possible to run ./temacs.
4874 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4875 syms_of_callproc does the same thing. Remove test for
4876 "initialized", do it in the caller.
4877 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4879 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4881 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4882 (read_minibuf): Use get_minibuffer.
4883 (syms_of_minibuf): Use DEFSYM.
4884 (Qmetadata): New var.
4885 * data.c (Qbuffer): Don't make it static.
4886 (syms_of_data): Use DEFSYM.
4888 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4890 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4891 (CCL_CODE_MIN): New macro.
4893 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4895 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4897 * eval.c (Qdebug): Now static.
4898 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4899 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4900 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4902 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4904 * image.c: Various fixes to ImageMagick code comments.
4905 (Fimagemagick_types): Doc fix.
4907 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4909 Minor fixes prompted by GCC 4.6.0 warnings.
4911 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4913 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4914 (x_clipboard_manager_save_all): Move extern decl to ...
4915 * xterm.h: ... here, so that it can be checked for consistency.
4917 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4919 * xselect.c (x_clipboard_manager_save_frame)
4920 (x_clipboard_manager_save_all): New functions.
4921 (Fx_clipboard_manager_save): Lisp function deleted.
4923 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4924 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4926 * xterm.h: Update prototype.
4928 2011-05-28 William Xu <william.xwl@gmail.com>
4930 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4933 2011-05-28 Jim Meyering <meyering@redhat.com>
4935 Avoid a sign-extension bug in crypto_hash_function.
4936 * fns.c (to_uchar): Define.
4937 (crypto_hash_function): Use it to convert some newly-signed
4938 variables to unsigned, to avoid sign-extension bugs. For example,
4939 without this change, (md5 "truc") would evaluate to
4940 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4941 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4942 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4944 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4946 Integer overflow fixes.
4948 * dbusbind.c: Serial number integer overflow fixes.
4949 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4950 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4951 to hold a serial number that is too large for a fixnum.
4952 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4953 Check for serial numbers out of range. Decode any serial number
4954 that was so large that it became a float. (Bug#8722)
4956 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4957 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4958 Use XFASTINT rather than XUINT when numbers are nonnegative.
4959 (xd_append_arg, Fdbus_method_return_internal):
4960 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4961 arguments, check that Lisp number is nonnegative, rather than
4962 silently wrapping negative numbers around. (Bug#8722)
4963 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4966 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4968 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4970 ccl: add integer overflow checks
4971 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4972 (IN_INT_RANGE): New macros.
4973 (ccl_driver): Use them to check for integer overflow when
4974 decoding a CCL program. Many of the new checks are whether XINT (x)
4975 fits in int; it doesn't always, on 64-bit hosts. The new version
4976 doesn't catch all possible integer overflows, but it's an
4977 improvement. (Bug#8719)
4979 * alloc.c (make_event_array): Use XINT, not XUINT.
4980 There's no need for unsigned here.
4982 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4983 This follows up to the 2011-05-06 change that substituted uintptr_t
4984 for EMACS_INT. This case wasn't caught back then.
4986 Rework Fformat to avoid integer overflow issues.
4987 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4988 now (part of C89). Include <verify.h>.
4989 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4990 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4991 (Fformat): Avoid the prepass trying to compute sizes; it was only
4992 approximate and thus did not catch overflow reliably. Instead, walk
4993 through the format just once, formatting and computing sizes as we go,
4994 checking for integer overflow at every step, and allocating a larger
4995 buffer as needed. Keep track separately whether the format is
4996 multibyte. Keep only the most-recently calculated precision, rather
4997 than them all. Record whether each argument has been converted to
4998 string. Use EMACS_INT, not int, for byte and char and arg counts.
4999 Support field widths and precisions larger than INT_MAX. Avoid
5000 sprintf's undefined behavior with conversion specifications such as %#d
5001 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5002 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5003 formatting out-of-range floating point numbers with int
5006 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5008 * data.c: Avoid integer truncation in expressions involving floats.
5009 * data.c: Include <intprops.h>.
5010 (arith_driver): When there's an integer overflow in an expression
5011 involving floating point, convert the integers to floating point
5012 so that the resulting value does not suffer from catastrophic
5013 integer truncation. For example, on a 64-bit host (* 4
5014 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5015 Do not rely on undefined behavior after integer overflow.
5017 merge count_size_as_multibyte, parse_str_to_multibyte
5018 * character.c, character.h (count_size_as_multibyte):
5019 Rename from parse_str_to_multibyte; all uses changed.
5020 Check for integer overflow.
5021 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5022 since it's now a duplicate of the other. This is more of
5023 a character than a buffer op, so better that it's in character.c.
5024 * fns.c, print.c: Adjust to above changes.
5026 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5028 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5030 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5032 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5033 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5034 (x_clipboard_manager_save): Now static.
5035 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5037 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5038 (crypto_hash_function): Now static.
5039 Fix pointer signedness problems. Avoid unnecessary initializations.
5041 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5043 * termhooks.h (Vselection_alist): Make it terminal-local.
5045 * terminal.c (create_terminal): Initialize it.
5047 * xselect.c: Support for clipboard managers.
5048 (Vselection_alist): Move to termhooks.h as terminal-local var.
5049 (LOCAL_SELECTION): New macro.
5050 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5051 (symbol_to_x_atom): Remove gratuitous arg.
5052 (x_handle_selection_request, lisp_data_to_selection_data)
5053 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5054 (x_own_selection, x_get_local_selection, x_convert_selection):
5055 New arg, specifying work frame. Use terminal-local Vselection_alist.
5056 (some_frame_on_display): Delete unused function.
5057 (Fx_own_selection_internal, Fx_get_selection_internal)
5058 (Fx_disown_selection_internal, Fx_selection_owner_p)
5059 (Fx_selection_exists_p): New optional frame arg.
5060 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5061 (x_handle_selection_clear): Don't treat other terminals with the
5062 same keyboard specially. Use the terminal-local Vselection_alist.
5063 (x_clear_frame_selections): Use Frun_hook_with_args.
5065 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5067 * xterm.h: Add support for those atoms.
5069 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5071 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5072 (converted_selections, conversion_fail_tag): New global variables.
5073 (x_selection_request_lisp_error): Free the above.
5074 (x_get_local_selection): Remove unnecessary code.
5075 (x_reply_selection_request): Args changed; handle arbitrary array
5076 of converted selections stored in converted_selections.
5077 Separate the XChangeProperty and SelectionNotify steps.
5078 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5079 (x_convert_selection): New function.
5080 (x_handle_selection_event): Simplify.
5081 (x_get_foreign_selection): Don't ignore incoming requests while
5082 waiting for an answer; this will fail when we implement
5083 SAVE_TARGETS, and seems unnecessary anyway.
5084 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5085 (Vx_sent_selection_functions): Doc fix.
5087 2011-05-26 Leo Liu <sdl.web@gmail.com>
5089 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5091 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5093 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5095 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5096 for fringe update if it has periodic bitmap.
5097 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5098 and fringe_bitmap_periodic_p.
5100 * fringe.c (get_fringe_bitmap_data): New function.
5101 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5102 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5103 row. Mark glyph row for fringe update if periodicity changed.
5105 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5106 for fringe update unless it has periodic bitmap.
5108 2011-05-25 Kenichi Handa <handa@m17n.org>
5110 * xdisp.c (get_next_display_element): Set correct it->face_id for
5111 a static composition.
5113 2011-05-24 Leo Liu <sdl.web@gmail.com>
5116 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5118 * fns.c (crypto_hash_function, Fsha1): New function.
5119 (Fmd5): Use crypto_hash_function.
5120 (syms_of_fns): Add Ssha1.
5122 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5124 * gnutls.c: Remove unused macros.
5125 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5126 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5127 Remove macros that are defined and never used.
5128 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5130 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5132 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5133 (Fx_get_selection_internal): Minor cleanup.
5134 (Fx_own_selection_internal): Rename arguments for consistency with
5137 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5139 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5141 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5143 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5145 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5147 * dispnew.c (scrolling_window): Don't exclude the case that the
5148 last enabled row in the desired matrix touches the bottom boundary.
5150 2011-05-21 Glenn Morris <rgm@gnu.org>
5152 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5153 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5154 and add some more files.
5156 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5158 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5159 report_file_error introduced by the change from 2011-05-07.
5161 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5163 * systime.h (Time): Define only if emacs is defined.
5164 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5165 where the include path doesn't have X11/X.h by default. See
5166 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5168 2011-05-20 Kenichi Handa <handa@m17n.org>
5170 * composite.c (find_automatic_composition): Fix previous change.
5172 2011-05-20 Glenn Morris <rgm@gnu.org>
5174 * lisp.mk: New file, split from Makefile.in.
5175 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5176 (shortlisp): Remove.
5177 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5179 2011-05-19 Glenn Morris <rgm@gnu.org>
5181 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5182 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5183 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5184 (lisp): Set the order to that of loadup.el.
5185 (shortlisp): Make it a copy of $lisp.
5186 (SOME_MACHINE_LISP): Remove.
5187 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5188 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5190 2011-05-18 Kenichi Handa <handa@m17n.org>
5192 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5193 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5194 (find_automatic_composition): Mostly rewrite for efficiency.
5196 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5198 * makefile.w32-in: Update dependencies.
5200 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5202 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5203 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5205 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5207 Fix some integer overflow issues, such as string length overflow.
5209 * insdel.c (count_size_as_multibyte): Check for string overflow.
5211 * character.c (lisp_string_width): Check for string overflow.
5212 Use EMACS_INT, not int, for string indexes and lengths; in
5213 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5214 the resulting string length overflows an EMACS_INT; instead,
5215 report a string overflow if no precision given. When checking for
5216 precision exhaustion, use a check that cannot possibly have
5217 integer overflow. (Bug#8675)
5218 * character.h (lisp_string_width): Adjust to new signature.
5220 * alloc.c (string_overflow): New function.
5221 (Fmake_string): Use it. This doesn't change behavior, but saves
5222 a few bytes and will simplify future changes.
5223 * character.c (string_escape_byte8): Likewise.
5224 * lisp.h (string_overflow): New decl.
5226 Fixups, following up to the user-interface timestamp change.
5227 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5228 for UI timestamps, instead of unsigned long.
5229 * msdos.c (mouse_get_pos): Likewise.
5230 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5231 * w32gui.h (Time): Define by including "systime.h" rather than by
5232 declaring it ourselves. (Bug#8664)
5234 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5235 * image.c (clear_image_cache): Likewise.
5237 * term.c (term_mouse_position): Don't assume time_t wraparound.
5239 Be more systematic about user-interface timestamps.
5240 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5241 and sometimes 'EMACS_UINT', to represent these timestamps.
5242 This change causes it to use 'Time' uniformly, as that's what X uses.
5243 This makes the code easier to follow, and makes it easier to catch
5244 integer overflow bugs such as Bug#8664.
5245 * frame.c (Fmouse_position, Fmouse_pixel_position):
5246 Use Time, not unsigned long, for user-interface timestamps.
5247 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5248 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5249 * keyboard.h (last_event_timestamp): Likewise.
5250 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5251 * menu.h (xmenu_show): Likewise.
5252 * term.c (term_mouse_position): Likewise.
5253 * termhooks.h (struct input_event.timestamp): Likewise.
5254 (struct terminal.mouse_position_hook): Likewise.
5255 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5256 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5257 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5258 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5260 * menu.h, termhooks.h: Include "systime.h", for Time.
5262 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5263 Don't assume that the difference between two unsigned long values
5264 can fit into an integer. At this point, we know button_down_time
5265 <= event->timestamp, so the difference must be nonnegative, so
5266 there's no need to cast the result if double-click-time is
5267 nonnegative, as it should be; check that it's nonnegative, just in
5268 case. This bug is triggered when events are more than 2**31 ms
5269 apart (about 25 days). (Bug#8664)
5271 * xselect.c (last_event_timestamp): Remove duplicate decl.
5272 (x_own_selection): Remove needless cast to unsigned long.
5274 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5275 that always fit in int. Use a sentinel instead of a counter, to
5276 avoid a temp and to allay GCC's concerns about possible int overflow.
5277 * frame.h (struct frame): Use int for menu_bar_items_used
5278 instead of EMACS_INT, since it always fits in int.
5280 * menu.c (grow_menu_items): Check for int overflow.
5282 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5284 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5285 Before, the code was not consistent. These values cannot exceed
5286 2**31 - 1 so there's no need to make them unsigned.
5287 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5288 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5289 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5291 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5293 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5294 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5295 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5296 presumably because the widths might not match.
5298 * window.c (size_window): Avoid needless test at loop start.
5300 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5302 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5304 2011-05-12 Drew Adams <drew.adams@oracle.com>
5306 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5308 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5310 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5311 `width' to `bar_area_x' and `bar_area_width', respectively.
5312 (x_scroll_run): Take account of fringe background extension.
5314 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5315 Rename local vars `left' and `width' to `bar_area_x' and
5316 `bar_area_width', respectively.
5317 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5318 background extension.
5320 2011-05-10 Jim Meyering <meyering@redhat.com>
5322 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5324 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5326 * image.c (Finit_image_library): Return t for built-in image types,
5327 like pbm and xbm. (Bug#8640)
5329 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5331 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5333 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5335 * w32console.c (Fset_screen_color): Doc fix.
5336 (Fget_screen_color): New function.
5337 (syms_of_ntterm): Defsubr it.
5339 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5340 unlink the temporary file if Fcall_process didn't create it in the
5342 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5343 child process will be redirected to a file specified with `:file'.
5344 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5345 cue to call_process_cleanup not to close that handle.
5347 2011-05-07 Ben Key <bkey76@gmail.com>
5349 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5350 one of two shell specific rules, either bootstrap-temacs-CMD or
5351 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5352 to the previous implementation of the bootstrap-temacs rule.
5353 The bootstrap-temacs-CMD rule is similar to the previous
5354 implementation of the bootstrap-temacs rule except that it
5355 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5358 These changes, along with some changes to nt/configure.bat,
5359 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5360 earlier fix to add support for --cflags and --ldflags options
5361 that include quotes so that it works whether make uses cmd or
5364 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5366 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5367 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5369 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5370 a string. Handle both cases.
5371 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5372 (Fdbus_register_method): Use Qinvalid_function.
5374 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5376 * makefile.w32-in: Update dependencies.
5377 (LISP_H): Add inttypes.h and stdin.h.
5378 (PROCESS_H): Add unistd.h.
5380 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5382 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5383 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5385 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5387 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5389 * term.c (vfatal): Remove stray call to va_end.
5390 It's not needed and the C Standard doesn't allow it here anyway.
5392 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5393 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5395 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5398 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5400 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5402 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5404 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5406 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5408 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5409 * charset.c (Fdefine_charset_internal): Don't initialize
5410 charset.code_space[15]. The value was garbage, on hosts with
5411 32-bit int (Bug#8600).
5413 * lread.c (read_integer): Be more consistent with string-to-number.
5414 Use string_to_number to do the actual conversion; this avoids
5415 rounding errors and fixes some other screwups. Without this fix,
5416 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5417 (digit_to_number): Move earlier, for benefit of read_integer.
5418 Return -1 if the digit is out of range for the base, -2 if it is
5419 not a digit in any supported base. (Bug#8602)
5421 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5423 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5424 to match comment at start of function. This also removes a
5425 GCC warning about overflow in a 32+64-bit port.
5427 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5429 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5430 Reported by Stefan Monnier in
5431 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5432 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5433 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5435 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5436 (EMACS_UINTPTR): Likewise, with uintptr_t.
5438 * lisp.h: Prefer 64-bit EMACS_INT if available.
5439 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5440 on 32-bit hosts that have 64-bit int, so that they can access
5442 However, temporarily disable this change unless the temporary
5443 symbol WIDE_EMACS_INT is defined.
5445 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5447 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5448 This removes an assumption that EMACS_INT and long are the same
5449 width as pointers. The assumption is true for Emacs porting targets
5450 now, but we want to make other targets possible.
5451 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5452 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5453 In the rest of the code, change types of integers that hold casted
5454 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5455 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5456 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5457 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5458 No need to cast type when ORing.
5459 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5460 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5461 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5462 assume EMACS_INT is the same width as char *.
5463 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5464 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5465 Remove no-longer-needed casts.
5466 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5467 (xg_tool_bar_help_callback, xg_make_tool_item):
5468 Use EMACS_INTPTR to hold an integer
5469 that will be cast to void *; this can avoid a GCC warning
5470 if EMACS_INT is not the same width as void *.
5471 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5472 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5473 (current_message_1, set_message_1):
5474 Use a local to convert to proper width without a cast.
5475 * xmenu.c (dialog_selection_callback): Likewise.
5477 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5478 Also, don't assume VALBITS / RAND_BITS is less than 5,
5479 and don't rely on undefined behavior when shifting a 1 left into
5481 * lisp.h (get_random): Change signature to match.
5483 * lread.c (hash_string): Use size_t, not int, for hash computation.
5484 Normally we prefer signed values; but hashing is special, because
5485 it's better to use unsigned division on hash table sizes so that
5486 the remainder is nonnegative. Also, size_t is the natural width
5487 for hashing into memory. The previous code used 'int', which doesn't
5488 retain enough info to hash well into very large tables.
5489 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5491 * dbusbind.c: Don't possibly lose pointer info when converting.
5492 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5493 Use XPNTR rather than XHASH, so that the high-order bits of
5494 the pointer aren't lost when converting through void *.
5496 * eval.c (Fautoload): Don't double-shift a pointer.
5498 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5500 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5502 * gnutls.c (DEF_GNUTLS_FN):
5503 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5505 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5507 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5510 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5512 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5513 New version that can reserve upto 2GB of heap space.
5515 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5517 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5519 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5521 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5522 `gnutls_certificate_set_x509_key_file'.
5524 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5526 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5527 Update dependencies.
5529 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5531 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5532 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5533 Remove unused parameter `fildes'.
5534 * process.c (read_process_output, send_process): Don't pass it.
5536 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5538 Fix previous change: the library cache is defined in w32.c.
5539 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5540 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5542 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5544 Implement dynamic loading of GnuTLS on Windows.
5546 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5547 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5548 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5551 * gnutls.c (Qgnutls_dll): Define.
5552 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5553 (gnutls_*): Declare function pointers.
5554 (init_gnutls_functions): New function to initialize function pointers.
5555 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5556 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5557 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5558 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5559 (emacs_gnutls_write, emacs_gnutls_read)
5560 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5561 (Fgnutls_available_p): New function.
5562 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5563 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5564 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5566 * image.c: Include w32.h.
5567 (Vimage_type_cache): Delete.
5568 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5569 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5570 (w32_delayed_load): Move to w32.c.
5572 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5574 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5575 (w32_delayed_load): Move from image.c. When loading a library, record
5576 its filename in the :loaded-from property of the library id.
5577 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5578 Initialize and staticpro them.
5579 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5581 * process.c: Include lisp.h before w32.h, not after.
5582 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5583 instead of gnutls_record_check_pending.
5585 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5587 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5589 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5590 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5593 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5595 * xterm.c (x_set_frame_alpha): Do not set property on anything
5596 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5598 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5600 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5602 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5604 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5605 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5606 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5607 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5608 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5609 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5610 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5611 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5612 (Qgnutls_bootprop_callbacks_verify): Make static.
5614 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5616 * callproc.c: Indentation fixup.
5618 * sysdep.c (wait_for_termination_1): Make static.
5619 (wait_for_termination, interruptible_wait_for_termination):
5620 Move after wait_for_termination_1.
5622 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5624 * sysdep.c (interruptible_wait_for_termination): New function
5625 which is like wait_for_termination, but allows keyboard
5628 * callproc.c (Fcall_process): Add (:file "file") as an option for
5630 (Fcall_process_region): Ditto.
5632 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5634 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5635 rather than `XVECTOR (FOO)->size'.
5637 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5638 inttypes.h, as a gnulib replacement is used if it not available in
5641 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5643 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5644 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5645 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5647 * coding.c (coding_alloc_by_realloc): Error out if destination
5648 will grow beyond MOST_POSITIVE_FIXNUM.
5649 (decode_coding_emacs_mule): Abort if there isn't enough place in
5650 charbuf for the composition carryover bytes. Reserve an extra
5651 space for up to 2 characters produced in a loop.
5652 (decode_coding_iso_2022): Abort if there isn't enough place in
5653 charbuf for the composition carryover bytes.
5655 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5657 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5658 aborting when %lld or %lll format is passed.
5659 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5660 %llo or %llx format is passed. (Bug#8545)
5662 * window.c (window_scroll_line_based): Use a marker instead of
5663 simple variables to record original value of point. (Bug#7952)
5665 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5666 produced by %s or %c overflows available buffer space. (Bug#8545)
5668 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5670 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5671 (SIZE_MAX): Move defn after all includes, as they might #define it.
5673 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5675 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5677 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5679 * keyboard.c (Qdelayed_warnings_hook): Define.
5680 (command_loop_1): Run `delayed-warnings-hook'
5681 if Vdelayed_warnings_list is non-nil.
5682 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5683 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5685 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5687 * doprnt.c (doprnt): Don't return value smaller than the buffer
5688 size if the message was truncated. (Bug#8545).
5690 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5692 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5693 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5695 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5697 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5699 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5701 * makefile.w32-in: Update dependencies.
5703 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5705 Improve `doprnt' and its usage. (Bug#8545)
5706 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5707 `format_end'. Remove support for %l as a conversion specifier.
5708 Don't use xrealloc. Improve diagnostics when the %l size modifier
5709 is used. Update the commentary.
5711 * eval.c (verror): Simplify calculation of size_t.
5713 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5716 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5718 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5721 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5723 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5724 This makes this file independent of the recent pseudovector change.
5726 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5728 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5730 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5731 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5732 Remove unused local.
5733 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5735 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5736 GCC 4.6.0 optimizes based on type-based alias analysis.
5737 For example, if b is of type struct buffer * and v of type struct
5738 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5739 != &v->size, and therefore "v->size = 1; b->size = 2; return
5740 v->size;" must therefore return 1. This assumption is incorrect
5741 for Emacs, since it type-puns struct Lisp_Vector * with many other
5742 types. To fix this problem, this patch adds a new type struct
5743 vectorlike_header that documents the constraints on layout of vectors
5744 and pseudovectors, and helps optimizing compilers not get fooled
5745 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5746 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5747 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5749 (XSETPVECTYPE): Rewrite in terms of new macro.
5750 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5751 This is a bit clearer, and further avoids the possibility of
5752 undesirable aliasing.
5753 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5754 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5755 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5756 since Lisp_Subr is a special case (no "next" field).
5757 (ASIZE): Now uses header.size rather than size.
5758 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5759 to avoid the hassle of writing XVECTOR (foo)->header.size.
5760 (struct vectorlike_header): New type.
5761 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5762 object, to help avoid aliasing.
5763 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5764 (SUBRP): Likewise, since Lisp_Subr is a special case.
5765 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5766 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5767 (struct Lisp_Hash_Table): Combine first two members into a single
5768 struct vectorlike_header member. All uses of "size" and "next" members
5769 changed to be "header.size" and "header.next".
5770 * buffer.h (struct buffer): Likewise.
5771 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5772 * frame.h (struct frame): Likewise.
5773 * process.h (struct Lisp_Process): Likewise.
5774 * termhooks.h (struct terminal): Likewise.
5775 * window.c (struct save_window_data, struct saved_window): Likewise.
5776 * window.h (struct window): Likewise.
5777 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5778 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5779 * buffer.c (init_buffer_once): Likewise.
5780 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5782 * process.c (Fformat_network_address): Use local var for size,
5785 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5787 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5788 * data.c (atof): Remove decl; no longer used or needed.
5789 (digit_to_number): Move to lread.c.
5790 (Fstring_to_number): Use new string_to_number function, to be
5791 consistent with how the Lisp reader treats infinities and NaNs.
5792 Do not assume that floating-point numbers represent EMACS_INT
5793 without losing information; this is not true on most 64-bit hosts.
5794 Avoid double-rounding errors, by insisting on integers when
5795 parsing non-base-10 numbers, as the documentation specifies.
5796 * lisp.h (string_to_number): New decl, replacing ...
5797 (isfloat_string): Remove.
5798 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5799 (read1): Do not accept +. and -. as integers; this
5800 appears to have been a coding error. Similarly, do not accept
5801 strings like +-1e0 as floating point numbers. Do not report
5802 overflow for integer overflows unless the base is not 10 which
5803 means we have no simple and reliable way to continue.
5804 Break out the floating-point parsing into a new
5805 function string_to_number, so that Fstring_to_number parses
5806 floating point numbers consistently with the Lisp reader.
5807 (digit_to_number): Move here from data.c. Make it static inline.
5808 (E_CHAR, EXP_INT): Remove, replacing with ...
5809 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5810 (string_to_number): New function, replacing isfloat_string.
5811 This function checks for valid syntax and produces the resulting
5812 Lisp float number too. Rework it so that string-to-number
5813 no longer mishandles examples like "1.0e+". Use strtoumax,
5814 so that overflow for non-base-10 numbers is reported only when
5815 there's no portable and simple way to convert to floating point.
5817 * textprop.c (set_text_properties_1): Rewrite for clarity,
5818 and to avoid GCC warning about integer overflow.
5820 * intervals.h (struct interval): Use EMACS_INT for members
5821 where EMACS_UINT might cause problems. See
5822 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5823 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5824 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5826 (offset_intervals): Tell GCC not to worry about length overflow
5827 when negating a negative length.
5829 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5830 (overrun_check_free): Likewise.
5832 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5833 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5836 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5837 (gnutls_make_error): Rename local to avoid shadowing.
5838 (gnutls_emacs_global_deinit): ifdef out; not used.
5839 (Fgnutls_boot): Use const for pointer to readonly storage.
5840 Comment out unused local. Fix pointer signedness problems.
5842 * lread.c (openp): Don't stuff size_t into an 'int'.
5843 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5844 about possible signed overflow.
5846 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5847 (GDK_KEY_g): Don't define if already defined.
5848 (xg_prepare_tooltip): Avoid pointer signedness problem.
5849 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5851 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5852 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5854 * xfns.c (Fx_window_property): Simplify a bit,
5855 to make a bit faster and to avoid GCC 4.6.0 warning.
5856 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5858 * fns.c (internal_equal): Don't assume size_t fits in int.
5860 * alloc.c (compact_small_strings): Tighten assertion a little.
5862 Replace pEd with more-general pI, and fix some printf arg casts.
5863 * lisp.h (pI): New macro, generalizing old pEd macro to other
5864 conversion specifiers. For example, use "...%"pI"d..." rather
5865 than "...%"pEd"...".
5866 (pEd): Remove. All uses replaced with similar uses of pI.
5867 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5868 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5869 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5870 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5871 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5872 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5873 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5875 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5876 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5877 * print.c (safe_debug_print, print_object): Likewise.
5878 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5880 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5881 avoiding the 0 flag, which is not portable.
5882 * process.c (Fmake_network_process): Use pI to avoid cast.
5883 * region-cache.c (pp_cache): Likewise.
5884 * xdisp.c (decode_mode_spec): Likewise.
5885 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5886 behavior on 64-bit hosts with printf arg.
5887 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5888 (x_stop_queuing_selection_requests): Likewise.
5889 (x_get_window_property): Don't truncate byte count to an 'int'
5892 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5893 here, since it parses constructs like leading '-' and spaces,
5894 which are not wanted; and it overflows with large numbers.
5895 Instead, simply match F[0-9]+, which is what is wanted anyway.
5897 * alloc.c: Remove unportable assumptions about struct layout.
5898 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5899 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5900 (allocate_vectorlike, make_pure_vector): Use the new macros,
5901 plus offsetof, to remove unportable assumptions about struct layout.
5902 These assumptions hold on all porting targets that I know of, but
5903 they are not guaranteed, they're easy to remove, and removing them
5904 makes further changes easier.
5906 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5907 This doesn't fix a bug but makes the code clearer.
5908 (string_overrun_cookie): Now const. Use initializers that
5909 don't formally overflow signed char, to avoid warnings.
5910 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5911 can cause Emacs to crash when string overrun checking is enabled.
5912 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5913 multiple of sizeof (EMACS_INT); it need not be, if
5914 alignof(EMACS_INT) < sizeof (EMACS_INT).
5915 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5917 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5919 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5921 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5923 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5924 supposed to be handshaking. (Bug#8556)
5925 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5927 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5929 * lisp.h (Qdebug): List symbol.
5930 * eval.c (Qdebug): Restore global linkage.
5931 * keyboard.c (debug-on-event): New variable.
5932 (handle_user_signal): Break into debugger when debug-on-event
5933 matches the current signal symbol.
5935 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5937 * alloc.c (check_sblock, check_string_bytes)
5938 (check_string_free_list): Convert to standard C.
5940 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5942 * w32.c (emacs_gnutls_push): Fix typo.
5944 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5946 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5947 "cast to pointer from integer of different size".
5949 Improve doprnt and its use in verror. (Bug#8545)
5950 * doprnt.c (doprnt): Document the set of format control sequences
5951 supported by the function. Use SAFE_ALLOCA instead of always
5954 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5955 is one byte too soon. Don't use xrealloc; instead xfree and
5958 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5960 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5963 * gnutls.c: Renamed global_initialized to
5964 gnutls_global_initialized. Added internals for the
5965 :verify-hostname-error, :verify-error, and :verify-flags
5966 parameters of `gnutls-boot' and documented those parameters in the
5967 docstring. Start callback support.
5968 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5969 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5970 on error. Return error code.
5971 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5972 (emacs_gnutls_read): Likewise.
5973 (Fgnutls_boot): Return handshake error code.
5974 (emacs_gnutls_handle_error): New function.
5975 (wsaerror_to_errno): Likewise.
5977 * w32.h (emacs_gnutls_pull): Add prototype.
5978 (emacs_gnutls_push): Likewise.
5980 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5981 (emacs_gnutls_push): Likewise.
5983 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5985 * process.c (wait_reading_process_output): Check if GnuTLS
5986 buffered some data internally if no FDs are set for TLS
5989 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5990 (LIBS): Link to USER_LIBS.
5991 ($(BLD)/gnutls.$(0)): New target.
5993 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5995 * xdisp.c (handle_single_display_spec): Rename the
5996 display_replaced_before_p argument into display_replaced_p, to
5997 make it consistent with the commentary. Fix typos in the
6000 * textprop.c (syms_of_textprop): Remove dead code.
6001 (copy_text_properties): Delete obsolete commentary about an
6002 interface that was deleted long ago. Fix typos in the description
6005 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6006 to changes in oldXMenu/XMenu.h from 2011-04-16.
6007 <menu_help_message, prev_menu_help_message>: Constify.
6008 (IT_menu_make_room): menu->help_text is now `const char **';
6011 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6012 to changes in oldXMenu/XMenu.h from 2011-04-16.
6013 (struct XMenu): Declare `help_text' `const char **'.
6015 * xfaces.c <Qunspecified>: Make extern again.
6017 * syntax.c: Include sys/types.h before including regex.h, as
6020 * doc.c (get_doc_string): Improve the format passed to `error'.
6022 * doprnt.c (doprnt): Improve commentary.
6024 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6026 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6029 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6030 changes in globals.h immediately force recompilation.
6031 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6032 $(CURDIR)/s/ms-w32.h.
6033 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6035 * character.c (Fchar_direction): Function deleted.
6036 (syms_of_character): Don't defsubr it.
6037 <char-direction-table>: Deleted.
6039 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6041 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6042 * doprnt.c: Include limits.h.
6043 (SIZE_MAX): New macro.
6044 (doprnt): Return a size_t value. 2nd arg is now size_t.
6045 Many local variables are now size_t instead of int or unsigned.
6046 Improve overflow protection. Support `l' modifier for integer
6047 conversions. Support %l conversion. Don't assume an EMACS_INT
6048 argument for integer conversions and for %c.
6050 * lisp.h (doprnt): Restore prototype.
6052 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6055 * Makefile.in (base_obj): Add back doprnt.o.
6057 * deps.mk (doprnt.o): Add back prerequisites.
6058 (callint.o): Depend on character.h.
6060 * eval.c (internal_lisp_condition_case): Include the handler
6061 representation in the error message.
6062 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6063 when breaking from the loop.
6065 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6067 * callint.c (Fcall_interactively): When displaying error message
6068 about invalid control letter, pass the character's codepoint, not
6069 a pointer to its multibyte form. Improve display of the character
6070 in octal and display also its hex code.
6072 * character.c (char_string): Use %x to display the (unsigned)
6073 codepoint of an invalid character, to avoid displaying a bogus
6076 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6077 `error', not SYMBOL_NAME itself.
6079 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6080 character arguments to `error'.
6082 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6083 to `error' in error message about FINAL_CHAR argument. Make sure
6084 FINAL_CHAR is a character, and use %c when it is passed as
6085 argument to `error'.
6087 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6089 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6091 * w32.c: Include <time.h>.
6092 (sys_localtime): New function.
6094 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6096 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6098 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6100 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6102 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6105 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6107 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6108 gl_state.e_property when gl_state.object is Qt.
6110 * insdel.c (make_gap_larger): Remove limitation of buffer size
6113 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6115 * xdisp.c (lookup_glyphless_char_display)
6116 (produce_glyphless_glyph): Handle cons cell entry in
6117 glyphless-char-display.
6118 (Vglyphless_char_display): Document it.
6120 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6121 glyphless-char-display.
6123 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6125 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6127 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6129 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6130 definition for no-X builds.
6132 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6134 Static checks with GCC 4.6.0 and non-default toolkits.
6136 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6138 * process.c (keyboard_bit_set): Define only if SIGIO.
6139 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6140 (send_process): Repair possible setjmp clobbering.
6142 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6144 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6146 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6148 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6149 Define only if needed.
6151 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6152 by pacifying GCC about it. Maybe it's time to retire it?
6153 * xfaces.c (USG, __TIMEVAL__): Likewise.
6155 * dispextern.h (struct redisplay_interface): Rename param
6157 * termhooks.h (struct terminal): Likewise.
6158 * xterm.c (xembed_send_message): Likewise.
6160 * insdel.c (make_gap_smaller): Define only if
6161 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6163 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6166 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6167 so that we aren't warned about unused symbols.
6169 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6171 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6173 * xfns.c (x_real_positions): Mark locals as initialized.
6175 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6177 * xterm.c: Fix problems found by static analysis with other toolkits.
6178 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6179 (x_dispatch_event): Declare static if USE_GTK, and
6180 define if USE_GTK || USE_X_TOOLKIT.
6181 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6182 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6183 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6184 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6186 * xmenu.c (menu_help_callback): Pointer type fixes.
6187 Use const pointers when pointing at readonly data. Avoid pointer
6189 (FALSE): Remove unused macro.
6190 (update_frame_menubar): Remove unused decl.
6192 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6194 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6195 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6196 (single_menu_item): Rename local to avoid shadowing.
6198 * keyboard.c (make_lispy_event): Remove unused local var.
6200 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6201 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6203 * bitmaps: Change bitmaps from unsigned char back to the X11
6204 compatible char. Avoid the old compiler warnings about
6205 out-of-range initializers by using, for example, '\xab' rather
6208 * xgselect.c (xgselect_initialize): Check vs interface
6209 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6211 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6213 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6214 to read-only memory.
6216 * fns.c (vector): Remove; this old hack is no longer needed.
6218 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6220 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6222 * xrdb.c (x_load_resources): Omit unused local.
6224 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6225 (x_window): Rename locals to avoid shadowing.
6226 (USG): Use the kludged USG macro, to pacify gcc.
6228 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6229 (x_term_init): Remove local to avoid shadowing.
6231 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6233 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6234 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6236 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6238 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6240 Fix regex.c, syntax.c and friends for buffers > 2GB.
6241 * syntax.h (struct gl_state_s): Declare character position members
6244 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6246 * textprop.c (verify_interval_modification, interval_of):
6247 Declare arguments EMACS_INT.
6249 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6252 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6254 * indent.c (Fvertical_motion): Local variable it_start is now
6257 * regex.c (re_match, re_match_2, re_match_2_internal)
6258 (bcmp_translate, regcomp, regexec, print_double_string)
6259 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6260 (re_compile_pattern, re_exec): Declare arguments and local
6261 variables `size_t' and `ssize_t' and return values `regoff_t', as
6263 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6264 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6265 <compile_stack_type>: `size' and `avail' are now `size_t'.
6267 * regex.h <regoff_t>: Use ssize_t, not int.
6268 (re_search, re_search_2, re_match, re_match_2): Arguments that
6269 specify buffer/string position and length are now ssize_t and
6270 size_t. Return type is regoff_t.
6272 2011-04-16 Ben Key <bkey76@gmail.com>
6274 * nsfont.m: Fixed bugs in ns_get_family and
6275 ns_descriptor_to_entity that were caused by using free to
6276 deallocate memory blocks that were allocated by xmalloc (via
6277 xstrdup). This caused Emacs to crash when compiled with
6278 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6279 --enable-checking=xmallocoverrun). xfree is now used to
6280 deallocate these memory blocks.
6282 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6284 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6286 emacs_write: Accept and return EMACS_INT for sizes.
6287 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6289 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6290 Accept and return EMACS_INT.
6291 (emacs_gnutls_write): Return the number of bytes written on
6293 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6294 (emacs_read, emacs_write): Remove check for negative size, as the
6295 Emacs source code has been audited now.
6296 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6297 (emacs_read, emacs_write): Use it.
6298 * process.c (send_process): Adjust to the new signatures of
6299 emacs_write and emacs_gnutls_write. Do not attempt to store
6300 a byte offset into an 'int'; it might overflow.
6301 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6303 * sound.c: Don't assume sizes fit in 'int'.
6304 (struct sound_device.period_size, alsa_period_size):
6305 Return EMACS_INT, not int.
6306 (struct sound_device.write, vox_write, alsa_write):
6307 Accept EMACS_INT, not int.
6308 (wav_play, au_play): Use EMACS_INT to store sizes and to
6309 record read return values.
6311 2011-04-15 Ben Key <bkey76@gmail.com>
6313 * keyboard.c (Qundefined): Don't declare static since it is used
6315 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6316 static since they are used in nsfont.m.
6318 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6320 * process.c (Qprocessp): Don't declare static.
6321 * lisp.h (Qprocessp): Declare again.
6323 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6325 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6327 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6329 Improve C-level modularity by making more things 'static'.
6331 Don't publish debugger-only interfaces to other modules.
6332 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6333 (verify_bytepos, count_markers): Move decls to the only modules
6335 * region-cache.h (pp_cache): Likewise.
6336 * window.h (check_all_windows): Likewise.
6337 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6339 * sysdep.c (croak): Now static, if
6340 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6341 * syssignal.h (croak): Declare only if not static.
6343 * alloc.c (refill_memory_reserve): Now static if
6344 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6345 * lisp.h (refill_memory_reserve): Declare only if not static.
6347 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6348 Define only if USE_LUCID.
6350 * xrdb.c (x_customization_string, x_rm_string): Now static.
6352 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6353 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6355 * xdisp.c (draw_row_with_mouse_face): Now static.
6356 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6358 * window.h (check_all_windows): Mark externally visible.
6360 * window.c (window_deletion_count): Now static.
6362 * undo.c: Make symbols static if they're not exported.
6363 (last_undo_buffer, last_boundary_position, pending_boundary):
6366 * textprop.c (interval_insert_behind_hooks): Now static.
6367 (interval_insert_in_front_hooks): Likewise.
6369 * term.c: Make symbols static if they're not exported.
6370 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6371 (max_frame_lines, tty_set_terminal_modes):
6372 (tty_reset_terminal_modes, tty_turn_off_highlight):
6373 (get_tty_terminal): Now static.
6374 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6375 * termhooks.h (term_mouse_moveto): Do not declare if
6377 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6378 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6380 * sysdep.c: Make symbols static if they're not exported.
6381 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6383 (sigprocmask_set, full_mask): Remove; unused.
6384 (wait_debugging): Mark as visible.
6385 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6386 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6388 * syntax.c (syntax_temp): Define only if !__GNUC__.
6390 * sound.c (current_sound_device, current_sound): Now static.
6392 * search.c (searchbufs, searchbuf_head): Now static.
6394 * scroll.c (scroll_cost): Remove; unused.
6395 * dispextern.h (scroll_cost): Remove decl.
6397 * region-cache.h (pp_cache): Mark as externally visible.
6399 * process.c: Make symbols static if they're not exported.
6400 (process_tick, update_tick, create_process, chan_process):
6401 (Vprocess_alist, proc_buffered_char, datagram_access):
6402 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6403 (deactivate_process): Mark defn as static, as well as decl.
6404 * lisp.h (create_process): Remove decl.
6405 * process.h (chan_process, Vprocess_alist): Remove decls.
6407 * print.c: Make symbols static if they're not exported.
6408 (print_depth, new_backquote_output, being_printed, print_buffer):
6409 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6410 (print_interval, print_number_index, initial_stderr_stream):
6412 * lisp.h (Fprinc): Remove decl.
6413 (debug_output_compilation_hack): Mark as externally visible.
6415 * sysdep.c (croak): Move decl from here to syssignal.h.
6416 * syssignal.h (croak): Put it here, so the API can be checked when
6417 'croak' is called from dissociate_if_controlling_tty.
6419 * minibuf.c: Make symbols static if they're not exported.
6420 (minibuf_save_list, choose_minibuf_frame): Now static.
6421 * lisp.h (choose_minibuf_frame): Remove decl.
6423 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6425 * lread.c: Make symbols static if they're not exported.
6426 (read_objects, initial_obarray, oblookup_last_bucket_number):
6428 (make_symbol): Remove; unused.
6429 * lisp.h (initial_obarray, make_symbol): Remove decls.
6431 * keyboard.c: Make symbols static if they're not exported.
6432 (single_kboard, recent_keys_index, total_keys, recent_keys):
6433 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6434 (this_single_command_key_start, echoing, last_auto_save):
6435 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6436 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6437 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6438 (Vlispy_mouse_stem, double_click_count):
6440 (force_auto_save_soon): Define only if SIGDANGER.
6441 (ignore_mouse_drag_p): Now static if
6442 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6443 (print_help): Remove; unused.
6444 (stop_character, last_timer_event): Mark as externally visible.
6445 * keyboard.h (ignore_mouse_drag_p): Declare only if
6446 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6447 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6448 * lisp.h (echoing): Remove decl.
6449 (force_auto_save_soon): Declare only if SIGDANGER.
6450 * xdisp.c (redisplay_window): Simplify code, to make it more
6451 obvious that ignore_mouse_drag_p is not accessed if !defined
6452 USE_GTK && !defined HAVE_NS.
6454 * intervals.c: Make symbols static if they're not exported.
6455 (merge_properties_sticky, merge_interval_right, delete_interval):
6457 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6459 * insdel.c: Make symbols static if they're not exported.
6460 However, leave prepare_to_modify_buffer alone. It's never
6461 called from outside this function, but that appears to be a bug.
6462 (combine_after_change_list, combine_after_change_buffer):
6463 (adjust_after_replace, signal_before_change): Now static.
6464 (adjust_after_replace_noundo): Remove; unused.
6465 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6466 (signal_before_change): Remove decls.
6468 * indent.c (val_compute_motion, val_vmotion): Now static.
6470 * image.c: Make symbols static if they're not exported.
6471 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6473 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6474 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6476 * fringe.c (standard_bitmaps): Now static.
6477 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6479 * frame.c: Make symbols static if they're not exported.
6480 (x_report_frame_params, make_terminal_frame): Now static.
6481 (get_frame_param): Now static, unless HAVE_NS.
6482 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6483 (x_get_resource_string): Remove; not used.
6484 * frame.h (make_terminal_frame, x_report_frame_params):
6485 (x_get_resource_string); Remove decls.
6486 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6487 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6489 * font.c, fontset.c: Make symbols static if they're not exported.
6490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6491 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6492 * font.c (font_close_object): Now static.
6493 * font.h (font_close_object): Remove.
6494 * fontset.c (FONTSET_OBJLIST): Remove.
6495 (free_realized_fontset) #if-0 the body, which does nothing.
6496 (face_suitable_for_char_p): #if-0, as it's never called.
6497 * fontset.h (face_suitable_for_char_p): Remove decl.
6498 * xfaces.c (face_at_string_position):
6499 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6500 since 0 is always ASCII.
6502 * fns.c (weak_hash_tables): Now static.
6504 * fileio.c: Make symbols static if they're not exported.
6505 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6506 (Vwrite_region_annotation_buffers): Now static.
6508 * eval.c: Make symbols static if they're not exported.
6509 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6510 * lisp.h (backtrace_list): Remove decl.
6512 * emacs.c: Make symbols static if they're not exported.
6513 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6514 (fatal_error_code, fatal_error_signal_hook, standard_args):
6516 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6517 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6518 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6519 * lisp.h (fatal_error_signal_hook): Remove decl.
6520 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6522 * editfns.c: Move a (normally-unused) function to its only use.
6523 * editfns.c, lisp.h (get_operating_system_release): Remove.
6524 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6525 worth the hassle of breaking this out.
6527 * xterm.c: Make symbols static if they're not exported.
6528 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6529 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6530 (x_destroy_window, x_delete_display):
6532 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6533 (x_mouse_leave): Remove; unused.
6534 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6535 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6536 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6538 (x_mouse_leave): Declare only if WINDOWSNT.
6539 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6540 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6543 * ftxfont.c: Make symbols static if they're not exported.
6544 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6546 * font.h (ftxfont_driver): Likewise.
6548 * xfns.c: Make symbols static if they're not exported.
6549 (x_last_font_name, x_display_info_for_name):
6550 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6551 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6552 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6553 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6554 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6555 (last_show_tip_args): Now static.
6556 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6557 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6558 (x_screen_planes): Remove; unused.
6559 * dispextern.h (x_screen_planes): Remove decl.
6561 * dispnew.c: Make symbols static if they're not exported.
6562 * dispextern.h (redraw_garbaged_frames, scrolling):
6563 (increment_row_positions): Remove.
6564 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6565 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6567 (redraw_garbaged_frames): Remove; unused.
6569 * xfaces.c: Make symbols static if they're not exported.
6570 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6572 * xterm.h (defined_color): Remove decls.
6573 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6574 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6575 (menu_face_changed_default, defined_color, free_realized_face):
6576 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6577 (ascii_face_of_lisp_face): Remove; unused.
6579 * xdisp.c: Make symbols static if they're not exported.
6580 * dispextern.h (scratch_glyph_row, window_box_edges):
6581 (glyph_to_pixel_coords, set_cursor_from_row):
6582 (get_next_display_element, set_iterator_to_next):
6583 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6584 (show_mouse_face): Remove decls
6585 * frame.h (message_buf_print): Likewise.
6586 * lisp.h (pop_message, set_message, check_point_in_composition):
6588 * xterm.h (set_vertical_scroll_bar): Likewise.
6589 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6590 (message_buf_print, scratch_glyph_row, displayed_buffer):
6591 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6592 (get_next_display_element, show_mouse_face, window_box_edges):
6593 (frame_to_window_pixel_xy, check_point_in_composition):
6594 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6595 (glyph_to_pixel_coords): Remove; unused.
6597 * dired.c (file_name_completion): Now static.
6599 * dbusbind.c (xd_in_read_queued_messages): Now static.
6601 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6602 * data.c (circular_list_error): Remove.
6604 * commands.h (last_point_position, last_point_position_buffer):
6605 (last_point_position_window): Remove decls.
6606 * keyboard.c: Make these variables static.
6608 * coding.h (coding, code_convert_region, encode_coding_gap):
6610 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6611 (iso_code_class, detect_coding, code_convert_region): Now static.
6612 (encode_coding_gap): Remove; unused.
6614 * chartab.c (chartab_chars, chartab_bits): Now static.
6616 * charset.h (charset_iso_8859_1): Remove decl.
6617 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6620 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6621 * ccl.c (Vccl_program_table): Now static.
6622 (check_ccl_update): Remove; unused.
6624 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6625 * category.h: ... from here.
6626 * category.c (check_category_table, set_category_set): Now static.
6628 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6629 * lisp.h: Remove these decls.
6631 * buffer.c (buffer_count): Remove unused var.
6633 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6634 so that it's not optimized away.
6635 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6636 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6637 exported only to the debugger.
6639 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6640 * atimer.h (run_all_atimers): Remove; not exported.
6642 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6643 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6644 was inaccessible from Lisp.
6645 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6646 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6648 alloc.c: Import and export fewer symbols, and remove unused items.
6649 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6651 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6652 it's not optimized away by whole-program optimization.
6653 (message_enable_multibyte, free_misc): Remove.
6654 (catchlist, handlerlist, mark_backtrace):
6655 Declare only if BYTE_MARK_STACK.
6656 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6657 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6658 (message_enable_multibyte): Remove decl.
6659 (free_misc, interval_free_list, float_block, float_block_index):
6660 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6661 (cons_free_list, last_marked_index):
6663 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6664 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6665 (mark_backtrace): Define only if BYTE_MARK_STACK.
6666 * xdisp.c (message_enable_multibyte): Now static.
6668 Declare Lisp_Object Q* variables to be 'static' if not exported.
6669 This makes it easier for human readers (and static analyzers)
6670 to see whether these variables are used from other modules.
6671 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6672 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6673 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6674 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6675 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6676 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6677 * xmenu.c, xselect.c:
6678 Declare Q* vars static if they are not used in other modules.
6679 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6680 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6681 Remove decls of unexported vars.
6682 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6684 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6686 Make Emacs functions such as Fatom 'static' by default.
6687 This makes it easier for human readers (and static analyzers)
6688 to see whether these functions can be called from other modules.
6689 DEFUN now defines a static function. To make the function external
6690 so that it can be used in other C modules, use the new macro DEFUE.
6691 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6692 (Finit_image_library):
6693 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6694 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6695 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6696 Remove decls, since these functions are now static.
6697 (Funintern, Fget_internal_run_time): New decls, since these functions
6698 were already external.
6700 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6701 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6702 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6703 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6704 * keyboard.c, keymap.c, lread.c:
6705 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6706 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6707 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6708 Mark functions with DEFUE instead of DEFUN,
6709 if they are used in other modules.
6710 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6711 decls for now-static functions.
6712 * buffer.h (Fdelete_overlay): Remove decl.
6713 * callproc.c (Fgetenv_internal): Mark as internal.
6714 * composite.c (Fremove_list_of_text_properties): Remove decl.
6715 (Fcomposition_get_gstring): New forward static decl.
6716 * composite.h (Fcomposite_get_gstring): Remove decl.
6717 * dired.c (Ffile_attributes): New forward static decl.
6718 * doc.c (Fdocumntation_property): New forward static decl.
6719 * eval.c (Ffetch_bytecode): New forward static decl.
6720 (Funintern): Remove extern decl; now in .h file where it belongs.
6721 * fileio.c (Fmake_symbolic_link): New forward static decl.
6722 * image.c (Finit_image_library): New forward static decl.
6723 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6724 * intervals.h (Fprevious_property_change):
6725 (Fremove_list_of_text_properties): Remove decls.
6726 * keyboard.c (Fthis_command_keys): Remove decl.
6727 (Fcommand_execute): New forward static decl.
6728 * keymap.c (Flookup_key): New forward static decl.
6729 (Fcopy_keymap): Now static.
6730 * keymap.h (Flookup_key): Remove decl.
6731 * process.c (Fget_process): New forward static decl.
6732 (Fprocess_datagram_address): Mark as internal.
6733 * syntax.c (Fsyntax_table_p): New forward static decl.
6734 (skip_chars): Remove duplicate decl.
6735 * textprop.c (Fprevious_property_change): New forward static decl.
6736 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6738 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6739 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6741 * editfns.c (Fformat): Remove unreachable code.
6743 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6745 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6748 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6750 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6751 when at ZV. (Bug#8487)
6753 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6755 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6757 * keyboard.c (parse_tool_bar_item): Likewise.
6758 * sound.c (sound_cleanup, alsa_close): Likewise.
6759 * termcap.c (tgetent): Likewise.
6760 * xfns.c (x_default_font_parameter): Likewise.
6761 * xsettings.c (read_and_apply_settings): Likewise.
6763 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6764 (overrun_check_free): Protoize.
6766 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6768 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6769 since callers should never pass a negative size.
6770 Change the signature to match that of plain 'read' and 'write'; see
6771 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6772 * lisp.h: Update prototypes of emacs_write and emacs_read.
6774 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6776 * xdisp.c (redisplay_window): Don't try to determine the character
6777 position of the scroll margin if the window start point w->startp
6778 is outside the buffer's accessible region. (Bug#8468)
6780 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6782 Fix write-region and its subroutines for buffers > 2GB.
6783 * fileio.c (a_write, e_write): Modify declaration of arguments and
6784 local variables to support buffers larger than 2GB.
6785 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6787 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6788 argument, local variables, and return value.
6790 * lisp.h: Update prototypes of emacs_write and emacs_read.
6792 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6794 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6796 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6798 Fix more problems found by GCC 4.6.0's static checks.
6800 * xdisp.c (vmessage): Use a better test for character truncation.
6802 * charset.c (load_charset_map): <, not <=, for optimization,
6803 and to avoid potential problems with integer overflow.
6804 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6805 * casetab.c (set_identity, shuffle): Likewise.
6806 * editfns.c (Fformat): Likewise.
6807 * syntax.c (skip_chars): Likewise.
6809 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6810 This also lets GCC 4.6.0 generate slightly better loop code.
6812 * callint.c (Fcall_interactively): <, not <=, for optimization.
6813 (Fcall_interactively): Count the number of arguments produced,
6814 not the number of arguments given. This is simpler and lets GCC
6815 4.6.0 generate slightly better code.
6817 * ftfont.c: Distingish more carefully between FcChar8 and char.
6818 The previous code passed unsigned char * to a functions like
6819 strlen and xstrcasecmp that expect char *, which does not
6820 conform to the C standard.
6821 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6822 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6823 char * when the C standard requires it.
6825 * keyboard.c (read_char): Remove unused var.
6827 * eval.c: Port to Windows vsnprintf (Bug#8435).
6829 (SIZE_MAX): Define if the headers do not.
6830 (verror): Do not give up if vsnprintf returns a negative count.
6831 Instead, grow the buffer. This ports to Windows vsnprintf, which
6832 does not conform to C99. Problem reported by Eli Zaretskii.
6833 Also, simplify the allocation scheme, by avoiding the need for
6834 calling realloc, and removing the ALLOCATED variable.
6836 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6838 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6839 But keep the doprint source code for now, as we might revamp it
6840 and use it again (Bug#8435).
6841 * lisp.h (doprnt): Remove.
6842 * Makefile.in (base_obj): Remove doprnt.o.
6843 * deps.mk (doprnt.o): Remove.
6845 error: Print 32- and 64-bit integers portably (Bug#8435).
6846 Without this change, on typical 64-bit hosts error ("...%d...", N)
6847 was used to print both 32- and 64-bit integers N, which relied on
6849 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6851 * lisp.h (error, verror): Mark as printf-like functions.
6852 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6853 Report overflow in size calculations when allocating printf buffer.
6854 Do not truncate output string at its first null byte.
6855 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6856 Truncate the output at a character boundary, since vsnprintf does not
6858 * charset.c (check_iso_charset_parameter): Convert internal
6859 character to string before calling 'error', since %c now has the
6861 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6862 overflow when computing char to be passed to 'error'. Do not
6863 pass Lisp_Object to 'error'; pass the integer instead.
6864 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6865 formatted with plain %d.
6867 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6869 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6871 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6873 * xterm.c (x_catch_errors): Remove duplicate declaration.
6875 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6877 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6879 2011-04-10 Jim Meyering <meyering@redhat.com>
6881 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6882 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6883 return ssize_t not "int", and use size_t as the buffer length.
6884 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6885 * gnutls.h: Update declarations.
6886 * process.c (read_process_output): Use ssize_t, to match.
6887 (send_process): Likewise.
6889 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6891 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6893 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6895 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6896 Use unsigned char, to match FcChar8 type definition.
6898 * xterm.c (handle_one_xevent):
6899 * xmenu.c (create_and_show_popup_menu):
6900 * xselect.c (x_decline_selection_request)
6901 (x_reply_selection_request): Avoid type-punned deref of X events.
6903 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6905 Fix some uses of `int' instead of EMACS_INT.
6906 * search.c (string_match_1, fast_string_match)
6907 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6908 (scan_buffer, find_next_newline_no_quit)
6909 (find_before_next_newline, search_command, Freplace_match)
6910 (Fmatch_data): Make some `int' variables be EMACS_INT.
6912 * xdisp.c (display_count_lines): 3rd argument and return value now
6913 EMACS_INT. All callers changed.
6914 (pint2hrstr): Last argument is now EMACS_INT.
6916 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6917 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6918 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6919 (decode_coding_utf_16, decode_coding_emacs_mule)
6920 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6921 (decode_coding_ccl, decode_coding_charset)
6922 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6923 (decode_coding_iso_2022, decode_coding_emacs_mule)
6924 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6925 <char_offset, last_offset>: Declare EMACS_INT.
6926 (encode_coding_utf_8, encode_coding_utf_16)
6927 (encode_coding_emacs_mule, encode_invocation_designation)
6928 (encode_designation_at_bol, encode_coding_iso_2022)
6929 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6930 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6932 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6933 (encode_invocation_designation): Last argument P_NCHARS is now
6935 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6936 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6938 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6941 * ccl.c (Fccl_execute_on_string): Declare some variables
6944 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6946 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6948 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6950 * process.c (Fformat_network_address): Doc fix.
6952 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6954 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6956 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6958 * keyboard.c (read_char): Call Lisp function help-form-show,
6959 instead of using internal_with_output_to_temp_buffer.
6960 (Qhelp_form_show): New var.
6961 (syms_of_keyboard): Use DEFSYM macro.
6963 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6965 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6967 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6969 * process.c (Flist_processes): Remove to Lisp.
6970 (list_processes_1): Delete.
6972 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6974 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6976 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6978 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6980 Fix more problems found by GCC 4.6.0's static checks.
6982 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6984 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6986 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6988 * xdisp.c (vmessage): Mark as a printf-like function.
6990 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6992 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6994 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6995 printf-like functions.
6996 (tiff_load): Add casts to remove these marks before passing them
6997 to system-supplied API.
6999 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7001 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7002 This avoids several warnings with gcc -Wstrict-overflow.
7003 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7004 directly, rather than having caller test rule sign. This avoids
7005 some unnecessary tests.
7006 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7007 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7008 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7010 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7011 (xfont_open): Avoid unnecessary tests.
7013 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7015 * composite.h, composite.c (composition_gstring_put_cache):
7016 Use EMACS_INT, not int, for length.
7018 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7019 breaking out part of COMPOSITION_DECODE_RULE.
7020 (COMPOSITION_DECODE_RULE): Use it.
7021 * composite.c (get_composition_id): Remove unused local vars,
7022 by using the new macro.
7024 * textprop.c (set_text_properties_1): Change while to do-while,
7025 since the condition is always true at first.
7027 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7028 (interval_deletion_adjustment): Return unsigned value.
7031 * process.c (list_processes_1, create_pty, read_process_output):
7032 (exec_sentinel): Remove vars that were set but not used.
7033 (create_pty): Remove unnecessary "volatile"s.
7034 (Fnetwork_interface_info): Avoid possibility of int overflow.
7035 (read_process_output): Do adaptive read buffering even if carryover.
7036 (read_process_output): Simplify nbytes computation if buffered.
7038 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7040 * syntax.c (scan_words): Remove var that was set but not used.
7041 (update_syntax_table): Use unsigned instead of int.
7043 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7044 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7045 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7047 * print.c (print_error_message): Avoid int overflow.
7049 * font.c (font_list_entities): Redo for clarity,
7050 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7052 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7053 (font_score): Avoid potential overflow in diff calculation.
7055 * fns.c (substring_both): Remove var that is set but not used.
7056 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7058 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7060 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7061 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7062 can always succeed if overflow has undefined behavior.
7064 * search.c (boyer_moore, wordify): Remove vars set but not used.
7065 (wordify): Omit three unnecessary tests.
7067 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7068 All callers changed. This avoids the need for an unused var.
7070 * casefiddle.c (casify_region): Remove var that is set but not used.
7072 * dired.c (file_name_completion): Remove var that is set but not used.
7074 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7076 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7077 (Finsert_file_contents): Remove unnecessary code checking fd.
7079 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7080 Check for integer overflow on size calculations.
7082 * buffer.c (Fprevious_overlay_change): Remove var that is set
7085 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7086 Remove vars that are set but not used.
7087 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7088 (timer_check_2): Mark vars as initialized.
7090 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7092 * image.c (lookup_image): Remove var that is set but not used.
7093 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7095 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7096 that are set but not used.
7098 * xfns.c (make_invisible_cursor): Don't return garbage
7099 if XCreateBitmapFromData fails (Bug#8410).
7101 * xselect.c (x_get_local_selection, x_handle_property_notify):
7102 Remove vars that are set but not used.
7104 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7105 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7107 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7108 Remove var that is set but not used.
7109 (scroll_bar_windows_size): Now size_t, not int.
7110 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7113 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7114 (map_tty_color) [!defined MSDOS]: Likewise.
7116 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7118 * coding.c: Remove vars that are set but not used.
7119 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7120 All callers changed.
7121 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7122 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7123 (decode_coding_charset): Remove vars that are set but not used.
7125 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7126 that is set but not used.
7128 * print.c (print_object): Remove var that is set but not used.
7130 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7131 The gnulib version avoids calling malloc in the usual case,
7132 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7133 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7134 * filelock.c (current_lock_owner): Likewise.
7135 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7136 * sysdep.c: Include allocator.h, careadlinkat.h.
7137 (emacs_no_realloc_allocator): New static constant.
7138 (emacs_readlink): New function.
7139 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7140 ../lib/careadlinkat.h.
7142 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7144 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7145 first non-nil return value).
7147 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7149 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7150 if not defined (Bug#8403).
7152 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7154 * xdisp.c (display_count_lines): Remove parameter `start',
7155 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7156 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7157 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7158 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7159 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7160 and thereabouts. All callers changed.
7161 (get_per_char_metric): Remove parameter `f', unused since
7162 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7164 2011-04-02 Jim Meyering <meyering@redhat.com>
7166 do not dereference NULL upon failed strdup
7167 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7168 (ns_get_family): Likewise.
7170 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7172 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7174 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7176 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7179 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7181 Add lexical binding.
7183 * window.c (Ftemp_output_buffer_show): New fun.
7184 (Fsave_window_excursion):
7185 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7187 * lread.c (lisp_file_lexically_bound_p): New function.
7188 (Fload): Bind Qlexical_binding.
7189 (readevalloop): Remove `evalfun' arg.
7190 Bind Qinternal_interpreter_environment.
7191 (Feval_buffer): Bind Qlexical_binding.
7192 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7194 (syms_of_lread): Declare `lexical-binding'.
7196 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7198 * keyboard.c (eval_dyn): New fun.
7199 (menu_item_eval_property): Use it.
7201 * image.c (parse_image_spec): Use Ffunctionp.
7203 * fns.c (concat, mapcar1): Accept byte-code-functions.
7205 * eval.c (Fsetq): Handle lexical vars.
7206 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7207 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7208 (FletX, Flet): Obey lexical binding.
7209 (Fcommandp): Handle closures.
7210 (Feval): New `lexical' arg.
7211 (eval_sub): New function extracted from Feval. Use it almost
7212 everywhere where Feval was used. Look up vars in lexical env.
7214 (Ffunctionp): Move from subr.el.
7215 (Ffuncall): Handle closures.
7216 (apply_lambda): Remove `eval_flags'.
7217 (funcall_lambda): Handle closures and new byte-code-functions.
7218 (Fspecial_variable_p): New function.
7219 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7220 but without exporting it to Lisp.
7222 * doc.c (Fdocumentation, store_function_docstring):
7223 * data.c (Finteractive_form): Handle closures.
7225 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7228 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7230 (exec_byte_code): New function extracted from Fbyte_code to handle new
7231 calling convention for byte-code-functions. Add new byte-codes.
7233 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7235 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7237 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7239 * xdisp.c (redisplay_internal): Fix prototype.
7241 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7243 * xdisp.c (SCROLL_LIMIT): New macro.
7244 (try_scrolling): Use it when setting scroll_limit.
7245 Limit scrolling to 100 screen lines.
7246 (redisplay_window): Even when falling back on "recentering",
7247 position point in the window according to scroll-conservatively,
7248 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7250 (try_scrolling): When point is above the window, allow searching
7251 as far as scroll_max, or one screenful, to compute vertical
7252 distance from PT to the scroll margin position. This prevents
7253 try_scrolling from unnecessarily failing when
7254 scroll-conservatively is set to a value slightly larger than the
7255 window height. Clean up the case of PT below the margin at bottom
7256 of window: scroll_max can no longer be INT_MAX. When aggressive
7257 scrolling is in use, don't let point enter the opposite scroll
7258 margin as result of the scroll.
7259 (syms_of_xdisp) <scroll-conservatively>: Document the
7260 threshold of 100 lines for never-recentering scrolling.
7262 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7264 * dispextern.h (move_it_by_lines):
7265 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7266 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7267 (message_log_check_duplicate): Remove parameters `prev_bol' and
7268 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7269 (redisplay_internal): Remove parameter `preserve_echo_area',
7270 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7272 * indent.c (Fvertical_motion):
7273 * window.c (window_scroll_pixel_based, Frecenter):
7274 Don't pass `need_y_p' to `move_it_by_lines'.
7276 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7278 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7279 steal a few bits to be more compact.
7280 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7281 Remove unneeded casts.
7283 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7285 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7287 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7288 binding" message (bug#7967).
7290 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7292 Fix more problems found by GCC 4.6.0's static checks.
7294 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7295 Remove unused local var.
7297 * editfns.c (Fmessage_box): Remove unused local var.
7299 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7300 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7301 Omit unused local vars.
7302 * window.c (shrink_windows): Omit unused local var.
7303 * menu.c (digest_single_submenu): Omit unused local var.
7304 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7305 Omit unused local var.
7307 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7308 Don't assume string length fits in int.
7309 (keyremap_step, read_key_sequence): Use size_t for sizes.
7310 (read_key_sequence): Don't check last_real_key_start redundantly.
7312 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7313 instead of alloca (Bug#8344).
7315 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7316 (Fbacktrace_frame): Don't assume nframes fits in int.
7318 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7320 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7323 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7325 * cm.c (calccost): Turn while-do into do-while, for clarity.
7327 * keyboard.c (syms_of_keyboard): Use the same style as later
7328 in this function when indexing through an array. This also
7329 works around GCC bug 48267.
7331 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7333 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7335 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7336 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7338 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7339 This avoids undefined behavior on integer overflow, and is a bit
7340 more convenient anyway since it is compared to a size_t variable.
7342 Variadic C functions now count arguments with size_t, not int.
7343 This avoids an unnecessary limitation on 64-bit machines, which
7344 caused (substring ...) to crash on large vectors (Bug#8344).
7345 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7346 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7347 All variadic functions and their callers changed accordingly.
7348 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7349 * data.c (arith_driver, float_arith_driver): Likewise.
7350 * editfns.c (general_insert_function): Likewise.
7351 * eval.c (struct backtrace.nargs, interactive_p)
7352 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7353 (funcall_lambda, mark_backtrace): Likewise.
7354 * fns.c (concat): Likewise.
7355 * frame.c (x_set_frame_parameters): Likewise.
7356 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7357 0 if not found, not -1. All callers changed.
7359 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7360 (stack_copy_size): Now size_t, not int.
7361 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7363 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7365 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7366 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7367 All callers changed.
7369 * lisp.h (multibyte_char_to_unibyte):
7370 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7371 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7372 * character.h (CHAR_TO_BYTE8):
7373 * cmds.c (internal_self_insert):
7374 * editfns.c (general_insert_function):
7375 * keymap.c (push_key_description):
7376 * search.c (Freplace_match):
7377 * xdisp.c (message_dolog, set_message_1): All callers changed.
7379 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7381 * keyboard.c (safe_run_hook_funcall): New function.
7382 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7383 don't set the hook to nil, but remove the offending function instead.
7384 (Qcommand_hook_internal): Remove, unused.
7385 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7386 Vcommand_hook_internal.
7388 * eval.c (enum run_hooks_condition): Remove.
7389 (funcall_nil, funcall_not): New functions.
7390 (run_hook_with_args): Call each function through a `funcall' argument.
7391 Remove `cond' argument, now redundant.
7392 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7393 (Frun_hook_with_args_until_failure): Adjust accordingly.
7394 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7396 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7398 * dispextern.h (string_buffer_position): Remove declaration.
7400 * print.c (strout): Remove parameter `multibyte', unused since
7401 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7403 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7404 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7405 All callers changed.
7407 * w32.c (_wsa_errlist): Use braces for struct initializers.
7409 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7410 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7411 All callers changed.
7412 (string_buffer_position): Likewise. Also, make static (it's never
7413 used outside xdisp.c).
7414 (cursor_row_p): Remove parameter `w', unused since
7415 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7416 (decode_mode_spec): Remove parameter `precision', introduced during
7417 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7418 All callers changed.
7420 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7422 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7424 2011-03-27 Anders Lindgren <andlind@gmail.com>
7426 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7427 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7428 (ns_update_auto_hide_menu_bar): New functions.
7429 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7430 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7431 ns_constrain_all_frames.
7432 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7433 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7435 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7437 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7439 2011-03-27 Glenn Morris <rgm@gnu.org>
7441 * syssignal.h: Replace RETSIGTYPE with void.
7442 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7443 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7444 Replace SIGTYPE with void everywhere.
7445 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7446 * s/template.h (SIGTYPE): Remove commented out definition.
7448 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7450 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7451 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7453 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7455 * w32.c (read_unc_volume): Use parameter `henum', instead of
7456 global variable `wget_enum_handle'.
7458 * keymap.c (describe_vector): Remove parameters `indices' and
7459 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7460 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7462 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7464 * keyboard.c (timer_check): Remove parameter `do_it_now',
7465 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7466 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7467 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7469 * keyboard.c (read_char):
7470 * w32menu.c (w32_menu_display_help):
7471 * xmenu.c (show_help_event, menu_help_callback):
7472 Adjust calls to `show_help_echo'.
7474 * gtkutil.c (xg_maybe_add_timer):
7475 * keyboard.c (readable_events):
7476 * process.c (wait_reading_process_output):
7477 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7479 * insdel.c (adjust_markers_gap_motion):
7480 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7481 (gap_left, gap_right): Don't call it.
7483 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7485 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7486 incurred during fontification.
7488 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7490 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7491 (DEFVAR_PER_BUFFER): Don't pass it.
7493 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7494 (scrolling_window): Don't pass it.
7496 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7498 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7500 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7502 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7503 of variables specific to SELinux and computation of `encoded_absname'.
7505 * image.c (XPutPixel): Remove unused variable `height'.
7507 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7509 * unexw32.c (get_section_info): Remove unused variable `section'.
7511 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7512 (system_process_attributes): Remove unused variable `sess'.
7513 (sys_read): Remove unused variable `err'.
7515 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7516 (w32_wnd_proc): Remove unused variable `isdead'.
7517 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7518 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7519 (x_create_tip_frame): Remove unused variable `tem'.
7521 * w32inevt.c (w32_console_read_socket):
7522 Remove unused variable `no_events'.
7524 * w32term.c (x_draw_composite_glyph_string_foreground):
7525 Remove unused variable `width'.
7527 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7529 * w32term.c (x_set_glyph_string_clipping):
7530 Don't pass uninitialized region to CombineRgn.
7532 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7534 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7535 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7536 (Fx_close_connection): Remove unused variable `i'.
7538 * w32font.c (w32font_draw): Return number of glyphs.
7539 (w32font_open_internal): Remove unused variable `i'.
7540 (w32font_driver): Add missing initializer.
7542 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7543 (fill_in_menu): Remove unused variable `items_added'.
7545 * w32term.c (last_mouse_press_frame): Remove static global variable.
7546 (w32_clip_to_row): Remove unused variable `f'.
7547 (x_delete_terminal): Remove unused variable `i'.
7549 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7550 (NOTHING): Remove unused static global variable.
7551 (uniscribe_check_otf): Remove unused variable `table'.
7552 (uniscribe_font_driver): Add missing initializers.
7554 2011-03-23 Julien Danjou <julien@danjou.info>
7556 * term.c (Fsuspend_tty, Fresume_tty):
7557 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7558 * window.c (temp_output_buffer_show):
7559 * insdel.c (signal_before_change):
7560 * frame.c (Fhandle_switch_frame):
7561 * fileio.c (Fdo_auto_save):
7562 * emacs.c (Fkill_emacs):
7563 * editfns.c (save_excursion_restore):
7564 * cmds.c (internal_self_insert):
7565 * callint.c (Fcall_interactively):
7566 * buffer.c (Fkill_all_local_variables):
7567 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7569 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7570 unconditionnaly since it does the check itself.
7572 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7574 Fix more problems found by GCC 4.5.2's static checks.
7576 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7577 the first time through the loop, since we know p0 < p1 then.
7578 This also avoids a gcc -Wstrict-overflow warning.
7580 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7581 leading to a memory leak, possible in functions like
7582 load_charset_map_from_file that can allocate an unbounded number
7583 of objects (Bug#8318).
7585 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7586 that could (at least in theory) be that large.
7588 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7589 This is less likely to overflow, and avoids undefined behavior if
7590 overflow does occur. All callers changed. Use strtoul to scan
7591 for the unsigned long integer.
7592 (pint2hrstr): Simplify and tune code slightly.
7593 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7595 * scroll.c (do_scrolling): Work around GCC bug 48228.
7596 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7598 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7599 This also avoids a warning with gcc -Wstrict-overflow.
7600 (validate_x_resource_name): Simplify count usage.
7601 This also avoids a warning with gcc -Wstrict-overflow.
7603 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7606 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7608 * process.c (Fmake_network_process): Use socklen_t, not int,
7609 where POSIX says socklen_t is required in portable programs.
7610 This fixes a porting bug on hosts like 64-bit HP-UX, where
7611 socklen_t is wider than int (Bug#8277).
7612 (Fmake_network_process, server_accept_connection):
7613 (wait_reading_process_output, read_process_output):
7616 * process.c: Rename or move locals to avoid shadowing.
7617 (list_processes_1, Fmake_network_process):
7618 (read_process_output_error_handler, exec_sentinel_error_handler):
7619 Rename or move locals.
7620 (Fmake_network_process): Define label "retry_connect" only if needed.
7621 (Fnetwork_interface_info): Fix pointer signedness.
7622 (process_send_signal): Add cast to avoid pointer signedness problem.
7623 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7624 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7626 Make tparam.h and terminfo.c consistent.
7627 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7628 Include tparam.h instead, since it declares them.
7629 * cm.h (PC): Remove extern decl; tparam.h now does this.
7630 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7631 * terminfo.c: Include tparam.h, to check interfaces.
7632 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7633 (tparam): Adjust signature to match interface in tparam.h;
7634 this removes some undefined behavior. Check that outstring and len
7635 are zero, which they always are with Emacs.
7636 * tparam.h (PC, BC, UP): New extern decls.
7638 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7639 (xftfont_open): Rename locals to avoid shadowing.
7641 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7642 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7643 (OTF_TAG_SYM): Omit macro if not needed.
7644 (ftfont_list): Remove unused local.
7645 (get_adstyle_property, ftfont_pattern_entity):
7646 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7647 Rename locals to avoid shadowing.
7649 * xfont.c (xfont_list_family): Mark var as initialized.
7651 * xml.c (make_dom): Now static.
7653 * composite.c (composition_compute_stop_pos): Rename local to
7655 (composition_reseat_it): Remove unused locals.
7656 (find_automatic_composition, composition_adjust_point): Likewise.
7657 (composition_update_it): Mark var as initialized.
7658 (find_automatic_composition): Mark vars as initialized,
7659 with a FIXME (Bug#8290).
7661 character.h: Rename locals to avoid shadowing.
7662 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7663 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7664 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7665 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7668 * textprop.c (property_change_between_p): Remove; unused.
7670 * intervals.c (interval_start_pos): Now static.
7672 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7674 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7675 Rename locals to avoid shadowing.
7677 * sound.c (wav_play, au_play, Fplay_sound_internal):
7678 Fix pointer signedness.
7679 (alsa_choose_format): Remove unused local var.
7680 (wav_play): Initialize a variable to 0, to prevent undefined
7681 behavior (Bug#8278).
7683 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7685 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7687 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7688 clobbering (Bug#8298).
7689 * sysdep.c (sys_subshell): Likewise.
7690 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7692 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7693 This should get cleaned up, so that child_setup has the
7694 same signature on all platforms.
7696 * callproc.c (call_process_cleanup): Now static.
7697 (relocate_fd): Rename locals to avoid shadowing.
7699 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7701 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7702 not to be necessary, and produces flickering.
7704 2011-03-20 Glenn Morris <rgm@gnu.org>
7706 * config.in: Remove file.
7708 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7710 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7711 are now in src/globals.h.
7712 (syms_of_minibuf): Remove spurious & from previous change.
7714 2011-03-20 Leo <sdl.web@gmail.com>
7716 * minibuf.c (completing-read-function): New variable.
7717 (completing-read-default): Rename from completing-read.
7718 (completing-read): Call completing-read-function.
7720 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7722 * xfaces.c (Fx_load_color_file):
7723 Read color file from absolute filename (bug#8250).
7725 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7727 * makefile.w32-in: Update dependencies.
7729 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7731 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7733 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7735 Fix more problems found by GCC 4.5.2's static checks.
7737 * process.c (make_serial_process_unwind, send_process_trap):
7738 (sigchld_handler): Now static.
7740 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7741 That way, the code declares only the vars that it needs.
7742 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7743 * s/cygwin.h (PTY_ITERATION): Likewise.
7744 * s/darwin.h (PTY_ITERATION): Likewise.
7745 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7747 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7748 * process.c (allocate_pty): Don't declare stb unless it's needed.
7750 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7751 (CONSTANTLIM): Remove; unused.
7752 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7753 Define only if needed.
7755 * unexelf.c (unexec): Name an expression,
7756 to avoid gcc -Wbad-function-cast warning.
7757 Use a different way to cause a compilation error if anyone uses
7758 n rather than nn, a way that does not involve shadowing.
7759 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7761 * deps.mk (unexalpha.o): Remove; unused.
7763 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7764 * unexec.h: New file.
7765 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7766 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7768 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7769 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7770 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7771 Change as necessary to match prototype in unexec.h.
7773 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7775 (back_comment, skip_chars): Mark vars as initialized.
7777 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7778 Rename locals to avoid shadowing.
7780 * lread.c (read1): Rewrite so as not to use empty "else".
7781 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7783 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7785 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7786 warning when compiling print.c.
7788 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7789 instead of using an uninitialized var.
7790 (font_sort_entities): Mark var as initialized.
7792 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7794 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7795 pointers to constants.
7796 (font_parse_fcname): Remove unused vars.
7797 (font_delete_unmatched): Now static.
7798 (font_get_spec): Remove; unused.
7799 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7800 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7801 Rename or move locals to avoid shadowing.
7803 * fns.c (require_nesting_list, require_unwind): Now static.
7804 (Ffillarray): Rename locals to avoid shadowing.
7806 * floatfns.c (domain_error2): Define only if needed.
7807 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7809 * alloc.c (mark_backtrace): Move decl from here ...
7810 * lisp.h: ... to here, so that it can be checked.
7812 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7813 (Fdefvar): Rewrite so as not to use empty "else".
7814 (lisp_indirect_variable): Name an expression,
7815 to avoid gcc -Wbad-function-cast warning.
7816 (Fdefvar): Rename locals to avoid shadowing.
7818 * callint.c (quotify_arg, quotify_args): Now static.
7819 (Fcall_interactively): Rename locals to avoid shadowing.
7820 Use const pointer when appropriate.
7822 * lisp.h (get_system_name, get_operating_system_release):
7823 Move decls here, to check interfaces.
7824 * process.c (get_operating_system_release): Move decl to lisp.h.
7825 * xrdb.c (get_system_name): Likewise.
7826 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7827 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7828 some of which prompt warnings from gcc -Wbad-function-cast.
7829 (Fformat_time_string, Fencode_time, Finsert_char):
7830 (Ftranslate_region_internal, Fformat):
7831 Rename or remove local vars to avoid shadowing.
7832 (Ftranslate_region_internal): Mark var as initialized.
7834 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7837 * lisp.h (eassert): Check that the argument compiles, even if
7838 ENABLE_CHECKING is not defined.
7840 * data.c (Findirect_variable): Name an expression, to avoid
7841 gcc -Wbad-function-cast warning.
7842 (default_value, arithcompare, arith_driver, arith_error): Now static.
7843 (store_symval_forwarding): Rename local to avoid shadowing.
7844 (Fmake_variable_buffer_local, Fmake_local_variable):
7845 Mark variables as initialized.
7846 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7848 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7849 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7850 Rename locals to avoid shadowing.
7851 (mark_stack): Move local variables into the #ifdef region where
7853 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7854 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7856 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7857 (GC_STRING_CHARS): Remove; not used.
7858 (Fmemory_limit): Cast sbrk's returned value to char *.
7860 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7861 avoids undefined behavior in theory.
7863 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7865 Use functions, not macros, for up- and down-casing (Bug#8254).
7866 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7867 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7868 to use the following functions instead of these macros.
7869 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7870 EMACS_INT, since callers assume the returned value fits in int.
7871 (upcase1): Likewise, for UPCASE_TABLE.
7872 (uppercasep, lowercasep, upcase): New static inline functions.
7873 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7874 the race-condition problem in the old DOWNCASE.
7876 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7877 Rename locals to avoid shadowing.
7878 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7879 (regex_compile, re_search_2, re_match_2_internal):
7880 Remove unused local vars.
7881 (FREE_VAR): Rewrite so as not to use empty "else",
7882 which gcc can warn about.
7883 (regex_compile, re_match_2_internal): Mark locals as initialized.
7884 (RETALLOC_IF): Define only if needed.
7885 (WORDCHAR_P): Likewise. This one is never needed, but is used
7886 only in a comment talking about a compiler bug, so put inside
7887 the #if 0 of that comment.
7888 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7889 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7892 * search.c (boyer_moore): Rename locals to avoid shadowing.
7893 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7894 (PREV_CHAR_BOUNDARY): Likewise.
7896 * search.c (simple_search): Remove unused var.
7898 * dired.c (compile_pattern): Move decl from here ...
7899 * lisp.h: ... to here, so that it can be checked.
7900 (struct re_registers): New forward decl.
7902 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7904 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7906 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7907 Rename locals to avoid shadowing.
7908 (Fvertical_motion): Mark locals as initialized.
7910 * casefiddle.c (casify_object, casify_region): Now static.
7911 (casify_region): Mark local as initialized.
7913 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7915 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7916 New macros, so that the caller can use some names other than
7917 gcpro1, gcpro2, etc.
7918 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7920 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7921 argument, for consistency with GCPRO2_VAR, etc: it is now the
7922 prefix of the variable, not the variable itself. All uses
7924 * dired.c (directory_files_internal, file_name_completion):
7925 Rename locals to avoid shadowing.
7927 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7928 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7929 dired.c's scmp function, had undefined behavior.
7930 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7931 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7932 * buffer.h: ... to here, because these macros use current_buffer,
7933 and the new implementation with inline functions needs to have
7934 current_buffer in scope now, rather than later when the macros
7936 (downcase, upcase1): New static inline functions.
7937 (DOWNCASE, UPCASE1): Reimplement using these functions.
7938 This avoids undefined behavior in expressions like
7939 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7940 from race conditions in accessing the global variables
7941 case_temp1 and case_temp2.
7942 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7943 * lisp.h (case_temp1, case_temp2): Remove their decls.
7944 * character.h (ASCII_CHAR_P): Move from here ...
7945 * lisp.h: ... to here, so that the inline functions mentioned
7948 * dired.c (directory_files_internal_unwind): Now static.
7950 * fileio.c (file_name_as_directory, directory_file_name):
7951 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7953 (file_name_as_directory): Use const pointers when appropriate.
7954 (Fexpand_file_name): Likewise. In particular, newdir might
7955 point at constant storage, so make it a const pointer.
7956 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7957 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7959 (Fset_file_times, Finsert_file_contents, auto_save_error):
7960 Rename locals to avoid shadowing.
7962 * minibuf.c (choose_minibuf_frame_1): Now static.
7963 (Ftry_completion, Fall_completions): Rename or remove locals
7966 * marker.c (bytepos_to_charpos): Remove; unused.
7968 * lisp.h (verify_bytepos, count_markers): New decls,
7969 so that gcc does not warn that these functions aren't declared.
7971 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7972 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7973 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7974 (copy_text): Remove unused local var.
7976 * filelock.c (within_one_second): Now static.
7977 (lock_file_1): Rename local to avoid shadowing.
7979 * buffer.c (fix_overlays_before): Mark locals as initialized.
7980 (fix_start_end_in_overlays): Likewise. This function should be
7981 simplified by using pointers-to-pointers, but that's a different
7983 (switch_to_buffer_1): Now static.
7984 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7985 (report_overlay_modification): Rename locals to avoid shadowing.
7987 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7988 Fix pointer signedness issue.
7989 (sys_subshell): Mark local as volatile if checking for lint,
7990 to suppress a gcc -Wclobbered warning that does not seem to be right.
7991 (MAXPATHLEN): Define only if needed.
7993 * process.c (serial_open, serial_configure): Move decls from here ...
7994 * systty.h: ... to here, so that they can be checked.
7996 * fns.c (get_random, seed_random): Move extern decls from here ...
7997 * lisp.h: ... to here, so that they can be checked.
7999 * sysdep.c (reset_io): Now static.
8000 (wait_for_termination_signal): Remove; unused.
8002 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8003 (copy_keymap_item, append_key, push_text_char_description):
8005 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8006 (DENSE_TABLE_SIZE): Remove; unused.
8007 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8008 (describe_map_tree):
8009 Rename locals to avoid shadowing.
8011 * keyboard.c: Declare functions static if they are not used elsewhere.
8012 (echo_char, echo_dash, cmd_error, top_level_2):
8013 (poll_for_input, handle_async_input): Now static.
8014 (read_char, kbd_buffer_get_event, make_lispy_position):
8015 (make_lispy_event, make_lispy_movement, apply_modifiers):
8016 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8017 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8018 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8019 (read_key_sequence, read_char): Mark locals as initialized.
8020 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8022 * keyboard.h (make_ctrl_char): New decl.
8023 (mark_kboards): Move decl here ...
8024 * alloc.c (mark_kboards): ... from here.
8026 * lisp.h (force_auto_save_soon): New decl.
8028 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8029 (DEFINE_DUMMY_FUNCTION): New macro.
8030 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8032 (main): Add casts to avoid warnings
8033 if GCC considers string literals to be constants.
8035 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8037 * dbusbind.c: Pointer signedness fixes.
8038 (xd_signature, xd_append_arg, xd_initialize):
8039 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8040 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8041 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8042 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8044 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8045 if GCC considers string literals to be constants.
8046 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8048 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8050 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8051 (print_preprocess, print_object): New macro to fix last change.
8053 * print.c (print_preprocess): Don't forget font objects.
8055 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8057 * emacs.c (USAGE3): Doc fixes.
8059 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8061 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8064 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8066 * lisp.h (VWindow_system, Qfile_name_history):
8067 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8068 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8069 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8071 * w32select.c: Don't #include "keyboard.h".
8072 (run_protected): Add extern declaration for waiting_for_input.
8074 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8075 * w32console.c (detect_input_pending, read_input_pending)
8076 (encode_terminal_code):
8077 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8078 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8079 (w32_system_caret_y, Qfile_name_history):
8080 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8081 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8082 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8083 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8084 * w32proc.c (Qlocal, report_file_error):
8085 * w32term.c (Vwindow_system, updating_frame):
8086 * w32uniscribe.c (initialized, uniscribe_font_driver):
8087 Remove unneeded extern declarations.
8089 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8091 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8093 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8095 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8096 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8097 These macros can no longer be used for assignment.
8099 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8100 Assign struct members directly, instead of using BUF_BEGV etc.
8101 (record_buffer_markers, fetch_buffer_markers): New functions for
8102 recording and fetching special buffer markers.
8103 (set_buffer_internal_1, set_buffer_temp): Use them.
8105 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8107 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8109 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8110 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8112 * xdisp.c (hscroll_window_tree):
8113 (reconsider_clip_changes): Use PT instead of BUF_PT.
8115 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8117 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8118 $(EMACS_ROOT)/lib/intprops.h.
8120 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8122 Fix more problems found by GCC 4.5.2's static checks.
8124 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8125 to unsigned char * to avoid compiler diagnostic.
8126 (xg_free_frame_widgets): Make it clear that a local variable is
8127 needed only if USE_GTK_TOOLTIP.
8128 (gdk_window_get_screen): Make it clear that this macro is needed
8129 only if USE_GTK_TOOLTIP.
8130 (int_gtk_range_get_value): New function, which avoids a diagnostic
8131 from gcc -Wbad-function-cast.
8132 (xg_set_toolkit_scroll_bar_thumb): Use it.
8133 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8134 diagnostic from gcc -Wbad-function-cast.
8135 (get_utf8_string, xg_get_file_with_chooser):
8136 Rename locals to avoid shadowing.
8137 (create_dialog): Move locals to avoid shadowing.
8139 * xgselect.c (xg_select): Remove unused var.
8141 * image.c (four_corners_best): Mark locals as initialized.
8142 (gif_load): Initialize transparent_p to zero (Bug#8238).
8143 Mark another local as initialized.
8144 (my_png_error, my_error_exit): Mark with NO_RETURN.
8146 * image.c (clear_image_cache): Now static.
8147 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8148 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8149 (x_edge_detection): Remove unnecessary cast that
8150 gcc -Wbad-function-cast diagnoses.
8151 (gif_load): Fix pointer signedness.
8152 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8153 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8155 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8157 Improve quality of tests for time stamp overflow.
8158 For example, without this patch (encode-time 0 0 0 1 1
8159 1152921504606846976) returns the obviously-bogus value (-948597
8160 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8161 reports time overflow. See
8162 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8163 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8164 * editfns.c: Include limits.h and intprops.h.
8165 (TIME_T_MIN, TIME_T_MAX): New macros.
8166 (time_overflow): Move earlier, to before first use.
8167 (hi_time, lo_time): New functions, for an accurate test for
8169 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8170 (Fget_internal_run_time): Don't assume time_t fits in int.
8171 (make_time): Use list2 instead of Fcons twice.
8172 (Fdecode_time): More accurate test for out-of-range times.
8173 (check_tm_member): New function.
8174 (Fencode_time): Use it, to test for out-of-range times.
8175 (lisp_time_argument): Don't rely on undefined left-shift and
8176 right-shift behavior when checking for time stamp overflow.
8178 * editfns.c (time_overflow): New function, refactoring common code.
8179 (Fformat_time_string, Fdecode_time, Fencode_time):
8180 (Fcurrent_time_string): Use it.
8182 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8183 * dired.c (make_time): Move to ...
8184 * editfns.c (make_time): ... here.
8185 * systime.h: Note the move.
8187 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8189 * fringe.c (update_window_fringes): Remove unused variables.
8191 * unexmacosx.c (copy_data_segment): Also copy __got section.
8194 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8196 * termcap.c [MSDOS]: Include "msdos.h".
8197 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8198 Constify `char *' arguments and their references according to
8199 prototypes in tparam.h.
8201 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8203 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8204 Adapt all references accordingly.
8206 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8208 2011-03-11 Tom Tromey <tromey@redhat.com>
8210 * buffer.c (syms_of_buffer): Remove obsolete comment.
8212 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8214 * termhooks.h (encode_terminal_code): Declare prototype.
8216 * msdos.c (encode_terminal_code): Don't declare prototype.
8218 * term.c (encode_terminal_code): Now external again, used by
8219 w32console.c and msdos.c.
8221 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8222 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8224 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8226 Fix some minor problems found by GCC 4.5.2's static checks.
8228 * fringe.c (update_window_fringes): Mark locals as initialized
8230 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8232 * alloc.c (mark_fringe_data): Move decl from here ...
8233 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8234 to check its interface.
8235 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8237 * fontset.c (free_realized_fontset): Now static.
8238 (Fset_fontset_font): Rename local to avoid shadowing.
8239 (fontset_font): Mark local as initialized.
8240 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8242 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8244 * xselect.c (x_disown_buffer_selections): Remove; not used.
8245 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8246 (x_own_selection, Fx_disown_selection_internal): Rename locals
8248 (x_handle_dnd_message): Remove local to avoid shadowing.
8250 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8251 so that the caller can use some name other than gcpro1.
8252 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8253 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8254 (Fx_backspace_delete_keys_p):
8255 Use them to avoid shadowing, and rename vars to avoid shadowing.
8256 (x_decode_color, x_set_name, x_window): Now static.
8257 (Fx_create_frame): Add braces to silence GCC warning.
8258 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8259 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8260 Remove unused locals.
8261 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8262 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8263 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8266 * xterm.h (x_mouse_leave): New decl.
8268 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8269 Remove unused functions.
8270 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8271 (x_calc_absolute_position): Now static.
8272 (XTread_socket): Don't define label "out" unless it's used.
8273 Don't declare local "event" unless it's used.
8274 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8275 unless they are used.
8276 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8277 (x_fatal_error_signal): Remove; not used.
8278 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8279 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8280 (x_error_catcher, x_connection_closed, x_error_handler):
8281 (x_error_quitter, xembed_send_message, x_iconify_frame):
8282 (my_log_handler): Rename locals to avoid shadowing.
8283 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8284 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8286 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8287 Rename or move locals to avoid shadowing.
8288 (tty_defined_color, merge_face_heights): Now static.
8289 (free_realized_faces_for_fontset): Remove; not used.
8290 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8291 does not deduce is never used uninitialized.
8292 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8293 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8295 * terminal.c (store_terminal_param): Now static.
8297 * xmenu.c (menu_highlight_callback): Now static.
8298 (set_frame_menubar): Remove unused local.
8299 (xmenu_show): Rename parameter to avoid shadowing.
8300 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8301 since they might point to immutable storage.
8302 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8303 since it's unused otherwise.
8305 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8306 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8307 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8308 avoids a gcc -Wuninitialized diagnostic.
8309 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8310 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8311 does not deduce are never used uninitialized.
8313 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8315 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8316 * window.c (window_loop, size_window):
8317 (run_window_configuration_change_hook, enlarge_window): Likewise.
8319 * window.c (display_buffer): Now static.
8320 (size_window): Mark variables that gcc -Wuninitialized
8321 does not deduce are never used uninitialized.
8322 * window.h (check_all_windows): New decl, to forestall
8323 gcc -Wmissing-prototypes diagnostic.
8324 * dispextern.h (bidi_dump_cached_states): Likewise.
8326 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8328 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8330 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8331 and to avoid gcc -Wuninitialized warning.
8332 (load_charset_map): Mark variables that gcc -Wuninitialized
8333 does not deduce are never used uninitialized.
8334 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8336 * coding.c (coding_set_source, coding_set_destination):
8337 Use "else { /* comment */ }" rather than "else /* comment */;"
8338 for clarity, and to avoid gcc -Wempty-body warning.
8339 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8340 a block, when the outer 'i' will do.
8341 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8342 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8343 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8344 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8345 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8346 Rename locals to avoid shadowing.
8347 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8348 * coding.c (emacs_mule_char, encode_invocation_designation):
8349 Now static, since they're not used elsewhere.
8350 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8351 (decode_coding_object, encode_coding_object, detect_coding_system):
8352 (decode_coding_emacs_mule): Mark variables that gcc
8353 -Wuninitialized does not deduce are never used uninitialized.
8354 (detect_coding_iso_2022): Initialize a local variable that might
8355 be used uninitialized. Leave a FIXME because it's not clear that
8356 this initialization is needed. (Bug#8211)
8357 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8358 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8359 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8360 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8361 Remove unused macros.
8363 * category.c (hash_get_category_set): Remove unused local var.
8364 (copy_category_table): Now static, since it's not used elsewhere.
8365 * character.c (string_count_byte8): Likewise.
8367 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8368 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8370 * chartab.c (copy_sub_char_table): Now static, since it's not used
8372 (sub_char_table_ref_and_range, char_table_ref_and_range):
8373 Rename locals to avoid shadowing.
8374 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8376 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8377 (BIDI_BOB): Remove unused macro.
8379 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8380 deduce are never used uninitialized.
8381 * term.c (encode_terminal_code): Likewise.
8383 * term.c (encode_terminal_code): Now static. Remove unused local.
8385 * tparam.h: New file.
8386 * term.c, tparam.h: Include it.
8387 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8388 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8389 Move these decls to tparam.h, and make them agree with what
8390 is actually in tparam.c. The previous trick of using incompatible
8391 decls in different modules does not conform to the C standard.
8392 All callers of tparam changed to use tparam's actual API.
8393 * tparam.c (tparam1, tparam, tgoto):
8394 Use const pointers where appropriate.
8396 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8397 * cm.h (struct cm): Likewise.
8398 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8399 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8400 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8401 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8402 (turn_on_face, init_tty): Likewise.
8403 * termchar.h (struct tty_display_info): Likewise.
8405 * term.c (term_mouse_position): Rename local to avoid shadowing.
8407 * alloc.c (mark_ttys): Move decl from here ...
8408 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8410 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8412 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8414 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8416 * search.c (compile_pattern_1): Remove argument regp, unused since
8417 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8418 (compile_pattern): Don't pass it.
8420 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8422 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8423 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8425 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8427 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8429 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8430 gdk_window_get_screen, gdk_window_get_geometry,
8431 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8432 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8433 (xg_get_pixbuf_from_pixmap): New function.
8434 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8435 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8436 Call xg_get_pixbuf_from_pixmap instead of
8437 gdk_pixbuf_get_from_drawable.
8438 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8439 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8440 (xg_check_special_colors): Use GtkStyleContext and its functions
8442 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8443 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8444 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8445 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8446 Call gtk_widget_get_preferred_size.
8447 (xg_frame_resized): gdk_window_get_geometry only takes 5
8449 (xg_win_to_widget, xg_event_is_for_menubar):
8450 Call gdk_x11_window_lookup_for_display.
8451 (xg_set_widget_bg): New function.
8452 (delete_cb): New function.
8453 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8454 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8455 (xg_set_background_color): Call xg_set_widget_bg.
8456 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8457 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8458 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8459 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8461 (update_frame_tool_bar): Call gtk_widget_hide.
8462 (xg_initialize): Use GDK_KEY_g.
8464 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8466 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8468 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8469 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8470 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8472 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8474 * w32xfns.c (select_palette): Check success of RealizePalette against
8475 GDI_ERROR, not zero.
8477 See ChangeLog.11 for earlier changes.
8483 Copyright (C) 2011 Free Software Foundation, Inc.
8485 This file is part of GNU Emacs.
8487 GNU Emacs is free software: you can redistribute it and/or modify
8488 it under the terms of the GNU General Public License as published by
8489 the Free Software Foundation, either version 3 of the License, or
8490 (at your option) any later version.
8492 GNU Emacs is distributed in the hope that it will be useful,
8493 but WITHOUT ANY WARRANTY; without even the implied warranty of
8494 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8495 GNU General Public License for more details.
8497 You should have received a copy of the GNU General Public License
8498 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.