1 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
8 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
11 2011-09-18 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (display_line): Record maximum and minimum buffer
14 positions even if no glyphs were produced (e.g., by a zero-width
15 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
16 buffer positions that will be removed from the glyph row because
18 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
19 column is beyond frame width: don't subtract 1 "pixel" when
20 computing width of the stretch.
21 (reseat_at_next_visible_line_start): Undo the change made on
22 2011-09-17 that saved paragraph information and restored it after
23 the call to `reseat'. (Bug#9545)
25 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
27 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
28 and turn window cursor on if cleared (Bug#9415).
30 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
32 * search.c (boyer_moore): Take unibyte characters from pattern
35 2011-09-18 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
39 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
41 Fix minor problem found by static checking.
42 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
43 initialized, to pacify gcc -Wuninitialized.
45 * fileio.c: Report proper errno when syscall falls.
46 (Finsert_file_contents): Save and restore errno,
47 so that report_file_error outputs the correct diagnostic.
48 (Fwrite_region) [CLASH_DETECTION]: Likewise.
50 2011-09-18 Eli Zaretskii <eliz@gnu.org>
52 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
54 2011-09-17 Eli Zaretskii <eliz@gnu.org>
56 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
57 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
59 2011-09-17 Eli Zaretskii <eliz@gnu.org>
61 * xdisp.c (reseat_at_next_visible_line_start): Keep information
62 about the current paragraph and restore it after the call to
65 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
66 (bidi_find_paragraph_start): Search back for paragraph beginning
67 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
68 (bidi_move_to_visually_next): Only trigger paragraph-related
69 computations when the last character is a newline or at EOB, not
70 just any NEUTRAL_B. (Bug#9470)
72 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
73 truncated lines if point is covered by a display string. (Bug#9524)
75 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
77 * xselect.c: Relax test for outgoing X longs (Bug#9498).
78 (cons_to_x_long): New function.
79 (lisp_data_to_selection_data): Use it. Correct the test for
80 short-versus-long data; it was negated. Break out of vector
81 loop, for efficiency, when a long datum is discovered.
83 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
85 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
87 2011-09-16 Eli Zaretskii <eliz@gnu.org>
89 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
90 GCC PR/17406) by declaring this function with external scope.
92 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
94 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
95 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
97 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
99 * editfns.c (Fformat): Correctly handle text properties on "%%".
101 2011-09-15 Eli Zaretskii <eliz@gnu.org>
103 * xterm.c (x_draw_composite_glyph_string_foreground):
104 * w32term.c (x_draw_composite_glyph_string_foreground):
105 * term.c (encode_terminal_code):
106 * composite.c (composition_update_it, get_composition_id):
107 * xdisp.c (get_next_display_element)
108 (fill_composite_glyph_string): Add comments about special meaning
109 of TAB characters in a composition.
111 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
113 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
114 This occurs when processing a multibyte format.
115 Problem reported by Wolfgang Jenker.
117 2011-09-15 Johan Bockgård <bojohan@gnu.org>
119 * xdisp.c (try_cursor_movement): Only check for exact match if
120 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
122 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
124 Remove unused external symbols.
125 * dispextern.h (calc_pixel_width_or_height): Remove decl.
126 * xdisp.c (calc_pixel_width_or_height): Now static.
127 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
128 * indent.c (check_display_width):
129 * w32term.c: Fix comment to match code.
130 * xterm.c, xterm.h (x_catching_errors): Remove.
132 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
134 * xselect.c: Use signed conversions more consistently (Bug#9498).
135 (selection_data_to_lisp_data): Assume incoming selection data are
136 signed integers, not unsigned. This is to be consistent with
137 outgoing selection data, which was modified to use signed integers
138 in as part of the fix to Bug#9196 in response to Jan D.'s comment
139 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
140 expects long, not unsigned long.
142 2011-09-14 Eli Zaretskii <eliz@gnu.org>
144 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
145 computation of loop end. Reported by Johan Bockgård
148 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
150 * frame.c (Fother_visible_frames_p): Function deleted.
152 2011-09-12 Eli Zaretskii <eliz@gnu.org>
154 * indent.c (compute_motion): Process display vector front to back
155 rather than the other way around. (Bug#2496)
157 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
159 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
161 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
163 * minibuf.c (Fread_from_minibuffer): Doc fix.
165 2011-09-11 Eli Zaretskii <eliz@gnu.org>
167 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
168 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
170 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
172 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
173 value for non-existent files.
175 2011-09-11 Eli Zaretskii <eliz@gnu.org>
177 * fileio.c (Finsert_file_contents): If the file cannot be opened,
178 set its "size" to -1. This will set the modtime_size field of
179 the corresponding buffer to -1, which is what
180 verify-visited-file-modtime expects for files that do not exist.
183 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
185 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
187 * lisp.h: ... from here. push_key_description is no longer
188 defined in keyboard.c, so its declaration should not be in
189 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
190 logically belongs with push_key_description.
192 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
194 * buffer.h: Include <sys/types.h> instead of <time.h>.
195 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
196 Problem reported by Herbert J. Skuhra.
198 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
200 * xml.c (parse_region): Make the parsing work for
201 non-comment-starting XML files again (bug#9144).
203 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
205 * image.c (gif_load): Fix calculation of bottom and right corner.
208 2011-09-10 Eli Zaretskii <eliz@gnu.org>
210 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
211 redisplay in small windows.
213 2011-09-09 Eli Zaretskii <eliz@gnu.org>
215 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
217 2011-09-08 Martin Rudalics <rudalics@gmx.at>
219 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
220 Operate on live windows only.
222 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
224 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
226 2011-09-07 Eli Zaretskii <eliz@gnu.org>
228 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
229 only under bidi iteration.
231 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
233 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
235 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
237 isnan: Fix porting problem to Solaris 10 with bundled gcc.
238 Without this fix, the command to link temacs failed due to an
239 undefined symbol __builtin_isnan. This is because
240 /usr/include/iso/math_c99.h #defines isnan(x) to
241 __builtin_isnan(x), but the bundled gcc, which identifies itself
242 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
244 * floatfns.c (isnan): #undef, and then #define to a clone of
246 (Fisnan): Always define, since it's always available now.
247 (syms_of_floatfns): Always define isnan at the Lisp level.
249 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
251 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
253 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
255 * fileio.c: Fix bugs with large file offsets (Bug#9428).
256 The previous code assumed that file offsets (off_t values) fit in
257 EMACS_INT variables, which is not true on typical 32-bit hosts.
258 The code messed up by falsely reporting buffer overflow in cases
259 such as (insert-file-contents "big" nil 1 2) into an empty buffer
260 when "big" contains more than 2**29 bytes, even though this
261 inserts just one byte and does not overflow the buffer.
262 (Finsert_file_contents): Store file offsets as off_t
263 values, not as EMACS_INT values. Check for overflow when
264 converting between EMACS_INT and off_t. When checking for
265 buffer overflow or for overlap, take the offsets into account.
266 Don't use EMACS_INT for small values where int suffices.
267 When checking for overlap, fix a typo: ZV was used where
268 ZV_BYTE was intended.
269 (Fwrite_region): Don't assume off_t fits into 'long'.
270 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
272 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
274 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
276 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
278 sprintf-related integer and memory overflow issues (Bug#9412).
280 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
281 (esprintf, exprintf, evxprintf): New functions.
282 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
283 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
284 (modify_event_symbol): Do not assume that the length of
285 name_alist_or_stem is safe to alloca and fits in int.
286 (Fexecute_extended_command): Likewise for function name and binding.
287 (Frecursion_depth): Wrap around reliably on integer overflow.
288 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
289 since some callers pass EMACS_INT values.
290 (Fsingle_key_description): Don't crash if symbol name contains more
291 than MAX_ALLOCA bytes.
292 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
293 (get_minibuffer): Arg is now EMACS_INT, not int.
294 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
295 (esprintf, exprintf, evxprintf): New decls.
296 * window.h (command_loop_level, minibuf_level): Reflect API changes.
298 * dbusbind.c (signature_cat): New function.
299 (xd_signature, Fdbus_register_signal):
300 Do not overrun buffer; instead, report string overflow.
302 * dispnew.c (add_window_display_history): Don't overrun buffer.
303 Truncate instead; this is OK since it's just a log.
305 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
306 even if the time zone offset is outlandishly large.
307 Don't mishandle offset == INT_MIN.
309 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
310 when creating daemon; the previous buffer-overflow check was incorrect.
312 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
313 which has the guts of the old verror function.
315 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
316 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
318 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
319 (font_unparse_xlfd): Don't blindly alloca long strings.
320 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
321 fits in int, when using sprintf. Use single snprintf to count
322 length of string rather than counting it via multiple sprintfs;
323 that's simpler and more reliable.
324 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
325 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
326 sprintf, in case result does not fit in int.
328 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
329 (fontset_from_font): Print it.
331 * frame.c (tty_frame_count): Now printmax_t, not int.
332 (make_terminal_frame, set_term_frame_name): Print it.
333 (x_report_frame_params): In X, window IDs are unsigned long,
334 not signed long, so print them as unsigned.
335 (validate_x_resource_name): Check for implausibly long names,
336 and don't assume name length fits in 'int'.
337 (x_get_resource_string): Don't blindly alloca invocation name;
338 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
341 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
342 (xg_check_special_colors, xg_set_geometry):
343 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
345 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
346 Use esprintf, not sprintf, in case result does not fit in int.
348 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
349 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
350 it as a large positive number.
351 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
352 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
354 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
355 in case result does not fit in int.
357 * print.c (float_to_string): Detect width overflow more reliably.
358 (print_object): Make sprintf buffer a bit bigger, to avoid potential
359 buffer overrun. Don't assume list length fits in 'int'. Treat
360 print length of 0 as 0, not as infinity; to be consistent with other
361 uses of print length in this function. Don't overflow print length
362 index. Don't assume hash table size fits in 'long', or that
363 vectorlike size fits in 'unsigned long'.
365 * process.c (make_process): Use printmax_t, not int, to format
366 process-name gensyms.
368 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
370 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
371 to avoid potential buffer overrun.
373 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
374 if X resource line is longer than 512 bytes.
376 * xfns.c (x_window): Make sprintf buffer a bit bigger
377 to avoid potential buffer overrun.
379 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
381 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
383 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
385 Integer overflow fixes for scrolling, etc.
386 Without these, Emacs silently mishandles large integers sometimes.
387 For example, "C-u 4294967297 M-x recenter" was treated as if
388 it were "C-u 1 M-x recenter" on a typical 64-bit host.
390 * xdisp.c (try_window_id): Check Emacs fixnum range before
393 * window.c (window_scroll_line_based, Frecenter):
394 Check that an Emacs fixnum is in range before assigning it to 'int'.
395 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
396 values converted from Emacs fixnums.
397 (Frecenter): Don't wrap around a line count if it is out of 'int'
398 range; instead, treat it as an extreme value.
399 (Fset_window_configuration, compare_window_configurations):
400 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
402 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
403 that can exceed INT_MAX. Check that EMACS_INT value is in range
404 before assigning it to the (possibly-narrower) index.
405 (match_limit): Don't assume that a fixnum can fit in 'int'.
407 * print.c (print_object): Use ptrdiff_t, not int, for index that can
410 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
411 (Fvertical_motion): Don't wrap around LINES values that don't fit
412 in 'int'. Instead, treat them as extreme values. This is good
413 enough for windows, which can't have more than INT_MAX lines anyway.
415 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
417 * Require libxml/parser.h to avoid compilation warning.
419 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
421 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
422 since this reportedly can destroy thread storage.
424 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
426 * syntax.c (find_defun_start): Update all cache variables if
427 exiting early (Bug#9401).
429 2011-08-30 Eli Zaretskii <eliz@gnu.org>
431 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
433 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
434 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
435 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
437 * term.c (tty_append_glyph): New function.
438 (produce_stretch_glyph): Static function and its prototype deleted.
440 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
443 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
445 * image.c (parse_image_spec): Check for nonnegative, not for positive,
446 when checking :margin (Bug#9390).
447 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
448 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
449 so that the name doesn't mislead. All uses changed.
451 2011-08-28 Johan Bockgård <bojohan@gnu.org>
453 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
456 2011-08-27 Eli Zaretskii <eliz@gnu.org>
458 * xdisp.c (move_it_to): Don't bail out early when reaching
459 position beyond to_charpos, if we are scanning backwards.
460 (move_it_vertically_backward): When DY == 0, make sure we get to
461 the first character in the line after the newline.
463 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
465 * ccl.c: Improve and simplify overflow checking (Bug#9196).
466 (ccl_driver): Do not generate an out-of-range pointer.
467 (Fccl_execute_on_string): Remove unnecessary check for
468 integer overflow, noted by Stefan Monnier in
469 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
470 Remove a FIXME that didn't need fixing.
471 Simplify the newly-introduced buffer reallocation code.
473 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
475 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
477 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
479 Integer and memory overflow issues (Bug#9196).
481 * doc.c (get_doc_string): Rework so that
482 get_doc_string_buffer_size is the actual buffer size, rather than
483 being 1 less than the actual buffer size; this makes xpalloc more
486 * image.c (x_allocate_bitmap_record, cache_image):
487 * xselect.c (Fx_register_dnd_atom):
488 Simplify previous changes by using xpalloc.
490 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
491 since either will do and ptrdiff_t is convenient with xpalloc.
493 * charset.c (charset_table_size)
494 (struct charset_sort_data.priority): Now ptrdiff_t.
495 (charset_compare): Don't overflow if priorities differ greatly.
496 (Fsort_charsets): Don't assume list length fits in int.
497 Check for size-calculation overflow when allocating sort data.
498 (syms_of_charset): Allocate an initial charset table that is
499 just under 64 KiB, to avoid problems with glibc malloc and mmap.
501 * cmds.c (internal_self_insert): Check for size-calculation overflow.
503 * composite.h (struct composition.glyph_len): Now int, not unsigned.
504 The actual value is always <= INT_MAX, and leaving it unsigned made
505 overflow checking harder.
507 * dispextern.h (struct glyph_matrix.rows_allocated)
508 (struct face_cache.size): Now ptrdiff_t, for convenience in use
509 with xpalloc. The values are still always <= INT_MAX.
511 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
513 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
514 (SAFE_NALLOCA): New macro.
516 * region-cache.c (struct boundary.pos, find_cache_boundary)
517 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
518 (set_cache_region, invalidate_region_cache)
519 (revalidate_region_cache, know_region_cache, region_cache_forward)
520 (region_cache_backward, pp_cache):
521 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
522 so that ptrdiff_t * can be passed to xpalloc.
523 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
524 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
525 (pp_cache): Don't assume cache_len fits in int.
526 * region-cache.h: Adjust extern decls to match.
528 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
529 EMACS_INT, since either will do, for xpalloc.
531 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
532 (xnmalloc, xnrealloc, xpalloc): New functions.
534 * bidi.c (bidi_shelve_header_size): New constant.
535 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
536 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
538 * bidi.c (bidi_cache_shrink):
539 * buffer.c (overlays_at, overlays_in, record_overlay_string)
541 Don't update size of array until after memory allocation succeeds,
542 because xmalloc/xrealloc may not return.
543 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
544 now that we have proper integer overflow checking.
545 (record_overlay_string, overlay_strings): Catch overflows when
546 calculating size of overlay_str_buf.
548 * callproc.c (Fcall_process): Check for size overflow when
549 calculating size of args2.
550 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
551 Normally we prefer signed values, but sticking with ptrdiff_t would
552 require adding more-complicated checks.
554 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
555 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
556 Redo buffer-overflow calculations to avoid integer overflow.
557 Add a FIXME comment where memory seems to be over-allocated.
559 * character.c (Fstring): Check for size-calculation overflow.
561 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
562 unnecessary integer overflow. Check for size overflow.
563 (encode_coding_object): Don't update size until xmalloc succeeds.
565 * composite.c (get_composition_id): Check for overflow in glyph
568 Integer and memory overflow fixes for display code.
569 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
570 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
571 (scrolling_window): Check for overflow in size calculations.
572 (line_draw_cost, realloc_glyph_pool, add_row_entry):
573 Don't assume glyph table len fits in int.
574 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
575 (row_table_size): Now ptrdiff_t, not int.
576 (scrolling_window): Avoid overflow in size calculations.
577 Don't update size until allocation succeeds.
578 * fns.c (concat): Check for overflow in size calculations.
579 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
580 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
581 (NEXT_ALMOST_PRIME_LIMIT): New constant.
583 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
584 (get_doc_string): Check for size calculation overflow.
585 Don't update size until allocation succeeds.
586 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
587 EMACS_INT, where ptrdiff_t will do.
588 (Fsubstitute_command_keys): Check for string overflow.
590 * editfns.c (set_time_zone_rule): Don't assume environment length
592 (message_length): Now ptrdiff_t, not int.
593 (Fmessage_box): Don't update size until allocation succeeds.
594 Don't assume message length fits in int.
595 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
597 * emacs.c (main): Do not reallocate argv, since there is a null at
598 the end that can be overwritten, and this way there's no need to
599 worry about size-calculation overflow.
600 (sort_args): Check for size-calculation overflow.
602 * eval.c (init_eval_once, grow_specpdl): Don't update size until
604 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
606 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
607 (x_set_scroll_bar_width, x_figure_window_size):
608 Check for integer overflow.
609 (x_set_alpha): Do not assume XINT fits in int.
611 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
612 This is for the members text_lines, text_cols, total_lines, total_cols,
613 where the system imposes an 'int' limit.
615 * fringe.c (Fdefine_fringe_bitmap):
616 Don't update size until alloc works.
618 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
619 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
621 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
622 Check for size-calculation overflow.
623 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
624 do, as we prefer signed integers.
625 (id_to_widget.max_size, id_to_widget.used)
626 (xg_store_widget_in_map, xg_remove_widget_from_map)
627 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
628 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
629 Use and return ptrdiff_t, not int.
630 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
631 * gtkutil.h: Change prototypes to match the above.
633 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
634 are duplicate now that they've been promoted to lisp.h.
635 (x_allocate_bitmap_record, x_alloc_image_color)
636 (make_image_cache, cache_image, xpm_load):
637 Don't update size until alloc is done.
638 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
640 Check for size calculation overflow.
641 (ct_colors_allocated_max): New constant.
642 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
645 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
646 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
647 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
648 Use ptrdiff_t, not int, to count maps.
649 (read_char_minibuf_menu_prompt): Check for overflow in size
650 calculations. Don't update size until allocation succeeds. Redo
651 calculations to avoid overflow.
652 * keyboard.h: Change prototypes to match the above.
654 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
656 (current_minor_maps): Check for size calculation overflow.
657 * keymap.h: Change prototypes to match the above.
659 * lread.c (read1, init_obarray): Don't update size until alloc done.
661 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
662 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
664 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
665 Now ptrdiff_t, not int.
666 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
667 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
669 * process.c (Fnetwork_interface_list): Check for overflow
672 * region-cache.c (move_cache_gap): Check for size calculation overflow.
674 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
675 overflow. Don't bother calling xmalloc when xrealloc will do.
677 * search.c (Freplace_match): Check for size calculation overflow.
678 (Fset_match_data): Don't assume list lengths fit in 'int'.
680 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
681 for command line length. Do not attempt to address one before the
682 beginning of an array, as that's not portable.
684 * term.c (max_frame_lines): Remove; unused.
685 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
687 (encode_terminal_code, calculate_costs): Check for size
688 calculation overflow.
689 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
690 table lengths and related sizes. Don't update size until alloc
691 done. Redo calculations to avoid overflow.
692 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
694 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
695 subtracting pointers.
696 (gobble_line): Check for overflow more carefully. Don't update size
699 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
700 Don't update size until alloc done.
701 Redo size calculations to avoid overflow.
702 Check for size calculation overflow.
703 (main) [DEBUG]: Fix typo in invoking tparam1.
705 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
706 Use ptrdiff_t, not int, for sizes.
707 (store_mode_line_noprop_char): Don't update size until alloc done.
709 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
710 Use ptrdiff_t, not int, for sizes.
711 (Finternal_make_lisp_face, cache_face):
712 Check for size calculation overflow.
713 (cache_face): Treat size calculation overflows as if they were
714 memory exhaustion (the usual treatment), rather than aborting.
716 * xfns.c (x_encode_text, x_set_name_internal)
717 (Fx_change_window_property): Use ptrdiff_t, not int, to count
718 sizes, since they can exceed INT_MAX in size. Check for size
719 calculation overflow.
721 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
722 (xg_select): Check for size calculation overflow.
723 Don't update size until alloc done.
725 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726 as sprintf is limited to int lengths.
728 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
729 (X_LONG_MIN): New macros.
730 Use them to make the following changes clearer.
731 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
732 This change doesn't affect the value now, but it may help remind
733 future maintainers not to raise the value too much later.
734 (SELECTION_QUANTUM): Remove, replacing with ...
735 (selection_quantum): ... new function, which avoids overflow.
737 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
738 assumption that selection length fits in 'int'.
739 (x_reply_selection_request, x_handle_selection_request)
740 (x_get_window_property, receive_incremental_selection)
741 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
742 (lisp_data_to_selection_data, clean_local_selection_data):
743 Use ptrdiff_t, not int, to record length of selection.
744 (x_reply_selection_request, x_get_window_property)
745 (receive_incremental_selection, x_property_data_to_lisp):
746 Redo calculations to avoid overflow.
747 (x_reply_selection_request): When sending hint, ceiling it at
748 X_LONG_MAX rather than relying on wraparound overflow to send
750 (x_get_window_property, receive_incremental_selection)
751 (lisp_data_to_selection_data, x_property_data_to_lisp):
752 Check for size-calculation overflow.
753 (x_get_window_property, receive_incremental_selection)
754 (lisp_data_to_selection_data, Fx_register_dnd_atom):
755 Don't store size until memory allocation succeeds.
756 (x_get_window_property): Plug memory leak on memory exhaustion.
757 Don't double-block input; malloc is safe here. Don't assume 2**34
758 - 4 fits in unsigned long. Add an xassert to check
759 XGetWindowProperty overflow. Be more careful about overflow
760 calculations, and distinguish size from memory overflow better.
761 (receive_incremental_selection): When tracing, don't assume
762 unsigned int is less than INT_MAX.
763 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
764 harmful) conversions of unsigned short to int.
765 (lisp_data_to_selection_data): Don't assume that integers
766 in the range -65535 through -1 fit in an X unsigned short.
767 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
768 result parameters unless successful. Rely on cons_to_unsigned
769 to report problems with elements; the old code wasn't right anyway.
770 (x_check_property_data): Check for int overflow; we cannot use
771 a wider type due to X limits.
772 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
774 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
776 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
777 (x_term_init): Check for size calculation overflow.
778 (x_color_cells): Don't store size until memory allocation succeeds.
779 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
780 Don't assume alloca size is less than MAX_ALLOCA.
781 (x_term_init): Don't assume length fits in int (sprintf is limited
784 Use ptrdiff_t for composition IDs.
785 * character.c (lisp_string_width):
786 * composite.c (composition_table_size, n_compositions)
787 (get_composition_id, composition_gstring_from_id):
788 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
789 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
790 * window.c (Frecenter):
791 Use ptrdiff_t, not int, for composition IDs.
792 * composite.c (get_composition_id): Check for integer overflow.
793 * composite.h: Adjust prototypes to match the above changes.
795 Use ptrdiff_t for hash table indexes.
796 * category.c (hash_get_category_set):
797 * ccl.c (ccl_driver):
798 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
799 * coding.c (coding_system_charset_list, detect_coding_system):
800 * coding.h (struct coding_system.id):
801 * composite.c (get_composition_id, gstring_lookup_cache):
802 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
803 * image.c (xpm_get_color_table_h):
804 * lisp.h (hash_lookup, hash_put):
805 * minibuf.c (Ftest_completion):
806 Use ptrdiff_t for hash table indexes, not int (which is too
807 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
808 32-bit --with-wide-int hosts).
810 * charset.c (Fdefine_charset_internal): Check for integer overflow.
811 Add a FIXME comment about memory leaks.
812 (syms_of_charset): Don't assume xmalloc returns.
814 Don't assume that stated character widths fit in int.
815 * character.c (Fchar_width, c_string_width, lisp_string_width):
816 * character.h (CHAR_WIDTH):
817 * indent.c (MULTIBYTE_BYTES_WIDTH):
818 Use sanitize_char_width to avoid undefined and/or bad behavior
819 with outlandish widths.
820 * character.h (sanitize_tab_width): Renamed from sanitize_width,
821 now that we have two such functions. All uses changed.
822 (sanitize_char_width): New inline function.
824 Don't assume that tab-width fits in int.
825 * character.h (sanitize_width): New inline function.
826 (SANE_TAB_WIDTH): New macro.
827 (ASCII_CHAR_WIDTH): Use it.
828 * indent.c (sane_tab_width): Remove. All uses replaced by
829 SANE_TAB_WIDTH (current_buffer).
830 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
832 * fileio.c: Integer overflow issues with file modes.
833 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
835 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
836 Remove unreachable code.
837 (read_hex, load_charset_map_from_file): Check for integer overflow.
839 * xterm.c: don't go over XClientMessageEvent limit
840 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
841 (x_send_scroll_bar_event): Likewise. Check that the size does not
842 exceed limits imposed by XClientMessageEvent, as well as the usual
843 ptrdiff_t and size_t limits.
845 * keyboard.c: Overflow, signedness and related fixes.
846 (make_lispy_movement): Use same integer type in forward decl
847 that is used in the definition.
848 (read_key_sequence, keyremap_step):
849 Change bufsize argument back to int, undoing my 2011-03-30 change.
850 We prefer signed types, and int is wide enough here.
851 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
852 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
853 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
854 length, not size_t. Use ptrdiff_t for index, not int.
855 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
856 possibility of integer overflow.
858 Overflow, signedness and related fixes for images.
860 * dispextern.h (struct it.stack[0].u.image.image_id)
861 (struct_it.image_id, struct image.id, struct image_cache.size)
862 (struct image_cache.used, struct image_cache.ref_count):
863 * gtkutil.c (update_frame_tool_bar):
864 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
865 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
866 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
867 * nsmenu.m (update_frame_tool_bar):
868 * xdisp.c (calc_pixel_width_or_height):
869 * xfns.c (image_cache_refcount):
870 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
871 on typical 64-bit hosts.
873 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
874 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
875 Omit unnecessary casts to int.
876 (parse_image_spec): Check that integers fall into 'int' range
877 when the callers expect that.
878 (image_ascent): Redo ascent calculation to avoid int overflow.
879 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
880 (lookup_image): Remove unnecessary tests.
881 (xbm_image_p): Locals are now of int, not EMACS_INT,
882 since parse_image_check makes sure they fit into int.
883 (png_load, gif_load, svg_load_image):
884 Prefer int to unsigned where either will do.
885 (tiff_handler): New function, combining the cores of the
886 old tiff_error_handler and tiff_warning_handler. This
887 function is rewritten to use vsnprintf and thereby avoid
888 stack buffer overflows. It uses only the features of vsnprintf
889 that are common to both POSIX and native Microsoft.
890 (tiff_error_handler, tiff_warning_handler): Use it.
891 (tiff_load, gif_load, imagemagick_load_image):
892 Don't assume :index value fits in 'int'.
893 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
894 (imagemagick_load_image): Check that crop parameters fit into
895 the integer types that MagickCropImage accepts. Don't assume
896 Vimagemagick_render_type has a nonnegative value. Don't assume
897 size_t fits in 'long'.
898 (gs_load): Use printmax_t to print the widest integers possible.
899 Check for integer overflow when computing image height and width.
901 2011-08-26 Eli Zaretskii <eliz@gnu.org>
903 * xdisp.c (redisplay_window): Don't force window start if point
904 will be invisible in the resulting window. (Bug#9324)
906 2011-08-25 Eli Zaretskii <eliz@gnu.org>
908 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
909 the display spec is of the form `(space ...)'.
910 (handle_display_spec): Return the value returned by
911 handle_single_display_spec, not just 1 or zero.
912 (handle_single_display_spec): If the display spec is of the form
913 `(space ...)', and specifies display in the text area, return 2
915 (try_cursor_movement): Check for the need to scroll more
916 accurately, and prefer exact match for point under bidi. Don't
917 advance `row' beyond the last row of the window.
919 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
920 into disp_prop; all users changed.
922 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
923 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
924 for the text covered by the display property.
926 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
928 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
929 Change return value to nil.
930 (Frecord_buffer): Delete unused function.
932 2011-08-24 Eli Zaretskii <eliz@gnu.org>
934 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
935 buffers, return left-to-right.
936 (set_cursor_from_row): Consider candidate row a win if its glyph
937 represents a newline and point is on that newline. Fixes cursor
938 positioning on the newline at EOL of R2L text within L2R
939 paragraph, and vice versa.
940 (try_cursor_movement): Check continued rows, in addition to
941 continuation rows. Fixes unwarranted scroll when point enters a
942 continued line of R2L text within an L2R paragraph, or vice versa.
943 (cursor_row_p): Consider the case of point being equal to
944 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
945 from the end of a short line to the beginning of a continued line
946 of R2L text within L2R paragraph.
947 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
950 * bidi.c (bidi_check_type): Use xassert.
951 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
954 2011-08-23 Eli Zaretskii <eliz@gnu.org>
956 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
959 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
961 * nsfont.m (ns_otf_to_script): Fix typo.
963 2011-08-22 Kenichi Handa <handa@m17n.org>
965 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
966 extra slot even if the purpose is char-code-property-table.
968 2011-08-23 Eli Zaretskii <eliz@gnu.org>
970 * xdisp.c (redisplay_window): When computing centering_position,
971 account for the height of the header line. (Bug#8874)
973 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
974 instead of CHAR_TO_BYTE. Fixes a crash when a completion
975 candidate is selected by the mouse, and that candidate has a
976 composed character under the mouse.
978 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
979 coordinates reported by pos-visible-in-window-p for a composed
980 character in column zero.
982 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
984 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
986 2011-08-22 Eli Zaretskii <eliz@gnu.org>
988 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
989 consider it a hit if to_charpos is anywhere in the range of the
990 composed buffer positions.
992 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
994 * image.c (gif_load): Don't assume that each subimage has the same
995 dimensions as the base image. Handle disposal method that is
996 "undefined" by the gif spec (Bug#9335).
998 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1000 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1001 (Fcondition_case): Document `debug' symbol in error handler.
1003 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1005 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1006 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1007 from an Org mode buffer to a Speedbar frame.
1009 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1010 a composition, take its buffer position from IT->cmp_it.charpos.
1011 Fixes cursor positioning at the beginning of a line that begins
1012 with a composed character.
1014 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1016 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1017 character bidirectional type, use STRONG_L instead. Fixes crashes
1018 in a buffer produced by `describe-categories'.
1020 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1021 members before the level stack, so they would be saved and
1022 restored when copying iterator state. Fixes incorrect reordering
1023 around TABs covered by display properties.
1025 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1027 * process.c (Fnetwork_interface_list): Correctly determine buffer
1030 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1032 * eval.c (internal_condition_case, internal_condition_case_1)
1033 (internal_condition_case_2, internal_condition_case_n):
1034 Remove unnecessary aborts (Bug#9081).
1036 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1038 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1039 has no `load' handler, try opening the file locally. (Bug#9311)
1041 2011-08-16 Ken Brown <kbrown@cornell.edu>
1043 * gmalloc.c: Expand comment.
1045 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1047 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1048 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1050 2011-08-16 Ken Brown <kbrown@cornell.edu>
1052 Fix memory allocation problems in Cygwin build (Bug#9273).
1054 * unexcw.c ( __malloc_initialized): Declare external variable.
1055 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1057 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1059 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1061 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1063 [CYGWIN] (special_realloc): New function.
1064 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1065 requests to realloc storage in the static heap.
1067 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1069 * bidi.c (bidi_initialize): Remove unused local.
1071 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1073 * biditype.h: File removed.
1075 * bidimirror.h: File removed.
1077 * deps.mk (bidi.o): Remove biditype.h and
1080 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1083 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1085 * chartab.c: Improve commentary for the uniprop_table API.
1087 * bidi.c (bidi_paragraph_init): Support zero value of
1088 bidi_ignore_explicit_marks_for_paragraph_level.
1089 (bidi_initialize): Use uniprop_table instead of including
1090 biditype.h and bidimirror.h.
1092 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1093 coordinates of the iterator when restoring from ppos_it.
1096 2011-08-14 Kenichi Handa <handa@m17n.org>
1098 * process.c (create_process): Call setup_process_coding_systems
1099 after the pid of the process is set to -1 (Bug#8162).
1101 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1103 * xdisp.c (move_it_in_display_line_to): Don't invoke
1104 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1105 ppos_it. Fixes vertical cursor motion when line beginning is
1106 covered by an image. (Bug#9296)
1108 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1110 * nsterm.h (ns_run_ascript): Declare.
1111 (NSAPP_DATA2_RUNASSCRIPT): Define.
1113 * nsfns.m (as_script, as_result, as_status): New static variables.
1114 (ns_run_ascript): New function.
1115 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1116 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1117 the event loop. Get status from as_status (Bug#7276).
1119 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1120 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1121 the event loop (Bug#7276).
1123 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1125 * gnutls.c (QCgnutls_bootprop_priority)
1126 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1127 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1128 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1129 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1130 (QCgnutls_bootprop_verify_hostname_error)
1131 (QCgnutls_bootprop_callbacks_verify): Rename from
1132 Qgnutls_bootprop_..., all uses changed.
1134 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1137 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1139 * xfaces.c (Qframe_set_background_mode): Now static.
1140 * dispextern.h (Qframe_set_background_mode): Remove decl.
1142 * process.c (Fnetwork_interface_info): Declare local only if needed.
1144 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1146 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1147 (Fnetwork_interface_list): Allocate in increments of bytes instead
1148 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1149 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1151 (struct ifflag_def): notrailers is smart on OSX.
1152 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1153 Get hardware address with getifaddrs if available.
1155 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1157 * xdisp.c (iterate_out_of_display_property): xassert that
1158 IT->position is set to within IT->object's boundaries. Break from
1159 the loop as soon as EOB is reached; avoids infloops in redisplay
1160 when IT->position is set up wrongly due to some bug.
1161 Set IT->current to match the bidi iterator unconditionally.
1162 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1163 entry. Force push_it to save on the stack the current
1164 buffer/string position, to be restored by pop_it. Fix flags in
1165 the iterator structure wrt the object coming from a display
1166 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1167 properties. (Bug#9284)
1169 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1171 * fontset.c (fontset_get_font_group): Add proper type checks.
1174 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1176 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1177 and LC_VERSION_MIN_MACOSX.
1178 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1179 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1181 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1183 * xdisp.c (forward_to_next_line_start): Allow to use the
1184 no-display-properties-and-no-overlays under bidi display.
1185 Set disp_pos in the bidi iterator to avoid searches for display
1186 properties and overlays.
1188 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1190 * editfns.c (Fset_time_zone_rule): Document relationship with the
1193 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1194 the font entity extracted from the cache (Bug#8109).
1196 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1198 * composite.c (autocmp_chars): Don't reset point. That is done by
1199 restore_point_unwind (Bug#5984).
1201 2011-08-07 Juri Linkov <juri@jurta.org>
1203 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1204 to show the arg `TIME' instead of `TIMEVAL'.
1206 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1208 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1209 display property strides EOL and includes a newline, as in
1210 longlines-mode. (Bug#9254)
1211 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1212 word-wrap under bidirectional display. (Bug#9224)
1214 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1215 is non-zero, even if the data buffer is NULL. Fixes a crash in
1216 vertical-motion with longlines-mode. (Bug#9254)
1218 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1220 * bidi.c <bidi_cache_total_alloc>: Now static.
1221 (bidi_initialize): Initialize bidi_cache_total_alloc.
1223 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1226 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1227 amount allocated this far in `bidi_cache_total_alloc'.
1228 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1229 non-zero, only free the data buffer without restoring the cache
1230 contents. All callers changed.
1232 * dispextern.h (bidi_unshelve_cache): Update prototype.
1234 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1235 (move_it_in_display_line, move_it_to)
1236 (move_it_vertically_backward, move_it_by_lines): Replace the call
1237 to xfree to an equivalent call to bidi_unshelve_cache.
1238 (move_it_in_display_line_to): Fix logic of returning
1239 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1241 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1243 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1244 came from a string character with a `cursor' property. (Bug#9229)
1246 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1248 * Makefile.in (LIB_PTHREAD): New variable.
1249 (LIBES): Add LIB_PTHREAD (Bug#9216).
1251 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1252 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1254 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1256 * regex.c (re_iswctype): Remove some redundant boolean
1259 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1261 * xterm.c (x_find_topmost_parent): New function.
1262 (x_set_frame_alpha): Find topmost parent window with
1263 x_find_topmost_parent and set the property there also (bug#9181).
1264 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1266 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1268 * callproc.c (Fcall_process): Avoid vfork clobbering
1269 the local vars buffer, coding_systems, current_dir.
1271 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1273 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1275 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1277 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1278 so that it is not optimized away.
1280 * xdisp.c (compute_display_string_pos): Remove unused local.
1282 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1284 Fix slow cursor motion and scrolling in large buffers with
1285 selective display, like Org Mode buffers. (Bug#9218)
1287 * dispextern.h (struct bidi_it): New member disp_prop_p.
1289 * xdisp.c: Remove one-slot cache of display string positions.
1290 (compute_display_string_pos): Accept an additional argument
1291 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1292 for a display string or property. If found, set DISP_PROP_P
1295 * bidi.c (bidi_fetch_char): Accept an additional argument
1296 DISP_PROP_P, and pass it to compute_display_string_pos.
1297 Only handle text covered by a display string if DISP_PROP_P is returned
1298 non-zero. All callers of bidi_fetch_char changed.
1300 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1302 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1304 2010-12-03 Don March <don@ohspite.net>
1306 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1307 last character M-[char] is translated to ESC [char] (bug#7541).
1309 2011-08-02 Kenichi Handa <handa@m17n.org>
1311 * lisp.h (uniprop_table): Extern it.
1313 * chartab.c (uniprop_table): Make it non-static.
1315 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1317 * xdisp.c (forward_to_next_line_start): Accept additional argument
1318 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1320 (reseat_at_next_visible_line_start): Use the bidi iterator state
1321 returned by forward_to_next_line_start to restore the state of
1322 it->bidi_it after backing up to previous newline. (Bug#9212)
1324 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1326 * regex.c (re_comp): Protoize.
1327 (re_exec): Fix return type.
1328 (regexec): Fix type of `ret'. (Bug#9203)
1330 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1332 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1333 This is needed if max-image-size is a floating-point number.
1335 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1337 * print.c (print_object): Print empty symbol as ##.
1339 * lread.c (read1): Read ## as empty symbol.
1341 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1343 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1344 setting frame foreground color (Bug#9175).
1345 (x_set_background_color): Likewise.
1347 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1348 contents (Bug#9176).
1349 (EmacsTooltip -init): Remove bezels and add shadows to
1352 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1353 or scroll bar (Bug#8470).
1355 * nsfont.m (nsfont_open): Remove assignment to voffset and
1356 unnecessary vars hshink, expand, hd, full_height, min_height.
1357 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1359 * nsterm.h (nsfont_info): Remove voffset field.
1361 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1363 Implement strike-through and overline on NextStep (Bug#8863).
1365 * nsfont.m (nsfont_open): Use underline position provided by font,
1366 instead of hard-coded value of 2.
1367 (nsfont_draw): Call ns_draw_text_decoration instead.
1369 * nsterm.h: Add declaration for ns_draw_text_decoration.
1371 * nsterm.m (ns_draw_text_decoration): New function for drawing
1372 underline, overline, and strike-through.
1373 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1374 ns_draw_text_decoration. Change treatment of cursor drawing to
1375 accommodate underlining, etc.
1377 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1379 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1382 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1384 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1385 Without this fix, if a signal arrives just after memory fills up,
1386 'malloc' might be invoked reentrantly.
1388 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1389 In other words, assume that every image size is allowed, on non-X
1390 hosts. This assumption is probably wrong, but it lets Emacs compile.
1392 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1394 * regex.c (re_iswctype): Convert return values to boolean.
1396 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1398 * xdisp.c (compute_display_string_pos): Don't use cached display
1399 string position if the buffer had its restriction changed.
1402 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1406 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1408 Integer signedness and overflow and related fixes. (Bug#9079)
1410 * bidi.c: Integer size and overflow fixes.
1411 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1412 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1413 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1414 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1415 (bidi_find_other_level_edge):
1416 Use ptrdiff_t instead of EMACS_INT where either will do.
1417 This works better on 32-bit hosts configured --with-wide-int.
1418 (bidi_cache_ensure_space): Check for size-calculation overflow.
1419 Use % rather than repeated addition, for better worst-case speed.
1420 Don't set bidi_cache_size until after xrealloc returns, because it
1422 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1423 (bidi_cache_ensure_space): Also check that the bidi cache size
1424 does not exceed that of the largest Lisp string or buffer. See Eli
1425 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1427 * alloc.c (__malloc_size_t): Remove.
1428 All uses replaced by size_t. See Andreas Schwab's note
1429 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1431 * image.c: Improve checking for integer overflow.
1432 (check_image_size): Assume that f is nonnull, since
1433 it is always nonnull in practice. This is one less thing to
1434 worry about when checking for integer overflow later.
1435 (x_check_image_size): New function, which checks for integer
1436 overflow issues inside X.
1437 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1438 This removes the need for a memory_full check.
1439 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1440 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1441 (xbm_read_bitmap_data): Change locals back to 'int', since
1442 their values must fit in 'int'.
1443 (xpm_load_image, png_load, tiff_load):
1444 Invoke x_create_x_image_and_pixmap earlier,
1445 to avoid much needless work if the image is too large.
1446 (tiff_load): Treat overly large images as if
1447 x_create_x_image_and_pixmap failed, not as malloc failures.
1448 (gs_load): Use x_check_image_size.
1450 * gtkutil.c: Omit integer casts.
1451 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1452 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1454 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1456 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1457 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1458 would wrongly return t on a 64-bit host.
1460 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1461 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1462 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1463 and therefore cause GCC to emit a bogus diagnostic in some cases.
1465 * image.c: Integer signedness and overflow and related fixes.
1466 This is not an exhaustive set of fixes, but it's time to
1467 record what I've got.
1468 (lookup_pixel_color, check_image_size): Remove redundant decls.
1469 (check_image_size): Don't assume that arbitrary EMACS_INT values
1470 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1471 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1472 (tiff_load, imagemagick_load_image):
1473 Check for overflow in size calculations.
1474 (x_create_x_image_and_pixmap): Remove unnecessary test for
1475 xmalloc returning NULL; that can't happen.
1476 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1477 (xpm_color_bucket): Use better integer hashing function.
1478 (xpm_cache_color): Don't possibly over-allocate memory.
1479 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1480 (gif_memory_source):
1481 Use ptrdiff_t, not int or size_t, to record sizes.
1482 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1483 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1484 either works, as we prefer signed integers.
1485 (tiff_read_from_memory, tiff_write_from_memory):
1486 Return tsize_t, not size_t, since that's what the TIFF API wants.
1487 (tiff_read_from_memory): Don't fail simply because the read would
1488 go past EOF; instead, return a short read.
1489 (tiff_load): Omit no-longer-needed casts.
1490 (Fimagemagick_types): Don't assume size fits into 'int'.
1492 Improve hashing quality when configured --with-wide-int.
1493 * fns.c (hash_string): New function, taken from sxhash_string.
1494 Do not discard information about ASCII character case; this
1495 discarding is no longer needed.
1496 (sxhash-string): Use it. Change sig to match it. Caller changed.
1497 * lisp.h: Declare it.
1498 * lread.c (hash_string): Remove, since we now use fns.c's version.
1499 The fns.c version returns a wider integer if --with-wide-int is
1500 specified, so this should help the quality of the hashing a bit.
1502 * emacs.c: Integer overflow minor fix.
1503 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1504 Define only if GNU_LINUX.
1505 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1507 * dispnew.c: Integer signedness and overflow fixes.
1508 Remove unnecessary forward decls, that were a maintenance hassle.
1509 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1511 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1512 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1513 (prepare_desired_row, line_draw_cost):
1514 Use int, not unsigned, where either works.
1515 (save_current_matrix, restore_current_matrix):
1516 Use ptrdiff_t, not size_t, where either works.
1517 (init_display): Check for overflow more accurately, and without
1518 relying on undefined behavior.
1520 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1521 Remove, replacing with the new symbols in lisp.h. All uses changed.
1522 * fileio.c (make_temp_name):
1523 * filelock.c (lock_file_1, lock_file):
1524 * xdisp.c (message_dolog):
1525 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1526 Use pMd etc. instead.
1527 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1528 replacing the pWIDE etc. symbols removed from editfns.c.
1530 * keyboard.h (num_input_events): Now uintmax_t.
1531 This is (very slightly) less likely to mess up due to wraparound.
1534 * buffer.c: Integer signedness fixes.
1535 (alloc_buffer_text, enlarge_buffer_text):
1536 Use ptrdiff_t rather than size_t when either will do, as we prefer
1539 * alloc.c: Integer signedness and overflow fixes.
1540 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1541 (__malloc_size_t): Default to size_t, not to int.
1542 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1543 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1544 Prefer ptrdiff_t to size_t when either would do, as we prefer
1546 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1547 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1548 Now const. Initialize with values that are in range even if char
1550 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1551 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1552 These functions do the right thing with sizes > 2**32.
1553 (check_depth): Now ptrdiff_t, not int.
1554 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1555 Adjust to new way of storing sizes. Check for size overflow bugs
1557 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1558 slightly wrong anyway, as it missed one instance of
1559 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1560 (refill_memory_reserve): Omit needless cast to size_t.
1561 (mark_object_loop_halt): Mark as externally visible.
1563 * xselect.c: Integer signedness and overflow fixes.
1564 (Fx_register_dnd_atom, x_handle_dnd_message):
1565 Use ptrdiff_t, not size_t, since we prefer signed.
1566 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1567 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1568 x_dnd_atoms_size and x_dnd_atoms_length.
1570 * doprnt.c: Prefer signed to unsigned when either works.
1572 * doprnt.c (doprnt):
1574 * xdisp.c (vmessage):
1575 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1576 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1577 prefer signed arithmetic to avoid comparison confusion.
1578 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1579 but is a bit tricky.
1581 Assume freestanding C89 headers, string.h, stdlib.h.
1582 * data.c, doprnt.c, floatfns.c, print.c:
1583 Include float.h unconditionally.
1584 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1585 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1586 * regex.c: Likewise for stddef.h, string.h.
1587 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1588 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1589 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1590 (STDC_HEADERS): Remove obsolete defines.
1591 * sysdep.c: Include limits.h unconditionally.
1593 Assume support for memcmp, memcpy, memmove, memset.
1594 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1595 * regex.c (memcmp, memcpy):
1596 Remove; we assume C89 now.
1598 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1599 (__malloc_safe_bcopy): Remove; no longer needed.
1601 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1602 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1603 well either way, and we prefer signed to unsigned.
1605 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1607 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1608 closes the connection while we're reading (bug#9182).
1610 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1612 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1613 are specified (Bug#9168).
1615 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1617 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1618 Found by GCC static checking and --with-wide-int on a 32-bit host.
1620 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1622 * xdisp.c (compute_display_string_pos): Fix logic of caching
1623 previous display string position. Initialize cached_prev_pos to
1624 -1. Fixes slow-down at the beginning of a buffer.
1626 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1628 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1629 for attrs[LFACE_FONTSET_INDEX].
1631 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1633 * xml.c (parse_region): Remove unused local
1634 that was recently introduced.
1636 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1638 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1639 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1641 * xdisp.c (move_it_in_display_line_to): Record the best matching
1642 position for TO_CHARPOS while scanning the line, and restore it on
1643 exit if none of the characters scanned was an exact match.
1644 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1645 when exact match is impossible due to invisible text, and the
1646 lines are truncated.
1648 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1650 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1653 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1655 Fix a significant slow-down of cursor motion with C-n, C-p,
1656 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1657 auto-repeat under bidi redisplay in fontified buffers.
1658 * xdisp.c (compute_stop_pos_backwards): New function.
1659 (next_element_from_buffer): Call compute_stop_pos_backwards to
1660 find a suitable prev_stop when we find ourselves before
1662 (reseat): Don't look for prev_stop, as that could mean a very long
1664 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1665 <cached_disp_overlay_modiff>: Cache for last found display string
1667 (compute_display_string_pos): Return the cached position if asked
1668 about the same buffer in the same area of character positions, and
1669 the buffer wasn't changed since the time the display string
1670 position was cached.
1672 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1675 is an integer, which is important for empty lines. (Bug#9149)
1677 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1679 * frame.c (Fmodify_frame_parameters): In tty case, update the
1680 default face if necessary (Bug#4238).
1682 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1684 * editfns.c (Fstring_to_char): No need to explain what a character
1685 is in the docstring (Bug#6576).
1687 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1689 * xml.c (parse_region): Make sure we always return a tree.
1691 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1693 * xml.c (parse_region): If a document contains only comments,
1696 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698 * xml.c (make_dom): Return comments, too.
1700 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1703 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1704 and the surrounding thread.
1705 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1706 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1707 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1709 * s/openbsd.h (BROKEN_SIGIO): Define.
1710 * unexelf.c (unexec) [__OpenBSD__]:
1711 Don't update the .mdebug section of the Alpha COFF symbol table.
1713 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1715 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1718 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1720 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1721 This fixes some race conditions on the permissions of any newly
1724 * alloc.c (valid_pointer_p): Use pipe, not open.
1725 This fixes some permissions issues when debugging.
1727 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1728 If fchown fails to set both uid and gid, try to set just gid,
1729 as that is sometimes allowed. Adjust the file's mode to eliminate
1730 setuid or setgid bits that are inappropriate if fchown fails.
1732 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1734 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1735 to compare Lisp_Objects.
1736 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1737 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1738 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1740 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1742 * lread.c (read_integer): Unread even EOF character.
1743 (read1): Likewise. Properly record start position of symbol.
1745 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1746 symbol character follows.
1748 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1750 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1751 This works around a problem with the previous change to Fcopy_file.
1752 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1753 and without this change, GCC might complain about discarding
1754 fchown's return value.
1756 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1758 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1760 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1762 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1764 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1766 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1767 it's used from the C level.
1769 * process.c: Use the same condition for POLL_FOR_INPUT in both
1770 keyboard.c and process.c (bug#1858).
1772 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1774 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1775 (Fgnutls_boot): Use it.
1777 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1779 * doc.c (Fsubstitute_command_keys): Revert last change.
1781 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1783 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1784 quotes the next character, and doesn't affect other longer
1785 sequences (bug#8935).
1787 * lread.c (syms_of_lread): Clarify that is isn't only
1788 `eval-buffer' and `eval-defun' that's affected by
1789 `lexical-binding' (bug#8460).
1791 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1794 bidi redisplay when a line includes both an image and is
1797 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1799 Fix minor problems found by static checking.
1800 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1801 (elsz): Now a signed constant, not a size_t var. We prefer signed
1802 types to unsigned, to avoid integer comparison confusion. Without
1803 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1804 "cannot optimize loop, the loop counter may overflow", a symptom
1806 * indent.c (Fvertical_motion): Mark locals as initialized.
1807 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1809 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1811 * search.c (Fre_search_backward): Mention `case-fold-search' in
1812 all the re_search_* functions (bug#8138).
1814 * keyboard.c (Fopen_dribble_file): Document when the file is
1817 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1819 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1822 Support bidi reordering of display and overlay strings.
1823 * xdisp.c (compute_display_string_pos)
1824 (compute_display_string_end): Accept additional argument STRING.
1825 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1826 (reseat_to_string): Initialize bidi_it->string.s and
1827 bidi_it->string.schars.
1828 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1829 NULL (avoids a crash in bidi_paragraph_init).
1830 Initialize itb.string.lstring.
1831 (init_iterator): Call bidi_init_it only of a valid
1832 buffer position was specified. Initialize paragraph_embedding to
1834 (reseat_to_string): Initialize the bidi iterator.
1835 (display_string): If we need to ignore text properties of
1836 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1837 original value of -1 will not work with bidi.)
1838 (compute_display_string_pos): First arg is now struct
1839 `text_pos *'; all callers changed. Support display properties on
1841 (compute_display_string_end): Support display properties on Lisp
1843 (init_iterator, reseat_1, reseat_to_string): Initialize the
1844 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1845 when iterating on a string not from display properties).
1846 (compute_display_string_pos, compute_display_string_end):
1847 Fix calculation of the object to scan. Fixes an error when using
1849 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1850 base_level_stop; instead, set base_level_stop to BEGV.
1851 Fixes crashes in vertical-motion.
1852 (next_element_from_buffer): Improve commentary for when
1853 the iterator is before prev_stop.
1854 (init_iterator): Initialize bidi_p from the default value of
1855 bidi-display-reordering, not from buffer-local value. Use the
1856 buffer-local value only if initializing for buffer iteration.
1857 (handle_invisible_prop): Support invisible properties on strings
1858 that are being bidi-reordered.
1859 (set_iterator_to_next): Support bidi reordering of C strings and
1861 (next_element_from_string): Support bidi reordering of Lisp
1863 (handle_stop_backwards): Support Lisp strings as well.
1864 (display_string): Support display of R2L glyph rows.
1865 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1866 (init_iterator): Don't initialize it->bidi_p for strings
1868 (reseat_to_string): Initialize it->bidi_p for strings here.
1869 (next_element_from_string, next_element_from_c_string)
1870 (next_element_from_buffer): Add xassert's for correspondence
1871 between IT's object being iterated and it->bidi_it.string
1873 (face_before_or_after_it_pos): Support bidi iteration.
1874 (next_element_from_c_string): Handle the case of the first string
1875 character that is not the first one in the visual order.
1876 (get_visually_first_element): New function, refactored from common
1877 parts of next_element_from_buffer, next_element_from_string, and
1878 next_element_from_c_string.
1879 (tool_bar_lines_needed, redisplay_tool_bar)
1880 (display_menu_bar): Force left-to-right direction. Add a FIXME
1881 comment for making that be controlled by a user option.
1882 (push_it, pop_it): Save and restore the state of the
1883 bidi iterator. Save and restore the bidi_p flag.
1884 (pop_it): Iterate out of display property for string iteration as
1886 (iterate_out_of_display_property): Support iteration over strings.
1887 (handle_single_display_spec): Set up it->bidi_it for iteration
1888 over a display string, and call bidi_init_it.
1889 (handle_single_display_spec, next_overlay_string)
1890 (get_overlay_strings_1, push_display_prop): Set up the bidi
1891 iterator for displaying display or overlay strings.
1892 (forward_to_next_line_start): Don't use the shortcut if
1894 (back_to_previous_visible_line_start): If handle_display_prop
1895 pushed the iterator stack, restore the internal state of the bidi
1896 iterator by calling bidi_pop_it same number of times.
1897 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1898 and we are bidi-iterating, don't decrement the iterator position;
1899 instead, set the first_elt flag in the bidi iterator, to produce
1901 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1902 (push_display_prop): xassert that we are iterating a buffer.
1903 (push_it, pop_it): Save and restore paragraph_embedding member.
1904 (handle_single_display_spec, next_overlay_string)
1905 (get_overlay_strings_1, reseat_1, reseat_to_string)
1906 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1907 correctly. Don't assume unibyte strings are not bidi-reordered.
1908 (compute_display_string_pos)
1909 (compute_display_string_end): Fix handling the case of C string.
1910 (push_it, pop_it): Save and restore from_disp_prop_p.
1911 (handle_single_display_spec, push_display_prop): Set the
1912 from_disp_prop_p flag.
1913 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1914 (pop_it): Call iterate_out_of_display_property only if we are
1915 popping after iteration over a string that came from a display
1916 property. Fix a typo in popping stretch info. Add an assertion
1917 for verifying that the iterator position is in sync with the bidi
1919 (handle_single_display_spec, get_overlay_strings_1)
1920 (push_display_prop): Fix initialization of paragraph direction for
1921 string when that of the parent object is not yet determined.
1922 (reseat_1): Call bidi_init_it to resync the bidi
1923 iterator with IT's position. (Bug#7616)
1924 (find_row_edges): If ROW->start.pos gives position
1925 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1926 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1927 Reset the from_disp_prop_p flag.
1928 (SAVE_IT, RESTORE_IT): New macros.
1929 (pos_visible_p, face_before_or_after_it_pos)
1930 (back_to_previous_visible_line_start)
1931 (move_it_in_display_line_to, move_it_in_display_line)
1932 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1933 (try_scrolling, redisplay_window, display_line): Use them when
1934 saving a temporary copy of the iterator and restoring it back.
1935 (back_to_previous_visible_line_start, reseat_1)
1936 (init_iterator): Empty the bidi cache "stack".
1937 (move_it_in_display_line_to): If iterator ended up at
1938 EOL, but we never saw any buffer positions smaller than
1939 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1940 motion in bidi-reordered lines.
1941 (move_it_in_display_line_to): Record prev_method and prev_pos
1942 immediately before the call to set_iterator_to_next. Fixes cursor
1943 motion in bidi-reordered lines with stretch glyphs and strings
1944 displayed in margins. (Bug#8133) (Bug#8867)
1945 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1947 (pos_visible_p): Support positions in bidi-reordered lines.
1948 Save and restore bidi cache.
1950 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1951 (bidi_paragraph_info): Delete unused struct.
1952 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1953 (bidi_cache_start): New variable.
1954 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1956 (bidi_cache_fetch_state, bidi_cache_search)
1957 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1958 (bidi_cache_find, bidi_peek_at_next_level)
1959 (bidi_level_of_next_char, bidi_find_other_level_edge)
1960 (bidi_move_to_visually_next): Compare cache index with
1961 bidi_cache_start rather than with zero.
1962 (bidi_fetch_char): Accept new argument STRING; all callers
1963 changed. Support iteration over a string. Support strings with
1964 display properties. Support unibyte strings. Fix the type of
1965 `len' according to what STRING_CHAR_AND_LENGTH expects.
1966 (bidi_paragraph_init, bidi_resolve_explicit_1)
1967 (bidi_resolve_explicit, bidi_resolve_weak)
1968 (bidi_level_of_next_char, bidi_move_to_visually_next):
1969 Support iteration over a string.
1970 (bidi_set_sor_type, bidi_resolve_explicit_1)
1971 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1972 can now be zero (for strings); special values 0 and -1 were
1973 changed to -1 and -2, respectively.
1974 (bidi_char_at_pos): New function.
1975 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1976 Call it instead of FETCH_MULTIBYTE_CHAR.
1977 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1978 initialized to valid values.
1979 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1981 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1982 the test for valid cached positions. Fix the logic for looking up
1983 the sentinel state in the cache. GCPRO the Lisp string we are
1985 (bidi_push_it, bidi_pop_it): New functions.
1986 (bidi_initialize): Initialize the bidi cache start stack pointer.
1987 (bidi_cache_ensure_space): New function, refactored from part of
1988 bidi_cache_iterator_state. Don't assume the required size is just
1989 one BIDI_CACHE_CHUNK away.
1990 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1991 (bidi_count_bytes, bidi_char_at_pos): New functions.
1992 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1993 always valid if bidi_cache_idx is valid.
1994 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1995 is valid if it's going to be used.
1996 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1997 (bidi_cache_fetch_state, bidi_cache_search)
1998 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1999 (bidi_cache_iterator_state, bidi_cache_find)
2000 (bidi_find_other_level_edge, bidi_cache_start_stack):
2001 All variables related to cache indices are now EMACS_INT.
2003 * dispextern.h (struct bidi_string_data): New structure.
2004 (struct bidi_it): New member `string'. Make flag members be 1-bit
2005 fields, and put them last in the struct.
2006 (compute_display_string_pos, compute_display_string_end):
2008 (bidi_push_it, bidi_pop_it): Add prototypes.
2009 (struct iterator_stack_entry): New members bidi_p,
2010 paragraph_embedding, and from_disp_prop_p.
2011 (struct it): Member bidi_p is now a bit field 1 bit wide.
2012 (bidi_shelve_cache, bidi_unshelve_cache):
2015 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2016 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2017 and vector-like objects.
2019 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2020 cache around display iteration.
2022 * window.c (Fwindow_end, window_scroll_pixel_based)
2023 (displayed_window_lines, Frecenter): Save and restore the bidi
2024 cache around display iteration.
2026 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2028 * editfns.c (Fdelete_region): Clarify the use of the named
2029 parameters (bug#6788).
2031 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2033 * indent.c (Fvertical_motion): Set and restore w->pointm when
2034 saving and restoring the window's buffer (Bug#9006).
2036 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038 * editfns.c (Fstring_to_char): Clarify just what is returned
2039 (bug#6576). Text by Eli Zaretskii.
2041 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2043 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2045 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2047 * buffer.c (mmap_find): Fix a typo.
2049 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2051 Fix execution of x selection hooks.
2052 * xselect.c (Qx_lost_selection_functions)
2053 (Qx_sent_selection_functions): New vars.
2054 (syms_of_xselect): DEFSYM them.
2055 (x_handle_selection_request): Pass Qx_sent_selection_functions
2056 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2057 (x_handle_selection_clear,x_clear_frame_selections):
2058 Pass Qx_lost_selection_functions rather than
2059 Vx_lost_selection_functions to Frun_hook_with_args.
2061 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2063 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2064 The old code sometimes used this field without initializing it.
2066 * alloc.c (gc_sweep): Don't read past end of array.
2067 In theory, the old code could also have corrupted Emacs internals,
2068 though it'd be very unlikely.
2070 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2072 * character.c (Fcharacterp): Don't advertise optional ignored
2073 argument. (Bug#4026)
2075 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2077 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2080 * window.c (Fset_window_start): Doc fix (bug#4199).
2081 (Fset_window_hscroll): Ditto.
2083 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2085 Fix minor new problems caught by GCC 4.6.1.
2086 * term.c (init_tty): Remove unused local.
2087 * xsettings.c (store_monospaced_changed): Define this function only
2088 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2091 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2093 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2095 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2097 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2098 are the mini-buffer and the echo area (bug#3320).
2100 * term.c (init_tty): Remove support for supdup, c10 and perq
2101 terminals, which are no longer supported (bug#1482).
2103 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2105 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2107 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2109 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2110 for non-popups (Bug#3642).
2112 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2114 * alloc.c (reset_malloc_hooks): Protoize.
2115 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2116 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2117 * cm.c (losecursor): Likewise.
2118 * data.c (fmod): Likewise.
2119 * dispnew.c (swap_glyphs_in_rows): Likewise.
2120 * emacs.c (memory_warning_signal): Likewise.
2121 * floatfns.c (float_error): Likewise.
2122 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2123 (otf_open, font_otf_capability, generate_otf_features)
2124 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2126 * image.c (pbm_read_file): Likewise.
2127 * indent.c (string_display_width): Likewise.
2128 * intervals.c (check_for_interval, search_for_interval)
2129 (inc_interval_count, count_intervals, root_interval)
2130 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2131 * lread.c (defalias): Likewise.
2132 * ralloc.c (r_alloc_check): Likewise.
2133 * regex.c (set_image_of_range_1, set_image_of_range)
2134 (regex_grow_registers): Likewise.
2135 * sysdep.c (strerror): Likewise.
2136 * termcap.c (valid_filename_p, tprint, main): Likewise.
2137 * tparam.c (main): Likewise.
2138 * unexhp9k800.c (run_time_remap, save_data_space)
2139 (update_file_ptrs, read_header, write_header, calculate_checksum)
2140 (copy_file, copy_rest, display_header): Likewise.
2141 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2143 * xdisp.c (check_it): Likewise.
2144 * xfaces.c (register_color, unregister_color, unregister_colors):
2146 * xfns.c (print_fontset_result): Likewise.
2147 * xrdb.c (member, fatal, main): Likewise.
2149 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2151 Fix minor problems found by static checking (Bug#9031).
2152 * chartab.c (char_table_set_range, map_sub_char_table):
2153 Remove unused locals.
2154 (uniprop_table): Now static.
2155 * composite.c (_work_char): Remove unused static var.
2157 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2159 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2161 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2163 * gtkutil.c (qttip_cb): Remove code without function.
2165 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2167 * w32.c (pthread_sigmask): New stub.
2169 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2171 Use pthread_sigmask, not sigprocmask (Bug#9010).
2172 sigprocmask is portable only for single-threaded applications, and
2173 Emacs can be multi-threaded when it uses GTK.
2174 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2176 * callproc.c (Fcall_process):
2177 * process.c (create_process):
2178 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2179 Use pthread_sigmask, not sigprocmask.
2181 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2183 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2184 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2187 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2189 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2190 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2191 (xg_hide_tooltip): Fix comment.
2193 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2194 in registerServicesMenuSendTypes.
2195 (validRequestorForSendType): Don't check ns_return_types.
2197 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2200 2011-07-08 Jason Rumney <jasonr@gnu.org>
2202 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2203 frame struct members of non-existent frames (Bug#6284).
2205 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2207 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2208 variable firstTime not needed on OSX >= 10.6.
2209 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2210 >= 10.5. Use setKnobProportion, setDoubleValue.
2212 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2213 (MAC_OS_X_VERSION_10_5): Define if not defined.
2214 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2215 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2216 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2218 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2219 cString and lossyCString on OSX >= 10.4
2221 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2222 sizeToFit on OSX >= 10.2.
2224 * nsimage.m (allocInitFromFile): Don't use deprecated method
2225 bestRepresentationForDevice on OSX >= 10.6.
2227 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2230 * emacs.c: Declare unexec_init_emacs_zone.
2232 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2234 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2236 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2237 on svcsMenu (Bug#8842).
2239 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2241 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2243 * nsterm.m (QUTF8_STRING): Declare.
2244 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2245 (validRequestorForSendType): Return type is (id).
2246 Change indexOfObjectIdenticalTo to indexOfObject.
2247 Check if we have local selection before returning self (Bug#8842).
2248 (writeSelectionToPasteboard): Put local selection into paste board
2249 if we have a local selection (Bug#8842).
2250 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2252 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2253 (ns_get_local_selection): Declare.
2255 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2257 * keymap.c (describe_map_tree): Don't insert a double newline at
2258 the end of the buffer (bug#1169) and return whether we inserted
2261 * callint.c (Fcall_interactively): Change "reading args" to
2262 "providing args" to try to clarify what it does (bug#1010).
2264 2011-07-07 Kenichi Handa <handa@m17n.org>
2266 * composite.c (composition_compute_stop_pos): Ignore a static
2267 composition starting before CHARPOS (Bug#8915).
2269 * xdisp.c (handle_composition_prop): Likewise.
2271 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2273 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2276 2011-07-07 Kenichi Handa <handa@m17n.org>
2278 * character.h (unicode_category_t): New enum type.
2280 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2281 (Qchar_code_property_table): New variable.
2282 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2283 (UNIPROP_COMPRESSED_FORM_P): New macros.
2284 (char_table_ascii): Uncompress the compressed values.
2285 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2286 Uncompress the compressed values.
2287 (sub_char_table_ref_and_range): Likewise.
2288 (char_table_ref_and_range): Uncompress the compressed values.
2289 (sub_char_table_set): New arg is_uniprop. Callers changed.
2290 Uncompress the compressed values.
2291 (sub_char_table_set_range): Args changed. Callers changed.
2292 (char_table_set_range): Adjuted for the above change.
2293 (map_sub_char_table): Delete args default_val and parent. Add arg
2294 top. Give decoded values to a Lisp function.
2295 (map_char_table): Adjust for the above change. Give decoded
2296 values to a Lisp function. Gcpro more variables.
2297 (uniprop_table_uncompress)
2298 (uniprop_decode_value_run_length): New functions.
2299 (uniprop_decoder, uniprop_decoder_count): New variables.
2300 (uniprop_get_decoder, uniprop_encode_value_character)
2301 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2303 (uniprop_encoder, uniprop_encoder_count): New variables.
2304 (uniprop_get_encoder, uniprop_table)
2305 (Funicode_property_table_internal, Fget_unicode_property_internal)
2306 (Fput_unicode_property_internal): New functions.
2307 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2308 Sunicode_property_table_internal, Sget_unicode_property_internal,
2309 and Sput_unicode_property_internal. Defvar_lisp
2310 char-code-property-alist.
2312 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2313 Vunicode_category_table.
2315 * font.c (font_range): Adjust for the change of
2316 Vunicode_category_table.
2318 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2320 * m/iris4d.h: Remove file, move contents ...
2321 * s/irix6-5.h: ... here.
2323 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2325 Remove unportable assumption about struct layout (Bug#8884).
2326 * alloc.c (mark_buffer):
2327 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2328 (clone_per_buffer_values): Don't assume that
2329 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2330 This isn't true in general, and it's particularly not true
2331 if Emacs is configured with --with-wide-int.
2332 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2333 New macros, used in the buffer.c change.
2335 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2337 * xsettings.c: Use both GConf and GSettings if both are available.
2338 (store_config_changed_event): Add comment.
2339 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2340 (store_tool_bar_style_changed): New functions.
2341 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2342 (struct xsettings): Move font inside HAVE_XFT.
2343 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2344 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2345 Move inside HAVE_XFT.
2346 (something_changed_gsettingsCB): Rename from something_changedCB.
2347 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2349 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2350 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2351 (something_changed_gconfCB): Rename from something_changedCB.
2352 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2353 (parse_settings): Move check for font inside HAVE_XFT.
2354 (read_settings, apply_xft_settings): Add comment.
2355 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2356 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2357 call store_font_name_changed.
2358 (xft_settings_event): Add comment.
2359 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2360 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2361 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2362 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2363 (xsettings_initialize): Call init_gsettings last.
2364 (xsettings_get_system_font, xsettings_get_system_normal_font):
2367 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2369 Random fixes. E.g., (random) never returned negative values.
2370 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2371 subseconds part to the entropy, as that's a bit more random.
2372 Prefer signed to unsigned, since the signedness doesn't matter and
2373 in general we prefer signed. When given a limit, use a
2374 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2375 latter isn't right if USE_2_TAGS_FOR_INTS.
2376 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2377 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2379 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2381 * textprop.c (text_property_stickiness):
2382 Obey Vtext_property_default_nonsticky.
2383 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2384 * w32fns.c (syms_of_w32fns):
2385 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2387 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2389 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2390 This is more efficient than Ffile_directory_p and avoids a minor race.
2392 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2394 * buffer.c (Foverlay_put): Say what the return value is
2397 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2398 is a directory before asking whether to use the file name
2400 (barf_or_query_if_file_exists): Make the "File is a directory"
2401 error be more correct.
2403 * fns.c (Frequire): Remove the mention of the .gz files, since
2404 that's installation-specific, but keep the mention of
2405 `get-load-suffixes'.
2407 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2409 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2410 Report string overflow if the output is too long.
2412 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2414 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2415 (syms_of_gnutls): Remove duplicate DEFSYM for
2416 Qgnutls_bootprop_verify_hostname_error, an error for
2417 Qgnutls_bootprop_verify_error (which is no longer used).
2419 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2420 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2421 Also (re)move comments that are misplaced or no longer relevant.
2423 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2425 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2427 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2429 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2430 and background color parameters if they have been changed.
2432 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2434 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2436 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2438 * xsettings.c (SYSTEM_FONT): Define only when used.
2439 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2441 * keymap.c (access_keymap_1): Now static.
2443 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2445 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2446 leave any prefix arg for the up event (Bug#1586).
2448 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2450 * lread.c (syms_of_lread): Mention single symbols defined by
2451 `defvar' or `defconst' (bug#7154).
2453 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2454 (Frequire): Mention get-load-suffixes.
2456 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2458 * window.h (window): Remove clone_number slot.
2459 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2461 (make_parent_window, make_window, saved_window)
2462 (Fset_window_configuration, save_window_save): Don't deal with
2464 * buffer.c (Qclone_number): Remove declaration.
2465 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2467 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2469 Add multiple inheritance to keymaps.
2470 * keymap.c (Fmake_composed_keymap): New function.
2471 (Fset_keymap_parent): Simplify.
2472 (fix_submap_inheritance): Remove.
2473 (access_keymap_1): New function extracted from access_keymap to handle
2474 embedded parents and handle lists of maps.
2475 (access_keymap): Use it.
2476 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2477 (Fcopy_keymap): Handle embedded parents.
2478 (Fcommand_remapping, define_as_prefix): Simplify.
2479 (Fkey_binding): Simplify.
2480 (syms_of_keymap): Move minibuffer-local-completion-map,
2481 minibuffer-local-filename-completion-map,
2482 minibuffer-local-must-match-map, and
2483 minibuffer-local-filename-must-match-map to Elisp.
2484 (syms_of_keymap): Defsubr make-composed-keymap.
2485 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2486 (parse_menu_item): Trivial simplification.
2488 2011-07-01 Glenn Morris <rgm@gnu.org>
2490 * Makefile.in (SETTINGS_LIBS): Fix typo.
2492 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2494 * coding.c (Fencode_coding_string): Record the last coding system
2495 used, as the function doc string says (bug#8738).
2497 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2499 * xsettings.c (store_monospaced_changed): Take new font as arg and
2500 check for change against current_mono_font.
2501 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2502 (emacs_settings_constructor, emacs_settings_get_property)
2503 (emacs_settings_set_property, emacs_settings_class_init)
2504 (emacs_settings_init, gsettings_obj): Remove.
2505 (something_changedCB): New function for HAVE_GSETTINGS.
2506 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2507 with value as argument.
2508 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2509 g_settings_new (Bug#8967). Do not create gsettings_obj.
2510 Remove calls to g_settings_bind. Connect something_changedCB to
2513 * xgselect.c: Add defined (HAVE_GSETTINGS).
2514 (xgselect_initialize): Ditto.
2516 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2517 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2520 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2522 * eval.c (struct backtrace): Simplify and port the data structure.
2523 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2524 signed bit field, as this assumption is not portable and it makes
2525 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2526 "char debug_on_exit : 1" as this is not portable either; instead,
2527 use the portable "unsigned int debug_on_exit : 1". Remove unused
2528 member evalargs. Remove obsolete comments about cc bombing out.
2530 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2532 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2533 Let HAVE_GSETTINGS override HAVE_GCONF.
2534 (store_monospaced_changed): New function.
2535 (EMACS_SETTINGS): A new type derived from GObject to handle
2536 GSettings notifications.
2537 (emacs_settings_constructor, emacs_settings_get_property)
2538 (emacs_settings_set_property, emacs_settings_class_init):
2540 (gsettings_client, gsettings_obj): New variables.
2541 (GSETTINGS_SCHEMA): New define.
2542 (something_changedCB): Call store_monospaced_changed.
2543 (init_gsettings): New function.
2544 (xsettings_initialize): Call init_gsettings.
2545 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2548 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2551 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2553 * window.c (resize_root_window, grow_mini_window)
2554 (shrink_mini_window): Rename Qresize_root_window to
2555 Qwindow_resize_root_window and Qresize_root_window_vertically to
2556 Qwindow_resize_root_window_vertically.
2558 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2560 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2562 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2564 * makefile.w32-in: Redesign dependencies so they reflect more
2565 clearly which files are directly included by each source file,
2566 and not through other includes.
2568 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2570 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2571 (sort_overlays, overlay_strings): When an overlay's clone number
2572 matches the window's clone number process the overlay even if
2573 the overlay's window property doesn't match the current window.
2575 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2576 (Fwindow_hchild): Rename to Fwindow_left_child.
2577 (Fwindow_next): Rename to Fwindow_next_sibling.
2578 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2579 (resize_window_check): Rename to window_resize_check.
2580 (resize_window_apply): Rename to window_resize_apply.
2581 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2582 (Fdelete_other_windows_internal, resize_frame_windows)
2583 (Fsplit_window_internal, Fdelete_window_internal)
2584 (grow_mini_window, shrink_mini_window)
2585 (Fresize_mini_window_internal): Fix callers accordingly.
2587 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2589 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2590 (emacs_fixed_set_min_size): Remove.
2591 (emacs_fixed_new): Take frame as argument.
2593 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2594 (_EmacsFixedPrivate): Remove minwidth/height.
2595 Add struct frame *f.
2596 (emacs_fixed_init): Initialize priv->f.
2597 (get_parent_class, emacs_fixed_set_min_size): Remove.
2598 (emacs_fixed_new): Set priv->f to argument.
2599 (emacs_fixed_get_preferred_width)
2600 (emacs_fixed_get_preferred_height): Use min_width/height from
2601 frames size_hint to set minimum and natural (Bug#8919).
2602 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2603 and use min_width/height from frames size_hint to set
2604 min_width/height (Bug#8919).
2606 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2607 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2610 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2612 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2613 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2616 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2618 * process.c (wait_reading_process_output): Bypass select if
2619 waiting for a cell while ignoring keyboard input, and input is
2620 pending. Suggested by Jan Djärv (Bug#8869).
2622 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2624 Use gnulib's dup2 module instead of rolling our own.
2625 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2627 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2629 * dispnew.c (scrolling_window): Before scrolling, turn off a
2630 mouse-highlight in the window being scrolled.
2632 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2634 Move DEFSYM to lisp.h and use everywhere.
2636 * character.h (DEFSYM): Move declaration...
2637 * lisp.h (DEFSYM): ...here.
2643 * w32select.c: Don't include character.h.
2645 * alloc.c (syms_of_alloc):
2646 * buffer.c (syms_of_buffer):
2647 * bytecode.c (syms_of_bytecode):
2648 * callint.c (syms_of_callint):
2649 * casefiddle.c (syms_of_casefiddle):
2650 * casetab.c (init_casetab_once):
2651 * category.c (init_category_once, syms_of_category):
2652 * ccl.c (syms_of_ccl):
2653 * cmds.c (syms_of_cmds):
2654 * composite.c (syms_of_composite):
2655 * dbusbind.c (syms_of_dbusbind):
2656 * dired.c (syms_of_dired):
2657 * dispnew.c (syms_of_display):
2658 * doc.c (syms_of_doc):
2659 * editfns.c (syms_of_editfns):
2660 * emacs.c (syms_of_emacs):
2661 * eval.c (syms_of_eval):
2662 * fileio.c (syms_of_fileio):
2663 * fns.c (syms_of_fns):
2664 * frame.c (syms_of_frame):
2665 * fringe.c (syms_of_fringe):
2666 * insdel.c (syms_of_insdel):
2667 * keymap.c (syms_of_keymap):
2668 * lread.c (init_obarray, syms_of_lread):
2669 * macros.c (syms_of_macros):
2670 * msdos.c (syms_of_msdos):
2671 * print.c (syms_of_print):
2672 * process.c (syms_of_process):
2673 * search.c (syms_of_search):
2674 * sound.c (syms_of_sound):
2675 * syntax.c (init_syntax_once, syms_of_syntax):
2676 * terminal.c (syms_of_terminal):
2677 * textprop.c (syms_of_textprop):
2678 * undo.c (syms_of_undo):
2679 * w32.c (globals_of_w32):
2680 * window.c (syms_of_window):
2681 * xdisp.c (syms_of_xdisp):
2682 * xfaces.c (syms_of_xfaces):
2683 * xfns.c (syms_of_xfns):
2684 * xmenu.c (syms_of_xmenu):
2685 * xsettings.c (syms_of_xsettings):
2686 * xterm.c (syms_of_xterm): Use DEFSYM.
2688 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2690 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2692 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2694 Integer and buffer overflow fixes (Bug#8873).
2696 * print.c (printchar, strout): Check for string overflow.
2697 (PRINTPREPARE, printchar, strout):
2698 Don't set size unless allocation succeeds.
2700 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2701 for sizes. Check for string overflow more accurately.
2702 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2704 * macros.c: Integer and buffer overflow fixes.
2705 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2706 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2707 Use ptrdiff_t, not int, for sizes.
2708 Don't increment bufsize until after realloc succeeds.
2709 Check for size-calculation overflow.
2710 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2712 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2714 * lread.c: Integer overflow fixes.
2715 (read_integer): Radix is now EMACS_INT, not int,
2716 to improve quality of diagnostics for out-of-range radices.
2717 Calculate buffer size correctly for out-of-range radices.
2718 (read1): Check for integer overflow in radices, and in
2719 read-circle numbers.
2720 (read_escape): Avoid int overflow.
2721 (Fload, openp, read_buffer_size, read1)
2722 (substitute_object_recurse, read_vector, read_list, map_obarray):
2723 Use ptrdiff_t, not int, for sizes.
2724 (read1): Use EMACS_INT, not int, for sizes.
2725 Check for size overflow.
2727 * image.c (cache_image): Check for size arithmetic overflow.
2729 * lread.c: Integer overflow issues.
2730 (saved_doc_string_size, saved_doc_string_length)
2731 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2732 Now ptrdiff_t, not int.
2733 (read1): Don't assume doc string length fits in int. Check for
2734 out-of-range doc string lengths.
2735 (read_list): Don't assume file position fits in int.
2736 (read_escape): Check for hex character overflow.
2738 2011-06-22 Leo Liu <sdl.web@gmail.com>
2740 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2741 Move to minibuffer.el.
2743 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2745 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2746 The following patches are for when GLYPH_DEBUG && !XASSERT.
2747 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2748 * dispnew.c (flush_stdout):
2749 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2750 Mark as externally visible.
2751 * dispnew.c (check_window_matrix_pointers): Now static.
2752 * dispnew.c (window_to_frame_vpos):
2753 * xfns.c (unwind_create_frame):
2754 * xterm.c (x_check_font): Remove unused local.
2755 * scroll.c (CHECK_BOUNDS):
2756 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2757 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2758 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2759 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2760 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2762 (debug_method_add): Use va_list and vsprintf rather than relying
2763 on undefined behavior with wrong number of arguments.
2764 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2765 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2766 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2767 since we're not interested in debugging glyphs with old libraries.
2768 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2769 GCC 4.6.0's static checking.
2771 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2773 Integer overflow and signedness fixes (Bug#8873).
2774 A few related buffer overrun fixes, too.
2776 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2778 * dispextern.h (struct face.stipple):
2779 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2780 (x_bitmap_mask, x_allocate_bitmap_record)
2781 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2782 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2783 (x_create_bitmap_from_xpm_data):
2784 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2785 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2787 * xfaces.c (load_pixmap):
2788 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2789 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2790 (.bitmaps_last, struct x_output.icon_bitmap):
2791 Use ptrdiff_t, not int, for bitmap indexes.
2792 (x_allocate_bitmap_record): Check for size overflow.
2793 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2795 Use ptrdiff_t, not int, for overlay counts.
2796 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2797 * editfns.c (overlays_around, get_pos_property):
2798 * textprop.c (get_char_property_and_overlay):
2799 * xdisp.c (next_overlay_change, note_mouse_highlight):
2800 * xfaces.c (face_at_buffer_position):
2801 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2802 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2803 (Fnext_overlay_change, Fprevious_overlay_change)
2804 (mouse_face_overlay_overlaps, Foverlays_in):
2805 Use ptrdiff_t, not int, for sizes.
2806 (overlays_at, overlays_in): Check for size-calculation overflow.
2808 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2810 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2811 (x_session_initialize): Do not assume string length fits in int.
2813 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2814 This is unlikely, but can occur if DPI is outlandish.
2816 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2817 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2819 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2820 * xrdb.c (magic_file_p, search_magic_path):
2821 Omit last arg SUFFIX; it was always 0. All callers changed.
2822 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2824 * xfont.c (xfont_match): Avoid need for strlen.
2826 * xfns.c: Don't assume strlen fits in int.
2827 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2829 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2830 not unsigned long, as we prefer signed integers. All callers changed.
2831 Detect integer overflow in repeat count.
2832 (message_dolog): Don't assume print length fits in 39 bytes.
2833 (display_mode_element): Don't assume strlen fits in int.
2835 * termcap.c: Don't assume sizes fit in int and never overflow.
2836 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2837 (gobble_line): Check for size-calculation overflow.
2839 * minibuf.c (Fread_buffer):
2840 * lread.c (intern, intern_c_string):
2841 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2842 Don't assume string length fits in int.
2844 * keyboard.c (parse_tool_bar_item):
2845 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2847 * font.c: Don't assume string length fits in int.
2848 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2849 Use ptrdiff_t, not int.
2850 (font_intern_prop): Don't assume string length fits in int.
2851 Don't assume integer property fits in fixnum.
2852 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2854 * filelock.c: Fix some buffer overrun and integer overflow issues.
2855 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2856 Reformulate so as not to need the command string.
2857 Invoke gzip -cd rather than gunzip, as it's more portable.
2858 (lock_info_type, lock_file_1, lock_file):
2859 Don't assume pid_t and time_t fit in unsigned long.
2860 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2861 (current_lock_owner): Prefer signed type for sizes.
2862 Use memcpy, not strncpy, where memcpy is what is really wanted.
2863 Don't assume (via atoi) that time_t and pid_t fit in int.
2864 Check for time_t and/or pid_t out of range, e.g., via a network share.
2865 Don't alloca where an auto var works fine.
2867 * fileio.c: Fix some integer overflow issues.
2868 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2869 Don't assume string length fits in int.
2870 (directory_file_name): Don't assume string length fits in long.
2871 (make_temp_name): Don't assume pid fits in int, or that its print
2872 length is less than 20.
2874 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2876 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2878 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2880 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2881 We prefer signed integers, even for size calculations.
2883 * emacs.c: Don't assume string length fits in 'int'.
2884 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2885 (main): Don't invoke strlen when not needed.
2887 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2888 (XD_DEBUG_MESSAGE): Don't waste a byte.
2890 * callproc.c (getenv_internal_1, getenv_internal)
2892 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2894 * lread.c (invalid_syntax): Omit length argument.
2895 All uses changed. This doesn't fix a bug, but it simplifies the
2896 code away from its former Hollerith-constant appearance, and it's
2897 one less 'int' to worry about when looking at integer-overflow issues.
2898 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2900 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2901 This didn't break anything, but it didn't help either.
2902 It's confusing to put a bogus integer in a place where the actual
2903 value does not matter.
2904 (LIST_END_P): Remove unused macro and its bogus comment.
2905 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2907 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2908 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2910 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2911 We prefer signed types, and the value cannot exceed the EMACS_INT
2912 range anyway (because otherwise the length would not be representable).
2913 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2914 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2915 This avoids a GCC warning when WIDE_EMACS_INT.
2917 * indent.c (sane_tab_width): New function.
2918 (current_column, scan_for_column, Findent_to, position_indentation)
2919 (compute_motion): Use it. This is just for clarity.
2920 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2922 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2924 * lisp.h (lint_assume): New macro.
2925 * composite.c (composition_gstring_put_cache):
2926 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2928 * editfns.c, insdel.c:
2929 Omit unnecessary forward decls, to simplify future changes.
2931 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2933 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2935 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2936 Use much-faster test for byte-length change.
2937 Don't assume string byte-length fits in 'int'.
2938 Check that character arg fits in 'int'.
2939 (mapcar1): Declare byte as byte, for clarity.
2941 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2943 * fns.c (concat): Catch string overflow earlier.
2944 Do not rely on integer wraparound.
2946 * dispextern.h (struct it.overlay_strings_charpos)
2947 (struct it.selective): Now EMACS_INT, not int.
2948 * xdisp.c (forward_to_next_line_start)
2949 (back_to_previous_visible_line_start)
2950 (reseat_at_next_visible_line_start, next_element_from_buffer):
2951 Don't arbitrarily truncate the value of 'selective' to int.
2953 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2955 * composite.c: Don't truncate sizes to 'int'.
2956 (composition_gstring_p, composition_reseat_it)
2957 (composition_adjust_point): Use EMACS_INT, not int.
2958 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2959 not EMACS_UINT, for indexes.
2961 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2963 * buffer.c: Include <verify.h>.
2964 (struct sortvec.priority, struct sortstr.priority):
2965 Now EMACS_INT, not int.
2966 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2967 (struct sortstr.size, record_overlay_string)
2968 (struct sortstrlist.size, struct sortlist.used):
2969 Don't truncate size to int.
2970 (record_overlay_string): Check for size-calculation overflow.
2971 (init_buffer_once): Check at compile-time, not run-time.
2973 2011-06-22 Jim Meyering <meyering@redhat.com>
2975 Don't leak an XBM-image-sized buffer
2976 * image.c (xbm_load): Free the image buffer after using it.
2978 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2981 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2982 that Sun C diagnosed.
2983 * fns.c (secure_hash): Fix pointer signedness issue.
2984 * intervals.c (static_offset_intervals): New function.
2985 (offset_intervals): Use it.
2987 2011-06-21 Leo Liu <sdl.web@gmail.com>
2990 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2993 * fns.c (secure_hash): Rename from crypto_hash_function and change
2994 the first arg to accept symbols.
2995 (Fsecure_hash): New primitive.
2996 (syms_of_fns): New symbols.
2998 2011-06-20 Deniz Dogan <deniz@dogan.se>
3000 * process.c (Fset_process_buffer): Clarify return value in
3003 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3005 * dispnew.c (add_window_display_history): Use BVAR.
3007 * xdisp.c (debug_method_add): Use BVAR.
3008 (check_window_end, dump_glyph_matrix, dump_glyph)
3009 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3011 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3014 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3015 check till after the cache is created in init_frame_faces.
3017 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3019 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3021 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3023 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3024 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3025 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3027 Improve buffer-overflow checking (Bug#8873).
3028 * fileio.c (Finsert_file_contents):
3029 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3030 Remove the old (too-loose) buffer overflow checks.
3031 They weren't needed, since make_gap checks for buffer overflow.
3032 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3033 The old code merely checked for Emacs fixnum overflow, and relied
3034 on undefined (wraparound) behavior. The new code avoids undefined
3035 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3037 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3038 Tune. Don't use wider integers than needed. Don't use alloca.
3039 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3041 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3043 * insdel.c, lisp.h (buffer_overflow): New function.
3044 (insert_from_buffer_1, replace_range, replace_range_2):
3045 * insdel.c (make_gap_larger):
3046 * editfns.c (Finsert_char):
3047 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3049 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3051 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3053 Integer overflow and signedness fixes (Bug#8873).
3055 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3056 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3058 * fileio.c: Don't assume EMACS_INT fits in off_t.
3059 (emacs_lseek): New static function.
3060 (Finsert_file_contents, Fwrite_region): Use it.
3061 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3063 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3065 * fns.c: Don't overflow int when computing a list length.
3066 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3067 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3068 truncation on 64-bit hosts. Check for QUIT every
3069 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3070 faster and is responsive enough.
3071 (Flength): Report an error instead of overflowing an integer.
3072 (Fsafe_length): Return a float if the value is not representable
3073 as a fixnum. This shouldn't happen except in contrived situations.
3074 (Fnthcdr, Fsort): Don't assume list length fits in int.
3075 (Fcopy_sequence): Don't assume vector length fits in int.
3077 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3078 (header_size, word_size): New constants.
3079 (allocate_vectorlike): Don't check size overflow here.
3080 (allocate_vector): Check it here instead, since this is the only
3081 caller of allocate_vectorlike that could cause overflow.
3082 Check that the new vector's length is representable as a fixnum.
3084 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3085 The previous code was bogus. For example, next_almost_prime (32)
3086 returned 39, which is undesirable as it is a multiple of 3; and
3087 next_almost_prime (24) returned 25, which is a multiple of 5 so
3088 why was the code bothering to check for multiples of 7?
3090 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3092 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3094 Variadic C functions now count arguments with ptrdiff_t.
3095 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3096 Back then I didn't know that the Emacs coding style prefers signed int.
3097 Also, in the meantime I found a few more instances where arguments
3098 were being counted with int, which may truncate counts on 64-bit
3099 machines, or EMACS_INT, which may be unnecessarily wide.
3100 * lisp.h (struct Lisp_Subr.function.aMANY)
3101 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3102 Arg counts are now ptrdiff_t, not size_t.
3103 All variadic functions and their callers changed accordingly.
3104 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3105 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3106 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3107 * callint.c (Fcall_interactively): Check arg count for overflow,
3108 to avoid potential buffer overrun. Use signed char, not 'int',
3109 for 'varies' array, so that we needn't bother to check its size
3110 calculation for overflow.
3111 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3112 * eval.c (apply_lambda):
3113 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3114 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3115 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3117 * callint.c (Fcall_interactively): Don't use index var as event count.
3119 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3120 * mem-limits.h (SIZE): Remove; no longer used.
3122 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3124 Remove unnecessary casts.
3125 * xterm.c (x_term_init):
3126 * xfns.c (x_set_border_pixel):
3127 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3128 These aren't needed now that we assume ANSI C.
3130 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3131 It's more likely to cause problems (due to unsigned overflow)
3134 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3136 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3138 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3140 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3142 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3144 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3146 GLYPH_CODE_FACE returns EMACS_INT, not int.
3147 * dispextern.h (merge_faces):
3148 * xfaces.c (merge_faces):
3149 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3150 Don't assume EMACS_INT fits in int.
3152 * character.h (CHAR_VALID_P): Remove unused parameter.
3153 * fontset.c, lisp.h, xdisp.c: All uses changed.
3155 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3157 * fns.c (concat): Minor tuning based on overflow analysis.
3158 This doesn't fix any bugs. Use int to hold character, instead
3159 of constantly refetching from Emacs object. Use XFASTINT, not
3160 XINT, for value known to be a character. Don't bother comparing
3161 a single byte to 0400, as it's always less.
3163 * floatfns.c (Fexpt):
3164 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3166 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3169 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3171 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3172 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3173 incorrectly succeed when S was a string, because 4294967386 was
3174 truncated before it was used.
3176 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3177 Otherwise, an out-of-range integer could cause undefined behavior
3180 * composite.c: Use int, not EMACS_INT, for characters.
3181 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3182 EMACS_INT, for values that are known to be in character range.
3183 This doesn't fix any bugs but is the usual style inside Emacs and
3184 may generate better code on 32-bit machines.
3186 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3187 This is for reasons similar to the recent CHAR_STRING fix.
3188 * charset.c (Fencode_char): Check that character arg is actually
3189 a character. Pass an int to ENCODE_CHAR.
3190 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3191 wider than 'int', as a compile-time check to prevent future regressions
3194 * character.c (char_string): Remove unnecessary casts.
3196 Make sure a 64-bit char is never passed to CHAR_STRING.
3197 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3198 by silently ignoring the top 32 bits, allowing some values
3199 that were far too large to be valid characters.
3200 * character.h: Include <verify.h>.
3201 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3202 arguments are no wider than unsigned, as a compile-time check
3203 to prevent future regressions in this area.
3205 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3206 (Fsubst_char_in_region):
3208 * xdisp.c (decode_mode_spec_coding):
3209 Adjust to CHAR_STRING's new requirement.
3210 * editfns.c (Finsert_char, Fsubst_char_in_region):
3211 * fns.c (concat): Check that character args are actually
3212 characters. Without this test, these functions did the wrong
3213 thing with wildly out-of-range values on 64-bit hosts.
3215 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3216 These casts should not be needed on 32-bit hosts, either.
3217 * keyboard.c (read_char):
3218 * lread.c (Fload): Remove casts to unsigned.
3220 * lisp.h (UNSIGNED_CMP): New macro.
3221 This fixes comparison bugs on 64-bit hosts.
3222 (ASCII_CHAR_P): Use it.
3223 * casefiddle.c (casify_object):
3224 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3225 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3226 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3227 * dispextern.h (FACE_FROM_ID):
3228 * keyboard.c (read_char): Use UNSIGNED_CMP.
3230 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3231 not to EMACS_INT, to avoid GCC warning.
3233 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3235 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3236 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3237 isn't needed on 32-bit machines.
3239 * buffer.c (Fgenerate_new_buffer_name):
3240 Use EMACS_INT for count, not int.
3241 (advance_to_char_boundary): Return EMACS_INT, not int.
3243 * data.c (Qcompiled_function): Now static.
3245 * window.c (window_body_lines): Now static.
3247 * image.c (gif_load): Rename local to avoid shadowing.
3249 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3250 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3251 * alloc.c (make_save_value): Integer argument is now of type
3253 (mark_object): Use ptrdiff_t, not int.
3254 * lisp.h (pD): New macro.
3255 * print.c (print_object): Use it.
3257 * alloc.c: Use EMACS_INT, not int, to count objects.
3258 (total_conses, total_markers, total_symbols, total_vector_size)
3259 (total_free_conses, total_free_markers, total_free_symbols)
3260 (total_free_floats, total_floats, total_free_intervals)
3261 (total_intervals, total_strings, total_free_strings):
3262 Now EMACS_INT, not int. All uses changed.
3263 (Fgarbage_collect): Compute overall total using a double, so that
3264 integer overflow is less likely to be a problem. Check for overflow
3265 when converting back to an integer.
3266 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3267 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3268 These were 'int' variables that could overflow on 64-bit hosts;
3269 they were never used, so remove them instead of repairing them.
3270 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3271 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3272 Previously, this ceilinged at INT_MAX, but that doesn't work on
3274 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3276 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3277 (allocate_vectorlike): Check for ptrdiff_t overflow.
3278 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3279 when a (possibly-narrower) signed value would do just as well.
3280 We prefer using signed arithmetic, to avoid comparison confusion.
3282 * alloc.c: Catch some string size overflows that we were missing.
3283 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3284 for convenience in STRING_BYTES_MAX.
3285 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3286 The definition here is exact; the one in lisp.h was approximate.
3287 (allocate_string_data): Check for string overflow. This catches
3288 some instances we weren't catching before. Also, it catches
3289 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3290 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3291 and ptrdiff_t and EMACS_INT are both 64 bits.
3293 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3294 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3295 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3297 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3299 * alloc.c (Fmake_string): Check for out-of-range init.
3301 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3303 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3305 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3307 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3308 xg_get_default_scrollbar_width.
3310 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3311 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3312 (style_changed_cb): Call update_theme_scrollbar_width and call
3313 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3314 all frames (Bug#8505).
3315 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3316 Call gtk_window_set_resizable if HAVE_GTK3.
3317 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3318 and height if HAVE_GTK3 (Bug#8505).
3319 (scroll_bar_width_for_theme): New variable.
3320 (update_theme_scrollbar_width): New function.
3321 (xg_get_default_scrollbar_width): Move code to
3322 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3323 (xg_initialize): Call update_theme_scrollbar_width.
3325 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3327 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3329 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3331 * frame.c (make_frame): Call other_buffer_safely instead of
3334 * window.c (temp_output_buffer_show): Call display_buffer with
3335 second argument Vtemp_buffer_show_specifiers and reset latter
3336 immediately after the call.
3337 (Vtemp_buffer_show_specifiers): New variable.
3338 (auto_window_vscroll_p, next_screen_context_lines)
3339 (Vscroll_preserve_screen_position): Remove leading asterisks from
3342 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3344 Fix minor problems found by GCC 4.6.0 static checking.
3345 * buffer.c (Qclone_number): Remove for now, as it's unused.
3346 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3347 (record_buffer): Remove unused local.
3348 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3349 (set_frame_buffer_list): Remove; unused.
3350 * frame.h (other_visible_frames): Remove decl.
3351 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3352 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3353 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3355 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3356 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3357 Define only if HAVE_GPM.
3358 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3359 (update_hints_inhibit): Remove; never set. All uses removed.
3360 * widgetprv.h (emacsFrameClassRec): Remove decl.
3361 * window.c (delete_deletable_window): Now returns void, since it
3362 wasn't returning anything.
3363 (compare_window_configurations): Remove unused locals.
3364 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3365 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3366 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3367 the same widths as pointers. This follows up on the 2011-05-06 patch.
3368 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3369 * xterm.h: Likewise.
3370 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3372 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3374 * makefile.w32-in: Update dependencies.
3375 (LISP_H): Add lib/intprops.h.
3377 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3379 * image.c (gif_load): Add animation frame delay to the metadata.
3380 (syms_of_image): Use DEFSYM. New symbol `delay'.
3382 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3384 * window.c (delete_deletable_window): Re-add.
3385 (Fset_window_configuration): Rewrite to handle dead buffers and
3386 consequently deletable windows.
3387 (window_tree, Fwindow_tree): Remove. Supply functionality in
3389 (compare_window_configurations): Simplify code.
3391 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3393 * image.c (imagemagick_load_image): Fix type mismatch.
3394 (Fimagemagick_types): Likewise.
3396 * window.h (replace_buffer_in_windows): Declare.
3398 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3400 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3401 Qclone_number. Remove external declaration of Qdelete_window.
3402 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3404 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3405 Run Qbuffer_list_update_hook if allowed.
3406 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3407 buffer list implementation.
3408 (other_buffer_safely): New function.
3409 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3410 calls to replace_buffer_in_windows and
3411 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3413 (record_buffer): Inhibit quitting and rewrite using quittable
3414 functions. Run Qbuffer_list_update_hook if allowed.
3415 (Frecord_buffer, Funrecord_buffer): New functions.
3416 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3417 Move switch-to-buffer to window.el.
3418 (bury-buffer): Move to window.el.
3419 (Vbuffer_list_update_hook): New variable.
3421 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3424 * window.h (resize_frame_windows): Move up in code.
3425 (Fwindow_frame): Remove EXFUN.
3426 (replace_buffer_in_all_windows): Remove prototype.
3427 (replace_buffer_in_windows_safely): Add prototype.
3429 * window.c: Declare Qdelete_window static again. Move down
3430 declaration of select_count.
3431 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3432 (Fother_window): Move to window.el.
3433 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3434 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3435 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3437 (replace_buffer_in_windows): Implement by calling
3438 Qreplace_buffer_in_windows.
3439 (replace_buffer_in_all_windows): Remove with some functionality
3440 moved into replace_buffer_in_windows_safely.
3441 (replace_buffer_in_windows_safely): New function.
3442 (select_window_norecord, select_frame_norecord): Move in front
3443 of run_window_configuration_change_hook. Remove now obsolete
3445 (Fset_window_buffer): Rewrite doc-string.
3446 Call Qrecord_window_buffer.
3447 (keys_of_window): Move binding for other-window to window.el.
3449 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3451 * dispextern.h (struct image): Replace data member, whose int_val
3452 and ptr_val fields were not used by anything, with a single
3455 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3456 (gif_clear_image, gif_load, imagemagick_load_image)
3457 (gs_clear_image, gs_load): Callers changed.
3459 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3461 * buffer.h: Include <time.h>, for time_t.
3462 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3464 Fix minor problems found by static checking.
3466 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3468 Make identifiers static if they are not used in other modules.
3469 * data.c (Qcompiled_function, Qframe, Qvector):
3470 * image.c (QimageMagick, Qsvg):
3471 * minibuf.c (Qmetadata):
3472 * window.c (resize_window_check, resize_root_window): Now static.
3473 * window.h (resize_window_check, resize_root_window): Remove decls.
3475 * window.c (window_deletion_count, delete_deletable_window):
3477 (window_body_lines): Now static.
3478 (Fdelete_other_windows_internal): Mark vars as initialized.
3479 Make sure 'resize_failed' is initialized.
3480 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3481 (resize_window_apply): Remove unused local.
3482 * window.h (delete_deletable_window): Remove decl.
3484 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3485 (imagemagick_load_image): Fix pointer signedness problem by changing
3486 last arg from unsigned char * to char *. All uses changed.
3487 Also, fix a local for similar reasons.
3488 Remove unused locals. Remove locals to avoid shadowing.
3489 (fn_rsvg_handle_free): Remove; unused.
3490 (svg_load, svg_load_image): Fix pointer signedness problem.
3491 (imagemagick_load_image): Don't use garbage pointer image_wand.
3493 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3495 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3497 * image.c (gif_load): Fix omitted cast error introduced by
3500 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3502 * window.h (resize_proportionally, orig_total_lines)
3503 (orig_top_line): Remove from window structure.
3504 (set_window_height, set_window_width, change_window_heights)
3505 (Fdelete_window): Remove prototypes.
3506 (resize_frame_windows): Remove duplicate declaration.
3508 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3510 * window.h (resize_frame_windows, resize_window_check)
3511 (delete_deletable_window, resize_root_window)
3512 (resize_frame_windows): Declare prototypes.
3514 * window.c (resize_window_apply): Make definition be "static" to
3515 match the prototype.
3517 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3519 * window.c: Remove declarations of Qwindow_size_fixed,
3520 window_min_size_1, window_min_size_2, window_min_size,
3521 size_window, window_fixed_size_p, enlarge_window, delete_window.
3522 Remove static from declaration of Qdelete_window, it's
3523 temporarily needed by Fbury_buffer.
3524 (replace_window): Don't assign orig_top_line and
3526 (Fdelete_window, delete_window): Remove. Window deletion is
3527 handled by window.el.
3528 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3529 Replace Fdelete_window calls with calls to Qdelete_window.
3530 (Fdelete_other_windows): Remove. Deleting other windows is
3531 handled by window.el.
3532 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3533 handled in window.el.
3534 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3535 Window minimum sizes are handled in window.el.
3536 (shrink_windows, size_window, set_window_height)
3537 (set_window_width, change_window_heights, window_height)
3538 (window_width, CURBEG, CURSIZE, enlarge_window)
3539 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3540 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3541 handled in window.el.
3542 (make_dummy_parent): Rename to make_parent_window and give it a
3543 second argument horflag.
3544 (make_window): Don't set resize_proportionally any more.
3545 (Fsplit_window): Remove. Windows are split in window.el.
3546 (save_restore_action, save_restore_orig_size)
3547 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3548 Resize mini windows in window.el.
3549 (grow_mini_window, shrink_mini_window): Implement by calling
3550 Qresize_root_window_vertically, resize_window_check and
3551 resize_window_apply.
3552 (saved_window, Fset_window_configuration, save_window_save):
3553 Do not handle orig_top_line, orig_total_lines, and
3554 resize_proportionally.
3555 (window_min_height, window_min_width): Move to window.el.
3556 (keys_of_window): Move bindings for delete-other-windows,
3557 split-window, delete-window and enlarge-window to window.el.
3559 * buffer.c: Temporarily extern Qdelete_window.
3560 (Fbury_buffer): Temporarily call Qdelete_window instead of
3561 Fdelete_window (Fbury_buffer will move to window.el soon).
3563 * frame.c (set_menu_bar_lines_1): Remove code handling
3564 orig_top_line and orig_total_lines.
3566 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3567 set_window_height but set heights directly.
3568 (change_frame_size_1): Use resize_frame_windows.
3570 * xdisp.c (init_xdisp): Don't use set_window_height but set
3573 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3574 Use resize_frame_windows instead of change_window_heights and run
3575 run_window_configuration_change_hook.
3577 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3578 instead of change_window_heights and run
3579 run_window_configuration_change_hook.
3581 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3583 * window.c (replace_window): Rename second argument REPLACEMENT to
3584 NEW. New third argument SETFLAG. Rewrite.
3585 (delete_window, make_dummy_parent): Call replace_window with
3587 (window_list_1): Move down in code.
3588 (run_window_configuration_change_hook): Move set_buffer part
3589 before select_frame_norecord part in order to unwind correctly.
3590 Rename count1 to count.
3591 (recombine_windows, delete_deletable_window, resize_root_window)
3592 (Fdelete_other_windows_internal)
3593 (Frun_window_configuration_change_hook, make_parent_window)
3594 (resize_window_check, resize_window_apply, Fresize_window_apply)
3595 (resize_frame_windows, Fsplit_window_internal)
3596 (Fdelete_window_internal, Fresize_mini_window_internal):
3598 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3600 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3602 * window.h (window): Add some new members to window structure -
3603 normal_lines, normal_cols, new_total, new_normal, clone_number,
3604 splits, nest, prev_buffers, next_buffers.
3605 (WINDOW_TOTAL_SIZE): Move here from window.c.
3606 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3608 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3610 (make_dummy_parent): Set new members of windows structure.
3611 (make_window): Move down in code. Handle new members of window
3613 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3614 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3615 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3616 (Fset_window_prev_buffers, Fwindow_next_buffers)
3617 (Fset_window_next_buffers, Fset_window_clone_number):
3619 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3620 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3622 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3623 Argument WINDOW can be now internal window too.
3624 (Fwindow_use_time): Move up in code.
3625 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3627 (Fset_window_configuration, saved_window)
3628 (Fcurrent_window_configuration, save_window_save): Handle new
3629 members of window structure.
3630 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3631 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3632 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3633 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3634 Qget_mru_window, Qresize_root_window,
3635 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3636 Qauto_buffer_name; staticpro them.
3638 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3640 * window.c (Fwindow_total_size, Fwindow_left_column)
3641 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3642 (Fwindow_list_1): New functions.
3643 (window_box_text_cols): Replace with window_body_cols.
3644 (Fwindow_width, Fscroll_left, Fscroll_right):
3645 Use window_body_cols instead of window_box_text_cols.
3646 (delete_window, Fset_window_configuration):
3647 Call delete_all_subwindows with window as argument.
3648 (delete_all_subwindows): Take a window as argument and not a
3650 (window_loop): Remove handling of GET_LRU_WINDOW and
3652 (Fget_lru_window, Fget_largest_window): Move to window.el.
3654 * window.h: Extern window_body_cols instead of
3655 window_box_text_cols. delete_all_subwindows now takes a
3656 Lisp_Object as argument.
3658 * indent.c (compute_motion, Fcompute_motion):
3659 Use window_body_cols instead of window_box_text_cols.
3661 * frame.c (delete_frame): Call delete_all_subwindows with root
3664 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3666 * fns.c (Fputhash): Document return value.
3668 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3670 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3672 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3674 Cons<->int and similar integer overflow fixes (Bug#8794).
3676 Check for overflow when converting integer to cons and back.
3677 * charset.c (Fdefine_charset_internal, Fdecode_char):
3678 Use cons_to_unsigned to catch overflow.
3679 (Fencode_char): Use INTEGER_TO_CONS.
3680 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3681 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3682 * data.c (long_to_cons, cons_to_long): Remove.
3683 (cons_to_unsigned, cons_to_signed): New functions.
3684 These signal an error for invalid or out-of-range values.
3685 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3686 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3687 * font.c (Ffont_variation_glyphs):
3688 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3689 * lisp.h: Include <intprops.h>.
3690 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3691 (cons_to_signed, cons_to_unsigned): New decls.
3692 (long_to_cons, cons_to_long): Remove decls.
3693 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3694 (Fprimitive_undo): Use CONS_TO_INTEGER.
3695 * xfns.c (Fx_window_property): Likewise.
3696 * xselect.c: Include <limits.h>.
3697 (x_own_selection, selection_data_to_lisp_data):
3698 Use INTEGER_TO_CONS.
3699 (x_handle_selection_request, x_handle_selection_clear)
3700 (x_get_foreign_selection, Fx_disown_selection_internal)
3701 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3702 (lisp_data_to_selection_data): Use cons_to_unsigned.
3703 (x_fill_property_data): Use cons_to_signed.
3704 Report values out of range.
3706 Check for buffer and string overflow more precisely.
3707 * buffer.h (BUF_BYTES_MAX): New macro.
3708 * lisp.h (STRING_BYTES_MAX): New macro.
3709 * alloc.c (Fmake_string):
3710 * character.c (string_escape_byte8):
3711 * coding.c (coding_alloc_by_realloc):
3712 * doprnt.c (doprnt):
3713 * editfns.c (Fformat):
3715 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3716 since they may not be the same number.
3717 * editfns.c (Finsert_char):
3718 * fileio.c (Finsert_file_contents):
3719 Likewise for BUF_BYTES_MAX.
3721 * image.c: Use ptrdiff_t, not int, for sizes.
3722 (slurp_file): Switch from int to ptrdiff_t.
3724 (slurp_file): Check that file size fits in both size_t (for
3725 malloc) and ptrdiff_t (for sanity and safety).
3727 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3728 if b->modtime has its maximal value.
3730 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3732 Don't assume time_t can fit into int.
3733 * buffer.h (struct buffer.modtime): Now time_t, not int.
3734 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3735 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3737 Minor fixes for signed vs unsigned integers.
3738 * character.h (MAYBE_UNIFY_CHAR):
3739 * charset.c (maybe_unify_char):
3740 * keyboard.c (read_char, reorder_modifiers):
3741 XINT -> XFASTINT, since the integer must be nonnegative.
3742 * ftfont.c (ftfont_spec_pattern):
3743 * keymap.c (access_keymap, silly_event_symbol_error):
3744 XUINT -> XFASTINT, since the integer must be nonnegative.
3745 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3746 since it makes no difference and we prefer signed.
3747 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3748 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3751 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3753 * window.h (Fwindow_frame): Declare.
3755 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3757 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3758 (SPARE_MEMORY): Always define.
3759 (LARGE_REQUEST): Remove.
3760 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3762 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3764 * lisp.h: Move EXFUNS for Fframe_root_window,
3765 Fframe_first_window and Fset_frame_selected_window to window.h.
3767 * window.h: Move EXFUNS for Fframe_root_window,
3768 Fframe_first_window and Fset_frame_selected_window here from
3771 * frame.c (Fwindow_frame, Fframe_first_window)
3772 (Fframe_root_window, Fframe_selected_window)
3773 (Fset_frame_selected_window): Move to window.c.
3774 (Factive_minibuffer_window): Move to minibuf.c.
3775 (Fother_visible_frames_p): New function.
3777 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3779 * window.c (decode_window, decode_any_window): Move up in code.
3780 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3781 (inhibit_frame_unsplittable): Remove unused variable.
3782 (Fwindow_buffer): Move up and rewrite doc-string.
3783 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3784 (Fwindow_prev): New functions.
3785 (Fwindow_frame): Move here from frame.c. Accept any window as
3787 (Fframe_root_window, Fframe_first_window)
3788 (Fframe_selected_window): Move here from frame.c. Accept frame
3789 or arbitrary window as argument. Update doc-strings.
3790 (Fminibuffer_window): Move up in code.
3791 (Fwindow_minibuffer_p): Move up in code and simplify.
3792 (Fset_frame_selected_window): Move here from frame.c.
3794 (Fselected_window, select_window, Fselect_window): Move up in
3795 code. Minor doc-string fixes.
3797 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3799 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3800 Do not assume that spare memory exists; that assumption is valid
3801 only if SYSTEM_MALLOC.
3802 (LARGE_REQUEST): New macro, so that the issue of large requests
3803 is separated from the issue of spare memory.
3805 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3807 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3810 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3812 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3815 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3817 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3819 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3821 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3822 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3824 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3826 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3828 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3830 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3831 (x_clipboard_manager_save): Add return value.
3832 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3834 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3835 Obey Vx_select_enable_clipboard_manager. Catch errors in
3836 x_clipboard_manager_save (Bug#8779).
3837 (Vx_select_enable_clipboard_manager): New variable.
3838 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3840 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3842 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3844 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3846 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3847 in the current matrix if keep_current_p is non-zero.
3849 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3851 * bidi.c (bidi_level_of_next_char): Fix last change.
3853 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3855 Support bidi reordering of text covered by display properties.
3857 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3858 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3859 (bidi_cache_search, bidi_cache_iterator_state)
3860 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3861 (bidi_level_of_next_char, bidi_move_to_visually_next):
3862 Support character positions inside a run of characters covered by a
3864 (bidi_paragraph_init, bidi_resolve_explicit_1)
3865 (bidi_level_of_next_char): Call bidi_fetch_char and
3866 bidi_fetch_char_advance instead of FETCH_CHAR and
3868 (bidi_init_it): Initialize new members.
3869 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3871 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3872 instead of using explicit *_CHAR codes.
3873 (bidi_resolve_explicit, bidi_resolve_weak):
3874 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3875 bidirectional text is supported only in multibyte buffers.
3876 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3877 it to initialize the frame_window_p member of struct bidi_it.
3878 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3879 (bidi_resolve_explicit, bidi_resolve_weak)
3880 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3881 bidi_it->nchars is non-positive.
3882 (bidi_level_of_next_char): Don't try to lookup the cache for the
3883 next/previous character if nothing is cached there yet, or if we
3884 were just reseat()'ed to a new position.
3886 * xdisp.c (set_cursor_from_row): Set start and stop points
3887 according to the row's direction when priming the loop that looks
3888 for the glyph on which to display cursor.
3889 (single_display_spec_intangible_p): Function deleted.
3890 (display_prop_intangible_p): Reimplement to call
3891 handle_display_spec instead of single_display_spec_intangible_p.
3892 Accept 3 additional arguments needed by handle_display_spec.
3893 This fixes incorrect cursor motion across display property with complex
3894 values: lists, `(when COND...)' forms, etc.
3895 (single_display_spec_string_p): Support property values that are
3896 lists with the argument STRING its top-level element.
3897 (display_prop_string_p): Fix the condition for processing a
3898 property that is a list to be consistent with handle_display_spec.
3899 (handle_display_spec): New function, refactored from the
3900 last portion of handle_display_prop.
3901 (compute_display_string_pos): Accept additional argument
3902 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3903 value of a `display' property is a "replacing spec".
3904 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3905 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3906 the display property, but just return a value indicating whether
3907 the display property will replace the characters it covers.
3908 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3909 frame_window_p members of struct bidi_it.
3910 (compute_display_string_pos, compute_display_string_end):
3912 (push_it): Accept second argument POSITION, where pop_it should
3913 jump to continue iteration.
3914 (reseat_1): Initialize bidi_it.disp_pos.
3916 * keyboard.c (adjust_point_for_property): Adjust the call to
3917 display_prop_intangible_p to its new signature.
3919 * dispextern.h (struct bidi_it): New member frame_window_p.
3920 (bidi_init_it): Update prototypes.
3921 (display_prop_intangible_p): Update prototype.
3922 (compute_display_string_pos, compute_display_string_end):
3924 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3927 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3929 Malloc failure behavior now depends on size of allocation.
3930 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3931 * lisp.h: Change signatures accordingly.
3932 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3933 All callers changed. (Bug#8762)
3935 * gnutls.c: Use Emacs's memory allocators.
3936 Without this change, the gnutls library would invoke malloc etc.
3937 directly, which causes problems on non-SYNC_INPUT hosts, and which
3938 runs afoul of improving memory_full behavior. (Bug#8761)
3939 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3940 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3941 xfree instead of the default malloc, realloc, free.
3942 (Fgnutls_boot): No need to check for memory allocation failure,
3943 since xmalloc does that for us.
3945 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3946 * category.c (hash_get_category_set):
3947 * ccl.c (ccl_driver):
3948 * charset.c (Fdefine_charset_internal):
3949 * charset.h (struct charset.hash_index):
3950 * composite.c (get_composition_id, gstring_lookup_cache)
3951 (composition_gstring_put_cache):
3952 * composite.h (struct composition.hash_index):
3953 * dispextern.h (struct image.hash):
3954 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3955 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3956 (hashfn_equal, hashfn_user_defined, make_hash_table)
3957 (maybe_resize_hash_table, hash_lookup, hash_put)
3958 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3959 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3960 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3961 * image.c (make_image, search_image_cache, lookup_image)
3962 (xpm_put_color_table_h):
3963 * lisp.h (struct Lisp_Hash_Table):
3964 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3965 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3966 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3967 * alloc.c (allocate_vectorlike):
3968 Check for overflow in vector size calculations.
3969 * ccl.c (ccl_driver):
3970 Check for overflow when converting EMACS_INT to int.
3971 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3972 need to be updated by these changes.
3973 * fns.c (make_hash_table, maybe_resize_hash_table):
3974 Check for integer overflow with large hash tables.
3975 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3976 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3977 (SXHASH_REDUCE): New macro.
3978 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3979 Use it instead of discarding useful hash info with large hash values.
3980 (sxhash_float): New function.
3981 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3982 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3983 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3984 Rewrite to use FIXNUM_BITS, as this simplifies things.
3985 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3986 Adjust signatures to match updated version of code.
3987 (consing_since_gc): Now EMACS_INT, since a single hash table can
3988 use more than INT_MAX bytes.
3990 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3992 Make it possible to build with GCC-4.6+ -O2 -flto.
3994 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3996 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3998 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3999 Call minibuffer-inactive-mode.
4001 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4003 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4004 Update dependencies.
4006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4008 * data.c (init_data): Remove code for UTS, this system is not
4011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4013 Don't force ./temacs to start in terminal mode.
4015 * frame.c (make_initial_frame): Initialize faces in all cases, not
4016 only when CANNOT_DUMP is defined.
4017 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4019 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4021 * dispnew.c (add_window_display_history): Use const for the string
4022 pointer. Remove declaration, not needed.
4024 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4026 Use 'inline', not 'INLINE'.
4027 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4028 * alloc.c, fontset.c (INLINE): Remove.
4029 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4030 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4031 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4032 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4033 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4035 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4037 Make it possible to run ./temacs.
4039 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4040 syms_of_callproc does the same thing. Remove test for
4041 "initialized", do it in the caller.
4042 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4044 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4046 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4047 (read_minibuf): Use get_minibuffer.
4048 (syms_of_minibuf): Use DEFSYM.
4049 (Qmetadata): New var.
4050 * data.c (Qbuffer): Don't make it static.
4051 (syms_of_data): Use DEFSYM.
4053 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4055 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4056 (CCL_CODE_MIN): New macro.
4058 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4060 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4062 * eval.c (Qdebug): Now static.
4063 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4064 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4065 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4067 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4069 * image.c: Various fixes to ImageMagick code comments.
4070 (Fimagemagick_types): Doc fix.
4072 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4074 Minor fixes prompted by GCC 4.6.0 warnings.
4076 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4078 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4079 (x_clipboard_manager_save_all): Move extern decl to ...
4080 * xterm.h: ... here, so that it can be checked for consistency.
4082 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4084 * xselect.c (x_clipboard_manager_save_frame)
4085 (x_clipboard_manager_save_all): New functions.
4086 (Fx_clipboard_manager_save): Lisp function deleted.
4088 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4089 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4091 * xterm.h: Update prototype.
4093 2011-05-28 William Xu <william.xwl@gmail.com>
4095 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4098 2011-05-28 Jim Meyering <meyering@redhat.com>
4100 Avoid a sign-extension bug in crypto_hash_function.
4101 * fns.c (to_uchar): Define.
4102 (crypto_hash_function): Use it to convert some newly-signed
4103 variables to unsigned, to avoid sign-extension bugs. For example,
4104 without this change, (md5 "truc") would evaluate to
4105 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4106 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4107 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4109 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4111 Integer overflow fixes.
4113 * dbusbind.c: Serial number integer overflow fixes.
4114 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4115 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4116 to hold a serial number that is too large for a fixnum.
4117 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4118 Check for serial numbers out of range. Decode any serial number
4119 that was so large that it became a float. (Bug#8722)
4121 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4122 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4123 Use XFASTINT rather than XUINT when numbers are nonnegative.
4124 (xd_append_arg, Fdbus_method_return_internal):
4125 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4126 arguments, check that Lisp number is nonnegative, rather than
4127 silently wrapping negative numbers around. (Bug#8722)
4128 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4131 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4133 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4135 ccl: add integer overflow checks
4136 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4137 (IN_INT_RANGE): New macros.
4138 (ccl_driver): Use them to check for integer overflow when
4139 decoding a CCL program. Many of the new checks are whether XINT (x)
4140 fits in int; it doesn't always, on 64-bit hosts. The new version
4141 doesn't catch all possible integer overflows, but it's an
4142 improvement. (Bug#8719)
4144 * alloc.c (make_event_array): Use XINT, not XUINT.
4145 There's no need for unsigned here.
4147 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4148 This follows up to the 2011-05-06 change that substituted uintptr_t
4149 for EMACS_INT. This case wasn't caught back then.
4151 Rework Fformat to avoid integer overflow issues.
4152 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4153 now (part of C89). Include <verify.h>.
4154 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4155 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4156 (Fformat): Avoid the prepass trying to compute sizes; it was only
4157 approximate and thus did not catch overflow reliably. Instead, walk
4158 through the format just once, formatting and computing sizes as we go,
4159 checking for integer overflow at every step, and allocating a larger
4160 buffer as needed. Keep track separately whether the format is
4161 multibyte. Keep only the most-recently calculated precision, rather
4162 than them all. Record whether each argument has been converted to
4163 string. Use EMACS_INT, not int, for byte and char and arg counts.
4164 Support field widths and precisions larger than INT_MAX. Avoid
4165 sprintf's undefined behavior with conversion specifications such as %#d
4166 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4167 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4168 formatting out-of-range floating point numbers with int
4171 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4173 * data.c: Avoid integer truncation in expressions involving floats.
4174 * data.c: Include <intprops.h>.
4175 (arith_driver): When there's an integer overflow in an expression
4176 involving floating point, convert the integers to floating point
4177 so that the resulting value does not suffer from catastrophic
4178 integer truncation. For example, on a 64-bit host (* 4
4179 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4180 Do not rely on undefined behavior after integer overflow.
4182 merge count_size_as_multibyte, parse_str_to_multibyte
4183 * character.c, character.h (count_size_as_multibyte):
4184 Rename from parse_str_to_multibyte; all uses changed.
4185 Check for integer overflow.
4186 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4187 since it's now a duplicate of the other. This is more of
4188 a character than a buffer op, so better that it's in character.c.
4189 * fns.c, print.c: Adjust to above changes.
4191 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4193 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4195 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4197 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4198 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4199 (x_clipboard_manager_save): Now static.
4200 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4202 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4203 (crypto_hash_function): Now static.
4204 Fix pointer signedness problems. Avoid unnecessary initializations.
4206 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4208 * termhooks.h (Vselection_alist): Make it terminal-local.
4210 * terminal.c (create_terminal): Initialize it.
4212 * xselect.c: Support for clipboard managers.
4213 (Vselection_alist): Move to termhooks.h as terminal-local var.
4214 (LOCAL_SELECTION): New macro.
4215 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4216 (symbol_to_x_atom): Remove gratuitous arg.
4217 (x_handle_selection_request, lisp_data_to_selection_data)
4218 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4219 (x_own_selection, x_get_local_selection, x_convert_selection):
4220 New arg, specifying work frame. Use terminal-local Vselection_alist.
4221 (some_frame_on_display): Delete unused function.
4222 (Fx_own_selection_internal, Fx_get_selection_internal)
4223 (Fx_disown_selection_internal, Fx_selection_owner_p)
4224 (Fx_selection_exists_p): New optional frame arg.
4225 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4226 (x_handle_selection_clear): Don't treat other terminals with the
4227 same keyboard specially. Use the terminal-local Vselection_alist.
4228 (x_clear_frame_selections): Use Frun_hook_with_args.
4230 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4232 * xterm.h: Add support for those atoms.
4234 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4236 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4237 (converted_selections, conversion_fail_tag): New global variables.
4238 (x_selection_request_lisp_error): Free the above.
4239 (x_get_local_selection): Remove unnecessary code.
4240 (x_reply_selection_request): Args changed; handle arbitrary array
4241 of converted selections stored in converted_selections.
4242 Separate the XChangeProperty and SelectionNotify steps.
4243 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4244 (x_convert_selection): New function.
4245 (x_handle_selection_event): Simplify.
4246 (x_get_foreign_selection): Don't ignore incoming requests while
4247 waiting for an answer; this will fail when we implement
4248 SAVE_TARGETS, and seems unnecessary anyway.
4249 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4250 (Vx_sent_selection_functions): Doc fix.
4252 2011-05-26 Leo Liu <sdl.web@gmail.com>
4254 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4256 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4258 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4260 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4261 for fringe update if it has periodic bitmap.
4262 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4263 and fringe_bitmap_periodic_p.
4265 * fringe.c (get_fringe_bitmap_data): New function.
4266 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4267 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4268 row. Mark glyph row for fringe update if periodicity changed.
4270 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4271 for fringe update unless it has periodic bitmap.
4273 2011-05-25 Kenichi Handa <handa@m17n.org>
4275 * xdisp.c (get_next_display_element): Set correct it->face_id for
4276 a static composition.
4278 2011-05-24 Leo Liu <sdl.web@gmail.com>
4281 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4283 * fns.c (crypto_hash_function, Fsha1): New function.
4284 (Fmd5): Use crypto_hash_function.
4285 (syms_of_fns): Add Ssha1.
4287 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4289 * gnutls.c: Remove unused macros.
4290 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4291 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4292 Remove macros that are defined and never used.
4293 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4295 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4297 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4298 (Fx_get_selection_internal): Minor cleanup.
4299 (Fx_own_selection_internal): Rename arguments for consistency with
4302 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4304 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4306 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4308 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4310 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4312 * dispnew.c (scrolling_window): Don't exclude the case that the
4313 last enabled row in the desired matrix touches the bottom boundary.
4315 2011-05-21 Glenn Morris <rgm@gnu.org>
4317 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4318 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4319 and add some more files.
4321 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4323 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4324 report_file_error introduced by the change from 2011-05-07.
4326 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4328 * systime.h (Time): Define only if emacs is defined.
4329 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4330 where the include path doesn't have X11/X.h by default. See
4331 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4333 2011-05-20 Kenichi Handa <handa@m17n.org>
4335 * composite.c (find_automatic_composition): Fix previous change.
4337 2011-05-20 Glenn Morris <rgm@gnu.org>
4339 * lisp.mk: New file, split from Makefile.in.
4340 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4341 (shortlisp): Remove.
4342 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4344 2011-05-19 Glenn Morris <rgm@gnu.org>
4346 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4347 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4348 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4349 (lisp): Set the order to that of loadup.el.
4350 (shortlisp): Make it a copy of $lisp.
4351 (SOME_MACHINE_LISP): Remove.
4352 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4353 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4355 2011-05-18 Kenichi Handa <handa@m17n.org>
4357 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4358 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4359 (find_automatic_composition): Mostly rewrite for efficiency.
4361 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4363 * makefile.w32-in: Update dependencies.
4365 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4367 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4368 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4370 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4372 Fix some integer overflow issues, such as string length overflow.
4374 * insdel.c (count_size_as_multibyte): Check for string overflow.
4376 * character.c (lisp_string_width): Check for string overflow.
4377 Use EMACS_INT, not int, for string indexes and lengths; in
4378 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4379 the resulting string length overflows an EMACS_INT; instead,
4380 report a string overflow if no precision given. When checking for
4381 precision exhaustion, use a check that cannot possibly have
4382 integer overflow. (Bug#8675)
4383 * character.h (lisp_string_width): Adjust to new signature.
4385 * alloc.c (string_overflow): New function.
4386 (Fmake_string): Use it. This doesn't change behavior, but saves
4387 a few bytes and will simplify future changes.
4388 * character.c (string_escape_byte8): Likewise.
4389 * lisp.h (string_overflow): New decl.
4391 Fixups, following up to the user-interface timestamp change.
4392 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4393 for UI timestamps, instead of unsigned long.
4394 * msdos.c (mouse_get_pos): Likewise.
4395 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4396 * w32gui.h (Time): Define by including "systime.h" rather than by
4397 declaring it ourselves. (Bug#8664)
4399 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4400 * image.c (clear_image_cache): Likewise.
4402 * term.c (term_mouse_position): Don't assume time_t wraparound.
4404 Be more systematic about user-interface timestamps.
4405 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4406 and sometimes 'EMACS_UINT', to represent these timestamps.
4407 This change causes it to use 'Time' uniformly, as that's what X uses.
4408 This makes the code easier to follow, and makes it easier to catch
4409 integer overflow bugs such as Bug#8664.
4410 * frame.c (Fmouse_position, Fmouse_pixel_position):
4411 Use Time, not unsigned long, for user-interface timestamps.
4412 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4413 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4414 * keyboard.h (last_event_timestamp): Likewise.
4415 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4416 * menu.h (xmenu_show): Likewise.
4417 * term.c (term_mouse_position): Likewise.
4418 * termhooks.h (struct input_event.timestamp): Likewise.
4419 (struct terminal.mouse_position_hook): Likewise.
4420 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4421 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4422 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4423 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4425 * menu.h, termhooks.h: Include "systime.h", for Time.
4427 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4428 Don't assume that the difference between two unsigned long values
4429 can fit into an integer. At this point, we know button_down_time
4430 <= event->timestamp, so the difference must be nonnegative, so
4431 there's no need to cast the result if double-click-time is
4432 nonnegative, as it should be; check that it's nonnegative, just in
4433 case. This bug is triggered when events are more than 2**31 ms
4434 apart (about 25 days). (Bug#8664)
4436 * xselect.c (last_event_timestamp): Remove duplicate decl.
4437 (x_own_selection): Remove needless cast to unsigned long.
4439 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4440 that always fit in int. Use a sentinel instead of a counter, to
4441 avoid a temp and to allay GCC's concerns about possible int overflow.
4442 * frame.h (struct frame): Use int for menu_bar_items_used
4443 instead of EMACS_INT, since it always fits in int.
4445 * menu.c (grow_menu_items): Check for int overflow.
4447 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4449 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4450 Before, the code was not consistent. These values cannot exceed
4451 2**31 - 1 so there's no need to make them unsigned.
4452 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4453 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4454 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4456 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4458 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4459 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4460 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4461 presumably because the widths might not match.
4463 * window.c (size_window): Avoid needless test at loop start.
4465 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4467 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4469 2011-05-12 Drew Adams <drew.adams@oracle.com>
4471 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4473 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4475 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4476 `width' to `bar_area_x' and `bar_area_width', respectively.
4477 (x_scroll_run): Take account of fringe background extension.
4479 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4480 Rename local vars `left' and `width' to `bar_area_x' and
4481 `bar_area_width', respectively.
4482 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4483 background extension.
4485 2011-05-10 Jim Meyering <meyering@redhat.com>
4487 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4489 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4491 * image.c (Finit_image_library): Return t for built-in image types,
4492 like pbm and xbm. (Bug#8640)
4494 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4496 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4498 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4500 * w32console.c (Fset_screen_color): Doc fix.
4501 (Fget_screen_color): New function.
4502 (syms_of_ntterm): Defsubr it.
4504 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4505 unlink the temporary file if Fcall_process didn't create it in the
4507 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4508 child process will be redirected to a file specified with `:file'.
4509 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4510 cue to call_process_cleanup not to close that handle.
4512 2011-05-07 Ben Key <bkey76@gmail.com>
4514 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4515 one of two shell specific rules, either bootstrap-temacs-CMD or
4516 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4517 to the previous implementation of the bootstrap-temacs rule.
4518 The bootstrap-temacs-CMD rule is similar to the previous
4519 implementation of the bootstrap-temacs rule except that it
4520 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4523 These changes, along with some changes to nt/configure.bat,
4524 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4525 earlier fix to add support for --cflags and --ldflags options
4526 that include quotes so that it works whether make uses cmd or
4529 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4531 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4532 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4534 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4535 a string. Handle both cases.
4536 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4537 (Fdbus_register_method): Use Qinvalid_function.
4539 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4541 * makefile.w32-in: Update dependencies.
4542 (LISP_H): Add inttypes.h and stdin.h.
4543 (PROCESS_H): Add unistd.h.
4545 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4547 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4548 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4550 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4552 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4554 * term.c (vfatal): Remove stray call to va_end.
4555 It's not needed and the C Standard doesn't allow it here anyway.
4557 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4558 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4560 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4563 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4565 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4567 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4569 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4571 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4573 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4574 * charset.c (Fdefine_charset_internal): Don't initialize
4575 charset.code_space[15]. The value was garbage, on hosts with
4576 32-bit int (Bug#8600).
4578 * lread.c (read_integer): Be more consistent with string-to-number.
4579 Use string_to_number to do the actual conversion; this avoids
4580 rounding errors and fixes some other screwups. Without this fix,
4581 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4582 (digit_to_number): Move earlier, for benefit of read_integer.
4583 Return -1 if the digit is out of range for the base, -2 if it is
4584 not a digit in any supported base. (Bug#8602)
4586 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4588 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4589 to match comment at start of function. This also removes a
4590 GCC warning about overflow in a 32+64-bit port.
4592 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4594 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4595 Reported by Stefan Monnier in
4596 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4597 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4598 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4600 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4601 (EMACS_UINTPTR): Likewise, with uintptr_t.
4603 * lisp.h: Prefer 64-bit EMACS_INT if available.
4604 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4605 on 32-bit hosts that have 64-bit int, so that they can access
4607 However, temporarily disable this change unless the temporary
4608 symbol WIDE_EMACS_INT is defined.
4610 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4612 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4613 This removes an assumption that EMACS_INT and long are the same
4614 width as pointers. The assumption is true for Emacs porting targets
4615 now, but we want to make other targets possible.
4616 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4617 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4618 In the rest of the code, change types of integers that hold casted
4619 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4620 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4621 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4622 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4623 No need to cast type when ORing.
4624 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4625 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4626 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4627 assume EMACS_INT is the same width as char *.
4628 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4629 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4630 Remove no-longer-needed casts.
4631 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4632 (xg_tool_bar_help_callback, xg_make_tool_item):
4633 Use EMACS_INTPTR to hold an integer
4634 that will be cast to void *; this can avoid a GCC warning
4635 if EMACS_INT is not the same width as void *.
4636 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4637 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4638 (current_message_1, set_message_1):
4639 Use a local to convert to proper width without a cast.
4640 * xmenu.c (dialog_selection_callback): Likewise.
4642 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4643 Also, don't assume VALBITS / RAND_BITS is less than 5,
4644 and don't rely on undefined behavior when shifting a 1 left into
4646 * lisp.h (get_random): Change signature to match.
4648 * lread.c (hash_string): Use size_t, not int, for hash computation.
4649 Normally we prefer signed values; but hashing is special, because
4650 it's better to use unsigned division on hash table sizes so that
4651 the remainder is nonnegative. Also, size_t is the natural width
4652 for hashing into memory. The previous code used 'int', which doesn't
4653 retain enough info to hash well into very large tables.
4654 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4656 * dbusbind.c: Don't possibly lose pointer info when converting.
4657 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4658 Use XPNTR rather than XHASH, so that the high-order bits of
4659 the pointer aren't lost when converting through void *.
4661 * eval.c (Fautoload): Don't double-shift a pointer.
4663 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4665 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4667 * gnutls.c (DEF_GNUTLS_FN):
4668 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4670 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4672 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4675 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4677 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4678 New version that can reserve upto 2GB of heap space.
4680 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4682 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4684 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4686 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4687 `gnutls_certificate_set_x509_key_file'.
4689 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4691 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4692 Update dependencies.
4694 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4696 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4697 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4698 Remove unused parameter `fildes'.
4699 * process.c (read_process_output, send_process): Don't pass it.
4701 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4703 Fix previous change: the library cache is defined in w32.c.
4704 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4705 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4707 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4709 Implement dynamic loading of GnuTLS on Windows.
4711 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4712 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4713 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4716 * gnutls.c (Qgnutls_dll): Define.
4717 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4718 (gnutls_*): Declare function pointers.
4719 (init_gnutls_functions): New function to initialize function pointers.
4720 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4721 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4722 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4723 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4724 (emacs_gnutls_write, emacs_gnutls_read)
4725 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4726 (Fgnutls_available_p): New function.
4727 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4728 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4729 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4731 * image.c: Include w32.h.
4732 (Vimage_type_cache): Delete.
4733 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4734 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4735 (w32_delayed_load): Move to w32.c.
4737 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4739 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4740 (w32_delayed_load): Move from image.c. When loading a library, record
4741 its filename in the :loaded-from property of the library id.
4742 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4743 Initialize and staticpro them.
4744 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4746 * process.c: Include lisp.h before w32.h, not after.
4747 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4748 instead of gnutls_record_check_pending.
4750 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4752 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4754 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4755 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4758 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4760 * xterm.c (x_set_frame_alpha): Do not set property on anything
4761 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4763 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4765 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4767 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4769 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4770 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4771 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4772 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4773 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4774 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4775 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4776 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4777 (Qgnutls_bootprop_callbacks_verify): Make static.
4779 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4781 * callproc.c: Indentation fixup.
4783 * sysdep.c (wait_for_termination_1): Make static.
4784 (wait_for_termination, interruptible_wait_for_termination):
4785 Move after wait_for_termination_1.
4787 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4789 * sysdep.c (interruptible_wait_for_termination): New function
4790 which is like wait_for_termination, but allows keyboard
4793 * callproc.c (Fcall_process): Add (:file "file") as an option for
4795 (Fcall_process_region): Ditto.
4797 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4799 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4800 rather than `XVECTOR (FOO)->size'.
4802 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4803 inttypes.h, as a gnulib replacement is used if it not available in
4806 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4808 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4809 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4810 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4812 * coding.c (coding_alloc_by_realloc): Error out if destination
4813 will grow beyond MOST_POSITIVE_FIXNUM.
4814 (decode_coding_emacs_mule): Abort if there isn't enough place in
4815 charbuf for the composition carryover bytes. Reserve an extra
4816 space for up to 2 characters produced in a loop.
4817 (decode_coding_iso_2022): Abort if there isn't enough place in
4818 charbuf for the composition carryover bytes.
4820 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4822 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4823 aborting when %lld or %lll format is passed.
4824 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4825 %llo or %llx format is passed. (Bug#8545)
4827 * window.c (window_scroll_line_based): Use a marker instead of
4828 simple variables to record original value of point. (Bug#7952)
4830 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4831 produced by %s or %c overflows available buffer space. (Bug#8545)
4833 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4835 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4836 (SIZE_MAX): Move defn after all includes, as they might #define it.
4838 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4840 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4842 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4844 * keyboard.c (Qdelayed_warnings_hook): Define.
4845 (command_loop_1): Run `delayed-warnings-hook'
4846 if Vdelayed_warnings_list is non-nil.
4847 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4848 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4850 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4852 * doprnt.c (doprnt): Don't return value smaller than the buffer
4853 size if the message was truncated. (Bug#8545).
4855 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4857 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4858 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4860 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4862 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4864 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4866 * makefile.w32-in: Update dependencies.
4868 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4870 Improve `doprnt' and its usage. (Bug#8545)
4871 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4872 `format_end'. Remove support for %l as a conversion specifier.
4873 Don't use xrealloc. Improve diagnostics when the %l size modifier
4874 is used. Update the commentary.
4876 * eval.c (verror): Simplify calculation of size_t.
4878 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4881 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4883 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4886 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4888 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4889 This makes this file independent of the recent pseudovector change.
4891 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4893 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4895 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4896 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4897 Remove unused local.
4898 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4900 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4901 GCC 4.6.0 optimizes based on type-based alias analysis.
4902 For example, if b is of type struct buffer * and v of type struct
4903 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4904 != &v->size, and therefore "v->size = 1; b->size = 2; return
4905 v->size;" must therefore return 1. This assumption is incorrect
4906 for Emacs, since it type-puns struct Lisp_Vector * with many other
4907 types. To fix this problem, this patch adds a new type struct
4908 vectorlike_header that documents the constraints on layout of vectors
4909 and pseudovectors, and helps optimizing compilers not get fooled
4910 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4911 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4912 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4914 (XSETPVECTYPE): Rewrite in terms of new macro.
4915 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4916 This is a bit clearer, and further avoids the possibility of
4917 undesirable aliasing.
4918 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4919 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4920 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4921 since Lisp_Subr is a special case (no "next" field).
4922 (ASIZE): Now uses header.size rather than size.
4923 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4924 to avoid the hassle of writing XVECTOR (foo)->header.size.
4925 (struct vectorlike_header): New type.
4926 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4927 object, to help avoid aliasing.
4928 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4929 (SUBRP): Likewise, since Lisp_Subr is a special case.
4930 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4931 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4932 (struct Lisp_Hash_Table): Combine first two members into a single
4933 struct vectorlike_header member. All uses of "size" and "next" members
4934 changed to be "header.size" and "header.next".
4935 * buffer.h (struct buffer): Likewise.
4936 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4937 * frame.h (struct frame): Likewise.
4938 * process.h (struct Lisp_Process): Likewise.
4939 * termhooks.h (struct terminal): Likewise.
4940 * window.c (struct save_window_data, struct saved_window): Likewise.
4941 * window.h (struct window): Likewise.
4942 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4943 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4944 * buffer.c (init_buffer_once): Likewise.
4945 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4947 * process.c (Fformat_network_address): Use local var for size,
4950 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4952 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4953 * data.c (atof): Remove decl; no longer used or needed.
4954 (digit_to_number): Move to lread.c.
4955 (Fstring_to_number): Use new string_to_number function, to be
4956 consistent with how the Lisp reader treats infinities and NaNs.
4957 Do not assume that floating-point numbers represent EMACS_INT
4958 without losing information; this is not true on most 64-bit hosts.
4959 Avoid double-rounding errors, by insisting on integers when
4960 parsing non-base-10 numbers, as the documentation specifies.
4961 * lisp.h (string_to_number): New decl, replacing ...
4962 (isfloat_string): Remove.
4963 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4964 (read1): Do not accept +. and -. as integers; this
4965 appears to have been a coding error. Similarly, do not accept
4966 strings like +-1e0 as floating point numbers. Do not report
4967 overflow for integer overflows unless the base is not 10 which
4968 means we have no simple and reliable way to continue.
4969 Break out the floating-point parsing into a new
4970 function string_to_number, so that Fstring_to_number parses
4971 floating point numbers consistently with the Lisp reader.
4972 (digit_to_number): Move here from data.c. Make it static inline.
4973 (E_CHAR, EXP_INT): Remove, replacing with ...
4974 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4975 (string_to_number): New function, replacing isfloat_string.
4976 This function checks for valid syntax and produces the resulting
4977 Lisp float number too. Rework it so that string-to-number
4978 no longer mishandles examples like "1.0e+". Use strtoumax,
4979 so that overflow for non-base-10 numbers is reported only when
4980 there's no portable and simple way to convert to floating point.
4982 * textprop.c (set_text_properties_1): Rewrite for clarity,
4983 and to avoid GCC warning about integer overflow.
4985 * intervals.h (struct interval): Use EMACS_INT for members
4986 where EMACS_UINT might cause problems. See
4987 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4988 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4989 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4991 (offset_intervals): Tell GCC not to worry about length overflow
4992 when negating a negative length.
4994 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4995 (overrun_check_free): Likewise.
4997 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4998 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5001 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5002 (gnutls_make_error): Rename local to avoid shadowing.
5003 (gnutls_emacs_global_deinit): ifdef out; not used.
5004 (Fgnutls_boot): Use const for pointer to readonly storage.
5005 Comment out unused local. Fix pointer signedness problems.
5007 * lread.c (openp): Don't stuff size_t into an 'int'.
5008 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5009 about possible signed overflow.
5011 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5012 (GDK_KEY_g): Don't define if already defined.
5013 (xg_prepare_tooltip): Avoid pointer signedness problem.
5014 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5016 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5017 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5019 * xfns.c (Fx_window_property): Simplify a bit,
5020 to make a bit faster and to avoid GCC 4.6.0 warning.
5021 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5023 * fns.c (internal_equal): Don't assume size_t fits in int.
5025 * alloc.c (compact_small_strings): Tighten assertion a little.
5027 Replace pEd with more-general pI, and fix some printf arg casts.
5028 * lisp.h (pI): New macro, generalizing old pEd macro to other
5029 conversion specifiers. For example, use "...%"pI"d..." rather
5030 than "...%"pEd"...".
5031 (pEd): Remove. All uses replaced with similar uses of pI.
5032 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5033 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5034 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5035 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5036 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5037 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5038 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5040 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5041 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5042 * print.c (safe_debug_print, print_object): Likewise.
5043 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5045 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5046 avoiding the 0 flag, which is not portable.
5047 * process.c (Fmake_network_process): Use pI to avoid cast.
5048 * region-cache.c (pp_cache): Likewise.
5049 * xdisp.c (decode_mode_spec): Likewise.
5050 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5051 behavior on 64-bit hosts with printf arg.
5052 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5053 (x_stop_queuing_selection_requests): Likewise.
5054 (x_get_window_property): Don't truncate byte count to an 'int'
5057 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5058 here, since it parses constructs like leading '-' and spaces,
5059 which are not wanted; and it overflows with large numbers.
5060 Instead, simply match F[0-9]+, which is what is wanted anyway.
5062 * alloc.c: Remove unportable assumptions about struct layout.
5063 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5064 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5065 (allocate_vectorlike, make_pure_vector): Use the new macros,
5066 plus offsetof, to remove unportable assumptions about struct layout.
5067 These assumptions hold on all porting targets that I know of, but
5068 they are not guaranteed, they're easy to remove, and removing them
5069 makes further changes easier.
5071 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5072 This doesn't fix a bug but makes the code clearer.
5073 (string_overrun_cookie): Now const. Use initializers that
5074 don't formally overflow signed char, to avoid warnings.
5075 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5076 can cause Emacs to crash when string overrun checking is enabled.
5077 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5078 multiple of sizeof (EMACS_INT); it need not be, if
5079 alignof(EMACS_INT) < sizeof (EMACS_INT).
5080 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5082 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5084 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5086 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5088 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5089 supposed to be handshaking. (Bug#8556)
5090 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5092 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5094 * lisp.h (Qdebug): List symbol.
5095 * eval.c (Qdebug): Restore global linkage.
5096 * keyboard.c (debug-on-event): New variable.
5097 (handle_user_signal): Break into debugger when debug-on-event
5098 matches the current signal symbol.
5100 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5102 * alloc.c (check_sblock, check_string_bytes)
5103 (check_string_free_list): Convert to standard C.
5105 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5107 * w32.c (emacs_gnutls_push): Fix typo.
5109 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5111 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5112 "cast to pointer from integer of different size".
5114 Improve doprnt and its use in verror. (Bug#8545)
5115 * doprnt.c (doprnt): Document the set of format control sequences
5116 supported by the function. Use SAFE_ALLOCA instead of always
5119 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5120 is one byte too soon. Don't use xrealloc; instead xfree and
5123 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5125 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5128 * gnutls.c: Renamed global_initialized to
5129 gnutls_global_initialized. Added internals for the
5130 :verify-hostname-error, :verify-error, and :verify-flags
5131 parameters of `gnutls-boot' and documented those parameters in the
5132 docstring. Start callback support.
5133 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5134 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5135 on error. Return error code.
5136 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5137 (emacs_gnutls_read): Likewise.
5138 (Fgnutls_boot): Return handshake error code.
5139 (emacs_gnutls_handle_error): New function.
5140 (wsaerror_to_errno): Likewise.
5142 * w32.h (emacs_gnutls_pull): Add prototype.
5143 (emacs_gnutls_push): Likewise.
5145 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5146 (emacs_gnutls_push): Likewise.
5148 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5150 * process.c (wait_reading_process_output): Check if GnuTLS
5151 buffered some data internally if no FDs are set for TLS
5154 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5155 (LIBS): Link to USER_LIBS.
5156 ($(BLD)/gnutls.$(0)): New target.
5158 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5160 * xdisp.c (handle_single_display_spec): Rename the
5161 display_replaced_before_p argument into display_replaced_p, to
5162 make it consistent with the commentary. Fix typos in the
5165 * textprop.c (syms_of_textprop): Remove dead code.
5166 (copy_text_properties): Delete obsolete commentary about an
5167 interface that was deleted long ago. Fix typos in the description
5170 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5171 to changes in oldXMenu/XMenu.h from 2011-04-16.
5172 <menu_help_message, prev_menu_help_message>: Constify.
5173 (IT_menu_make_room): menu->help_text is now `const char **';
5176 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5177 to changes in oldXMenu/XMenu.h from 2011-04-16.
5178 (struct XMenu): Declare `help_text' `const char **'.
5180 * xfaces.c <Qunspecified>: Make extern again.
5182 * syntax.c: Include sys/types.h before including regex.h, as
5185 * doc.c (get_doc_string): Improve the format passed to `error'.
5187 * doprnt.c (doprnt): Improve commentary.
5189 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5191 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5194 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5195 changes in globals.h immediately force recompilation.
5196 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5197 $(CURDIR)/s/ms-w32.h.
5198 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5200 * character.c (Fchar_direction): Function deleted.
5201 (syms_of_character): Don't defsubr it.
5202 <char-direction-table>: Deleted.
5204 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5206 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5207 * doprnt.c: Include limits.h.
5208 (SIZE_MAX): New macro.
5209 (doprnt): Return a size_t value. 2nd arg is now size_t.
5210 Many local variables are now size_t instead of int or unsigned.
5211 Improve overflow protection. Support `l' modifier for integer
5212 conversions. Support %l conversion. Don't assume an EMACS_INT
5213 argument for integer conversions and for %c.
5215 * lisp.h (doprnt): Restore prototype.
5217 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5220 * Makefile.in (base_obj): Add back doprnt.o.
5222 * deps.mk (doprnt.o): Add back prerequisites.
5223 (callint.o): Depend on character.h.
5225 * eval.c (internal_lisp_condition_case): Include the handler
5226 representation in the error message.
5227 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5228 when breaking from the loop.
5230 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5232 * callint.c (Fcall_interactively): When displaying error message
5233 about invalid control letter, pass the character's codepoint, not
5234 a pointer to its multibyte form. Improve display of the character
5235 in octal and display also its hex code.
5237 * character.c (char_string): Use %x to display the (unsigned)
5238 codepoint of an invalid character, to avoid displaying a bogus
5241 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5242 `error', not SYMBOL_NAME itself.
5244 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5245 character arguments to `error'.
5247 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5248 to `error' in error message about FINAL_CHAR argument. Make sure
5249 FINAL_CHAR is a character, and use %c when it is passed as
5250 argument to `error'.
5252 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5254 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5256 * w32.c: Include <time.h>.
5257 (sys_localtime): New function.
5259 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5261 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5263 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5265 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5267 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5270 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5272 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5273 gl_state.e_property when gl_state.object is Qt.
5275 * insdel.c (make_gap_larger): Remove limitation of buffer size
5278 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5280 * xdisp.c (lookup_glyphless_char_display)
5281 (produce_glyphless_glyph): Handle cons cell entry in
5282 glyphless-char-display.
5283 (Vglyphless_char_display): Document it.
5285 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5286 glyphless-char-display.
5288 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5290 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5292 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5294 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5295 definition for no-X builds.
5297 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5299 Static checks with GCC 4.6.0 and non-default toolkits.
5301 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5303 * process.c (keyboard_bit_set): Define only if SIGIO.
5304 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5305 (send_process): Repair possible setjmp clobbering.
5307 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5309 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5311 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5313 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5314 Define only if needed.
5316 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5317 by pacifying GCC about it. Maybe it's time to retire it?
5318 * xfaces.c (USG, __TIMEVAL__): Likewise.
5320 * dispextern.h (struct redisplay_interface): Rename param
5322 * termhooks.h (struct terminal): Likewise.
5323 * xterm.c (xembed_send_message): Likewise.
5325 * insdel.c (make_gap_smaller): Define only if
5326 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5328 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5331 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5332 so that we aren't warned about unused symbols.
5334 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5336 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5338 * xfns.c (x_real_positions): Mark locals as initialized.
5340 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5342 * xterm.c: Fix problems found by static analysis with other toolkits.
5343 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5344 (x_dispatch_event): Declare static if USE_GTK, and
5345 define if USE_GTK || USE_X_TOOLKIT.
5346 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5347 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5348 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5349 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5351 * xmenu.c (menu_help_callback): Pointer type fixes.
5352 Use const pointers when pointing at readonly data. Avoid pointer
5354 (FALSE): Remove unused macro.
5355 (update_frame_menubar): Remove unused decl.
5357 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5359 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5360 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5361 (single_menu_item): Rename local to avoid shadowing.
5363 * keyboard.c (make_lispy_event): Remove unused local var.
5365 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5366 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5368 * bitmaps: Change bitmaps from unsigned char back to the X11
5369 compatible char. Avoid the old compiler warnings about
5370 out-of-range initializers by using, for example, '\xab' rather
5373 * xgselect.c (xgselect_initialize): Check vs interface
5374 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5376 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5378 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5379 to read-only memory.
5381 * fns.c (vector): Remove; this old hack is no longer needed.
5383 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5385 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5387 * xrdb.c (x_load_resources): Omit unused local.
5389 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5390 (x_window): Rename locals to avoid shadowing.
5391 (USG): Use the kludged USG macro, to pacify gcc.
5393 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5394 (x_term_init): Remove local to avoid shadowing.
5396 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5398 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5399 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5401 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5403 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5405 Fix regex.c, syntax.c and friends for buffers > 2GB.
5406 * syntax.h (struct gl_state_s): Declare character position members
5409 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5411 * textprop.c (verify_interval_modification, interval_of):
5412 Declare arguments EMACS_INT.
5414 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5417 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5419 * indent.c (Fvertical_motion): Local variable it_start is now
5422 * regex.c (re_match, re_match_2, re_match_2_internal)
5423 (bcmp_translate, regcomp, regexec, print_double_string)
5424 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5425 (re_compile_pattern, re_exec): Declare arguments and local
5426 variables `size_t' and `ssize_t' and return values `regoff_t', as
5428 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5429 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5430 <compile_stack_type>: `size' and `avail' are now `size_t'.
5432 * regex.h <regoff_t>: Use ssize_t, not int.
5433 (re_search, re_search_2, re_match, re_match_2): Arguments that
5434 specify buffer/string position and length are now ssize_t and
5435 size_t. Return type is regoff_t.
5437 2011-04-16 Ben Key <bkey76@gmail.com>
5439 * nsfont.m: Fixed bugs in ns_get_family and
5440 ns_descriptor_to_entity that were caused by using free to
5441 deallocate memory blocks that were allocated by xmalloc (via
5442 xstrdup). This caused Emacs to crash when compiled with
5443 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5444 --enable-checking=xmallocoverrun). xfree is now used to
5445 deallocate these memory blocks.
5447 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5449 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5451 emacs_write: Accept and return EMACS_INT for sizes.
5452 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5454 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5455 Accept and return EMACS_INT.
5456 (emacs_gnutls_write): Return the number of bytes written on
5458 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5459 (emacs_read, emacs_write): Remove check for negative size, as the
5460 Emacs source code has been audited now.
5461 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5462 (emacs_read, emacs_write): Use it.
5463 * process.c (send_process): Adjust to the new signatures of
5464 emacs_write and emacs_gnutls_write. Do not attempt to store
5465 a byte offset into an 'int'; it might overflow.
5466 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5468 * sound.c: Don't assume sizes fit in 'int'.
5469 (struct sound_device.period_size, alsa_period_size):
5470 Return EMACS_INT, not int.
5471 (struct sound_device.write, vox_write, alsa_write):
5472 Accept EMACS_INT, not int.
5473 (wav_play, au_play): Use EMACS_INT to store sizes and to
5474 record read return values.
5476 2011-04-15 Ben Key <bkey76@gmail.com>
5478 * keyboard.c (Qundefined): Don't declare static since it is used
5480 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5481 static since they are used in nsfont.m.
5483 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5485 * process.c (Qprocessp): Don't declare static.
5486 * lisp.h (Qprocessp): Declare again.
5488 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5490 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5492 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5494 Improve C-level modularity by making more things 'static'.
5496 Don't publish debugger-only interfaces to other modules.
5497 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5498 (verify_bytepos, count_markers): Move decls to the only modules
5500 * region-cache.h (pp_cache): Likewise.
5501 * window.h (check_all_windows): Likewise.
5502 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5504 * sysdep.c (croak): Now static, if
5505 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5506 * syssignal.h (croak): Declare only if not static.
5508 * alloc.c (refill_memory_reserve): Now static if
5509 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5510 * lisp.h (refill_memory_reserve): Declare only if not static.
5512 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5513 Define only if USE_LUCID.
5515 * xrdb.c (x_customization_string, x_rm_string): Now static.
5517 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5518 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5520 * xdisp.c (draw_row_with_mouse_face): Now static.
5521 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5523 * window.h (check_all_windows): Mark externally visible.
5525 * window.c (window_deletion_count): Now static.
5527 * undo.c: Make symbols static if they're not exported.
5528 (last_undo_buffer, last_boundary_position, pending_boundary):
5531 * textprop.c (interval_insert_behind_hooks): Now static.
5532 (interval_insert_in_front_hooks): Likewise.
5534 * term.c: Make symbols static if they're not exported.
5535 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5536 (max_frame_lines, tty_set_terminal_modes):
5537 (tty_reset_terminal_modes, tty_turn_off_highlight):
5538 (get_tty_terminal): Now static.
5539 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5540 * termhooks.h (term_mouse_moveto): Do not declare if
5542 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5543 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5545 * sysdep.c: Make symbols static if they're not exported.
5546 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5548 (sigprocmask_set, full_mask): Remove; unused.
5549 (wait_debugging): Mark as visible.
5550 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5551 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5553 * syntax.c (syntax_temp): Define only if !__GNUC__.
5555 * sound.c (current_sound_device, current_sound): Now static.
5557 * search.c (searchbufs, searchbuf_head): Now static.
5559 * scroll.c (scroll_cost): Remove; unused.
5560 * dispextern.h (scroll_cost): Remove decl.
5562 * region-cache.h (pp_cache): Mark as externally visible.
5564 * process.c: Make symbols static if they're not exported.
5565 (process_tick, update_tick, create_process, chan_process):
5566 (Vprocess_alist, proc_buffered_char, datagram_access):
5567 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5568 (deactivate_process): Mark defn as static, as well as decl.
5569 * lisp.h (create_process): Remove decl.
5570 * process.h (chan_process, Vprocess_alist): Remove decls.
5572 * print.c: Make symbols static if they're not exported.
5573 (print_depth, new_backquote_output, being_printed, print_buffer):
5574 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5575 (print_interval, print_number_index, initial_stderr_stream):
5577 * lisp.h (Fprinc): Remove decl.
5578 (debug_output_compilation_hack): Mark as externally visible.
5580 * sysdep.c (croak): Move decl from here to syssignal.h.
5581 * syssignal.h (croak): Put it here, so the API can be checked when
5582 'croak' is called from dissociate_if_controlling_tty.
5584 * minibuf.c: Make symbols static if they're not exported.
5585 (minibuf_save_list, choose_minibuf_frame): Now static.
5586 * lisp.h (choose_minibuf_frame): Remove decl.
5588 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5590 * lread.c: Make symbols static if they're not exported.
5591 (read_objects, initial_obarray, oblookup_last_bucket_number):
5593 (make_symbol): Remove; unused.
5594 * lisp.h (initial_obarray, make_symbol): Remove decls.
5596 * keyboard.c: Make symbols static if they're not exported.
5597 (single_kboard, recent_keys_index, total_keys, recent_keys):
5598 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5599 (this_single_command_key_start, echoing, last_auto_save):
5600 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5601 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5602 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5603 (Vlispy_mouse_stem, double_click_count):
5605 (force_auto_save_soon): Define only if SIGDANGER.
5606 (ignore_mouse_drag_p): Now static if
5607 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5608 (print_help): Remove; unused.
5609 (stop_character, last_timer_event): Mark as externally visible.
5610 * keyboard.h (ignore_mouse_drag_p): Declare only if
5611 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5612 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5613 * lisp.h (echoing): Remove decl.
5614 (force_auto_save_soon): Declare only if SIGDANGER.
5615 * xdisp.c (redisplay_window): Simplify code, to make it more
5616 obvious that ignore_mouse_drag_p is not accessed if !defined
5617 USE_GTK && !defined HAVE_NS.
5619 * intervals.c: Make symbols static if they're not exported.
5620 (merge_properties_sticky, merge_interval_right, delete_interval):
5622 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5624 * insdel.c: Make symbols static if they're not exported.
5625 However, leave prepare_to_modify_buffer alone. It's never
5626 called from outside this function, but that appears to be a bug.
5627 (combine_after_change_list, combine_after_change_buffer):
5628 (adjust_after_replace, signal_before_change): Now static.
5629 (adjust_after_replace_noundo): Remove; unused.
5630 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5631 (signal_before_change): Remove decls.
5633 * indent.c (val_compute_motion, val_vmotion): Now static.
5635 * image.c: Make symbols static if they're not exported.
5636 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5638 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5639 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5641 * fringe.c (standard_bitmaps): Now static.
5642 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5644 * frame.c: Make symbols static if they're not exported.
5645 (x_report_frame_params, make_terminal_frame): Now static.
5646 (get_frame_param): Now static, unless HAVE_NS.
5647 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5648 (x_get_resource_string): Remove; not used.
5649 * frame.h (make_terminal_frame, x_report_frame_params):
5650 (x_get_resource_string); Remove decls.
5651 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5652 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5654 * font.c, fontset.c: Make symbols static if they're not exported.
5655 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5656 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5657 * font.c (font_close_object): Now static.
5658 * font.h (font_close_object): Remove.
5659 * fontset.c (FONTSET_OBJLIST): Remove.
5660 (free_realized_fontset) #if-0 the body, which does nothing.
5661 (face_suitable_for_char_p): #if-0, as it's never called.
5662 * fontset.h (face_suitable_for_char_p): Remove decl.
5663 * xfaces.c (face_at_string_position):
5664 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5665 since 0 is always ASCII.
5667 * fns.c (weak_hash_tables): Now static.
5669 * fileio.c: Make symbols static if they're not exported.
5670 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5671 (Vwrite_region_annotation_buffers): Now static.
5673 * eval.c: Make symbols static if they're not exported.
5674 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5675 * lisp.h (backtrace_list): Remove decl.
5677 * emacs.c: Make symbols static if they're not exported.
5678 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5679 (fatal_error_code, fatal_error_signal_hook, standard_args):
5681 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5682 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5683 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5684 * lisp.h (fatal_error_signal_hook): Remove decl.
5685 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5687 * editfns.c: Move a (normally-unused) function to its only use.
5688 * editfns.c, lisp.h (get_operating_system_release): Remove.
5689 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5690 worth the hassle of breaking this out.
5692 * xterm.c: Make symbols static if they're not exported.
5693 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5694 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5695 (x_destroy_window, x_delete_display):
5697 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5698 (x_mouse_leave): Remove; unused.
5699 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5700 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5701 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5703 (x_mouse_leave): Declare only if WINDOWSNT.
5704 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5705 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5708 * ftxfont.c: Make symbols static if they're not exported.
5709 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5711 * font.h (ftxfont_driver): Likewise.
5713 * xfns.c: Make symbols static if they're not exported.
5714 (x_last_font_name, x_display_info_for_name):
5715 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5716 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5717 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5718 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5719 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5720 (last_show_tip_args): Now static.
5721 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5722 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5723 (x_screen_planes): Remove; unused.
5724 * dispextern.h (x_screen_planes): Remove decl.
5726 * dispnew.c: Make symbols static if they're not exported.
5727 * dispextern.h (redraw_garbaged_frames, scrolling):
5728 (increment_row_positions): Remove.
5729 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5730 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5732 (redraw_garbaged_frames): Remove; unused.
5734 * xfaces.c: Make symbols static if they're not exported.
5735 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5737 * xterm.h (defined_color): Remove decls.
5738 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5739 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5740 (menu_face_changed_default, defined_color, free_realized_face):
5741 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5742 (ascii_face_of_lisp_face): Remove; unused.
5744 * xdisp.c: Make symbols static if they're not exported.
5745 * dispextern.h (scratch_glyph_row, window_box_edges):
5746 (glyph_to_pixel_coords, set_cursor_from_row):
5747 (get_next_display_element, set_iterator_to_next):
5748 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5749 (show_mouse_face): Remove decls
5750 * frame.h (message_buf_print): Likewise.
5751 * lisp.h (pop_message, set_message, check_point_in_composition):
5753 * xterm.h (set_vertical_scroll_bar): Likewise.
5754 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5755 (message_buf_print, scratch_glyph_row, displayed_buffer):
5756 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5757 (get_next_display_element, show_mouse_face, window_box_edges):
5758 (frame_to_window_pixel_xy, check_point_in_composition):
5759 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5760 (glyph_to_pixel_coords): Remove; unused.
5762 * dired.c (file_name_completion): Now static.
5764 * dbusbind.c (xd_in_read_queued_messages): Now static.
5766 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5767 * data.c (circular_list_error): Remove.
5769 * commands.h (last_point_position, last_point_position_buffer):
5770 (last_point_position_window): Remove decls.
5771 * keyboard.c: Make these variables static.
5773 * coding.h (coding, code_convert_region, encode_coding_gap):
5775 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5776 (iso_code_class, detect_coding, code_convert_region): Now static.
5777 (encode_coding_gap): Remove; unused.
5779 * chartab.c (chartab_chars, chartab_bits): Now static.
5781 * charset.h (charset_iso_8859_1): Remove decl.
5782 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5785 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5786 * ccl.c (Vccl_program_table): Now static.
5787 (check_ccl_update): Remove; unused.
5789 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5790 * category.h: ... from here.
5791 * category.c (check_category_table, set_category_set): Now static.
5793 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5794 * lisp.h: Remove these decls.
5796 * buffer.c (buffer_count): Remove unused var.
5798 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5799 so that it's not optimized away.
5800 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5801 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5802 exported only to the debugger.
5804 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5805 * atimer.h (run_all_atimers): Remove; not exported.
5807 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5808 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5809 was inaccessible from Lisp.
5810 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5811 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5813 alloc.c: Import and export fewer symbols, and remove unused items.
5814 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5816 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5817 it's not optimized away by whole-program optimization.
5818 (message_enable_multibyte, free_misc): Remove.
5819 (catchlist, handlerlist, mark_backtrace):
5820 Declare only if BYTE_MARK_STACK.
5821 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5822 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5823 (message_enable_multibyte): Remove decl.
5824 (free_misc, interval_free_list, float_block, float_block_index):
5825 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5826 (cons_free_list, last_marked_index):
5828 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5829 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5830 (mark_backtrace): Define only if BYTE_MARK_STACK.
5831 * xdisp.c (message_enable_multibyte): Now static.
5833 Declare Lisp_Object Q* variables to be 'static' if not exported.
5834 This makes it easier for human readers (and static analyzers)
5835 to see whether these variables are used from other modules.
5836 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5837 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5838 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5839 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5840 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5841 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5842 * xmenu.c, xselect.c:
5843 Declare Q* vars static if they are not used in other modules.
5844 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5845 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5846 Remove decls of unexported vars.
5847 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5849 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5851 Make Emacs functions such as Fatom 'static' by default.
5852 This makes it easier for human readers (and static analyzers)
5853 to see whether these functions can be called from other modules.
5854 DEFUN now defines a static function. To make the function external
5855 so that it can be used in other C modules, use the new macro DEFUE.
5856 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5857 (Finit_image_library):
5858 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5859 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5860 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5861 Remove decls, since these functions are now static.
5862 (Funintern, Fget_internal_run_time): New decls, since these functions
5863 were already external.
5865 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5866 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5867 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5868 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5869 * keyboard.c, keymap.c, lread.c:
5870 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5871 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5872 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5873 Mark functions with DEFUE instead of DEFUN,
5874 if they are used in other modules.
5875 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5876 decls for now-static functions.
5877 * buffer.h (Fdelete_overlay): Remove decl.
5878 * callproc.c (Fgetenv_internal): Mark as internal.
5879 * composite.c (Fremove_list_of_text_properties): Remove decl.
5880 (Fcomposition_get_gstring): New forward static decl.
5881 * composite.h (Fcomposite_get_gstring): Remove decl.
5882 * dired.c (Ffile_attributes): New forward static decl.
5883 * doc.c (Fdocumntation_property): New forward static decl.
5884 * eval.c (Ffetch_bytecode): New forward static decl.
5885 (Funintern): Remove extern decl; now in .h file where it belongs.
5886 * fileio.c (Fmake_symbolic_link): New forward static decl.
5887 * image.c (Finit_image_library): New forward static decl.
5888 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5889 * intervals.h (Fprevious_property_change):
5890 (Fremove_list_of_text_properties): Remove decls.
5891 * keyboard.c (Fthis_command_keys): Remove decl.
5892 (Fcommand_execute): New forward static decl.
5893 * keymap.c (Flookup_key): New forward static decl.
5894 (Fcopy_keymap): Now static.
5895 * keymap.h (Flookup_key): Remove decl.
5896 * process.c (Fget_process): New forward static decl.
5897 (Fprocess_datagram_address): Mark as internal.
5898 * syntax.c (Fsyntax_table_p): New forward static decl.
5899 (skip_chars): Remove duplicate decl.
5900 * textprop.c (Fprevious_property_change): New forward static decl.
5901 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5903 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5904 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5906 * editfns.c (Fformat): Remove unreachable code.
5908 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5910 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5913 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5915 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5916 when at ZV. (Bug#8487)
5918 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5920 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5922 * keyboard.c (parse_tool_bar_item): Likewise.
5923 * sound.c (sound_cleanup, alsa_close): Likewise.
5924 * termcap.c (tgetent): Likewise.
5925 * xfns.c (x_default_font_parameter): Likewise.
5926 * xsettings.c (read_and_apply_settings): Likewise.
5928 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5929 (overrun_check_free): Protoize.
5931 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5933 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5934 since callers should never pass a negative size.
5935 Change the signature to match that of plain 'read' and 'write'; see
5936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5937 * lisp.h: Update prototypes of emacs_write and emacs_read.
5939 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5941 * xdisp.c (redisplay_window): Don't try to determine the character
5942 position of the scroll margin if the window start point w->startp
5943 is outside the buffer's accessible region. (Bug#8468)
5945 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5947 Fix write-region and its subroutines for buffers > 2GB.
5948 * fileio.c (a_write, e_write): Modify declaration of arguments and
5949 local variables to support buffers larger than 2GB.
5950 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5952 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5953 argument, local variables, and return value.
5955 * lisp.h: Update prototypes of emacs_write and emacs_read.
5957 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5959 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5961 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5963 Fix more problems found by GCC 4.6.0's static checks.
5965 * xdisp.c (vmessage): Use a better test for character truncation.
5967 * charset.c (load_charset_map): <, not <=, for optimization,
5968 and to avoid potential problems with integer overflow.
5969 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5970 * casetab.c (set_identity, shuffle): Likewise.
5971 * editfns.c (Fformat): Likewise.
5972 * syntax.c (skip_chars): Likewise.
5974 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5975 This also lets GCC 4.6.0 generate slightly better loop code.
5977 * callint.c (Fcall_interactively): <, not <=, for optimization.
5978 (Fcall_interactively): Count the number of arguments produced,
5979 not the number of arguments given. This is simpler and lets GCC
5980 4.6.0 generate slightly better code.
5982 * ftfont.c: Distingish more carefully between FcChar8 and char.
5983 The previous code passed unsigned char * to a functions like
5984 strlen and xstrcasecmp that expect char *, which does not
5985 conform to the C standard.
5986 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5987 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5988 char * when the C standard requires it.
5990 * keyboard.c (read_char): Remove unused var.
5992 * eval.c: Port to Windows vsnprintf (Bug#8435).
5994 (SIZE_MAX): Define if the headers do not.
5995 (verror): Do not give up if vsnprintf returns a negative count.
5996 Instead, grow the buffer. This ports to Windows vsnprintf, which
5997 does not conform to C99. Problem reported by Eli Zaretskii.
5998 Also, simplify the allocation scheme, by avoiding the need for
5999 calling realloc, and removing the ALLOCATED variable.
6001 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6003 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6004 But keep the doprint source code for now, as we might revamp it
6005 and use it again (Bug#8435).
6006 * lisp.h (doprnt): Remove.
6007 * Makefile.in (base_obj): Remove doprnt.o.
6008 * deps.mk (doprnt.o): Remove.
6010 error: Print 32- and 64-bit integers portably (Bug#8435).
6011 Without this change, on typical 64-bit hosts error ("...%d...", N)
6012 was used to print both 32- and 64-bit integers N, which relied on
6014 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6016 * lisp.h (error, verror): Mark as printf-like functions.
6017 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6018 Report overflow in size calculations when allocating printf buffer.
6019 Do not truncate output string at its first null byte.
6020 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6021 Truncate the output at a character boundary, since vsnprintf does not
6023 * charset.c (check_iso_charset_parameter): Convert internal
6024 character to string before calling 'error', since %c now has the
6026 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6027 overflow when computing char to be passed to 'error'. Do not
6028 pass Lisp_Object to 'error'; pass the integer instead.
6029 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6030 formatted with plain %d.
6032 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6034 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6036 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6038 * xterm.c (x_catch_errors): Remove duplicate declaration.
6040 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6042 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6044 2011-04-10 Jim Meyering <meyering@redhat.com>
6046 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6047 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6048 return ssize_t not "int", and use size_t as the buffer length.
6049 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6050 * gnutls.h: Update declarations.
6051 * process.c (read_process_output): Use ssize_t, to match.
6052 (send_process): Likewise.
6054 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6056 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6058 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6060 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6061 Use unsigned char, to match FcChar8 type definition.
6063 * xterm.c (handle_one_xevent):
6064 * xmenu.c (create_and_show_popup_menu):
6065 * xselect.c (x_decline_selection_request)
6066 (x_reply_selection_request): Avoid type-punned deref of X events.
6068 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6070 Fix some uses of `int' instead of EMACS_INT.
6071 * search.c (string_match_1, fast_string_match)
6072 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6073 (scan_buffer, find_next_newline_no_quit)
6074 (find_before_next_newline, search_command, Freplace_match)
6075 (Fmatch_data): Make some `int' variables be EMACS_INT.
6077 * xdisp.c (display_count_lines): 3rd argument and return value now
6078 EMACS_INT. All callers changed.
6079 (pint2hrstr): Last argument is now EMACS_INT.
6081 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6082 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6083 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6084 (decode_coding_utf_16, decode_coding_emacs_mule)
6085 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6086 (decode_coding_ccl, decode_coding_charset)
6087 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6088 (decode_coding_iso_2022, decode_coding_emacs_mule)
6089 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6090 <char_offset, last_offset>: Declare EMACS_INT.
6091 (encode_coding_utf_8, encode_coding_utf_16)
6092 (encode_coding_emacs_mule, encode_invocation_designation)
6093 (encode_designation_at_bol, encode_coding_iso_2022)
6094 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6095 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6097 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6098 (encode_invocation_designation): Last argument P_NCHARS is now
6100 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6101 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6103 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6106 * ccl.c (Fccl_execute_on_string): Declare some variables
6109 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6111 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6113 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6115 * process.c (Fformat_network_address): Doc fix.
6117 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6119 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6121 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6123 * keyboard.c (read_char): Call Lisp function help-form-show,
6124 instead of using internal_with_output_to_temp_buffer.
6125 (Qhelp_form_show): New var.
6126 (syms_of_keyboard): Use DEFSYM macro.
6128 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6130 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6132 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6134 * process.c (Flist_processes): Remove to Lisp.
6135 (list_processes_1): Delete.
6137 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6139 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6141 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6143 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6145 Fix more problems found by GCC 4.6.0's static checks.
6147 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6149 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6151 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6153 * xdisp.c (vmessage): Mark as a printf-like function.
6155 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6157 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6159 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6160 printf-like functions.
6161 (tiff_load): Add casts to remove these marks before passing them
6162 to system-supplied API.
6164 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6166 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6167 This avoids several warnings with gcc -Wstrict-overflow.
6168 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6169 directly, rather than having caller test rule sign. This avoids
6170 some unnecessary tests.
6171 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6172 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6173 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6175 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6176 (xfont_open): Avoid unnecessary tests.
6178 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6180 * composite.h, composite.c (composition_gstring_put_cache):
6181 Use EMACS_INT, not int, for length.
6183 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6184 breaking out part of COMPOSITION_DECODE_RULE.
6185 (COMPOSITION_DECODE_RULE): Use it.
6186 * composite.c (get_composition_id): Remove unused local vars,
6187 by using the new macro.
6189 * textprop.c (set_text_properties_1): Change while to do-while,
6190 since the condition is always true at first.
6192 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6193 (interval_deletion_adjustment): Return unsigned value.
6196 * process.c (list_processes_1, create_pty, read_process_output):
6197 (exec_sentinel): Remove vars that were set but not used.
6198 (create_pty): Remove unnecessary "volatile"s.
6199 (Fnetwork_interface_info): Avoid possibility of int overflow.
6200 (read_process_output): Do adaptive read buffering even if carryover.
6201 (read_process_output): Simplify nbytes computation if buffered.
6203 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6205 * syntax.c (scan_words): Remove var that was set but not used.
6206 (update_syntax_table): Use unsigned instead of int.
6208 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6209 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6210 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6212 * print.c (print_error_message): Avoid int overflow.
6214 * font.c (font_list_entities): Redo for clarity,
6215 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6217 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6218 (font_score): Avoid potential overflow in diff calculation.
6220 * fns.c (substring_both): Remove var that is set but not used.
6221 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6223 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6225 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6226 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6227 can always succeed if overflow has undefined behavior.
6229 * search.c (boyer_moore, wordify): Remove vars set but not used.
6230 (wordify): Omit three unnecessary tests.
6232 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6233 All callers changed. This avoids the need for an unused var.
6235 * casefiddle.c (casify_region): Remove var that is set but not used.
6237 * dired.c (file_name_completion): Remove var that is set but not used.
6239 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6241 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6242 (Finsert_file_contents): Remove unnecessary code checking fd.
6244 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6245 Check for integer overflow on size calculations.
6247 * buffer.c (Fprevious_overlay_change): Remove var that is set
6250 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6251 Remove vars that are set but not used.
6252 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6253 (timer_check_2): Mark vars as initialized.
6255 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6257 * image.c (lookup_image): Remove var that is set but not used.
6258 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6260 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6261 that are set but not used.
6263 * xfns.c (make_invisible_cursor): Don't return garbage
6264 if XCreateBitmapFromData fails (Bug#8410).
6266 * xselect.c (x_get_local_selection, x_handle_property_notify):
6267 Remove vars that are set but not used.
6269 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6270 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6272 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6273 Remove var that is set but not used.
6274 (scroll_bar_windows_size): Now size_t, not int.
6275 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6278 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6279 (map_tty_color) [!defined MSDOS]: Likewise.
6281 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6283 * coding.c: Remove vars that are set but not used.
6284 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6285 All callers changed.
6286 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6287 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6288 (decode_coding_charset): Remove vars that are set but not used.
6290 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6291 that is set but not used.
6293 * print.c (print_object): Remove var that is set but not used.
6295 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6296 The gnulib version avoids calling malloc in the usual case,
6297 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6298 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6299 * filelock.c (current_lock_owner): Likewise.
6300 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6301 * sysdep.c: Include allocator.h, careadlinkat.h.
6302 (emacs_no_realloc_allocator): New static constant.
6303 (emacs_readlink): New function.
6304 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6305 ../lib/careadlinkat.h.
6307 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6309 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6310 first non-nil return value).
6312 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6314 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6315 if not defined (Bug#8403).
6317 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6319 * xdisp.c (display_count_lines): Remove parameter `start',
6320 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6321 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6322 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6323 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6324 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6325 and thereabouts. All callers changed.
6326 (get_per_char_metric): Remove parameter `f', unused since
6327 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6329 2011-04-02 Jim Meyering <meyering@redhat.com>
6331 do not dereference NULL upon failed strdup
6332 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6333 (ns_get_family): Likewise.
6335 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6337 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6339 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6341 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6344 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6346 Add lexical binding.
6348 * window.c (Ftemp_output_buffer_show): New fun.
6349 (Fsave_window_excursion):
6350 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6352 * lread.c (lisp_file_lexically_bound_p): New function.
6353 (Fload): Bind Qlexical_binding.
6354 (readevalloop): Remove `evalfun' arg.
6355 Bind Qinternal_interpreter_environment.
6356 (Feval_buffer): Bind Qlexical_binding.
6357 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6359 (syms_of_lread): Declare `lexical-binding'.
6361 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6363 * keyboard.c (eval_dyn): New fun.
6364 (menu_item_eval_property): Use it.
6366 * image.c (parse_image_spec): Use Ffunctionp.
6368 * fns.c (concat, mapcar1): Accept byte-code-functions.
6370 * eval.c (Fsetq): Handle lexical vars.
6371 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6372 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6373 (FletX, Flet): Obey lexical binding.
6374 (Fcommandp): Handle closures.
6375 (Feval): New `lexical' arg.
6376 (eval_sub): New function extracted from Feval. Use it almost
6377 everywhere where Feval was used. Look up vars in lexical env.
6379 (Ffunctionp): Move from subr.el.
6380 (Ffuncall): Handle closures.
6381 (apply_lambda): Remove `eval_flags'.
6382 (funcall_lambda): Handle closures and new byte-code-functions.
6383 (Fspecial_variable_p): New function.
6384 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6385 but without exporting it to Lisp.
6387 * doc.c (Fdocumentation, store_function_docstring):
6388 * data.c (Finteractive_form): Handle closures.
6390 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6393 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6395 (exec_byte_code): New function extracted from Fbyte_code to handle new
6396 calling convention for byte-code-functions. Add new byte-codes.
6398 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6400 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6402 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6404 * xdisp.c (redisplay_internal): Fix prototype.
6406 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6408 * xdisp.c (SCROLL_LIMIT): New macro.
6409 (try_scrolling): Use it when setting scroll_limit.
6410 Limit scrolling to 100 screen lines.
6411 (redisplay_window): Even when falling back on "recentering",
6412 position point in the window according to scroll-conservatively,
6413 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6415 (try_scrolling): When point is above the window, allow searching
6416 as far as scroll_max, or one screenful, to compute vertical
6417 distance from PT to the scroll margin position. This prevents
6418 try_scrolling from unnecessarily failing when
6419 scroll-conservatively is set to a value slightly larger than the
6420 window height. Clean up the case of PT below the margin at bottom
6421 of window: scroll_max can no longer be INT_MAX. When aggressive
6422 scrolling is in use, don't let point enter the opposite scroll
6423 margin as result of the scroll.
6424 (syms_of_xdisp) <scroll-conservatively>: Document the
6425 threshold of 100 lines for never-recentering scrolling.
6427 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6429 * dispextern.h (move_it_by_lines):
6430 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6431 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6432 (message_log_check_duplicate): Remove parameters `prev_bol' and
6433 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6434 (redisplay_internal): Remove parameter `preserve_echo_area',
6435 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6437 * indent.c (Fvertical_motion):
6438 * window.c (window_scroll_pixel_based, Frecenter):
6439 Don't pass `need_y_p' to `move_it_by_lines'.
6441 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6443 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6444 steal a few bits to be more compact.
6445 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6446 Remove unneeded casts.
6448 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6450 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6452 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6453 binding" message (bug#7967).
6455 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6457 Fix more problems found by GCC 4.6.0's static checks.
6459 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6460 Remove unused local var.
6462 * editfns.c (Fmessage_box): Remove unused local var.
6464 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6465 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6466 Omit unused local vars.
6467 * window.c (shrink_windows): Omit unused local var.
6468 * menu.c (digest_single_submenu): Omit unused local var.
6469 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6470 Omit unused local var.
6472 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6473 Don't assume string length fits in int.
6474 (keyremap_step, read_key_sequence): Use size_t for sizes.
6475 (read_key_sequence): Don't check last_real_key_start redundantly.
6477 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6478 instead of alloca (Bug#8344).
6480 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6481 (Fbacktrace_frame): Don't assume nframes fits in int.
6483 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6485 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6488 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6490 * cm.c (calccost): Turn while-do into do-while, for clarity.
6492 * keyboard.c (syms_of_keyboard): Use the same style as later
6493 in this function when indexing through an array. This also
6494 works around GCC bug 48267.
6496 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6498 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6500 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6501 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6503 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6504 This avoids undefined behavior on integer overflow, and is a bit
6505 more convenient anyway since it is compared to a size_t variable.
6507 Variadic C functions now count arguments with size_t, not int.
6508 This avoids an unnecessary limitation on 64-bit machines, which
6509 caused (substring ...) to crash on large vectors (Bug#8344).
6510 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6511 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6512 All variadic functions and their callers changed accordingly.
6513 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6514 * data.c (arith_driver, float_arith_driver): Likewise.
6515 * editfns.c (general_insert_function): Likewise.
6516 * eval.c (struct backtrace.nargs, interactive_p)
6517 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6518 (funcall_lambda, mark_backtrace): Likewise.
6519 * fns.c (concat): Likewise.
6520 * frame.c (x_set_frame_parameters): Likewise.
6521 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6522 0 if not found, not -1. All callers changed.
6524 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6525 (stack_copy_size): Now size_t, not int.
6526 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6528 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6530 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6531 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6532 All callers changed.
6534 * lisp.h (multibyte_char_to_unibyte):
6535 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6536 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6537 * character.h (CHAR_TO_BYTE8):
6538 * cmds.c (internal_self_insert):
6539 * editfns.c (general_insert_function):
6540 * keymap.c (push_key_description):
6541 * search.c (Freplace_match):
6542 * xdisp.c (message_dolog, set_message_1): All callers changed.
6544 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6546 * keyboard.c (safe_run_hook_funcall): New function.
6547 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6548 don't set the hook to nil, but remove the offending function instead.
6549 (Qcommand_hook_internal): Remove, unused.
6550 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6551 Vcommand_hook_internal.
6553 * eval.c (enum run_hooks_condition): Remove.
6554 (funcall_nil, funcall_not): New functions.
6555 (run_hook_with_args): Call each function through a `funcall' argument.
6556 Remove `cond' argument, now redundant.
6557 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6558 (Frun_hook_with_args_until_failure): Adjust accordingly.
6559 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6561 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6563 * dispextern.h (string_buffer_position): Remove declaration.
6565 * print.c (strout): Remove parameter `multibyte', unused since
6566 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6568 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6569 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6570 All callers changed.
6572 * w32.c (_wsa_errlist): Use braces for struct initializers.
6574 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6575 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6576 All callers changed.
6577 (string_buffer_position): Likewise. Also, make static (it's never
6578 used outside xdisp.c).
6579 (cursor_row_p): Remove parameter `w', unused since
6580 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6581 (decode_mode_spec): Remove parameter `precision', introduced during
6582 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6583 All callers changed.
6585 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6587 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6589 2011-03-27 Anders Lindgren <andlind@gmail.com>
6591 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6592 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6593 (ns_update_auto_hide_menu_bar): New functions.
6594 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6595 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6596 ns_constrain_all_frames.
6597 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6598 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6600 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6602 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6604 2011-03-27 Glenn Morris <rgm@gnu.org>
6606 * syssignal.h: Replace RETSIGTYPE with void.
6607 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6608 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6609 Replace SIGTYPE with void everywhere.
6610 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6611 * s/template.h (SIGTYPE): Remove commented out definition.
6613 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6615 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6616 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6618 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6620 * w32.c (read_unc_volume): Use parameter `henum', instead of
6621 global variable `wget_enum_handle'.
6623 * keymap.c (describe_vector): Remove parameters `indices' and
6624 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6625 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6627 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6629 * keyboard.c (timer_check): Remove parameter `do_it_now',
6630 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6631 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6632 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6634 * keyboard.c (read_char):
6635 * w32menu.c (w32_menu_display_help):
6636 * xmenu.c (show_help_event, menu_help_callback):
6637 Adjust calls to `show_help_echo'.
6639 * gtkutil.c (xg_maybe_add_timer):
6640 * keyboard.c (readable_events):
6641 * process.c (wait_reading_process_output):
6642 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6644 * insdel.c (adjust_markers_gap_motion):
6645 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6646 (gap_left, gap_right): Don't call it.
6648 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6650 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6651 incurred during fontification.
6653 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6655 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6656 (DEFVAR_PER_BUFFER): Don't pass it.
6658 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6659 (scrolling_window): Don't pass it.
6661 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6663 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6665 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6667 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6668 of variables specific to SELinux and computation of `encoded_absname'.
6670 * image.c (XPutPixel): Remove unused variable `height'.
6672 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6674 * unexw32.c (get_section_info): Remove unused variable `section'.
6676 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6677 (system_process_attributes): Remove unused variable `sess'.
6678 (sys_read): Remove unused variable `err'.
6680 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6681 (w32_wnd_proc): Remove unused variable `isdead'.
6682 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6683 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6684 (x_create_tip_frame): Remove unused variable `tem'.
6686 * w32inevt.c (w32_console_read_socket):
6687 Remove unused variable `no_events'.
6689 * w32term.c (x_draw_composite_glyph_string_foreground):
6690 Remove unused variable `width'.
6692 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6694 * w32term.c (x_set_glyph_string_clipping):
6695 Don't pass uninitialized region to CombineRgn.
6697 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6699 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6700 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6701 (Fx_close_connection): Remove unused variable `i'.
6703 * w32font.c (w32font_draw): Return number of glyphs.
6704 (w32font_open_internal): Remove unused variable `i'.
6705 (w32font_driver): Add missing initializer.
6707 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6708 (fill_in_menu): Remove unused variable `items_added'.
6710 * w32term.c (last_mouse_press_frame): Remove static global variable.
6711 (w32_clip_to_row): Remove unused variable `f'.
6712 (x_delete_terminal): Remove unused variable `i'.
6714 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6715 (NOTHING): Remove unused static global variable.
6716 (uniscribe_check_otf): Remove unused variable `table'.
6717 (uniscribe_font_driver): Add missing initializers.
6719 2011-03-23 Julien Danjou <julien@danjou.info>
6721 * term.c (Fsuspend_tty, Fresume_tty):
6722 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6723 * window.c (temp_output_buffer_show):
6724 * insdel.c (signal_before_change):
6725 * frame.c (Fhandle_switch_frame):
6726 * fileio.c (Fdo_auto_save):
6727 * emacs.c (Fkill_emacs):
6728 * editfns.c (save_excursion_restore):
6729 * cmds.c (internal_self_insert):
6730 * callint.c (Fcall_interactively):
6731 * buffer.c (Fkill_all_local_variables):
6732 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6734 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6735 unconditionnaly since it does the check itself.
6737 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6739 Fix more problems found by GCC 4.5.2's static checks.
6741 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6742 the first time through the loop, since we know p0 < p1 then.
6743 This also avoids a gcc -Wstrict-overflow warning.
6745 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6746 leading to a memory leak, possible in functions like
6747 load_charset_map_from_file that can allocate an unbounded number
6748 of objects (Bug#8318).
6750 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6751 that could (at least in theory) be that large.
6753 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6754 This is less likely to overflow, and avoids undefined behavior if
6755 overflow does occur. All callers changed. Use strtoul to scan
6756 for the unsigned long integer.
6757 (pint2hrstr): Simplify and tune code slightly.
6758 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6760 * scroll.c (do_scrolling): Work around GCC bug 48228.
6761 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6763 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6764 This also avoids a warning with gcc -Wstrict-overflow.
6765 (validate_x_resource_name): Simplify count usage.
6766 This also avoids a warning with gcc -Wstrict-overflow.
6768 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6771 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6773 * process.c (Fmake_network_process): Use socklen_t, not int,
6774 where POSIX says socklen_t is required in portable programs.
6775 This fixes a porting bug on hosts like 64-bit HP-UX, where
6776 socklen_t is wider than int (Bug#8277).
6777 (Fmake_network_process, server_accept_connection):
6778 (wait_reading_process_output, read_process_output):
6781 * process.c: Rename or move locals to avoid shadowing.
6782 (list_processes_1, Fmake_network_process):
6783 (read_process_output_error_handler, exec_sentinel_error_handler):
6784 Rename or move locals.
6785 (Fmake_network_process): Define label "retry_connect" only if needed.
6786 (Fnetwork_interface_info): Fix pointer signedness.
6787 (process_send_signal): Add cast to avoid pointer signedness problem.
6788 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6789 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6791 Make tparam.h and terminfo.c consistent.
6792 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6793 Include tparam.h instead, since it declares them.
6794 * cm.h (PC): Remove extern decl; tparam.h now does this.
6795 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6796 * terminfo.c: Include tparam.h, to check interfaces.
6797 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6798 (tparam): Adjust signature to match interface in tparam.h;
6799 this removes some undefined behavior. Check that outstring and len
6800 are zero, which they always are with Emacs.
6801 * tparam.h (PC, BC, UP): New extern decls.
6803 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6804 (xftfont_open): Rename locals to avoid shadowing.
6806 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6807 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6808 (OTF_TAG_SYM): Omit macro if not needed.
6809 (ftfont_list): Remove unused local.
6810 (get_adstyle_property, ftfont_pattern_entity):
6811 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6812 Rename locals to avoid shadowing.
6814 * xfont.c (xfont_list_family): Mark var as initialized.
6816 * xml.c (make_dom): Now static.
6818 * composite.c (composition_compute_stop_pos): Rename local to
6820 (composition_reseat_it): Remove unused locals.
6821 (find_automatic_composition, composition_adjust_point): Likewise.
6822 (composition_update_it): Mark var as initialized.
6823 (find_automatic_composition): Mark vars as initialized,
6824 with a FIXME (Bug#8290).
6826 character.h: Rename locals to avoid shadowing.
6827 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6828 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6829 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6830 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6833 * textprop.c (property_change_between_p): Remove; unused.
6835 * intervals.c (interval_start_pos): Now static.
6837 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6839 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6840 Rename locals to avoid shadowing.
6842 * sound.c (wav_play, au_play, Fplay_sound_internal):
6843 Fix pointer signedness.
6844 (alsa_choose_format): Remove unused local var.
6845 (wav_play): Initialize a variable to 0, to prevent undefined
6846 behavior (Bug#8278).
6848 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6850 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6852 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6853 clobbering (Bug#8298).
6854 * sysdep.c (sys_subshell): Likewise.
6855 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6857 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6858 This should get cleaned up, so that child_setup has the
6859 same signature on all platforms.
6861 * callproc.c (call_process_cleanup): Now static.
6862 (relocate_fd): Rename locals to avoid shadowing.
6864 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6866 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6867 not to be necessary, and produces flickering.
6869 2011-03-20 Glenn Morris <rgm@gnu.org>
6871 * config.in: Remove file.
6873 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6875 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6876 are now in src/globals.h.
6877 (syms_of_minibuf): Remove spurious & from previous change.
6879 2011-03-20 Leo <sdl.web@gmail.com>
6881 * minibuf.c (completing-read-function): New variable.
6882 (completing-read-default): Rename from completing-read.
6883 (completing-read): Call completing-read-function.
6885 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6887 * xfaces.c (Fx_load_color_file):
6888 Read color file from absolute filename (bug#8250).
6890 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6892 * makefile.w32-in: Update dependencies.
6894 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6896 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6898 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6900 Fix more problems found by GCC 4.5.2's static checks.
6902 * process.c (make_serial_process_unwind, send_process_trap):
6903 (sigchld_handler): Now static.
6905 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6906 That way, the code declares only the vars that it needs.
6907 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6908 * s/cygwin.h (PTY_ITERATION): Likewise.
6909 * s/darwin.h (PTY_ITERATION): Likewise.
6910 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6912 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6913 * process.c (allocate_pty): Don't declare stb unless it's needed.
6915 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6916 (CONSTANTLIM): Remove; unused.
6917 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6918 Define only if needed.
6920 * unexelf.c (unexec): Name an expression,
6921 to avoid gcc -Wbad-function-cast warning.
6922 Use a different way to cause a compilation error if anyone uses
6923 n rather than nn, a way that does not involve shadowing.
6924 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6926 * deps.mk (unexalpha.o): Remove; unused.
6928 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6929 * unexec.h: New file.
6930 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6931 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6933 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6934 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6935 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6936 Change as necessary to match prototype in unexec.h.
6938 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6940 (back_comment, skip_chars): Mark vars as initialized.
6942 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6943 Rename locals to avoid shadowing.
6945 * lread.c (read1): Rewrite so as not to use empty "else".
6946 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6948 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6950 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6951 warning when compiling print.c.
6953 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6954 instead of using an uninitialized var.
6955 (font_sort_entities): Mark var as initialized.
6957 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6959 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6960 pointers to constants.
6961 (font_parse_fcname): Remove unused vars.
6962 (font_delete_unmatched): Now static.
6963 (font_get_spec): Remove; unused.
6964 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6965 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6966 Rename or move locals to avoid shadowing.
6968 * fns.c (require_nesting_list, require_unwind): Now static.
6969 (Ffillarray): Rename locals to avoid shadowing.
6971 * floatfns.c (domain_error2): Define only if needed.
6972 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6974 * alloc.c (mark_backtrace): Move decl from here ...
6975 * lisp.h: ... to here, so that it can be checked.
6977 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6978 (Fdefvar): Rewrite so as not to use empty "else".
6979 (lisp_indirect_variable): Name an expression,
6980 to avoid gcc -Wbad-function-cast warning.
6981 (Fdefvar): Rename locals to avoid shadowing.
6983 * callint.c (quotify_arg, quotify_args): Now static.
6984 (Fcall_interactively): Rename locals to avoid shadowing.
6985 Use const pointer when appropriate.
6987 * lisp.h (get_system_name, get_operating_system_release):
6988 Move decls here, to check interfaces.
6989 * process.c (get_operating_system_release): Move decl to lisp.h.
6990 * xrdb.c (get_system_name): Likewise.
6991 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6992 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6993 some of which prompt warnings from gcc -Wbad-function-cast.
6994 (Fformat_time_string, Fencode_time, Finsert_char):
6995 (Ftranslate_region_internal, Fformat):
6996 Rename or remove local vars to avoid shadowing.
6997 (Ftranslate_region_internal): Mark var as initialized.
6999 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7002 * lisp.h (eassert): Check that the argument compiles, even if
7003 ENABLE_CHECKING is not defined.
7005 * data.c (Findirect_variable): Name an expression, to avoid
7006 gcc -Wbad-function-cast warning.
7007 (default_value, arithcompare, arith_driver, arith_error): Now static.
7008 (store_symval_forwarding): Rename local to avoid shadowing.
7009 (Fmake_variable_buffer_local, Fmake_local_variable):
7010 Mark variables as initialized.
7011 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7013 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7014 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7015 Rename locals to avoid shadowing.
7016 (mark_stack): Move local variables into the #ifdef region where
7018 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7019 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7021 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7022 (GC_STRING_CHARS): Remove; not used.
7023 (Fmemory_limit): Cast sbrk's returned value to char *.
7025 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7026 avoids undefined behavior in theory.
7028 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7030 Use functions, not macros, for up- and down-casing (Bug#8254).
7031 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7032 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7033 to use the following functions instead of these macros.
7034 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7035 EMACS_INT, since callers assume the returned value fits in int.
7036 (upcase1): Likewise, for UPCASE_TABLE.
7037 (uppercasep, lowercasep, upcase): New static inline functions.
7038 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7039 the race-condition problem in the old DOWNCASE.
7041 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7042 Rename locals to avoid shadowing.
7043 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7044 (regex_compile, re_search_2, re_match_2_internal):
7045 Remove unused local vars.
7046 (FREE_VAR): Rewrite so as not to use empty "else",
7047 which gcc can warn about.
7048 (regex_compile, re_match_2_internal): Mark locals as initialized.
7049 (RETALLOC_IF): Define only if needed.
7050 (WORDCHAR_P): Likewise. This one is never needed, but is used
7051 only in a comment talking about a compiler bug, so put inside
7052 the #if 0 of that comment.
7053 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7054 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7057 * search.c (boyer_moore): Rename locals to avoid shadowing.
7058 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7059 (PREV_CHAR_BOUNDARY): Likewise.
7061 * search.c (simple_search): Remove unused var.
7063 * dired.c (compile_pattern): Move decl from here ...
7064 * lisp.h: ... to here, so that it can be checked.
7065 (struct re_registers): New forward decl.
7067 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7069 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7071 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7072 Rename locals to avoid shadowing.
7073 (Fvertical_motion): Mark locals as initialized.
7075 * casefiddle.c (casify_object, casify_region): Now static.
7076 (casify_region): Mark local as initialized.
7078 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7080 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7081 New macros, so that the caller can use some names other than
7082 gcpro1, gcpro2, etc.
7083 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7085 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7086 argument, for consistency with GCPRO2_VAR, etc: it is now the
7087 prefix of the variable, not the variable itself. All uses
7089 * dired.c (directory_files_internal, file_name_completion):
7090 Rename locals to avoid shadowing.
7092 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7093 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7094 dired.c's scmp function, had undefined behavior.
7095 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7096 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7097 * buffer.h: ... to here, because these macros use current_buffer,
7098 and the new implementation with inline functions needs to have
7099 current_buffer in scope now, rather than later when the macros
7101 (downcase, upcase1): New static inline functions.
7102 (DOWNCASE, UPCASE1): Reimplement using these functions.
7103 This avoids undefined behavior in expressions like
7104 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7105 from race conditions in accessing the global variables
7106 case_temp1 and case_temp2.
7107 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7108 * lisp.h (case_temp1, case_temp2): Remove their decls.
7109 * character.h (ASCII_CHAR_P): Move from here ...
7110 * lisp.h: ... to here, so that the inline functions mentioned
7113 * dired.c (directory_files_internal_unwind): Now static.
7115 * fileio.c (file_name_as_directory, directory_file_name):
7116 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7118 (file_name_as_directory): Use const pointers when appropriate.
7119 (Fexpand_file_name): Likewise. In particular, newdir might
7120 point at constant storage, so make it a const pointer.
7121 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7122 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7124 (Fset_file_times, Finsert_file_contents, auto_save_error):
7125 Rename locals to avoid shadowing.
7127 * minibuf.c (choose_minibuf_frame_1): Now static.
7128 (Ftry_completion, Fall_completions): Rename or remove locals
7131 * marker.c (bytepos_to_charpos): Remove; unused.
7133 * lisp.h (verify_bytepos, count_markers): New decls,
7134 so that gcc does not warn that these functions aren't declared.
7136 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7137 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7138 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7139 (copy_text): Remove unused local var.
7141 * filelock.c (within_one_second): Now static.
7142 (lock_file_1): Rename local to avoid shadowing.
7144 * buffer.c (fix_overlays_before): Mark locals as initialized.
7145 (fix_start_end_in_overlays): Likewise. This function should be
7146 simplified by using pointers-to-pointers, but that's a different
7148 (switch_to_buffer_1): Now static.
7149 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7150 (report_overlay_modification): Rename locals to avoid shadowing.
7152 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7153 Fix pointer signedness issue.
7154 (sys_subshell): Mark local as volatile if checking for lint,
7155 to suppress a gcc -Wclobbered warning that does not seem to be right.
7156 (MAXPATHLEN): Define only if needed.
7158 * process.c (serial_open, serial_configure): Move decls from here ...
7159 * systty.h: ... to here, so that they can be checked.
7161 * fns.c (get_random, seed_random): Move extern decls from here ...
7162 * lisp.h: ... to here, so that they can be checked.
7164 * sysdep.c (reset_io): Now static.
7165 (wait_for_termination_signal): Remove; unused.
7167 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7168 (copy_keymap_item, append_key, push_text_char_description):
7170 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7171 (DENSE_TABLE_SIZE): Remove; unused.
7172 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7173 (describe_map_tree):
7174 Rename locals to avoid shadowing.
7176 * keyboard.c: Declare functions static if they are not used elsewhere.
7177 (echo_char, echo_dash, cmd_error, top_level_2):
7178 (poll_for_input, handle_async_input): Now static.
7179 (read_char, kbd_buffer_get_event, make_lispy_position):
7180 (make_lispy_event, make_lispy_movement, apply_modifiers):
7181 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7182 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7183 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7184 (read_key_sequence, read_char): Mark locals as initialized.
7185 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7187 * keyboard.h (make_ctrl_char): New decl.
7188 (mark_kboards): Move decl here ...
7189 * alloc.c (mark_kboards): ... from here.
7191 * lisp.h (force_auto_save_soon): New decl.
7193 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7194 (DEFINE_DUMMY_FUNCTION): New macro.
7195 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7197 (main): Add casts to avoid warnings
7198 if GCC considers string literals to be constants.
7200 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7202 * dbusbind.c: Pointer signedness fixes.
7203 (xd_signature, xd_append_arg, xd_initialize):
7204 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7205 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7206 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7207 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7209 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7210 if GCC considers string literals to be constants.
7211 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7213 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7215 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7216 (print_preprocess, print_object): New macro to fix last change.
7218 * print.c (print_preprocess): Don't forget font objects.
7220 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7222 * emacs.c (USAGE3): Doc fixes.
7224 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7226 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7229 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7231 * lisp.h (VWindow_system, Qfile_name_history):
7232 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7233 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7234 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7236 * w32select.c: Don't #include "keyboard.h".
7237 (run_protected): Add extern declaration for waiting_for_input.
7239 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7240 * w32console.c (detect_input_pending, read_input_pending)
7241 (encode_terminal_code):
7242 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7243 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7244 (w32_system_caret_y, Qfile_name_history):
7245 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7246 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7247 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7248 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7249 * w32proc.c (Qlocal, report_file_error):
7250 * w32term.c (Vwindow_system, updating_frame):
7251 * w32uniscribe.c (initialized, uniscribe_font_driver):
7252 Remove unneeded extern declarations.
7254 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7256 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7258 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7260 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7261 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7262 These macros can no longer be used for assignment.
7264 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7265 Assign struct members directly, instead of using BUF_BEGV etc.
7266 (record_buffer_markers, fetch_buffer_markers): New functions for
7267 recording and fetching special buffer markers.
7268 (set_buffer_internal_1, set_buffer_temp): Use them.
7270 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7272 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7274 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7275 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7277 * xdisp.c (hscroll_window_tree):
7278 (reconsider_clip_changes): Use PT instead of BUF_PT.
7280 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7282 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7283 $(EMACS_ROOT)/lib/intprops.h.
7285 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7287 Fix more problems found by GCC 4.5.2's static checks.
7289 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7290 to unsigned char * to avoid compiler diagnostic.
7291 (xg_free_frame_widgets): Make it clear that a local variable is
7292 needed only if USE_GTK_TOOLTIP.
7293 (gdk_window_get_screen): Make it clear that this macro is needed
7294 only if USE_GTK_TOOLTIP.
7295 (int_gtk_range_get_value): New function, which avoids a diagnostic
7296 from gcc -Wbad-function-cast.
7297 (xg_set_toolkit_scroll_bar_thumb): Use it.
7298 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7299 diagnostic from gcc -Wbad-function-cast.
7300 (get_utf8_string, xg_get_file_with_chooser):
7301 Rename locals to avoid shadowing.
7302 (create_dialog): Move locals to avoid shadowing.
7304 * xgselect.c (xg_select): Remove unused var.
7306 * image.c (four_corners_best): Mark locals as initialized.
7307 (gif_load): Initialize transparent_p to zero (Bug#8238).
7308 Mark another local as initialized.
7309 (my_png_error, my_error_exit): Mark with NO_RETURN.
7311 * image.c (clear_image_cache): Now static.
7312 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7313 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7314 (x_edge_detection): Remove unnecessary cast that
7315 gcc -Wbad-function-cast diagnoses.
7316 (gif_load): Fix pointer signedness.
7317 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7318 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7320 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7322 Improve quality of tests for time stamp overflow.
7323 For example, without this patch (encode-time 0 0 0 1 1
7324 1152921504606846976) returns the obviously-bogus value (-948597
7325 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7326 reports time overflow. See
7327 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7328 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7329 * editfns.c: Include limits.h and intprops.h.
7330 (TIME_T_MIN, TIME_T_MAX): New macros.
7331 (time_overflow): Move earlier, to before first use.
7332 (hi_time, lo_time): New functions, for an accurate test for
7334 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7335 (Fget_internal_run_time): Don't assume time_t fits in int.
7336 (make_time): Use list2 instead of Fcons twice.
7337 (Fdecode_time): More accurate test for out-of-range times.
7338 (check_tm_member): New function.
7339 (Fencode_time): Use it, to test for out-of-range times.
7340 (lisp_time_argument): Don't rely on undefined left-shift and
7341 right-shift behavior when checking for time stamp overflow.
7343 * editfns.c (time_overflow): New function, refactoring common code.
7344 (Fformat_time_string, Fdecode_time, Fencode_time):
7345 (Fcurrent_time_string): Use it.
7347 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7348 * dired.c (make_time): Move to ...
7349 * editfns.c (make_time): ... here.
7350 * systime.h: Note the move.
7352 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7354 * fringe.c (update_window_fringes): Remove unused variables.
7356 * unexmacosx.c (copy_data_segment): Also copy __got section.
7359 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7361 * termcap.c [MSDOS]: Include "msdos.h".
7362 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7363 Constify `char *' arguments and their references according to
7364 prototypes in tparam.h.
7366 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7368 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7369 Adapt all references accordingly.
7371 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7373 2011-03-11 Tom Tromey <tromey@redhat.com>
7375 * buffer.c (syms_of_buffer): Remove obsolete comment.
7377 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7379 * termhooks.h (encode_terminal_code): Declare prototype.
7381 * msdos.c (encode_terminal_code): Don't declare prototype.
7383 * term.c (encode_terminal_code): Now external again, used by
7384 w32console.c and msdos.c.
7386 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7387 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7389 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7391 Fix some minor problems found by GCC 4.5.2's static checks.
7393 * fringe.c (update_window_fringes): Mark locals as initialized
7395 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7397 * alloc.c (mark_fringe_data): Move decl from here ...
7398 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7399 to check its interface.
7400 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7402 * fontset.c (free_realized_fontset): Now static.
7403 (Fset_fontset_font): Rename local to avoid shadowing.
7404 (fontset_font): Mark local as initialized.
7405 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7407 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7409 * xselect.c (x_disown_buffer_selections): Remove; not used.
7410 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7411 (x_own_selection, Fx_disown_selection_internal): Rename locals
7413 (x_handle_dnd_message): Remove local to avoid shadowing.
7415 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7416 so that the caller can use some name other than gcpro1.
7417 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7418 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7419 (Fx_backspace_delete_keys_p):
7420 Use them to avoid shadowing, and rename vars to avoid shadowing.
7421 (x_decode_color, x_set_name, x_window): Now static.
7422 (Fx_create_frame): Add braces to silence GCC warning.
7423 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7424 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7425 Remove unused locals.
7426 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7427 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7428 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7431 * xterm.h (x_mouse_leave): New decl.
7433 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7434 Remove unused functions.
7435 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7436 (x_calc_absolute_position): Now static.
7437 (XTread_socket): Don't define label "out" unless it's used.
7438 Don't declare local "event" unless it's used.
7439 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7440 unless they are used.
7441 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7442 (x_fatal_error_signal): Remove; not used.
7443 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7444 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7445 (x_error_catcher, x_connection_closed, x_error_handler):
7446 (x_error_quitter, xembed_send_message, x_iconify_frame):
7447 (my_log_handler): Rename locals to avoid shadowing.
7448 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7449 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7451 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7452 Rename or move locals to avoid shadowing.
7453 (tty_defined_color, merge_face_heights): Now static.
7454 (free_realized_faces_for_fontset): Remove; not used.
7455 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7456 does not deduce is never used uninitialized.
7457 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7458 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7460 * terminal.c (store_terminal_param): Now static.
7462 * xmenu.c (menu_highlight_callback): Now static.
7463 (set_frame_menubar): Remove unused local.
7464 (xmenu_show): Rename parameter to avoid shadowing.
7465 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7466 since they might point to immutable storage.
7467 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7468 since it's unused otherwise.
7470 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7471 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7472 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7473 avoids a gcc -Wuninitialized diagnostic.
7474 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7475 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7476 does not deduce are never used uninitialized.
7478 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7480 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7481 * window.c (window_loop, size_window):
7482 (run_window_configuration_change_hook, enlarge_window): Likewise.
7484 * window.c (display_buffer): Now static.
7485 (size_window): Mark variables that gcc -Wuninitialized
7486 does not deduce are never used uninitialized.
7487 * window.h (check_all_windows): New decl, to forestall
7488 gcc -Wmissing-prototypes diagnostic.
7489 * dispextern.h (bidi_dump_cached_states): Likewise.
7491 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7493 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7495 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7496 and to avoid gcc -Wuninitialized warning.
7497 (load_charset_map): Mark variables that gcc -Wuninitialized
7498 does not deduce are never used uninitialized.
7499 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7501 * coding.c (coding_set_source, coding_set_destination):
7502 Use "else { /* comment */ }" rather than "else /* comment */;"
7503 for clarity, and to avoid gcc -Wempty-body warning.
7504 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7505 a block, when the outer 'i' will do.
7506 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7507 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7508 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7509 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7510 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7511 Rename locals to avoid shadowing.
7512 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7513 * coding.c (emacs_mule_char, encode_invocation_designation):
7514 Now static, since they're not used elsewhere.
7515 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7516 (decode_coding_object, encode_coding_object, detect_coding_system):
7517 (decode_coding_emacs_mule): Mark variables that gcc
7518 -Wuninitialized does not deduce are never used uninitialized.
7519 (detect_coding_iso_2022): Initialize a local variable that might
7520 be used uninitialized. Leave a FIXME because it's not clear that
7521 this initialization is needed. (Bug#8211)
7522 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7523 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7524 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7525 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7526 Remove unused macros.
7528 * category.c (hash_get_category_set): Remove unused local var.
7529 (copy_category_table): Now static, since it's not used elsewhere.
7530 * character.c (string_count_byte8): Likewise.
7532 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7533 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7535 * chartab.c (copy_sub_char_table): Now static, since it's not used
7537 (sub_char_table_ref_and_range, char_table_ref_and_range):
7538 Rename locals to avoid shadowing.
7539 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7541 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7542 (BIDI_BOB): Remove unused macro.
7544 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7545 deduce are never used uninitialized.
7546 * term.c (encode_terminal_code): Likewise.
7548 * term.c (encode_terminal_code): Now static. Remove unused local.
7550 * tparam.h: New file.
7551 * term.c, tparam.h: Include it.
7552 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7553 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7554 Move these decls to tparam.h, and make them agree with what
7555 is actually in tparam.c. The previous trick of using incompatible
7556 decls in different modules does not conform to the C standard.
7557 All callers of tparam changed to use tparam's actual API.
7558 * tparam.c (tparam1, tparam, tgoto):
7559 Use const pointers where appropriate.
7561 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7562 * cm.h (struct cm): Likewise.
7563 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7564 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7565 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7566 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7567 (turn_on_face, init_tty): Likewise.
7568 * termchar.h (struct tty_display_info): Likewise.
7570 * term.c (term_mouse_position): Rename local to avoid shadowing.
7572 * alloc.c (mark_ttys): Move decl from here ...
7573 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7575 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7577 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7579 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7581 * search.c (compile_pattern_1): Remove argument regp, unused since
7582 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7583 (compile_pattern): Don't pass it.
7585 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7587 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7588 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7590 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7592 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7594 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7595 gdk_window_get_screen, gdk_window_get_geometry,
7596 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7597 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7598 (xg_get_pixbuf_from_pixmap): New function.
7599 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7600 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7601 Call xg_get_pixbuf_from_pixmap instead of
7602 gdk_pixbuf_get_from_drawable.
7603 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7604 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7605 (xg_check_special_colors): Use GtkStyleContext and its functions
7607 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7608 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7609 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7610 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7611 Call gtk_widget_get_preferred_size.
7612 (xg_frame_resized): gdk_window_get_geometry only takes 5
7614 (xg_win_to_widget, xg_event_is_for_menubar):
7615 Call gdk_x11_window_lookup_for_display.
7616 (xg_set_widget_bg): New function.
7617 (delete_cb): New function.
7618 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7619 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7620 (xg_set_background_color): Call xg_set_widget_bg.
7621 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7622 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7623 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7624 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7626 (update_frame_tool_bar): Call gtk_widget_hide.
7627 (xg_initialize): Use GDK_KEY_g.
7629 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7631 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7633 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7634 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7635 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7637 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7639 * w32xfns.c (select_palette): Check success of RealizePalette against
7640 GDI_ERROR, not zero.
7642 See ChangeLog.11 for earlier changes.
7648 Copyright (C) 2011 Free Software Foundation, Inc.
7650 This file is part of GNU Emacs.
7652 GNU Emacs is free software: you can redistribute it and/or modify
7653 it under the terms of the GNU General Public License as published by
7654 the Free Software Foundation, either version 3 of the License, or
7655 (at your option) any later version.
7657 GNU Emacs is distributed in the hope that it will be useful,
7658 but WITHOUT ANY WARRANTY; without even the implied warranty of
7659 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7660 GNU General Public License for more details.
7662 You should have received a copy of the GNU General Public License
7663 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.