]> code.delx.au - gnu-emacs/blob - src/ChangeLog
83b625d279e06f113cb621b4775a7b4b57c3b6c2
[gnu-emacs] / src / ChangeLog
1 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2
3 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4 of scroll runs so as to avoid assigning disabled bogus rows and
5 unnecessary graphics copy operations.
6
7 2011-11-27 Eli Zaretskii <eliz@gnu.org>
8
9 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
10 (snprintf) [_MSC_VER]: Redirect to _snprintf.
11 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
12 (malloc, free, realloc, calloc): Redirect to e_* only when
13 compiling Emacs.
14
15 * lisp.h (GCTYPEBITS): Move before first use.
16 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
17 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
18 this macro definition.
19
20 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
21 _MSC_VER.
22
23 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
24
25 * gtkutil.c (xg_create_frame_widgets): Call
26 gtk_window_set_has_resize_grip (FALSE) if that function is
27 present with Gtk+ 2.0.
28
29 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
30
31 * fileio.c (Finsert_file_contents): Undo previous change; see
32 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
33
34 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
35
36 Rename locals to avoid shadowing.
37 * fileio.c (Finsert_file_contents):
38 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
39 * process.c (wait_reading_process_output):
40 Rename inner 'proc' to 'p' to avoid shadowing.
41 Indent for consistency with usual Emacs style.
42
43 2011-11-25 Eli Zaretskii <eliz@gnu.org>
44
45 * xdisp.c (redisplay_window): If cursor row is not fully visible
46 after recentering, and scroll-conservatively is set to a large
47 number, scroll window by a few more lines to make the cursor fully
48 visible and out of scroll-margin. (Bug#10105)
49 (start_display): Don't move to the next line if the display should
50 start at a newline that is part of a display vector or an overlay
51 string. (Bug#10119)
52
53 2011-11-24 Juri Linkov <juri@jurta.org>
54
55 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
56 after the `MagickPingImage' call. (Bug#10112)
57
58 2011-11-23 Chong Yidong <cyd@gnu.org>
59
60 * window.c (Fcoordinates_in_window_p): Accept only live windows.
61
62 2011-11-23 Martin Rudalics <rudalics@gmx.at>
63
64 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
65 making another buffer current. (Bug#10114)
66
67 2011-11-23 Glenn Morris <rgm@gnu.org>
68
69 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
70
71 2011-11-23 Chong Yidong <cyd@gnu.org>
72
73 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
74 using it (Bug#5984).
75
76 2011-11-22 Eli Zaretskii <eliz@gnu.org>
77
78 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
79 and header-lines, as they don't have one computed for them.
80 (Bug#10098)
81
82 * .gdbinit (prow): Make displayed values more self-explaining.
83 Add row's hash code.
84
85 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
86
87 * process.c (wait_reading_process_output): Fix asynchrounous
88 GnuTLS socket handling on some versions of the GnuTLS library.
89 (wait_reading_process_output): Add comment and URL.
90
91 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
92
93 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
94
95 2011-11-21 Chong Yidong <cyd@gnu.org>
96
97 * window.c (Fnext_window, Fprevious_window): Doc fix.
98
99 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
102
103 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
104
105 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
106
107 2011-11-20 Martin Rudalics <rudalics@gmx.at>
108
109 * window.c (Fset_window_combination_limit): Rename argument
110 STATUS to LIMIT.
111 (Vwindow_combination_limit): Remove "status" from doc-string.
112
113 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
114
115 * m/ibms390.h: Remove.
116 * m/ibms390x.h: Don't include "ibms390.h".
117
118 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
119
120 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
121 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
122
123 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
124
125 * casetab.c (Fset_case_table):
126 * charset.c (Fcharset_after): Fix typos.
127
128 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
129
130 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
131 Otherwise, valgrind does not work on some platforms.
132 Problem reported by Andreas Schwab in
133 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
134 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
135 is set, removing the need for VIRT_ADDRESS_VARIES.
136 (PURE_P): Use a more-efficient implementation that needs just one
137 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
138 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
139 to 4 (xorl, subq, cmpq, setbe).
140 * alloc.c (pure): Always extern now, since that's the
141 VIRT_ADDR_VARIES behavior.
142 (PURE_POINTER_P): Use a single comparison, not two, for
143 consistency with the new puresize.h.
144 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
145 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
146 Remove VIRT_ADDR_VARIES no longer needed.
147
148 2011-11-19 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
151 (erase_phys_cursor, update_window_cursor, show_mouse_face)
152 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
153 behave as if the cursor position were at the window margin.
154
155 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
156 and the cursor position is out of bounds, behave as if the cursor
157 position were at the window margin. (Bug#10075)
158
159 2011-11-18 Chong Yidong <cyd@gnu.org>
160
161 * window.c (Fwindow_combination_limit): Make first argument
162 non-optional, since it is meaningless for live windows like the
163 selected window.
164
165 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
166
167 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
168
169 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
170
171 * intervals.c: Fix grafting over the whole buffer (bug#10071).
172 (graft_intervals_into_buffer): Simplify.
173
174 2011-11-18 Eli Zaretskii <eliz@gnu.org>
175
176 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
177 hash values of the two rows.
178 (copy_row_except_pointers): Preserve the used[] arrays and the
179 hash values of the two rows. (Bug#10035)
180 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
181
182 * xdisp.c (row_hash): New function, body extracted from
183 compute_line_metrics.
184 (compute_line_metrics): Call row_hash, instead of computing the
185 hash code inline.
186
187 * dispnew.c (verify_row_hash): Call row_hash for computing the
188 hash code of a row, instead of duplicating code from xdisp.c.
189
190 * dispextern.h (row_hash): Add prototype.
191
192 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
193
194 * frame.c (delete_frame): Don't delete the terminal when the last
195 X frame is closed if emacs is built with GTK toolkit.
196
197 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
198
199 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
200
201 2011-11-17 Martin Rudalics <rudalics@gmx.at>
202
203 * window.c (Vwindow_splits): Rename to
204 Vwindow_combination_resize. Suggested by Juri Linkov.
205 (Fsplit_window_internal): Use Vwindow_combination_resize instead
206 of Vwindow_splits.
207
208 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
209
210 * nsfns.m (Fns_font_name):
211 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
212
213 2011-11-16 Martin Rudalics <rudalics@gmx.at>
214
215 * window.h (window): Rename slot "nest" to "combination_limit".
216 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
217 (Fset_window_nest): Rename to Fset_window_combination_limit.
218 (Vwindow_nest): Rename to Vwindow_combination_limit.
219 (recombine_windows, make_parent_window, make_window)
220 (Fsplit_window_internal, saved_window)
221 (Fset_window_configuration, save_window_save): Rename all
222 occurrences of window_nest to window_combination_limit.
223
224 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
225
226 * image.c (imagemagick_load_image): Fix typo.
227
228 2011-11-14 Eli Zaretskii <eliz@gnu.org>
229
230 * xdisp.c (display_line): Move the call to
231 highlight_trailing_whitespace before the call to
232 compute_line_metrics, since the latter needs to see the final
233 faces of all the glyphs to compute ROW's hash value. Fixes
234 assertion violations in row_equal_p. (Bug#10035)
235
236 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
237
238 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
239 just return (bug#10044).
240
241 2011-11-12 Eli Zaretskii <eliz@gnu.org>
242
243 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
244 with user-defined heap size. Bump the default size of the temacs
245 heap to 27MB, to avoid memory warning when running temacs.
246 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
247
248 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
249 current_matrix and desired_matrix. (Bug#9990)
250 (verify_row_hash) [XASSERTS]: New function.
251 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
252 that the hash value of glyph rows is correct.
253
254 2011-11-12 Martin Rudalics <rudalics@gmx.at>
255
256 * window.h (window): Remove splits slot.
257 * window.c (Fwindow_splits, Fset_window_splits): Remove.
258 (Fdelete_other_windows_internal, make_parent_window)
259 (make_window, Fsplit_window_internal, Fdelete_window_internal)
260 (Fset_window_configuration, save_window_save): Don't deal with
261 split status of windows.
262 (saved_window): Remove splits slot.
263 (Vwindow_splits): Rewrite doc-string.
264
265 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
266
267 * xfns.c (unwind_create_frame):
268 * nsfns.m (unwind_create_frame):
269 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
270 Vframe_list (Bug#9999).
271
272 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
273
274 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
275
276 2011-11-11 Kenichi Handa <handa@m17n.org>
277
278 * callproc.c (Fcall_process): Set the member dst_multibyte of
279 process_coding.
280
281 2011-11-11 Johan Bockgård <bojohan@gnu.org>
282
283 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
284 avoid a crash (bug#9496).
285
286 2011-11-09 Chong Yidong <cyd@gnu.org>
287
288 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
289 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
290
291 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
292
293 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
294
295 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
296
297 Avoid some portability problems by eschewing 'extern inline' functions.
298 The trivial performance wins aren't worth the portability hassles; see
299 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
300 et seq.
301 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
302 (window_box_width, window_box_left, window_box_left_offset)
303 (window_box_right, window_box_right_offset): Undo previous change,
304 by removing the "extern"s.
305 * intervals.c (adjust_intervals_for_insertion)
306 (adjust_intervals_for_deletion): Undo previous change,
307 making these static again.
308 (offset_intervals, temp_set_point_both, temp_set_point)
309 (copy_intervals_to_string): No longer inline.
310 * xdisp.c (window_text_bottom_y, window_box_width)
311 (window_box_height, window_box_left_offset)
312 (window_box_right_offset, window_box_left, window_box_right)
313 (window_box): No longer inline.
314
315 2011-11-08 Chong Yidong <cyd@gnu.org>
316
317 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
318 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
319 an error if not a live window.
320 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
321 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
322
323 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
324
325 * lisp.h (syms_of_abbrev): Remove declaration.
326 Reported by CHENG Gao <chenggao@royau.me>.
327
328 2011-11-07 Eli Zaretskii <eliz@gnu.org>
329
330 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
331 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
332 of temacs in GUI mode.
333
334 2011-11-07 Martin Rudalics <rudalics@gmx.at>
335
336 * window.h: Declare delete_all_child_windows instead of
337 delete_all_subwindows.
338 * window.c (Fwindow_nest, Fset_window_nest)
339 (Fset_window_new_total, Fset_window_new_normal)
340 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
341 (delete_all_subwindows): Rename to delete_all_child_windows.
342 (Fdelete_other_windows_internal, Fset_window_configuration):
343 Call delete_all_child_windows instead of delete_all_subwindows.
344 * frame.c (delete_frame): Call delete_all_child_windows instead
345 of delete_all_subwindows.
346
347 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
348
349 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
350 This is also needed for porting to any host where GC_MARK_STACK is
351 not GC_MAKE_GCPROS_NOOPS.
352 (which_symbols): Use it.
353
354 2011-11-07 Kenichi Handa <handa@m17n.org>
355
356 * coding.c (coding_set_destination): Check coding->src_pos only
357 when coding->src_object is a buffer (bug#9910).
358
359 * process.c (send_process): Set the member src_multibyte of coding
360 to 0 (bug#9911) when sending a unibyte text.
361
362 * callproc.c (Fcall_process): Set the member src_multibyte of
363 process_coding to 0 (bug#9912).
364
365 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
366
367 * xmenu.c (cleanup_widget_value_tree): New function.
368 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
369 calling free_menubar_widget_value_tree directly (Bug#9830).
370
371 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
372
373 Fix some portability problems with 'inline'.
374 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
375 (window_box_width, window_box_left, window_box_left_offset)
376 (window_box_right, window_box_right_offset): Declare extern.
377 Otherwise, these inline functions do not conform to C99 and
378 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
379 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
380 * intervals.c (adjust_intervals_for_insertion)
381 (adjust_intervals_for_deletion): Now extern, because otherwise the
382 extern inline functions 'offset_intervals' couldn't refer to it.
383 (static_offset_intervals): Remove.
384 (offset_intervals): Rewrite using the old contents of
385 static_offset_intervals. The old version didn't conform to C99
386 because an extern inline function contained a reference to an
387 identifier with static linkage.
388
389 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
390
391 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
392 GC.
393
394 2011-11-06 Eli Zaretskii <eliz@gnu.org>
395
396 * xdisp.c (init_iterator, reseat_to_string): Don't set the
397 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
398 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
399 return Qleft_to_right.
400
401 2011-11-06 Chong Yidong <cyd@gnu.org>
402
403 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
404 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
405 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
406 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
407 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
408 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
409 (Fwindow_vscroll): Doc fix.
410 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
411 argument, since it makes no sense to pass a live window and for
412 consistency with window-child.
413
414 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
415
416 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
417 support MSVC.
418
419 2011-11-05 Jason Rumney <jasonr@gnu.org>
420
421 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
422 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
423 fonts (Bug#6029).
424 (add_font_entity_to_list): Fix logic errors in mixed boolean and
425 bitwise arithmetic preventing use of unicode-sip and non-truetype
426 opentype fonts.
427
428 2011-11-05 Eli Zaretskii <eliz@gnu.org>
429
430 * s/ms-w32.h (fstat, stat, utime): Move redirections to
431 "emacs"-only part.
432
433 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
434 initialization code to keep similarity to xfns.c after changes
435 from 2011-11-05.
436
437 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
438
439 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
440 (unwind_create_frame): New function (Bug#9943).
441 (Fx_create_frame): Restructure code to be more similar to the one in
442 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
443 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
444 Move terminal->reference_count++ just before making the frame official
445 (Bug#9943).
446
447 * nsterm.m (x_free_frame_resources): New function.
448 (x_destroy_window): Move code to x_free_frame_resources.
449
450 * xfns.c (unwind_create_frame): Fix comment.
451 (Fx_create_frame, x_create_tip_frame): Move
452 terminal->reference_count++ just before making the frame
453 official. Move initialization of image_cache_refcount and
454 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
455
456 2011-11-05 Eli Zaretskii <eliz@gnu.org>
457
458 Support MSVC build with newer versions of Visual Studio.
459 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
460 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
461 nt/gmake.defs.
462
463 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
464 which are not supported by MSVC.
465 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
466 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
467 bitfields.
468 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
469 types in bitfields.
470 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
471
472 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
473
474 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
475
476 Support MSVC build with newer versions of Visual Studio.
477 * w32.c: Don't include w32api.h for MSVC.
478 (init_environment) [_MSC_VER]: Call sys_access, not _access.
479
480 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
481 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
482 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
483 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
484 e_* cousins.
485 (alloca) [_MSC_VER]: Define to _alloca.
486
487 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
488
489 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
490
491 2011-11-04 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (note_mouse_highlight): If either of
494 previous/next-single-property-change returns nil, treat that as
495 the beginning or the end of the buffer. (Bug#9955)
496
497 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
498
499 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
500 label is not null (Bug#9951).
501 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
502 may be NULL.
503
504 2011-11-04 Eli Zaretskii <eliz@gnu.org>
505
506 * window.c (Fwindow_body_size): Mention in the doc string that the
507 return value is in frame's canonical units. (Bug#9949)
508
509 2011-11-03 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
512
513 * w32fns.c (unwind_create_frame): If needed, free the glyph
514 matrices of the partially constructed frame. (Bug#9943)
515 * xfns.c (unwind_create_frame): Likewise.
516
517 2011-11-01 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
520 Don't stop backward scan on the continuation glyph, even though
521 its CHARPOS is positive.
522 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
523 cover_string to disp_string.
524
525 2011-11-01 Martin Rudalics <rudalics@gmx.at>
526
527 * window.c (temp_output_buffer_show): Don't use
528 Vtemp_buffer_show_specifiers.
529 (Vtemp_buffer_show_specifiers): Remove unused variable.
530
531 2011-10-30 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
534 past the beginning of the current glyph matrix.
535
536 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
537
538 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
539 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
540 HAVE_GTK3 (Bug#9869).
541
542 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
543 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
544
545 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
546
547 * xterm.c: Declare x_handle_net_wm_state to return int.
548 (handle_one_xevent): Check if we are iconified but don't have
549 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
550 (get_current_wm_state): Return non-zero if not hidden,
551 check for _NET_WM_STATE_HIDDEN (Bug#9893).
552 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
553 (x_handle_net_wm_state): Return what get_current_wm_state returns.
554 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
555
556 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
557
558 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
559 so that this new function doesn't get optimized away by a
560 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
561
562 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
563
564 * frame.h (MOUSE_HL_INFO): Remove excess parens.
565
566 2011-10-29 Eli Zaretskii <eliz@gnu.org>
567
568 Fix the `xbytecode' command.
569 * .gdbinit (xprintbytestr): New command.
570 (xwhichsymbols): Rename from `which'; all callers changed.
571 (xbytecode): Print the byte-code string as well.
572
573 2011-10-29 Kim Storm <storm@cua.dk>
574
575 * alloc.c (which_symbols): New function.
576
577 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
578
579 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
580 line. (Bug#9903)
581
582 2011-10-29 Glenn Morris <rgm@gnu.org>
583
584 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
585 Not clear what it was for, and it causes various bugs. (Bug#9839)
586
587 2011-10-28 Eli Zaretskii <eliz@gnu.org>
588
589 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
590 possible random value that matches one of those tested as
591 condition to clear the mouse face.
592
593 2011-10-28 Chong Yidong <cyd@gnu.org>
594
595 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
596
597 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
598
599 * window.c (make_window): Initialize phys_cursor_on_p.
600
601 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * lisp.h (struct Lisp_Symbol): Update comments.
604
605 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
606
607 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
608
609 2011-10-28 Eli Zaretskii <eliz@gnu.org>
610
611 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
612 <oslsachem@gmail.com> for helping to debug this.
613
614 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
615 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
616 (g_b_init_get_glyph_outline_w): New static variables.
617 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
618 (GetGlyphOutlineW_Proc): New typedefs.
619 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
620 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
621 New functions.
622 (w32font_open_internal, compute_metrics):
623 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
624 instead of calling the "wide" APIs directly.
625
626 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
627
628 * w32.h (syms_of_w32font): Add prototype.
629
630 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
631
632 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
633 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
634 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
635 (Fmove_to_window_line): Doc fix.
636
637 2011-10-27 Chong Yidong <cyd@gnu.org>
638
639 * process.c (make_process): Set gnutls_state to NULL.
640
641 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
642 non-NULL, regardless of GNUTLS_INITSTAGE.
643 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
644 an error. Set process slots as soon as we allocate them.
645
646 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
647
648 2011-10-27 Chong Yidong <cyd@gnu.org>
649
650 * gnutls.c (emacs_gnutls_deinit): New function.
651 Deallocate credentials structures as well as calling gnutls_deinit.
652 (Fgnutls_deinit, Fgnutls_boot): Use it.
653
654 * process.c (make_process): Initialize GnuTLS credentials to NULL.
655 (deactivate_process): Call emacs_gnutls_deinit.
656
657 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
658
659 * image.c (x_create_x_image_and_pixmap):
660 * w32.c (sys_rename, w32_delayed_load):
661 * w32font.c (fill_in_logfont):
662 * w32reg.c (x_get_string_resource): Silence compiler warnings.
663
664 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
665
666 * w32fns.c (w32_default_color_map): New function,
667 extracted from Fw32_default_color_map.
668 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
669
670 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
671
672 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
673
674 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * keyboard.c (test_undefined): New function (bug#9751).
677 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
678
679 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
680
681 * sysdep.c (init_sys_modes): Fix the check for the controlling
682 terminal (Bug#6649).
683
684 2011-10-20 Eli Zaretskii <eliz@gnu.org>
685
686 * dispextern.h (struct bidi_it): New member next_en_type.
687
688 * bidi.c (bidi_line_init): Initialize the next_en_type member.
689 (bidi_resolve_explicit_1): When next_en_pos is valid for the
690 current character, check also for next_en_type being WEAK_EN.
691 (bidi_resolve_weak): Don't enter the expensive loop if the current
692 position is before next_en_pos. Record the bidi type of the first
693 non-ET, non-BN character we find, in addition to its position.
694 (bidi_level_of_next_char): Invalidate next_en_type when
695 next_en_pos is over-stepped.
696
697 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
698
699 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
700 * editfns.c: Rewrite current-time-zone so that it invokes
701 the equivalent of (format-time-string "%Z") to get the time zone name.
702 This fixes a bug when the time zone name contains characters that
703 need converting from the system time locale to Emacs internal format.
704 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
705 that patch fixed format-time-string to do the conversion, but
706 I forgot to fix current-time-zone.
707 (format_time_string): New function, containing most of
708 what Fformat_time_string used to contain.
709 (Fformat_time_string): Rewrite in terms of format_time_string.
710 This doesn't change this function's behavior.
711 (current-time-zone): Rewrite to use format_time_string.
712 This fixes the bug reported by Michael Schierl in
713 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
714 Jason Rumney's 2007-06-07 change worked around this bug, but
715 didn't fix it.
716 * systime.h (tzname, timezone): Remove no-longer-used declarations.
717
718 2011-10-19 Eli Zaretskii <eliz@gnu.org>
719
720 * xdisp.c (start_display): If the character at POS is displayed
721 via a display vector, reset IT->current.dpvec_index to zero.
722 (try_window_reusing_current_matrix): If a line ends in a display
723 vector or the next line starts in a display vector, continue
724 redrawing the window even though the character position of
725 start_row was reached.
726 (Bug#9771, part 2)
727
728 2011-10-18 Chong Yidong <cyd@gnu.org>
729
730 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
731 with nobreak-char-display too.
732
733 2011-10-18 Eli Zaretskii <eliz@gnu.org>
734
735 Fix part 3 of bug#9771.
736 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
737 (bidi_resolve_neutral): Don't enter the expensive loop looking for
738 non-neutral characters if the current character is a paragraph
739 separator (a.k.a. Newline). This avoids running the same
740 expensive loop twice, once when we consume the preceding newline
741 and the other time when the line actually needs to be displayed.
742 Avoid the loop when we see neutrals on the base embedding level
743 following a character whose directionality is the same as the
744 paragraph's. This avoids running the expensive loop when a line
745 ends in a long sequence of neutrals, like control characters.
746 Add assertion against STRONG_AL type. Slightly rearrange code
747 that determines the type of a neutral given the first non-neutral
748 that follows it.
749 (bidi_level_of_next_char): Set next_en_pos to zero when
750 invalidating its info.
751
752 2011-10-17 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (push_display_prop): Determine whether to record string
755 or buffer position by IT->string, not by IT->method. Allow
756 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
757 (move_it_vertically_backward): Don't look for character position
758 immediately after the newline when in a continuation line.
759 (Bug#9771, part 1)
760
761 2011-10-15 Martin Rudalics <rudalics@gmx.at>
762
763 * window.c (coordinates_in_window): Rewrite and delabelize
764 vertical border check. (Bug#5357) (Bug#9618)
765
766 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
769 errors in XSetWindowBorder (bug#9310).
770
771 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
772
773 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
774 avoid crash when xmalloc overrun checking is enabled.
775
776 2011-10-13 Eli Zaretskii <eliz@gnu.org>
777
778 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
779 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
780 cursor motion with <left> and <right> arrow keys.
781
782 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
783 some callers set that themselves.
784
785 2011-10-12 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
788 display string and the previous row comes from the same string and
789 is empty. (Bug#9739) (Bug#9738)
790
791 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * doc.c (get_doc_string): Encode file name (bug#9735).
794
795 2011-10-12 Eli Zaretskii <eliz@gnu.org>
796
797 * bidi.c (bidi_level_of_next_char):
798 * xdisp.c (get_visually_first_element): Remove old incorrect
799 comments regarding the Unicode Line Separator character.
800
801 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
802
803 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
804
805 * alloc.c (Fgc_status): Do not access beyond zombies array
806 boundary if nzombies > MAX_ZOMBIES.
807 * alloc.c (dump_zombies): Add missing format specifier.
808
809 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
810
811 * xdisp.c (set_cursor_from_row): Simplify conditionals,
812 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
813
814 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
815 Some packages use them to denote characters with modifiers.
816
817 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
818
819 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
820 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
821 matching a pp-number. Rename parameter var to var1.
822
823 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
824
825 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
826
827 2011-10-08 Glenn Morris <rgm@gnu.org>
828
829 * callint.c (Fcall_interactively): Give a more explicit error for the
830 'c' case with a non-character input. (Bug#8479)
831
832 2011-10-08 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
835 lines.
836 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
837 lines that are hscrolled on the left.
838
839 * dispnew.c (buffer_posn_from_coords): Account for a possible
840 presence of header-line. (Bug#4426)
841
842 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
845 Don't advertise functionality which we discourage or doesn't work.
846
847 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
848
849 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
850 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
851 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
852 this makes Emacs dump core during garbage collection on rare
853 occasions. sizeof is obviously inferior to offsetof here, so
854 stick with offsetof.
855 (GC_POINTER_ALIGNMENT): New macro.
856 (mark_memory): Omit 3rd (offset) arg; caller changed.
857 Don't assume EMACS_INT alignment is the same as pointer alignment.
858
859 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * keyboard.c (read_key_sequence_remapped): New var.
862 (read_key_sequence): Compute remapping in the right buffer.
863 (command_loop_1): Use read_key_sequence's remapping directly.
864
865 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
866
867 * dired.c (file_name_completion): Don't expand file name.
868 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
869 before checking file name handler.
870
871 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
872 they've been requested explicitly (bug#9591).
873
874 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
875
876 * keymap.c (Fsingle_key_description): Use make_specified_string
877 instead of build_string to build string from push_key_description.
878 (Bug#5193)
879
880 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
881
882 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
883 This fixes a Y2038 bug on 64-bit hosts.
884 * buffer.c (reset_buffer):
885 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
886 (Fclear_buffer_auto_save_failure):
887 Use 0, not -1, to represent an unset failure time, since time_t
888 might not be signed.
889
890 Remove dependency on glibc malloc internals.
891 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
892 Move back here from lisp.h, but with their new implementations.
893 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
894 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
895 * charset.c (charset_table_init): New static var.
896 (syms_of_charset): Use it instead of xmalloc. This removes a
897 dependency on glibc malloc internals. See Eli Zaretskii's comment in
898 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
899 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
900 Move back to alloc.c.
901 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
902 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
903
904 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
905
906 * nsterm.m (windowDidResize): Call x_set_window_size only when
907 ns_in_resize is true. Otherwise set pixelwidth/height and
908 call change_frame_size (Bug#9628).
909
910 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
911
912 Port --enable-checking=all to Fedora 14 x86-64.
913 * charset.c (syms_of_charset): Also account for glibc malloc's
914 internal overhead when calculating the initial malloc maximum.
915
916 Port --enable-checking=all to Fedora 14 x86.
917 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
918 Move to lisp.h.
919 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
920 (overrun_check_realloc, overrun_check_free):
921 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
922 That way, xmalloc returns a properly-aligned pointer even if
923 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
924 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
925 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
926 into account when calculating the initial malloc maximum.
927 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
928 Move here from alloc.c, so that charset.c can use it too.
929 Properly align; the old code wasn't right for common 32-bit hosts
930 when configured with --enable-checking=all.
931 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
932 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
933
934 2011-09-29 Eli Zaretskii <eliz@gnu.org>
935
936 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
937 use EDOM.
938
939 2011-09-28 Eli Zaretskii <eliz@gnu.org>
940
941 * xdisp.c (compute_display_string_end): If there's no display
942 string at CHARPOS, return -1.
943
944 * bidi.c (bidi_fetch_char): When compute_display_string_end
945 returns a negative value, treat the character as a normal
946 character not covered by a display string. (Bug#9624)
947
948 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
949
950 * lread.c (Fread_from_string): Fix typo in docstring.
951
952 2011-09-27 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (handle_invisible_prop): If invisible text ends on a
955 newline, reseat the iterator instead of bidi-iterating there one
956 character at a time. (Bug#9610)
957 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
958 TO_CHARPOS if the bidi iterator is at base embedding level.
959
960 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
961
962 * lread.c (readevalloop): Use correct code for NBSP.
963 (read1): Likewise. (Bug#9608)
964
965 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
966
967 * dbusbind.c (Fdbus_register_signal): When service is not
968 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
969
970 2011-09-25 Glenn Morris <rgm@gnu.org>
971
972 * buffer.c (truncate-lines): Doc fix.
973
974 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
975
976 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
977 (Fset_window_next_buffers): Doc fix.
978
979 2011-09-24 Glenn Morris <rgm@gnu.org>
980
981 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
982
983 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
984
985 Fix minor problems found by static checking.
986 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
987 * indent.c (Fvertical_motion): Fix == vs = typo.
988
989 2011-09-24 Eli Zaretskii <eliz@gnu.org>
990
991 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
992 Default value is now t. Doc fix.
993
994 * indent.c (Fvertical_motion): Compute and apply the overshoot
995 logic when moving up, not only when moving down. Fix the
996 confusing name and values of the it_overshoot_expected variable;
997 logic changes accordingly. (Bug#9254) (Bug#9549)
998
999 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1000 CHARPOS is covered by a display string which includes newlines.
1001 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1002 is covered by a display string with embedded newlines.
1003
1004 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1005
1006 * dbusbind.c (Fdbus_register_signal): Add match rule to
1007 Vdbus_registered_objects_table. (Bug#9581)
1008 (Fdbus_register_method, Vdbus_registered_objects_table):
1009 Fix docstring.
1010
1011 2011-09-24 Jim Meyering <meyering@redhat.com>
1012
1013 do not ignore write error for any output size
1014 The previous change was incomplete.
1015 While it makes emacs --batch detect the vast majority of stdout
1016 write failures, errors were still ignored whenever the output size is
1017 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1018 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1019 && echo FAIL: ignored write error
1020 FAIL: ignored write error
1021 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1022 && echo FAIL: ignored write error
1023 FAIL: ignored write error
1024 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1025
1026 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 * emacs.c (Fkill_emacs): In noninteractive mode exit
1029 non-successfully if a write error occurred on stdout. (Bug#9574)
1030
1031 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1032
1033 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1034 the xassert test.
1035
1036 * dispextern.h (struct it): Update the comment documenting what
1037 can it->OBJECT be.
1038
1039 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1042 a display string, extend search for cursor position to end of row.
1043 (find_row_edges): If the row ends in a newline from a display
1044 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1045 Handle the case of a display string with multiple newlines.
1046 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1047 non-empty line. Fixes confusing cursor motion with arrow keys at
1048 the beginning of a line that starts with whitespace.
1049
1050 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1051
1052 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1053 (bug#9493).
1054
1055 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1056
1057 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1058 boolean (Bug#9154).
1059
1060 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1061
1062 * xdisp.c (display_line): Record maximum and minimum buffer
1063 positions even if no glyphs were produced (e.g., by a zero-width
1064 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1065 buffer positions that will be removed from the glyph row because
1066 they don't fit.
1067 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1068 column is beyond frame width: don't subtract 1 "pixel" when
1069 computing width of the stretch.
1070 (reseat_at_next_visible_line_start): Undo the change made on
1071 2011-09-17 that saved paragraph information and restored it after
1072 the call to `reseat'. (Bug#9545)
1073
1074 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1075
1076 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1077 and turn window cursor on if cleared (Bug#9415).
1078
1079 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1080
1081 * search.c (boyer_moore): Take unibyte characters from pattern
1082 literally. (Bug#9458)
1083
1084 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1085
1086 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1087
1088 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 Fix minor problem found by static checking.
1091 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1092 initialized, to pacify gcc -Wuninitialized.
1093
1094 * fileio.c: Report proper errno when syscall falls.
1095 (Finsert_file_contents): Save and restore errno,
1096 so that report_file_error outputs the correct diagnostic.
1097 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1098
1099 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1100
1101 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1102
1103 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1106 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1107
1108 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1109
1110 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1111 about the current paragraph and restore it after the call to reseat.
1112
1113 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1114 (bidi_find_paragraph_start): Search back for paragraph beginning
1115 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1116 (bidi_move_to_visually_next): Only trigger paragraph-related
1117 computations when the last character is a newline or at EOB, not
1118 just any NEUTRAL_B. (Bug#9470)
1119
1120 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1121 truncated lines if point is covered by a display string. (Bug#9524)
1122
1123 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1126 (cons_to_x_long): New function.
1127 (lisp_data_to_selection_data): Use it. Correct the test for
1128 short-versus-long data; it was negated. Break out of vector
1129 loop, for efficiency, when a long datum is discovered.
1130
1131 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1132
1133 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1134
1135 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1136
1137 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1138 GCC PR/17406) by declaring this function with external scope.
1139
1140 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1143 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1144
1145 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1146
1147 * editfns.c (Fformat): Correctly handle text properties on "%%".
1148
1149 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1150
1151 * xterm.c (x_draw_composite_glyph_string_foreground):
1152 * w32term.c (x_draw_composite_glyph_string_foreground):
1153 * term.c (encode_terminal_code):
1154 * composite.c (composition_update_it, get_composition_id):
1155 * xdisp.c (get_next_display_element)
1156 (fill_composite_glyph_string): Add comments about special meaning
1157 of TAB characters in a composition.
1158
1159 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1162 This occurs when processing a multibyte format.
1163 Problem reported by Wolfgang Jenker.
1164
1165 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1166
1167 * xdisp.c (try_cursor_movement): Only check for exact match if
1168 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1169
1170 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Remove unused external symbols.
1173 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1174 * xdisp.c (calc_pixel_width_or_height): Now static.
1175 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1176 * indent.c (check_display_width):
1177 * w32term.c: Fix comment to match code.
1178 * xterm.c, xterm.h (x_catching_errors): Remove.
1179
1180 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * xselect.c: Use signed conversions more consistently (Bug#9498).
1183 (selection_data_to_lisp_data): Assume incoming selection data are
1184 signed integers, not unsigned. This is to be consistent with
1185 outgoing selection data, which was modified to use signed integers
1186 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1187 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1188 expects long, not unsigned long.
1189
1190 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1191
1192 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1193 computation of loop end. Reported by Johan Bockgård
1194 <bojohan@gnu.org>.
1195
1196 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1197
1198 * frame.c (Fother_visible_frames_p): Function deleted.
1199
1200 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1201
1202 * indent.c (compute_motion): Process display vector front to back
1203 rather than the other way around. (Bug#2496)
1204
1205 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1208
1209 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * minibuf.c (Fread_from_minibuffer): Doc fix.
1212
1213 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1216 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1217
1218 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1219
1220 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1221 value for non-existent files.
1222
1223 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1224
1225 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1226 set its "size" to -1. This will set the modtime_size field of
1227 the corresponding buffer to -1, which is what
1228 verify-visited-file-modtime expects for files that do not exist.
1229 (Bug#9139)
1230
1231 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1234 here ...
1235 * lisp.h: ... from here. push_key_description is no longer
1236 defined in keyboard.c, so its declaration should not be in
1237 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1238 logically belongs with push_key_description.
1239
1240 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * buffer.h: Include <sys/types.h> instead of <time.h>.
1243 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1244 Problem reported by Herbert J. Skuhra.
1245
1246 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1247
1248 * xml.c (parse_region): Make the parsing work for
1249 non-comment-starting XML files again (bug#9144).
1250
1251 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1252
1253 * image.c (gif_load): Fix calculation of bottom and right corner.
1254 (Bug#9468)
1255
1256 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1259 redisplay in small windows.
1260
1261 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1262
1263 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1264
1265 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1266
1267 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1268 Operate on live windows only.
1269
1270 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1271
1272 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1273
1274 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1277 only under bidi iteration.
1278
1279 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1280
1281 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1282
1283 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1286 Without this fix, the command to link temacs failed due to an
1287 undefined symbol __builtin_isnan. This is because
1288 /usr/include/iso/math_c99.h #defines isnan(x) to
1289 __builtin_isnan(x), but the bundled gcc, which identifies itself
1290 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1291 a __builtin_isnan.
1292 * floatfns.c (isnan): #undef, and then #define to a clone of
1293 what's in data.c.
1294 (Fisnan): Always define, since it's always available now.
1295 (syms_of_floatfns): Always define isnan at the Lisp level.
1296
1297 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1300
1301 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1304 The previous code assumed that file offsets (off_t values) fit in
1305 EMACS_INT variables, which is not true on typical 32-bit hosts.
1306 The code messed up by falsely reporting buffer overflow in cases
1307 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1308 when "big" contains more than 2**29 bytes, even though this
1309 inserts just one byte and does not overflow the buffer.
1310 (Finsert_file_contents): Store file offsets as off_t
1311 values, not as EMACS_INT values. Check for overflow when
1312 converting between EMACS_INT and off_t. When checking for
1313 buffer overflow or for overlap, take the offsets into account.
1314 Don't use EMACS_INT for small values where int suffices.
1315 When checking for overlap, fix a typo: ZV was used where
1316 ZV_BYTE was intended.
1317 (Fwrite_region): Don't assume off_t fits into 'long'.
1318 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1319
1320 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1321
1322 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1323
1324 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 sprintf-related integer and memory overflow issues (Bug#9412).
1327
1328 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1329 (esprintf, exprintf, evxprintf): New functions.
1330 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1331 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1332 (modify_event_symbol): Do not assume that the length of
1333 name_alist_or_stem is safe to alloca and fits in int.
1334 (Fexecute_extended_command): Likewise for function name and binding.
1335 (Frecursion_depth): Wrap around reliably on integer overflow.
1336 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1337 since some callers pass EMACS_INT values.
1338 (Fsingle_key_description): Don't crash if symbol name contains more
1339 than MAX_ALLOCA bytes.
1340 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1341 (get_minibuffer): Arg is now EMACS_INT, not int.
1342 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1343 (esprintf, exprintf, evxprintf): New decls.
1344 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1345
1346 * dbusbind.c (signature_cat): New function.
1347 (xd_signature, Fdbus_register_signal):
1348 Do not overrun buffer; instead, report string overflow.
1349
1350 * dispnew.c (add_window_display_history): Don't overrun buffer.
1351 Truncate instead; this is OK since it's just a log.
1352
1353 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1354 even if the time zone offset is outlandishly large.
1355 Don't mishandle offset == INT_MIN.
1356
1357 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1358 when creating daemon; the previous buffer-overflow check was incorrect.
1359
1360 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1361 which has the guts of the old verror function.
1362
1363 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1364 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1365
1366 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1367 (font_unparse_xlfd): Don't blindly alloca long strings.
1368 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1369 fits in int, when using sprintf. Use single snprintf to count
1370 length of string rather than counting it via multiple sprintfs;
1371 that's simpler and more reliable.
1372 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1373 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1374 sprintf, in case result does not fit in int.
1375
1376 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1377 (fontset_from_font): Print it.
1378
1379 * frame.c (tty_frame_count): Now printmax_t, not int.
1380 (make_terminal_frame, set_term_frame_name): Print it.
1381 (x_report_frame_params): In X, window IDs are unsigned long,
1382 not signed long, so print them as unsigned.
1383 (validate_x_resource_name): Check for implausibly long names,
1384 and don't assume name length fits in 'int'.
1385 (x_get_resource_string): Don't blindly alloca invocation name;
1386 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1387 not fit in int.
1388
1389 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1390 (xg_check_special_colors, xg_set_geometry):
1391 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1392
1393 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1394 Use esprintf, not sprintf, in case result does not fit in int.
1395
1396 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1397 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1398 it as a large positive number.
1399 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1400 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1401
1402 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1403 in case result does not fit in int.
1404
1405 * print.c (float_to_string): Detect width overflow more reliably.
1406 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1407 buffer overrun. Don't assume list length fits in 'int'. Treat
1408 print length of 0 as 0, not as infinity; to be consistent with other
1409 uses of print length in this function. Don't overflow print length
1410 index. Don't assume hash table size fits in 'long', or that
1411 vectorlike size fits in 'unsigned long'.
1412
1413 * process.c (make_process): Use printmax_t, not int, to format
1414 process-name gensyms.
1415
1416 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1417
1418 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1419 to avoid potential buffer overrun.
1420
1421 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1422 if X resource line is longer than 512 bytes.
1423
1424 * xfns.c (x_window): Make sprintf buffer a bit bigger
1425 to avoid potential buffer overrun.
1426
1427 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1428
1429 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1430
1431 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 Integer overflow fixes for scrolling, etc.
1434 Without these, Emacs silently mishandles large integers sometimes.
1435 For example, "C-u 4294967297 M-x recenter" was treated as if
1436 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1437
1438 * xdisp.c (try_window_id): Check Emacs fixnum range before
1439 converting to 'int'.
1440
1441 * window.c (window_scroll_line_based, Frecenter):
1442 Check that an Emacs fixnum is in range before assigning it to 'int'.
1443 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1444 values converted from Emacs fixnums.
1445 (Frecenter): Don't wrap around a line count if it is out of 'int'
1446 range; instead, treat it as an extreme value.
1447 (Fset_window_configuration, compare_window_configurations):
1448 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1449
1450 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1451 that can exceed INT_MAX. Check that EMACS_INT value is in range
1452 before assigning it to the (possibly-narrower) index.
1453 (match_limit): Don't assume that a fixnum can fit in 'int'.
1454
1455 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1456 exceed INT_MAX.
1457
1458 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1459 (Fvertical_motion): Don't wrap around LINES values that don't fit
1460 in 'int'. Instead, treat them as extreme values. This is good
1461 enough for windows, which can't have more than INT_MAX lines anyway.
1462
1463 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1464
1465 * Require libxml/parser.h to avoid compilation warning.
1466
1467 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1468
1469 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1470 since this reportedly can destroy thread storage.
1471
1472 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1473
1474 * syntax.c (find_defun_start): Update all cache variables if
1475 exiting early (Bug#9401).
1476
1477 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1478
1479 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1480
1481 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1482 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1483 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1484
1485 * term.c (tty_append_glyph): New function.
1486 (produce_stretch_glyph): Static function and its prototype deleted.
1487
1488 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1489 Add prototypes.
1490
1491 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1494 when checking :margin (Bug#9390).
1495 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1496 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1497 so that the name doesn't mislead. All uses changed.
1498
1499 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1500
1501 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1502 set_tty_hooks.
1503
1504 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1505
1506 * xdisp.c (move_it_to): Don't bail out early when reaching
1507 position beyond to_charpos, if we are scanning backwards.
1508 (move_it_vertically_backward): When DY == 0, make sure we get to
1509 the first character in the line after the newline.
1510
1511 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1514 (ccl_driver): Do not generate an out-of-range pointer.
1515 (Fccl_execute_on_string): Remove unnecessary check for
1516 integer overflow, noted by Stefan Monnier in
1517 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1518 Remove a FIXME that didn't need fixing.
1519 Simplify the newly-introduced buffer reallocation code.
1520
1521 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1522
1523 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1524
1525 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1526
1527 Integer and memory overflow issues (Bug#9196).
1528
1529 * doc.c (get_doc_string): Rework so that
1530 get_doc_string_buffer_size is the actual buffer size, rather than
1531 being 1 less than the actual buffer size; this makes xpalloc more
1532 convenient.
1533
1534 * image.c (x_allocate_bitmap_record, cache_image):
1535 * xselect.c (Fx_register_dnd_atom):
1536 Simplify previous changes by using xpalloc.
1537
1538 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1539 since either will do and ptrdiff_t is convenient with xpalloc.
1540
1541 * charset.c (charset_table_size)
1542 (struct charset_sort_data.priority): Now ptrdiff_t.
1543 (charset_compare): Don't overflow if priorities differ greatly.
1544 (Fsort_charsets): Don't assume list length fits in int.
1545 Check for size-calculation overflow when allocating sort data.
1546 (syms_of_charset): Allocate an initial charset table that is
1547 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1548
1549 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1550
1551 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1552 The actual value is always <= INT_MAX, and leaving it unsigned made
1553 overflow checking harder.
1554
1555 * dispextern.h (struct glyph_matrix.rows_allocated)
1556 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1557 with xpalloc. The values are still always <= INT_MAX.
1558
1559 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1560
1561 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1562 (SAFE_NALLOCA): New macro.
1563
1564 * region-cache.c (struct boundary.pos, find_cache_boundary)
1565 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1566 (set_cache_region, invalidate_region_cache)
1567 (revalidate_region_cache, know_region_cache, region_cache_forward)
1568 (region_cache_backward, pp_cache):
1569 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1570 so that ptrdiff_t * can be passed to xpalloc.
1571 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1572 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1573 (pp_cache): Don't assume cache_len fits in int.
1574 * region-cache.h: Adjust extern decls to match.
1575
1576 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1577 EMACS_INT, since either will do, for xpalloc.
1578
1579 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1580 (xnmalloc, xnrealloc, xpalloc): New functions.
1581
1582 * bidi.c (bidi_shelve_header_size): New constant.
1583 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1584 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1585
1586 * bidi.c (bidi_cache_shrink):
1587 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1588 (overlay_strings):
1589 Don't update size of array until after memory allocation succeeds,
1590 because xmalloc/xrealloc may not return.
1591 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1592 now that we have proper integer overflow checking.
1593 (record_overlay_string, overlay_strings): Catch overflows when
1594 calculating size of overlay_str_buf.
1595
1596 * callproc.c (Fcall_process): Check for size overflow when
1597 calculating size of args2.
1598 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1599 Normally we prefer signed values, but sticking with ptrdiff_t would
1600 require adding more-complicated checks.
1601
1602 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1603 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1604 Redo buffer-overflow calculations to avoid integer overflow.
1605 Add a FIXME comment where memory seems to be over-allocated.
1606
1607 * character.c (Fstring): Check for size-calculation overflow.
1608
1609 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1610 unnecessary integer overflow. Check for size overflow.
1611 (encode_coding_object): Don't update size until xmalloc succeeds.
1612
1613 * composite.c (get_composition_id): Check for overflow in glyph
1614 length calculations.
1615
1616 Integer and memory overflow fixes for display code.
1617 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1618 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1619 (scrolling_window): Check for overflow in size calculations.
1620 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1621 Don't assume glyph table len fits in int.
1622 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1623 (row_table_size): Now ptrdiff_t, not int.
1624 (scrolling_window): Avoid overflow in size calculations.
1625 Don't update size until allocation succeeds.
1626 * fns.c (concat): Check for overflow in size calculations.
1627 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1628 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1629 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1630
1631 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1632 (get_doc_string): Check for size calculation overflow.
1633 Don't update size until allocation succeeds.
1634 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1635 EMACS_INT, where ptrdiff_t will do.
1636 (Fsubstitute_command_keys): Check for string overflow.
1637
1638 * editfns.c (set_time_zone_rule): Don't assume environment length
1639 fits in int.
1640 (message_length): Now ptrdiff_t, not int.
1641 (Fmessage_box): Don't update size until allocation succeeds.
1642 Don't assume message length fits in int.
1643 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1644
1645 * emacs.c (main): Do not reallocate argv, since there is a null at
1646 the end that can be overwritten, and this way there's no need to
1647 worry about size-calculation overflow.
1648 (sort_args): Check for size-calculation overflow.
1649
1650 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1651 alloc succeeds.
1652 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1653
1654 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1655 (x_set_scroll_bar_width, x_figure_window_size):
1656 Check for integer overflow.
1657 (x_set_alpha): Do not assume XINT fits in int.
1658
1659 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1660 This is for the members text_lines, text_cols, total_lines, total_cols,
1661 where the system imposes an 'int' limit.
1662
1663 * fringe.c (Fdefine_fringe_bitmap):
1664 Don't update size until alloc works.
1665
1666 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1667 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1668
1669 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1670 Check for size-calculation overflow.
1671 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1672 do, as we prefer signed integers.
1673 (id_to_widget.max_size, id_to_widget.used)
1674 (xg_store_widget_in_map, xg_remove_widget_from_map)
1675 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1676 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1677 Use and return ptrdiff_t, not int.
1678 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1679 * gtkutil.h: Change prototypes to match the above.
1680
1681 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1682 are duplicate now that they've been promoted to lisp.h.
1683 (x_allocate_bitmap_record, x_alloc_image_color)
1684 (make_image_cache, cache_image, xpm_load):
1685 Don't update size until alloc is done.
1686 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1687 (x_detect_edges):
1688 Check for size calculation overflow.
1689 (ct_colors_allocated_max): New constant.
1690 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1691 overflow.
1692
1693 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1694 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1695 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1696 Use ptrdiff_t, not int, to count maps.
1697 (read_char_minibuf_menu_prompt): Check for overflow in size
1698 calculations. Don't update size until allocation succeeds.
1699 Redo calculations to avoid overflow.
1700 * keyboard.h: Change prototypes to match the above.
1701
1702 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1703 to count maps.
1704 (current_minor_maps): Check for size calculation overflow.
1705 * keymap.h: Change prototypes to match the above.
1706
1707 * lread.c (read1, init_obarray): Don't update size until alloc done.
1708
1709 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1710 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1711
1712 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1713 Now ptrdiff_t, not int.
1714 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1715 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1716
1717 * process.c (Fnetwork_interface_list): Check for overflow
1718 in size calculation.
1719
1720 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1721
1722 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1723 overflow. Don't bother calling xmalloc when xrealloc will do.
1724
1725 * search.c (Freplace_match): Check for size calculation overflow.
1726 (Fset_match_data): Don't assume list lengths fit in 'int'.
1727
1728 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1729 for command line length. Do not attempt to address one before the
1730 beginning of an array, as that's not portable.
1731
1732 * term.c (max_frame_lines): Remove; unused.
1733 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1734 not int.
1735 (encode_terminal_code, calculate_costs): Check for size
1736 calculation overflow.
1737 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1738 table lengths and related sizes. Don't update size until alloc
1739 done. Redo calculations to avoid overflow.
1740 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1741
1742 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1743 subtracting pointers.
1744 (gobble_line): Check for overflow more carefully. Don't update size
1745 until alloc done.
1746
1747 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1748 Don't update size until alloc done.
1749 Redo size calculations to avoid overflow.
1750 Check for size calculation overflow.
1751 (main) [DEBUG]: Fix typo in invoking tparam1.
1752
1753 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1754 Use ptrdiff_t, not int, for sizes.
1755 (store_mode_line_noprop_char): Don't update size until alloc done.
1756
1757 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1758 Use ptrdiff_t, not int, for sizes.
1759 (Finternal_make_lisp_face, cache_face):
1760 Check for size calculation overflow.
1761 (cache_face): Treat size calculation overflows as if they were
1762 memory exhaustion (the usual treatment), rather than aborting.
1763
1764 * xfns.c (x_encode_text, x_set_name_internal)
1765 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1766 sizes, since they can exceed INT_MAX in size. Check for size
1767 calculation overflow.
1768
1769 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1770 (xg_select): Check for size calculation overflow.
1771 Don't update size until alloc done.
1772
1773 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1774 as sprintf is limited to int lengths.
1775
1776 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1777 (X_LONG_MIN): New macros.
1778 Use them to make the following changes clearer.
1779 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1780 This change doesn't affect the value now, but it may help remind
1781 future maintainers not to raise the value too much later.
1782 (SELECTION_QUANTUM): Remove, replacing with ...
1783 (selection_quantum): ... new function, which avoids overflow.
1784 All uses changed.
1785 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1786 assumption that selection length fits in 'int'.
1787 (x_reply_selection_request, x_handle_selection_request)
1788 (x_get_window_property, receive_incremental_selection)
1789 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1790 (lisp_data_to_selection_data, clean_local_selection_data):
1791 Use ptrdiff_t, not int, to record length of selection.
1792 (x_reply_selection_request, x_get_window_property)
1793 (receive_incremental_selection, x_property_data_to_lisp):
1794 Redo calculations to avoid overflow.
1795 (x_reply_selection_request): When sending hint, ceiling it at
1796 X_LONG_MAX rather than relying on wraparound overflow to send
1797 something.
1798 (x_get_window_property, receive_incremental_selection)
1799 (lisp_data_to_selection_data, x_property_data_to_lisp):
1800 Check for size-calculation overflow.
1801 (x_get_window_property, receive_incremental_selection)
1802 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1803 Don't store size until memory allocation succeeds.
1804 (x_get_window_property): Plug memory leak on memory exhaustion.
1805 Don't double-block input; malloc is safe here. Don't assume 2**34
1806 - 4 fits in unsigned long. Add an xassert to check
1807 XGetWindowProperty overflow. Be more careful about overflow
1808 calculations, and distinguish size from memory overflow better.
1809 (receive_incremental_selection): When tracing, don't assume
1810 unsigned int is less than INT_MAX.
1811 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1812 harmful) conversions of unsigned short to int.
1813 (lisp_data_to_selection_data): Don't assume that integers
1814 in the range -65535 through -1 fit in an X unsigned short.
1815 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1816 result parameters unless successful. Rely on cons_to_unsigned
1817 to report problems with elements; the old code wasn't right anyway.
1818 (x_check_property_data): Check for int overflow; we cannot use
1819 a wider type due to X limits.
1820 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1821
1822 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1823
1824 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1825 (x_term_init): Check for size calculation overflow.
1826 (x_color_cells): Don't store size until memory allocation succeeds.
1827 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1828 Don't assume alloca size is less than MAX_ALLOCA.
1829 (x_term_init): Don't assume length fits in int (sprintf is limited
1830 to int size).
1831
1832 Use ptrdiff_t for composition IDs.
1833 * character.c (lisp_string_width):
1834 * composite.c (composition_table_size, n_compositions)
1835 (get_composition_id, composition_gstring_from_id):
1836 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1837 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1838 * window.c (Frecenter):
1839 Use ptrdiff_t, not int, for composition IDs.
1840 * composite.c (get_composition_id): Check for integer overflow.
1841 * composite.h: Adjust prototypes to match the above changes.
1842
1843 Use ptrdiff_t for hash table indexes.
1844 * category.c (hash_get_category_set):
1845 * ccl.c (ccl_driver):
1846 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1847 * coding.c (coding_system_charset_list, detect_coding_system):
1848 * coding.h (struct coding_system.id):
1849 * composite.c (get_composition_id, gstring_lookup_cache):
1850 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1851 * image.c (xpm_get_color_table_h):
1852 * lisp.h (hash_lookup, hash_put):
1853 * minibuf.c (Ftest_completion):
1854 Use ptrdiff_t for hash table indexes, not int (which is too
1855 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1856 32-bit --with-wide-int hosts).
1857
1858 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1859 Add a FIXME comment about memory leaks.
1860 (syms_of_charset): Don't assume xmalloc returns.
1861
1862 Don't assume that stated character widths fit in int.
1863 * character.c (Fchar_width, c_string_width, lisp_string_width):
1864 * character.h (CHAR_WIDTH):
1865 * indent.c (MULTIBYTE_BYTES_WIDTH):
1866 Use sanitize_char_width to avoid undefined and/or bad behavior
1867 with outlandish widths.
1868 * character.h (sanitize_tab_width): Rename from sanitize_width,
1869 now that we have two such functions. All uses changed.
1870 (sanitize_char_width): New inline function.
1871
1872 Don't assume that tab-width fits in int.
1873 * character.h (sanitize_width): New inline function.
1874 (SANE_TAB_WIDTH): New macro.
1875 (ASCII_CHAR_WIDTH): Use it.
1876 * indent.c (sane_tab_width): Remove. All uses replaced by
1877 SANE_TAB_WIDTH (current_buffer).
1878 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1879
1880 * fileio.c: Integer overflow issues with file modes.
1881 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1882
1883 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1884 Remove unreachable code.
1885 (read_hex, load_charset_map_from_file): Check for integer overflow.
1886
1887 * xterm.c: don't go over XClientMessageEvent limit
1888 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1889 (x_send_scroll_bar_event): Likewise. Check that the size does not
1890 exceed limits imposed by XClientMessageEvent, as well as the usual
1891 ptrdiff_t and size_t limits.
1892
1893 * keyboard.c: Overflow, signedness and related fixes.
1894 (make_lispy_movement): Use same integer type in forward decl
1895 that is used in the definition.
1896 (read_key_sequence, keyremap_step):
1897 Change bufsize argument back to int, undoing my 2011-03-30 change.
1898 We prefer signed types, and int is wide enough here.
1899 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1900 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1901 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1902 length, not size_t. Use ptrdiff_t for index, not int.
1903 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1904 possibility of integer overflow.
1905
1906 Overflow, signedness and related fixes for images.
1907
1908 * dispextern.h (struct it.stack[0].u.image.image_id)
1909 (struct_it.image_id, struct image.id, struct image_cache.size)
1910 (struct image_cache.used, struct image_cache.ref_count):
1911 * gtkutil.c (update_frame_tool_bar):
1912 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1913 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1914 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1915 * nsmenu.m (update_frame_tool_bar):
1916 * xdisp.c (calc_pixel_width_or_height):
1917 * xfns.c (image_cache_refcount):
1918 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1919 on typical 64-bit hosts.
1920
1921 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1922 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1923 Omit unnecessary casts to int.
1924 (parse_image_spec): Check that integers fall into 'int' range
1925 when the callers expect that.
1926 (image_ascent): Redo ascent calculation to avoid int overflow.
1927 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1928 (lookup_image): Remove unnecessary tests.
1929 (xbm_image_p): Locals are now of int, not EMACS_INT,
1930 since parse_image_check makes sure they fit into int.
1931 (png_load, gif_load, svg_load_image):
1932 Prefer int to unsigned where either will do.
1933 (tiff_handler): New function, combining the cores of the
1934 old tiff_error_handler and tiff_warning_handler.
1935 This function is rewritten to use vsnprintf and thereby avoid
1936 stack buffer overflows. It uses only the features of vsnprintf
1937 that are common to both POSIX and native Microsoft.
1938 (tiff_error_handler, tiff_warning_handler): Use it.
1939 (tiff_load, gif_load, imagemagick_load_image):
1940 Don't assume :index value fits in 'int'.
1941 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1942 (imagemagick_load_image): Check that crop parameters fit into
1943 the integer types that MagickCropImage accepts. Don't assume
1944 Vimagemagick_render_type has a nonnegative value. Don't assume
1945 size_t fits in 'long'.
1946 (gs_load): Use printmax_t to print the widest integers possible.
1947 Check for integer overflow when computing image height and width.
1948
1949 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1950
1951 * xdisp.c (redisplay_window): Don't force window start if point
1952 will be invisible in the resulting window. (Bug#9324)
1953
1954 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1955
1956 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1957 the display spec is of the form `(space ...)'.
1958 (handle_display_spec): Return the value returned by
1959 handle_single_display_spec, not just 1 or zero.
1960 (handle_single_display_spec): If the display spec is of the form
1961 `(space ...)', and specifies display in the text area, return 2
1962 rather than 1.
1963 (try_cursor_movement): Check for the need to scroll more
1964 accurately, and prefer exact match for point under bidi.
1965 Don't advance `row' beyond the last row of the window.
1966
1967 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1968 into disp_prop; all users changed.
1969
1970 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1971 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1972 for the text covered by the display property.
1973
1974 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1977 Change return value to nil.
1978 (Frecord_buffer): Delete unused function.
1979
1980 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1983 buffers, return left-to-right.
1984 (set_cursor_from_row): Consider candidate row a win if its glyph
1985 represents a newline and point is on that newline. Fixes cursor
1986 positioning on the newline at EOL of R2L text within L2R
1987 paragraph, and vice versa.
1988 (try_cursor_movement): Check continued rows, in addition to
1989 continuation rows. Fixes unwarranted scroll when point enters a
1990 continued line of R2L text within an L2R paragraph, or vice versa.
1991 (cursor_row_p): Consider the case of point being equal to
1992 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1993 from the end of a short line to the beginning of a continued line
1994 of R2L text within L2R paragraph.
1995 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1996 composed characters.
1997
1998 * bidi.c (bidi_check_type): Use xassert.
1999 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2000 members.
2001
2002 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2003
2004 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2005 a character.
2006
2007 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2008
2009 * nsfont.m (ns_otf_to_script): Fix typo.
2010
2011 2011-08-22 Kenichi Handa <handa@m17n.org>
2012
2013 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2014 extra slot even if the purpose is char-code-property-table.
2015
2016 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (redisplay_window): When computing centering_position,
2019 account for the height of the header line. (Bug#8874)
2020
2021 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2022 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2023 candidate is selected by the mouse, and that candidate has a
2024 composed character under the mouse.
2025
2026 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2027 coordinates reported by pos-visible-in-window-p for a composed
2028 character in column zero.
2029
2030 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2031
2032 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2033
2034 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2035
2036 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2037 consider it a hit if to_charpos is anywhere in the range of the
2038 composed buffer positions.
2039
2040 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * image.c (gif_load): Don't assume that each subimage has the same
2043 dimensions as the base image. Handle disposal method that is
2044 "undefined" by the gif spec (Bug#9335).
2045
2046 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2047
2048 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2049 (Fcondition_case): Document `debug' symbol in error handler.
2050
2051 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2054 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2055 from an Org mode buffer to a Speedbar frame.
2056
2057 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2058 a composition, take its buffer position from IT->cmp_it.charpos.
2059 Fixes cursor positioning at the beginning of a line that begins
2060 with a composed character.
2061
2062 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2063
2064 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2065 character bidirectional type, use STRONG_L instead. Fixes crashes
2066 in a buffer produced by `describe-categories'.
2067
2068 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2069 members before the level stack, so they would be saved and
2070 restored when copying iterator state. Fixes incorrect reordering
2071 around TABs covered by display properties.
2072
2073 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2074
2075 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2076
2077 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2078
2079 * eval.c (internal_condition_case, internal_condition_case_1)
2080 (internal_condition_case_2, internal_condition_case_n):
2081 Remove unnecessary aborts (Bug#9081).
2082
2083 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2084
2085 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2086 has no `load' handler, try opening the file locally. (Bug#9311)
2087
2088 2011-08-16 Ken Brown <kbrown@cornell.edu>
2089
2090 * gmalloc.c: Expand comment.
2091
2092 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2095 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2096
2097 2011-08-16 Ken Brown <kbrown@cornell.edu>
2098
2099 Fix memory allocation problems in Cygwin build (Bug#9273).
2100
2101 * unexcw.c ( __malloc_initialized): Declare external variable.
2102 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2103
2104 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2105 New variables.
2106 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2107 dumped emacs.
2108 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2109 in the static heap.
2110 [CYGWIN] (special_realloc): New function.
2111 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2112 requests to realloc storage in the static heap.
2113
2114 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 * bidi.c (bidi_initialize): Remove unused local.
2117
2118 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2119
2120 * bidimirror.h:
2121 * biditype.h: Remove file.
2122 * makefile.w32-in ($(BLD)/bidi.$(O)):
2123 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2124
2125 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2126
2127 * chartab.c: Improve commentary for the uniprop_table API.
2128
2129 * bidi.c (bidi_paragraph_init): Support zero value of
2130 bidi_ignore_explicit_marks_for_paragraph_level.
2131 (bidi_initialize): Use uniprop_table instead of including
2132 biditype.h and bidimirror.h.
2133
2134 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2135 coordinates of the iterator when restoring from ppos_it.
2136 (Bug#9296)
2137
2138 2011-08-14 Kenichi Handa <handa@m17n.org>
2139
2140 * process.c (create_process): Call setup_process_coding_systems
2141 after the pid of the process is set to -1 (Bug#8162).
2142
2143 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (move_it_in_display_line_to): Don't invoke
2146 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2147 ppos_it. Fixes vertical cursor motion when line beginning is
2148 covered by an image. (Bug#9296)
2149
2150 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2151
2152 * nsterm.h (ns_run_ascript): Declare.
2153 (NSAPP_DATA2_RUNASSCRIPT): Define.
2154
2155 * nsfns.m (as_script, as_result, as_status): New static variables.
2156 (ns_run_ascript): New function.
2157 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2158 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2159 the event loop. Get status from as_status (Bug#7276).
2160
2161 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2162 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2163 the event loop (Bug#7276).
2164
2165 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2166
2167 * gnutls.c (QCgnutls_bootprop_priority)
2168 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2169 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2170 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2171 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2172 (QCgnutls_bootprop_verify_hostname_error)
2173 (QCgnutls_bootprop_callbacks_verify): Rename from
2174 Qgnutls_bootprop_..., all uses changed.
2175
2176 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2177 uses changed.
2178
2179 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * xfaces.c (Qframe_set_background_mode): Now static.
2182 * dispextern.h (Qframe_set_background_mode): Remove decl.
2183
2184 * process.c (Fnetwork_interface_info): Declare local only if needed.
2185
2186 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2187
2188 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2189 (Fnetwork_interface_list): Allocate in increments of bytes instead
2190 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2191 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2192 sockaddr.
2193 (struct ifflag_def): notrailers is smart on OSX.
2194 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2195 Get hardware address with getifaddrs if available.
2196
2197 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2198
2199 * xdisp.c (iterate_out_of_display_property): xassert that
2200 IT->position is set to within IT->object's boundaries. Break from
2201 the loop as soon as EOB is reached; avoids infloops in redisplay
2202 when IT->position is set up wrongly due to some bug.
2203 Set IT->current to match the bidi iterator unconditionally.
2204 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2205 entry. Force push_it to save on the stack the current
2206 buffer/string position, to be restored by pop_it. Fix flags in
2207 the iterator structure wrt the object coming from a display
2208 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2209 properties. (Bug#9284)
2210
2211 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2212
2213 * fontset.c (fontset_get_font_group): Add proper type checks.
2214 (Bug#9172)
2215
2216 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2217
2218 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2219 and LC_VERSION_MIN_MACOSX.
2220 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2221 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2222
2223 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2224
2225 * xdisp.c (forward_to_next_line_start): Allow to use the
2226 no-display-properties-and-no-overlays under bidi display.
2227 Set disp_pos in the bidi iterator to avoid searches for display
2228 properties and overlays.
2229
2230 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2231
2232 * editfns.c (Fset_time_zone_rule): Document relationship with the
2233 setenv function.
2234
2235 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2236 the font entity extracted from the cache (Bug#8109).
2237
2238 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2239
2240 * composite.c (autocmp_chars): Don't reset point. That is done by
2241 restore_point_unwind (Bug#5984).
2242
2243 2011-08-07 Juri Linkov <juri@jurta.org>
2244
2245 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2246 to show the arg `TIME' instead of `TIMEVAL'.
2247
2248 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2249
2250 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2251 display property strides EOL and includes a newline, as in
2252 longlines-mode. (Bug#9254)
2253 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2254 word-wrap under bidirectional display. (Bug#9224)
2255
2256 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2257 is non-zero, even if the data buffer is NULL. Fixes a crash in
2258 vertical-motion with longlines-mode. (Bug#9254)
2259
2260 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2261
2262 * bidi.c <bidi_cache_total_alloc>: Now static.
2263 (bidi_initialize): Initialize bidi_cache_total_alloc.
2264
2265 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2266 cache. (Bug#9221)
2267
2268 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2269 amount allocated this far in `bidi_cache_total_alloc'.
2270 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2271 non-zero, only free the data buffer without restoring the cache
2272 contents. All callers changed.
2273
2274 * dispextern.h (bidi_unshelve_cache): Update prototype.
2275
2276 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2277 (move_it_in_display_line, move_it_to)
2278 (move_it_vertically_backward, move_it_by_lines): Replace the call
2279 to xfree to an equivalent call to bidi_unshelve_cache.
2280 (move_it_in_display_line_to): Fix logic of returning
2281 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2282
2283 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2286 came from a string character with a `cursor' property. (Bug#9229)
2287
2288 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2289
2290 * Makefile.in (LIB_PTHREAD): New variable.
2291 (LIBES): Add LIB_PTHREAD (Bug#9216).
2292
2293 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2294 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2295
2296 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2297
2298 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2299
2300 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2301
2302 * xterm.c (x_find_topmost_parent): New function.
2303 (x_set_frame_alpha): Find topmost parent window with
2304 x_find_topmost_parent and set the property there also (bug#9181).
2305 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2306
2307 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * callproc.c (Fcall_process): Avoid vfork clobbering
2310 the local vars buffer, coding_systems, current_dir.
2311
2312 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2313
2314 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2315
2316 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2319 so that it is not optimized away.
2320
2321 * xdisp.c (compute_display_string_pos): Remove unused local.
2322
2323 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2324
2325 Fix slow cursor motion and scrolling in large buffers with
2326 selective display, like Org Mode buffers. (Bug#9218)
2327
2328 * dispextern.h (struct bidi_it): New member disp_prop_p.
2329
2330 * xdisp.c: Remove one-slot cache of display string positions.
2331 (compute_display_string_pos): Accept an additional argument
2332 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2333 for a display string or property. If found, set DISP_PROP_P
2334 non-zero.
2335
2336 * bidi.c (bidi_fetch_char): Accept an additional argument
2337 DISP_PROP_P, and pass it to compute_display_string_pos.
2338 Only handle text covered by a display string if DISP_PROP_P is returned
2339 non-zero. All callers of bidi_fetch_char changed.
2340
2341 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2344
2345 2010-12-03 Don March <don@ohspite.net>
2346
2347 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2348 last character M-[char] is translated to ESC [char] (bug#7541).
2349
2350 2011-08-02 Kenichi Handa <handa@m17n.org>
2351
2352 * lisp.h (uniprop_table): Extern it.
2353
2354 * chartab.c (uniprop_table): Make it non-static.
2355
2356 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (forward_to_next_line_start): Accept additional argument
2359 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2360 on the newline.
2361 (reseat_at_next_visible_line_start): Use the bidi iterator state
2362 returned by forward_to_next_line_start to restore the state of
2363 it->bidi_it after backing up to previous newline. (Bug#9212)
2364
2365 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * regex.c (re_comp): Protoize.
2368 (re_exec): Fix return type.
2369 (regexec): Fix type of `ret'. (Bug#9203)
2370
2371 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2374 This is needed if max-image-size is a floating-point number.
2375
2376 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * print.c (print_object): Print empty symbol as ##.
2379
2380 * lread.c (read1): Read ## as empty symbol.
2381
2382 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2383
2384 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2385 setting frame foreground color (Bug#9175).
2386 (x_set_background_color): Likewise.
2387
2388 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2389 contents (Bug#9176).
2390 (EmacsTooltip -init): Remove bezels and add shadows to
2391 tooltip windows.
2392
2393 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2394 or scroll bar (Bug#8470).
2395
2396 * nsfont.m (nsfont_open): Remove assignment to voffset and
2397 unnecessary vars hshink, expand, hd, full_height, min_height.
2398 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2399
2400 * nsterm.h (nsfont_info): Remove voffset field.
2401
2402 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2403
2404 Implement strike-through and overline on NextStep (Bug#8863).
2405
2406 * nsfont.m (nsfont_open): Use underline position provided by font,
2407 instead of hard-coded value of 2.
2408 (nsfont_draw): Call ns_draw_text_decoration instead.
2409
2410 * nsterm.h: Add declaration for ns_draw_text_decoration.
2411
2412 * nsterm.m (ns_draw_text_decoration): New function for drawing
2413 underline, overline, and strike-through.
2414 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2415 ns_draw_text_decoration. Change treatment of cursor drawing to
2416 accommodate underlining, etc.
2417
2418 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2419
2420 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2421 default.
2422
2423 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2426 Without this fix, if a signal arrives just after memory fills up,
2427 'malloc' might be invoked reentrantly.
2428
2429 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2430 In other words, assume that every image size is allowed, on non-X
2431 hosts. This assumption is probably wrong, but it lets Emacs compile.
2432
2433 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2434
2435 * regex.c (re_iswctype): Convert return values to boolean.
2436
2437 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2438
2439 * xdisp.c (compute_display_string_pos): Don't use cached display
2440 string position if the buffer had its restriction changed.
2441 (Bug#9184)
2442
2443 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2446
2447 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Integer signedness and overflow and related fixes. (Bug#9079)
2450
2451 * bidi.c: Integer size and overflow fixes.
2452 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2453 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2454 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2455 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2456 (bidi_find_other_level_edge):
2457 Use ptrdiff_t instead of EMACS_INT where either will do.
2458 This works better on 32-bit hosts configured --with-wide-int.
2459 (bidi_cache_ensure_space): Check for size-calculation overflow.
2460 Use % rather than repeated addition, for better worst-case speed.
2461 Don't set bidi_cache_size until after xrealloc returns, because it
2462 might not return.
2463 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2464 (bidi_cache_ensure_space): Also check that the bidi cache size
2465 does not exceed that of the largest Lisp string or buffer. See Eli
2466 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2467
2468 * alloc.c (__malloc_size_t): Remove.
2469 All uses replaced by size_t. See Andreas Schwab's note
2470 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2471
2472 * image.c: Improve checking for integer overflow.
2473 (check_image_size): Assume that f is nonnull, since
2474 it is always nonnull in practice. This is one less thing to
2475 worry about when checking for integer overflow later.
2476 (x_check_image_size): New function, which checks for integer
2477 overflow issues inside X.
2478 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2479 This removes the need for a memory_full check.
2480 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2481 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2482 (xbm_read_bitmap_data): Change locals back to 'int', since
2483 their values must fit in 'int'.
2484 (xpm_load_image, png_load, tiff_load):
2485 Invoke x_create_x_image_and_pixmap earlier,
2486 to avoid much needless work if the image is too large.
2487 (tiff_load): Treat overly large images as if
2488 x_create_x_image_and_pixmap failed, not as malloc failures.
2489 (gs_load): Use x_check_image_size.
2490
2491 * gtkutil.c: Omit integer casts.
2492 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2493 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2494
2495 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2496
2497 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2498 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2499 would wrongly return t on a 64-bit host.
2500
2501 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2502 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2503 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2504 and therefore cause GCC to emit a bogus diagnostic in some cases.
2505
2506 * image.c: Integer signedness and overflow and related fixes.
2507 This is not an exhaustive set of fixes, but it's time to
2508 record what I've got.
2509 (lookup_pixel_color, check_image_size): Remove redundant decls.
2510 (check_image_size): Don't assume that arbitrary EMACS_INT values
2511 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2512 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2513 (tiff_load, imagemagick_load_image):
2514 Check for overflow in size calculations.
2515 (x_create_x_image_and_pixmap): Remove unnecessary test for
2516 xmalloc returning NULL; that can't happen.
2517 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2518 (xpm_color_bucket): Use better integer hashing function.
2519 (xpm_cache_color): Don't possibly over-allocate memory.
2520 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2521 (gif_memory_source):
2522 Use ptrdiff_t, not int or size_t, to record sizes.
2523 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2524 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2525 either works, as we prefer signed integers.
2526 (tiff_read_from_memory, tiff_write_from_memory):
2527 Return tsize_t, not size_t, since that's what the TIFF API wants.
2528 (tiff_read_from_memory): Don't fail simply because the read would
2529 go past EOF; instead, return a short read.
2530 (tiff_load): Omit no-longer-needed casts.
2531 (Fimagemagick_types): Don't assume size fits into 'int'.
2532
2533 Improve hashing quality when configured --with-wide-int.
2534 * fns.c (hash_string): New function, taken from sxhash_string.
2535 Do not discard information about ASCII character case; this
2536 discarding is no longer needed.
2537 (sxhash-string): Use it. Change sig to match it. Caller changed.
2538 * lisp.h: Declare it.
2539 * lread.c (hash_string): Remove, since we now use fns.c's version.
2540 The fns.c version returns a wider integer if --with-wide-int is
2541 specified, so this should help the quality of the hashing a bit.
2542
2543 * emacs.c: Integer overflow minor fix.
2544 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2545 Define only if GNU_LINUX.
2546 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2547
2548 * dispnew.c: Integer signedness and overflow fixes.
2549 Remove unnecessary forward decls, that were a maintenance hassle.
2550 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2551 All uses changed.
2552 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2553 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2554 (prepare_desired_row, line_draw_cost):
2555 Use int, not unsigned, where either works.
2556 (save_current_matrix, restore_current_matrix):
2557 Use ptrdiff_t, not size_t, where either works.
2558 (init_display): Check for overflow more accurately, and without
2559 relying on undefined behavior.
2560
2561 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2562 Remove, replacing with the new symbols in lisp.h. All uses changed.
2563 * fileio.c (make_temp_name):
2564 * filelock.c (lock_file_1, lock_file):
2565 * xdisp.c (message_dolog):
2566 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2567 Use pMd etc. instead.
2568 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2569 replacing the pWIDE etc. symbols removed from editfns.c.
2570
2571 * keyboard.h (num_input_events): Now uintmax_t.
2572 This is (very slightly) less likely to mess up due to wraparound.
2573 All uses changed.
2574
2575 * buffer.c: Integer signedness fixes.
2576 (alloc_buffer_text, enlarge_buffer_text):
2577 Use ptrdiff_t rather than size_t when either will do, as we prefer
2578 signed integers.
2579
2580 * alloc.c: Integer signedness and overflow fixes.
2581 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2582 (__malloc_size_t): Default to size_t, not to int.
2583 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2584 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2585 Prefer ptrdiff_t to size_t when either would do, as we prefer
2586 signed integers.
2587 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2588 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2589 Now const. Initialize with values that are in range even if char
2590 is signed.
2591 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2592 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2593 These functions do the right thing with sizes > 2**32.
2594 (check_depth): Now ptrdiff_t, not int.
2595 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2596 Adjust to new way of storing sizes. Check for size overflow bugs
2597 in rest of code.
2598 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2599 slightly wrong anyway, as it missed one instance of
2600 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2601 (refill_memory_reserve): Omit needless cast to size_t.
2602 (mark_object_loop_halt): Mark as externally visible.
2603
2604 * xselect.c: Integer signedness and overflow fixes.
2605 (Fx_register_dnd_atom, x_handle_dnd_message):
2606 Use ptrdiff_t, not size_t, since we prefer signed.
2607 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2608 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2609 x_dnd_atoms_size and x_dnd_atoms_length.
2610
2611 * doprnt.c: Prefer signed to unsigned when either works.
2612 * eval.c (verror):
2613 * doprnt.c (doprnt):
2614 * lisp.h (doprnt):
2615 * xdisp.c (vmessage):
2616 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2617 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2618 prefer signed arithmetic to avoid comparison confusion.
2619 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2620 but is a bit tricky.
2621
2622 Assume freestanding C89 headers, string.h, stdlib.h.
2623 * data.c, doprnt.c, floatfns.c, print.c:
2624 Include float.h unconditionally.
2625 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2626 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2627 * regex.c: Likewise for stddef.h, string.h.
2628 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2629 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2630 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2631 (STDC_HEADERS): Remove obsolete defines.
2632 * sysdep.c: Include limits.h unconditionally.
2633
2634 Assume support for memcmp, memcpy, memmove, memset.
2635 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2636 * regex.c (memcmp, memcpy):
2637 Remove; we assume C89 now.
2638
2639 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2640 (__malloc_safe_bcopy): Remove; no longer needed.
2641
2642 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2643 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2644 well either way, and we prefer signed to unsigned.
2645
2646 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2647
2648 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2649 closes the connection while we're reading (bug#9182).
2650
2651 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2652
2653 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2654 are specified (Bug#9168).
2655
2656 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2659 Found by GCC static checking and --with-wide-int on a 32-bit host.
2660
2661 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xdisp.c (compute_display_string_pos): Fix logic of caching
2664 previous display string position. Initialize cached_prev_pos to
2665 -1. Fixes slow-down at the beginning of a buffer.
2666
2667 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2668
2669 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2670 for attrs[LFACE_FONTSET_INDEX].
2671
2672 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * xml.c (parse_region): Remove unused local
2675 that was recently introduced.
2676
2677 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2680 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2681
2682 * xdisp.c (move_it_in_display_line_to): Record the best matching
2683 position for TO_CHARPOS while scanning the line, and restore it on
2684 exit if none of the characters scanned was an exact match.
2685 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2686 when exact match is impossible due to invisible text, and the
2687 lines are truncated.
2688
2689 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2692 for OSX >= 10.7.
2693
2694 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2695
2696 Fix a significant slow-down of cursor motion with C-n, C-p,
2697 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2698 auto-repeat under bidi redisplay in fontified buffers.
2699 * xdisp.c (compute_stop_pos_backwards): New function.
2700 (next_element_from_buffer): Call compute_stop_pos_backwards to
2701 find a suitable prev_stop when we find ourselves before
2702 base_level_stop.
2703 (reseat): Don't look for prev_stop, as that could mean a very long
2704 run.
2705 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2706 <cached_disp_overlay_modiff>: Cache for last found display string
2707 position.
2708 (compute_display_string_pos): Return the cached position if asked
2709 about the same buffer in the same area of character positions, and
2710 the buffer wasn't changed since the time the display string
2711 position was cached.
2712
2713 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2716 is an integer, which is important for empty lines. (Bug#9149)
2717
2718 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2719
2720 * frame.c (Fmodify_frame_parameters): In tty case, update the
2721 default face if necessary (Bug#4238).
2722
2723 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * editfns.c (Fstring_to_char): No need to explain what a character
2726 is in the docstring (Bug#6576).
2727
2728 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2729
2730 * xml.c (parse_region): Make sure we always return a tree.
2731
2732 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2733
2734 * xml.c (parse_region): If a document contains only comments,
2735 return that, too.
2736
2737 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2738
2739 * xml.c (make_dom): Return comments, too.
2740
2741 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Port to OpenBSD.
2744 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2745 and the surrounding thread.
2746 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2747 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2748 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2749 timer goes off.
2750 * s/openbsd.h (BROKEN_SIGIO): Define.
2751 * unexelf.c (unexec) [__OpenBSD__]:
2752 Don't update the .mdebug section of the Alpha COFF symbol table.
2753
2754 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2755
2756 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2757 (bug#8460).
2758
2759 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2760
2761 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2762 This fixes some race conditions on the permissions of any newly
2763 created file.
2764
2765 * alloc.c (valid_pointer_p): Use pipe, not open.
2766 This fixes some permissions issues when debugging.
2767
2768 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2769 If fchown fails to set both uid and gid, try to set just gid,
2770 as that is sometimes allowed. Adjust the file's mode to eliminate
2771 setuid or setgid bits that are inappropriate if fchown fails.
2772
2773 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2774
2775 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2776 to compare Lisp_Objects.
2777 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2778 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2779 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2780
2781 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2782
2783 * lread.c (read_integer): Unread even EOF character.
2784 (read1): Likewise. Properly record start position of symbol.
2785
2786 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2787 symbol character follows.
2788
2789 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2792 This works around a problem with the previous change to Fcopy_file.
2793 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2794 and without this change, GCC might complain about discarding
2795 fchown's return value.
2796
2797 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2800
2801 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2804
2805 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2806
2807 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2808 it's used from the C level.
2809
2810 * process.c: Use the same condition for POLL_FOR_INPUT in both
2811 keyboard.c and process.c (bug#1858).
2812
2813 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2814
2815 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2816 (Fgnutls_boot): Use it.
2817
2818 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * doc.c (Fsubstitute_command_keys): Revert last change.
2821
2822 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2823
2824 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2825 quotes the next character, and doesn't affect other longer
2826 sequences (bug#8935).
2827
2828 * lread.c (syms_of_lread): Clarify that is isn't only
2829 `eval-buffer' and `eval-defun' that's affected by
2830 `lexical-binding' (bug#8460).
2831
2832 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2833
2834 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2835 bidi redisplay when a line includes both an image and is truncated.
2836
2837 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Fix minor problems found by static checking.
2840 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2841 (elsz): Now a signed constant, not a size_t var. We prefer signed
2842 types to unsigned, to avoid integer comparison confusion. Without
2843 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2844 "cannot optimize loop, the loop counter may overflow", a symptom
2845 of the confusion.
2846 * indent.c (Fvertical_motion): Mark locals as initialized.
2847 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2848
2849 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2850
2851 * search.c (Fre_search_backward): Mention `case-fold-search' in
2852 all the re_search_* functions (bug#8138).
2853
2854 * keyboard.c (Fopen_dribble_file): Document when the file is
2855 closed (bug#8056).
2856
2857 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2858
2859 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2860 bidi_cache_idx.
2861
2862 Support bidi reordering of display and overlay strings.
2863 * xdisp.c (compute_display_string_pos)
2864 (compute_display_string_end): Accept additional argument STRING.
2865 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2866 (reseat_to_string): Initialize bidi_it->string.s and
2867 bidi_it->string.schars.
2868 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2869 NULL (avoids a crash in bidi_paragraph_init).
2870 Initialize itb.string.lstring.
2871 (init_iterator): Call bidi_init_it only of a valid
2872 buffer position was specified. Initialize paragraph_embedding to
2873 L2R.
2874 (reseat_to_string): Initialize the bidi iterator.
2875 (display_string): If we need to ignore text properties of
2876 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2877 original value of -1 will not work with bidi.)
2878 (compute_display_string_pos): First arg is now struct
2879 `text_pos *'; all callers changed. Support display properties on
2880 Lisp strings.
2881 (compute_display_string_end): Support display properties on Lisp
2882 strings.
2883 (init_iterator, reseat_1, reseat_to_string): Initialize the
2884 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2885 when iterating on a string not from display properties).
2886 (compute_display_string_pos, compute_display_string_end):
2887 Fix calculation of the object to scan. Fixes an error when using
2888 arrow keys.
2889 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2890 base_level_stop; instead, set base_level_stop to BEGV.
2891 Fixes crashes in vertical-motion.
2892 (next_element_from_buffer): Improve commentary for when
2893 the iterator is before prev_stop.
2894 (init_iterator): Initialize bidi_p from the default value of
2895 bidi-display-reordering, not from buffer-local value. Use the
2896 buffer-local value only if initializing for buffer iteration.
2897 (handle_invisible_prop): Support invisible properties on strings
2898 that are being bidi-reordered.
2899 (set_iterator_to_next): Support bidi reordering of C strings and
2900 Lisp strings.
2901 (next_element_from_string): Support bidi reordering of Lisp
2902 strings.
2903 (handle_stop_backwards): Support Lisp strings as well.
2904 (display_string): Support display of R2L glyph rows.
2905 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2906 (init_iterator): Don't initialize it->bidi_p for strings
2907 here.
2908 (reseat_to_string): Initialize it->bidi_p for strings here.
2909 (next_element_from_string, next_element_from_c_string)
2910 (next_element_from_buffer): Add xassert's for correspondence
2911 between IT's object being iterated and it->bidi_it.string
2912 structure.
2913 (face_before_or_after_it_pos): Support bidi iteration.
2914 (next_element_from_c_string): Handle the case of the first string
2915 character that is not the first one in the visual order.
2916 (get_visually_first_element): New function, refactored from common
2917 parts of next_element_from_buffer, next_element_from_string, and
2918 next_element_from_c_string.
2919 (tool_bar_lines_needed, redisplay_tool_bar)
2920 (display_menu_bar): Force left-to-right direction. Add a FIXME
2921 comment for making that be controlled by a user option.
2922 (push_it, pop_it): Save and restore the state of the
2923 bidi iterator. Save and restore the bidi_p flag.
2924 (pop_it): Iterate out of display property for string iteration as
2925 well.
2926 (iterate_out_of_display_property): Support iteration over strings.
2927 (handle_single_display_spec): Set up it->bidi_it for iteration
2928 over a display string, and call bidi_init_it.
2929 (handle_single_display_spec, next_overlay_string)
2930 (get_overlay_strings_1, push_display_prop): Set up the bidi
2931 iterator for displaying display or overlay strings.
2932 (forward_to_next_line_start): Don't use the shortcut if
2933 bidi-iterating.
2934 (back_to_previous_visible_line_start): If handle_display_prop
2935 pushed the iterator stack, restore the internal state of the bidi
2936 iterator by calling bidi_pop_it same number of times.
2937 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2938 and we are bidi-iterating, don't decrement the iterator position;
2939 instead, set the first_elt flag in the bidi iterator, to produce
2940 the same effect.
2941 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2942 (push_display_prop): xassert that we are iterating a buffer.
2943 (push_it, pop_it): Save and restore paragraph_embedding member.
2944 (handle_single_display_spec, next_overlay_string)
2945 (get_overlay_strings_1, reseat_1, reseat_to_string)
2946 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2947 correctly. Don't assume unibyte strings are not bidi-reordered.
2948 (compute_display_string_pos)
2949 (compute_display_string_end): Fix handling the case of C string.
2950 (push_it, pop_it): Save and restore from_disp_prop_p.
2951 (handle_single_display_spec, push_display_prop): Set the
2952 from_disp_prop_p flag.
2953 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2954 (pop_it): Call iterate_out_of_display_property only if we are
2955 popping after iteration over a string that came from a display
2956 property. Fix a typo in popping stretch info. Add an assertion
2957 for verifying that the iterator position is in sync with the bidi
2958 iterator.
2959 (handle_single_display_spec, get_overlay_strings_1)
2960 (push_display_prop): Fix initialization of paragraph direction for
2961 string when that of the parent object is not yet determined.
2962 (reseat_1): Call bidi_init_it to resync the bidi
2963 iterator with IT's position. (Bug#7616)
2964 (find_row_edges): If ROW->start.pos gives position
2965 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2966 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2967 Reset the from_disp_prop_p flag.
2968 (SAVE_IT, RESTORE_IT): New macros.
2969 (pos_visible_p, face_before_or_after_it_pos)
2970 (back_to_previous_visible_line_start)
2971 (move_it_in_display_line_to, move_it_in_display_line)
2972 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2973 (try_scrolling, redisplay_window, display_line): Use them when
2974 saving a temporary copy of the iterator and restoring it back.
2975 (back_to_previous_visible_line_start, reseat_1)
2976 (init_iterator): Empty the bidi cache "stack".
2977 (move_it_in_display_line_to): If iterator ended up at
2978 EOL, but we never saw any buffer positions smaller than
2979 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2980 motion in bidi-reordered lines.
2981 (move_it_in_display_line_to): Record prev_method and prev_pos
2982 immediately before the call to set_iterator_to_next. Fixes cursor
2983 motion in bidi-reordered lines with stretch glyphs and strings
2984 displayed in margins. (Bug#8133) (Bug#8867)
2985 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2986 TO_CHARPOS.
2987 (pos_visible_p): Support positions in bidi-reordered lines.
2988 Save and restore bidi cache.
2989
2990 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2991 (bidi_paragraph_info): Delete unused struct.
2992 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2993 (bidi_cache_start): New variable.
2994 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2995 to zero.
2996 (bidi_cache_fetch_state, bidi_cache_search)
2997 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2998 (bidi_cache_find, bidi_peek_at_next_level)
2999 (bidi_level_of_next_char, bidi_find_other_level_edge)
3000 (bidi_move_to_visually_next): Compare cache index with
3001 bidi_cache_start rather than with zero.
3002 (bidi_fetch_char): Accept new argument STRING; all callers
3003 changed. Support iteration over a string. Support strings with
3004 display properties. Support unibyte strings. Fix the type of
3005 `len' according to what STRING_CHAR_AND_LENGTH expects.
3006 (bidi_paragraph_init, bidi_resolve_explicit_1)
3007 (bidi_resolve_explicit, bidi_resolve_weak)
3008 (bidi_level_of_next_char, bidi_move_to_visually_next):
3009 Support iteration over a string.
3010 (bidi_set_sor_type, bidi_resolve_explicit_1)
3011 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3012 can now be zero (for strings); special values 0 and -1 were
3013 changed to -1 and -2, respectively.
3014 (bidi_char_at_pos): New function.
3015 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3016 Call it instead of FETCH_MULTIBYTE_CHAR.
3017 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3018 initialized to valid values.
3019 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3020 values.
3021 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3022 the test for valid cached positions. Fix the logic for looking up
3023 the sentinel state in the cache. GCPRO the Lisp string we are
3024 iterating.
3025 (bidi_push_it, bidi_pop_it): New functions.
3026 (bidi_initialize): Initialize the bidi cache start stack pointer.
3027 (bidi_cache_ensure_space): New function, refactored from part of
3028 bidi_cache_iterator_state. Don't assume the required size is just
3029 one BIDI_CACHE_CHUNK away.
3030 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3031 (bidi_count_bytes, bidi_char_at_pos): New functions.
3032 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3033 always valid if bidi_cache_idx is valid.
3034 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3035 is valid if it's going to be used.
3036 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3037 (bidi_cache_fetch_state, bidi_cache_search)
3038 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3039 (bidi_cache_iterator_state, bidi_cache_find)
3040 (bidi_find_other_level_edge, bidi_cache_start_stack):
3041 All variables related to cache indices are now EMACS_INT.
3042
3043 * dispextern.h (struct bidi_string_data): New structure.
3044 (struct bidi_it): New member `string'. Make flag members be 1-bit
3045 fields, and put them last in the struct.
3046 (compute_display_string_pos, compute_display_string_end):
3047 Update prototypes.
3048 (bidi_push_it, bidi_pop_it): Add prototypes.
3049 (struct iterator_stack_entry): New members bidi_p,
3050 paragraph_embedding, and from_disp_prop_p.
3051 (struct it): Member bidi_p is now a bit field 1 bit wide.
3052 (bidi_shelve_cache, bidi_unshelve_cache):
3053 Declare prototypes.
3054
3055 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3056 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3057 and vector-like objects.
3058
3059 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3060 cache around display iteration.
3061
3062 * window.c (Fwindow_end, window_scroll_pixel_based)
3063 (displayed_window_lines, Frecenter): Save and restore the bidi
3064 cache around display iteration.
3065
3066 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3067
3068 * editfns.c (Fdelete_region): Clarify the use of the named
3069 parameters (bug#6788).
3070
3071 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3072
3073 * indent.c (Fvertical_motion): Set and restore w->pointm when
3074 saving and restoring the window's buffer (Bug#9006).
3075
3076 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3077
3078 * editfns.c (Fstring_to_char): Clarify just what is returned
3079 (bug#6576). Text by Eli Zaretskii.
3080
3081 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3084
3085 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3086
3087 * buffer.c (mmap_find): Fix a typo.
3088
3089 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3090
3091 Fix execution of x selection hooks.
3092 * xselect.c (Qx_lost_selection_functions)
3093 (Qx_sent_selection_functions): New vars.
3094 (syms_of_xselect): DEFSYM them.
3095 (x_handle_selection_request): Pass Qx_sent_selection_functions
3096 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3097 (x_handle_selection_clear,x_clear_frame_selections):
3098 Pass Qx_lost_selection_functions rather than
3099 Vx_lost_selection_functions to Frun_hook_with_args.
3100
3101 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3104 The old code sometimes used this field without initializing it.
3105
3106 * alloc.c (gc_sweep): Don't read past end of array.
3107 In theory, the old code could also have corrupted Emacs internals,
3108 though it'd be very unlikely.
3109
3110 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3111
3112 * character.c (Fcharacterp): Don't advertise optional ignored
3113 argument. (Bug#4026)
3114
3115 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3116
3117 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3118 key" (bug#4257).
3119
3120 * window.c (Fset_window_start): Doc fix (bug#4199).
3121 (Fset_window_hscroll): Ditto.
3122
3123 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 Fix minor new problems caught by GCC 4.6.1.
3126 * term.c (init_tty): Remove unused local.
3127 * xsettings.c (store_monospaced_changed): Define this function only
3128 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3129 not used otherwise.
3130
3131 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3132
3133 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3134
3135 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3136
3137 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3138 are the mini-buffer and the echo area (bug#3320).
3139
3140 * term.c (init_tty): Remove support for supdup, c10 and perq
3141 terminals, which are no longer supported (bug#1482).
3142
3143 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3144
3145 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3146
3147 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3150 for non-popups (Bug#3642).
3151
3152 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3153
3154 * alloc.c (reset_malloc_hooks): Protoize.
3155 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3156 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3157 * cm.c (losecursor): Likewise.
3158 * data.c (fmod): Likewise.
3159 * dispnew.c (swap_glyphs_in_rows): Likewise.
3160 * emacs.c (memory_warning_signal): Likewise.
3161 * floatfns.c (float_error): Likewise.
3162 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3163 (otf_open, font_otf_capability, generate_otf_features)
3164 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3165 Likewise.
3166 * image.c (pbm_read_file): Likewise.
3167 * indent.c (string_display_width): Likewise.
3168 * intervals.c (check_for_interval, search_for_interval)
3169 (inc_interval_count, count_intervals, root_interval)
3170 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3171 * lread.c (defalias): Likewise.
3172 * ralloc.c (r_alloc_check): Likewise.
3173 * regex.c (set_image_of_range_1, set_image_of_range)
3174 (regex_grow_registers): Likewise.
3175 * sysdep.c (strerror): Likewise.
3176 * termcap.c (valid_filename_p, tprint, main): Likewise.
3177 * tparam.c (main): Likewise.
3178 * unexhp9k800.c (run_time_remap, save_data_space)
3179 (update_file_ptrs, read_header, write_header, calculate_checksum)
3180 (copy_file, copy_rest, display_header): Likewise.
3181 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3182 Likewise.
3183 * xdisp.c (check_it): Likewise.
3184 * xfaces.c (register_color, unregister_color, unregister_colors):
3185 Likewise.
3186 * xfns.c (print_fontset_result): Likewise.
3187 * xrdb.c (member, fatal, main): Likewise.
3188
3189 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 Fix minor problems found by static checking (Bug#9031).
3192 * chartab.c (char_table_set_range, map_sub_char_table):
3193 Remove unused locals.
3194 (uniprop_table): Now static.
3195 * composite.c (_work_char): Remove unused static var.
3196
3197 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3198
3199 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3200
3201 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3202
3203 * gtkutil.c (qttip_cb): Remove code without function.
3204
3205 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3206
3207 * w32.c (pthread_sigmask): New stub.
3208
3209 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3210
3211 Use pthread_sigmask, not sigprocmask (Bug#9010).
3212 sigprocmask is portable only for single-threaded applications, and
3213 Emacs can be multi-threaded when it uses GTK.
3214 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3215 (LIBES): Use it.
3216 * callproc.c (Fcall_process):
3217 * process.c (create_process):
3218 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3219 Use pthread_sigmask, not sigprocmask.
3220
3221 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3222
3223 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3224 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3225 wrong (Bug#8591).
3226
3227 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3228
3229 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3230 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3231 (xg_hide_tooltip): Fix comment.
3232
3233 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3234 in registerServicesMenuSendTypes.
3235 (validRequestorForSendType): Don't check ns_return_types.
3236
3237 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3238 ns_return_type.
3239
3240 2011-07-08 Jason Rumney <jasonr@gnu.org>
3241
3242 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3243 SH_SHOW for hidden windows (Bug#5482).
3244
3245 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3246 frame struct members of non-existent frames (Bug#6284).
3247
3248 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3249
3250 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3251 variable firstTime not needed on OSX >= 10.6.
3252 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3253 >= 10.5. Use setKnobProportion, setDoubleValue.
3254
3255 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3256 (MAC_OS_X_VERSION_10_5): Define if not defined.
3257 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3258 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3259 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3260
3261 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3262 cString and lossyCString on OSX >= 10.4
3263
3264 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3265 sizeToFit on OSX >= 10.2.
3266
3267 * nsimage.m (allocInitFromFile): Don't use deprecated method
3268 bestRepresentationForDevice on OSX >= 10.6.
3269
3270 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3271 to avoid warning.
3272
3273 * emacs.c: Declare unexec_init_emacs_zone.
3274
3275 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3276
3277 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3278
3279 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3280 on svcsMenu (Bug#8842).
3281
3282 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3283 ns_return_types.
3284 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3285
3286 * nsterm.m (QUTF8_STRING): Declare.
3287 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3288 (validRequestorForSendType): Return type is (id).
3289 Change indexOfObjectIdenticalTo to indexOfObject.
3290 Check if we have local selection before returning self (Bug#8842).
3291 (writeSelectionToPasteboard): Put local selection into paste board
3292 if we have a local selection (Bug#8842).
3293 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3294
3295 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3296 (ns_get_local_selection): Declare.
3297
3298 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3299
3300 * keymap.c (describe_map_tree): Don't insert a double newline at
3301 the end of the buffer (bug#1169) and return whether we inserted
3302 something.
3303
3304 * callint.c (Fcall_interactively): Change "reading args" to
3305 "providing args" to try to clarify what it does (bug#1010).
3306
3307 2011-07-07 Kenichi Handa <handa@m17n.org>
3308
3309 * composite.c (composition_compute_stop_pos): Ignore a static
3310 composition starting before CHARPOS (Bug#8915).
3311
3312 * xdisp.c (handle_composition_prop): Likewise.
3313
3314 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3315
3316 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3317 (Bug#9015)
3318
3319 2011-07-07 Kenichi Handa <handa@m17n.org>
3320
3321 * character.h (unicode_category_t): New enum type.
3322
3323 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3324 (Qchar_code_property_table): New variable.
3325 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3326 (UNIPROP_COMPRESSED_FORM_P): New macros.
3327 (char_table_ascii): Uncompress the compressed values.
3328 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3329 Uncompress the compressed values.
3330 (sub_char_table_ref_and_range): Likewise.
3331 (char_table_ref_and_range): Uncompress the compressed values.
3332 (sub_char_table_set): New arg is_uniprop. Callers changed.
3333 Uncompress the compressed values.
3334 (sub_char_table_set_range): Args changed. Callers changed.
3335 (char_table_set_range): Adjuted for the above change.
3336 (map_sub_char_table): Delete args default_val and parent. Add arg
3337 top. Give decoded values to a Lisp function.
3338 (map_char_table): Adjust for the above change. Give decoded
3339 values to a Lisp function. Gcpro more variables.
3340 (uniprop_table_uncompress)
3341 (uniprop_decode_value_run_length): New functions.
3342 (uniprop_decoder, uniprop_decoder_count): New variables.
3343 (uniprop_get_decoder, uniprop_encode_value_character)
3344 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3345 New functions.
3346 (uniprop_encoder, uniprop_encoder_count): New variables.
3347 (uniprop_get_encoder, uniprop_table)
3348 (Funicode_property_table_internal, Fget_unicode_property_internal)
3349 (Fput_unicode_property_internal): New functions.
3350 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3351 Sunicode_property_table_internal, Sget_unicode_property_internal,
3352 and Sput_unicode_property_internal. Defvar_lisp
3353 char-code-property-alist.
3354
3355 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3356 Vunicode_category_table.
3357
3358 * font.c (font_range): Adjust for the change of
3359 Vunicode_category_table.
3360
3361 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3362
3363 * m/iris4d.h: Remove file, move contents ...
3364 * s/irix6-5.h: ... here.
3365
3366 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 Remove unportable assumption about struct layout (Bug#8884).
3369 * alloc.c (mark_buffer):
3370 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3371 (clone_per_buffer_values): Don't assume that
3372 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3373 This isn't true in general, and it's particularly not true
3374 if Emacs is configured with --with-wide-int.
3375 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3376 New macros, used in the buffer.c change.
3377
3378 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * xsettings.c: Use both GConf and GSettings if both are available.
3381 (store_config_changed_event): Add comment.
3382 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3383 (store_tool_bar_style_changed): New functions.
3384 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3385 (struct xsettings): Move font inside HAVE_XFT.
3386 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3387 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3388 Move inside HAVE_XFT.
3389 (something_changed_gsettingsCB): Rename from something_changedCB.
3390 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3391 also.
3392 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3393 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3394 (something_changed_gconfCB): Rename from something_changedCB.
3395 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3396 (parse_settings): Move check for font inside HAVE_XFT.
3397 (read_settings, apply_xft_settings): Add comment.
3398 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3399 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3400 call store_font_name_changed.
3401 (xft_settings_event): Add comment.
3402 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3403 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3404 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3405 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3406 (xsettings_initialize): Call init_gsettings last.
3407 (xsettings_get_system_font, xsettings_get_system_normal_font):
3408 Add comment.
3409
3410 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 Random fixes. E.g., (random) never returned negative values.
3413 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3414 subseconds part to the entropy, as that's a bit more random.
3415 Prefer signed to unsigned, since the signedness doesn't matter and
3416 in general we prefer signed. When given a limit, use a
3417 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3418 latter isn't right if USE_2_TAGS_FOR_INTS.
3419 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3420 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3421
3422 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3423
3424 * textprop.c (text_property_stickiness):
3425 Obey Vtext_property_default_nonsticky.
3426 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3427 * w32fns.c (syms_of_w32fns):
3428 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3429
3430 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3431
3432 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3433 This is more efficient than Ffile_directory_p and avoids a minor race.
3434
3435 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3436
3437 * buffer.c (Foverlay_put): Say what the return value is
3438 (bug#7835).
3439
3440 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3441 is a directory before asking whether to use the file name
3442 (bug#7564).
3443 (barf_or_query_if_file_exists): Make the "File is a directory"
3444 error be more correct.
3445
3446 * fns.c (Frequire): Remove the mention of the .gz files, since
3447 that's installation-specific, but keep the mention of
3448 `get-load-suffixes'.
3449
3450 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3453 Report string overflow if the output is too long.
3454
3455 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3458 (syms_of_gnutls): Remove duplicate DEFSYM for
3459 Qgnutls_bootprop_verify_hostname_error, an error for
3460 Qgnutls_bootprop_verify_error (which is no longer used).
3461
3462 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3463 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3464 Also (re)move comments that are misplaced or no longer relevant.
3465
3466 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3467
3468 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3469
3470 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3471
3472 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3473 and background color parameters if they have been changed.
3474
3475 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3476
3477 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3478
3479 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * xsettings.c (SYSTEM_FONT): Define only when used.
3482 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3483
3484 * keymap.c (access_keymap_1): Now static.
3485
3486 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3487
3488 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3489 leave any prefix arg for the up event (Bug#1586).
3490
3491 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3492
3493 * lread.c (syms_of_lread): Mention single symbols defined by
3494 `defvar' or `defconst' (bug#7154).
3495
3496 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3497 (Frequire): Mention get-load-suffixes.
3498
3499 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3500
3501 * window.h (window): Remove clone_number slot.
3502 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3503 Remove.
3504 (make_parent_window, make_window, saved_window)
3505 (Fset_window_configuration, save_window_save): Don't deal with
3506 clone numbers.
3507 * buffer.c (Qclone_number): Remove declaration.
3508 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3509
3510 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 Add multiple inheritance to keymaps.
3513 * keymap.c (Fmake_composed_keymap): New function.
3514 (Fset_keymap_parent): Simplify.
3515 (fix_submap_inheritance): Remove.
3516 (access_keymap_1): New function extracted from access_keymap to handle
3517 embedded parents and handle lists of maps.
3518 (access_keymap): Use it.
3519 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3520 (Fcopy_keymap): Handle embedded parents.
3521 (Fcommand_remapping, define_as_prefix): Simplify.
3522 (Fkey_binding): Simplify.
3523 (syms_of_keymap): Move minibuffer-local-completion-map,
3524 minibuffer-local-filename-completion-map,
3525 minibuffer-local-must-match-map, and
3526 minibuffer-local-filename-must-match-map to Elisp.
3527 (syms_of_keymap): Defsubr make-composed-keymap.
3528 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3529 (parse_menu_item): Trivial simplification.
3530
3531 2011-07-01 Glenn Morris <rgm@gnu.org>
3532
3533 * Makefile.in (SETTINGS_LIBS): Fix typo.
3534
3535 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3536
3537 * coding.c (Fencode_coding_string): Record the last coding system
3538 used, as the function doc string says (bug#8738).
3539
3540 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3541
3542 * xsettings.c (store_monospaced_changed): Take new font as arg and
3543 check for change against current_mono_font.
3544 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3545 (emacs_settings_constructor, emacs_settings_get_property)
3546 (emacs_settings_set_property, emacs_settings_class_init)
3547 (emacs_settings_init, gsettings_obj): Remove.
3548 (something_changedCB): New function for HAVE_GSETTINGS.
3549 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3550 with value as argument.
3551 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3552 g_settings_new (Bug#8967). Do not create gsettings_obj.
3553 Remove calls to g_settings_bind. Connect something_changedCB to
3554 "changed".
3555
3556 * xgselect.c: Add defined (HAVE_GSETTINGS).
3557 (xgselect_initialize): Ditto.
3558
3559 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3560 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3561 xg_select.
3562
3563 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * eval.c (struct backtrace): Simplify and port the data structure.
3566 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3567 signed bit field, as this assumption is not portable and it makes
3568 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3569 "char debug_on_exit : 1" as this is not portable either; instead,
3570 use the portable "unsigned int debug_on_exit : 1". Remove unused
3571 member evalargs. Remove obsolete comments about cc bombing out.
3572
3573 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3576 Let HAVE_GSETTINGS override HAVE_GCONF.
3577 (store_monospaced_changed): New function.
3578 (EMACS_SETTINGS): A new type derived from GObject to handle
3579 GSettings notifications.
3580 (emacs_settings_constructor, emacs_settings_get_property)
3581 (emacs_settings_set_property, emacs_settings_class_init):
3582 New functions.
3583 (gsettings_client, gsettings_obj): New variables.
3584 (GSETTINGS_SCHEMA): New define.
3585 (something_changedCB): Call store_monospaced_changed.
3586 (init_gsettings): New function.
3587 (xsettings_initialize): Call init_gsettings.
3588 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3589 to NULL.
3590
3591 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3592 GCONF_CFLAGS/LIBS.
3593
3594 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3595
3596 * window.c (resize_root_window, grow_mini_window)
3597 (shrink_mini_window): Rename Qresize_root_window to
3598 Qwindow_resize_root_window and Qresize_root_window_vertically to
3599 Qwindow_resize_root_window_vertically.
3600
3601 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3604
3605 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * makefile.w32-in: Redesign dependencies so they reflect more
3608 clearly which files are directly included by each source file,
3609 and not through other includes.
3610
3611 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3612
3613 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3614 (sort_overlays, overlay_strings): When an overlay's clone number
3615 matches the window's clone number process the overlay even if
3616 the overlay's window property doesn't match the current window.
3617
3618 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3619 (Fwindow_hchild): Rename to Fwindow_left_child.
3620 (Fwindow_next): Rename to Fwindow_next_sibling.
3621 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3622 (resize_window_check): Rename to window_resize_check.
3623 (resize_window_apply): Rename to window_resize_apply.
3624 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3625 (Fdelete_other_windows_internal, resize_frame_windows)
3626 (Fsplit_window_internal, Fdelete_window_internal)
3627 (grow_mini_window, shrink_mini_window)
3628 (Fresize_mini_window_internal): Fix callers accordingly.
3629
3630 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3631
3632 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3633 (emacs_fixed_set_min_size): Remove.
3634 (emacs_fixed_new): Take frame as argument.
3635
3636 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3637 (_EmacsFixedPrivate): Remove minwidth/height.
3638 Add struct frame *f.
3639 (emacs_fixed_init): Initialize priv->f.
3640 (get_parent_class, emacs_fixed_set_min_size): Remove.
3641 (emacs_fixed_new): Set priv->f to argument.
3642 (emacs_fixed_get_preferred_width)
3643 (emacs_fixed_get_preferred_height): Use min_width/height from
3644 frames size_hint to set minimum and natural (Bug#8919).
3645 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3646 and use min_width/height from frames size_hint to set
3647 min_width/height (Bug#8919).
3648
3649 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3650 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3651 Fix indentation.
3652
3653 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3654
3655 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3656 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3657 called at ZV.
3658
3659 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3660
3661 * process.c (wait_reading_process_output): Bypass select if
3662 waiting for a cell while ignoring keyboard input, and input is
3663 pending. Suggested by Jan Djärv (Bug#8869).
3664
3665 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 Use gnulib's dup2 module instead of rolling our own.
3668 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3669
3670 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3671
3672 * dispnew.c (scrolling_window): Before scrolling, turn off a
3673 mouse-highlight in the window being scrolled.
3674
3675 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3676
3677 Move DEFSYM to lisp.h and use everywhere.
3678
3679 * character.h (DEFSYM): Move declaration...
3680 * lisp.h (DEFSYM): ...here.
3681
3682 * gnutls.c:
3683 * minibuf.c:
3684 * w32menu.c:
3685 * w32proc.c:
3686 * w32select.c: Don't include character.h.
3687
3688 * alloc.c (syms_of_alloc):
3689 * buffer.c (syms_of_buffer):
3690 * bytecode.c (syms_of_bytecode):
3691 * callint.c (syms_of_callint):
3692 * casefiddle.c (syms_of_casefiddle):
3693 * casetab.c (init_casetab_once):
3694 * category.c (init_category_once, syms_of_category):
3695 * ccl.c (syms_of_ccl):
3696 * cmds.c (syms_of_cmds):
3697 * composite.c (syms_of_composite):
3698 * dbusbind.c (syms_of_dbusbind):
3699 * dired.c (syms_of_dired):
3700 * dispnew.c (syms_of_display):
3701 * doc.c (syms_of_doc):
3702 * editfns.c (syms_of_editfns):
3703 * emacs.c (syms_of_emacs):
3704 * eval.c (syms_of_eval):
3705 * fileio.c (syms_of_fileio):
3706 * fns.c (syms_of_fns):
3707 * frame.c (syms_of_frame):
3708 * fringe.c (syms_of_fringe):
3709 * insdel.c (syms_of_insdel):
3710 * keymap.c (syms_of_keymap):
3711 * lread.c (init_obarray, syms_of_lread):
3712 * macros.c (syms_of_macros):
3713 * msdos.c (syms_of_msdos):
3714 * print.c (syms_of_print):
3715 * process.c (syms_of_process):
3716 * search.c (syms_of_search):
3717 * sound.c (syms_of_sound):
3718 * syntax.c (init_syntax_once, syms_of_syntax):
3719 * terminal.c (syms_of_terminal):
3720 * textprop.c (syms_of_textprop):
3721 * undo.c (syms_of_undo):
3722 * w32.c (globals_of_w32):
3723 * window.c (syms_of_window):
3724 * xdisp.c (syms_of_xdisp):
3725 * xfaces.c (syms_of_xfaces):
3726 * xfns.c (syms_of_xfns):
3727 * xmenu.c (syms_of_xmenu):
3728 * xsettings.c (syms_of_xsettings):
3729 * xterm.c (syms_of_xterm): Use DEFSYM.
3730
3731 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3732
3733 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3734
3735 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 Integer and buffer overflow fixes (Bug#8873).
3738
3739 * print.c (printchar, strout): Check for string overflow.
3740 (PRINTPREPARE, printchar, strout):
3741 Don't set size unless allocation succeeds.
3742
3743 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3744 for sizes. Check for string overflow more accurately.
3745 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3746
3747 * macros.c: Integer and buffer overflow fixes.
3748 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3749 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3750 Use ptrdiff_t, not int, for sizes.
3751 Don't increment bufsize until after realloc succeeds.
3752 Check for size-calculation overflow.
3753 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3754
3755 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3756
3757 * lread.c: Integer overflow fixes.
3758 (read_integer): Radix is now EMACS_INT, not int,
3759 to improve quality of diagnostics for out-of-range radices.
3760 Calculate buffer size correctly for out-of-range radices.
3761 (read1): Check for integer overflow in radices, and in
3762 read-circle numbers.
3763 (read_escape): Avoid int overflow.
3764 (Fload, openp, read_buffer_size, read1)
3765 (substitute_object_recurse, read_vector, read_list, map_obarray):
3766 Use ptrdiff_t, not int, for sizes.
3767 (read1): Use EMACS_INT, not int, for sizes.
3768 Check for size overflow.
3769
3770 * image.c (cache_image): Check for size arithmetic overflow.
3771
3772 * lread.c: Integer overflow issues.
3773 (saved_doc_string_size, saved_doc_string_length)
3774 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3775 Now ptrdiff_t, not int.
3776 (read1): Don't assume doc string length fits in int. Check for
3777 out-of-range doc string lengths.
3778 (read_list): Don't assume file position fits in int.
3779 (read_escape): Check for hex character overflow.
3780
3781 2011-06-22 Leo Liu <sdl.web@gmail.com>
3782
3783 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3784 Move to minibuffer.el.
3785
3786 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3787
3788 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3789 The following patches are for when GLYPH_DEBUG && !XASSERT.
3790 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3791 * dispnew.c (flush_stdout):
3792 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3793 Mark as externally visible.
3794 * dispnew.c (check_window_matrix_pointers): Now static.
3795 * dispnew.c (window_to_frame_vpos):
3796 * xfns.c (unwind_create_frame):
3797 * xterm.c (x_check_font): Remove unused local.
3798 * scroll.c (CHECK_BOUNDS):
3799 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3800 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3801 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3802 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3803 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3804 Now static.
3805 (debug_method_add): Use va_list and vsprintf rather than relying
3806 on undefined behavior with wrong number of arguments.
3807 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3808 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3809 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3810 since we're not interested in debugging glyphs with old libraries.
3811 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3812 GCC 4.6.0's static checking.
3813
3814 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 Integer overflow and signedness fixes (Bug#8873).
3817 A few related buffer overrun fixes, too.
3818
3819 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3820
3821 * dispextern.h (struct face.stipple):
3822 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3823 (x_bitmap_mask, x_allocate_bitmap_record)
3824 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3825 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3826 (x_create_bitmap_from_xpm_data):
3827 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3828 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3829 (.bitmaps_last):
3830 * xfaces.c (load_pixmap):
3831 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3832 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3833 (.bitmaps_last, struct x_output.icon_bitmap):
3834 Use ptrdiff_t, not int, for bitmap indexes.
3835 (x_allocate_bitmap_record): Check for size overflow.
3836 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3837
3838 Use ptrdiff_t, not int, for overlay counts.
3839 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3840 * editfns.c (overlays_around, get_pos_property):
3841 * textprop.c (get_char_property_and_overlay):
3842 * xdisp.c (next_overlay_change, note_mouse_highlight):
3843 * xfaces.c (face_at_buffer_position):
3844 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3845 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3846 (Fnext_overlay_change, Fprevious_overlay_change)
3847 (mouse_face_overlay_overlaps, Foverlays_in):
3848 Use ptrdiff_t, not int, for sizes.
3849 (overlays_at, overlays_in): Check for size-calculation overflow.
3850
3851 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3852
3853 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3854 (x_session_initialize): Do not assume string length fits in int.
3855
3856 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3857 This is unlikely, but can occur if DPI is outlandish.
3858
3859 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3860 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3861
3862 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3863 * xrdb.c (magic_file_p, search_magic_path):
3864 Omit last arg SUFFIX; it was always 0. All callers changed.
3865 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3866
3867 * xfont.c (xfont_match): Avoid need for strlen.
3868
3869 * xfns.c: Don't assume strlen fits in int.
3870 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3871
3872 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3873 not unsigned long, as we prefer signed integers. All callers changed.
3874 Detect integer overflow in repeat count.
3875 (message_dolog): Don't assume print length fits in 39 bytes.
3876 (display_mode_element): Don't assume strlen fits in int.
3877
3878 * termcap.c: Don't assume sizes fit in int and never overflow.
3879 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3880 (gobble_line): Check for size-calculation overflow.
3881
3882 * minibuf.c (Fread_buffer):
3883 * lread.c (intern, intern_c_string):
3884 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3885 Don't assume string length fits in int.
3886
3887 * keyboard.c (parse_tool_bar_item):
3888 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3889
3890 * font.c: Don't assume string length fits in int.
3891 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3892 Use ptrdiff_t, not int.
3893 (font_intern_prop): Don't assume string length fits in int.
3894 Don't assume integer property fits in fixnum.
3895 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3896
3897 * filelock.c: Fix some buffer overrun and integer overflow issues.
3898 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3899 Reformulate so as not to need the command string.
3900 Invoke gzip -cd rather than gunzip, as it's more portable.
3901 (lock_info_type, lock_file_1, lock_file):
3902 Don't assume pid_t and time_t fit in unsigned long.
3903 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3904 (current_lock_owner): Prefer signed type for sizes.
3905 Use memcpy, not strncpy, where memcpy is what is really wanted.
3906 Don't assume (via atoi) that time_t and pid_t fit in int.
3907 Check for time_t and/or pid_t out of range, e.g., via a network share.
3908 Don't alloca where an auto var works fine.
3909
3910 * fileio.c: Fix some integer overflow issues.
3911 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3912 Don't assume string length fits in int.
3913 (directory_file_name): Don't assume string length fits in long.
3914 (make_temp_name): Don't assume pid fits in int, or that its print
3915 length is less than 20.
3916
3917 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3918
3919 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3920
3921 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3922
3923 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3924 We prefer signed integers, even for size calculations.
3925
3926 * emacs.c: Don't assume string length fits in 'int'.
3927 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3928 (main): Don't invoke strlen when not needed.
3929
3930 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3931 (XD_DEBUG_MESSAGE): Don't waste a byte.
3932
3933 * callproc.c (getenv_internal_1, getenv_internal)
3934 (Fgetenv_internal):
3935 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3936
3937 * lread.c (invalid_syntax): Omit length argument.
3938 All uses changed. This doesn't fix a bug, but it simplifies the
3939 code away from its former Hollerith-constant appearance, and it's
3940 one less 'int' to worry about when looking at integer-overflow issues.
3941 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3942
3943 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3944 This didn't break anything, but it didn't help either.
3945 It's confusing to put a bogus integer in a place where the actual
3946 value does not matter.
3947 (LIST_END_P): Remove unused macro and its bogus comment.
3948 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3949
3950 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3951 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3952 implementation.
3953 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3954 We prefer signed types, and the value cannot exceed the EMACS_INT
3955 range anyway (because otherwise the length would not be representable).
3956 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3957 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3958 This avoids a GCC warning when WIDE_EMACS_INT.
3959
3960 * indent.c (sane_tab_width): New function.
3961 (current_column, scan_for_column, Findent_to, position_indentation)
3962 (compute_motion): Use it. This is just for clarity.
3963 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3964
3965 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3966
3967 * lisp.h (lint_assume): New macro.
3968 * composite.c (composition_gstring_put_cache):
3969 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3970
3971 * editfns.c, insdel.c:
3972 Omit unnecessary forward decls, to simplify future changes.
3973
3974 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3975
3976 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3977
3978 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3979 Use much-faster test for byte-length change.
3980 Don't assume string byte-length fits in 'int'.
3981 Check that character arg fits in 'int'.
3982 (mapcar1): Declare byte as byte, for clarity.
3983
3984 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3985
3986 * fns.c (concat): Catch string overflow earlier.
3987 Do not rely on integer wraparound.
3988
3989 * dispextern.h (struct it.overlay_strings_charpos)
3990 (struct it.selective): Now EMACS_INT, not int.
3991 * xdisp.c (forward_to_next_line_start)
3992 (back_to_previous_visible_line_start)
3993 (reseat_at_next_visible_line_start, next_element_from_buffer):
3994 Don't arbitrarily truncate the value of 'selective' to int.
3995
3996 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3997
3998 * composite.c: Don't truncate sizes to 'int'.
3999 (composition_gstring_p, composition_reseat_it)
4000 (composition_adjust_point): Use EMACS_INT, not int.
4001 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4002 not EMACS_UINT, for indexes.
4003
4004 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4005
4006 * buffer.c: Include <verify.h>.
4007 (struct sortvec.priority, struct sortstr.priority):
4008 Now EMACS_INT, not int.
4009 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4010 (struct sortstr.size, record_overlay_string)
4011 (struct sortstrlist.size, struct sortlist.used):
4012 Don't truncate size to int.
4013 (record_overlay_string): Check for size-calculation overflow.
4014 (init_buffer_once): Check at compile-time, not run-time.
4015
4016 2011-06-22 Jim Meyering <meyering@redhat.com>
4017
4018 Don't leak an XBM-image-sized buffer
4019 * image.c (xbm_load): Free the image buffer after using it.
4020
4021 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4022
4023 Port to Sun C.
4024 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4025 that Sun C diagnosed.
4026 * fns.c (secure_hash): Fix pointer signedness issue.
4027 * intervals.c (static_offset_intervals): New function.
4028 (offset_intervals): Use it.
4029
4030 2011-06-21 Leo Liu <sdl.web@gmail.com>
4031
4032 * deps.mk (fns.o):
4033 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4034 sha512.h.
4035
4036 * fns.c (secure_hash): Rename from crypto_hash_function and change
4037 the first arg to accept symbols.
4038 (Fsecure_hash): New primitive.
4039 (syms_of_fns): New symbols.
4040
4041 2011-06-20 Deniz Dogan <deniz@dogan.se>
4042
4043 * process.c (Fset_process_buffer): Clarify return value in
4044 docstring.
4045
4046 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4047
4048 * dispnew.c (add_window_display_history): Use BVAR.
4049
4050 * xdisp.c (debug_method_add): Use BVAR.
4051 (check_window_end, dump_glyph_matrix, dump_glyph)
4052 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4053
4054 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4055 Likewise.
4056
4057 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4058 check till after the cache is created in init_frame_faces.
4059
4060 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4061
4062 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4063
4064 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4067 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4068 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4069
4070 Improve buffer-overflow checking (Bug#8873).
4071 * fileio.c (Finsert_file_contents):
4072 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4073 Remove the old (too-loose) buffer overflow checks.
4074 They weren't needed, since make_gap checks for buffer overflow.
4075 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4076 The old code merely checked for Emacs fixnum overflow, and relied
4077 on undefined (wraparound) behavior. The new code avoids undefined
4078 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4079
4080 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4081 Tune. Don't use wider integers than needed. Don't use alloca.
4082 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4083
4084 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4085
4086 * insdel.c, lisp.h (buffer_overflow): New function.
4087 (insert_from_buffer_1, replace_range, replace_range_2):
4088 * insdel.c (make_gap_larger):
4089 * editfns.c (Finsert_char):
4090 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4091
4092 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4093
4094 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4095
4096 Integer overflow and signedness fixes (Bug#8873).
4097
4098 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4099 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4100
4101 * fileio.c: Don't assume EMACS_INT fits in off_t.
4102 (emacs_lseek): New static function.
4103 (Finsert_file_contents, Fwrite_region): Use it.
4104 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4105
4106 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4107
4108 * fns.c: Don't overflow int when computing a list length.
4109 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4110 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4111 truncation on 64-bit hosts. Check for QUIT every
4112 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4113 faster and is responsive enough.
4114 (Flength): Report an error instead of overflowing an integer.
4115 (Fsafe_length): Return a float if the value is not representable
4116 as a fixnum. This shouldn't happen except in contrived situations.
4117 (Fnthcdr, Fsort): Don't assume list length fits in int.
4118 (Fcopy_sequence): Don't assume vector length fits in int.
4119
4120 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4121 (header_size, word_size): New constants.
4122 (allocate_vectorlike): Don't check size overflow here.
4123 (allocate_vector): Check it here instead, since this is the only
4124 caller of allocate_vectorlike that could cause overflow.
4125 Check that the new vector's length is representable as a fixnum.
4126
4127 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4128 The previous code was bogus. For example, next_almost_prime (32)
4129 returned 39, which is undesirable as it is a multiple of 3; and
4130 next_almost_prime (24) returned 25, which is a multiple of 5 so
4131 why was the code bothering to check for multiples of 7?
4132
4133 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4134
4135 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4136
4137 Variadic C functions now count arguments with ptrdiff_t.
4138 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4139 Back then I didn't know that the Emacs coding style prefers signed int.
4140 Also, in the meantime I found a few more instances where arguments
4141 were being counted with int, which may truncate counts on 64-bit
4142 machines, or EMACS_INT, which may be unnecessarily wide.
4143 * lisp.h (struct Lisp_Subr.function.aMANY)
4144 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4145 Arg counts are now ptrdiff_t, not size_t.
4146 All variadic functions and their callers changed accordingly.
4147 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4148 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4149 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4150 * callint.c (Fcall_interactively): Check arg count for overflow,
4151 to avoid potential buffer overrun. Use signed char, not 'int',
4152 for 'varies' array, so that we needn't bother to check its size
4153 calculation for overflow.
4154 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4155 * eval.c (apply_lambda):
4156 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4157 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4158 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4159
4160 * callint.c (Fcall_interactively): Don't use index var as event count.
4161
4162 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4163 * mem-limits.h (SIZE): Remove; no longer used.
4164
4165 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4166
4167 Remove unnecessary casts.
4168 * xterm.c (x_term_init):
4169 * xfns.c (x_set_border_pixel):
4170 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4171 These aren't needed now that we assume ANSI C.
4172
4173 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4174 It's more likely to cause problems (due to unsigned overflow)
4175 than to cure them.
4176
4177 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4178
4179 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4180
4181 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4182
4183 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4184
4185 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4186
4187 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4188
4189 GLYPH_CODE_FACE returns EMACS_INT, not int.
4190 * dispextern.h (merge_faces):
4191 * xfaces.c (merge_faces):
4192 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4193 Don't assume EMACS_INT fits in int.
4194
4195 * character.h (CHAR_VALID_P): Remove unused parameter.
4196 * fontset.c, lisp.h, xdisp.c: All uses changed.
4197
4198 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4199
4200 * fns.c (concat): Minor tuning based on overflow analysis.
4201 This doesn't fix any bugs. Use int to hold character, instead
4202 of constantly refetching from Emacs object. Use XFASTINT, not
4203 XINT, for value known to be a character. Don't bother comparing
4204 a single byte to 0400, as it's always less.
4205
4206 * floatfns.c (Fexpt):
4207 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4208
4209 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4210 for characters.
4211
4212 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4213
4214 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4215 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4216 incorrectly succeed when S was a string, because 4294967386 was
4217 truncated before it was used.
4218
4219 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4220 Otherwise, an out-of-range integer could cause undefined behavior
4221 on a 64-bit host.
4222
4223 * composite.c: Use int, not EMACS_INT, for characters.
4224 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4225 EMACS_INT, for values that are known to be in character range.
4226 This doesn't fix any bugs but is the usual style inside Emacs and
4227 may generate better code on 32-bit machines.
4228
4229 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4230 This is for reasons similar to the recent CHAR_STRING fix.
4231 * charset.c (Fencode_char): Check that character arg is actually
4232 a character. Pass an int to ENCODE_CHAR.
4233 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4234 wider than 'int', as a compile-time check to prevent future regressions
4235 in this area.
4236
4237 * character.c (char_string): Remove unnecessary casts.
4238
4239 Make sure a 64-bit char is never passed to CHAR_STRING.
4240 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4241 by silently ignoring the top 32 bits, allowing some values
4242 that were far too large to be valid characters.
4243 * character.h: Include <verify.h>.
4244 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4245 arguments are no wider than unsigned, as a compile-time check
4246 to prevent future regressions in this area.
4247 * data.c (Faset):
4248 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4249 (Fsubst_char_in_region):
4250 * fns.c (concat):
4251 * xdisp.c (decode_mode_spec_coding):
4252 Adjust to CHAR_STRING's new requirement.
4253 * editfns.c (Finsert_char, Fsubst_char_in_region):
4254 * fns.c (concat): Check that character args are actually
4255 characters. Without this test, these functions did the wrong
4256 thing with wildly out-of-range values on 64-bit hosts.
4257
4258 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4259 These casts should not be needed on 32-bit hosts, either.
4260 * keyboard.c (read_char):
4261 * lread.c (Fload): Remove casts to unsigned.
4262
4263 * lisp.h (UNSIGNED_CMP): New macro.
4264 This fixes comparison bugs on 64-bit hosts.
4265 (ASCII_CHAR_P): Use it.
4266 * casefiddle.c (casify_object):
4267 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4268 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4269 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4270 * dispextern.h (FACE_FROM_ID):
4271 * keyboard.c (read_char): Use UNSIGNED_CMP.
4272
4273 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4274 not to EMACS_INT, to avoid GCC warning.
4275
4276 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4277
4278 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4279 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4280 isn't needed on 32-bit machines.
4281
4282 * buffer.c (Fgenerate_new_buffer_name):
4283 Use EMACS_INT for count, not int.
4284 (advance_to_char_boundary): Return EMACS_INT, not int.
4285
4286 * data.c (Qcompiled_function): Now static.
4287
4288 * window.c (window_body_lines): Now static.
4289
4290 * image.c (gif_load): Rename local to avoid shadowing.
4291
4292 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4293 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4294 * alloc.c (make_save_value): Integer argument is now of type
4295 ptrdiff_t, not int.
4296 (mark_object): Use ptrdiff_t, not int.
4297 * lisp.h (pD): New macro.
4298 * print.c (print_object): Use it.
4299
4300 * alloc.c: Use EMACS_INT, not int, to count objects.
4301 (total_conses, total_markers, total_symbols, total_vector_size)
4302 (total_free_conses, total_free_markers, total_free_symbols)
4303 (total_free_floats, total_floats, total_free_intervals)
4304 (total_intervals, total_strings, total_free_strings):
4305 Now EMACS_INT, not int. All uses changed.
4306 (Fgarbage_collect): Compute overall total using a double, so that
4307 integer overflow is less likely to be a problem. Check for overflow
4308 when converting back to an integer.
4309 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4310 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4311 These were 'int' variables that could overflow on 64-bit hosts;
4312 they were never used, so remove them instead of repairing them.
4313 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4314 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4315 Previously, this ceilinged at INT_MAX, but that doesn't work on
4316 64-bit machines.
4317 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4318
4319 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4320 (allocate_vectorlike): Check for ptrdiff_t overflow.
4321 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4322 when a (possibly-narrower) signed value would do just as well.
4323 We prefer using signed arithmetic, to avoid comparison confusion.
4324
4325 * alloc.c: Catch some string size overflows that we were missing.
4326 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4327 for convenience in STRING_BYTES_MAX.
4328 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4329 The definition here is exact; the one in lisp.h was approximate.
4330 (allocate_string_data): Check for string overflow. This catches
4331 some instances we weren't catching before. Also, it catches
4332 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4333 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4334 and ptrdiff_t and EMACS_INT are both 64 bits.
4335
4336 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4337 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4338 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4339
4340 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4341
4342 * alloc.c (Fmake_string): Check for out-of-range init.
4343
4344 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4345
4346 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4347
4348 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4349
4350 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4351 xg_get_default_scrollbar_width.
4352
4353 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4354 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4355 (style_changed_cb): Call update_theme_scrollbar_width and call
4356 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4357 all frames (Bug#8505).
4358 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4359 Call gtk_window_set_resizable if HAVE_GTK3.
4360 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4361 and height if HAVE_GTK3 (Bug#8505).
4362 (scroll_bar_width_for_theme): New variable.
4363 (update_theme_scrollbar_width): New function.
4364 (xg_get_default_scrollbar_width): Move code to
4365 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4366 (xg_initialize): Call update_theme_scrollbar_width.
4367
4368 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4369
4370 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4371
4372 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4373
4374 * frame.c (make_frame): Call other_buffer_safely instead of
4375 other_buffer.
4376
4377 * window.c (temp_output_buffer_show): Call display_buffer with
4378 second argument Vtemp_buffer_show_specifiers and reset latter
4379 immediately after the call.
4380 (Vtemp_buffer_show_specifiers): New variable.
4381 (auto_window_vscroll_p, next_screen_context_lines)
4382 (Vscroll_preserve_screen_position): Remove leading asterisks from
4383 doc-strings.
4384
4385 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Fix minor problems found by GCC 4.6.0 static checking.
4388 * buffer.c (Qclone_number): Remove for now, as it's unused.
4389 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4390 (record_buffer): Remove unused local.
4391 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4392 (set_frame_buffer_list): Remove; unused.
4393 * frame.h (other_visible_frames): Remove decl.
4394 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4395 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4396 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4397 if HAVE_GPM.
4398 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4399 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4400 Define only if HAVE_GPM.
4401 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4402 (update_hints_inhibit): Remove; never set. All uses removed.
4403 * widgetprv.h (emacsFrameClassRec): Remove decl.
4404 * window.c (delete_deletable_window): Now returns void, since it
4405 wasn't returning anything.
4406 (compare_window_configurations): Remove unused locals.
4407 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4408 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4409 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4410 the same widths as pointers. This follows up on the 2011-05-06 patch.
4411 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4412 * xterm.h: Likewise.
4413 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4414
4415 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4416
4417 * makefile.w32-in: Update dependencies.
4418 (LISP_H): Add lib/intprops.h.
4419
4420 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4421
4422 * image.c (gif_load): Add animation frame delay to the metadata.
4423 (syms_of_image): Use DEFSYM. New symbol `delay'.
4424
4425 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4426
4427 * window.c (delete_deletable_window): Re-add.
4428 (Fset_window_configuration): Rewrite to handle dead buffers and
4429 consequently deletable windows.
4430 (window_tree, Fwindow_tree): Remove. Supply functionality in
4431 window.el.
4432 (compare_window_configurations): Simplify code.
4433
4434 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4435
4436 * image.c (imagemagick_load_image): Fix type mismatch.
4437 (Fimagemagick_types): Likewise.
4438
4439 * window.h (replace_buffer_in_windows): Declare.
4440
4441 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4442
4443 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4444 Qclone_number. Remove external declaration of Qdelete_window.
4445 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4446 code.
4447 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4448 Run Qbuffer_list_update_hook if allowed.
4449 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4450 buffer list implementation.
4451 (other_buffer_safely): New function.
4452 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4453 calls to replace_buffer_in_windows and
4454 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4455 if allowed.
4456 (record_buffer): Inhibit quitting and rewrite using quittable
4457 functions. Run Qbuffer_list_update_hook if allowed.
4458 (Frecord_buffer, Funrecord_buffer): New functions.
4459 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4460 Move switch-to-buffer to window.el.
4461 (bury-buffer): Move to window.el.
4462 (Vbuffer_list_update_hook): New variable.
4463
4464 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4465 section.
4466
4467 * window.h (resize_frame_windows): Move up in code.
4468 (Fwindow_frame): Remove EXFUN.
4469 (replace_buffer_in_all_windows): Remove prototype.
4470 (replace_buffer_in_windows_safely): Add prototype.
4471
4472 * window.c: Declare Qdelete_window static again. Move down
4473 declaration of select_count.
4474 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4475 (Fother_window): Move to window.el.
4476 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4477 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4478 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4479 window.el.
4480 (replace_buffer_in_windows): Implement by calling
4481 Qreplace_buffer_in_windows.
4482 (replace_buffer_in_all_windows): Remove with some functionality
4483 moved into replace_buffer_in_windows_safely.
4484 (replace_buffer_in_windows_safely): New function.
4485 (select_window_norecord, select_frame_norecord): Move in front
4486 of run_window_configuration_change_hook. Remove now obsolete
4487 declarations.
4488 (Fset_window_buffer): Rewrite doc-string.
4489 Call Qrecord_window_buffer.
4490 (keys_of_window): Move binding for other-window to window.el.
4491
4492 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4493
4494 * dispextern.h (struct image): Replace data member, whose int_val
4495 and ptr_val fields were not used by anything, with a single
4496 lisp_val object.
4497
4498 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4499 (gif_clear_image, gif_load, imagemagick_load_image)
4500 (gs_clear_image, gs_load): Callers changed.
4501
4502 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 * buffer.h: Include <time.h>, for time_t.
4505 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4506
4507 Fix minor problems found by static checking.
4508
4509 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4510
4511 Make identifiers static if they are not used in other modules.
4512 * data.c (Qcompiled_function, Qframe, Qvector):
4513 * image.c (QimageMagick, Qsvg):
4514 * minibuf.c (Qmetadata):
4515 * window.c (resize_window_check, resize_root_window): Now static.
4516 * window.h (resize_window_check, resize_root_window): Remove decls.
4517
4518 * window.c (window_deletion_count, delete_deletable_window):
4519 Remove; unused.
4520 (window_body_lines): Now static.
4521 (Fdelete_other_windows_internal): Mark vars as initialized.
4522 Make sure 'resize_failed' is initialized.
4523 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4524 (resize_window_apply): Remove unused local.
4525 * window.h (delete_deletable_window): Remove decl.
4526
4527 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4528 (imagemagick_load_image): Fix pointer signedness problem by changing
4529 last arg from unsigned char * to char *. All uses changed.
4530 Also, fix a local for similar reasons.
4531 Remove unused locals. Remove locals to avoid shadowing.
4532 (fn_rsvg_handle_free): Remove; unused.
4533 (svg_load, svg_load_image): Fix pointer signedness problem.
4534 (imagemagick_load_image): Don't use garbage pointer image_wand.
4535
4536 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4537
4538 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4539
4540 * image.c (gif_load): Fix omitted cast error introduced by
4541 2011-06-06 change.
4542
4543 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4544
4545 * window.h (resize_proportionally, orig_total_lines)
4546 (orig_top_line): Remove from window structure.
4547 (set_window_height, set_window_width, change_window_heights)
4548 (Fdelete_window): Remove prototypes.
4549 (resize_frame_windows): Remove duplicate declaration.
4550
4551 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4552
4553 * window.h (resize_frame_windows, resize_window_check)
4554 (delete_deletable_window, resize_root_window)
4555 (resize_frame_windows): Declare prototypes.
4556
4557 * window.c (resize_window_apply): Make definition be "static" to
4558 match the prototype.
4559
4560 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4561
4562 * window.c: Remove declarations of Qwindow_size_fixed,
4563 window_min_size_1, window_min_size_2, window_min_size,
4564 size_window, window_fixed_size_p, enlarge_window, delete_window.
4565 Remove static from declaration of Qdelete_window, it's
4566 temporarily needed by Fbury_buffer.
4567 (replace_window): Don't assign orig_top_line and
4568 orig_total_lines.
4569 (Fdelete_window, delete_window): Remove. Window deletion is
4570 handled by window.el.
4571 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4572 Replace Fdelete_window calls with calls to Qdelete_window.
4573 (Fdelete_other_windows): Remove. Deleting other windows is
4574 handled by window.el.
4575 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4576 handled in window.el.
4577 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4578 Window minimum sizes are handled in window.el.
4579 (shrink_windows, size_window, set_window_height)
4580 (set_window_width, change_window_heights, window_height)
4581 (window_width, CURBEG, CURSIZE, enlarge_window)
4582 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4583 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4584 handled in window.el.
4585 (make_dummy_parent): Rename to make_parent_window and give it a
4586 second argument horflag.
4587 (make_window): Don't set resize_proportionally any more.
4588 (Fsplit_window): Remove. Windows are split in window.el.
4589 (save_restore_action, save_restore_orig_size)
4590 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4591 Resize mini windows in window.el.
4592 (grow_mini_window, shrink_mini_window): Implement by calling
4593 Qresize_root_window_vertically, resize_window_check and
4594 resize_window_apply.
4595 (saved_window, Fset_window_configuration, save_window_save):
4596 Do not handle orig_top_line, orig_total_lines, and
4597 resize_proportionally.
4598 (window_min_height, window_min_width): Move to window.el.
4599 (keys_of_window): Move bindings for delete-other-windows,
4600 split-window, delete-window and enlarge-window to window.el.
4601
4602 * buffer.c: Temporarily extern Qdelete_window.
4603 (Fbury_buffer): Temporarily call Qdelete_window instead of
4604 Fdelete_window (Fbury_buffer will move to window.el soon).
4605
4606 * frame.c (set_menu_bar_lines_1): Remove code handling
4607 orig_top_line and orig_total_lines.
4608
4609 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4610 set_window_height but set heights directly.
4611 (change_frame_size_1): Use resize_frame_windows.
4612
4613 * xdisp.c (init_xdisp): Don't use set_window_height but set
4614 heights directly.
4615
4616 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4617 Use resize_frame_windows instead of change_window_heights and run
4618 run_window_configuration_change_hook.
4619
4620 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4621 instead of change_window_heights and run
4622 run_window_configuration_change_hook.
4623
4624 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4625
4626 * window.c (replace_window): Rename second argument REPLACEMENT to
4627 NEW. New third argument SETFLAG. Rewrite.
4628 (delete_window, make_dummy_parent): Call replace_window with
4629 third argument 1.
4630 (window_list_1): Move down in code.
4631 (run_window_configuration_change_hook): Move set_buffer part
4632 before select_frame_norecord part in order to unwind correctly.
4633 Rename count1 to count.
4634 (recombine_windows, delete_deletable_window, resize_root_window)
4635 (Fdelete_other_windows_internal)
4636 (Frun_window_configuration_change_hook, make_parent_window)
4637 (resize_window_check, resize_window_apply, Fresize_window_apply)
4638 (resize_frame_windows, Fsplit_window_internal)
4639 (Fdelete_window_internal, Fresize_mini_window_internal):
4640 New functions.
4641 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4642
4643 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4644
4645 * window.h (window): Add some new members to window structure -
4646 normal_lines, normal_cols, new_total, new_normal, clone_number,
4647 splits, nest, prev_buffers, next_buffers.
4648 (WINDOW_TOTAL_SIZE): Move here from window.c.
4649 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4650
4651 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4652 Remove.
4653 (make_dummy_parent): Set new members of windows structure.
4654 (make_window): Move down in code. Handle new members of window
4655 structure.
4656 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4657 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4658 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4659 (Fset_window_prev_buffers, Fwindow_next_buffers)
4660 (Fset_window_next_buffers, Fset_window_clone_number):
4661 New functions.
4662 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4663 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4664 Doc-string fixes.
4665 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4666 Argument WINDOW can be now internal window too.
4667 (Fwindow_use_time): Move up in code.
4668 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4669 Rewrite doc-string.
4670 (Fset_window_configuration, saved_window)
4671 (Fcurrent_window_configuration, save_window_save): Handle new
4672 members of window structure.
4673 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4674 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4675 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4676 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4677 Qget_mru_window, Qresize_root_window,
4678 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4679 Qauto_buffer_name; staticpro them.
4680
4681 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4682
4683 * window.c (Fwindow_total_size, Fwindow_left_column)
4684 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4685 (Fwindow_list_1): New functions.
4686 (window_box_text_cols): Replace with window_body_cols.
4687 (Fwindow_width, Fscroll_left, Fscroll_right):
4688 Use window_body_cols instead of window_box_text_cols.
4689 (delete_window, Fset_window_configuration):
4690 Call delete_all_subwindows with window as argument.
4691 (delete_all_subwindows): Take a window as argument and not a
4692 structure. Rewrite.
4693 (window_loop): Remove handling of GET_LRU_WINDOW and
4694 GET_LARGEST_WINDOW.
4695 (Fget_lru_window, Fget_largest_window): Move to window.el.
4696
4697 * window.h: Extern window_body_cols instead of
4698 window_box_text_cols. delete_all_subwindows now takes a
4699 Lisp_Object as argument.
4700
4701 * indent.c (compute_motion, Fcompute_motion):
4702 Use window_body_cols instead of window_box_text_cols.
4703
4704 * frame.c (delete_frame): Call delete_all_subwindows with root
4705 window as argument.
4706
4707 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4708
4709 * fns.c (Fputhash): Document return value.
4710
4711 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4712
4713 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4714
4715 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 Cons<->int and similar integer overflow fixes (Bug#8794).
4718
4719 Check for overflow when converting integer to cons and back.
4720 * charset.c (Fdefine_charset_internal, Fdecode_char):
4721 Use cons_to_unsigned to catch overflow.
4722 (Fencode_char): Use INTEGER_TO_CONS.
4723 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4724 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4725 * data.c (long_to_cons, cons_to_long): Remove.
4726 (cons_to_unsigned, cons_to_signed): New functions.
4727 These signal an error for invalid or out-of-range values.
4728 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4729 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4730 * font.c (Ffont_variation_glyphs):
4731 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4732 * lisp.h: Include <intprops.h>.
4733 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4734 (cons_to_signed, cons_to_unsigned): New decls.
4735 (long_to_cons, cons_to_long): Remove decls.
4736 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4737 (Fprimitive_undo): Use CONS_TO_INTEGER.
4738 * xfns.c (Fx_window_property): Likewise.
4739 * xselect.c: Include <limits.h>.
4740 (x_own_selection, selection_data_to_lisp_data):
4741 Use INTEGER_TO_CONS.
4742 (x_handle_selection_request, x_handle_selection_clear)
4743 (x_get_foreign_selection, Fx_disown_selection_internal)
4744 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4745 (lisp_data_to_selection_data): Use cons_to_unsigned.
4746 (x_fill_property_data): Use cons_to_signed.
4747 Report values out of range.
4748
4749 Check for buffer and string overflow more precisely.
4750 * buffer.h (BUF_BYTES_MAX): New macro.
4751 * lisp.h (STRING_BYTES_MAX): New macro.
4752 * alloc.c (Fmake_string):
4753 * character.c (string_escape_byte8):
4754 * coding.c (coding_alloc_by_realloc):
4755 * doprnt.c (doprnt):
4756 * editfns.c (Fformat):
4757 * eval.c (verror):
4758 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4759 since they may not be the same number.
4760 * editfns.c (Finsert_char):
4761 * fileio.c (Finsert_file_contents):
4762 Likewise for BUF_BYTES_MAX.
4763
4764 * image.c: Use ptrdiff_t, not int, for sizes.
4765 (slurp_file): Switch from int to ptrdiff_t.
4766 All uses changed.
4767 (slurp_file): Check that file size fits in both size_t (for
4768 malloc) and ptrdiff_t (for sanity and safety).
4769
4770 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4771 if b->modtime has its maximal value.
4772
4773 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4774
4775 Don't assume time_t can fit into int.
4776 * buffer.h (struct buffer.modtime): Now time_t, not int.
4777 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4778 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4779
4780 Minor fixes for signed vs unsigned integers.
4781 * character.h (MAYBE_UNIFY_CHAR):
4782 * charset.c (maybe_unify_char):
4783 * keyboard.c (read_char, reorder_modifiers):
4784 XINT -> XFASTINT, since the integer must be nonnegative.
4785 * ftfont.c (ftfont_spec_pattern):
4786 * keymap.c (access_keymap, silly_event_symbol_error):
4787 XUINT -> XFASTINT, since the integer must be nonnegative.
4788 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4789 since it makes no difference and we prefer signed.
4790 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4791 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4792 nonnegative.
4793
4794 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4795
4796 * window.h (Fwindow_frame): Declare.
4797
4798 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4799
4800 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4801 (SPARE_MEMORY): Always define.
4802 (LARGE_REQUEST): Remove.
4803 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4804
4805 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4806
4807 * lisp.h: Move EXFUNS for Fframe_root_window,
4808 Fframe_first_window and Fset_frame_selected_window to window.h.
4809
4810 * window.h: Move EXFUNS for Fframe_root_window,
4811 Fframe_first_window and Fset_frame_selected_window here from
4812 lisp.h.
4813
4814 * frame.c (Fwindow_frame, Fframe_first_window)
4815 (Fframe_root_window, Fframe_selected_window)
4816 (Fset_frame_selected_window): Move to window.c.
4817 (Factive_minibuffer_window): Move to minibuf.c.
4818 (Fother_visible_frames_p): New function.
4819
4820 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4821
4822 * window.c (decode_window, decode_any_window): Move up in code.
4823 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4824 (inhibit_frame_unsplittable): Remove unused variable.
4825 (Fwindow_buffer): Move up and rewrite doc-string.
4826 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4827 (Fwindow_prev): New functions.
4828 (Fwindow_frame): Move here from frame.c. Accept any window as
4829 argument.
4830 (Fframe_root_window, Fframe_first_window)
4831 (Fframe_selected_window): Move here from frame.c. Accept frame
4832 or arbitrary window as argument. Update doc-strings.
4833 (Fminibuffer_window): Move up in code.
4834 (Fwindow_minibuffer_p): Move up in code and simplify.
4835 (Fset_frame_selected_window): Move here from frame.c.
4836 Marginal rewrite.
4837 (Fselected_window, select_window, Fselect_window): Move up in
4838 code. Minor doc-string fixes.
4839
4840 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4841
4842 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4843 Do not assume that spare memory exists; that assumption is valid
4844 only if SYSTEM_MALLOC.
4845 (LARGE_REQUEST): New macro, so that the issue of large requests
4846 is separated from the issue of spare memory.
4847
4848 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4851 format. (Bug#8806)
4852
4853 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4854
4855 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4856 before statements.
4857
4858 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4859
4860 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4861
4862 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4863
4864 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4865 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4866
4867 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4868
4869 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4870
4871 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4872
4873 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4874 (x_clipboard_manager_save): Add return value.
4875 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4876 New error handlers.
4877 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4878 Obey Vx_select_enable_clipboard_manager. Catch errors in
4879 x_clipboard_manager_save (Bug#8779).
4880 (Vx_select_enable_clipboard_manager): New variable.
4881 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4882
4883 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4884
4885 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4886
4887 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4888
4889 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4890 in the current matrix if keep_current_p is non-zero.
4891
4892 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4893
4894 * bidi.c (bidi_level_of_next_char): Fix last change.
4895
4896 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4897
4898 Support bidi reordering of text covered by display properties.
4899
4900 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4901 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4902 (bidi_cache_search, bidi_cache_iterator_state)
4903 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4904 (bidi_level_of_next_char, bidi_move_to_visually_next):
4905 Support character positions inside a run of characters covered by a
4906 display string.
4907 (bidi_paragraph_init, bidi_resolve_explicit_1)
4908 (bidi_level_of_next_char): Call bidi_fetch_char and
4909 bidi_fetch_char_advance instead of FETCH_CHAR and
4910 FETCH_CHAR_ADVANCE.
4911 (bidi_init_it): Initialize new members.
4912 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4913 definitions.
4914 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4915 instead of using explicit *_CHAR codes.
4916 (bidi_resolve_explicit, bidi_resolve_weak):
4917 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4918 bidirectional text is supported only in multibyte buffers.
4919 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4920 it to initialize the frame_window_p member of struct bidi_it.
4921 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4922 (bidi_resolve_explicit, bidi_resolve_weak)
4923 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4924 bidi_it->nchars is non-positive.
4925 (bidi_level_of_next_char): Don't try to lookup the cache for the
4926 next/previous character if nothing is cached there yet, or if we
4927 were just reseat()'ed to a new position.
4928
4929 * xdisp.c (set_cursor_from_row): Set start and stop points
4930 according to the row's direction when priming the loop that looks
4931 for the glyph on which to display cursor.
4932 (single_display_spec_intangible_p): Function deleted.
4933 (display_prop_intangible_p): Reimplement to call
4934 handle_display_spec instead of single_display_spec_intangible_p.
4935 Accept 3 additional arguments needed by handle_display_spec.
4936 This fixes incorrect cursor motion across display property with complex
4937 values: lists, `(when COND...)' forms, etc.
4938 (single_display_spec_string_p): Support property values that are
4939 lists with the argument STRING its top-level element.
4940 (display_prop_string_p): Fix the condition for processing a
4941 property that is a list to be consistent with handle_display_spec.
4942 (handle_display_spec): New function, refactored from the
4943 last portion of handle_display_prop.
4944 (compute_display_string_pos): Accept additional argument
4945 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4946 value of a `display' property is a "replacing spec".
4947 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4948 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4949 the display property, but just return a value indicating whether
4950 the display property will replace the characters it covers.
4951 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4952 frame_window_p members of struct bidi_it.
4953 (compute_display_string_pos, compute_display_string_end):
4954 New functions.
4955 (push_it): Accept second argument POSITION, where pop_it should
4956 jump to continue iteration.
4957 (reseat_1): Initialize bidi_it.disp_pos.
4958
4959 * keyboard.c (adjust_point_for_property): Adjust the call to
4960 display_prop_intangible_p to its new signature.
4961
4962 * dispextern.h (struct bidi_it): New member frame_window_p.
4963 (bidi_init_it): Update prototypes.
4964 (display_prop_intangible_p): Update prototype.
4965 (compute_display_string_pos, compute_display_string_end):
4966 Declare prototypes.
4967 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4968 EMACS_INT.
4969
4970 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 Malloc failure behavior now depends on size of allocation.
4973 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4974 * lisp.h: Change signatures accordingly.
4975 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4976 All callers changed. (Bug#8762)
4977
4978 * gnutls.c: Use Emacs's memory allocators.
4979 Without this change, the gnutls library would invoke malloc etc.
4980 directly, which causes problems on non-SYNC_INPUT hosts, and which
4981 runs afoul of improving memory_full behavior. (Bug#8761)
4982 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4983 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4984 xfree instead of the default malloc, realloc, free.
4985 (Fgnutls_boot): No need to check for memory allocation failure,
4986 since xmalloc does that for us.
4987
4988 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4989 * category.c (hash_get_category_set):
4990 * ccl.c (ccl_driver):
4991 * charset.c (Fdefine_charset_internal):
4992 * charset.h (struct charset.hash_index):
4993 * composite.c (get_composition_id, gstring_lookup_cache)
4994 (composition_gstring_put_cache):
4995 * composite.h (struct composition.hash_index):
4996 * dispextern.h (struct image.hash):
4997 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4998 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4999 (hashfn_equal, hashfn_user_defined, make_hash_table)
5000 (maybe_resize_hash_table, hash_lookup, hash_put)
5001 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5002 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5003 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5004 * image.c (make_image, search_image_cache, lookup_image)
5005 (xpm_put_color_table_h):
5006 * lisp.h (struct Lisp_Hash_Table):
5007 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5008 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5009 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5010 * alloc.c (allocate_vectorlike):
5011 Check for overflow in vector size calculations.
5012 * ccl.c (ccl_driver):
5013 Check for overflow when converting EMACS_INT to int.
5014 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5015 need to be updated by these changes.
5016 * fns.c (make_hash_table, maybe_resize_hash_table):
5017 Check for integer overflow with large hash tables.
5018 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5019 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5020 (SXHASH_REDUCE): New macro.
5021 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5022 Use it instead of discarding useful hash info with large hash values.
5023 (sxhash_float): New function.
5024 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5025 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5026 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5027 Rewrite to use FIXNUM_BITS, as this simplifies things.
5028 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5029 Adjust signatures to match updated version of code.
5030 (consing_since_gc): Now EMACS_INT, since a single hash table can
5031 use more than INT_MAX bytes.
5032
5033 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5034
5035 Make it possible to build with GCC-4.6+ -O2 -flto.
5036
5037 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5038
5039 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5040
5041 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5042 Call minibuffer-inactive-mode.
5043
5044 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5047 Update dependencies.
5048
5049 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5050
5051 * data.c (init_data): Remove code for UTS, this system is not
5052 supported anymore.
5053
5054 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5055
5056 Don't force ./temacs to start in terminal mode.
5057
5058 * frame.c (make_initial_frame): Initialize faces in all cases, not
5059 only when CANNOT_DUMP is defined.
5060 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5061
5062 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5063
5064 * dispnew.c (add_window_display_history): Use const for the string
5065 pointer. Remove declaration, not needed.
5066
5067 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 Use 'inline', not 'INLINE'.
5070 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5071 * alloc.c, fontset.c (INLINE): Remove.
5072 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5073 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5074 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5075 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5076 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5077
5078 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5079
5080 Make it possible to run ./temacs.
5081
5082 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5083 syms_of_callproc does the same thing. Remove test for
5084 "initialized", do it in the caller.
5085 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5086
5087 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5090 (read_minibuf): Use get_minibuffer.
5091 (syms_of_minibuf): Use DEFSYM.
5092 (Qmetadata): New var.
5093 * data.c (Qbuffer): Don't make it static.
5094 (syms_of_data): Use DEFSYM.
5095
5096 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5099 (CCL_CODE_MIN): New macro.
5100
5101 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5102
5103 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5104
5105 * eval.c (Qdebug): Now static.
5106 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5107 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5108 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5109
5110 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5111
5112 * image.c: Various fixes to ImageMagick code comments.
5113 (Fimagemagick_types): Doc fix.
5114
5115 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 Minor fixes prompted by GCC 4.6.0 warnings.
5118
5119 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5120
5121 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5122 (x_clipboard_manager_save_all): Move extern decl to ...
5123 * xterm.h: ... here, so that it can be checked for consistency.
5124
5125 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5126
5127 * xselect.c (x_clipboard_manager_save_frame)
5128 (x_clipboard_manager_save_all): New functions.
5129 (Fx_clipboard_manager_save): Lisp function deleted.
5130
5131 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5132 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5133
5134 * xterm.h: Update prototype.
5135
5136 2011-05-28 William Xu <william.xwl@gmail.com>
5137
5138 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5139 exiting (Bug#8239).
5140
5141 2011-05-28 Jim Meyering <meyering@redhat.com>
5142
5143 Avoid a sign-extension bug in crypto_hash_function.
5144 * fns.c (to_uchar): Define.
5145 (crypto_hash_function): Use it to convert some newly-signed
5146 variables to unsigned, to avoid sign-extension bugs. For example,
5147 without this change, (md5 "truc") would evaluate to
5148 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5149 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5150 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5151
5152 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5153
5154 Integer overflow fixes.
5155
5156 * dbusbind.c: Serial number integer overflow fixes.
5157 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5158 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5159 to hold a serial number that is too large for a fixnum.
5160 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5161 Check for serial numbers out of range. Decode any serial number
5162 that was so large that it became a float. (Bug#8722)
5163
5164 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5165 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5166 Use XFASTINT rather than XUINT when numbers are nonnegative.
5167 (xd_append_arg, Fdbus_method_return_internal):
5168 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5169 arguments, check that Lisp number is nonnegative, rather than
5170 silently wrapping negative numbers around. (Bug#8722)
5171 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5172 (Bug#8722)
5173
5174 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5175
5176 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5177
5178 ccl: add integer overflow checks
5179 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5180 (IN_INT_RANGE): New macros.
5181 (ccl_driver): Use them to check for integer overflow when
5182 decoding a CCL program. Many of the new checks are whether XINT (x)
5183 fits in int; it doesn't always, on 64-bit hosts. The new version
5184 doesn't catch all possible integer overflows, but it's an
5185 improvement. (Bug#8719)
5186
5187 * alloc.c (make_event_array): Use XINT, not XUINT.
5188 There's no need for unsigned here.
5189
5190 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5191 This follows up to the 2011-05-06 change that substituted uintptr_t
5192 for EMACS_INT. This case wasn't caught back then.
5193
5194 Rework Fformat to avoid integer overflow issues.
5195 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5196 now (part of C89). Include <verify.h>.
5197 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5198 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5199 (Fformat): Avoid the prepass trying to compute sizes; it was only
5200 approximate and thus did not catch overflow reliably. Instead, walk
5201 through the format just once, formatting and computing sizes as we go,
5202 checking for integer overflow at every step, and allocating a larger
5203 buffer as needed. Keep track separately whether the format is
5204 multibyte. Keep only the most-recently calculated precision, rather
5205 than them all. Record whether each argument has been converted to
5206 string. Use EMACS_INT, not int, for byte and char and arg counts.
5207 Support field widths and precisions larger than INT_MAX. Avoid
5208 sprintf's undefined behavior with conversion specifications such as %#d
5209 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5210 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5211 formatting out-of-range floating point numbers with int
5212 formats. (Bug#8668)
5213
5214 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5215
5216 * data.c: Avoid integer truncation in expressions involving floats.
5217 * data.c: Include <intprops.h>.
5218 (arith_driver): When there's an integer overflow in an expression
5219 involving floating point, convert the integers to floating point
5220 so that the resulting value does not suffer from catastrophic
5221 integer truncation. For example, on a 64-bit host (* 4
5222 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5223 Do not rely on undefined behavior after integer overflow.
5224
5225 merge count_size_as_multibyte, parse_str_to_multibyte
5226 * character.c, character.h (count_size_as_multibyte):
5227 Rename from parse_str_to_multibyte; all uses changed.
5228 Check for integer overflow.
5229 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5230 since it's now a duplicate of the other. This is more of
5231 a character than a buffer op, so better that it's in character.c.
5232 * fns.c, print.c: Adjust to above changes.
5233
5234 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5235
5236 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5237
5238 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5241 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5242 (x_clipboard_manager_save): Now static.
5243 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5244
5245 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5246 (crypto_hash_function): Now static.
5247 Fix pointer signedness problems. Avoid unnecessary initializations.
5248
5249 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * termhooks.h (Vselection_alist): Make it terminal-local.
5252
5253 * terminal.c (create_terminal): Initialize it.
5254
5255 * xselect.c: Support for clipboard managers.
5256 (Vselection_alist): Move to termhooks.h as terminal-local var.
5257 (LOCAL_SELECTION): New macro.
5258 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5259 (symbol_to_x_atom): Remove gratuitous arg.
5260 (x_handle_selection_request, lisp_data_to_selection_data)
5261 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5262 (x_own_selection, x_get_local_selection, x_convert_selection):
5263 New arg, specifying work frame. Use terminal-local Vselection_alist.
5264 (some_frame_on_display): Delete unused function.
5265 (Fx_own_selection_internal, Fx_get_selection_internal)
5266 (Fx_disown_selection_internal, Fx_selection_owner_p)
5267 (Fx_selection_exists_p): New optional frame arg.
5268 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5269 (x_handle_selection_clear): Don't treat other terminals with the
5270 same keyboard specially. Use the terminal-local Vselection_alist.
5271 (x_clear_frame_selections): Use Frun_hook_with_args.
5272
5273 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5274
5275 * xterm.h: Add support for those atoms.
5276
5277 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5278
5279 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5280 (converted_selections, conversion_fail_tag): New global variables.
5281 (x_selection_request_lisp_error): Free the above.
5282 (x_get_local_selection): Remove unnecessary code.
5283 (x_reply_selection_request): Args changed; handle arbitrary array
5284 of converted selections stored in converted_selections.
5285 Separate the XChangeProperty and SelectionNotify steps.
5286 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5287 (x_convert_selection): New function.
5288 (x_handle_selection_event): Simplify.
5289 (x_get_foreign_selection): Don't ignore incoming requests while
5290 waiting for an answer; this will fail when we implement
5291 SAVE_TARGETS, and seems unnecessary anyway.
5292 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5293 (Vx_sent_selection_functions): Doc fix.
5294
5295 2011-05-26 Leo Liu <sdl.web@gmail.com>
5296
5297 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5298
5299 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5300
5301 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5302
5303 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5304 for fringe update if it has periodic bitmap.
5305 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5306 and fringe_bitmap_periodic_p.
5307
5308 * fringe.c (get_fringe_bitmap_data): New function.
5309 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5310 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5311 row. Mark glyph row for fringe update if periodicity changed.
5312
5313 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5314 for fringe update unless it has periodic bitmap.
5315
5316 2011-05-25 Kenichi Handa <handa@m17n.org>
5317
5318 * xdisp.c (get_next_display_element): Set correct it->face_id for
5319 a static composition.
5320
5321 2011-05-24 Leo Liu <sdl.web@gmail.com>
5322
5323 * deps.mk (fns.o):
5324 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5325
5326 * fns.c (crypto_hash_function, Fsha1): New function.
5327 (Fmd5): Use crypto_hash_function.
5328 (syms_of_fns): Add Ssha1.
5329
5330 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5331
5332 * gnutls.c: Remove unused macros.
5333 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5334 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5335 Remove macros that are defined and never used.
5336 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5337
5338 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5339
5340 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5341 (Fx_get_selection_internal): Minor cleanup.
5342 (Fx_own_selection_internal): Rename arguments for consistency with
5343 select.el.
5344
5345 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5348
5349 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5352
5353 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5354
5355 * dispnew.c (scrolling_window): Don't exclude the case that the
5356 last enabled row in the desired matrix touches the bottom boundary.
5357
5358 2011-05-21 Glenn Morris <rgm@gnu.org>
5359
5360 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5361 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5362 and add some more files.
5363
5364 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5365
5366 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5367 report_file_error introduced by the change from 2011-05-07.
5368
5369 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * systime.h (Time): Define only if emacs is defined.
5372 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5373 where the include path doesn't have X11/X.h by default. See
5374 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5375
5376 2011-05-20 Kenichi Handa <handa@m17n.org>
5377
5378 * composite.c (find_automatic_composition): Fix previous change.
5379
5380 2011-05-20 Glenn Morris <rgm@gnu.org>
5381
5382 * lisp.mk: New file, split from Makefile.in.
5383 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5384 (shortlisp): Remove.
5385 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5386
5387 2011-05-19 Glenn Morris <rgm@gnu.org>
5388
5389 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5390 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5391 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5392 (lisp): Set the order to that of loadup.el.
5393 (shortlisp): Make it a copy of $lisp.
5394 (SOME_MACHINE_LISP): Remove.
5395 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5396 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5397
5398 2011-05-18 Kenichi Handa <handa@m17n.org>
5399
5400 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5401 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5402 (find_automatic_composition): Mostly rewrite for efficiency.
5403
5404 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * makefile.w32-in: Update dependencies.
5407
5408 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5409
5410 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5411 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5412
5413 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 Fix some integer overflow issues, such as string length overflow.
5416
5417 * insdel.c (count_size_as_multibyte): Check for string overflow.
5418
5419 * character.c (lisp_string_width): Check for string overflow.
5420 Use EMACS_INT, not int, for string indexes and lengths; in
5421 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5422 the resulting string length overflows an EMACS_INT; instead,
5423 report a string overflow if no precision given. When checking for
5424 precision exhaustion, use a check that cannot possibly have
5425 integer overflow. (Bug#8675)
5426 * character.h (lisp_string_width): Adjust to new signature.
5427
5428 * alloc.c (string_overflow): New function.
5429 (Fmake_string): Use it. This doesn't change behavior, but saves
5430 a few bytes and will simplify future changes.
5431 * character.c (string_escape_byte8): Likewise.
5432 * lisp.h (string_overflow): New decl.
5433
5434 Fixups, following up to the user-interface timestamp change.
5435 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5436 for UI timestamps, instead of unsigned long.
5437 * msdos.c (mouse_get_pos): Likewise.
5438 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5439 * w32gui.h (Time): Define by including "systime.h" rather than by
5440 declaring it ourselves. (Bug#8664)
5441
5442 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5443 * image.c (clear_image_cache): Likewise.
5444
5445 * term.c (term_mouse_position): Don't assume time_t wraparound.
5446
5447 Be more systematic about user-interface timestamps.
5448 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5449 and sometimes 'EMACS_UINT', to represent these timestamps.
5450 This change causes it to use 'Time' uniformly, as that's what X uses.
5451 This makes the code easier to follow, and makes it easier to catch
5452 integer overflow bugs such as Bug#8664.
5453 * frame.c (Fmouse_position, Fmouse_pixel_position):
5454 Use Time, not unsigned long, for user-interface timestamps.
5455 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5456 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5457 * keyboard.h (last_event_timestamp): Likewise.
5458 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5459 * menu.h (xmenu_show): Likewise.
5460 * term.c (term_mouse_position): Likewise.
5461 * termhooks.h (struct input_event.timestamp): Likewise.
5462 (struct terminal.mouse_position_hook): Likewise.
5463 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5464 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5465 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5466 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5467 what it was before.
5468 * menu.h, termhooks.h: Include "systime.h", for Time.
5469
5470 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5471 Don't assume that the difference between two unsigned long values
5472 can fit into an integer. At this point, we know button_down_time
5473 <= event->timestamp, so the difference must be nonnegative, so
5474 there's no need to cast the result if double-click-time is
5475 nonnegative, as it should be; check that it's nonnegative, just in
5476 case. This bug is triggered when events are more than 2**31 ms
5477 apart (about 25 days). (Bug#8664)
5478
5479 * xselect.c (last_event_timestamp): Remove duplicate decl.
5480 (x_own_selection): Remove needless cast to unsigned long.
5481
5482 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5483 that always fit in int. Use a sentinel instead of a counter, to
5484 avoid a temp and to allay GCC's concerns about possible int overflow.
5485 * frame.h (struct frame): Use int for menu_bar_items_used
5486 instead of EMACS_INT, since it always fits in int.
5487
5488 * menu.c (grow_menu_items): Check for int overflow.
5489
5490 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5491
5492 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5493 Before, the code was not consistent. These values cannot exceed
5494 2**31 - 1 so there's no need to make them unsigned.
5495 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5496 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5497 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5498 as modifiers.
5499 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5500
5501 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5502 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5503 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5504 presumably because the widths might not match.
5505
5506 * window.c (size_window): Avoid needless test at loop start.
5507
5508 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5509
5510 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5511
5512 2011-05-12 Drew Adams <drew.adams@oracle.com>
5513
5514 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5515
5516 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5517
5518 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5519 `width' to `bar_area_x' and `bar_area_width', respectively.
5520 (x_scroll_run): Take account of fringe background extension.
5521
5522 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5523 Rename local vars `left' and `width' to `bar_area_x' and
5524 `bar_area_width', respectively.
5525 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5526 background extension.
5527
5528 2011-05-10 Jim Meyering <meyering@redhat.com>
5529
5530 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5531
5532 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5533
5534 * image.c (Finit_image_library): Return t for built-in image types,
5535 like pbm and xbm. (Bug#8640)
5536
5537 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5538
5539 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5540
5541 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5542
5543 * w32console.c (Fset_screen_color): Doc fix.
5544 (Fget_screen_color): New function.
5545 (syms_of_ntterm): Defsubr it.
5546
5547 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5548 unlink the temporary file if Fcall_process didn't create it in the
5549 first place.
5550 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5551 child process will be redirected to a file specified with `:file'.
5552 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5553 cue to call_process_cleanup not to close that handle.
5554
5555 2011-05-07 Ben Key <bkey76@gmail.com>
5556
5557 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5558 one of two shell specific rules, either bootstrap-temacs-CMD or
5559 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5560 to the previous implementation of the bootstrap-temacs rule.
5561 The bootstrap-temacs-CMD rule is similar to the previous
5562 implementation of the bootstrap-temacs rule except that it
5563 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5564 variable.
5565
5566 These changes, along with some changes to nt/configure.bat,
5567 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5568 earlier fix to add support for --cflags and --ldflags options
5569 that include quotes so that it works whether make uses cmd or
5570 sh as the shell.
5571
5572 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5573
5574 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5575 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5576 is a constant.
5577 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5578 a string. Handle both cases.
5579 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5580 (Fdbus_register_method): Use Qinvalid_function.
5581
5582 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5583
5584 * makefile.w32-in: Update dependencies.
5585 (LISP_H): Add inttypes.h and stdin.h.
5586 (PROCESS_H): Add unistd.h.
5587
5588 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5589
5590 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5591 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5592
5593 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5594
5595 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5596
5597 * term.c (vfatal): Remove stray call to va_end.
5598 It's not needed and the C Standard doesn't allow it here anyway.
5599
5600 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5601 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5602
5603 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5604 bytes.
5605
5606 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5607
5608 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5609
5610 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5611
5612 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5613
5614 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5615
5616 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5617 * charset.c (Fdefine_charset_internal): Don't initialize
5618 charset.code_space[15]. The value was garbage, on hosts with
5619 32-bit int (Bug#8600).
5620
5621 * lread.c (read_integer): Be more consistent with string-to-number.
5622 Use string_to_number to do the actual conversion; this avoids
5623 rounding errors and fixes some other screwups. Without this fix,
5624 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5625 (digit_to_number): Move earlier, for benefit of read_integer.
5626 Return -1 if the digit is out of range for the base, -2 if it is
5627 not a digit in any supported base. (Bug#8602)
5628
5629 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5630
5631 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5632 to match comment at start of function. This also removes a
5633 GCC warning about overflow in a 32+64-bit port.
5634
5635 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5636
5637 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5638 Reported by Stefan Monnier in
5639 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5640 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5641 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5642
5643 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5644 (EMACS_UINTPTR): Likewise, with uintptr_t.
5645
5646 * lisp.h: Prefer 64-bit EMACS_INT if available.
5647 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5648 on 32-bit hosts that have 64-bit int, so that they can access
5649 large files.
5650 However, temporarily disable this change unless the temporary
5651 symbol WIDE_EMACS_INT is defined.
5652
5653 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5654
5655 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5656 This removes an assumption that EMACS_INT and long are the same
5657 width as pointers. The assumption is true for Emacs porting targets
5658 now, but we want to make other targets possible.
5659 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5660 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5661 In the rest of the code, change types of integers that hold casted
5662 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5663 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5664 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5665 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5666 No need to cast type when ORing.
5667 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5668 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5669 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5670 assume EMACS_INT is the same width as char *.
5671 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5672 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5673 Remove no-longer-needed casts.
5674 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5675 (xg_tool_bar_help_callback, xg_make_tool_item):
5676 Use EMACS_INTPTR to hold an integer
5677 that will be cast to void *; this can avoid a GCC warning
5678 if EMACS_INT is not the same width as void *.
5679 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5680 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5681 (current_message_1, set_message_1):
5682 Use a local to convert to proper width without a cast.
5683 * xmenu.c (dialog_selection_callback): Likewise.
5684
5685 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5686 Also, don't assume VALBITS / RAND_BITS is less than 5,
5687 and don't rely on undefined behavior when shifting a 1 left into
5688 the sign bit.
5689 * lisp.h (get_random): Change signature to match.
5690
5691 * lread.c (hash_string): Use size_t, not int, for hash computation.
5692 Normally we prefer signed values; but hashing is special, because
5693 it's better to use unsigned division on hash table sizes so that
5694 the remainder is nonnegative. Also, size_t is the natural width
5695 for hashing into memory. The previous code used 'int', which doesn't
5696 retain enough info to hash well into very large tables.
5697 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5698
5699 * dbusbind.c: Don't possibly lose pointer info when converting.
5700 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5701 Use XPNTR rather than XHASH, so that the high-order bits of
5702 the pointer aren't lost when converting through void *.
5703
5704 * eval.c (Fautoload): Don't double-shift a pointer.
5705
5706 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5707
5708 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5709
5710 * gnutls.c (DEF_GNUTLS_FN):
5711 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5712
5713 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5714
5715 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5716 marker. (Bug#8610)
5717
5718 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5719
5720 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5721 New version that can reserve upto 2GB of heap space.
5722
5723 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5724
5725 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5726
5727 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5728
5729 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5730 `gnutls_certificate_set_x509_key_file'.
5731
5732 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5733
5734 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5735 Update dependencies.
5736
5737 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5740 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5741 Remove unused parameter `fildes'.
5742 * process.c (read_process_output, send_process): Don't pass it.
5743
5744 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5745
5746 Fix previous change: the library cache is defined in w32.c.
5747 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5748 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5749
5750 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5751
5752 Implement dynamic loading of GnuTLS on Windows.
5753
5754 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5755 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5756 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5757 Declare.
5758
5759 * gnutls.c (Qgnutls_dll): Define.
5760 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5761 (gnutls_*): Declare function pointers.
5762 (init_gnutls_functions): New function to initialize function pointers.
5763 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5764 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5765 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5766 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5767 (emacs_gnutls_write, emacs_gnutls_read)
5768 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5769 (Fgnutls_available_p): New function.
5770 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5771 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5772 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5773
5774 * image.c: Include w32.h.
5775 (Vimage_type_cache): Delete.
5776 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5777 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5778 (w32_delayed_load): Move to w32.c.
5779
5780 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5781
5782 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5783 (w32_delayed_load): Move from image.c. When loading a library, record
5784 its filename in the :loaded-from property of the library id.
5785 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5786 Initialize and staticpro them.
5787 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5788
5789 * process.c: Include lisp.h before w32.h, not after.
5790 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5791 instead of gnutls_record_check_pending.
5792
5793 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5794
5795 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5796
5797 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5798 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5799 as passed in.
5800
5801 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5802
5803 * xterm.c (x_set_frame_alpha): Do not set property on anything
5804 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5805
5806 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5809
5810 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5811
5812 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5813 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5814 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5815 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5816 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5817 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5818 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5819 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5820 (Qgnutls_bootprop_callbacks_verify): Make static.
5821
5822 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5823
5824 * callproc.c: Indentation fixup.
5825
5826 * sysdep.c (wait_for_termination_1): Make static.
5827 (wait_for_termination, interruptible_wait_for_termination):
5828 Move after wait_for_termination_1.
5829
5830 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831
5832 * sysdep.c (interruptible_wait_for_termination): New function
5833 which is like wait_for_termination, but allows keyboard
5834 interruptions.
5835
5836 * callproc.c (Fcall_process): Add (:file "file") as an option for
5837 the STDOUT buffer.
5838 (Fcall_process_region): Ditto.
5839
5840 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5841
5842 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5843 rather than `XVECTOR (FOO)->size'.
5844
5845 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5846 inttypes.h, as a gnulib replacement is used if it not available in
5847 system headers.
5848
5849 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5850
5851 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5852 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5853 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5854
5855 * coding.c (coding_alloc_by_realloc): Error out if destination
5856 will grow beyond MOST_POSITIVE_FIXNUM.
5857 (decode_coding_emacs_mule): Abort if there isn't enough place in
5858 charbuf for the composition carryover bytes. Reserve an extra
5859 space for up to 2 characters produced in a loop.
5860 (decode_coding_iso_2022): Abort if there isn't enough place in
5861 charbuf for the composition carryover bytes.
5862
5863 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5864
5865 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5866 aborting when %lld or %lll format is passed.
5867 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5868 %llo or %llx format is passed. (Bug#8545)
5869
5870 * window.c (window_scroll_line_based): Use a marker instead of
5871 simple variables to record original value of point. (Bug#7952)
5872
5873 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5874 produced by %s or %c overflows available buffer space. (Bug#8545)
5875
5876 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5877
5878 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5879 (SIZE_MAX): Move defn after all includes, as they might #define it.
5880
5881 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5882
5883 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5884
5885 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5886
5887 * keyboard.c (Qdelayed_warnings_hook): Define.
5888 (command_loop_1): Run `delayed-warnings-hook'
5889 if Vdelayed_warnings_list is non-nil.
5890 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5891 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5892
5893 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5894
5895 * doprnt.c (doprnt): Don't return value smaller than the buffer
5896 size if the message was truncated. (Bug#8545).
5897
5898 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5901 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5902
5903 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5904
5905 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5906
5907 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * makefile.w32-in: Update dependencies.
5910
5911 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5912
5913 Improve `doprnt' and its usage. (Bug#8545)
5914 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5915 `format_end'. Remove support for %l as a conversion specifier.
5916 Don't use xrealloc. Improve diagnostics when the %l size modifier
5917 is used. Update the commentary.
5918
5919 * eval.c (verror): Simplify calculation of size_t.
5920
5921 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5922 messages.
5923
5924 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5925
5926 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5927 change.
5928
5929 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5930
5931 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5932 This makes this file independent of the recent pseudovector change.
5933
5934 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5935
5936 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5937
5938 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5939 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5940 Remove unused local.
5941 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5942
5943 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5944 GCC 4.6.0 optimizes based on type-based alias analysis.
5945 For example, if b is of type struct buffer * and v of type struct
5946 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5947 != &v->size, and therefore "v->size = 1; b->size = 2; return
5948 v->size;" must therefore return 1. This assumption is incorrect
5949 for Emacs, since it type-puns struct Lisp_Vector * with many other
5950 types. To fix this problem, this patch adds a new type struct
5951 vectorlike_header that documents the constraints on layout of vectors
5952 and pseudovectors, and helps optimizing compilers not get fooled
5953 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5954 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5955 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5956 the size member.
5957 (XSETPVECTYPE): Rewrite in terms of new macro.
5958 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5959 This is a bit clearer, and further avoids the possibility of
5960 undesirable aliasing.
5961 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5962 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5963 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5964 since Lisp_Subr is a special case (no "next" field).
5965 (ASIZE): Now uses header.size rather than size.
5966 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5967 to avoid the hassle of writing XVECTOR (foo)->header.size.
5968 (struct vectorlike_header): New type.
5969 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5970 object, to help avoid aliasing.
5971 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5972 (SUBRP): Likewise, since Lisp_Subr is a special case.
5973 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5974 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5975 (struct Lisp_Hash_Table): Combine first two members into a single
5976 struct vectorlike_header member. All uses of "size" and "next" members
5977 changed to be "header.size" and "header.next".
5978 * buffer.h (struct buffer): Likewise.
5979 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5980 * frame.h (struct frame): Likewise.
5981 * process.h (struct Lisp_Process): Likewise.
5982 * termhooks.h (struct terminal): Likewise.
5983 * window.c (struct save_window_data, struct saved_window): Likewise.
5984 * window.h (struct window): Likewise.
5985 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5986 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5987 * buffer.c (init_buffer_once): Likewise.
5988 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5989 special case.
5990 * process.c (Fformat_network_address): Use local var for size,
5991 for brevity.
5992
5993 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5994
5995 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5996 * data.c (atof): Remove decl; no longer used or needed.
5997 (digit_to_number): Move to lread.c.
5998 (Fstring_to_number): Use new string_to_number function, to be
5999 consistent with how the Lisp reader treats infinities and NaNs.
6000 Do not assume that floating-point numbers represent EMACS_INT
6001 without losing information; this is not true on most 64-bit hosts.
6002 Avoid double-rounding errors, by insisting on integers when
6003 parsing non-base-10 numbers, as the documentation specifies.
6004 * lisp.h (string_to_number): New decl, replacing ...
6005 (isfloat_string): Remove.
6006 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6007 (read1): Do not accept +. and -. as integers; this
6008 appears to have been a coding error. Similarly, do not accept
6009 strings like +-1e0 as floating point numbers. Do not report
6010 overflow for integer overflows unless the base is not 10 which
6011 means we have no simple and reliable way to continue.
6012 Break out the floating-point parsing into a new
6013 function string_to_number, so that Fstring_to_number parses
6014 floating point numbers consistently with the Lisp reader.
6015 (digit_to_number): Move here from data.c. Make it static inline.
6016 (E_CHAR, EXP_INT): Remove, replacing with ...
6017 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6018 (string_to_number): New function, replacing isfloat_string.
6019 This function checks for valid syntax and produces the resulting
6020 Lisp float number too. Rework it so that string-to-number
6021 no longer mishandles examples like "1.0e+". Use strtoumax,
6022 so that overflow for non-base-10 numbers is reported only when
6023 there's no portable and simple way to convert to floating point.
6024
6025 * textprop.c (set_text_properties_1): Rewrite for clarity,
6026 and to avoid GCC warning about integer overflow.
6027
6028 * intervals.h (struct interval): Use EMACS_INT for members
6029 where EMACS_UINT might cause problems. See
6030 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6031 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6032 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6033 All uses changed.
6034 (offset_intervals): Tell GCC not to worry about length overflow
6035 when negating a negative length.
6036
6037 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6038 (overrun_check_free): Likewise.
6039
6040 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6041 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6042 word size.
6043
6044 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6045 (gnutls_make_error): Rename local to avoid shadowing.
6046 (gnutls_emacs_global_deinit): ifdef out; not used.
6047 (Fgnutls_boot): Use const for pointer to readonly storage.
6048 Comment out unused local. Fix pointer signedness problems.
6049
6050 * lread.c (openp): Don't stuff size_t into an 'int'.
6051 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6052 about possible signed overflow.
6053
6054 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6055 (GDK_KEY_g): Don't define if already defined.
6056 (xg_prepare_tooltip): Avoid pointer signedness problem.
6057 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6058
6059 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6060 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6061
6062 * xfns.c (Fx_window_property): Simplify a bit,
6063 to make a bit faster and to avoid GCC 4.6.0 warning.
6064 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6065
6066 * fns.c (internal_equal): Don't assume size_t fits in int.
6067
6068 * alloc.c (compact_small_strings): Tighten assertion a little.
6069
6070 Replace pEd with more-general pI, and fix some printf arg casts.
6071 * lisp.h (pI): New macro, generalizing old pEd macro to other
6072 conversion specifiers. For example, use "...%"pI"d..." rather
6073 than "...%"pEd"...".
6074 (pEd): Remove. All uses replaced with similar uses of pI.
6075 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6076 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6077 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6078 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6079 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6080 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6081 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6082 64-bit hosts.
6083 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6084 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6085 * print.c (safe_debug_print, print_object): Likewise.
6086 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6087 to int.
6088 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6089 avoiding the 0 flag, which is not portable.
6090 * process.c (Fmake_network_process): Use pI to avoid cast.
6091 * region-cache.c (pp_cache): Likewise.
6092 * xdisp.c (decode_mode_spec): Likewise.
6093 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6094 behavior on 64-bit hosts with printf arg.
6095 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6096 (x_stop_queuing_selection_requests): Likewise.
6097 (x_get_window_property): Don't truncate byte count to an 'int'
6098 when tracing.
6099
6100 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6101 here, since it parses constructs like leading '-' and spaces,
6102 which are not wanted; and it overflows with large numbers.
6103 Instead, simply match F[0-9]+, which is what is wanted anyway.
6104
6105 * alloc.c: Remove unportable assumptions about struct layout.
6106 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6107 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6108 (allocate_vectorlike, make_pure_vector): Use the new macros,
6109 plus offsetof, to remove unportable assumptions about struct layout.
6110 These assumptions hold on all porting targets that I know of, but
6111 they are not guaranteed, they're easy to remove, and removing them
6112 makes further changes easier.
6113
6114 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6115 This doesn't fix a bug but makes the code clearer.
6116 (string_overrun_cookie): Now const. Use initializers that
6117 don't formally overflow signed char, to avoid warnings.
6118 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6119 can cause Emacs to crash when string overrun checking is enabled.
6120 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6121 multiple of sizeof (EMACS_INT); it need not be, if
6122 alignof(EMACS_INT) < sizeof (EMACS_INT).
6123 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6124
6125 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6126
6127 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6128
6129 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6130
6131 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6132 supposed to be handshaking. (Bug#8556)
6133 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6134
6135 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6136
6137 * lisp.h (Qdebug): List symbol.
6138 * eval.c (Qdebug): Restore global linkage.
6139 * keyboard.c (debug-on-event): New variable.
6140 (handle_user_signal): Break into debugger when debug-on-event
6141 matches the current signal symbol.
6142
6143 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6144
6145 * alloc.c (check_sblock, check_string_bytes)
6146 (check_string_free_list): Convert to standard C.
6147
6148 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6149
6150 * w32.c (emacs_gnutls_push): Fix typo.
6151
6152 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6153
6154 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6155 "cast to pointer from integer of different size".
6156
6157 Improve doprnt and its use in verror. (Bug#8545)
6158 * doprnt.c (doprnt): Document the set of format control sequences
6159 supported by the function. Use SAFE_ALLOCA instead of always
6160 using `alloca'.
6161
6162 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6163 is one byte too soon. Don't use xrealloc; instead xfree and
6164 xmalloc anew.
6165
6166 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6167
6168 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6169 callbacks stage.
6170
6171 * gnutls.c: Renamed global_initialized to
6172 gnutls_global_initialized. Added internals for the
6173 :verify-hostname-error, :verify-error, and :verify-flags
6174 parameters of `gnutls-boot' and documented those parameters in the
6175 docstring. Start callback support.
6176 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6177 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6178 on error. Return error code.
6179 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6180 (emacs_gnutls_read): Likewise.
6181 (Fgnutls_boot): Return handshake error code.
6182 (emacs_gnutls_handle_error): New function.
6183 (wsaerror_to_errno): Likewise.
6184
6185 * w32.h (emacs_gnutls_pull): Add prototype.
6186 (emacs_gnutls_push): Likewise.
6187
6188 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6189 (emacs_gnutls_push): Likewise.
6190
6191 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6192
6193 * process.c (wait_reading_process_output): Check if GnuTLS
6194 buffered some data internally if no FDs are set for TLS
6195 connections.
6196
6197 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6198 (LIBS): Link to USER_LIBS.
6199 ($(BLD)/gnutls.$(0)): New target.
6200
6201 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6202
6203 * xdisp.c (handle_single_display_spec): Rename the
6204 display_replaced_before_p argument into display_replaced_p, to
6205 make it consistent with the commentary. Fix typos in the
6206 commentary.
6207
6208 * textprop.c (syms_of_textprop): Remove dead code.
6209 (copy_text_properties): Delete obsolete commentary about an
6210 interface that was deleted long ago. Fix typos in the description
6211 of arguments.
6212
6213 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6214 to changes in oldXMenu/XMenu.h from 2011-04-16.
6215 <menu_help_message, prev_menu_help_message>: Constify.
6216 (IT_menu_make_room): menu->help_text is now `const char **';
6217 adjust.
6218
6219 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6220 to changes in oldXMenu/XMenu.h from 2011-04-16.
6221 (struct XMenu): Declare `help_text' `const char **'.
6222
6223 * xfaces.c <Qunspecified>: Make extern again.
6224
6225 * syntax.c: Include sys/types.h before including regex.h, as
6226 required by Posix.
6227
6228 * doc.c (get_doc_string): Improve the format passed to `error'.
6229
6230 * doprnt.c (doprnt): Improve commentary.
6231
6232 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6233
6234 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6235 them with etags.
6236
6237 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6238 changes in globals.h immediately force recompilation.
6239 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6240 $(CURDIR)/s/ms-w32.h.
6241 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6242
6243 * character.c (Fchar_direction): Function deleted.
6244 (syms_of_character): Don't defsubr it.
6245 <char-direction-table>: Deleted.
6246
6247 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6248
6249 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6250 * doprnt.c: Include limits.h.
6251 (SIZE_MAX): New macro.
6252 (doprnt): Return a size_t value. 2nd arg is now size_t.
6253 Many local variables are now size_t instead of int or unsigned.
6254 Improve overflow protection. Support `l' modifier for integer
6255 conversions. Support %l conversion. Don't assume an EMACS_INT
6256 argument for integer conversions and for %c.
6257
6258 * lisp.h (doprnt): Restore prototype.
6259
6260 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6261 $(SRC)/character.h.
6262
6263 * Makefile.in (base_obj): Add back doprnt.o.
6264
6265 * deps.mk (doprnt.o): Add back prerequisites.
6266 (callint.o): Depend on character.h.
6267
6268 * eval.c (internal_lisp_condition_case): Include the handler
6269 representation in the error message.
6270 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6271 when breaking from the loop.
6272
6273 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6274
6275 * callint.c (Fcall_interactively): When displaying error message
6276 about invalid control letter, pass the character's codepoint, not
6277 a pointer to its multibyte form. Improve display of the character
6278 in octal and display also its hex code.
6279
6280 * character.c (char_string): Use %x to display the (unsigned)
6281 codepoint of an invalid character, to avoid displaying a bogus
6282 negative value.
6283
6284 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6285 `error', not SYMBOL_NAME itself.
6286
6287 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6288 character arguments to `error'.
6289
6290 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6291 to `error' in error message about FINAL_CHAR argument. Make sure
6292 FINAL_CHAR is a character, and use %c when it is passed as
6293 argument to `error'.
6294
6295 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6296
6297 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6298
6299 * w32.c: Include <time.h>.
6300 (sys_localtime): New function.
6301
6302 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6305
6306 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6307
6308 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6309
6310 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6311 zombies (Bug#8467).
6312
6313 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6314
6315 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6316 gl_state.e_property when gl_state.object is Qt.
6317
6318 * insdel.c (make_gap_larger): Remove limitation of buffer size
6319 to <= INT_MAX.
6320
6321 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6322
6323 * xdisp.c (lookup_glyphless_char_display)
6324 (produce_glyphless_glyph): Handle cons cell entry in
6325 glyphless-char-display.
6326 (Vglyphless_char_display): Document it.
6327
6328 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6329 glyphless-char-display.
6330
6331 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6332
6333 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6334
6335 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6336
6337 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6338 definition for no-X builds.
6339
6340 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6341
6342 Static checks with GCC 4.6.0 and non-default toolkits.
6343
6344 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6345
6346 * process.c (keyboard_bit_set): Define only if SIGIO.
6347 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6348 (send_process): Repair possible setjmp clobbering.
6349
6350 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6351
6352 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6353
6354 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6355
6356 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6357 Define only if needed.
6358
6359 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6360 by pacifying GCC about it. Maybe it's time to retire it?
6361 * xfaces.c (USG, __TIMEVAL__): Likewise.
6362
6363 * dispextern.h (struct redisplay_interface): Rename param
6364 to avoid shadowing.
6365 * termhooks.h (struct terminal): Likewise.
6366 * xterm.c (xembed_send_message): Likewise.
6367
6368 * insdel.c (make_gap_smaller): Define only if
6369 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6370
6371 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6372 it.
6373
6374 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6375 so that we aren't warned about unused symbols.
6376
6377 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6378
6379 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6380
6381 * xfns.c (x_real_positions): Mark locals as initialized.
6382
6383 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6384
6385 * xterm.c: Fix problems found by static analysis with other toolkits.
6386 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6387 (x_dispatch_event): Declare static if USE_GTK, and
6388 define if USE_GTK || USE_X_TOOLKIT.
6389 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6390 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6391 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6392 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6393
6394 * xmenu.c (menu_help_callback): Pointer type fixes.
6395 Use const pointers when pointing at readonly data. Avoid pointer
6396 signedness clashes.
6397 (FALSE): Remove unused macro.
6398 (update_frame_menubar): Remove unused decl.
6399
6400 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6401
6402 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6403 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6404 (single_menu_item): Rename local to avoid shadowing.
6405
6406 * keyboard.c (make_lispy_event): Remove unused local var.
6407
6408 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6409 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6410
6411 * bitmaps: Change bitmaps from unsigned char back to the X11
6412 compatible char. Avoid the old compiler warnings about
6413 out-of-range initializers by using, for example, '\xab' rather
6414 than 0xab.
6415
6416 * xgselect.c (xgselect_initialize): Check vs interface
6417 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6418
6419 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6420
6421 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6422 to read-only memory.
6423
6424 * fns.c (vector): Remove; this old hack is no longer needed.
6425
6426 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6427 Remove unused var.
6428 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6429
6430 * xrdb.c (x_load_resources): Omit unused local.
6431
6432 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6433 (x_window): Rename locals to avoid shadowing.
6434 (USG): Use the kludged USG macro, to pacify gcc.
6435
6436 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6437 (x_term_init): Remove local to avoid shadowing.
6438
6439 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6440
6441 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6442 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6443
6444 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6445
6446 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6447
6448 Fix regex.c, syntax.c and friends for buffers > 2GB.
6449 * syntax.h (struct gl_state_s): Declare character position members
6450 EMACS_INT.
6451
6452 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6453
6454 * textprop.c (verify_interval_modification, interval_of):
6455 Declare arguments EMACS_INT.
6456
6457 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6458 EMACS_INT.
6459
6460 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6461
6462 * indent.c (Fvertical_motion): Local variable it_start is now
6463 EMACS_INT.
6464
6465 * regex.c (re_match, re_match_2, re_match_2_internal)
6466 (bcmp_translate, regcomp, regexec, print_double_string)
6467 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6468 (re_compile_pattern, re_exec): Declare arguments and local
6469 variables `size_t' and `ssize_t' and return values `regoff_t', as
6470 appropriate.
6471 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6472 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6473 <compile_stack_type>: `size' and `avail' are now `size_t'.
6474
6475 * regex.h <regoff_t>: Use ssize_t, not int.
6476 (re_search, re_search_2, re_match, re_match_2): Arguments that
6477 specify buffer/string position and length are now ssize_t and
6478 size_t. Return type is regoff_t.
6479
6480 2011-04-16 Ben Key <bkey76@gmail.com>
6481
6482 * nsfont.m: Fixed bugs in ns_get_family and
6483 ns_descriptor_to_entity that were caused by using free to
6484 deallocate memory blocks that were allocated by xmalloc (via
6485 xstrdup). This caused Emacs to crash when compiled with
6486 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6487 --enable-checking=xmallocoverrun). xfree is now used to
6488 deallocate these memory blocks.
6489
6490 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6493
6494 emacs_write: Accept and return EMACS_INT for sizes.
6495 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6496 et seq.
6497 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6498 Accept and return EMACS_INT.
6499 (emacs_gnutls_write): Return the number of bytes written on
6500 partial writes.
6501 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6502 (emacs_read, emacs_write): Remove check for negative size, as the
6503 Emacs source code has been audited now.
6504 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6505 (emacs_read, emacs_write): Use it.
6506 * process.c (send_process): Adjust to the new signatures of
6507 emacs_write and emacs_gnutls_write. Do not attempt to store
6508 a byte offset into an 'int'; it might overflow.
6509 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6510
6511 * sound.c: Don't assume sizes fit in 'int'.
6512 (struct sound_device.period_size, alsa_period_size):
6513 Return EMACS_INT, not int.
6514 (struct sound_device.write, vox_write, alsa_write):
6515 Accept EMACS_INT, not int.
6516 (wav_play, au_play): Use EMACS_INT to store sizes and to
6517 record read return values.
6518
6519 2011-04-15 Ben Key <bkey76@gmail.com>
6520
6521 * keyboard.c (Qundefined): Don't declare static since it is used
6522 in nsfns.m.
6523 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6524 static since they are used in nsfont.m.
6525
6526 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6527
6528 * process.c (Qprocessp): Don't declare static.
6529 * lisp.h (Qprocessp): Declare again.
6530
6531 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6532
6533 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6534
6535 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6536
6537 Improve C-level modularity by making more things 'static'.
6538
6539 Don't publish debugger-only interfaces to other modules.
6540 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6541 (verify_bytepos, count_markers): Move decls to the only modules
6542 that need them.
6543 * region-cache.h (pp_cache): Likewise.
6544 * window.h (check_all_windows): Likewise.
6545 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6546
6547 * sysdep.c (croak): Now static, if
6548 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6549 * syssignal.h (croak): Declare only if not static.
6550
6551 * alloc.c (refill_memory_reserve): Now static if
6552 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6553 * lisp.h (refill_memory_reserve): Declare only if not static.
6554
6555 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6556 Define only if USE_LUCID.
6557
6558 * xrdb.c (x_customization_string, x_rm_string): Now static.
6559
6560 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6561 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6562
6563 * xdisp.c (draw_row_with_mouse_face): Now static.
6564 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6565
6566 * window.h (check_all_windows): Mark externally visible.
6567
6568 * window.c (window_deletion_count): Now static.
6569
6570 * undo.c: Make symbols static if they're not exported.
6571 (last_undo_buffer, last_boundary_position, pending_boundary):
6572 Now static.
6573
6574 * textprop.c (interval_insert_behind_hooks): Now static.
6575 (interval_insert_in_front_hooks): Likewise.
6576
6577 * term.c: Make symbols static if they're not exported.
6578 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6579 (max_frame_lines, tty_set_terminal_modes):
6580 (tty_reset_terminal_modes, tty_turn_off_highlight):
6581 (get_tty_terminal): Now static.
6582 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6583 * termhooks.h (term_mouse_moveto): Do not declare if
6584 HAVE_WINDOW_SYSTEM.
6585 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6586 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6587
6588 * sysdep.c: Make symbols static if they're not exported.
6589 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6590 Now static.
6591 (sigprocmask_set, full_mask): Remove; unused.
6592 (wait_debugging): Mark as visible.
6593 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6594 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6595
6596 * syntax.c (syntax_temp): Define only if !__GNUC__.
6597
6598 * sound.c (current_sound_device, current_sound): Now static.
6599
6600 * search.c (searchbufs, searchbuf_head): Now static.
6601
6602 * scroll.c (scroll_cost): Remove; unused.
6603 * dispextern.h (scroll_cost): Remove decl.
6604
6605 * region-cache.h (pp_cache): Mark as externally visible.
6606
6607 * process.c: Make symbols static if they're not exported.
6608 (process_tick, update_tick, create_process, chan_process):
6609 (Vprocess_alist, proc_buffered_char, datagram_access):
6610 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6611 (deactivate_process): Mark defn as static, as well as decl.
6612 * lisp.h (create_process): Remove decl.
6613 * process.h (chan_process, Vprocess_alist): Remove decls.
6614
6615 * print.c: Make symbols static if they're not exported.
6616 (print_depth, new_backquote_output, being_printed, print_buffer):
6617 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6618 (print_interval, print_number_index, initial_stderr_stream):
6619 Now static.
6620 * lisp.h (Fprinc): Remove decl.
6621 (debug_output_compilation_hack): Mark as externally visible.
6622
6623 * sysdep.c (croak): Move decl from here to syssignal.h.
6624 * syssignal.h (croak): Put it here, so the API can be checked when
6625 'croak' is called from dissociate_if_controlling_tty.
6626
6627 * minibuf.c: Make symbols static if they're not exported.
6628 (minibuf_save_list, choose_minibuf_frame): Now static.
6629 * lisp.h (choose_minibuf_frame): Remove decl.
6630
6631 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6632
6633 * lread.c: Make symbols static if they're not exported.
6634 (read_objects, initial_obarray, oblookup_last_bucket_number):
6635 Now static.
6636 (make_symbol): Remove; unused.
6637 * lisp.h (initial_obarray, make_symbol): Remove decls.
6638
6639 * keyboard.c: Make symbols static if they're not exported.
6640 (single_kboard, recent_keys_index, total_keys, recent_keys):
6641 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6642 (this_single_command_key_start, echoing, last_auto_save):
6643 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6644 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6645 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6646 (Vlispy_mouse_stem, double_click_count):
6647 Now static.
6648 (force_auto_save_soon): Define only if SIGDANGER.
6649 (ignore_mouse_drag_p): Now static if
6650 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6651 (print_help): Remove; unused.
6652 (stop_character, last_timer_event): Mark as externally visible.
6653 * keyboard.h (ignore_mouse_drag_p): Declare only if
6654 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6655 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6656 * lisp.h (echoing): Remove decl.
6657 (force_auto_save_soon): Declare only if SIGDANGER.
6658 * xdisp.c (redisplay_window): Simplify code, to make it more
6659 obvious that ignore_mouse_drag_p is not accessed if !defined
6660 USE_GTK && !defined HAVE_NS.
6661
6662 * intervals.c: Make symbols static if they're not exported.
6663 (merge_properties_sticky, merge_interval_right, delete_interval):
6664 Now static.
6665 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6666
6667 * insdel.c: Make symbols static if they're not exported.
6668 However, leave prepare_to_modify_buffer alone. It's never
6669 called from outside this function, but that appears to be a bug.
6670 (combine_after_change_list, combine_after_change_buffer):
6671 (adjust_after_replace, signal_before_change): Now static.
6672 (adjust_after_replace_noundo): Remove; unused.
6673 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6674 (signal_before_change): Remove decls.
6675
6676 * indent.c (val_compute_motion, val_vmotion): Now static.
6677
6678 * image.c: Make symbols static if they're not exported.
6679 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6680 if USE_GTK.
6681 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6682 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6683
6684 * fringe.c (standard_bitmaps): Now static.
6685 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6686
6687 * frame.c: Make symbols static if they're not exported.
6688 (x_report_frame_params, make_terminal_frame): Now static.
6689 (get_frame_param): Now static, unless HAVE_NS.
6690 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6691 (x_get_resource_string): Remove; not used.
6692 * frame.h (make_terminal_frame, x_report_frame_params):
6693 (x_get_resource_string); Remove decls.
6694 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6695 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6696
6697 * font.c, fontset.c: Make symbols static if they're not exported.
6698 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6699 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6700 * font.c (font_close_object): Now static.
6701 * font.h (font_close_object): Remove.
6702 * fontset.c (FONTSET_OBJLIST): Remove.
6703 (free_realized_fontset) #if-0 the body, which does nothing.
6704 (face_suitable_for_char_p): #if-0, as it's never called.
6705 * fontset.h (face_suitable_for_char_p): Remove decl.
6706 * xfaces.c (face_at_string_position):
6707 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6708 since 0 is always ASCII.
6709
6710 * fns.c (weak_hash_tables): Now static.
6711
6712 * fileio.c: Make symbols static if they're not exported.
6713 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6714 (Vwrite_region_annotation_buffers): Now static.
6715
6716 * eval.c: Make symbols static if they're not exported.
6717 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6718 * lisp.h (backtrace_list): Remove decl.
6719
6720 * emacs.c: Make symbols static if they're not exported.
6721 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6722 (fatal_error_code, fatal_error_signal_hook, standard_args):
6723 Now static.
6724 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6725 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6726 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6727 * lisp.h (fatal_error_signal_hook): Remove decl.
6728 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6729
6730 * editfns.c: Move a (normally-unused) function to its only use.
6731 * editfns.c, lisp.h (get_operating_system_release): Remove.
6732 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6733 worth the hassle of breaking this out.
6734
6735 * xterm.c: Make symbols static if they're not exported.
6736 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6737 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6738 (x_destroy_window, x_delete_display):
6739 Now static.
6740 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6741 (x_mouse_leave): Remove; unused.
6742 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6743 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6744 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6745 Remove decls.
6746 (x_mouse_leave): Declare only if WINDOWSNT.
6747 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6748 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6749 USE_X_TOOLKIT.
6750
6751 * ftxfont.c: Make symbols static if they're not exported.
6752 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6753 HAVE_FREETYPE.
6754 * font.h (ftxfont_driver): Likewise.
6755
6756 * xfns.c: Make symbols static if they're not exported.
6757 (x_last_font_name, x_display_info_for_name):
6758 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6759 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6760 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6761 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6762 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6763 (last_show_tip_args): Now static.
6764 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6765 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6766 (x_screen_planes): Remove; unused.
6767 * dispextern.h (x_screen_planes): Remove decl.
6768
6769 * dispnew.c: Make symbols static if they're not exported.
6770 * dispextern.h (redraw_garbaged_frames, scrolling):
6771 (increment_row_positions): Remove.
6772 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6773 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6774 Now static.
6775 (redraw_garbaged_frames): Remove; unused.
6776
6777 * xfaces.c: Make symbols static if they're not exported.
6778 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6779 Remove decls.
6780 * xterm.h (defined_color): Remove decls.
6781 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6782 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6783 (menu_face_changed_default, defined_color, free_realized_face):
6784 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6785 (ascii_face_of_lisp_face): Remove; unused.
6786
6787 * xdisp.c: Make symbols static if they're not exported.
6788 * dispextern.h (scratch_glyph_row, window_box_edges):
6789 (glyph_to_pixel_coords, set_cursor_from_row):
6790 (get_next_display_element, set_iterator_to_next):
6791 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6792 (show_mouse_face): Remove decls
6793 * frame.h (message_buf_print): Likewise.
6794 * lisp.h (pop_message, set_message, check_point_in_composition):
6795 Likewise.
6796 * xterm.h (set_vertical_scroll_bar): Likewise.
6797 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6798 (message_buf_print, scratch_glyph_row, displayed_buffer):
6799 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6800 (get_next_display_element, show_mouse_face, window_box_edges):
6801 (frame_to_window_pixel_xy, check_point_in_composition):
6802 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6803 (glyph_to_pixel_coords): Remove; unused.
6804
6805 * dired.c (file_name_completion): Now static.
6806
6807 * dbusbind.c (xd_in_read_queued_messages): Now static.
6808
6809 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6810 * data.c (circular_list_error): Remove.
6811
6812 * commands.h (last_point_position, last_point_position_buffer):
6813 (last_point_position_window): Remove decls.
6814 * keyboard.c: Make these variables static.
6815
6816 * coding.h (coding, code_convert_region, encode_coding_gap):
6817 Remove decls.
6818 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6819 (iso_code_class, detect_coding, code_convert_region): Now static.
6820 (encode_coding_gap): Remove; unused.
6821
6822 * chartab.c (chartab_chars, chartab_bits): Now static.
6823
6824 * charset.h (charset_iso_8859_1): Remove decl.
6825 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6826 Now static.
6827
6828 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6829 * ccl.c (Vccl_program_table): Now static.
6830 (check_ccl_update): Remove; unused.
6831
6832 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6833 * category.h: ... from here.
6834 * category.c (check_category_table, set_category_set): Now static.
6835
6836 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6837 * lisp.h: Remove these decls.
6838
6839 * buffer.c (buffer_count): Remove unused var.
6840
6841 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6842 so that it's not optimized away.
6843 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6844 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6845 exported only to the debugger.
6846
6847 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6848 * atimer.h (run_all_atimers): Remove; not exported.
6849
6850 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6851 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6852 was inaccessible from Lisp.
6853 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6854 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6855
6856 alloc.c: Import and export fewer symbols, and remove unused items.
6857 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6858 is defined.
6859 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6860 it's not optimized away by whole-program optimization.
6861 (message_enable_multibyte, free_misc): Remove.
6862 (catchlist, handlerlist, mark_backtrace):
6863 Declare only if BYTE_MARK_STACK.
6864 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6865 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6866 (message_enable_multibyte): Remove decl.
6867 (free_misc, interval_free_list, float_block, float_block_index):
6868 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6869 (cons_free_list, last_marked_index):
6870 Now static.
6871 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6872 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6873 (mark_backtrace): Define only if BYTE_MARK_STACK.
6874 * xdisp.c (message_enable_multibyte): Now static.
6875
6876 Declare Lisp_Object Q* variables to be 'static' if not exported.
6877 This makes it easier for human readers (and static analyzers)
6878 to see whether these variables are used from other modules.
6879 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6880 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6881 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6882 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6883 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6884 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6885 * xmenu.c, xselect.c:
6886 Declare Q* vars static if they are not used in other modules.
6887 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6888 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6889 Remove decls of unexported vars.
6890 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6891
6892 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6893
6894 Make Emacs functions such as Fatom 'static' by default.
6895 This makes it easier for human readers (and static analyzers)
6896 to see whether these functions can be called from other modules.
6897 DEFUN now defines a static function. To make the function external
6898 so that it can be used in other C modules, use the new macro DEFUE.
6899 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6900 (Finit_image_library):
6901 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6902 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6903 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6904 Remove decls, since these functions are now static.
6905 (Funintern, Fget_internal_run_time): New decls, since these functions
6906 were already external.
6907
6908 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6909 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6910 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6911 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6912 * keyboard.c, keymap.c, lread.c:
6913 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6914 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6915 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6916 Mark functions with DEFUE instead of DEFUN,
6917 if they are used in other modules.
6918 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6919 decls for now-static functions.
6920 * buffer.h (Fdelete_overlay): Remove decl.
6921 * callproc.c (Fgetenv_internal): Mark as internal.
6922 * composite.c (Fremove_list_of_text_properties): Remove decl.
6923 (Fcomposition_get_gstring): New forward static decl.
6924 * composite.h (Fcomposite_get_gstring): Remove decl.
6925 * dired.c (Ffile_attributes): New forward static decl.
6926 * doc.c (Fdocumntation_property): New forward static decl.
6927 * eval.c (Ffetch_bytecode): New forward static decl.
6928 (Funintern): Remove extern decl; now in .h file where it belongs.
6929 * fileio.c (Fmake_symbolic_link): New forward static decl.
6930 * image.c (Finit_image_library): New forward static decl.
6931 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6932 * intervals.h (Fprevious_property_change):
6933 (Fremove_list_of_text_properties): Remove decls.
6934 * keyboard.c (Fthis_command_keys): Remove decl.
6935 (Fcommand_execute): New forward static decl.
6936 * keymap.c (Flookup_key): New forward static decl.
6937 (Fcopy_keymap): Now static.
6938 * keymap.h (Flookup_key): Remove decl.
6939 * process.c (Fget_process): New forward static decl.
6940 (Fprocess_datagram_address): Mark as internal.
6941 * syntax.c (Fsyntax_table_p): New forward static decl.
6942 (skip_chars): Remove duplicate decl.
6943 * textprop.c (Fprevious_property_change): New forward static decl.
6944 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6945 Now internal.
6946 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6947 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6948
6949 * editfns.c (Fformat): Remove unreachable code.
6950
6951 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6952
6953 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6954 change. (Bug#8496)
6955
6956 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6957
6958 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6959 when at ZV. (Bug#8487)
6960
6961 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6962
6963 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6964 (Bug#8437)
6965 * keyboard.c (parse_tool_bar_item): Likewise.
6966 * sound.c (sound_cleanup, alsa_close): Likewise.
6967 * termcap.c (tgetent): Likewise.
6968 * xfns.c (x_default_font_parameter): Likewise.
6969 * xsettings.c (read_and_apply_settings): Likewise.
6970
6971 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6972 (overrun_check_free): Protoize.
6973
6974 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6975
6976 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6977 since callers should never pass a negative size.
6978 Change the signature to match that of plain 'read' and 'write'; see
6979 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6980 * lisp.h: Update prototypes of emacs_write and emacs_read.
6981
6982 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6983
6984 * xdisp.c (redisplay_window): Don't try to determine the character
6985 position of the scroll margin if the window start point w->startp
6986 is outside the buffer's accessible region. (Bug#8468)
6987
6988 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6989
6990 Fix write-region and its subroutines for buffers > 2GB.
6991 * fileio.c (a_write, e_write): Modify declaration of arguments and
6992 local variables to support buffers larger than 2GB.
6993 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6994
6995 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6996 argument, local variables, and return value.
6997
6998 * lisp.h: Update prototypes of emacs_write and emacs_read.
6999
7000 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7001
7002 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7003
7004 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7005
7006 Fix more problems found by GCC 4.6.0's static checks.
7007
7008 * xdisp.c (vmessage): Use a better test for character truncation.
7009
7010 * charset.c (load_charset_map): <, not <=, for optimization,
7011 and to avoid potential problems with integer overflow.
7012 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7013 * casetab.c (set_identity, shuffle): Likewise.
7014 * editfns.c (Fformat): Likewise.
7015 * syntax.c (skip_chars): Likewise.
7016
7017 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7018 This also lets GCC 4.6.0 generate slightly better loop code.
7019
7020 * callint.c (Fcall_interactively): <, not <=, for optimization.
7021 (Fcall_interactively): Count the number of arguments produced,
7022 not the number of arguments given. This is simpler and lets GCC
7023 4.6.0 generate slightly better code.
7024
7025 * ftfont.c: Distingish more carefully between FcChar8 and char.
7026 The previous code passed unsigned char * to a functions like
7027 strlen and xstrcasecmp that expect char *, which does not
7028 conform to the C standard.
7029 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7030 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7031 char * when the C standard requires it.
7032
7033 * keyboard.c (read_char): Remove unused var.
7034
7035 * eval.c: Port to Windows vsnprintf (Bug#8435).
7036 Include <limits.h>.
7037 (SIZE_MAX): Define if the headers do not.
7038 (verror): Do not give up if vsnprintf returns a negative count.
7039 Instead, grow the buffer. This ports to Windows vsnprintf, which
7040 does not conform to C99. Problem reported by Eli Zaretskii.
7041 Also, simplify the allocation scheme, by avoiding the need for
7042 calling realloc, and removing the ALLOCATED variable.
7043
7044 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7045
7046 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7047 But keep the doprint source code for now, as we might revamp it
7048 and use it again (Bug#8435).
7049 * lisp.h (doprnt): Remove.
7050 * Makefile.in (base_obj): Remove doprnt.o.
7051 * deps.mk (doprnt.o): Remove.
7052
7053 error: Print 32- and 64-bit integers portably (Bug#8435).
7054 Without this change, on typical 64-bit hosts error ("...%d...", N)
7055 was used to print both 32- and 64-bit integers N, which relied on
7056 undefined behavior.
7057 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7058 New macro.
7059 * lisp.h (error, verror): Mark as printf-like functions.
7060 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7061 Report overflow in size calculations when allocating printf buffer.
7062 Do not truncate output string at its first null byte.
7063 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7064 Truncate the output at a character boundary, since vsnprintf does not
7065 do that.
7066 * charset.c (check_iso_charset_parameter): Convert internal
7067 character to string before calling 'error', since %c now has the
7068 printf meaning.
7069 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7070 overflow when computing char to be passed to 'error'. Do not
7071 pass Lisp_Object to 'error'; pass the integer instead.
7072 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7073 formatted with plain %d.
7074
7075 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7076
7077 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7078
7079 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7080
7081 * xterm.c (x_catch_errors): Remove duplicate declaration.
7082
7083 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7084
7085 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7086
7087 2011-04-10 Jim Meyering <meyering@redhat.com>
7088
7089 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7090 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7091 return ssize_t not "int", and use size_t as the buffer length.
7092 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7093 * gnutls.h: Update declarations.
7094 * process.c (read_process_output): Use ssize_t, to match.
7095 (send_process): Likewise.
7096
7097 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7098
7099 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7100
7101 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7102
7103 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7104 Use unsigned char, to match FcChar8 type definition.
7105
7106 * xterm.c (handle_one_xevent):
7107 * xmenu.c (create_and_show_popup_menu):
7108 * xselect.c (x_decline_selection_request)
7109 (x_reply_selection_request): Avoid type-punned deref of X events.
7110
7111 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7112
7113 Fix some uses of `int' instead of EMACS_INT.
7114 * search.c (string_match_1, fast_string_match)
7115 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7116 (scan_buffer, find_next_newline_no_quit)
7117 (find_before_next_newline, search_command, Freplace_match)
7118 (Fmatch_data): Make some `int' variables be EMACS_INT.
7119
7120 * xdisp.c (display_count_lines): 3rd argument and return value now
7121 EMACS_INT. All callers changed.
7122 (pint2hrstr): Last argument is now EMACS_INT.
7123
7124 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7125 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7126 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7127 (decode_coding_utf_16, decode_coding_emacs_mule)
7128 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7129 (decode_coding_ccl, decode_coding_charset)
7130 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7131 (decode_coding_iso_2022, decode_coding_emacs_mule)
7132 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7133 <char_offset, last_offset>: Declare EMACS_INT.
7134 (encode_coding_utf_8, encode_coding_utf_16)
7135 (encode_coding_emacs_mule, encode_invocation_designation)
7136 (encode_designation_at_bol, encode_coding_iso_2022)
7137 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7138 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7139 Declare EMACS_INT.
7140 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7141 (encode_invocation_designation): Last argument P_NCHARS is now
7142 EMACS_INT.
7143 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7144 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7145
7146 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7147 All users changed.
7148
7149 * ccl.c (Fccl_execute_on_string): Declare some variables
7150 EMACS_INT.
7151
7152 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7153
7154 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7155
7156 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7157
7158 * process.c (Fformat_network_address): Doc fix.
7159
7160 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7161
7162 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7163
7164 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7165
7166 * keyboard.c (read_char): Call Lisp function help-form-show,
7167 instead of using internal_with_output_to_temp_buffer.
7168 (Qhelp_form_show): New var.
7169 (syms_of_keyboard): Use DEFSYM macro.
7170
7171 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7172
7173 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7174
7175 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7176
7177 * process.c (Flist_processes): Remove to Lisp.
7178 (list_processes_1): Delete.
7179
7180 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7181
7182 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7183
7184 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7185
7186 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7187
7188 Fix more problems found by GCC 4.6.0's static checks.
7189
7190 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7191
7192 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7193
7194 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7195
7196 * xdisp.c (vmessage): Mark as a printf-like function.
7197
7198 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7199
7200 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7201
7202 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7203 printf-like functions.
7204 (tiff_load): Add casts to remove these marks before passing them
7205 to system-supplied API.
7206
7207 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7208
7209 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7210 This avoids several warnings with gcc -Wstrict-overflow.
7211 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7212 directly, rather than having caller test rule sign. This avoids
7213 some unnecessary tests.
7214 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7215 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7216 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7217
7218 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7219 (xfont_open): Avoid unnecessary tests.
7220
7221 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7222
7223 * composite.h, composite.c (composition_gstring_put_cache):
7224 Use EMACS_INT, not int, for length.
7225
7226 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7227 breaking out part of COMPOSITION_DECODE_RULE.
7228 (COMPOSITION_DECODE_RULE): Use it.
7229 * composite.c (get_composition_id): Remove unused local vars,
7230 by using the new macro.
7231
7232 * textprop.c (set_text_properties_1): Change while to do-while,
7233 since the condition is always true at first.
7234
7235 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7236 (interval_deletion_adjustment): Return unsigned value.
7237 All uses changed.
7238
7239 * process.c (list_processes_1, create_pty, read_process_output):
7240 (exec_sentinel): Remove vars that were set but not used.
7241 (create_pty): Remove unnecessary "volatile"s.
7242 (Fnetwork_interface_info): Avoid possibility of int overflow.
7243 (read_process_output): Do adaptive read buffering even if carryover.
7244 (read_process_output): Simplify nbytes computation if buffered.
7245
7246 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7247
7248 * syntax.c (scan_words): Remove var that was set but not used.
7249 (update_syntax_table): Use unsigned instead of int.
7250
7251 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7252 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7253 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7254
7255 * print.c (print_error_message): Avoid int overflow.
7256
7257 * font.c (font_list_entities): Redo for clarity,
7258 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7259
7260 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7261 (font_score): Avoid potential overflow in diff calculation.
7262
7263 * fns.c (substring_both): Remove var that is set but not used.
7264 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7265
7266 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7267
7268 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7269 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7270 can always succeed if overflow has undefined behavior.
7271
7272 * search.c (boyer_moore, wordify): Remove vars set but not used.
7273 (wordify): Omit three unnecessary tests.
7274
7275 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7276 All callers changed. This avoids the need for an unused var.
7277
7278 * casefiddle.c (casify_region): Remove var that is set but not used.
7279
7280 * dired.c (file_name_completion): Remove var that is set but not used.
7281
7282 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7283
7284 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7285 (Finsert_file_contents): Remove unnecessary code checking fd.
7286
7287 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7288 Check for integer overflow on size calculations.
7289
7290 * buffer.c (Fprevious_overlay_change): Remove var that is set
7291 but not used.
7292
7293 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7294 Remove vars that are set but not used.
7295 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7296 (timer_check_2): Mark vars as initialized.
7297
7298 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7299
7300 * image.c (lookup_image): Remove var that is set but not used.
7301 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7302
7303 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7304 that are set but not used.
7305
7306 * xfns.c (make_invisible_cursor): Don't return garbage
7307 if XCreateBitmapFromData fails (Bug#8410).
7308
7309 * xselect.c (x_get_local_selection, x_handle_property_notify):
7310 Remove vars that are set but not used.
7311
7312 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7313 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7314
7315 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7316 Remove var that is set but not used.
7317 (scroll_bar_windows_size): Now size_t, not int.
7318 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7319 Check for overflow.
7320
7321 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7322 (map_tty_color) [!defined MSDOS]: Likewise.
7323
7324 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7325
7326 * coding.c: Remove vars that are set but not used.
7327 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7328 All callers changed.
7329 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7330 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7331 (decode_coding_charset): Remove vars that are set but not used.
7332
7333 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7334 that is set but not used.
7335
7336 * print.c (print_object): Remove var that is set but not used.
7337
7338 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7339 The gnulib version avoids calling malloc in the usual case,
7340 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7341 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7342 * filelock.c (current_lock_owner): Likewise.
7343 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7344 * sysdep.c: Include allocator.h, careadlinkat.h.
7345 (emacs_no_realloc_allocator): New static constant.
7346 (emacs_readlink): New function.
7347 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7348 ../lib/careadlinkat.h.
7349
7350 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7351
7352 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7353 first non-nil return value).
7354
7355 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7356
7357 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7358 if not defined (Bug#8403).
7359
7360 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7361
7362 * xdisp.c (display_count_lines): Remove parameter `start',
7363 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7364 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7365 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7366 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7367 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7368 and thereabouts. All callers changed.
7369 (get_per_char_metric): Remove parameter `f', unused since
7370 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7371
7372 2011-04-02 Jim Meyering <meyering@redhat.com>
7373
7374 do not dereference NULL upon failed strdup
7375 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7376 (ns_get_family): Likewise.
7377
7378 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7379
7380 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7381
7382 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7383
7384 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7385 later (Bug#8403).
7386
7387 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7388
7389 Add lexical binding.
7390
7391 * window.c (Ftemp_output_buffer_show): New fun.
7392 (Fsave_window_excursion):
7393 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7394
7395 * lread.c (lisp_file_lexically_bound_p): New function.
7396 (Fload): Bind Qlexical_binding.
7397 (readevalloop): Remove `evalfun' arg.
7398 Bind Qinternal_interpreter_environment.
7399 (Feval_buffer): Bind Qlexical_binding.
7400 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7401 Mark as dynamic.
7402 (syms_of_lread): Declare `lexical-binding'.
7403
7404 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7405
7406 * keyboard.c (eval_dyn): New fun.
7407 (menu_item_eval_property): Use it.
7408
7409 * image.c (parse_image_spec): Use Ffunctionp.
7410
7411 * fns.c (concat, mapcar1): Accept byte-code-functions.
7412
7413 * eval.c (Fsetq): Handle lexical vars.
7414 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7415 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7416 (FletX, Flet): Obey lexical binding.
7417 (Fcommandp): Handle closures.
7418 (Feval): New `lexical' arg.
7419 (eval_sub): New function extracted from Feval. Use it almost
7420 everywhere where Feval was used. Look up vars in lexical env.
7421 Handle closures.
7422 (Ffunctionp): Move from subr.el.
7423 (Ffuncall): Handle closures.
7424 (apply_lambda): Remove `eval_flags'.
7425 (funcall_lambda): Handle closures and new byte-code-functions.
7426 (Fspecial_variable_p): New function.
7427 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7428 but without exporting it to Lisp.
7429
7430 * doc.c (Fdocumentation, store_function_docstring):
7431 * data.c (Finteractive_form): Handle closures.
7432
7433 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7434 interactive spec.
7435
7436 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7437 New byte-codes.
7438 (exec_byte_code): New function extracted from Fbyte_code to handle new
7439 calling convention for byte-code-functions. Add new byte-codes.
7440
7441 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7442
7443 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7444
7445 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7446
7447 * xdisp.c (redisplay_internal): Fix prototype.
7448
7449 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7450
7451 * xdisp.c (SCROLL_LIMIT): New macro.
7452 (try_scrolling): Use it when setting scroll_limit.
7453 Limit scrolling to 100 screen lines.
7454 (redisplay_window): Even when falling back on "recentering",
7455 position point in the window according to scroll-conservatively,
7456 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7457
7458 (try_scrolling): When point is above the window, allow searching
7459 as far as scroll_max, or one screenful, to compute vertical
7460 distance from PT to the scroll margin position. This prevents
7461 try_scrolling from unnecessarily failing when
7462 scroll-conservatively is set to a value slightly larger than the
7463 window height. Clean up the case of PT below the margin at bottom
7464 of window: scroll_max can no longer be INT_MAX. When aggressive
7465 scrolling is in use, don't let point enter the opposite scroll
7466 margin as result of the scroll.
7467 (syms_of_xdisp) <scroll-conservatively>: Document the
7468 threshold of 100 lines for never-recentering scrolling.
7469
7470 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7471
7472 * dispextern.h (move_it_by_lines):
7473 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7474 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7475 (message_log_check_duplicate): Remove parameters `prev_bol' and
7476 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7477 (redisplay_internal): Remove parameter `preserve_echo_area',
7478 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7479
7480 * indent.c (Fvertical_motion):
7481 * window.c (window_scroll_pixel_based, Frecenter):
7482 Don't pass `need_y_p' to `move_it_by_lines'.
7483
7484 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7485
7486 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7487 steal a few bits to be more compact.
7488 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7489 Remove unneeded casts.
7490
7491 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7492
7493 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7494
7495 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7496 binding" message (bug#7967).
7497
7498 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7499
7500 Fix more problems found by GCC 4.6.0's static checks.
7501
7502 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7503 Remove unused local var.
7504
7505 * editfns.c (Fmessage_box): Remove unused local var.
7506
7507 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7508 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7509 Omit unused local vars.
7510 * window.c (shrink_windows): Omit unused local var.
7511 * menu.c (digest_single_submenu): Omit unused local var.
7512 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7513 Omit unused local var.
7514
7515 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7516 Don't assume string length fits in int.
7517 (keyremap_step, read_key_sequence): Use size_t for sizes.
7518 (read_key_sequence): Don't check last_real_key_start redundantly.
7519
7520 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7521 instead of alloca (Bug#8344).
7522
7523 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7524 (Fbacktrace_frame): Don't assume nframes fits in int.
7525
7526 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7527
7528 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7529 concerns.
7530
7531 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7532
7533 * cm.c (calccost): Turn while-do into do-while, for clarity.
7534
7535 * keyboard.c (syms_of_keyboard): Use the same style as later
7536 in this function when indexing through an array. This also
7537 works around GCC bug 48267.
7538
7539 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7540
7541 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7542
7543 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7544 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7545
7546 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7547 This avoids undefined behavior on integer overflow, and is a bit
7548 more convenient anyway since it is compared to a size_t variable.
7549
7550 Variadic C functions now count arguments with size_t, not int.
7551 This avoids an unnecessary limitation on 64-bit machines, which
7552 caused (substring ...) to crash on large vectors (Bug#8344).
7553 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7554 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7555 All variadic functions and their callers changed accordingly.
7556 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7557 * data.c (arith_driver, float_arith_driver): Likewise.
7558 * editfns.c (general_insert_function): Likewise.
7559 * eval.c (struct backtrace.nargs, interactive_p)
7560 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7561 (funcall_lambda, mark_backtrace): Likewise.
7562 * fns.c (concat): Likewise.
7563 * frame.c (x_set_frame_parameters): Likewise.
7564 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7565 0 if not found, not -1. All callers changed.
7566
7567 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7568 (stack_copy_size): Now size_t, not int.
7569 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7570
7571 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7572
7573 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7574 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7575 All callers changed.
7576
7577 * lisp.h (multibyte_char_to_unibyte):
7578 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7579 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7580 * character.h (CHAR_TO_BYTE8):
7581 * cmds.c (internal_self_insert):
7582 * editfns.c (general_insert_function):
7583 * keymap.c (push_key_description):
7584 * search.c (Freplace_match):
7585 * xdisp.c (message_dolog, set_message_1): All callers changed.
7586
7587 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7588
7589 * keyboard.c (safe_run_hook_funcall): New function.
7590 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7591 don't set the hook to nil, but remove the offending function instead.
7592 (Qcommand_hook_internal): Remove, unused.
7593 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7594 Vcommand_hook_internal.
7595
7596 * eval.c (enum run_hooks_condition): Remove.
7597 (funcall_nil, funcall_not): New functions.
7598 (run_hook_with_args): Call each function through a `funcall' argument.
7599 Remove `cond' argument, now redundant.
7600 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7601 (Frun_hook_with_args_until_failure): Adjust accordingly.
7602 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7603
7604 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7605
7606 * dispextern.h (string_buffer_position): Remove declaration.
7607
7608 * print.c (strout): Remove parameter `multibyte', unused since
7609 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7610
7611 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7612 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7613 All callers changed.
7614
7615 * w32.c (_wsa_errlist): Use braces for struct initializers.
7616
7617 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7618 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7619 All callers changed.
7620 (string_buffer_position): Likewise. Also, make static (it's never
7621 used outside xdisp.c).
7622 (cursor_row_p): Remove parameter `w', unused since
7623 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7624 (decode_mode_spec): Remove parameter `precision', introduced during
7625 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7626 All callers changed.
7627
7628 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7629
7630 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7631
7632 2011-03-27 Anders Lindgren <andlind@gmail.com>
7633
7634 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7635 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7636 (ns_update_auto_hide_menu_bar): New functions.
7637 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7638 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7639 ns_constrain_all_frames.
7640 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7641 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7642
7643 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7644
7645 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7646
7647 2011-03-27 Glenn Morris <rgm@gnu.org>
7648
7649 * syssignal.h: Replace RETSIGTYPE with void.
7650 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7651 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7652 Replace SIGTYPE with void everywhere.
7653 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7654 * s/template.h (SIGTYPE): Remove commented out definition.
7655
7656 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7657
7658 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7659 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7660
7661 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7662
7663 * w32.c (read_unc_volume): Use parameter `henum', instead of
7664 global variable `wget_enum_handle'.
7665
7666 * keymap.c (describe_vector): Remove parameters `indices' and
7667 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7668 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7669
7670 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7671
7672 * keyboard.c (timer_check): Remove parameter `do_it_now',
7673 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7674 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7675 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7676
7677 * keyboard.c (read_char):
7678 * w32menu.c (w32_menu_display_help):
7679 * xmenu.c (show_help_event, menu_help_callback):
7680 Adjust calls to `show_help_echo'.
7681
7682 * gtkutil.c (xg_maybe_add_timer):
7683 * keyboard.c (readable_events):
7684 * process.c (wait_reading_process_output):
7685 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7686
7687 * insdel.c (adjust_markers_gap_motion):
7688 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7689 (gap_left, gap_right): Don't call it.
7690
7691 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7692
7693 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7694 incurred during fontification.
7695
7696 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7697
7698 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7699 (DEFVAR_PER_BUFFER): Don't pass it.
7700
7701 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7702 (scrolling_window): Don't pass it.
7703
7704 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7705
7706 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7707
7708 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7709 and `suffix'.
7710 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7711 of variables specific to SELinux and computation of `encoded_absname'.
7712
7713 * image.c (XPutPixel): Remove unused variable `height'.
7714
7715 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7716
7717 * unexw32.c (get_section_info): Remove unused variable `section'.
7718
7719 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7720 (system_process_attributes): Remove unused variable `sess'.
7721 (sys_read): Remove unused variable `err'.
7722
7723 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7724 (w32_wnd_proc): Remove unused variable `isdead'.
7725 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7726 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7727 (x_create_tip_frame): Remove unused variable `tem'.
7728
7729 * w32inevt.c (w32_console_read_socket):
7730 Remove unused variable `no_events'.
7731
7732 * w32term.c (x_draw_composite_glyph_string_foreground):
7733 Remove unused variable `width'.
7734
7735 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7736
7737 * w32term.c (x_set_glyph_string_clipping):
7738 Don't pass uninitialized region to CombineRgn.
7739
7740 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7741
7742 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7743 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7744 (Fx_close_connection): Remove unused variable `i'.
7745
7746 * w32font.c (w32font_draw): Return number of glyphs.
7747 (w32font_open_internal): Remove unused variable `i'.
7748 (w32font_driver): Add missing initializer.
7749
7750 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7751 (fill_in_menu): Remove unused variable `items_added'.
7752
7753 * w32term.c (last_mouse_press_frame): Remove static global variable.
7754 (w32_clip_to_row): Remove unused variable `f'.
7755 (x_delete_terminal): Remove unused variable `i'.
7756
7757 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7758 (NOTHING): Remove unused static global variable.
7759 (uniscribe_check_otf): Remove unused variable `table'.
7760 (uniscribe_font_driver): Add missing initializers.
7761
7762 2011-03-23 Julien Danjou <julien@danjou.info>
7763
7764 * term.c (Fsuspend_tty, Fresume_tty):
7765 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7766 * window.c (temp_output_buffer_show):
7767 * insdel.c (signal_before_change):
7768 * frame.c (Fhandle_switch_frame):
7769 * fileio.c (Fdo_auto_save):
7770 * emacs.c (Fkill_emacs):
7771 * editfns.c (save_excursion_restore):
7772 * cmds.c (internal_self_insert):
7773 * callint.c (Fcall_interactively):
7774 * buffer.c (Fkill_all_local_variables):
7775 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7776 Use Frun_hooks.
7777 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7778 unconditionally since it does the check itself.
7779
7780 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7781
7782 Fix more problems found by GCC 4.5.2's static checks.
7783
7784 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7785 the first time through the loop, since we know p0 < p1 then.
7786 This also avoids a gcc -Wstrict-overflow warning.
7787
7788 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7789 leading to a memory leak, possible in functions like
7790 load_charset_map_from_file that can allocate an unbounded number
7791 of objects (Bug#8318).
7792
7793 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7794 that could (at least in theory) be that large.
7795
7796 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7797 This is less likely to overflow, and avoids undefined behavior if
7798 overflow does occur. All callers changed. Use strtoul to scan
7799 for the unsigned long integer.
7800 (pint2hrstr): Simplify and tune code slightly.
7801 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7802
7803 * scroll.c (do_scrolling): Work around GCC bug 48228.
7804 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7805
7806 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7807 This also avoids a warning with gcc -Wstrict-overflow.
7808 (validate_x_resource_name): Simplify count usage.
7809 This also avoids a warning with gcc -Wstrict-overflow.
7810
7811 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7812 fail (Bug#8306).
7813
7814 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7815
7816 * process.c (Fmake_network_process): Use socklen_t, not int,
7817 where POSIX says socklen_t is required in portable programs.
7818 This fixes a porting bug on hosts like 64-bit HP-UX, where
7819 socklen_t is wider than int (Bug#8277).
7820 (Fmake_network_process, server_accept_connection):
7821 (wait_reading_process_output, read_process_output):
7822 Likewise.
7823
7824 * process.c: Rename or move locals to avoid shadowing.
7825 (list_processes_1, Fmake_network_process):
7826 (read_process_output_error_handler, exec_sentinel_error_handler):
7827 Rename or move locals.
7828 (Fmake_network_process): Define label "retry_connect" only if needed.
7829 (Fnetwork_interface_info): Fix pointer signedness.
7830 (process_send_signal): Add cast to avoid pointer signedness problem.
7831 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7832 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7833
7834 Make tparam.h and terminfo.c consistent.
7835 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7836 Include tparam.h instead, since it declares them.
7837 * cm.h (PC): Remove extern decl; tparam.h now does this.
7838 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7839 * terminfo.c: Include tparam.h, to check interfaces.
7840 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7841 (tparam): Adjust signature to match interface in tparam.h;
7842 this removes some undefined behavior. Check that outstring and len
7843 are zero, which they always are with Emacs.
7844 * tparam.h (PC, BC, UP): New extern decls.
7845
7846 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7847 (xftfont_open): Rename locals to avoid shadowing.
7848
7849 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7850 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7851 (OTF_TAG_SYM): Omit macro if not needed.
7852 (ftfont_list): Remove unused local.
7853 (get_adstyle_property, ftfont_pattern_entity):
7854 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7855 Rename locals to avoid shadowing.
7856
7857 * xfont.c (xfont_list_family): Mark var as initialized.
7858
7859 * xml.c (make_dom): Now static.
7860
7861 * composite.c (composition_compute_stop_pos): Rename local to
7862 avoid shadowing.
7863 (composition_reseat_it): Remove unused locals.
7864 (find_automatic_composition, composition_adjust_point): Likewise.
7865 (composition_update_it): Mark var as initialized.
7866 (find_automatic_composition): Mark vars as initialized,
7867 with a FIXME (Bug#8290).
7868
7869 character.h: Rename locals to avoid shadowing.
7870 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7871 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7872 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7873 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7874 to avoid shadowing.
7875
7876 * textprop.c (property_change_between_p): Remove; unused.
7877
7878 * intervals.c (interval_start_pos): Now static.
7879
7880 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7881
7882 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7883 Rename locals to avoid shadowing.
7884
7885 * sound.c (wav_play, au_play, Fplay_sound_internal):
7886 Fix pointer signedness.
7887 (alsa_choose_format): Remove unused local var.
7888 (wav_play): Initialize a variable to 0, to prevent undefined
7889 behavior (Bug#8278).
7890
7891 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7892
7893 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7894
7895 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7896 clobbering (Bug#8298).
7897 * sysdep.c (sys_subshell): Likewise.
7898 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7899
7900 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7901 This should get cleaned up, so that child_setup has the
7902 same signature on all platforms.
7903
7904 * callproc.c (call_process_cleanup): Now static.
7905 (relocate_fd): Rename locals to avoid shadowing.
7906
7907 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7908
7909 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7910 not to be necessary, and produces flickering.
7911
7912 2011-03-20 Glenn Morris <rgm@gnu.org>
7913
7914 * config.in: Remove file.
7915
7916 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7917
7918 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7919 are now in src/globals.h.
7920 (syms_of_minibuf): Remove spurious & from previous change.
7921
7922 2011-03-20 Leo <sdl.web@gmail.com>
7923
7924 * minibuf.c (completing-read-function): New variable.
7925 (completing-read-default): Rename from completing-read.
7926 (completing-read): Call completing-read-function.
7927
7928 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7929
7930 * xfaces.c (Fx_load_color_file):
7931 Read color file from absolute filename (bug#8250).
7932
7933 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7934
7935 * makefile.w32-in: Update dependencies.
7936
7937 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7938
7939 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7940
7941 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7942
7943 Fix more problems found by GCC 4.5.2's static checks.
7944
7945 * process.c (make_serial_process_unwind, send_process_trap):
7946 (sigchld_handler): Now static.
7947
7948 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7949 That way, the code declares only the vars that it needs.
7950 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7951 * s/cygwin.h (PTY_ITERATION): Likewise.
7952 * s/darwin.h (PTY_ITERATION): Likewise.
7953 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7954
7955 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7956 * process.c (allocate_pty): Don't declare stb unless it's needed.
7957
7958 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7959 (CONSTANTLIM): Remove; unused.
7960 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7961 Define only if needed.
7962
7963 * unexelf.c (unexec): Name an expression,
7964 to avoid gcc -Wbad-function-cast warning.
7965 Use a different way to cause a compilation error if anyone uses
7966 n rather than nn, a way that does not involve shadowing.
7967 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7968
7969 * deps.mk (unexalpha.o): Remove; unused.
7970
7971 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7972 * unexec.h: New file.
7973 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7974 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7975 Depend on unexec.h.
7976 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7977 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7978 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7979 Change as necessary to match prototype in unexec.h.
7980
7981 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7982 shadowing.
7983 (back_comment, skip_chars): Mark vars as initialized.
7984
7985 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7986 Rename locals to avoid shadowing.
7987
7988 * lread.c (read1): Rewrite so as not to use empty "else".
7989 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7990
7991 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7992
7993 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7994 warning when compiling print.c.
7995
7996 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7997 instead of using an uninitialized var.
7998 (font_sort_entities): Mark var as initialized.
7999
8000 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8001
8002 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8003 pointers to constants.
8004 (font_parse_fcname): Remove unused vars.
8005 (font_delete_unmatched): Now static.
8006 (font_get_spec): Remove; unused.
8007 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8008 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8009 Rename or move locals to avoid shadowing.
8010
8011 * fns.c (require_nesting_list, require_unwind): Now static.
8012 (Ffillarray): Rename locals to avoid shadowing.
8013
8014 * floatfns.c (domain_error2): Define only if needed.
8015 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8016
8017 * alloc.c (mark_backtrace): Move decl from here ...
8018 * lisp.h: ... to here, so that it can be checked.
8019
8020 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8021 (Fdefvar): Rewrite so as not to use empty "else".
8022 (lisp_indirect_variable): Name an expression,
8023 to avoid gcc -Wbad-function-cast warning.
8024 (Fdefvar): Rename locals to avoid shadowing.
8025
8026 * callint.c (quotify_arg, quotify_args): Now static.
8027 (Fcall_interactively): Rename locals to avoid shadowing.
8028 Use const pointer when appropriate.
8029
8030 * lisp.h (get_system_name, get_operating_system_release):
8031 Move decls here, to check interfaces.
8032 * process.c (get_operating_system_release): Move decl to lisp.h.
8033 * xrdb.c (get_system_name): Likewise.
8034 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8035 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8036 some of which prompt warnings from gcc -Wbad-function-cast.
8037 (Fformat_time_string, Fencode_time, Finsert_char):
8038 (Ftranslate_region_internal, Fformat):
8039 Rename or remove local vars to avoid shadowing.
8040 (Ftranslate_region_internal): Mark var as initialized.
8041
8042 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8043 avoid shadowing.
8044
8045 * lisp.h (eassert): Check that the argument compiles, even if
8046 ENABLE_CHECKING is not defined.
8047
8048 * data.c (Findirect_variable): Name an expression, to avoid
8049 gcc -Wbad-function-cast warning.
8050 (default_value, arithcompare, arith_driver, arith_error): Now static.
8051 (store_symval_forwarding): Rename local to avoid shadowing.
8052 (Fmake_variable_buffer_local, Fmake_local_variable):
8053 Mark variables as initialized.
8054 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8055
8056 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8057 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8058 Rename locals to avoid shadowing.
8059 (mark_stack): Move local variables into the #ifdef region where
8060 they're used.
8061 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8062 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8063 needed otherwise.
8064 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8065 (GC_STRING_CHARS): Remove; not used.
8066 (Fmemory_limit): Cast sbrk's returned value to char *.
8067
8068 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8069 avoids undefined behavior in theory.
8070
8071 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8072
8073 Use functions, not macros, for up- and down-casing (Bug#8254).
8074 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8075 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8076 to use the following functions instead of these macros.
8077 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8078 EMACS_INT, since callers assume the returned value fits in int.
8079 (upcase1): Likewise, for UPCASE_TABLE.
8080 (uppercasep, lowercasep, upcase): New static inline functions.
8081 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8082 the race-condition problem in the old DOWNCASE.
8083
8084 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8085 Rename locals to avoid shadowing.
8086 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8087 (regex_compile, re_search_2, re_match_2_internal):
8088 Remove unused local vars.
8089 (FREE_VAR): Rewrite so as not to use empty "else",
8090 which gcc can warn about.
8091 (regex_compile, re_match_2_internal): Mark locals as initialized.
8092 (RETALLOC_IF): Define only if needed.
8093 (WORDCHAR_P): Likewise. This one is never needed, but is used
8094 only in a comment talking about a compiler bug, so put inside
8095 the #if 0 of that comment.
8096 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8097 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8098 Remove; unused.
8099
8100 * search.c (boyer_moore): Rename locals to avoid shadowing.
8101 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8102 (PREV_CHAR_BOUNDARY): Likewise.
8103
8104 * search.c (simple_search): Remove unused var.
8105
8106 * dired.c (compile_pattern): Move decl from here ...
8107 * lisp.h: ... to here, so that it can be checked.
8108 (struct re_registers): New forward decl.
8109
8110 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8111
8112 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8113 All uses changed.
8114 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8115 Rename locals to avoid shadowing.
8116 (Fvertical_motion): Mark locals as initialized.
8117
8118 * casefiddle.c (casify_object, casify_region): Now static.
8119 (casify_region): Mark local as initialized.
8120
8121 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8122
8123 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8124 New macros, so that the caller can use some names other than
8125 gcpro1, gcpro2, etc.
8126 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8127 of the new macros.
8128 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8129 argument, for consistency with GCPRO2_VAR, etc: it is now the
8130 prefix of the variable, not the variable itself. All uses
8131 changed.
8132 * dired.c (directory_files_internal, file_name_completion):
8133 Rename locals to avoid shadowing.
8134
8135 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8136 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8137 dired.c's scmp function, had undefined behavior.
8138 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8139 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8140 * buffer.h: ... to here, because these macros use current_buffer,
8141 and the new implementation with inline functions needs to have
8142 current_buffer in scope now, rather than later when the macros
8143 are used.
8144 (downcase, upcase1): New static inline functions.
8145 (DOWNCASE, UPCASE1): Reimplement using these functions.
8146 This avoids undefined behavior in expressions like
8147 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8148 from race conditions in accessing the global variables
8149 case_temp1 and case_temp2.
8150 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8151 * lisp.h (case_temp1, case_temp2): Remove their decls.
8152 * character.h (ASCII_CHAR_P): Move from here ...
8153 * lisp.h: ... to here, so that the inline functions mentioned
8154 above can use them.
8155
8156 * dired.c (directory_files_internal_unwind): Now static.
8157
8158 * fileio.c (file_name_as_directory, directory_file_name):
8159 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8160 Now static.
8161 (file_name_as_directory): Use const pointers when appropriate.
8162 (Fexpand_file_name): Likewise. In particular, newdir might
8163 point at constant storage, so make it a const pointer.
8164 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8165 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8166 signedness issues.
8167 (Fset_file_times, Finsert_file_contents, auto_save_error):
8168 Rename locals to avoid shadowing.
8169
8170 * minibuf.c (choose_minibuf_frame_1): Now static.
8171 (Ftry_completion, Fall_completions): Rename or remove locals
8172 to avoid shadowing.
8173
8174 * marker.c (bytepos_to_charpos): Remove; unused.
8175
8176 * lisp.h (verify_bytepos, count_markers): New decls,
8177 so that gcc does not warn that these functions aren't declared.
8178
8179 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8180 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8181 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8182 (copy_text): Remove unused local var.
8183
8184 * filelock.c (within_one_second): Now static.
8185 (lock_file_1): Rename local to avoid shadowing.
8186
8187 * buffer.c (fix_overlays_before): Mark locals as initialized.
8188 (fix_start_end_in_overlays): Likewise. This function should be
8189 simplified by using pointers-to-pointers, but that's a different
8190 matter.
8191 (switch_to_buffer_1): Now static.
8192 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8193 (report_overlay_modification): Rename locals to avoid shadowing.
8194
8195 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8196 Fix pointer signedness issue.
8197 (sys_subshell): Mark local as volatile if checking for lint,
8198 to suppress a gcc -Wclobbered warning that does not seem to be right.
8199 (MAXPATHLEN): Define only if needed.
8200
8201 * process.c (serial_open, serial_configure): Move decls from here ...
8202 * systty.h: ... to here, so that they can be checked.
8203
8204 * fns.c (get_random, seed_random): Move extern decls from here ...
8205 * lisp.h: ... to here, so that they can be checked.
8206
8207 * sysdep.c (reset_io): Now static.
8208 (wait_for_termination_signal): Remove; unused.
8209
8210 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8211 (copy_keymap_item, append_key, push_text_char_description):
8212 Now static.
8213 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8214 (DENSE_TABLE_SIZE): Remove; unused.
8215 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8216 (describe_map_tree):
8217 Rename locals to avoid shadowing.
8218
8219 * keyboard.c: Declare functions static if they are not used elsewhere.
8220 (echo_char, echo_dash, cmd_error, top_level_2):
8221 (poll_for_input, handle_async_input): Now static.
8222 (read_char, kbd_buffer_get_event, make_lispy_position):
8223 (make_lispy_event, make_lispy_movement, apply_modifiers):
8224 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8225 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8226 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8227 (read_key_sequence, read_char): Mark locals as initialized.
8228 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8229
8230 * keyboard.h (make_ctrl_char): New decl.
8231 (mark_kboards): Move decl here ...
8232 * alloc.c (mark_kboards): ... from here.
8233
8234 * lisp.h (force_auto_save_soon): New decl.
8235
8236 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8237 (DEFINE_DUMMY_FUNCTION): New macro.
8238 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8239 Use it.
8240 (main): Add casts to avoid warnings
8241 if GCC considers string literals to be constants.
8242
8243 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8244
8245 * dbusbind.c: Pointer signedness fixes.
8246 (xd_signature, xd_append_arg, xd_initialize):
8247 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8248 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8249 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8250 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8251
8252 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8253 if GCC considers string literals to be constants.
8254 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8255
8256 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8257
8258 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8259 (print_preprocess, print_object): New macro to fix last change.
8260
8261 * print.c (print_preprocess): Don't forget font objects.
8262
8263 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8264
8265 * emacs.c (USAGE3): Doc fixes.
8266
8267 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8268
8269 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8270 structure.
8271
8272 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8273
8274 * lisp.h (VWindow_system, Qfile_name_history):
8275 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8276 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8277 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8278
8279 * w32select.c: Don't #include "keyboard.h".
8280 (run_protected): Add extern declaration for waiting_for_input.
8281
8282 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8283 * w32console.c (detect_input_pending, read_input_pending)
8284 (encode_terminal_code):
8285 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8286 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8287 (w32_system_caret_y, Qfile_name_history):
8288 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8289 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8290 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8291 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8292 * w32proc.c (Qlocal, report_file_error):
8293 * w32term.c (Vwindow_system, updating_frame):
8294 * w32uniscribe.c (initialized, uniscribe_font_driver):
8295 Remove unneeded extern declarations.
8296
8297 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8298
8299 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8300
8301 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8302
8303 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8304 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8305 These macros can no longer be used for assignment.
8306
8307 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8308 Assign struct members directly, instead of using BUF_BEGV etc.
8309 (record_buffer_markers, fetch_buffer_markers): New functions for
8310 recording and fetching special buffer markers.
8311 (set_buffer_internal_1, set_buffer_temp): Use them.
8312
8313 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8314
8315 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8316
8317 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8318 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8319
8320 * xdisp.c (hscroll_window_tree):
8321 (reconsider_clip_changes): Use PT instead of BUF_PT.
8322
8323 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8324
8325 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8326 $(EMACS_ROOT)/lib/intprops.h.
8327
8328 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8329
8330 Fix more problems found by GCC 4.5.2's static checks.
8331
8332 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8333 to unsigned char * to avoid compiler diagnostic.
8334 (xg_free_frame_widgets): Make it clear that a local variable is
8335 needed only if USE_GTK_TOOLTIP.
8336 (gdk_window_get_screen): Make it clear that this macro is needed
8337 only if USE_GTK_TOOLTIP.
8338 (int_gtk_range_get_value): New function, which avoids a diagnostic
8339 from gcc -Wbad-function-cast.
8340 (xg_set_toolkit_scroll_bar_thumb): Use it.
8341 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8342 diagnostic from gcc -Wbad-function-cast.
8343 (get_utf8_string, xg_get_file_with_chooser):
8344 Rename locals to avoid shadowing.
8345 (create_dialog): Move locals to avoid shadowing.
8346
8347 * xgselect.c (xg_select): Remove unused var.
8348
8349 * image.c (four_corners_best): Mark locals as initialized.
8350 (gif_load): Initialize transparent_p to zero (Bug#8238).
8351 Mark another local as initialized.
8352 (my_png_error, my_error_exit): Mark with NO_RETURN.
8353
8354 * image.c (clear_image_cache): Now static.
8355 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8356 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8357 (x_edge_detection): Remove unnecessary cast that
8358 gcc -Wbad-function-cast diagnoses.
8359 (gif_load): Fix pointer signedness.
8360 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8361 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8362
8363 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8364
8365 Improve quality of tests for time stamp overflow.
8366 For example, without this patch (encode-time 0 0 0 1 1
8367 1152921504606846976) returns the obviously-bogus value (-948597
8368 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8369 reports time overflow. See
8370 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8371 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8372 * editfns.c: Include limits.h and intprops.h.
8373 (TIME_T_MIN, TIME_T_MAX): New macros.
8374 (time_overflow): Move earlier, to before first use.
8375 (hi_time, lo_time): New functions, for an accurate test for
8376 out-of-range times.
8377 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8378 (Fget_internal_run_time): Don't assume time_t fits in int.
8379 (make_time): Use list2 instead of Fcons twice.
8380 (Fdecode_time): More accurate test for out-of-range times.
8381 (check_tm_member): New function.
8382 (Fencode_time): Use it, to test for out-of-range times.
8383 (lisp_time_argument): Don't rely on undefined left-shift and
8384 right-shift behavior when checking for time stamp overflow.
8385
8386 * editfns.c (time_overflow): New function, refactoring common code.
8387 (Fformat_time_string, Fdecode_time, Fencode_time):
8388 (Fcurrent_time_string): Use it.
8389
8390 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8391 * dired.c (make_time): Move to ...
8392 * editfns.c (make_time): ... here.
8393 * systime.h: Note the move.
8394
8395 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8396
8397 * fringe.c (update_window_fringes): Remove unused variables.
8398
8399 * unexmacosx.c (copy_data_segment): Also copy __got section.
8400 (Bug#8223)
8401
8402 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8403
8404 * termcap.c [MSDOS]: Include "msdos.h".
8405 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8406 Constify `char *' arguments and their references according to
8407 prototypes in tparam.h.
8408
8409 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8410
8411 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8412 Adapt all references accordingly.
8413
8414 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8415
8416 2011-03-11 Tom Tromey <tromey@redhat.com>
8417
8418 * buffer.c (syms_of_buffer): Remove obsolete comment.
8419
8420 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8421
8422 * termhooks.h (encode_terminal_code): Declare prototype.
8423
8424 * msdos.c (encode_terminal_code): Don't declare prototype.
8425
8426 * term.c (encode_terminal_code): Now external again, used by
8427 w32console.c and msdos.c.
8428
8429 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8430 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8431
8432 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8433
8434 Fix some minor problems found by GCC 4.5.2's static checks.
8435
8436 * fringe.c (update_window_fringes): Mark locals as initialized
8437 (Bug#8227).
8438 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8439
8440 * alloc.c (mark_fringe_data): Move decl from here ...
8441 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8442 to check its interface.
8443 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8444
8445 * fontset.c (free_realized_fontset): Now static.
8446 (Fset_fontset_font): Rename local to avoid shadowing.
8447 (fontset_font): Mark local as initialized.
8448 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8449
8450 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8451
8452 * xselect.c (x_disown_buffer_selections): Remove; not used.
8453 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8454 (x_own_selection, Fx_disown_selection_internal): Rename locals
8455 to avoid shadowing.
8456 (x_handle_dnd_message): Remove local to avoid shadowing.
8457
8458 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8459 so that the caller can use some name other than gcpro1.
8460 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8461 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8462 (Fx_backspace_delete_keys_p):
8463 Use them to avoid shadowing, and rename vars to avoid shadowing.
8464 (x_decode_color, x_set_name, x_window): Now static.
8465 (Fx_create_frame): Add braces to silence GCC warning.
8466 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8467 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8468 Remove unused locals.
8469 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8470 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8471 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8472 macros.
8473
8474 * xterm.h (x_mouse_leave): New decl.
8475
8476 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8477 Remove unused functions.
8478 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8479 (x_calc_absolute_position): Now static.
8480 (XTread_socket): Don't define label "out" unless it's used.
8481 Don't declare local "event" unless it's used.
8482 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8483 unless they are used.
8484 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8485 (x_fatal_error_signal): Remove; not used.
8486 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8487 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8488 (x_error_catcher, x_connection_closed, x_error_handler):
8489 (x_error_quitter, xembed_send_message, x_iconify_frame):
8490 (my_log_handler): Rename locals to avoid shadowing.
8491 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8492 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8493
8494 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8495 Rename or move locals to avoid shadowing.
8496 (tty_defined_color, merge_face_heights): Now static.
8497 (free_realized_faces_for_fontset): Remove; not used.
8498 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8499 does not deduce is never used uninitialized.
8500 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8501 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8502
8503 * terminal.c (store_terminal_param): Now static.
8504
8505 * xmenu.c (menu_highlight_callback): Now static.
8506 (set_frame_menubar): Remove unused local.
8507 (xmenu_show): Rename parameter to avoid shadowing.
8508 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8509 since they might point to immutable storage.
8510 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8511 since it's unused otherwise.
8512
8513 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8514 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8515 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8516 avoids a gcc -Wuninitialized diagnostic.
8517 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8518 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8519 does not deduce are never used uninitialized.
8520
8521 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8522
8523 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8524 * window.c (window_loop, size_window):
8525 (run_window_configuration_change_hook, enlarge_window): Likewise.
8526
8527 * window.c (display_buffer): Now static.
8528 (size_window): Mark variables that gcc -Wuninitialized
8529 does not deduce are never used uninitialized.
8530 * window.h (check_all_windows): New decl, to forestall
8531 gcc -Wmissing-prototypes diagnostic.
8532 * dispextern.h (bidi_dump_cached_states): Likewise.
8533
8534 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8535 shadowing.
8536 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8537 Include <limits.h>.
8538 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8539 and to avoid gcc -Wuninitialized warning.
8540 (load_charset_map): Mark variables that gcc -Wuninitialized
8541 does not deduce are never used uninitialized.
8542 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8543
8544 * coding.c (coding_set_source, coding_set_destination):
8545 Use "else { /* comment */ }" rather than "else /* comment */;"
8546 for clarity, and to avoid gcc -Wempty-body warning.
8547 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8548 a block, when the outer 'i' will do.
8549 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8550 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8551 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8552 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8553 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8554 Rename locals to avoid shadowing.
8555 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8556 * coding.c (emacs_mule_char, encode_invocation_designation):
8557 Now static, since they're not used elsewhere.
8558 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8559 (decode_coding_object, encode_coding_object, detect_coding_system):
8560 (decode_coding_emacs_mule): Mark variables that gcc
8561 -Wuninitialized does not deduce are never used uninitialized.
8562 (detect_coding_iso_2022): Initialize a local variable that might
8563 be used uninitialized. Leave a FIXME because it's not clear that
8564 this initialization is needed. (Bug#8211)
8565 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8566 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8567 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8568 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8569 Remove unused macros.
8570
8571 * category.c (hash_get_category_set): Remove unused local var.
8572 (copy_category_table): Now static, since it's not used elsewhere.
8573 * character.c (string_count_byte8): Likewise.
8574
8575 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8576 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8577
8578 * chartab.c (copy_sub_char_table): Now static, since it's not used
8579 elsewhere.
8580 (sub_char_table_ref_and_range, char_table_ref_and_range):
8581 Rename locals to avoid shadowing.
8582 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8583
8584 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8585 (BIDI_BOB): Remove unused macro.
8586
8587 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8588 deduce are never used uninitialized.
8589 * term.c (encode_terminal_code): Likewise.
8590
8591 * term.c (encode_terminal_code): Now static. Remove unused local.
8592
8593 * tparam.h: New file.
8594 * term.c, tparam.h: Include it.
8595 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8596 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8597 Move these decls to tparam.h, and make them agree with what
8598 is actually in tparam.c. The previous trick of using incompatible
8599 decls in different modules does not conform to the C standard.
8600 All callers of tparam changed to use tparam's actual API.
8601 * tparam.c (tparam1, tparam, tgoto):
8602 Use const pointers where appropriate.
8603
8604 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8605 * cm.h (struct cm): Likewise.
8606 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8607 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8608 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8609 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8610 (turn_on_face, init_tty): Likewise.
8611 * termchar.h (struct tty_display_info): Likewise.
8612
8613 * term.c (term_mouse_position): Rename local to avoid shadowing.
8614
8615 * alloc.c (mark_ttys): Move decl from here ...
8616 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8617
8618 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8619
8620 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8621
8622 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8623
8624 * search.c (compile_pattern_1): Remove argument regp, unused since
8625 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8626 (compile_pattern): Don't pass it.
8627
8628 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8629
8630 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8631 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8632 for ! HAVE_GTK3.
8633 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8634
8635 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8636
8637 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8638 gdk_window_get_screen, gdk_window_get_geometry,
8639 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8640 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8641 (xg_get_pixbuf_from_pixmap): New function.
8642 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8643 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8644 Call xg_get_pixbuf_from_pixmap instead of
8645 gdk_pixbuf_get_from_drawable.
8646 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8647 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8648 (xg_check_special_colors): Use GtkStyleContext and its functions
8649 for HAVE_GTK3.
8650 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8651 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8652 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8653 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8654 Call gtk_widget_get_preferred_size.
8655 (xg_frame_resized): gdk_window_get_geometry only takes 5
8656 parameters.
8657 (xg_win_to_widget, xg_event_is_for_menubar):
8658 Call gdk_x11_window_lookup_for_display.
8659 (xg_set_widget_bg): New function.
8660 (delete_cb): New function.
8661 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8662 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8663 (xg_set_background_color): Call xg_set_widget_bg.
8664 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8665 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8666 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8667 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8668 if ! HAVE_GTK3.
8669 (update_frame_tool_bar): Call gtk_widget_hide.
8670 (xg_initialize): Use GDK_KEY_g.
8671
8672 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8673 if ! HAVE_GTK3
8674 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8675
8676 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8677 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8678 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8679
8680 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8681
8682 * w32xfns.c (select_palette): Check success of RealizePalette against
8683 GDI_ERROR, not zero.
8684
8685 See ChangeLog.11 for earlier changes.
8686
8687 ;; Local Variables:
8688 ;; coding: utf-8
8689 ;; End:
8690
8691 Copyright (C) 2011 Free Software Foundation, Inc.
8692
8693 This file is part of GNU Emacs.
8694
8695 GNU Emacs is free software: you can redistribute it and/or modify
8696 it under the terms of the GNU General Public License as published by
8697 the Free Software Foundation, either version 3 of the License, or
8698 (at your option) any later version.
8699
8700 GNU Emacs is distributed in the hope that it will be useful,
8701 but WITHOUT ANY WARRANTY; without even the implied warranty of
8702 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8703 GNU General Public License for more details.
8704
8705 You should have received a copy of the GNU General Public License
8706 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.