1 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4 Only r_alloc_inhibit_buffer_relocation needed to be added;
5 the others were already declared.
7 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
8 before checking whether it's out of range. Put the check inside
10 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
12 2012-05-27 Ken Brown <kbrown@cornell.edu>
14 * callproc.c (Fcall_process): Restore a line that was accidentally
15 commented out in the 2011-02-13 change (bug#11547).
17 2012-05-27 Eli Zaretskii <eliz@gnu.org>
19 * lisp.h [REL_ALLOC]: Add prototypes for external functions
22 * buffer.c [REL_ALLOC]: Remove prototypes of
23 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
24 they are now on lisp.h.
26 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
28 * search.c (search_buffer): Use it to inhibit relocation of buffer
29 text while re_search_2 is doing its job, because re_search_2 is
30 passed C pointers to buffer text. (Bug#11519)
32 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
35 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
36 state after an additional call to move_it_in_display_line_to, keep
37 the values of it->max_ascent and it->max_descent found for the
39 (pos_visible_p): Revert the comparison against bottom_y to what it
40 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
43 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
45 Fix coding-related core dumps with gcc -ftrapv.
46 The code was computing A - B, where A and B are pointers, and B is
47 random garbage. This can lead to core dumps on platforms that
48 have special pointer registers, and it also leads to core dumps on
49 x86-64 when compiled with gcc -ftrapv. The fix is to compute
50 A - B only when B is initialized properly.
51 * coding.c (coding_set_source, coding_set_destination): Return void.
52 (coding_change_source, coding_change_destinations): New functions,
53 with the old behaviors of coding_set_source and coding_set_destination.
54 All callers that need an offset changed to use these new functions.
56 2012-05-26 Glenn Morris <rgm@gnu.org>
58 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
60 2012-05-26 Eli Zaretskii <eliz@gnu.org>
62 Extend mouse support on W32 text-mode console.
63 * xdisp.c (draw_row_with_mouse_face): Call
64 tty_draw_row_with_mouse_face for WINDOWSNT as well.
66 * w32console.c: Include window.h.
67 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
69 (initialize_w32_display): Initialize mouse-highlight data.
71 * w32inevt.c: Include termchar.h and window.h.
72 (do_mouse_event): Support mouse-autoselect-window. When the mouse
73 moves, call note_mouse_highlight. If help_echo changed, call
74 gen_help_event to produce help-echo message in the echo area.
75 Call clear_mouse_face if mouse_face_hidden is set in the mouse
78 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
80 * lread.c (read1): Simplify slightly to avoid an overflow warning
81 with GCC 4.7.0 on x86-64.
83 2012-05-26 Eli Zaretskii <eliz@gnu.org>
85 * bidi.c (bidi_mirror_char): Revert last change: an int is
86 definitely wide enough here.
88 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
90 Fix integer width and related bugs (Bug#9874).
91 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
92 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
93 (string_bytes, check_sblock, allocate_string_data):
94 (compact_small_strings, Fmake_bool_vector, make_string)
95 (make_unibyte_string, make_multibyte_string)
96 (make_string_from_bytes, make_specified_string)
97 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
98 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
101 (allocate_pseudovector):
102 Use int, not EMACS_INT, where int is wide enough.
103 (inhibit_garbage_collection, Fgarbage_collect):
104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
105 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
106 int might not be wide enough.
107 (bidi_cache_search, bidi_cache_find, bidi_init_it)
108 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
109 (bidi_at_paragraph_end, bidi_find_paragraph_start)
110 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
111 (bidi_level_of_next_char, bidi_move_to_visually_next):
112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
113 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
114 (Fkill_buffer, Fset_buffer_major_mode)
115 (advance_to_char_boundary, Fbuffer_swap_text)
116 (Fset_buffer_multibyte, overlays_at, overlays_in)
117 (overlay_touches_p, struct sortvec, record_overlay_string)
118 (overlay_strings, recenter_overlay_lists)
119 (adjust_overlays_for_insert, adjust_overlays_for_delete)
120 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
121 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
122 (Foverlay_recenter, last_overlay_modification_hooks_used)
123 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
125 (validate_region): Omit unnecessary test for b <= e,
126 since that's guaranteed by the previous test.
127 (adjust_overlays_for_delete): Avoid pos + length overflow.
128 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
129 (report_overlay_modification):
130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
131 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
132 Omit pointer cast, which isn't needed anyway, and doesn't work
133 after the EMACS_INT -> ptrdiff_t change.
134 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
135 * buffer.h: Adjust decls to match defn changes elsewhere.
136 (struct buffer_text, struct buffer):
137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
138 Use EMACS_INT, not int, where int might not be wide enough.
139 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
140 not int, to avoid needless 32-bit limit on 64-bit hosts.
141 (exec_byte_code): Use tighter memory-full test, one that checks
142 for alloca overflow. Don't compute the address of the object just
143 before an array, as that's not portable. Use EMACS_INT, not
144 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
145 * callint.c (Fcall_interactively):
146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
147 * callproc.c (call_process_kill, Fcall_process):
148 Don't assume pid_t fits into an Emacs fixnum.
149 (call_process_cleanup, Fcall_process, child_setup):
150 Don't assume pid_t fits into int.
151 (call_process_cleanup, Fcall_process, delete_temp_file)
152 (Fcall_process_region):
153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
154 (Fcall_process): Simplify handling of volatile integers.
155 Use int, not EMACS_INT, where int will do.
156 * casefiddle.c (casify_object, casify_region, operate_on_word)
157 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
159 (casify_object): Avoid integer overflow when overallocating buffer.
160 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
161 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
162 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
163 * category.h (CATEGORYP): Don't assume arg is nonnegative.
164 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
165 integers are now checked earlier. All uses replaced with XINT.
167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
168 For CCL_MapSingle, check that content and value are in int range.
169 (ccl_driver, Fregister_code_conversion_map):
170 Check that Vcode_version_map_vector is a vector.
171 (resolve_symbol_ccl_program): Check that vector header is in range.
172 Always copy the vector, so that we can check its contents reliably
173 now rather than having to recheck each instruction as it's being
174 executed. Check that vector words fit in 'int'.
175 (ccl_get_compiled_code, Fregister_ccl_program)
176 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
177 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
178 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
179 contents are in range.
180 (Fccl_execute_on_string): Check that status is in range.
181 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
182 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
183 Accept and return EMACS_INT, not int, because callers can pass values
185 (c_string_width, strwidth, lisp_string_width, chars_in_text)
186 (multibyte_chars_in_text, parse_str_as_multibyte)
187 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
188 (str_as_unibyte, str_to_unibyte, string_count_byte8)
189 (string_escape_byte8, Fget_byte):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
192 avoid mishandling large integers.
193 * character.h: Adjust decls to match defn changes elsewhere.
194 * charset.c (load_charset_map_from_file, find_charsets_in_text)
195 (Ffind_charset_region):
196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
197 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
198 (load_charset_map_from_vector, Fdefine_charset_internal):
199 Don't assume fixnum fits in int.
200 (load_charset_map_from_vector, Fmap_charset_chars):
201 Remove now-unnecessary CHECK_NATNUMs.
202 (Fdefine_charset_internal): Check ranges here, more carefully.
203 Don't rely on undefined behavior with signed left shift overflow.
204 Don't assume unsigned int fits into fixnum, or that fixnum fits
205 into unsigned int. Don't require max_code to be a valid fixnum;
206 that's not true for gb10830 4-byte on a 32-bit host. Allow
207 invalid_code to be a cons, for the same reason. Require code_offset
208 to be a character. Avoid int overflow if max_char is close
210 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
211 this is intended anyway and avoids some undefined behavior.
212 (load_charset_map): Pass unsigned, not int, as 2nd arg of
213 INDEX_TO_CODE_POINT, as that's what it expects.
214 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
215 * charset.h (DECODE_CHAR): Return int, not unsigned;
216 this is what was intended anyway, and it avoids undefined behavior.
217 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
218 integer-overflow issues.
219 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
220 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
221 where the argument is EMACS_INT, and this behavior is not intended.
222 * chartab.c (Fmake_char_table, Fset_char_table_range)
223 (uniprop_get_decoder, uniprop_get_encoder):
224 Don't assume fixnum fits in int.
225 * cmds.c (move_point): New function, that does the gist of
226 Fforward_char and Fbackward_char, but does so while checking
227 for integer overflow more accurately.
228 (Fforward_char, Fbackward_char): Use it.
229 (Fforward_line, Fend_of_line, internal_self_insert)
230 (internal_self_insert):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 Fix a FIXME, by checking for integer overflow when calculating
233 target_clm and actual_clm.
234 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
235 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
236 (ASSURE_DESTINATION, coding_alloc_by_realloc)
237 (coding_alloc_by_making_gap, alloc_destination)
238 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
239 (encode_coding_utf_16, detect_coding_emacs_mule)
240 (decode_coding_emacs_mule, encode_coding_emacs_mule)
241 (detect_coding_iso_2022, decode_coding_iso_2022)
242 (encode_invocation_designation, encode_designation_at_bol)
243 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
244 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
245 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
246 (encode_coding_ccl, encode_coding_raw_text)
247 (detect_coding_charset, decode_coding_charset)
248 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
249 (produce_composition, produce_charset, produce_annotation)
250 (decode_coding, handle_composition_annotation)
251 (handle_charset_annotation, consume_chars, decode_coding_gap)
252 (decode_coding_object, encode_coding_object, detect_coding_system)
253 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
254 (code_convert_region, code_convert_string)
255 (Fdefine_coding_system_internal)
256 (coding_set_source, coding_set_destination):
257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
258 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
259 (Fdefine_coding_system_internal):
260 Don't assume fixnums fit in int.
261 (decode_coding_gap, decode_coding_object, encode_coding_object)
262 (Fread_coding_system, Fdetect_coding_region)
263 (Funencodable_char_position, Fcheck_coding_systems_region)
264 (get_translation, handle_composition_annotation, consume_chars):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 (consume_chars): Rewrite to not calculate an address outside buffer.
267 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
268 Don't access memory outside of the args array.
269 (Fdefine_coding_system_internal): Check for charset-id overflow.
270 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
271 result of ENCODE_CHAR.
272 * coding.h: Adjust decls to match defn changes elsewhere.
273 (struct coding_system):
274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
275 * composite.c (get_composition_id, find_composition)
276 (run_composition_function, update_compositions)
277 (compose_text, composition_gstring_put_cache)
278 (composition_gstring_p, composition_gstring_width)
279 (fill_gstring_header, fill_gstring_body, autocmp_chars)
280 (composition_compute_stop_pos, composition_reseat_it)
281 (composition_update_it, struct position_record)
282 (find_automatic_composition, composition_adjust_point)
283 (Fcomposition_get_gstring, Ffind_composition_internal):
284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
285 (update_compositions):
286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
287 * composite.h: Adjust decls to match defn changes elsewhere.
288 (struct composition):
289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
290 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
291 Do not attempt to compute the address of the object just before a
292 buffer; this is not portable.
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 (Faset): Use int, not EMACS_INT, where int is wide enough.
296 (Fstring_to_number): Don't assume fixnums fit in int.
297 (Frem): Don't assume arg is nonnegative.
298 * dbusbind.c (xd_append_arg): Check for integers out of range.
299 (Fdbus_call_method): Don't overflow the timeout int.
300 (extract_signed, extract_unsigned): New functions.
301 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
302 (xd_get_connection_references): Return ptrdiff_t, not int.
304 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
306 Use int, not unsigned, where the dbus API uses int.
307 (Fdbus_message_internal): Don't overflow mtype.
308 (syms_of_dbusbind): Allocate right-sized buffer for integers.
309 * dired.c (directory_files_internal, file_name_completion, scmp)
310 (file_name_completion_stat):
311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
312 (file_name_completion): Don't overflow matchcount.
313 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
314 * dispextern.h: Adjust decls to match defn changes elsewhere.
315 (struct text_pos, struct glyph, struct bidi_saved_info)
316 (struct bidi_string_data, struct bidi_it, struct composition_it)
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 (struct display_pos, struct composition_it, struct it):
320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
321 * dispnew.c (increment_matrix_positions)
322 (increment_row_positions, mode_line_string)
323 (marginal_area_string):
324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
325 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
327 (duration_to_sec_usec): New function, to check for overflow better.
328 (Fsleep_for, sit_for): Use it.
329 * doc.c (get_doc_string, store_function_docstring):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 (get_doc_string, Fsnarf_documentation):
332 Use int, not EMACS_INT, where int is wide enough.
334 Use SAFE_ALLOCA, not alloca.
335 Check for overflow when converting EMACS_INT to off_t.
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
339 Don't assume uid_t fits into fixnum.
340 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
341 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
342 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
343 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
344 (general_insert_function)
345 (Finsert_char, make_buffer_string, make_buffer_string_both)
346 (update_buffer_properties, Fbuffer_substring)
347 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
348 (Fsubst_char_in_region, check_translation)
349 (Ftranslate_region_internal, save_restriction_restore, Fformat)
350 (transpose_markers, Ftranspose_regions):
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 (clip_to_bounds): Move to lisp.h as an inline function).
353 (Fconstrain_to_field): Don't assume integers are nonnegative.
354 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
355 (Fsubst_char_in_region, Fsave_restriction):
356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
357 (Femacs_pid): Don't assume pid_t fits into fixnum.
358 (lo_time): Use int, not EMACS_INT, when int suffices.
359 (lisp_time_argument): Check for usec out of range.
360 (Fencode_time): Don't assume fixnum fits in int.
361 (Fuser_login_name, Fuser_full_name): Signal an error
362 if a uid argument is out of range, rather than relying on
364 (Fformat_time_string): Remove now-unnecessary check.
365 lisp_time_argument checks for out-of-range usec now.
366 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
367 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
368 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
369 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
370 (init_cmdargs, Fdump_emacs):
371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
372 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
373 the bottom (typically) 32 bits of the fixnum.
374 * eval.c (specpdl_size, call_debugger):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (when_entered_debugger, Fbacktrace_debug):
377 Don't assume fixnum can fit in int.
378 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
379 the object just before a buffer; this is not portable.
380 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
381 (grow_specpdl, unbind_to):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
384 (grow_specpdl): Simplify allocation by using xpalloc.
385 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
386 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
387 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
389 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
392 (Fcopy_file, non_regular_nbytes, read_non_regular)
393 (Finsert_file_contents):
394 Use int, not EMACS_INT, where int is wide enough.
395 (READ_BUF_SIZE): Verify that it fits in int.
396 (Finsert_file_contents): Check that counts are in proper range,
397 rather than assuming fixnums fit into ptrdiff_t etc.
398 Don't assume fixnums fit into int.
399 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
400 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
401 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
402 (string_char_to_byte, string_byte_to_char)
403 (string_make_multibyte, string_to_multibyte)
404 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
405 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
406 (substring_both, Fdelete, internal_equal, Ffillarray)
407 (Fclear_string, mapcar1)
408 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
409 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
410 (larger_vector, make_hash_table, maybe_resize_hash_table)
411 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
412 (Fmaphash, secure_hash):
413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
414 (concat): Check for string index and length overflow.
415 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
418 (larger_vector): New API (vec, incr_min, size_max) replaces old
419 one (vec, new_size, init). This catches size overflow.
420 INIT was removed because it was always Qnil.
422 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
423 the upper bound on a hash table index size.
424 (make_hash_table, maybe_resize_hash_table): Use it.
425 (secure_hash): Computer start_byte and end_byte only after
426 they're known to be in ptrdiff_t range.
427 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
428 (Ffont_get_glyphs, Ffont_at):
429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
430 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
431 (Flist_fonts, Fopen_font):
432 Don't assume fixnum can fit in int.
433 (check_gstring): Don't assume index can fit in int.
434 (font_match_p): Check that fixnum is a character, not a nonnegative
435 fixnum, since the later code needs to stuff it into an int.
436 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
437 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
438 conversion overflow issues.
439 (Fopen_font): Check for integer out of range.
440 (Ffont_get_glyphs): Don't assume index can fit in int.
441 * font.h: Adjust decls to match defn changes elsewhere.
442 * fontset.c (reorder_font_vector): Redo score calculation to avoid
444 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
445 printmax_t, where ptrdiff_t is wide enough.
446 (Finternal_char_font):
447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
448 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
449 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
450 (Fset_frame_position, x_set_frame_parameters)
451 (x_set_line_spacing, x_set_border_width)
452 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
453 Check that fixnums are in proper range for system types.
454 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
456 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
457 Use SAFE_ALLOCA_LISP, not alloca.
458 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
459 intptr_t is wide enough.
460 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
461 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
462 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
463 Check for fixnum out of range.
464 * ftfont.c (ftfont_list): Don't assume index fits in int.
465 Check that fixnums are in proper range for system types.
466 (ftfont_shape_by_flt):
467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
468 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
470 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
471 Check that fixnums are in proper range for system types.
472 * gnutls.h: Adjust decls to match defn changes elsewhere.
473 * gtkutil.c (xg_dialog_run):
474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
475 (update_frame_tool_bar):
476 Check that fixnums are in proper range for system types.
477 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
478 (lookup_image): Check that fixnums are in range for system types.
479 * indent.c (last_known_column, last_known_column_point):
480 (current_column_bol_cache):
481 (skip_invisible, current_column, check_display_width):
482 (check_display_width, scan_for_column, current_column_1)
483 (Findent_to, Fcurrent_indentation, position_indentation)
484 (indented_beyond_p, Fmove_to_column, compute_motion):
485 (Fcompute_motion, Fvertical_motion):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (last_known_column_modified): Use EMACS_INT, not int.
488 (check_display_width):
490 Check that fixnums and floats are in proper range for system types.
491 (compute_motion): Don't assume index or fixnum fits in int.
492 (compute_motion, Fcompute_motion):
493 Use int, not EMACS_INT, when it is wide enough.
494 (vmotion): Omit local var start_hpos that is always 0; that way
495 we don't need to worry about overflow in expressions involving it.
496 * indent.h: Adjust decls to match defn changes elsewhere.
498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
499 Use int, not EMACS_INT, where int is wide enough.
500 Remove unused members ovstring_chars_done and tab_offset;
502 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
503 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
504 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
505 (make_gap, copy_text, insert, insert_and_inherit)
506 (insert_before_markers, insert_before_markers_and_inherit)
507 (insert_1, count_combining_before, count_combining_after)
508 (insert_1_both, insert_from_string)
509 (insert_from_string_before_markers, insert_from_string_1)
510 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
511 (adjust_after_replace, adjust_after_insert, replace_range)
512 (replace_range_2, del_range, del_range_1, del_range_byte)
513 (del_range_both, del_range_2, modify_region)
514 (prepare_to_modify_buffer, signal_before_change)
515 (signal_after_change, Fcombine_after_change_execute):
516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
517 * intervals.c (traverse_intervals, rotate_right, rotate_left)
518 (balance_an_interval, split_interval_right, split_interval_left)
519 (find_interval, next_interval, update_interval)
520 (adjust_intervals_for_insertion, delete_node, delete_interval)
521 (interval_deletion_adjustment, adjust_intervals_for_deletion)
522 (static_offset_intervals, offset_intervals)
523 (merge_interval_right, merge_interval_left, make_new_interval)
524 (graft_intervals_into_buffer, temp_set_point_both)
525 (temp_set_point, set_point, adjust_for_invis_intang)
526 (set_point_both, move_if_not_intangible, get_property_and_range)
527 (get_local_map, copy_intervals, copy_intervals_to_string)
528 (compare_string_intervals, set_intervals_multibyte_1):
529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
530 * intervals.h: Adjust decls to match defn changes elsewhere.
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 * keyboard.c (this_command_key_count, this_single_command_key_start)
534 (before_command_key_count, before_command_echo_length, echo_now)
535 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
536 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
537 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
538 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 (last_non_minibuf_size, last_point_position, echo_truncate)
541 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
542 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
543 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
544 (stuff_buffered_input):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (last_auto_save, command_loop_1, read_char):
547 Use EMACS_INT, not int, to avoid integer overflow.
548 (record_char): Avoid overflow in total_keys computation.
549 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
550 * keyboard.h: Adjust decls to match defn changes elsewhere.
551 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
552 (Fkey_description, Fdescribe_vector, Flookup_key):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (click_position): New function, to check that positions are in range.
555 (Fcurrent_active_maps):
557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
558 (Faccessible_keymaps, Fkey_description):
559 (preferred_sequence_p):
560 Don't assume fixnum can fit into int.
561 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
562 Check for integer overflow in size calculations.
563 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
564 avoid mishandling large integers.
565 * lisp.h: Adjust decls to match defn changes elsewhere.
566 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
567 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
568 (struct Lisp_Marker):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (clip_to_bounds): Now an inline function, moved here from editfns.c.
571 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
572 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
574 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
575 Assume the arg has valid form, since it always does.
576 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
577 unsigned integer system type.
578 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
579 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
582 (duration_to_sec_usec): New decl.
583 * lread.c (read_from_string_index, read_from_string_index_byte)
584 (read_from_string_limit, readchar, unreadchar, openp)
585 (read_internal_start, read1, oblookup):
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
587 (Fload, readevalloop, Feval_buffer, Feval_region):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (openp): Check for out-of-range argument to 'access'.
590 (read1): Use int, not EMACS_INT, where int is wide enough.
591 Don't assume fixnum fits into int.
592 Fix off-by-one error that can read outside a buffer.
593 (read_filtered_event): Use duration_to_sec_usec
594 to do proper overflow checking on durations.
595 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
597 (Fexecute_kbd_macro):
598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
599 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
600 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
601 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
602 (set_marker_both, set_marker_restricted_both, marker_position)
603 (marker_byte_position, Fbuffer_has_markers_at):
604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
605 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
606 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
607 It now merely ensures that the menu is large enough, without
608 necessarily growing it, as this avoids some integer overflow issues.
610 (keymap_panes, parse_single_submenu, Fx_popup_menu):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
613 Use SAFE_ALLOCA_LISP, not alloca.
614 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
615 to EMACS_INT. Check that fixnums are in proper range for system types.
616 * minibuf.c (minibuf_prompt_width, string_to_object)
617 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
618 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
620 (get_minibuffer, read_minibuf_unwind):
621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
622 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
623 this simplifies overflow checking. All callers changed.
624 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
627 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
628 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
629 Check that fixnums are in proper range for system types.
630 (Fx_create_frame, Fx_show_tip):
631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
632 * nsfont.m (ns_findfonts, nsfont_list_family):
633 Don't assume fixnum fits in long.
634 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
638 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
640 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
641 (PRINTDECLARE, PRINTPREPARE):
642 (strout, print_string):
643 (print, print_preprocess, print_check_string_charset_prop)
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
647 (temp_output_buffer_setup, Fprin1_to_string, print_object):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
649 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
650 (printchar, strout): Use xpalloc to catch size calculation overflow.
651 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
652 (print_error_message): Use SAFE_ALLOCA, not alloca.
653 (print_object): Use int, not EMACS_INT, where int is wide enough.
654 (print_depth, new_backquote_output, print_number_index):
655 Use ptrdiff_t, not int, where int might not be wide enough.
656 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
657 (Fset_process_window_size, Fformat_network_address)
658 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
660 Check that fixnums are in proper range for system types.
661 (Fsignal_process): Simplify by avoiding a goto.
662 Check for process-ids out of pid_t range rather than relying on
664 (process_tick, update_tick): Use EMACS_INT, not int.
665 (Fformat_network_address, read_process_output, send_process)
666 (Fprocess_send_region, status_notify):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
669 (wait_reading_process_output, read_process_output, exec_sentinel):
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
672 (Faccept_process_output): Use duration_to_sec_usec to do proper
673 overflow checking on durations.
674 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
675 Don't assume pid_t fits in int.
676 * process.h (struct Lisp_Process): Members tick and update_tick
677 are now of type EMACS_INT, not int.
678 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
679 configured --with-wide-int.
680 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
681 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
682 * search.c (looking_at_1, string_match_1):
683 (fast_string_match, fast_c_string_match_ignore_case)
684 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
685 (scan_newline, find_before_next_newline, search_command)
686 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
687 (set_search_regs, wordify):
690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
691 (string_match_1, search_buffer, set_search_regs):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 (wordify): Check for overflow in size calculation.
695 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
696 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
697 Check that fixnums are in proper range for system types.
698 * sound.c (struct sound_device)
699 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 (Fplay_sound_internal):
702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
703 * syntax.c (struct lisp_parse_state, find_start_modiff)
704 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
705 (Fparse_partial_sexp):
706 Don't assume fixnums can fit in int.
707 (struct lisp_parse_state, find_start_pos, find_start_value)
708 (find_start_value_byte, find_start_begv)
709 (update_syntax_table, char_quoted, dec_bytepos)
710 (find_defun_start, prev_char_comend_first, back_comment):
711 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
712 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (Finternal_describe_syntax_value): Check that match_lisp is a
715 character, not an integer, since the code stuffs it into int.
716 (scan_words, scan_sexps_forward):
717 Check that fixnums are in proper range for system types.
719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
720 (scan_sexps_forward):
721 Use CHARACTERP, not INTEGERP, since the value must fit into int.
722 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
723 * syntax.h: Adjust decls to match defn changes elsewhere.
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
727 MOST_POSITIVE_FIXNUM.
728 * sysdep.c (wait_for_termination_1, wait_for_termination)
729 (interruptible_wait_for_termination, mkdir):
730 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
731 (emacs_read, emacs_write):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
734 and double all fit in int.
735 * term.c (set_tty_color_mode):
736 Check that fixnums are in proper range for system types.
737 * termhooks.h (struct input_event):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 * textprop.c (validate_interval_range, interval_of)
740 (Fadd_text_properties, set_text_properties_1)
741 (Fremove_text_properties, Fremove_list_of_text_properties)
742 (Ftext_property_any, Ftext_property_not_all)
743 (copy_text_properties, text_property_list, extend_property_ranges)
744 (verify_interval_modification):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
746 (Fnext_single_char_property_change)
747 (Fprevious_single_char_property_change):
748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
749 (copy_text_properties):
750 Check for integer overflow in index calculation.
751 * undo.c (last_boundary_position, record_point, record_insert)
752 (record_delete, record_marker_adjustment, record_change)
753 (record_property_change):
754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
755 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
757 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
758 (Fx_hide_tip, Fx_file_dialog):
759 * w32menu.c (set_frame_menubar):
760 Use ptrdiff_t, not int, for consistency with rest of code.
761 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
762 (select_window, Fdelete_other_windows_internal)
763 (window_scroll_pixel_based, window_scroll_line_based)
764 (Frecenter, Fset_window_configuration):
765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
766 (Fset_window_hscroll, run_window_configuration_change_hook)
767 (set_window_buffer, temp_output_buffer_show, scroll_command)
768 (Fscroll_other_window, Frecenter):
769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
770 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
771 Don't assume fixnum fits in int.
772 (Fset_window_scroll_bars):
773 Check that fixnums are in proper range for system types.
774 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
775 (string_pos, c_string_pos, number_of_chars, init_iterator)
776 (in_ellipses_for_invisible_text_p, init_from_display_pos)
777 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
778 (compute_display_string_end, handle_face_prop)
779 (face_before_or_after_it_pos, handle_invisible_prop)
780 (handle_display_prop, handle_display_spec, handle_single_display_spec)
781 (display_prop_intangible_p, string_buffer_position_lim)
782 (string_buffer_position, handle_composition_prop, load_overlay_strings)
783 (get_overlay_strings_1, get_overlay_strings)
784 (iterate_out_of_display_property, forward_to_next_line_start)
785 (back_to_previous_visible_line_start, reseat, reseat_to_string)
786 (get_next_display_element, set_iterator_to_next)
787 (get_visually_first_element, compute_stop_pos_backwards)
788 (handle_stop_backwards, next_element_from_buffer)
789 (move_it_in_display_line_to, move_it_in_display_line)
790 (move_it_to, move_it_vertically_backward, move_it_by_lines)
791 (add_to_log, message_dolog, message_log_check_duplicate)
792 (message2, message2_nolog, message3, message3_nolog
793 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
794 (current_message_1, truncate_echo_area, truncate_message_1)
795 (set_message, set_message_1, store_mode_line_noprop)
796 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
797 (text_outside_line_unchanged_p, check_point_in_composition)
798 (reconsider_clip_changes)
799 (redisplay_internal, set_cursor_from_row, try_scrolling)
800 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
801 (redisplay_window, find_last_unchanged_at_beg_row)
802 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
803 (trailing_whitespace_p, find_row_edges, display_line)
804 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
805 (display_mode_element, store_mode_line_string)
806 (pint2str, pint2hrstr, decode_mode_spec)
807 (display_count_lines, display_string, draw_glyphs)
808 (x_produce_glyphs, x_insert_glyphs)
809 (rows_from_pos_range, mouse_face_from_buffer_pos)
810 (fast_find_string_pos, mouse_face_from_string_pos)
811 (note_mode_line_or_margin_highlight, note_mouse_highlight):
812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
813 (safe_call, init_from_display_pos, handle_fontified_prop)
814 (handle_single_display_spec, load_overlay_strings)
815 (with_echo_area_buffer, setup_echo_area_for_printing)
816 (display_echo_area, echo_area_display)
817 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
818 (update_tool_bar, hscroll_window_tree, redisplay_internal)
819 (redisplay_window, dump_glyph_row, display_mode_line)
820 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
821 (handle_display_spec, display_prop_string_p):
822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
823 (handle_single_display_spec, build_desired_tool_bar_string)
824 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
825 (get_specified_cursor_type):
826 Check that fixnums are in proper range for system types.
827 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
829 Don't assume fixnums fit in int.
830 (compare_overlay_entries):
831 Avoid mishandling comparisons due to subtraction overflow.
832 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
833 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
834 (handle_tool_bar_click):
835 Use int, not unsigned, since we prefer signed and the signedness
837 (get_next_display_element, next_element_from_display_vector):
838 Use int, not EMACS_INT, when int is wide enough.
839 (start_hourglass): Use duration_to_sec_usec to do proper
840 overflow checking on durations.
841 * xfaces.c (Fbitmap_spec_p):
842 Check that fixnums are in proper range for system types.
843 (compare_fonts_by_sort_order):
844 Avoid mishandling comparisons due to subtraction overflow.
845 (Fx_family_fonts, realize_basic_faces):
846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
848 Don't assume fixnum fits in int.
849 Use SAFE_ALLOCA_LISP, not alloca.
850 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
851 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
852 (face_at_buffer_position, face_for_overlay_string)
853 (face_at_string_position):
854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
855 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
856 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
858 Check that fixnums are in proper range for system types.
859 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
860 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
862 (Fx_change_window_property): Don't assume fixnums fit in int.
863 * xfont.c (xfont_chars_supported):
864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
865 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
866 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
868 * xml.c (parse_region):
869 * xrdb.c (magic_file_p):
870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
871 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
872 (x_get_local_selection, x_reply_selection_request)
873 (x_handle_selection_request, wait_for_property_change):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
876 short is wide enough.
877 (x_send_client_event): Don't assume fixnum fits in int.
878 * xterm.c (x_x_to_emacs_modifiers):
879 Don't assume EMACS_INT overflows nicely into int.
880 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
882 (handle_one_xevent): NATNUMP can eval its arg twice.
883 (x_connection_closed):
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 * xterm.h: Adjust decls to match defn changes elsewhere.
886 (struct scroll_bar): Use struct vectorlike_header
887 rather than rolling our own approximation.
888 (SCROLL_BAR_VEC_SIZE): Remove; not used.
890 2012-05-25 Glenn Morris <rgm@gnu.org>
892 * lisp.mk (lisp): Update for more files being compiled now.
894 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
896 * lread.c: Remove `read_pure' which makes no difference.
897 (read_pure): Remove var.
898 (unreadpure): Remove function.
899 (readevalloop): Don't call read_list with -1 flag.
900 (read1, read_vector): Don't test read_pure any more.
901 (read_list): Simplify.
903 * fileio.c, character.h: Minor style tweaks.
905 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
907 * window.h (clip_changed): Remove useless declaration.
909 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
911 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
912 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
914 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
917 This directory predates autoconf and is no longer needed nowadays.
918 Move its few remaining bits of functionality to where they're needed.
919 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
920 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
921 * m/template.h: Remove.
922 * Makefile.in (M_FILE): Remove. All uses removed.
923 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
924 * lisp.h (USE_LSB_TAG):
925 * mem-limits.h (EXCEEDS_LISP_PTR):
926 Use VAL_MAX, not VALBITS, in #if.
927 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
928 (EMACS_UINT): Define unconditionally now.
929 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
930 (BITS_PER_EMACS_INT): New constants, replacing
931 what used to be in config.h, but not useful in #if.
932 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
933 define them any more.
934 (VAL_MAX): New macro.
936 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
937 BITS_PER_EMACS_INT, in #if.
938 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
939 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
940 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
941 * s/ms-w32.h (DATA_START):
942 Move here from removed file m/intel386.h.
943 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
944 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
946 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
949 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
950 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
952 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
953 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
954 * textprop.c, tparam.c (NULL): Remove.
955 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
956 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
957 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
958 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
959 * xterm.c (input_signal_count): Assume volatile works.
961 2012-05-21 Ken Brown <kbrown@cornell.edu>
963 * xgselect.c (xg_select): Fix first argument in call to 'select'
966 2012-05-20 Ken Brown <kbrown@cornell.edu>
968 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
969 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
971 2012-05-19 Ken Brown <kbrown@cornell.edu>
973 * xfns.c (x_in_use): Remove `static' qualifier.
974 * xterm.h (x_in_use): Declare.
975 * xgselect.c: Include xterm.h.
976 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
977 and `display_arg' (bug#9754).
979 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
981 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
983 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
984 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
986 2012-05-18 Eli Zaretskii <eliz@gnu.org>
988 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
990 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
991 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
993 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
994 reference to image_cache->refcount.
995 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
997 2012-05-17 Juri Linkov <juri@jurta.org>
999 * search.c (Fword_search_regexp, Fword_search_backward)
1000 (Fword_search_forward, Fword_search_backward_lax)
1001 (Fword_search_forward_lax): Move functions to isearch.el
1002 (bug#10145, bug#11381).
1004 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1006 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1008 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1010 * lread.c (init_obarray): Declare Qt and Qnil as special.
1012 2012-05-14 Glenn Morris <rgm@gnu.org>
1014 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1015 Put "libexec" before "bin", for the sake of init_callproc_1.
1017 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1019 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1021 * unexaix.c: Port to more-recent AIX compilers.
1022 (report_error, report_error_1, make_hdr, copy_sym)
1023 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1024 Make arguments const char *, not char *, to avoid violations of C
1025 standard and to fix some AIX warnings reported by Gilles Pion.
1027 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1029 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1030 already have overlays loaded.
1031 (handle_single_display_spec): Before returning without displaying
1032 fringe bitmap, synchronize the bidi iterator with the main display
1033 iterator, by calling iterate_out_of_display_property.
1034 (iterate_out_of_display_property): Detect buffer iteration by
1035 testing that it->string is a Lisp string.
1036 (get_next_display_element): When the current object is exhausted,
1037 and there's something on it->stack, call set_iterator_to_next to
1038 proceed with what's on the stack, instead of returning zero.
1039 (set_iterator_to_next): If called at the end of a Lisp string,
1040 proceed to consider_string_end without incrementing string
1041 position. Don't increment display vector index past the end of
1042 the display vector. (Bug#11417)
1043 (pos_visible_p): Don't report a position visible when move_it_to
1044 stopped at the last line of window, which happens to be scanned
1045 backwards by the bidi iteration. (Bug#11464)
1047 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1050 and right-margin display specs even if the spec is invalid or we
1051 are on a TTY, and thus unable to display on the fringes. That's
1052 because the text with the property will not be displayed anyway,
1053 so we need to signal to the caller that this is a "replacing"
1054 display spec. This fixes display when the spec is invalid or we
1057 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1059 * unexaix.c (make_hdr): Fix typo in prototype.
1060 This bug broke the build on AIX. Problem reported by Gilles Pion.
1062 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1064 * keyboard.c (kbd_buffer_get_event): Read special events also in
1065 batch mode. (Bug#11415)
1067 2012-05-12 Glenn Morris <rgm@gnu.org>
1069 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1071 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1073 * lisp.mk (lisp): Add newcomment.elc.
1075 2012-05-12 Glenn Morris <rgm@gnu.org>
1077 * Makefile.in (MKDIR_P): New, set by configure.
1078 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1080 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1082 Remove unused function hourglass_started.
1083 * dispextern.h (hourglass_started):
1084 * w32fns.c (hourglass_started):
1085 * xdisp.c (hourglass_started): Remove.
1087 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1089 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1090 Update dependencies.
1092 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1094 * xgselect.c (xg_select): Put maxfds+1 into a var.
1095 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1097 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1099 2012-05-10 Dave Abrahams <dave@boostpro.com>
1101 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1102 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1104 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1106 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1107 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1108 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1109 Initialize xd_registered_buses.
1111 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1113 Untag more efficiently if USE_LSB_TAG.
1114 This is based on a proposal by YAMAMOTO Mitsuharu in
1115 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1116 For an admittedly artificial (nth 8000 longlist) benchmark on
1117 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1118 Emacs's overall text size by 1%.
1119 * lisp.h (XUNTAG): New macro.
1120 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1121 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1122 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1123 * eval.c (Fautoload):
1124 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1125 * frame.h (XFRAME): Use XUNTAG.
1127 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1128 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1129 Remove unportable assumptions about print widths of types like
1131 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1132 intptr_t when converting between pointer and integer, to avoid GCC
1133 warnings about wrong width.
1135 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1137 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1138 stack for each reader_thread, instead of defaulting to 8MB
1139 determined by the linker. This avoids failures in creating
1140 subprocesses on Windows 7, see the discussion in this thread:
1141 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1143 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1145 Fix up display of the *Minibuf-0* buffer in the mini window.
1146 * keyboard.c (read_char): Don't clear the echo area if there's no
1148 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1149 contents of *Minibuf-0*) if there's no message displayed in its stead.
1151 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1153 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1156 2012-05-06 Chong Yidong <cyd@gnu.org>
1158 * lisp.mk (lisp): Update.
1160 2012-05-05 Jim Meyering <meyering@redhat.com>
1162 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1164 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1166 * data.c (PUT_ERROR): New macro.
1167 (syms_of_data): Use it. Add new error type `user-error'.
1168 * undo.c (user_error): New function.
1169 (Fprimitive_undo): Use it.
1170 * print.c (print_error_message): Adjust print style for `user-error'.
1171 * keyboard.c (user_error): New function.
1172 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1174 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1176 Do not limit current-time-string to years 1000..9999.
1177 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1178 (Fcurrent_time_string): Support any year that is supported by the
1179 underlying localtime representation. Don't use asctime, as it
1180 has undefined behavior for years outside the range -999..9999.
1182 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1184 Fix race conditions involving setenv, gmtime, localtime, asctime.
1185 Without this fix, interrupts could mess up code that uses these
1186 nonreentrant functions, since setting TZ invalidates existing
1187 tm_zone or tzname values, and since most of these functions return
1188 pointers to static storage.
1189 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1190 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1191 Grow the critical sections to include not just invoking
1192 localtime/gmtime, but also accessing these functions' results
1193 including their tm_zone values if any, and any related TZ setting.
1194 (format_time_string): Last arg is now struct tm *, not struct tm **,
1195 so that the struct tm is saved in the critical section.
1196 All callers changed. Simplify allocation of initial buffer, partly
1197 motivated by the fact that memory allocation needs to be outside
1198 the critical section.
1200 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1202 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1203 with RESET_INTERVAL.
1205 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1206 Remove duplicated buffer name initialization.
1208 2012-05-02 Jim Meyering <jim@meyering.net>
1210 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1212 * xfns.c (x_window): Use xstrdup (Bug#11375).
1214 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1216 * xdisp.c (pos_visible_p): If already at a newline from the
1217 display string before the 'while' loop, don't walk back the glyphs
1218 from it3.glyph_row. Solves assertion violation when the display
1219 string begins with a newline (egg.el). (Bug#11367)
1221 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1223 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1226 2012-05-01 Glenn Morris <rgm@gnu.org>
1228 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1229 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1230 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1231 All were removed before 23.1.
1233 * dispnew.c: Remove HAVE_LIBNCURSES test;
1234 it is always true on relevant platforms.
1236 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1237 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1239 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1241 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1243 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1244 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1247 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1249 Do not avoid creating empty evaporating overlays (Bug#9642).
1250 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1251 That is, do not delete an evaporating overlay if it becomes
1252 empty after its bounds are adjusted to fit within its buffer.
1253 This fix caused other problems, and I'm reverting it until we get
1254 to the bottom of them.
1256 2012-04-27 Chong Yidong <cyd@gnu.org>
1258 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1260 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (pos_visible_p): If the window start position is beyond
1263 ZV, start the display from buffer beginning. Prevents assertion
1264 violation in init_iterator when the minibuffer window is scrolled
1267 * window.c (window_scroll_pixel_based): Likewise.
1269 2012-04-27 Chong Yidong <cyd@gnu.org>
1271 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1273 2012-04-27 Glenn Morris <rgm@gnu.org>
1275 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1276 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1278 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1280 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1281 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1283 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1285 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1286 display element, check also the underlying string or buffer
1287 character. (Bug#11341)
1289 * w32menu.c: Include w32heap.h.
1290 (add_menu_item): If the call to AppendMenuW (via
1291 unicode_append_menu) fails, disable Unicode menus only if we are
1292 running on Windows 9X/Me.
1294 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1296 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1297 (xgetint): Add missing shift for LSB tags.
1299 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1301 * keyboard.c (read_char): Don't wipe echo area for select window
1302 events: These might get delayed via `mouse-autoselect-window'
1305 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1307 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1308 manipulation of :loaded-from data.
1310 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1312 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1313 now a cons (bug#11311).
1315 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1317 Do not create empty overlays with the evaporate property (Bug#9642).
1318 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1319 if it becomes empty after its bounds are adjusted to fit within
1320 its buffer. Without this fix, in a nonempty buffer (let ((o
1321 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1322 yields an empty overlay that has the evaporate property, which is
1323 not supposed to happen.
1325 Fix minor GTK3 problems found by static checking.
1326 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1327 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1328 (struct _EmacsFixedClass, emacs_fixed_get_type):
1329 Move decls here from emacsgtkfixed.h, since they needn't be public.
1330 (emacs_fixed_get_type): Now static.
1331 (emacs_fixed_class_init): Omit unused local.
1332 (emacs_fixed_child_type): Remove; unused.
1333 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1334 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1335 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1336 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1337 (EMACS_FIXED_GET_CLASS): Remove; unused.
1338 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1340 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1341 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1343 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1345 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1346 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1347 (__malloc_size_t, __malloc_ptrdiff_t):
1348 Remove. All uses removed, replaced by the definiens if needed,
1349 since we can assume C89 or better now.
1350 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1351 (protect_malloc_state, align, get_contiguous_space)
1352 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1353 (malloc_atfork_handler_child, malloc_enable_thread)
1354 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1355 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1356 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1357 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1358 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1359 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1360 Define using prototypes, not old style.
1361 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1362 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1363 (align): Don't assume that signed integer overflow wraps around.
1364 Omit unused local var.
1365 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1366 (_free_internal_nolock, memalign, mallochook, reallochook):
1367 Omit no-longer-needed casts.
1368 (valloc): Use getpagesize, not __getpagesize.
1369 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1370 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1372 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1374 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1376 Move functions from C to Lisp. Make non-blocking method calls
1377 the default. Implement further D-Bus standard interfaces.
1379 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1380 (QCdbus_request_name_allow_replacement)
1381 (QCdbus_request_name_replace_existing)
1382 (QCdbus_request_name_do_not_queue)
1383 (QCdbus_request_name_reply_primary_owner)
1384 (QCdbus_request_name_reply_in_queue)
1385 (QCdbus_request_name_reply_exists)
1386 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1387 (QCdbus_registered_serial, QCdbus_registered_method)
1388 (QCdbus_registered_signal): New Lisp objects.
1389 (XD_DEBUG_MESSAGE): Use sizeof.
1390 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1391 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1392 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1393 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1394 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1395 (xd_signature, xd_append_arg): Allow float for integer types.
1396 (xd_get_connection_references): New function.
1397 (xd_get_connection_address): Rename from xd_initialize.
1398 Return cached address.
1399 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1400 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1402 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1403 Return number of refcounts.
1404 (Fdbus_get_unique_name): Make stronger parameter check.
1405 (Fdbus_message_internal): New defun.
1406 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1407 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1408 (Fdbus_send_signal, Fdbus_register_service)
1409 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1410 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1411 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1412 (Vdbus_compiled_version, Vdbus_runtime_version)
1413 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1414 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1415 (Vdbus_message_type_signal): New defvars.
1416 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1419 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1421 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1422 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1423 Do not assume ptrdiff_t is the same width as 'int'.
1425 * alloc.c: Handle unusual debugging option combinations.
1426 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1427 since the two debugging options are incompatible.
1428 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1430 (mem_init, mem_insert, mem_insert_fixup):
1431 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1432 (NEED_MEM_INSERT): Remove; no longer needed.
1434 2012-04-22 Leo Liu <sdl.web@gmail.com>
1436 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1438 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1440 * sysdep.c [__FreeBSD__]: Minor cleanups.
1441 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1442 Use Emacs indenting style more consistently. Avoid some casts.
1443 Use 'double' consistently rather than mixing 'float' and 'double'.
1445 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1447 * sysdep.c (list_system_processes, system_process_attributes):
1448 Add implementation for FreeBSD (Bug#5243).
1450 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1452 * lisp.mk (lisp): Update.
1454 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1456 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1457 It is never used otherwise.
1459 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1461 * print.c (print_preprocess): Only check print_depth if print-circle
1463 (print_object): Check for cycles even when print-circle is nil and
1464 print-gensym is t, but only check print_depth if print-circle is nil.
1466 2012-04-20 Chong Yidong <cyd@gnu.org>
1468 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1469 set the status to "failed" and ensure that sentinel is run.
1471 2012-04-20 Glenn Morris <rgm@gnu.org>
1473 * process.c (Fset_process_inherit_coding_system_flag)
1474 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1475 (Fmake_network_process, Fmake_serial_process): Doc fix.
1477 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (string_buffer_position_lim): Limit starting position to
1481 (set_cursor_from_row): If called for a mode-line or header-line
1482 row, return zero immediately.
1483 (try_cursor_movement): If inside continuation line, don't back up
1484 farther than the first row after the header line, if any.
1485 Don't consider the header-line row as "partially visible", even if
1486 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1488 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1490 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1493 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1494 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1496 configure: new option --enable-gcc-warnings (Bug#11207)
1497 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1498 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1499 (ALL_CFLAGS): Use new macros rather than old.
1500 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1501 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1502 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1503 -Wunused-result, -Wunused-variable. This should go away once
1504 the Emacs and Gnulib regex code is merged.
1505 (xmalloc, xrealloc): Now static.
1507 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1509 * dired.c (Fsystem_groups): Remove unused local.
1511 2012-04-17 Glenn Morris <rgm@gnu.org>
1513 * dired.c (Fsystem_users): Doc fix.
1515 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1517 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1518 (syms_of_dired): Add them.
1520 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1522 Fix minor alloc.c problems found by static checking.
1523 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1524 New extern decls, to avoid calling undeclared functions.
1525 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1526 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1527 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1528 (NEED_MEM_INSERT): New macro.
1529 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1530 Remove one incorrect comment and fix another.
1532 Fix minor ralloc.c problems found by static checking.
1533 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1534 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1535 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1536 (r_alloc_sbrk): Now static.
1538 Improve ralloc.c interface checking.
1539 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1540 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1541 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1542 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1543 [REL_ALLOC]: ... to here, to check interface.
1544 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1545 Remove decls. This fixes an "It stinks!".
1547 * alloc.c (which_symbols): Fix alignment issue / type clash.
1549 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1551 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1552 (struct Lisp_Misc_Any): Likewise.
1553 (struct Lisp_Free): Likewise.
1554 * alloc.c (union aligned_Lisp_Symbol): Define.
1555 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1556 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1557 (union aligned_Lisp_Misc): Define.
1558 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1559 aligned_Lisp_Misc instead of union Lisp_Misc.
1560 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1562 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1564 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1565 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1566 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1567 * s/netbsd.h, s/sol2-6.h:
1568 Remove definition of GC_MARK_STACK, since the default now works.
1569 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1570 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1571 no longer the default.
1572 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1574 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1576 * lread.c (lisp_file_lexically_bound_p):
1577 Fix hang at ";-*-\n" (bug#11238).
1579 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1582 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1584 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1586 * nsterm.m (constrainFrameRect): Always constrain when there is only
1587 one screen (Bug#10962).
1589 2012-04-13 Ken Brown <kbrown@cornell.edu>
1591 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1593 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1595 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1597 2012-04-11 Daniel Colascione <dancol@dancol.org>
1599 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1600 against is gone. It's better to use vfork now so that when Cygwin
1601 gains a new, working vfork, we use it automatically (bug#10398).
1603 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1605 * window.c (save_window_save): Obey window-point-insertion-type.
1607 2012-04-11 Glenn Morris <rgm@gnu.org>
1609 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1611 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1613 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1615 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1617 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1618 (force_quit_count): New var.
1619 (handle_interrupt): Use it.
1621 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1623 * w32.c (w32_delayed_load): Record the full path of the library
1624 being loaded (bug#10424).
1626 2012-04-09 Glenn Morris <rgm@gnu.org>
1628 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1629 not just in the obarray, before snarfing them. (Bug#11036)
1631 * Makefile.in ($(leimdir)/leim-list.el):
1632 Pass EMACS rather than BUILT_EMACS.
1634 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1636 * process.c (make_process):
1637 * process.h: Add integer `gnutls_handshakes_tried' member to
1640 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1641 Add convenience `GNUTLS_LOG2i' macro.
1643 * gnutls.c (gnutls_log_function2i): Convenience log function.
1644 (emacs_gnutls_read): Use new log functions,
1645 `gnutls_handshakes_tried' process member, and
1646 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1647 attempts per process (connection).
1649 2012-04-09 Chong Yidong <cyd@gnu.org>
1651 * eval.c (Fuser_variable_p, user_variable_p_eh)
1652 (lisp_indirect_variable): Functions deleted.
1653 (Fdefvar): Caller changed.
1655 * callint.c (Finteractive, Fcall_interactively):
1656 * minibuf.c (Fread_variable): Callers changed.
1658 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1660 * xdisp.c (set_cursor_from_row): If the display string appears in
1661 the buffer at position that is closer to point than the position
1662 after the display string, display the cursor on the first glyph of
1663 the display string. Fixes cursor display when a 'display' text
1664 property immediately follows invisible text. (Bug#11094)
1666 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1668 composite.c: use 'double' consistently
1669 * composite.c (get_composition_id): Use 'double' consistently
1670 instead of converting 'float' to 'double' and vice versa; this is
1671 easier to understand and avoids a GCC warning.
1673 2012-04-09 Glenn Morris <rgm@gnu.org>
1675 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1676 preparation for dumping it with emacs. (Bug#4789)
1677 (leimdir): New variable.
1678 ($(leimdir)/leim-list.el): New rule.
1679 (emacs$(EXEEXT)): Depend on leim-list.el.
1681 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1682 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1683 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1685 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1687 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1690 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1692 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1693 Remove unused local variable.
1695 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1697 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1698 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1699 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1700 objects, as mark_maybe_pointer will catch them otherwise.
1701 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1702 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1704 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1706 Fix typo that broke non-Windows builds.
1707 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1709 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1711 Support building on MS-Windows with libxml2.
1713 * makefile.w32-in (OBJ2): Add xml.$(O).
1714 (GLOBAL_SOURCES): Add xml.c.
1715 ($(BLD)/xml.$(O)): New dependency list.
1717 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1718 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1719 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1720 [!WINDOWSNT]: New macros.
1721 (init_libxml2_functions, libxml2_loaded_p): New functions.
1722 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1723 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1724 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1725 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1727 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1728 Call init_libxml2_functions before calling libxml2 functions.
1729 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1731 * emacs.c: Don't include libxml/parser.h.
1732 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1733 xmlCleanupParser directly.
1735 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1737 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1739 * indent.c (Fvertical_motion): If there is a display string at
1740 point, use it.vpos to compute how many lines to backtrack after
1741 move_it_to point. (Bug#11133)
1743 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1745 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1746 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1747 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1748 macros related to unification of CJK characters. For the details,
1749 see the discussion following the message here:
1750 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1752 2012-04-04 Chong Yidong <cyd@gnu.org>
1754 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1756 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1758 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1759 instead of alloca. (Bug#11138)
1761 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1763 * w32menu.c (is_simple_dialog): Properly check lisp types.
1766 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1768 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1769 position we get to after a call to move_it_to fails the
1770 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1771 only if we wind up in a string from display property. (Bug#11063)
1773 * window.c (Fdelete_other_windows_internal): Invalidate the row
1774 and column information about mouse highlight, so that redisplay
1775 restores it after reallocating the glyph matrices. (Bug#7464)
1777 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1778 string comes from a `display' text property, use the buffer
1779 position of that property as if we actually saw that position in
1781 (move_it_by_lines): Remove the assertion that
1782 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1783 violated when there's a before-string at the beginning of a line.
1786 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1788 * xdisp.c (append_space_for_newline): If the default face was
1789 remapped, use the remapped face for the appended newline.
1790 (extend_face_to_end_of_line): Use the remapped default face for
1791 extending the face to the end of the line.
1792 (display_line): Call extend_face_to_end_of_line when the default
1793 face was remapped. (Bug#11068)
1795 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1797 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1799 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1801 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1803 2012-03-27 Glenn Morris <rgm@gnu.org>
1805 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1808 2012-03-26 Kenichi Handa <handa@m17n.org>
1810 * dispextern.h (struct glyph): Fix previous change. Change the
1811 bit length of glyphless.ch to 25 (Bug#11082).
1813 2012-03-26 Chong Yidong <cyd@gnu.org>
1815 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1816 (command_loop_1): Use it; inhibit selection update for
1817 handle-select-window too (Bug#8996).
1819 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1821 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1823 2012-03-25 Kenichi Handa <handa@m17n.org>
1825 * dispextern.h (struct glyph): Change the bit length of
1826 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1828 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1830 * s/ms-w32.h (tzname): Include time.h before redirecting to
1831 _tzname. Fixes the MSVC build. (Bug#9960)
1833 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1835 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1838 * xterm.c (XTread_socket): Only modify handling_signal if
1839 !SYNC_INPUT. (Bug#11080)
1841 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1843 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1844 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1845 when fetching a multibyte character consumes more bytes than
1846 CHAR_BYTES returns, due to unification of CJK characters in
1847 string_char. (Bug#11073)
1849 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1851 * process.c (wait_reading_process_output): Handle pty disconnect
1852 by refraining from sending oneself a SIGCHLD (bug#10933).
1854 2012-03-22 Chong Yidong <cyd@gnu.org>
1856 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1858 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1859 Mark string as coming from a prefix property.
1860 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1861 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1863 2012-03-21 Chong Yidong <cyd@gnu.org>
1865 * xfaces.c (Vface_remapping_alist): Doc fix.
1867 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1869 * w32proc.c (Fw32_set_console_codepage)
1870 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1873 2012-03-20 Chong Yidong <cyd@gnu.org>
1875 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1876 to reflect default non-nil value of redisplay-dont-pause.
1878 2012-03-19 Kenichi Handa <handa@m17n.org>
1880 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1881 it fit in a valid range (Bug#11003).
1883 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1886 that is not from display property, accept the row as a "cursor
1887 row" if one of the string's character has a non-nil `cursor'
1888 property. Fixes cursor positioning when there are newlines in
1889 overlay strings, e.g. in icomplete.el. (Bug#11035)
1891 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1893 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1895 2012-03-12 Chong Yidong <cyd@gnu.org>
1897 * eval.c (inhibit_lisp_code): Rename from
1898 inhibit_window_configuration_change_hook; move from window.c.
1900 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1901 * window.c (run_window_configuration_change_hook)
1902 (syms_of_window): Callers changed.
1904 2012-03-11 Chong Yidong <cyd@gnu.org>
1906 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1908 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1910 2012-03-10 Chong Yidong <cyd@gnu.org>
1912 * frame.c (other_visible_frames): Don't assume the selected frame
1913 is visible (Bug#10955).
1915 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1917 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1919 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1921 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1922 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1925 2012-03-03 Glenn Morris <rgm@gnu.org>
1927 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1929 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1931 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1932 position past the first glyph_row that ends at ZV. (Bug#10902)
1933 (redisplay_window, next_element_from_string): Fix typos in
1935 (redisplay_window): Pass to move_it_vertically the margin in
1936 pixels, not in screen lines.
1938 2012-03-02 Glenn Morris <rgm@gnu.org>
1940 * buffer.c (buffer-list-update-hook): Doc fix.
1942 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1945 push_it before setting up the iterator for the first overlay
1946 string, even if we have an empty string loaded.
1947 (next_overlay_string): If there's an empty string on the iterator
1948 stack, pop the stack. (Bug#10903)
1950 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1952 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1953 Suggested by Stefan Monnier in
1954 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1955 * alloc.c (widen_to_Lisp_Object): New static function.
1956 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1957 and widening them to Lisp_Objects. This would work even if
1958 USE_LSB_TAG is defined and wide integers are used, which might
1959 happen in a future version of Emacs.
1961 2012-02-25 Chong Yidong <cyd@gnu.org>
1963 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1966 * xselect.c (Fx_selection_exists_p): Doc fix.
1967 (x_clipboard_manager_save_all): Print an informative message
1968 before saving to clipboard manager.
1970 2012-02-24 Chong Yidong <cyd@gnu.org>
1972 * keyboard.c (process_special_events): Handle all X selection
1973 requests in kbd_buffer, not just the next one (Bug#8869).
1975 2012-02-23 Chong Yidong <cyd@gnu.org>
1977 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1978 call when setting menu-bar-lines and tool-bar-lines parameters.
1979 (unwind_create_frame_1): New helper function.
1981 * window.c (inhibit_window_configuration_change_hook): New var.
1982 (run_window_configuration_change_hook): Obey it.
1983 (syms_of_window): Initialize it.
1985 2012-02-22 Chong Yidong <cyd@gnu.org>
1987 * xterm.c (x_draw_image_relief): Add missing type check for
1988 Vtool_bar_button_margin (Bug#10743).
1990 2012-02-21 Chong Yidong <cyd@gnu.org>
1992 * fileio.c (Vfile_name_handler_alist): Doc fix.
1994 * buffer.c (Fget_file_buffer): Protect against invalid file
1995 handler return value.
1997 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1999 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2000 when computing $valmask.
2002 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2003 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2004 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2005 It's useless in that case, and it can cause problems on hosts
2006 that allocate halves of EMACS_INT values separately.
2007 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2008 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2009 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2010 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2011 it avoids undefined behavior on hosts where shifting right by more
2012 than the word width has undefined behavior.
2014 2012-02-19 Chong Yidong <cyd@gnu.org>
2016 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2017 (Funhandled_file_name_directory, Ffile_name_as_directory)
2018 (Fdirectory_file_name, Fexpand_file_name)
2019 (Fsubstitute_in_file_name): Protect against invalid file handler
2020 return values (Bug#10845).
2022 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2024 * .gdbinit (pitx): Fix incorrect references to fields of the
2027 2012-02-17 Chong Yidong <cyd@gnu.org>
2029 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2031 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2033 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2034 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2036 2012-02-15 Chong Yidong <cyd@gnu.org>
2038 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2039 marked as special. Also, starting docstrings with * is obsolete.
2041 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2043 * gnutls.c (emacs_gnutls_write): Fix last change.
2045 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2047 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2050 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2052 * keymap.c (Fsingle_key_description): Handle char ranges.
2054 2012-02-12 Chong Yidong <cyd@gnu.org>
2056 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2057 as that creates a dangerous corner case.
2059 * window.c (Fdelete_window_internal): Invalidate the mouse
2060 highlight (Bug#9904).
2062 2012-02-12 Glenn Morris <rgm@gnu.org>
2064 * xselect.c (Fx_own_selection_internal)
2065 (Fx_get_selection_internal, Fx_disown_selection_internal)
2066 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2067 * nsselect.m (Fx_own_selection_internal)
2068 (Fx_disown_selection_internal, Fx_selection_exists_p)
2069 (Fx_selection_owner_p, Fx_get_selection_internal):
2070 Sync docs and argument specs with the xselect.c versions.
2072 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2074 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2076 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2078 * w32select.c (Fx_selection_exists_p): Sync doc string and
2079 argument list with xselect.c. (Bug#10783)
2081 * w16select.c (Fx_selection_exists_p): Sync doc string and
2082 argument list with xselect.c. (Bug#10783)
2084 2012-02-10 Glenn Morris <rgm@gnu.org>
2086 * fns.c (Fsecure_hash): Doc fix.
2088 2012-02-09 Kenichi Handa <handa@m17n.org>
2090 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2092 2012-02-07 Chong Yidong <cyd@gnu.org>
2094 * buffer.c (Fbuffer_local_variables)
2095 (buffer_lisp_local_variables): Handle unbound vars correctly;
2096 don't let Qunbound leak into Lisp.
2098 2012-02-07 Glenn Morris <rgm@gnu.org>
2100 * image.c (Fimagemagick_types): Doc fix.
2102 * image.c (imagemagick-render-type): Change it from a lisp object
2103 to an integer. Move the doc here from the lisp manual.
2104 Treat all values not equal to 0 the same.
2106 2012-02-06 Chong Yidong <cyd@gnu.org>
2108 * doc.c (store_function_docstring): Avoid applying docstring of
2109 alias to base function (Bug#2603).
2111 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2113 * .gdbinit (pp1, pv1): Remove redundant defines.
2116 2012-02-04 Chong Yidong <cyd@gnu.org>
2118 * nsterm.m: Declare a global (Bug#10694).
2120 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2122 * w32.c (get_emacs_configuration_options):
2123 Include --enable-checking, if specified, in the return value.
2125 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2127 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2128 after rounding frame sizes. (Bug#9723)
2130 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2132 * keyboard.c (adjust_point_for_property): Don't position point
2133 before BEGV. (Bug#10696)
2135 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2137 Handle overflow when computing char display width (Bug#9496).
2138 * character.c (char_width): Return EMACS_INT, not int.
2139 (char_width, c_string_width): Check for overflow when
2140 computing the width; this is possible now that individual
2141 characters can have unbounded width. Problem introduced
2142 by merge from Emacs 23 on 2012-01-19.
2144 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2146 * dbusbind.c (Fdbus_register_method): Mention the return value
2147 :ignore in the docstring.
2149 2012-02-02 Glenn Morris <rgm@gnu.org>
2151 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2153 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2154 Unconditionally set to t. (Bug#10673)
2155 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2156 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2157 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2159 2012-02-02 Kenichi Handa <handa@m17n.org>
2161 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2162 0, do not call append_composite_glyph.
2164 2012-02-02 Kenichi Handa <handa@m17n.org>
2166 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2168 (x_produce_glyphs): If the component of a composition is a null
2169 string, set it->pixel_width to 1 to avoid zero-width glyph.
2171 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2173 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2174 first 2 arguments are identical. This makes inserting large
2175 output from a subprocess an order of magnitude faster on
2176 MS-Windows, where all sbrk'ed memory is always contiguous.
2178 2012-01-31 Glenn Morris <rgm@gnu.org>
2180 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2181 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2182 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2184 2012-01-29 Glenn Morris <rgm@gnu.org>
2186 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2188 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2190 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2192 2012-01-28 Chong Yidong <cyd@gnu.org>
2194 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2196 2012-01-26 Chong Yidong <cyd@gnu.org>
2198 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2200 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2201 repeat counts (Bug#10507).
2203 2012-01-26 Glenn Morris <rgm@gnu.org>
2205 * lread.c (syms_of_lread): Doc fix.
2207 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2209 * coding.c (encode_designation_at_bol): Change return value to
2212 2012-01-25 Chong Yidong <cyd@gnu.org>
2214 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2216 2012-01-21 Chong Yidong <cyd@gnu.org>
2218 * floatfns.c (Fcopysign): Make the second argument non-optional,
2219 since nil is not allowed anyway.
2221 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2223 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2224 (send_process): Likewise.
2226 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2228 * window.c (save_window_save, Fcurrent_window_configuration)
2229 (Vwindow_persistent_parameters): Do not use Qstate.
2230 Rewrite doc-strings.
2232 2012-01-19 Kenichi Handa <handa@m17n.org>
2234 * character.c (char_width): New function.
2235 (Fchar_width, c_string_width, lisp_string_width):
2236 Use char_width (Bug#9496).
2238 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2240 * window.c (Vwindow_persistent_parameters): New variable.
2241 (Fset_window_configuration, save_window_save): Handle persistent
2244 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2246 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2247 thrashing the stack of the thread. (Bug#9087)
2249 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2251 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2253 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (rows_from_pos_range): Handle the case where the
2256 highlight ends on a newline. (Bug#10464)
2257 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2258 he end column for display of highlight that ends on a newline
2261 2012-01-11 Glenn Morris <rgm@gnu.org>
2263 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2264 from load-path also when installation-directory is nil. (Bug#10208)
2266 2012-01-10 Glenn Morris <rgm@gnu.org>
2268 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2270 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2271 Update template values to be closer to their typical values these days.
2273 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2275 * xdisp.c (rows_from_pos_range): Accept additional argument
2276 DISP_STRING, and accept any glyph in a row whose object is that
2277 string as eligible for mouse highlight. Fixes mouse highlight of
2278 display strings from overlays. (Bug#10464)
2280 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2282 emacs: fix an auto-save permissions race condition (Bug#10400)
2283 * fileio.c (auto_saving_dir_umask): New static var.
2284 (Fmake_directory_internal): Use it.
2285 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2286 creating the directory. The old code temporarily assigns
2287 too-generous permissions to the directory.
2288 (do_auto_save_eh): Clear it.
2289 (Fdo_auto_save): Catch all errors, not just file errors, so
2290 that the var is always cleared.
2292 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2294 * search.c (scan_buffer): Pass character positions to
2295 know_region_cache, not byte positions. (Bug#6540)
2297 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2299 * w32.c (sys_rename): Report EXDEV when rename of a directory
2300 fails because the target is on another logical disk. (Bug#10284)
2302 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2304 * xterm.c (x_embed_request_focus): New function.
2306 * xterm.h: Add prototype.
2308 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2310 2012-01-05 Glenn Morris <rgm@gnu.org>
2312 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2314 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2316 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2317 Load gnutls_transport_set_lowat only if GnuTLS version is below
2319 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2320 GnuTLS versions below 2.11.1.
2322 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2324 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2325 to the doc string advising against its use for altering the way
2326 windows are scrolled.
2328 2011-12-28 Kenichi Handa <handa@m17n.org>
2330 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2331 coding-system ASCII compatible only when it does not produce BOM
2332 on encoding (Bug#10383).
2334 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2336 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2338 (create_and_show_popup_menu): Always use menu_position_func for
2341 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2343 * callint.c (Fcall_interactively): Don't truncate prompt string.
2345 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2347 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2348 property that ends at ZV, so that the bidi iteration could be
2349 resumed from there (after widening). (Bug#10360)
2351 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2353 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2355 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2357 * nsterm.m (x_free_frame_resources):
2358 Release f->output_data.ns->miniimage.
2359 (ns_index_color): Fix indentation. Do not retain
2360 color_table->colors[i].
2362 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2365 * nsfns.m (x_set_background_color): Assign return value from
2366 ns_index_color to face-background instead of NSColor*.
2367 (ns_implicitly_set_icon_type): Fix indentation.
2368 Change assignment in for loop to comparison.
2370 * emacs.c (ns_pool): New variable.
2371 (main): Assign ns_pool.
2372 (Fkill_emacs): Call ns_release_autorelease_pool.
2374 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2375 autorelease fdesc, release fdAttrs and tdict.
2376 (ns_get_covering_families): Release charset.
2377 (ns_findfonts): Release NSFontDescriptor created with new.
2378 (ns_uni_to_glyphs): Fix indentation.
2379 (setString): Release attrStr before assigning new value.
2381 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2383 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2385 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2386 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2388 2011-12-18 David Reitter <reitter@cmu.edu>
2390 * nsterm.m (ns_term_init): Subscribe for notifications
2391 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2392 to method trackingNotification in EmacsMenu.
2394 * nsmenu.m (trackingMenu): New variable.
2395 (trackingNotification): New method (from Aquamacs).
2396 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2397 from Aquamacs (Bug#7030).
2399 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2401 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2402 (symbol_to_nsstring): Fix indentation.
2403 (ns_symbol_to_pb): New function.
2404 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2405 (Fns_rotate_cut_buffers_internal): Remove.
2406 (Fns_store_selection_internal): Rename from
2407 Fns_store_cut_buffer_internal.
2408 (ns_get_foreign_selection, Fx_own_selection_internal)
2409 (Fx_disown_selection_internal, Fx_selection_exists_p)
2410 (Fns_get_selection_internal, Fns_store_selection_internal):
2411 Use ns_symbol_to_pb and check if return value is nil.
2412 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2413 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2414 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2415 renamed to Sns_store_selection_internal.
2416 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2417 and remove this function.
2418 (ns_handle_selection_clear): Remove, never used.
2419 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2422 2011-12-17 Ken Brown <kbrown@cornell.edu>
2424 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2425 GID is unknown (Bug#10257).
2427 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2429 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2430 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2431 which caused a build failure on GNU/Linux IA-64. This problem was
2432 introduced by my 2011-10-07 patch.
2434 2011-12-15 Juri Linkov <juri@jurta.org>
2436 * image.c (imagemagick_error): New function. (Bug#10112)
2437 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2438 Use `imagemagick_error' where ImageMagick functions return
2440 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2443 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2445 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2446 fill background (Bug#8992).
2448 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2450 * window.c (Vwindow_combination_resize)
2451 (Vwindow_combination_limit): Use t instead of non-nil in
2453 (Vrecenter_redisplay): Add first sentence of doc-string on
2455 (Frecenter): Fix doc-string typo.
2457 2011-12-11 Kenichi Handa <handa@m17n.org>
2459 * coding.c (Funencodable_char_position): Pay attention to the
2460 buffer text relocation (Bug#9389).
2462 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2464 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2465 gtk_init (Bug#10100).
2467 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2469 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2470 IT->string is nil. (Bug#10263)
2472 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2474 * nsterm.h (x_free_frame_resources): Declare.
2476 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2477 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2479 * nsterm.h (ns_get_defaults_value): Declare.
2481 * nsterm.m (ns_default): Call ns_get_defaults_value.
2483 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2485 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2488 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2490 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2491 that where the value of an _OBJC_* symbol points to is in the .bss
2492 section (Bug#10240).
2494 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2496 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2497 after the loop to call ccl_driver at least once (Bug#8619).
2499 2011-12-08 Kenichi Handa <handa@m17n.org>
2501 * ftfont.c (get_adstyle_property): Fix previous change
2504 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2506 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2507 dirs from the default value of EMACSLOADPATH (bug#10208).
2509 2011-12-07 Glenn Morris <rgm@gnu.org>
2511 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2512 installation and source directories as well. (Bug#10208)
2514 2011-12-06 Chong Yidong <cyd@gnu.org>
2516 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2518 2011-12-06 Glenn Morris <rgm@gnu.org>
2520 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2521 as an error, not just -1. (Bug#10217)
2523 2011-12-05 Chong Yidong <cyd@gnu.org>
2525 * keyboard.c (process_special_events): New function.
2526 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2528 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2530 * coding.c (encode_designation_at_bol): Don't use uninitialized
2531 local variable (Bug#9318).
2533 2011-12-05 Kenichi Handa <handa@m17n.org>
2535 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2536 return Qnil (Bug#8046, Bug#10193).
2538 2011-12-05 Kenichi Handa <handa@m17n.org>
2540 * coding.c (encode_designation_at_bol): New args charbuf_end and
2541 dst. Return the number of produced bytes. Callers changed.
2542 (coding_set_source): Return how many bytes coding->source was
2544 (coding_set_destination): Return how many bytes
2545 coding->destination was relocated.
2546 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2547 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2549 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2551 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2552 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2555 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2557 The following changes are to fix Bug#9318.
2559 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2560 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2561 (encode_coding_iso_2022, encode_coding_sjis)
2562 (encode_coding_big5, encode_coding_charset): Use the above macros.
2564 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2566 * lisp.h (process_quit_flag): Fix external declaration.
2568 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2570 Don't macro-inline non-performance-critical code.
2571 * eval.c (process_quit_flag): New function.
2572 * lisp.h (QUIT): Use it.
2574 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2576 * nsfns.m (get_geometry_from_preferences): New function.
2577 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2579 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2581 * emacs.c (Qkill_emacs): Define.
2582 (syms_of_emacs): Initialize it.
2583 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2584 Qquit_flag to `kill-emacs' instead.
2585 (quit_throw_to_read_char): Add parameter `from_signal'.
2586 All callers changed. Call Fkill_emacs if requested and safe.
2587 * lisp.h (QUIT): Call Fkill_emacs if requested.
2589 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2591 * widget.c (update_wm_hints): Return if wmshell is null.
2592 (widget_update_wm_size_hints): New function.
2594 * widget.h (widget_update_wm_size_hints): Declare.
2596 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2597 widget_update_wm_size_hints (Bug#10104).
2599 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2601 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2602 before a newline, prepare the bidi iterator for consuming the
2603 newline, and keep the current paragraph direction. (Bug#10183)
2604 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2606 2011-12-02 Juri Linkov <juri@jurta.org>
2608 * search.c (Fword_search_regexp): New Lisp function created from
2609 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2610 (Fword_search_backward, Fword_search_forward)
2611 (Fword_search_backward_lax, Fword_search_forward_lax):
2612 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2613 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2615 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2617 * fileio.c (Finsert_file_contents): Move after-change-function call
2618 to before the "handled:" label, since all "goto handled" appear in
2619 cases where the *-change-functions have already been properly called
2622 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2624 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2625 waiting for input. (Bug#10169)
2627 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2629 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2630 verifies glyph row's hash code--we have just reallocated the
2631 glyphs, so their contents can be complete garbage. (Bug#10164)
2633 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2635 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2637 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2639 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2640 attributes are tested _before_ calling verify_row_hash, to protect
2641 against GCC re-ordering of the tests. (Bug#10164)
2643 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2645 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2647 * xterm.c (handle_one_xevent): Only set async_visible and friends
2648 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2649 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2650 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2652 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2654 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2655 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2656 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2657 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2658 All uses changed to use GCPRO1 etc.
2659 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2660 Revert to old implementation (i.e., before 2011-03-11).
2662 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2664 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2665 of scroll runs so as to avoid assigning disabled bogus rows and
2666 unnecessary graphics copy operations.
2668 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2670 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2671 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2672 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2673 (malloc, free, realloc, calloc): Redirect to e_* only when
2676 * lisp.h (GCTYPEBITS): Move before first use.
2677 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2678 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2679 this macro definition.
2681 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2684 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2686 * gtkutil.c (xg_create_frame_widgets):
2687 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2688 present with Gtk+ 2.0.
2690 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2692 * fileio.c (Finsert_file_contents): Undo previous change; see
2693 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2695 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2697 Rename locals to avoid shadowing.
2698 * fileio.c (Finsert_file_contents):
2699 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2700 * process.c (wait_reading_process_output):
2701 Rename inner 'proc' to 'p' to avoid shadowing.
2702 Indent for consistency with usual Emacs style.
2704 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2706 * xdisp.c (redisplay_window): If cursor row is not fully visible
2707 after recentering, and scroll-conservatively is set to a large
2708 number, scroll window by a few more lines to make the cursor fully
2709 visible and out of scroll-margin. (Bug#10105)
2710 (start_display): Don't move to the next line if the display should
2711 start at a newline that is part of a display vector or an overlay
2714 2011-11-24 Juri Linkov <juri@jurta.org>
2716 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2717 after the `MagickPingImage' call. (Bug#10112)
2719 2011-11-23 Chong Yidong <cyd@gnu.org>
2721 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2723 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2725 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2726 making another buffer current. (Bug#10114)
2728 2011-11-23 Glenn Morris <rgm@gnu.org>
2730 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2732 2011-11-23 Chong Yidong <cyd@gnu.org>
2734 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2735 using it (Bug#5984).
2737 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2739 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2740 and header-lines, as they don't have one computed for them.
2743 * .gdbinit (prow): Make displayed values more self-explaining.
2744 Add row's hash code.
2746 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2748 * process.c (wait_reading_process_output): Fix asynchrounous
2749 GnuTLS socket handling on some versions of the GnuTLS library.
2750 (wait_reading_process_output): Add comment and URL.
2752 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2754 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2756 2011-11-21 Chong Yidong <cyd@gnu.org>
2758 * window.c (Fnext_window, Fprevious_window): Doc fix.
2760 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2762 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2764 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2766 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2768 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2770 * window.c (Fset_window_combination_limit): Rename argument
2772 (Vwindow_combination_limit): Remove "status" from doc-string.
2774 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2776 * m/ibms390.h: Remove.
2777 * m/ibms390x.h: Don't include "ibms390.h".
2779 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2781 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2782 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2784 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2786 * casetab.c (Fset_case_table):
2787 * charset.c (Fcharset_after): Fix typos.
2789 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2791 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2792 Otherwise, valgrind does not work on some platforms.
2793 Problem reported by Andreas Schwab in
2794 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2795 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2796 is set, removing the need for VIRT_ADDRESS_VARIES.
2797 (PURE_P): Use a more-efficient implementation that needs just one
2798 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2799 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2800 to 4 (xorl, subq, cmpq, setbe).
2801 * alloc.c (pure): Always extern now, since that's the
2802 VIRT_ADDR_VARIES behavior.
2803 (PURE_POINTER_P): Use a single comparison, not two, for
2804 consistency with the new puresize.h.
2805 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2806 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2807 Remove VIRT_ADDR_VARIES no longer needed.
2809 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2811 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2812 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2813 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2814 behave as if the cursor position were at the window margin.
2816 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2817 and the cursor position is out of bounds, behave as if the cursor
2818 position were at the window margin. (Bug#10075)
2820 2011-11-18 Chong Yidong <cyd@gnu.org>
2822 * window.c (Fwindow_combination_limit): Make first argument
2823 non-optional, since it is meaningless for live windows like the
2826 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2828 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2830 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2832 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2833 (graft_intervals_into_buffer): Simplify.
2835 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2837 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2838 hash values of the two rows.
2839 (copy_row_except_pointers): Preserve the used[] arrays and the
2840 hash values of the two rows. (Bug#10035)
2841 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2843 * xdisp.c (row_hash): New function, body extracted from
2844 compute_line_metrics.
2845 (compute_line_metrics): Call row_hash, instead of computing the
2848 * dispnew.c (verify_row_hash): Call row_hash for computing the
2849 hash code of a row, instead of duplicating code from xdisp.c.
2851 * dispextern.h (row_hash): Add prototype.
2853 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2855 * frame.c (delete_frame): Don't delete the terminal when the last
2856 X frame is closed if emacs is built with GTK toolkit.
2858 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2860 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2862 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2864 * window.c (Vwindow_splits): Rename to
2865 Vwindow_combination_resize. Suggested by Juri Linkov.
2866 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2869 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2871 * nsfns.m (Fns_font_name):
2872 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2874 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2876 * window.h (window): Rename slot "nest" to "combination_limit".
2877 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2878 (Fset_window_nest): Rename to Fset_window_combination_limit.
2879 (Vwindow_nest): Rename to Vwindow_combination_limit.
2880 (recombine_windows, make_parent_window, make_window)
2881 (Fsplit_window_internal, saved_window)
2882 (Fset_window_configuration, save_window_save): Rename all
2883 occurrences of window_nest to window_combination_limit.
2885 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2887 * image.c (imagemagick_load_image): Fix typo.
2889 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2891 * xdisp.c (display_line): Move the call to
2892 highlight_trailing_whitespace before the call to
2893 compute_line_metrics, since the latter needs to see the final
2894 faces of all the glyphs to compute ROW's hash value.
2895 Fixes assertion violations in row_equal_p. (Bug#10035)
2897 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2899 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2900 just return (bug#10044).
2902 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2904 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2905 with user-defined heap size. Bump the default size of the temacs
2906 heap to 27MB, to avoid memory warning when running temacs.
2907 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2909 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2910 current_matrix and desired_matrix. (Bug#9990)
2911 (verify_row_hash) [XASSERTS]: New function.
2912 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2913 that the hash value of glyph rows is correct.
2915 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2917 * window.h (window): Remove splits slot.
2918 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2919 (Fdelete_other_windows_internal, make_parent_window)
2920 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2921 (Fset_window_configuration, save_window_save): Don't deal with
2922 split status of windows.
2923 (saved_window): Remove splits slot.
2924 (Vwindow_splits): Rewrite doc-string.
2926 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2928 * xfns.c (unwind_create_frame):
2929 * nsfns.m (unwind_create_frame):
2930 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2931 Vframe_list (Bug#9999).
2933 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2935 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2937 2011-11-11 Kenichi Handa <handa@m17n.org>
2939 * callproc.c (Fcall_process): Set the member dst_multibyte of
2942 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2944 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2945 avoid a crash (bug#9496).
2947 2011-11-09 Chong Yidong <cyd@gnu.org>
2949 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2950 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2952 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2954 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2956 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2958 Avoid some portability problems by eschewing 'extern inline' functions.
2959 The trivial performance wins aren't worth the portability hassles; see
2960 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2962 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2963 (window_box_width, window_box_left, window_box_left_offset)
2964 (window_box_right, window_box_right_offset): Undo previous change,
2965 by removing the "extern"s.
2966 * intervals.c (adjust_intervals_for_insertion)
2967 (adjust_intervals_for_deletion): Undo previous change,
2968 making these static again.
2969 (offset_intervals, temp_set_point_both, temp_set_point)
2970 (copy_intervals_to_string): No longer inline.
2971 * xdisp.c (window_text_bottom_y, window_box_width)
2972 (window_box_height, window_box_left_offset)
2973 (window_box_right_offset, window_box_left, window_box_right)
2974 (window_box): No longer inline.
2976 2011-11-08 Chong Yidong <cyd@gnu.org>
2978 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2979 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2980 Signal an error if not a live window.
2981 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2982 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2984 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2986 * lisp.h (syms_of_abbrev): Remove declaration.
2987 Reported by CHENG Gao <chenggao@royau.me>.
2989 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2991 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2992 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2993 of temacs in GUI mode.
2995 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2997 * window.h: Declare delete_all_child_windows instead of
2998 delete_all_subwindows.
2999 * window.c (Fwindow_nest, Fset_window_nest)
3000 (Fset_window_new_total, Fset_window_new_normal)
3001 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3002 (delete_all_subwindows): Rename to delete_all_child_windows.
3003 (Fdelete_other_windows_internal, Fset_window_configuration):
3004 Call delete_all_child_windows instead of delete_all_subwindows.
3005 * frame.c (delete_frame): Call delete_all_child_windows instead
3006 of delete_all_subwindows.
3008 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3010 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3011 This is also needed for porting to any host where GC_MARK_STACK is
3012 not GC_MAKE_GCPROS_NOOPS.
3013 (which_symbols): Use it.
3015 2011-11-07 Kenichi Handa <handa@m17n.org>
3017 * coding.c (coding_set_destination): Check coding->src_pos only
3018 when coding->src_object is a buffer (bug#9910).
3020 * process.c (send_process): Set the member src_multibyte of coding
3021 to 0 (bug#9911) when sending a unibyte text.
3023 * callproc.c (Fcall_process): Set the member src_multibyte of
3024 process_coding to 0 (bug#9912).
3026 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3028 * xmenu.c (cleanup_widget_value_tree): New function.
3029 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3030 calling free_menubar_widget_value_tree directly (Bug#9830).
3032 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3034 Fix some portability problems with 'inline'.
3035 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3036 (window_box_width, window_box_left, window_box_left_offset)
3037 (window_box_right, window_box_right_offset): Declare extern.
3038 Otherwise, these inline functions do not conform to C99 and
3039 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3040 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3041 * intervals.c (adjust_intervals_for_insertion)
3042 (adjust_intervals_for_deletion): Now extern, because otherwise the
3043 extern inline functions 'offset_intervals' couldn't refer to it.
3044 (static_offset_intervals): Remove.
3045 (offset_intervals): Rewrite using the old contents of
3046 static_offset_intervals. The old version didn't conform to C99
3047 because an extern inline function contained a reference to an
3048 identifier with static linkage.
3050 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3052 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3055 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3057 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3058 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3059 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3060 return Qleft_to_right.
3062 2011-11-06 Chong Yidong <cyd@gnu.org>
3064 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3065 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3066 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3067 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3068 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3069 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3070 (Fwindow_vscroll): Doc fix.
3071 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3072 argument, since it makes no sense to pass a live window and for
3073 consistency with window-child.
3075 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3077 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3080 2011-11-05 Jason Rumney <jasonr@gnu.org>
3082 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3083 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3085 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3086 bitwise arithmetic preventing use of unicode-sip and non-truetype
3089 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3091 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3094 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3095 initialization code to keep similarity to xfns.c after changes
3098 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3100 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3101 (unwind_create_frame): New function (Bug#9943).
3102 (Fx_create_frame): Restructure code to be more similar to the one in
3103 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3104 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3105 Move terminal->reference_count++ just before making the frame official
3108 * nsterm.m (x_free_frame_resources): New function.
3109 (x_destroy_window): Move code to x_free_frame_resources.
3111 * xfns.c (unwind_create_frame): Fix comment.
3112 (Fx_create_frame, x_create_tip_frame):
3113 Move terminal->reference_count++ just before making the frame
3114 official. Move initialization of image_cache_refcount and
3115 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3117 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3119 Support MSVC build with newer versions of Visual Studio.
3120 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3121 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3124 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3125 which are not supported by MSVC.
3126 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3127 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3129 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3131 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3133 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3135 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3137 Support MSVC build with newer versions of Visual Studio.
3138 * w32.c: Don't include w32api.h for MSVC.
3139 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3141 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3142 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3143 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3144 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3146 (alloca) [_MSC_VER]: Define to _alloca.
3148 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3150 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3152 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3154 * xdisp.c (note_mouse_highlight): If either of
3155 previous/next-single-property-change returns nil, treat that as
3156 the beginning or the end of the buffer. (Bug#9955)
3158 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3160 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3161 label is not null (Bug#9951).
3162 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3165 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3167 * window.c (Fwindow_body_size): Mention in the doc string that the
3168 return value is in frame's canonical units. (Bug#9949)
3170 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3172 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3174 * w32fns.c (unwind_create_frame): If needed, free the glyph
3175 matrices of the partially constructed frame. (Bug#9943)
3176 * xfns.c (unwind_create_frame): Likewise.
3178 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3180 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3181 Don't stop backward scan on the continuation glyph, even though
3182 its CHARPOS is positive.
3183 (mouse_face_from_buffer_pos, note_mouse_highlight):
3184 Rename cover_string to disp_string.
3186 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3188 * window.c (temp_output_buffer_show): Don't use
3189 Vtemp_buffer_show_specifiers.
3190 (Vtemp_buffer_show_specifiers): Remove unused variable.
3192 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3194 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3195 past the beginning of the current glyph matrix.
3197 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3199 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3200 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3201 HAVE_GTK3 (Bug#9869).
3203 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3204 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3206 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3208 * xterm.c: Declare x_handle_net_wm_state to return int.
3209 (handle_one_xevent): Check if we are iconified but don't have
3210 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3211 (get_current_wm_state): Return non-zero if not hidden,
3212 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3213 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3214 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3215 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3217 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3219 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3220 so that this new function doesn't get optimized away by a
3221 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3223 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3225 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3227 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3229 Fix the `xbytecode' command.
3230 * .gdbinit (xprintbytestr): New command.
3231 (xwhichsymbols): Rename from `which'; all callers changed.
3232 (xbytecode): Print the byte-code string as well.
3234 2011-10-29 Kim Storm <storm@cua.dk>
3236 * alloc.c (which_symbols): New function.
3238 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3240 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3243 2011-10-29 Glenn Morris <rgm@gnu.org>
3245 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3246 Not clear what it was for, and it causes various bugs. (Bug#9839)
3248 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3250 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3251 possible random value that matches one of those tested as
3252 condition to clear the mouse face.
3254 2011-10-28 Chong Yidong <cyd@gnu.org>
3256 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3258 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3260 * window.c (make_window): Initialize phys_cursor_on_p.
3262 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3264 * lisp.h (struct Lisp_Symbol): Update comments.
3266 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3268 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3270 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3272 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3273 <oslsachem@gmail.com> for helping to debug this.
3275 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3276 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3277 (g_b_init_get_glyph_outline_w): New static variables.
3278 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3279 (GetGlyphOutlineW_Proc): New typedefs.
3280 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3281 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3283 (w32font_open_internal, compute_metrics):
3284 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3285 instead of calling the "wide" APIs directly.
3287 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3289 * w32.h (syms_of_w32font): Add prototype.
3291 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3293 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3294 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3295 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3296 (Fmove_to_window_line): Doc fix.
3298 2011-10-27 Chong Yidong <cyd@gnu.org>
3300 * process.c (make_process): Set gnutls_state to NULL.
3302 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3303 non-NULL, regardless of GNUTLS_INITSTAGE.
3304 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3305 an error. Set process slots as soon as we allocate them.
3307 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3309 2011-10-27 Chong Yidong <cyd@gnu.org>
3311 * gnutls.c (emacs_gnutls_deinit): New function.
3312 Deallocate credentials structures as well as calling gnutls_deinit.
3313 (Fgnutls_deinit, Fgnutls_boot): Use it.
3315 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3316 (deactivate_process): Call emacs_gnutls_deinit.
3318 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3320 * image.c (x_create_x_image_and_pixmap):
3321 * w32.c (sys_rename, w32_delayed_load):
3322 * w32font.c (fill_in_logfont):
3323 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3325 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3327 * w32fns.c (w32_default_color_map): New function,
3328 extracted from Fw32_default_color_map.
3329 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3331 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3333 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3335 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3337 * keyboard.c (test_undefined): New function (bug#9751).
3338 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3340 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3342 * sysdep.c (init_sys_modes): Fix the check for the controlling
3343 terminal (Bug#6649).
3345 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3347 * dispextern.h (struct bidi_it): New member next_en_type.
3349 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3350 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3351 current character, check also for next_en_type being WEAK_EN.
3352 (bidi_resolve_weak): Don't enter the expensive loop if the current
3353 position is before next_en_pos. Record the bidi type of the first
3354 non-ET, non-BN character we find, in addition to its position.
3355 (bidi_level_of_next_char): Invalidate next_en_type when
3356 next_en_pos is over-stepped.
3358 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3360 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3361 * editfns.c: Rewrite current-time-zone so that it invokes
3362 the equivalent of (format-time-string "%Z") to get the time zone name.
3363 This fixes a bug when the time zone name contains characters that
3364 need converting from the system time locale to Emacs internal format.
3365 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3366 that patch fixed format-time-string to do the conversion, but
3367 I forgot to fix current-time-zone.
3368 (format_time_string): New function, containing most of
3369 what Fformat_time_string used to contain.
3370 (Fformat_time_string): Rewrite in terms of format_time_string.
3371 This doesn't change this function's behavior.
3372 (current-time-zone): Rewrite to use format_time_string.
3373 This fixes the bug reported by Michael Schierl in
3374 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3375 Jason Rumney's 2007-06-07 change worked around this bug, but
3377 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3379 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3381 * xdisp.c (start_display): If the character at POS is displayed
3382 via a display vector, reset IT->current.dpvec_index to zero.
3383 (try_window_reusing_current_matrix): If a line ends in a display
3384 vector or the next line starts in a display vector, continue
3385 redrawing the window even though the character position of
3386 start_row was reached.
3389 2011-10-18 Chong Yidong <cyd@gnu.org>
3391 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3392 with nobreak-char-display too.
3394 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3396 Fix part 3 of bug#9771.
3397 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3398 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3399 non-neutral characters if the current character is a paragraph
3400 separator (a.k.a. Newline). This avoids running the same
3401 expensive loop twice, once when we consume the preceding newline
3402 and the other time when the line actually needs to be displayed.
3403 Avoid the loop when we see neutrals on the base embedding level
3404 following a character whose directionality is the same as the
3405 paragraph's. This avoids running the expensive loop when a line
3406 ends in a long sequence of neutrals, like control characters.
3407 Add assertion against STRONG_AL type. Slightly rearrange code
3408 that determines the type of a neutral given the first non-neutral
3410 (bidi_level_of_next_char): Set next_en_pos to zero when
3411 invalidating its info.
3413 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3415 * xdisp.c (push_display_prop): Determine whether to record string
3416 or buffer position by IT->string, not by IT->method. Allow
3417 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3418 (move_it_vertically_backward): Don't look for character position
3419 immediately after the newline when in a continuation line.
3422 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3424 * window.c (coordinates_in_window): Rewrite and delabelize
3425 vertical border check. (Bug#5357) (Bug#9618)
3427 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3429 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3430 errors in XSetWindowBorder (bug#9310).
3432 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3434 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3435 avoid crash when xmalloc overrun checking is enabled.
3437 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3439 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3440 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3441 cursor motion with <left> and <right> arrow keys.
3443 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3444 some callers set that themselves.
3446 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3448 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3449 display string and the previous row comes from the same string and
3450 is empty. (Bug#9739) (Bug#9738)
3452 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3454 * doc.c (get_doc_string): Encode file name (bug#9735).
3456 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3458 * bidi.c (bidi_level_of_next_char):
3459 * xdisp.c (get_visually_first_element): Remove old incorrect
3460 comments regarding the Unicode Line Separator character.
3462 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3464 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3466 * alloc.c (Fgc_status): Do not access beyond zombies array
3467 boundary if nzombies > MAX_ZOMBIES.
3468 * alloc.c (dump_zombies): Add missing format specifier.
3470 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3472 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3473 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3475 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3476 Some packages use them to denote characters with modifiers.
3478 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3480 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3481 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3482 matching a pp-number. Rename parameter var to var1.
3484 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3486 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3488 2011-10-08 Glenn Morris <rgm@gnu.org>
3490 * callint.c (Fcall_interactively): Give a more explicit error for the
3491 'c' case with a non-character input. (Bug#8479)
3493 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3495 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3497 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3498 lines that are hscrolled on the left.
3500 * dispnew.c (buffer_posn_from_coords): Account for a possible
3501 presence of header-line. (Bug#4426)
3503 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3505 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3506 Don't advertise functionality which we discourage or doesn't work.
3508 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3510 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3511 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3512 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3513 this makes Emacs dump core during garbage collection on rare
3514 occasions. sizeof is obviously inferior to offsetof here, so
3515 stick with offsetof.
3516 (GC_POINTER_ALIGNMENT): New macro.
3517 (mark_memory): Omit 3rd (offset) arg; caller changed.
3518 Don't assume EMACS_INT alignment is the same as pointer alignment.
3520 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3522 * keyboard.c (read_key_sequence_remapped): New var.
3523 (read_key_sequence): Compute remapping in the right buffer.
3524 (command_loop_1): Use read_key_sequence's remapping directly.
3526 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3528 * dired.c (file_name_completion): Don't expand file name.
3529 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3530 before checking file name handler.
3532 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3533 they've been requested explicitly (bug#9591).
3535 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3537 * keymap.c (Fsingle_key_description): Use make_specified_string
3538 instead of build_string to build string from push_key_description.
3541 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3543 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3544 This fixes a Y2038 bug on 64-bit hosts.
3545 * buffer.c (reset_buffer):
3546 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3547 (Fclear_buffer_auto_save_failure):
3548 Use 0, not -1, to represent an unset failure time, since time_t
3549 might not be signed.
3551 Remove dependency on glibc malloc internals.
3552 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3553 Move back here from lisp.h, but with their new implementations.
3554 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3555 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3556 * charset.c (charset_table_init): New static var.
3557 (syms_of_charset): Use it instead of xmalloc. This removes a
3558 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3559 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3560 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3561 Move back to alloc.c.
3562 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3563 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3565 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3567 * nsterm.m (windowDidResize): Call x_set_window_size only when
3568 ns_in_resize is true. Otherwise set pixelwidth/height and
3569 call change_frame_size (Bug#9628).
3571 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3573 Port --enable-checking=all to Fedora 14 x86-64.
3574 * charset.c (syms_of_charset): Also account for glibc malloc's
3575 internal overhead when calculating the initial malloc maximum.
3577 Port --enable-checking=all to Fedora 14 x86.
3578 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3580 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3581 (overrun_check_realloc, overrun_check_free):
3582 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3583 That way, xmalloc returns a properly-aligned pointer even if
3584 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3585 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3586 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3587 into account when calculating the initial malloc maximum.
3588 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3589 Move here from alloc.c, so that charset.c can use it too.
3590 Properly align; the old code wasn't right for common 32-bit hosts
3591 when configured with --enable-checking=all.
3592 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3593 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3595 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3597 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3600 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3602 * xdisp.c (compute_display_string_end): If there's no display
3603 string at CHARPOS, return -1.
3605 * bidi.c (bidi_fetch_char): When compute_display_string_end
3606 returns a negative value, treat the character as a normal
3607 character not covered by a display string. (Bug#9624)
3609 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3611 * lread.c (Fread_from_string): Fix typo in docstring.
3613 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3615 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3616 newline, reseat the iterator instead of bidi-iterating there one
3617 character at a time. (Bug#9610)
3618 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3619 TO_CHARPOS if the bidi iterator is at base embedding level.
3621 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3623 * lread.c (readevalloop): Use correct code for NBSP.
3624 (read1): Likewise. (Bug#9608)
3626 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3628 * dbusbind.c (Fdbus_register_signal): When service is not
3629 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3631 2011-09-25 Glenn Morris <rgm@gnu.org>
3633 * buffer.c (truncate-lines): Doc fix.
3635 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3637 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3638 (Fset_window_next_buffers): Doc fix.
3640 2011-09-24 Glenn Morris <rgm@gnu.org>
3642 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3644 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3646 Fix minor problems found by static checking.
3647 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3648 * indent.c (Fvertical_motion): Fix == vs = typo.
3650 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3652 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3653 Default value is now t. Doc fix.
3655 * indent.c (Fvertical_motion): Compute and apply the overshoot
3656 logic when moving up, not only when moving down. Fix the
3657 confusing name and values of the it_overshoot_expected variable;
3658 logic changes accordingly. (Bug#9254) (Bug#9549)
3660 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3661 CHARPOS is covered by a display string which includes newlines.
3662 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3663 is covered by a display string with embedded newlines.
3665 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3667 * dbusbind.c (Fdbus_register_signal): Add match rule to
3668 Vdbus_registered_objects_table. (Bug#9581)
3669 (Fdbus_register_method, Vdbus_registered_objects_table):
3672 2011-09-24 Jim Meyering <meyering@redhat.com>
3674 do not ignore write error for any output size
3675 The previous change was incomplete.
3676 While it makes emacs --batch detect the vast majority of stdout
3677 write failures, errors were still ignored whenever the output size is
3678 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3679 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3680 && echo FAIL: ignored write error
3681 FAIL: ignored write error
3682 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3683 && echo FAIL: ignored write error
3684 FAIL: ignored write error
3685 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3687 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3689 * emacs.c (Fkill_emacs): In noninteractive mode exit
3690 non-successfully if a write error occurred on stdout. (Bug#9574)
3692 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3694 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3697 * dispextern.h (struct it): Update the comment documenting what
3700 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3702 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3703 a display string, extend search for cursor position to end of row.
3704 (find_row_edges): If the row ends in a newline from a display
3705 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3706 Handle the case of a display string with multiple newlines.
3707 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3708 non-empty line. Fixes confusing cursor motion with arrow keys at
3709 the beginning of a line that starts with whitespace.
3711 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3713 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3716 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3718 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3721 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (display_line): Record maximum and minimum buffer
3724 positions even if no glyphs were produced (e.g., by a zero-width
3725 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3726 buffer positions that will be removed from the glyph row because
3728 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3729 column is beyond frame width: don't subtract 1 "pixel" when
3730 computing width of the stretch.
3731 (reseat_at_next_visible_line_start): Undo the change made on
3732 2011-09-17 that saved paragraph information and restored it after
3733 the call to `reseat'. (Bug#9545)
3735 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3737 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3738 and turn window cursor on if cleared (Bug#9415).
3740 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3742 * search.c (boyer_moore): Take unibyte characters from pattern
3743 literally. (Bug#9458)
3745 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3747 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3749 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3751 Fix minor problem found by static checking.
3752 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3753 initialized, to pacify gcc -Wuninitialized.
3755 * fileio.c: Report proper errno when syscall falls.
3756 (Finsert_file_contents): Save and restore errno,
3757 so that report_file_error outputs the correct diagnostic.
3758 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3760 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3762 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3764 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3766 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3767 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3769 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3771 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3772 about the current paragraph and restore it after the call to reseat.
3774 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3775 (bidi_find_paragraph_start): Search back for paragraph beginning
3776 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3777 (bidi_move_to_visually_next): Only trigger paragraph-related
3778 computations when the last character is a newline or at EOB, not
3779 just any NEUTRAL_B. (Bug#9470)
3781 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3782 truncated lines if point is covered by a display string. (Bug#9524)
3784 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3786 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3787 (cons_to_x_long): New function.
3788 (lisp_data_to_selection_data): Use it. Correct the test for
3789 short-versus-long data; it was negated. Break out of vector
3790 loop, for efficiency, when a long datum is discovered.
3792 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3794 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3796 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3798 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3799 GCC PR/17406) by declaring this function with external scope.
3801 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3803 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3804 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3806 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3808 * editfns.c (Fformat): Correctly handle text properties on "%%".
3810 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3812 * xterm.c (x_draw_composite_glyph_string_foreground):
3813 * w32term.c (x_draw_composite_glyph_string_foreground):
3814 * term.c (encode_terminal_code):
3815 * composite.c (composition_update_it, get_composition_id):
3816 * xdisp.c (get_next_display_element)
3817 (fill_composite_glyph_string): Add comments about special meaning
3818 of TAB characters in a composition.
3820 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3822 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3823 This occurs when processing a multibyte format.
3824 Problem reported by Wolfgang Jenker.
3826 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3828 * xdisp.c (try_cursor_movement): Only check for exact match if
3829 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3831 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3833 Remove unused external symbols.
3834 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3835 * xdisp.c (calc_pixel_width_or_height): Now static.
3836 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3837 * indent.c (check_display_width):
3838 * w32term.c: Fix comment to match code.
3839 * xterm.c, xterm.h (x_catching_errors): Remove.
3841 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3843 * xselect.c: Use signed conversions more consistently (Bug#9498).
3844 (selection_data_to_lisp_data): Assume incoming selection data are
3845 signed integers, not unsigned. This is to be consistent with
3846 outgoing selection data, which was modified to use signed integers
3847 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3848 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3849 expects long, not unsigned long.
3851 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3853 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3854 computation of loop end. Reported by Johan Bockgård
3857 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3859 * frame.c (Fother_visible_frames_p): Function deleted.
3861 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3863 * indent.c (compute_motion): Process display vector front to back
3864 rather than the other way around. (Bug#2496)
3866 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3868 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3870 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3872 * minibuf.c (Fread_from_minibuffer): Doc fix.
3874 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3876 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3877 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3879 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3881 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3882 value for non-existent files.
3884 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3886 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3887 set its "size" to -1. This will set the modtime_size field of
3888 the corresponding buffer to -1, which is what
3889 verify-visited-file-modtime expects for files that do not exist.
3892 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3894 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3896 * lisp.h: ... from here. push_key_description is no longer
3897 defined in keyboard.c, so its declaration should not be in
3898 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3899 logically belongs with push_key_description.
3901 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3903 * buffer.h: Include <sys/types.h> instead of <time.h>.
3904 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3905 Problem reported by Herbert J. Skuhra.
3907 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909 * xml.c (parse_region): Make the parsing work for
3910 non-comment-starting XML files again (bug#9144).
3912 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3914 * image.c (gif_load): Fix calculation of bottom and right corner.
3917 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3919 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3920 redisplay in small windows.
3922 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3924 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3926 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3928 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3929 Operate on live windows only.
3931 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3933 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3935 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3937 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3938 only under bidi iteration.
3940 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3942 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3944 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3946 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3947 Without this fix, the command to link temacs failed due to an
3948 undefined symbol __builtin_isnan. This is because
3949 /usr/include/iso/math_c99.h #defines isnan(x) to
3950 __builtin_isnan(x), but the bundled gcc, which identifies itself
3951 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3953 * floatfns.c (isnan): #undef, and then #define to a clone of
3955 (Fisnan): Always define, since it's always available now.
3956 (syms_of_floatfns): Always define isnan at the Lisp level.
3958 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3960 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3962 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3964 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3965 The previous code assumed that file offsets (off_t values) fit in
3966 EMACS_INT variables, which is not true on typical 32-bit hosts.
3967 The code messed up by falsely reporting buffer overflow in cases
3968 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3969 when "big" contains more than 2**29 bytes, even though this
3970 inserts just one byte and does not overflow the buffer.
3971 (Finsert_file_contents): Store file offsets as off_t
3972 values, not as EMACS_INT values. Check for overflow when
3973 converting between EMACS_INT and off_t. When checking for
3974 buffer overflow or for overlap, take the offsets into account.
3975 Don't use EMACS_INT for small values where int suffices.
3976 When checking for overlap, fix a typo: ZV was used where
3977 ZV_BYTE was intended.
3978 (Fwrite_region): Don't assume off_t fits into 'long'.
3979 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3981 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3983 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3985 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3987 sprintf-related integer and memory overflow issues (Bug#9412).
3989 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3990 (esprintf, exprintf, evxprintf): New functions.
3991 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3992 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3993 (modify_event_symbol): Do not assume that the length of
3994 name_alist_or_stem is safe to alloca and fits in int.
3995 (Fexecute_extended_command): Likewise for function name and binding.
3996 (Frecursion_depth): Wrap around reliably on integer overflow.
3997 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3998 since some callers pass EMACS_INT values.
3999 (Fsingle_key_description): Don't crash if symbol name contains more
4000 than MAX_ALLOCA bytes.
4001 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4002 (get_minibuffer): Arg is now EMACS_INT, not int.
4003 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4004 (esprintf, exprintf, evxprintf): New decls.
4005 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4007 * dbusbind.c (signature_cat): New function.
4008 (xd_signature, Fdbus_register_signal):
4009 Do not overrun buffer; instead, report string overflow.
4011 * dispnew.c (add_window_display_history): Don't overrun buffer.
4012 Truncate instead; this is OK since it's just a log.
4014 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4015 even if the time zone offset is outlandishly large.
4016 Don't mishandle offset == INT_MIN.
4018 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4019 when creating daemon; the previous buffer-overflow check was incorrect.
4021 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4022 which has the guts of the old verror function.
4024 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4025 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4027 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4028 (font_unparse_xlfd): Don't blindly alloca long strings.
4029 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4030 fits in int, when using sprintf. Use single snprintf to count
4031 length of string rather than counting it via multiple sprintfs;
4032 that's simpler and more reliable.
4033 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4034 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4035 sprintf, in case result does not fit in int.
4037 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4038 (fontset_from_font): Print it.
4040 * frame.c (tty_frame_count): Now printmax_t, not int.
4041 (make_terminal_frame, set_term_frame_name): Print it.
4042 (x_report_frame_params): In X, window IDs are unsigned long,
4043 not signed long, so print them as unsigned.
4044 (validate_x_resource_name): Check for implausibly long names,
4045 and don't assume name length fits in 'int'.
4046 (x_get_resource_string): Don't blindly alloca invocation name;
4047 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4050 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4051 (xg_check_special_colors, xg_set_geometry):
4052 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4054 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4055 Use esprintf, not sprintf, in case result does not fit in int.
4057 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4058 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4059 it as a large positive number.
4060 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4061 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4063 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4064 in case result does not fit in int.
4066 * print.c (float_to_string): Detect width overflow more reliably.
4067 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4068 buffer overrun. Don't assume list length fits in 'int'. Treat
4069 print length of 0 as 0, not as infinity; to be consistent with other
4070 uses of print length in this function. Don't overflow print length
4071 index. Don't assume hash table size fits in 'long', or that
4072 vectorlike size fits in 'unsigned long'.
4074 * process.c (make_process): Use printmax_t, not int, to format
4075 process-name gensyms.
4077 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4079 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4080 to avoid potential buffer overrun.
4082 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4083 if X resource line is longer than 512 bytes.
4085 * xfns.c (x_window): Make sprintf buffer a bit bigger
4086 to avoid potential buffer overrun.
4088 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4090 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4092 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4094 Integer overflow fixes for scrolling, etc.
4095 Without these, Emacs silently mishandles large integers sometimes.
4096 For example, "C-u 4294967297 M-x recenter" was treated as if
4097 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4099 * xdisp.c (try_window_id): Check Emacs fixnum range before
4100 converting to 'int'.
4102 * window.c (window_scroll_line_based, Frecenter):
4103 Check that an Emacs fixnum is in range before assigning it to 'int'.
4104 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4105 values converted from Emacs fixnums.
4106 (Frecenter): Don't wrap around a line count if it is out of 'int'
4107 range; instead, treat it as an extreme value.
4108 (Fset_window_configuration, compare_window_configurations):
4109 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4111 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4112 that can exceed INT_MAX. Check that EMACS_INT value is in range
4113 before assigning it to the (possibly-narrower) index.
4114 (match_limit): Don't assume that a fixnum can fit in 'int'.
4116 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4119 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4120 (Fvertical_motion): Don't wrap around LINES values that don't fit
4121 in 'int'. Instead, treat them as extreme values. This is good
4122 enough for windows, which can't have more than INT_MAX lines anyway.
4124 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126 * Require libxml/parser.h to avoid compilation warning.
4128 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4130 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4131 since this reportedly can destroy thread storage.
4133 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4135 * syntax.c (find_defun_start): Update all cache variables if
4136 exiting early (Bug#9401).
4138 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4140 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4142 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4143 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4144 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4146 * term.c (tty_append_glyph): New function.
4147 (produce_stretch_glyph): Static function and its prototype deleted.
4149 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4152 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4154 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4155 when checking :margin (Bug#9390).
4156 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4157 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4158 so that the name doesn't mislead. All uses changed.
4160 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4162 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4165 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4167 * xdisp.c (move_it_to): Don't bail out early when reaching
4168 position beyond to_charpos, if we are scanning backwards.
4169 (move_it_vertically_backward): When DY == 0, make sure we get to
4170 the first character in the line after the newline.
4172 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4174 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4175 (ccl_driver): Do not generate an out-of-range pointer.
4176 (Fccl_execute_on_string): Remove unnecessary check for
4177 integer overflow, noted by Stefan Monnier in
4178 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4179 Remove a FIXME that didn't need fixing.
4180 Simplify the newly-introduced buffer reallocation code.
4182 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4184 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4186 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4188 Integer and memory overflow issues (Bug#9196).
4190 * doc.c (get_doc_string): Rework so that
4191 get_doc_string_buffer_size is the actual buffer size, rather than
4192 being 1 less than the actual buffer size; this makes xpalloc more
4195 * image.c (x_allocate_bitmap_record, cache_image):
4196 * xselect.c (Fx_register_dnd_atom):
4197 Simplify previous changes by using xpalloc.
4199 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4200 since either will do and ptrdiff_t is convenient with xpalloc.
4202 * charset.c (charset_table_size)
4203 (struct charset_sort_data.priority): Now ptrdiff_t.
4204 (charset_compare): Don't overflow if priorities differ greatly.
4205 (Fsort_charsets): Don't assume list length fits in int.
4206 Check for size-calculation overflow when allocating sort data.
4207 (syms_of_charset): Allocate an initial charset table that is
4208 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4210 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4212 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4213 The actual value is always <= INT_MAX, and leaving it unsigned made
4214 overflow checking harder.
4216 * dispextern.h (struct glyph_matrix.rows_allocated)
4217 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4218 with xpalloc. The values are still always <= INT_MAX.
4220 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4222 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4223 (SAFE_NALLOCA): New macro.
4225 * region-cache.c (struct boundary.pos, find_cache_boundary)
4226 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4227 (set_cache_region, invalidate_region_cache)
4228 (revalidate_region_cache, know_region_cache, region_cache_forward)
4229 (region_cache_backward, pp_cache):
4230 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4231 so that ptrdiff_t * can be passed to xpalloc.
4232 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4233 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4234 (pp_cache): Don't assume cache_len fits in int.
4235 * region-cache.h: Adjust extern decls to match.
4237 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4238 EMACS_INT, since either will do, for xpalloc.
4240 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4241 (xnmalloc, xnrealloc, xpalloc): New functions.
4243 * bidi.c (bidi_shelve_header_size): New constant.
4244 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4245 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4247 * bidi.c (bidi_cache_shrink):
4248 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4250 Don't update size of array until after memory allocation succeeds,
4251 because xmalloc/xrealloc may not return.
4252 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4253 now that we have proper integer overflow checking.
4254 (record_overlay_string, overlay_strings): Catch overflows when
4255 calculating size of overlay_str_buf.
4257 * callproc.c (Fcall_process): Check for size overflow when
4258 calculating size of args2.
4259 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4260 Normally we prefer signed values, but sticking with ptrdiff_t would
4261 require adding more-complicated checks.
4263 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4264 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4265 Redo buffer-overflow calculations to avoid integer overflow.
4266 Add a FIXME comment where memory seems to be over-allocated.
4268 * character.c (Fstring): Check for size-calculation overflow.
4270 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4271 unnecessary integer overflow. Check for size overflow.
4272 (encode_coding_object): Don't update size until xmalloc succeeds.
4274 * composite.c (get_composition_id): Check for overflow in glyph
4275 length calculations.
4277 Integer and memory overflow fixes for display code.
4278 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4279 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4280 (scrolling_window): Check for overflow in size calculations.
4281 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4282 Don't assume glyph table len fits in int.
4283 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4284 (row_table_size): Now ptrdiff_t, not int.
4285 (scrolling_window): Avoid overflow in size calculations.
4286 Don't update size until allocation succeeds.
4287 * fns.c (concat): Check for overflow in size calculations.
4288 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4289 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4290 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4292 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4293 (get_doc_string): Check for size calculation overflow.
4294 Don't update size until allocation succeeds.
4295 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4296 EMACS_INT, where ptrdiff_t will do.
4297 (Fsubstitute_command_keys): Check for string overflow.
4299 * editfns.c (set_time_zone_rule): Don't assume environment length
4301 (message_length): Now ptrdiff_t, not int.
4302 (Fmessage_box): Don't update size until allocation succeeds.
4303 Don't assume message length fits in int.
4304 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4306 * emacs.c (main): Do not reallocate argv, since there is a null at
4307 the end that can be overwritten, and this way there's no need to
4308 worry about size-calculation overflow.
4309 (sort_args): Check for size-calculation overflow.
4311 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4313 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4315 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4316 (x_set_scroll_bar_width, x_figure_window_size):
4317 Check for integer overflow.
4318 (x_set_alpha): Do not assume XINT fits in int.
4320 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4321 This is for the members text_lines, text_cols, total_lines, total_cols,
4322 where the system imposes an 'int' limit.
4324 * fringe.c (Fdefine_fringe_bitmap):
4325 Don't update size until alloc works.
4327 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4328 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4330 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4331 Check for size-calculation overflow.
4332 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4333 do, as we prefer signed integers.
4334 (id_to_widget.max_size, id_to_widget.used)
4335 (xg_store_widget_in_map, xg_remove_widget_from_map)
4336 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4337 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4338 Use and return ptrdiff_t, not int.
4339 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4340 * gtkutil.h: Change prototypes to match the above.
4342 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4343 are duplicate now that they've been promoted to lisp.h.
4344 (x_allocate_bitmap_record, x_alloc_image_color)
4345 (make_image_cache, cache_image, xpm_load):
4346 Don't update size until alloc is done.
4347 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4349 Check for size calculation overflow.
4350 (ct_colors_allocated_max): New constant.
4351 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4354 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4355 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4356 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4357 Use ptrdiff_t, not int, to count maps.
4358 (read_char_minibuf_menu_prompt): Check for overflow in size
4359 calculations. Don't update size until allocation succeeds.
4360 Redo calculations to avoid overflow.
4361 * keyboard.h: Change prototypes to match the above.
4363 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4365 (current_minor_maps): Check for size calculation overflow.
4366 * keymap.h: Change prototypes to match the above.
4368 * lread.c (read1, init_obarray): Don't update size until alloc done.
4370 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4371 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4373 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4374 Now ptrdiff_t, not int.
4375 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4376 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4378 * process.c (Fnetwork_interface_list): Check for overflow
4379 in size calculation.
4381 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4383 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4384 overflow. Don't bother calling xmalloc when xrealloc will do.
4386 * search.c (Freplace_match): Check for size calculation overflow.
4387 (Fset_match_data): Don't assume list lengths fit in 'int'.
4389 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4390 for command line length. Do not attempt to address one before the
4391 beginning of an array, as that's not portable.
4393 * term.c (max_frame_lines): Remove; unused.
4394 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4396 (encode_terminal_code, calculate_costs): Check for size
4397 calculation overflow.
4398 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4399 table lengths and related sizes. Don't update size until alloc
4400 done. Redo calculations to avoid overflow.
4401 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4403 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4404 subtracting pointers.
4405 (gobble_line): Check for overflow more carefully. Don't update size
4408 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4409 Don't update size until alloc done.
4410 Redo size calculations to avoid overflow.
4411 Check for size calculation overflow.
4412 (main) [DEBUG]: Fix typo in invoking tparam1.
4414 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4415 Use ptrdiff_t, not int, for sizes.
4416 (store_mode_line_noprop_char): Don't update size until alloc done.
4418 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4419 Use ptrdiff_t, not int, for sizes.
4420 (Finternal_make_lisp_face, cache_face):
4421 Check for size calculation overflow.
4422 (cache_face): Treat size calculation overflows as if they were
4423 memory exhaustion (the usual treatment), rather than aborting.
4425 * xfns.c (x_encode_text, x_set_name_internal)
4426 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4427 sizes, since they can exceed INT_MAX in size. Check for size
4428 calculation overflow.
4430 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4431 (xg_select): Check for size calculation overflow.
4432 Don't update size until alloc done.
4434 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4435 as sprintf is limited to int lengths.
4437 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4438 (X_LONG_MIN): New macros.
4439 Use them to make the following changes clearer.
4440 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4441 This change doesn't affect the value now, but it may help remind
4442 future maintainers not to raise the value too much later.
4443 (SELECTION_QUANTUM): Remove, replacing with ...
4444 (selection_quantum): ... new function, which avoids overflow.
4446 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4447 assumption that selection length fits in 'int'.
4448 (x_reply_selection_request, x_handle_selection_request)
4449 (x_get_window_property, receive_incremental_selection)
4450 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4451 (lisp_data_to_selection_data, clean_local_selection_data):
4452 Use ptrdiff_t, not int, to record length of selection.
4453 (x_reply_selection_request, x_get_window_property)
4454 (receive_incremental_selection, x_property_data_to_lisp):
4455 Redo calculations to avoid overflow.
4456 (x_reply_selection_request): When sending hint, ceiling it at
4457 X_LONG_MAX rather than relying on wraparound overflow to send
4459 (x_get_window_property, receive_incremental_selection)
4460 (lisp_data_to_selection_data, x_property_data_to_lisp):
4461 Check for size-calculation overflow.
4462 (x_get_window_property, receive_incremental_selection)
4463 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4464 Don't store size until memory allocation succeeds.
4465 (x_get_window_property): Plug memory leak on memory exhaustion.
4466 Don't double-block input; malloc is safe here. Don't assume 2**34
4467 - 4 fits in unsigned long. Add an xassert to check
4468 XGetWindowProperty overflow. Be more careful about overflow
4469 calculations, and distinguish size from memory overflow better.
4470 (receive_incremental_selection): When tracing, don't assume
4471 unsigned int is less than INT_MAX.
4472 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4473 harmful) conversions of unsigned short to int.
4474 (lisp_data_to_selection_data): Don't assume that integers
4475 in the range -65535 through -1 fit in an X unsigned short.
4476 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4477 result parameters unless successful. Rely on cons_to_unsigned
4478 to report problems with elements; the old code wasn't right anyway.
4479 (x_check_property_data): Check for int overflow; we cannot use
4480 a wider type due to X limits.
4481 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4483 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4485 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4486 (x_term_init): Check for size calculation overflow.
4487 (x_color_cells): Don't store size until memory allocation succeeds.
4488 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4489 Don't assume alloca size is less than MAX_ALLOCA.
4490 (x_term_init): Don't assume length fits in int (sprintf is limited
4493 Use ptrdiff_t for composition IDs.
4494 * character.c (lisp_string_width):
4495 * composite.c (composition_table_size, n_compositions)
4496 (get_composition_id, composition_gstring_from_id):
4497 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4498 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4499 * window.c (Frecenter):
4500 Use ptrdiff_t, not int, for composition IDs.
4501 * composite.c (get_composition_id): Check for integer overflow.
4502 * composite.h: Adjust prototypes to match the above changes.
4504 Use ptrdiff_t for hash table indexes.
4505 * category.c (hash_get_category_set):
4506 * ccl.c (ccl_driver):
4507 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4508 * coding.c (coding_system_charset_list, detect_coding_system):
4509 * coding.h (struct coding_system.id):
4510 * composite.c (get_composition_id, gstring_lookup_cache):
4511 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4512 * image.c (xpm_get_color_table_h):
4513 * lisp.h (hash_lookup, hash_put):
4514 * minibuf.c (Ftest_completion):
4515 Use ptrdiff_t for hash table indexes, not int (which is too
4516 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4517 32-bit --with-wide-int hosts).
4519 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4520 Add a FIXME comment about memory leaks.
4521 (syms_of_charset): Don't assume xmalloc returns.
4523 Don't assume that stated character widths fit in int.
4524 * character.c (Fchar_width, c_string_width, lisp_string_width):
4525 * character.h (CHAR_WIDTH):
4526 * indent.c (MULTIBYTE_BYTES_WIDTH):
4527 Use sanitize_char_width to avoid undefined and/or bad behavior
4528 with outlandish widths.
4529 * character.h (sanitize_tab_width): Rename from sanitize_width,
4530 now that we have two such functions. All uses changed.
4531 (sanitize_char_width): New inline function.
4533 Don't assume that tab-width fits in int.
4534 * character.h (sanitize_width): New inline function.
4535 (SANE_TAB_WIDTH): New macro.
4536 (ASCII_CHAR_WIDTH): Use it.
4537 * indent.c (sane_tab_width): Remove. All uses replaced by
4538 SANE_TAB_WIDTH (current_buffer).
4539 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4541 * fileio.c: Integer overflow issues with file modes.
4542 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4544 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4545 Remove unreachable code.
4546 (read_hex, load_charset_map_from_file): Check for integer overflow.
4548 * xterm.c: Don't go over XClientMessageEvent limit.
4549 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4550 (x_send_scroll_bar_event): Likewise. Check that the size does not
4551 exceed limits imposed by XClientMessageEvent, as well as the usual
4552 ptrdiff_t and size_t limits.
4554 * keyboard.c: Overflow, signedness and related fixes.
4555 (make_lispy_movement): Use same integer type in forward decl
4556 that is used in the definition.
4557 (read_key_sequence, keyremap_step):
4558 Change bufsize argument back to int, undoing my 2011-03-30 change.
4559 We prefer signed types, and int is wide enough here.
4560 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4561 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4562 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4563 length, not size_t. Use ptrdiff_t for index, not int.
4564 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4565 possibility of integer overflow.
4567 Overflow, signedness and related fixes for images.
4569 * dispextern.h (struct it.stack[0].u.image.image_id)
4570 (struct_it.image_id, struct image.id, struct image_cache.size)
4571 (struct image_cache.used, struct image_cache.ref_count):
4572 * gtkutil.c (update_frame_tool_bar):
4573 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4574 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4575 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4576 * nsmenu.m (update_frame_tool_bar):
4577 * xdisp.c (calc_pixel_width_or_height):
4578 * xfns.c (image_cache_refcount):
4579 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4580 on typical 64-bit hosts.
4582 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4583 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4584 Omit unnecessary casts to int.
4585 (parse_image_spec): Check that integers fall into 'int' range
4586 when the callers expect that.
4587 (image_ascent): Redo ascent calculation to avoid int overflow.
4588 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4589 (lookup_image): Remove unnecessary tests.
4590 (xbm_image_p): Locals are now of int, not EMACS_INT,
4591 since parse_image_check makes sure they fit into int.
4592 (png_load, gif_load, svg_load_image):
4593 Prefer int to unsigned where either will do.
4594 (tiff_handler): New function, combining the cores of the
4595 old tiff_error_handler and tiff_warning_handler.
4596 This function is rewritten to use vsnprintf and thereby avoid
4597 stack buffer overflows. It uses only the features of vsnprintf
4598 that are common to both POSIX and native Microsoft.
4599 (tiff_error_handler, tiff_warning_handler): Use it.
4600 (tiff_load, gif_load, imagemagick_load_image):
4601 Don't assume :index value fits in 'int'.
4602 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4603 (imagemagick_load_image): Check that crop parameters fit into
4604 the integer types that MagickCropImage accepts. Don't assume
4605 Vimagemagick_render_type has a nonnegative value. Don't assume
4606 size_t fits in 'long'.
4607 (gs_load): Use printmax_t to print the widest integers possible.
4608 Check for integer overflow when computing image height and width.
4610 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4612 * xdisp.c (redisplay_window): Don't force window start if point
4613 will be invisible in the resulting window. (Bug#9324)
4615 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4617 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4618 the display spec is of the form `(space ...)'.
4619 (handle_display_spec): Return the value returned by
4620 handle_single_display_spec, not just 1 or zero.
4621 (handle_single_display_spec): If the display spec is of the form
4622 `(space ...)', and specifies display in the text area, return 2
4624 (try_cursor_movement): Check for the need to scroll more
4625 accurately, and prefer exact match for point under bidi.
4626 Don't advance `row' beyond the last row of the window.
4628 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4629 into disp_prop; all users changed.
4631 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4632 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4633 for the text covered by the display property.
4635 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4637 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4638 Change return value to nil.
4639 (Frecord_buffer): Delete unused function.
4641 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4643 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4644 buffers, return left-to-right.
4645 (set_cursor_from_row): Consider candidate row a win if its glyph
4646 represents a newline and point is on that newline. Fixes cursor
4647 positioning on the newline at EOL of R2L text within L2R
4648 paragraph, and vice versa.
4649 (try_cursor_movement): Check continued rows, in addition to
4650 continuation rows. Fixes unwarranted scroll when point enters a
4651 continued line of R2L text within an L2R paragraph, or vice versa.
4652 (cursor_row_p): Consider the case of point being equal to
4653 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4654 from the end of a short line to the beginning of a continued line
4655 of R2L text within L2R paragraph.
4656 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4657 composed characters.
4659 * bidi.c (bidi_check_type): Use xassert.
4660 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4663 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4665 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4668 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4670 * nsfont.m (ns_otf_to_script): Fix typo.
4672 2011-08-22 Kenichi Handa <handa@m17n.org>
4674 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4675 extra slot even if the purpose is char-code-property-table.
4677 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4679 * xdisp.c (redisplay_window): When computing centering_position,
4680 account for the height of the header line. (Bug#8874)
4682 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4683 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4684 candidate is selected by the mouse, and that candidate has a
4685 composed character under the mouse.
4687 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4688 coordinates reported by pos-visible-in-window-p for a composed
4689 character in column zero.
4691 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4693 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4695 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4697 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4698 consider it a hit if to_charpos is anywhere in the range of the
4699 composed buffer positions.
4701 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4703 * image.c (gif_load): Don't assume that each subimage has the same
4704 dimensions as the base image. Handle disposal method that is
4705 "undefined" by the gif spec (Bug#9335).
4707 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4709 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4710 (Fcondition_case): Document `debug' symbol in error handler.
4712 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4714 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4715 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4716 from an Org mode buffer to a Speedbar frame.
4718 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4719 a composition, take its buffer position from IT->cmp_it.charpos.
4720 Fixes cursor positioning at the beginning of a line that begins
4721 with a composed character.
4723 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4725 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4726 character bidirectional type, use STRONG_L instead. Fixes crashes
4727 in a buffer produced by `describe-categories'.
4729 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4730 members before the level stack, so they would be saved and
4731 restored when copying iterator state. Fixes incorrect reordering
4732 around TABs covered by display properties.
4734 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4736 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4738 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4740 * eval.c (internal_condition_case, internal_condition_case_1)
4741 (internal_condition_case_2, internal_condition_case_n):
4742 Remove unnecessary aborts (Bug#9081).
4744 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4746 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4747 has no `load' handler, try opening the file locally. (Bug#9311)
4749 2011-08-16 Ken Brown <kbrown@cornell.edu>
4751 * gmalloc.c: Expand comment.
4753 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4755 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4756 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4758 2011-08-16 Ken Brown <kbrown@cornell.edu>
4760 Fix memory allocation problems in Cygwin build (Bug#9273).
4762 * unexcw.c ( __malloc_initialized): Declare external variable.
4763 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4765 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4767 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4769 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4771 [CYGWIN] (special_realloc): New function.
4772 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4773 requests to realloc storage in the static heap.
4775 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4777 * bidi.c (bidi_initialize): Remove unused local.
4779 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4782 * biditype.h: Remove file.
4783 * makefile.w32-in ($(BLD)/bidi.$(O)):
4784 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4786 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4788 * chartab.c: Improve commentary for the uniprop_table API.
4790 * bidi.c (bidi_paragraph_init): Support zero value of
4791 bidi_ignore_explicit_marks_for_paragraph_level.
4792 (bidi_initialize): Use uniprop_table instead of including
4793 biditype.h and bidimirror.h.
4795 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4796 coordinates of the iterator when restoring from ppos_it.
4799 2011-08-14 Kenichi Handa <handa@m17n.org>
4801 * process.c (create_process): Call setup_process_coding_systems
4802 after the pid of the process is set to -1 (Bug#8162).
4804 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4806 * xdisp.c (move_it_in_display_line_to): Don't invoke
4807 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4808 ppos_it. Fixes vertical cursor motion when line beginning is
4809 covered by an image. (Bug#9296)
4811 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4813 * nsterm.h (ns_run_ascript): Declare.
4814 (NSAPP_DATA2_RUNASSCRIPT): Define.
4816 * nsfns.m (as_script, as_result, as_status): New static variables.
4817 (ns_run_ascript): New function.
4818 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4819 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4820 the event loop. Get status from as_status (Bug#7276).
4822 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4823 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4824 the event loop (Bug#7276).
4826 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4828 * gnutls.c (QCgnutls_bootprop_priority)
4829 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4830 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4831 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4832 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4833 (QCgnutls_bootprop_verify_hostname_error)
4834 (QCgnutls_bootprop_callbacks_verify): Rename from
4835 Qgnutls_bootprop_..., all uses changed.
4837 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4840 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4842 * xfaces.c (Qframe_set_background_mode): Now static.
4843 * dispextern.h (Qframe_set_background_mode): Remove decl.
4845 * process.c (Fnetwork_interface_info): Declare local only if needed.
4847 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4849 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4850 (Fnetwork_interface_list): Allocate in increments of bytes instead
4851 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4852 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4854 (struct ifflag_def): notrailers is smart on OSX.
4855 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4856 Get hardware address with getifaddrs if available.
4858 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4860 * xdisp.c (iterate_out_of_display_property): xassert that
4861 IT->position is set to within IT->object's boundaries. Break from
4862 the loop as soon as EOB is reached; avoids infloops in redisplay
4863 when IT->position is set up wrongly due to some bug.
4864 Set IT->current to match the bidi iterator unconditionally.
4865 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4866 entry. Force push_it to save on the stack the current
4867 buffer/string position, to be restored by pop_it. Fix flags in
4868 the iterator structure wrt the object coming from a display
4869 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4870 properties. (Bug#9284)
4872 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4874 * fontset.c (fontset_get_font_group): Add proper type checks.
4877 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4879 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4880 and LC_VERSION_MIN_MACOSX.
4881 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4882 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4884 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4886 * xdisp.c (forward_to_next_line_start): Allow to use the
4887 no-display-properties-and-no-overlays under bidi display.
4888 Set disp_pos in the bidi iterator to avoid searches for display
4889 properties and overlays.
4891 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4893 * editfns.c (Fset_time_zone_rule): Document relationship with the
4896 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4897 the font entity extracted from the cache (Bug#8109).
4899 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4901 * composite.c (autocmp_chars): Don't reset point. That is done by
4902 restore_point_unwind (Bug#5984).
4904 2011-08-07 Juri Linkov <juri@jurta.org>
4906 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4907 to show the arg `TIME' instead of `TIMEVAL'.
4909 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4911 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4912 display property strides EOL and includes a newline, as in
4913 longlines-mode. (Bug#9254)
4914 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4915 word-wrap under bidirectional display. (Bug#9224)
4917 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4918 is non-zero, even if the data buffer is NULL. Fixes a crash in
4919 vertical-motion with longlines-mode. (Bug#9254)
4921 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4923 * bidi.c <bidi_cache_total_alloc>: Now static.
4924 (bidi_initialize): Initialize bidi_cache_total_alloc.
4926 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4929 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4930 amount allocated this far in `bidi_cache_total_alloc'.
4931 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4932 non-zero, only free the data buffer without restoring the cache
4933 contents. All callers changed.
4935 * dispextern.h (bidi_unshelve_cache): Update prototype.
4937 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4938 (move_it_in_display_line, move_it_to)
4939 (move_it_vertically_backward, move_it_by_lines): Replace the call
4940 to xfree to an equivalent call to bidi_unshelve_cache.
4941 (move_it_in_display_line_to): Fix logic of returning
4942 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4944 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4946 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4947 came from a string character with a `cursor' property. (Bug#9229)
4949 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4951 * Makefile.in (LIB_PTHREAD): New variable.
4952 (LIBES): Add LIB_PTHREAD (Bug#9216).
4954 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4955 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4957 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4959 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4961 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4963 * xterm.c (x_find_topmost_parent): New function.
4964 (x_set_frame_alpha): Find topmost parent window with
4965 x_find_topmost_parent and set the property there also (bug#9181).
4966 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4968 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4970 * callproc.c (Fcall_process): Avoid vfork clobbering
4971 the local vars buffer, coding_systems, current_dir.
4973 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4975 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4977 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4979 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4980 so that it is not optimized away.
4982 * xdisp.c (compute_display_string_pos): Remove unused local.
4984 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4986 Fix slow cursor motion and scrolling in large buffers with
4987 selective display, like Org Mode buffers. (Bug#9218)
4989 * dispextern.h (struct bidi_it): New member disp_prop_p.
4991 * xdisp.c: Remove one-slot cache of display string positions.
4992 (compute_display_string_pos): Accept an additional argument
4993 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4994 for a display string or property. If found, set DISP_PROP_P
4997 * bidi.c (bidi_fetch_char): Accept an additional argument
4998 DISP_PROP_P, and pass it to compute_display_string_pos.
4999 Only handle text covered by a display string if DISP_PROP_P is returned
5000 non-zero. All callers of bidi_fetch_char changed.
5002 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5004 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5006 2010-12-03 Don March <don@ohspite.net>
5008 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5009 last character M-[char] is translated to ESC [char] (bug#7541).
5011 2011-08-02 Kenichi Handa <handa@m17n.org>
5013 * lisp.h (uniprop_table): Extern it.
5015 * chartab.c (uniprop_table): Make it non-static.
5017 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5019 * xdisp.c (forward_to_next_line_start): Accept additional argument
5020 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5022 (reseat_at_next_visible_line_start): Use the bidi iterator state
5023 returned by forward_to_next_line_start to restore the state of
5024 it->bidi_it after backing up to previous newline. (Bug#9212)
5026 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5028 * regex.c (re_comp): Protoize.
5029 (re_exec): Fix return type.
5030 (regexec): Fix type of `ret'. (Bug#9203)
5032 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5034 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5035 This is needed if max-image-size is a floating-point number.
5037 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5039 * print.c (print_object): Print empty symbol as ##.
5041 * lread.c (read1): Read ## as empty symbol.
5043 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5045 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5046 setting frame foreground color (Bug#9175).
5047 (x_set_background_color): Likewise.
5049 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5050 contents (Bug#9176).
5051 (EmacsTooltip -init): Remove bezels and add shadows to
5054 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5055 or scroll bar (Bug#8470).
5057 * nsfont.m (nsfont_open): Remove assignment to voffset and
5058 unnecessary vars hshink, expand, hd, full_height, min_height.
5059 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5061 * nsterm.h (nsfont_info): Remove voffset field.
5063 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5065 Implement strike-through and overline on NextStep (Bug#8863).
5067 * nsfont.m (nsfont_open): Use underline position provided by font,
5068 instead of hard-coded value of 2.
5069 (nsfont_draw): Call ns_draw_text_decoration instead.
5071 * nsterm.h: Add declaration for ns_draw_text_decoration.
5073 * nsterm.m (ns_draw_text_decoration): New function for drawing
5074 underline, overline, and strike-through.
5075 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5076 ns_draw_text_decoration. Change treatment of cursor drawing to
5077 accommodate underlining, etc.
5079 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5081 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5084 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5086 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5087 Without this fix, if a signal arrives just after memory fills up,
5088 'malloc' might be invoked reentrantly.
5090 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5091 In other words, assume that every image size is allowed, on non-X
5092 hosts. This assumption is probably wrong, but it lets Emacs compile.
5094 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5096 * regex.c (re_iswctype): Convert return values to boolean.
5098 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5100 * xdisp.c (compute_display_string_pos): Don't use cached display
5101 string position if the buffer had its restriction changed.
5104 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5106 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5108 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5110 Integer signedness and overflow and related fixes. (Bug#9079)
5112 * bidi.c: Integer size and overflow fixes.
5113 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5114 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5115 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5116 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5117 (bidi_find_other_level_edge):
5118 Use ptrdiff_t instead of EMACS_INT where either will do.
5119 This works better on 32-bit hosts configured --with-wide-int.
5120 (bidi_cache_ensure_space): Check for size-calculation overflow.
5121 Use % rather than repeated addition, for better worst-case speed.
5122 Don't set bidi_cache_size until after xrealloc returns, because it
5124 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5125 (bidi_cache_ensure_space): Also check that the bidi cache size
5126 does not exceed that of the largest Lisp string or buffer. See Eli
5127 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5129 * alloc.c (__malloc_size_t): Remove.
5130 All uses replaced by size_t. See Andreas Schwab's note
5131 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5133 * image.c: Improve checking for integer overflow.
5134 (check_image_size): Assume that f is nonnull, since
5135 it is always nonnull in practice. This is one less thing to
5136 worry about when checking for integer overflow later.
5137 (x_check_image_size): New function, which checks for integer
5138 overflow issues inside X.
5139 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5140 This removes the need for a memory_full check.
5141 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5142 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5143 (xbm_read_bitmap_data): Change locals back to 'int', since
5144 their values must fit in 'int'.
5145 (xpm_load_image, png_load, tiff_load):
5146 Invoke x_create_x_image_and_pixmap earlier,
5147 to avoid much needless work if the image is too large.
5148 (tiff_load): Treat overly large images as if
5149 x_create_x_image_and_pixmap failed, not as malloc failures.
5150 (gs_load): Use x_check_image_size.
5152 * gtkutil.c: Omit integer casts.
5153 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5154 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5156 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5158 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5159 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5160 would wrongly return t on a 64-bit host.
5162 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5163 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5164 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5165 and therefore cause GCC to emit a bogus diagnostic in some cases.
5167 * image.c: Integer signedness and overflow and related fixes.
5168 This is not an exhaustive set of fixes, but it's time to
5169 record what I've got.
5170 (lookup_pixel_color, check_image_size): Remove redundant decls.
5171 (check_image_size): Don't assume that arbitrary EMACS_INT values
5172 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5173 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5174 (tiff_load, imagemagick_load_image):
5175 Check for overflow in size calculations.
5176 (x_create_x_image_and_pixmap): Remove unnecessary test for
5177 xmalloc returning NULL; that can't happen.
5178 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5179 (xpm_color_bucket): Use better integer hashing function.
5180 (xpm_cache_color): Don't possibly over-allocate memory.
5181 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5182 (gif_memory_source):
5183 Use ptrdiff_t, not int or size_t, to record sizes.
5184 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5185 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5186 either works, as we prefer signed integers.
5187 (tiff_read_from_memory, tiff_write_from_memory):
5188 Return tsize_t, not size_t, since that's what the TIFF API wants.
5189 (tiff_read_from_memory): Don't fail simply because the read would
5190 go past EOF; instead, return a short read.
5191 (tiff_load): Omit no-longer-needed casts.
5192 (Fimagemagick_types): Don't assume size fits into 'int'.
5194 Improve hashing quality when configured --with-wide-int.
5195 * fns.c (hash_string): New function, taken from sxhash_string.
5196 Do not discard information about ASCII character case; this
5197 discarding is no longer needed.
5198 (sxhash-string): Use it. Change sig to match it. Caller changed.
5199 * lisp.h: Declare it.
5200 * lread.c (hash_string): Remove, since we now use fns.c's version.
5201 The fns.c version returns a wider integer if --with-wide-int is
5202 specified, so this should help the quality of the hashing a bit.
5204 * emacs.c: Integer overflow minor fix.
5205 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5206 Define only if GNU_LINUX.
5207 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5209 * dispnew.c: Integer signedness and overflow fixes.
5210 Remove unnecessary forward decls, that were a maintenance hassle.
5211 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5213 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5214 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5215 (prepare_desired_row, line_draw_cost):
5216 Use int, not unsigned, where either works.
5217 (save_current_matrix, restore_current_matrix):
5218 Use ptrdiff_t, not size_t, where either works.
5219 (init_display): Check for overflow more accurately, and without
5220 relying on undefined behavior.
5222 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5223 Remove, replacing with the new symbols in lisp.h. All uses changed.
5224 * fileio.c (make_temp_name):
5225 * filelock.c (lock_file_1, lock_file):
5226 * xdisp.c (message_dolog):
5227 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5228 Use pMd etc. instead.
5229 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5230 replacing the pWIDE etc. symbols removed from editfns.c.
5232 * keyboard.h (num_input_events): Now uintmax_t.
5233 This is (very slightly) less likely to mess up due to wraparound.
5236 * buffer.c: Integer signedness fixes.
5237 (alloc_buffer_text, enlarge_buffer_text):
5238 Use ptrdiff_t rather than size_t when either will do, as we prefer
5241 * alloc.c: Integer signedness and overflow fixes.
5242 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5243 (__malloc_size_t): Default to size_t, not to int.
5244 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5245 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5246 Prefer ptrdiff_t to size_t when either would do, as we prefer
5248 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5249 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5250 Now const. Initialize with values that are in range even if char
5252 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5253 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5254 These functions do the right thing with sizes > 2**32.
5255 (check_depth): Now ptrdiff_t, not int.
5256 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5257 Adjust to new way of storing sizes. Check for size overflow bugs
5259 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5260 slightly wrong anyway, as it missed one instance of
5261 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5262 (refill_memory_reserve): Omit needless cast to size_t.
5263 (mark_object_loop_halt): Mark as externally visible.
5265 * xselect.c: Integer signedness and overflow fixes.
5266 (Fx_register_dnd_atom, x_handle_dnd_message):
5267 Use ptrdiff_t, not size_t, since we prefer signed.
5268 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5269 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5270 x_dnd_atoms_size and x_dnd_atoms_length.
5272 * doprnt.c: Prefer signed to unsigned when either works.
5274 * doprnt.c (doprnt):
5276 * xdisp.c (vmessage):
5277 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5278 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5279 prefer signed arithmetic to avoid comparison confusion.
5280 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5281 but is a bit tricky.
5283 Assume freestanding C89 headers, string.h, stdlib.h.
5284 * data.c, doprnt.c, floatfns.c, print.c:
5285 Include float.h unconditionally.
5286 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5287 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5288 * regex.c: Likewise for stddef.h, string.h.
5289 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5290 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5291 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5292 (STDC_HEADERS): Remove obsolete defines.
5293 * sysdep.c: Include limits.h unconditionally.
5295 Assume support for memcmp, memcpy, memmove, memset.
5296 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5297 * regex.c (memcmp, memcpy):
5298 Remove; we assume C89 now.
5300 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5301 (__malloc_safe_bcopy): Remove; no longer needed.
5303 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5304 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5305 well either way, and we prefer signed to unsigned.
5307 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5309 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5310 closes the connection while we're reading (bug#9182).
5312 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5314 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5315 are specified (Bug#9168).
5317 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5319 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5320 Found by GCC static checking and --with-wide-int on a 32-bit host.
5322 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5324 * xdisp.c (compute_display_string_pos): Fix logic of caching
5325 previous display string position. Initialize cached_prev_pos to
5326 -1. Fixes slow-down at the beginning of a buffer.
5328 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5330 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5331 for attrs[LFACE_FONTSET_INDEX].
5333 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5335 * xml.c (parse_region): Remove unused local
5336 that was recently introduced.
5338 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5340 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5341 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5343 * xdisp.c (move_it_in_display_line_to): Record the best matching
5344 position for TO_CHARPOS while scanning the line, and restore it on
5345 exit if none of the characters scanned was an exact match.
5346 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5347 when exact match is impossible due to invisible text, and the
5348 lines are truncated.
5350 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5352 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5355 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5357 Fix a significant slow-down of cursor motion with C-n, C-p,
5358 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5359 auto-repeat under bidi redisplay in fontified buffers.
5360 * xdisp.c (compute_stop_pos_backwards): New function.
5361 (next_element_from_buffer): Call compute_stop_pos_backwards to
5362 find a suitable prev_stop when we find ourselves before
5364 (reseat): Don't look for prev_stop, as that could mean a very long
5366 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5367 <cached_disp_overlay_modiff>: Cache for last found display string
5369 (compute_display_string_pos): Return the cached position if asked
5370 about the same buffer in the same area of character positions, and
5371 the buffer wasn't changed since the time the display string
5372 position was cached.
5374 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5376 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5377 is an integer, which is important for empty lines. (Bug#9149)
5379 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5381 * frame.c (Fmodify_frame_parameters): In tty case, update the
5382 default face if necessary (Bug#4238).
5384 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5386 * editfns.c (Fstring_to_char): No need to explain what a character
5387 is in the docstring (Bug#6576).
5389 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5391 * xml.c (parse_region): Make sure we always return a tree.
5393 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5395 * xml.c (parse_region): If a document contains only comments,
5398 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5400 * xml.c (make_dom): Return comments, too.
5402 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5405 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5406 and the surrounding thread.
5407 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5408 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5409 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5411 * s/openbsd.h (BROKEN_SIGIO): Define.
5412 * unexelf.c (unexec) [__OpenBSD__]:
5413 Don't update the .mdebug section of the Alpha COFF symbol table.
5415 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5417 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5420 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5422 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5423 This fixes some race conditions on the permissions of any newly
5426 * alloc.c (valid_pointer_p): Use pipe, not open.
5427 This fixes some permissions issues when debugging.
5429 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5430 If fchown fails to set both uid and gid, try to set just gid,
5431 as that is sometimes allowed. Adjust the file's mode to eliminate
5432 setuid or setgid bits that are inappropriate if fchown fails.
5434 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5436 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5437 to compare Lisp_Objects.
5438 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5439 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5440 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5442 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5444 * lread.c (read_integer): Unread even EOF character.
5445 (read1): Likewise. Properly record start position of symbol.
5447 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5448 symbol character follows.
5450 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5452 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5453 This works around a problem with the previous change to Fcopy_file.
5454 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5455 and without this change, GCC might complain about discarding
5456 fchown's return value.
5458 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5460 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5462 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5464 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5466 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5468 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5469 it's used from the C level.
5471 * process.c: Use the same condition for POLL_FOR_INPUT in both
5472 keyboard.c and process.c (bug#1858).
5474 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5476 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5477 (Fgnutls_boot): Use it.
5479 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5481 * doc.c (Fsubstitute_command_keys): Revert last change.
5483 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5485 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5486 quotes the next character, and doesn't affect other longer
5487 sequences (bug#8935).
5489 * lread.c (syms_of_lread): Clarify that is isn't only
5490 `eval-buffer' and `eval-defun' that's affected by
5491 `lexical-binding' (bug#8460).
5493 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5495 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5496 bidi redisplay when a line includes both an image and is truncated.
5498 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5500 Fix minor problems found by static checking.
5501 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5502 (elsz): Now a signed constant, not a size_t var. We prefer signed
5503 types to unsigned, to avoid integer comparison confusion. Without
5504 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5505 "cannot optimize loop, the loop counter may overflow", a symptom
5507 * indent.c (Fvertical_motion): Mark locals as initialized.
5508 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5510 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5512 * search.c (Fre_search_backward): Mention `case-fold-search' in
5513 all the re_search_* functions (bug#8138).
5515 * keyboard.c (Fopen_dribble_file): Document when the file is
5518 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5520 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5523 Support bidi reordering of display and overlay strings.
5524 * xdisp.c (compute_display_string_pos)
5525 (compute_display_string_end): Accept additional argument STRING.
5526 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5527 (reseat_to_string): Initialize bidi_it->string.s and
5528 bidi_it->string.schars.
5529 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5530 NULL (avoids a crash in bidi_paragraph_init).
5531 Initialize itb.string.lstring.
5532 (init_iterator): Call bidi_init_it only of a valid
5533 buffer position was specified. Initialize paragraph_embedding to
5535 (reseat_to_string): Initialize the bidi iterator.
5536 (display_string): If we need to ignore text properties of
5537 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5538 original value of -1 will not work with bidi.)
5539 (compute_display_string_pos): First arg is now struct
5540 `text_pos *'; all callers changed. Support display properties on
5542 (compute_display_string_end): Support display properties on Lisp
5544 (init_iterator, reseat_1, reseat_to_string): Initialize the
5545 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5546 when iterating on a string not from display properties).
5547 (compute_display_string_pos, compute_display_string_end):
5548 Fix calculation of the object to scan. Fixes an error when using
5550 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5551 base_level_stop; instead, set base_level_stop to BEGV.
5552 Fixes crashes in vertical-motion.
5553 (next_element_from_buffer): Improve commentary for when
5554 the iterator is before prev_stop.
5555 (init_iterator): Initialize bidi_p from the default value of
5556 bidi-display-reordering, not from buffer-local value. Use the
5557 buffer-local value only if initializing for buffer iteration.
5558 (handle_invisible_prop): Support invisible properties on strings
5559 that are being bidi-reordered.
5560 (set_iterator_to_next): Support bidi reordering of C strings and
5562 (next_element_from_string): Support bidi reordering of Lisp
5564 (handle_stop_backwards): Support Lisp strings as well.
5565 (display_string): Support display of R2L glyph rows.
5566 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5567 (init_iterator): Don't initialize it->bidi_p for strings
5569 (reseat_to_string): Initialize it->bidi_p for strings here.
5570 (next_element_from_string, next_element_from_c_string)
5571 (next_element_from_buffer): Add xassert's for correspondence
5572 between IT's object being iterated and it->bidi_it.string
5574 (face_before_or_after_it_pos): Support bidi iteration.
5575 (next_element_from_c_string): Handle the case of the first string
5576 character that is not the first one in the visual order.
5577 (get_visually_first_element): New function, refactored from common
5578 parts of next_element_from_buffer, next_element_from_string, and
5579 next_element_from_c_string.
5580 (tool_bar_lines_needed, redisplay_tool_bar)
5581 (display_menu_bar): Force left-to-right direction. Add a FIXME
5582 comment for making that be controlled by a user option.
5583 (push_it, pop_it): Save and restore the state of the
5584 bidi iterator. Save and restore the bidi_p flag.
5585 (pop_it): Iterate out of display property for string iteration as
5587 (iterate_out_of_display_property): Support iteration over strings.
5588 (handle_single_display_spec): Set up it->bidi_it for iteration
5589 over a display string, and call bidi_init_it.
5590 (handle_single_display_spec, next_overlay_string)
5591 (get_overlay_strings_1, push_display_prop): Set up the bidi
5592 iterator for displaying display or overlay strings.
5593 (forward_to_next_line_start): Don't use the shortcut if
5595 (back_to_previous_visible_line_start): If handle_display_prop
5596 pushed the iterator stack, restore the internal state of the bidi
5597 iterator by calling bidi_pop_it same number of times.
5598 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5599 and we are bidi-iterating, don't decrement the iterator position;
5600 instead, set the first_elt flag in the bidi iterator, to produce
5602 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5603 (push_display_prop): xassert that we are iterating a buffer.
5604 (push_it, pop_it): Save and restore paragraph_embedding member.
5605 (handle_single_display_spec, next_overlay_string)
5606 (get_overlay_strings_1, reseat_1, reseat_to_string)
5607 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5608 correctly. Don't assume unibyte strings are not bidi-reordered.
5609 (compute_display_string_pos)
5610 (compute_display_string_end): Fix handling the case of C string.
5611 (push_it, pop_it): Save and restore from_disp_prop_p.
5612 (handle_single_display_spec, push_display_prop): Set the
5613 from_disp_prop_p flag.
5614 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5615 (pop_it): Call iterate_out_of_display_property only if we are
5616 popping after iteration over a string that came from a display
5617 property. Fix a typo in popping stretch info. Add an assertion
5618 for verifying that the iterator position is in sync with the bidi
5620 (handle_single_display_spec, get_overlay_strings_1)
5621 (push_display_prop): Fix initialization of paragraph direction for
5622 string when that of the parent object is not yet determined.
5623 (reseat_1): Call bidi_init_it to resync the bidi
5624 iterator with IT's position. (Bug#7616)
5625 (find_row_edges): If ROW->start.pos gives position
5626 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5627 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5628 Reset the from_disp_prop_p flag.
5629 (SAVE_IT, RESTORE_IT): New macros.
5630 (pos_visible_p, face_before_or_after_it_pos)
5631 (back_to_previous_visible_line_start)
5632 (move_it_in_display_line_to, move_it_in_display_line)
5633 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5634 (try_scrolling, redisplay_window, display_line): Use them when
5635 saving a temporary copy of the iterator and restoring it back.
5636 (back_to_previous_visible_line_start, reseat_1)
5637 (init_iterator): Empty the bidi cache "stack".
5638 (move_it_in_display_line_to): If iterator ended up at
5639 EOL, but we never saw any buffer positions smaller than
5640 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5641 motion in bidi-reordered lines.
5642 (move_it_in_display_line_to): Record prev_method and prev_pos
5643 immediately before the call to set_iterator_to_next. Fixes cursor
5644 motion in bidi-reordered lines with stretch glyphs and strings
5645 displayed in margins. (Bug#8133) (Bug#8867)
5646 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5648 (pos_visible_p): Support positions in bidi-reordered lines.
5649 Save and restore bidi cache.
5651 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5652 (bidi_paragraph_info): Delete unused struct.
5653 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5654 (bidi_cache_start): New variable.
5655 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5657 (bidi_cache_fetch_state, bidi_cache_search)
5658 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5659 (bidi_cache_find, bidi_peek_at_next_level)
5660 (bidi_level_of_next_char, bidi_find_other_level_edge)
5661 (bidi_move_to_visually_next): Compare cache index with
5662 bidi_cache_start rather than with zero.
5663 (bidi_fetch_char): Accept new argument STRING; all callers
5664 changed. Support iteration over a string. Support strings with
5665 display properties. Support unibyte strings. Fix the type of
5666 `len' according to what STRING_CHAR_AND_LENGTH expects.
5667 (bidi_paragraph_init, bidi_resolve_explicit_1)
5668 (bidi_resolve_explicit, bidi_resolve_weak)
5669 (bidi_level_of_next_char, bidi_move_to_visually_next):
5670 Support iteration over a string.
5671 (bidi_set_sor_type, bidi_resolve_explicit_1)
5672 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5673 can now be zero (for strings); special values 0 and -1 were
5674 changed to -1 and -2, respectively.
5675 (bidi_char_at_pos): New function.
5676 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5677 Call it instead of FETCH_MULTIBYTE_CHAR.
5678 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5679 initialized to valid values.
5680 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5682 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5683 the test for valid cached positions. Fix the logic for looking up
5684 the sentinel state in the cache. GCPRO the Lisp string we are
5686 (bidi_push_it, bidi_pop_it): New functions.
5687 (bidi_initialize): Initialize the bidi cache start stack pointer.
5688 (bidi_cache_ensure_space): New function, refactored from part of
5689 bidi_cache_iterator_state. Don't assume the required size is just
5690 one BIDI_CACHE_CHUNK away.
5691 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5692 (bidi_count_bytes, bidi_char_at_pos): New functions.
5693 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5694 always valid if bidi_cache_idx is valid.
5695 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5696 is valid if it's going to be used.
5697 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5698 (bidi_cache_fetch_state, bidi_cache_search)
5699 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5700 (bidi_cache_iterator_state, bidi_cache_find)
5701 (bidi_find_other_level_edge, bidi_cache_start_stack):
5702 All variables related to cache indices are now EMACS_INT.
5704 * dispextern.h (struct bidi_string_data): New structure.
5705 (struct bidi_it): New member `string'. Make flag members be 1-bit
5706 fields, and put them last in the struct.
5707 (compute_display_string_pos, compute_display_string_end):
5709 (bidi_push_it, bidi_pop_it): Add prototypes.
5710 (struct iterator_stack_entry): New members bidi_p,
5711 paragraph_embedding, and from_disp_prop_p.
5712 (struct it): Member bidi_p is now a bit field 1 bit wide.
5713 (bidi_shelve_cache, bidi_unshelve_cache):
5716 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5717 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5718 and vector-like objects.
5720 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5721 cache around display iteration.
5723 * window.c (Fwindow_end, window_scroll_pixel_based)
5724 (displayed_window_lines, Frecenter): Save and restore the bidi
5725 cache around display iteration.
5727 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5729 * editfns.c (Fdelete_region): Clarify the use of the named
5730 parameters (bug#6788).
5732 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5734 * indent.c (Fvertical_motion): Set and restore w->pointm when
5735 saving and restoring the window's buffer (Bug#9006).
5737 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5739 * editfns.c (Fstring_to_char): Clarify just what is returned
5740 (bug#6576). Text by Eli Zaretskii.
5742 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5744 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5746 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5748 * buffer.c (mmap_find): Fix a typo.
5750 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5752 Fix execution of x selection hooks.
5753 * xselect.c (Qx_lost_selection_functions)
5754 (Qx_sent_selection_functions): New vars.
5755 (syms_of_xselect): DEFSYM them.
5756 (x_handle_selection_request): Pass Qx_sent_selection_functions
5757 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5758 (x_handle_selection_clear,x_clear_frame_selections):
5759 Pass Qx_lost_selection_functions rather than
5760 Vx_lost_selection_functions to Frun_hook_with_args.
5762 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5764 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5765 The old code sometimes used this field without initializing it.
5767 * alloc.c (gc_sweep): Don't read past end of array.
5768 In theory, the old code could also have corrupted Emacs internals,
5769 though it'd be very unlikely.
5771 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5773 * character.c (Fcharacterp): Don't advertise optional ignored
5774 argument. (Bug#4026)
5776 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5778 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5781 * window.c (Fset_window_start): Doc fix (bug#4199).
5782 (Fset_window_hscroll): Ditto.
5784 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5786 Fix minor new problems caught by GCC 4.6.1.
5787 * term.c (init_tty): Remove unused local.
5788 * xsettings.c (store_monospaced_changed): Define this function only
5789 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5792 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5794 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5796 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5798 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5799 are the mini-buffer and the echo area (bug#3320).
5801 * term.c (init_tty): Remove support for supdup, c10 and perq
5802 terminals, which are no longer supported (bug#1482).
5804 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5806 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5808 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5810 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5811 for non-popups (Bug#3642).
5813 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5815 * alloc.c (reset_malloc_hooks): Protoize.
5816 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5817 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5818 * cm.c (losecursor): Likewise.
5819 * data.c (fmod): Likewise.
5820 * dispnew.c (swap_glyphs_in_rows): Likewise.
5821 * emacs.c (memory_warning_signal): Likewise.
5822 * floatfns.c (float_error): Likewise.
5823 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5824 (otf_open, font_otf_capability, generate_otf_features)
5825 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5827 * image.c (pbm_read_file): Likewise.
5828 * indent.c (string_display_width): Likewise.
5829 * intervals.c (check_for_interval, search_for_interval)
5830 (inc_interval_count, count_intervals, root_interval)
5831 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5832 * lread.c (defalias): Likewise.
5833 * ralloc.c (r_alloc_check): Likewise.
5834 * regex.c (set_image_of_range_1, set_image_of_range)
5835 (regex_grow_registers): Likewise.
5836 * sysdep.c (strerror): Likewise.
5837 * termcap.c (valid_filename_p, tprint, main): Likewise.
5838 * tparam.c (main): Likewise.
5839 * unexhp9k800.c (run_time_remap, save_data_space)
5840 (update_file_ptrs, read_header, write_header, calculate_checksum)
5841 (copy_file, copy_rest, display_header): Likewise.
5842 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5844 * xdisp.c (check_it): Likewise.
5845 * xfaces.c (register_color, unregister_color, unregister_colors):
5847 * xfns.c (print_fontset_result): Likewise.
5848 * xrdb.c (member, fatal, main): Likewise.
5850 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5852 Fix minor problems found by static checking (Bug#9031).
5853 * chartab.c (char_table_set_range, map_sub_char_table):
5854 Remove unused locals.
5855 (uniprop_table): Now static.
5856 * composite.c (_work_char): Remove unused static var.
5858 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5860 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5862 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5864 * gtkutil.c (qttip_cb): Remove code without function.
5866 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5868 * w32.c (pthread_sigmask): New stub.
5870 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5872 Use pthread_sigmask, not sigprocmask (Bug#9010).
5873 sigprocmask is portable only for single-threaded applications, and
5874 Emacs can be multi-threaded when it uses GTK.
5875 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5877 * callproc.c (Fcall_process):
5878 * process.c (create_process):
5879 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5880 Use pthread_sigmask, not sigprocmask.
5882 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5884 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5885 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5888 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5890 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5891 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5892 (xg_hide_tooltip): Fix comment.
5894 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5895 in registerServicesMenuSendTypes.
5896 (validRequestorForSendType): Don't check ns_return_types.
5898 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5901 2011-07-08 Jason Rumney <jasonr@gnu.org>
5903 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5904 SH_SHOW for hidden windows (Bug#5482).
5906 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5907 frame struct members of non-existent frames (Bug#6284).
5909 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5911 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5912 variable firstTime not needed on OSX >= 10.6.
5913 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5914 >= 10.5. Use setKnobProportion, setDoubleValue.
5916 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5917 (MAC_OS_X_VERSION_10_5): Define if not defined.
5918 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5919 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5920 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5922 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5923 cString and lossyCString on OSX >= 10.4
5925 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5926 sizeToFit on OSX >= 10.2.
5928 * nsimage.m (allocInitFromFile): Don't use deprecated method
5929 bestRepresentationForDevice on OSX >= 10.6.
5931 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5934 * emacs.c: Declare unexec_init_emacs_zone.
5936 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5938 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5940 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5941 on svcsMenu (Bug#8842).
5943 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5945 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5947 * nsterm.m (QUTF8_STRING): Declare.
5948 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5949 (validRequestorForSendType): Return type is (id).
5950 Change indexOfObjectIdenticalTo to indexOfObject.
5951 Check if we have local selection before returning self (Bug#8842).
5952 (writeSelectionToPasteboard): Put local selection into paste board
5953 if we have a local selection (Bug#8842).
5954 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5956 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5957 (ns_get_local_selection): Declare.
5959 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5961 * keymap.c (describe_map_tree): Don't insert a double newline at
5962 the end of the buffer (bug#1169) and return whether we inserted
5965 * callint.c (Fcall_interactively): Change "reading args" to
5966 "providing args" to try to clarify what it does (bug#1010).
5968 2011-07-07 Kenichi Handa <handa@m17n.org>
5970 * composite.c (composition_compute_stop_pos): Ignore a static
5971 composition starting before CHARPOS (Bug#8915).
5973 * xdisp.c (handle_composition_prop): Likewise.
5975 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5977 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5980 2011-07-07 Kenichi Handa <handa@m17n.org>
5982 * character.h (unicode_category_t): New enum type.
5984 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5985 (Qchar_code_property_table): New variable.
5986 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5987 (UNIPROP_COMPRESSED_FORM_P): New macros.
5988 (char_table_ascii): Uncompress the compressed values.
5989 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5990 Uncompress the compressed values.
5991 (sub_char_table_ref_and_range): Likewise.
5992 (char_table_ref_and_range): Uncompress the compressed values.
5993 (sub_char_table_set): New arg is_uniprop. Callers changed.
5994 Uncompress the compressed values.
5995 (sub_char_table_set_range): Args changed. Callers changed.
5996 (char_table_set_range): Adjuted for the above change.
5997 (map_sub_char_table): Delete args default_val and parent. Add arg
5998 top. Give decoded values to a Lisp function.
5999 (map_char_table): Adjust for the above change. Give decoded
6000 values to a Lisp function. Gcpro more variables.
6001 (uniprop_table_uncompress)
6002 (uniprop_decode_value_run_length): New functions.
6003 (uniprop_decoder, uniprop_decoder_count): New variables.
6004 (uniprop_get_decoder, uniprop_encode_value_character)
6005 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6007 (uniprop_encoder, uniprop_encoder_count): New variables.
6008 (uniprop_get_encoder, uniprop_table)
6009 (Funicode_property_table_internal, Fget_unicode_property_internal)
6010 (Fput_unicode_property_internal): New functions.
6011 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6012 Sunicode_property_table_internal, Sget_unicode_property_internal,
6013 and Sput_unicode_property_internal. Defvar_lisp
6014 char-code-property-alist.
6016 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6017 Vunicode_category_table.
6019 * font.c (font_range): Adjust for the change of
6020 Vunicode_category_table.
6022 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6024 * m/iris4d.h: Remove file, move contents ...
6025 * s/irix6-5.h: ... here.
6027 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6029 Remove unportable assumption about struct layout (Bug#8884).
6030 * alloc.c (mark_buffer):
6031 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6032 (clone_per_buffer_values): Don't assume that
6033 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6034 This isn't true in general, and it's particularly not true
6035 if Emacs is configured with --with-wide-int.
6036 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6037 New macros, used in the buffer.c change.
6039 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6041 * xsettings.c: Use both GConf and GSettings if both are available.
6042 (store_config_changed_event): Add comment.
6043 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6044 (store_tool_bar_style_changed): New functions.
6045 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6046 (struct xsettings): Move font inside HAVE_XFT.
6047 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6048 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6049 Move inside HAVE_XFT.
6050 (something_changed_gsettingsCB): Rename from something_changedCB.
6051 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6053 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6054 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6055 (something_changed_gconfCB): Rename from something_changedCB.
6056 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6057 (parse_settings): Move check for font inside HAVE_XFT.
6058 (read_settings, apply_xft_settings): Add comment.
6059 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6060 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6061 call store_font_name_changed.
6062 (xft_settings_event): Add comment.
6063 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6064 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6065 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6066 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6067 (xsettings_initialize): Call init_gsettings last.
6068 (xsettings_get_system_font, xsettings_get_system_normal_font):
6071 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6073 Random fixes. E.g., (random) never returned negative values.
6074 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6075 subseconds part to the entropy, as that's a bit more random.
6076 Prefer signed to unsigned, since the signedness doesn't matter and
6077 in general we prefer signed. When given a limit, use a
6078 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6079 latter isn't right if USE_2_TAGS_FOR_INTS.
6080 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6081 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6083 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6085 * textprop.c (text_property_stickiness):
6086 Obey Vtext_property_default_nonsticky.
6087 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6088 * w32fns.c (syms_of_w32fns):
6089 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6091 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6093 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6094 This is more efficient than Ffile_directory_p and avoids a minor race.
6096 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6098 * buffer.c (Foverlay_put): Say what the return value is
6101 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6102 is a directory before asking whether to use the file name
6104 (barf_or_query_if_file_exists): Make the "File is a directory"
6105 error be more correct.
6107 * fns.c (Frequire): Remove the mention of the .gz files, since
6108 that's installation-specific, but keep the mention of
6109 `get-load-suffixes'.
6111 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6113 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6114 Report string overflow if the output is too long.
6116 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6118 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6119 (syms_of_gnutls): Remove duplicate DEFSYM for
6120 Qgnutls_bootprop_verify_hostname_error, an error for
6121 Qgnutls_bootprop_verify_error (which is no longer used).
6123 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6124 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6125 Also (re)move comments that are misplaced or no longer relevant.
6127 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6129 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6131 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6133 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6134 and background color parameters if they have been changed.
6136 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6138 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6140 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6142 * xsettings.c (SYSTEM_FONT): Define only when used.
6143 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6145 * keymap.c (access_keymap_1): Now static.
6147 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6149 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6150 leave any prefix arg for the up event (Bug#1586).
6152 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6154 * lread.c (syms_of_lread): Mention single symbols defined by
6155 `defvar' or `defconst' (bug#7154).
6157 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6158 (Frequire): Mention get-load-suffixes.
6160 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6162 * window.h (window): Remove clone_number slot.
6163 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6165 (make_parent_window, make_window, saved_window)
6166 (Fset_window_configuration, save_window_save): Don't deal with
6168 * buffer.c (Qclone_number): Remove declaration.
6169 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6171 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6173 Add multiple inheritance to keymaps.
6174 * keymap.c (Fmake_composed_keymap): New function.
6175 (Fset_keymap_parent): Simplify.
6176 (fix_submap_inheritance): Remove.
6177 (access_keymap_1): New function extracted from access_keymap to handle
6178 embedded parents and handle lists of maps.
6179 (access_keymap): Use it.
6180 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6181 (Fcopy_keymap): Handle embedded parents.
6182 (Fcommand_remapping, define_as_prefix): Simplify.
6183 (Fkey_binding): Simplify.
6184 (syms_of_keymap): Move minibuffer-local-completion-map,
6185 minibuffer-local-filename-completion-map,
6186 minibuffer-local-must-match-map, and
6187 minibuffer-local-filename-must-match-map to Elisp.
6188 (syms_of_keymap): Defsubr make-composed-keymap.
6189 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6190 (parse_menu_item): Trivial simplification.
6192 2011-07-01 Glenn Morris <rgm@gnu.org>
6194 * Makefile.in (SETTINGS_LIBS): Fix typo.
6196 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6198 * coding.c (Fencode_coding_string): Record the last coding system
6199 used, as the function doc string says (bug#8738).
6201 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6203 * xsettings.c (store_monospaced_changed): Take new font as arg and
6204 check for change against current_mono_font.
6205 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6206 (emacs_settings_constructor, emacs_settings_get_property)
6207 (emacs_settings_set_property, emacs_settings_class_init)
6208 (emacs_settings_init, gsettings_obj): Remove.
6209 (something_changedCB): New function for HAVE_GSETTINGS.
6210 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6211 with value as argument.
6212 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6213 g_settings_new (Bug#8967). Do not create gsettings_obj.
6214 Remove calls to g_settings_bind. Connect something_changedCB to
6217 * xgselect.c: Add defined (HAVE_GSETTINGS).
6218 (xgselect_initialize): Ditto.
6220 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6221 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6224 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6226 * eval.c (struct backtrace): Simplify and port the data structure.
6227 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6228 signed bit field, as this assumption is not portable and it makes
6229 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6230 "char debug_on_exit : 1" as this is not portable either; instead,
6231 use the portable "unsigned int debug_on_exit : 1". Remove unused
6232 member evalargs. Remove obsolete comments about cc bombing out.
6234 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6236 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6237 Let HAVE_GSETTINGS override HAVE_GCONF.
6238 (store_monospaced_changed): New function.
6239 (EMACS_SETTINGS): A new type derived from GObject to handle
6240 GSettings notifications.
6241 (emacs_settings_constructor, emacs_settings_get_property)
6242 (emacs_settings_set_property, emacs_settings_class_init):
6244 (gsettings_client, gsettings_obj): New variables.
6245 (GSETTINGS_SCHEMA): New define.
6246 (something_changedCB): Call store_monospaced_changed.
6247 (init_gsettings): New function.
6248 (xsettings_initialize): Call init_gsettings.
6249 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6252 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6255 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6257 * window.c (resize_root_window, grow_mini_window)
6258 (shrink_mini_window): Rename Qresize_root_window to
6259 Qwindow_resize_root_window and Qresize_root_window_vertically to
6260 Qwindow_resize_root_window_vertically.
6262 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6264 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6266 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6268 * makefile.w32-in: Redesign dependencies so they reflect more
6269 clearly which files are directly included by each source file,
6270 and not through other includes.
6272 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6274 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6275 (sort_overlays, overlay_strings): When an overlay's clone number
6276 matches the window's clone number process the overlay even if
6277 the overlay's window property doesn't match the current window.
6279 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6280 (Fwindow_hchild): Rename to Fwindow_left_child.
6281 (Fwindow_next): Rename to Fwindow_next_sibling.
6282 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6283 (resize_window_check): Rename to window_resize_check.
6284 (resize_window_apply): Rename to window_resize_apply.
6285 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6286 (Fdelete_other_windows_internal, resize_frame_windows)
6287 (Fsplit_window_internal, Fdelete_window_internal)
6288 (grow_mini_window, shrink_mini_window)
6289 (Fresize_mini_window_internal): Fix callers accordingly.
6291 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6293 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6294 (emacs_fixed_set_min_size): Remove.
6295 (emacs_fixed_new): Take frame as argument.
6297 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6298 (_EmacsFixedPrivate): Remove minwidth/height.
6299 Add struct frame *f.
6300 (emacs_fixed_init): Initialize priv->f.
6301 (get_parent_class, emacs_fixed_set_min_size): Remove.
6302 (emacs_fixed_new): Set priv->f to argument.
6303 (emacs_fixed_get_preferred_width)
6304 (emacs_fixed_get_preferred_height): Use min_width/height from
6305 frames size_hint to set minimum and natural (Bug#8919).
6306 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6307 and use min_width/height from frames size_hint to set
6308 min_width/height (Bug#8919).
6310 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6311 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6314 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6316 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6317 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6320 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6322 * process.c (wait_reading_process_output): Bypass select if
6323 waiting for a cell while ignoring keyboard input, and input is
6324 pending. Suggested by Jan Djärv (Bug#8869).
6326 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6328 Use gnulib's dup2 module instead of rolling our own.
6329 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6331 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6333 * dispnew.c (scrolling_window): Before scrolling, turn off a
6334 mouse-highlight in the window being scrolled.
6336 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6338 Move DEFSYM to lisp.h and use everywhere.
6340 * character.h (DEFSYM): Move declaration...
6341 * lisp.h (DEFSYM): ...here.
6347 * w32select.c: Don't include character.h.
6349 * alloc.c (syms_of_alloc):
6350 * buffer.c (syms_of_buffer):
6351 * bytecode.c (syms_of_bytecode):
6352 * callint.c (syms_of_callint):
6353 * casefiddle.c (syms_of_casefiddle):
6354 * casetab.c (init_casetab_once):
6355 * category.c (init_category_once, syms_of_category):
6356 * ccl.c (syms_of_ccl):
6357 * cmds.c (syms_of_cmds):
6358 * composite.c (syms_of_composite):
6359 * dbusbind.c (syms_of_dbusbind):
6360 * dired.c (syms_of_dired):
6361 * dispnew.c (syms_of_display):
6362 * doc.c (syms_of_doc):
6363 * editfns.c (syms_of_editfns):
6364 * emacs.c (syms_of_emacs):
6365 * eval.c (syms_of_eval):
6366 * fileio.c (syms_of_fileio):
6367 * fns.c (syms_of_fns):
6368 * frame.c (syms_of_frame):
6369 * fringe.c (syms_of_fringe):
6370 * insdel.c (syms_of_insdel):
6371 * keymap.c (syms_of_keymap):
6372 * lread.c (init_obarray, syms_of_lread):
6373 * macros.c (syms_of_macros):
6374 * msdos.c (syms_of_msdos):
6375 * print.c (syms_of_print):
6376 * process.c (syms_of_process):
6377 * search.c (syms_of_search):
6378 * sound.c (syms_of_sound):
6379 * syntax.c (init_syntax_once, syms_of_syntax):
6380 * terminal.c (syms_of_terminal):
6381 * textprop.c (syms_of_textprop):
6382 * undo.c (syms_of_undo):
6383 * w32.c (globals_of_w32):
6384 * window.c (syms_of_window):
6385 * xdisp.c (syms_of_xdisp):
6386 * xfaces.c (syms_of_xfaces):
6387 * xfns.c (syms_of_xfns):
6388 * xmenu.c (syms_of_xmenu):
6389 * xsettings.c (syms_of_xsettings):
6390 * xterm.c (syms_of_xterm): Use DEFSYM.
6392 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6394 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6396 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6398 Integer and buffer overflow fixes (Bug#8873).
6400 * print.c (printchar, strout): Check for string overflow.
6401 (PRINTPREPARE, printchar, strout):
6402 Don't set size unless allocation succeeds.
6404 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6405 for sizes. Check for string overflow more accurately.
6406 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6408 * macros.c: Integer and buffer overflow fixes.
6409 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6410 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6411 Use ptrdiff_t, not int, for sizes.
6412 Don't increment bufsize until after realloc succeeds.
6413 Check for size-calculation overflow.
6414 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6416 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6418 * lread.c: Integer overflow fixes.
6419 (read_integer): Radix is now EMACS_INT, not int,
6420 to improve quality of diagnostics for out-of-range radices.
6421 Calculate buffer size correctly for out-of-range radices.
6422 (read1): Check for integer overflow in radices, and in
6423 read-circle numbers.
6424 (read_escape): Avoid int overflow.
6425 (Fload, openp, read_buffer_size, read1)
6426 (substitute_object_recurse, read_vector, read_list, map_obarray):
6427 Use ptrdiff_t, not int, for sizes.
6428 (read1): Use EMACS_INT, not int, for sizes.
6429 Check for size overflow.
6431 * image.c (cache_image): Check for size arithmetic overflow.
6433 * lread.c: Integer overflow issues.
6434 (saved_doc_string_size, saved_doc_string_length)
6435 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6436 Now ptrdiff_t, not int.
6437 (read1): Don't assume doc string length fits in int. Check for
6438 out-of-range doc string lengths.
6439 (read_list): Don't assume file position fits in int.
6440 (read_escape): Check for hex character overflow.
6442 2011-06-22 Leo Liu <sdl.web@gmail.com>
6444 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6445 Move to minibuffer.el.
6447 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6449 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6450 The following patches are for when GLYPH_DEBUG && !XASSERT.
6451 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6452 * dispnew.c (flush_stdout):
6453 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6454 Mark as externally visible.
6455 * dispnew.c (check_window_matrix_pointers): Now static.
6456 * dispnew.c (window_to_frame_vpos):
6457 * xfns.c (unwind_create_frame):
6458 * xterm.c (x_check_font): Remove unused local.
6459 * scroll.c (CHECK_BOUNDS):
6460 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6461 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6462 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6463 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6464 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6466 (debug_method_add): Use va_list and vsprintf rather than relying
6467 on undefined behavior with wrong number of arguments.
6468 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6469 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6470 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6471 since we're not interested in debugging glyphs with old libraries.
6472 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6473 GCC 4.6.0's static checking.
6475 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6477 Integer overflow and signedness fixes (Bug#8873).
6478 A few related buffer overrun fixes, too.
6480 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6482 * dispextern.h (struct face.stipple):
6483 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6484 (x_bitmap_mask, x_allocate_bitmap_record)
6485 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6486 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6487 (x_create_bitmap_from_xpm_data):
6488 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6489 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6491 * xfaces.c (load_pixmap):
6492 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6493 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6494 (.bitmaps_last, struct x_output.icon_bitmap):
6495 Use ptrdiff_t, not int, for bitmap indexes.
6496 (x_allocate_bitmap_record): Check for size overflow.
6497 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6499 Use ptrdiff_t, not int, for overlay counts.
6500 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6501 * editfns.c (overlays_around, get_pos_property):
6502 * textprop.c (get_char_property_and_overlay):
6503 * xdisp.c (next_overlay_change, note_mouse_highlight):
6504 * xfaces.c (face_at_buffer_position):
6505 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6506 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6507 (Fnext_overlay_change, Fprevious_overlay_change)
6508 (mouse_face_overlay_overlaps, Foverlays_in):
6509 Use ptrdiff_t, not int, for sizes.
6510 (overlays_at, overlays_in): Check for size-calculation overflow.
6512 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6514 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6515 (x_session_initialize): Do not assume string length fits in int.
6517 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6518 This is unlikely, but can occur if DPI is outlandish.
6520 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6521 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6523 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6524 * xrdb.c (magic_file_p, search_magic_path):
6525 Omit last arg SUFFIX; it was always 0. All callers changed.
6526 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6528 * xfont.c (xfont_match): Avoid need for strlen.
6530 * xfns.c: Don't assume strlen fits in int.
6531 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6533 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6534 not unsigned long, as we prefer signed integers. All callers changed.
6535 Detect integer overflow in repeat count.
6536 (message_dolog): Don't assume print length fits in 39 bytes.
6537 (display_mode_element): Don't assume strlen fits in int.
6539 * termcap.c: Don't assume sizes fit in int and never overflow.
6540 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6541 (gobble_line): Check for size-calculation overflow.
6543 * minibuf.c (Fread_buffer):
6544 * lread.c (intern, intern_c_string):
6545 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6546 Don't assume string length fits in int.
6548 * keyboard.c (parse_tool_bar_item):
6549 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6551 * font.c: Don't assume string length fits in int.
6552 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6553 Use ptrdiff_t, not int.
6554 (font_intern_prop): Don't assume string length fits in int.
6555 Don't assume integer property fits in fixnum.
6556 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6558 * filelock.c: Fix some buffer overrun and integer overflow issues.
6559 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6560 Reformulate so as not to need the command string.
6561 Invoke gzip -cd rather than gunzip, as it's more portable.
6562 (lock_info_type, lock_file_1, lock_file):
6563 Don't assume pid_t and time_t fit in unsigned long.
6564 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6565 (current_lock_owner): Prefer signed type for sizes.
6566 Use memcpy, not strncpy, where memcpy is what is really wanted.
6567 Don't assume (via atoi) that time_t and pid_t fit in int.
6568 Check for time_t and/or pid_t out of range, e.g., via a network share.
6569 Don't alloca where an auto var works fine.
6571 * fileio.c: Fix some integer overflow issues.
6572 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6573 Don't assume string length fits in int.
6574 (directory_file_name): Don't assume string length fits in long.
6575 (make_temp_name): Don't assume pid fits in int, or that its print
6576 length is less than 20.
6578 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6580 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6582 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6584 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6585 We prefer signed integers, even for size calculations.
6587 * emacs.c: Don't assume string length fits in 'int'.
6588 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6589 (main): Don't invoke strlen when not needed.
6591 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6592 (XD_DEBUG_MESSAGE): Don't waste a byte.
6594 * callproc.c (getenv_internal_1, getenv_internal)
6596 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6598 * lread.c (invalid_syntax): Omit length argument.
6599 All uses changed. This doesn't fix a bug, but it simplifies the
6600 code away from its former Hollerith-constant appearance, and it's
6601 one less 'int' to worry about when looking at integer-overflow issues.
6602 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6604 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6605 This didn't break anything, but it didn't help either.
6606 It's confusing to put a bogus integer in a place where the actual
6607 value does not matter.
6608 (LIST_END_P): Remove unused macro and its bogus comment.
6609 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6611 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6612 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6614 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6615 We prefer signed types, and the value cannot exceed the EMACS_INT
6616 range anyway (because otherwise the length would not be representable).
6617 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6618 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6619 This avoids a GCC warning when WIDE_EMACS_INT.
6621 * indent.c (sane_tab_width): New function.
6622 (current_column, scan_for_column, Findent_to, position_indentation)
6623 (compute_motion): Use it. This is just for clarity.
6624 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6626 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6628 * lisp.h (lint_assume): New macro.
6629 * composite.c (composition_gstring_put_cache):
6630 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6632 * editfns.c, insdel.c:
6633 Omit unnecessary forward decls, to simplify future changes.
6635 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6637 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6639 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6640 Use much-faster test for byte-length change.
6641 Don't assume string byte-length fits in 'int'.
6642 Check that character arg fits in 'int'.
6643 (mapcar1): Declare byte as byte, for clarity.
6645 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6647 * fns.c (concat): Catch string overflow earlier.
6648 Do not rely on integer wraparound.
6650 * dispextern.h (struct it.overlay_strings_charpos)
6651 (struct it.selective): Now EMACS_INT, not int.
6652 * xdisp.c (forward_to_next_line_start)
6653 (back_to_previous_visible_line_start)
6654 (reseat_at_next_visible_line_start, next_element_from_buffer):
6655 Don't arbitrarily truncate the value of 'selective' to int.
6657 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6659 * composite.c: Don't truncate sizes to 'int'.
6660 (composition_gstring_p, composition_reseat_it)
6661 (composition_adjust_point): Use EMACS_INT, not int.
6662 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6663 not EMACS_UINT, for indexes.
6665 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6667 * buffer.c: Include <verify.h>.
6668 (struct sortvec.priority, struct sortstr.priority):
6669 Now EMACS_INT, not int.
6670 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6671 (struct sortstr.size, record_overlay_string)
6672 (struct sortstrlist.size, struct sortlist.used):
6673 Don't truncate size to int.
6674 (record_overlay_string): Check for size-calculation overflow.
6675 (init_buffer_once): Check at compile-time, not run-time.
6677 2011-06-22 Jim Meyering <meyering@redhat.com>
6679 Don't leak an XBM-image-sized buffer
6680 * image.c (xbm_load): Free the image buffer after using it.
6682 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6685 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6686 that Sun C diagnosed.
6687 * fns.c (secure_hash): Fix pointer signedness issue.
6688 * intervals.c (static_offset_intervals): New function.
6689 (offset_intervals): Use it.
6691 2011-06-21 Leo Liu <sdl.web@gmail.com>
6694 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6697 * fns.c (secure_hash): Rename from crypto_hash_function and change
6698 the first arg to accept symbols.
6699 (Fsecure_hash): New primitive.
6700 (syms_of_fns): New symbols.
6702 2011-06-20 Deniz Dogan <deniz@dogan.se>
6704 * process.c (Fset_process_buffer): Clarify return value in
6707 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6709 * dispnew.c (add_window_display_history): Use BVAR.
6711 * xdisp.c (debug_method_add): Use BVAR.
6712 (check_window_end, dump_glyph_matrix, dump_glyph)
6713 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6715 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6718 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6719 check till after the cache is created in init_frame_faces.
6721 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6723 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6725 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6727 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6728 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6729 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6731 Improve buffer-overflow checking (Bug#8873).
6732 * fileio.c (Finsert_file_contents):
6733 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6734 Remove the old (too-loose) buffer overflow checks.
6735 They weren't needed, since make_gap checks for buffer overflow.
6736 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6737 The old code merely checked for Emacs fixnum overflow, and relied
6738 on undefined (wraparound) behavior. The new code avoids undefined
6739 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6741 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6742 Tune. Don't use wider integers than needed. Don't use alloca.
6743 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6745 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6747 * insdel.c, lisp.h (buffer_overflow): New function.
6748 (insert_from_buffer_1, replace_range, replace_range_2):
6749 * insdel.c (make_gap_larger):
6750 * editfns.c (Finsert_char):
6751 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6753 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6755 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6757 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6759 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6760 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6762 * fileio.c: Don't assume EMACS_INT fits in off_t.
6763 (emacs_lseek): New static function.
6764 (Finsert_file_contents, Fwrite_region): Use it.
6765 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6767 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6769 * fns.c: Don't overflow int when computing a list length.
6770 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6771 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6772 truncation on 64-bit hosts. Check for QUIT every
6773 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6774 faster and is responsive enough.
6775 (Flength): Report an error instead of overflowing an integer.
6776 (Fsafe_length): Return a float if the value is not representable
6777 as a fixnum. This shouldn't happen except in contrived situations.
6778 (Fnthcdr, Fsort): Don't assume list length fits in int.
6779 (Fcopy_sequence): Don't assume vector length fits in int.
6781 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6782 (header_size, word_size): New constants.
6783 (allocate_vectorlike): Don't check size overflow here.
6784 (allocate_vector): Check it here instead, since this is the only
6785 caller of allocate_vectorlike that could cause overflow.
6786 Check that the new vector's length is representable as a fixnum.
6788 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6789 The previous code was bogus. For example, next_almost_prime (32)
6790 returned 39, which is undesirable as it is a multiple of 3; and
6791 next_almost_prime (24) returned 25, which is a multiple of 5 so
6792 why was the code bothering to check for multiples of 7?
6794 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6796 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6798 Variadic C functions now count arguments with ptrdiff_t.
6799 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6800 Back then I didn't know that the Emacs coding style prefers signed int.
6801 Also, in the meantime I found a few more instances where arguments
6802 were being counted with int, which may truncate counts on 64-bit
6803 machines, or EMACS_INT, which may be unnecessarily wide.
6804 * lisp.h (struct Lisp_Subr.function.aMANY)
6805 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6806 Arg counts are now ptrdiff_t, not size_t.
6807 All variadic functions and their callers changed accordingly.
6808 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6809 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6810 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6811 * callint.c (Fcall_interactively): Check arg count for overflow,
6812 to avoid potential buffer overrun. Use signed char, not 'int',
6813 for 'varies' array, so that we needn't bother to check its size
6814 calculation for overflow.
6815 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6816 * eval.c (apply_lambda):
6817 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6818 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6819 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6821 * callint.c (Fcall_interactively): Don't use index var as event count.
6823 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6824 * mem-limits.h (SIZE): Remove; no longer used.
6826 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6828 Remove unnecessary casts.
6829 * xterm.c (x_term_init):
6830 * xfns.c (x_set_border_pixel):
6831 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6832 These aren't needed now that we assume ANSI C.
6834 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6835 It's more likely to cause problems (due to unsigned overflow)
6838 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6840 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6842 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6844 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6846 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6848 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6850 GLYPH_CODE_FACE returns EMACS_INT, not int.
6851 * dispextern.h (merge_faces):
6852 * xfaces.c (merge_faces):
6853 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6854 Don't assume EMACS_INT fits in int.
6856 * character.h (CHAR_VALID_P): Remove unused parameter.
6857 * fontset.c, lisp.h, xdisp.c: All uses changed.
6859 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6861 * fns.c (concat): Minor tuning based on overflow analysis.
6862 This doesn't fix any bugs. Use int to hold character, instead
6863 of constantly refetching from Emacs object. Use XFASTINT, not
6864 XINT, for value known to be a character. Don't bother comparing
6865 a single byte to 0400, as it's always less.
6867 * floatfns.c (Fexpt):
6868 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6870 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6873 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6875 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6876 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6877 incorrectly succeed when S was a string, because 4294967386 was
6878 truncated before it was used.
6880 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6881 Otherwise, an out-of-range integer could cause undefined behavior
6884 * composite.c: Use int, not EMACS_INT, for characters.
6885 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6886 EMACS_INT, for values that are known to be in character range.
6887 This doesn't fix any bugs but is the usual style inside Emacs and
6888 may generate better code on 32-bit machines.
6890 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6891 This is for reasons similar to the recent CHAR_STRING fix.
6892 * charset.c (Fencode_char): Check that character arg is actually
6893 a character. Pass an int to ENCODE_CHAR.
6894 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6895 wider than 'int', as a compile-time check to prevent future regressions
6898 * character.c (char_string): Remove unnecessary casts.
6900 Make sure a 64-bit char is never passed to CHAR_STRING.
6901 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6902 by silently ignoring the top 32 bits, allowing some values
6903 that were far too large to be valid characters.
6904 * character.h: Include <verify.h>.
6905 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6906 arguments are no wider than unsigned, as a compile-time check
6907 to prevent future regressions in this area.
6909 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6910 (Fsubst_char_in_region):
6912 * xdisp.c (decode_mode_spec_coding):
6913 Adjust to CHAR_STRING's new requirement.
6914 * editfns.c (Finsert_char, Fsubst_char_in_region):
6915 * fns.c (concat): Check that character args are actually
6916 characters. Without this test, these functions did the wrong
6917 thing with wildly out-of-range values on 64-bit hosts.
6919 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6920 These casts should not be needed on 32-bit hosts, either.
6921 * keyboard.c (read_char):
6922 * lread.c (Fload): Remove casts to unsigned.
6924 * lisp.h (UNSIGNED_CMP): New macro.
6925 This fixes comparison bugs on 64-bit hosts.
6926 (ASCII_CHAR_P): Use it.
6927 * casefiddle.c (casify_object):
6928 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6929 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6930 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6931 * dispextern.h (FACE_FROM_ID):
6932 * keyboard.c (read_char): Use UNSIGNED_CMP.
6934 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6935 not to EMACS_INT, to avoid GCC warning.
6937 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6939 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6940 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6941 isn't needed on 32-bit machines.
6943 * buffer.c (Fgenerate_new_buffer_name):
6944 Use EMACS_INT for count, not int.
6945 (advance_to_char_boundary): Return EMACS_INT, not int.
6947 * data.c (Qcompiled_function): Now static.
6949 * window.c (window_body_lines): Now static.
6951 * image.c (gif_load): Rename local to avoid shadowing.
6953 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6954 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6955 * alloc.c (make_save_value): Integer argument is now of type
6957 (mark_object): Use ptrdiff_t, not int.
6958 * lisp.h (pD): New macro.
6959 * print.c (print_object): Use it.
6961 * alloc.c: Use EMACS_INT, not int, to count objects.
6962 (total_conses, total_markers, total_symbols, total_vector_size)
6963 (total_free_conses, total_free_markers, total_free_symbols)
6964 (total_free_floats, total_floats, total_free_intervals)
6965 (total_intervals, total_strings, total_free_strings):
6966 Now EMACS_INT, not int. All uses changed.
6967 (Fgarbage_collect): Compute overall total using a double, so that
6968 integer overflow is less likely to be a problem. Check for overflow
6969 when converting back to an integer.
6970 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6971 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6972 These were 'int' variables that could overflow on 64-bit hosts;
6973 they were never used, so remove them instead of repairing them.
6974 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6975 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6976 Previously, this ceilinged at INT_MAX, but that doesn't work on
6978 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6980 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6981 (allocate_vectorlike): Check for ptrdiff_t overflow.
6982 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6983 when a (possibly-narrower) signed value would do just as well.
6984 We prefer using signed arithmetic, to avoid comparison confusion.
6986 * alloc.c: Catch some string size overflows that we were missing.
6987 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6988 for convenience in STRING_BYTES_MAX.
6989 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6990 The definition here is exact; the one in lisp.h was approximate.
6991 (allocate_string_data): Check for string overflow. This catches
6992 some instances we weren't catching before. Also, it catches
6993 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6994 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6995 and ptrdiff_t and EMACS_INT are both 64 bits.
6997 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6998 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6999 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7001 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7003 * alloc.c (Fmake_string): Check for out-of-range init.
7005 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7007 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7009 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7011 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7012 xg_get_default_scrollbar_width.
7014 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7015 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7016 (style_changed_cb): Call update_theme_scrollbar_width and call
7017 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7018 all frames (Bug#8505).
7019 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7020 Call gtk_window_set_resizable if HAVE_GTK3.
7021 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7022 and height if HAVE_GTK3 (Bug#8505).
7023 (scroll_bar_width_for_theme): New variable.
7024 (update_theme_scrollbar_width): New function.
7025 (xg_get_default_scrollbar_width): Move code to
7026 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7027 (xg_initialize): Call update_theme_scrollbar_width.
7029 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7031 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7033 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7035 * frame.c (make_frame): Call other_buffer_safely instead of
7038 * window.c (temp_output_buffer_show): Call display_buffer with
7039 second argument Vtemp_buffer_show_specifiers and reset latter
7040 immediately after the call.
7041 (Vtemp_buffer_show_specifiers): New variable.
7042 (auto_window_vscroll_p, next_screen_context_lines)
7043 (Vscroll_preserve_screen_position): Remove leading asterisks from
7046 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7048 Fix minor problems found by GCC 4.6.0 static checking.
7049 * buffer.c (Qclone_number): Remove for now, as it's unused.
7050 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7051 (record_buffer): Remove unused local.
7052 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7053 (set_frame_buffer_list): Remove; unused.
7054 * frame.h (other_visible_frames): Remove decl.
7055 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7056 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7057 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7059 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7060 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7061 Define only if HAVE_GPM.
7062 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7063 (update_hints_inhibit): Remove; never set. All uses removed.
7064 * widgetprv.h (emacsFrameClassRec): Remove decl.
7065 * window.c (delete_deletable_window): Now returns void, since it
7066 wasn't returning anything.
7067 (compare_window_configurations): Remove unused locals.
7068 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7069 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7070 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7071 the same widths as pointers. This follows up on the 2011-05-06 patch.
7072 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7073 * xterm.h: Likewise.
7074 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7076 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7078 * makefile.w32-in: Update dependencies.
7079 (LISP_H): Add lib/intprops.h.
7081 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7083 * image.c (gif_load): Add animation frame delay to the metadata.
7084 (syms_of_image): Use DEFSYM. New symbol `delay'.
7086 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7088 * window.c (delete_deletable_window): Re-add.
7089 (Fset_window_configuration): Rewrite to handle dead buffers and
7090 consequently deletable windows.
7091 (window_tree, Fwindow_tree): Remove. Supply functionality in
7093 (compare_window_configurations): Simplify code.
7095 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7097 * image.c (imagemagick_load_image): Fix type mismatch.
7098 (Fimagemagick_types): Likewise.
7100 * window.h (replace_buffer_in_windows): Declare.
7102 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7104 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7105 Qclone_number. Remove external declaration of Qdelete_window.
7106 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7108 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7109 Run Qbuffer_list_update_hook if allowed.
7110 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7111 buffer list implementation.
7112 (other_buffer_safely): New function.
7113 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7114 calls to replace_buffer_in_windows and
7115 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7117 (record_buffer): Inhibit quitting and rewrite using quittable
7118 functions. Run Qbuffer_list_update_hook if allowed.
7119 (Frecord_buffer, Funrecord_buffer): New functions.
7120 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7121 Move switch-to-buffer to window.el.
7122 (bury-buffer): Move to window.el.
7123 (Vbuffer_list_update_hook): New variable.
7125 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7128 * window.h (resize_frame_windows): Move up in code.
7129 (Fwindow_frame): Remove EXFUN.
7130 (replace_buffer_in_all_windows): Remove prototype.
7131 (replace_buffer_in_windows_safely): Add prototype.
7133 * window.c: Declare Qdelete_window static again. Move down
7134 declaration of select_count.
7135 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7136 (Fother_window): Move to window.el.
7137 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7138 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7139 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7141 (replace_buffer_in_windows): Implement by calling
7142 Qreplace_buffer_in_windows.
7143 (replace_buffer_in_all_windows): Remove with some functionality
7144 moved into replace_buffer_in_windows_safely.
7145 (replace_buffer_in_windows_safely): New function.
7146 (select_window_norecord, select_frame_norecord): Move in front
7147 of run_window_configuration_change_hook. Remove now obsolete
7149 (Fset_window_buffer): Rewrite doc-string.
7150 Call Qrecord_window_buffer.
7151 (keys_of_window): Move binding for other-window to window.el.
7153 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7155 * dispextern.h (struct image): Replace data member, whose int_val
7156 and ptr_val fields were not used by anything, with a single
7159 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7160 (gif_clear_image, gif_load, imagemagick_load_image)
7161 (gs_clear_image, gs_load): Callers changed.
7163 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7165 * buffer.h: Include <time.h>, for time_t.
7166 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7168 Fix minor problems found by static checking.
7170 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7172 Make identifiers static if they are not used in other modules.
7173 * data.c (Qcompiled_function, Qframe, Qvector):
7174 * image.c (QimageMagick, Qsvg):
7175 * minibuf.c (Qmetadata):
7176 * window.c (resize_window_check, resize_root_window): Now static.
7177 * window.h (resize_window_check, resize_root_window): Remove decls.
7179 * window.c (window_deletion_count, delete_deletable_window):
7181 (window_body_lines): Now static.
7182 (Fdelete_other_windows_internal): Mark vars as initialized.
7183 Make sure 'resize_failed' is initialized.
7184 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7185 (resize_window_apply): Remove unused local.
7186 * window.h (delete_deletable_window): Remove decl.
7188 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7189 (imagemagick_load_image): Fix pointer signedness problem by changing
7190 last arg from unsigned char * to char *. All uses changed.
7191 Also, fix a local for similar reasons.
7192 Remove unused locals. Remove locals to avoid shadowing.
7193 (fn_rsvg_handle_free): Remove; unused.
7194 (svg_load, svg_load_image): Fix pointer signedness problem.
7195 (imagemagick_load_image): Don't use garbage pointer image_wand.
7197 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7199 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7201 * image.c (gif_load): Fix omitted cast error introduced by
7204 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7206 * window.h (resize_proportionally, orig_total_lines)
7207 (orig_top_line): Remove from window structure.
7208 (set_window_height, set_window_width, change_window_heights)
7209 (Fdelete_window): Remove prototypes.
7210 (resize_frame_windows): Remove duplicate declaration.
7212 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7214 * window.h (resize_frame_windows, resize_window_check)
7215 (delete_deletable_window, resize_root_window)
7216 (resize_frame_windows): Declare prototypes.
7218 * window.c (resize_window_apply): Make definition be "static" to
7219 match the prototype.
7221 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7223 * window.c: Remove declarations of Qwindow_size_fixed,
7224 window_min_size_1, window_min_size_2, window_min_size,
7225 size_window, window_fixed_size_p, enlarge_window, delete_window.
7226 Remove static from declaration of Qdelete_window, it's
7227 temporarily needed by Fbury_buffer.
7228 (replace_window): Don't assign orig_top_line and
7230 (Fdelete_window, delete_window): Remove. Window deletion is
7231 handled by window.el.
7232 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7233 Replace Fdelete_window calls with calls to Qdelete_window.
7234 (Fdelete_other_windows): Remove. Deleting other windows is
7235 handled by window.el.
7236 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7237 handled in window.el.
7238 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7239 Window minimum sizes are handled in window.el.
7240 (shrink_windows, size_window, set_window_height)
7241 (set_window_width, change_window_heights, window_height)
7242 (window_width, CURBEG, CURSIZE, enlarge_window)
7243 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7244 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7245 handled in window.el.
7246 (make_dummy_parent): Rename to make_parent_window and give it a
7247 second argument horflag.
7248 (make_window): Don't set resize_proportionally any more.
7249 (Fsplit_window): Remove. Windows are split in window.el.
7250 (save_restore_action, save_restore_orig_size)
7251 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7252 Resize mini windows in window.el.
7253 (grow_mini_window, shrink_mini_window): Implement by calling
7254 Qresize_root_window_vertically, resize_window_check and
7255 resize_window_apply.
7256 (saved_window, Fset_window_configuration, save_window_save):
7257 Do not handle orig_top_line, orig_total_lines, and
7258 resize_proportionally.
7259 (window_min_height, window_min_width): Move to window.el.
7260 (keys_of_window): Move bindings for delete-other-windows,
7261 split-window, delete-window and enlarge-window to window.el.
7263 * buffer.c: Temporarily extern Qdelete_window.
7264 (Fbury_buffer): Temporarily call Qdelete_window instead of
7265 Fdelete_window (Fbury_buffer will move to window.el soon).
7267 * frame.c (set_menu_bar_lines_1): Remove code handling
7268 orig_top_line and orig_total_lines.
7270 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7271 set_window_height but set heights directly.
7272 (change_frame_size_1): Use resize_frame_windows.
7274 * xdisp.c (init_xdisp): Don't use set_window_height but set
7277 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7278 Use resize_frame_windows instead of change_window_heights and run
7279 run_window_configuration_change_hook.
7281 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7282 instead of change_window_heights and run
7283 run_window_configuration_change_hook.
7285 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7287 * window.c (replace_window): Rename second argument REPLACEMENT to
7288 NEW. New third argument SETFLAG. Rewrite.
7289 (delete_window, make_dummy_parent): Call replace_window with
7291 (window_list_1): Move down in code.
7292 (run_window_configuration_change_hook): Move set_buffer part
7293 before select_frame_norecord part in order to unwind correctly.
7294 Rename count1 to count.
7295 (recombine_windows, delete_deletable_window, resize_root_window)
7296 (Fdelete_other_windows_internal)
7297 (Frun_window_configuration_change_hook, make_parent_window)
7298 (resize_window_check, resize_window_apply, Fresize_window_apply)
7299 (resize_frame_windows, Fsplit_window_internal)
7300 (Fdelete_window_internal, Fresize_mini_window_internal):
7302 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7304 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7306 * window.h (window): Add some new members to window structure -
7307 normal_lines, normal_cols, new_total, new_normal, clone_number,
7308 splits, nest, prev_buffers, next_buffers.
7309 (WINDOW_TOTAL_SIZE): Move here from window.c.
7310 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7312 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7314 (make_dummy_parent): Set new members of windows structure.
7315 (make_window): Move down in code. Handle new members of window
7317 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7318 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7319 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7320 (Fset_window_prev_buffers, Fwindow_next_buffers)
7321 (Fset_window_next_buffers, Fset_window_clone_number):
7323 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7324 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7326 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7327 Argument WINDOW can be now internal window too.
7328 (Fwindow_use_time): Move up in code.
7329 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7331 (Fset_window_configuration, saved_window)
7332 (Fcurrent_window_configuration, save_window_save): Handle new
7333 members of window structure.
7334 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7335 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7336 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7337 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7338 Qget_mru_window, Qresize_root_window,
7339 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7340 Qauto_buffer_name; staticpro them.
7342 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7344 * window.c (Fwindow_total_size, Fwindow_left_column)
7345 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7346 (Fwindow_list_1): New functions.
7347 (window_box_text_cols): Replace with window_body_cols.
7348 (Fwindow_width, Fscroll_left, Fscroll_right):
7349 Use window_body_cols instead of window_box_text_cols.
7350 (delete_window, Fset_window_configuration):
7351 Call delete_all_subwindows with window as argument.
7352 (delete_all_subwindows): Take a window as argument and not a
7354 (window_loop): Remove handling of GET_LRU_WINDOW and
7356 (Fget_lru_window, Fget_largest_window): Move to window.el.
7358 * window.h: Extern window_body_cols instead of
7359 window_box_text_cols. delete_all_subwindows now takes a
7360 Lisp_Object as argument.
7362 * indent.c (compute_motion, Fcompute_motion):
7363 Use window_body_cols instead of window_box_text_cols.
7365 * frame.c (delete_frame): Call delete_all_subwindows with root
7368 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7370 * fns.c (Fputhash): Document return value.
7372 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7374 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7376 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7378 Cons<->int and similar integer overflow fixes (Bug#8794).
7380 Check for overflow when converting integer to cons and back.
7381 * charset.c (Fdefine_charset_internal, Fdecode_char):
7382 Use cons_to_unsigned to catch overflow.
7383 (Fencode_char): Use INTEGER_TO_CONS.
7384 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7385 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7386 * data.c (long_to_cons, cons_to_long): Remove.
7387 (cons_to_unsigned, cons_to_signed): New functions.
7388 These signal an error for invalid or out-of-range values.
7389 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7390 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7391 * font.c (Ffont_variation_glyphs):
7392 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7393 * lisp.h: Include <intprops.h>.
7394 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7395 (cons_to_signed, cons_to_unsigned): New decls.
7396 (long_to_cons, cons_to_long): Remove decls.
7397 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7398 (Fprimitive_undo): Use CONS_TO_INTEGER.
7399 * xfns.c (Fx_window_property): Likewise.
7400 * xselect.c: Include <limits.h>.
7401 (x_own_selection, selection_data_to_lisp_data):
7402 Use INTEGER_TO_CONS.
7403 (x_handle_selection_request, x_handle_selection_clear)
7404 (x_get_foreign_selection, Fx_disown_selection_internal)
7405 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7406 (lisp_data_to_selection_data): Use cons_to_unsigned.
7407 (x_fill_property_data): Use cons_to_signed.
7408 Report values out of range.
7410 Check for buffer and string overflow more precisely.
7411 * buffer.h (BUF_BYTES_MAX): New macro.
7412 * lisp.h (STRING_BYTES_MAX): New macro.
7413 * alloc.c (Fmake_string):
7414 * character.c (string_escape_byte8):
7415 * coding.c (coding_alloc_by_realloc):
7416 * doprnt.c (doprnt):
7417 * editfns.c (Fformat):
7419 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7420 since they may not be the same number.
7421 * editfns.c (Finsert_char):
7422 * fileio.c (Finsert_file_contents):
7423 Likewise for BUF_BYTES_MAX.
7425 * image.c: Use ptrdiff_t, not int, for sizes.
7426 (slurp_file): Switch from int to ptrdiff_t.
7428 (slurp_file): Check that file size fits in both size_t (for
7429 malloc) and ptrdiff_t (for sanity and safety).
7431 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7432 if b->modtime has its maximal value.
7434 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7436 Don't assume time_t can fit into int.
7437 * buffer.h (struct buffer.modtime): Now time_t, not int.
7438 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7439 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7441 Minor fixes for signed vs unsigned integers.
7442 * character.h (MAYBE_UNIFY_CHAR):
7443 * charset.c (maybe_unify_char):
7444 * keyboard.c (read_char, reorder_modifiers):
7445 XINT -> XFASTINT, since the integer must be nonnegative.
7446 * ftfont.c (ftfont_spec_pattern):
7447 * keymap.c (access_keymap, silly_event_symbol_error):
7448 XUINT -> XFASTINT, since the integer must be nonnegative.
7449 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7450 since it makes no difference and we prefer signed.
7451 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7452 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7455 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7457 * window.h (Fwindow_frame): Declare.
7459 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7461 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7462 (SPARE_MEMORY): Always define.
7463 (LARGE_REQUEST): Remove.
7464 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7466 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7468 * lisp.h: Move EXFUNS for Fframe_root_window,
7469 Fframe_first_window and Fset_frame_selected_window to window.h.
7471 * window.h: Move EXFUNS for Fframe_root_window,
7472 Fframe_first_window and Fset_frame_selected_window here from
7475 * frame.c (Fwindow_frame, Fframe_first_window)
7476 (Fframe_root_window, Fframe_selected_window)
7477 (Fset_frame_selected_window): Move to window.c.
7478 (Factive_minibuffer_window): Move to minibuf.c.
7479 (Fother_visible_frames_p): New function.
7481 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7483 * window.c (decode_window, decode_any_window): Move up in code.
7484 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7485 (inhibit_frame_unsplittable): Remove unused variable.
7486 (Fwindow_buffer): Move up and rewrite doc-string.
7487 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7488 (Fwindow_prev): New functions.
7489 (Fwindow_frame): Move here from frame.c. Accept any window as
7491 (Fframe_root_window, Fframe_first_window)
7492 (Fframe_selected_window): Move here from frame.c. Accept frame
7493 or arbitrary window as argument. Update doc-strings.
7494 (Fminibuffer_window): Move up in code.
7495 (Fwindow_minibuffer_p): Move up in code and simplify.
7496 (Fset_frame_selected_window): Move here from frame.c.
7498 (Fselected_window, select_window, Fselect_window): Move up in
7499 code. Minor doc-string fixes.
7501 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7503 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7504 Do not assume that spare memory exists; that assumption is valid
7505 only if SYSTEM_MALLOC.
7506 (LARGE_REQUEST): New macro, so that the issue of large requests
7507 is separated from the issue of spare memory.
7509 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7511 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7514 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7516 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7519 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7521 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7523 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7525 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7526 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7528 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7530 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7532 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7534 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7535 (x_clipboard_manager_save): Add return value.
7536 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7538 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7539 Obey Vx_select_enable_clipboard_manager. Catch errors in
7540 x_clipboard_manager_save (Bug#8779).
7541 (Vx_select_enable_clipboard_manager): New variable.
7542 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7544 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7546 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7548 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7550 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7551 in the current matrix if keep_current_p is non-zero.
7553 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7555 * bidi.c (bidi_level_of_next_char): Fix last change.
7557 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7559 Support bidi reordering of text covered by display properties.
7561 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7562 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7563 (bidi_cache_search, bidi_cache_iterator_state)
7564 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7565 (bidi_level_of_next_char, bidi_move_to_visually_next):
7566 Support character positions inside a run of characters covered by a
7568 (bidi_paragraph_init, bidi_resolve_explicit_1)
7569 (bidi_level_of_next_char): Call bidi_fetch_char and
7570 bidi_fetch_char_advance instead of FETCH_CHAR and
7572 (bidi_init_it): Initialize new members.
7573 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7575 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7576 instead of using explicit *_CHAR codes.
7577 (bidi_resolve_explicit, bidi_resolve_weak):
7578 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7579 bidirectional text is supported only in multibyte buffers.
7580 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7581 it to initialize the frame_window_p member of struct bidi_it.
7582 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7583 (bidi_resolve_explicit, bidi_resolve_weak)
7584 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7585 bidi_it->nchars is non-positive.
7586 (bidi_level_of_next_char): Don't try to lookup the cache for the
7587 next/previous character if nothing is cached there yet, or if we
7588 were just reseat()'ed to a new position.
7590 * xdisp.c (set_cursor_from_row): Set start and stop points
7591 according to the row's direction when priming the loop that looks
7592 for the glyph on which to display cursor.
7593 (single_display_spec_intangible_p): Function deleted.
7594 (display_prop_intangible_p): Reimplement to call
7595 handle_display_spec instead of single_display_spec_intangible_p.
7596 Accept 3 additional arguments needed by handle_display_spec.
7597 This fixes incorrect cursor motion across display property with complex
7598 values: lists, `(when COND...)' forms, etc.
7599 (single_display_spec_string_p): Support property values that are
7600 lists with the argument STRING its top-level element.
7601 (display_prop_string_p): Fix the condition for processing a
7602 property that is a list to be consistent with handle_display_spec.
7603 (handle_display_spec): New function, refactored from the
7604 last portion of handle_display_prop.
7605 (compute_display_string_pos): Accept additional argument
7606 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7607 value of a `display' property is a "replacing spec".
7608 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7609 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7610 the display property, but just return a value indicating whether
7611 the display property will replace the characters it covers.
7612 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7613 frame_window_p members of struct bidi_it.
7614 (compute_display_string_pos, compute_display_string_end):
7616 (push_it): Accept second argument POSITION, where pop_it should
7617 jump to continue iteration.
7618 (reseat_1): Initialize bidi_it.disp_pos.
7620 * keyboard.c (adjust_point_for_property): Adjust the call to
7621 display_prop_intangible_p to its new signature.
7623 * dispextern.h (struct bidi_it): New member frame_window_p.
7624 (bidi_init_it): Update prototypes.
7625 (display_prop_intangible_p): Update prototype.
7626 (compute_display_string_pos, compute_display_string_end):
7628 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7631 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7633 Malloc failure behavior now depends on size of allocation.
7634 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7635 * lisp.h: Change signatures accordingly.
7636 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7637 All callers changed. (Bug#8762)
7639 * gnutls.c: Use Emacs's memory allocators.
7640 Without this change, the gnutls library would invoke malloc etc.
7641 directly, which causes problems on non-SYNC_INPUT hosts, and which
7642 runs afoul of improving memory_full behavior. (Bug#8761)
7643 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7644 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7645 xfree instead of the default malloc, realloc, free.
7646 (Fgnutls_boot): No need to check for memory allocation failure,
7647 since xmalloc does that for us.
7649 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7650 * category.c (hash_get_category_set):
7651 * ccl.c (ccl_driver):
7652 * charset.c (Fdefine_charset_internal):
7653 * charset.h (struct charset.hash_index):
7654 * composite.c (get_composition_id, gstring_lookup_cache)
7655 (composition_gstring_put_cache):
7656 * composite.h (struct composition.hash_index):
7657 * dispextern.h (struct image.hash):
7658 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7659 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7660 (hashfn_equal, hashfn_user_defined, make_hash_table)
7661 (maybe_resize_hash_table, hash_lookup, hash_put)
7662 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7663 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7664 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7665 * image.c (make_image, search_image_cache, lookup_image)
7666 (xpm_put_color_table_h):
7667 * lisp.h (struct Lisp_Hash_Table):
7668 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7669 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7670 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7671 * alloc.c (allocate_vectorlike):
7672 Check for overflow in vector size calculations.
7673 * ccl.c (ccl_driver):
7674 Check for overflow when converting EMACS_INT to int.
7675 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7676 need to be updated by these changes.
7677 * fns.c (make_hash_table, maybe_resize_hash_table):
7678 Check for integer overflow with large hash tables.
7679 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7680 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7681 (SXHASH_REDUCE): New macro.
7682 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7683 Use it instead of discarding useful hash info with large hash values.
7684 (sxhash_float): New function.
7685 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7686 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7687 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7688 Rewrite to use FIXNUM_BITS, as this simplifies things.
7689 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7690 Adjust signatures to match updated version of code.
7691 (consing_since_gc): Now EMACS_INT, since a single hash table can
7692 use more than INT_MAX bytes.
7694 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7696 Make it possible to build with GCC-4.6+ -O2 -flto.
7698 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7700 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7702 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7703 Call minibuffer-inactive-mode.
7705 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7707 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7708 Update dependencies.
7710 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7712 * data.c (init_data): Remove code for UTS, this system is not
7715 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7717 Don't force ./temacs to start in terminal mode.
7719 * frame.c (make_initial_frame): Initialize faces in all cases, not
7720 only when CANNOT_DUMP is defined.
7721 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7723 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7725 * dispnew.c (add_window_display_history): Use const for the string
7726 pointer. Remove declaration, not needed.
7728 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7730 Use 'inline', not 'INLINE'.
7731 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7732 * alloc.c, fontset.c (INLINE): Remove.
7733 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7734 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7735 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7736 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7737 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7739 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7741 Make it possible to run ./temacs.
7743 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7744 syms_of_callproc does the same thing. Remove test for
7745 "initialized", do it in the caller.
7746 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7748 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7750 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7751 (read_minibuf): Use get_minibuffer.
7752 (syms_of_minibuf): Use DEFSYM.
7753 (Qmetadata): New var.
7754 * data.c (Qbuffer): Don't make it static.
7755 (syms_of_data): Use DEFSYM.
7757 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7759 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7760 (CCL_CODE_MIN): New macro.
7762 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7764 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7766 * eval.c (Qdebug): Now static.
7767 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7768 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7769 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7771 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7773 * image.c: Various fixes to ImageMagick code comments.
7774 (Fimagemagick_types): Doc fix.
7776 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7778 Minor fixes prompted by GCC 4.6.0 warnings.
7780 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7782 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7783 (x_clipboard_manager_save_all): Move extern decl to ...
7784 * xterm.h: ... here, so that it can be checked for consistency.
7786 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7788 * xselect.c (x_clipboard_manager_save_frame)
7789 (x_clipboard_manager_save_all): New functions.
7790 (Fx_clipboard_manager_save): Lisp function deleted.
7792 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7793 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7795 * xterm.h: Update prototype.
7797 2011-05-28 William Xu <william.xwl@gmail.com>
7799 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7802 2011-05-28 Jim Meyering <meyering@redhat.com>
7804 Avoid a sign-extension bug in crypto_hash_function.
7805 * fns.c (to_uchar): Define.
7806 (crypto_hash_function): Use it to convert some newly-signed
7807 variables to unsigned, to avoid sign-extension bugs. For example,
7808 without this change, (md5 "truc") would evaluate to
7809 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7810 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7811 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7813 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7815 Integer overflow fixes.
7817 * dbusbind.c: Serial number integer overflow fixes.
7818 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7819 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7820 to hold a serial number that is too large for a fixnum.
7821 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7822 Check for serial numbers out of range. Decode any serial number
7823 that was so large that it became a float. (Bug#8722)
7825 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7826 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7827 Use XFASTINT rather than XUINT when numbers are nonnegative.
7828 (xd_append_arg, Fdbus_method_return_internal):
7829 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7830 arguments, check that Lisp number is nonnegative, rather than
7831 silently wrapping negative numbers around. (Bug#8722)
7832 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7835 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7837 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7839 ccl: Add integer overflow checks.
7840 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7841 (IN_INT_RANGE): New macros.
7842 (ccl_driver): Use them to check for integer overflow when
7843 decoding a CCL program. Many of the new checks are whether XINT (x)
7844 fits in int; it doesn't always, on 64-bit hosts. The new version
7845 doesn't catch all possible integer overflows, but it's an
7846 improvement. (Bug#8719)
7848 * alloc.c (make_event_array): Use XINT, not XUINT.
7849 There's no need for unsigned here.
7851 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7852 This follows up to the 2011-05-06 change that substituted uintptr_t
7853 for EMACS_INT. This case wasn't caught back then.
7855 Rework Fformat to avoid integer overflow issues.
7856 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7857 now (part of C89). Include <verify.h>.
7858 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7859 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7860 (Fformat): Avoid the prepass trying to compute sizes; it was only
7861 approximate and thus did not catch overflow reliably. Instead, walk
7862 through the format just once, formatting and computing sizes as we go,
7863 checking for integer overflow at every step, and allocating a larger
7864 buffer as needed. Keep track separately whether the format is
7865 multibyte. Keep only the most-recently calculated precision, rather
7866 than them all. Record whether each argument has been converted to
7867 string. Use EMACS_INT, not int, for byte and char and arg counts.
7868 Support field widths and precisions larger than INT_MAX. Avoid
7869 sprintf's undefined behavior with conversion specifications such as %#d
7870 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7871 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7872 formatting out-of-range floating point numbers with int
7875 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7877 * data.c: Avoid integer truncation in expressions involving floats.
7878 * data.c: Include <intprops.h>.
7879 (arith_driver): When there's an integer overflow in an expression
7880 involving floating point, convert the integers to floating point
7881 so that the resulting value does not suffer from catastrophic
7882 integer truncation. For example, on a 64-bit host (* 4
7883 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7884 Do not rely on undefined behavior after integer overflow.
7886 merge count_size_as_multibyte, parse_str_to_multibyte
7887 * character.c, character.h (count_size_as_multibyte):
7888 Rename from parse_str_to_multibyte; all uses changed.
7889 Check for integer overflow.
7890 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7891 since it's now a duplicate of the other. This is more of
7892 a character than a buffer op, so better that it's in character.c.
7893 * fns.c, print.c: Adjust to above changes.
7895 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7897 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7899 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7901 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7902 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7903 (x_clipboard_manager_save): Now static.
7904 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7906 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7907 (crypto_hash_function): Now static.
7908 Fix pointer signedness problems. Avoid unnecessary initializations.
7910 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7912 * termhooks.h (Vselection_alist): Make it terminal-local.
7914 * terminal.c (create_terminal): Initialize it.
7916 * xselect.c: Support for clipboard managers.
7917 (Vselection_alist): Move to termhooks.h as terminal-local var.
7918 (LOCAL_SELECTION): New macro.
7919 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7920 (symbol_to_x_atom): Remove gratuitous arg.
7921 (x_handle_selection_request, lisp_data_to_selection_data)
7922 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7923 (x_own_selection, x_get_local_selection, x_convert_selection):
7924 New arg, specifying work frame. Use terminal-local Vselection_alist.
7925 (some_frame_on_display): Delete unused function.
7926 (Fx_own_selection_internal, Fx_get_selection_internal)
7927 (Fx_disown_selection_internal, Fx_selection_owner_p)
7928 (Fx_selection_exists_p): New optional frame arg.
7929 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7930 (x_handle_selection_clear): Don't treat other terminals with the
7931 same keyboard specially. Use the terminal-local Vselection_alist.
7932 (x_clear_frame_selections): Use Frun_hook_with_args.
7934 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7936 * xterm.h: Add support for those atoms.
7938 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7940 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7941 (converted_selections, conversion_fail_tag): New global variables.
7942 (x_selection_request_lisp_error): Free the above.
7943 (x_get_local_selection): Remove unnecessary code.
7944 (x_reply_selection_request): Args changed; handle arbitrary array
7945 of converted selections stored in converted_selections.
7946 Separate the XChangeProperty and SelectionNotify steps.
7947 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7948 (x_convert_selection): New function.
7949 (x_handle_selection_event): Simplify.
7950 (x_get_foreign_selection): Don't ignore incoming requests while
7951 waiting for an answer; this will fail when we implement
7952 SAVE_TARGETS, and seems unnecessary anyway.
7953 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7954 (Vx_sent_selection_functions): Doc fix.
7956 2011-05-26 Leo Liu <sdl.web@gmail.com>
7958 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7960 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7962 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7964 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7965 for fringe update if it has periodic bitmap.
7966 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7967 and fringe_bitmap_periodic_p.
7969 * fringe.c (get_fringe_bitmap_data): New function.
7970 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7971 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7972 row. Mark glyph row for fringe update if periodicity changed.
7974 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7975 for fringe update unless it has periodic bitmap.
7977 2011-05-25 Kenichi Handa <handa@m17n.org>
7979 * xdisp.c (get_next_display_element): Set correct it->face_id for
7980 a static composition.
7982 2011-05-24 Leo Liu <sdl.web@gmail.com>
7985 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7987 * fns.c (crypto_hash_function, Fsha1): New function.
7988 (Fmd5): Use crypto_hash_function.
7989 (syms_of_fns): Add Ssha1.
7991 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7993 * gnutls.c: Remove unused macros.
7994 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7995 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7996 Remove macros that are defined and never used.
7997 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7999 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8001 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8002 (Fx_get_selection_internal): Minor cleanup.
8003 (Fx_own_selection_internal): Rename arguments for consistency with
8006 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8008 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8010 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8012 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8014 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8016 * dispnew.c (scrolling_window): Don't exclude the case that the
8017 last enabled row in the desired matrix touches the bottom boundary.
8019 2011-05-21 Glenn Morris <rgm@gnu.org>
8021 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8022 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8023 and add some more files.
8025 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8027 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8028 report_file_error introduced by the change from 2011-05-07.
8030 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8032 * systime.h (Time): Define only if emacs is defined.
8033 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8034 where the include path doesn't have X11/X.h by default. See
8035 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8037 2011-05-20 Kenichi Handa <handa@m17n.org>
8039 * composite.c (find_automatic_composition): Fix previous change.
8041 2011-05-20 Glenn Morris <rgm@gnu.org>
8043 * lisp.mk: New file, split from Makefile.in.
8044 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8045 (shortlisp): Remove.
8046 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8048 2011-05-19 Glenn Morris <rgm@gnu.org>
8050 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8051 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8052 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8053 (lisp): Set the order to that of loadup.el.
8054 (shortlisp): Make it a copy of $lisp.
8055 (SOME_MACHINE_LISP): Remove.
8056 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8057 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8059 2011-05-18 Kenichi Handa <handa@m17n.org>
8061 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8062 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8063 (find_automatic_composition): Mostly rewrite for efficiency.
8065 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8067 * makefile.w32-in: Update dependencies.
8069 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8071 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8072 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8074 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8076 Fix some integer overflow issues, such as string length overflow.
8078 * insdel.c (count_size_as_multibyte): Check for string overflow.
8080 * character.c (lisp_string_width): Check for string overflow.
8081 Use EMACS_INT, not int, for string indexes and lengths; in
8082 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8083 the resulting string length overflows an EMACS_INT; instead,
8084 report a string overflow if no precision given. When checking for
8085 precision exhaustion, use a check that cannot possibly have
8086 integer overflow. (Bug#8675)
8087 * character.h (lisp_string_width): Adjust to new signature.
8089 * alloc.c (string_overflow): New function.
8090 (Fmake_string): Use it. This doesn't change behavior, but saves
8091 a few bytes and will simplify future changes.
8092 * character.c (string_escape_byte8): Likewise.
8093 * lisp.h (string_overflow): New decl.
8095 Fixups, following up to the user-interface timestamp change.
8096 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8097 for UI timestamps, instead of unsigned long.
8098 * msdos.c (mouse_get_pos): Likewise.
8099 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8100 * w32gui.h (Time): Define by including "systime.h" rather than by
8101 declaring it ourselves. (Bug#8664)
8103 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8104 * image.c (clear_image_cache): Likewise.
8106 * term.c (term_mouse_position): Don't assume time_t wraparound.
8108 Be more systematic about user-interface timestamps.
8109 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8110 and sometimes 'EMACS_UINT', to represent these timestamps.
8111 This change causes it to use 'Time' uniformly, as that's what X uses.
8112 This makes the code easier to follow, and makes it easier to catch
8113 integer overflow bugs such as Bug#8664.
8114 * frame.c (Fmouse_position, Fmouse_pixel_position):
8115 Use Time, not unsigned long, for user-interface timestamps.
8116 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8117 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8118 * keyboard.h (last_event_timestamp): Likewise.
8119 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8120 * menu.h (xmenu_show): Likewise.
8121 * term.c (term_mouse_position): Likewise.
8122 * termhooks.h (struct input_event.timestamp): Likewise.
8123 (struct terminal.mouse_position_hook): Likewise.
8124 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8125 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8126 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8127 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8129 * menu.h, termhooks.h: Include "systime.h", for Time.
8131 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8132 Don't assume that the difference between two unsigned long values
8133 can fit into an integer. At this point, we know button_down_time
8134 <= event->timestamp, so the difference must be nonnegative, so
8135 there's no need to cast the result if double-click-time is
8136 nonnegative, as it should be; check that it's nonnegative, just in
8137 case. This bug is triggered when events are more than 2**31 ms
8138 apart (about 25 days). (Bug#8664)
8140 * xselect.c (last_event_timestamp): Remove duplicate decl.
8141 (x_own_selection): Remove needless cast to unsigned long.
8143 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8144 that always fit in int. Use a sentinel instead of a counter, to
8145 avoid a temp and to allay GCC's concerns about possible int overflow.
8146 * frame.h (struct frame): Use int for menu_bar_items_used
8147 instead of EMACS_INT, since it always fits in int.
8149 * menu.c (grow_menu_items): Check for int overflow.
8151 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8153 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8154 Before, the code was not consistent. These values cannot exceed
8155 2**31 - 1 so there's no need to make them unsigned.
8156 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8157 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8158 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8160 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8162 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8163 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8164 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8165 presumably because the widths might not match.
8167 * window.c (size_window): Avoid needless test at loop start.
8169 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8171 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8173 2011-05-12 Drew Adams <drew.adams@oracle.com>
8175 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8177 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8179 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8180 `width' to `bar_area_x' and `bar_area_width', respectively.
8181 (x_scroll_run): Take account of fringe background extension.
8183 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8184 Rename local vars `left' and `width' to `bar_area_x' and
8185 `bar_area_width', respectively.
8186 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8187 background extension.
8189 2011-05-10 Jim Meyering <meyering@redhat.com>
8191 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8193 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8195 * image.c (Finit_image_library): Return t for built-in image types,
8196 like pbm and xbm. (Bug#8640)
8198 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8200 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8202 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8204 * w32console.c (Fset_screen_color): Doc fix.
8205 (Fget_screen_color): New function.
8206 (syms_of_ntterm): Defsubr it.
8208 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8209 unlink the temporary file if Fcall_process didn't create it in the
8211 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8212 child process will be redirected to a file specified with `:file'.
8213 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8214 cue to call_process_cleanup not to close that handle.
8216 2011-05-07 Ben Key <bkey76@gmail.com>
8218 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8219 one of two shell specific rules, either bootstrap-temacs-CMD or
8220 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8221 to the previous implementation of the bootstrap-temacs rule.
8222 The bootstrap-temacs-CMD rule is similar to the previous
8223 implementation of the bootstrap-temacs rule except that it
8224 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8227 These changes, along with some changes to nt/configure.bat,
8228 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8229 earlier fix to add support for --cflags and --ldflags options
8230 that include quotes so that it works whether make uses cmd or
8233 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8235 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8236 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8238 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8239 a string. Handle both cases.
8240 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8241 (Fdbus_register_method): Use Qinvalid_function.
8243 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8245 * makefile.w32-in: Update dependencies.
8246 (LISP_H): Add inttypes.h and stdin.h.
8247 (PROCESS_H): Add unistd.h.
8249 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8251 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8252 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8254 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8256 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8258 * term.c (vfatal): Remove stray call to va_end.
8259 It's not needed and the C Standard doesn't allow it here anyway.
8261 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8262 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8264 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8267 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8269 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8271 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8273 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8275 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8277 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8278 * charset.c (Fdefine_charset_internal): Don't initialize
8279 charset.code_space[15]. The value was garbage, on hosts with
8280 32-bit int (Bug#8600).
8282 * lread.c (read_integer): Be more consistent with string-to-number.
8283 Use string_to_number to do the actual conversion; this avoids
8284 rounding errors and fixes some other screwups. Without this fix,
8285 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8286 (digit_to_number): Move earlier, for benefit of read_integer.
8287 Return -1 if the digit is out of range for the base, -2 if it is
8288 not a digit in any supported base. (Bug#8602)
8290 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8292 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8293 to match comment at start of function. This also removes a
8294 GCC warning about overflow in a 32+64-bit port.
8296 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8298 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8299 Reported by Stefan Monnier in
8300 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8301 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8302 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8304 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8305 (EMACS_UINTPTR): Likewise, with uintptr_t.
8307 * lisp.h: Prefer 64-bit EMACS_INT if available.
8308 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8309 on 32-bit hosts that have 64-bit int, so that they can access
8311 However, temporarily disable this change unless the temporary
8312 symbol WIDE_EMACS_INT is defined.
8314 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8316 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8317 This removes an assumption that EMACS_INT and long are the same
8318 width as pointers. The assumption is true for Emacs porting targets
8319 now, but we want to make other targets possible.
8320 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8321 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8322 In the rest of the code, change types of integers that hold casted
8323 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8324 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8325 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8326 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8327 No need to cast type when ORing.
8328 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8329 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8330 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8331 assume EMACS_INT is the same width as char *.
8332 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8333 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8334 Remove no-longer-needed casts.
8335 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8336 (xg_tool_bar_help_callback, xg_make_tool_item):
8337 Use EMACS_INTPTR to hold an integer
8338 that will be cast to void *; this can avoid a GCC warning
8339 if EMACS_INT is not the same width as void *.
8340 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8341 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8342 (current_message_1, set_message_1):
8343 Use a local to convert to proper width without a cast.
8344 * xmenu.c (dialog_selection_callback): Likewise.
8346 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8347 Also, don't assume VALBITS / RAND_BITS is less than 5,
8348 and don't rely on undefined behavior when shifting a 1 left into
8350 * lisp.h (get_random): Change signature to match.
8352 * lread.c (hash_string): Use size_t, not int, for hash computation.
8353 Normally we prefer signed values; but hashing is special, because
8354 it's better to use unsigned division on hash table sizes so that
8355 the remainder is nonnegative. Also, size_t is the natural width
8356 for hashing into memory. The previous code used 'int', which doesn't
8357 retain enough info to hash well into very large tables.
8358 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8360 * dbusbind.c: Don't possibly lose pointer info when converting.
8361 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8362 Use XPNTR rather than XHASH, so that the high-order bits of
8363 the pointer aren't lost when converting through void *.
8365 * eval.c (Fautoload): Don't double-shift a pointer.
8367 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8369 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8371 * gnutls.c (DEF_GNUTLS_FN):
8372 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8374 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8376 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8379 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8381 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8382 New version that can reserve upto 2GB of heap space.
8384 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8386 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8388 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8390 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8391 `gnutls_certificate_set_x509_key_file'.
8393 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8395 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8396 Update dependencies.
8398 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8400 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8401 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8402 Remove unused parameter `fildes'.
8403 * process.c (read_process_output, send_process): Don't pass it.
8405 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8407 Fix previous change: the library cache is defined in w32.c.
8408 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8409 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8411 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8413 Implement dynamic loading of GnuTLS on Windows.
8415 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8416 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8417 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8420 * gnutls.c (Qgnutls_dll): Define.
8421 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8422 (gnutls_*): Declare function pointers.
8423 (init_gnutls_functions): New function to initialize function pointers.
8424 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8425 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8426 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8427 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8428 (emacs_gnutls_write, emacs_gnutls_read)
8429 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8430 (Fgnutls_available_p): New function.
8431 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8432 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8433 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8435 * image.c: Include w32.h.
8436 (Vimage_type_cache): Delete.
8437 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8438 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8439 (w32_delayed_load): Move to w32.c.
8441 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8443 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8444 (w32_delayed_load): Move from image.c. When loading a library, record
8445 its filename in the :loaded-from property of the library id.
8446 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8447 Initialize and staticpro them.
8448 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8450 * process.c: Include lisp.h before w32.h, not after.
8451 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8452 instead of gnutls_record_check_pending.
8454 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8456 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8458 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8459 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8462 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8464 * xterm.c (x_set_frame_alpha): Do not set property on anything
8465 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8467 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8469 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8471 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8473 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8474 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8475 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8476 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8477 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8478 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8479 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8480 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8481 (Qgnutls_bootprop_callbacks_verify): Make static.
8483 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8485 * callproc.c: Indentation fixup.
8487 * sysdep.c (wait_for_termination_1): Make static.
8488 (wait_for_termination, interruptible_wait_for_termination):
8489 Move after wait_for_termination_1.
8491 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8493 * sysdep.c (interruptible_wait_for_termination): New function
8494 which is like wait_for_termination, but allows keyboard
8497 * callproc.c (Fcall_process): Add (:file "file") as an option for
8499 (Fcall_process_region): Ditto.
8501 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8503 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8504 rather than `XVECTOR (FOO)->size'.
8506 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8507 inttypes.h, as a gnulib replacement is used if it not available in
8510 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8512 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8513 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8514 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8516 * coding.c (coding_alloc_by_realloc): Error out if destination
8517 will grow beyond MOST_POSITIVE_FIXNUM.
8518 (decode_coding_emacs_mule): Abort if there isn't enough place in
8519 charbuf for the composition carryover bytes. Reserve an extra
8520 space for up to 2 characters produced in a loop.
8521 (decode_coding_iso_2022): Abort if there isn't enough place in
8522 charbuf for the composition carryover bytes.
8524 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8526 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8527 aborting when %lld or %lll format is passed.
8528 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8529 %llo or %llx format is passed. (Bug#8545)
8531 * window.c (window_scroll_line_based): Use a marker instead of
8532 simple variables to record original value of point. (Bug#7952)
8534 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8535 produced by %s or %c overflows available buffer space. (Bug#8545)
8537 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8539 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8540 (SIZE_MAX): Move defn after all includes, as they might #define it.
8542 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8544 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8546 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8548 * keyboard.c (Qdelayed_warnings_hook): Define.
8549 (command_loop_1): Run `delayed-warnings-hook'
8550 if Vdelayed_warnings_list is non-nil.
8551 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8552 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8554 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8556 * doprnt.c (doprnt): Don't return value smaller than the buffer
8557 size if the message was truncated. (Bug#8545).
8559 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8561 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8562 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8564 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8566 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8568 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8570 * makefile.w32-in: Update dependencies.
8572 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8574 Improve `doprnt' and its usage. (Bug#8545)
8575 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8576 `format_end'. Remove support for %l as a conversion specifier.
8577 Don't use xrealloc. Improve diagnostics when the %l size modifier
8578 is used. Update the commentary.
8580 * eval.c (verror): Simplify calculation of size_t.
8582 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8585 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8587 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8590 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8592 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8593 This makes this file independent of the recent pseudovector change.
8595 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8597 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8599 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8600 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8601 Remove unused local.
8602 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8604 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8605 GCC 4.6.0 optimizes based on type-based alias analysis.
8606 For example, if b is of type struct buffer * and v of type struct
8607 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8608 != &v->size, and therefore "v->size = 1; b->size = 2; return
8609 v->size;" must therefore return 1. This assumption is incorrect
8610 for Emacs, since it type-puns struct Lisp_Vector * with many other
8611 types. To fix this problem, this patch adds a new type struct
8612 vectorlike_header that documents the constraints on layout of vectors
8613 and pseudovectors, and helps optimizing compilers not get fooled
8614 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8615 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8616 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8618 (XSETPVECTYPE): Rewrite in terms of new macro.
8619 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8620 This is a bit clearer, and further avoids the possibility of
8621 undesirable aliasing.
8622 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8623 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8624 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8625 since Lisp_Subr is a special case (no "next" field).
8626 (ASIZE): Now uses header.size rather than size.
8627 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8628 to avoid the hassle of writing XVECTOR (foo)->header.size.
8629 (struct vectorlike_header): New type.
8630 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8631 object, to help avoid aliasing.
8632 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8633 (SUBRP): Likewise, since Lisp_Subr is a special case.
8634 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8635 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8636 (struct Lisp_Hash_Table): Combine first two members into a single
8637 struct vectorlike_header member. All uses of "size" and "next" members
8638 changed to be "header.size" and "header.next".
8639 * buffer.h (struct buffer): Likewise.
8640 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8641 * frame.h (struct frame): Likewise.
8642 * process.h (struct Lisp_Process): Likewise.
8643 * termhooks.h (struct terminal): Likewise.
8644 * window.c (struct save_window_data, struct saved_window): Likewise.
8645 * window.h (struct window): Likewise.
8646 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8647 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8648 * buffer.c (init_buffer_once): Likewise.
8649 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8651 * process.c (Fformat_network_address): Use local var for size,
8654 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8656 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8657 * data.c (atof): Remove decl; no longer used or needed.
8658 (digit_to_number): Move to lread.c.
8659 (Fstring_to_number): Use new string_to_number function, to be
8660 consistent with how the Lisp reader treats infinities and NaNs.
8661 Do not assume that floating-point numbers represent EMACS_INT
8662 without losing information; this is not true on most 64-bit hosts.
8663 Avoid double-rounding errors, by insisting on integers when
8664 parsing non-base-10 numbers, as the documentation specifies.
8665 * lisp.h (string_to_number): New decl, replacing ...
8666 (isfloat_string): Remove.
8667 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8668 (read1): Do not accept +. and -. as integers; this
8669 appears to have been a coding error. Similarly, do not accept
8670 strings like +-1e0 as floating point numbers. Do not report
8671 overflow for integer overflows unless the base is not 10 which
8672 means we have no simple and reliable way to continue.
8673 Break out the floating-point parsing into a new
8674 function string_to_number, so that Fstring_to_number parses
8675 floating point numbers consistently with the Lisp reader.
8676 (digit_to_number): Move here from data.c. Make it static inline.
8677 (E_CHAR, EXP_INT): Remove, replacing with ...
8678 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8679 (string_to_number): New function, replacing isfloat_string.
8680 This function checks for valid syntax and produces the resulting
8681 Lisp float number too. Rework it so that string-to-number
8682 no longer mishandles examples like "1.0e+". Use strtoumax,
8683 so that overflow for non-base-10 numbers is reported only when
8684 there's no portable and simple way to convert to floating point.
8686 * textprop.c (set_text_properties_1): Rewrite for clarity,
8687 and to avoid GCC warning about integer overflow.
8689 * intervals.h (struct interval): Use EMACS_INT for members
8690 where EMACS_UINT might cause problems. See
8691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8692 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8693 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8695 (offset_intervals): Tell GCC not to worry about length overflow
8696 when negating a negative length.
8698 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8699 (overrun_check_free): Likewise.
8701 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8702 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8705 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8706 (gnutls_make_error): Rename local to avoid shadowing.
8707 (gnutls_emacs_global_deinit): ifdef out; not used.
8708 (Fgnutls_boot): Use const for pointer to readonly storage.
8709 Comment out unused local. Fix pointer signedness problems.
8711 * lread.c (openp): Don't stuff size_t into an 'int'.
8712 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8713 about possible signed overflow.
8715 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8716 (GDK_KEY_g): Don't define if already defined.
8717 (xg_prepare_tooltip): Avoid pointer signedness problem.
8718 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8720 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8721 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8723 * xfns.c (Fx_window_property): Simplify a bit,
8724 to make a bit faster and to avoid GCC 4.6.0 warning.
8725 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8727 * fns.c (internal_equal): Don't assume size_t fits in int.
8729 * alloc.c (compact_small_strings): Tighten assertion a little.
8731 Replace pEd with more-general pI, and fix some printf arg casts.
8732 * lisp.h (pI): New macro, generalizing old pEd macro to other
8733 conversion specifiers. For example, use "...%"pI"d..." rather
8734 than "...%"pEd"...".
8735 (pEd): Remove. All uses replaced with similar uses of pI.
8736 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8737 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8738 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8739 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8740 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8741 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8742 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8744 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8745 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8746 * print.c (safe_debug_print, print_object): Likewise.
8747 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8749 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8750 avoiding the 0 flag, which is not portable.
8751 * process.c (Fmake_network_process): Use pI to avoid cast.
8752 * region-cache.c (pp_cache): Likewise.
8753 * xdisp.c (decode_mode_spec): Likewise.
8754 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8755 behavior on 64-bit hosts with printf arg.
8756 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8757 (x_stop_queuing_selection_requests): Likewise.
8758 (x_get_window_property): Don't truncate byte count to an 'int'
8761 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8762 here, since it parses constructs like leading '-' and spaces,
8763 which are not wanted; and it overflows with large numbers.
8764 Instead, simply match F[0-9]+, which is what is wanted anyway.
8766 * alloc.c: Remove unportable assumptions about struct layout.
8767 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8768 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8769 (allocate_vectorlike, make_pure_vector): Use the new macros,
8770 plus offsetof, to remove unportable assumptions about struct layout.
8771 These assumptions hold on all porting targets that I know of, but
8772 they are not guaranteed, they're easy to remove, and removing them
8773 makes further changes easier.
8775 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8776 This doesn't fix a bug but makes the code clearer.
8777 (string_overrun_cookie): Now const. Use initializers that
8778 don't formally overflow signed char, to avoid warnings.
8779 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8780 can cause Emacs to crash when string overrun checking is enabled.
8781 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8782 multiple of sizeof (EMACS_INT); it need not be, if
8783 alignof(EMACS_INT) < sizeof (EMACS_INT).
8784 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8786 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8788 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8790 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8792 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8793 supposed to be handshaking. (Bug#8556)
8794 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8796 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8798 * lisp.h (Qdebug): List symbol.
8799 * eval.c (Qdebug): Restore global linkage.
8800 * keyboard.c (debug-on-event): New variable.
8801 (handle_user_signal): Break into debugger when debug-on-event
8802 matches the current signal symbol.
8804 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8806 * alloc.c (check_sblock, check_string_bytes)
8807 (check_string_free_list): Convert to standard C.
8809 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8811 * w32.c (emacs_gnutls_push): Fix typo.
8813 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8815 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8816 "cast to pointer from integer of different size".
8818 Improve doprnt and its use in verror. (Bug#8545)
8819 * doprnt.c (doprnt): Document the set of format control sequences
8820 supported by the function. Use SAFE_ALLOCA instead of always
8823 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8824 is one byte too soon. Don't use xrealloc; instead xfree and
8827 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8829 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8832 * gnutls.c: Renamed global_initialized to
8833 gnutls_global_initialized. Added internals for the
8834 :verify-hostname-error, :verify-error, and :verify-flags
8835 parameters of `gnutls-boot' and documented those parameters in the
8836 docstring. Start callback support.
8837 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8838 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8839 on error. Return error code.
8840 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8841 (emacs_gnutls_read): Likewise.
8842 (Fgnutls_boot): Return handshake error code.
8843 (emacs_gnutls_handle_error): New function.
8844 (wsaerror_to_errno): Likewise.
8846 * w32.h (emacs_gnutls_pull): Add prototype.
8847 (emacs_gnutls_push): Likewise.
8849 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8850 (emacs_gnutls_push): Likewise.
8852 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8854 * process.c (wait_reading_process_output): Check if GnuTLS
8855 buffered some data internally if no FDs are set for TLS
8858 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8859 (LIBS): Link to USER_LIBS.
8860 ($(BLD)/gnutls.$(0)): New target.
8862 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8864 * xdisp.c (handle_single_display_spec): Rename the
8865 display_replaced_before_p argument into display_replaced_p, to
8866 make it consistent with the commentary. Fix typos in the
8869 * textprop.c (syms_of_textprop): Remove dead code.
8870 (copy_text_properties): Delete obsolete commentary about an
8871 interface that was deleted long ago. Fix typos in the description
8874 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8875 to changes in oldXMenu/XMenu.h from 2011-04-16.
8876 <menu_help_message, prev_menu_help_message>: Constify.
8877 (IT_menu_make_room): menu->help_text is now `const char **';
8880 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8881 to changes in oldXMenu/XMenu.h from 2011-04-16.
8882 (struct XMenu): Declare `help_text' `const char **'.
8884 * xfaces.c <Qunspecified>: Make extern again.
8886 * syntax.c: Include sys/types.h before including regex.h, as
8889 * doc.c (get_doc_string): Improve the format passed to `error'.
8891 * doprnt.c (doprnt): Improve commentary.
8893 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8895 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8898 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8899 changes in globals.h immediately force recompilation.
8900 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8901 $(CURDIR)/s/ms-w32.h.
8902 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8904 * character.c (Fchar_direction): Function deleted.
8905 (syms_of_character): Don't defsubr it.
8906 <char-direction-table>: Deleted.
8908 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8910 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8911 * doprnt.c: Include limits.h.
8912 (SIZE_MAX): New macro.
8913 (doprnt): Return a size_t value. 2nd arg is now size_t.
8914 Many local variables are now size_t instead of int or unsigned.
8915 Improve overflow protection. Support `l' modifier for integer
8916 conversions. Support %l conversion. Don't assume an EMACS_INT
8917 argument for integer conversions and for %c.
8919 * lisp.h (doprnt): Restore prototype.
8921 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8924 * Makefile.in (base_obj): Add back doprnt.o.
8926 * deps.mk (doprnt.o): Add back prerequisites.
8927 (callint.o): Depend on character.h.
8929 * eval.c (internal_lisp_condition_case): Include the handler
8930 representation in the error message.
8931 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8932 when breaking from the loop.
8934 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8936 * callint.c (Fcall_interactively): When displaying error message
8937 about invalid control letter, pass the character's codepoint, not
8938 a pointer to its multibyte form. Improve display of the character
8939 in octal and display also its hex code.
8941 * character.c (char_string): Use %x to display the (unsigned)
8942 codepoint of an invalid character, to avoid displaying a bogus
8945 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8946 `error', not SYMBOL_NAME itself.
8948 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8949 character arguments to `error'.
8951 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8952 to `error' in error message about FINAL_CHAR argument. Make sure
8953 FINAL_CHAR is a character, and use %c when it is passed as
8954 argument to `error'.
8956 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8958 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8960 * w32.c: Include <time.h>.
8961 (sys_localtime): New function.
8963 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8965 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8967 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8969 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8971 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8974 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8976 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8977 gl_state.e_property when gl_state.object is Qt.
8979 * insdel.c (make_gap_larger): Remove limitation of buffer size
8982 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8984 * xdisp.c (lookup_glyphless_char_display)
8985 (produce_glyphless_glyph): Handle cons cell entry in
8986 glyphless-char-display.
8987 (Vglyphless_char_display): Document it.
8989 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8990 glyphless-char-display.
8992 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8994 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8996 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8998 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8999 definition for no-X builds.
9001 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9003 Static checks with GCC 4.6.0 and non-default toolkits.
9005 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9007 * process.c (keyboard_bit_set): Define only if SIGIO.
9008 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9009 (send_process): Repair possible setjmp clobbering.
9011 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9013 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9015 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9017 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9018 Define only if needed.
9020 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9021 by pacifying GCC about it. Maybe it's time to retire it?
9022 * xfaces.c (USG, __TIMEVAL__): Likewise.
9024 * dispextern.h (struct redisplay_interface): Rename param
9026 * termhooks.h (struct terminal): Likewise.
9027 * xterm.c (xembed_send_message): Likewise.
9029 * insdel.c (make_gap_smaller): Define only if
9030 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9032 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9035 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9036 so that we aren't warned about unused symbols.
9038 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9040 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9042 * xfns.c (x_real_positions): Mark locals as initialized.
9044 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9046 * xterm.c: Fix problems found by static analysis with other toolkits.
9047 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9048 (x_dispatch_event): Declare static if USE_GTK, and
9049 define if USE_GTK || USE_X_TOOLKIT.
9050 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9051 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9052 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9053 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9055 * xmenu.c (menu_help_callback): Pointer type fixes.
9056 Use const pointers when pointing at readonly data. Avoid pointer
9058 (FALSE): Remove unused macro.
9059 (update_frame_menubar): Remove unused decl.
9061 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9063 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9064 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9065 (single_menu_item): Rename local to avoid shadowing.
9067 * keyboard.c (make_lispy_event): Remove unused local var.
9069 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9070 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9072 * bitmaps: Change bitmaps from unsigned char back to the X11
9073 compatible char. Avoid the old compiler warnings about
9074 out-of-range initializers by using, for example, '\xab' rather
9077 * xgselect.c (xgselect_initialize): Check vs interface
9078 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9080 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9082 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9083 to read-only memory.
9085 * fns.c (vector): Remove; this old hack is no longer needed.
9087 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9089 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9091 * xrdb.c (x_load_resources): Omit unused local.
9093 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9094 (x_window): Rename locals to avoid shadowing.
9095 (USG): Use the kludged USG macro, to pacify gcc.
9097 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9098 (x_term_init): Remove local to avoid shadowing.
9100 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9102 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9103 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9105 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9107 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9109 Fix regex.c, syntax.c and friends for buffers > 2GB.
9110 * syntax.h (struct gl_state_s): Declare character position members
9113 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9115 * textprop.c (verify_interval_modification, interval_of):
9116 Declare arguments EMACS_INT.
9118 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9121 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9123 * indent.c (Fvertical_motion): Local variable it_start is now
9126 * regex.c (re_match, re_match_2, re_match_2_internal)
9127 (bcmp_translate, regcomp, regexec, print_double_string)
9128 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9129 (re_compile_pattern, re_exec): Declare arguments and local
9130 variables `size_t' and `ssize_t' and return values `regoff_t', as
9132 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9133 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9134 <compile_stack_type>: `size' and `avail' are now `size_t'.
9136 * regex.h <regoff_t>: Use ssize_t, not int.
9137 (re_search, re_search_2, re_match, re_match_2): Arguments that
9138 specify buffer/string position and length are now ssize_t and
9139 size_t. Return type is regoff_t.
9141 2011-04-16 Ben Key <bkey76@gmail.com>
9143 * nsfont.m: Fixed bugs in ns_get_family and
9144 ns_descriptor_to_entity that were caused by using free to
9145 deallocate memory blocks that were allocated by xmalloc (via
9146 xstrdup). This caused Emacs to crash when compiled with
9147 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9148 --enable-checking=xmallocoverrun). xfree is now used to
9149 deallocate these memory blocks.
9151 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9153 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9155 emacs_write: Accept and return EMACS_INT for sizes.
9156 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9158 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9159 Accept and return EMACS_INT.
9160 (emacs_gnutls_write): Return the number of bytes written on
9162 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9163 (emacs_read, emacs_write): Remove check for negative size, as the
9164 Emacs source code has been audited now.
9165 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9166 (emacs_read, emacs_write): Use it.
9167 * process.c (send_process): Adjust to the new signatures of
9168 emacs_write and emacs_gnutls_write. Do not attempt to store
9169 a byte offset into an 'int'; it might overflow.
9170 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9172 * sound.c: Don't assume sizes fit in 'int'.
9173 (struct sound_device.period_size, alsa_period_size):
9174 Return EMACS_INT, not int.
9175 (struct sound_device.write, vox_write, alsa_write):
9176 Accept EMACS_INT, not int.
9177 (wav_play, au_play): Use EMACS_INT to store sizes and to
9178 record read return values.
9180 2011-04-15 Ben Key <bkey76@gmail.com>
9182 * keyboard.c (Qundefined): Don't declare static since it is used
9184 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9185 static since they are used in nsfont.m.
9187 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9189 * process.c (Qprocessp): Don't declare static.
9190 * lisp.h (Qprocessp): Declare again.
9192 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9194 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9196 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9198 Improve C-level modularity by making more things 'static'.
9200 Don't publish debugger-only interfaces to other modules.
9201 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9202 (verify_bytepos, count_markers): Move decls to the only modules
9204 * region-cache.h (pp_cache): Likewise.
9205 * window.h (check_all_windows): Likewise.
9206 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9208 * sysdep.c (croak): Now static, if
9209 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9210 * syssignal.h (croak): Declare only if not static.
9212 * alloc.c (refill_memory_reserve): Now static if
9213 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9214 * lisp.h (refill_memory_reserve): Declare only if not static.
9216 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9217 Define only if USE_LUCID.
9219 * xrdb.c (x_customization_string, x_rm_string): Now static.
9221 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9222 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9224 * xdisp.c (draw_row_with_mouse_face): Now static.
9225 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9227 * window.h (check_all_windows): Mark externally visible.
9229 * window.c (window_deletion_count): Now static.
9231 * undo.c: Make symbols static if they're not exported.
9232 (last_undo_buffer, last_boundary_position, pending_boundary):
9235 * textprop.c (interval_insert_behind_hooks): Now static.
9236 (interval_insert_in_front_hooks): Likewise.
9238 * term.c: Make symbols static if they're not exported.
9239 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9240 (max_frame_lines, tty_set_terminal_modes):
9241 (tty_reset_terminal_modes, tty_turn_off_highlight):
9242 (get_tty_terminal): Now static.
9243 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9244 * termhooks.h (term_mouse_moveto): Do not declare if
9246 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9247 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9249 * sysdep.c: Make symbols static if they're not exported.
9250 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9252 (sigprocmask_set, full_mask): Remove; unused.
9253 (wait_debugging): Mark as visible.
9254 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9255 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9257 * syntax.c (syntax_temp): Define only if !__GNUC__.
9259 * sound.c (current_sound_device, current_sound): Now static.
9261 * search.c (searchbufs, searchbuf_head): Now static.
9263 * scroll.c (scroll_cost): Remove; unused.
9264 * dispextern.h (scroll_cost): Remove decl.
9266 * region-cache.h (pp_cache): Mark as externally visible.
9268 * process.c: Make symbols static if they're not exported.
9269 (process_tick, update_tick, create_process, chan_process):
9270 (Vprocess_alist, proc_buffered_char, datagram_access):
9271 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9272 (deactivate_process): Mark defn as static, as well as decl.
9273 * lisp.h (create_process): Remove decl.
9274 * process.h (chan_process, Vprocess_alist): Remove decls.
9276 * print.c: Make symbols static if they're not exported.
9277 (print_depth, new_backquote_output, being_printed, print_buffer):
9278 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9279 (print_interval, print_number_index, initial_stderr_stream):
9281 * lisp.h (Fprinc): Remove decl.
9282 (debug_output_compilation_hack): Mark as externally visible.
9284 * sysdep.c (croak): Move decl from here to syssignal.h.
9285 * syssignal.h (croak): Put it here, so the API can be checked when
9286 'croak' is called from dissociate_if_controlling_tty.
9288 * minibuf.c: Make symbols static if they're not exported.
9289 (minibuf_save_list, choose_minibuf_frame): Now static.
9290 * lisp.h (choose_minibuf_frame): Remove decl.
9292 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9294 * lread.c: Make symbols static if they're not exported.
9295 (read_objects, initial_obarray, oblookup_last_bucket_number):
9297 (make_symbol): Remove; unused.
9298 * lisp.h (initial_obarray, make_symbol): Remove decls.
9300 * keyboard.c: Make symbols static if they're not exported.
9301 (single_kboard, recent_keys_index, total_keys, recent_keys):
9302 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9303 (this_single_command_key_start, echoing, last_auto_save):
9304 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9305 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9306 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9307 (Vlispy_mouse_stem, double_click_count):
9309 (force_auto_save_soon): Define only if SIGDANGER.
9310 (ignore_mouse_drag_p): Now static if
9311 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9312 (print_help): Remove; unused.
9313 (stop_character, last_timer_event): Mark as externally visible.
9314 * keyboard.h (ignore_mouse_drag_p): Declare only if
9315 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9316 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9317 * lisp.h (echoing): Remove decl.
9318 (force_auto_save_soon): Declare only if SIGDANGER.
9319 * xdisp.c (redisplay_window): Simplify code, to make it more
9320 obvious that ignore_mouse_drag_p is not accessed if !defined
9321 USE_GTK && !defined HAVE_NS.
9323 * intervals.c: Make symbols static if they're not exported.
9324 (merge_properties_sticky, merge_interval_right, delete_interval):
9326 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9328 * insdel.c: Make symbols static if they're not exported.
9329 However, leave prepare_to_modify_buffer alone. It's never
9330 called from outside this function, but that appears to be a bug.
9331 (combine_after_change_list, combine_after_change_buffer):
9332 (adjust_after_replace, signal_before_change): Now static.
9333 (adjust_after_replace_noundo): Remove; unused.
9334 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9335 (signal_before_change): Remove decls.
9337 * indent.c (val_compute_motion, val_vmotion): Now static.
9339 * image.c: Make symbols static if they're not exported.
9340 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9342 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9343 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9345 * fringe.c (standard_bitmaps): Now static.
9346 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9348 * frame.c: Make symbols static if they're not exported.
9349 (x_report_frame_params, make_terminal_frame): Now static.
9350 (get_frame_param): Now static, unless HAVE_NS.
9351 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9352 (x_get_resource_string): Remove; not used.
9353 * frame.h (make_terminal_frame, x_report_frame_params):
9354 (x_get_resource_string); Remove decls.
9355 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9356 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9358 * font.c, fontset.c: Make symbols static if they're not exported.
9359 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9360 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9361 * font.c (font_close_object): Now static.
9362 * font.h (font_close_object): Remove.
9363 * fontset.c (FONTSET_OBJLIST): Remove.
9364 (free_realized_fontset) #if-0 the body, which does nothing.
9365 (face_suitable_for_char_p): #if-0, as it's never called.
9366 * fontset.h (face_suitable_for_char_p): Remove decl.
9367 * xfaces.c (face_at_string_position):
9368 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9369 since 0 is always ASCII.
9371 * fns.c (weak_hash_tables): Now static.
9373 * fileio.c: Make symbols static if they're not exported.
9374 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9375 (Vwrite_region_annotation_buffers): Now static.
9377 * eval.c: Make symbols static if they're not exported.
9378 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9379 * lisp.h (backtrace_list): Remove decl.
9381 * emacs.c: Make symbols static if they're not exported.
9382 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9383 (fatal_error_code, fatal_error_signal_hook, standard_args):
9385 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9386 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9387 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9388 * lisp.h (fatal_error_signal_hook): Remove decl.
9389 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9391 * editfns.c: Move a (normally-unused) function to its only use.
9392 * editfns.c, lisp.h (get_operating_system_release): Remove.
9393 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9394 worth the hassle of breaking this out.
9396 * xterm.c: Make symbols static if they're not exported.
9397 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9398 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9399 (x_destroy_window, x_delete_display):
9401 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9402 (x_mouse_leave): Remove; unused.
9403 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9404 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9405 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9407 (x_mouse_leave): Declare only if WINDOWSNT.
9408 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9409 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9412 * ftxfont.c: Make symbols static if they're not exported.
9413 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9415 * font.h (ftxfont_driver): Likewise.
9417 * xfns.c: Make symbols static if they're not exported.
9418 (x_last_font_name, x_display_info_for_name):
9419 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9420 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9421 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9422 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9423 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9424 (last_show_tip_args): Now static.
9425 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9426 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9427 (x_screen_planes): Remove; unused.
9428 * dispextern.h (x_screen_planes): Remove decl.
9430 * dispnew.c: Make symbols static if they're not exported.
9431 * dispextern.h (redraw_garbaged_frames, scrolling):
9432 (increment_row_positions): Remove.
9433 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9434 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9436 (redraw_garbaged_frames): Remove; unused.
9438 * xfaces.c: Make symbols static if they're not exported.
9439 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9441 * xterm.h (defined_color): Remove decls.
9442 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9443 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9444 (menu_face_changed_default, defined_color, free_realized_face):
9445 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9446 (ascii_face_of_lisp_face): Remove; unused.
9448 * xdisp.c: Make symbols static if they're not exported.
9449 * dispextern.h (scratch_glyph_row, window_box_edges):
9450 (glyph_to_pixel_coords, set_cursor_from_row):
9451 (get_next_display_element, set_iterator_to_next):
9452 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9453 (show_mouse_face): Remove decls
9454 * frame.h (message_buf_print): Likewise.
9455 * lisp.h (pop_message, set_message, check_point_in_composition):
9457 * xterm.h (set_vertical_scroll_bar): Likewise.
9458 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9459 (message_buf_print, scratch_glyph_row, displayed_buffer):
9460 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9461 (get_next_display_element, show_mouse_face, window_box_edges):
9462 (frame_to_window_pixel_xy, check_point_in_composition):
9463 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9464 (glyph_to_pixel_coords): Remove; unused.
9466 * dired.c (file_name_completion): Now static.
9468 * dbusbind.c (xd_in_read_queued_messages): Now static.
9470 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9471 * data.c (circular_list_error): Remove.
9473 * commands.h (last_point_position, last_point_position_buffer):
9474 (last_point_position_window): Remove decls.
9475 * keyboard.c: Make these variables static.
9477 * coding.h (coding, code_convert_region, encode_coding_gap):
9479 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9480 (iso_code_class, detect_coding, code_convert_region): Now static.
9481 (encode_coding_gap): Remove; unused.
9483 * chartab.c (chartab_chars, chartab_bits): Now static.
9485 * charset.h (charset_iso_8859_1): Remove decl.
9486 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9489 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9490 * ccl.c (Vccl_program_table): Now static.
9491 (check_ccl_update): Remove; unused.
9493 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9494 * category.h: ... from here.
9495 * category.c (check_category_table, set_category_set): Now static.
9497 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9498 * lisp.h: Remove these decls.
9500 * buffer.c (buffer_count): Remove unused var.
9502 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9503 so that it's not optimized away.
9504 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9505 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9506 exported only to the debugger.
9508 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9509 * atimer.h (run_all_atimers): Remove; not exported.
9511 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9512 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9513 was inaccessible from Lisp.
9514 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9515 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9517 alloc.c: Import and export fewer symbols, and remove unused items.
9518 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9520 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9521 it's not optimized away by whole-program optimization.
9522 (message_enable_multibyte, free_misc): Remove.
9523 (catchlist, handlerlist, mark_backtrace):
9524 Declare only if BYTE_MARK_STACK.
9525 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9526 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9527 (message_enable_multibyte): Remove decl.
9528 (free_misc, interval_free_list, float_block, float_block_index):
9529 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9530 (cons_free_list, last_marked_index):
9532 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9533 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9534 (mark_backtrace): Define only if BYTE_MARK_STACK.
9535 * xdisp.c (message_enable_multibyte): Now static.
9537 Declare Lisp_Object Q* variables to be 'static' if not exported.
9538 This makes it easier for human readers (and static analyzers)
9539 to see whether these variables are used from other modules.
9540 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9541 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9542 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9543 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9544 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9545 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9546 * xmenu.c, xselect.c:
9547 Declare Q* vars static if they are not used in other modules.
9548 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9549 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9550 Remove decls of unexported vars.
9551 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9553 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9555 Make Emacs functions such as Fatom 'static' by default.
9556 This makes it easier for human readers (and static analyzers)
9557 to see whether these functions can be called from other modules.
9558 DEFUN now defines a static function. To make the function external
9559 so that it can be used in other C modules, use the new macro DEFUE.
9560 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9561 (Finit_image_library):
9562 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9563 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9564 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9565 Remove decls, since these functions are now static.
9566 (Funintern, Fget_internal_run_time): New decls, since these functions
9567 were already external.
9569 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9570 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9571 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9572 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9573 * keyboard.c, keymap.c, lread.c:
9574 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9575 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9576 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9577 Mark functions with DEFUE instead of DEFUN,
9578 if they are used in other modules.
9579 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9580 decls for now-static functions.
9581 * buffer.h (Fdelete_overlay): Remove decl.
9582 * callproc.c (Fgetenv_internal): Mark as internal.
9583 * composite.c (Fremove_list_of_text_properties): Remove decl.
9584 (Fcomposition_get_gstring): New forward static decl.
9585 * composite.h (Fcomposite_get_gstring): Remove decl.
9586 * dired.c (Ffile_attributes): New forward static decl.
9587 * doc.c (Fdocumntation_property): New forward static decl.
9588 * eval.c (Ffetch_bytecode): New forward static decl.
9589 (Funintern): Remove extern decl; now in .h file where it belongs.
9590 * fileio.c (Fmake_symbolic_link): New forward static decl.
9591 * image.c (Finit_image_library): New forward static decl.
9592 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9593 * intervals.h (Fprevious_property_change):
9594 (Fremove_list_of_text_properties): Remove decls.
9595 * keyboard.c (Fthis_command_keys): Remove decl.
9596 (Fcommand_execute): New forward static decl.
9597 * keymap.c (Flookup_key): New forward static decl.
9598 (Fcopy_keymap): Now static.
9599 * keymap.h (Flookup_key): Remove decl.
9600 * process.c (Fget_process): New forward static decl.
9601 (Fprocess_datagram_address): Mark as internal.
9602 * syntax.c (Fsyntax_table_p): New forward static decl.
9603 (skip_chars): Remove duplicate decl.
9604 * textprop.c (Fprevious_property_change): New forward static decl.
9605 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9607 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9608 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9610 * editfns.c (Fformat): Remove unreachable code.
9612 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9614 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9617 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9619 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9620 when at ZV. (Bug#8487)
9622 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9624 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9626 * keyboard.c (parse_tool_bar_item): Likewise.
9627 * sound.c (sound_cleanup, alsa_close): Likewise.
9628 * termcap.c (tgetent): Likewise.
9629 * xfns.c (x_default_font_parameter): Likewise.
9630 * xsettings.c (read_and_apply_settings): Likewise.
9632 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9633 (overrun_check_free): Protoize.
9635 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9637 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9638 since callers should never pass a negative size.
9639 Change the signature to match that of plain 'read' and 'write'; see
9640 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9641 * lisp.h: Update prototypes of emacs_write and emacs_read.
9643 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9645 * xdisp.c (redisplay_window): Don't try to determine the character
9646 position of the scroll margin if the window start point w->startp
9647 is outside the buffer's accessible region. (Bug#8468)
9649 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9651 Fix write-region and its subroutines for buffers > 2GB.
9652 * fileio.c (a_write, e_write): Modify declaration of arguments and
9653 local variables to support buffers larger than 2GB.
9654 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9656 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9657 argument, local variables, and return value.
9659 * lisp.h: Update prototypes of emacs_write and emacs_read.
9661 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9663 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9665 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9667 Fix more problems found by GCC 4.6.0's static checks.
9669 * xdisp.c (vmessage): Use a better test for character truncation.
9671 * charset.c (load_charset_map): <, not <=, for optimization,
9672 and to avoid potential problems with integer overflow.
9673 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9674 * casetab.c (set_identity, shuffle): Likewise.
9675 * editfns.c (Fformat): Likewise.
9676 * syntax.c (skip_chars): Likewise.
9678 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9679 This also lets GCC 4.6.0 generate slightly better loop code.
9681 * callint.c (Fcall_interactively): <, not <=, for optimization.
9682 (Fcall_interactively): Count the number of arguments produced,
9683 not the number of arguments given. This is simpler and lets GCC
9684 4.6.0 generate slightly better code.
9686 * ftfont.c: Distingish more carefully between FcChar8 and char.
9687 The previous code passed unsigned char * to a functions like
9688 strlen and xstrcasecmp that expect char *, which does not
9689 conform to the C standard.
9690 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9691 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9692 char * when the C standard requires it.
9694 * keyboard.c (read_char): Remove unused var.
9696 * eval.c: Port to Windows vsnprintf (Bug#8435).
9698 (SIZE_MAX): Define if the headers do not.
9699 (verror): Do not give up if vsnprintf returns a negative count.
9700 Instead, grow the buffer. This ports to Windows vsnprintf, which
9701 does not conform to C99. Problem reported by Eli Zaretskii.
9702 Also, simplify the allocation scheme, by avoiding the need for
9703 calling realloc, and removing the ALLOCATED variable.
9705 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9707 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9708 But keep the doprint source code for now, as we might revamp it
9709 and use it again (Bug#8435).
9710 * lisp.h (doprnt): Remove.
9711 * Makefile.in (base_obj): Remove doprnt.o.
9712 * deps.mk (doprnt.o): Remove.
9714 error: Print 32- and 64-bit integers portably (Bug#8435).
9715 Without this change, on typical 64-bit hosts error ("...%d...", N)
9716 was used to print both 32- and 64-bit integers N, which relied on
9718 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9719 * lisp.h (error, verror): Mark as printf-like functions.
9720 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9721 Report overflow in size calculations when allocating printf buffer.
9722 Do not truncate output string at its first null byte.
9723 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9724 Truncate the output at a character boundary, since vsnprintf does not
9726 * charset.c (check_iso_charset_parameter): Convert internal
9727 character to string before calling 'error', since %c now has the
9729 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9730 overflow when computing char to be passed to 'error'. Do not
9731 pass Lisp_Object to 'error'; pass the integer instead.
9732 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9733 formatted with plain %d.
9735 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9737 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9739 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9741 * xterm.c (x_catch_errors): Remove duplicate declaration.
9743 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9745 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9747 2011-04-10 Jim Meyering <meyering@redhat.com>
9749 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9750 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9751 return ssize_t not "int", and use size_t as the buffer length.
9752 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9753 * gnutls.h: Update declarations.
9754 * process.c (read_process_output): Use ssize_t, to match.
9755 (send_process): Likewise.
9757 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9759 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9761 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9763 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9764 Use unsigned char, to match FcChar8 type definition.
9766 * xterm.c (handle_one_xevent):
9767 * xmenu.c (create_and_show_popup_menu):
9768 * xselect.c (x_decline_selection_request)
9769 (x_reply_selection_request): Avoid type-punned deref of X events.
9771 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9773 Fix some uses of `int' instead of EMACS_INT.
9774 * search.c (string_match_1, fast_string_match)
9775 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9776 (scan_buffer, find_next_newline_no_quit)
9777 (find_before_next_newline, search_command, Freplace_match)
9778 (Fmatch_data): Make some `int' variables be EMACS_INT.
9780 * xdisp.c (display_count_lines): 3rd argument and return value now
9781 EMACS_INT. All callers changed.
9782 (pint2hrstr): Last argument is now EMACS_INT.
9784 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9785 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9786 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9787 (decode_coding_utf_16, decode_coding_emacs_mule)
9788 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9789 (decode_coding_ccl, decode_coding_charset)
9790 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9791 (decode_coding_iso_2022, decode_coding_emacs_mule)
9792 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9793 <char_offset, last_offset>: Declare EMACS_INT.
9794 (encode_coding_utf_8, encode_coding_utf_16)
9795 (encode_coding_emacs_mule, encode_invocation_designation)
9796 (encode_designation_at_bol, encode_coding_iso_2022)
9797 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9798 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9800 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9801 (encode_invocation_designation): Last argument P_NCHARS is now
9803 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9804 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9806 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9809 * ccl.c (Fccl_execute_on_string): Declare some variables
9812 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9814 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9816 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9818 * process.c (Fformat_network_address): Doc fix.
9820 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9822 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9824 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9826 * keyboard.c (read_char): Call Lisp function help-form-show,
9827 instead of using internal_with_output_to_temp_buffer.
9828 (Qhelp_form_show): New var.
9829 (syms_of_keyboard): Use DEFSYM macro.
9831 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9833 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9835 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9837 * process.c (Flist_processes): Remove to Lisp.
9838 (list_processes_1): Delete.
9840 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9842 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9844 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9846 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9848 Fix more problems found by GCC 4.6.0's static checks.
9850 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9852 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9854 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9856 * xdisp.c (vmessage): Mark as a printf-like function.
9858 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9860 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9862 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9863 printf-like functions.
9864 (tiff_load): Add casts to remove these marks before passing them
9865 to system-supplied API.
9867 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9869 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9870 This avoids several warnings with gcc -Wstrict-overflow.
9871 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9872 directly, rather than having caller test rule sign. This avoids
9873 some unnecessary tests.
9874 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9875 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9876 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9878 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9879 (xfont_open): Avoid unnecessary tests.
9881 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9883 * composite.h, composite.c (composition_gstring_put_cache):
9884 Use EMACS_INT, not int, for length.
9886 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9887 breaking out part of COMPOSITION_DECODE_RULE.
9888 (COMPOSITION_DECODE_RULE): Use it.
9889 * composite.c (get_composition_id): Remove unused local vars,
9890 by using the new macro.
9892 * textprop.c (set_text_properties_1): Change while to do-while,
9893 since the condition is always true at first.
9895 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9896 (interval_deletion_adjustment): Return unsigned value.
9899 * process.c (list_processes_1, create_pty, read_process_output):
9900 (exec_sentinel): Remove vars that were set but not used.
9901 (create_pty): Remove unnecessary "volatile"s.
9902 (Fnetwork_interface_info): Avoid possibility of int overflow.
9903 (read_process_output): Do adaptive read buffering even if carryover.
9904 (read_process_output): Simplify nbytes computation if buffered.
9906 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9908 * syntax.c (scan_words): Remove var that was set but not used.
9909 (update_syntax_table): Use unsigned instead of int.
9911 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9912 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9913 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9915 * print.c (print_error_message): Avoid int overflow.
9917 * font.c (font_list_entities): Redo for clarity,
9918 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9920 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9921 (font_score): Avoid potential overflow in diff calculation.
9923 * fns.c (substring_both): Remove var that is set but not used.
9924 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9926 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9928 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9929 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9930 can always succeed if overflow has undefined behavior.
9932 * search.c (boyer_moore, wordify): Remove vars set but not used.
9933 (wordify): Omit three unnecessary tests.
9935 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9936 All callers changed. This avoids the need for an unused var.
9938 * casefiddle.c (casify_region): Remove var that is set but not used.
9940 * dired.c (file_name_completion): Remove var that is set but not used.
9942 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9944 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9945 (Finsert_file_contents): Remove unnecessary code checking fd.
9947 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9948 Check for integer overflow on size calculations.
9950 * buffer.c (Fprevious_overlay_change): Remove var that is set
9953 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9954 Remove vars that are set but not used.
9955 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9956 (timer_check_2): Mark vars as initialized.
9958 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9960 * image.c (lookup_image): Remove var that is set but not used.
9961 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9963 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9964 that are set but not used.
9966 * xfns.c (make_invisible_cursor): Don't return garbage
9967 if XCreateBitmapFromData fails (Bug#8410).
9969 * xselect.c (x_get_local_selection, x_handle_property_notify):
9970 Remove vars that are set but not used.
9972 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9973 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9975 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9976 Remove var that is set but not used.
9977 (scroll_bar_windows_size): Now size_t, not int.
9978 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9981 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9982 (map_tty_color) [!defined MSDOS]: Likewise.
9984 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9986 * coding.c: Remove vars that are set but not used.
9987 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9988 All callers changed.
9989 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9990 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9991 (decode_coding_charset): Remove vars that are set but not used.
9993 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9994 that is set but not used.
9996 * print.c (print_object): Remove var that is set but not used.
9998 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9999 The gnulib version avoids calling malloc in the usual case,
10000 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10001 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10002 * filelock.c (current_lock_owner): Likewise.
10003 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10004 * sysdep.c: Include allocator.h, careadlinkat.h.
10005 (emacs_no_realloc_allocator): New static constant.
10006 (emacs_readlink): New function.
10007 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10008 ../lib/careadlinkat.h.
10010 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10012 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10013 first non-nil return value).
10015 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10017 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10018 if not defined (Bug#8403).
10020 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10022 * xdisp.c (display_count_lines): Remove parameter `start',
10023 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10024 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10025 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10026 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10027 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10028 and thereabouts. All callers changed.
10029 (get_per_char_metric): Remove parameter `f', unused since
10030 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10032 2011-04-02 Jim Meyering <meyering@redhat.com>
10034 do not dereference NULL upon failed strdup
10035 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10036 (ns_get_family): Likewise.
10038 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10040 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10042 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10044 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10047 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10049 Add lexical binding.
10051 * window.c (Ftemp_output_buffer_show): New fun.
10052 (Fsave_window_excursion):
10053 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10055 * lread.c (lisp_file_lexically_bound_p): New function.
10056 (Fload): Bind Qlexical_binding.
10057 (readevalloop): Remove `evalfun' arg.
10058 Bind Qinternal_interpreter_environment.
10059 (Feval_buffer): Bind Qlexical_binding.
10060 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10062 (syms_of_lread): Declare `lexical-binding'.
10064 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10066 * keyboard.c (eval_dyn): New fun.
10067 (menu_item_eval_property): Use it.
10069 * image.c (parse_image_spec): Use Ffunctionp.
10071 * fns.c (concat, mapcar1): Accept byte-code-functions.
10073 * eval.c (Fsetq): Handle lexical vars.
10074 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10075 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10076 (FletX, Flet): Obey lexical binding.
10077 (Fcommandp): Handle closures.
10078 (Feval): New `lexical' arg.
10079 (eval_sub): New function extracted from Feval. Use it almost
10080 everywhere where Feval was used. Look up vars in lexical env.
10082 (Ffunctionp): Move from subr.el.
10083 (Ffuncall): Handle closures.
10084 (apply_lambda): Remove `eval_flags'.
10085 (funcall_lambda): Handle closures and new byte-code-functions.
10086 (Fspecial_variable_p): New function.
10087 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10088 but without exporting it to Lisp.
10090 * doc.c (Fdocumentation, store_function_docstring):
10091 * data.c (Finteractive_form): Handle closures.
10093 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10096 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10098 (exec_byte_code): New function extracted from Fbyte_code to handle new
10099 calling convention for byte-code-functions. Add new byte-codes.
10101 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10103 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10105 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10107 * xdisp.c (redisplay_internal): Fix prototype.
10109 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10111 * xdisp.c (SCROLL_LIMIT): New macro.
10112 (try_scrolling): Use it when setting scroll_limit.
10113 Limit scrolling to 100 screen lines.
10114 (redisplay_window): Even when falling back on "recentering",
10115 position point in the window according to scroll-conservatively,
10116 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10118 (try_scrolling): When point is above the window, allow searching
10119 as far as scroll_max, or one screenful, to compute vertical
10120 distance from PT to the scroll margin position. This prevents
10121 try_scrolling from unnecessarily failing when
10122 scroll-conservatively is set to a value slightly larger than the
10123 window height. Clean up the case of PT below the margin at bottom
10124 of window: scroll_max can no longer be INT_MAX. When aggressive
10125 scrolling is in use, don't let point enter the opposite scroll
10126 margin as result of the scroll.
10127 (syms_of_xdisp) <scroll-conservatively>: Document the
10128 threshold of 100 lines for never-recentering scrolling.
10130 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10132 * dispextern.h (move_it_by_lines):
10133 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10134 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10135 (message_log_check_duplicate): Remove parameters `prev_bol' and
10136 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10137 (redisplay_internal): Remove parameter `preserve_echo_area',
10138 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10140 * indent.c (Fvertical_motion):
10141 * window.c (window_scroll_pixel_based, Frecenter):
10142 Don't pass `need_y_p' to `move_it_by_lines'.
10144 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10146 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10147 steal a few bits to be more compact.
10148 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10149 Remove unneeded casts.
10151 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10153 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10155 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10156 binding" message (bug#7967).
10158 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10160 Fix more problems found by GCC 4.6.0's static checks.
10162 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10163 Remove unused local var.
10165 * editfns.c (Fmessage_box): Remove unused local var.
10167 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10168 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10169 Omit unused local vars.
10170 * window.c (shrink_windows): Omit unused local var.
10171 * menu.c (digest_single_submenu): Omit unused local var.
10172 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10173 Omit unused local var.
10175 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10176 Don't assume string length fits in int.
10177 (keyremap_step, read_key_sequence): Use size_t for sizes.
10178 (read_key_sequence): Don't check last_real_key_start redundantly.
10180 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10181 instead of alloca (Bug#8344).
10183 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10184 (Fbacktrace_frame): Don't assume nframes fits in int.
10186 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10188 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10191 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10193 * cm.c (calccost): Turn while-do into do-while, for clarity.
10195 * keyboard.c (syms_of_keyboard): Use the same style as later
10196 in this function when indexing through an array. This also
10197 works around GCC bug 48267.
10199 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10201 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10203 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10204 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10206 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10207 This avoids undefined behavior on integer overflow, and is a bit
10208 more convenient anyway since it is compared to a size_t variable.
10210 Variadic C functions now count arguments with size_t, not int.
10211 This avoids an unnecessary limitation on 64-bit machines, which
10212 caused (substring ...) to crash on large vectors (Bug#8344).
10213 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10214 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10215 All variadic functions and their callers changed accordingly.
10216 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10217 * data.c (arith_driver, float_arith_driver): Likewise.
10218 * editfns.c (general_insert_function): Likewise.
10219 * eval.c (struct backtrace.nargs, interactive_p)
10220 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10221 (funcall_lambda, mark_backtrace): Likewise.
10222 * fns.c (concat): Likewise.
10223 * frame.c (x_set_frame_parameters): Likewise.
10224 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10225 0 if not found, not -1. All callers changed.
10227 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10228 (stack_copy_size): Now size_t, not int.
10229 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10231 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10233 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10234 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10235 All callers changed.
10237 * lisp.h (multibyte_char_to_unibyte):
10238 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10239 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10240 * character.h (CHAR_TO_BYTE8):
10241 * cmds.c (internal_self_insert):
10242 * editfns.c (general_insert_function):
10243 * keymap.c (push_key_description):
10244 * search.c (Freplace_match):
10245 * xdisp.c (message_dolog, set_message_1): All callers changed.
10247 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10249 * keyboard.c (safe_run_hook_funcall): New function.
10250 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10251 don't set the hook to nil, but remove the offending function instead.
10252 (Qcommand_hook_internal): Remove, unused.
10253 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10254 Vcommand_hook_internal.
10256 * eval.c (enum run_hooks_condition): Remove.
10257 (funcall_nil, funcall_not): New functions.
10258 (run_hook_with_args): Call each function through a `funcall' argument.
10259 Remove `cond' argument, now redundant.
10260 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10261 (Frun_hook_with_args_until_failure): Adjust accordingly.
10262 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10264 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10266 * dispextern.h (string_buffer_position): Remove declaration.
10268 * print.c (strout): Remove parameter `multibyte', unused since
10269 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10271 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10272 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10273 All callers changed.
10275 * w32.c (_wsa_errlist): Use braces for struct initializers.
10277 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10278 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10279 All callers changed.
10280 (string_buffer_position): Likewise. Also, make static (it's never
10281 used outside xdisp.c).
10282 (cursor_row_p): Remove parameter `w', unused since
10283 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10284 (decode_mode_spec): Remove parameter `precision', introduced during
10285 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10286 All callers changed.
10288 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10290 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10292 2011-03-27 Anders Lindgren <andlind@gmail.com>
10294 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10295 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10296 (ns_update_auto_hide_menu_bar): New functions.
10297 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10298 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10299 ns_constrain_all_frames.
10300 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10301 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10303 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10305 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10307 2011-03-27 Glenn Morris <rgm@gnu.org>
10309 * syssignal.h: Replace RETSIGTYPE with void.
10310 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10311 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10312 Replace SIGTYPE with void everywhere.
10313 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10314 * s/template.h (SIGTYPE): Remove commented out definition.
10316 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10318 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10319 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10321 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10323 * w32.c (read_unc_volume): Use parameter `henum', instead of
10324 global variable `wget_enum_handle'.
10326 * keymap.c (describe_vector): Remove parameters `indices' and
10327 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10328 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10330 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10332 * keyboard.c (timer_check): Remove parameter `do_it_now',
10333 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10334 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10335 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10337 * keyboard.c (read_char):
10338 * w32menu.c (w32_menu_display_help):
10339 * xmenu.c (show_help_event, menu_help_callback):
10340 Adjust calls to `show_help_echo'.
10342 * gtkutil.c (xg_maybe_add_timer):
10343 * keyboard.c (readable_events):
10344 * process.c (wait_reading_process_output):
10345 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10347 * insdel.c (adjust_markers_gap_motion):
10348 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10349 (gap_left, gap_right): Don't call it.
10351 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10353 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10354 incurred during fontification.
10356 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10358 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10359 (DEFVAR_PER_BUFFER): Don't pass it.
10361 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10362 (scrolling_window): Don't pass it.
10364 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10366 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10368 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10370 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10371 of variables specific to SELinux and computation of `encoded_absname'.
10373 * image.c (XPutPixel): Remove unused variable `height'.
10375 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10377 * unexw32.c (get_section_info): Remove unused variable `section'.
10379 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10380 (system_process_attributes): Remove unused variable `sess'.
10381 (sys_read): Remove unused variable `err'.
10383 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10384 (w32_wnd_proc): Remove unused variable `isdead'.
10385 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10386 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10387 (x_create_tip_frame): Remove unused variable `tem'.
10389 * w32inevt.c (w32_console_read_socket):
10390 Remove unused variable `no_events'.
10392 * w32term.c (x_draw_composite_glyph_string_foreground):
10393 Remove unused variable `width'.
10395 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10397 * w32term.c (x_set_glyph_string_clipping):
10398 Don't pass uninitialized region to CombineRgn.
10400 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10402 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10403 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10404 (Fx_close_connection): Remove unused variable `i'.
10406 * w32font.c (w32font_draw): Return number of glyphs.
10407 (w32font_open_internal): Remove unused variable `i'.
10408 (w32font_driver): Add missing initializer.
10410 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10411 (fill_in_menu): Remove unused variable `items_added'.
10413 * w32term.c (last_mouse_press_frame): Remove static global variable.
10414 (w32_clip_to_row): Remove unused variable `f'.
10415 (x_delete_terminal): Remove unused variable `i'.
10417 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10418 (NOTHING): Remove unused static global variable.
10419 (uniscribe_check_otf): Remove unused variable `table'.
10420 (uniscribe_font_driver): Add missing initializers.
10422 2011-03-23 Julien Danjou <julien@danjou.info>
10424 * term.c (Fsuspend_tty, Fresume_tty):
10425 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10426 * window.c (temp_output_buffer_show):
10427 * insdel.c (signal_before_change):
10428 * frame.c (Fhandle_switch_frame):
10429 * fileio.c (Fdo_auto_save):
10430 * emacs.c (Fkill_emacs):
10431 * editfns.c (save_excursion_restore):
10432 * cmds.c (internal_self_insert):
10433 * callint.c (Fcall_interactively):
10434 * buffer.c (Fkill_all_local_variables):
10435 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10437 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10438 unconditionally since it does the check itself.
10440 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10442 Fix more problems found by GCC 4.5.2's static checks.
10444 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10445 the first time through the loop, since we know p0 < p1 then.
10446 This also avoids a gcc -Wstrict-overflow warning.
10448 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10449 leading to a memory leak, possible in functions like
10450 load_charset_map_from_file that can allocate an unbounded number
10451 of objects (Bug#8318).
10453 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10454 that could (at least in theory) be that large.
10456 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10457 This is less likely to overflow, and avoids undefined behavior if
10458 overflow does occur. All callers changed. Use strtoul to scan
10459 for the unsigned long integer.
10460 (pint2hrstr): Simplify and tune code slightly.
10461 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10463 * scroll.c (do_scrolling): Work around GCC bug 48228.
10464 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10466 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10467 This also avoids a warning with gcc -Wstrict-overflow.
10468 (validate_x_resource_name): Simplify count usage.
10469 This also avoids a warning with gcc -Wstrict-overflow.
10471 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10474 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10476 * process.c (Fmake_network_process): Use socklen_t, not int,
10477 where POSIX says socklen_t is required in portable programs.
10478 This fixes a porting bug on hosts like 64-bit HP-UX, where
10479 socklen_t is wider than int (Bug#8277).
10480 (Fmake_network_process, server_accept_connection):
10481 (wait_reading_process_output, read_process_output):
10484 * process.c: Rename or move locals to avoid shadowing.
10485 (list_processes_1, Fmake_network_process):
10486 (read_process_output_error_handler, exec_sentinel_error_handler):
10487 Rename or move locals.
10488 (Fmake_network_process): Define label "retry_connect" only if needed.
10489 (Fnetwork_interface_info): Fix pointer signedness.
10490 (process_send_signal): Add cast to avoid pointer signedness problem.
10491 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10492 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10494 Make tparam.h and terminfo.c consistent.
10495 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10496 Include tparam.h instead, since it declares them.
10497 * cm.h (PC): Remove extern decl; tparam.h now does this.
10498 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10499 * terminfo.c: Include tparam.h, to check interfaces.
10500 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10501 (tparam): Adjust signature to match interface in tparam.h;
10502 this removes some undefined behavior. Check that outstring and len
10503 are zero, which they always are with Emacs.
10504 * tparam.h (PC, BC, UP): New extern decls.
10506 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10507 (xftfont_open): Rename locals to avoid shadowing.
10509 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10510 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10511 (OTF_TAG_SYM): Omit macro if not needed.
10512 (ftfont_list): Remove unused local.
10513 (get_adstyle_property, ftfont_pattern_entity):
10514 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10515 Rename locals to avoid shadowing.
10517 * xfont.c (xfont_list_family): Mark var as initialized.
10519 * xml.c (make_dom): Now static.
10521 * composite.c (composition_compute_stop_pos): Rename local to
10523 (composition_reseat_it): Remove unused locals.
10524 (find_automatic_composition, composition_adjust_point): Likewise.
10525 (composition_update_it): Mark var as initialized.
10526 (find_automatic_composition): Mark vars as initialized,
10527 with a FIXME (Bug#8290).
10529 character.h: Rename locals to avoid shadowing.
10530 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10531 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10532 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10533 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10534 to avoid shadowing.
10536 * textprop.c (property_change_between_p): Remove; unused.
10538 * intervals.c (interval_start_pos): Now static.
10540 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10542 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10543 Rename locals to avoid shadowing.
10545 * sound.c (wav_play, au_play, Fplay_sound_internal):
10546 Fix pointer signedness.
10547 (alsa_choose_format): Remove unused local var.
10548 (wav_play): Initialize a variable to 0, to prevent undefined
10549 behavior (Bug#8278).
10551 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10553 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10555 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10556 clobbering (Bug#8298).
10557 * sysdep.c (sys_subshell): Likewise.
10558 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10560 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10561 This should get cleaned up, so that child_setup has the
10562 same signature on all platforms.
10564 * callproc.c (call_process_cleanup): Now static.
10565 (relocate_fd): Rename locals to avoid shadowing.
10567 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10569 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10570 not to be necessary, and produces flickering.
10572 2011-03-20 Glenn Morris <rgm@gnu.org>
10574 * config.in: Remove file.
10576 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10578 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10579 are now in src/globals.h.
10580 (syms_of_minibuf): Remove spurious & from previous change.
10582 2011-03-20 Leo Liu <sdl.web@gmail.com>
10584 * minibuf.c (completing-read-function): New variable.
10585 (completing-read-default): Rename from completing-read.
10586 (completing-read): Call completing-read-function.
10588 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10590 * xfaces.c (Fx_load_color_file):
10591 Read color file from absolute filename (bug#8250).
10593 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10595 * makefile.w32-in: Update dependencies.
10597 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10599 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10601 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10603 Fix more problems found by GCC 4.5.2's static checks.
10605 * process.c (make_serial_process_unwind, send_process_trap):
10606 (sigchld_handler): Now static.
10608 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10609 That way, the code declares only the vars that it needs.
10610 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10611 * s/cygwin.h (PTY_ITERATION): Likewise.
10612 * s/darwin.h (PTY_ITERATION): Likewise.
10613 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10615 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10616 * process.c (allocate_pty): Don't declare stb unless it's needed.
10618 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10619 (CONSTANTLIM): Remove; unused.
10620 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10621 Define only if needed.
10623 * unexelf.c (unexec): Name an expression,
10624 to avoid gcc -Wbad-function-cast warning.
10625 Use a different way to cause a compilation error if anyone uses
10626 n rather than nn, a way that does not involve shadowing.
10627 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10629 * deps.mk (unexalpha.o): Remove; unused.
10631 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10632 * unexec.h: New file.
10633 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10634 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10635 Depend on unexec.h.
10636 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10637 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10638 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10639 Change as necessary to match prototype in unexec.h.
10641 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10643 (back_comment, skip_chars): Mark vars as initialized.
10645 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10646 Rename locals to avoid shadowing.
10648 * lread.c (read1): Rewrite so as not to use empty "else".
10649 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10651 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10653 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10654 warning when compiling print.c.
10656 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10657 instead of using an uninitialized var.
10658 (font_sort_entities): Mark var as initialized.
10660 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10662 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10663 pointers to constants.
10664 (font_parse_fcname): Remove unused vars.
10665 (font_delete_unmatched): Now static.
10666 (font_get_spec): Remove; unused.
10667 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10668 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10669 Rename or move locals to avoid shadowing.
10671 * fns.c (require_nesting_list, require_unwind): Now static.
10672 (Ffillarray): Rename locals to avoid shadowing.
10674 * floatfns.c (domain_error2): Define only if needed.
10675 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10677 * alloc.c (mark_backtrace): Move decl from here ...
10678 * lisp.h: ... to here, so that it can be checked.
10680 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10681 (Fdefvar): Rewrite so as not to use empty "else".
10682 (lisp_indirect_variable): Name an expression,
10683 to avoid gcc -Wbad-function-cast warning.
10684 (Fdefvar): Rename locals to avoid shadowing.
10686 * callint.c (quotify_arg, quotify_args): Now static.
10687 (Fcall_interactively): Rename locals to avoid shadowing.
10688 Use const pointer when appropriate.
10690 * lisp.h (get_system_name, get_operating_system_release):
10691 Move decls here, to check interfaces.
10692 * process.c (get_operating_system_release): Move decl to lisp.h.
10693 * xrdb.c (get_system_name): Likewise.
10694 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10695 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10696 some of which prompt warnings from gcc -Wbad-function-cast.
10697 (Fformat_time_string, Fencode_time, Finsert_char):
10698 (Ftranslate_region_internal, Fformat):
10699 Rename or remove local vars to avoid shadowing.
10700 (Ftranslate_region_internal): Mark var as initialized.
10702 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10705 * lisp.h (eassert): Check that the argument compiles, even if
10706 ENABLE_CHECKING is not defined.
10708 * data.c (Findirect_variable): Name an expression, to avoid
10709 gcc -Wbad-function-cast warning.
10710 (default_value, arithcompare, arith_driver, arith_error): Now static.
10711 (store_symval_forwarding): Rename local to avoid shadowing.
10712 (Fmake_variable_buffer_local, Fmake_local_variable):
10713 Mark variables as initialized.
10714 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10716 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10717 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10718 Rename locals to avoid shadowing.
10719 (mark_stack): Move local variables into the #ifdef region where
10721 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10722 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10724 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10725 (GC_STRING_CHARS): Remove; not used.
10726 (Fmemory_limit): Cast sbrk's returned value to char *.
10728 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10729 avoids undefined behavior in theory.
10731 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10733 Use functions, not macros, for up- and down-casing (Bug#8254).
10734 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10735 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10736 to use the following functions instead of these macros.
10737 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10738 EMACS_INT, since callers assume the returned value fits in int.
10739 (upcase1): Likewise, for UPCASE_TABLE.
10740 (uppercasep, lowercasep, upcase): New static inline functions.
10741 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10742 the race-condition problem in the old DOWNCASE.
10744 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10745 Rename locals to avoid shadowing.
10746 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10747 (regex_compile, re_search_2, re_match_2_internal):
10748 Remove unused local vars.
10749 (FREE_VAR): Rewrite so as not to use empty "else",
10750 which gcc can warn about.
10751 (regex_compile, re_match_2_internal): Mark locals as initialized.
10752 (RETALLOC_IF): Define only if needed.
10753 (WORDCHAR_P): Likewise. This one is never needed, but is used
10754 only in a comment talking about a compiler bug, so put inside
10755 the #if 0 of that comment.
10756 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10757 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10760 * search.c (boyer_moore): Rename locals to avoid shadowing.
10761 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10762 (PREV_CHAR_BOUNDARY): Likewise.
10764 * search.c (simple_search): Remove unused var.
10766 * dired.c (compile_pattern): Move decl from here ...
10767 * lisp.h: ... to here, so that it can be checked.
10768 (struct re_registers): New forward decl.
10770 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10772 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10774 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10775 Rename locals to avoid shadowing.
10776 (Fvertical_motion): Mark locals as initialized.
10778 * casefiddle.c (casify_object, casify_region): Now static.
10779 (casify_region): Mark local as initialized.
10781 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10783 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10784 New macros, so that the caller can use some names other than
10785 gcpro1, gcpro2, etc.
10786 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10788 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10789 argument, for consistency with GCPRO2_VAR, etc: it is now the
10790 prefix of the variable, not the variable itself. All uses
10792 * dired.c (directory_files_internal, file_name_completion):
10793 Rename locals to avoid shadowing.
10795 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10796 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10797 dired.c's scmp function, had undefined behavior.
10798 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10799 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10800 * buffer.h: ... to here, because these macros use current_buffer,
10801 and the new implementation with inline functions needs to have
10802 current_buffer in scope now, rather than later when the macros
10804 (downcase, upcase1): New static inline functions.
10805 (DOWNCASE, UPCASE1): Reimplement using these functions.
10806 This avoids undefined behavior in expressions like
10807 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10808 from race conditions in accessing the global variables
10809 case_temp1 and case_temp2.
10810 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10811 * lisp.h (case_temp1, case_temp2): Remove their decls.
10812 * character.h (ASCII_CHAR_P): Move from here ...
10813 * lisp.h: ... to here, so that the inline functions mentioned
10814 above can use them.
10816 * dired.c (directory_files_internal_unwind): Now static.
10818 * fileio.c (file_name_as_directory, directory_file_name):
10819 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10821 (file_name_as_directory): Use const pointers when appropriate.
10822 (Fexpand_file_name): Likewise. In particular, newdir might
10823 point at constant storage, so make it a const pointer.
10824 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10825 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10827 (Fset_file_times, Finsert_file_contents, auto_save_error):
10828 Rename locals to avoid shadowing.
10830 * minibuf.c (choose_minibuf_frame_1): Now static.
10831 (Ftry_completion, Fall_completions): Rename or remove locals
10832 to avoid shadowing.
10834 * marker.c (bytepos_to_charpos): Remove; unused.
10836 * lisp.h (verify_bytepos, count_markers): New decls,
10837 so that gcc does not warn that these functions aren't declared.
10839 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10840 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10841 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10842 (copy_text): Remove unused local var.
10844 * filelock.c (within_one_second): Now static.
10845 (lock_file_1): Rename local to avoid shadowing.
10847 * buffer.c (fix_overlays_before): Mark locals as initialized.
10848 (fix_start_end_in_overlays): Likewise. This function should be
10849 simplified by using pointers-to-pointers, but that's a different
10851 (switch_to_buffer_1): Now static.
10852 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10853 (report_overlay_modification): Rename locals to avoid shadowing.
10855 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10856 Fix pointer signedness issue.
10857 (sys_subshell): Mark local as volatile if checking for lint,
10858 to suppress a gcc -Wclobbered warning that does not seem to be right.
10859 (MAXPATHLEN): Define only if needed.
10861 * process.c (serial_open, serial_configure): Move decls from here ...
10862 * systty.h: ... to here, so that they can be checked.
10864 * fns.c (get_random, seed_random): Move extern decls from here ...
10865 * lisp.h: ... to here, so that they can be checked.
10867 * sysdep.c (reset_io): Now static.
10868 (wait_for_termination_signal): Remove; unused.
10870 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10871 (copy_keymap_item, append_key, push_text_char_description):
10873 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10874 (DENSE_TABLE_SIZE): Remove; unused.
10875 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10876 (describe_map_tree):
10877 Rename locals to avoid shadowing.
10879 * keyboard.c: Declare functions static if they are not used elsewhere.
10880 (echo_char, echo_dash, cmd_error, top_level_2):
10881 (poll_for_input, handle_async_input): Now static.
10882 (read_char, kbd_buffer_get_event, make_lispy_position):
10883 (make_lispy_event, make_lispy_movement, apply_modifiers):
10884 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10885 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10886 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10887 (read_key_sequence, read_char): Mark locals as initialized.
10888 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10890 * keyboard.h (make_ctrl_char): New decl.
10891 (mark_kboards): Move decl here ...
10892 * alloc.c (mark_kboards): ... from here.
10894 * lisp.h (force_auto_save_soon): New decl.
10896 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10897 (DEFINE_DUMMY_FUNCTION): New macro.
10898 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10900 (main): Add casts to avoid warnings
10901 if GCC considers string literals to be constants.
10903 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10905 * dbusbind.c: Pointer signedness fixes.
10906 (xd_signature, xd_append_arg, xd_initialize):
10907 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10908 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10909 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10910 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10912 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10913 if GCC considers string literals to be constants.
10914 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10916 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10918 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10919 (print_preprocess, print_object): New macro to fix last change.
10921 * print.c (print_preprocess): Don't forget font objects.
10923 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10925 * emacs.c (USAGE3): Doc fixes.
10927 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10929 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10932 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10934 * lisp.h (VWindow_system, Qfile_name_history):
10935 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10936 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10937 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10939 * w32select.c: Don't #include "keyboard.h".
10940 (run_protected): Add extern declaration for waiting_for_input.
10942 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10943 * w32console.c (detect_input_pending, read_input_pending)
10944 (encode_terminal_code):
10945 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10946 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10947 (w32_system_caret_y, Qfile_name_history):
10948 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10949 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10950 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10951 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10952 * w32proc.c (Qlocal, report_file_error):
10953 * w32term.c (Vwindow_system, updating_frame):
10954 * w32uniscribe.c (initialized, uniscribe_font_driver):
10955 Remove unneeded extern declarations.
10957 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10959 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10961 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10963 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10964 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10965 These macros can no longer be used for assignment.
10967 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10968 Assign struct members directly, instead of using BUF_BEGV etc.
10969 (record_buffer_markers, fetch_buffer_markers): New functions for
10970 recording and fetching special buffer markers.
10971 (set_buffer_internal_1, set_buffer_temp): Use them.
10973 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10975 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10977 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10978 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10980 * xdisp.c (hscroll_window_tree):
10981 (reconsider_clip_changes): Use PT instead of BUF_PT.
10983 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10985 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10986 $(EMACS_ROOT)/lib/intprops.h.
10988 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10990 Fix more problems found by GCC 4.5.2's static checks.
10992 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10993 to unsigned char * to avoid compiler diagnostic.
10994 (xg_free_frame_widgets): Make it clear that a local variable is
10995 needed only if USE_GTK_TOOLTIP.
10996 (gdk_window_get_screen): Make it clear that this macro is needed
10997 only if USE_GTK_TOOLTIP.
10998 (int_gtk_range_get_value): New function, which avoids a diagnostic
10999 from gcc -Wbad-function-cast.
11000 (xg_set_toolkit_scroll_bar_thumb): Use it.
11001 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11002 diagnostic from gcc -Wbad-function-cast.
11003 (get_utf8_string, xg_get_file_with_chooser):
11004 Rename locals to avoid shadowing.
11005 (create_dialog): Move locals to avoid shadowing.
11007 * xgselect.c (xg_select): Remove unused var.
11009 * image.c (four_corners_best): Mark locals as initialized.
11010 (gif_load): Initialize transparent_p to zero (Bug#8238).
11011 Mark another local as initialized.
11012 (my_png_error, my_error_exit): Mark with NO_RETURN.
11014 * image.c (clear_image_cache): Now static.
11015 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11016 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11017 (x_edge_detection): Remove unnecessary cast that
11018 gcc -Wbad-function-cast diagnoses.
11019 (gif_load): Fix pointer signedness.
11020 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11021 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11023 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11025 Improve quality of tests for time stamp overflow.
11026 For example, without this patch (encode-time 0 0 0 1 1
11027 1152921504606846976) returns the obviously-bogus value (-948597
11028 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11029 reports time overflow. See
11030 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11031 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11032 * editfns.c: Include limits.h and intprops.h.
11033 (TIME_T_MIN, TIME_T_MAX): New macros.
11034 (time_overflow): Move earlier, to before first use.
11035 (hi_time, lo_time): New functions, for an accurate test for
11036 out-of-range times.
11037 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11038 (Fget_internal_run_time): Don't assume time_t fits in int.
11039 (make_time): Use list2 instead of Fcons twice.
11040 (Fdecode_time): More accurate test for out-of-range times.
11041 (check_tm_member): New function.
11042 (Fencode_time): Use it, to test for out-of-range times.
11043 (lisp_time_argument): Don't rely on undefined left-shift and
11044 right-shift behavior when checking for time stamp overflow.
11046 * editfns.c (time_overflow): New function, refactoring common code.
11047 (Fformat_time_string, Fdecode_time, Fencode_time):
11048 (Fcurrent_time_string): Use it.
11050 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11051 * dired.c (make_time): Move to ...
11052 * editfns.c (make_time): ... here.
11053 * systime.h: Note the move.
11055 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11057 * fringe.c (update_window_fringes): Remove unused variables.
11059 * unexmacosx.c (copy_data_segment): Also copy __got section.
11062 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11064 * termcap.c [MSDOS]: Include "msdos.h".
11065 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11066 Constify `char *' arguments and their references according to
11067 prototypes in tparam.h.
11069 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11071 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11072 Adapt all references accordingly.
11074 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11076 2011-03-11 Tom Tromey <tromey@redhat.com>
11078 * buffer.c (syms_of_buffer): Remove obsolete comment.
11080 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11082 * termhooks.h (encode_terminal_code): Declare prototype.
11084 * msdos.c (encode_terminal_code): Don't declare prototype.
11086 * term.c (encode_terminal_code): Now external again, used by
11087 w32console.c and msdos.c.
11089 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11090 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11092 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11094 Fix some minor problems found by GCC 4.5.2's static checks.
11096 * fringe.c (update_window_fringes): Mark locals as initialized
11098 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11100 * alloc.c (mark_fringe_data): Move decl from here ...
11101 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11102 to check its interface.
11103 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11105 * fontset.c (free_realized_fontset): Now static.
11106 (Fset_fontset_font): Rename local to avoid shadowing.
11107 (fontset_font): Mark local as initialized.
11108 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11110 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11112 * xselect.c (x_disown_buffer_selections): Remove; not used.
11113 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11114 (x_own_selection, Fx_disown_selection_internal): Rename locals
11115 to avoid shadowing.
11116 (x_handle_dnd_message): Remove local to avoid shadowing.
11118 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11119 so that the caller can use some name other than gcpro1.
11120 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11121 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11122 (Fx_backspace_delete_keys_p):
11123 Use them to avoid shadowing, and rename vars to avoid shadowing.
11124 (x_decode_color, x_set_name, x_window): Now static.
11125 (Fx_create_frame): Add braces to silence GCC warning.
11126 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11127 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11128 Remove unused locals.
11129 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11130 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11131 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11134 * xterm.h (x_mouse_leave): New decl.
11136 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11137 Remove unused functions.
11138 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11139 (x_calc_absolute_position): Now static.
11140 (XTread_socket): Don't define label "out" unless it's used.
11141 Don't declare local "event" unless it's used.
11142 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11143 unless they are used.
11144 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11145 (x_fatal_error_signal): Remove; not used.
11146 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11147 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11148 (x_error_catcher, x_connection_closed, x_error_handler):
11149 (x_error_quitter, xembed_send_message, x_iconify_frame):
11150 (my_log_handler): Rename locals to avoid shadowing.
11151 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11152 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11154 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11155 Rename or move locals to avoid shadowing.
11156 (tty_defined_color, merge_face_heights): Now static.
11157 (free_realized_faces_for_fontset): Remove; not used.
11158 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11159 does not deduce is never used uninitialized.
11160 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11161 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11163 * terminal.c (store_terminal_param): Now static.
11165 * xmenu.c (menu_highlight_callback): Now static.
11166 (set_frame_menubar): Remove unused local.
11167 (xmenu_show): Rename parameter to avoid shadowing.
11168 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11169 since they might point to immutable storage.
11170 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11171 since it's unused otherwise.
11173 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11174 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11175 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11176 avoids a gcc -Wuninitialized diagnostic.
11177 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11178 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11179 does not deduce are never used uninitialized.
11181 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11183 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11184 * window.c (window_loop, size_window):
11185 (run_window_configuration_change_hook, enlarge_window): Likewise.
11187 * window.c (display_buffer): Now static.
11188 (size_window): Mark variables that gcc -Wuninitialized
11189 does not deduce are never used uninitialized.
11190 * window.h (check_all_windows): New decl, to forestall
11191 gcc -Wmissing-prototypes diagnostic.
11192 * dispextern.h (bidi_dump_cached_states): Likewise.
11194 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11196 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11197 Include <limits.h>.
11198 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11199 and to avoid gcc -Wuninitialized warning.
11200 (load_charset_map): Mark variables that gcc -Wuninitialized
11201 does not deduce are never used uninitialized.
11202 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11204 * coding.c (coding_set_source, coding_set_destination):
11205 Use "else { /* comment */ }" rather than "else /* comment */;"
11206 for clarity, and to avoid gcc -Wempty-body warning.
11207 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11208 a block, when the outer 'i' will do.
11209 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11210 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11211 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11212 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11213 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11214 Rename locals to avoid shadowing.
11215 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11216 * coding.c (emacs_mule_char, encode_invocation_designation):
11217 Now static, since they're not used elsewhere.
11218 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11219 (decode_coding_object, encode_coding_object, detect_coding_system):
11220 (decode_coding_emacs_mule): Mark variables that gcc
11221 -Wuninitialized does not deduce are never used uninitialized.
11222 (detect_coding_iso_2022): Initialize a local variable that might
11223 be used uninitialized. Leave a FIXME because it's not clear that
11224 this initialization is needed. (Bug#8211)
11225 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11226 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11227 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11228 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11229 Remove unused macros.
11231 * category.c (hash_get_category_set): Remove unused local var.
11232 (copy_category_table): Now static, since it's not used elsewhere.
11233 * character.c (string_count_byte8): Likewise.
11235 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11236 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11238 * chartab.c (copy_sub_char_table): Now static, since it's not used
11240 (sub_char_table_ref_and_range, char_table_ref_and_range):
11241 Rename locals to avoid shadowing.
11242 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11244 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11245 (BIDI_BOB): Remove unused macro.
11247 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11248 deduce are never used uninitialized.
11249 * term.c (encode_terminal_code): Likewise.
11251 * term.c (encode_terminal_code): Now static. Remove unused local.
11253 * tparam.h: New file.
11254 * term.c, tparam.h: Include it.
11255 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11256 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11257 Move these decls to tparam.h, and make them agree with what
11258 is actually in tparam.c. The previous trick of using incompatible
11259 decls in different modules does not conform to the C standard.
11260 All callers of tparam changed to use tparam's actual API.
11261 * tparam.c (tparam1, tparam, tgoto):
11262 Use const pointers where appropriate.
11264 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11265 * cm.h (struct cm): Likewise.
11266 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11267 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11268 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11269 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11270 (turn_on_face, init_tty): Likewise.
11271 * termchar.h (struct tty_display_info): Likewise.
11273 * term.c (term_mouse_position): Rename local to avoid shadowing.
11275 * alloc.c (mark_ttys): Move decl from here ...
11276 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11278 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11280 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11282 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11284 * search.c (compile_pattern_1): Remove argument regp, unused since
11285 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11286 (compile_pattern): Don't pass it.
11288 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11290 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11291 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11293 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11295 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11297 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11298 gdk_window_get_screen, gdk_window_get_geometry,
11299 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11300 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11301 (xg_get_pixbuf_from_pixmap): New function.
11302 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11303 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11304 Call xg_get_pixbuf_from_pixmap instead of
11305 gdk_pixbuf_get_from_drawable.
11306 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11307 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11308 (xg_check_special_colors): Use GtkStyleContext and its functions
11310 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11311 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11312 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11313 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11314 Call gtk_widget_get_preferred_size.
11315 (xg_frame_resized): gdk_window_get_geometry only takes 5
11317 (xg_win_to_widget, xg_event_is_for_menubar):
11318 Call gdk_x11_window_lookup_for_display.
11319 (xg_set_widget_bg): New function.
11320 (delete_cb): New function.
11321 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11322 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11323 (xg_set_background_color): Call xg_set_widget_bg.
11324 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11325 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11326 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11327 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11329 (update_frame_tool_bar): Call gtk_widget_hide.
11330 (xg_initialize): Use GDK_KEY_g.
11332 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11334 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11336 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11337 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11338 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11340 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11342 * w32xfns.c (select_palette): Check success of RealizePalette against
11343 GDI_ERROR, not zero.
11345 See ChangeLog.11 for earlier changes.
11347 ;; Local Variables:
11351 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11353 This file is part of GNU Emacs.
11355 GNU Emacs is free software: you can redistribute it and/or modify
11356 it under the terms of the GNU General Public License as published by
11357 the Free Software Foundation, either version 3 of the License, or
11358 (at your option) any later version.
11360 GNU Emacs is distributed in the hope that it will be useful,
11361 but WITHOUT ANY WARRANTY; without even the implied warranty of
11362 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11363 GNU General Public License for more details.
11365 You should have received a copy of the GNU General Public License
11366 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.