1 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
48 * buffer.h: Adjust decls to match defn changes elsewhere.
49 (struct buffer_text, struct buffer):
50 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
51 Use EMACS_INT, not int, where int might not be wide enough.
52 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
53 not int, to avoid needless 32-bit limit on 64-bit hosts.
54 (exec_byte_code): Use tighter memory-full test, one that checks
55 for alloca overflow. Don't compute the address of the object just
56 before an array, as that's not portable. Use EMACS_INT, not
57 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
58 * callint.c (Fcall_interactively):
59 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
60 * callproc.c (call_process_kill, Fcall_process):
61 Don't assume pid_t fits into an Emacs fixnum.
62 (call_process_cleanup, Fcall_process, child_setup):
63 Don't assume pid_t fits into int.
64 (call_process_cleanup, Fcall_process, delete_temp_file)
65 (Fcall_process_region):
66 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
67 (Fcall_process): Simplify handling of volatile integers.
68 Use int, not EMACS_INT, where int will do.
69 * casefiddle.c (casify_object, casify_region, operate_on_word)
70 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
71 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
72 (casify_object): Avoid integer overflow when overallocating buffer.
73 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
74 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
75 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
76 * category.h (CATEGORYP): Don't assume arg is nonnegative.
77 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
78 integers are now checked earlier. All uses replaced with XINT.
80 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
81 For CCL_MapSingle, check that content and value are in int range.
82 (ccl_driver, Fregister_code_conversion_map):
83 Check that Vcode_version_map_vector is a vector.
84 (resolve_symbol_ccl_program): Check that vector header is in range.
85 Always copy the vector, so that we can check its contents reliably
86 now rather than having to recheck each instruction as it's being
87 executed. Check that vector words fit in 'int'.
88 (ccl_get_compiled_code, Fregister_ccl_program)
89 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
90 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
91 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
92 contents are in range.
93 (Fccl_execute_on_string): Check that status is in range.
94 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
95 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
96 Accept and return EMACS_INT, not int, because callers can pass values
98 (c_string_width, strwidth, lisp_string_width, chars_in_text)
99 (multibyte_chars_in_text, parse_str_as_multibyte)
100 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
101 (str_as_unibyte, str_to_unibyte, string_count_byte8)
102 (string_escape_byte8, Fget_byte):
103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
104 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
105 avoid mishandling large integers.
106 * character.h: Adjust decls to match defn changes elsewhere.
107 * charset.c (load_charset_map_from_file, find_charsets_in_text)
108 (Ffind_charset_region):
109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
110 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
111 (load_charset_map_from_vector, Fdefine_charset_internal):
112 Don't assume fixnum fits in int.
113 (load_charset_map_from_vector, Fmap_charset_chars):
114 Remove now-unnecessary CHECK_NATNUMs.
115 (Fdefine_charset_internal): Check ranges here, more carefully.
116 Don't rely on undefined behavior with signed left shift overflow.
117 Don't assume unsigned int fits into fixnum, or that fixnum fits
118 into unsigned int. Don't require max_code to be a valid fixnum;
119 that's not true for gb10830 4-byte on a 32-bit host. Allow
120 invalid_code to be a cons, for the same reason. Require code_offset
121 to be a character. Avoid int overflow if max_char is close
123 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
124 this is intended anyway and avoids some undefined behavior.
125 (load_charset_map): Pass unsigned, not int, as 2nd arg of
126 INDEX_TO_CODE_POINT, as that's what it expects.
127 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
128 * charset.h (DECODE_CHAR): Return int, not unsigned;
129 this is what was intended anyway, and it avoids undefined behavior.
130 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
131 integer-overflow issues.
132 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
133 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
134 where the argument is EMACS_INT, and this behavior is not intended.
135 * chartab.c (Fmake_char_table, Fset_char_table_range)
136 (uniprop_get_decoder, uniprop_get_encoder):
137 Don't assume fixnum fits in int.
138 * cmds.c (move_point): New function, that does the gist of
139 Fforward_char and Fbackward_char, but does so while checking
140 for integer overflow more accurately.
141 (Fforward_char, Fbackward_char): Use it.
142 (Fforward_line, Fend_of_line, internal_self_insert)
143 (internal_self_insert):
144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
145 Fix a FIXME, by checking for integer overflow when calculating
146 target_clm and actual_clm.
147 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
148 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
149 (ASSURE_DESTINATION, coding_alloc_by_realloc)
150 (coding_alloc_by_making_gap, alloc_destination)
151 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
152 (encode_coding_utf_16, detect_coding_emacs_mule)
153 (decode_coding_emacs_mule, encode_coding_emacs_mule)
154 (detect_coding_iso_2022, decode_coding_iso_2022)
155 (encode_invocation_designation, encode_designation_at_bol)
156 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
157 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
158 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
159 (encode_coding_ccl, encode_coding_raw_text)
160 (detect_coding_charset, decode_coding_charset)
161 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
162 (produce_composition, produce_charset, produce_annotation)
163 (decode_coding, handle_composition_annotation)
164 (handle_charset_annotation, consume_chars, decode_coding_gap)
165 (decode_coding_object, encode_coding_object, detect_coding_system)
166 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
167 (code_convert_region, code_convert_string)
168 (Fdefine_coding_system_internal)
169 (coding_set_source, coding_set_destination):
170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
171 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
172 (Fdefine_coding_system_internal):
173 Don't assume fixnums fit in int.
174 (decode_coding_gap, decode_coding_object, encode_coding_object)
175 (Fread_coding_system, Fdetect_coding_region)
176 (Funencodable_char_position, Fcheck_coding_systems_region)
177 (get_translation, handle_composition_annotation, consume_chars):
178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
179 (consume_chars): Rewrite to not calculate an address outside buffer.
180 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
181 Don't access memory outside of the args array.
182 (Fdefine_coding_system_internal): Check for charset-id overflow.
183 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
184 result of ENCODE_CHAR.
185 * coding.h: Adjust decls to match defn changes elsewhere.
186 (struct coding_system):
187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
188 * composite.c (get_composition_id, find_composition)
189 (run_composition_function, update_compositions)
190 (compose_text, composition_gstring_put_cache)
191 (composition_gstring_p, composition_gstring_width)
192 (fill_gstring_header, fill_gstring_body, autocmp_chars)
193 (composition_compute_stop_pos, composition_reseat_it)
194 (composition_update_it, struct position_record)
195 (find_automatic_composition, composition_adjust_point)
196 (Fcomposition_get_gstring, Ffind_composition_internal):
197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
198 (update_compositions):
199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
200 * composite.h: Adjust decls to match defn changes elsewhere.
201 (struct composition):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
204 Do not attempt to compute the address of the object just before a
205 buffer; this is not portable.
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 (Faset): Use int, not EMACS_INT, where int is wide enough.
209 (Fstring_to_number): Don't assume fixnums fit in int.
210 (Frem): Don't assume arg is nonnegative.
211 * dbusbind.c (xd_append_arg): Check for integers out of range.
212 (Fdbus_call_method): Don't overflow the timeout int.
213 (extract_signed, extract_unsigned): New functions.
214 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
215 (xd_get_connection_references): Return ptrdiff_t, not int.
217 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
219 Use int, not unsigned, where the dbus API uses int.
220 (Fdbus_message_internal): Don't overflow mtype.
221 (syms_of_dbusbind): Allocate right-sized buffer for integers.
222 * dired.c (directory_files_internal, file_name_completion, scmp)
223 (file_name_completion_stat):
224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
225 (file_name_completion): Don't overflow matchcount.
226 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
227 * dispextern.h: Adjust decls to match defn changes elsewhere.
228 (struct text_pos, struct glyph, struct bidi_saved_info)
229 (struct bidi_string_data, struct bidi_it, struct composition_it)
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (struct display_pos, struct composition_it, struct it):
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 * dispnew.c (increment_matrix_positions)
235 (increment_row_positions, mode_line_string)
236 (marginal_area_string):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
240 (duration_to_sec_usec): New function, to check for overflow better.
241 (Fsleep_for, sit_for): Use it.
242 * doc.c (get_doc_string, store_function_docstring):
243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
244 (get_doc_string, Fsnarf_documentation):
245 Use int, not EMACS_INT, where int is wide enough.
247 Use SAFE_ALLOCA, not alloca.
248 Check for overflow when converting EMACS_INT to off_t.
250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
251 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
252 Don't assume uid_t fits into fixnum.
253 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
254 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
255 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
256 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
257 (general_insert_function)
258 (Finsert_char, make_buffer_string, make_buffer_string_both)
259 (update_buffer_properties, Fbuffer_substring)
260 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
261 (Fsubst_char_in_region, check_translation)
262 (Ftranslate_region_internal, save_restriction_restore, Fformat)
263 (transpose_markers, Ftranspose_regions):
264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
265 (clip_to_bounds): Move to lisp.h as an inline function).
266 (Fconstrain_to_field): Don't assume integers are nonnegative.
267 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
268 (Fsubst_char_in_region, Fsave_restriction):
269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
270 (Femacs_pid): Don't assume pid_t fits into fixnum.
271 (lo_time): Use int, not EMACS_INT, when int suffices.
272 (lisp_time_argument): Check for usec out of range.
273 (Fencode_time): Don't assume fixnum fits in int.
274 (Fuser_login_name, Fuser_full_name): Signal an error
275 if a uid argument is out of range, rather than relying on
277 (Fformat_time_string): Remove now-unnecessary check.
278 lisp_time_argument checks for out-of-range usec now.
279 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
280 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
281 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
282 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
283 (init_cmdargs, Fdump_emacs):
284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
285 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
286 the bottom (typically) 32 bits of the fixnum.
287 * eval.c (specpdl_size, call_debugger):
288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
289 (when_entered_debugger, Fbacktrace_debug):
290 Don't assume fixnum can fit in int.
291 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
292 the object just before a buffer; this is not portable.
293 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
294 (grow_specpdl, unbind_to):
295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
296 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
297 (grow_specpdl): Simplify allocation by using xpalloc.
298 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
299 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
300 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
302 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
305 (Fcopy_file, non_regular_nbytes, read_non_regular)
306 (Finsert_file_contents):
307 Use int, not EMACS_INT, where int is wide enough.
308 (READ_BUF_SIZE): Verify that it fits in int.
309 (Finsert_file_contents): Check that counts are in proper range,
310 rather than assuming fixnums fit into ptrdiff_t etc.
311 Don't assume fixnums fit into int.
312 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
313 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
314 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
315 (string_char_to_byte, string_byte_to_char)
316 (string_make_multibyte, string_to_multibyte)
317 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
318 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
319 (substring_both, Fdelete, internal_equal, Ffillarray)
320 (Fclear_string, mapcar1)
321 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
322 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
323 (larger_vector, make_hash_table, maybe_resize_hash_table)
324 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
325 (Fmaphash, secure_hash):
326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
327 (concat): Check for string index and length overflow.
328 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
331 (larger_vector): New API (vec, incr_min, size_max) replaces old
332 one (vec, new_size, init). This catches size overflow.
333 INIT was removed because it was always Qnil.
335 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
336 the upper bound on a hash table index size.
337 (make_hash_table, maybe_resize_hash_table): Use it.
338 (secure_hash): Computer start_byte and end_byte only after
339 they're known to be in ptrdiff_t range.
340 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
341 (Ffont_get_glyphs, Ffont_at):
342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
343 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
344 (Flist_fonts, Fopen_font):
345 Don't assume fixnum can fit in int.
346 (check_gstring): Don't assume index can fit in int.
347 (font_match_p): Check that fixnum is a character, not a nonnegative
348 fixnum, since the later code needs to stuff it into an int.
349 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
350 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
351 conversion overflow issues.
352 (Fopen_font): Check for integer out of range.
353 (Ffont_get_glyphs): Don't assume index can fit in int.
354 * font.h: Adjust decls to match defn changes elsewhere.
355 * fontset.c (reorder_font_vector): Redo score calculation to avoid
357 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
358 printmax_t, where ptrdiff_t is wide enough.
359 (Finternal_char_font):
360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
361 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
362 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
363 (Fset_frame_position, x_set_frame_parameters)
364 (x_set_line_spacing, x_set_border_width)
365 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
366 Check that fixnums are in proper range for system types.
367 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
369 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
370 Use SAFE_ALLOCA_LISP, not alloca.
371 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
372 intptr_t is wide enough.
373 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
374 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
375 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
376 Check for fixnum out of range.
377 * ftfont.c (ftfont_list): Don't assume index fits in int.
378 Check that fixnums are in proper range for system types.
379 (ftfont_shape_by_flt):
380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
381 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
383 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
384 Check that fixnums are in proper range for system types.
385 * gnutls.h: Adjust decls to match defn changes elsewhere.
386 * gtkutil.c (xg_dialog_run):
387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
388 (update_frame_tool_bar):
389 Check that fixnums are in proper range for system types.
390 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
391 (lookup_image): Check that fixnums are in range for system types.
392 * indent.c (last_known_column, last_known_column_point):
393 (current_column_bol_cache):
394 (skip_invisible, current_column, check_display_width):
395 (check_display_width, scan_for_column, current_column_1)
396 (Findent_to, Fcurrent_indentation, position_indentation)
397 (indented_beyond_p, Fmove_to_column, compute_motion):
398 (Fcompute_motion, Fvertical_motion):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 (last_known_column_modified): Use EMACS_INT, not int.
401 (check_display_width):
403 Check that fixnums and floats are in proper range for system types.
404 (compute_motion): Don't assume index or fixnum fits in int.
405 (compute_motion, Fcompute_motion):
406 Use int, not EMACS_INT, when it is wide enough.
407 (vmotion): Omit local var start_hpos that is always 0; that way
408 we don't need to worry about overflow in expressions involving it.
409 * indent.h: Adjust decls to match defn changes elsewhere.
411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
412 Use int, not EMACS_INT, where int is wide enough.
413 Remove unused members ovstring_chars_done and tab_offset;
415 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
416 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
417 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
418 (make_gap, copy_text, insert, insert_and_inherit)
419 (insert_before_markers, insert_before_markers_and_inherit)
420 (insert_1, count_combining_before, count_combining_after)
421 (insert_1_both, insert_from_string)
422 (insert_from_string_before_markers, insert_from_string_1)
423 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
424 (adjust_after_replace, adjust_after_insert, replace_range)
425 (replace_range_2, del_range, del_range_1, del_range_byte)
426 (del_range_both, del_range_2, modify_region)
427 (prepare_to_modify_buffer, signal_before_change)
428 (signal_after_change, Fcombine_after_change_execute):
429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
430 * intervals.c (traverse_intervals, rotate_right, rotate_left)
431 (balance_an_interval, split_interval_right, split_interval_left)
432 (find_interval, next_interval, update_interval)
433 (adjust_intervals_for_insertion, delete_node, delete_interval)
434 (interval_deletion_adjustment, adjust_intervals_for_deletion)
435 (static_offset_intervals, offset_intervals)
436 (merge_interval_right, merge_interval_left, make_new_interval)
437 (graft_intervals_into_buffer, temp_set_point_both)
438 (temp_set_point, set_point, adjust_for_invis_intang)
439 (set_point_both, move_if_not_intangible, get_property_and_range)
440 (get_local_map, copy_intervals, copy_intervals_to_string)
441 (compare_string_intervals, set_intervals_multibyte_1):
442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
443 * intervals.h: Adjust decls to match defn changes elsewhere.
445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
446 * keyboard.c (this_command_key_count, this_single_command_key_start)
447 (before_command_key_count, before_command_echo_length, echo_now)
448 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
449 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
450 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
451 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
453 (last_non_minibuf_size, last_point_position, echo_truncate)
454 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
455 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
456 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
457 (stuff_buffered_input):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (last_auto_save, command_loop_1, read_char):
460 Use EMACS_INT, not int, to avoid integer overflow.
461 (record_char): Avoid overflow in total_keys computation.
462 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
463 * keyboard.h: Adjust decls to match defn changes elsewhere.
464 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
465 (Fkey_description, Fdescribe_vector, Flookup_key):
466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
467 (click_position): New function, to check that positions are in range.
468 (Fcurrent_active_maps):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (Faccessible_keymaps, Fkey_description):
472 (preferred_sequence_p):
473 Don't assume fixnum can fit into int.
474 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
475 Check for integer overflow in size calculations.
476 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
477 avoid mishandling large integers.
478 * lisp.h: Adjust decls to match defn changes elsewhere.
479 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
480 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
481 (struct Lisp_Marker):
482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
483 (clip_to_bounds): Now an inline function, moved here from editfns.c.
484 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
485 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
487 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
488 Assume the arg has valid form, since it always does.
489 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
490 unsigned integer system type.
491 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
492 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
494 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
495 (duration_to_sec_usec): New decl.
496 * lread.c (read_from_string_index, read_from_string_index_byte)
497 (read_from_string_limit, readchar, unreadchar, openp)
498 (read_internal_start, read1, oblookup):
499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
500 (Fload, readevalloop, Feval_buffer, Feval_region):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 (openp): Check for out-of-range argument to 'access'.
503 (read1): Use int, not EMACS_INT, where int is wide enough.
504 Don't assume fixnum fits into int.
505 Fix off-by-one error that can read outside a buffer.
506 (read_filtered_event): Use duration_to_sec_usec
507 to do proper overflow checking on durations.
508 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
510 (Fexecute_kbd_macro):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
513 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
514 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
515 (set_marker_both, set_marker_restricted_both, marker_position)
516 (marker_byte_position, Fbuffer_has_markers_at):
517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
518 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
519 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
520 It now merely ensures that the menu is large enough, without
521 necessarily growing it, as this avoids some integer overflow issues.
523 (keymap_panes, parse_single_submenu, Fx_popup_menu):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
526 Use SAFE_ALLOCA_LISP, not alloca.
527 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
528 to EMACS_INT. Check that fixnums are in proper range for system types.
529 * minibuf.c (minibuf_prompt_width, string_to_object)
530 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
531 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (get_minibuffer, read_minibuf_unwind):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
536 this simplifies overflow checking. All callers changed.
537 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
541 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
542 Check that fixnums are in proper range for system types.
543 (Fx_create_frame, Fx_show_tip):
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 * nsfont.m (ns_findfonts, nsfont_list_family):
546 Don't assume fixnum fits in long.
547 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
549 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
551 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
553 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
554 (PRINTDECLARE, PRINTPREPARE):
555 (strout, print_string):
556 (print, print_preprocess, print_check_string_charset_prop)
558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 (temp_output_buffer_setup, Fprin1_to_string, print_object):
561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
562 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
563 (printchar, strout): Use xpalloc to catch size calculation overflow.
564 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
565 (print_error_message): Use SAFE_ALLOCA, not alloca.
566 (print_object): Use int, not EMACS_INT, where int is wide enough.
567 (print_depth, new_backquote_output, print_number_index):
568 Use ptrdiff_t, not int, where int might not be wide enough.
569 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
570 (Fset_process_window_size, Fformat_network_address)
571 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
573 Check that fixnums are in proper range for system types.
574 (Fsignal_process): Simplify by avoiding a goto.
575 Check for process-ids out of pid_t range rather than relying on
577 (process_tick, update_tick): Use EMACS_INT, not int.
578 (Fformat_network_address, read_process_output, send_process)
579 (Fprocess_send_region, status_notify):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
582 (wait_reading_process_output, read_process_output, exec_sentinel):
583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
584 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
585 (Faccept_process_output): Use duration_to_sec_usec to do proper
586 overflow checking on durations.
587 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
588 Don't assume pid_t fits in int.
589 * process.h (struct Lisp_Process): Members tick and update_tick
590 are now of type EMACS_INT, not int.
591 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
592 configured --with-wide-int.
593 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
594 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
595 * search.c (looking_at_1, string_match_1):
596 (fast_string_match, fast_c_string_match_ignore_case)
597 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
598 (scan_newline, find_before_next_newline, search_command)
599 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
600 (set_search_regs, wordify):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (string_match_1, search_buffer, set_search_regs):
606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
607 (wordify): Check for overflow in size calculation.
608 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
609 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
610 Check that fixnums are in proper range for system types.
611 * sound.c (struct sound_device)
612 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
614 (Fplay_sound_internal):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 * syntax.c (struct lisp_parse_state, find_start_modiff)
617 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
618 (Fparse_partial_sexp):
619 Don't assume fixnums can fit in int.
620 (struct lisp_parse_state, find_start_pos, find_start_value)
621 (find_start_value_byte, find_start_begv)
622 (update_syntax_table, char_quoted, dec_bytepos)
623 (find_defun_start, prev_char_comend_first, back_comment):
624 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
625 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 (Finternal_describe_syntax_value): Check that match_lisp is a
628 character, not an integer, since the code stuffs it into int.
629 (scan_words, scan_sexps_forward):
630 Check that fixnums are in proper range for system types.
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 (scan_sexps_forward):
634 Use CHARACTERP, not INTEGERP, since the value must fit into int.
635 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
636 * syntax.h: Adjust decls to match defn changes elsewhere.
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
640 MOST_POSITIVE_FIXNUM.
641 * sysdep.c (wait_for_termination_1, wait_for_termination)
642 (interruptible_wait_for_termination, mkdir):
643 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
644 (emacs_read, emacs_write):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
647 and double all fit in int.
648 * term.c (set_tty_color_mode):
649 Check that fixnums are in proper range for system types.
650 * termhooks.h (struct input_event):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 * textprop.c (validate_interval_range, interval_of)
653 (Fadd_text_properties, set_text_properties_1)
654 (Fremove_text_properties, Fremove_list_of_text_properties)
655 (Ftext_property_any, Ftext_property_not_all)
656 (copy_text_properties, text_property_list, extend_property_ranges)
657 (verify_interval_modification):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 (Fnext_single_char_property_change)
660 (Fprevious_single_char_property_change):
661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
662 (copy_text_properties):
663 Check for integer overflow in index calculation.
664 * undo.c (last_boundary_position, record_point, record_insert)
665 (record_delete, record_marker_adjustment, record_change)
666 (record_property_change):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
670 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
671 (Fx_hide_tip, Fx_file_dialog):
672 * w32menu.c (set_frame_menubar):
673 Use ptrdiff_t, not int, for consistency with rest of code.
674 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
675 (select_window, Fdelete_other_windows_internal)
676 (window_scroll_pixel_based, window_scroll_line_based)
677 (Frecenter, Fset_window_configuration):
678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
679 (Fset_window_hscroll, run_window_configuration_change_hook)
680 (set_window_buffer, temp_output_buffer_show, scroll_command)
681 (Fscroll_other_window, Frecenter):
682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
683 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
684 Don't assume fixnum fits in int.
685 (Fset_window_scroll_bars):
686 Check that fixnums are in proper range for system types.
687 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
688 (string_pos, c_string_pos, number_of_chars, init_iterator)
689 (in_ellipses_for_invisible_text_p, init_from_display_pos)
690 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
691 (compute_display_string_end, handle_face_prop)
692 (face_before_or_after_it_pos, handle_invisible_prop)
693 (handle_display_prop, handle_display_spec, handle_single_display_spec)
694 (display_prop_intangible_p, string_buffer_position_lim)
695 (string_buffer_position, handle_composition_prop, load_overlay_strings)
696 (get_overlay_strings_1, get_overlay_strings)
697 (iterate_out_of_display_property, forward_to_next_line_start)
698 (back_to_previous_visible_line_start, reseat, reseat_to_string)
699 (get_next_display_element, set_iterator_to_next)
700 (get_visually_first_element, compute_stop_pos_backwards)
701 (handle_stop_backwards, next_element_from_buffer)
702 (move_it_in_display_line_to, move_it_in_display_line)
703 (move_it_to, move_it_vertically_backward, move_it_by_lines)
704 (add_to_log, message_dolog, message_log_check_duplicate)
705 (message2, message2_nolog, message3, message3_nolog
706 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
707 (current_message_1, truncate_echo_area, truncate_message_1)
708 (set_message, set_message_1, store_mode_line_noprop)
709 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
710 (text_outside_line_unchanged_p, check_point_in_composition)
711 (reconsider_clip_changes)
712 (redisplay_internal, set_cursor_from_row, try_scrolling)
713 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
714 (redisplay_window, find_last_unchanged_at_beg_row)
715 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
716 (trailing_whitespace_p, find_row_edges, display_line)
717 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
718 (display_mode_element, store_mode_line_string)
719 (pint2str, pint2hrstr, decode_mode_spec)
720 (display_count_lines, display_string, draw_glyphs)
721 (x_produce_glyphs, x_insert_glyphs)
722 (rows_from_pos_range, mouse_face_from_buffer_pos)
723 (fast_find_string_pos, mouse_face_from_string_pos)
724 (note_mode_line_or_margin_highlight, note_mouse_highlight):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (safe_call, init_from_display_pos, handle_fontified_prop)
727 (handle_single_display_spec, load_overlay_strings)
728 (with_echo_area_buffer, setup_echo_area_for_printing)
729 (display_echo_area, echo_area_display)
730 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
731 (update_tool_bar, hscroll_window_tree, redisplay_internal)
732 (redisplay_window, dump_glyph_row, display_mode_line)
733 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
734 (handle_display_spec, display_prop_string_p):
735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
736 (handle_single_display_spec, build_desired_tool_bar_string)
737 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
738 (get_specified_cursor_type):
739 Check that fixnums are in proper range for system types.
740 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
742 Don't assume fixnums fit in int.
743 (compare_overlay_entries):
744 Avoid mishandling comparisons due to subtraction overflow.
745 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
746 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
747 (handle_tool_bar_click):
748 Use int, not unsigned, since we prefer signed and the signedness
750 (get_next_display_element, next_element_from_display_vector):
751 Use int, not EMACS_INT, when int is wide enough.
752 (start_hourglass): Use duration_to_sec_usec to do proper
753 overflow checking on durations.
754 * xfaces.c (Fbitmap_spec_p):
755 Check that fixnums are in proper range for system types.
756 (compare_fonts_by_sort_order):
757 Avoid mishandling comparisons due to subtraction overflow.
758 (Fx_family_fonts, realize_basic_faces):
759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 Don't assume fixnum fits in int.
762 Use SAFE_ALLOCA_LISP, not alloca.
763 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
764 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
765 (face_at_buffer_position, face_for_overlay_string)
766 (face_at_string_position):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
769 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
771 Check that fixnums are in proper range for system types.
772 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
773 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (Fx_change_window_property): Don't assume fixnums fit in int.
776 * xfont.c (xfont_chars_supported):
777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
778 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
779 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 * xml.c (parse_region):
782 * xrdb.c (magic_file_p):
783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
784 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
785 (x_get_local_selection, x_reply_selection_request)
786 (x_handle_selection_request, wait_for_property_change):
787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
788 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
789 short is wide enough.
790 (x_send_client_event): Don't assume fixnum fits in int.
791 * xterm.c (x_x_to_emacs_modifiers):
792 Don't assume EMACS_INT overflows nicely into int.
793 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
795 (handle_one_xevent): NATNUMP can eval its arg twice.
796 (x_connection_closed):
797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
798 * xterm.h: Adjust decls to match defn changes elsewhere.
799 (struct scroll_bar): Use struct vectorlike_header
800 rather than rolling our own approximation.
801 (SCROLL_BAR_VEC_SIZE): Remove; not used.
803 2012-05-25 Glenn Morris <rgm@gnu.org>
805 * lisp.mk (lisp): Update for more files being compiled now.
807 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
809 * lread.c: Remove `read_pure' which makes no difference.
810 (read_pure): Remove var.
811 (unreadpure): Remove function.
812 (readevalloop): Don't call read_list with -1 flag.
813 (read1, read_vector): Don't test read_pure any more.
814 (read_list): Simplify.
816 * fileio.c, character.h: Minor style tweaks.
818 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
820 * window.h (clip_changed): Remove useless declaration.
822 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
824 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
825 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
827 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
830 This directory predates autoconf and is no longer needed nowadays.
831 Move its few remaining bits of functionality to where they're needed.
832 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
833 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
834 * m/template.h: Remove.
835 * Makefile.in (M_FILE): Remove. All uses removed.
836 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
837 * lisp.h (USE_LSB_TAG):
838 * mem-limits.h (EXCEEDS_LISP_PTR):
839 Use VAL_MAX, not VALBITS, in #if.
840 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
841 (EMACS_UINT): Define unconditionally now.
842 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
843 (BITS_PER_EMACS_INT): New constants, replacing
844 what used to be in config.h, but not useful in #if.
845 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
846 define them any more.
847 (VAL_MAX): New macro.
849 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
850 BITS_PER_EMACS_INT, in #if.
851 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
852 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
853 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
854 * s/ms-w32.h (DATA_START):
855 Move here from removed file m/intel386.h.
856 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
857 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
859 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
862 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
863 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
865 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
866 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
867 * textprop.c, tparam.c (NULL): Remove.
868 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
869 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
870 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
871 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
872 * xterm.c (input_signal_count): Assume volatile works.
874 2012-05-21 Ken Brown <kbrown@cornell.edu>
876 * xgselect.c (xg_select): Fix first argument in call to 'select'
879 2012-05-20 Ken Brown <kbrown@cornell.edu>
881 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
882 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
884 2012-05-19 Ken Brown <kbrown@cornell.edu>
886 * xfns.c (x_in_use): Remove `static' qualifier.
887 * xterm.h (x_in_use): Declare.
888 * xgselect.c: Include xterm.h.
889 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
890 and `display_arg' (bug#9754).
892 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
894 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
896 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
897 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
899 2012-05-18 Eli Zaretskii <eliz@gnu.org>
901 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
903 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
904 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
906 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
907 reference to image_cache->refcount.
908 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
910 2012-05-17 Juri Linkov <juri@jurta.org>
912 * search.c (Fword_search_regexp, Fword_search_backward)
913 (Fword_search_forward, Fword_search_backward_lax)
914 (Fword_search_forward_lax): Move functions to isearch.el
915 (bug#10145, bug#11381).
917 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
919 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
921 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
923 * lread.c (init_obarray): Declare Qt and Qnil as special.
925 2012-05-14 Glenn Morris <rgm@gnu.org>
927 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
928 Put "libexec" before "bin", for the sake of init_callproc_1.
930 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
932 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
934 * unexaix.c: Port to more-recent AIX compilers.
935 (report_error, report_error_1, make_hdr, copy_sym)
936 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
937 Make arguments const char *, not char *, to avoid violations of C
938 standard and to fix some AIX warnings reported by Gilles Pion.
940 2012-05-14 Eli Zaretskii <eliz@gnu.org>
942 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
943 already have overlays loaded.
944 (handle_single_display_spec): Before returning without displaying
945 fringe bitmap, synchronize the bidi iterator with the main display
946 iterator, by calling iterate_out_of_display_property.
947 (iterate_out_of_display_property): Detect buffer iteration by
948 testing that it->string is a Lisp string.
949 (get_next_display_element): When the current object is exhausted,
950 and there's something on it->stack, call set_iterator_to_next to
951 proceed with what's on the stack, instead of returning zero.
952 (set_iterator_to_next): If called at the end of a Lisp string,
953 proceed to consider_string_end without incrementing string
954 position. Don't increment display vector index past the end of
955 the display vector. (Bug#11417)
956 (pos_visible_p): Don't report a position visible when move_it_to
957 stopped at the last line of window, which happens to be scanned
958 backwards by the bidi iteration. (Bug#11464)
960 2012-05-14 Eli Zaretskii <eliz@gnu.org>
962 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
963 and right-margin display specs even if the spec is invalid or we
964 are on a TTY, and thus unable to display on the fringes. That's
965 because the text with the property will not be displayed anyway,
966 so we need to signal to the caller that this is a "replacing"
967 display spec. This fixes display when the spec is invalid or we
970 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
972 * unexaix.c (make_hdr): Fix typo in prototype.
973 This bug broke the build on AIX. Problem reported by Gilles Pion.
975 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
977 * keyboard.c (kbd_buffer_get_event): Read special events also in
978 batch mode. (Bug#11415)
980 2012-05-12 Glenn Morris <rgm@gnu.org>
982 * ns.mk: Update for ns_appbindir no longer having trailing "/".
984 2012-05-12 Eli Zaretskii <eliz@gnu.org>
986 * lisp.mk (lisp): Add newcomment.elc.
988 2012-05-12 Glenn Morris <rgm@gnu.org>
990 * Makefile.in (MKDIR_P): New, set by configure.
991 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
993 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
995 Remove unused function hourglass_started.
996 * dispextern.h (hourglass_started):
997 * w32fns.c (hourglass_started):
998 * xdisp.c (hourglass_started): Remove.
1000 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1002 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1003 Update dependencies.
1005 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1007 * xgselect.c (xg_select): Put maxfds+1 into a var.
1008 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1010 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1012 2012-05-10 Dave Abrahams <dave@boostpro.com>
1014 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1015 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1017 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1019 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1020 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1021 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1022 Initialize xd_registered_buses.
1024 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1026 Untag more efficiently if USE_LSB_TAG.
1027 This is based on a proposal by YAMAMOTO Mitsuharu in
1028 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1029 For an admittedly artificial (nth 8000 longlist) benchmark on
1030 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1031 Emacs's overall text size by 1%.
1032 * lisp.h (XUNTAG): New macro.
1033 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1034 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1035 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1036 * eval.c (Fautoload):
1037 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1038 * frame.h (XFRAME): Use XUNTAG.
1040 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1041 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1042 Remove unportable assumptions about print widths of types like
1044 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1045 intptr_t when converting between pointer and integer, to avoid GCC
1046 warnings about wrong width.
1048 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1050 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1051 stack for each reader_thread, instead of defaulting to 8MB
1052 determined by the linker. This avoids failures in creating
1053 subprocesses on Windows 7, see the discussion in this thread:
1054 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1056 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1058 Fix up display of the *Minibuf-0* buffer in the mini window.
1059 * keyboard.c (read_char): Don't clear the echo area if there's no
1061 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1062 contents of *Minibuf-0*) if there's no message displayed in its stead.
1064 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1066 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1069 2012-05-06 Chong Yidong <cyd@gnu.org>
1071 * lisp.mk (lisp): Update.
1073 2012-05-05 Jim Meyering <meyering@redhat.com>
1075 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1077 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1079 * data.c (PUT_ERROR): New macro.
1080 (syms_of_data): Use it. Add new error type `user-error'.
1081 * undo.c (user_error): New function.
1082 (Fprimitive_undo): Use it.
1083 * print.c (print_error_message): Adjust print style for `user-error'.
1084 * keyboard.c (user_error): New function.
1085 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1087 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1089 Do not limit current-time-string to years 1000..9999.
1090 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1091 (Fcurrent_time_string): Support any year that is supported by the
1092 underlying localtime representation. Don't use asctime, as it
1093 has undefined behavior for years outside the range -999..9999.
1095 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1097 Fix race conditions involving setenv, gmtime, localtime, asctime.
1098 Without this fix, interrupts could mess up code that uses these
1099 nonreentrant functions, since setting TZ invalidates existing
1100 tm_zone or tzname values, and since most of these functions return
1101 pointers to static storage.
1102 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1103 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1104 Grow the critical sections to include not just invoking
1105 localtime/gmtime, but also accessing these functions' results
1106 including their tm_zone values if any, and any related TZ setting.
1107 (format_time_string): Last arg is now struct tm *, not struct tm **,
1108 so that the struct tm is saved in the critical section.
1109 All callers changed. Simplify allocation of initial buffer, partly
1110 motivated by the fact that memory allocation needs to be outside
1111 the critical section.
1113 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1115 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1116 with RESET_INTERVAL.
1118 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1119 Remove duplicated buffer name initialization.
1121 2012-05-02 Jim Meyering <jim@meyering.net>
1123 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1125 * xfns.c (x_window): Use xstrdup (Bug#11375).
1127 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1129 * xdisp.c (pos_visible_p): If already at a newline from the
1130 display string before the 'while' loop, don't walk back the glyphs
1131 from it3.glyph_row. Solves assertion violation when the display
1132 string begins with a newline (egg.el). (Bug#11367)
1134 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1136 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1139 2012-05-01 Glenn Morris <rgm@gnu.org>
1141 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1142 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1143 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1144 All were removed before 23.1.
1146 * dispnew.c: Remove HAVE_LIBNCURSES test;
1147 it is always true on relevant platforms.
1149 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1150 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1152 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1154 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1156 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1157 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1160 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1162 Do not avoid creating empty evaporating overlays (Bug#9642).
1163 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1164 That is, do not delete an evaporating overlay if it becomes
1165 empty after its bounds are adjusted to fit within its buffer.
1166 This fix caused other problems, and I'm reverting it until we get
1167 to the bottom of them.
1169 2012-04-27 Chong Yidong <cyd@gnu.org>
1171 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1173 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1175 * xdisp.c (pos_visible_p): If the window start position is beyond
1176 ZV, start the display from buffer beginning. Prevents assertion
1177 violation in init_iterator when the minibuffer window is scrolled
1180 * window.c (window_scroll_pixel_based): Likewise.
1182 2012-04-27 Chong Yidong <cyd@gnu.org>
1184 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1186 2012-04-27 Glenn Morris <rgm@gnu.org>
1188 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1189 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1191 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1193 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1194 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1196 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1198 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1199 display element, check also the underlying string or buffer
1200 character. (Bug#11341)
1202 * w32menu.c: Include w32heap.h.
1203 (add_menu_item): If the call to AppendMenuW (via
1204 unicode_append_menu) fails, disable Unicode menus only if we are
1205 running on Windows 9X/Me.
1207 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1209 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1210 (xgetint): Add missing shift for LSB tags.
1212 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1214 * keyboard.c (read_char): Don't wipe echo area for select window
1215 events: These might get delayed via `mouse-autoselect-window'
1218 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1220 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1221 manipulation of :loaded-from data.
1223 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1225 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1226 now a cons (bug#11311).
1228 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1230 Do not create empty overlays with the evaporate property (Bug#9642).
1231 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1232 if it becomes empty after its bounds are adjusted to fit within
1233 its buffer. Without this fix, in a nonempty buffer (let ((o
1234 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1235 yields an empty overlay that has the evaporate property, which is
1236 not supposed to happen.
1238 Fix minor GTK3 problems found by static checking.
1239 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1240 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1241 (struct _EmacsFixedClass, emacs_fixed_get_type):
1242 Move decls here from emacsgtkfixed.h, since they needn't be public.
1243 (emacs_fixed_get_type): Now static.
1244 (emacs_fixed_class_init): Omit unused local.
1245 (emacs_fixed_child_type): Remove; unused.
1246 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1247 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1248 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1249 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1250 (EMACS_FIXED_GET_CLASS): Remove; unused.
1251 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1253 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1254 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1256 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1258 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1259 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1260 (__malloc_size_t, __malloc_ptrdiff_t):
1261 Remove. All uses removed, replaced by the definiens if needed,
1262 since we can assume C89 or better now.
1263 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1264 (protect_malloc_state, align, get_contiguous_space)
1265 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1266 (malloc_atfork_handler_child, malloc_enable_thread)
1267 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1268 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1269 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1270 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1271 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1272 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1273 Define using prototypes, not old style.
1274 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1275 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1276 (align): Don't assume that signed integer overflow wraps around.
1277 Omit unused local var.
1278 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1279 (_free_internal_nolock, memalign, mallochook, reallochook):
1280 Omit no-longer-needed casts.
1281 (valloc): Use getpagesize, not __getpagesize.
1282 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1283 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1285 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1287 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1289 Move functions from C to Lisp. Make non-blocking method calls
1290 the default. Implement further D-Bus standard interfaces.
1292 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1293 (QCdbus_request_name_allow_replacement)
1294 (QCdbus_request_name_replace_existing)
1295 (QCdbus_request_name_do_not_queue)
1296 (QCdbus_request_name_reply_primary_owner)
1297 (QCdbus_request_name_reply_in_queue)
1298 (QCdbus_request_name_reply_exists)
1299 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1300 (QCdbus_registered_serial, QCdbus_registered_method)
1301 (QCdbus_registered_signal): New Lisp objects.
1302 (XD_DEBUG_MESSAGE): Use sizeof.
1303 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1304 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1305 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1306 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1307 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1308 (xd_signature, xd_append_arg): Allow float for integer types.
1309 (xd_get_connection_references): New function.
1310 (xd_get_connection_address): Rename from xd_initialize.
1311 Return cached address.
1312 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1313 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1315 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1316 Return number of refcounts.
1317 (Fdbus_get_unique_name): Make stronger parameter check.
1318 (Fdbus_message_internal): New defun.
1319 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1320 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1321 (Fdbus_send_signal, Fdbus_register_service)
1322 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1323 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1324 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1325 (Vdbus_compiled_version, Vdbus_runtime_version)
1326 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1327 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1328 (Vdbus_message_type_signal): New defvars.
1329 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1332 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1334 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1335 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1336 Do not assume ptrdiff_t is the same width as 'int'.
1338 * alloc.c: Handle unusual debugging option combinations.
1339 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1340 since the two debugging options are incompatible.
1341 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1343 (mem_init, mem_insert, mem_insert_fixup):
1344 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1345 (NEED_MEM_INSERT): Remove; no longer needed.
1347 2012-04-22 Leo Liu <sdl.web@gmail.com>
1349 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1351 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1353 * sysdep.c [__FreeBSD__]: Minor cleanups.
1354 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1355 Use Emacs indenting style more consistently. Avoid some casts.
1356 Use 'double' consistently rather than mixing 'float' and 'double'.
1358 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1360 * sysdep.c (list_system_processes, system_process_attributes):
1361 Add implementation for FreeBSD (Bug#5243).
1363 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1365 * lisp.mk (lisp): Update.
1367 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1369 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1370 It is never used otherwise.
1372 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1374 * print.c (print_preprocess): Only check print_depth if print-circle
1376 (print_object): Check for cycles even when print-circle is nil and
1377 print-gensym is t, but only check print_depth if print-circle is nil.
1379 2012-04-20 Chong Yidong <cyd@gnu.org>
1381 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1382 set the status to "failed" and ensure that sentinel is run.
1384 2012-04-20 Glenn Morris <rgm@gnu.org>
1386 * process.c (Fset_process_inherit_coding_system_flag)
1387 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1388 (Fmake_network_process, Fmake_serial_process): Doc fix.
1390 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1392 * xdisp.c (string_buffer_position_lim): Limit starting position to
1394 (set_cursor_from_row): If called for a mode-line or header-line
1395 row, return zero immediately.
1396 (try_cursor_movement): If inside continuation line, don't back up
1397 farther than the first row after the header line, if any.
1398 Don't consider the header-line row as "partially visible", even if
1399 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1401 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1403 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1406 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1407 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1409 configure: new option --enable-gcc-warnings (Bug#11207)
1410 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1411 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1412 (ALL_CFLAGS): Use new macros rather than old.
1413 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1414 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1415 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1416 -Wunused-result, -Wunused-variable. This should go away once
1417 the Emacs and Gnulib regex code is merged.
1418 (xmalloc, xrealloc): Now static.
1420 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1422 * dired.c (Fsystem_groups): Remove unused local.
1424 2012-04-17 Glenn Morris <rgm@gnu.org>
1426 * dired.c (Fsystem_users): Doc fix.
1428 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1430 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1431 (syms_of_dired): Add them.
1433 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1435 Fix minor alloc.c problems found by static checking.
1436 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1437 New extern decls, to avoid calling undeclared functions.
1438 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1439 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1440 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1441 (NEED_MEM_INSERT): New macro.
1442 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1443 Remove one incorrect comment and fix another.
1445 Fix minor ralloc.c problems found by static checking.
1446 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1447 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1448 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1449 (r_alloc_sbrk): Now static.
1451 Improve ralloc.c interface checking.
1452 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1453 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1454 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1455 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1456 [REL_ALLOC]: ... to here, to check interface.
1457 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1458 Remove decls. This fixes an "It stinks!".
1460 * alloc.c (which_symbols): Fix alignment issue / type clash.
1462 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1464 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1465 (struct Lisp_Misc_Any): Likewise.
1466 (struct Lisp_Free): Likewise.
1467 * alloc.c (union aligned_Lisp_Symbol): Define.
1468 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1469 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1470 (union aligned_Lisp_Misc): Define.
1471 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1472 aligned_Lisp_Misc instead of union Lisp_Misc.
1473 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1475 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1477 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1478 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1479 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1480 * s/netbsd.h, s/sol2-6.h:
1481 Remove definition of GC_MARK_STACK, since the default now works.
1482 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1483 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1484 no longer the default.
1485 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1487 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1489 * lread.c (lisp_file_lexically_bound_p):
1490 Fix hang at ";-*-\n" (bug#11238).
1492 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1494 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1495 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1497 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1499 * nsterm.m (constrainFrameRect): Always constrain when there is only
1500 one screen (Bug#10962).
1502 2012-04-13 Ken Brown <kbrown@cornell.edu>
1504 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1506 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1508 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1510 2012-04-11 Daniel Colascione <dancol@dancol.org>
1512 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1513 against is gone. It's better to use vfork now so that when Cygwin
1514 gains a new, working vfork, we use it automatically (bug#10398).
1516 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1518 * window.c (save_window_save): Obey window-point-insertion-type.
1520 2012-04-11 Glenn Morris <rgm@gnu.org>
1522 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1524 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1526 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1528 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1530 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1531 (force_quit_count): New var.
1532 (handle_interrupt): Use it.
1534 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1536 * w32.c (w32_delayed_load): Record the full path of the library
1537 being loaded (bug#10424).
1539 2012-04-09 Glenn Morris <rgm@gnu.org>
1541 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1542 not just in the obarray, before snarfing them. (Bug#11036)
1544 * Makefile.in ($(leimdir)/leim-list.el):
1545 Pass EMACS rather than BUILT_EMACS.
1547 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1549 * process.c (make_process):
1550 * process.h: Add integer `gnutls_handshakes_tried' member to
1553 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1554 Add convenience `GNUTLS_LOG2i' macro.
1556 * gnutls.c (gnutls_log_function2i): Convenience log function.
1557 (emacs_gnutls_read): Use new log functions,
1558 `gnutls_handshakes_tried' process member, and
1559 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1560 attempts per process (connection).
1562 2012-04-09 Chong Yidong <cyd@gnu.org>
1564 * eval.c (Fuser_variable_p, user_variable_p_eh)
1565 (lisp_indirect_variable): Functions deleted.
1566 (Fdefvar): Caller changed.
1568 * callint.c (Finteractive, Fcall_interactively):
1569 * minibuf.c (Fread_variable): Callers changed.
1571 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1573 * xdisp.c (set_cursor_from_row): If the display string appears in
1574 the buffer at position that is closer to point than the position
1575 after the display string, display the cursor on the first glyph of
1576 the display string. Fixes cursor display when a 'display' text
1577 property immediately follows invisible text. (Bug#11094)
1579 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1581 composite.c: use 'double' consistently
1582 * composite.c (get_composition_id): Use 'double' consistently
1583 instead of converting 'float' to 'double' and vice versa; this is
1584 easier to understand and avoids a GCC warning.
1586 2012-04-09 Glenn Morris <rgm@gnu.org>
1588 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1589 preparation for dumping it with emacs. (Bug#4789)
1590 (leimdir): New variable.
1591 ($(leimdir)/leim-list.el): New rule.
1592 (emacs$(EXEEXT)): Depend on leim-list.el.
1594 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1595 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1596 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1598 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1600 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1603 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1605 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1606 Remove unused local variable.
1608 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1610 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1611 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1612 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1613 objects, as mark_maybe_pointer will catch them otherwise.
1614 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1615 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1617 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1619 Fix typo that broke non-Windows builds.
1620 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1622 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1624 Support building on MS-Windows with libxml2.
1626 * makefile.w32-in (OBJ2): Add xml.$(O).
1627 (GLOBAL_SOURCES): Add xml.c.
1628 ($(BLD)/xml.$(O)): New dependency list.
1630 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1631 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1632 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1633 [!WINDOWSNT]: New macros.
1634 (init_libxml2_functions, libxml2_loaded_p): New functions.
1635 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1636 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1637 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1638 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1640 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1641 Call init_libxml2_functions before calling libxml2 functions.
1642 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1644 * emacs.c: Don't include libxml/parser.h.
1645 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1646 xmlCleanupParser directly.
1648 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1650 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1652 * indent.c (Fvertical_motion): If there is a display string at
1653 point, use it.vpos to compute how many lines to backtrack after
1654 move_it_to point. (Bug#11133)
1656 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1658 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1659 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1660 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1661 macros related to unification of CJK characters. For the details,
1662 see the discussion following the message here:
1663 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1665 2012-04-04 Chong Yidong <cyd@gnu.org>
1667 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1669 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1671 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1672 instead of alloca. (Bug#11138)
1674 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1676 * w32menu.c (is_simple_dialog): Properly check lisp types.
1679 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1681 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1682 position we get to after a call to move_it_to fails the
1683 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1684 only if we wind up in a string from display property. (Bug#11063)
1686 * window.c (Fdelete_other_windows_internal): Invalidate the row
1687 and column information about mouse highlight, so that redisplay
1688 restores it after reallocating the glyph matrices. (Bug#7464)
1690 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1691 string comes from a `display' text property, use the buffer
1692 position of that property as if we actually saw that position in
1694 (move_it_by_lines): Remove the assertion that
1695 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1696 violated when there's a before-string at the beginning of a line.
1699 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1701 * xdisp.c (append_space_for_newline): If the default face was
1702 remapped, use the remapped face for the appended newline.
1703 (extend_face_to_end_of_line): Use the remapped default face for
1704 extending the face to the end of the line.
1705 (display_line): Call extend_face_to_end_of_line when the default
1706 face was remapped. (Bug#11068)
1708 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1710 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1712 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1714 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1716 2012-03-27 Glenn Morris <rgm@gnu.org>
1718 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1721 2012-03-26 Kenichi Handa <handa@m17n.org>
1723 * dispextern.h (struct glyph): Fix previous change. Change the
1724 bit length of glyphless.ch to 25 (Bug#11082).
1726 2012-03-26 Chong Yidong <cyd@gnu.org>
1728 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1729 (command_loop_1): Use it; inhibit selection update for
1730 handle-select-window too (Bug#8996).
1732 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1734 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1736 2012-03-25 Kenichi Handa <handa@m17n.org>
1738 * dispextern.h (struct glyph): Change the bit length of
1739 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1741 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1743 * s/ms-w32.h (tzname): Include time.h before redirecting to
1744 _tzname. Fixes the MSVC build. (Bug#9960)
1746 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1748 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1751 * xterm.c (XTread_socket): Only modify handling_signal if
1752 !SYNC_INPUT. (Bug#11080)
1754 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1756 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1757 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1758 when fetching a multibyte character consumes more bytes than
1759 CHAR_BYTES returns, due to unification of CJK characters in
1760 string_char. (Bug#11073)
1762 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1764 * process.c (wait_reading_process_output): Handle pty disconnect
1765 by refraining from sending oneself a SIGCHLD (bug#10933).
1767 2012-03-22 Chong Yidong <cyd@gnu.org>
1769 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1771 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1772 Mark string as coming from a prefix property.
1773 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1774 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1776 2012-03-21 Chong Yidong <cyd@gnu.org>
1778 * xfaces.c (Vface_remapping_alist): Doc fix.
1780 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1782 * w32proc.c (Fw32_set_console_codepage)
1783 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1786 2012-03-20 Chong Yidong <cyd@gnu.org>
1788 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1789 to reflect default non-nil value of redisplay-dont-pause.
1791 2012-03-19 Kenichi Handa <handa@m17n.org>
1793 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1794 it fit in a valid range (Bug#11003).
1796 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1798 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1799 that is not from display property, accept the row as a "cursor
1800 row" if one of the string's character has a non-nil `cursor'
1801 property. Fixes cursor positioning when there are newlines in
1802 overlay strings, e.g. in icomplete.el. (Bug#11035)
1804 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1806 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1808 2012-03-12 Chong Yidong <cyd@gnu.org>
1810 * eval.c (inhibit_lisp_code): Rename from
1811 inhibit_window_configuration_change_hook; move from window.c.
1813 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1814 * window.c (run_window_configuration_change_hook)
1815 (syms_of_window): Callers changed.
1817 2012-03-11 Chong Yidong <cyd@gnu.org>
1819 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1821 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1823 2012-03-10 Chong Yidong <cyd@gnu.org>
1825 * frame.c (other_visible_frames): Don't assume the selected frame
1826 is visible (Bug#10955).
1828 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1830 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1832 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1834 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1835 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1838 2012-03-03 Glenn Morris <rgm@gnu.org>
1840 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1842 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1844 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1845 position past the first glyph_row that ends at ZV. (Bug#10902)
1846 (redisplay_window, next_element_from_string): Fix typos in
1848 (redisplay_window): Pass to move_it_vertically the margin in
1849 pixels, not in screen lines.
1851 2012-03-02 Glenn Morris <rgm@gnu.org>
1853 * buffer.c (buffer-list-update-hook): Doc fix.
1855 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1858 push_it before setting up the iterator for the first overlay
1859 string, even if we have an empty string loaded.
1860 (next_overlay_string): If there's an empty string on the iterator
1861 stack, pop the stack. (Bug#10903)
1863 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1865 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1866 Suggested by Stefan Monnier in
1867 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1868 * alloc.c (widen_to_Lisp_Object): New static function.
1869 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1870 and widening them to Lisp_Objects. This would work even if
1871 USE_LSB_TAG is defined and wide integers are used, which might
1872 happen in a future version of Emacs.
1874 2012-02-25 Chong Yidong <cyd@gnu.org>
1876 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1879 * xselect.c (Fx_selection_exists_p): Doc fix.
1880 (x_clipboard_manager_save_all): Print an informative message
1881 before saving to clipboard manager.
1883 2012-02-24 Chong Yidong <cyd@gnu.org>
1885 * keyboard.c (process_special_events): Handle all X selection
1886 requests in kbd_buffer, not just the next one (Bug#8869).
1888 2012-02-23 Chong Yidong <cyd@gnu.org>
1890 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1891 call when setting menu-bar-lines and tool-bar-lines parameters.
1892 (unwind_create_frame_1): New helper function.
1894 * window.c (inhibit_window_configuration_change_hook): New var.
1895 (run_window_configuration_change_hook): Obey it.
1896 (syms_of_window): Initialize it.
1898 2012-02-22 Chong Yidong <cyd@gnu.org>
1900 * xterm.c (x_draw_image_relief): Add missing type check for
1901 Vtool_bar_button_margin (Bug#10743).
1903 2012-02-21 Chong Yidong <cyd@gnu.org>
1905 * fileio.c (Vfile_name_handler_alist): Doc fix.
1907 * buffer.c (Fget_file_buffer): Protect against invalid file
1908 handler return value.
1910 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1912 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1913 when computing $valmask.
1915 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1916 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1917 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1918 It's useless in that case, and it can cause problems on hosts
1919 that allocate halves of EMACS_INT values separately.
1920 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1921 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1922 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1923 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1924 it avoids undefined behavior on hosts where shifting right by more
1925 than the word width has undefined behavior.
1927 2012-02-19 Chong Yidong <cyd@gnu.org>
1929 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1930 (Funhandled_file_name_directory, Ffile_name_as_directory)
1931 (Fdirectory_file_name, Fexpand_file_name)
1932 (Fsubstitute_in_file_name): Protect against invalid file handler
1933 return values (Bug#10845).
1935 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1937 * .gdbinit (pitx): Fix incorrect references to fields of the
1940 2012-02-17 Chong Yidong <cyd@gnu.org>
1942 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1944 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1946 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1947 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1949 2012-02-15 Chong Yidong <cyd@gnu.org>
1951 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1952 marked as special. Also, starting docstrings with * is obsolete.
1954 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1956 * gnutls.c (emacs_gnutls_write): Fix last change.
1958 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1960 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1963 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1965 * keymap.c (Fsingle_key_description): Handle char ranges.
1967 2012-02-12 Chong Yidong <cyd@gnu.org>
1969 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1970 as that creates a dangerous corner case.
1972 * window.c (Fdelete_window_internal): Invalidate the mouse
1973 highlight (Bug#9904).
1975 2012-02-12 Glenn Morris <rgm@gnu.org>
1977 * xselect.c (Fx_own_selection_internal)
1978 (Fx_get_selection_internal, Fx_disown_selection_internal)
1979 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1980 * nsselect.m (Fx_own_selection_internal)
1981 (Fx_disown_selection_internal, Fx_selection_exists_p)
1982 (Fx_selection_owner_p, Fx_get_selection_internal):
1983 Sync docs and argument specs with the xselect.c versions.
1985 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1987 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1989 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1991 * w32select.c (Fx_selection_exists_p): Sync doc string and
1992 argument list with xselect.c. (Bug#10783)
1994 * w16select.c (Fx_selection_exists_p): Sync doc string and
1995 argument list with xselect.c. (Bug#10783)
1997 2012-02-10 Glenn Morris <rgm@gnu.org>
1999 * fns.c (Fsecure_hash): Doc fix.
2001 2012-02-09 Kenichi Handa <handa@m17n.org>
2003 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2005 2012-02-07 Chong Yidong <cyd@gnu.org>
2007 * buffer.c (Fbuffer_local_variables)
2008 (buffer_lisp_local_variables): Handle unbound vars correctly;
2009 don't let Qunbound leak into Lisp.
2011 2012-02-07 Glenn Morris <rgm@gnu.org>
2013 * image.c (Fimagemagick_types): Doc fix.
2015 * image.c (imagemagick-render-type): Change it from a lisp object
2016 to an integer. Move the doc here from the lisp manual.
2017 Treat all values not equal to 0 the same.
2019 2012-02-06 Chong Yidong <cyd@gnu.org>
2021 * doc.c (store_function_docstring): Avoid applying docstring of
2022 alias to base function (Bug#2603).
2024 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2026 * .gdbinit (pp1, pv1): Remove redundant defines.
2029 2012-02-04 Chong Yidong <cyd@gnu.org>
2031 * nsterm.m: Declare a global (Bug#10694).
2033 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2035 * w32.c (get_emacs_configuration_options):
2036 Include --enable-checking, if specified, in the return value.
2038 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2040 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2041 after rounding frame sizes. (Bug#9723)
2043 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2045 * keyboard.c (adjust_point_for_property): Don't position point
2046 before BEGV. (Bug#10696)
2048 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2050 Handle overflow when computing char display width (Bug#9496).
2051 * character.c (char_width): Return EMACS_INT, not int.
2052 (char_width, c_string_width): Check for overflow when
2053 computing the width; this is possible now that individual
2054 characters can have unbounded width. Problem introduced
2055 by merge from Emacs 23 on 2012-01-19.
2057 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2059 * dbusbind.c (Fdbus_register_method): Mention the return value
2060 :ignore in the docstring.
2062 2012-02-02 Glenn Morris <rgm@gnu.org>
2064 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2066 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2067 Unconditionally set to t. (Bug#10673)
2068 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2069 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2070 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2072 2012-02-02 Kenichi Handa <handa@m17n.org>
2074 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2075 0, do not call append_composite_glyph.
2077 2012-02-02 Kenichi Handa <handa@m17n.org>
2079 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2081 (x_produce_glyphs): If the component of a composition is a null
2082 string, set it->pixel_width to 1 to avoid zero-width glyph.
2084 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2086 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2087 first 2 arguments are identical. This makes inserting large
2088 output from a subprocess an order of magnitude faster on
2089 MS-Windows, where all sbrk'ed memory is always contiguous.
2091 2012-01-31 Glenn Morris <rgm@gnu.org>
2093 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2094 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2095 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2097 2012-01-29 Glenn Morris <rgm@gnu.org>
2099 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2101 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2103 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2105 2012-01-28 Chong Yidong <cyd@gnu.org>
2107 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2109 2012-01-26 Chong Yidong <cyd@gnu.org>
2111 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2113 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2114 repeat counts (Bug#10507).
2116 2012-01-26 Glenn Morris <rgm@gnu.org>
2118 * lread.c (syms_of_lread): Doc fix.
2120 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2122 * coding.c (encode_designation_at_bol): Change return value to
2125 2012-01-25 Chong Yidong <cyd@gnu.org>
2127 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2129 2012-01-21 Chong Yidong <cyd@gnu.org>
2131 * floatfns.c (Fcopysign): Make the second argument non-optional,
2132 since nil is not allowed anyway.
2134 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2136 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2137 (send_process): Likewise.
2139 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2141 * window.c (save_window_save, Fcurrent_window_configuration)
2142 (Vwindow_persistent_parameters): Do not use Qstate.
2143 Rewrite doc-strings.
2145 2012-01-19 Kenichi Handa <handa@m17n.org>
2147 * character.c (char_width): New function.
2148 (Fchar_width, c_string_width, lisp_string_width):
2149 Use char_width (Bug#9496).
2151 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2153 * window.c (Vwindow_persistent_parameters): New variable.
2154 (Fset_window_configuration, save_window_save): Handle persistent
2157 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2159 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2160 thrashing the stack of the thread. (Bug#9087)
2162 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2164 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2166 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (rows_from_pos_range): Handle the case where the
2169 highlight ends on a newline. (Bug#10464)
2170 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2171 he end column for display of highlight that ends on a newline
2174 2012-01-11 Glenn Morris <rgm@gnu.org>
2176 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2177 from load-path also when installation-directory is nil. (Bug#10208)
2179 2012-01-10 Glenn Morris <rgm@gnu.org>
2181 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2183 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2184 Update template values to be closer to their typical values these days.
2186 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2188 * xdisp.c (rows_from_pos_range): Accept additional argument
2189 DISP_STRING, and accept any glyph in a row whose object is that
2190 string as eligible for mouse highlight. Fixes mouse highlight of
2191 display strings from overlays. (Bug#10464)
2193 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2195 emacs: fix an auto-save permissions race condition (Bug#10400)
2196 * fileio.c (auto_saving_dir_umask): New static var.
2197 (Fmake_directory_internal): Use it.
2198 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2199 creating the directory. The old code temporarily assigns
2200 too-generous permissions to the directory.
2201 (do_auto_save_eh): Clear it.
2202 (Fdo_auto_save): Catch all errors, not just file errors, so
2203 that the var is always cleared.
2205 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2207 * search.c (scan_buffer): Pass character positions to
2208 know_region_cache, not byte positions. (Bug#6540)
2210 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2212 * w32.c (sys_rename): Report EXDEV when rename of a directory
2213 fails because the target is on another logical disk. (Bug#10284)
2215 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2217 * xterm.c (x_embed_request_focus): New function.
2219 * xterm.h: Add prototype.
2221 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2223 2012-01-05 Glenn Morris <rgm@gnu.org>
2225 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2227 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2229 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2230 Load gnutls_transport_set_lowat only if GnuTLS version is below
2232 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2233 GnuTLS versions below 2.11.1.
2235 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2237 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2238 to the doc string advising against its use for altering the way
2239 windows are scrolled.
2241 2011-12-28 Kenichi Handa <handa@m17n.org>
2243 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2244 coding-system ASCII compatible only when it does not produce BOM
2245 on encoding (Bug#10383).
2247 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2249 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2251 (create_and_show_popup_menu): Always use menu_position_func for
2254 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2256 * callint.c (Fcall_interactively): Don't truncate prompt string.
2258 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2261 property that ends at ZV, so that the bidi iteration could be
2262 resumed from there (after widening). (Bug#10360)
2264 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2266 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2268 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2270 * nsterm.m (x_free_frame_resources):
2271 Release f->output_data.ns->miniimage.
2272 (ns_index_color): Fix indentation. Do not retain
2273 color_table->colors[i].
2275 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2278 * nsfns.m (x_set_background_color): Assign return value from
2279 ns_index_color to face-background instead of NSColor*.
2280 (ns_implicitly_set_icon_type): Fix indentation.
2281 Change assignment in for loop to comparison.
2283 * emacs.c (ns_pool): New variable.
2284 (main): Assign ns_pool.
2285 (Fkill_emacs): Call ns_release_autorelease_pool.
2287 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2288 autorelease fdesc, release fdAttrs and tdict.
2289 (ns_get_covering_families): Release charset.
2290 (ns_findfonts): Release NSFontDescriptor created with new.
2291 (ns_uni_to_glyphs): Fix indentation.
2292 (setString): Release attrStr before assigning new value.
2294 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2296 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2298 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2299 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2301 2011-12-18 David Reitter <reitter@cmu.edu>
2303 * nsterm.m (ns_term_init): Subscribe for notifications
2304 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2305 to method trackingNotification in EmacsMenu.
2307 * nsmenu.m (trackingMenu): New variable.
2308 (trackingNotification): New method (from Aquamacs).
2309 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2310 from Aquamacs (Bug#7030).
2312 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2314 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2315 (symbol_to_nsstring): Fix indentation.
2316 (ns_symbol_to_pb): New function.
2317 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2318 (Fns_rotate_cut_buffers_internal): Remove.
2319 (Fns_store_selection_internal): Rename from
2320 Fns_store_cut_buffer_internal.
2321 (ns_get_foreign_selection, Fx_own_selection_internal)
2322 (Fx_disown_selection_internal, Fx_selection_exists_p)
2323 (Fns_get_selection_internal, Fns_store_selection_internal):
2324 Use ns_symbol_to_pb and check if return value is nil.
2325 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2326 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2327 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2328 renamed to Sns_store_selection_internal.
2329 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2330 and remove this function.
2331 (ns_handle_selection_clear): Remove, never used.
2332 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2335 2011-12-17 Ken Brown <kbrown@cornell.edu>
2337 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2338 GID is unknown (Bug#10257).
2340 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2342 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2343 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2344 which caused a build failure on GNU/Linux IA-64. This problem was
2345 introduced by my 2011-10-07 patch.
2347 2011-12-15 Juri Linkov <juri@jurta.org>
2349 * image.c (imagemagick_error): New function. (Bug#10112)
2350 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2351 Use `imagemagick_error' where ImageMagick functions return
2353 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2356 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2358 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2359 fill background (Bug#8992).
2361 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2363 * window.c (Vwindow_combination_resize)
2364 (Vwindow_combination_limit): Use t instead of non-nil in
2366 (Vrecenter_redisplay): Add first sentence of doc-string on
2368 (Frecenter): Fix doc-string typo.
2370 2011-12-11 Kenichi Handa <handa@m17n.org>
2372 * coding.c (Funencodable_char_position): Pay attention to the
2373 buffer text relocation (Bug#9389).
2375 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2377 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2378 gtk_init (Bug#10100).
2380 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2382 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2383 IT->string is nil. (Bug#10263)
2385 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2387 * nsterm.h (x_free_frame_resources): Declare.
2389 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2390 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2392 * nsterm.h (ns_get_defaults_value): Declare.
2394 * nsterm.m (ns_default): Call ns_get_defaults_value.
2396 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2398 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2401 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2403 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2404 that where the value of an _OBJC_* symbol points to is in the .bss
2405 section (Bug#10240).
2407 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2409 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2410 after the loop to call ccl_driver at least once (Bug#8619).
2412 2011-12-08 Kenichi Handa <handa@m17n.org>
2414 * ftfont.c (get_adstyle_property): Fix previous change
2417 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2419 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2420 dirs from the default value of EMACSLOADPATH (bug#10208).
2422 2011-12-07 Glenn Morris <rgm@gnu.org>
2424 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2425 installation and source directories as well. (Bug#10208)
2427 2011-12-06 Chong Yidong <cyd@gnu.org>
2429 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2431 2011-12-06 Glenn Morris <rgm@gnu.org>
2433 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2434 as an error, not just -1. (Bug#10217)
2436 2011-12-05 Chong Yidong <cyd@gnu.org>
2438 * keyboard.c (process_special_events): New function.
2439 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2441 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2443 * coding.c (encode_designation_at_bol): Don't use uninitialized
2444 local variable (Bug#9318).
2446 2011-12-05 Kenichi Handa <handa@m17n.org>
2448 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2449 return Qnil (Bug#8046, Bug#10193).
2451 2011-12-05 Kenichi Handa <handa@m17n.org>
2453 * coding.c (encode_designation_at_bol): New args charbuf_end and
2454 dst. Return the number of produced bytes. Callers changed.
2455 (coding_set_source): Return how many bytes coding->source was
2457 (coding_set_destination): Return how many bytes
2458 coding->destination was relocated.
2459 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2460 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2462 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2464 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2465 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2468 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2470 The following changes are to fix Bug#9318.
2472 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2473 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2474 (encode_coding_iso_2022, encode_coding_sjis)
2475 (encode_coding_big5, encode_coding_charset): Use the above macros.
2477 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2479 * lisp.h (process_quit_flag): Fix external declaration.
2481 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2483 Don't macro-inline non-performance-critical code.
2484 * eval.c (process_quit_flag): New function.
2485 * lisp.h (QUIT): Use it.
2487 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2489 * nsfns.m (get_geometry_from_preferences): New function.
2490 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2492 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2494 * emacs.c (Qkill_emacs): Define.
2495 (syms_of_emacs): Initialize it.
2496 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2497 Qquit_flag to `kill-emacs' instead.
2498 (quit_throw_to_read_char): Add parameter `from_signal'.
2499 All callers changed. Call Fkill_emacs if requested and safe.
2500 * lisp.h (QUIT): Call Fkill_emacs if requested.
2502 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2504 * widget.c (update_wm_hints): Return if wmshell is null.
2505 (widget_update_wm_size_hints): New function.
2507 * widget.h (widget_update_wm_size_hints): Declare.
2509 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2510 widget_update_wm_size_hints (Bug#10104).
2512 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2514 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2515 before a newline, prepare the bidi iterator for consuming the
2516 newline, and keep the current paragraph direction. (Bug#10183)
2517 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2519 2011-12-02 Juri Linkov <juri@jurta.org>
2521 * search.c (Fword_search_regexp): New Lisp function created from
2522 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2523 (Fword_search_backward, Fword_search_forward)
2524 (Fword_search_backward_lax, Fword_search_forward_lax):
2525 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2526 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2528 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2530 * fileio.c (Finsert_file_contents): Move after-change-function call
2531 to before the "handled:" label, since all "goto handled" appear in
2532 cases where the *-change-functions have already been properly called
2535 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2537 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2538 waiting for input. (Bug#10169)
2540 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2542 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2543 verifies glyph row's hash code--we have just reallocated the
2544 glyphs, so their contents can be complete garbage. (Bug#10164)
2546 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2548 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2550 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2552 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2553 attributes are tested _before_ calling verify_row_hash, to protect
2554 against GCC re-ordering of the tests. (Bug#10164)
2556 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2558 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2560 * xterm.c (handle_one_xevent): Only set async_visible and friends
2561 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2562 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2563 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2565 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2567 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2568 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2569 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2570 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2571 All uses changed to use GCPRO1 etc.
2572 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2573 Revert to old implementation (i.e., before 2011-03-11).
2575 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2577 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2578 of scroll runs so as to avoid assigning disabled bogus rows and
2579 unnecessary graphics copy operations.
2581 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2583 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2584 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2585 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2586 (malloc, free, realloc, calloc): Redirect to e_* only when
2589 * lisp.h (GCTYPEBITS): Move before first use.
2590 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2591 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2592 this macro definition.
2594 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2597 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2599 * gtkutil.c (xg_create_frame_widgets):
2600 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2601 present with Gtk+ 2.0.
2603 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2605 * fileio.c (Finsert_file_contents): Undo previous change; see
2606 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2608 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2610 Rename locals to avoid shadowing.
2611 * fileio.c (Finsert_file_contents):
2612 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2613 * process.c (wait_reading_process_output):
2614 Rename inner 'proc' to 'p' to avoid shadowing.
2615 Indent for consistency with usual Emacs style.
2617 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2619 * xdisp.c (redisplay_window): If cursor row is not fully visible
2620 after recentering, and scroll-conservatively is set to a large
2621 number, scroll window by a few more lines to make the cursor fully
2622 visible and out of scroll-margin. (Bug#10105)
2623 (start_display): Don't move to the next line if the display should
2624 start at a newline that is part of a display vector or an overlay
2627 2011-11-24 Juri Linkov <juri@jurta.org>
2629 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2630 after the `MagickPingImage' call. (Bug#10112)
2632 2011-11-23 Chong Yidong <cyd@gnu.org>
2634 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2636 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2638 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2639 making another buffer current. (Bug#10114)
2641 2011-11-23 Glenn Morris <rgm@gnu.org>
2643 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2645 2011-11-23 Chong Yidong <cyd@gnu.org>
2647 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2648 using it (Bug#5984).
2650 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2652 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2653 and header-lines, as they don't have one computed for them.
2656 * .gdbinit (prow): Make displayed values more self-explaining.
2657 Add row's hash code.
2659 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2661 * process.c (wait_reading_process_output): Fix asynchrounous
2662 GnuTLS socket handling on some versions of the GnuTLS library.
2663 (wait_reading_process_output): Add comment and URL.
2665 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2667 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2669 2011-11-21 Chong Yidong <cyd@gnu.org>
2671 * window.c (Fnext_window, Fprevious_window): Doc fix.
2673 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2675 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2677 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2679 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2681 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2683 * window.c (Fset_window_combination_limit): Rename argument
2685 (Vwindow_combination_limit): Remove "status" from doc-string.
2687 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2689 * m/ibms390.h: Remove.
2690 * m/ibms390x.h: Don't include "ibms390.h".
2692 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2694 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2695 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2697 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2699 * casetab.c (Fset_case_table):
2700 * charset.c (Fcharset_after): Fix typos.
2702 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2704 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2705 Otherwise, valgrind does not work on some platforms.
2706 Problem reported by Andreas Schwab in
2707 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2708 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2709 is set, removing the need for VIRT_ADDRESS_VARIES.
2710 (PURE_P): Use a more-efficient implementation that needs just one
2711 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2712 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2713 to 4 (xorl, subq, cmpq, setbe).
2714 * alloc.c (pure): Always extern now, since that's the
2715 VIRT_ADDR_VARIES behavior.
2716 (PURE_POINTER_P): Use a single comparison, not two, for
2717 consistency with the new puresize.h.
2718 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2719 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2720 Remove VIRT_ADDR_VARIES no longer needed.
2722 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2724 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2725 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2726 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2727 behave as if the cursor position were at the window margin.
2729 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2730 and the cursor position is out of bounds, behave as if the cursor
2731 position were at the window margin. (Bug#10075)
2733 2011-11-18 Chong Yidong <cyd@gnu.org>
2735 * window.c (Fwindow_combination_limit): Make first argument
2736 non-optional, since it is meaningless for live windows like the
2739 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2741 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2743 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2745 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2746 (graft_intervals_into_buffer): Simplify.
2748 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2750 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2751 hash values of the two rows.
2752 (copy_row_except_pointers): Preserve the used[] arrays and the
2753 hash values of the two rows. (Bug#10035)
2754 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2756 * xdisp.c (row_hash): New function, body extracted from
2757 compute_line_metrics.
2758 (compute_line_metrics): Call row_hash, instead of computing the
2761 * dispnew.c (verify_row_hash): Call row_hash for computing the
2762 hash code of a row, instead of duplicating code from xdisp.c.
2764 * dispextern.h (row_hash): Add prototype.
2766 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2768 * frame.c (delete_frame): Don't delete the terminal when the last
2769 X frame is closed if emacs is built with GTK toolkit.
2771 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2773 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2775 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2777 * window.c (Vwindow_splits): Rename to
2778 Vwindow_combination_resize. Suggested by Juri Linkov.
2779 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2782 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2784 * nsfns.m (Fns_font_name):
2785 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2787 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2789 * window.h (window): Rename slot "nest" to "combination_limit".
2790 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2791 (Fset_window_nest): Rename to Fset_window_combination_limit.
2792 (Vwindow_nest): Rename to Vwindow_combination_limit.
2793 (recombine_windows, make_parent_window, make_window)
2794 (Fsplit_window_internal, saved_window)
2795 (Fset_window_configuration, save_window_save): Rename all
2796 occurrences of window_nest to window_combination_limit.
2798 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2800 * image.c (imagemagick_load_image): Fix typo.
2802 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2804 * xdisp.c (display_line): Move the call to
2805 highlight_trailing_whitespace before the call to
2806 compute_line_metrics, since the latter needs to see the final
2807 faces of all the glyphs to compute ROW's hash value.
2808 Fixes assertion violations in row_equal_p. (Bug#10035)
2810 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2812 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2813 just return (bug#10044).
2815 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2817 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2818 with user-defined heap size. Bump the default size of the temacs
2819 heap to 27MB, to avoid memory warning when running temacs.
2820 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2822 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2823 current_matrix and desired_matrix. (Bug#9990)
2824 (verify_row_hash) [XASSERTS]: New function.
2825 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2826 that the hash value of glyph rows is correct.
2828 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2830 * window.h (window): Remove splits slot.
2831 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2832 (Fdelete_other_windows_internal, make_parent_window)
2833 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2834 (Fset_window_configuration, save_window_save): Don't deal with
2835 split status of windows.
2836 (saved_window): Remove splits slot.
2837 (Vwindow_splits): Rewrite doc-string.
2839 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2841 * xfns.c (unwind_create_frame):
2842 * nsfns.m (unwind_create_frame):
2843 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2844 Vframe_list (Bug#9999).
2846 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2848 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2850 2011-11-11 Kenichi Handa <handa@m17n.org>
2852 * callproc.c (Fcall_process): Set the member dst_multibyte of
2855 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2857 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2858 avoid a crash (bug#9496).
2860 2011-11-09 Chong Yidong <cyd@gnu.org>
2862 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2863 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2865 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2867 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2869 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2871 Avoid some portability problems by eschewing 'extern inline' functions.
2872 The trivial performance wins aren't worth the portability hassles; see
2873 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2875 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2876 (window_box_width, window_box_left, window_box_left_offset)
2877 (window_box_right, window_box_right_offset): Undo previous change,
2878 by removing the "extern"s.
2879 * intervals.c (adjust_intervals_for_insertion)
2880 (adjust_intervals_for_deletion): Undo previous change,
2881 making these static again.
2882 (offset_intervals, temp_set_point_both, temp_set_point)
2883 (copy_intervals_to_string): No longer inline.
2884 * xdisp.c (window_text_bottom_y, window_box_width)
2885 (window_box_height, window_box_left_offset)
2886 (window_box_right_offset, window_box_left, window_box_right)
2887 (window_box): No longer inline.
2889 2011-11-08 Chong Yidong <cyd@gnu.org>
2891 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2892 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2893 Signal an error if not a live window.
2894 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2895 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2897 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2899 * lisp.h (syms_of_abbrev): Remove declaration.
2900 Reported by CHENG Gao <chenggao@royau.me>.
2902 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2904 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2905 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2906 of temacs in GUI mode.
2908 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2910 * window.h: Declare delete_all_child_windows instead of
2911 delete_all_subwindows.
2912 * window.c (Fwindow_nest, Fset_window_nest)
2913 (Fset_window_new_total, Fset_window_new_normal)
2914 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2915 (delete_all_subwindows): Rename to delete_all_child_windows.
2916 (Fdelete_other_windows_internal, Fset_window_configuration):
2917 Call delete_all_child_windows instead of delete_all_subwindows.
2918 * frame.c (delete_frame): Call delete_all_child_windows instead
2919 of delete_all_subwindows.
2921 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2923 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2924 This is also needed for porting to any host where GC_MARK_STACK is
2925 not GC_MAKE_GCPROS_NOOPS.
2926 (which_symbols): Use it.
2928 2011-11-07 Kenichi Handa <handa@m17n.org>
2930 * coding.c (coding_set_destination): Check coding->src_pos only
2931 when coding->src_object is a buffer (bug#9910).
2933 * process.c (send_process): Set the member src_multibyte of coding
2934 to 0 (bug#9911) when sending a unibyte text.
2936 * callproc.c (Fcall_process): Set the member src_multibyte of
2937 process_coding to 0 (bug#9912).
2939 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2941 * xmenu.c (cleanup_widget_value_tree): New function.
2942 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2943 calling free_menubar_widget_value_tree directly (Bug#9830).
2945 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2947 Fix some portability problems with 'inline'.
2948 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2949 (window_box_width, window_box_left, window_box_left_offset)
2950 (window_box_right, window_box_right_offset): Declare extern.
2951 Otherwise, these inline functions do not conform to C99 and
2952 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2953 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2954 * intervals.c (adjust_intervals_for_insertion)
2955 (adjust_intervals_for_deletion): Now extern, because otherwise the
2956 extern inline functions 'offset_intervals' couldn't refer to it.
2957 (static_offset_intervals): Remove.
2958 (offset_intervals): Rewrite using the old contents of
2959 static_offset_intervals. The old version didn't conform to C99
2960 because an extern inline function contained a reference to an
2961 identifier with static linkage.
2963 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2965 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2968 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2970 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2971 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2972 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2973 return Qleft_to_right.
2975 2011-11-06 Chong Yidong <cyd@gnu.org>
2977 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2978 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2979 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2980 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2981 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2982 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2983 (Fwindow_vscroll): Doc fix.
2984 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2985 argument, since it makes no sense to pass a live window and for
2986 consistency with window-child.
2988 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2990 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2993 2011-11-05 Jason Rumney <jasonr@gnu.org>
2995 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2996 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2998 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2999 bitwise arithmetic preventing use of unicode-sip and non-truetype
3002 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3004 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3007 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3008 initialization code to keep similarity to xfns.c after changes
3011 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3013 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3014 (unwind_create_frame): New function (Bug#9943).
3015 (Fx_create_frame): Restructure code to be more similar to the one in
3016 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3017 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3018 Move terminal->reference_count++ just before making the frame official
3021 * nsterm.m (x_free_frame_resources): New function.
3022 (x_destroy_window): Move code to x_free_frame_resources.
3024 * xfns.c (unwind_create_frame): Fix comment.
3025 (Fx_create_frame, x_create_tip_frame):
3026 Move terminal->reference_count++ just before making the frame
3027 official. Move initialization of image_cache_refcount and
3028 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3030 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3032 Support MSVC build with newer versions of Visual Studio.
3033 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3034 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3037 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3038 which are not supported by MSVC.
3039 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3040 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3042 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3044 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3046 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3048 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3050 Support MSVC build with newer versions of Visual Studio.
3051 * w32.c: Don't include w32api.h for MSVC.
3052 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3054 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3055 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3056 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3057 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3059 (alloca) [_MSC_VER]: Define to _alloca.
3061 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3063 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3065 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3067 * xdisp.c (note_mouse_highlight): If either of
3068 previous/next-single-property-change returns nil, treat that as
3069 the beginning or the end of the buffer. (Bug#9955)
3071 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3073 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3074 label is not null (Bug#9951).
3075 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3078 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3080 * window.c (Fwindow_body_size): Mention in the doc string that the
3081 return value is in frame's canonical units. (Bug#9949)
3083 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3085 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3087 * w32fns.c (unwind_create_frame): If needed, free the glyph
3088 matrices of the partially constructed frame. (Bug#9943)
3089 * xfns.c (unwind_create_frame): Likewise.
3091 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3093 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3094 Don't stop backward scan on the continuation glyph, even though
3095 its CHARPOS is positive.
3096 (mouse_face_from_buffer_pos, note_mouse_highlight):
3097 Rename cover_string to disp_string.
3099 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3101 * window.c (temp_output_buffer_show): Don't use
3102 Vtemp_buffer_show_specifiers.
3103 (Vtemp_buffer_show_specifiers): Remove unused variable.
3105 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3107 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3108 past the beginning of the current glyph matrix.
3110 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3112 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3113 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3114 HAVE_GTK3 (Bug#9869).
3116 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3117 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3119 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3121 * xterm.c: Declare x_handle_net_wm_state to return int.
3122 (handle_one_xevent): Check if we are iconified but don't have
3123 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3124 (get_current_wm_state): Return non-zero if not hidden,
3125 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3126 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3127 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3128 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3130 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3132 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3133 so that this new function doesn't get optimized away by a
3134 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3136 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3138 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3140 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3142 Fix the `xbytecode' command.
3143 * .gdbinit (xprintbytestr): New command.
3144 (xwhichsymbols): Rename from `which'; all callers changed.
3145 (xbytecode): Print the byte-code string as well.
3147 2011-10-29 Kim Storm <storm@cua.dk>
3149 * alloc.c (which_symbols): New function.
3151 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3153 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3156 2011-10-29 Glenn Morris <rgm@gnu.org>
3158 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3159 Not clear what it was for, and it causes various bugs. (Bug#9839)
3161 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3163 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3164 possible random value that matches one of those tested as
3165 condition to clear the mouse face.
3167 2011-10-28 Chong Yidong <cyd@gnu.org>
3169 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3171 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3173 * window.c (make_window): Initialize phys_cursor_on_p.
3175 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3177 * lisp.h (struct Lisp_Symbol): Update comments.
3179 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3181 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3183 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3185 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3186 <oslsachem@gmail.com> for helping to debug this.
3188 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3189 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3190 (g_b_init_get_glyph_outline_w): New static variables.
3191 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3192 (GetGlyphOutlineW_Proc): New typedefs.
3193 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3194 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3196 (w32font_open_internal, compute_metrics):
3197 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3198 instead of calling the "wide" APIs directly.
3200 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3202 * w32.h (syms_of_w32font): Add prototype.
3204 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3206 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3207 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3208 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3209 (Fmove_to_window_line): Doc fix.
3211 2011-10-27 Chong Yidong <cyd@gnu.org>
3213 * process.c (make_process): Set gnutls_state to NULL.
3215 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3216 non-NULL, regardless of GNUTLS_INITSTAGE.
3217 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3218 an error. Set process slots as soon as we allocate them.
3220 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3222 2011-10-27 Chong Yidong <cyd@gnu.org>
3224 * gnutls.c (emacs_gnutls_deinit): New function.
3225 Deallocate credentials structures as well as calling gnutls_deinit.
3226 (Fgnutls_deinit, Fgnutls_boot): Use it.
3228 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3229 (deactivate_process): Call emacs_gnutls_deinit.
3231 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3233 * image.c (x_create_x_image_and_pixmap):
3234 * w32.c (sys_rename, w32_delayed_load):
3235 * w32font.c (fill_in_logfont):
3236 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3238 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3240 * w32fns.c (w32_default_color_map): New function,
3241 extracted from Fw32_default_color_map.
3242 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3244 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3246 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3248 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3250 * keyboard.c (test_undefined): New function (bug#9751).
3251 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3253 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3255 * sysdep.c (init_sys_modes): Fix the check for the controlling
3256 terminal (Bug#6649).
3258 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3260 * dispextern.h (struct bidi_it): New member next_en_type.
3262 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3263 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3264 current character, check also for next_en_type being WEAK_EN.
3265 (bidi_resolve_weak): Don't enter the expensive loop if the current
3266 position is before next_en_pos. Record the bidi type of the first
3267 non-ET, non-BN character we find, in addition to its position.
3268 (bidi_level_of_next_char): Invalidate next_en_type when
3269 next_en_pos is over-stepped.
3271 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3273 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3274 * editfns.c: Rewrite current-time-zone so that it invokes
3275 the equivalent of (format-time-string "%Z") to get the time zone name.
3276 This fixes a bug when the time zone name contains characters that
3277 need converting from the system time locale to Emacs internal format.
3278 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3279 that patch fixed format-time-string to do the conversion, but
3280 I forgot to fix current-time-zone.
3281 (format_time_string): New function, containing most of
3282 what Fformat_time_string used to contain.
3283 (Fformat_time_string): Rewrite in terms of format_time_string.
3284 This doesn't change this function's behavior.
3285 (current-time-zone): Rewrite to use format_time_string.
3286 This fixes the bug reported by Michael Schierl in
3287 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3288 Jason Rumney's 2007-06-07 change worked around this bug, but
3290 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3292 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3294 * xdisp.c (start_display): If the character at POS is displayed
3295 via a display vector, reset IT->current.dpvec_index to zero.
3296 (try_window_reusing_current_matrix): If a line ends in a display
3297 vector or the next line starts in a display vector, continue
3298 redrawing the window even though the character position of
3299 start_row was reached.
3302 2011-10-18 Chong Yidong <cyd@gnu.org>
3304 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3305 with nobreak-char-display too.
3307 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3309 Fix part 3 of bug#9771.
3310 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3311 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3312 non-neutral characters if the current character is a paragraph
3313 separator (a.k.a. Newline). This avoids running the same
3314 expensive loop twice, once when we consume the preceding newline
3315 and the other time when the line actually needs to be displayed.
3316 Avoid the loop when we see neutrals on the base embedding level
3317 following a character whose directionality is the same as the
3318 paragraph's. This avoids running the expensive loop when a line
3319 ends in a long sequence of neutrals, like control characters.
3320 Add assertion against STRONG_AL type. Slightly rearrange code
3321 that determines the type of a neutral given the first non-neutral
3323 (bidi_level_of_next_char): Set next_en_pos to zero when
3324 invalidating its info.
3326 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3328 * xdisp.c (push_display_prop): Determine whether to record string
3329 or buffer position by IT->string, not by IT->method. Allow
3330 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3331 (move_it_vertically_backward): Don't look for character position
3332 immediately after the newline when in a continuation line.
3335 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3337 * window.c (coordinates_in_window): Rewrite and delabelize
3338 vertical border check. (Bug#5357) (Bug#9618)
3340 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3342 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3343 errors in XSetWindowBorder (bug#9310).
3345 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3347 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3348 avoid crash when xmalloc overrun checking is enabled.
3350 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3352 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3353 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3354 cursor motion with <left> and <right> arrow keys.
3356 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3357 some callers set that themselves.
3359 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3361 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3362 display string and the previous row comes from the same string and
3363 is empty. (Bug#9739) (Bug#9738)
3365 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3367 * doc.c (get_doc_string): Encode file name (bug#9735).
3369 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3371 * bidi.c (bidi_level_of_next_char):
3372 * xdisp.c (get_visually_first_element): Remove old incorrect
3373 comments regarding the Unicode Line Separator character.
3375 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3377 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3379 * alloc.c (Fgc_status): Do not access beyond zombies array
3380 boundary if nzombies > MAX_ZOMBIES.
3381 * alloc.c (dump_zombies): Add missing format specifier.
3383 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3385 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3386 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3388 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3389 Some packages use them to denote characters with modifiers.
3391 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3393 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3394 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3395 matching a pp-number. Rename parameter var to var1.
3397 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3399 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3401 2011-10-08 Glenn Morris <rgm@gnu.org>
3403 * callint.c (Fcall_interactively): Give a more explicit error for the
3404 'c' case with a non-character input. (Bug#8479)
3406 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3408 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3410 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3411 lines that are hscrolled on the left.
3413 * dispnew.c (buffer_posn_from_coords): Account for a possible
3414 presence of header-line. (Bug#4426)
3416 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3418 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3419 Don't advertise functionality which we discourage or doesn't work.
3421 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3423 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3424 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3425 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3426 this makes Emacs dump core during garbage collection on rare
3427 occasions. sizeof is obviously inferior to offsetof here, so
3428 stick with offsetof.
3429 (GC_POINTER_ALIGNMENT): New macro.
3430 (mark_memory): Omit 3rd (offset) arg; caller changed.
3431 Don't assume EMACS_INT alignment is the same as pointer alignment.
3433 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3435 * keyboard.c (read_key_sequence_remapped): New var.
3436 (read_key_sequence): Compute remapping in the right buffer.
3437 (command_loop_1): Use read_key_sequence's remapping directly.
3439 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3441 * dired.c (file_name_completion): Don't expand file name.
3442 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3443 before checking file name handler.
3445 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3446 they've been requested explicitly (bug#9591).
3448 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3450 * keymap.c (Fsingle_key_description): Use make_specified_string
3451 instead of build_string to build string from push_key_description.
3454 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3456 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3457 This fixes a Y2038 bug on 64-bit hosts.
3458 * buffer.c (reset_buffer):
3459 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3460 (Fclear_buffer_auto_save_failure):
3461 Use 0, not -1, to represent an unset failure time, since time_t
3462 might not be signed.
3464 Remove dependency on glibc malloc internals.
3465 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3466 Move back here from lisp.h, but with their new implementations.
3467 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3468 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3469 * charset.c (charset_table_init): New static var.
3470 (syms_of_charset): Use it instead of xmalloc. This removes a
3471 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3472 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3473 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3474 Move back to alloc.c.
3475 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3476 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3478 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3480 * nsterm.m (windowDidResize): Call x_set_window_size only when
3481 ns_in_resize is true. Otherwise set pixelwidth/height and
3482 call change_frame_size (Bug#9628).
3484 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3486 Port --enable-checking=all to Fedora 14 x86-64.
3487 * charset.c (syms_of_charset): Also account for glibc malloc's
3488 internal overhead when calculating the initial malloc maximum.
3490 Port --enable-checking=all to Fedora 14 x86.
3491 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3493 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3494 (overrun_check_realloc, overrun_check_free):
3495 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3496 That way, xmalloc returns a properly-aligned pointer even if
3497 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3498 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3499 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3500 into account when calculating the initial malloc maximum.
3501 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3502 Move here from alloc.c, so that charset.c can use it too.
3503 Properly align; the old code wasn't right for common 32-bit hosts
3504 when configured with --enable-checking=all.
3505 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3506 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3508 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3510 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3513 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3515 * xdisp.c (compute_display_string_end): If there's no display
3516 string at CHARPOS, return -1.
3518 * bidi.c (bidi_fetch_char): When compute_display_string_end
3519 returns a negative value, treat the character as a normal
3520 character not covered by a display string. (Bug#9624)
3522 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3524 * lread.c (Fread_from_string): Fix typo in docstring.
3526 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3528 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3529 newline, reseat the iterator instead of bidi-iterating there one
3530 character at a time. (Bug#9610)
3531 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3532 TO_CHARPOS if the bidi iterator is at base embedding level.
3534 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3536 * lread.c (readevalloop): Use correct code for NBSP.
3537 (read1): Likewise. (Bug#9608)
3539 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3541 * dbusbind.c (Fdbus_register_signal): When service is not
3542 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3544 2011-09-25 Glenn Morris <rgm@gnu.org>
3546 * buffer.c (truncate-lines): Doc fix.
3548 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3550 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3551 (Fset_window_next_buffers): Doc fix.
3553 2011-09-24 Glenn Morris <rgm@gnu.org>
3555 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3557 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3559 Fix minor problems found by static checking.
3560 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3561 * indent.c (Fvertical_motion): Fix == vs = typo.
3563 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3565 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3566 Default value is now t. Doc fix.
3568 * indent.c (Fvertical_motion): Compute and apply the overshoot
3569 logic when moving up, not only when moving down. Fix the
3570 confusing name and values of the it_overshoot_expected variable;
3571 logic changes accordingly. (Bug#9254) (Bug#9549)
3573 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3574 CHARPOS is covered by a display string which includes newlines.
3575 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3576 is covered by a display string with embedded newlines.
3578 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3580 * dbusbind.c (Fdbus_register_signal): Add match rule to
3581 Vdbus_registered_objects_table. (Bug#9581)
3582 (Fdbus_register_method, Vdbus_registered_objects_table):
3585 2011-09-24 Jim Meyering <meyering@redhat.com>
3587 do not ignore write error for any output size
3588 The previous change was incomplete.
3589 While it makes emacs --batch detect the vast majority of stdout
3590 write failures, errors were still ignored whenever the output size is
3591 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3592 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3593 && echo FAIL: ignored write error
3594 FAIL: ignored write error
3595 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3596 && echo FAIL: ignored write error
3597 FAIL: ignored write error
3598 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3600 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3602 * emacs.c (Fkill_emacs): In noninteractive mode exit
3603 non-successfully if a write error occurred on stdout. (Bug#9574)
3605 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3610 * dispextern.h (struct it): Update the comment documenting what
3613 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3615 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3616 a display string, extend search for cursor position to end of row.
3617 (find_row_edges): If the row ends in a newline from a display
3618 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3619 Handle the case of a display string with multiple newlines.
3620 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3621 non-empty line. Fixes confusing cursor motion with arrow keys at
3622 the beginning of a line that starts with whitespace.
3624 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3626 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3629 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3631 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3634 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3636 * xdisp.c (display_line): Record maximum and minimum buffer
3637 positions even if no glyphs were produced (e.g., by a zero-width
3638 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3639 buffer positions that will be removed from the glyph row because
3641 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3642 column is beyond frame width: don't subtract 1 "pixel" when
3643 computing width of the stretch.
3644 (reseat_at_next_visible_line_start): Undo the change made on
3645 2011-09-17 that saved paragraph information and restored it after
3646 the call to `reseat'. (Bug#9545)
3648 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3650 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3651 and turn window cursor on if cleared (Bug#9415).
3653 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3655 * search.c (boyer_moore): Take unibyte characters from pattern
3656 literally. (Bug#9458)
3658 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3660 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3662 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3664 Fix minor problem found by static checking.
3665 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3666 initialized, to pacify gcc -Wuninitialized.
3668 * fileio.c: Report proper errno when syscall falls.
3669 (Finsert_file_contents): Save and restore errno,
3670 so that report_file_error outputs the correct diagnostic.
3671 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3673 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3675 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3677 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3680 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3682 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3684 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3685 about the current paragraph and restore it after the call to reseat.
3687 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3688 (bidi_find_paragraph_start): Search back for paragraph beginning
3689 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3690 (bidi_move_to_visually_next): Only trigger paragraph-related
3691 computations when the last character is a newline or at EOB, not
3692 just any NEUTRAL_B. (Bug#9470)
3694 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3695 truncated lines if point is covered by a display string. (Bug#9524)
3697 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3699 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3700 (cons_to_x_long): New function.
3701 (lisp_data_to_selection_data): Use it. Correct the test for
3702 short-versus-long data; it was negated. Break out of vector
3703 loop, for efficiency, when a long datum is discovered.
3705 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3707 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3709 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3711 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3712 GCC PR/17406) by declaring this function with external scope.
3714 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3716 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3717 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3719 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3721 * editfns.c (Fformat): Correctly handle text properties on "%%".
3723 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3725 * xterm.c (x_draw_composite_glyph_string_foreground):
3726 * w32term.c (x_draw_composite_glyph_string_foreground):
3727 * term.c (encode_terminal_code):
3728 * composite.c (composition_update_it, get_composition_id):
3729 * xdisp.c (get_next_display_element)
3730 (fill_composite_glyph_string): Add comments about special meaning
3731 of TAB characters in a composition.
3733 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3735 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3736 This occurs when processing a multibyte format.
3737 Problem reported by Wolfgang Jenker.
3739 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3741 * xdisp.c (try_cursor_movement): Only check for exact match if
3742 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3744 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3746 Remove unused external symbols.
3747 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3748 * xdisp.c (calc_pixel_width_or_height): Now static.
3749 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3750 * indent.c (check_display_width):
3751 * w32term.c: Fix comment to match code.
3752 * xterm.c, xterm.h (x_catching_errors): Remove.
3754 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3756 * xselect.c: Use signed conversions more consistently (Bug#9498).
3757 (selection_data_to_lisp_data): Assume incoming selection data are
3758 signed integers, not unsigned. This is to be consistent with
3759 outgoing selection data, which was modified to use signed integers
3760 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3761 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3762 expects long, not unsigned long.
3764 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3766 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3767 computation of loop end. Reported by Johan Bockgård
3770 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3772 * frame.c (Fother_visible_frames_p): Function deleted.
3774 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3776 * indent.c (compute_motion): Process display vector front to back
3777 rather than the other way around. (Bug#2496)
3779 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3781 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3783 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3785 * minibuf.c (Fread_from_minibuffer): Doc fix.
3787 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3789 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3790 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3792 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3795 value for non-existent files.
3797 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3799 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3800 set its "size" to -1. This will set the modtime_size field of
3801 the corresponding buffer to -1, which is what
3802 verify-visited-file-modtime expects for files that do not exist.
3805 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3807 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3809 * lisp.h: ... from here. push_key_description is no longer
3810 defined in keyboard.c, so its declaration should not be in
3811 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3812 logically belongs with push_key_description.
3814 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3816 * buffer.h: Include <sys/types.h> instead of <time.h>.
3817 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3818 Problem reported by Herbert J. Skuhra.
3820 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3822 * xml.c (parse_region): Make the parsing work for
3823 non-comment-starting XML files again (bug#9144).
3825 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3827 * image.c (gif_load): Fix calculation of bottom and right corner.
3830 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3832 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3833 redisplay in small windows.
3835 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3837 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3839 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3841 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3842 Operate on live windows only.
3844 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3846 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3848 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3850 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3851 only under bidi iteration.
3853 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3855 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3857 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3859 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3860 Without this fix, the command to link temacs failed due to an
3861 undefined symbol __builtin_isnan. This is because
3862 /usr/include/iso/math_c99.h #defines isnan(x) to
3863 __builtin_isnan(x), but the bundled gcc, which identifies itself
3864 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3866 * floatfns.c (isnan): #undef, and then #define to a clone of
3868 (Fisnan): Always define, since it's always available now.
3869 (syms_of_floatfns): Always define isnan at the Lisp level.
3871 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3873 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3875 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3877 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3878 The previous code assumed that file offsets (off_t values) fit in
3879 EMACS_INT variables, which is not true on typical 32-bit hosts.
3880 The code messed up by falsely reporting buffer overflow in cases
3881 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3882 when "big" contains more than 2**29 bytes, even though this
3883 inserts just one byte and does not overflow the buffer.
3884 (Finsert_file_contents): Store file offsets as off_t
3885 values, not as EMACS_INT values. Check for overflow when
3886 converting between EMACS_INT and off_t. When checking for
3887 buffer overflow or for overlap, take the offsets into account.
3888 Don't use EMACS_INT for small values where int suffices.
3889 When checking for overlap, fix a typo: ZV was used where
3890 ZV_BYTE was intended.
3891 (Fwrite_region): Don't assume off_t fits into 'long'.
3892 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3894 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3896 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3898 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3900 sprintf-related integer and memory overflow issues (Bug#9412).
3902 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3903 (esprintf, exprintf, evxprintf): New functions.
3904 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3905 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3906 (modify_event_symbol): Do not assume that the length of
3907 name_alist_or_stem is safe to alloca and fits in int.
3908 (Fexecute_extended_command): Likewise for function name and binding.
3909 (Frecursion_depth): Wrap around reliably on integer overflow.
3910 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3911 since some callers pass EMACS_INT values.
3912 (Fsingle_key_description): Don't crash if symbol name contains more
3913 than MAX_ALLOCA bytes.
3914 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3915 (get_minibuffer): Arg is now EMACS_INT, not int.
3916 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3917 (esprintf, exprintf, evxprintf): New decls.
3918 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3920 * dbusbind.c (signature_cat): New function.
3921 (xd_signature, Fdbus_register_signal):
3922 Do not overrun buffer; instead, report string overflow.
3924 * dispnew.c (add_window_display_history): Don't overrun buffer.
3925 Truncate instead; this is OK since it's just a log.
3927 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3928 even if the time zone offset is outlandishly large.
3929 Don't mishandle offset == INT_MIN.
3931 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3932 when creating daemon; the previous buffer-overflow check was incorrect.
3934 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3935 which has the guts of the old verror function.
3937 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3938 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3940 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3941 (font_unparse_xlfd): Don't blindly alloca long strings.
3942 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3943 fits in int, when using sprintf. Use single snprintf to count
3944 length of string rather than counting it via multiple sprintfs;
3945 that's simpler and more reliable.
3946 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3947 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3948 sprintf, in case result does not fit in int.
3950 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3951 (fontset_from_font): Print it.
3953 * frame.c (tty_frame_count): Now printmax_t, not int.
3954 (make_terminal_frame, set_term_frame_name): Print it.
3955 (x_report_frame_params): In X, window IDs are unsigned long,
3956 not signed long, so print them as unsigned.
3957 (validate_x_resource_name): Check for implausibly long names,
3958 and don't assume name length fits in 'int'.
3959 (x_get_resource_string): Don't blindly alloca invocation name;
3960 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3963 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3964 (xg_check_special_colors, xg_set_geometry):
3965 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3967 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3968 Use esprintf, not sprintf, in case result does not fit in int.
3970 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3971 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3972 it as a large positive number.
3973 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3974 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3976 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3977 in case result does not fit in int.
3979 * print.c (float_to_string): Detect width overflow more reliably.
3980 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3981 buffer overrun. Don't assume list length fits in 'int'. Treat
3982 print length of 0 as 0, not as infinity; to be consistent with other
3983 uses of print length in this function. Don't overflow print length
3984 index. Don't assume hash table size fits in 'long', or that
3985 vectorlike size fits in 'unsigned long'.
3987 * process.c (make_process): Use printmax_t, not int, to format
3988 process-name gensyms.
3990 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3992 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3993 to avoid potential buffer overrun.
3995 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3996 if X resource line is longer than 512 bytes.
3998 * xfns.c (x_window): Make sprintf buffer a bit bigger
3999 to avoid potential buffer overrun.
4001 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4003 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4005 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4007 Integer overflow fixes for scrolling, etc.
4008 Without these, Emacs silently mishandles large integers sometimes.
4009 For example, "C-u 4294967297 M-x recenter" was treated as if
4010 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4012 * xdisp.c (try_window_id): Check Emacs fixnum range before
4013 converting to 'int'.
4015 * window.c (window_scroll_line_based, Frecenter):
4016 Check that an Emacs fixnum is in range before assigning it to 'int'.
4017 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4018 values converted from Emacs fixnums.
4019 (Frecenter): Don't wrap around a line count if it is out of 'int'
4020 range; instead, treat it as an extreme value.
4021 (Fset_window_configuration, compare_window_configurations):
4022 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4024 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4025 that can exceed INT_MAX. Check that EMACS_INT value is in range
4026 before assigning it to the (possibly-narrower) index.
4027 (match_limit): Don't assume that a fixnum can fit in 'int'.
4029 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4032 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4033 (Fvertical_motion): Don't wrap around LINES values that don't fit
4034 in 'int'. Instead, treat them as extreme values. This is good
4035 enough for windows, which can't have more than INT_MAX lines anyway.
4037 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4039 * Require libxml/parser.h to avoid compilation warning.
4041 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4043 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4044 since this reportedly can destroy thread storage.
4046 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4048 * syntax.c (find_defun_start): Update all cache variables if
4049 exiting early (Bug#9401).
4051 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4053 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4055 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4056 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4057 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4059 * term.c (tty_append_glyph): New function.
4060 (produce_stretch_glyph): Static function and its prototype deleted.
4062 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4065 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4067 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4068 when checking :margin (Bug#9390).
4069 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4070 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4071 so that the name doesn't mislead. All uses changed.
4073 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4075 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4078 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4080 * xdisp.c (move_it_to): Don't bail out early when reaching
4081 position beyond to_charpos, if we are scanning backwards.
4082 (move_it_vertically_backward): When DY == 0, make sure we get to
4083 the first character in the line after the newline.
4085 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4087 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4088 (ccl_driver): Do not generate an out-of-range pointer.
4089 (Fccl_execute_on_string): Remove unnecessary check for
4090 integer overflow, noted by Stefan Monnier in
4091 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4092 Remove a FIXME that didn't need fixing.
4093 Simplify the newly-introduced buffer reallocation code.
4095 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4097 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4099 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4101 Integer and memory overflow issues (Bug#9196).
4103 * doc.c (get_doc_string): Rework so that
4104 get_doc_string_buffer_size is the actual buffer size, rather than
4105 being 1 less than the actual buffer size; this makes xpalloc more
4108 * image.c (x_allocate_bitmap_record, cache_image):
4109 * xselect.c (Fx_register_dnd_atom):
4110 Simplify previous changes by using xpalloc.
4112 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4113 since either will do and ptrdiff_t is convenient with xpalloc.
4115 * charset.c (charset_table_size)
4116 (struct charset_sort_data.priority): Now ptrdiff_t.
4117 (charset_compare): Don't overflow if priorities differ greatly.
4118 (Fsort_charsets): Don't assume list length fits in int.
4119 Check for size-calculation overflow when allocating sort data.
4120 (syms_of_charset): Allocate an initial charset table that is
4121 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4123 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4125 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4126 The actual value is always <= INT_MAX, and leaving it unsigned made
4127 overflow checking harder.
4129 * dispextern.h (struct glyph_matrix.rows_allocated)
4130 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4131 with xpalloc. The values are still always <= INT_MAX.
4133 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4135 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4136 (SAFE_NALLOCA): New macro.
4138 * region-cache.c (struct boundary.pos, find_cache_boundary)
4139 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4140 (set_cache_region, invalidate_region_cache)
4141 (revalidate_region_cache, know_region_cache, region_cache_forward)
4142 (region_cache_backward, pp_cache):
4143 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4144 so that ptrdiff_t * can be passed to xpalloc.
4145 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4146 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4147 (pp_cache): Don't assume cache_len fits in int.
4148 * region-cache.h: Adjust extern decls to match.
4150 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4151 EMACS_INT, since either will do, for xpalloc.
4153 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4154 (xnmalloc, xnrealloc, xpalloc): New functions.
4156 * bidi.c (bidi_shelve_header_size): New constant.
4157 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4158 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4160 * bidi.c (bidi_cache_shrink):
4161 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4163 Don't update size of array until after memory allocation succeeds,
4164 because xmalloc/xrealloc may not return.
4165 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4166 now that we have proper integer overflow checking.
4167 (record_overlay_string, overlay_strings): Catch overflows when
4168 calculating size of overlay_str_buf.
4170 * callproc.c (Fcall_process): Check for size overflow when
4171 calculating size of args2.
4172 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4173 Normally we prefer signed values, but sticking with ptrdiff_t would
4174 require adding more-complicated checks.
4176 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4177 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4178 Redo buffer-overflow calculations to avoid integer overflow.
4179 Add a FIXME comment where memory seems to be over-allocated.
4181 * character.c (Fstring): Check for size-calculation overflow.
4183 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4184 unnecessary integer overflow. Check for size overflow.
4185 (encode_coding_object): Don't update size until xmalloc succeeds.
4187 * composite.c (get_composition_id): Check for overflow in glyph
4188 length calculations.
4190 Integer and memory overflow fixes for display code.
4191 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4192 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4193 (scrolling_window): Check for overflow in size calculations.
4194 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4195 Don't assume glyph table len fits in int.
4196 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4197 (row_table_size): Now ptrdiff_t, not int.
4198 (scrolling_window): Avoid overflow in size calculations.
4199 Don't update size until allocation succeeds.
4200 * fns.c (concat): Check for overflow in size calculations.
4201 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4202 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4203 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4205 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4206 (get_doc_string): Check for size calculation overflow.
4207 Don't update size until allocation succeeds.
4208 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4209 EMACS_INT, where ptrdiff_t will do.
4210 (Fsubstitute_command_keys): Check for string overflow.
4212 * editfns.c (set_time_zone_rule): Don't assume environment length
4214 (message_length): Now ptrdiff_t, not int.
4215 (Fmessage_box): Don't update size until allocation succeeds.
4216 Don't assume message length fits in int.
4217 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4219 * emacs.c (main): Do not reallocate argv, since there is a null at
4220 the end that can be overwritten, and this way there's no need to
4221 worry about size-calculation overflow.
4222 (sort_args): Check for size-calculation overflow.
4224 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4226 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4228 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4229 (x_set_scroll_bar_width, x_figure_window_size):
4230 Check for integer overflow.
4231 (x_set_alpha): Do not assume XINT fits in int.
4233 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4234 This is for the members text_lines, text_cols, total_lines, total_cols,
4235 where the system imposes an 'int' limit.
4237 * fringe.c (Fdefine_fringe_bitmap):
4238 Don't update size until alloc works.
4240 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4241 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4243 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4244 Check for size-calculation overflow.
4245 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4246 do, as we prefer signed integers.
4247 (id_to_widget.max_size, id_to_widget.used)
4248 (xg_store_widget_in_map, xg_remove_widget_from_map)
4249 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4250 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4251 Use and return ptrdiff_t, not int.
4252 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4253 * gtkutil.h: Change prototypes to match the above.
4255 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4256 are duplicate now that they've been promoted to lisp.h.
4257 (x_allocate_bitmap_record, x_alloc_image_color)
4258 (make_image_cache, cache_image, xpm_load):
4259 Don't update size until alloc is done.
4260 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4262 Check for size calculation overflow.
4263 (ct_colors_allocated_max): New constant.
4264 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4267 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4268 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4269 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4270 Use ptrdiff_t, not int, to count maps.
4271 (read_char_minibuf_menu_prompt): Check for overflow in size
4272 calculations. Don't update size until allocation succeeds.
4273 Redo calculations to avoid overflow.
4274 * keyboard.h: Change prototypes to match the above.
4276 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4278 (current_minor_maps): Check for size calculation overflow.
4279 * keymap.h: Change prototypes to match the above.
4281 * lread.c (read1, init_obarray): Don't update size until alloc done.
4283 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4284 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4286 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4287 Now ptrdiff_t, not int.
4288 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4289 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4291 * process.c (Fnetwork_interface_list): Check for overflow
4292 in size calculation.
4294 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4296 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4297 overflow. Don't bother calling xmalloc when xrealloc will do.
4299 * search.c (Freplace_match): Check for size calculation overflow.
4300 (Fset_match_data): Don't assume list lengths fit in 'int'.
4302 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4303 for command line length. Do not attempt to address one before the
4304 beginning of an array, as that's not portable.
4306 * term.c (max_frame_lines): Remove; unused.
4307 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4309 (encode_terminal_code, calculate_costs): Check for size
4310 calculation overflow.
4311 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4312 table lengths and related sizes. Don't update size until alloc
4313 done. Redo calculations to avoid overflow.
4314 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4316 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4317 subtracting pointers.
4318 (gobble_line): Check for overflow more carefully. Don't update size
4321 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4322 Don't update size until alloc done.
4323 Redo size calculations to avoid overflow.
4324 Check for size calculation overflow.
4325 (main) [DEBUG]: Fix typo in invoking tparam1.
4327 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4328 Use ptrdiff_t, not int, for sizes.
4329 (store_mode_line_noprop_char): Don't update size until alloc done.
4331 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4332 Use ptrdiff_t, not int, for sizes.
4333 (Finternal_make_lisp_face, cache_face):
4334 Check for size calculation overflow.
4335 (cache_face): Treat size calculation overflows as if they were
4336 memory exhaustion (the usual treatment), rather than aborting.
4338 * xfns.c (x_encode_text, x_set_name_internal)
4339 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4340 sizes, since they can exceed INT_MAX in size. Check for size
4341 calculation overflow.
4343 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4344 (xg_select): Check for size calculation overflow.
4345 Don't update size until alloc done.
4347 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4348 as sprintf is limited to int lengths.
4350 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4351 (X_LONG_MIN): New macros.
4352 Use them to make the following changes clearer.
4353 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4354 This change doesn't affect the value now, but it may help remind
4355 future maintainers not to raise the value too much later.
4356 (SELECTION_QUANTUM): Remove, replacing with ...
4357 (selection_quantum): ... new function, which avoids overflow.
4359 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4360 assumption that selection length fits in 'int'.
4361 (x_reply_selection_request, x_handle_selection_request)
4362 (x_get_window_property, receive_incremental_selection)
4363 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4364 (lisp_data_to_selection_data, clean_local_selection_data):
4365 Use ptrdiff_t, not int, to record length of selection.
4366 (x_reply_selection_request, x_get_window_property)
4367 (receive_incremental_selection, x_property_data_to_lisp):
4368 Redo calculations to avoid overflow.
4369 (x_reply_selection_request): When sending hint, ceiling it at
4370 X_LONG_MAX rather than relying on wraparound overflow to send
4372 (x_get_window_property, receive_incremental_selection)
4373 (lisp_data_to_selection_data, x_property_data_to_lisp):
4374 Check for size-calculation overflow.
4375 (x_get_window_property, receive_incremental_selection)
4376 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4377 Don't store size until memory allocation succeeds.
4378 (x_get_window_property): Plug memory leak on memory exhaustion.
4379 Don't double-block input; malloc is safe here. Don't assume 2**34
4380 - 4 fits in unsigned long. Add an xassert to check
4381 XGetWindowProperty overflow. Be more careful about overflow
4382 calculations, and distinguish size from memory overflow better.
4383 (receive_incremental_selection): When tracing, don't assume
4384 unsigned int is less than INT_MAX.
4385 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4386 harmful) conversions of unsigned short to int.
4387 (lisp_data_to_selection_data): Don't assume that integers
4388 in the range -65535 through -1 fit in an X unsigned short.
4389 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4390 result parameters unless successful. Rely on cons_to_unsigned
4391 to report problems with elements; the old code wasn't right anyway.
4392 (x_check_property_data): Check for int overflow; we cannot use
4393 a wider type due to X limits.
4394 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4396 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4398 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4399 (x_term_init): Check for size calculation overflow.
4400 (x_color_cells): Don't store size until memory allocation succeeds.
4401 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4402 Don't assume alloca size is less than MAX_ALLOCA.
4403 (x_term_init): Don't assume length fits in int (sprintf is limited
4406 Use ptrdiff_t for composition IDs.
4407 * character.c (lisp_string_width):
4408 * composite.c (composition_table_size, n_compositions)
4409 (get_composition_id, composition_gstring_from_id):
4410 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4412 * window.c (Frecenter):
4413 Use ptrdiff_t, not int, for composition IDs.
4414 * composite.c (get_composition_id): Check for integer overflow.
4415 * composite.h: Adjust prototypes to match the above changes.
4417 Use ptrdiff_t for hash table indexes.
4418 * category.c (hash_get_category_set):
4419 * ccl.c (ccl_driver):
4420 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4421 * coding.c (coding_system_charset_list, detect_coding_system):
4422 * coding.h (struct coding_system.id):
4423 * composite.c (get_composition_id, gstring_lookup_cache):
4424 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4425 * image.c (xpm_get_color_table_h):
4426 * lisp.h (hash_lookup, hash_put):
4427 * minibuf.c (Ftest_completion):
4428 Use ptrdiff_t for hash table indexes, not int (which is too
4429 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4430 32-bit --with-wide-int hosts).
4432 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4433 Add a FIXME comment about memory leaks.
4434 (syms_of_charset): Don't assume xmalloc returns.
4436 Don't assume that stated character widths fit in int.
4437 * character.c (Fchar_width, c_string_width, lisp_string_width):
4438 * character.h (CHAR_WIDTH):
4439 * indent.c (MULTIBYTE_BYTES_WIDTH):
4440 Use sanitize_char_width to avoid undefined and/or bad behavior
4441 with outlandish widths.
4442 * character.h (sanitize_tab_width): Rename from sanitize_width,
4443 now that we have two such functions. All uses changed.
4444 (sanitize_char_width): New inline function.
4446 Don't assume that tab-width fits in int.
4447 * character.h (sanitize_width): New inline function.
4448 (SANE_TAB_WIDTH): New macro.
4449 (ASCII_CHAR_WIDTH): Use it.
4450 * indent.c (sane_tab_width): Remove. All uses replaced by
4451 SANE_TAB_WIDTH (current_buffer).
4452 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4454 * fileio.c: Integer overflow issues with file modes.
4455 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4457 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4458 Remove unreachable code.
4459 (read_hex, load_charset_map_from_file): Check for integer overflow.
4461 * xterm.c: Don't go over XClientMessageEvent limit.
4462 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4463 (x_send_scroll_bar_event): Likewise. Check that the size does not
4464 exceed limits imposed by XClientMessageEvent, as well as the usual
4465 ptrdiff_t and size_t limits.
4467 * keyboard.c: Overflow, signedness and related fixes.
4468 (make_lispy_movement): Use same integer type in forward decl
4469 that is used in the definition.
4470 (read_key_sequence, keyremap_step):
4471 Change bufsize argument back to int, undoing my 2011-03-30 change.
4472 We prefer signed types, and int is wide enough here.
4473 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4474 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4475 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4476 length, not size_t. Use ptrdiff_t for index, not int.
4477 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4478 possibility of integer overflow.
4480 Overflow, signedness and related fixes for images.
4482 * dispextern.h (struct it.stack[0].u.image.image_id)
4483 (struct_it.image_id, struct image.id, struct image_cache.size)
4484 (struct image_cache.used, struct image_cache.ref_count):
4485 * gtkutil.c (update_frame_tool_bar):
4486 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4487 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4488 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4489 * nsmenu.m (update_frame_tool_bar):
4490 * xdisp.c (calc_pixel_width_or_height):
4491 * xfns.c (image_cache_refcount):
4492 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4493 on typical 64-bit hosts.
4495 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4496 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4497 Omit unnecessary casts to int.
4498 (parse_image_spec): Check that integers fall into 'int' range
4499 when the callers expect that.
4500 (image_ascent): Redo ascent calculation to avoid int overflow.
4501 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4502 (lookup_image): Remove unnecessary tests.
4503 (xbm_image_p): Locals are now of int, not EMACS_INT,
4504 since parse_image_check makes sure they fit into int.
4505 (png_load, gif_load, svg_load_image):
4506 Prefer int to unsigned where either will do.
4507 (tiff_handler): New function, combining the cores of the
4508 old tiff_error_handler and tiff_warning_handler.
4509 This function is rewritten to use vsnprintf and thereby avoid
4510 stack buffer overflows. It uses only the features of vsnprintf
4511 that are common to both POSIX and native Microsoft.
4512 (tiff_error_handler, tiff_warning_handler): Use it.
4513 (tiff_load, gif_load, imagemagick_load_image):
4514 Don't assume :index value fits in 'int'.
4515 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4516 (imagemagick_load_image): Check that crop parameters fit into
4517 the integer types that MagickCropImage accepts. Don't assume
4518 Vimagemagick_render_type has a nonnegative value. Don't assume
4519 size_t fits in 'long'.
4520 (gs_load): Use printmax_t to print the widest integers possible.
4521 Check for integer overflow when computing image height and width.
4523 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4525 * xdisp.c (redisplay_window): Don't force window start if point
4526 will be invisible in the resulting window. (Bug#9324)
4528 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4530 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4531 the display spec is of the form `(space ...)'.
4532 (handle_display_spec): Return the value returned by
4533 handle_single_display_spec, not just 1 or zero.
4534 (handle_single_display_spec): If the display spec is of the form
4535 `(space ...)', and specifies display in the text area, return 2
4537 (try_cursor_movement): Check for the need to scroll more
4538 accurately, and prefer exact match for point under bidi.
4539 Don't advance `row' beyond the last row of the window.
4541 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4542 into disp_prop; all users changed.
4544 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4545 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4546 for the text covered by the display property.
4548 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4550 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4551 Change return value to nil.
4552 (Frecord_buffer): Delete unused function.
4554 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4556 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4557 buffers, return left-to-right.
4558 (set_cursor_from_row): Consider candidate row a win if its glyph
4559 represents a newline and point is on that newline. Fixes cursor
4560 positioning on the newline at EOL of R2L text within L2R
4561 paragraph, and vice versa.
4562 (try_cursor_movement): Check continued rows, in addition to
4563 continuation rows. Fixes unwarranted scroll when point enters a
4564 continued line of R2L text within an L2R paragraph, or vice versa.
4565 (cursor_row_p): Consider the case of point being equal to
4566 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4567 from the end of a short line to the beginning of a continued line
4568 of R2L text within L2R paragraph.
4569 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4570 composed characters.
4572 * bidi.c (bidi_check_type): Use xassert.
4573 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4576 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4578 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4581 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4583 * nsfont.m (ns_otf_to_script): Fix typo.
4585 2011-08-22 Kenichi Handa <handa@m17n.org>
4587 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4588 extra slot even if the purpose is char-code-property-table.
4590 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4592 * xdisp.c (redisplay_window): When computing centering_position,
4593 account for the height of the header line. (Bug#8874)
4595 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4596 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4597 candidate is selected by the mouse, and that candidate has a
4598 composed character under the mouse.
4600 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4601 coordinates reported by pos-visible-in-window-p for a composed
4602 character in column zero.
4604 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4606 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4608 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4610 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4611 consider it a hit if to_charpos is anywhere in the range of the
4612 composed buffer positions.
4614 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4616 * image.c (gif_load): Don't assume that each subimage has the same
4617 dimensions as the base image. Handle disposal method that is
4618 "undefined" by the gif spec (Bug#9335).
4620 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4622 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4623 (Fcondition_case): Document `debug' symbol in error handler.
4625 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4627 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4628 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4629 from an Org mode buffer to a Speedbar frame.
4631 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4632 a composition, take its buffer position from IT->cmp_it.charpos.
4633 Fixes cursor positioning at the beginning of a line that begins
4634 with a composed character.
4636 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4638 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4639 character bidirectional type, use STRONG_L instead. Fixes crashes
4640 in a buffer produced by `describe-categories'.
4642 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4643 members before the level stack, so they would be saved and
4644 restored when copying iterator state. Fixes incorrect reordering
4645 around TABs covered by display properties.
4647 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4649 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4651 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4653 * eval.c (internal_condition_case, internal_condition_case_1)
4654 (internal_condition_case_2, internal_condition_case_n):
4655 Remove unnecessary aborts (Bug#9081).
4657 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4659 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4660 has no `load' handler, try opening the file locally. (Bug#9311)
4662 2011-08-16 Ken Brown <kbrown@cornell.edu>
4664 * gmalloc.c: Expand comment.
4666 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4668 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4669 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4671 2011-08-16 Ken Brown <kbrown@cornell.edu>
4673 Fix memory allocation problems in Cygwin build (Bug#9273).
4675 * unexcw.c ( __malloc_initialized): Declare external variable.
4676 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4678 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4680 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4682 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4684 [CYGWIN] (special_realloc): New function.
4685 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4686 requests to realloc storage in the static heap.
4688 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4690 * bidi.c (bidi_initialize): Remove unused local.
4692 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4695 * biditype.h: Remove file.
4696 * makefile.w32-in ($(BLD)/bidi.$(O)):
4697 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4699 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4701 * chartab.c: Improve commentary for the uniprop_table API.
4703 * bidi.c (bidi_paragraph_init): Support zero value of
4704 bidi_ignore_explicit_marks_for_paragraph_level.
4705 (bidi_initialize): Use uniprop_table instead of including
4706 biditype.h and bidimirror.h.
4708 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4709 coordinates of the iterator when restoring from ppos_it.
4712 2011-08-14 Kenichi Handa <handa@m17n.org>
4714 * process.c (create_process): Call setup_process_coding_systems
4715 after the pid of the process is set to -1 (Bug#8162).
4717 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4719 * xdisp.c (move_it_in_display_line_to): Don't invoke
4720 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4721 ppos_it. Fixes vertical cursor motion when line beginning is
4722 covered by an image. (Bug#9296)
4724 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4726 * nsterm.h (ns_run_ascript): Declare.
4727 (NSAPP_DATA2_RUNASSCRIPT): Define.
4729 * nsfns.m (as_script, as_result, as_status): New static variables.
4730 (ns_run_ascript): New function.
4731 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4732 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4733 the event loop. Get status from as_status (Bug#7276).
4735 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4736 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4737 the event loop (Bug#7276).
4739 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4741 * gnutls.c (QCgnutls_bootprop_priority)
4742 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4743 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4744 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4745 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4746 (QCgnutls_bootprop_verify_hostname_error)
4747 (QCgnutls_bootprop_callbacks_verify): Rename from
4748 Qgnutls_bootprop_..., all uses changed.
4750 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4753 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4755 * xfaces.c (Qframe_set_background_mode): Now static.
4756 * dispextern.h (Qframe_set_background_mode): Remove decl.
4758 * process.c (Fnetwork_interface_info): Declare local only if needed.
4760 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4762 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4763 (Fnetwork_interface_list): Allocate in increments of bytes instead
4764 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4765 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4767 (struct ifflag_def): notrailers is smart on OSX.
4768 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4769 Get hardware address with getifaddrs if available.
4771 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4773 * xdisp.c (iterate_out_of_display_property): xassert that
4774 IT->position is set to within IT->object's boundaries. Break from
4775 the loop as soon as EOB is reached; avoids infloops in redisplay
4776 when IT->position is set up wrongly due to some bug.
4777 Set IT->current to match the bidi iterator unconditionally.
4778 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4779 entry. Force push_it to save on the stack the current
4780 buffer/string position, to be restored by pop_it. Fix flags in
4781 the iterator structure wrt the object coming from a display
4782 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4783 properties. (Bug#9284)
4785 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4787 * fontset.c (fontset_get_font_group): Add proper type checks.
4790 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4792 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4793 and LC_VERSION_MIN_MACOSX.
4794 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4795 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4797 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4799 * xdisp.c (forward_to_next_line_start): Allow to use the
4800 no-display-properties-and-no-overlays under bidi display.
4801 Set disp_pos in the bidi iterator to avoid searches for display
4802 properties and overlays.
4804 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4806 * editfns.c (Fset_time_zone_rule): Document relationship with the
4809 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4810 the font entity extracted from the cache (Bug#8109).
4812 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4814 * composite.c (autocmp_chars): Don't reset point. That is done by
4815 restore_point_unwind (Bug#5984).
4817 2011-08-07 Juri Linkov <juri@jurta.org>
4819 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4820 to show the arg `TIME' instead of `TIMEVAL'.
4822 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4824 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4825 display property strides EOL and includes a newline, as in
4826 longlines-mode. (Bug#9254)
4827 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4828 word-wrap under bidirectional display. (Bug#9224)
4830 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4831 is non-zero, even if the data buffer is NULL. Fixes a crash in
4832 vertical-motion with longlines-mode. (Bug#9254)
4834 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4836 * bidi.c <bidi_cache_total_alloc>: Now static.
4837 (bidi_initialize): Initialize bidi_cache_total_alloc.
4839 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4842 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4843 amount allocated this far in `bidi_cache_total_alloc'.
4844 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4845 non-zero, only free the data buffer without restoring the cache
4846 contents. All callers changed.
4848 * dispextern.h (bidi_unshelve_cache): Update prototype.
4850 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4851 (move_it_in_display_line, move_it_to)
4852 (move_it_vertically_backward, move_it_by_lines): Replace the call
4853 to xfree to an equivalent call to bidi_unshelve_cache.
4854 (move_it_in_display_line_to): Fix logic of returning
4855 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4857 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4859 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4860 came from a string character with a `cursor' property. (Bug#9229)
4862 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4864 * Makefile.in (LIB_PTHREAD): New variable.
4865 (LIBES): Add LIB_PTHREAD (Bug#9216).
4867 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4868 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4870 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4872 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4874 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4876 * xterm.c (x_find_topmost_parent): New function.
4877 (x_set_frame_alpha): Find topmost parent window with
4878 x_find_topmost_parent and set the property there also (bug#9181).
4879 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4881 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4883 * callproc.c (Fcall_process): Avoid vfork clobbering
4884 the local vars buffer, coding_systems, current_dir.
4886 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4888 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4890 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4892 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4893 so that it is not optimized away.
4895 * xdisp.c (compute_display_string_pos): Remove unused local.
4897 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4899 Fix slow cursor motion and scrolling in large buffers with
4900 selective display, like Org Mode buffers. (Bug#9218)
4902 * dispextern.h (struct bidi_it): New member disp_prop_p.
4904 * xdisp.c: Remove one-slot cache of display string positions.
4905 (compute_display_string_pos): Accept an additional argument
4906 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4907 for a display string or property. If found, set DISP_PROP_P
4910 * bidi.c (bidi_fetch_char): Accept an additional argument
4911 DISP_PROP_P, and pass it to compute_display_string_pos.
4912 Only handle text covered by a display string if DISP_PROP_P is returned
4913 non-zero. All callers of bidi_fetch_char changed.
4915 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4917 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4919 2010-12-03 Don March <don@ohspite.net>
4921 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4922 last character M-[char] is translated to ESC [char] (bug#7541).
4924 2011-08-02 Kenichi Handa <handa@m17n.org>
4926 * lisp.h (uniprop_table): Extern it.
4928 * chartab.c (uniprop_table): Make it non-static.
4930 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4932 * xdisp.c (forward_to_next_line_start): Accept additional argument
4933 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4935 (reseat_at_next_visible_line_start): Use the bidi iterator state
4936 returned by forward_to_next_line_start to restore the state of
4937 it->bidi_it after backing up to previous newline. (Bug#9212)
4939 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4941 * regex.c (re_comp): Protoize.
4942 (re_exec): Fix return type.
4943 (regexec): Fix type of `ret'. (Bug#9203)
4945 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4947 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4948 This is needed if max-image-size is a floating-point number.
4950 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4952 * print.c (print_object): Print empty symbol as ##.
4954 * lread.c (read1): Read ## as empty symbol.
4956 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4958 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4959 setting frame foreground color (Bug#9175).
4960 (x_set_background_color): Likewise.
4962 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4963 contents (Bug#9176).
4964 (EmacsTooltip -init): Remove bezels and add shadows to
4967 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4968 or scroll bar (Bug#8470).
4970 * nsfont.m (nsfont_open): Remove assignment to voffset and
4971 unnecessary vars hshink, expand, hd, full_height, min_height.
4972 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4974 * nsterm.h (nsfont_info): Remove voffset field.
4976 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4978 Implement strike-through and overline on NextStep (Bug#8863).
4980 * nsfont.m (nsfont_open): Use underline position provided by font,
4981 instead of hard-coded value of 2.
4982 (nsfont_draw): Call ns_draw_text_decoration instead.
4984 * nsterm.h: Add declaration for ns_draw_text_decoration.
4986 * nsterm.m (ns_draw_text_decoration): New function for drawing
4987 underline, overline, and strike-through.
4988 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4989 ns_draw_text_decoration. Change treatment of cursor drawing to
4990 accommodate underlining, etc.
4992 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4994 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4997 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4999 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5000 Without this fix, if a signal arrives just after memory fills up,
5001 'malloc' might be invoked reentrantly.
5003 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5004 In other words, assume that every image size is allowed, on non-X
5005 hosts. This assumption is probably wrong, but it lets Emacs compile.
5007 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5009 * regex.c (re_iswctype): Convert return values to boolean.
5011 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5013 * xdisp.c (compute_display_string_pos): Don't use cached display
5014 string position if the buffer had its restriction changed.
5017 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5019 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5021 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5023 Integer signedness and overflow and related fixes. (Bug#9079)
5025 * bidi.c: Integer size and overflow fixes.
5026 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5027 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5028 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5029 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5030 (bidi_find_other_level_edge):
5031 Use ptrdiff_t instead of EMACS_INT where either will do.
5032 This works better on 32-bit hosts configured --with-wide-int.
5033 (bidi_cache_ensure_space): Check for size-calculation overflow.
5034 Use % rather than repeated addition, for better worst-case speed.
5035 Don't set bidi_cache_size until after xrealloc returns, because it
5037 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5038 (bidi_cache_ensure_space): Also check that the bidi cache size
5039 does not exceed that of the largest Lisp string or buffer. See Eli
5040 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5042 * alloc.c (__malloc_size_t): Remove.
5043 All uses replaced by size_t. See Andreas Schwab's note
5044 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5046 * image.c: Improve checking for integer overflow.
5047 (check_image_size): Assume that f is nonnull, since
5048 it is always nonnull in practice. This is one less thing to
5049 worry about when checking for integer overflow later.
5050 (x_check_image_size): New function, which checks for integer
5051 overflow issues inside X.
5052 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5053 This removes the need for a memory_full check.
5054 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5055 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5056 (xbm_read_bitmap_data): Change locals back to 'int', since
5057 their values must fit in 'int'.
5058 (xpm_load_image, png_load, tiff_load):
5059 Invoke x_create_x_image_and_pixmap earlier,
5060 to avoid much needless work if the image is too large.
5061 (tiff_load): Treat overly large images as if
5062 x_create_x_image_and_pixmap failed, not as malloc failures.
5063 (gs_load): Use x_check_image_size.
5065 * gtkutil.c: Omit integer casts.
5066 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5067 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5069 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5071 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5072 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5073 would wrongly return t on a 64-bit host.
5075 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5076 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5077 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5078 and therefore cause GCC to emit a bogus diagnostic in some cases.
5080 * image.c: Integer signedness and overflow and related fixes.
5081 This is not an exhaustive set of fixes, but it's time to
5082 record what I've got.
5083 (lookup_pixel_color, check_image_size): Remove redundant decls.
5084 (check_image_size): Don't assume that arbitrary EMACS_INT values
5085 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5086 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5087 (tiff_load, imagemagick_load_image):
5088 Check for overflow in size calculations.
5089 (x_create_x_image_and_pixmap): Remove unnecessary test for
5090 xmalloc returning NULL; that can't happen.
5091 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5092 (xpm_color_bucket): Use better integer hashing function.
5093 (xpm_cache_color): Don't possibly over-allocate memory.
5094 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5095 (gif_memory_source):
5096 Use ptrdiff_t, not int or size_t, to record sizes.
5097 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5098 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5099 either works, as we prefer signed integers.
5100 (tiff_read_from_memory, tiff_write_from_memory):
5101 Return tsize_t, not size_t, since that's what the TIFF API wants.
5102 (tiff_read_from_memory): Don't fail simply because the read would
5103 go past EOF; instead, return a short read.
5104 (tiff_load): Omit no-longer-needed casts.
5105 (Fimagemagick_types): Don't assume size fits into 'int'.
5107 Improve hashing quality when configured --with-wide-int.
5108 * fns.c (hash_string): New function, taken from sxhash_string.
5109 Do not discard information about ASCII character case; this
5110 discarding is no longer needed.
5111 (sxhash-string): Use it. Change sig to match it. Caller changed.
5112 * lisp.h: Declare it.
5113 * lread.c (hash_string): Remove, since we now use fns.c's version.
5114 The fns.c version returns a wider integer if --with-wide-int is
5115 specified, so this should help the quality of the hashing a bit.
5117 * emacs.c: Integer overflow minor fix.
5118 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5119 Define only if GNU_LINUX.
5120 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5122 * dispnew.c: Integer signedness and overflow fixes.
5123 Remove unnecessary forward decls, that were a maintenance hassle.
5124 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5126 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5127 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5128 (prepare_desired_row, line_draw_cost):
5129 Use int, not unsigned, where either works.
5130 (save_current_matrix, restore_current_matrix):
5131 Use ptrdiff_t, not size_t, where either works.
5132 (init_display): Check for overflow more accurately, and without
5133 relying on undefined behavior.
5135 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5136 Remove, replacing with the new symbols in lisp.h. All uses changed.
5137 * fileio.c (make_temp_name):
5138 * filelock.c (lock_file_1, lock_file):
5139 * xdisp.c (message_dolog):
5140 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5141 Use pMd etc. instead.
5142 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5143 replacing the pWIDE etc. symbols removed from editfns.c.
5145 * keyboard.h (num_input_events): Now uintmax_t.
5146 This is (very slightly) less likely to mess up due to wraparound.
5149 * buffer.c: Integer signedness fixes.
5150 (alloc_buffer_text, enlarge_buffer_text):
5151 Use ptrdiff_t rather than size_t when either will do, as we prefer
5154 * alloc.c: Integer signedness and overflow fixes.
5155 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5156 (__malloc_size_t): Default to size_t, not to int.
5157 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5158 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5159 Prefer ptrdiff_t to size_t when either would do, as we prefer
5161 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5162 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5163 Now const. Initialize with values that are in range even if char
5165 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5166 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5167 These functions do the right thing with sizes > 2**32.
5168 (check_depth): Now ptrdiff_t, not int.
5169 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5170 Adjust to new way of storing sizes. Check for size overflow bugs
5172 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5173 slightly wrong anyway, as it missed one instance of
5174 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5175 (refill_memory_reserve): Omit needless cast to size_t.
5176 (mark_object_loop_halt): Mark as externally visible.
5178 * xselect.c: Integer signedness and overflow fixes.
5179 (Fx_register_dnd_atom, x_handle_dnd_message):
5180 Use ptrdiff_t, not size_t, since we prefer signed.
5181 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5182 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5183 x_dnd_atoms_size and x_dnd_atoms_length.
5185 * doprnt.c: Prefer signed to unsigned when either works.
5187 * doprnt.c (doprnt):
5189 * xdisp.c (vmessage):
5190 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5191 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5192 prefer signed arithmetic to avoid comparison confusion.
5193 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5194 but is a bit tricky.
5196 Assume freestanding C89 headers, string.h, stdlib.h.
5197 * data.c, doprnt.c, floatfns.c, print.c:
5198 Include float.h unconditionally.
5199 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5200 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5201 * regex.c: Likewise for stddef.h, string.h.
5202 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5203 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5204 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5205 (STDC_HEADERS): Remove obsolete defines.
5206 * sysdep.c: Include limits.h unconditionally.
5208 Assume support for memcmp, memcpy, memmove, memset.
5209 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5210 * regex.c (memcmp, memcpy):
5211 Remove; we assume C89 now.
5213 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5214 (__malloc_safe_bcopy): Remove; no longer needed.
5216 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5217 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5218 well either way, and we prefer signed to unsigned.
5220 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5222 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5223 closes the connection while we're reading (bug#9182).
5225 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5227 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5228 are specified (Bug#9168).
5230 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5232 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5233 Found by GCC static checking and --with-wide-int on a 32-bit host.
5235 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5237 * xdisp.c (compute_display_string_pos): Fix logic of caching
5238 previous display string position. Initialize cached_prev_pos to
5239 -1. Fixes slow-down at the beginning of a buffer.
5241 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5243 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5244 for attrs[LFACE_FONTSET_INDEX].
5246 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5248 * xml.c (parse_region): Remove unused local
5249 that was recently introduced.
5251 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5253 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5254 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5256 * xdisp.c (move_it_in_display_line_to): Record the best matching
5257 position for TO_CHARPOS while scanning the line, and restore it on
5258 exit if none of the characters scanned was an exact match.
5259 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5260 when exact match is impossible due to invisible text, and the
5261 lines are truncated.
5263 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5265 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5268 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5270 Fix a significant slow-down of cursor motion with C-n, C-p,
5271 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5272 auto-repeat under bidi redisplay in fontified buffers.
5273 * xdisp.c (compute_stop_pos_backwards): New function.
5274 (next_element_from_buffer): Call compute_stop_pos_backwards to
5275 find a suitable prev_stop when we find ourselves before
5277 (reseat): Don't look for prev_stop, as that could mean a very long
5279 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5280 <cached_disp_overlay_modiff>: Cache for last found display string
5282 (compute_display_string_pos): Return the cached position if asked
5283 about the same buffer in the same area of character positions, and
5284 the buffer wasn't changed since the time the display string
5285 position was cached.
5287 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5289 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5290 is an integer, which is important for empty lines. (Bug#9149)
5292 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5294 * frame.c (Fmodify_frame_parameters): In tty case, update the
5295 default face if necessary (Bug#4238).
5297 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5299 * editfns.c (Fstring_to_char): No need to explain what a character
5300 is in the docstring (Bug#6576).
5302 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5304 * xml.c (parse_region): Make sure we always return a tree.
5306 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5308 * xml.c (parse_region): If a document contains only comments,
5311 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5313 * xml.c (make_dom): Return comments, too.
5315 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5318 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5319 and the surrounding thread.
5320 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5321 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5322 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5324 * s/openbsd.h (BROKEN_SIGIO): Define.
5325 * unexelf.c (unexec) [__OpenBSD__]:
5326 Don't update the .mdebug section of the Alpha COFF symbol table.
5328 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5330 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5333 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5335 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5336 This fixes some race conditions on the permissions of any newly
5339 * alloc.c (valid_pointer_p): Use pipe, not open.
5340 This fixes some permissions issues when debugging.
5342 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5343 If fchown fails to set both uid and gid, try to set just gid,
5344 as that is sometimes allowed. Adjust the file's mode to eliminate
5345 setuid or setgid bits that are inappropriate if fchown fails.
5347 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5349 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5350 to compare Lisp_Objects.
5351 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5352 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5353 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5355 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5357 * lread.c (read_integer): Unread even EOF character.
5358 (read1): Likewise. Properly record start position of symbol.
5360 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5361 symbol character follows.
5363 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5365 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5366 This works around a problem with the previous change to Fcopy_file.
5367 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5368 and without this change, GCC might complain about discarding
5369 fchown's return value.
5371 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5373 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5375 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5377 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5379 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5381 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5382 it's used from the C level.
5384 * process.c: Use the same condition for POLL_FOR_INPUT in both
5385 keyboard.c and process.c (bug#1858).
5387 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5389 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5390 (Fgnutls_boot): Use it.
5392 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5394 * doc.c (Fsubstitute_command_keys): Revert last change.
5396 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5398 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5399 quotes the next character, and doesn't affect other longer
5400 sequences (bug#8935).
5402 * lread.c (syms_of_lread): Clarify that is isn't only
5403 `eval-buffer' and `eval-defun' that's affected by
5404 `lexical-binding' (bug#8460).
5406 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5408 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5409 bidi redisplay when a line includes both an image and is truncated.
5411 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5413 Fix minor problems found by static checking.
5414 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5415 (elsz): Now a signed constant, not a size_t var. We prefer signed
5416 types to unsigned, to avoid integer comparison confusion. Without
5417 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5418 "cannot optimize loop, the loop counter may overflow", a symptom
5420 * indent.c (Fvertical_motion): Mark locals as initialized.
5421 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5423 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5425 * search.c (Fre_search_backward): Mention `case-fold-search' in
5426 all the re_search_* functions (bug#8138).
5428 * keyboard.c (Fopen_dribble_file): Document when the file is
5431 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5433 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5436 Support bidi reordering of display and overlay strings.
5437 * xdisp.c (compute_display_string_pos)
5438 (compute_display_string_end): Accept additional argument STRING.
5439 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5440 (reseat_to_string): Initialize bidi_it->string.s and
5441 bidi_it->string.schars.
5442 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5443 NULL (avoids a crash in bidi_paragraph_init).
5444 Initialize itb.string.lstring.
5445 (init_iterator): Call bidi_init_it only of a valid
5446 buffer position was specified. Initialize paragraph_embedding to
5448 (reseat_to_string): Initialize the bidi iterator.
5449 (display_string): If we need to ignore text properties of
5450 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5451 original value of -1 will not work with bidi.)
5452 (compute_display_string_pos): First arg is now struct
5453 `text_pos *'; all callers changed. Support display properties on
5455 (compute_display_string_end): Support display properties on Lisp
5457 (init_iterator, reseat_1, reseat_to_string): Initialize the
5458 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5459 when iterating on a string not from display properties).
5460 (compute_display_string_pos, compute_display_string_end):
5461 Fix calculation of the object to scan. Fixes an error when using
5463 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5464 base_level_stop; instead, set base_level_stop to BEGV.
5465 Fixes crashes in vertical-motion.
5466 (next_element_from_buffer): Improve commentary for when
5467 the iterator is before prev_stop.
5468 (init_iterator): Initialize bidi_p from the default value of
5469 bidi-display-reordering, not from buffer-local value. Use the
5470 buffer-local value only if initializing for buffer iteration.
5471 (handle_invisible_prop): Support invisible properties on strings
5472 that are being bidi-reordered.
5473 (set_iterator_to_next): Support bidi reordering of C strings and
5475 (next_element_from_string): Support bidi reordering of Lisp
5477 (handle_stop_backwards): Support Lisp strings as well.
5478 (display_string): Support display of R2L glyph rows.
5479 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5480 (init_iterator): Don't initialize it->bidi_p for strings
5482 (reseat_to_string): Initialize it->bidi_p for strings here.
5483 (next_element_from_string, next_element_from_c_string)
5484 (next_element_from_buffer): Add xassert's for correspondence
5485 between IT's object being iterated and it->bidi_it.string
5487 (face_before_or_after_it_pos): Support bidi iteration.
5488 (next_element_from_c_string): Handle the case of the first string
5489 character that is not the first one in the visual order.
5490 (get_visually_first_element): New function, refactored from common
5491 parts of next_element_from_buffer, next_element_from_string, and
5492 next_element_from_c_string.
5493 (tool_bar_lines_needed, redisplay_tool_bar)
5494 (display_menu_bar): Force left-to-right direction. Add a FIXME
5495 comment for making that be controlled by a user option.
5496 (push_it, pop_it): Save and restore the state of the
5497 bidi iterator. Save and restore the bidi_p flag.
5498 (pop_it): Iterate out of display property for string iteration as
5500 (iterate_out_of_display_property): Support iteration over strings.
5501 (handle_single_display_spec): Set up it->bidi_it for iteration
5502 over a display string, and call bidi_init_it.
5503 (handle_single_display_spec, next_overlay_string)
5504 (get_overlay_strings_1, push_display_prop): Set up the bidi
5505 iterator for displaying display or overlay strings.
5506 (forward_to_next_line_start): Don't use the shortcut if
5508 (back_to_previous_visible_line_start): If handle_display_prop
5509 pushed the iterator stack, restore the internal state of the bidi
5510 iterator by calling bidi_pop_it same number of times.
5511 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5512 and we are bidi-iterating, don't decrement the iterator position;
5513 instead, set the first_elt flag in the bidi iterator, to produce
5515 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5516 (push_display_prop): xassert that we are iterating a buffer.
5517 (push_it, pop_it): Save and restore paragraph_embedding member.
5518 (handle_single_display_spec, next_overlay_string)
5519 (get_overlay_strings_1, reseat_1, reseat_to_string)
5520 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5521 correctly. Don't assume unibyte strings are not bidi-reordered.
5522 (compute_display_string_pos)
5523 (compute_display_string_end): Fix handling the case of C string.
5524 (push_it, pop_it): Save and restore from_disp_prop_p.
5525 (handle_single_display_spec, push_display_prop): Set the
5526 from_disp_prop_p flag.
5527 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5528 (pop_it): Call iterate_out_of_display_property only if we are
5529 popping after iteration over a string that came from a display
5530 property. Fix a typo in popping stretch info. Add an assertion
5531 for verifying that the iterator position is in sync with the bidi
5533 (handle_single_display_spec, get_overlay_strings_1)
5534 (push_display_prop): Fix initialization of paragraph direction for
5535 string when that of the parent object is not yet determined.
5536 (reseat_1): Call bidi_init_it to resync the bidi
5537 iterator with IT's position. (Bug#7616)
5538 (find_row_edges): If ROW->start.pos gives position
5539 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5540 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5541 Reset the from_disp_prop_p flag.
5542 (SAVE_IT, RESTORE_IT): New macros.
5543 (pos_visible_p, face_before_or_after_it_pos)
5544 (back_to_previous_visible_line_start)
5545 (move_it_in_display_line_to, move_it_in_display_line)
5546 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5547 (try_scrolling, redisplay_window, display_line): Use them when
5548 saving a temporary copy of the iterator and restoring it back.
5549 (back_to_previous_visible_line_start, reseat_1)
5550 (init_iterator): Empty the bidi cache "stack".
5551 (move_it_in_display_line_to): If iterator ended up at
5552 EOL, but we never saw any buffer positions smaller than
5553 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5554 motion in bidi-reordered lines.
5555 (move_it_in_display_line_to): Record prev_method and prev_pos
5556 immediately before the call to set_iterator_to_next. Fixes cursor
5557 motion in bidi-reordered lines with stretch glyphs and strings
5558 displayed in margins. (Bug#8133) (Bug#8867)
5559 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5561 (pos_visible_p): Support positions in bidi-reordered lines.
5562 Save and restore bidi cache.
5564 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5565 (bidi_paragraph_info): Delete unused struct.
5566 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5567 (bidi_cache_start): New variable.
5568 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5570 (bidi_cache_fetch_state, bidi_cache_search)
5571 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5572 (bidi_cache_find, bidi_peek_at_next_level)
5573 (bidi_level_of_next_char, bidi_find_other_level_edge)
5574 (bidi_move_to_visually_next): Compare cache index with
5575 bidi_cache_start rather than with zero.
5576 (bidi_fetch_char): Accept new argument STRING; all callers
5577 changed. Support iteration over a string. Support strings with
5578 display properties. Support unibyte strings. Fix the type of
5579 `len' according to what STRING_CHAR_AND_LENGTH expects.
5580 (bidi_paragraph_init, bidi_resolve_explicit_1)
5581 (bidi_resolve_explicit, bidi_resolve_weak)
5582 (bidi_level_of_next_char, bidi_move_to_visually_next):
5583 Support iteration over a string.
5584 (bidi_set_sor_type, bidi_resolve_explicit_1)
5585 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5586 can now be zero (for strings); special values 0 and -1 were
5587 changed to -1 and -2, respectively.
5588 (bidi_char_at_pos): New function.
5589 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5590 Call it instead of FETCH_MULTIBYTE_CHAR.
5591 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5592 initialized to valid values.
5593 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5595 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5596 the test for valid cached positions. Fix the logic for looking up
5597 the sentinel state in the cache. GCPRO the Lisp string we are
5599 (bidi_push_it, bidi_pop_it): New functions.
5600 (bidi_initialize): Initialize the bidi cache start stack pointer.
5601 (bidi_cache_ensure_space): New function, refactored from part of
5602 bidi_cache_iterator_state. Don't assume the required size is just
5603 one BIDI_CACHE_CHUNK away.
5604 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5605 (bidi_count_bytes, bidi_char_at_pos): New functions.
5606 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5607 always valid if bidi_cache_idx is valid.
5608 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5609 is valid if it's going to be used.
5610 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5611 (bidi_cache_fetch_state, bidi_cache_search)
5612 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5613 (bidi_cache_iterator_state, bidi_cache_find)
5614 (bidi_find_other_level_edge, bidi_cache_start_stack):
5615 All variables related to cache indices are now EMACS_INT.
5617 * dispextern.h (struct bidi_string_data): New structure.
5618 (struct bidi_it): New member `string'. Make flag members be 1-bit
5619 fields, and put them last in the struct.
5620 (compute_display_string_pos, compute_display_string_end):
5622 (bidi_push_it, bidi_pop_it): Add prototypes.
5623 (struct iterator_stack_entry): New members bidi_p,
5624 paragraph_embedding, and from_disp_prop_p.
5625 (struct it): Member bidi_p is now a bit field 1 bit wide.
5626 (bidi_shelve_cache, bidi_unshelve_cache):
5629 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5630 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5631 and vector-like objects.
5633 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5634 cache around display iteration.
5636 * window.c (Fwindow_end, window_scroll_pixel_based)
5637 (displayed_window_lines, Frecenter): Save and restore the bidi
5638 cache around display iteration.
5640 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5642 * editfns.c (Fdelete_region): Clarify the use of the named
5643 parameters (bug#6788).
5645 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5647 * indent.c (Fvertical_motion): Set and restore w->pointm when
5648 saving and restoring the window's buffer (Bug#9006).
5650 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5652 * editfns.c (Fstring_to_char): Clarify just what is returned
5653 (bug#6576). Text by Eli Zaretskii.
5655 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5657 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5659 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5661 * buffer.c (mmap_find): Fix a typo.
5663 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5665 Fix execution of x selection hooks.
5666 * xselect.c (Qx_lost_selection_functions)
5667 (Qx_sent_selection_functions): New vars.
5668 (syms_of_xselect): DEFSYM them.
5669 (x_handle_selection_request): Pass Qx_sent_selection_functions
5670 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5671 (x_handle_selection_clear,x_clear_frame_selections):
5672 Pass Qx_lost_selection_functions rather than
5673 Vx_lost_selection_functions to Frun_hook_with_args.
5675 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5677 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5678 The old code sometimes used this field without initializing it.
5680 * alloc.c (gc_sweep): Don't read past end of array.
5681 In theory, the old code could also have corrupted Emacs internals,
5682 though it'd be very unlikely.
5684 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5686 * character.c (Fcharacterp): Don't advertise optional ignored
5687 argument. (Bug#4026)
5689 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5691 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5694 * window.c (Fset_window_start): Doc fix (bug#4199).
5695 (Fset_window_hscroll): Ditto.
5697 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5699 Fix minor new problems caught by GCC 4.6.1.
5700 * term.c (init_tty): Remove unused local.
5701 * xsettings.c (store_monospaced_changed): Define this function only
5702 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5705 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5707 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5709 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5711 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5712 are the mini-buffer and the echo area (bug#3320).
5714 * term.c (init_tty): Remove support for supdup, c10 and perq
5715 terminals, which are no longer supported (bug#1482).
5717 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5719 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5721 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5723 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5724 for non-popups (Bug#3642).
5726 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5728 * alloc.c (reset_malloc_hooks): Protoize.
5729 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5730 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5731 * cm.c (losecursor): Likewise.
5732 * data.c (fmod): Likewise.
5733 * dispnew.c (swap_glyphs_in_rows): Likewise.
5734 * emacs.c (memory_warning_signal): Likewise.
5735 * floatfns.c (float_error): Likewise.
5736 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5737 (otf_open, font_otf_capability, generate_otf_features)
5738 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5740 * image.c (pbm_read_file): Likewise.
5741 * indent.c (string_display_width): Likewise.
5742 * intervals.c (check_for_interval, search_for_interval)
5743 (inc_interval_count, count_intervals, root_interval)
5744 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5745 * lread.c (defalias): Likewise.
5746 * ralloc.c (r_alloc_check): Likewise.
5747 * regex.c (set_image_of_range_1, set_image_of_range)
5748 (regex_grow_registers): Likewise.
5749 * sysdep.c (strerror): Likewise.
5750 * termcap.c (valid_filename_p, tprint, main): Likewise.
5751 * tparam.c (main): Likewise.
5752 * unexhp9k800.c (run_time_remap, save_data_space)
5753 (update_file_ptrs, read_header, write_header, calculate_checksum)
5754 (copy_file, copy_rest, display_header): Likewise.
5755 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5757 * xdisp.c (check_it): Likewise.
5758 * xfaces.c (register_color, unregister_color, unregister_colors):
5760 * xfns.c (print_fontset_result): Likewise.
5761 * xrdb.c (member, fatal, main): Likewise.
5763 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5765 Fix minor problems found by static checking (Bug#9031).
5766 * chartab.c (char_table_set_range, map_sub_char_table):
5767 Remove unused locals.
5768 (uniprop_table): Now static.
5769 * composite.c (_work_char): Remove unused static var.
5771 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5773 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5775 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5777 * gtkutil.c (qttip_cb): Remove code without function.
5779 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5781 * w32.c (pthread_sigmask): New stub.
5783 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5785 Use pthread_sigmask, not sigprocmask (Bug#9010).
5786 sigprocmask is portable only for single-threaded applications, and
5787 Emacs can be multi-threaded when it uses GTK.
5788 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5790 * callproc.c (Fcall_process):
5791 * process.c (create_process):
5792 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5793 Use pthread_sigmask, not sigprocmask.
5795 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5797 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5798 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5801 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5803 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5804 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5805 (xg_hide_tooltip): Fix comment.
5807 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5808 in registerServicesMenuSendTypes.
5809 (validRequestorForSendType): Don't check ns_return_types.
5811 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5814 2011-07-08 Jason Rumney <jasonr@gnu.org>
5816 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5817 SH_SHOW for hidden windows (Bug#5482).
5819 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5820 frame struct members of non-existent frames (Bug#6284).
5822 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5824 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5825 variable firstTime not needed on OSX >= 10.6.
5826 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5827 >= 10.5. Use setKnobProportion, setDoubleValue.
5829 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5830 (MAC_OS_X_VERSION_10_5): Define if not defined.
5831 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5832 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5833 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5835 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5836 cString and lossyCString on OSX >= 10.4
5838 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5839 sizeToFit on OSX >= 10.2.
5841 * nsimage.m (allocInitFromFile): Don't use deprecated method
5842 bestRepresentationForDevice on OSX >= 10.6.
5844 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5847 * emacs.c: Declare unexec_init_emacs_zone.
5849 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5851 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5853 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5854 on svcsMenu (Bug#8842).
5856 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5858 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5860 * nsterm.m (QUTF8_STRING): Declare.
5861 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5862 (validRequestorForSendType): Return type is (id).
5863 Change indexOfObjectIdenticalTo to indexOfObject.
5864 Check if we have local selection before returning self (Bug#8842).
5865 (writeSelectionToPasteboard): Put local selection into paste board
5866 if we have a local selection (Bug#8842).
5867 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5869 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5870 (ns_get_local_selection): Declare.
5872 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5874 * keymap.c (describe_map_tree): Don't insert a double newline at
5875 the end of the buffer (bug#1169) and return whether we inserted
5878 * callint.c (Fcall_interactively): Change "reading args" to
5879 "providing args" to try to clarify what it does (bug#1010).
5881 2011-07-07 Kenichi Handa <handa@m17n.org>
5883 * composite.c (composition_compute_stop_pos): Ignore a static
5884 composition starting before CHARPOS (Bug#8915).
5886 * xdisp.c (handle_composition_prop): Likewise.
5888 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5890 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5893 2011-07-07 Kenichi Handa <handa@m17n.org>
5895 * character.h (unicode_category_t): New enum type.
5897 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5898 (Qchar_code_property_table): New variable.
5899 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5900 (UNIPROP_COMPRESSED_FORM_P): New macros.
5901 (char_table_ascii): Uncompress the compressed values.
5902 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5903 Uncompress the compressed values.
5904 (sub_char_table_ref_and_range): Likewise.
5905 (char_table_ref_and_range): Uncompress the compressed values.
5906 (sub_char_table_set): New arg is_uniprop. Callers changed.
5907 Uncompress the compressed values.
5908 (sub_char_table_set_range): Args changed. Callers changed.
5909 (char_table_set_range): Adjuted for the above change.
5910 (map_sub_char_table): Delete args default_val and parent. Add arg
5911 top. Give decoded values to a Lisp function.
5912 (map_char_table): Adjust for the above change. Give decoded
5913 values to a Lisp function. Gcpro more variables.
5914 (uniprop_table_uncompress)
5915 (uniprop_decode_value_run_length): New functions.
5916 (uniprop_decoder, uniprop_decoder_count): New variables.
5917 (uniprop_get_decoder, uniprop_encode_value_character)
5918 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5920 (uniprop_encoder, uniprop_encoder_count): New variables.
5921 (uniprop_get_encoder, uniprop_table)
5922 (Funicode_property_table_internal, Fget_unicode_property_internal)
5923 (Fput_unicode_property_internal): New functions.
5924 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5925 Sunicode_property_table_internal, Sget_unicode_property_internal,
5926 and Sput_unicode_property_internal. Defvar_lisp
5927 char-code-property-alist.
5929 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5930 Vunicode_category_table.
5932 * font.c (font_range): Adjust for the change of
5933 Vunicode_category_table.
5935 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5937 * m/iris4d.h: Remove file, move contents ...
5938 * s/irix6-5.h: ... here.
5940 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5942 Remove unportable assumption about struct layout (Bug#8884).
5943 * alloc.c (mark_buffer):
5944 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5945 (clone_per_buffer_values): Don't assume that
5946 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5947 This isn't true in general, and it's particularly not true
5948 if Emacs is configured with --with-wide-int.
5949 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5950 New macros, used in the buffer.c change.
5952 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5954 * xsettings.c: Use both GConf and GSettings if both are available.
5955 (store_config_changed_event): Add comment.
5956 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5957 (store_tool_bar_style_changed): New functions.
5958 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5959 (struct xsettings): Move font inside HAVE_XFT.
5960 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5961 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5962 Move inside HAVE_XFT.
5963 (something_changed_gsettingsCB): Rename from something_changedCB.
5964 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5966 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5967 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5968 (something_changed_gconfCB): Rename from something_changedCB.
5969 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5970 (parse_settings): Move check for font inside HAVE_XFT.
5971 (read_settings, apply_xft_settings): Add comment.
5972 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5973 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5974 call store_font_name_changed.
5975 (xft_settings_event): Add comment.
5976 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5977 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5978 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5979 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5980 (xsettings_initialize): Call init_gsettings last.
5981 (xsettings_get_system_font, xsettings_get_system_normal_font):
5984 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5986 Random fixes. E.g., (random) never returned negative values.
5987 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5988 subseconds part to the entropy, as that's a bit more random.
5989 Prefer signed to unsigned, since the signedness doesn't matter and
5990 in general we prefer signed. When given a limit, use a
5991 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5992 latter isn't right if USE_2_TAGS_FOR_INTS.
5993 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5994 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5996 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5998 * textprop.c (text_property_stickiness):
5999 Obey Vtext_property_default_nonsticky.
6000 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6001 * w32fns.c (syms_of_w32fns):
6002 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6004 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6006 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6007 This is more efficient than Ffile_directory_p and avoids a minor race.
6009 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6011 * buffer.c (Foverlay_put): Say what the return value is
6014 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6015 is a directory before asking whether to use the file name
6017 (barf_or_query_if_file_exists): Make the "File is a directory"
6018 error be more correct.
6020 * fns.c (Frequire): Remove the mention of the .gz files, since
6021 that's installation-specific, but keep the mention of
6022 `get-load-suffixes'.
6024 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6026 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6027 Report string overflow if the output is too long.
6029 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6031 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6032 (syms_of_gnutls): Remove duplicate DEFSYM for
6033 Qgnutls_bootprop_verify_hostname_error, an error for
6034 Qgnutls_bootprop_verify_error (which is no longer used).
6036 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6037 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6038 Also (re)move comments that are misplaced or no longer relevant.
6040 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6042 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6044 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6046 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6047 and background color parameters if they have been changed.
6049 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6051 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6053 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6055 * xsettings.c (SYSTEM_FONT): Define only when used.
6056 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6058 * keymap.c (access_keymap_1): Now static.
6060 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6062 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6063 leave any prefix arg for the up event (Bug#1586).
6065 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6067 * lread.c (syms_of_lread): Mention single symbols defined by
6068 `defvar' or `defconst' (bug#7154).
6070 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6071 (Frequire): Mention get-load-suffixes.
6073 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6075 * window.h (window): Remove clone_number slot.
6076 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6078 (make_parent_window, make_window, saved_window)
6079 (Fset_window_configuration, save_window_save): Don't deal with
6081 * buffer.c (Qclone_number): Remove declaration.
6082 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6084 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6086 Add multiple inheritance to keymaps.
6087 * keymap.c (Fmake_composed_keymap): New function.
6088 (Fset_keymap_parent): Simplify.
6089 (fix_submap_inheritance): Remove.
6090 (access_keymap_1): New function extracted from access_keymap to handle
6091 embedded parents and handle lists of maps.
6092 (access_keymap): Use it.
6093 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6094 (Fcopy_keymap): Handle embedded parents.
6095 (Fcommand_remapping, define_as_prefix): Simplify.
6096 (Fkey_binding): Simplify.
6097 (syms_of_keymap): Move minibuffer-local-completion-map,
6098 minibuffer-local-filename-completion-map,
6099 minibuffer-local-must-match-map, and
6100 minibuffer-local-filename-must-match-map to Elisp.
6101 (syms_of_keymap): Defsubr make-composed-keymap.
6102 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6103 (parse_menu_item): Trivial simplification.
6105 2011-07-01 Glenn Morris <rgm@gnu.org>
6107 * Makefile.in (SETTINGS_LIBS): Fix typo.
6109 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6111 * coding.c (Fencode_coding_string): Record the last coding system
6112 used, as the function doc string says (bug#8738).
6114 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6116 * xsettings.c (store_monospaced_changed): Take new font as arg and
6117 check for change against current_mono_font.
6118 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6119 (emacs_settings_constructor, emacs_settings_get_property)
6120 (emacs_settings_set_property, emacs_settings_class_init)
6121 (emacs_settings_init, gsettings_obj): Remove.
6122 (something_changedCB): New function for HAVE_GSETTINGS.
6123 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6124 with value as argument.
6125 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6126 g_settings_new (Bug#8967). Do not create gsettings_obj.
6127 Remove calls to g_settings_bind. Connect something_changedCB to
6130 * xgselect.c: Add defined (HAVE_GSETTINGS).
6131 (xgselect_initialize): Ditto.
6133 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6134 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6137 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6139 * eval.c (struct backtrace): Simplify and port the data structure.
6140 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6141 signed bit field, as this assumption is not portable and it makes
6142 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6143 "char debug_on_exit : 1" as this is not portable either; instead,
6144 use the portable "unsigned int debug_on_exit : 1". Remove unused
6145 member evalargs. Remove obsolete comments about cc bombing out.
6147 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6149 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6150 Let HAVE_GSETTINGS override HAVE_GCONF.
6151 (store_monospaced_changed): New function.
6152 (EMACS_SETTINGS): A new type derived from GObject to handle
6153 GSettings notifications.
6154 (emacs_settings_constructor, emacs_settings_get_property)
6155 (emacs_settings_set_property, emacs_settings_class_init):
6157 (gsettings_client, gsettings_obj): New variables.
6158 (GSETTINGS_SCHEMA): New define.
6159 (something_changedCB): Call store_monospaced_changed.
6160 (init_gsettings): New function.
6161 (xsettings_initialize): Call init_gsettings.
6162 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6165 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6168 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6170 * window.c (resize_root_window, grow_mini_window)
6171 (shrink_mini_window): Rename Qresize_root_window to
6172 Qwindow_resize_root_window and Qresize_root_window_vertically to
6173 Qwindow_resize_root_window_vertically.
6175 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6177 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6179 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6181 * makefile.w32-in: Redesign dependencies so they reflect more
6182 clearly which files are directly included by each source file,
6183 and not through other includes.
6185 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6187 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6188 (sort_overlays, overlay_strings): When an overlay's clone number
6189 matches the window's clone number process the overlay even if
6190 the overlay's window property doesn't match the current window.
6192 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6193 (Fwindow_hchild): Rename to Fwindow_left_child.
6194 (Fwindow_next): Rename to Fwindow_next_sibling.
6195 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6196 (resize_window_check): Rename to window_resize_check.
6197 (resize_window_apply): Rename to window_resize_apply.
6198 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6199 (Fdelete_other_windows_internal, resize_frame_windows)
6200 (Fsplit_window_internal, Fdelete_window_internal)
6201 (grow_mini_window, shrink_mini_window)
6202 (Fresize_mini_window_internal): Fix callers accordingly.
6204 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6206 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6207 (emacs_fixed_set_min_size): Remove.
6208 (emacs_fixed_new): Take frame as argument.
6210 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6211 (_EmacsFixedPrivate): Remove minwidth/height.
6212 Add struct frame *f.
6213 (emacs_fixed_init): Initialize priv->f.
6214 (get_parent_class, emacs_fixed_set_min_size): Remove.
6215 (emacs_fixed_new): Set priv->f to argument.
6216 (emacs_fixed_get_preferred_width)
6217 (emacs_fixed_get_preferred_height): Use min_width/height from
6218 frames size_hint to set minimum and natural (Bug#8919).
6219 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6220 and use min_width/height from frames size_hint to set
6221 min_width/height (Bug#8919).
6223 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6224 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6227 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6229 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6230 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6233 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6235 * process.c (wait_reading_process_output): Bypass select if
6236 waiting for a cell while ignoring keyboard input, and input is
6237 pending. Suggested by Jan Djärv (Bug#8869).
6239 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6241 Use gnulib's dup2 module instead of rolling our own.
6242 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6244 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6246 * dispnew.c (scrolling_window): Before scrolling, turn off a
6247 mouse-highlight in the window being scrolled.
6249 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6251 Move DEFSYM to lisp.h and use everywhere.
6253 * character.h (DEFSYM): Move declaration...
6254 * lisp.h (DEFSYM): ...here.
6260 * w32select.c: Don't include character.h.
6262 * alloc.c (syms_of_alloc):
6263 * buffer.c (syms_of_buffer):
6264 * bytecode.c (syms_of_bytecode):
6265 * callint.c (syms_of_callint):
6266 * casefiddle.c (syms_of_casefiddle):
6267 * casetab.c (init_casetab_once):
6268 * category.c (init_category_once, syms_of_category):
6269 * ccl.c (syms_of_ccl):
6270 * cmds.c (syms_of_cmds):
6271 * composite.c (syms_of_composite):
6272 * dbusbind.c (syms_of_dbusbind):
6273 * dired.c (syms_of_dired):
6274 * dispnew.c (syms_of_display):
6275 * doc.c (syms_of_doc):
6276 * editfns.c (syms_of_editfns):
6277 * emacs.c (syms_of_emacs):
6278 * eval.c (syms_of_eval):
6279 * fileio.c (syms_of_fileio):
6280 * fns.c (syms_of_fns):
6281 * frame.c (syms_of_frame):
6282 * fringe.c (syms_of_fringe):
6283 * insdel.c (syms_of_insdel):
6284 * keymap.c (syms_of_keymap):
6285 * lread.c (init_obarray, syms_of_lread):
6286 * macros.c (syms_of_macros):
6287 * msdos.c (syms_of_msdos):
6288 * print.c (syms_of_print):
6289 * process.c (syms_of_process):
6290 * search.c (syms_of_search):
6291 * sound.c (syms_of_sound):
6292 * syntax.c (init_syntax_once, syms_of_syntax):
6293 * terminal.c (syms_of_terminal):
6294 * textprop.c (syms_of_textprop):
6295 * undo.c (syms_of_undo):
6296 * w32.c (globals_of_w32):
6297 * window.c (syms_of_window):
6298 * xdisp.c (syms_of_xdisp):
6299 * xfaces.c (syms_of_xfaces):
6300 * xfns.c (syms_of_xfns):
6301 * xmenu.c (syms_of_xmenu):
6302 * xsettings.c (syms_of_xsettings):
6303 * xterm.c (syms_of_xterm): Use DEFSYM.
6305 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6307 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6309 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6311 Integer and buffer overflow fixes (Bug#8873).
6313 * print.c (printchar, strout): Check for string overflow.
6314 (PRINTPREPARE, printchar, strout):
6315 Don't set size unless allocation succeeds.
6317 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6318 for sizes. Check for string overflow more accurately.
6319 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6321 * macros.c: Integer and buffer overflow fixes.
6322 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6323 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6324 Use ptrdiff_t, not int, for sizes.
6325 Don't increment bufsize until after realloc succeeds.
6326 Check for size-calculation overflow.
6327 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6329 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6331 * lread.c: Integer overflow fixes.
6332 (read_integer): Radix is now EMACS_INT, not int,
6333 to improve quality of diagnostics for out-of-range radices.
6334 Calculate buffer size correctly for out-of-range radices.
6335 (read1): Check for integer overflow in radices, and in
6336 read-circle numbers.
6337 (read_escape): Avoid int overflow.
6338 (Fload, openp, read_buffer_size, read1)
6339 (substitute_object_recurse, read_vector, read_list, map_obarray):
6340 Use ptrdiff_t, not int, for sizes.
6341 (read1): Use EMACS_INT, not int, for sizes.
6342 Check for size overflow.
6344 * image.c (cache_image): Check for size arithmetic overflow.
6346 * lread.c: Integer overflow issues.
6347 (saved_doc_string_size, saved_doc_string_length)
6348 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6349 Now ptrdiff_t, not int.
6350 (read1): Don't assume doc string length fits in int. Check for
6351 out-of-range doc string lengths.
6352 (read_list): Don't assume file position fits in int.
6353 (read_escape): Check for hex character overflow.
6355 2011-06-22 Leo Liu <sdl.web@gmail.com>
6357 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6358 Move to minibuffer.el.
6360 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6362 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6363 The following patches are for when GLYPH_DEBUG && !XASSERT.
6364 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6365 * dispnew.c (flush_stdout):
6366 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6367 Mark as externally visible.
6368 * dispnew.c (check_window_matrix_pointers): Now static.
6369 * dispnew.c (window_to_frame_vpos):
6370 * xfns.c (unwind_create_frame):
6371 * xterm.c (x_check_font): Remove unused local.
6372 * scroll.c (CHECK_BOUNDS):
6373 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6374 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6375 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6376 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6377 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6379 (debug_method_add): Use va_list and vsprintf rather than relying
6380 on undefined behavior with wrong number of arguments.
6381 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6382 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6383 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6384 since we're not interested in debugging glyphs with old libraries.
6385 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6386 GCC 4.6.0's static checking.
6388 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6390 Integer overflow and signedness fixes (Bug#8873).
6391 A few related buffer overrun fixes, too.
6393 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6395 * dispextern.h (struct face.stipple):
6396 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6397 (x_bitmap_mask, x_allocate_bitmap_record)
6398 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6399 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6400 (x_create_bitmap_from_xpm_data):
6401 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6402 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6404 * xfaces.c (load_pixmap):
6405 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6406 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6407 (.bitmaps_last, struct x_output.icon_bitmap):
6408 Use ptrdiff_t, not int, for bitmap indexes.
6409 (x_allocate_bitmap_record): Check for size overflow.
6410 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6412 Use ptrdiff_t, not int, for overlay counts.
6413 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6414 * editfns.c (overlays_around, get_pos_property):
6415 * textprop.c (get_char_property_and_overlay):
6416 * xdisp.c (next_overlay_change, note_mouse_highlight):
6417 * xfaces.c (face_at_buffer_position):
6418 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6419 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6420 (Fnext_overlay_change, Fprevious_overlay_change)
6421 (mouse_face_overlay_overlaps, Foverlays_in):
6422 Use ptrdiff_t, not int, for sizes.
6423 (overlays_at, overlays_in): Check for size-calculation overflow.
6425 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6427 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6428 (x_session_initialize): Do not assume string length fits in int.
6430 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6431 This is unlikely, but can occur if DPI is outlandish.
6433 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6434 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6436 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6437 * xrdb.c (magic_file_p, search_magic_path):
6438 Omit last arg SUFFIX; it was always 0. All callers changed.
6439 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6441 * xfont.c (xfont_match): Avoid need for strlen.
6443 * xfns.c: Don't assume strlen fits in int.
6444 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6446 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6447 not unsigned long, as we prefer signed integers. All callers changed.
6448 Detect integer overflow in repeat count.
6449 (message_dolog): Don't assume print length fits in 39 bytes.
6450 (display_mode_element): Don't assume strlen fits in int.
6452 * termcap.c: Don't assume sizes fit in int and never overflow.
6453 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6454 (gobble_line): Check for size-calculation overflow.
6456 * minibuf.c (Fread_buffer):
6457 * lread.c (intern, intern_c_string):
6458 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6459 Don't assume string length fits in int.
6461 * keyboard.c (parse_tool_bar_item):
6462 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6464 * font.c: Don't assume string length fits in int.
6465 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6466 Use ptrdiff_t, not int.
6467 (font_intern_prop): Don't assume string length fits in int.
6468 Don't assume integer property fits in fixnum.
6469 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6471 * filelock.c: Fix some buffer overrun and integer overflow issues.
6472 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6473 Reformulate so as not to need the command string.
6474 Invoke gzip -cd rather than gunzip, as it's more portable.
6475 (lock_info_type, lock_file_1, lock_file):
6476 Don't assume pid_t and time_t fit in unsigned long.
6477 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6478 (current_lock_owner): Prefer signed type for sizes.
6479 Use memcpy, not strncpy, where memcpy is what is really wanted.
6480 Don't assume (via atoi) that time_t and pid_t fit in int.
6481 Check for time_t and/or pid_t out of range, e.g., via a network share.
6482 Don't alloca where an auto var works fine.
6484 * fileio.c: Fix some integer overflow issues.
6485 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6486 Don't assume string length fits in int.
6487 (directory_file_name): Don't assume string length fits in long.
6488 (make_temp_name): Don't assume pid fits in int, or that its print
6489 length is less than 20.
6491 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6493 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6495 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6497 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6498 We prefer signed integers, even for size calculations.
6500 * emacs.c: Don't assume string length fits in 'int'.
6501 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6502 (main): Don't invoke strlen when not needed.
6504 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6505 (XD_DEBUG_MESSAGE): Don't waste a byte.
6507 * callproc.c (getenv_internal_1, getenv_internal)
6509 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6511 * lread.c (invalid_syntax): Omit length argument.
6512 All uses changed. This doesn't fix a bug, but it simplifies the
6513 code away from its former Hollerith-constant appearance, and it's
6514 one less 'int' to worry about when looking at integer-overflow issues.
6515 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6517 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6518 This didn't break anything, but it didn't help either.
6519 It's confusing to put a bogus integer in a place where the actual
6520 value does not matter.
6521 (LIST_END_P): Remove unused macro and its bogus comment.
6522 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6524 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6525 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6527 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6528 We prefer signed types, and the value cannot exceed the EMACS_INT
6529 range anyway (because otherwise the length would not be representable).
6530 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6531 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6532 This avoids a GCC warning when WIDE_EMACS_INT.
6534 * indent.c (sane_tab_width): New function.
6535 (current_column, scan_for_column, Findent_to, position_indentation)
6536 (compute_motion): Use it. This is just for clarity.
6537 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6539 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6541 * lisp.h (lint_assume): New macro.
6542 * composite.c (composition_gstring_put_cache):
6543 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6545 * editfns.c, insdel.c:
6546 Omit unnecessary forward decls, to simplify future changes.
6548 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6550 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6552 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6553 Use much-faster test for byte-length change.
6554 Don't assume string byte-length fits in 'int'.
6555 Check that character arg fits in 'int'.
6556 (mapcar1): Declare byte as byte, for clarity.
6558 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6560 * fns.c (concat): Catch string overflow earlier.
6561 Do not rely on integer wraparound.
6563 * dispextern.h (struct it.overlay_strings_charpos)
6564 (struct it.selective): Now EMACS_INT, not int.
6565 * xdisp.c (forward_to_next_line_start)
6566 (back_to_previous_visible_line_start)
6567 (reseat_at_next_visible_line_start, next_element_from_buffer):
6568 Don't arbitrarily truncate the value of 'selective' to int.
6570 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6572 * composite.c: Don't truncate sizes to 'int'.
6573 (composition_gstring_p, composition_reseat_it)
6574 (composition_adjust_point): Use EMACS_INT, not int.
6575 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6576 not EMACS_UINT, for indexes.
6578 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6580 * buffer.c: Include <verify.h>.
6581 (struct sortvec.priority, struct sortstr.priority):
6582 Now EMACS_INT, not int.
6583 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6584 (struct sortstr.size, record_overlay_string)
6585 (struct sortstrlist.size, struct sortlist.used):
6586 Don't truncate size to int.
6587 (record_overlay_string): Check for size-calculation overflow.
6588 (init_buffer_once): Check at compile-time, not run-time.
6590 2011-06-22 Jim Meyering <meyering@redhat.com>
6592 Don't leak an XBM-image-sized buffer
6593 * image.c (xbm_load): Free the image buffer after using it.
6595 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6598 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6599 that Sun C diagnosed.
6600 * fns.c (secure_hash): Fix pointer signedness issue.
6601 * intervals.c (static_offset_intervals): New function.
6602 (offset_intervals): Use it.
6604 2011-06-21 Leo Liu <sdl.web@gmail.com>
6607 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6610 * fns.c (secure_hash): Rename from crypto_hash_function and change
6611 the first arg to accept symbols.
6612 (Fsecure_hash): New primitive.
6613 (syms_of_fns): New symbols.
6615 2011-06-20 Deniz Dogan <deniz@dogan.se>
6617 * process.c (Fset_process_buffer): Clarify return value in
6620 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6622 * dispnew.c (add_window_display_history): Use BVAR.
6624 * xdisp.c (debug_method_add): Use BVAR.
6625 (check_window_end, dump_glyph_matrix, dump_glyph)
6626 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6628 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6631 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6632 check till after the cache is created in init_frame_faces.
6634 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6636 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6638 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6640 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6641 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6642 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6644 Improve buffer-overflow checking (Bug#8873).
6645 * fileio.c (Finsert_file_contents):
6646 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6647 Remove the old (too-loose) buffer overflow checks.
6648 They weren't needed, since make_gap checks for buffer overflow.
6649 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6650 The old code merely checked for Emacs fixnum overflow, and relied
6651 on undefined (wraparound) behavior. The new code avoids undefined
6652 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6654 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6655 Tune. Don't use wider integers than needed. Don't use alloca.
6656 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6658 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6660 * insdel.c, lisp.h (buffer_overflow): New function.
6661 (insert_from_buffer_1, replace_range, replace_range_2):
6662 * insdel.c (make_gap_larger):
6663 * editfns.c (Finsert_char):
6664 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6666 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6668 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6670 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6672 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6673 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6675 * fileio.c: Don't assume EMACS_INT fits in off_t.
6676 (emacs_lseek): New static function.
6677 (Finsert_file_contents, Fwrite_region): Use it.
6678 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6680 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6682 * fns.c: Don't overflow int when computing a list length.
6683 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6684 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6685 truncation on 64-bit hosts. Check for QUIT every
6686 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6687 faster and is responsive enough.
6688 (Flength): Report an error instead of overflowing an integer.
6689 (Fsafe_length): Return a float if the value is not representable
6690 as a fixnum. This shouldn't happen except in contrived situations.
6691 (Fnthcdr, Fsort): Don't assume list length fits in int.
6692 (Fcopy_sequence): Don't assume vector length fits in int.
6694 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6695 (header_size, word_size): New constants.
6696 (allocate_vectorlike): Don't check size overflow here.
6697 (allocate_vector): Check it here instead, since this is the only
6698 caller of allocate_vectorlike that could cause overflow.
6699 Check that the new vector's length is representable as a fixnum.
6701 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6702 The previous code was bogus. For example, next_almost_prime (32)
6703 returned 39, which is undesirable as it is a multiple of 3; and
6704 next_almost_prime (24) returned 25, which is a multiple of 5 so
6705 why was the code bothering to check for multiples of 7?
6707 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6709 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6711 Variadic C functions now count arguments with ptrdiff_t.
6712 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6713 Back then I didn't know that the Emacs coding style prefers signed int.
6714 Also, in the meantime I found a few more instances where arguments
6715 were being counted with int, which may truncate counts on 64-bit
6716 machines, or EMACS_INT, which may be unnecessarily wide.
6717 * lisp.h (struct Lisp_Subr.function.aMANY)
6718 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6719 Arg counts are now ptrdiff_t, not size_t.
6720 All variadic functions and their callers changed accordingly.
6721 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6722 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6723 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6724 * callint.c (Fcall_interactively): Check arg count for overflow,
6725 to avoid potential buffer overrun. Use signed char, not 'int',
6726 for 'varies' array, so that we needn't bother to check its size
6727 calculation for overflow.
6728 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6729 * eval.c (apply_lambda):
6730 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6731 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6732 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6734 * callint.c (Fcall_interactively): Don't use index var as event count.
6736 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6737 * mem-limits.h (SIZE): Remove; no longer used.
6739 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6741 Remove unnecessary casts.
6742 * xterm.c (x_term_init):
6743 * xfns.c (x_set_border_pixel):
6744 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6745 These aren't needed now that we assume ANSI C.
6747 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6748 It's more likely to cause problems (due to unsigned overflow)
6751 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6753 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6755 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6757 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6759 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6761 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6763 GLYPH_CODE_FACE returns EMACS_INT, not int.
6764 * dispextern.h (merge_faces):
6765 * xfaces.c (merge_faces):
6766 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6767 Don't assume EMACS_INT fits in int.
6769 * character.h (CHAR_VALID_P): Remove unused parameter.
6770 * fontset.c, lisp.h, xdisp.c: All uses changed.
6772 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6774 * fns.c (concat): Minor tuning based on overflow analysis.
6775 This doesn't fix any bugs. Use int to hold character, instead
6776 of constantly refetching from Emacs object. Use XFASTINT, not
6777 XINT, for value known to be a character. Don't bother comparing
6778 a single byte to 0400, as it's always less.
6780 * floatfns.c (Fexpt):
6781 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6783 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6786 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6788 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6789 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6790 incorrectly succeed when S was a string, because 4294967386 was
6791 truncated before it was used.
6793 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6794 Otherwise, an out-of-range integer could cause undefined behavior
6797 * composite.c: Use int, not EMACS_INT, for characters.
6798 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6799 EMACS_INT, for values that are known to be in character range.
6800 This doesn't fix any bugs but is the usual style inside Emacs and
6801 may generate better code on 32-bit machines.
6803 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6804 This is for reasons similar to the recent CHAR_STRING fix.
6805 * charset.c (Fencode_char): Check that character arg is actually
6806 a character. Pass an int to ENCODE_CHAR.
6807 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6808 wider than 'int', as a compile-time check to prevent future regressions
6811 * character.c (char_string): Remove unnecessary casts.
6813 Make sure a 64-bit char is never passed to CHAR_STRING.
6814 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6815 by silently ignoring the top 32 bits, allowing some values
6816 that were far too large to be valid characters.
6817 * character.h: Include <verify.h>.
6818 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6819 arguments are no wider than unsigned, as a compile-time check
6820 to prevent future regressions in this area.
6822 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6823 (Fsubst_char_in_region):
6825 * xdisp.c (decode_mode_spec_coding):
6826 Adjust to CHAR_STRING's new requirement.
6827 * editfns.c (Finsert_char, Fsubst_char_in_region):
6828 * fns.c (concat): Check that character args are actually
6829 characters. Without this test, these functions did the wrong
6830 thing with wildly out-of-range values on 64-bit hosts.
6832 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6833 These casts should not be needed on 32-bit hosts, either.
6834 * keyboard.c (read_char):
6835 * lread.c (Fload): Remove casts to unsigned.
6837 * lisp.h (UNSIGNED_CMP): New macro.
6838 This fixes comparison bugs on 64-bit hosts.
6839 (ASCII_CHAR_P): Use it.
6840 * casefiddle.c (casify_object):
6841 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6842 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6843 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6844 * dispextern.h (FACE_FROM_ID):
6845 * keyboard.c (read_char): Use UNSIGNED_CMP.
6847 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6848 not to EMACS_INT, to avoid GCC warning.
6850 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6852 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6853 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6854 isn't needed on 32-bit machines.
6856 * buffer.c (Fgenerate_new_buffer_name):
6857 Use EMACS_INT for count, not int.
6858 (advance_to_char_boundary): Return EMACS_INT, not int.
6860 * data.c (Qcompiled_function): Now static.
6862 * window.c (window_body_lines): Now static.
6864 * image.c (gif_load): Rename local to avoid shadowing.
6866 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6867 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6868 * alloc.c (make_save_value): Integer argument is now of type
6870 (mark_object): Use ptrdiff_t, not int.
6871 * lisp.h (pD): New macro.
6872 * print.c (print_object): Use it.
6874 * alloc.c: Use EMACS_INT, not int, to count objects.
6875 (total_conses, total_markers, total_symbols, total_vector_size)
6876 (total_free_conses, total_free_markers, total_free_symbols)
6877 (total_free_floats, total_floats, total_free_intervals)
6878 (total_intervals, total_strings, total_free_strings):
6879 Now EMACS_INT, not int. All uses changed.
6880 (Fgarbage_collect): Compute overall total using a double, so that
6881 integer overflow is less likely to be a problem. Check for overflow
6882 when converting back to an integer.
6883 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6884 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6885 These were 'int' variables that could overflow on 64-bit hosts;
6886 they were never used, so remove them instead of repairing them.
6887 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6888 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6889 Previously, this ceilinged at INT_MAX, but that doesn't work on
6891 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6893 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6894 (allocate_vectorlike): Check for ptrdiff_t overflow.
6895 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6896 when a (possibly-narrower) signed value would do just as well.
6897 We prefer using signed arithmetic, to avoid comparison confusion.
6899 * alloc.c: Catch some string size overflows that we were missing.
6900 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6901 for convenience in STRING_BYTES_MAX.
6902 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6903 The definition here is exact; the one in lisp.h was approximate.
6904 (allocate_string_data): Check for string overflow. This catches
6905 some instances we weren't catching before. Also, it catches
6906 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6907 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6908 and ptrdiff_t and EMACS_INT are both 64 bits.
6910 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6911 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6912 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6914 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6916 * alloc.c (Fmake_string): Check for out-of-range init.
6918 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6920 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6922 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6924 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6925 xg_get_default_scrollbar_width.
6927 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6928 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6929 (style_changed_cb): Call update_theme_scrollbar_width and call
6930 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6931 all frames (Bug#8505).
6932 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6933 Call gtk_window_set_resizable if HAVE_GTK3.
6934 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6935 and height if HAVE_GTK3 (Bug#8505).
6936 (scroll_bar_width_for_theme): New variable.
6937 (update_theme_scrollbar_width): New function.
6938 (xg_get_default_scrollbar_width): Move code to
6939 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6940 (xg_initialize): Call update_theme_scrollbar_width.
6942 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6944 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6946 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6948 * frame.c (make_frame): Call other_buffer_safely instead of
6951 * window.c (temp_output_buffer_show): Call display_buffer with
6952 second argument Vtemp_buffer_show_specifiers and reset latter
6953 immediately after the call.
6954 (Vtemp_buffer_show_specifiers): New variable.
6955 (auto_window_vscroll_p, next_screen_context_lines)
6956 (Vscroll_preserve_screen_position): Remove leading asterisks from
6959 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6961 Fix minor problems found by GCC 4.6.0 static checking.
6962 * buffer.c (Qclone_number): Remove for now, as it's unused.
6963 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6964 (record_buffer): Remove unused local.
6965 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6966 (set_frame_buffer_list): Remove; unused.
6967 * frame.h (other_visible_frames): Remove decl.
6968 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6969 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6970 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6972 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6973 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6974 Define only if HAVE_GPM.
6975 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6976 (update_hints_inhibit): Remove; never set. All uses removed.
6977 * widgetprv.h (emacsFrameClassRec): Remove decl.
6978 * window.c (delete_deletable_window): Now returns void, since it
6979 wasn't returning anything.
6980 (compare_window_configurations): Remove unused locals.
6981 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6982 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6983 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6984 the same widths as pointers. This follows up on the 2011-05-06 patch.
6985 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6986 * xterm.h: Likewise.
6987 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6989 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6991 * makefile.w32-in: Update dependencies.
6992 (LISP_H): Add lib/intprops.h.
6994 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6996 * image.c (gif_load): Add animation frame delay to the metadata.
6997 (syms_of_image): Use DEFSYM. New symbol `delay'.
6999 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7001 * window.c (delete_deletable_window): Re-add.
7002 (Fset_window_configuration): Rewrite to handle dead buffers and
7003 consequently deletable windows.
7004 (window_tree, Fwindow_tree): Remove. Supply functionality in
7006 (compare_window_configurations): Simplify code.
7008 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7010 * image.c (imagemagick_load_image): Fix type mismatch.
7011 (Fimagemagick_types): Likewise.
7013 * window.h (replace_buffer_in_windows): Declare.
7015 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7017 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7018 Qclone_number. Remove external declaration of Qdelete_window.
7019 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7021 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7022 Run Qbuffer_list_update_hook if allowed.
7023 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7024 buffer list implementation.
7025 (other_buffer_safely): New function.
7026 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7027 calls to replace_buffer_in_windows and
7028 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7030 (record_buffer): Inhibit quitting and rewrite using quittable
7031 functions. Run Qbuffer_list_update_hook if allowed.
7032 (Frecord_buffer, Funrecord_buffer): New functions.
7033 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7034 Move switch-to-buffer to window.el.
7035 (bury-buffer): Move to window.el.
7036 (Vbuffer_list_update_hook): New variable.
7038 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7041 * window.h (resize_frame_windows): Move up in code.
7042 (Fwindow_frame): Remove EXFUN.
7043 (replace_buffer_in_all_windows): Remove prototype.
7044 (replace_buffer_in_windows_safely): Add prototype.
7046 * window.c: Declare Qdelete_window static again. Move down
7047 declaration of select_count.
7048 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7049 (Fother_window): Move to window.el.
7050 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7051 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7052 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7054 (replace_buffer_in_windows): Implement by calling
7055 Qreplace_buffer_in_windows.
7056 (replace_buffer_in_all_windows): Remove with some functionality
7057 moved into replace_buffer_in_windows_safely.
7058 (replace_buffer_in_windows_safely): New function.
7059 (select_window_norecord, select_frame_norecord): Move in front
7060 of run_window_configuration_change_hook. Remove now obsolete
7062 (Fset_window_buffer): Rewrite doc-string.
7063 Call Qrecord_window_buffer.
7064 (keys_of_window): Move binding for other-window to window.el.
7066 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7068 * dispextern.h (struct image): Replace data member, whose int_val
7069 and ptr_val fields were not used by anything, with a single
7072 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7073 (gif_clear_image, gif_load, imagemagick_load_image)
7074 (gs_clear_image, gs_load): Callers changed.
7076 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7078 * buffer.h: Include <time.h>, for time_t.
7079 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7081 Fix minor problems found by static checking.
7083 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7085 Make identifiers static if they are not used in other modules.
7086 * data.c (Qcompiled_function, Qframe, Qvector):
7087 * image.c (QimageMagick, Qsvg):
7088 * minibuf.c (Qmetadata):
7089 * window.c (resize_window_check, resize_root_window): Now static.
7090 * window.h (resize_window_check, resize_root_window): Remove decls.
7092 * window.c (window_deletion_count, delete_deletable_window):
7094 (window_body_lines): Now static.
7095 (Fdelete_other_windows_internal): Mark vars as initialized.
7096 Make sure 'resize_failed' is initialized.
7097 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7098 (resize_window_apply): Remove unused local.
7099 * window.h (delete_deletable_window): Remove decl.
7101 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7102 (imagemagick_load_image): Fix pointer signedness problem by changing
7103 last arg from unsigned char * to char *. All uses changed.
7104 Also, fix a local for similar reasons.
7105 Remove unused locals. Remove locals to avoid shadowing.
7106 (fn_rsvg_handle_free): Remove; unused.
7107 (svg_load, svg_load_image): Fix pointer signedness problem.
7108 (imagemagick_load_image): Don't use garbage pointer image_wand.
7110 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7112 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7114 * image.c (gif_load): Fix omitted cast error introduced by
7117 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7119 * window.h (resize_proportionally, orig_total_lines)
7120 (orig_top_line): Remove from window structure.
7121 (set_window_height, set_window_width, change_window_heights)
7122 (Fdelete_window): Remove prototypes.
7123 (resize_frame_windows): Remove duplicate declaration.
7125 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7127 * window.h (resize_frame_windows, resize_window_check)
7128 (delete_deletable_window, resize_root_window)
7129 (resize_frame_windows): Declare prototypes.
7131 * window.c (resize_window_apply): Make definition be "static" to
7132 match the prototype.
7134 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7136 * window.c: Remove declarations of Qwindow_size_fixed,
7137 window_min_size_1, window_min_size_2, window_min_size,
7138 size_window, window_fixed_size_p, enlarge_window, delete_window.
7139 Remove static from declaration of Qdelete_window, it's
7140 temporarily needed by Fbury_buffer.
7141 (replace_window): Don't assign orig_top_line and
7143 (Fdelete_window, delete_window): Remove. Window deletion is
7144 handled by window.el.
7145 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7146 Replace Fdelete_window calls with calls to Qdelete_window.
7147 (Fdelete_other_windows): Remove. Deleting other windows is
7148 handled by window.el.
7149 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7150 handled in window.el.
7151 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7152 Window minimum sizes are handled in window.el.
7153 (shrink_windows, size_window, set_window_height)
7154 (set_window_width, change_window_heights, window_height)
7155 (window_width, CURBEG, CURSIZE, enlarge_window)
7156 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7157 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7158 handled in window.el.
7159 (make_dummy_parent): Rename to make_parent_window and give it a
7160 second argument horflag.
7161 (make_window): Don't set resize_proportionally any more.
7162 (Fsplit_window): Remove. Windows are split in window.el.
7163 (save_restore_action, save_restore_orig_size)
7164 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7165 Resize mini windows in window.el.
7166 (grow_mini_window, shrink_mini_window): Implement by calling
7167 Qresize_root_window_vertically, resize_window_check and
7168 resize_window_apply.
7169 (saved_window, Fset_window_configuration, save_window_save):
7170 Do not handle orig_top_line, orig_total_lines, and
7171 resize_proportionally.
7172 (window_min_height, window_min_width): Move to window.el.
7173 (keys_of_window): Move bindings for delete-other-windows,
7174 split-window, delete-window and enlarge-window to window.el.
7176 * buffer.c: Temporarily extern Qdelete_window.
7177 (Fbury_buffer): Temporarily call Qdelete_window instead of
7178 Fdelete_window (Fbury_buffer will move to window.el soon).
7180 * frame.c (set_menu_bar_lines_1): Remove code handling
7181 orig_top_line and orig_total_lines.
7183 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7184 set_window_height but set heights directly.
7185 (change_frame_size_1): Use resize_frame_windows.
7187 * xdisp.c (init_xdisp): Don't use set_window_height but set
7190 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7191 Use resize_frame_windows instead of change_window_heights and run
7192 run_window_configuration_change_hook.
7194 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7195 instead of change_window_heights and run
7196 run_window_configuration_change_hook.
7198 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7200 * window.c (replace_window): Rename second argument REPLACEMENT to
7201 NEW. New third argument SETFLAG. Rewrite.
7202 (delete_window, make_dummy_parent): Call replace_window with
7204 (window_list_1): Move down in code.
7205 (run_window_configuration_change_hook): Move set_buffer part
7206 before select_frame_norecord part in order to unwind correctly.
7207 Rename count1 to count.
7208 (recombine_windows, delete_deletable_window, resize_root_window)
7209 (Fdelete_other_windows_internal)
7210 (Frun_window_configuration_change_hook, make_parent_window)
7211 (resize_window_check, resize_window_apply, Fresize_window_apply)
7212 (resize_frame_windows, Fsplit_window_internal)
7213 (Fdelete_window_internal, Fresize_mini_window_internal):
7215 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7217 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7219 * window.h (window): Add some new members to window structure -
7220 normal_lines, normal_cols, new_total, new_normal, clone_number,
7221 splits, nest, prev_buffers, next_buffers.
7222 (WINDOW_TOTAL_SIZE): Move here from window.c.
7223 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7225 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7227 (make_dummy_parent): Set new members of windows structure.
7228 (make_window): Move down in code. Handle new members of window
7230 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7231 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7232 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7233 (Fset_window_prev_buffers, Fwindow_next_buffers)
7234 (Fset_window_next_buffers, Fset_window_clone_number):
7236 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7237 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7239 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7240 Argument WINDOW can be now internal window too.
7241 (Fwindow_use_time): Move up in code.
7242 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7244 (Fset_window_configuration, saved_window)
7245 (Fcurrent_window_configuration, save_window_save): Handle new
7246 members of window structure.
7247 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7248 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7249 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7250 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7251 Qget_mru_window, Qresize_root_window,
7252 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7253 Qauto_buffer_name; staticpro them.
7255 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7257 * window.c (Fwindow_total_size, Fwindow_left_column)
7258 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7259 (Fwindow_list_1): New functions.
7260 (window_box_text_cols): Replace with window_body_cols.
7261 (Fwindow_width, Fscroll_left, Fscroll_right):
7262 Use window_body_cols instead of window_box_text_cols.
7263 (delete_window, Fset_window_configuration):
7264 Call delete_all_subwindows with window as argument.
7265 (delete_all_subwindows): Take a window as argument and not a
7267 (window_loop): Remove handling of GET_LRU_WINDOW and
7269 (Fget_lru_window, Fget_largest_window): Move to window.el.
7271 * window.h: Extern window_body_cols instead of
7272 window_box_text_cols. delete_all_subwindows now takes a
7273 Lisp_Object as argument.
7275 * indent.c (compute_motion, Fcompute_motion):
7276 Use window_body_cols instead of window_box_text_cols.
7278 * frame.c (delete_frame): Call delete_all_subwindows with root
7281 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7283 * fns.c (Fputhash): Document return value.
7285 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7287 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7289 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7291 Cons<->int and similar integer overflow fixes (Bug#8794).
7293 Check for overflow when converting integer to cons and back.
7294 * charset.c (Fdefine_charset_internal, Fdecode_char):
7295 Use cons_to_unsigned to catch overflow.
7296 (Fencode_char): Use INTEGER_TO_CONS.
7297 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7298 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7299 * data.c (long_to_cons, cons_to_long): Remove.
7300 (cons_to_unsigned, cons_to_signed): New functions.
7301 These signal an error for invalid or out-of-range values.
7302 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7303 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7304 * font.c (Ffont_variation_glyphs):
7305 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7306 * lisp.h: Include <intprops.h>.
7307 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7308 (cons_to_signed, cons_to_unsigned): New decls.
7309 (long_to_cons, cons_to_long): Remove decls.
7310 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7311 (Fprimitive_undo): Use CONS_TO_INTEGER.
7312 * xfns.c (Fx_window_property): Likewise.
7313 * xselect.c: Include <limits.h>.
7314 (x_own_selection, selection_data_to_lisp_data):
7315 Use INTEGER_TO_CONS.
7316 (x_handle_selection_request, x_handle_selection_clear)
7317 (x_get_foreign_selection, Fx_disown_selection_internal)
7318 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7319 (lisp_data_to_selection_data): Use cons_to_unsigned.
7320 (x_fill_property_data): Use cons_to_signed.
7321 Report values out of range.
7323 Check for buffer and string overflow more precisely.
7324 * buffer.h (BUF_BYTES_MAX): New macro.
7325 * lisp.h (STRING_BYTES_MAX): New macro.
7326 * alloc.c (Fmake_string):
7327 * character.c (string_escape_byte8):
7328 * coding.c (coding_alloc_by_realloc):
7329 * doprnt.c (doprnt):
7330 * editfns.c (Fformat):
7332 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7333 since they may not be the same number.
7334 * editfns.c (Finsert_char):
7335 * fileio.c (Finsert_file_contents):
7336 Likewise for BUF_BYTES_MAX.
7338 * image.c: Use ptrdiff_t, not int, for sizes.
7339 (slurp_file): Switch from int to ptrdiff_t.
7341 (slurp_file): Check that file size fits in both size_t (for
7342 malloc) and ptrdiff_t (for sanity and safety).
7344 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7345 if b->modtime has its maximal value.
7347 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7349 Don't assume time_t can fit into int.
7350 * buffer.h (struct buffer.modtime): Now time_t, not int.
7351 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7352 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7354 Minor fixes for signed vs unsigned integers.
7355 * character.h (MAYBE_UNIFY_CHAR):
7356 * charset.c (maybe_unify_char):
7357 * keyboard.c (read_char, reorder_modifiers):
7358 XINT -> XFASTINT, since the integer must be nonnegative.
7359 * ftfont.c (ftfont_spec_pattern):
7360 * keymap.c (access_keymap, silly_event_symbol_error):
7361 XUINT -> XFASTINT, since the integer must be nonnegative.
7362 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7363 since it makes no difference and we prefer signed.
7364 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7365 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7368 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7370 * window.h (Fwindow_frame): Declare.
7372 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7374 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7375 (SPARE_MEMORY): Always define.
7376 (LARGE_REQUEST): Remove.
7377 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7379 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7381 * lisp.h: Move EXFUNS for Fframe_root_window,
7382 Fframe_first_window and Fset_frame_selected_window to window.h.
7384 * window.h: Move EXFUNS for Fframe_root_window,
7385 Fframe_first_window and Fset_frame_selected_window here from
7388 * frame.c (Fwindow_frame, Fframe_first_window)
7389 (Fframe_root_window, Fframe_selected_window)
7390 (Fset_frame_selected_window): Move to window.c.
7391 (Factive_minibuffer_window): Move to minibuf.c.
7392 (Fother_visible_frames_p): New function.
7394 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7396 * window.c (decode_window, decode_any_window): Move up in code.
7397 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7398 (inhibit_frame_unsplittable): Remove unused variable.
7399 (Fwindow_buffer): Move up and rewrite doc-string.
7400 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7401 (Fwindow_prev): New functions.
7402 (Fwindow_frame): Move here from frame.c. Accept any window as
7404 (Fframe_root_window, Fframe_first_window)
7405 (Fframe_selected_window): Move here from frame.c. Accept frame
7406 or arbitrary window as argument. Update doc-strings.
7407 (Fminibuffer_window): Move up in code.
7408 (Fwindow_minibuffer_p): Move up in code and simplify.
7409 (Fset_frame_selected_window): Move here from frame.c.
7411 (Fselected_window, select_window, Fselect_window): Move up in
7412 code. Minor doc-string fixes.
7414 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7416 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7417 Do not assume that spare memory exists; that assumption is valid
7418 only if SYSTEM_MALLOC.
7419 (LARGE_REQUEST): New macro, so that the issue of large requests
7420 is separated from the issue of spare memory.
7422 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7424 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7427 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7429 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7432 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7434 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7436 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7438 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7439 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7441 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7443 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7445 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7447 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7448 (x_clipboard_manager_save): Add return value.
7449 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7451 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7452 Obey Vx_select_enable_clipboard_manager. Catch errors in
7453 x_clipboard_manager_save (Bug#8779).
7454 (Vx_select_enable_clipboard_manager): New variable.
7455 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7457 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7459 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7461 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7463 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7464 in the current matrix if keep_current_p is non-zero.
7466 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7468 * bidi.c (bidi_level_of_next_char): Fix last change.
7470 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7472 Support bidi reordering of text covered by display properties.
7474 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7475 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7476 (bidi_cache_search, bidi_cache_iterator_state)
7477 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7478 (bidi_level_of_next_char, bidi_move_to_visually_next):
7479 Support character positions inside a run of characters covered by a
7481 (bidi_paragraph_init, bidi_resolve_explicit_1)
7482 (bidi_level_of_next_char): Call bidi_fetch_char and
7483 bidi_fetch_char_advance instead of FETCH_CHAR and
7485 (bidi_init_it): Initialize new members.
7486 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7488 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7489 instead of using explicit *_CHAR codes.
7490 (bidi_resolve_explicit, bidi_resolve_weak):
7491 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7492 bidirectional text is supported only in multibyte buffers.
7493 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7494 it to initialize the frame_window_p member of struct bidi_it.
7495 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7496 (bidi_resolve_explicit, bidi_resolve_weak)
7497 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7498 bidi_it->nchars is non-positive.
7499 (bidi_level_of_next_char): Don't try to lookup the cache for the
7500 next/previous character if nothing is cached there yet, or if we
7501 were just reseat()'ed to a new position.
7503 * xdisp.c (set_cursor_from_row): Set start and stop points
7504 according to the row's direction when priming the loop that looks
7505 for the glyph on which to display cursor.
7506 (single_display_spec_intangible_p): Function deleted.
7507 (display_prop_intangible_p): Reimplement to call
7508 handle_display_spec instead of single_display_spec_intangible_p.
7509 Accept 3 additional arguments needed by handle_display_spec.
7510 This fixes incorrect cursor motion across display property with complex
7511 values: lists, `(when COND...)' forms, etc.
7512 (single_display_spec_string_p): Support property values that are
7513 lists with the argument STRING its top-level element.
7514 (display_prop_string_p): Fix the condition for processing a
7515 property that is a list to be consistent with handle_display_spec.
7516 (handle_display_spec): New function, refactored from the
7517 last portion of handle_display_prop.
7518 (compute_display_string_pos): Accept additional argument
7519 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7520 value of a `display' property is a "replacing spec".
7521 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7522 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7523 the display property, but just return a value indicating whether
7524 the display property will replace the characters it covers.
7525 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7526 frame_window_p members of struct bidi_it.
7527 (compute_display_string_pos, compute_display_string_end):
7529 (push_it): Accept second argument POSITION, where pop_it should
7530 jump to continue iteration.
7531 (reseat_1): Initialize bidi_it.disp_pos.
7533 * keyboard.c (adjust_point_for_property): Adjust the call to
7534 display_prop_intangible_p to its new signature.
7536 * dispextern.h (struct bidi_it): New member frame_window_p.
7537 (bidi_init_it): Update prototypes.
7538 (display_prop_intangible_p): Update prototype.
7539 (compute_display_string_pos, compute_display_string_end):
7541 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7544 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7546 Malloc failure behavior now depends on size of allocation.
7547 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7548 * lisp.h: Change signatures accordingly.
7549 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7550 All callers changed. (Bug#8762)
7552 * gnutls.c: Use Emacs's memory allocators.
7553 Without this change, the gnutls library would invoke malloc etc.
7554 directly, which causes problems on non-SYNC_INPUT hosts, and which
7555 runs afoul of improving memory_full behavior. (Bug#8761)
7556 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7557 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7558 xfree instead of the default malloc, realloc, free.
7559 (Fgnutls_boot): No need to check for memory allocation failure,
7560 since xmalloc does that for us.
7562 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7563 * category.c (hash_get_category_set):
7564 * ccl.c (ccl_driver):
7565 * charset.c (Fdefine_charset_internal):
7566 * charset.h (struct charset.hash_index):
7567 * composite.c (get_composition_id, gstring_lookup_cache)
7568 (composition_gstring_put_cache):
7569 * composite.h (struct composition.hash_index):
7570 * dispextern.h (struct image.hash):
7571 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7572 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7573 (hashfn_equal, hashfn_user_defined, make_hash_table)
7574 (maybe_resize_hash_table, hash_lookup, hash_put)
7575 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7576 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7577 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7578 * image.c (make_image, search_image_cache, lookup_image)
7579 (xpm_put_color_table_h):
7580 * lisp.h (struct Lisp_Hash_Table):
7581 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7582 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7583 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7584 * alloc.c (allocate_vectorlike):
7585 Check for overflow in vector size calculations.
7586 * ccl.c (ccl_driver):
7587 Check for overflow when converting EMACS_INT to int.
7588 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7589 need to be updated by these changes.
7590 * fns.c (make_hash_table, maybe_resize_hash_table):
7591 Check for integer overflow with large hash tables.
7592 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7593 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7594 (SXHASH_REDUCE): New macro.
7595 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7596 Use it instead of discarding useful hash info with large hash values.
7597 (sxhash_float): New function.
7598 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7599 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7600 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7601 Rewrite to use FIXNUM_BITS, as this simplifies things.
7602 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7603 Adjust signatures to match updated version of code.
7604 (consing_since_gc): Now EMACS_INT, since a single hash table can
7605 use more than INT_MAX bytes.
7607 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7609 Make it possible to build with GCC-4.6+ -O2 -flto.
7611 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7613 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7615 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7616 Call minibuffer-inactive-mode.
7618 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7620 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7621 Update dependencies.
7623 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7625 * data.c (init_data): Remove code for UTS, this system is not
7628 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7630 Don't force ./temacs to start in terminal mode.
7632 * frame.c (make_initial_frame): Initialize faces in all cases, not
7633 only when CANNOT_DUMP is defined.
7634 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7636 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7638 * dispnew.c (add_window_display_history): Use const for the string
7639 pointer. Remove declaration, not needed.
7641 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7643 Use 'inline', not 'INLINE'.
7644 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7645 * alloc.c, fontset.c (INLINE): Remove.
7646 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7647 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7648 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7649 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7650 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7652 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7654 Make it possible to run ./temacs.
7656 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7657 syms_of_callproc does the same thing. Remove test for
7658 "initialized", do it in the caller.
7659 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7661 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7663 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7664 (read_minibuf): Use get_minibuffer.
7665 (syms_of_minibuf): Use DEFSYM.
7666 (Qmetadata): New var.
7667 * data.c (Qbuffer): Don't make it static.
7668 (syms_of_data): Use DEFSYM.
7670 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7672 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7673 (CCL_CODE_MIN): New macro.
7675 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7677 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7679 * eval.c (Qdebug): Now static.
7680 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7681 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7682 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7684 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7686 * image.c: Various fixes to ImageMagick code comments.
7687 (Fimagemagick_types): Doc fix.
7689 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7691 Minor fixes prompted by GCC 4.6.0 warnings.
7693 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7695 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7696 (x_clipboard_manager_save_all): Move extern decl to ...
7697 * xterm.h: ... here, so that it can be checked for consistency.
7699 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7701 * xselect.c (x_clipboard_manager_save_frame)
7702 (x_clipboard_manager_save_all): New functions.
7703 (Fx_clipboard_manager_save): Lisp function deleted.
7705 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7706 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7708 * xterm.h: Update prototype.
7710 2011-05-28 William Xu <william.xwl@gmail.com>
7712 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7715 2011-05-28 Jim Meyering <meyering@redhat.com>
7717 Avoid a sign-extension bug in crypto_hash_function.
7718 * fns.c (to_uchar): Define.
7719 (crypto_hash_function): Use it to convert some newly-signed
7720 variables to unsigned, to avoid sign-extension bugs. For example,
7721 without this change, (md5 "truc") would evaluate to
7722 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7723 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7724 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7726 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7728 Integer overflow fixes.
7730 * dbusbind.c: Serial number integer overflow fixes.
7731 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7732 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7733 to hold a serial number that is too large for a fixnum.
7734 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7735 Check for serial numbers out of range. Decode any serial number
7736 that was so large that it became a float. (Bug#8722)
7738 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7739 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7740 Use XFASTINT rather than XUINT when numbers are nonnegative.
7741 (xd_append_arg, Fdbus_method_return_internal):
7742 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7743 arguments, check that Lisp number is nonnegative, rather than
7744 silently wrapping negative numbers around. (Bug#8722)
7745 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7748 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7750 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7752 ccl: Add integer overflow checks.
7753 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7754 (IN_INT_RANGE): New macros.
7755 (ccl_driver): Use them to check for integer overflow when
7756 decoding a CCL program. Many of the new checks are whether XINT (x)
7757 fits in int; it doesn't always, on 64-bit hosts. The new version
7758 doesn't catch all possible integer overflows, but it's an
7759 improvement. (Bug#8719)
7761 * alloc.c (make_event_array): Use XINT, not XUINT.
7762 There's no need for unsigned here.
7764 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7765 This follows up to the 2011-05-06 change that substituted uintptr_t
7766 for EMACS_INT. This case wasn't caught back then.
7768 Rework Fformat to avoid integer overflow issues.
7769 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7770 now (part of C89). Include <verify.h>.
7771 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7772 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7773 (Fformat): Avoid the prepass trying to compute sizes; it was only
7774 approximate and thus did not catch overflow reliably. Instead, walk
7775 through the format just once, formatting and computing sizes as we go,
7776 checking for integer overflow at every step, and allocating a larger
7777 buffer as needed. Keep track separately whether the format is
7778 multibyte. Keep only the most-recently calculated precision, rather
7779 than them all. Record whether each argument has been converted to
7780 string. Use EMACS_INT, not int, for byte and char and arg counts.
7781 Support field widths and precisions larger than INT_MAX. Avoid
7782 sprintf's undefined behavior with conversion specifications such as %#d
7783 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7784 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7785 formatting out-of-range floating point numbers with int
7788 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7790 * data.c: Avoid integer truncation in expressions involving floats.
7791 * data.c: Include <intprops.h>.
7792 (arith_driver): When there's an integer overflow in an expression
7793 involving floating point, convert the integers to floating point
7794 so that the resulting value does not suffer from catastrophic
7795 integer truncation. For example, on a 64-bit host (* 4
7796 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7797 Do not rely on undefined behavior after integer overflow.
7799 merge count_size_as_multibyte, parse_str_to_multibyte
7800 * character.c, character.h (count_size_as_multibyte):
7801 Rename from parse_str_to_multibyte; all uses changed.
7802 Check for integer overflow.
7803 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7804 since it's now a duplicate of the other. This is more of
7805 a character than a buffer op, so better that it's in character.c.
7806 * fns.c, print.c: Adjust to above changes.
7808 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7810 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7812 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7814 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7815 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7816 (x_clipboard_manager_save): Now static.
7817 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7819 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7820 (crypto_hash_function): Now static.
7821 Fix pointer signedness problems. Avoid unnecessary initializations.
7823 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7825 * termhooks.h (Vselection_alist): Make it terminal-local.
7827 * terminal.c (create_terminal): Initialize it.
7829 * xselect.c: Support for clipboard managers.
7830 (Vselection_alist): Move to termhooks.h as terminal-local var.
7831 (LOCAL_SELECTION): New macro.
7832 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7833 (symbol_to_x_atom): Remove gratuitous arg.
7834 (x_handle_selection_request, lisp_data_to_selection_data)
7835 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7836 (x_own_selection, x_get_local_selection, x_convert_selection):
7837 New arg, specifying work frame. Use terminal-local Vselection_alist.
7838 (some_frame_on_display): Delete unused function.
7839 (Fx_own_selection_internal, Fx_get_selection_internal)
7840 (Fx_disown_selection_internal, Fx_selection_owner_p)
7841 (Fx_selection_exists_p): New optional frame arg.
7842 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7843 (x_handle_selection_clear): Don't treat other terminals with the
7844 same keyboard specially. Use the terminal-local Vselection_alist.
7845 (x_clear_frame_selections): Use Frun_hook_with_args.
7847 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7849 * xterm.h: Add support for those atoms.
7851 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7853 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7854 (converted_selections, conversion_fail_tag): New global variables.
7855 (x_selection_request_lisp_error): Free the above.
7856 (x_get_local_selection): Remove unnecessary code.
7857 (x_reply_selection_request): Args changed; handle arbitrary array
7858 of converted selections stored in converted_selections.
7859 Separate the XChangeProperty and SelectionNotify steps.
7860 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7861 (x_convert_selection): New function.
7862 (x_handle_selection_event): Simplify.
7863 (x_get_foreign_selection): Don't ignore incoming requests while
7864 waiting for an answer; this will fail when we implement
7865 SAVE_TARGETS, and seems unnecessary anyway.
7866 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7867 (Vx_sent_selection_functions): Doc fix.
7869 2011-05-26 Leo Liu <sdl.web@gmail.com>
7871 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7873 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7875 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7877 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7878 for fringe update if it has periodic bitmap.
7879 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7880 and fringe_bitmap_periodic_p.
7882 * fringe.c (get_fringe_bitmap_data): New function.
7883 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7884 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7885 row. Mark glyph row for fringe update if periodicity changed.
7887 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7888 for fringe update unless it has periodic bitmap.
7890 2011-05-25 Kenichi Handa <handa@m17n.org>
7892 * xdisp.c (get_next_display_element): Set correct it->face_id for
7893 a static composition.
7895 2011-05-24 Leo Liu <sdl.web@gmail.com>
7898 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7900 * fns.c (crypto_hash_function, Fsha1): New function.
7901 (Fmd5): Use crypto_hash_function.
7902 (syms_of_fns): Add Ssha1.
7904 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7906 * gnutls.c: Remove unused macros.
7907 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7908 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7909 Remove macros that are defined and never used.
7910 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7912 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7914 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7915 (Fx_get_selection_internal): Minor cleanup.
7916 (Fx_own_selection_internal): Rename arguments for consistency with
7919 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7921 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7923 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7925 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7927 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7929 * dispnew.c (scrolling_window): Don't exclude the case that the
7930 last enabled row in the desired matrix touches the bottom boundary.
7932 2011-05-21 Glenn Morris <rgm@gnu.org>
7934 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7935 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7936 and add some more files.
7938 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7940 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7941 report_file_error introduced by the change from 2011-05-07.
7943 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7945 * systime.h (Time): Define only if emacs is defined.
7946 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7947 where the include path doesn't have X11/X.h by default. See
7948 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7950 2011-05-20 Kenichi Handa <handa@m17n.org>
7952 * composite.c (find_automatic_composition): Fix previous change.
7954 2011-05-20 Glenn Morris <rgm@gnu.org>
7956 * lisp.mk: New file, split from Makefile.in.
7957 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7958 (shortlisp): Remove.
7959 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7961 2011-05-19 Glenn Morris <rgm@gnu.org>
7963 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7964 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7965 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7966 (lisp): Set the order to that of loadup.el.
7967 (shortlisp): Make it a copy of $lisp.
7968 (SOME_MACHINE_LISP): Remove.
7969 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7970 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7972 2011-05-18 Kenichi Handa <handa@m17n.org>
7974 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7975 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7976 (find_automatic_composition): Mostly rewrite for efficiency.
7978 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7980 * makefile.w32-in: Update dependencies.
7982 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7984 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7985 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7987 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7989 Fix some integer overflow issues, such as string length overflow.
7991 * insdel.c (count_size_as_multibyte): Check for string overflow.
7993 * character.c (lisp_string_width): Check for string overflow.
7994 Use EMACS_INT, not int, for string indexes and lengths; in
7995 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7996 the resulting string length overflows an EMACS_INT; instead,
7997 report a string overflow if no precision given. When checking for
7998 precision exhaustion, use a check that cannot possibly have
7999 integer overflow. (Bug#8675)
8000 * character.h (lisp_string_width): Adjust to new signature.
8002 * alloc.c (string_overflow): New function.
8003 (Fmake_string): Use it. This doesn't change behavior, but saves
8004 a few bytes and will simplify future changes.
8005 * character.c (string_escape_byte8): Likewise.
8006 * lisp.h (string_overflow): New decl.
8008 Fixups, following up to the user-interface timestamp change.
8009 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8010 for UI timestamps, instead of unsigned long.
8011 * msdos.c (mouse_get_pos): Likewise.
8012 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8013 * w32gui.h (Time): Define by including "systime.h" rather than by
8014 declaring it ourselves. (Bug#8664)
8016 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8017 * image.c (clear_image_cache): Likewise.
8019 * term.c (term_mouse_position): Don't assume time_t wraparound.
8021 Be more systematic about user-interface timestamps.
8022 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8023 and sometimes 'EMACS_UINT', to represent these timestamps.
8024 This change causes it to use 'Time' uniformly, as that's what X uses.
8025 This makes the code easier to follow, and makes it easier to catch
8026 integer overflow bugs such as Bug#8664.
8027 * frame.c (Fmouse_position, Fmouse_pixel_position):
8028 Use Time, not unsigned long, for user-interface timestamps.
8029 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8030 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8031 * keyboard.h (last_event_timestamp): Likewise.
8032 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8033 * menu.h (xmenu_show): Likewise.
8034 * term.c (term_mouse_position): Likewise.
8035 * termhooks.h (struct input_event.timestamp): Likewise.
8036 (struct terminal.mouse_position_hook): Likewise.
8037 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8038 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8039 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8040 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8042 * menu.h, termhooks.h: Include "systime.h", for Time.
8044 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8045 Don't assume that the difference between two unsigned long values
8046 can fit into an integer. At this point, we know button_down_time
8047 <= event->timestamp, so the difference must be nonnegative, so
8048 there's no need to cast the result if double-click-time is
8049 nonnegative, as it should be; check that it's nonnegative, just in
8050 case. This bug is triggered when events are more than 2**31 ms
8051 apart (about 25 days). (Bug#8664)
8053 * xselect.c (last_event_timestamp): Remove duplicate decl.
8054 (x_own_selection): Remove needless cast to unsigned long.
8056 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8057 that always fit in int. Use a sentinel instead of a counter, to
8058 avoid a temp and to allay GCC's concerns about possible int overflow.
8059 * frame.h (struct frame): Use int for menu_bar_items_used
8060 instead of EMACS_INT, since it always fits in int.
8062 * menu.c (grow_menu_items): Check for int overflow.
8064 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8066 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8067 Before, the code was not consistent. These values cannot exceed
8068 2**31 - 1 so there's no need to make them unsigned.
8069 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8070 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8071 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8073 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8075 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8076 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8077 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8078 presumably because the widths might not match.
8080 * window.c (size_window): Avoid needless test at loop start.
8082 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8084 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8086 2011-05-12 Drew Adams <drew.adams@oracle.com>
8088 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8090 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8092 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8093 `width' to `bar_area_x' and `bar_area_width', respectively.
8094 (x_scroll_run): Take account of fringe background extension.
8096 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8097 Rename local vars `left' and `width' to `bar_area_x' and
8098 `bar_area_width', respectively.
8099 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8100 background extension.
8102 2011-05-10 Jim Meyering <meyering@redhat.com>
8104 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8106 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8108 * image.c (Finit_image_library): Return t for built-in image types,
8109 like pbm and xbm. (Bug#8640)
8111 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8113 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8115 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8117 * w32console.c (Fset_screen_color): Doc fix.
8118 (Fget_screen_color): New function.
8119 (syms_of_ntterm): Defsubr it.
8121 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8122 unlink the temporary file if Fcall_process didn't create it in the
8124 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8125 child process will be redirected to a file specified with `:file'.
8126 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8127 cue to call_process_cleanup not to close that handle.
8129 2011-05-07 Ben Key <bkey76@gmail.com>
8131 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8132 one of two shell specific rules, either bootstrap-temacs-CMD or
8133 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8134 to the previous implementation of the bootstrap-temacs rule.
8135 The bootstrap-temacs-CMD rule is similar to the previous
8136 implementation of the bootstrap-temacs rule except that it
8137 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8140 These changes, along with some changes to nt/configure.bat,
8141 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8142 earlier fix to add support for --cflags and --ldflags options
8143 that include quotes so that it works whether make uses cmd or
8146 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8148 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8149 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8151 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8152 a string. Handle both cases.
8153 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8154 (Fdbus_register_method): Use Qinvalid_function.
8156 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8158 * makefile.w32-in: Update dependencies.
8159 (LISP_H): Add inttypes.h and stdin.h.
8160 (PROCESS_H): Add unistd.h.
8162 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8164 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8165 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8167 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8169 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8171 * term.c (vfatal): Remove stray call to va_end.
8172 It's not needed and the C Standard doesn't allow it here anyway.
8174 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8175 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8177 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8180 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8182 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8184 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8186 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8188 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8190 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8191 * charset.c (Fdefine_charset_internal): Don't initialize
8192 charset.code_space[15]. The value was garbage, on hosts with
8193 32-bit int (Bug#8600).
8195 * lread.c (read_integer): Be more consistent with string-to-number.
8196 Use string_to_number to do the actual conversion; this avoids
8197 rounding errors and fixes some other screwups. Without this fix,
8198 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8199 (digit_to_number): Move earlier, for benefit of read_integer.
8200 Return -1 if the digit is out of range for the base, -2 if it is
8201 not a digit in any supported base. (Bug#8602)
8203 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8205 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8206 to match comment at start of function. This also removes a
8207 GCC warning about overflow in a 32+64-bit port.
8209 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8211 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8212 Reported by Stefan Monnier in
8213 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8214 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8215 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8217 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8218 (EMACS_UINTPTR): Likewise, with uintptr_t.
8220 * lisp.h: Prefer 64-bit EMACS_INT if available.
8221 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8222 on 32-bit hosts that have 64-bit int, so that they can access
8224 However, temporarily disable this change unless the temporary
8225 symbol WIDE_EMACS_INT is defined.
8227 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8229 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8230 This removes an assumption that EMACS_INT and long are the same
8231 width as pointers. The assumption is true for Emacs porting targets
8232 now, but we want to make other targets possible.
8233 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8234 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8235 In the rest of the code, change types of integers that hold casted
8236 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8237 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8238 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8239 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8240 No need to cast type when ORing.
8241 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8242 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8243 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8244 assume EMACS_INT is the same width as char *.
8245 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8246 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8247 Remove no-longer-needed casts.
8248 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8249 (xg_tool_bar_help_callback, xg_make_tool_item):
8250 Use EMACS_INTPTR to hold an integer
8251 that will be cast to void *; this can avoid a GCC warning
8252 if EMACS_INT is not the same width as void *.
8253 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8254 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8255 (current_message_1, set_message_1):
8256 Use a local to convert to proper width without a cast.
8257 * xmenu.c (dialog_selection_callback): Likewise.
8259 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8260 Also, don't assume VALBITS / RAND_BITS is less than 5,
8261 and don't rely on undefined behavior when shifting a 1 left into
8263 * lisp.h (get_random): Change signature to match.
8265 * lread.c (hash_string): Use size_t, not int, for hash computation.
8266 Normally we prefer signed values; but hashing is special, because
8267 it's better to use unsigned division on hash table sizes so that
8268 the remainder is nonnegative. Also, size_t is the natural width
8269 for hashing into memory. The previous code used 'int', which doesn't
8270 retain enough info to hash well into very large tables.
8271 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8273 * dbusbind.c: Don't possibly lose pointer info when converting.
8274 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8275 Use XPNTR rather than XHASH, so that the high-order bits of
8276 the pointer aren't lost when converting through void *.
8278 * eval.c (Fautoload): Don't double-shift a pointer.
8280 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8282 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8284 * gnutls.c (DEF_GNUTLS_FN):
8285 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8287 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8289 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8292 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8294 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8295 New version that can reserve upto 2GB of heap space.
8297 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8299 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8301 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8303 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8304 `gnutls_certificate_set_x509_key_file'.
8306 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8308 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8309 Update dependencies.
8311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8313 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8314 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8315 Remove unused parameter `fildes'.
8316 * process.c (read_process_output, send_process): Don't pass it.
8318 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8320 Fix previous change: the library cache is defined in w32.c.
8321 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8322 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8324 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8326 Implement dynamic loading of GnuTLS on Windows.
8328 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8329 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8330 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8333 * gnutls.c (Qgnutls_dll): Define.
8334 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8335 (gnutls_*): Declare function pointers.
8336 (init_gnutls_functions): New function to initialize function pointers.
8337 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8338 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8339 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8340 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8341 (emacs_gnutls_write, emacs_gnutls_read)
8342 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8343 (Fgnutls_available_p): New function.
8344 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8345 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8346 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8348 * image.c: Include w32.h.
8349 (Vimage_type_cache): Delete.
8350 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8351 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8352 (w32_delayed_load): Move to w32.c.
8354 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8356 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8357 (w32_delayed_load): Move from image.c. When loading a library, record
8358 its filename in the :loaded-from property of the library id.
8359 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8360 Initialize and staticpro them.
8361 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8363 * process.c: Include lisp.h before w32.h, not after.
8364 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8365 instead of gnutls_record_check_pending.
8367 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8369 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8371 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8372 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8375 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8377 * xterm.c (x_set_frame_alpha): Do not set property on anything
8378 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8380 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8382 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8384 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8386 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8387 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8388 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8389 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8390 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8391 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8392 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8393 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8394 (Qgnutls_bootprop_callbacks_verify): Make static.
8396 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8398 * callproc.c: Indentation fixup.
8400 * sysdep.c (wait_for_termination_1): Make static.
8401 (wait_for_termination, interruptible_wait_for_termination):
8402 Move after wait_for_termination_1.
8404 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8406 * sysdep.c (interruptible_wait_for_termination): New function
8407 which is like wait_for_termination, but allows keyboard
8410 * callproc.c (Fcall_process): Add (:file "file") as an option for
8412 (Fcall_process_region): Ditto.
8414 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8416 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8417 rather than `XVECTOR (FOO)->size'.
8419 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8420 inttypes.h, as a gnulib replacement is used if it not available in
8423 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8425 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8426 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8427 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8429 * coding.c (coding_alloc_by_realloc): Error out if destination
8430 will grow beyond MOST_POSITIVE_FIXNUM.
8431 (decode_coding_emacs_mule): Abort if there isn't enough place in
8432 charbuf for the composition carryover bytes. Reserve an extra
8433 space for up to 2 characters produced in a loop.
8434 (decode_coding_iso_2022): Abort if there isn't enough place in
8435 charbuf for the composition carryover bytes.
8437 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8439 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8440 aborting when %lld or %lll format is passed.
8441 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8442 %llo or %llx format is passed. (Bug#8545)
8444 * window.c (window_scroll_line_based): Use a marker instead of
8445 simple variables to record original value of point. (Bug#7952)
8447 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8448 produced by %s or %c overflows available buffer space. (Bug#8545)
8450 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8452 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8453 (SIZE_MAX): Move defn after all includes, as they might #define it.
8455 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8457 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8459 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8461 * keyboard.c (Qdelayed_warnings_hook): Define.
8462 (command_loop_1): Run `delayed-warnings-hook'
8463 if Vdelayed_warnings_list is non-nil.
8464 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8465 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8467 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8469 * doprnt.c (doprnt): Don't return value smaller than the buffer
8470 size if the message was truncated. (Bug#8545).
8472 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8474 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8475 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8477 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8479 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8481 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8483 * makefile.w32-in: Update dependencies.
8485 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8487 Improve `doprnt' and its usage. (Bug#8545)
8488 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8489 `format_end'. Remove support for %l as a conversion specifier.
8490 Don't use xrealloc. Improve diagnostics when the %l size modifier
8491 is used. Update the commentary.
8493 * eval.c (verror): Simplify calculation of size_t.
8495 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8498 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8500 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8503 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8505 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8506 This makes this file independent of the recent pseudovector change.
8508 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8510 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8512 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8513 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8514 Remove unused local.
8515 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8517 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8518 GCC 4.6.0 optimizes based on type-based alias analysis.
8519 For example, if b is of type struct buffer * and v of type struct
8520 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8521 != &v->size, and therefore "v->size = 1; b->size = 2; return
8522 v->size;" must therefore return 1. This assumption is incorrect
8523 for Emacs, since it type-puns struct Lisp_Vector * with many other
8524 types. To fix this problem, this patch adds a new type struct
8525 vectorlike_header that documents the constraints on layout of vectors
8526 and pseudovectors, and helps optimizing compilers not get fooled
8527 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8528 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8529 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8531 (XSETPVECTYPE): Rewrite in terms of new macro.
8532 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8533 This is a bit clearer, and further avoids the possibility of
8534 undesirable aliasing.
8535 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8536 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8537 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8538 since Lisp_Subr is a special case (no "next" field).
8539 (ASIZE): Now uses header.size rather than size.
8540 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8541 to avoid the hassle of writing XVECTOR (foo)->header.size.
8542 (struct vectorlike_header): New type.
8543 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8544 object, to help avoid aliasing.
8545 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8546 (SUBRP): Likewise, since Lisp_Subr is a special case.
8547 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8548 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8549 (struct Lisp_Hash_Table): Combine first two members into a single
8550 struct vectorlike_header member. All uses of "size" and "next" members
8551 changed to be "header.size" and "header.next".
8552 * buffer.h (struct buffer): Likewise.
8553 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8554 * frame.h (struct frame): Likewise.
8555 * process.h (struct Lisp_Process): Likewise.
8556 * termhooks.h (struct terminal): Likewise.
8557 * window.c (struct save_window_data, struct saved_window): Likewise.
8558 * window.h (struct window): Likewise.
8559 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8560 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8561 * buffer.c (init_buffer_once): Likewise.
8562 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8564 * process.c (Fformat_network_address): Use local var for size,
8567 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8569 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8570 * data.c (atof): Remove decl; no longer used or needed.
8571 (digit_to_number): Move to lread.c.
8572 (Fstring_to_number): Use new string_to_number function, to be
8573 consistent with how the Lisp reader treats infinities and NaNs.
8574 Do not assume that floating-point numbers represent EMACS_INT
8575 without losing information; this is not true on most 64-bit hosts.
8576 Avoid double-rounding errors, by insisting on integers when
8577 parsing non-base-10 numbers, as the documentation specifies.
8578 * lisp.h (string_to_number): New decl, replacing ...
8579 (isfloat_string): Remove.
8580 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8581 (read1): Do not accept +. and -. as integers; this
8582 appears to have been a coding error. Similarly, do not accept
8583 strings like +-1e0 as floating point numbers. Do not report
8584 overflow for integer overflows unless the base is not 10 which
8585 means we have no simple and reliable way to continue.
8586 Break out the floating-point parsing into a new
8587 function string_to_number, so that Fstring_to_number parses
8588 floating point numbers consistently with the Lisp reader.
8589 (digit_to_number): Move here from data.c. Make it static inline.
8590 (E_CHAR, EXP_INT): Remove, replacing with ...
8591 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8592 (string_to_number): New function, replacing isfloat_string.
8593 This function checks for valid syntax and produces the resulting
8594 Lisp float number too. Rework it so that string-to-number
8595 no longer mishandles examples like "1.0e+". Use strtoumax,
8596 so that overflow for non-base-10 numbers is reported only when
8597 there's no portable and simple way to convert to floating point.
8599 * textprop.c (set_text_properties_1): Rewrite for clarity,
8600 and to avoid GCC warning about integer overflow.
8602 * intervals.h (struct interval): Use EMACS_INT for members
8603 where EMACS_UINT might cause problems. See
8604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8605 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8606 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8608 (offset_intervals): Tell GCC not to worry about length overflow
8609 when negating a negative length.
8611 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8612 (overrun_check_free): Likewise.
8614 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8615 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8618 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8619 (gnutls_make_error): Rename local to avoid shadowing.
8620 (gnutls_emacs_global_deinit): ifdef out; not used.
8621 (Fgnutls_boot): Use const for pointer to readonly storage.
8622 Comment out unused local. Fix pointer signedness problems.
8624 * lread.c (openp): Don't stuff size_t into an 'int'.
8625 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8626 about possible signed overflow.
8628 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8629 (GDK_KEY_g): Don't define if already defined.
8630 (xg_prepare_tooltip): Avoid pointer signedness problem.
8631 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8633 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8634 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8636 * xfns.c (Fx_window_property): Simplify a bit,
8637 to make a bit faster and to avoid GCC 4.6.0 warning.
8638 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8640 * fns.c (internal_equal): Don't assume size_t fits in int.
8642 * alloc.c (compact_small_strings): Tighten assertion a little.
8644 Replace pEd with more-general pI, and fix some printf arg casts.
8645 * lisp.h (pI): New macro, generalizing old pEd macro to other
8646 conversion specifiers. For example, use "...%"pI"d..." rather
8647 than "...%"pEd"...".
8648 (pEd): Remove. All uses replaced with similar uses of pI.
8649 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8650 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8651 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8652 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8653 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8654 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8655 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8657 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8658 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8659 * print.c (safe_debug_print, print_object): Likewise.
8660 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8662 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8663 avoiding the 0 flag, which is not portable.
8664 * process.c (Fmake_network_process): Use pI to avoid cast.
8665 * region-cache.c (pp_cache): Likewise.
8666 * xdisp.c (decode_mode_spec): Likewise.
8667 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8668 behavior on 64-bit hosts with printf arg.
8669 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8670 (x_stop_queuing_selection_requests): Likewise.
8671 (x_get_window_property): Don't truncate byte count to an 'int'
8674 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8675 here, since it parses constructs like leading '-' and spaces,
8676 which are not wanted; and it overflows with large numbers.
8677 Instead, simply match F[0-9]+, which is what is wanted anyway.
8679 * alloc.c: Remove unportable assumptions about struct layout.
8680 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8681 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8682 (allocate_vectorlike, make_pure_vector): Use the new macros,
8683 plus offsetof, to remove unportable assumptions about struct layout.
8684 These assumptions hold on all porting targets that I know of, but
8685 they are not guaranteed, they're easy to remove, and removing them
8686 makes further changes easier.
8688 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8689 This doesn't fix a bug but makes the code clearer.
8690 (string_overrun_cookie): Now const. Use initializers that
8691 don't formally overflow signed char, to avoid warnings.
8692 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8693 can cause Emacs to crash when string overrun checking is enabled.
8694 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8695 multiple of sizeof (EMACS_INT); it need not be, if
8696 alignof(EMACS_INT) < sizeof (EMACS_INT).
8697 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8699 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8701 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8703 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8705 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8706 supposed to be handshaking. (Bug#8556)
8707 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8709 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8711 * lisp.h (Qdebug): List symbol.
8712 * eval.c (Qdebug): Restore global linkage.
8713 * keyboard.c (debug-on-event): New variable.
8714 (handle_user_signal): Break into debugger when debug-on-event
8715 matches the current signal symbol.
8717 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8719 * alloc.c (check_sblock, check_string_bytes)
8720 (check_string_free_list): Convert to standard C.
8722 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8724 * w32.c (emacs_gnutls_push): Fix typo.
8726 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8728 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8729 "cast to pointer from integer of different size".
8731 Improve doprnt and its use in verror. (Bug#8545)
8732 * doprnt.c (doprnt): Document the set of format control sequences
8733 supported by the function. Use SAFE_ALLOCA instead of always
8736 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8737 is one byte too soon. Don't use xrealloc; instead xfree and
8740 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8742 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8745 * gnutls.c: Renamed global_initialized to
8746 gnutls_global_initialized. Added internals for the
8747 :verify-hostname-error, :verify-error, and :verify-flags
8748 parameters of `gnutls-boot' and documented those parameters in the
8749 docstring. Start callback support.
8750 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8751 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8752 on error. Return error code.
8753 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8754 (emacs_gnutls_read): Likewise.
8755 (Fgnutls_boot): Return handshake error code.
8756 (emacs_gnutls_handle_error): New function.
8757 (wsaerror_to_errno): Likewise.
8759 * w32.h (emacs_gnutls_pull): Add prototype.
8760 (emacs_gnutls_push): Likewise.
8762 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8763 (emacs_gnutls_push): Likewise.
8765 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8767 * process.c (wait_reading_process_output): Check if GnuTLS
8768 buffered some data internally if no FDs are set for TLS
8771 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8772 (LIBS): Link to USER_LIBS.
8773 ($(BLD)/gnutls.$(0)): New target.
8775 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8777 * xdisp.c (handle_single_display_spec): Rename the
8778 display_replaced_before_p argument into display_replaced_p, to
8779 make it consistent with the commentary. Fix typos in the
8782 * textprop.c (syms_of_textprop): Remove dead code.
8783 (copy_text_properties): Delete obsolete commentary about an
8784 interface that was deleted long ago. Fix typos in the description
8787 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8788 to changes in oldXMenu/XMenu.h from 2011-04-16.
8789 <menu_help_message, prev_menu_help_message>: Constify.
8790 (IT_menu_make_room): menu->help_text is now `const char **';
8793 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8794 to changes in oldXMenu/XMenu.h from 2011-04-16.
8795 (struct XMenu): Declare `help_text' `const char **'.
8797 * xfaces.c <Qunspecified>: Make extern again.
8799 * syntax.c: Include sys/types.h before including regex.h, as
8802 * doc.c (get_doc_string): Improve the format passed to `error'.
8804 * doprnt.c (doprnt): Improve commentary.
8806 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8808 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8811 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8812 changes in globals.h immediately force recompilation.
8813 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8814 $(CURDIR)/s/ms-w32.h.
8815 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8817 * character.c (Fchar_direction): Function deleted.
8818 (syms_of_character): Don't defsubr it.
8819 <char-direction-table>: Deleted.
8821 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8823 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8824 * doprnt.c: Include limits.h.
8825 (SIZE_MAX): New macro.
8826 (doprnt): Return a size_t value. 2nd arg is now size_t.
8827 Many local variables are now size_t instead of int or unsigned.
8828 Improve overflow protection. Support `l' modifier for integer
8829 conversions. Support %l conversion. Don't assume an EMACS_INT
8830 argument for integer conversions and for %c.
8832 * lisp.h (doprnt): Restore prototype.
8834 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8837 * Makefile.in (base_obj): Add back doprnt.o.
8839 * deps.mk (doprnt.o): Add back prerequisites.
8840 (callint.o): Depend on character.h.
8842 * eval.c (internal_lisp_condition_case): Include the handler
8843 representation in the error message.
8844 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8845 when breaking from the loop.
8847 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8849 * callint.c (Fcall_interactively): When displaying error message
8850 about invalid control letter, pass the character's codepoint, not
8851 a pointer to its multibyte form. Improve display of the character
8852 in octal and display also its hex code.
8854 * character.c (char_string): Use %x to display the (unsigned)
8855 codepoint of an invalid character, to avoid displaying a bogus
8858 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8859 `error', not SYMBOL_NAME itself.
8861 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8862 character arguments to `error'.
8864 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8865 to `error' in error message about FINAL_CHAR argument. Make sure
8866 FINAL_CHAR is a character, and use %c when it is passed as
8867 argument to `error'.
8869 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8871 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8873 * w32.c: Include <time.h>.
8874 (sys_localtime): New function.
8876 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8878 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8880 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8882 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8884 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8887 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8889 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8890 gl_state.e_property when gl_state.object is Qt.
8892 * insdel.c (make_gap_larger): Remove limitation of buffer size
8895 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8897 * xdisp.c (lookup_glyphless_char_display)
8898 (produce_glyphless_glyph): Handle cons cell entry in
8899 glyphless-char-display.
8900 (Vglyphless_char_display): Document it.
8902 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8903 glyphless-char-display.
8905 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8907 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8909 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8911 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8912 definition for no-X builds.
8914 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8916 Static checks with GCC 4.6.0 and non-default toolkits.
8918 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8920 * process.c (keyboard_bit_set): Define only if SIGIO.
8921 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8922 (send_process): Repair possible setjmp clobbering.
8924 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8926 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8928 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8930 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8931 Define only if needed.
8933 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8934 by pacifying GCC about it. Maybe it's time to retire it?
8935 * xfaces.c (USG, __TIMEVAL__): Likewise.
8937 * dispextern.h (struct redisplay_interface): Rename param
8939 * termhooks.h (struct terminal): Likewise.
8940 * xterm.c (xembed_send_message): Likewise.
8942 * insdel.c (make_gap_smaller): Define only if
8943 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8945 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8948 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8949 so that we aren't warned about unused symbols.
8951 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8953 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8955 * xfns.c (x_real_positions): Mark locals as initialized.
8957 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8959 * xterm.c: Fix problems found by static analysis with other toolkits.
8960 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8961 (x_dispatch_event): Declare static if USE_GTK, and
8962 define if USE_GTK || USE_X_TOOLKIT.
8963 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8964 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8965 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8966 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8968 * xmenu.c (menu_help_callback): Pointer type fixes.
8969 Use const pointers when pointing at readonly data. Avoid pointer
8971 (FALSE): Remove unused macro.
8972 (update_frame_menubar): Remove unused decl.
8974 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8976 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8977 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8978 (single_menu_item): Rename local to avoid shadowing.
8980 * keyboard.c (make_lispy_event): Remove unused local var.
8982 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8983 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8985 * bitmaps: Change bitmaps from unsigned char back to the X11
8986 compatible char. Avoid the old compiler warnings about
8987 out-of-range initializers by using, for example, '\xab' rather
8990 * xgselect.c (xgselect_initialize): Check vs interface
8991 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8993 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8995 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8996 to read-only memory.
8998 * fns.c (vector): Remove; this old hack is no longer needed.
9000 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9002 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9004 * xrdb.c (x_load_resources): Omit unused local.
9006 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9007 (x_window): Rename locals to avoid shadowing.
9008 (USG): Use the kludged USG macro, to pacify gcc.
9010 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9011 (x_term_init): Remove local to avoid shadowing.
9013 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9015 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9016 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9018 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9020 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9022 Fix regex.c, syntax.c and friends for buffers > 2GB.
9023 * syntax.h (struct gl_state_s): Declare character position members
9026 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9028 * textprop.c (verify_interval_modification, interval_of):
9029 Declare arguments EMACS_INT.
9031 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9034 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9036 * indent.c (Fvertical_motion): Local variable it_start is now
9039 * regex.c (re_match, re_match_2, re_match_2_internal)
9040 (bcmp_translate, regcomp, regexec, print_double_string)
9041 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9042 (re_compile_pattern, re_exec): Declare arguments and local
9043 variables `size_t' and `ssize_t' and return values `regoff_t', as
9045 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9046 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9047 <compile_stack_type>: `size' and `avail' are now `size_t'.
9049 * regex.h <regoff_t>: Use ssize_t, not int.
9050 (re_search, re_search_2, re_match, re_match_2): Arguments that
9051 specify buffer/string position and length are now ssize_t and
9052 size_t. Return type is regoff_t.
9054 2011-04-16 Ben Key <bkey76@gmail.com>
9056 * nsfont.m: Fixed bugs in ns_get_family and
9057 ns_descriptor_to_entity that were caused by using free to
9058 deallocate memory blocks that were allocated by xmalloc (via
9059 xstrdup). This caused Emacs to crash when compiled with
9060 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9061 --enable-checking=xmallocoverrun). xfree is now used to
9062 deallocate these memory blocks.
9064 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9066 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9068 emacs_write: Accept and return EMACS_INT for sizes.
9069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9071 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9072 Accept and return EMACS_INT.
9073 (emacs_gnutls_write): Return the number of bytes written on
9075 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9076 (emacs_read, emacs_write): Remove check for negative size, as the
9077 Emacs source code has been audited now.
9078 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9079 (emacs_read, emacs_write): Use it.
9080 * process.c (send_process): Adjust to the new signatures of
9081 emacs_write and emacs_gnutls_write. Do not attempt to store
9082 a byte offset into an 'int'; it might overflow.
9083 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9085 * sound.c: Don't assume sizes fit in 'int'.
9086 (struct sound_device.period_size, alsa_period_size):
9087 Return EMACS_INT, not int.
9088 (struct sound_device.write, vox_write, alsa_write):
9089 Accept EMACS_INT, not int.
9090 (wav_play, au_play): Use EMACS_INT to store sizes and to
9091 record read return values.
9093 2011-04-15 Ben Key <bkey76@gmail.com>
9095 * keyboard.c (Qundefined): Don't declare static since it is used
9097 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9098 static since they are used in nsfont.m.
9100 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9102 * process.c (Qprocessp): Don't declare static.
9103 * lisp.h (Qprocessp): Declare again.
9105 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9107 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9109 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9111 Improve C-level modularity by making more things 'static'.
9113 Don't publish debugger-only interfaces to other modules.
9114 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9115 (verify_bytepos, count_markers): Move decls to the only modules
9117 * region-cache.h (pp_cache): Likewise.
9118 * window.h (check_all_windows): Likewise.
9119 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9121 * sysdep.c (croak): Now static, if
9122 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9123 * syssignal.h (croak): Declare only if not static.
9125 * alloc.c (refill_memory_reserve): Now static if
9126 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9127 * lisp.h (refill_memory_reserve): Declare only if not static.
9129 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9130 Define only if USE_LUCID.
9132 * xrdb.c (x_customization_string, x_rm_string): Now static.
9134 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9135 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9137 * xdisp.c (draw_row_with_mouse_face): Now static.
9138 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9140 * window.h (check_all_windows): Mark externally visible.
9142 * window.c (window_deletion_count): Now static.
9144 * undo.c: Make symbols static if they're not exported.
9145 (last_undo_buffer, last_boundary_position, pending_boundary):
9148 * textprop.c (interval_insert_behind_hooks): Now static.
9149 (interval_insert_in_front_hooks): Likewise.
9151 * term.c: Make symbols static if they're not exported.
9152 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9153 (max_frame_lines, tty_set_terminal_modes):
9154 (tty_reset_terminal_modes, tty_turn_off_highlight):
9155 (get_tty_terminal): Now static.
9156 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9157 * termhooks.h (term_mouse_moveto): Do not declare if
9159 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9160 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9162 * sysdep.c: Make symbols static if they're not exported.
9163 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9165 (sigprocmask_set, full_mask): Remove; unused.
9166 (wait_debugging): Mark as visible.
9167 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9168 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9170 * syntax.c (syntax_temp): Define only if !__GNUC__.
9172 * sound.c (current_sound_device, current_sound): Now static.
9174 * search.c (searchbufs, searchbuf_head): Now static.
9176 * scroll.c (scroll_cost): Remove; unused.
9177 * dispextern.h (scroll_cost): Remove decl.
9179 * region-cache.h (pp_cache): Mark as externally visible.
9181 * process.c: Make symbols static if they're not exported.
9182 (process_tick, update_tick, create_process, chan_process):
9183 (Vprocess_alist, proc_buffered_char, datagram_access):
9184 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9185 (deactivate_process): Mark defn as static, as well as decl.
9186 * lisp.h (create_process): Remove decl.
9187 * process.h (chan_process, Vprocess_alist): Remove decls.
9189 * print.c: Make symbols static if they're not exported.
9190 (print_depth, new_backquote_output, being_printed, print_buffer):
9191 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9192 (print_interval, print_number_index, initial_stderr_stream):
9194 * lisp.h (Fprinc): Remove decl.
9195 (debug_output_compilation_hack): Mark as externally visible.
9197 * sysdep.c (croak): Move decl from here to syssignal.h.
9198 * syssignal.h (croak): Put it here, so the API can be checked when
9199 'croak' is called from dissociate_if_controlling_tty.
9201 * minibuf.c: Make symbols static if they're not exported.
9202 (minibuf_save_list, choose_minibuf_frame): Now static.
9203 * lisp.h (choose_minibuf_frame): Remove decl.
9205 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9207 * lread.c: Make symbols static if they're not exported.
9208 (read_objects, initial_obarray, oblookup_last_bucket_number):
9210 (make_symbol): Remove; unused.
9211 * lisp.h (initial_obarray, make_symbol): Remove decls.
9213 * keyboard.c: Make symbols static if they're not exported.
9214 (single_kboard, recent_keys_index, total_keys, recent_keys):
9215 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9216 (this_single_command_key_start, echoing, last_auto_save):
9217 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9218 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9219 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9220 (Vlispy_mouse_stem, double_click_count):
9222 (force_auto_save_soon): Define only if SIGDANGER.
9223 (ignore_mouse_drag_p): Now static if
9224 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9225 (print_help): Remove; unused.
9226 (stop_character, last_timer_event): Mark as externally visible.
9227 * keyboard.h (ignore_mouse_drag_p): Declare only if
9228 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9229 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9230 * lisp.h (echoing): Remove decl.
9231 (force_auto_save_soon): Declare only if SIGDANGER.
9232 * xdisp.c (redisplay_window): Simplify code, to make it more
9233 obvious that ignore_mouse_drag_p is not accessed if !defined
9234 USE_GTK && !defined HAVE_NS.
9236 * intervals.c: Make symbols static if they're not exported.
9237 (merge_properties_sticky, merge_interval_right, delete_interval):
9239 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9241 * insdel.c: Make symbols static if they're not exported.
9242 However, leave prepare_to_modify_buffer alone. It's never
9243 called from outside this function, but that appears to be a bug.
9244 (combine_after_change_list, combine_after_change_buffer):
9245 (adjust_after_replace, signal_before_change): Now static.
9246 (adjust_after_replace_noundo): Remove; unused.
9247 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9248 (signal_before_change): Remove decls.
9250 * indent.c (val_compute_motion, val_vmotion): Now static.
9252 * image.c: Make symbols static if they're not exported.
9253 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9255 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9256 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9258 * fringe.c (standard_bitmaps): Now static.
9259 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9261 * frame.c: Make symbols static if they're not exported.
9262 (x_report_frame_params, make_terminal_frame): Now static.
9263 (get_frame_param): Now static, unless HAVE_NS.
9264 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9265 (x_get_resource_string): Remove; not used.
9266 * frame.h (make_terminal_frame, x_report_frame_params):
9267 (x_get_resource_string); Remove decls.
9268 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9269 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9271 * font.c, fontset.c: Make symbols static if they're not exported.
9272 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9273 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9274 * font.c (font_close_object): Now static.
9275 * font.h (font_close_object): Remove.
9276 * fontset.c (FONTSET_OBJLIST): Remove.
9277 (free_realized_fontset) #if-0 the body, which does nothing.
9278 (face_suitable_for_char_p): #if-0, as it's never called.
9279 * fontset.h (face_suitable_for_char_p): Remove decl.
9280 * xfaces.c (face_at_string_position):
9281 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9282 since 0 is always ASCII.
9284 * fns.c (weak_hash_tables): Now static.
9286 * fileio.c: Make symbols static if they're not exported.
9287 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9288 (Vwrite_region_annotation_buffers): Now static.
9290 * eval.c: Make symbols static if they're not exported.
9291 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9292 * lisp.h (backtrace_list): Remove decl.
9294 * emacs.c: Make symbols static if they're not exported.
9295 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9296 (fatal_error_code, fatal_error_signal_hook, standard_args):
9298 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9299 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9300 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9301 * lisp.h (fatal_error_signal_hook): Remove decl.
9302 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9304 * editfns.c: Move a (normally-unused) function to its only use.
9305 * editfns.c, lisp.h (get_operating_system_release): Remove.
9306 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9307 worth the hassle of breaking this out.
9309 * xterm.c: Make symbols static if they're not exported.
9310 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9311 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9312 (x_destroy_window, x_delete_display):
9314 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9315 (x_mouse_leave): Remove; unused.
9316 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9317 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9318 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9320 (x_mouse_leave): Declare only if WINDOWSNT.
9321 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9322 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9325 * ftxfont.c: Make symbols static if they're not exported.
9326 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9328 * font.h (ftxfont_driver): Likewise.
9330 * xfns.c: Make symbols static if they're not exported.
9331 (x_last_font_name, x_display_info_for_name):
9332 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9333 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9334 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9335 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9336 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9337 (last_show_tip_args): Now static.
9338 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9339 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9340 (x_screen_planes): Remove; unused.
9341 * dispextern.h (x_screen_planes): Remove decl.
9343 * dispnew.c: Make symbols static if they're not exported.
9344 * dispextern.h (redraw_garbaged_frames, scrolling):
9345 (increment_row_positions): Remove.
9346 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9347 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9349 (redraw_garbaged_frames): Remove; unused.
9351 * xfaces.c: Make symbols static if they're not exported.
9352 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9354 * xterm.h (defined_color): Remove decls.
9355 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9356 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9357 (menu_face_changed_default, defined_color, free_realized_face):
9358 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9359 (ascii_face_of_lisp_face): Remove; unused.
9361 * xdisp.c: Make symbols static if they're not exported.
9362 * dispextern.h (scratch_glyph_row, window_box_edges):
9363 (glyph_to_pixel_coords, set_cursor_from_row):
9364 (get_next_display_element, set_iterator_to_next):
9365 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9366 (show_mouse_face): Remove decls
9367 * frame.h (message_buf_print): Likewise.
9368 * lisp.h (pop_message, set_message, check_point_in_composition):
9370 * xterm.h (set_vertical_scroll_bar): Likewise.
9371 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9372 (message_buf_print, scratch_glyph_row, displayed_buffer):
9373 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9374 (get_next_display_element, show_mouse_face, window_box_edges):
9375 (frame_to_window_pixel_xy, check_point_in_composition):
9376 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9377 (glyph_to_pixel_coords): Remove; unused.
9379 * dired.c (file_name_completion): Now static.
9381 * dbusbind.c (xd_in_read_queued_messages): Now static.
9383 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9384 * data.c (circular_list_error): Remove.
9386 * commands.h (last_point_position, last_point_position_buffer):
9387 (last_point_position_window): Remove decls.
9388 * keyboard.c: Make these variables static.
9390 * coding.h (coding, code_convert_region, encode_coding_gap):
9392 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9393 (iso_code_class, detect_coding, code_convert_region): Now static.
9394 (encode_coding_gap): Remove; unused.
9396 * chartab.c (chartab_chars, chartab_bits): Now static.
9398 * charset.h (charset_iso_8859_1): Remove decl.
9399 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9402 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9403 * ccl.c (Vccl_program_table): Now static.
9404 (check_ccl_update): Remove; unused.
9406 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9407 * category.h: ... from here.
9408 * category.c (check_category_table, set_category_set): Now static.
9410 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9411 * lisp.h: Remove these decls.
9413 * buffer.c (buffer_count): Remove unused var.
9415 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9416 so that it's not optimized away.
9417 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9418 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9419 exported only to the debugger.
9421 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9422 * atimer.h (run_all_atimers): Remove; not exported.
9424 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9425 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9426 was inaccessible from Lisp.
9427 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9428 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9430 alloc.c: Import and export fewer symbols, and remove unused items.
9431 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9433 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9434 it's not optimized away by whole-program optimization.
9435 (message_enable_multibyte, free_misc): Remove.
9436 (catchlist, handlerlist, mark_backtrace):
9437 Declare only if BYTE_MARK_STACK.
9438 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9439 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9440 (message_enable_multibyte): Remove decl.
9441 (free_misc, interval_free_list, float_block, float_block_index):
9442 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9443 (cons_free_list, last_marked_index):
9445 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9446 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9447 (mark_backtrace): Define only if BYTE_MARK_STACK.
9448 * xdisp.c (message_enable_multibyte): Now static.
9450 Declare Lisp_Object Q* variables to be 'static' if not exported.
9451 This makes it easier for human readers (and static analyzers)
9452 to see whether these variables are used from other modules.
9453 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9454 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9455 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9456 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9457 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9458 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9459 * xmenu.c, xselect.c:
9460 Declare Q* vars static if they are not used in other modules.
9461 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9462 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9463 Remove decls of unexported vars.
9464 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9466 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9468 Make Emacs functions such as Fatom 'static' by default.
9469 This makes it easier for human readers (and static analyzers)
9470 to see whether these functions can be called from other modules.
9471 DEFUN now defines a static function. To make the function external
9472 so that it can be used in other C modules, use the new macro DEFUE.
9473 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9474 (Finit_image_library):
9475 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9476 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9477 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9478 Remove decls, since these functions are now static.
9479 (Funintern, Fget_internal_run_time): New decls, since these functions
9480 were already external.
9482 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9483 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9484 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9485 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9486 * keyboard.c, keymap.c, lread.c:
9487 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9488 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9489 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9490 Mark functions with DEFUE instead of DEFUN,
9491 if they are used in other modules.
9492 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9493 decls for now-static functions.
9494 * buffer.h (Fdelete_overlay): Remove decl.
9495 * callproc.c (Fgetenv_internal): Mark as internal.
9496 * composite.c (Fremove_list_of_text_properties): Remove decl.
9497 (Fcomposition_get_gstring): New forward static decl.
9498 * composite.h (Fcomposite_get_gstring): Remove decl.
9499 * dired.c (Ffile_attributes): New forward static decl.
9500 * doc.c (Fdocumntation_property): New forward static decl.
9501 * eval.c (Ffetch_bytecode): New forward static decl.
9502 (Funintern): Remove extern decl; now in .h file where it belongs.
9503 * fileio.c (Fmake_symbolic_link): New forward static decl.
9504 * image.c (Finit_image_library): New forward static decl.
9505 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9506 * intervals.h (Fprevious_property_change):
9507 (Fremove_list_of_text_properties): Remove decls.
9508 * keyboard.c (Fthis_command_keys): Remove decl.
9509 (Fcommand_execute): New forward static decl.
9510 * keymap.c (Flookup_key): New forward static decl.
9511 (Fcopy_keymap): Now static.
9512 * keymap.h (Flookup_key): Remove decl.
9513 * process.c (Fget_process): New forward static decl.
9514 (Fprocess_datagram_address): Mark as internal.
9515 * syntax.c (Fsyntax_table_p): New forward static decl.
9516 (skip_chars): Remove duplicate decl.
9517 * textprop.c (Fprevious_property_change): New forward static decl.
9518 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9520 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9521 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9523 * editfns.c (Fformat): Remove unreachable code.
9525 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9527 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9530 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9532 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9533 when at ZV. (Bug#8487)
9535 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9537 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9539 * keyboard.c (parse_tool_bar_item): Likewise.
9540 * sound.c (sound_cleanup, alsa_close): Likewise.
9541 * termcap.c (tgetent): Likewise.
9542 * xfns.c (x_default_font_parameter): Likewise.
9543 * xsettings.c (read_and_apply_settings): Likewise.
9545 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9546 (overrun_check_free): Protoize.
9548 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9550 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9551 since callers should never pass a negative size.
9552 Change the signature to match that of plain 'read' and 'write'; see
9553 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9554 * lisp.h: Update prototypes of emacs_write and emacs_read.
9556 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9558 * xdisp.c (redisplay_window): Don't try to determine the character
9559 position of the scroll margin if the window start point w->startp
9560 is outside the buffer's accessible region. (Bug#8468)
9562 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9564 Fix write-region and its subroutines for buffers > 2GB.
9565 * fileio.c (a_write, e_write): Modify declaration of arguments and
9566 local variables to support buffers larger than 2GB.
9567 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9569 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9570 argument, local variables, and return value.
9572 * lisp.h: Update prototypes of emacs_write and emacs_read.
9574 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9576 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9578 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9580 Fix more problems found by GCC 4.6.0's static checks.
9582 * xdisp.c (vmessage): Use a better test for character truncation.
9584 * charset.c (load_charset_map): <, not <=, for optimization,
9585 and to avoid potential problems with integer overflow.
9586 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9587 * casetab.c (set_identity, shuffle): Likewise.
9588 * editfns.c (Fformat): Likewise.
9589 * syntax.c (skip_chars): Likewise.
9591 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9592 This also lets GCC 4.6.0 generate slightly better loop code.
9594 * callint.c (Fcall_interactively): <, not <=, for optimization.
9595 (Fcall_interactively): Count the number of arguments produced,
9596 not the number of arguments given. This is simpler and lets GCC
9597 4.6.0 generate slightly better code.
9599 * ftfont.c: Distingish more carefully between FcChar8 and char.
9600 The previous code passed unsigned char * to a functions like
9601 strlen and xstrcasecmp that expect char *, which does not
9602 conform to the C standard.
9603 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9604 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9605 char * when the C standard requires it.
9607 * keyboard.c (read_char): Remove unused var.
9609 * eval.c: Port to Windows vsnprintf (Bug#8435).
9611 (SIZE_MAX): Define if the headers do not.
9612 (verror): Do not give up if vsnprintf returns a negative count.
9613 Instead, grow the buffer. This ports to Windows vsnprintf, which
9614 does not conform to C99. Problem reported by Eli Zaretskii.
9615 Also, simplify the allocation scheme, by avoiding the need for
9616 calling realloc, and removing the ALLOCATED variable.
9618 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9620 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9621 But keep the doprint source code for now, as we might revamp it
9622 and use it again (Bug#8435).
9623 * lisp.h (doprnt): Remove.
9624 * Makefile.in (base_obj): Remove doprnt.o.
9625 * deps.mk (doprnt.o): Remove.
9627 error: Print 32- and 64-bit integers portably (Bug#8435).
9628 Without this change, on typical 64-bit hosts error ("...%d...", N)
9629 was used to print both 32- and 64-bit integers N, which relied on
9631 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9632 * lisp.h (error, verror): Mark as printf-like functions.
9633 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9634 Report overflow in size calculations when allocating printf buffer.
9635 Do not truncate output string at its first null byte.
9636 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9637 Truncate the output at a character boundary, since vsnprintf does not
9639 * charset.c (check_iso_charset_parameter): Convert internal
9640 character to string before calling 'error', since %c now has the
9642 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9643 overflow when computing char to be passed to 'error'. Do not
9644 pass Lisp_Object to 'error'; pass the integer instead.
9645 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9646 formatted with plain %d.
9648 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9650 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9652 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9654 * xterm.c (x_catch_errors): Remove duplicate declaration.
9656 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9658 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9660 2011-04-10 Jim Meyering <meyering@redhat.com>
9662 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9663 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9664 return ssize_t not "int", and use size_t as the buffer length.
9665 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9666 * gnutls.h: Update declarations.
9667 * process.c (read_process_output): Use ssize_t, to match.
9668 (send_process): Likewise.
9670 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9672 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9674 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9676 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9677 Use unsigned char, to match FcChar8 type definition.
9679 * xterm.c (handle_one_xevent):
9680 * xmenu.c (create_and_show_popup_menu):
9681 * xselect.c (x_decline_selection_request)
9682 (x_reply_selection_request): Avoid type-punned deref of X events.
9684 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9686 Fix some uses of `int' instead of EMACS_INT.
9687 * search.c (string_match_1, fast_string_match)
9688 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9689 (scan_buffer, find_next_newline_no_quit)
9690 (find_before_next_newline, search_command, Freplace_match)
9691 (Fmatch_data): Make some `int' variables be EMACS_INT.
9693 * xdisp.c (display_count_lines): 3rd argument and return value now
9694 EMACS_INT. All callers changed.
9695 (pint2hrstr): Last argument is now EMACS_INT.
9697 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9698 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9699 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9700 (decode_coding_utf_16, decode_coding_emacs_mule)
9701 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9702 (decode_coding_ccl, decode_coding_charset)
9703 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9704 (decode_coding_iso_2022, decode_coding_emacs_mule)
9705 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9706 <char_offset, last_offset>: Declare EMACS_INT.
9707 (encode_coding_utf_8, encode_coding_utf_16)
9708 (encode_coding_emacs_mule, encode_invocation_designation)
9709 (encode_designation_at_bol, encode_coding_iso_2022)
9710 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9711 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9713 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9714 (encode_invocation_designation): Last argument P_NCHARS is now
9716 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9717 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9719 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9722 * ccl.c (Fccl_execute_on_string): Declare some variables
9725 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9727 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9729 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9731 * process.c (Fformat_network_address): Doc fix.
9733 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9735 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9737 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9739 * keyboard.c (read_char): Call Lisp function help-form-show,
9740 instead of using internal_with_output_to_temp_buffer.
9741 (Qhelp_form_show): New var.
9742 (syms_of_keyboard): Use DEFSYM macro.
9744 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9746 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9748 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9750 * process.c (Flist_processes): Remove to Lisp.
9751 (list_processes_1): Delete.
9753 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9755 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9757 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9759 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9761 Fix more problems found by GCC 4.6.0's static checks.
9763 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9765 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9767 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9769 * xdisp.c (vmessage): Mark as a printf-like function.
9771 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9773 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9775 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9776 printf-like functions.
9777 (tiff_load): Add casts to remove these marks before passing them
9778 to system-supplied API.
9780 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9782 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9783 This avoids several warnings with gcc -Wstrict-overflow.
9784 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9785 directly, rather than having caller test rule sign. This avoids
9786 some unnecessary tests.
9787 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9788 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9789 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9791 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9792 (xfont_open): Avoid unnecessary tests.
9794 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9796 * composite.h, composite.c (composition_gstring_put_cache):
9797 Use EMACS_INT, not int, for length.
9799 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9800 breaking out part of COMPOSITION_DECODE_RULE.
9801 (COMPOSITION_DECODE_RULE): Use it.
9802 * composite.c (get_composition_id): Remove unused local vars,
9803 by using the new macro.
9805 * textprop.c (set_text_properties_1): Change while to do-while,
9806 since the condition is always true at first.
9808 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9809 (interval_deletion_adjustment): Return unsigned value.
9812 * process.c (list_processes_1, create_pty, read_process_output):
9813 (exec_sentinel): Remove vars that were set but not used.
9814 (create_pty): Remove unnecessary "volatile"s.
9815 (Fnetwork_interface_info): Avoid possibility of int overflow.
9816 (read_process_output): Do adaptive read buffering even if carryover.
9817 (read_process_output): Simplify nbytes computation if buffered.
9819 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9821 * syntax.c (scan_words): Remove var that was set but not used.
9822 (update_syntax_table): Use unsigned instead of int.
9824 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9825 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9826 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9828 * print.c (print_error_message): Avoid int overflow.
9830 * font.c (font_list_entities): Redo for clarity,
9831 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9833 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9834 (font_score): Avoid potential overflow in diff calculation.
9836 * fns.c (substring_both): Remove var that is set but not used.
9837 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9839 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9841 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9842 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9843 can always succeed if overflow has undefined behavior.
9845 * search.c (boyer_moore, wordify): Remove vars set but not used.
9846 (wordify): Omit three unnecessary tests.
9848 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9849 All callers changed. This avoids the need for an unused var.
9851 * casefiddle.c (casify_region): Remove var that is set but not used.
9853 * dired.c (file_name_completion): Remove var that is set but not used.
9855 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9857 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9858 (Finsert_file_contents): Remove unnecessary code checking fd.
9860 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9861 Check for integer overflow on size calculations.
9863 * buffer.c (Fprevious_overlay_change): Remove var that is set
9866 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9867 Remove vars that are set but not used.
9868 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9869 (timer_check_2): Mark vars as initialized.
9871 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9873 * image.c (lookup_image): Remove var that is set but not used.
9874 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9876 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9877 that are set but not used.
9879 * xfns.c (make_invisible_cursor): Don't return garbage
9880 if XCreateBitmapFromData fails (Bug#8410).
9882 * xselect.c (x_get_local_selection, x_handle_property_notify):
9883 Remove vars that are set but not used.
9885 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9886 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9888 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9889 Remove var that is set but not used.
9890 (scroll_bar_windows_size): Now size_t, not int.
9891 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9894 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9895 (map_tty_color) [!defined MSDOS]: Likewise.
9897 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9899 * coding.c: Remove vars that are set but not used.
9900 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9901 All callers changed.
9902 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9903 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9904 (decode_coding_charset): Remove vars that are set but not used.
9906 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9907 that is set but not used.
9909 * print.c (print_object): Remove var that is set but not used.
9911 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9912 The gnulib version avoids calling malloc in the usual case,
9913 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9914 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9915 * filelock.c (current_lock_owner): Likewise.
9916 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9917 * sysdep.c: Include allocator.h, careadlinkat.h.
9918 (emacs_no_realloc_allocator): New static constant.
9919 (emacs_readlink): New function.
9920 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9921 ../lib/careadlinkat.h.
9923 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9925 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9926 first non-nil return value).
9928 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9930 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9931 if not defined (Bug#8403).
9933 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9935 * xdisp.c (display_count_lines): Remove parameter `start',
9936 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9937 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9938 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9939 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9940 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9941 and thereabouts. All callers changed.
9942 (get_per_char_metric): Remove parameter `f', unused since
9943 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9945 2011-04-02 Jim Meyering <meyering@redhat.com>
9947 do not dereference NULL upon failed strdup
9948 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9949 (ns_get_family): Likewise.
9951 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9953 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9955 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9957 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9960 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9962 Add lexical binding.
9964 * window.c (Ftemp_output_buffer_show): New fun.
9965 (Fsave_window_excursion):
9966 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9968 * lread.c (lisp_file_lexically_bound_p): New function.
9969 (Fload): Bind Qlexical_binding.
9970 (readevalloop): Remove `evalfun' arg.
9971 Bind Qinternal_interpreter_environment.
9972 (Feval_buffer): Bind Qlexical_binding.
9973 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9975 (syms_of_lread): Declare `lexical-binding'.
9977 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9979 * keyboard.c (eval_dyn): New fun.
9980 (menu_item_eval_property): Use it.
9982 * image.c (parse_image_spec): Use Ffunctionp.
9984 * fns.c (concat, mapcar1): Accept byte-code-functions.
9986 * eval.c (Fsetq): Handle lexical vars.
9987 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9988 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9989 (FletX, Flet): Obey lexical binding.
9990 (Fcommandp): Handle closures.
9991 (Feval): New `lexical' arg.
9992 (eval_sub): New function extracted from Feval. Use it almost
9993 everywhere where Feval was used. Look up vars in lexical env.
9995 (Ffunctionp): Move from subr.el.
9996 (Ffuncall): Handle closures.
9997 (apply_lambda): Remove `eval_flags'.
9998 (funcall_lambda): Handle closures and new byte-code-functions.
9999 (Fspecial_variable_p): New function.
10000 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10001 but without exporting it to Lisp.
10003 * doc.c (Fdocumentation, store_function_docstring):
10004 * data.c (Finteractive_form): Handle closures.
10006 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10009 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10011 (exec_byte_code): New function extracted from Fbyte_code to handle new
10012 calling convention for byte-code-functions. Add new byte-codes.
10014 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10016 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10018 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10020 * xdisp.c (redisplay_internal): Fix prototype.
10022 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10024 * xdisp.c (SCROLL_LIMIT): New macro.
10025 (try_scrolling): Use it when setting scroll_limit.
10026 Limit scrolling to 100 screen lines.
10027 (redisplay_window): Even when falling back on "recentering",
10028 position point in the window according to scroll-conservatively,
10029 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10031 (try_scrolling): When point is above the window, allow searching
10032 as far as scroll_max, or one screenful, to compute vertical
10033 distance from PT to the scroll margin position. This prevents
10034 try_scrolling from unnecessarily failing when
10035 scroll-conservatively is set to a value slightly larger than the
10036 window height. Clean up the case of PT below the margin at bottom
10037 of window: scroll_max can no longer be INT_MAX. When aggressive
10038 scrolling is in use, don't let point enter the opposite scroll
10039 margin as result of the scroll.
10040 (syms_of_xdisp) <scroll-conservatively>: Document the
10041 threshold of 100 lines for never-recentering scrolling.
10043 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10045 * dispextern.h (move_it_by_lines):
10046 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10047 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10048 (message_log_check_duplicate): Remove parameters `prev_bol' and
10049 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10050 (redisplay_internal): Remove parameter `preserve_echo_area',
10051 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10053 * indent.c (Fvertical_motion):
10054 * window.c (window_scroll_pixel_based, Frecenter):
10055 Don't pass `need_y_p' to `move_it_by_lines'.
10057 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10059 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10060 steal a few bits to be more compact.
10061 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10062 Remove unneeded casts.
10064 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10066 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10068 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10069 binding" message (bug#7967).
10071 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10073 Fix more problems found by GCC 4.6.0's static checks.
10075 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10076 Remove unused local var.
10078 * editfns.c (Fmessage_box): Remove unused local var.
10080 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10081 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10082 Omit unused local vars.
10083 * window.c (shrink_windows): Omit unused local var.
10084 * menu.c (digest_single_submenu): Omit unused local var.
10085 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10086 Omit unused local var.
10088 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10089 Don't assume string length fits in int.
10090 (keyremap_step, read_key_sequence): Use size_t for sizes.
10091 (read_key_sequence): Don't check last_real_key_start redundantly.
10093 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10094 instead of alloca (Bug#8344).
10096 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10097 (Fbacktrace_frame): Don't assume nframes fits in int.
10099 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10101 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10104 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10106 * cm.c (calccost): Turn while-do into do-while, for clarity.
10108 * keyboard.c (syms_of_keyboard): Use the same style as later
10109 in this function when indexing through an array. This also
10110 works around GCC bug 48267.
10112 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10114 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10116 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10117 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10119 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10120 This avoids undefined behavior on integer overflow, and is a bit
10121 more convenient anyway since it is compared to a size_t variable.
10123 Variadic C functions now count arguments with size_t, not int.
10124 This avoids an unnecessary limitation on 64-bit machines, which
10125 caused (substring ...) to crash on large vectors (Bug#8344).
10126 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10127 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10128 All variadic functions and their callers changed accordingly.
10129 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10130 * data.c (arith_driver, float_arith_driver): Likewise.
10131 * editfns.c (general_insert_function): Likewise.
10132 * eval.c (struct backtrace.nargs, interactive_p)
10133 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10134 (funcall_lambda, mark_backtrace): Likewise.
10135 * fns.c (concat): Likewise.
10136 * frame.c (x_set_frame_parameters): Likewise.
10137 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10138 0 if not found, not -1. All callers changed.
10140 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10141 (stack_copy_size): Now size_t, not int.
10142 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10144 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10146 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10147 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10148 All callers changed.
10150 * lisp.h (multibyte_char_to_unibyte):
10151 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10152 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10153 * character.h (CHAR_TO_BYTE8):
10154 * cmds.c (internal_self_insert):
10155 * editfns.c (general_insert_function):
10156 * keymap.c (push_key_description):
10157 * search.c (Freplace_match):
10158 * xdisp.c (message_dolog, set_message_1): All callers changed.
10160 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10162 * keyboard.c (safe_run_hook_funcall): New function.
10163 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10164 don't set the hook to nil, but remove the offending function instead.
10165 (Qcommand_hook_internal): Remove, unused.
10166 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10167 Vcommand_hook_internal.
10169 * eval.c (enum run_hooks_condition): Remove.
10170 (funcall_nil, funcall_not): New functions.
10171 (run_hook_with_args): Call each function through a `funcall' argument.
10172 Remove `cond' argument, now redundant.
10173 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10174 (Frun_hook_with_args_until_failure): Adjust accordingly.
10175 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10177 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10179 * dispextern.h (string_buffer_position): Remove declaration.
10181 * print.c (strout): Remove parameter `multibyte', unused since
10182 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10184 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10185 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10186 All callers changed.
10188 * w32.c (_wsa_errlist): Use braces for struct initializers.
10190 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10191 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10192 All callers changed.
10193 (string_buffer_position): Likewise. Also, make static (it's never
10194 used outside xdisp.c).
10195 (cursor_row_p): Remove parameter `w', unused since
10196 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10197 (decode_mode_spec): Remove parameter `precision', introduced during
10198 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10199 All callers changed.
10201 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10203 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10205 2011-03-27 Anders Lindgren <andlind@gmail.com>
10207 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10208 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10209 (ns_update_auto_hide_menu_bar): New functions.
10210 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10211 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10212 ns_constrain_all_frames.
10213 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10214 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10216 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10218 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10220 2011-03-27 Glenn Morris <rgm@gnu.org>
10222 * syssignal.h: Replace RETSIGTYPE with void.
10223 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10224 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10225 Replace SIGTYPE with void everywhere.
10226 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10227 * s/template.h (SIGTYPE): Remove commented out definition.
10229 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10231 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10232 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10234 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10236 * w32.c (read_unc_volume): Use parameter `henum', instead of
10237 global variable `wget_enum_handle'.
10239 * keymap.c (describe_vector): Remove parameters `indices' and
10240 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10241 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10243 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10245 * keyboard.c (timer_check): Remove parameter `do_it_now',
10246 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10247 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10248 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10250 * keyboard.c (read_char):
10251 * w32menu.c (w32_menu_display_help):
10252 * xmenu.c (show_help_event, menu_help_callback):
10253 Adjust calls to `show_help_echo'.
10255 * gtkutil.c (xg_maybe_add_timer):
10256 * keyboard.c (readable_events):
10257 * process.c (wait_reading_process_output):
10258 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10260 * insdel.c (adjust_markers_gap_motion):
10261 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10262 (gap_left, gap_right): Don't call it.
10264 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10266 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10267 incurred during fontification.
10269 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10271 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10272 (DEFVAR_PER_BUFFER): Don't pass it.
10274 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10275 (scrolling_window): Don't pass it.
10277 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10279 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10281 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10283 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10284 of variables specific to SELinux and computation of `encoded_absname'.
10286 * image.c (XPutPixel): Remove unused variable `height'.
10288 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10290 * unexw32.c (get_section_info): Remove unused variable `section'.
10292 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10293 (system_process_attributes): Remove unused variable `sess'.
10294 (sys_read): Remove unused variable `err'.
10296 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10297 (w32_wnd_proc): Remove unused variable `isdead'.
10298 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10299 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10300 (x_create_tip_frame): Remove unused variable `tem'.
10302 * w32inevt.c (w32_console_read_socket):
10303 Remove unused variable `no_events'.
10305 * w32term.c (x_draw_composite_glyph_string_foreground):
10306 Remove unused variable `width'.
10308 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10310 * w32term.c (x_set_glyph_string_clipping):
10311 Don't pass uninitialized region to CombineRgn.
10313 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10315 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10316 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10317 (Fx_close_connection): Remove unused variable `i'.
10319 * w32font.c (w32font_draw): Return number of glyphs.
10320 (w32font_open_internal): Remove unused variable `i'.
10321 (w32font_driver): Add missing initializer.
10323 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10324 (fill_in_menu): Remove unused variable `items_added'.
10326 * w32term.c (last_mouse_press_frame): Remove static global variable.
10327 (w32_clip_to_row): Remove unused variable `f'.
10328 (x_delete_terminal): Remove unused variable `i'.
10330 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10331 (NOTHING): Remove unused static global variable.
10332 (uniscribe_check_otf): Remove unused variable `table'.
10333 (uniscribe_font_driver): Add missing initializers.
10335 2011-03-23 Julien Danjou <julien@danjou.info>
10337 * term.c (Fsuspend_tty, Fresume_tty):
10338 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10339 * window.c (temp_output_buffer_show):
10340 * insdel.c (signal_before_change):
10341 * frame.c (Fhandle_switch_frame):
10342 * fileio.c (Fdo_auto_save):
10343 * emacs.c (Fkill_emacs):
10344 * editfns.c (save_excursion_restore):
10345 * cmds.c (internal_self_insert):
10346 * callint.c (Fcall_interactively):
10347 * buffer.c (Fkill_all_local_variables):
10348 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10350 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10351 unconditionally since it does the check itself.
10353 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10355 Fix more problems found by GCC 4.5.2's static checks.
10357 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10358 the first time through the loop, since we know p0 < p1 then.
10359 This also avoids a gcc -Wstrict-overflow warning.
10361 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10362 leading to a memory leak, possible in functions like
10363 load_charset_map_from_file that can allocate an unbounded number
10364 of objects (Bug#8318).
10366 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10367 that could (at least in theory) be that large.
10369 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10370 This is less likely to overflow, and avoids undefined behavior if
10371 overflow does occur. All callers changed. Use strtoul to scan
10372 for the unsigned long integer.
10373 (pint2hrstr): Simplify and tune code slightly.
10374 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10376 * scroll.c (do_scrolling): Work around GCC bug 48228.
10377 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10379 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10380 This also avoids a warning with gcc -Wstrict-overflow.
10381 (validate_x_resource_name): Simplify count usage.
10382 This also avoids a warning with gcc -Wstrict-overflow.
10384 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10387 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10389 * process.c (Fmake_network_process): Use socklen_t, not int,
10390 where POSIX says socklen_t is required in portable programs.
10391 This fixes a porting bug on hosts like 64-bit HP-UX, where
10392 socklen_t is wider than int (Bug#8277).
10393 (Fmake_network_process, server_accept_connection):
10394 (wait_reading_process_output, read_process_output):
10397 * process.c: Rename or move locals to avoid shadowing.
10398 (list_processes_1, Fmake_network_process):
10399 (read_process_output_error_handler, exec_sentinel_error_handler):
10400 Rename or move locals.
10401 (Fmake_network_process): Define label "retry_connect" only if needed.
10402 (Fnetwork_interface_info): Fix pointer signedness.
10403 (process_send_signal): Add cast to avoid pointer signedness problem.
10404 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10405 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10407 Make tparam.h and terminfo.c consistent.
10408 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10409 Include tparam.h instead, since it declares them.
10410 * cm.h (PC): Remove extern decl; tparam.h now does this.
10411 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10412 * terminfo.c: Include tparam.h, to check interfaces.
10413 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10414 (tparam): Adjust signature to match interface in tparam.h;
10415 this removes some undefined behavior. Check that outstring and len
10416 are zero, which they always are with Emacs.
10417 * tparam.h (PC, BC, UP): New extern decls.
10419 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10420 (xftfont_open): Rename locals to avoid shadowing.
10422 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10423 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10424 (OTF_TAG_SYM): Omit macro if not needed.
10425 (ftfont_list): Remove unused local.
10426 (get_adstyle_property, ftfont_pattern_entity):
10427 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10428 Rename locals to avoid shadowing.
10430 * xfont.c (xfont_list_family): Mark var as initialized.
10432 * xml.c (make_dom): Now static.
10434 * composite.c (composition_compute_stop_pos): Rename local to
10436 (composition_reseat_it): Remove unused locals.
10437 (find_automatic_composition, composition_adjust_point): Likewise.
10438 (composition_update_it): Mark var as initialized.
10439 (find_automatic_composition): Mark vars as initialized,
10440 with a FIXME (Bug#8290).
10442 character.h: Rename locals to avoid shadowing.
10443 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10444 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10445 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10446 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10447 to avoid shadowing.
10449 * textprop.c (property_change_between_p): Remove; unused.
10451 * intervals.c (interval_start_pos): Now static.
10453 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10455 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10456 Rename locals to avoid shadowing.
10458 * sound.c (wav_play, au_play, Fplay_sound_internal):
10459 Fix pointer signedness.
10460 (alsa_choose_format): Remove unused local var.
10461 (wav_play): Initialize a variable to 0, to prevent undefined
10462 behavior (Bug#8278).
10464 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10466 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10468 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10469 clobbering (Bug#8298).
10470 * sysdep.c (sys_subshell): Likewise.
10471 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10473 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10474 This should get cleaned up, so that child_setup has the
10475 same signature on all platforms.
10477 * callproc.c (call_process_cleanup): Now static.
10478 (relocate_fd): Rename locals to avoid shadowing.
10480 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10482 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10483 not to be necessary, and produces flickering.
10485 2011-03-20 Glenn Morris <rgm@gnu.org>
10487 * config.in: Remove file.
10489 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10491 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10492 are now in src/globals.h.
10493 (syms_of_minibuf): Remove spurious & from previous change.
10495 2011-03-20 Leo Liu <sdl.web@gmail.com>
10497 * minibuf.c (completing-read-function): New variable.
10498 (completing-read-default): Rename from completing-read.
10499 (completing-read): Call completing-read-function.
10501 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10503 * xfaces.c (Fx_load_color_file):
10504 Read color file from absolute filename (bug#8250).
10506 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10508 * makefile.w32-in: Update dependencies.
10510 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10512 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10514 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10516 Fix more problems found by GCC 4.5.2's static checks.
10518 * process.c (make_serial_process_unwind, send_process_trap):
10519 (sigchld_handler): Now static.
10521 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10522 That way, the code declares only the vars that it needs.
10523 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10524 * s/cygwin.h (PTY_ITERATION): Likewise.
10525 * s/darwin.h (PTY_ITERATION): Likewise.
10526 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10528 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10529 * process.c (allocate_pty): Don't declare stb unless it's needed.
10531 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10532 (CONSTANTLIM): Remove; unused.
10533 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10534 Define only if needed.
10536 * unexelf.c (unexec): Name an expression,
10537 to avoid gcc -Wbad-function-cast warning.
10538 Use a different way to cause a compilation error if anyone uses
10539 n rather than nn, a way that does not involve shadowing.
10540 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10542 * deps.mk (unexalpha.o): Remove; unused.
10544 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10545 * unexec.h: New file.
10546 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10547 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10548 Depend on unexec.h.
10549 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10550 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10551 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10552 Change as necessary to match prototype in unexec.h.
10554 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10556 (back_comment, skip_chars): Mark vars as initialized.
10558 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10559 Rename locals to avoid shadowing.
10561 * lread.c (read1): Rewrite so as not to use empty "else".
10562 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10564 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10566 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10567 warning when compiling print.c.
10569 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10570 instead of using an uninitialized var.
10571 (font_sort_entities): Mark var as initialized.
10573 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10575 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10576 pointers to constants.
10577 (font_parse_fcname): Remove unused vars.
10578 (font_delete_unmatched): Now static.
10579 (font_get_spec): Remove; unused.
10580 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10581 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10582 Rename or move locals to avoid shadowing.
10584 * fns.c (require_nesting_list, require_unwind): Now static.
10585 (Ffillarray): Rename locals to avoid shadowing.
10587 * floatfns.c (domain_error2): Define only if needed.
10588 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10590 * alloc.c (mark_backtrace): Move decl from here ...
10591 * lisp.h: ... to here, so that it can be checked.
10593 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10594 (Fdefvar): Rewrite so as not to use empty "else".
10595 (lisp_indirect_variable): Name an expression,
10596 to avoid gcc -Wbad-function-cast warning.
10597 (Fdefvar): Rename locals to avoid shadowing.
10599 * callint.c (quotify_arg, quotify_args): Now static.
10600 (Fcall_interactively): Rename locals to avoid shadowing.
10601 Use const pointer when appropriate.
10603 * lisp.h (get_system_name, get_operating_system_release):
10604 Move decls here, to check interfaces.
10605 * process.c (get_operating_system_release): Move decl to lisp.h.
10606 * xrdb.c (get_system_name): Likewise.
10607 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10608 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10609 some of which prompt warnings from gcc -Wbad-function-cast.
10610 (Fformat_time_string, Fencode_time, Finsert_char):
10611 (Ftranslate_region_internal, Fformat):
10612 Rename or remove local vars to avoid shadowing.
10613 (Ftranslate_region_internal): Mark var as initialized.
10615 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10618 * lisp.h (eassert): Check that the argument compiles, even if
10619 ENABLE_CHECKING is not defined.
10621 * data.c (Findirect_variable): Name an expression, to avoid
10622 gcc -Wbad-function-cast warning.
10623 (default_value, arithcompare, arith_driver, arith_error): Now static.
10624 (store_symval_forwarding): Rename local to avoid shadowing.
10625 (Fmake_variable_buffer_local, Fmake_local_variable):
10626 Mark variables as initialized.
10627 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10629 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10630 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10631 Rename locals to avoid shadowing.
10632 (mark_stack): Move local variables into the #ifdef region where
10634 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10635 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10637 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10638 (GC_STRING_CHARS): Remove; not used.
10639 (Fmemory_limit): Cast sbrk's returned value to char *.
10641 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10642 avoids undefined behavior in theory.
10644 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10646 Use functions, not macros, for up- and down-casing (Bug#8254).
10647 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10648 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10649 to use the following functions instead of these macros.
10650 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10651 EMACS_INT, since callers assume the returned value fits in int.
10652 (upcase1): Likewise, for UPCASE_TABLE.
10653 (uppercasep, lowercasep, upcase): New static inline functions.
10654 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10655 the race-condition problem in the old DOWNCASE.
10657 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10658 Rename locals to avoid shadowing.
10659 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10660 (regex_compile, re_search_2, re_match_2_internal):
10661 Remove unused local vars.
10662 (FREE_VAR): Rewrite so as not to use empty "else",
10663 which gcc can warn about.
10664 (regex_compile, re_match_2_internal): Mark locals as initialized.
10665 (RETALLOC_IF): Define only if needed.
10666 (WORDCHAR_P): Likewise. This one is never needed, but is used
10667 only in a comment talking about a compiler bug, so put inside
10668 the #if 0 of that comment.
10669 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10670 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10673 * search.c (boyer_moore): Rename locals to avoid shadowing.
10674 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10675 (PREV_CHAR_BOUNDARY): Likewise.
10677 * search.c (simple_search): Remove unused var.
10679 * dired.c (compile_pattern): Move decl from here ...
10680 * lisp.h: ... to here, so that it can be checked.
10681 (struct re_registers): New forward decl.
10683 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10685 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10687 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10688 Rename locals to avoid shadowing.
10689 (Fvertical_motion): Mark locals as initialized.
10691 * casefiddle.c (casify_object, casify_region): Now static.
10692 (casify_region): Mark local as initialized.
10694 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10696 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10697 New macros, so that the caller can use some names other than
10698 gcpro1, gcpro2, etc.
10699 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10701 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10702 argument, for consistency with GCPRO2_VAR, etc: it is now the
10703 prefix of the variable, not the variable itself. All uses
10705 * dired.c (directory_files_internal, file_name_completion):
10706 Rename locals to avoid shadowing.
10708 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10709 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10710 dired.c's scmp function, had undefined behavior.
10711 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10712 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10713 * buffer.h: ... to here, because these macros use current_buffer,
10714 and the new implementation with inline functions needs to have
10715 current_buffer in scope now, rather than later when the macros
10717 (downcase, upcase1): New static inline functions.
10718 (DOWNCASE, UPCASE1): Reimplement using these functions.
10719 This avoids undefined behavior in expressions like
10720 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10721 from race conditions in accessing the global variables
10722 case_temp1 and case_temp2.
10723 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10724 * lisp.h (case_temp1, case_temp2): Remove their decls.
10725 * character.h (ASCII_CHAR_P): Move from here ...
10726 * lisp.h: ... to here, so that the inline functions mentioned
10727 above can use them.
10729 * dired.c (directory_files_internal_unwind): Now static.
10731 * fileio.c (file_name_as_directory, directory_file_name):
10732 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10734 (file_name_as_directory): Use const pointers when appropriate.
10735 (Fexpand_file_name): Likewise. In particular, newdir might
10736 point at constant storage, so make it a const pointer.
10737 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10738 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10740 (Fset_file_times, Finsert_file_contents, auto_save_error):
10741 Rename locals to avoid shadowing.
10743 * minibuf.c (choose_minibuf_frame_1): Now static.
10744 (Ftry_completion, Fall_completions): Rename or remove locals
10745 to avoid shadowing.
10747 * marker.c (bytepos_to_charpos): Remove; unused.
10749 * lisp.h (verify_bytepos, count_markers): New decls,
10750 so that gcc does not warn that these functions aren't declared.
10752 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10753 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10754 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10755 (copy_text): Remove unused local var.
10757 * filelock.c (within_one_second): Now static.
10758 (lock_file_1): Rename local to avoid shadowing.
10760 * buffer.c (fix_overlays_before): Mark locals as initialized.
10761 (fix_start_end_in_overlays): Likewise. This function should be
10762 simplified by using pointers-to-pointers, but that's a different
10764 (switch_to_buffer_1): Now static.
10765 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10766 (report_overlay_modification): Rename locals to avoid shadowing.
10768 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10769 Fix pointer signedness issue.
10770 (sys_subshell): Mark local as volatile if checking for lint,
10771 to suppress a gcc -Wclobbered warning that does not seem to be right.
10772 (MAXPATHLEN): Define only if needed.
10774 * process.c (serial_open, serial_configure): Move decls from here ...
10775 * systty.h: ... to here, so that they can be checked.
10777 * fns.c (get_random, seed_random): Move extern decls from here ...
10778 * lisp.h: ... to here, so that they can be checked.
10780 * sysdep.c (reset_io): Now static.
10781 (wait_for_termination_signal): Remove; unused.
10783 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10784 (copy_keymap_item, append_key, push_text_char_description):
10786 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10787 (DENSE_TABLE_SIZE): Remove; unused.
10788 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10789 (describe_map_tree):
10790 Rename locals to avoid shadowing.
10792 * keyboard.c: Declare functions static if they are not used elsewhere.
10793 (echo_char, echo_dash, cmd_error, top_level_2):
10794 (poll_for_input, handle_async_input): Now static.
10795 (read_char, kbd_buffer_get_event, make_lispy_position):
10796 (make_lispy_event, make_lispy_movement, apply_modifiers):
10797 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10798 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10799 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10800 (read_key_sequence, read_char): Mark locals as initialized.
10801 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10803 * keyboard.h (make_ctrl_char): New decl.
10804 (mark_kboards): Move decl here ...
10805 * alloc.c (mark_kboards): ... from here.
10807 * lisp.h (force_auto_save_soon): New decl.
10809 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10810 (DEFINE_DUMMY_FUNCTION): New macro.
10811 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10813 (main): Add casts to avoid warnings
10814 if GCC considers string literals to be constants.
10816 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10818 * dbusbind.c: Pointer signedness fixes.
10819 (xd_signature, xd_append_arg, xd_initialize):
10820 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10821 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10822 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10823 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10825 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10826 if GCC considers string literals to be constants.
10827 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10829 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10831 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10832 (print_preprocess, print_object): New macro to fix last change.
10834 * print.c (print_preprocess): Don't forget font objects.
10836 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10838 * emacs.c (USAGE3): Doc fixes.
10840 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10842 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10845 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10847 * lisp.h (VWindow_system, Qfile_name_history):
10848 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10849 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10850 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10852 * w32select.c: Don't #include "keyboard.h".
10853 (run_protected): Add extern declaration for waiting_for_input.
10855 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10856 * w32console.c (detect_input_pending, read_input_pending)
10857 (encode_terminal_code):
10858 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10859 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10860 (w32_system_caret_y, Qfile_name_history):
10861 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10862 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10863 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10864 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10865 * w32proc.c (Qlocal, report_file_error):
10866 * w32term.c (Vwindow_system, updating_frame):
10867 * w32uniscribe.c (initialized, uniscribe_font_driver):
10868 Remove unneeded extern declarations.
10870 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10872 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10874 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10876 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10877 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10878 These macros can no longer be used for assignment.
10880 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10881 Assign struct members directly, instead of using BUF_BEGV etc.
10882 (record_buffer_markers, fetch_buffer_markers): New functions for
10883 recording and fetching special buffer markers.
10884 (set_buffer_internal_1, set_buffer_temp): Use them.
10886 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10888 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10890 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10891 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10893 * xdisp.c (hscroll_window_tree):
10894 (reconsider_clip_changes): Use PT instead of BUF_PT.
10896 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10898 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10899 $(EMACS_ROOT)/lib/intprops.h.
10901 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10903 Fix more problems found by GCC 4.5.2's static checks.
10905 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10906 to unsigned char * to avoid compiler diagnostic.
10907 (xg_free_frame_widgets): Make it clear that a local variable is
10908 needed only if USE_GTK_TOOLTIP.
10909 (gdk_window_get_screen): Make it clear that this macro is needed
10910 only if USE_GTK_TOOLTIP.
10911 (int_gtk_range_get_value): New function, which avoids a diagnostic
10912 from gcc -Wbad-function-cast.
10913 (xg_set_toolkit_scroll_bar_thumb): Use it.
10914 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10915 diagnostic from gcc -Wbad-function-cast.
10916 (get_utf8_string, xg_get_file_with_chooser):
10917 Rename locals to avoid shadowing.
10918 (create_dialog): Move locals to avoid shadowing.
10920 * xgselect.c (xg_select): Remove unused var.
10922 * image.c (four_corners_best): Mark locals as initialized.
10923 (gif_load): Initialize transparent_p to zero (Bug#8238).
10924 Mark another local as initialized.
10925 (my_png_error, my_error_exit): Mark with NO_RETURN.
10927 * image.c (clear_image_cache): Now static.
10928 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10929 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10930 (x_edge_detection): Remove unnecessary cast that
10931 gcc -Wbad-function-cast diagnoses.
10932 (gif_load): Fix pointer signedness.
10933 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10934 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10936 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10938 Improve quality of tests for time stamp overflow.
10939 For example, without this patch (encode-time 0 0 0 1 1
10940 1152921504606846976) returns the obviously-bogus value (-948597
10941 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10942 reports time overflow. See
10943 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10944 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10945 * editfns.c: Include limits.h and intprops.h.
10946 (TIME_T_MIN, TIME_T_MAX): New macros.
10947 (time_overflow): Move earlier, to before first use.
10948 (hi_time, lo_time): New functions, for an accurate test for
10949 out-of-range times.
10950 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10951 (Fget_internal_run_time): Don't assume time_t fits in int.
10952 (make_time): Use list2 instead of Fcons twice.
10953 (Fdecode_time): More accurate test for out-of-range times.
10954 (check_tm_member): New function.
10955 (Fencode_time): Use it, to test for out-of-range times.
10956 (lisp_time_argument): Don't rely on undefined left-shift and
10957 right-shift behavior when checking for time stamp overflow.
10959 * editfns.c (time_overflow): New function, refactoring common code.
10960 (Fformat_time_string, Fdecode_time, Fencode_time):
10961 (Fcurrent_time_string): Use it.
10963 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10964 * dired.c (make_time): Move to ...
10965 * editfns.c (make_time): ... here.
10966 * systime.h: Note the move.
10968 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10970 * fringe.c (update_window_fringes): Remove unused variables.
10972 * unexmacosx.c (copy_data_segment): Also copy __got section.
10975 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10977 * termcap.c [MSDOS]: Include "msdos.h".
10978 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10979 Constify `char *' arguments and their references according to
10980 prototypes in tparam.h.
10982 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10984 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10985 Adapt all references accordingly.
10987 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10989 2011-03-11 Tom Tromey <tromey@redhat.com>
10991 * buffer.c (syms_of_buffer): Remove obsolete comment.
10993 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10995 * termhooks.h (encode_terminal_code): Declare prototype.
10997 * msdos.c (encode_terminal_code): Don't declare prototype.
10999 * term.c (encode_terminal_code): Now external again, used by
11000 w32console.c and msdos.c.
11002 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11003 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11005 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11007 Fix some minor problems found by GCC 4.5.2's static checks.
11009 * fringe.c (update_window_fringes): Mark locals as initialized
11011 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11013 * alloc.c (mark_fringe_data): Move decl from here ...
11014 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11015 to check its interface.
11016 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11018 * fontset.c (free_realized_fontset): Now static.
11019 (Fset_fontset_font): Rename local to avoid shadowing.
11020 (fontset_font): Mark local as initialized.
11021 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11023 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11025 * xselect.c (x_disown_buffer_selections): Remove; not used.
11026 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11027 (x_own_selection, Fx_disown_selection_internal): Rename locals
11028 to avoid shadowing.
11029 (x_handle_dnd_message): Remove local to avoid shadowing.
11031 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11032 so that the caller can use some name other than gcpro1.
11033 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11034 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11035 (Fx_backspace_delete_keys_p):
11036 Use them to avoid shadowing, and rename vars to avoid shadowing.
11037 (x_decode_color, x_set_name, x_window): Now static.
11038 (Fx_create_frame): Add braces to silence GCC warning.
11039 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11040 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11041 Remove unused locals.
11042 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11043 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11044 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11047 * xterm.h (x_mouse_leave): New decl.
11049 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11050 Remove unused functions.
11051 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11052 (x_calc_absolute_position): Now static.
11053 (XTread_socket): Don't define label "out" unless it's used.
11054 Don't declare local "event" unless it's used.
11055 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11056 unless they are used.
11057 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11058 (x_fatal_error_signal): Remove; not used.
11059 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11060 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11061 (x_error_catcher, x_connection_closed, x_error_handler):
11062 (x_error_quitter, xembed_send_message, x_iconify_frame):
11063 (my_log_handler): Rename locals to avoid shadowing.
11064 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11065 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11067 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11068 Rename or move locals to avoid shadowing.
11069 (tty_defined_color, merge_face_heights): Now static.
11070 (free_realized_faces_for_fontset): Remove; not used.
11071 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11072 does not deduce is never used uninitialized.
11073 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11074 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11076 * terminal.c (store_terminal_param): Now static.
11078 * xmenu.c (menu_highlight_callback): Now static.
11079 (set_frame_menubar): Remove unused local.
11080 (xmenu_show): Rename parameter to avoid shadowing.
11081 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11082 since they might point to immutable storage.
11083 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11084 since it's unused otherwise.
11086 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11087 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11088 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11089 avoids a gcc -Wuninitialized diagnostic.
11090 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11091 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11092 does not deduce are never used uninitialized.
11094 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11096 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11097 * window.c (window_loop, size_window):
11098 (run_window_configuration_change_hook, enlarge_window): Likewise.
11100 * window.c (display_buffer): Now static.
11101 (size_window): Mark variables that gcc -Wuninitialized
11102 does not deduce are never used uninitialized.
11103 * window.h (check_all_windows): New decl, to forestall
11104 gcc -Wmissing-prototypes diagnostic.
11105 * dispextern.h (bidi_dump_cached_states): Likewise.
11107 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11109 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11110 Include <limits.h>.
11111 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11112 and to avoid gcc -Wuninitialized warning.
11113 (load_charset_map): Mark variables that gcc -Wuninitialized
11114 does not deduce are never used uninitialized.
11115 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11117 * coding.c (coding_set_source, coding_set_destination):
11118 Use "else { /* comment */ }" rather than "else /* comment */;"
11119 for clarity, and to avoid gcc -Wempty-body warning.
11120 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11121 a block, when the outer 'i' will do.
11122 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11123 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11124 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11125 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11126 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11127 Rename locals to avoid shadowing.
11128 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11129 * coding.c (emacs_mule_char, encode_invocation_designation):
11130 Now static, since they're not used elsewhere.
11131 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11132 (decode_coding_object, encode_coding_object, detect_coding_system):
11133 (decode_coding_emacs_mule): Mark variables that gcc
11134 -Wuninitialized does not deduce are never used uninitialized.
11135 (detect_coding_iso_2022): Initialize a local variable that might
11136 be used uninitialized. Leave a FIXME because it's not clear that
11137 this initialization is needed. (Bug#8211)
11138 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11139 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11140 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11141 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11142 Remove unused macros.
11144 * category.c (hash_get_category_set): Remove unused local var.
11145 (copy_category_table): Now static, since it's not used elsewhere.
11146 * character.c (string_count_byte8): Likewise.
11148 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11149 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11151 * chartab.c (copy_sub_char_table): Now static, since it's not used
11153 (sub_char_table_ref_and_range, char_table_ref_and_range):
11154 Rename locals to avoid shadowing.
11155 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11157 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11158 (BIDI_BOB): Remove unused macro.
11160 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11161 deduce are never used uninitialized.
11162 * term.c (encode_terminal_code): Likewise.
11164 * term.c (encode_terminal_code): Now static. Remove unused local.
11166 * tparam.h: New file.
11167 * term.c, tparam.h: Include it.
11168 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11169 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11170 Move these decls to tparam.h, and make them agree with what
11171 is actually in tparam.c. The previous trick of using incompatible
11172 decls in different modules does not conform to the C standard.
11173 All callers of tparam changed to use tparam's actual API.
11174 * tparam.c (tparam1, tparam, tgoto):
11175 Use const pointers where appropriate.
11177 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11178 * cm.h (struct cm): Likewise.
11179 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11180 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11181 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11182 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11183 (turn_on_face, init_tty): Likewise.
11184 * termchar.h (struct tty_display_info): Likewise.
11186 * term.c (term_mouse_position): Rename local to avoid shadowing.
11188 * alloc.c (mark_ttys): Move decl from here ...
11189 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11191 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11193 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11195 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11197 * search.c (compile_pattern_1): Remove argument regp, unused since
11198 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11199 (compile_pattern): Don't pass it.
11201 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11203 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11204 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11206 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11208 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11210 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11211 gdk_window_get_screen, gdk_window_get_geometry,
11212 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11213 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11214 (xg_get_pixbuf_from_pixmap): New function.
11215 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11216 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11217 Call xg_get_pixbuf_from_pixmap instead of
11218 gdk_pixbuf_get_from_drawable.
11219 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11220 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11221 (xg_check_special_colors): Use GtkStyleContext and its functions
11223 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11224 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11225 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11226 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11227 Call gtk_widget_get_preferred_size.
11228 (xg_frame_resized): gdk_window_get_geometry only takes 5
11230 (xg_win_to_widget, xg_event_is_for_menubar):
11231 Call gdk_x11_window_lookup_for_display.
11232 (xg_set_widget_bg): New function.
11233 (delete_cb): New function.
11234 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11235 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11236 (xg_set_background_color): Call xg_set_widget_bg.
11237 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11238 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11239 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11240 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11242 (update_frame_tool_bar): Call gtk_widget_hide.
11243 (xg_initialize): Use GDK_KEY_g.
11245 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11247 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11249 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11250 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11251 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11253 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11255 * w32xfns.c (select_palette): Check success of RealizePalette against
11256 GDI_ERROR, not zero.
11258 See ChangeLog.11 for earlier changes.
11260 ;; Local Variables:
11264 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11266 This file is part of GNU Emacs.
11268 GNU Emacs is free software: you can redistribute it and/or modify
11269 it under the terms of the GNU General Public License as published by
11270 the Free Software Foundation, either version 3 of the License, or
11271 (at your option) any later version.
11273 GNU Emacs is distributed in the hope that it will be useful,
11274 but WITHOUT ANY WARRANTY; without even the implied warranty of
11275 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11276 GNU General Public License for more details.
11278 You should have received a copy of the GNU General Public License
11279 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.