1 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (openFiles): Fix previous checkin.
5 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
7 * indent.c (compute_motion): Remove unused local.
9 2012-07-31 Glenn Morris <rgm@gnu.org>
11 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
12 * s/irix6-5.h: Remove file.
14 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
15 * s/darwin.h: Remove file.
17 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
18 * s/hpux10-20.h: Remove file, which is now empty.
20 2012-07-30 Glenn Morris <rgm@gnu.org>
22 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
23 * Makefile.in (config_h): Add conf_post.h.
24 * makefile.w32-in (CONFIG_H): Add conf_post.h.
26 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
28 * nsterm.m (ns_do_open_file): New variable.
29 (ns_term_init): Set ns_do_open_file to NO after run returns.
30 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
31 files only if ns_do_open_file.
33 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
35 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
36 This no-op macro hasn't been needed for many years.
37 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
39 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
40 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
41 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
42 gdb_make_enums_visible.
43 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
44 (DIRECTORY_SEP): Now a constant, not a macro.
46 2012-07-30 Eli Zaretskii <eliz@gnu.org>
48 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
49 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
51 * w32term.c <w32_keyboard_codepage>: Renamed from
52 keyboard_codepage and now external. All users changed.
54 * w32term.h: Add declaration of w32_keyboard_codepage.
56 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
57 the codepage to translate keys to Unicode. If this argument is
58 -1, use the value returned by GetConsoleCP. All callers changed.
60 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
62 Update .PHONY listings in makefiles.
63 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
64 bootstrap-clean, distclean, maintainer-clean, versioclean,
67 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
68 This is a bit clearer. Fix some commentary typos.
70 2012-07-30 Glenn Morris <rgm@gnu.org>
72 * s/netbsd.h: Let configure include signal.h if needed.
73 Remove file, which is now empty.
75 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
76 Let configure set them.
77 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
78 No more need to undefine.
80 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
82 * keymap.c (Fkey_description): Don't remove 0x80 bit from
83 non-single-byte char when adding meta modifier. (Bug#12090)
85 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
87 Convert safe_call to use variable number of arguments.
88 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
89 (safe_call2): Fix comment.
90 * lisp.h (safe_call): Adjust prototype.
91 * coding.c (encode_coding_object): Change to use safe_call2.
92 * xfaces.c (merge_face_heights): Change to use safe_call1.
94 2012-07-30 Glenn Morris <rgm@gnu.org>
96 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
97 does that unconditionally. Remove file, which is now empty.
99 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
102 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
104 Export to GDB most of lisp.h's remaining object-like macros.
105 * lisp.h (min, max): Move earlier, because they're used earlier now.
106 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
107 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
108 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
109 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
110 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
111 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
112 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
113 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
114 Now constants, for GDB. They need not be macros.
115 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
116 Now constants, for GDB, as well as macros, for static initializers.
117 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
118 Move to after the definition of struct Lisp_Char_Table,
119 since the former now needs that type defined.
120 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
121 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
122 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
123 New enums, for gdb_make_enums_visible.
124 (GLYPH_MODE_LINE_FACE): Remove; unused.
125 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
126 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
127 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
128 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
129 enum maxargs, enum MAX_ALLOCA.
130 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
131 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
132 no longer needed, now that they are done in lisp.h.
134 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
136 Cleanup string bytes checking.
137 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
138 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
139 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
140 (check_sblock, compact_small_strings): Simplify.
142 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
144 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
145 These macros are confusing and no longer need to be defined, as
146 the enum values now suffice. All uses replaced with definiens.
147 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
149 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
151 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
152 ($(BLD)/w32console.$(O)): Update dependencies.
154 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
156 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
157 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
159 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
161 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
163 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
164 setting sitelisp (Bug#12010).
166 2012-07-29 Eli Zaretskii <eliz@gnu.org>
168 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
170 * w32heap.c (cache_system_info):
171 * w32.c (sys_rename):
172 * w32proc.c (find_child_console, sys_kill): All users changed.
174 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
176 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
178 2012-07-29 Eli Zaretskii <eliz@gnu.org>
180 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
182 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
184 Cleanup statistics calculation in Fgarbage_collect.
185 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
186 zombies percentage calculation. Simplify elapsed time calculation.
188 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
190 Generalize marker debugging code under MARKER_DEBUG and use eassert.
191 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
192 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
193 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
194 (replace_range, replace_range_2, del_range_2): Change to eassert.
195 * marker.c (byte_char_debug_check): Adjust style.
197 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
199 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
200 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
201 long-ago-commented-out code that talks about "WIN32".
202 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
205 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
207 Use Gnulib stdalign module (Bug#9772, Bug#9960).
208 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
209 Simplify by using alignof.
210 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
211 * lisp.h: Include <stdalign.h>.
212 (GCALIGNMENT): New macro and constant.
213 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
214 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
215 (stdalign): New macro, if not already defined.
217 2012-07-28 Eli Zaretskii <eliz@gnu.org>
219 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
220 * w32inevt.c: Include w32inevt.h.
221 (w32_read_console_input): New inline function, calls either
222 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
223 w32_console_unicode_input.
224 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
225 (w32_kbd_patch_key, key_event): Use the codepage returned by
226 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
227 (key_event): use uChar.UnicodeChar only if
228 w32_console_unicode_input is non-zero.
230 * w32console.c: Include w32heap.h.
231 <w32_console_unicode_input>: New global variable.
232 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
233 family of Windows, zero otherwise.
235 * w32inevt.h: Declare w32_console_unicode_input.
237 * xdisp.c (init_iterator): Don't reference tip_frame in a build
238 --without-x. (Bug#11742)
240 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
242 Adjust GDB to reflect pvec_type changes (Bug#12036).
243 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
244 2012-07-04 changes to pseudovector representation. Problem
245 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
247 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
249 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
251 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
253 2012-07-27 Eli Zaretskii <eliz@gnu.org>
255 * alloc.c (listn): Fix the order the arguments are consed onto the
258 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
259 enumeration constants, as PURE and HEAP are too general, and clash
260 with other headers and sources, such as gmalloc.c and the
261 MS-Windows system headers. All users changed.
263 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
265 Revert last save_excursion_save and save_excursion_restore changes.
266 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
267 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
269 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
271 Fix recently-introduced typos in Windows port.
272 Reported by Martin Rudalics <rudalics@gmx.at>.
273 * w32.c (init_environment): Replace comma with semicolon.
274 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
276 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
278 Improve GDB symbol export (Bug#12036).
279 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
280 arms of an 'if', not using conditional expressions; otherwise GDB
281 complains about the types in the unevaluated arm when the argument
282 is an integer literal.
283 (xgetint): Simplify expression.
284 * alloc.c (gdb_make_enums_visible): New constant. This ports to
285 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
286 Zaretskii in <http://bugs.gnu.org/12036#13>.
287 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
288 needed now that we have gdb_make_enums_visible.
289 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
290 (enum enum_USE_LSB_TAG):
291 New enum types, packaging up enums that need to be exported to GDB.
293 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
295 Utility function to make a list from specified amount of objects.
296 * lisp.h (enum constype): New datatype.
297 (listn): New prototype.
298 * alloc.c (listn): New function.
299 (Fmemory_use_count, syms_of_alloc): Use it.
300 * buffer.c (syms_of_buffer): Likewise.
301 * callint.c (syms_of_callint): Likewise.
302 * charset.c (define_charset_internal): Likewise.
303 * coding.c (syms_of_coding): Likewise.
304 * keymap.c (syms_of_keymap): Likewise.
305 * search.c (syms_of_search): Likewise.
306 * syntax.c (syms_of_syntax): Likewise.
307 * w32.c (init_environment): Likewise.
308 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
309 * xdisp.c (syms_of_xdisp): Likewise.
310 * xfns.c (syms_of_xfns): Likewise.
312 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
314 Fast save_excursion_save and save_excursion_restore.
315 * lisp.h (struct Lisp_Excursion): New data type.
316 (PVEC_EXCURSION): New pseudovector type.
317 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
318 to deal with it. Adjust comments.
319 (init_marker, attach_marker): New prototype.
320 (unchain_marker): Adjust prototype.
321 * marker.c (attach_marker): Change to global.
322 (init_marker): New function.
323 * alloc.c (Fmake_marker, build_marker): Use it.
324 (build_marker): More easserts.
325 (mark_object): Handle struct Lisp_Excursion.
326 * editfns.c (save_excursion_save, save_excursion_restore):
327 Reimplement to use struct Lisp_Excursion. Add comments.
329 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
331 Fix export of symbols to GDB (Bug#12036).
332 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
333 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
334 emacs.c, as this is a more-suitable home. Had this been done earlier
335 the fix for 12036 would have avoided some of the problems noted in
336 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
337 would have been more obvious.
338 * emacs.c: Do not include <verify.h>; no longer needed.
339 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
340 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
341 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
342 Remove; now done in lisp.h.
343 * lisp.h (PUBLISH_TO_GDB): New macro.
344 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
345 (DATA_SEG_BITS): Use it.
346 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
347 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
348 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
349 not be usable in #if. This simplifies things.
351 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
353 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
355 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
357 Simplify export of symbols to GDB (Bug#12036).
358 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
359 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
360 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
361 Adjust to changes in lisp.h and emacs.c, by using
362 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
363 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
364 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
365 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
366 instead of gdb_valbits.
367 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
368 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
369 instead of gdb_array_mark_flag.
370 (xboolvector): Get size from $->size, not $->header.size.
371 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
372 (xreload, hook-run, hookpost-run): Remove.
373 * emacs.c: Include <verify.h>.
374 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
375 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
377 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
378 (gdb_USE_LSB_TAG): New enum constants.
379 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
380 Also define these as enum constants, so they're visible to GDB.
381 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
382 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
383 as constants, so they're visible to GDB.
384 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
385 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
386 Now enum constants, not macros, so they're visible to GDB.
387 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
388 more convenient now. All uses changed.
389 (VALMASK) [USE_LSB_TAG]: Also define in this case.
390 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
392 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
394 Explicitly free restriction data that are not needed anymore.
395 * editfns.c (save_restriction_restore): Free restriction data.
397 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
399 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
400 add argument, tune behavior, and adjust all callers.
402 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
404 Use typedef for EMACS_INT, EMACS_UINT.
405 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
406 than macros. This simplifies debugging in the usual case, since
407 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
408 and it allows expressions involving EMACS_INT casts.
409 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
411 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
413 * nsterm.m (ns_read_socket): Return early if there is a modal
416 2012-07-25 Martin Rudalics <rudalics@gmx.at>
418 * frame.c (Fredirect_frame_focus): In doc-string don't mention
419 that FOCUS-FRAME can be omitted.
421 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
423 Adjust buffer text indirection counters at the end of Fkill_buffer.
424 * buffer.c (Fkill_buffer): Adjust indirection counters when the
425 buffer is definitely dead. This should really fix an issue reported
426 by Christoph Scholtes again. (Bug#12007).
427 (init_buffer_once): Initialize indirection counters of
428 buffer_defaults and buffer_local_symbols (for sanity and safety).
430 2012-07-24 Eli Zaretskii <eliz@gnu.org>
432 * xdisp.c (init_iterator): Don't compute dimensions of truncation
433 and continuation glyphs on tooltip frames, leave them at zero.
434 Avoids continued lines in tooltips. (Bug#11832)
436 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
438 Simplify copy_overlay.
439 * buffer.c (copy_overlay): Simplify. Use build_marker.
440 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
442 2012-07-23 Eli Zaretskii <eliz@gnu.org>
444 * print.c (print_object): Don't crash when a frame's name is nil
445 or invalid. (Bug#12025)
447 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
448 it signals an error when a tooltip frame is being created.
450 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
452 Cleanup miscellaneous objects allocation and initialization.
453 * alloc.c (allocate_misc): Change to static. Add argument to
454 specify the subtype. Adjust comment and users.
455 (build_overlay): New function.
456 * buffer.c (copy_overlays, Fmake_overlay): Use it.
457 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
458 (allocate_misc): Remove prototype.
459 (build_overlay): Add prototype.
461 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
463 Swap buffer text indirection counters in Fbuffer_swap_text.
464 * buffer.c (Fbuffer_swap_text): Swap indirections too.
465 This avoids crash reported by Christoph Scholtes at
466 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
468 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
470 * nsmenu.m (Popdown_data): New struct.
471 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
473 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
474 (initWithContentRect): Make imgView and contentView non-static
475 and autorelease them. Also autorelease img and matrix (Bug#12005).
476 (dealloc): Remove (Bug#12005).
478 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
480 Adjust consing_since_gc when objects are explicitly freed.
481 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
482 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
483 (free_cons, free_misc): Subtract object size from consing_since_gc.
485 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
487 Simplify and cleanup markers positioning code.
488 * marker.c (attach_marker): More useful eassert.
489 (live_buffer, set_marker_internal): New function.
490 (Fset_marker, set_marker_restricted): Use set_marker_internal.
491 (set_marker_both, set_marker_restricted_both): Use live_buffer.
493 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
495 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
496 as it's limited by the amount of memory, not by INT_MAX.
498 2012-07-21 Eli Zaretskii <eliz@gnu.org>
500 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
501 in special-event-map. See the discussion at
502 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
505 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
506 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
507 Fabrice Popineau <fabrice.popineau@supelec.fr>.
509 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
511 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
512 (conversationIdentifier): Return value is NSInteger.
513 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
515 2012-07-21 Chong Yidong <cyd@gnu.org>
517 * window.c (decode_any_window): Signal an error if the window is
518 on a dead frame (Bug#11984).
520 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
522 Add indirection counting to speed up Fkill_buffer.
523 * buffer.h (struct buffer): New member.
524 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
525 (Fmake_indirect_buffer): Set indirection counter to -1, increment
526 base buffer indirection counter.
527 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
528 (Fkill_buffer): Adjust indirection counters as needed, don't walk
529 through buffer list if indirection counter is 0.
531 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
533 Extend the value returned by Fgarbage_collect with heap statistics.
534 * alloc.c (Qheap): New symbol.
535 (syms_of_alloc): DEFSYM it.
536 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
537 (Fmemory_free): Remove.
538 (syms_of_alloc): Don't defsubr it.
539 * buffer.c (Fcompact_buffer): Remove.
540 (syms_of_buffer): Don't defsubr it.
542 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
544 Make maybe_gc inline.
545 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
546 * lisp.h (consing_since_gc, gc_relative_threshold)
547 (memory_full_cons_threshold): Revert declaration.
548 (maybe_gc): Remove prototype, define as inline.
549 * alloc.c: Remove old commented-out code.
550 (consing_since_gc, gc_relative_threshold)
551 (memory_full_cons_threshold): Revert to global.
554 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
556 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
557 * lisp.h (build_unibyte_string): New function.
558 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
559 * sysdep.c, w32fns.c, xfns.c: Use it.
560 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
561 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
562 Adjust users accordingly.
563 * font.h (font_open_by_name): Adjust prototype.
565 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
567 Cleanup calls to Fgarbage_collect.
568 * lisp.h (maybe_gc): New prototype.
569 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
571 * alloc.c (maybe_gc): New function.
572 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
574 * bytecode.c (MAYBE_GC): Use maybe_gc.
575 * eval.c (eval_sub, Ffuncall): Likewise.
576 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
577 to avoid dependency from auto-save feature.
579 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
581 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
582 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
583 'for_each_per_buffer_object_at'.
584 All uses changed. It's better to use upper-case for macros that
585 cannot be implemented as functions, to give the reader a clue
586 that they're special.
588 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
590 * alloc.c (Fgarbage_collect): Tweak docstring.
592 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
594 Tweak the value returned from Fgarbage_collect again.
595 * alloc.c (Fgarbage_collect): New return value, as confirmed in
596 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
597 Adjust documentation.
598 (total_vector_bytes): Rename to total_vector_slots, adjust
600 (total_free_vector_bytes): Rename to total_free_vector_slots,
602 (Qstring_bytes, Qvector_slots): New symbols.
603 (syms_of_alloc): DEFSYM them.
605 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
607 Buffer compaction primitive which may be used from Lisp.
608 * buffer.c (compact_buffer, Fcompact_buffer): New function.
609 (syms_of_buffer): Register Fcompact_buffer.
610 * alloc.c (Fgarbage_collect): Use compact_buffer.
611 * buffer.h (compact_buffer): New prototype.
612 (struct buffer_text): New member.
614 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
616 New macro to iterate over all buffers, miscellaneous cleanups.
617 * lisp.h (all_buffers): Remove declaration.
618 * buffer.h (all_buffers): Add declaration, with comment.
619 (for_each_buffer): New macro.
620 * alloc.c (Fgarbage_collect, mark_object): Use it.
621 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
622 (init_buffer): Likewise.
623 * data.c (Fset_default): Likewise.
624 * coding.c (code_conversion_restore): Remove redundant check
626 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
628 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
630 Fix bug that created negative-length intervals.
631 * intervals.c (merge_interval_right, merge_interval_left):
632 Do not zero out this interval if it is absorbed by its children,
633 as this interval's total length doesn't change in that case. See
634 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
636 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
638 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
639 when invoking (make-bool-vector N t) and N is a positive
640 multiple of 8 -- the last 8 bits were mistakenly cleared.
642 Remove some struct layout assumptions in bool vectors.
643 * alloc.c (bool_header_size): New constant.
644 (header_size, word_size): Move earlier, as they're now used earlier.
645 Use 'word_size' in a few more places, where it's appropriate.
646 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
647 padding before the data member of a bool vector.
648 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
649 than doing the check by hand with an abort ().
651 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
653 * eval.c (Fdefvar): Don't check constants since we only set the var if
654 it's not yet defined anyway (bug#11904).
656 * lisp.h (last_undo_boundary): Declare new var.
657 * keyboard.c (command_loop_1): Set it.
658 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
659 were auto-added by the command loop (bug#11774).
661 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
663 * w32font.c (Qsymbol): Remove local definition.
664 (syms_of_w32font): Don't DEFSYM it.
666 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
668 Fix sweep_vectors to handle large bool vectors correctly.
669 * alloc.c (sweep_vectors): Account total_vector_bytes for
670 bool vectors larger than VBLOCK_BYTES_MAX.
672 2012-07-18 Chong Yidong <cyd@gnu.org>
674 * frame.c (x_set_frame_parameters): Revert bogus change introduced
675 in 2012-05-25 commit by Paul Eggert (Bug#11738).
677 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
679 Return more descriptive data from Fgarbage_collect.
680 Suggested by Stefan Monnier in
681 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
682 * alloc.c (bounded_number): New function.
683 (total_buffers, total_vectors): New variable.
684 (total_string_size): Rename to total_string_bytes, adjust users.
685 (total_vector_size): Rename to total_vector_bytes, adjust users.
686 (sweep_vectors): Account total_vectors and total_vector_bytes.
687 (Fgarbage_collect): New return value. Adjust documentation.
688 (gc_sweep): Account total_buffers.
689 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
690 (VECTOR_SIZE): Remove.
691 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
692 (Qinterval, Qmisc): New symbols.
693 (syms_of_data): Initialize them.
694 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
695 (Qcons, Qbuffer): New declarations.
697 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
699 * alloc.c (Fmemory_free): Account for memory-free's own storage.
700 Round up, not down. Improve doc.
702 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
704 Restore old code in allocate_string_data to avoid Faset breakage.
705 Reported by Julien Danjou <julien@danjou.info> in
706 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
707 * alloc.c (allocate_string_data): Restore old code with minor
708 adjustments, fix comment to explain this subtle issue.
710 2012-07-17 Eli Zaretskii <eliz@gnu.org>
712 Remove FILE_SYSTEM_CASE.
713 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
715 * fileio.c (FILE_SYSTEM_CASE): Don't define.
716 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
717 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
718 call-process-region passes it through expand-file-name.
720 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
722 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
724 Fix crash when creating indirect buffer (Bug#11917)
725 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
726 Don't handle unbound variables specially if non-zero.
727 (Fbuffer_local_variables): Pass zero.
728 (clone_per_buffer_values): Pass non-zero.
730 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
732 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
733 to make the loop interruptible.
735 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
737 * gnutls.c (emacs_gnutls_handshake): Only retry if
738 GNUTLS_E_INTERRUPTED.
740 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
742 Cleanup and convert miscellaneous checks to eassert.
743 * alloc.c (mark_interval): Fix comment, partially rephrase
744 old comment from intervals.h (see below).
745 * intervals.c (find_interval, adjust_intervals_for_insertion)
746 (delete_interval, adjust_intervals_for_deletion)
747 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
749 (adjust_intervals_for_insertion, make_new_interval):
750 Remove obsolete and unused code.
751 * intervals.h (struct interval): Remove obsolete comment.
752 * textprotp.c (erase_properties): Remove unused code.
753 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
754 (Fremove_list_of_text_properties): Convert to eassert.
756 2012-07-17 Chong Yidong <cyd@gnu.org>
758 * editfns.c (Finsert_char): Doc fix.
760 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
762 Fix previous change to make Fmemory_free always accurate.
763 * alloc.c (make_interval): Update total_free_intervals.
764 (make_float): Likewise for total_free_floats.
765 (free_cons, Fcons): Likewise for total_free_conses.
766 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
767 Likewise for total_free_vector_bytes.
768 (Fmake_symbol): Likewise for total_free_symbols.
769 (bytes_free): Remove.
771 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
773 Simple free memory accounting feature.
774 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
775 (sweep_vectors): Accumulate size of free vectors.
776 (Fgarbage_collect): Setup bytes_free.
777 (Fmemory_free): New function.
778 (syms_of_alloc): Register it.
780 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
782 Cleanup overlays checking.
783 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
784 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
785 eassert and OVERLAYP.
786 (sort_overlays): Change to use OVERLAYP.
788 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
790 * editfns.c (Finsert_char): Make it interactive, and make the
791 second arg optional. Copy interactive spec and docstring from
794 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
796 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
797 Unlike the other wrapped functions, fabs has an unspecified
800 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
802 * nsterm.m (keyDown): Interpret flags without left/right bits
803 as the left key (Bug#11670).
805 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
807 Remove empty and useless init functions.
808 * lisp.h (init_character_once, init_fns, init_image)
809 (init_filelock, init_sound): Remove prototype.
810 * character.c (init_character_once): Remove.
811 * filelock.c (init_filelock): Likewise.
812 * fns.c (init_fns): Likewise.
813 * image.c (init_image): Likewise.
814 * sound.c (init_sound): Likewise.
815 * emacs.c (main): Adjust accordingly.
817 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
819 * gtkutil.h: Tiny cleanups.
820 (use_old_gtk_file_dialog): Remove useless declaration.
821 (xg_uses_old_file_dialog): Add suggested const attribute.
823 2012-07-15 Eli Zaretskii <eliz@gnu.org>
825 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
826 (bidi_paragraph_init): Use it to limit search forward for a strong
827 directional character in abnormally large paragraphs full of
828 neutral or weak characters. (Bug#11943)
830 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
832 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
833 the toolbar (Bug#9451).
834 (xg_make_tool_item): Give the widget event box a transparent
837 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
839 Cleanup basic allocation variables and functions.
840 * alloc.c (ignore_warnings, init_intervals, init_float)
841 (init_cons, init_symbol, init_marker): Remove.
842 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
843 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
844 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
845 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
846 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
847 (staticidx, init_alloc_once, init_strings, free_ablock):
848 Remove redundant initialization.
849 * fns.c (init_weak_hash_tables): Remove.
850 * lisp.h (init_weak_hash_tables): Remove prototype.
852 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
854 Use zero_vector where appropriate.
855 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
857 * lisp.h (zero_vector): New declaration.
858 * font.c (null_vector): Remove.
859 (syms_of_font): Remove initialization and staticpro.
860 (font_list_entities, font_find_for_lface): Change to use zero_vector.
861 * keymap.c (Faccessible_keymaps): Likewise.
863 2012-07-15 Leo Liu <sdl.web@gmail.com>
865 * fringe.c: Fix typo in comments.
867 2012-07-14 Leo Liu <sdl.web@gmail.com>
869 * fringe.c: Add a new bitmap exclamation-mark.
871 2012-07-14 Eli Zaretskii <eliz@gnu.org>
873 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
875 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
876 (HAVE_MENUS): Don't define, defined by editing config.in with
878 (GMALLOC_INHIBIT_VALLOC): Don't define.
879 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
881 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
883 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
885 2012-07-14 Glenn Morris <rgm@gnu.org>
887 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
888 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
889 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
891 2012-07-13 Glenn Morris <rgm@gnu.org>
893 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
895 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
896 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
898 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
900 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
901 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
902 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
903 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
905 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
906 as boolean expression.
907 (x_set_window_size): Remove unused variable toolbar.
908 (ns_get_color_default, ns_mod_to_lisp): Remove.
909 (ns_mouse_position): Remove unused variables xchar and ychar.
910 (ns_compute_glyph_string_overhangs): Remove unused variable face.
911 (ns_set_vertical_scroll_bar): Remove unused variable count.
912 (ns_delete_terminal): Remove unused variable i.
913 (ns_term_init): Remove unused variables r, g and b.
914 (mouseDown): Remove unused variable window.
915 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
916 (initFrameFromEmacs): Remove unused variable vbextra.
917 (mouseEntered): Remove unused variables p and dpyinfo.
918 (mouseExited): Remove unused variables p and r.
919 (ns_define_frame_cursor, ns_clear_frame_area)
920 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
921 (menuDown): Assign [sender tag] to variable and cast the variable.
923 * nsterm.h (menuDown): Add id as type to argument sender.
924 (ns_display_info_for_name): Add Lisp_Object argument.
925 (ns_term_init): Add Lisp_Object argument.
926 (ns_map_event_to_object): Add void argument.
927 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
928 prototype with arguments and only declare if __OBJC__.
929 (nxatoms_of_nsselect): Add void argument.
930 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
931 (ns_alloc_autorelease_pool): Add void argument.
932 (ns_release_autorelease_pool): Add void* argument.
933 (ns_get_defaults_value): Add const char* argument.
935 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
936 (initFromContents): Use SSDATA where appropriate.
937 (ns_update_menubar): Add braces to ambigous if-else.
938 (initWithTitle): Put () around assignment in if statement.
939 (ns_menu_show): Remove unused variables window and keymap.
940 (update_frame_tool_bar): Remove unused variable selected_p.
941 (initWithContentRect): Remove unused variable this_cmd_name.
943 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
945 (setXBMColor): Remove unused variable len.
946 (setPixmapData): Put () around assignment in loop statement.
948 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
949 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
951 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
952 around assignment in loop statement.
953 (nsfont_open): Remove unused variable i.
954 (nsfont_open): Remove unused variable len.
955 (nsfont_draw): Remove unused variable cs.
957 * nsfns.m (x_set_icon_name, ns_set_name_internal)
958 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
959 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
960 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
961 (Fns_font_name, Fns_perform_service)
962 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
963 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
964 (ns_set_name): Remove unused variable view.
965 (x_set_menu_bar_lines): Remove unused variable olines.
966 (x_set_tool_bar_lines): Remove unused variable root_window.
967 (Fns_list_colors): Put () around assignment in while statement.
968 (Fns_perform_service): Remove unused variable len.
969 (Fns_display_usable_bounds): Remove unused variable top.
970 (syms_of_nsfns): Remove unused variable i.
972 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
975 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
977 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
978 and free it with DestroyExceptionInfo (Bug#11558).
980 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
982 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
983 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
984 Set here, not in nt/config.nt.
986 2012-07-13 Eli Zaretskii <eliz@gnu.org>
988 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
989 cursor overflow into the last glyph on display line when the right
990 fringe is off. (Bug#11832)
992 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
994 * xdisp.c (produce_special_glyphs): Now static.
995 * dispextern.h (produce_special_glyphs): Remove decl.
997 2012-07-13 Glenn Morris <rgm@gnu.org>
999 * s/bsd-common, s/cygwin.h: Remove empty files.
1000 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1002 * s/usg5-4-common.h (USG, USG5):
1003 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1004 * s/sol2-6.h (SOLARIS2):
1005 * s/irix6-5.h (IRIX6_5):
1006 * s/hpux10-20.h (USG, USG5, HPUX):
1007 * s/gnu-linux.h (USG, GNU_LINUX):
1008 * s/freebsd.h (BSD_SYSTEM):
1009 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1010 * s/cygwin.h (CYGWIN):
1011 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1012 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1014 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1016 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1018 2012-07-13 Glenn Morris <rgm@gnu.org>
1020 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1022 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1024 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1025 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1027 2012-07-12 Glenn Morris <rgm@gnu.org>
1029 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1031 * process.c (init_process_emacs): Rename from init_process.
1032 The old name is also the name of a Mach system call.
1033 * lisp.h, emacs.c: Update for this name change.
1034 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1037 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1039 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1040 memmove call that removes glyphs covered by the left truncation
1041 glyph. Improve commentary.
1042 (display_line): Fix display of continuation glyphs on GUI frames
1043 when the right fringe is turned off and variable-size fonts are
1044 used in the window. Move the code that appends a stretch glyph to
1045 produce_special_glyphs, so that it could be used for truncation
1046 and continuation glyphs alike.
1047 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1048 glyph of a suitably computed width, to align the special glyphs at
1049 the window margin. Code moved from display_line. (Bug#11832)
1051 2012-07-12 Glenn Morris <rgm@gnu.org>
1053 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1055 * s/gnu-linux.h, s/hpux10-20.h:
1056 Do not unconditionally define HAVE_XRMSETDATABASE.
1058 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1060 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1062 Fix typos that broke OS X build.
1063 Reported by Randal L. Schwartz in
1064 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1065 * nsterm.m (ns_timeout): Add missing local decl.
1066 (ns_get_color): snprintf -> sprintf, to fix typo.
1068 2012-07-12 Glenn Morris <rgm@gnu.org>
1070 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1071 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1072 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1073 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1075 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1076 Move PTY_OPEN to configure.
1078 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1079 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1080 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1082 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1084 Use empty_unibyte_string where applicable.
1085 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1086 * lread.c (read1): Likewise.
1087 * xsettings.c (syms_of_xsettings): Likewise.
1089 2012-07-12 Glenn Morris <rgm@gnu.org>
1091 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1092 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1093 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1094 * s/hpux10-20.h (RUN_TIME_REMAP):
1095 * s/bsd-common.h (TABDLY): Move to configure.
1097 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1099 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1101 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1102 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1104 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1106 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1107 * s/template.h: Move NARROWPROTO to configure.
1109 2012-07-11 Glenn Morris <rgm@gnu.org>
1111 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1112 unused since 2011-01-17 change to systty.h.
1114 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1115 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1116 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1118 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1120 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1122 2012-07-11 Glenn Morris <rgm@gnu.org>
1124 * s/darwin.h, s/gnu-linux.h, s/template.h:
1125 Move INTERRUPT_INPUT to configure.
1127 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1129 Minor adjustments to interning code.
1130 * lisp.h (intern, intern_c_string): Redefine as static inline
1131 wrappers for intern_1 and intern_c_string_1, respectively.
1132 (intern_1, intern_c_string_1): Rename prototypes.
1133 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1135 * font.c (font_intern_prop): Likewise. Adjust comment.
1136 * w32font.c (intern_font_name): Likewise.
1138 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1140 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1142 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1143 of Fcar/Fcdr if possible.
1144 * font.c (check_otf_features): Likewise.
1145 * fontset.c (Fnew_fontset): Likewise.
1146 * gnutls.c (Fgnutls_boot): Likewise.
1147 * minibuf.c (read_minibuf): Likewise.
1148 * msdos.c (IT_set_frame_parameters): Likewise.
1149 * xmenu.c (Fx_popup_dialog): Likewise.
1150 * w32menu.c (Fx_popup_dialog): Likewise.
1152 2012-07-11 Glenn Morris <rgm@gnu.org>
1154 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1155 since nothing has defined it on these platforms.
1157 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1158 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1160 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1161 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1162 Move CLASH_DETECTION to configure.
1164 * s/gnu.h: Remove file, which is now empty.
1166 * s/gnu.h, s/gnu-linux.h:
1167 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1169 2012-07-11 John Wiegley <johnw@newartisans.com>
1171 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1172 function attribute, so we only use it if it exists in the
1175 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1177 Avoid call to strlen in fast_c_string_match_ignore_case.
1178 * search.c (fast_c_string_match_ignore_case): Change to use
1179 length argument. Adjust users accordingly.
1180 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1182 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1184 Assume mkdir, rmdir.
1185 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1186 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1189 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1192 * s/hpux10-20.h (HAVE_PERROR): Remove.
1193 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1194 Remove dummy definition, as this problem was obsolete long ago.
1197 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1199 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1201 Avoid calls to strlen in font processing functions.
1202 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1203 (font_open_by_name): Change to use length argument. Adjust
1205 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1207 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1208 Change to return ptrdiff_t.
1209 (xfont_list_pattern, xfont_match): Use length returned by
1210 xfont_decode_coding_xlfd.
1211 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1213 2012-07-11 Glenn Morris <rgm@gnu.org>
1215 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1216 Move DONT_REOPEN_PTY to configure.
1218 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1219 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1221 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1223 Remove "#define unix" that is no longer needed (Bug#11905).
1224 * s/aix4-2.h (unix): Remove; no longer needed.
1226 EMACS_TIME simplification (Bug#11875).
1227 This replaces macros (which typically do not work in GDB)
1228 with functions, typedefs and enums, making the code easier to debug.
1229 The functional style also makes code easier to read and maintain.
1230 * systime.h: Include <sys/time.h> on all hosts, not just if
1231 WINDOWSNT, since 'struct timeval' is needed in general.
1232 (EMACS_TIME): Now a typedef, not a macro.
1233 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1235 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1236 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1237 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1238 (EMACS_TIME_LE): Now functions, not macros.
1239 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1240 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1241 which are not functions. All uses rewritten to use:
1242 (make_emacs_time): New function.
1243 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1244 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1245 not functions. All uses rewritten to use the following, respectively:
1246 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1247 (add_emacs_time, sub_emacs_time): New functions.
1248 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1249 * fileio.c (Fcopy_file):
1250 * xterm.c (XTflash): Get the current time closer to when it's used.
1251 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1253 * bytecode.c (targets): Suppress -Woverride-init warnings.
1255 Simplify by avoiding confusing use of strncpy etc.
1256 * doc.c (Fsnarf_documentation):
1257 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1258 * frame.c (Fmake_terminal_frame):
1259 * gtkutil.c (get_utf8_string):
1261 * nsmenu.m (ns_update_menubar):
1262 * regex.c (regerror):
1263 Prefer memcpy to strncpy and strncat when either will do.
1264 * fileio.c (Fsubstitute_in_file_name):
1265 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1266 (menu_separator_name_p):
1267 * nsmenu.m (ns_update_menubar):
1268 Prefer memcmp to strncmp when either will do.
1269 * nsterm.m: Include <ftoastr.h>.
1271 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1272 Prefer snprintf to strncpy.
1273 * nsterm.m (ns_term_init):
1274 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1275 * nsterm.m (ns_term_init):
1276 Avoid the need for strncpy, by using build_string or
1277 make_unibyte_string directly. Use dtoastr, not snprintf.
1278 * process.c (Fmake_network_process): Diagnose service names that
1279 are too long, rather than silently truncating them or creating
1280 non-null-terminated names.
1281 (Fnetwork_interface_info): Likewise, for interface names.
1282 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1283 Prefer sprintf to strncat.
1284 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1285 Prefer vsnprintf to vsprintf + strncpy.
1287 2012-07-10 Glenn Morris <rgm@gnu.org>
1289 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1290 Clarify fallback case.
1292 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1294 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1295 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1296 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1297 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1298 where argument type is known to be a Lisp_Cons.
1300 2012-07-10 Tom Tromey <tromey@redhat.com>
1302 * bytecode.c (BYTE_CODE_THREADED): New macro.
1303 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1304 (enum byte_code_op): New type.
1305 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1306 (exec_byte_code): Use them. Use token threading when applicable.
1308 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1310 Optimize pure C strings initialization.
1311 * lisp.h (make_pure_string): Fix prototype.
1312 (build_pure_c_string): New function, defined as static inline. This
1313 provides a better opportunity to optimize away calls to strlen when
1314 the function is called with compile-time constant argument.
1315 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1316 argument, adjust users accordingly. Use build_pure_c_string where
1318 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1319 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1320 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1322 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1324 Avoid calls to strlen in miscellaneous functions.
1325 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1326 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1327 * lread.c (openp): Likewise.
1329 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1331 Avoid calls to strlen in path processing functions.
1332 * fileio.c (file_name_as_directory): Add comment. Change to add
1333 srclen argument and return the length of result. Adjust users
1335 (directory_file_name): Fix comment. Change to add srclen argument,
1336 swap 1st and 2nd arguments to obey the common convention. Adjust
1338 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1340 2012-07-10 Glenn Morris <rgm@gnu.org>
1342 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1343 Move PENDING_OUTPUT_COUNT definition to configure.
1345 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1346 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1347 * s/gnu.h (DATA_START): Move definitions to configure.
1349 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1350 We include usg5-4-common.h, which defines them both.
1352 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1353 O_RDONLY already includes it).
1355 Stop ns builds setting the EMACSLOADPATH environment variable.
1356 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1357 Now it does not set EMACSLOADPATH, just returns the load-path string.
1358 * nsterm.h: Update accordingly.
1359 * lread.c [HAVE_NS]: Include nsterm.h.
1360 (init_lread) [HAVE_NS]: Use ns_load_path.
1361 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1363 2012-07-09 Glenn Morris <rgm@gnu.org>
1365 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1366 since the included bsd-common.h does so.
1368 Stop ns builds setting the EMACSPATH environment variable.
1369 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1370 (ns_init_paths): Do not set EMACSPATH.
1371 * nsterm.h (ns_exec_path): Add it.
1372 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1375 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1377 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1379 * process.c (wait_reading_process_output): 'waitchannels' was unset
1380 when read_kbd || !NILP (wait_for_cell); fix this.
1382 Add GCC-style 'const' attribute to functions that can use it.
1383 * character.h (char_resolve_modifier_mask):
1384 * keyboard.h (make_ctrl_char):
1385 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1386 (init_character_once, next_almost_prime, init_fns, init_image)
1387 (flush_pending_output, init_sound):
1388 * mem-limits.h (start_of_data):
1389 * menu.h (finish_menu_items):
1390 Add ATTRIBUTE_CONST.
1391 * emacs.c (DEFINE_DUMMY_FUNCTION):
1392 Declare the dummy function with ATTRIBUTE_CONST.
1393 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1394 Add decls with ATTRIBUTE_CONST.
1396 Minor improvements to make_formatted_string.
1397 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1398 where int is good enough, as vsprintf returns an int.
1399 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1401 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1403 Use make_formatted_string to avoid double length calculation.
1404 * lisp.h (make_formatted_string): New prototype.
1405 * alloc.c (make_formatted_string): New function.
1406 * buffer.c (Fgenerate_new_buffer_name): Use it.
1407 * dbus.c (syms_of_dbusbind): Likewise.
1408 * editfns.c (Fcurrent_time_zone): Likewise.
1409 * filelock.c (get_boot_time): Likewise.
1410 * frame.c (make_terminal_frame, set_term_frame_name)
1411 (x_report_frame_params): Likewise.
1412 * image.c (gs_load): Likewise.
1413 * minibuf.c (get_minibuffer): Likewise.
1414 * msdos.c (dos_set_window_size): Likewise.
1415 * process.c (make_process): Likewise.
1416 * xdisp.c (ensure_echo_area_buffers): Likewise.
1417 * xsettings.c (apply_xft_settings): Likewise.
1419 2012-07-09 Glenn Morris <rgm@gnu.org>
1421 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1422 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1423 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1424 * nsterm.h (ns_etc_directory): Add it.
1425 * callproc.c [HAVE_NS]: Include nsterm.h.
1426 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1428 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1430 Move marker debugging code under MARKER_DEBUG.
1431 * marker.c (MARKER_DEBUG): Move marker debugging code under
1432 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1433 for bootstrap with --enable-checking (~3x slowdown reported
1434 by Juanma Barranquero <lekktu@gmail.com>).
1435 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1437 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1439 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1440 See <http://bugs.gnu.org/11825#29>.
1442 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1444 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1445 has no font, use the frame's font. (Bug#11813)
1446 (display_line): Add commentary about displaying truncation glyphs
1448 (produce_special_glyphs): Move here from term.c.
1450 * term.c (produce_special_glyphs): Move to xdisp.c.
1452 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1455 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1457 * xdisp.c (display_line): Avoid warning about implicit declaration
1460 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1462 * lisp.h: Remove empty conditional.
1464 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1466 * lread.c (load_path_check): Now static.
1468 Fix some minor --with-ns problems found by static checking.
1469 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1470 (x_set_font) [!HAVE_X_WINDOWS]:
1471 * image.c (xpm_load_image) [HAVE_NS]:
1472 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1473 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1474 Remove unused local.
1475 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1476 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1477 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1478 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1479 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1480 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1481 Fix pointer signedness problem.
1482 * xfaces.c (FRAME_X_FONT_TABLE):
1483 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1485 2012-07-07 Glenn Morris <rgm@gnu.org>
1487 * lread.c (load_path_check): New function, split from init_lread.
1488 (init_lread): Reorganize. Motivation:
1489 If EMACSLOADPATH is set, check/warn about that rather than the
1490 defaults, which we are not going to use. Hence we can remove
1491 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1492 Don't warn if site-lisp directories are missing.
1493 If not installed, start from a blank load-path, since
1494 PATH_LOADSEARCH refers to the eventual installation directories.
1496 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1498 Support truncation and continuation glyphs on GUI frames, when
1499 fringes are disabled. (Bug#11832)
1500 * xdisp.c (init_iterator): Get dimensions of truncation and
1501 continuation glyphs even if on GUI frames. Adjust
1502 it->last_visible_x on GUI frames when the left or right fringes,
1503 or both, are absent.
1504 (start_display, move_it_in_display_line_to): Handle the case of a
1505 GUI frame without a fringe to display continuation or truncation
1507 (insert_left_trunc_glyphs): Support GUI frames: make sure
1508 truncation glyphs overwrite enough glyphs from the current line to
1509 have sufficient space in pixels.
1510 (display_line): Support truncation and continuation glyphs on GUI
1511 frames. If some spare pixels are left on the line after inserting
1512 the truncation glyphs, fill that space with a stretch glyph of a
1513 suitably computed width.
1515 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1516 produce_glyphs, to support GUI sessions.
1518 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1520 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1522 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1524 Do not require float-time's arg to fit in time_t (Bug#11825).
1525 This works better on hosts where time_t is unsigned, and where
1526 float-time is applied to the (negative) difference between two times.
1527 * editfns.c (decode_time_components): Last arg is now double *,
1528 not int *, and means to store all the result as a double, without
1529 worrying about whether the seconds part fits in time_t.
1530 All callers changed.
1531 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1532 All callers changed.
1533 (Ffloat_time): Do not fail merely because the specified time falls
1534 outside of time_t range.
1536 2012-07-07 Glenn Morris <rgm@gnu.org>
1538 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1539 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1540 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1542 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1544 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1545 Update dependencies.
1547 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1549 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1551 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1552 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1553 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1554 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1555 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1556 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1558 * xfont.c (compare_font_names): Redo to omit the need for casts.
1560 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1562 * xfns.c (Fx_change_window_property): Doc fix.
1563 * w32fns.c (Fx_change_window_property): Doc fix.
1565 * w32fns.c (Fx_window_property): Accept the same arguments as the
1566 X Windows version. Doc fix.
1567 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1569 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1570 Eli Zaretskii <eliz@gnu.org>
1572 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1573 Windows-specific code from nt/config.nt moved here.
1574 Obsolete settings removed.
1576 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1578 * process.c: Avoid unnecessary calls to gettime.
1579 (wait_reading_process_output): Don't get the time of day
1580 when gobbling data immediately and not waiting, as there's no need
1581 for it in that case. This removes a FIXME.
1583 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1585 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1586 is defined (Bug#11768).
1588 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1590 Fix marker debugging code.
1591 * marker.c (byte_char_debug_check): Do not perform the check
1592 if buffer is not multibyte.
1593 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1594 Call byte_char_debug_check with correct arguments.
1596 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1598 Compile marker debugging code only if ENABLE_CHECKING is defined.
1599 * marker.c (byte_char_debug_check, count_markers):
1600 Use only if ENABLE_CHECKING is defined.
1601 (byte_debug_flag): Remove.
1602 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1603 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1605 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1607 Avoid code repetition in marker-related functions.
1608 * marker.c (attach_marker): New function.
1609 (Fset_marker, set_marker_restricted, set_marker_both)
1610 (set_marker_restricted_both): Use it.
1611 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1612 Consistently rename charno to charpos.
1613 (marker_position): Add eassert.
1614 (marker_byte_position): Convert to eassert.
1616 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1618 Simplify list operations in unchain_overlay and unchain_marker.
1619 * buffer.c (unchain_overlay): Simplify. Add comment.
1620 * marker.c (unchain_marker): Simplify. Fix comments.
1622 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1624 Introduce fast path for the widely used marker operation.
1625 * alloc.c (build_marker): New function.
1626 * lisp.h (build_marker): New prototype.
1627 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1628 * composite.c (autocmp_chars): Likewise.
1629 * editfns.c (buildmark): Remove.
1630 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1631 (save_restriction_save): Use build_marker.
1632 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1633 * window.c (save_window_save): Likewise.
1635 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1637 Do not use Fdelete_overlay in delete_all_overlays
1638 to avoid redundant calls to unchain_overlay.
1639 * buffer.c (drop_overlay): New function.
1640 (delete_all_overlays, Fdelete_overlay): Use it.
1641 * minibuf.c (get_minibuffer): Fix comment.
1643 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1645 Port to OpenBSD 5.1 amd64.
1646 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1647 This is needed for OpenBSD, and should be harmless on all BSD systems.
1648 Also, include <sys/sysctl.h>, as it should be available on all
1649 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1650 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1651 use p_pid member, not kp_proc.pid.
1653 2012-07-06 Glenn Morris <rgm@gnu.org>
1655 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1657 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1659 More xmalloc and related cleanup.
1660 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1661 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1662 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1663 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1664 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1665 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1666 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1667 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1668 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1670 Omit needless casts involving void * pointers and allocation.
1671 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1672 as the former is more robust if P's type is changed.
1673 Prefer xzalloc to xmalloc + memset 0.
1674 Simplify malloc-or-realloc to realloc.
1675 Don't worry about xmalloc returning a null pointer.
1676 Prefer xstrdup to xmalloc + strcpy.
1677 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1679 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1680 alloca of a constant.
1682 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1684 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1685 hscroll is larger than the line width. Fixes long and futile
1686 looping inside extend_face_to_end_of_line (on a TTY) producing
1687 glyphs that are not needed and thrown away.
1689 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1691 * marker.c (set_marker_restricted_both): Simplify by using
1694 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1696 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1698 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1700 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1701 not defined (Bug#11768).
1702 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1703 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1704 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1705 followed by gtk_box_set_homogeneous (Bug#11768).
1706 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1707 (update_theme_scrollbar_width, xg_create_scroll_bar):
1708 Use gtk_scrollbar_new (Bug#11768).
1709 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1710 (is_box_type): New function (Bug#11768).
1711 (xg_tool_item_stale_p): Call is_box_type.
1712 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1713 with default display (Bug#11768).
1715 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (window_hscroll_limited): New function.
1718 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1719 coordinates when window's hscroll is set to insanely large
1722 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1724 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1725 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1727 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1730 * lisp.h (xzalloc): New prototype. Omit needless casts.
1731 * alloc.c (xzalloc): New function. Omit needless casts.
1732 * charset.c: Omit needless casts. Convert all calls to
1733 xmalloc with following memset to xzalloc.
1734 * dispnew.c: Likewise.
1735 * fringe.c: Likewise.
1736 * image.c: Likewise.
1737 * sound.c: Likewise.
1739 * w32fns.c: Likewise.
1740 * w32font.c: Likewise.
1741 * w32term.c: Likewise.
1742 * xfaces.c: Likewise.
1744 * xterm.c: Likewise.
1745 * atimer.c: Omit needless casts.
1746 * buffer.c: Likewise.
1747 * callproc.c: Likewise.
1749 * coding.c: Likewise.
1750 * composite.c: Likewise.
1752 * doprnt.c: Likewise.
1753 * editfns.c: Likewise.
1754 * emacs.c: Likewise.
1756 * filelock.c: Likewise.
1758 * gtkutil.c: Likewise.
1759 * keyboard.c: Likewise.
1761 * lread.c: Likewise.
1762 * minibuf.c: Likewise.
1763 * msdos.c: Likewise.
1764 * print.c: Likewise.
1765 * process.c: Likewise.
1766 * region-cache.c: Likewise.
1767 * search.c: Likewise.
1768 * sysdep.c: Likewise.
1769 * termcap.c: Likewise.
1770 * terminal.c: Likewise.
1771 * tparam.c: Likewise.
1772 * w16select.c: Likewise.
1774 * w32reg.c: Likewise.
1775 * w32select.c: Likewise.
1776 * w32uniscribe.c: Likewise.
1777 * widget.c: Likewise.
1778 * xdisp.c: Likewise.
1779 * xmenu.c: Likewise.
1781 * xselect.c: Likewise.
1783 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1785 * fileio.c (time_error_value): Check the right error number.
1786 Problem reported by Troels Nielsen in
1787 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1789 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1791 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1792 This should be fixed in a better way; see Eli Zaretskii in
1793 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1794 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1796 * fileio.c (time_error_value): Rename from special_mtime.
1797 The old name's problems were noted by Eli Zaretskii in
1798 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1800 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1801 This variable's comment says Emacs needs at least one GDB-visible
1802 symbol of type enum pvec_type, to work around GDB problems.
1803 The symbol's value doesn't matter.
1805 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1806 that causes compilation to fail on pre-C99 compilers.
1808 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1810 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1811 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1813 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1815 * buffer.c (init_buffer_once): Fix initialization of
1816 headers for buffer_defaults and buffer_local_symbols.
1817 Reported by Juanma Barranquero <lekktu@gmail.com>.
1819 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1821 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1822 * lisp.h (enum pvec_type): Use fewer bits.
1823 (PSEUDOVECTOR_SIZE_BITS): New constant.
1824 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1825 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1826 change in pvec_type.
1827 (PSEUDOVECTOR_TYPEP): New macro.
1828 (TYPED_PSEUDOVECTORP): Use it.
1829 * fns.c (internal_equal): Adapt code to extract pvectype.
1830 * emacs.c (gdb_pvec_type): Update type.
1831 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1832 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1833 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1834 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1835 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1836 abusing vector->header.next.nbytes.
1837 (live_vector_p): Use PVEC_TYPE.
1838 (mark_object): Adapt code to extract pvectype. Use switch.
1840 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1842 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1843 Tighten new eassert a bit.
1845 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1847 Fix compilation with --enable-gcc-warnings and -O1
1849 * doprnt.c (doprnt): Change type of tem to int, initialize
1850 to avoid compiler warning. Add eassert.
1851 * search.c (simple_search): Initialize match_byte to avoid
1852 compiler warning. Add eassert.
1854 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1856 Avoid weird behavior with large horizontal scrolls.
1857 Without this change, for example, large hscroll values would
1858 mess up Emacs's display on Fedora 15 x86, presumably due to
1859 overflows in int calculations in the display code.
1860 Also, if buffers had long lines, Emacs would freeze.
1861 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1862 (set_window_hscroll): New function, containing the old guts of
1863 Fset_window_hscroll. Return the clipped value.
1864 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1865 This avoids the need to check against PTRDIFF_MAX.
1867 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1869 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1871 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1873 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1875 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1876 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1877 since GCC 4.4.6 issues a bogus warning for them.
1879 Fix bugs in file timestamp newness comparisons.
1880 * fileio.c (Ffile_newer_than_file_p):
1881 * lread.c (Fload): Use full timestamp resolution of files,
1882 not just the 1-second resolution, so that files that are only
1883 slightly newer still count as newer.
1884 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1885 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1887 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1889 * fileio.c: Improve handling of file time marker. (Bug#11852)
1890 (special_mtime): New function.
1891 (Finsert_file_contents, Fverify_visited_file_modtime):
1892 Use it to set special mtime values consistently.
1894 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1896 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1897 marker for non-existing file. (Bug#11852)
1899 2012-07-03 Glenn Morris <rgm@gnu.org>
1901 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1902 and did not make it into globals.h).
1904 2012-07-03 Tom Tromey <tromey@redhat.com>
1906 * window.c (Fset_window_margins, Fset_window_fringes)
1907 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1908 * textprop.c (Fprevious_property_change): No longer static.
1909 * syntax.c (Fsyntax_table_p): No longer static.
1910 * process.c (Fget_process, Fprocess_datagram_address): No longer
1912 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1913 * keyboard.c (Fcommand_execute): No longer static.
1915 * insdel.c (Fcombine_after_change_execute): No longer static.
1916 * image.c (Finit_image_library): No longer static.
1917 * fileio.c (Fmake_symbolic_link): No longer static.
1918 * eval.c (Ffetch_bytecode): No longer static.
1919 * editfns.c (Fuser_full_name): No longer static.
1920 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1922 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1924 * dired.c (Ffile_attributes): No longer static.
1925 * composite.c (Fcomposition_get_gstring): No longer static.
1926 * callproc.c (Fgetenv_internal): No longer static.
1928 * ccl.h: Remove EXFUNs.
1929 * buffer.h: Remove EXFUNs.
1930 * dispextern.h: Remove EXFUNs.
1931 * intervals.h: Remove EXFUNs.
1932 * fontset.h: Remove EXFUN.
1933 * font.h: Remove EXFUNs.
1934 * dosfns.c (system_process_attributes): Remove EXFUN.
1935 * keymap.h: Remove EXFUNs.
1936 * lisp.h: Remove EXFUNs.
1937 * w32term.h: Remove EXFUNs.
1938 * window.h: Remove EXFUNs.
1939 * xsettings.h: Remove EXFUN.
1940 * xterm.h: Remove EXFUN.
1942 2012-07-03 Glenn Morris <rgm@gnu.org>
1944 * lisp.h (Frandom): Make it visible to C.
1945 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1946 buffer for invisible buffers. (Bug#1229)
1948 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1950 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1951 values which aren't power of 2.
1952 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1953 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1956 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1958 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1960 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1962 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1964 * alloc.c (allocate_vector_block): Remove redundant
1965 calls to mallopt if DOUG_LEA_MALLOC is defined.
1966 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1967 avoid calls to mallopt if zero_vector is returned.
1969 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1971 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1972 is enabled, avoid dereferencing NULL current_sblock if
1975 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1977 Cleanup basic buffer management.
1978 * buffer.h (struct buffer): Change layout to use generic vector
1979 marking code. Fix some comments. Change type of 'clip_changed'
1980 to bitfield. Remove unused #ifndef old.
1981 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1982 (GET_OVERLAYS_AT): Fix indentation.
1983 (for_each_per_buffer_object_at): New macro.
1984 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1985 (Fbuffer_local_variables): Use it.
1986 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1987 * alloc.c (allocate_buffer): Adjust to match new layout of
1988 struct buffer. Fix comment.
1989 (mark_overlay): New function.
1990 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1991 Lisp area of struct buffer.
1992 (mark_object): Use it. Adjust marking of misc objects
1993 and related comments.
1995 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1997 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1998 wrapper that is not needed because the wrapped code is a no-op (zero
1999 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2000 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2002 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2004 * alloc.c (mark_buffer): Simplify. Remove prototype.
2005 (mark_object): Add comment. Reorganize marking of vector-like
2006 objects. Use CHECK_LIVE for all vector-like objects except buffers
2007 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2008 redundant calls to mark_vectorlike for bool vectors.
2010 2012-06-30 Glenn Morris <rgm@gnu.org>
2012 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2014 * epaths.in (PATH_SITELOADSEARCH): New.
2015 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2016 This is rather than relying on --enable-locallisppath elements
2017 having "site-lisp" in their names. (Bug#10208#25, 11658)
2019 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2021 * w32proc.c (sys_select): Accept and ignore one more argument.
2023 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2025 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2026 (pselect) [!MS_DOS]: Redirect to sys_select.
2028 * sysdep.c: Don't include dos.h and dosfns.h.
2030 * process.c (sys_select):
2031 * msdos.c (sys_select): Accept one more argument and ignore it.
2033 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2034 adapt data types and code to that.
2037 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2038 which clashes with the gnulib function of the same name.
2040 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2042 * font.c (font_style_to_value, font_style_symbolic)
2043 (font_prop_validate_style): Add type checks for values in
2046 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2048 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2051 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2053 * xdisp.c (try_window_id): Undo last change.
2055 * w32.c (getwd): Adjust commentary about startup_dir.
2056 (init_environment): Always call sys_access, even in non-MSVC
2057 builds. Don't chdir to the directory of the Emacs executable.
2058 This undoes code from 1997 which was justified by the need to
2059 "avoid conflicts when removing and renaming directories". But its
2060 downside was that every relative file name was being interpreted
2061 relative to the directory of the Emacs executable, which can never
2062 be TRT. In particular, it broke sys_access when called with
2063 relative file names.
2064 (sys_access): Map GetLastError to errno.
2066 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2068 * window.h (struct window): Change type of 'fringes_outside_margins'
2069 to bitfield. Fix comment. Adjust users accordingly.
2070 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2072 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2075 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2077 * gnutls.c (emacs_gnutls_handshake):
2078 Add QUIT to make the loop interruptible.
2080 2012-06-29 Glenn Morris <rgm@gnu.org>
2082 * charset.c (init_charset): Make lack of etc/charsets fatal.
2084 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2086 * editfns.c (region_limit): Fix type mismatch.
2088 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2090 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2091 undefined. Convert from xassert to eassert.
2092 * nsmenu.m: Convert from xassert to eassert.
2093 * nsterm.m: Likewise.
2095 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2097 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2099 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2101 Avoid integer overflow on scroll-left and scroll-right.
2102 * window.c (HSCROLL_MAX): New macro.
2103 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2104 overflow when requested scroll falls outside ptrdiff_t range.
2106 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2108 * window.h (struct window): Change type of 'hscroll',
2109 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2110 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2111 Adjust users accordingly.
2112 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2113 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2114 from EMACS_INT to ptrdiff_t.
2115 (make_window): Omit redundant initialization.
2117 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2119 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2121 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2123 * window.h (struct window): Change type of 'use_time' and
2124 'sequence_number' from Lisp_Object to int.
2125 * frame.c (make_frame): Adjust users accordingly.
2126 * print.c (print_object): Likewise.
2127 * window.c (select_window, Fwindow_use_time, make_parent_window)
2128 (make_window): Likewise.
2130 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2132 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2133 enabled with --enable-checking=[all,glyphs] configure option.
2134 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2135 adjust comments accordingly.
2136 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2137 undefined, adjust comments accordingly.
2138 * image.c: Likewise.
2139 * scroll.c: Likewise.
2140 * w32fns.c: Likewise.
2141 * w32term.c: Likewise.
2142 * xdisp.c: Likewise.
2143 * xfaces.c: Likewise.
2145 * xterm.c: Likewise.
2147 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2149 Generalize run-time debugging checks.
2150 * dispextern.h (XASSERTS): Remove.
2151 * fontset.c (xassert): Remove.
2152 Convert from xassert to eassert.
2153 * alloc.c: Convert from xassert to eassert.
2155 * dispnew.c: Likewise.
2157 * fringe.c: Likewise.
2158 * ftfont.c: Likewise.
2159 * gtkutil.c: Likewise.
2160 * image.c: Likewise.
2161 * keyboard.c: Likewise.
2163 * process.c: Likewise.
2164 * scroll.c: Likewise.
2165 * sound.c: Likewise.
2167 * w32console.c: Likewise.
2168 * w32fns.c: Likewise.
2169 * w32term.c: Likewise.
2170 * window.c: Likewise.
2171 * xdisp.c: Likewise.
2172 * xfaces.c: Likewise.
2174 * xselect.c: Likewise.
2175 * xterm.c: Likewise.
2177 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2179 * fns.c (maybe_resize_hash_table): Output message when growing the
2182 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2184 * alloc.c (allocate_string_data): Remove dead code.
2185 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2186 avoid GCC warning about unused macro.
2188 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2190 * alloc.c (allocate_string): Omit intervals initialization.
2191 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2192 as in make_pure_string and make_pure_c_string.
2194 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2196 * alloc.c (allocate_string): Fix last change.
2198 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2200 * alloc.c (allocate_string): Remove two redundant calls
2201 to memset, add explicit initialization where appropriate.
2203 2012-06-27 Glenn Morris <rgm@gnu.org>
2205 * lisp.mk (lisp): Remove paths.elc.
2207 2012-06-27 Chong Yidong <cyd@gnu.org>
2209 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2211 2012-06-26 John Wiegley <johnw@newartisans.com>
2213 * unexmacosx.c (copy_data_segment): Add two section names used
2214 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2216 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2217 when building with Clang.
2219 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2221 * eval.c (Fapply): Allow calling it with a single argument.
2223 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2225 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2226 _stricmp and _strnicmp.
2227 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2229 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2231 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2233 (allocate_process): Likewise for new process.
2234 (allocate_terminal): Change to use offsetof.
2235 (allocate_frame): Likewise.
2236 * frame.c (make_frame): Omit redundant initialization.
2237 * window.c (make_parent_window): Use memset.
2238 (make_window): Omit redundant initialization.
2239 * process.c (make_process): Omit redundant initialization.
2240 * terminal.c (create_terminal): Likewise.
2242 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2244 * term.c (delete_tty): Remove redundant call to memset.
2246 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2248 * alloc.c: Remove build_string.
2249 * lisp.h: Define build_string as static inline. This provides
2250 a better opportunity to optimize away calls to strlen when the
2251 function is called with compile-time constant argument.
2252 * image.c (imagemagick_error): Convert to build_string.
2253 * w32proc.c (sys_spawnve): Likewise.
2254 * xterm.c (x_term_init): Likewise.
2256 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2258 Use sprintf return value instead of invoking strlen on result.
2259 In the old days this wasn't portable, since some sprintf
2260 implementations returned char *. But they died out years ago and
2261 Emacs already assumes sprintf returns int.
2262 Similarly for float_to_string.
2263 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2264 * ccl.c (ccl_driver):
2265 * character.c (string_escape_byte8):
2266 * data.c (Fnumber_to_string):
2267 * doprnt.c (doprnt):
2268 * print.c (print_object):
2269 * xdisp.c (message_dolog):
2270 * xfns.c (syms_of_xfns):
2271 Use sprintf or float_to_string result to avoid need to call strlen.
2272 * data.c (Fnumber_to_string):
2273 Use make_unibyte_string, since the string must be ASCII.
2274 * lisp.h, print.c (float_to_string): Now returns int length.
2275 * term.c (produce_glyphless_glyph):
2276 Use sprintf result rather than recomputing it.
2278 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2279 * Makefile.in (ALL_CFLAGS):
2280 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2281 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2283 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2285 * dispextern.h (xstrcasecmp): Define to library function
2286 strcasecmp if available.
2287 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2289 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2291 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2292 Avoid comma operator.
2293 * menu.c (push_submenu_start, push_submenu_end)
2294 (push_left_right_boundary, push_menu_pane): Likewise.
2295 * msdos.c (dos_rawgetc): Likewise.
2297 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2299 * xfns.c (xic_create_fontsetname): Remove redundant calls
2302 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2304 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2305 sprintf already null-terminates its output.
2307 * xfns.c (x_window): Remove redundant cast.
2309 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2311 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2312 `const char *' to `char *' to avoid compiler warning.
2314 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2316 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2317 instead of truncating it to 63 (admittedly a generous limit).
2319 * process.c: Fix spelling and caps in comments.
2321 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2323 * emacs.c (setpgrp): Remove definition, unused.
2324 * sysdep.c (setpgrp): Remove definition, not used in this file.
2326 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2328 * makefile.w32-in: Update dependencies.
2330 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2332 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2333 (SYSTIME_H): Add nt/inc/sys/time.h.
2335 * systime.h [WINDOWSNT]: Include sys/time.h.
2337 * s/ms-w32.h (struct timespec): Definition moved from
2338 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2340 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2342 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2343 * buffer.h (buffer_slot_type_mismatch):
2344 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2345 * eval.c (unwind_to_catch):
2346 * image.c (my_png_error, my_error_exit):
2347 * keyboard.c (quit_throw_to_read_char, user_error)
2348 (Fexit_recursive_edit, Fabort_recursive_edit):
2349 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2350 (wrong_type_argument, buffer_overflow, __executable_start)
2351 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2352 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2353 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2355 (child_setup) [!DOS_NT]:
2356 * lread.c (end_of_file_error, invalid_syntax):
2357 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2358 * puresize.h (pure_write_error):
2359 * search.c (matcher_overflow):
2360 * sound.c (sound_perror, alsa_sound_perror):
2361 * sysdep.c, syssignal.h (croak):
2362 * term.c (maybe_fatal, vfatal):
2363 * textprop.c (text_read_only):
2364 * undo.c (user_error):
2365 * unexmacosx.c (unexec_error):
2366 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2367 Use _Noreturn rather than NO_RETURN.
2368 No need for separate decl merely because of _Noreturn.
2369 * sound.c (sound_warning, parse_sound):
2370 Remove unnecessary forward decls.
2372 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2374 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2375 * lisp.h (WAIT_READING_MAX): New macro.
2376 * dispnew.c (Fsleep_for, sit_for):
2377 * keyboard.c (kbd_buffer_get_event):
2378 * process.c (Faccept_process_output):
2379 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2380 This improves on the previous patch, which introduced a bug
2381 when time_t is unsigned and as wide as intmax_t.
2382 See <http://bugs.gnu.org/9000#51>.
2384 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2386 * dispnew.c (sit_for, Fsleep_for):
2387 * keyboard.c (kbd_buffer_get_event):
2388 * process.c (Faccept_process_output): Avoid compiler warnings when
2389 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2391 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2393 * makefile.w32-in: Update dependencies.
2395 * w32.c (ltime): Add return type and declare static.
2396 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2398 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2400 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2401 Privately reported by Herbert J. Skuhra.
2402 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2404 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2405 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2407 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2409 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2410 last argument of make_unibyte_string.
2412 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2413 language ID in the event parameters.
2415 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2416 event.code, not the obscure "character set ID".
2418 2012-06-23 Chong Yidong <cyd@gnu.org>
2420 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2422 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2424 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2425 * w32.c (fdutimens): New function.
2427 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2429 * s/ms-w32.h (pselect): Redirect to sys_select.
2431 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2433 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2434 in the logic of incrementing and decrementing the value of
2435 use_relocatable_buffers.
2437 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2439 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2440 Privately reported by Herbert J. Skuhra.
2441 [__FreeBSD__]: Remove "*/" typo after "#include".
2442 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2443 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2444 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2445 Don't assume EMACS_TIME and struct timeval are the same type.
2447 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2449 Support higher-resolution time stamps (Bug#9000).
2450 The time stamps are only nanosecond-resolution at the C level,
2451 since that's the best that any real-world system supports now.
2452 But they are picosecond-resolution at the Lisp level, as that's
2453 easy, and leaves room for future OS improvements.
2455 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2458 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2459 Don't get current time unless it's needed.
2461 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2462 now provides it if it's absent.
2463 (start_atimer): Port to higher-res time stamps.
2464 Check for time stamp overflow. Don't get current time more
2465 often than is needed.
2467 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2468 Include systime.h, not time.h.
2469 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2471 * dired.c: Include stat-time.h.
2472 (Ffile-attributes): File times now have higher resolution.
2474 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2475 (struct image): Timestamp now has higher resolution.
2477 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2478 has at least microseconds now. All uses removed.
2479 (update_frame, update_single_window, update_window, update_frame_1)
2480 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2482 * editfns.c (time_overflow): Now extern.
2483 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2484 (float-time, Fformat_time_string, Fcurrent_time_string)
2485 (Fcurrent_time_zone): Accept and generate higher-resolution
2487 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2488 (decode_time_components, lisp_seconds_argument): New functions.
2489 (make_time): Now static.
2490 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2491 Report an error if the time is invalid, rather than having the caller
2494 * fileio.c: Include <stat-time.h>
2495 (Fcopy_file): Copy higher-resolution time stamps.
2496 Prefer to set the time stamp via a file descriptor if that works.
2497 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2498 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2499 (Fvisited_file_modtime, Fset_visited_file_modtime):
2500 Support higher-resolution time stamps.
2502 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2504 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2506 * image.c (prepare_image_for_display, clear_image_cache)
2507 (lookup_image): Port to higer-resolution time stamps.
2509 * keyboard.c (start_polling, bind_polling_period):
2510 Check for time stamp overflow.
2511 (read_char, kbd_buffer_get_event, timer_start_idle)
2512 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2513 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2514 Port to higher-resolution time stamps. Do not assume time_t is signed.
2515 (decode_timer): New function. Timers are now vectors of length 9,
2516 not 8, to accommodate the picosecond component.
2517 (timer_check_2): Use it.
2519 * nsterm.m (select_timeout, timeval_subtract): Remove.
2520 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2521 as they're a bit more accurate and handle overflow better.
2522 (ns_select): Change prototype to be compatible with pselect.
2523 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2524 * nsterm.h (ns_select): Adjust prototype.
2526 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2527 us-resolution time stamps.
2528 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2530 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2532 * lisp.h (time_overflow): New decl.
2533 (wait_reading_process_output): First arg is now intmax_t, not int,
2534 to accommodate larger waits.
2536 * process.h (struct Lisp_Process.read_output_delay):
2537 Now counts nanoseconds, not microseconds.
2538 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2540 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2541 (wait_reading_process_output):
2542 Port to ns-resolution time stamps.
2543 (Faccept_process_output, wait_reading_process_output):
2544 Check for time stamp overflow. Do not assume time_t is signed.
2545 (select_wrapper): Remove; we now use pselect.
2546 (Fprocess_attributes): Now generates ns-resolution time stamps.
2548 * sysdep.c: Include utimens.h. Don't include utime.h
2549 or worry about struct utimbuf; gnulib does that for us now.
2550 (gettimeofday): Remove; gnulib provides a substitute.
2551 (make_timeval): New function.
2552 (set_file_times): Now sets ns-resolution time stamps.
2553 New arg FD; all uses changed.
2554 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2555 (system_process_attributes):
2556 Now returns ns-resolution time stamp. All uses changed.
2557 Check for time stamp overflow.
2559 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2560 provides a substitute now.
2562 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2563 since it guarantees struct timespec.
2564 (EMACS_TIME): Now struct timespec, so that we can support
2565 ns-resolution time stamps.
2566 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2567 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2568 (EMACS_USECS): Remove.
2569 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2570 so multiply the arg by 1000 before storing it.
2571 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2573 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2574 Port to ns-resolution time stamps.
2575 (EMACS_TIME_NEG_P): Remove; replaced by....
2576 (EMACS_TIME_SIGN): New macro.
2577 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2578 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2579 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2580 (make_timeval, make_lisp_time, decode_time_components): New decls.
2581 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2582 that it mishandled time_t overflow. You can't compare by subtracting!
2583 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2584 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2586 * term.c: Include <sys/time.h>.
2587 (timeval_to_Time): New function, for proper overflow wraparound.
2588 (term_mouse_position, term_mouse_click): Use it.
2590 * undo.c (record_first_change): Support higher-resolution time stamps
2592 (Fprimitive_undo): Use them when restoring time stamps.
2594 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2595 (w32_get_internal_run_time):
2596 Port to higher-resolution Emacs time stamps.
2597 (ltime): Now accepts single 64-bit integer, as that's more convenient
2600 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2602 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2603 for compatibility with pselect. Support ns-resolution time stamps.
2605 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2607 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2608 Check for time stamp overflow, and support ns-resolution time stamps.
2610 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2611 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2612 (timeval_subtract): Remove; no longer needed.
2613 (XTflash, XTring_bell, x_wait_for_event):
2614 Port to ns-resolution time stamps. Don't assume time_t is signed.
2616 2012-06-22 Chong Yidong <cyd@gnu.org>
2618 * xdisp.c (x_consider_frame_title): Revert last change.
2620 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2622 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2623 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2624 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2625 staticidx goes up to 1597 out of 1600 = 0x640.)
2627 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2629 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2630 Otherwise, the umask might be mistakenly 0 while handling input signals.
2632 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2634 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2636 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2638 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2639 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2640 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2641 access to `contents' member of Lisp_Vector objects with AREF and ASET
2644 2012-06-19 Chong Yidong <cyd@gnu.org>
2646 * frame.c (delete_frame): When selecting a frame on a different
2647 text terminal, do not alter the terminal's top-frame.
2649 * xdisp.c (format_mode_line_unwind_data): Record the target
2650 frame's selected window and its terminal's top-frame.
2651 (unwind_format_mode_line): Restore them.
2652 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2654 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2655 since tty frames can be explicitly named.
2656 (prepare_menu_bars): Likewise.
2658 * term.c (Ftty_top_frame): New function.
2660 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2662 Port byte-code-meter to modern targets.
2663 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2664 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2665 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2666 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2667 (METER_1, METER_2): Simplify.
2669 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2671 * data.c (Fdefalias): Return `symbol' (bug#11686).
2673 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2675 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2676 gets killed during executing of this function (Bug#11665).
2677 Try to always return Qt when the buffer has been actually killed.
2678 (Vkill_buffer_query_functions): In doc-string say that functions
2679 run by this hook should not change the current buffer.
2681 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2683 Fix recently-introduced process.c problems found by static checking.
2684 * process.c (write_queue_push, write_queue_pop, send_process):
2685 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2686 (write_queue_pop): Fix pointer signedness problem.
2687 (send_process): Remove unused local.
2689 2012-06-17 Chong Yidong <cyd@gnu.org>
2691 * xdisp.c (redisplay_internal): No need to redisplay terminal
2692 frames that are not on top.
2694 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2696 * process.c (make_process): Initialize write_queue.
2697 (write_queue_push, write_queue_pop): New functions.
2698 (send_process): Use them to maintain correct ordering of process
2701 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2703 * lisp.h (eassert): Assume C89 or later.
2704 This removes the need for CHECK.
2705 (CHECK): Remove. Its comments about always evaluating its
2706 argument were confusing, as 'eassert' typically does not evaluate
2709 * coding.c (produce_chars): Use ptrdiff_t, not int.
2711 * xterm.c (x_draw_underwave): Check for integer overflow.
2712 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2714 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2716 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2717 referenced (Bug#11583).
2719 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2721 Implement wave-style variant of underlining.
2722 * dispextern.h (face_underline_type): New enum.
2723 (face): Add field for underline type.
2724 * nsterm.m (ns_draw_underwave): New function.
2725 (ns_draw_text_decoration): Use it.
2726 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2728 (x_draw_glyph_string): Use them.
2729 * xfaces.c (Qline, Qwave): New Lisp objects.
2730 (check_lface_attrs, merge_face_ref)
2731 (Finternal_set_lisp_face_attribute, realize_x_face):
2732 Handle wave-style underline face attributes.
2733 * xterm.c (x_draw_underwave): New function.
2734 (x_draw_glyph_string): Use it.
2736 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2738 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2739 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2740 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2741 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2742 ($(BLD)/w32select.$(O)): Update dependencies.
2744 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2746 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2747 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2748 * character.c (_fetch_multibyte_char_p): Remove.
2749 * alloc.c: Include "character.h" before "buffer.h".
2751 * buffer.c: Likewise.
2752 * bytecode.c: Likewise.
2753 * callint.c: Likewise.
2754 * callproc.c: Likewise.
2755 * casefiddle.c: Likewise.
2756 * casetab.c: Likewise.
2757 * category.c: Likewise.
2759 * coding.c: Likewise.
2760 * composite.c: Likewise.
2761 * dired.c: Likewise.
2762 * dispnew.c: Likewise.
2764 * dosfns.c: Likewise.
2765 * editfns.c: Likewise.
2766 * emacs.c: Likewise.
2767 * fileio.c: Likewise.
2768 * filelock.c: Likewise.
2770 * fontset.c: Likewise.
2771 * fringe.c: Likewise.
2772 * indent.c: Likewise.
2773 * insdel.c: Likewise.
2774 * intervals.c: Likewise.
2775 * keyboard.c: Likewise.
2776 * keymap.c: Likewise.
2777 * lread.c: Likewise.
2778 * macros.c: Likewise.
2779 * marker.c: Likewise.
2780 * minibuf.c: Likewise.
2781 * nsfns.m: Likewise.
2782 * nsmenu.m: Likewise.
2783 * print.c: Likewise.
2784 * process.c: Likewise.
2785 * regex.c: Likewise.
2786 * region-cache.c: Likewise.
2787 * search.c: Likewise.
2788 * syntax.c: Likewise.
2790 * textprop.c: Likewise.
2792 * unexsol.c: Likewise.
2793 * w16select.c: Likewise.
2794 * w32fns.c: Likewise.
2795 * w32menu.c: Likewise.
2796 * window.c: Likewise.
2797 * xdisp.c: Likewise.
2799 * xmenu.c: Likewise.
2801 * xselect.c: Likewise.
2803 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2805 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2806 If all the glyphs of the glyph row came from strings, and we have no
2807 cursor positioning clues, put the cursor on the first glyph of the
2809 (handle_face_prop): Use chunk-relative overlay string index when
2810 indexing into it->string_overlays array. (Bug#11653)
2811 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2812 the rightmost. (Bug#11720)
2814 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2816 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2817 (CATEGORY_MEMBER): Enforce 1/0 value.
2818 * category.c (_temp_category_set): Remove.
2820 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2822 * window.c (Fdelete_other_windows_internal)
2823 (Fdelete_window_internal): Don't access frame's mouse highlight
2824 info of the initial frame. (Bug#11677)
2826 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2828 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2829 Assume USE_2_TAGS_FOR_INTS.
2830 (xreload): Adjust $tagmask width to match recent lisp.h change.
2832 Simplify lisp.h in minor ways that should not affect code.
2833 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2834 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2835 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2836 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2837 (INTTYPEBITS): New macro, for clarity.
2838 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2839 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2840 Simplify now that USE_LSB_TAG is always defined.
2841 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2842 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2844 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2846 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2848 2012-06-13 Glenn Morris <rgm@gnu.org>
2850 * s/bsd-common.h (BSD4_3):
2851 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2853 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2855 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2858 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2860 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2861 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2862 * alloc.c (widen_to_Lisp_Object): Remove.
2863 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2864 * frame.c (delete_frame): Remove outdated comment.
2865 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2866 USE_LISP_UNION_TYPE.
2867 (Fw32_unregister_hot_key): Likewise.
2868 (Fw32_toggle_lock_key): Likewise.
2869 * w32menu.c (add_menu_item): Likewise.
2870 (w32_menu_display_help): Use XIL instead of checking
2871 USE_LISP_UNION_TYPE.
2872 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2873 (init_heap): Likewise.
2874 * w32term.c (w32_read_socket): Update comment.
2876 2012-06-13 Glenn Morris <rgm@gnu.org>
2878 * s/usg5-4-common.h, src/s/unixware.h:
2879 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2881 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2883 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2885 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2886 * alloc.c (make_number) [!defined make_number]:
2887 Remove, as lisp.h always defines this now.
2888 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2889 (roundup_size): Verify that it is a power of 2.
2890 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2891 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2892 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2893 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2894 USE_LSB_TAG now is always defined to be either 0 or 1.
2896 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2897 code works fine either way, and efficiency is not a concern here,
2898 as the union type is for debugging, not for production.
2899 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2900 Use an inline function on all platforms when using the union type,
2901 since this is simpler and 'static inline' can be used portably
2903 (LISP_INITIALLY_ZERO): New macro.
2904 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2905 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2907 2012-06-12 Glenn Morris <rgm@gnu.org>
2909 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2911 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2913 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2914 Move BROKEN_SIGIO to configure.
2916 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2917 Move NO_TERMIO to configure.
2919 2012-06-12 Chong Yidong <cyd@gnu.org>
2921 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2922 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2923 MagickExportImagePixels is undefined.
2925 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2927 * image.c (imagemagick_load_image): Remove unused label.
2929 2012-06-11 Glenn Morris <rgm@gnu.org>
2931 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2932 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2933 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2934 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2936 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * alloc.c (make_byte_code): New function.
2939 (Fmake_byte_code): Use it. Don't purify here.
2940 * lread.c (read1): Use it as well to avoid extra allocation.
2942 2012-06-11 Chong Yidong <cyd@gnu.org>
2944 * image.c (imagemagick_load_image): Implement transparency.
2946 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2948 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2949 account for preceding backslashes. (Bug#11663)
2951 2012-06-09 Chong Yidong <cyd@gnu.org>
2953 * term.c: Support italics in capable terminals (Bug#9652).
2954 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2955 (turn_on_face): Output using TS_enter_italic_mode if available.
2956 Don't handle unused blinking and alt-charset cases.
2957 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2958 and tty_alt_charset_p cases.
2959 (tty_capable_p, init_tty): Support italics.
2961 * termchar.h (struct tty_display_info): Add field for italics.
2962 Remove unused blink field.
2964 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2967 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2968 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2969 tty_alt_charset_p. Add tty_italic_p.
2971 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2973 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2974 dbus_type_is_basic if available.
2975 (xd_extract_signed, xd_extract_unsigned): Rename from
2976 extract_signed and extract_unsigned, respectively. Adapt callers.
2978 2012-06-09 Chong Yidong <cyd@gnu.org>
2980 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2982 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2985 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2987 * xdisp.c (vmessage): Treat frame message as multibyte.
2988 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2989 would generate the diagnostic "Making \302\247 buffer-local while
2992 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2994 * dispnew.c (showing_window_margins_p): Undo last change, which
2995 was done due to an inadvertent commit.
2996 (adjust_frame_glyphs_for_frame_redisplay): Do call
2997 showing_window_margins_p.
2999 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3001 * eval.c (Fmake_var_non_special): New primitive.
3002 (syms_of_eval): Defsubr it.
3003 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3005 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3007 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3008 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3010 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3012 * alloc.c (allocate_vectorlike): Fix last change.
3014 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3016 Block-based vector allocation of small vectors.
3017 * lisp.h (struct vectorlike_header): New field `nbytes',
3018 adjust comment accordingly.
3019 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3020 to denote vector blocks. Adjust users (live_vector_p,
3021 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3022 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3023 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3024 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3025 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3026 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3027 (roundup_size): New constant.
3028 (struct vector_block): New data type.
3029 (vector_blocks, vector_free_lists, zero_vector): New variables.
3030 (all_vectors): Rename to `large_vectors'.
3031 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3032 (sweep_vectors): New functions.
3033 (allocate_vectorlike): Return `zero_vector' as the only vector of
3034 0 items. Allocate new vector from block if vector size is less than
3035 or equal to VBLOCK_BYTES_MAX.
3036 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3037 (init_alloc_once): Add call to init_vectors.
3039 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3041 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3043 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3045 * doprnt.c (doprnt): Truncate multibyte char correctly.
3046 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3047 would mishandle a string argument "Xc" if X was a multibyte
3048 character of length 2: it would truncate after X's first byte
3049 rather than including all of X.
3051 2012-06-06 Chong Yidong <cyd@gnu.org>
3053 * buffer.c (word_wrap): Doc fix.
3055 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3057 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3059 2012-06-03 Glenn Morris <rgm@gnu.org>
3061 * xdisp.c (tool-bar-style): Doc fix.
3063 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3065 * Makefile.in (PAXCTL): Define.
3066 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3067 binary via PaX flags if the paxctl utility is available.
3068 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3069 Restore PaX flags to their default. (Bug#11398)
3071 2012-06-03 Chong Yidong <cyd@gnu.org>
3073 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3076 2012-06-03 Chong Yidong <cyd@gnu.org>
3078 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3079 (note_mode_line_or_margin_highlight): If there is no help echo,
3080 use mode-line-default-help-echo. Handle the case where the mouse
3081 position is past the end of the mode line string.
3083 * buffer.c (buffer_local_value_1): New function, split from
3084 Fbuffer_local_value; can return Qunbound.
3085 (Fbuffer_local_value): Use it.
3086 (Vmode_line_format): Docstring tweaks.
3088 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3090 * sysdep.c (system_process_attributes): Improve comment.
3092 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3094 * keyboard.c: Export real-this-command to Elisp.
3095 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3096 and DEFVAR it. Update all users.
3098 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3100 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3102 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3103 Convert pctcpu and pctmem to Lisp float properly.
3104 Let the compiler fold better, as 100.0/0x8000 is exact.
3106 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3108 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3111 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3113 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3115 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3117 For a 'struct window', replace some Lisp_Object fields to
3118 bitfields where appropriate, remove unused fields.
3119 * window.h (struct window): Remove unused 'last_mark_x' and
3120 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3121 change it's type from Lisp_Object to bitfield.
3122 Change type of 'force_start', 'optional_new_start',
3123 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3124 fields from Lisp_Object to bitfield. Adjust users accordingly.
3126 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3128 Pacify gcc -Wdouble-precision when using Xaw.
3129 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3130 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3131 Use 'float' consistently, rather than 'float' in most places
3132 and 'double' in a couple of places.
3134 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3136 * xdisp.c (handle_stop): Detect whether we have overlay strings
3137 loaded by testing it->current.overlay_string_index to be
3138 non-negative, instead of checking whether n_overlay_strings is
3139 positive. (Bug#11587)
3141 2012-05-31 Chong Yidong <cyd@gnu.org>
3143 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3145 * doc.c (Fsubstitute_command_keys): Doc fix.
3147 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3149 * search.c (search_buffer): Remove calls to
3150 r_alloc_inhibit_buffer_relocation, as it is now called by
3151 maybe_unify_char, which was the cause of relocation of buffer text
3154 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3156 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3157 for the duration of call to load_charset, to avoid problems with
3158 callers of maybe_unify_char that access buffer text through C
3161 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3162 decrement the inhibition flag, instead of just setting or
3165 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3167 Remove obsolete '#define static' cruft.
3168 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3169 This #undef was "temporary" in 2000; it is no longer needed
3170 now that '#define static' has gone away.
3171 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3172 (gray_bitmap_bits): Remove; no longer needed.
3173 All uses replaced with definiens.
3174 * xterm.c: Include "bitmaps/gray.xbm".
3176 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3178 Clean up __executable_start, monstartup when --enable-profiling.
3179 The following changes affect the code only when profiling.
3180 * dispnew.c (__executable_start): Rename from safe_bcopy.
3181 Define only on platforms that need it.
3182 * emacs.c: Include <sys/gmon.h> when profiling.
3183 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3184 (__executable_start): Remove decl, since lisp.h does it now.
3185 (safe_bcopy): Remove decl; no longer has that name.
3186 (main): Coalesce #if into single bit of code, for simplicity.
3187 Cast pointers to uintptr_t, since standard libraries want integers
3189 * lisp.h (__executable_start): New decl.
3191 2012-05-31 Glenn Morris <rgm@gnu.org>
3193 * image.c (Fimagemagick_types): Doc fix.
3195 2012-05-30 Jim Meyering <meyering@redhat.com>
3197 * callproc.c (Fcall_process_region): Include directory component
3198 in mkstemp error message (Bug#11586).
3200 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3202 * alloc.c, lisp.h (make_pure_vector): Now static.
3204 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3206 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3207 Move to byte-run.el.
3208 (Fautoload): Do the hash-doc more carefully.
3209 * data.c (Fdefalias): Purify definition, except for keymaps.
3210 (Qdefun): Move from eval.c.
3211 * lisp.h (Qdefun): Remove.
3212 * lread.c (read1): Tiny simplification.
3214 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3216 Do not create empty overlays with the evaporate property (Bug#9642).
3217 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3218 Bug#9642, but explicitly check that the buffer the overlay would
3219 be moved to is live and rearrange lines to make sure that errors
3220 will not put the overlay in an inconsistent state.
3221 (Fdelete_overlay): Cosmetics.
3223 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3225 * w32term.c (my_bring_window_to_top): New function.
3226 (x_raise_frame): Use handle returned by DeferWindowPos, which
3227 could be different from the original one.
3228 Call my_bring_window_to_top instead of my_set_foreground_window.
3231 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3232 by calling BringWindowToTop.
3234 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3235 (WM_EMACS_END): Increase by one.
3237 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3239 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3240 This avoids undefined behavior that might cause the eassert
3241 to not catch an out-of-range value.
3243 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3245 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3246 Update dependencies.
3248 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3250 * bidi.c (bidi_mirror_char): Fix last change.
3252 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3254 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3255 when referring to sectname field in printf format.
3257 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3259 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3260 Only r_alloc_inhibit_buffer_relocation needed to be added;
3261 the others were already declared.
3263 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3264 before checking whether it's out of range. Put the check inside
3266 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3268 2012-05-27 Ken Brown <kbrown@cornell.edu>
3270 * callproc.c (Fcall_process): Restore a line that was accidentally
3271 commented out in the 2011-02-13 change (bug#11547).
3273 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3275 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3276 defined on ralloc.c.
3278 * buffer.c [REL_ALLOC]: Remove prototypes of
3279 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3280 they are now on lisp.h.
3282 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3284 * search.c (search_buffer): Use it to inhibit relocation of buffer
3285 text while re_search_2 is doing its job, because re_search_2 is
3286 passed C pointers to buffer text. (Bug#11519)
3288 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3291 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3292 state after an additional call to move_it_in_display_line_to, keep
3293 the values of it->max_ascent and it->max_descent found for the
3295 (pos_visible_p): Revert the comparison against bottom_y to what it
3296 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3299 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3301 Fix coding-related core dumps with gcc -ftrapv.
3302 The code was computing A - B, where A and B are pointers, and B is
3303 random garbage. This can lead to core dumps on platforms that
3304 have special pointer registers, and it also leads to core dumps on
3305 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3306 A - B only when B is initialized properly.
3307 * coding.c (coding_set_source, coding_set_destination): Return void.
3308 (coding_change_source, coding_change_destinations): New functions,
3309 with the old behaviors of coding_set_source and coding_set_destination.
3310 All callers that need an offset changed to use these new functions.
3312 2012-05-26 Glenn Morris <rgm@gnu.org>
3314 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3316 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3318 Extend mouse support on W32 text-mode console.
3319 * xdisp.c (draw_row_with_mouse_face):
3320 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3322 * w32console.c: Include window.h.
3323 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3325 (initialize_w32_display): Initialize mouse-highlight data.
3327 * w32inevt.c: Include termchar.h and window.h.
3328 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3329 moves, call note_mouse_highlight. If help_echo changed, call
3330 gen_help_event to produce help-echo message in the echo area.
3331 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3334 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3336 * lread.c (read1): Simplify slightly to avoid an overflow warning
3337 with GCC 4.7.0 on x86-64.
3339 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3341 * bidi.c (bidi_mirror_char): Revert last change: an int is
3342 definitely wide enough here.
3344 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3346 Fix integer width and related bugs (Bug#9874).
3347 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3348 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3349 (string_bytes, check_sblock, allocate_string_data):
3350 (compact_small_strings, Fmake_bool_vector, make_string)
3351 (make_unibyte_string, make_multibyte_string)
3352 (make_string_from_bytes, make_specified_string)
3353 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3354 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3357 (allocate_pseudovector):
3358 Use int, not EMACS_INT, where int is wide enough.
3359 (inhibit_garbage_collection, Fgarbage_collect):
3360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3361 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3362 int might not be wide enough.
3363 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3364 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3365 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3366 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3367 (bidi_level_of_next_char, bidi_move_to_visually_next):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3370 (Fkill_buffer, Fset_buffer_major_mode)
3371 (advance_to_char_boundary, Fbuffer_swap_text)
3372 (Fset_buffer_multibyte, overlays_at, overlays_in)
3373 (overlay_touches_p, struct sortvec, record_overlay_string)
3374 (overlay_strings, recenter_overlay_lists)
3375 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3376 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3377 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3378 (Foverlay_recenter, last_overlay_modification_hooks_used)
3379 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3381 (validate_region): Omit unnecessary test for b <= e,
3382 since that's guaranteed by the previous test.
3383 (adjust_overlays_for_delete): Avoid pos + length overflow.
3384 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3385 (report_overlay_modification):
3386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3387 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3388 Omit pointer cast, which isn't needed anyway, and doesn't work
3389 after the EMACS_INT -> ptrdiff_t change.
3390 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3391 * buffer.h: Adjust decls to match defn changes elsewhere.
3392 (struct buffer_text, struct buffer):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 Use EMACS_INT, not int, where int might not be wide enough.
3395 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3396 not int, to avoid needless 32-bit limit on 64-bit hosts.
3397 (exec_byte_code): Use tighter memory-full test, one that checks
3398 for alloca overflow. Don't compute the address of the object just
3399 before an array, as that's not portable. Use EMACS_INT, not
3400 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3401 * callint.c (Fcall_interactively):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 * callproc.c (call_process_kill, Fcall_process):
3404 Don't assume pid_t fits into an Emacs fixnum.
3405 (call_process_cleanup, Fcall_process, child_setup):
3406 Don't assume pid_t fits into int.
3407 (call_process_cleanup, Fcall_process, delete_temp_file)
3408 (Fcall_process_region):
3409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3410 (Fcall_process): Simplify handling of volatile integers.
3411 Use int, not EMACS_INT, where int will do.
3412 * casefiddle.c (casify_object, casify_region, operate_on_word)
3413 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (casify_object): Avoid integer overflow when overallocating buffer.
3416 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3417 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3418 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3419 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3420 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3421 integers are now checked earlier. All uses replaced with XINT.
3423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3424 For CCL_MapSingle, check that content and value are in int range.
3425 (ccl_driver, Fregister_code_conversion_map):
3426 Check that Vcode_version_map_vector is a vector.
3427 (resolve_symbol_ccl_program): Check that vector header is in range.
3428 Always copy the vector, so that we can check its contents reliably
3429 now rather than having to recheck each instruction as it's being
3430 executed. Check that vector words fit in 'int'.
3431 (ccl_get_compiled_code, Fregister_ccl_program)
3432 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3433 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3434 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3435 contents are in range.
3436 (Fccl_execute_on_string): Check that status is in range.
3437 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3438 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3439 Accept and return EMACS_INT, not int, because callers can pass values
3441 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3442 (multibyte_chars_in_text, parse_str_as_multibyte)
3443 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3444 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3445 (string_escape_byte8, Fget_byte):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3448 avoid mishandling large integers.
3449 * character.h: Adjust decls to match defn changes elsewhere.
3450 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3451 (Ffind_charset_region):
3452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3453 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3454 (load_charset_map_from_vector, Fdefine_charset_internal):
3455 Don't assume fixnum fits in int.
3456 (load_charset_map_from_vector, Fmap_charset_chars):
3457 Remove now-unnecessary CHECK_NATNUMs.
3458 (Fdefine_charset_internal): Check ranges here, more carefully.
3459 Don't rely on undefined behavior with signed left shift overflow.
3460 Don't assume unsigned int fits into fixnum, or that fixnum fits
3461 into unsigned int. Don't require max_code to be a valid fixnum;
3462 that's not true for gb10830 4-byte on a 32-bit host. Allow
3463 invalid_code to be a cons, for the same reason. Require code_offset
3464 to be a character. Avoid int overflow if max_char is close
3466 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3467 this is intended anyway and avoids some undefined behavior.
3468 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3469 INDEX_TO_CODE_POINT, as that's what it expects.
3470 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3471 * charset.h (DECODE_CHAR): Return int, not unsigned;
3472 this is what was intended anyway, and it avoids undefined behavior.
3473 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3474 integer-overflow issues.
3475 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3476 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3477 where the argument is EMACS_INT, and this behavior is not intended.
3478 * chartab.c (Fmake_char_table, Fset_char_table_range)
3479 (uniprop_get_decoder, uniprop_get_encoder):
3480 Don't assume fixnum fits in int.
3481 * cmds.c (move_point): New function, that does the gist of
3482 Fforward_char and Fbackward_char, but does so while checking
3483 for integer overflow more accurately.
3484 (Fforward_char, Fbackward_char): Use it.
3485 (Fforward_line, Fend_of_line, internal_self_insert)
3486 (internal_self_insert):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3488 Fix a FIXME, by checking for integer overflow when calculating
3489 target_clm and actual_clm.
3490 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3491 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3492 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3493 (coding_alloc_by_making_gap, alloc_destination)
3494 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3495 (encode_coding_utf_16, detect_coding_emacs_mule)
3496 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3497 (detect_coding_iso_2022, decode_coding_iso_2022)
3498 (encode_invocation_designation, encode_designation_at_bol)
3499 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3500 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3501 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3502 (encode_coding_ccl, encode_coding_raw_text)
3503 (detect_coding_charset, decode_coding_charset)
3504 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3505 (produce_composition, produce_charset, produce_annotation)
3506 (decode_coding, handle_composition_annotation)
3507 (handle_charset_annotation, consume_chars, decode_coding_gap)
3508 (decode_coding_object, encode_coding_object, detect_coding_system)
3509 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3510 (code_convert_region, code_convert_string)
3511 (Fdefine_coding_system_internal)
3512 (coding_set_source, coding_set_destination):
3513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3514 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3515 (Fdefine_coding_system_internal):
3516 Don't assume fixnums fit in int.
3517 (decode_coding_gap, decode_coding_object, encode_coding_object)
3518 (Fread_coding_system, Fdetect_coding_region)
3519 (Funencodable_char_position, Fcheck_coding_systems_region)
3520 (get_translation, handle_composition_annotation, consume_chars):
3521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3522 (consume_chars): Rewrite to not calculate an address outside buffer.
3523 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3524 Don't access memory outside of the args array.
3525 (Fdefine_coding_system_internal): Check for charset-id overflow.
3526 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3527 result of ENCODE_CHAR.
3528 * coding.h: Adjust decls to match defn changes elsewhere.
3529 (struct coding_system):
3530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3531 * composite.c (get_composition_id, find_composition)
3532 (run_composition_function, update_compositions)
3533 (compose_text, composition_gstring_put_cache)
3534 (composition_gstring_p, composition_gstring_width)
3535 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3536 (composition_compute_stop_pos, composition_reseat_it)
3537 (composition_update_it, struct position_record)
3538 (find_automatic_composition, composition_adjust_point)
3539 (Fcomposition_get_gstring, Ffind_composition_internal):
3540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3541 (update_compositions):
3542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3543 * composite.h: Adjust decls to match defn changes elsewhere.
3544 (struct composition):
3545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3546 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3547 Do not attempt to compute the address of the object just before a
3548 buffer; this is not portable.
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 (Faset): Use int, not EMACS_INT, where int is wide enough.
3552 (Fstring_to_number): Don't assume fixnums fit in int.
3553 (Frem): Don't assume arg is nonnegative.
3554 * dbusbind.c (xd_append_arg): Check for integers out of range.
3555 (Fdbus_call_method): Don't overflow the timeout int.
3556 (extract_signed, extract_unsigned): New functions.
3557 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3558 (xd_get_connection_references): Return ptrdiff_t, not int.
3560 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3561 (xd_read_message_1):
3562 Use int, not unsigned, where the dbus API uses int.
3563 (Fdbus_message_internal): Don't overflow mtype.
3564 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3565 * dired.c (directory_files_internal, file_name_completion, scmp)
3566 (file_name_completion_stat):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 (file_name_completion): Don't overflow matchcount.
3569 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3570 * dispextern.h: Adjust decls to match defn changes elsewhere.
3571 (struct text_pos, struct glyph, struct bidi_saved_info)
3572 (struct bidi_string_data, struct bidi_it, struct composition_it)
3574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3575 (struct display_pos, struct composition_it, struct it):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * dispnew.c (increment_matrix_positions)
3578 (increment_row_positions, mode_line_string)
3579 (marginal_area_string):
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3581 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (duration_to_sec_usec): New function, to check for overflow better.
3584 (Fsleep_for, sit_for): Use it.
3585 * doc.c (get_doc_string, store_function_docstring):
3586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3587 (get_doc_string, Fsnarf_documentation):
3588 Use int, not EMACS_INT, where int is wide enough.
3590 Use SAFE_ALLOCA, not alloca.
3591 Check for overflow when converting EMACS_INT to off_t.
3592 * doprnt.c (doprnt):
3593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3594 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3595 Don't assume uid_t fits into fixnum.
3596 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3597 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3598 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3599 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3600 (general_insert_function)
3601 (Finsert_char, make_buffer_string, make_buffer_string_both)
3602 (update_buffer_properties, Fbuffer_substring)
3603 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3604 (Fsubst_char_in_region, check_translation)
3605 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3606 (transpose_markers, Ftranspose_regions):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 (clip_to_bounds): Move to lisp.h as an inline function).
3609 (Fconstrain_to_field): Don't assume integers are nonnegative.
3610 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3611 (Fsubst_char_in_region, Fsave_restriction):
3612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3613 (Femacs_pid): Don't assume pid_t fits into fixnum.
3614 (lo_time): Use int, not EMACS_INT, when int suffices.
3615 (lisp_time_argument): Check for usec out of range.
3616 (Fencode_time): Don't assume fixnum fits in int.
3617 (Fuser_login_name, Fuser_full_name): Signal an error
3618 if a uid argument is out of range, rather than relying on
3620 (Fformat_time_string): Remove now-unnecessary check.
3621 lisp_time_argument checks for out-of-range usec now.
3622 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3623 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3624 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3625 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3626 (init_cmdargs, Fdump_emacs):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3629 the bottom (typically) 32 bits of the fixnum.
3630 * eval.c (specpdl_size, call_debugger):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 (when_entered_debugger, Fbacktrace_debug):
3633 Don't assume fixnum can fit in int.
3634 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3635 the object just before a buffer; this is not portable.
3636 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3637 (grow_specpdl, unbind_to):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3640 (grow_specpdl): Simplify allocation by using xpalloc.
3641 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3642 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3643 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3645 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3648 (Fcopy_file, non_regular_nbytes, read_non_regular)
3649 (Finsert_file_contents):
3650 Use int, not EMACS_INT, where int is wide enough.
3651 (READ_BUF_SIZE): Verify that it fits in int.
3652 (Finsert_file_contents): Check that counts are in proper range,
3653 rather than assuming fixnums fit into ptrdiff_t etc.
3654 Don't assume fixnums fit into int.
3655 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3656 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3657 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3658 (string_char_to_byte, string_byte_to_char)
3659 (string_make_multibyte, string_to_multibyte)
3660 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3661 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3662 (substring_both, Fdelete, internal_equal, Ffillarray)
3663 (Fclear_string, mapcar1)
3664 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3665 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3666 (larger_vector, make_hash_table, maybe_resize_hash_table)
3667 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3668 (Fmaphash, secure_hash):
3669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3670 (concat): Check for string index and length overflow.
3671 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3674 (larger_vector): New API (vec, incr_min, size_max) replaces old
3675 one (vec, new_size, init). This catches size overflow.
3676 INIT was removed because it was always Qnil.
3677 All callers changed.
3678 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3679 the upper bound on a hash table index size.
3680 (make_hash_table, maybe_resize_hash_table): Use it.
3681 (secure_hash): Computer start_byte and end_byte only after
3682 they're known to be in ptrdiff_t range.
3683 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3684 (Ffont_get_glyphs, Ffont_at):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3687 (Flist_fonts, Fopen_font):
3688 Don't assume fixnum can fit in int.
3689 (check_gstring): Don't assume index can fit in int.
3690 (font_match_p): Check that fixnum is a character, not a nonnegative
3691 fixnum, since the later code needs to stuff it into an int.
3692 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3693 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3694 conversion overflow issues.
3695 (Fopen_font): Check for integer out of range.
3696 (Ffont_get_glyphs): Don't assume index can fit in int.
3697 * font.h: Adjust decls to match defn changes elsewhere.
3698 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3700 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3701 printmax_t, where ptrdiff_t is wide enough.
3702 (Finternal_char_font):
3703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3704 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3705 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3706 (Fset_frame_position, x_set_frame_parameters)
3707 (x_set_line_spacing, x_set_border_width)
3708 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3709 Check that fixnums are in proper range for system types.
3710 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3712 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3713 Use SAFE_ALLOCA_LISP, not alloca.
3714 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3715 intptr_t is wide enough.
3716 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3717 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3718 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3719 Check for fixnum out of range.
3720 * ftfont.c (ftfont_list): Don't assume index fits in int.
3721 Check that fixnums are in proper range for system types.
3722 (ftfont_shape_by_flt):
3723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3724 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3726 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3727 Check that fixnums are in proper range for system types.
3728 * gnutls.h: Adjust decls to match defn changes elsewhere.
3729 * gtkutil.c (xg_dialog_run):
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 (update_frame_tool_bar):
3732 Check that fixnums are in proper range for system types.
3733 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3734 (lookup_image): Check that fixnums are in range for system types.
3735 * indent.c (last_known_column, last_known_column_point):
3736 (current_column_bol_cache):
3737 (skip_invisible, current_column, check_display_width):
3738 (check_display_width, scan_for_column, current_column_1)
3739 (Findent_to, Fcurrent_indentation, position_indentation)
3740 (indented_beyond_p, Fmove_to_column, compute_motion):
3741 (Fcompute_motion, Fvertical_motion):
3742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3743 (last_known_column_modified): Use EMACS_INT, not int.
3744 (check_display_width):
3746 Check that fixnums and floats are in proper range for system types.
3747 (compute_motion): Don't assume index or fixnum fits in int.
3748 (compute_motion, Fcompute_motion):
3749 Use int, not EMACS_INT, when it is wide enough.
3750 (vmotion): Omit local var start_hpos that is always 0; that way
3751 we don't need to worry about overflow in expressions involving it.
3752 * indent.h: Adjust decls to match defn changes elsewhere.
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 Use int, not EMACS_INT, where int is wide enough.
3756 Remove unused members ovstring_chars_done and tab_offset;
3758 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3759 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3760 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3761 (make_gap, copy_text, insert, insert_and_inherit)
3762 (insert_before_markers, insert_before_markers_and_inherit)
3763 (insert_1, count_combining_before, count_combining_after)
3764 (insert_1_both, insert_from_string)
3765 (insert_from_string_before_markers, insert_from_string_1)
3766 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3767 (adjust_after_replace, adjust_after_insert, replace_range)
3768 (replace_range_2, del_range, del_range_1, del_range_byte)
3769 (del_range_both, del_range_2, modify_region)
3770 (prepare_to_modify_buffer, signal_before_change)
3771 (signal_after_change, Fcombine_after_change_execute):
3772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3773 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3774 (balance_an_interval, split_interval_right, split_interval_left)
3775 (find_interval, next_interval, update_interval)
3776 (adjust_intervals_for_insertion, delete_node, delete_interval)
3777 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3778 (static_offset_intervals, offset_intervals)
3779 (merge_interval_right, merge_interval_left, make_new_interval)
3780 (graft_intervals_into_buffer, temp_set_point_both)
3781 (temp_set_point, set_point, adjust_for_invis_intang)
3782 (set_point_both, move_if_not_intangible, get_property_and_range)
3783 (get_local_map, copy_intervals, copy_intervals_to_string)
3784 (compare_string_intervals, set_intervals_multibyte_1):
3785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3786 * intervals.h: Adjust decls to match defn changes elsewhere.
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 * keyboard.c (this_command_key_count, this_single_command_key_start)
3790 (before_command_key_count, before_command_echo_length, echo_now)
3791 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3792 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3793 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3794 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3796 (last_non_minibuf_size, last_point_position, echo_truncate)
3797 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3798 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3799 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3800 (stuff_buffered_input):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3802 (last_auto_save, command_loop_1, read_char):
3803 Use EMACS_INT, not int, to avoid integer overflow.
3804 (record_char): Avoid overflow in total_keys computation.
3805 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3806 * keyboard.h: Adjust decls to match defn changes elsewhere.
3807 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3808 (Fkey_description, Fdescribe_vector, Flookup_key):
3809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3810 (click_position): New function, to check that positions are in range.
3811 (Fcurrent_active_maps):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 (Faccessible_keymaps, Fkey_description):
3815 (preferred_sequence_p):
3816 Don't assume fixnum can fit into int.
3817 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3818 Check for integer overflow in size calculations.
3819 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3820 avoid mishandling large integers.
3821 * lisp.h: Adjust decls to match defn changes elsewhere.
3822 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3823 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3824 (struct Lisp_Marker):
3825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3826 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3827 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3828 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3829 All callers changed.
3830 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3831 Assume the arg has valid form, since it always does.
3832 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3833 unsigned integer system type.
3834 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3835 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3837 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3838 (duration_to_sec_usec): New decl.
3839 * lread.c (read_from_string_index, read_from_string_index_byte)
3840 (read_from_string_limit, readchar, unreadchar, openp)
3841 (read_internal_start, read1, oblookup):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 (Fload, readevalloop, Feval_buffer, Feval_region):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 (openp): Check for out-of-range argument to 'access'.
3846 (read1): Use int, not EMACS_INT, where int is wide enough.
3847 Don't assume fixnum fits into int.
3848 Fix off-by-one error that can read outside a buffer.
3849 (read_filtered_event): Use duration_to_sec_usec
3850 to do proper overflow checking on durations.
3851 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3852 in size calculation.
3853 (Fexecute_kbd_macro):
3854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3855 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3856 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3857 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3858 (set_marker_both, set_marker_restricted_both, marker_position)
3859 (marker_byte_position, Fbuffer_has_markers_at):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3862 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3863 It now merely ensures that the menu is large enough, without
3864 necessarily growing it, as this avoids some integer overflow issues.
3865 All callers changed.
3866 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3868 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3869 Use SAFE_ALLOCA_LISP, not alloca.
3870 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3871 to EMACS_INT. Check that fixnums are in proper range for system types.
3872 * minibuf.c (minibuf_prompt_width, string_to_object)
3873 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3874 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (get_minibuffer, read_minibuf_unwind):
3877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3878 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3879 this simplifies overflow checking. All callers changed.
3880 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3884 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3885 Check that fixnums are in proper range for system types.
3886 (Fx_create_frame, Fx_show_tip):
3887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3888 * nsfont.m (ns_findfonts, nsfont_list_family):
3889 Don't assume fixnum fits in long.
3890 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3892 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3894 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3896 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3897 (PRINTDECLARE, PRINTPREPARE):
3898 (strout, print_string):
3899 (print, print_preprocess, print_check_string_charset_prop)
3901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3903 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3906 (printchar, strout): Use xpalloc to catch size calculation overflow.
3907 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3908 (print_error_message): Use SAFE_ALLOCA, not alloca.
3909 (print_object): Use int, not EMACS_INT, where int is wide enough.
3910 (print_depth, new_backquote_output, print_number_index):
3911 Use ptrdiff_t, not int, where int might not be wide enough.
3912 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3913 (Fset_process_window_size, Fformat_network_address)
3914 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3916 Check that fixnums are in proper range for system types.
3917 (Fsignal_process): Simplify by avoiding a goto.
3918 Check for process-ids out of pid_t range rather than relying on
3920 (process_tick, update_tick): Use EMACS_INT, not int.
3921 (Fformat_network_address, read_process_output, send_process)
3922 (Fprocess_send_region, status_notify):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3925 (wait_reading_process_output, read_process_output, exec_sentinel):
3926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3927 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3928 (Faccept_process_output): Use duration_to_sec_usec to do proper
3929 overflow checking on durations.
3930 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3931 Don't assume pid_t fits in int.
3932 * process.h (struct Lisp_Process): Members tick and update_tick
3933 are now of type EMACS_INT, not int.
3934 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3935 configured --with-wide-int.
3936 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3937 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3938 * search.c (looking_at_1, string_match_1):
3939 (fast_string_match, fast_c_string_match_ignore_case)
3940 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3941 (scan_newline, find_before_next_newline, search_command)
3942 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3943 (set_search_regs, wordify):
3946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3947 (string_match_1, search_buffer, set_search_regs):
3949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3950 (wordify): Check for overflow in size calculation.
3951 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3952 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3953 Check that fixnums are in proper range for system types.
3954 * sound.c (struct sound_device)
3955 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (Fplay_sound_internal):
3958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3959 * syntax.c (struct lisp_parse_state, find_start_modiff)
3960 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3961 (Fparse_partial_sexp):
3962 Don't assume fixnums can fit in int.
3963 (struct lisp_parse_state, find_start_pos, find_start_value)
3964 (find_start_value_byte, find_start_begv)
3965 (update_syntax_table, char_quoted, dec_bytepos)
3966 (find_defun_start, prev_char_comend_first, back_comment):
3967 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3968 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3970 (Finternal_describe_syntax_value): Check that match_lisp is a
3971 character, not an integer, since the code stuffs it into int.
3972 (scan_words, scan_sexps_forward):
3973 Check that fixnums are in proper range for system types.
3975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3976 (scan_sexps_forward):
3977 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3978 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3979 * syntax.h: Adjust decls to match defn changes elsewhere.
3980 (struct gl_state_s):
3981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3982 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3983 MOST_POSITIVE_FIXNUM.
3984 * sysdep.c (wait_for_termination_1, wait_for_termination)
3985 (interruptible_wait_for_termination, mkdir):
3986 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3987 (emacs_read, emacs_write):
3988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3989 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3990 and double all fit in int.
3991 * term.c (set_tty_color_mode):
3992 Check that fixnums are in proper range for system types.
3993 * termhooks.h (struct input_event):
3994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3995 * textprop.c (validate_interval_range, interval_of)
3996 (Fadd_text_properties, set_text_properties_1)
3997 (Fremove_text_properties, Fremove_list_of_text_properties)
3998 (Ftext_property_any, Ftext_property_not_all)
3999 (copy_text_properties, text_property_list, extend_property_ranges)
4000 (verify_interval_modification):
4001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4002 (Fnext_single_char_property_change)
4003 (Fprevious_single_char_property_change):
4004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4005 (copy_text_properties):
4006 Check for integer overflow in index calculation.
4007 * undo.c (last_boundary_position, record_point, record_insert)
4008 (record_delete, record_marker_adjustment, record_change)
4009 (record_property_change):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4013 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4014 (Fx_hide_tip, Fx_file_dialog):
4015 * w32menu.c (set_frame_menubar):
4016 Use ptrdiff_t, not int, for consistency with rest of code.
4017 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4018 (select_window, Fdelete_other_windows_internal)
4019 (window_scroll_pixel_based, window_scroll_line_based)
4020 (Frecenter, Fset_window_configuration):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4022 (Fset_window_hscroll, run_window_configuration_change_hook)
4023 (set_window_buffer, temp_output_buffer_show, scroll_command)
4024 (Fscroll_other_window, Frecenter):
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4026 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4027 Don't assume fixnum fits in int.
4028 (Fset_window_scroll_bars):
4029 Check that fixnums are in proper range for system types.
4030 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4031 (string_pos, c_string_pos, number_of_chars, init_iterator)
4032 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4033 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4034 (compute_display_string_end, handle_face_prop)
4035 (face_before_or_after_it_pos, handle_invisible_prop)
4036 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4037 (display_prop_intangible_p, string_buffer_position_lim)
4038 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4039 (get_overlay_strings_1, get_overlay_strings)
4040 (iterate_out_of_display_property, forward_to_next_line_start)
4041 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4042 (get_next_display_element, set_iterator_to_next)
4043 (get_visually_first_element, compute_stop_pos_backwards)
4044 (handle_stop_backwards, next_element_from_buffer)
4045 (move_it_in_display_line_to, move_it_in_display_line)
4046 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4047 (add_to_log, message_dolog, message_log_check_duplicate)
4048 (message2, message2_nolog, message3, message3_nolog
4049 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4050 (current_message_1, truncate_echo_area, truncate_message_1)
4051 (set_message, set_message_1, store_mode_line_noprop)
4052 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4053 (text_outside_line_unchanged_p, check_point_in_composition)
4054 (reconsider_clip_changes)
4055 (redisplay_internal, set_cursor_from_row, try_scrolling)
4056 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4057 (redisplay_window, find_last_unchanged_at_beg_row)
4058 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4059 (trailing_whitespace_p, find_row_edges, display_line)
4060 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4061 (display_mode_element, store_mode_line_string)
4062 (pint2str, pint2hrstr, decode_mode_spec)
4063 (display_count_lines, display_string, draw_glyphs)
4064 (x_produce_glyphs, x_insert_glyphs)
4065 (rows_from_pos_range, mouse_face_from_buffer_pos)
4066 (fast_find_string_pos, mouse_face_from_string_pos)
4067 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4069 (safe_call, init_from_display_pos, handle_fontified_prop)
4070 (handle_single_display_spec, load_overlay_strings)
4071 (with_echo_area_buffer, setup_echo_area_for_printing)
4072 (display_echo_area, echo_area_display)
4073 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4074 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4075 (redisplay_window, dump_glyph_row, display_mode_line)
4076 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4077 (handle_display_spec, display_prop_string_p):
4078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4079 (handle_single_display_spec, build_desired_tool_bar_string)
4080 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4081 (get_specified_cursor_type):
4082 Check that fixnums are in proper range for system types.
4083 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4084 (Flookup_image_map):
4085 Don't assume fixnums fit in int.
4086 (compare_overlay_entries):
4087 Avoid mishandling comparisons due to subtraction overflow.
4088 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4089 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4090 (handle_tool_bar_click):
4091 Use int, not unsigned, since we prefer signed and the signedness
4092 doesn't matter here.
4093 (get_next_display_element, next_element_from_display_vector):
4094 Use int, not EMACS_INT, when int is wide enough.
4095 (start_hourglass): Use duration_to_sec_usec to do proper
4096 overflow checking on durations.
4097 * xfaces.c (Fbitmap_spec_p):
4098 Check that fixnums are in proper range for system types.
4099 (compare_fonts_by_sort_order):
4100 Avoid mishandling comparisons due to subtraction overflow.
4101 (Fx_family_fonts, realize_basic_faces):
4102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4104 Don't assume fixnum fits in int.
4105 Use SAFE_ALLOCA_LISP, not alloca.
4106 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4107 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4108 (face_at_buffer_position, face_for_overlay_string)
4109 (face_at_string_position):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4112 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4114 Check that fixnums are in proper range for system types.
4115 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4116 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 (Fx_change_window_property): Don't assume fixnums fit in int.
4119 * xfont.c (xfont_chars_supported):
4120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4121 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4122 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 * xml.c (parse_region):
4125 * xrdb.c (magic_file_p):
4126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4127 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4128 (x_get_local_selection, x_reply_selection_request)
4129 (x_handle_selection_request, wait_for_property_change):
4130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4131 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4132 short is wide enough.
4133 (x_send_client_event): Don't assume fixnum fits in int.
4134 * xterm.c (x_x_to_emacs_modifiers):
4135 Don't assume EMACS_INT overflows nicely into int.
4136 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4138 (handle_one_xevent): NATNUMP can eval its arg twice.
4139 (x_connection_closed):
4140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4141 * xterm.h: Adjust decls to match defn changes elsewhere.
4142 (struct scroll_bar): Use struct vectorlike_header
4143 rather than rolling our own approximation.
4144 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4146 2012-05-25 Glenn Morris <rgm@gnu.org>
4148 * lisp.mk (lisp): Update for more files being compiled now.
4150 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4152 * lread.c: Remove `read_pure' which makes no difference.
4153 (read_pure): Remove var.
4154 (unreadpure): Remove function.
4155 (readevalloop): Don't call read_list with -1 flag.
4156 (read1, read_vector): Don't test read_pure any more.
4157 (read_list): Simplify.
4159 * fileio.c, character.h: Minor style tweaks.
4161 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4163 * window.h (clip_changed): Remove useless declaration.
4165 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4167 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4168 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4170 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4173 This directory predates autoconf and is no longer needed nowadays.
4174 Move its few remaining bits of functionality to where they're needed.
4175 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4176 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4177 * m/template.h: Remove.
4178 * Makefile.in (M_FILE): Remove. All uses removed.
4179 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4180 * lisp.h (USE_LSB_TAG):
4181 * mem-limits.h (EXCEEDS_LISP_PTR):
4182 Use VAL_MAX, not VALBITS, in #if.
4183 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4184 (EMACS_UINT): Define unconditionally now.
4185 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4186 (BITS_PER_EMACS_INT): New constants, replacing
4187 what used to be in config.h, but not useful in #if.
4188 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4189 define them any more.
4190 (VAL_MAX): New macro.
4192 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4193 BITS_PER_EMACS_INT, in #if.
4194 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4195 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4196 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4197 * s/ms-w32.h (DATA_START):
4198 Move here from removed file m/intel386.h.
4199 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4200 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4202 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4204 Assume C89 or later.
4205 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4206 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4208 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4209 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4210 * textprop.c, tparam.c (NULL): Remove.
4211 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4212 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4213 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4214 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4215 * xterm.c (input_signal_count): Assume volatile works.
4217 2012-05-21 Ken Brown <kbrown@cornell.edu>
4219 * xgselect.c (xg_select): Fix first argument in call to 'select'
4222 2012-05-20 Ken Brown <kbrown@cornell.edu>
4224 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4225 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4227 2012-05-19 Ken Brown <kbrown@cornell.edu>
4229 * xfns.c (x_in_use): Remove `static' qualifier.
4230 * xterm.h (x_in_use): Declare.
4231 * xgselect.c: Include xterm.h.
4232 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4233 and `display_arg' (bug#9754).
4235 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4237 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4239 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4240 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4242 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4244 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4246 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4247 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4249 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4250 reference to image_cache->refcount.
4251 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4253 2012-05-17 Juri Linkov <juri@jurta.org>
4255 * search.c (Fword_search_regexp, Fword_search_backward)
4256 (Fword_search_forward, Fword_search_backward_lax)
4257 (Fword_search_forward_lax): Move functions to isearch.el
4258 (bug#10145, bug#11381).
4260 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4262 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4264 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4266 * lread.c (init_obarray): Declare Qt and Qnil as special.
4268 2012-05-14 Glenn Morris <rgm@gnu.org>
4270 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4271 Put "libexec" before "bin", for the sake of init_callproc_1.
4273 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4275 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4277 * unexaix.c: Port to more-recent AIX compilers.
4278 (report_error, report_error_1, make_hdr, copy_sym)
4279 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4280 Make arguments const char *, not char *, to avoid violations of C
4281 standard and to fix some AIX warnings reported by Gilles Pion.
4283 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4285 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4286 already have overlays loaded.
4287 (handle_single_display_spec): Before returning without displaying
4288 fringe bitmap, synchronize the bidi iterator with the main display
4289 iterator, by calling iterate_out_of_display_property.
4290 (iterate_out_of_display_property): Detect buffer iteration by
4291 testing that it->string is a Lisp string.
4292 (get_next_display_element): When the current object is exhausted,
4293 and there's something on it->stack, call set_iterator_to_next to
4294 proceed with what's on the stack, instead of returning zero.
4295 (set_iterator_to_next): If called at the end of a Lisp string,
4296 proceed to consider_string_end without incrementing string
4297 position. Don't increment display vector index past the end of
4298 the display vector. (Bug#11417)
4299 (pos_visible_p): Don't report a position visible when move_it_to
4300 stopped at the last line of window, which happens to be scanned
4301 backwards by the bidi iteration. (Bug#11464)
4303 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4305 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4306 and right-margin display specs even if the spec is invalid or we
4307 are on a TTY, and thus unable to display on the fringes.
4308 That's because the text with the property will not be displayed anyway,
4309 so we need to signal to the caller that this is a "replacing"
4310 display spec. This fixes display when the spec is invalid or we
4313 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4315 * unexaix.c (make_hdr): Fix typo in prototype.
4316 This bug broke the build on AIX. Problem reported by Gilles Pion.
4318 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4320 * keyboard.c (kbd_buffer_get_event): Read special events also in
4321 batch mode. (Bug#11415)
4323 2012-05-12 Glenn Morris <rgm@gnu.org>
4325 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4327 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4329 * lisp.mk (lisp): Add newcomment.elc.
4331 2012-05-12 Glenn Morris <rgm@gnu.org>
4333 * Makefile.in (MKDIR_P): New, set by configure.
4334 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4336 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4338 Remove unused function hourglass_started.
4339 * dispextern.h (hourglass_started):
4340 * w32fns.c (hourglass_started):
4341 * xdisp.c (hourglass_started): Remove.
4343 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4345 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4346 Update dependencies.
4348 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4350 * xgselect.c (xg_select): Put maxfds+1 into a var.
4351 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4353 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4355 2012-05-10 Dave Abrahams <dave@boostpro.com>
4357 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4358 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4360 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4362 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4363 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4364 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4365 Initialize xd_registered_buses.
4367 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4369 Untag more efficiently if USE_LSB_TAG.
4370 This is based on a proposal by YAMAMOTO Mitsuharu in
4371 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4372 For an admittedly artificial (nth 8000 longlist) benchmark on
4373 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4374 Emacs's overall text size by 1%.
4375 * lisp.h (XUNTAG): New macro.
4376 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4377 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4378 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4379 * eval.c (Fautoload):
4380 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4381 * frame.h (XFRAME): Use XUNTAG.
4383 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4384 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4385 Remove unportable assumptions about print widths of types like
4387 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4388 intptr_t when converting between pointer and integer, to avoid GCC
4389 warnings about wrong width.
4391 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4393 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4394 stack for each reader_thread, instead of defaulting to 8MB
4395 determined by the linker. This avoids failures in creating
4396 subprocesses on Windows 7, see the discussion in this thread:
4397 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4399 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4401 Fix up display of the *Minibuf-0* buffer in the mini window.
4402 * keyboard.c (read_char): Don't clear the echo area if there's no
4404 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4405 contents of *Minibuf-0*) if there's no message displayed in its stead.
4407 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4409 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4412 2012-05-06 Chong Yidong <cyd@gnu.org>
4414 * lisp.mk (lisp): Update.
4416 2012-05-05 Jim Meyering <meyering@redhat.com>
4418 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4420 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4422 * data.c (PUT_ERROR): New macro.
4423 (syms_of_data): Use it. Add new error type `user-error'.
4424 * undo.c (user_error): New function.
4425 (Fprimitive_undo): Use it.
4426 * print.c (print_error_message): Adjust print style for `user-error'.
4427 * keyboard.c (user_error): New function.
4428 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4430 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4432 Do not limit current-time-string to years 1000..9999.
4433 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4434 (Fcurrent_time_string): Support any year that is supported by the
4435 underlying localtime representation. Don't use asctime, as it
4436 has undefined behavior for years outside the range -999..9999.
4438 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4440 Fix race conditions involving setenv, gmtime, localtime, asctime.
4441 Without this fix, interrupts could mess up code that uses these
4442 nonreentrant functions, since setting TZ invalidates existing
4443 tm_zone or tzname values, and since most of these functions return
4444 pointers to static storage.
4445 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4446 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4447 Grow the critical sections to include not just invoking
4448 localtime/gmtime, but also accessing these functions' results
4449 including their tm_zone values if any, and any related TZ setting.
4450 (format_time_string): Last arg is now struct tm *, not struct tm **,
4451 so that the struct tm is saved in the critical section.
4452 All callers changed. Simplify allocation of initial buffer, partly
4453 motivated by the fact that memory allocation needs to be outside
4454 the critical section.
4456 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4458 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4459 with RESET_INTERVAL.
4461 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4462 Remove duplicated buffer name initialization.
4464 2012-05-02 Jim Meyering <jim@meyering.net>
4466 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4468 * xfns.c (x_window): Use xstrdup (Bug#11375).
4470 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4472 * xdisp.c (pos_visible_p): If already at a newline from the
4473 display string before the 'while' loop, don't walk back the glyphs
4474 from it3.glyph_row. Solves assertion violation when the display
4475 string begins with a newline (egg.el). (Bug#11367)
4477 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4479 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4482 2012-05-01 Glenn Morris <rgm@gnu.org>
4484 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4485 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4486 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4487 All were removed before 23.1.
4489 * dispnew.c: Remove HAVE_LIBNCURSES test;
4490 it is always true on relevant platforms.
4492 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4493 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4495 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4497 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4499 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4500 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4503 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4505 Do not avoid creating empty evaporating overlays (Bug#9642).
4506 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4507 That is, do not delete an evaporating overlay if it becomes
4508 empty after its bounds are adjusted to fit within its buffer.
4509 This fix caused other problems, and I'm reverting it until we get
4510 to the bottom of them.
4512 2012-04-27 Chong Yidong <cyd@gnu.org>
4514 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4516 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4518 * xdisp.c (pos_visible_p): If the window start position is beyond
4519 ZV, start the display from buffer beginning. Prevents assertion
4520 violation in init_iterator when the minibuffer window is scrolled
4523 * window.c (window_scroll_pixel_based): Likewise.
4525 2012-04-27 Chong Yidong <cyd@gnu.org>
4527 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4529 2012-04-27 Glenn Morris <rgm@gnu.org>
4531 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4532 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4534 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4536 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4537 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4539 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4541 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4542 display element, check also the underlying string or buffer
4543 character. (Bug#11341)
4545 * w32menu.c: Include w32heap.h.
4546 (add_menu_item): If the call to AppendMenuW (via
4547 unicode_append_menu) fails, disable Unicode menus only if we are
4548 running on Windows 9X/Me.
4550 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4552 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4553 (xgetint): Add missing shift for LSB tags.
4555 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4557 * keyboard.c (read_char): Don't wipe echo area for select window
4558 events: These might get delayed via `mouse-autoselect-window'
4561 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4563 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4564 manipulation of :loaded-from data.
4566 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4568 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4569 now a cons (bug#11311).
4571 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4573 Do not create empty overlays with the evaporate property (Bug#9642).
4574 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4575 if it becomes empty after its bounds are adjusted to fit within
4576 its buffer. Without this fix, in a nonempty buffer (let ((o
4577 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4578 yields an empty overlay that has the evaporate property, which is
4579 not supposed to happen.
4581 Fix minor GTK3 problems found by static checking.
4582 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4583 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4584 (struct _EmacsFixedClass, emacs_fixed_get_type):
4585 Move decls here from emacsgtkfixed.h, since they needn't be public.
4586 (emacs_fixed_get_type): Now static.
4587 (emacs_fixed_class_init): Omit unused local.
4588 (emacs_fixed_child_type): Remove; unused.
4589 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4590 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4591 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4592 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4593 (EMACS_FIXED_GET_CLASS): Remove; unused.
4594 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4596 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4597 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4599 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4601 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4602 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4603 (__malloc_size_t, __malloc_ptrdiff_t):
4604 Remove. All uses removed, replaced by the definiens if needed,
4605 since we can assume C89 or better now.
4606 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4607 (protect_malloc_state, align, get_contiguous_space)
4608 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4609 (malloc_atfork_handler_child, malloc_enable_thread)
4610 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4611 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4612 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4613 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4614 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4615 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4616 Define using prototypes, not old style.
4617 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4618 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4619 (align): Don't assume that signed integer overflow wraps around.
4620 Omit unused local var.
4621 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4622 (_free_internal_nolock, memalign, mallochook, reallochook):
4623 Omit no-longer-needed casts.
4624 (valloc): Use getpagesize, not __getpagesize.
4625 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4626 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4628 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4630 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4632 Move functions from C to Lisp. Make non-blocking method calls
4633 the default. Implement further D-Bus standard interfaces.
4635 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4636 (QCdbus_request_name_allow_replacement)
4637 (QCdbus_request_name_replace_existing)
4638 (QCdbus_request_name_do_not_queue)
4639 (QCdbus_request_name_reply_primary_owner)
4640 (QCdbus_request_name_reply_in_queue)
4641 (QCdbus_request_name_reply_exists)
4642 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4643 (QCdbus_registered_serial, QCdbus_registered_method)
4644 (QCdbus_registered_signal): New Lisp objects.
4645 (XD_DEBUG_MESSAGE): Use sizeof.
4646 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4647 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4648 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4649 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4650 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4651 (xd_signature, xd_append_arg): Allow float for integer types.
4652 (xd_get_connection_references): New function.
4653 (xd_get_connection_address): Rename from xd_initialize.
4654 Return cached address.
4655 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4656 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4658 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4659 Return number of refcounts.
4660 (Fdbus_get_unique_name): Make stronger parameter check.
4661 (Fdbus_message_internal): New defun.
4662 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4663 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4664 (Fdbus_send_signal, Fdbus_register_service)
4665 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4666 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4667 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4668 (Vdbus_compiled_version, Vdbus_runtime_version)
4669 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4670 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4671 (Vdbus_message_type_signal): New defvars.
4672 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4675 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4677 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4678 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4679 Do not assume ptrdiff_t is the same width as 'int'.
4681 * alloc.c: Handle unusual debugging option combinations.
4682 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4683 since the two debugging options are incompatible.
4684 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4686 (mem_init, mem_insert, mem_insert_fixup):
4687 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4688 (NEED_MEM_INSERT): Remove; no longer needed.
4690 2012-04-22 Leo Liu <sdl.web@gmail.com>
4692 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4694 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4696 * sysdep.c [__FreeBSD__]: Minor cleanups.
4697 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4698 Use Emacs indenting style more consistently. Avoid some casts.
4699 Use 'double' consistently rather than mixing 'float' and 'double'.
4701 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4703 * sysdep.c (list_system_processes, system_process_attributes):
4704 Add implementation for FreeBSD (Bug#5243).
4706 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4708 * lisp.mk (lisp): Update.
4710 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4712 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4713 It is never used otherwise.
4715 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4717 * print.c (print_preprocess): Only check print_depth if print-circle
4719 (print_object): Check for cycles even when print-circle is nil and
4720 print-gensym is t, but only check print_depth if print-circle is nil.
4722 2012-04-20 Chong Yidong <cyd@gnu.org>
4724 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4725 set the status to "failed" and ensure that sentinel is run.
4727 2012-04-20 Glenn Morris <rgm@gnu.org>
4729 * process.c (Fset_process_inherit_coding_system_flag)
4730 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4731 (Fmake_network_process, Fmake_serial_process): Doc fix.
4733 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4735 * xdisp.c (string_buffer_position_lim): Limit starting position to
4737 (set_cursor_from_row): If called for a mode-line or header-line
4738 row, return zero immediately.
4739 (try_cursor_movement): If inside continuation line, don't back up
4740 farther than the first row after the header line, if any.
4741 Don't consider the header-line row as "partially visible", even if
4742 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4744 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4746 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4749 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4750 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4752 configure: new option --enable-gcc-warnings (Bug#11207)
4753 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4754 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4755 (ALL_CFLAGS): Use new macros rather than old.
4756 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4757 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4758 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4759 -Wunused-result, -Wunused-variable. This should go away once
4760 the Emacs and Gnulib regex code is merged.
4761 (xmalloc, xrealloc): Now static.
4763 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4765 * dired.c (Fsystem_groups): Remove unused local.
4767 2012-04-17 Glenn Morris <rgm@gnu.org>
4769 * dired.c (Fsystem_users): Doc fix.
4771 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4773 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4774 (syms_of_dired): Add them.
4776 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4778 Fix minor alloc.c problems found by static checking.
4779 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4780 New extern decls, to avoid calling undeclared functions.
4781 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4782 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4783 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4784 (NEED_MEM_INSERT): New macro.
4785 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4786 Remove one incorrect comment and fix another.
4788 Fix minor ralloc.c problems found by static checking.
4789 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4790 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4791 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4792 (r_alloc_sbrk): Now static.
4794 Improve ralloc.c interface checking.
4795 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4796 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4797 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4798 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4799 [REL_ALLOC]: ... to here, to check interface.
4800 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4801 Remove decls. This fixes an "It stinks!".
4803 * alloc.c (which_symbols): Fix alignment issue / type clash.
4805 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4807 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4808 (struct Lisp_Misc_Any): Likewise.
4809 (struct Lisp_Free): Likewise.
4810 * alloc.c (union aligned_Lisp_Symbol): Define.
4811 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4812 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4813 (union aligned_Lisp_Misc): Define.
4814 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4815 aligned_Lisp_Misc instead of union Lisp_Misc.
4816 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4818 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4820 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4821 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4822 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4823 * s/netbsd.h, s/sol2-6.h:
4824 Remove definition of GC_MARK_STACK, since the default now works.
4825 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4826 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4827 no longer the default.
4828 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4830 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4832 * lread.c (lisp_file_lexically_bound_p):
4833 Fix hang at ";-*-\n" (bug#11238).
4835 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4837 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4838 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4840 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4842 * nsterm.m (constrainFrameRect): Always constrain when there is only
4843 one screen (Bug#10962).
4845 2012-04-13 Ken Brown <kbrown@cornell.edu>
4847 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4849 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4851 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4853 2012-04-11 Daniel Colascione <dancol@dancol.org>
4855 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4856 against is gone. It's better to use vfork now so that when Cygwin
4857 gains a new, working vfork, we use it automatically (bug#10398).
4859 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4861 * window.c (save_window_save): Obey window-point-insertion-type.
4863 2012-04-11 Glenn Morris <rgm@gnu.org>
4865 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4867 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4869 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4871 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4873 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4874 (force_quit_count): New var.
4875 (handle_interrupt): Use it.
4877 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4879 * w32.c (w32_delayed_load): Record the full path of the library
4880 being loaded (bug#10424).
4882 2012-04-09 Glenn Morris <rgm@gnu.org>
4884 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4885 not just in the obarray, before snarfing them. (Bug#11036)
4887 * Makefile.in ($(leimdir)/leim-list.el):
4888 Pass EMACS rather than BUILT_EMACS.
4890 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4892 * process.c (make_process):
4893 * process.h: Add integer `gnutls_handshakes_tried' member to
4896 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4897 Add convenience `GNUTLS_LOG2i' macro.
4899 * gnutls.c (gnutls_log_function2i): Convenience log function.
4900 (emacs_gnutls_read): Use new log functions,
4901 `gnutls_handshakes_tried' process member, and
4902 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4903 attempts per process (connection).
4905 2012-04-09 Chong Yidong <cyd@gnu.org>
4907 * eval.c (Fuser_variable_p, user_variable_p_eh)
4908 (lisp_indirect_variable): Functions deleted.
4909 (Fdefvar): Caller changed.
4911 * callint.c (Finteractive, Fcall_interactively):
4912 * minibuf.c (Fread_variable): Callers changed.
4914 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4916 * xdisp.c (set_cursor_from_row): If the display string appears in
4917 the buffer at position that is closer to point than the position
4918 after the display string, display the cursor on the first glyph of
4919 the display string. Fixes cursor display when a 'display' text
4920 property immediately follows invisible text. (Bug#11094)
4922 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4924 composite.c: use 'double' consistently
4925 * composite.c (get_composition_id): Use 'double' consistently
4926 instead of converting 'float' to 'double' and vice versa; this is
4927 easier to understand and avoids a GCC warning.
4929 2012-04-09 Glenn Morris <rgm@gnu.org>
4931 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4932 preparation for dumping it with emacs. (Bug#4789)
4933 (leimdir): New variable.
4934 ($(leimdir)/leim-list.el): New rule.
4935 (emacs$(EXEEXT)): Depend on leim-list.el.
4937 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4938 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4939 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4941 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4943 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4946 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4948 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4949 Remove unused local variable.
4951 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4953 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4954 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4955 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4956 objects, as mark_maybe_pointer will catch them otherwise.
4957 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4958 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4960 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4962 Fix typo that broke non-Windows builds.
4963 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4965 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4967 Support building on MS-Windows with libxml2.
4969 * makefile.w32-in (OBJ2): Add xml.$(O).
4970 (GLOBAL_SOURCES): Add xml.c.
4971 ($(BLD)/xml.$(O)): New dependency list.
4973 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4974 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4975 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4976 [!WINDOWSNT]: New macros.
4977 (init_libxml2_functions, libxml2_loaded_p): New functions.
4978 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4979 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4980 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4981 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4983 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4984 Call init_libxml2_functions before calling libxml2 functions.
4985 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4987 * emacs.c: Don't include libxml/parser.h.
4988 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4989 xmlCleanupParser directly.
4991 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4993 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4995 * indent.c (Fvertical_motion): If there is a display string at
4996 point, use it.vpos to compute how many lines to backtrack after
4997 move_it_to point. (Bug#11133)
4999 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5001 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5002 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5003 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5004 macros related to unification of CJK characters. For the details,
5005 see the discussion following the message here:
5006 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5008 2012-04-04 Chong Yidong <cyd@gnu.org>
5010 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5012 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5014 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5015 instead of alloca. (Bug#11138)
5017 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5019 * w32menu.c (is_simple_dialog): Properly check lisp types.
5022 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5024 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5025 position we get to after a call to move_it_to fails the
5026 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5027 only if we wind up in a string from display property. (Bug#11063)
5029 * window.c (Fdelete_other_windows_internal): Invalidate the row
5030 and column information about mouse highlight, so that redisplay
5031 restores it after reallocating the glyph matrices. (Bug#7464)
5033 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5034 string comes from a `display' text property, use the buffer
5035 position of that property as if we actually saw that position in
5037 (move_it_by_lines): Remove the assertion that
5038 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5039 violated when there's a before-string at the beginning of a line.
5042 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5044 * xdisp.c (append_space_for_newline): If the default face was
5045 remapped, use the remapped face for the appended newline.
5046 (extend_face_to_end_of_line): Use the remapped default face for
5047 extending the face to the end of the line.
5048 (display_line): Call extend_face_to_end_of_line when the default
5049 face was remapped. (Bug#11068)
5051 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5053 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5055 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5057 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5059 2012-03-27 Glenn Morris <rgm@gnu.org>
5061 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5064 2012-03-26 Kenichi Handa <handa@m17n.org>
5066 * dispextern.h (struct glyph): Fix previous change. Change the
5067 bit length of glyphless.ch to 25 (Bug#11082).
5069 2012-03-26 Chong Yidong <cyd@gnu.org>
5071 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5072 (command_loop_1): Use it; inhibit selection update for
5073 handle-select-window too (Bug#8996).
5075 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5077 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5079 2012-03-25 Kenichi Handa <handa@m17n.org>
5081 * dispextern.h (struct glyph): Change the bit length of
5082 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5084 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5086 * s/ms-w32.h (tzname): Include time.h before redirecting to
5087 _tzname. Fixes the MSVC build. (Bug#9960)
5089 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5091 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5094 * xterm.c (XTread_socket): Only modify handling_signal if
5095 !SYNC_INPUT. (Bug#11080)
5097 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5099 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5100 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5101 when fetching a multibyte character consumes more bytes than
5102 CHAR_BYTES returns, due to unification of CJK characters in
5103 string_char. (Bug#11073)
5105 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5107 * process.c (wait_reading_process_output): Handle pty disconnect
5108 by refraining from sending oneself a SIGCHLD (bug#10933).
5110 2012-03-22 Chong Yidong <cyd@gnu.org>
5112 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5114 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5115 Mark string as coming from a prefix property.
5116 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5117 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5119 2012-03-21 Chong Yidong <cyd@gnu.org>
5121 * xfaces.c (Vface_remapping_alist): Doc fix.
5123 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5125 * w32proc.c (Fw32_set_console_codepage)
5126 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5129 2012-03-20 Chong Yidong <cyd@gnu.org>
5131 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5132 to reflect default non-nil value of redisplay-dont-pause.
5134 2012-03-19 Kenichi Handa <handa@m17n.org>
5136 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5137 it fit in a valid range (Bug#11003).
5139 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5141 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5142 that is not from display property, accept the row as a "cursor
5143 row" if one of the string's character has a non-nil `cursor'
5144 property. Fixes cursor positioning when there are newlines in
5145 overlay strings, e.g. in icomplete.el. (Bug#11035)
5147 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5149 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5151 2012-03-12 Chong Yidong <cyd@gnu.org>
5153 * eval.c (inhibit_lisp_code): Rename from
5154 inhibit_window_configuration_change_hook; move from window.c.
5156 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5157 * window.c (run_window_configuration_change_hook)
5158 (syms_of_window): Callers changed.
5160 2012-03-11 Chong Yidong <cyd@gnu.org>
5162 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5164 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5166 2012-03-10 Chong Yidong <cyd@gnu.org>
5168 * frame.c (other_visible_frames): Don't assume the selected frame
5169 is visible (Bug#10955).
5171 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5173 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5175 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5177 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5178 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5181 2012-03-03 Glenn Morris <rgm@gnu.org>
5183 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5185 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5187 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5188 position past the first glyph_row that ends at ZV. (Bug#10902)
5189 (redisplay_window, next_element_from_string): Fix typos in
5191 (redisplay_window): Pass to move_it_vertically the margin in
5192 pixels, not in screen lines.
5194 2012-03-02 Glenn Morris <rgm@gnu.org>
5196 * buffer.c (buffer-list-update-hook): Doc fix.
5198 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5200 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5201 push_it before setting up the iterator for the first overlay
5202 string, even if we have an empty string loaded.
5203 (next_overlay_string): If there's an empty string on the iterator
5204 stack, pop the stack. (Bug#10903)
5206 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5208 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5209 Suggested by Stefan Monnier in
5210 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5211 * alloc.c (widen_to_Lisp_Object): New static function.
5212 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5213 and widening them to Lisp_Objects. This would work even if
5214 USE_LSB_TAG is defined and wide integers are used, which might
5215 happen in a future version of Emacs.
5217 2012-02-25 Chong Yidong <cyd@gnu.org>
5219 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5222 * xselect.c (Fx_selection_exists_p): Doc fix.
5223 (x_clipboard_manager_save_all): Print an informative message
5224 before saving to clipboard manager.
5226 2012-02-24 Chong Yidong <cyd@gnu.org>
5228 * keyboard.c (process_special_events): Handle all X selection
5229 requests in kbd_buffer, not just the next one (Bug#8869).
5231 2012-02-23 Chong Yidong <cyd@gnu.org>
5233 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5234 call when setting menu-bar-lines and tool-bar-lines parameters.
5235 (unwind_create_frame_1): New helper function.
5237 * window.c (inhibit_window_configuration_change_hook): New var.
5238 (run_window_configuration_change_hook): Obey it.
5239 (syms_of_window): Initialize it.
5241 2012-02-22 Chong Yidong <cyd@gnu.org>
5243 * xterm.c (x_draw_image_relief): Add missing type check for
5244 Vtool_bar_button_margin (Bug#10743).
5246 2012-02-21 Chong Yidong <cyd@gnu.org>
5248 * fileio.c (Vfile_name_handler_alist): Doc fix.
5250 * buffer.c (Fget_file_buffer): Protect against invalid file
5251 handler return value.
5253 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5255 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5256 when computing $valmask.
5258 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5259 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5260 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5261 It's useless in that case, and it can cause problems on hosts
5262 that allocate halves of EMACS_INT values separately.
5263 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5264 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5265 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5266 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5267 it avoids undefined behavior on hosts where shifting right by more
5268 than the word width has undefined behavior.
5270 2012-02-19 Chong Yidong <cyd@gnu.org>
5272 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5273 (Funhandled_file_name_directory, Ffile_name_as_directory)
5274 (Fdirectory_file_name, Fexpand_file_name)
5275 (Fsubstitute_in_file_name): Protect against invalid file handler
5276 return values (Bug#10845).
5278 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5280 * .gdbinit (pitx): Fix incorrect references to fields of the
5283 2012-02-17 Chong Yidong <cyd@gnu.org>
5285 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5287 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5289 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5290 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5292 2012-02-15 Chong Yidong <cyd@gnu.org>
5294 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5295 marked as special. Also, starting docstrings with * is obsolete.
5297 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5299 * gnutls.c (emacs_gnutls_write): Fix last change.
5301 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5303 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5306 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5308 * keymap.c (Fsingle_key_description): Handle char ranges.
5310 2012-02-12 Chong Yidong <cyd@gnu.org>
5312 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5313 as that creates a dangerous corner case.
5315 * window.c (Fdelete_window_internal): Invalidate the mouse
5316 highlight (Bug#9904).
5318 2012-02-12 Glenn Morris <rgm@gnu.org>
5320 * xselect.c (Fx_own_selection_internal)
5321 (Fx_get_selection_internal, Fx_disown_selection_internal)
5322 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5323 * nsselect.m (Fx_own_selection_internal)
5324 (Fx_disown_selection_internal, Fx_selection_exists_p)
5325 (Fx_selection_owner_p, Fx_get_selection_internal):
5326 Sync docs and argument specs with the xselect.c versions.
5328 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5330 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5332 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5334 * w32select.c (Fx_selection_exists_p): Sync doc string and
5335 argument list with xselect.c. (Bug#10783)
5337 * w16select.c (Fx_selection_exists_p): Sync doc string and
5338 argument list with xselect.c. (Bug#10783)
5340 2012-02-10 Glenn Morris <rgm@gnu.org>
5342 * fns.c (Fsecure_hash): Doc fix.
5344 2012-02-09 Kenichi Handa <handa@m17n.org>
5346 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5348 2012-02-07 Chong Yidong <cyd@gnu.org>
5350 * buffer.c (Fbuffer_local_variables)
5351 (buffer_lisp_local_variables): Handle unbound vars correctly;
5352 don't let Qunbound leak into Lisp.
5354 2012-02-07 Glenn Morris <rgm@gnu.org>
5356 * image.c (Fimagemagick_types): Doc fix.
5358 * image.c (imagemagick-render-type): Change it from a lisp object
5359 to an integer. Move the doc here from the lisp manual.
5360 Treat all values not equal to 0 the same.
5362 2012-02-06 Chong Yidong <cyd@gnu.org>
5364 * doc.c (store_function_docstring): Avoid applying docstring of
5365 alias to base function (Bug#2603).
5367 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5369 * .gdbinit (pp1, pv1): Remove redundant defines.
5372 2012-02-04 Chong Yidong <cyd@gnu.org>
5374 * nsterm.m: Declare a global (Bug#10694).
5376 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5378 * w32.c (get_emacs_configuration_options):
5379 Include --enable-checking, if specified, in the return value.
5381 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5383 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5384 after rounding frame sizes. (Bug#9723)
5386 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5388 * keyboard.c (adjust_point_for_property): Don't position point
5389 before BEGV. (Bug#10696)
5391 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5393 Handle overflow when computing char display width (Bug#9496).
5394 * character.c (char_width): Return EMACS_INT, not int.
5395 (char_width, c_string_width): Check for overflow when
5396 computing the width; this is possible now that individual
5397 characters can have unbounded width. Problem introduced
5398 by merge from Emacs 23 on 2012-01-19.
5400 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5402 * dbusbind.c (Fdbus_register_method): Mention the return value
5403 :ignore in the docstring.
5405 2012-02-02 Glenn Morris <rgm@gnu.org>
5407 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5409 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5410 Unconditionally set to t. (Bug#10673)
5411 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5412 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5413 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5415 2012-02-02 Kenichi Handa <handa@m17n.org>
5417 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5418 0, do not call append_composite_glyph.
5420 2012-02-02 Kenichi Handa <handa@m17n.org>
5422 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5424 (x_produce_glyphs): If the component of a composition is a null
5425 string, set it->pixel_width to 1 to avoid zero-width glyph.
5427 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5429 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5430 first 2 arguments are identical. This makes inserting large
5431 output from a subprocess an order of magnitude faster on
5432 MS-Windows, where all sbrk'ed memory is always contiguous.
5434 2012-01-31 Glenn Morris <rgm@gnu.org>
5436 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5437 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5438 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5440 2012-01-29 Glenn Morris <rgm@gnu.org>
5442 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5444 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5446 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5448 2012-01-28 Chong Yidong <cyd@gnu.org>
5450 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5452 2012-01-26 Chong Yidong <cyd@gnu.org>
5454 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5456 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5457 repeat counts (Bug#10507).
5459 2012-01-26 Glenn Morris <rgm@gnu.org>
5461 * lread.c (syms_of_lread): Doc fix.
5463 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5465 * coding.c (encode_designation_at_bol): Change return value to
5468 2012-01-25 Chong Yidong <cyd@gnu.org>
5470 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5472 2012-01-21 Chong Yidong <cyd@gnu.org>
5474 * floatfns.c (Fcopysign): Make the second argument non-optional,
5475 since nil is not allowed anyway.
5477 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5479 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5480 (send_process): Likewise.
5482 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5484 * window.c (save_window_save, Fcurrent_window_configuration)
5485 (Vwindow_persistent_parameters): Do not use Qstate.
5486 Rewrite doc-strings.
5488 2012-01-19 Kenichi Handa <handa@m17n.org>
5490 * character.c (char_width): New function.
5491 (Fchar_width, c_string_width, lisp_string_width):
5492 Use char_width (Bug#9496).
5494 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5496 * window.c (Vwindow_persistent_parameters): New variable.
5497 (Fset_window_configuration, save_window_save): Handle persistent
5500 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5502 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5503 thrashing the stack of the thread. (Bug#9087)
5505 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5507 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5509 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5511 * xdisp.c (rows_from_pos_range): Handle the case where the
5512 highlight ends on a newline. (Bug#10464)
5513 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5514 he end column for display of highlight that ends on a newline
5517 2012-01-11 Glenn Morris <rgm@gnu.org>
5519 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5520 from load-path also when installation-directory is nil. (Bug#10208)
5522 2012-01-10 Glenn Morris <rgm@gnu.org>
5524 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5526 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5527 Update template values to be closer to their typical values these days.
5529 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5531 * xdisp.c (rows_from_pos_range): Accept additional argument
5532 DISP_STRING, and accept any glyph in a row whose object is that
5533 string as eligible for mouse highlight. Fixes mouse highlight of
5534 display strings from overlays. (Bug#10464)
5536 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5538 emacs: fix an auto-save permissions race condition (Bug#10400)
5539 * fileio.c (auto_saving_dir_umask): New static var.
5540 (Fmake_directory_internal): Use it.
5541 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5542 creating the directory. The old code temporarily assigns
5543 too-generous permissions to the directory.
5544 (do_auto_save_eh): Clear it.
5545 (Fdo_auto_save): Catch all errors, not just file errors, so
5546 that the var is always cleared.
5548 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5550 * search.c (scan_buffer): Pass character positions to
5551 know_region_cache, not byte positions. (Bug#6540)
5553 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5555 * w32.c (sys_rename): Report EXDEV when rename of a directory
5556 fails because the target is on another logical disk. (Bug#10284)
5558 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5560 * xterm.c (x_embed_request_focus): New function.
5562 * xterm.h: Add prototype.
5564 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5566 2012-01-05 Glenn Morris <rgm@gnu.org>
5568 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5570 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5572 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5573 Load gnutls_transport_set_lowat only if GnuTLS version is below
5575 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5576 GnuTLS versions below 2.11.1.
5578 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5580 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5581 to the doc string advising against its use for altering the way
5582 windows are scrolled.
5584 2011-12-28 Kenichi Handa <handa@m17n.org>
5586 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5587 coding-system ASCII compatible only when it does not produce BOM
5588 on encoding (Bug#10383).
5590 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5592 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5594 (create_and_show_popup_menu): Always use menu_position_func for
5597 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5599 * callint.c (Fcall_interactively): Don't truncate prompt string.
5601 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5603 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5604 property that ends at ZV, so that the bidi iteration could be
5605 resumed from there (after widening). (Bug#10360)
5607 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5609 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5611 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5613 * nsterm.m (x_free_frame_resources):
5614 Release f->output_data.ns->miniimage.
5615 (ns_index_color): Fix indentation. Do not retain
5616 color_table->colors[i].
5618 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5621 * nsfns.m (x_set_background_color): Assign return value from
5622 ns_index_color to face-background instead of NSColor*.
5623 (ns_implicitly_set_icon_type): Fix indentation.
5624 Change assignment in for loop to comparison.
5626 * emacs.c (ns_pool): New variable.
5627 (main): Assign ns_pool.
5628 (Fkill_emacs): Call ns_release_autorelease_pool.
5630 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5631 autorelease fdesc, release fdAttrs and tdict.
5632 (ns_get_covering_families): Release charset.
5633 (ns_findfonts): Release NSFontDescriptor created with new.
5634 (ns_uni_to_glyphs): Fix indentation.
5635 (setString): Release attrStr before assigning new value.
5637 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5639 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5641 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5642 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5644 2011-12-18 David Reitter <reitter@cmu.edu>
5646 * nsterm.m (ns_term_init): Subscribe for notifications
5647 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5648 to method trackingNotification in EmacsMenu.
5650 * nsmenu.m (trackingMenu): New variable.
5651 (trackingNotification): New method (from Aquamacs).
5652 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5653 from Aquamacs (Bug#7030).
5655 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5657 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5658 (symbol_to_nsstring): Fix indentation.
5659 (ns_symbol_to_pb): New function.
5660 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5661 (Fns_rotate_cut_buffers_internal): Remove.
5662 (Fns_store_selection_internal): Rename from
5663 Fns_store_cut_buffer_internal.
5664 (ns_get_foreign_selection, Fx_own_selection_internal)
5665 (Fx_disown_selection_internal, Fx_selection_exists_p)
5666 (Fns_get_selection_internal, Fns_store_selection_internal):
5667 Use ns_symbol_to_pb and check if return value is nil.
5668 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5669 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5670 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5671 renamed to Sns_store_selection_internal.
5672 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5673 and remove this function.
5674 (ns_handle_selection_clear): Remove, never used.
5675 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5678 2011-12-17 Ken Brown <kbrown@cornell.edu>
5680 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5681 GID is unknown (Bug#10257).
5683 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5685 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5686 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5687 which caused a build failure on GNU/Linux IA-64. This problem was
5688 introduced by my 2011-10-07 patch.
5690 2011-12-15 Juri Linkov <juri@jurta.org>
5692 * image.c (imagemagick_error): New function. (Bug#10112)
5693 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5694 Use `imagemagick_error' where ImageMagick functions return
5696 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5699 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5701 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5702 fill background (Bug#8992).
5704 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5706 * window.c (Vwindow_combination_resize)
5707 (Vwindow_combination_limit): Use t instead of non-nil in
5709 (Vrecenter_redisplay): Add first sentence of doc-string on
5711 (Frecenter): Fix doc-string typo.
5713 2011-12-11 Kenichi Handa <handa@m17n.org>
5715 * coding.c (Funencodable_char_position): Pay attention to the
5716 buffer text relocation (Bug#9389).
5718 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5720 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5721 gtk_init (Bug#10100).
5723 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5725 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5726 IT->string is nil. (Bug#10263)
5728 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5730 * nsterm.h (x_free_frame_resources): Declare.
5732 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5733 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5735 * nsterm.h (ns_get_defaults_value): Declare.
5737 * nsterm.m (ns_default): Call ns_get_defaults_value.
5739 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5741 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5744 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5746 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5747 that where the value of an _OBJC_* symbol points to is in the .bss
5748 section (Bug#10240).
5750 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5752 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5753 after the loop to call ccl_driver at least once (Bug#8619).
5755 2011-12-08 Kenichi Handa <handa@m17n.org>
5757 * ftfont.c (get_adstyle_property): Fix previous change
5760 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5762 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5763 dirs from the default value of EMACSLOADPATH (bug#10208).
5765 2011-12-07 Glenn Morris <rgm@gnu.org>
5767 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5768 installation and source directories as well. (Bug#10208)
5770 2011-12-06 Chong Yidong <cyd@gnu.org>
5772 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5774 2011-12-06 Glenn Morris <rgm@gnu.org>
5776 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5777 as an error, not just -1. (Bug#10217)
5779 2011-12-05 Chong Yidong <cyd@gnu.org>
5781 * keyboard.c (process_special_events): New function.
5782 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5784 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5786 * coding.c (encode_designation_at_bol): Don't use uninitialized
5787 local variable (Bug#9318).
5789 2011-12-05 Kenichi Handa <handa@m17n.org>
5791 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5792 return Qnil (Bug#8046, Bug#10193).
5794 2011-12-05 Kenichi Handa <handa@m17n.org>
5796 * coding.c (encode_designation_at_bol): New args charbuf_end and
5797 dst. Return the number of produced bytes. Callers changed.
5798 (coding_set_source): Return how many bytes coding->source was
5800 (coding_set_destination): Return how many bytes
5801 coding->destination was relocated.
5802 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5803 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5805 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5807 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5808 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5811 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5813 The following changes are to fix Bug#9318.
5815 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5816 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5817 (encode_coding_iso_2022, encode_coding_sjis)
5818 (encode_coding_big5, encode_coding_charset): Use the above macros.
5820 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5822 * lisp.h (process_quit_flag): Fix external declaration.
5824 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5826 Don't macro-inline non-performance-critical code.
5827 * eval.c (process_quit_flag): New function.
5828 * lisp.h (QUIT): Use it.
5830 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5832 * nsfns.m (get_geometry_from_preferences): New function.
5833 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5835 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5837 * emacs.c (Qkill_emacs): Define.
5838 (syms_of_emacs): Initialize it.
5839 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5840 Qquit_flag to `kill-emacs' instead.
5841 (quit_throw_to_read_char): Add parameter `from_signal'.
5842 All callers changed. Call Fkill_emacs if requested and safe.
5843 * lisp.h (QUIT): Call Fkill_emacs if requested.
5845 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5847 * widget.c (update_wm_hints): Return if wmshell is null.
5848 (widget_update_wm_size_hints): New function.
5850 * widget.h (widget_update_wm_size_hints): Declare.
5852 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5853 widget_update_wm_size_hints (Bug#10104).
5855 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5857 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5858 before a newline, prepare the bidi iterator for consuming the
5859 newline, and keep the current paragraph direction. (Bug#10183)
5860 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5862 2011-12-02 Juri Linkov <juri@jurta.org>
5864 * search.c (Fword_search_regexp): New Lisp function created from
5865 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5866 (Fword_search_backward, Fword_search_forward)
5867 (Fword_search_backward_lax, Fword_search_forward_lax):
5868 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5869 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5871 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5873 * fileio.c (Finsert_file_contents): Move after-change-function call
5874 to before the "handled:" label, since all "goto handled" appear in
5875 cases where the *-change-functions have already been properly called
5878 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5880 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5881 waiting for input. (Bug#10169)
5883 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5885 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5886 verifies glyph row's hash code--we have just reallocated the
5887 glyphs, so their contents can be complete garbage. (Bug#10164)
5889 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5891 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5893 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5895 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5896 attributes are tested _before_ calling verify_row_hash, to protect
5897 against GCC re-ordering of the tests. (Bug#10164)
5899 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5901 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5903 * xterm.c (handle_one_xevent): Only set async_visible and friends
5904 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5905 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5906 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5908 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5910 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5911 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5912 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5913 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5914 All uses changed to use GCPRO1 etc.
5915 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5916 Revert to old implementation (i.e., before 2011-03-11).
5918 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5920 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5921 of scroll runs so as to avoid assigning disabled bogus rows and
5922 unnecessary graphics copy operations.
5924 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5926 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5927 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5928 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5929 (malloc, free, realloc, calloc): Redirect to e_* only when
5932 * lisp.h (GCTYPEBITS): Move before first use.
5933 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5934 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5935 this macro definition.
5937 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5940 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5942 * gtkutil.c (xg_create_frame_widgets):
5943 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5944 present with Gtk+ 2.0.
5946 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5948 * fileio.c (Finsert_file_contents): Undo previous change; see
5949 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5951 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5953 Rename locals to avoid shadowing.
5954 * fileio.c (Finsert_file_contents):
5955 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5956 * process.c (wait_reading_process_output):
5957 Rename inner 'proc' to 'p' to avoid shadowing.
5958 Indent for consistency with usual Emacs style.
5960 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5962 * xdisp.c (redisplay_window): If cursor row is not fully visible
5963 after recentering, and scroll-conservatively is set to a large
5964 number, scroll window by a few more lines to make the cursor fully
5965 visible and out of scroll-margin. (Bug#10105)
5966 (start_display): Don't move to the next line if the display should
5967 start at a newline that is part of a display vector or an overlay
5970 2011-11-24 Juri Linkov <juri@jurta.org>
5972 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5973 after the `MagickPingImage' call. (Bug#10112)
5975 2011-11-23 Chong Yidong <cyd@gnu.org>
5977 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5979 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5981 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5982 making another buffer current. (Bug#10114)
5984 2011-11-23 Glenn Morris <rgm@gnu.org>
5986 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5988 2011-11-23 Chong Yidong <cyd@gnu.org>
5990 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5991 using it (Bug#5984).
5993 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5995 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5996 and header-lines, as they don't have one computed for them.
5999 * .gdbinit (prow): Make displayed values more self-explaining.
6000 Add row's hash code.
6002 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6004 * process.c (wait_reading_process_output): Fix asynchrounous
6005 GnuTLS socket handling on some versions of the GnuTLS library.
6006 (wait_reading_process_output): Add comment and URL.
6008 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6010 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6012 2011-11-21 Chong Yidong <cyd@gnu.org>
6014 * window.c (Fnext_window, Fprevious_window): Doc fix.
6016 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6018 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6020 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6022 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6024 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6026 * window.c (Fset_window_combination_limit): Rename argument
6028 (Vwindow_combination_limit): Remove "status" from doc-string.
6030 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6032 * m/ibms390.h: Remove.
6033 * m/ibms390x.h: Don't include "ibms390.h".
6035 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6037 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6038 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6040 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6042 * casetab.c (Fset_case_table):
6043 * charset.c (Fcharset_after): Fix typos.
6045 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6047 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6048 Otherwise, valgrind does not work on some platforms.
6049 Problem reported by Andreas Schwab in
6050 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6051 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6052 is set, removing the need for VIRT_ADDRESS_VARIES.
6053 (PURE_P): Use a more-efficient implementation that needs just one
6054 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6055 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6056 to 4 (xorl, subq, cmpq, setbe).
6057 * alloc.c (pure): Always extern now, since that's the
6058 VIRT_ADDR_VARIES behavior.
6059 (PURE_POINTER_P): Use a single comparison, not two, for
6060 consistency with the new puresize.h.
6061 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6062 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6063 Remove VIRT_ADDR_VARIES no longer needed.
6065 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6067 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6068 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6069 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6070 behave as if the cursor position were at the window margin.
6072 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6073 and the cursor position is out of bounds, behave as if the cursor
6074 position were at the window margin. (Bug#10075)
6076 2011-11-18 Chong Yidong <cyd@gnu.org>
6078 * window.c (Fwindow_combination_limit): Make first argument
6079 non-optional, since it is meaningless for live windows like the
6082 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6084 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6086 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6088 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6089 (graft_intervals_into_buffer): Simplify.
6091 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6093 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6094 hash values of the two rows.
6095 (copy_row_except_pointers): Preserve the used[] arrays and the
6096 hash values of the two rows. (Bug#10035)
6097 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6099 * xdisp.c (row_hash): New function, body extracted from
6100 compute_line_metrics.
6101 (compute_line_metrics): Call row_hash, instead of computing the
6104 * dispnew.c (verify_row_hash): Call row_hash for computing the
6105 hash code of a row, instead of duplicating code from xdisp.c.
6107 * dispextern.h (row_hash): Add prototype.
6109 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6111 * frame.c (delete_frame): Don't delete the terminal when the last
6112 X frame is closed if emacs is built with GTK toolkit.
6114 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6116 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6118 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6120 * window.c (Vwindow_splits): Rename to
6121 Vwindow_combination_resize. Suggested by Juri Linkov.
6122 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6125 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6127 * nsfns.m (Fns_font_name):
6128 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6130 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6132 * window.h (window): Rename slot "nest" to "combination_limit".
6133 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6134 (Fset_window_nest): Rename to Fset_window_combination_limit.
6135 (Vwindow_nest): Rename to Vwindow_combination_limit.
6136 (recombine_windows, make_parent_window, make_window)
6137 (Fsplit_window_internal, saved_window)
6138 (Fset_window_configuration, save_window_save): Rename all
6139 occurrences of window_nest to window_combination_limit.
6141 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6143 * image.c (imagemagick_load_image): Fix typo.
6145 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6147 * xdisp.c (display_line): Move the call to
6148 highlight_trailing_whitespace before the call to
6149 compute_line_metrics, since the latter needs to see the final
6150 faces of all the glyphs to compute ROW's hash value.
6151 Fixes assertion violations in row_equal_p. (Bug#10035)
6153 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6155 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6156 just return (bug#10044).
6158 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6160 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6161 with user-defined heap size. Bump the default size of the temacs
6162 heap to 27MB, to avoid memory warning when running temacs.
6163 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6165 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6166 current_matrix and desired_matrix. (Bug#9990)
6167 (verify_row_hash) [XASSERTS]: New function.
6168 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6169 that the hash value of glyph rows is correct.
6171 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6173 * window.h (window): Remove splits slot.
6174 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6175 (Fdelete_other_windows_internal, make_parent_window)
6176 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6177 (Fset_window_configuration, save_window_save): Don't deal with
6178 split status of windows.
6179 (saved_window): Remove splits slot.
6180 (Vwindow_splits): Rewrite doc-string.
6182 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6184 * xfns.c (unwind_create_frame):
6185 * nsfns.m (unwind_create_frame):
6186 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6187 Vframe_list (Bug#9999).
6189 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6191 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6193 2011-11-11 Kenichi Handa <handa@m17n.org>
6195 * callproc.c (Fcall_process): Set the member dst_multibyte of
6198 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6200 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6201 avoid a crash (bug#9496).
6203 2011-11-09 Chong Yidong <cyd@gnu.org>
6205 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6206 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6208 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6210 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6212 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6214 Avoid some portability problems by eschewing 'extern inline' functions.
6215 The trivial performance wins aren't worth the portability hassles; see
6216 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6218 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6219 (window_box_width, window_box_left, window_box_left_offset)
6220 (window_box_right, window_box_right_offset): Undo previous change,
6221 by removing the "extern"s.
6222 * intervals.c (adjust_intervals_for_insertion)
6223 (adjust_intervals_for_deletion): Undo previous change,
6224 making these static again.
6225 (offset_intervals, temp_set_point_both, temp_set_point)
6226 (copy_intervals_to_string): No longer inline.
6227 * xdisp.c (window_text_bottom_y, window_box_width)
6228 (window_box_height, window_box_left_offset)
6229 (window_box_right_offset, window_box_left, window_box_right)
6230 (window_box): No longer inline.
6232 2011-11-08 Chong Yidong <cyd@gnu.org>
6234 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6235 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6236 Signal an error if not a live window.
6237 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6238 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6240 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6242 * lisp.h (syms_of_abbrev): Remove declaration.
6243 Reported by CHENG Gao <chenggao@royau.me>.
6245 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6247 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6248 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6249 of temacs in GUI mode.
6251 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6253 * window.h: Declare delete_all_child_windows instead of
6254 delete_all_subwindows.
6255 * window.c (Fwindow_nest, Fset_window_nest)
6256 (Fset_window_new_total, Fset_window_new_normal)
6257 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6258 (delete_all_subwindows): Rename to delete_all_child_windows.
6259 (Fdelete_other_windows_internal, Fset_window_configuration):
6260 Call delete_all_child_windows instead of delete_all_subwindows.
6261 * frame.c (delete_frame): Call delete_all_child_windows instead
6262 of delete_all_subwindows.
6264 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6266 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6267 This is also needed for porting to any host where GC_MARK_STACK is
6268 not GC_MAKE_GCPROS_NOOPS.
6269 (which_symbols): Use it.
6271 2011-11-07 Kenichi Handa <handa@m17n.org>
6273 * coding.c (coding_set_destination): Check coding->src_pos only
6274 when coding->src_object is a buffer (bug#9910).
6276 * process.c (send_process): Set the member src_multibyte of coding
6277 to 0 (bug#9911) when sending a unibyte text.
6279 * callproc.c (Fcall_process): Set the member src_multibyte of
6280 process_coding to 0 (bug#9912).
6282 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6284 * xmenu.c (cleanup_widget_value_tree): New function.
6285 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6286 calling free_menubar_widget_value_tree directly (Bug#9830).
6288 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6290 Fix some portability problems with 'inline'.
6291 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6292 (window_box_width, window_box_left, window_box_left_offset)
6293 (window_box_right, window_box_right_offset): Declare extern.
6294 Otherwise, these inline functions do not conform to C99 and
6295 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6296 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6297 * intervals.c (adjust_intervals_for_insertion)
6298 (adjust_intervals_for_deletion): Now extern, because otherwise the
6299 extern inline functions 'offset_intervals' couldn't refer to it.
6300 (static_offset_intervals): Remove.
6301 (offset_intervals): Rewrite using the old contents of
6302 static_offset_intervals. The old version didn't conform to C99
6303 because an extern inline function contained a reference to an
6304 identifier with static linkage.
6306 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6308 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6311 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6313 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6314 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6315 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6316 return Qleft_to_right.
6318 2011-11-06 Chong Yidong <cyd@gnu.org>
6320 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6321 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6322 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6323 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6324 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6325 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6326 (Fwindow_vscroll): Doc fix.
6327 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6328 argument, since it makes no sense to pass a live window and for
6329 consistency with window-child.
6331 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6333 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6336 2011-11-05 Jason Rumney <jasonr@gnu.org>
6338 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6339 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6341 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6342 bitwise arithmetic preventing use of unicode-sip and non-truetype
6345 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6347 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6350 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6351 initialization code to keep similarity to xfns.c after changes
6354 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6356 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6357 (unwind_create_frame): New function (Bug#9943).
6358 (Fx_create_frame): Restructure code to be more similar to the one in
6359 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6360 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6361 Move terminal->reference_count++ just before making the frame official
6364 * nsterm.m (x_free_frame_resources): New function.
6365 (x_destroy_window): Move code to x_free_frame_resources.
6367 * xfns.c (unwind_create_frame): Fix comment.
6368 (Fx_create_frame, x_create_tip_frame):
6369 Move terminal->reference_count++ just before making the frame
6370 official. Move initialization of image_cache_refcount and
6371 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6373 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6375 Support MSVC build with newer versions of Visual Studio.
6376 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6377 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6380 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6381 which are not supported by MSVC.
6382 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6383 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6385 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6387 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6389 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6391 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6393 Support MSVC build with newer versions of Visual Studio.
6394 * w32.c: Don't include w32api.h for MSVC.
6395 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6397 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6398 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6399 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6400 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6402 (alloca) [_MSC_VER]: Define to _alloca.
6404 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6406 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6408 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6410 * xdisp.c (note_mouse_highlight): If either of
6411 previous/next-single-property-change returns nil, treat that as
6412 the beginning or the end of the buffer. (Bug#9955)
6414 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6416 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6417 label is not null (Bug#9951).
6418 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6421 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6423 * window.c (Fwindow_body_size): Mention in the doc string that the
6424 return value is in frame's canonical units. (Bug#9949)
6426 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6428 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6430 * w32fns.c (unwind_create_frame): If needed, free the glyph
6431 matrices of the partially constructed frame. (Bug#9943)
6432 * xfns.c (unwind_create_frame): Likewise.
6434 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6436 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6437 Don't stop backward scan on the continuation glyph, even though
6438 its CHARPOS is positive.
6439 (mouse_face_from_buffer_pos, note_mouse_highlight):
6440 Rename cover_string to disp_string.
6442 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6444 * window.c (temp_output_buffer_show): Don't use
6445 Vtemp_buffer_show_specifiers.
6446 (Vtemp_buffer_show_specifiers): Remove unused variable.
6448 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6450 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6451 past the beginning of the current glyph matrix.
6453 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6455 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6456 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6457 HAVE_GTK3 (Bug#9869).
6459 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6460 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6462 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6464 * xterm.c: Declare x_handle_net_wm_state to return int.
6465 (handle_one_xevent): Check if we are iconified but don't have
6466 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6467 (get_current_wm_state): Return non-zero if not hidden,
6468 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6469 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6470 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6471 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6473 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6475 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6476 so that this new function doesn't get optimized away by a
6477 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6479 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6481 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6483 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6485 Fix the `xbytecode' command.
6486 * .gdbinit (xprintbytestr): New command.
6487 (xwhichsymbols): Rename from `which'; all callers changed.
6488 (xbytecode): Print the byte-code string as well.
6490 2011-10-29 Kim Storm <storm@cua.dk>
6492 * alloc.c (which_symbols): New function.
6494 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6496 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6499 2011-10-29 Glenn Morris <rgm@gnu.org>
6501 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6502 Not clear what it was for, and it causes various bugs. (Bug#9839)
6504 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6506 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6507 possible random value that matches one of those tested as
6508 condition to clear the mouse face.
6510 2011-10-28 Chong Yidong <cyd@gnu.org>
6512 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6514 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6516 * window.c (make_window): Initialize phys_cursor_on_p.
6518 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6520 * lisp.h (struct Lisp_Symbol): Update comments.
6522 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6524 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6526 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6528 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6529 <oslsachem@gmail.com> for helping to debug this.
6531 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6532 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6533 (g_b_init_get_glyph_outline_w): New static variables.
6534 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6535 (GetGlyphOutlineW_Proc): New typedefs.
6536 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6537 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6539 (w32font_open_internal, compute_metrics):
6540 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6541 instead of calling the "wide" APIs directly.
6543 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6545 * w32.h (syms_of_w32font): Add prototype.
6547 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6549 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6550 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6551 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6552 (Fmove_to_window_line): Doc fix.
6554 2011-10-27 Chong Yidong <cyd@gnu.org>
6556 * process.c (make_process): Set gnutls_state to NULL.
6558 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6559 non-NULL, regardless of GNUTLS_INITSTAGE.
6560 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6561 an error. Set process slots as soon as we allocate them.
6563 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6565 2011-10-27 Chong Yidong <cyd@gnu.org>
6567 * gnutls.c (emacs_gnutls_deinit): New function.
6568 Deallocate credentials structures as well as calling gnutls_deinit.
6569 (Fgnutls_deinit, Fgnutls_boot): Use it.
6571 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6572 (deactivate_process): Call emacs_gnutls_deinit.
6574 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6576 * image.c (x_create_x_image_and_pixmap):
6577 * w32.c (sys_rename, w32_delayed_load):
6578 * w32font.c (fill_in_logfont):
6579 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6581 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6583 * w32fns.c (w32_default_color_map): New function,
6584 extracted from Fw32_default_color_map.
6585 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6587 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6589 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6591 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6593 * keyboard.c (test_undefined): New function (bug#9751).
6594 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6596 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6598 * sysdep.c (init_sys_modes): Fix the check for the controlling
6599 terminal (Bug#6649).
6601 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6603 * dispextern.h (struct bidi_it): New member next_en_type.
6605 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6606 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6607 current character, check also for next_en_type being WEAK_EN.
6608 (bidi_resolve_weak): Don't enter the expensive loop if the current
6609 position is before next_en_pos. Record the bidi type of the first
6610 non-ET, non-BN character we find, in addition to its position.
6611 (bidi_level_of_next_char): Invalidate next_en_type when
6612 next_en_pos is over-stepped.
6614 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6616 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6617 * editfns.c: Rewrite current-time-zone so that it invokes
6618 the equivalent of (format-time-string "%Z") to get the time zone name.
6619 This fixes a bug when the time zone name contains characters that
6620 need converting from the system time locale to Emacs internal format.
6621 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6622 that patch fixed format-time-string to do the conversion, but
6623 I forgot to fix current-time-zone.
6624 (format_time_string): New function, containing most of
6625 what Fformat_time_string used to contain.
6626 (Fformat_time_string): Rewrite in terms of format_time_string.
6627 This doesn't change this function's behavior.
6628 (current-time-zone): Rewrite to use format_time_string.
6629 This fixes the bug reported by Michael Schierl in
6630 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6631 Jason Rumney's 2007-06-07 change worked around this bug, but
6633 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6635 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6637 * xdisp.c (start_display): If the character at POS is displayed
6638 via a display vector, reset IT->current.dpvec_index to zero.
6639 (try_window_reusing_current_matrix): If a line ends in a display
6640 vector or the next line starts in a display vector, continue
6641 redrawing the window even though the character position of
6642 start_row was reached.
6645 2011-10-18 Chong Yidong <cyd@gnu.org>
6647 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6648 with nobreak-char-display too.
6650 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6652 Fix part 3 of bug#9771.
6653 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6654 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6655 non-neutral characters if the current character is a paragraph
6656 separator (a.k.a. Newline). This avoids running the same
6657 expensive loop twice, once when we consume the preceding newline
6658 and the other time when the line actually needs to be displayed.
6659 Avoid the loop when we see neutrals on the base embedding level
6660 following a character whose directionality is the same as the
6661 paragraph's. This avoids running the expensive loop when a line
6662 ends in a long sequence of neutrals, like control characters.
6663 Add assertion against STRONG_AL type. Slightly rearrange code
6664 that determines the type of a neutral given the first non-neutral
6666 (bidi_level_of_next_char): Set next_en_pos to zero when
6667 invalidating its info.
6669 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6671 * xdisp.c (push_display_prop): Determine whether to record string
6672 or buffer position by IT->string, not by IT->method. Allow
6673 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6674 (move_it_vertically_backward): Don't look for character position
6675 immediately after the newline when in a continuation line.
6678 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6680 * window.c (coordinates_in_window): Rewrite and delabelize
6681 vertical border check. (Bug#5357) (Bug#9618)
6683 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6685 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6686 errors in XSetWindowBorder (bug#9310).
6688 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6690 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6691 avoid crash when xmalloc overrun checking is enabled.
6693 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6695 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6696 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6697 cursor motion with <left> and <right> arrow keys.
6699 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6700 some callers set that themselves.
6702 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6704 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6705 display string and the previous row comes from the same string and
6706 is empty. (Bug#9739) (Bug#9738)
6708 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6710 * doc.c (get_doc_string): Encode file name (bug#9735).
6712 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6714 * bidi.c (bidi_level_of_next_char):
6715 * xdisp.c (get_visually_first_element): Remove old incorrect
6716 comments regarding the Unicode Line Separator character.
6718 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6720 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6722 * alloc.c (Fgc_status): Do not access beyond zombies array
6723 boundary if nzombies > MAX_ZOMBIES.
6724 * alloc.c (dump_zombies): Add missing format specifier.
6726 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6728 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6729 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6731 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6732 Some packages use them to denote characters with modifiers.
6734 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6736 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6737 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6738 matching a pp-number. Rename parameter var to var1.
6740 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6742 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6744 2011-10-08 Glenn Morris <rgm@gnu.org>
6746 * callint.c (Fcall_interactively): Give a more explicit error for the
6747 'c' case with a non-character input. (Bug#8479)
6749 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6751 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6753 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6754 lines that are hscrolled on the left.
6756 * dispnew.c (buffer_posn_from_coords): Account for a possible
6757 presence of header-line. (Bug#4426)
6759 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6761 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6762 Don't advertise functionality which we discourage or doesn't work.
6764 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6766 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6767 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6768 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6769 this makes Emacs dump core during garbage collection on rare
6770 occasions. sizeof is obviously inferior to offsetof here, so
6771 stick with offsetof.
6772 (GC_POINTER_ALIGNMENT): New macro.
6773 (mark_memory): Omit 3rd (offset) arg; caller changed.
6774 Don't assume EMACS_INT alignment is the same as pointer alignment.
6776 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6778 * keyboard.c (read_key_sequence_remapped): New var.
6779 (read_key_sequence): Compute remapping in the right buffer.
6780 (command_loop_1): Use read_key_sequence's remapping directly.
6782 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6784 * dired.c (file_name_completion): Don't expand file name.
6785 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6786 before checking file name handler.
6788 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6789 they've been requested explicitly (bug#9591).
6791 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6793 * keymap.c (Fsingle_key_description): Use make_specified_string
6794 instead of build_string to build string from push_key_description.
6797 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6799 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6800 This fixes a Y2038 bug on 64-bit hosts.
6801 * buffer.c (reset_buffer):
6802 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6803 (Fclear_buffer_auto_save_failure):
6804 Use 0, not -1, to represent an unset failure time, since time_t
6805 might not be signed.
6807 Remove dependency on glibc malloc internals.
6808 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6809 Move back here from lisp.h, but with their new implementations.
6810 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6811 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6812 * charset.c (charset_table_init): New static var.
6813 (syms_of_charset): Use it instead of xmalloc. This removes a
6814 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6815 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6816 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6817 Move back to alloc.c.
6818 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6819 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6821 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6823 * nsterm.m (windowDidResize): Call x_set_window_size only when
6824 ns_in_resize is true. Otherwise set pixelwidth/height and
6825 call change_frame_size (Bug#9628).
6827 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6829 Port --enable-checking=all to Fedora 14 x86-64.
6830 * charset.c (syms_of_charset): Also account for glibc malloc's
6831 internal overhead when calculating the initial malloc maximum.
6833 Port --enable-checking=all to Fedora 14 x86.
6834 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6836 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6837 (overrun_check_realloc, overrun_check_free):
6838 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6839 That way, xmalloc returns a properly-aligned pointer even if
6840 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6841 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6842 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6843 into account when calculating the initial malloc maximum.
6844 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6845 Move here from alloc.c, so that charset.c can use it too.
6846 Properly align; the old code wasn't right for common 32-bit hosts
6847 when configured with --enable-checking=all.
6848 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6849 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6851 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6853 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6856 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6858 * xdisp.c (compute_display_string_end): If there's no display
6859 string at CHARPOS, return -1.
6861 * bidi.c (bidi_fetch_char): When compute_display_string_end
6862 returns a negative value, treat the character as a normal
6863 character not covered by a display string. (Bug#9624)
6865 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6867 * lread.c (Fread_from_string): Fix typo in docstring.
6869 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6871 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6872 newline, reseat the iterator instead of bidi-iterating there one
6873 character at a time. (Bug#9610)
6874 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6875 TO_CHARPOS if the bidi iterator is at base embedding level.
6877 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6879 * lread.c (readevalloop): Use correct code for NBSP.
6880 (read1): Likewise. (Bug#9608)
6882 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6884 * dbusbind.c (Fdbus_register_signal): When service is not
6885 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6887 2011-09-25 Glenn Morris <rgm@gnu.org>
6889 * buffer.c (truncate-lines): Doc fix.
6891 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6893 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6894 (Fset_window_next_buffers): Doc fix.
6896 2011-09-24 Glenn Morris <rgm@gnu.org>
6898 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6900 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6902 Fix minor problems found by static checking.
6903 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6904 * indent.c (Fvertical_motion): Fix == vs = typo.
6906 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6908 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6909 Default value is now t. Doc fix.
6911 * indent.c (Fvertical_motion): Compute and apply the overshoot
6912 logic when moving up, not only when moving down. Fix the
6913 confusing name and values of the it_overshoot_expected variable;
6914 logic changes accordingly. (Bug#9254) (Bug#9549)
6916 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6917 CHARPOS is covered by a display string which includes newlines.
6918 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6919 is covered by a display string with embedded newlines.
6921 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6923 * dbusbind.c (Fdbus_register_signal): Add match rule to
6924 Vdbus_registered_objects_table. (Bug#9581)
6925 (Fdbus_register_method, Vdbus_registered_objects_table):
6928 2011-09-24 Jim Meyering <meyering@redhat.com>
6930 do not ignore write error for any output size
6931 The previous change was incomplete.
6932 While it makes emacs --batch detect the vast majority of stdout
6933 write failures, errors were still ignored whenever the output size is
6934 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6935 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6936 && echo FAIL: ignored write error
6937 FAIL: ignored write error
6938 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6939 && echo FAIL: ignored write error
6940 FAIL: ignored write error
6941 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6943 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6945 * emacs.c (Fkill_emacs): In noninteractive mode exit
6946 non-successfully if a write error occurred on stdout. (Bug#9574)
6948 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6950 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6953 * dispextern.h (struct it): Update the comment documenting what
6956 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6958 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6959 a display string, extend search for cursor position to end of row.
6960 (find_row_edges): If the row ends in a newline from a display
6961 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6962 Handle the case of a display string with multiple newlines.
6963 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6964 non-empty line. Fixes confusing cursor motion with arrow keys at
6965 the beginning of a line that starts with whitespace.
6967 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6969 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6972 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6974 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6977 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6979 * xdisp.c (display_line): Record maximum and minimum buffer
6980 positions even if no glyphs were produced (e.g., by a zero-width
6981 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6982 buffer positions that will be removed from the glyph row because
6984 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6985 column is beyond frame width: don't subtract 1 "pixel" when
6986 computing width of the stretch.
6987 (reseat_at_next_visible_line_start): Undo the change made on
6988 2011-09-17 that saved paragraph information and restored it after
6989 the call to `reseat'. (Bug#9545)
6991 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6993 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6994 and turn window cursor on if cleared (Bug#9415).
6996 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6998 * search.c (boyer_moore): Take unibyte characters from pattern
6999 literally. (Bug#9458)
7001 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7003 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7005 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7007 Fix minor problem found by static checking.
7008 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7009 initialized, to pacify gcc -Wuninitialized.
7011 * fileio.c: Report proper errno when syscall falls.
7012 (Finsert_file_contents): Save and restore errno,
7013 so that report_file_error outputs the correct diagnostic.
7014 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7016 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7018 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7020 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7022 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7023 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7025 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7027 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7028 about the current paragraph and restore it after the call to reseat.
7030 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7031 (bidi_find_paragraph_start): Search back for paragraph beginning
7032 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7033 (bidi_move_to_visually_next): Only trigger paragraph-related
7034 computations when the last character is a newline or at EOB, not
7035 just any NEUTRAL_B. (Bug#9470)
7037 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7038 truncated lines if point is covered by a display string. (Bug#9524)
7040 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7042 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7043 (cons_to_x_long): New function.
7044 (lisp_data_to_selection_data): Use it. Correct the test for
7045 short-versus-long data; it was negated. Break out of vector
7046 loop, for efficiency, when a long datum is discovered.
7048 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7050 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7052 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7054 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7055 GCC PR/17406) by declaring this function with external scope.
7057 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7059 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7060 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7062 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7064 * editfns.c (Fformat): Correctly handle text properties on "%%".
7066 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7068 * xterm.c (x_draw_composite_glyph_string_foreground):
7069 * w32term.c (x_draw_composite_glyph_string_foreground):
7070 * term.c (encode_terminal_code):
7071 * composite.c (composition_update_it, get_composition_id):
7072 * xdisp.c (get_next_display_element)
7073 (fill_composite_glyph_string): Add comments about special meaning
7074 of TAB characters in a composition.
7076 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7078 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7079 This occurs when processing a multibyte format.
7080 Problem reported by Wolfgang Jenker.
7082 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7084 * xdisp.c (try_cursor_movement): Only check for exact match if
7085 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7087 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7089 Remove unused external symbols.
7090 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7091 * xdisp.c (calc_pixel_width_or_height): Now static.
7092 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7093 * indent.c (check_display_width):
7094 * w32term.c: Fix comment to match code.
7095 * xterm.c, xterm.h (x_catching_errors): Remove.
7097 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7099 * xselect.c: Use signed conversions more consistently (Bug#9498).
7100 (selection_data_to_lisp_data): Assume incoming selection data are
7101 signed integers, not unsigned. This is to be consistent with
7102 outgoing selection data, which was modified to use signed integers
7103 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7104 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7105 expects long, not unsigned long.
7107 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7109 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7110 computation of loop end. Reported by Johan Bockgård
7113 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7115 * frame.c (Fother_visible_frames_p): Function deleted.
7117 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7119 * indent.c (compute_motion): Process display vector front to back
7120 rather than the other way around. (Bug#2496)
7122 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7124 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7126 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7128 * minibuf.c (Fread_from_minibuffer): Doc fix.
7130 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7132 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7133 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7135 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7137 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7138 value for non-existent files.
7140 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7142 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7143 set its "size" to -1. This will set the modtime_size field of
7144 the corresponding buffer to -1, which is what
7145 verify-visited-file-modtime expects for files that do not exist.
7148 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7150 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7152 * lisp.h: ... from here. push_key_description is no longer
7153 defined in keyboard.c, so its declaration should not be in
7154 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7155 logically belongs with push_key_description.
7157 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7159 * buffer.h: Include <sys/types.h> instead of <time.h>.
7160 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7161 Problem reported by Herbert J. Skuhra.
7163 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7165 * xml.c (parse_region): Make the parsing work for
7166 non-comment-starting XML files again (bug#9144).
7168 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7170 * image.c (gif_load): Fix calculation of bottom and right corner.
7173 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7175 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7176 redisplay in small windows.
7178 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7180 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7182 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7184 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7185 Operate on live windows only.
7187 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7189 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7191 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7193 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7194 only under bidi iteration.
7196 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7198 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7200 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7202 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7203 Without this fix, the command to link temacs failed due to an
7204 undefined symbol __builtin_isnan. This is because
7205 /usr/include/iso/math_c99.h #defines isnan(x) to
7206 __builtin_isnan(x), but the bundled gcc, which identifies itself
7207 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7209 * floatfns.c (isnan): #undef, and then #define to a clone of
7211 (Fisnan): Always define, since it's always available now.
7212 (syms_of_floatfns): Always define isnan at the Lisp level.
7214 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7216 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7218 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7220 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7221 The previous code assumed that file offsets (off_t values) fit in
7222 EMACS_INT variables, which is not true on typical 32-bit hosts.
7223 The code messed up by falsely reporting buffer overflow in cases
7224 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7225 when "big" contains more than 2**29 bytes, even though this
7226 inserts just one byte and does not overflow the buffer.
7227 (Finsert_file_contents): Store file offsets as off_t
7228 values, not as EMACS_INT values. Check for overflow when
7229 converting between EMACS_INT and off_t. When checking for
7230 buffer overflow or for overlap, take the offsets into account.
7231 Don't use EMACS_INT for small values where int suffices.
7232 When checking for overlap, fix a typo: ZV was used where
7233 ZV_BYTE was intended.
7234 (Fwrite_region): Don't assume off_t fits into 'long'.
7235 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7237 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7239 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7241 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7243 sprintf-related integer and memory overflow issues (Bug#9412).
7245 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7246 (esprintf, exprintf, evxprintf): New functions.
7247 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7248 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7249 (modify_event_symbol): Do not assume that the length of
7250 name_alist_or_stem is safe to alloca and fits in int.
7251 (Fexecute_extended_command): Likewise for function name and binding.
7252 (Frecursion_depth): Wrap around reliably on integer overflow.
7253 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7254 since some callers pass EMACS_INT values.
7255 (Fsingle_key_description): Don't crash if symbol name contains more
7256 than MAX_ALLOCA bytes.
7257 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7258 (get_minibuffer): Arg is now EMACS_INT, not int.
7259 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7260 (esprintf, exprintf, evxprintf): New decls.
7261 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7263 * dbusbind.c (signature_cat): New function.
7264 (xd_signature, Fdbus_register_signal):
7265 Do not overrun buffer; instead, report string overflow.
7267 * dispnew.c (add_window_display_history): Don't overrun buffer.
7268 Truncate instead; this is OK since it's just a log.
7270 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7271 even if the time zone offset is outlandishly large.
7272 Don't mishandle offset == INT_MIN.
7274 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7275 when creating daemon; the previous buffer-overflow check was incorrect.
7277 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7278 which has the guts of the old verror function.
7280 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7281 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7283 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7284 (font_unparse_xlfd): Don't blindly alloca long strings.
7285 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7286 fits in int, when using sprintf. Use single snprintf to count
7287 length of string rather than counting it via multiple sprintfs;
7288 that's simpler and more reliable.
7289 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7290 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7291 sprintf, in case result does not fit in int.
7293 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7294 (fontset_from_font): Print it.
7296 * frame.c (tty_frame_count): Now printmax_t, not int.
7297 (make_terminal_frame, set_term_frame_name): Print it.
7298 (x_report_frame_params): In X, window IDs are unsigned long,
7299 not signed long, so print them as unsigned.
7300 (validate_x_resource_name): Check for implausibly long names,
7301 and don't assume name length fits in 'int'.
7302 (x_get_resource_string): Don't blindly alloca invocation name;
7303 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7306 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7307 (xg_check_special_colors, xg_set_geometry):
7308 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7310 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7311 Use esprintf, not sprintf, in case result does not fit in int.
7313 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7314 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7315 it as a large positive number.
7316 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7317 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7319 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7320 in case result does not fit in int.
7322 * print.c (float_to_string): Detect width overflow more reliably.
7323 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7324 buffer overrun. Don't assume list length fits in 'int'. Treat
7325 print length of 0 as 0, not as infinity; to be consistent with other
7326 uses of print length in this function. Don't overflow print length
7327 index. Don't assume hash table size fits in 'long', or that
7328 vectorlike size fits in 'unsigned long'.
7330 * process.c (make_process): Use printmax_t, not int, to format
7331 process-name gensyms.
7333 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7335 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7336 to avoid potential buffer overrun.
7338 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7339 if X resource line is longer than 512 bytes.
7341 * xfns.c (x_window): Make sprintf buffer a bit bigger
7342 to avoid potential buffer overrun.
7344 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7346 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7348 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7350 Integer overflow fixes for scrolling, etc.
7351 Without these, Emacs silently mishandles large integers sometimes.
7352 For example, "C-u 4294967297 M-x recenter" was treated as if
7353 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7355 * xdisp.c (try_window_id): Check Emacs fixnum range before
7356 converting to 'int'.
7358 * window.c (window_scroll_line_based, Frecenter):
7359 Check that an Emacs fixnum is in range before assigning it to 'int'.
7360 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7361 values converted from Emacs fixnums.
7362 (Frecenter): Don't wrap around a line count if it is out of 'int'
7363 range; instead, treat it as an extreme value.
7364 (Fset_window_configuration, compare_window_configurations):
7365 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7367 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7368 that can exceed INT_MAX. Check that EMACS_INT value is in range
7369 before assigning it to the (possibly-narrower) index.
7370 (match_limit): Don't assume that a fixnum can fit in 'int'.
7372 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7375 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7376 (Fvertical_motion): Don't wrap around LINES values that don't fit
7377 in 'int'. Instead, treat them as extreme values. This is good
7378 enough for windows, which can't have more than INT_MAX lines anyway.
7380 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7382 * Require libxml/parser.h to avoid compilation warning.
7384 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7386 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7387 since this reportedly can destroy thread storage.
7389 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7391 * syntax.c (find_defun_start): Update all cache variables if
7392 exiting early (Bug#9401).
7394 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7396 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7398 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7399 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7400 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7402 * term.c (tty_append_glyph): New function.
7403 (produce_stretch_glyph): Static function and its prototype deleted.
7405 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7408 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7410 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7411 when checking :margin (Bug#9390).
7412 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7413 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7414 so that the name doesn't mislead. All uses changed.
7416 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7418 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7421 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7423 * xdisp.c (move_it_to): Don't bail out early when reaching
7424 position beyond to_charpos, if we are scanning backwards.
7425 (move_it_vertically_backward): When DY == 0, make sure we get to
7426 the first character in the line after the newline.
7428 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7430 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7431 (ccl_driver): Do not generate an out-of-range pointer.
7432 (Fccl_execute_on_string): Remove unnecessary check for
7433 integer overflow, noted by Stefan Monnier in
7434 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7435 Remove a FIXME that didn't need fixing.
7436 Simplify the newly-introduced buffer reallocation code.
7438 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7440 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7442 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7444 Integer and memory overflow issues (Bug#9196).
7446 * doc.c (get_doc_string): Rework so that
7447 get_doc_string_buffer_size is the actual buffer size, rather than
7448 being 1 less than the actual buffer size; this makes xpalloc more
7451 * image.c (x_allocate_bitmap_record, cache_image):
7452 * xselect.c (Fx_register_dnd_atom):
7453 Simplify previous changes by using xpalloc.
7455 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7456 since either will do and ptrdiff_t is convenient with xpalloc.
7458 * charset.c (charset_table_size)
7459 (struct charset_sort_data.priority): Now ptrdiff_t.
7460 (charset_compare): Don't overflow if priorities differ greatly.
7461 (Fsort_charsets): Don't assume list length fits in int.
7462 Check for size-calculation overflow when allocating sort data.
7463 (syms_of_charset): Allocate an initial charset table that is
7464 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7466 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7468 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7469 The actual value is always <= INT_MAX, and leaving it unsigned made
7470 overflow checking harder.
7472 * dispextern.h (struct glyph_matrix.rows_allocated)
7473 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7474 with xpalloc. The values are still always <= INT_MAX.
7476 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7478 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7479 (SAFE_NALLOCA): New macro.
7481 * region-cache.c (struct boundary.pos, find_cache_boundary)
7482 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7483 (set_cache_region, invalidate_region_cache)
7484 (revalidate_region_cache, know_region_cache, region_cache_forward)
7485 (region_cache_backward, pp_cache):
7486 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7487 so that ptrdiff_t * can be passed to xpalloc.
7488 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7489 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7490 (pp_cache): Don't assume cache_len fits in int.
7491 * region-cache.h: Adjust extern decls to match.
7493 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7494 EMACS_INT, since either will do, for xpalloc.
7496 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7497 (xnmalloc, xnrealloc, xpalloc): New functions.
7499 * bidi.c (bidi_shelve_header_size): New constant.
7500 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7501 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7503 * bidi.c (bidi_cache_shrink):
7504 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7506 Don't update size of array until after memory allocation succeeds,
7507 because xmalloc/xrealloc may not return.
7508 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7509 now that we have proper integer overflow checking.
7510 (record_overlay_string, overlay_strings): Catch overflows when
7511 calculating size of overlay_str_buf.
7513 * callproc.c (Fcall_process): Check for size overflow when
7514 calculating size of args2.
7515 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7516 Normally we prefer signed values, but sticking with ptrdiff_t would
7517 require adding more-complicated checks.
7519 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7520 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7521 Redo buffer-overflow calculations to avoid integer overflow.
7522 Add a FIXME comment where memory seems to be over-allocated.
7524 * character.c (Fstring): Check for size-calculation overflow.
7526 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7527 unnecessary integer overflow. Check for size overflow.
7528 (encode_coding_object): Don't update size until xmalloc succeeds.
7530 * composite.c (get_composition_id): Check for overflow in glyph
7531 length calculations.
7533 Integer and memory overflow fixes for display code.
7534 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7535 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7536 (scrolling_window): Check for overflow in size calculations.
7537 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7538 Don't assume glyph table len fits in int.
7539 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7540 (row_table_size): Now ptrdiff_t, not int.
7541 (scrolling_window): Avoid overflow in size calculations.
7542 Don't update size until allocation succeeds.
7543 * fns.c (concat): Check for overflow in size calculations.
7544 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7545 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7546 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7548 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7549 (get_doc_string): Check for size calculation overflow.
7550 Don't update size until allocation succeeds.
7551 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7552 EMACS_INT, where ptrdiff_t will do.
7553 (Fsubstitute_command_keys): Check for string overflow.
7555 * editfns.c (set_time_zone_rule): Don't assume environment length
7557 (message_length): Now ptrdiff_t, not int.
7558 (Fmessage_box): Don't update size until allocation succeeds.
7559 Don't assume message length fits in int.
7560 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7562 * emacs.c (main): Do not reallocate argv, since there is a null at
7563 the end that can be overwritten, and this way there's no need to
7564 worry about size-calculation overflow.
7565 (sort_args): Check for size-calculation overflow.
7567 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7569 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7571 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7572 (x_set_scroll_bar_width, x_figure_window_size):
7573 Check for integer overflow.
7574 (x_set_alpha): Do not assume XINT fits in int.
7576 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7577 This is for the members text_lines, text_cols, total_lines, total_cols,
7578 where the system imposes an 'int' limit.
7580 * fringe.c (Fdefine_fringe_bitmap):
7581 Don't update size until alloc works.
7583 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7584 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7586 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7587 Check for size-calculation overflow.
7588 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7589 do, as we prefer signed integers.
7590 (id_to_widget.max_size, id_to_widget.used)
7591 (xg_store_widget_in_map, xg_remove_widget_from_map)
7592 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7593 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7594 Use and return ptrdiff_t, not int.
7595 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7596 * gtkutil.h: Change prototypes to match the above.
7598 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7599 are duplicate now that they've been promoted to lisp.h.
7600 (x_allocate_bitmap_record, x_alloc_image_color)
7601 (make_image_cache, cache_image, xpm_load):
7602 Don't update size until alloc is done.
7603 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7605 Check for size calculation overflow.
7606 (ct_colors_allocated_max): New constant.
7607 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7610 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7611 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7612 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7613 Use ptrdiff_t, not int, to count maps.
7614 (read_char_minibuf_menu_prompt): Check for overflow in size
7615 calculations. Don't update size until allocation succeeds.
7616 Redo calculations to avoid overflow.
7617 * keyboard.h: Change prototypes to match the above.
7619 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7621 (current_minor_maps): Check for size calculation overflow.
7622 * keymap.h: Change prototypes to match the above.
7624 * lread.c (read1, init_obarray): Don't update size until alloc done.
7626 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7627 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7629 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7630 Now ptrdiff_t, not int.
7631 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7632 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7634 * process.c (Fnetwork_interface_list): Check for overflow
7635 in size calculation.
7637 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7639 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7640 overflow. Don't bother calling xmalloc when xrealloc will do.
7642 * search.c (Freplace_match): Check for size calculation overflow.
7643 (Fset_match_data): Don't assume list lengths fit in 'int'.
7645 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7646 for command line length. Do not attempt to address one before the
7647 beginning of an array, as that's not portable.
7649 * term.c (max_frame_lines): Remove; unused.
7650 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7652 (encode_terminal_code, calculate_costs): Check for size
7653 calculation overflow.
7654 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7655 table lengths and related sizes. Don't update size until alloc
7656 done. Redo calculations to avoid overflow.
7657 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7659 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7660 subtracting pointers.
7661 (gobble_line): Check for overflow more carefully. Don't update size
7664 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7665 Don't update size until alloc done.
7666 Redo size calculations to avoid overflow.
7667 Check for size calculation overflow.
7668 (main) [DEBUG]: Fix typo in invoking tparam1.
7670 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7671 Use ptrdiff_t, not int, for sizes.
7672 (store_mode_line_noprop_char): Don't update size until alloc done.
7674 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7675 Use ptrdiff_t, not int, for sizes.
7676 (Finternal_make_lisp_face, cache_face):
7677 Check for size calculation overflow.
7678 (cache_face): Treat size calculation overflows as if they were
7679 memory exhaustion (the usual treatment), rather than aborting.
7681 * xfns.c (x_encode_text, x_set_name_internal)
7682 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7683 sizes, since they can exceed INT_MAX in size. Check for size
7684 calculation overflow.
7686 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7687 (xg_select): Check for size calculation overflow.
7688 Don't update size until alloc done.
7690 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7691 as sprintf is limited to int lengths.
7693 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7694 (X_LONG_MIN): New macros.
7695 Use them to make the following changes clearer.
7696 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7697 This change doesn't affect the value now, but it may help remind
7698 future maintainers not to raise the value too much later.
7699 (SELECTION_QUANTUM): Remove, replacing with ...
7700 (selection_quantum): ... new function, which avoids overflow.
7702 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7703 assumption that selection length fits in 'int'.
7704 (x_reply_selection_request, x_handle_selection_request)
7705 (x_get_window_property, receive_incremental_selection)
7706 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7707 (lisp_data_to_selection_data, clean_local_selection_data):
7708 Use ptrdiff_t, not int, to record length of selection.
7709 (x_reply_selection_request, x_get_window_property)
7710 (receive_incremental_selection, x_property_data_to_lisp):
7711 Redo calculations to avoid overflow.
7712 (x_reply_selection_request): When sending hint, ceiling it at
7713 X_LONG_MAX rather than relying on wraparound overflow to send
7715 (x_get_window_property, receive_incremental_selection)
7716 (lisp_data_to_selection_data, x_property_data_to_lisp):
7717 Check for size-calculation overflow.
7718 (x_get_window_property, receive_incremental_selection)
7719 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7720 Don't store size until memory allocation succeeds.
7721 (x_get_window_property): Plug memory leak on memory exhaustion.
7722 Don't double-block input; malloc is safe here. Don't assume 2**34
7723 - 4 fits in unsigned long. Add an xassert to check
7724 XGetWindowProperty overflow. Be more careful about overflow
7725 calculations, and distinguish size from memory overflow better.
7726 (receive_incremental_selection): When tracing, don't assume
7727 unsigned int is less than INT_MAX.
7728 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7729 harmful) conversions of unsigned short to int.
7730 (lisp_data_to_selection_data): Don't assume that integers
7731 in the range -65535 through -1 fit in an X unsigned short.
7732 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7733 result parameters unless successful. Rely on cons_to_unsigned
7734 to report problems with elements; the old code wasn't right anyway.
7735 (x_check_property_data): Check for int overflow; we cannot use
7736 a wider type due to X limits.
7737 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7739 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7741 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7742 (x_term_init): Check for size calculation overflow.
7743 (x_color_cells): Don't store size until memory allocation succeeds.
7744 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7745 Don't assume alloca size is less than MAX_ALLOCA.
7746 (x_term_init): Don't assume length fits in int (sprintf is limited
7749 Use ptrdiff_t for composition IDs.
7750 * character.c (lisp_string_width):
7751 * composite.c (composition_table_size, n_compositions)
7752 (get_composition_id, composition_gstring_from_id):
7753 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7754 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7755 * window.c (Frecenter):
7756 Use ptrdiff_t, not int, for composition IDs.
7757 * composite.c (get_composition_id): Check for integer overflow.
7758 * composite.h: Adjust prototypes to match the above changes.
7760 Use ptrdiff_t for hash table indexes.
7761 * category.c (hash_get_category_set):
7762 * ccl.c (ccl_driver):
7763 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7764 * coding.c (coding_system_charset_list, detect_coding_system):
7765 * coding.h (struct coding_system.id):
7766 * composite.c (get_composition_id, gstring_lookup_cache):
7767 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7768 * image.c (xpm_get_color_table_h):
7769 * lisp.h (hash_lookup, hash_put):
7770 * minibuf.c (Ftest_completion):
7771 Use ptrdiff_t for hash table indexes, not int (which is too
7772 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7773 32-bit --with-wide-int hosts).
7775 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7776 Add a FIXME comment about memory leaks.
7777 (syms_of_charset): Don't assume xmalloc returns.
7779 Don't assume that stated character widths fit in int.
7780 * character.c (Fchar_width, c_string_width, lisp_string_width):
7781 * character.h (CHAR_WIDTH):
7782 * indent.c (MULTIBYTE_BYTES_WIDTH):
7783 Use sanitize_char_width to avoid undefined and/or bad behavior
7784 with outlandish widths.
7785 * character.h (sanitize_tab_width): Rename from sanitize_width,
7786 now that we have two such functions. All uses changed.
7787 (sanitize_char_width): New inline function.
7789 Don't assume that tab-width fits in int.
7790 * character.h (sanitize_width): New inline function.
7791 (SANE_TAB_WIDTH): New macro.
7792 (ASCII_CHAR_WIDTH): Use it.
7793 * indent.c (sane_tab_width): Remove. All uses replaced by
7794 SANE_TAB_WIDTH (current_buffer).
7795 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7797 * fileio.c: Integer overflow issues with file modes.
7798 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7800 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7801 Remove unreachable code.
7802 (read_hex, load_charset_map_from_file): Check for integer overflow.
7804 * xterm.c: Don't go over XClientMessageEvent limit.
7805 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7806 (x_send_scroll_bar_event): Likewise. Check that the size does not
7807 exceed limits imposed by XClientMessageEvent, as well as the usual
7808 ptrdiff_t and size_t limits.
7810 * keyboard.c: Overflow, signedness and related fixes.
7811 (make_lispy_movement): Use same integer type in forward decl
7812 that is used in the definition.
7813 (read_key_sequence, keyremap_step):
7814 Change bufsize argument back to int, undoing my 2011-03-30 change.
7815 We prefer signed types, and int is wide enough here.
7816 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7817 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7818 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7819 length, not size_t. Use ptrdiff_t for index, not int.
7820 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7821 possibility of integer overflow.
7823 Overflow, signedness and related fixes for images.
7825 * dispextern.h (struct it.stack[0].u.image.image_id)
7826 (struct_it.image_id, struct image.id, struct image_cache.size)
7827 (struct image_cache.used, struct image_cache.ref_count):
7828 * gtkutil.c (update_frame_tool_bar):
7829 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7830 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7831 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7832 * nsmenu.m (update_frame_tool_bar):
7833 * xdisp.c (calc_pixel_width_or_height):
7834 * xfns.c (image_cache_refcount):
7835 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7836 on typical 64-bit hosts.
7838 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7839 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7840 Omit unnecessary casts to int.
7841 (parse_image_spec): Check that integers fall into 'int' range
7842 when the callers expect that.
7843 (image_ascent): Redo ascent calculation to avoid int overflow.
7844 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7845 (lookup_image): Remove unnecessary tests.
7846 (xbm_image_p): Locals are now of int, not EMACS_INT,
7847 since parse_image_check makes sure they fit into int.
7848 (png_load, gif_load, svg_load_image):
7849 Prefer int to unsigned where either will do.
7850 (tiff_handler): New function, combining the cores of the
7851 old tiff_error_handler and tiff_warning_handler.
7852 This function is rewritten to use vsnprintf and thereby avoid
7853 stack buffer overflows. It uses only the features of vsnprintf
7854 that are common to both POSIX and native Microsoft.
7855 (tiff_error_handler, tiff_warning_handler): Use it.
7856 (tiff_load, gif_load, imagemagick_load_image):
7857 Don't assume :index value fits in 'int'.
7858 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7859 (imagemagick_load_image): Check that crop parameters fit into
7860 the integer types that MagickCropImage accepts. Don't assume
7861 Vimagemagick_render_type has a nonnegative value. Don't assume
7862 size_t fits in 'long'.
7863 (gs_load): Use printmax_t to print the widest integers possible.
7864 Check for integer overflow when computing image height and width.
7866 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7868 * xdisp.c (redisplay_window): Don't force window start if point
7869 will be invisible in the resulting window. (Bug#9324)
7871 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7873 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7874 the display spec is of the form `(space ...)'.
7875 (handle_display_spec): Return the value returned by
7876 handle_single_display_spec, not just 1 or zero.
7877 (handle_single_display_spec): If the display spec is of the form
7878 `(space ...)', and specifies display in the text area, return 2
7880 (try_cursor_movement): Check for the need to scroll more
7881 accurately, and prefer exact match for point under bidi.
7882 Don't advance `row' beyond the last row of the window.
7884 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7885 into disp_prop; all users changed.
7887 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7888 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7889 for the text covered by the display property.
7891 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7893 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7894 Change return value to nil.
7895 (Frecord_buffer): Delete unused function.
7897 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7899 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7900 buffers, return left-to-right.
7901 (set_cursor_from_row): Consider candidate row a win if its glyph
7902 represents a newline and point is on that newline. Fixes cursor
7903 positioning on the newline at EOL of R2L text within L2R
7904 paragraph, and vice versa.
7905 (try_cursor_movement): Check continued rows, in addition to
7906 continuation rows. Fixes unwarranted scroll when point enters a
7907 continued line of R2L text within an L2R paragraph, or vice versa.
7908 (cursor_row_p): Consider the case of point being equal to
7909 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7910 from the end of a short line to the beginning of a continued line
7911 of R2L text within L2R paragraph.
7912 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7913 composed characters.
7915 * bidi.c (bidi_check_type): Use xassert.
7916 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7919 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7921 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7924 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7926 * nsfont.m (ns_otf_to_script): Fix typo.
7928 2011-08-22 Kenichi Handa <handa@m17n.org>
7930 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7931 extra slot even if the purpose is char-code-property-table.
7933 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7935 * xdisp.c (redisplay_window): When computing centering_position,
7936 account for the height of the header line. (Bug#8874)
7938 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7939 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7940 candidate is selected by the mouse, and that candidate has a
7941 composed character under the mouse.
7943 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7944 coordinates reported by pos-visible-in-window-p for a composed
7945 character in column zero.
7947 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7949 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7951 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7953 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7954 consider it a hit if to_charpos is anywhere in the range of the
7955 composed buffer positions.
7957 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7959 * image.c (gif_load): Don't assume that each subimage has the same
7960 dimensions as the base image. Handle disposal method that is
7961 "undefined" by the gif spec (Bug#9335).
7963 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7965 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7966 (Fcondition_case): Document `debug' symbol in error handler.
7968 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7970 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7971 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7972 from an Org mode buffer to a Speedbar frame.
7974 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7975 a composition, take its buffer position from IT->cmp_it.charpos.
7976 Fixes cursor positioning at the beginning of a line that begins
7977 with a composed character.
7979 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7981 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7982 character bidirectional type, use STRONG_L instead. Fixes crashes
7983 in a buffer produced by `describe-categories'.
7985 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7986 members before the level stack, so they would be saved and
7987 restored when copying iterator state. Fixes incorrect reordering
7988 around TABs covered by display properties.
7990 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7992 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7994 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7996 * eval.c (internal_condition_case, internal_condition_case_1)
7997 (internal_condition_case_2, internal_condition_case_n):
7998 Remove unnecessary aborts (Bug#9081).
8000 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8002 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8003 has no `load' handler, try opening the file locally. (Bug#9311)
8005 2011-08-16 Ken Brown <kbrown@cornell.edu>
8007 * gmalloc.c: Expand comment.
8009 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8011 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8012 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8014 2011-08-16 Ken Brown <kbrown@cornell.edu>
8016 Fix memory allocation problems in Cygwin build (Bug#9273).
8018 * unexcw.c ( __malloc_initialized): Declare external variable.
8019 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8021 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8023 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8025 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8027 [CYGWIN] (special_realloc): New function.
8028 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8029 requests to realloc storage in the static heap.
8031 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8033 * bidi.c (bidi_initialize): Remove unused local.
8035 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8038 * biditype.h: Remove file.
8039 * makefile.w32-in ($(BLD)/bidi.$(O)):
8040 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8042 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8044 * chartab.c: Improve commentary for the uniprop_table API.
8046 * bidi.c (bidi_paragraph_init): Support zero value of
8047 bidi_ignore_explicit_marks_for_paragraph_level.
8048 (bidi_initialize): Use uniprop_table instead of including
8049 biditype.h and bidimirror.h.
8051 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8052 coordinates of the iterator when restoring from ppos_it.
8055 2011-08-14 Kenichi Handa <handa@m17n.org>
8057 * process.c (create_process): Call setup_process_coding_systems
8058 after the pid of the process is set to -1 (Bug#8162).
8060 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8062 * xdisp.c (move_it_in_display_line_to): Don't invoke
8063 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8064 ppos_it. Fixes vertical cursor motion when line beginning is
8065 covered by an image. (Bug#9296)
8067 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8069 * nsterm.h (ns_run_ascript): Declare.
8070 (NSAPP_DATA2_RUNASSCRIPT): Define.
8072 * nsfns.m (as_script, as_result, as_status): New static variables.
8073 (ns_run_ascript): New function.
8074 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8075 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8076 the event loop. Get status from as_status (Bug#7276).
8078 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8079 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8080 the event loop (Bug#7276).
8082 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8084 * gnutls.c (QCgnutls_bootprop_priority)
8085 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8086 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8087 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8088 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8089 (QCgnutls_bootprop_verify_hostname_error)
8090 (QCgnutls_bootprop_callbacks_verify): Rename from
8091 Qgnutls_bootprop_..., all uses changed.
8093 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8096 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8098 * xfaces.c (Qframe_set_background_mode): Now static.
8099 * dispextern.h (Qframe_set_background_mode): Remove decl.
8101 * process.c (Fnetwork_interface_info): Declare local only if needed.
8103 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8105 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8106 (Fnetwork_interface_list): Allocate in increments of bytes instead
8107 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8108 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8110 (struct ifflag_def): notrailers is smart on OSX.
8111 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8112 Get hardware address with getifaddrs if available.
8114 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8116 * xdisp.c (iterate_out_of_display_property): xassert that
8117 IT->position is set to within IT->object's boundaries. Break from
8118 the loop as soon as EOB is reached; avoids infloops in redisplay
8119 when IT->position is set up wrongly due to some bug.
8120 Set IT->current to match the bidi iterator unconditionally.
8121 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8122 entry. Force push_it to save on the stack the current
8123 buffer/string position, to be restored by pop_it. Fix flags in
8124 the iterator structure wrt the object coming from a display
8125 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8126 properties. (Bug#9284)
8128 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8130 * fontset.c (fontset_get_font_group): Add proper type checks.
8133 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8135 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8136 and LC_VERSION_MIN_MACOSX.
8137 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8138 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8140 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8142 * xdisp.c (forward_to_next_line_start): Allow to use the
8143 no-display-properties-and-no-overlays under bidi display.
8144 Set disp_pos in the bidi iterator to avoid searches for display
8145 properties and overlays.
8147 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8149 * editfns.c (Fset_time_zone_rule): Document relationship with the
8152 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8153 the font entity extracted from the cache (Bug#8109).
8155 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8157 * composite.c (autocmp_chars): Don't reset point. That is done by
8158 restore_point_unwind (Bug#5984).
8160 2011-08-07 Juri Linkov <juri@jurta.org>
8162 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8163 to show the arg `TIME' instead of `TIMEVAL'.
8165 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8167 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8168 display property strides EOL and includes a newline, as in
8169 longlines-mode. (Bug#9254)
8170 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8171 word-wrap under bidirectional display. (Bug#9224)
8173 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8174 is non-zero, even if the data buffer is NULL. Fixes a crash in
8175 vertical-motion with longlines-mode. (Bug#9254)
8177 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8179 * bidi.c <bidi_cache_total_alloc>: Now static.
8180 (bidi_initialize): Initialize bidi_cache_total_alloc.
8182 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8185 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8186 amount allocated this far in `bidi_cache_total_alloc'.
8187 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8188 non-zero, only free the data buffer without restoring the cache
8189 contents. All callers changed.
8191 * dispextern.h (bidi_unshelve_cache): Update prototype.
8193 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8194 (move_it_in_display_line, move_it_to)
8195 (move_it_vertically_backward, move_it_by_lines): Replace the call
8196 to xfree to an equivalent call to bidi_unshelve_cache.
8197 (move_it_in_display_line_to): Fix logic of returning
8198 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8200 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8202 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8203 came from a string character with a `cursor' property. (Bug#9229)
8205 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8207 * Makefile.in (LIB_PTHREAD): New variable.
8208 (LIBES): Add LIB_PTHREAD (Bug#9216).
8210 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8211 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8213 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8215 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8217 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8219 * xterm.c (x_find_topmost_parent): New function.
8220 (x_set_frame_alpha): Find topmost parent window with
8221 x_find_topmost_parent and set the property there also (bug#9181).
8222 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8224 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8226 * callproc.c (Fcall_process): Avoid vfork clobbering
8227 the local vars buffer, coding_systems, current_dir.
8229 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8231 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8233 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8235 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8236 so that it is not optimized away.
8238 * xdisp.c (compute_display_string_pos): Remove unused local.
8240 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8242 Fix slow cursor motion and scrolling in large buffers with
8243 selective display, like Org Mode buffers. (Bug#9218)
8245 * dispextern.h (struct bidi_it): New member disp_prop_p.
8247 * xdisp.c: Remove one-slot cache of display string positions.
8248 (compute_display_string_pos): Accept an additional argument
8249 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8250 for a display string or property. If found, set DISP_PROP_P
8253 * bidi.c (bidi_fetch_char): Accept an additional argument
8254 DISP_PROP_P, and pass it to compute_display_string_pos.
8255 Only handle text covered by a display string if DISP_PROP_P is returned
8256 non-zero. All callers of bidi_fetch_char changed.
8258 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8260 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8262 2010-12-03 Don March <don@ohspite.net>
8264 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8265 last character M-[char] is translated to ESC [char] (bug#7541).
8267 2011-08-02 Kenichi Handa <handa@m17n.org>
8269 * lisp.h (uniprop_table): Extern it.
8271 * chartab.c (uniprop_table): Make it non-static.
8273 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8275 * xdisp.c (forward_to_next_line_start): Accept additional argument
8276 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8278 (reseat_at_next_visible_line_start): Use the bidi iterator state
8279 returned by forward_to_next_line_start to restore the state of
8280 it->bidi_it after backing up to previous newline. (Bug#9212)
8282 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8284 * regex.c (re_comp): Protoize.
8285 (re_exec): Fix return type.
8286 (regexec): Fix type of `ret'. (Bug#9203)
8288 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8290 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8291 This is needed if max-image-size is a floating-point number.
8293 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8295 * print.c (print_object): Print empty symbol as ##.
8297 * lread.c (read1): Read ## as empty symbol.
8299 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8301 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8302 setting frame foreground color (Bug#9175).
8303 (x_set_background_color): Likewise.
8305 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8306 contents (Bug#9176).
8307 (EmacsTooltip -init): Remove bezels and add shadows to
8310 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8311 or scroll bar (Bug#8470).
8313 * nsfont.m (nsfont_open): Remove assignment to voffset and
8314 unnecessary vars hshink, expand, hd, full_height, min_height.
8315 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8317 * nsterm.h (nsfont_info): Remove voffset field.
8319 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8321 Implement strike-through and overline on NextStep (Bug#8863).
8323 * nsfont.m (nsfont_open): Use underline position provided by font,
8324 instead of hard-coded value of 2.
8325 (nsfont_draw): Call ns_draw_text_decoration instead.
8327 * nsterm.h: Add declaration for ns_draw_text_decoration.
8329 * nsterm.m (ns_draw_text_decoration): New function for drawing
8330 underline, overline, and strike-through.
8331 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8332 ns_draw_text_decoration. Change treatment of cursor drawing to
8333 accommodate underlining, etc.
8335 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8337 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8340 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8342 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8343 Without this fix, if a signal arrives just after memory fills up,
8344 'malloc' might be invoked reentrantly.
8346 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8347 In other words, assume that every image size is allowed, on non-X
8348 hosts. This assumption is probably wrong, but it lets Emacs compile.
8350 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8352 * regex.c (re_iswctype): Convert return values to boolean.
8354 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8356 * xdisp.c (compute_display_string_pos): Don't use cached display
8357 string position if the buffer had its restriction changed.
8360 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8362 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8364 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8366 Integer signedness and overflow and related fixes. (Bug#9079)
8368 * bidi.c: Integer size and overflow fixes.
8369 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8370 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8371 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8372 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8373 (bidi_find_other_level_edge):
8374 Use ptrdiff_t instead of EMACS_INT where either will do.
8375 This works better on 32-bit hosts configured --with-wide-int.
8376 (bidi_cache_ensure_space): Check for size-calculation overflow.
8377 Use % rather than repeated addition, for better worst-case speed.
8378 Don't set bidi_cache_size until after xrealloc returns, because it
8380 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8381 (bidi_cache_ensure_space): Also check that the bidi cache size
8382 does not exceed that of the largest Lisp string or buffer. See Eli
8383 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8385 * alloc.c (__malloc_size_t): Remove.
8386 All uses replaced by size_t. See Andreas Schwab's note
8387 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8389 * image.c: Improve checking for integer overflow.
8390 (check_image_size): Assume that f is nonnull, since
8391 it is always nonnull in practice. This is one less thing to
8392 worry about when checking for integer overflow later.
8393 (x_check_image_size): New function, which checks for integer
8394 overflow issues inside X.
8395 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8396 This removes the need for a memory_full check.
8397 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8398 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8399 (xbm_read_bitmap_data): Change locals back to 'int', since
8400 their values must fit in 'int'.
8401 (xpm_load_image, png_load, tiff_load):
8402 Invoke x_create_x_image_and_pixmap earlier,
8403 to avoid much needless work if the image is too large.
8404 (tiff_load): Treat overly large images as if
8405 x_create_x_image_and_pixmap failed, not as malloc failures.
8406 (gs_load): Use x_check_image_size.
8408 * gtkutil.c: Omit integer casts.
8409 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8410 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8412 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8414 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8415 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8416 would wrongly return t on a 64-bit host.
8418 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8419 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8420 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8421 and therefore cause GCC to emit a bogus diagnostic in some cases.
8423 * image.c: Integer signedness and overflow and related fixes.
8424 This is not an exhaustive set of fixes, but it's time to
8425 record what I've got.
8426 (lookup_pixel_color, check_image_size): Remove redundant decls.
8427 (check_image_size): Don't assume that arbitrary EMACS_INT values
8428 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8429 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8430 (tiff_load, imagemagick_load_image):
8431 Check for overflow in size calculations.
8432 (x_create_x_image_and_pixmap): Remove unnecessary test for
8433 xmalloc returning NULL; that can't happen.
8434 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8435 (xpm_color_bucket): Use better integer hashing function.
8436 (xpm_cache_color): Don't possibly over-allocate memory.
8437 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8438 (gif_memory_source):
8439 Use ptrdiff_t, not int or size_t, to record sizes.
8440 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8441 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8442 either works, as we prefer signed integers.
8443 (tiff_read_from_memory, tiff_write_from_memory):
8444 Return tsize_t, not size_t, since that's what the TIFF API wants.
8445 (tiff_read_from_memory): Don't fail simply because the read would
8446 go past EOF; instead, return a short read.
8447 (tiff_load): Omit no-longer-needed casts.
8448 (Fimagemagick_types): Don't assume size fits into 'int'.
8450 Improve hashing quality when configured --with-wide-int.
8451 * fns.c (hash_string): New function, taken from sxhash_string.
8452 Do not discard information about ASCII character case; this
8453 discarding is no longer needed.
8454 (sxhash-string): Use it. Change sig to match it. Caller changed.
8455 * lisp.h: Declare it.
8456 * lread.c (hash_string): Remove, since we now use fns.c's version.
8457 The fns.c version returns a wider integer if --with-wide-int is
8458 specified, so this should help the quality of the hashing a bit.
8460 * emacs.c: Integer overflow minor fix.
8461 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8462 Define only if GNU_LINUX.
8463 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8465 * dispnew.c: Integer signedness and overflow fixes.
8466 Remove unnecessary forward decls, that were a maintenance hassle.
8467 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8469 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8470 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8471 (prepare_desired_row, line_draw_cost):
8472 Use int, not unsigned, where either works.
8473 (save_current_matrix, restore_current_matrix):
8474 Use ptrdiff_t, not size_t, where either works.
8475 (init_display): Check for overflow more accurately, and without
8476 relying on undefined behavior.
8478 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8479 Remove, replacing with the new symbols in lisp.h. All uses changed.
8480 * fileio.c (make_temp_name):
8481 * filelock.c (lock_file_1, lock_file):
8482 * xdisp.c (message_dolog):
8483 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8484 Use pMd etc. instead.
8485 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8486 replacing the pWIDE etc. symbols removed from editfns.c.
8488 * keyboard.h (num_input_events): Now uintmax_t.
8489 This is (very slightly) less likely to mess up due to wraparound.
8492 * buffer.c: Integer signedness fixes.
8493 (alloc_buffer_text, enlarge_buffer_text):
8494 Use ptrdiff_t rather than size_t when either will do, as we prefer
8497 * alloc.c: Integer signedness and overflow fixes.
8498 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8499 (__malloc_size_t): Default to size_t, not to int.
8500 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8501 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8502 Prefer ptrdiff_t to size_t when either would do, as we prefer
8504 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8505 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8506 Now const. Initialize with values that are in range even if char
8508 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8509 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8510 These functions do the right thing with sizes > 2**32.
8511 (check_depth): Now ptrdiff_t, not int.
8512 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8513 Adjust to new way of storing sizes. Check for size overflow bugs
8515 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8516 slightly wrong anyway, as it missed one instance of
8517 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8518 (refill_memory_reserve): Omit needless cast to size_t.
8519 (mark_object_loop_halt): Mark as externally visible.
8521 * xselect.c: Integer signedness and overflow fixes.
8522 (Fx_register_dnd_atom, x_handle_dnd_message):
8523 Use ptrdiff_t, not size_t, since we prefer signed.
8524 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8525 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8526 x_dnd_atoms_size and x_dnd_atoms_length.
8528 * doprnt.c: Prefer signed to unsigned when either works.
8530 * doprnt.c (doprnt):
8532 * xdisp.c (vmessage):
8533 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8534 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8535 prefer signed arithmetic to avoid comparison confusion.
8536 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8537 but is a bit tricky.
8539 Assume freestanding C89 headers, string.h, stdlib.h.
8540 * data.c, doprnt.c, floatfns.c, print.c:
8541 Include float.h unconditionally.
8542 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8543 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8544 * regex.c: Likewise for stddef.h, string.h.
8545 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8546 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8547 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8548 (STDC_HEADERS): Remove obsolete defines.
8549 * sysdep.c: Include limits.h unconditionally.
8551 Assume support for memcmp, memcpy, memmove, memset.
8552 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8553 * regex.c (memcmp, memcpy):
8554 Remove; we assume C89 now.
8556 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8557 (__malloc_safe_bcopy): Remove; no longer needed.
8559 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8560 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8561 well either way, and we prefer signed to unsigned.
8563 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8565 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8566 closes the connection while we're reading (bug#9182).
8568 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8570 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8571 are specified (Bug#9168).
8573 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8575 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8576 Found by GCC static checking and --with-wide-int on a 32-bit host.
8578 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8580 * xdisp.c (compute_display_string_pos): Fix logic of caching
8581 previous display string position. Initialize cached_prev_pos to
8582 -1. Fixes slow-down at the beginning of a buffer.
8584 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8586 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8587 for attrs[LFACE_FONTSET_INDEX].
8589 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8591 * xml.c (parse_region): Remove unused local
8592 that was recently introduced.
8594 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8596 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8597 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8599 * xdisp.c (move_it_in_display_line_to): Record the best matching
8600 position for TO_CHARPOS while scanning the line, and restore it on
8601 exit if none of the characters scanned was an exact match.
8602 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8603 when exact match is impossible due to invisible text, and the
8604 lines are truncated.
8606 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8608 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8611 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8613 Fix a significant slow-down of cursor motion with C-n, C-p,
8614 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8615 auto-repeat under bidi redisplay in fontified buffers.
8616 * xdisp.c (compute_stop_pos_backwards): New function.
8617 (next_element_from_buffer): Call compute_stop_pos_backwards to
8618 find a suitable prev_stop when we find ourselves before
8620 (reseat): Don't look for prev_stop, as that could mean a very long
8622 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8623 <cached_disp_overlay_modiff>: Cache for last found display string
8625 (compute_display_string_pos): Return the cached position if asked
8626 about the same buffer in the same area of character positions, and
8627 the buffer wasn't changed since the time the display string
8628 position was cached.
8630 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8632 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8633 is an integer, which is important for empty lines. (Bug#9149)
8635 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8637 * frame.c (Fmodify_frame_parameters): In tty case, update the
8638 default face if necessary (Bug#4238).
8640 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8642 * editfns.c (Fstring_to_char): No need to explain what a character
8643 is in the docstring (Bug#6576).
8645 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8647 * xml.c (parse_region): Make sure we always return a tree.
8649 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8651 * xml.c (parse_region): If a document contains only comments,
8654 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8656 * xml.c (make_dom): Return comments, too.
8658 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8661 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8662 and the surrounding thread.
8663 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8664 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8665 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8667 * s/openbsd.h (BROKEN_SIGIO): Define.
8668 * unexelf.c (unexec) [__OpenBSD__]:
8669 Don't update the .mdebug section of the Alpha COFF symbol table.
8671 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8673 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8676 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8678 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8679 This fixes some race conditions on the permissions of any newly
8682 * alloc.c (valid_pointer_p): Use pipe, not open.
8683 This fixes some permissions issues when debugging.
8685 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8686 If fchown fails to set both uid and gid, try to set just gid,
8687 as that is sometimes allowed. Adjust the file's mode to eliminate
8688 setuid or setgid bits that are inappropriate if fchown fails.
8690 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8692 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8693 to compare Lisp_Objects.
8694 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8695 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8696 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8698 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8700 * lread.c (read_integer): Unread even EOF character.
8701 (read1): Likewise. Properly record start position of symbol.
8703 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8704 symbol character follows.
8706 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8708 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8709 This works around a problem with the previous change to Fcopy_file.
8710 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8711 and without this change, GCC might complain about discarding
8712 fchown's return value.
8714 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8716 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8718 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8720 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8722 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8724 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8725 it's used from the C level.
8727 * process.c: Use the same condition for POLL_FOR_INPUT in both
8728 keyboard.c and process.c (bug#1858).
8730 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8732 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8733 (Fgnutls_boot): Use it.
8735 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8737 * doc.c (Fsubstitute_command_keys): Revert last change.
8739 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8741 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8742 quotes the next character, and doesn't affect other longer
8743 sequences (bug#8935).
8745 * lread.c (syms_of_lread): Clarify that is isn't only
8746 `eval-buffer' and `eval-defun' that's affected by
8747 `lexical-binding' (bug#8460).
8749 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8751 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8752 bidi redisplay when a line includes both an image and is truncated.
8754 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8756 Fix minor problems found by static checking.
8757 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8758 (elsz): Now a signed constant, not a size_t var. We prefer signed
8759 types to unsigned, to avoid integer comparison confusion. Without
8760 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8761 "cannot optimize loop, the loop counter may overflow", a symptom
8763 * indent.c (Fvertical_motion): Mark locals as initialized.
8764 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8766 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8768 * search.c (Fre_search_backward): Mention `case-fold-search' in
8769 all the re_search_* functions (bug#8138).
8771 * keyboard.c (Fopen_dribble_file): Document when the file is
8774 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8776 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8779 Support bidi reordering of display and overlay strings.
8780 * xdisp.c (compute_display_string_pos)
8781 (compute_display_string_end): Accept additional argument STRING.
8782 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8783 (reseat_to_string): Initialize bidi_it->string.s and
8784 bidi_it->string.schars.
8785 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8786 NULL (avoids a crash in bidi_paragraph_init).
8787 Initialize itb.string.lstring.
8788 (init_iterator): Call bidi_init_it only of a valid
8789 buffer position was specified. Initialize paragraph_embedding to
8791 (reseat_to_string): Initialize the bidi iterator.
8792 (display_string): If we need to ignore text properties of
8793 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8794 original value of -1 will not work with bidi.)
8795 (compute_display_string_pos): First arg is now struct
8796 `text_pos *'; all callers changed. Support display properties on
8798 (compute_display_string_end): Support display properties on Lisp
8800 (init_iterator, reseat_1, reseat_to_string): Initialize the
8801 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8802 when iterating on a string not from display properties).
8803 (compute_display_string_pos, compute_display_string_end):
8804 Fix calculation of the object to scan. Fixes an error when using
8806 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8807 base_level_stop; instead, set base_level_stop to BEGV.
8808 Fixes crashes in vertical-motion.
8809 (next_element_from_buffer): Improve commentary for when
8810 the iterator is before prev_stop.
8811 (init_iterator): Initialize bidi_p from the default value of
8812 bidi-display-reordering, not from buffer-local value. Use the
8813 buffer-local value only if initializing for buffer iteration.
8814 (handle_invisible_prop): Support invisible properties on strings
8815 that are being bidi-reordered.
8816 (set_iterator_to_next): Support bidi reordering of C strings and
8818 (next_element_from_string): Support bidi reordering of Lisp
8820 (handle_stop_backwards): Support Lisp strings as well.
8821 (display_string): Support display of R2L glyph rows.
8822 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8823 (init_iterator): Don't initialize it->bidi_p for strings
8825 (reseat_to_string): Initialize it->bidi_p for strings here.
8826 (next_element_from_string, next_element_from_c_string)
8827 (next_element_from_buffer): Add xassert's for correspondence
8828 between IT's object being iterated and it->bidi_it.string
8830 (face_before_or_after_it_pos): Support bidi iteration.
8831 (next_element_from_c_string): Handle the case of the first string
8832 character that is not the first one in the visual order.
8833 (get_visually_first_element): New function, refactored from common
8834 parts of next_element_from_buffer, next_element_from_string, and
8835 next_element_from_c_string.
8836 (tool_bar_lines_needed, redisplay_tool_bar)
8837 (display_menu_bar): Force left-to-right direction. Add a FIXME
8838 comment for making that be controlled by a user option.
8839 (push_it, pop_it): Save and restore the state of the
8840 bidi iterator. Save and restore the bidi_p flag.
8841 (pop_it): Iterate out of display property for string iteration as
8843 (iterate_out_of_display_property): Support iteration over strings.
8844 (handle_single_display_spec): Set up it->bidi_it for iteration
8845 over a display string, and call bidi_init_it.
8846 (handle_single_display_spec, next_overlay_string)
8847 (get_overlay_strings_1, push_display_prop): Set up the bidi
8848 iterator for displaying display or overlay strings.
8849 (forward_to_next_line_start): Don't use the shortcut if
8851 (back_to_previous_visible_line_start): If handle_display_prop
8852 pushed the iterator stack, restore the internal state of the bidi
8853 iterator by calling bidi_pop_it same number of times.
8854 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8855 and we are bidi-iterating, don't decrement the iterator position;
8856 instead, set the first_elt flag in the bidi iterator, to produce
8858 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8859 (push_display_prop): xassert that we are iterating a buffer.
8860 (push_it, pop_it): Save and restore paragraph_embedding member.
8861 (handle_single_display_spec, next_overlay_string)
8862 (get_overlay_strings_1, reseat_1, reseat_to_string)
8863 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8864 correctly. Don't assume unibyte strings are not bidi-reordered.
8865 (compute_display_string_pos)
8866 (compute_display_string_end): Fix handling the case of C string.
8867 (push_it, pop_it): Save and restore from_disp_prop_p.
8868 (handle_single_display_spec, push_display_prop): Set the
8869 from_disp_prop_p flag.
8870 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8871 (pop_it): Call iterate_out_of_display_property only if we are
8872 popping after iteration over a string that came from a display
8873 property. Fix a typo in popping stretch info. Add an assertion
8874 for verifying that the iterator position is in sync with the bidi
8876 (handle_single_display_spec, get_overlay_strings_1)
8877 (push_display_prop): Fix initialization of paragraph direction for
8878 string when that of the parent object is not yet determined.
8879 (reseat_1): Call bidi_init_it to resync the bidi
8880 iterator with IT's position. (Bug#7616)
8881 (find_row_edges): If ROW->start.pos gives position
8882 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8883 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8884 Reset the from_disp_prop_p flag.
8885 (SAVE_IT, RESTORE_IT): New macros.
8886 (pos_visible_p, face_before_or_after_it_pos)
8887 (back_to_previous_visible_line_start)
8888 (move_it_in_display_line_to, move_it_in_display_line)
8889 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8890 (try_scrolling, redisplay_window, display_line): Use them when
8891 saving a temporary copy of the iterator and restoring it back.
8892 (back_to_previous_visible_line_start, reseat_1)
8893 (init_iterator): Empty the bidi cache "stack".
8894 (move_it_in_display_line_to): If iterator ended up at
8895 EOL, but we never saw any buffer positions smaller than
8896 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8897 motion in bidi-reordered lines.
8898 (move_it_in_display_line_to): Record prev_method and prev_pos
8899 immediately before the call to set_iterator_to_next. Fixes cursor
8900 motion in bidi-reordered lines with stretch glyphs and strings
8901 displayed in margins. (Bug#8133) (Bug#8867)
8902 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8904 (pos_visible_p): Support positions in bidi-reordered lines.
8905 Save and restore bidi cache.
8907 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8908 (bidi_paragraph_info): Delete unused struct.
8909 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8910 (bidi_cache_start): New variable.
8911 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8913 (bidi_cache_fetch_state, bidi_cache_search)
8914 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8915 (bidi_cache_find, bidi_peek_at_next_level)
8916 (bidi_level_of_next_char, bidi_find_other_level_edge)
8917 (bidi_move_to_visually_next): Compare cache index with
8918 bidi_cache_start rather than with zero.
8919 (bidi_fetch_char): Accept new argument STRING; all callers
8920 changed. Support iteration over a string. Support strings with
8921 display properties. Support unibyte strings. Fix the type of
8922 `len' according to what STRING_CHAR_AND_LENGTH expects.
8923 (bidi_paragraph_init, bidi_resolve_explicit_1)
8924 (bidi_resolve_explicit, bidi_resolve_weak)
8925 (bidi_level_of_next_char, bidi_move_to_visually_next):
8926 Support iteration over a string.
8927 (bidi_set_sor_type, bidi_resolve_explicit_1)
8928 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8929 can now be zero (for strings); special values 0 and -1 were
8930 changed to -1 and -2, respectively.
8931 (bidi_char_at_pos): New function.
8932 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8933 Call it instead of FETCH_MULTIBYTE_CHAR.
8934 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8935 initialized to valid values.
8936 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8938 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8939 the test for valid cached positions. Fix the logic for looking up
8940 the sentinel state in the cache. GCPRO the Lisp string we are
8942 (bidi_push_it, bidi_pop_it): New functions.
8943 (bidi_initialize): Initialize the bidi cache start stack pointer.
8944 (bidi_cache_ensure_space): New function, refactored from part of
8945 bidi_cache_iterator_state. Don't assume the required size is just
8946 one BIDI_CACHE_CHUNK away.
8947 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8948 (bidi_count_bytes, bidi_char_at_pos): New functions.
8949 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8950 always valid if bidi_cache_idx is valid.
8951 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8952 is valid if it's going to be used.
8953 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8954 (bidi_cache_fetch_state, bidi_cache_search)
8955 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8956 (bidi_cache_iterator_state, bidi_cache_find)
8957 (bidi_find_other_level_edge, bidi_cache_start_stack):
8958 All variables related to cache indices are now EMACS_INT.
8960 * dispextern.h (struct bidi_string_data): New structure.
8961 (struct bidi_it): New member `string'. Make flag members be 1-bit
8962 fields, and put them last in the struct.
8963 (compute_display_string_pos, compute_display_string_end):
8965 (bidi_push_it, bidi_pop_it): Add prototypes.
8966 (struct iterator_stack_entry): New members bidi_p,
8967 paragraph_embedding, and from_disp_prop_p.
8968 (struct it): Member bidi_p is now a bit field 1 bit wide.
8969 (bidi_shelve_cache, bidi_unshelve_cache):
8972 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8973 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8974 and vector-like objects.
8976 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8977 cache around display iteration.
8979 * window.c (Fwindow_end, window_scroll_pixel_based)
8980 (displayed_window_lines, Frecenter): Save and restore the bidi
8981 cache around display iteration.
8983 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8985 * editfns.c (Fdelete_region): Clarify the use of the named
8986 parameters (bug#6788).
8988 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8990 * indent.c (Fvertical_motion): Set and restore w->pointm when
8991 saving and restoring the window's buffer (Bug#9006).
8993 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8995 * editfns.c (Fstring_to_char): Clarify just what is returned
8996 (bug#6576). Text by Eli Zaretskii.
8998 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9000 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9002 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9004 * buffer.c (mmap_find): Fix a typo.
9006 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9008 Fix execution of x selection hooks.
9009 * xselect.c (Qx_lost_selection_functions)
9010 (Qx_sent_selection_functions): New vars.
9011 (syms_of_xselect): DEFSYM them.
9012 (x_handle_selection_request): Pass Qx_sent_selection_functions
9013 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9014 (x_handle_selection_clear,x_clear_frame_selections):
9015 Pass Qx_lost_selection_functions rather than
9016 Vx_lost_selection_functions to Frun_hook_with_args.
9018 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9020 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9021 The old code sometimes used this field without initializing it.
9023 * alloc.c (gc_sweep): Don't read past end of array.
9024 In theory, the old code could also have corrupted Emacs internals,
9025 though it'd be very unlikely.
9027 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9029 * character.c (Fcharacterp): Don't advertise optional ignored
9030 argument. (Bug#4026)
9032 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9034 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9037 * window.c (Fset_window_start): Doc fix (bug#4199).
9038 (Fset_window_hscroll): Ditto.
9040 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9042 Fix minor new problems caught by GCC 4.6.1.
9043 * term.c (init_tty): Remove unused local.
9044 * xsettings.c (store_monospaced_changed): Define this function only
9045 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9048 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9050 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9052 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9054 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9055 are the mini-buffer and the echo area (bug#3320).
9057 * term.c (init_tty): Remove support for supdup, c10 and perq
9058 terminals, which are no longer supported (bug#1482).
9060 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9062 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9064 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9066 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9067 for non-popups (Bug#3642).
9069 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9071 * alloc.c (reset_malloc_hooks): Protoize.
9072 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9073 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9074 * cm.c (losecursor): Likewise.
9075 * data.c (fmod): Likewise.
9076 * dispnew.c (swap_glyphs_in_rows): Likewise.
9077 * emacs.c (memory_warning_signal): Likewise.
9078 * floatfns.c (float_error): Likewise.
9079 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9080 (otf_open, font_otf_capability, generate_otf_features)
9081 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9083 * image.c (pbm_read_file): Likewise.
9084 * indent.c (string_display_width): Likewise.
9085 * intervals.c (check_for_interval, search_for_interval)
9086 (inc_interval_count, count_intervals, root_interval)
9087 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9088 * lread.c (defalias): Likewise.
9089 * ralloc.c (r_alloc_check): Likewise.
9090 * regex.c (set_image_of_range_1, set_image_of_range)
9091 (regex_grow_registers): Likewise.
9092 * sysdep.c (strerror): Likewise.
9093 * termcap.c (valid_filename_p, tprint, main): Likewise.
9094 * tparam.c (main): Likewise.
9095 * unexhp9k800.c (run_time_remap, save_data_space)
9096 (update_file_ptrs, read_header, write_header, calculate_checksum)
9097 (copy_file, copy_rest, display_header): Likewise.
9098 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9100 * xdisp.c (check_it): Likewise.
9101 * xfaces.c (register_color, unregister_color, unregister_colors):
9103 * xfns.c (print_fontset_result): Likewise.
9104 * xrdb.c (member, fatal, main): Likewise.
9106 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9108 Fix minor problems found by static checking (Bug#9031).
9109 * chartab.c (char_table_set_range, map_sub_char_table):
9110 Remove unused locals.
9111 (uniprop_table): Now static.
9112 * composite.c (_work_char): Remove unused static var.
9114 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9116 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9118 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9120 * gtkutil.c (qttip_cb): Remove code without function.
9122 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9124 * w32.c (pthread_sigmask): New stub.
9126 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9128 Use pthread_sigmask, not sigprocmask (Bug#9010).
9129 sigprocmask is portable only for single-threaded applications, and
9130 Emacs can be multi-threaded when it uses GTK.
9131 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9133 * callproc.c (Fcall_process):
9134 * process.c (create_process):
9135 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9136 Use pthread_sigmask, not sigprocmask.
9138 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9140 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9141 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9144 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9146 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9147 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9148 (xg_hide_tooltip): Fix comment.
9150 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9151 in registerServicesMenuSendTypes.
9152 (validRequestorForSendType): Don't check ns_return_types.
9154 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9157 2011-07-08 Jason Rumney <jasonr@gnu.org>
9159 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9160 SH_SHOW for hidden windows (Bug#5482).
9162 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9163 frame struct members of non-existent frames (Bug#6284).
9165 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9167 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9168 variable firstTime not needed on OSX >= 10.6.
9169 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9170 >= 10.5. Use setKnobProportion, setDoubleValue.
9172 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9173 (MAC_OS_X_VERSION_10_5): Define if not defined.
9174 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9175 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9176 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9178 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9179 cString and lossyCString on OSX >= 10.4.
9181 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9182 sizeToFit on OSX >= 10.2.
9184 * nsimage.m (allocInitFromFile): Don't use deprecated method
9185 bestRepresentationForDevice on OSX >= 10.6.
9187 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9190 * emacs.c: Declare unexec_init_emacs_zone.
9192 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9194 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9196 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9197 on svcsMenu (Bug#8842).
9199 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9201 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9203 * nsterm.m (QUTF8_STRING): Declare.
9204 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9205 (validRequestorForSendType): Return type is (id).
9206 Change indexOfObjectIdenticalTo to indexOfObject.
9207 Check if we have local selection before returning self (Bug#8842).
9208 (writeSelectionToPasteboard): Put local selection into paste board
9209 if we have a local selection (Bug#8842).
9210 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9212 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9213 (ns_get_local_selection): Declare.
9215 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9217 * keymap.c (describe_map_tree): Don't insert a double newline at
9218 the end of the buffer (bug#1169) and return whether we inserted
9221 * callint.c (Fcall_interactively): Change "reading args" to
9222 "providing args" to try to clarify what it does (bug#1010).
9224 2011-07-07 Kenichi Handa <handa@m17n.org>
9226 * composite.c (composition_compute_stop_pos): Ignore a static
9227 composition starting before CHARPOS (Bug#8915).
9229 * xdisp.c (handle_composition_prop): Likewise.
9231 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9233 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9236 2011-07-07 Kenichi Handa <handa@m17n.org>
9238 * character.h (unicode_category_t): New enum type.
9240 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9241 (Qchar_code_property_table): New variable.
9242 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9243 (UNIPROP_COMPRESSED_FORM_P): New macros.
9244 (char_table_ascii): Uncompress the compressed values.
9245 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9246 Uncompress the compressed values.
9247 (sub_char_table_ref_and_range): Likewise.
9248 (char_table_ref_and_range): Uncompress the compressed values.
9249 (sub_char_table_set): New arg is_uniprop. Callers changed.
9250 Uncompress the compressed values.
9251 (sub_char_table_set_range): Args changed. Callers changed.
9252 (char_table_set_range): Adjuted for the above change.
9253 (map_sub_char_table): Delete args default_val and parent. Add arg
9254 top. Give decoded values to a Lisp function.
9255 (map_char_table): Adjust for the above change. Give decoded
9256 values to a Lisp function. Gcpro more variables.
9257 (uniprop_table_uncompress)
9258 (uniprop_decode_value_run_length): New functions.
9259 (uniprop_decoder, uniprop_decoder_count): New variables.
9260 (uniprop_get_decoder, uniprop_encode_value_character)
9261 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9263 (uniprop_encoder, uniprop_encoder_count): New variables.
9264 (uniprop_get_encoder, uniprop_table)
9265 (Funicode_property_table_internal, Fget_unicode_property_internal)
9266 (Fput_unicode_property_internal): New functions.
9267 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9268 Sunicode_property_table_internal, Sget_unicode_property_internal,
9269 and Sput_unicode_property_internal. Defvar_lisp
9270 char-code-property-alist.
9272 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9273 Vunicode_category_table.
9275 * font.c (font_range): Adjust for the change of
9276 Vunicode_category_table.
9278 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9280 * m/iris4d.h: Remove file, move contents ...
9281 * s/irix6-5.h: ... here.
9283 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9285 Remove unportable assumption about struct layout (Bug#8884).
9286 * alloc.c (mark_buffer):
9287 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9288 (clone_per_buffer_values): Don't assume that
9289 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9290 This isn't true in general, and it's particularly not true
9291 if Emacs is configured with --with-wide-int.
9292 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9293 New macros, used in the buffer.c change.
9295 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9297 * xsettings.c: Use both GConf and GSettings if both are available.
9298 (store_config_changed_event): Add comment.
9299 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9300 (store_tool_bar_style_changed): New functions.
9301 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9302 (struct xsettings): Move font inside HAVE_XFT.
9303 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9304 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9305 Move inside HAVE_XFT.
9306 (something_changed_gsettingsCB): Rename from something_changedCB.
9307 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9309 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9310 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9311 (something_changed_gconfCB): Rename from something_changedCB.
9312 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9313 (parse_settings): Move check for font inside HAVE_XFT.
9314 (read_settings, apply_xft_settings): Add comment.
9315 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9316 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9317 call store_font_name_changed.
9318 (xft_settings_event): Add comment.
9319 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9320 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9321 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9322 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9323 (xsettings_initialize): Call init_gsettings last.
9324 (xsettings_get_system_font, xsettings_get_system_normal_font):
9327 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9329 Random fixes. E.g., (random) never returned negative values.
9330 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9331 subseconds part to the entropy, as that's a bit more random.
9332 Prefer signed to unsigned, since the signedness doesn't matter and
9333 in general we prefer signed. When given a limit, use a
9334 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9335 latter isn't right if USE_2_TAGS_FOR_INTS.
9336 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9337 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9339 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9341 * textprop.c (text_property_stickiness):
9342 Obey Vtext_property_default_nonsticky.
9343 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9344 * w32fns.c (syms_of_w32fns):
9345 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9347 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9349 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9350 This is more efficient than Ffile_directory_p and avoids a minor race.
9352 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9354 * buffer.c (Foverlay_put): Say what the return value is
9357 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9358 is a directory before asking whether to use the file name
9360 (barf_or_query_if_file_exists): Make the "File is a directory"
9361 error be more correct.
9363 * fns.c (Frequire): Remove the mention of the .gz files, since
9364 that's installation-specific, but keep the mention of
9365 `get-load-suffixes'.
9367 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9369 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9370 Report string overflow if the output is too long.
9372 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9374 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9375 (syms_of_gnutls): Remove duplicate DEFSYM for
9376 Qgnutls_bootprop_verify_hostname_error, an error for
9377 Qgnutls_bootprop_verify_error (which is no longer used).
9379 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9380 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9381 Also (re)move comments that are misplaced or no longer relevant.
9383 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9385 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9387 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9389 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9390 and background color parameters if they have been changed.
9392 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9394 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9396 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9398 * xsettings.c (SYSTEM_FONT): Define only when used.
9399 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9401 * keymap.c (access_keymap_1): Now static.
9403 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9405 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9406 leave any prefix arg for the up event (Bug#1586).
9408 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9410 * lread.c (syms_of_lread): Mention single symbols defined by
9411 `defvar' or `defconst' (bug#7154).
9413 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9414 (Frequire): Mention get-load-suffixes.
9416 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9418 * window.h (window): Remove clone_number slot.
9419 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9421 (make_parent_window, make_window, saved_window)
9422 (Fset_window_configuration, save_window_save): Don't deal with
9424 * buffer.c (Qclone_number): Remove declaration.
9425 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9427 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9429 Add multiple inheritance to keymaps.
9430 * keymap.c (Fmake_composed_keymap): New function.
9431 (Fset_keymap_parent): Simplify.
9432 (fix_submap_inheritance): Remove.
9433 (access_keymap_1): New function extracted from access_keymap to handle
9434 embedded parents and handle lists of maps.
9435 (access_keymap): Use it.
9436 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9437 (Fcopy_keymap): Handle embedded parents.
9438 (Fcommand_remapping, define_as_prefix): Simplify.
9439 (Fkey_binding): Simplify.
9440 (syms_of_keymap): Move minibuffer-local-completion-map,
9441 minibuffer-local-filename-completion-map,
9442 minibuffer-local-must-match-map, and
9443 minibuffer-local-filename-must-match-map to Elisp.
9444 (syms_of_keymap): Defsubr make-composed-keymap.
9445 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9446 (parse_menu_item): Trivial simplification.
9448 2011-07-01 Glenn Morris <rgm@gnu.org>
9450 * Makefile.in (SETTINGS_LIBS): Fix typo.
9452 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9454 * coding.c (Fencode_coding_string): Record the last coding system
9455 used, as the function doc string says (bug#8738).
9457 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9459 * xsettings.c (store_monospaced_changed): Take new font as arg and
9460 check for change against current_mono_font.
9461 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9462 (emacs_settings_constructor, emacs_settings_get_property)
9463 (emacs_settings_set_property, emacs_settings_class_init)
9464 (emacs_settings_init, gsettings_obj): Remove.
9465 (something_changedCB): New function for HAVE_GSETTINGS.
9466 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9467 with value as argument.
9468 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9469 g_settings_new (Bug#8967). Do not create gsettings_obj.
9470 Remove calls to g_settings_bind. Connect something_changedCB to
9473 * xgselect.c: Add defined (HAVE_GSETTINGS).
9474 (xgselect_initialize): Ditto.
9476 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9477 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9480 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9482 * eval.c (struct backtrace): Simplify and port the data structure.
9483 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9484 signed bit field, as this assumption is not portable and it makes
9485 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9486 "char debug_on_exit : 1" as this is not portable either; instead,
9487 use the portable "unsigned int debug_on_exit : 1". Remove unused
9488 member evalargs. Remove obsolete comments about cc bombing out.
9490 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9492 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9493 Let HAVE_GSETTINGS override HAVE_GCONF.
9494 (store_monospaced_changed): New function.
9495 (EMACS_SETTINGS): A new type derived from GObject to handle
9496 GSettings notifications.
9497 (emacs_settings_constructor, emacs_settings_get_property)
9498 (emacs_settings_set_property, emacs_settings_class_init):
9500 (gsettings_client, gsettings_obj): New variables.
9501 (GSETTINGS_SCHEMA): New define.
9502 (something_changedCB): Call store_monospaced_changed.
9503 (init_gsettings): New function.
9504 (xsettings_initialize): Call init_gsettings.
9505 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9508 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9511 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9513 * window.c (resize_root_window, grow_mini_window)
9514 (shrink_mini_window): Rename Qresize_root_window to
9515 Qwindow_resize_root_window and Qresize_root_window_vertically to
9516 Qwindow_resize_root_window_vertically.
9518 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9520 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9522 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9524 * makefile.w32-in: Redesign dependencies so they reflect more
9525 clearly which files are directly included by each source file,
9526 and not through other includes.
9528 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9530 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9531 (sort_overlays, overlay_strings): When an overlay's clone number
9532 matches the window's clone number process the overlay even if
9533 the overlay's window property doesn't match the current window.
9535 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9536 (Fwindow_hchild): Rename to Fwindow_left_child.
9537 (Fwindow_next): Rename to Fwindow_next_sibling.
9538 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9539 (resize_window_check): Rename to window_resize_check.
9540 (resize_window_apply): Rename to window_resize_apply.
9541 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9542 (Fdelete_other_windows_internal, resize_frame_windows)
9543 (Fsplit_window_internal, Fdelete_window_internal)
9544 (grow_mini_window, shrink_mini_window)
9545 (Fresize_mini_window_internal): Fix callers accordingly.
9547 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9549 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9550 (emacs_fixed_set_min_size): Remove.
9551 (emacs_fixed_new): Take frame as argument.
9553 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9554 (_EmacsFixedPrivate): Remove minwidth/height.
9555 Add struct frame *f.
9556 (emacs_fixed_init): Initialize priv->f.
9557 (get_parent_class, emacs_fixed_set_min_size): Remove.
9558 (emacs_fixed_new): Set priv->f to argument.
9559 (emacs_fixed_get_preferred_width)
9560 (emacs_fixed_get_preferred_height): Use min_width/height from
9561 frames size_hint to set minimum and natural (Bug#8919).
9562 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9563 and use min_width/height from frames size_hint to set
9564 min_width/height (Bug#8919).
9566 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9567 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9570 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9572 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9573 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9576 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9578 * process.c (wait_reading_process_output): Bypass select if
9579 waiting for a cell while ignoring keyboard input, and input is
9580 pending. Suggested by Jan Djärv (Bug#8869).
9582 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9584 Use gnulib's dup2 module instead of rolling our own.
9585 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9587 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9589 * dispnew.c (scrolling_window): Before scrolling, turn off a
9590 mouse-highlight in the window being scrolled.
9592 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9594 Move DEFSYM to lisp.h and use everywhere.
9596 * character.h (DEFSYM): Move declaration...
9597 * lisp.h (DEFSYM): ...here.
9603 * w32select.c: Don't include character.h.
9605 * alloc.c (syms_of_alloc):
9606 * buffer.c (syms_of_buffer):
9607 * bytecode.c (syms_of_bytecode):
9608 * callint.c (syms_of_callint):
9609 * casefiddle.c (syms_of_casefiddle):
9610 * casetab.c (init_casetab_once):
9611 * category.c (init_category_once, syms_of_category):
9612 * ccl.c (syms_of_ccl):
9613 * cmds.c (syms_of_cmds):
9614 * composite.c (syms_of_composite):
9615 * dbusbind.c (syms_of_dbusbind):
9616 * dired.c (syms_of_dired):
9617 * dispnew.c (syms_of_display):
9618 * doc.c (syms_of_doc):
9619 * editfns.c (syms_of_editfns):
9620 * emacs.c (syms_of_emacs):
9621 * eval.c (syms_of_eval):
9622 * fileio.c (syms_of_fileio):
9623 * fns.c (syms_of_fns):
9624 * frame.c (syms_of_frame):
9625 * fringe.c (syms_of_fringe):
9626 * insdel.c (syms_of_insdel):
9627 * keymap.c (syms_of_keymap):
9628 * lread.c (init_obarray, syms_of_lread):
9629 * macros.c (syms_of_macros):
9630 * msdos.c (syms_of_msdos):
9631 * print.c (syms_of_print):
9632 * process.c (syms_of_process):
9633 * search.c (syms_of_search):
9634 * sound.c (syms_of_sound):
9635 * syntax.c (init_syntax_once, syms_of_syntax):
9636 * terminal.c (syms_of_terminal):
9637 * textprop.c (syms_of_textprop):
9638 * undo.c (syms_of_undo):
9639 * w32.c (globals_of_w32):
9640 * window.c (syms_of_window):
9641 * xdisp.c (syms_of_xdisp):
9642 * xfaces.c (syms_of_xfaces):
9643 * xfns.c (syms_of_xfns):
9644 * xmenu.c (syms_of_xmenu):
9645 * xsettings.c (syms_of_xsettings):
9646 * xterm.c (syms_of_xterm): Use DEFSYM.
9648 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9650 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9652 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9654 Integer and buffer overflow fixes (Bug#8873).
9656 * print.c (printchar, strout): Check for string overflow.
9657 (PRINTPREPARE, printchar, strout):
9658 Don't set size unless allocation succeeds.
9660 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9661 for sizes. Check for string overflow more accurately.
9662 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9664 * macros.c: Integer and buffer overflow fixes.
9665 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9666 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9667 Use ptrdiff_t, not int, for sizes.
9668 Don't increment bufsize until after realloc succeeds.
9669 Check for size-calculation overflow.
9670 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9672 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9674 * lread.c: Integer overflow fixes.
9675 (read_integer): Radix is now EMACS_INT, not int,
9676 to improve quality of diagnostics for out-of-range radices.
9677 Calculate buffer size correctly for out-of-range radices.
9678 (read1): Check for integer overflow in radices, and in
9679 read-circle numbers.
9680 (read_escape): Avoid int overflow.
9681 (Fload, openp, read_buffer_size, read1)
9682 (substitute_object_recurse, read_vector, read_list, map_obarray):
9683 Use ptrdiff_t, not int, for sizes.
9684 (read1): Use EMACS_INT, not int, for sizes.
9685 Check for size overflow.
9687 * image.c (cache_image): Check for size arithmetic overflow.
9689 * lread.c: Integer overflow issues.
9690 (saved_doc_string_size, saved_doc_string_length)
9691 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9692 Now ptrdiff_t, not int.
9693 (read1): Don't assume doc string length fits in int. Check for
9694 out-of-range doc string lengths.
9695 (read_list): Don't assume file position fits in int.
9696 (read_escape): Check for hex character overflow.
9698 2011-06-22 Leo Liu <sdl.web@gmail.com>
9700 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9701 Move to minibuffer.el.
9703 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9705 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9706 The following patches are for when GLYPH_DEBUG && !XASSERT.
9707 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9708 * dispnew.c (flush_stdout):
9709 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9710 Mark as externally visible.
9711 * dispnew.c (check_window_matrix_pointers): Now static.
9712 * dispnew.c (window_to_frame_vpos):
9713 * xfns.c (unwind_create_frame):
9714 * xterm.c (x_check_font): Remove unused local.
9715 * scroll.c (CHECK_BOUNDS):
9716 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9717 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9718 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9719 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9720 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9722 (debug_method_add): Use va_list and vsprintf rather than relying
9723 on undefined behavior with wrong number of arguments.
9724 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9725 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9726 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9727 since we're not interested in debugging glyphs with old libraries.
9728 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9729 GCC 4.6.0's static checking.
9731 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9733 Integer overflow and signedness fixes (Bug#8873).
9734 A few related buffer overrun fixes, too.
9736 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9738 * dispextern.h (struct face.stipple):
9739 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9740 (x_bitmap_mask, x_allocate_bitmap_record)
9741 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9742 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9743 (x_create_bitmap_from_xpm_data):
9744 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9745 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9747 * xfaces.c (load_pixmap):
9748 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9749 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9750 (.bitmaps_last, struct x_output.icon_bitmap):
9751 Use ptrdiff_t, not int, for bitmap indexes.
9752 (x_allocate_bitmap_record): Check for size overflow.
9753 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9755 Use ptrdiff_t, not int, for overlay counts.
9756 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9757 * editfns.c (overlays_around, get_pos_property):
9758 * textprop.c (get_char_property_and_overlay):
9759 * xdisp.c (next_overlay_change, note_mouse_highlight):
9760 * xfaces.c (face_at_buffer_position):
9761 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9762 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9763 (Fnext_overlay_change, Fprevious_overlay_change)
9764 (mouse_face_overlay_overlaps, Foverlays_in):
9765 Use ptrdiff_t, not int, for sizes.
9766 (overlays_at, overlays_in): Check for size-calculation overflow.
9768 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9770 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9771 (x_session_initialize): Do not assume string length fits in int.
9773 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9774 This is unlikely, but can occur if DPI is outlandish.
9776 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9777 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9779 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9780 * xrdb.c (magic_file_p, search_magic_path):
9781 Omit last arg SUFFIX; it was always 0. All callers changed.
9782 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9784 * xfont.c (xfont_match): Avoid need for strlen.
9786 * xfns.c: Don't assume strlen fits in int.
9787 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9789 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9790 not unsigned long, as we prefer signed integers. All callers changed.
9791 Detect integer overflow in repeat count.
9792 (message_dolog): Don't assume print length fits in 39 bytes.
9793 (display_mode_element): Don't assume strlen fits in int.
9795 * termcap.c: Don't assume sizes fit in int and never overflow.
9796 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9797 (gobble_line): Check for size-calculation overflow.
9799 * minibuf.c (Fread_buffer):
9800 * lread.c (intern, intern_c_string):
9801 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9802 Don't assume string length fits in int.
9804 * keyboard.c (parse_tool_bar_item):
9805 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9807 * font.c: Don't assume string length fits in int.
9808 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9809 Use ptrdiff_t, not int.
9810 (font_intern_prop): Don't assume string length fits in int.
9811 Don't assume integer property fits in fixnum.
9812 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9814 * filelock.c: Fix some buffer overrun and integer overflow issues.
9815 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9816 Reformulate so as not to need the command string.
9817 Invoke gzip -cd rather than gunzip, as it's more portable.
9818 (lock_info_type, lock_file_1, lock_file):
9819 Don't assume pid_t and time_t fit in unsigned long.
9820 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9821 (current_lock_owner): Prefer signed type for sizes.
9822 Use memcpy, not strncpy, where memcpy is what is really wanted.
9823 Don't assume (via atoi) that time_t and pid_t fit in int.
9824 Check for time_t and/or pid_t out of range, e.g., via a network share.
9825 Don't alloca where an auto var works fine.
9827 * fileio.c: Fix some integer overflow issues.
9828 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9829 Don't assume string length fits in int.
9830 (directory_file_name): Don't assume string length fits in long.
9831 (make_temp_name): Don't assume pid fits in int, or that its print
9832 length is less than 20.
9834 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9836 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9838 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9840 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9841 We prefer signed integers, even for size calculations.
9843 * emacs.c: Don't assume string length fits in 'int'.
9844 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9845 (main): Don't invoke strlen when not needed.
9847 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9848 (XD_DEBUG_MESSAGE): Don't waste a byte.
9850 * callproc.c (getenv_internal_1, getenv_internal)
9852 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9854 * lread.c (invalid_syntax): Omit length argument.
9855 All uses changed. This doesn't fix a bug, but it simplifies the
9856 code away from its former Hollerith-constant appearance, and it's
9857 one less 'int' to worry about when looking at integer-overflow issues.
9858 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9860 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9861 This didn't break anything, but it didn't help either.
9862 It's confusing to put a bogus integer in a place where the actual
9863 value does not matter.
9864 (LIST_END_P): Remove unused macro and its bogus comment.
9865 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9867 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9868 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9870 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9871 We prefer signed types, and the value cannot exceed the EMACS_INT
9872 range anyway (because otherwise the length would not be representable).
9873 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9874 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9875 This avoids a GCC warning when WIDE_EMACS_INT.
9877 * indent.c (sane_tab_width): New function.
9878 (current_column, scan_for_column, Findent_to, position_indentation)
9879 (compute_motion): Use it. This is just for clarity.
9880 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9882 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9884 * lisp.h (lint_assume): New macro.
9885 * composite.c (composition_gstring_put_cache):
9886 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9888 * editfns.c, insdel.c:
9889 Omit unnecessary forward decls, to simplify future changes.
9891 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9893 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9895 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9896 Use much-faster test for byte-length change.
9897 Don't assume string byte-length fits in 'int'.
9898 Check that character arg fits in 'int'.
9899 (mapcar1): Declare byte as byte, for clarity.
9901 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9903 * fns.c (concat): Catch string overflow earlier.
9904 Do not rely on integer wraparound.
9906 * dispextern.h (struct it.overlay_strings_charpos)
9907 (struct it.selective): Now EMACS_INT, not int.
9908 * xdisp.c (forward_to_next_line_start)
9909 (back_to_previous_visible_line_start)
9910 (reseat_at_next_visible_line_start, next_element_from_buffer):
9911 Don't arbitrarily truncate the value of 'selective' to int.
9913 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9915 * composite.c: Don't truncate sizes to 'int'.
9916 (composition_gstring_p, composition_reseat_it)
9917 (composition_adjust_point): Use EMACS_INT, not int.
9918 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9919 not EMACS_UINT, for indexes.
9921 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9923 * buffer.c: Include <verify.h>.
9924 (struct sortvec.priority, struct sortstr.priority):
9925 Now EMACS_INT, not int.
9926 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9927 (struct sortstr.size, record_overlay_string)
9928 (struct sortstrlist.size, struct sortlist.used):
9929 Don't truncate size to int.
9930 (record_overlay_string): Check for size-calculation overflow.
9931 (init_buffer_once): Check at compile-time, not run-time.
9933 2011-06-22 Jim Meyering <meyering@redhat.com>
9935 Don't leak an XBM-image-sized buffer
9936 * image.c (xbm_load): Free the image buffer after using it.
9938 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9941 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9942 that Sun C diagnosed.
9943 * fns.c (secure_hash): Fix pointer signedness issue.
9944 * intervals.c (static_offset_intervals): New function.
9945 (offset_intervals): Use it.
9947 2011-06-21 Leo Liu <sdl.web@gmail.com>
9950 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9953 * fns.c (secure_hash): Rename from crypto_hash_function and change
9954 the first arg to accept symbols.
9955 (Fsecure_hash): New primitive.
9956 (syms_of_fns): New symbols.
9958 2011-06-20 Deniz Dogan <deniz@dogan.se>
9960 * process.c (Fset_process_buffer): Clarify return value in
9963 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9965 * dispnew.c (add_window_display_history): Use BVAR.
9967 * xdisp.c (debug_method_add): Use BVAR.
9968 (check_window_end, dump_glyph_matrix, dump_glyph)
9969 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9971 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9974 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9975 check till after the cache is created in init_frame_faces.
9977 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9979 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9981 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9983 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9984 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9985 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9987 Improve buffer-overflow checking (Bug#8873).
9988 * fileio.c (Finsert_file_contents):
9989 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9990 Remove the old (too-loose) buffer overflow checks.
9991 They weren't needed, since make_gap checks for buffer overflow.
9992 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9993 The old code merely checked for Emacs fixnum overflow, and relied
9994 on undefined (wraparound) behavior. The new code avoids undefined
9995 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9997 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9998 Tune. Don't use wider integers than needed. Don't use alloca.
9999 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10001 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10003 * insdel.c, lisp.h (buffer_overflow): New function.
10004 (insert_from_buffer_1, replace_range, replace_range_2):
10005 * insdel.c (make_gap_larger):
10006 * editfns.c (Finsert_char):
10007 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10009 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10011 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10013 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10015 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10016 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10018 * fileio.c: Don't assume EMACS_INT fits in off_t.
10019 (emacs_lseek): New static function.
10020 (Finsert_file_contents, Fwrite_region): Use it.
10021 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10023 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10025 * fns.c: Don't overflow int when computing a list length.
10026 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10027 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10028 truncation on 64-bit hosts. Check for QUIT every
10029 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10030 faster and is responsive enough.
10031 (Flength): Report an error instead of overflowing an integer.
10032 (Fsafe_length): Return a float if the value is not representable
10033 as a fixnum. This shouldn't happen except in contrived situations.
10034 (Fnthcdr, Fsort): Don't assume list length fits in int.
10035 (Fcopy_sequence): Don't assume vector length fits in int.
10037 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10038 (header_size, word_size): New constants.
10039 (allocate_vectorlike): Don't check size overflow here.
10040 (allocate_vector): Check it here instead, since this is the only
10041 caller of allocate_vectorlike that could cause overflow.
10042 Check that the new vector's length is representable as a fixnum.
10044 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10045 The previous code was bogus. For example, next_almost_prime (32)
10046 returned 39, which is undesirable as it is a multiple of 3; and
10047 next_almost_prime (24) returned 25, which is a multiple of 5 so
10048 why was the code bothering to check for multiples of 7?
10050 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10052 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10054 Variadic C functions now count arguments with ptrdiff_t.
10055 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10056 Back then I didn't know that the Emacs coding style prefers signed int.
10057 Also, in the meantime I found a few more instances where arguments
10058 were being counted with int, which may truncate counts on 64-bit
10059 machines, or EMACS_INT, which may be unnecessarily wide.
10060 * lisp.h (struct Lisp_Subr.function.aMANY)
10061 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10062 Arg counts are now ptrdiff_t, not size_t.
10063 All variadic functions and their callers changed accordingly.
10064 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10065 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10066 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10067 * callint.c (Fcall_interactively): Check arg count for overflow,
10068 to avoid potential buffer overrun. Use signed char, not 'int',
10069 for 'varies' array, so that we needn't bother to check its size
10070 calculation for overflow.
10071 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10072 * eval.c (apply_lambda):
10073 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10074 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10075 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10077 * callint.c (Fcall_interactively): Don't use index var as event count.
10079 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10080 * mem-limits.h (SIZE): Remove; no longer used.
10082 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10084 Remove unnecessary casts.
10085 * xterm.c (x_term_init):
10086 * xfns.c (x_set_border_pixel):
10087 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10088 These aren't needed now that we assume ANSI C.
10090 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10091 It's more likely to cause problems (due to unsigned overflow)
10094 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10096 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10098 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10100 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10102 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10104 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10106 GLYPH_CODE_FACE returns EMACS_INT, not int.
10107 * dispextern.h (merge_faces):
10108 * xfaces.c (merge_faces):
10109 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10110 Don't assume EMACS_INT fits in int.
10112 * character.h (CHAR_VALID_P): Remove unused parameter.
10113 * fontset.c, lisp.h, xdisp.c: All uses changed.
10115 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10117 * fns.c (concat): Minor tuning based on overflow analysis.
10118 This doesn't fix any bugs. Use int to hold character, instead
10119 of constantly refetching from Emacs object. Use XFASTINT, not
10120 XINT, for value known to be a character. Don't bother comparing
10121 a single byte to 0400, as it's always less.
10123 * floatfns.c (Fexpt):
10124 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10126 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10129 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10131 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10132 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10133 incorrectly succeed when S was a string, because 4294967386 was
10134 truncated before it was used.
10136 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10137 Otherwise, an out-of-range integer could cause undefined behavior
10140 * composite.c: Use int, not EMACS_INT, for characters.
10141 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10142 EMACS_INT, for values that are known to be in character range.
10143 This doesn't fix any bugs but is the usual style inside Emacs and
10144 may generate better code on 32-bit machines.
10146 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10147 This is for reasons similar to the recent CHAR_STRING fix.
10148 * charset.c (Fencode_char): Check that character arg is actually
10149 a character. Pass an int to ENCODE_CHAR.
10150 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10151 wider than 'int', as a compile-time check to prevent future regressions
10154 * character.c (char_string): Remove unnecessary casts.
10156 Make sure a 64-bit char is never passed to CHAR_STRING.
10157 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10158 by silently ignoring the top 32 bits, allowing some values
10159 that were far too large to be valid characters.
10160 * character.h: Include <verify.h>.
10161 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10162 arguments are no wider than unsigned, as a compile-time check
10163 to prevent future regressions in this area.
10165 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10166 (Fsubst_char_in_region):
10168 * xdisp.c (decode_mode_spec_coding):
10169 Adjust to CHAR_STRING's new requirement.
10170 * editfns.c (Finsert_char, Fsubst_char_in_region):
10171 * fns.c (concat): Check that character args are actually
10172 characters. Without this test, these functions did the wrong
10173 thing with wildly out-of-range values on 64-bit hosts.
10175 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10176 These casts should not be needed on 32-bit hosts, either.
10177 * keyboard.c (read_char):
10178 * lread.c (Fload): Remove casts to unsigned.
10180 * lisp.h (UNSIGNED_CMP): New macro.
10181 This fixes comparison bugs on 64-bit hosts.
10182 (ASCII_CHAR_P): Use it.
10183 * casefiddle.c (casify_object):
10184 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10185 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10186 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10187 * dispextern.h (FACE_FROM_ID):
10188 * keyboard.c (read_char): Use UNSIGNED_CMP.
10190 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10191 not to EMACS_INT, to avoid GCC warning.
10193 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10195 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10196 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10197 isn't needed on 32-bit machines.
10199 * buffer.c (Fgenerate_new_buffer_name):
10200 Use EMACS_INT for count, not int.
10201 (advance_to_char_boundary): Return EMACS_INT, not int.
10203 * data.c (Qcompiled_function): Now static.
10205 * window.c (window_body_lines): Now static.
10207 * image.c (gif_load): Rename local to avoid shadowing.
10209 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10210 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10211 * alloc.c (make_save_value): Integer argument is now of type
10212 ptrdiff_t, not int.
10213 (mark_object): Use ptrdiff_t, not int.
10214 * lisp.h (pD): New macro.
10215 * print.c (print_object): Use it.
10217 * alloc.c: Use EMACS_INT, not int, to count objects.
10218 (total_conses, total_markers, total_symbols, total_vector_size)
10219 (total_free_conses, total_free_markers, total_free_symbols)
10220 (total_free_floats, total_floats, total_free_intervals)
10221 (total_intervals, total_strings, total_free_strings):
10222 Now EMACS_INT, not int. All uses changed.
10223 (Fgarbage_collect): Compute overall total using a double, so that
10224 integer overflow is less likely to be a problem. Check for overflow
10225 when converting back to an integer.
10226 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10227 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10228 These were 'int' variables that could overflow on 64-bit hosts;
10229 they were never used, so remove them instead of repairing them.
10230 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10231 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10232 Previously, this ceilinged at INT_MAX, but that doesn't work on
10234 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10236 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10237 (allocate_vectorlike): Check for ptrdiff_t overflow.
10238 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10239 when a (possibly-narrower) signed value would do just as well.
10240 We prefer using signed arithmetic, to avoid comparison confusion.
10242 * alloc.c: Catch some string size overflows that we were missing.
10243 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10244 for convenience in STRING_BYTES_MAX.
10245 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10246 The definition here is exact; the one in lisp.h was approximate.
10247 (allocate_string_data): Check for string overflow. This catches
10248 some instances we weren't catching before. Also, it catches
10249 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10250 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10251 and ptrdiff_t and EMACS_INT are both 64 bits.
10253 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10254 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10255 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10257 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10259 * alloc.c (Fmake_string): Check for out-of-range init.
10261 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10263 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10265 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10267 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10268 xg_get_default_scrollbar_width.
10270 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10271 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10272 (style_changed_cb): Call update_theme_scrollbar_width and call
10273 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10274 all frames (Bug#8505).
10275 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10276 Call gtk_window_set_resizable if HAVE_GTK3.
10277 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10278 and height if HAVE_GTK3 (Bug#8505).
10279 (scroll_bar_width_for_theme): New variable.
10280 (update_theme_scrollbar_width): New function.
10281 (xg_get_default_scrollbar_width): Move code to
10282 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10283 (xg_initialize): Call update_theme_scrollbar_width.
10285 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10287 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10289 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10291 * frame.c (make_frame): Call other_buffer_safely instead of
10294 * window.c (temp_output_buffer_show): Call display_buffer with
10295 second argument Vtemp_buffer_show_specifiers and reset latter
10296 immediately after the call.
10297 (Vtemp_buffer_show_specifiers): New variable.
10298 (auto_window_vscroll_p, next_screen_context_lines)
10299 (Vscroll_preserve_screen_position): Remove leading asterisks from
10302 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10304 Fix minor problems found by GCC 4.6.0 static checking.
10305 * buffer.c (Qclone_number): Remove for now, as it's unused.
10306 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10307 (record_buffer): Remove unused local.
10308 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10309 (set_frame_buffer_list): Remove; unused.
10310 * frame.h (other_visible_frames): Remove decl.
10311 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10312 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10313 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10315 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10316 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10317 Define only if HAVE_GPM.
10318 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10319 (update_hints_inhibit): Remove; never set. All uses removed.
10320 * widgetprv.h (emacsFrameClassRec): Remove decl.
10321 * window.c (delete_deletable_window): Now returns void, since it
10322 wasn't returning anything.
10323 (compare_window_configurations): Remove unused locals.
10324 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10325 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10326 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10327 the same widths as pointers. This follows up on the 2011-05-06 patch.
10328 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10329 * xterm.h: Likewise.
10330 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10332 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10334 * makefile.w32-in: Update dependencies.
10335 (LISP_H): Add lib/intprops.h.
10337 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10339 * image.c (gif_load): Add animation frame delay to the metadata.
10340 (syms_of_image): Use DEFSYM. New symbol `delay'.
10342 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10344 * window.c (delete_deletable_window): Re-add.
10345 (Fset_window_configuration): Rewrite to handle dead buffers and
10346 consequently deletable windows.
10347 (window_tree, Fwindow_tree): Remove. Supply functionality in
10349 (compare_window_configurations): Simplify code.
10351 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10353 * image.c (imagemagick_load_image): Fix type mismatch.
10354 (Fimagemagick_types): Likewise.
10356 * window.h (replace_buffer_in_windows): Declare.
10358 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10360 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10361 Qclone_number. Remove external declaration of Qdelete_window.
10362 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10364 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10365 Run Qbuffer_list_update_hook if allowed.
10366 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10367 buffer list implementation.
10368 (other_buffer_safely): New function.
10369 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10370 calls to replace_buffer_in_windows and
10371 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10373 (record_buffer): Inhibit quitting and rewrite using quittable
10374 functions. Run Qbuffer_list_update_hook if allowed.
10375 (Frecord_buffer, Funrecord_buffer): New functions.
10376 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10377 Move switch-to-buffer to window.el.
10378 (bury-buffer): Move to window.el.
10379 (Vbuffer_list_update_hook): New variable.
10381 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10384 * window.h (resize_frame_windows): Move up in code.
10385 (Fwindow_frame): Remove EXFUN.
10386 (replace_buffer_in_all_windows): Remove prototype.
10387 (replace_buffer_in_windows_safely): Add prototype.
10389 * window.c: Declare Qdelete_window static again. Move down
10390 declaration of select_count.
10391 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10392 (Fother_window): Move to window.el.
10393 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10394 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10395 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10397 (replace_buffer_in_windows): Implement by calling
10398 Qreplace_buffer_in_windows.
10399 (replace_buffer_in_all_windows): Remove with some functionality
10400 moved into replace_buffer_in_windows_safely.
10401 (replace_buffer_in_windows_safely): New function.
10402 (select_window_norecord, select_frame_norecord): Move in front
10403 of run_window_configuration_change_hook. Remove now obsolete
10405 (Fset_window_buffer): Rewrite doc-string.
10406 Call Qrecord_window_buffer.
10407 (keys_of_window): Move binding for other-window to window.el.
10409 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10411 * dispextern.h (struct image): Replace data member, whose int_val
10412 and ptr_val fields were not used by anything, with a single
10415 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10416 (gif_clear_image, gif_load, imagemagick_load_image)
10417 (gs_clear_image, gs_load): Callers changed.
10419 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10421 * buffer.h: Include <time.h>, for time_t.
10422 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10424 Fix minor problems found by static checking.
10426 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10428 Make identifiers static if they are not used in other modules.
10429 * data.c (Qcompiled_function, Qframe, Qvector):
10430 * image.c (QimageMagick, Qsvg):
10431 * minibuf.c (Qmetadata):
10432 * window.c (resize_window_check, resize_root_window): Now static.
10433 * window.h (resize_window_check, resize_root_window): Remove decls.
10435 * window.c (window_deletion_count, delete_deletable_window):
10437 (window_body_lines): Now static.
10438 (Fdelete_other_windows_internal): Mark vars as initialized.
10439 Make sure 'resize_failed' is initialized.
10440 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10441 (resize_window_apply): Remove unused local.
10442 * window.h (delete_deletable_window): Remove decl.
10444 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10445 (imagemagick_load_image): Fix pointer signedness problem by changing
10446 last arg from unsigned char * to char *. All uses changed.
10447 Also, fix a local for similar reasons.
10448 Remove unused locals. Remove locals to avoid shadowing.
10449 (fn_rsvg_handle_free): Remove; unused.
10450 (svg_load, svg_load_image): Fix pointer signedness problem.
10451 (imagemagick_load_image): Don't use garbage pointer image_wand.
10453 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10455 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10457 * image.c (gif_load): Fix omitted cast error introduced by
10460 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10462 * window.h (resize_proportionally, orig_total_lines)
10463 (orig_top_line): Remove from window structure.
10464 (set_window_height, set_window_width, change_window_heights)
10465 (Fdelete_window): Remove prototypes.
10466 (resize_frame_windows): Remove duplicate declaration.
10468 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10470 * window.h (resize_frame_windows, resize_window_check)
10471 (delete_deletable_window, resize_root_window)
10472 (resize_frame_windows): Declare prototypes.
10474 * window.c (resize_window_apply): Make definition be "static" to
10475 match the prototype.
10477 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10479 * window.c: Remove declarations of Qwindow_size_fixed,
10480 window_min_size_1, window_min_size_2, window_min_size,
10481 size_window, window_fixed_size_p, enlarge_window, delete_window.
10482 Remove static from declaration of Qdelete_window, it's
10483 temporarily needed by Fbury_buffer.
10484 (replace_window): Don't assign orig_top_line and
10486 (Fdelete_window, delete_window): Remove. Window deletion is
10487 handled by window.el.
10488 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10489 Replace Fdelete_window calls with calls to Qdelete_window.
10490 (Fdelete_other_windows): Remove. Deleting other windows is
10491 handled by window.el.
10492 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10493 handled in window.el.
10494 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10495 Window minimum sizes are handled in window.el.
10496 (shrink_windows, size_window, set_window_height)
10497 (set_window_width, change_window_heights, window_height)
10498 (window_width, CURBEG, CURSIZE, enlarge_window)
10499 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10500 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10501 handled in window.el.
10502 (make_dummy_parent): Rename to make_parent_window and give it a
10503 second argument horflag.
10504 (make_window): Don't set resize_proportionally any more.
10505 (Fsplit_window): Remove. Windows are split in window.el.
10506 (save_restore_action, save_restore_orig_size)
10507 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10508 Resize mini windows in window.el.
10509 (grow_mini_window, shrink_mini_window): Implement by calling
10510 Qresize_root_window_vertically, resize_window_check and
10511 resize_window_apply.
10512 (saved_window, Fset_window_configuration, save_window_save):
10513 Do not handle orig_top_line, orig_total_lines, and
10514 resize_proportionally.
10515 (window_min_height, window_min_width): Move to window.el.
10516 (keys_of_window): Move bindings for delete-other-windows,
10517 split-window, delete-window and enlarge-window to window.el.
10519 * buffer.c: Temporarily extern Qdelete_window.
10520 (Fbury_buffer): Temporarily call Qdelete_window instead of
10521 Fdelete_window (Fbury_buffer will move to window.el soon).
10523 * frame.c (set_menu_bar_lines_1): Remove code handling
10524 orig_top_line and orig_total_lines.
10526 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10527 set_window_height but set heights directly.
10528 (change_frame_size_1): Use resize_frame_windows.
10530 * xdisp.c (init_xdisp): Don't use set_window_height but set
10533 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10534 Use resize_frame_windows instead of change_window_heights and run
10535 run_window_configuration_change_hook.
10537 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10538 instead of change_window_heights and run
10539 run_window_configuration_change_hook.
10541 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10543 * window.c (replace_window): Rename second argument REPLACEMENT to
10544 NEW. New third argument SETFLAG. Rewrite.
10545 (delete_window, make_dummy_parent): Call replace_window with
10547 (window_list_1): Move down in code.
10548 (run_window_configuration_change_hook): Move set_buffer part
10549 before select_frame_norecord part in order to unwind correctly.
10550 Rename count1 to count.
10551 (recombine_windows, delete_deletable_window, resize_root_window)
10552 (Fdelete_other_windows_internal)
10553 (Frun_window_configuration_change_hook, make_parent_window)
10554 (resize_window_check, resize_window_apply, Fresize_window_apply)
10555 (resize_frame_windows, Fsplit_window_internal)
10556 (Fdelete_window_internal, Fresize_mini_window_internal):
10558 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10560 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10562 * window.h (window): Add some new members to window structure -
10563 normal_lines, normal_cols, new_total, new_normal, clone_number,
10564 splits, nest, prev_buffers, next_buffers.
10565 (WINDOW_TOTAL_SIZE): Move here from window.c.
10566 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10568 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10570 (make_dummy_parent): Set new members of windows structure.
10571 (make_window): Move down in code. Handle new members of window
10573 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10574 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10575 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10576 (Fset_window_prev_buffers, Fwindow_next_buffers)
10577 (Fset_window_next_buffers, Fset_window_clone_number):
10579 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10580 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10582 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10583 Argument WINDOW can be now internal window too.
10584 (Fwindow_use_time): Move up in code.
10585 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10586 Rewrite doc-string.
10587 (Fset_window_configuration, saved_window)
10588 (Fcurrent_window_configuration, save_window_save): Handle new
10589 members of window structure.
10590 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10591 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10592 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10593 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10594 Qget_mru_window, Qresize_root_window,
10595 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10596 Qauto_buffer_name; staticpro them.
10598 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10600 * window.c (Fwindow_total_size, Fwindow_left_column)
10601 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10602 (Fwindow_list_1): New functions.
10603 (window_box_text_cols): Replace with window_body_cols.
10604 (Fwindow_width, Fscroll_left, Fscroll_right):
10605 Use window_body_cols instead of window_box_text_cols.
10606 (delete_window, Fset_window_configuration):
10607 Call delete_all_subwindows with window as argument.
10608 (delete_all_subwindows): Take a window as argument and not a
10609 structure. Rewrite.
10610 (window_loop): Remove handling of GET_LRU_WINDOW and
10611 GET_LARGEST_WINDOW.
10612 (Fget_lru_window, Fget_largest_window): Move to window.el.
10614 * window.h: Extern window_body_cols instead of
10615 window_box_text_cols. delete_all_subwindows now takes a
10616 Lisp_Object as argument.
10618 * indent.c (compute_motion, Fcompute_motion):
10619 Use window_body_cols instead of window_box_text_cols.
10621 * frame.c (delete_frame): Call delete_all_subwindows with root
10622 window as argument.
10624 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10626 * fns.c (Fputhash): Document return value.
10628 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10630 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10632 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10634 Cons<->int and similar integer overflow fixes (Bug#8794).
10636 Check for overflow when converting integer to cons and back.
10637 * charset.c (Fdefine_charset_internal, Fdecode_char):
10638 Use cons_to_unsigned to catch overflow.
10639 (Fencode_char): Use INTEGER_TO_CONS.
10640 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10641 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10642 * data.c (long_to_cons, cons_to_long): Remove.
10643 (cons_to_unsigned, cons_to_signed): New functions.
10644 These signal an error for invalid or out-of-range values.
10645 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10646 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10647 * font.c (Ffont_variation_glyphs):
10648 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10649 * lisp.h: Include <intprops.h>.
10650 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10651 (cons_to_signed, cons_to_unsigned): New decls.
10652 (long_to_cons, cons_to_long): Remove decls.
10653 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10654 (Fprimitive_undo): Use CONS_TO_INTEGER.
10655 * xfns.c (Fx_window_property): Likewise.
10656 * xselect.c: Include <limits.h>.
10657 (x_own_selection, selection_data_to_lisp_data):
10658 Use INTEGER_TO_CONS.
10659 (x_handle_selection_request, x_handle_selection_clear)
10660 (x_get_foreign_selection, Fx_disown_selection_internal)
10661 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10662 (lisp_data_to_selection_data): Use cons_to_unsigned.
10663 (x_fill_property_data): Use cons_to_signed.
10664 Report values out of range.
10666 Check for buffer and string overflow more precisely.
10667 * buffer.h (BUF_BYTES_MAX): New macro.
10668 * lisp.h (STRING_BYTES_MAX): New macro.
10669 * alloc.c (Fmake_string):
10670 * character.c (string_escape_byte8):
10671 * coding.c (coding_alloc_by_realloc):
10672 * doprnt.c (doprnt):
10673 * editfns.c (Fformat):
10675 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10676 since they may not be the same number.
10677 * editfns.c (Finsert_char):
10678 * fileio.c (Finsert_file_contents):
10679 Likewise for BUF_BYTES_MAX.
10681 * image.c: Use ptrdiff_t, not int, for sizes.
10682 (slurp_file): Switch from int to ptrdiff_t.
10684 (slurp_file): Check that file size fits in both size_t (for
10685 malloc) and ptrdiff_t (for sanity and safety).
10687 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10688 if b->modtime has its maximal value.
10690 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10692 Don't assume time_t can fit into int.
10693 * buffer.h (struct buffer.modtime): Now time_t, not int.
10694 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10695 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10697 Minor fixes for signed vs unsigned integers.
10698 * character.h (MAYBE_UNIFY_CHAR):
10699 * charset.c (maybe_unify_char):
10700 * keyboard.c (read_char, reorder_modifiers):
10701 XINT -> XFASTINT, since the integer must be nonnegative.
10702 * ftfont.c (ftfont_spec_pattern):
10703 * keymap.c (access_keymap, silly_event_symbol_error):
10704 XUINT -> XFASTINT, since the integer must be nonnegative.
10705 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10706 since it makes no difference and we prefer signed.
10707 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10708 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10711 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10713 * window.h (Fwindow_frame): Declare.
10715 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10717 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10718 (SPARE_MEMORY): Always define.
10719 (LARGE_REQUEST): Remove.
10720 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10722 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10724 * lisp.h: Move EXFUNS for Fframe_root_window,
10725 Fframe_first_window and Fset_frame_selected_window to window.h.
10727 * window.h: Move EXFUNS for Fframe_root_window,
10728 Fframe_first_window and Fset_frame_selected_window here from
10731 * frame.c (Fwindow_frame, Fframe_first_window)
10732 (Fframe_root_window, Fframe_selected_window)
10733 (Fset_frame_selected_window): Move to window.c.
10734 (Factive_minibuffer_window): Move to minibuf.c.
10735 (Fother_visible_frames_p): New function.
10737 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10739 * window.c (decode_window, decode_any_window): Move up in code.
10740 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10741 (inhibit_frame_unsplittable): Remove unused variable.
10742 (Fwindow_buffer): Move up and rewrite doc-string.
10743 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10744 (Fwindow_prev): New functions.
10745 (Fwindow_frame): Move here from frame.c. Accept any window as
10747 (Fframe_root_window, Fframe_first_window)
10748 (Fframe_selected_window): Move here from frame.c. Accept frame
10749 or arbitrary window as argument. Update doc-strings.
10750 (Fminibuffer_window): Move up in code.
10751 (Fwindow_minibuffer_p): Move up in code and simplify.
10752 (Fset_frame_selected_window): Move here from frame.c.
10754 (Fselected_window, select_window, Fselect_window): Move up in
10755 code. Minor doc-string fixes.
10757 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10759 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10760 Do not assume that spare memory exists; that assumption is valid
10761 only if SYSTEM_MALLOC.
10762 (LARGE_REQUEST): New macro, so that the issue of large requests
10763 is separated from the issue of spare memory.
10765 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10767 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10770 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10772 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10775 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10777 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10779 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10781 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10782 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10784 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10786 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10788 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10790 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10791 (x_clipboard_manager_save): Add return value.
10792 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10793 New error handlers.
10794 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10795 Obey Vx_select_enable_clipboard_manager. Catch errors in
10796 x_clipboard_manager_save (Bug#8779).
10797 (Vx_select_enable_clipboard_manager): New variable.
10798 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10800 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10802 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10804 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10806 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10807 in the current matrix if keep_current_p is non-zero.
10809 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10811 * bidi.c (bidi_level_of_next_char): Fix last change.
10813 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10815 Support bidi reordering of text covered by display properties.
10817 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10818 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10819 (bidi_cache_search, bidi_cache_iterator_state)
10820 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10821 (bidi_level_of_next_char, bidi_move_to_visually_next):
10822 Support character positions inside a run of characters covered by a
10824 (bidi_paragraph_init, bidi_resolve_explicit_1)
10825 (bidi_level_of_next_char): Call bidi_fetch_char and
10826 bidi_fetch_char_advance instead of FETCH_CHAR and
10827 FETCH_CHAR_ADVANCE.
10828 (bidi_init_it): Initialize new members.
10829 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10831 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10832 instead of using explicit *_CHAR codes.
10833 (bidi_resolve_explicit, bidi_resolve_weak):
10834 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10835 bidirectional text is supported only in multibyte buffers.
10836 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10837 it to initialize the frame_window_p member of struct bidi_it.
10838 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10839 (bidi_resolve_explicit, bidi_resolve_weak)
10840 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10841 bidi_it->nchars is non-positive.
10842 (bidi_level_of_next_char): Don't try to lookup the cache for the
10843 next/previous character if nothing is cached there yet, or if we
10844 were just reseat()'ed to a new position.
10846 * xdisp.c (set_cursor_from_row): Set start and stop points
10847 according to the row's direction when priming the loop that looks
10848 for the glyph on which to display cursor.
10849 (single_display_spec_intangible_p): Function deleted.
10850 (display_prop_intangible_p): Reimplement to call
10851 handle_display_spec instead of single_display_spec_intangible_p.
10852 Accept 3 additional arguments needed by handle_display_spec.
10853 This fixes incorrect cursor motion across display property with complex
10854 values: lists, `(when COND...)' forms, etc.
10855 (single_display_spec_string_p): Support property values that are
10856 lists with the argument STRING its top-level element.
10857 (display_prop_string_p): Fix the condition for processing a
10858 property that is a list to be consistent with handle_display_spec.
10859 (handle_display_spec): New function, refactored from the
10860 last portion of handle_display_prop.
10861 (compute_display_string_pos): Accept additional argument
10862 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10863 value of a `display' property is a "replacing spec".
10864 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10865 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10866 the display property, but just return a value indicating whether
10867 the display property will replace the characters it covers.
10868 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10869 frame_window_p members of struct bidi_it.
10870 (compute_display_string_pos, compute_display_string_end):
10872 (push_it): Accept second argument POSITION, where pop_it should
10873 jump to continue iteration.
10874 (reseat_1): Initialize bidi_it.disp_pos.
10876 * keyboard.c (adjust_point_for_property): Adjust the call to
10877 display_prop_intangible_p to its new signature.
10879 * dispextern.h (struct bidi_it): New member frame_window_p.
10880 (bidi_init_it): Update prototypes.
10881 (display_prop_intangible_p): Update prototype.
10882 (compute_display_string_pos, compute_display_string_end):
10883 Declare prototypes.
10884 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10887 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10889 Malloc failure behavior now depends on size of allocation.
10890 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10891 * lisp.h: Change signatures accordingly.
10892 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10893 All callers changed. (Bug#8762)
10895 * gnutls.c: Use Emacs's memory allocators.
10896 Without this change, the gnutls library would invoke malloc etc.
10897 directly, which causes problems on non-SYNC_INPUT hosts, and which
10898 runs afoul of improving memory_full behavior. (Bug#8761)
10899 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10900 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10901 xfree instead of the default malloc, realloc, free.
10902 (Fgnutls_boot): No need to check for memory allocation failure,
10903 since xmalloc does that for us.
10905 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10906 * category.c (hash_get_category_set):
10907 * ccl.c (ccl_driver):
10908 * charset.c (Fdefine_charset_internal):
10909 * charset.h (struct charset.hash_index):
10910 * composite.c (get_composition_id, gstring_lookup_cache)
10911 (composition_gstring_put_cache):
10912 * composite.h (struct composition.hash_index):
10913 * dispextern.h (struct image.hash):
10914 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10915 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10916 (hashfn_equal, hashfn_user_defined, make_hash_table)
10917 (maybe_resize_hash_table, hash_lookup, hash_put)
10918 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10919 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10920 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10921 * image.c (make_image, search_image_cache, lookup_image)
10922 (xpm_put_color_table_h):
10923 * lisp.h (struct Lisp_Hash_Table):
10924 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10925 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10926 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10927 * alloc.c (allocate_vectorlike):
10928 Check for overflow in vector size calculations.
10929 * ccl.c (ccl_driver):
10930 Check for overflow when converting EMACS_INT to int.
10931 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10932 need to be updated by these changes.
10933 * fns.c (make_hash_table, maybe_resize_hash_table):
10934 Check for integer overflow with large hash tables.
10935 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10936 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10937 (SXHASH_REDUCE): New macro.
10938 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10939 Use it instead of discarding useful hash info with large hash values.
10940 (sxhash_float): New function.
10941 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10942 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10943 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10944 Rewrite to use FIXNUM_BITS, as this simplifies things.
10945 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10946 Adjust signatures to match updated version of code.
10947 (consing_since_gc): Now EMACS_INT, since a single hash table can
10948 use more than INT_MAX bytes.
10950 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10952 Make it possible to build with GCC-4.6+ -O2 -flto.
10954 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10956 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10958 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10959 Call minibuffer-inactive-mode.
10961 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10963 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10964 Update dependencies.
10966 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10968 * data.c (init_data): Remove code for UTS, this system is not
10971 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10973 Don't force ./temacs to start in terminal mode.
10975 * frame.c (make_initial_frame): Initialize faces in all cases, not
10976 only when CANNOT_DUMP is defined.
10977 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10979 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10981 * dispnew.c (add_window_display_history): Use const for the string
10982 pointer. Remove declaration, not needed.
10984 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10986 Use 'inline', not 'INLINE'.
10987 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10988 * alloc.c, fontset.c (INLINE): Remove.
10989 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10990 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10991 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10992 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10993 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10997 Make it possible to run ./temacs.
10999 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11000 syms_of_callproc does the same thing. Remove test for
11001 "initialized", do it in the caller.
11002 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11004 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11006 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11007 (read_minibuf): Use get_minibuffer.
11008 (syms_of_minibuf): Use DEFSYM.
11009 (Qmetadata): New var.
11010 * data.c (Qbuffer): Don't make it static.
11011 (syms_of_data): Use DEFSYM.
11013 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11015 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11016 (CCL_CODE_MIN): New macro.
11018 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11020 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11022 * eval.c (Qdebug): Now static.
11023 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11024 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11025 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11027 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11029 * image.c: Various fixes to ImageMagick code comments.
11030 (Fimagemagick_types): Doc fix.
11032 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11034 Minor fixes prompted by GCC 4.6.0 warnings.
11036 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11038 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11039 (x_clipboard_manager_save_all): Move extern decl to ...
11040 * xterm.h: ... here, so that it can be checked for consistency.
11042 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11044 * xselect.c (x_clipboard_manager_save_frame)
11045 (x_clipboard_manager_save_all): New functions.
11046 (Fx_clipboard_manager_save): Lisp function deleted.
11048 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11049 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11051 * xterm.h: Update prototype.
11053 2011-05-28 William Xu <william.xwl@gmail.com>
11055 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11056 exiting (Bug#8239).
11058 2011-05-28 Jim Meyering <meyering@redhat.com>
11060 Avoid a sign-extension bug in crypto_hash_function.
11061 * fns.c (to_uchar): Define.
11062 (crypto_hash_function): Use it to convert some newly-signed
11063 variables to unsigned, to avoid sign-extension bugs. For example,
11064 without this change, (md5 "truc") would evaluate to
11065 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11066 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11067 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11069 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11071 Integer overflow fixes.
11073 * dbusbind.c: Serial number integer overflow fixes.
11074 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11075 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11076 to hold a serial number that is too large for a fixnum.
11077 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11078 Check for serial numbers out of range. Decode any serial number
11079 that was so large that it became a float. (Bug#8722)
11081 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11082 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11083 Use XFASTINT rather than XUINT when numbers are nonnegative.
11084 (xd_append_arg, Fdbus_method_return_internal):
11085 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11086 arguments, check that Lisp number is nonnegative, rather than
11087 silently wrapping negative numbers around. (Bug#8722)
11088 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11091 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11093 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11095 ccl: Add integer overflow checks.
11096 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11097 (IN_INT_RANGE): New macros.
11098 (ccl_driver): Use them to check for integer overflow when
11099 decoding a CCL program. Many of the new checks are whether XINT (x)
11100 fits in int; it doesn't always, on 64-bit hosts. The new version
11101 doesn't catch all possible integer overflows, but it's an
11102 improvement. (Bug#8719)
11104 * alloc.c (make_event_array): Use XINT, not XUINT.
11105 There's no need for unsigned here.
11107 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11108 This follows up to the 2011-05-06 change that substituted uintptr_t
11109 for EMACS_INT. This case wasn't caught back then.
11111 Rework Fformat to avoid integer overflow issues.
11112 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11113 now (part of C89). Include <verify.h>.
11114 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11115 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11116 (Fformat): Avoid the prepass trying to compute sizes; it was only
11117 approximate and thus did not catch overflow reliably. Instead, walk
11118 through the format just once, formatting and computing sizes as we go,
11119 checking for integer overflow at every step, and allocating a larger
11120 buffer as needed. Keep track separately whether the format is
11121 multibyte. Keep only the most-recently calculated precision, rather
11122 than them all. Record whether each argument has been converted to
11123 string. Use EMACS_INT, not int, for byte and char and arg counts.
11124 Support field widths and precisions larger than INT_MAX. Avoid
11125 sprintf's undefined behavior with conversion specifications such as %#d
11126 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11127 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11128 formatting out-of-range floating point numbers with int
11129 formats. (Bug#8668)
11131 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11133 * data.c: Avoid integer truncation in expressions involving floats.
11134 * data.c: Include <intprops.h>.
11135 (arith_driver): When there's an integer overflow in an expression
11136 involving floating point, convert the integers to floating point
11137 so that the resulting value does not suffer from catastrophic
11138 integer truncation. For example, on a 64-bit host (* 4
11139 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11140 Do not rely on undefined behavior after integer overflow.
11142 merge count_size_as_multibyte, parse_str_to_multibyte
11143 * character.c, character.h (count_size_as_multibyte):
11144 Rename from parse_str_to_multibyte; all uses changed.
11145 Check for integer overflow.
11146 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11147 since it's now a duplicate of the other. This is more of
11148 a character than a buffer op, so better that it's in character.c.
11149 * fns.c, print.c: Adjust to above changes.
11151 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11153 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11155 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11157 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11158 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11159 (x_clipboard_manager_save): Now static.
11160 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11162 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11163 (crypto_hash_function): Now static.
11164 Fix pointer signedness problems. Avoid unnecessary initializations.
11166 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11168 * termhooks.h (Vselection_alist): Make it terminal-local.
11170 * terminal.c (create_terminal): Initialize it.
11172 * xselect.c: Support for clipboard managers.
11173 (Vselection_alist): Move to termhooks.h as terminal-local var.
11174 (LOCAL_SELECTION): New macro.
11175 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11176 (symbol_to_x_atom): Remove gratuitous arg.
11177 (x_handle_selection_request, lisp_data_to_selection_data)
11178 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11179 (x_own_selection, x_get_local_selection, x_convert_selection):
11180 New arg, specifying work frame. Use terminal-local Vselection_alist.
11181 (some_frame_on_display): Delete unused function.
11182 (Fx_own_selection_internal, Fx_get_selection_internal)
11183 (Fx_disown_selection_internal, Fx_selection_owner_p)
11184 (Fx_selection_exists_p): New optional frame arg.
11185 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11186 (x_handle_selection_clear): Don't treat other terminals with the
11187 same keyboard specially. Use the terminal-local Vselection_alist.
11188 (x_clear_frame_selections): Use Frun_hook_with_args.
11190 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11192 * xterm.h: Add support for those atoms.
11194 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11196 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11197 (converted_selections, conversion_fail_tag): New global variables.
11198 (x_selection_request_lisp_error): Free the above.
11199 (x_get_local_selection): Remove unnecessary code.
11200 (x_reply_selection_request): Args changed; handle arbitrary array
11201 of converted selections stored in converted_selections.
11202 Separate the XChangeProperty and SelectionNotify steps.
11203 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11204 (x_convert_selection): New function.
11205 (x_handle_selection_event): Simplify.
11206 (x_get_foreign_selection): Don't ignore incoming requests while
11207 waiting for an answer; this will fail when we implement
11208 SAVE_TARGETS, and seems unnecessary anyway.
11209 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11210 (Vx_sent_selection_functions): Doc fix.
11212 2011-05-26 Leo Liu <sdl.web@gmail.com>
11214 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11216 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11218 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11220 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11221 for fringe update if it has periodic bitmap.
11222 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11223 and fringe_bitmap_periodic_p.
11225 * fringe.c (get_fringe_bitmap_data): New function.
11226 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11227 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11228 row. Mark glyph row for fringe update if periodicity changed.
11230 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11231 for fringe update unless it has periodic bitmap.
11233 2011-05-25 Kenichi Handa <handa@m17n.org>
11235 * xdisp.c (get_next_display_element): Set correct it->face_id for
11236 a static composition.
11238 2011-05-24 Leo Liu <sdl.web@gmail.com>
11241 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11243 * fns.c (crypto_hash_function, Fsha1): New function.
11244 (Fmd5): Use crypto_hash_function.
11245 (syms_of_fns): Add Ssha1.
11247 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11249 * gnutls.c: Remove unused macros.
11250 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11251 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11252 Remove macros that are defined and never used.
11253 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11255 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11257 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11258 (Fx_get_selection_internal): Minor cleanup.
11259 (Fx_own_selection_internal): Rename arguments for consistency with
11262 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11264 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11266 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11268 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11270 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11272 * dispnew.c (scrolling_window): Don't exclude the case that the
11273 last enabled row in the desired matrix touches the bottom boundary.
11275 2011-05-21 Glenn Morris <rgm@gnu.org>
11277 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11278 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11279 and add some more files.
11281 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11283 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11284 report_file_error introduced by the change from 2011-05-07.
11286 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11288 * systime.h (Time): Define only if emacs is defined.
11289 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11290 where the include path doesn't have X11/X.h by default. See
11291 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11293 2011-05-20 Kenichi Handa <handa@m17n.org>
11295 * composite.c (find_automatic_composition): Fix previous change.
11297 2011-05-20 Glenn Morris <rgm@gnu.org>
11299 * lisp.mk: New file, split from Makefile.in.
11300 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11301 (shortlisp): Remove.
11302 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11304 2011-05-19 Glenn Morris <rgm@gnu.org>
11306 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11307 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11308 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11309 (lisp): Set the order to that of loadup.el.
11310 (shortlisp): Make it a copy of $lisp.
11311 (SOME_MACHINE_LISP): Remove.
11312 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11313 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11315 2011-05-18 Kenichi Handa <handa@m17n.org>
11317 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11318 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11319 (find_automatic_composition): Mostly rewrite for efficiency.
11321 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11323 * makefile.w32-in: Update dependencies.
11325 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11327 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11328 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11330 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11332 Fix some integer overflow issues, such as string length overflow.
11334 * insdel.c (count_size_as_multibyte): Check for string overflow.
11336 * character.c (lisp_string_width): Check for string overflow.
11337 Use EMACS_INT, not int, for string indexes and lengths; in
11338 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11339 the resulting string length overflows an EMACS_INT; instead,
11340 report a string overflow if no precision given. When checking for
11341 precision exhaustion, use a check that cannot possibly have
11342 integer overflow. (Bug#8675)
11343 * character.h (lisp_string_width): Adjust to new signature.
11345 * alloc.c (string_overflow): New function.
11346 (Fmake_string): Use it. This doesn't change behavior, but saves
11347 a few bytes and will simplify future changes.
11348 * character.c (string_escape_byte8): Likewise.
11349 * lisp.h (string_overflow): New decl.
11351 Fixups, following up to the user-interface timestamp change.
11352 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11353 for UI timestamps, instead of unsigned long.
11354 * msdos.c (mouse_get_pos): Likewise.
11355 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11356 * w32gui.h (Time): Define by including "systime.h" rather than by
11357 declaring it ourselves. (Bug#8664)
11359 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11360 * image.c (clear_image_cache): Likewise.
11362 * term.c (term_mouse_position): Don't assume time_t wraparound.
11364 Be more systematic about user-interface timestamps.
11365 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11366 and sometimes 'EMACS_UINT', to represent these timestamps.
11367 This change causes it to use 'Time' uniformly, as that's what X uses.
11368 This makes the code easier to follow, and makes it easier to catch
11369 integer overflow bugs such as Bug#8664.
11370 * frame.c (Fmouse_position, Fmouse_pixel_position):
11371 Use Time, not unsigned long, for user-interface timestamps.
11372 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11373 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11374 * keyboard.h (last_event_timestamp): Likewise.
11375 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11376 * menu.h (xmenu_show): Likewise.
11377 * term.c (term_mouse_position): Likewise.
11378 * termhooks.h (struct input_event.timestamp): Likewise.
11379 (struct terminal.mouse_position_hook): Likewise.
11380 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11381 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11382 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11383 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11384 what it was before.
11385 * menu.h, termhooks.h: Include "systime.h", for Time.
11387 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11388 Don't assume that the difference between two unsigned long values
11389 can fit into an integer. At this point, we know button_down_time
11390 <= event->timestamp, so the difference must be nonnegative, so
11391 there's no need to cast the result if double-click-time is
11392 nonnegative, as it should be; check that it's nonnegative, just in
11393 case. This bug is triggered when events are more than 2**31 ms
11394 apart (about 25 days). (Bug#8664)
11396 * xselect.c (last_event_timestamp): Remove duplicate decl.
11397 (x_own_selection): Remove needless cast to unsigned long.
11399 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11400 that always fit in int. Use a sentinel instead of a counter, to
11401 avoid a temp and to allay GCC's concerns about possible int overflow.
11402 * frame.h (struct frame): Use int for menu_bar_items_used
11403 instead of EMACS_INT, since it always fits in int.
11405 * menu.c (grow_menu_items): Check for int overflow.
11407 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11409 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11410 Before, the code was not consistent. These values cannot exceed
11411 2**31 - 1 so there's no need to make them unsigned.
11412 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11413 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11414 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11416 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11418 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11419 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11420 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11421 presumably because the widths might not match.
11423 * window.c (size_window): Avoid needless test at loop start.
11425 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11427 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11429 2011-05-12 Drew Adams <drew.adams@oracle.com>
11431 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11433 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11435 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11436 `width' to `bar_area_x' and `bar_area_width', respectively.
11437 (x_scroll_run): Take account of fringe background extension.
11439 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11440 Rename local vars `left' and `width' to `bar_area_x' and
11441 `bar_area_width', respectively.
11442 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11443 background extension.
11445 2011-05-10 Jim Meyering <meyering@redhat.com>
11447 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11449 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11451 * image.c (Finit_image_library): Return t for built-in image types,
11452 like pbm and xbm. (Bug#8640)
11454 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11456 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11458 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11460 * w32console.c (Fset_screen_color): Doc fix.
11461 (Fget_screen_color): New function.
11462 (syms_of_ntterm): Defsubr it.
11464 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11465 unlink the temporary file if Fcall_process didn't create it in the
11467 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11468 child process will be redirected to a file specified with `:file'.
11469 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11470 cue to call_process_cleanup not to close that handle.
11472 2011-05-07 Ben Key <bkey76@gmail.com>
11474 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11475 one of two shell specific rules, either bootstrap-temacs-CMD or
11476 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11477 to the previous implementation of the bootstrap-temacs rule.
11478 The bootstrap-temacs-CMD rule is similar to the previous
11479 implementation of the bootstrap-temacs rule except that it
11480 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11483 These changes, along with some changes to nt/configure.bat,
11484 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11485 earlier fix to add support for --cflags and --ldflags options
11486 that include quotes so that it works whether make uses cmd or
11489 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11491 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11492 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11494 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11495 a string. Handle both cases.
11496 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11497 (Fdbus_register_method): Use Qinvalid_function.
11499 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11501 * makefile.w32-in: Update dependencies.
11502 (LISP_H): Add inttypes.h and stdin.h.
11503 (PROCESS_H): Add unistd.h.
11505 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11507 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11508 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11510 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11512 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11514 * term.c (vfatal): Remove stray call to va_end.
11515 It's not needed and the C Standard doesn't allow it here anyway.
11517 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11518 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11520 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11523 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11525 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11527 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11529 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11531 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11533 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11534 * charset.c (Fdefine_charset_internal): Don't initialize
11535 charset.code_space[15]. The value was garbage, on hosts with
11536 32-bit int (Bug#8600).
11538 * lread.c (read_integer): Be more consistent with string-to-number.
11539 Use string_to_number to do the actual conversion; this avoids
11540 rounding errors and fixes some other screwups. Without this fix,
11541 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11542 (digit_to_number): Move earlier, for benefit of read_integer.
11543 Return -1 if the digit is out of range for the base, -2 if it is
11544 not a digit in any supported base. (Bug#8602)
11546 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11548 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11549 to match comment at start of function. This also removes a
11550 GCC warning about overflow in a 32+64-bit port.
11552 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11554 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11555 Reported by Stefan Monnier in
11556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11557 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11558 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11560 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11561 (EMACS_UINTPTR): Likewise, with uintptr_t.
11563 * lisp.h: Prefer 64-bit EMACS_INT if available.
11564 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11565 on 32-bit hosts that have 64-bit int, so that they can access
11567 However, temporarily disable this change unless the temporary
11568 symbol WIDE_EMACS_INT is defined.
11570 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11572 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11573 This removes an assumption that EMACS_INT and long are the same
11574 width as pointers. The assumption is true for Emacs porting targets
11575 now, but we want to make other targets possible.
11576 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11577 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11578 In the rest of the code, change types of integers that hold casted
11579 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11580 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11581 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11582 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11583 No need to cast type when ORing.
11584 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11585 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11586 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11587 assume EMACS_INT is the same width as char *.
11588 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11589 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11590 Remove no-longer-needed casts.
11591 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11592 (xg_tool_bar_help_callback, xg_make_tool_item):
11593 Use EMACS_INTPTR to hold an integer
11594 that will be cast to void *; this can avoid a GCC warning
11595 if EMACS_INT is not the same width as void *.
11596 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11597 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11598 (current_message_1, set_message_1):
11599 Use a local to convert to proper width without a cast.
11600 * xmenu.c (dialog_selection_callback): Likewise.
11602 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11603 Also, don't assume VALBITS / RAND_BITS is less than 5,
11604 and don't rely on undefined behavior when shifting a 1 left into
11606 * lisp.h (get_random): Change signature to match.
11608 * lread.c (hash_string): Use size_t, not int, for hash computation.
11609 Normally we prefer signed values; but hashing is special, because
11610 it's better to use unsigned division on hash table sizes so that
11611 the remainder is nonnegative. Also, size_t is the natural width
11612 for hashing into memory. The previous code used 'int', which doesn't
11613 retain enough info to hash well into very large tables.
11614 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11616 * dbusbind.c: Don't possibly lose pointer info when converting.
11617 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11618 Use XPNTR rather than XHASH, so that the high-order bits of
11619 the pointer aren't lost when converting through void *.
11621 * eval.c (Fautoload): Don't double-shift a pointer.
11623 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11625 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11627 * gnutls.c (DEF_GNUTLS_FN):
11628 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11630 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11632 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11635 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11637 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11638 New version that can reserve upto 2GB of heap space.
11640 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11642 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11644 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11646 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11647 `gnutls_certificate_set_x509_key_file'.
11649 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11651 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11652 Update dependencies.
11654 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11656 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11657 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11658 Remove unused parameter `fildes'.
11659 * process.c (read_process_output, send_process): Don't pass it.
11661 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11663 Fix previous change: the library cache is defined in w32.c.
11664 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11665 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11667 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11669 Implement dynamic loading of GnuTLS on Windows.
11671 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11672 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11673 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11676 * gnutls.c (Qgnutls_dll): Define.
11677 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11678 (gnutls_*): Declare function pointers.
11679 (init_gnutls_functions): New function to initialize function pointers.
11680 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11681 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11682 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11683 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11684 (emacs_gnutls_write, emacs_gnutls_read)
11685 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11686 (Fgnutls_available_p): New function.
11687 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11688 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11689 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11691 * image.c: Include w32.h.
11692 (Vimage_type_cache): Delete.
11693 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11694 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11695 (w32_delayed_load): Move to w32.c.
11697 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11699 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11700 (w32_delayed_load): Move from image.c. When loading a library, record
11701 its filename in the :loaded-from property of the library id.
11702 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11703 Initialize and staticpro them.
11704 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11706 * process.c: Include lisp.h before w32.h, not after.
11707 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11708 instead of gnutls_record_check_pending.
11710 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11712 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11714 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11715 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11718 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11720 * xterm.c (x_set_frame_alpha): Do not set property on anything
11721 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11723 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11725 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11727 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11729 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11730 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11731 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11732 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11733 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11734 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11735 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11736 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11737 (Qgnutls_bootprop_callbacks_verify): Make static.
11739 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11741 * callproc.c: Indentation fixup.
11743 * sysdep.c (wait_for_termination_1): Make static.
11744 (wait_for_termination, interruptible_wait_for_termination):
11745 Move after wait_for_termination_1.
11747 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11749 * sysdep.c (interruptible_wait_for_termination): New function
11750 which is like wait_for_termination, but allows keyboard
11753 * callproc.c (Fcall_process): Add (:file "file") as an option for
11755 (Fcall_process_region): Ditto.
11757 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11759 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11760 rather than `XVECTOR (FOO)->size'.
11762 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11763 inttypes.h, as a gnulib replacement is used if it not available in
11766 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11768 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11769 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11770 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11772 * coding.c (coding_alloc_by_realloc): Error out if destination
11773 will grow beyond MOST_POSITIVE_FIXNUM.
11774 (decode_coding_emacs_mule): Abort if there isn't enough place in
11775 charbuf for the composition carryover bytes. Reserve an extra
11776 space for up to 2 characters produced in a loop.
11777 (decode_coding_iso_2022): Abort if there isn't enough place in
11778 charbuf for the composition carryover bytes.
11780 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11782 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11783 aborting when %lld or %lll format is passed.
11784 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11785 %llo or %llx format is passed. (Bug#8545)
11787 * window.c (window_scroll_line_based): Use a marker instead of
11788 simple variables to record original value of point. (Bug#7952)
11790 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11791 produced by %s or %c overflows available buffer space. (Bug#8545)
11793 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11795 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11796 (SIZE_MAX): Move defn after all includes, as they might #define it.
11798 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11800 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11802 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11804 * keyboard.c (Qdelayed_warnings_hook): Define.
11805 (command_loop_1): Run `delayed-warnings-hook'
11806 if Vdelayed_warnings_list is non-nil.
11807 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11808 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11810 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11812 * doprnt.c (doprnt): Don't return value smaller than the buffer
11813 size if the message was truncated. (Bug#8545).
11815 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11817 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11818 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11820 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11822 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11824 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11826 * makefile.w32-in: Update dependencies.
11828 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11830 Improve `doprnt' and its usage. (Bug#8545)
11831 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11832 `format_end'. Remove support for %l as a conversion specifier.
11833 Don't use xrealloc. Improve diagnostics when the %l size modifier
11834 is used. Update the commentary.
11836 * eval.c (verror): Simplify calculation of size_t.
11838 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11841 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11843 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11846 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11848 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11849 This makes this file independent of the recent pseudovector change.
11851 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11853 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11855 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11856 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11857 Remove unused local.
11858 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11860 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11861 GCC 4.6.0 optimizes based on type-based alias analysis.
11862 For example, if b is of type struct buffer * and v of type struct
11863 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11864 != &v->size, and therefore "v->size = 1; b->size = 2; return
11865 v->size;" must therefore return 1. This assumption is incorrect
11866 for Emacs, since it type-puns struct Lisp_Vector * with many other
11867 types. To fix this problem, this patch adds a new type struct
11868 vectorlike_header that documents the constraints on layout of vectors
11869 and pseudovectors, and helps optimizing compilers not get fooled
11870 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11871 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11872 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11874 (XSETPVECTYPE): Rewrite in terms of new macro.
11875 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11876 This is a bit clearer, and further avoids the possibility of
11877 undesirable aliasing.
11878 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11879 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11880 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11881 since Lisp_Subr is a special case (no "next" field).
11882 (ASIZE): Now uses header.size rather than size.
11883 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11884 to avoid the hassle of writing XVECTOR (foo)->header.size.
11885 (struct vectorlike_header): New type.
11886 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11887 object, to help avoid aliasing.
11888 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11889 (SUBRP): Likewise, since Lisp_Subr is a special case.
11890 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11891 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11892 (struct Lisp_Hash_Table): Combine first two members into a single
11893 struct vectorlike_header member. All uses of "size" and "next" members
11894 changed to be "header.size" and "header.next".
11895 * buffer.h (struct buffer): Likewise.
11896 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11897 * frame.h (struct frame): Likewise.
11898 * process.h (struct Lisp_Process): Likewise.
11899 * termhooks.h (struct terminal): Likewise.
11900 * window.c (struct save_window_data, struct saved_window): Likewise.
11901 * window.h (struct window): Likewise.
11902 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11903 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11904 * buffer.c (init_buffer_once): Likewise.
11905 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11907 * process.c (Fformat_network_address): Use local var for size,
11910 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11912 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11913 * data.c (atof): Remove decl; no longer used or needed.
11914 (digit_to_number): Move to lread.c.
11915 (Fstring_to_number): Use new string_to_number function, to be
11916 consistent with how the Lisp reader treats infinities and NaNs.
11917 Do not assume that floating-point numbers represent EMACS_INT
11918 without losing information; this is not true on most 64-bit hosts.
11919 Avoid double-rounding errors, by insisting on integers when
11920 parsing non-base-10 numbers, as the documentation specifies.
11921 * lisp.h (string_to_number): New decl, replacing ...
11922 (isfloat_string): Remove.
11923 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11924 (read1): Do not accept +. and -. as integers; this
11925 appears to have been a coding error. Similarly, do not accept
11926 strings like +-1e0 as floating point numbers. Do not report
11927 overflow for integer overflows unless the base is not 10 which
11928 means we have no simple and reliable way to continue.
11929 Break out the floating-point parsing into a new
11930 function string_to_number, so that Fstring_to_number parses
11931 floating point numbers consistently with the Lisp reader.
11932 (digit_to_number): Move here from data.c. Make it static inline.
11933 (E_CHAR, EXP_INT): Remove, replacing with ...
11934 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11935 (string_to_number): New function, replacing isfloat_string.
11936 This function checks for valid syntax and produces the resulting
11937 Lisp float number too. Rework it so that string-to-number
11938 no longer mishandles examples like "1.0e+". Use strtoumax,
11939 so that overflow for non-base-10 numbers is reported only when
11940 there's no portable and simple way to convert to floating point.
11942 * textprop.c (set_text_properties_1): Rewrite for clarity,
11943 and to avoid GCC warning about integer overflow.
11945 * intervals.h (struct interval): Use EMACS_INT for members
11946 where EMACS_UINT might cause problems. See
11947 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11948 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11949 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11951 (offset_intervals): Tell GCC not to worry about length overflow
11952 when negating a negative length.
11954 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11955 (overrun_check_free): Likewise.
11957 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11958 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11961 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11962 (gnutls_make_error): Rename local to avoid shadowing.
11963 (gnutls_emacs_global_deinit): ifdef out; not used.
11964 (Fgnutls_boot): Use const for pointer to readonly storage.
11965 Comment out unused local. Fix pointer signedness problems.
11967 * lread.c (openp): Don't stuff size_t into an 'int'.
11968 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11969 about possible signed overflow.
11971 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11972 (GDK_KEY_g): Don't define if already defined.
11973 (xg_prepare_tooltip): Avoid pointer signedness problem.
11974 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11976 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11977 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11979 * xfns.c (Fx_window_property): Simplify a bit,
11980 to make a bit faster and to avoid GCC 4.6.0 warning.
11981 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11983 * fns.c (internal_equal): Don't assume size_t fits in int.
11985 * alloc.c (compact_small_strings): Tighten assertion a little.
11987 Replace pEd with more-general pI, and fix some printf arg casts.
11988 * lisp.h (pI): New macro, generalizing old pEd macro to other
11989 conversion specifiers. For example, use "...%"pI"d..." rather
11990 than "...%"pEd"...".
11991 (pEd): Remove. All uses replaced with similar uses of pI.
11992 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11993 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11994 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11995 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11996 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11997 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11998 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12000 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12001 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12002 * print.c (safe_debug_print, print_object): Likewise.
12003 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12005 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12006 avoiding the 0 flag, which is not portable.
12007 * process.c (Fmake_network_process): Use pI to avoid cast.
12008 * region-cache.c (pp_cache): Likewise.
12009 * xdisp.c (decode_mode_spec): Likewise.
12010 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12011 behavior on 64-bit hosts with printf arg.
12012 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12013 (x_stop_queuing_selection_requests): Likewise.
12014 (x_get_window_property): Don't truncate byte count to an 'int'
12017 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12018 here, since it parses constructs like leading '-' and spaces,
12019 which are not wanted; and it overflows with large numbers.
12020 Instead, simply match F[0-9]+, which is what is wanted anyway.
12022 * alloc.c: Remove unportable assumptions about struct layout.
12023 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12024 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12025 (allocate_vectorlike, make_pure_vector): Use the new macros,
12026 plus offsetof, to remove unportable assumptions about struct layout.
12027 These assumptions hold on all porting targets that I know of, but
12028 they are not guaranteed, they're easy to remove, and removing them
12029 makes further changes easier.
12031 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12032 This doesn't fix a bug but makes the code clearer.
12033 (string_overrun_cookie): Now const. Use initializers that
12034 don't formally overflow signed char, to avoid warnings.
12035 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12036 can cause Emacs to crash when string overrun checking is enabled.
12037 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12038 multiple of sizeof (EMACS_INT); it need not be, if
12039 alignof(EMACS_INT) < sizeof (EMACS_INT).
12040 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12042 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12044 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12046 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12048 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12049 supposed to be handshaking. (Bug#8556)
12050 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12052 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12054 * lisp.h (Qdebug): List symbol.
12055 * eval.c (Qdebug): Restore global linkage.
12056 * keyboard.c (debug-on-event): New variable.
12057 (handle_user_signal): Break into debugger when debug-on-event
12058 matches the current signal symbol.
12060 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12062 * alloc.c (check_sblock, check_string_bytes)
12063 (check_string_free_list): Convert to standard C.
12065 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12067 * w32.c (emacs_gnutls_push): Fix typo.
12069 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12071 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12072 "cast to pointer from integer of different size".
12074 Improve doprnt and its use in verror. (Bug#8545)
12075 * doprnt.c (doprnt): Document the set of format control sequences
12076 supported by the function. Use SAFE_ALLOCA instead of always
12079 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12080 is one byte too soon. Don't use xrealloc; instead xfree and
12083 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12085 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12088 * gnutls.c: Renamed global_initialized to
12089 gnutls_global_initialized. Added internals for the
12090 :verify-hostname-error, :verify-error, and :verify-flags
12091 parameters of `gnutls-boot' and documented those parameters in the
12092 docstring. Start callback support.
12093 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12094 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12095 on error. Return error code.
12096 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12097 (emacs_gnutls_read): Likewise.
12098 (Fgnutls_boot): Return handshake error code.
12099 (emacs_gnutls_handle_error): New function.
12100 (wsaerror_to_errno): Likewise.
12102 * w32.h (emacs_gnutls_pull): Add prototype.
12103 (emacs_gnutls_push): Likewise.
12105 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12106 (emacs_gnutls_push): Likewise.
12108 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12110 * process.c (wait_reading_process_output): Check if GnuTLS
12111 buffered some data internally if no FDs are set for TLS
12114 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12115 (LIBS): Link to USER_LIBS.
12116 ($(BLD)/gnutls.$(0)): New target.
12118 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12120 * xdisp.c (handle_single_display_spec): Rename the
12121 display_replaced_before_p argument into display_replaced_p, to
12122 make it consistent with the commentary. Fix typos in the
12125 * textprop.c (syms_of_textprop): Remove dead code.
12126 (copy_text_properties): Delete obsolete commentary about an
12127 interface that was deleted long ago. Fix typos in the description
12130 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12131 to changes in oldXMenu/XMenu.h from 2011-04-16.
12132 <menu_help_message, prev_menu_help_message>: Constify.
12133 (IT_menu_make_room): menu->help_text is now `const char **';
12136 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12137 to changes in oldXMenu/XMenu.h from 2011-04-16.
12138 (struct XMenu): Declare `help_text' `const char **'.
12140 * xfaces.c <Qunspecified>: Make extern again.
12142 * syntax.c: Include sys/types.h before including regex.h, as
12145 * doc.c (get_doc_string): Improve the format passed to `error'.
12147 * doprnt.c (doprnt): Improve commentary.
12149 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12151 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12154 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12155 changes in globals.h immediately force recompilation.
12156 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12157 $(CURDIR)/s/ms-w32.h.
12158 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12160 * character.c (Fchar_direction): Function deleted.
12161 (syms_of_character): Don't defsubr it.
12162 <char-direction-table>: Deleted.
12164 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12166 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12167 * doprnt.c: Include limits.h.
12168 (SIZE_MAX): New macro.
12169 (doprnt): Return a size_t value. 2nd arg is now size_t.
12170 Many local variables are now size_t instead of int or unsigned.
12171 Improve overflow protection. Support `l' modifier for integer
12172 conversions. Support %l conversion. Don't assume an EMACS_INT
12173 argument for integer conversions and for %c.
12175 * lisp.h (doprnt): Restore prototype.
12177 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12178 $(SRC)/character.h.
12180 * Makefile.in (base_obj): Add back doprnt.o.
12182 * deps.mk (doprnt.o): Add back prerequisites.
12183 (callint.o): Depend on character.h.
12185 * eval.c (internal_lisp_condition_case): Include the handler
12186 representation in the error message.
12187 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12188 when breaking from the loop.
12190 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12192 * callint.c (Fcall_interactively): When displaying error message
12193 about invalid control letter, pass the character's codepoint, not
12194 a pointer to its multibyte form. Improve display of the character
12195 in octal and display also its hex code.
12197 * character.c (char_string): Use %x to display the (unsigned)
12198 codepoint of an invalid character, to avoid displaying a bogus
12201 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12202 `error', not SYMBOL_NAME itself.
12204 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12205 character arguments to `error'.
12207 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12208 to `error' in error message about FINAL_CHAR argument. Make sure
12209 FINAL_CHAR is a character, and use %c when it is passed as
12210 argument to `error'.
12212 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12214 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12216 * w32.c: Include <time.h>.
12217 (sys_localtime): New function.
12219 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12221 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12223 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12225 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12227 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12228 zombies (Bug#8467).
12230 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12232 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12233 gl_state.e_property when gl_state.object is Qt.
12235 * insdel.c (make_gap_larger): Remove limitation of buffer size
12238 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12240 * xdisp.c (lookup_glyphless_char_display)
12241 (produce_glyphless_glyph): Handle cons cell entry in
12242 glyphless-char-display.
12243 (Vglyphless_char_display): Document it.
12245 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12246 glyphless-char-display.
12248 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12250 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12252 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12254 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12255 definition for no-X builds.
12257 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12259 Static checks with GCC 4.6.0 and non-default toolkits.
12261 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12263 * process.c (keyboard_bit_set): Define only if SIGIO.
12264 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12265 (send_process): Repair possible setjmp clobbering.
12267 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12269 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12271 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12273 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12274 Define only if needed.
12276 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12277 by pacifying GCC about it. Maybe it's time to retire it?
12278 * xfaces.c (USG, __TIMEVAL__): Likewise.
12280 * dispextern.h (struct redisplay_interface): Rename param
12281 to avoid shadowing.
12282 * termhooks.h (struct terminal): Likewise.
12283 * xterm.c (xembed_send_message): Likewise.
12285 * insdel.c (make_gap_smaller): Define only if
12286 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12288 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12291 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12292 so that we aren't warned about unused symbols.
12294 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12296 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12298 * xfns.c (x_real_positions): Mark locals as initialized.
12300 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12302 * xterm.c: Fix problems found by static analysis with other toolkits.
12303 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12304 (x_dispatch_event): Declare static if USE_GTK, and
12305 define if USE_GTK || USE_X_TOOLKIT.
12306 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12307 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12308 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12309 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12311 * xmenu.c (menu_help_callback): Pointer type fixes.
12312 Use const pointers when pointing at readonly data. Avoid pointer
12313 signedness clashes.
12314 (FALSE): Remove unused macro.
12315 (update_frame_menubar): Remove unused decl.
12317 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12319 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12320 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12321 (single_menu_item): Rename local to avoid shadowing.
12323 * keyboard.c (make_lispy_event): Remove unused local var.
12325 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12326 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12328 * bitmaps: Change bitmaps from unsigned char back to the X11
12329 compatible char. Avoid the old compiler warnings about
12330 out-of-range initializers by using, for example, '\xab' rather
12333 * xgselect.c (xgselect_initialize): Check vs interface
12334 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12336 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12338 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12339 to read-only memory.
12341 * fns.c (vector): Remove; this old hack is no longer needed.
12343 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12345 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12347 * xrdb.c (x_load_resources): Omit unused local.
12349 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12350 (x_window): Rename locals to avoid shadowing.
12351 (USG): Use the kludged USG macro, to pacify gcc.
12353 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12354 (x_term_init): Remove local to avoid shadowing.
12356 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12358 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12359 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12361 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12363 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12365 Fix regex.c, syntax.c and friends for buffers > 2GB.
12366 * syntax.h (struct gl_state_s): Declare character position members
12369 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12371 * textprop.c (verify_interval_modification, interval_of):
12372 Declare arguments EMACS_INT.
12374 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12377 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12379 * indent.c (Fvertical_motion): Local variable it_start is now
12382 * regex.c (re_match, re_match_2, re_match_2_internal)
12383 (bcmp_translate, regcomp, regexec, print_double_string)
12384 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12385 (re_compile_pattern, re_exec): Declare arguments and local
12386 variables `size_t' and `ssize_t' and return values `regoff_t', as
12388 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12389 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12390 <compile_stack_type>: `size' and `avail' are now `size_t'.
12392 * regex.h <regoff_t>: Use ssize_t, not int.
12393 (re_search, re_search_2, re_match, re_match_2): Arguments that
12394 specify buffer/string position and length are now ssize_t and
12395 size_t. Return type is regoff_t.
12397 2011-04-16 Ben Key <bkey76@gmail.com>
12399 * nsfont.m: Fixed bugs in ns_get_family and
12400 ns_descriptor_to_entity that were caused by using free to
12401 deallocate memory blocks that were allocated by xmalloc (via
12402 xstrdup). This caused Emacs to crash when compiled with
12403 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12404 --enable-checking=xmallocoverrun). xfree is now used to
12405 deallocate these memory blocks.
12407 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12409 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12411 emacs_write: Accept and return EMACS_INT for sizes.
12412 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12414 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12415 Accept and return EMACS_INT.
12416 (emacs_gnutls_write): Return the number of bytes written on
12418 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12419 (emacs_read, emacs_write): Remove check for negative size, as the
12420 Emacs source code has been audited now.
12421 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12422 (emacs_read, emacs_write): Use it.
12423 * process.c (send_process): Adjust to the new signatures of
12424 emacs_write and emacs_gnutls_write. Do not attempt to store
12425 a byte offset into an 'int'; it might overflow.
12426 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12428 * sound.c: Don't assume sizes fit in 'int'.
12429 (struct sound_device.period_size, alsa_period_size):
12430 Return EMACS_INT, not int.
12431 (struct sound_device.write, vox_write, alsa_write):
12432 Accept EMACS_INT, not int.
12433 (wav_play, au_play): Use EMACS_INT to store sizes and to
12434 record read return values.
12436 2011-04-15 Ben Key <bkey76@gmail.com>
12438 * keyboard.c (Qundefined): Don't declare static since it is used
12440 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12441 static since they are used in nsfont.m.
12443 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12445 * process.c (Qprocessp): Don't declare static.
12446 * lisp.h (Qprocessp): Declare again.
12448 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12450 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12452 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12454 Improve C-level modularity by making more things 'static'.
12456 Don't publish debugger-only interfaces to other modules.
12457 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12458 (verify_bytepos, count_markers): Move decls to the only modules
12460 * region-cache.h (pp_cache): Likewise.
12461 * window.h (check_all_windows): Likewise.
12462 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12464 * sysdep.c (croak): Now static, if
12465 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12466 * syssignal.h (croak): Declare only if not static.
12468 * alloc.c (refill_memory_reserve): Now static if
12469 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12470 * lisp.h (refill_memory_reserve): Declare only if not static.
12472 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12473 Define only if USE_LUCID.
12475 * xrdb.c (x_customization_string, x_rm_string): Now static.
12477 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12478 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12480 * xdisp.c (draw_row_with_mouse_face): Now static.
12481 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12483 * window.h (check_all_windows): Mark externally visible.
12485 * window.c (window_deletion_count): Now static.
12487 * undo.c: Make symbols static if they're not exported.
12488 (last_undo_buffer, last_boundary_position, pending_boundary):
12491 * textprop.c (interval_insert_behind_hooks): Now static.
12492 (interval_insert_in_front_hooks): Likewise.
12494 * term.c: Make symbols static if they're not exported.
12495 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12496 (max_frame_lines, tty_set_terminal_modes):
12497 (tty_reset_terminal_modes, tty_turn_off_highlight):
12498 (get_tty_terminal): Now static.
12499 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12500 * termhooks.h (term_mouse_moveto): Do not declare if
12501 HAVE_WINDOW_SYSTEM.
12502 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12503 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12505 * sysdep.c: Make symbols static if they're not exported.
12506 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12508 (sigprocmask_set, full_mask): Remove; unused.
12509 (wait_debugging): Mark as visible.
12510 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12511 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12513 * syntax.c (syntax_temp): Define only if !__GNUC__.
12515 * sound.c (current_sound_device, current_sound): Now static.
12517 * search.c (searchbufs, searchbuf_head): Now static.
12519 * scroll.c (scroll_cost): Remove; unused.
12520 * dispextern.h (scroll_cost): Remove decl.
12522 * region-cache.h (pp_cache): Mark as externally visible.
12524 * process.c: Make symbols static if they're not exported.
12525 (process_tick, update_tick, create_process, chan_process):
12526 (Vprocess_alist, proc_buffered_char, datagram_access):
12527 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12528 (deactivate_process): Mark defn as static, as well as decl.
12529 * lisp.h (create_process): Remove decl.
12530 * process.h (chan_process, Vprocess_alist): Remove decls.
12532 * print.c: Make symbols static if they're not exported.
12533 (print_depth, new_backquote_output, being_printed, print_buffer):
12534 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12535 (print_interval, print_number_index, initial_stderr_stream):
12537 * lisp.h (Fprinc): Remove decl.
12538 (debug_output_compilation_hack): Mark as externally visible.
12540 * sysdep.c (croak): Move decl from here to syssignal.h.
12541 * syssignal.h (croak): Put it here, so the API can be checked when
12542 'croak' is called from dissociate_if_controlling_tty.
12544 * minibuf.c: Make symbols static if they're not exported.
12545 (minibuf_save_list, choose_minibuf_frame): Now static.
12546 * lisp.h (choose_minibuf_frame): Remove decl.
12548 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12550 * lread.c: Make symbols static if they're not exported.
12551 (read_objects, initial_obarray, oblookup_last_bucket_number):
12553 (make_symbol): Remove; unused.
12554 * lisp.h (initial_obarray, make_symbol): Remove decls.
12556 * keyboard.c: Make symbols static if they're not exported.
12557 (single_kboard, recent_keys_index, total_keys, recent_keys):
12558 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12559 (this_single_command_key_start, echoing, last_auto_save):
12560 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12561 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12562 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12563 (Vlispy_mouse_stem, double_click_count):
12565 (force_auto_save_soon): Define only if SIGDANGER.
12566 (ignore_mouse_drag_p): Now static if
12567 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12568 (print_help): Remove; unused.
12569 (stop_character, last_timer_event): Mark as externally visible.
12570 * keyboard.h (ignore_mouse_drag_p): Declare only if
12571 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12572 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12573 * lisp.h (echoing): Remove decl.
12574 (force_auto_save_soon): Declare only if SIGDANGER.
12575 * xdisp.c (redisplay_window): Simplify code, to make it more
12576 obvious that ignore_mouse_drag_p is not accessed if !defined
12577 USE_GTK && !defined HAVE_NS.
12579 * intervals.c: Make symbols static if they're not exported.
12580 (merge_properties_sticky, merge_interval_right, delete_interval):
12582 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12584 * insdel.c: Make symbols static if they're not exported.
12585 However, leave prepare_to_modify_buffer alone. It's never
12586 called from outside this function, but that appears to be a bug.
12587 (combine_after_change_list, combine_after_change_buffer):
12588 (adjust_after_replace, signal_before_change): Now static.
12589 (adjust_after_replace_noundo): Remove; unused.
12590 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12591 (signal_before_change): Remove decls.
12593 * indent.c (val_compute_motion, val_vmotion): Now static.
12595 * image.c: Make symbols static if they're not exported.
12596 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12598 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12599 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12601 * fringe.c (standard_bitmaps): Now static.
12602 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12604 * frame.c: Make symbols static if they're not exported.
12605 (x_report_frame_params, make_terminal_frame): Now static.
12606 (get_frame_param): Now static, unless HAVE_NS.
12607 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12608 (x_get_resource_string): Remove; not used.
12609 * frame.h (make_terminal_frame, x_report_frame_params):
12610 (x_get_resource_string); Remove decls.
12611 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12612 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12614 * font.c, fontset.c: Make symbols static if they're not exported.
12615 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12616 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12617 * font.c (font_close_object): Now static.
12618 * font.h (font_close_object): Remove.
12619 * fontset.c (FONTSET_OBJLIST): Remove.
12620 (free_realized_fontset) #if-0 the body, which does nothing.
12621 (face_suitable_for_char_p): #if-0, as it's never called.
12622 * fontset.h (face_suitable_for_char_p): Remove decl.
12623 * xfaces.c (face_at_string_position):
12624 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12625 since 0 is always ASCII.
12627 * fns.c (weak_hash_tables): Now static.
12629 * fileio.c: Make symbols static if they're not exported.
12630 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12631 (Vwrite_region_annotation_buffers): Now static.
12633 * eval.c: Make symbols static if they're not exported.
12634 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12635 * lisp.h (backtrace_list): Remove decl.
12637 * emacs.c: Make symbols static if they're not exported.
12638 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12639 (fatal_error_code, fatal_error_signal_hook, standard_args):
12641 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12642 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12643 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12644 * lisp.h (fatal_error_signal_hook): Remove decl.
12645 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12647 * editfns.c: Move a (normally-unused) function to its only use.
12648 * editfns.c, lisp.h (get_operating_system_release): Remove.
12649 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12650 worth the hassle of breaking this out.
12652 * xterm.c: Make symbols static if they're not exported.
12653 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12654 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12655 (x_destroy_window, x_delete_display):
12657 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12658 (x_mouse_leave): Remove; unused.
12659 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12660 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12661 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12663 (x_mouse_leave): Declare only if WINDOWSNT.
12664 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12665 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12668 * ftxfont.c: Make symbols static if they're not exported.
12669 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12671 * font.h (ftxfont_driver): Likewise.
12673 * xfns.c: Make symbols static if they're not exported.
12674 (x_last_font_name, x_display_info_for_name):
12675 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12676 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12677 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12678 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12679 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12680 (last_show_tip_args): Now static.
12681 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12682 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12683 (x_screen_planes): Remove; unused.
12684 * dispextern.h (x_screen_planes): Remove decl.
12686 * dispnew.c: Make symbols static if they're not exported.
12687 * dispextern.h (redraw_garbaged_frames, scrolling):
12688 (increment_row_positions): Remove.
12689 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12690 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12692 (redraw_garbaged_frames): Remove; unused.
12694 * xfaces.c: Make symbols static if they're not exported.
12695 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12697 * xterm.h (defined_color): Remove decls.
12698 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12699 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12700 (menu_face_changed_default, defined_color, free_realized_face):
12701 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12702 (ascii_face_of_lisp_face): Remove; unused.
12704 * xdisp.c: Make symbols static if they're not exported.
12705 * dispextern.h (scratch_glyph_row, window_box_edges):
12706 (glyph_to_pixel_coords, set_cursor_from_row):
12707 (get_next_display_element, set_iterator_to_next):
12708 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12709 (show_mouse_face): Remove decls
12710 * frame.h (message_buf_print): Likewise.
12711 * lisp.h (pop_message, set_message, check_point_in_composition):
12713 * xterm.h (set_vertical_scroll_bar): Likewise.
12714 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12715 (message_buf_print, scratch_glyph_row, displayed_buffer):
12716 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12717 (get_next_display_element, show_mouse_face, window_box_edges):
12718 (frame_to_window_pixel_xy, check_point_in_composition):
12719 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12720 (glyph_to_pixel_coords): Remove; unused.
12722 * dired.c (file_name_completion): Now static.
12724 * dbusbind.c (xd_in_read_queued_messages): Now static.
12726 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12727 * data.c (circular_list_error): Remove.
12729 * commands.h (last_point_position, last_point_position_buffer):
12730 (last_point_position_window): Remove decls.
12731 * keyboard.c: Make these variables static.
12733 * coding.h (coding, code_convert_region, encode_coding_gap):
12735 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12736 (iso_code_class, detect_coding, code_convert_region): Now static.
12737 (encode_coding_gap): Remove; unused.
12739 * chartab.c (chartab_chars, chartab_bits): Now static.
12741 * charset.h (charset_iso_8859_1): Remove decl.
12742 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12745 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12746 * ccl.c (Vccl_program_table): Now static.
12747 (check_ccl_update): Remove; unused.
12749 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12750 * category.h: ... from here.
12751 * category.c (check_category_table, set_category_set): Now static.
12753 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12754 * lisp.h: Remove these decls.
12756 * buffer.c (buffer_count): Remove unused var.
12758 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12759 so that it's not optimized away.
12760 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12761 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12762 exported only to the debugger.
12764 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12765 * atimer.h (run_all_atimers): Remove; not exported.
12767 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12768 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12769 was inaccessible from Lisp.
12770 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12771 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12773 alloc.c: Import and export fewer symbols, and remove unused items.
12774 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12776 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12777 it's not optimized away by whole-program optimization.
12778 (message_enable_multibyte, free_misc): Remove.
12779 (catchlist, handlerlist, mark_backtrace):
12780 Declare only if BYTE_MARK_STACK.
12781 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12782 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12783 (message_enable_multibyte): Remove decl.
12784 (free_misc, interval_free_list, float_block, float_block_index):
12785 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12786 (cons_free_list, last_marked_index):
12788 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12789 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12790 (mark_backtrace): Define only if BYTE_MARK_STACK.
12791 * xdisp.c (message_enable_multibyte): Now static.
12793 Declare Lisp_Object Q* variables to be 'static' if not exported.
12794 This makes it easier for human readers (and static analyzers)
12795 to see whether these variables are used from other modules.
12796 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12797 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12798 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12799 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12800 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12801 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12802 * xmenu.c, xselect.c:
12803 Declare Q* vars static if they are not used in other modules.
12804 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12805 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12806 Remove decls of unexported vars.
12807 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12809 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12811 Make Emacs functions such as Fatom 'static' by default.
12812 This makes it easier for human readers (and static analyzers)
12813 to see whether these functions can be called from other modules.
12814 DEFUN now defines a static function. To make the function external
12815 so that it can be used in other C modules, use the new macro DEFUE.
12816 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12817 (Finit_image_library):
12818 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12819 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12820 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12821 Remove decls, since these functions are now static.
12822 (Funintern, Fget_internal_run_time): New decls, since these functions
12823 were already external.
12825 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12826 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12827 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12828 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12829 * keyboard.c, keymap.c, lread.c:
12830 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12831 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12832 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12833 Mark functions with DEFUE instead of DEFUN,
12834 if they are used in other modules.
12835 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12836 decls for now-static functions.
12837 * buffer.h (Fdelete_overlay): Remove decl.
12838 * callproc.c (Fgetenv_internal): Mark as internal.
12839 * composite.c (Fremove_list_of_text_properties): Remove decl.
12840 (Fcomposition_get_gstring): New forward static decl.
12841 * composite.h (Fcomposite_get_gstring): Remove decl.
12842 * dired.c (Ffile_attributes): New forward static decl.
12843 * doc.c (Fdocumntation_property): New forward static decl.
12844 * eval.c (Ffetch_bytecode): New forward static decl.
12845 (Funintern): Remove extern decl; now in .h file where it belongs.
12846 * fileio.c (Fmake_symbolic_link): New forward static decl.
12847 * image.c (Finit_image_library): New forward static decl.
12848 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12849 * intervals.h (Fprevious_property_change):
12850 (Fremove_list_of_text_properties): Remove decls.
12851 * keyboard.c (Fthis_command_keys): Remove decl.
12852 (Fcommand_execute): New forward static decl.
12853 * keymap.c (Flookup_key): New forward static decl.
12854 (Fcopy_keymap): Now static.
12855 * keymap.h (Flookup_key): Remove decl.
12856 * process.c (Fget_process): New forward static decl.
12857 (Fprocess_datagram_address): Mark as internal.
12858 * syntax.c (Fsyntax_table_p): New forward static decl.
12859 (skip_chars): Remove duplicate decl.
12860 * textprop.c (Fprevious_property_change): New forward static decl.
12861 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12863 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12864 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12866 * editfns.c (Fformat): Remove unreachable code.
12868 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12870 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12873 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12875 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12876 when at ZV. (Bug#8487)
12878 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12880 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12882 * keyboard.c (parse_tool_bar_item): Likewise.
12883 * sound.c (sound_cleanup, alsa_close): Likewise.
12884 * termcap.c (tgetent): Likewise.
12885 * xfns.c (x_default_font_parameter): Likewise.
12886 * xsettings.c (read_and_apply_settings): Likewise.
12888 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12889 (overrun_check_free): Protoize.
12891 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12893 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12894 since callers should never pass a negative size.
12895 Change the signature to match that of plain 'read' and 'write'; see
12896 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12897 * lisp.h: Update prototypes of emacs_write and emacs_read.
12899 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12901 * xdisp.c (redisplay_window): Don't try to determine the character
12902 position of the scroll margin if the window start point w->startp
12903 is outside the buffer's accessible region. (Bug#8468)
12905 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12907 Fix write-region and its subroutines for buffers > 2GB.
12908 * fileio.c (a_write, e_write): Modify declaration of arguments and
12909 local variables to support buffers larger than 2GB.
12910 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12912 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12913 argument, local variables, and return value.
12915 * lisp.h: Update prototypes of emacs_write and emacs_read.
12917 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12919 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12921 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12923 Fix more problems found by GCC 4.6.0's static checks.
12925 * xdisp.c (vmessage): Use a better test for character truncation.
12927 * charset.c (load_charset_map): <, not <=, for optimization,
12928 and to avoid potential problems with integer overflow.
12929 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12930 * casetab.c (set_identity, shuffle): Likewise.
12931 * editfns.c (Fformat): Likewise.
12932 * syntax.c (skip_chars): Likewise.
12934 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12935 This also lets GCC 4.6.0 generate slightly better loop code.
12937 * callint.c (Fcall_interactively): <, not <=, for optimization.
12938 (Fcall_interactively): Count the number of arguments produced,
12939 not the number of arguments given. This is simpler and lets GCC
12940 4.6.0 generate slightly better code.
12942 * ftfont.c: Distingish more carefully between FcChar8 and char.
12943 The previous code passed unsigned char * to a functions like
12944 strlen and xstrcasecmp that expect char *, which does not
12945 conform to the C standard.
12946 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12947 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12948 char * when the C standard requires it.
12950 * keyboard.c (read_char): Remove unused var.
12952 * eval.c: Port to Windows vsnprintf (Bug#8435).
12953 Include <limits.h>.
12954 (SIZE_MAX): Define if the headers do not.
12955 (verror): Do not give up if vsnprintf returns a negative count.
12956 Instead, grow the buffer. This ports to Windows vsnprintf, which
12957 does not conform to C99. Problem reported by Eli Zaretskii.
12958 Also, simplify the allocation scheme, by avoiding the need for
12959 calling realloc, and removing the ALLOCATED variable.
12961 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12963 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12964 But keep the doprint source code for now, as we might revamp it
12965 and use it again (Bug#8435).
12966 * lisp.h (doprnt): Remove.
12967 * Makefile.in (base_obj): Remove doprnt.o.
12968 * deps.mk (doprnt.o): Remove.
12970 error: Print 32- and 64-bit integers portably (Bug#8435).
12971 Without this change, on typical 64-bit hosts error ("...%d...", N)
12972 was used to print both 32- and 64-bit integers N, which relied on
12973 undefined behavior.
12974 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12975 * lisp.h (error, verror): Mark as printf-like functions.
12976 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12977 Report overflow in size calculations when allocating printf buffer.
12978 Do not truncate output string at its first null byte.
12979 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12980 Truncate the output at a character boundary, since vsnprintf does not
12982 * charset.c (check_iso_charset_parameter): Convert internal
12983 character to string before calling 'error', since %c now has the
12985 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12986 overflow when computing char to be passed to 'error'. Do not
12987 pass Lisp_Object to 'error'; pass the integer instead.
12988 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12989 formatted with plain %d.
12991 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12993 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12995 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12997 * xterm.c (x_catch_errors): Remove duplicate declaration.
12999 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13001 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13003 2011-04-10 Jim Meyering <meyering@redhat.com>
13005 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13006 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13007 return ssize_t not "int", and use size_t as the buffer length.
13008 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13009 * gnutls.h: Update declarations.
13010 * process.c (read_process_output): Use ssize_t, to match.
13011 (send_process): Likewise.
13013 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13015 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13017 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13019 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13020 Use unsigned char, to match FcChar8 type definition.
13022 * xterm.c (handle_one_xevent):
13023 * xmenu.c (create_and_show_popup_menu):
13024 * xselect.c (x_decline_selection_request)
13025 (x_reply_selection_request): Avoid type-punned deref of X events.
13027 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13029 Fix some uses of `int' instead of EMACS_INT.
13030 * search.c (string_match_1, fast_string_match)
13031 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13032 (scan_buffer, find_next_newline_no_quit)
13033 (find_before_next_newline, search_command, Freplace_match)
13034 (Fmatch_data): Make some `int' variables be EMACS_INT.
13036 * xdisp.c (display_count_lines): 3rd argument and return value now
13037 EMACS_INT. All callers changed.
13038 (pint2hrstr): Last argument is now EMACS_INT.
13040 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13041 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13042 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13043 (decode_coding_utf_16, decode_coding_emacs_mule)
13044 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13045 (decode_coding_ccl, decode_coding_charset)
13046 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13047 (decode_coding_iso_2022, decode_coding_emacs_mule)
13048 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13049 <char_offset, last_offset>: Declare EMACS_INT.
13050 (encode_coding_utf_8, encode_coding_utf_16)
13051 (encode_coding_emacs_mule, encode_invocation_designation)
13052 (encode_designation_at_bol, encode_coding_iso_2022)
13053 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13054 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13056 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13057 (encode_invocation_designation): Last argument P_NCHARS is now
13059 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13060 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13062 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13065 * ccl.c (Fccl_execute_on_string): Declare some variables
13068 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13070 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13072 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13074 * process.c (Fformat_network_address): Doc fix.
13076 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13078 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13080 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13082 * keyboard.c (read_char): Call Lisp function help-form-show,
13083 instead of using internal_with_output_to_temp_buffer.
13084 (Qhelp_form_show): New var.
13085 (syms_of_keyboard): Use DEFSYM macro.
13087 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13089 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13091 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13093 * process.c (Flist_processes): Remove to Lisp.
13094 (list_processes_1): Delete.
13096 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13098 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13100 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13102 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13104 Fix more problems found by GCC 4.6.0's static checks.
13106 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13108 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13110 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13112 * xdisp.c (vmessage): Mark as a printf-like function.
13114 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13116 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13118 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13119 printf-like functions.
13120 (tiff_load): Add casts to remove these marks before passing them
13121 to system-supplied API.
13123 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13125 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13126 This avoids several warnings with gcc -Wstrict-overflow.
13127 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13128 directly, rather than having caller test rule sign. This avoids
13129 some unnecessary tests.
13130 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13131 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13132 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13134 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13135 (xfont_open): Avoid unnecessary tests.
13137 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13139 * composite.h, composite.c (composition_gstring_put_cache):
13140 Use EMACS_INT, not int, for length.
13142 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13143 breaking out part of COMPOSITION_DECODE_RULE.
13144 (COMPOSITION_DECODE_RULE): Use it.
13145 * composite.c (get_composition_id): Remove unused local vars,
13146 by using the new macro.
13148 * textprop.c (set_text_properties_1): Change while to do-while,
13149 since the condition is always true at first.
13151 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13152 (interval_deletion_adjustment): Return unsigned value.
13155 * process.c (list_processes_1, create_pty, read_process_output):
13156 (exec_sentinel): Remove vars that were set but not used.
13157 (create_pty): Remove unnecessary "volatile"s.
13158 (Fnetwork_interface_info): Avoid possibility of int overflow.
13159 (read_process_output): Do adaptive read buffering even if carryover.
13160 (read_process_output): Simplify nbytes computation if buffered.
13162 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13164 * syntax.c (scan_words): Remove var that was set but not used.
13165 (update_syntax_table): Use unsigned instead of int.
13167 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13168 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13169 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13171 * print.c (print_error_message): Avoid int overflow.
13173 * font.c (font_list_entities): Redo for clarity,
13174 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13176 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13177 (font_score): Avoid potential overflow in diff calculation.
13179 * fns.c (substring_both): Remove var that is set but not used.
13180 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13182 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13184 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13185 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13186 can always succeed if overflow has undefined behavior.
13188 * search.c (boyer_moore, wordify): Remove vars set but not used.
13189 (wordify): Omit three unnecessary tests.
13191 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13192 All callers changed. This avoids the need for an unused var.
13194 * casefiddle.c (casify_region): Remove var that is set but not used.
13196 * dired.c (file_name_completion): Remove var that is set but not used.
13198 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13200 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13201 (Finsert_file_contents): Remove unnecessary code checking fd.
13203 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13204 Check for integer overflow on size calculations.
13206 * buffer.c (Fprevious_overlay_change): Remove var that is set
13209 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13210 Remove vars that are set but not used.
13211 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13212 (timer_check_2): Mark vars as initialized.
13214 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13216 * image.c (lookup_image): Remove var that is set but not used.
13217 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13219 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13220 that are set but not used.
13222 * xfns.c (make_invisible_cursor): Don't return garbage
13223 if XCreateBitmapFromData fails (Bug#8410).
13225 * xselect.c (x_get_local_selection, x_handle_property_notify):
13226 Remove vars that are set but not used.
13228 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13229 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13231 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13232 Remove var that is set but not used.
13233 (scroll_bar_windows_size): Now size_t, not int.
13234 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13235 Check for overflow.
13237 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13238 (map_tty_color) [!defined MSDOS]: Likewise.
13240 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13242 * coding.c: Remove vars that are set but not used.
13243 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13244 All callers changed.
13245 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13246 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13247 (decode_coding_charset): Remove vars that are set but not used.
13249 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13250 that is set but not used.
13252 * print.c (print_object): Remove var that is set but not used.
13254 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13255 The gnulib version avoids calling malloc in the usual case,
13256 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13257 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13258 * filelock.c (current_lock_owner): Likewise.
13259 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13260 * sysdep.c: Include allocator.h, careadlinkat.h.
13261 (emacs_no_realloc_allocator): New static constant.
13262 (emacs_readlink): New function.
13263 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13264 ../lib/careadlinkat.h.
13266 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13268 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13269 first non-nil return value).
13271 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13273 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13274 if not defined (Bug#8403).
13276 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13278 * xdisp.c (display_count_lines): Remove parameter `start',
13279 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13280 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13281 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13282 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13283 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13284 and thereabouts. All callers changed.
13285 (get_per_char_metric): Remove parameter `f', unused since
13286 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13288 2011-04-02 Jim Meyering <meyering@redhat.com>
13290 do not dereference NULL upon failed strdup
13291 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13292 (ns_get_family): Likewise.
13294 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13296 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13298 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13300 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13303 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13305 Add lexical binding.
13307 * window.c (Ftemp_output_buffer_show): New fun.
13308 (Fsave_window_excursion):
13309 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13311 * lread.c (lisp_file_lexically_bound_p): New function.
13312 (Fload): Bind Qlexical_binding.
13313 (readevalloop): Remove `evalfun' arg.
13314 Bind Qinternal_interpreter_environment.
13315 (Feval_buffer): Bind Qlexical_binding.
13316 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13318 (syms_of_lread): Declare `lexical-binding'.
13320 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13322 * keyboard.c (eval_dyn): New fun.
13323 (menu_item_eval_property): Use it.
13325 * image.c (parse_image_spec): Use Ffunctionp.
13327 * fns.c (concat, mapcar1): Accept byte-code-functions.
13329 * eval.c (Fsetq): Handle lexical vars.
13330 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13331 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13332 (FletX, Flet): Obey lexical binding.
13333 (Fcommandp): Handle closures.
13334 (Feval): New `lexical' arg.
13335 (eval_sub): New function extracted from Feval. Use it almost
13336 everywhere where Feval was used. Look up vars in lexical env.
13338 (Ffunctionp): Move from subr.el.
13339 (Ffuncall): Handle closures.
13340 (apply_lambda): Remove `eval_flags'.
13341 (funcall_lambda): Handle closures and new byte-code-functions.
13342 (Fspecial_variable_p): New function.
13343 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13344 but without exporting it to Lisp.
13346 * doc.c (Fdocumentation, store_function_docstring):
13347 * data.c (Finteractive_form): Handle closures.
13349 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13352 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13354 (exec_byte_code): New function extracted from Fbyte_code to handle new
13355 calling convention for byte-code-functions. Add new byte-codes.
13357 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13359 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13361 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13363 * xdisp.c (redisplay_internal): Fix prototype.
13365 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13367 * xdisp.c (SCROLL_LIMIT): New macro.
13368 (try_scrolling): Use it when setting scroll_limit.
13369 Limit scrolling to 100 screen lines.
13370 (redisplay_window): Even when falling back on "recentering",
13371 position point in the window according to scroll-conservatively,
13372 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13374 (try_scrolling): When point is above the window, allow searching
13375 as far as scroll_max, or one screenful, to compute vertical
13376 distance from PT to the scroll margin position. This prevents
13377 try_scrolling from unnecessarily failing when
13378 scroll-conservatively is set to a value slightly larger than the
13379 window height. Clean up the case of PT below the margin at bottom
13380 of window: scroll_max can no longer be INT_MAX. When aggressive
13381 scrolling is in use, don't let point enter the opposite scroll
13382 margin as result of the scroll.
13383 (syms_of_xdisp) <scroll-conservatively>: Document the
13384 threshold of 100 lines for never-recentering scrolling.
13386 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13388 * dispextern.h (move_it_by_lines):
13389 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13390 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13391 (message_log_check_duplicate): Remove parameters `prev_bol' and
13392 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13393 (redisplay_internal): Remove parameter `preserve_echo_area',
13394 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13396 * indent.c (Fvertical_motion):
13397 * window.c (window_scroll_pixel_based, Frecenter):
13398 Don't pass `need_y_p' to `move_it_by_lines'.
13400 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13402 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13403 steal a few bits to be more compact.
13404 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13405 Remove unneeded casts.
13407 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13409 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13411 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13412 binding" message (bug#7967).
13414 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13416 Fix more problems found by GCC 4.6.0's static checks.
13418 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13419 Remove unused local var.
13421 * editfns.c (Fmessage_box): Remove unused local var.
13423 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13424 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13425 Omit unused local vars.
13426 * window.c (shrink_windows): Omit unused local var.
13427 * menu.c (digest_single_submenu): Omit unused local var.
13428 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13429 Omit unused local var.
13431 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13432 Don't assume string length fits in int.
13433 (keyremap_step, read_key_sequence): Use size_t for sizes.
13434 (read_key_sequence): Don't check last_real_key_start redundantly.
13436 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13437 instead of alloca (Bug#8344).
13439 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13440 (Fbacktrace_frame): Don't assume nframes fits in int.
13442 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13444 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13447 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13449 * cm.c (calccost): Turn while-do into do-while, for clarity.
13451 * keyboard.c (syms_of_keyboard): Use the same style as later
13452 in this function when indexing through an array. This also
13453 works around GCC bug 48267.
13455 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13457 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13459 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13460 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13462 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13463 This avoids undefined behavior on integer overflow, and is a bit
13464 more convenient anyway since it is compared to a size_t variable.
13466 Variadic C functions now count arguments with size_t, not int.
13467 This avoids an unnecessary limitation on 64-bit machines, which
13468 caused (substring ...) to crash on large vectors (Bug#8344).
13469 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13470 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13471 All variadic functions and their callers changed accordingly.
13472 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13473 * data.c (arith_driver, float_arith_driver): Likewise.
13474 * editfns.c (general_insert_function): Likewise.
13475 * eval.c (struct backtrace.nargs, interactive_p)
13476 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13477 (funcall_lambda, mark_backtrace): Likewise.
13478 * fns.c (concat): Likewise.
13479 * frame.c (x_set_frame_parameters): Likewise.
13480 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13481 0 if not found, not -1. All callers changed.
13483 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13484 (stack_copy_size): Now size_t, not int.
13485 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13487 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13489 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13490 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13491 All callers changed.
13493 * lisp.h (multibyte_char_to_unibyte):
13494 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13495 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13496 * character.h (CHAR_TO_BYTE8):
13497 * cmds.c (internal_self_insert):
13498 * editfns.c (general_insert_function):
13499 * keymap.c (push_key_description):
13500 * search.c (Freplace_match):
13501 * xdisp.c (message_dolog, set_message_1): All callers changed.
13503 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13505 * keyboard.c (safe_run_hook_funcall): New function.
13506 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13507 don't set the hook to nil, but remove the offending function instead.
13508 (Qcommand_hook_internal): Remove, unused.
13509 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13510 Vcommand_hook_internal.
13512 * eval.c (enum run_hooks_condition): Remove.
13513 (funcall_nil, funcall_not): New functions.
13514 (run_hook_with_args): Call each function through a `funcall' argument.
13515 Remove `cond' argument, now redundant.
13516 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13517 (Frun_hook_with_args_until_failure): Adjust accordingly.
13518 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13520 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13522 * dispextern.h (string_buffer_position): Remove declaration.
13524 * print.c (strout): Remove parameter `multibyte', unused since
13525 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13527 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13528 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13529 All callers changed.
13531 * w32.c (_wsa_errlist): Use braces for struct initializers.
13533 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13534 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13535 All callers changed.
13536 (string_buffer_position): Likewise. Also, make static (it's never
13537 used outside xdisp.c).
13538 (cursor_row_p): Remove parameter `w', unused since
13539 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13540 (decode_mode_spec): Remove parameter `precision', introduced during
13541 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13542 All callers changed.
13544 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13546 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13548 2011-03-27 Anders Lindgren <andlind@gmail.com>
13550 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13551 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13552 (ns_update_auto_hide_menu_bar): New functions.
13553 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13554 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13555 ns_constrain_all_frames.
13556 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13557 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13559 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13561 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13563 2011-03-27 Glenn Morris <rgm@gnu.org>
13565 * syssignal.h: Replace RETSIGTYPE with void.
13566 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13567 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13568 Replace SIGTYPE with void everywhere.
13569 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13570 * s/template.h (SIGTYPE): Remove commented out definition.
13572 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13574 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13575 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13577 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13579 * w32.c (read_unc_volume): Use parameter `henum', instead of
13580 global variable `wget_enum_handle'.
13582 * keymap.c (describe_vector): Remove parameters `indices' and
13583 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13584 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13586 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13588 * keyboard.c (timer_check): Remove parameter `do_it_now',
13589 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13590 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13591 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13593 * keyboard.c (read_char):
13594 * w32menu.c (w32_menu_display_help):
13595 * xmenu.c (show_help_event, menu_help_callback):
13596 Adjust calls to `show_help_echo'.
13598 * gtkutil.c (xg_maybe_add_timer):
13599 * keyboard.c (readable_events):
13600 * process.c (wait_reading_process_output):
13601 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13603 * insdel.c (adjust_markers_gap_motion):
13604 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13605 (gap_left, gap_right): Don't call it.
13607 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13609 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13610 incurred during fontification.
13612 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13614 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13615 (DEFVAR_PER_BUFFER): Don't pass it.
13617 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13618 (scrolling_window): Don't pass it.
13620 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13622 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13624 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13626 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13627 of variables specific to SELinux and computation of `encoded_absname'.
13629 * image.c (XPutPixel): Remove unused variable `height'.
13631 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13633 * unexw32.c (get_section_info): Remove unused variable `section'.
13635 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13636 (system_process_attributes): Remove unused variable `sess'.
13637 (sys_read): Remove unused variable `err'.
13639 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13640 (w32_wnd_proc): Remove unused variable `isdead'.
13641 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13642 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13643 (x_create_tip_frame): Remove unused variable `tem'.
13645 * w32inevt.c (w32_console_read_socket):
13646 Remove unused variable `no_events'.
13648 * w32term.c (x_draw_composite_glyph_string_foreground):
13649 Remove unused variable `width'.
13651 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13653 * w32term.c (x_set_glyph_string_clipping):
13654 Don't pass uninitialized region to CombineRgn.
13656 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13658 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13659 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13660 (Fx_close_connection): Remove unused variable `i'.
13662 * w32font.c (w32font_draw): Return number of glyphs.
13663 (w32font_open_internal): Remove unused variable `i'.
13664 (w32font_driver): Add missing initializer.
13666 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13667 (fill_in_menu): Remove unused variable `items_added'.
13669 * w32term.c (last_mouse_press_frame): Remove static global variable.
13670 (w32_clip_to_row): Remove unused variable `f'.
13671 (x_delete_terminal): Remove unused variable `i'.
13673 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13674 (NOTHING): Remove unused static global variable.
13675 (uniscribe_check_otf): Remove unused variable `table'.
13676 (uniscribe_font_driver): Add missing initializers.
13678 2011-03-23 Julien Danjou <julien@danjou.info>
13680 * term.c (Fsuspend_tty, Fresume_tty):
13681 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13682 * window.c (temp_output_buffer_show):
13683 * insdel.c (signal_before_change):
13684 * frame.c (Fhandle_switch_frame):
13685 * fileio.c (Fdo_auto_save):
13686 * emacs.c (Fkill_emacs):
13687 * editfns.c (save_excursion_restore):
13688 * cmds.c (internal_self_insert):
13689 * callint.c (Fcall_interactively):
13690 * buffer.c (Fkill_all_local_variables):
13691 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13693 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13694 unconditionally since it does the check itself.
13696 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13698 Fix more problems found by GCC 4.5.2's static checks.
13700 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13701 the first time through the loop, since we know p0 < p1 then.
13702 This also avoids a gcc -Wstrict-overflow warning.
13704 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13705 leading to a memory leak, possible in functions like
13706 load_charset_map_from_file that can allocate an unbounded number
13707 of objects (Bug#8318).
13709 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13710 that could (at least in theory) be that large.
13712 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13713 This is less likely to overflow, and avoids undefined behavior if
13714 overflow does occur. All callers changed. Use strtoul to scan
13715 for the unsigned long integer.
13716 (pint2hrstr): Simplify and tune code slightly.
13717 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13719 * scroll.c (do_scrolling): Work around GCC bug 48228.
13720 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13722 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13723 This also avoids a warning with gcc -Wstrict-overflow.
13724 (validate_x_resource_name): Simplify count usage.
13725 This also avoids a warning with gcc -Wstrict-overflow.
13727 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13730 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13732 * process.c (Fmake_network_process): Use socklen_t, not int,
13733 where POSIX says socklen_t is required in portable programs.
13734 This fixes a porting bug on hosts like 64-bit HP-UX, where
13735 socklen_t is wider than int (Bug#8277).
13736 (Fmake_network_process, server_accept_connection):
13737 (wait_reading_process_output, read_process_output):
13740 * process.c: Rename or move locals to avoid shadowing.
13741 (list_processes_1, Fmake_network_process):
13742 (read_process_output_error_handler, exec_sentinel_error_handler):
13743 Rename or move locals.
13744 (Fmake_network_process): Define label "retry_connect" only if needed.
13745 (Fnetwork_interface_info): Fix pointer signedness.
13746 (process_send_signal): Add cast to avoid pointer signedness problem.
13747 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13748 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13750 Make tparam.h and terminfo.c consistent.
13751 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13752 Include tparam.h instead, since it declares them.
13753 * cm.h (PC): Remove extern decl; tparam.h now does this.
13754 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13755 * terminfo.c: Include tparam.h, to check interfaces.
13756 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13757 (tparam): Adjust signature to match interface in tparam.h;
13758 this removes some undefined behavior. Check that outstring and len
13759 are zero, which they always are with Emacs.
13760 * tparam.h (PC, BC, UP): New extern decls.
13762 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13763 (xftfont_open): Rename locals to avoid shadowing.
13765 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13766 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13767 (OTF_TAG_SYM): Omit macro if not needed.
13768 (ftfont_list): Remove unused local.
13769 (get_adstyle_property, ftfont_pattern_entity):
13770 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13771 Rename locals to avoid shadowing.
13773 * xfont.c (xfont_list_family): Mark var as initialized.
13775 * xml.c (make_dom): Now static.
13777 * composite.c (composition_compute_stop_pos): Rename local to
13779 (composition_reseat_it): Remove unused locals.
13780 (find_automatic_composition, composition_adjust_point): Likewise.
13781 (composition_update_it): Mark var as initialized.
13782 (find_automatic_composition): Mark vars as initialized,
13783 with a FIXME (Bug#8290).
13785 character.h: Rename locals to avoid shadowing.
13786 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13787 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13788 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13789 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13790 to avoid shadowing.
13792 * textprop.c (property_change_between_p): Remove; unused.
13794 * intervals.c (interval_start_pos): Now static.
13796 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13798 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13799 Rename locals to avoid shadowing.
13801 * sound.c (wav_play, au_play, Fplay_sound_internal):
13802 Fix pointer signedness.
13803 (alsa_choose_format): Remove unused local var.
13804 (wav_play): Initialize a variable to 0, to prevent undefined
13805 behavior (Bug#8278).
13807 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13809 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13812 clobbering (Bug#8298).
13813 * sysdep.c (sys_subshell): Likewise.
13814 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13816 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13817 This should get cleaned up, so that child_setup has the
13818 same signature on all platforms.
13820 * callproc.c (call_process_cleanup): Now static.
13821 (relocate_fd): Rename locals to avoid shadowing.
13823 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13825 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13826 not to be necessary, and produces flickering.
13828 2011-03-20 Glenn Morris <rgm@gnu.org>
13830 * config.in: Remove file.
13832 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13834 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13835 are now in src/globals.h.
13836 (syms_of_minibuf): Remove spurious & from previous change.
13838 2011-03-20 Leo Liu <sdl.web@gmail.com>
13840 * minibuf.c (completing-read-function): New variable.
13841 (completing-read-default): Rename from completing-read.
13842 (completing-read): Call completing-read-function.
13844 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13846 * xfaces.c (Fx_load_color_file):
13847 Read color file from absolute filename (bug#8250).
13849 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13851 * makefile.w32-in: Update dependencies.
13853 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13855 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13857 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13859 Fix more problems found by GCC 4.5.2's static checks.
13861 * process.c (make_serial_process_unwind, send_process_trap):
13862 (sigchld_handler): Now static.
13864 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13865 That way, the code declares only the vars that it needs.
13866 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13867 * s/cygwin.h (PTY_ITERATION): Likewise.
13868 * s/darwin.h (PTY_ITERATION): Likewise.
13869 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13871 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13872 * process.c (allocate_pty): Don't declare stb unless it's needed.
13874 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13875 (CONSTANTLIM): Remove; unused.
13876 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13877 Define only if needed.
13879 * unexelf.c (unexec): Name an expression,
13880 to avoid gcc -Wbad-function-cast warning.
13881 Use a different way to cause a compilation error if anyone uses
13882 n rather than nn, a way that does not involve shadowing.
13883 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13885 * deps.mk (unexalpha.o): Remove; unused.
13887 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13888 * unexec.h: New file.
13889 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13890 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13891 Depend on unexec.h.
13892 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13893 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13894 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13895 Change as necessary to match prototype in unexec.h.
13897 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13899 (back_comment, skip_chars): Mark vars as initialized.
13901 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13902 Rename locals to avoid shadowing.
13904 * lread.c (read1): Rewrite so as not to use empty "else".
13905 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13907 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13909 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13910 warning when compiling print.c.
13912 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13913 instead of using an uninitialized var.
13914 (font_sort_entities): Mark var as initialized.
13916 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13918 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13919 pointers to constants.
13920 (font_parse_fcname): Remove unused vars.
13921 (font_delete_unmatched): Now static.
13922 (font_get_spec): Remove; unused.
13923 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13924 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13925 Rename or move locals to avoid shadowing.
13927 * fns.c (require_nesting_list, require_unwind): Now static.
13928 (Ffillarray): Rename locals to avoid shadowing.
13930 * floatfns.c (domain_error2): Define only if needed.
13931 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13933 * alloc.c (mark_backtrace): Move decl from here ...
13934 * lisp.h: ... to here, so that it can be checked.
13936 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13937 (Fdefvar): Rewrite so as not to use empty "else".
13938 (lisp_indirect_variable): Name an expression,
13939 to avoid gcc -Wbad-function-cast warning.
13940 (Fdefvar): Rename locals to avoid shadowing.
13942 * callint.c (quotify_arg, quotify_args): Now static.
13943 (Fcall_interactively): Rename locals to avoid shadowing.
13944 Use const pointer when appropriate.
13946 * lisp.h (get_system_name, get_operating_system_release):
13947 Move decls here, to check interfaces.
13948 * process.c (get_operating_system_release): Move decl to lisp.h.
13949 * xrdb.c (get_system_name): Likewise.
13950 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13951 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13952 some of which prompt warnings from gcc -Wbad-function-cast.
13953 (Fformat_time_string, Fencode_time, Finsert_char):
13954 (Ftranslate_region_internal, Fformat):
13955 Rename or remove local vars to avoid shadowing.
13956 (Ftranslate_region_internal): Mark var as initialized.
13958 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13961 * lisp.h (eassert): Check that the argument compiles, even if
13962 ENABLE_CHECKING is not defined.
13964 * data.c (Findirect_variable): Name an expression, to avoid
13965 gcc -Wbad-function-cast warning.
13966 (default_value, arithcompare, arith_driver, arith_error): Now static.
13967 (store_symval_forwarding): Rename local to avoid shadowing.
13968 (Fmake_variable_buffer_local, Fmake_local_variable):
13969 Mark variables as initialized.
13970 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13972 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13973 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13974 Rename locals to avoid shadowing.
13975 (mark_stack): Move local variables into the #ifdef region where
13977 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13978 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13980 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13981 (GC_STRING_CHARS): Remove; not used.
13982 (Fmemory_limit): Cast sbrk's returned value to char *.
13984 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13985 avoids undefined behavior in theory.
13987 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13989 Use functions, not macros, for up- and down-casing (Bug#8254).
13990 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13991 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13992 to use the following functions instead of these macros.
13993 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13994 EMACS_INT, since callers assume the returned value fits in int.
13995 (upcase1): Likewise, for UPCASE_TABLE.
13996 (uppercasep, lowercasep, upcase): New static inline functions.
13997 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13998 the race-condition problem in the old DOWNCASE.
14000 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14001 Rename locals to avoid shadowing.
14002 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14003 (regex_compile, re_search_2, re_match_2_internal):
14004 Remove unused local vars.
14005 (FREE_VAR): Rewrite so as not to use empty "else",
14006 which gcc can warn about.
14007 (regex_compile, re_match_2_internal): Mark locals as initialized.
14008 (RETALLOC_IF): Define only if needed.
14009 (WORDCHAR_P): Likewise. This one is never needed, but is used
14010 only in a comment talking about a compiler bug, so put inside
14011 the #if 0 of that comment.
14012 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14013 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14016 * search.c (boyer_moore): Rename locals to avoid shadowing.
14017 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14018 (PREV_CHAR_BOUNDARY): Likewise.
14020 * search.c (simple_search): Remove unused var.
14022 * dired.c (compile_pattern): Move decl from here ...
14023 * lisp.h: ... to here, so that it can be checked.
14024 (struct re_registers): New forward decl.
14026 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14028 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14030 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14031 Rename locals to avoid shadowing.
14032 (Fvertical_motion): Mark locals as initialized.
14034 * casefiddle.c (casify_object, casify_region): Now static.
14035 (casify_region): Mark local as initialized.
14037 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14039 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14040 New macros, so that the caller can use some names other than
14041 gcpro1, gcpro2, etc.
14042 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14044 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14045 argument, for consistency with GCPRO2_VAR, etc: it is now the
14046 prefix of the variable, not the variable itself. All uses
14048 * dired.c (directory_files_internal, file_name_completion):
14049 Rename locals to avoid shadowing.
14051 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14052 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14053 dired.c's scmp function, had undefined behavior.
14054 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14055 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14056 * buffer.h: ... to here, because these macros use current_buffer,
14057 and the new implementation with inline functions needs to have
14058 current_buffer in scope now, rather than later when the macros
14060 (downcase, upcase1): New static inline functions.
14061 (DOWNCASE, UPCASE1): Reimplement using these functions.
14062 This avoids undefined behavior in expressions like
14063 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14064 from race conditions in accessing the global variables
14065 case_temp1 and case_temp2.
14066 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14067 * lisp.h (case_temp1, case_temp2): Remove their decls.
14068 * character.h (ASCII_CHAR_P): Move from here ...
14069 * lisp.h: ... to here, so that the inline functions mentioned
14070 above can use them.
14072 * dired.c (directory_files_internal_unwind): Now static.
14074 * fileio.c (file_name_as_directory, directory_file_name):
14075 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14077 (file_name_as_directory): Use const pointers when appropriate.
14078 (Fexpand_file_name): Likewise. In particular, newdir might
14079 point at constant storage, so make it a const pointer.
14080 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14081 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14083 (Fset_file_times, Finsert_file_contents, auto_save_error):
14084 Rename locals to avoid shadowing.
14086 * minibuf.c (choose_minibuf_frame_1): Now static.
14087 (Ftry_completion, Fall_completions): Rename or remove locals
14088 to avoid shadowing.
14090 * marker.c (bytepos_to_charpos): Remove; unused.
14092 * lisp.h (verify_bytepos, count_markers): New decls,
14093 so that gcc does not warn that these functions aren't declared.
14095 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14096 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14097 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14098 (copy_text): Remove unused local var.
14100 * filelock.c (within_one_second): Now static.
14101 (lock_file_1): Rename local to avoid shadowing.
14103 * buffer.c (fix_overlays_before): Mark locals as initialized.
14104 (fix_start_end_in_overlays): Likewise. This function should be
14105 simplified by using pointers-to-pointers, but that's a different
14107 (switch_to_buffer_1): Now static.
14108 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14109 (report_overlay_modification): Rename locals to avoid shadowing.
14111 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14112 Fix pointer signedness issue.
14113 (sys_subshell): Mark local as volatile if checking for lint,
14114 to suppress a gcc -Wclobbered warning that does not seem to be right.
14115 (MAXPATHLEN): Define only if needed.
14117 * process.c (serial_open, serial_configure): Move decls from here ...
14118 * systty.h: ... to here, so that they can be checked.
14120 * fns.c (get_random, seed_random): Move extern decls from here ...
14121 * lisp.h: ... to here, so that they can be checked.
14123 * sysdep.c (reset_io): Now static.
14124 (wait_for_termination_signal): Remove; unused.
14126 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14127 (copy_keymap_item, append_key, push_text_char_description):
14129 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14130 (DENSE_TABLE_SIZE): Remove; unused.
14131 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14132 (describe_map_tree):
14133 Rename locals to avoid shadowing.
14135 * keyboard.c: Declare functions static if they are not used elsewhere.
14136 (echo_char, echo_dash, cmd_error, top_level_2):
14137 (poll_for_input, handle_async_input): Now static.
14138 (read_char, kbd_buffer_get_event, make_lispy_position):
14139 (make_lispy_event, make_lispy_movement, apply_modifiers):
14140 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14141 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14142 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14143 (read_key_sequence, read_char): Mark locals as initialized.
14144 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14146 * keyboard.h (make_ctrl_char): New decl.
14147 (mark_kboards): Move decl here ...
14148 * alloc.c (mark_kboards): ... from here.
14150 * lisp.h (force_auto_save_soon): New decl.
14152 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14153 (DEFINE_DUMMY_FUNCTION): New macro.
14154 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14156 (main): Add casts to avoid warnings
14157 if GCC considers string literals to be constants.
14159 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14161 * dbusbind.c: Pointer signedness fixes.
14162 (xd_signature, xd_append_arg, xd_initialize):
14163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14164 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14165 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14166 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14168 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14169 if GCC considers string literals to be constants.
14170 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14172 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14174 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14175 (print_preprocess, print_object): New macro to fix last change.
14177 * print.c (print_preprocess): Don't forget font objects.
14179 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14181 * emacs.c (USAGE3): Doc fixes.
14183 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14185 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14188 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14190 * lisp.h (VWindow_system, Qfile_name_history):
14191 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14192 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14193 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14195 * w32select.c: Don't #include "keyboard.h".
14196 (run_protected): Add extern declaration for waiting_for_input.
14198 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14199 * w32console.c (detect_input_pending, read_input_pending)
14200 (encode_terminal_code):
14201 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14202 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14203 (w32_system_caret_y, Qfile_name_history):
14204 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14205 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14206 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14207 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14208 * w32proc.c (Qlocal, report_file_error):
14209 * w32term.c (Vwindow_system, updating_frame):
14210 * w32uniscribe.c (initialized, uniscribe_font_driver):
14211 Remove unneeded extern declarations.
14213 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14215 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14217 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14219 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14220 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14221 These macros can no longer be used for assignment.
14223 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14224 Assign struct members directly, instead of using BUF_BEGV etc.
14225 (record_buffer_markers, fetch_buffer_markers): New functions for
14226 recording and fetching special buffer markers.
14227 (set_buffer_internal_1, set_buffer_temp): Use them.
14229 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14231 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14233 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14234 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14236 * xdisp.c (hscroll_window_tree):
14237 (reconsider_clip_changes): Use PT instead of BUF_PT.
14239 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14241 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14242 $(EMACS_ROOT)/lib/intprops.h.
14244 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14246 Fix more problems found by GCC 4.5.2's static checks.
14248 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14249 to unsigned char * to avoid compiler diagnostic.
14250 (xg_free_frame_widgets): Make it clear that a local variable is
14251 needed only if USE_GTK_TOOLTIP.
14252 (gdk_window_get_screen): Make it clear that this macro is needed
14253 only if USE_GTK_TOOLTIP.
14254 (int_gtk_range_get_value): New function, which avoids a diagnostic
14255 from gcc -Wbad-function-cast.
14256 (xg_set_toolkit_scroll_bar_thumb): Use it.
14257 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14258 diagnostic from gcc -Wbad-function-cast.
14259 (get_utf8_string, xg_get_file_with_chooser):
14260 Rename locals to avoid shadowing.
14261 (create_dialog): Move locals to avoid shadowing.
14263 * xgselect.c (xg_select): Remove unused var.
14265 * image.c (four_corners_best): Mark locals as initialized.
14266 (gif_load): Initialize transparent_p to zero (Bug#8238).
14267 Mark another local as initialized.
14268 (my_png_error, my_error_exit): Mark with NO_RETURN.
14270 * image.c (clear_image_cache): Now static.
14271 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14272 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14273 (x_edge_detection): Remove unnecessary cast that
14274 gcc -Wbad-function-cast diagnoses.
14275 (gif_load): Fix pointer signedness.
14276 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14277 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14279 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14281 Improve quality of tests for time stamp overflow.
14282 For example, without this patch (encode-time 0 0 0 1 1
14283 1152921504606846976) returns the obviously-bogus value (-948597
14284 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14285 reports time overflow. See
14286 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14287 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14288 * editfns.c: Include limits.h and intprops.h.
14289 (TIME_T_MIN, TIME_T_MAX): New macros.
14290 (time_overflow): Move earlier, to before first use.
14291 (hi_time, lo_time): New functions, for an accurate test for
14292 out-of-range times.
14293 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14294 (Fget_internal_run_time): Don't assume time_t fits in int.
14295 (make_time): Use list2 instead of Fcons twice.
14296 (Fdecode_time): More accurate test for out-of-range times.
14297 (check_tm_member): New function.
14298 (Fencode_time): Use it, to test for out-of-range times.
14299 (lisp_time_argument): Don't rely on undefined left-shift and
14300 right-shift behavior when checking for time stamp overflow.
14302 * editfns.c (time_overflow): New function, refactoring common code.
14303 (Fformat_time_string, Fdecode_time, Fencode_time):
14304 (Fcurrent_time_string): Use it.
14306 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14307 * dired.c (make_time): Move to ...
14308 * editfns.c (make_time): ... here.
14309 * systime.h: Note the move.
14311 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14313 * fringe.c (update_window_fringes): Remove unused variables.
14315 * unexmacosx.c (copy_data_segment): Also copy __got section.
14318 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14320 * termcap.c [MSDOS]: Include "msdos.h".
14321 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14322 Constify `char *' arguments and their references according to
14323 prototypes in tparam.h.
14325 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14327 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14328 Adapt all references accordingly.
14330 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14332 2011-03-11 Tom Tromey <tromey@redhat.com>
14334 * buffer.c (syms_of_buffer): Remove obsolete comment.
14336 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14338 * termhooks.h (encode_terminal_code): Declare prototype.
14340 * msdos.c (encode_terminal_code): Don't declare prototype.
14342 * term.c (encode_terminal_code): Now external again, used by
14343 w32console.c and msdos.c.
14345 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14346 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14348 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14350 Fix some minor problems found by GCC 4.5.2's static checks.
14352 * fringe.c (update_window_fringes): Mark locals as initialized
14354 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14356 * alloc.c (mark_fringe_data): Move decl from here ...
14357 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14358 to check its interface.
14359 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14361 * fontset.c (free_realized_fontset): Now static.
14362 (Fset_fontset_font): Rename local to avoid shadowing.
14363 (fontset_font): Mark local as initialized.
14364 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14366 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14368 * xselect.c (x_disown_buffer_selections): Remove; not used.
14369 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14370 (x_own_selection, Fx_disown_selection_internal): Rename locals
14371 to avoid shadowing.
14372 (x_handle_dnd_message): Remove local to avoid shadowing.
14374 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14375 so that the caller can use some name other than gcpro1.
14376 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14377 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14378 (Fx_backspace_delete_keys_p):
14379 Use them to avoid shadowing, and rename vars to avoid shadowing.
14380 (x_decode_color, x_set_name, x_window): Now static.
14381 (Fx_create_frame): Add braces to silence GCC warning.
14382 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14383 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14384 Remove unused locals.
14385 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14386 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14387 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14390 * xterm.h (x_mouse_leave): New decl.
14392 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14393 Remove unused functions.
14394 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14395 (x_calc_absolute_position): Now static.
14396 (XTread_socket): Don't define label "out" unless it's used.
14397 Don't declare local "event" unless it's used.
14398 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14399 unless they are used.
14400 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14401 (x_fatal_error_signal): Remove; not used.
14402 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14403 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14404 (x_error_catcher, x_connection_closed, x_error_handler):
14405 (x_error_quitter, xembed_send_message, x_iconify_frame):
14406 (my_log_handler): Rename locals to avoid shadowing.
14407 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14408 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14410 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14411 Rename or move locals to avoid shadowing.
14412 (tty_defined_color, merge_face_heights): Now static.
14413 (free_realized_faces_for_fontset): Remove; not used.
14414 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14415 does not deduce is never used uninitialized.
14416 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14417 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14419 * terminal.c (store_terminal_param): Now static.
14421 * xmenu.c (menu_highlight_callback): Now static.
14422 (set_frame_menubar): Remove unused local.
14423 (xmenu_show): Rename parameter to avoid shadowing.
14424 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14425 since they might point to immutable storage.
14426 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14427 since it's unused otherwise.
14429 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14430 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14431 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14432 avoids a gcc -Wuninitialized diagnostic.
14433 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14434 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14435 does not deduce are never used uninitialized.
14437 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14439 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14440 * window.c (window_loop, size_window):
14441 (run_window_configuration_change_hook, enlarge_window): Likewise.
14443 * window.c (display_buffer): Now static.
14444 (size_window): Mark variables that gcc -Wuninitialized
14445 does not deduce are never used uninitialized.
14446 * window.h (check_all_windows): New decl, to forestall
14447 gcc -Wmissing-prototypes diagnostic.
14448 * dispextern.h (bidi_dump_cached_states): Likewise.
14450 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14452 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14453 Include <limits.h>.
14454 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14455 and to avoid gcc -Wuninitialized warning.
14456 (load_charset_map): Mark variables that gcc -Wuninitialized
14457 does not deduce are never used uninitialized.
14458 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14460 * coding.c (coding_set_source, coding_set_destination):
14461 Use "else { /* comment */ }" rather than "else /* comment */;"
14462 for clarity, and to avoid gcc -Wempty-body warning.
14463 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14464 a block, when the outer 'i' will do.
14465 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14466 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14467 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14468 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14469 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14470 Rename locals to avoid shadowing.
14471 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14472 * coding.c (emacs_mule_char, encode_invocation_designation):
14473 Now static, since they're not used elsewhere.
14474 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14475 (decode_coding_object, encode_coding_object, detect_coding_system):
14476 (decode_coding_emacs_mule): Mark variables that gcc
14477 -Wuninitialized does not deduce are never used uninitialized.
14478 (detect_coding_iso_2022): Initialize a local variable that might
14479 be used uninitialized. Leave a FIXME because it's not clear that
14480 this initialization is needed. (Bug#8211)
14481 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14482 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14483 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14484 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14485 Remove unused macros.
14487 * category.c (hash_get_category_set): Remove unused local var.
14488 (copy_category_table): Now static, since it's not used elsewhere.
14489 * character.c (string_count_byte8): Likewise.
14491 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14492 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14494 * chartab.c (copy_sub_char_table): Now static, since it's not used
14496 (sub_char_table_ref_and_range, char_table_ref_and_range):
14497 Rename locals to avoid shadowing.
14498 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14500 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14501 (BIDI_BOB): Remove unused macro.
14503 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14504 deduce are never used uninitialized.
14505 * term.c (encode_terminal_code): Likewise.
14507 * term.c (encode_terminal_code): Now static. Remove unused local.
14509 * tparam.h: New file.
14510 * term.c, tparam.h: Include it.
14511 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14512 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14513 Move these decls to tparam.h, and make them agree with what
14514 is actually in tparam.c. The previous trick of using incompatible
14515 decls in different modules does not conform to the C standard.
14516 All callers of tparam changed to use tparam's actual API.
14517 * tparam.c (tparam1, tparam, tgoto):
14518 Use const pointers where appropriate.
14520 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14521 * cm.h (struct cm): Likewise.
14522 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14523 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14524 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14525 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14526 (turn_on_face, init_tty): Likewise.
14527 * termchar.h (struct tty_display_info): Likewise.
14529 * term.c (term_mouse_position): Rename local to avoid shadowing.
14531 * alloc.c (mark_ttys): Move decl from here ...
14532 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14534 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14536 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14538 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14540 * search.c (compile_pattern_1): Remove argument regp, unused since
14541 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14542 (compile_pattern): Don't pass it.
14544 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14546 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14547 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14549 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14551 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14553 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14554 gdk_window_get_screen, gdk_window_get_geometry,
14555 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14556 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14557 (xg_get_pixbuf_from_pixmap): New function.
14558 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14559 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14560 Call xg_get_pixbuf_from_pixmap instead of
14561 gdk_pixbuf_get_from_drawable.
14562 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14563 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14564 (xg_check_special_colors): Use GtkStyleContext and its functions
14566 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14567 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14568 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14569 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14570 Call gtk_widget_get_preferred_size.
14571 (xg_frame_resized): gdk_window_get_geometry only takes 5
14573 (xg_win_to_widget, xg_event_is_for_menubar):
14574 Call gdk_x11_window_lookup_for_display.
14575 (xg_set_widget_bg): New function.
14576 (delete_cb): New function.
14577 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14578 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14579 (xg_set_background_color): Call xg_set_widget_bg.
14580 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14581 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14582 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14583 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14585 (update_frame_tool_bar): Call gtk_widget_hide.
14586 (xg_initialize): Use GDK_KEY_g.
14588 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14590 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14592 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14593 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14594 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14596 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14598 * w32xfns.c (select_palette): Check success of RealizePalette against
14599 GDI_ERROR, not zero.
14601 See ChangeLog.11 for earlier changes.
14603 ;; Local Variables:
14607 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14609 This file is part of GNU Emacs.
14611 GNU Emacs is free software: you can redistribute it and/or modify
14612 it under the terms of the GNU General Public License as published by
14613 the Free Software Foundation, either version 3 of the License, or
14614 (at your option) any later version.
14616 GNU Emacs is distributed in the hope that it will be useful,
14617 but WITHOUT ANY WARRANTY; without even the implied warranty of
14618 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14619 GNU General Public License for more details.
14621 You should have received a copy of the GNU General Public License
14622 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.