]> code.delx.au - gnu-emacs/blob - src/ChangeLog
ce049ebfc84bab056a61c79b66f90ab532f02595
[gnu-emacs] / src / ChangeLog
1 2011-10-18 Chong Yidong <cyd@gnu.org>
2
3 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4 with nobreak-char-display too.
5
6 2011-10-18 Eli Zaretskii <eliz@gnu.org>
7
8 Fix part 3 of bug#9771.
9 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10 (bidi_resolve_neutral): Don't enter the expensive loop looking for
11 non-neutral characters if the current character is a paragraph
12 separator (a.k.a. Newline). This avoids running the same
13 expensive loop twice, once when we consume the preceding newline
14 and the other time when the line actually needs to be displayed.
15 Avoid the loop when we see neutrals on the base embedding level
16 following a character whose directionality is the same as the
17 paragraph's. This avoids running the expensive loop when a line
18 ends in a long sequence of neutrals, like control characters.
19 Add assertion against STRONG_AL type. Slightly rearrange code
20 that determines the type of a neutral given the first non-neutral
21 that follows it.
22 (bidi_level_of_next_char): Set next_en_pos to zero when
23 invalidating its info.
24
25 2011-10-17 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (push_display_prop): Determine whether to record string
28 or buffer position by IT->string, not by IT->method. Allow
29 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
30 (move_it_vertically_backward): Don't look for character position
31 immediately after the newline when in a continuation line.
32 (Bug#9771, part 1)
33
34 2011-10-15 Martin Rudalics <rudalics@gmx.at>
35
36 * window.c (coordinates_in_window): Rewrite and delabelize
37 vertical border check. (Bug#5357) (Bug#9618)
38
39 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
40
41 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
42 errors in XSetWindowBorder (bug#9310).
43
44 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
45
46 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
47 avoid crash when xmalloc overrun checking is enabled.
48
49 2011-10-13 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
52 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
53 cursor motion with <left> and <right> arrow keys.
54
55 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
56 some callers set that themselves.
57
58 2011-10-12 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
61 display string and the previous row comes from the same string and
62 is empty. (Bug#9739) (Bug#9738)
63
64 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
65
66 * doc.c (get_doc_string): Encode file name (bug#9735).
67
68 2011-10-12 Eli Zaretskii <eliz@gnu.org>
69
70 * bidi.c (bidi_level_of_next_char):
71 * xdisp.c (get_visually_first_element): Remove old incorrect
72 comments regarding the Unicode Line Separator character.
73
74 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
75
76 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
77
78 * alloc.c (Fgc_status): Do not access beyond zombies array
79 boundary if nzombies > MAX_ZOMBIES.
80 * alloc.c (dump_zombies): Add missing format specifier.
81
82 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
83
84 * xdisp.c (set_cursor_from_row): Simplify conditionals,
85 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
86
87 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
88 Some packages use them to denote characters with modifiers.
89
90 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
91
92 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
93 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
94 matching a pp-number. Rename parameter var to var1.
95
96 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
97
98 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
99
100 2011-10-08 Glenn Morris <rgm@gnu.org>
101
102 * callint.c (Fcall_interactively): Give a more explicit error for the
103 'c' case with a non-character input. (Bug#8479)
104
105 2011-10-08 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
108 lines.
109 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
110 lines that are hscrolled on the left.
111
112 * dispnew.c (buffer_posn_from_coords): Account for a possible
113 presence of header-line. (Bug#4426)
114
115 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
116
117 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
118 Don't advertise functionality which we discourage or doesn't work.
119
120 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
121
122 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
123 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
124 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
125 this makes Emacs dump core during garbage collection on rare
126 occasions. sizeof is obviously inferior to offsetof here, so
127 stick with offsetof.
128 (GC_POINTER_ALIGNMENT): New macro.
129 (mark_memory): Omit 3rd (offset) arg; caller changed.
130 Don't assume EMACS_INT alignment is the same as pointer alignment.
131
132 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
133
134 * keyboard.c (read_key_sequence_remapped): New var.
135 (read_key_sequence): Compute remapping in the right buffer.
136 (command_loop_1): Use read_key_sequence's remapping directly.
137
138 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
139
140 * dired.c (file_name_completion): Don't expand file name.
141 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
142 before checking file name handler.
143
144 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
145 they've been requested explicitly (bug#9591).
146
147 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
148
149 * keymap.c (Fsingle_key_description): Use make_specified_string
150 instead of build_string to build string from push_key_description.
151 (Bug#5193)
152
153 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
154
155 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
156 This fixes a Y2038 bug on 64-bit hosts.
157 * buffer.c (reset_buffer):
158 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
159 (Fclear_buffer_auto_save_failure):
160 Use 0, not -1, to represent an unset failure time, since time_t
161 might not be signed.
162
163 Remove dependency on glibc malloc internals.
164 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
165 Move back here from lisp.h, but with their new implementations.
166 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
167 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
168 * charset.c (charset_table_init): New static var.
169 (syms_of_charset): Use it instead of xmalloc. This removes a
170 dependency on glibc malloc internals. See Eli Zaretskii's comment in
171 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
172 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
173 Move back to alloc.c.
174 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
175 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
176
177 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
178
179 * nsterm.m (windowDidResize): Call x_set_window_size only when
180 ns_in_resize is true. Otherwise set pixelwidth/height and
181 call change_frame_size (Bug#9628).
182
183 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
184
185 Port --enable-checking=all to Fedora 14 x86-64.
186 * charset.c (syms_of_charset): Also account for glibc malloc's
187 internal overhead when calculating the initial malloc maximum.
188
189 Port --enable-checking=all to Fedora 14 x86.
190 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
191 Move to lisp.h.
192 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
193 (overrun_check_realloc, overrun_check_free):
194 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
195 That way, xmalloc returns a properly-aligned pointer even if
196 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
197 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
198 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
199 into account when calculating the initial malloc maximum.
200 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
201 Move here from alloc.c, so that charset.c can use it too.
202 Properly align; the old code wasn't right for common 32-bit hosts
203 when configured with --enable-checking=all.
204 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
205 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
206
207 2011-09-29 Eli Zaretskii <eliz@gnu.org>
208
209 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
210 use EDOM.
211
212 2011-09-28 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (compute_display_string_end): If there's no display
215 string at CHARPOS, return -1.
216
217 * bidi.c (bidi_fetch_char): When compute_display_string_end
218 returns a negative value, treat the character as a normal
219 character not covered by a display string. (Bug#9624)
220
221 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
222
223 * lread.c (Fread_from_string): Fix typo in docstring.
224
225 2011-09-27 Eli Zaretskii <eliz@gnu.org>
226
227 * xdisp.c (handle_invisible_prop): If invisible text ends on a
228 newline, reseat the iterator instead of bidi-iterating there one
229 character at a time. (Bug#9610)
230 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
231 TO_CHARPOS if the bidi iterator is at base embedding level.
232
233 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
234
235 * lread.c (readevalloop): Use correct code for NBSP.
236 (read1): Likewise. (Bug#9608)
237
238 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
239
240 * dbusbind.c (Fdbus_register_signal): When service is not
241 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
242
243 2011-09-25 Glenn Morris <rgm@gnu.org>
244
245 * buffer.c (truncate-lines): Doc fix.
246
247 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
248
249 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
250 (Fset_window_next_buffers): Doc fix.
251
252 2011-09-24 Glenn Morris <rgm@gnu.org>
253
254 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
255
256 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
257
258 Fix minor problems found by static checking.
259 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
260 * indent.c (Fvertical_motion): Fix == vs = typo.
261
262 2011-09-24 Eli Zaretskii <eliz@gnu.org>
263
264 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
265 Default value is now t. Doc fix.
266
267 * indent.c (Fvertical_motion): Compute and apply the overshoot
268 logic when moving up, not only when moving down. Fix the
269 confusing name and values of the it_overshoot_expected variable;
270 logic changes accordingly. (Bug#9254) (Bug#9549)
271
272 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
273 CHARPOS is covered by a display string which includes newlines.
274 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
275 is covered by a display string with embedded newlines.
276
277 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
278
279 * dbusbind.c (Fdbus_register_signal): Add match rule to
280 Vdbus_registered_objects_table. (Bug#9581)
281 (Fdbus_register_method, Vdbus_registered_objects_table):
282 Fix docstring.
283
284 2011-09-24 Jim Meyering <meyering@redhat.com>
285
286 do not ignore write error for any output size
287 The previous change was incomplete.
288 While it makes emacs --batch detect the vast majority of stdout
289 write failures, errors were still ignored whenever the output size is
290 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
291 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
292 && echo FAIL: ignored write error
293 FAIL: ignored write error
294 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
295 && echo FAIL: ignored write error
296 FAIL: ignored write error
297 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
298
299 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
300
301 * emacs.c (Fkill_emacs): In noninteractive mode exit
302 non-successfully if a write error occurred on stdout. (Bug#9574)
303
304 2011-09-21 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
307 the xassert test.
308
309 * dispextern.h (struct it): Update the comment documenting what
310 can it->OBJECT be.
311
312 2011-09-20 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
315 a display string, extend search for cursor position to end of row.
316 (find_row_edges): If the row ends in a newline from a display
317 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
318 Handle the case of a display string with multiple newlines.
319 (Fcurrent_bidi_paragraph_direction): Fix search for previous
320 non-empty line. Fixes confusing cursor motion with arrow keys at
321 the beginning of a line that starts with whitespace.
322
323 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
324
325 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
326 (bug#9493).
327
328 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
329
330 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
331 boolean (Bug#9154).
332
333 2011-09-18 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (display_line): Record maximum and minimum buffer
336 positions even if no glyphs were produced (e.g., by a zero-width
337 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
338 buffer positions that will be removed from the glyph row because
339 they don't fit.
340 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
341 column is beyond frame width: don't subtract 1 "pixel" when
342 computing width of the stretch.
343 (reseat_at_next_visible_line_start): Undo the change made on
344 2011-09-17 that saved paragraph information and restored it after
345 the call to `reseat'. (Bug#9545)
346
347 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
348
349 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
350 and turn window cursor on if cleared (Bug#9415).
351
352 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
353
354 * search.c (boyer_moore): Take unibyte characters from pattern
355 literally. (Bug#9458)
356
357 2011-09-18 Eli Zaretskii <eliz@gnu.org>
358
359 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
360
361 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
362
363 Fix minor problem found by static checking.
364 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
365 initialized, to pacify gcc -Wuninitialized.
366
367 * fileio.c: Report proper errno when syscall falls.
368 (Finsert_file_contents): Save and restore errno,
369 so that report_file_error outputs the correct diagnostic.
370 (Fwrite_region) [CLASH_DETECTION]: Likewise.
371
372 2011-09-18 Eli Zaretskii <eliz@gnu.org>
373
374 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
375
376 2011-09-17 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
379 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
380
381 2011-09-17 Eli Zaretskii <eliz@gnu.org>
382
383 * xdisp.c (reseat_at_next_visible_line_start): Keep information
384 about the current paragraph and restore it after the call to reseat.
385
386 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
387 (bidi_find_paragraph_start): Search back for paragraph beginning
388 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
389 (bidi_move_to_visually_next): Only trigger paragraph-related
390 computations when the last character is a newline or at EOB, not
391 just any NEUTRAL_B. (Bug#9470)
392
393 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
394 truncated lines if point is covered by a display string. (Bug#9524)
395
396 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
397
398 * xselect.c: Relax test for outgoing X longs (Bug#9498).
399 (cons_to_x_long): New function.
400 (lisp_data_to_selection_data): Use it. Correct the test for
401 short-versus-long data; it was negated. Break out of vector
402 loop, for efficiency, when a long datum is discovered.
403
404 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
407
408 2011-09-16 Eli Zaretskii <eliz@gnu.org>
409
410 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
411 GCC PR/17406) by declaring this function with external scope.
412
413 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
414
415 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
416 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
417
418 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
419
420 * editfns.c (Fformat): Correctly handle text properties on "%%".
421
422 2011-09-15 Eli Zaretskii <eliz@gnu.org>
423
424 * xterm.c (x_draw_composite_glyph_string_foreground):
425 * w32term.c (x_draw_composite_glyph_string_foreground):
426 * term.c (encode_terminal_code):
427 * composite.c (composition_update_it, get_composition_id):
428 * xdisp.c (get_next_display_element)
429 (fill_composite_glyph_string): Add comments about special meaning
430 of TAB characters in a composition.
431
432 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
433
434 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
435 This occurs when processing a multibyte format.
436 Problem reported by Wolfgang Jenker.
437
438 2011-09-15 Johan Bockgård <bojohan@gnu.org>
439
440 * xdisp.c (try_cursor_movement): Only check for exact match if
441 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
442
443 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
444
445 Remove unused external symbols.
446 * dispextern.h (calc_pixel_width_or_height): Remove decl.
447 * xdisp.c (calc_pixel_width_or_height): Now static.
448 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
449 * indent.c (check_display_width):
450 * w32term.c: Fix comment to match code.
451 * xterm.c, xterm.h (x_catching_errors): Remove.
452
453 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
454
455 * xselect.c: Use signed conversions more consistently (Bug#9498).
456 (selection_data_to_lisp_data): Assume incoming selection data are
457 signed integers, not unsigned. This is to be consistent with
458 outgoing selection data, which was modified to use signed integers
459 in as part of the fix to Bug#9196 in response to Jan D.'s comment
460 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
461 expects long, not unsigned long.
462
463 2011-09-14 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
466 computation of loop end. Reported by Johan Bockgård
467 <bojohan@gnu.org>.
468
469 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
470
471 * frame.c (Fother_visible_frames_p): Function deleted.
472
473 2011-09-12 Eli Zaretskii <eliz@gnu.org>
474
475 * indent.c (compute_motion): Process display vector front to back
476 rather than the other way around. (Bug#2496)
477
478 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
479
480 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
481
482 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
483
484 * minibuf.c (Fread_from_minibuffer): Doc fix.
485
486 2011-09-11 Eli Zaretskii <eliz@gnu.org>
487
488 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
489 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
490
491 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
492
493 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
494 value for non-existent files.
495
496 2011-09-11 Eli Zaretskii <eliz@gnu.org>
497
498 * fileio.c (Finsert_file_contents): If the file cannot be opened,
499 set its "size" to -1. This will set the modtime_size field of
500 the corresponding buffer to -1, which is what
501 verify-visited-file-modtime expects for files that do not exist.
502 (Bug#9139)
503
504 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
505
506 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
507 here ...
508 * lisp.h: ... from here. push_key_description is no longer
509 defined in keyboard.c, so its declaration should not be in
510 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
511 logically belongs with push_key_description.
512
513 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
514
515 * buffer.h: Include <sys/types.h> instead of <time.h>.
516 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
517 Problem reported by Herbert J. Skuhra.
518
519 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
520
521 * xml.c (parse_region): Make the parsing work for
522 non-comment-starting XML files again (bug#9144).
523
524 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
525
526 * image.c (gif_load): Fix calculation of bottom and right corner.
527 (Bug#9468)
528
529 2011-09-10 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
532 redisplay in small windows.
533
534 2011-09-09 Eli Zaretskii <eliz@gnu.org>
535
536 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
537
538 2011-09-08 Martin Rudalics <rudalics@gmx.at>
539
540 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
541 Operate on live windows only.
542
543 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
544
545 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
546
547 2011-09-07 Eli Zaretskii <eliz@gnu.org>
548
549 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
550 only under bidi iteration.
551
552 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
553
554 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
555
556 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
557
558 isnan: Fix porting problem to Solaris 10 with bundled gcc.
559 Without this fix, the command to link temacs failed due to an
560 undefined symbol __builtin_isnan. This is because
561 /usr/include/iso/math_c99.h #defines isnan(x) to
562 __builtin_isnan(x), but the bundled gcc, which identifies itself
563 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
564 a __builtin_isnan.
565 * floatfns.c (isnan): #undef, and then #define to a clone of
566 what's in data.c.
567 (Fisnan): Always define, since it's always available now.
568 (syms_of_floatfns): Always define isnan at the Lisp level.
569
570 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
571
572 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
573
574 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
575
576 * fileio.c: Fix bugs with large file offsets (Bug#9428).
577 The previous code assumed that file offsets (off_t values) fit in
578 EMACS_INT variables, which is not true on typical 32-bit hosts.
579 The code messed up by falsely reporting buffer overflow in cases
580 such as (insert-file-contents "big" nil 1 2) into an empty buffer
581 when "big" contains more than 2**29 bytes, even though this
582 inserts just one byte and does not overflow the buffer.
583 (Finsert_file_contents): Store file offsets as off_t
584 values, not as EMACS_INT values. Check for overflow when
585 converting between EMACS_INT and off_t. When checking for
586 buffer overflow or for overlap, take the offsets into account.
587 Don't use EMACS_INT for small values where int suffices.
588 When checking for overlap, fix a typo: ZV was used where
589 ZV_BYTE was intended.
590 (Fwrite_region): Don't assume off_t fits into 'long'.
591 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
592
593 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
594
595 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
596
597 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
598
599 sprintf-related integer and memory overflow issues (Bug#9412).
600
601 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
602 (esprintf, exprintf, evxprintf): New functions.
603 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
604 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
605 (modify_event_symbol): Do not assume that the length of
606 name_alist_or_stem is safe to alloca and fits in int.
607 (Fexecute_extended_command): Likewise for function name and binding.
608 (Frecursion_depth): Wrap around reliably on integer overflow.
609 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
610 since some callers pass EMACS_INT values.
611 (Fsingle_key_description): Don't crash if symbol name contains more
612 than MAX_ALLOCA bytes.
613 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
614 (get_minibuffer): Arg is now EMACS_INT, not int.
615 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
616 (esprintf, exprintf, evxprintf): New decls.
617 * window.h (command_loop_level, minibuf_level): Reflect API changes.
618
619 * dbusbind.c (signature_cat): New function.
620 (xd_signature, Fdbus_register_signal):
621 Do not overrun buffer; instead, report string overflow.
622
623 * dispnew.c (add_window_display_history): Don't overrun buffer.
624 Truncate instead; this is OK since it's just a log.
625
626 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
627 even if the time zone offset is outlandishly large.
628 Don't mishandle offset == INT_MIN.
629
630 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
631 when creating daemon; the previous buffer-overflow check was incorrect.
632
633 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
634 which has the guts of the old verror function.
635
636 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
637 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
638
639 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
640 (font_unparse_xlfd): Don't blindly alloca long strings.
641 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
642 fits in int, when using sprintf. Use single snprintf to count
643 length of string rather than counting it via multiple sprintfs;
644 that's simpler and more reliable.
645 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
646 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
647 sprintf, in case result does not fit in int.
648
649 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
650 (fontset_from_font): Print it.
651
652 * frame.c (tty_frame_count): Now printmax_t, not int.
653 (make_terminal_frame, set_term_frame_name): Print it.
654 (x_report_frame_params): In X, window IDs are unsigned long,
655 not signed long, so print them as unsigned.
656 (validate_x_resource_name): Check for implausibly long names,
657 and don't assume name length fits in 'int'.
658 (x_get_resource_string): Don't blindly alloca invocation name;
659 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
660 not fit in int.
661
662 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
663 (xg_check_special_colors, xg_set_geometry):
664 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
665
666 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
667 Use esprintf, not sprintf, in case result does not fit in int.
668
669 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
670 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
671 it as a large positive number.
672 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
673 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
674
675 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
676 in case result does not fit in int.
677
678 * print.c (float_to_string): Detect width overflow more reliably.
679 (print_object): Make sprintf buffer a bit bigger, to avoid potential
680 buffer overrun. Don't assume list length fits in 'int'. Treat
681 print length of 0 as 0, not as infinity; to be consistent with other
682 uses of print length in this function. Don't overflow print length
683 index. Don't assume hash table size fits in 'long', or that
684 vectorlike size fits in 'unsigned long'.
685
686 * process.c (make_process): Use printmax_t, not int, to format
687 process-name gensyms.
688
689 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
690
691 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
692 to avoid potential buffer overrun.
693
694 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
695 if X resource line is longer than 512 bytes.
696
697 * xfns.c (x_window): Make sprintf buffer a bit bigger
698 to avoid potential buffer overrun.
699
700 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
701
702 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
703
704 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
705
706 Integer overflow fixes for scrolling, etc.
707 Without these, Emacs silently mishandles large integers sometimes.
708 For example, "C-u 4294967297 M-x recenter" was treated as if
709 it were "C-u 1 M-x recenter" on a typical 64-bit host.
710
711 * xdisp.c (try_window_id): Check Emacs fixnum range before
712 converting to 'int'.
713
714 * window.c (window_scroll_line_based, Frecenter):
715 Check that an Emacs fixnum is in range before assigning it to 'int'.
716 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
717 values converted from Emacs fixnums.
718 (Frecenter): Don't wrap around a line count if it is out of 'int'
719 range; instead, treat it as an extreme value.
720 (Fset_window_configuration, compare_window_configurations):
721 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
722
723 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
724 that can exceed INT_MAX. Check that EMACS_INT value is in range
725 before assigning it to the (possibly-narrower) index.
726 (match_limit): Don't assume that a fixnum can fit in 'int'.
727
728 * print.c (print_object): Use ptrdiff_t, not int, for index that can
729 exceed INT_MAX.
730
731 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
732 (Fvertical_motion): Don't wrap around LINES values that don't fit
733 in 'int'. Instead, treat them as extreme values. This is good
734 enough for windows, which can't have more than INT_MAX lines anyway.
735
736 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
737
738 * Require libxml/parser.h to avoid compilation warning.
739
740 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
741
742 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
743 since this reportedly can destroy thread storage.
744
745 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
746
747 * syntax.c (find_defun_start): Update all cache variables if
748 exiting early (Bug#9401).
749
750 2011-08-30 Eli Zaretskii <eliz@gnu.org>
751
752 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
753
754 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
755 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
756 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
757
758 * term.c (tty_append_glyph): New function.
759 (produce_stretch_glyph): Static function and its prototype deleted.
760
761 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
762 Add prototypes.
763
764 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
765
766 * image.c (parse_image_spec): Check for nonnegative, not for positive,
767 when checking :margin (Bug#9390).
768 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
769 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
770 so that the name doesn't mislead. All uses changed.
771
772 2011-08-28 Johan Bockgård <bojohan@gnu.org>
773
774 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
775 set_tty_hooks.
776
777 2011-08-27 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (move_it_to): Don't bail out early when reaching
780 position beyond to_charpos, if we are scanning backwards.
781 (move_it_vertically_backward): When DY == 0, make sure we get to
782 the first character in the line after the newline.
783
784 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
785
786 * ccl.c: Improve and simplify overflow checking (Bug#9196).
787 (ccl_driver): Do not generate an out-of-range pointer.
788 (Fccl_execute_on_string): Remove unnecessary check for
789 integer overflow, noted by Stefan Monnier in
790 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
791 Remove a FIXME that didn't need fixing.
792 Simplify the newly-introduced buffer reallocation code.
793
794 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
795
796 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
797
798 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
799
800 Integer and memory overflow issues (Bug#9196).
801
802 * doc.c (get_doc_string): Rework so that
803 get_doc_string_buffer_size is the actual buffer size, rather than
804 being 1 less than the actual buffer size; this makes xpalloc more
805 convenient.
806
807 * image.c (x_allocate_bitmap_record, cache_image):
808 * xselect.c (Fx_register_dnd_atom):
809 Simplify previous changes by using xpalloc.
810
811 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
812 since either will do and ptrdiff_t is convenient with xpalloc.
813
814 * charset.c (charset_table_size)
815 (struct charset_sort_data.priority): Now ptrdiff_t.
816 (charset_compare): Don't overflow if priorities differ greatly.
817 (Fsort_charsets): Don't assume list length fits in int.
818 Check for size-calculation overflow when allocating sort data.
819 (syms_of_charset): Allocate an initial charset table that is
820 just under 64 KiB, to avoid problems with glibc malloc and mmap.
821
822 * cmds.c (internal_self_insert): Check for size-calculation overflow.
823
824 * composite.h (struct composition.glyph_len): Now int, not unsigned.
825 The actual value is always <= INT_MAX, and leaving it unsigned made
826 overflow checking harder.
827
828 * dispextern.h (struct glyph_matrix.rows_allocated)
829 (struct face_cache.size): Now ptrdiff_t, for convenience in use
830 with xpalloc. The values are still always <= INT_MAX.
831
832 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
833
834 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
835 (SAFE_NALLOCA): New macro.
836
837 * region-cache.c (struct boundary.pos, find_cache_boundary)
838 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
839 (set_cache_region, invalidate_region_cache)
840 (revalidate_region_cache, know_region_cache, region_cache_forward)
841 (region_cache_backward, pp_cache):
842 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
843 so that ptrdiff_t * can be passed to xpalloc.
844 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
845 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
846 (pp_cache): Don't assume cache_len fits in int.
847 * region-cache.h: Adjust extern decls to match.
848
849 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
850 EMACS_INT, since either will do, for xpalloc.
851
852 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
853 (xnmalloc, xnrealloc, xpalloc): New functions.
854
855 * bidi.c (bidi_shelve_header_size): New constant.
856 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
857 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
858
859 * bidi.c (bidi_cache_shrink):
860 * buffer.c (overlays_at, overlays_in, record_overlay_string)
861 (overlay_strings):
862 Don't update size of array until after memory allocation succeeds,
863 because xmalloc/xrealloc may not return.
864 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
865 now that we have proper integer overflow checking.
866 (record_overlay_string, overlay_strings): Catch overflows when
867 calculating size of overlay_str_buf.
868
869 * callproc.c (Fcall_process): Check for size overflow when
870 calculating size of args2.
871 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
872 Normally we prefer signed values, but sticking with ptrdiff_t would
873 require adding more-complicated checks.
874
875 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
876 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
877 Redo buffer-overflow calculations to avoid integer overflow.
878 Add a FIXME comment where memory seems to be over-allocated.
879
880 * character.c (Fstring): Check for size-calculation overflow.
881
882 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
883 unnecessary integer overflow. Check for size overflow.
884 (encode_coding_object): Don't update size until xmalloc succeeds.
885
886 * composite.c (get_composition_id): Check for overflow in glyph
887 length calculations.
888
889 Integer and memory overflow fixes for display code.
890 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
891 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
892 (scrolling_window): Check for overflow in size calculations.
893 (line_draw_cost, realloc_glyph_pool, add_row_entry):
894 Don't assume glyph table len fits in int.
895 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
896 (row_table_size): Now ptrdiff_t, not int.
897 (scrolling_window): Avoid overflow in size calculations.
898 Don't update size until allocation succeeds.
899 * fns.c (concat): Check for overflow in size calculations.
900 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
901 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
902 (NEXT_ALMOST_PRIME_LIMIT): New constant.
903
904 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
905 (get_doc_string): Check for size calculation overflow.
906 Don't update size until allocation succeeds.
907 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
908 EMACS_INT, where ptrdiff_t will do.
909 (Fsubstitute_command_keys): Check for string overflow.
910
911 * editfns.c (set_time_zone_rule): Don't assume environment length
912 fits in int.
913 (message_length): Now ptrdiff_t, not int.
914 (Fmessage_box): Don't update size until allocation succeeds.
915 Don't assume message length fits in int.
916 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
917
918 * emacs.c (main): Do not reallocate argv, since there is a null at
919 the end that can be overwritten, and this way there's no need to
920 worry about size-calculation overflow.
921 (sort_args): Check for size-calculation overflow.
922
923 * eval.c (init_eval_once, grow_specpdl): Don't update size until
924 alloc succeeds.
925 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
926
927 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
928 (x_set_scroll_bar_width, x_figure_window_size):
929 Check for integer overflow.
930 (x_set_alpha): Do not assume XINT fits in int.
931
932 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
933 This is for the members text_lines, text_cols, total_lines, total_cols,
934 where the system imposes an 'int' limit.
935
936 * fringe.c (Fdefine_fringe_bitmap):
937 Don't update size until alloc works.
938
939 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
940 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
941
942 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
943 Check for size-calculation overflow.
944 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
945 do, as we prefer signed integers.
946 (id_to_widget.max_size, id_to_widget.used)
947 (xg_store_widget_in_map, xg_remove_widget_from_map)
948 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
949 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
950 Use and return ptrdiff_t, not int.
951 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
952 * gtkutil.h: Change prototypes to match the above.
953
954 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
955 are duplicate now that they've been promoted to lisp.h.
956 (x_allocate_bitmap_record, x_alloc_image_color)
957 (make_image_cache, cache_image, xpm_load):
958 Don't update size until alloc is done.
959 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
960 (x_detect_edges):
961 Check for size calculation overflow.
962 (ct_colors_allocated_max): New constant.
963 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
964 overflow.
965
966 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
967 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
968 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
969 Use ptrdiff_t, not int, to count maps.
970 (read_char_minibuf_menu_prompt): Check for overflow in size
971 calculations. Don't update size until allocation succeeds.
972 Redo calculations to avoid overflow.
973 * keyboard.h: Change prototypes to match the above.
974
975 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
976 to count maps.
977 (current_minor_maps): Check for size calculation overflow.
978 * keymap.h: Change prototypes to match the above.
979
980 * lread.c (read1, init_obarray): Don't update size until alloc done.
981
982 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
983 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
984
985 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
986 Now ptrdiff_t, not int.
987 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
988 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
989
990 * process.c (Fnetwork_interface_list): Check for overflow
991 in size calculation.
992
993 * region-cache.c (move_cache_gap): Check for size calculation overflow.
994
995 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
996 overflow. Don't bother calling xmalloc when xrealloc will do.
997
998 * search.c (Freplace_match): Check for size calculation overflow.
999 (Fset_match_data): Don't assume list lengths fit in 'int'.
1000
1001 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1002 for command line length. Do not attempt to address one before the
1003 beginning of an array, as that's not portable.
1004
1005 * term.c (max_frame_lines): Remove; unused.
1006 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1007 not int.
1008 (encode_terminal_code, calculate_costs): Check for size
1009 calculation overflow.
1010 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1011 table lengths and related sizes. Don't update size until alloc
1012 done. Redo calculations to avoid overflow.
1013 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1014
1015 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1016 subtracting pointers.
1017 (gobble_line): Check for overflow more carefully. Don't update size
1018 until alloc done.
1019
1020 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1021 Don't update size until alloc done.
1022 Redo size calculations to avoid overflow.
1023 Check for size calculation overflow.
1024 (main) [DEBUG]: Fix typo in invoking tparam1.
1025
1026 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1027 Use ptrdiff_t, not int, for sizes.
1028 (store_mode_line_noprop_char): Don't update size until alloc done.
1029
1030 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1031 Use ptrdiff_t, not int, for sizes.
1032 (Finternal_make_lisp_face, cache_face):
1033 Check for size calculation overflow.
1034 (cache_face): Treat size calculation overflows as if they were
1035 memory exhaustion (the usual treatment), rather than aborting.
1036
1037 * xfns.c (x_encode_text, x_set_name_internal)
1038 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1039 sizes, since they can exceed INT_MAX in size. Check for size
1040 calculation overflow.
1041
1042 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1043 (xg_select): Check for size calculation overflow.
1044 Don't update size until alloc done.
1045
1046 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1047 as sprintf is limited to int lengths.
1048
1049 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1050 (X_LONG_MIN): New macros.
1051 Use them to make the following changes clearer.
1052 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1053 This change doesn't affect the value now, but it may help remind
1054 future maintainers not to raise the value too much later.
1055 (SELECTION_QUANTUM): Remove, replacing with ...
1056 (selection_quantum): ... new function, which avoids overflow.
1057 All uses changed.
1058 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1059 assumption that selection length fits in 'int'.
1060 (x_reply_selection_request, x_handle_selection_request)
1061 (x_get_window_property, receive_incremental_selection)
1062 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1063 (lisp_data_to_selection_data, clean_local_selection_data):
1064 Use ptrdiff_t, not int, to record length of selection.
1065 (x_reply_selection_request, x_get_window_property)
1066 (receive_incremental_selection, x_property_data_to_lisp):
1067 Redo calculations to avoid overflow.
1068 (x_reply_selection_request): When sending hint, ceiling it at
1069 X_LONG_MAX rather than relying on wraparound overflow to send
1070 something.
1071 (x_get_window_property, receive_incremental_selection)
1072 (lisp_data_to_selection_data, x_property_data_to_lisp):
1073 Check for size-calculation overflow.
1074 (x_get_window_property, receive_incremental_selection)
1075 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1076 Don't store size until memory allocation succeeds.
1077 (x_get_window_property): Plug memory leak on memory exhaustion.
1078 Don't double-block input; malloc is safe here. Don't assume 2**34
1079 - 4 fits in unsigned long. Add an xassert to check
1080 XGetWindowProperty overflow. Be more careful about overflow
1081 calculations, and distinguish size from memory overflow better.
1082 (receive_incremental_selection): When tracing, don't assume
1083 unsigned int is less than INT_MAX.
1084 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1085 harmful) conversions of unsigned short to int.
1086 (lisp_data_to_selection_data): Don't assume that integers
1087 in the range -65535 through -1 fit in an X unsigned short.
1088 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1089 result parameters unless successful. Rely on cons_to_unsigned
1090 to report problems with elements; the old code wasn't right anyway.
1091 (x_check_property_data): Check for int overflow; we cannot use
1092 a wider type due to X limits.
1093 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1094
1095 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1096
1097 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1098 (x_term_init): Check for size calculation overflow.
1099 (x_color_cells): Don't store size until memory allocation succeeds.
1100 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1101 Don't assume alloca size is less than MAX_ALLOCA.
1102 (x_term_init): Don't assume length fits in int (sprintf is limited
1103 to int size).
1104
1105 Use ptrdiff_t for composition IDs.
1106 * character.c (lisp_string_width):
1107 * composite.c (composition_table_size, n_compositions)
1108 (get_composition_id, composition_gstring_from_id):
1109 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1110 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1111 * window.c (Frecenter):
1112 Use ptrdiff_t, not int, for composition IDs.
1113 * composite.c (get_composition_id): Check for integer overflow.
1114 * composite.h: Adjust prototypes to match the above changes.
1115
1116 Use ptrdiff_t for hash table indexes.
1117 * category.c (hash_get_category_set):
1118 * ccl.c (ccl_driver):
1119 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1120 * coding.c (coding_system_charset_list, detect_coding_system):
1121 * coding.h (struct coding_system.id):
1122 * composite.c (get_composition_id, gstring_lookup_cache):
1123 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1124 * image.c (xpm_get_color_table_h):
1125 * lisp.h (hash_lookup, hash_put):
1126 * minibuf.c (Ftest_completion):
1127 Use ptrdiff_t for hash table indexes, not int (which is too
1128 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1129 32-bit --with-wide-int hosts).
1130
1131 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1132 Add a FIXME comment about memory leaks.
1133 (syms_of_charset): Don't assume xmalloc returns.
1134
1135 Don't assume that stated character widths fit in int.
1136 * character.c (Fchar_width, c_string_width, lisp_string_width):
1137 * character.h (CHAR_WIDTH):
1138 * indent.c (MULTIBYTE_BYTES_WIDTH):
1139 Use sanitize_char_width to avoid undefined and/or bad behavior
1140 with outlandish widths.
1141 * character.h (sanitize_tab_width): Rename from sanitize_width,
1142 now that we have two such functions. All uses changed.
1143 (sanitize_char_width): New inline function.
1144
1145 Don't assume that tab-width fits in int.
1146 * character.h (sanitize_width): New inline function.
1147 (SANE_TAB_WIDTH): New macro.
1148 (ASCII_CHAR_WIDTH): Use it.
1149 * indent.c (sane_tab_width): Remove. All uses replaced by
1150 SANE_TAB_WIDTH (current_buffer).
1151 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1152
1153 * fileio.c: Integer overflow issues with file modes.
1154 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1155
1156 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1157 Remove unreachable code.
1158 (read_hex, load_charset_map_from_file): Check for integer overflow.
1159
1160 * xterm.c: don't go over XClientMessageEvent limit
1161 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1162 (x_send_scroll_bar_event): Likewise. Check that the size does not
1163 exceed limits imposed by XClientMessageEvent, as well as the usual
1164 ptrdiff_t and size_t limits.
1165
1166 * keyboard.c: Overflow, signedness and related fixes.
1167 (make_lispy_movement): Use same integer type in forward decl
1168 that is used in the definition.
1169 (read_key_sequence, keyremap_step):
1170 Change bufsize argument back to int, undoing my 2011-03-30 change.
1171 We prefer signed types, and int is wide enough here.
1172 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1173 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1174 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1175 length, not size_t. Use ptrdiff_t for index, not int.
1176 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1177 possibility of integer overflow.
1178
1179 Overflow, signedness and related fixes for images.
1180
1181 * dispextern.h (struct it.stack[0].u.image.image_id)
1182 (struct_it.image_id, struct image.id, struct image_cache.size)
1183 (struct image_cache.used, struct image_cache.ref_count):
1184 * gtkutil.c (update_frame_tool_bar):
1185 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1186 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1187 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1188 * nsmenu.m (update_frame_tool_bar):
1189 * xdisp.c (calc_pixel_width_or_height):
1190 * xfns.c (image_cache_refcount):
1191 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1192 on typical 64-bit hosts.
1193
1194 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1195 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1196 Omit unnecessary casts to int.
1197 (parse_image_spec): Check that integers fall into 'int' range
1198 when the callers expect that.
1199 (image_ascent): Redo ascent calculation to avoid int overflow.
1200 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1201 (lookup_image): Remove unnecessary tests.
1202 (xbm_image_p): Locals are now of int, not EMACS_INT,
1203 since parse_image_check makes sure they fit into int.
1204 (png_load, gif_load, svg_load_image):
1205 Prefer int to unsigned where either will do.
1206 (tiff_handler): New function, combining the cores of the
1207 old tiff_error_handler and tiff_warning_handler.
1208 This function is rewritten to use vsnprintf and thereby avoid
1209 stack buffer overflows. It uses only the features of vsnprintf
1210 that are common to both POSIX and native Microsoft.
1211 (tiff_error_handler, tiff_warning_handler): Use it.
1212 (tiff_load, gif_load, imagemagick_load_image):
1213 Don't assume :index value fits in 'int'.
1214 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1215 (imagemagick_load_image): Check that crop parameters fit into
1216 the integer types that MagickCropImage accepts. Don't assume
1217 Vimagemagick_render_type has a nonnegative value. Don't assume
1218 size_t fits in 'long'.
1219 (gs_load): Use printmax_t to print the widest integers possible.
1220 Check for integer overflow when computing image height and width.
1221
1222 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xdisp.c (redisplay_window): Don't force window start if point
1225 will be invisible in the resulting window. (Bug#9324)
1226
1227 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1228
1229 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1230 the display spec is of the form `(space ...)'.
1231 (handle_display_spec): Return the value returned by
1232 handle_single_display_spec, not just 1 or zero.
1233 (handle_single_display_spec): If the display spec is of the form
1234 `(space ...)', and specifies display in the text area, return 2
1235 rather than 1.
1236 (try_cursor_movement): Check for the need to scroll more
1237 accurately, and prefer exact match for point under bidi.
1238 Don't advance `row' beyond the last row of the window.
1239
1240 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1241 into disp_prop; all users changed.
1242
1243 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1244 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1245 for the text covered by the display property.
1246
1247 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1250 Change return value to nil.
1251 (Frecord_buffer): Delete unused function.
1252
1253 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1256 buffers, return left-to-right.
1257 (set_cursor_from_row): Consider candidate row a win if its glyph
1258 represents a newline and point is on that newline. Fixes cursor
1259 positioning on the newline at EOL of R2L text within L2R
1260 paragraph, and vice versa.
1261 (try_cursor_movement): Check continued rows, in addition to
1262 continuation rows. Fixes unwarranted scroll when point enters a
1263 continued line of R2L text within an L2R paragraph, or vice versa.
1264 (cursor_row_p): Consider the case of point being equal to
1265 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1266 from the end of a short line to the beginning of a continued line
1267 of R2L text within L2R paragraph.
1268 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1269 composed characters.
1270
1271 * bidi.c (bidi_check_type): Use xassert.
1272 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1273 members.
1274
1275 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1276
1277 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1278 a character.
1279
1280 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1281
1282 * nsfont.m (ns_otf_to_script): Fix typo.
1283
1284 2011-08-22 Kenichi Handa <handa@m17n.org>
1285
1286 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1287 extra slot even if the purpose is char-code-property-table.
1288
1289 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1290
1291 * xdisp.c (redisplay_window): When computing centering_position,
1292 account for the height of the header line. (Bug#8874)
1293
1294 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1295 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1296 candidate is selected by the mouse, and that candidate has a
1297 composed character under the mouse.
1298
1299 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1300 coordinates reported by pos-visible-in-window-p for a composed
1301 character in column zero.
1302
1303 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1304
1305 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1306
1307 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1308
1309 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1310 consider it a hit if to_charpos is anywhere in the range of the
1311 composed buffer positions.
1312
1313 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1314
1315 * image.c (gif_load): Don't assume that each subimage has the same
1316 dimensions as the base image. Handle disposal method that is
1317 "undefined" by the gif spec (Bug#9335).
1318
1319 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1320
1321 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1322 (Fcondition_case): Document `debug' symbol in error handler.
1323
1324 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1327 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1328 from an Org mode buffer to a Speedbar frame.
1329
1330 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1331 a composition, take its buffer position from IT->cmp_it.charpos.
1332 Fixes cursor positioning at the beginning of a line that begins
1333 with a composed character.
1334
1335 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1336
1337 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1338 character bidirectional type, use STRONG_L instead. Fixes crashes
1339 in a buffer produced by `describe-categories'.
1340
1341 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1342 members before the level stack, so they would be saved and
1343 restored when copying iterator state. Fixes incorrect reordering
1344 around TABs covered by display properties.
1345
1346 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1349
1350 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1351
1352 * eval.c (internal_condition_case, internal_condition_case_1)
1353 (internal_condition_case_2, internal_condition_case_n):
1354 Remove unnecessary aborts (Bug#9081).
1355
1356 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1357
1358 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1359 has no `load' handler, try opening the file locally. (Bug#9311)
1360
1361 2011-08-16 Ken Brown <kbrown@cornell.edu>
1362
1363 * gmalloc.c: Expand comment.
1364
1365 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1368 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1369
1370 2011-08-16 Ken Brown <kbrown@cornell.edu>
1371
1372 Fix memory allocation problems in Cygwin build (Bug#9273).
1373
1374 * unexcw.c ( __malloc_initialized): Declare external variable.
1375 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1376
1377 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1378 New variables.
1379 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1380 dumped emacs.
1381 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1382 in the static heap.
1383 [CYGWIN] (special_realloc): New function.
1384 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1385 requests to realloc storage in the static heap.
1386
1387 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 * bidi.c (bidi_initialize): Remove unused local.
1390
1391 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1392
1393 * bidimirror.h:
1394 * biditype.h: Remove file.
1395 * makefile.w32-in ($(BLD)/bidi.$(O)):
1396 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1397
1398 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1399
1400 * chartab.c: Improve commentary for the uniprop_table API.
1401
1402 * bidi.c (bidi_paragraph_init): Support zero value of
1403 bidi_ignore_explicit_marks_for_paragraph_level.
1404 (bidi_initialize): Use uniprop_table instead of including
1405 biditype.h and bidimirror.h.
1406
1407 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1408 coordinates of the iterator when restoring from ppos_it.
1409 (Bug#9296)
1410
1411 2011-08-14 Kenichi Handa <handa@m17n.org>
1412
1413 * process.c (create_process): Call setup_process_coding_systems
1414 after the pid of the process is set to -1 (Bug#8162).
1415
1416 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (move_it_in_display_line_to): Don't invoke
1419 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1420 ppos_it. Fixes vertical cursor motion when line beginning is
1421 covered by an image. (Bug#9296)
1422
1423 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1424
1425 * nsterm.h (ns_run_ascript): Declare.
1426 (NSAPP_DATA2_RUNASSCRIPT): Define.
1427
1428 * nsfns.m (as_script, as_result, as_status): New static variables.
1429 (ns_run_ascript): New function.
1430 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1431 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1432 the event loop. Get status from as_status (Bug#7276).
1433
1434 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1435 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1436 the event loop (Bug#7276).
1437
1438 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * gnutls.c (QCgnutls_bootprop_priority)
1441 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1442 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1443 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1444 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1445 (QCgnutls_bootprop_verify_hostname_error)
1446 (QCgnutls_bootprop_callbacks_verify): Rename from
1447 Qgnutls_bootprop_..., all uses changed.
1448
1449 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1450 uses changed.
1451
1452 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * xfaces.c (Qframe_set_background_mode): Now static.
1455 * dispextern.h (Qframe_set_background_mode): Remove decl.
1456
1457 * process.c (Fnetwork_interface_info): Declare local only if needed.
1458
1459 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1460
1461 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1462 (Fnetwork_interface_list): Allocate in increments of bytes instead
1463 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1464 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1465 sockaddr.
1466 (struct ifflag_def): notrailers is smart on OSX.
1467 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1468 Get hardware address with getifaddrs if available.
1469
1470 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xdisp.c (iterate_out_of_display_property): xassert that
1473 IT->position is set to within IT->object's boundaries. Break from
1474 the loop as soon as EOB is reached; avoids infloops in redisplay
1475 when IT->position is set up wrongly due to some bug.
1476 Set IT->current to match the bidi iterator unconditionally.
1477 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1478 entry. Force push_it to save on the stack the current
1479 buffer/string position, to be restored by pop_it. Fix flags in
1480 the iterator structure wrt the object coming from a display
1481 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1482 properties. (Bug#9284)
1483
1484 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1485
1486 * fontset.c (fontset_get_font_group): Add proper type checks.
1487 (Bug#9172)
1488
1489 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1490
1491 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1492 and LC_VERSION_MIN_MACOSX.
1493 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1494 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1495
1496 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1497
1498 * xdisp.c (forward_to_next_line_start): Allow to use the
1499 no-display-properties-and-no-overlays under bidi display.
1500 Set disp_pos in the bidi iterator to avoid searches for display
1501 properties and overlays.
1502
1503 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1504
1505 * editfns.c (Fset_time_zone_rule): Document relationship with the
1506 setenv function.
1507
1508 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1509 the font entity extracted from the cache (Bug#8109).
1510
1511 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1512
1513 * composite.c (autocmp_chars): Don't reset point. That is done by
1514 restore_point_unwind (Bug#5984).
1515
1516 2011-08-07 Juri Linkov <juri@jurta.org>
1517
1518 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1519 to show the arg `TIME' instead of `TIMEVAL'.
1520
1521 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1522
1523 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1524 display property strides EOL and includes a newline, as in
1525 longlines-mode. (Bug#9254)
1526 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1527 word-wrap under bidirectional display. (Bug#9224)
1528
1529 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1530 is non-zero, even if the data buffer is NULL. Fixes a crash in
1531 vertical-motion with longlines-mode. (Bug#9254)
1532
1533 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1534
1535 * bidi.c <bidi_cache_total_alloc>: Now static.
1536 (bidi_initialize): Initialize bidi_cache_total_alloc.
1537
1538 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1539 cache. (Bug#9221)
1540
1541 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1542 amount allocated this far in `bidi_cache_total_alloc'.
1543 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1544 non-zero, only free the data buffer without restoring the cache
1545 contents. All callers changed.
1546
1547 * dispextern.h (bidi_unshelve_cache): Update prototype.
1548
1549 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1550 (move_it_in_display_line, move_it_to)
1551 (move_it_vertically_backward, move_it_by_lines): Replace the call
1552 to xfree to an equivalent call to bidi_unshelve_cache.
1553 (move_it_in_display_line_to): Fix logic of returning
1554 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1555
1556 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1557
1558 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1559 came from a string character with a `cursor' property. (Bug#9229)
1560
1561 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1562
1563 * Makefile.in (LIB_PTHREAD): New variable.
1564 (LIBES): Add LIB_PTHREAD (Bug#9216).
1565
1566 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1567 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1568
1569 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1570
1571 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1572
1573 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1574
1575 * xterm.c (x_find_topmost_parent): New function.
1576 (x_set_frame_alpha): Find topmost parent window with
1577 x_find_topmost_parent and set the property there also (bug#9181).
1578 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1579
1580 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * callproc.c (Fcall_process): Avoid vfork clobbering
1583 the local vars buffer, coding_systems, current_dir.
1584
1585 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1586
1587 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1588
1589 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1592 so that it is not optimized away.
1593
1594 * xdisp.c (compute_display_string_pos): Remove unused local.
1595
1596 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1597
1598 Fix slow cursor motion and scrolling in large buffers with
1599 selective display, like Org Mode buffers. (Bug#9218)
1600
1601 * dispextern.h (struct bidi_it): New member disp_prop_p.
1602
1603 * xdisp.c: Remove one-slot cache of display string positions.
1604 (compute_display_string_pos): Accept an additional argument
1605 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1606 for a display string or property. If found, set DISP_PROP_P
1607 non-zero.
1608
1609 * bidi.c (bidi_fetch_char): Accept an additional argument
1610 DISP_PROP_P, and pass it to compute_display_string_pos.
1611 Only handle text covered by a display string if DISP_PROP_P is returned
1612 non-zero. All callers of bidi_fetch_char changed.
1613
1614 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1615
1616 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1617
1618 2010-12-03 Don March <don@ohspite.net>
1619
1620 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1621 last character M-[char] is translated to ESC [char] (bug#7541).
1622
1623 2011-08-02 Kenichi Handa <handa@m17n.org>
1624
1625 * lisp.h (uniprop_table): Extern it.
1626
1627 * chartab.c (uniprop_table): Make it non-static.
1628
1629 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1630
1631 * xdisp.c (forward_to_next_line_start): Accept additional argument
1632 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1633 on the newline.
1634 (reseat_at_next_visible_line_start): Use the bidi iterator state
1635 returned by forward_to_next_line_start to restore the state of
1636 it->bidi_it after backing up to previous newline. (Bug#9212)
1637
1638 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1639
1640 * regex.c (re_comp): Protoize.
1641 (re_exec): Fix return type.
1642 (regexec): Fix type of `ret'. (Bug#9203)
1643
1644 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1647 This is needed if max-image-size is a floating-point number.
1648
1649 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1650
1651 * print.c (print_object): Print empty symbol as ##.
1652
1653 * lread.c (read1): Read ## as empty symbol.
1654
1655 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1656
1657 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1658 setting frame foreground color (Bug#9175).
1659 (x_set_background_color): Likewise.
1660
1661 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1662 contents (Bug#9176).
1663 (EmacsTooltip -init): Remove bezels and add shadows to
1664 tooltip windows.
1665
1666 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1667 or scroll bar (Bug#8470).
1668
1669 * nsfont.m (nsfont_open): Remove assignment to voffset and
1670 unnecessary vars hshink, expand, hd, full_height, min_height.
1671 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1672
1673 * nsterm.h (nsfont_info): Remove voffset field.
1674
1675 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1676
1677 Implement strike-through and overline on NextStep (Bug#8863).
1678
1679 * nsfont.m (nsfont_open): Use underline position provided by font,
1680 instead of hard-coded value of 2.
1681 (nsfont_draw): Call ns_draw_text_decoration instead.
1682
1683 * nsterm.h: Add declaration for ns_draw_text_decoration.
1684
1685 * nsterm.m (ns_draw_text_decoration): New function for drawing
1686 underline, overline, and strike-through.
1687 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1688 ns_draw_text_decoration. Change treatment of cursor drawing to
1689 accommodate underlining, etc.
1690
1691 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1692
1693 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1694 default.
1695
1696 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1699 Without this fix, if a signal arrives just after memory fills up,
1700 'malloc' might be invoked reentrantly.
1701
1702 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1703 In other words, assume that every image size is allowed, on non-X
1704 hosts. This assumption is probably wrong, but it lets Emacs compile.
1705
1706 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 * regex.c (re_iswctype): Convert return values to boolean.
1709
1710 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1711
1712 * xdisp.c (compute_display_string_pos): Don't use cached display
1713 string position if the buffer had its restriction changed.
1714 (Bug#9184)
1715
1716 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1719
1720 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 Integer signedness and overflow and related fixes. (Bug#9079)
1723
1724 * bidi.c: Integer size and overflow fixes.
1725 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1726 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1727 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1728 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1729 (bidi_find_other_level_edge):
1730 Use ptrdiff_t instead of EMACS_INT where either will do.
1731 This works better on 32-bit hosts configured --with-wide-int.
1732 (bidi_cache_ensure_space): Check for size-calculation overflow.
1733 Use % rather than repeated addition, for better worst-case speed.
1734 Don't set bidi_cache_size until after xrealloc returns, because it
1735 might not return.
1736 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1737 (bidi_cache_ensure_space): Also check that the bidi cache size
1738 does not exceed that of the largest Lisp string or buffer. See Eli
1739 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1740
1741 * alloc.c (__malloc_size_t): Remove.
1742 All uses replaced by size_t. See Andreas Schwab's note
1743 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1744
1745 * image.c: Improve checking for integer overflow.
1746 (check_image_size): Assume that f is nonnull, since
1747 it is always nonnull in practice. This is one less thing to
1748 worry about when checking for integer overflow later.
1749 (x_check_image_size): New function, which checks for integer
1750 overflow issues inside X.
1751 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1752 This removes the need for a memory_full check.
1753 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1754 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1755 (xbm_read_bitmap_data): Change locals back to 'int', since
1756 their values must fit in 'int'.
1757 (xpm_load_image, png_load, tiff_load):
1758 Invoke x_create_x_image_and_pixmap earlier,
1759 to avoid much needless work if the image is too large.
1760 (tiff_load): Treat overly large images as if
1761 x_create_x_image_and_pixmap failed, not as malloc failures.
1762 (gs_load): Use x_check_image_size.
1763
1764 * gtkutil.c: Omit integer casts.
1765 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1766 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1767
1768 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1769
1770 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1771 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1772 would wrongly return t on a 64-bit host.
1773
1774 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1775 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1776 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1777 and therefore cause GCC to emit a bogus diagnostic in some cases.
1778
1779 * image.c: Integer signedness and overflow and related fixes.
1780 This is not an exhaustive set of fixes, but it's time to
1781 record what I've got.
1782 (lookup_pixel_color, check_image_size): Remove redundant decls.
1783 (check_image_size): Don't assume that arbitrary EMACS_INT values
1784 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1785 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1786 (tiff_load, imagemagick_load_image):
1787 Check for overflow in size calculations.
1788 (x_create_x_image_and_pixmap): Remove unnecessary test for
1789 xmalloc returning NULL; that can't happen.
1790 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1791 (xpm_color_bucket): Use better integer hashing function.
1792 (xpm_cache_color): Don't possibly over-allocate memory.
1793 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1794 (gif_memory_source):
1795 Use ptrdiff_t, not int or size_t, to record sizes.
1796 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1797 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1798 either works, as we prefer signed integers.
1799 (tiff_read_from_memory, tiff_write_from_memory):
1800 Return tsize_t, not size_t, since that's what the TIFF API wants.
1801 (tiff_read_from_memory): Don't fail simply because the read would
1802 go past EOF; instead, return a short read.
1803 (tiff_load): Omit no-longer-needed casts.
1804 (Fimagemagick_types): Don't assume size fits into 'int'.
1805
1806 Improve hashing quality when configured --with-wide-int.
1807 * fns.c (hash_string): New function, taken from sxhash_string.
1808 Do not discard information about ASCII character case; this
1809 discarding is no longer needed.
1810 (sxhash-string): Use it. Change sig to match it. Caller changed.
1811 * lisp.h: Declare it.
1812 * lread.c (hash_string): Remove, since we now use fns.c's version.
1813 The fns.c version returns a wider integer if --with-wide-int is
1814 specified, so this should help the quality of the hashing a bit.
1815
1816 * emacs.c: Integer overflow minor fix.
1817 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1818 Define only if GNU_LINUX.
1819 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1820
1821 * dispnew.c: Integer signedness and overflow fixes.
1822 Remove unnecessary forward decls, that were a maintenance hassle.
1823 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1824 All uses changed.
1825 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1826 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1827 (prepare_desired_row, line_draw_cost):
1828 Use int, not unsigned, where either works.
1829 (save_current_matrix, restore_current_matrix):
1830 Use ptrdiff_t, not size_t, where either works.
1831 (init_display): Check for overflow more accurately, and without
1832 relying on undefined behavior.
1833
1834 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1835 Remove, replacing with the new symbols in lisp.h. All uses changed.
1836 * fileio.c (make_temp_name):
1837 * filelock.c (lock_file_1, lock_file):
1838 * xdisp.c (message_dolog):
1839 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1840 Use pMd etc. instead.
1841 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1842 replacing the pWIDE etc. symbols removed from editfns.c.
1843
1844 * keyboard.h (num_input_events): Now uintmax_t.
1845 This is (very slightly) less likely to mess up due to wraparound.
1846 All uses changed.
1847
1848 * buffer.c: Integer signedness fixes.
1849 (alloc_buffer_text, enlarge_buffer_text):
1850 Use ptrdiff_t rather than size_t when either will do, as we prefer
1851 signed integers.
1852
1853 * alloc.c: Integer signedness and overflow fixes.
1854 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1855 (__malloc_size_t): Default to size_t, not to int.
1856 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1857 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1858 Prefer ptrdiff_t to size_t when either would do, as we prefer
1859 signed integers.
1860 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1861 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1862 Now const. Initialize with values that are in range even if char
1863 is signed.
1864 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1865 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1866 These functions do the right thing with sizes > 2**32.
1867 (check_depth): Now ptrdiff_t, not int.
1868 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1869 Adjust to new way of storing sizes. Check for size overflow bugs
1870 in rest of code.
1871 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1872 slightly wrong anyway, as it missed one instance of
1873 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1874 (refill_memory_reserve): Omit needless cast to size_t.
1875 (mark_object_loop_halt): Mark as externally visible.
1876
1877 * xselect.c: Integer signedness and overflow fixes.
1878 (Fx_register_dnd_atom, x_handle_dnd_message):
1879 Use ptrdiff_t, not size_t, since we prefer signed.
1880 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1881 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1882 x_dnd_atoms_size and x_dnd_atoms_length.
1883
1884 * doprnt.c: Prefer signed to unsigned when either works.
1885 * eval.c (verror):
1886 * doprnt.c (doprnt):
1887 * lisp.h (doprnt):
1888 * xdisp.c (vmessage):
1889 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1890 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1891 prefer signed arithmetic to avoid comparison confusion.
1892 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1893 but is a bit tricky.
1894
1895 Assume freestanding C89 headers, string.h, stdlib.h.
1896 * data.c, doprnt.c, floatfns.c, print.c:
1897 Include float.h unconditionally.
1898 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1899 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1900 * regex.c: Likewise for stddef.h, string.h.
1901 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1902 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1903 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1904 (STDC_HEADERS): Remove obsolete defines.
1905 * sysdep.c: Include limits.h unconditionally.
1906
1907 Assume support for memcmp, memcpy, memmove, memset.
1908 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1909 * regex.c (memcmp, memcpy):
1910 Remove; we assume C89 now.
1911
1912 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1913 (__malloc_safe_bcopy): Remove; no longer needed.
1914
1915 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1916 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1917 well either way, and we prefer signed to unsigned.
1918
1919 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920
1921 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1922 closes the connection while we're reading (bug#9182).
1923
1924 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1925
1926 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1927 are specified (Bug#9168).
1928
1929 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1932 Found by GCC static checking and --with-wide-int on a 32-bit host.
1933
1934 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1935
1936 * xdisp.c (compute_display_string_pos): Fix logic of caching
1937 previous display string position. Initialize cached_prev_pos to
1938 -1. Fixes slow-down at the beginning of a buffer.
1939
1940 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1943 for attrs[LFACE_FONTSET_INDEX].
1944
1945 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * xml.c (parse_region): Remove unused local
1948 that was recently introduced.
1949
1950 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1953 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1954
1955 * xdisp.c (move_it_in_display_line_to): Record the best matching
1956 position for TO_CHARPOS while scanning the line, and restore it on
1957 exit if none of the characters scanned was an exact match.
1958 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1959 when exact match is impossible due to invisible text, and the
1960 lines are truncated.
1961
1962 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1965 for OSX >= 10.7.
1966
1967 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1968
1969 Fix a significant slow-down of cursor motion with C-n, C-p,
1970 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1971 auto-repeat under bidi redisplay in fontified buffers.
1972 * xdisp.c (compute_stop_pos_backwards): New function.
1973 (next_element_from_buffer): Call compute_stop_pos_backwards to
1974 find a suitable prev_stop when we find ourselves before
1975 base_level_stop.
1976 (reseat): Don't look for prev_stop, as that could mean a very long
1977 run.
1978 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1979 <cached_disp_overlay_modiff>: Cache for last found display string
1980 position.
1981 (compute_display_string_pos): Return the cached position if asked
1982 about the same buffer in the same area of character positions, and
1983 the buffer wasn't changed since the time the display string
1984 position was cached.
1985
1986 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1989 is an integer, which is important for empty lines. (Bug#9149)
1990
1991 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1992
1993 * frame.c (Fmodify_frame_parameters): In tty case, update the
1994 default face if necessary (Bug#4238).
1995
1996 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1997
1998 * editfns.c (Fstring_to_char): No need to explain what a character
1999 is in the docstring (Bug#6576).
2000
2001 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2002
2003 * xml.c (parse_region): Make sure we always return a tree.
2004
2005 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2006
2007 * xml.c (parse_region): If a document contains only comments,
2008 return that, too.
2009
2010 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011
2012 * xml.c (make_dom): Return comments, too.
2013
2014 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 Port to OpenBSD.
2017 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2018 and the surrounding thread.
2019 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2020 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2021 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2022 timer goes off.
2023 * s/openbsd.h (BROKEN_SIGIO): Define.
2024 * unexelf.c (unexec) [__OpenBSD__]:
2025 Don't update the .mdebug section of the Alpha COFF symbol table.
2026
2027 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2028
2029 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2030 (bug#8460).
2031
2032 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2035 This fixes some race conditions on the permissions of any newly
2036 created file.
2037
2038 * alloc.c (valid_pointer_p): Use pipe, not open.
2039 This fixes some permissions issues when debugging.
2040
2041 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2042 If fchown fails to set both uid and gid, try to set just gid,
2043 as that is sometimes allowed. Adjust the file's mode to eliminate
2044 setuid or setgid bits that are inappropriate if fchown fails.
2045
2046 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2047
2048 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2049 to compare Lisp_Objects.
2050 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2051 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2052 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2053
2054 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2055
2056 * lread.c (read_integer): Unread even EOF character.
2057 (read1): Likewise. Properly record start position of symbol.
2058
2059 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2060 symbol character follows.
2061
2062 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2065 This works around a problem with the previous change to Fcopy_file.
2066 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2067 and without this change, GCC might complain about discarding
2068 fchown's return value.
2069
2070 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2073
2074 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2075
2076 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2077
2078 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2079
2080 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2081 it's used from the C level.
2082
2083 * process.c: Use the same condition for POLL_FOR_INPUT in both
2084 keyboard.c and process.c (bug#1858).
2085
2086 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2087
2088 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2089 (Fgnutls_boot): Use it.
2090
2091 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * doc.c (Fsubstitute_command_keys): Revert last change.
2094
2095 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2096
2097 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2098 quotes the next character, and doesn't affect other longer
2099 sequences (bug#8935).
2100
2101 * lread.c (syms_of_lread): Clarify that is isn't only
2102 `eval-buffer' and `eval-defun' that's affected by
2103 `lexical-binding' (bug#8460).
2104
2105 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2106
2107 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2108 bidi redisplay when a line includes both an image and is truncated.
2109
2110 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 Fix minor problems found by static checking.
2113 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2114 (elsz): Now a signed constant, not a size_t var. We prefer signed
2115 types to unsigned, to avoid integer comparison confusion. Without
2116 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2117 "cannot optimize loop, the loop counter may overflow", a symptom
2118 of the confusion.
2119 * indent.c (Fvertical_motion): Mark locals as initialized.
2120 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2121
2122 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2123
2124 * search.c (Fre_search_backward): Mention `case-fold-search' in
2125 all the re_search_* functions (bug#8138).
2126
2127 * keyboard.c (Fopen_dribble_file): Document when the file is
2128 closed (bug#8056).
2129
2130 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2131
2132 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2133 bidi_cache_idx.
2134
2135 Support bidi reordering of display and overlay strings.
2136 * xdisp.c (compute_display_string_pos)
2137 (compute_display_string_end): Accept additional argument STRING.
2138 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2139 (reseat_to_string): Initialize bidi_it->string.s and
2140 bidi_it->string.schars.
2141 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2142 NULL (avoids a crash in bidi_paragraph_init).
2143 Initialize itb.string.lstring.
2144 (init_iterator): Call bidi_init_it only of a valid
2145 buffer position was specified. Initialize paragraph_embedding to
2146 L2R.
2147 (reseat_to_string): Initialize the bidi iterator.
2148 (display_string): If we need to ignore text properties of
2149 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2150 original value of -1 will not work with bidi.)
2151 (compute_display_string_pos): First arg is now struct
2152 `text_pos *'; all callers changed. Support display properties on
2153 Lisp strings.
2154 (compute_display_string_end): Support display properties on Lisp
2155 strings.
2156 (init_iterator, reseat_1, reseat_to_string): Initialize the
2157 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2158 when iterating on a string not from display properties).
2159 (compute_display_string_pos, compute_display_string_end):
2160 Fix calculation of the object to scan. Fixes an error when using
2161 arrow keys.
2162 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2163 base_level_stop; instead, set base_level_stop to BEGV.
2164 Fixes crashes in vertical-motion.
2165 (next_element_from_buffer): Improve commentary for when
2166 the iterator is before prev_stop.
2167 (init_iterator): Initialize bidi_p from the default value of
2168 bidi-display-reordering, not from buffer-local value. Use the
2169 buffer-local value only if initializing for buffer iteration.
2170 (handle_invisible_prop): Support invisible properties on strings
2171 that are being bidi-reordered.
2172 (set_iterator_to_next): Support bidi reordering of C strings and
2173 Lisp strings.
2174 (next_element_from_string): Support bidi reordering of Lisp
2175 strings.
2176 (handle_stop_backwards): Support Lisp strings as well.
2177 (display_string): Support display of R2L glyph rows.
2178 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2179 (init_iterator): Don't initialize it->bidi_p for strings
2180 here.
2181 (reseat_to_string): Initialize it->bidi_p for strings here.
2182 (next_element_from_string, next_element_from_c_string)
2183 (next_element_from_buffer): Add xassert's for correspondence
2184 between IT's object being iterated and it->bidi_it.string
2185 structure.
2186 (face_before_or_after_it_pos): Support bidi iteration.
2187 (next_element_from_c_string): Handle the case of the first string
2188 character that is not the first one in the visual order.
2189 (get_visually_first_element): New function, refactored from common
2190 parts of next_element_from_buffer, next_element_from_string, and
2191 next_element_from_c_string.
2192 (tool_bar_lines_needed, redisplay_tool_bar)
2193 (display_menu_bar): Force left-to-right direction. Add a FIXME
2194 comment for making that be controlled by a user option.
2195 (push_it, pop_it): Save and restore the state of the
2196 bidi iterator. Save and restore the bidi_p flag.
2197 (pop_it): Iterate out of display property for string iteration as
2198 well.
2199 (iterate_out_of_display_property): Support iteration over strings.
2200 (handle_single_display_spec): Set up it->bidi_it for iteration
2201 over a display string, and call bidi_init_it.
2202 (handle_single_display_spec, next_overlay_string)
2203 (get_overlay_strings_1, push_display_prop): Set up the bidi
2204 iterator for displaying display or overlay strings.
2205 (forward_to_next_line_start): Don't use the shortcut if
2206 bidi-iterating.
2207 (back_to_previous_visible_line_start): If handle_display_prop
2208 pushed the iterator stack, restore the internal state of the bidi
2209 iterator by calling bidi_pop_it same number of times.
2210 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2211 and we are bidi-iterating, don't decrement the iterator position;
2212 instead, set the first_elt flag in the bidi iterator, to produce
2213 the same effect.
2214 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2215 (push_display_prop): xassert that we are iterating a buffer.
2216 (push_it, pop_it): Save and restore paragraph_embedding member.
2217 (handle_single_display_spec, next_overlay_string)
2218 (get_overlay_strings_1, reseat_1, reseat_to_string)
2219 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2220 correctly. Don't assume unibyte strings are not bidi-reordered.
2221 (compute_display_string_pos)
2222 (compute_display_string_end): Fix handling the case of C string.
2223 (push_it, pop_it): Save and restore from_disp_prop_p.
2224 (handle_single_display_spec, push_display_prop): Set the
2225 from_disp_prop_p flag.
2226 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2227 (pop_it): Call iterate_out_of_display_property only if we are
2228 popping after iteration over a string that came from a display
2229 property. Fix a typo in popping stretch info. Add an assertion
2230 for verifying that the iterator position is in sync with the bidi
2231 iterator.
2232 (handle_single_display_spec, get_overlay_strings_1)
2233 (push_display_prop): Fix initialization of paragraph direction for
2234 string when that of the parent object is not yet determined.
2235 (reseat_1): Call bidi_init_it to resync the bidi
2236 iterator with IT's position. (Bug#7616)
2237 (find_row_edges): If ROW->start.pos gives position
2238 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2239 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2240 Reset the from_disp_prop_p flag.
2241 (SAVE_IT, RESTORE_IT): New macros.
2242 (pos_visible_p, face_before_or_after_it_pos)
2243 (back_to_previous_visible_line_start)
2244 (move_it_in_display_line_to, move_it_in_display_line)
2245 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2246 (try_scrolling, redisplay_window, display_line): Use them when
2247 saving a temporary copy of the iterator and restoring it back.
2248 (back_to_previous_visible_line_start, reseat_1)
2249 (init_iterator): Empty the bidi cache "stack".
2250 (move_it_in_display_line_to): If iterator ended up at
2251 EOL, but we never saw any buffer positions smaller than
2252 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2253 motion in bidi-reordered lines.
2254 (move_it_in_display_line_to): Record prev_method and prev_pos
2255 immediately before the call to set_iterator_to_next. Fixes cursor
2256 motion in bidi-reordered lines with stretch glyphs and strings
2257 displayed in margins. (Bug#8133) (Bug#8867)
2258 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2259 TO_CHARPOS.
2260 (pos_visible_p): Support positions in bidi-reordered lines.
2261 Save and restore bidi cache.
2262
2263 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2264 (bidi_paragraph_info): Delete unused struct.
2265 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2266 (bidi_cache_start): New variable.
2267 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2268 to zero.
2269 (bidi_cache_fetch_state, bidi_cache_search)
2270 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2271 (bidi_cache_find, bidi_peek_at_next_level)
2272 (bidi_level_of_next_char, bidi_find_other_level_edge)
2273 (bidi_move_to_visually_next): Compare cache index with
2274 bidi_cache_start rather than with zero.
2275 (bidi_fetch_char): Accept new argument STRING; all callers
2276 changed. Support iteration over a string. Support strings with
2277 display properties. Support unibyte strings. Fix the type of
2278 `len' according to what STRING_CHAR_AND_LENGTH expects.
2279 (bidi_paragraph_init, bidi_resolve_explicit_1)
2280 (bidi_resolve_explicit, bidi_resolve_weak)
2281 (bidi_level_of_next_char, bidi_move_to_visually_next):
2282 Support iteration over a string.
2283 (bidi_set_sor_type, bidi_resolve_explicit_1)
2284 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2285 can now be zero (for strings); special values 0 and -1 were
2286 changed to -1 and -2, respectively.
2287 (bidi_char_at_pos): New function.
2288 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2289 Call it instead of FETCH_MULTIBYTE_CHAR.
2290 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2291 initialized to valid values.
2292 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2293 values.
2294 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2295 the test for valid cached positions. Fix the logic for looking up
2296 the sentinel state in the cache. GCPRO the Lisp string we are
2297 iterating.
2298 (bidi_push_it, bidi_pop_it): New functions.
2299 (bidi_initialize): Initialize the bidi cache start stack pointer.
2300 (bidi_cache_ensure_space): New function, refactored from part of
2301 bidi_cache_iterator_state. Don't assume the required size is just
2302 one BIDI_CACHE_CHUNK away.
2303 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2304 (bidi_count_bytes, bidi_char_at_pos): New functions.
2305 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2306 always valid if bidi_cache_idx is valid.
2307 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2308 is valid if it's going to be used.
2309 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2310 (bidi_cache_fetch_state, bidi_cache_search)
2311 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2312 (bidi_cache_iterator_state, bidi_cache_find)
2313 (bidi_find_other_level_edge, bidi_cache_start_stack):
2314 All variables related to cache indices are now EMACS_INT.
2315
2316 * dispextern.h (struct bidi_string_data): New structure.
2317 (struct bidi_it): New member `string'. Make flag members be 1-bit
2318 fields, and put them last in the struct.
2319 (compute_display_string_pos, compute_display_string_end):
2320 Update prototypes.
2321 (bidi_push_it, bidi_pop_it): Add prototypes.
2322 (struct iterator_stack_entry): New members bidi_p,
2323 paragraph_embedding, and from_disp_prop_p.
2324 (struct it): Member bidi_p is now a bit field 1 bit wide.
2325 (bidi_shelve_cache, bidi_unshelve_cache):
2326 Declare prototypes.
2327
2328 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2329 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2330 and vector-like objects.
2331
2332 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2333 cache around display iteration.
2334
2335 * window.c (Fwindow_end, window_scroll_pixel_based)
2336 (displayed_window_lines, Frecenter): Save and restore the bidi
2337 cache around display iteration.
2338
2339 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2340
2341 * editfns.c (Fdelete_region): Clarify the use of the named
2342 parameters (bug#6788).
2343
2344 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2345
2346 * indent.c (Fvertical_motion): Set and restore w->pointm when
2347 saving and restoring the window's buffer (Bug#9006).
2348
2349 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2350
2351 * editfns.c (Fstring_to_char): Clarify just what is returned
2352 (bug#6576). Text by Eli Zaretskii.
2353
2354 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2355
2356 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2357
2358 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2359
2360 * buffer.c (mmap_find): Fix a typo.
2361
2362 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2363
2364 Fix execution of x selection hooks.
2365 * xselect.c (Qx_lost_selection_functions)
2366 (Qx_sent_selection_functions): New vars.
2367 (syms_of_xselect): DEFSYM them.
2368 (x_handle_selection_request): Pass Qx_sent_selection_functions
2369 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2370 (x_handle_selection_clear,x_clear_frame_selections):
2371 Pass Qx_lost_selection_functions rather than
2372 Vx_lost_selection_functions to Frun_hook_with_args.
2373
2374 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2377 The old code sometimes used this field without initializing it.
2378
2379 * alloc.c (gc_sweep): Don't read past end of array.
2380 In theory, the old code could also have corrupted Emacs internals,
2381 though it'd be very unlikely.
2382
2383 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2384
2385 * character.c (Fcharacterp): Don't advertise optional ignored
2386 argument. (Bug#4026)
2387
2388 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2389
2390 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2391 key" (bug#4257).
2392
2393 * window.c (Fset_window_start): Doc fix (bug#4199).
2394 (Fset_window_hscroll): Ditto.
2395
2396 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 Fix minor new problems caught by GCC 4.6.1.
2399 * term.c (init_tty): Remove unused local.
2400 * xsettings.c (store_monospaced_changed): Define this function only
2401 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2402 not used otherwise.
2403
2404 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2407
2408 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2409
2410 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2411 are the mini-buffer and the echo area (bug#3320).
2412
2413 * term.c (init_tty): Remove support for supdup, c10 and perq
2414 terminals, which are no longer supported (bug#1482).
2415
2416 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2417
2418 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2419
2420 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2421
2422 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2423 for non-popups (Bug#3642).
2424
2425 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2426
2427 * alloc.c (reset_malloc_hooks): Protoize.
2428 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2429 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2430 * cm.c (losecursor): Likewise.
2431 * data.c (fmod): Likewise.
2432 * dispnew.c (swap_glyphs_in_rows): Likewise.
2433 * emacs.c (memory_warning_signal): Likewise.
2434 * floatfns.c (float_error): Likewise.
2435 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2436 (otf_open, font_otf_capability, generate_otf_features)
2437 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2438 Likewise.
2439 * image.c (pbm_read_file): Likewise.
2440 * indent.c (string_display_width): Likewise.
2441 * intervals.c (check_for_interval, search_for_interval)
2442 (inc_interval_count, count_intervals, root_interval)
2443 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2444 * lread.c (defalias): Likewise.
2445 * ralloc.c (r_alloc_check): Likewise.
2446 * regex.c (set_image_of_range_1, set_image_of_range)
2447 (regex_grow_registers): Likewise.
2448 * sysdep.c (strerror): Likewise.
2449 * termcap.c (valid_filename_p, tprint, main): Likewise.
2450 * tparam.c (main): Likewise.
2451 * unexhp9k800.c (run_time_remap, save_data_space)
2452 (update_file_ptrs, read_header, write_header, calculate_checksum)
2453 (copy_file, copy_rest, display_header): Likewise.
2454 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2455 Likewise.
2456 * xdisp.c (check_it): Likewise.
2457 * xfaces.c (register_color, unregister_color, unregister_colors):
2458 Likewise.
2459 * xfns.c (print_fontset_result): Likewise.
2460 * xrdb.c (member, fatal, main): Likewise.
2461
2462 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Fix minor problems found by static checking (Bug#9031).
2465 * chartab.c (char_table_set_range, map_sub_char_table):
2466 Remove unused locals.
2467 (uniprop_table): Now static.
2468 * composite.c (_work_char): Remove unused static var.
2469
2470 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2471
2472 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2473
2474 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * gtkutil.c (qttip_cb): Remove code without function.
2477
2478 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2479
2480 * w32.c (pthread_sigmask): New stub.
2481
2482 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 Use pthread_sigmask, not sigprocmask (Bug#9010).
2485 sigprocmask is portable only for single-threaded applications, and
2486 Emacs can be multi-threaded when it uses GTK.
2487 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2488 (LIBES): Use it.
2489 * callproc.c (Fcall_process):
2490 * process.c (create_process):
2491 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2492 Use pthread_sigmask, not sigprocmask.
2493
2494 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2495
2496 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2497 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2498 wrong (Bug#8591).
2499
2500 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2501
2502 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2503 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2504 (xg_hide_tooltip): Fix comment.
2505
2506 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2507 in registerServicesMenuSendTypes.
2508 (validRequestorForSendType): Don't check ns_return_types.
2509
2510 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2511 ns_return_type.
2512
2513 2011-07-08 Jason Rumney <jasonr@gnu.org>
2514
2515 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2516 frame struct members of non-existent frames (Bug#6284).
2517
2518 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2519
2520 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2521 variable firstTime not needed on OSX >= 10.6.
2522 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2523 >= 10.5. Use setKnobProportion, setDoubleValue.
2524
2525 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2526 (MAC_OS_X_VERSION_10_5): Define if not defined.
2527 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2528 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2529 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2530
2531 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2532 cString and lossyCString on OSX >= 10.4
2533
2534 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2535 sizeToFit on OSX >= 10.2.
2536
2537 * nsimage.m (allocInitFromFile): Don't use deprecated method
2538 bestRepresentationForDevice on OSX >= 10.6.
2539
2540 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2541 to avoid warning.
2542
2543 * emacs.c: Declare unexec_init_emacs_zone.
2544
2545 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2546
2547 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2548
2549 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2550 on svcsMenu (Bug#8842).
2551
2552 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2553 ns_return_types.
2554 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2555
2556 * nsterm.m (QUTF8_STRING): Declare.
2557 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2558 (validRequestorForSendType): Return type is (id).
2559 Change indexOfObjectIdenticalTo to indexOfObject.
2560 Check if we have local selection before returning self (Bug#8842).
2561 (writeSelectionToPasteboard): Put local selection into paste board
2562 if we have a local selection (Bug#8842).
2563 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2564
2565 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2566 (ns_get_local_selection): Declare.
2567
2568 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2569
2570 * keymap.c (describe_map_tree): Don't insert a double newline at
2571 the end of the buffer (bug#1169) and return whether we inserted
2572 something.
2573
2574 * callint.c (Fcall_interactively): Change "reading args" to
2575 "providing args" to try to clarify what it does (bug#1010).
2576
2577 2011-07-07 Kenichi Handa <handa@m17n.org>
2578
2579 * composite.c (composition_compute_stop_pos): Ignore a static
2580 composition starting before CHARPOS (Bug#8915).
2581
2582 * xdisp.c (handle_composition_prop): Likewise.
2583
2584 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2585
2586 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2587 (Bug#9015)
2588
2589 2011-07-07 Kenichi Handa <handa@m17n.org>
2590
2591 * character.h (unicode_category_t): New enum type.
2592
2593 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2594 (Qchar_code_property_table): New variable.
2595 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2596 (UNIPROP_COMPRESSED_FORM_P): New macros.
2597 (char_table_ascii): Uncompress the compressed values.
2598 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2599 Uncompress the compressed values.
2600 (sub_char_table_ref_and_range): Likewise.
2601 (char_table_ref_and_range): Uncompress the compressed values.
2602 (sub_char_table_set): New arg is_uniprop. Callers changed.
2603 Uncompress the compressed values.
2604 (sub_char_table_set_range): Args changed. Callers changed.
2605 (char_table_set_range): Adjuted for the above change.
2606 (map_sub_char_table): Delete args default_val and parent. Add arg
2607 top. Give decoded values to a Lisp function.
2608 (map_char_table): Adjust for the above change. Give decoded
2609 values to a Lisp function. Gcpro more variables.
2610 (uniprop_table_uncompress)
2611 (uniprop_decode_value_run_length): New functions.
2612 (uniprop_decoder, uniprop_decoder_count): New variables.
2613 (uniprop_get_decoder, uniprop_encode_value_character)
2614 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2615 New functions.
2616 (uniprop_encoder, uniprop_encoder_count): New variables.
2617 (uniprop_get_encoder, uniprop_table)
2618 (Funicode_property_table_internal, Fget_unicode_property_internal)
2619 (Fput_unicode_property_internal): New functions.
2620 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2621 Sunicode_property_table_internal, Sget_unicode_property_internal,
2622 and Sput_unicode_property_internal. Defvar_lisp
2623 char-code-property-alist.
2624
2625 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2626 Vunicode_category_table.
2627
2628 * font.c (font_range): Adjust for the change of
2629 Vunicode_category_table.
2630
2631 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2632
2633 * m/iris4d.h: Remove file, move contents ...
2634 * s/irix6-5.h: ... here.
2635
2636 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 Remove unportable assumption about struct layout (Bug#8884).
2639 * alloc.c (mark_buffer):
2640 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2641 (clone_per_buffer_values): Don't assume that
2642 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2643 This isn't true in general, and it's particularly not true
2644 if Emacs is configured with --with-wide-int.
2645 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2646 New macros, used in the buffer.c change.
2647
2648 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2649
2650 * xsettings.c: Use both GConf and GSettings if both are available.
2651 (store_config_changed_event): Add comment.
2652 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2653 (store_tool_bar_style_changed): New functions.
2654 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2655 (struct xsettings): Move font inside HAVE_XFT.
2656 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2657 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2658 Move inside HAVE_XFT.
2659 (something_changed_gsettingsCB): Rename from something_changedCB.
2660 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2661 also.
2662 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2663 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2664 (something_changed_gconfCB): Rename from something_changedCB.
2665 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2666 (parse_settings): Move check for font inside HAVE_XFT.
2667 (read_settings, apply_xft_settings): Add comment.
2668 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2669 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2670 call store_font_name_changed.
2671 (xft_settings_event): Add comment.
2672 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2673 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2674 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2675 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2676 (xsettings_initialize): Call init_gsettings last.
2677 (xsettings_get_system_font, xsettings_get_system_normal_font):
2678 Add comment.
2679
2680 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 Random fixes. E.g., (random) never returned negative values.
2683 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2684 subseconds part to the entropy, as that's a bit more random.
2685 Prefer signed to unsigned, since the signedness doesn't matter and
2686 in general we prefer signed. When given a limit, use a
2687 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2688 latter isn't right if USE_2_TAGS_FOR_INTS.
2689 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2690 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2691
2692 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2693
2694 * textprop.c (text_property_stickiness):
2695 Obey Vtext_property_default_nonsticky.
2696 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2697 * w32fns.c (syms_of_w32fns):
2698 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2699
2700 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2703 This is more efficient than Ffile_directory_p and avoids a minor race.
2704
2705 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2706
2707 * buffer.c (Foverlay_put): Say what the return value is
2708 (bug#7835).
2709
2710 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2711 is a directory before asking whether to use the file name
2712 (bug#7564).
2713 (barf_or_query_if_file_exists): Make the "File is a directory"
2714 error be more correct.
2715
2716 * fns.c (Frequire): Remove the mention of the .gz files, since
2717 that's installation-specific, but keep the mention of
2718 `get-load-suffixes'.
2719
2720 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2723 Report string overflow if the output is too long.
2724
2725 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2726
2727 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2728 (syms_of_gnutls): Remove duplicate DEFSYM for
2729 Qgnutls_bootprop_verify_hostname_error, an error for
2730 Qgnutls_bootprop_verify_error (which is no longer used).
2731
2732 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2733 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2734 Also (re)move comments that are misplaced or no longer relevant.
2735
2736 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2737
2738 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2739
2740 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2741
2742 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2743 and background color parameters if they have been changed.
2744
2745 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2746
2747 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2748
2749 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * xsettings.c (SYSTEM_FONT): Define only when used.
2752 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2753
2754 * keymap.c (access_keymap_1): Now static.
2755
2756 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2757
2758 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2759 leave any prefix arg for the up event (Bug#1586).
2760
2761 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2762
2763 * lread.c (syms_of_lread): Mention single symbols defined by
2764 `defvar' or `defconst' (bug#7154).
2765
2766 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2767 (Frequire): Mention get-load-suffixes.
2768
2769 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2770
2771 * window.h (window): Remove clone_number slot.
2772 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2773 Remove.
2774 (make_parent_window, make_window, saved_window)
2775 (Fset_window_configuration, save_window_save): Don't deal with
2776 clone numbers.
2777 * buffer.c (Qclone_number): Remove declaration.
2778 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2779
2780 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 Add multiple inheritance to keymaps.
2783 * keymap.c (Fmake_composed_keymap): New function.
2784 (Fset_keymap_parent): Simplify.
2785 (fix_submap_inheritance): Remove.
2786 (access_keymap_1): New function extracted from access_keymap to handle
2787 embedded parents and handle lists of maps.
2788 (access_keymap): Use it.
2789 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2790 (Fcopy_keymap): Handle embedded parents.
2791 (Fcommand_remapping, define_as_prefix): Simplify.
2792 (Fkey_binding): Simplify.
2793 (syms_of_keymap): Move minibuffer-local-completion-map,
2794 minibuffer-local-filename-completion-map,
2795 minibuffer-local-must-match-map, and
2796 minibuffer-local-filename-must-match-map to Elisp.
2797 (syms_of_keymap): Defsubr make-composed-keymap.
2798 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2799 (parse_menu_item): Trivial simplification.
2800
2801 2011-07-01 Glenn Morris <rgm@gnu.org>
2802
2803 * Makefile.in (SETTINGS_LIBS): Fix typo.
2804
2805 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2806
2807 * coding.c (Fencode_coding_string): Record the last coding system
2808 used, as the function doc string says (bug#8738).
2809
2810 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2811
2812 * xsettings.c (store_monospaced_changed): Take new font as arg and
2813 check for change against current_mono_font.
2814 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2815 (emacs_settings_constructor, emacs_settings_get_property)
2816 (emacs_settings_set_property, emacs_settings_class_init)
2817 (emacs_settings_init, gsettings_obj): Remove.
2818 (something_changedCB): New function for HAVE_GSETTINGS.
2819 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2820 with value as argument.
2821 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2822 g_settings_new (Bug#8967). Do not create gsettings_obj.
2823 Remove calls to g_settings_bind. Connect something_changedCB to
2824 "changed".
2825
2826 * xgselect.c: Add defined (HAVE_GSETTINGS).
2827 (xgselect_initialize): Ditto.
2828
2829 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2830 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2831 xg_select.
2832
2833 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2834
2835 * eval.c (struct backtrace): Simplify and port the data structure.
2836 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2837 signed bit field, as this assumption is not portable and it makes
2838 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2839 "char debug_on_exit : 1" as this is not portable either; instead,
2840 use the portable "unsigned int debug_on_exit : 1". Remove unused
2841 member evalargs. Remove obsolete comments about cc bombing out.
2842
2843 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2844
2845 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2846 Let HAVE_GSETTINGS override HAVE_GCONF.
2847 (store_monospaced_changed): New function.
2848 (EMACS_SETTINGS): A new type derived from GObject to handle
2849 GSettings notifications.
2850 (emacs_settings_constructor, emacs_settings_get_property)
2851 (emacs_settings_set_property, emacs_settings_class_init):
2852 New functions.
2853 (gsettings_client, gsettings_obj): New variables.
2854 (GSETTINGS_SCHEMA): New define.
2855 (something_changedCB): Call store_monospaced_changed.
2856 (init_gsettings): New function.
2857 (xsettings_initialize): Call init_gsettings.
2858 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2859 to NULL.
2860
2861 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2862 GCONF_CFLAGS/LIBS.
2863
2864 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2865
2866 * window.c (resize_root_window, grow_mini_window)
2867 (shrink_mini_window): Rename Qresize_root_window to
2868 Qwindow_resize_root_window and Qresize_root_window_vertically to
2869 Qwindow_resize_root_window_vertically.
2870
2871 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2874
2875 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * makefile.w32-in: Redesign dependencies so they reflect more
2878 clearly which files are directly included by each source file,
2879 and not through other includes.
2880
2881 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2882
2883 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2884 (sort_overlays, overlay_strings): When an overlay's clone number
2885 matches the window's clone number process the overlay even if
2886 the overlay's window property doesn't match the current window.
2887
2888 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2889 (Fwindow_hchild): Rename to Fwindow_left_child.
2890 (Fwindow_next): Rename to Fwindow_next_sibling.
2891 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2892 (resize_window_check): Rename to window_resize_check.
2893 (resize_window_apply): Rename to window_resize_apply.
2894 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2895 (Fdelete_other_windows_internal, resize_frame_windows)
2896 (Fsplit_window_internal, Fdelete_window_internal)
2897 (grow_mini_window, shrink_mini_window)
2898 (Fresize_mini_window_internal): Fix callers accordingly.
2899
2900 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2901
2902 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2903 (emacs_fixed_set_min_size): Remove.
2904 (emacs_fixed_new): Take frame as argument.
2905
2906 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2907 (_EmacsFixedPrivate): Remove minwidth/height.
2908 Add struct frame *f.
2909 (emacs_fixed_init): Initialize priv->f.
2910 (get_parent_class, emacs_fixed_set_min_size): Remove.
2911 (emacs_fixed_new): Set priv->f to argument.
2912 (emacs_fixed_get_preferred_width)
2913 (emacs_fixed_get_preferred_height): Use min_width/height from
2914 frames size_hint to set minimum and natural (Bug#8919).
2915 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2916 and use min_width/height from frames size_hint to set
2917 min_width/height (Bug#8919).
2918
2919 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2920 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2921 Fix indentation.
2922
2923 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2924
2925 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2926 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2927 called at ZV.
2928
2929 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2930
2931 * process.c (wait_reading_process_output): Bypass select if
2932 waiting for a cell while ignoring keyboard input, and input is
2933 pending. Suggested by Jan Djärv (Bug#8869).
2934
2935 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 Use gnulib's dup2 module instead of rolling our own.
2938 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2939
2940 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2941
2942 * dispnew.c (scrolling_window): Before scrolling, turn off a
2943 mouse-highlight in the window being scrolled.
2944
2945 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2946
2947 Move DEFSYM to lisp.h and use everywhere.
2948
2949 * character.h (DEFSYM): Move declaration...
2950 * lisp.h (DEFSYM): ...here.
2951
2952 * gnutls.c:
2953 * minibuf.c:
2954 * w32menu.c:
2955 * w32proc.c:
2956 * w32select.c: Don't include character.h.
2957
2958 * alloc.c (syms_of_alloc):
2959 * buffer.c (syms_of_buffer):
2960 * bytecode.c (syms_of_bytecode):
2961 * callint.c (syms_of_callint):
2962 * casefiddle.c (syms_of_casefiddle):
2963 * casetab.c (init_casetab_once):
2964 * category.c (init_category_once, syms_of_category):
2965 * ccl.c (syms_of_ccl):
2966 * cmds.c (syms_of_cmds):
2967 * composite.c (syms_of_composite):
2968 * dbusbind.c (syms_of_dbusbind):
2969 * dired.c (syms_of_dired):
2970 * dispnew.c (syms_of_display):
2971 * doc.c (syms_of_doc):
2972 * editfns.c (syms_of_editfns):
2973 * emacs.c (syms_of_emacs):
2974 * eval.c (syms_of_eval):
2975 * fileio.c (syms_of_fileio):
2976 * fns.c (syms_of_fns):
2977 * frame.c (syms_of_frame):
2978 * fringe.c (syms_of_fringe):
2979 * insdel.c (syms_of_insdel):
2980 * keymap.c (syms_of_keymap):
2981 * lread.c (init_obarray, syms_of_lread):
2982 * macros.c (syms_of_macros):
2983 * msdos.c (syms_of_msdos):
2984 * print.c (syms_of_print):
2985 * process.c (syms_of_process):
2986 * search.c (syms_of_search):
2987 * sound.c (syms_of_sound):
2988 * syntax.c (init_syntax_once, syms_of_syntax):
2989 * terminal.c (syms_of_terminal):
2990 * textprop.c (syms_of_textprop):
2991 * undo.c (syms_of_undo):
2992 * w32.c (globals_of_w32):
2993 * window.c (syms_of_window):
2994 * xdisp.c (syms_of_xdisp):
2995 * xfaces.c (syms_of_xfaces):
2996 * xfns.c (syms_of_xfns):
2997 * xmenu.c (syms_of_xmenu):
2998 * xsettings.c (syms_of_xsettings):
2999 * xterm.c (syms_of_xterm): Use DEFSYM.
3000
3001 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3002
3003 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3004
3005 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 Integer and buffer overflow fixes (Bug#8873).
3008
3009 * print.c (printchar, strout): Check for string overflow.
3010 (PRINTPREPARE, printchar, strout):
3011 Don't set size unless allocation succeeds.
3012
3013 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3014 for sizes. Check for string overflow more accurately.
3015 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3016
3017 * macros.c: Integer and buffer overflow fixes.
3018 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3019 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3020 Use ptrdiff_t, not int, for sizes.
3021 Don't increment bufsize until after realloc succeeds.
3022 Check for size-calculation overflow.
3023 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3024
3025 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3026
3027 * lread.c: Integer overflow fixes.
3028 (read_integer): Radix is now EMACS_INT, not int,
3029 to improve quality of diagnostics for out-of-range radices.
3030 Calculate buffer size correctly for out-of-range radices.
3031 (read1): Check for integer overflow in radices, and in
3032 read-circle numbers.
3033 (read_escape): Avoid int overflow.
3034 (Fload, openp, read_buffer_size, read1)
3035 (substitute_object_recurse, read_vector, read_list, map_obarray):
3036 Use ptrdiff_t, not int, for sizes.
3037 (read1): Use EMACS_INT, not int, for sizes.
3038 Check for size overflow.
3039
3040 * image.c (cache_image): Check for size arithmetic overflow.
3041
3042 * lread.c: Integer overflow issues.
3043 (saved_doc_string_size, saved_doc_string_length)
3044 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3045 Now ptrdiff_t, not int.
3046 (read1): Don't assume doc string length fits in int. Check for
3047 out-of-range doc string lengths.
3048 (read_list): Don't assume file position fits in int.
3049 (read_escape): Check for hex character overflow.
3050
3051 2011-06-22 Leo Liu <sdl.web@gmail.com>
3052
3053 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3054 Move to minibuffer.el.
3055
3056 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3059 The following patches are for when GLYPH_DEBUG && !XASSERT.
3060 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3061 * dispnew.c (flush_stdout):
3062 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3063 Mark as externally visible.
3064 * dispnew.c (check_window_matrix_pointers): Now static.
3065 * dispnew.c (window_to_frame_vpos):
3066 * xfns.c (unwind_create_frame):
3067 * xterm.c (x_check_font): Remove unused local.
3068 * scroll.c (CHECK_BOUNDS):
3069 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3070 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3071 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3072 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3073 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3074 Now static.
3075 (debug_method_add): Use va_list and vsprintf rather than relying
3076 on undefined behavior with wrong number of arguments.
3077 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3078 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3079 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3080 since we're not interested in debugging glyphs with old libraries.
3081 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3082 GCC 4.6.0's static checking.
3083
3084 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 Integer overflow and signedness fixes (Bug#8873).
3087 A few related buffer overrun fixes, too.
3088
3089 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3090
3091 * dispextern.h (struct face.stipple):
3092 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3093 (x_bitmap_mask, x_allocate_bitmap_record)
3094 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3095 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3096 (x_create_bitmap_from_xpm_data):
3097 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3098 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3099 (.bitmaps_last):
3100 * xfaces.c (load_pixmap):
3101 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3102 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3103 (.bitmaps_last, struct x_output.icon_bitmap):
3104 Use ptrdiff_t, not int, for bitmap indexes.
3105 (x_allocate_bitmap_record): Check for size overflow.
3106 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3107
3108 Use ptrdiff_t, not int, for overlay counts.
3109 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3110 * editfns.c (overlays_around, get_pos_property):
3111 * textprop.c (get_char_property_and_overlay):
3112 * xdisp.c (next_overlay_change, note_mouse_highlight):
3113 * xfaces.c (face_at_buffer_position):
3114 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3115 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3116 (Fnext_overlay_change, Fprevious_overlay_change)
3117 (mouse_face_overlay_overlaps, Foverlays_in):
3118 Use ptrdiff_t, not int, for sizes.
3119 (overlays_at, overlays_in): Check for size-calculation overflow.
3120
3121 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3122
3123 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3124 (x_session_initialize): Do not assume string length fits in int.
3125
3126 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3127 This is unlikely, but can occur if DPI is outlandish.
3128
3129 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3130 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3131
3132 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3133 * xrdb.c (magic_file_p, search_magic_path):
3134 Omit last arg SUFFIX; it was always 0. All callers changed.
3135 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3136
3137 * xfont.c (xfont_match): Avoid need for strlen.
3138
3139 * xfns.c: Don't assume strlen fits in int.
3140 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3141
3142 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3143 not unsigned long, as we prefer signed integers. All callers changed.
3144 Detect integer overflow in repeat count.
3145 (message_dolog): Don't assume print length fits in 39 bytes.
3146 (display_mode_element): Don't assume strlen fits in int.
3147
3148 * termcap.c: Don't assume sizes fit in int and never overflow.
3149 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3150 (gobble_line): Check for size-calculation overflow.
3151
3152 * minibuf.c (Fread_buffer):
3153 * lread.c (intern, intern_c_string):
3154 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3155 Don't assume string length fits in int.
3156
3157 * keyboard.c (parse_tool_bar_item):
3158 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3159
3160 * font.c: Don't assume string length fits in int.
3161 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3162 Use ptrdiff_t, not int.
3163 (font_intern_prop): Don't assume string length fits in int.
3164 Don't assume integer property fits in fixnum.
3165 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3166
3167 * filelock.c: Fix some buffer overrun and integer overflow issues.
3168 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3169 Reformulate so as not to need the command string.
3170 Invoke gzip -cd rather than gunzip, as it's more portable.
3171 (lock_info_type, lock_file_1, lock_file):
3172 Don't assume pid_t and time_t fit in unsigned long.
3173 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3174 (current_lock_owner): Prefer signed type for sizes.
3175 Use memcpy, not strncpy, where memcpy is what is really wanted.
3176 Don't assume (via atoi) that time_t and pid_t fit in int.
3177 Check for time_t and/or pid_t out of range, e.g., via a network share.
3178 Don't alloca where an auto var works fine.
3179
3180 * fileio.c: Fix some integer overflow issues.
3181 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3182 Don't assume string length fits in int.
3183 (directory_file_name): Don't assume string length fits in long.
3184 (make_temp_name): Don't assume pid fits in int, or that its print
3185 length is less than 20.
3186
3187 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3188
3189 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3190
3191 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3192
3193 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3194 We prefer signed integers, even for size calculations.
3195
3196 * emacs.c: Don't assume string length fits in 'int'.
3197 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3198 (main): Don't invoke strlen when not needed.
3199
3200 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3201 (XD_DEBUG_MESSAGE): Don't waste a byte.
3202
3203 * callproc.c (getenv_internal_1, getenv_internal)
3204 (Fgetenv_internal):
3205 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3206
3207 * lread.c (invalid_syntax): Omit length argument.
3208 All uses changed. This doesn't fix a bug, but it simplifies the
3209 code away from its former Hollerith-constant appearance, and it's
3210 one less 'int' to worry about when looking at integer-overflow issues.
3211 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3212
3213 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3214 This didn't break anything, but it didn't help either.
3215 It's confusing to put a bogus integer in a place where the actual
3216 value does not matter.
3217 (LIST_END_P): Remove unused macro and its bogus comment.
3218 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3219
3220 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3221 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3222 implementation.
3223 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3224 We prefer signed types, and the value cannot exceed the EMACS_INT
3225 range anyway (because otherwise the length would not be representable).
3226 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3227 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3228 This avoids a GCC warning when WIDE_EMACS_INT.
3229
3230 * indent.c (sane_tab_width): New function.
3231 (current_column, scan_for_column, Findent_to, position_indentation)
3232 (compute_motion): Use it. This is just for clarity.
3233 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3234
3235 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3236
3237 * lisp.h (lint_assume): New macro.
3238 * composite.c (composition_gstring_put_cache):
3239 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3240
3241 * editfns.c, insdel.c:
3242 Omit unnecessary forward decls, to simplify future changes.
3243
3244 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3245
3246 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3247
3248 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3249 Use much-faster test for byte-length change.
3250 Don't assume string byte-length fits in 'int'.
3251 Check that character arg fits in 'int'.
3252 (mapcar1): Declare byte as byte, for clarity.
3253
3254 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3255
3256 * fns.c (concat): Catch string overflow earlier.
3257 Do not rely on integer wraparound.
3258
3259 * dispextern.h (struct it.overlay_strings_charpos)
3260 (struct it.selective): Now EMACS_INT, not int.
3261 * xdisp.c (forward_to_next_line_start)
3262 (back_to_previous_visible_line_start)
3263 (reseat_at_next_visible_line_start, next_element_from_buffer):
3264 Don't arbitrarily truncate the value of 'selective' to int.
3265
3266 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3267
3268 * composite.c: Don't truncate sizes to 'int'.
3269 (composition_gstring_p, composition_reseat_it)
3270 (composition_adjust_point): Use EMACS_INT, not int.
3271 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3272 not EMACS_UINT, for indexes.
3273
3274 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3275
3276 * buffer.c: Include <verify.h>.
3277 (struct sortvec.priority, struct sortstr.priority):
3278 Now EMACS_INT, not int.
3279 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3280 (struct sortstr.size, record_overlay_string)
3281 (struct sortstrlist.size, struct sortlist.used):
3282 Don't truncate size to int.
3283 (record_overlay_string): Check for size-calculation overflow.
3284 (init_buffer_once): Check at compile-time, not run-time.
3285
3286 2011-06-22 Jim Meyering <meyering@redhat.com>
3287
3288 Don't leak an XBM-image-sized buffer
3289 * image.c (xbm_load): Free the image buffer after using it.
3290
3291 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 Port to Sun C.
3294 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3295 that Sun C diagnosed.
3296 * fns.c (secure_hash): Fix pointer signedness issue.
3297 * intervals.c (static_offset_intervals): New function.
3298 (offset_intervals): Use it.
3299
3300 2011-06-21 Leo Liu <sdl.web@gmail.com>
3301
3302 * deps.mk (fns.o):
3303 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3304 sha512.h.
3305
3306 * fns.c (secure_hash): Rename from crypto_hash_function and change
3307 the first arg to accept symbols.
3308 (Fsecure_hash): New primitive.
3309 (syms_of_fns): New symbols.
3310
3311 2011-06-20 Deniz Dogan <deniz@dogan.se>
3312
3313 * process.c (Fset_process_buffer): Clarify return value in
3314 docstring.
3315
3316 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3317
3318 * dispnew.c (add_window_display_history): Use BVAR.
3319
3320 * xdisp.c (debug_method_add): Use BVAR.
3321 (check_window_end, dump_glyph_matrix, dump_glyph)
3322 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3323
3324 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3325 Likewise.
3326
3327 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3328 check till after the cache is created in init_frame_faces.
3329
3330 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3331
3332 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3333
3334 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3337 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3338 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3339
3340 Improve buffer-overflow checking (Bug#8873).
3341 * fileio.c (Finsert_file_contents):
3342 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3343 Remove the old (too-loose) buffer overflow checks.
3344 They weren't needed, since make_gap checks for buffer overflow.
3345 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3346 The old code merely checked for Emacs fixnum overflow, and relied
3347 on undefined (wraparound) behavior. The new code avoids undefined
3348 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3349
3350 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3351 Tune. Don't use wider integers than needed. Don't use alloca.
3352 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3353
3354 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3355
3356 * insdel.c, lisp.h (buffer_overflow): New function.
3357 (insert_from_buffer_1, replace_range, replace_range_2):
3358 * insdel.c (make_gap_larger):
3359 * editfns.c (Finsert_char):
3360 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3361
3362 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3363
3364 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 Integer overflow and signedness fixes (Bug#8873).
3367
3368 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3369 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3370
3371 * fileio.c: Don't assume EMACS_INT fits in off_t.
3372 (emacs_lseek): New static function.
3373 (Finsert_file_contents, Fwrite_region): Use it.
3374 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3375
3376 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3377
3378 * fns.c: Don't overflow int when computing a list length.
3379 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3380 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3381 truncation on 64-bit hosts. Check for QUIT every
3382 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3383 faster and is responsive enough.
3384 (Flength): Report an error instead of overflowing an integer.
3385 (Fsafe_length): Return a float if the value is not representable
3386 as a fixnum. This shouldn't happen except in contrived situations.
3387 (Fnthcdr, Fsort): Don't assume list length fits in int.
3388 (Fcopy_sequence): Don't assume vector length fits in int.
3389
3390 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3391 (header_size, word_size): New constants.
3392 (allocate_vectorlike): Don't check size overflow here.
3393 (allocate_vector): Check it here instead, since this is the only
3394 caller of allocate_vectorlike that could cause overflow.
3395 Check that the new vector's length is representable as a fixnum.
3396
3397 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3398 The previous code was bogus. For example, next_almost_prime (32)
3399 returned 39, which is undesirable as it is a multiple of 3; and
3400 next_almost_prime (24) returned 25, which is a multiple of 5 so
3401 why was the code bothering to check for multiples of 7?
3402
3403 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3404
3405 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3406
3407 Variadic C functions now count arguments with ptrdiff_t.
3408 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3409 Back then I didn't know that the Emacs coding style prefers signed int.
3410 Also, in the meantime I found a few more instances where arguments
3411 were being counted with int, which may truncate counts on 64-bit
3412 machines, or EMACS_INT, which may be unnecessarily wide.
3413 * lisp.h (struct Lisp_Subr.function.aMANY)
3414 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3415 Arg counts are now ptrdiff_t, not size_t.
3416 All variadic functions and their callers changed accordingly.
3417 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3418 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3419 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3420 * callint.c (Fcall_interactively): Check arg count for overflow,
3421 to avoid potential buffer overrun. Use signed char, not 'int',
3422 for 'varies' array, so that we needn't bother to check its size
3423 calculation for overflow.
3424 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3425 * eval.c (apply_lambda):
3426 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3427 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3428 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3429
3430 * callint.c (Fcall_interactively): Don't use index var as event count.
3431
3432 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3433 * mem-limits.h (SIZE): Remove; no longer used.
3434
3435 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3436
3437 Remove unnecessary casts.
3438 * xterm.c (x_term_init):
3439 * xfns.c (x_set_border_pixel):
3440 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3441 These aren't needed now that we assume ANSI C.
3442
3443 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3444 It's more likely to cause problems (due to unsigned overflow)
3445 than to cure them.
3446
3447 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3448
3449 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3450
3451 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3452
3453 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3454
3455 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3456
3457 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3458
3459 GLYPH_CODE_FACE returns EMACS_INT, not int.
3460 * dispextern.h (merge_faces):
3461 * xfaces.c (merge_faces):
3462 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3463 Don't assume EMACS_INT fits in int.
3464
3465 * character.h (CHAR_VALID_P): Remove unused parameter.
3466 * fontset.c, lisp.h, xdisp.c: All uses changed.
3467
3468 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3469
3470 * fns.c (concat): Minor tuning based on overflow analysis.
3471 This doesn't fix any bugs. Use int to hold character, instead
3472 of constantly refetching from Emacs object. Use XFASTINT, not
3473 XINT, for value known to be a character. Don't bother comparing
3474 a single byte to 0400, as it's always less.
3475
3476 * floatfns.c (Fexpt):
3477 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3478
3479 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3480 for characters.
3481
3482 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3483
3484 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3485 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3486 incorrectly succeed when S was a string, because 4294967386 was
3487 truncated before it was used.
3488
3489 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3490 Otherwise, an out-of-range integer could cause undefined behavior
3491 on a 64-bit host.
3492
3493 * composite.c: Use int, not EMACS_INT, for characters.
3494 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3495 EMACS_INT, for values that are known to be in character range.
3496 This doesn't fix any bugs but is the usual style inside Emacs and
3497 may generate better code on 32-bit machines.
3498
3499 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3500 This is for reasons similar to the recent CHAR_STRING fix.
3501 * charset.c (Fencode_char): Check that character arg is actually
3502 a character. Pass an int to ENCODE_CHAR.
3503 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3504 wider than 'int', as a compile-time check to prevent future regressions
3505 in this area.
3506
3507 * character.c (char_string): Remove unnecessary casts.
3508
3509 Make sure a 64-bit char is never passed to CHAR_STRING.
3510 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3511 by silently ignoring the top 32 bits, allowing some values
3512 that were far too large to be valid characters.
3513 * character.h: Include <verify.h>.
3514 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3515 arguments are no wider than unsigned, as a compile-time check
3516 to prevent future regressions in this area.
3517 * data.c (Faset):
3518 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3519 (Fsubst_char_in_region):
3520 * fns.c (concat):
3521 * xdisp.c (decode_mode_spec_coding):
3522 Adjust to CHAR_STRING's new requirement.
3523 * editfns.c (Finsert_char, Fsubst_char_in_region):
3524 * fns.c (concat): Check that character args are actually
3525 characters. Without this test, these functions did the wrong
3526 thing with wildly out-of-range values on 64-bit hosts.
3527
3528 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3529 These casts should not be needed on 32-bit hosts, either.
3530 * keyboard.c (read_char):
3531 * lread.c (Fload): Remove casts to unsigned.
3532
3533 * lisp.h (UNSIGNED_CMP): New macro.
3534 This fixes comparison bugs on 64-bit hosts.
3535 (ASCII_CHAR_P): Use it.
3536 * casefiddle.c (casify_object):
3537 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3538 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3539 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3540 * dispextern.h (FACE_FROM_ID):
3541 * keyboard.c (read_char): Use UNSIGNED_CMP.
3542
3543 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3544 not to EMACS_INT, to avoid GCC warning.
3545
3546 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3547
3548 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3549 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3550 isn't needed on 32-bit machines.
3551
3552 * buffer.c (Fgenerate_new_buffer_name):
3553 Use EMACS_INT for count, not int.
3554 (advance_to_char_boundary): Return EMACS_INT, not int.
3555
3556 * data.c (Qcompiled_function): Now static.
3557
3558 * window.c (window_body_lines): Now static.
3559
3560 * image.c (gif_load): Rename local to avoid shadowing.
3561
3562 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3563 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3564 * alloc.c (make_save_value): Integer argument is now of type
3565 ptrdiff_t, not int.
3566 (mark_object): Use ptrdiff_t, not int.
3567 * lisp.h (pD): New macro.
3568 * print.c (print_object): Use it.
3569
3570 * alloc.c: Use EMACS_INT, not int, to count objects.
3571 (total_conses, total_markers, total_symbols, total_vector_size)
3572 (total_free_conses, total_free_markers, total_free_symbols)
3573 (total_free_floats, total_floats, total_free_intervals)
3574 (total_intervals, total_strings, total_free_strings):
3575 Now EMACS_INT, not int. All uses changed.
3576 (Fgarbage_collect): Compute overall total using a double, so that
3577 integer overflow is less likely to be a problem. Check for overflow
3578 when converting back to an integer.
3579 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3580 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3581 These were 'int' variables that could overflow on 64-bit hosts;
3582 they were never used, so remove them instead of repairing them.
3583 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3584 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3585 Previously, this ceilinged at INT_MAX, but that doesn't work on
3586 64-bit machines.
3587 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3588
3589 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3590 (allocate_vectorlike): Check for ptrdiff_t overflow.
3591 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3592 when a (possibly-narrower) signed value would do just as well.
3593 We prefer using signed arithmetic, to avoid comparison confusion.
3594
3595 * alloc.c: Catch some string size overflows that we were missing.
3596 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3597 for convenience in STRING_BYTES_MAX.
3598 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3599 The definition here is exact; the one in lisp.h was approximate.
3600 (allocate_string_data): Check for string overflow. This catches
3601 some instances we weren't catching before. Also, it catches
3602 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3603 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3604 and ptrdiff_t and EMACS_INT are both 64 bits.
3605
3606 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3607 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3608 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3609
3610 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3611
3612 * alloc.c (Fmake_string): Check for out-of-range init.
3613
3614 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3617
3618 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3619
3620 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3621 xg_get_default_scrollbar_width.
3622
3623 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3624 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3625 (style_changed_cb): Call update_theme_scrollbar_width and call
3626 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3627 all frames (Bug#8505).
3628 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3629 Call gtk_window_set_resizable if HAVE_GTK3.
3630 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3631 and height if HAVE_GTK3 (Bug#8505).
3632 (scroll_bar_width_for_theme): New variable.
3633 (update_theme_scrollbar_width): New function.
3634 (xg_get_default_scrollbar_width): Move code to
3635 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3636 (xg_initialize): Call update_theme_scrollbar_width.
3637
3638 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3639
3640 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3641
3642 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3643
3644 * frame.c (make_frame): Call other_buffer_safely instead of
3645 other_buffer.
3646
3647 * window.c (temp_output_buffer_show): Call display_buffer with
3648 second argument Vtemp_buffer_show_specifiers and reset latter
3649 immediately after the call.
3650 (Vtemp_buffer_show_specifiers): New variable.
3651 (auto_window_vscroll_p, next_screen_context_lines)
3652 (Vscroll_preserve_screen_position): Remove leading asterisks from
3653 doc-strings.
3654
3655 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 Fix minor problems found by GCC 4.6.0 static checking.
3658 * buffer.c (Qclone_number): Remove for now, as it's unused.
3659 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3660 (record_buffer): Remove unused local.
3661 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3662 (set_frame_buffer_list): Remove; unused.
3663 * frame.h (other_visible_frames): Remove decl.
3664 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3665 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3666 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3667 if HAVE_GPM.
3668 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3669 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3670 Define only if HAVE_GPM.
3671 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3672 (update_hints_inhibit): Remove; never set. All uses removed.
3673 * widgetprv.h (emacsFrameClassRec): Remove decl.
3674 * window.c (delete_deletable_window): Now returns void, since it
3675 wasn't returning anything.
3676 (compare_window_configurations): Remove unused locals.
3677 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3678 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3679 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3680 the same widths as pointers. This follows up on the 2011-05-06 patch.
3681 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3682 * xterm.h: Likewise.
3683 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3684
3685 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3686
3687 * makefile.w32-in: Update dependencies.
3688 (LISP_H): Add lib/intprops.h.
3689
3690 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * image.c (gif_load): Add animation frame delay to the metadata.
3693 (syms_of_image): Use DEFSYM. New symbol `delay'.
3694
3695 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3696
3697 * window.c (delete_deletable_window): Re-add.
3698 (Fset_window_configuration): Rewrite to handle dead buffers and
3699 consequently deletable windows.
3700 (window_tree, Fwindow_tree): Remove. Supply functionality in
3701 window.el.
3702 (compare_window_configurations): Simplify code.
3703
3704 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3705
3706 * image.c (imagemagick_load_image): Fix type mismatch.
3707 (Fimagemagick_types): Likewise.
3708
3709 * window.h (replace_buffer_in_windows): Declare.
3710
3711 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3712
3713 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3714 Qclone_number. Remove external declaration of Qdelete_window.
3715 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3716 code.
3717 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3718 Run Qbuffer_list_update_hook if allowed.
3719 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3720 buffer list implementation.
3721 (other_buffer_safely): New function.
3722 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3723 calls to replace_buffer_in_windows and
3724 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3725 if allowed.
3726 (record_buffer): Inhibit quitting and rewrite using quittable
3727 functions. Run Qbuffer_list_update_hook if allowed.
3728 (Frecord_buffer, Funrecord_buffer): New functions.
3729 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3730 Move switch-to-buffer to window.el.
3731 (bury-buffer): Move to window.el.
3732 (Vbuffer_list_update_hook): New variable.
3733
3734 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3735 section.
3736
3737 * window.h (resize_frame_windows): Move up in code.
3738 (Fwindow_frame): Remove EXFUN.
3739 (replace_buffer_in_all_windows): Remove prototype.
3740 (replace_buffer_in_windows_safely): Add prototype.
3741
3742 * window.c: Declare Qdelete_window static again. Move down
3743 declaration of select_count.
3744 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3745 (Fother_window): Move to window.el.
3746 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3747 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3748 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3749 window.el.
3750 (replace_buffer_in_windows): Implement by calling
3751 Qreplace_buffer_in_windows.
3752 (replace_buffer_in_all_windows): Remove with some functionality
3753 moved into replace_buffer_in_windows_safely.
3754 (replace_buffer_in_windows_safely): New function.
3755 (select_window_norecord, select_frame_norecord): Move in front
3756 of run_window_configuration_change_hook. Remove now obsolete
3757 declarations.
3758 (Fset_window_buffer): Rewrite doc-string.
3759 Call Qrecord_window_buffer.
3760 (keys_of_window): Move binding for other-window to window.el.
3761
3762 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3763
3764 * dispextern.h (struct image): Replace data member, whose int_val
3765 and ptr_val fields were not used by anything, with a single
3766 lisp_val object.
3767
3768 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3769 (gif_clear_image, gif_load, imagemagick_load_image)
3770 (gs_clear_image, gs_load): Callers changed.
3771
3772 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 * buffer.h: Include <time.h>, for time_t.
3775 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3776
3777 Fix minor problems found by static checking.
3778
3779 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3780
3781 Make identifiers static if they are not used in other modules.
3782 * data.c (Qcompiled_function, Qframe, Qvector):
3783 * image.c (QimageMagick, Qsvg):
3784 * minibuf.c (Qmetadata):
3785 * window.c (resize_window_check, resize_root_window): Now static.
3786 * window.h (resize_window_check, resize_root_window): Remove decls.
3787
3788 * window.c (window_deletion_count, delete_deletable_window):
3789 Remove; unused.
3790 (window_body_lines): Now static.
3791 (Fdelete_other_windows_internal): Mark vars as initialized.
3792 Make sure 'resize_failed' is initialized.
3793 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3794 (resize_window_apply): Remove unused local.
3795 * window.h (delete_deletable_window): Remove decl.
3796
3797 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3798 (imagemagick_load_image): Fix pointer signedness problem by changing
3799 last arg from unsigned char * to char *. All uses changed.
3800 Also, fix a local for similar reasons.
3801 Remove unused locals. Remove locals to avoid shadowing.
3802 (fn_rsvg_handle_free): Remove; unused.
3803 (svg_load, svg_load_image): Fix pointer signedness problem.
3804 (imagemagick_load_image): Don't use garbage pointer image_wand.
3805
3806 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3807
3808 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3809
3810 * image.c (gif_load): Fix omitted cast error introduced by
3811 2011-06-06 change.
3812
3813 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3814
3815 * window.h (resize_proportionally, orig_total_lines)
3816 (orig_top_line): Remove from window structure.
3817 (set_window_height, set_window_width, change_window_heights)
3818 (Fdelete_window): Remove prototypes.
3819 (resize_frame_windows): Remove duplicate declaration.
3820
3821 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3822
3823 * window.h (resize_frame_windows, resize_window_check)
3824 (delete_deletable_window, resize_root_window)
3825 (resize_frame_windows): Declare prototypes.
3826
3827 * window.c (resize_window_apply): Make definition be "static" to
3828 match the prototype.
3829
3830 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3831
3832 * window.c: Remove declarations of Qwindow_size_fixed,
3833 window_min_size_1, window_min_size_2, window_min_size,
3834 size_window, window_fixed_size_p, enlarge_window, delete_window.
3835 Remove static from declaration of Qdelete_window, it's
3836 temporarily needed by Fbury_buffer.
3837 (replace_window): Don't assign orig_top_line and
3838 orig_total_lines.
3839 (Fdelete_window, delete_window): Remove. Window deletion is
3840 handled by window.el.
3841 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3842 Replace Fdelete_window calls with calls to Qdelete_window.
3843 (Fdelete_other_windows): Remove. Deleting other windows is
3844 handled by window.el.
3845 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3846 handled in window.el.
3847 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3848 Window minimum sizes are handled in window.el.
3849 (shrink_windows, size_window, set_window_height)
3850 (set_window_width, change_window_heights, window_height)
3851 (window_width, CURBEG, CURSIZE, enlarge_window)
3852 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3853 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3854 handled in window.el.
3855 (make_dummy_parent): Rename to make_parent_window and give it a
3856 second argument horflag.
3857 (make_window): Don't set resize_proportionally any more.
3858 (Fsplit_window): Remove. Windows are split in window.el.
3859 (save_restore_action, save_restore_orig_size)
3860 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3861 Resize mini windows in window.el.
3862 (grow_mini_window, shrink_mini_window): Implement by calling
3863 Qresize_root_window_vertically, resize_window_check and
3864 resize_window_apply.
3865 (saved_window, Fset_window_configuration, save_window_save):
3866 Do not handle orig_top_line, orig_total_lines, and
3867 resize_proportionally.
3868 (window_min_height, window_min_width): Move to window.el.
3869 (keys_of_window): Move bindings for delete-other-windows,
3870 split-window, delete-window and enlarge-window to window.el.
3871
3872 * buffer.c: Temporarily extern Qdelete_window.
3873 (Fbury_buffer): Temporarily call Qdelete_window instead of
3874 Fdelete_window (Fbury_buffer will move to window.el soon).
3875
3876 * frame.c (set_menu_bar_lines_1): Remove code handling
3877 orig_top_line and orig_total_lines.
3878
3879 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3880 set_window_height but set heights directly.
3881 (change_frame_size_1): Use resize_frame_windows.
3882
3883 * xdisp.c (init_xdisp): Don't use set_window_height but set
3884 heights directly.
3885
3886 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3887 Use resize_frame_windows instead of change_window_heights and run
3888 run_window_configuration_change_hook.
3889
3890 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3891 instead of change_window_heights and run
3892 run_window_configuration_change_hook.
3893
3894 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3895
3896 * window.c (replace_window): Rename second argument REPLACEMENT to
3897 NEW. New third argument SETFLAG. Rewrite.
3898 (delete_window, make_dummy_parent): Call replace_window with
3899 third argument 1.
3900 (window_list_1): Move down in code.
3901 (run_window_configuration_change_hook): Move set_buffer part
3902 before select_frame_norecord part in order to unwind correctly.
3903 Rename count1 to count.
3904 (recombine_windows, delete_deletable_window, resize_root_window)
3905 (Fdelete_other_windows_internal)
3906 (Frun_window_configuration_change_hook, make_parent_window)
3907 (resize_window_check, resize_window_apply, Fresize_window_apply)
3908 (resize_frame_windows, Fsplit_window_internal)
3909 (Fdelete_window_internal, Fresize_mini_window_internal):
3910 New functions.
3911 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3912
3913 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3914
3915 * window.h (window): Add some new members to window structure -
3916 normal_lines, normal_cols, new_total, new_normal, clone_number,
3917 splits, nest, prev_buffers, next_buffers.
3918 (WINDOW_TOTAL_SIZE): Move here from window.c.
3919 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3920
3921 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3922 Remove.
3923 (make_dummy_parent): Set new members of windows structure.
3924 (make_window): Move down in code. Handle new members of window
3925 structure.
3926 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3927 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3928 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3929 (Fset_window_prev_buffers, Fwindow_next_buffers)
3930 (Fset_window_next_buffers, Fset_window_clone_number):
3931 New functions.
3932 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3933 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3934 Doc-string fixes.
3935 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3936 Argument WINDOW can be now internal window too.
3937 (Fwindow_use_time): Move up in code.
3938 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3939 Rewrite doc-string.
3940 (Fset_window_configuration, saved_window)
3941 (Fcurrent_window_configuration, save_window_save): Handle new
3942 members of window structure.
3943 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3944 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3945 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3946 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3947 Qget_mru_window, Qresize_root_window,
3948 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3949 Qauto_buffer_name; staticpro them.
3950
3951 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3952
3953 * window.c (Fwindow_total_size, Fwindow_left_column)
3954 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3955 (Fwindow_list_1): New functions.
3956 (window_box_text_cols): Replace with window_body_cols.
3957 (Fwindow_width, Fscroll_left, Fscroll_right):
3958 Use window_body_cols instead of window_box_text_cols.
3959 (delete_window, Fset_window_configuration):
3960 Call delete_all_subwindows with window as argument.
3961 (delete_all_subwindows): Take a window as argument and not a
3962 structure. Rewrite.
3963 (window_loop): Remove handling of GET_LRU_WINDOW and
3964 GET_LARGEST_WINDOW.
3965 (Fget_lru_window, Fget_largest_window): Move to window.el.
3966
3967 * window.h: Extern window_body_cols instead of
3968 window_box_text_cols. delete_all_subwindows now takes a
3969 Lisp_Object as argument.
3970
3971 * indent.c (compute_motion, Fcompute_motion):
3972 Use window_body_cols instead of window_box_text_cols.
3973
3974 * frame.c (delete_frame): Call delete_all_subwindows with root
3975 window as argument.
3976
3977 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3978
3979 * fns.c (Fputhash): Document return value.
3980
3981 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3982
3983 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3984
3985 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 Cons<->int and similar integer overflow fixes (Bug#8794).
3988
3989 Check for overflow when converting integer to cons and back.
3990 * charset.c (Fdefine_charset_internal, Fdecode_char):
3991 Use cons_to_unsigned to catch overflow.
3992 (Fencode_char): Use INTEGER_TO_CONS.
3993 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3994 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3995 * data.c (long_to_cons, cons_to_long): Remove.
3996 (cons_to_unsigned, cons_to_signed): New functions.
3997 These signal an error for invalid or out-of-range values.
3998 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3999 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4000 * font.c (Ffont_variation_glyphs):
4001 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4002 * lisp.h: Include <intprops.h>.
4003 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4004 (cons_to_signed, cons_to_unsigned): New decls.
4005 (long_to_cons, cons_to_long): Remove decls.
4006 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4007 (Fprimitive_undo): Use CONS_TO_INTEGER.
4008 * xfns.c (Fx_window_property): Likewise.
4009 * xselect.c: Include <limits.h>.
4010 (x_own_selection, selection_data_to_lisp_data):
4011 Use INTEGER_TO_CONS.
4012 (x_handle_selection_request, x_handle_selection_clear)
4013 (x_get_foreign_selection, Fx_disown_selection_internal)
4014 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4015 (lisp_data_to_selection_data): Use cons_to_unsigned.
4016 (x_fill_property_data): Use cons_to_signed.
4017 Report values out of range.
4018
4019 Check for buffer and string overflow more precisely.
4020 * buffer.h (BUF_BYTES_MAX): New macro.
4021 * lisp.h (STRING_BYTES_MAX): New macro.
4022 * alloc.c (Fmake_string):
4023 * character.c (string_escape_byte8):
4024 * coding.c (coding_alloc_by_realloc):
4025 * doprnt.c (doprnt):
4026 * editfns.c (Fformat):
4027 * eval.c (verror):
4028 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4029 since they may not be the same number.
4030 * editfns.c (Finsert_char):
4031 * fileio.c (Finsert_file_contents):
4032 Likewise for BUF_BYTES_MAX.
4033
4034 * image.c: Use ptrdiff_t, not int, for sizes.
4035 (slurp_file): Switch from int to ptrdiff_t.
4036 All uses changed.
4037 (slurp_file): Check that file size fits in both size_t (for
4038 malloc) and ptrdiff_t (for sanity and safety).
4039
4040 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4041 if b->modtime has its maximal value.
4042
4043 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4044
4045 Don't assume time_t can fit into int.
4046 * buffer.h (struct buffer.modtime): Now time_t, not int.
4047 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4048 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4049
4050 Minor fixes for signed vs unsigned integers.
4051 * character.h (MAYBE_UNIFY_CHAR):
4052 * charset.c (maybe_unify_char):
4053 * keyboard.c (read_char, reorder_modifiers):
4054 XINT -> XFASTINT, since the integer must be nonnegative.
4055 * ftfont.c (ftfont_spec_pattern):
4056 * keymap.c (access_keymap, silly_event_symbol_error):
4057 XUINT -> XFASTINT, since the integer must be nonnegative.
4058 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4059 since it makes no difference and we prefer signed.
4060 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4061 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4062 nonnegative.
4063
4064 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4065
4066 * window.h (Fwindow_frame): Declare.
4067
4068 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4069
4070 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4071 (SPARE_MEMORY): Always define.
4072 (LARGE_REQUEST): Remove.
4073 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4074
4075 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4076
4077 * lisp.h: Move EXFUNS for Fframe_root_window,
4078 Fframe_first_window and Fset_frame_selected_window to window.h.
4079
4080 * window.h: Move EXFUNS for Fframe_root_window,
4081 Fframe_first_window and Fset_frame_selected_window here from
4082 lisp.h.
4083
4084 * frame.c (Fwindow_frame, Fframe_first_window)
4085 (Fframe_root_window, Fframe_selected_window)
4086 (Fset_frame_selected_window): Move to window.c.
4087 (Factive_minibuffer_window): Move to minibuf.c.
4088 (Fother_visible_frames_p): New function.
4089
4090 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4091
4092 * window.c (decode_window, decode_any_window): Move up in code.
4093 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4094 (inhibit_frame_unsplittable): Remove unused variable.
4095 (Fwindow_buffer): Move up and rewrite doc-string.
4096 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4097 (Fwindow_prev): New functions.
4098 (Fwindow_frame): Move here from frame.c. Accept any window as
4099 argument.
4100 (Fframe_root_window, Fframe_first_window)
4101 (Fframe_selected_window): Move here from frame.c. Accept frame
4102 or arbitrary window as argument. Update doc-strings.
4103 (Fminibuffer_window): Move up in code.
4104 (Fwindow_minibuffer_p): Move up in code and simplify.
4105 (Fset_frame_selected_window): Move here from frame.c.
4106 Marginal rewrite.
4107 (Fselected_window, select_window, Fselect_window): Move up in
4108 code. Minor doc-string fixes.
4109
4110 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4113 Do not assume that spare memory exists; that assumption is valid
4114 only if SYSTEM_MALLOC.
4115 (LARGE_REQUEST): New macro, so that the issue of large requests
4116 is separated from the issue of spare memory.
4117
4118 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4119
4120 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4121 format. (Bug#8806)
4122
4123 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4124
4125 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4126 before statements.
4127
4128 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4129
4130 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4131
4132 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4133
4134 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4135 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4136
4137 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4140
4141 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4142
4143 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4144 (x_clipboard_manager_save): Add return value.
4145 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4146 New error handlers.
4147 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4148 Obey Vx_select_enable_clipboard_manager. Catch errors in
4149 x_clipboard_manager_save (Bug#8779).
4150 (Vx_select_enable_clipboard_manager): New variable.
4151 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4152
4153 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4154
4155 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4156
4157 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4158
4159 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4160 in the current matrix if keep_current_p is non-zero.
4161
4162 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4163
4164 * bidi.c (bidi_level_of_next_char): Fix last change.
4165
4166 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4167
4168 Support bidi reordering of text covered by display properties.
4169
4170 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4171 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4172 (bidi_cache_search, bidi_cache_iterator_state)
4173 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4174 (bidi_level_of_next_char, bidi_move_to_visually_next):
4175 Support character positions inside a run of characters covered by a
4176 display string.
4177 (bidi_paragraph_init, bidi_resolve_explicit_1)
4178 (bidi_level_of_next_char): Call bidi_fetch_char and
4179 bidi_fetch_char_advance instead of FETCH_CHAR and
4180 FETCH_CHAR_ADVANCE.
4181 (bidi_init_it): Initialize new members.
4182 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4183 definitions.
4184 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4185 instead of using explicit *_CHAR codes.
4186 (bidi_resolve_explicit, bidi_resolve_weak):
4187 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4188 bidirectional text is supported only in multibyte buffers.
4189 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4190 it to initialize the frame_window_p member of struct bidi_it.
4191 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4192 (bidi_resolve_explicit, bidi_resolve_weak)
4193 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4194 bidi_it->nchars is non-positive.
4195 (bidi_level_of_next_char): Don't try to lookup the cache for the
4196 next/previous character if nothing is cached there yet, or if we
4197 were just reseat()'ed to a new position.
4198
4199 * xdisp.c (set_cursor_from_row): Set start and stop points
4200 according to the row's direction when priming the loop that looks
4201 for the glyph on which to display cursor.
4202 (single_display_spec_intangible_p): Function deleted.
4203 (display_prop_intangible_p): Reimplement to call
4204 handle_display_spec instead of single_display_spec_intangible_p.
4205 Accept 3 additional arguments needed by handle_display_spec.
4206 This fixes incorrect cursor motion across display property with complex
4207 values: lists, `(when COND...)' forms, etc.
4208 (single_display_spec_string_p): Support property values that are
4209 lists with the argument STRING its top-level element.
4210 (display_prop_string_p): Fix the condition for processing a
4211 property that is a list to be consistent with handle_display_spec.
4212 (handle_display_spec): New function, refactored from the
4213 last portion of handle_display_prop.
4214 (compute_display_string_pos): Accept additional argument
4215 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4216 value of a `display' property is a "replacing spec".
4217 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4218 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4219 the display property, but just return a value indicating whether
4220 the display property will replace the characters it covers.
4221 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4222 frame_window_p members of struct bidi_it.
4223 (compute_display_string_pos, compute_display_string_end):
4224 New functions.
4225 (push_it): Accept second argument POSITION, where pop_it should
4226 jump to continue iteration.
4227 (reseat_1): Initialize bidi_it.disp_pos.
4228
4229 * keyboard.c (adjust_point_for_property): Adjust the call to
4230 display_prop_intangible_p to its new signature.
4231
4232 * dispextern.h (struct bidi_it): New member frame_window_p.
4233 (bidi_init_it): Update prototypes.
4234 (display_prop_intangible_p): Update prototype.
4235 (compute_display_string_pos, compute_display_string_end):
4236 Declare prototypes.
4237 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4238 EMACS_INT.
4239
4240 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 Malloc failure behavior now depends on size of allocation.
4243 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4244 * lisp.h: Change signatures accordingly.
4245 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4246 All callers changed. (Bug#8762)
4247
4248 * gnutls.c: Use Emacs's memory allocators.
4249 Without this change, the gnutls library would invoke malloc etc.
4250 directly, which causes problems on non-SYNC_INPUT hosts, and which
4251 runs afoul of improving memory_full behavior. (Bug#8761)
4252 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4253 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4254 xfree instead of the default malloc, realloc, free.
4255 (Fgnutls_boot): No need to check for memory allocation failure,
4256 since xmalloc does that for us.
4257
4258 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4259 * category.c (hash_get_category_set):
4260 * ccl.c (ccl_driver):
4261 * charset.c (Fdefine_charset_internal):
4262 * charset.h (struct charset.hash_index):
4263 * composite.c (get_composition_id, gstring_lookup_cache)
4264 (composition_gstring_put_cache):
4265 * composite.h (struct composition.hash_index):
4266 * dispextern.h (struct image.hash):
4267 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4268 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4269 (hashfn_equal, hashfn_user_defined, make_hash_table)
4270 (maybe_resize_hash_table, hash_lookup, hash_put)
4271 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4272 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4273 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4274 * image.c (make_image, search_image_cache, lookup_image)
4275 (xpm_put_color_table_h):
4276 * lisp.h (struct Lisp_Hash_Table):
4277 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4278 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4279 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4280 * alloc.c (allocate_vectorlike):
4281 Check for overflow in vector size calculations.
4282 * ccl.c (ccl_driver):
4283 Check for overflow when converting EMACS_INT to int.
4284 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4285 need to be updated by these changes.
4286 * fns.c (make_hash_table, maybe_resize_hash_table):
4287 Check for integer overflow with large hash tables.
4288 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4289 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4290 (SXHASH_REDUCE): New macro.
4291 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4292 Use it instead of discarding useful hash info with large hash values.
4293 (sxhash_float): New function.
4294 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4295 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4296 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4297 Rewrite to use FIXNUM_BITS, as this simplifies things.
4298 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4299 Adjust signatures to match updated version of code.
4300 (consing_since_gc): Now EMACS_INT, since a single hash table can
4301 use more than INT_MAX bytes.
4302
4303 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4304
4305 Make it possible to build with GCC-4.6+ -O2 -flto.
4306
4307 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4308
4309 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4312 Call minibuffer-inactive-mode.
4313
4314 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4315
4316 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4317 Update dependencies.
4318
4319 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4320
4321 * data.c (init_data): Remove code for UTS, this system is not
4322 supported anymore.
4323
4324 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4325
4326 Don't force ./temacs to start in terminal mode.
4327
4328 * frame.c (make_initial_frame): Initialize faces in all cases, not
4329 only when CANNOT_DUMP is defined.
4330 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4331
4332 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4333
4334 * dispnew.c (add_window_display_history): Use const for the string
4335 pointer. Remove declaration, not needed.
4336
4337 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Use 'inline', not 'INLINE'.
4340 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4341 * alloc.c, fontset.c (INLINE): Remove.
4342 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4343 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4344 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4345 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4346 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4347
4348 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4349
4350 Make it possible to run ./temacs.
4351
4352 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4353 syms_of_callproc does the same thing. Remove test for
4354 "initialized", do it in the caller.
4355 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4356
4357 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4358
4359 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4360 (read_minibuf): Use get_minibuffer.
4361 (syms_of_minibuf): Use DEFSYM.
4362 (Qmetadata): New var.
4363 * data.c (Qbuffer): Don't make it static.
4364 (syms_of_data): Use DEFSYM.
4365
4366 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4367
4368 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4369 (CCL_CODE_MIN): New macro.
4370
4371 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4372
4373 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4374
4375 * eval.c (Qdebug): Now static.
4376 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4377 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4378 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4379
4380 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * image.c: Various fixes to ImageMagick code comments.
4383 (Fimagemagick_types): Doc fix.
4384
4385 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Minor fixes prompted by GCC 4.6.0 warnings.
4388
4389 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4390
4391 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4392 (x_clipboard_manager_save_all): Move extern decl to ...
4393 * xterm.h: ... here, so that it can be checked for consistency.
4394
4395 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4396
4397 * xselect.c (x_clipboard_manager_save_frame)
4398 (x_clipboard_manager_save_all): New functions.
4399 (Fx_clipboard_manager_save): Lisp function deleted.
4400
4401 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4402 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4403
4404 * xterm.h: Update prototype.
4405
4406 2011-05-28 William Xu <william.xwl@gmail.com>
4407
4408 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4409 exiting (Bug#8239).
4410
4411 2011-05-28 Jim Meyering <meyering@redhat.com>
4412
4413 Avoid a sign-extension bug in crypto_hash_function.
4414 * fns.c (to_uchar): Define.
4415 (crypto_hash_function): Use it to convert some newly-signed
4416 variables to unsigned, to avoid sign-extension bugs. For example,
4417 without this change, (md5 "truc") would evaluate to
4418 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4419 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4420 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4421
4422 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 Integer overflow fixes.
4425
4426 * dbusbind.c: Serial number integer overflow fixes.
4427 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4428 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4429 to hold a serial number that is too large for a fixnum.
4430 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4431 Check for serial numbers out of range. Decode any serial number
4432 that was so large that it became a float. (Bug#8722)
4433
4434 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4435 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4436 Use XFASTINT rather than XUINT when numbers are nonnegative.
4437 (xd_append_arg, Fdbus_method_return_internal):
4438 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4439 arguments, check that Lisp number is nonnegative, rather than
4440 silently wrapping negative numbers around. (Bug#8722)
4441 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4442 (Bug#8722)
4443
4444 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4445
4446 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4447
4448 ccl: add integer overflow checks
4449 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4450 (IN_INT_RANGE): New macros.
4451 (ccl_driver): Use them to check for integer overflow when
4452 decoding a CCL program. Many of the new checks are whether XINT (x)
4453 fits in int; it doesn't always, on 64-bit hosts. The new version
4454 doesn't catch all possible integer overflows, but it's an
4455 improvement. (Bug#8719)
4456
4457 * alloc.c (make_event_array): Use XINT, not XUINT.
4458 There's no need for unsigned here.
4459
4460 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4461 This follows up to the 2011-05-06 change that substituted uintptr_t
4462 for EMACS_INT. This case wasn't caught back then.
4463
4464 Rework Fformat to avoid integer overflow issues.
4465 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4466 now (part of C89). Include <verify.h>.
4467 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4468 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4469 (Fformat): Avoid the prepass trying to compute sizes; it was only
4470 approximate and thus did not catch overflow reliably. Instead, walk
4471 through the format just once, formatting and computing sizes as we go,
4472 checking for integer overflow at every step, and allocating a larger
4473 buffer as needed. Keep track separately whether the format is
4474 multibyte. Keep only the most-recently calculated precision, rather
4475 than them all. Record whether each argument has been converted to
4476 string. Use EMACS_INT, not int, for byte and char and arg counts.
4477 Support field widths and precisions larger than INT_MAX. Avoid
4478 sprintf's undefined behavior with conversion specifications such as %#d
4479 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4480 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4481 formatting out-of-range floating point numbers with int
4482 formats. (Bug#8668)
4483
4484 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4485
4486 * data.c: Avoid integer truncation in expressions involving floats.
4487 * data.c: Include <intprops.h>.
4488 (arith_driver): When there's an integer overflow in an expression
4489 involving floating point, convert the integers to floating point
4490 so that the resulting value does not suffer from catastrophic
4491 integer truncation. For example, on a 64-bit host (* 4
4492 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4493 Do not rely on undefined behavior after integer overflow.
4494
4495 merge count_size_as_multibyte, parse_str_to_multibyte
4496 * character.c, character.h (count_size_as_multibyte):
4497 Rename from parse_str_to_multibyte; all uses changed.
4498 Check for integer overflow.
4499 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4500 since it's now a duplicate of the other. This is more of
4501 a character than a buffer op, so better that it's in character.c.
4502 * fns.c, print.c: Adjust to above changes.
4503
4504 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4505
4506 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4507
4508 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4511 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4512 (x_clipboard_manager_save): Now static.
4513 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4514
4515 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4516 (crypto_hash_function): Now static.
4517 Fix pointer signedness problems. Avoid unnecessary initializations.
4518
4519 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4520
4521 * termhooks.h (Vselection_alist): Make it terminal-local.
4522
4523 * terminal.c (create_terminal): Initialize it.
4524
4525 * xselect.c: Support for clipboard managers.
4526 (Vselection_alist): Move to termhooks.h as terminal-local var.
4527 (LOCAL_SELECTION): New macro.
4528 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4529 (symbol_to_x_atom): Remove gratuitous arg.
4530 (x_handle_selection_request, lisp_data_to_selection_data)
4531 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4532 (x_own_selection, x_get_local_selection, x_convert_selection):
4533 New arg, specifying work frame. Use terminal-local Vselection_alist.
4534 (some_frame_on_display): Delete unused function.
4535 (Fx_own_selection_internal, Fx_get_selection_internal)
4536 (Fx_disown_selection_internal, Fx_selection_owner_p)
4537 (Fx_selection_exists_p): New optional frame arg.
4538 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4539 (x_handle_selection_clear): Don't treat other terminals with the
4540 same keyboard specially. Use the terminal-local Vselection_alist.
4541 (x_clear_frame_selections): Use Frun_hook_with_args.
4542
4543 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4544
4545 * xterm.h: Add support for those atoms.
4546
4547 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4548
4549 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4550 (converted_selections, conversion_fail_tag): New global variables.
4551 (x_selection_request_lisp_error): Free the above.
4552 (x_get_local_selection): Remove unnecessary code.
4553 (x_reply_selection_request): Args changed; handle arbitrary array
4554 of converted selections stored in converted_selections.
4555 Separate the XChangeProperty and SelectionNotify steps.
4556 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4557 (x_convert_selection): New function.
4558 (x_handle_selection_event): Simplify.
4559 (x_get_foreign_selection): Don't ignore incoming requests while
4560 waiting for an answer; this will fail when we implement
4561 SAVE_TARGETS, and seems unnecessary anyway.
4562 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4563 (Vx_sent_selection_functions): Doc fix.
4564
4565 2011-05-26 Leo Liu <sdl.web@gmail.com>
4566
4567 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4568
4569 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4570
4571 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4572
4573 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4574 for fringe update if it has periodic bitmap.
4575 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4576 and fringe_bitmap_periodic_p.
4577
4578 * fringe.c (get_fringe_bitmap_data): New function.
4579 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4580 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4581 row. Mark glyph row for fringe update if periodicity changed.
4582
4583 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4584 for fringe update unless it has periodic bitmap.
4585
4586 2011-05-25 Kenichi Handa <handa@m17n.org>
4587
4588 * xdisp.c (get_next_display_element): Set correct it->face_id for
4589 a static composition.
4590
4591 2011-05-24 Leo Liu <sdl.web@gmail.com>
4592
4593 * deps.mk (fns.o):
4594 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4595
4596 * fns.c (crypto_hash_function, Fsha1): New function.
4597 (Fmd5): Use crypto_hash_function.
4598 (syms_of_fns): Add Ssha1.
4599
4600 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 * gnutls.c: Remove unused macros.
4603 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4604 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4605 Remove macros that are defined and never used.
4606 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4607
4608 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4609
4610 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4611 (Fx_get_selection_internal): Minor cleanup.
4612 (Fx_own_selection_internal): Rename arguments for consistency with
4613 select.el.
4614
4615 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4616
4617 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4618
4619 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4620
4621 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4622
4623 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4624
4625 * dispnew.c (scrolling_window): Don't exclude the case that the
4626 last enabled row in the desired matrix touches the bottom boundary.
4627
4628 2011-05-21 Glenn Morris <rgm@gnu.org>
4629
4630 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4631 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4632 and add some more files.
4633
4634 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4635
4636 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4637 report_file_error introduced by the change from 2011-05-07.
4638
4639 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4640
4641 * systime.h (Time): Define only if emacs is defined.
4642 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4643 where the include path doesn't have X11/X.h by default. See
4644 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4645
4646 2011-05-20 Kenichi Handa <handa@m17n.org>
4647
4648 * composite.c (find_automatic_composition): Fix previous change.
4649
4650 2011-05-20 Glenn Morris <rgm@gnu.org>
4651
4652 * lisp.mk: New file, split from Makefile.in.
4653 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4654 (shortlisp): Remove.
4655 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4656
4657 2011-05-19 Glenn Morris <rgm@gnu.org>
4658
4659 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4660 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4661 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4662 (lisp): Set the order to that of loadup.el.
4663 (shortlisp): Make it a copy of $lisp.
4664 (SOME_MACHINE_LISP): Remove.
4665 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4666 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4667
4668 2011-05-18 Kenichi Handa <handa@m17n.org>
4669
4670 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4671 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4672 (find_automatic_composition): Mostly rewrite for efficiency.
4673
4674 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4675
4676 * makefile.w32-in: Update dependencies.
4677
4678 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4679
4680 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4681 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4682
4683 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 Fix some integer overflow issues, such as string length overflow.
4686
4687 * insdel.c (count_size_as_multibyte): Check for string overflow.
4688
4689 * character.c (lisp_string_width): Check for string overflow.
4690 Use EMACS_INT, not int, for string indexes and lengths; in
4691 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4692 the resulting string length overflows an EMACS_INT; instead,
4693 report a string overflow if no precision given. When checking for
4694 precision exhaustion, use a check that cannot possibly have
4695 integer overflow. (Bug#8675)
4696 * character.h (lisp_string_width): Adjust to new signature.
4697
4698 * alloc.c (string_overflow): New function.
4699 (Fmake_string): Use it. This doesn't change behavior, but saves
4700 a few bytes and will simplify future changes.
4701 * character.c (string_escape_byte8): Likewise.
4702 * lisp.h (string_overflow): New decl.
4703
4704 Fixups, following up to the user-interface timestamp change.
4705 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4706 for UI timestamps, instead of unsigned long.
4707 * msdos.c (mouse_get_pos): Likewise.
4708 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4709 * w32gui.h (Time): Define by including "systime.h" rather than by
4710 declaring it ourselves. (Bug#8664)
4711
4712 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4713 * image.c (clear_image_cache): Likewise.
4714
4715 * term.c (term_mouse_position): Don't assume time_t wraparound.
4716
4717 Be more systematic about user-interface timestamps.
4718 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4719 and sometimes 'EMACS_UINT', to represent these timestamps.
4720 This change causes it to use 'Time' uniformly, as that's what X uses.
4721 This makes the code easier to follow, and makes it easier to catch
4722 integer overflow bugs such as Bug#8664.
4723 * frame.c (Fmouse_position, Fmouse_pixel_position):
4724 Use Time, not unsigned long, for user-interface timestamps.
4725 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4726 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4727 * keyboard.h (last_event_timestamp): Likewise.
4728 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4729 * menu.h (xmenu_show): Likewise.
4730 * term.c (term_mouse_position): Likewise.
4731 * termhooks.h (struct input_event.timestamp): Likewise.
4732 (struct terminal.mouse_position_hook): Likewise.
4733 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4734 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4735 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4736 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4737 what it was before.
4738 * menu.h, termhooks.h: Include "systime.h", for Time.
4739
4740 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4741 Don't assume that the difference between two unsigned long values
4742 can fit into an integer. At this point, we know button_down_time
4743 <= event->timestamp, so the difference must be nonnegative, so
4744 there's no need to cast the result if double-click-time is
4745 nonnegative, as it should be; check that it's nonnegative, just in
4746 case. This bug is triggered when events are more than 2**31 ms
4747 apart (about 25 days). (Bug#8664)
4748
4749 * xselect.c (last_event_timestamp): Remove duplicate decl.
4750 (x_own_selection): Remove needless cast to unsigned long.
4751
4752 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4753 that always fit in int. Use a sentinel instead of a counter, to
4754 avoid a temp and to allay GCC's concerns about possible int overflow.
4755 * frame.h (struct frame): Use int for menu_bar_items_used
4756 instead of EMACS_INT, since it always fits in int.
4757
4758 * menu.c (grow_menu_items): Check for int overflow.
4759
4760 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4761
4762 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4763 Before, the code was not consistent. These values cannot exceed
4764 2**31 - 1 so there's no need to make them unsigned.
4765 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4766 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4767 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4768 as modifiers.
4769 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4770
4771 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4772 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4773 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4774 presumably because the widths might not match.
4775
4776 * window.c (size_window): Avoid needless test at loop start.
4777
4778 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4779
4780 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4781
4782 2011-05-12 Drew Adams <drew.adams@oracle.com>
4783
4784 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4785
4786 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4787
4788 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4789 `width' to `bar_area_x' and `bar_area_width', respectively.
4790 (x_scroll_run): Take account of fringe background extension.
4791
4792 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4793 Rename local vars `left' and `width' to `bar_area_x' and
4794 `bar_area_width', respectively.
4795 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4796 background extension.
4797
4798 2011-05-10 Jim Meyering <meyering@redhat.com>
4799
4800 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4801
4802 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4803
4804 * image.c (Finit_image_library): Return t for built-in image types,
4805 like pbm and xbm. (Bug#8640)
4806
4807 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4808
4809 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4810
4811 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4812
4813 * w32console.c (Fset_screen_color): Doc fix.
4814 (Fget_screen_color): New function.
4815 (syms_of_ntterm): Defsubr it.
4816
4817 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4818 unlink the temporary file if Fcall_process didn't create it in the
4819 first place.
4820 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4821 child process will be redirected to a file specified with `:file'.
4822 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4823 cue to call_process_cleanup not to close that handle.
4824
4825 2011-05-07 Ben Key <bkey76@gmail.com>
4826
4827 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4828 one of two shell specific rules, either bootstrap-temacs-CMD or
4829 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4830 to the previous implementation of the bootstrap-temacs rule.
4831 The bootstrap-temacs-CMD rule is similar to the previous
4832 implementation of the bootstrap-temacs rule except that it
4833 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4834 variable.
4835
4836 These changes, along with some changes to nt/configure.bat,
4837 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4838 earlier fix to add support for --cflags and --ldflags options
4839 that include quotes so that it works whether make uses cmd or
4840 sh as the shell.
4841
4842 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4843
4844 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4845 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4846 is a constant.
4847 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4848 a string. Handle both cases.
4849 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4850 (Fdbus_register_method): Use Qinvalid_function.
4851
4852 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4853
4854 * makefile.w32-in: Update dependencies.
4855 (LISP_H): Add inttypes.h and stdin.h.
4856 (PROCESS_H): Add unistd.h.
4857
4858 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4859
4860 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4861 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4862
4863 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4864
4865 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4866
4867 * term.c (vfatal): Remove stray call to va_end.
4868 It's not needed and the C Standard doesn't allow it here anyway.
4869
4870 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4871 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4872
4873 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4874 bytes.
4875
4876 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4877
4878 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4879
4880 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4881
4882 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4883
4884 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4885
4886 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4887 * charset.c (Fdefine_charset_internal): Don't initialize
4888 charset.code_space[15]. The value was garbage, on hosts with
4889 32-bit int (Bug#8600).
4890
4891 * lread.c (read_integer): Be more consistent with string-to-number.
4892 Use string_to_number to do the actual conversion; this avoids
4893 rounding errors and fixes some other screwups. Without this fix,
4894 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4895 (digit_to_number): Move earlier, for benefit of read_integer.
4896 Return -1 if the digit is out of range for the base, -2 if it is
4897 not a digit in any supported base. (Bug#8602)
4898
4899 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4900
4901 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4902 to match comment at start of function. This also removes a
4903 GCC warning about overflow in a 32+64-bit port.
4904
4905 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4906
4907 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4908 Reported by Stefan Monnier in
4909 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4910 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4911 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4912
4913 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4914 (EMACS_UINTPTR): Likewise, with uintptr_t.
4915
4916 * lisp.h: Prefer 64-bit EMACS_INT if available.
4917 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4918 on 32-bit hosts that have 64-bit int, so that they can access
4919 large files.
4920 However, temporarily disable this change unless the temporary
4921 symbol WIDE_EMACS_INT is defined.
4922
4923 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4924
4925 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4926 This removes an assumption that EMACS_INT and long are the same
4927 width as pointers. The assumption is true for Emacs porting targets
4928 now, but we want to make other targets possible.
4929 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4930 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4931 In the rest of the code, change types of integers that hold casted
4932 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4933 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4934 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4935 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4936 No need to cast type when ORing.
4937 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4938 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4939 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4940 assume EMACS_INT is the same width as char *.
4941 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4942 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4943 Remove no-longer-needed casts.
4944 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4945 (xg_tool_bar_help_callback, xg_make_tool_item):
4946 Use EMACS_INTPTR to hold an integer
4947 that will be cast to void *; this can avoid a GCC warning
4948 if EMACS_INT is not the same width as void *.
4949 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4950 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4951 (current_message_1, set_message_1):
4952 Use a local to convert to proper width without a cast.
4953 * xmenu.c (dialog_selection_callback): Likewise.
4954
4955 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4956 Also, don't assume VALBITS / RAND_BITS is less than 5,
4957 and don't rely on undefined behavior when shifting a 1 left into
4958 the sign bit.
4959 * lisp.h (get_random): Change signature to match.
4960
4961 * lread.c (hash_string): Use size_t, not int, for hash computation.
4962 Normally we prefer signed values; but hashing is special, because
4963 it's better to use unsigned division on hash table sizes so that
4964 the remainder is nonnegative. Also, size_t is the natural width
4965 for hashing into memory. The previous code used 'int', which doesn't
4966 retain enough info to hash well into very large tables.
4967 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4968
4969 * dbusbind.c: Don't possibly lose pointer info when converting.
4970 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4971 Use XPNTR rather than XHASH, so that the high-order bits of
4972 the pointer aren't lost when converting through void *.
4973
4974 * eval.c (Fautoload): Don't double-shift a pointer.
4975
4976 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4977
4978 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4979
4980 * gnutls.c (DEF_GNUTLS_FN):
4981 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4982
4983 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4984
4985 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4986 marker. (Bug#8610)
4987
4988 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4989
4990 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4991 New version that can reserve upto 2GB of heap space.
4992
4993 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4994
4995 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4996
4997 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4998
4999 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5000 `gnutls_certificate_set_x509_key_file'.
5001
5002 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5003
5004 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5005 Update dependencies.
5006
5007 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5008
5009 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5010 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5011 Remove unused parameter `fildes'.
5012 * process.c (read_process_output, send_process): Don't pass it.
5013
5014 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5015
5016 Fix previous change: the library cache is defined in w32.c.
5017 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5018 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5019
5020 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5021
5022 Implement dynamic loading of GnuTLS on Windows.
5023
5024 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5025 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5026 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5027 Declare.
5028
5029 * gnutls.c (Qgnutls_dll): Define.
5030 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5031 (gnutls_*): Declare function pointers.
5032 (init_gnutls_functions): New function to initialize function pointers.
5033 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5034 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5035 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5036 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5037 (emacs_gnutls_write, emacs_gnutls_read)
5038 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5039 (Fgnutls_available_p): New function.
5040 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5041 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5042 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5043
5044 * image.c: Include w32.h.
5045 (Vimage_type_cache): Delete.
5046 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5047 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5048 (w32_delayed_load): Move to w32.c.
5049
5050 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5051
5052 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5053 (w32_delayed_load): Move from image.c. When loading a library, record
5054 its filename in the :loaded-from property of the library id.
5055 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5056 Initialize and staticpro them.
5057 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5058
5059 * process.c: Include lisp.h before w32.h, not after.
5060 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5061 instead of gnutls_record_check_pending.
5062
5063 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5064
5065 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5066
5067 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5068 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5069 as passed in.
5070
5071 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5072
5073 * xterm.c (x_set_frame_alpha): Do not set property on anything
5074 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5075
5076 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5077
5078 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5079
5080 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5083 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5084 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5085 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5086 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5087 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5088 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5089 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5090 (Qgnutls_bootprop_callbacks_verify): Make static.
5091
5092 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5093
5094 * callproc.c: Indentation fixup.
5095
5096 * sysdep.c (wait_for_termination_1): Make static.
5097 (wait_for_termination, interruptible_wait_for_termination):
5098 Move after wait_for_termination_1.
5099
5100 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5101
5102 * sysdep.c (interruptible_wait_for_termination): New function
5103 which is like wait_for_termination, but allows keyboard
5104 interruptions.
5105
5106 * callproc.c (Fcall_process): Add (:file "file") as an option for
5107 the STDOUT buffer.
5108 (Fcall_process_region): Ditto.
5109
5110 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5111
5112 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5113 rather than `XVECTOR (FOO)->size'.
5114
5115 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5116 inttypes.h, as a gnulib replacement is used if it not available in
5117 system headers.
5118
5119 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5120
5121 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5122 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5123 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5124
5125 * coding.c (coding_alloc_by_realloc): Error out if destination
5126 will grow beyond MOST_POSITIVE_FIXNUM.
5127 (decode_coding_emacs_mule): Abort if there isn't enough place in
5128 charbuf for the composition carryover bytes. Reserve an extra
5129 space for up to 2 characters produced in a loop.
5130 (decode_coding_iso_2022): Abort if there isn't enough place in
5131 charbuf for the composition carryover bytes.
5132
5133 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5134
5135 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5136 aborting when %lld or %lll format is passed.
5137 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5138 %llo or %llx format is passed. (Bug#8545)
5139
5140 * window.c (window_scroll_line_based): Use a marker instead of
5141 simple variables to record original value of point. (Bug#7952)
5142
5143 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5144 produced by %s or %c overflows available buffer space. (Bug#8545)
5145
5146 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5149 (SIZE_MAX): Move defn after all includes, as they might #define it.
5150
5151 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5154
5155 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5156
5157 * keyboard.c (Qdelayed_warnings_hook): Define.
5158 (command_loop_1): Run `delayed-warnings-hook'
5159 if Vdelayed_warnings_list is non-nil.
5160 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5161 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5162
5163 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5164
5165 * doprnt.c (doprnt): Don't return value smaller than the buffer
5166 size if the message was truncated. (Bug#8545).
5167
5168 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5171 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5172
5173 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5174
5175 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5176
5177 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5178
5179 * makefile.w32-in: Update dependencies.
5180
5181 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5182
5183 Improve `doprnt' and its usage. (Bug#8545)
5184 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5185 `format_end'. Remove support for %l as a conversion specifier.
5186 Don't use xrealloc. Improve diagnostics when the %l size modifier
5187 is used. Update the commentary.
5188
5189 * eval.c (verror): Simplify calculation of size_t.
5190
5191 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5192 messages.
5193
5194 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5195
5196 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5197 change.
5198
5199 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5202 This makes this file independent of the recent pseudovector change.
5203
5204 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5207
5208 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5209 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5210 Remove unused local.
5211 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5212
5213 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5214 GCC 4.6.0 optimizes based on type-based alias analysis.
5215 For example, if b is of type struct buffer * and v of type struct
5216 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5217 != &v->size, and therefore "v->size = 1; b->size = 2; return
5218 v->size;" must therefore return 1. This assumption is incorrect
5219 for Emacs, since it type-puns struct Lisp_Vector * with many other
5220 types. To fix this problem, this patch adds a new type struct
5221 vectorlike_header that documents the constraints on layout of vectors
5222 and pseudovectors, and helps optimizing compilers not get fooled
5223 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5224 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5225 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5226 the size member.
5227 (XSETPVECTYPE): Rewrite in terms of new macro.
5228 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5229 This is a bit clearer, and further avoids the possibility of
5230 undesirable aliasing.
5231 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5232 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5233 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5234 since Lisp_Subr is a special case (no "next" field).
5235 (ASIZE): Now uses header.size rather than size.
5236 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5237 to avoid the hassle of writing XVECTOR (foo)->header.size.
5238 (struct vectorlike_header): New type.
5239 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5240 object, to help avoid aliasing.
5241 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5242 (SUBRP): Likewise, since Lisp_Subr is a special case.
5243 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5244 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5245 (struct Lisp_Hash_Table): Combine first two members into a single
5246 struct vectorlike_header member. All uses of "size" and "next" members
5247 changed to be "header.size" and "header.next".
5248 * buffer.h (struct buffer): Likewise.
5249 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5250 * frame.h (struct frame): Likewise.
5251 * process.h (struct Lisp_Process): Likewise.
5252 * termhooks.h (struct terminal): Likewise.
5253 * window.c (struct save_window_data, struct saved_window): Likewise.
5254 * window.h (struct window): Likewise.
5255 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5256 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5257 * buffer.c (init_buffer_once): Likewise.
5258 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5259 special case.
5260 * process.c (Fformat_network_address): Use local var for size,
5261 for brevity.
5262
5263 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5264
5265 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5266 * data.c (atof): Remove decl; no longer used or needed.
5267 (digit_to_number): Move to lread.c.
5268 (Fstring_to_number): Use new string_to_number function, to be
5269 consistent with how the Lisp reader treats infinities and NaNs.
5270 Do not assume that floating-point numbers represent EMACS_INT
5271 without losing information; this is not true on most 64-bit hosts.
5272 Avoid double-rounding errors, by insisting on integers when
5273 parsing non-base-10 numbers, as the documentation specifies.
5274 * lisp.h (string_to_number): New decl, replacing ...
5275 (isfloat_string): Remove.
5276 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5277 (read1): Do not accept +. and -. as integers; this
5278 appears to have been a coding error. Similarly, do not accept
5279 strings like +-1e0 as floating point numbers. Do not report
5280 overflow for integer overflows unless the base is not 10 which
5281 means we have no simple and reliable way to continue.
5282 Break out the floating-point parsing into a new
5283 function string_to_number, so that Fstring_to_number parses
5284 floating point numbers consistently with the Lisp reader.
5285 (digit_to_number): Move here from data.c. Make it static inline.
5286 (E_CHAR, EXP_INT): Remove, replacing with ...
5287 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5288 (string_to_number): New function, replacing isfloat_string.
5289 This function checks for valid syntax and produces the resulting
5290 Lisp float number too. Rework it so that string-to-number
5291 no longer mishandles examples like "1.0e+". Use strtoumax,
5292 so that overflow for non-base-10 numbers is reported only when
5293 there's no portable and simple way to convert to floating point.
5294
5295 * textprop.c (set_text_properties_1): Rewrite for clarity,
5296 and to avoid GCC warning about integer overflow.
5297
5298 * intervals.h (struct interval): Use EMACS_INT for members
5299 where EMACS_UINT might cause problems. See
5300 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5301 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5302 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5303 All uses changed.
5304 (offset_intervals): Tell GCC not to worry about length overflow
5305 when negating a negative length.
5306
5307 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5308 (overrun_check_free): Likewise.
5309
5310 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5311 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5312 word size.
5313
5314 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5315 (gnutls_make_error): Rename local to avoid shadowing.
5316 (gnutls_emacs_global_deinit): ifdef out; not used.
5317 (Fgnutls_boot): Use const for pointer to readonly storage.
5318 Comment out unused local. Fix pointer signedness problems.
5319
5320 * lread.c (openp): Don't stuff size_t into an 'int'.
5321 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5322 about possible signed overflow.
5323
5324 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5325 (GDK_KEY_g): Don't define if already defined.
5326 (xg_prepare_tooltip): Avoid pointer signedness problem.
5327 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5328
5329 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5330 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5331
5332 * xfns.c (Fx_window_property): Simplify a bit,
5333 to make a bit faster and to avoid GCC 4.6.0 warning.
5334 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5335
5336 * fns.c (internal_equal): Don't assume size_t fits in int.
5337
5338 * alloc.c (compact_small_strings): Tighten assertion a little.
5339
5340 Replace pEd with more-general pI, and fix some printf arg casts.
5341 * lisp.h (pI): New macro, generalizing old pEd macro to other
5342 conversion specifiers. For example, use "...%"pI"d..." rather
5343 than "...%"pEd"...".
5344 (pEd): Remove. All uses replaced with similar uses of pI.
5345 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5346 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5347 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5348 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5349 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5350 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5351 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5352 64-bit hosts.
5353 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5354 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5355 * print.c (safe_debug_print, print_object): Likewise.
5356 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5357 to int.
5358 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5359 avoiding the 0 flag, which is not portable.
5360 * process.c (Fmake_network_process): Use pI to avoid cast.
5361 * region-cache.c (pp_cache): Likewise.
5362 * xdisp.c (decode_mode_spec): Likewise.
5363 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5364 behavior on 64-bit hosts with printf arg.
5365 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5366 (x_stop_queuing_selection_requests): Likewise.
5367 (x_get_window_property): Don't truncate byte count to an 'int'
5368 when tracing.
5369
5370 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5371 here, since it parses constructs like leading '-' and spaces,
5372 which are not wanted; and it overflows with large numbers.
5373 Instead, simply match F[0-9]+, which is what is wanted anyway.
5374
5375 * alloc.c: Remove unportable assumptions about struct layout.
5376 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5377 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5378 (allocate_vectorlike, make_pure_vector): Use the new macros,
5379 plus offsetof, to remove unportable assumptions about struct layout.
5380 These assumptions hold on all porting targets that I know of, but
5381 they are not guaranteed, they're easy to remove, and removing them
5382 makes further changes easier.
5383
5384 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5385 This doesn't fix a bug but makes the code clearer.
5386 (string_overrun_cookie): Now const. Use initializers that
5387 don't formally overflow signed char, to avoid warnings.
5388 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5389 can cause Emacs to crash when string overrun checking is enabled.
5390 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5391 multiple of sizeof (EMACS_INT); it need not be, if
5392 alignof(EMACS_INT) < sizeof (EMACS_INT).
5393 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5394
5395 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5396
5397 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5398
5399 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5400
5401 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5402 supposed to be handshaking. (Bug#8556)
5403 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5404
5405 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5406
5407 * lisp.h (Qdebug): List symbol.
5408 * eval.c (Qdebug): Restore global linkage.
5409 * keyboard.c (debug-on-event): New variable.
5410 (handle_user_signal): Break into debugger when debug-on-event
5411 matches the current signal symbol.
5412
5413 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5414
5415 * alloc.c (check_sblock, check_string_bytes)
5416 (check_string_free_list): Convert to standard C.
5417
5418 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5419
5420 * w32.c (emacs_gnutls_push): Fix typo.
5421
5422 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5423
5424 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5425 "cast to pointer from integer of different size".
5426
5427 Improve doprnt and its use in verror. (Bug#8545)
5428 * doprnt.c (doprnt): Document the set of format control sequences
5429 supported by the function. Use SAFE_ALLOCA instead of always
5430 using `alloca'.
5431
5432 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5433 is one byte too soon. Don't use xrealloc; instead xfree and
5434 xmalloc anew.
5435
5436 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5437
5438 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5439 callbacks stage.
5440
5441 * gnutls.c: Renamed global_initialized to
5442 gnutls_global_initialized. Added internals for the
5443 :verify-hostname-error, :verify-error, and :verify-flags
5444 parameters of `gnutls-boot' and documented those parameters in the
5445 docstring. Start callback support.
5446 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5447 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5448 on error. Return error code.
5449 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5450 (emacs_gnutls_read): Likewise.
5451 (Fgnutls_boot): Return handshake error code.
5452 (emacs_gnutls_handle_error): New function.
5453 (wsaerror_to_errno): Likewise.
5454
5455 * w32.h (emacs_gnutls_pull): Add prototype.
5456 (emacs_gnutls_push): Likewise.
5457
5458 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5459 (emacs_gnutls_push): Likewise.
5460
5461 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5462
5463 * process.c (wait_reading_process_output): Check if GnuTLS
5464 buffered some data internally if no FDs are set for TLS
5465 connections.
5466
5467 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5468 (LIBS): Link to USER_LIBS.
5469 ($(BLD)/gnutls.$(0)): New target.
5470
5471 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5472
5473 * xdisp.c (handle_single_display_spec): Rename the
5474 display_replaced_before_p argument into display_replaced_p, to
5475 make it consistent with the commentary. Fix typos in the
5476 commentary.
5477
5478 * textprop.c (syms_of_textprop): Remove dead code.
5479 (copy_text_properties): Delete obsolete commentary about an
5480 interface that was deleted long ago. Fix typos in the description
5481 of arguments.
5482
5483 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5484 to changes in oldXMenu/XMenu.h from 2011-04-16.
5485 <menu_help_message, prev_menu_help_message>: Constify.
5486 (IT_menu_make_room): menu->help_text is now `const char **';
5487 adjust.
5488
5489 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5490 to changes in oldXMenu/XMenu.h from 2011-04-16.
5491 (struct XMenu): Declare `help_text' `const char **'.
5492
5493 * xfaces.c <Qunspecified>: Make extern again.
5494
5495 * syntax.c: Include sys/types.h before including regex.h, as
5496 required by Posix.
5497
5498 * doc.c (get_doc_string): Improve the format passed to `error'.
5499
5500 * doprnt.c (doprnt): Improve commentary.
5501
5502 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5503
5504 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5505 them with etags.
5506
5507 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5508 changes in globals.h immediately force recompilation.
5509 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5510 $(CURDIR)/s/ms-w32.h.
5511 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5512
5513 * character.c (Fchar_direction): Function deleted.
5514 (syms_of_character): Don't defsubr it.
5515 <char-direction-table>: Deleted.
5516
5517 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5518
5519 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5520 * doprnt.c: Include limits.h.
5521 (SIZE_MAX): New macro.
5522 (doprnt): Return a size_t value. 2nd arg is now size_t.
5523 Many local variables are now size_t instead of int or unsigned.
5524 Improve overflow protection. Support `l' modifier for integer
5525 conversions. Support %l conversion. Don't assume an EMACS_INT
5526 argument for integer conversions and for %c.
5527
5528 * lisp.h (doprnt): Restore prototype.
5529
5530 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5531 $(SRC)/character.h.
5532
5533 * Makefile.in (base_obj): Add back doprnt.o.
5534
5535 * deps.mk (doprnt.o): Add back prerequisites.
5536 (callint.o): Depend on character.h.
5537
5538 * eval.c (internal_lisp_condition_case): Include the handler
5539 representation in the error message.
5540 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5541 when breaking from the loop.
5542
5543 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5544
5545 * callint.c (Fcall_interactively): When displaying error message
5546 about invalid control letter, pass the character's codepoint, not
5547 a pointer to its multibyte form. Improve display of the character
5548 in octal and display also its hex code.
5549
5550 * character.c (char_string): Use %x to display the (unsigned)
5551 codepoint of an invalid character, to avoid displaying a bogus
5552 negative value.
5553
5554 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5555 `error', not SYMBOL_NAME itself.
5556
5557 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5558 character arguments to `error'.
5559
5560 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5561 to `error' in error message about FINAL_CHAR argument. Make sure
5562 FINAL_CHAR is a character, and use %c when it is passed as
5563 argument to `error'.
5564
5565 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5566
5567 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5568
5569 * w32.c: Include <time.h>.
5570 (sys_localtime): New function.
5571
5572 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5573
5574 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5575
5576 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5577
5578 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5579
5580 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5581 zombies (Bug#8467).
5582
5583 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5584
5585 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5586 gl_state.e_property when gl_state.object is Qt.
5587
5588 * insdel.c (make_gap_larger): Remove limitation of buffer size
5589 to <= INT_MAX.
5590
5591 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5592
5593 * xdisp.c (lookup_glyphless_char_display)
5594 (produce_glyphless_glyph): Handle cons cell entry in
5595 glyphless-char-display.
5596 (Vglyphless_char_display): Document it.
5597
5598 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5599 glyphless-char-display.
5600
5601 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5602
5603 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5604
5605 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5606
5607 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5608 definition for no-X builds.
5609
5610 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5611
5612 Static checks with GCC 4.6.0 and non-default toolkits.
5613
5614 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5615
5616 * process.c (keyboard_bit_set): Define only if SIGIO.
5617 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5618 (send_process): Repair possible setjmp clobbering.
5619
5620 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5621
5622 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5623
5624 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5625
5626 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5627 Define only if needed.
5628
5629 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5630 by pacifying GCC about it. Maybe it's time to retire it?
5631 * xfaces.c (USG, __TIMEVAL__): Likewise.
5632
5633 * dispextern.h (struct redisplay_interface): Rename param
5634 to avoid shadowing.
5635 * termhooks.h (struct terminal): Likewise.
5636 * xterm.c (xembed_send_message): Likewise.
5637
5638 * insdel.c (make_gap_smaller): Define only if
5639 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5640
5641 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5642 it.
5643
5644 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5645 so that we aren't warned about unused symbols.
5646
5647 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5648
5649 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5650
5651 * xfns.c (x_real_positions): Mark locals as initialized.
5652
5653 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5654
5655 * xterm.c: Fix problems found by static analysis with other toolkits.
5656 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5657 (x_dispatch_event): Declare static if USE_GTK, and
5658 define if USE_GTK || USE_X_TOOLKIT.
5659 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5660 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5661 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5662 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5663
5664 * xmenu.c (menu_help_callback): Pointer type fixes.
5665 Use const pointers when pointing at readonly data. Avoid pointer
5666 signedness clashes.
5667 (FALSE): Remove unused macro.
5668 (update_frame_menubar): Remove unused decl.
5669
5670 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5671
5672 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5673 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5674 (single_menu_item): Rename local to avoid shadowing.
5675
5676 * keyboard.c (make_lispy_event): Remove unused local var.
5677
5678 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5679 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5680
5681 * bitmaps: Change bitmaps from unsigned char back to the X11
5682 compatible char. Avoid the old compiler warnings about
5683 out-of-range initializers by using, for example, '\xab' rather
5684 than 0xab.
5685
5686 * xgselect.c (xgselect_initialize): Check vs interface
5687 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5688
5689 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5690
5691 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5692 to read-only memory.
5693
5694 * fns.c (vector): Remove; this old hack is no longer needed.
5695
5696 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5697 Remove unused var.
5698 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5699
5700 * xrdb.c (x_load_resources): Omit unused local.
5701
5702 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5703 (x_window): Rename locals to avoid shadowing.
5704 (USG): Use the kludged USG macro, to pacify gcc.
5705
5706 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5707 (x_term_init): Remove local to avoid shadowing.
5708
5709 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5710
5711 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5712 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5713
5714 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5715
5716 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5717
5718 Fix regex.c, syntax.c and friends for buffers > 2GB.
5719 * syntax.h (struct gl_state_s): Declare character position members
5720 EMACS_INT.
5721
5722 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5723
5724 * textprop.c (verify_interval_modification, interval_of):
5725 Declare arguments EMACS_INT.
5726
5727 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5728 EMACS_INT.
5729
5730 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5731
5732 * indent.c (Fvertical_motion): Local variable it_start is now
5733 EMACS_INT.
5734
5735 * regex.c (re_match, re_match_2, re_match_2_internal)
5736 (bcmp_translate, regcomp, regexec, print_double_string)
5737 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5738 (re_compile_pattern, re_exec): Declare arguments and local
5739 variables `size_t' and `ssize_t' and return values `regoff_t', as
5740 appropriate.
5741 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5742 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5743 <compile_stack_type>: `size' and `avail' are now `size_t'.
5744
5745 * regex.h <regoff_t>: Use ssize_t, not int.
5746 (re_search, re_search_2, re_match, re_match_2): Arguments that
5747 specify buffer/string position and length are now ssize_t and
5748 size_t. Return type is regoff_t.
5749
5750 2011-04-16 Ben Key <bkey76@gmail.com>
5751
5752 * nsfont.m: Fixed bugs in ns_get_family and
5753 ns_descriptor_to_entity that were caused by using free to
5754 deallocate memory blocks that were allocated by xmalloc (via
5755 xstrdup). This caused Emacs to crash when compiled with
5756 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5757 --enable-checking=xmallocoverrun). xfree is now used to
5758 deallocate these memory blocks.
5759
5760 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5761
5762 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5763
5764 emacs_write: Accept and return EMACS_INT for sizes.
5765 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5766 et seq.
5767 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5768 Accept and return EMACS_INT.
5769 (emacs_gnutls_write): Return the number of bytes written on
5770 partial writes.
5771 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5772 (emacs_read, emacs_write): Remove check for negative size, as the
5773 Emacs source code has been audited now.
5774 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5775 (emacs_read, emacs_write): Use it.
5776 * process.c (send_process): Adjust to the new signatures of
5777 emacs_write and emacs_gnutls_write. Do not attempt to store
5778 a byte offset into an 'int'; it might overflow.
5779 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5780
5781 * sound.c: Don't assume sizes fit in 'int'.
5782 (struct sound_device.period_size, alsa_period_size):
5783 Return EMACS_INT, not int.
5784 (struct sound_device.write, vox_write, alsa_write):
5785 Accept EMACS_INT, not int.
5786 (wav_play, au_play): Use EMACS_INT to store sizes and to
5787 record read return values.
5788
5789 2011-04-15 Ben Key <bkey76@gmail.com>
5790
5791 * keyboard.c (Qundefined): Don't declare static since it is used
5792 in nsfns.m.
5793 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5794 static since they are used in nsfont.m.
5795
5796 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5797
5798 * process.c (Qprocessp): Don't declare static.
5799 * lisp.h (Qprocessp): Declare again.
5800
5801 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5802
5803 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5804
5805 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5806
5807 Improve C-level modularity by making more things 'static'.
5808
5809 Don't publish debugger-only interfaces to other modules.
5810 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5811 (verify_bytepos, count_markers): Move decls to the only modules
5812 that need them.
5813 * region-cache.h (pp_cache): Likewise.
5814 * window.h (check_all_windows): Likewise.
5815 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5816
5817 * sysdep.c (croak): Now static, if
5818 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5819 * syssignal.h (croak): Declare only if not static.
5820
5821 * alloc.c (refill_memory_reserve): Now static if
5822 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5823 * lisp.h (refill_memory_reserve): Declare only if not static.
5824
5825 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5826 Define only if USE_LUCID.
5827
5828 * xrdb.c (x_customization_string, x_rm_string): Now static.
5829
5830 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5831 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5832
5833 * xdisp.c (draw_row_with_mouse_face): Now static.
5834 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5835
5836 * window.h (check_all_windows): Mark externally visible.
5837
5838 * window.c (window_deletion_count): Now static.
5839
5840 * undo.c: Make symbols static if they're not exported.
5841 (last_undo_buffer, last_boundary_position, pending_boundary):
5842 Now static.
5843
5844 * textprop.c (interval_insert_behind_hooks): Now static.
5845 (interval_insert_in_front_hooks): Likewise.
5846
5847 * term.c: Make symbols static if they're not exported.
5848 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5849 (max_frame_lines, tty_set_terminal_modes):
5850 (tty_reset_terminal_modes, tty_turn_off_highlight):
5851 (get_tty_terminal): Now static.
5852 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5853 * termhooks.h (term_mouse_moveto): Do not declare if
5854 HAVE_WINDOW_SYSTEM.
5855 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5856 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5857
5858 * sysdep.c: Make symbols static if they're not exported.
5859 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5860 Now static.
5861 (sigprocmask_set, full_mask): Remove; unused.
5862 (wait_debugging): Mark as visible.
5863 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5864 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5865
5866 * syntax.c (syntax_temp): Define only if !__GNUC__.
5867
5868 * sound.c (current_sound_device, current_sound): Now static.
5869
5870 * search.c (searchbufs, searchbuf_head): Now static.
5871
5872 * scroll.c (scroll_cost): Remove; unused.
5873 * dispextern.h (scroll_cost): Remove decl.
5874
5875 * region-cache.h (pp_cache): Mark as externally visible.
5876
5877 * process.c: Make symbols static if they're not exported.
5878 (process_tick, update_tick, create_process, chan_process):
5879 (Vprocess_alist, proc_buffered_char, datagram_access):
5880 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5881 (deactivate_process): Mark defn as static, as well as decl.
5882 * lisp.h (create_process): Remove decl.
5883 * process.h (chan_process, Vprocess_alist): Remove decls.
5884
5885 * print.c: Make symbols static if they're not exported.
5886 (print_depth, new_backquote_output, being_printed, print_buffer):
5887 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5888 (print_interval, print_number_index, initial_stderr_stream):
5889 Now static.
5890 * lisp.h (Fprinc): Remove decl.
5891 (debug_output_compilation_hack): Mark as externally visible.
5892
5893 * sysdep.c (croak): Move decl from here to syssignal.h.
5894 * syssignal.h (croak): Put it here, so the API can be checked when
5895 'croak' is called from dissociate_if_controlling_tty.
5896
5897 * minibuf.c: Make symbols static if they're not exported.
5898 (minibuf_save_list, choose_minibuf_frame): Now static.
5899 * lisp.h (choose_minibuf_frame): Remove decl.
5900
5901 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5902
5903 * lread.c: Make symbols static if they're not exported.
5904 (read_objects, initial_obarray, oblookup_last_bucket_number):
5905 Now static.
5906 (make_symbol): Remove; unused.
5907 * lisp.h (initial_obarray, make_symbol): Remove decls.
5908
5909 * keyboard.c: Make symbols static if they're not exported.
5910 (single_kboard, recent_keys_index, total_keys, recent_keys):
5911 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5912 (this_single_command_key_start, echoing, last_auto_save):
5913 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5914 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5915 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5916 (Vlispy_mouse_stem, double_click_count):
5917 Now static.
5918 (force_auto_save_soon): Define only if SIGDANGER.
5919 (ignore_mouse_drag_p): Now static if
5920 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5921 (print_help): Remove; unused.
5922 (stop_character, last_timer_event): Mark as externally visible.
5923 * keyboard.h (ignore_mouse_drag_p): Declare only if
5924 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5925 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5926 * lisp.h (echoing): Remove decl.
5927 (force_auto_save_soon): Declare only if SIGDANGER.
5928 * xdisp.c (redisplay_window): Simplify code, to make it more
5929 obvious that ignore_mouse_drag_p is not accessed if !defined
5930 USE_GTK && !defined HAVE_NS.
5931
5932 * intervals.c: Make symbols static if they're not exported.
5933 (merge_properties_sticky, merge_interval_right, delete_interval):
5934 Now static.
5935 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5936
5937 * insdel.c: Make symbols static if they're not exported.
5938 However, leave prepare_to_modify_buffer alone. It's never
5939 called from outside this function, but that appears to be a bug.
5940 (combine_after_change_list, combine_after_change_buffer):
5941 (adjust_after_replace, signal_before_change): Now static.
5942 (adjust_after_replace_noundo): Remove; unused.
5943 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5944 (signal_before_change): Remove decls.
5945
5946 * indent.c (val_compute_motion, val_vmotion): Now static.
5947
5948 * image.c: Make symbols static if they're not exported.
5949 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5950 if USE_GTK.
5951 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5952 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5953
5954 * fringe.c (standard_bitmaps): Now static.
5955 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5956
5957 * frame.c: Make symbols static if they're not exported.
5958 (x_report_frame_params, make_terminal_frame): Now static.
5959 (get_frame_param): Now static, unless HAVE_NS.
5960 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5961 (x_get_resource_string): Remove; not used.
5962 * frame.h (make_terminal_frame, x_report_frame_params):
5963 (x_get_resource_string); Remove decls.
5964 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5965 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5966
5967 * font.c, fontset.c: Make symbols static if they're not exported.
5968 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5969 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5970 * font.c (font_close_object): Now static.
5971 * font.h (font_close_object): Remove.
5972 * fontset.c (FONTSET_OBJLIST): Remove.
5973 (free_realized_fontset) #if-0 the body, which does nothing.
5974 (face_suitable_for_char_p): #if-0, as it's never called.
5975 * fontset.h (face_suitable_for_char_p): Remove decl.
5976 * xfaces.c (face_at_string_position):
5977 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5978 since 0 is always ASCII.
5979
5980 * fns.c (weak_hash_tables): Now static.
5981
5982 * fileio.c: Make symbols static if they're not exported.
5983 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5984 (Vwrite_region_annotation_buffers): Now static.
5985
5986 * eval.c: Make symbols static if they're not exported.
5987 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5988 * lisp.h (backtrace_list): Remove decl.
5989
5990 * emacs.c: Make symbols static if they're not exported.
5991 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5992 (fatal_error_code, fatal_error_signal_hook, standard_args):
5993 Now static.
5994 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5995 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5996 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5997 * lisp.h (fatal_error_signal_hook): Remove decl.
5998 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5999
6000 * editfns.c: Move a (normally-unused) function to its only use.
6001 * editfns.c, lisp.h (get_operating_system_release): Remove.
6002 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6003 worth the hassle of breaking this out.
6004
6005 * xterm.c: Make symbols static if they're not exported.
6006 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6007 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6008 (x_destroy_window, x_delete_display):
6009 Now static.
6010 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6011 (x_mouse_leave): Remove; unused.
6012 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6013 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6014 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6015 Remove decls.
6016 (x_mouse_leave): Declare only if WINDOWSNT.
6017 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6018 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6019 USE_X_TOOLKIT.
6020
6021 * ftxfont.c: Make symbols static if they're not exported.
6022 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6023 HAVE_FREETYPE.
6024 * font.h (ftxfont_driver): Likewise.
6025
6026 * xfns.c: Make symbols static if they're not exported.
6027 (x_last_font_name, x_display_info_for_name):
6028 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6029 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6030 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6031 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6032 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6033 (last_show_tip_args): Now static.
6034 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6035 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6036 (x_screen_planes): Remove; unused.
6037 * dispextern.h (x_screen_planes): Remove decl.
6038
6039 * dispnew.c: Make symbols static if they're not exported.
6040 * dispextern.h (redraw_garbaged_frames, scrolling):
6041 (increment_row_positions): Remove.
6042 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6043 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6044 Now static.
6045 (redraw_garbaged_frames): Remove; unused.
6046
6047 * xfaces.c: Make symbols static if they're not exported.
6048 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6049 Remove decls.
6050 * xterm.h (defined_color): Remove decls.
6051 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6052 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6053 (menu_face_changed_default, defined_color, free_realized_face):
6054 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6055 (ascii_face_of_lisp_face): Remove; unused.
6056
6057 * xdisp.c: Make symbols static if they're not exported.
6058 * dispextern.h (scratch_glyph_row, window_box_edges):
6059 (glyph_to_pixel_coords, set_cursor_from_row):
6060 (get_next_display_element, set_iterator_to_next):
6061 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6062 (show_mouse_face): Remove decls
6063 * frame.h (message_buf_print): Likewise.
6064 * lisp.h (pop_message, set_message, check_point_in_composition):
6065 Likewise.
6066 * xterm.h (set_vertical_scroll_bar): Likewise.
6067 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6068 (message_buf_print, scratch_glyph_row, displayed_buffer):
6069 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6070 (get_next_display_element, show_mouse_face, window_box_edges):
6071 (frame_to_window_pixel_xy, check_point_in_composition):
6072 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6073 (glyph_to_pixel_coords): Remove; unused.
6074
6075 * dired.c (file_name_completion): Now static.
6076
6077 * dbusbind.c (xd_in_read_queued_messages): Now static.
6078
6079 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6080 * data.c (circular_list_error): Remove.
6081
6082 * commands.h (last_point_position, last_point_position_buffer):
6083 (last_point_position_window): Remove decls.
6084 * keyboard.c: Make these variables static.
6085
6086 * coding.h (coding, code_convert_region, encode_coding_gap):
6087 Remove decls.
6088 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6089 (iso_code_class, detect_coding, code_convert_region): Now static.
6090 (encode_coding_gap): Remove; unused.
6091
6092 * chartab.c (chartab_chars, chartab_bits): Now static.
6093
6094 * charset.h (charset_iso_8859_1): Remove decl.
6095 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6096 Now static.
6097
6098 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6099 * ccl.c (Vccl_program_table): Now static.
6100 (check_ccl_update): Remove; unused.
6101
6102 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6103 * category.h: ... from here.
6104 * category.c (check_category_table, set_category_set): Now static.
6105
6106 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6107 * lisp.h: Remove these decls.
6108
6109 * buffer.c (buffer_count): Remove unused var.
6110
6111 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6112 so that it's not optimized away.
6113 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6114 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6115 exported only to the debugger.
6116
6117 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6118 * atimer.h (run_all_atimers): Remove; not exported.
6119
6120 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6121 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6122 was inaccessible from Lisp.
6123 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6124 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6125
6126 alloc.c: Import and export fewer symbols, and remove unused items.
6127 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6128 is defined.
6129 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6130 it's not optimized away by whole-program optimization.
6131 (message_enable_multibyte, free_misc): Remove.
6132 (catchlist, handlerlist, mark_backtrace):
6133 Declare only if BYTE_MARK_STACK.
6134 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6135 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6136 (message_enable_multibyte): Remove decl.
6137 (free_misc, interval_free_list, float_block, float_block_index):
6138 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6139 (cons_free_list, last_marked_index):
6140 Now static.
6141 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6142 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6143 (mark_backtrace): Define only if BYTE_MARK_STACK.
6144 * xdisp.c (message_enable_multibyte): Now static.
6145
6146 Declare Lisp_Object Q* variables to be 'static' if not exported.
6147 This makes it easier for human readers (and static analyzers)
6148 to see whether these variables are used from other modules.
6149 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6150 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6151 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6152 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6153 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6154 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6155 * xmenu.c, xselect.c:
6156 Declare Q* vars static if they are not used in other modules.
6157 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6158 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6159 Remove decls of unexported vars.
6160 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6161
6162 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6163
6164 Make Emacs functions such as Fatom 'static' by default.
6165 This makes it easier for human readers (and static analyzers)
6166 to see whether these functions can be called from other modules.
6167 DEFUN now defines a static function. To make the function external
6168 so that it can be used in other C modules, use the new macro DEFUE.
6169 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6170 (Finit_image_library):
6171 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6172 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6173 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6174 Remove decls, since these functions are now static.
6175 (Funintern, Fget_internal_run_time): New decls, since these functions
6176 were already external.
6177
6178 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6179 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6180 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6181 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6182 * keyboard.c, keymap.c, lread.c:
6183 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6184 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6185 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6186 Mark functions with DEFUE instead of DEFUN,
6187 if they are used in other modules.
6188 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6189 decls for now-static functions.
6190 * buffer.h (Fdelete_overlay): Remove decl.
6191 * callproc.c (Fgetenv_internal): Mark as internal.
6192 * composite.c (Fremove_list_of_text_properties): Remove decl.
6193 (Fcomposition_get_gstring): New forward static decl.
6194 * composite.h (Fcomposite_get_gstring): Remove decl.
6195 * dired.c (Ffile_attributes): New forward static decl.
6196 * doc.c (Fdocumntation_property): New forward static decl.
6197 * eval.c (Ffetch_bytecode): New forward static decl.
6198 (Funintern): Remove extern decl; now in .h file where it belongs.
6199 * fileio.c (Fmake_symbolic_link): New forward static decl.
6200 * image.c (Finit_image_library): New forward static decl.
6201 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6202 * intervals.h (Fprevious_property_change):
6203 (Fremove_list_of_text_properties): Remove decls.
6204 * keyboard.c (Fthis_command_keys): Remove decl.
6205 (Fcommand_execute): New forward static decl.
6206 * keymap.c (Flookup_key): New forward static decl.
6207 (Fcopy_keymap): Now static.
6208 * keymap.h (Flookup_key): Remove decl.
6209 * process.c (Fget_process): New forward static decl.
6210 (Fprocess_datagram_address): Mark as internal.
6211 * syntax.c (Fsyntax_table_p): New forward static decl.
6212 (skip_chars): Remove duplicate decl.
6213 * textprop.c (Fprevious_property_change): New forward static decl.
6214 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6215 Now internal.
6216 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6217 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6218
6219 * editfns.c (Fformat): Remove unreachable code.
6220
6221 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6222
6223 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6224 change. (Bug#8496)
6225
6226 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6227
6228 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6229 when at ZV. (Bug#8487)
6230
6231 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6232
6233 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6234 (Bug#8437)
6235 * keyboard.c (parse_tool_bar_item): Likewise.
6236 * sound.c (sound_cleanup, alsa_close): Likewise.
6237 * termcap.c (tgetent): Likewise.
6238 * xfns.c (x_default_font_parameter): Likewise.
6239 * xsettings.c (read_and_apply_settings): Likewise.
6240
6241 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6242 (overrun_check_free): Protoize.
6243
6244 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6247 since callers should never pass a negative size.
6248 Change the signature to match that of plain 'read' and 'write'; see
6249 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6250 * lisp.h: Update prototypes of emacs_write and emacs_read.
6251
6252 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6253
6254 * xdisp.c (redisplay_window): Don't try to determine the character
6255 position of the scroll margin if the window start point w->startp
6256 is outside the buffer's accessible region. (Bug#8468)
6257
6258 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6259
6260 Fix write-region and its subroutines for buffers > 2GB.
6261 * fileio.c (a_write, e_write): Modify declaration of arguments and
6262 local variables to support buffers larger than 2GB.
6263 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6264
6265 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6266 argument, local variables, and return value.
6267
6268 * lisp.h: Update prototypes of emacs_write and emacs_read.
6269
6270 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6271
6272 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6275
6276 Fix more problems found by GCC 4.6.0's static checks.
6277
6278 * xdisp.c (vmessage): Use a better test for character truncation.
6279
6280 * charset.c (load_charset_map): <, not <=, for optimization,
6281 and to avoid potential problems with integer overflow.
6282 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6283 * casetab.c (set_identity, shuffle): Likewise.
6284 * editfns.c (Fformat): Likewise.
6285 * syntax.c (skip_chars): Likewise.
6286
6287 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6288 This also lets GCC 4.6.0 generate slightly better loop code.
6289
6290 * callint.c (Fcall_interactively): <, not <=, for optimization.
6291 (Fcall_interactively): Count the number of arguments produced,
6292 not the number of arguments given. This is simpler and lets GCC
6293 4.6.0 generate slightly better code.
6294
6295 * ftfont.c: Distingish more carefully between FcChar8 and char.
6296 The previous code passed unsigned char * to a functions like
6297 strlen and xstrcasecmp that expect char *, which does not
6298 conform to the C standard.
6299 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6300 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6301 char * when the C standard requires it.
6302
6303 * keyboard.c (read_char): Remove unused var.
6304
6305 * eval.c: Port to Windows vsnprintf (Bug#8435).
6306 Include <limits.h>.
6307 (SIZE_MAX): Define if the headers do not.
6308 (verror): Do not give up if vsnprintf returns a negative count.
6309 Instead, grow the buffer. This ports to Windows vsnprintf, which
6310 does not conform to C99. Problem reported by Eli Zaretskii.
6311 Also, simplify the allocation scheme, by avoiding the need for
6312 calling realloc, and removing the ALLOCATED variable.
6313
6314 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6315
6316 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6317 But keep the doprint source code for now, as we might revamp it
6318 and use it again (Bug#8435).
6319 * lisp.h (doprnt): Remove.
6320 * Makefile.in (base_obj): Remove doprnt.o.
6321 * deps.mk (doprnt.o): Remove.
6322
6323 error: Print 32- and 64-bit integers portably (Bug#8435).
6324 Without this change, on typical 64-bit hosts error ("...%d...", N)
6325 was used to print both 32- and 64-bit integers N, which relied on
6326 undefined behavior.
6327 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6328 New macro.
6329 * lisp.h (error, verror): Mark as printf-like functions.
6330 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6331 Report overflow in size calculations when allocating printf buffer.
6332 Do not truncate output string at its first null byte.
6333 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6334 Truncate the output at a character boundary, since vsnprintf does not
6335 do that.
6336 * charset.c (check_iso_charset_parameter): Convert internal
6337 character to string before calling 'error', since %c now has the
6338 printf meaning.
6339 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6340 overflow when computing char to be passed to 'error'. Do not
6341 pass Lisp_Object to 'error'; pass the integer instead.
6342 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6343 formatted with plain %d.
6344
6345 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6346
6347 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6348
6349 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6350
6351 * xterm.c (x_catch_errors): Remove duplicate declaration.
6352
6353 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6354
6355 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6356
6357 2011-04-10 Jim Meyering <meyering@redhat.com>
6358
6359 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6360 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6361 return ssize_t not "int", and use size_t as the buffer length.
6362 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6363 * gnutls.h: Update declarations.
6364 * process.c (read_process_output): Use ssize_t, to match.
6365 (send_process): Likewise.
6366
6367 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6368
6369 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6370
6371 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6372
6373 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6374 Use unsigned char, to match FcChar8 type definition.
6375
6376 * xterm.c (handle_one_xevent):
6377 * xmenu.c (create_and_show_popup_menu):
6378 * xselect.c (x_decline_selection_request)
6379 (x_reply_selection_request): Avoid type-punned deref of X events.
6380
6381 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6382
6383 Fix some uses of `int' instead of EMACS_INT.
6384 * search.c (string_match_1, fast_string_match)
6385 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6386 (scan_buffer, find_next_newline_no_quit)
6387 (find_before_next_newline, search_command, Freplace_match)
6388 (Fmatch_data): Make some `int' variables be EMACS_INT.
6389
6390 * xdisp.c (display_count_lines): 3rd argument and return value now
6391 EMACS_INT. All callers changed.
6392 (pint2hrstr): Last argument is now EMACS_INT.
6393
6394 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6395 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6396 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6397 (decode_coding_utf_16, decode_coding_emacs_mule)
6398 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6399 (decode_coding_ccl, decode_coding_charset)
6400 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6401 (decode_coding_iso_2022, decode_coding_emacs_mule)
6402 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6403 <char_offset, last_offset>: Declare EMACS_INT.
6404 (encode_coding_utf_8, encode_coding_utf_16)
6405 (encode_coding_emacs_mule, encode_invocation_designation)
6406 (encode_designation_at_bol, encode_coding_iso_2022)
6407 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6408 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6409 Declare EMACS_INT.
6410 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6411 (encode_invocation_designation): Last argument P_NCHARS is now
6412 EMACS_INT.
6413 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6414 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6415
6416 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6417 All users changed.
6418
6419 * ccl.c (Fccl_execute_on_string): Declare some variables
6420 EMACS_INT.
6421
6422 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6423
6424 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6425
6426 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6427
6428 * process.c (Fformat_network_address): Doc fix.
6429
6430 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6431
6432 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6433
6434 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6435
6436 * keyboard.c (read_char): Call Lisp function help-form-show,
6437 instead of using internal_with_output_to_temp_buffer.
6438 (Qhelp_form_show): New var.
6439 (syms_of_keyboard): Use DEFSYM macro.
6440
6441 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6442
6443 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6444
6445 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6446
6447 * process.c (Flist_processes): Remove to Lisp.
6448 (list_processes_1): Delete.
6449
6450 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6451
6452 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6453
6454 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6455
6456 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6457
6458 Fix more problems found by GCC 4.6.0's static checks.
6459
6460 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6461
6462 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6463
6464 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6465
6466 * xdisp.c (vmessage): Mark as a printf-like function.
6467
6468 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6469
6470 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6471
6472 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6473 printf-like functions.
6474 (tiff_load): Add casts to remove these marks before passing them
6475 to system-supplied API.
6476
6477 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6478
6479 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6480 This avoids several warnings with gcc -Wstrict-overflow.
6481 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6482 directly, rather than having caller test rule sign. This avoids
6483 some unnecessary tests.
6484 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6485 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6486 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6487
6488 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6489 (xfont_open): Avoid unnecessary tests.
6490
6491 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6492
6493 * composite.h, composite.c (composition_gstring_put_cache):
6494 Use EMACS_INT, not int, for length.
6495
6496 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6497 breaking out part of COMPOSITION_DECODE_RULE.
6498 (COMPOSITION_DECODE_RULE): Use it.
6499 * composite.c (get_composition_id): Remove unused local vars,
6500 by using the new macro.
6501
6502 * textprop.c (set_text_properties_1): Change while to do-while,
6503 since the condition is always true at first.
6504
6505 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6506 (interval_deletion_adjustment): Return unsigned value.
6507 All uses changed.
6508
6509 * process.c (list_processes_1, create_pty, read_process_output):
6510 (exec_sentinel): Remove vars that were set but not used.
6511 (create_pty): Remove unnecessary "volatile"s.
6512 (Fnetwork_interface_info): Avoid possibility of int overflow.
6513 (read_process_output): Do adaptive read buffering even if carryover.
6514 (read_process_output): Simplify nbytes computation if buffered.
6515
6516 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6517
6518 * syntax.c (scan_words): Remove var that was set but not used.
6519 (update_syntax_table): Use unsigned instead of int.
6520
6521 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6522 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6523 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6524
6525 * print.c (print_error_message): Avoid int overflow.
6526
6527 * font.c (font_list_entities): Redo for clarity,
6528 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6529
6530 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6531 (font_score): Avoid potential overflow in diff calculation.
6532
6533 * fns.c (substring_both): Remove var that is set but not used.
6534 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6535
6536 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6537
6538 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6539 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6540 can always succeed if overflow has undefined behavior.
6541
6542 * search.c (boyer_moore, wordify): Remove vars set but not used.
6543 (wordify): Omit three unnecessary tests.
6544
6545 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6546 All callers changed. This avoids the need for an unused var.
6547
6548 * casefiddle.c (casify_region): Remove var that is set but not used.
6549
6550 * dired.c (file_name_completion): Remove var that is set but not used.
6551
6552 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6553
6554 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6555 (Finsert_file_contents): Remove unnecessary code checking fd.
6556
6557 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6558 Check for integer overflow on size calculations.
6559
6560 * buffer.c (Fprevious_overlay_change): Remove var that is set
6561 but not used.
6562
6563 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6564 Remove vars that are set but not used.
6565 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6566 (timer_check_2): Mark vars as initialized.
6567
6568 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6569
6570 * image.c (lookup_image): Remove var that is set but not used.
6571 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6572
6573 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6574 that are set but not used.
6575
6576 * xfns.c (make_invisible_cursor): Don't return garbage
6577 if XCreateBitmapFromData fails (Bug#8410).
6578
6579 * xselect.c (x_get_local_selection, x_handle_property_notify):
6580 Remove vars that are set but not used.
6581
6582 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6583 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6584
6585 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6586 Remove var that is set but not used.
6587 (scroll_bar_windows_size): Now size_t, not int.
6588 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6589 Check for overflow.
6590
6591 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6592 (map_tty_color) [!defined MSDOS]: Likewise.
6593
6594 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6595
6596 * coding.c: Remove vars that are set but not used.
6597 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6598 All callers changed.
6599 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6600 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6601 (decode_coding_charset): Remove vars that are set but not used.
6602
6603 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6604 that is set but not used.
6605
6606 * print.c (print_object): Remove var that is set but not used.
6607
6608 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6609 The gnulib version avoids calling malloc in the usual case,
6610 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6611 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6612 * filelock.c (current_lock_owner): Likewise.
6613 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6614 * sysdep.c: Include allocator.h, careadlinkat.h.
6615 (emacs_no_realloc_allocator): New static constant.
6616 (emacs_readlink): New function.
6617 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6618 ../lib/careadlinkat.h.
6619
6620 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6621
6622 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6623 first non-nil return value).
6624
6625 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6626
6627 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6628 if not defined (Bug#8403).
6629
6630 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6631
6632 * xdisp.c (display_count_lines): Remove parameter `start',
6633 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6634 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6635 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6636 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6637 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6638 and thereabouts. All callers changed.
6639 (get_per_char_metric): Remove parameter `f', unused since
6640 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6641
6642 2011-04-02 Jim Meyering <meyering@redhat.com>
6643
6644 do not dereference NULL upon failed strdup
6645 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6646 (ns_get_family): Likewise.
6647
6648 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6651
6652 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6653
6654 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6655 later (Bug#8403).
6656
6657 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6658
6659 Add lexical binding.
6660
6661 * window.c (Ftemp_output_buffer_show): New fun.
6662 (Fsave_window_excursion):
6663 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6664
6665 * lread.c (lisp_file_lexically_bound_p): New function.
6666 (Fload): Bind Qlexical_binding.
6667 (readevalloop): Remove `evalfun' arg.
6668 Bind Qinternal_interpreter_environment.
6669 (Feval_buffer): Bind Qlexical_binding.
6670 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6671 Mark as dynamic.
6672 (syms_of_lread): Declare `lexical-binding'.
6673
6674 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6675
6676 * keyboard.c (eval_dyn): New fun.
6677 (menu_item_eval_property): Use it.
6678
6679 * image.c (parse_image_spec): Use Ffunctionp.
6680
6681 * fns.c (concat, mapcar1): Accept byte-code-functions.
6682
6683 * eval.c (Fsetq): Handle lexical vars.
6684 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6685 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6686 (FletX, Flet): Obey lexical binding.
6687 (Fcommandp): Handle closures.
6688 (Feval): New `lexical' arg.
6689 (eval_sub): New function extracted from Feval. Use it almost
6690 everywhere where Feval was used. Look up vars in lexical env.
6691 Handle closures.
6692 (Ffunctionp): Move from subr.el.
6693 (Ffuncall): Handle closures.
6694 (apply_lambda): Remove `eval_flags'.
6695 (funcall_lambda): Handle closures and new byte-code-functions.
6696 (Fspecial_variable_p): New function.
6697 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6698 but without exporting it to Lisp.
6699
6700 * doc.c (Fdocumentation, store_function_docstring):
6701 * data.c (Finteractive_form): Handle closures.
6702
6703 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6704 interactive spec.
6705
6706 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6707 New byte-codes.
6708 (exec_byte_code): New function extracted from Fbyte_code to handle new
6709 calling convention for byte-code-functions. Add new byte-codes.
6710
6711 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6712
6713 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6714
6715 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6716
6717 * xdisp.c (redisplay_internal): Fix prototype.
6718
6719 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6720
6721 * xdisp.c (SCROLL_LIMIT): New macro.
6722 (try_scrolling): Use it when setting scroll_limit.
6723 Limit scrolling to 100 screen lines.
6724 (redisplay_window): Even when falling back on "recentering",
6725 position point in the window according to scroll-conservatively,
6726 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6727
6728 (try_scrolling): When point is above the window, allow searching
6729 as far as scroll_max, or one screenful, to compute vertical
6730 distance from PT to the scroll margin position. This prevents
6731 try_scrolling from unnecessarily failing when
6732 scroll-conservatively is set to a value slightly larger than the
6733 window height. Clean up the case of PT below the margin at bottom
6734 of window: scroll_max can no longer be INT_MAX. When aggressive
6735 scrolling is in use, don't let point enter the opposite scroll
6736 margin as result of the scroll.
6737 (syms_of_xdisp) <scroll-conservatively>: Document the
6738 threshold of 100 lines for never-recentering scrolling.
6739
6740 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6741
6742 * dispextern.h (move_it_by_lines):
6743 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6744 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6745 (message_log_check_duplicate): Remove parameters `prev_bol' and
6746 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6747 (redisplay_internal): Remove parameter `preserve_echo_area',
6748 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6749
6750 * indent.c (Fvertical_motion):
6751 * window.c (window_scroll_pixel_based, Frecenter):
6752 Don't pass `need_y_p' to `move_it_by_lines'.
6753
6754 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6755
6756 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6757 steal a few bits to be more compact.
6758 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6759 Remove unneeded casts.
6760
6761 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6762
6763 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6764
6765 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6766 binding" message (bug#7967).
6767
6768 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6769
6770 Fix more problems found by GCC 4.6.0's static checks.
6771
6772 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6773 Remove unused local var.
6774
6775 * editfns.c (Fmessage_box): Remove unused local var.
6776
6777 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6778 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6779 Omit unused local vars.
6780 * window.c (shrink_windows): Omit unused local var.
6781 * menu.c (digest_single_submenu): Omit unused local var.
6782 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6783 Omit unused local var.
6784
6785 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6786 Don't assume string length fits in int.
6787 (keyremap_step, read_key_sequence): Use size_t for sizes.
6788 (read_key_sequence): Don't check last_real_key_start redundantly.
6789
6790 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6791 instead of alloca (Bug#8344).
6792
6793 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6794 (Fbacktrace_frame): Don't assume nframes fits in int.
6795
6796 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6797
6798 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6799 concerns.
6800
6801 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6802
6803 * cm.c (calccost): Turn while-do into do-while, for clarity.
6804
6805 * keyboard.c (syms_of_keyboard): Use the same style as later
6806 in this function when indexing through an array. This also
6807 works around GCC bug 48267.
6808
6809 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6810
6811 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6812
6813 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6814 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6815
6816 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6817 This avoids undefined behavior on integer overflow, and is a bit
6818 more convenient anyway since it is compared to a size_t variable.
6819
6820 Variadic C functions now count arguments with size_t, not int.
6821 This avoids an unnecessary limitation on 64-bit machines, which
6822 caused (substring ...) to crash on large vectors (Bug#8344).
6823 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6824 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6825 All variadic functions and their callers changed accordingly.
6826 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6827 * data.c (arith_driver, float_arith_driver): Likewise.
6828 * editfns.c (general_insert_function): Likewise.
6829 * eval.c (struct backtrace.nargs, interactive_p)
6830 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6831 (funcall_lambda, mark_backtrace): Likewise.
6832 * fns.c (concat): Likewise.
6833 * frame.c (x_set_frame_parameters): Likewise.
6834 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6835 0 if not found, not -1. All callers changed.
6836
6837 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6838 (stack_copy_size): Now size_t, not int.
6839 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6840
6841 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6842
6843 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6844 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6845 All callers changed.
6846
6847 * lisp.h (multibyte_char_to_unibyte):
6848 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6849 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6850 * character.h (CHAR_TO_BYTE8):
6851 * cmds.c (internal_self_insert):
6852 * editfns.c (general_insert_function):
6853 * keymap.c (push_key_description):
6854 * search.c (Freplace_match):
6855 * xdisp.c (message_dolog, set_message_1): All callers changed.
6856
6857 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6858
6859 * keyboard.c (safe_run_hook_funcall): New function.
6860 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6861 don't set the hook to nil, but remove the offending function instead.
6862 (Qcommand_hook_internal): Remove, unused.
6863 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6864 Vcommand_hook_internal.
6865
6866 * eval.c (enum run_hooks_condition): Remove.
6867 (funcall_nil, funcall_not): New functions.
6868 (run_hook_with_args): Call each function through a `funcall' argument.
6869 Remove `cond' argument, now redundant.
6870 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6871 (Frun_hook_with_args_until_failure): Adjust accordingly.
6872 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6873
6874 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * dispextern.h (string_buffer_position): Remove declaration.
6877
6878 * print.c (strout): Remove parameter `multibyte', unused since
6879 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6880
6881 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6882 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6883 All callers changed.
6884
6885 * w32.c (_wsa_errlist): Use braces for struct initializers.
6886
6887 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6888 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6889 All callers changed.
6890 (string_buffer_position): Likewise. Also, make static (it's never
6891 used outside xdisp.c).
6892 (cursor_row_p): Remove parameter `w', unused since
6893 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6894 (decode_mode_spec): Remove parameter `precision', introduced during
6895 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6896 All callers changed.
6897
6898 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6899
6900 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6901
6902 2011-03-27 Anders Lindgren <andlind@gmail.com>
6903
6904 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6905 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6906 (ns_update_auto_hide_menu_bar): New functions.
6907 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6908 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6909 ns_constrain_all_frames.
6910 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6911 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6912
6913 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6914
6915 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6916
6917 2011-03-27 Glenn Morris <rgm@gnu.org>
6918
6919 * syssignal.h: Replace RETSIGTYPE with void.
6920 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6921 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6922 Replace SIGTYPE with void everywhere.
6923 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6924 * s/template.h (SIGTYPE): Remove commented out definition.
6925
6926 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6927
6928 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6929 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6930
6931 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * w32.c (read_unc_volume): Use parameter `henum', instead of
6934 global variable `wget_enum_handle'.
6935
6936 * keymap.c (describe_vector): Remove parameters `indices' and
6937 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6938 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6939
6940 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6941
6942 * keyboard.c (timer_check): Remove parameter `do_it_now',
6943 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6944 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6945 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6946
6947 * keyboard.c (read_char):
6948 * w32menu.c (w32_menu_display_help):
6949 * xmenu.c (show_help_event, menu_help_callback):
6950 Adjust calls to `show_help_echo'.
6951
6952 * gtkutil.c (xg_maybe_add_timer):
6953 * keyboard.c (readable_events):
6954 * process.c (wait_reading_process_output):
6955 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6956
6957 * insdel.c (adjust_markers_gap_motion):
6958 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6959 (gap_left, gap_right): Don't call it.
6960
6961 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6962
6963 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6964 incurred during fontification.
6965
6966 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6967
6968 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6969 (DEFVAR_PER_BUFFER): Don't pass it.
6970
6971 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6972 (scrolling_window): Don't pass it.
6973
6974 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6975
6976 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6977
6978 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6979 and `suffix'.
6980 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6981 of variables specific to SELinux and computation of `encoded_absname'.
6982
6983 * image.c (XPutPixel): Remove unused variable `height'.
6984
6985 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6986
6987 * unexw32.c (get_section_info): Remove unused variable `section'.
6988
6989 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6990 (system_process_attributes): Remove unused variable `sess'.
6991 (sys_read): Remove unused variable `err'.
6992
6993 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6994 (w32_wnd_proc): Remove unused variable `isdead'.
6995 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6996 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6997 (x_create_tip_frame): Remove unused variable `tem'.
6998
6999 * w32inevt.c (w32_console_read_socket):
7000 Remove unused variable `no_events'.
7001
7002 * w32term.c (x_draw_composite_glyph_string_foreground):
7003 Remove unused variable `width'.
7004
7005 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7006
7007 * w32term.c (x_set_glyph_string_clipping):
7008 Don't pass uninitialized region to CombineRgn.
7009
7010 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7013 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7014 (Fx_close_connection): Remove unused variable `i'.
7015
7016 * w32font.c (w32font_draw): Return number of glyphs.
7017 (w32font_open_internal): Remove unused variable `i'.
7018 (w32font_driver): Add missing initializer.
7019
7020 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7021 (fill_in_menu): Remove unused variable `items_added'.
7022
7023 * w32term.c (last_mouse_press_frame): Remove static global variable.
7024 (w32_clip_to_row): Remove unused variable `f'.
7025 (x_delete_terminal): Remove unused variable `i'.
7026
7027 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7028 (NOTHING): Remove unused static global variable.
7029 (uniscribe_check_otf): Remove unused variable `table'.
7030 (uniscribe_font_driver): Add missing initializers.
7031
7032 2011-03-23 Julien Danjou <julien@danjou.info>
7033
7034 * term.c (Fsuspend_tty, Fresume_tty):
7035 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7036 * window.c (temp_output_buffer_show):
7037 * insdel.c (signal_before_change):
7038 * frame.c (Fhandle_switch_frame):
7039 * fileio.c (Fdo_auto_save):
7040 * emacs.c (Fkill_emacs):
7041 * editfns.c (save_excursion_restore):
7042 * cmds.c (internal_self_insert):
7043 * callint.c (Fcall_interactively):
7044 * buffer.c (Fkill_all_local_variables):
7045 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7046 Use Frun_hooks.
7047 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7048 unconditionnaly since it does the check itself.
7049
7050 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7051
7052 Fix more problems found by GCC 4.5.2's static checks.
7053
7054 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7055 the first time through the loop, since we know p0 < p1 then.
7056 This also avoids a gcc -Wstrict-overflow warning.
7057
7058 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7059 leading to a memory leak, possible in functions like
7060 load_charset_map_from_file that can allocate an unbounded number
7061 of objects (Bug#8318).
7062
7063 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7064 that could (at least in theory) be that large.
7065
7066 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7067 This is less likely to overflow, and avoids undefined behavior if
7068 overflow does occur. All callers changed. Use strtoul to scan
7069 for the unsigned long integer.
7070 (pint2hrstr): Simplify and tune code slightly.
7071 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7072
7073 * scroll.c (do_scrolling): Work around GCC bug 48228.
7074 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7075
7076 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7077 This also avoids a warning with gcc -Wstrict-overflow.
7078 (validate_x_resource_name): Simplify count usage.
7079 This also avoids a warning with gcc -Wstrict-overflow.
7080
7081 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7082 fail (Bug#8306).
7083
7084 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7085
7086 * process.c (Fmake_network_process): Use socklen_t, not int,
7087 where POSIX says socklen_t is required in portable programs.
7088 This fixes a porting bug on hosts like 64-bit HP-UX, where
7089 socklen_t is wider than int (Bug#8277).
7090 (Fmake_network_process, server_accept_connection):
7091 (wait_reading_process_output, read_process_output):
7092 Likewise.
7093
7094 * process.c: Rename or move locals to avoid shadowing.
7095 (list_processes_1, Fmake_network_process):
7096 (read_process_output_error_handler, exec_sentinel_error_handler):
7097 Rename or move locals.
7098 (Fmake_network_process): Define label "retry_connect" only if needed.
7099 (Fnetwork_interface_info): Fix pointer signedness.
7100 (process_send_signal): Add cast to avoid pointer signedness problem.
7101 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7102 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7103
7104 Make tparam.h and terminfo.c consistent.
7105 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7106 Include tparam.h instead, since it declares them.
7107 * cm.h (PC): Remove extern decl; tparam.h now does this.
7108 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7109 * terminfo.c: Include tparam.h, to check interfaces.
7110 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7111 (tparam): Adjust signature to match interface in tparam.h;
7112 this removes some undefined behavior. Check that outstring and len
7113 are zero, which they always are with Emacs.
7114 * tparam.h (PC, BC, UP): New extern decls.
7115
7116 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7117 (xftfont_open): Rename locals to avoid shadowing.
7118
7119 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7120 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7121 (OTF_TAG_SYM): Omit macro if not needed.
7122 (ftfont_list): Remove unused local.
7123 (get_adstyle_property, ftfont_pattern_entity):
7124 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7125 Rename locals to avoid shadowing.
7126
7127 * xfont.c (xfont_list_family): Mark var as initialized.
7128
7129 * xml.c (make_dom): Now static.
7130
7131 * composite.c (composition_compute_stop_pos): Rename local to
7132 avoid shadowing.
7133 (composition_reseat_it): Remove unused locals.
7134 (find_automatic_composition, composition_adjust_point): Likewise.
7135 (composition_update_it): Mark var as initialized.
7136 (find_automatic_composition): Mark vars as initialized,
7137 with a FIXME (Bug#8290).
7138
7139 character.h: Rename locals to avoid shadowing.
7140 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7141 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7142 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7143 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7144 to avoid shadowing.
7145
7146 * textprop.c (property_change_between_p): Remove; unused.
7147
7148 * intervals.c (interval_start_pos): Now static.
7149
7150 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7151
7152 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7153 Rename locals to avoid shadowing.
7154
7155 * sound.c (wav_play, au_play, Fplay_sound_internal):
7156 Fix pointer signedness.
7157 (alsa_choose_format): Remove unused local var.
7158 (wav_play): Initialize a variable to 0, to prevent undefined
7159 behavior (Bug#8278).
7160
7161 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7162
7163 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7164
7165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7166 clobbering (Bug#8298).
7167 * sysdep.c (sys_subshell): Likewise.
7168 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7169
7170 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7171 This should get cleaned up, so that child_setup has the
7172 same signature on all platforms.
7173
7174 * callproc.c (call_process_cleanup): Now static.
7175 (relocate_fd): Rename locals to avoid shadowing.
7176
7177 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7178
7179 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7180 not to be necessary, and produces flickering.
7181
7182 2011-03-20 Glenn Morris <rgm@gnu.org>
7183
7184 * config.in: Remove file.
7185
7186 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7189 are now in src/globals.h.
7190 (syms_of_minibuf): Remove spurious & from previous change.
7191
7192 2011-03-20 Leo <sdl.web@gmail.com>
7193
7194 * minibuf.c (completing-read-function): New variable.
7195 (completing-read-default): Rename from completing-read.
7196 (completing-read): Call completing-read-function.
7197
7198 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7199
7200 * xfaces.c (Fx_load_color_file):
7201 Read color file from absolute filename (bug#8250).
7202
7203 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7204
7205 * makefile.w32-in: Update dependencies.
7206
7207 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7208
7209 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7210
7211 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7212
7213 Fix more problems found by GCC 4.5.2's static checks.
7214
7215 * process.c (make_serial_process_unwind, send_process_trap):
7216 (sigchld_handler): Now static.
7217
7218 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7219 That way, the code declares only the vars that it needs.
7220 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7221 * s/cygwin.h (PTY_ITERATION): Likewise.
7222 * s/darwin.h (PTY_ITERATION): Likewise.
7223 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7224
7225 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7226 * process.c (allocate_pty): Don't declare stb unless it's needed.
7227
7228 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7229 (CONSTANTLIM): Remove; unused.
7230 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7231 Define only if needed.
7232
7233 * unexelf.c (unexec): Name an expression,
7234 to avoid gcc -Wbad-function-cast warning.
7235 Use a different way to cause a compilation error if anyone uses
7236 n rather than nn, a way that does not involve shadowing.
7237 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7238
7239 * deps.mk (unexalpha.o): Remove; unused.
7240
7241 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7242 * unexec.h: New file.
7243 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7244 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7245 Depend on unexec.h.
7246 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7247 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7248 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7249 Change as necessary to match prototype in unexec.h.
7250
7251 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7252 shadowing.
7253 (back_comment, skip_chars): Mark vars as initialized.
7254
7255 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7256 Rename locals to avoid shadowing.
7257
7258 * lread.c (read1): Rewrite so as not to use empty "else".
7259 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7260
7261 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7262
7263 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7264 warning when compiling print.c.
7265
7266 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7267 instead of using an uninitialized var.
7268 (font_sort_entities): Mark var as initialized.
7269
7270 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7271
7272 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7273 pointers to constants.
7274 (font_parse_fcname): Remove unused vars.
7275 (font_delete_unmatched): Now static.
7276 (font_get_spec): Remove; unused.
7277 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7278 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7279 Rename or move locals to avoid shadowing.
7280
7281 * fns.c (require_nesting_list, require_unwind): Now static.
7282 (Ffillarray): Rename locals to avoid shadowing.
7283
7284 * floatfns.c (domain_error2): Define only if needed.
7285 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7286
7287 * alloc.c (mark_backtrace): Move decl from here ...
7288 * lisp.h: ... to here, so that it can be checked.
7289
7290 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7291 (Fdefvar): Rewrite so as not to use empty "else".
7292 (lisp_indirect_variable): Name an expression,
7293 to avoid gcc -Wbad-function-cast warning.
7294 (Fdefvar): Rename locals to avoid shadowing.
7295
7296 * callint.c (quotify_arg, quotify_args): Now static.
7297 (Fcall_interactively): Rename locals to avoid shadowing.
7298 Use const pointer when appropriate.
7299
7300 * lisp.h (get_system_name, get_operating_system_release):
7301 Move decls here, to check interfaces.
7302 * process.c (get_operating_system_release): Move decl to lisp.h.
7303 * xrdb.c (get_system_name): Likewise.
7304 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7305 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7306 some of which prompt warnings from gcc -Wbad-function-cast.
7307 (Fformat_time_string, Fencode_time, Finsert_char):
7308 (Ftranslate_region_internal, Fformat):
7309 Rename or remove local vars to avoid shadowing.
7310 (Ftranslate_region_internal): Mark var as initialized.
7311
7312 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7313 avoid shadowing.
7314
7315 * lisp.h (eassert): Check that the argument compiles, even if
7316 ENABLE_CHECKING is not defined.
7317
7318 * data.c (Findirect_variable): Name an expression, to avoid
7319 gcc -Wbad-function-cast warning.
7320 (default_value, arithcompare, arith_driver, arith_error): Now static.
7321 (store_symval_forwarding): Rename local to avoid shadowing.
7322 (Fmake_variable_buffer_local, Fmake_local_variable):
7323 Mark variables as initialized.
7324 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7325
7326 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7327 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7328 Rename locals to avoid shadowing.
7329 (mark_stack): Move local variables into the #ifdef region where
7330 they're used.
7331 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7332 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7333 needed otherwise.
7334 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7335 (GC_STRING_CHARS): Remove; not used.
7336 (Fmemory_limit): Cast sbrk's returned value to char *.
7337
7338 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7339 avoids undefined behavior in theory.
7340
7341 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7342
7343 Use functions, not macros, for up- and down-casing (Bug#8254).
7344 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7345 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7346 to use the following functions instead of these macros.
7347 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7348 EMACS_INT, since callers assume the returned value fits in int.
7349 (upcase1): Likewise, for UPCASE_TABLE.
7350 (uppercasep, lowercasep, upcase): New static inline functions.
7351 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7352 the race-condition problem in the old DOWNCASE.
7353
7354 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7355 Rename locals to avoid shadowing.
7356 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7357 (regex_compile, re_search_2, re_match_2_internal):
7358 Remove unused local vars.
7359 (FREE_VAR): Rewrite so as not to use empty "else",
7360 which gcc can warn about.
7361 (regex_compile, re_match_2_internal): Mark locals as initialized.
7362 (RETALLOC_IF): Define only if needed.
7363 (WORDCHAR_P): Likewise. This one is never needed, but is used
7364 only in a comment talking about a compiler bug, so put inside
7365 the #if 0 of that comment.
7366 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7367 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7368 Remove; unused.
7369
7370 * search.c (boyer_moore): Rename locals to avoid shadowing.
7371 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7372 (PREV_CHAR_BOUNDARY): Likewise.
7373
7374 * search.c (simple_search): Remove unused var.
7375
7376 * dired.c (compile_pattern): Move decl from here ...
7377 * lisp.h: ... to here, so that it can be checked.
7378 (struct re_registers): New forward decl.
7379
7380 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7381
7382 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7383 All uses changed.
7384 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7385 Rename locals to avoid shadowing.
7386 (Fvertical_motion): Mark locals as initialized.
7387
7388 * casefiddle.c (casify_object, casify_region): Now static.
7389 (casify_region): Mark local as initialized.
7390
7391 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7392
7393 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7394 New macros, so that the caller can use some names other than
7395 gcpro1, gcpro2, etc.
7396 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7397 of the new macros.
7398 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7399 argument, for consistency with GCPRO2_VAR, etc: it is now the
7400 prefix of the variable, not the variable itself. All uses
7401 changed.
7402 * dired.c (directory_files_internal, file_name_completion):
7403 Rename locals to avoid shadowing.
7404
7405 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7406 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7407 dired.c's scmp function, had undefined behavior.
7408 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7409 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7410 * buffer.h: ... to here, because these macros use current_buffer,
7411 and the new implementation with inline functions needs to have
7412 current_buffer in scope now, rather than later when the macros
7413 are used.
7414 (downcase, upcase1): New static inline functions.
7415 (DOWNCASE, UPCASE1): Reimplement using these functions.
7416 This avoids undefined behavior in expressions like
7417 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7418 from race conditions in accessing the global variables
7419 case_temp1 and case_temp2.
7420 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7421 * lisp.h (case_temp1, case_temp2): Remove their decls.
7422 * character.h (ASCII_CHAR_P): Move from here ...
7423 * lisp.h: ... to here, so that the inline functions mentioned
7424 above can use them.
7425
7426 * dired.c (directory_files_internal_unwind): Now static.
7427
7428 * fileio.c (file_name_as_directory, directory_file_name):
7429 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7430 Now static.
7431 (file_name_as_directory): Use const pointers when appropriate.
7432 (Fexpand_file_name): Likewise. In particular, newdir might
7433 point at constant storage, so make it a const pointer.
7434 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7435 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7436 signedness issues.
7437 (Fset_file_times, Finsert_file_contents, auto_save_error):
7438 Rename locals to avoid shadowing.
7439
7440 * minibuf.c (choose_minibuf_frame_1): Now static.
7441 (Ftry_completion, Fall_completions): Rename or remove locals
7442 to avoid shadowing.
7443
7444 * marker.c (bytepos_to_charpos): Remove; unused.
7445
7446 * lisp.h (verify_bytepos, count_markers): New decls,
7447 so that gcc does not warn that these functions aren't declared.
7448
7449 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7450 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7451 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7452 (copy_text): Remove unused local var.
7453
7454 * filelock.c (within_one_second): Now static.
7455 (lock_file_1): Rename local to avoid shadowing.
7456
7457 * buffer.c (fix_overlays_before): Mark locals as initialized.
7458 (fix_start_end_in_overlays): Likewise. This function should be
7459 simplified by using pointers-to-pointers, but that's a different
7460 matter.
7461 (switch_to_buffer_1): Now static.
7462 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7463 (report_overlay_modification): Rename locals to avoid shadowing.
7464
7465 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7466 Fix pointer signedness issue.
7467 (sys_subshell): Mark local as volatile if checking for lint,
7468 to suppress a gcc -Wclobbered warning that does not seem to be right.
7469 (MAXPATHLEN): Define only if needed.
7470
7471 * process.c (serial_open, serial_configure): Move decls from here ...
7472 * systty.h: ... to here, so that they can be checked.
7473
7474 * fns.c (get_random, seed_random): Move extern decls from here ...
7475 * lisp.h: ... to here, so that they can be checked.
7476
7477 * sysdep.c (reset_io): Now static.
7478 (wait_for_termination_signal): Remove; unused.
7479
7480 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7481 (copy_keymap_item, append_key, push_text_char_description):
7482 Now static.
7483 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7484 (DENSE_TABLE_SIZE): Remove; unused.
7485 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7486 (describe_map_tree):
7487 Rename locals to avoid shadowing.
7488
7489 * keyboard.c: Declare functions static if they are not used elsewhere.
7490 (echo_char, echo_dash, cmd_error, top_level_2):
7491 (poll_for_input, handle_async_input): Now static.
7492 (read_char, kbd_buffer_get_event, make_lispy_position):
7493 (make_lispy_event, make_lispy_movement, apply_modifiers):
7494 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7495 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7496 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7497 (read_key_sequence, read_char): Mark locals as initialized.
7498 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7499
7500 * keyboard.h (make_ctrl_char): New decl.
7501 (mark_kboards): Move decl here ...
7502 * alloc.c (mark_kboards): ... from here.
7503
7504 * lisp.h (force_auto_save_soon): New decl.
7505
7506 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7507 (DEFINE_DUMMY_FUNCTION): New macro.
7508 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7509 Use it.
7510 (main): Add casts to avoid warnings
7511 if GCC considers string literals to be constants.
7512
7513 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7514
7515 * dbusbind.c: Pointer signedness fixes.
7516 (xd_signature, xd_append_arg, xd_initialize):
7517 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7518 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7519 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7520 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7521
7522 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7523 if GCC considers string literals to be constants.
7524 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7525
7526 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7529 (print_preprocess, print_object): New macro to fix last change.
7530
7531 * print.c (print_preprocess): Don't forget font objects.
7532
7533 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7534
7535 * emacs.c (USAGE3): Doc fixes.
7536
7537 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7538
7539 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7540 structure.
7541
7542 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7543
7544 * lisp.h (VWindow_system, Qfile_name_history):
7545 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7546 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7547 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7548
7549 * w32select.c: Don't #include "keyboard.h".
7550 (run_protected): Add extern declaration for waiting_for_input.
7551
7552 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7553 * w32console.c (detect_input_pending, read_input_pending)
7554 (encode_terminal_code):
7555 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7556 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7557 (w32_system_caret_y, Qfile_name_history):
7558 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7559 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7560 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7561 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7562 * w32proc.c (Qlocal, report_file_error):
7563 * w32term.c (Vwindow_system, updating_frame):
7564 * w32uniscribe.c (initialized, uniscribe_font_driver):
7565 Remove unneeded extern declarations.
7566
7567 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7568
7569 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7570
7571 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7572
7573 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7574 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7575 These macros can no longer be used for assignment.
7576
7577 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7578 Assign struct members directly, instead of using BUF_BEGV etc.
7579 (record_buffer_markers, fetch_buffer_markers): New functions for
7580 recording and fetching special buffer markers.
7581 (set_buffer_internal_1, set_buffer_temp): Use them.
7582
7583 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7584
7585 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7586
7587 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7588 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7589
7590 * xdisp.c (hscroll_window_tree):
7591 (reconsider_clip_changes): Use PT instead of BUF_PT.
7592
7593 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7594
7595 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7596 $(EMACS_ROOT)/lib/intprops.h.
7597
7598 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7599
7600 Fix more problems found by GCC 4.5.2's static checks.
7601
7602 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7603 to unsigned char * to avoid compiler diagnostic.
7604 (xg_free_frame_widgets): Make it clear that a local variable is
7605 needed only if USE_GTK_TOOLTIP.
7606 (gdk_window_get_screen): Make it clear that this macro is needed
7607 only if USE_GTK_TOOLTIP.
7608 (int_gtk_range_get_value): New function, which avoids a diagnostic
7609 from gcc -Wbad-function-cast.
7610 (xg_set_toolkit_scroll_bar_thumb): Use it.
7611 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7612 diagnostic from gcc -Wbad-function-cast.
7613 (get_utf8_string, xg_get_file_with_chooser):
7614 Rename locals to avoid shadowing.
7615 (create_dialog): Move locals to avoid shadowing.
7616
7617 * xgselect.c (xg_select): Remove unused var.
7618
7619 * image.c (four_corners_best): Mark locals as initialized.
7620 (gif_load): Initialize transparent_p to zero (Bug#8238).
7621 Mark another local as initialized.
7622 (my_png_error, my_error_exit): Mark with NO_RETURN.
7623
7624 * image.c (clear_image_cache): Now static.
7625 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7626 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7627 (x_edge_detection): Remove unnecessary cast that
7628 gcc -Wbad-function-cast diagnoses.
7629 (gif_load): Fix pointer signedness.
7630 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7631 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7632
7633 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7634
7635 Improve quality of tests for time stamp overflow.
7636 For example, without this patch (encode-time 0 0 0 1 1
7637 1152921504606846976) returns the obviously-bogus value (-948597
7638 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7639 reports time overflow. See
7640 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7641 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7642 * editfns.c: Include limits.h and intprops.h.
7643 (TIME_T_MIN, TIME_T_MAX): New macros.
7644 (time_overflow): Move earlier, to before first use.
7645 (hi_time, lo_time): New functions, for an accurate test for
7646 out-of-range times.
7647 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7648 (Fget_internal_run_time): Don't assume time_t fits in int.
7649 (make_time): Use list2 instead of Fcons twice.
7650 (Fdecode_time): More accurate test for out-of-range times.
7651 (check_tm_member): New function.
7652 (Fencode_time): Use it, to test for out-of-range times.
7653 (lisp_time_argument): Don't rely on undefined left-shift and
7654 right-shift behavior when checking for time stamp overflow.
7655
7656 * editfns.c (time_overflow): New function, refactoring common code.
7657 (Fformat_time_string, Fdecode_time, Fencode_time):
7658 (Fcurrent_time_string): Use it.
7659
7660 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7661 * dired.c (make_time): Move to ...
7662 * editfns.c (make_time): ... here.
7663 * systime.h: Note the move.
7664
7665 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7666
7667 * fringe.c (update_window_fringes): Remove unused variables.
7668
7669 * unexmacosx.c (copy_data_segment): Also copy __got section.
7670 (Bug#8223)
7671
7672 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7673
7674 * termcap.c [MSDOS]: Include "msdos.h".
7675 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7676 Constify `char *' arguments and their references according to
7677 prototypes in tparam.h.
7678
7679 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7680
7681 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7682 Adapt all references accordingly.
7683
7684 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7685
7686 2011-03-11 Tom Tromey <tromey@redhat.com>
7687
7688 * buffer.c (syms_of_buffer): Remove obsolete comment.
7689
7690 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7691
7692 * termhooks.h (encode_terminal_code): Declare prototype.
7693
7694 * msdos.c (encode_terminal_code): Don't declare prototype.
7695
7696 * term.c (encode_terminal_code): Now external again, used by
7697 w32console.c and msdos.c.
7698
7699 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7700 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7701
7702 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7703
7704 Fix some minor problems found by GCC 4.5.2's static checks.
7705
7706 * fringe.c (update_window_fringes): Mark locals as initialized
7707 (Bug#8227).
7708 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7709
7710 * alloc.c (mark_fringe_data): Move decl from here ...
7711 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7712 to check its interface.
7713 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7714
7715 * fontset.c (free_realized_fontset): Now static.
7716 (Fset_fontset_font): Rename local to avoid shadowing.
7717 (fontset_font): Mark local as initialized.
7718 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7719
7720 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7721
7722 * xselect.c (x_disown_buffer_selections): Remove; not used.
7723 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7724 (x_own_selection, Fx_disown_selection_internal): Rename locals
7725 to avoid shadowing.
7726 (x_handle_dnd_message): Remove local to avoid shadowing.
7727
7728 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7729 so that the caller can use some name other than gcpro1.
7730 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7731 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7732 (Fx_backspace_delete_keys_p):
7733 Use them to avoid shadowing, and rename vars to avoid shadowing.
7734 (x_decode_color, x_set_name, x_window): Now static.
7735 (Fx_create_frame): Add braces to silence GCC warning.
7736 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7737 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7738 Remove unused locals.
7739 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7740 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7741 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7742 macros.
7743
7744 * xterm.h (x_mouse_leave): New decl.
7745
7746 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7747 Remove unused functions.
7748 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7749 (x_calc_absolute_position): Now static.
7750 (XTread_socket): Don't define label "out" unless it's used.
7751 Don't declare local "event" unless it's used.
7752 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7753 unless they are used.
7754 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7755 (x_fatal_error_signal): Remove; not used.
7756 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7757 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7758 (x_error_catcher, x_connection_closed, x_error_handler):
7759 (x_error_quitter, xembed_send_message, x_iconify_frame):
7760 (my_log_handler): Rename locals to avoid shadowing.
7761 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7762 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7763
7764 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7765 Rename or move locals to avoid shadowing.
7766 (tty_defined_color, merge_face_heights): Now static.
7767 (free_realized_faces_for_fontset): Remove; not used.
7768 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7769 does not deduce is never used uninitialized.
7770 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7771 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7772
7773 * terminal.c (store_terminal_param): Now static.
7774
7775 * xmenu.c (menu_highlight_callback): Now static.
7776 (set_frame_menubar): Remove unused local.
7777 (xmenu_show): Rename parameter to avoid shadowing.
7778 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7779 since they might point to immutable storage.
7780 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7781 since it's unused otherwise.
7782
7783 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7784 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7785 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7786 avoids a gcc -Wuninitialized diagnostic.
7787 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7788 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7789 does not deduce are never used uninitialized.
7790
7791 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7792
7793 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7794 * window.c (window_loop, size_window):
7795 (run_window_configuration_change_hook, enlarge_window): Likewise.
7796
7797 * window.c (display_buffer): Now static.
7798 (size_window): Mark variables that gcc -Wuninitialized
7799 does not deduce are never used uninitialized.
7800 * window.h (check_all_windows): New decl, to forestall
7801 gcc -Wmissing-prototypes diagnostic.
7802 * dispextern.h (bidi_dump_cached_states): Likewise.
7803
7804 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7805 shadowing.
7806 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7807 Include <limits.h>.
7808 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7809 and to avoid gcc -Wuninitialized warning.
7810 (load_charset_map): Mark variables that gcc -Wuninitialized
7811 does not deduce are never used uninitialized.
7812 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7813
7814 * coding.c (coding_set_source, coding_set_destination):
7815 Use "else { /* comment */ }" rather than "else /* comment */;"
7816 for clarity, and to avoid gcc -Wempty-body warning.
7817 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7818 a block, when the outer 'i' will do.
7819 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7820 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7821 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7822 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7823 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7824 Rename locals to avoid shadowing.
7825 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7826 * coding.c (emacs_mule_char, encode_invocation_designation):
7827 Now static, since they're not used elsewhere.
7828 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7829 (decode_coding_object, encode_coding_object, detect_coding_system):
7830 (decode_coding_emacs_mule): Mark variables that gcc
7831 -Wuninitialized does not deduce are never used uninitialized.
7832 (detect_coding_iso_2022): Initialize a local variable that might
7833 be used uninitialized. Leave a FIXME because it's not clear that
7834 this initialization is needed. (Bug#8211)
7835 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7836 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7837 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7838 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7839 Remove unused macros.
7840
7841 * category.c (hash_get_category_set): Remove unused local var.
7842 (copy_category_table): Now static, since it's not used elsewhere.
7843 * character.c (string_count_byte8): Likewise.
7844
7845 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7846 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7847
7848 * chartab.c (copy_sub_char_table): Now static, since it's not used
7849 elsewhere.
7850 (sub_char_table_ref_and_range, char_table_ref_and_range):
7851 Rename locals to avoid shadowing.
7852 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7853
7854 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7855 (BIDI_BOB): Remove unused macro.
7856
7857 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7858 deduce are never used uninitialized.
7859 * term.c (encode_terminal_code): Likewise.
7860
7861 * term.c (encode_terminal_code): Now static. Remove unused local.
7862
7863 * tparam.h: New file.
7864 * term.c, tparam.h: Include it.
7865 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7866 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7867 Move these decls to tparam.h, and make them agree with what
7868 is actually in tparam.c. The previous trick of using incompatible
7869 decls in different modules does not conform to the C standard.
7870 All callers of tparam changed to use tparam's actual API.
7871 * tparam.c (tparam1, tparam, tgoto):
7872 Use const pointers where appropriate.
7873
7874 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7875 * cm.h (struct cm): Likewise.
7876 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7877 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7878 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7879 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7880 (turn_on_face, init_tty): Likewise.
7881 * termchar.h (struct tty_display_info): Likewise.
7882
7883 * term.c (term_mouse_position): Rename local to avoid shadowing.
7884
7885 * alloc.c (mark_ttys): Move decl from here ...
7886 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7887
7888 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7889
7890 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7891
7892 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7893
7894 * search.c (compile_pattern_1): Remove argument regp, unused since
7895 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7896 (compile_pattern): Don't pass it.
7897
7898 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7899
7900 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7901 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7902 for ! HAVE_GTK3.
7903 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7904
7905 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7906
7907 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7908 gdk_window_get_screen, gdk_window_get_geometry,
7909 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7910 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7911 (xg_get_pixbuf_from_pixmap): New function.
7912 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7913 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7914 Call xg_get_pixbuf_from_pixmap instead of
7915 gdk_pixbuf_get_from_drawable.
7916 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7917 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7918 (xg_check_special_colors): Use GtkStyleContext and its functions
7919 for HAVE_GTK3.
7920 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7921 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7922 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7923 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7924 Call gtk_widget_get_preferred_size.
7925 (xg_frame_resized): gdk_window_get_geometry only takes 5
7926 parameters.
7927 (xg_win_to_widget, xg_event_is_for_menubar):
7928 Call gdk_x11_window_lookup_for_display.
7929 (xg_set_widget_bg): New function.
7930 (delete_cb): New function.
7931 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7932 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7933 (xg_set_background_color): Call xg_set_widget_bg.
7934 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7935 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7936 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7937 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7938 if ! HAVE_GTK3.
7939 (update_frame_tool_bar): Call gtk_widget_hide.
7940 (xg_initialize): Use GDK_KEY_g.
7941
7942 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7943 if ! HAVE_GTK3
7944 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7945
7946 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7947 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7948 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7949
7950 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * w32xfns.c (select_palette): Check success of RealizePalette against
7953 GDI_ERROR, not zero.
7954
7955 See ChangeLog.11 for earlier changes.
7956
7957 ;; Local Variables:
7958 ;; coding: utf-8
7959 ;; End:
7960
7961 Copyright (C) 2011 Free Software Foundation, Inc.
7962
7963 This file is part of GNU Emacs.
7964
7965 GNU Emacs is free software: you can redistribute it and/or modify
7966 it under the terms of the GNU General Public License as published by
7967 the Free Software Foundation, either version 3 of the License, or
7968 (at your option) any later version.
7969
7970 GNU Emacs is distributed in the hope that it will be useful,
7971 but WITHOUT ANY WARRANTY; without even the implied warranty of
7972 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7973 GNU General Public License for more details.
7974
7975 You should have received a copy of the GNU General Public License
7976 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.