1 2012-05-21 Eli Zaretskii <eliz@gnu.org>
3 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6 2012-05-19 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
9 state after an additional call to move_it_in_display_line_to, keep
10 the values of it->max_ascent and it->max_descent found for the
12 (pos_visible_p): Revert the comparison against bottom_y to what it
13 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
16 2012-05-15 Eli Zaretskii <eliz@gnu.org>
18 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
20 2012-05-13 Eli Zaretskii <eliz@gnu.org>
22 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
23 already have overlays loaded.
24 (handle_single_display_spec): Before returning without displaying
25 fringe bitmap, synchronize the bidi iterator with the main display
26 iterator, by calling iterate_out_of_display_property.
27 (iterate_out_of_display_property): Detect buffer iteration by
28 testing that it->string is a Lisp string.
29 (get_next_display_element): When the current object is exhausted,
30 and there's something on it->stack, call set_iterator_to_next to
31 proceed with what's on the stack, instead of returning zero.
32 (set_iterator_to_next): If called at the end of a Lisp string,
33 proceed to consider_string_end without incrementing string
34 position. Don't increment display vector index past the end of
35 the display vector. (Bug#11417)
36 (pos_visible_p): Don't report a position visible when move_it_to
37 stopped at the last line of window, which happens to be scanned
38 backwards by the bidi iteration. (Bug#11464)
40 2012-05-11 Eli Zaretskii <eliz@gnu.org>
42 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
43 and right-margin display specs even if the spec is invalid or we
44 are on a TTY, and thus unable to display on the fringes. That's
45 because the text with the property will not be displayed anyway,
46 so we need to signal to the caller that this is a "replacing"
47 display spec. This fixes display when the spec is invalid or we
50 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
52 * unexaix.c (make_hdr): Fix typo in prototype.
53 This bug broke the build on AIX. Problem reported by Gilles Pion.
55 2012-05-05 Eli Zaretskii <eliz@gnu.org>
57 * w32proc.c (new_child): Force Windows to reserve only 64KB of
58 stack for each reader_thread, instead of defaulting to 8MB
59 determined by the linker. This avoids failures in creating
60 subprocesses on Windows 7, see the discussion in this thread:
61 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
63 2012-05-02 Jim Meyering <meyering@redhat.com>
65 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
67 2012-04-29 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (pos_visible_p): If already at a newline from the
70 display string before the 'while' loop, don't walk back the glyphs
71 from it3.glyph_row. Solves assertion violation when the display
72 string begins with a newline (egg.el). (Bug#11367)
74 2012-04-24 Chong Yidong <cyd@gnu.org>
76 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
78 2012-04-23 Eli Zaretskii <eliz@gnu.org>
80 * xdisp.c (pos_visible_p): If the window start position is beyond
81 ZV, start the display from buffer beginning. Prevents assertion
82 violation in init_iterator when the minibuffer window is scrolled
85 * window.c (window_scroll_pixel_based): Likewise.
87 2012-04-23 Chong Yidong <cyd@gnu.org>
89 * keymap.c (where_is_internal): Doc fix (Bug#10872).
91 2012-04-20 Glenn Morris <rgm@gnu.org>
93 * fileio.c (Fcopy_file, Fset_file_selinux_context):
94 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
96 2012-04-20 Eli Zaretskii <eliz@gnu.org>
98 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
99 overrun array limits of glyph row's used[] array. (Bug#11288)
101 2012-04-20 Chong Yidong <cyd@gnu.org>
103 * process.c (wait_reading_process_output): If EIO occurs on a pty,
104 set the status to "failed" and ensure that sentinel is run.
106 2012-04-18 Glenn Morris <rgm@gnu.org>
108 * process.c (Fset_process_inherit_coding_system_flag)
109 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
110 (Fmake_network_process, Fmake_serial_process): Doc fix.
112 2012-04-17 Eli Zaretskii <eliz@gnu.org>
114 * xdisp.c (string_buffer_position_lim): Limit starting position to
116 (set_cursor_from_row): If called for a mode-line or header-line
117 row, return zero immediately.
118 (try_cursor_movement): If inside continuation line, don't back up
119 farther than the first row after the header line, if any. Don't
120 consider the header-line row as "partially visible", even if
121 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
123 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
125 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
127 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
129 * process.c (make_process):
130 * process.h: Add integer `gnutls_handshakes_tried' member to
133 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
134 Add convenience `GNUTLS_LOG2i' macro.
136 * gnutls.c (gnutls_log_function2i): Convenience log function.
137 (emacs_gnutls_read): Use new log functions,
138 `gnutls_handshakes_tried' process member, and
139 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
140 attempts per process (connection).
142 2012-04-09 Eli Zaretskii <eliz@gnu.org>
144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
147 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
149 * nsterm.m (constrainFrameRect): Always constrain when there is only
150 one screen (Bug#10962).
152 2012-04-06 Eli Zaretskii <eliz@gnu.org>
154 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
155 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
156 about subtle differences between FETCH_CHAR* and STRING_CHAR*
157 macros related to unification of CJK characters. For the details,
158 see the discussion following the message here:
159 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
161 2012-04-04 Chong Yidong <cyd@gnu.org>
163 * keyboard.c (Vdelayed_warnings_list): Doc fix.
165 2012-04-01 Eli Zaretskii <eliz@gnu.org>
167 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
168 instead of alloca. (Bug#11138)
170 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
172 * w32menu.c (is_simple_dialog): Properly check lisp types.
175 2012-03-31 Eli Zaretskii <eliz@gnu.org>
177 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
178 position we get to after a call to move_it_to fails the
179 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
180 only if we wind up in a string from display property. (Bug#11063)
182 * window.c (Fdelete_other_windows_internal): Invalidate the row
183 and column information about mouse highlight, so that redisplay
184 restores it after reallocating the glyph matrices. (Bug#7464)
186 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
187 string comes from a `display' text property, use the buffer
188 position of that property as if we actually saw that position in
190 (move_it_by_lines): Remove the assertion that
191 "it->current_x == 0 && it->hpos == 0" which can be legitimately
192 violated when there's a before-string at the beginning of a line.
195 2012-03-30 Eli Zaretskii <eliz@gnu.org>
197 * xdisp.c (append_space_for_newline): If the default face was
198 remapped, use the remapped face for the appended newline.
199 (extend_face_to_end_of_line): Use the remapped default face for
200 extending the face to the end of the line.
201 (display_line): Call extend_face_to_end_of_line when the default
202 face was remapped. (Bug#11068)
204 2012-03-29 Eli Zaretskii <eliz@gnu.org>
206 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
208 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
210 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
212 2012-03-27 Glenn Morris <rgm@gnu.org>
214 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
217 2012-03-26 Kenichi Handa <handa@m17n.org>
219 * dispextern.h (struct glyph): Fix previous change. Change the
220 bit length of glyphless.ch to 25 (Bug#11082).
222 2012-03-26 Chong Yidong <cyd@gnu.org>
224 * keyboard.c (Vselection_inhibit_update_commands): New variable.
225 (command_loop_1): Use it; inhibit selection update for
226 handle-select-window too (Bug#8996).
228 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
230 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
232 2012-03-25 Kenichi Handa <handa@m17n.org>
234 * dispextern.h (struct glyph): Change the bit length of
235 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
237 2012-03-24 Eli Zaretskii <eliz@gnu.org>
239 * s/ms-w32.h (tzname): Include time.h before redirecting to
240 _tzname. Fixes the MSVC build. (Bug#9960)
242 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
244 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
247 * xterm.c (XTread_socket): Only modify handling_signal if
248 !SYNC_INPUT. (Bug#11080)
250 2012-03-23 Eli Zaretskii <eliz@gnu.org>
252 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
253 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
254 when fetching a multibyte character consumes more bytes than
255 CHAR_BYTES returns, due to unification of CJK characters in
256 string_char. (Bug#11073)
258 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
260 * process.c (wait_reading_process_output): Handle pty disconnect
261 by refraining from sending oneself a SIGCHLD (bug#10933).
263 2012-03-22 Chong Yidong <cyd@gnu.org>
265 * dispextern.h (struct it): New member string_from_prefix_prop_p.
267 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
268 Mark string as coming from a prefix property.
269 (handle_face_prop): Use default face for prefix strings (Bug#4281).
270 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
272 2012-03-21 Chong Yidong <cyd@gnu.org>
274 * xfaces.c (Vface_remapping_alist): Doc fix.
276 2012-03-20 Eli Zaretskii <eliz@gnu.org>
278 * w32proc.c (Fw32_set_console_codepage)
279 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
282 2012-03-20 Chong Yidong <cyd@gnu.org>
284 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
285 to reflect default non-nil value of redisplay-dont-pause.
287 2012-03-19 Kenichi Handa <handa@m17n.org>
289 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
290 it fit in a valid range (Bug#11003).
292 2012-03-18 Eli Zaretskii <eliz@gnu.org>
294 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
295 that is not from display property, accept the row as a "cursor
296 row" if one of the string's character has a non-nil `cursor'
297 property. Fixes cursor positioning when there are newlines in
298 overlay strings, e.g. in icomplete.el. (Bug#11035)
300 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
302 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
304 2012-03-12 Chong Yidong <cyd@gnu.org>
306 * eval.c (inhibit_lisp_code): Rename from
307 inhibit_window_configuration_change_hook; move from window.c.
309 * xfns.c (unwind_create_frame_1, Fx_create_frame):
310 * window.c (run_window_configuration_change_hook)
311 (syms_of_window): Callers changed.
313 2012-03-11 Chong Yidong <cyd@gnu.org>
315 * keymap.c (Fkey_description): Doc fix (Bug#9700).
317 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
319 2012-03-10 Chong Yidong <cyd@gnu.org>
321 * frame.c (other_visible_frames): Don't assume the selected frame
322 is visible (Bug#10955).
324 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
326 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
328 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
330 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
331 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
334 2012-03-03 Glenn Morris <rgm@gnu.org>
336 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
338 2012-03-02 Eli Zaretskii <eliz@gnu.org>
340 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
341 position past the first glyph_row that ends at ZV. (Bug#10902)
342 (redisplay_window, next_element_from_string): Fix typos in
344 (redisplay_window): Pass to move_it_vertically the margin in
345 pixels, not in screen lines.
347 2012-03-02 Glenn Morris <rgm@gnu.org>
349 * buffer.c (buffer-list-update-hook): Doc fix.
351 2012-02-29 Eli Zaretskii <eliz@gnu.org>
353 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
354 push_it before setting up the iterator for the first overlay
355 string, even if we have an empty string loaded.
356 (next_overlay_string): If there's an empty string on the iterator
357 stack, pop the stack. (Bug#10903)
359 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
361 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
362 Suggested by Stefan Monnier in
363 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
364 * alloc.c (widen_to_Lisp_Object): New static function.
365 (mark_memory): Also mark Lisp_Objects by fetching pointer words
366 and widening them to Lisp_Objects. This would work even if
367 USE_LSB_TAG is defined and wide integers are used, which might
368 happen in a future version of Emacs.
370 2012-02-25 Chong Yidong <cyd@gnu.org>
372 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
375 * xselect.c (Fx_selection_exists_p): Doc fix.
376 (x_clipboard_manager_save_all): Print an informative message
377 before saving to clipboard manager.
379 2012-02-24 Chong Yidong <cyd@gnu.org>
381 * keyboard.c (process_special_events): Handle all X selection
382 requests in kbd_buffer, not just the next one (Bug#8869).
384 2012-02-23 Chong Yidong <cyd@gnu.org>
386 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
387 call when setting menu-bar-lines and tool-bar-lines parameters.
388 (unwind_create_frame_1): New helper function.
390 * window.c (inhibit_window_configuration_change_hook): New var.
391 (run_window_configuration_change_hook): Obey it.
392 (syms_of_window): Initialize it.
394 2012-02-22 Chong Yidong <cyd@gnu.org>
396 * xterm.c (x_draw_image_relief): Add missing type check for
397 Vtool_bar_button_margin (Bug#10743).
399 2012-02-21 Chong Yidong <cyd@gnu.org>
401 * fileio.c (Vfile_name_handler_alist): Doc fix.
403 * buffer.c (Fget_file_buffer): Protect against invalid file
404 handler return value.
406 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
408 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
409 when computing $valmask.
411 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
412 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
413 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
414 It's useless in that case, and it can cause problems on hosts
415 that allocate halves of EMACS_INT values separately.
416 Reported by Dan Horák. Diagnosed by Andreas Schwab in
417 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
418 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
419 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
420 it avoids undefined behavior on hosts where shifting right by more
421 than the word width has undefined behavior.
423 2012-02-19 Chong Yidong <cyd@gnu.org>
425 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
426 (Funhandled_file_name_directory, Ffile_name_as_directory)
427 (Fdirectory_file_name, Fexpand_file_name)
428 (Fsubstitute_in_file_name): Protect against invalid file handler
429 return values (Bug#10845).
431 2012-02-18 Eli Zaretskii <eliz@gnu.org>
433 * .gdbinit (pitx): Fix incorrect references to fields of the
436 2012-02-17 Chong Yidong <cyd@gnu.org>
438 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
440 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
442 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
443 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
445 2012-02-15 Chong Yidong <cyd@gnu.org>
447 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
448 marked as special. Also, starting docstrings with * is obsolete.
450 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
452 * gnutls.c (emacs_gnutls_write): Fix last change.
454 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
456 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
459 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
461 * keymap.c (Fsingle_key_description): Handle char ranges.
463 2012-02-12 Chong Yidong <cyd@gnu.org>
465 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
466 as that creates a dangerous corner case.
468 * window.c (Fdelete_window_internal): Invalidate the mouse
469 highlight (Bug#9904).
471 2012-02-12 Glenn Morris <rgm@gnu.org>
473 * xselect.c (Fx_own_selection_internal)
474 (Fx_get_selection_internal, Fx_disown_selection_internal)
475 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
476 * nsselect.m (Fx_own_selection_internal)
477 (Fx_disown_selection_internal, Fx_selection_exists_p)
478 (Fx_selection_owner_p, Fx_get_selection_internal):
479 Sync docs and argument specs with the xselect.c versions.
481 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
483 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
485 2012-02-11 Eli Zaretskii <eliz@gnu.org>
487 * w32select.c (Fx_selection_exists_p): Sync doc string and
488 argument list with xselect.c. (Bug#10783)
490 * w16select.c (Fx_selection_exists_p): Sync doc string and
491 argument list with xselect.c. (Bug#10783)
493 2012-02-10 Glenn Morris <rgm@gnu.org>
495 * fns.c (Fsecure_hash): Doc fix.
497 2012-02-09 Kenichi Handa <handa@m17n.org>
499 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
501 2012-02-07 Chong Yidong <cyd@gnu.org>
503 * buffer.c (Fbuffer_local_variables)
504 (buffer_lisp_local_variables): Handle unbound vars correctly;
505 don't let Qunbound leak into Lisp.
507 2012-02-07 Glenn Morris <rgm@gnu.org>
509 * image.c (Fimagemagick_types): Doc fix.
511 * image.c (imagemagick-render-type): Change it from a lisp object
512 to an integer. Move the doc here from the lisp manual.
513 Treat all values not equal to 0 the same.
515 2012-02-06 Chong Yidong <cyd@gnu.org>
517 * doc.c (store_function_docstring): Avoid applying docstring of
518 alias to base function (Bug#2603).
520 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
522 * .gdbinit (pp1, pv1): Remove redundant defines.
525 2012-02-04 Chong Yidong <cyd@gnu.org>
527 * nsterm.m: Declare a global (Bug#10694).
529 2012-02-04 Eli Zaretskii <eliz@gnu.org>
531 * w32.c (get_emacs_configuration_options):
532 Include --enable-checking, if specified, in the return value.
534 2012-02-04 Martin Rudalics <rudalics@gmx.at>
536 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
537 after rounding frame sizes. (Bug#9723)
539 2012-02-04 Eli Zaretskii <eliz@gnu.org>
541 * keyboard.c (adjust_point_for_property): Don't position point
542 before BEGV. (Bug#10696)
544 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
546 Handle overflow when computing char display width (Bug#9496).
547 * character.c (char_width): Return EMACS_INT, not int.
548 (char_width, c_string_width): Check for overflow when
549 computing the width; this is possible now that individual
550 characters can have unbounded width. Problem introduced
551 by merge from Emacs 23 on 2012-01-19.
553 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
555 * dbusbind.c (Fdbus_register_method): Mention the return value
556 :ignore in the docstring.
558 2012-02-02 Glenn Morris <rgm@gnu.org>
560 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
562 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
563 Unconditionally set to t. (Bug#10673)
564 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
565 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
566 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
568 2012-02-02 Kenichi Handa <handa@m17n.org>
570 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
571 0, do not call append_composite_glyph.
573 2012-02-02 Kenichi Handa <handa@m17n.org>
575 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
577 (x_produce_glyphs): If the component of a composition is a null
578 string, set it->pixel_width to 1 to avoid zero-width glyph.
580 2012-02-01 Eli Zaretskii <eliz@gnu.org>
582 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
583 first 2 arguments are identical. This makes inserting large
584 output from a subprocess an order of magnitude faster on
585 MS-Windows, where all sbrk'ed memory is always contiguous.
587 2012-01-31 Glenn Morris <rgm@gnu.org>
589 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
590 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
591 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
593 2012-01-29 Glenn Morris <rgm@gnu.org>
595 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
597 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
599 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
601 2012-01-28 Chong Yidong <cyd@gnu.org>
603 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
605 2012-01-26 Chong Yidong <cyd@gnu.org>
607 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
609 * search.c (Fsearch_forward, Fsearch_backward): Document negative
610 repeat counts (Bug#10507).
612 2012-01-26 Glenn Morris <rgm@gnu.org>
614 * lread.c (syms_of_lread): Doc fix.
616 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
618 * coding.c (encode_designation_at_bol): Change return value to
621 2012-01-25 Chong Yidong <cyd@gnu.org>
623 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
625 2012-01-21 Chong Yidong <cyd@gnu.org>
627 * floatfns.c (Fcopysign): Make the second argument non-optional,
628 since nil is not allowed anyway.
630 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
632 * process.c (read_process_output): Use p instead of XPROCESS (proc).
633 (send_process): Likewise.
635 2012-01-19 Martin Rudalics <rudalics@gmx.at>
637 * window.c (save_window_save, Fcurrent_window_configuration)
638 (Vwindow_persistent_parameters): Do not use Qstate.
641 2012-01-19 Kenichi Handa <handa@m17n.org>
643 * character.c (char_width): New function.
644 (Fchar_width, c_string_width, lisp_string_width):
645 Use char_width (Bug#9496).
647 2012-01-16 Martin Rudalics <rudalics@gmx.at>
649 * window.c (Vwindow_persistent_parameters): New variable.
650 (Fset_window_configuration, save_window_save): Handle persistent
653 2012-01-14 Eli Zaretskii <eliz@gnu.org>
655 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
656 thrashing the stack of the thread. (Bug#9087)
658 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
660 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
662 2012-01-11 Eli Zaretskii <eliz@gnu.org>
664 * xdisp.c (rows_from_pos_range): Handle the case where the
665 highlight ends on a newline. (Bug#10464)
666 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
667 he end column for display of highlight that ends on a newline
670 2012-01-11 Glenn Morris <rgm@gnu.org>
672 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
673 from load-path also when installation-directory is nil. (Bug#10208)
675 2012-01-10 Glenn Morris <rgm@gnu.org>
677 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
679 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
680 Update template values to be closer to their typical values these days.
682 2012-01-09 Eli Zaretskii <eliz@gnu.org>
684 * xdisp.c (rows_from_pos_range): Accept additional argument
685 DISP_STRING, and accept any glyph in a row whose object is that
686 string as eligible for mouse highlight. Fixes mouse highlight of
687 display strings from overlays. (Bug#10464)
689 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
691 emacs: fix an auto-save permissions race condition (Bug#10400)
692 * fileio.c (auto_saving_dir_umask): New static var.
693 (Fmake_directory_internal): Use it.
694 (do_auto_save_make_dir): Set it, instead of invoking chmod after
695 creating the directory. The old code temporarily assigns
696 too-generous permissions to the directory.
697 (do_auto_save_eh): Clear it.
698 (Fdo_auto_save): Catch all errors, not just file errors, so
699 that the var is always cleared.
701 2012-01-07 Eli Zaretskii <eliz@gnu.org>
703 * search.c (scan_buffer): Pass character positions to
704 know_region_cache, not byte positions. (Bug#6540)
706 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
708 * w32.c (sys_rename): Report EXDEV when rename of a directory
709 fails because the target is on another logical disk. (Bug#10284)
711 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
713 * xterm.c (x_embed_request_focus): New function.
715 * xterm.h: Add prototype.
717 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
719 2012-01-05 Glenn Morris <rgm@gnu.org>
721 * emacs.c (emacs_copyright): Update short copyright year to 2012.
723 2012-01-01 Eli Zaretskii <eliz@gnu.org>
725 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
726 Load gnutls_transport_set_lowat only if GnuTLS version is below
728 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
729 GnuTLS versions below 2.11.1.
731 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
733 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
734 to the doc string advising against its use for altering the way
735 windows are scrolled.
737 2011-12-28 Kenichi Handa <handa@m17n.org>
739 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
740 coding-system ASCII compatible only when it does not produce BOM
741 on encoding (Bug#10383).
743 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
745 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
747 (create_and_show_popup_menu): Always use menu_position_func for
750 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
752 * callint.c (Fcall_interactively): Don't truncate prompt string.
754 2011-12-23 Eli Zaretskii <eliz@gnu.org>
756 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
757 property that ends at ZV, so that the bidi iteration could be
758 resumed from there (after widening). (Bug#10360)
760 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
762 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
764 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
766 * nsterm.m (x_free_frame_resources):
767 Release f->output_data.ns->miniimage.
768 (ns_index_color): Fix indentation. Do not retain
769 color_table->colors[i].
771 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
774 * nsfns.m (x_set_background_color): Assign return value from
775 ns_index_color to face-background instead of NSColor*.
776 (ns_implicitly_set_icon_type): Fix indentation.
777 Change assignment in for loop to comparison.
779 * emacs.c (ns_pool): New variable.
780 (main): Assign ns_pool.
781 (Fkill_emacs): Call ns_release_autorelease_pool.
783 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
784 autorelease fdesc, release fdAttrs and tdict.
785 (ns_get_covering_families): Release charset.
786 (ns_findfonts): Release NSFontDescriptor created with new.
787 (ns_uni_to_glyphs): Fix indentation.
788 (setString): Release attrStr before assigning new value.
790 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
792 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
794 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
795 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
797 2011-12-18 David Reitter <reitter@cmu.edu>
799 * nsterm.m (ns_term_init): Subscribe for notifications
800 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
801 to method trackingNotification in EmacsMenu.
803 * nsmenu.m (trackingMenu): New variable.
804 (trackingNotification): New method (from Aquamacs).
805 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
806 from Aquamacs (Bug#7030).
808 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
810 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
811 (symbol_to_nsstring): Fix indentation.
812 (ns_symbol_to_pb): New function.
813 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
814 (Fns_rotate_cut_buffers_internal): Remove.
815 (Fns_store_selection_internal): Rename from
816 Fns_store_cut_buffer_internal.
817 (ns_get_foreign_selection, Fx_own_selection_internal)
818 (Fx_disown_selection_internal, Fx_selection_exists_p)
819 (Fns_get_selection_internal, Fns_store_selection_internal):
820 Use ns_symbol_to_pb and check if return value is nil.
821 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
822 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
823 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
824 renamed to Sns_store_selection_internal.
825 (ns_handle_selection_request): Move code to Fx_own_selection_internal
826 and remove this function.
827 (ns_handle_selection_clear): Remove, never used.
828 (Fx_own_selection_internal): Move code from ns_handle_selection_request
831 2011-12-17 Ken Brown <kbrown@cornell.edu>
833 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
834 GID is unknown (Bug#10257).
836 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
838 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
839 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
840 which caused a build failure on GNU/Linux IA-64. This problem was
841 introduced by my 2011-10-07 patch.
843 2011-12-15 Juri Linkov <juri@jurta.org>
845 * image.c (imagemagick_error): New function. (Bug#10112)
846 (imagemagick_load_image): Comment out `MagickSetResolution' call.
847 Use `imagemagick_error' where ImageMagick functions return
849 (Fimagemagick_types): Add `Fnreverse' to return the list in the
852 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
854 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
855 fill background (Bug#8992).
857 2011-12-13 Martin Rudalics <rudalics@gmx.at>
859 * window.c (Vwindow_combination_resize)
860 (Vwindow_combination_limit): Use t instead of non-nil in
862 (Vrecenter_redisplay): Add first sentence of doc-string on
864 (Frecenter): Fix doc-string typo.
866 2011-12-11 Kenichi Handa <handa@m17n.org>
868 * coding.c (Funencodable_char_position): Pay attention to the
869 buffer text relocation (Bug#9389).
871 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
873 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
874 gtk_init (Bug#10100).
876 2011-12-10 Eli Zaretskii <eliz@gnu.org>
878 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
879 IT->string is nil. (Bug#10263)
881 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
883 * nsterm.h (x_free_frame_resources): Declare.
885 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
886 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
888 * nsterm.h (ns_get_defaults_value): Declare.
890 * nsterm.m (ns_default): Call ns_get_defaults_value.
892 2011-12-09 Eli Zaretskii <eliz@gnu.org>
894 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
897 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
899 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
900 that where the value of an _OBJC_* symbol points to is in the .bss
903 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
905 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
906 after the loop to call ccl_driver at least once (Bug#8619).
908 2011-12-08 Kenichi Handa <handa@m17n.org>
910 * ftfont.c (get_adstyle_property): Fix previous change
913 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
915 * w32.c (init_environment): If no_site_lisp, remove site-lisp
916 dirs from the default value of EMACSLOADPATH (bug#10208).
918 2011-12-07 Glenn Morris <rgm@gnu.org>
920 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
921 installation and source directories as well. (Bug#10208)
923 2011-12-06 Chong Yidong <cyd@gnu.org>
925 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
927 2011-12-06 Glenn Morris <rgm@gnu.org>
929 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
930 as an error, not just -1. (Bug#10217)
932 2011-12-05 Chong Yidong <cyd@gnu.org>
934 * keyboard.c (process_special_events): New function.
935 (swallow_events, Finput_pending_p): Use it (Bug#10195).
937 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
939 * coding.c (encode_designation_at_bol): Don't use uninitialized
940 local variable (Bug#9318).
942 2011-12-05 Kenichi Handa <handa@m17n.org>
944 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
945 return Qnil (Bug#8046, Bug#10193).
947 2011-12-05 Kenichi Handa <handa@m17n.org>
949 * coding.c (encode_designation_at_bol): New args charbuf_end and
950 dst. Return the number of produced bytes. Callers changed.
951 (coding_set_source): Return how many bytes coding->source was
953 (coding_set_destination): Return how many bytes
954 coding->destination was relocated.
955 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
956 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
958 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
960 * coding.c (CODING_CHAR_CHARSET_P): New macro.
961 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
964 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
966 The following changes are to fix Bug#9318.
968 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
969 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
970 (encode_coding_iso_2022, encode_coding_sjis)
971 (encode_coding_big5, encode_coding_charset): Use the above macros.
973 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
975 * lisp.h (process_quit_flag): Fix external declaration.
977 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
979 Don't macro-inline non-performance-critical code.
980 * eval.c (process_quit_flag): New function.
981 * lisp.h (QUIT): Use it.
983 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
985 * nsfns.m (get_geometry_from_preferences): New function.
986 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
988 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
990 * emacs.c (Qkill_emacs): Define.
991 (syms_of_emacs): Initialize it.
992 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
993 Qquit_flag to `kill-emacs' instead.
994 (quit_throw_to_read_char): Add parameter `from_signal'.
995 All callers changed. Call Fkill_emacs if requested and safe.
996 * lisp.h (QUIT): Call Fkill_emacs if requested.
998 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1000 * widget.c (update_wm_hints): Return if wmshell is null.
1001 (widget_update_wm_size_hints): New function.
1003 * widget.h (widget_update_wm_size_hints): Declare.
1005 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1006 widget_update_wm_size_hints (Bug#10104).
1008 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1010 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1011 before a newline, prepare the bidi iterator for consuming the
1012 newline, and keep the current paragraph direction. (Bug#10183)
1013 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1015 2011-12-02 Juri Linkov <juri@jurta.org>
1017 * search.c (Fword_search_regexp): New Lisp function created from
1018 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1019 (Fword_search_backward, Fword_search_forward)
1020 (Fword_search_backward_lax, Fword_search_forward_lax):
1021 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1022 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1024 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1026 * fileio.c (Finsert_file_contents): Move after-change-function call
1027 to before the "handled:" label, since all "goto handled" appear in
1028 cases where the *-change-functions have already been properly called
1031 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1033 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1034 waiting for input. (Bug#10169)
1036 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1038 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1039 verifies glyph row's hash code--we have just reallocated the
1040 glyphs, so their contents can be complete garbage. (Bug#10164)
1042 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1044 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1046 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1048 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1049 attributes are tested _before_ calling verify_row_hash, to protect
1050 against GCC re-ordering of the tests. (Bug#10164)
1052 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1054 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1056 * xterm.c (handle_one_xevent): Only set async_visible and friends
1057 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1058 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1059 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1061 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1063 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1064 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1065 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1066 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1067 All uses changed to use GCPRO1 etc.
1068 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1069 Revert to old implementation (i.e., before 2011-03-11).
1071 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1073 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1074 of scroll runs so as to avoid assigning disabled bogus rows and
1075 unnecessary graphics copy operations.
1077 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1079 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1080 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1081 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1082 (malloc, free, realloc, calloc): Redirect to e_* only when
1085 * lisp.h (GCTYPEBITS): Move before first use.
1086 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1087 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1088 this macro definition.
1090 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1093 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1095 * gtkutil.c (xg_create_frame_widgets):
1096 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1097 present with Gtk+ 2.0.
1099 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1101 * fileio.c (Finsert_file_contents): Undo previous change; see
1102 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1104 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1106 Rename locals to avoid shadowing.
1107 * fileio.c (Finsert_file_contents):
1108 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1109 * process.c (wait_reading_process_output):
1110 Rename inner 'proc' to 'p' to avoid shadowing.
1111 Indent for consistency with usual Emacs style.
1113 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1115 * xdisp.c (redisplay_window): If cursor row is not fully visible
1116 after recentering, and scroll-conservatively is set to a large
1117 number, scroll window by a few more lines to make the cursor fully
1118 visible and out of scroll-margin. (Bug#10105)
1119 (start_display): Don't move to the next line if the display should
1120 start at a newline that is part of a display vector or an overlay
1123 2011-11-24 Juri Linkov <juri@jurta.org>
1125 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1126 after the `MagickPingImage' call. (Bug#10112)
1128 2011-11-23 Chong Yidong <cyd@gnu.org>
1130 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1132 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1134 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1135 making another buffer current. (Bug#10114)
1137 2011-11-23 Glenn Morris <rgm@gnu.org>
1139 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1141 2011-11-23 Chong Yidong <cyd@gnu.org>
1143 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1144 using it (Bug#5984).
1146 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1148 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1149 and header-lines, as they don't have one computed for them.
1152 * .gdbinit (prow): Make displayed values more self-explaining.
1153 Add row's hash code.
1155 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157 * process.c (wait_reading_process_output): Fix asynchrounous
1158 GnuTLS socket handling on some versions of the GnuTLS library.
1159 (wait_reading_process_output): Add comment and URL.
1161 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1163 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1165 2011-11-21 Chong Yidong <cyd@gnu.org>
1167 * window.c (Fnext_window, Fprevious_window): Doc fix.
1169 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1171 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1173 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1175 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1177 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1179 * window.c (Fset_window_combination_limit): Rename argument
1181 (Vwindow_combination_limit): Remove "status" from doc-string.
1183 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1185 * m/ibms390.h: Remove.
1186 * m/ibms390x.h: Don't include "ibms390.h".
1188 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1190 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1191 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1193 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1195 * casetab.c (Fset_case_table):
1196 * charset.c (Fcharset_after): Fix typos.
1198 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1200 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1201 Otherwise, valgrind does not work on some platforms.
1202 Problem reported by Andreas Schwab in
1203 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1204 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1205 is set, removing the need for VIRT_ADDRESS_VARIES.
1206 (PURE_P): Use a more-efficient implementation that needs just one
1207 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1208 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1209 to 4 (xorl, subq, cmpq, setbe).
1210 * alloc.c (pure): Always extern now, since that's the
1211 VIRT_ADDR_VARIES behavior.
1212 (PURE_POINTER_P): Use a single comparison, not two, for
1213 consistency with the new puresize.h.
1214 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1215 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1216 Remove VIRT_ADDR_VARIES no longer needed.
1218 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1220 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1221 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1222 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1223 behave as if the cursor position were at the window margin.
1225 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1226 and the cursor position is out of bounds, behave as if the cursor
1227 position were at the window margin. (Bug#10075)
1229 2011-11-18 Chong Yidong <cyd@gnu.org>
1231 * window.c (Fwindow_combination_limit): Make first argument
1232 non-optional, since it is meaningless for live windows like the
1235 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1237 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1239 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1241 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1242 (graft_intervals_into_buffer): Simplify.
1244 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1246 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1247 hash values of the two rows.
1248 (copy_row_except_pointers): Preserve the used[] arrays and the
1249 hash values of the two rows. (Bug#10035)
1250 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1252 * xdisp.c (row_hash): New function, body extracted from
1253 compute_line_metrics.
1254 (compute_line_metrics): Call row_hash, instead of computing the
1257 * dispnew.c (verify_row_hash): Call row_hash for computing the
1258 hash code of a row, instead of duplicating code from xdisp.c.
1260 * dispextern.h (row_hash): Add prototype.
1262 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1264 * frame.c (delete_frame): Don't delete the terminal when the last
1265 X frame is closed if emacs is built with GTK toolkit.
1267 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1269 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1271 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1273 * window.c (Vwindow_splits): Rename to
1274 Vwindow_combination_resize. Suggested by Juri Linkov.
1275 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1278 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1280 * nsfns.m (Fns_font_name):
1281 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1283 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1285 * window.h (window): Rename slot "nest" to "combination_limit".
1286 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1287 (Fset_window_nest): Rename to Fset_window_combination_limit.
1288 (Vwindow_nest): Rename to Vwindow_combination_limit.
1289 (recombine_windows, make_parent_window, make_window)
1290 (Fsplit_window_internal, saved_window)
1291 (Fset_window_configuration, save_window_save): Rename all
1292 occurrences of window_nest to window_combination_limit.
1294 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1296 * image.c (imagemagick_load_image): Fix typo.
1298 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1300 * xdisp.c (display_line): Move the call to
1301 highlight_trailing_whitespace before the call to
1302 compute_line_metrics, since the latter needs to see the final
1303 faces of all the glyphs to compute ROW's hash value.
1304 Fixes assertion violations in row_equal_p. (Bug#10035)
1306 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1308 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1309 just return (bug#10044).
1311 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1313 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1314 with user-defined heap size. Bump the default size of the temacs
1315 heap to 27MB, to avoid memory warning when running temacs.
1316 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1318 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1319 current_matrix and desired_matrix. (Bug#9990)
1320 (verify_row_hash) [XASSERTS]: New function.
1321 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1322 that the hash value of glyph rows is correct.
1324 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1326 * window.h (window): Remove splits slot.
1327 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1328 (Fdelete_other_windows_internal, make_parent_window)
1329 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1330 (Fset_window_configuration, save_window_save): Don't deal with
1331 split status of windows.
1332 (saved_window): Remove splits slot.
1333 (Vwindow_splits): Rewrite doc-string.
1335 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1337 * xfns.c (unwind_create_frame):
1338 * nsfns.m (unwind_create_frame):
1339 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1340 Vframe_list (Bug#9999).
1342 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1344 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1346 2011-11-11 Kenichi Handa <handa@m17n.org>
1348 * callproc.c (Fcall_process): Set the member dst_multibyte of
1351 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1353 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1354 avoid a crash (bug#9496).
1356 2011-11-09 Chong Yidong <cyd@gnu.org>
1358 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1359 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1361 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1363 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1365 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1367 Avoid some portability problems by eschewing 'extern inline' functions.
1368 The trivial performance wins aren't worth the portability hassles; see
1369 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1371 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1372 (window_box_width, window_box_left, window_box_left_offset)
1373 (window_box_right, window_box_right_offset): Undo previous change,
1374 by removing the "extern"s.
1375 * intervals.c (adjust_intervals_for_insertion)
1376 (adjust_intervals_for_deletion): Undo previous change,
1377 making these static again.
1378 (offset_intervals, temp_set_point_both, temp_set_point)
1379 (copy_intervals_to_string): No longer inline.
1380 * xdisp.c (window_text_bottom_y, window_box_width)
1381 (window_box_height, window_box_left_offset)
1382 (window_box_right_offset, window_box_left, window_box_right)
1383 (window_box): No longer inline.
1385 2011-11-08 Chong Yidong <cyd@gnu.org>
1387 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1388 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1389 Signal an error if not a live window.
1390 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1391 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1393 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1395 * lisp.h (syms_of_abbrev): Remove declaration.
1396 Reported by CHENG Gao <chenggao@royau.me>.
1398 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1400 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1401 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1402 of temacs in GUI mode.
1404 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1406 * window.h: Declare delete_all_child_windows instead of
1407 delete_all_subwindows.
1408 * window.c (Fwindow_nest, Fset_window_nest)
1409 (Fset_window_new_total, Fset_window_new_normal)
1410 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1411 (delete_all_subwindows): Rename to delete_all_child_windows.
1412 (Fdelete_other_windows_internal, Fset_window_configuration):
1413 Call delete_all_child_windows instead of delete_all_subwindows.
1414 * frame.c (delete_frame): Call delete_all_child_windows instead
1415 of delete_all_subwindows.
1417 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1419 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1420 This is also needed for porting to any host where GC_MARK_STACK is
1421 not GC_MAKE_GCPROS_NOOPS.
1422 (which_symbols): Use it.
1424 2011-11-07 Kenichi Handa <handa@m17n.org>
1426 * coding.c (coding_set_destination): Check coding->src_pos only
1427 when coding->src_object is a buffer (bug#9910).
1429 * process.c (send_process): Set the member src_multibyte of coding
1430 to 0 (bug#9911) when sending a unibyte text.
1432 * callproc.c (Fcall_process): Set the member src_multibyte of
1433 process_coding to 0 (bug#9912).
1435 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1437 * xmenu.c (cleanup_widget_value_tree): New function.
1438 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1439 calling free_menubar_widget_value_tree directly (Bug#9830).
1441 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1443 Fix some portability problems with 'inline'.
1444 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1445 (window_box_width, window_box_left, window_box_left_offset)
1446 (window_box_right, window_box_right_offset): Declare extern.
1447 Otherwise, these inline functions do not conform to C99 and
1448 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1449 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1450 * intervals.c (adjust_intervals_for_insertion)
1451 (adjust_intervals_for_deletion): Now extern, because otherwise the
1452 extern inline functions 'offset_intervals' couldn't refer to it.
1453 (static_offset_intervals): Remove.
1454 (offset_intervals): Rewrite using the old contents of
1455 static_offset_intervals. The old version didn't conform to C99
1456 because an extern inline function contained a reference to an
1457 identifier with static linkage.
1459 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1461 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1464 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1466 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1467 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1468 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1469 return Qleft_to_right.
1471 2011-11-06 Chong Yidong <cyd@gnu.org>
1473 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1474 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1475 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1476 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1477 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1478 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1479 (Fwindow_vscroll): Doc fix.
1480 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1481 argument, since it makes no sense to pass a live window and for
1482 consistency with window-child.
1484 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1486 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1489 2011-11-05 Jason Rumney <jasonr@gnu.org>
1491 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1492 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1494 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1495 bitwise arithmetic preventing use of unicode-sip and non-truetype
1498 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1500 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1503 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1504 initialization code to keep similarity to xfns.c after changes
1507 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1509 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1510 (unwind_create_frame): New function (Bug#9943).
1511 (Fx_create_frame): Restructure code to be more similar to the one in
1512 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1513 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1514 Move terminal->reference_count++ just before making the frame official
1517 * nsterm.m (x_free_frame_resources): New function.
1518 (x_destroy_window): Move code to x_free_frame_resources.
1520 * xfns.c (unwind_create_frame): Fix comment.
1521 (Fx_create_frame, x_create_tip_frame):
1522 Move terminal->reference_count++ just before making the frame
1523 official. Move initialization of image_cache_refcount and
1524 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1526 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1528 Support MSVC build with newer versions of Visual Studio.
1529 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1530 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1533 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1534 which are not supported by MSVC.
1535 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1536 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1538 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1540 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1542 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1544 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1546 Support MSVC build with newer versions of Visual Studio.
1547 * w32.c: Don't include w32api.h for MSVC.
1548 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1550 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1551 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1552 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1553 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1555 (alloca) [_MSC_VER]: Define to _alloca.
1557 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1559 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1561 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1563 * xdisp.c (note_mouse_highlight): If either of
1564 previous/next-single-property-change returns nil, treat that as
1565 the beginning or the end of the buffer. (Bug#9955)
1567 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1569 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1570 label is not null (Bug#9951).
1571 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1574 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1576 * window.c (Fwindow_body_size): Mention in the doc string that the
1577 return value is in frame's canonical units. (Bug#9949)
1579 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1583 * w32fns.c (unwind_create_frame): If needed, free the glyph
1584 matrices of the partially constructed frame. (Bug#9943)
1585 * xfns.c (unwind_create_frame): Likewise.
1587 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1589 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1590 Don't stop backward scan on the continuation glyph, even though
1591 its CHARPOS is positive.
1592 (mouse_face_from_buffer_pos, note_mouse_highlight):
1593 Rename cover_string to disp_string.
1595 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1597 * window.c (temp_output_buffer_show): Don't use
1598 Vtemp_buffer_show_specifiers.
1599 (Vtemp_buffer_show_specifiers): Remove unused variable.
1601 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1603 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1604 past the beginning of the current glyph matrix.
1606 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1608 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1609 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1610 HAVE_GTK3 (Bug#9869).
1612 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1613 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1615 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1617 * xterm.c: Declare x_handle_net_wm_state to return int.
1618 (handle_one_xevent): Check if we are iconified but don't have
1619 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1620 (get_current_wm_state): Return non-zero if not hidden,
1621 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1622 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1623 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1624 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1626 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1628 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1629 so that this new function doesn't get optimized away by a
1630 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1632 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1634 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1636 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1638 Fix the `xbytecode' command.
1639 * .gdbinit (xprintbytestr): New command.
1640 (xwhichsymbols): Rename from `which'; all callers changed.
1641 (xbytecode): Print the byte-code string as well.
1643 2011-10-29 Kim Storm <storm@cua.dk>
1645 * alloc.c (which_symbols): New function.
1647 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1649 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1652 2011-10-29 Glenn Morris <rgm@gnu.org>
1654 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1655 Not clear what it was for, and it causes various bugs. (Bug#9839)
1657 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1659 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1660 possible random value that matches one of those tested as
1661 condition to clear the mouse face.
1663 2011-10-28 Chong Yidong <cyd@gnu.org>
1665 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1667 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1669 * window.c (make_window): Initialize phys_cursor_on_p.
1671 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1673 * lisp.h (struct Lisp_Symbol): Update comments.
1675 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1677 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1679 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1681 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1682 <oslsachem@gmail.com> for helping to debug this.
1684 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1685 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1686 (g_b_init_get_glyph_outline_w): New static variables.
1687 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1688 (GetGlyphOutlineW_Proc): New typedefs.
1689 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1690 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1692 (w32font_open_internal, compute_metrics):
1693 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1694 instead of calling the "wide" APIs directly.
1696 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1698 * w32.h (syms_of_w32font): Add prototype.
1700 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1702 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1703 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1704 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1705 (Fmove_to_window_line): Doc fix.
1707 2011-10-27 Chong Yidong <cyd@gnu.org>
1709 * process.c (make_process): Set gnutls_state to NULL.
1711 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1712 non-NULL, regardless of GNUTLS_INITSTAGE.
1713 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1714 an error. Set process slots as soon as we allocate them.
1716 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1718 2011-10-27 Chong Yidong <cyd@gnu.org>
1720 * gnutls.c (emacs_gnutls_deinit): New function.
1721 Deallocate credentials structures as well as calling gnutls_deinit.
1722 (Fgnutls_deinit, Fgnutls_boot): Use it.
1724 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1725 (deactivate_process): Call emacs_gnutls_deinit.
1727 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1729 * image.c (x_create_x_image_and_pixmap):
1730 * w32.c (sys_rename, w32_delayed_load):
1731 * w32font.c (fill_in_logfont):
1732 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1734 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1736 * w32fns.c (w32_default_color_map): New function,
1737 extracted from Fw32_default_color_map.
1738 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1740 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1742 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1744 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1746 * keyboard.c (test_undefined): New function (bug#9751).
1747 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1749 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1751 * sysdep.c (init_sys_modes): Fix the check for the controlling
1752 terminal (Bug#6649).
1754 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1756 * dispextern.h (struct bidi_it): New member next_en_type.
1758 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1759 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1760 current character, check also for next_en_type being WEAK_EN.
1761 (bidi_resolve_weak): Don't enter the expensive loop if the current
1762 position is before next_en_pos. Record the bidi type of the first
1763 non-ET, non-BN character we find, in addition to its position.
1764 (bidi_level_of_next_char): Invalidate next_en_type when
1765 next_en_pos is over-stepped.
1767 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1769 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1770 * editfns.c: Rewrite current-time-zone so that it invokes
1771 the equivalent of (format-time-string "%Z") to get the time zone name.
1772 This fixes a bug when the time zone name contains characters that
1773 need converting from the system time locale to Emacs internal format.
1774 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1775 that patch fixed format-time-string to do the conversion, but
1776 I forgot to fix current-time-zone.
1777 (format_time_string): New function, containing most of
1778 what Fformat_time_string used to contain.
1779 (Fformat_time_string): Rewrite in terms of format_time_string.
1780 This doesn't change this function's behavior.
1781 (current-time-zone): Rewrite to use format_time_string.
1782 This fixes the bug reported by Michael Schierl in
1783 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1784 Jason Rumney's 2007-06-07 change worked around this bug, but
1786 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1788 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1790 * xdisp.c (start_display): If the character at POS is displayed
1791 via a display vector, reset IT->current.dpvec_index to zero.
1792 (try_window_reusing_current_matrix): If a line ends in a display
1793 vector or the next line starts in a display vector, continue
1794 redrawing the window even though the character position of
1795 start_row was reached.
1798 2011-10-18 Chong Yidong <cyd@gnu.org>
1800 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1801 with nobreak-char-display too.
1803 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1805 Fix part 3 of bug#9771.
1806 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1807 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1808 non-neutral characters if the current character is a paragraph
1809 separator (a.k.a. Newline). This avoids running the same
1810 expensive loop twice, once when we consume the preceding newline
1811 and the other time when the line actually needs to be displayed.
1812 Avoid the loop when we see neutrals on the base embedding level
1813 following a character whose directionality is the same as the
1814 paragraph's. This avoids running the expensive loop when a line
1815 ends in a long sequence of neutrals, like control characters.
1816 Add assertion against STRONG_AL type. Slightly rearrange code
1817 that determines the type of a neutral given the first non-neutral
1819 (bidi_level_of_next_char): Set next_en_pos to zero when
1820 invalidating its info.
1822 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1824 * xdisp.c (push_display_prop): Determine whether to record string
1825 or buffer position by IT->string, not by IT->method. Allow
1826 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1827 (move_it_vertically_backward): Don't look for character position
1828 immediately after the newline when in a continuation line.
1831 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1833 * window.c (coordinates_in_window): Rewrite and delabelize
1834 vertical border check. (Bug#5357) (Bug#9618)
1836 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1838 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1839 errors in XSetWindowBorder (bug#9310).
1841 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1843 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1844 avoid crash when xmalloc overrun checking is enabled.
1846 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1848 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1849 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1850 cursor motion with <left> and <right> arrow keys.
1852 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1853 some callers set that themselves.
1855 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1858 display string and the previous row comes from the same string and
1859 is empty. (Bug#9739) (Bug#9738)
1861 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1863 * doc.c (get_doc_string): Encode file name (bug#9735).
1865 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1867 * bidi.c (bidi_level_of_next_char):
1868 * xdisp.c (get_visually_first_element): Remove old incorrect
1869 comments regarding the Unicode Line Separator character.
1871 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1873 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1875 * alloc.c (Fgc_status): Do not access beyond zombies array
1876 boundary if nzombies > MAX_ZOMBIES.
1877 * alloc.c (dump_zombies): Add missing format specifier.
1879 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1881 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1882 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1884 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1885 Some packages use them to denote characters with modifiers.
1887 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1889 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1890 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1891 matching a pp-number. Rename parameter var to var1.
1893 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1895 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1897 2011-10-08 Glenn Morris <rgm@gnu.org>
1899 * callint.c (Fcall_interactively): Give a more explicit error for the
1900 'c' case with a non-character input. (Bug#8479)
1902 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1904 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1906 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1907 lines that are hscrolled on the left.
1909 * dispnew.c (buffer_posn_from_coords): Account for a possible
1910 presence of header-line. (Bug#4426)
1912 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1914 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1915 Don't advertise functionality which we discourage or doesn't work.
1917 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1919 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1920 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1921 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1922 this makes Emacs dump core during garbage collection on rare
1923 occasions. sizeof is obviously inferior to offsetof here, so
1924 stick with offsetof.
1925 (GC_POINTER_ALIGNMENT): New macro.
1926 (mark_memory): Omit 3rd (offset) arg; caller changed.
1927 Don't assume EMACS_INT alignment is the same as pointer alignment.
1929 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1931 * keyboard.c (read_key_sequence_remapped): New var.
1932 (read_key_sequence): Compute remapping in the right buffer.
1933 (command_loop_1): Use read_key_sequence's remapping directly.
1935 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1937 * dired.c (file_name_completion): Don't expand file name.
1938 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1939 before checking file name handler.
1941 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1942 they've been requested explicitly (bug#9591).
1944 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1946 * keymap.c (Fsingle_key_description): Use make_specified_string
1947 instead of build_string to build string from push_key_description.
1950 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1952 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1953 This fixes a Y2038 bug on 64-bit hosts.
1954 * buffer.c (reset_buffer):
1955 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1956 (Fclear_buffer_auto_save_failure):
1957 Use 0, not -1, to represent an unset failure time, since time_t
1958 might not be signed.
1960 Remove dependency on glibc malloc internals.
1961 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1962 Move back here from lisp.h, but with their new implementations.
1963 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1964 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1965 * charset.c (charset_table_init): New static var.
1966 (syms_of_charset): Use it instead of xmalloc. This removes a
1967 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1968 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1969 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1970 Move back to alloc.c.
1971 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1972 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1974 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1976 * nsterm.m (windowDidResize): Call x_set_window_size only when
1977 ns_in_resize is true. Otherwise set pixelwidth/height and
1978 call change_frame_size (Bug#9628).
1980 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1982 Port --enable-checking=all to Fedora 14 x86-64.
1983 * charset.c (syms_of_charset): Also account for glibc malloc's
1984 internal overhead when calculating the initial malloc maximum.
1986 Port --enable-checking=all to Fedora 14 x86.
1987 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1989 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1990 (overrun_check_realloc, overrun_check_free):
1991 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1992 That way, xmalloc returns a properly-aligned pointer even if
1993 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1994 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1995 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1996 into account when calculating the initial malloc maximum.
1997 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1998 Move here from alloc.c, so that charset.c can use it too.
1999 Properly align; the old code wasn't right for common 32-bit hosts
2000 when configured with --enable-checking=all.
2001 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2002 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2004 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2006 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2009 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (compute_display_string_end): If there's no display
2012 string at CHARPOS, return -1.
2014 * bidi.c (bidi_fetch_char): When compute_display_string_end
2015 returns a negative value, treat the character as a normal
2016 character not covered by a display string. (Bug#9624)
2018 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2020 * lread.c (Fread_from_string): Fix typo in docstring.
2022 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2024 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2025 newline, reseat the iterator instead of bidi-iterating there one
2026 character at a time. (Bug#9610)
2027 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2028 TO_CHARPOS if the bidi iterator is at base embedding level.
2030 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2032 * lread.c (readevalloop): Use correct code for NBSP.
2033 (read1): Likewise. (Bug#9608)
2035 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2037 * dbusbind.c (Fdbus_register_signal): When service is not
2038 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2040 2011-09-25 Glenn Morris <rgm@gnu.org>
2042 * buffer.c (truncate-lines): Doc fix.
2044 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2046 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2047 (Fset_window_next_buffers): Doc fix.
2049 2011-09-24 Glenn Morris <rgm@gnu.org>
2051 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2053 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2055 Fix minor problems found by static checking.
2056 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2057 * indent.c (Fvertical_motion): Fix == vs = typo.
2059 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2061 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2062 Default value is now t. Doc fix.
2064 * indent.c (Fvertical_motion): Compute and apply the overshoot
2065 logic when moving up, not only when moving down. Fix the
2066 confusing name and values of the it_overshoot_expected variable;
2067 logic changes accordingly. (Bug#9254) (Bug#9549)
2069 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2070 CHARPOS is covered by a display string which includes newlines.
2071 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2072 is covered by a display string with embedded newlines.
2074 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2076 * dbusbind.c (Fdbus_register_signal): Add match rule to
2077 Vdbus_registered_objects_table. (Bug#9581)
2078 (Fdbus_register_method, Vdbus_registered_objects_table):
2081 2011-09-24 Jim Meyering <meyering@redhat.com>
2083 do not ignore write error for any output size
2084 The previous change was incomplete.
2085 While it makes emacs --batch detect the vast majority of stdout
2086 write failures, errors were still ignored whenever the output size is
2087 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2088 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2089 && echo FAIL: ignored write error
2090 FAIL: ignored write error
2091 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2092 && echo FAIL: ignored write error
2093 FAIL: ignored write error
2094 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2096 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2098 * emacs.c (Fkill_emacs): In noninteractive mode exit
2099 non-successfully if a write error occurred on stdout. (Bug#9574)
2101 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2106 * dispextern.h (struct it): Update the comment documenting what
2109 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2111 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2112 a display string, extend search for cursor position to end of row.
2113 (find_row_edges): If the row ends in a newline from a display
2114 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2115 Handle the case of a display string with multiple newlines.
2116 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2117 non-empty line. Fixes confusing cursor motion with arrow keys at
2118 the beginning of a line that starts with whitespace.
2120 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2122 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2125 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2127 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2130 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2132 * xdisp.c (display_line): Record maximum and minimum buffer
2133 positions even if no glyphs were produced (e.g., by a zero-width
2134 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2135 buffer positions that will be removed from the glyph row because
2137 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2138 column is beyond frame width: don't subtract 1 "pixel" when
2139 computing width of the stretch.
2140 (reseat_at_next_visible_line_start): Undo the change made on
2141 2011-09-17 that saved paragraph information and restored it after
2142 the call to `reseat'. (Bug#9545)
2144 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2146 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2147 and turn window cursor on if cleared (Bug#9415).
2149 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2151 * search.c (boyer_moore): Take unibyte characters from pattern
2152 literally. (Bug#9458)
2154 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2156 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2158 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2160 Fix minor problem found by static checking.
2161 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2162 initialized, to pacify gcc -Wuninitialized.
2164 * fileio.c: Report proper errno when syscall falls.
2165 (Finsert_file_contents): Save and restore errno,
2166 so that report_file_error outputs the correct diagnostic.
2167 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2169 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2171 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2173 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2175 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2176 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2178 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2180 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2181 about the current paragraph and restore it after the call to reseat.
2183 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2184 (bidi_find_paragraph_start): Search back for paragraph beginning
2185 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2186 (bidi_move_to_visually_next): Only trigger paragraph-related
2187 computations when the last character is a newline or at EOB, not
2188 just any NEUTRAL_B. (Bug#9470)
2190 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2191 truncated lines if point is covered by a display string. (Bug#9524)
2193 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2195 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2196 (cons_to_x_long): New function.
2197 (lisp_data_to_selection_data): Use it. Correct the test for
2198 short-versus-long data; it was negated. Break out of vector
2199 loop, for efficiency, when a long datum is discovered.
2201 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2203 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2205 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2207 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2208 GCC PR/17406) by declaring this function with external scope.
2210 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2212 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2213 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2215 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2217 * editfns.c (Fformat): Correctly handle text properties on "%%".
2219 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2221 * xterm.c (x_draw_composite_glyph_string_foreground):
2222 * w32term.c (x_draw_composite_glyph_string_foreground):
2223 * term.c (encode_terminal_code):
2224 * composite.c (composition_update_it, get_composition_id):
2225 * xdisp.c (get_next_display_element)
2226 (fill_composite_glyph_string): Add comments about special meaning
2227 of TAB characters in a composition.
2229 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2231 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2232 This occurs when processing a multibyte format.
2233 Problem reported by Wolfgang Jenker.
2235 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2237 * xdisp.c (try_cursor_movement): Only check for exact match if
2238 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2240 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2242 Remove unused external symbols.
2243 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2244 * xdisp.c (calc_pixel_width_or_height): Now static.
2245 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2246 * indent.c (check_display_width):
2247 * w32term.c: Fix comment to match code.
2248 * xterm.c, xterm.h (x_catching_errors): Remove.
2250 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2252 * xselect.c: Use signed conversions more consistently (Bug#9498).
2253 (selection_data_to_lisp_data): Assume incoming selection data are
2254 signed integers, not unsigned. This is to be consistent with
2255 outgoing selection data, which was modified to use signed integers
2256 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2257 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2258 expects long, not unsigned long.
2260 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2262 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2263 computation of loop end. Reported by Johan Bockgård
2266 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2268 * frame.c (Fother_visible_frames_p): Function deleted.
2270 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2272 * indent.c (compute_motion): Process display vector front to back
2273 rather than the other way around. (Bug#2496)
2275 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2277 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2279 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2281 * minibuf.c (Fread_from_minibuffer): Doc fix.
2283 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2285 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2286 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2288 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2290 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2291 value for non-existent files.
2293 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2295 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2296 set its "size" to -1. This will set the modtime_size field of
2297 the corresponding buffer to -1, which is what
2298 verify-visited-file-modtime expects for files that do not exist.
2301 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2303 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2305 * lisp.h: ... from here. push_key_description is no longer
2306 defined in keyboard.c, so its declaration should not be in
2307 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2308 logically belongs with push_key_description.
2310 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2312 * buffer.h: Include <sys/types.h> instead of <time.h>.
2313 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2314 Problem reported by Herbert J. Skuhra.
2316 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2318 * xml.c (parse_region): Make the parsing work for
2319 non-comment-starting XML files again (bug#9144).
2321 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2323 * image.c (gif_load): Fix calculation of bottom and right corner.
2326 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2328 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2329 redisplay in small windows.
2331 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2333 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2335 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2337 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2338 Operate on live windows only.
2340 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2342 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2344 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2346 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2347 only under bidi iteration.
2349 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2351 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2353 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2355 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2356 Without this fix, the command to link temacs failed due to an
2357 undefined symbol __builtin_isnan. This is because
2358 /usr/include/iso/math_c99.h #defines isnan(x) to
2359 __builtin_isnan(x), but the bundled gcc, which identifies itself
2360 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2362 * floatfns.c (isnan): #undef, and then #define to a clone of
2364 (Fisnan): Always define, since it's always available now.
2365 (syms_of_floatfns): Always define isnan at the Lisp level.
2367 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2369 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2371 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2373 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2374 The previous code assumed that file offsets (off_t values) fit in
2375 EMACS_INT variables, which is not true on typical 32-bit hosts.
2376 The code messed up by falsely reporting buffer overflow in cases
2377 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2378 when "big" contains more than 2**29 bytes, even though this
2379 inserts just one byte and does not overflow the buffer.
2380 (Finsert_file_contents): Store file offsets as off_t
2381 values, not as EMACS_INT values. Check for overflow when
2382 converting between EMACS_INT and off_t. When checking for
2383 buffer overflow or for overlap, take the offsets into account.
2384 Don't use EMACS_INT for small values where int suffices.
2385 When checking for overlap, fix a typo: ZV was used where
2386 ZV_BYTE was intended.
2387 (Fwrite_region): Don't assume off_t fits into 'long'.
2388 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2390 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2392 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2394 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2396 sprintf-related integer and memory overflow issues (Bug#9412).
2398 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2399 (esprintf, exprintf, evxprintf): New functions.
2400 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2401 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2402 (modify_event_symbol): Do not assume that the length of
2403 name_alist_or_stem is safe to alloca and fits in int.
2404 (Fexecute_extended_command): Likewise for function name and binding.
2405 (Frecursion_depth): Wrap around reliably on integer overflow.
2406 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2407 since some callers pass EMACS_INT values.
2408 (Fsingle_key_description): Don't crash if symbol name contains more
2409 than MAX_ALLOCA bytes.
2410 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2411 (get_minibuffer): Arg is now EMACS_INT, not int.
2412 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2413 (esprintf, exprintf, evxprintf): New decls.
2414 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2416 * dbusbind.c (signature_cat): New function.
2417 (xd_signature, Fdbus_register_signal):
2418 Do not overrun buffer; instead, report string overflow.
2420 * dispnew.c (add_window_display_history): Don't overrun buffer.
2421 Truncate instead; this is OK since it's just a log.
2423 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2424 even if the time zone offset is outlandishly large.
2425 Don't mishandle offset == INT_MIN.
2427 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2428 when creating daemon; the previous buffer-overflow check was incorrect.
2430 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2431 which has the guts of the old verror function.
2433 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2434 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2436 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2437 (font_unparse_xlfd): Don't blindly alloca long strings.
2438 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2439 fits in int, when using sprintf. Use single snprintf to count
2440 length of string rather than counting it via multiple sprintfs;
2441 that's simpler and more reliable.
2442 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2443 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2444 sprintf, in case result does not fit in int.
2446 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2447 (fontset_from_font): Print it.
2449 * frame.c (tty_frame_count): Now printmax_t, not int.
2450 (make_terminal_frame, set_term_frame_name): Print it.
2451 (x_report_frame_params): In X, window IDs are unsigned long,
2452 not signed long, so print them as unsigned.
2453 (validate_x_resource_name): Check for implausibly long names,
2454 and don't assume name length fits in 'int'.
2455 (x_get_resource_string): Don't blindly alloca invocation name;
2456 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2459 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2460 (xg_check_special_colors, xg_set_geometry):
2461 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2463 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2464 Use esprintf, not sprintf, in case result does not fit in int.
2466 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2467 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2468 it as a large positive number.
2469 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2470 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2472 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2473 in case result does not fit in int.
2475 * print.c (float_to_string): Detect width overflow more reliably.
2476 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2477 buffer overrun. Don't assume list length fits in 'int'. Treat
2478 print length of 0 as 0, not as infinity; to be consistent with other
2479 uses of print length in this function. Don't overflow print length
2480 index. Don't assume hash table size fits in 'long', or that
2481 vectorlike size fits in 'unsigned long'.
2483 * process.c (make_process): Use printmax_t, not int, to format
2484 process-name gensyms.
2486 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2488 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2489 to avoid potential buffer overrun.
2491 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2492 if X resource line is longer than 512 bytes.
2494 * xfns.c (x_window): Make sprintf buffer a bit bigger
2495 to avoid potential buffer overrun.
2497 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2499 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2501 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2503 Integer overflow fixes for scrolling, etc.
2504 Without these, Emacs silently mishandles large integers sometimes.
2505 For example, "C-u 4294967297 M-x recenter" was treated as if
2506 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2508 * xdisp.c (try_window_id): Check Emacs fixnum range before
2509 converting to 'int'.
2511 * window.c (window_scroll_line_based, Frecenter):
2512 Check that an Emacs fixnum is in range before assigning it to 'int'.
2513 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2514 values converted from Emacs fixnums.
2515 (Frecenter): Don't wrap around a line count if it is out of 'int'
2516 range; instead, treat it as an extreme value.
2517 (Fset_window_configuration, compare_window_configurations):
2518 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2520 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2521 that can exceed INT_MAX. Check that EMACS_INT value is in range
2522 before assigning it to the (possibly-narrower) index.
2523 (match_limit): Don't assume that a fixnum can fit in 'int'.
2525 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2528 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2529 (Fvertical_motion): Don't wrap around LINES values that don't fit
2530 in 'int'. Instead, treat them as extreme values. This is good
2531 enough for windows, which can't have more than INT_MAX lines anyway.
2533 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535 * Require libxml/parser.h to avoid compilation warning.
2537 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2539 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2540 since this reportedly can destroy thread storage.
2542 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2544 * syntax.c (find_defun_start): Update all cache variables if
2545 exiting early (Bug#9401).
2547 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2549 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2551 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2552 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2553 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2555 * term.c (tty_append_glyph): New function.
2556 (produce_stretch_glyph): Static function and its prototype deleted.
2558 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2561 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2563 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2564 when checking :margin (Bug#9390).
2565 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2566 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2567 so that the name doesn't mislead. All uses changed.
2569 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2571 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2574 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2576 * xdisp.c (move_it_to): Don't bail out early when reaching
2577 position beyond to_charpos, if we are scanning backwards.
2578 (move_it_vertically_backward): When DY == 0, make sure we get to
2579 the first character in the line after the newline.
2581 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2583 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2584 (ccl_driver): Do not generate an out-of-range pointer.
2585 (Fccl_execute_on_string): Remove unnecessary check for
2586 integer overflow, noted by Stefan Monnier in
2587 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2588 Remove a FIXME that didn't need fixing.
2589 Simplify the newly-introduced buffer reallocation code.
2591 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2593 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2595 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2597 Integer and memory overflow issues (Bug#9196).
2599 * doc.c (get_doc_string): Rework so that
2600 get_doc_string_buffer_size is the actual buffer size, rather than
2601 being 1 less than the actual buffer size; this makes xpalloc more
2604 * image.c (x_allocate_bitmap_record, cache_image):
2605 * xselect.c (Fx_register_dnd_atom):
2606 Simplify previous changes by using xpalloc.
2608 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2609 since either will do and ptrdiff_t is convenient with xpalloc.
2611 * charset.c (charset_table_size)
2612 (struct charset_sort_data.priority): Now ptrdiff_t.
2613 (charset_compare): Don't overflow if priorities differ greatly.
2614 (Fsort_charsets): Don't assume list length fits in int.
2615 Check for size-calculation overflow when allocating sort data.
2616 (syms_of_charset): Allocate an initial charset table that is
2617 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2619 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2621 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2622 The actual value is always <= INT_MAX, and leaving it unsigned made
2623 overflow checking harder.
2625 * dispextern.h (struct glyph_matrix.rows_allocated)
2626 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2627 with xpalloc. The values are still always <= INT_MAX.
2629 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2631 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2632 (SAFE_NALLOCA): New macro.
2634 * region-cache.c (struct boundary.pos, find_cache_boundary)
2635 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2636 (set_cache_region, invalidate_region_cache)
2637 (revalidate_region_cache, know_region_cache, region_cache_forward)
2638 (region_cache_backward, pp_cache):
2639 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2640 so that ptrdiff_t * can be passed to xpalloc.
2641 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2642 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2643 (pp_cache): Don't assume cache_len fits in int.
2644 * region-cache.h: Adjust extern decls to match.
2646 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2647 EMACS_INT, since either will do, for xpalloc.
2649 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2650 (xnmalloc, xnrealloc, xpalloc): New functions.
2652 * bidi.c (bidi_shelve_header_size): New constant.
2653 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2654 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2656 * bidi.c (bidi_cache_shrink):
2657 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2659 Don't update size of array until after memory allocation succeeds,
2660 because xmalloc/xrealloc may not return.
2661 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2662 now that we have proper integer overflow checking.
2663 (record_overlay_string, overlay_strings): Catch overflows when
2664 calculating size of overlay_str_buf.
2666 * callproc.c (Fcall_process): Check for size overflow when
2667 calculating size of args2.
2668 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2669 Normally we prefer signed values, but sticking with ptrdiff_t would
2670 require adding more-complicated checks.
2672 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2673 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2674 Redo buffer-overflow calculations to avoid integer overflow.
2675 Add a FIXME comment where memory seems to be over-allocated.
2677 * character.c (Fstring): Check for size-calculation overflow.
2679 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2680 unnecessary integer overflow. Check for size overflow.
2681 (encode_coding_object): Don't update size until xmalloc succeeds.
2683 * composite.c (get_composition_id): Check for overflow in glyph
2684 length calculations.
2686 Integer and memory overflow fixes for display code.
2687 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2688 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2689 (scrolling_window): Check for overflow in size calculations.
2690 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2691 Don't assume glyph table len fits in int.
2692 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2693 (row_table_size): Now ptrdiff_t, not int.
2694 (scrolling_window): Avoid overflow in size calculations.
2695 Don't update size until allocation succeeds.
2696 * fns.c (concat): Check for overflow in size calculations.
2697 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2698 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2699 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2701 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2702 (get_doc_string): Check for size calculation overflow.
2703 Don't update size until allocation succeeds.
2704 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2705 EMACS_INT, where ptrdiff_t will do.
2706 (Fsubstitute_command_keys): Check for string overflow.
2708 * editfns.c (set_time_zone_rule): Don't assume environment length
2710 (message_length): Now ptrdiff_t, not int.
2711 (Fmessage_box): Don't update size until allocation succeeds.
2712 Don't assume message length fits in int.
2713 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2715 * emacs.c (main): Do not reallocate argv, since there is a null at
2716 the end that can be overwritten, and this way there's no need to
2717 worry about size-calculation overflow.
2718 (sort_args): Check for size-calculation overflow.
2720 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2722 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2724 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2725 (x_set_scroll_bar_width, x_figure_window_size):
2726 Check for integer overflow.
2727 (x_set_alpha): Do not assume XINT fits in int.
2729 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2730 This is for the members text_lines, text_cols, total_lines, total_cols,
2731 where the system imposes an 'int' limit.
2733 * fringe.c (Fdefine_fringe_bitmap):
2734 Don't update size until alloc works.
2736 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2737 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2739 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2740 Check for size-calculation overflow.
2741 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2742 do, as we prefer signed integers.
2743 (id_to_widget.max_size, id_to_widget.used)
2744 (xg_store_widget_in_map, xg_remove_widget_from_map)
2745 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2746 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2747 Use and return ptrdiff_t, not int.
2748 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2749 * gtkutil.h: Change prototypes to match the above.
2751 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2752 are duplicate now that they've been promoted to lisp.h.
2753 (x_allocate_bitmap_record, x_alloc_image_color)
2754 (make_image_cache, cache_image, xpm_load):
2755 Don't update size until alloc is done.
2756 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2758 Check for size calculation overflow.
2759 (ct_colors_allocated_max): New constant.
2760 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2763 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2764 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2765 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2766 Use ptrdiff_t, not int, to count maps.
2767 (read_char_minibuf_menu_prompt): Check for overflow in size
2768 calculations. Don't update size until allocation succeeds.
2769 Redo calculations to avoid overflow.
2770 * keyboard.h: Change prototypes to match the above.
2772 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2774 (current_minor_maps): Check for size calculation overflow.
2775 * keymap.h: Change prototypes to match the above.
2777 * lread.c (read1, init_obarray): Don't update size until alloc done.
2779 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2780 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2782 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2783 Now ptrdiff_t, not int.
2784 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2785 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2787 * process.c (Fnetwork_interface_list): Check for overflow
2788 in size calculation.
2790 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2792 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2793 overflow. Don't bother calling xmalloc when xrealloc will do.
2795 * search.c (Freplace_match): Check for size calculation overflow.
2796 (Fset_match_data): Don't assume list lengths fit in 'int'.
2798 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2799 for command line length. Do not attempt to address one before the
2800 beginning of an array, as that's not portable.
2802 * term.c (max_frame_lines): Remove; unused.
2803 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2805 (encode_terminal_code, calculate_costs): Check for size
2806 calculation overflow.
2807 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2808 table lengths and related sizes. Don't update size until alloc
2809 done. Redo calculations to avoid overflow.
2810 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2812 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2813 subtracting pointers.
2814 (gobble_line): Check for overflow more carefully. Don't update size
2817 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2818 Don't update size until alloc done.
2819 Redo size calculations to avoid overflow.
2820 Check for size calculation overflow.
2821 (main) [DEBUG]: Fix typo in invoking tparam1.
2823 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2824 Use ptrdiff_t, not int, for sizes.
2825 (store_mode_line_noprop_char): Don't update size until alloc done.
2827 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2828 Use ptrdiff_t, not int, for sizes.
2829 (Finternal_make_lisp_face, cache_face):
2830 Check for size calculation overflow.
2831 (cache_face): Treat size calculation overflows as if they were
2832 memory exhaustion (the usual treatment), rather than aborting.
2834 * xfns.c (x_encode_text, x_set_name_internal)
2835 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2836 sizes, since they can exceed INT_MAX in size. Check for size
2837 calculation overflow.
2839 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2840 (xg_select): Check for size calculation overflow.
2841 Don't update size until alloc done.
2843 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2844 as sprintf is limited to int lengths.
2846 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2847 (X_LONG_MIN): New macros.
2848 Use them to make the following changes clearer.
2849 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2850 This change doesn't affect the value now, but it may help remind
2851 future maintainers not to raise the value too much later.
2852 (SELECTION_QUANTUM): Remove, replacing with ...
2853 (selection_quantum): ... new function, which avoids overflow.
2855 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2856 assumption that selection length fits in 'int'.
2857 (x_reply_selection_request, x_handle_selection_request)
2858 (x_get_window_property, receive_incremental_selection)
2859 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2860 (lisp_data_to_selection_data, clean_local_selection_data):
2861 Use ptrdiff_t, not int, to record length of selection.
2862 (x_reply_selection_request, x_get_window_property)
2863 (receive_incremental_selection, x_property_data_to_lisp):
2864 Redo calculations to avoid overflow.
2865 (x_reply_selection_request): When sending hint, ceiling it at
2866 X_LONG_MAX rather than relying on wraparound overflow to send
2868 (x_get_window_property, receive_incremental_selection)
2869 (lisp_data_to_selection_data, x_property_data_to_lisp):
2870 Check for size-calculation overflow.
2871 (x_get_window_property, receive_incremental_selection)
2872 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2873 Don't store size until memory allocation succeeds.
2874 (x_get_window_property): Plug memory leak on memory exhaustion.
2875 Don't double-block input; malloc is safe here. Don't assume 2**34
2876 - 4 fits in unsigned long. Add an xassert to check
2877 XGetWindowProperty overflow. Be more careful about overflow
2878 calculations, and distinguish size from memory overflow better.
2879 (receive_incremental_selection): When tracing, don't assume
2880 unsigned int is less than INT_MAX.
2881 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2882 harmful) conversions of unsigned short to int.
2883 (lisp_data_to_selection_data): Don't assume that integers
2884 in the range -65535 through -1 fit in an X unsigned short.
2885 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2886 result parameters unless successful. Rely on cons_to_unsigned
2887 to report problems with elements; the old code wasn't right anyway.
2888 (x_check_property_data): Check for int overflow; we cannot use
2889 a wider type due to X limits.
2890 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2892 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2894 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2895 (x_term_init): Check for size calculation overflow.
2896 (x_color_cells): Don't store size until memory allocation succeeds.
2897 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2898 Don't assume alloca size is less than MAX_ALLOCA.
2899 (x_term_init): Don't assume length fits in int (sprintf is limited
2902 Use ptrdiff_t for composition IDs.
2903 * character.c (lisp_string_width):
2904 * composite.c (composition_table_size, n_compositions)
2905 (get_composition_id, composition_gstring_from_id):
2906 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2907 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2908 * window.c (Frecenter):
2909 Use ptrdiff_t, not int, for composition IDs.
2910 * composite.c (get_composition_id): Check for integer overflow.
2911 * composite.h: Adjust prototypes to match the above changes.
2913 Use ptrdiff_t for hash table indexes.
2914 * category.c (hash_get_category_set):
2915 * ccl.c (ccl_driver):
2916 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2917 * coding.c (coding_system_charset_list, detect_coding_system):
2918 * coding.h (struct coding_system.id):
2919 * composite.c (get_composition_id, gstring_lookup_cache):
2920 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2921 * image.c (xpm_get_color_table_h):
2922 * lisp.h (hash_lookup, hash_put):
2923 * minibuf.c (Ftest_completion):
2924 Use ptrdiff_t for hash table indexes, not int (which is too
2925 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2926 32-bit --with-wide-int hosts).
2928 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2929 Add a FIXME comment about memory leaks.
2930 (syms_of_charset): Don't assume xmalloc returns.
2932 Don't assume that stated character widths fit in int.
2933 * character.c (Fchar_width, c_string_width, lisp_string_width):
2934 * character.h (CHAR_WIDTH):
2935 * indent.c (MULTIBYTE_BYTES_WIDTH):
2936 Use sanitize_char_width to avoid undefined and/or bad behavior
2937 with outlandish widths.
2938 * character.h (sanitize_tab_width): Rename from sanitize_width,
2939 now that we have two such functions. All uses changed.
2940 (sanitize_char_width): New inline function.
2942 Don't assume that tab-width fits in int.
2943 * character.h (sanitize_width): New inline function.
2944 (SANE_TAB_WIDTH): New macro.
2945 (ASCII_CHAR_WIDTH): Use it.
2946 * indent.c (sane_tab_width): Remove. All uses replaced by
2947 SANE_TAB_WIDTH (current_buffer).
2948 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2950 * fileio.c: Integer overflow issues with file modes.
2951 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2953 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2954 Remove unreachable code.
2955 (read_hex, load_charset_map_from_file): Check for integer overflow.
2957 * xterm.c: Don't go over XClientMessageEvent limit.
2958 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2959 (x_send_scroll_bar_event): Likewise. Check that the size does not
2960 exceed limits imposed by XClientMessageEvent, as well as the usual
2961 ptrdiff_t and size_t limits.
2963 * keyboard.c: Overflow, signedness and related fixes.
2964 (make_lispy_movement): Use same integer type in forward decl
2965 that is used in the definition.
2966 (read_key_sequence, keyremap_step):
2967 Change bufsize argument back to int, undoing my 2011-03-30 change.
2968 We prefer signed types, and int is wide enough here.
2969 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2970 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2971 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2972 length, not size_t. Use ptrdiff_t for index, not int.
2973 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2974 possibility of integer overflow.
2976 Overflow, signedness and related fixes for images.
2978 * dispextern.h (struct it.stack[0].u.image.image_id)
2979 (struct_it.image_id, struct image.id, struct image_cache.size)
2980 (struct image_cache.used, struct image_cache.ref_count):
2981 * gtkutil.c (update_frame_tool_bar):
2982 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2983 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2984 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2985 * nsmenu.m (update_frame_tool_bar):
2986 * xdisp.c (calc_pixel_width_or_height):
2987 * xfns.c (image_cache_refcount):
2988 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2989 on typical 64-bit hosts.
2991 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2992 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2993 Omit unnecessary casts to int.
2994 (parse_image_spec): Check that integers fall into 'int' range
2995 when the callers expect that.
2996 (image_ascent): Redo ascent calculation to avoid int overflow.
2997 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2998 (lookup_image): Remove unnecessary tests.
2999 (xbm_image_p): Locals are now of int, not EMACS_INT,
3000 since parse_image_check makes sure they fit into int.
3001 (png_load, gif_load, svg_load_image):
3002 Prefer int to unsigned where either will do.
3003 (tiff_handler): New function, combining the cores of the
3004 old tiff_error_handler and tiff_warning_handler.
3005 This function is rewritten to use vsnprintf and thereby avoid
3006 stack buffer overflows. It uses only the features of vsnprintf
3007 that are common to both POSIX and native Microsoft.
3008 (tiff_error_handler, tiff_warning_handler): Use it.
3009 (tiff_load, gif_load, imagemagick_load_image):
3010 Don't assume :index value fits in 'int'.
3011 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3012 (imagemagick_load_image): Check that crop parameters fit into
3013 the integer types that MagickCropImage accepts. Don't assume
3014 Vimagemagick_render_type has a nonnegative value. Don't assume
3015 size_t fits in 'long'.
3016 (gs_load): Use printmax_t to print the widest integers possible.
3017 Check for integer overflow when computing image height and width.
3019 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3021 * xdisp.c (redisplay_window): Don't force window start if point
3022 will be invisible in the resulting window. (Bug#9324)
3024 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3026 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3027 the display spec is of the form `(space ...)'.
3028 (handle_display_spec): Return the value returned by
3029 handle_single_display_spec, not just 1 or zero.
3030 (handle_single_display_spec): If the display spec is of the form
3031 `(space ...)', and specifies display in the text area, return 2
3033 (try_cursor_movement): Check for the need to scroll more
3034 accurately, and prefer exact match for point under bidi.
3035 Don't advance `row' beyond the last row of the window.
3037 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3038 into disp_prop; all users changed.
3040 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3041 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3042 for the text covered by the display property.
3044 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3046 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3047 Change return value to nil.
3048 (Frecord_buffer): Delete unused function.
3050 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3052 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3053 buffers, return left-to-right.
3054 (set_cursor_from_row): Consider candidate row a win if its glyph
3055 represents a newline and point is on that newline. Fixes cursor
3056 positioning on the newline at EOL of R2L text within L2R
3057 paragraph, and vice versa.
3058 (try_cursor_movement): Check continued rows, in addition to
3059 continuation rows. Fixes unwarranted scroll when point enters a
3060 continued line of R2L text within an L2R paragraph, or vice versa.
3061 (cursor_row_p): Consider the case of point being equal to
3062 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3063 from the end of a short line to the beginning of a continued line
3064 of R2L text within L2R paragraph.
3065 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3066 composed characters.
3068 * bidi.c (bidi_check_type): Use xassert.
3069 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3072 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3074 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3077 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3079 * nsfont.m (ns_otf_to_script): Fix typo.
3081 2011-08-22 Kenichi Handa <handa@m17n.org>
3083 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3084 extra slot even if the purpose is char-code-property-table.
3086 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3088 * xdisp.c (redisplay_window): When computing centering_position,
3089 account for the height of the header line. (Bug#8874)
3091 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3092 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3093 candidate is selected by the mouse, and that candidate has a
3094 composed character under the mouse.
3096 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3097 coordinates reported by pos-visible-in-window-p for a composed
3098 character in column zero.
3100 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3102 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3104 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3106 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3107 consider it a hit if to_charpos is anywhere in the range of the
3108 composed buffer positions.
3110 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3112 * image.c (gif_load): Don't assume that each subimage has the same
3113 dimensions as the base image. Handle disposal method that is
3114 "undefined" by the gif spec (Bug#9335).
3116 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3118 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3119 (Fcondition_case): Document `debug' symbol in error handler.
3121 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3123 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3124 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3125 from an Org mode buffer to a Speedbar frame.
3127 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3128 a composition, take its buffer position from IT->cmp_it.charpos.
3129 Fixes cursor positioning at the beginning of a line that begins
3130 with a composed character.
3132 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3134 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3135 character bidirectional type, use STRONG_L instead. Fixes crashes
3136 in a buffer produced by `describe-categories'.
3138 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3139 members before the level stack, so they would be saved and
3140 restored when copying iterator state. Fixes incorrect reordering
3141 around TABs covered by display properties.
3143 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3145 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3147 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3149 * eval.c (internal_condition_case, internal_condition_case_1)
3150 (internal_condition_case_2, internal_condition_case_n):
3151 Remove unnecessary aborts (Bug#9081).
3153 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3155 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3156 has no `load' handler, try opening the file locally. (Bug#9311)
3158 2011-08-16 Ken Brown <kbrown@cornell.edu>
3160 * gmalloc.c: Expand comment.
3162 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3164 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3165 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3167 2011-08-16 Ken Brown <kbrown@cornell.edu>
3169 Fix memory allocation problems in Cygwin build (Bug#9273).
3171 * unexcw.c ( __malloc_initialized): Declare external variable.
3172 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3174 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3176 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3178 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3180 [CYGWIN] (special_realloc): New function.
3181 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3182 requests to realloc storage in the static heap.
3184 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3186 * bidi.c (bidi_initialize): Remove unused local.
3188 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3191 * biditype.h: Remove file.
3192 * makefile.w32-in ($(BLD)/bidi.$(O)):
3193 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3195 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3197 * chartab.c: Improve commentary for the uniprop_table API.
3199 * bidi.c (bidi_paragraph_init): Support zero value of
3200 bidi_ignore_explicit_marks_for_paragraph_level.
3201 (bidi_initialize): Use uniprop_table instead of including
3202 biditype.h and bidimirror.h.
3204 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3205 coordinates of the iterator when restoring from ppos_it.
3208 2011-08-14 Kenichi Handa <handa@m17n.org>
3210 * process.c (create_process): Call setup_process_coding_systems
3211 after the pid of the process is set to -1 (Bug#8162).
3213 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3215 * xdisp.c (move_it_in_display_line_to): Don't invoke
3216 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3217 ppos_it. Fixes vertical cursor motion when line beginning is
3218 covered by an image. (Bug#9296)
3220 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3222 * nsterm.h (ns_run_ascript): Declare.
3223 (NSAPP_DATA2_RUNASSCRIPT): Define.
3225 * nsfns.m (as_script, as_result, as_status): New static variables.
3226 (ns_run_ascript): New function.
3227 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3228 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3229 the event loop. Get status from as_status (Bug#7276).
3231 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3232 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3233 the event loop (Bug#7276).
3235 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3237 * gnutls.c (QCgnutls_bootprop_priority)
3238 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3239 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3240 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3241 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3242 (QCgnutls_bootprop_verify_hostname_error)
3243 (QCgnutls_bootprop_callbacks_verify): Rename from
3244 Qgnutls_bootprop_..., all uses changed.
3246 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3249 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3251 * xfaces.c (Qframe_set_background_mode): Now static.
3252 * dispextern.h (Qframe_set_background_mode): Remove decl.
3254 * process.c (Fnetwork_interface_info): Declare local only if needed.
3256 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3258 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3259 (Fnetwork_interface_list): Allocate in increments of bytes instead
3260 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3261 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3263 (struct ifflag_def): notrailers is smart on OSX.
3264 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3265 Get hardware address with getifaddrs if available.
3267 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3269 * xdisp.c (iterate_out_of_display_property): xassert that
3270 IT->position is set to within IT->object's boundaries. Break from
3271 the loop as soon as EOB is reached; avoids infloops in redisplay
3272 when IT->position is set up wrongly due to some bug.
3273 Set IT->current to match the bidi iterator unconditionally.
3274 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3275 entry. Force push_it to save on the stack the current
3276 buffer/string position, to be restored by pop_it. Fix flags in
3277 the iterator structure wrt the object coming from a display
3278 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3279 properties. (Bug#9284)
3281 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3283 * fontset.c (fontset_get_font_group): Add proper type checks.
3286 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3288 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3289 and LC_VERSION_MIN_MACOSX.
3290 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3291 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3293 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3295 * xdisp.c (forward_to_next_line_start): Allow to use the
3296 no-display-properties-and-no-overlays under bidi display.
3297 Set disp_pos in the bidi iterator to avoid searches for display
3298 properties and overlays.
3300 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3302 * editfns.c (Fset_time_zone_rule): Document relationship with the
3305 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3306 the font entity extracted from the cache (Bug#8109).
3308 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3310 * composite.c (autocmp_chars): Don't reset point. That is done by
3311 restore_point_unwind (Bug#5984).
3313 2011-08-07 Juri Linkov <juri@jurta.org>
3315 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3316 to show the arg `TIME' instead of `TIMEVAL'.
3318 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3320 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3321 display property strides EOL and includes a newline, as in
3322 longlines-mode. (Bug#9254)
3323 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3324 word-wrap under bidirectional display. (Bug#9224)
3326 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3327 is non-zero, even if the data buffer is NULL. Fixes a crash in
3328 vertical-motion with longlines-mode. (Bug#9254)
3330 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3332 * bidi.c <bidi_cache_total_alloc>: Now static.
3333 (bidi_initialize): Initialize bidi_cache_total_alloc.
3335 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3338 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3339 amount allocated this far in `bidi_cache_total_alloc'.
3340 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3341 non-zero, only free the data buffer without restoring the cache
3342 contents. All callers changed.
3344 * dispextern.h (bidi_unshelve_cache): Update prototype.
3346 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3347 (move_it_in_display_line, move_it_to)
3348 (move_it_vertically_backward, move_it_by_lines): Replace the call
3349 to xfree to an equivalent call to bidi_unshelve_cache.
3350 (move_it_in_display_line_to): Fix logic of returning
3351 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3353 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3356 came from a string character with a `cursor' property. (Bug#9229)
3358 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3360 * Makefile.in (LIB_PTHREAD): New variable.
3361 (LIBES): Add LIB_PTHREAD (Bug#9216).
3363 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3364 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3366 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3368 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3370 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3372 * xterm.c (x_find_topmost_parent): New function.
3373 (x_set_frame_alpha): Find topmost parent window with
3374 x_find_topmost_parent and set the property there also (bug#9181).
3375 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3377 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3379 * callproc.c (Fcall_process): Avoid vfork clobbering
3380 the local vars buffer, coding_systems, current_dir.
3382 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3384 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3386 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3388 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3389 so that it is not optimized away.
3391 * xdisp.c (compute_display_string_pos): Remove unused local.
3393 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3395 Fix slow cursor motion and scrolling in large buffers with
3396 selective display, like Org Mode buffers. (Bug#9218)
3398 * dispextern.h (struct bidi_it): New member disp_prop_p.
3400 * xdisp.c: Remove one-slot cache of display string positions.
3401 (compute_display_string_pos): Accept an additional argument
3402 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3403 for a display string or property. If found, set DISP_PROP_P
3406 * bidi.c (bidi_fetch_char): Accept an additional argument
3407 DISP_PROP_P, and pass it to compute_display_string_pos.
3408 Only handle text covered by a display string if DISP_PROP_P is returned
3409 non-zero. All callers of bidi_fetch_char changed.
3411 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3413 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3415 2010-12-03 Don March <don@ohspite.net>
3417 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3418 last character M-[char] is translated to ESC [char] (bug#7541).
3420 2011-08-02 Kenichi Handa <handa@m17n.org>
3422 * lisp.h (uniprop_table): Extern it.
3424 * chartab.c (uniprop_table): Make it non-static.
3426 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3428 * xdisp.c (forward_to_next_line_start): Accept additional argument
3429 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3431 (reseat_at_next_visible_line_start): Use the bidi iterator state
3432 returned by forward_to_next_line_start to restore the state of
3433 it->bidi_it after backing up to previous newline. (Bug#9212)
3435 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3437 * regex.c (re_comp): Protoize.
3438 (re_exec): Fix return type.
3439 (regexec): Fix type of `ret'. (Bug#9203)
3441 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3443 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3444 This is needed if max-image-size is a floating-point number.
3446 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3448 * print.c (print_object): Print empty symbol as ##.
3450 * lread.c (read1): Read ## as empty symbol.
3452 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3454 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3455 setting frame foreground color (Bug#9175).
3456 (x_set_background_color): Likewise.
3458 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3459 contents (Bug#9176).
3460 (EmacsTooltip -init): Remove bezels and add shadows to
3463 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3464 or scroll bar (Bug#8470).
3466 * nsfont.m (nsfont_open): Remove assignment to voffset and
3467 unnecessary vars hshink, expand, hd, full_height, min_height.
3468 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3470 * nsterm.h (nsfont_info): Remove voffset field.
3472 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3474 Implement strike-through and overline on NextStep (Bug#8863).
3476 * nsfont.m (nsfont_open): Use underline position provided by font,
3477 instead of hard-coded value of 2.
3478 (nsfont_draw): Call ns_draw_text_decoration instead.
3480 * nsterm.h: Add declaration for ns_draw_text_decoration.
3482 * nsterm.m (ns_draw_text_decoration): New function for drawing
3483 underline, overline, and strike-through.
3484 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3485 ns_draw_text_decoration. Change treatment of cursor drawing to
3486 accommodate underlining, etc.
3488 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3490 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3493 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3495 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3496 Without this fix, if a signal arrives just after memory fills up,
3497 'malloc' might be invoked reentrantly.
3499 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3500 In other words, assume that every image size is allowed, on non-X
3501 hosts. This assumption is probably wrong, but it lets Emacs compile.
3503 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3505 * regex.c (re_iswctype): Convert return values to boolean.
3507 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3509 * xdisp.c (compute_display_string_pos): Don't use cached display
3510 string position if the buffer had its restriction changed.
3513 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3517 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3519 Integer signedness and overflow and related fixes. (Bug#9079)
3521 * bidi.c: Integer size and overflow fixes.
3522 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3523 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3524 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3525 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3526 (bidi_find_other_level_edge):
3527 Use ptrdiff_t instead of EMACS_INT where either will do.
3528 This works better on 32-bit hosts configured --with-wide-int.
3529 (bidi_cache_ensure_space): Check for size-calculation overflow.
3530 Use % rather than repeated addition, for better worst-case speed.
3531 Don't set bidi_cache_size until after xrealloc returns, because it
3533 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3534 (bidi_cache_ensure_space): Also check that the bidi cache size
3535 does not exceed that of the largest Lisp string or buffer. See Eli
3536 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3538 * alloc.c (__malloc_size_t): Remove.
3539 All uses replaced by size_t. See Andreas Schwab's note
3540 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3542 * image.c: Improve checking for integer overflow.
3543 (check_image_size): Assume that f is nonnull, since
3544 it is always nonnull in practice. This is one less thing to
3545 worry about when checking for integer overflow later.
3546 (x_check_image_size): New function, which checks for integer
3547 overflow issues inside X.
3548 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3549 This removes the need for a memory_full check.
3550 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3551 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3552 (xbm_read_bitmap_data): Change locals back to 'int', since
3553 their values must fit in 'int'.
3554 (xpm_load_image, png_load, tiff_load):
3555 Invoke x_create_x_image_and_pixmap earlier,
3556 to avoid much needless work if the image is too large.
3557 (tiff_load): Treat overly large images as if
3558 x_create_x_image_and_pixmap failed, not as malloc failures.
3559 (gs_load): Use x_check_image_size.
3561 * gtkutil.c: Omit integer casts.
3562 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3563 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3565 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3567 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3568 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3569 would wrongly return t on a 64-bit host.
3571 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3572 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3573 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3574 and therefore cause GCC to emit a bogus diagnostic in some cases.
3576 * image.c: Integer signedness and overflow and related fixes.
3577 This is not an exhaustive set of fixes, but it's time to
3578 record what I've got.
3579 (lookup_pixel_color, check_image_size): Remove redundant decls.
3580 (check_image_size): Don't assume that arbitrary EMACS_INT values
3581 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3582 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3583 (tiff_load, imagemagick_load_image):
3584 Check for overflow in size calculations.
3585 (x_create_x_image_and_pixmap): Remove unnecessary test for
3586 xmalloc returning NULL; that can't happen.
3587 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3588 (xpm_color_bucket): Use better integer hashing function.
3589 (xpm_cache_color): Don't possibly over-allocate memory.
3590 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3591 (gif_memory_source):
3592 Use ptrdiff_t, not int or size_t, to record sizes.
3593 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3594 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3595 either works, as we prefer signed integers.
3596 (tiff_read_from_memory, tiff_write_from_memory):
3597 Return tsize_t, not size_t, since that's what the TIFF API wants.
3598 (tiff_read_from_memory): Don't fail simply because the read would
3599 go past EOF; instead, return a short read.
3600 (tiff_load): Omit no-longer-needed casts.
3601 (Fimagemagick_types): Don't assume size fits into 'int'.
3603 Improve hashing quality when configured --with-wide-int.
3604 * fns.c (hash_string): New function, taken from sxhash_string.
3605 Do not discard information about ASCII character case; this
3606 discarding is no longer needed.
3607 (sxhash-string): Use it. Change sig to match it. Caller changed.
3608 * lisp.h: Declare it.
3609 * lread.c (hash_string): Remove, since we now use fns.c's version.
3610 The fns.c version returns a wider integer if --with-wide-int is
3611 specified, so this should help the quality of the hashing a bit.
3613 * emacs.c: Integer overflow minor fix.
3614 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3615 Define only if GNU_LINUX.
3616 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3618 * dispnew.c: Integer signedness and overflow fixes.
3619 Remove unnecessary forward decls, that were a maintenance hassle.
3620 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3622 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3623 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3624 (prepare_desired_row, line_draw_cost):
3625 Use int, not unsigned, where either works.
3626 (save_current_matrix, restore_current_matrix):
3627 Use ptrdiff_t, not size_t, where either works.
3628 (init_display): Check for overflow more accurately, and without
3629 relying on undefined behavior.
3631 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3632 Remove, replacing with the new symbols in lisp.h. All uses changed.
3633 * fileio.c (make_temp_name):
3634 * filelock.c (lock_file_1, lock_file):
3635 * xdisp.c (message_dolog):
3636 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3637 Use pMd etc. instead.
3638 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3639 replacing the pWIDE etc. symbols removed from editfns.c.
3641 * keyboard.h (num_input_events): Now uintmax_t.
3642 This is (very slightly) less likely to mess up due to wraparound.
3645 * buffer.c: Integer signedness fixes.
3646 (alloc_buffer_text, enlarge_buffer_text):
3647 Use ptrdiff_t rather than size_t when either will do, as we prefer
3650 * alloc.c: Integer signedness and overflow fixes.
3651 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3652 (__malloc_size_t): Default to size_t, not to int.
3653 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3654 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3655 Prefer ptrdiff_t to size_t when either would do, as we prefer
3657 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3658 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3659 Now const. Initialize with values that are in range even if char
3661 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3662 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3663 These functions do the right thing with sizes > 2**32.
3664 (check_depth): Now ptrdiff_t, not int.
3665 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3666 Adjust to new way of storing sizes. Check for size overflow bugs
3668 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3669 slightly wrong anyway, as it missed one instance of
3670 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3671 (refill_memory_reserve): Omit needless cast to size_t.
3672 (mark_object_loop_halt): Mark as externally visible.
3674 * xselect.c: Integer signedness and overflow fixes.
3675 (Fx_register_dnd_atom, x_handle_dnd_message):
3676 Use ptrdiff_t, not size_t, since we prefer signed.
3677 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3678 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3679 x_dnd_atoms_size and x_dnd_atoms_length.
3681 * doprnt.c: Prefer signed to unsigned when either works.
3683 * doprnt.c (doprnt):
3685 * xdisp.c (vmessage):
3686 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3687 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3688 prefer signed arithmetic to avoid comparison confusion.
3689 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3690 but is a bit tricky.
3692 Assume freestanding C89 headers, string.h, stdlib.h.
3693 * data.c, doprnt.c, floatfns.c, print.c:
3694 Include float.h unconditionally.
3695 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3696 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3697 * regex.c: Likewise for stddef.h, string.h.
3698 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3699 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3700 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3701 (STDC_HEADERS): Remove obsolete defines.
3702 * sysdep.c: Include limits.h unconditionally.
3704 Assume support for memcmp, memcpy, memmove, memset.
3705 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3706 * regex.c (memcmp, memcpy):
3707 Remove; we assume C89 now.
3709 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3710 (__malloc_safe_bcopy): Remove; no longer needed.
3712 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3713 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3714 well either way, and we prefer signed to unsigned.
3716 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3718 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3719 closes the connection while we're reading (bug#9182).
3721 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3723 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3724 are specified (Bug#9168).
3726 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3728 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3729 Found by GCC static checking and --with-wide-int on a 32-bit host.
3731 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3733 * xdisp.c (compute_display_string_pos): Fix logic of caching
3734 previous display string position. Initialize cached_prev_pos to
3735 -1. Fixes slow-down at the beginning of a buffer.
3737 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3739 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3740 for attrs[LFACE_FONTSET_INDEX].
3742 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3744 * xml.c (parse_region): Remove unused local
3745 that was recently introduced.
3747 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3749 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3750 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3752 * xdisp.c (move_it_in_display_line_to): Record the best matching
3753 position for TO_CHARPOS while scanning the line, and restore it on
3754 exit if none of the characters scanned was an exact match.
3755 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3756 when exact match is impossible due to invisible text, and the
3757 lines are truncated.
3759 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3761 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3764 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3766 Fix a significant slow-down of cursor motion with C-n, C-p,
3767 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3768 auto-repeat under bidi redisplay in fontified buffers.
3769 * xdisp.c (compute_stop_pos_backwards): New function.
3770 (next_element_from_buffer): Call compute_stop_pos_backwards to
3771 find a suitable prev_stop when we find ourselves before
3773 (reseat): Don't look for prev_stop, as that could mean a very long
3775 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3776 <cached_disp_overlay_modiff>: Cache for last found display string
3778 (compute_display_string_pos): Return the cached position if asked
3779 about the same buffer in the same area of character positions, and
3780 the buffer wasn't changed since the time the display string
3781 position was cached.
3783 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3785 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3786 is an integer, which is important for empty lines. (Bug#9149)
3788 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3790 * frame.c (Fmodify_frame_parameters): In tty case, update the
3791 default face if necessary (Bug#4238).
3793 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3795 * editfns.c (Fstring_to_char): No need to explain what a character
3796 is in the docstring (Bug#6576).
3798 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3800 * xml.c (parse_region): Make sure we always return a tree.
3802 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3804 * xml.c (parse_region): If a document contains only comments,
3807 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3809 * xml.c (make_dom): Return comments, too.
3811 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3814 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3815 and the surrounding thread.
3816 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3817 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3818 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3820 * s/openbsd.h (BROKEN_SIGIO): Define.
3821 * unexelf.c (unexec) [__OpenBSD__]:
3822 Don't update the .mdebug section of the Alpha COFF symbol table.
3824 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3829 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3831 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3832 This fixes some race conditions on the permissions of any newly
3835 * alloc.c (valid_pointer_p): Use pipe, not open.
3836 This fixes some permissions issues when debugging.
3838 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3839 If fchown fails to set both uid and gid, try to set just gid,
3840 as that is sometimes allowed. Adjust the file's mode to eliminate
3841 setuid or setgid bits that are inappropriate if fchown fails.
3843 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3845 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3846 to compare Lisp_Objects.
3847 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3848 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3849 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3851 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3853 * lread.c (read_integer): Unread even EOF character.
3854 (read1): Likewise. Properly record start position of symbol.
3856 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3857 symbol character follows.
3859 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3861 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3862 This works around a problem with the previous change to Fcopy_file.
3863 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3864 and without this change, GCC might complain about discarding
3865 fchown's return value.
3867 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3869 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3871 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3873 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3875 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3877 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3878 it's used from the C level.
3880 * process.c: Use the same condition for POLL_FOR_INPUT in both
3881 keyboard.c and process.c (bug#1858).
3883 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3885 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3886 (Fgnutls_boot): Use it.
3888 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3890 * doc.c (Fsubstitute_command_keys): Revert last change.
3892 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3894 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3895 quotes the next character, and doesn't affect other longer
3896 sequences (bug#8935).
3898 * lread.c (syms_of_lread): Clarify that is isn't only
3899 `eval-buffer' and `eval-defun' that's affected by
3900 `lexical-binding' (bug#8460).
3902 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3904 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3905 bidi redisplay when a line includes both an image and is truncated.
3907 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3909 Fix minor problems found by static checking.
3910 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3911 (elsz): Now a signed constant, not a size_t var. We prefer signed
3912 types to unsigned, to avoid integer comparison confusion. Without
3913 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3914 "cannot optimize loop, the loop counter may overflow", a symptom
3916 * indent.c (Fvertical_motion): Mark locals as initialized.
3917 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3919 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3921 * search.c (Fre_search_backward): Mention `case-fold-search' in
3922 all the re_search_* functions (bug#8138).
3924 * keyboard.c (Fopen_dribble_file): Document when the file is
3927 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3929 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3932 Support bidi reordering of display and overlay strings.
3933 * xdisp.c (compute_display_string_pos)
3934 (compute_display_string_end): Accept additional argument STRING.
3935 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3936 (reseat_to_string): Initialize bidi_it->string.s and
3937 bidi_it->string.schars.
3938 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3939 NULL (avoids a crash in bidi_paragraph_init).
3940 Initialize itb.string.lstring.
3941 (init_iterator): Call bidi_init_it only of a valid
3942 buffer position was specified. Initialize paragraph_embedding to
3944 (reseat_to_string): Initialize the bidi iterator.
3945 (display_string): If we need to ignore text properties of
3946 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3947 original value of -1 will not work with bidi.)
3948 (compute_display_string_pos): First arg is now struct
3949 `text_pos *'; all callers changed. Support display properties on
3951 (compute_display_string_end): Support display properties on Lisp
3953 (init_iterator, reseat_1, reseat_to_string): Initialize the
3954 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3955 when iterating on a string not from display properties).
3956 (compute_display_string_pos, compute_display_string_end):
3957 Fix calculation of the object to scan. Fixes an error when using
3959 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3960 base_level_stop; instead, set base_level_stop to BEGV.
3961 Fixes crashes in vertical-motion.
3962 (next_element_from_buffer): Improve commentary for when
3963 the iterator is before prev_stop.
3964 (init_iterator): Initialize bidi_p from the default value of
3965 bidi-display-reordering, not from buffer-local value. Use the
3966 buffer-local value only if initializing for buffer iteration.
3967 (handle_invisible_prop): Support invisible properties on strings
3968 that are being bidi-reordered.
3969 (set_iterator_to_next): Support bidi reordering of C strings and
3971 (next_element_from_string): Support bidi reordering of Lisp
3973 (handle_stop_backwards): Support Lisp strings as well.
3974 (display_string): Support display of R2L glyph rows.
3975 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3976 (init_iterator): Don't initialize it->bidi_p for strings
3978 (reseat_to_string): Initialize it->bidi_p for strings here.
3979 (next_element_from_string, next_element_from_c_string)
3980 (next_element_from_buffer): Add xassert's for correspondence
3981 between IT's object being iterated and it->bidi_it.string
3983 (face_before_or_after_it_pos): Support bidi iteration.
3984 (next_element_from_c_string): Handle the case of the first string
3985 character that is not the first one in the visual order.
3986 (get_visually_first_element): New function, refactored from common
3987 parts of next_element_from_buffer, next_element_from_string, and
3988 next_element_from_c_string.
3989 (tool_bar_lines_needed, redisplay_tool_bar)
3990 (display_menu_bar): Force left-to-right direction. Add a FIXME
3991 comment for making that be controlled by a user option.
3992 (push_it, pop_it): Save and restore the state of the
3993 bidi iterator. Save and restore the bidi_p flag.
3994 (pop_it): Iterate out of display property for string iteration as
3996 (iterate_out_of_display_property): Support iteration over strings.
3997 (handle_single_display_spec): Set up it->bidi_it for iteration
3998 over a display string, and call bidi_init_it.
3999 (handle_single_display_spec, next_overlay_string)
4000 (get_overlay_strings_1, push_display_prop): Set up the bidi
4001 iterator for displaying display or overlay strings.
4002 (forward_to_next_line_start): Don't use the shortcut if
4004 (back_to_previous_visible_line_start): If handle_display_prop
4005 pushed the iterator stack, restore the internal state of the bidi
4006 iterator by calling bidi_pop_it same number of times.
4007 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4008 and we are bidi-iterating, don't decrement the iterator position;
4009 instead, set the first_elt flag in the bidi iterator, to produce
4011 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4012 (push_display_prop): xassert that we are iterating a buffer.
4013 (push_it, pop_it): Save and restore paragraph_embedding member.
4014 (handle_single_display_spec, next_overlay_string)
4015 (get_overlay_strings_1, reseat_1, reseat_to_string)
4016 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4017 correctly. Don't assume unibyte strings are not bidi-reordered.
4018 (compute_display_string_pos)
4019 (compute_display_string_end): Fix handling the case of C string.
4020 (push_it, pop_it): Save and restore from_disp_prop_p.
4021 (handle_single_display_spec, push_display_prop): Set the
4022 from_disp_prop_p flag.
4023 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4024 (pop_it): Call iterate_out_of_display_property only if we are
4025 popping after iteration over a string that came from a display
4026 property. Fix a typo in popping stretch info. Add an assertion
4027 for verifying that the iterator position is in sync with the bidi
4029 (handle_single_display_spec, get_overlay_strings_1)
4030 (push_display_prop): Fix initialization of paragraph direction for
4031 string when that of the parent object is not yet determined.
4032 (reseat_1): Call bidi_init_it to resync the bidi
4033 iterator with IT's position. (Bug#7616)
4034 (find_row_edges): If ROW->start.pos gives position
4035 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4036 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4037 Reset the from_disp_prop_p flag.
4038 (SAVE_IT, RESTORE_IT): New macros.
4039 (pos_visible_p, face_before_or_after_it_pos)
4040 (back_to_previous_visible_line_start)
4041 (move_it_in_display_line_to, move_it_in_display_line)
4042 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4043 (try_scrolling, redisplay_window, display_line): Use them when
4044 saving a temporary copy of the iterator and restoring it back.
4045 (back_to_previous_visible_line_start, reseat_1)
4046 (init_iterator): Empty the bidi cache "stack".
4047 (move_it_in_display_line_to): If iterator ended up at
4048 EOL, but we never saw any buffer positions smaller than
4049 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4050 motion in bidi-reordered lines.
4051 (move_it_in_display_line_to): Record prev_method and prev_pos
4052 immediately before the call to set_iterator_to_next. Fixes cursor
4053 motion in bidi-reordered lines with stretch glyphs and strings
4054 displayed in margins. (Bug#8133) (Bug#8867)
4055 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4057 (pos_visible_p): Support positions in bidi-reordered lines.
4058 Save and restore bidi cache.
4060 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4061 (bidi_paragraph_info): Delete unused struct.
4062 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4063 (bidi_cache_start): New variable.
4064 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4066 (bidi_cache_fetch_state, bidi_cache_search)
4067 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4068 (bidi_cache_find, bidi_peek_at_next_level)
4069 (bidi_level_of_next_char, bidi_find_other_level_edge)
4070 (bidi_move_to_visually_next): Compare cache index with
4071 bidi_cache_start rather than with zero.
4072 (bidi_fetch_char): Accept new argument STRING; all callers
4073 changed. Support iteration over a string. Support strings with
4074 display properties. Support unibyte strings. Fix the type of
4075 `len' according to what STRING_CHAR_AND_LENGTH expects.
4076 (bidi_paragraph_init, bidi_resolve_explicit_1)
4077 (bidi_resolve_explicit, bidi_resolve_weak)
4078 (bidi_level_of_next_char, bidi_move_to_visually_next):
4079 Support iteration over a string.
4080 (bidi_set_sor_type, bidi_resolve_explicit_1)
4081 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4082 can now be zero (for strings); special values 0 and -1 were
4083 changed to -1 and -2, respectively.
4084 (bidi_char_at_pos): New function.
4085 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4086 Call it instead of FETCH_MULTIBYTE_CHAR.
4087 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4088 initialized to valid values.
4089 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4091 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4092 the test for valid cached positions. Fix the logic for looking up
4093 the sentinel state in the cache. GCPRO the Lisp string we are
4095 (bidi_push_it, bidi_pop_it): New functions.
4096 (bidi_initialize): Initialize the bidi cache start stack pointer.
4097 (bidi_cache_ensure_space): New function, refactored from part of
4098 bidi_cache_iterator_state. Don't assume the required size is just
4099 one BIDI_CACHE_CHUNK away.
4100 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4101 (bidi_count_bytes, bidi_char_at_pos): New functions.
4102 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4103 always valid if bidi_cache_idx is valid.
4104 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4105 is valid if it's going to be used.
4106 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4107 (bidi_cache_fetch_state, bidi_cache_search)
4108 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4109 (bidi_cache_iterator_state, bidi_cache_find)
4110 (bidi_find_other_level_edge, bidi_cache_start_stack):
4111 All variables related to cache indices are now EMACS_INT.
4113 * dispextern.h (struct bidi_string_data): New structure.
4114 (struct bidi_it): New member `string'. Make flag members be 1-bit
4115 fields, and put them last in the struct.
4116 (compute_display_string_pos, compute_display_string_end):
4118 (bidi_push_it, bidi_pop_it): Add prototypes.
4119 (struct iterator_stack_entry): New members bidi_p,
4120 paragraph_embedding, and from_disp_prop_p.
4121 (struct it): Member bidi_p is now a bit field 1 bit wide.
4122 (bidi_shelve_cache, bidi_unshelve_cache):
4125 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4126 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4127 and vector-like objects.
4129 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4130 cache around display iteration.
4132 * window.c (Fwindow_end, window_scroll_pixel_based)
4133 (displayed_window_lines, Frecenter): Save and restore the bidi
4134 cache around display iteration.
4136 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4138 * editfns.c (Fdelete_region): Clarify the use of the named
4139 parameters (bug#6788).
4141 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4143 * indent.c (Fvertical_motion): Set and restore w->pointm when
4144 saving and restoring the window's buffer (Bug#9006).
4146 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4148 * editfns.c (Fstring_to_char): Clarify just what is returned
4149 (bug#6576). Text by Eli Zaretskii.
4151 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4153 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4155 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4157 * buffer.c (mmap_find): Fix a typo.
4159 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4161 Fix execution of x selection hooks.
4162 * xselect.c (Qx_lost_selection_functions)
4163 (Qx_sent_selection_functions): New vars.
4164 (syms_of_xselect): DEFSYM them.
4165 (x_handle_selection_request): Pass Qx_sent_selection_functions
4166 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4167 (x_handle_selection_clear,x_clear_frame_selections):
4168 Pass Qx_lost_selection_functions rather than
4169 Vx_lost_selection_functions to Frun_hook_with_args.
4171 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4173 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4174 The old code sometimes used this field without initializing it.
4176 * alloc.c (gc_sweep): Don't read past end of array.
4177 In theory, the old code could also have corrupted Emacs internals,
4178 though it'd be very unlikely.
4180 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4182 * character.c (Fcharacterp): Don't advertise optional ignored
4183 argument. (Bug#4026)
4185 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4190 * window.c (Fset_window_start): Doc fix (bug#4199).
4191 (Fset_window_hscroll): Ditto.
4193 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4195 Fix minor new problems caught by GCC 4.6.1.
4196 * term.c (init_tty): Remove unused local.
4197 * xsettings.c (store_monospaced_changed): Define this function only
4198 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4201 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4203 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4205 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4207 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4208 are the mini-buffer and the echo area (bug#3320).
4210 * term.c (init_tty): Remove support for supdup, c10 and perq
4211 terminals, which are no longer supported (bug#1482).
4213 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4215 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4217 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4219 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4220 for non-popups (Bug#3642).
4222 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4224 * alloc.c (reset_malloc_hooks): Protoize.
4225 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4226 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4227 * cm.c (losecursor): Likewise.
4228 * data.c (fmod): Likewise.
4229 * dispnew.c (swap_glyphs_in_rows): Likewise.
4230 * emacs.c (memory_warning_signal): Likewise.
4231 * floatfns.c (float_error): Likewise.
4232 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4233 (otf_open, font_otf_capability, generate_otf_features)
4234 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4236 * image.c (pbm_read_file): Likewise.
4237 * indent.c (string_display_width): Likewise.
4238 * intervals.c (check_for_interval, search_for_interval)
4239 (inc_interval_count, count_intervals, root_interval)
4240 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4241 * lread.c (defalias): Likewise.
4242 * ralloc.c (r_alloc_check): Likewise.
4243 * regex.c (set_image_of_range_1, set_image_of_range)
4244 (regex_grow_registers): Likewise.
4245 * sysdep.c (strerror): Likewise.
4246 * termcap.c (valid_filename_p, tprint, main): Likewise.
4247 * tparam.c (main): Likewise.
4248 * unexhp9k800.c (run_time_remap, save_data_space)
4249 (update_file_ptrs, read_header, write_header, calculate_checksum)
4250 (copy_file, copy_rest, display_header): Likewise.
4251 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4253 * xdisp.c (check_it): Likewise.
4254 * xfaces.c (register_color, unregister_color, unregister_colors):
4256 * xfns.c (print_fontset_result): Likewise.
4257 * xrdb.c (member, fatal, main): Likewise.
4259 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4261 Fix minor problems found by static checking (Bug#9031).
4262 * chartab.c (char_table_set_range, map_sub_char_table):
4263 Remove unused locals.
4264 (uniprop_table): Now static.
4265 * composite.c (_work_char): Remove unused static var.
4267 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4269 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4271 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4273 * gtkutil.c (qttip_cb): Remove code without function.
4275 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4277 * w32.c (pthread_sigmask): New stub.
4279 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4281 Use pthread_sigmask, not sigprocmask (Bug#9010).
4282 sigprocmask is portable only for single-threaded applications, and
4283 Emacs can be multi-threaded when it uses GTK.
4284 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4286 * callproc.c (Fcall_process):
4287 * process.c (create_process):
4288 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4289 Use pthread_sigmask, not sigprocmask.
4291 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4293 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4294 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4297 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4299 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4300 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4301 (xg_hide_tooltip): Fix comment.
4303 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4304 in registerServicesMenuSendTypes.
4305 (validRequestorForSendType): Don't check ns_return_types.
4307 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4310 2011-07-08 Jason Rumney <jasonr@gnu.org>
4312 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4313 SH_SHOW for hidden windows (Bug#5482).
4315 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4316 frame struct members of non-existent frames (Bug#6284).
4318 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4320 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4321 variable firstTime not needed on OSX >= 10.6.
4322 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4323 >= 10.5. Use setKnobProportion, setDoubleValue.
4325 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4326 (MAC_OS_X_VERSION_10_5): Define if not defined.
4327 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4328 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4329 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4331 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4332 cString and lossyCString on OSX >= 10.4
4334 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4335 sizeToFit on OSX >= 10.2.
4337 * nsimage.m (allocInitFromFile): Don't use deprecated method
4338 bestRepresentationForDevice on OSX >= 10.6.
4340 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4343 * emacs.c: Declare unexec_init_emacs_zone.
4345 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4347 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4349 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4350 on svcsMenu (Bug#8842).
4352 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4354 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4356 * nsterm.m (QUTF8_STRING): Declare.
4357 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4358 (validRequestorForSendType): Return type is (id).
4359 Change indexOfObjectIdenticalTo to indexOfObject.
4360 Check if we have local selection before returning self (Bug#8842).
4361 (writeSelectionToPasteboard): Put local selection into paste board
4362 if we have a local selection (Bug#8842).
4363 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4365 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4366 (ns_get_local_selection): Declare.
4368 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4370 * keymap.c (describe_map_tree): Don't insert a double newline at
4371 the end of the buffer (bug#1169) and return whether we inserted
4374 * callint.c (Fcall_interactively): Change "reading args" to
4375 "providing args" to try to clarify what it does (bug#1010).
4377 2011-07-07 Kenichi Handa <handa@m17n.org>
4379 * composite.c (composition_compute_stop_pos): Ignore a static
4380 composition starting before CHARPOS (Bug#8915).
4382 * xdisp.c (handle_composition_prop): Likewise.
4384 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4386 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4389 2011-07-07 Kenichi Handa <handa@m17n.org>
4391 * character.h (unicode_category_t): New enum type.
4393 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4394 (Qchar_code_property_table): New variable.
4395 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4396 (UNIPROP_COMPRESSED_FORM_P): New macros.
4397 (char_table_ascii): Uncompress the compressed values.
4398 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4399 Uncompress the compressed values.
4400 (sub_char_table_ref_and_range): Likewise.
4401 (char_table_ref_and_range): Uncompress the compressed values.
4402 (sub_char_table_set): New arg is_uniprop. Callers changed.
4403 Uncompress the compressed values.
4404 (sub_char_table_set_range): Args changed. Callers changed.
4405 (char_table_set_range): Adjuted for the above change.
4406 (map_sub_char_table): Delete args default_val and parent. Add arg
4407 top. Give decoded values to a Lisp function.
4408 (map_char_table): Adjust for the above change. Give decoded
4409 values to a Lisp function. Gcpro more variables.
4410 (uniprop_table_uncompress)
4411 (uniprop_decode_value_run_length): New functions.
4412 (uniprop_decoder, uniprop_decoder_count): New variables.
4413 (uniprop_get_decoder, uniprop_encode_value_character)
4414 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4416 (uniprop_encoder, uniprop_encoder_count): New variables.
4417 (uniprop_get_encoder, uniprop_table)
4418 (Funicode_property_table_internal, Fget_unicode_property_internal)
4419 (Fput_unicode_property_internal): New functions.
4420 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4421 Sunicode_property_table_internal, Sget_unicode_property_internal,
4422 and Sput_unicode_property_internal. Defvar_lisp
4423 char-code-property-alist.
4425 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4426 Vunicode_category_table.
4428 * font.c (font_range): Adjust for the change of
4429 Vunicode_category_table.
4431 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4433 * m/iris4d.h: Remove file, move contents ...
4434 * s/irix6-5.h: ... here.
4436 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4438 Remove unportable assumption about struct layout (Bug#8884).
4439 * alloc.c (mark_buffer):
4440 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4441 (clone_per_buffer_values): Don't assume that
4442 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4443 This isn't true in general, and it's particularly not true
4444 if Emacs is configured with --with-wide-int.
4445 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4446 New macros, used in the buffer.c change.
4448 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4450 * xsettings.c: Use both GConf and GSettings if both are available.
4451 (store_config_changed_event): Add comment.
4452 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4453 (store_tool_bar_style_changed): New functions.
4454 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4455 (struct xsettings): Move font inside HAVE_XFT.
4456 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4457 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4458 Move inside HAVE_XFT.
4459 (something_changed_gsettingsCB): Rename from something_changedCB.
4460 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4462 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4463 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4464 (something_changed_gconfCB): Rename from something_changedCB.
4465 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4466 (parse_settings): Move check for font inside HAVE_XFT.
4467 (read_settings, apply_xft_settings): Add comment.
4468 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4469 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4470 call store_font_name_changed.
4471 (xft_settings_event): Add comment.
4472 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4473 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4474 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4475 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4476 (xsettings_initialize): Call init_gsettings last.
4477 (xsettings_get_system_font, xsettings_get_system_normal_font):
4480 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4482 Random fixes. E.g., (random) never returned negative values.
4483 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4484 subseconds part to the entropy, as that's a bit more random.
4485 Prefer signed to unsigned, since the signedness doesn't matter and
4486 in general we prefer signed. When given a limit, use a
4487 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4488 latter isn't right if USE_2_TAGS_FOR_INTS.
4489 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4490 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4492 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4494 * textprop.c (text_property_stickiness):
4495 Obey Vtext_property_default_nonsticky.
4496 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4497 * w32fns.c (syms_of_w32fns):
4498 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4500 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4502 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4503 This is more efficient than Ffile_directory_p and avoids a minor race.
4505 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4507 * buffer.c (Foverlay_put): Say what the return value is
4510 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4511 is a directory before asking whether to use the file name
4513 (barf_or_query_if_file_exists): Make the "File is a directory"
4514 error be more correct.
4516 * fns.c (Frequire): Remove the mention of the .gz files, since
4517 that's installation-specific, but keep the mention of
4518 `get-load-suffixes'.
4520 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4522 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4523 Report string overflow if the output is too long.
4525 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4527 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4528 (syms_of_gnutls): Remove duplicate DEFSYM for
4529 Qgnutls_bootprop_verify_hostname_error, an error for
4530 Qgnutls_bootprop_verify_error (which is no longer used).
4532 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4533 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4534 Also (re)move comments that are misplaced or no longer relevant.
4536 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4538 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4540 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4542 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4543 and background color parameters if they have been changed.
4545 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4547 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4549 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4551 * xsettings.c (SYSTEM_FONT): Define only when used.
4552 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4554 * keymap.c (access_keymap_1): Now static.
4556 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4558 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4559 leave any prefix arg for the up event (Bug#1586).
4561 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4563 * lread.c (syms_of_lread): Mention single symbols defined by
4564 `defvar' or `defconst' (bug#7154).
4566 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4567 (Frequire): Mention get-load-suffixes.
4569 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4571 * window.h (window): Remove clone_number slot.
4572 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4574 (make_parent_window, make_window, saved_window)
4575 (Fset_window_configuration, save_window_save): Don't deal with
4577 * buffer.c (Qclone_number): Remove declaration.
4578 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4580 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4582 Add multiple inheritance to keymaps.
4583 * keymap.c (Fmake_composed_keymap): New function.
4584 (Fset_keymap_parent): Simplify.
4585 (fix_submap_inheritance): Remove.
4586 (access_keymap_1): New function extracted from access_keymap to handle
4587 embedded parents and handle lists of maps.
4588 (access_keymap): Use it.
4589 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4590 (Fcopy_keymap): Handle embedded parents.
4591 (Fcommand_remapping, define_as_prefix): Simplify.
4592 (Fkey_binding): Simplify.
4593 (syms_of_keymap): Move minibuffer-local-completion-map,
4594 minibuffer-local-filename-completion-map,
4595 minibuffer-local-must-match-map, and
4596 minibuffer-local-filename-must-match-map to Elisp.
4597 (syms_of_keymap): Defsubr make-composed-keymap.
4598 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4599 (parse_menu_item): Trivial simplification.
4601 2011-07-01 Glenn Morris <rgm@gnu.org>
4603 * Makefile.in (SETTINGS_LIBS): Fix typo.
4605 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4607 * coding.c (Fencode_coding_string): Record the last coding system
4608 used, as the function doc string says (bug#8738).
4610 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4612 * xsettings.c (store_monospaced_changed): Take new font as arg and
4613 check for change against current_mono_font.
4614 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4615 (emacs_settings_constructor, emacs_settings_get_property)
4616 (emacs_settings_set_property, emacs_settings_class_init)
4617 (emacs_settings_init, gsettings_obj): Remove.
4618 (something_changedCB): New function for HAVE_GSETTINGS.
4619 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4620 with value as argument.
4621 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4622 g_settings_new (Bug#8967). Do not create gsettings_obj.
4623 Remove calls to g_settings_bind. Connect something_changedCB to
4626 * xgselect.c: Add defined (HAVE_GSETTINGS).
4627 (xgselect_initialize): Ditto.
4629 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4630 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4633 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4635 * eval.c (struct backtrace): Simplify and port the data structure.
4636 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4637 signed bit field, as this assumption is not portable and it makes
4638 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4639 "char debug_on_exit : 1" as this is not portable either; instead,
4640 use the portable "unsigned int debug_on_exit : 1". Remove unused
4641 member evalargs. Remove obsolete comments about cc bombing out.
4643 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4645 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4646 Let HAVE_GSETTINGS override HAVE_GCONF.
4647 (store_monospaced_changed): New function.
4648 (EMACS_SETTINGS): A new type derived from GObject to handle
4649 GSettings notifications.
4650 (emacs_settings_constructor, emacs_settings_get_property)
4651 (emacs_settings_set_property, emacs_settings_class_init):
4653 (gsettings_client, gsettings_obj): New variables.
4654 (GSETTINGS_SCHEMA): New define.
4655 (something_changedCB): Call store_monospaced_changed.
4656 (init_gsettings): New function.
4657 (xsettings_initialize): Call init_gsettings.
4658 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4661 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4664 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4666 * window.c (resize_root_window, grow_mini_window)
4667 (shrink_mini_window): Rename Qresize_root_window to
4668 Qwindow_resize_root_window and Qresize_root_window_vertically to
4669 Qwindow_resize_root_window_vertically.
4671 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4673 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4675 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4677 * makefile.w32-in: Redesign dependencies so they reflect more
4678 clearly which files are directly included by each source file,
4679 and not through other includes.
4681 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4683 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4684 (sort_overlays, overlay_strings): When an overlay's clone number
4685 matches the window's clone number process the overlay even if
4686 the overlay's window property doesn't match the current window.
4688 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4689 (Fwindow_hchild): Rename to Fwindow_left_child.
4690 (Fwindow_next): Rename to Fwindow_next_sibling.
4691 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4692 (resize_window_check): Rename to window_resize_check.
4693 (resize_window_apply): Rename to window_resize_apply.
4694 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4695 (Fdelete_other_windows_internal, resize_frame_windows)
4696 (Fsplit_window_internal, Fdelete_window_internal)
4697 (grow_mini_window, shrink_mini_window)
4698 (Fresize_mini_window_internal): Fix callers accordingly.
4700 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4702 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4703 (emacs_fixed_set_min_size): Remove.
4704 (emacs_fixed_new): Take frame as argument.
4706 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4707 (_EmacsFixedPrivate): Remove minwidth/height.
4708 Add struct frame *f.
4709 (emacs_fixed_init): Initialize priv->f.
4710 (get_parent_class, emacs_fixed_set_min_size): Remove.
4711 (emacs_fixed_new): Set priv->f to argument.
4712 (emacs_fixed_get_preferred_width)
4713 (emacs_fixed_get_preferred_height): Use min_width/height from
4714 frames size_hint to set minimum and natural (Bug#8919).
4715 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4716 and use min_width/height from frames size_hint to set
4717 min_width/height (Bug#8919).
4719 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4720 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4723 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4725 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4726 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4729 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4731 * process.c (wait_reading_process_output): Bypass select if
4732 waiting for a cell while ignoring keyboard input, and input is
4733 pending. Suggested by Jan Djärv (Bug#8869).
4735 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4737 Use gnulib's dup2 module instead of rolling our own.
4738 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4740 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4742 * dispnew.c (scrolling_window): Before scrolling, turn off a
4743 mouse-highlight in the window being scrolled.
4745 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4747 Move DEFSYM to lisp.h and use everywhere.
4749 * character.h (DEFSYM): Move declaration...
4750 * lisp.h (DEFSYM): ...here.
4756 * w32select.c: Don't include character.h.
4758 * alloc.c (syms_of_alloc):
4759 * buffer.c (syms_of_buffer):
4760 * bytecode.c (syms_of_bytecode):
4761 * callint.c (syms_of_callint):
4762 * casefiddle.c (syms_of_casefiddle):
4763 * casetab.c (init_casetab_once):
4764 * category.c (init_category_once, syms_of_category):
4765 * ccl.c (syms_of_ccl):
4766 * cmds.c (syms_of_cmds):
4767 * composite.c (syms_of_composite):
4768 * dbusbind.c (syms_of_dbusbind):
4769 * dired.c (syms_of_dired):
4770 * dispnew.c (syms_of_display):
4771 * doc.c (syms_of_doc):
4772 * editfns.c (syms_of_editfns):
4773 * emacs.c (syms_of_emacs):
4774 * eval.c (syms_of_eval):
4775 * fileio.c (syms_of_fileio):
4776 * fns.c (syms_of_fns):
4777 * frame.c (syms_of_frame):
4778 * fringe.c (syms_of_fringe):
4779 * insdel.c (syms_of_insdel):
4780 * keymap.c (syms_of_keymap):
4781 * lread.c (init_obarray, syms_of_lread):
4782 * macros.c (syms_of_macros):
4783 * msdos.c (syms_of_msdos):
4784 * print.c (syms_of_print):
4785 * process.c (syms_of_process):
4786 * search.c (syms_of_search):
4787 * sound.c (syms_of_sound):
4788 * syntax.c (init_syntax_once, syms_of_syntax):
4789 * terminal.c (syms_of_terminal):
4790 * textprop.c (syms_of_textprop):
4791 * undo.c (syms_of_undo):
4792 * w32.c (globals_of_w32):
4793 * window.c (syms_of_window):
4794 * xdisp.c (syms_of_xdisp):
4795 * xfaces.c (syms_of_xfaces):
4796 * xfns.c (syms_of_xfns):
4797 * xmenu.c (syms_of_xmenu):
4798 * xsettings.c (syms_of_xsettings):
4799 * xterm.c (syms_of_xterm): Use DEFSYM.
4801 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4803 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4805 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4807 Integer and buffer overflow fixes (Bug#8873).
4809 * print.c (printchar, strout): Check for string overflow.
4810 (PRINTPREPARE, printchar, strout):
4811 Don't set size unless allocation succeeds.
4813 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4814 for sizes. Check for string overflow more accurately.
4815 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4817 * macros.c: Integer and buffer overflow fixes.
4818 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4819 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4820 Use ptrdiff_t, not int, for sizes.
4821 Don't increment bufsize until after realloc succeeds.
4822 Check for size-calculation overflow.
4823 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4825 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4827 * lread.c: Integer overflow fixes.
4828 (read_integer): Radix is now EMACS_INT, not int,
4829 to improve quality of diagnostics for out-of-range radices.
4830 Calculate buffer size correctly for out-of-range radices.
4831 (read1): Check for integer overflow in radices, and in
4832 read-circle numbers.
4833 (read_escape): Avoid int overflow.
4834 (Fload, openp, read_buffer_size, read1)
4835 (substitute_object_recurse, read_vector, read_list, map_obarray):
4836 Use ptrdiff_t, not int, for sizes.
4837 (read1): Use EMACS_INT, not int, for sizes.
4838 Check for size overflow.
4840 * image.c (cache_image): Check for size arithmetic overflow.
4842 * lread.c: Integer overflow issues.
4843 (saved_doc_string_size, saved_doc_string_length)
4844 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4845 Now ptrdiff_t, not int.
4846 (read1): Don't assume doc string length fits in int. Check for
4847 out-of-range doc string lengths.
4848 (read_list): Don't assume file position fits in int.
4849 (read_escape): Check for hex character overflow.
4851 2011-06-22 Leo Liu <sdl.web@gmail.com>
4853 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4854 Move to minibuffer.el.
4856 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4858 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4859 The following patches are for when GLYPH_DEBUG && !XASSERT.
4860 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4861 * dispnew.c (flush_stdout):
4862 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4863 Mark as externally visible.
4864 * dispnew.c (check_window_matrix_pointers): Now static.
4865 * dispnew.c (window_to_frame_vpos):
4866 * xfns.c (unwind_create_frame):
4867 * xterm.c (x_check_font): Remove unused local.
4868 * scroll.c (CHECK_BOUNDS):
4869 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4870 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4871 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4872 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4873 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4875 (debug_method_add): Use va_list and vsprintf rather than relying
4876 on undefined behavior with wrong number of arguments.
4877 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4878 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4879 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4880 since we're not interested in debugging glyphs with old libraries.
4881 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4882 GCC 4.6.0's static checking.
4884 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4886 Integer overflow and signedness fixes (Bug#8873).
4887 A few related buffer overrun fixes, too.
4889 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4891 * dispextern.h (struct face.stipple):
4892 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4893 (x_bitmap_mask, x_allocate_bitmap_record)
4894 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4895 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4896 (x_create_bitmap_from_xpm_data):
4897 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4898 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4900 * xfaces.c (load_pixmap):
4901 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4902 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4903 (.bitmaps_last, struct x_output.icon_bitmap):
4904 Use ptrdiff_t, not int, for bitmap indexes.
4905 (x_allocate_bitmap_record): Check for size overflow.
4906 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4908 Use ptrdiff_t, not int, for overlay counts.
4909 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4910 * editfns.c (overlays_around, get_pos_property):
4911 * textprop.c (get_char_property_and_overlay):
4912 * xdisp.c (next_overlay_change, note_mouse_highlight):
4913 * xfaces.c (face_at_buffer_position):
4914 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4915 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4916 (Fnext_overlay_change, Fprevious_overlay_change)
4917 (mouse_face_overlay_overlaps, Foverlays_in):
4918 Use ptrdiff_t, not int, for sizes.
4919 (overlays_at, overlays_in): Check for size-calculation overflow.
4921 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4923 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4924 (x_session_initialize): Do not assume string length fits in int.
4926 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4927 This is unlikely, but can occur if DPI is outlandish.
4929 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4930 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4932 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4933 * xrdb.c (magic_file_p, search_magic_path):
4934 Omit last arg SUFFIX; it was always 0. All callers changed.
4935 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4937 * xfont.c (xfont_match): Avoid need for strlen.
4939 * xfns.c: Don't assume strlen fits in int.
4940 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4942 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4943 not unsigned long, as we prefer signed integers. All callers changed.
4944 Detect integer overflow in repeat count.
4945 (message_dolog): Don't assume print length fits in 39 bytes.
4946 (display_mode_element): Don't assume strlen fits in int.
4948 * termcap.c: Don't assume sizes fit in int and never overflow.
4949 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4950 (gobble_line): Check for size-calculation overflow.
4952 * minibuf.c (Fread_buffer):
4953 * lread.c (intern, intern_c_string):
4954 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4955 Don't assume string length fits in int.
4957 * keyboard.c (parse_tool_bar_item):
4958 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4960 * font.c: Don't assume string length fits in int.
4961 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4962 Use ptrdiff_t, not int.
4963 (font_intern_prop): Don't assume string length fits in int.
4964 Don't assume integer property fits in fixnum.
4965 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4967 * filelock.c: Fix some buffer overrun and integer overflow issues.
4968 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4969 Reformulate so as not to need the command string.
4970 Invoke gzip -cd rather than gunzip, as it's more portable.
4971 (lock_info_type, lock_file_1, lock_file):
4972 Don't assume pid_t and time_t fit in unsigned long.
4973 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4974 (current_lock_owner): Prefer signed type for sizes.
4975 Use memcpy, not strncpy, where memcpy is what is really wanted.
4976 Don't assume (via atoi) that time_t and pid_t fit in int.
4977 Check for time_t and/or pid_t out of range, e.g., via a network share.
4978 Don't alloca where an auto var works fine.
4980 * fileio.c: Fix some integer overflow issues.
4981 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4982 Don't assume string length fits in int.
4983 (directory_file_name): Don't assume string length fits in long.
4984 (make_temp_name): Don't assume pid fits in int, or that its print
4985 length is less than 20.
4987 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4989 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4991 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4993 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4994 We prefer signed integers, even for size calculations.
4996 * emacs.c: Don't assume string length fits in 'int'.
4997 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4998 (main): Don't invoke strlen when not needed.
5000 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5001 (XD_DEBUG_MESSAGE): Don't waste a byte.
5003 * callproc.c (getenv_internal_1, getenv_internal)
5005 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5007 * lread.c (invalid_syntax): Omit length argument.
5008 All uses changed. This doesn't fix a bug, but it simplifies the
5009 code away from its former Hollerith-constant appearance, and it's
5010 one less 'int' to worry about when looking at integer-overflow issues.
5011 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5013 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5014 This didn't break anything, but it didn't help either.
5015 It's confusing to put a bogus integer in a place where the actual
5016 value does not matter.
5017 (LIST_END_P): Remove unused macro and its bogus comment.
5018 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5020 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5021 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5023 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5024 We prefer signed types, and the value cannot exceed the EMACS_INT
5025 range anyway (because otherwise the length would not be representable).
5026 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5027 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5028 This avoids a GCC warning when WIDE_EMACS_INT.
5030 * indent.c (sane_tab_width): New function.
5031 (current_column, scan_for_column, Findent_to, position_indentation)
5032 (compute_motion): Use it. This is just for clarity.
5033 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5035 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5037 * lisp.h (lint_assume): New macro.
5038 * composite.c (composition_gstring_put_cache):
5039 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5041 * editfns.c, insdel.c:
5042 Omit unnecessary forward decls, to simplify future changes.
5044 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5046 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5048 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5049 Use much-faster test for byte-length change.
5050 Don't assume string byte-length fits in 'int'.
5051 Check that character arg fits in 'int'.
5052 (mapcar1): Declare byte as byte, for clarity.
5054 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5056 * fns.c (concat): Catch string overflow earlier.
5057 Do not rely on integer wraparound.
5059 * dispextern.h (struct it.overlay_strings_charpos)
5060 (struct it.selective): Now EMACS_INT, not int.
5061 * xdisp.c (forward_to_next_line_start)
5062 (back_to_previous_visible_line_start)
5063 (reseat_at_next_visible_line_start, next_element_from_buffer):
5064 Don't arbitrarily truncate the value of 'selective' to int.
5066 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5068 * composite.c: Don't truncate sizes to 'int'.
5069 (composition_gstring_p, composition_reseat_it)
5070 (composition_adjust_point): Use EMACS_INT, not int.
5071 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5072 not EMACS_UINT, for indexes.
5074 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5076 * buffer.c: Include <verify.h>.
5077 (struct sortvec.priority, struct sortstr.priority):
5078 Now EMACS_INT, not int.
5079 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5080 (struct sortstr.size, record_overlay_string)
5081 (struct sortstrlist.size, struct sortlist.used):
5082 Don't truncate size to int.
5083 (record_overlay_string): Check for size-calculation overflow.
5084 (init_buffer_once): Check at compile-time, not run-time.
5086 2011-06-22 Jim Meyering <meyering@redhat.com>
5088 Don't leak an XBM-image-sized buffer
5089 * image.c (xbm_load): Free the image buffer after using it.
5091 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5094 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5095 that Sun C diagnosed.
5096 * fns.c (secure_hash): Fix pointer signedness issue.
5097 * intervals.c (static_offset_intervals): New function.
5098 (offset_intervals): Use it.
5100 2011-06-21 Leo Liu <sdl.web@gmail.com>
5103 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5106 * fns.c (secure_hash): Rename from crypto_hash_function and change
5107 the first arg to accept symbols.
5108 (Fsecure_hash): New primitive.
5109 (syms_of_fns): New symbols.
5111 2011-06-20 Deniz Dogan <deniz@dogan.se>
5113 * process.c (Fset_process_buffer): Clarify return value in
5116 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5118 * dispnew.c (add_window_display_history): Use BVAR.
5120 * xdisp.c (debug_method_add): Use BVAR.
5121 (check_window_end, dump_glyph_matrix, dump_glyph)
5122 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5124 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5127 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5128 check till after the cache is created in init_frame_faces.
5130 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5132 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5134 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5136 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5137 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5138 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5140 Improve buffer-overflow checking (Bug#8873).
5141 * fileio.c (Finsert_file_contents):
5142 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5143 Remove the old (too-loose) buffer overflow checks.
5144 They weren't needed, since make_gap checks for buffer overflow.
5145 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5146 The old code merely checked for Emacs fixnum overflow, and relied
5147 on undefined (wraparound) behavior. The new code avoids undefined
5148 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5150 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5151 Tune. Don't use wider integers than needed. Don't use alloca.
5152 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5154 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5156 * insdel.c, lisp.h (buffer_overflow): New function.
5157 (insert_from_buffer_1, replace_range, replace_range_2):
5158 * insdel.c (make_gap_larger):
5159 * editfns.c (Finsert_char):
5160 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5162 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5164 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5166 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5168 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5169 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5171 * fileio.c: Don't assume EMACS_INT fits in off_t.
5172 (emacs_lseek): New static function.
5173 (Finsert_file_contents, Fwrite_region): Use it.
5174 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5176 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5178 * fns.c: Don't overflow int when computing a list length.
5179 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5180 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5181 truncation on 64-bit hosts. Check for QUIT every
5182 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5183 faster and is responsive enough.
5184 (Flength): Report an error instead of overflowing an integer.
5185 (Fsafe_length): Return a float if the value is not representable
5186 as a fixnum. This shouldn't happen except in contrived situations.
5187 (Fnthcdr, Fsort): Don't assume list length fits in int.
5188 (Fcopy_sequence): Don't assume vector length fits in int.
5190 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5191 (header_size, word_size): New constants.
5192 (allocate_vectorlike): Don't check size overflow here.
5193 (allocate_vector): Check it here instead, since this is the only
5194 caller of allocate_vectorlike that could cause overflow.
5195 Check that the new vector's length is representable as a fixnum.
5197 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5198 The previous code was bogus. For example, next_almost_prime (32)
5199 returned 39, which is undesirable as it is a multiple of 3; and
5200 next_almost_prime (24) returned 25, which is a multiple of 5 so
5201 why was the code bothering to check for multiples of 7?
5203 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5205 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5207 Variadic C functions now count arguments with ptrdiff_t.
5208 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5209 Back then I didn't know that the Emacs coding style prefers signed int.
5210 Also, in the meantime I found a few more instances where arguments
5211 were being counted with int, which may truncate counts on 64-bit
5212 machines, or EMACS_INT, which may be unnecessarily wide.
5213 * lisp.h (struct Lisp_Subr.function.aMANY)
5214 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5215 Arg counts are now ptrdiff_t, not size_t.
5216 All variadic functions and their callers changed accordingly.
5217 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5218 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5219 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5220 * callint.c (Fcall_interactively): Check arg count for overflow,
5221 to avoid potential buffer overrun. Use signed char, not 'int',
5222 for 'varies' array, so that we needn't bother to check its size
5223 calculation for overflow.
5224 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5225 * eval.c (apply_lambda):
5226 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5227 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5228 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5230 * callint.c (Fcall_interactively): Don't use index var as event count.
5232 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5233 * mem-limits.h (SIZE): Remove; no longer used.
5235 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5237 Remove unnecessary casts.
5238 * xterm.c (x_term_init):
5239 * xfns.c (x_set_border_pixel):
5240 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5241 These aren't needed now that we assume ANSI C.
5243 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5244 It's more likely to cause problems (due to unsigned overflow)
5247 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5249 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5251 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5253 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5255 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5257 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5259 GLYPH_CODE_FACE returns EMACS_INT, not int.
5260 * dispextern.h (merge_faces):
5261 * xfaces.c (merge_faces):
5262 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5263 Don't assume EMACS_INT fits in int.
5265 * character.h (CHAR_VALID_P): Remove unused parameter.
5266 * fontset.c, lisp.h, xdisp.c: All uses changed.
5268 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5270 * fns.c (concat): Minor tuning based on overflow analysis.
5271 This doesn't fix any bugs. Use int to hold character, instead
5272 of constantly refetching from Emacs object. Use XFASTINT, not
5273 XINT, for value known to be a character. Don't bother comparing
5274 a single byte to 0400, as it's always less.
5276 * floatfns.c (Fexpt):
5277 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5279 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5282 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5284 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5285 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5286 incorrectly succeed when S was a string, because 4294967386 was
5287 truncated before it was used.
5289 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5290 Otherwise, an out-of-range integer could cause undefined behavior
5293 * composite.c: Use int, not EMACS_INT, for characters.
5294 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5295 EMACS_INT, for values that are known to be in character range.
5296 This doesn't fix any bugs but is the usual style inside Emacs and
5297 may generate better code on 32-bit machines.
5299 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5300 This is for reasons similar to the recent CHAR_STRING fix.
5301 * charset.c (Fencode_char): Check that character arg is actually
5302 a character. Pass an int to ENCODE_CHAR.
5303 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5304 wider than 'int', as a compile-time check to prevent future regressions
5307 * character.c (char_string): Remove unnecessary casts.
5309 Make sure a 64-bit char is never passed to CHAR_STRING.
5310 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5311 by silently ignoring the top 32 bits, allowing some values
5312 that were far too large to be valid characters.
5313 * character.h: Include <verify.h>.
5314 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5315 arguments are no wider than unsigned, as a compile-time check
5316 to prevent future regressions in this area.
5318 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5319 (Fsubst_char_in_region):
5321 * xdisp.c (decode_mode_spec_coding):
5322 Adjust to CHAR_STRING's new requirement.
5323 * editfns.c (Finsert_char, Fsubst_char_in_region):
5324 * fns.c (concat): Check that character args are actually
5325 characters. Without this test, these functions did the wrong
5326 thing with wildly out-of-range values on 64-bit hosts.
5328 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5329 These casts should not be needed on 32-bit hosts, either.
5330 * keyboard.c (read_char):
5331 * lread.c (Fload): Remove casts to unsigned.
5333 * lisp.h (UNSIGNED_CMP): New macro.
5334 This fixes comparison bugs on 64-bit hosts.
5335 (ASCII_CHAR_P): Use it.
5336 * casefiddle.c (casify_object):
5337 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5338 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5339 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5340 * dispextern.h (FACE_FROM_ID):
5341 * keyboard.c (read_char): Use UNSIGNED_CMP.
5343 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5344 not to EMACS_INT, to avoid GCC warning.
5346 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5348 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5349 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5350 isn't needed on 32-bit machines.
5352 * buffer.c (Fgenerate_new_buffer_name):
5353 Use EMACS_INT for count, not int.
5354 (advance_to_char_boundary): Return EMACS_INT, not int.
5356 * data.c (Qcompiled_function): Now static.
5358 * window.c (window_body_lines): Now static.
5360 * image.c (gif_load): Rename local to avoid shadowing.
5362 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5363 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5364 * alloc.c (make_save_value): Integer argument is now of type
5366 (mark_object): Use ptrdiff_t, not int.
5367 * lisp.h (pD): New macro.
5368 * print.c (print_object): Use it.
5370 * alloc.c: Use EMACS_INT, not int, to count objects.
5371 (total_conses, total_markers, total_symbols, total_vector_size)
5372 (total_free_conses, total_free_markers, total_free_symbols)
5373 (total_free_floats, total_floats, total_free_intervals)
5374 (total_intervals, total_strings, total_free_strings):
5375 Now EMACS_INT, not int. All uses changed.
5376 (Fgarbage_collect): Compute overall total using a double, so that
5377 integer overflow is less likely to be a problem. Check for overflow
5378 when converting back to an integer.
5379 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5380 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5381 These were 'int' variables that could overflow on 64-bit hosts;
5382 they were never used, so remove them instead of repairing them.
5383 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5384 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5385 Previously, this ceilinged at INT_MAX, but that doesn't work on
5387 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5389 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5390 (allocate_vectorlike): Check for ptrdiff_t overflow.
5391 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5392 when a (possibly-narrower) signed value would do just as well.
5393 We prefer using signed arithmetic, to avoid comparison confusion.
5395 * alloc.c: Catch some string size overflows that we were missing.
5396 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5397 for convenience in STRING_BYTES_MAX.
5398 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5399 The definition here is exact; the one in lisp.h was approximate.
5400 (allocate_string_data): Check for string overflow. This catches
5401 some instances we weren't catching before. Also, it catches
5402 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5403 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5404 and ptrdiff_t and EMACS_INT are both 64 bits.
5406 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5407 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5408 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5410 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5412 * alloc.c (Fmake_string): Check for out-of-range init.
5414 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5416 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5418 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5420 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5421 xg_get_default_scrollbar_width.
5423 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5424 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5425 (style_changed_cb): Call update_theme_scrollbar_width and call
5426 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5427 all frames (Bug#8505).
5428 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5429 Call gtk_window_set_resizable if HAVE_GTK3.
5430 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5431 and height if HAVE_GTK3 (Bug#8505).
5432 (scroll_bar_width_for_theme): New variable.
5433 (update_theme_scrollbar_width): New function.
5434 (xg_get_default_scrollbar_width): Move code to
5435 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5436 (xg_initialize): Call update_theme_scrollbar_width.
5438 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5440 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5442 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5444 * frame.c (make_frame): Call other_buffer_safely instead of
5447 * window.c (temp_output_buffer_show): Call display_buffer with
5448 second argument Vtemp_buffer_show_specifiers and reset latter
5449 immediately after the call.
5450 (Vtemp_buffer_show_specifiers): New variable.
5451 (auto_window_vscroll_p, next_screen_context_lines)
5452 (Vscroll_preserve_screen_position): Remove leading asterisks from
5455 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5457 Fix minor problems found by GCC 4.6.0 static checking.
5458 * buffer.c (Qclone_number): Remove for now, as it's unused.
5459 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5460 (record_buffer): Remove unused local.
5461 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5462 (set_frame_buffer_list): Remove; unused.
5463 * frame.h (other_visible_frames): Remove decl.
5464 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5465 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5466 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5468 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5469 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5470 Define only if HAVE_GPM.
5471 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5472 (update_hints_inhibit): Remove; never set. All uses removed.
5473 * widgetprv.h (emacsFrameClassRec): Remove decl.
5474 * window.c (delete_deletable_window): Now returns void, since it
5475 wasn't returning anything.
5476 (compare_window_configurations): Remove unused locals.
5477 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5478 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5479 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5480 the same widths as pointers. This follows up on the 2011-05-06 patch.
5481 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5482 * xterm.h: Likewise.
5483 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5485 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5487 * makefile.w32-in: Update dependencies.
5488 (LISP_H): Add lib/intprops.h.
5490 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5492 * image.c (gif_load): Add animation frame delay to the metadata.
5493 (syms_of_image): Use DEFSYM. New symbol `delay'.
5495 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5497 * window.c (delete_deletable_window): Re-add.
5498 (Fset_window_configuration): Rewrite to handle dead buffers and
5499 consequently deletable windows.
5500 (window_tree, Fwindow_tree): Remove. Supply functionality in
5502 (compare_window_configurations): Simplify code.
5504 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5506 * image.c (imagemagick_load_image): Fix type mismatch.
5507 (Fimagemagick_types): Likewise.
5509 * window.h (replace_buffer_in_windows): Declare.
5511 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5513 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5514 Qclone_number. Remove external declaration of Qdelete_window.
5515 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5517 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5518 Run Qbuffer_list_update_hook if allowed.
5519 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5520 buffer list implementation.
5521 (other_buffer_safely): New function.
5522 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5523 calls to replace_buffer_in_windows and
5524 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5526 (record_buffer): Inhibit quitting and rewrite using quittable
5527 functions. Run Qbuffer_list_update_hook if allowed.
5528 (Frecord_buffer, Funrecord_buffer): New functions.
5529 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5530 Move switch-to-buffer to window.el.
5531 (bury-buffer): Move to window.el.
5532 (Vbuffer_list_update_hook): New variable.
5534 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5537 * window.h (resize_frame_windows): Move up in code.
5538 (Fwindow_frame): Remove EXFUN.
5539 (replace_buffer_in_all_windows): Remove prototype.
5540 (replace_buffer_in_windows_safely): Add prototype.
5542 * window.c: Declare Qdelete_window static again. Move down
5543 declaration of select_count.
5544 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5545 (Fother_window): Move to window.el.
5546 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5547 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5548 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5550 (replace_buffer_in_windows): Implement by calling
5551 Qreplace_buffer_in_windows.
5552 (replace_buffer_in_all_windows): Remove with some functionality
5553 moved into replace_buffer_in_windows_safely.
5554 (replace_buffer_in_windows_safely): New function.
5555 (select_window_norecord, select_frame_norecord): Move in front
5556 of run_window_configuration_change_hook. Remove now obsolete
5558 (Fset_window_buffer): Rewrite doc-string.
5559 Call Qrecord_window_buffer.
5560 (keys_of_window): Move binding for other-window to window.el.
5562 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5564 * dispextern.h (struct image): Replace data member, whose int_val
5565 and ptr_val fields were not used by anything, with a single
5568 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5569 (gif_clear_image, gif_load, imagemagick_load_image)
5570 (gs_clear_image, gs_load): Callers changed.
5572 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5574 * buffer.h: Include <time.h>, for time_t.
5575 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5577 Fix minor problems found by static checking.
5579 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5581 Make identifiers static if they are not used in other modules.
5582 * data.c (Qcompiled_function, Qframe, Qvector):
5583 * image.c (QimageMagick, Qsvg):
5584 * minibuf.c (Qmetadata):
5585 * window.c (resize_window_check, resize_root_window): Now static.
5586 * window.h (resize_window_check, resize_root_window): Remove decls.
5588 * window.c (window_deletion_count, delete_deletable_window):
5590 (window_body_lines): Now static.
5591 (Fdelete_other_windows_internal): Mark vars as initialized.
5592 Make sure 'resize_failed' is initialized.
5593 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5594 (resize_window_apply): Remove unused local.
5595 * window.h (delete_deletable_window): Remove decl.
5597 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5598 (imagemagick_load_image): Fix pointer signedness problem by changing
5599 last arg from unsigned char * to char *. All uses changed.
5600 Also, fix a local for similar reasons.
5601 Remove unused locals. Remove locals to avoid shadowing.
5602 (fn_rsvg_handle_free): Remove; unused.
5603 (svg_load, svg_load_image): Fix pointer signedness problem.
5604 (imagemagick_load_image): Don't use garbage pointer image_wand.
5606 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5608 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5610 * image.c (gif_load): Fix omitted cast error introduced by
5613 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5615 * window.h (resize_proportionally, orig_total_lines)
5616 (orig_top_line): Remove from window structure.
5617 (set_window_height, set_window_width, change_window_heights)
5618 (Fdelete_window): Remove prototypes.
5619 (resize_frame_windows): Remove duplicate declaration.
5621 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5623 * window.h (resize_frame_windows, resize_window_check)
5624 (delete_deletable_window, resize_root_window)
5625 (resize_frame_windows): Declare prototypes.
5627 * window.c (resize_window_apply): Make definition be "static" to
5628 match the prototype.
5630 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5632 * window.c: Remove declarations of Qwindow_size_fixed,
5633 window_min_size_1, window_min_size_2, window_min_size,
5634 size_window, window_fixed_size_p, enlarge_window, delete_window.
5635 Remove static from declaration of Qdelete_window, it's
5636 temporarily needed by Fbury_buffer.
5637 (replace_window): Don't assign orig_top_line and
5639 (Fdelete_window, delete_window): Remove. Window deletion is
5640 handled by window.el.
5641 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5642 Replace Fdelete_window calls with calls to Qdelete_window.
5643 (Fdelete_other_windows): Remove. Deleting other windows is
5644 handled by window.el.
5645 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5646 handled in window.el.
5647 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5648 Window minimum sizes are handled in window.el.
5649 (shrink_windows, size_window, set_window_height)
5650 (set_window_width, change_window_heights, window_height)
5651 (window_width, CURBEG, CURSIZE, enlarge_window)
5652 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5653 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5654 handled in window.el.
5655 (make_dummy_parent): Rename to make_parent_window and give it a
5656 second argument horflag.
5657 (make_window): Don't set resize_proportionally any more.
5658 (Fsplit_window): Remove. Windows are split in window.el.
5659 (save_restore_action, save_restore_orig_size)
5660 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5661 Resize mini windows in window.el.
5662 (grow_mini_window, shrink_mini_window): Implement by calling
5663 Qresize_root_window_vertically, resize_window_check and
5664 resize_window_apply.
5665 (saved_window, Fset_window_configuration, save_window_save):
5666 Do not handle orig_top_line, orig_total_lines, and
5667 resize_proportionally.
5668 (window_min_height, window_min_width): Move to window.el.
5669 (keys_of_window): Move bindings for delete-other-windows,
5670 split-window, delete-window and enlarge-window to window.el.
5672 * buffer.c: Temporarily extern Qdelete_window.
5673 (Fbury_buffer): Temporarily call Qdelete_window instead of
5674 Fdelete_window (Fbury_buffer will move to window.el soon).
5676 * frame.c (set_menu_bar_lines_1): Remove code handling
5677 orig_top_line and orig_total_lines.
5679 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5680 set_window_height but set heights directly.
5681 (change_frame_size_1): Use resize_frame_windows.
5683 * xdisp.c (init_xdisp): Don't use set_window_height but set
5686 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5687 Use resize_frame_windows instead of change_window_heights and run
5688 run_window_configuration_change_hook.
5690 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5691 instead of change_window_heights and run
5692 run_window_configuration_change_hook.
5694 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5696 * window.c (replace_window): Rename second argument REPLACEMENT to
5697 NEW. New third argument SETFLAG. Rewrite.
5698 (delete_window, make_dummy_parent): Call replace_window with
5700 (window_list_1): Move down in code.
5701 (run_window_configuration_change_hook): Move set_buffer part
5702 before select_frame_norecord part in order to unwind correctly.
5703 Rename count1 to count.
5704 (recombine_windows, delete_deletable_window, resize_root_window)
5705 (Fdelete_other_windows_internal)
5706 (Frun_window_configuration_change_hook, make_parent_window)
5707 (resize_window_check, resize_window_apply, Fresize_window_apply)
5708 (resize_frame_windows, Fsplit_window_internal)
5709 (Fdelete_window_internal, Fresize_mini_window_internal):
5711 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5713 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5715 * window.h (window): Add some new members to window structure -
5716 normal_lines, normal_cols, new_total, new_normal, clone_number,
5717 splits, nest, prev_buffers, next_buffers.
5718 (WINDOW_TOTAL_SIZE): Move here from window.c.
5719 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5721 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5723 (make_dummy_parent): Set new members of windows structure.
5724 (make_window): Move down in code. Handle new members of window
5726 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5727 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5728 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5729 (Fset_window_prev_buffers, Fwindow_next_buffers)
5730 (Fset_window_next_buffers, Fset_window_clone_number):
5732 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5733 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5735 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5736 Argument WINDOW can be now internal window too.
5737 (Fwindow_use_time): Move up in code.
5738 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5740 (Fset_window_configuration, saved_window)
5741 (Fcurrent_window_configuration, save_window_save): Handle new
5742 members of window structure.
5743 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5744 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5745 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5746 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5747 Qget_mru_window, Qresize_root_window,
5748 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5749 Qauto_buffer_name; staticpro them.
5751 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5753 * window.c (Fwindow_total_size, Fwindow_left_column)
5754 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5755 (Fwindow_list_1): New functions.
5756 (window_box_text_cols): Replace with window_body_cols.
5757 (Fwindow_width, Fscroll_left, Fscroll_right):
5758 Use window_body_cols instead of window_box_text_cols.
5759 (delete_window, Fset_window_configuration):
5760 Call delete_all_subwindows with window as argument.
5761 (delete_all_subwindows): Take a window as argument and not a
5763 (window_loop): Remove handling of GET_LRU_WINDOW and
5765 (Fget_lru_window, Fget_largest_window): Move to window.el.
5767 * window.h: Extern window_body_cols instead of
5768 window_box_text_cols. delete_all_subwindows now takes a
5769 Lisp_Object as argument.
5771 * indent.c (compute_motion, Fcompute_motion):
5772 Use window_body_cols instead of window_box_text_cols.
5774 * frame.c (delete_frame): Call delete_all_subwindows with root
5777 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5779 * fns.c (Fputhash): Document return value.
5781 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5783 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5785 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5787 Cons<->int and similar integer overflow fixes (Bug#8794).
5789 Check for overflow when converting integer to cons and back.
5790 * charset.c (Fdefine_charset_internal, Fdecode_char):
5791 Use cons_to_unsigned to catch overflow.
5792 (Fencode_char): Use INTEGER_TO_CONS.
5793 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5794 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5795 * data.c (long_to_cons, cons_to_long): Remove.
5796 (cons_to_unsigned, cons_to_signed): New functions.
5797 These signal an error for invalid or out-of-range values.
5798 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5799 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5800 * font.c (Ffont_variation_glyphs):
5801 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5802 * lisp.h: Include <intprops.h>.
5803 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5804 (cons_to_signed, cons_to_unsigned): New decls.
5805 (long_to_cons, cons_to_long): Remove decls.
5806 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5807 (Fprimitive_undo): Use CONS_TO_INTEGER.
5808 * xfns.c (Fx_window_property): Likewise.
5809 * xselect.c: Include <limits.h>.
5810 (x_own_selection, selection_data_to_lisp_data):
5811 Use INTEGER_TO_CONS.
5812 (x_handle_selection_request, x_handle_selection_clear)
5813 (x_get_foreign_selection, Fx_disown_selection_internal)
5814 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5815 (lisp_data_to_selection_data): Use cons_to_unsigned.
5816 (x_fill_property_data): Use cons_to_signed.
5817 Report values out of range.
5819 Check for buffer and string overflow more precisely.
5820 * buffer.h (BUF_BYTES_MAX): New macro.
5821 * lisp.h (STRING_BYTES_MAX): New macro.
5822 * alloc.c (Fmake_string):
5823 * character.c (string_escape_byte8):
5824 * coding.c (coding_alloc_by_realloc):
5825 * doprnt.c (doprnt):
5826 * editfns.c (Fformat):
5828 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5829 since they may not be the same number.
5830 * editfns.c (Finsert_char):
5831 * fileio.c (Finsert_file_contents):
5832 Likewise for BUF_BYTES_MAX.
5834 * image.c: Use ptrdiff_t, not int, for sizes.
5835 (slurp_file): Switch from int to ptrdiff_t.
5837 (slurp_file): Check that file size fits in both size_t (for
5838 malloc) and ptrdiff_t (for sanity and safety).
5840 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5841 if b->modtime has its maximal value.
5843 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5845 Don't assume time_t can fit into int.
5846 * buffer.h (struct buffer.modtime): Now time_t, not int.
5847 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5848 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5850 Minor fixes for signed vs unsigned integers.
5851 * character.h (MAYBE_UNIFY_CHAR):
5852 * charset.c (maybe_unify_char):
5853 * keyboard.c (read_char, reorder_modifiers):
5854 XINT -> XFASTINT, since the integer must be nonnegative.
5855 * ftfont.c (ftfont_spec_pattern):
5856 * keymap.c (access_keymap, silly_event_symbol_error):
5857 XUINT -> XFASTINT, since the integer must be nonnegative.
5858 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5859 since it makes no difference and we prefer signed.
5860 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5861 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5864 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5866 * window.h (Fwindow_frame): Declare.
5868 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5870 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5871 (SPARE_MEMORY): Always define.
5872 (LARGE_REQUEST): Remove.
5873 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5875 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5877 * lisp.h: Move EXFUNS for Fframe_root_window,
5878 Fframe_first_window and Fset_frame_selected_window to window.h.
5880 * window.h: Move EXFUNS for Fframe_root_window,
5881 Fframe_first_window and Fset_frame_selected_window here from
5884 * frame.c (Fwindow_frame, Fframe_first_window)
5885 (Fframe_root_window, Fframe_selected_window)
5886 (Fset_frame_selected_window): Move to window.c.
5887 (Factive_minibuffer_window): Move to minibuf.c.
5888 (Fother_visible_frames_p): New function.
5890 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5892 * window.c (decode_window, decode_any_window): Move up in code.
5893 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5894 (inhibit_frame_unsplittable): Remove unused variable.
5895 (Fwindow_buffer): Move up and rewrite doc-string.
5896 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5897 (Fwindow_prev): New functions.
5898 (Fwindow_frame): Move here from frame.c. Accept any window as
5900 (Fframe_root_window, Fframe_first_window)
5901 (Fframe_selected_window): Move here from frame.c. Accept frame
5902 or arbitrary window as argument. Update doc-strings.
5903 (Fminibuffer_window): Move up in code.
5904 (Fwindow_minibuffer_p): Move up in code and simplify.
5905 (Fset_frame_selected_window): Move here from frame.c.
5907 (Fselected_window, select_window, Fselect_window): Move up in
5908 code. Minor doc-string fixes.
5910 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5912 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5913 Do not assume that spare memory exists; that assumption is valid
5914 only if SYSTEM_MALLOC.
5915 (LARGE_REQUEST): New macro, so that the issue of large requests
5916 is separated from the issue of spare memory.
5918 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5920 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5923 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5925 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5928 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5930 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5932 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5934 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5935 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5937 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5939 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5941 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5943 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5944 (x_clipboard_manager_save): Add return value.
5945 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5947 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5948 Obey Vx_select_enable_clipboard_manager. Catch errors in
5949 x_clipboard_manager_save (Bug#8779).
5950 (Vx_select_enable_clipboard_manager): New variable.
5951 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5953 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5955 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5957 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5959 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5960 in the current matrix if keep_current_p is non-zero.
5962 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5964 * bidi.c (bidi_level_of_next_char): Fix last change.
5966 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5968 Support bidi reordering of text covered by display properties.
5970 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5971 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5972 (bidi_cache_search, bidi_cache_iterator_state)
5973 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5974 (bidi_level_of_next_char, bidi_move_to_visually_next):
5975 Support character positions inside a run of characters covered by a
5977 (bidi_paragraph_init, bidi_resolve_explicit_1)
5978 (bidi_level_of_next_char): Call bidi_fetch_char and
5979 bidi_fetch_char_advance instead of FETCH_CHAR and
5981 (bidi_init_it): Initialize new members.
5982 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5984 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5985 instead of using explicit *_CHAR codes.
5986 (bidi_resolve_explicit, bidi_resolve_weak):
5987 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5988 bidirectional text is supported only in multibyte buffers.
5989 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5990 it to initialize the frame_window_p member of struct bidi_it.
5991 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5992 (bidi_resolve_explicit, bidi_resolve_weak)
5993 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5994 bidi_it->nchars is non-positive.
5995 (bidi_level_of_next_char): Don't try to lookup the cache for the
5996 next/previous character if nothing is cached there yet, or if we
5997 were just reseat()'ed to a new position.
5999 * xdisp.c (set_cursor_from_row): Set start and stop points
6000 according to the row's direction when priming the loop that looks
6001 for the glyph on which to display cursor.
6002 (single_display_spec_intangible_p): Function deleted.
6003 (display_prop_intangible_p): Reimplement to call
6004 handle_display_spec instead of single_display_spec_intangible_p.
6005 Accept 3 additional arguments needed by handle_display_spec.
6006 This fixes incorrect cursor motion across display property with complex
6007 values: lists, `(when COND...)' forms, etc.
6008 (single_display_spec_string_p): Support property values that are
6009 lists with the argument STRING its top-level element.
6010 (display_prop_string_p): Fix the condition for processing a
6011 property that is a list to be consistent with handle_display_spec.
6012 (handle_display_spec): New function, refactored from the
6013 last portion of handle_display_prop.
6014 (compute_display_string_pos): Accept additional argument
6015 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6016 value of a `display' property is a "replacing spec".
6017 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6018 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6019 the display property, but just return a value indicating whether
6020 the display property will replace the characters it covers.
6021 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6022 frame_window_p members of struct bidi_it.
6023 (compute_display_string_pos, compute_display_string_end):
6025 (push_it): Accept second argument POSITION, where pop_it should
6026 jump to continue iteration.
6027 (reseat_1): Initialize bidi_it.disp_pos.
6029 * keyboard.c (adjust_point_for_property): Adjust the call to
6030 display_prop_intangible_p to its new signature.
6032 * dispextern.h (struct bidi_it): New member frame_window_p.
6033 (bidi_init_it): Update prototypes.
6034 (display_prop_intangible_p): Update prototype.
6035 (compute_display_string_pos, compute_display_string_end):
6037 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6040 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6042 Malloc failure behavior now depends on size of allocation.
6043 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6044 * lisp.h: Change signatures accordingly.
6045 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6046 All callers changed. (Bug#8762)
6048 * gnutls.c: Use Emacs's memory allocators.
6049 Without this change, the gnutls library would invoke malloc etc.
6050 directly, which causes problems on non-SYNC_INPUT hosts, and which
6051 runs afoul of improving memory_full behavior. (Bug#8761)
6052 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6053 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6054 xfree instead of the default malloc, realloc, free.
6055 (Fgnutls_boot): No need to check for memory allocation failure,
6056 since xmalloc does that for us.
6058 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6059 * category.c (hash_get_category_set):
6060 * ccl.c (ccl_driver):
6061 * charset.c (Fdefine_charset_internal):
6062 * charset.h (struct charset.hash_index):
6063 * composite.c (get_composition_id, gstring_lookup_cache)
6064 (composition_gstring_put_cache):
6065 * composite.h (struct composition.hash_index):
6066 * dispextern.h (struct image.hash):
6067 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6068 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6069 (hashfn_equal, hashfn_user_defined, make_hash_table)
6070 (maybe_resize_hash_table, hash_lookup, hash_put)
6071 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6072 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6073 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6074 * image.c (make_image, search_image_cache, lookup_image)
6075 (xpm_put_color_table_h):
6076 * lisp.h (struct Lisp_Hash_Table):
6077 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6078 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6079 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6080 * alloc.c (allocate_vectorlike):
6081 Check for overflow in vector size calculations.
6082 * ccl.c (ccl_driver):
6083 Check for overflow when converting EMACS_INT to int.
6084 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6085 need to be updated by these changes.
6086 * fns.c (make_hash_table, maybe_resize_hash_table):
6087 Check for integer overflow with large hash tables.
6088 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6089 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6090 (SXHASH_REDUCE): New macro.
6091 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6092 Use it instead of discarding useful hash info with large hash values.
6093 (sxhash_float): New function.
6094 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6095 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6096 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6097 Rewrite to use FIXNUM_BITS, as this simplifies things.
6098 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6099 Adjust signatures to match updated version of code.
6100 (consing_since_gc): Now EMACS_INT, since a single hash table can
6101 use more than INT_MAX bytes.
6103 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6105 Make it possible to build with GCC-4.6+ -O2 -flto.
6107 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6109 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6111 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6112 Call minibuffer-inactive-mode.
6114 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6116 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6117 Update dependencies.
6119 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6121 * data.c (init_data): Remove code for UTS, this system is not
6124 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6126 Don't force ./temacs to start in terminal mode.
6128 * frame.c (make_initial_frame): Initialize faces in all cases, not
6129 only when CANNOT_DUMP is defined.
6130 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6132 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6134 * dispnew.c (add_window_display_history): Use const for the string
6135 pointer. Remove declaration, not needed.
6137 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6139 Use 'inline', not 'INLINE'.
6140 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6141 * alloc.c, fontset.c (INLINE): Remove.
6142 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6143 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6144 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6145 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6146 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6148 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6150 Make it possible to run ./temacs.
6152 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6153 syms_of_callproc does the same thing. Remove test for
6154 "initialized", do it in the caller.
6155 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6157 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6159 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6160 (read_minibuf): Use get_minibuffer.
6161 (syms_of_minibuf): Use DEFSYM.
6162 (Qmetadata): New var.
6163 * data.c (Qbuffer): Don't make it static.
6164 (syms_of_data): Use DEFSYM.
6166 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6168 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6169 (CCL_CODE_MIN): New macro.
6171 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6173 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6175 * eval.c (Qdebug): Now static.
6176 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6177 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6178 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6180 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6182 * image.c: Various fixes to ImageMagick code comments.
6183 (Fimagemagick_types): Doc fix.
6185 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6187 Minor fixes prompted by GCC 4.6.0 warnings.
6189 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6191 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6192 (x_clipboard_manager_save_all): Move extern decl to ...
6193 * xterm.h: ... here, so that it can be checked for consistency.
6195 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6197 * xselect.c (x_clipboard_manager_save_frame)
6198 (x_clipboard_manager_save_all): New functions.
6199 (Fx_clipboard_manager_save): Lisp function deleted.
6201 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6202 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6204 * xterm.h: Update prototype.
6206 2011-05-28 William Xu <william.xwl@gmail.com>
6208 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6211 2011-05-28 Jim Meyering <meyering@redhat.com>
6213 Avoid a sign-extension bug in crypto_hash_function.
6214 * fns.c (to_uchar): Define.
6215 (crypto_hash_function): Use it to convert some newly-signed
6216 variables to unsigned, to avoid sign-extension bugs. For example,
6217 without this change, (md5 "truc") would evaluate to
6218 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6219 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6220 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6222 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6224 Integer overflow fixes.
6226 * dbusbind.c: Serial number integer overflow fixes.
6227 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6228 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6229 to hold a serial number that is too large for a fixnum.
6230 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6231 Check for serial numbers out of range. Decode any serial number
6232 that was so large that it became a float. (Bug#8722)
6234 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6235 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6236 Use XFASTINT rather than XUINT when numbers are nonnegative.
6237 (xd_append_arg, Fdbus_method_return_internal):
6238 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6239 arguments, check that Lisp number is nonnegative, rather than
6240 silently wrapping negative numbers around. (Bug#8722)
6241 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6244 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6246 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6248 ccl: Add integer overflow checks.
6249 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6250 (IN_INT_RANGE): New macros.
6251 (ccl_driver): Use them to check for integer overflow when
6252 decoding a CCL program. Many of the new checks are whether XINT (x)
6253 fits in int; it doesn't always, on 64-bit hosts. The new version
6254 doesn't catch all possible integer overflows, but it's an
6255 improvement. (Bug#8719)
6257 * alloc.c (make_event_array): Use XINT, not XUINT.
6258 There's no need for unsigned here.
6260 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6261 This follows up to the 2011-05-06 change that substituted uintptr_t
6262 for EMACS_INT. This case wasn't caught back then.
6264 Rework Fformat to avoid integer overflow issues.
6265 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6266 now (part of C89). Include <verify.h>.
6267 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6268 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6269 (Fformat): Avoid the prepass trying to compute sizes; it was only
6270 approximate and thus did not catch overflow reliably. Instead, walk
6271 through the format just once, formatting and computing sizes as we go,
6272 checking for integer overflow at every step, and allocating a larger
6273 buffer as needed. Keep track separately whether the format is
6274 multibyte. Keep only the most-recently calculated precision, rather
6275 than them all. Record whether each argument has been converted to
6276 string. Use EMACS_INT, not int, for byte and char and arg counts.
6277 Support field widths and precisions larger than INT_MAX. Avoid
6278 sprintf's undefined behavior with conversion specifications such as %#d
6279 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6280 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6281 formatting out-of-range floating point numbers with int
6284 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6286 * data.c: Avoid integer truncation in expressions involving floats.
6287 * data.c: Include <intprops.h>.
6288 (arith_driver): When there's an integer overflow in an expression
6289 involving floating point, convert the integers to floating point
6290 so that the resulting value does not suffer from catastrophic
6291 integer truncation. For example, on a 64-bit host (* 4
6292 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6293 Do not rely on undefined behavior after integer overflow.
6295 merge count_size_as_multibyte, parse_str_to_multibyte
6296 * character.c, character.h (count_size_as_multibyte):
6297 Rename from parse_str_to_multibyte; all uses changed.
6298 Check for integer overflow.
6299 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6300 since it's now a duplicate of the other. This is more of
6301 a character than a buffer op, so better that it's in character.c.
6302 * fns.c, print.c: Adjust to above changes.
6304 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6306 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6308 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6310 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6311 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6312 (x_clipboard_manager_save): Now static.
6313 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6315 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6316 (crypto_hash_function): Now static.
6317 Fix pointer signedness problems. Avoid unnecessary initializations.
6319 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6321 * termhooks.h (Vselection_alist): Make it terminal-local.
6323 * terminal.c (create_terminal): Initialize it.
6325 * xselect.c: Support for clipboard managers.
6326 (Vselection_alist): Move to termhooks.h as terminal-local var.
6327 (LOCAL_SELECTION): New macro.
6328 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6329 (symbol_to_x_atom): Remove gratuitous arg.
6330 (x_handle_selection_request, lisp_data_to_selection_data)
6331 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6332 (x_own_selection, x_get_local_selection, x_convert_selection):
6333 New arg, specifying work frame. Use terminal-local Vselection_alist.
6334 (some_frame_on_display): Delete unused function.
6335 (Fx_own_selection_internal, Fx_get_selection_internal)
6336 (Fx_disown_selection_internal, Fx_selection_owner_p)
6337 (Fx_selection_exists_p): New optional frame arg.
6338 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6339 (x_handle_selection_clear): Don't treat other terminals with the
6340 same keyboard specially. Use the terminal-local Vselection_alist.
6341 (x_clear_frame_selections): Use Frun_hook_with_args.
6343 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6345 * xterm.h: Add support for those atoms.
6347 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6349 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6350 (converted_selections, conversion_fail_tag): New global variables.
6351 (x_selection_request_lisp_error): Free the above.
6352 (x_get_local_selection): Remove unnecessary code.
6353 (x_reply_selection_request): Args changed; handle arbitrary array
6354 of converted selections stored in converted_selections.
6355 Separate the XChangeProperty and SelectionNotify steps.
6356 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6357 (x_convert_selection): New function.
6358 (x_handle_selection_event): Simplify.
6359 (x_get_foreign_selection): Don't ignore incoming requests while
6360 waiting for an answer; this will fail when we implement
6361 SAVE_TARGETS, and seems unnecessary anyway.
6362 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6363 (Vx_sent_selection_functions): Doc fix.
6365 2011-05-26 Leo Liu <sdl.web@gmail.com>
6367 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6369 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6371 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6373 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6374 for fringe update if it has periodic bitmap.
6375 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6376 and fringe_bitmap_periodic_p.
6378 * fringe.c (get_fringe_bitmap_data): New function.
6379 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6380 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6381 row. Mark glyph row for fringe update if periodicity changed.
6383 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6384 for fringe update unless it has periodic bitmap.
6386 2011-05-25 Kenichi Handa <handa@m17n.org>
6388 * xdisp.c (get_next_display_element): Set correct it->face_id for
6389 a static composition.
6391 2011-05-24 Leo Liu <sdl.web@gmail.com>
6394 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6396 * fns.c (crypto_hash_function, Fsha1): New function.
6397 (Fmd5): Use crypto_hash_function.
6398 (syms_of_fns): Add Ssha1.
6400 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6402 * gnutls.c: Remove unused macros.
6403 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6404 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6405 Remove macros that are defined and never used.
6406 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6408 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6410 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6411 (Fx_get_selection_internal): Minor cleanup.
6412 (Fx_own_selection_internal): Rename arguments for consistency with
6415 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6417 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6419 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6421 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6423 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6425 * dispnew.c (scrolling_window): Don't exclude the case that the
6426 last enabled row in the desired matrix touches the bottom boundary.
6428 2011-05-21 Glenn Morris <rgm@gnu.org>
6430 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6431 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6432 and add some more files.
6434 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6436 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6437 report_file_error introduced by the change from 2011-05-07.
6439 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6441 * systime.h (Time): Define only if emacs is defined.
6442 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6443 where the include path doesn't have X11/X.h by default. See
6444 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6446 2011-05-20 Kenichi Handa <handa@m17n.org>
6448 * composite.c (find_automatic_composition): Fix previous change.
6450 2011-05-20 Glenn Morris <rgm@gnu.org>
6452 * lisp.mk: New file, split from Makefile.in.
6453 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6454 (shortlisp): Remove.
6455 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6457 2011-05-19 Glenn Morris <rgm@gnu.org>
6459 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6460 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6461 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6462 (lisp): Set the order to that of loadup.el.
6463 (shortlisp): Make it a copy of $lisp.
6464 (SOME_MACHINE_LISP): Remove.
6465 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6466 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6468 2011-05-18 Kenichi Handa <handa@m17n.org>
6470 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6471 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6472 (find_automatic_composition): Mostly rewrite for efficiency.
6474 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6476 * makefile.w32-in: Update dependencies.
6478 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6480 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6481 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6483 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6485 Fix some integer overflow issues, such as string length overflow.
6487 * insdel.c (count_size_as_multibyte): Check for string overflow.
6489 * character.c (lisp_string_width): Check for string overflow.
6490 Use EMACS_INT, not int, for string indexes and lengths; in
6491 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6492 the resulting string length overflows an EMACS_INT; instead,
6493 report a string overflow if no precision given. When checking for
6494 precision exhaustion, use a check that cannot possibly have
6495 integer overflow. (Bug#8675)
6496 * character.h (lisp_string_width): Adjust to new signature.
6498 * alloc.c (string_overflow): New function.
6499 (Fmake_string): Use it. This doesn't change behavior, but saves
6500 a few bytes and will simplify future changes.
6501 * character.c (string_escape_byte8): Likewise.
6502 * lisp.h (string_overflow): New decl.
6504 Fixups, following up to the user-interface timestamp change.
6505 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6506 for UI timestamps, instead of unsigned long.
6507 * msdos.c (mouse_get_pos): Likewise.
6508 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6509 * w32gui.h (Time): Define by including "systime.h" rather than by
6510 declaring it ourselves. (Bug#8664)
6512 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6513 * image.c (clear_image_cache): Likewise.
6515 * term.c (term_mouse_position): Don't assume time_t wraparound.
6517 Be more systematic about user-interface timestamps.
6518 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6519 and sometimes 'EMACS_UINT', to represent these timestamps.
6520 This change causes it to use 'Time' uniformly, as that's what X uses.
6521 This makes the code easier to follow, and makes it easier to catch
6522 integer overflow bugs such as Bug#8664.
6523 * frame.c (Fmouse_position, Fmouse_pixel_position):
6524 Use Time, not unsigned long, for user-interface timestamps.
6525 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6526 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6527 * keyboard.h (last_event_timestamp): Likewise.
6528 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6529 * menu.h (xmenu_show): Likewise.
6530 * term.c (term_mouse_position): Likewise.
6531 * termhooks.h (struct input_event.timestamp): Likewise.
6532 (struct terminal.mouse_position_hook): Likewise.
6533 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6534 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6535 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6536 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6538 * menu.h, termhooks.h: Include "systime.h", for Time.
6540 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6541 Don't assume that the difference between two unsigned long values
6542 can fit into an integer. At this point, we know button_down_time
6543 <= event->timestamp, so the difference must be nonnegative, so
6544 there's no need to cast the result if double-click-time is
6545 nonnegative, as it should be; check that it's nonnegative, just in
6546 case. This bug is triggered when events are more than 2**31 ms
6547 apart (about 25 days). (Bug#8664)
6549 * xselect.c (last_event_timestamp): Remove duplicate decl.
6550 (x_own_selection): Remove needless cast to unsigned long.
6552 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6553 that always fit in int. Use a sentinel instead of a counter, to
6554 avoid a temp and to allay GCC's concerns about possible int overflow.
6555 * frame.h (struct frame): Use int for menu_bar_items_used
6556 instead of EMACS_INT, since it always fits in int.
6558 * menu.c (grow_menu_items): Check for int overflow.
6560 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6562 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6563 Before, the code was not consistent. These values cannot exceed
6564 2**31 - 1 so there's no need to make them unsigned.
6565 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6566 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6567 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6569 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6571 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6572 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6573 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6574 presumably because the widths might not match.
6576 * window.c (size_window): Avoid needless test at loop start.
6578 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6580 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6582 2011-05-12 Drew Adams <drew.adams@oracle.com>
6584 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6586 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6588 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6589 `width' to `bar_area_x' and `bar_area_width', respectively.
6590 (x_scroll_run): Take account of fringe background extension.
6592 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6593 Rename local vars `left' and `width' to `bar_area_x' and
6594 `bar_area_width', respectively.
6595 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6596 background extension.
6598 2011-05-10 Jim Meyering <meyering@redhat.com>
6600 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6602 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6604 * image.c (Finit_image_library): Return t for built-in image types,
6605 like pbm and xbm. (Bug#8640)
6607 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6609 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6611 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6613 * w32console.c (Fset_screen_color): Doc fix.
6614 (Fget_screen_color): New function.
6615 (syms_of_ntterm): Defsubr it.
6617 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6618 unlink the temporary file if Fcall_process didn't create it in the
6620 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6621 child process will be redirected to a file specified with `:file'.
6622 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6623 cue to call_process_cleanup not to close that handle.
6625 2011-05-07 Ben Key <bkey76@gmail.com>
6627 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6628 one of two shell specific rules, either bootstrap-temacs-CMD or
6629 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6630 to the previous implementation of the bootstrap-temacs rule.
6631 The bootstrap-temacs-CMD rule is similar to the previous
6632 implementation of the bootstrap-temacs rule except that it
6633 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6636 These changes, along with some changes to nt/configure.bat,
6637 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6638 earlier fix to add support for --cflags and --ldflags options
6639 that include quotes so that it works whether make uses cmd or
6642 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6644 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6645 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6647 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6648 a string. Handle both cases.
6649 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6650 (Fdbus_register_method): Use Qinvalid_function.
6652 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6654 * makefile.w32-in: Update dependencies.
6655 (LISP_H): Add inttypes.h and stdin.h.
6656 (PROCESS_H): Add unistd.h.
6658 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6660 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6661 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6663 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6665 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6667 * term.c (vfatal): Remove stray call to va_end.
6668 It's not needed and the C Standard doesn't allow it here anyway.
6670 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6671 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6673 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6676 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6678 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6680 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6682 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6684 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6686 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6687 * charset.c (Fdefine_charset_internal): Don't initialize
6688 charset.code_space[15]. The value was garbage, on hosts with
6689 32-bit int (Bug#8600).
6691 * lread.c (read_integer): Be more consistent with string-to-number.
6692 Use string_to_number to do the actual conversion; this avoids
6693 rounding errors and fixes some other screwups. Without this fix,
6694 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6695 (digit_to_number): Move earlier, for benefit of read_integer.
6696 Return -1 if the digit is out of range for the base, -2 if it is
6697 not a digit in any supported base. (Bug#8602)
6699 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6701 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6702 to match comment at start of function. This also removes a
6703 GCC warning about overflow in a 32+64-bit port.
6705 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6707 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6708 Reported by Stefan Monnier in
6709 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6710 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6711 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6713 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6714 (EMACS_UINTPTR): Likewise, with uintptr_t.
6716 * lisp.h: Prefer 64-bit EMACS_INT if available.
6717 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6718 on 32-bit hosts that have 64-bit int, so that they can access
6720 However, temporarily disable this change unless the temporary
6721 symbol WIDE_EMACS_INT is defined.
6723 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6725 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6726 This removes an assumption that EMACS_INT and long are the same
6727 width as pointers. The assumption is true for Emacs porting targets
6728 now, but we want to make other targets possible.
6729 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6730 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6731 In the rest of the code, change types of integers that hold casted
6732 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6733 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6734 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6735 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6736 No need to cast type when ORing.
6737 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6738 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6739 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6740 assume EMACS_INT is the same width as char *.
6741 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6742 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6743 Remove no-longer-needed casts.
6744 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6745 (xg_tool_bar_help_callback, xg_make_tool_item):
6746 Use EMACS_INTPTR to hold an integer
6747 that will be cast to void *; this can avoid a GCC warning
6748 if EMACS_INT is not the same width as void *.
6749 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6750 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6751 (current_message_1, set_message_1):
6752 Use a local to convert to proper width without a cast.
6753 * xmenu.c (dialog_selection_callback): Likewise.
6755 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6756 Also, don't assume VALBITS / RAND_BITS is less than 5,
6757 and don't rely on undefined behavior when shifting a 1 left into
6759 * lisp.h (get_random): Change signature to match.
6761 * lread.c (hash_string): Use size_t, not int, for hash computation.
6762 Normally we prefer signed values; but hashing is special, because
6763 it's better to use unsigned division on hash table sizes so that
6764 the remainder is nonnegative. Also, size_t is the natural width
6765 for hashing into memory. The previous code used 'int', which doesn't
6766 retain enough info to hash well into very large tables.
6767 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6769 * dbusbind.c: Don't possibly lose pointer info when converting.
6770 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6771 Use XPNTR rather than XHASH, so that the high-order bits of
6772 the pointer aren't lost when converting through void *.
6774 * eval.c (Fautoload): Don't double-shift a pointer.
6776 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6778 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6780 * gnutls.c (DEF_GNUTLS_FN):
6781 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6783 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6785 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6788 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6790 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6791 New version that can reserve upto 2GB of heap space.
6793 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6795 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6797 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6799 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6800 `gnutls_certificate_set_x509_key_file'.
6802 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6804 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6805 Update dependencies.
6807 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6809 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6810 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6811 Remove unused parameter `fildes'.
6812 * process.c (read_process_output, send_process): Don't pass it.
6814 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6816 Fix previous change: the library cache is defined in w32.c.
6817 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6818 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6820 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6822 Implement dynamic loading of GnuTLS on Windows.
6824 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6825 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6826 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6829 * gnutls.c (Qgnutls_dll): Define.
6830 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6831 (gnutls_*): Declare function pointers.
6832 (init_gnutls_functions): New function to initialize function pointers.
6833 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6834 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6835 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6836 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6837 (emacs_gnutls_write, emacs_gnutls_read)
6838 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6839 (Fgnutls_available_p): New function.
6840 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6841 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6842 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6844 * image.c: Include w32.h.
6845 (Vimage_type_cache): Delete.
6846 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6847 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6848 (w32_delayed_load): Move to w32.c.
6850 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6852 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6853 (w32_delayed_load): Move from image.c. When loading a library, record
6854 its filename in the :loaded-from property of the library id.
6855 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6856 Initialize and staticpro them.
6857 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6859 * process.c: Include lisp.h before w32.h, not after.
6860 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6861 instead of gnutls_record_check_pending.
6863 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6865 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6867 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6868 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6871 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6873 * xterm.c (x_set_frame_alpha): Do not set property on anything
6874 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6876 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6878 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6880 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6882 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6883 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6884 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6885 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6886 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6887 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6888 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6889 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6890 (Qgnutls_bootprop_callbacks_verify): Make static.
6892 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6894 * callproc.c: Indentation fixup.
6896 * sysdep.c (wait_for_termination_1): Make static.
6897 (wait_for_termination, interruptible_wait_for_termination):
6898 Move after wait_for_termination_1.
6900 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6902 * sysdep.c (interruptible_wait_for_termination): New function
6903 which is like wait_for_termination, but allows keyboard
6906 * callproc.c (Fcall_process): Add (:file "file") as an option for
6908 (Fcall_process_region): Ditto.
6910 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6912 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6913 rather than `XVECTOR (FOO)->size'.
6915 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6916 inttypes.h, as a gnulib replacement is used if it not available in
6919 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6921 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6922 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6923 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6925 * coding.c (coding_alloc_by_realloc): Error out if destination
6926 will grow beyond MOST_POSITIVE_FIXNUM.
6927 (decode_coding_emacs_mule): Abort if there isn't enough place in
6928 charbuf for the composition carryover bytes. Reserve an extra
6929 space for up to 2 characters produced in a loop.
6930 (decode_coding_iso_2022): Abort if there isn't enough place in
6931 charbuf for the composition carryover bytes.
6933 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6935 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6936 aborting when %lld or %lll format is passed.
6937 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6938 %llo or %llx format is passed. (Bug#8545)
6940 * window.c (window_scroll_line_based): Use a marker instead of
6941 simple variables to record original value of point. (Bug#7952)
6943 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6944 produced by %s or %c overflows available buffer space. (Bug#8545)
6946 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6948 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6949 (SIZE_MAX): Move defn after all includes, as they might #define it.
6951 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6953 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6955 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6957 * keyboard.c (Qdelayed_warnings_hook): Define.
6958 (command_loop_1): Run `delayed-warnings-hook'
6959 if Vdelayed_warnings_list is non-nil.
6960 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6961 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6963 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6965 * doprnt.c (doprnt): Don't return value smaller than the buffer
6966 size if the message was truncated. (Bug#8545).
6968 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6970 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6971 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6973 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6975 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6977 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6979 * makefile.w32-in: Update dependencies.
6981 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6983 Improve `doprnt' and its usage. (Bug#8545)
6984 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6985 `format_end'. Remove support for %l as a conversion specifier.
6986 Don't use xrealloc. Improve diagnostics when the %l size modifier
6987 is used. Update the commentary.
6989 * eval.c (verror): Simplify calculation of size_t.
6991 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6994 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6996 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6999 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7001 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7002 This makes this file independent of the recent pseudovector change.
7004 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7006 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7008 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7009 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7010 Remove unused local.
7011 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7013 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7014 GCC 4.6.0 optimizes based on type-based alias analysis.
7015 For example, if b is of type struct buffer * and v of type struct
7016 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7017 != &v->size, and therefore "v->size = 1; b->size = 2; return
7018 v->size;" must therefore return 1. This assumption is incorrect
7019 for Emacs, since it type-puns struct Lisp_Vector * with many other
7020 types. To fix this problem, this patch adds a new type struct
7021 vectorlike_header that documents the constraints on layout of vectors
7022 and pseudovectors, and helps optimizing compilers not get fooled
7023 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7024 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7025 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7027 (XSETPVECTYPE): Rewrite in terms of new macro.
7028 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7029 This is a bit clearer, and further avoids the possibility of
7030 undesirable aliasing.
7031 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7032 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7033 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7034 since Lisp_Subr is a special case (no "next" field).
7035 (ASIZE): Now uses header.size rather than size.
7036 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7037 to avoid the hassle of writing XVECTOR (foo)->header.size.
7038 (struct vectorlike_header): New type.
7039 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7040 object, to help avoid aliasing.
7041 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7042 (SUBRP): Likewise, since Lisp_Subr is a special case.
7043 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7044 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7045 (struct Lisp_Hash_Table): Combine first two members into a single
7046 struct vectorlike_header member. All uses of "size" and "next" members
7047 changed to be "header.size" and "header.next".
7048 * buffer.h (struct buffer): Likewise.
7049 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7050 * frame.h (struct frame): Likewise.
7051 * process.h (struct Lisp_Process): Likewise.
7052 * termhooks.h (struct terminal): Likewise.
7053 * window.c (struct save_window_data, struct saved_window): Likewise.
7054 * window.h (struct window): Likewise.
7055 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7056 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7057 * buffer.c (init_buffer_once): Likewise.
7058 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7060 * process.c (Fformat_network_address): Use local var for size,
7063 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7065 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7066 * data.c (atof): Remove decl; no longer used or needed.
7067 (digit_to_number): Move to lread.c.
7068 (Fstring_to_number): Use new string_to_number function, to be
7069 consistent with how the Lisp reader treats infinities and NaNs.
7070 Do not assume that floating-point numbers represent EMACS_INT
7071 without losing information; this is not true on most 64-bit hosts.
7072 Avoid double-rounding errors, by insisting on integers when
7073 parsing non-base-10 numbers, as the documentation specifies.
7074 * lisp.h (string_to_number): New decl, replacing ...
7075 (isfloat_string): Remove.
7076 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7077 (read1): Do not accept +. and -. as integers; this
7078 appears to have been a coding error. Similarly, do not accept
7079 strings like +-1e0 as floating point numbers. Do not report
7080 overflow for integer overflows unless the base is not 10 which
7081 means we have no simple and reliable way to continue.
7082 Break out the floating-point parsing into a new
7083 function string_to_number, so that Fstring_to_number parses
7084 floating point numbers consistently with the Lisp reader.
7085 (digit_to_number): Move here from data.c. Make it static inline.
7086 (E_CHAR, EXP_INT): Remove, replacing with ...
7087 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7088 (string_to_number): New function, replacing isfloat_string.
7089 This function checks for valid syntax and produces the resulting
7090 Lisp float number too. Rework it so that string-to-number
7091 no longer mishandles examples like "1.0e+". Use strtoumax,
7092 so that overflow for non-base-10 numbers is reported only when
7093 there's no portable and simple way to convert to floating point.
7095 * textprop.c (set_text_properties_1): Rewrite for clarity,
7096 and to avoid GCC warning about integer overflow.
7098 * intervals.h (struct interval): Use EMACS_INT for members
7099 where EMACS_UINT might cause problems. See
7100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7101 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7102 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7104 (offset_intervals): Tell GCC not to worry about length overflow
7105 when negating a negative length.
7107 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7108 (overrun_check_free): Likewise.
7110 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7111 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7114 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7115 (gnutls_make_error): Rename local to avoid shadowing.
7116 (gnutls_emacs_global_deinit): ifdef out; not used.
7117 (Fgnutls_boot): Use const for pointer to readonly storage.
7118 Comment out unused local. Fix pointer signedness problems.
7120 * lread.c (openp): Don't stuff size_t into an 'int'.
7121 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7122 about possible signed overflow.
7124 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7125 (GDK_KEY_g): Don't define if already defined.
7126 (xg_prepare_tooltip): Avoid pointer signedness problem.
7127 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7129 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7130 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7132 * xfns.c (Fx_window_property): Simplify a bit,
7133 to make a bit faster and to avoid GCC 4.6.0 warning.
7134 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7136 * fns.c (internal_equal): Don't assume size_t fits in int.
7138 * alloc.c (compact_small_strings): Tighten assertion a little.
7140 Replace pEd with more-general pI, and fix some printf arg casts.
7141 * lisp.h (pI): New macro, generalizing old pEd macro to other
7142 conversion specifiers. For example, use "...%"pI"d..." rather
7143 than "...%"pEd"...".
7144 (pEd): Remove. All uses replaced with similar uses of pI.
7145 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7146 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7147 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7148 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7149 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7150 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7151 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7153 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7154 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7155 * print.c (safe_debug_print, print_object): Likewise.
7156 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7158 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7159 avoiding the 0 flag, which is not portable.
7160 * process.c (Fmake_network_process): Use pI to avoid cast.
7161 * region-cache.c (pp_cache): Likewise.
7162 * xdisp.c (decode_mode_spec): Likewise.
7163 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7164 behavior on 64-bit hosts with printf arg.
7165 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7166 (x_stop_queuing_selection_requests): Likewise.
7167 (x_get_window_property): Don't truncate byte count to an 'int'
7170 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7171 here, since it parses constructs like leading '-' and spaces,
7172 which are not wanted; and it overflows with large numbers.
7173 Instead, simply match F[0-9]+, which is what is wanted anyway.
7175 * alloc.c: Remove unportable assumptions about struct layout.
7176 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7177 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7178 (allocate_vectorlike, make_pure_vector): Use the new macros,
7179 plus offsetof, to remove unportable assumptions about struct layout.
7180 These assumptions hold on all porting targets that I know of, but
7181 they are not guaranteed, they're easy to remove, and removing them
7182 makes further changes easier.
7184 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7185 This doesn't fix a bug but makes the code clearer.
7186 (string_overrun_cookie): Now const. Use initializers that
7187 don't formally overflow signed char, to avoid warnings.
7188 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7189 can cause Emacs to crash when string overrun checking is enabled.
7190 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7191 multiple of sizeof (EMACS_INT); it need not be, if
7192 alignof(EMACS_INT) < sizeof (EMACS_INT).
7193 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7195 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7197 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7199 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7201 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7202 supposed to be handshaking. (Bug#8556)
7203 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7205 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7207 * lisp.h (Qdebug): List symbol.
7208 * eval.c (Qdebug): Restore global linkage.
7209 * keyboard.c (debug-on-event): New variable.
7210 (handle_user_signal): Break into debugger when debug-on-event
7211 matches the current signal symbol.
7213 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7215 * alloc.c (check_sblock, check_string_bytes)
7216 (check_string_free_list): Convert to standard C.
7218 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7220 * w32.c (emacs_gnutls_push): Fix typo.
7222 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7224 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7225 "cast to pointer from integer of different size".
7227 Improve doprnt and its use in verror. (Bug#8545)
7228 * doprnt.c (doprnt): Document the set of format control sequences
7229 supported by the function. Use SAFE_ALLOCA instead of always
7232 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7233 is one byte too soon. Don't use xrealloc; instead xfree and
7236 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7238 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7241 * gnutls.c: Renamed global_initialized to
7242 gnutls_global_initialized. Added internals for the
7243 :verify-hostname-error, :verify-error, and :verify-flags
7244 parameters of `gnutls-boot' and documented those parameters in the
7245 docstring. Start callback support.
7246 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7247 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7248 on error. Return error code.
7249 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7250 (emacs_gnutls_read): Likewise.
7251 (Fgnutls_boot): Return handshake error code.
7252 (emacs_gnutls_handle_error): New function.
7253 (wsaerror_to_errno): Likewise.
7255 * w32.h (emacs_gnutls_pull): Add prototype.
7256 (emacs_gnutls_push): Likewise.
7258 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7259 (emacs_gnutls_push): Likewise.
7261 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7263 * process.c (wait_reading_process_output): Check if GnuTLS
7264 buffered some data internally if no FDs are set for TLS
7267 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7268 (LIBS): Link to USER_LIBS.
7269 ($(BLD)/gnutls.$(0)): New target.
7271 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7273 * xdisp.c (handle_single_display_spec): Rename the
7274 display_replaced_before_p argument into display_replaced_p, to
7275 make it consistent with the commentary. Fix typos in the
7278 * textprop.c (syms_of_textprop): Remove dead code.
7279 (copy_text_properties): Delete obsolete commentary about an
7280 interface that was deleted long ago. Fix typos in the description
7283 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7284 to changes in oldXMenu/XMenu.h from 2011-04-16.
7285 <menu_help_message, prev_menu_help_message>: Constify.
7286 (IT_menu_make_room): menu->help_text is now `const char **';
7289 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7290 to changes in oldXMenu/XMenu.h from 2011-04-16.
7291 (struct XMenu): Declare `help_text' `const char **'.
7293 * xfaces.c <Qunspecified>: Make extern again.
7295 * syntax.c: Include sys/types.h before including regex.h, as
7298 * doc.c (get_doc_string): Improve the format passed to `error'.
7300 * doprnt.c (doprnt): Improve commentary.
7302 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7304 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7307 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7308 changes in globals.h immediately force recompilation.
7309 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7310 $(CURDIR)/s/ms-w32.h.
7311 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7313 * character.c (Fchar_direction): Function deleted.
7314 (syms_of_character): Don't defsubr it.
7315 <char-direction-table>: Deleted.
7317 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7319 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7320 * doprnt.c: Include limits.h.
7321 (SIZE_MAX): New macro.
7322 (doprnt): Return a size_t value. 2nd arg is now size_t.
7323 Many local variables are now size_t instead of int or unsigned.
7324 Improve overflow protection. Support `l' modifier for integer
7325 conversions. Support %l conversion. Don't assume an EMACS_INT
7326 argument for integer conversions and for %c.
7328 * lisp.h (doprnt): Restore prototype.
7330 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7333 * Makefile.in (base_obj): Add back doprnt.o.
7335 * deps.mk (doprnt.o): Add back prerequisites.
7336 (callint.o): Depend on character.h.
7338 * eval.c (internal_lisp_condition_case): Include the handler
7339 representation in the error message.
7340 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7341 when breaking from the loop.
7343 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7345 * callint.c (Fcall_interactively): When displaying error message
7346 about invalid control letter, pass the character's codepoint, not
7347 a pointer to its multibyte form. Improve display of the character
7348 in octal and display also its hex code.
7350 * character.c (char_string): Use %x to display the (unsigned)
7351 codepoint of an invalid character, to avoid displaying a bogus
7354 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7355 `error', not SYMBOL_NAME itself.
7357 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7358 character arguments to `error'.
7360 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7361 to `error' in error message about FINAL_CHAR argument. Make sure
7362 FINAL_CHAR is a character, and use %c when it is passed as
7363 argument to `error'.
7365 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7367 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7369 * w32.c: Include <time.h>.
7370 (sys_localtime): New function.
7372 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7374 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7376 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7378 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7380 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7383 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7385 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7386 gl_state.e_property when gl_state.object is Qt.
7388 * insdel.c (make_gap_larger): Remove limitation of buffer size
7391 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7393 * xdisp.c (lookup_glyphless_char_display)
7394 (produce_glyphless_glyph): Handle cons cell entry in
7395 glyphless-char-display.
7396 (Vglyphless_char_display): Document it.
7398 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7399 glyphless-char-display.
7401 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7403 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7405 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7407 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7408 definition for no-X builds.
7410 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7412 Static checks with GCC 4.6.0 and non-default toolkits.
7414 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7416 * process.c (keyboard_bit_set): Define only if SIGIO.
7417 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7418 (send_process): Repair possible setjmp clobbering.
7420 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7422 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7424 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7426 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7427 Define only if needed.
7429 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7430 by pacifying GCC about it. Maybe it's time to retire it?
7431 * xfaces.c (USG, __TIMEVAL__): Likewise.
7433 * dispextern.h (struct redisplay_interface): Rename param
7435 * termhooks.h (struct terminal): Likewise.
7436 * xterm.c (xembed_send_message): Likewise.
7438 * insdel.c (make_gap_smaller): Define only if
7439 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7441 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7444 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7445 so that we aren't warned about unused symbols.
7447 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7449 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7451 * xfns.c (x_real_positions): Mark locals as initialized.
7453 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7455 * xterm.c: Fix problems found by static analysis with other toolkits.
7456 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7457 (x_dispatch_event): Declare static if USE_GTK, and
7458 define if USE_GTK || USE_X_TOOLKIT.
7459 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7460 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7461 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7462 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7464 * xmenu.c (menu_help_callback): Pointer type fixes.
7465 Use const pointers when pointing at readonly data. Avoid pointer
7467 (FALSE): Remove unused macro.
7468 (update_frame_menubar): Remove unused decl.
7470 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7472 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7473 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7474 (single_menu_item): Rename local to avoid shadowing.
7476 * keyboard.c (make_lispy_event): Remove unused local var.
7478 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7479 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7481 * bitmaps: Change bitmaps from unsigned char back to the X11
7482 compatible char. Avoid the old compiler warnings about
7483 out-of-range initializers by using, for example, '\xab' rather
7486 * xgselect.c (xgselect_initialize): Check vs interface
7487 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7489 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7491 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7492 to read-only memory.
7494 * fns.c (vector): Remove; this old hack is no longer needed.
7496 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7498 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7500 * xrdb.c (x_load_resources): Omit unused local.
7502 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7503 (x_window): Rename locals to avoid shadowing.
7504 (USG): Use the kludged USG macro, to pacify gcc.
7506 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7507 (x_term_init): Remove local to avoid shadowing.
7509 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7511 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7512 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7514 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7516 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7518 Fix regex.c, syntax.c and friends for buffers > 2GB.
7519 * syntax.h (struct gl_state_s): Declare character position members
7522 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7524 * textprop.c (verify_interval_modification, interval_of):
7525 Declare arguments EMACS_INT.
7527 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7530 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7532 * indent.c (Fvertical_motion): Local variable it_start is now
7535 * regex.c (re_match, re_match_2, re_match_2_internal)
7536 (bcmp_translate, regcomp, regexec, print_double_string)
7537 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7538 (re_compile_pattern, re_exec): Declare arguments and local
7539 variables `size_t' and `ssize_t' and return values `regoff_t', as
7541 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7542 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7543 <compile_stack_type>: `size' and `avail' are now `size_t'.
7545 * regex.h <regoff_t>: Use ssize_t, not int.
7546 (re_search, re_search_2, re_match, re_match_2): Arguments that
7547 specify buffer/string position and length are now ssize_t and
7548 size_t. Return type is regoff_t.
7550 2011-04-16 Ben Key <bkey76@gmail.com>
7552 * nsfont.m: Fixed bugs in ns_get_family and
7553 ns_descriptor_to_entity that were caused by using free to
7554 deallocate memory blocks that were allocated by xmalloc (via
7555 xstrdup). This caused Emacs to crash when compiled with
7556 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7557 --enable-checking=xmallocoverrun). xfree is now used to
7558 deallocate these memory blocks.
7560 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7562 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7564 emacs_write: Accept and return EMACS_INT for sizes.
7565 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7567 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7568 Accept and return EMACS_INT.
7569 (emacs_gnutls_write): Return the number of bytes written on
7571 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7572 (emacs_read, emacs_write): Remove check for negative size, as the
7573 Emacs source code has been audited now.
7574 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7575 (emacs_read, emacs_write): Use it.
7576 * process.c (send_process): Adjust to the new signatures of
7577 emacs_write and emacs_gnutls_write. Do not attempt to store
7578 a byte offset into an 'int'; it might overflow.
7579 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7581 * sound.c: Don't assume sizes fit in 'int'.
7582 (struct sound_device.period_size, alsa_period_size):
7583 Return EMACS_INT, not int.
7584 (struct sound_device.write, vox_write, alsa_write):
7585 Accept EMACS_INT, not int.
7586 (wav_play, au_play): Use EMACS_INT to store sizes and to
7587 record read return values.
7589 2011-04-15 Ben Key <bkey76@gmail.com>
7591 * keyboard.c (Qundefined): Don't declare static since it is used
7593 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7594 static since they are used in nsfont.m.
7596 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7598 * process.c (Qprocessp): Don't declare static.
7599 * lisp.h (Qprocessp): Declare again.
7601 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7603 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7605 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7607 Improve C-level modularity by making more things 'static'.
7609 Don't publish debugger-only interfaces to other modules.
7610 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7611 (verify_bytepos, count_markers): Move decls to the only modules
7613 * region-cache.h (pp_cache): Likewise.
7614 * window.h (check_all_windows): Likewise.
7615 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7617 * sysdep.c (croak): Now static, if
7618 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7619 * syssignal.h (croak): Declare only if not static.
7621 * alloc.c (refill_memory_reserve): Now static if
7622 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7623 * lisp.h (refill_memory_reserve): Declare only if not static.
7625 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7626 Define only if USE_LUCID.
7628 * xrdb.c (x_customization_string, x_rm_string): Now static.
7630 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7631 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7633 * xdisp.c (draw_row_with_mouse_face): Now static.
7634 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7636 * window.h (check_all_windows): Mark externally visible.
7638 * window.c (window_deletion_count): Now static.
7640 * undo.c: Make symbols static if they're not exported.
7641 (last_undo_buffer, last_boundary_position, pending_boundary):
7644 * textprop.c (interval_insert_behind_hooks): Now static.
7645 (interval_insert_in_front_hooks): Likewise.
7647 * term.c: Make symbols static if they're not exported.
7648 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7649 (max_frame_lines, tty_set_terminal_modes):
7650 (tty_reset_terminal_modes, tty_turn_off_highlight):
7651 (get_tty_terminal): Now static.
7652 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7653 * termhooks.h (term_mouse_moveto): Do not declare if
7655 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7656 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7658 * sysdep.c: Make symbols static if they're not exported.
7659 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7661 (sigprocmask_set, full_mask): Remove; unused.
7662 (wait_debugging): Mark as visible.
7663 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7664 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7666 * syntax.c (syntax_temp): Define only if !__GNUC__.
7668 * sound.c (current_sound_device, current_sound): Now static.
7670 * search.c (searchbufs, searchbuf_head): Now static.
7672 * scroll.c (scroll_cost): Remove; unused.
7673 * dispextern.h (scroll_cost): Remove decl.
7675 * region-cache.h (pp_cache): Mark as externally visible.
7677 * process.c: Make symbols static if they're not exported.
7678 (process_tick, update_tick, create_process, chan_process):
7679 (Vprocess_alist, proc_buffered_char, datagram_access):
7680 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7681 (deactivate_process): Mark defn as static, as well as decl.
7682 * lisp.h (create_process): Remove decl.
7683 * process.h (chan_process, Vprocess_alist): Remove decls.
7685 * print.c: Make symbols static if they're not exported.
7686 (print_depth, new_backquote_output, being_printed, print_buffer):
7687 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7688 (print_interval, print_number_index, initial_stderr_stream):
7690 * lisp.h (Fprinc): Remove decl.
7691 (debug_output_compilation_hack): Mark as externally visible.
7693 * sysdep.c (croak): Move decl from here to syssignal.h.
7694 * syssignal.h (croak): Put it here, so the API can be checked when
7695 'croak' is called from dissociate_if_controlling_tty.
7697 * minibuf.c: Make symbols static if they're not exported.
7698 (minibuf_save_list, choose_minibuf_frame): Now static.
7699 * lisp.h (choose_minibuf_frame): Remove decl.
7701 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7703 * lread.c: Make symbols static if they're not exported.
7704 (read_objects, initial_obarray, oblookup_last_bucket_number):
7706 (make_symbol): Remove; unused.
7707 * lisp.h (initial_obarray, make_symbol): Remove decls.
7709 * keyboard.c: Make symbols static if they're not exported.
7710 (single_kboard, recent_keys_index, total_keys, recent_keys):
7711 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7712 (this_single_command_key_start, echoing, last_auto_save):
7713 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7714 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7715 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7716 (Vlispy_mouse_stem, double_click_count):
7718 (force_auto_save_soon): Define only if SIGDANGER.
7719 (ignore_mouse_drag_p): Now static if
7720 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7721 (print_help): Remove; unused.
7722 (stop_character, last_timer_event): Mark as externally visible.
7723 * keyboard.h (ignore_mouse_drag_p): Declare only if
7724 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7725 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7726 * lisp.h (echoing): Remove decl.
7727 (force_auto_save_soon): Declare only if SIGDANGER.
7728 * xdisp.c (redisplay_window): Simplify code, to make it more
7729 obvious that ignore_mouse_drag_p is not accessed if !defined
7730 USE_GTK && !defined HAVE_NS.
7732 * intervals.c: Make symbols static if they're not exported.
7733 (merge_properties_sticky, merge_interval_right, delete_interval):
7735 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7737 * insdel.c: Make symbols static if they're not exported.
7738 However, leave prepare_to_modify_buffer alone. It's never
7739 called from outside this function, but that appears to be a bug.
7740 (combine_after_change_list, combine_after_change_buffer):
7741 (adjust_after_replace, signal_before_change): Now static.
7742 (adjust_after_replace_noundo): Remove; unused.
7743 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7744 (signal_before_change): Remove decls.
7746 * indent.c (val_compute_motion, val_vmotion): Now static.
7748 * image.c: Make symbols static if they're not exported.
7749 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7751 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7752 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7754 * fringe.c (standard_bitmaps): Now static.
7755 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7757 * frame.c: Make symbols static if they're not exported.
7758 (x_report_frame_params, make_terminal_frame): Now static.
7759 (get_frame_param): Now static, unless HAVE_NS.
7760 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7761 (x_get_resource_string): Remove; not used.
7762 * frame.h (make_terminal_frame, x_report_frame_params):
7763 (x_get_resource_string); Remove decls.
7764 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7765 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7767 * font.c, fontset.c: Make symbols static if they're not exported.
7768 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7769 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7770 * font.c (font_close_object): Now static.
7771 * font.h (font_close_object): Remove.
7772 * fontset.c (FONTSET_OBJLIST): Remove.
7773 (free_realized_fontset) #if-0 the body, which does nothing.
7774 (face_suitable_for_char_p): #if-0, as it's never called.
7775 * fontset.h (face_suitable_for_char_p): Remove decl.
7776 * xfaces.c (face_at_string_position):
7777 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7778 since 0 is always ASCII.
7780 * fns.c (weak_hash_tables): Now static.
7782 * fileio.c: Make symbols static if they're not exported.
7783 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7784 (Vwrite_region_annotation_buffers): Now static.
7786 * eval.c: Make symbols static if they're not exported.
7787 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7788 * lisp.h (backtrace_list): Remove decl.
7790 * emacs.c: Make symbols static if they're not exported.
7791 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7792 (fatal_error_code, fatal_error_signal_hook, standard_args):
7794 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7795 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7796 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7797 * lisp.h (fatal_error_signal_hook): Remove decl.
7798 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7800 * editfns.c: Move a (normally-unused) function to its only use.
7801 * editfns.c, lisp.h (get_operating_system_release): Remove.
7802 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7803 worth the hassle of breaking this out.
7805 * xterm.c: Make symbols static if they're not exported.
7806 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7807 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7808 (x_destroy_window, x_delete_display):
7810 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7811 (x_mouse_leave): Remove; unused.
7812 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7813 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7814 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7816 (x_mouse_leave): Declare only if WINDOWSNT.
7817 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7818 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7821 * ftxfont.c: Make symbols static if they're not exported.
7822 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7824 * font.h (ftxfont_driver): Likewise.
7826 * xfns.c: Make symbols static if they're not exported.
7827 (x_last_font_name, x_display_info_for_name):
7828 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7829 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7830 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7831 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7832 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7833 (last_show_tip_args): Now static.
7834 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7835 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7836 (x_screen_planes): Remove; unused.
7837 * dispextern.h (x_screen_planes): Remove decl.
7839 * dispnew.c: Make symbols static if they're not exported.
7840 * dispextern.h (redraw_garbaged_frames, scrolling):
7841 (increment_row_positions): Remove.
7842 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7843 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7845 (redraw_garbaged_frames): Remove; unused.
7847 * xfaces.c: Make symbols static if they're not exported.
7848 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7850 * xterm.h (defined_color): Remove decls.
7851 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7852 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7853 (menu_face_changed_default, defined_color, free_realized_face):
7854 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7855 (ascii_face_of_lisp_face): Remove; unused.
7857 * xdisp.c: Make symbols static if they're not exported.
7858 * dispextern.h (scratch_glyph_row, window_box_edges):
7859 (glyph_to_pixel_coords, set_cursor_from_row):
7860 (get_next_display_element, set_iterator_to_next):
7861 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7862 (show_mouse_face): Remove decls
7863 * frame.h (message_buf_print): Likewise.
7864 * lisp.h (pop_message, set_message, check_point_in_composition):
7866 * xterm.h (set_vertical_scroll_bar): Likewise.
7867 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7868 (message_buf_print, scratch_glyph_row, displayed_buffer):
7869 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7870 (get_next_display_element, show_mouse_face, window_box_edges):
7871 (frame_to_window_pixel_xy, check_point_in_composition):
7872 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7873 (glyph_to_pixel_coords): Remove; unused.
7875 * dired.c (file_name_completion): Now static.
7877 * dbusbind.c (xd_in_read_queued_messages): Now static.
7879 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7880 * data.c (circular_list_error): Remove.
7882 * commands.h (last_point_position, last_point_position_buffer):
7883 (last_point_position_window): Remove decls.
7884 * keyboard.c: Make these variables static.
7886 * coding.h (coding, code_convert_region, encode_coding_gap):
7888 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7889 (iso_code_class, detect_coding, code_convert_region): Now static.
7890 (encode_coding_gap): Remove; unused.
7892 * chartab.c (chartab_chars, chartab_bits): Now static.
7894 * charset.h (charset_iso_8859_1): Remove decl.
7895 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7898 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7899 * ccl.c (Vccl_program_table): Now static.
7900 (check_ccl_update): Remove; unused.
7902 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7903 * category.h: ... from here.
7904 * category.c (check_category_table, set_category_set): Now static.
7906 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7907 * lisp.h: Remove these decls.
7909 * buffer.c (buffer_count): Remove unused var.
7911 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7912 so that it's not optimized away.
7913 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7914 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7915 exported only to the debugger.
7917 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7918 * atimer.h (run_all_atimers): Remove; not exported.
7920 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7921 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7922 was inaccessible from Lisp.
7923 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7924 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7926 alloc.c: Import and export fewer symbols, and remove unused items.
7927 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7929 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7930 it's not optimized away by whole-program optimization.
7931 (message_enable_multibyte, free_misc): Remove.
7932 (catchlist, handlerlist, mark_backtrace):
7933 Declare only if BYTE_MARK_STACK.
7934 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7935 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7936 (message_enable_multibyte): Remove decl.
7937 (free_misc, interval_free_list, float_block, float_block_index):
7938 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7939 (cons_free_list, last_marked_index):
7941 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7942 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7943 (mark_backtrace): Define only if BYTE_MARK_STACK.
7944 * xdisp.c (message_enable_multibyte): Now static.
7946 Declare Lisp_Object Q* variables to be 'static' if not exported.
7947 This makes it easier for human readers (and static analyzers)
7948 to see whether these variables are used from other modules.
7949 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7950 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7951 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7952 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7953 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7954 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7955 * xmenu.c, xselect.c:
7956 Declare Q* vars static if they are not used in other modules.
7957 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7958 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7959 Remove decls of unexported vars.
7960 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7962 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7964 Make Emacs functions such as Fatom 'static' by default.
7965 This makes it easier for human readers (and static analyzers)
7966 to see whether these functions can be called from other modules.
7967 DEFUN now defines a static function. To make the function external
7968 so that it can be used in other C modules, use the new macro DEFUE.
7969 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7970 (Finit_image_library):
7971 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7972 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7973 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7974 Remove decls, since these functions are now static.
7975 (Funintern, Fget_internal_run_time): New decls, since these functions
7976 were already external.
7978 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7979 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7980 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7981 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7982 * keyboard.c, keymap.c, lread.c:
7983 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7984 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7985 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7986 Mark functions with DEFUE instead of DEFUN,
7987 if they are used in other modules.
7988 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7989 decls for now-static functions.
7990 * buffer.h (Fdelete_overlay): Remove decl.
7991 * callproc.c (Fgetenv_internal): Mark as internal.
7992 * composite.c (Fremove_list_of_text_properties): Remove decl.
7993 (Fcomposition_get_gstring): New forward static decl.
7994 * composite.h (Fcomposite_get_gstring): Remove decl.
7995 * dired.c (Ffile_attributes): New forward static decl.
7996 * doc.c (Fdocumntation_property): New forward static decl.
7997 * eval.c (Ffetch_bytecode): New forward static decl.
7998 (Funintern): Remove extern decl; now in .h file where it belongs.
7999 * fileio.c (Fmake_symbolic_link): New forward static decl.
8000 * image.c (Finit_image_library): New forward static decl.
8001 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8002 * intervals.h (Fprevious_property_change):
8003 (Fremove_list_of_text_properties): Remove decls.
8004 * keyboard.c (Fthis_command_keys): Remove decl.
8005 (Fcommand_execute): New forward static decl.
8006 * keymap.c (Flookup_key): New forward static decl.
8007 (Fcopy_keymap): Now static.
8008 * keymap.h (Flookup_key): Remove decl.
8009 * process.c (Fget_process): New forward static decl.
8010 (Fprocess_datagram_address): Mark as internal.
8011 * syntax.c (Fsyntax_table_p): New forward static decl.
8012 (skip_chars): Remove duplicate decl.
8013 * textprop.c (Fprevious_property_change): New forward static decl.
8014 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8016 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8017 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8019 * editfns.c (Fformat): Remove unreachable code.
8021 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8023 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8026 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8028 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8029 when at ZV. (Bug#8487)
8031 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8033 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8035 * keyboard.c (parse_tool_bar_item): Likewise.
8036 * sound.c (sound_cleanup, alsa_close): Likewise.
8037 * termcap.c (tgetent): Likewise.
8038 * xfns.c (x_default_font_parameter): Likewise.
8039 * xsettings.c (read_and_apply_settings): Likewise.
8041 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8042 (overrun_check_free): Protoize.
8044 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8046 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8047 since callers should never pass a negative size.
8048 Change the signature to match that of plain 'read' and 'write'; see
8049 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8050 * lisp.h: Update prototypes of emacs_write and emacs_read.
8052 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8054 * xdisp.c (redisplay_window): Don't try to determine the character
8055 position of the scroll margin if the window start point w->startp
8056 is outside the buffer's accessible region. (Bug#8468)
8058 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8060 Fix write-region and its subroutines for buffers > 2GB.
8061 * fileio.c (a_write, e_write): Modify declaration of arguments and
8062 local variables to support buffers larger than 2GB.
8063 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8065 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8066 argument, local variables, and return value.
8068 * lisp.h: Update prototypes of emacs_write and emacs_read.
8070 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8072 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8074 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8076 Fix more problems found by GCC 4.6.0's static checks.
8078 * xdisp.c (vmessage): Use a better test for character truncation.
8080 * charset.c (load_charset_map): <, not <=, for optimization,
8081 and to avoid potential problems with integer overflow.
8082 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8083 * casetab.c (set_identity, shuffle): Likewise.
8084 * editfns.c (Fformat): Likewise.
8085 * syntax.c (skip_chars): Likewise.
8087 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8088 This also lets GCC 4.6.0 generate slightly better loop code.
8090 * callint.c (Fcall_interactively): <, not <=, for optimization.
8091 (Fcall_interactively): Count the number of arguments produced,
8092 not the number of arguments given. This is simpler and lets GCC
8093 4.6.0 generate slightly better code.
8095 * ftfont.c: Distingish more carefully between FcChar8 and char.
8096 The previous code passed unsigned char * to a functions like
8097 strlen and xstrcasecmp that expect char *, which does not
8098 conform to the C standard.
8099 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8100 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8101 char * when the C standard requires it.
8103 * keyboard.c (read_char): Remove unused var.
8105 * eval.c: Port to Windows vsnprintf (Bug#8435).
8107 (SIZE_MAX): Define if the headers do not.
8108 (verror): Do not give up if vsnprintf returns a negative count.
8109 Instead, grow the buffer. This ports to Windows vsnprintf, which
8110 does not conform to C99. Problem reported by Eli Zaretskii.
8111 Also, simplify the allocation scheme, by avoiding the need for
8112 calling realloc, and removing the ALLOCATED variable.
8114 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8116 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8117 But keep the doprint source code for now, as we might revamp it
8118 and use it again (Bug#8435).
8119 * lisp.h (doprnt): Remove.
8120 * Makefile.in (base_obj): Remove doprnt.o.
8121 * deps.mk (doprnt.o): Remove.
8123 error: Print 32- and 64-bit integers portably (Bug#8435).
8124 Without this change, on typical 64-bit hosts error ("...%d...", N)
8125 was used to print both 32- and 64-bit integers N, which relied on
8127 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8128 * lisp.h (error, verror): Mark as printf-like functions.
8129 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8130 Report overflow in size calculations when allocating printf buffer.
8131 Do not truncate output string at its first null byte.
8132 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8133 Truncate the output at a character boundary, since vsnprintf does not
8135 * charset.c (check_iso_charset_parameter): Convert internal
8136 character to string before calling 'error', since %c now has the
8138 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8139 overflow when computing char to be passed to 'error'. Do not
8140 pass Lisp_Object to 'error'; pass the integer instead.
8141 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8142 formatted with plain %d.
8144 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8146 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8148 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8150 * xterm.c (x_catch_errors): Remove duplicate declaration.
8152 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8154 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8156 2011-04-10 Jim Meyering <meyering@redhat.com>
8158 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8159 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8160 return ssize_t not "int", and use size_t as the buffer length.
8161 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8162 * gnutls.h: Update declarations.
8163 * process.c (read_process_output): Use ssize_t, to match.
8164 (send_process): Likewise.
8166 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8168 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8170 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8172 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8173 Use unsigned char, to match FcChar8 type definition.
8175 * xterm.c (handle_one_xevent):
8176 * xmenu.c (create_and_show_popup_menu):
8177 * xselect.c (x_decline_selection_request)
8178 (x_reply_selection_request): Avoid type-punned deref of X events.
8180 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8182 Fix some uses of `int' instead of EMACS_INT.
8183 * search.c (string_match_1, fast_string_match)
8184 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8185 (scan_buffer, find_next_newline_no_quit)
8186 (find_before_next_newline, search_command, Freplace_match)
8187 (Fmatch_data): Make some `int' variables be EMACS_INT.
8189 * xdisp.c (display_count_lines): 3rd argument and return value now
8190 EMACS_INT. All callers changed.
8191 (pint2hrstr): Last argument is now EMACS_INT.
8193 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8194 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8195 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8196 (decode_coding_utf_16, decode_coding_emacs_mule)
8197 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8198 (decode_coding_ccl, decode_coding_charset)
8199 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8200 (decode_coding_iso_2022, decode_coding_emacs_mule)
8201 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8202 <char_offset, last_offset>: Declare EMACS_INT.
8203 (encode_coding_utf_8, encode_coding_utf_16)
8204 (encode_coding_emacs_mule, encode_invocation_designation)
8205 (encode_designation_at_bol, encode_coding_iso_2022)
8206 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8207 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8209 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8210 (encode_invocation_designation): Last argument P_NCHARS is now
8212 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8213 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8215 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8218 * ccl.c (Fccl_execute_on_string): Declare some variables
8221 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8223 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8225 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8227 * process.c (Fformat_network_address): Doc fix.
8229 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8231 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8233 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8235 * keyboard.c (read_char): Call Lisp function help-form-show,
8236 instead of using internal_with_output_to_temp_buffer.
8237 (Qhelp_form_show): New var.
8238 (syms_of_keyboard): Use DEFSYM macro.
8240 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8242 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8244 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8246 * process.c (Flist_processes): Remove to Lisp.
8247 (list_processes_1): Delete.
8249 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8251 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8253 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8255 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8257 Fix more problems found by GCC 4.6.0's static checks.
8259 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8261 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8263 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8265 * xdisp.c (vmessage): Mark as a printf-like function.
8267 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8269 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8271 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8272 printf-like functions.
8273 (tiff_load): Add casts to remove these marks before passing them
8274 to system-supplied API.
8276 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8278 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8279 This avoids several warnings with gcc -Wstrict-overflow.
8280 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8281 directly, rather than having caller test rule sign. This avoids
8282 some unnecessary tests.
8283 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8284 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8285 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8287 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8288 (xfont_open): Avoid unnecessary tests.
8290 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8292 * composite.h, composite.c (composition_gstring_put_cache):
8293 Use EMACS_INT, not int, for length.
8295 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8296 breaking out part of COMPOSITION_DECODE_RULE.
8297 (COMPOSITION_DECODE_RULE): Use it.
8298 * composite.c (get_composition_id): Remove unused local vars,
8299 by using the new macro.
8301 * textprop.c (set_text_properties_1): Change while to do-while,
8302 since the condition is always true at first.
8304 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8305 (interval_deletion_adjustment): Return unsigned value.
8308 * process.c (list_processes_1, create_pty, read_process_output):
8309 (exec_sentinel): Remove vars that were set but not used.
8310 (create_pty): Remove unnecessary "volatile"s.
8311 (Fnetwork_interface_info): Avoid possibility of int overflow.
8312 (read_process_output): Do adaptive read buffering even if carryover.
8313 (read_process_output): Simplify nbytes computation if buffered.
8315 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8317 * syntax.c (scan_words): Remove var that was set but not used.
8318 (update_syntax_table): Use unsigned instead of int.
8320 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8321 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8322 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8324 * print.c (print_error_message): Avoid int overflow.
8326 * font.c (font_list_entities): Redo for clarity,
8327 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8329 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8330 (font_score): Avoid potential overflow in diff calculation.
8332 * fns.c (substring_both): Remove var that is set but not used.
8333 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8335 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8337 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8338 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8339 can always succeed if overflow has undefined behavior.
8341 * search.c (boyer_moore, wordify): Remove vars set but not used.
8342 (wordify): Omit three unnecessary tests.
8344 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8345 All callers changed. This avoids the need for an unused var.
8347 * casefiddle.c (casify_region): Remove var that is set but not used.
8349 * dired.c (file_name_completion): Remove var that is set but not used.
8351 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8353 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8354 (Finsert_file_contents): Remove unnecessary code checking fd.
8356 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8357 Check for integer overflow on size calculations.
8359 * buffer.c (Fprevious_overlay_change): Remove var that is set
8362 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8363 Remove vars that are set but not used.
8364 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8365 (timer_check_2): Mark vars as initialized.
8367 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8369 * image.c (lookup_image): Remove var that is set but not used.
8370 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8372 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8373 that are set but not used.
8375 * xfns.c (make_invisible_cursor): Don't return garbage
8376 if XCreateBitmapFromData fails (Bug#8410).
8378 * xselect.c (x_get_local_selection, x_handle_property_notify):
8379 Remove vars that are set but not used.
8381 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8382 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8384 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8385 Remove var that is set but not used.
8386 (scroll_bar_windows_size): Now size_t, not int.
8387 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8390 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8391 (map_tty_color) [!defined MSDOS]: Likewise.
8393 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8395 * coding.c: Remove vars that are set but not used.
8396 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8397 All callers changed.
8398 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8399 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8400 (decode_coding_charset): Remove vars that are set but not used.
8402 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8403 that is set but not used.
8405 * print.c (print_object): Remove var that is set but not used.
8407 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8408 The gnulib version avoids calling malloc in the usual case,
8409 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8410 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8411 * filelock.c (current_lock_owner): Likewise.
8412 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8413 * sysdep.c: Include allocator.h, careadlinkat.h.
8414 (emacs_no_realloc_allocator): New static constant.
8415 (emacs_readlink): New function.
8416 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8417 ../lib/careadlinkat.h.
8419 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8421 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8422 first non-nil return value).
8424 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8426 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8427 if not defined (Bug#8403).
8429 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8431 * xdisp.c (display_count_lines): Remove parameter `start',
8432 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8433 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8434 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8435 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8436 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8437 and thereabouts. All callers changed.
8438 (get_per_char_metric): Remove parameter `f', unused since
8439 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8441 2011-04-02 Jim Meyering <meyering@redhat.com>
8443 do not dereference NULL upon failed strdup
8444 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8445 (ns_get_family): Likewise.
8447 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8449 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8451 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8453 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8456 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8458 Add lexical binding.
8460 * window.c (Ftemp_output_buffer_show): New fun.
8461 (Fsave_window_excursion):
8462 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8464 * lread.c (lisp_file_lexically_bound_p): New function.
8465 (Fload): Bind Qlexical_binding.
8466 (readevalloop): Remove `evalfun' arg.
8467 Bind Qinternal_interpreter_environment.
8468 (Feval_buffer): Bind Qlexical_binding.
8469 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8471 (syms_of_lread): Declare `lexical-binding'.
8473 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8475 * keyboard.c (eval_dyn): New fun.
8476 (menu_item_eval_property): Use it.
8478 * image.c (parse_image_spec): Use Ffunctionp.
8480 * fns.c (concat, mapcar1): Accept byte-code-functions.
8482 * eval.c (Fsetq): Handle lexical vars.
8483 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8484 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8485 (FletX, Flet): Obey lexical binding.
8486 (Fcommandp): Handle closures.
8487 (Feval): New `lexical' arg.
8488 (eval_sub): New function extracted from Feval. Use it almost
8489 everywhere where Feval was used. Look up vars in lexical env.
8491 (Ffunctionp): Move from subr.el.
8492 (Ffuncall): Handle closures.
8493 (apply_lambda): Remove `eval_flags'.
8494 (funcall_lambda): Handle closures and new byte-code-functions.
8495 (Fspecial_variable_p): New function.
8496 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8497 but without exporting it to Lisp.
8499 * doc.c (Fdocumentation, store_function_docstring):
8500 * data.c (Finteractive_form): Handle closures.
8502 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8505 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8507 (exec_byte_code): New function extracted from Fbyte_code to handle new
8508 calling convention for byte-code-functions. Add new byte-codes.
8510 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8512 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8514 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8516 * xdisp.c (redisplay_internal): Fix prototype.
8518 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8520 * xdisp.c (SCROLL_LIMIT): New macro.
8521 (try_scrolling): Use it when setting scroll_limit.
8522 Limit scrolling to 100 screen lines.
8523 (redisplay_window): Even when falling back on "recentering",
8524 position point in the window according to scroll-conservatively,
8525 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8527 (try_scrolling): When point is above the window, allow searching
8528 as far as scroll_max, or one screenful, to compute vertical
8529 distance from PT to the scroll margin position. This prevents
8530 try_scrolling from unnecessarily failing when
8531 scroll-conservatively is set to a value slightly larger than the
8532 window height. Clean up the case of PT below the margin at bottom
8533 of window: scroll_max can no longer be INT_MAX. When aggressive
8534 scrolling is in use, don't let point enter the opposite scroll
8535 margin as result of the scroll.
8536 (syms_of_xdisp) <scroll-conservatively>: Document the
8537 threshold of 100 lines for never-recentering scrolling.
8539 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8541 * dispextern.h (move_it_by_lines):
8542 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8543 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8544 (message_log_check_duplicate): Remove parameters `prev_bol' and
8545 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8546 (redisplay_internal): Remove parameter `preserve_echo_area',
8547 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8549 * indent.c (Fvertical_motion):
8550 * window.c (window_scroll_pixel_based, Frecenter):
8551 Don't pass `need_y_p' to `move_it_by_lines'.
8553 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8555 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8556 steal a few bits to be more compact.
8557 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8558 Remove unneeded casts.
8560 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8562 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8564 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8565 binding" message (bug#7967).
8567 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8569 Fix more problems found by GCC 4.6.0's static checks.
8571 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8572 Remove unused local var.
8574 * editfns.c (Fmessage_box): Remove unused local var.
8576 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8577 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8578 Omit unused local vars.
8579 * window.c (shrink_windows): Omit unused local var.
8580 * menu.c (digest_single_submenu): Omit unused local var.
8581 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8582 Omit unused local var.
8584 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8585 Don't assume string length fits in int.
8586 (keyremap_step, read_key_sequence): Use size_t for sizes.
8587 (read_key_sequence): Don't check last_real_key_start redundantly.
8589 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8590 instead of alloca (Bug#8344).
8592 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8593 (Fbacktrace_frame): Don't assume nframes fits in int.
8595 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8597 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8600 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8602 * cm.c (calccost): Turn while-do into do-while, for clarity.
8604 * keyboard.c (syms_of_keyboard): Use the same style as later
8605 in this function when indexing through an array. This also
8606 works around GCC bug 48267.
8608 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8610 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8612 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8613 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8615 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8616 This avoids undefined behavior on integer overflow, and is a bit
8617 more convenient anyway since it is compared to a size_t variable.
8619 Variadic C functions now count arguments with size_t, not int.
8620 This avoids an unnecessary limitation on 64-bit machines, which
8621 caused (substring ...) to crash on large vectors (Bug#8344).
8622 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8623 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8624 All variadic functions and their callers changed accordingly.
8625 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8626 * data.c (arith_driver, float_arith_driver): Likewise.
8627 * editfns.c (general_insert_function): Likewise.
8628 * eval.c (struct backtrace.nargs, interactive_p)
8629 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8630 (funcall_lambda, mark_backtrace): Likewise.
8631 * fns.c (concat): Likewise.
8632 * frame.c (x_set_frame_parameters): Likewise.
8633 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8634 0 if not found, not -1. All callers changed.
8636 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8637 (stack_copy_size): Now size_t, not int.
8638 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8640 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8642 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8643 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8644 All callers changed.
8646 * lisp.h (multibyte_char_to_unibyte):
8647 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8648 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8649 * character.h (CHAR_TO_BYTE8):
8650 * cmds.c (internal_self_insert):
8651 * editfns.c (general_insert_function):
8652 * keymap.c (push_key_description):
8653 * search.c (Freplace_match):
8654 * xdisp.c (message_dolog, set_message_1): All callers changed.
8656 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8658 * keyboard.c (safe_run_hook_funcall): New function.
8659 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8660 don't set the hook to nil, but remove the offending function instead.
8661 (Qcommand_hook_internal): Remove, unused.
8662 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8663 Vcommand_hook_internal.
8665 * eval.c (enum run_hooks_condition): Remove.
8666 (funcall_nil, funcall_not): New functions.
8667 (run_hook_with_args): Call each function through a `funcall' argument.
8668 Remove `cond' argument, now redundant.
8669 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8670 (Frun_hook_with_args_until_failure): Adjust accordingly.
8671 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8673 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8675 * dispextern.h (string_buffer_position): Remove declaration.
8677 * print.c (strout): Remove parameter `multibyte', unused since
8678 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8680 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8681 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8682 All callers changed.
8684 * w32.c (_wsa_errlist): Use braces for struct initializers.
8686 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8687 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8688 All callers changed.
8689 (string_buffer_position): Likewise. Also, make static (it's never
8690 used outside xdisp.c).
8691 (cursor_row_p): Remove parameter `w', unused since
8692 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8693 (decode_mode_spec): Remove parameter `precision', introduced during
8694 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8695 All callers changed.
8697 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8699 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8701 2011-03-27 Anders Lindgren <andlind@gmail.com>
8703 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8704 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8705 (ns_update_auto_hide_menu_bar): New functions.
8706 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8707 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8708 ns_constrain_all_frames.
8709 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8710 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8712 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8714 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8716 2011-03-27 Glenn Morris <rgm@gnu.org>
8718 * syssignal.h: Replace RETSIGTYPE with void.
8719 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8720 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8721 Replace SIGTYPE with void everywhere.
8722 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8723 * s/template.h (SIGTYPE): Remove commented out definition.
8725 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8727 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8728 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8730 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8732 * w32.c (read_unc_volume): Use parameter `henum', instead of
8733 global variable `wget_enum_handle'.
8735 * keymap.c (describe_vector): Remove parameters `indices' and
8736 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8737 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8739 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8741 * keyboard.c (timer_check): Remove parameter `do_it_now',
8742 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8743 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8744 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8746 * keyboard.c (read_char):
8747 * w32menu.c (w32_menu_display_help):
8748 * xmenu.c (show_help_event, menu_help_callback):
8749 Adjust calls to `show_help_echo'.
8751 * gtkutil.c (xg_maybe_add_timer):
8752 * keyboard.c (readable_events):
8753 * process.c (wait_reading_process_output):
8754 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8756 * insdel.c (adjust_markers_gap_motion):
8757 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8758 (gap_left, gap_right): Don't call it.
8760 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8762 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8763 incurred during fontification.
8765 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8767 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8768 (DEFVAR_PER_BUFFER): Don't pass it.
8770 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8771 (scrolling_window): Don't pass it.
8773 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8775 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8777 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8779 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8780 of variables specific to SELinux and computation of `encoded_absname'.
8782 * image.c (XPutPixel): Remove unused variable `height'.
8784 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8786 * unexw32.c (get_section_info): Remove unused variable `section'.
8788 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8789 (system_process_attributes): Remove unused variable `sess'.
8790 (sys_read): Remove unused variable `err'.
8792 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8793 (w32_wnd_proc): Remove unused variable `isdead'.
8794 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8795 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8796 (x_create_tip_frame): Remove unused variable `tem'.
8798 * w32inevt.c (w32_console_read_socket):
8799 Remove unused variable `no_events'.
8801 * w32term.c (x_draw_composite_glyph_string_foreground):
8802 Remove unused variable `width'.
8804 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8806 * w32term.c (x_set_glyph_string_clipping):
8807 Don't pass uninitialized region to CombineRgn.
8809 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8811 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8812 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8813 (Fx_close_connection): Remove unused variable `i'.
8815 * w32font.c (w32font_draw): Return number of glyphs.
8816 (w32font_open_internal): Remove unused variable `i'.
8817 (w32font_driver): Add missing initializer.
8819 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8820 (fill_in_menu): Remove unused variable `items_added'.
8822 * w32term.c (last_mouse_press_frame): Remove static global variable.
8823 (w32_clip_to_row): Remove unused variable `f'.
8824 (x_delete_terminal): Remove unused variable `i'.
8826 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8827 (NOTHING): Remove unused static global variable.
8828 (uniscribe_check_otf): Remove unused variable `table'.
8829 (uniscribe_font_driver): Add missing initializers.
8831 2011-03-23 Julien Danjou <julien@danjou.info>
8833 * term.c (Fsuspend_tty, Fresume_tty):
8834 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8835 * window.c (temp_output_buffer_show):
8836 * insdel.c (signal_before_change):
8837 * frame.c (Fhandle_switch_frame):
8838 * fileio.c (Fdo_auto_save):
8839 * emacs.c (Fkill_emacs):
8840 * editfns.c (save_excursion_restore):
8841 * cmds.c (internal_self_insert):
8842 * callint.c (Fcall_interactively):
8843 * buffer.c (Fkill_all_local_variables):
8844 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8846 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8847 unconditionally since it does the check itself.
8849 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8851 Fix more problems found by GCC 4.5.2's static checks.
8853 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8854 the first time through the loop, since we know p0 < p1 then.
8855 This also avoids a gcc -Wstrict-overflow warning.
8857 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8858 leading to a memory leak, possible in functions like
8859 load_charset_map_from_file that can allocate an unbounded number
8860 of objects (Bug#8318).
8862 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8863 that could (at least in theory) be that large.
8865 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8866 This is less likely to overflow, and avoids undefined behavior if
8867 overflow does occur. All callers changed. Use strtoul to scan
8868 for the unsigned long integer.
8869 (pint2hrstr): Simplify and tune code slightly.
8870 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8872 * scroll.c (do_scrolling): Work around GCC bug 48228.
8873 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8875 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8876 This also avoids a warning with gcc -Wstrict-overflow.
8877 (validate_x_resource_name): Simplify count usage.
8878 This also avoids a warning with gcc -Wstrict-overflow.
8880 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8883 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8885 * process.c (Fmake_network_process): Use socklen_t, not int,
8886 where POSIX says socklen_t is required in portable programs.
8887 This fixes a porting bug on hosts like 64-bit HP-UX, where
8888 socklen_t is wider than int (Bug#8277).
8889 (Fmake_network_process, server_accept_connection):
8890 (wait_reading_process_output, read_process_output):
8893 * process.c: Rename or move locals to avoid shadowing.
8894 (list_processes_1, Fmake_network_process):
8895 (read_process_output_error_handler, exec_sentinel_error_handler):
8896 Rename or move locals.
8897 (Fmake_network_process): Define label "retry_connect" only if needed.
8898 (Fnetwork_interface_info): Fix pointer signedness.
8899 (process_send_signal): Add cast to avoid pointer signedness problem.
8900 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8901 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8903 Make tparam.h and terminfo.c consistent.
8904 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8905 Include tparam.h instead, since it declares them.
8906 * cm.h (PC): Remove extern decl; tparam.h now does this.
8907 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8908 * terminfo.c: Include tparam.h, to check interfaces.
8909 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8910 (tparam): Adjust signature to match interface in tparam.h;
8911 this removes some undefined behavior. Check that outstring and len
8912 are zero, which they always are with Emacs.
8913 * tparam.h (PC, BC, UP): New extern decls.
8915 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8916 (xftfont_open): Rename locals to avoid shadowing.
8918 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8919 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8920 (OTF_TAG_SYM): Omit macro if not needed.
8921 (ftfont_list): Remove unused local.
8922 (get_adstyle_property, ftfont_pattern_entity):
8923 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8924 Rename locals to avoid shadowing.
8926 * xfont.c (xfont_list_family): Mark var as initialized.
8928 * xml.c (make_dom): Now static.
8930 * composite.c (composition_compute_stop_pos): Rename local to
8932 (composition_reseat_it): Remove unused locals.
8933 (find_automatic_composition, composition_adjust_point): Likewise.
8934 (composition_update_it): Mark var as initialized.
8935 (find_automatic_composition): Mark vars as initialized,
8936 with a FIXME (Bug#8290).
8938 character.h: Rename locals to avoid shadowing.
8939 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8940 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8941 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8942 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8945 * textprop.c (property_change_between_p): Remove; unused.
8947 * intervals.c (interval_start_pos): Now static.
8949 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8951 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8952 Rename locals to avoid shadowing.
8954 * sound.c (wav_play, au_play, Fplay_sound_internal):
8955 Fix pointer signedness.
8956 (alsa_choose_format): Remove unused local var.
8957 (wav_play): Initialize a variable to 0, to prevent undefined
8958 behavior (Bug#8278).
8960 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8962 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8964 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8965 clobbering (Bug#8298).
8966 * sysdep.c (sys_subshell): Likewise.
8967 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8969 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8970 This should get cleaned up, so that child_setup has the
8971 same signature on all platforms.
8973 * callproc.c (call_process_cleanup): Now static.
8974 (relocate_fd): Rename locals to avoid shadowing.
8976 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8978 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8979 not to be necessary, and produces flickering.
8981 2011-03-20 Glenn Morris <rgm@gnu.org>
8983 * config.in: Remove file.
8985 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8987 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8988 are now in src/globals.h.
8989 (syms_of_minibuf): Remove spurious & from previous change.
8991 2011-03-20 Leo Liu <sdl.web@gmail.com>
8993 * minibuf.c (completing-read-function): New variable.
8994 (completing-read-default): Rename from completing-read.
8995 (completing-read): Call completing-read-function.
8997 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8999 * xfaces.c (Fx_load_color_file):
9000 Read color file from absolute filename (bug#8250).
9002 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9004 * makefile.w32-in: Update dependencies.
9006 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9008 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9010 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9012 Fix more problems found by GCC 4.5.2's static checks.
9014 * process.c (make_serial_process_unwind, send_process_trap):
9015 (sigchld_handler): Now static.
9017 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9018 That way, the code declares only the vars that it needs.
9019 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9020 * s/cygwin.h (PTY_ITERATION): Likewise.
9021 * s/darwin.h (PTY_ITERATION): Likewise.
9022 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9024 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9025 * process.c (allocate_pty): Don't declare stb unless it's needed.
9027 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9028 (CONSTANTLIM): Remove; unused.
9029 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9030 Define only if needed.
9032 * unexelf.c (unexec): Name an expression,
9033 to avoid gcc -Wbad-function-cast warning.
9034 Use a different way to cause a compilation error if anyone uses
9035 n rather than nn, a way that does not involve shadowing.
9036 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9038 * deps.mk (unexalpha.o): Remove; unused.
9040 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9041 * unexec.h: New file.
9042 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9043 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9045 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9046 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9047 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9048 Change as necessary to match prototype in unexec.h.
9050 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9052 (back_comment, skip_chars): Mark vars as initialized.
9054 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9055 Rename locals to avoid shadowing.
9057 * lread.c (read1): Rewrite so as not to use empty "else".
9058 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9060 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9062 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9063 warning when compiling print.c.
9065 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9066 instead of using an uninitialized var.
9067 (font_sort_entities): Mark var as initialized.
9069 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9071 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9072 pointers to constants.
9073 (font_parse_fcname): Remove unused vars.
9074 (font_delete_unmatched): Now static.
9075 (font_get_spec): Remove; unused.
9076 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9077 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9078 Rename or move locals to avoid shadowing.
9080 * fns.c (require_nesting_list, require_unwind): Now static.
9081 (Ffillarray): Rename locals to avoid shadowing.
9083 * floatfns.c (domain_error2): Define only if needed.
9084 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9086 * alloc.c (mark_backtrace): Move decl from here ...
9087 * lisp.h: ... to here, so that it can be checked.
9089 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9090 (Fdefvar): Rewrite so as not to use empty "else".
9091 (lisp_indirect_variable): Name an expression,
9092 to avoid gcc -Wbad-function-cast warning.
9093 (Fdefvar): Rename locals to avoid shadowing.
9095 * callint.c (quotify_arg, quotify_args): Now static.
9096 (Fcall_interactively): Rename locals to avoid shadowing.
9097 Use const pointer when appropriate.
9099 * lisp.h (get_system_name, get_operating_system_release):
9100 Move decls here, to check interfaces.
9101 * process.c (get_operating_system_release): Move decl to lisp.h.
9102 * xrdb.c (get_system_name): Likewise.
9103 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9104 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9105 some of which prompt warnings from gcc -Wbad-function-cast.
9106 (Fformat_time_string, Fencode_time, Finsert_char):
9107 (Ftranslate_region_internal, Fformat):
9108 Rename or remove local vars to avoid shadowing.
9109 (Ftranslate_region_internal): Mark var as initialized.
9111 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9114 * lisp.h (eassert): Check that the argument compiles, even if
9115 ENABLE_CHECKING is not defined.
9117 * data.c (Findirect_variable): Name an expression, to avoid
9118 gcc -Wbad-function-cast warning.
9119 (default_value, arithcompare, arith_driver, arith_error): Now static.
9120 (store_symval_forwarding): Rename local to avoid shadowing.
9121 (Fmake_variable_buffer_local, Fmake_local_variable):
9122 Mark variables as initialized.
9123 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9125 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9126 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9127 Rename locals to avoid shadowing.
9128 (mark_stack): Move local variables into the #ifdef region where
9130 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9131 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9133 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9134 (GC_STRING_CHARS): Remove; not used.
9135 (Fmemory_limit): Cast sbrk's returned value to char *.
9137 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9138 avoids undefined behavior in theory.
9140 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9142 Use functions, not macros, for up- and down-casing (Bug#8254).
9143 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9144 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9145 to use the following functions instead of these macros.
9146 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9147 EMACS_INT, since callers assume the returned value fits in int.
9148 (upcase1): Likewise, for UPCASE_TABLE.
9149 (uppercasep, lowercasep, upcase): New static inline functions.
9150 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9151 the race-condition problem in the old DOWNCASE.
9153 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9154 Rename locals to avoid shadowing.
9155 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9156 (regex_compile, re_search_2, re_match_2_internal):
9157 Remove unused local vars.
9158 (FREE_VAR): Rewrite so as not to use empty "else",
9159 which gcc can warn about.
9160 (regex_compile, re_match_2_internal): Mark locals as initialized.
9161 (RETALLOC_IF): Define only if needed.
9162 (WORDCHAR_P): Likewise. This one is never needed, but is used
9163 only in a comment talking about a compiler bug, so put inside
9164 the #if 0 of that comment.
9165 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9166 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9169 * search.c (boyer_moore): Rename locals to avoid shadowing.
9170 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9171 (PREV_CHAR_BOUNDARY): Likewise.
9173 * search.c (simple_search): Remove unused var.
9175 * dired.c (compile_pattern): Move decl from here ...
9176 * lisp.h: ... to here, so that it can be checked.
9177 (struct re_registers): New forward decl.
9179 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9181 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9183 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9184 Rename locals to avoid shadowing.
9185 (Fvertical_motion): Mark locals as initialized.
9187 * casefiddle.c (casify_object, casify_region): Now static.
9188 (casify_region): Mark local as initialized.
9190 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9192 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9193 New macros, so that the caller can use some names other than
9194 gcpro1, gcpro2, etc.
9195 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9197 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9198 argument, for consistency with GCPRO2_VAR, etc: it is now the
9199 prefix of the variable, not the variable itself. All uses
9201 * dired.c (directory_files_internal, file_name_completion):
9202 Rename locals to avoid shadowing.
9204 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9205 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9206 dired.c's scmp function, had undefined behavior.
9207 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9208 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9209 * buffer.h: ... to here, because these macros use current_buffer,
9210 and the new implementation with inline functions needs to have
9211 current_buffer in scope now, rather than later when the macros
9213 (downcase, upcase1): New static inline functions.
9214 (DOWNCASE, UPCASE1): Reimplement using these functions.
9215 This avoids undefined behavior in expressions like
9216 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9217 from race conditions in accessing the global variables
9218 case_temp1 and case_temp2.
9219 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9220 * lisp.h (case_temp1, case_temp2): Remove their decls.
9221 * character.h (ASCII_CHAR_P): Move from here ...
9222 * lisp.h: ... to here, so that the inline functions mentioned
9225 * dired.c (directory_files_internal_unwind): Now static.
9227 * fileio.c (file_name_as_directory, directory_file_name):
9228 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9230 (file_name_as_directory): Use const pointers when appropriate.
9231 (Fexpand_file_name): Likewise. In particular, newdir might
9232 point at constant storage, so make it a const pointer.
9233 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9234 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9236 (Fset_file_times, Finsert_file_contents, auto_save_error):
9237 Rename locals to avoid shadowing.
9239 * minibuf.c (choose_minibuf_frame_1): Now static.
9240 (Ftry_completion, Fall_completions): Rename or remove locals
9243 * marker.c (bytepos_to_charpos): Remove; unused.
9245 * lisp.h (verify_bytepos, count_markers): New decls,
9246 so that gcc does not warn that these functions aren't declared.
9248 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9249 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9250 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9251 (copy_text): Remove unused local var.
9253 * filelock.c (within_one_second): Now static.
9254 (lock_file_1): Rename local to avoid shadowing.
9256 * buffer.c (fix_overlays_before): Mark locals as initialized.
9257 (fix_start_end_in_overlays): Likewise. This function should be
9258 simplified by using pointers-to-pointers, but that's a different
9260 (switch_to_buffer_1): Now static.
9261 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9262 (report_overlay_modification): Rename locals to avoid shadowing.
9264 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9265 Fix pointer signedness issue.
9266 (sys_subshell): Mark local as volatile if checking for lint,
9267 to suppress a gcc -Wclobbered warning that does not seem to be right.
9268 (MAXPATHLEN): Define only if needed.
9270 * process.c (serial_open, serial_configure): Move decls from here ...
9271 * systty.h: ... to here, so that they can be checked.
9273 * fns.c (get_random, seed_random): Move extern decls from here ...
9274 * lisp.h: ... to here, so that they can be checked.
9276 * sysdep.c (reset_io): Now static.
9277 (wait_for_termination_signal): Remove; unused.
9279 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9280 (copy_keymap_item, append_key, push_text_char_description):
9282 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9283 (DENSE_TABLE_SIZE): Remove; unused.
9284 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9285 (describe_map_tree):
9286 Rename locals to avoid shadowing.
9288 * keyboard.c: Declare functions static if they are not used elsewhere.
9289 (echo_char, echo_dash, cmd_error, top_level_2):
9290 (poll_for_input, handle_async_input): Now static.
9291 (read_char, kbd_buffer_get_event, make_lispy_position):
9292 (make_lispy_event, make_lispy_movement, apply_modifiers):
9293 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9294 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9295 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9296 (read_key_sequence, read_char): Mark locals as initialized.
9297 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9299 * keyboard.h (make_ctrl_char): New decl.
9300 (mark_kboards): Move decl here ...
9301 * alloc.c (mark_kboards): ... from here.
9303 * lisp.h (force_auto_save_soon): New decl.
9305 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9306 (DEFINE_DUMMY_FUNCTION): New macro.
9307 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9309 (main): Add casts to avoid warnings
9310 if GCC considers string literals to be constants.
9312 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9314 * dbusbind.c: Pointer signedness fixes.
9315 (xd_signature, xd_append_arg, xd_initialize):
9316 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9317 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9318 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9319 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9321 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9322 if GCC considers string literals to be constants.
9323 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9325 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9327 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9328 (print_preprocess, print_object): New macro to fix last change.
9330 * print.c (print_preprocess): Don't forget font objects.
9332 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9334 * emacs.c (USAGE3): Doc fixes.
9336 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9338 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9341 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9343 * lisp.h (VWindow_system, Qfile_name_history):
9344 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9345 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9346 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9348 * w32select.c: Don't #include "keyboard.h".
9349 (run_protected): Add extern declaration for waiting_for_input.
9351 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9352 * w32console.c (detect_input_pending, read_input_pending)
9353 (encode_terminal_code):
9354 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9355 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9356 (w32_system_caret_y, Qfile_name_history):
9357 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9358 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9359 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9360 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9361 * w32proc.c (Qlocal, report_file_error):
9362 * w32term.c (Vwindow_system, updating_frame):
9363 * w32uniscribe.c (initialized, uniscribe_font_driver):
9364 Remove unneeded extern declarations.
9366 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9368 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9370 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9372 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9373 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9374 These macros can no longer be used for assignment.
9376 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9377 Assign struct members directly, instead of using BUF_BEGV etc.
9378 (record_buffer_markers, fetch_buffer_markers): New functions for
9379 recording and fetching special buffer markers.
9380 (set_buffer_internal_1, set_buffer_temp): Use them.
9382 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9384 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9386 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9387 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9389 * xdisp.c (hscroll_window_tree):
9390 (reconsider_clip_changes): Use PT instead of BUF_PT.
9392 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9394 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9395 $(EMACS_ROOT)/lib/intprops.h.
9397 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9399 Fix more problems found by GCC 4.5.2's static checks.
9401 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9402 to unsigned char * to avoid compiler diagnostic.
9403 (xg_free_frame_widgets): Make it clear that a local variable is
9404 needed only if USE_GTK_TOOLTIP.
9405 (gdk_window_get_screen): Make it clear that this macro is needed
9406 only if USE_GTK_TOOLTIP.
9407 (int_gtk_range_get_value): New function, which avoids a diagnostic
9408 from gcc -Wbad-function-cast.
9409 (xg_set_toolkit_scroll_bar_thumb): Use it.
9410 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9411 diagnostic from gcc -Wbad-function-cast.
9412 (get_utf8_string, xg_get_file_with_chooser):
9413 Rename locals to avoid shadowing.
9414 (create_dialog): Move locals to avoid shadowing.
9416 * xgselect.c (xg_select): Remove unused var.
9418 * image.c (four_corners_best): Mark locals as initialized.
9419 (gif_load): Initialize transparent_p to zero (Bug#8238).
9420 Mark another local as initialized.
9421 (my_png_error, my_error_exit): Mark with NO_RETURN.
9423 * image.c (clear_image_cache): Now static.
9424 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9425 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9426 (x_edge_detection): Remove unnecessary cast that
9427 gcc -Wbad-function-cast diagnoses.
9428 (gif_load): Fix pointer signedness.
9429 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9430 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9432 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9434 Improve quality of tests for time stamp overflow.
9435 For example, without this patch (encode-time 0 0 0 1 1
9436 1152921504606846976) returns the obviously-bogus value (-948597
9437 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9438 reports time overflow. See
9439 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9440 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9441 * editfns.c: Include limits.h and intprops.h.
9442 (TIME_T_MIN, TIME_T_MAX): New macros.
9443 (time_overflow): Move earlier, to before first use.
9444 (hi_time, lo_time): New functions, for an accurate test for
9446 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9447 (Fget_internal_run_time): Don't assume time_t fits in int.
9448 (make_time): Use list2 instead of Fcons twice.
9449 (Fdecode_time): More accurate test for out-of-range times.
9450 (check_tm_member): New function.
9451 (Fencode_time): Use it, to test for out-of-range times.
9452 (lisp_time_argument): Don't rely on undefined left-shift and
9453 right-shift behavior when checking for time stamp overflow.
9455 * editfns.c (time_overflow): New function, refactoring common code.
9456 (Fformat_time_string, Fdecode_time, Fencode_time):
9457 (Fcurrent_time_string): Use it.
9459 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9460 * dired.c (make_time): Move to ...
9461 * editfns.c (make_time): ... here.
9462 * systime.h: Note the move.
9464 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9466 * fringe.c (update_window_fringes): Remove unused variables.
9468 * unexmacosx.c (copy_data_segment): Also copy __got section.
9471 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9473 * termcap.c [MSDOS]: Include "msdos.h".
9474 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9475 Constify `char *' arguments and their references according to
9476 prototypes in tparam.h.
9478 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9480 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9481 Adapt all references accordingly.
9483 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9485 2011-03-11 Tom Tromey <tromey@redhat.com>
9487 * buffer.c (syms_of_buffer): Remove obsolete comment.
9489 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9491 * termhooks.h (encode_terminal_code): Declare prototype.
9493 * msdos.c (encode_terminal_code): Don't declare prototype.
9495 * term.c (encode_terminal_code): Now external again, used by
9496 w32console.c and msdos.c.
9498 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9499 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9501 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9503 Fix some minor problems found by GCC 4.5.2's static checks.
9505 * fringe.c (update_window_fringes): Mark locals as initialized
9507 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9509 * alloc.c (mark_fringe_data): Move decl from here ...
9510 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9511 to check its interface.
9512 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9514 * fontset.c (free_realized_fontset): Now static.
9515 (Fset_fontset_font): Rename local to avoid shadowing.
9516 (fontset_font): Mark local as initialized.
9517 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9519 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9521 * xselect.c (x_disown_buffer_selections): Remove; not used.
9522 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9523 (x_own_selection, Fx_disown_selection_internal): Rename locals
9525 (x_handle_dnd_message): Remove local to avoid shadowing.
9527 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9528 so that the caller can use some name other than gcpro1.
9529 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9530 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9531 (Fx_backspace_delete_keys_p):
9532 Use them to avoid shadowing, and rename vars to avoid shadowing.
9533 (x_decode_color, x_set_name, x_window): Now static.
9534 (Fx_create_frame): Add braces to silence GCC warning.
9535 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9536 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9537 Remove unused locals.
9538 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9539 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9540 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9543 * xterm.h (x_mouse_leave): New decl.
9545 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9546 Remove unused functions.
9547 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9548 (x_calc_absolute_position): Now static.
9549 (XTread_socket): Don't define label "out" unless it's used.
9550 Don't declare local "event" unless it's used.
9551 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9552 unless they are used.
9553 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9554 (x_fatal_error_signal): Remove; not used.
9555 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9556 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9557 (x_error_catcher, x_connection_closed, x_error_handler):
9558 (x_error_quitter, xembed_send_message, x_iconify_frame):
9559 (my_log_handler): Rename locals to avoid shadowing.
9560 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9561 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9563 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9564 Rename or move locals to avoid shadowing.
9565 (tty_defined_color, merge_face_heights): Now static.
9566 (free_realized_faces_for_fontset): Remove; not used.
9567 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9568 does not deduce is never used uninitialized.
9569 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9570 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9572 * terminal.c (store_terminal_param): Now static.
9574 * xmenu.c (menu_highlight_callback): Now static.
9575 (set_frame_menubar): Remove unused local.
9576 (xmenu_show): Rename parameter to avoid shadowing.
9577 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9578 since they might point to immutable storage.
9579 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9580 since it's unused otherwise.
9582 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9583 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9584 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9585 avoids a gcc -Wuninitialized diagnostic.
9586 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9587 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9588 does not deduce are never used uninitialized.
9590 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9592 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9593 * window.c (window_loop, size_window):
9594 (run_window_configuration_change_hook, enlarge_window): Likewise.
9596 * window.c (display_buffer): Now static.
9597 (size_window): Mark variables that gcc -Wuninitialized
9598 does not deduce are never used uninitialized.
9599 * window.h (check_all_windows): New decl, to forestall
9600 gcc -Wmissing-prototypes diagnostic.
9601 * dispextern.h (bidi_dump_cached_states): Likewise.
9603 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9605 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9607 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9608 and to avoid gcc -Wuninitialized warning.
9609 (load_charset_map): Mark variables that gcc -Wuninitialized
9610 does not deduce are never used uninitialized.
9611 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9613 * coding.c (coding_set_source, coding_set_destination):
9614 Use "else { /* comment */ }" rather than "else /* comment */;"
9615 for clarity, and to avoid gcc -Wempty-body warning.
9616 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9617 a block, when the outer 'i' will do.
9618 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9619 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9620 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9621 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9622 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9623 Rename locals to avoid shadowing.
9624 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9625 * coding.c (emacs_mule_char, encode_invocation_designation):
9626 Now static, since they're not used elsewhere.
9627 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9628 (decode_coding_object, encode_coding_object, detect_coding_system):
9629 (decode_coding_emacs_mule): Mark variables that gcc
9630 -Wuninitialized does not deduce are never used uninitialized.
9631 (detect_coding_iso_2022): Initialize a local variable that might
9632 be used uninitialized. Leave a FIXME because it's not clear that
9633 this initialization is needed. (Bug#8211)
9634 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9635 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9636 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9637 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9638 Remove unused macros.
9640 * category.c (hash_get_category_set): Remove unused local var.
9641 (copy_category_table): Now static, since it's not used elsewhere.
9642 * character.c (string_count_byte8): Likewise.
9644 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9645 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9647 * chartab.c (copy_sub_char_table): Now static, since it's not used
9649 (sub_char_table_ref_and_range, char_table_ref_and_range):
9650 Rename locals to avoid shadowing.
9651 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9653 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9654 (BIDI_BOB): Remove unused macro.
9656 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9657 deduce are never used uninitialized.
9658 * term.c (encode_terminal_code): Likewise.
9660 * term.c (encode_terminal_code): Now static. Remove unused local.
9662 * tparam.h: New file.
9663 * term.c, tparam.h: Include it.
9664 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9665 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9666 Move these decls to tparam.h, and make them agree with what
9667 is actually in tparam.c. The previous trick of using incompatible
9668 decls in different modules does not conform to the C standard.
9669 All callers of tparam changed to use tparam's actual API.
9670 * tparam.c (tparam1, tparam, tgoto):
9671 Use const pointers where appropriate.
9673 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9674 * cm.h (struct cm): Likewise.
9675 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9676 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9677 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9678 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9679 (turn_on_face, init_tty): Likewise.
9680 * termchar.h (struct tty_display_info): Likewise.
9682 * term.c (term_mouse_position): Rename local to avoid shadowing.
9684 * alloc.c (mark_ttys): Move decl from here ...
9685 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9687 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9689 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9691 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9693 * search.c (compile_pattern_1): Remove argument regp, unused since
9694 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9695 (compile_pattern): Don't pass it.
9697 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9699 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9700 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9702 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9704 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9706 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9707 gdk_window_get_screen, gdk_window_get_geometry,
9708 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9709 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9710 (xg_get_pixbuf_from_pixmap): New function.
9711 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9712 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9713 Call xg_get_pixbuf_from_pixmap instead of
9714 gdk_pixbuf_get_from_drawable.
9715 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9716 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9717 (xg_check_special_colors): Use GtkStyleContext and its functions
9719 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9720 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9721 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9722 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9723 Call gtk_widget_get_preferred_size.
9724 (xg_frame_resized): gdk_window_get_geometry only takes 5
9726 (xg_win_to_widget, xg_event_is_for_menubar):
9727 Call gdk_x11_window_lookup_for_display.
9728 (xg_set_widget_bg): New function.
9729 (delete_cb): New function.
9730 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9731 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9732 (xg_set_background_color): Call xg_set_widget_bg.
9733 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9734 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9735 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9736 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9738 (update_frame_tool_bar): Call gtk_widget_hide.
9739 (xg_initialize): Use GDK_KEY_g.
9741 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9743 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9745 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9746 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9747 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9749 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9751 * w32xfns.c (select_palette): Check success of RealizePalette against
9752 GDI_ERROR, not zero.
9754 See ChangeLog.11 for earlier changes.
9760 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9762 This file is part of GNU Emacs.
9764 GNU Emacs is free software: you can redistribute it and/or modify
9765 it under the terms of the GNU General Public License as published by
9766 the Free Software Foundation, either version 3 of the License, or
9767 (at your option) any later version.
9769 GNU Emacs is distributed in the hope that it will be useful,
9770 but WITHOUT ANY WARRANTY; without even the implied warranty of
9771 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9772 GNU General Public License for more details.
9774 You should have received a copy of the GNU General Public License
9775 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.