1 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3 * alloc.c (make_byte_code): New function.
4 (Fmake_byte_code): Use it. Don't purify here.
5 * lread.c (read1): Use it as well to avoid extra allocation.
7 2012-06-11 Chong Yidong <cyd@gnu.org>
9 * image.c (imagemagick_load_image): Implement transparency.
11 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
13 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
14 account for preceding backslashes. (Bug#11663)
16 2012-06-09 Chong Yidong <cyd@gnu.org>
18 * term.c: Support italics in capable terminals (Bug#9652).
19 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
20 (turn_on_face): Output using TS_enter_italic_mode if available.
21 Don't handle unused blinking and alt-charset cases.
22 (turn_off_face): Handle italic case; discard unused tty_blinking_p
23 and tty_alt_charset_p cases.
24 (tty_capable_p, init_tty): Support italics.
26 * termchar.h (struct tty_display_info): Add field for italics.
27 Remove unused blink field.
29 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
32 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
33 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
34 tty_alt_charset_p. Add tty_italic_p.
36 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
38 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
39 dbus_type_is_basic if available.
40 (xd_extract_signed, xd_extract_unsigned): Rename from
41 extract_signed and extract_unsigned, respectively. Adapt callers.
43 2012-06-09 Chong Yidong <cyd@gnu.org>
45 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
47 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
50 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
52 * xdisp.c (vmessage): Treat frame message as multibyte.
53 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
54 would generate the diagnostic "Making \302\247 buffer-local while
57 2012-06-08 Eli Zaretskii <eliz@gnu.org>
59 * dispnew.c (showing_window_margins_p): Undo last change, which
60 was done due to an inadvertent commit.
61 (adjust_frame_glyphs_for_frame_redisplay): Do call
62 showing_window_margins_p.
64 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
66 * eval.c (Fmake_var_non_special): New primitive.
67 (syms_of_eval): Defsubr it.
68 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
70 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
72 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
73 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
75 2012-06-08 Eli Zaretskii <eliz@gnu.org>
77 * alloc.c (allocate_vectorlike): Fix last change.
79 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
81 Block-based vector allocation of small vectors.
82 * lisp.h (struct vectorlike_header): New field `nbytes',
83 adjust comment accordingly.
84 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
85 to denote vector blocks. Adjust users (live_vector_p,
86 mark_maybe_pointer, valid_lisp_object_p) accordingly.
87 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
88 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
89 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
90 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
91 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
92 (roundup_size): New constant.
93 (struct vector_block): New data type.
94 (vector_blocks, vector_free_lists, zero_vector): New variables.
95 (all_vectors): Rename to `large_vectors'.
96 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
97 (sweep_vectors): New functions.
98 (allocate_vectorlike): Return `zero_vector' as the only vector of
99 0 items. Allocate new vector from block if vector size is less than
100 or equal to VBLOCK_BYTES_MAX.
101 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
102 (init_alloc_once): Add call to init_vectors.
104 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
106 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
108 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
110 * doprnt.c (doprnt): Truncate multibyte char correctly.
111 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
112 would mishandle a string argument "Xc" if X was a multibyte
113 character of length 2: it would truncate after X's first byte
114 rather than including all of X.
116 2012-06-06 Chong Yidong <cyd@gnu.org>
118 * buffer.c (word_wrap): Doc fix.
120 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
122 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
124 2012-06-03 Glenn Morris <rgm@gnu.org>
126 * xdisp.c (tool-bar-style): Doc fix.
128 2012-06-03 Ulrich Müller <ulm@gentoo.org>
130 * Makefile.in (PAXCTL): Define.
131 (temacs$(EXEEXT)): Disable memory randomization for the temacs
132 binary via PaX flags if the paxctl utility is available.
133 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
134 Restore PaX flags to their default. (Bug#11398)
136 2012-06-03 Chong Yidong <cyd@gnu.org>
138 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
141 2012-06-03 Chong Yidong <cyd@gnu.org>
143 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
144 (note_mode_line_or_margin_highlight): If there is no help echo,
145 use mode-line-default-help-echo. Handle the case where the mouse
146 position is past the end of the mode line string.
148 * buffer.c (buffer_local_value_1): New function, split from
149 Fbuffer_local_value; can return Qunbound.
150 (Fbuffer_local_value): Use it.
151 (Vmode_line_format): Docstring tweaks.
153 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
155 * sysdep.c (system_process_attributes): Improve comment.
157 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
159 * keyboard.c: Export real-this-command to Elisp.
160 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
161 and DEFVAR it. Update all users.
163 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
165 * minibuf.c (Fassoc_string): Remove duplicate declaration.
167 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
168 Convert pctcpu and pctmem to Lisp float properly.
169 Let the compiler fold better, as 100.0/0x8000 is exact.
171 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
173 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
176 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
178 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
180 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
182 For a 'struct window', replace some Lisp_Object fields to
183 bitfields where appropriate, remove unused fields.
184 * window.h (struct window): Remove unused 'last_mark_x' and
185 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
186 change it's type from Lisp_Object to bitfield.
187 Change type of 'force_start', 'optional_new_start',
188 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
189 fields from Lisp_Object to bitfield. Adjust users accordingly.
191 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
193 Pacify gcc -Wdouble-precision when using Xaw.
194 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
195 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
196 Use 'float' consistently, rather than 'float' in most places
197 and 'double' in a couple of places.
199 2012-05-31 Eli Zaretskii <eliz@gnu.org>
201 * xdisp.c (handle_stop): Detect whether we have overlay strings
202 loaded by testing it->current.overlay_string_index to be
203 non-negative, instead of checking whether n_overlay_strings is
204 positive. (Bug#11587)
206 2012-05-31 Chong Yidong <cyd@gnu.org>
208 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
210 * doc.c (Fsubstitute_command_keys): Doc fix.
212 2012-05-31 Eli Zaretskii <eliz@gnu.org>
214 * search.c (search_buffer): Remove calls to
215 r_alloc_inhibit_buffer_relocation, as it is now called by
216 maybe_unify_char, which was the cause of relocation of buffer text
219 2012-05-31 Eli Zaretskii <eliz@gnu.org>
221 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
222 for the duration of call to load_charset, to avoid problems with
223 callers of maybe_unify_char that access buffer text through C
226 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
227 decrement the inhibition flag, instead of just setting or
230 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
232 Remove obsolete '#define static' cruft.
233 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
234 This #undef was "temporary" in 2000; it is no longer needed
235 now that '#define static' has gone away.
236 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
237 (gray_bitmap_bits): Remove; no longer needed.
238 All uses replaced with definiens.
239 * xterm.c: Include "bitmaps/gray.xbm".
241 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
243 Clean up __executable_start, monstartup when --enable-profiling.
244 The following changes affect the code only when profiling.
245 * dispnew.c (__executable_start): Rename from safe_bcopy.
246 Define only on platforms that need it.
247 * emacs.c: Include <sys/gmon.h> when profiling.
248 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
249 (__executable_start): Remove decl, since lisp.h does it now.
250 (safe_bcopy): Remove decl; no longer has that name.
251 (main): Coalesce #if into single bit of code, for simplicity.
252 Cast pointers to uintptr_t, since standard libraries want integers
254 * lisp.h (__executable_start): New decl.
256 2012-05-31 Glenn Morris <rgm@gnu.org>
258 * image.c (Fimagemagick_types): Doc fix.
260 2012-05-30 Jim Meyering <meyering@redhat.com>
262 * callproc.c (Fcall_process_region): Include directory component
263 in mkstemp error message (Bug#11586).
265 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
267 * alloc.c, lisp.h (make_pure_vector): Now static.
269 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
271 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
273 (Fautoload): Do the hash-doc more carefully.
274 * data.c (Fdefalias): Purify definition, except for keymaps.
275 (Qdefun): Move from eval.c.
276 * lisp.h (Qdefun): Remove.
277 * lread.c (read1): Tiny simplification.
279 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
281 Do not create empty overlays with the evaporate property (Bug#9642).
282 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
283 Bug#9642, but explicitly check that the buffer the overlay would
284 be moved to is live and rearrange lines to make sure that errors
285 will not put the overlay in an inconsistent state.
286 (Fdelete_overlay): Cosmetics.
288 2012-05-28 Eli Zaretskii <eliz@gnu.org>
290 * w32term.c (my_bring_window_to_top): New function.
291 (x_raise_frame): Use handle returned by DeferWindowPos, which
292 could be different from the original one.
293 Call my_bring_window_to_top instead of my_set_foreground_window.
296 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
297 by calling BringWindowToTop.
299 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
300 (WM_EMACS_END): Increase by one.
302 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
304 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
305 This avoids undefined behavior that might cause the eassert
306 to not catch an out-of-range value.
308 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
310 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
313 2012-05-27 Eli Zaretskii <eliz@gnu.org>
315 * bidi.c (bidi_mirror_char): Fix last change.
317 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
319 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
320 when referring to sectname field in printf format.
322 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
324 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
325 Only r_alloc_inhibit_buffer_relocation needed to be added;
326 the others were already declared.
328 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
329 before checking whether it's out of range. Put the check inside
331 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
333 2012-05-27 Ken Brown <kbrown@cornell.edu>
335 * callproc.c (Fcall_process): Restore a line that was accidentally
336 commented out in the 2011-02-13 change (bug#11547).
338 2012-05-27 Eli Zaretskii <eliz@gnu.org>
340 * lisp.h [REL_ALLOC]: Add prototypes for external functions
343 * buffer.c [REL_ALLOC]: Remove prototypes of
344 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
345 they are now on lisp.h.
347 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
349 * search.c (search_buffer): Use it to inhibit relocation of buffer
350 text while re_search_2 is doing its job, because re_search_2 is
351 passed C pointers to buffer text. (Bug#11519)
353 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
356 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
357 state after an additional call to move_it_in_display_line_to, keep
358 the values of it->max_ascent and it->max_descent found for the
360 (pos_visible_p): Revert the comparison against bottom_y to what it
361 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
364 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
366 Fix coding-related core dumps with gcc -ftrapv.
367 The code was computing A - B, where A and B are pointers, and B is
368 random garbage. This can lead to core dumps on platforms that
369 have special pointer registers, and it also leads to core dumps on
370 x86-64 when compiled with gcc -ftrapv. The fix is to compute
371 A - B only when B is initialized properly.
372 * coding.c (coding_set_source, coding_set_destination): Return void.
373 (coding_change_source, coding_change_destinations): New functions,
374 with the old behaviors of coding_set_source and coding_set_destination.
375 All callers that need an offset changed to use these new functions.
377 2012-05-26 Glenn Morris <rgm@gnu.org>
379 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
381 2012-05-26 Eli Zaretskii <eliz@gnu.org>
383 Extend mouse support on W32 text-mode console.
384 * xdisp.c (draw_row_with_mouse_face):
385 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
387 * w32console.c: Include window.h.
388 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
390 (initialize_w32_display): Initialize mouse-highlight data.
392 * w32inevt.c: Include termchar.h and window.h.
393 (do_mouse_event): Support mouse-autoselect-window. When the mouse
394 moves, call note_mouse_highlight. If help_echo changed, call
395 gen_help_event to produce help-echo message in the echo area.
396 Call clear_mouse_face if mouse_face_hidden is set in the mouse
399 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
401 * lread.c (read1): Simplify slightly to avoid an overflow warning
402 with GCC 4.7.0 on x86-64.
404 2012-05-26 Eli Zaretskii <eliz@gnu.org>
406 * bidi.c (bidi_mirror_char): Revert last change: an int is
407 definitely wide enough here.
409 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
411 Fix integer width and related bugs (Bug#9874).
412 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
413 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
414 (string_bytes, check_sblock, allocate_string_data):
415 (compact_small_strings, Fmake_bool_vector, make_string)
416 (make_unibyte_string, make_multibyte_string)
417 (make_string_from_bytes, make_specified_string)
418 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
419 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
422 (allocate_pseudovector):
423 Use int, not EMACS_INT, where int is wide enough.
424 (inhibit_garbage_collection, Fgarbage_collect):
425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
426 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
427 int might not be wide enough.
428 (bidi_cache_search, bidi_cache_find, bidi_init_it)
429 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
430 (bidi_at_paragraph_end, bidi_find_paragraph_start)
431 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
432 (bidi_level_of_next_char, bidi_move_to_visually_next):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
435 (Fkill_buffer, Fset_buffer_major_mode)
436 (advance_to_char_boundary, Fbuffer_swap_text)
437 (Fset_buffer_multibyte, overlays_at, overlays_in)
438 (overlay_touches_p, struct sortvec, record_overlay_string)
439 (overlay_strings, recenter_overlay_lists)
440 (adjust_overlays_for_insert, adjust_overlays_for_delete)
441 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
442 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
443 (Foverlay_recenter, last_overlay_modification_hooks_used)
444 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
446 (validate_region): Omit unnecessary test for b <= e,
447 since that's guaranteed by the previous test.
448 (adjust_overlays_for_delete): Avoid pos + length overflow.
449 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
450 (report_overlay_modification):
451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
452 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
453 Omit pointer cast, which isn't needed anyway, and doesn't work
454 after the EMACS_INT -> ptrdiff_t change.
455 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
456 * buffer.h: Adjust decls to match defn changes elsewhere.
457 (struct buffer_text, struct buffer):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 Use EMACS_INT, not int, where int might not be wide enough.
460 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
461 not int, to avoid needless 32-bit limit on 64-bit hosts.
462 (exec_byte_code): Use tighter memory-full test, one that checks
463 for alloca overflow. Don't compute the address of the object just
464 before an array, as that's not portable. Use EMACS_INT, not
465 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
466 * callint.c (Fcall_interactively):
467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
468 * callproc.c (call_process_kill, Fcall_process):
469 Don't assume pid_t fits into an Emacs fixnum.
470 (call_process_cleanup, Fcall_process, child_setup):
471 Don't assume pid_t fits into int.
472 (call_process_cleanup, Fcall_process, delete_temp_file)
473 (Fcall_process_region):
474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
475 (Fcall_process): Simplify handling of volatile integers.
476 Use int, not EMACS_INT, where int will do.
477 * casefiddle.c (casify_object, casify_region, operate_on_word)
478 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
480 (casify_object): Avoid integer overflow when overallocating buffer.
481 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
482 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
483 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
484 * category.h (CATEGORYP): Don't assume arg is nonnegative.
485 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
486 integers are now checked earlier. All uses replaced with XINT.
488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
489 For CCL_MapSingle, check that content and value are in int range.
490 (ccl_driver, Fregister_code_conversion_map):
491 Check that Vcode_version_map_vector is a vector.
492 (resolve_symbol_ccl_program): Check that vector header is in range.
493 Always copy the vector, so that we can check its contents reliably
494 now rather than having to recheck each instruction as it's being
495 executed. Check that vector words fit in 'int'.
496 (ccl_get_compiled_code, Fregister_ccl_program)
497 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
498 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
499 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
500 contents are in range.
501 (Fccl_execute_on_string): Check that status is in range.
502 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
503 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
504 Accept and return EMACS_INT, not int, because callers can pass values
506 (c_string_width, strwidth, lisp_string_width, chars_in_text)
507 (multibyte_chars_in_text, parse_str_as_multibyte)
508 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
509 (str_as_unibyte, str_to_unibyte, string_count_byte8)
510 (string_escape_byte8, Fget_byte):
511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
512 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
513 avoid mishandling large integers.
514 * character.h: Adjust decls to match defn changes elsewhere.
515 * charset.c (load_charset_map_from_file, find_charsets_in_text)
516 (Ffind_charset_region):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
519 (load_charset_map_from_vector, Fdefine_charset_internal):
520 Don't assume fixnum fits in int.
521 (load_charset_map_from_vector, Fmap_charset_chars):
522 Remove now-unnecessary CHECK_NATNUMs.
523 (Fdefine_charset_internal): Check ranges here, more carefully.
524 Don't rely on undefined behavior with signed left shift overflow.
525 Don't assume unsigned int fits into fixnum, or that fixnum fits
526 into unsigned int. Don't require max_code to be a valid fixnum;
527 that's not true for gb10830 4-byte on a 32-bit host. Allow
528 invalid_code to be a cons, for the same reason. Require code_offset
529 to be a character. Avoid int overflow if max_char is close
531 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
532 this is intended anyway and avoids some undefined behavior.
533 (load_charset_map): Pass unsigned, not int, as 2nd arg of
534 INDEX_TO_CODE_POINT, as that's what it expects.
535 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
536 * charset.h (DECODE_CHAR): Return int, not unsigned;
537 this is what was intended anyway, and it avoids undefined behavior.
538 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
539 integer-overflow issues.
540 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
541 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
542 where the argument is EMACS_INT, and this behavior is not intended.
543 * chartab.c (Fmake_char_table, Fset_char_table_range)
544 (uniprop_get_decoder, uniprop_get_encoder):
545 Don't assume fixnum fits in int.
546 * cmds.c (move_point): New function, that does the gist of
547 Fforward_char and Fbackward_char, but does so while checking
548 for integer overflow more accurately.
549 (Fforward_char, Fbackward_char): Use it.
550 (Fforward_line, Fend_of_line, internal_self_insert)
551 (internal_self_insert):
552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
553 Fix a FIXME, by checking for integer overflow when calculating
554 target_clm and actual_clm.
555 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
556 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
557 (ASSURE_DESTINATION, coding_alloc_by_realloc)
558 (coding_alloc_by_making_gap, alloc_destination)
559 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
560 (encode_coding_utf_16, detect_coding_emacs_mule)
561 (decode_coding_emacs_mule, encode_coding_emacs_mule)
562 (detect_coding_iso_2022, decode_coding_iso_2022)
563 (encode_invocation_designation, encode_designation_at_bol)
564 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
565 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
566 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
567 (encode_coding_ccl, encode_coding_raw_text)
568 (detect_coding_charset, decode_coding_charset)
569 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
570 (produce_composition, produce_charset, produce_annotation)
571 (decode_coding, handle_composition_annotation)
572 (handle_charset_annotation, consume_chars, decode_coding_gap)
573 (decode_coding_object, encode_coding_object, detect_coding_system)
574 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
575 (code_convert_region, code_convert_string)
576 (Fdefine_coding_system_internal)
577 (coding_set_source, coding_set_destination):
578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
579 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
580 (Fdefine_coding_system_internal):
581 Don't assume fixnums fit in int.
582 (decode_coding_gap, decode_coding_object, encode_coding_object)
583 (Fread_coding_system, Fdetect_coding_region)
584 (Funencodable_char_position, Fcheck_coding_systems_region)
585 (get_translation, handle_composition_annotation, consume_chars):
586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
587 (consume_chars): Rewrite to not calculate an address outside buffer.
588 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
589 Don't access memory outside of the args array.
590 (Fdefine_coding_system_internal): Check for charset-id overflow.
591 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
592 result of ENCODE_CHAR.
593 * coding.h: Adjust decls to match defn changes elsewhere.
594 (struct coding_system):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 * composite.c (get_composition_id, find_composition)
597 (run_composition_function, update_compositions)
598 (compose_text, composition_gstring_put_cache)
599 (composition_gstring_p, composition_gstring_width)
600 (fill_gstring_header, fill_gstring_body, autocmp_chars)
601 (composition_compute_stop_pos, composition_reseat_it)
602 (composition_update_it, struct position_record)
603 (find_automatic_composition, composition_adjust_point)
604 (Fcomposition_get_gstring, Ffind_composition_internal):
605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
606 (update_compositions):
607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
608 * composite.h: Adjust decls to match defn changes elsewhere.
609 (struct composition):
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
612 Do not attempt to compute the address of the object just before a
613 buffer; this is not portable.
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (Faset): Use int, not EMACS_INT, where int is wide enough.
617 (Fstring_to_number): Don't assume fixnums fit in int.
618 (Frem): Don't assume arg is nonnegative.
619 * dbusbind.c (xd_append_arg): Check for integers out of range.
620 (Fdbus_call_method): Don't overflow the timeout int.
621 (extract_signed, extract_unsigned): New functions.
622 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
623 (xd_get_connection_references): Return ptrdiff_t, not int.
625 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
627 Use int, not unsigned, where the dbus API uses int.
628 (Fdbus_message_internal): Don't overflow mtype.
629 (syms_of_dbusbind): Allocate right-sized buffer for integers.
630 * dired.c (directory_files_internal, file_name_completion, scmp)
631 (file_name_completion_stat):
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 (file_name_completion): Don't overflow matchcount.
634 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
635 * dispextern.h: Adjust decls to match defn changes elsewhere.
636 (struct text_pos, struct glyph, struct bidi_saved_info)
637 (struct bidi_string_data, struct bidi_it, struct composition_it)
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (struct display_pos, struct composition_it, struct it):
641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
642 * dispnew.c (increment_matrix_positions)
643 (increment_row_positions, mode_line_string)
644 (marginal_area_string):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 (duration_to_sec_usec): New function, to check for overflow better.
649 (Fsleep_for, sit_for): Use it.
650 * doc.c (get_doc_string, store_function_docstring):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 (get_doc_string, Fsnarf_documentation):
653 Use int, not EMACS_INT, where int is wide enough.
655 Use SAFE_ALLOCA, not alloca.
656 Check for overflow when converting EMACS_INT to off_t.
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
660 Don't assume uid_t fits into fixnum.
661 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
662 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
663 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
664 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
665 (general_insert_function)
666 (Finsert_char, make_buffer_string, make_buffer_string_both)
667 (update_buffer_properties, Fbuffer_substring)
668 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
669 (Fsubst_char_in_region, check_translation)
670 (Ftranslate_region_internal, save_restriction_restore, Fformat)
671 (transpose_markers, Ftranspose_regions):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (clip_to_bounds): Move to lisp.h as an inline function).
674 (Fconstrain_to_field): Don't assume integers are nonnegative.
675 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
676 (Fsubst_char_in_region, Fsave_restriction):
677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
678 (Femacs_pid): Don't assume pid_t fits into fixnum.
679 (lo_time): Use int, not EMACS_INT, when int suffices.
680 (lisp_time_argument): Check for usec out of range.
681 (Fencode_time): Don't assume fixnum fits in int.
682 (Fuser_login_name, Fuser_full_name): Signal an error
683 if a uid argument is out of range, rather than relying on
685 (Fformat_time_string): Remove now-unnecessary check.
686 lisp_time_argument checks for out-of-range usec now.
687 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
688 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
689 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
690 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
691 (init_cmdargs, Fdump_emacs):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
694 the bottom (typically) 32 bits of the fixnum.
695 * eval.c (specpdl_size, call_debugger):
696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
697 (when_entered_debugger, Fbacktrace_debug):
698 Don't assume fixnum can fit in int.
699 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
700 the object just before a buffer; this is not portable.
701 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
702 (grow_specpdl, unbind_to):
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
705 (grow_specpdl): Simplify allocation by using xpalloc.
706 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
707 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
708 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
710 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
713 (Fcopy_file, non_regular_nbytes, read_non_regular)
714 (Finsert_file_contents):
715 Use int, not EMACS_INT, where int is wide enough.
716 (READ_BUF_SIZE): Verify that it fits in int.
717 (Finsert_file_contents): Check that counts are in proper range,
718 rather than assuming fixnums fit into ptrdiff_t etc.
719 Don't assume fixnums fit into int.
720 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
721 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
722 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
723 (string_char_to_byte, string_byte_to_char)
724 (string_make_multibyte, string_to_multibyte)
725 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
726 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
727 (substring_both, Fdelete, internal_equal, Ffillarray)
728 (Fclear_string, mapcar1)
729 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
730 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
731 (larger_vector, make_hash_table, maybe_resize_hash_table)
732 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
733 (Fmaphash, secure_hash):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (concat): Check for string index and length overflow.
736 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
739 (larger_vector): New API (vec, incr_min, size_max) replaces old
740 one (vec, new_size, init). This catches size overflow.
741 INIT was removed because it was always Qnil.
743 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
744 the upper bound on a hash table index size.
745 (make_hash_table, maybe_resize_hash_table): Use it.
746 (secure_hash): Computer start_byte and end_byte only after
747 they're known to be in ptrdiff_t range.
748 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
749 (Ffont_get_glyphs, Ffont_at):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
752 (Flist_fonts, Fopen_font):
753 Don't assume fixnum can fit in int.
754 (check_gstring): Don't assume index can fit in int.
755 (font_match_p): Check that fixnum is a character, not a nonnegative
756 fixnum, since the later code needs to stuff it into an int.
757 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
758 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
759 conversion overflow issues.
760 (Fopen_font): Check for integer out of range.
761 (Ffont_get_glyphs): Don't assume index can fit in int.
762 * font.h: Adjust decls to match defn changes elsewhere.
763 * fontset.c (reorder_font_vector): Redo score calculation to avoid
765 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
766 printmax_t, where ptrdiff_t is wide enough.
767 (Finternal_char_font):
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
770 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
771 (Fset_frame_position, x_set_frame_parameters)
772 (x_set_line_spacing, x_set_border_width)
773 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
774 Check that fixnums are in proper range for system types.
775 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
777 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
778 Use SAFE_ALLOCA_LISP, not alloca.
779 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
780 intptr_t is wide enough.
781 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
782 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
783 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
784 Check for fixnum out of range.
785 * ftfont.c (ftfont_list): Don't assume index fits in int.
786 Check that fixnums are in proper range for system types.
787 (ftfont_shape_by_flt):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
791 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
792 Check that fixnums are in proper range for system types.
793 * gnutls.h: Adjust decls to match defn changes elsewhere.
794 * gtkutil.c (xg_dialog_run):
795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
796 (update_frame_tool_bar):
797 Check that fixnums are in proper range for system types.
798 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
799 (lookup_image): Check that fixnums are in range for system types.
800 * indent.c (last_known_column, last_known_column_point):
801 (current_column_bol_cache):
802 (skip_invisible, current_column, check_display_width):
803 (check_display_width, scan_for_column, current_column_1)
804 (Findent_to, Fcurrent_indentation, position_indentation)
805 (indented_beyond_p, Fmove_to_column, compute_motion):
806 (Fcompute_motion, Fvertical_motion):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (last_known_column_modified): Use EMACS_INT, not int.
809 (check_display_width):
811 Check that fixnums and floats are in proper range for system types.
812 (compute_motion): Don't assume index or fixnum fits in int.
813 (compute_motion, Fcompute_motion):
814 Use int, not EMACS_INT, when it is wide enough.
815 (vmotion): Omit local var start_hpos that is always 0; that way
816 we don't need to worry about overflow in expressions involving it.
817 * indent.h: Adjust decls to match defn changes elsewhere.
819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
820 Use int, not EMACS_INT, where int is wide enough.
821 Remove unused members ovstring_chars_done and tab_offset;
823 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
824 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
825 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
826 (make_gap, copy_text, insert, insert_and_inherit)
827 (insert_before_markers, insert_before_markers_and_inherit)
828 (insert_1, count_combining_before, count_combining_after)
829 (insert_1_both, insert_from_string)
830 (insert_from_string_before_markers, insert_from_string_1)
831 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
832 (adjust_after_replace, adjust_after_insert, replace_range)
833 (replace_range_2, del_range, del_range_1, del_range_byte)
834 (del_range_both, del_range_2, modify_region)
835 (prepare_to_modify_buffer, signal_before_change)
836 (signal_after_change, Fcombine_after_change_execute):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 * intervals.c (traverse_intervals, rotate_right, rotate_left)
839 (balance_an_interval, split_interval_right, split_interval_left)
840 (find_interval, next_interval, update_interval)
841 (adjust_intervals_for_insertion, delete_node, delete_interval)
842 (interval_deletion_adjustment, adjust_intervals_for_deletion)
843 (static_offset_intervals, offset_intervals)
844 (merge_interval_right, merge_interval_left, make_new_interval)
845 (graft_intervals_into_buffer, temp_set_point_both)
846 (temp_set_point, set_point, adjust_for_invis_intang)
847 (set_point_both, move_if_not_intangible, get_property_and_range)
848 (get_local_map, copy_intervals, copy_intervals_to_string)
849 (compare_string_intervals, set_intervals_multibyte_1):
850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
851 * intervals.h: Adjust decls to match defn changes elsewhere.
853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
854 * keyboard.c (this_command_key_count, this_single_command_key_start)
855 (before_command_key_count, before_command_echo_length, echo_now)
856 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
857 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
858 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
859 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
861 (last_non_minibuf_size, last_point_position, echo_truncate)
862 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
863 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
864 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
865 (stuff_buffered_input):
866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
867 (last_auto_save, command_loop_1, read_char):
868 Use EMACS_INT, not int, to avoid integer overflow.
869 (record_char): Avoid overflow in total_keys computation.
870 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
871 * keyboard.h: Adjust decls to match defn changes elsewhere.
872 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
873 (Fkey_description, Fdescribe_vector, Flookup_key):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (click_position): New function, to check that positions are in range.
876 (Fcurrent_active_maps):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 (Faccessible_keymaps, Fkey_description):
880 (preferred_sequence_p):
881 Don't assume fixnum can fit into int.
882 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
883 Check for integer overflow in size calculations.
884 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
885 avoid mishandling large integers.
886 * lisp.h: Adjust decls to match defn changes elsewhere.
887 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
888 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
889 (struct Lisp_Marker):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 (clip_to_bounds): Now an inline function, moved here from editfns.c.
892 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
893 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
895 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
896 Assume the arg has valid form, since it always does.
897 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
898 unsigned integer system type.
899 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
900 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
902 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
903 (duration_to_sec_usec): New decl.
904 * lread.c (read_from_string_index, read_from_string_index_byte)
905 (read_from_string_limit, readchar, unreadchar, openp)
906 (read_internal_start, read1, oblookup):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Fload, readevalloop, Feval_buffer, Feval_region):
909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
910 (openp): Check for out-of-range argument to 'access'.
911 (read1): Use int, not EMACS_INT, where int is wide enough.
912 Don't assume fixnum fits into int.
913 Fix off-by-one error that can read outside a buffer.
914 (read_filtered_event): Use duration_to_sec_usec
915 to do proper overflow checking on durations.
916 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
918 (Fexecute_kbd_macro):
919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
920 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
921 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
922 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
923 (set_marker_both, set_marker_restricted_both, marker_position)
924 (marker_byte_position, Fbuffer_has_markers_at):
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
927 * menu.c (ensure_menu_items): Rename from grow_menu_items.
928 It now merely ensures that the menu is large enough, without
929 necessarily growing it, as this avoids some integer overflow issues.
931 (keymap_panes, parse_single_submenu, Fx_popup_menu):
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
934 Use SAFE_ALLOCA_LISP, not alloca.
935 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
936 to EMACS_INT. Check that fixnums are in proper range for system types.
937 * minibuf.c (minibuf_prompt_width, string_to_object)
938 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
939 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
941 (get_minibuffer, read_minibuf_unwind):
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
943 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
944 this simplifies overflow checking. All callers changed.
945 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
948 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
949 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
950 Check that fixnums are in proper range for system types.
951 (Fx_create_frame, Fx_show_tip):
952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
953 * nsfont.m (ns_findfonts, nsfont_list_family):
954 Don't assume fixnum fits in long.
955 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
957 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
959 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
961 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
962 (PRINTDECLARE, PRINTPREPARE):
963 (strout, print_string):
964 (print, print_preprocess, print_check_string_charset_prop)
966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
968 (temp_output_buffer_setup, Fprin1_to_string, print_object):
969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
970 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
971 (printchar, strout): Use xpalloc to catch size calculation overflow.
972 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
973 (print_error_message): Use SAFE_ALLOCA, not alloca.
974 (print_object): Use int, not EMACS_INT, where int is wide enough.
975 (print_depth, new_backquote_output, print_number_index):
976 Use ptrdiff_t, not int, where int might not be wide enough.
977 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
978 (Fset_process_window_size, Fformat_network_address)
979 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
981 Check that fixnums are in proper range for system types.
982 (Fsignal_process): Simplify by avoiding a goto.
983 Check for process-ids out of pid_t range rather than relying on
985 (process_tick, update_tick): Use EMACS_INT, not int.
986 (Fformat_network_address, read_process_output, send_process)
987 (Fprocess_send_region, status_notify):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
989 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
990 (wait_reading_process_output, read_process_output, exec_sentinel):
991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
992 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
993 (Faccept_process_output): Use duration_to_sec_usec to do proper
994 overflow checking on durations.
995 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
996 Don't assume pid_t fits in int.
997 * process.h (struct Lisp_Process): Members tick and update_tick
998 are now of type EMACS_INT, not int.
999 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1000 configured --with-wide-int.
1001 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1002 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1003 * search.c (looking_at_1, string_match_1):
1004 (fast_string_match, fast_c_string_match_ignore_case)
1005 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1006 (scan_newline, find_before_next_newline, search_command)
1007 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1008 (set_search_regs, wordify):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 (string_match_1, search_buffer, set_search_regs):
1014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1015 (wordify): Check for overflow in size calculation.
1016 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1017 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1018 Check that fixnums are in proper range for system types.
1019 * sound.c (struct sound_device)
1020 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1022 (Fplay_sound_internal):
1023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1024 * syntax.c (struct lisp_parse_state, find_start_modiff)
1025 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1026 (Fparse_partial_sexp):
1027 Don't assume fixnums can fit in int.
1028 (struct lisp_parse_state, find_start_pos, find_start_value)
1029 (find_start_value_byte, find_start_begv)
1030 (update_syntax_table, char_quoted, dec_bytepos)
1031 (find_defun_start, prev_char_comend_first, back_comment):
1032 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1033 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1035 (Finternal_describe_syntax_value): Check that match_lisp is a
1036 character, not an integer, since the code stuffs it into int.
1037 (scan_words, scan_sexps_forward):
1038 Check that fixnums are in proper range for system types.
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1041 (scan_sexps_forward):
1042 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1043 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1044 * syntax.h: Adjust decls to match defn changes elsewhere.
1045 (struct gl_state_s):
1046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1047 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1048 MOST_POSITIVE_FIXNUM.
1049 * sysdep.c (wait_for_termination_1, wait_for_termination)
1050 (interruptible_wait_for_termination, mkdir):
1051 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1052 (emacs_read, emacs_write):
1053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1054 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1055 and double all fit in int.
1056 * term.c (set_tty_color_mode):
1057 Check that fixnums are in proper range for system types.
1058 * termhooks.h (struct input_event):
1059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1060 * textprop.c (validate_interval_range, interval_of)
1061 (Fadd_text_properties, set_text_properties_1)
1062 (Fremove_text_properties, Fremove_list_of_text_properties)
1063 (Ftext_property_any, Ftext_property_not_all)
1064 (copy_text_properties, text_property_list, extend_property_ranges)
1065 (verify_interval_modification):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 (Fnext_single_char_property_change)
1068 (Fprevious_single_char_property_change):
1069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1070 (copy_text_properties):
1071 Check for integer overflow in index calculation.
1072 * undo.c (last_boundary_position, record_point, record_insert)
1073 (record_delete, record_marker_adjustment, record_change)
1074 (record_property_change):
1075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1076 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1078 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1079 (Fx_hide_tip, Fx_file_dialog):
1080 * w32menu.c (set_frame_menubar):
1081 Use ptrdiff_t, not int, for consistency with rest of code.
1082 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1083 (select_window, Fdelete_other_windows_internal)
1084 (window_scroll_pixel_based, window_scroll_line_based)
1085 (Frecenter, Fset_window_configuration):
1086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1087 (Fset_window_hscroll, run_window_configuration_change_hook)
1088 (set_window_buffer, temp_output_buffer_show, scroll_command)
1089 (Fscroll_other_window, Frecenter):
1090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1091 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1092 Don't assume fixnum fits in int.
1093 (Fset_window_scroll_bars):
1094 Check that fixnums are in proper range for system types.
1095 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1096 (string_pos, c_string_pos, number_of_chars, init_iterator)
1097 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1098 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1099 (compute_display_string_end, handle_face_prop)
1100 (face_before_or_after_it_pos, handle_invisible_prop)
1101 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1102 (display_prop_intangible_p, string_buffer_position_lim)
1103 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1104 (get_overlay_strings_1, get_overlay_strings)
1105 (iterate_out_of_display_property, forward_to_next_line_start)
1106 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1107 (get_next_display_element, set_iterator_to_next)
1108 (get_visually_first_element, compute_stop_pos_backwards)
1109 (handle_stop_backwards, next_element_from_buffer)
1110 (move_it_in_display_line_to, move_it_in_display_line)
1111 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1112 (add_to_log, message_dolog, message_log_check_duplicate)
1113 (message2, message2_nolog, message3, message3_nolog
1114 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1115 (current_message_1, truncate_echo_area, truncate_message_1)
1116 (set_message, set_message_1, store_mode_line_noprop)
1117 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1118 (text_outside_line_unchanged_p, check_point_in_composition)
1119 (reconsider_clip_changes)
1120 (redisplay_internal, set_cursor_from_row, try_scrolling)
1121 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1122 (redisplay_window, find_last_unchanged_at_beg_row)
1123 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1124 (trailing_whitespace_p, find_row_edges, display_line)
1125 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1126 (display_mode_element, store_mode_line_string)
1127 (pint2str, pint2hrstr, decode_mode_spec)
1128 (display_count_lines, display_string, draw_glyphs)
1129 (x_produce_glyphs, x_insert_glyphs)
1130 (rows_from_pos_range, mouse_face_from_buffer_pos)
1131 (fast_find_string_pos, mouse_face_from_string_pos)
1132 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 (safe_call, init_from_display_pos, handle_fontified_prop)
1135 (handle_single_display_spec, load_overlay_strings)
1136 (with_echo_area_buffer, setup_echo_area_for_printing)
1137 (display_echo_area, echo_area_display)
1138 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1139 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1140 (redisplay_window, dump_glyph_row, display_mode_line)
1141 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1142 (handle_display_spec, display_prop_string_p):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 (handle_single_display_spec, build_desired_tool_bar_string)
1145 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1146 (get_specified_cursor_type):
1147 Check that fixnums are in proper range for system types.
1148 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1149 (Flookup_image_map):
1150 Don't assume fixnums fit in int.
1151 (compare_overlay_entries):
1152 Avoid mishandling comparisons due to subtraction overflow.
1153 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1154 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1155 (handle_tool_bar_click):
1156 Use int, not unsigned, since we prefer signed and the signedness
1157 doesn't matter here.
1158 (get_next_display_element, next_element_from_display_vector):
1159 Use int, not EMACS_INT, when int is wide enough.
1160 (start_hourglass): Use duration_to_sec_usec to do proper
1161 overflow checking on durations.
1162 * xfaces.c (Fbitmap_spec_p):
1163 Check that fixnums are in proper range for system types.
1164 (compare_fonts_by_sort_order):
1165 Avoid mishandling comparisons due to subtraction overflow.
1166 (Fx_family_fonts, realize_basic_faces):
1167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 Don't assume fixnum fits in int.
1170 Use SAFE_ALLOCA_LISP, not alloca.
1171 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1172 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1173 (face_at_buffer_position, face_for_overlay_string)
1174 (face_at_string_position):
1175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1176 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1177 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1179 Check that fixnums are in proper range for system types.
1180 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1181 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1183 (Fx_change_window_property): Don't assume fixnums fit in int.
1184 * xfont.c (xfont_chars_supported):
1185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1186 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1187 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1189 * xml.c (parse_region):
1190 * xrdb.c (magic_file_p):
1191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1192 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1193 (x_get_local_selection, x_reply_selection_request)
1194 (x_handle_selection_request, wait_for_property_change):
1195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1196 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1197 short is wide enough.
1198 (x_send_client_event): Don't assume fixnum fits in int.
1199 * xterm.c (x_x_to_emacs_modifiers):
1200 Don't assume EMACS_INT overflows nicely into int.
1201 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1203 (handle_one_xevent): NATNUMP can eval its arg twice.
1204 (x_connection_closed):
1205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1206 * xterm.h: Adjust decls to match defn changes elsewhere.
1207 (struct scroll_bar): Use struct vectorlike_header
1208 rather than rolling our own approximation.
1209 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1211 2012-05-25 Glenn Morris <rgm@gnu.org>
1213 * lisp.mk (lisp): Update for more files being compiled now.
1215 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1217 * lread.c: Remove `read_pure' which makes no difference.
1218 (read_pure): Remove var.
1219 (unreadpure): Remove function.
1220 (readevalloop): Don't call read_list with -1 flag.
1221 (read1, read_vector): Don't test read_pure any more.
1222 (read_list): Simplify.
1224 * fileio.c, character.h: Minor style tweaks.
1226 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1228 * window.h (clip_changed): Remove useless declaration.
1230 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1232 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1233 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1235 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1238 This directory predates autoconf and is no longer needed nowadays.
1239 Move its few remaining bits of functionality to where they're needed.
1240 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1241 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1242 * m/template.h: Remove.
1243 * Makefile.in (M_FILE): Remove. All uses removed.
1244 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1245 * lisp.h (USE_LSB_TAG):
1246 * mem-limits.h (EXCEEDS_LISP_PTR):
1247 Use VAL_MAX, not VALBITS, in #if.
1248 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1249 (EMACS_UINT): Define unconditionally now.
1250 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1251 (BITS_PER_EMACS_INT): New constants, replacing
1252 what used to be in config.h, but not useful in #if.
1253 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1254 define them any more.
1255 (VAL_MAX): New macro.
1257 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1258 BITS_PER_EMACS_INT, in #if.
1259 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1260 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1261 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1262 * s/ms-w32.h (DATA_START):
1263 Move here from removed file m/intel386.h.
1264 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1265 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1267 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1269 Assume C89 or later.
1270 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1271 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1273 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1274 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1275 * textprop.c, tparam.c (NULL): Remove.
1276 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1277 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1278 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1279 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1280 * xterm.c (input_signal_count): Assume volatile works.
1282 2012-05-21 Ken Brown <kbrown@cornell.edu>
1284 * xgselect.c (xg_select): Fix first argument in call to 'select'
1287 2012-05-20 Ken Brown <kbrown@cornell.edu>
1289 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1290 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1292 2012-05-19 Ken Brown <kbrown@cornell.edu>
1294 * xfns.c (x_in_use): Remove `static' qualifier.
1295 * xterm.h (x_in_use): Declare.
1296 * xgselect.c: Include xterm.h.
1297 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1298 and `display_arg' (bug#9754).
1300 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1302 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1304 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1305 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1307 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1309 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1311 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1312 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1314 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1315 reference to image_cache->refcount.
1316 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1318 2012-05-17 Juri Linkov <juri@jurta.org>
1320 * search.c (Fword_search_regexp, Fword_search_backward)
1321 (Fword_search_forward, Fword_search_backward_lax)
1322 (Fword_search_forward_lax): Move functions to isearch.el
1323 (bug#10145, bug#11381).
1325 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1327 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1329 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1331 * lread.c (init_obarray): Declare Qt and Qnil as special.
1333 2012-05-14 Glenn Morris <rgm@gnu.org>
1335 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1336 Put "libexec" before "bin", for the sake of init_callproc_1.
1338 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1340 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1342 * unexaix.c: Port to more-recent AIX compilers.
1343 (report_error, report_error_1, make_hdr, copy_sym)
1344 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1345 Make arguments const char *, not char *, to avoid violations of C
1346 standard and to fix some AIX warnings reported by Gilles Pion.
1348 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1350 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1351 already have overlays loaded.
1352 (handle_single_display_spec): Before returning without displaying
1353 fringe bitmap, synchronize the bidi iterator with the main display
1354 iterator, by calling iterate_out_of_display_property.
1355 (iterate_out_of_display_property): Detect buffer iteration by
1356 testing that it->string is a Lisp string.
1357 (get_next_display_element): When the current object is exhausted,
1358 and there's something on it->stack, call set_iterator_to_next to
1359 proceed with what's on the stack, instead of returning zero.
1360 (set_iterator_to_next): If called at the end of a Lisp string,
1361 proceed to consider_string_end without incrementing string
1362 position. Don't increment display vector index past the end of
1363 the display vector. (Bug#11417)
1364 (pos_visible_p): Don't report a position visible when move_it_to
1365 stopped at the last line of window, which happens to be scanned
1366 backwards by the bidi iteration. (Bug#11464)
1368 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1370 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1371 and right-margin display specs even if the spec is invalid or we
1372 are on a TTY, and thus unable to display on the fringes.
1373 That's because the text with the property will not be displayed anyway,
1374 so we need to signal to the caller that this is a "replacing"
1375 display spec. This fixes display when the spec is invalid or we
1378 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1380 * unexaix.c (make_hdr): Fix typo in prototype.
1381 This bug broke the build on AIX. Problem reported by Gilles Pion.
1383 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1385 * keyboard.c (kbd_buffer_get_event): Read special events also in
1386 batch mode. (Bug#11415)
1388 2012-05-12 Glenn Morris <rgm@gnu.org>
1390 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1392 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1394 * lisp.mk (lisp): Add newcomment.elc.
1396 2012-05-12 Glenn Morris <rgm@gnu.org>
1398 * Makefile.in (MKDIR_P): New, set by configure.
1399 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1401 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1403 Remove unused function hourglass_started.
1404 * dispextern.h (hourglass_started):
1405 * w32fns.c (hourglass_started):
1406 * xdisp.c (hourglass_started): Remove.
1408 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1410 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1411 Update dependencies.
1413 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1415 * xgselect.c (xg_select): Put maxfds+1 into a var.
1416 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1418 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1420 2012-05-10 Dave Abrahams <dave@boostpro.com>
1422 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1423 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1425 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1427 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1428 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1429 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1430 Initialize xd_registered_buses.
1432 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1434 Untag more efficiently if USE_LSB_TAG.
1435 This is based on a proposal by YAMAMOTO Mitsuharu in
1436 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1437 For an admittedly artificial (nth 8000 longlist) benchmark on
1438 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1439 Emacs's overall text size by 1%.
1440 * lisp.h (XUNTAG): New macro.
1441 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1442 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1443 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1444 * eval.c (Fautoload):
1445 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1446 * frame.h (XFRAME): Use XUNTAG.
1448 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1449 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1450 Remove unportable assumptions about print widths of types like
1452 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1453 intptr_t when converting between pointer and integer, to avoid GCC
1454 warnings about wrong width.
1456 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1458 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1459 stack for each reader_thread, instead of defaulting to 8MB
1460 determined by the linker. This avoids failures in creating
1461 subprocesses on Windows 7, see the discussion in this thread:
1462 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1464 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1466 Fix up display of the *Minibuf-0* buffer in the mini window.
1467 * keyboard.c (read_char): Don't clear the echo area if there's no
1469 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1470 contents of *Minibuf-0*) if there's no message displayed in its stead.
1472 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1474 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1477 2012-05-06 Chong Yidong <cyd@gnu.org>
1479 * lisp.mk (lisp): Update.
1481 2012-05-05 Jim Meyering <meyering@redhat.com>
1483 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1485 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1487 * data.c (PUT_ERROR): New macro.
1488 (syms_of_data): Use it. Add new error type `user-error'.
1489 * undo.c (user_error): New function.
1490 (Fprimitive_undo): Use it.
1491 * print.c (print_error_message): Adjust print style for `user-error'.
1492 * keyboard.c (user_error): New function.
1493 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1495 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1497 Do not limit current-time-string to years 1000..9999.
1498 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1499 (Fcurrent_time_string): Support any year that is supported by the
1500 underlying localtime representation. Don't use asctime, as it
1501 has undefined behavior for years outside the range -999..9999.
1503 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1505 Fix race conditions involving setenv, gmtime, localtime, asctime.
1506 Without this fix, interrupts could mess up code that uses these
1507 nonreentrant functions, since setting TZ invalidates existing
1508 tm_zone or tzname values, and since most of these functions return
1509 pointers to static storage.
1510 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1511 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1512 Grow the critical sections to include not just invoking
1513 localtime/gmtime, but also accessing these functions' results
1514 including their tm_zone values if any, and any related TZ setting.
1515 (format_time_string): Last arg is now struct tm *, not struct tm **,
1516 so that the struct tm is saved in the critical section.
1517 All callers changed. Simplify allocation of initial buffer, partly
1518 motivated by the fact that memory allocation needs to be outside
1519 the critical section.
1521 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1523 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1524 with RESET_INTERVAL.
1526 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1527 Remove duplicated buffer name initialization.
1529 2012-05-02 Jim Meyering <jim@meyering.net>
1531 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1533 * xfns.c (x_window): Use xstrdup (Bug#11375).
1535 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1537 * xdisp.c (pos_visible_p): If already at a newline from the
1538 display string before the 'while' loop, don't walk back the glyphs
1539 from it3.glyph_row. Solves assertion violation when the display
1540 string begins with a newline (egg.el). (Bug#11367)
1542 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1544 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1547 2012-05-01 Glenn Morris <rgm@gnu.org>
1549 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1550 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1551 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1552 All were removed before 23.1.
1554 * dispnew.c: Remove HAVE_LIBNCURSES test;
1555 it is always true on relevant platforms.
1557 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1558 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1560 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1562 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1564 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1565 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1568 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1570 Do not avoid creating empty evaporating overlays (Bug#9642).
1571 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1572 That is, do not delete an evaporating overlay if it becomes
1573 empty after its bounds are adjusted to fit within its buffer.
1574 This fix caused other problems, and I'm reverting it until we get
1575 to the bottom of them.
1577 2012-04-27 Chong Yidong <cyd@gnu.org>
1579 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1581 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1583 * xdisp.c (pos_visible_p): If the window start position is beyond
1584 ZV, start the display from buffer beginning. Prevents assertion
1585 violation in init_iterator when the minibuffer window is scrolled
1588 * window.c (window_scroll_pixel_based): Likewise.
1590 2012-04-27 Chong Yidong <cyd@gnu.org>
1592 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1594 2012-04-27 Glenn Morris <rgm@gnu.org>
1596 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1597 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1599 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1601 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1602 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1604 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1606 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1607 display element, check also the underlying string or buffer
1608 character. (Bug#11341)
1610 * w32menu.c: Include w32heap.h.
1611 (add_menu_item): If the call to AppendMenuW (via
1612 unicode_append_menu) fails, disable Unicode menus only if we are
1613 running on Windows 9X/Me.
1615 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1617 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1618 (xgetint): Add missing shift for LSB tags.
1620 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1622 * keyboard.c (read_char): Don't wipe echo area for select window
1623 events: These might get delayed via `mouse-autoselect-window'
1626 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1628 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1629 manipulation of :loaded-from data.
1631 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1633 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1634 now a cons (bug#11311).
1636 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1638 Do not create empty overlays with the evaporate property (Bug#9642).
1639 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1640 if it becomes empty after its bounds are adjusted to fit within
1641 its buffer. Without this fix, in a nonempty buffer (let ((o
1642 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1643 yields an empty overlay that has the evaporate property, which is
1644 not supposed to happen.
1646 Fix minor GTK3 problems found by static checking.
1647 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1648 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1649 (struct _EmacsFixedClass, emacs_fixed_get_type):
1650 Move decls here from emacsgtkfixed.h, since they needn't be public.
1651 (emacs_fixed_get_type): Now static.
1652 (emacs_fixed_class_init): Omit unused local.
1653 (emacs_fixed_child_type): Remove; unused.
1654 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1655 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1656 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1657 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1658 (EMACS_FIXED_GET_CLASS): Remove; unused.
1659 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1661 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1662 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1664 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1666 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1667 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1668 (__malloc_size_t, __malloc_ptrdiff_t):
1669 Remove. All uses removed, replaced by the definiens if needed,
1670 since we can assume C89 or better now.
1671 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1672 (protect_malloc_state, align, get_contiguous_space)
1673 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1674 (malloc_atfork_handler_child, malloc_enable_thread)
1675 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1676 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1677 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1678 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1679 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1680 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1681 Define using prototypes, not old style.
1682 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1683 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1684 (align): Don't assume that signed integer overflow wraps around.
1685 Omit unused local var.
1686 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1687 (_free_internal_nolock, memalign, mallochook, reallochook):
1688 Omit no-longer-needed casts.
1689 (valloc): Use getpagesize, not __getpagesize.
1690 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1691 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1693 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1695 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1697 Move functions from C to Lisp. Make non-blocking method calls
1698 the default. Implement further D-Bus standard interfaces.
1700 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1701 (QCdbus_request_name_allow_replacement)
1702 (QCdbus_request_name_replace_existing)
1703 (QCdbus_request_name_do_not_queue)
1704 (QCdbus_request_name_reply_primary_owner)
1705 (QCdbus_request_name_reply_in_queue)
1706 (QCdbus_request_name_reply_exists)
1707 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1708 (QCdbus_registered_serial, QCdbus_registered_method)
1709 (QCdbus_registered_signal): New Lisp objects.
1710 (XD_DEBUG_MESSAGE): Use sizeof.
1711 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1712 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1713 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1714 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1715 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1716 (xd_signature, xd_append_arg): Allow float for integer types.
1717 (xd_get_connection_references): New function.
1718 (xd_get_connection_address): Rename from xd_initialize.
1719 Return cached address.
1720 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1721 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1723 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1724 Return number of refcounts.
1725 (Fdbus_get_unique_name): Make stronger parameter check.
1726 (Fdbus_message_internal): New defun.
1727 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1728 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1729 (Fdbus_send_signal, Fdbus_register_service)
1730 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1731 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1732 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1733 (Vdbus_compiled_version, Vdbus_runtime_version)
1734 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1735 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1736 (Vdbus_message_type_signal): New defvars.
1737 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1740 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1742 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1743 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1744 Do not assume ptrdiff_t is the same width as 'int'.
1746 * alloc.c: Handle unusual debugging option combinations.
1747 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1748 since the two debugging options are incompatible.
1749 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1751 (mem_init, mem_insert, mem_insert_fixup):
1752 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1753 (NEED_MEM_INSERT): Remove; no longer needed.
1755 2012-04-22 Leo Liu <sdl.web@gmail.com>
1757 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1759 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1761 * sysdep.c [__FreeBSD__]: Minor cleanups.
1762 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1763 Use Emacs indenting style more consistently. Avoid some casts.
1764 Use 'double' consistently rather than mixing 'float' and 'double'.
1766 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1768 * sysdep.c (list_system_processes, system_process_attributes):
1769 Add implementation for FreeBSD (Bug#5243).
1771 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1773 * lisp.mk (lisp): Update.
1775 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1777 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1778 It is never used otherwise.
1780 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1782 * print.c (print_preprocess): Only check print_depth if print-circle
1784 (print_object): Check for cycles even when print-circle is nil and
1785 print-gensym is t, but only check print_depth if print-circle is nil.
1787 2012-04-20 Chong Yidong <cyd@gnu.org>
1789 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1790 set the status to "failed" and ensure that sentinel is run.
1792 2012-04-20 Glenn Morris <rgm@gnu.org>
1794 * process.c (Fset_process_inherit_coding_system_flag)
1795 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1796 (Fmake_network_process, Fmake_serial_process): Doc fix.
1798 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1800 * xdisp.c (string_buffer_position_lim): Limit starting position to
1802 (set_cursor_from_row): If called for a mode-line or header-line
1803 row, return zero immediately.
1804 (try_cursor_movement): If inside continuation line, don't back up
1805 farther than the first row after the header line, if any.
1806 Don't consider the header-line row as "partially visible", even if
1807 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1809 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1811 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1814 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1815 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1817 configure: new option --enable-gcc-warnings (Bug#11207)
1818 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1819 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1820 (ALL_CFLAGS): Use new macros rather than old.
1821 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1822 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1823 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1824 -Wunused-result, -Wunused-variable. This should go away once
1825 the Emacs and Gnulib regex code is merged.
1826 (xmalloc, xrealloc): Now static.
1828 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1830 * dired.c (Fsystem_groups): Remove unused local.
1832 2012-04-17 Glenn Morris <rgm@gnu.org>
1834 * dired.c (Fsystem_users): Doc fix.
1836 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1838 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1839 (syms_of_dired): Add them.
1841 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1843 Fix minor alloc.c problems found by static checking.
1844 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1845 New extern decls, to avoid calling undeclared functions.
1846 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1847 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1848 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1849 (NEED_MEM_INSERT): New macro.
1850 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1851 Remove one incorrect comment and fix another.
1853 Fix minor ralloc.c problems found by static checking.
1854 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1855 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1856 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1857 (r_alloc_sbrk): Now static.
1859 Improve ralloc.c interface checking.
1860 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1861 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1862 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1863 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1864 [REL_ALLOC]: ... to here, to check interface.
1865 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1866 Remove decls. This fixes an "It stinks!".
1868 * alloc.c (which_symbols): Fix alignment issue / type clash.
1870 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1872 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1873 (struct Lisp_Misc_Any): Likewise.
1874 (struct Lisp_Free): Likewise.
1875 * alloc.c (union aligned_Lisp_Symbol): Define.
1876 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1877 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1878 (union aligned_Lisp_Misc): Define.
1879 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1880 aligned_Lisp_Misc instead of union Lisp_Misc.
1881 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1883 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1885 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1886 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1887 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1888 * s/netbsd.h, s/sol2-6.h:
1889 Remove definition of GC_MARK_STACK, since the default now works.
1890 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1891 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1892 no longer the default.
1893 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1895 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1897 * lread.c (lisp_file_lexically_bound_p):
1898 Fix hang at ";-*-\n" (bug#11238).
1900 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1902 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1903 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1905 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1907 * nsterm.m (constrainFrameRect): Always constrain when there is only
1908 one screen (Bug#10962).
1910 2012-04-13 Ken Brown <kbrown@cornell.edu>
1912 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1914 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1916 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1918 2012-04-11 Daniel Colascione <dancol@dancol.org>
1920 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1921 against is gone. It's better to use vfork now so that when Cygwin
1922 gains a new, working vfork, we use it automatically (bug#10398).
1924 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1926 * window.c (save_window_save): Obey window-point-insertion-type.
1928 2012-04-11 Glenn Morris <rgm@gnu.org>
1930 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1932 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1934 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1936 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1938 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1939 (force_quit_count): New var.
1940 (handle_interrupt): Use it.
1942 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1944 * w32.c (w32_delayed_load): Record the full path of the library
1945 being loaded (bug#10424).
1947 2012-04-09 Glenn Morris <rgm@gnu.org>
1949 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1950 not just in the obarray, before snarfing them. (Bug#11036)
1952 * Makefile.in ($(leimdir)/leim-list.el):
1953 Pass EMACS rather than BUILT_EMACS.
1955 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1957 * process.c (make_process):
1958 * process.h: Add integer `gnutls_handshakes_tried' member to
1961 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1962 Add convenience `GNUTLS_LOG2i' macro.
1964 * gnutls.c (gnutls_log_function2i): Convenience log function.
1965 (emacs_gnutls_read): Use new log functions,
1966 `gnutls_handshakes_tried' process member, and
1967 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1968 attempts per process (connection).
1970 2012-04-09 Chong Yidong <cyd@gnu.org>
1972 * eval.c (Fuser_variable_p, user_variable_p_eh)
1973 (lisp_indirect_variable): Functions deleted.
1974 (Fdefvar): Caller changed.
1976 * callint.c (Finteractive, Fcall_interactively):
1977 * minibuf.c (Fread_variable): Callers changed.
1979 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (set_cursor_from_row): If the display string appears in
1982 the buffer at position that is closer to point than the position
1983 after the display string, display the cursor on the first glyph of
1984 the display string. Fixes cursor display when a 'display' text
1985 property immediately follows invisible text. (Bug#11094)
1987 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1989 composite.c: use 'double' consistently
1990 * composite.c (get_composition_id): Use 'double' consistently
1991 instead of converting 'float' to 'double' and vice versa; this is
1992 easier to understand and avoids a GCC warning.
1994 2012-04-09 Glenn Morris <rgm@gnu.org>
1996 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1997 preparation for dumping it with emacs. (Bug#4789)
1998 (leimdir): New variable.
1999 ($(leimdir)/leim-list.el): New rule.
2000 (emacs$(EXEEXT)): Depend on leim-list.el.
2002 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2003 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2004 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2006 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2008 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2011 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2013 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2014 Remove unused local variable.
2016 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2018 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2019 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2020 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2021 objects, as mark_maybe_pointer will catch them otherwise.
2022 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2023 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2025 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2027 Fix typo that broke non-Windows builds.
2028 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2030 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2032 Support building on MS-Windows with libxml2.
2034 * makefile.w32-in (OBJ2): Add xml.$(O).
2035 (GLOBAL_SOURCES): Add xml.c.
2036 ($(BLD)/xml.$(O)): New dependency list.
2038 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2039 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2040 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2041 [!WINDOWSNT]: New macros.
2042 (init_libxml2_functions, libxml2_loaded_p): New functions.
2043 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2044 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2045 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2046 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2048 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2049 Call init_libxml2_functions before calling libxml2 functions.
2050 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2052 * emacs.c: Don't include libxml/parser.h.
2053 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2054 xmlCleanupParser directly.
2056 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2058 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2060 * indent.c (Fvertical_motion): If there is a display string at
2061 point, use it.vpos to compute how many lines to backtrack after
2062 move_it_to point. (Bug#11133)
2064 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2066 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2067 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2068 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2069 macros related to unification of CJK characters. For the details,
2070 see the discussion following the message here:
2071 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2073 2012-04-04 Chong Yidong <cyd@gnu.org>
2075 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2077 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2079 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2080 instead of alloca. (Bug#11138)
2082 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2084 * w32menu.c (is_simple_dialog): Properly check lisp types.
2087 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2089 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2090 position we get to after a call to move_it_to fails the
2091 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2092 only if we wind up in a string from display property. (Bug#11063)
2094 * window.c (Fdelete_other_windows_internal): Invalidate the row
2095 and column information about mouse highlight, so that redisplay
2096 restores it after reallocating the glyph matrices. (Bug#7464)
2098 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2099 string comes from a `display' text property, use the buffer
2100 position of that property as if we actually saw that position in
2102 (move_it_by_lines): Remove the assertion that
2103 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2104 violated when there's a before-string at the beginning of a line.
2107 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2109 * xdisp.c (append_space_for_newline): If the default face was
2110 remapped, use the remapped face for the appended newline.
2111 (extend_face_to_end_of_line): Use the remapped default face for
2112 extending the face to the end of the line.
2113 (display_line): Call extend_face_to_end_of_line when the default
2114 face was remapped. (Bug#11068)
2116 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2118 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2120 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2122 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2124 2012-03-27 Glenn Morris <rgm@gnu.org>
2126 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2129 2012-03-26 Kenichi Handa <handa@m17n.org>
2131 * dispextern.h (struct glyph): Fix previous change. Change the
2132 bit length of glyphless.ch to 25 (Bug#11082).
2134 2012-03-26 Chong Yidong <cyd@gnu.org>
2136 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2137 (command_loop_1): Use it; inhibit selection update for
2138 handle-select-window too (Bug#8996).
2140 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2142 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2144 2012-03-25 Kenichi Handa <handa@m17n.org>
2146 * dispextern.h (struct glyph): Change the bit length of
2147 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2149 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2151 * s/ms-w32.h (tzname): Include time.h before redirecting to
2152 _tzname. Fixes the MSVC build. (Bug#9960)
2154 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2156 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2159 * xterm.c (XTread_socket): Only modify handling_signal if
2160 !SYNC_INPUT. (Bug#11080)
2162 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2164 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2165 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2166 when fetching a multibyte character consumes more bytes than
2167 CHAR_BYTES returns, due to unification of CJK characters in
2168 string_char. (Bug#11073)
2170 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2172 * process.c (wait_reading_process_output): Handle pty disconnect
2173 by refraining from sending oneself a SIGCHLD (bug#10933).
2175 2012-03-22 Chong Yidong <cyd@gnu.org>
2177 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2179 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2180 Mark string as coming from a prefix property.
2181 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2182 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2184 2012-03-21 Chong Yidong <cyd@gnu.org>
2186 * xfaces.c (Vface_remapping_alist): Doc fix.
2188 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2190 * w32proc.c (Fw32_set_console_codepage)
2191 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2194 2012-03-20 Chong Yidong <cyd@gnu.org>
2196 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2197 to reflect default non-nil value of redisplay-dont-pause.
2199 2012-03-19 Kenichi Handa <handa@m17n.org>
2201 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2202 it fit in a valid range (Bug#11003).
2204 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2206 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2207 that is not from display property, accept the row as a "cursor
2208 row" if one of the string's character has a non-nil `cursor'
2209 property. Fixes cursor positioning when there are newlines in
2210 overlay strings, e.g. in icomplete.el. (Bug#11035)
2212 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2214 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2216 2012-03-12 Chong Yidong <cyd@gnu.org>
2218 * eval.c (inhibit_lisp_code): Rename from
2219 inhibit_window_configuration_change_hook; move from window.c.
2221 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2222 * window.c (run_window_configuration_change_hook)
2223 (syms_of_window): Callers changed.
2225 2012-03-11 Chong Yidong <cyd@gnu.org>
2227 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2229 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2231 2012-03-10 Chong Yidong <cyd@gnu.org>
2233 * frame.c (other_visible_frames): Don't assume the selected frame
2234 is visible (Bug#10955).
2236 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2238 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2240 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2242 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2243 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2246 2012-03-03 Glenn Morris <rgm@gnu.org>
2248 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2250 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2252 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2253 position past the first glyph_row that ends at ZV. (Bug#10902)
2254 (redisplay_window, next_element_from_string): Fix typos in
2256 (redisplay_window): Pass to move_it_vertically the margin in
2257 pixels, not in screen lines.
2259 2012-03-02 Glenn Morris <rgm@gnu.org>
2261 * buffer.c (buffer-list-update-hook): Doc fix.
2263 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2266 push_it before setting up the iterator for the first overlay
2267 string, even if we have an empty string loaded.
2268 (next_overlay_string): If there's an empty string on the iterator
2269 stack, pop the stack. (Bug#10903)
2271 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2273 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2274 Suggested by Stefan Monnier in
2275 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2276 * alloc.c (widen_to_Lisp_Object): New static function.
2277 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2278 and widening them to Lisp_Objects. This would work even if
2279 USE_LSB_TAG is defined and wide integers are used, which might
2280 happen in a future version of Emacs.
2282 2012-02-25 Chong Yidong <cyd@gnu.org>
2284 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2287 * xselect.c (Fx_selection_exists_p): Doc fix.
2288 (x_clipboard_manager_save_all): Print an informative message
2289 before saving to clipboard manager.
2291 2012-02-24 Chong Yidong <cyd@gnu.org>
2293 * keyboard.c (process_special_events): Handle all X selection
2294 requests in kbd_buffer, not just the next one (Bug#8869).
2296 2012-02-23 Chong Yidong <cyd@gnu.org>
2298 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2299 call when setting menu-bar-lines and tool-bar-lines parameters.
2300 (unwind_create_frame_1): New helper function.
2302 * window.c (inhibit_window_configuration_change_hook): New var.
2303 (run_window_configuration_change_hook): Obey it.
2304 (syms_of_window): Initialize it.
2306 2012-02-22 Chong Yidong <cyd@gnu.org>
2308 * xterm.c (x_draw_image_relief): Add missing type check for
2309 Vtool_bar_button_margin (Bug#10743).
2311 2012-02-21 Chong Yidong <cyd@gnu.org>
2313 * fileio.c (Vfile_name_handler_alist): Doc fix.
2315 * buffer.c (Fget_file_buffer): Protect against invalid file
2316 handler return value.
2318 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2320 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2321 when computing $valmask.
2323 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2324 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2325 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2326 It's useless in that case, and it can cause problems on hosts
2327 that allocate halves of EMACS_INT values separately.
2328 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2329 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2330 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2331 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2332 it avoids undefined behavior on hosts where shifting right by more
2333 than the word width has undefined behavior.
2335 2012-02-19 Chong Yidong <cyd@gnu.org>
2337 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2338 (Funhandled_file_name_directory, Ffile_name_as_directory)
2339 (Fdirectory_file_name, Fexpand_file_name)
2340 (Fsubstitute_in_file_name): Protect against invalid file handler
2341 return values (Bug#10845).
2343 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2345 * .gdbinit (pitx): Fix incorrect references to fields of the
2348 2012-02-17 Chong Yidong <cyd@gnu.org>
2350 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2352 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2354 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2355 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2357 2012-02-15 Chong Yidong <cyd@gnu.org>
2359 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2360 marked as special. Also, starting docstrings with * is obsolete.
2362 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2364 * gnutls.c (emacs_gnutls_write): Fix last change.
2366 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2368 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2371 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2373 * keymap.c (Fsingle_key_description): Handle char ranges.
2375 2012-02-12 Chong Yidong <cyd@gnu.org>
2377 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2378 as that creates a dangerous corner case.
2380 * window.c (Fdelete_window_internal): Invalidate the mouse
2381 highlight (Bug#9904).
2383 2012-02-12 Glenn Morris <rgm@gnu.org>
2385 * xselect.c (Fx_own_selection_internal)
2386 (Fx_get_selection_internal, Fx_disown_selection_internal)
2387 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2388 * nsselect.m (Fx_own_selection_internal)
2389 (Fx_disown_selection_internal, Fx_selection_exists_p)
2390 (Fx_selection_owner_p, Fx_get_selection_internal):
2391 Sync docs and argument specs with the xselect.c versions.
2393 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2395 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2397 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2399 * w32select.c (Fx_selection_exists_p): Sync doc string and
2400 argument list with xselect.c. (Bug#10783)
2402 * w16select.c (Fx_selection_exists_p): Sync doc string and
2403 argument list with xselect.c. (Bug#10783)
2405 2012-02-10 Glenn Morris <rgm@gnu.org>
2407 * fns.c (Fsecure_hash): Doc fix.
2409 2012-02-09 Kenichi Handa <handa@m17n.org>
2411 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2413 2012-02-07 Chong Yidong <cyd@gnu.org>
2415 * buffer.c (Fbuffer_local_variables)
2416 (buffer_lisp_local_variables): Handle unbound vars correctly;
2417 don't let Qunbound leak into Lisp.
2419 2012-02-07 Glenn Morris <rgm@gnu.org>
2421 * image.c (Fimagemagick_types): Doc fix.
2423 * image.c (imagemagick-render-type): Change it from a lisp object
2424 to an integer. Move the doc here from the lisp manual.
2425 Treat all values not equal to 0 the same.
2427 2012-02-06 Chong Yidong <cyd@gnu.org>
2429 * doc.c (store_function_docstring): Avoid applying docstring of
2430 alias to base function (Bug#2603).
2432 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2434 * .gdbinit (pp1, pv1): Remove redundant defines.
2437 2012-02-04 Chong Yidong <cyd@gnu.org>
2439 * nsterm.m: Declare a global (Bug#10694).
2441 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2443 * w32.c (get_emacs_configuration_options):
2444 Include --enable-checking, if specified, in the return value.
2446 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2448 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2449 after rounding frame sizes. (Bug#9723)
2451 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2453 * keyboard.c (adjust_point_for_property): Don't position point
2454 before BEGV. (Bug#10696)
2456 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2458 Handle overflow when computing char display width (Bug#9496).
2459 * character.c (char_width): Return EMACS_INT, not int.
2460 (char_width, c_string_width): Check for overflow when
2461 computing the width; this is possible now that individual
2462 characters can have unbounded width. Problem introduced
2463 by merge from Emacs 23 on 2012-01-19.
2465 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2467 * dbusbind.c (Fdbus_register_method): Mention the return value
2468 :ignore in the docstring.
2470 2012-02-02 Glenn Morris <rgm@gnu.org>
2472 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2474 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2475 Unconditionally set to t. (Bug#10673)
2476 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2477 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2478 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2480 2012-02-02 Kenichi Handa <handa@m17n.org>
2482 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2483 0, do not call append_composite_glyph.
2485 2012-02-02 Kenichi Handa <handa@m17n.org>
2487 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2489 (x_produce_glyphs): If the component of a composition is a null
2490 string, set it->pixel_width to 1 to avoid zero-width glyph.
2492 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2494 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2495 first 2 arguments are identical. This makes inserting large
2496 output from a subprocess an order of magnitude faster on
2497 MS-Windows, where all sbrk'ed memory is always contiguous.
2499 2012-01-31 Glenn Morris <rgm@gnu.org>
2501 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2502 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2503 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2505 2012-01-29 Glenn Morris <rgm@gnu.org>
2507 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2509 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2511 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2513 2012-01-28 Chong Yidong <cyd@gnu.org>
2515 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2517 2012-01-26 Chong Yidong <cyd@gnu.org>
2519 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2521 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2522 repeat counts (Bug#10507).
2524 2012-01-26 Glenn Morris <rgm@gnu.org>
2526 * lread.c (syms_of_lread): Doc fix.
2528 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2530 * coding.c (encode_designation_at_bol): Change return value to
2533 2012-01-25 Chong Yidong <cyd@gnu.org>
2535 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2537 2012-01-21 Chong Yidong <cyd@gnu.org>
2539 * floatfns.c (Fcopysign): Make the second argument non-optional,
2540 since nil is not allowed anyway.
2542 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2544 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2545 (send_process): Likewise.
2547 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2549 * window.c (save_window_save, Fcurrent_window_configuration)
2550 (Vwindow_persistent_parameters): Do not use Qstate.
2551 Rewrite doc-strings.
2553 2012-01-19 Kenichi Handa <handa@m17n.org>
2555 * character.c (char_width): New function.
2556 (Fchar_width, c_string_width, lisp_string_width):
2557 Use char_width (Bug#9496).
2559 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2561 * window.c (Vwindow_persistent_parameters): New variable.
2562 (Fset_window_configuration, save_window_save): Handle persistent
2565 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2567 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2568 thrashing the stack of the thread. (Bug#9087)
2570 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2572 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2574 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2576 * xdisp.c (rows_from_pos_range): Handle the case where the
2577 highlight ends on a newline. (Bug#10464)
2578 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2579 he end column for display of highlight that ends on a newline
2582 2012-01-11 Glenn Morris <rgm@gnu.org>
2584 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2585 from load-path also when installation-directory is nil. (Bug#10208)
2587 2012-01-10 Glenn Morris <rgm@gnu.org>
2589 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2591 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2592 Update template values to be closer to their typical values these days.
2594 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2596 * xdisp.c (rows_from_pos_range): Accept additional argument
2597 DISP_STRING, and accept any glyph in a row whose object is that
2598 string as eligible for mouse highlight. Fixes mouse highlight of
2599 display strings from overlays. (Bug#10464)
2601 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2603 emacs: fix an auto-save permissions race condition (Bug#10400)
2604 * fileio.c (auto_saving_dir_umask): New static var.
2605 (Fmake_directory_internal): Use it.
2606 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2607 creating the directory. The old code temporarily assigns
2608 too-generous permissions to the directory.
2609 (do_auto_save_eh): Clear it.
2610 (Fdo_auto_save): Catch all errors, not just file errors, so
2611 that the var is always cleared.
2613 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2615 * search.c (scan_buffer): Pass character positions to
2616 know_region_cache, not byte positions. (Bug#6540)
2618 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2620 * w32.c (sys_rename): Report EXDEV when rename of a directory
2621 fails because the target is on another logical disk. (Bug#10284)
2623 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2625 * xterm.c (x_embed_request_focus): New function.
2627 * xterm.h: Add prototype.
2629 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2631 2012-01-05 Glenn Morris <rgm@gnu.org>
2633 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2635 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2637 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2638 Load gnutls_transport_set_lowat only if GnuTLS version is below
2640 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2641 GnuTLS versions below 2.11.1.
2643 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2645 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2646 to the doc string advising against its use for altering the way
2647 windows are scrolled.
2649 2011-12-28 Kenichi Handa <handa@m17n.org>
2651 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2652 coding-system ASCII compatible only when it does not produce BOM
2653 on encoding (Bug#10383).
2655 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2657 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2659 (create_and_show_popup_menu): Always use menu_position_func for
2662 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2664 * callint.c (Fcall_interactively): Don't truncate prompt string.
2666 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2668 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2669 property that ends at ZV, so that the bidi iteration could be
2670 resumed from there (after widening). (Bug#10360)
2672 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2674 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2676 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2678 * nsterm.m (x_free_frame_resources):
2679 Release f->output_data.ns->miniimage.
2680 (ns_index_color): Fix indentation. Do not retain
2681 color_table->colors[i].
2683 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2686 * nsfns.m (x_set_background_color): Assign return value from
2687 ns_index_color to face-background instead of NSColor*.
2688 (ns_implicitly_set_icon_type): Fix indentation.
2689 Change assignment in for loop to comparison.
2691 * emacs.c (ns_pool): New variable.
2692 (main): Assign ns_pool.
2693 (Fkill_emacs): Call ns_release_autorelease_pool.
2695 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2696 autorelease fdesc, release fdAttrs and tdict.
2697 (ns_get_covering_families): Release charset.
2698 (ns_findfonts): Release NSFontDescriptor created with new.
2699 (ns_uni_to_glyphs): Fix indentation.
2700 (setString): Release attrStr before assigning new value.
2702 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2704 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2706 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2707 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2709 2011-12-18 David Reitter <reitter@cmu.edu>
2711 * nsterm.m (ns_term_init): Subscribe for notifications
2712 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2713 to method trackingNotification in EmacsMenu.
2715 * nsmenu.m (trackingMenu): New variable.
2716 (trackingNotification): New method (from Aquamacs).
2717 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2718 from Aquamacs (Bug#7030).
2720 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2722 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2723 (symbol_to_nsstring): Fix indentation.
2724 (ns_symbol_to_pb): New function.
2725 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2726 (Fns_rotate_cut_buffers_internal): Remove.
2727 (Fns_store_selection_internal): Rename from
2728 Fns_store_cut_buffer_internal.
2729 (ns_get_foreign_selection, Fx_own_selection_internal)
2730 (Fx_disown_selection_internal, Fx_selection_exists_p)
2731 (Fns_get_selection_internal, Fns_store_selection_internal):
2732 Use ns_symbol_to_pb and check if return value is nil.
2733 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2734 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2735 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2736 renamed to Sns_store_selection_internal.
2737 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2738 and remove this function.
2739 (ns_handle_selection_clear): Remove, never used.
2740 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2743 2011-12-17 Ken Brown <kbrown@cornell.edu>
2745 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2746 GID is unknown (Bug#10257).
2748 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2750 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2751 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2752 which caused a build failure on GNU/Linux IA-64. This problem was
2753 introduced by my 2011-10-07 patch.
2755 2011-12-15 Juri Linkov <juri@jurta.org>
2757 * image.c (imagemagick_error): New function. (Bug#10112)
2758 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2759 Use `imagemagick_error' where ImageMagick functions return
2761 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2764 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2766 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2767 fill background (Bug#8992).
2769 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2771 * window.c (Vwindow_combination_resize)
2772 (Vwindow_combination_limit): Use t instead of non-nil in
2774 (Vrecenter_redisplay): Add first sentence of doc-string on
2776 (Frecenter): Fix doc-string typo.
2778 2011-12-11 Kenichi Handa <handa@m17n.org>
2780 * coding.c (Funencodable_char_position): Pay attention to the
2781 buffer text relocation (Bug#9389).
2783 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2785 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2786 gtk_init (Bug#10100).
2788 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2791 IT->string is nil. (Bug#10263)
2793 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2795 * nsterm.h (x_free_frame_resources): Declare.
2797 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2798 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2800 * nsterm.h (ns_get_defaults_value): Declare.
2802 * nsterm.m (ns_default): Call ns_get_defaults_value.
2804 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2806 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2809 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2811 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2812 that where the value of an _OBJC_* symbol points to is in the .bss
2813 section (Bug#10240).
2815 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2817 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2818 after the loop to call ccl_driver at least once (Bug#8619).
2820 2011-12-08 Kenichi Handa <handa@m17n.org>
2822 * ftfont.c (get_adstyle_property): Fix previous change
2825 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2827 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2828 dirs from the default value of EMACSLOADPATH (bug#10208).
2830 2011-12-07 Glenn Morris <rgm@gnu.org>
2832 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2833 installation and source directories as well. (Bug#10208)
2835 2011-12-06 Chong Yidong <cyd@gnu.org>
2837 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2839 2011-12-06 Glenn Morris <rgm@gnu.org>
2841 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2842 as an error, not just -1. (Bug#10217)
2844 2011-12-05 Chong Yidong <cyd@gnu.org>
2846 * keyboard.c (process_special_events): New function.
2847 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2849 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2851 * coding.c (encode_designation_at_bol): Don't use uninitialized
2852 local variable (Bug#9318).
2854 2011-12-05 Kenichi Handa <handa@m17n.org>
2856 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2857 return Qnil (Bug#8046, Bug#10193).
2859 2011-12-05 Kenichi Handa <handa@m17n.org>
2861 * coding.c (encode_designation_at_bol): New args charbuf_end and
2862 dst. Return the number of produced bytes. Callers changed.
2863 (coding_set_source): Return how many bytes coding->source was
2865 (coding_set_destination): Return how many bytes
2866 coding->destination was relocated.
2867 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2868 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2870 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2872 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2873 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2876 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2878 The following changes are to fix Bug#9318.
2880 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2881 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2882 (encode_coding_iso_2022, encode_coding_sjis)
2883 (encode_coding_big5, encode_coding_charset): Use the above macros.
2885 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2887 * lisp.h (process_quit_flag): Fix external declaration.
2889 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2891 Don't macro-inline non-performance-critical code.
2892 * eval.c (process_quit_flag): New function.
2893 * lisp.h (QUIT): Use it.
2895 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2897 * nsfns.m (get_geometry_from_preferences): New function.
2898 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2900 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2902 * emacs.c (Qkill_emacs): Define.
2903 (syms_of_emacs): Initialize it.
2904 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2905 Qquit_flag to `kill-emacs' instead.
2906 (quit_throw_to_read_char): Add parameter `from_signal'.
2907 All callers changed. Call Fkill_emacs if requested and safe.
2908 * lisp.h (QUIT): Call Fkill_emacs if requested.
2910 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2912 * widget.c (update_wm_hints): Return if wmshell is null.
2913 (widget_update_wm_size_hints): New function.
2915 * widget.h (widget_update_wm_size_hints): Declare.
2917 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2918 widget_update_wm_size_hints (Bug#10104).
2920 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2922 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2923 before a newline, prepare the bidi iterator for consuming the
2924 newline, and keep the current paragraph direction. (Bug#10183)
2925 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2927 2011-12-02 Juri Linkov <juri@jurta.org>
2929 * search.c (Fword_search_regexp): New Lisp function created from
2930 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2931 (Fword_search_backward, Fword_search_forward)
2932 (Fword_search_backward_lax, Fword_search_forward_lax):
2933 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2934 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2936 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * fileio.c (Finsert_file_contents): Move after-change-function call
2939 to before the "handled:" label, since all "goto handled" appear in
2940 cases where the *-change-functions have already been properly called
2943 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2945 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2946 waiting for input. (Bug#10169)
2948 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2950 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2951 verifies glyph row's hash code--we have just reallocated the
2952 glyphs, so their contents can be complete garbage. (Bug#10164)
2954 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2956 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2958 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2960 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2961 attributes are tested _before_ calling verify_row_hash, to protect
2962 against GCC re-ordering of the tests. (Bug#10164)
2964 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2966 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2968 * xterm.c (handle_one_xevent): Only set async_visible and friends
2969 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2970 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2971 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2973 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2975 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2976 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2977 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2978 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2979 All uses changed to use GCPRO1 etc.
2980 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2981 Revert to old implementation (i.e., before 2011-03-11).
2983 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2985 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2986 of scroll runs so as to avoid assigning disabled bogus rows and
2987 unnecessary graphics copy operations.
2989 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2991 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2992 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2993 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2994 (malloc, free, realloc, calloc): Redirect to e_* only when
2997 * lisp.h (GCTYPEBITS): Move before first use.
2998 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2999 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3000 this macro definition.
3002 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3005 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3007 * gtkutil.c (xg_create_frame_widgets):
3008 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3009 present with Gtk+ 2.0.
3011 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3013 * fileio.c (Finsert_file_contents): Undo previous change; see
3014 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3016 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3018 Rename locals to avoid shadowing.
3019 * fileio.c (Finsert_file_contents):
3020 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3021 * process.c (wait_reading_process_output):
3022 Rename inner 'proc' to 'p' to avoid shadowing.
3023 Indent for consistency with usual Emacs style.
3025 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3027 * xdisp.c (redisplay_window): If cursor row is not fully visible
3028 after recentering, and scroll-conservatively is set to a large
3029 number, scroll window by a few more lines to make the cursor fully
3030 visible and out of scroll-margin. (Bug#10105)
3031 (start_display): Don't move to the next line if the display should
3032 start at a newline that is part of a display vector or an overlay
3035 2011-11-24 Juri Linkov <juri@jurta.org>
3037 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3038 after the `MagickPingImage' call. (Bug#10112)
3040 2011-11-23 Chong Yidong <cyd@gnu.org>
3042 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3044 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3046 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3047 making another buffer current. (Bug#10114)
3049 2011-11-23 Glenn Morris <rgm@gnu.org>
3051 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3053 2011-11-23 Chong Yidong <cyd@gnu.org>
3055 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3056 using it (Bug#5984).
3058 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3060 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3061 and header-lines, as they don't have one computed for them.
3064 * .gdbinit (prow): Make displayed values more self-explaining.
3065 Add row's hash code.
3067 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3069 * process.c (wait_reading_process_output): Fix asynchrounous
3070 GnuTLS socket handling on some versions of the GnuTLS library.
3071 (wait_reading_process_output): Add comment and URL.
3073 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3075 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3077 2011-11-21 Chong Yidong <cyd@gnu.org>
3079 * window.c (Fnext_window, Fprevious_window): Doc fix.
3081 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3083 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3085 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3087 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3089 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3091 * window.c (Fset_window_combination_limit): Rename argument
3093 (Vwindow_combination_limit): Remove "status" from doc-string.
3095 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3097 * m/ibms390.h: Remove.
3098 * m/ibms390x.h: Don't include "ibms390.h".
3100 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3102 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3103 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3105 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3107 * casetab.c (Fset_case_table):
3108 * charset.c (Fcharset_after): Fix typos.
3110 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3112 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3113 Otherwise, valgrind does not work on some platforms.
3114 Problem reported by Andreas Schwab in
3115 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3116 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3117 is set, removing the need for VIRT_ADDRESS_VARIES.
3118 (PURE_P): Use a more-efficient implementation that needs just one
3119 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3120 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3121 to 4 (xorl, subq, cmpq, setbe).
3122 * alloc.c (pure): Always extern now, since that's the
3123 VIRT_ADDR_VARIES behavior.
3124 (PURE_POINTER_P): Use a single comparison, not two, for
3125 consistency with the new puresize.h.
3126 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3127 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3128 Remove VIRT_ADDR_VARIES no longer needed.
3130 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3132 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3133 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3134 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3135 behave as if the cursor position were at the window margin.
3137 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3138 and the cursor position is out of bounds, behave as if the cursor
3139 position were at the window margin. (Bug#10075)
3141 2011-11-18 Chong Yidong <cyd@gnu.org>
3143 * window.c (Fwindow_combination_limit): Make first argument
3144 non-optional, since it is meaningless for live windows like the
3147 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3149 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3151 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3154 (graft_intervals_into_buffer): Simplify.
3156 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3158 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3159 hash values of the two rows.
3160 (copy_row_except_pointers): Preserve the used[] arrays and the
3161 hash values of the two rows. (Bug#10035)
3162 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3164 * xdisp.c (row_hash): New function, body extracted from
3165 compute_line_metrics.
3166 (compute_line_metrics): Call row_hash, instead of computing the
3169 * dispnew.c (verify_row_hash): Call row_hash for computing the
3170 hash code of a row, instead of duplicating code from xdisp.c.
3172 * dispextern.h (row_hash): Add prototype.
3174 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3176 * frame.c (delete_frame): Don't delete the terminal when the last
3177 X frame is closed if emacs is built with GTK toolkit.
3179 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3181 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3183 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3185 * window.c (Vwindow_splits): Rename to
3186 Vwindow_combination_resize. Suggested by Juri Linkov.
3187 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3190 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3192 * nsfns.m (Fns_font_name):
3193 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3195 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3197 * window.h (window): Rename slot "nest" to "combination_limit".
3198 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3199 (Fset_window_nest): Rename to Fset_window_combination_limit.
3200 (Vwindow_nest): Rename to Vwindow_combination_limit.
3201 (recombine_windows, make_parent_window, make_window)
3202 (Fsplit_window_internal, saved_window)
3203 (Fset_window_configuration, save_window_save): Rename all
3204 occurrences of window_nest to window_combination_limit.
3206 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3208 * image.c (imagemagick_load_image): Fix typo.
3210 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3212 * xdisp.c (display_line): Move the call to
3213 highlight_trailing_whitespace before the call to
3214 compute_line_metrics, since the latter needs to see the final
3215 faces of all the glyphs to compute ROW's hash value.
3216 Fixes assertion violations in row_equal_p. (Bug#10035)
3218 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3220 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3221 just return (bug#10044).
3223 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3225 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3226 with user-defined heap size. Bump the default size of the temacs
3227 heap to 27MB, to avoid memory warning when running temacs.
3228 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3230 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3231 current_matrix and desired_matrix. (Bug#9990)
3232 (verify_row_hash) [XASSERTS]: New function.
3233 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3234 that the hash value of glyph rows is correct.
3236 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3238 * window.h (window): Remove splits slot.
3239 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3240 (Fdelete_other_windows_internal, make_parent_window)
3241 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3242 (Fset_window_configuration, save_window_save): Don't deal with
3243 split status of windows.
3244 (saved_window): Remove splits slot.
3245 (Vwindow_splits): Rewrite doc-string.
3247 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3249 * xfns.c (unwind_create_frame):
3250 * nsfns.m (unwind_create_frame):
3251 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3252 Vframe_list (Bug#9999).
3254 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3256 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3258 2011-11-11 Kenichi Handa <handa@m17n.org>
3260 * callproc.c (Fcall_process): Set the member dst_multibyte of
3263 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3265 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3266 avoid a crash (bug#9496).
3268 2011-11-09 Chong Yidong <cyd@gnu.org>
3270 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3271 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3273 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3275 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3277 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3279 Avoid some portability problems by eschewing 'extern inline' functions.
3280 The trivial performance wins aren't worth the portability hassles; see
3281 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3283 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3284 (window_box_width, window_box_left, window_box_left_offset)
3285 (window_box_right, window_box_right_offset): Undo previous change,
3286 by removing the "extern"s.
3287 * intervals.c (adjust_intervals_for_insertion)
3288 (adjust_intervals_for_deletion): Undo previous change,
3289 making these static again.
3290 (offset_intervals, temp_set_point_both, temp_set_point)
3291 (copy_intervals_to_string): No longer inline.
3292 * xdisp.c (window_text_bottom_y, window_box_width)
3293 (window_box_height, window_box_left_offset)
3294 (window_box_right_offset, window_box_left, window_box_right)
3295 (window_box): No longer inline.
3297 2011-11-08 Chong Yidong <cyd@gnu.org>
3299 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3300 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3301 Signal an error if not a live window.
3302 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3303 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3305 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3307 * lisp.h (syms_of_abbrev): Remove declaration.
3308 Reported by CHENG Gao <chenggao@royau.me>.
3310 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3312 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3313 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3314 of temacs in GUI mode.
3316 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3318 * window.h: Declare delete_all_child_windows instead of
3319 delete_all_subwindows.
3320 * window.c (Fwindow_nest, Fset_window_nest)
3321 (Fset_window_new_total, Fset_window_new_normal)
3322 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3323 (delete_all_subwindows): Rename to delete_all_child_windows.
3324 (Fdelete_other_windows_internal, Fset_window_configuration):
3325 Call delete_all_child_windows instead of delete_all_subwindows.
3326 * frame.c (delete_frame): Call delete_all_child_windows instead
3327 of delete_all_subwindows.
3329 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3331 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3332 This is also needed for porting to any host where GC_MARK_STACK is
3333 not GC_MAKE_GCPROS_NOOPS.
3334 (which_symbols): Use it.
3336 2011-11-07 Kenichi Handa <handa@m17n.org>
3338 * coding.c (coding_set_destination): Check coding->src_pos only
3339 when coding->src_object is a buffer (bug#9910).
3341 * process.c (send_process): Set the member src_multibyte of coding
3342 to 0 (bug#9911) when sending a unibyte text.
3344 * callproc.c (Fcall_process): Set the member src_multibyte of
3345 process_coding to 0 (bug#9912).
3347 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3349 * xmenu.c (cleanup_widget_value_tree): New function.
3350 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3351 calling free_menubar_widget_value_tree directly (Bug#9830).
3353 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3355 Fix some portability problems with 'inline'.
3356 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3357 (window_box_width, window_box_left, window_box_left_offset)
3358 (window_box_right, window_box_right_offset): Declare extern.
3359 Otherwise, these inline functions do not conform to C99 and
3360 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3361 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3362 * intervals.c (adjust_intervals_for_insertion)
3363 (adjust_intervals_for_deletion): Now extern, because otherwise the
3364 extern inline functions 'offset_intervals' couldn't refer to it.
3365 (static_offset_intervals): Remove.
3366 (offset_intervals): Rewrite using the old contents of
3367 static_offset_intervals. The old version didn't conform to C99
3368 because an extern inline function contained a reference to an
3369 identifier with static linkage.
3371 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3373 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3376 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3378 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3379 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3380 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3381 return Qleft_to_right.
3383 2011-11-06 Chong Yidong <cyd@gnu.org>
3385 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3386 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3387 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3388 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3389 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3390 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3391 (Fwindow_vscroll): Doc fix.
3392 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3393 argument, since it makes no sense to pass a live window and for
3394 consistency with window-child.
3396 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3398 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3401 2011-11-05 Jason Rumney <jasonr@gnu.org>
3403 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3404 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3406 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3407 bitwise arithmetic preventing use of unicode-sip and non-truetype
3410 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3412 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3415 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3416 initialization code to keep similarity to xfns.c after changes
3419 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3421 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3422 (unwind_create_frame): New function (Bug#9943).
3423 (Fx_create_frame): Restructure code to be more similar to the one in
3424 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3425 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3426 Move terminal->reference_count++ just before making the frame official
3429 * nsterm.m (x_free_frame_resources): New function.
3430 (x_destroy_window): Move code to x_free_frame_resources.
3432 * xfns.c (unwind_create_frame): Fix comment.
3433 (Fx_create_frame, x_create_tip_frame):
3434 Move terminal->reference_count++ just before making the frame
3435 official. Move initialization of image_cache_refcount and
3436 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3438 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3440 Support MSVC build with newer versions of Visual Studio.
3441 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3442 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3445 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3446 which are not supported by MSVC.
3447 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3448 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3450 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3452 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3454 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3456 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3458 Support MSVC build with newer versions of Visual Studio.
3459 * w32.c: Don't include w32api.h for MSVC.
3460 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3462 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3463 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3464 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3465 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3467 (alloca) [_MSC_VER]: Define to _alloca.
3469 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3471 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3473 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3475 * xdisp.c (note_mouse_highlight): If either of
3476 previous/next-single-property-change returns nil, treat that as
3477 the beginning or the end of the buffer. (Bug#9955)
3479 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3481 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3482 label is not null (Bug#9951).
3483 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3486 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3488 * window.c (Fwindow_body_size): Mention in the doc string that the
3489 return value is in frame's canonical units. (Bug#9949)
3491 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3493 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3495 * w32fns.c (unwind_create_frame): If needed, free the glyph
3496 matrices of the partially constructed frame. (Bug#9943)
3497 * xfns.c (unwind_create_frame): Likewise.
3499 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3501 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3502 Don't stop backward scan on the continuation glyph, even though
3503 its CHARPOS is positive.
3504 (mouse_face_from_buffer_pos, note_mouse_highlight):
3505 Rename cover_string to disp_string.
3507 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3509 * window.c (temp_output_buffer_show): Don't use
3510 Vtemp_buffer_show_specifiers.
3511 (Vtemp_buffer_show_specifiers): Remove unused variable.
3513 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3515 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3516 past the beginning of the current glyph matrix.
3518 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3520 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3521 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3522 HAVE_GTK3 (Bug#9869).
3524 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3525 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3527 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3529 * xterm.c: Declare x_handle_net_wm_state to return int.
3530 (handle_one_xevent): Check if we are iconified but don't have
3531 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3532 (get_current_wm_state): Return non-zero if not hidden,
3533 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3534 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3535 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3536 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3538 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3540 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3541 so that this new function doesn't get optimized away by a
3542 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3544 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3546 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3548 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3550 Fix the `xbytecode' command.
3551 * .gdbinit (xprintbytestr): New command.
3552 (xwhichsymbols): Rename from `which'; all callers changed.
3553 (xbytecode): Print the byte-code string as well.
3555 2011-10-29 Kim Storm <storm@cua.dk>
3557 * alloc.c (which_symbols): New function.
3559 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3561 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3564 2011-10-29 Glenn Morris <rgm@gnu.org>
3566 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3567 Not clear what it was for, and it causes various bugs. (Bug#9839)
3569 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3571 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3572 possible random value that matches one of those tested as
3573 condition to clear the mouse face.
3575 2011-10-28 Chong Yidong <cyd@gnu.org>
3577 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3579 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3581 * window.c (make_window): Initialize phys_cursor_on_p.
3583 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3585 * lisp.h (struct Lisp_Symbol): Update comments.
3587 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3589 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3591 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3593 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3594 <oslsachem@gmail.com> for helping to debug this.
3596 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3597 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3598 (g_b_init_get_glyph_outline_w): New static variables.
3599 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3600 (GetGlyphOutlineW_Proc): New typedefs.
3601 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3602 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3604 (w32font_open_internal, compute_metrics):
3605 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3606 instead of calling the "wide" APIs directly.
3608 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3610 * w32.h (syms_of_w32font): Add prototype.
3612 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3614 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3615 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3616 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3617 (Fmove_to_window_line): Doc fix.
3619 2011-10-27 Chong Yidong <cyd@gnu.org>
3621 * process.c (make_process): Set gnutls_state to NULL.
3623 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3624 non-NULL, regardless of GNUTLS_INITSTAGE.
3625 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3626 an error. Set process slots as soon as we allocate them.
3628 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3630 2011-10-27 Chong Yidong <cyd@gnu.org>
3632 * gnutls.c (emacs_gnutls_deinit): New function.
3633 Deallocate credentials structures as well as calling gnutls_deinit.
3634 (Fgnutls_deinit, Fgnutls_boot): Use it.
3636 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3637 (deactivate_process): Call emacs_gnutls_deinit.
3639 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3641 * image.c (x_create_x_image_and_pixmap):
3642 * w32.c (sys_rename, w32_delayed_load):
3643 * w32font.c (fill_in_logfont):
3644 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3646 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3648 * w32fns.c (w32_default_color_map): New function,
3649 extracted from Fw32_default_color_map.
3650 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3652 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3654 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3656 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3658 * keyboard.c (test_undefined): New function (bug#9751).
3659 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3661 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3663 * sysdep.c (init_sys_modes): Fix the check for the controlling
3664 terminal (Bug#6649).
3666 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3668 * dispextern.h (struct bidi_it): New member next_en_type.
3670 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3671 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3672 current character, check also for next_en_type being WEAK_EN.
3673 (bidi_resolve_weak): Don't enter the expensive loop if the current
3674 position is before next_en_pos. Record the bidi type of the first
3675 non-ET, non-BN character we find, in addition to its position.
3676 (bidi_level_of_next_char): Invalidate next_en_type when
3677 next_en_pos is over-stepped.
3679 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3681 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3682 * editfns.c: Rewrite current-time-zone so that it invokes
3683 the equivalent of (format-time-string "%Z") to get the time zone name.
3684 This fixes a bug when the time zone name contains characters that
3685 need converting from the system time locale to Emacs internal format.
3686 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3687 that patch fixed format-time-string to do the conversion, but
3688 I forgot to fix current-time-zone.
3689 (format_time_string): New function, containing most of
3690 what Fformat_time_string used to contain.
3691 (Fformat_time_string): Rewrite in terms of format_time_string.
3692 This doesn't change this function's behavior.
3693 (current-time-zone): Rewrite to use format_time_string.
3694 This fixes the bug reported by Michael Schierl in
3695 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3696 Jason Rumney's 2007-06-07 change worked around this bug, but
3698 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3700 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3702 * xdisp.c (start_display): If the character at POS is displayed
3703 via a display vector, reset IT->current.dpvec_index to zero.
3704 (try_window_reusing_current_matrix): If a line ends in a display
3705 vector or the next line starts in a display vector, continue
3706 redrawing the window even though the character position of
3707 start_row was reached.
3710 2011-10-18 Chong Yidong <cyd@gnu.org>
3712 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3713 with nobreak-char-display too.
3715 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3717 Fix part 3 of bug#9771.
3718 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3719 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3720 non-neutral characters if the current character is a paragraph
3721 separator (a.k.a. Newline). This avoids running the same
3722 expensive loop twice, once when we consume the preceding newline
3723 and the other time when the line actually needs to be displayed.
3724 Avoid the loop when we see neutrals on the base embedding level
3725 following a character whose directionality is the same as the
3726 paragraph's. This avoids running the expensive loop when a line
3727 ends in a long sequence of neutrals, like control characters.
3728 Add assertion against STRONG_AL type. Slightly rearrange code
3729 that determines the type of a neutral given the first non-neutral
3731 (bidi_level_of_next_char): Set next_en_pos to zero when
3732 invalidating its info.
3734 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3736 * xdisp.c (push_display_prop): Determine whether to record string
3737 or buffer position by IT->string, not by IT->method. Allow
3738 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3739 (move_it_vertically_backward): Don't look for character position
3740 immediately after the newline when in a continuation line.
3743 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3745 * window.c (coordinates_in_window): Rewrite and delabelize
3746 vertical border check. (Bug#5357) (Bug#9618)
3748 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3750 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3751 errors in XSetWindowBorder (bug#9310).
3753 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3755 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3756 avoid crash when xmalloc overrun checking is enabled.
3758 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3760 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3761 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3762 cursor motion with <left> and <right> arrow keys.
3764 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3765 some callers set that themselves.
3767 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3769 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3770 display string and the previous row comes from the same string and
3771 is empty. (Bug#9739) (Bug#9738)
3773 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3775 * doc.c (get_doc_string): Encode file name (bug#9735).
3777 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3779 * bidi.c (bidi_level_of_next_char):
3780 * xdisp.c (get_visually_first_element): Remove old incorrect
3781 comments regarding the Unicode Line Separator character.
3783 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3785 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3787 * alloc.c (Fgc_status): Do not access beyond zombies array
3788 boundary if nzombies > MAX_ZOMBIES.
3789 * alloc.c (dump_zombies): Add missing format specifier.
3791 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3793 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3794 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3796 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3797 Some packages use them to denote characters with modifiers.
3799 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3801 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3802 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3803 matching a pp-number. Rename parameter var to var1.
3805 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3807 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3809 2011-10-08 Glenn Morris <rgm@gnu.org>
3811 * callint.c (Fcall_interactively): Give a more explicit error for the
3812 'c' case with a non-character input. (Bug#8479)
3814 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3816 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3818 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3819 lines that are hscrolled on the left.
3821 * dispnew.c (buffer_posn_from_coords): Account for a possible
3822 presence of header-line. (Bug#4426)
3824 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3826 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3827 Don't advertise functionality which we discourage or doesn't work.
3829 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3831 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3832 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3833 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3834 this makes Emacs dump core during garbage collection on rare
3835 occasions. sizeof is obviously inferior to offsetof here, so
3836 stick with offsetof.
3837 (GC_POINTER_ALIGNMENT): New macro.
3838 (mark_memory): Omit 3rd (offset) arg; caller changed.
3839 Don't assume EMACS_INT alignment is the same as pointer alignment.
3841 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3843 * keyboard.c (read_key_sequence_remapped): New var.
3844 (read_key_sequence): Compute remapping in the right buffer.
3845 (command_loop_1): Use read_key_sequence's remapping directly.
3847 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3849 * dired.c (file_name_completion): Don't expand file name.
3850 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3851 before checking file name handler.
3853 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3854 they've been requested explicitly (bug#9591).
3856 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3858 * keymap.c (Fsingle_key_description): Use make_specified_string
3859 instead of build_string to build string from push_key_description.
3862 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3864 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3865 This fixes a Y2038 bug on 64-bit hosts.
3866 * buffer.c (reset_buffer):
3867 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3868 (Fclear_buffer_auto_save_failure):
3869 Use 0, not -1, to represent an unset failure time, since time_t
3870 might not be signed.
3872 Remove dependency on glibc malloc internals.
3873 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3874 Move back here from lisp.h, but with their new implementations.
3875 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3876 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3877 * charset.c (charset_table_init): New static var.
3878 (syms_of_charset): Use it instead of xmalloc. This removes a
3879 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3880 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3881 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3882 Move back to alloc.c.
3883 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3884 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3886 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3888 * nsterm.m (windowDidResize): Call x_set_window_size only when
3889 ns_in_resize is true. Otherwise set pixelwidth/height and
3890 call change_frame_size (Bug#9628).
3892 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3894 Port --enable-checking=all to Fedora 14 x86-64.
3895 * charset.c (syms_of_charset): Also account for glibc malloc's
3896 internal overhead when calculating the initial malloc maximum.
3898 Port --enable-checking=all to Fedora 14 x86.
3899 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3901 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3902 (overrun_check_realloc, overrun_check_free):
3903 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3904 That way, xmalloc returns a properly-aligned pointer even if
3905 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3906 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3907 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3908 into account when calculating the initial malloc maximum.
3909 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3910 Move here from alloc.c, so that charset.c can use it too.
3911 Properly align; the old code wasn't right for common 32-bit hosts
3912 when configured with --enable-checking=all.
3913 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3914 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3916 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3918 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3921 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3923 * xdisp.c (compute_display_string_end): If there's no display
3924 string at CHARPOS, return -1.
3926 * bidi.c (bidi_fetch_char): When compute_display_string_end
3927 returns a negative value, treat the character as a normal
3928 character not covered by a display string. (Bug#9624)
3930 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3932 * lread.c (Fread_from_string): Fix typo in docstring.
3934 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3936 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3937 newline, reseat the iterator instead of bidi-iterating there one
3938 character at a time. (Bug#9610)
3939 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3940 TO_CHARPOS if the bidi iterator is at base embedding level.
3942 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3944 * lread.c (readevalloop): Use correct code for NBSP.
3945 (read1): Likewise. (Bug#9608)
3947 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3949 * dbusbind.c (Fdbus_register_signal): When service is not
3950 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3952 2011-09-25 Glenn Morris <rgm@gnu.org>
3954 * buffer.c (truncate-lines): Doc fix.
3956 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3958 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3959 (Fset_window_next_buffers): Doc fix.
3961 2011-09-24 Glenn Morris <rgm@gnu.org>
3963 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3965 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3967 Fix minor problems found by static checking.
3968 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3969 * indent.c (Fvertical_motion): Fix == vs = typo.
3971 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3973 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3974 Default value is now t. Doc fix.
3976 * indent.c (Fvertical_motion): Compute and apply the overshoot
3977 logic when moving up, not only when moving down. Fix the
3978 confusing name and values of the it_overshoot_expected variable;
3979 logic changes accordingly. (Bug#9254) (Bug#9549)
3981 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3982 CHARPOS is covered by a display string which includes newlines.
3983 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3984 is covered by a display string with embedded newlines.
3986 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3988 * dbusbind.c (Fdbus_register_signal): Add match rule to
3989 Vdbus_registered_objects_table. (Bug#9581)
3990 (Fdbus_register_method, Vdbus_registered_objects_table):
3993 2011-09-24 Jim Meyering <meyering@redhat.com>
3995 do not ignore write error for any output size
3996 The previous change was incomplete.
3997 While it makes emacs --batch detect the vast majority of stdout
3998 write failures, errors were still ignored whenever the output size is
3999 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4000 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4001 && echo FAIL: ignored write error
4002 FAIL: ignored write error
4003 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4004 && echo FAIL: ignored write error
4005 FAIL: ignored write error
4006 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4008 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4010 * emacs.c (Fkill_emacs): In noninteractive mode exit
4011 non-successfully if a write error occurred on stdout. (Bug#9574)
4013 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4015 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4018 * dispextern.h (struct it): Update the comment documenting what
4021 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4023 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4024 a display string, extend search for cursor position to end of row.
4025 (find_row_edges): If the row ends in a newline from a display
4026 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4027 Handle the case of a display string with multiple newlines.
4028 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4029 non-empty line. Fixes confusing cursor motion with arrow keys at
4030 the beginning of a line that starts with whitespace.
4032 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4037 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4039 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4042 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4044 * xdisp.c (display_line): Record maximum and minimum buffer
4045 positions even if no glyphs were produced (e.g., by a zero-width
4046 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4047 buffer positions that will be removed from the glyph row because
4049 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4050 column is beyond frame width: don't subtract 1 "pixel" when
4051 computing width of the stretch.
4052 (reseat_at_next_visible_line_start): Undo the change made on
4053 2011-09-17 that saved paragraph information and restored it after
4054 the call to `reseat'. (Bug#9545)
4056 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4058 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4059 and turn window cursor on if cleared (Bug#9415).
4061 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4063 * search.c (boyer_moore): Take unibyte characters from pattern
4064 literally. (Bug#9458)
4066 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4068 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4070 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4072 Fix minor problem found by static checking.
4073 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4074 initialized, to pacify gcc -Wuninitialized.
4076 * fileio.c: Report proper errno when syscall falls.
4077 (Finsert_file_contents): Save and restore errno,
4078 so that report_file_error outputs the correct diagnostic.
4079 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4081 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4083 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4085 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4087 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4088 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4090 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4092 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4093 about the current paragraph and restore it after the call to reseat.
4095 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4096 (bidi_find_paragraph_start): Search back for paragraph beginning
4097 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4098 (bidi_move_to_visually_next): Only trigger paragraph-related
4099 computations when the last character is a newline or at EOB, not
4100 just any NEUTRAL_B. (Bug#9470)
4102 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4103 truncated lines if point is covered by a display string. (Bug#9524)
4105 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4107 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4108 (cons_to_x_long): New function.
4109 (lisp_data_to_selection_data): Use it. Correct the test for
4110 short-versus-long data; it was negated. Break out of vector
4111 loop, for efficiency, when a long datum is discovered.
4113 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4115 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4117 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4119 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4120 GCC PR/17406) by declaring this function with external scope.
4122 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4124 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4125 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4127 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4129 * editfns.c (Fformat): Correctly handle text properties on "%%".
4131 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4133 * xterm.c (x_draw_composite_glyph_string_foreground):
4134 * w32term.c (x_draw_composite_glyph_string_foreground):
4135 * term.c (encode_terminal_code):
4136 * composite.c (composition_update_it, get_composition_id):
4137 * xdisp.c (get_next_display_element)
4138 (fill_composite_glyph_string): Add comments about special meaning
4139 of TAB characters in a composition.
4141 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4143 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4144 This occurs when processing a multibyte format.
4145 Problem reported by Wolfgang Jenker.
4147 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4149 * xdisp.c (try_cursor_movement): Only check for exact match if
4150 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4152 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4154 Remove unused external symbols.
4155 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4156 * xdisp.c (calc_pixel_width_or_height): Now static.
4157 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4158 * indent.c (check_display_width):
4159 * w32term.c: Fix comment to match code.
4160 * xterm.c, xterm.h (x_catching_errors): Remove.
4162 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4164 * xselect.c: Use signed conversions more consistently (Bug#9498).
4165 (selection_data_to_lisp_data): Assume incoming selection data are
4166 signed integers, not unsigned. This is to be consistent with
4167 outgoing selection data, which was modified to use signed integers
4168 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4169 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4170 expects long, not unsigned long.
4172 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4174 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4175 computation of loop end. Reported by Johan Bockgård
4178 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4180 * frame.c (Fother_visible_frames_p): Function deleted.
4182 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4184 * indent.c (compute_motion): Process display vector front to back
4185 rather than the other way around. (Bug#2496)
4187 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4189 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4191 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4193 * minibuf.c (Fread_from_minibuffer): Doc fix.
4195 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4197 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4198 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4200 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4202 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4203 value for non-existent files.
4205 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4207 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4208 set its "size" to -1. This will set the modtime_size field of
4209 the corresponding buffer to -1, which is what
4210 verify-visited-file-modtime expects for files that do not exist.
4213 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4215 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4217 * lisp.h: ... from here. push_key_description is no longer
4218 defined in keyboard.c, so its declaration should not be in
4219 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4220 logically belongs with push_key_description.
4222 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4224 * buffer.h: Include <sys/types.h> instead of <time.h>.
4225 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4226 Problem reported by Herbert J. Skuhra.
4228 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4230 * xml.c (parse_region): Make the parsing work for
4231 non-comment-starting XML files again (bug#9144).
4233 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4235 * image.c (gif_load): Fix calculation of bottom and right corner.
4238 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4240 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4241 redisplay in small windows.
4243 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4245 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4247 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4249 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4250 Operate on live windows only.
4252 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4254 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4256 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4258 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4259 only under bidi iteration.
4261 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4263 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4265 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4267 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4268 Without this fix, the command to link temacs failed due to an
4269 undefined symbol __builtin_isnan. This is because
4270 /usr/include/iso/math_c99.h #defines isnan(x) to
4271 __builtin_isnan(x), but the bundled gcc, which identifies itself
4272 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4274 * floatfns.c (isnan): #undef, and then #define to a clone of
4276 (Fisnan): Always define, since it's always available now.
4277 (syms_of_floatfns): Always define isnan at the Lisp level.
4279 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4281 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4283 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4285 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4286 The previous code assumed that file offsets (off_t values) fit in
4287 EMACS_INT variables, which is not true on typical 32-bit hosts.
4288 The code messed up by falsely reporting buffer overflow in cases
4289 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4290 when "big" contains more than 2**29 bytes, even though this
4291 inserts just one byte and does not overflow the buffer.
4292 (Finsert_file_contents): Store file offsets as off_t
4293 values, not as EMACS_INT values. Check for overflow when
4294 converting between EMACS_INT and off_t. When checking for
4295 buffer overflow or for overlap, take the offsets into account.
4296 Don't use EMACS_INT for small values where int suffices.
4297 When checking for overlap, fix a typo: ZV was used where
4298 ZV_BYTE was intended.
4299 (Fwrite_region): Don't assume off_t fits into 'long'.
4300 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4302 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4304 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4306 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4308 sprintf-related integer and memory overflow issues (Bug#9412).
4310 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4311 (esprintf, exprintf, evxprintf): New functions.
4312 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4313 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4314 (modify_event_symbol): Do not assume that the length of
4315 name_alist_or_stem is safe to alloca and fits in int.
4316 (Fexecute_extended_command): Likewise for function name and binding.
4317 (Frecursion_depth): Wrap around reliably on integer overflow.
4318 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4319 since some callers pass EMACS_INT values.
4320 (Fsingle_key_description): Don't crash if symbol name contains more
4321 than MAX_ALLOCA bytes.
4322 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4323 (get_minibuffer): Arg is now EMACS_INT, not int.
4324 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4325 (esprintf, exprintf, evxprintf): New decls.
4326 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4328 * dbusbind.c (signature_cat): New function.
4329 (xd_signature, Fdbus_register_signal):
4330 Do not overrun buffer; instead, report string overflow.
4332 * dispnew.c (add_window_display_history): Don't overrun buffer.
4333 Truncate instead; this is OK since it's just a log.
4335 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4336 even if the time zone offset is outlandishly large.
4337 Don't mishandle offset == INT_MIN.
4339 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4340 when creating daemon; the previous buffer-overflow check was incorrect.
4342 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4343 which has the guts of the old verror function.
4345 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4346 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4348 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4349 (font_unparse_xlfd): Don't blindly alloca long strings.
4350 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4351 fits in int, when using sprintf. Use single snprintf to count
4352 length of string rather than counting it via multiple sprintfs;
4353 that's simpler and more reliable.
4354 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4355 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4356 sprintf, in case result does not fit in int.
4358 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4359 (fontset_from_font): Print it.
4361 * frame.c (tty_frame_count): Now printmax_t, not int.
4362 (make_terminal_frame, set_term_frame_name): Print it.
4363 (x_report_frame_params): In X, window IDs are unsigned long,
4364 not signed long, so print them as unsigned.
4365 (validate_x_resource_name): Check for implausibly long names,
4366 and don't assume name length fits in 'int'.
4367 (x_get_resource_string): Don't blindly alloca invocation name;
4368 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4371 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4372 (xg_check_special_colors, xg_set_geometry):
4373 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4375 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4376 Use esprintf, not sprintf, in case result does not fit in int.
4378 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4379 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4380 it as a large positive number.
4381 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4382 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4384 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4385 in case result does not fit in int.
4387 * print.c (float_to_string): Detect width overflow more reliably.
4388 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4389 buffer overrun. Don't assume list length fits in 'int'. Treat
4390 print length of 0 as 0, not as infinity; to be consistent with other
4391 uses of print length in this function. Don't overflow print length
4392 index. Don't assume hash table size fits in 'long', or that
4393 vectorlike size fits in 'unsigned long'.
4395 * process.c (make_process): Use printmax_t, not int, to format
4396 process-name gensyms.
4398 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4400 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4401 to avoid potential buffer overrun.
4403 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4404 if X resource line is longer than 512 bytes.
4406 * xfns.c (x_window): Make sprintf buffer a bit bigger
4407 to avoid potential buffer overrun.
4409 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4411 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4413 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4415 Integer overflow fixes for scrolling, etc.
4416 Without these, Emacs silently mishandles large integers sometimes.
4417 For example, "C-u 4294967297 M-x recenter" was treated as if
4418 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4420 * xdisp.c (try_window_id): Check Emacs fixnum range before
4421 converting to 'int'.
4423 * window.c (window_scroll_line_based, Frecenter):
4424 Check that an Emacs fixnum is in range before assigning it to 'int'.
4425 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4426 values converted from Emacs fixnums.
4427 (Frecenter): Don't wrap around a line count if it is out of 'int'
4428 range; instead, treat it as an extreme value.
4429 (Fset_window_configuration, compare_window_configurations):
4430 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4432 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4433 that can exceed INT_MAX. Check that EMACS_INT value is in range
4434 before assigning it to the (possibly-narrower) index.
4435 (match_limit): Don't assume that a fixnum can fit in 'int'.
4437 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4440 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4441 (Fvertical_motion): Don't wrap around LINES values that don't fit
4442 in 'int'. Instead, treat them as extreme values. This is good
4443 enough for windows, which can't have more than INT_MAX lines anyway.
4445 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4447 * Require libxml/parser.h to avoid compilation warning.
4449 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4451 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4452 since this reportedly can destroy thread storage.
4454 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4456 * syntax.c (find_defun_start): Update all cache variables if
4457 exiting early (Bug#9401).
4459 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4461 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4463 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4464 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4465 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4467 * term.c (tty_append_glyph): New function.
4468 (produce_stretch_glyph): Static function and its prototype deleted.
4470 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4473 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4475 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4476 when checking :margin (Bug#9390).
4477 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4478 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4479 so that the name doesn't mislead. All uses changed.
4481 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4483 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4486 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4488 * xdisp.c (move_it_to): Don't bail out early when reaching
4489 position beyond to_charpos, if we are scanning backwards.
4490 (move_it_vertically_backward): When DY == 0, make sure we get to
4491 the first character in the line after the newline.
4493 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4495 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4496 (ccl_driver): Do not generate an out-of-range pointer.
4497 (Fccl_execute_on_string): Remove unnecessary check for
4498 integer overflow, noted by Stefan Monnier in
4499 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4500 Remove a FIXME that didn't need fixing.
4501 Simplify the newly-introduced buffer reallocation code.
4503 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4505 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4507 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4509 Integer and memory overflow issues (Bug#9196).
4511 * doc.c (get_doc_string): Rework so that
4512 get_doc_string_buffer_size is the actual buffer size, rather than
4513 being 1 less than the actual buffer size; this makes xpalloc more
4516 * image.c (x_allocate_bitmap_record, cache_image):
4517 * xselect.c (Fx_register_dnd_atom):
4518 Simplify previous changes by using xpalloc.
4520 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4521 since either will do and ptrdiff_t is convenient with xpalloc.
4523 * charset.c (charset_table_size)
4524 (struct charset_sort_data.priority): Now ptrdiff_t.
4525 (charset_compare): Don't overflow if priorities differ greatly.
4526 (Fsort_charsets): Don't assume list length fits in int.
4527 Check for size-calculation overflow when allocating sort data.
4528 (syms_of_charset): Allocate an initial charset table that is
4529 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4531 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4533 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4534 The actual value is always <= INT_MAX, and leaving it unsigned made
4535 overflow checking harder.
4537 * dispextern.h (struct glyph_matrix.rows_allocated)
4538 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4539 with xpalloc. The values are still always <= INT_MAX.
4541 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4543 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4544 (SAFE_NALLOCA): New macro.
4546 * region-cache.c (struct boundary.pos, find_cache_boundary)
4547 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4548 (set_cache_region, invalidate_region_cache)
4549 (revalidate_region_cache, know_region_cache, region_cache_forward)
4550 (region_cache_backward, pp_cache):
4551 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4552 so that ptrdiff_t * can be passed to xpalloc.
4553 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4554 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4555 (pp_cache): Don't assume cache_len fits in int.
4556 * region-cache.h: Adjust extern decls to match.
4558 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4559 EMACS_INT, since either will do, for xpalloc.
4561 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4562 (xnmalloc, xnrealloc, xpalloc): New functions.
4564 * bidi.c (bidi_shelve_header_size): New constant.
4565 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4566 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4568 * bidi.c (bidi_cache_shrink):
4569 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4571 Don't update size of array until after memory allocation succeeds,
4572 because xmalloc/xrealloc may not return.
4573 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4574 now that we have proper integer overflow checking.
4575 (record_overlay_string, overlay_strings): Catch overflows when
4576 calculating size of overlay_str_buf.
4578 * callproc.c (Fcall_process): Check for size overflow when
4579 calculating size of args2.
4580 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4581 Normally we prefer signed values, but sticking with ptrdiff_t would
4582 require adding more-complicated checks.
4584 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4585 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4586 Redo buffer-overflow calculations to avoid integer overflow.
4587 Add a FIXME comment where memory seems to be over-allocated.
4589 * character.c (Fstring): Check for size-calculation overflow.
4591 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4592 unnecessary integer overflow. Check for size overflow.
4593 (encode_coding_object): Don't update size until xmalloc succeeds.
4595 * composite.c (get_composition_id): Check for overflow in glyph
4596 length calculations.
4598 Integer and memory overflow fixes for display code.
4599 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4600 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4601 (scrolling_window): Check for overflow in size calculations.
4602 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4603 Don't assume glyph table len fits in int.
4604 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4605 (row_table_size): Now ptrdiff_t, not int.
4606 (scrolling_window): Avoid overflow in size calculations.
4607 Don't update size until allocation succeeds.
4608 * fns.c (concat): Check for overflow in size calculations.
4609 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4610 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4611 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4613 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4614 (get_doc_string): Check for size calculation overflow.
4615 Don't update size until allocation succeeds.
4616 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4617 EMACS_INT, where ptrdiff_t will do.
4618 (Fsubstitute_command_keys): Check for string overflow.
4620 * editfns.c (set_time_zone_rule): Don't assume environment length
4622 (message_length): Now ptrdiff_t, not int.
4623 (Fmessage_box): Don't update size until allocation succeeds.
4624 Don't assume message length fits in int.
4625 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4627 * emacs.c (main): Do not reallocate argv, since there is a null at
4628 the end that can be overwritten, and this way there's no need to
4629 worry about size-calculation overflow.
4630 (sort_args): Check for size-calculation overflow.
4632 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4634 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4636 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4637 (x_set_scroll_bar_width, x_figure_window_size):
4638 Check for integer overflow.
4639 (x_set_alpha): Do not assume XINT fits in int.
4641 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4642 This is for the members text_lines, text_cols, total_lines, total_cols,
4643 where the system imposes an 'int' limit.
4645 * fringe.c (Fdefine_fringe_bitmap):
4646 Don't update size until alloc works.
4648 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4649 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4651 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4652 Check for size-calculation overflow.
4653 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4654 do, as we prefer signed integers.
4655 (id_to_widget.max_size, id_to_widget.used)
4656 (xg_store_widget_in_map, xg_remove_widget_from_map)
4657 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4658 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4659 Use and return ptrdiff_t, not int.
4660 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4661 * gtkutil.h: Change prototypes to match the above.
4663 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4664 are duplicate now that they've been promoted to lisp.h.
4665 (x_allocate_bitmap_record, x_alloc_image_color)
4666 (make_image_cache, cache_image, xpm_load):
4667 Don't update size until alloc is done.
4668 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4670 Check for size calculation overflow.
4671 (ct_colors_allocated_max): New constant.
4672 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4675 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4676 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4677 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4678 Use ptrdiff_t, not int, to count maps.
4679 (read_char_minibuf_menu_prompt): Check for overflow in size
4680 calculations. Don't update size until allocation succeeds.
4681 Redo calculations to avoid overflow.
4682 * keyboard.h: Change prototypes to match the above.
4684 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4686 (current_minor_maps): Check for size calculation overflow.
4687 * keymap.h: Change prototypes to match the above.
4689 * lread.c (read1, init_obarray): Don't update size until alloc done.
4691 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4692 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4694 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4695 Now ptrdiff_t, not int.
4696 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4697 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4699 * process.c (Fnetwork_interface_list): Check for overflow
4700 in size calculation.
4702 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4704 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4705 overflow. Don't bother calling xmalloc when xrealloc will do.
4707 * search.c (Freplace_match): Check for size calculation overflow.
4708 (Fset_match_data): Don't assume list lengths fit in 'int'.
4710 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4711 for command line length. Do not attempt to address one before the
4712 beginning of an array, as that's not portable.
4714 * term.c (max_frame_lines): Remove; unused.
4715 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4717 (encode_terminal_code, calculate_costs): Check for size
4718 calculation overflow.
4719 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4720 table lengths and related sizes. Don't update size until alloc
4721 done. Redo calculations to avoid overflow.
4722 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4724 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4725 subtracting pointers.
4726 (gobble_line): Check for overflow more carefully. Don't update size
4729 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4730 Don't update size until alloc done.
4731 Redo size calculations to avoid overflow.
4732 Check for size calculation overflow.
4733 (main) [DEBUG]: Fix typo in invoking tparam1.
4735 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4736 Use ptrdiff_t, not int, for sizes.
4737 (store_mode_line_noprop_char): Don't update size until alloc done.
4739 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4740 Use ptrdiff_t, not int, for sizes.
4741 (Finternal_make_lisp_face, cache_face):
4742 Check for size calculation overflow.
4743 (cache_face): Treat size calculation overflows as if they were
4744 memory exhaustion (the usual treatment), rather than aborting.
4746 * xfns.c (x_encode_text, x_set_name_internal)
4747 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4748 sizes, since they can exceed INT_MAX in size. Check for size
4749 calculation overflow.
4751 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4752 (xg_select): Check for size calculation overflow.
4753 Don't update size until alloc done.
4755 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4756 as sprintf is limited to int lengths.
4758 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4759 (X_LONG_MIN): New macros.
4760 Use them to make the following changes clearer.
4761 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4762 This change doesn't affect the value now, but it may help remind
4763 future maintainers not to raise the value too much later.
4764 (SELECTION_QUANTUM): Remove, replacing with ...
4765 (selection_quantum): ... new function, which avoids overflow.
4767 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4768 assumption that selection length fits in 'int'.
4769 (x_reply_selection_request, x_handle_selection_request)
4770 (x_get_window_property, receive_incremental_selection)
4771 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4772 (lisp_data_to_selection_data, clean_local_selection_data):
4773 Use ptrdiff_t, not int, to record length of selection.
4774 (x_reply_selection_request, x_get_window_property)
4775 (receive_incremental_selection, x_property_data_to_lisp):
4776 Redo calculations to avoid overflow.
4777 (x_reply_selection_request): When sending hint, ceiling it at
4778 X_LONG_MAX rather than relying on wraparound overflow to send
4780 (x_get_window_property, receive_incremental_selection)
4781 (lisp_data_to_selection_data, x_property_data_to_lisp):
4782 Check for size-calculation overflow.
4783 (x_get_window_property, receive_incremental_selection)
4784 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4785 Don't store size until memory allocation succeeds.
4786 (x_get_window_property): Plug memory leak on memory exhaustion.
4787 Don't double-block input; malloc is safe here. Don't assume 2**34
4788 - 4 fits in unsigned long. Add an xassert to check
4789 XGetWindowProperty overflow. Be more careful about overflow
4790 calculations, and distinguish size from memory overflow better.
4791 (receive_incremental_selection): When tracing, don't assume
4792 unsigned int is less than INT_MAX.
4793 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4794 harmful) conversions of unsigned short to int.
4795 (lisp_data_to_selection_data): Don't assume that integers
4796 in the range -65535 through -1 fit in an X unsigned short.
4797 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4798 result parameters unless successful. Rely on cons_to_unsigned
4799 to report problems with elements; the old code wasn't right anyway.
4800 (x_check_property_data): Check for int overflow; we cannot use
4801 a wider type due to X limits.
4802 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4804 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4806 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4807 (x_term_init): Check for size calculation overflow.
4808 (x_color_cells): Don't store size until memory allocation succeeds.
4809 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4810 Don't assume alloca size is less than MAX_ALLOCA.
4811 (x_term_init): Don't assume length fits in int (sprintf is limited
4814 Use ptrdiff_t for composition IDs.
4815 * character.c (lisp_string_width):
4816 * composite.c (composition_table_size, n_compositions)
4817 (get_composition_id, composition_gstring_from_id):
4818 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4819 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4820 * window.c (Frecenter):
4821 Use ptrdiff_t, not int, for composition IDs.
4822 * composite.c (get_composition_id): Check for integer overflow.
4823 * composite.h: Adjust prototypes to match the above changes.
4825 Use ptrdiff_t for hash table indexes.
4826 * category.c (hash_get_category_set):
4827 * ccl.c (ccl_driver):
4828 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4829 * coding.c (coding_system_charset_list, detect_coding_system):
4830 * coding.h (struct coding_system.id):
4831 * composite.c (get_composition_id, gstring_lookup_cache):
4832 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4833 * image.c (xpm_get_color_table_h):
4834 * lisp.h (hash_lookup, hash_put):
4835 * minibuf.c (Ftest_completion):
4836 Use ptrdiff_t for hash table indexes, not int (which is too
4837 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4838 32-bit --with-wide-int hosts).
4840 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4841 Add a FIXME comment about memory leaks.
4842 (syms_of_charset): Don't assume xmalloc returns.
4844 Don't assume that stated character widths fit in int.
4845 * character.c (Fchar_width, c_string_width, lisp_string_width):
4846 * character.h (CHAR_WIDTH):
4847 * indent.c (MULTIBYTE_BYTES_WIDTH):
4848 Use sanitize_char_width to avoid undefined and/or bad behavior
4849 with outlandish widths.
4850 * character.h (sanitize_tab_width): Rename from sanitize_width,
4851 now that we have two such functions. All uses changed.
4852 (sanitize_char_width): New inline function.
4854 Don't assume that tab-width fits in int.
4855 * character.h (sanitize_width): New inline function.
4856 (SANE_TAB_WIDTH): New macro.
4857 (ASCII_CHAR_WIDTH): Use it.
4858 * indent.c (sane_tab_width): Remove. All uses replaced by
4859 SANE_TAB_WIDTH (current_buffer).
4860 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4862 * fileio.c: Integer overflow issues with file modes.
4863 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4865 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4866 Remove unreachable code.
4867 (read_hex, load_charset_map_from_file): Check for integer overflow.
4869 * xterm.c: Don't go over XClientMessageEvent limit.
4870 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4871 (x_send_scroll_bar_event): Likewise. Check that the size does not
4872 exceed limits imposed by XClientMessageEvent, as well as the usual
4873 ptrdiff_t and size_t limits.
4875 * keyboard.c: Overflow, signedness and related fixes.
4876 (make_lispy_movement): Use same integer type in forward decl
4877 that is used in the definition.
4878 (read_key_sequence, keyremap_step):
4879 Change bufsize argument back to int, undoing my 2011-03-30 change.
4880 We prefer signed types, and int is wide enough here.
4881 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4882 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4883 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4884 length, not size_t. Use ptrdiff_t for index, not int.
4885 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4886 possibility of integer overflow.
4888 Overflow, signedness and related fixes for images.
4890 * dispextern.h (struct it.stack[0].u.image.image_id)
4891 (struct_it.image_id, struct image.id, struct image_cache.size)
4892 (struct image_cache.used, struct image_cache.ref_count):
4893 * gtkutil.c (update_frame_tool_bar):
4894 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4895 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4896 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4897 * nsmenu.m (update_frame_tool_bar):
4898 * xdisp.c (calc_pixel_width_or_height):
4899 * xfns.c (image_cache_refcount):
4900 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4901 on typical 64-bit hosts.
4903 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4904 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4905 Omit unnecessary casts to int.
4906 (parse_image_spec): Check that integers fall into 'int' range
4907 when the callers expect that.
4908 (image_ascent): Redo ascent calculation to avoid int overflow.
4909 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4910 (lookup_image): Remove unnecessary tests.
4911 (xbm_image_p): Locals are now of int, not EMACS_INT,
4912 since parse_image_check makes sure they fit into int.
4913 (png_load, gif_load, svg_load_image):
4914 Prefer int to unsigned where either will do.
4915 (tiff_handler): New function, combining the cores of the
4916 old tiff_error_handler and tiff_warning_handler.
4917 This function is rewritten to use vsnprintf and thereby avoid
4918 stack buffer overflows. It uses only the features of vsnprintf
4919 that are common to both POSIX and native Microsoft.
4920 (tiff_error_handler, tiff_warning_handler): Use it.
4921 (tiff_load, gif_load, imagemagick_load_image):
4922 Don't assume :index value fits in 'int'.
4923 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4924 (imagemagick_load_image): Check that crop parameters fit into
4925 the integer types that MagickCropImage accepts. Don't assume
4926 Vimagemagick_render_type has a nonnegative value. Don't assume
4927 size_t fits in 'long'.
4928 (gs_load): Use printmax_t to print the widest integers possible.
4929 Check for integer overflow when computing image height and width.
4931 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4933 * xdisp.c (redisplay_window): Don't force window start if point
4934 will be invisible in the resulting window. (Bug#9324)
4936 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4938 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4939 the display spec is of the form `(space ...)'.
4940 (handle_display_spec): Return the value returned by
4941 handle_single_display_spec, not just 1 or zero.
4942 (handle_single_display_spec): If the display spec is of the form
4943 `(space ...)', and specifies display in the text area, return 2
4945 (try_cursor_movement): Check for the need to scroll more
4946 accurately, and prefer exact match for point under bidi.
4947 Don't advance `row' beyond the last row of the window.
4949 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4950 into disp_prop; all users changed.
4952 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4953 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4954 for the text covered by the display property.
4956 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4958 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4959 Change return value to nil.
4960 (Frecord_buffer): Delete unused function.
4962 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4964 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4965 buffers, return left-to-right.
4966 (set_cursor_from_row): Consider candidate row a win if its glyph
4967 represents a newline and point is on that newline. Fixes cursor
4968 positioning on the newline at EOL of R2L text within L2R
4969 paragraph, and vice versa.
4970 (try_cursor_movement): Check continued rows, in addition to
4971 continuation rows. Fixes unwarranted scroll when point enters a
4972 continued line of R2L text within an L2R paragraph, or vice versa.
4973 (cursor_row_p): Consider the case of point being equal to
4974 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4975 from the end of a short line to the beginning of a continued line
4976 of R2L text within L2R paragraph.
4977 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4978 composed characters.
4980 * bidi.c (bidi_check_type): Use xassert.
4981 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4984 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4986 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4989 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4991 * nsfont.m (ns_otf_to_script): Fix typo.
4993 2011-08-22 Kenichi Handa <handa@m17n.org>
4995 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4996 extra slot even if the purpose is char-code-property-table.
4998 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5000 * xdisp.c (redisplay_window): When computing centering_position,
5001 account for the height of the header line. (Bug#8874)
5003 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5004 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5005 candidate is selected by the mouse, and that candidate has a
5006 composed character under the mouse.
5008 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5009 coordinates reported by pos-visible-in-window-p for a composed
5010 character in column zero.
5012 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5014 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5016 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5018 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5019 consider it a hit if to_charpos is anywhere in the range of the
5020 composed buffer positions.
5022 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5024 * image.c (gif_load): Don't assume that each subimage has the same
5025 dimensions as the base image. Handle disposal method that is
5026 "undefined" by the gif spec (Bug#9335).
5028 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5030 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5031 (Fcondition_case): Document `debug' symbol in error handler.
5033 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5035 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5036 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5037 from an Org mode buffer to a Speedbar frame.
5039 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5040 a composition, take its buffer position from IT->cmp_it.charpos.
5041 Fixes cursor positioning at the beginning of a line that begins
5042 with a composed character.
5044 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5046 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5047 character bidirectional type, use STRONG_L instead. Fixes crashes
5048 in a buffer produced by `describe-categories'.
5050 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5051 members before the level stack, so they would be saved and
5052 restored when copying iterator state. Fixes incorrect reordering
5053 around TABs covered by display properties.
5055 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5057 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5059 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5061 * eval.c (internal_condition_case, internal_condition_case_1)
5062 (internal_condition_case_2, internal_condition_case_n):
5063 Remove unnecessary aborts (Bug#9081).
5065 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5067 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5068 has no `load' handler, try opening the file locally. (Bug#9311)
5070 2011-08-16 Ken Brown <kbrown@cornell.edu>
5072 * gmalloc.c: Expand comment.
5074 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5076 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5077 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5079 2011-08-16 Ken Brown <kbrown@cornell.edu>
5081 Fix memory allocation problems in Cygwin build (Bug#9273).
5083 * unexcw.c ( __malloc_initialized): Declare external variable.
5084 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5086 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5088 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5090 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5092 [CYGWIN] (special_realloc): New function.
5093 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5094 requests to realloc storage in the static heap.
5096 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5098 * bidi.c (bidi_initialize): Remove unused local.
5100 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5103 * biditype.h: Remove file.
5104 * makefile.w32-in ($(BLD)/bidi.$(O)):
5105 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5107 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5109 * chartab.c: Improve commentary for the uniprop_table API.
5111 * bidi.c (bidi_paragraph_init): Support zero value of
5112 bidi_ignore_explicit_marks_for_paragraph_level.
5113 (bidi_initialize): Use uniprop_table instead of including
5114 biditype.h and bidimirror.h.
5116 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5117 coordinates of the iterator when restoring from ppos_it.
5120 2011-08-14 Kenichi Handa <handa@m17n.org>
5122 * process.c (create_process): Call setup_process_coding_systems
5123 after the pid of the process is set to -1 (Bug#8162).
5125 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5127 * xdisp.c (move_it_in_display_line_to): Don't invoke
5128 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5129 ppos_it. Fixes vertical cursor motion when line beginning is
5130 covered by an image. (Bug#9296)
5132 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5134 * nsterm.h (ns_run_ascript): Declare.
5135 (NSAPP_DATA2_RUNASSCRIPT): Define.
5137 * nsfns.m (as_script, as_result, as_status): New static variables.
5138 (ns_run_ascript): New function.
5139 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5140 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5141 the event loop. Get status from as_status (Bug#7276).
5143 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5144 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5145 the event loop (Bug#7276).
5147 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5149 * gnutls.c (QCgnutls_bootprop_priority)
5150 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5151 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5152 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5153 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5154 (QCgnutls_bootprop_verify_hostname_error)
5155 (QCgnutls_bootprop_callbacks_verify): Rename from
5156 Qgnutls_bootprop_..., all uses changed.
5158 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5161 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5163 * xfaces.c (Qframe_set_background_mode): Now static.
5164 * dispextern.h (Qframe_set_background_mode): Remove decl.
5166 * process.c (Fnetwork_interface_info): Declare local only if needed.
5168 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5170 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5171 (Fnetwork_interface_list): Allocate in increments of bytes instead
5172 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5173 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5175 (struct ifflag_def): notrailers is smart on OSX.
5176 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5177 Get hardware address with getifaddrs if available.
5179 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5181 * xdisp.c (iterate_out_of_display_property): xassert that
5182 IT->position is set to within IT->object's boundaries. Break from
5183 the loop as soon as EOB is reached; avoids infloops in redisplay
5184 when IT->position is set up wrongly due to some bug.
5185 Set IT->current to match the bidi iterator unconditionally.
5186 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5187 entry. Force push_it to save on the stack the current
5188 buffer/string position, to be restored by pop_it. Fix flags in
5189 the iterator structure wrt the object coming from a display
5190 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5191 properties. (Bug#9284)
5193 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5195 * fontset.c (fontset_get_font_group): Add proper type checks.
5198 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5200 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5201 and LC_VERSION_MIN_MACOSX.
5202 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5203 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5205 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5207 * xdisp.c (forward_to_next_line_start): Allow to use the
5208 no-display-properties-and-no-overlays under bidi display.
5209 Set disp_pos in the bidi iterator to avoid searches for display
5210 properties and overlays.
5212 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5214 * editfns.c (Fset_time_zone_rule): Document relationship with the
5217 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5218 the font entity extracted from the cache (Bug#8109).
5220 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5222 * composite.c (autocmp_chars): Don't reset point. That is done by
5223 restore_point_unwind (Bug#5984).
5225 2011-08-07 Juri Linkov <juri@jurta.org>
5227 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5228 to show the arg `TIME' instead of `TIMEVAL'.
5230 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5232 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5233 display property strides EOL and includes a newline, as in
5234 longlines-mode. (Bug#9254)
5235 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5236 word-wrap under bidirectional display. (Bug#9224)
5238 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5239 is non-zero, even if the data buffer is NULL. Fixes a crash in
5240 vertical-motion with longlines-mode. (Bug#9254)
5242 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5244 * bidi.c <bidi_cache_total_alloc>: Now static.
5245 (bidi_initialize): Initialize bidi_cache_total_alloc.
5247 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5250 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5251 amount allocated this far in `bidi_cache_total_alloc'.
5252 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5253 non-zero, only free the data buffer without restoring the cache
5254 contents. All callers changed.
5256 * dispextern.h (bidi_unshelve_cache): Update prototype.
5258 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5259 (move_it_in_display_line, move_it_to)
5260 (move_it_vertically_backward, move_it_by_lines): Replace the call
5261 to xfree to an equivalent call to bidi_unshelve_cache.
5262 (move_it_in_display_line_to): Fix logic of returning
5263 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5265 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5267 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5268 came from a string character with a `cursor' property. (Bug#9229)
5270 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5272 * Makefile.in (LIB_PTHREAD): New variable.
5273 (LIBES): Add LIB_PTHREAD (Bug#9216).
5275 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5276 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5278 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5280 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5282 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5284 * xterm.c (x_find_topmost_parent): New function.
5285 (x_set_frame_alpha): Find topmost parent window with
5286 x_find_topmost_parent and set the property there also (bug#9181).
5287 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5289 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5291 * callproc.c (Fcall_process): Avoid vfork clobbering
5292 the local vars buffer, coding_systems, current_dir.
5294 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5296 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5298 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5300 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5301 so that it is not optimized away.
5303 * xdisp.c (compute_display_string_pos): Remove unused local.
5305 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5307 Fix slow cursor motion and scrolling in large buffers with
5308 selective display, like Org Mode buffers. (Bug#9218)
5310 * dispextern.h (struct bidi_it): New member disp_prop_p.
5312 * xdisp.c: Remove one-slot cache of display string positions.
5313 (compute_display_string_pos): Accept an additional argument
5314 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5315 for a display string or property. If found, set DISP_PROP_P
5318 * bidi.c (bidi_fetch_char): Accept an additional argument
5319 DISP_PROP_P, and pass it to compute_display_string_pos.
5320 Only handle text covered by a display string if DISP_PROP_P is returned
5321 non-zero. All callers of bidi_fetch_char changed.
5323 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5325 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5327 2010-12-03 Don March <don@ohspite.net>
5329 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5330 last character M-[char] is translated to ESC [char] (bug#7541).
5332 2011-08-02 Kenichi Handa <handa@m17n.org>
5334 * lisp.h (uniprop_table): Extern it.
5336 * chartab.c (uniprop_table): Make it non-static.
5338 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5340 * xdisp.c (forward_to_next_line_start): Accept additional argument
5341 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5343 (reseat_at_next_visible_line_start): Use the bidi iterator state
5344 returned by forward_to_next_line_start to restore the state of
5345 it->bidi_it after backing up to previous newline. (Bug#9212)
5347 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5349 * regex.c (re_comp): Protoize.
5350 (re_exec): Fix return type.
5351 (regexec): Fix type of `ret'. (Bug#9203)
5353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5355 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5356 This is needed if max-image-size is a floating-point number.
5358 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5360 * print.c (print_object): Print empty symbol as ##.
5362 * lread.c (read1): Read ## as empty symbol.
5364 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5366 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5367 setting frame foreground color (Bug#9175).
5368 (x_set_background_color): Likewise.
5370 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5371 contents (Bug#9176).
5372 (EmacsTooltip -init): Remove bezels and add shadows to
5375 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5376 or scroll bar (Bug#8470).
5378 * nsfont.m (nsfont_open): Remove assignment to voffset and
5379 unnecessary vars hshink, expand, hd, full_height, min_height.
5380 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5382 * nsterm.h (nsfont_info): Remove voffset field.
5384 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5386 Implement strike-through and overline on NextStep (Bug#8863).
5388 * nsfont.m (nsfont_open): Use underline position provided by font,
5389 instead of hard-coded value of 2.
5390 (nsfont_draw): Call ns_draw_text_decoration instead.
5392 * nsterm.h: Add declaration for ns_draw_text_decoration.
5394 * nsterm.m (ns_draw_text_decoration): New function for drawing
5395 underline, overline, and strike-through.
5396 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5397 ns_draw_text_decoration. Change treatment of cursor drawing to
5398 accommodate underlining, etc.
5400 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5402 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5405 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5407 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5408 Without this fix, if a signal arrives just after memory fills up,
5409 'malloc' might be invoked reentrantly.
5411 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5412 In other words, assume that every image size is allowed, on non-X
5413 hosts. This assumption is probably wrong, but it lets Emacs compile.
5415 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5417 * regex.c (re_iswctype): Convert return values to boolean.
5419 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5421 * xdisp.c (compute_display_string_pos): Don't use cached display
5422 string position if the buffer had its restriction changed.
5425 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5427 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5429 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5431 Integer signedness and overflow and related fixes. (Bug#9079)
5433 * bidi.c: Integer size and overflow fixes.
5434 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5435 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5436 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5437 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5438 (bidi_find_other_level_edge):
5439 Use ptrdiff_t instead of EMACS_INT where either will do.
5440 This works better on 32-bit hosts configured --with-wide-int.
5441 (bidi_cache_ensure_space): Check for size-calculation overflow.
5442 Use % rather than repeated addition, for better worst-case speed.
5443 Don't set bidi_cache_size until after xrealloc returns, because it
5445 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5446 (bidi_cache_ensure_space): Also check that the bidi cache size
5447 does not exceed that of the largest Lisp string or buffer. See Eli
5448 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5450 * alloc.c (__malloc_size_t): Remove.
5451 All uses replaced by size_t. See Andreas Schwab's note
5452 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5454 * image.c: Improve checking for integer overflow.
5455 (check_image_size): Assume that f is nonnull, since
5456 it is always nonnull in practice. This is one less thing to
5457 worry about when checking for integer overflow later.
5458 (x_check_image_size): New function, which checks for integer
5459 overflow issues inside X.
5460 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5461 This removes the need for a memory_full check.
5462 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5463 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5464 (xbm_read_bitmap_data): Change locals back to 'int', since
5465 their values must fit in 'int'.
5466 (xpm_load_image, png_load, tiff_load):
5467 Invoke x_create_x_image_and_pixmap earlier,
5468 to avoid much needless work if the image is too large.
5469 (tiff_load): Treat overly large images as if
5470 x_create_x_image_and_pixmap failed, not as malloc failures.
5471 (gs_load): Use x_check_image_size.
5473 * gtkutil.c: Omit integer casts.
5474 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5475 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5477 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5479 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5480 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5481 would wrongly return t on a 64-bit host.
5483 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5484 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5485 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5486 and therefore cause GCC to emit a bogus diagnostic in some cases.
5488 * image.c: Integer signedness and overflow and related fixes.
5489 This is not an exhaustive set of fixes, but it's time to
5490 record what I've got.
5491 (lookup_pixel_color, check_image_size): Remove redundant decls.
5492 (check_image_size): Don't assume that arbitrary EMACS_INT values
5493 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5494 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5495 (tiff_load, imagemagick_load_image):
5496 Check for overflow in size calculations.
5497 (x_create_x_image_and_pixmap): Remove unnecessary test for
5498 xmalloc returning NULL; that can't happen.
5499 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5500 (xpm_color_bucket): Use better integer hashing function.
5501 (xpm_cache_color): Don't possibly over-allocate memory.
5502 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5503 (gif_memory_source):
5504 Use ptrdiff_t, not int or size_t, to record sizes.
5505 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5506 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5507 either works, as we prefer signed integers.
5508 (tiff_read_from_memory, tiff_write_from_memory):
5509 Return tsize_t, not size_t, since that's what the TIFF API wants.
5510 (tiff_read_from_memory): Don't fail simply because the read would
5511 go past EOF; instead, return a short read.
5512 (tiff_load): Omit no-longer-needed casts.
5513 (Fimagemagick_types): Don't assume size fits into 'int'.
5515 Improve hashing quality when configured --with-wide-int.
5516 * fns.c (hash_string): New function, taken from sxhash_string.
5517 Do not discard information about ASCII character case; this
5518 discarding is no longer needed.
5519 (sxhash-string): Use it. Change sig to match it. Caller changed.
5520 * lisp.h: Declare it.
5521 * lread.c (hash_string): Remove, since we now use fns.c's version.
5522 The fns.c version returns a wider integer if --with-wide-int is
5523 specified, so this should help the quality of the hashing a bit.
5525 * emacs.c: Integer overflow minor fix.
5526 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5527 Define only if GNU_LINUX.
5528 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5530 * dispnew.c: Integer signedness and overflow fixes.
5531 Remove unnecessary forward decls, that were a maintenance hassle.
5532 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5534 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5535 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5536 (prepare_desired_row, line_draw_cost):
5537 Use int, not unsigned, where either works.
5538 (save_current_matrix, restore_current_matrix):
5539 Use ptrdiff_t, not size_t, where either works.
5540 (init_display): Check for overflow more accurately, and without
5541 relying on undefined behavior.
5543 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5544 Remove, replacing with the new symbols in lisp.h. All uses changed.
5545 * fileio.c (make_temp_name):
5546 * filelock.c (lock_file_1, lock_file):
5547 * xdisp.c (message_dolog):
5548 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5549 Use pMd etc. instead.
5550 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5551 replacing the pWIDE etc. symbols removed from editfns.c.
5553 * keyboard.h (num_input_events): Now uintmax_t.
5554 This is (very slightly) less likely to mess up due to wraparound.
5557 * buffer.c: Integer signedness fixes.
5558 (alloc_buffer_text, enlarge_buffer_text):
5559 Use ptrdiff_t rather than size_t when either will do, as we prefer
5562 * alloc.c: Integer signedness and overflow fixes.
5563 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5564 (__malloc_size_t): Default to size_t, not to int.
5565 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5566 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5567 Prefer ptrdiff_t to size_t when either would do, as we prefer
5569 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5570 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5571 Now const. Initialize with values that are in range even if char
5573 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5574 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5575 These functions do the right thing with sizes > 2**32.
5576 (check_depth): Now ptrdiff_t, not int.
5577 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5578 Adjust to new way of storing sizes. Check for size overflow bugs
5580 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5581 slightly wrong anyway, as it missed one instance of
5582 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5583 (refill_memory_reserve): Omit needless cast to size_t.
5584 (mark_object_loop_halt): Mark as externally visible.
5586 * xselect.c: Integer signedness and overflow fixes.
5587 (Fx_register_dnd_atom, x_handle_dnd_message):
5588 Use ptrdiff_t, not size_t, since we prefer signed.
5589 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5590 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5591 x_dnd_atoms_size and x_dnd_atoms_length.
5593 * doprnt.c: Prefer signed to unsigned when either works.
5595 * doprnt.c (doprnt):
5597 * xdisp.c (vmessage):
5598 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5599 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5600 prefer signed arithmetic to avoid comparison confusion.
5601 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5602 but is a bit tricky.
5604 Assume freestanding C89 headers, string.h, stdlib.h.
5605 * data.c, doprnt.c, floatfns.c, print.c:
5606 Include float.h unconditionally.
5607 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5608 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5609 * regex.c: Likewise for stddef.h, string.h.
5610 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5611 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5612 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5613 (STDC_HEADERS): Remove obsolete defines.
5614 * sysdep.c: Include limits.h unconditionally.
5616 Assume support for memcmp, memcpy, memmove, memset.
5617 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5618 * regex.c (memcmp, memcpy):
5619 Remove; we assume C89 now.
5621 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5622 (__malloc_safe_bcopy): Remove; no longer needed.
5624 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5625 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5626 well either way, and we prefer signed to unsigned.
5628 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5630 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5631 closes the connection while we're reading (bug#9182).
5633 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5635 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5636 are specified (Bug#9168).
5638 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5640 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5641 Found by GCC static checking and --with-wide-int on a 32-bit host.
5643 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5645 * xdisp.c (compute_display_string_pos): Fix logic of caching
5646 previous display string position. Initialize cached_prev_pos to
5647 -1. Fixes slow-down at the beginning of a buffer.
5649 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5651 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5652 for attrs[LFACE_FONTSET_INDEX].
5654 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5656 * xml.c (parse_region): Remove unused local
5657 that was recently introduced.
5659 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5661 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5662 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5664 * xdisp.c (move_it_in_display_line_to): Record the best matching
5665 position for TO_CHARPOS while scanning the line, and restore it on
5666 exit if none of the characters scanned was an exact match.
5667 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5668 when exact match is impossible due to invisible text, and the
5669 lines are truncated.
5671 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5673 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5676 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5678 Fix a significant slow-down of cursor motion with C-n, C-p,
5679 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5680 auto-repeat under bidi redisplay in fontified buffers.
5681 * xdisp.c (compute_stop_pos_backwards): New function.
5682 (next_element_from_buffer): Call compute_stop_pos_backwards to
5683 find a suitable prev_stop when we find ourselves before
5685 (reseat): Don't look for prev_stop, as that could mean a very long
5687 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5688 <cached_disp_overlay_modiff>: Cache for last found display string
5690 (compute_display_string_pos): Return the cached position if asked
5691 about the same buffer in the same area of character positions, and
5692 the buffer wasn't changed since the time the display string
5693 position was cached.
5695 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5697 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5698 is an integer, which is important for empty lines. (Bug#9149)
5700 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5702 * frame.c (Fmodify_frame_parameters): In tty case, update the
5703 default face if necessary (Bug#4238).
5705 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5707 * editfns.c (Fstring_to_char): No need to explain what a character
5708 is in the docstring (Bug#6576).
5710 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5712 * xml.c (parse_region): Make sure we always return a tree.
5714 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5716 * xml.c (parse_region): If a document contains only comments,
5719 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5721 * xml.c (make_dom): Return comments, too.
5723 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5726 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5727 and the surrounding thread.
5728 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5729 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5730 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5732 * s/openbsd.h (BROKEN_SIGIO): Define.
5733 * unexelf.c (unexec) [__OpenBSD__]:
5734 Don't update the .mdebug section of the Alpha COFF symbol table.
5736 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5738 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5741 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5743 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5744 This fixes some race conditions on the permissions of any newly
5747 * alloc.c (valid_pointer_p): Use pipe, not open.
5748 This fixes some permissions issues when debugging.
5750 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5751 If fchown fails to set both uid and gid, try to set just gid,
5752 as that is sometimes allowed. Adjust the file's mode to eliminate
5753 setuid or setgid bits that are inappropriate if fchown fails.
5755 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5757 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5758 to compare Lisp_Objects.
5759 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5760 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5761 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5763 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5765 * lread.c (read_integer): Unread even EOF character.
5766 (read1): Likewise. Properly record start position of symbol.
5768 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5769 symbol character follows.
5771 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5773 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5774 This works around a problem with the previous change to Fcopy_file.
5775 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5776 and without this change, GCC might complain about discarding
5777 fchown's return value.
5779 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5781 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5783 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5785 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5787 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5789 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5790 it's used from the C level.
5792 * process.c: Use the same condition for POLL_FOR_INPUT in both
5793 keyboard.c and process.c (bug#1858).
5795 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5797 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5798 (Fgnutls_boot): Use it.
5800 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5802 * doc.c (Fsubstitute_command_keys): Revert last change.
5804 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5806 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5807 quotes the next character, and doesn't affect other longer
5808 sequences (bug#8935).
5810 * lread.c (syms_of_lread): Clarify that is isn't only
5811 `eval-buffer' and `eval-defun' that's affected by
5812 `lexical-binding' (bug#8460).
5814 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5816 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5817 bidi redisplay when a line includes both an image and is truncated.
5819 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5821 Fix minor problems found by static checking.
5822 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5823 (elsz): Now a signed constant, not a size_t var. We prefer signed
5824 types to unsigned, to avoid integer comparison confusion. Without
5825 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5826 "cannot optimize loop, the loop counter may overflow", a symptom
5828 * indent.c (Fvertical_motion): Mark locals as initialized.
5829 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5831 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5833 * search.c (Fre_search_backward): Mention `case-fold-search' in
5834 all the re_search_* functions (bug#8138).
5836 * keyboard.c (Fopen_dribble_file): Document when the file is
5839 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5841 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5844 Support bidi reordering of display and overlay strings.
5845 * xdisp.c (compute_display_string_pos)
5846 (compute_display_string_end): Accept additional argument STRING.
5847 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5848 (reseat_to_string): Initialize bidi_it->string.s and
5849 bidi_it->string.schars.
5850 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5851 NULL (avoids a crash in bidi_paragraph_init).
5852 Initialize itb.string.lstring.
5853 (init_iterator): Call bidi_init_it only of a valid
5854 buffer position was specified. Initialize paragraph_embedding to
5856 (reseat_to_string): Initialize the bidi iterator.
5857 (display_string): If we need to ignore text properties of
5858 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5859 original value of -1 will not work with bidi.)
5860 (compute_display_string_pos): First arg is now struct
5861 `text_pos *'; all callers changed. Support display properties on
5863 (compute_display_string_end): Support display properties on Lisp
5865 (init_iterator, reseat_1, reseat_to_string): Initialize the
5866 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5867 when iterating on a string not from display properties).
5868 (compute_display_string_pos, compute_display_string_end):
5869 Fix calculation of the object to scan. Fixes an error when using
5871 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5872 base_level_stop; instead, set base_level_stop to BEGV.
5873 Fixes crashes in vertical-motion.
5874 (next_element_from_buffer): Improve commentary for when
5875 the iterator is before prev_stop.
5876 (init_iterator): Initialize bidi_p from the default value of
5877 bidi-display-reordering, not from buffer-local value. Use the
5878 buffer-local value only if initializing for buffer iteration.
5879 (handle_invisible_prop): Support invisible properties on strings
5880 that are being bidi-reordered.
5881 (set_iterator_to_next): Support bidi reordering of C strings and
5883 (next_element_from_string): Support bidi reordering of Lisp
5885 (handle_stop_backwards): Support Lisp strings as well.
5886 (display_string): Support display of R2L glyph rows.
5887 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5888 (init_iterator): Don't initialize it->bidi_p for strings
5890 (reseat_to_string): Initialize it->bidi_p for strings here.
5891 (next_element_from_string, next_element_from_c_string)
5892 (next_element_from_buffer): Add xassert's for correspondence
5893 between IT's object being iterated and it->bidi_it.string
5895 (face_before_or_after_it_pos): Support bidi iteration.
5896 (next_element_from_c_string): Handle the case of the first string
5897 character that is not the first one in the visual order.
5898 (get_visually_first_element): New function, refactored from common
5899 parts of next_element_from_buffer, next_element_from_string, and
5900 next_element_from_c_string.
5901 (tool_bar_lines_needed, redisplay_tool_bar)
5902 (display_menu_bar): Force left-to-right direction. Add a FIXME
5903 comment for making that be controlled by a user option.
5904 (push_it, pop_it): Save and restore the state of the
5905 bidi iterator. Save and restore the bidi_p flag.
5906 (pop_it): Iterate out of display property for string iteration as
5908 (iterate_out_of_display_property): Support iteration over strings.
5909 (handle_single_display_spec): Set up it->bidi_it for iteration
5910 over a display string, and call bidi_init_it.
5911 (handle_single_display_spec, next_overlay_string)
5912 (get_overlay_strings_1, push_display_prop): Set up the bidi
5913 iterator for displaying display or overlay strings.
5914 (forward_to_next_line_start): Don't use the shortcut if
5916 (back_to_previous_visible_line_start): If handle_display_prop
5917 pushed the iterator stack, restore the internal state of the bidi
5918 iterator by calling bidi_pop_it same number of times.
5919 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5920 and we are bidi-iterating, don't decrement the iterator position;
5921 instead, set the first_elt flag in the bidi iterator, to produce
5923 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5924 (push_display_prop): xassert that we are iterating a buffer.
5925 (push_it, pop_it): Save and restore paragraph_embedding member.
5926 (handle_single_display_spec, next_overlay_string)
5927 (get_overlay_strings_1, reseat_1, reseat_to_string)
5928 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5929 correctly. Don't assume unibyte strings are not bidi-reordered.
5930 (compute_display_string_pos)
5931 (compute_display_string_end): Fix handling the case of C string.
5932 (push_it, pop_it): Save and restore from_disp_prop_p.
5933 (handle_single_display_spec, push_display_prop): Set the
5934 from_disp_prop_p flag.
5935 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5936 (pop_it): Call iterate_out_of_display_property only if we are
5937 popping after iteration over a string that came from a display
5938 property. Fix a typo in popping stretch info. Add an assertion
5939 for verifying that the iterator position is in sync with the bidi
5941 (handle_single_display_spec, get_overlay_strings_1)
5942 (push_display_prop): Fix initialization of paragraph direction for
5943 string when that of the parent object is not yet determined.
5944 (reseat_1): Call bidi_init_it to resync the bidi
5945 iterator with IT's position. (Bug#7616)
5946 (find_row_edges): If ROW->start.pos gives position
5947 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5948 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5949 Reset the from_disp_prop_p flag.
5950 (SAVE_IT, RESTORE_IT): New macros.
5951 (pos_visible_p, face_before_or_after_it_pos)
5952 (back_to_previous_visible_line_start)
5953 (move_it_in_display_line_to, move_it_in_display_line)
5954 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5955 (try_scrolling, redisplay_window, display_line): Use them when
5956 saving a temporary copy of the iterator and restoring it back.
5957 (back_to_previous_visible_line_start, reseat_1)
5958 (init_iterator): Empty the bidi cache "stack".
5959 (move_it_in_display_line_to): If iterator ended up at
5960 EOL, but we never saw any buffer positions smaller than
5961 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5962 motion in bidi-reordered lines.
5963 (move_it_in_display_line_to): Record prev_method and prev_pos
5964 immediately before the call to set_iterator_to_next. Fixes cursor
5965 motion in bidi-reordered lines with stretch glyphs and strings
5966 displayed in margins. (Bug#8133) (Bug#8867)
5967 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5969 (pos_visible_p): Support positions in bidi-reordered lines.
5970 Save and restore bidi cache.
5972 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5973 (bidi_paragraph_info): Delete unused struct.
5974 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5975 (bidi_cache_start): New variable.
5976 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5978 (bidi_cache_fetch_state, bidi_cache_search)
5979 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5980 (bidi_cache_find, bidi_peek_at_next_level)
5981 (bidi_level_of_next_char, bidi_find_other_level_edge)
5982 (bidi_move_to_visually_next): Compare cache index with
5983 bidi_cache_start rather than with zero.
5984 (bidi_fetch_char): Accept new argument STRING; all callers
5985 changed. Support iteration over a string. Support strings with
5986 display properties. Support unibyte strings. Fix the type of
5987 `len' according to what STRING_CHAR_AND_LENGTH expects.
5988 (bidi_paragraph_init, bidi_resolve_explicit_1)
5989 (bidi_resolve_explicit, bidi_resolve_weak)
5990 (bidi_level_of_next_char, bidi_move_to_visually_next):
5991 Support iteration over a string.
5992 (bidi_set_sor_type, bidi_resolve_explicit_1)
5993 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5994 can now be zero (for strings); special values 0 and -1 were
5995 changed to -1 and -2, respectively.
5996 (bidi_char_at_pos): New function.
5997 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5998 Call it instead of FETCH_MULTIBYTE_CHAR.
5999 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6000 initialized to valid values.
6001 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6003 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6004 the test for valid cached positions. Fix the logic for looking up
6005 the sentinel state in the cache. GCPRO the Lisp string we are
6007 (bidi_push_it, bidi_pop_it): New functions.
6008 (bidi_initialize): Initialize the bidi cache start stack pointer.
6009 (bidi_cache_ensure_space): New function, refactored from part of
6010 bidi_cache_iterator_state. Don't assume the required size is just
6011 one BIDI_CACHE_CHUNK away.
6012 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6013 (bidi_count_bytes, bidi_char_at_pos): New functions.
6014 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6015 always valid if bidi_cache_idx is valid.
6016 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6017 is valid if it's going to be used.
6018 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6019 (bidi_cache_fetch_state, bidi_cache_search)
6020 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6021 (bidi_cache_iterator_state, bidi_cache_find)
6022 (bidi_find_other_level_edge, bidi_cache_start_stack):
6023 All variables related to cache indices are now EMACS_INT.
6025 * dispextern.h (struct bidi_string_data): New structure.
6026 (struct bidi_it): New member `string'. Make flag members be 1-bit
6027 fields, and put them last in the struct.
6028 (compute_display_string_pos, compute_display_string_end):
6030 (bidi_push_it, bidi_pop_it): Add prototypes.
6031 (struct iterator_stack_entry): New members bidi_p,
6032 paragraph_embedding, and from_disp_prop_p.
6033 (struct it): Member bidi_p is now a bit field 1 bit wide.
6034 (bidi_shelve_cache, bidi_unshelve_cache):
6037 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6038 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6039 and vector-like objects.
6041 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6042 cache around display iteration.
6044 * window.c (Fwindow_end, window_scroll_pixel_based)
6045 (displayed_window_lines, Frecenter): Save and restore the bidi
6046 cache around display iteration.
6048 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6050 * editfns.c (Fdelete_region): Clarify the use of the named
6051 parameters (bug#6788).
6053 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6055 * indent.c (Fvertical_motion): Set and restore w->pointm when
6056 saving and restoring the window's buffer (Bug#9006).
6058 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6060 * editfns.c (Fstring_to_char): Clarify just what is returned
6061 (bug#6576). Text by Eli Zaretskii.
6063 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6065 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6067 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6069 * buffer.c (mmap_find): Fix a typo.
6071 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6073 Fix execution of x selection hooks.
6074 * xselect.c (Qx_lost_selection_functions)
6075 (Qx_sent_selection_functions): New vars.
6076 (syms_of_xselect): DEFSYM them.
6077 (x_handle_selection_request): Pass Qx_sent_selection_functions
6078 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6079 (x_handle_selection_clear,x_clear_frame_selections):
6080 Pass Qx_lost_selection_functions rather than
6081 Vx_lost_selection_functions to Frun_hook_with_args.
6083 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6085 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6086 The old code sometimes used this field without initializing it.
6088 * alloc.c (gc_sweep): Don't read past end of array.
6089 In theory, the old code could also have corrupted Emacs internals,
6090 though it'd be very unlikely.
6092 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6094 * character.c (Fcharacterp): Don't advertise optional ignored
6095 argument. (Bug#4026)
6097 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6099 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6102 * window.c (Fset_window_start): Doc fix (bug#4199).
6103 (Fset_window_hscroll): Ditto.
6105 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6107 Fix minor new problems caught by GCC 4.6.1.
6108 * term.c (init_tty): Remove unused local.
6109 * xsettings.c (store_monospaced_changed): Define this function only
6110 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6113 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6115 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6117 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6119 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6120 are the mini-buffer and the echo area (bug#3320).
6122 * term.c (init_tty): Remove support for supdup, c10 and perq
6123 terminals, which are no longer supported (bug#1482).
6125 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6127 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6129 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6131 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6132 for non-popups (Bug#3642).
6134 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6136 * alloc.c (reset_malloc_hooks): Protoize.
6137 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6138 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6139 * cm.c (losecursor): Likewise.
6140 * data.c (fmod): Likewise.
6141 * dispnew.c (swap_glyphs_in_rows): Likewise.
6142 * emacs.c (memory_warning_signal): Likewise.
6143 * floatfns.c (float_error): Likewise.
6144 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6145 (otf_open, font_otf_capability, generate_otf_features)
6146 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6148 * image.c (pbm_read_file): Likewise.
6149 * indent.c (string_display_width): Likewise.
6150 * intervals.c (check_for_interval, search_for_interval)
6151 (inc_interval_count, count_intervals, root_interval)
6152 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6153 * lread.c (defalias): Likewise.
6154 * ralloc.c (r_alloc_check): Likewise.
6155 * regex.c (set_image_of_range_1, set_image_of_range)
6156 (regex_grow_registers): Likewise.
6157 * sysdep.c (strerror): Likewise.
6158 * termcap.c (valid_filename_p, tprint, main): Likewise.
6159 * tparam.c (main): Likewise.
6160 * unexhp9k800.c (run_time_remap, save_data_space)
6161 (update_file_ptrs, read_header, write_header, calculate_checksum)
6162 (copy_file, copy_rest, display_header): Likewise.
6163 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6165 * xdisp.c (check_it): Likewise.
6166 * xfaces.c (register_color, unregister_color, unregister_colors):
6168 * xfns.c (print_fontset_result): Likewise.
6169 * xrdb.c (member, fatal, main): Likewise.
6171 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6173 Fix minor problems found by static checking (Bug#9031).
6174 * chartab.c (char_table_set_range, map_sub_char_table):
6175 Remove unused locals.
6176 (uniprop_table): Now static.
6177 * composite.c (_work_char): Remove unused static var.
6179 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6181 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6183 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6185 * gtkutil.c (qttip_cb): Remove code without function.
6187 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6189 * w32.c (pthread_sigmask): New stub.
6191 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6193 Use pthread_sigmask, not sigprocmask (Bug#9010).
6194 sigprocmask is portable only for single-threaded applications, and
6195 Emacs can be multi-threaded when it uses GTK.
6196 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6198 * callproc.c (Fcall_process):
6199 * process.c (create_process):
6200 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6201 Use pthread_sigmask, not sigprocmask.
6203 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6205 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6206 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6209 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6211 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6212 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6213 (xg_hide_tooltip): Fix comment.
6215 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6216 in registerServicesMenuSendTypes.
6217 (validRequestorForSendType): Don't check ns_return_types.
6219 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6222 2011-07-08 Jason Rumney <jasonr@gnu.org>
6224 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6225 SH_SHOW for hidden windows (Bug#5482).
6227 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6228 frame struct members of non-existent frames (Bug#6284).
6230 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6232 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6233 variable firstTime not needed on OSX >= 10.6.
6234 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6235 >= 10.5. Use setKnobProportion, setDoubleValue.
6237 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6238 (MAC_OS_X_VERSION_10_5): Define if not defined.
6239 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6240 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6241 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6243 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6244 cString and lossyCString on OSX >= 10.4
6246 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6247 sizeToFit on OSX >= 10.2.
6249 * nsimage.m (allocInitFromFile): Don't use deprecated method
6250 bestRepresentationForDevice on OSX >= 10.6.
6252 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6255 * emacs.c: Declare unexec_init_emacs_zone.
6257 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6259 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6261 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6262 on svcsMenu (Bug#8842).
6264 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6266 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6268 * nsterm.m (QUTF8_STRING): Declare.
6269 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6270 (validRequestorForSendType): Return type is (id).
6271 Change indexOfObjectIdenticalTo to indexOfObject.
6272 Check if we have local selection before returning self (Bug#8842).
6273 (writeSelectionToPasteboard): Put local selection into paste board
6274 if we have a local selection (Bug#8842).
6275 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6277 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6278 (ns_get_local_selection): Declare.
6280 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6282 * keymap.c (describe_map_tree): Don't insert a double newline at
6283 the end of the buffer (bug#1169) and return whether we inserted
6286 * callint.c (Fcall_interactively): Change "reading args" to
6287 "providing args" to try to clarify what it does (bug#1010).
6289 2011-07-07 Kenichi Handa <handa@m17n.org>
6291 * composite.c (composition_compute_stop_pos): Ignore a static
6292 composition starting before CHARPOS (Bug#8915).
6294 * xdisp.c (handle_composition_prop): Likewise.
6296 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6298 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6301 2011-07-07 Kenichi Handa <handa@m17n.org>
6303 * character.h (unicode_category_t): New enum type.
6305 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6306 (Qchar_code_property_table): New variable.
6307 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6308 (UNIPROP_COMPRESSED_FORM_P): New macros.
6309 (char_table_ascii): Uncompress the compressed values.
6310 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6311 Uncompress the compressed values.
6312 (sub_char_table_ref_and_range): Likewise.
6313 (char_table_ref_and_range): Uncompress the compressed values.
6314 (sub_char_table_set): New arg is_uniprop. Callers changed.
6315 Uncompress the compressed values.
6316 (sub_char_table_set_range): Args changed. Callers changed.
6317 (char_table_set_range): Adjuted for the above change.
6318 (map_sub_char_table): Delete args default_val and parent. Add arg
6319 top. Give decoded values to a Lisp function.
6320 (map_char_table): Adjust for the above change. Give decoded
6321 values to a Lisp function. Gcpro more variables.
6322 (uniprop_table_uncompress)
6323 (uniprop_decode_value_run_length): New functions.
6324 (uniprop_decoder, uniprop_decoder_count): New variables.
6325 (uniprop_get_decoder, uniprop_encode_value_character)
6326 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6328 (uniprop_encoder, uniprop_encoder_count): New variables.
6329 (uniprop_get_encoder, uniprop_table)
6330 (Funicode_property_table_internal, Fget_unicode_property_internal)
6331 (Fput_unicode_property_internal): New functions.
6332 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6333 Sunicode_property_table_internal, Sget_unicode_property_internal,
6334 and Sput_unicode_property_internal. Defvar_lisp
6335 char-code-property-alist.
6337 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6338 Vunicode_category_table.
6340 * font.c (font_range): Adjust for the change of
6341 Vunicode_category_table.
6343 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6345 * m/iris4d.h: Remove file, move contents ...
6346 * s/irix6-5.h: ... here.
6348 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6350 Remove unportable assumption about struct layout (Bug#8884).
6351 * alloc.c (mark_buffer):
6352 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6353 (clone_per_buffer_values): Don't assume that
6354 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6355 This isn't true in general, and it's particularly not true
6356 if Emacs is configured with --with-wide-int.
6357 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6358 New macros, used in the buffer.c change.
6360 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6362 * xsettings.c: Use both GConf and GSettings if both are available.
6363 (store_config_changed_event): Add comment.
6364 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6365 (store_tool_bar_style_changed): New functions.
6366 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6367 (struct xsettings): Move font inside HAVE_XFT.
6368 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6369 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6370 Move inside HAVE_XFT.
6371 (something_changed_gsettingsCB): Rename from something_changedCB.
6372 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6374 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6375 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6376 (something_changed_gconfCB): Rename from something_changedCB.
6377 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6378 (parse_settings): Move check for font inside HAVE_XFT.
6379 (read_settings, apply_xft_settings): Add comment.
6380 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6381 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6382 call store_font_name_changed.
6383 (xft_settings_event): Add comment.
6384 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6385 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6386 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6387 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6388 (xsettings_initialize): Call init_gsettings last.
6389 (xsettings_get_system_font, xsettings_get_system_normal_font):
6392 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6394 Random fixes. E.g., (random) never returned negative values.
6395 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6396 subseconds part to the entropy, as that's a bit more random.
6397 Prefer signed to unsigned, since the signedness doesn't matter and
6398 in general we prefer signed. When given a limit, use a
6399 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6400 latter isn't right if USE_2_TAGS_FOR_INTS.
6401 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6402 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6404 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6406 * textprop.c (text_property_stickiness):
6407 Obey Vtext_property_default_nonsticky.
6408 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6409 * w32fns.c (syms_of_w32fns):
6410 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6412 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6414 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6415 This is more efficient than Ffile_directory_p and avoids a minor race.
6417 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6419 * buffer.c (Foverlay_put): Say what the return value is
6422 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6423 is a directory before asking whether to use the file name
6425 (barf_or_query_if_file_exists): Make the "File is a directory"
6426 error be more correct.
6428 * fns.c (Frequire): Remove the mention of the .gz files, since
6429 that's installation-specific, but keep the mention of
6430 `get-load-suffixes'.
6432 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6434 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6435 Report string overflow if the output is too long.
6437 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6439 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6440 (syms_of_gnutls): Remove duplicate DEFSYM for
6441 Qgnutls_bootprop_verify_hostname_error, an error for
6442 Qgnutls_bootprop_verify_error (which is no longer used).
6444 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6445 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6446 Also (re)move comments that are misplaced or no longer relevant.
6448 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6450 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6452 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6454 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6455 and background color parameters if they have been changed.
6457 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6459 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6461 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6463 * xsettings.c (SYSTEM_FONT): Define only when used.
6464 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6466 * keymap.c (access_keymap_1): Now static.
6468 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6470 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6471 leave any prefix arg for the up event (Bug#1586).
6473 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6475 * lread.c (syms_of_lread): Mention single symbols defined by
6476 `defvar' or `defconst' (bug#7154).
6478 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6479 (Frequire): Mention get-load-suffixes.
6481 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6483 * window.h (window): Remove clone_number slot.
6484 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6486 (make_parent_window, make_window, saved_window)
6487 (Fset_window_configuration, save_window_save): Don't deal with
6489 * buffer.c (Qclone_number): Remove declaration.
6490 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6492 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6494 Add multiple inheritance to keymaps.
6495 * keymap.c (Fmake_composed_keymap): New function.
6496 (Fset_keymap_parent): Simplify.
6497 (fix_submap_inheritance): Remove.
6498 (access_keymap_1): New function extracted from access_keymap to handle
6499 embedded parents and handle lists of maps.
6500 (access_keymap): Use it.
6501 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6502 (Fcopy_keymap): Handle embedded parents.
6503 (Fcommand_remapping, define_as_prefix): Simplify.
6504 (Fkey_binding): Simplify.
6505 (syms_of_keymap): Move minibuffer-local-completion-map,
6506 minibuffer-local-filename-completion-map,
6507 minibuffer-local-must-match-map, and
6508 minibuffer-local-filename-must-match-map to Elisp.
6509 (syms_of_keymap): Defsubr make-composed-keymap.
6510 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6511 (parse_menu_item): Trivial simplification.
6513 2011-07-01 Glenn Morris <rgm@gnu.org>
6515 * Makefile.in (SETTINGS_LIBS): Fix typo.
6517 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6519 * coding.c (Fencode_coding_string): Record the last coding system
6520 used, as the function doc string says (bug#8738).
6522 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6524 * xsettings.c (store_monospaced_changed): Take new font as arg and
6525 check for change against current_mono_font.
6526 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6527 (emacs_settings_constructor, emacs_settings_get_property)
6528 (emacs_settings_set_property, emacs_settings_class_init)
6529 (emacs_settings_init, gsettings_obj): Remove.
6530 (something_changedCB): New function for HAVE_GSETTINGS.
6531 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6532 with value as argument.
6533 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6534 g_settings_new (Bug#8967). Do not create gsettings_obj.
6535 Remove calls to g_settings_bind. Connect something_changedCB to
6538 * xgselect.c: Add defined (HAVE_GSETTINGS).
6539 (xgselect_initialize): Ditto.
6541 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6542 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6545 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6547 * eval.c (struct backtrace): Simplify and port the data structure.
6548 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6549 signed bit field, as this assumption is not portable and it makes
6550 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6551 "char debug_on_exit : 1" as this is not portable either; instead,
6552 use the portable "unsigned int debug_on_exit : 1". Remove unused
6553 member evalargs. Remove obsolete comments about cc bombing out.
6555 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6557 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6558 Let HAVE_GSETTINGS override HAVE_GCONF.
6559 (store_monospaced_changed): New function.
6560 (EMACS_SETTINGS): A new type derived from GObject to handle
6561 GSettings notifications.
6562 (emacs_settings_constructor, emacs_settings_get_property)
6563 (emacs_settings_set_property, emacs_settings_class_init):
6565 (gsettings_client, gsettings_obj): New variables.
6566 (GSETTINGS_SCHEMA): New define.
6567 (something_changedCB): Call store_monospaced_changed.
6568 (init_gsettings): New function.
6569 (xsettings_initialize): Call init_gsettings.
6570 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6573 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6576 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6578 * window.c (resize_root_window, grow_mini_window)
6579 (shrink_mini_window): Rename Qresize_root_window to
6580 Qwindow_resize_root_window and Qresize_root_window_vertically to
6581 Qwindow_resize_root_window_vertically.
6583 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6585 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6587 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6589 * makefile.w32-in: Redesign dependencies so they reflect more
6590 clearly which files are directly included by each source file,
6591 and not through other includes.
6593 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6595 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6596 (sort_overlays, overlay_strings): When an overlay's clone number
6597 matches the window's clone number process the overlay even if
6598 the overlay's window property doesn't match the current window.
6600 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6601 (Fwindow_hchild): Rename to Fwindow_left_child.
6602 (Fwindow_next): Rename to Fwindow_next_sibling.
6603 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6604 (resize_window_check): Rename to window_resize_check.
6605 (resize_window_apply): Rename to window_resize_apply.
6606 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6607 (Fdelete_other_windows_internal, resize_frame_windows)
6608 (Fsplit_window_internal, Fdelete_window_internal)
6609 (grow_mini_window, shrink_mini_window)
6610 (Fresize_mini_window_internal): Fix callers accordingly.
6612 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6614 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6615 (emacs_fixed_set_min_size): Remove.
6616 (emacs_fixed_new): Take frame as argument.
6618 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6619 (_EmacsFixedPrivate): Remove minwidth/height.
6620 Add struct frame *f.
6621 (emacs_fixed_init): Initialize priv->f.
6622 (get_parent_class, emacs_fixed_set_min_size): Remove.
6623 (emacs_fixed_new): Set priv->f to argument.
6624 (emacs_fixed_get_preferred_width)
6625 (emacs_fixed_get_preferred_height): Use min_width/height from
6626 frames size_hint to set minimum and natural (Bug#8919).
6627 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6628 and use min_width/height from frames size_hint to set
6629 min_width/height (Bug#8919).
6631 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6632 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6635 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6637 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6638 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6641 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6643 * process.c (wait_reading_process_output): Bypass select if
6644 waiting for a cell while ignoring keyboard input, and input is
6645 pending. Suggested by Jan Djärv (Bug#8869).
6647 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6649 Use gnulib's dup2 module instead of rolling our own.
6650 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6652 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6654 * dispnew.c (scrolling_window): Before scrolling, turn off a
6655 mouse-highlight in the window being scrolled.
6657 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6659 Move DEFSYM to lisp.h and use everywhere.
6661 * character.h (DEFSYM): Move declaration...
6662 * lisp.h (DEFSYM): ...here.
6668 * w32select.c: Don't include character.h.
6670 * alloc.c (syms_of_alloc):
6671 * buffer.c (syms_of_buffer):
6672 * bytecode.c (syms_of_bytecode):
6673 * callint.c (syms_of_callint):
6674 * casefiddle.c (syms_of_casefiddle):
6675 * casetab.c (init_casetab_once):
6676 * category.c (init_category_once, syms_of_category):
6677 * ccl.c (syms_of_ccl):
6678 * cmds.c (syms_of_cmds):
6679 * composite.c (syms_of_composite):
6680 * dbusbind.c (syms_of_dbusbind):
6681 * dired.c (syms_of_dired):
6682 * dispnew.c (syms_of_display):
6683 * doc.c (syms_of_doc):
6684 * editfns.c (syms_of_editfns):
6685 * emacs.c (syms_of_emacs):
6686 * eval.c (syms_of_eval):
6687 * fileio.c (syms_of_fileio):
6688 * fns.c (syms_of_fns):
6689 * frame.c (syms_of_frame):
6690 * fringe.c (syms_of_fringe):
6691 * insdel.c (syms_of_insdel):
6692 * keymap.c (syms_of_keymap):
6693 * lread.c (init_obarray, syms_of_lread):
6694 * macros.c (syms_of_macros):
6695 * msdos.c (syms_of_msdos):
6696 * print.c (syms_of_print):
6697 * process.c (syms_of_process):
6698 * search.c (syms_of_search):
6699 * sound.c (syms_of_sound):
6700 * syntax.c (init_syntax_once, syms_of_syntax):
6701 * terminal.c (syms_of_terminal):
6702 * textprop.c (syms_of_textprop):
6703 * undo.c (syms_of_undo):
6704 * w32.c (globals_of_w32):
6705 * window.c (syms_of_window):
6706 * xdisp.c (syms_of_xdisp):
6707 * xfaces.c (syms_of_xfaces):
6708 * xfns.c (syms_of_xfns):
6709 * xmenu.c (syms_of_xmenu):
6710 * xsettings.c (syms_of_xsettings):
6711 * xterm.c (syms_of_xterm): Use DEFSYM.
6713 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6715 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6717 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6719 Integer and buffer overflow fixes (Bug#8873).
6721 * print.c (printchar, strout): Check for string overflow.
6722 (PRINTPREPARE, printchar, strout):
6723 Don't set size unless allocation succeeds.
6725 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6726 for sizes. Check for string overflow more accurately.
6727 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6729 * macros.c: Integer and buffer overflow fixes.
6730 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6731 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6732 Use ptrdiff_t, not int, for sizes.
6733 Don't increment bufsize until after realloc succeeds.
6734 Check for size-calculation overflow.
6735 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6737 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6739 * lread.c: Integer overflow fixes.
6740 (read_integer): Radix is now EMACS_INT, not int,
6741 to improve quality of diagnostics for out-of-range radices.
6742 Calculate buffer size correctly for out-of-range radices.
6743 (read1): Check for integer overflow in radices, and in
6744 read-circle numbers.
6745 (read_escape): Avoid int overflow.
6746 (Fload, openp, read_buffer_size, read1)
6747 (substitute_object_recurse, read_vector, read_list, map_obarray):
6748 Use ptrdiff_t, not int, for sizes.
6749 (read1): Use EMACS_INT, not int, for sizes.
6750 Check for size overflow.
6752 * image.c (cache_image): Check for size arithmetic overflow.
6754 * lread.c: Integer overflow issues.
6755 (saved_doc_string_size, saved_doc_string_length)
6756 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6757 Now ptrdiff_t, not int.
6758 (read1): Don't assume doc string length fits in int. Check for
6759 out-of-range doc string lengths.
6760 (read_list): Don't assume file position fits in int.
6761 (read_escape): Check for hex character overflow.
6763 2011-06-22 Leo Liu <sdl.web@gmail.com>
6765 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6766 Move to minibuffer.el.
6768 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6770 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6771 The following patches are for when GLYPH_DEBUG && !XASSERT.
6772 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6773 * dispnew.c (flush_stdout):
6774 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6775 Mark as externally visible.
6776 * dispnew.c (check_window_matrix_pointers): Now static.
6777 * dispnew.c (window_to_frame_vpos):
6778 * xfns.c (unwind_create_frame):
6779 * xterm.c (x_check_font): Remove unused local.
6780 * scroll.c (CHECK_BOUNDS):
6781 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6782 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6783 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6784 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6785 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6787 (debug_method_add): Use va_list and vsprintf rather than relying
6788 on undefined behavior with wrong number of arguments.
6789 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6790 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6791 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6792 since we're not interested in debugging glyphs with old libraries.
6793 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6794 GCC 4.6.0's static checking.
6796 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6798 Integer overflow and signedness fixes (Bug#8873).
6799 A few related buffer overrun fixes, too.
6801 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6803 * dispextern.h (struct face.stipple):
6804 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6805 (x_bitmap_mask, x_allocate_bitmap_record)
6806 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6807 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6808 (x_create_bitmap_from_xpm_data):
6809 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6810 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6812 * xfaces.c (load_pixmap):
6813 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6814 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6815 (.bitmaps_last, struct x_output.icon_bitmap):
6816 Use ptrdiff_t, not int, for bitmap indexes.
6817 (x_allocate_bitmap_record): Check for size overflow.
6818 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6820 Use ptrdiff_t, not int, for overlay counts.
6821 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6822 * editfns.c (overlays_around, get_pos_property):
6823 * textprop.c (get_char_property_and_overlay):
6824 * xdisp.c (next_overlay_change, note_mouse_highlight):
6825 * xfaces.c (face_at_buffer_position):
6826 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6827 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6828 (Fnext_overlay_change, Fprevious_overlay_change)
6829 (mouse_face_overlay_overlaps, Foverlays_in):
6830 Use ptrdiff_t, not int, for sizes.
6831 (overlays_at, overlays_in): Check for size-calculation overflow.
6833 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6835 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6836 (x_session_initialize): Do not assume string length fits in int.
6838 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6839 This is unlikely, but can occur if DPI is outlandish.
6841 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6842 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6844 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6845 * xrdb.c (magic_file_p, search_magic_path):
6846 Omit last arg SUFFIX; it was always 0. All callers changed.
6847 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6849 * xfont.c (xfont_match): Avoid need for strlen.
6851 * xfns.c: Don't assume strlen fits in int.
6852 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6854 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6855 not unsigned long, as we prefer signed integers. All callers changed.
6856 Detect integer overflow in repeat count.
6857 (message_dolog): Don't assume print length fits in 39 bytes.
6858 (display_mode_element): Don't assume strlen fits in int.
6860 * termcap.c: Don't assume sizes fit in int and never overflow.
6861 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6862 (gobble_line): Check for size-calculation overflow.
6864 * minibuf.c (Fread_buffer):
6865 * lread.c (intern, intern_c_string):
6866 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6867 Don't assume string length fits in int.
6869 * keyboard.c (parse_tool_bar_item):
6870 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6872 * font.c: Don't assume string length fits in int.
6873 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6874 Use ptrdiff_t, not int.
6875 (font_intern_prop): Don't assume string length fits in int.
6876 Don't assume integer property fits in fixnum.
6877 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6879 * filelock.c: Fix some buffer overrun and integer overflow issues.
6880 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6881 Reformulate so as not to need the command string.
6882 Invoke gzip -cd rather than gunzip, as it's more portable.
6883 (lock_info_type, lock_file_1, lock_file):
6884 Don't assume pid_t and time_t fit in unsigned long.
6885 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6886 (current_lock_owner): Prefer signed type for sizes.
6887 Use memcpy, not strncpy, where memcpy is what is really wanted.
6888 Don't assume (via atoi) that time_t and pid_t fit in int.
6889 Check for time_t and/or pid_t out of range, e.g., via a network share.
6890 Don't alloca where an auto var works fine.
6892 * fileio.c: Fix some integer overflow issues.
6893 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6894 Don't assume string length fits in int.
6895 (directory_file_name): Don't assume string length fits in long.
6896 (make_temp_name): Don't assume pid fits in int, or that its print
6897 length is less than 20.
6899 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6901 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6903 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6905 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6906 We prefer signed integers, even for size calculations.
6908 * emacs.c: Don't assume string length fits in 'int'.
6909 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6910 (main): Don't invoke strlen when not needed.
6912 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6913 (XD_DEBUG_MESSAGE): Don't waste a byte.
6915 * callproc.c (getenv_internal_1, getenv_internal)
6917 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6919 * lread.c (invalid_syntax): Omit length argument.
6920 All uses changed. This doesn't fix a bug, but it simplifies the
6921 code away from its former Hollerith-constant appearance, and it's
6922 one less 'int' to worry about when looking at integer-overflow issues.
6923 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6925 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6926 This didn't break anything, but it didn't help either.
6927 It's confusing to put a bogus integer in a place where the actual
6928 value does not matter.
6929 (LIST_END_P): Remove unused macro and its bogus comment.
6930 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6932 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6933 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6935 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6936 We prefer signed types, and the value cannot exceed the EMACS_INT
6937 range anyway (because otherwise the length would not be representable).
6938 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6939 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6940 This avoids a GCC warning when WIDE_EMACS_INT.
6942 * indent.c (sane_tab_width): New function.
6943 (current_column, scan_for_column, Findent_to, position_indentation)
6944 (compute_motion): Use it. This is just for clarity.
6945 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6947 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6949 * lisp.h (lint_assume): New macro.
6950 * composite.c (composition_gstring_put_cache):
6951 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6953 * editfns.c, insdel.c:
6954 Omit unnecessary forward decls, to simplify future changes.
6956 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6958 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6960 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6961 Use much-faster test for byte-length change.
6962 Don't assume string byte-length fits in 'int'.
6963 Check that character arg fits in 'int'.
6964 (mapcar1): Declare byte as byte, for clarity.
6966 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6968 * fns.c (concat): Catch string overflow earlier.
6969 Do not rely on integer wraparound.
6971 * dispextern.h (struct it.overlay_strings_charpos)
6972 (struct it.selective): Now EMACS_INT, not int.
6973 * xdisp.c (forward_to_next_line_start)
6974 (back_to_previous_visible_line_start)
6975 (reseat_at_next_visible_line_start, next_element_from_buffer):
6976 Don't arbitrarily truncate the value of 'selective' to int.
6978 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6980 * composite.c: Don't truncate sizes to 'int'.
6981 (composition_gstring_p, composition_reseat_it)
6982 (composition_adjust_point): Use EMACS_INT, not int.
6983 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6984 not EMACS_UINT, for indexes.
6986 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6988 * buffer.c: Include <verify.h>.
6989 (struct sortvec.priority, struct sortstr.priority):
6990 Now EMACS_INT, not int.
6991 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6992 (struct sortstr.size, record_overlay_string)
6993 (struct sortstrlist.size, struct sortlist.used):
6994 Don't truncate size to int.
6995 (record_overlay_string): Check for size-calculation overflow.
6996 (init_buffer_once): Check at compile-time, not run-time.
6998 2011-06-22 Jim Meyering <meyering@redhat.com>
7000 Don't leak an XBM-image-sized buffer
7001 * image.c (xbm_load): Free the image buffer after using it.
7003 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7006 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7007 that Sun C diagnosed.
7008 * fns.c (secure_hash): Fix pointer signedness issue.
7009 * intervals.c (static_offset_intervals): New function.
7010 (offset_intervals): Use it.
7012 2011-06-21 Leo Liu <sdl.web@gmail.com>
7015 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7018 * fns.c (secure_hash): Rename from crypto_hash_function and change
7019 the first arg to accept symbols.
7020 (Fsecure_hash): New primitive.
7021 (syms_of_fns): New symbols.
7023 2011-06-20 Deniz Dogan <deniz@dogan.se>
7025 * process.c (Fset_process_buffer): Clarify return value in
7028 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7030 * dispnew.c (add_window_display_history): Use BVAR.
7032 * xdisp.c (debug_method_add): Use BVAR.
7033 (check_window_end, dump_glyph_matrix, dump_glyph)
7034 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7036 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7039 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7040 check till after the cache is created in init_frame_faces.
7042 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7044 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7046 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7048 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7049 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7050 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7052 Improve buffer-overflow checking (Bug#8873).
7053 * fileio.c (Finsert_file_contents):
7054 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7055 Remove the old (too-loose) buffer overflow checks.
7056 They weren't needed, since make_gap checks for buffer overflow.
7057 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7058 The old code merely checked for Emacs fixnum overflow, and relied
7059 on undefined (wraparound) behavior. The new code avoids undefined
7060 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7062 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7063 Tune. Don't use wider integers than needed. Don't use alloca.
7064 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7066 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7068 * insdel.c, lisp.h (buffer_overflow): New function.
7069 (insert_from_buffer_1, replace_range, replace_range_2):
7070 * insdel.c (make_gap_larger):
7071 * editfns.c (Finsert_char):
7072 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7074 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7076 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7078 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7080 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7081 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7083 * fileio.c: Don't assume EMACS_INT fits in off_t.
7084 (emacs_lseek): New static function.
7085 (Finsert_file_contents, Fwrite_region): Use it.
7086 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7088 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7090 * fns.c: Don't overflow int when computing a list length.
7091 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7092 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7093 truncation on 64-bit hosts. Check for QUIT every
7094 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7095 faster and is responsive enough.
7096 (Flength): Report an error instead of overflowing an integer.
7097 (Fsafe_length): Return a float if the value is not representable
7098 as a fixnum. This shouldn't happen except in contrived situations.
7099 (Fnthcdr, Fsort): Don't assume list length fits in int.
7100 (Fcopy_sequence): Don't assume vector length fits in int.
7102 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7103 (header_size, word_size): New constants.
7104 (allocate_vectorlike): Don't check size overflow here.
7105 (allocate_vector): Check it here instead, since this is the only
7106 caller of allocate_vectorlike that could cause overflow.
7107 Check that the new vector's length is representable as a fixnum.
7109 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7110 The previous code was bogus. For example, next_almost_prime (32)
7111 returned 39, which is undesirable as it is a multiple of 3; and
7112 next_almost_prime (24) returned 25, which is a multiple of 5 so
7113 why was the code bothering to check for multiples of 7?
7115 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7117 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7119 Variadic C functions now count arguments with ptrdiff_t.
7120 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7121 Back then I didn't know that the Emacs coding style prefers signed int.
7122 Also, in the meantime I found a few more instances where arguments
7123 were being counted with int, which may truncate counts on 64-bit
7124 machines, or EMACS_INT, which may be unnecessarily wide.
7125 * lisp.h (struct Lisp_Subr.function.aMANY)
7126 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7127 Arg counts are now ptrdiff_t, not size_t.
7128 All variadic functions and their callers changed accordingly.
7129 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7130 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7131 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7132 * callint.c (Fcall_interactively): Check arg count for overflow,
7133 to avoid potential buffer overrun. Use signed char, not 'int',
7134 for 'varies' array, so that we needn't bother to check its size
7135 calculation for overflow.
7136 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7137 * eval.c (apply_lambda):
7138 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7139 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7140 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7142 * callint.c (Fcall_interactively): Don't use index var as event count.
7144 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7145 * mem-limits.h (SIZE): Remove; no longer used.
7147 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7149 Remove unnecessary casts.
7150 * xterm.c (x_term_init):
7151 * xfns.c (x_set_border_pixel):
7152 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7153 These aren't needed now that we assume ANSI C.
7155 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7156 It's more likely to cause problems (due to unsigned overflow)
7159 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7161 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7163 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7165 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7167 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7169 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7171 GLYPH_CODE_FACE returns EMACS_INT, not int.
7172 * dispextern.h (merge_faces):
7173 * xfaces.c (merge_faces):
7174 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7175 Don't assume EMACS_INT fits in int.
7177 * character.h (CHAR_VALID_P): Remove unused parameter.
7178 * fontset.c, lisp.h, xdisp.c: All uses changed.
7180 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7182 * fns.c (concat): Minor tuning based on overflow analysis.
7183 This doesn't fix any bugs. Use int to hold character, instead
7184 of constantly refetching from Emacs object. Use XFASTINT, not
7185 XINT, for value known to be a character. Don't bother comparing
7186 a single byte to 0400, as it's always less.
7188 * floatfns.c (Fexpt):
7189 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7191 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7194 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7196 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7197 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7198 incorrectly succeed when S was a string, because 4294967386 was
7199 truncated before it was used.
7201 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7202 Otherwise, an out-of-range integer could cause undefined behavior
7205 * composite.c: Use int, not EMACS_INT, for characters.
7206 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7207 EMACS_INT, for values that are known to be in character range.
7208 This doesn't fix any bugs but is the usual style inside Emacs and
7209 may generate better code on 32-bit machines.
7211 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7212 This is for reasons similar to the recent CHAR_STRING fix.
7213 * charset.c (Fencode_char): Check that character arg is actually
7214 a character. Pass an int to ENCODE_CHAR.
7215 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7216 wider than 'int', as a compile-time check to prevent future regressions
7219 * character.c (char_string): Remove unnecessary casts.
7221 Make sure a 64-bit char is never passed to CHAR_STRING.
7222 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7223 by silently ignoring the top 32 bits, allowing some values
7224 that were far too large to be valid characters.
7225 * character.h: Include <verify.h>.
7226 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7227 arguments are no wider than unsigned, as a compile-time check
7228 to prevent future regressions in this area.
7230 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7231 (Fsubst_char_in_region):
7233 * xdisp.c (decode_mode_spec_coding):
7234 Adjust to CHAR_STRING's new requirement.
7235 * editfns.c (Finsert_char, Fsubst_char_in_region):
7236 * fns.c (concat): Check that character args are actually
7237 characters. Without this test, these functions did the wrong
7238 thing with wildly out-of-range values on 64-bit hosts.
7240 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7241 These casts should not be needed on 32-bit hosts, either.
7242 * keyboard.c (read_char):
7243 * lread.c (Fload): Remove casts to unsigned.
7245 * lisp.h (UNSIGNED_CMP): New macro.
7246 This fixes comparison bugs on 64-bit hosts.
7247 (ASCII_CHAR_P): Use it.
7248 * casefiddle.c (casify_object):
7249 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7250 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7251 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7252 * dispextern.h (FACE_FROM_ID):
7253 * keyboard.c (read_char): Use UNSIGNED_CMP.
7255 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7256 not to EMACS_INT, to avoid GCC warning.
7258 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7260 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7261 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7262 isn't needed on 32-bit machines.
7264 * buffer.c (Fgenerate_new_buffer_name):
7265 Use EMACS_INT for count, not int.
7266 (advance_to_char_boundary): Return EMACS_INT, not int.
7268 * data.c (Qcompiled_function): Now static.
7270 * window.c (window_body_lines): Now static.
7272 * image.c (gif_load): Rename local to avoid shadowing.
7274 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7275 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7276 * alloc.c (make_save_value): Integer argument is now of type
7278 (mark_object): Use ptrdiff_t, not int.
7279 * lisp.h (pD): New macro.
7280 * print.c (print_object): Use it.
7282 * alloc.c: Use EMACS_INT, not int, to count objects.
7283 (total_conses, total_markers, total_symbols, total_vector_size)
7284 (total_free_conses, total_free_markers, total_free_symbols)
7285 (total_free_floats, total_floats, total_free_intervals)
7286 (total_intervals, total_strings, total_free_strings):
7287 Now EMACS_INT, not int. All uses changed.
7288 (Fgarbage_collect): Compute overall total using a double, so that
7289 integer overflow is less likely to be a problem. Check for overflow
7290 when converting back to an integer.
7291 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7292 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7293 These were 'int' variables that could overflow on 64-bit hosts;
7294 they were never used, so remove them instead of repairing them.
7295 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7296 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7297 Previously, this ceilinged at INT_MAX, but that doesn't work on
7299 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7301 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7302 (allocate_vectorlike): Check for ptrdiff_t overflow.
7303 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7304 when a (possibly-narrower) signed value would do just as well.
7305 We prefer using signed arithmetic, to avoid comparison confusion.
7307 * alloc.c: Catch some string size overflows that we were missing.
7308 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7309 for convenience in STRING_BYTES_MAX.
7310 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7311 The definition here is exact; the one in lisp.h was approximate.
7312 (allocate_string_data): Check for string overflow. This catches
7313 some instances we weren't catching before. Also, it catches
7314 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7315 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7316 and ptrdiff_t and EMACS_INT are both 64 bits.
7318 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7319 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7320 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7322 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7324 * alloc.c (Fmake_string): Check for out-of-range init.
7326 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7328 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7330 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7332 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7333 xg_get_default_scrollbar_width.
7335 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7336 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7337 (style_changed_cb): Call update_theme_scrollbar_width and call
7338 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7339 all frames (Bug#8505).
7340 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7341 Call gtk_window_set_resizable if HAVE_GTK3.
7342 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7343 and height if HAVE_GTK3 (Bug#8505).
7344 (scroll_bar_width_for_theme): New variable.
7345 (update_theme_scrollbar_width): New function.
7346 (xg_get_default_scrollbar_width): Move code to
7347 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7348 (xg_initialize): Call update_theme_scrollbar_width.
7350 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7352 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7354 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7356 * frame.c (make_frame): Call other_buffer_safely instead of
7359 * window.c (temp_output_buffer_show): Call display_buffer with
7360 second argument Vtemp_buffer_show_specifiers and reset latter
7361 immediately after the call.
7362 (Vtemp_buffer_show_specifiers): New variable.
7363 (auto_window_vscroll_p, next_screen_context_lines)
7364 (Vscroll_preserve_screen_position): Remove leading asterisks from
7367 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7369 Fix minor problems found by GCC 4.6.0 static checking.
7370 * buffer.c (Qclone_number): Remove for now, as it's unused.
7371 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7372 (record_buffer): Remove unused local.
7373 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7374 (set_frame_buffer_list): Remove; unused.
7375 * frame.h (other_visible_frames): Remove decl.
7376 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7377 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7378 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7380 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7381 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7382 Define only if HAVE_GPM.
7383 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7384 (update_hints_inhibit): Remove; never set. All uses removed.
7385 * widgetprv.h (emacsFrameClassRec): Remove decl.
7386 * window.c (delete_deletable_window): Now returns void, since it
7387 wasn't returning anything.
7388 (compare_window_configurations): Remove unused locals.
7389 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7390 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7391 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7392 the same widths as pointers. This follows up on the 2011-05-06 patch.
7393 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7394 * xterm.h: Likewise.
7395 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7397 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7399 * makefile.w32-in: Update dependencies.
7400 (LISP_H): Add lib/intprops.h.
7402 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7404 * image.c (gif_load): Add animation frame delay to the metadata.
7405 (syms_of_image): Use DEFSYM. New symbol `delay'.
7407 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7409 * window.c (delete_deletable_window): Re-add.
7410 (Fset_window_configuration): Rewrite to handle dead buffers and
7411 consequently deletable windows.
7412 (window_tree, Fwindow_tree): Remove. Supply functionality in
7414 (compare_window_configurations): Simplify code.
7416 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7418 * image.c (imagemagick_load_image): Fix type mismatch.
7419 (Fimagemagick_types): Likewise.
7421 * window.h (replace_buffer_in_windows): Declare.
7423 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7425 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7426 Qclone_number. Remove external declaration of Qdelete_window.
7427 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7429 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7430 Run Qbuffer_list_update_hook if allowed.
7431 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7432 buffer list implementation.
7433 (other_buffer_safely): New function.
7434 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7435 calls to replace_buffer_in_windows and
7436 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7438 (record_buffer): Inhibit quitting and rewrite using quittable
7439 functions. Run Qbuffer_list_update_hook if allowed.
7440 (Frecord_buffer, Funrecord_buffer): New functions.
7441 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7442 Move switch-to-buffer to window.el.
7443 (bury-buffer): Move to window.el.
7444 (Vbuffer_list_update_hook): New variable.
7446 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7449 * window.h (resize_frame_windows): Move up in code.
7450 (Fwindow_frame): Remove EXFUN.
7451 (replace_buffer_in_all_windows): Remove prototype.
7452 (replace_buffer_in_windows_safely): Add prototype.
7454 * window.c: Declare Qdelete_window static again. Move down
7455 declaration of select_count.
7456 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7457 (Fother_window): Move to window.el.
7458 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7459 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7460 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7462 (replace_buffer_in_windows): Implement by calling
7463 Qreplace_buffer_in_windows.
7464 (replace_buffer_in_all_windows): Remove with some functionality
7465 moved into replace_buffer_in_windows_safely.
7466 (replace_buffer_in_windows_safely): New function.
7467 (select_window_norecord, select_frame_norecord): Move in front
7468 of run_window_configuration_change_hook. Remove now obsolete
7470 (Fset_window_buffer): Rewrite doc-string.
7471 Call Qrecord_window_buffer.
7472 (keys_of_window): Move binding for other-window to window.el.
7474 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7476 * dispextern.h (struct image): Replace data member, whose int_val
7477 and ptr_val fields were not used by anything, with a single
7480 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7481 (gif_clear_image, gif_load, imagemagick_load_image)
7482 (gs_clear_image, gs_load): Callers changed.
7484 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7486 * buffer.h: Include <time.h>, for time_t.
7487 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7489 Fix minor problems found by static checking.
7491 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7493 Make identifiers static if they are not used in other modules.
7494 * data.c (Qcompiled_function, Qframe, Qvector):
7495 * image.c (QimageMagick, Qsvg):
7496 * minibuf.c (Qmetadata):
7497 * window.c (resize_window_check, resize_root_window): Now static.
7498 * window.h (resize_window_check, resize_root_window): Remove decls.
7500 * window.c (window_deletion_count, delete_deletable_window):
7502 (window_body_lines): Now static.
7503 (Fdelete_other_windows_internal): Mark vars as initialized.
7504 Make sure 'resize_failed' is initialized.
7505 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7506 (resize_window_apply): Remove unused local.
7507 * window.h (delete_deletable_window): Remove decl.
7509 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7510 (imagemagick_load_image): Fix pointer signedness problem by changing
7511 last arg from unsigned char * to char *. All uses changed.
7512 Also, fix a local for similar reasons.
7513 Remove unused locals. Remove locals to avoid shadowing.
7514 (fn_rsvg_handle_free): Remove; unused.
7515 (svg_load, svg_load_image): Fix pointer signedness problem.
7516 (imagemagick_load_image): Don't use garbage pointer image_wand.
7518 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7520 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7522 * image.c (gif_load): Fix omitted cast error introduced by
7525 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7527 * window.h (resize_proportionally, orig_total_lines)
7528 (orig_top_line): Remove from window structure.
7529 (set_window_height, set_window_width, change_window_heights)
7530 (Fdelete_window): Remove prototypes.
7531 (resize_frame_windows): Remove duplicate declaration.
7533 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7535 * window.h (resize_frame_windows, resize_window_check)
7536 (delete_deletable_window, resize_root_window)
7537 (resize_frame_windows): Declare prototypes.
7539 * window.c (resize_window_apply): Make definition be "static" to
7540 match the prototype.
7542 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7544 * window.c: Remove declarations of Qwindow_size_fixed,
7545 window_min_size_1, window_min_size_2, window_min_size,
7546 size_window, window_fixed_size_p, enlarge_window, delete_window.
7547 Remove static from declaration of Qdelete_window, it's
7548 temporarily needed by Fbury_buffer.
7549 (replace_window): Don't assign orig_top_line and
7551 (Fdelete_window, delete_window): Remove. Window deletion is
7552 handled by window.el.
7553 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7554 Replace Fdelete_window calls with calls to Qdelete_window.
7555 (Fdelete_other_windows): Remove. Deleting other windows is
7556 handled by window.el.
7557 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7558 handled in window.el.
7559 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7560 Window minimum sizes are handled in window.el.
7561 (shrink_windows, size_window, set_window_height)
7562 (set_window_width, change_window_heights, window_height)
7563 (window_width, CURBEG, CURSIZE, enlarge_window)
7564 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7565 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7566 handled in window.el.
7567 (make_dummy_parent): Rename to make_parent_window and give it a
7568 second argument horflag.
7569 (make_window): Don't set resize_proportionally any more.
7570 (Fsplit_window): Remove. Windows are split in window.el.
7571 (save_restore_action, save_restore_orig_size)
7572 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7573 Resize mini windows in window.el.
7574 (grow_mini_window, shrink_mini_window): Implement by calling
7575 Qresize_root_window_vertically, resize_window_check and
7576 resize_window_apply.
7577 (saved_window, Fset_window_configuration, save_window_save):
7578 Do not handle orig_top_line, orig_total_lines, and
7579 resize_proportionally.
7580 (window_min_height, window_min_width): Move to window.el.
7581 (keys_of_window): Move bindings for delete-other-windows,
7582 split-window, delete-window and enlarge-window to window.el.
7584 * buffer.c: Temporarily extern Qdelete_window.
7585 (Fbury_buffer): Temporarily call Qdelete_window instead of
7586 Fdelete_window (Fbury_buffer will move to window.el soon).
7588 * frame.c (set_menu_bar_lines_1): Remove code handling
7589 orig_top_line and orig_total_lines.
7591 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7592 set_window_height but set heights directly.
7593 (change_frame_size_1): Use resize_frame_windows.
7595 * xdisp.c (init_xdisp): Don't use set_window_height but set
7598 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7599 Use resize_frame_windows instead of change_window_heights and run
7600 run_window_configuration_change_hook.
7602 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7603 instead of change_window_heights and run
7604 run_window_configuration_change_hook.
7606 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7608 * window.c (replace_window): Rename second argument REPLACEMENT to
7609 NEW. New third argument SETFLAG. Rewrite.
7610 (delete_window, make_dummy_parent): Call replace_window with
7612 (window_list_1): Move down in code.
7613 (run_window_configuration_change_hook): Move set_buffer part
7614 before select_frame_norecord part in order to unwind correctly.
7615 Rename count1 to count.
7616 (recombine_windows, delete_deletable_window, resize_root_window)
7617 (Fdelete_other_windows_internal)
7618 (Frun_window_configuration_change_hook, make_parent_window)
7619 (resize_window_check, resize_window_apply, Fresize_window_apply)
7620 (resize_frame_windows, Fsplit_window_internal)
7621 (Fdelete_window_internal, Fresize_mini_window_internal):
7623 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7625 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7627 * window.h (window): Add some new members to window structure -
7628 normal_lines, normal_cols, new_total, new_normal, clone_number,
7629 splits, nest, prev_buffers, next_buffers.
7630 (WINDOW_TOTAL_SIZE): Move here from window.c.
7631 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7633 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7635 (make_dummy_parent): Set new members of windows structure.
7636 (make_window): Move down in code. Handle new members of window
7638 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7639 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7640 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7641 (Fset_window_prev_buffers, Fwindow_next_buffers)
7642 (Fset_window_next_buffers, Fset_window_clone_number):
7644 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7645 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7647 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7648 Argument WINDOW can be now internal window too.
7649 (Fwindow_use_time): Move up in code.
7650 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7652 (Fset_window_configuration, saved_window)
7653 (Fcurrent_window_configuration, save_window_save): Handle new
7654 members of window structure.
7655 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7656 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7657 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7658 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7659 Qget_mru_window, Qresize_root_window,
7660 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7661 Qauto_buffer_name; staticpro them.
7663 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7665 * window.c (Fwindow_total_size, Fwindow_left_column)
7666 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7667 (Fwindow_list_1): New functions.
7668 (window_box_text_cols): Replace with window_body_cols.
7669 (Fwindow_width, Fscroll_left, Fscroll_right):
7670 Use window_body_cols instead of window_box_text_cols.
7671 (delete_window, Fset_window_configuration):
7672 Call delete_all_subwindows with window as argument.
7673 (delete_all_subwindows): Take a window as argument and not a
7675 (window_loop): Remove handling of GET_LRU_WINDOW and
7677 (Fget_lru_window, Fget_largest_window): Move to window.el.
7679 * window.h: Extern window_body_cols instead of
7680 window_box_text_cols. delete_all_subwindows now takes a
7681 Lisp_Object as argument.
7683 * indent.c (compute_motion, Fcompute_motion):
7684 Use window_body_cols instead of window_box_text_cols.
7686 * frame.c (delete_frame): Call delete_all_subwindows with root
7689 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7691 * fns.c (Fputhash): Document return value.
7693 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7695 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7697 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7699 Cons<->int and similar integer overflow fixes (Bug#8794).
7701 Check for overflow when converting integer to cons and back.
7702 * charset.c (Fdefine_charset_internal, Fdecode_char):
7703 Use cons_to_unsigned to catch overflow.
7704 (Fencode_char): Use INTEGER_TO_CONS.
7705 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7706 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7707 * data.c (long_to_cons, cons_to_long): Remove.
7708 (cons_to_unsigned, cons_to_signed): New functions.
7709 These signal an error for invalid or out-of-range values.
7710 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7711 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7712 * font.c (Ffont_variation_glyphs):
7713 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7714 * lisp.h: Include <intprops.h>.
7715 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7716 (cons_to_signed, cons_to_unsigned): New decls.
7717 (long_to_cons, cons_to_long): Remove decls.
7718 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7719 (Fprimitive_undo): Use CONS_TO_INTEGER.
7720 * xfns.c (Fx_window_property): Likewise.
7721 * xselect.c: Include <limits.h>.
7722 (x_own_selection, selection_data_to_lisp_data):
7723 Use INTEGER_TO_CONS.
7724 (x_handle_selection_request, x_handle_selection_clear)
7725 (x_get_foreign_selection, Fx_disown_selection_internal)
7726 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7727 (lisp_data_to_selection_data): Use cons_to_unsigned.
7728 (x_fill_property_data): Use cons_to_signed.
7729 Report values out of range.
7731 Check for buffer and string overflow more precisely.
7732 * buffer.h (BUF_BYTES_MAX): New macro.
7733 * lisp.h (STRING_BYTES_MAX): New macro.
7734 * alloc.c (Fmake_string):
7735 * character.c (string_escape_byte8):
7736 * coding.c (coding_alloc_by_realloc):
7737 * doprnt.c (doprnt):
7738 * editfns.c (Fformat):
7740 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7741 since they may not be the same number.
7742 * editfns.c (Finsert_char):
7743 * fileio.c (Finsert_file_contents):
7744 Likewise for BUF_BYTES_MAX.
7746 * image.c: Use ptrdiff_t, not int, for sizes.
7747 (slurp_file): Switch from int to ptrdiff_t.
7749 (slurp_file): Check that file size fits in both size_t (for
7750 malloc) and ptrdiff_t (for sanity and safety).
7752 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7753 if b->modtime has its maximal value.
7755 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7757 Don't assume time_t can fit into int.
7758 * buffer.h (struct buffer.modtime): Now time_t, not int.
7759 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7760 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7762 Minor fixes for signed vs unsigned integers.
7763 * character.h (MAYBE_UNIFY_CHAR):
7764 * charset.c (maybe_unify_char):
7765 * keyboard.c (read_char, reorder_modifiers):
7766 XINT -> XFASTINT, since the integer must be nonnegative.
7767 * ftfont.c (ftfont_spec_pattern):
7768 * keymap.c (access_keymap, silly_event_symbol_error):
7769 XUINT -> XFASTINT, since the integer must be nonnegative.
7770 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7771 since it makes no difference and we prefer signed.
7772 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7773 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7776 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7778 * window.h (Fwindow_frame): Declare.
7780 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7782 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7783 (SPARE_MEMORY): Always define.
7784 (LARGE_REQUEST): Remove.
7785 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7787 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7789 * lisp.h: Move EXFUNS for Fframe_root_window,
7790 Fframe_first_window and Fset_frame_selected_window to window.h.
7792 * window.h: Move EXFUNS for Fframe_root_window,
7793 Fframe_first_window and Fset_frame_selected_window here from
7796 * frame.c (Fwindow_frame, Fframe_first_window)
7797 (Fframe_root_window, Fframe_selected_window)
7798 (Fset_frame_selected_window): Move to window.c.
7799 (Factive_minibuffer_window): Move to minibuf.c.
7800 (Fother_visible_frames_p): New function.
7802 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7804 * window.c (decode_window, decode_any_window): Move up in code.
7805 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7806 (inhibit_frame_unsplittable): Remove unused variable.
7807 (Fwindow_buffer): Move up and rewrite doc-string.
7808 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7809 (Fwindow_prev): New functions.
7810 (Fwindow_frame): Move here from frame.c. Accept any window as
7812 (Fframe_root_window, Fframe_first_window)
7813 (Fframe_selected_window): Move here from frame.c. Accept frame
7814 or arbitrary window as argument. Update doc-strings.
7815 (Fminibuffer_window): Move up in code.
7816 (Fwindow_minibuffer_p): Move up in code and simplify.
7817 (Fset_frame_selected_window): Move here from frame.c.
7819 (Fselected_window, select_window, Fselect_window): Move up in
7820 code. Minor doc-string fixes.
7822 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7824 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7825 Do not assume that spare memory exists; that assumption is valid
7826 only if SYSTEM_MALLOC.
7827 (LARGE_REQUEST): New macro, so that the issue of large requests
7828 is separated from the issue of spare memory.
7830 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7832 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7835 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7837 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7840 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7842 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7844 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7846 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7847 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7849 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7851 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7853 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7855 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7856 (x_clipboard_manager_save): Add return value.
7857 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7859 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7860 Obey Vx_select_enable_clipboard_manager. Catch errors in
7861 x_clipboard_manager_save (Bug#8779).
7862 (Vx_select_enable_clipboard_manager): New variable.
7863 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7865 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7867 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7869 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7871 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7872 in the current matrix if keep_current_p is non-zero.
7874 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7876 * bidi.c (bidi_level_of_next_char): Fix last change.
7878 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7880 Support bidi reordering of text covered by display properties.
7882 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7883 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7884 (bidi_cache_search, bidi_cache_iterator_state)
7885 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7886 (bidi_level_of_next_char, bidi_move_to_visually_next):
7887 Support character positions inside a run of characters covered by a
7889 (bidi_paragraph_init, bidi_resolve_explicit_1)
7890 (bidi_level_of_next_char): Call bidi_fetch_char and
7891 bidi_fetch_char_advance instead of FETCH_CHAR and
7893 (bidi_init_it): Initialize new members.
7894 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7896 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7897 instead of using explicit *_CHAR codes.
7898 (bidi_resolve_explicit, bidi_resolve_weak):
7899 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7900 bidirectional text is supported only in multibyte buffers.
7901 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7902 it to initialize the frame_window_p member of struct bidi_it.
7903 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7904 (bidi_resolve_explicit, bidi_resolve_weak)
7905 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7906 bidi_it->nchars is non-positive.
7907 (bidi_level_of_next_char): Don't try to lookup the cache for the
7908 next/previous character if nothing is cached there yet, or if we
7909 were just reseat()'ed to a new position.
7911 * xdisp.c (set_cursor_from_row): Set start and stop points
7912 according to the row's direction when priming the loop that looks
7913 for the glyph on which to display cursor.
7914 (single_display_spec_intangible_p): Function deleted.
7915 (display_prop_intangible_p): Reimplement to call
7916 handle_display_spec instead of single_display_spec_intangible_p.
7917 Accept 3 additional arguments needed by handle_display_spec.
7918 This fixes incorrect cursor motion across display property with complex
7919 values: lists, `(when COND...)' forms, etc.
7920 (single_display_spec_string_p): Support property values that are
7921 lists with the argument STRING its top-level element.
7922 (display_prop_string_p): Fix the condition for processing a
7923 property that is a list to be consistent with handle_display_spec.
7924 (handle_display_spec): New function, refactored from the
7925 last portion of handle_display_prop.
7926 (compute_display_string_pos): Accept additional argument
7927 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7928 value of a `display' property is a "replacing spec".
7929 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7930 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7931 the display property, but just return a value indicating whether
7932 the display property will replace the characters it covers.
7933 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7934 frame_window_p members of struct bidi_it.
7935 (compute_display_string_pos, compute_display_string_end):
7937 (push_it): Accept second argument POSITION, where pop_it should
7938 jump to continue iteration.
7939 (reseat_1): Initialize bidi_it.disp_pos.
7941 * keyboard.c (adjust_point_for_property): Adjust the call to
7942 display_prop_intangible_p to its new signature.
7944 * dispextern.h (struct bidi_it): New member frame_window_p.
7945 (bidi_init_it): Update prototypes.
7946 (display_prop_intangible_p): Update prototype.
7947 (compute_display_string_pos, compute_display_string_end):
7949 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7952 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7954 Malloc failure behavior now depends on size of allocation.
7955 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7956 * lisp.h: Change signatures accordingly.
7957 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7958 All callers changed. (Bug#8762)
7960 * gnutls.c: Use Emacs's memory allocators.
7961 Without this change, the gnutls library would invoke malloc etc.
7962 directly, which causes problems on non-SYNC_INPUT hosts, and which
7963 runs afoul of improving memory_full behavior. (Bug#8761)
7964 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7965 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7966 xfree instead of the default malloc, realloc, free.
7967 (Fgnutls_boot): No need to check for memory allocation failure,
7968 since xmalloc does that for us.
7970 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7971 * category.c (hash_get_category_set):
7972 * ccl.c (ccl_driver):
7973 * charset.c (Fdefine_charset_internal):
7974 * charset.h (struct charset.hash_index):
7975 * composite.c (get_composition_id, gstring_lookup_cache)
7976 (composition_gstring_put_cache):
7977 * composite.h (struct composition.hash_index):
7978 * dispextern.h (struct image.hash):
7979 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7980 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7981 (hashfn_equal, hashfn_user_defined, make_hash_table)
7982 (maybe_resize_hash_table, hash_lookup, hash_put)
7983 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7984 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7985 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7986 * image.c (make_image, search_image_cache, lookup_image)
7987 (xpm_put_color_table_h):
7988 * lisp.h (struct Lisp_Hash_Table):
7989 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7990 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7991 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7992 * alloc.c (allocate_vectorlike):
7993 Check for overflow in vector size calculations.
7994 * ccl.c (ccl_driver):
7995 Check for overflow when converting EMACS_INT to int.
7996 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7997 need to be updated by these changes.
7998 * fns.c (make_hash_table, maybe_resize_hash_table):
7999 Check for integer overflow with large hash tables.
8000 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8001 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8002 (SXHASH_REDUCE): New macro.
8003 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8004 Use it instead of discarding useful hash info with large hash values.
8005 (sxhash_float): New function.
8006 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8007 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8008 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8009 Rewrite to use FIXNUM_BITS, as this simplifies things.
8010 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8011 Adjust signatures to match updated version of code.
8012 (consing_since_gc): Now EMACS_INT, since a single hash table can
8013 use more than INT_MAX bytes.
8015 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8017 Make it possible to build with GCC-4.6+ -O2 -flto.
8019 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8021 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8023 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8024 Call minibuffer-inactive-mode.
8026 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8028 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8029 Update dependencies.
8031 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8033 * data.c (init_data): Remove code for UTS, this system is not
8036 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8038 Don't force ./temacs to start in terminal mode.
8040 * frame.c (make_initial_frame): Initialize faces in all cases, not
8041 only when CANNOT_DUMP is defined.
8042 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8044 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8046 * dispnew.c (add_window_display_history): Use const for the string
8047 pointer. Remove declaration, not needed.
8049 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8051 Use 'inline', not 'INLINE'.
8052 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8053 * alloc.c, fontset.c (INLINE): Remove.
8054 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8055 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8056 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8057 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8058 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8060 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8062 Make it possible to run ./temacs.
8064 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8065 syms_of_callproc does the same thing. Remove test for
8066 "initialized", do it in the caller.
8067 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8069 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8071 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8072 (read_minibuf): Use get_minibuffer.
8073 (syms_of_minibuf): Use DEFSYM.
8074 (Qmetadata): New var.
8075 * data.c (Qbuffer): Don't make it static.
8076 (syms_of_data): Use DEFSYM.
8078 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8080 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8081 (CCL_CODE_MIN): New macro.
8083 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8085 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8087 * eval.c (Qdebug): Now static.
8088 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8089 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8090 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8092 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8094 * image.c: Various fixes to ImageMagick code comments.
8095 (Fimagemagick_types): Doc fix.
8097 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8099 Minor fixes prompted by GCC 4.6.0 warnings.
8101 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8103 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8104 (x_clipboard_manager_save_all): Move extern decl to ...
8105 * xterm.h: ... here, so that it can be checked for consistency.
8107 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8109 * xselect.c (x_clipboard_manager_save_frame)
8110 (x_clipboard_manager_save_all): New functions.
8111 (Fx_clipboard_manager_save): Lisp function deleted.
8113 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8114 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8116 * xterm.h: Update prototype.
8118 2011-05-28 William Xu <william.xwl@gmail.com>
8120 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8123 2011-05-28 Jim Meyering <meyering@redhat.com>
8125 Avoid a sign-extension bug in crypto_hash_function.
8126 * fns.c (to_uchar): Define.
8127 (crypto_hash_function): Use it to convert some newly-signed
8128 variables to unsigned, to avoid sign-extension bugs. For example,
8129 without this change, (md5 "truc") would evaluate to
8130 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8131 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8132 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8134 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8136 Integer overflow fixes.
8138 * dbusbind.c: Serial number integer overflow fixes.
8139 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8140 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8141 to hold a serial number that is too large for a fixnum.
8142 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8143 Check for serial numbers out of range. Decode any serial number
8144 that was so large that it became a float. (Bug#8722)
8146 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8147 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8148 Use XFASTINT rather than XUINT when numbers are nonnegative.
8149 (xd_append_arg, Fdbus_method_return_internal):
8150 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8151 arguments, check that Lisp number is nonnegative, rather than
8152 silently wrapping negative numbers around. (Bug#8722)
8153 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8156 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8158 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8160 ccl: Add integer overflow checks.
8161 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8162 (IN_INT_RANGE): New macros.
8163 (ccl_driver): Use them to check for integer overflow when
8164 decoding a CCL program. Many of the new checks are whether XINT (x)
8165 fits in int; it doesn't always, on 64-bit hosts. The new version
8166 doesn't catch all possible integer overflows, but it's an
8167 improvement. (Bug#8719)
8169 * alloc.c (make_event_array): Use XINT, not XUINT.
8170 There's no need for unsigned here.
8172 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8173 This follows up to the 2011-05-06 change that substituted uintptr_t
8174 for EMACS_INT. This case wasn't caught back then.
8176 Rework Fformat to avoid integer overflow issues.
8177 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8178 now (part of C89). Include <verify.h>.
8179 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8180 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8181 (Fformat): Avoid the prepass trying to compute sizes; it was only
8182 approximate and thus did not catch overflow reliably. Instead, walk
8183 through the format just once, formatting and computing sizes as we go,
8184 checking for integer overflow at every step, and allocating a larger
8185 buffer as needed. Keep track separately whether the format is
8186 multibyte. Keep only the most-recently calculated precision, rather
8187 than them all. Record whether each argument has been converted to
8188 string. Use EMACS_INT, not int, for byte and char and arg counts.
8189 Support field widths and precisions larger than INT_MAX. Avoid
8190 sprintf's undefined behavior with conversion specifications such as %#d
8191 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8192 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8193 formatting out-of-range floating point numbers with int
8196 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8198 * data.c: Avoid integer truncation in expressions involving floats.
8199 * data.c: Include <intprops.h>.
8200 (arith_driver): When there's an integer overflow in an expression
8201 involving floating point, convert the integers to floating point
8202 so that the resulting value does not suffer from catastrophic
8203 integer truncation. For example, on a 64-bit host (* 4
8204 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8205 Do not rely on undefined behavior after integer overflow.
8207 merge count_size_as_multibyte, parse_str_to_multibyte
8208 * character.c, character.h (count_size_as_multibyte):
8209 Rename from parse_str_to_multibyte; all uses changed.
8210 Check for integer overflow.
8211 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8212 since it's now a duplicate of the other. This is more of
8213 a character than a buffer op, so better that it's in character.c.
8214 * fns.c, print.c: Adjust to above changes.
8216 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8218 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8220 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8222 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8223 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8224 (x_clipboard_manager_save): Now static.
8225 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8227 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8228 (crypto_hash_function): Now static.
8229 Fix pointer signedness problems. Avoid unnecessary initializations.
8231 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8233 * termhooks.h (Vselection_alist): Make it terminal-local.
8235 * terminal.c (create_terminal): Initialize it.
8237 * xselect.c: Support for clipboard managers.
8238 (Vselection_alist): Move to termhooks.h as terminal-local var.
8239 (LOCAL_SELECTION): New macro.
8240 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8241 (symbol_to_x_atom): Remove gratuitous arg.
8242 (x_handle_selection_request, lisp_data_to_selection_data)
8243 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8244 (x_own_selection, x_get_local_selection, x_convert_selection):
8245 New arg, specifying work frame. Use terminal-local Vselection_alist.
8246 (some_frame_on_display): Delete unused function.
8247 (Fx_own_selection_internal, Fx_get_selection_internal)
8248 (Fx_disown_selection_internal, Fx_selection_owner_p)
8249 (Fx_selection_exists_p): New optional frame arg.
8250 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8251 (x_handle_selection_clear): Don't treat other terminals with the
8252 same keyboard specially. Use the terminal-local Vselection_alist.
8253 (x_clear_frame_selections): Use Frun_hook_with_args.
8255 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8257 * xterm.h: Add support for those atoms.
8259 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8261 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8262 (converted_selections, conversion_fail_tag): New global variables.
8263 (x_selection_request_lisp_error): Free the above.
8264 (x_get_local_selection): Remove unnecessary code.
8265 (x_reply_selection_request): Args changed; handle arbitrary array
8266 of converted selections stored in converted_selections.
8267 Separate the XChangeProperty and SelectionNotify steps.
8268 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8269 (x_convert_selection): New function.
8270 (x_handle_selection_event): Simplify.
8271 (x_get_foreign_selection): Don't ignore incoming requests while
8272 waiting for an answer; this will fail when we implement
8273 SAVE_TARGETS, and seems unnecessary anyway.
8274 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8275 (Vx_sent_selection_functions): Doc fix.
8277 2011-05-26 Leo Liu <sdl.web@gmail.com>
8279 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8281 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8283 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8285 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8286 for fringe update if it has periodic bitmap.
8287 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8288 and fringe_bitmap_periodic_p.
8290 * fringe.c (get_fringe_bitmap_data): New function.
8291 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8292 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8293 row. Mark glyph row for fringe update if periodicity changed.
8295 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8296 for fringe update unless it has periodic bitmap.
8298 2011-05-25 Kenichi Handa <handa@m17n.org>
8300 * xdisp.c (get_next_display_element): Set correct it->face_id for
8301 a static composition.
8303 2011-05-24 Leo Liu <sdl.web@gmail.com>
8306 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8308 * fns.c (crypto_hash_function, Fsha1): New function.
8309 (Fmd5): Use crypto_hash_function.
8310 (syms_of_fns): Add Ssha1.
8312 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8314 * gnutls.c: Remove unused macros.
8315 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8316 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8317 Remove macros that are defined and never used.
8318 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8320 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8322 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8323 (Fx_get_selection_internal): Minor cleanup.
8324 (Fx_own_selection_internal): Rename arguments for consistency with
8327 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8329 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8331 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8333 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8335 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8337 * dispnew.c (scrolling_window): Don't exclude the case that the
8338 last enabled row in the desired matrix touches the bottom boundary.
8340 2011-05-21 Glenn Morris <rgm@gnu.org>
8342 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8343 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8344 and add some more files.
8346 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8348 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8349 report_file_error introduced by the change from 2011-05-07.
8351 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8353 * systime.h (Time): Define only if emacs is defined.
8354 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8355 where the include path doesn't have X11/X.h by default. See
8356 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8358 2011-05-20 Kenichi Handa <handa@m17n.org>
8360 * composite.c (find_automatic_composition): Fix previous change.
8362 2011-05-20 Glenn Morris <rgm@gnu.org>
8364 * lisp.mk: New file, split from Makefile.in.
8365 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8366 (shortlisp): Remove.
8367 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8369 2011-05-19 Glenn Morris <rgm@gnu.org>
8371 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8372 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8373 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8374 (lisp): Set the order to that of loadup.el.
8375 (shortlisp): Make it a copy of $lisp.
8376 (SOME_MACHINE_LISP): Remove.
8377 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8378 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8380 2011-05-18 Kenichi Handa <handa@m17n.org>
8382 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8383 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8384 (find_automatic_composition): Mostly rewrite for efficiency.
8386 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8388 * makefile.w32-in: Update dependencies.
8390 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8392 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8393 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8395 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8397 Fix some integer overflow issues, such as string length overflow.
8399 * insdel.c (count_size_as_multibyte): Check for string overflow.
8401 * character.c (lisp_string_width): Check for string overflow.
8402 Use EMACS_INT, not int, for string indexes and lengths; in
8403 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8404 the resulting string length overflows an EMACS_INT; instead,
8405 report a string overflow if no precision given. When checking for
8406 precision exhaustion, use a check that cannot possibly have
8407 integer overflow. (Bug#8675)
8408 * character.h (lisp_string_width): Adjust to new signature.
8410 * alloc.c (string_overflow): New function.
8411 (Fmake_string): Use it. This doesn't change behavior, but saves
8412 a few bytes and will simplify future changes.
8413 * character.c (string_escape_byte8): Likewise.
8414 * lisp.h (string_overflow): New decl.
8416 Fixups, following up to the user-interface timestamp change.
8417 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8418 for UI timestamps, instead of unsigned long.
8419 * msdos.c (mouse_get_pos): Likewise.
8420 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8421 * w32gui.h (Time): Define by including "systime.h" rather than by
8422 declaring it ourselves. (Bug#8664)
8424 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8425 * image.c (clear_image_cache): Likewise.
8427 * term.c (term_mouse_position): Don't assume time_t wraparound.
8429 Be more systematic about user-interface timestamps.
8430 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8431 and sometimes 'EMACS_UINT', to represent these timestamps.
8432 This change causes it to use 'Time' uniformly, as that's what X uses.
8433 This makes the code easier to follow, and makes it easier to catch
8434 integer overflow bugs such as Bug#8664.
8435 * frame.c (Fmouse_position, Fmouse_pixel_position):
8436 Use Time, not unsigned long, for user-interface timestamps.
8437 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8438 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8439 * keyboard.h (last_event_timestamp): Likewise.
8440 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8441 * menu.h (xmenu_show): Likewise.
8442 * term.c (term_mouse_position): Likewise.
8443 * termhooks.h (struct input_event.timestamp): Likewise.
8444 (struct terminal.mouse_position_hook): Likewise.
8445 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8446 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8447 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8448 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8450 * menu.h, termhooks.h: Include "systime.h", for Time.
8452 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8453 Don't assume that the difference between two unsigned long values
8454 can fit into an integer. At this point, we know button_down_time
8455 <= event->timestamp, so the difference must be nonnegative, so
8456 there's no need to cast the result if double-click-time is
8457 nonnegative, as it should be; check that it's nonnegative, just in
8458 case. This bug is triggered when events are more than 2**31 ms
8459 apart (about 25 days). (Bug#8664)
8461 * xselect.c (last_event_timestamp): Remove duplicate decl.
8462 (x_own_selection): Remove needless cast to unsigned long.
8464 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8465 that always fit in int. Use a sentinel instead of a counter, to
8466 avoid a temp and to allay GCC's concerns about possible int overflow.
8467 * frame.h (struct frame): Use int for menu_bar_items_used
8468 instead of EMACS_INT, since it always fits in int.
8470 * menu.c (grow_menu_items): Check for int overflow.
8472 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8474 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8475 Before, the code was not consistent. These values cannot exceed
8476 2**31 - 1 so there's no need to make them unsigned.
8477 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8478 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8479 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8481 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8483 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8484 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8485 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8486 presumably because the widths might not match.
8488 * window.c (size_window): Avoid needless test at loop start.
8490 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8492 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8494 2011-05-12 Drew Adams <drew.adams@oracle.com>
8496 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8498 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8500 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8501 `width' to `bar_area_x' and `bar_area_width', respectively.
8502 (x_scroll_run): Take account of fringe background extension.
8504 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8505 Rename local vars `left' and `width' to `bar_area_x' and
8506 `bar_area_width', respectively.
8507 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8508 background extension.
8510 2011-05-10 Jim Meyering <meyering@redhat.com>
8512 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8514 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8516 * image.c (Finit_image_library): Return t for built-in image types,
8517 like pbm and xbm. (Bug#8640)
8519 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8521 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8523 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8525 * w32console.c (Fset_screen_color): Doc fix.
8526 (Fget_screen_color): New function.
8527 (syms_of_ntterm): Defsubr it.
8529 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8530 unlink the temporary file if Fcall_process didn't create it in the
8532 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8533 child process will be redirected to a file specified with `:file'.
8534 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8535 cue to call_process_cleanup not to close that handle.
8537 2011-05-07 Ben Key <bkey76@gmail.com>
8539 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8540 one of two shell specific rules, either bootstrap-temacs-CMD or
8541 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8542 to the previous implementation of the bootstrap-temacs rule.
8543 The bootstrap-temacs-CMD rule is similar to the previous
8544 implementation of the bootstrap-temacs rule except that it
8545 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8548 These changes, along with some changes to nt/configure.bat,
8549 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8550 earlier fix to add support for --cflags and --ldflags options
8551 that include quotes so that it works whether make uses cmd or
8554 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8556 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8557 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8559 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8560 a string. Handle both cases.
8561 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8562 (Fdbus_register_method): Use Qinvalid_function.
8564 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8566 * makefile.w32-in: Update dependencies.
8567 (LISP_H): Add inttypes.h and stdin.h.
8568 (PROCESS_H): Add unistd.h.
8570 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8572 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8573 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8575 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8577 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8579 * term.c (vfatal): Remove stray call to va_end.
8580 It's not needed and the C Standard doesn't allow it here anyway.
8582 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8583 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8585 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8588 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8592 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8594 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8596 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8598 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8599 * charset.c (Fdefine_charset_internal): Don't initialize
8600 charset.code_space[15]. The value was garbage, on hosts with
8601 32-bit int (Bug#8600).
8603 * lread.c (read_integer): Be more consistent with string-to-number.
8604 Use string_to_number to do the actual conversion; this avoids
8605 rounding errors and fixes some other screwups. Without this fix,
8606 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8607 (digit_to_number): Move earlier, for benefit of read_integer.
8608 Return -1 if the digit is out of range for the base, -2 if it is
8609 not a digit in any supported base. (Bug#8602)
8611 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8613 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8614 to match comment at start of function. This also removes a
8615 GCC warning about overflow in a 32+64-bit port.
8617 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8619 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8620 Reported by Stefan Monnier in
8621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8622 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8623 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8625 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8626 (EMACS_UINTPTR): Likewise, with uintptr_t.
8628 * lisp.h: Prefer 64-bit EMACS_INT if available.
8629 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8630 on 32-bit hosts that have 64-bit int, so that they can access
8632 However, temporarily disable this change unless the temporary
8633 symbol WIDE_EMACS_INT is defined.
8635 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8637 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8638 This removes an assumption that EMACS_INT and long are the same
8639 width as pointers. The assumption is true for Emacs porting targets
8640 now, but we want to make other targets possible.
8641 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8642 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8643 In the rest of the code, change types of integers that hold casted
8644 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8645 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8646 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8647 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8648 No need to cast type when ORing.
8649 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8650 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8651 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8652 assume EMACS_INT is the same width as char *.
8653 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8654 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8655 Remove no-longer-needed casts.
8656 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8657 (xg_tool_bar_help_callback, xg_make_tool_item):
8658 Use EMACS_INTPTR to hold an integer
8659 that will be cast to void *; this can avoid a GCC warning
8660 if EMACS_INT is not the same width as void *.
8661 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8662 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8663 (current_message_1, set_message_1):
8664 Use a local to convert to proper width without a cast.
8665 * xmenu.c (dialog_selection_callback): Likewise.
8667 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8668 Also, don't assume VALBITS / RAND_BITS is less than 5,
8669 and don't rely on undefined behavior when shifting a 1 left into
8671 * lisp.h (get_random): Change signature to match.
8673 * lread.c (hash_string): Use size_t, not int, for hash computation.
8674 Normally we prefer signed values; but hashing is special, because
8675 it's better to use unsigned division on hash table sizes so that
8676 the remainder is nonnegative. Also, size_t is the natural width
8677 for hashing into memory. The previous code used 'int', which doesn't
8678 retain enough info to hash well into very large tables.
8679 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8681 * dbusbind.c: Don't possibly lose pointer info when converting.
8682 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8683 Use XPNTR rather than XHASH, so that the high-order bits of
8684 the pointer aren't lost when converting through void *.
8686 * eval.c (Fautoload): Don't double-shift a pointer.
8688 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8690 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8692 * gnutls.c (DEF_GNUTLS_FN):
8693 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8695 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8697 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8700 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8702 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8703 New version that can reserve upto 2GB of heap space.
8705 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8707 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8709 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8711 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8712 `gnutls_certificate_set_x509_key_file'.
8714 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8716 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8717 Update dependencies.
8719 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8721 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8722 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8723 Remove unused parameter `fildes'.
8724 * process.c (read_process_output, send_process): Don't pass it.
8726 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8728 Fix previous change: the library cache is defined in w32.c.
8729 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8730 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8732 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8734 Implement dynamic loading of GnuTLS on Windows.
8736 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8737 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8738 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8741 * gnutls.c (Qgnutls_dll): Define.
8742 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8743 (gnutls_*): Declare function pointers.
8744 (init_gnutls_functions): New function to initialize function pointers.
8745 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8746 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8747 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8748 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8749 (emacs_gnutls_write, emacs_gnutls_read)
8750 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8751 (Fgnutls_available_p): New function.
8752 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8753 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8754 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8756 * image.c: Include w32.h.
8757 (Vimage_type_cache): Delete.
8758 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8759 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8760 (w32_delayed_load): Move to w32.c.
8762 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8764 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8765 (w32_delayed_load): Move from image.c. When loading a library, record
8766 its filename in the :loaded-from property of the library id.
8767 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8768 Initialize and staticpro them.
8769 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8771 * process.c: Include lisp.h before w32.h, not after.
8772 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8773 instead of gnutls_record_check_pending.
8775 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8777 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8779 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8780 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8783 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8785 * xterm.c (x_set_frame_alpha): Do not set property on anything
8786 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8788 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8790 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8792 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8794 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8795 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8796 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8797 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8798 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8799 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8800 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8801 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8802 (Qgnutls_bootprop_callbacks_verify): Make static.
8804 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8806 * callproc.c: Indentation fixup.
8808 * sysdep.c (wait_for_termination_1): Make static.
8809 (wait_for_termination, interruptible_wait_for_termination):
8810 Move after wait_for_termination_1.
8812 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8814 * sysdep.c (interruptible_wait_for_termination): New function
8815 which is like wait_for_termination, but allows keyboard
8818 * callproc.c (Fcall_process): Add (:file "file") as an option for
8820 (Fcall_process_region): Ditto.
8822 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8824 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8825 rather than `XVECTOR (FOO)->size'.
8827 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8828 inttypes.h, as a gnulib replacement is used if it not available in
8831 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8833 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8834 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8835 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8837 * coding.c (coding_alloc_by_realloc): Error out if destination
8838 will grow beyond MOST_POSITIVE_FIXNUM.
8839 (decode_coding_emacs_mule): Abort if there isn't enough place in
8840 charbuf for the composition carryover bytes. Reserve an extra
8841 space for up to 2 characters produced in a loop.
8842 (decode_coding_iso_2022): Abort if there isn't enough place in
8843 charbuf for the composition carryover bytes.
8845 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8847 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8848 aborting when %lld or %lll format is passed.
8849 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8850 %llo or %llx format is passed. (Bug#8545)
8852 * window.c (window_scroll_line_based): Use a marker instead of
8853 simple variables to record original value of point. (Bug#7952)
8855 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8856 produced by %s or %c overflows available buffer space. (Bug#8545)
8858 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8860 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8861 (SIZE_MAX): Move defn after all includes, as they might #define it.
8863 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8865 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8867 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8869 * keyboard.c (Qdelayed_warnings_hook): Define.
8870 (command_loop_1): Run `delayed-warnings-hook'
8871 if Vdelayed_warnings_list is non-nil.
8872 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8873 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8875 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8877 * doprnt.c (doprnt): Don't return value smaller than the buffer
8878 size if the message was truncated. (Bug#8545).
8880 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8882 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8883 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8885 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8887 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8889 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8891 * makefile.w32-in: Update dependencies.
8893 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8895 Improve `doprnt' and its usage. (Bug#8545)
8896 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8897 `format_end'. Remove support for %l as a conversion specifier.
8898 Don't use xrealloc. Improve diagnostics when the %l size modifier
8899 is used. Update the commentary.
8901 * eval.c (verror): Simplify calculation of size_t.
8903 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8906 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8908 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8911 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8913 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8914 This makes this file independent of the recent pseudovector change.
8916 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8918 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8920 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8921 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8922 Remove unused local.
8923 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8925 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8926 GCC 4.6.0 optimizes based on type-based alias analysis.
8927 For example, if b is of type struct buffer * and v of type struct
8928 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8929 != &v->size, and therefore "v->size = 1; b->size = 2; return
8930 v->size;" must therefore return 1. This assumption is incorrect
8931 for Emacs, since it type-puns struct Lisp_Vector * with many other
8932 types. To fix this problem, this patch adds a new type struct
8933 vectorlike_header that documents the constraints on layout of vectors
8934 and pseudovectors, and helps optimizing compilers not get fooled
8935 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8936 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8937 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8939 (XSETPVECTYPE): Rewrite in terms of new macro.
8940 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8941 This is a bit clearer, and further avoids the possibility of
8942 undesirable aliasing.
8943 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8944 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8945 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8946 since Lisp_Subr is a special case (no "next" field).
8947 (ASIZE): Now uses header.size rather than size.
8948 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8949 to avoid the hassle of writing XVECTOR (foo)->header.size.
8950 (struct vectorlike_header): New type.
8951 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8952 object, to help avoid aliasing.
8953 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8954 (SUBRP): Likewise, since Lisp_Subr is a special case.
8955 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8956 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8957 (struct Lisp_Hash_Table): Combine first two members into a single
8958 struct vectorlike_header member. All uses of "size" and "next" members
8959 changed to be "header.size" and "header.next".
8960 * buffer.h (struct buffer): Likewise.
8961 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8962 * frame.h (struct frame): Likewise.
8963 * process.h (struct Lisp_Process): Likewise.
8964 * termhooks.h (struct terminal): Likewise.
8965 * window.c (struct save_window_data, struct saved_window): Likewise.
8966 * window.h (struct window): Likewise.
8967 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8968 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8969 * buffer.c (init_buffer_once): Likewise.
8970 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8972 * process.c (Fformat_network_address): Use local var for size,
8975 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8977 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8978 * data.c (atof): Remove decl; no longer used or needed.
8979 (digit_to_number): Move to lread.c.
8980 (Fstring_to_number): Use new string_to_number function, to be
8981 consistent with how the Lisp reader treats infinities and NaNs.
8982 Do not assume that floating-point numbers represent EMACS_INT
8983 without losing information; this is not true on most 64-bit hosts.
8984 Avoid double-rounding errors, by insisting on integers when
8985 parsing non-base-10 numbers, as the documentation specifies.
8986 * lisp.h (string_to_number): New decl, replacing ...
8987 (isfloat_string): Remove.
8988 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8989 (read1): Do not accept +. and -. as integers; this
8990 appears to have been a coding error. Similarly, do not accept
8991 strings like +-1e0 as floating point numbers. Do not report
8992 overflow for integer overflows unless the base is not 10 which
8993 means we have no simple and reliable way to continue.
8994 Break out the floating-point parsing into a new
8995 function string_to_number, so that Fstring_to_number parses
8996 floating point numbers consistently with the Lisp reader.
8997 (digit_to_number): Move here from data.c. Make it static inline.
8998 (E_CHAR, EXP_INT): Remove, replacing with ...
8999 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9000 (string_to_number): New function, replacing isfloat_string.
9001 This function checks for valid syntax and produces the resulting
9002 Lisp float number too. Rework it so that string-to-number
9003 no longer mishandles examples like "1.0e+". Use strtoumax,
9004 so that overflow for non-base-10 numbers is reported only when
9005 there's no portable and simple way to convert to floating point.
9007 * textprop.c (set_text_properties_1): Rewrite for clarity,
9008 and to avoid GCC warning about integer overflow.
9010 * intervals.h (struct interval): Use EMACS_INT for members
9011 where EMACS_UINT might cause problems. See
9012 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9013 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9014 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9016 (offset_intervals): Tell GCC not to worry about length overflow
9017 when negating a negative length.
9019 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9020 (overrun_check_free): Likewise.
9022 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9023 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9026 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9027 (gnutls_make_error): Rename local to avoid shadowing.
9028 (gnutls_emacs_global_deinit): ifdef out; not used.
9029 (Fgnutls_boot): Use const for pointer to readonly storage.
9030 Comment out unused local. Fix pointer signedness problems.
9032 * lread.c (openp): Don't stuff size_t into an 'int'.
9033 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9034 about possible signed overflow.
9036 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9037 (GDK_KEY_g): Don't define if already defined.
9038 (xg_prepare_tooltip): Avoid pointer signedness problem.
9039 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9041 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9042 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9044 * xfns.c (Fx_window_property): Simplify a bit,
9045 to make a bit faster and to avoid GCC 4.6.0 warning.
9046 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9048 * fns.c (internal_equal): Don't assume size_t fits in int.
9050 * alloc.c (compact_small_strings): Tighten assertion a little.
9052 Replace pEd with more-general pI, and fix some printf arg casts.
9053 * lisp.h (pI): New macro, generalizing old pEd macro to other
9054 conversion specifiers. For example, use "...%"pI"d..." rather
9055 than "...%"pEd"...".
9056 (pEd): Remove. All uses replaced with similar uses of pI.
9057 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9058 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9059 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9060 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9061 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9062 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9063 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9065 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9066 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9067 * print.c (safe_debug_print, print_object): Likewise.
9068 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9070 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9071 avoiding the 0 flag, which is not portable.
9072 * process.c (Fmake_network_process): Use pI to avoid cast.
9073 * region-cache.c (pp_cache): Likewise.
9074 * xdisp.c (decode_mode_spec): Likewise.
9075 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9076 behavior on 64-bit hosts with printf arg.
9077 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9078 (x_stop_queuing_selection_requests): Likewise.
9079 (x_get_window_property): Don't truncate byte count to an 'int'
9082 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9083 here, since it parses constructs like leading '-' and spaces,
9084 which are not wanted; and it overflows with large numbers.
9085 Instead, simply match F[0-9]+, which is what is wanted anyway.
9087 * alloc.c: Remove unportable assumptions about struct layout.
9088 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9089 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9090 (allocate_vectorlike, make_pure_vector): Use the new macros,
9091 plus offsetof, to remove unportable assumptions about struct layout.
9092 These assumptions hold on all porting targets that I know of, but
9093 they are not guaranteed, they're easy to remove, and removing them
9094 makes further changes easier.
9096 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9097 This doesn't fix a bug but makes the code clearer.
9098 (string_overrun_cookie): Now const. Use initializers that
9099 don't formally overflow signed char, to avoid warnings.
9100 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9101 can cause Emacs to crash when string overrun checking is enabled.
9102 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9103 multiple of sizeof (EMACS_INT); it need not be, if
9104 alignof(EMACS_INT) < sizeof (EMACS_INT).
9105 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9107 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9109 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9111 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9113 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9114 supposed to be handshaking. (Bug#8556)
9115 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9117 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9119 * lisp.h (Qdebug): List symbol.
9120 * eval.c (Qdebug): Restore global linkage.
9121 * keyboard.c (debug-on-event): New variable.
9122 (handle_user_signal): Break into debugger when debug-on-event
9123 matches the current signal symbol.
9125 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9127 * alloc.c (check_sblock, check_string_bytes)
9128 (check_string_free_list): Convert to standard C.
9130 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9132 * w32.c (emacs_gnutls_push): Fix typo.
9134 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9136 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9137 "cast to pointer from integer of different size".
9139 Improve doprnt and its use in verror. (Bug#8545)
9140 * doprnt.c (doprnt): Document the set of format control sequences
9141 supported by the function. Use SAFE_ALLOCA instead of always
9144 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9145 is one byte too soon. Don't use xrealloc; instead xfree and
9148 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9150 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9153 * gnutls.c: Renamed global_initialized to
9154 gnutls_global_initialized. Added internals for the
9155 :verify-hostname-error, :verify-error, and :verify-flags
9156 parameters of `gnutls-boot' and documented those parameters in the
9157 docstring. Start callback support.
9158 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9159 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9160 on error. Return error code.
9161 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9162 (emacs_gnutls_read): Likewise.
9163 (Fgnutls_boot): Return handshake error code.
9164 (emacs_gnutls_handle_error): New function.
9165 (wsaerror_to_errno): Likewise.
9167 * w32.h (emacs_gnutls_pull): Add prototype.
9168 (emacs_gnutls_push): Likewise.
9170 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9171 (emacs_gnutls_push): Likewise.
9173 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9175 * process.c (wait_reading_process_output): Check if GnuTLS
9176 buffered some data internally if no FDs are set for TLS
9179 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9180 (LIBS): Link to USER_LIBS.
9181 ($(BLD)/gnutls.$(0)): New target.
9183 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9185 * xdisp.c (handle_single_display_spec): Rename the
9186 display_replaced_before_p argument into display_replaced_p, to
9187 make it consistent with the commentary. Fix typos in the
9190 * textprop.c (syms_of_textprop): Remove dead code.
9191 (copy_text_properties): Delete obsolete commentary about an
9192 interface that was deleted long ago. Fix typos in the description
9195 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9196 to changes in oldXMenu/XMenu.h from 2011-04-16.
9197 <menu_help_message, prev_menu_help_message>: Constify.
9198 (IT_menu_make_room): menu->help_text is now `const char **';
9201 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9202 to changes in oldXMenu/XMenu.h from 2011-04-16.
9203 (struct XMenu): Declare `help_text' `const char **'.
9205 * xfaces.c <Qunspecified>: Make extern again.
9207 * syntax.c: Include sys/types.h before including regex.h, as
9210 * doc.c (get_doc_string): Improve the format passed to `error'.
9212 * doprnt.c (doprnt): Improve commentary.
9214 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9216 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9219 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9220 changes in globals.h immediately force recompilation.
9221 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9222 $(CURDIR)/s/ms-w32.h.
9223 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9225 * character.c (Fchar_direction): Function deleted.
9226 (syms_of_character): Don't defsubr it.
9227 <char-direction-table>: Deleted.
9229 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9231 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9232 * doprnt.c: Include limits.h.
9233 (SIZE_MAX): New macro.
9234 (doprnt): Return a size_t value. 2nd arg is now size_t.
9235 Many local variables are now size_t instead of int or unsigned.
9236 Improve overflow protection. Support `l' modifier for integer
9237 conversions. Support %l conversion. Don't assume an EMACS_INT
9238 argument for integer conversions and for %c.
9240 * lisp.h (doprnt): Restore prototype.
9242 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9245 * Makefile.in (base_obj): Add back doprnt.o.
9247 * deps.mk (doprnt.o): Add back prerequisites.
9248 (callint.o): Depend on character.h.
9250 * eval.c (internal_lisp_condition_case): Include the handler
9251 representation in the error message.
9252 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9253 when breaking from the loop.
9255 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9257 * callint.c (Fcall_interactively): When displaying error message
9258 about invalid control letter, pass the character's codepoint, not
9259 a pointer to its multibyte form. Improve display of the character
9260 in octal and display also its hex code.
9262 * character.c (char_string): Use %x to display the (unsigned)
9263 codepoint of an invalid character, to avoid displaying a bogus
9266 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9267 `error', not SYMBOL_NAME itself.
9269 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9270 character arguments to `error'.
9272 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9273 to `error' in error message about FINAL_CHAR argument. Make sure
9274 FINAL_CHAR is a character, and use %c when it is passed as
9275 argument to `error'.
9277 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9279 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9281 * w32.c: Include <time.h>.
9282 (sys_localtime): New function.
9284 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9286 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9288 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9290 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9292 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9295 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9297 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9298 gl_state.e_property when gl_state.object is Qt.
9300 * insdel.c (make_gap_larger): Remove limitation of buffer size
9303 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9305 * xdisp.c (lookup_glyphless_char_display)
9306 (produce_glyphless_glyph): Handle cons cell entry in
9307 glyphless-char-display.
9308 (Vglyphless_char_display): Document it.
9310 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9311 glyphless-char-display.
9313 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9315 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9317 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9320 definition for no-X builds.
9322 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9324 Static checks with GCC 4.6.0 and non-default toolkits.
9326 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9328 * process.c (keyboard_bit_set): Define only if SIGIO.
9329 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9330 (send_process): Repair possible setjmp clobbering.
9332 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9334 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9336 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9338 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9339 Define only if needed.
9341 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9342 by pacifying GCC about it. Maybe it's time to retire it?
9343 * xfaces.c (USG, __TIMEVAL__): Likewise.
9345 * dispextern.h (struct redisplay_interface): Rename param
9347 * termhooks.h (struct terminal): Likewise.
9348 * xterm.c (xembed_send_message): Likewise.
9350 * insdel.c (make_gap_smaller): Define only if
9351 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9353 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9356 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9357 so that we aren't warned about unused symbols.
9359 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9361 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9363 * xfns.c (x_real_positions): Mark locals as initialized.
9365 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9367 * xterm.c: Fix problems found by static analysis with other toolkits.
9368 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9369 (x_dispatch_event): Declare static if USE_GTK, and
9370 define if USE_GTK || USE_X_TOOLKIT.
9371 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9372 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9373 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9374 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9376 * xmenu.c (menu_help_callback): Pointer type fixes.
9377 Use const pointers when pointing at readonly data. Avoid pointer
9379 (FALSE): Remove unused macro.
9380 (update_frame_menubar): Remove unused decl.
9382 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9384 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9385 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9386 (single_menu_item): Rename local to avoid shadowing.
9388 * keyboard.c (make_lispy_event): Remove unused local var.
9390 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9391 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9393 * bitmaps: Change bitmaps from unsigned char back to the X11
9394 compatible char. Avoid the old compiler warnings about
9395 out-of-range initializers by using, for example, '\xab' rather
9398 * xgselect.c (xgselect_initialize): Check vs interface
9399 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9401 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9403 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9404 to read-only memory.
9406 * fns.c (vector): Remove; this old hack is no longer needed.
9408 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9410 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9412 * xrdb.c (x_load_resources): Omit unused local.
9414 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9415 (x_window): Rename locals to avoid shadowing.
9416 (USG): Use the kludged USG macro, to pacify gcc.
9418 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9419 (x_term_init): Remove local to avoid shadowing.
9421 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9423 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9424 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9426 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9428 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9430 Fix regex.c, syntax.c and friends for buffers > 2GB.
9431 * syntax.h (struct gl_state_s): Declare character position members
9434 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9436 * textprop.c (verify_interval_modification, interval_of):
9437 Declare arguments EMACS_INT.
9439 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9442 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9444 * indent.c (Fvertical_motion): Local variable it_start is now
9447 * regex.c (re_match, re_match_2, re_match_2_internal)
9448 (bcmp_translate, regcomp, regexec, print_double_string)
9449 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9450 (re_compile_pattern, re_exec): Declare arguments and local
9451 variables `size_t' and `ssize_t' and return values `regoff_t', as
9453 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9454 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9455 <compile_stack_type>: `size' and `avail' are now `size_t'.
9457 * regex.h <regoff_t>: Use ssize_t, not int.
9458 (re_search, re_search_2, re_match, re_match_2): Arguments that
9459 specify buffer/string position and length are now ssize_t and
9460 size_t. Return type is regoff_t.
9462 2011-04-16 Ben Key <bkey76@gmail.com>
9464 * nsfont.m: Fixed bugs in ns_get_family and
9465 ns_descriptor_to_entity that were caused by using free to
9466 deallocate memory blocks that were allocated by xmalloc (via
9467 xstrdup). This caused Emacs to crash when compiled with
9468 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9469 --enable-checking=xmallocoverrun). xfree is now used to
9470 deallocate these memory blocks.
9472 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9474 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9476 emacs_write: Accept and return EMACS_INT for sizes.
9477 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9479 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9480 Accept and return EMACS_INT.
9481 (emacs_gnutls_write): Return the number of bytes written on
9483 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9484 (emacs_read, emacs_write): Remove check for negative size, as the
9485 Emacs source code has been audited now.
9486 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9487 (emacs_read, emacs_write): Use it.
9488 * process.c (send_process): Adjust to the new signatures of
9489 emacs_write and emacs_gnutls_write. Do not attempt to store
9490 a byte offset into an 'int'; it might overflow.
9491 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9493 * sound.c: Don't assume sizes fit in 'int'.
9494 (struct sound_device.period_size, alsa_period_size):
9495 Return EMACS_INT, not int.
9496 (struct sound_device.write, vox_write, alsa_write):
9497 Accept EMACS_INT, not int.
9498 (wav_play, au_play): Use EMACS_INT to store sizes and to
9499 record read return values.
9501 2011-04-15 Ben Key <bkey76@gmail.com>
9503 * keyboard.c (Qundefined): Don't declare static since it is used
9505 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9506 static since they are used in nsfont.m.
9508 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9510 * process.c (Qprocessp): Don't declare static.
9511 * lisp.h (Qprocessp): Declare again.
9513 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9515 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9517 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9519 Improve C-level modularity by making more things 'static'.
9521 Don't publish debugger-only interfaces to other modules.
9522 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9523 (verify_bytepos, count_markers): Move decls to the only modules
9525 * region-cache.h (pp_cache): Likewise.
9526 * window.h (check_all_windows): Likewise.
9527 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9529 * sysdep.c (croak): Now static, if
9530 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9531 * syssignal.h (croak): Declare only if not static.
9533 * alloc.c (refill_memory_reserve): Now static if
9534 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9535 * lisp.h (refill_memory_reserve): Declare only if not static.
9537 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9538 Define only if USE_LUCID.
9540 * xrdb.c (x_customization_string, x_rm_string): Now static.
9542 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9543 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9545 * xdisp.c (draw_row_with_mouse_face): Now static.
9546 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9548 * window.h (check_all_windows): Mark externally visible.
9550 * window.c (window_deletion_count): Now static.
9552 * undo.c: Make symbols static if they're not exported.
9553 (last_undo_buffer, last_boundary_position, pending_boundary):
9556 * textprop.c (interval_insert_behind_hooks): Now static.
9557 (interval_insert_in_front_hooks): Likewise.
9559 * term.c: Make symbols static if they're not exported.
9560 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9561 (max_frame_lines, tty_set_terminal_modes):
9562 (tty_reset_terminal_modes, tty_turn_off_highlight):
9563 (get_tty_terminal): Now static.
9564 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9565 * termhooks.h (term_mouse_moveto): Do not declare if
9567 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9568 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9570 * sysdep.c: Make symbols static if they're not exported.
9571 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9573 (sigprocmask_set, full_mask): Remove; unused.
9574 (wait_debugging): Mark as visible.
9575 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9576 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9578 * syntax.c (syntax_temp): Define only if !__GNUC__.
9580 * sound.c (current_sound_device, current_sound): Now static.
9582 * search.c (searchbufs, searchbuf_head): Now static.
9584 * scroll.c (scroll_cost): Remove; unused.
9585 * dispextern.h (scroll_cost): Remove decl.
9587 * region-cache.h (pp_cache): Mark as externally visible.
9589 * process.c: Make symbols static if they're not exported.
9590 (process_tick, update_tick, create_process, chan_process):
9591 (Vprocess_alist, proc_buffered_char, datagram_access):
9592 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9593 (deactivate_process): Mark defn as static, as well as decl.
9594 * lisp.h (create_process): Remove decl.
9595 * process.h (chan_process, Vprocess_alist): Remove decls.
9597 * print.c: Make symbols static if they're not exported.
9598 (print_depth, new_backquote_output, being_printed, print_buffer):
9599 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9600 (print_interval, print_number_index, initial_stderr_stream):
9602 * lisp.h (Fprinc): Remove decl.
9603 (debug_output_compilation_hack): Mark as externally visible.
9605 * sysdep.c (croak): Move decl from here to syssignal.h.
9606 * syssignal.h (croak): Put it here, so the API can be checked when
9607 'croak' is called from dissociate_if_controlling_tty.
9609 * minibuf.c: Make symbols static if they're not exported.
9610 (minibuf_save_list, choose_minibuf_frame): Now static.
9611 * lisp.h (choose_minibuf_frame): Remove decl.
9613 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9615 * lread.c: Make symbols static if they're not exported.
9616 (read_objects, initial_obarray, oblookup_last_bucket_number):
9618 (make_symbol): Remove; unused.
9619 * lisp.h (initial_obarray, make_symbol): Remove decls.
9621 * keyboard.c: Make symbols static if they're not exported.
9622 (single_kboard, recent_keys_index, total_keys, recent_keys):
9623 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9624 (this_single_command_key_start, echoing, last_auto_save):
9625 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9626 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9627 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9628 (Vlispy_mouse_stem, double_click_count):
9630 (force_auto_save_soon): Define only if SIGDANGER.
9631 (ignore_mouse_drag_p): Now static if
9632 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9633 (print_help): Remove; unused.
9634 (stop_character, last_timer_event): Mark as externally visible.
9635 * keyboard.h (ignore_mouse_drag_p): Declare only if
9636 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9637 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9638 * lisp.h (echoing): Remove decl.
9639 (force_auto_save_soon): Declare only if SIGDANGER.
9640 * xdisp.c (redisplay_window): Simplify code, to make it more
9641 obvious that ignore_mouse_drag_p is not accessed if !defined
9642 USE_GTK && !defined HAVE_NS.
9644 * intervals.c: Make symbols static if they're not exported.
9645 (merge_properties_sticky, merge_interval_right, delete_interval):
9647 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9649 * insdel.c: Make symbols static if they're not exported.
9650 However, leave prepare_to_modify_buffer alone. It's never
9651 called from outside this function, but that appears to be a bug.
9652 (combine_after_change_list, combine_after_change_buffer):
9653 (adjust_after_replace, signal_before_change): Now static.
9654 (adjust_after_replace_noundo): Remove; unused.
9655 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9656 (signal_before_change): Remove decls.
9658 * indent.c (val_compute_motion, val_vmotion): Now static.
9660 * image.c: Make symbols static if they're not exported.
9661 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9663 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9664 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9666 * fringe.c (standard_bitmaps): Now static.
9667 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9669 * frame.c: Make symbols static if they're not exported.
9670 (x_report_frame_params, make_terminal_frame): Now static.
9671 (get_frame_param): Now static, unless HAVE_NS.
9672 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9673 (x_get_resource_string): Remove; not used.
9674 * frame.h (make_terminal_frame, x_report_frame_params):
9675 (x_get_resource_string); Remove decls.
9676 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9677 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9679 * font.c, fontset.c: Make symbols static if they're not exported.
9680 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9681 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9682 * font.c (font_close_object): Now static.
9683 * font.h (font_close_object): Remove.
9684 * fontset.c (FONTSET_OBJLIST): Remove.
9685 (free_realized_fontset) #if-0 the body, which does nothing.
9686 (face_suitable_for_char_p): #if-0, as it's never called.
9687 * fontset.h (face_suitable_for_char_p): Remove decl.
9688 * xfaces.c (face_at_string_position):
9689 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9690 since 0 is always ASCII.
9692 * fns.c (weak_hash_tables): Now static.
9694 * fileio.c: Make symbols static if they're not exported.
9695 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9696 (Vwrite_region_annotation_buffers): Now static.
9698 * eval.c: Make symbols static if they're not exported.
9699 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9700 * lisp.h (backtrace_list): Remove decl.
9702 * emacs.c: Make symbols static if they're not exported.
9703 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9704 (fatal_error_code, fatal_error_signal_hook, standard_args):
9706 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9707 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9708 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9709 * lisp.h (fatal_error_signal_hook): Remove decl.
9710 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9712 * editfns.c: Move a (normally-unused) function to its only use.
9713 * editfns.c, lisp.h (get_operating_system_release): Remove.
9714 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9715 worth the hassle of breaking this out.
9717 * xterm.c: Make symbols static if they're not exported.
9718 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9719 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9720 (x_destroy_window, x_delete_display):
9722 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9723 (x_mouse_leave): Remove; unused.
9724 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9725 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9726 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9728 (x_mouse_leave): Declare only if WINDOWSNT.
9729 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9730 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9733 * ftxfont.c: Make symbols static if they're not exported.
9734 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9736 * font.h (ftxfont_driver): Likewise.
9738 * xfns.c: Make symbols static if they're not exported.
9739 (x_last_font_name, x_display_info_for_name):
9740 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9741 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9742 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9743 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9744 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9745 (last_show_tip_args): Now static.
9746 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9747 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9748 (x_screen_planes): Remove; unused.
9749 * dispextern.h (x_screen_planes): Remove decl.
9751 * dispnew.c: Make symbols static if they're not exported.
9752 * dispextern.h (redraw_garbaged_frames, scrolling):
9753 (increment_row_positions): Remove.
9754 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9755 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9757 (redraw_garbaged_frames): Remove; unused.
9759 * xfaces.c: Make symbols static if they're not exported.
9760 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9762 * xterm.h (defined_color): Remove decls.
9763 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9764 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9765 (menu_face_changed_default, defined_color, free_realized_face):
9766 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9767 (ascii_face_of_lisp_face): Remove; unused.
9769 * xdisp.c: Make symbols static if they're not exported.
9770 * dispextern.h (scratch_glyph_row, window_box_edges):
9771 (glyph_to_pixel_coords, set_cursor_from_row):
9772 (get_next_display_element, set_iterator_to_next):
9773 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9774 (show_mouse_face): Remove decls
9775 * frame.h (message_buf_print): Likewise.
9776 * lisp.h (pop_message, set_message, check_point_in_composition):
9778 * xterm.h (set_vertical_scroll_bar): Likewise.
9779 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9780 (message_buf_print, scratch_glyph_row, displayed_buffer):
9781 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9782 (get_next_display_element, show_mouse_face, window_box_edges):
9783 (frame_to_window_pixel_xy, check_point_in_composition):
9784 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9785 (glyph_to_pixel_coords): Remove; unused.
9787 * dired.c (file_name_completion): Now static.
9789 * dbusbind.c (xd_in_read_queued_messages): Now static.
9791 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9792 * data.c (circular_list_error): Remove.
9794 * commands.h (last_point_position, last_point_position_buffer):
9795 (last_point_position_window): Remove decls.
9796 * keyboard.c: Make these variables static.
9798 * coding.h (coding, code_convert_region, encode_coding_gap):
9800 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9801 (iso_code_class, detect_coding, code_convert_region): Now static.
9802 (encode_coding_gap): Remove; unused.
9804 * chartab.c (chartab_chars, chartab_bits): Now static.
9806 * charset.h (charset_iso_8859_1): Remove decl.
9807 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9810 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9811 * ccl.c (Vccl_program_table): Now static.
9812 (check_ccl_update): Remove; unused.
9814 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9815 * category.h: ... from here.
9816 * category.c (check_category_table, set_category_set): Now static.
9818 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9819 * lisp.h: Remove these decls.
9821 * buffer.c (buffer_count): Remove unused var.
9823 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9824 so that it's not optimized away.
9825 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9826 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9827 exported only to the debugger.
9829 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9830 * atimer.h (run_all_atimers): Remove; not exported.
9832 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9833 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9834 was inaccessible from Lisp.
9835 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9836 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9838 alloc.c: Import and export fewer symbols, and remove unused items.
9839 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9841 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9842 it's not optimized away by whole-program optimization.
9843 (message_enable_multibyte, free_misc): Remove.
9844 (catchlist, handlerlist, mark_backtrace):
9845 Declare only if BYTE_MARK_STACK.
9846 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9847 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9848 (message_enable_multibyte): Remove decl.
9849 (free_misc, interval_free_list, float_block, float_block_index):
9850 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9851 (cons_free_list, last_marked_index):
9853 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9854 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9855 (mark_backtrace): Define only if BYTE_MARK_STACK.
9856 * xdisp.c (message_enable_multibyte): Now static.
9858 Declare Lisp_Object Q* variables to be 'static' if not exported.
9859 This makes it easier for human readers (and static analyzers)
9860 to see whether these variables are used from other modules.
9861 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9862 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9863 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9864 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9865 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9866 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9867 * xmenu.c, xselect.c:
9868 Declare Q* vars static if they are not used in other modules.
9869 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9870 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9871 Remove decls of unexported vars.
9872 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9874 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9876 Make Emacs functions such as Fatom 'static' by default.
9877 This makes it easier for human readers (and static analyzers)
9878 to see whether these functions can be called from other modules.
9879 DEFUN now defines a static function. To make the function external
9880 so that it can be used in other C modules, use the new macro DEFUE.
9881 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9882 (Finit_image_library):
9883 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9884 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9885 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9886 Remove decls, since these functions are now static.
9887 (Funintern, Fget_internal_run_time): New decls, since these functions
9888 were already external.
9890 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9891 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9892 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9893 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9894 * keyboard.c, keymap.c, lread.c:
9895 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9896 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9897 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9898 Mark functions with DEFUE instead of DEFUN,
9899 if they are used in other modules.
9900 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9901 decls for now-static functions.
9902 * buffer.h (Fdelete_overlay): Remove decl.
9903 * callproc.c (Fgetenv_internal): Mark as internal.
9904 * composite.c (Fremove_list_of_text_properties): Remove decl.
9905 (Fcomposition_get_gstring): New forward static decl.
9906 * composite.h (Fcomposite_get_gstring): Remove decl.
9907 * dired.c (Ffile_attributes): New forward static decl.
9908 * doc.c (Fdocumntation_property): New forward static decl.
9909 * eval.c (Ffetch_bytecode): New forward static decl.
9910 (Funintern): Remove extern decl; now in .h file where it belongs.
9911 * fileio.c (Fmake_symbolic_link): New forward static decl.
9912 * image.c (Finit_image_library): New forward static decl.
9913 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9914 * intervals.h (Fprevious_property_change):
9915 (Fremove_list_of_text_properties): Remove decls.
9916 * keyboard.c (Fthis_command_keys): Remove decl.
9917 (Fcommand_execute): New forward static decl.
9918 * keymap.c (Flookup_key): New forward static decl.
9919 (Fcopy_keymap): Now static.
9920 * keymap.h (Flookup_key): Remove decl.
9921 * process.c (Fget_process): New forward static decl.
9922 (Fprocess_datagram_address): Mark as internal.
9923 * syntax.c (Fsyntax_table_p): New forward static decl.
9924 (skip_chars): Remove duplicate decl.
9925 * textprop.c (Fprevious_property_change): New forward static decl.
9926 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9928 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9929 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9931 * editfns.c (Fformat): Remove unreachable code.
9933 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9935 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9938 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9940 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9941 when at ZV. (Bug#8487)
9943 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9945 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9947 * keyboard.c (parse_tool_bar_item): Likewise.
9948 * sound.c (sound_cleanup, alsa_close): Likewise.
9949 * termcap.c (tgetent): Likewise.
9950 * xfns.c (x_default_font_parameter): Likewise.
9951 * xsettings.c (read_and_apply_settings): Likewise.
9953 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9954 (overrun_check_free): Protoize.
9956 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9958 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9959 since callers should never pass a negative size.
9960 Change the signature to match that of plain 'read' and 'write'; see
9961 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9962 * lisp.h: Update prototypes of emacs_write and emacs_read.
9964 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9966 * xdisp.c (redisplay_window): Don't try to determine the character
9967 position of the scroll margin if the window start point w->startp
9968 is outside the buffer's accessible region. (Bug#8468)
9970 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9972 Fix write-region and its subroutines for buffers > 2GB.
9973 * fileio.c (a_write, e_write): Modify declaration of arguments and
9974 local variables to support buffers larger than 2GB.
9975 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9977 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9978 argument, local variables, and return value.
9980 * lisp.h: Update prototypes of emacs_write and emacs_read.
9982 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9984 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9986 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9988 Fix more problems found by GCC 4.6.0's static checks.
9990 * xdisp.c (vmessage): Use a better test for character truncation.
9992 * charset.c (load_charset_map): <, not <=, for optimization,
9993 and to avoid potential problems with integer overflow.
9994 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9995 * casetab.c (set_identity, shuffle): Likewise.
9996 * editfns.c (Fformat): Likewise.
9997 * syntax.c (skip_chars): Likewise.
9999 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10000 This also lets GCC 4.6.0 generate slightly better loop code.
10002 * callint.c (Fcall_interactively): <, not <=, for optimization.
10003 (Fcall_interactively): Count the number of arguments produced,
10004 not the number of arguments given. This is simpler and lets GCC
10005 4.6.0 generate slightly better code.
10007 * ftfont.c: Distingish more carefully between FcChar8 and char.
10008 The previous code passed unsigned char * to a functions like
10009 strlen and xstrcasecmp that expect char *, which does not
10010 conform to the C standard.
10011 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10012 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10013 char * when the C standard requires it.
10015 * keyboard.c (read_char): Remove unused var.
10017 * eval.c: Port to Windows vsnprintf (Bug#8435).
10018 Include <limits.h>.
10019 (SIZE_MAX): Define if the headers do not.
10020 (verror): Do not give up if vsnprintf returns a negative count.
10021 Instead, grow the buffer. This ports to Windows vsnprintf, which
10022 does not conform to C99. Problem reported by Eli Zaretskii.
10023 Also, simplify the allocation scheme, by avoiding the need for
10024 calling realloc, and removing the ALLOCATED variable.
10026 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10028 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10029 But keep the doprint source code for now, as we might revamp it
10030 and use it again (Bug#8435).
10031 * lisp.h (doprnt): Remove.
10032 * Makefile.in (base_obj): Remove doprnt.o.
10033 * deps.mk (doprnt.o): Remove.
10035 error: Print 32- and 64-bit integers portably (Bug#8435).
10036 Without this change, on typical 64-bit hosts error ("...%d...", N)
10037 was used to print both 32- and 64-bit integers N, which relied on
10038 undefined behavior.
10039 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10040 * lisp.h (error, verror): Mark as printf-like functions.
10041 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10042 Report overflow in size calculations when allocating printf buffer.
10043 Do not truncate output string at its first null byte.
10044 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10045 Truncate the output at a character boundary, since vsnprintf does not
10047 * charset.c (check_iso_charset_parameter): Convert internal
10048 character to string before calling 'error', since %c now has the
10050 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10051 overflow when computing char to be passed to 'error'. Do not
10052 pass Lisp_Object to 'error'; pass the integer instead.
10053 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10054 formatted with plain %d.
10056 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10058 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10060 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10062 * xterm.c (x_catch_errors): Remove duplicate declaration.
10064 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10066 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10068 2011-04-10 Jim Meyering <meyering@redhat.com>
10070 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10071 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10072 return ssize_t not "int", and use size_t as the buffer length.
10073 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10074 * gnutls.h: Update declarations.
10075 * process.c (read_process_output): Use ssize_t, to match.
10076 (send_process): Likewise.
10078 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10080 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10082 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10084 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10085 Use unsigned char, to match FcChar8 type definition.
10087 * xterm.c (handle_one_xevent):
10088 * xmenu.c (create_and_show_popup_menu):
10089 * xselect.c (x_decline_selection_request)
10090 (x_reply_selection_request): Avoid type-punned deref of X events.
10092 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10094 Fix some uses of `int' instead of EMACS_INT.
10095 * search.c (string_match_1, fast_string_match)
10096 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10097 (scan_buffer, find_next_newline_no_quit)
10098 (find_before_next_newline, search_command, Freplace_match)
10099 (Fmatch_data): Make some `int' variables be EMACS_INT.
10101 * xdisp.c (display_count_lines): 3rd argument and return value now
10102 EMACS_INT. All callers changed.
10103 (pint2hrstr): Last argument is now EMACS_INT.
10105 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10106 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10107 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10108 (decode_coding_utf_16, decode_coding_emacs_mule)
10109 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10110 (decode_coding_ccl, decode_coding_charset)
10111 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10112 (decode_coding_iso_2022, decode_coding_emacs_mule)
10113 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10114 <char_offset, last_offset>: Declare EMACS_INT.
10115 (encode_coding_utf_8, encode_coding_utf_16)
10116 (encode_coding_emacs_mule, encode_invocation_designation)
10117 (encode_designation_at_bol, encode_coding_iso_2022)
10118 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10119 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10121 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10122 (encode_invocation_designation): Last argument P_NCHARS is now
10124 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10125 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10127 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10130 * ccl.c (Fccl_execute_on_string): Declare some variables
10133 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10135 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10137 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10139 * process.c (Fformat_network_address): Doc fix.
10141 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10143 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10145 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10147 * keyboard.c (read_char): Call Lisp function help-form-show,
10148 instead of using internal_with_output_to_temp_buffer.
10149 (Qhelp_form_show): New var.
10150 (syms_of_keyboard): Use DEFSYM macro.
10152 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10154 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10156 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10158 * process.c (Flist_processes): Remove to Lisp.
10159 (list_processes_1): Delete.
10161 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10163 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10165 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10167 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10169 Fix more problems found by GCC 4.6.0's static checks.
10171 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10173 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10175 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10177 * xdisp.c (vmessage): Mark as a printf-like function.
10179 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10181 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10183 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10184 printf-like functions.
10185 (tiff_load): Add casts to remove these marks before passing them
10186 to system-supplied API.
10188 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10190 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10191 This avoids several warnings with gcc -Wstrict-overflow.
10192 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10193 directly, rather than having caller test rule sign. This avoids
10194 some unnecessary tests.
10195 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10196 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10197 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10199 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10200 (xfont_open): Avoid unnecessary tests.
10202 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10204 * composite.h, composite.c (composition_gstring_put_cache):
10205 Use EMACS_INT, not int, for length.
10207 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10208 breaking out part of COMPOSITION_DECODE_RULE.
10209 (COMPOSITION_DECODE_RULE): Use it.
10210 * composite.c (get_composition_id): Remove unused local vars,
10211 by using the new macro.
10213 * textprop.c (set_text_properties_1): Change while to do-while,
10214 since the condition is always true at first.
10216 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10217 (interval_deletion_adjustment): Return unsigned value.
10220 * process.c (list_processes_1, create_pty, read_process_output):
10221 (exec_sentinel): Remove vars that were set but not used.
10222 (create_pty): Remove unnecessary "volatile"s.
10223 (Fnetwork_interface_info): Avoid possibility of int overflow.
10224 (read_process_output): Do adaptive read buffering even if carryover.
10225 (read_process_output): Simplify nbytes computation if buffered.
10227 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10229 * syntax.c (scan_words): Remove var that was set but not used.
10230 (update_syntax_table): Use unsigned instead of int.
10232 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10233 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10234 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10236 * print.c (print_error_message): Avoid int overflow.
10238 * font.c (font_list_entities): Redo for clarity,
10239 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10241 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10242 (font_score): Avoid potential overflow in diff calculation.
10244 * fns.c (substring_both): Remove var that is set but not used.
10245 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10247 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10249 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10250 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10251 can always succeed if overflow has undefined behavior.
10253 * search.c (boyer_moore, wordify): Remove vars set but not used.
10254 (wordify): Omit three unnecessary tests.
10256 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10257 All callers changed. This avoids the need for an unused var.
10259 * casefiddle.c (casify_region): Remove var that is set but not used.
10261 * dired.c (file_name_completion): Remove var that is set but not used.
10263 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10265 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10266 (Finsert_file_contents): Remove unnecessary code checking fd.
10268 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10269 Check for integer overflow on size calculations.
10271 * buffer.c (Fprevious_overlay_change): Remove var that is set
10274 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10275 Remove vars that are set but not used.
10276 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10277 (timer_check_2): Mark vars as initialized.
10279 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10281 * image.c (lookup_image): Remove var that is set but not used.
10282 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10284 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10285 that are set but not used.
10287 * xfns.c (make_invisible_cursor): Don't return garbage
10288 if XCreateBitmapFromData fails (Bug#8410).
10290 * xselect.c (x_get_local_selection, x_handle_property_notify):
10291 Remove vars that are set but not used.
10293 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10294 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10296 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10297 Remove var that is set but not used.
10298 (scroll_bar_windows_size): Now size_t, not int.
10299 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10300 Check for overflow.
10302 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10303 (map_tty_color) [!defined MSDOS]: Likewise.
10305 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10307 * coding.c: Remove vars that are set but not used.
10308 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10309 All callers changed.
10310 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10311 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10312 (decode_coding_charset): Remove vars that are set but not used.
10314 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10315 that is set but not used.
10317 * print.c (print_object): Remove var that is set but not used.
10319 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10320 The gnulib version avoids calling malloc in the usual case,
10321 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10322 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10323 * filelock.c (current_lock_owner): Likewise.
10324 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10325 * sysdep.c: Include allocator.h, careadlinkat.h.
10326 (emacs_no_realloc_allocator): New static constant.
10327 (emacs_readlink): New function.
10328 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10329 ../lib/careadlinkat.h.
10331 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10333 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10334 first non-nil return value).
10336 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10338 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10339 if not defined (Bug#8403).
10341 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10343 * xdisp.c (display_count_lines): Remove parameter `start',
10344 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10345 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10346 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10347 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10348 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10349 and thereabouts. All callers changed.
10350 (get_per_char_metric): Remove parameter `f', unused since
10351 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10353 2011-04-02 Jim Meyering <meyering@redhat.com>
10355 do not dereference NULL upon failed strdup
10356 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10357 (ns_get_family): Likewise.
10359 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10361 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10363 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10365 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10368 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10370 Add lexical binding.
10372 * window.c (Ftemp_output_buffer_show): New fun.
10373 (Fsave_window_excursion):
10374 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10376 * lread.c (lisp_file_lexically_bound_p): New function.
10377 (Fload): Bind Qlexical_binding.
10378 (readevalloop): Remove `evalfun' arg.
10379 Bind Qinternal_interpreter_environment.
10380 (Feval_buffer): Bind Qlexical_binding.
10381 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10383 (syms_of_lread): Declare `lexical-binding'.
10385 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10387 * keyboard.c (eval_dyn): New fun.
10388 (menu_item_eval_property): Use it.
10390 * image.c (parse_image_spec): Use Ffunctionp.
10392 * fns.c (concat, mapcar1): Accept byte-code-functions.
10394 * eval.c (Fsetq): Handle lexical vars.
10395 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10396 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10397 (FletX, Flet): Obey lexical binding.
10398 (Fcommandp): Handle closures.
10399 (Feval): New `lexical' arg.
10400 (eval_sub): New function extracted from Feval. Use it almost
10401 everywhere where Feval was used. Look up vars in lexical env.
10403 (Ffunctionp): Move from subr.el.
10404 (Ffuncall): Handle closures.
10405 (apply_lambda): Remove `eval_flags'.
10406 (funcall_lambda): Handle closures and new byte-code-functions.
10407 (Fspecial_variable_p): New function.
10408 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10409 but without exporting it to Lisp.
10411 * doc.c (Fdocumentation, store_function_docstring):
10412 * data.c (Finteractive_form): Handle closures.
10414 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10417 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10419 (exec_byte_code): New function extracted from Fbyte_code to handle new
10420 calling convention for byte-code-functions. Add new byte-codes.
10422 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10424 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10426 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10428 * xdisp.c (redisplay_internal): Fix prototype.
10430 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10432 * xdisp.c (SCROLL_LIMIT): New macro.
10433 (try_scrolling): Use it when setting scroll_limit.
10434 Limit scrolling to 100 screen lines.
10435 (redisplay_window): Even when falling back on "recentering",
10436 position point in the window according to scroll-conservatively,
10437 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10439 (try_scrolling): When point is above the window, allow searching
10440 as far as scroll_max, or one screenful, to compute vertical
10441 distance from PT to the scroll margin position. This prevents
10442 try_scrolling from unnecessarily failing when
10443 scroll-conservatively is set to a value slightly larger than the
10444 window height. Clean up the case of PT below the margin at bottom
10445 of window: scroll_max can no longer be INT_MAX. When aggressive
10446 scrolling is in use, don't let point enter the opposite scroll
10447 margin as result of the scroll.
10448 (syms_of_xdisp) <scroll-conservatively>: Document the
10449 threshold of 100 lines for never-recentering scrolling.
10451 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10453 * dispextern.h (move_it_by_lines):
10454 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10455 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10456 (message_log_check_duplicate): Remove parameters `prev_bol' and
10457 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10458 (redisplay_internal): Remove parameter `preserve_echo_area',
10459 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10461 * indent.c (Fvertical_motion):
10462 * window.c (window_scroll_pixel_based, Frecenter):
10463 Don't pass `need_y_p' to `move_it_by_lines'.
10465 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10467 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10468 steal a few bits to be more compact.
10469 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10470 Remove unneeded casts.
10472 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10474 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10476 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10477 binding" message (bug#7967).
10479 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10481 Fix more problems found by GCC 4.6.0's static checks.
10483 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10484 Remove unused local var.
10486 * editfns.c (Fmessage_box): Remove unused local var.
10488 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10489 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10490 Omit unused local vars.
10491 * window.c (shrink_windows): Omit unused local var.
10492 * menu.c (digest_single_submenu): Omit unused local var.
10493 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10494 Omit unused local var.
10496 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10497 Don't assume string length fits in int.
10498 (keyremap_step, read_key_sequence): Use size_t for sizes.
10499 (read_key_sequence): Don't check last_real_key_start redundantly.
10501 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10502 instead of alloca (Bug#8344).
10504 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10505 (Fbacktrace_frame): Don't assume nframes fits in int.
10507 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10509 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10512 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10514 * cm.c (calccost): Turn while-do into do-while, for clarity.
10516 * keyboard.c (syms_of_keyboard): Use the same style as later
10517 in this function when indexing through an array. This also
10518 works around GCC bug 48267.
10520 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10522 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10524 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10525 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10527 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10528 This avoids undefined behavior on integer overflow, and is a bit
10529 more convenient anyway since it is compared to a size_t variable.
10531 Variadic C functions now count arguments with size_t, not int.
10532 This avoids an unnecessary limitation on 64-bit machines, which
10533 caused (substring ...) to crash on large vectors (Bug#8344).
10534 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10535 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10536 All variadic functions and their callers changed accordingly.
10537 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10538 * data.c (arith_driver, float_arith_driver): Likewise.
10539 * editfns.c (general_insert_function): Likewise.
10540 * eval.c (struct backtrace.nargs, interactive_p)
10541 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10542 (funcall_lambda, mark_backtrace): Likewise.
10543 * fns.c (concat): Likewise.
10544 * frame.c (x_set_frame_parameters): Likewise.
10545 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10546 0 if not found, not -1. All callers changed.
10548 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10549 (stack_copy_size): Now size_t, not int.
10550 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10552 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10554 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10555 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10556 All callers changed.
10558 * lisp.h (multibyte_char_to_unibyte):
10559 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10560 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10561 * character.h (CHAR_TO_BYTE8):
10562 * cmds.c (internal_self_insert):
10563 * editfns.c (general_insert_function):
10564 * keymap.c (push_key_description):
10565 * search.c (Freplace_match):
10566 * xdisp.c (message_dolog, set_message_1): All callers changed.
10568 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10570 * keyboard.c (safe_run_hook_funcall): New function.
10571 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10572 don't set the hook to nil, but remove the offending function instead.
10573 (Qcommand_hook_internal): Remove, unused.
10574 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10575 Vcommand_hook_internal.
10577 * eval.c (enum run_hooks_condition): Remove.
10578 (funcall_nil, funcall_not): New functions.
10579 (run_hook_with_args): Call each function through a `funcall' argument.
10580 Remove `cond' argument, now redundant.
10581 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10582 (Frun_hook_with_args_until_failure): Adjust accordingly.
10583 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10585 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10587 * dispextern.h (string_buffer_position): Remove declaration.
10589 * print.c (strout): Remove parameter `multibyte', unused since
10590 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10592 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10593 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10594 All callers changed.
10596 * w32.c (_wsa_errlist): Use braces for struct initializers.
10598 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10599 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10600 All callers changed.
10601 (string_buffer_position): Likewise. Also, make static (it's never
10602 used outside xdisp.c).
10603 (cursor_row_p): Remove parameter `w', unused since
10604 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10605 (decode_mode_spec): Remove parameter `precision', introduced during
10606 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10607 All callers changed.
10609 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10611 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10613 2011-03-27 Anders Lindgren <andlind@gmail.com>
10615 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10616 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10617 (ns_update_auto_hide_menu_bar): New functions.
10618 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10619 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10620 ns_constrain_all_frames.
10621 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10622 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10624 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10626 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10628 2011-03-27 Glenn Morris <rgm@gnu.org>
10630 * syssignal.h: Replace RETSIGTYPE with void.
10631 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10632 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10633 Replace SIGTYPE with void everywhere.
10634 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10635 * s/template.h (SIGTYPE): Remove commented out definition.
10637 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10639 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10640 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10642 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10644 * w32.c (read_unc_volume): Use parameter `henum', instead of
10645 global variable `wget_enum_handle'.
10647 * keymap.c (describe_vector): Remove parameters `indices' and
10648 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10649 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10651 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10653 * keyboard.c (timer_check): Remove parameter `do_it_now',
10654 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10655 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10656 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10658 * keyboard.c (read_char):
10659 * w32menu.c (w32_menu_display_help):
10660 * xmenu.c (show_help_event, menu_help_callback):
10661 Adjust calls to `show_help_echo'.
10663 * gtkutil.c (xg_maybe_add_timer):
10664 * keyboard.c (readable_events):
10665 * process.c (wait_reading_process_output):
10666 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10668 * insdel.c (adjust_markers_gap_motion):
10669 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10670 (gap_left, gap_right): Don't call it.
10672 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10674 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10675 incurred during fontification.
10677 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10679 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10680 (DEFVAR_PER_BUFFER): Don't pass it.
10682 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10683 (scrolling_window): Don't pass it.
10685 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10687 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10689 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10691 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10692 of variables specific to SELinux and computation of `encoded_absname'.
10694 * image.c (XPutPixel): Remove unused variable `height'.
10696 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10698 * unexw32.c (get_section_info): Remove unused variable `section'.
10700 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10701 (system_process_attributes): Remove unused variable `sess'.
10702 (sys_read): Remove unused variable `err'.
10704 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10705 (w32_wnd_proc): Remove unused variable `isdead'.
10706 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10707 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10708 (x_create_tip_frame): Remove unused variable `tem'.
10710 * w32inevt.c (w32_console_read_socket):
10711 Remove unused variable `no_events'.
10713 * w32term.c (x_draw_composite_glyph_string_foreground):
10714 Remove unused variable `width'.
10716 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10718 * w32term.c (x_set_glyph_string_clipping):
10719 Don't pass uninitialized region to CombineRgn.
10721 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10723 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10724 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10725 (Fx_close_connection): Remove unused variable `i'.
10727 * w32font.c (w32font_draw): Return number of glyphs.
10728 (w32font_open_internal): Remove unused variable `i'.
10729 (w32font_driver): Add missing initializer.
10731 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10732 (fill_in_menu): Remove unused variable `items_added'.
10734 * w32term.c (last_mouse_press_frame): Remove static global variable.
10735 (w32_clip_to_row): Remove unused variable `f'.
10736 (x_delete_terminal): Remove unused variable `i'.
10738 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10739 (NOTHING): Remove unused static global variable.
10740 (uniscribe_check_otf): Remove unused variable `table'.
10741 (uniscribe_font_driver): Add missing initializers.
10743 2011-03-23 Julien Danjou <julien@danjou.info>
10745 * term.c (Fsuspend_tty, Fresume_tty):
10746 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10747 * window.c (temp_output_buffer_show):
10748 * insdel.c (signal_before_change):
10749 * frame.c (Fhandle_switch_frame):
10750 * fileio.c (Fdo_auto_save):
10751 * emacs.c (Fkill_emacs):
10752 * editfns.c (save_excursion_restore):
10753 * cmds.c (internal_self_insert):
10754 * callint.c (Fcall_interactively):
10755 * buffer.c (Fkill_all_local_variables):
10756 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10758 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10759 unconditionally since it does the check itself.
10761 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10763 Fix more problems found by GCC 4.5.2's static checks.
10765 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10766 the first time through the loop, since we know p0 < p1 then.
10767 This also avoids a gcc -Wstrict-overflow warning.
10769 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10770 leading to a memory leak, possible in functions like
10771 load_charset_map_from_file that can allocate an unbounded number
10772 of objects (Bug#8318).
10774 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10775 that could (at least in theory) be that large.
10777 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10778 This is less likely to overflow, and avoids undefined behavior if
10779 overflow does occur. All callers changed. Use strtoul to scan
10780 for the unsigned long integer.
10781 (pint2hrstr): Simplify and tune code slightly.
10782 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10784 * scroll.c (do_scrolling): Work around GCC bug 48228.
10785 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10787 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10788 This also avoids a warning with gcc -Wstrict-overflow.
10789 (validate_x_resource_name): Simplify count usage.
10790 This also avoids a warning with gcc -Wstrict-overflow.
10792 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10795 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10797 * process.c (Fmake_network_process): Use socklen_t, not int,
10798 where POSIX says socklen_t is required in portable programs.
10799 This fixes a porting bug on hosts like 64-bit HP-UX, where
10800 socklen_t is wider than int (Bug#8277).
10801 (Fmake_network_process, server_accept_connection):
10802 (wait_reading_process_output, read_process_output):
10805 * process.c: Rename or move locals to avoid shadowing.
10806 (list_processes_1, Fmake_network_process):
10807 (read_process_output_error_handler, exec_sentinel_error_handler):
10808 Rename or move locals.
10809 (Fmake_network_process): Define label "retry_connect" only if needed.
10810 (Fnetwork_interface_info): Fix pointer signedness.
10811 (process_send_signal): Add cast to avoid pointer signedness problem.
10812 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10813 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10815 Make tparam.h and terminfo.c consistent.
10816 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10817 Include tparam.h instead, since it declares them.
10818 * cm.h (PC): Remove extern decl; tparam.h now does this.
10819 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10820 * terminfo.c: Include tparam.h, to check interfaces.
10821 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10822 (tparam): Adjust signature to match interface in tparam.h;
10823 this removes some undefined behavior. Check that outstring and len
10824 are zero, which they always are with Emacs.
10825 * tparam.h (PC, BC, UP): New extern decls.
10827 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10828 (xftfont_open): Rename locals to avoid shadowing.
10830 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10831 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10832 (OTF_TAG_SYM): Omit macro if not needed.
10833 (ftfont_list): Remove unused local.
10834 (get_adstyle_property, ftfont_pattern_entity):
10835 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10836 Rename locals to avoid shadowing.
10838 * xfont.c (xfont_list_family): Mark var as initialized.
10840 * xml.c (make_dom): Now static.
10842 * composite.c (composition_compute_stop_pos): Rename local to
10844 (composition_reseat_it): Remove unused locals.
10845 (find_automatic_composition, composition_adjust_point): Likewise.
10846 (composition_update_it): Mark var as initialized.
10847 (find_automatic_composition): Mark vars as initialized,
10848 with a FIXME (Bug#8290).
10850 character.h: Rename locals to avoid shadowing.
10851 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10852 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10853 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10854 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10855 to avoid shadowing.
10857 * textprop.c (property_change_between_p): Remove; unused.
10859 * intervals.c (interval_start_pos): Now static.
10861 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10863 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10864 Rename locals to avoid shadowing.
10866 * sound.c (wav_play, au_play, Fplay_sound_internal):
10867 Fix pointer signedness.
10868 (alsa_choose_format): Remove unused local var.
10869 (wav_play): Initialize a variable to 0, to prevent undefined
10870 behavior (Bug#8278).
10872 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10874 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10876 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10877 clobbering (Bug#8298).
10878 * sysdep.c (sys_subshell): Likewise.
10879 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10881 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10882 This should get cleaned up, so that child_setup has the
10883 same signature on all platforms.
10885 * callproc.c (call_process_cleanup): Now static.
10886 (relocate_fd): Rename locals to avoid shadowing.
10888 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10890 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10891 not to be necessary, and produces flickering.
10893 2011-03-20 Glenn Morris <rgm@gnu.org>
10895 * config.in: Remove file.
10897 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10899 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10900 are now in src/globals.h.
10901 (syms_of_minibuf): Remove spurious & from previous change.
10903 2011-03-20 Leo Liu <sdl.web@gmail.com>
10905 * minibuf.c (completing-read-function): New variable.
10906 (completing-read-default): Rename from completing-read.
10907 (completing-read): Call completing-read-function.
10909 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10911 * xfaces.c (Fx_load_color_file):
10912 Read color file from absolute filename (bug#8250).
10914 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10916 * makefile.w32-in: Update dependencies.
10918 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10920 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10922 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10924 Fix more problems found by GCC 4.5.2's static checks.
10926 * process.c (make_serial_process_unwind, send_process_trap):
10927 (sigchld_handler): Now static.
10929 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10930 That way, the code declares only the vars that it needs.
10931 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10932 * s/cygwin.h (PTY_ITERATION): Likewise.
10933 * s/darwin.h (PTY_ITERATION): Likewise.
10934 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10936 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10937 * process.c (allocate_pty): Don't declare stb unless it's needed.
10939 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10940 (CONSTANTLIM): Remove; unused.
10941 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10942 Define only if needed.
10944 * unexelf.c (unexec): Name an expression,
10945 to avoid gcc -Wbad-function-cast warning.
10946 Use a different way to cause a compilation error if anyone uses
10947 n rather than nn, a way that does not involve shadowing.
10948 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10950 * deps.mk (unexalpha.o): Remove; unused.
10952 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10953 * unexec.h: New file.
10954 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10955 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10956 Depend on unexec.h.
10957 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10958 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10959 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10960 Change as necessary to match prototype in unexec.h.
10962 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10964 (back_comment, skip_chars): Mark vars as initialized.
10966 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10967 Rename locals to avoid shadowing.
10969 * lread.c (read1): Rewrite so as not to use empty "else".
10970 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10972 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10974 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10975 warning when compiling print.c.
10977 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10978 instead of using an uninitialized var.
10979 (font_sort_entities): Mark var as initialized.
10981 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10983 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10984 pointers to constants.
10985 (font_parse_fcname): Remove unused vars.
10986 (font_delete_unmatched): Now static.
10987 (font_get_spec): Remove; unused.
10988 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10989 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10990 Rename or move locals to avoid shadowing.
10992 * fns.c (require_nesting_list, require_unwind): Now static.
10993 (Ffillarray): Rename locals to avoid shadowing.
10995 * floatfns.c (domain_error2): Define only if needed.
10996 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10998 * alloc.c (mark_backtrace): Move decl from here ...
10999 * lisp.h: ... to here, so that it can be checked.
11001 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11002 (Fdefvar): Rewrite so as not to use empty "else".
11003 (lisp_indirect_variable): Name an expression,
11004 to avoid gcc -Wbad-function-cast warning.
11005 (Fdefvar): Rename locals to avoid shadowing.
11007 * callint.c (quotify_arg, quotify_args): Now static.
11008 (Fcall_interactively): Rename locals to avoid shadowing.
11009 Use const pointer when appropriate.
11011 * lisp.h (get_system_name, get_operating_system_release):
11012 Move decls here, to check interfaces.
11013 * process.c (get_operating_system_release): Move decl to lisp.h.
11014 * xrdb.c (get_system_name): Likewise.
11015 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11016 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11017 some of which prompt warnings from gcc -Wbad-function-cast.
11018 (Fformat_time_string, Fencode_time, Finsert_char):
11019 (Ftranslate_region_internal, Fformat):
11020 Rename or remove local vars to avoid shadowing.
11021 (Ftranslate_region_internal): Mark var as initialized.
11023 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11026 * lisp.h (eassert): Check that the argument compiles, even if
11027 ENABLE_CHECKING is not defined.
11029 * data.c (Findirect_variable): Name an expression, to avoid
11030 gcc -Wbad-function-cast warning.
11031 (default_value, arithcompare, arith_driver, arith_error): Now static.
11032 (store_symval_forwarding): Rename local to avoid shadowing.
11033 (Fmake_variable_buffer_local, Fmake_local_variable):
11034 Mark variables as initialized.
11035 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11037 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11038 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11039 Rename locals to avoid shadowing.
11040 (mark_stack): Move local variables into the #ifdef region where
11042 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11043 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11045 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11046 (GC_STRING_CHARS): Remove; not used.
11047 (Fmemory_limit): Cast sbrk's returned value to char *.
11049 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11050 avoids undefined behavior in theory.
11052 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11054 Use functions, not macros, for up- and down-casing (Bug#8254).
11055 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11056 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11057 to use the following functions instead of these macros.
11058 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11059 EMACS_INT, since callers assume the returned value fits in int.
11060 (upcase1): Likewise, for UPCASE_TABLE.
11061 (uppercasep, lowercasep, upcase): New static inline functions.
11062 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11063 the race-condition problem in the old DOWNCASE.
11065 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11066 Rename locals to avoid shadowing.
11067 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11068 (regex_compile, re_search_2, re_match_2_internal):
11069 Remove unused local vars.
11070 (FREE_VAR): Rewrite so as not to use empty "else",
11071 which gcc can warn about.
11072 (regex_compile, re_match_2_internal): Mark locals as initialized.
11073 (RETALLOC_IF): Define only if needed.
11074 (WORDCHAR_P): Likewise. This one is never needed, but is used
11075 only in a comment talking about a compiler bug, so put inside
11076 the #if 0 of that comment.
11077 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11078 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11081 * search.c (boyer_moore): Rename locals to avoid shadowing.
11082 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11083 (PREV_CHAR_BOUNDARY): Likewise.
11085 * search.c (simple_search): Remove unused var.
11087 * dired.c (compile_pattern): Move decl from here ...
11088 * lisp.h: ... to here, so that it can be checked.
11089 (struct re_registers): New forward decl.
11091 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11093 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11095 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11096 Rename locals to avoid shadowing.
11097 (Fvertical_motion): Mark locals as initialized.
11099 * casefiddle.c (casify_object, casify_region): Now static.
11100 (casify_region): Mark local as initialized.
11102 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11104 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11105 New macros, so that the caller can use some names other than
11106 gcpro1, gcpro2, etc.
11107 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11109 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11110 argument, for consistency with GCPRO2_VAR, etc: it is now the
11111 prefix of the variable, not the variable itself. All uses
11113 * dired.c (directory_files_internal, file_name_completion):
11114 Rename locals to avoid shadowing.
11116 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11117 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11118 dired.c's scmp function, had undefined behavior.
11119 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11120 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11121 * buffer.h: ... to here, because these macros use current_buffer,
11122 and the new implementation with inline functions needs to have
11123 current_buffer in scope now, rather than later when the macros
11125 (downcase, upcase1): New static inline functions.
11126 (DOWNCASE, UPCASE1): Reimplement using these functions.
11127 This avoids undefined behavior in expressions like
11128 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11129 from race conditions in accessing the global variables
11130 case_temp1 and case_temp2.
11131 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11132 * lisp.h (case_temp1, case_temp2): Remove their decls.
11133 * character.h (ASCII_CHAR_P): Move from here ...
11134 * lisp.h: ... to here, so that the inline functions mentioned
11135 above can use them.
11137 * dired.c (directory_files_internal_unwind): Now static.
11139 * fileio.c (file_name_as_directory, directory_file_name):
11140 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11142 (file_name_as_directory): Use const pointers when appropriate.
11143 (Fexpand_file_name): Likewise. In particular, newdir might
11144 point at constant storage, so make it a const pointer.
11145 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11146 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11148 (Fset_file_times, Finsert_file_contents, auto_save_error):
11149 Rename locals to avoid shadowing.
11151 * minibuf.c (choose_minibuf_frame_1): Now static.
11152 (Ftry_completion, Fall_completions): Rename or remove locals
11153 to avoid shadowing.
11155 * marker.c (bytepos_to_charpos): Remove; unused.
11157 * lisp.h (verify_bytepos, count_markers): New decls,
11158 so that gcc does not warn that these functions aren't declared.
11160 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11161 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11162 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11163 (copy_text): Remove unused local var.
11165 * filelock.c (within_one_second): Now static.
11166 (lock_file_1): Rename local to avoid shadowing.
11168 * buffer.c (fix_overlays_before): Mark locals as initialized.
11169 (fix_start_end_in_overlays): Likewise. This function should be
11170 simplified by using pointers-to-pointers, but that's a different
11172 (switch_to_buffer_1): Now static.
11173 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11174 (report_overlay_modification): Rename locals to avoid shadowing.
11176 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11177 Fix pointer signedness issue.
11178 (sys_subshell): Mark local as volatile if checking for lint,
11179 to suppress a gcc -Wclobbered warning that does not seem to be right.
11180 (MAXPATHLEN): Define only if needed.
11182 * process.c (serial_open, serial_configure): Move decls from here ...
11183 * systty.h: ... to here, so that they can be checked.
11185 * fns.c (get_random, seed_random): Move extern decls from here ...
11186 * lisp.h: ... to here, so that they can be checked.
11188 * sysdep.c (reset_io): Now static.
11189 (wait_for_termination_signal): Remove; unused.
11191 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11192 (copy_keymap_item, append_key, push_text_char_description):
11194 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11195 (DENSE_TABLE_SIZE): Remove; unused.
11196 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11197 (describe_map_tree):
11198 Rename locals to avoid shadowing.
11200 * keyboard.c: Declare functions static if they are not used elsewhere.
11201 (echo_char, echo_dash, cmd_error, top_level_2):
11202 (poll_for_input, handle_async_input): Now static.
11203 (read_char, kbd_buffer_get_event, make_lispy_position):
11204 (make_lispy_event, make_lispy_movement, apply_modifiers):
11205 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11206 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11207 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11208 (read_key_sequence, read_char): Mark locals as initialized.
11209 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11211 * keyboard.h (make_ctrl_char): New decl.
11212 (mark_kboards): Move decl here ...
11213 * alloc.c (mark_kboards): ... from here.
11215 * lisp.h (force_auto_save_soon): New decl.
11217 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11218 (DEFINE_DUMMY_FUNCTION): New macro.
11219 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11221 (main): Add casts to avoid warnings
11222 if GCC considers string literals to be constants.
11224 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11226 * dbusbind.c: Pointer signedness fixes.
11227 (xd_signature, xd_append_arg, xd_initialize):
11228 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11229 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11230 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11231 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11233 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11234 if GCC considers string literals to be constants.
11235 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11237 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11239 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11240 (print_preprocess, print_object): New macro to fix last change.
11242 * print.c (print_preprocess): Don't forget font objects.
11244 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11246 * emacs.c (USAGE3): Doc fixes.
11248 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11250 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11253 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11255 * lisp.h (VWindow_system, Qfile_name_history):
11256 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11257 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11258 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11260 * w32select.c: Don't #include "keyboard.h".
11261 (run_protected): Add extern declaration for waiting_for_input.
11263 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11264 * w32console.c (detect_input_pending, read_input_pending)
11265 (encode_terminal_code):
11266 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11267 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11268 (w32_system_caret_y, Qfile_name_history):
11269 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11270 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11271 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11272 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11273 * w32proc.c (Qlocal, report_file_error):
11274 * w32term.c (Vwindow_system, updating_frame):
11275 * w32uniscribe.c (initialized, uniscribe_font_driver):
11276 Remove unneeded extern declarations.
11278 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11280 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11282 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11284 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11285 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11286 These macros can no longer be used for assignment.
11288 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11289 Assign struct members directly, instead of using BUF_BEGV etc.
11290 (record_buffer_markers, fetch_buffer_markers): New functions for
11291 recording and fetching special buffer markers.
11292 (set_buffer_internal_1, set_buffer_temp): Use them.
11294 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11296 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11298 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11299 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11301 * xdisp.c (hscroll_window_tree):
11302 (reconsider_clip_changes): Use PT instead of BUF_PT.
11304 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11306 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11307 $(EMACS_ROOT)/lib/intprops.h.
11309 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11311 Fix more problems found by GCC 4.5.2's static checks.
11313 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11314 to unsigned char * to avoid compiler diagnostic.
11315 (xg_free_frame_widgets): Make it clear that a local variable is
11316 needed only if USE_GTK_TOOLTIP.
11317 (gdk_window_get_screen): Make it clear that this macro is needed
11318 only if USE_GTK_TOOLTIP.
11319 (int_gtk_range_get_value): New function, which avoids a diagnostic
11320 from gcc -Wbad-function-cast.
11321 (xg_set_toolkit_scroll_bar_thumb): Use it.
11322 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11323 diagnostic from gcc -Wbad-function-cast.
11324 (get_utf8_string, xg_get_file_with_chooser):
11325 Rename locals to avoid shadowing.
11326 (create_dialog): Move locals to avoid shadowing.
11328 * xgselect.c (xg_select): Remove unused var.
11330 * image.c (four_corners_best): Mark locals as initialized.
11331 (gif_load): Initialize transparent_p to zero (Bug#8238).
11332 Mark another local as initialized.
11333 (my_png_error, my_error_exit): Mark with NO_RETURN.
11335 * image.c (clear_image_cache): Now static.
11336 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11337 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11338 (x_edge_detection): Remove unnecessary cast that
11339 gcc -Wbad-function-cast diagnoses.
11340 (gif_load): Fix pointer signedness.
11341 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11342 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11344 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11346 Improve quality of tests for time stamp overflow.
11347 For example, without this patch (encode-time 0 0 0 1 1
11348 1152921504606846976) returns the obviously-bogus value (-948597
11349 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11350 reports time overflow. See
11351 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11352 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11353 * editfns.c: Include limits.h and intprops.h.
11354 (TIME_T_MIN, TIME_T_MAX): New macros.
11355 (time_overflow): Move earlier, to before first use.
11356 (hi_time, lo_time): New functions, for an accurate test for
11357 out-of-range times.
11358 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11359 (Fget_internal_run_time): Don't assume time_t fits in int.
11360 (make_time): Use list2 instead of Fcons twice.
11361 (Fdecode_time): More accurate test for out-of-range times.
11362 (check_tm_member): New function.
11363 (Fencode_time): Use it, to test for out-of-range times.
11364 (lisp_time_argument): Don't rely on undefined left-shift and
11365 right-shift behavior when checking for time stamp overflow.
11367 * editfns.c (time_overflow): New function, refactoring common code.
11368 (Fformat_time_string, Fdecode_time, Fencode_time):
11369 (Fcurrent_time_string): Use it.
11371 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11372 * dired.c (make_time): Move to ...
11373 * editfns.c (make_time): ... here.
11374 * systime.h: Note the move.
11376 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11378 * fringe.c (update_window_fringes): Remove unused variables.
11380 * unexmacosx.c (copy_data_segment): Also copy __got section.
11383 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11385 * termcap.c [MSDOS]: Include "msdos.h".
11386 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11387 Constify `char *' arguments and their references according to
11388 prototypes in tparam.h.
11390 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11392 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11393 Adapt all references accordingly.
11395 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11397 2011-03-11 Tom Tromey <tromey@redhat.com>
11399 * buffer.c (syms_of_buffer): Remove obsolete comment.
11401 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11403 * termhooks.h (encode_terminal_code): Declare prototype.
11405 * msdos.c (encode_terminal_code): Don't declare prototype.
11407 * term.c (encode_terminal_code): Now external again, used by
11408 w32console.c and msdos.c.
11410 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11411 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11413 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11415 Fix some minor problems found by GCC 4.5.2's static checks.
11417 * fringe.c (update_window_fringes): Mark locals as initialized
11419 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11421 * alloc.c (mark_fringe_data): Move decl from here ...
11422 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11423 to check its interface.
11424 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11426 * fontset.c (free_realized_fontset): Now static.
11427 (Fset_fontset_font): Rename local to avoid shadowing.
11428 (fontset_font): Mark local as initialized.
11429 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11431 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11433 * xselect.c (x_disown_buffer_selections): Remove; not used.
11434 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11435 (x_own_selection, Fx_disown_selection_internal): Rename locals
11436 to avoid shadowing.
11437 (x_handle_dnd_message): Remove local to avoid shadowing.
11439 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11440 so that the caller can use some name other than gcpro1.
11441 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11442 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11443 (Fx_backspace_delete_keys_p):
11444 Use them to avoid shadowing, and rename vars to avoid shadowing.
11445 (x_decode_color, x_set_name, x_window): Now static.
11446 (Fx_create_frame): Add braces to silence GCC warning.
11447 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11448 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11449 Remove unused locals.
11450 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11451 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11452 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11455 * xterm.h (x_mouse_leave): New decl.
11457 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11458 Remove unused functions.
11459 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11460 (x_calc_absolute_position): Now static.
11461 (XTread_socket): Don't define label "out" unless it's used.
11462 Don't declare local "event" unless it's used.
11463 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11464 unless they are used.
11465 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11466 (x_fatal_error_signal): Remove; not used.
11467 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11468 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11469 (x_error_catcher, x_connection_closed, x_error_handler):
11470 (x_error_quitter, xembed_send_message, x_iconify_frame):
11471 (my_log_handler): Rename locals to avoid shadowing.
11472 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11473 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11475 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11476 Rename or move locals to avoid shadowing.
11477 (tty_defined_color, merge_face_heights): Now static.
11478 (free_realized_faces_for_fontset): Remove; not used.
11479 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11480 does not deduce is never used uninitialized.
11481 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11482 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11484 * terminal.c (store_terminal_param): Now static.
11486 * xmenu.c (menu_highlight_callback): Now static.
11487 (set_frame_menubar): Remove unused local.
11488 (xmenu_show): Rename parameter to avoid shadowing.
11489 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11490 since they might point to immutable storage.
11491 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11492 since it's unused otherwise.
11494 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11495 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11496 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11497 avoids a gcc -Wuninitialized diagnostic.
11498 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11499 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11500 does not deduce are never used uninitialized.
11502 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11504 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11505 * window.c (window_loop, size_window):
11506 (run_window_configuration_change_hook, enlarge_window): Likewise.
11508 * window.c (display_buffer): Now static.
11509 (size_window): Mark variables that gcc -Wuninitialized
11510 does not deduce are never used uninitialized.
11511 * window.h (check_all_windows): New decl, to forestall
11512 gcc -Wmissing-prototypes diagnostic.
11513 * dispextern.h (bidi_dump_cached_states): Likewise.
11515 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11517 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11518 Include <limits.h>.
11519 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11520 and to avoid gcc -Wuninitialized warning.
11521 (load_charset_map): Mark variables that gcc -Wuninitialized
11522 does not deduce are never used uninitialized.
11523 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11525 * coding.c (coding_set_source, coding_set_destination):
11526 Use "else { /* comment */ }" rather than "else /* comment */;"
11527 for clarity, and to avoid gcc -Wempty-body warning.
11528 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11529 a block, when the outer 'i' will do.
11530 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11531 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11532 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11533 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11534 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11535 Rename locals to avoid shadowing.
11536 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11537 * coding.c (emacs_mule_char, encode_invocation_designation):
11538 Now static, since they're not used elsewhere.
11539 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11540 (decode_coding_object, encode_coding_object, detect_coding_system):
11541 (decode_coding_emacs_mule): Mark variables that gcc
11542 -Wuninitialized does not deduce are never used uninitialized.
11543 (detect_coding_iso_2022): Initialize a local variable that might
11544 be used uninitialized. Leave a FIXME because it's not clear that
11545 this initialization is needed. (Bug#8211)
11546 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11547 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11548 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11549 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11550 Remove unused macros.
11552 * category.c (hash_get_category_set): Remove unused local var.
11553 (copy_category_table): Now static, since it's not used elsewhere.
11554 * character.c (string_count_byte8): Likewise.
11556 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11557 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11559 * chartab.c (copy_sub_char_table): Now static, since it's not used
11561 (sub_char_table_ref_and_range, char_table_ref_and_range):
11562 Rename locals to avoid shadowing.
11563 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11565 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11566 (BIDI_BOB): Remove unused macro.
11568 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11569 deduce are never used uninitialized.
11570 * term.c (encode_terminal_code): Likewise.
11572 * term.c (encode_terminal_code): Now static. Remove unused local.
11574 * tparam.h: New file.
11575 * term.c, tparam.h: Include it.
11576 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11577 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11578 Move these decls to tparam.h, and make them agree with what
11579 is actually in tparam.c. The previous trick of using incompatible
11580 decls in different modules does not conform to the C standard.
11581 All callers of tparam changed to use tparam's actual API.
11582 * tparam.c (tparam1, tparam, tgoto):
11583 Use const pointers where appropriate.
11585 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11586 * cm.h (struct cm): Likewise.
11587 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11588 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11589 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11590 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11591 (turn_on_face, init_tty): Likewise.
11592 * termchar.h (struct tty_display_info): Likewise.
11594 * term.c (term_mouse_position): Rename local to avoid shadowing.
11596 * alloc.c (mark_ttys): Move decl from here ...
11597 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11599 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11601 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11603 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11605 * search.c (compile_pattern_1): Remove argument regp, unused since
11606 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11607 (compile_pattern): Don't pass it.
11609 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11611 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11612 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11614 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11616 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11618 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11619 gdk_window_get_screen, gdk_window_get_geometry,
11620 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11621 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11622 (xg_get_pixbuf_from_pixmap): New function.
11623 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11624 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11625 Call xg_get_pixbuf_from_pixmap instead of
11626 gdk_pixbuf_get_from_drawable.
11627 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11628 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11629 (xg_check_special_colors): Use GtkStyleContext and its functions
11631 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11632 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11633 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11634 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11635 Call gtk_widget_get_preferred_size.
11636 (xg_frame_resized): gdk_window_get_geometry only takes 5
11638 (xg_win_to_widget, xg_event_is_for_menubar):
11639 Call gdk_x11_window_lookup_for_display.
11640 (xg_set_widget_bg): New function.
11641 (delete_cb): New function.
11642 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11643 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11644 (xg_set_background_color): Call xg_set_widget_bg.
11645 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11646 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11647 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11648 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11650 (update_frame_tool_bar): Call gtk_widget_hide.
11651 (xg_initialize): Use GDK_KEY_g.
11653 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11655 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11657 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11658 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11659 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11661 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11663 * w32xfns.c (select_palette): Check success of RealizePalette against
11664 GDI_ERROR, not zero.
11666 See ChangeLog.11 for earlier changes.
11668 ;; Local Variables:
11672 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11674 This file is part of GNU Emacs.
11676 GNU Emacs is free software: you can redistribute it and/or modify
11677 it under the terms of the GNU General Public License as published by
11678 the Free Software Foundation, either version 3 of the License, or
11679 (at your option) any later version.
11681 GNU Emacs is distributed in the hope that it will be useful,
11682 but WITHOUT ANY WARRANTY; without even the implied warranty of
11683 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11684 GNU General Public License for more details.
11686 You should have received a copy of the GNU General Public License
11687 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.