]> code.delx.au - gnu-emacs/blobdiff - lisp/ediff-util.el
*** empty log message ***
[gnu-emacs] / lisp / ediff-util.el
index a87e45496484ac6e1eb5e1765ac432510bf95653..dff3c6bee6161e3c82cf00b3d7306b8ad1bdbcbf 100644 (file)
@@ -1,8 +1,9 @@
 ;;; ediff-util.el --- the core commands and utilities of ediff
 
-;; Copyright (C) 1994, 1995, 1996, 1997 Free Software Foundation, Inc.
+;; Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
+;;   2003, 2004, 2005, 2006 Free Software Foundation, Inc.
 
-;; Author: Michael Kifer <kifer@cs.sunysb.edu>
+;; Author: Michael Kifer <kifer@cs.stonybrook.edu>
 
 ;; This file is part of GNU Emacs.
 
 
 ;; You should have received a copy of the GNU General Public License
 ;; along with GNU Emacs; see the file COPYING.  If not, write to the
-;; Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-;; Boston, MA 02111-1307, USA.
+;; Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+;; Boston, MA 02110-1301, USA.
+
+;;; Commentary:
 
 ;;; Code:
-        
-(provide 'ediff-util)
+
 
 ;; Compiler pacifier
 (defvar ediff-patch-diagnostics)
 (defvar ediff-patchbufer)
+(defvar ediff-use-toolbar-p)
+(defvar ediff-toolbar-height)
 (defvar ediff-toolbar)
 (defvar ediff-toolbar-3way)
 (defvar bottom-toolbar)
 (defvar bottom-toolbar-visible-p)
 (defvar bottom-toolbar-height)
 (defvar mark-active)
+(defvar ediff-emacs-p)
+
+(defvar ediff-after-quit-hook-internal nil)
+
+(and noninteractive
+     (eval-when-compile
+        (load "reporter" 'noerror)))
 
 (eval-when-compile
   (let ((load-path (cons (expand-file-name ".") load-path)))
+    (provide 'ediff-util) ; to break recursive load cycle
     (or (featurep 'ediff-init)
        (load "ediff-init.el" nil nil 'nosuffix))
     (or (featurep 'ediff-help)
     (or (featurep 'ediff)
        (load "ediff.el" nil nil 'nosuffix))
     (or (featurep 'ediff-tbar)
+       ediff-emacs-p
        (load "ediff-tbar.el" 'noerror nil 'nosuffix))
     ))
 ;; end pacifier
 
+
 (require 'ediff-init)
 (require 'ediff-help)
 (require 'ediff-mult)
 (require 'ediff-diff)
 (require 'ediff-merg)
 
-
-;; be careful with ediff-tbar
 (if ediff-xemacs-p
-    (condition-case nil
-       (require 'ediff-tbar)
-      (error
-       (defun ediff-use-toolbar-p () nil)))
-  (defun ediff-use-toolbar-p () nil))
+    (require 'ediff-tbar))
 
 \f
 ;;; Functions
@@ -109,9 +117,15 @@ Commands:
   (kill-all-local-variables)
   (setq major-mode 'ediff-mode)
   (setq mode-name "Ediff")
+  ;; We use run-hooks instead of run-mode-hooks for two reasons.
+  ;; The ediff control buffer is read-only and it is not supposed to be
+  ;; modified by minor modes and such. So, run-mode-hooks doesn't do anything
+  ;; useful here on top of what run-hooks does.
+  ;; Second, changing run-hooks to run-mode-hooks would require an
+  ;; if-statement, since XEmacs doesn't have this. 
   (run-hooks 'ediff-mode-hook))
 
-    
+
 \f
 ;;; Build keymaps
 
@@ -126,29 +140,30 @@ to invocation.")
   (if (null ediff-mode-map)
       (ediff-setup-keymap))
   (use-local-map ediff-mode-map))
-  
+
 ;; Reload Ediff keymap.  For debugging only.
 (defun ediff-reload-keymap ()
   (interactive)
   (setq ediff-mode-map nil)
   (ediff-set-keys))
-  
+
 
 (defun ediff-setup-keymap ()
   "Set up the keymap used in the control buffer of Ediff."
   (setq ediff-mode-map (make-sparse-keymap))
   (suppress-keymap ediff-mode-map)
-  
+
   (define-key ediff-mode-map
     (if ediff-emacs-p [mouse-2] [button2]) 'ediff-help-for-quick-help)
   (define-key ediff-mode-map "\C-m"  'ediff-help-for-quick-help)
 
   (define-key ediff-mode-map "p" 'ediff-previous-difference)
   (define-key ediff-mode-map "\C-?" 'ediff-previous-difference)
-  (define-key ediff-mode-map [backspace] 'ediff-previous-difference)
   (define-key ediff-mode-map [delete] 'ediff-previous-difference)
   (define-key ediff-mode-map "\C-h" (if ediff-no-emacs-help-in-control-buffer
                                        'ediff-previous-difference nil))
+  ;; must come after C-h, or else C-h wipes out backspace's binding in XEmacs
+  (define-key ediff-mode-map [backspace] 'ediff-previous-difference)
   (define-key ediff-mode-map "n" 'ediff-next-difference)
   (define-key ediff-mode-map " " 'ediff-next-difference)
   (define-key ediff-mode-map "j" 'ediff-jump-to-difference)
@@ -177,7 +192,7 @@ to invocation.")
   (define-key ediff-mode-map "E" 'ediff-documentation)
   (define-key ediff-mode-map "?" 'ediff-toggle-help)
   (define-key ediff-mode-map "!" 'ediff-update-diffs)
-  (define-key ediff-mode-map "M" 'ediff-show-meta-buffer)
+  (define-key ediff-mode-map "M" 'ediff-show-current-session-meta-buffer)
   (define-key ediff-mode-map "R" 'ediff-show-registry)
   (or ediff-word-mode
       (define-key ediff-mode-map "*" 'ediff-make-or-kill-fine-diffs))
@@ -193,7 +208,9 @@ to invocation.")
         (define-key ediff-mode-map "r" 'ediff-restore-diff-in-merge-buffer)
         (define-key ediff-mode-map "s" 'ediff-shrink-window-C)
         (define-key ediff-mode-map "+" 'ediff-combine-diffs)
-        (define-key ediff-mode-map "$" 'ediff-toggle-show-clashes-only)
+        (define-key ediff-mode-map "$"  nil)
+        (define-key ediff-mode-map "$$" 'ediff-toggle-show-clashes-only)
+        (define-key ediff-mode-map "$*" 'ediff-toggle-skip-changed-regions)
         (define-key ediff-mode-map "&" 'ediff-re-merge))
        (ediff-3way-comparison-job
         (define-key ediff-mode-map "ab" 'ediff-copy-A-to-B)
@@ -217,6 +234,7 @@ to invocation.")
   (define-key ediff-mode-map "#"  nil)
   (define-key ediff-mode-map "#h"  'ediff-toggle-regexp-match)
   (define-key ediff-mode-map "#f"  'ediff-toggle-regexp-match)
+  (define-key ediff-mode-map "#c"  'ediff-toggle-ignore-case)
   (or ediff-word-mode
       (define-key ediff-mode-map "##"  'ediff-toggle-skip-similar))
   (define-key ediff-mode-map "o"   nil)
@@ -227,7 +245,7 @@ to invocation.")
   (define-key ediff-mode-map "wb"  'ediff-save-buffer)
   (define-key ediff-mode-map "wd"  'ediff-save-buffer)
   (define-key ediff-mode-map "="   'ediff-inferior-compare-regions)
-  (if (fboundp 'ediff-show-patch-diagnostics)
+  (if (and (fboundp 'ediff-show-patch-diagnostics) (ediff-patch-job))
       (define-key ediff-mode-map "P"  'ediff-show-patch-diagnostics))
   (if ediff-3way-job
       (progn
@@ -236,7 +254,7 @@ to invocation.")
        ))
 
   (define-key ediff-mode-map "m" 'ediff-toggle-wide-display)
-       
+
   ;; Allow ediff-mode-map to be referenced indirectly
   (fset 'ediff-mode-map ediff-mode-map)
   (run-hooks 'ediff-keymap-setup-hook))
@@ -250,7 +268,9 @@ to invocation.")
 ;; STARTUP-HOOKS, but these parameters are set in the new control buffer right
 ;; after this buf is created and before any windows are set and such.
 (defun ediff-setup (buffer-A file-A buffer-B file-B buffer-C file-C
-                            startup-hooks setup-parameters)
+                            startup-hooks setup-parameters
+                            &optional merge-buffer-file)
+  (run-hooks 'ediff-before-setup-hook)
   ;; ediff-convert-standard-filename puts file names in the form appropriate
   ;; for the OS at hand.
   (setq file-A (ediff-convert-standard-filename (expand-file-name file-A)))
@@ -258,13 +278,28 @@ to invocation.")
   (if (stringp file-C)
       (setq file-C
            (ediff-convert-standard-filename (expand-file-name file-C))))
-  (let* ((control-buffer-name 
+  (if (stringp merge-buffer-file)
+      (progn
+       (setq merge-buffer-file
+             (ediff-convert-standard-filename
+              (expand-file-name merge-buffer-file)))
+       ;; check the directory exists
+       (or (file-exists-p (file-name-directory merge-buffer-file))
+           (error "Directory %s given as place to save the merge doesn't exist"
+                  (abbreviate-file-name
+                   (file-name-directory merge-buffer-file))))
+       (if (and (file-exists-p merge-buffer-file)
+                (file-directory-p merge-buffer-file))
+           (error "The merge buffer file %s must not be a directory"
+                  (abbreviate-file-name merge-buffer-file)))
+       ))
+  (let* ((control-buffer-name
          (ediff-unique-buffer-name "*Ediff Control Panel" "*"))
-        (control-buffer (ediff-eval-in-buffer buffer-A
+        (control-buffer (ediff-with-current-buffer buffer-A
                           (get-buffer-create control-buffer-name))))
-    (ediff-eval-in-buffer control-buffer
-      (ediff-mode)                 
-       
+    (ediff-with-current-buffer control-buffer
+      (ediff-mode)
+
       (make-local-variable 'ediff-use-long-help-message)
       (make-local-variable 'ediff-prefer-iconified-control-frame)
       (make-local-variable 'ediff-split-window-function)
@@ -272,12 +307,17 @@ to invocation.")
       (make-local-variable 'ediff-merge-window-share)
       (make-local-variable 'ediff-window-setup-function)
       (make-local-variable 'ediff-keep-variants)
-      
+
+      (ediff-cond-compile-for-xemacs-or-emacs
+       (make-local-hook 'ediff-after-quit-hook-internal) ; xemacs form
+       nil ; emacs form
+       )
+
       ;; unwrap set up parameters passed as argument
       (while setup-parameters
        (set (car (car setup-parameters)) (cdr (car setup-parameters)))
        (setq setup-parameters (cdr setup-parameters)))
-       
+
       ;; set variables classifying the current ediff job
       ;; must come AFTER setup-parameters
       (setq ediff-3way-comparison-job (ediff-3way-comparison-job)
@@ -290,51 +330,58 @@ to invocation.")
            ediff-word-mode-job (ediff-word-mode-job))
 
       ;; Don't delete variants in case of ediff-buffer-* jobs without asking.
-      ;; This is because u may loose work---dangerous.
+      ;; This is because one may loose work---dangerous.
       (if (string-match "buffer" (symbol-name ediff-job-name))
          (setq ediff-keep-variants t))
 
-      (make-local-hook 'pre-command-hook)
+      (ediff-cond-compile-for-xemacs-or-emacs
+       (make-local-hook 'pre-command-hook) ; xemacs form
+       nil                                 ; emacs form
+       )
+
       (if (ediff-window-display-p)
-         (add-hook 'pre-command-hook 'ediff-spy-after-mouse nil t))
+         (add-hook 'pre-command-hook 'ediff-spy-after-mouse nil 'local))
       (setq ediff-mouse-pixel-position (mouse-pixel-position))
-      
+
       ;; adjust for merge jobs
       (if ediff-merge-job
          (let ((buf
                 ;; If default variant is `combined', the right stuff is
                 ;; inserted by ediff-do-merge
                 ;; Note: at some point, we tried to put ancestor buffer here
-                ;; (which is currently buffer C. This didn't work right
+                ;; (which is currently buffer C.  This didn't work right
                 ;; because the merge buffer will contain lossage: diff regions
                 ;; in the ancestor, which correspond to revisions that agree
                 ;; in both buf A and B.
                 (cond ((eq ediff-default-variant 'default-B)
                        buffer-B)
                       (t buffer-A))))
-                
+
            (setq ediff-split-window-function
-                 ediff-merge-split-window-function) 
-           
+                 ediff-merge-split-window-function)
+
            ;; remember the ancestor buffer, if any
            (setq ediff-ancestor-buffer buffer-C)
-           
+
            (setq buffer-C
                  (get-buffer-create
                   (ediff-unique-buffer-name "*ediff-merge" "*")))
            (save-excursion
              (set-buffer buffer-C)
-             (insert-buffer buf)
-             (funcall (ediff-eval-in-buffer buf major-mode))
-             ;; after Stig@hackvan.com
+             (insert-buffer-substring buf)
+             (goto-char (point-min))
+             (funcall (ediff-with-current-buffer buf major-mode))
+             (widen) ; merge buffer is always widened
              (add-hook 'local-write-file-hooks 'ediff-set-merge-mode nil t)
              )))
-      (setq buffer-read-only nil    
+      (setq buffer-read-only nil
            ediff-buffer-A buffer-A
            ediff-buffer-B buffer-B
            ediff-buffer-C buffer-C
            ediff-control-buffer control-buffer)
-          
+
+      (ediff-choose-syntax-table)
+
       (setq ediff-control-buffer-suffix
            (if (string-match "<[0-9]*>" control-buffer-name)
                (substring control-buffer-name
@@ -350,27 +397,27 @@ to invocation.")
                (or
                 (string-match "[0-9]+" ediff-control-buffer-suffix)
                 0))))))
-          
+
       (setq ediff-error-buffer
            (get-buffer-create (ediff-unique-buffer-name "*ediff-errors" "*")))
-      
-      (ediff-eval-in-buffer buffer-A (ediff-strip-mode-line-format))
-      (ediff-eval-in-buffer buffer-B (ediff-strip-mode-line-format))
+
+      (ediff-with-current-buffer buffer-A (ediff-strip-mode-line-format))
+      (ediff-with-current-buffer buffer-B (ediff-strip-mode-line-format))
       (if ediff-3way-job
-         (ediff-eval-in-buffer buffer-C (ediff-strip-mode-line-format)))
+         (ediff-with-current-buffer buffer-C (ediff-strip-mode-line-format)))
       (if (ediff-buffer-live-p ediff-ancestor-buffer)
-         (ediff-eval-in-buffer ediff-ancestor-buffer
+         (ediff-with-current-buffer ediff-ancestor-buffer
            (ediff-strip-mode-line-format)))
-      
+
       (ediff-save-protected-variables) ; save variables to be restored on exit
-      
+
       ;; ediff-setup-diff-regions-function must be set after setup
       ;; parameters are processed.
       (setq ediff-setup-diff-regions-function
            (if ediff-diff3-job
                'ediff-setup-diff-regions3
              'ediff-setup-diff-regions))
-       
+
       (setq ediff-wide-bounds
            (list (ediff-make-bullet-proof-overlay
                   '(point-min) '(point-max) ediff-buffer-A)
@@ -378,27 +425,27 @@ to invocation.")
                   '(point-min) '(point-max) ediff-buffer-B)
                  (ediff-make-bullet-proof-overlay
                   '(point-min) '(point-max) ediff-buffer-C)))
-      
+
       ;; This has effect only on ediff-windows/regions
       ;; In all other cases, ediff-visible-region sets visibility bounds to
       ;; ediff-wide-bounds, and ediff-narrow-bounds are ignored.
       (if ediff-start-narrowed
          (setq ediff-visible-bounds ediff-narrow-bounds)
        (setq ediff-visible-bounds ediff-wide-bounds))
-      
+
       (ediff-set-keys) ; comes after parameter setup
-      
+
       ;; set up ediff-narrow-bounds, if not set
       (or ediff-narrow-bounds
          (setq ediff-narrow-bounds ediff-wide-bounds))
-      
-      ;; All these must be inside ediff-eval-in-buffer control-buffer,
+
+      ;; All these must be inside ediff-with-current-buffer control-buffer,
       ;; since these vars are local to control-buffer
       ;; These won't run if there are errors in diff
-      (ediff-eval-in-buffer ediff-buffer-A
+      (ediff-with-current-buffer ediff-buffer-A
        (ediff-nuke-selective-display)
        (run-hooks 'ediff-prepare-buffer-hook)
-       (if (ediff-eval-in-buffer control-buffer ediff-merge-job)
+       (if (ediff-with-current-buffer control-buffer ediff-merge-job)
            (setq buffer-read-only t))
        ;; add control-buffer to the list of sessions--no longer used, but may
        ;; be used again in the future
@@ -409,10 +456,10 @@ to invocation.")
            (setq buffer-read-only t))
        )
 
-      (ediff-eval-in-buffer ediff-buffer-B
+      (ediff-with-current-buffer ediff-buffer-B
        (ediff-nuke-selective-display)
        (run-hooks 'ediff-prepare-buffer-hook)
-       (if (ediff-eval-in-buffer control-buffer ediff-merge-job)
+       (if (ediff-with-current-buffer control-buffer ediff-merge-job)
            (setq buffer-read-only t))
        ;; add control-buffer to the list of sessions
        (or (memq control-buffer ediff-this-buffer-ediff-sessions)
@@ -423,20 +470,25 @@ to invocation.")
        )
 
       (if ediff-3way-job
-         (ediff-eval-in-buffer ediff-buffer-C
+         (ediff-with-current-buffer ediff-buffer-C
            (ediff-nuke-selective-display)
+           ;; the merge bufer should never be narrowed
+           ;; (it can happen if it is on rmail-mode or similar)
+           (if (ediff-with-current-buffer control-buffer ediff-merge-job)
+               (widen))
            (run-hooks 'ediff-prepare-buffer-hook)
            ;; add control-buffer to the list of sessions
            (or (memq control-buffer ediff-this-buffer-ediff-sessions)
                (setq ediff-this-buffer-ediff-sessions
                      (cons control-buffer
-                           ediff-this-buffer-ediff-sessions))) 
+                           ediff-this-buffer-ediff-sessions)))
            (if ediff-make-buffers-readonly-at-startup
-               (setq buffer-read-only t))
+               (setq buffer-read-only t)
+             (setq buffer-read-only nil))
            ))
 
       (if (ediff-buffer-live-p ediff-ancestor-buffer)
-         (ediff-eval-in-buffer ediff-ancestor-buffer
+         (ediff-with-current-buffer ediff-ancestor-buffer
            (ediff-nuke-selective-display)
            (setq buffer-read-only t)
            (run-hooks 'ediff-prepare-buffer-hook)
@@ -445,22 +497,22 @@ to invocation.")
                      (cons control-buffer
                            ediff-this-buffer-ediff-sessions)))
            ))
-      
-      ;; must come after setting up  ediff-narrow-bounds AND after
+
+      ;; the following must be after setting up  ediff-narrow-bounds AND after
       ;; nuking selective display
       (funcall ediff-setup-diff-regions-function file-A file-B file-C)
       (setq ediff-number-of-differences (length ediff-difference-vector-A))
       (setq ediff-current-difference -1)
-      
+
       (ediff-make-current-diff-overlay 'A)
       (ediff-make-current-diff-overlay 'B)
       (if ediff-3way-job
          (ediff-make-current-diff-overlay 'C))
       (if ediff-merge-with-ancestor-job
          (ediff-make-current-diff-overlay 'Ancestor))
-         
+
       (ediff-setup-windows buffer-A buffer-B buffer-C control-buffer)
-      
+
       (let ((shift-A (ediff-overlay-start
                      (ediff-get-value-according-to-buffer-type
                       'A ediff-narrow-bounds)))
@@ -483,25 +535,28 @@ to invocation.")
              (select-window ediff-window-C)
              (goto-char shift-C)))
        )
-      
+
       (select-window ediff-control-window)
       (ediff-visible-region)
-      
+
       (run-hooks 'startup-hooks)
+      (ediff-arrange-autosave-in-merge-jobs merge-buffer-file)
+
       (ediff-refresh-mode-lines)
       (setq buffer-read-only t)
       (setq ediff-session-registry
            (cons control-buffer ediff-session-registry))
       (ediff-update-registry)
       (if (ediff-buffer-live-p ediff-meta-buffer)
-         (ediff-update-meta-buffer ediff-meta-buffer))
+         (ediff-update-meta-buffer
+          ediff-meta-buffer nil ediff-meta-session-number))
       (run-hooks 'ediff-startup-hook)
       ) ; eval in control-buffer
     control-buffer))
-      
-      
+
+
 ;; This function assumes that we are in the window where control buffer is
-;; to reside. 
+;; to reside.
 (defun ediff-setup-control-buffer (ctl-buf)
   "Set up window for control buffer."
   (if (window-dedicated-p (selected-window))
@@ -534,12 +589,31 @@ to invocation.")
        (ediff-make-bottom-toolbar)) ; this checks if toolbar is requested
     (goto-char (point-min))
     (skip-chars-forward ediff-whitespace)))
-    
-    
+
+;; This executes in control buffer and sets auto-save, visited file name, etc,
+;; in the merge buffer
+(defun ediff-arrange-autosave-in-merge-jobs (merge-buffer-file)
+  (if (not ediff-merge-job)
+      ()
+    (if (stringp merge-buffer-file)
+       (setq ediff-autostore-merges t
+             ediff-merge-store-file merge-buffer-file))
+    (if (stringp ediff-merge-store-file)
+       (progn
+         ;; save before leaving ctl buffer
+         (ediff-verify-file-merge-buffer ediff-merge-store-file)
+         (setq merge-buffer-file ediff-merge-store-file)
+         (ediff-with-current-buffer ediff-buffer-C
+           (set-visited-file-name merge-buffer-file))))
+    (ediff-with-current-buffer ediff-buffer-C
+      (setq buffer-offer-save t) ; ask before killing buffer
+      ;; make sure the contents is auto-saved
+      (auto-save-mode 1))
+    ))
 
 \f
 ;;; Commands for working with Ediff
-     
+
 (defun ediff-update-diffs ()
   "Recompute difference regions in buffers A, B, and C.
 Buffers are not synchronized with their respective files, so changes done
@@ -548,27 +622,19 @@ if necessary."
   (interactive)
   (ediff-barf-if-not-control-buffer)
   (if (and (ediff-buffer-live-p ediff-ancestor-buffer)
-          (not (y-or-n-p "Recompute differences during merge, really? ")))
-      (error "Recomputation of differences cancelled"))
-      
-  (let ((point-A (ediff-eval-in-buffer ediff-buffer-A (point)))
-       ;;(point-B (ediff-eval-in-buffer ediff-buffer-B (point)))
+          (not
+           (y-or-n-p
+            "Ancestor buffer will not be used.  Recompute diffs anyway? ")))
+      (error "Recomputation of differences canceled"))
+
+  (let ((point-A (ediff-with-current-buffer ediff-buffer-A (point)))
+       ;;(point-B (ediff-with-current-buffer ediff-buffer-B (point)))
        (tmp-buffer (get-buffer-create ediff-tmp-buffer))
-       (buf-A-file-name
-        (file-name-nondirectory (or (buffer-file-name ediff-buffer-A)
-                                    (buffer-name ediff-buffer-A)
-                                    )))
-       (buf-B-file-name
-        (file-name-nondirectory (or (buffer-file-name ediff-buffer-B)
-                                    (buffer-name ediff-buffer-B)
-                                    )))
-       (buf-C-file-name
-        (file-name-nondirectory (or (buffer-file-name ediff-buffer-C)
-                                    ;; if (null ediff-buffer-C), there is
-                                    ;; no danger, since we later check if
-                                    ;; ediff-buffer-C is alive
-                                    (buffer-name ediff-buffer-C)
-                                    )))
+       (buf-A-file-name (buffer-file-name ediff-buffer-A))
+       (buf-B-file-name (buffer-file-name ediff-buffer-B))
+       ;; (null ediff-buffer-C) is no problem, as we later check if
+       ;; ediff-buffer-C is alive
+       (buf-C-file-name (buffer-file-name ediff-buffer-C))
        (overl-A (ediff-get-value-according-to-buffer-type
                  'A ediff-narrow-bounds))
        (overl-B (ediff-get-value-according-to-buffer-type
@@ -577,15 +643,23 @@ if necessary."
                  'C ediff-narrow-bounds))
        beg-A end-A beg-B end-B beg-C end-C
        file-A file-B file-C)
+
+    (if (stringp buf-A-file-name)
+       (setq buf-A-file-name (file-name-nondirectory buf-A-file-name)))
+    (if (stringp buf-B-file-name)
+       (setq buf-B-file-name (file-name-nondirectory buf-B-file-name)))
+    (if (stringp buf-C-file-name)
+       (setq buf-C-file-name (file-name-nondirectory buf-C-file-name)))
+
     (ediff-unselect-and-select-difference -1)
-    
+
     (setq beg-A (ediff-overlay-start overl-A)
          beg-B (ediff-overlay-start overl-B)
          beg-C (ediff-overlay-start overl-C)
          end-A (ediff-overlay-end overl-A)
          end-B (ediff-overlay-end overl-B)
          end-C (ediff-overlay-end overl-C))
-         
+
     (if ediff-word-mode
        (progn
          (ediff-wordify beg-A end-A ediff-buffer-A tmp-buffer)
@@ -603,20 +677,20 @@ if necessary."
       (if ediff-3way-job
          (setq file-C (ediff-make-temp-file ediff-buffer-C buf-C-file-name)))
       )
-       
+
     (ediff-clear-diff-vector 'ediff-difference-vector-A 'fine-diffs-also)
     (ediff-clear-diff-vector 'ediff-difference-vector-B 'fine-diffs-also)
     (ediff-clear-diff-vector 'ediff-difference-vector-C 'fine-diffs-also)
     (ediff-clear-diff-vector
      'ediff-difference-vector-Ancestor 'fine-diffs-also)
-    ;; let them garbage collect. we can't use the ancestor after recomputing
+    ;; let them garbage collect.  we can't use the ancestor after recomputing
     ;; the diffs.
     (setq ediff-difference-vector-Ancestor nil
          ediff-ancestor-buffer nil
          ediff-state-of-merge nil)
 
     (setq ediff-killed-diffs-alist nil) ; invalidate saved killed diff regions
-    
+
     ;; In case of merge job, fool it into thinking that it is just doing
     ;; comparison
     (let ((ediff-setup-diff-regions-function ediff-setup-diff-regions-function)
@@ -631,23 +705,23 @@ if necessary."
                ediff-merge-with-ancestor-job nil
                ediff-job-name 'ediff-files3))
       (funcall ediff-setup-diff-regions-function file-A file-B file-C))
-           
+
     (setq ediff-number-of-differences (length ediff-difference-vector-A))
     (delete-file file-A)
     (delete-file file-B)
     (if file-C
        (delete-file file-C))
-       
+
     (if ediff-3way-job
        (ediff-set-state-of-all-diffs-in-all-buffers ediff-control-buffer))
-       
+
     (ediff-jump-to-difference (ediff-diff-at-point 'A point-A))
     (message "")
     ))
-    
-;; Not bound to any key---to dangerous. A user can do it if necessary.
+
+;; Not bound to any key---to dangerous.  A user can do it if necessary.
 (defun ediff-revert-buffers-then-recompute-diffs (noconfirm)
-  "Revert buffers A, B and C. Then rerun Ediff on file A and file B."
+  "Revert buffers A, B and C.  Then rerun Ediff on file A and file B."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
   (let ((bufA ediff-buffer-A)
@@ -659,13 +733,13 @@ if necessary."
        (ancestor-job ediff-merge-with-ancestor-job)
        (merge ediff-merge-job)
        (comparison ediff-3way-comparison-job))
-    (ediff-eval-in-buffer bufA
+    (ediff-with-current-buffer bufA
       (revert-buffer t noconfirm))
-    (ediff-eval-in-buffer bufB
+    (ediff-with-current-buffer bufB
       (revert-buffer t noconfirm))
     ;; this should only be executed in a 3way comparison, not in merge
     (if comparison
-       (ediff-eval-in-buffer bufC
+       (ediff-with-current-buffer bufC
          (revert-buffer t noconfirm)))
     (if merge
        (progn
@@ -681,16 +755,12 @@ if necessary."
       (ediff-update-diffs))))
 
 
-;; optional NO-REHIGHLIGHT says to not rehighlight buffers 
+;; optional NO-REHIGHLIGHT says to not rehighlight buffers
 (defun ediff-recenter (&optional no-rehighlight)
   "Bring the highlighted region of all buffers being compared into view.
 Reestablish the default three-window display."
   (interactive)
   (ediff-barf-if-not-control-buffer)
-  
-;;  ;; No longer needed: XEmacs has surrogate minibuffers now.
-;;  (if ediff-xemacs-p (setq synchronize-minibuffers t))
-  
   (let (buffer-read-only)
     (if (and (ediff-buffer-live-p ediff-buffer-A)
             (ediff-buffer-live-p ediff-buffer-B)
@@ -702,7 +772,7 @@ Reestablish the default three-window display."
          (message ediff-KILLED-VITAL-BUFFER
                   (beep 1)))
       ))
-  
+
   ;; set visibility range appropriate to this invocation of Ediff.
   (ediff-visible-region)
   ;; raise
@@ -736,7 +806,7 @@ Reestablish the default three-window display."
           (not ediff-use-long-help-message)
           (not (ediff-frame-iconified-p ediff-control-frame)))
       (raise-frame ediff-control-frame))
-  
+
   ;; Redisplay whatever buffers are showing, if there is a selected difference
   (let ((control-frame ediff-control-frame)
        (control-buf ediff-control-buffer))
@@ -747,15 +817,15 @@ Reestablish the default three-window display."
        (progn
          (or no-rehighlight
              (ediff-select-difference ediff-current-difference))
-         
+
          (ediff-recenter-one-window 'A)
          (ediff-recenter-one-window 'B)
          (if ediff-3way-job
              (ediff-recenter-one-window 'C))
-         
-         (ediff-eval-in-buffer control-buf
+
+         (ediff-with-current-buffer control-buf
            (ediff-recenter-ancestor) ; check if ancestor is alive
-           
+
            (if (and (ediff-multiframe-setup-p)
                     (not ediff-use-long-help-message)
                     (not (ediff-frame-iconified-p ediff-control-frame)))
@@ -765,10 +835,11 @@ Reestablish the default three-window display."
                 (eq this-command 'ediff-quit))))
          ))
 
-    (ediff-restore-highlighting)
-    (ediff-eval-in-buffer control-buf (ediff-refresh-mode-lines))
+    (or no-rehighlight
+       (ediff-restore-highlighting))
+    (ediff-with-current-buffer control-buf (ediff-refresh-mode-lines))
     ))
-  
+
 ;; this function returns to the window it was called from
 ;; (which was the control window)
 (defun ediff-recenter-one-window (buf-type)
@@ -776,14 +847,15 @@ Reestablish the default three-window display."
       ;; context must be saved before switching to windows A/B/C
       (let* ((ctl-wind (selected-window))
             (shift (ediff-overlay-start
-                    (ediff-get-value-according-to-buffer-type 
+                    (ediff-get-value-according-to-buffer-type
                      buf-type ediff-narrow-bounds)))
             (job-name ediff-job-name)
             (control-buf ediff-control-buffer)
-            (window-name (intern (format "ediff-window-%S" buf-type)))
+            (window-name (ediff-get-symbol-from-alist
+                          buf-type ediff-window-alist))
             (window (if (window-live-p (symbol-value window-name))
                         (symbol-value window-name))))
-       
+
        (if (and window ediff-windows-job)
            (set-window-start window shift))
        (if window
@@ -808,7 +880,7 @@ Reestablish the default three-window display."
            (ctl-wind (selected-window))
            (job-name ediff-job-name)
            (ctl-buf ediff-control-buffer))
-       (ediff-eval-in-buffer ediff-ancestor-buffer
+       (ediff-with-current-buffer ediff-ancestor-buffer
          (goto-char (ediff-get-diff-posn 'Ancestor 'beg nil ctl-buf))
          (if window
              (progn
@@ -821,10 +893,10 @@ Reestablish the default three-window display."
        (select-window ctl-wind)
        )))
 
-       
+
 ;; This will have to be refined for 3way jobs
 (defun ediff-toggle-split ()
-  "Toggle vertical/horizontal window split. 
+  "Toggle vertical/horizontal window split.
 Does nothing if file-A and file-B are in different frames."
   (interactive)
   (ediff-barf-if-not-control-buffer)
@@ -846,44 +918,48 @@ Does nothing if file-A and file-B are in different frames."
                'split-window-vertically))
       (message "Buffers being compared are in different frames"))
     (ediff-recenter 'no-rehighlight)))
-  
+
 (defun ediff-toggle-hilit ()
   "Switch between highlighting using ASCII flags and highlighting using faces.
-On a dumb terminal, switches between ASCII highlighting and no highlighting." 
+On a dumb terminal, switches between ASCII highlighting and no highlighting."
   (interactive)
   (ediff-barf-if-not-control-buffer)
-  (if (not (ediff-has-face-support-p))
-      (if (eq ediff-highlighting-style 'ascii)
-         (progn
-           (message "ASCII highlighting flags removed")
-           (ediff-unselect-and-select-difference ediff-current-difference
-                                                 'unselect-only)
-           (setq ediff-highlighting-style 'off))
-       (ediff-unselect-and-select-difference ediff-current-difference
-                                             'select-only))
-    (ediff-unselect-and-select-difference ediff-current-difference
-                                         'unselect-only)
-    ;; cycle through highlighting
-    (cond ((and ediff-use-faces ediff-highlight-all-diffs)
-          (message "Unhighlighting unselected difference regions")
-          (setq ediff-highlight-all-diffs nil))
-         (ediff-use-faces
-          (message "Highlighting with ASCII flags")
-          (setq ediff-use-faces nil))
-         (t
-          (message "Re-highlighting all difference regions")
-          (setq ediff-use-faces t
-                ediff-highlight-all-diffs t)))
-                
-    (if (and ediff-use-faces ediff-highlight-all-diffs)
-       (ediff-paint-background-regions)
-      (ediff-paint-background-regions 'unhighlight))
-    
-    (ediff-unselect-and-select-difference
-     ediff-current-difference 'select-only))
-  )
 
-  
+  (ediff-unselect-and-select-difference
+   ediff-current-difference 'unselect-only)
+  ;; cycle through highlighting
+  (cond ((and ediff-use-faces
+             (ediff-has-face-support-p)
+             ediff-highlight-all-diffs)
+        (message "Unhighlighting unselected difference regions")
+        (setq ediff-highlight-all-diffs  nil
+              ediff-highlighting-style  'face))
+       ((or (and ediff-use-faces  (ediff-has-face-support-p)
+                 (eq ediff-highlighting-style 'face))       ; has face support
+            (and (not (ediff-has-face-support-p))           ; no face support
+                 (eq ediff-highlighting-style 'off)))
+        (message "Highlighting with ASCII flags")
+        (setq ediff-highlighting-style  'ascii
+              ediff-highlight-all-diffs  nil
+              ediff-use-faces            nil))
+       ((eq ediff-highlighting-style 'ascii)
+        (message "ASCII highlighting flags removed")
+        (setq ediff-highlighting-style  'off
+              ediff-highlight-all-diffs  nil))
+       ((ediff-has-face-support-p)   ; catch-all for cases with face support
+        (message "Re-highlighting all difference regions")
+        (setq ediff-use-faces            t
+              ediff-highlighting-style  'face
+              ediff-highlight-all-diffs  t)))
+
+  (if (and ediff-use-faces ediff-highlight-all-diffs)
+      (ediff-paint-background-regions)
+    (ediff-paint-background-regions 'unhighlight))
+
+  (ediff-unselect-and-select-difference
+   ediff-current-difference 'select-only))
+
+
 (defun ediff-toggle-autorefine ()
   "Toggle auto-refine mode."
   (interactive)
@@ -915,10 +991,10 @@ On a dumb terminal, switches between ASCII highlighting and no highlighting."
     (cond ((setq wind (ediff-get-visible-buffer-window ediff-ancestor-buffer))
           (raise-frame (window-frame wind)))
          (t (set-window-buffer ediff-window-C ediff-ancestor-buffer)))))
-       
+
 (defun ediff-make-or-kill-fine-diffs (arg)
-  "Compute fine diffs. With negative prefix arg, kill fine diffs.
-In both cases, operates on the currrent difference region." 
+  "Compute fine diffs.  With negative prefix arg, kill fine diffs.
+In both cases, operates on the current difference region."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
   (cond ((eq arg '-)
@@ -926,8 +1002,8 @@ In both cases, operates on the currrent difference region."
        ((and (numberp arg) (< arg 0))
         (ediff-clear-fine-differences ediff-current-difference))
        (t (ediff-make-fine-diffs))))
-        
-  
+
+
 (defun ediff-toggle-help ()
   "Toggle short/long help message."
   (interactive)
@@ -941,11 +1017,11 @@ In both cases, operates on the currrent difference region."
   (if (and ediff-use-long-help-message (ediff-multiframe-setup-p))
       (setq ediff-prefer-iconified-control-frame
            (ediff-frame-iconified-p ediff-control-frame)))
-           
+
   (setq ediff-window-config-saved "") ; force redisplay
   (ediff-recenter 'no-rehighlight))
-  
-  
+
+
 ;; If BUF, this is the buffer to toggle, not current buffer.
 (defun ediff-toggle-read-only (&optional buf)
   "Toggle read-only in current buffer.
@@ -959,8 +1035,8 @@ of the current buffer."
     (or buf (ediff-recenter))
     (or buf
        (setq buf (ediff-get-buffer buf-type)))
-             
-    (ediff-eval-in-buffer buf     ; eval in buf A/B/C
+
+    (ediff-with-current-buffer buf     ; eval in buf A/B/C
       (let* ((file (buffer-file-name buf))
             (file-writable (and file
                                 (file-exists-p file)
@@ -971,8 +1047,8 @@ of the current buffer."
                                  (file-writable 'toggle-read-only)
                                  (t (key-binding "\C-x\C-q")))))
        ;; If the file is checked in, make sure we don't make buffer modifiable
-       ;; without warning the user. The user can fool our checks by making the
-       ;; buffer non-RO without checking the file out. We regard this as a
+       ;; without warning the user.  The user can fool our checks by making the
+       ;; buffer non-RO without checking the file out.  We regard this as a
        ;; user problem.
        (if (and (ediff-file-checked-in-p file)
                 ;; If ctl-buf is null, this means we called this
@@ -983,14 +1059,14 @@ of the current buffer."
                  ((and (or (beep 1) t) ; always beep
                        (y-or-n-p
                         (format
-                         "File %s is under version control. Check it out? "
+                         "File %s is under version control.  Check it out? "
                          (ediff-abbreviate-file-name file))))
                   ;; if we checked the file out, we should also change the
                   ;; original state of buffer-read-only to nil.  If we don't
                   ;; do this, the mode line will show %%, since the file was
                   ;; RO before ediff started, so the user will think the file
                   ;; is checked in.
-                  (ediff-eval-in-buffer ctl-buf
+                  (ediff-with-current-buffer ctl-buf
                     (ediff-change-saved-variable
                      'buffer-read-only nil buf-type)))
                  (t
@@ -999,69 +1075,95 @@ of the current buffer."
                   (message
                    "Boy, this is risky! Don't modify this file...")
                   (sit-for 3)))) ; let the user see the warning
-       (if (and toggle-ro-cmd 
+       (if (and toggle-ro-cmd
                 (string-match "toggle-read-only" (symbol-name toggle-ro-cmd)))
            (save-excursion
              (save-window-excursion
                (select-window (ediff-get-visible-buffer-window buf))
                (command-execute toggle-ro-cmd)))
          (error "Don't know how to toggle read-only in buffer %S" buf))
-       
+
        ;; Check if we made the current buffer updatable, but its file is RO.
        ;; Signal a warning in this case.
        (if (and file (not buffer-read-only)
                 (eq this-command 'ediff-toggle-read-only)
                 (file-exists-p file)
                 (not (file-writable-p file)))
-           (message "Warning: file %s is read-only"
-                    (ediff-abbreviate-file-name file) (beep 1)))
+           (progn
+             (beep 1)
+             (message "Warning: file %s is read-only"
+                      (ediff-abbreviate-file-name file))))
        ))))
 
 ;; checkout if visited file is checked in
 (defun ediff-maybe-checkout (buf)
-  (let ((file (buffer-file-name buf))
+  (let ((file (expand-file-name (buffer-file-name buf)))
        (checkout-function (key-binding "\C-x\C-q")))
     (if (and (ediff-file-checked-in-p file)
             (or (beep 1) t)
             (y-or-n-p
              (format
-              "File %s is under version control. Check it out? "
+              "File %s is under version control.  Check it out? "
               (ediff-abbreviate-file-name file))))
-       (ediff-eval-in-buffer buf
+       (ediff-with-current-buffer buf
          (command-execute checkout-function)))))
-          
+
 
 ;; This is a simple-minded check for whether a file is under version control.
 ;; If file,v exists but file doesn't, this file is considered to be not checked
 ;; in and not checked out for the purpose of patching (since patch won't be
 ;; able to read such a file anyway).
 ;; FILE is a string representing file name
-(defun ediff-file-under-version-control (file)
-  (let* ((filedir (file-name-directory file))
-        (file-nondir (file-name-nondirectory file))
-        (trial (concat file-nondir ",v"))
-        (full-trial (concat filedir trial))
-        (full-rcs-trial (concat filedir "RCS/" trial)))
-    (and (stringp file)
-        (file-exists-p file)
-        (or
-         (and
-          (file-exists-p full-trial)
-          ;; in FAT FS, `file,v' and `file' may turn out to be the same!
-          ;; don't be fooled by this!
-          (not (equal (file-attributes file)
-                      (file-attributes full-trial))))
-         ;; check if a version is in RCS/ directory
-         (file-exists-p full-rcs-trial)))
-       ))
+;;(defun ediff-file-under-version-control (file)
+;;  (let* ((filedir (file-name-directory file))
+;;      (file-nondir (file-name-nondirectory file))
+;;      (trial (concat file-nondir ",v"))
+;;      (full-trial (concat filedir trial))
+;;      (full-rcs-trial (concat filedir "RCS/" trial)))
+;;    (and (stringp file)
+;;      (file-exists-p file)
+;;      (or
+;;       (and
+;;        (file-exists-p full-trial)
+;;        ;; in FAT FS, `file,v' and `file' may turn out to be the same!
+;;        ;; don't be fooled by this!
+;;        (not (equal (file-attributes file)
+;;                    (file-attributes full-trial))))
+;;       ;; check if a version is in RCS/ directory
+;;       (file-exists-p full-rcs-trial)))
+;;       ))
+
 
 (defun ediff-file-checked-out-p (file)
-  (and (ediff-file-under-version-control file)
-       (file-writable-p file)))
+  (or (not (featurep 'vc-hooks))
+      (and (vc-backend file)
+          (if (fboundp 'vc-state)
+              (or (memq (vc-state file) '(edited needs-merge))
+                  (stringp (vc-state file)))
+            ;; XEmacs has no vc-state
+            (vc-locking-user file))
+          )))
+
 (defun ediff-file-checked-in-p (file)
-  (and (ediff-file-under-version-control file)
-       (not (file-writable-p file))))
-      
+  (and (featurep 'vc-hooks)
+       ;; CVS files are considered not checked in
+       (not (memq (vc-backend file) '(nil CVS)))
+       (if (fboundp 'vc-state)
+          (and
+           (not (memq (vc-state file) '(edited needs-merge)))
+           (not (stringp (vc-state file))))
+        ;; XEmacs has no vc-state
+        (not (vc-locking-user file)))
+       ))
+
+(defun ediff-file-compressed-p (file)
+  (condition-case nil
+      (require 'jka-compr)
+    (error))
+  (if (featurep 'jka-compr)
+      (string-match (jka-compr-build-file-regexp) file)))
+
+
 (defun ediff-swap-buffers ()
   "Rotate the display of buffers A, B, and C."
   (interactive)
@@ -1090,7 +1192,7 @@ of the current buffer."
                  ediff-buffer-B buf)
          (setq ediff-buffer-A ediff-buffer-B
                ediff-buffer-B buf))
-               
+
        ;; swap saved buffer characteristics
        (if ediff-3way-comparison-job
            (setq ediff-buffer-values-orig-A ediff-buffer-values-orig-C
@@ -1098,7 +1200,7 @@ of the current buffer."
                  ediff-buffer-values-orig-B values)
          (setq ediff-buffer-values-orig-A ediff-buffer-values-orig-B
                ediff-buffer-values-orig-B values))
-       
+
        ;; swap diff vectors
        (if ediff-3way-comparison-job
            (setq ediff-difference-vector-A ediff-difference-vector-C
@@ -1106,7 +1208,7 @@ of the current buffer."
                  ediff-difference-vector-B diff-vec)
          (setq ediff-difference-vector-A ediff-difference-vector-B
                ediff-difference-vector-B diff-vec))
-               
+
        ;; swap hide/focus regexp
        (if ediff-3way-comparison-job
            (setq ediff-regexp-hide-A ediff-regexp-hide-C
@@ -1119,9 +1221,9 @@ of the current buffer."
                ediff-regexp-hide-B hide-regexp
                ediff-regexp-focus-A ediff-regexp-focus-B
                ediff-regexp-focus-B focus-regexp))
-       
+
        ;; The following is needed for XEmacs, since there one can't move
-       ;; overlay to another buffer. In Emacs, this swap is redundant.
+       ;; overlay to another buffer.  In Emacs, this swap is redundant.
        (if (ediff-has-face-support-p)
            (if ediff-3way-comparison-job
                (setq ediff-current-diff-overlay-A ediff-current-diff-overlay-C
@@ -1129,7 +1231,7 @@ of the current buffer."
                      ediff-current-diff-overlay-B overlay)
              (setq ediff-current-diff-overlay-A ediff-current-diff-overlay-B
                    ediff-current-diff-overlay-B overlay)))
-                   
+
        ;; swap wide bounds
        (setq ediff-wide-bounds
              (cond (ediff-3way-comparison-job
@@ -1140,7 +1242,7 @@ of the current buffer."
                     (list (nth 1 ediff-wide-bounds)
                           (nth 0 ediff-wide-bounds)
                           (nth 2 ediff-wide-bounds)))
-                   (t 
+                   (t
                     (list (nth 1 ediff-wide-bounds)
                           (nth 0 ediff-wide-bounds)))))
        ;; swap narrow bounds
@@ -1153,7 +1255,7 @@ of the current buffer."
                     (list (nth 1 ediff-narrow-bounds)
                           (nth 0 ediff-narrow-bounds)
                           (nth 2 ediff-narrow-bounds)))
-                   (t 
+                   (t
                     (list (nth 1 ediff-narrow-bounds)
                           (nth 0 ediff-narrow-bounds)))))
        (if wide-visibility-p
@@ -1164,7 +1266,7 @@ of the current buffer."
       (ediff-set-state-of-all-diffs-in-all-buffers ediff-control-buffer))
   (ediff-recenter 'no-rehighlight)
   )
-  
+
 
 (defun ediff-toggle-wide-display ()
   "Toggle wide/regular display.
@@ -1178,7 +1280,7 @@ This is especially useful when comparing buffers side-by-side."
   (let ((ctl-buf ediff-control-buffer))
     (setq ediff-wide-display-p (not ediff-wide-display-p))
     (if (not ediff-wide-display-p)
-       (ediff-eval-in-buffer ctl-buf
+       (ediff-with-current-buffer ctl-buf
          (modify-frame-parameters
           ediff-wide-display-frame ediff-wide-display-orig-parameters)
          ;;(sit-for (if ediff-xemacs-p 0.4 0))
@@ -1190,10 +1292,10 @@ This is especially useful when comparing buffers side-by-side."
          (ediff-recenter 'no-rehighlight))
       (funcall ediff-make-wide-display-function)
       ;;(sit-for (if ediff-xemacs-p 0.4 0))
-      (ediff-eval-in-buffer ctl-buf
+      (ediff-with-current-buffer ctl-buf
        (setq ediff-window-B nil) ; force update of window config
        (ediff-recenter 'no-rehighlight)))))
-       
+
 ;;;###autoload
 (defun ediff-toggle-multiframe ()
   "Switch from multiframe display to single-frame display and back.
@@ -1215,10 +1317,9 @@ which see."
   ;; change default
   (setq-default ediff-window-setup-function window-setup-func)
   ;; change in all active ediff sessions
-  (mapcar (function (lambda(buf)
-                     (ediff-eval-in-buffer buf
-                       (setq ediff-window-setup-function window-setup-func
-                             ediff-window-B nil))))
+  (mapcar (lambda(buf) (ediff-with-current-buffer buf
+                        (setq ediff-window-setup-function window-setup-func
+                              ediff-window-B nil)))
          ediff-session-registry)
   (if (ediff-in-control-buffer-p)
       (ediff-recenter 'no-rehighlight))))
@@ -1239,12 +1340,12 @@ To change the default, set the variable `ediff-use-toolbar-p', which see."
            (ediff-kill-bottom-toolbar))
        ;; do this only after killing the toolbar
        (setq ediff-use-toolbar-p (not ediff-use-toolbar-p))
-       
-       (mapcar (function (lambda(buf)
-                           (ediff-eval-in-buffer buf
-                             ;; force redisplay
-                             (setq ediff-window-config-saved "")
-                             )))
+
+       (mapcar (lambda(buf)
+                 (ediff-with-current-buffer buf
+                   ;; force redisplay
+                   (setq ediff-window-config-saved "")
+                   ))
                ediff-session-registry)
        (if (ediff-in-control-buffer-p)
            (ediff-recenter 'no-rehighlight)))))
@@ -1257,11 +1358,15 @@ To change the default, set the variable `ediff-use-toolbar-p', which see."
   ;;(selected-frame).
   ;; The problem with this is that any previous bottom-toolbar
   ;; will not re-appear after our cleanup here.  Is there a way
-  ;; to do "push" and "pop" toolbars ?  --marcpa  
+  ;; to do "push" and "pop" toolbars ?  --marcpa
   (if (ediff-use-toolbar-p)
-      (progn
-       (set-specifier bottom-toolbar (list (selected-frame) nil))
-       (set-specifier bottom-toolbar-visible-p (list (selected-frame) nil)))))
+      (ediff-cond-compile-for-xemacs-or-emacs
+       (progn ; xemacs
+        (set-specifier bottom-toolbar (list (selected-frame) nil))
+        (set-specifier bottom-toolbar-visible-p (list (selected-frame) nil)))
+       nil  ; emacs
+       )
+    ))
 
 ;; If wants to use toolbar, make it.
 ;; If not, zero the toolbar for XEmacs.
@@ -1271,22 +1376,31 @@ To change the default, set the variable `ediff-use-toolbar-p', which see."
       (progn
        (setq frame (or frame (selected-frame)))
        (cond ((ediff-use-toolbar-p) ; this checks for XEmacs
-              (set-specifier
-               bottom-toolbar
-               (list frame (if (ediff-3way-comparison-job)
-                               ediff-toolbar-3way ediff-toolbar)))
-              (set-specifier bottom-toolbar-visible-p (list frame t)) 
-              (set-specifier bottom-toolbar-height
-                             (list frame ediff-toolbar-height)))
-             (ediff-xemacs-p
-              (set-specifier bottom-toolbar-height (list frame 0)))
+              (ediff-cond-compile-for-xemacs-or-emacs
+               (progn ; xemacs
+                 (set-specifier
+                  bottom-toolbar
+                  (list frame (if (ediff-3way-comparison-job)
+                                  ediff-toolbar-3way ediff-toolbar)))
+                 (set-specifier bottom-toolbar-visible-p (list frame t))
+                 (set-specifier bottom-toolbar-height
+                                (list frame ediff-toolbar-height)))
+               nil ; emacs
+               )
+              )
+             ((ediff-has-toolbar-support-p)
+              (ediff-cond-compile-for-xemacs-or-emacs
+               (set-specifier bottom-toolbar-height (list frame 0)) ; xemacs
+               nil                                                  ; emacs
+               )
+              )
              ))
     ))
-              
+
 ;; Merging
 
 (defun ediff-toggle-show-clashes-only ()
-  "Toggle the mode where only the regions where both buffers differ with the ancestor are shown."
+  "Toggle the mode that shows only the merge regions where both variants differ from the ancestor."
   (interactive)
   (ediff-barf-if-not-control-buffer)
   (if (not ediff-merge-with-ancestor-job)
@@ -1295,7 +1409,19 @@ To change the default, set the variable `ediff-use-toolbar-p', which see."
   (if ediff-show-clashes-only
       (message "Focus on regions where both buffers differ from the ancestor")
     (message "Canceling focus on regions where changes clash")))
-              
+
+(defun ediff-toggle-skip-changed-regions ()
+  "Toggle the mode that skips the merge regions that differ from the default."
+  (interactive)
+  (ediff-barf-if-not-control-buffer)
+  (setq ediff-skip-merge-regions-that-differ-from-default
+       (not ediff-skip-merge-regions-that-differ-from-default))
+  (if ediff-skip-merge-regions-that-differ-from-default
+      (message "Skipping regions that differ from default setting")
+    (message "Showing regions that differ from default setting")))
+
+
+
 ;; Widening/narrowing
 
 (defun ediff-toggle-narrow-region ()
@@ -1308,11 +1434,11 @@ Used in ediff-windows/regions only."
       (setq ediff-visible-bounds ediff-narrow-bounds)
     (setq ediff-visible-bounds ediff-wide-bounds))
   (ediff-recenter 'no-rehighlight))
-  
-;; Narrow bufs A/B/C to ediff-visible-bounds. If this is currently set to
+
+;; Narrow bufs A/B/C to ediff-visible-bounds.  If this is currently set to
 ;; ediff-wide-bounds, then this actually widens.
 ;; This function does nothing if job-name is not
-;; ediff-regions-wordwise/linewise or ediff-windows-wordwise/linewise. 
+;; ediff-regions-wordwise/linewise or ediff-windows-wordwise/linewise.
 ;; Does nothing if buffer-A  = buffer-B since we can't narrow
 ;; to two different regions in one buffer.
 (defun ediff-visible-region ()
@@ -1331,19 +1457,21 @@ Used in ediff-windows/regions only."
          (overl-C (ediff-get-value-according-to-buffer-type
                    'C  ediff-visible-bounds))
          )
-      (ediff-eval-in-buffer ediff-buffer-A
-       (narrow-to-region
-        (ediff-overlay-start overl-A) (ediff-overlay-end overl-A)))
-      (ediff-eval-in-buffer ediff-buffer-B
-       (narrow-to-region
-        (ediff-overlay-start overl-B) (ediff-overlay-end overl-B)))
-      
-      (if ediff-3way-job
-         (ediff-eval-in-buffer ediff-buffer-C
+      (ediff-with-current-buffer ediff-buffer-A
+       (if (ediff-overlay-buffer overl-A)
+           (narrow-to-region
+            (ediff-overlay-start overl-A) (ediff-overlay-end overl-A))))
+      (ediff-with-current-buffer ediff-buffer-B
+       (if (ediff-overlay-buffer overl-B)
+           (narrow-to-region
+            (ediff-overlay-start overl-B) (ediff-overlay-end overl-B))))
+
+      (if (and ediff-3way-job (ediff-overlay-buffer overl-C))
+         (ediff-with-current-buffer ediff-buffer-C
            (narrow-to-region
             (ediff-overlay-start overl-C) (ediff-overlay-end overl-C))))
       )))
-  
+
 
 ;; Window scrolling operations
 
@@ -1352,7 +1480,7 @@ Used in ediff-windows/regions only."
 ;; Usually, errors come from scrolling off the
 ;; beginning or end of the buffer, and this gives error messages.
 (defun ediff-operate-on-windows (operation arg)
-        
+
   ;; make sure windows aren't dead
   (if (not (and (window-live-p ediff-window-A) (window-live-p ediff-window-B)))
       (ediff-recenter 'no-rehighlight))
@@ -1361,7 +1489,7 @@ Used in ediff-windows/regions only."
                (or (not ediff-3way-job) ediff-buffer-C)
                ))
       (error ediff-KILLED-VITAL-BUFFER))
-       
+
   (let* ((wind (selected-window))
         (wind-A ediff-window-A)
         (wind-B ediff-window-B)
@@ -1371,7 +1499,7 @@ Used in ediff-windows/regions only."
         (three-way ediff-3way-job)
         (coefC (if three-way
                    (ediff-get-region-size-coefficient 'C operation))))
-            
+
     (select-window wind-A)
     (condition-case nil
        (funcall operation (round (* coefA arg)))
@@ -1394,7 +1522,7 @@ With optional argument ARG, scroll ARG lines; otherwise scroll by nearly
 the one half of the height of window-A."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
-  
+
   ;; make sure windows aren't dead
   (if (not (and (window-live-p ediff-window-A) (window-live-p ediff-window-B)))
       (ediff-recenter 'no-rehighlight))
@@ -1404,10 +1532,10 @@ the one half of the height of window-A."
                    (ediff-buffer-live-p ediff-buffer-C))
                ))
       (error ediff-KILLED-VITAL-BUFFER))
-      
+
   (ediff-operate-on-windows
    (if (memq last-command-char '(?v ?\C-v))
-       'scroll-up 
+       'scroll-up
      'scroll-down)
    ;; calculate argument to scroll-up/down
    ;; if there is an explicit argument
@@ -1416,7 +1544,7 @@ the one half of the height of window-A."
        (prefix-numeric-value arg)
      ;; if not, see if we can determine a default amount (the window height)
      (let (default-amount)
-       (setq default-amount 
+       (setq default-amount
             (- (/ (min (window-height ediff-window-A)
                        (window-height ediff-window-B)
                        (if ediff-3way-job
@@ -1438,7 +1566,7 @@ If an argument is given, that is how many columns are scrolled, else nearly
 the width of the A/B/C windows."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
-  
+
   ;; make sure windows aren't dead
   (if (not (and (window-live-p ediff-window-A) (window-live-p ediff-window-B)))
       (ediff-recenter 'no-rehighlight))
@@ -1448,11 +1576,19 @@ the width of the A/B/C windows."
                    (ediff-buffer-live-p ediff-buffer-C))
                ))
       (error ediff-KILLED-VITAL-BUFFER))
-    
+
   (ediff-operate-on-windows
+   ;; Arrange for scroll-left and scroll-right being called
+   ;; interactively so that they set the window's min_hscroll.
+   ;; Otherwise, automatic hscrolling will undo the effect of
+   ;; hscrolling.
    (if (= last-command-char ?<)
-       'scroll-left
-     'scroll-right)
+       (lambda (arg)
+        (let ((prefix-arg arg))
+          (call-interactively 'scroll-left)))
+     (lambda (arg)
+       (let ((prefix-arg arg))
+        (call-interactively 'scroll-right))))
    ;; calculate argument to scroll-left/right
    ;; if there is an explicit argument
    (if (and arg (not (equal arg '-)))
@@ -1481,8 +1617,8 @@ the width of the A/B/C windows."
 
 
 ;;BEG, END show the region to be positioned.
-;;JOB-NAME holds ediff-job-name. The ediff-windows job positions regions
-;;differently. 
+;;JOB-NAME holds ediff-job-name.  The ediff-windows job positions regions
+;;differently.
 (defun ediff-position-region (beg end pos job-name)
   (if (> end (point-max))
       (setq end (point-max)))
@@ -1522,30 +1658,33 @@ the width of the A/B/C windows."
 (defun ediff-get-lines-to-region-end (buf-type &optional n ctl-buf)
   (or n (setq n ediff-current-difference))
   (or ctl-buf (setq ctl-buf ediff-control-buffer))
-  (ediff-eval-in-buffer ctl-buf
+  (ediff-with-current-buffer ctl-buf
     (let* ((buf (ediff-get-buffer buf-type))
-          (wind (eval (intern (format "ediff-window-%S" buf-type))))
+          (wind (eval (ediff-get-symbol-from-alist
+                       buf-type ediff-window-alist)))
           (beg (window-start wind))
           (end (ediff-get-diff-posn buf-type 'end))
           lines)
-      (ediff-eval-in-buffer buf
+      (ediff-with-current-buffer buf
        (if (< beg end)
            (setq lines (count-lines beg end))
          (setq lines 0))
        lines
        ))))
 
-;; get number of lines from window end to region start
-(defun ediff-get-lines-to-region-start (buf-type &optional n ctl-buf)
-  (or n (setq n ediff-current-difference))
+;; Calculate the number of lines from window end to the start of diff region
+(defun ediff-get-lines-to-region-start (buf-type &optional diff-num ctl-buf)
+  (or diff-num (setq diff-num ediff-current-difference))
   (or ctl-buf (setq ctl-buf ediff-control-buffer))
-  (ediff-eval-in-buffer ctl-buf
+  (ediff-with-current-buffer ctl-buf
     (let* ((buf (ediff-get-buffer buf-type))
-          (wind (eval (intern (format "ediff-window-%S" buf-type))))
-          (end (window-end wind))
-          (beg (ediff-get-diff-posn buf-type 'beg)))
-      (ediff-eval-in-buffer buf
-       (if (< beg end) (count-lines beg end) 0))
+          (wind (eval (ediff-get-symbol-from-alist
+                       buf-type ediff-window-alist)))
+          (end (or (window-end wind) (window-end wind t)))
+          (beg (ediff-get-diff-posn buf-type 'beg diff-num)))
+      (ediff-with-current-buffer buf
+       (if (< beg end)
+           (count-lines (max beg (point-min)) (min end (point-max))) 0))
       )))
 
 
@@ -1557,7 +1696,7 @@ the width of the A/B/C windows."
 ;;
 ;; If the difference region is invalid, the coefficient is 1
 (defun ediff-get-region-size-coefficient (buf-type op &optional n ctl-buf)
-  (ediff-eval-in-buffer (or ctl-buf ediff-control-buffer)
+  (ediff-with-current-buffer (or ctl-buf ediff-control-buffer)
     (if (ediff-valid-difference-p n)
        (let* ((func (cond ((eq op 'scroll-down)
                            'ediff-get-lines-to-region-start)
@@ -1579,35 +1718,48 @@ the width of the A/B/C windows."
 
 
 (defun ediff-next-difference (&optional arg)
-  "Advance to the next difference. 
+  "Advance to the next difference.
 With a prefix argument, go forward that many differences."
   (interactive "p")
   (ediff-barf-if-not-control-buffer)
   (if (< ediff-current-difference ediff-number-of-differences)
       (let ((n (min ediff-number-of-differences
-                   (+ ediff-current-difference arg)))
-           regexp-skip)
-           
+                   (+ ediff-current-difference (or arg 1))))
+           non-clash-skip skip-changed regexp-skip)
+
        (ediff-visible-region)
        (or (>= n ediff-number-of-differences)
            (setq regexp-skip (funcall ediff-skip-diff-region-function n))
+           ;; this won't exec if regexp-skip is t
+           (setq non-clash-skip (ediff-merge-region-is-non-clash-to-skip n)
+                 skip-changed
+                 (ediff-skip-merge-region-if-changed-from-default-p n))
            (ediff-install-fine-diff-if-necessary n))
+       ;; Skip loop
        (while (and (< n ediff-number-of-differences)
                    (or
                     ;; regexp skip
                     regexp-skip
                     ;; skip clashes, if necessary
-                    (and ediff-show-clashes-only
-                         (string-match "prefer"
-                                       (or (ediff-get-state-of-merge n) "")))
+                    non-clash-skip
+                    ;; skip processed regions
+                    skip-changed
                     ;; skip difference regions that differ in white space
                     (and ediff-ignore-similar-regions
-                         (eq (ediff-no-fine-diffs-p n) t))))
+                         (ediff-merge-region-is-non-clash n)
+                         (or (eq (ediff-no-fine-diffs-p n) t)
+                             (and (ediff-merge-job)
+                                  (eq (ediff-no-fine-diffs-p n) 'C)))
+                         )))
          (setq n (1+ n))
          (if (= 0 (mod n 20))
              (message "Skipped over region %d and counting ..."  n))
          (or (>= n ediff-number-of-differences)
              (setq regexp-skip (funcall ediff-skip-diff-region-function n))
+             ;; this won't exec if regexp-skip is t
+             (setq non-clash-skip (ediff-merge-region-is-non-clash-to-skip n)
+                   skip-changed
+                   (ediff-skip-merge-region-if-changed-from-default-p n))
              (ediff-install-fine-diff-if-necessary n))
          )
        (message "")
@@ -1617,34 +1769,46 @@ With a prefix argument, go forward that many differences."
     (error "At end of the difference list")))
 
 (defun ediff-previous-difference (&optional arg)
-  "Go to the previous difference. 
+  "Go to the previous difference.
 With a prefix argument, go back that many differences."
   (interactive "p")
   (ediff-barf-if-not-control-buffer)
   (if (> ediff-current-difference -1)
-      (let ((n (max -1 (- ediff-current-difference arg)))
-           regexp-skip)
-           
+      (let ((n (max -1 (- ediff-current-difference (or arg 1))))
+           non-clash-skip skip-changed regexp-skip)
+
        (ediff-visible-region)
        (or (< n 0)
            (setq regexp-skip (funcall ediff-skip-diff-region-function n))
+           ;; this won't exec if regexp-skip is t
+           (setq non-clash-skip (ediff-merge-region-is-non-clash-to-skip n)
+                 skip-changed
+                 (ediff-skip-merge-region-if-changed-from-default-p n))
            (ediff-install-fine-diff-if-necessary n))
        (while (and (> n -1)
                    (or
                     ;; regexp skip
                     regexp-skip
                     ;; skip clashes, if necessary
-                    (and ediff-show-clashes-only
-                         (string-match "prefer"
-                                       (or (ediff-get-state-of-merge n) "")))
+                    non-clash-skip
+                    ;; skipp changed regions
+                    skip-changed
                     ;; skip difference regions that differ in white space
                     (and ediff-ignore-similar-regions
-                         (eq (ediff-no-fine-diffs-p n) t))))
+                         (ediff-merge-region-is-non-clash n)
+                         (or (eq (ediff-no-fine-diffs-p n) t)
+                             (and (ediff-merge-job)
+                                  (eq (ediff-no-fine-diffs-p n) 'C)))
+                         )))
          (if (= 0 (mod (1+ n) 20))
              (message "Skipped over region %d and counting ..."  (1+ n)))
          (setq n (1- n))
          (or (< n 0)
              (setq regexp-skip (funcall ediff-skip-diff-region-function n))
+             ;; this won't exec if regexp-skip is t
+             (setq non-clash-skip (ediff-merge-region-is-non-clash-to-skip n)
+                   skip-changed
+                   (ediff-skip-merge-region-if-changed-from-default-p n))
              (ediff-install-fine-diff-if-necessary n))
          )
        (message "")
@@ -1672,23 +1836,23 @@ If the prefix is negative, count differences from the end."
       (ediff-unselect-and-select-difference difference-number)
     (error ediff-BAD-DIFF-NUMBER
           this-command (1+ difference-number) ediff-number-of-differences)))
-      
+
 (defun ediff-jump-to-difference-at-point (arg)
   "Go to difference closest to the point in buffer A, B, or C.
 The buffer depends on last command character \(a, b, or c\) that invoked this
-command. For instance, if the command was `ga' then the point value in buffer A
-is used.
+command.  For instance, if the command was `ga' then the point value in buffer
+is used.
 With a prefix argument, synchronize all files around the current point position
 in the specified buffer."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
   (let* ((buf-type (ediff-char-to-buftype last-command-char))
         (buffer (ediff-get-buffer buf-type))
-        (pt (ediff-eval-in-buffer buffer (point)))
+        (pt (ediff-with-current-buffer buffer (point)))
         (diff-no (ediff-diff-at-point buf-type nil (if arg 'after)))
         (past-last-diff (< ediff-number-of-differences diff-no))
         (beg (if past-last-diff
-                 (ediff-eval-in-buffer buffer (point-max))
+                 (ediff-with-current-buffer buffer (point-max))
                (ediff-get-diff-posn buf-type 'beg (1- diff-no))))
         ctl-wind wind-A wind-B wind-C
         shift)
@@ -1701,7 +1865,7 @@ in the specified buffer."
          wind-C ediff-window-C)
     (if arg
        (progn
-         (ediff-eval-in-buffer buffer
+         (ediff-with-current-buffer buffer
            (setq shift (- beg pt)))
          (select-window wind-A)
          (if past-last-diff (goto-char (point-max)))
@@ -1727,14 +1891,14 @@ in the specified buffer."
          (select-window ctl-wind)
          ))
     ))
-       
-      
+
+
 ;; find region most related to the current point position (or POS, if given)
 ;; returns diff number as seen by the user (i.e., 1+ the internal
-;; representation) 
-;; The optional argument WHICH-DIFF can be `after' or `before'. If `after',
-;; find the diff after the point. If `before', find the diff before the
-;; point. If the point is inside a diff, return that diff.
+;; representation)
+;; The optional argument WHICH-DIFF can be `after' or `before'.  If `after',
+;; find the diff after the point.  If `before', find the diff before the
+;; point.  If the point is inside a diff, return that diff.
 (defun ediff-diff-at-point (buf-type &optional pos which-diff)
   (let ((buffer (ediff-get-buffer buf-type))
        (ctl-buffer ediff-control-buffer)
@@ -1744,8 +1908,8 @@ in the specified buffer."
        (prev-end 0)
        (beg 0)
        (end 0))
-       
-    (ediff-eval-in-buffer buffer
+
+    (ediff-with-current-buffer buffer
       (setq pos (or pos (point)))
       (while (and (or (< pos prev-beg) (> pos beg))
                  (< diff-no max-dif-num))
@@ -1755,7 +1919,7 @@ in the specified buffer."
        (setq beg (ediff-get-diff-posn buf-type 'beg diff-no ctl-buffer)
              end (ediff-get-diff-posn buf-type 'end diff-no ctl-buffer))
        )
-      
+
       ;; boost diff-no by 1, if past the last diff region
       (if (and (memq which-diff '(after before))
               (> pos beg) (= diff-no max-dif-num))
@@ -1779,7 +1943,7 @@ If numerical prefix argument, copy the difference specified in the arg.
 Otherwise, copy the difference given by `ediff-current-difference'.
 This command assumes it is bound to a 2-character key sequence, `ab', `ba',
 `ac', etc., which is used to determine the types of buffers to be used for
-copying difference regions. The first character in the sequence specifies
+copying difference regions.  The first character in the sequence specifies
 the source buffer and the second specifies the target.
 
 If the second optional argument, a 2-character string, is given, use it to
@@ -1792,8 +1956,8 @@ determine the source and the target buffers instead of the command keys."
 
   (let* ((key1 (aref keys 0))
         (key2 (aref keys 1))
-        (char1 (if (and ediff-xemacs-p (eventp key1)) (event-key key1) key1))
-        (char2 (if (and ediff-xemacs-p (eventp key1)) (event-key key2) key2))
+        (char1 (ediff-event-key key1))
+        (char2 (ediff-event-key key2))
         ediff-verbose-p)
     (ediff-copy-diff ediff-current-difference
                     (ediff-char-to-buftype char1)
@@ -1803,37 +1967,37 @@ determine the source and the target buffers instead of the command keys."
 
 (defun ediff-copy-A-to-B (arg)
   "Copy ARGth difference region from buffer A to B.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "ab"))
 
 (defun ediff-copy-B-to-A (arg)
   "Copy ARGth difference region from buffer B to A.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "ba"))
 
 (defun ediff-copy-A-to-C (arg)
   "Copy ARGth difference region from buffer A to buffer C.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "ac"))
 
 (defun ediff-copy-B-to-C (arg)
   "Copy ARGth difference region from buffer B to buffer C.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "bc"))
 
 (defun ediff-copy-C-to-B (arg)
   "Copy ARGth difference region from buffer C to B.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "cb"))
 
 (defun ediff-copy-C-to-A (arg)
   "Copy ARGth difference region from buffer C to A.
-ARG is a prefix argument. If nil, copy the current difference region."
+ARG is a prefix argument.  If nil, copy the current difference region."
   (interactive "P")
   (ediff-diff-to-diff arg "ca"))
 
@@ -1841,7 +2005,7 @@ ARG is a prefix argument. If nil, copy the current difference region."
 
 ;; Copy diff N from FROM-BUF-TYPE \(given as A, B or C\) to TO-BUF-TYPE.
 ;; If optional DO-NOT-SAVE is non-nil, do not save the old value of the
-;; target diff. This is used in merging, when constructing the merged
+;; target diff.  This is used in merging, when constructing the merged
 ;; version.
 (defun ediff-copy-diff (n from-buf-type to-buf-type
                          &optional batch-invocation reg-to-copy)
@@ -1853,38 +2017,38 @@ ARG is a prefix argument. If nil, copy the current difference region."
         messg
         ediff-verbose-p
         reg-to-delete reg-to-delete-beg reg-to-delete-end)
-       
+
     (setq reg-to-delete-beg
          (ediff-get-diff-posn to-buf-type 'beg n ctrl-buf))
     (setq reg-to-delete-end
          (ediff-get-diff-posn to-buf-type 'end n ctrl-buf))
-         
+
     (if reg-to-copy
        (setq from-buf-type nil)
       (setq reg-to-copy (ediff-get-region-contents n from-buf-type ctrl-buf)))
-    
+
     (setq reg-to-delete (ediff-get-region-contents
                         n to-buf-type ctrl-buf
                         reg-to-delete-beg reg-to-delete-end))
-    
+
     (if (string= reg-to-delete reg-to-copy)
        (setq saved-p nil) ; don't copy identical buffers
       ;; seems ok to copy
       (if (or batch-invocation (ediff-test-save-region n to-buf-type))
          (condition-case conds
              (progn
-               (ediff-eval-in-buffer to-buf
+               (ediff-with-current-buffer to-buf
                  ;; to prevent flags from interfering if buffer is writable
                  (let ((inhibit-read-only (null buffer-read-only)))
-                   
+
                    (goto-char reg-to-delete-end)
                    (insert reg-to-copy)
-                   
+
                    (if (> reg-to-delete-end reg-to-delete-beg)
                        (kill-region reg-to-delete-beg reg-to-delete-end))
                    ))
                (or batch-invocation
-                   (setq 
+                   (setq
                     messg
                     (ediff-save-diff-region n to-buf-type reg-to-delete))))
            (error (message "ediff-copy-diff: %s %s"
@@ -1895,7 +2059,7 @@ ARG is a prefix argument. If nil, copy the current difference region."
                   (setq saved-p nil)
                   )))
       )
-    
+
     ;; adjust state of difference in case 3-way and diff was copied ok
     (if (and saved-p three-way)
        (ediff-set-state-of-diff-in-all-buffers n ctrl-buf))
@@ -1906,18 +2070,18 @@ ARG is a prefix argument. If nil, copy the current difference region."
       ;; before reinserting flags (and thus before ediff-recenter).
       (if (and saved-p three-way)
          (ediff-clear-fine-differences n))
-      
+
       (ediff-refresh-mode-lines)
-      
+
       ;; For diff2 jobs, don't recompute fine diffs, since we know there
-      ;; aren't any. So we clear diffs after ediff-recenter.
+      ;; aren't any.  So we clear diffs after ediff-recenter.
       (if (and saved-p (not three-way))
          (ediff-clear-fine-differences n))
       ;; Make sure that the message about saving and how to restore is seen
       ;; by the user
-      (message messg))
+      (message "%s" messg))
     ))
-     
+
 ;; Save Nth diff of buffer BUF-TYPE \(A, B, or C\).
 ;; That is to say, the Nth diff on the `ediff-killed-diffs-alist'.  REG
 ;; is the region to save.  It is redundant here, but is passed anyway, for
@@ -1926,7 +2090,7 @@ ARG is a prefix argument. If nil, copy the current difference region."
   (let* ((n-th-diff-saved (assoc n ediff-killed-diffs-alist))
         (buf (ediff-get-buffer buf-type))
         (this-buf-n-th-diff-saved (assoc buf (cdr n-th-diff-saved))))
-        
+
     (if this-buf-n-th-diff-saved
        ;; either nothing saved for n-th diff and buffer or we OK'ed
        ;; overriding
@@ -1936,27 +2100,27 @@ ARG is a prefix argument. If nil, copy the current difference region."
        (setq ediff-killed-diffs-alist  ;; create record for n-th diff
              (cons (list n (cons buf reg))
                    ediff-killed-diffs-alist))))
-    (message "Saving old diff region #%d of buffer %S. To recover, type `r%s'"
+    (message "Saving old diff region #%d of buffer %S.  To recover, type `r%s'"
             (1+ n) buf-type
             (if ediff-merge-job
                 "" (downcase (symbol-name buf-type))))
     ))
-    
+
 ;; Test if saving Nth difference region of buffer BUF-TYPE is possible.
 (defun ediff-test-save-region (n buf-type)
   (let* ((n-th-diff-saved (assoc n ediff-killed-diffs-alist))
         (buf (ediff-get-buffer buf-type))
         (this-buf-n-th-diff-saved (assoc buf (cdr n-th-diff-saved))))
-        
+
     (if this-buf-n-th-diff-saved
        (if (yes-or-no-p
-            (format 
-             "You've previously copied diff region %d to buffer %S. Confirm "
+            (format
+             "You've previously copied diff region %d to buffer %S.  Confirm? "
              (1+ n) buf-type))
            t
          (error "Quit"))
       t)))
-         
+
 (defun ediff-pop-diff (n buf-type)
   "Pop last killed Nth diff region from buffer BUF-TYPE."
   (let* ((n-th-record (assoc n ediff-killed-diffs-alist))
@@ -1966,54 +2130,54 @@ ARG is a prefix argument. If nil, copy the current difference region."
         (ctl-buf ediff-control-buffer)
         ediff-verbose-p
         saved-diff reg-beg reg-end recovered)
-       
+
     (if (cdr saved-rec)
        (setq saved-diff (cdr saved-rec))
       (if (> ediff-number-of-differences 0)
          (error "Nothing saved for diff %d in buffer %S" (1+ n) buf-type)
        (error ediff-NO-DIFFERENCES)))
-    
+
     (setq reg-beg (ediff-get-diff-posn buf-type 'beg n ediff-control-buffer))
     (setq reg-end (ediff-get-diff-posn buf-type 'end n ediff-control-buffer))
-    
+
     (condition-case conds
-       (ediff-eval-in-buffer buf
+       (ediff-with-current-buffer buf
          (let ((inhibit-read-only (null buffer-read-only)))
-           
+
            (goto-char reg-end)
            (insert saved-diff)
-           
+
            (if (> reg-end reg-beg)
                (kill-region reg-beg reg-end))
-           
+
            (setq recovered t)
            ))
       (error (message "ediff-pop-diff: %s %s"
                      (car conds)
                      (mapconcat 'prin1-to-string (cdr conds) " "))
             (beep 1)))
-    
+
     ;; Clearing fine diffs is necessary for
-    ;; ediff-unselect-and-select-difference to properly recompute them. We
+    ;; ediff-unselect-and-select-difference to properly recompute them.  We
     ;; can't rely on ediff-copy-diff to clear this vector, as the user might
     ;; have modified diff regions after copying and, thus, may have recomputed
     ;; fine diffs.
     (if recovered
        (ediff-clear-fine-differences n))
-         
+
     ;; adjust state of difference
     (if (and three-way recovered)
        (ediff-set-state-of-diff-in-all-buffers n ctl-buf))
-       
+
     (ediff-refresh-mode-lines)
-    
+
     (if recovered
        (progn
          (setq n-th-record (delq saved-rec n-th-record))
          (message "Diff region %d in buffer %S restored" (1+ n) buf-type)
          ))
     ))
-      
+
 (defun ediff-restore-diff  (arg &optional key)
   "Restore ARGth diff from `ediff-killed-diffs-alist'.
 ARG is a prefix argument.  If ARG is nil, restore the current-difference.
@@ -2023,7 +2187,7 @@ determine the target buffer instead of last-command-char"
   (ediff-barf-if-not-control-buffer)
   (if (numberp arg)
       (ediff-jump-to-difference arg))
-  (ediff-pop-diff ediff-current-difference 
+  (ediff-pop-diff ediff-current-difference
                  (ediff-char-to-buftype (or key last-command-char)))
   ;; recenter with rehighlighting, but no messages
   (let (ediff-verbose-p)
@@ -2031,11 +2195,11 @@ determine the target buffer instead of last-command-char"
 
 (defun ediff-restore-diff-in-merge-buffer (arg)
   "Restore ARGth diff in the merge buffer.
-ARG is a prefix argument. If nil, restore the current diff."
+ARG is a prefix argument.  If nil, restore the current diff."
   (interactive "P")
   (ediff-restore-diff arg ?c))
-  
-  
+
+
 (defun ediff-toggle-regexp-match ()
   "Toggle between focusing and hiding of difference regions that match
 a regular expression typed in by the user."
@@ -2056,21 +2220,21 @@ a regular expression typed in by the user."
       (setq ediff-skip-diff-region-function 'ediff-show-all-diffs))
      ((eq last-command-char ?h)
       (setq ediff-skip-diff-region-function ediff-hide-regexp-matches-function
-           regexp-A 
+           regexp-A
            (read-string
-            (format 
-             "Ignore A-regions matching this regexp (default \"%s\"): "
+            (format
+             "Ignore A-regions matching this regexp (default %s): "
              ediff-regexp-hide-A))
            regexp-B
            (read-string
-            (format 
-             "Ignore B-regions matching this regexp (default \"%s\"): "
+            (format
+             "Ignore B-regions matching this regexp (default %s): "
              ediff-regexp-hide-B)))
       (if ediff-3way-comparison-job
          (setq regexp-C
                (read-string
-                (format 
-                 "Ignore C-regions matching this regexp (default \"%s\"): "
+                (format
+                 "Ignore C-regions matching this regexp (default %s): "
                  ediff-regexp-hide-C))))
       (if (eq ediff-hide-regexp-connective 'and)
          (setq msg-connective "BOTH"
@@ -2082,11 +2246,11 @@ a regular expression typed in by the user."
       (if (y-or-n-p
           (format
            "Ignore regions that match %s regexps, OK? "
-           msg-connective alt-msg-connective))
+           msg-connective))
          (message "Will ignore regions that match %s regexps" msg-connective)
        (setq ediff-hide-regexp-connective alt-connective)
        (message "Will ignore regions that match %s regexps"
-                alt-msg-connective)) 
+                alt-msg-connective))
 
       (or (string= regexp-A "") (setq ediff-regexp-hide-A regexp-A))
       (or (string= regexp-B "") (setq ediff-regexp-hide-B regexp-B))
@@ -2095,21 +2259,21 @@ a regular expression typed in by the user."
      ((eq last-command-char ?f)
       (setq ediff-skip-diff-region-function
            ediff-focus-on-regexp-matches-function
-           regexp-A 
+           regexp-A
            (read-string
-            (format 
-             "Focus on A-regions matching this regexp (default \"%s\"): "
+            (format
+             "Focus on A-regions matching this regexp (default %s): "
              ediff-regexp-focus-A))
            regexp-B
            (read-string
-            (format 
-             "Focus on B-regions matching this regexp (default \"%s\"): "
+            (format
+             "Focus on B-regions matching this regexp (default %s): "
              ediff-regexp-focus-B)))
       (if ediff-3way-comparison-job
          (setq regexp-C
                (read-string
-                (format 
-                 "Focus on C-regions matching this regexp (default \"%s\"): "
+                (format
+                 "Focus on C-regions matching this regexp (default %s): "
                  ediff-regexp-focus-C))))
       (if (eq ediff-focus-regexp-connective 'and)
          (setq msg-connective "BOTH"
@@ -2121,17 +2285,17 @@ a regular expression typed in by the user."
       (if (y-or-n-p
           (format
            "Focus on regions that match %s regexps, OK? "
-           msg-connective alt-msg-connective))
+           msg-connective))
          (message "Will focus on regions that match %s regexps"
                   msg-connective)
        (setq ediff-focus-regexp-connective alt-connective)
-       (message "Will focus on regions that match %s regexps" 
+       (message "Will focus on regions that match %s regexps"
                 alt-msg-connective))
 
       (or (string= regexp-A "") (setq ediff-regexp-focus-A regexp-A))
       (or (string= regexp-B "") (setq ediff-regexp-focus-B regexp-B))
       (or (string= regexp-C "") (setq ediff-regexp-focus-C regexp-C))))))
-      
+
 (defun ediff-toggle-skip-similar ()
   (interactive)
   (ediff-barf-if-not-control-buffer)
@@ -2143,37 +2307,37 @@ a regular expression typed in by the user."
       (message
        "Skipping regions that differ only in white space & line breaks")
     (message "Skipping over white-space differences turned off")))
-  
+
 (defun ediff-focus-on-regexp-matches (n)
   "Focus on diffs that match regexp `ediff-regexp-focus-A/B'.
-Regions to be ignored according to this function are those where   
+Regions to be ignored according to this function are those where
 buf A region doesn't match `ediff-regexp-focus-A' and buf B region
 doesn't match `ediff-regexp-focus-B'.
 This function returns nil if the region number N (specified as
 an argument) is not to be ignored and t if region N is to be ignored.
 
-N is a region number used by Ediff internally. It is 1 less
+N is a region number used by Ediff internally.  It is 1 less
 the number seen by the user."
   (if (ediff-valid-difference-p n)
       (let* ((ctl-buf ediff-control-buffer)
             (regex-A ediff-regexp-focus-A)
             (regex-B ediff-regexp-focus-B)
             (regex-C ediff-regexp-focus-C)
-            (reg-A-match (ediff-eval-in-buffer ediff-buffer-A
+            (reg-A-match (ediff-with-current-buffer ediff-buffer-A
                            (save-restriction
                              (narrow-to-region
                               (ediff-get-diff-posn 'A 'beg n ctl-buf)
                               (ediff-get-diff-posn 'A 'end n ctl-buf))
                              (goto-char (point-min))
                              (re-search-forward regex-A nil t))))
-            (reg-B-match (ediff-eval-in-buffer ediff-buffer-B
+            (reg-B-match (ediff-with-current-buffer ediff-buffer-B
                            (save-restriction
                              (narrow-to-region
                               (ediff-get-diff-posn 'B 'beg n ctl-buf)
                               (ediff-get-diff-posn 'B 'end n ctl-buf))
                              (re-search-forward regex-B nil t))))
             (reg-C-match (if ediff-3way-comparison-job
-                             (ediff-eval-in-buffer ediff-buffer-C
+                             (ediff-with-current-buffer ediff-buffer-C
                                (save-restriction
                                  (narrow-to-region
                                   (ediff-get-diff-posn 'C 'beg n ctl-buf)
@@ -2185,29 +2349,29 @@ the number seen by the user."
                     (list ediff-focus-regexp-connective
                           reg-A-match reg-B-match))))
        )))
-  
-(defun ediff-hide-regexp-matches (n)  
+
+(defun ediff-hide-regexp-matches (n)
   "Hide diffs that match regexp `ediff-regexp-hide-A/B/C'.
 Regions to be ignored are those where buf A region matches
 `ediff-regexp-hide-A' and buf B region matches `ediff-regexp-hide-B'.
 This function returns nil if the region number N (specified as
 an argument) is not to be ignored and t if region N is to be ignored.
 
-N is a region number used by Ediff internally. It is 1 less
+N is a region number used by Ediff internally.  It is 1 less
 the number seen by the user."
   (if (ediff-valid-difference-p n)
       (let* ((ctl-buf ediff-control-buffer)
             (regex-A ediff-regexp-hide-A)
             (regex-B ediff-regexp-hide-B)
             (regex-C ediff-regexp-hide-C)
-            (reg-A-match (ediff-eval-in-buffer ediff-buffer-A
+            (reg-A-match (ediff-with-current-buffer ediff-buffer-A
                            (save-restriction
                              (narrow-to-region
                               (ediff-get-diff-posn 'A 'beg n ctl-buf)
                               (ediff-get-diff-posn 'A 'end n ctl-buf))
                              (goto-char (point-min))
                              (re-search-forward regex-A nil t))))
-            (reg-B-match (ediff-eval-in-buffer ediff-buffer-B
+            (reg-B-match (ediff-with-current-buffer ediff-buffer-B
                            (save-restriction
                              (narrow-to-region
                               (ediff-get-diff-posn 'B 'beg n ctl-buf)
@@ -2215,7 +2379,7 @@ the number seen by the user."
                              (goto-char (point-min))
                              (re-search-forward regex-B nil t))))
             (reg-C-match (if ediff-3way-comparison-job
-                             (ediff-eval-in-buffer ediff-buffer-C
+                             (ediff-with-current-buffer ediff-buffer-C
                                (save-restriction
                                  (narrow-to-region
                                   (ediff-get-diff-posn 'C 'beg n ctl-buf)
@@ -2227,7 +2391,7 @@ the number seen by the user."
                        reg-A-match reg-B-match reg-C-match)
                (list ediff-hide-regexp-connective reg-A-match reg-B-match)))
        )))
-    
+
 
 \f
 ;;; Quitting, suspending, etc.
@@ -2239,8 +2403,8 @@ flags of the compared file buffers, kills Ediff buffers for this session
 \(but not buffers A, B, C\).
 
 If `ediff-keep-variants' is nil, the user will be asked whether the buffers
-containing the variants should be removed \(if they haven't been modified\). 
-If it is t, they will be preserved unconditionally. A prefix argument, 
+containing the variants should be removed \(if they haven't been modified\).
+If it is t, they will be preserved unconditionally.  A prefix argument,
 temporarily reverses the meaning of this variable."
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
@@ -2264,57 +2428,59 @@ temporarily reverses the meaning of this variable."
   (ediff-clear-diff-vector 'ediff-difference-vector-Ancestor 'fine-diffs-also)
 
   (ediff-delete-temp-files)
-                                 
-  ;; Restore visibility range. This affects only ediff-*-regions/windows.
+
+  ;; Restore the visibility range.  This affects only ediff-*-regions/windows.
   ;; Since for other job names ediff-visible-region sets
   ;; ediff-visible-bounds to ediff-wide-bounds, the settings below are
   ;; ignored for such jobs.
   (if ediff-quit-widened
       (setq ediff-visible-bounds ediff-wide-bounds)
     (setq ediff-visible-bounds ediff-narrow-bounds))
-  
+
   ;; Apply selective display to narrow or widen
   (ediff-visible-region)
-  (mapcar (function (lambda (overl)
-                     (if (ediff-overlayp overl)
-                         (ediff-delete-overlay overl))))
+  (mapcar (lambda (overl)
+           (if (ediff-overlayp overl)
+               (ediff-delete-overlay overl)))
          ediff-wide-bounds)
-  (mapcar (function (lambda (overl)
-                     (if (ediff-overlayp overl)
-                         (ediff-delete-overlay overl))))
+  (mapcar (lambda (overl)
+           (if (ediff-overlayp overl)
+               (ediff-delete-overlay overl)))
          ediff-narrow-bounds)
 
   ;; restore buffer mode line id's in buffer-A/B/C
   (let ((control-buffer ediff-control-buffer)
        (meta-buffer ediff-meta-buffer)
+       (after-quit-hook-internal ediff-after-quit-hook-internal)
+       (session-number ediff-meta-session-number)
        ;; suitable working frame
        (warp-frame (if (and (ediff-window-display-p) (eq ediff-grab-mouse t))
-                       (cond ((window-live-p ediff-window-A) 
+                       (cond ((window-live-p ediff-window-A)
                               (window-frame ediff-window-A))
-                             ((window-live-p ediff-window-B) 
+                             ((window-live-p ediff-window-B)
                               (window-frame ediff-window-B))
                              (t (next-frame))))))
     (condition-case nil
-       (ediff-eval-in-buffer ediff-buffer-A
-         (setq ediff-this-buffer-ediff-sessions 
+       (ediff-with-current-buffer ediff-buffer-A
+         (setq ediff-this-buffer-ediff-sessions
                (delq control-buffer ediff-this-buffer-ediff-sessions))
          (kill-local-variable 'mode-line-buffer-identification)
          (kill-local-variable 'mode-line-format)
          )
       (error))
-      
+
     (condition-case nil
-       (ediff-eval-in-buffer ediff-buffer-B
-         (setq ediff-this-buffer-ediff-sessions 
+       (ediff-with-current-buffer ediff-buffer-B
+         (setq ediff-this-buffer-ediff-sessions
                (delq control-buffer ediff-this-buffer-ediff-sessions))
          (kill-local-variable 'mode-line-buffer-identification)
          (kill-local-variable 'mode-line-format)
          )
       (error))
-    
+
     (condition-case nil
-       (ediff-eval-in-buffer ediff-buffer-C
-         (setq ediff-this-buffer-ediff-sessions 
+       (ediff-with-current-buffer ediff-buffer-C
+         (setq ediff-this-buffer-ediff-sessions
                (delq control-buffer ediff-this-buffer-ediff-sessions))
          (kill-local-variable 'mode-line-buffer-identification)
          (kill-local-variable 'mode-line-format)
@@ -2322,8 +2488,8 @@ temporarily reverses the meaning of this variable."
       (error))
 
     (condition-case nil
-       (ediff-eval-in-buffer ediff-ancestor-buffer
-         (setq ediff-this-buffer-ediff-sessions 
+       (ediff-with-current-buffer ediff-ancestor-buffer
+         (setq ediff-this-buffer-ediff-sessions
                (delq control-buffer ediff-this-buffer-ediff-sessions))
          (kill-local-variable 'mode-line-buffer-identification)
          (kill-local-variable 'mode-line-format)
@@ -2343,53 +2509,77 @@ temporarily reverses the meaning of this variable."
          (run-hooks 'ediff-quit-merge-hook))
     (quit))
 
-  ;; good place to kill buffers A/B/C
   (run-hooks 'ediff-cleanup-hook)
-  (let ((ediff-keep-variants ediff-keep-variants))
-    (if reverse-default-keep-variants
-       (setq ediff-keep-variants (not ediff-keep-variants)))
-    (or ediff-keep-variants (ediff-janitor 'ask)))
 
+  (ediff-janitor
+   'ask
+   ;; reverse-default-keep-variants is t if the user quits with a prefix arg
+   (if reverse-default-keep-variants
+       (not ediff-keep-variants)
+     ediff-keep-variants))
+
+  ;; one hook here is ediff-cleanup-mess, which kills the control buffer and
+  ;; other auxiliary buffers. we made it into a hook to let the users do their
+  ;; own cleanup, if needed.
   (run-hooks 'ediff-quit-hook)
-  (ediff-cleanup-meta-buffer meta-buffer)
+  (ediff-update-meta-buffer meta-buffer nil session-number)
 
   ;; warp mouse into a working window
   (setq warp-frame  ; if mouse is over a reasonable frame, use it
-       (cond ((and ediff-xemacs-p (window-live-p (car (mouse-position))))
-              (window-frame (car (mouse-position))))
-             ((frame-live-p (car (mouse-position)))
-              (car (mouse-position)))
+       (cond ((ediff-good-frame-under-mouse))
              (t warp-frame)))
-  (if (frame-live-p warp-frame)
+  (if (and (ediff-window-display-p) (frame-live-p warp-frame) ediff-grab-mouse)
       (set-mouse-position (if ediff-emacs-p
                              warp-frame
                            (frame-selected-window warp-frame))
                          2 1))
 
-  (if (ediff-buffer-live-p meta-buffer)
-      (ediff-show-meta-buffer meta-buffer))
+  (run-hooks 'after-quit-hook-internal)
   ))
-  
-  
+
+;; Returns frame under mouse, if this frame is not a minibuffer
+;; frame.  Otherwise: nil
+(defun ediff-good-frame-under-mouse ()
+  (let ((frame-or-win (car (mouse-position)))
+       (buf-name "")
+       frame obj-ok)
+    (setq obj-ok
+         (if ediff-emacs-p
+             (frame-live-p frame-or-win)
+           (window-live-p frame-or-win)))
+    (if obj-ok
+       (setq frame (if ediff-emacs-p frame-or-win (window-frame frame-or-win))
+             buf-name
+             (buffer-name (window-buffer (frame-selected-window frame)))))
+    (if (string-match "Minibuf" buf-name)
+       nil
+      frame)))
+
+
 (defun ediff-delete-temp-files ()
-  (if (stringp ediff-temp-file-A)
+  (if (and (stringp ediff-temp-file-A) (file-exists-p ediff-temp-file-A))
       (delete-file ediff-temp-file-A))
-  (if (stringp ediff-temp-file-B)
+  (if (and (stringp ediff-temp-file-B) (file-exists-p ediff-temp-file-B))
       (delete-file ediff-temp-file-B))
-  (if (stringp ediff-temp-file-C)
+  (if (and (stringp ediff-temp-file-C) (file-exists-p ediff-temp-file-C))
       (delete-file ediff-temp-file-C)))
-  
+
 
 ;; Kill control buffer, other auxiliary Ediff buffers.
 ;; Leave one of the frames split between buffers A/B/C
 (defun ediff-cleanup-mess ()
-  (let ((buff-A ediff-buffer-A)
-       (buff-B ediff-buffer-B)
-       (buff-C ediff-buffer-C)
-       (ctl-buf  ediff-control-buffer)
-       (ctl-frame ediff-control-frame)
-       (three-way-job ediff-3way-job))
-       
+  (let* ((buff-A ediff-buffer-A)
+        (buff-B ediff-buffer-B)
+        (buff-C ediff-buffer-C)
+        (ctl-buf  ediff-control-buffer)
+        (ctl-wind  (ediff-get-visible-buffer-window ctl-buf))
+        (ctl-frame ediff-control-frame)
+        (three-way-job ediff-3way-job)
+        (main-frame (cond ((window-live-p ediff-window-A)
+                           (window-frame ediff-window-A))
+                          ((window-live-p ediff-window-B)
+                           (window-frame ediff-window-B)))))
+
     (ediff-kill-buffer-carefully ediff-diff-buffer)
     (ediff-kill-buffer-carefully ediff-custom-diff-buffer)
     (ediff-kill-buffer-carefully ediff-fine-diff-buffer)
@@ -2400,16 +2590,21 @@ temporarily reverses the meaning of this variable."
     (if (boundp 'ediff-patch-diagnostics)
        (ediff-kill-buffer-carefully ediff-patch-diagnostics))
 
-    (if (and (ediff-window-display-p) (frame-live-p ctl-frame))
-       (delete-frame ctl-frame))
+    ;; delete control frame or window
+    (cond ((and (ediff-window-display-p) (frame-live-p ctl-frame))
+          (delete-frame ctl-frame))
+         ((window-live-p ctl-wind)
+          (delete-window ctl-wind)))
+
     ;; Hide bottom toolbar.  --marcpa
     (if (not (ediff-multiframe-setup-p))
        (ediff-kill-bottom-toolbar))
 
     (ediff-kill-buffer-carefully ctl-buf)
-      
-    (delete-other-windows)
-    
+
+    (if (frame-live-p main-frame)
+       (select-frame main-frame))
+
     ;; display only if not visible
     (condition-case nil
        (or (ediff-get-visible-buffer-window buff-B)
@@ -2418,7 +2613,8 @@ temporarily reverses the meaning of this variable."
     (condition-case nil
        (or (ediff-get-visible-buffer-window buff-A)
            (progn
-             (if (ediff-get-visible-buffer-window buff-B)
+             (if (and (ediff-get-visible-buffer-window buff-B)
+                      (ediff-buffer-live-p buff-A))
                  (funcall ediff-split-window-function))
              (switch-to-buffer buff-A)))
       (error))
@@ -2426,55 +2622,73 @@ temporarily reverses the meaning of this variable."
        (condition-case nil
            (or (ediff-get-visible-buffer-window buff-C)
                (progn
-                 (if (or (ediff-get-visible-buffer-window buff-A)
-                         (ediff-get-visible-buffer-window buff-B))
+                 (if (and (or (ediff-get-visible-buffer-window buff-A)
+                              (ediff-get-visible-buffer-window buff-B))
+                          (ediff-buffer-live-p buff-C))
                      (funcall ediff-split-window-function))
-                 (switch-to-buffer buff-C)
-                 (balance-windows)))
+                 (switch-to-buffer buff-C)))
          (error)))
+    (balance-windows)
     (message "")
     ))
 
-(defun ediff-janitor (&optional ask)
+(defun ediff-janitor (ask keep-variants)
   "Kill buffers A, B, and, possibly, C, if these buffers aren't modified.
-In merge jobs, buffer C is never deleted.
-However, the side effect of cleaning up may be that you cannot compare the same
-buffer in two separate Ediff sessions: quitting one of them will delete this
-buffer in another session as well."
-  (or (not (ediff-buffer-live-p ediff-buffer-A))
-      (buffer-modified-p ediff-buffer-A)
-      (and ask
-          (not (y-or-n-p (format "Kill buffer A [%s]? "
-                                 (buffer-name ediff-buffer-A)))))
-      (ediff-kill-buffer-carefully ediff-buffer-A))
-  (or (not (ediff-buffer-live-p ediff-buffer-B))
-      (buffer-modified-p ediff-buffer-B)
-      (and ask
-          (not (y-or-n-p (format "Kill buffer B [%s]? "
-                                 (buffer-name ediff-buffer-B)))))
-      (ediff-kill-buffer-carefully ediff-buffer-B))
+In merge jobs, buffer C is not deleted here, but rather according to
+ediff-quit-merge-hook.
+A side effect of cleaning up may be that you should be careful when comparing
+the same buffer in two separate Ediff sessions: quitting one of them might
+delete this buffer in another session as well."
+  (ediff-dispose-of-variant-according-to-user
+   ediff-buffer-A 'A ask keep-variants)
+  (ediff-dispose-of-variant-according-to-user
+   ediff-buffer-B 'B ask keep-variants)
   (if ediff-merge-job  ; don't del buf C if merging--del ancestor buf instead
-      (or (not (ediff-buffer-live-p ediff-ancestor-buffer))
-         (buffer-modified-p ediff-ancestor-buffer)
-         (and ask
-              (not (y-or-n-p (format "Kill the ancestor buffer [%s]? "
-                                     (buffer-name ediff-ancestor-buffer)))))
-         (ediff-kill-buffer-carefully ediff-ancestor-buffer))
-    (or (not (ediff-buffer-live-p ediff-buffer-C))
-       (buffer-modified-p ediff-buffer-C)
-       (and ask (not (y-or-n-p (format "Kill buffer C [%s]? "
-                                       (buffer-name ediff-buffer-C)))))
-       (ediff-kill-buffer-carefully ediff-buffer-C))))
+      (ediff-dispose-of-variant-according-to-user
+       ediff-ancestor-buffer 'Ancestor ask keep-variants)
+    (ediff-dispose-of-variant-according-to-user
+     ediff-buffer-C 'C ask keep-variants)
+    ))
+
+;; Kill the variant buffer, according to user directives (ask, kill
+;; unconditionaly, keep)
+;; BUFF is the buffer, BUFF-TYPE is either 'A, or 'B, 'C, 'Ancestor
+(defun ediff-dispose-of-variant-according-to-user (buff bufftype ask keep-variants)
+  ;; if this is indirect buffer, kill it and substitute with direct buf
+  (if (and (ediff-buffer-live-p buff)
+          (ediff-with-current-buffer buff ediff-temp-indirect-buffer))
+      (let ((wind (ediff-get-visible-buffer-window buff))
+           (base (buffer-base-buffer buff))
+           (modified-p (buffer-modified-p buff)))
+       (if (and (window-live-p wind) (ediff-buffer-live-p base))
+           (set-window-buffer wind base))
+       ;; Kill indirect buffer even if it is modified, because the base buffer
+       ;; is still there. Note that if the base buffer is dead then so will be
+       ;; the indirect buffer
+       (ediff-with-current-buffer buff
+         (set-buffer-modified-p nil))
+       (ediff-kill-buffer-carefully buff)
+       (ediff-with-current-buffer base
+         (set-buffer-modified-p modified-p)))
+    ;; otherwise, ask or use the value of keep-variants
+    (or (not (ediff-buffer-live-p buff))
+       keep-variants
+       (buffer-modified-p buff)
+       (and ask
+            (not (y-or-n-p (format "Kill buffer %S [%s]? "
+                                   bufftype (buffer-name buff)))))
+       (ediff-kill-buffer-carefully buff))
+    ))
 
 (defun ediff-maybe-save-and-delete-merge (&optional save-and-continue)
   "Default hook to run on quitting a merge job.
 This can also be used to save merge buffer in the middle of an Ediff session.
 
 If the optional SAVE-AND-CONTINUE argument is non-nil, save merge buffer and
-continue. Otherwise:
+continue.  Otherwise:
 If `ediff-autostore-merges' is nil, this does nothing.
 If it is t, it saves the merge buffer in the file `ediff-merge-store-file'
-or asks the user, if the latter is nil. It then asks the user whether to
+or asks the user, if the latter is nil.  It then asks the user whether to
 delete the merge buffer.
 If `ediff-autostore-merges' is neither nil nor t, the merge buffer is saved
 only if this merge job is part of a group, i.e., was invoked from within
@@ -2483,47 +2697,58 @@ only if this merge job is part of a group, i.e., was invoked from within
        (ediff-autostore-merges ; fake ediff-autostore-merges, if necessary
         (if save-and-continue t ediff-autostore-merges)))
     (if ediff-autostore-merges
-       (cond ((stringp ediff-merge-store-file)
+       (cond ((stringp merge-store-file)
               ;; store, ask to delete
               (ediff-write-merge-buffer-and-maybe-kill
                ediff-buffer-C merge-store-file 'show-file save-and-continue))
              ((eq ediff-autostore-merges t)
               ;; ask for file name
               (setq merge-store-file
-                    (read-file-name "Save the merge buffer in file: "))
+                    (read-file-name "Save the result of the merge in file: "))
               (ediff-write-merge-buffer-and-maybe-kill
                ediff-buffer-C merge-store-file nil save-and-continue))
              ((and (ediff-buffer-live-p ediff-meta-buffer)
-                   (ediff-eval-in-buffer ediff-meta-buffer
+                   (ediff-with-current-buffer ediff-meta-buffer
                      (ediff-merge-metajob)))
-              ;; This case shouldn't occur, as the parent metajob must pass on
-              ;; a file name, ediff-merge-store-file, where to save the result
-              ;; of the merge.
-              ;; Ask where to save anyway--will decide what to do here later.
-              (setq merge-store-file
-                    (read-file-name "Save the merge buffer in file: "))
-              (ediff-write-merge-buffer-and-maybe-kill
-               ediff-buffer-C merge-store-file nil save-and-continue))))
+              ;; The parent metajob passed nil as the autostore file.
+              nil)))
     ))
 
-;; write merge buffer. If the optional argument save-and-continue is non-nil,
+;; write merge buffer.  If the optional argument save-and-continue is non-nil,
 ;; then don't kill the merge buffer
 (defun ediff-write-merge-buffer-and-maybe-kill (buf file
                                               &optional
                                               show-file save-and-continue)
-  (ediff-eval-in-buffer buf
-    (if (or (not (file-exists-p file))
-           (y-or-n-p (format "File %s exists, overwrite? " file)))
-       (progn
-         (write-region (point-min) (point-max) file)
-         (if show-file
-             (progn
-               (message "Merge buffer saved in: %s" file)
-               (sit-for 2)))
-         (if (and
-              (not save-and-continue)
-              (y-or-n-p "Merge buffer saved in file. Now kill the buffer? "))
-             (ediff-kill-buffer-carefully buf))))))
+  (if (not (eq (find-buffer-visiting file) buf))
+      (let ((warn-message
+            (format "Another buffer is visiting file %s. Too dangerous to save the merge buffer"
+                    file)))
+       (beep)
+       (message "%s" warn-message)
+       (with-output-to-temp-buffer ediff-msg-buffer
+         (princ "\n\n")
+         (princ warn-message)
+         (princ "\n\n")
+         )
+       (sit-for 2))
+    (ediff-with-current-buffer buf
+      (if (or (not (file-exists-p file))
+             (y-or-n-p (format "File %s exists, overwrite? " file)))
+         (progn
+           ;;(write-region (point-min) (point-max) file)
+           (ediff-with-current-buffer buf
+             (set-visited-file-name file)
+             (save-buffer))
+           (if show-file
+               (progn
+                 (message "Merge buffer saved in: %s" file)
+                 (set-buffer-modified-p nil)
+                 (sit-for 3)))
+           (if (and
+                (not save-and-continue)
+                (y-or-n-p "Merge buffer saved.  Now kill the buffer? "))
+               (ediff-kill-buffer-carefully buf)))))
+    ))
 
 ;; The default way of suspending Ediff.
 ;; Buries Ediff buffers, kills all windows.
@@ -2541,11 +2766,11 @@ only if this merge job is part of a group, i.e., was invoked from within
         (buf-diff ediff-diff-buffer)
         (buf-custom-diff ediff-custom-diff-buffer)
         (buf-fine-diff ediff-fine-diff-buffer))
-    
+
     ;; hide the control panel
     (if (and (ediff-window-display-p) (frame-live-p ediff-control-frame))
        (iconify-frame ediff-control-frame)
-      (bury-buffer)) 
+      (bury-buffer))
     (if buf-err (bury-buffer buf-err))
     (if buf-diff (bury-buffer buf-diff))
     (if buf-custom-diff (bury-buffer buf-custom-diff))
@@ -2581,7 +2806,7 @@ only if this merge job is part of a group, i.e., was invoked from within
            (bury-buffer))))
     ))
 
-     
+
 (defun ediff-suspend ()
   "Suspend Ediff.
 To resume, switch to the appropriate `Ediff Control Panel'
@@ -2602,27 +2827,29 @@ Hit \\[ediff-recenter] to reset the windows afterward."
   (save-excursion
     (ediff-skip-unsuitable-frames))
   (with-output-to-temp-buffer ediff-msg-buffer
+    (ediff-with-current-buffer standard-output
+      (fundamental-mode))
     (raise-frame (selected-frame))
     (princ (ediff-version))
     (princ "\n\n")
-    (ediff-eval-in-buffer ediff-buffer-A
+    (ediff-with-current-buffer ediff-buffer-A
       (if buffer-file-name
          (princ
           (format "File A = %S\n" buffer-file-name))
-       (princ 
+       (princ
         (format "Buffer A = %S\n" (buffer-name)))))
-    (ediff-eval-in-buffer ediff-buffer-B
+    (ediff-with-current-buffer ediff-buffer-B
       (if buffer-file-name
          (princ
           (format "File B = %S\n" buffer-file-name))
-       (princ 
+       (princ
         (format "Buffer B = %S\n" (buffer-name)))))
     (if ediff-3way-job
-       (ediff-eval-in-buffer ediff-buffer-C
+       (ediff-with-current-buffer ediff-buffer-C
          (if buffer-file-name
              (princ
               (format "File C = %S\n" buffer-file-name))
-           (princ 
+           (princ
             (format "Buffer C = %S\n" (buffer-name))))))
     (princ (format "Customized diff output %s\n"
                   (if (ediff-buffer-live-p ediff-custom-diff-buffer)
@@ -2634,20 +2861,20 @@ Hit \\[ediff-recenter] to reset the windows afterward."
                       (concat "\tin buffer "
                               (buffer-name ediff-diff-buffer))
                     " is not available")))
-                             
-    (let* ((A-line (ediff-eval-in-buffer ediff-buffer-A
+
+    (let* ((A-line (ediff-with-current-buffer ediff-buffer-A
                     (1+ (count-lines (point-min) (point)))))
-          (B-line (ediff-eval-in-buffer ediff-buffer-B
+          (B-line (ediff-with-current-buffer ediff-buffer-B
                     (1+ (count-lines (point-min) (point)))))
           C-line)
       (princ (format "\Buffer A's point is on line %d\n" A-line))
       (princ (format "Buffer B's point is on line %d\n" B-line))
       (if ediff-3way-job
          (progn
-           (setq C-line (ediff-eval-in-buffer ediff-buffer-C
+           (setq C-line (ediff-with-current-buffer ediff-buffer-C
                           (1+ (count-lines (point-min) (point)))))
            (princ (format "Buffer C's point is on line %d\n" C-line)))))
-      
+
     (princ (format "\nCurrent difference number = %S\n"
                   (cond ((< ediff-current-difference 0) 'start)
                         ((>= ediff-current-difference
@@ -2661,7 +2888,10 @@ Hit \\[ediff-recenter] to reset the windows afterward."
     (if (and ediff-merge-job ediff-show-clashes-only)
        (princ
         "\nFocusing on regions where both buffers differ from the ancestor"))
-    
+    (if (and ediff-skip-merge-regions-that-differ-from-default ediff-merge-job)
+       (princ
+        "\nSkipping merge regions that differ from default setting"))
+
     (cond ((eq ediff-skip-diff-region-function 'ediff-show-all-diffs)
           (princ "\nSelective browsing by regexp is off\n"))
          ((eq ediff-skip-diff-region-function
@@ -2669,7 +2899,7 @@ Hit \\[ediff-recenter] to reset the windows afterward."
           (princ
            "\nIgnoring regions that match")
           (princ
-           (format 
+           (format
             "\n\t regexp `%s' in buffer A  %S\n\t regexp `%s' in buffer B\n"
             ediff-regexp-hide-A ediff-hide-regexp-connective
             ediff-regexp-hide-B)))
@@ -2683,7 +2913,7 @@ Hit \\[ediff-recenter] to reset the windows afterward."
             ediff-regexp-focus-A ediff-focus-regexp-connective
             ediff-regexp-focus-B)))
          (t (princ "\nSelective browsing via a user-defined method.\n")))
-    
+
     (princ
      (format "\nBugs/suggestions: type `%s' while in Ediff Control Panel."
             (substitute-command-keys "\\[ediff-submit-report]")))
@@ -2692,7 +2922,7 @@ Hit \\[ediff-recenter] to reset the windows afterward."
       (ediff-reset-mouse ediff-control-frame))
   (if (window-live-p ediff-control-window)
       (select-window ediff-control-window)))
-    
+
 
 
 \f
@@ -2706,33 +2936,34 @@ Hit \\[ediff-recenter] to reset the windows afterward."
           (ediff-buffer-live-p ediff-buffer-B)
           (ediff-valid-difference-p n))
       (progn
-       (if (and (ediff-has-face-support-p) ediff-use-faces)
-           (progn
-             (ediff-highlight-diff n)
-             (setq ediff-highlighting-style 'face))
-         (setq ediff-highlighting-style 'ascii)
-         (ediff-place-flags-in-buffer
-          'A ediff-buffer-A ediff-control-buffer n)
-         (ediff-place-flags-in-buffer
-          'B ediff-buffer-B ediff-control-buffer n)
-         (if ediff-3way-job
-             (ediff-place-flags-in-buffer
-              'C ediff-buffer-C ediff-control-buffer n))
-         (if (ediff-buffer-live-p ediff-ancestor-buffer)
-             (ediff-place-flags-in-buffer
-              'Ancestor ediff-ancestor-buffer
-              ediff-control-buffer n))
-         ) 
-                                      
+       (cond
+           ((and (ediff-has-face-support-p) ediff-use-faces)
+              (ediff-highlight-diff n))
+           ((eq ediff-highlighting-style 'ascii)
+            (ediff-place-flags-in-buffer
+             'A ediff-buffer-A ediff-control-buffer n)
+            (ediff-place-flags-in-buffer
+             'B ediff-buffer-B ediff-control-buffer n)
+            (if ediff-3way-job
+                (ediff-place-flags-in-buffer
+                 'C ediff-buffer-C ediff-control-buffer n))
+            (if (ediff-buffer-live-p ediff-ancestor-buffer)
+                (ediff-place-flags-in-buffer
+                 'Ancestor ediff-ancestor-buffer
+                 ediff-control-buffer n))
+            ))
+
        (ediff-install-fine-diff-if-necessary n)
+       ;; set current difference here so the hook will be able to refer to it
+       (setq ediff-current-difference n)
        (run-hooks 'ediff-select-hook))))
-       
+
 
 ;; Unselect a difference by removing the ASCII flags in the buffers.
 ;; This may have to be modified for buffer C, when it will be supported.
 (defun ediff-unselect-difference (n)
   (if (ediff-valid-difference-p n)
-      (progn 
+      (progn
        (cond ((and (ediff-has-face-support-p) ediff-use-faces)
               (ediff-unhighlight-diff))
              ((eq ediff-highlighting-style 'ascii)
@@ -2751,12 +2982,11 @@ Hit \\[ediff-recenter] to reset the windows afterward."
                    ediff-ancestor-buffer
                    (ediff-get-diff-overlay n 'Ancestor)))
               ))
-       (setq ediff-highlighting-style nil)
-       
+
        ;; unhighlight fine diffs
        (ediff-set-fine-diff-properties ediff-current-difference 'default)
        (run-hooks 'ediff-unselect-hook))))
-  
+
 
 ;; Unselects prev diff and selects a new one, if FLAG has value other than
 ;; 'select-only or 'unselect-only.  If FLAG is 'select-only, the
@@ -2768,30 +2998,121 @@ Hit \\[ediff-recenter] to reset the windows afterward."
   (let ((ediff-current-difference n))
     (or no-recenter
        (ediff-recenter 'no-rehighlight)))
-         
+
   (let ((control-buf ediff-control-buffer))
-    (unwind-protect    
+    (unwind-protect
        (progn
          (or (eq flag 'select-only)
              (ediff-unselect-difference ediff-current-difference))
-         
+
          (or (eq flag 'unselect-only)
              (ediff-select-difference n))
+         ;; need to set current diff here even though it is also set in
+         ;; ediff-select-difference because ediff-select-difference might not
+         ;; be called if unselect-only is specified
          (setq ediff-current-difference n)
          ) ; end protected section
-      
-      (ediff-eval-in-buffer control-buf (ediff-refresh-mode-lines))
-      )))
+
+      (ediff-with-current-buffer control-buf (ediff-refresh-mode-lines)))
+    ))
+
+
+
+(defun ediff-highlight-diff-in-one-buffer (n buf-type)
+  (if (ediff-buffer-live-p (ediff-get-buffer buf-type))
+      (let* ((buff (ediff-get-buffer buf-type))
+            (last (ediff-with-current-buffer buff (point-max)))
+            (begin (ediff-get-diff-posn buf-type 'beg n))
+            (end (ediff-get-diff-posn buf-type 'end n))
+            (xtra (if (equal begin end) 1 0))
+            (end-hilit (min last (+ end xtra)))
+            (current-diff-overlay
+             (symbol-value
+              (ediff-get-symbol-from-alist
+               buf-type ediff-current-diff-overlay-alist))))
+
+       (if ediff-xemacs-p
+           (ediff-move-overlay current-diff-overlay begin end-hilit)
+         (ediff-move-overlay current-diff-overlay begin end-hilit buff))
+       (ediff-overlay-put current-diff-overlay 'priority
+                          (ediff-highest-priority begin end-hilit buff))
+       (ediff-overlay-put current-diff-overlay 'ediff-diff-num n)
+
+       ;; unhighlight the background overlay for diff n so it won't
+       ;; interfere with the current diff overlay
+       (ediff-set-overlay-face (ediff-get-diff-overlay n buf-type) nil)
+       )))
+
+
+(defun ediff-unhighlight-diff-in-one-buffer (buf-type)
+  (if (ediff-buffer-live-p (ediff-get-buffer buf-type))
+      (let ((current-diff-overlay
+            (symbol-value
+             (ediff-get-symbol-from-alist
+              buf-type ediff-current-diff-overlay-alist)))
+           (overlay
+            (ediff-get-diff-overlay ediff-current-difference buf-type))
+           )
+
+       (ediff-move-overlay current-diff-overlay 1 1)
+
+       ;; rehighlight the overlay in the background of the
+       ;; current difference region
+       (ediff-set-overlay-face
+        overlay
+        (if (and (ediff-has-face-support-p)
+                 ediff-use-faces ediff-highlight-all-diffs)
+            (ediff-background-face buf-type ediff-current-difference)))
+       )))
+
+(defun ediff-unhighlight-diffs-totally-in-one-buffer (buf-type)
+  (ediff-unselect-and-select-difference -1)
+  (if (and (ediff-has-face-support-p) ediff-use-faces)
+      (let* ((inhibit-quit t)
+            (current-diff-overlay-var
+             (ediff-get-symbol-from-alist
+              buf-type ediff-current-diff-overlay-alist))
+            (current-diff-overlay (symbol-value current-diff-overlay-var)))
+       (ediff-paint-background-regions 'unhighlight)
+       (if (ediff-overlayp current-diff-overlay)
+           (ediff-delete-overlay current-diff-overlay))
+       (set current-diff-overlay-var nil)
+       )))
+
+
+(defun ediff-highlight-diff (n)
+  "Put face on diff N.  Invoked for X displays only."
+  (ediff-highlight-diff-in-one-buffer n 'A)
+  (ediff-highlight-diff-in-one-buffer n 'B)
+  (ediff-highlight-diff-in-one-buffer n 'C)
+  (ediff-highlight-diff-in-one-buffer n 'Ancestor)
+  )
 
 
-(defun ediff-read-file-name (prompt default-dir default-file)
-; This is a modified version of a similar function in `emerge.el'.
-; PROMPT should not have trailing ': ', so that it can be modified
-; according to context.
-; If default-file is set, it should be used as the default value.
-; If default-dir is non-nil, use it as the default directory.
-; Otherwise, use the value of Emacs' variable `default-directory.'
+(defun ediff-unhighlight-diff ()
+  "Remove overlays from buffers A, B, and C."
+  (ediff-unhighlight-diff-in-one-buffer 'A)
+  (ediff-unhighlight-diff-in-one-buffer 'B)
+  (ediff-unhighlight-diff-in-one-buffer 'C)
+  (ediff-unhighlight-diff-in-one-buffer 'Ancestor)
+  )
 
+;; delete highlighting overlays, restore faces to their original form
+(defun ediff-unhighlight-diffs-totally ()
+  (ediff-unhighlight-diffs-totally-in-one-buffer 'A)
+  (ediff-unhighlight-diffs-totally-in-one-buffer 'B)
+  (ediff-unhighlight-diffs-totally-in-one-buffer 'C)
+  (ediff-unhighlight-diffs-totally-in-one-buffer 'Ancestor)
+  )
+
+
+;; This is adapted from a similar function in `emerge.el'.
+;; PROMPT should not have a trailing ': ', so that it can be modified
+;; according to context.
+;; If DEFAULT-FILE is set, it should be used as the default value.
+;; If DEFAULT-DIR is non-nil, use it as the default directory.
+;; Otherwise, use the value of Emacs' variable `default-directory.'
+(defun ediff-read-file-name (prompt default-dir default-file &optional no-dirs)
   ;; hack default-dir if it is not set
   (setq default-dir
        (file-name-as-directory
@@ -2822,53 +3143,90 @@ Hit \\[ediff-recenter] to reset the windows afterward."
              )
             default-dir
             ))
-    ;; If user enters a directory name, expand the default file in that
+    ;; If user entered a directory name, expand the default file in that
     ;; directory.  This allows the user to enter a directory name for the
     ;; B-file and diff against the default-file in that directory instead
     ;; of a DIRED listing!
     (if (and (file-directory-p f) default-file)
        (setq f (expand-file-name
                 (file-name-nondirectory default-file) f)))
-    f)) 
-  
+    (if (and no-dirs (file-directory-p f))
+       (error "File %s is a directory" f))
+    f))
+
 ;; If PREFIX is given, then it is used as a prefix for the temp file
-;; name. Otherwise, `ediff_' is used. If FILE is given, use this
+;; name.  Otherwise, `ediff' is used.  If FILE is given, use this
 ;; file and don't create a new one.
-;; On MS-DOS, make sure the prefix isn't longer than 7 characters, or
-;; else `make-temp-name' isn't guaranteed to return a unique filename.
+;; In MS-DOS, make sure the prefix isn't too long, or else
+;; `make-temp-name' isn't guaranteed to return a unique filename.
 ;; Also, save buffer from START to END in the file.
 ;; START defaults to (point-min), END to (point-max)
 (defun ediff-make-temp-file (buff &optional prefix given-file start end)
-  (let ((p (or prefix "ediff"))
-       f)
-    (if (and (eq system-type 'ms-dos) (> (length p) 7))
-       (setq p (substring p 0 7)))
+  (let* ((p (ediff-convert-standard-filename (or prefix "ediff")))
+        (short-p p)
+        (coding-system-for-write ediff-coding-system-for-write)
+        f short-f)
+    (if (and (fboundp 'msdos-long-file-names)
+            (not (msdos-long-file-names))
+            (> (length p) 2))
+       (setq short-p (substring p 0 2)))
 
     (setq f (concat ediff-temp-file-prefix p)
-         f (cond (given-file)
-                 ((find-file-name-handler f 'find-file-noselect)
+         short-f (concat ediff-temp-file-prefix short-p)
+         f (cond (given-file)
+                 ((find-file-name-handler f 'insert-file-contents)
                   ;; to thwart file handlers in write-region, e.g., if file
                   ;; name ends with .Z or .gz
                   ;; This is needed so that patches produced by ediff will
                   ;; have more meaningful names
-                  (make-temp-name f))
-                 ;; Prefix is most often the same as the file name for the
-                 ;; variant. Here we are trying to use the original file name
-                 ;; but in the temp directory.
-                 ((and prefix (not (file-exists-p f))) f)
-                 ;; If a file with the orig name exists, add some random stuff
-                 ;; to it.
-                 (t (make-temp-name f))))
-    
+                  (ediff-make-empty-tmp-file short-f))
+                 (prefix
+                  ;; Prefix is most often the same as the file name for the
+                  ;; variant.  Here we are trying to use the original file
+                  ;; name but in the temp directory.
+                  (ediff-make-empty-tmp-file f 'keep-name))
+                 (t
+                  ;; If don't care about name, add some random stuff
+                  ;; to proposed file name.
+                  (ediff-make-empty-tmp-file short-f))))
+
     ;; create the file
-    (ediff-eval-in-buffer buff
+    (ediff-with-current-buffer buff
       (write-region (if start start (point-min))
                    (if end end (point-max))
                    f
                    nil          ; don't append---erase
-                   'no-message) 
+                   'no-message)
       (set-file-modes f ediff-temp-file-mode)
-      (ediff-convert-standard-filename (expand-file-name f)))))
+      (expand-file-name f))))
+
+;; Create a temporary file.
+;; The returned file name (created by appending some random characters at the
+;; end of PROPOSED-NAME is guaranteed to point to a newly created empty file.
+;; This is a replacement for make-temp-name, which eliminates a security hole.
+;; If KEEP-PROPOSED-NAME isn't nil, try to keep PROPOSED-NAME, unless such file
+;; already exists.
+;; It is a modified version of make-temp-file in emacs 20.5
+(defun ediff-make-empty-tmp-file (proposed-name &optional keep-proposed-name)
+  (let ((file proposed-name))
+    (while (condition-case ()
+               (progn
+                (if (or (file-exists-p file) (not keep-proposed-name))
+                    (setq file (make-temp-name proposed-name)))
+                ;; the with-temp-buffer thing is a workaround for an XEmacs
+                ;; bug: write-region complains that we are trying to visit a
+                ;; file in an indirect buffer, failing to notice that the
+                ;; VISIT flag is unset and that we are actually writing from a
+                ;; string and not from any buffer.
+                (with-temp-buffer
+                  (write-region "" nil file nil 'silent nil 'excl))
+                 nil)
+            (file-already-exists t))
+      ;; the file was somehow created by someone else between
+      ;; `make-temp-name' and `write-region', let's try again.
+      nil)
+    file))
+
 
 ;; Quote metacharacters (using \) when executing diff in Unix, but not in
 ;; EMX OS/2
@@ -2893,8 +3251,9 @@ Hit \\[ediff-recenter] to reset the windows afterward."
   (if (verify-visited-file-modtime (current-buffer))
       (if (buffer-modified-p)
          ;; If buffer is not obsolete and is modified, offer to save
-         (if (yes-or-no-p 
-              (format "Buffer out of sync with visited file. Save file %s? "
+         (if (yes-or-no-p
+              (format "Buffer %s has been modified. Save it in file %s? "
+                      (buffer-name)
                       buffer-file-name))
              (condition-case nil
                  (save-buffer)
@@ -2906,7 +3265,9 @@ Hit \\[ediff-recenter] to reset the windows afterward."
        nil)
     ;; If buffer is obsolete, offer to revert
     (if (yes-or-no-p
-        (format "Buffer is out of sync with visited file. REVERT file %s? "
+        (format "File %s was modified since visited by buffer %s.  REVERT file %s? "
+                buffer-file-name
+                (buffer-name)
                 buffer-file-name))
        (progn
          (if file-magic
@@ -2914,6 +3275,34 @@ Hit \\[ediff-recenter] to reset the windows afterward."
          (revert-buffer t t))
       (error "Buffer out of sync for file %s" buffer-file-name))))
 
+;; if there is another buffer visiting the file of the merge buffer, offer to
+;; save and delete the buffer; else bark
+(defun ediff-verify-file-merge-buffer (file)
+  (let ((buff (if (stringp file) (find-buffer-visiting file)))
+       warn-message)
+    (or (null buff)
+       (progn
+         (setq warn-message
+               (format "Buffer %s is visiting %s. Save and kill the buffer? "
+                       (buffer-name buff) file))
+         (with-output-to-temp-buffer ediff-msg-buffer
+           (princ "\n\n")
+           (princ warn-message)
+           (princ "\n\n"))
+         (if (y-or-n-p
+              (message "%s" warn-message))
+             (with-current-buffer buff
+               (save-buffer)
+               (kill-buffer (current-buffer)))
+           (error "Too dangerous to merge versions of a file visited by another buffer"))))
+    ))
+
+
+
+(defun ediff-filename-magic-p (file)
+  (or (ediff-file-compressed-p file)
+      (ediff-file-remote-p file)))
+
 
 (defun ediff-save-buffer (arg)
   "Safe way of saving buffers A, B, C, and the diff output.
@@ -2926,7 +3315,7 @@ Without an argument, it saves customized diff argument, if available
   (interactive "P")
   (ediff-barf-if-not-control-buffer)
   (ediff-compute-custom-diffs-maybe)
-  (ediff-eval-in-buffer
+  (ediff-with-current-buffer
       (cond ((memq last-command-char '(?a ?b ?c))
             (ediff-get-buffer
              (ediff-char-to-buftype last-command-char)))
@@ -2943,26 +3332,113 @@ Without an argument, it saves customized diff argument, if available
            )
     (save-buffer)))
 
+
+;; idea suggested by Hannu Koivisto <azure@iki.fi>
+(defun ediff-clone-buffer-for-region-comparison (buff region-name)
+  (let ((cloned-buff (ediff-make-cloned-buffer buff region-name))
+       (pop-up-windows t)
+       wind
+       other-wind
+       msg-buf)
+    (ediff-with-current-buffer cloned-buff
+      (setq ediff-temp-indirect-buffer t))
+    (pop-to-buffer cloned-buff)
+    (setq wind (ediff-get-visible-buffer-window cloned-buff))
+    (select-window wind)
+    (delete-other-windows)
+    (split-window-vertically)
+    (ediff-select-lowest-window)
+    (setq other-wind (selected-window))
+    (with-temp-buffer
+      (erase-buffer)
+      (insert
+       (format "\n   *******  Mark a region in buffer %s  *******\n"
+              (buffer-name cloned-buff)))
+      (insert
+       (ediff-with-current-buffer buff
+        (format "\n\t      When done, type %s       Use %s to abort\n    "
+                (ediff-format-bindings-of 'exit-recursive-edit)
+                (ediff-format-bindings-of 'abort-recursive-edit))))
+      (goto-char (point-min))
+      (setq msg-buf (current-buffer))
+      (set-window-buffer other-wind msg-buf)
+      (shrink-window-if-larger-than-buffer)
+      (if (window-live-p wind)
+         (select-window wind))
+      (condition-case nil
+         (recursive-edit)
+       (quit
+        (ediff-kill-buffer-carefully cloned-buff)))
+      )
+    cloned-buff))
+
+
+(defun ediff-clone-buffer-for-window-comparison (buff wind region-name)
+  (let ((cloned-buff (ediff-make-cloned-buffer buff region-name)))
+    (ediff-with-current-buffer cloned-buff
+      (setq ediff-temp-indirect-buffer t))
+    (set-window-buffer wind cloned-buff)
+    cloned-buff))
+
+(defun ediff-clone-buffer-for-current-diff-comparison (buff buf-type reg-name)
+  (let ((cloned-buff (ediff-make-cloned-buffer buff reg-name))
+       (reg-start (ediff-get-diff-posn buf-type 'beg))
+       (reg-end (ediff-get-diff-posn buf-type 'end)))
+    (ediff-with-current-buffer cloned-buff
+      ;; set region to be the current diff region
+      (goto-char reg-start)
+      (set-mark reg-end)
+      (setq ediff-temp-indirect-buffer t))
+    cloned-buff))
+
+
+
+(defun ediff-make-cloned-buffer (buff region-name)
+  (ediff-make-indirect-buffer
+   buff (generate-new-buffer-name
+         (concat (if (stringp buff) buff (buffer-name buff)) region-name))
+   ))
+
+
+(defun ediff-make-indirect-buffer (base-buf indirect-buf-name)
+  (ediff-cond-compile-for-xemacs-or-emacs
+   (make-indirect-buffer base-buf indirect-buf-name) ; xemacs
+   (make-indirect-buffer base-buf indirect-buf-name 'clone) ; emacs
+   ))
+
+
+;; This function operates only from an ediff control buffer
 (defun ediff-compute-custom-diffs-maybe ()
   (let ((buf-A-file-name (buffer-file-name ediff-buffer-A))
        (buf-B-file-name (buffer-file-name ediff-buffer-B))
        file-A file-B)
-    (if (stringp buf-A-file-name)
-       (setq buf-A-file-name (file-name-nondirectory buf-A-file-name)))
-    (if (stringp buf-B-file-name)
-       (setq buf-B-file-name (file-name-nondirectory buf-B-file-name)))
-    (setq file-A (ediff-make-temp-file ediff-buffer-A buf-A-file-name)
-         file-B (ediff-make-temp-file ediff-buffer-B buf-B-file-name))
-                        
+    (unless (and buf-A-file-name (file-exists-p buf-A-file-name))
+      (setq file-A
+           (ediff-make-temp-file ediff-buffer-A)))
+    (unless (and buf-B-file-name (file-exists-p buf-B-file-name))
+      (setq file-B
+           (ediff-make-temp-file ediff-buffer-B)))
     (or (ediff-buffer-live-p ediff-custom-diff-buffer)
        (setq ediff-custom-diff-buffer
              (get-buffer-create
               (ediff-unique-buffer-name "*ediff-custom-diff" "*"))))
+    (ediff-with-current-buffer ediff-custom-diff-buffer
+                              (setq buffer-read-only nil)
+                              (erase-buffer))
     (ediff-exec-process
      ediff-custom-diff-program ediff-custom-diff-buffer 'synchronize
-     ediff-custom-diff-options file-A file-B)
-    (delete-file file-A)
-    (delete-file file-B)
+     ediff-custom-diff-options
+     ;; repetition of buf-A-file-name is needed so it'll return a file
+     (or (and buf-A-file-name (file-exists-p buf-A-file-name) buf-A-file-name)
+        file-A)
+     (or (and buf-B-file-name (file-exists-p buf-B-file-name) buf-B-file-name)
+        file-B))
+    ;; put the diff file in diff-mode, if it is available
+    (if (fboundp 'diff-mode)
+       (with-current-buffer ediff-custom-diff-buffer
+         (diff-mode)))
+    (and file-A (file-exists-p file-A) (delete-file file-A))
+    (and file-B (file-exists-p file-B) (delete-file file-B))
     ))
 
 (defun ediff-show-diff-output (arg)
@@ -2983,7 +3459,7 @@ Without an argument, it saves customized diff argument, if available
                    nil))))
     (if buf
        (progn
-         (ediff-eval-in-buffer buf
+         (ediff-with-current-buffer buf
            (goto-char (point-min)))
          (switch-to-buffer buf)
          (raise-frame (selected-frame)))))
@@ -3004,12 +3480,18 @@ Ediff Control Panel to restore highlighting."
   (let ((answer "")
        (possibilities (list ?A ?B ?C))
        (zmacs-regions t)
-       (ctl-buf (current-buffer))
-       quit-now
+       use-current-diff-p
        begA begB endA endB bufA bufB)
 
+    (if (ediff-valid-difference-p ediff-current-difference)
+       (progn
+         (ediff-set-fine-diff-properties ediff-current-difference 'default)
+         (ediff-unhighlight-diff)))
+    (ediff-paint-background-regions 'unhighlight)
+
     (cond ((ediff-merge-job)
           (setq bufB ediff-buffer-C)
+          ;; ask which buffer to compare to the merge buffer
           (while (cond ((eq answer ?A)
                         (setq bufA ediff-buffer-A
                               possibilities '(?B))
@@ -3024,37 +3506,41 @@ Ediff Control Panel to restore highlighting."
                           (sit-for 2)
                           t))
             (let ((cursor-in-echo-area t))
-              (message "Which buffer to compare to the merge buffer (A/B)? ")
+              (message
+               "Which buffer to compare to the merge buffer (A or B)? ")
               (setq answer (capitalize (read-char-exclusive))))))
 
          ((ediff-3way-comparison-job)
+          ;; ask which two buffers to compare
           (while (cond ((memq answer possibilities)
                         (setq possibilities (delq answer possibilities))
                         (setq bufA
                               (eval
-                               (intern (format "ediff-buffer-%c" answer))))
+                               (ediff-get-symbol-from-alist
+                                answer ediff-buffer-alist)))
                         nil)
                        ((equal answer ""))
                        (t (beep 1)
-                          (message 
+                          (message
                            "Valid values are %s"
                            (mapconcat 'char-to-string possibilities " or "))
                           (sit-for 2)
                           t))
             (let ((cursor-in-echo-area t))
               (message "Enter the 1st buffer you want to compare (%s): "
-                       (mapconcat 'char-to-string possibilities "/"))
+                       (mapconcat 'char-to-string possibilities " or "))
               (setq answer (capitalize (read-char-exclusive)))))
           (setq answer "") ; silence error msg
           (while (cond ((memq answer possibilities)
                         (setq possibilities (delq answer possibilities))
                         (setq bufB
                               (eval
-                               (intern (format "ediff-buffer-%c" answer))))
+                               (ediff-get-symbol-from-alist
+                                answer ediff-buffer-alist)))
                         nil)
                        ((equal answer ""))
                        (t (beep 1)
-                          (message 
+                          (message
                            "Valid values are %s"
                            (mapconcat 'char-to-string possibilities " or "))
                           (sit-for 2)
@@ -3068,9 +3554,15 @@ Ediff Control Panel to restore highlighting."
                 bufB ediff-buffer-B
                 possibilities nil)))
 
-    (ediff-eval-in-buffer bufA
-      (or (mark t)
-         (error "You forgot to specify a region in buffer %s" (buffer-name)))
+    (if (and (ediff-valid-difference-p ediff-current-difference)
+            (y-or-n-p "Compare currently highlighted difference regions? "))
+       (setq use-current-diff-p t))
+
+    (setq bufA (if use-current-diff-p
+                  (ediff-clone-buffer-for-current-diff-comparison
+                   bufA 'A "-Region.A-")
+                (ediff-clone-buffer-for-region-comparison bufA "-Region.A-")))
+    (ediff-with-current-buffer bufA
       (setq begA (region-beginning)
            endA (region-end))
       (goto-char begA)
@@ -3080,9 +3572,12 @@ Ediff Control Panel to restore highlighting."
       (end-of-line)
       (or (eobp) (forward-char)) ; include the newline char
       (setq endA (point)))
-    (ediff-eval-in-buffer bufB
-      (or (mark t)
-         (error "You forgot to specify a region in buffer %s" (buffer-name)))
+
+    (setq bufB (if use-current-diff-p
+                  (ediff-clone-buffer-for-current-diff-comparison
+                   bufB 'B "-Region.B-")
+                (ediff-clone-buffer-for-region-comparison bufB "-Region.B-")))
+    (ediff-with-current-buffer bufB
       (setq begB (region-beginning)
            endB (region-end))
       (goto-char begB)
@@ -3093,70 +3588,28 @@ Ediff Control Panel to restore highlighting."
       (or (eobp) (forward-char)) ; include the newline char
       (setq endB (point)))
 
-    (ediff-unselect-and-select-difference
-     ediff-current-difference 'unselect-only)
-    (ediff-paint-background-regions 'unhighlight)
-
-    (ediff-eval-in-buffer bufA
-      (goto-char begA)
-      (set-mark endA)
-      (narrow-to-region begA endA)
-      ;; (ediff-activate-mark)
-      )
-    ;; (sit-for 0)
-    (ediff-eval-in-buffer bufB
-      (goto-char begB)
-      (set-mark endB)
-      (narrow-to-region begB endB)
-      ;; (ediff-activate-mark)
-      )
-    ;; (sit-for 0)
-    
-    ;; At this point, possibilities contains either the window char A/B/C
-    ;; that was not selected, or it is nil. We delete the window that is not
-    ;; selected.
-    (if possibilities
-       (ediff-eval-in-buffer ctl-buf
-         (let* ((wind-to-delete (eval
-                                 (intern
-                                  (format
-                                   "ediff-window-%c" (car possibilities)))))
-                (frame (window-frame wind-to-delete)))
-           (delete-window wind-to-delete)
-           (select-frame frame)
-           (balance-windows))))
-    (or (y-or-n-p 
-        "Please check regions selected for comparison. Continue? ")
-       (setq quit-now t))
-    
-    (ediff-eval-in-buffer bufA
-      (widen))
-    (ediff-eval-in-buffer bufB
-      (widen))
-    (if quit-now
-       (ediff-eval-in-buffer ctl-buf
-         (ediff-recenter)
-         (sit-for 0)
-         (error "All right. Make up your mind and come back...")))
 
     (ediff-regions-internal
      bufA begA endA bufB begB endB
-     nil                       ; setup-hook
-     'ediff-regions-linewise   ; job name
-     nil                       ; no word mode
+     nil                       ; setup-hook
+     (if use-current-diff-p    ; job name
+        'ediff-regions-wordwise
+       'ediff-regions-linewise)
+     (if use-current-diff-p    ; word mode, if diffing current diff
+        t nil)
      ;; setup param to pass to ediff-setup
      (list (cons 'ediff-split-window-function ediff-split-window-function)))
     ))
-      
-    
+
+
 
 (defun ediff-remove-flags-from-buffer (buffer overlay)
-  (ediff-eval-in-buffer buffer
+  (ediff-with-current-buffer buffer
     (let ((inhibit-read-only t))
       (if ediff-xemacs-p
          (ediff-overlay-put overlay 'begin-glyph nil)
        (ediff-overlay-put overlay 'before-string nil))
-      
+
       (if ediff-xemacs-p
          (ediff-overlay-put overlay 'end-glyph nil)
        (ediff-overlay-put overlay 'after-string nil))
@@ -3165,55 +3618,89 @@ Ediff Control Panel to restore highlighting."
 
 
 (defun ediff-place-flags-in-buffer (buf-type buffer ctl-buffer diff)
-  (ediff-eval-in-buffer buffer
+  (ediff-with-current-buffer buffer
     (ediff-place-flags-in-buffer1 buf-type ctl-buffer diff)))
 
 
 (defun ediff-place-flags-in-buffer1 (buf-type ctl-buffer diff-no)
-  (let* ((curr-overl (ediff-eval-in-buffer ctl-buffer
+  (let* ((curr-overl (ediff-with-current-buffer ctl-buffer
                       (ediff-get-diff-overlay diff-no buf-type)))
         (before (ediff-get-diff-posn buf-type 'beg diff-no ctl-buffer))
         after beg-of-line flag)
-       
+
     ;; insert flag before the difference
     (goto-char before)
     (setq beg-of-line (bolp))
-    
-    (setq flag (ediff-eval-in-buffer ctl-buffer
+
+    (setq flag (ediff-with-current-buffer ctl-buffer
                 (if (eq ediff-highlighting-style 'ascii)
                     (if beg-of-line
                         ediff-before-flag-bol ediff-before-flag-mol))))
-    
+
     ;; insert the flag itself
     (if ediff-xemacs-p
        (ediff-overlay-put curr-overl 'begin-glyph flag)
       (ediff-overlay-put curr-overl 'before-string flag))
-    
+
     ;; insert the flag after the difference
     ;; `after' must be set here, after the before-flag was inserted
     (setq after (ediff-get-diff-posn buf-type 'end diff-no ctl-buffer))
     (goto-char after)
     (setq beg-of-line (bolp))
-    
-    (setq flag (ediff-eval-in-buffer ctl-buffer
+
+    (setq flag (ediff-with-current-buffer ctl-buffer
                 (if (eq ediff-highlighting-style 'ascii)
                     (if beg-of-line
                         ediff-after-flag-eol ediff-after-flag-mol))))
-    
+
     ;; insert the flag itself
     (if ediff-xemacs-p
        (ediff-overlay-put curr-overl 'end-glyph flag)
       (ediff-overlay-put curr-overl 'after-string flag))
     ))
 
-  
+
+;;; Some diff region tests
+
+;; t if diff region is empty.
+;; In case of buffer C, t also if it is not a 3way
+;; comparison job (merging jobs return t as well).
+(defun ediff-empty-diff-region-p (n buf-type)
+  (if (eq buf-type 'C)
+      (or (not ediff-3way-comparison-job)
+         (= (ediff-get-diff-posn 'C 'beg n)
+            (ediff-get-diff-posn 'C 'end n)))
+    (= (ediff-get-diff-posn buf-type 'beg n)
+       (ediff-get-diff-posn buf-type 'end n))))
+
+;; Test if diff region is white space only.
+;; If 2-way job and buf-type = C, then returns t.
+(defun ediff-whitespace-diff-region-p (n buf-type)
+  (or (and (eq buf-type 'C) (not ediff-3way-job))
+      (ediff-empty-diff-region-p n buf-type)
+      (let ((beg (ediff-get-diff-posn buf-type 'beg n))
+           (end (ediff-get-diff-posn buf-type 'end n)))
+       (ediff-with-current-buffer (ediff-get-buffer buf-type)
+         (save-excursion
+           (goto-char beg)
+           (skip-chars-forward ediff-whitespace)
+           (>= (point) end))))))
+
+
+(defun ediff-get-region-contents (n buf-type ctrl-buf &optional start end)
+  (ediff-with-current-buffer
+      (ediff-with-current-buffer ctrl-buf (ediff-get-buffer buf-type))
+    (buffer-substring
+     (or start (ediff-get-diff-posn buf-type 'beg n ctrl-buf))
+     (or end (ediff-get-diff-posn buf-type 'end n ctrl-buf)))))
+
 ;; Returns positions of difference sectors in the BUF-TYPE buffer.
-;; BUF-TYPE should be a symbol -- `A', `B', or `C'. 
+;; BUF-TYPE should be a symbol -- `A', `B', or `C'.
 ;; POS is either `beg' or `end'--it specifies whether you want the position at
 ;; the beginning of a difference or at the end.
-;; 
+;;
 ;; The optional argument N says which difference (default:
-;; `ediff-current-difference'). N is the internal difference number (1- what
+;; `ediff-current-difference').  N is the internal difference number (1- what
 ;; the user sees).  The optional argument CONTROL-BUF says
 ;; which control buffer is in effect in case it is not the current
 ;; buffer.
@@ -3222,7 +3709,7 @@ Ediff Control Panel to restore highlighting."
     (or control-buf
        (setq control-buf (current-buffer)))
 
-    (ediff-eval-in-buffer control-buf
+    (ediff-with-current-buffer control-buf
       (or n  (setq n ediff-current-difference))
       (if (or (< n 0) (>= n ediff-number-of-differences))
          (if (> ediff-number-of-differences 0)
@@ -3241,39 +3728,38 @@ Ediff Control Panel to restore highlighting."
 ;; Restore highlighting to what it should be according to ediff-use-faces,
 ;; ediff-highlighting-style, and ediff-highlight-all-diffs variables.
 (defun ediff-restore-highlighting (&optional ctl-buf)
-  (ediff-eval-in-buffer (or ctl-buf (current-buffer))
-    (if (and (ediff-has-face-support-p) 
+  (ediff-with-current-buffer (or ctl-buf (current-buffer))
+    (if (and (ediff-has-face-support-p)
             ediff-use-faces
             ediff-highlight-all-diffs)
        (ediff-paint-background-regions))
     (ediff-select-difference ediff-current-difference)))
 
 
-    
+
 ;; null out difference overlays so they won't slow down future
 ;; editing operations
 ;; VEC is either a difference vector or a fine-diff vector
 (defun ediff-clear-diff-vector (vec-var &optional fine-diffs-also)
   (if (vectorp (symbol-value vec-var))
-      (mapcar (function
-              (lambda (elt)
-                (ediff-delete-overlay 
-                 (ediff-get-diff-overlay-from-diff-record elt))
-                (if fine-diffs-also
-                    (ediff-clear-fine-diff-vector elt))
-                ))
+      (mapcar (lambda (elt)
+               (ediff-delete-overlay
+                (ediff-get-diff-overlay-from-diff-record elt))
+               (if fine-diffs-also
+                   (ediff-clear-fine-diff-vector elt))
+               )
              (symbol-value vec-var)))
   ;; allow them to be garbage collected
   (set vec-var nil))
 
-       
+
 \f
 ;;; Misc
 
-;; In Emacs, this just makes overlay. In the future, when Emacs will start
+;; In Emacs, this just makes overlay.  In the future, when Emacs will start
 ;; supporting sticky overlays, this function will make a sticky overlay.
 ;; BEG and END are expressions telling where overlay starts.
-;; If they are numbers or buffers, then all is well. Otherwise, they must
+;; If they are numbers or buffers, then all is well.  Otherwise, they must
 ;; be expressions to be evaluated in buffer BUF in order to get the overlay
 ;; bounds.
 ;; If BUFF is not a live buffer, then return nil; otherwise, return the
@@ -3281,69 +3767,166 @@ Ediff Control Panel to restore highlighting."
 (defun ediff-make-bullet-proof-overlay (beg end buff)
   (if (ediff-buffer-live-p buff)
       (let (overl)
-       (ediff-eval-in-buffer buff
+       (ediff-with-current-buffer buff
          (or (number-or-marker-p beg)
              (setq beg (eval beg)))
          (or (number-or-marker-p end)
              (setq end (eval end)))
-         (setq overl 
-               (if ediff-xemacs-p
-                   (make-extent beg end buff)
-                 ;; advance front and rear of the overlay
-                 (make-overlay beg end buff nil 'rear-advance)))
-         
+         (setq overl
+               (ediff-cond-compile-for-xemacs-or-emacs
+                (make-extent beg end buff)                     ; xemacs
+                ;; advance front and rear of the overlay
+                (make-overlay beg end buff nil 'rear-advance)  ; emacs
+                ))
+
          ;; never detach
          (ediff-overlay-put
           overl (if ediff-emacs-p 'evaporate 'detachable) nil)
-         ;; make vip-minibuffer-overlay open-ended
+         ;; make overlay open-ended
          ;; In emacs, it is made open ended at creation time
          (if ediff-xemacs-p
              (progn
-               (ediff-overlay-put overl 'start-open nil) 
+               (ediff-overlay-put overl 'start-open nil)
                (ediff-overlay-put overl 'end-open nil)))
          (ediff-overlay-put overl 'ediff-diff-num 0)
          overl))))
-         
-  
+
+
+(defun ediff-make-current-diff-overlay (type)
+  (if (ediff-has-face-support-p)
+      (let ((overlay (ediff-get-symbol-from-alist
+                     type ediff-current-diff-overlay-alist))
+           (buffer (ediff-get-buffer type))
+           (face (face-name
+                  (ediff-get-symbol-from-alist
+                   type ediff-current-diff-face-alist))))
+       (set overlay
+            (ediff-make-bullet-proof-overlay (point-max) (point-max) buffer))
+       (ediff-set-overlay-face (symbol-value overlay) face)
+       (ediff-overlay-put (symbol-value overlay) 'ediff ediff-control-buffer))
+    ))
+
+
 ;; Like other-buffer, but prefers visible buffers and ignores temporary or
 ;; other insignificant buffers (those beginning with "^[ *]").
 ;; Gets one arg--buffer name or a list of buffer names (it won't return
 ;; these buffers).
-(defun ediff-other-buffer (buff)
-  (if (not (listp buff)) (setq buff (list buff)))
-  (let* ((frame-buffers (buffer-list))
+;; EXCL-BUFF-LIST is an exclusion list.
+(defun ediff-other-buffer (excl-buff-lst)
+  (or (listp excl-buff-lst) (setq excl-buff-lst (list excl-buff-lst)))
+  (let* ((all-buffers (nconc (ediff-get-selected-buffers) (buffer-list)))
+        ;; we compute this the second time because we need to do memq on it
+        ;; later, and nconc above will break it. Either this or use slow
+        ;; append instead of nconc
+        (selected-buffers (ediff-get-selected-buffers))
+        (prefered-buffer (car all-buffers))
+        visible-dired-buffers
+        (excl-buff-name-list
+         (mapcar
+          (lambda (b) (cond ((stringp b) b)
+                            ((bufferp b) (buffer-name b))))
+          excl-buff-lst))
+        ;; if at least one buffer on the exclusion list is dired, then force
+        ;; all others to be dired. This is because this means that the user
+        ;; has already chosen a dired buffer before
+        (use-dired-major-mode
+         (cond ((null (ediff-buffer-live-p (car excl-buff-lst))) 'unknown)
+               ((eq (ediff-with-current-buffer (car excl-buff-lst) major-mode)
+                    'dired-mode)
+                'yes)
+               (t 'no)))
+        ;; significant-buffers must be visible and not belong
+        ;; to the exclusion list `buff-list'
+        ;; We also exclude temporary buffers, but keep mail and gnus buffers
+        ;; Furthermore, we exclude dired buffers, unless they are the only
+        ;; ones visible (and there are at least two of them).
+        ;; Also, any visible window not on the exclusion list that is first in
+        ;; the buffer list is chosen regardless. (This is because the user
+        ;; clicked on it or did something to distinguish it).
         (significant-buffers
          (mapcar
-          (function (lambda (x)
-                      (cond ((member (buffer-name x) buff)
-                             nil)
-                            ((not (ediff-get-visible-buffer-window x))
-                             nil)
-                            ((string-match "^ " (buffer-name x))
-                             nil)
-                            (t x))))
-          frame-buffers))
-        (buffers (delq nil significant-buffers))
+          (lambda (x)
+            (cond ((member (buffer-name x) excl-buff-name-list) nil)
+                  ((memq x selected-buffers) x)
+                  ((not (ediff-get-visible-buffer-window x)) nil)
+                  ((eq x prefered-buffer) x)
+                  ;; if prev selected buffer is dired, look only at
+                  ;; dired.
+                  ((eq use-dired-major-mode 'yes)
+                   (if (eq (ediff-with-current-buffer x major-mode)
+                           'dired-mode)
+                       x nil))
+                  ((eq (ediff-with-current-buffer x major-mode)
+                       'dired-mode)
+                   (if (null use-dired-major-mode)
+                       ;; don't know if we must enforce dired.
+                       ;; Remember this buffer in case
+                       ;; dired buffs are the only ones visible.
+                       (setq visible-dired-buffers
+                             (cons x visible-dired-buffers)))
+                   ;; skip, if dired is not forced
+                   nil)
+                  ((memq (ediff-with-current-buffer x major-mode)
+                         '(rmail-mode
+                           vm-mode
+                           gnus-article-mode
+                           mh-show-mode))
+                   x)
+                  ((string-match "^[ *]" (buffer-name x)) nil)
+                  ((string= "*scratch*" (buffer-name x)) nil)
+                  (t x)))
+          all-buffers))
+        (clean-significant-buffers (delq nil significant-buffers))
         less-significant-buffers)
-        
-    (cond (buffers (car buffers))
+
+    (if (and (null clean-significant-buffers)
+            (> (length visible-dired-buffers) 0))
+       (setq clean-significant-buffers visible-dired-buffers))
+
+    (cond (clean-significant-buffers (car clean-significant-buffers))
          ;; try also buffers that are not displayed in windows
          ((setq less-significant-buffers
                 (delq nil
                       (mapcar
-                       (function
-                        (lambda (x)
-                          (cond ((member (buffer-name x) buff) nil)
-                                ((string-match "^[ *]" (buffer-name x)) nil)
-                                (t x))))
-                       frame-buffers)))
+                       (lambda (x)
+                         (cond ((member (buffer-name x) excl-buff-name-list)
+                                nil)
+                               ((eq use-dired-major-mode 'yes)
+                                (if (eq (ediff-with-current-buffer
+                                            x major-mode)
+                                        'dired-mode)
+                                    x nil))
+                               ((eq (ediff-with-current-buffer x major-mode)
+                                    'dired-mode)
+                                nil)
+                               ((string-match "^[ *]" (buffer-name x)) nil)
+                               ((string= "*scratch*" (buffer-name x)) nil)
+                               (t x)))
+                       all-buffers)))
           (car less-significant-buffers))
-         (t (other-buffer (current-buffer))))
+         (t "*scratch*"))
     ))
-      
-      
+
+
+;; If current buffer is a Buffer-menu buffer, then take the selected buffers
+;; and append the buffer at the cursor to the end.
+;; This list would be the preferred list.
+(defun ediff-get-selected-buffers ()
+  (if (eq major-mode 'Buffer-menu-mode)
+      (let ((lis (condition-case nil
+                    (list (Buffer-menu-buffer t))
+                  (error))
+                ))
+       (save-excursion
+         (goto-char (point-max))
+         (while (search-backward "\n>" nil t)
+           (forward-char 1)
+           (setq lis (cons (Buffer-menu-buffer t) lis)))
+         lis))
+    ))
+
 ;; Construct a unique buffer name.
-;; The first one tried is prefixsuffix, then prefix<2>suffix, 
+;; The first one tried is prefixsuffix, then prefix<2>suffix,
 ;; prefix<3>suffix, etc.
 (defun ediff-unique-buffer-name (prefix suffix)
   (if (null (get-buffer (concat prefix suffix)))
@@ -3352,23 +3935,7 @@ Ediff Control Panel to restore highlighting."
       (while (get-buffer (format "%s<%d>%s" prefix n suffix))
        (setq n (1+ n)))
       (format "%s<%d>%s" prefix n suffix))))
-  
-
-;; splits at a white space, returns a list
-(defun ediff-split-string (string)
-  (let ((start 0)
-        (result '())
-       substr)
-    (while (string-match "[ \t]+" string start)
-      (let ((match (string-match "[ \t]+" string start)))
-       (setq substr (substring string start match))
-       (if (> (length substr) 0)
-           (setq result (cons substr result)))
-        (setq start (match-end 0))))
-    (setq substr (substring string start nil))
-    (if (> (length substr) 0)
-       (setq result (cons substr result)))
-    (nreverse result)))
+
 
 (defun ediff-submit-report ()
   "Submit bug report on Ediff."
@@ -3379,9 +3946,10 @@ Ediff Control Panel to restore highlighting."
        (ediff-device-type (ediff-device-type))
        varlist salutation buffer-name)
     (setq varlist '(ediff-diff-program ediff-diff-options
+                    ediff-diff3-program ediff-diff3-options
                    ediff-patch-program ediff-patch-options
                    ediff-shell
-                   ediff-use-faces 
+                   ediff-use-faces
                    ediff-auto-refine ediff-highlighting-style
                    ediff-buffer-A ediff-buffer-B ediff-control-buffer
                    ediff-forward-word-function
@@ -3397,16 +3965,16 @@ Ediff Control Panel to restore highlighting."
                    ediff-device-type
                    ))
     (setq salutation "
-Congratulations! You may have unearthed a bug in Ediff!
+Congratulations!  You may have unearthed a bug in Ediff!
 
 Please make a concise and accurate summary of what happened
 and mail it to the address above.
 -----------------------------------------------------------
 ")
-    
+
     (ediff-skip-unsuitable-frames)
     (ediff-reset-mouse)
-    
+
     (switch-to-buffer ediff-msg-buffer)
     (erase-buffer)
     (delete-other-windows)
@@ -3414,16 +3982,16 @@ and mail it to the address above.
 Please read this first:
 ----------------------
 
-Some ``bugs'' may actually be no bugs at all. For instance, if you are
+Some ``bugs'' may actually be no bugs at all.  For instance, if you are
 reporting that certain difference regions are not matched as you think they
 should, this is most likely due to the way Unix diff program decides what
-constitutes a difference region. Ediff is an Emacs interface to diff, and
+constitutes a difference region.  Ediff is an Emacs interface to diff, and
 it has nothing to do with those decisions---it only takes the output from
 diff and presents it in a way that is better suited for human browsing and
 manipulation.
 
 If Emacs happens to dump core, this is NOT an Ediff problem---it is
-an Emacs bug. Report this to Emacs maintainers.
+an Emacs bug.  Report this to Emacs maintainers.
 
 Another popular topic for reports is compilation messages.  Because Ediff
 interfaces to several other packages and runs under Emacs and XEmacs,
@@ -3433,7 +4001,7 @@ byte-compilation may produce output like this:
         ** reference to free variable pm-color-alist
           ........................
        While compiling the end of the data:
-        ** The following functions are not known to be defined: 
+        ** The following functions are not known to be defined:
           ediff-valid-color-p, ediff-set-face,
           ........................
 
@@ -3443,39 +4011,60 @@ Please do not report those and similar things.  However, comments and
 suggestions are always welcome.
 
 Mail anyway? (y or n) ")
-      
+
     (if (y-or-n-p "Mail anyway? ")
        (progn
          (if (ediff-buffer-live-p ctl-buf)
              (set-buffer ctl-buf))
          (setq buffer-name (buffer-name))
          (require 'reporter)
-         (reporter-submit-bug-report "kifer@cs.sunysb.edu"
+         (reporter-submit-bug-report "kifer@cs.stonybrook.edu"
                                      (ediff-version)
                                      varlist
-                                     nil 
+                                     nil
                                      'delete-other-windows
                                      salutation))
       (bury-buffer)
       (beep 1)(message "Bug report aborted")
       (if (ediff-buffer-live-p ctl-buf)
-         (ediff-eval-in-buffer ctl-buf
+         (ediff-with-current-buffer ctl-buf
            (ediff-recenter 'no-rehighlight))))
     ))
-                            
-       
+
+
+;; Find an appropriate syntax table for everyone to use
+;; If buffer B is not fundamental or text mode, use its syntax table
+;; Otherwise, use buffer B's.
+;; The syntax mode is used in ediff-forward-word-function
+;; The important thing is that every buffer should use the same syntax table
+;; during the refinement operation
+(defun ediff-choose-syntax-table ()
+  (setq ediff-syntax-table
+       (ediff-with-current-buffer ediff-buffer-A
+         (if (not (memq major-mode
+                        '(fundamental-mode text-mode indented-text-mode)))
+             (syntax-table))))
+  (if (not ediff-syntax-table)
+      (setq ediff-syntax-table
+           (ediff-with-current-buffer ediff-buffer-B
+             (syntax-table))))
+  )
+
+
 (defun ediff-deactivate-mark ()
-  (if ediff-xemacs-p
-         (zmacs-deactivate-region)
-       (deactivate-mark)))
+  (ediff-cond-compile-for-xemacs-or-emacs
+   (zmacs-deactivate-region) ; xemacs
+   (deactivate-mark) ; emacs
+   ))
 (defun ediff-activate-mark ()
-  (if ediff-emacs-p
-      (setq mark-active t)
-    (zmacs-activate-region)))
+  (ediff-cond-compile-for-xemacs-or-emacs
+   (zmacs-activate-region) ; xemacs
+   (setq mark-active t) ; emacs
+   ))
 
 (cond ((fboundp 'nuke-selective-display)
-       ;; XEmacs 19.12 has nuke-selective-display
-       (fset 'ediff-nuke-selective-display 'nuke-selective-display))
+       ;; XEmacs has nuke-selective-display
+       (defalias 'ediff-nuke-selective-display 'nuke-selective-display))
       (t
        (defun ediff-nuke-selective-display ()
         (save-excursion
@@ -3496,12 +4085,12 @@ Mail anyway? (y or n) ")
               (setq selective-display nil)))))
        ))
 
-        
+
 ;; The next two are modified versions from emerge.el.
 ;; VARS must be a list of symbols
 ;; ediff-save-variables returns an association list: ((var . val) ...)
 (defsubst ediff-save-variables (vars)
-  (mapcar (function (lambda (v) (cons v (symbol-value v))))
+  (mapcar (lambda (v) (cons v (symbol-value v)))
          vars))
 ;; VARS is a list of variable symbols.
 (defun ediff-restore-variables (vars assoc-list)
@@ -3511,29 +4100,29 @@ Mail anyway? (y or n) ")
 
 (defun ediff-change-saved-variable (var value buf-type)
   (let* ((assoc-list
-         (symbol-value (intern
-                        (concat "ediff-buffer-values-orig-"
-                                (symbol-name buf-type)))))
+         (symbol-value (ediff-get-symbol-from-alist
+                        buf-type
+                        ediff-buffer-values-orig-alist)))
         (assoc-elt (assoc var assoc-list)))
   (if assoc-elt
       (setcdr assoc-elt value))))
-  
-  
+
+
 ;; must execute in control buf
 (defun ediff-save-protected-variables ()
   (setq ediff-buffer-values-orig-A
-       (ediff-eval-in-buffer ediff-buffer-A
+       (ediff-with-current-buffer ediff-buffer-A
          (ediff-save-variables ediff-protected-variables)))
   (setq ediff-buffer-values-orig-B
-       (ediff-eval-in-buffer ediff-buffer-B
+       (ediff-with-current-buffer ediff-buffer-B
          (ediff-save-variables ediff-protected-variables)))
   (if ediff-3way-comparison-job
       (setq ediff-buffer-values-orig-C
-           (ediff-eval-in-buffer ediff-buffer-C
+           (ediff-with-current-buffer ediff-buffer-C
              (ediff-save-variables ediff-protected-variables))))
   (if (ediff-buffer-live-p ediff-ancestor-buffer)
       (setq ediff-buffer-values-orig-Ancestor
-           (ediff-eval-in-buffer ediff-ancestor-buffer
+           (ediff-with-current-buffer ediff-ancestor-buffer
              (ediff-save-variables ediff-protected-variables)))))
 
 ;; must execute in control buf
@@ -3542,21 +4131,21 @@ Mail anyway? (y or n) ")
        (values-B ediff-buffer-values-orig-B)
        (values-C ediff-buffer-values-orig-C)
        (values-Ancestor ediff-buffer-values-orig-Ancestor))
-    (ediff-eval-in-buffer ediff-buffer-A
+    (ediff-with-current-buffer ediff-buffer-A
       (ediff-restore-variables ediff-protected-variables values-A))
-    (ediff-eval-in-buffer ediff-buffer-B
+    (ediff-with-current-buffer ediff-buffer-B
       (ediff-restore-variables ediff-protected-variables values-B))
     (if ediff-3way-comparison-job
-       (ediff-eval-in-buffer ediff-buffer-C
+       (ediff-with-current-buffer ediff-buffer-C
          (ediff-restore-variables ediff-protected-variables values-C)))
     (if (ediff-buffer-live-p ediff-ancestor-buffer)
-       (ediff-eval-in-buffer ediff-ancestor-buffer
+       (ediff-with-current-buffer ediff-ancestor-buffer
          (ediff-restore-variables ediff-protected-variables values-Ancestor)))
     ))
 
-;; save BUFFER in FILE. used in hooks.
+;; save BUFFER in FILE.  used in hooks.
 (defun ediff-save-buffer-in-file (buffer file)
-  (ediff-eval-in-buffer buffer
+  (ediff-with-current-buffer buffer
     (write-file file)))
 
 
@@ -3578,12 +4167,17 @@ Mail anyway? (y or n) ")
 
 (defsubst ediff-save-time ()
   (setq ediff-command-begin-time (current-time)))
-    
+
 (defun ediff-profile ()
   "Toggle profiling Ediff commands."
   (interactive)
   (ediff-barf-if-not-control-buffer)
-  (make-local-hook 'post-command-hook)
+
+  (ediff-cond-compile-for-xemacs-or-emacs
+   (make-local-hook 'post-command-hook) ; xemacs form
+   nil                                  ; emacs form
+   )
+
   (let ((pre-hook 'pre-command-hook)
        (post-hook 'post-command-hook))
     (if (not (equal ediff-command-begin-time '(0 0 0)))
@@ -3591,41 +4185,42 @@ Mail anyway? (y or n) ")
               (remove-hook post-hook 'ediff-calc-command-time)
               (setq ediff-command-begin-time '(0 0 0))
               (message "Ediff profiling disabled"))
-      (add-hook pre-hook 'ediff-save-time t t)
-      (add-hook post-hook 'ediff-calc-command-time nil t)
+      (add-hook pre-hook 'ediff-save-time t 'local)
+      (add-hook post-hook 'ediff-calc-command-time nil 'local)
       (message "Ediff profiling enabled"))))
-    
+
 (defun ediff-print-diff-vector (diff-vector-var)
   (princ (format "\n*** %S ***\n" diff-vector-var))
-  (mapcar (function
-          (lambda (overl-vec)
-            (princ
-             (format
-              "Diff %d: \tOverlay:    %S
+  (mapcar (lambda (overl-vec)
+           (princ
+            (format
+             "Diff %d: \tOverlay:    %S
 \t\tFine diffs: %s
 \t\tNo-fine-diff-flag: %S
 \t\tState-of-diff:\t   %S
 \t\tState-of-merge:\t   %S
-" 
-              (1+ (ediff-overlay-get (aref overl-vec 0) 'ediff-diff-num))
-              (aref overl-vec 0)
-              ;; fine-diff-vector
-              (if (= (length (aref overl-vec 1)) 0)
-                  "none\n"
-                (mapconcat 'prin1-to-string
-                           (aref overl-vec 1) "\n\t\t\t    "))
-              (aref overl-vec 2) ; no fine diff flag
-              (aref overl-vec 3) ; state-of-diff
-              (aref overl-vec 4) ; state-of-merge
-              ))))
+"
+             (1+ (ediff-overlay-get (aref overl-vec 0) 'ediff-diff-num))
+             (aref overl-vec 0)
+             ;; fine-diff-vector
+             (if (= (length (aref overl-vec 1)) 0)
+                 "none\n"
+               (mapconcat 'prin1-to-string
+                          (aref overl-vec 1) "\n\t\t\t    "))
+             (aref overl-vec 2) ; no fine diff flag
+             (aref overl-vec 3) ; state-of-diff
+             (aref overl-vec 4) ; state-of-merge
+             )))
          (eval diff-vector-var)))
 
-  
+
 
 (defun ediff-debug-info ()
   (interactive)
   (ediff-barf-if-not-control-buffer)
   (with-output-to-temp-buffer ediff-debug-buffer
+    (ediff-with-current-buffer standard-output
+      (fundamental-mode))
     (princ (format "\nCtl buffer: %S\n" ediff-control-buffer))
     (ediff-print-diff-vector (intern "ediff-difference-vector-A"))
     (ediff-print-diff-vector (intern "ediff-difference-vector-B"))
@@ -3642,6 +4237,16 @@ Mail anyway? (y or n) ")
     (setq lis (cdr lis)))
   lis)
 
+;; Make a readable representation of the invocation sequence for FUNC-DEF.
+;; It would either be a key or M-x something.
+(defun ediff-format-bindings-of (func-def)
+  (let ((desc (car (where-is-internal func-def
+                                     overriding-local-map
+                                     nil nil))))
+    (if desc
+       (key-description desc)
+      (format "M-x %s" func-def))))
+
 ;; this uses comparison-func to decide who is a member, and this determines how
 ;; intersection looks like
 (defun ediff-intersection (lis1 lis2 comparison-func)
@@ -3651,7 +4256,7 @@ Mail anyway? (y or n) ")
          (nconc result (list (car lis1))))
       (setq lis1 (cdr lis1)))
     (cdr result)))
-    
+
 
 ;; eliminates duplicates using comparison-func
 (defun ediff-union (lis1 lis2 comparison-func)
@@ -3676,30 +4281,35 @@ Mail anyway? (y or n) ")
       (setq lis1 (cdr lis1)))
     (cdr result)))
 
-(defun ediff-copy-list (list)
-  (if (consp list)
+(if (fboundp 'copy-sequence)
+    (defalias 'ediff-copy-list 'copy-sequence)
+  (defun ediff-copy-list (list)
+    (if (consp list)
       ;;;(let ((res nil))
       ;;;  (while (consp list) (push (pop list) res))
       ;;;  (prog1 (nreverse res) (setcdr res list)))
-      (let (res elt)
-       (while (consp list)
-         (setq elt (car list)
-               res (cons elt res)
-               list (cdr list)))
-       (nreverse res))
-    (car list)))
-    
+       (let (res elt)
+         (while (consp list)
+           (setq elt (car list)
+                 res (cons elt res)
+                 list (cdr list)))
+         (nreverse res))
+      (car list))))
+
 
 ;; don't report error if version control package wasn't found
 ;;(ediff-load-version-control 'silent)
 
 (run-hooks 'ediff-load-hook)
-    
+
+(provide 'ediff-util)
+
 
 ;;; Local Variables:
 ;;; eval: (put 'ediff-defvar-local 'lisp-indent-hook 'defun)
-;;; eval: (put 'ediff-eval-in-buffer 'lisp-indent-hook 1)
-;;; eval: (put 'ediff-eval-in-buffer 'edebug-form-spec '(form body))
+;;; eval: (put 'ediff-with-current-buffer 'lisp-indent-hook 1)
+;;; eval: (put 'ediff-with-current-buffer 'edebug-form-spec '(form body))
 ;;; End:
 
+;;; arch-tag: f51099b6-ef4b-470f-88a1-3a0e0b03a879
 ;;; ediff-util.el ends here