X-Git-Url: https://code.delx.au/gnu-emacs/blobdiff_plain/a773ed9ac83b950cb2a934e9d54e1880f44bd350..41d48a42df6ce4e5af9543f97313e256f16aa900:/src/ChangeLog diff --git a/src/ChangeLog b/src/ChangeLog index 6e3a82c7c1..ab90682aa6 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,303 @@ +2013-07-16 Paul Eggert + + Fix bug where Emacs tries to close a file twice (Bug#14839). + * fileio.c (close_file_unwind): Don't close if FD is negative; + this can happen when unwinding a zapped file descriptor. + (Finsert_file_contents): Unwind-protect the fd before the point marker, + in case Emacs runs out of memory between the two unwind-protects. + Don't trash errno when closing FD. + Zap the FD in the specpdl when closing it, instead of deferring + the removal of the unwind-protect; this fixes a bug where a child + function unwinds the stack past us. + + New unwind-protect flavors to better type-check C callbacks. + This also lessens the need to write wrappers for callbacks, + and the need for make_save_pointer. + * alloca.c (free_save_value): + * atimer.c (run_all_atimers): + Now extern. + * alloc.c (safe_alloca_unwind): + * atimer.c (unwind_stop_other_atimers): + * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]: + * menu.c (cleanup_popup_menu) [HAVE_NS]: + * minibuf.c (choose_minibuf_frame_1): + * process.c (make_serial_process_unwind): + * xdisp.h (pop_message_unwind): + * xselect.c (queue_selection_requests_unwind): + Remove no-longer-needed wrapper. All uses replaced by the wrappee. + * alloca.c (record_xmalloc): + Prefer record_unwind_protect_ptr to record_unwind_protect with + make_save_pointer. + * alloca.c (Fgarbage_collect): + Prefer record_unwind_protect_void to passing a dummy. + * buffer.c (restore_buffer): + * window.c (restore_window_configuration): + * xfns.c, w32fns.c (do_unwind_create_frame) + New wrapper. All record-unwind uses of wrappee changed. + * buffer.c (set_buffer_if_live): + * callproc.c (call_process_cleanup, delete_temp_file): + * coding.c (code_conversion_restore): + * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]: + * editfns.c (save_excursion_restore) + (subst_char_in_region_unwind, subst_char_in_region_unwind_1) + (save_restriction_restore): + * eval.c (restore_stack_limits, un_autoload): + * fns.c (require_unwind): + * keyboard.c (recursive_edit_unwind, tracking_off): + * lread.c (record_load_unwind, load_warn_old_style_backquotes): + * macros.c (pop_kbd_macro, restore_menu_items): + * nsfns.m (unwind_create_frame): + * print.c (print_unwind): + * process.c (start_process_unwind): + * search.c (unwind_set_match_data): + * window.c (select_window_norecord, select_frame_norecord): + * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line) + (fast_set_selected_frame): + * xfns.c, w32fns.c (unwind_create_tip_frame): + Return void, not a dummy Lisp_Object. All uses changed. + * buffer.h (set_buffer_if_live): Move decl here from lisp.h. + * callproc.c (call_process_kill): + * fileio.c (restore_point_unwind, decide_coding_unwind) + (build_annotations_unwind): + * insdel.c (Fcombine_after_change_execute_1): + * keyboard.c (read_char_help_form_unwind): + * menu.c (unuse_menu_items): + * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind): + * sound.c (sound_cleanup): + * xdisp.c (unwind_redisplay): + * xfns.c (clean_up_dialog): + * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind): + Accept no args and return void, instead of accepting and returning + a dummy Lisp_Object. All uses changed. + * cygw32.c (fchdir_unwind): + * fileio.c (close_file_unwind): + * keyboard.c (restore_kboard_configuration): + * lread.c (readevalllop_1): + * process.c (wait_reading_process_output_unwind): + Accept int and return void, rather than accepting an Emacs integer + and returning a dummy object. In some cases this fixes an + unlikely bug when the corresponding int is outside Emacs integer + range. All uses changed. + * dired.c (directory_files_internal_unwind): + * fileio.c (do_auto_save_unwind): + * gtkutil.c (pop_down_dialog): + * insdel.c (reset_var_on_error): + * lread.c (load_unwind): + * xfns.c (clean_up_file_dialog): + * xmenu.c, nsmenu.m (pop_down_menu): + * xmenu.c (cleanup_widget_value_tree): + * xselect.c (wait_for_property_change_unwind): + Accept pointer and return void, rather than accepting an Emacs + save value encapsulating the pointer and returning a dummy object. + All uses changed. + * editfns.c (Fformat): Update the saved pointer directly via + set_unwind_protect_ptr rather than indirectly via make_save_pointer. + * eval.c (specpdl_func): Remove. All uses replaced by definiens. + (unwind_body): New function. + (record_unwind_protect): First arg is now a function returning void, + not a dummy Lisp_Object. + (record_unwind_protect_ptr, record_unwind_protect_int) + (record_unwind_protect_void): New functions. + (unbind_to): Support SPECPDL_UNWIND_PTR etc. + * fileio.c (struct auto_save_unwind): New type. + (do_auto_save_unwind): Use it. + (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind. + * insdel.c (struct rvoe_arg): New type. + (reset_var_on_error): Use it. + * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID): + New constants. + (specbinding_func): Remove; there are now several such functions. + (union specbinding): New members unwind_ptr, unwind_int, unwind_void. + (set_unwind_protect_ptr): New function. + * xselect.c: Remove unnecessary forward decls, to simplify maintenance. + + Be simpler and more consistent about reporting I/O errors. + * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region): + Say "Read error" and "Write error", rather than "I/O error", or + "IO error reading", or "IO error writing", when a read or write + error occurs. + * process.c (Fmake_network_process, wait_reading_process_output) + (send_process, Fprocess_send_eof, wait_reading_process_output): + Capitalize diagnostics consistently. Put "failed foo" at the + start of the diagnostic, so that we don't capitalize the + function name "foo". Consistently say "failed" for such + diagnostics. + * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string. + All callers changed. This is so it can use report_file_error. + * sysdep.c (serial_open, serial_configure): Capitalize I/O + diagnostics consistently as above. + + * fileio.c (report_file_errno): Fix errno reporting bug. + If the file name is neither null nor a pair, package it up as a + singleton list. All callers changed, both to this function and to + report_file_error. This fixes a bug where the memory allocator + invoked by list1 set errno so that the immediately following + report_file_error reported the wrong errno value. + + Fix minor problems found by --enable-gcc-warnings. + * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value. + * keyboard.c (kbd_buffer_get_event): Remove unused local. + +2013-07-16 Jan Djärv + + * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT. + Set event->arg to Qt if switch-event shall be generated. + Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame. + + * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT. + + * nsterm.m (windowDidResignKey): If this is the focused frame, generate + FOCUS_OUT_EVENT. + + * keyboard.c (Qfocus_in, Qfocus_out): New static objects. + (make_lispy_focus_in, make_lispy_focus_out): Declare and define. + (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no + switch frame event is made. Check ! NILP (event->arg) if X11 (moved + from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11 + and there is a focused frame. + (head_table): Add focus-in and focus-out. + (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map, + bind to handle-focus-in/out. + + * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions. + (Fhandle_switch_frame): Call Fhandle_focus_in. + (syms_of_frame): defsubr handle-focus-in/out. + +2013-07-16 Paul Eggert + + Fix porting bug to older POSIXish platforms (Bug#14862). + * sysdep.c (emacs_pipe): New function, that implements + pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC. + This should port better to CentOS 5 and to Mac OS X 10.6. + All calls to pipe2 changed. + + Prefer list1 (X) to Fcons (X, Qnil) when building lists. + This makes the code easier to read and the executable a bit smaller. + Do not replace all calls to Fcons that happen to create lists, + just calls that are intended to create lists. For example, when + creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil)) + rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil). + Similarly for list2 through list5. + * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): + * bytecode.c (exec_byte_code): + * callint.c (quotify_arg, Fcall_interactively): + * callproc.c (Fcall_process, create_temp_file): + * charset.c (load_charset_map_from_file) + (Fdefine_charset_internal, init_charset): + * coding.c (get_translation_table, detect_coding_system) + (Fcheck_coding_systems_region) + (Fset_terminal_coding_system_internal) + (Fdefine_coding_system_internal, Fdefine_coding_system_alias): + * composite.c (update_compositions, Ffind_composition_internal): + * dired.c (directory_files_internal, file_name_completion) + (Fsystem_users): + * dispnew.c (Fopen_termscript, bitch_at_user, init_display): + * doc.c (Fsnarf_documentation): + * editfns.c (Fmessage_box): + * emacs.c (main): + * eval.c (do_debug_on_call, signal_error, maybe_call_debugger) + (Feval, eval_sub, Ffuncall, apply_lambda): + * fileio.c (make_temp_name, Fcopy_file, Faccess_file) + (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes) + (Fset_file_times, Finsert_file_contents) + (Fchoose_write_coding_system, Fwrite_region): + * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns): + * font.c (font_registry_charsets, font_parse_fcname) + (font_prepare_cache, font_update_drivers, Flist_fonts): + * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset): + * frame.c (make_frame, Fmake_terminal_frame) + (x_set_frame_parameters, x_report_frame_params) + (x_default_parameter, Fx_parse_geometry): + * ftfont.c (syms_of_ftfont): + * image.c (gif_load): + * keyboard.c (command_loop_1): + * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1) + (Fcopy_keymap, append_key, Fcurrent_active_maps) + (Fminor_mode_key_binding, accessible_keymaps_1) + (Faccessible_keymaps, Fwhere_is_internal): + * lread.c (read_emacs_mule_char): + * menu.c (find_and_return_menu_selection): + * minibuf.c (get_minibuffer): + * nsfns.m (Fns_perform_service): + * nsfont.m (ns_script_to_charset): + * nsmenu.m (ns_popup_dialog): + * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard) + (Fx_own_selection_internal): + * nsterm.m (append2): + * print.c (Fredirect_debugging_output) + (print_prune_string_charset): + * process.c (Fdelete_process, Fprocess_contact) + (Fformat_network_address, set_socket_option) + (read_and_dispose_of_process_output, write_queue_push) + (send_process, exec_sentinel): + * sound.c (Fplay_sound_internal): + * textprop.c (validate_plist, add_properties) + (Fput_text_property, Fadd_face_text_property) + (copy_text_properties, text_property_list, syms_of_textprop): + * unexaix.c (report_error): + * unexcoff.c (report_error): + * unexsol.c (unexec): + * xdisp.c (redisplay_tool_bar, store_mode_line_string) + (Fformat_mode_line, syms_of_xdisp): + * xfaces.c (set_font_frame_param) + (Finternal_lisp_face_attribute_values) + (Finternal_merge_in_global_face, syms_of_xfaces): + * xfns.c (x_default_scroll_bar_color_parameter) + (x_default_font_parameter, x_create_tip_frame): + * xfont.c (xfont_supported_scripts): + * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show) + (menu_help_callback, xmenu_show): + * xml.c (make_dom): + * xterm.c (set_wm_state): + Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list, + and similarly for list2 through list5. + +2013-07-15 Paul Eggert + + * callproc.c (Fcall_process_region): Fix minor race and tune. + (create_temp_file): New function, with the temp-file-creation part + of the old Fcall_process_region. Use Fcopy_sequence to create the + temp file name, rather than alloca + build_string, for simplicity. + Don't bother to block input around the temp file creation; + shouldn't be needed. Simplify use of mktemp. Use + record_unwind_protect immediately after creating the temp file; + this closes an unlikely race where the temp file was not removed. + Use memcpy rather than an open-coded loop. + (Fcall_process_region): Use the new function. If the input is + empty, redirect from /dev/null rather than from a newly created + empty temp file; this avoids unnecessary file system traffic. + +2013-07-14 Paul Eggert + + * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]: + Simplify by making this case like the other two. This is a bit + slower on obsolete hosts, but the extra complexity isn't worth it. + + * callproc.c (child_setup, relocate_fd) [!DOS_NT]: + * process.c (create_process) [!DOS_NT]: + Remove now-unnecessary calls to emacs_close. + +2013-07-13 Eli Zaretskii + + * w32term.c (x_draw_hollow_cursor): Delete the brush object when + returning early. (Bug#14850) + + * coding.c (syms_of_coding): Set up inhibit-null-byte-detection + and inhibit-iso-escape-detection attributes of 'undecided'. + (Bug#14822) + +2013-07-13 Paul Eggert + + * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h. + Reported by Herbert J. Skuhra in + . + + Don't lose top specpdl entry when memory is exhausted. + * eval.c (grow_specpdl): Increment specpdl top by 1 and check for + specpdl overflow here, to simplify callers; all callers changed. + Always reserve an unused entry at the stack top; this avoids + losing the top entry's information when memory is exhausted. + 2013-07-12 Paul Eggert Clean up errno reporting and fix some errno-reporting bugs.