X-Git-Url: https://code.delx.au/gnu-emacs/blobdiff_plain/ac5475dacb20d240db27d56199910d8a6fcc90e8..50dce3c4225384cc3705bee4f8e55939f0885f73:/test/automated/ert-tests.el

diff --git a/test/automated/ert-tests.el b/test/automated/ert-tests.el
index 181df8956f..5382c40096 100644
--- a/test/automated/ert-tests.el
+++ b/test/automated/ert-tests.el
@@ -345,10 +345,15 @@ This macro is used to test if macroexpansion in `should' works."
         (should (equal actual-condition expected-condition)))))))
 
 (ert-deftest ert-test-deftest ()
+  ;; FIXME: These tests don't look very good.  What is their intent, i.e. what
+  ;; are they really testing?  The precise generated code shouldn't matter, so
+  ;; we should either test the behavior of the code, or else try to express the
+  ;; kind of efficiency guarantees we're looking for.
   (should (equal (macroexpand '(ert-deftest abc () "foo" :tags '(bar)))
 		 '(progn
 		    (ert-set-test 'abc
 				  (progn
+				    "Constructor for objects of type `ert-test'."
 				    (vector 'cl-struct-ert-test 'abc "foo"
 					    #'(lambda nil)
 					    nil ':passed
@@ -363,6 +368,7 @@ This macro is used to test if macroexpansion in `should' works."
 		 '(progn
 		    (ert-set-test 'def
 				  (progn
+				    "Constructor for objects of type `ert-test'."
 				    (vector 'cl-struct-ert-test 'def nil
 					    #'(lambda nil)
 					    nil ':passed 'nil)))