From: Richard M. Stallman <rms@gnu.org>
Date: Fri, 21 Dec 2001 14:12:30 +0000 (+0000)
Subject: (define-minor-mode): Make no arg by default in an interactive call,
X-Git-Tag: ttn-vms-21-2-B4~17554
X-Git-Url: https://code.delx.au/gnu-emacs/commitdiff_plain/d743da264342d075295a477c9e49dd185ee654a4

(define-minor-mode): Make no arg by default in an interactive call,
so that repeating the command toggles again.
---

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4d4a74545a..7fd55a5690 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,16 +1,25 @@
+2001-12-21  Richard M. Stallman  <rms@gnu.org>
+
+	* emacs-lisp/easy-mmode.el (define-minor-mode): 
+	Make no arg by default in an interactive call,
+	so that repeating the command toggles again.
+
+	* emacs-lisp/lisp-mode.el (eval-defun-1): Cope with atoms as args.
+
 2001-12-21  Eli Zaretskii  <eliz@is.elta.co.il>
 
 	* jka-compr.el (jka-compr-partial-uncompress): Use null-device
-	instead of a literal /dev/null.  Reported by Jens Schmidt
-	<schmidt@mathematik.uni-kl.de>.
+	instead of a literal /dev/null.
+
+	* Makefile.in (distclean): Remove Makefile in the build
+	directory, not in the source directory.
+
+2001-12-21  Simon Josefsson  <jas@extundo.com>.
 
 	* mail/smtpmail.el (smtpmail-send-queued-mail): Use
 	with-temp-buffer instead of find-file-noselect, and bind
 	coding-system-for-read to no-conversion when reading the queued
-	messages.  From Simon Josefsson <jas@extundo.com>.
-
-	* Makefile.in (distclean): Remove Makefile in the build
-	directory, not in the source directory.
+	messages.
 
 2001-12-20  Werner Lemberg  <wl@gnu.org>
 
diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 0030600028..0757115ee4 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -107,7 +107,7 @@ BODY contains code that will be executed each time the mode is (dis)activated.
   (let* ((mode-name (symbol-name mode))
 	 (pretty-name (easy-mmode-pretty-mode-name mode lighter))
 	 (globalp nil)
-	 (togglep t)			;why would you ever want to toggle?
+	 (togglep t) ;; This should never be nil -- rms.
 	 (group nil)
 	 (extra-args nil)
 	 (keymap-sym (if (and keymap (symbolp keymap)) keymap
@@ -175,7 +175,9 @@ Interactively, with no prefix argument, toggle the mode.
 With universal prefix ARG " (unless togglep "(or if ARG is nil) ") "turn mode on.
 With zero or negative ARG turn mode off.
 \\{%s}") pretty-name keymap-sym))
-	 (interactive (list (or current-prefix-arg (if ,mode 0 1))))
+	 ;; Make no arg by default in an interactive call,
+	 ;; so that repeating the command toggles again.
+	 (interactive)
 	 (setq ,mode
 	       (if arg
 		   (> (prefix-numeric-value arg) 0)