From 3f042f65887672da52c6fe32b6d3254aff4be9c7 Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Thu, 26 Nov 2015 22:08:54 +0200 Subject: [PATCH] Improve commentary of prepare_to_modify_buffer_1 * src/insdel.c (prepare_to_modify_buffer_1): Mention in commentary that this function runs Lisp. Suggested by Richard Stallman . --- src/insdel.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/insdel.c b/src/insdel.c index 8b08c1e59b..bb3171b14c 100644 --- a/src/insdel.c +++ b/src/insdel.c @@ -1785,7 +1785,12 @@ run_undoable_change (void) any modification properties the text may have. If PRESERVE_PTR is nonzero, we relocate *PRESERVE_PTR - by holding its value temporarily in a marker. */ + by holding its value temporarily in a marker. + + This function runs Lisp, which means it can GC, which means it can + compact buffers, including the current buffer being worked on here. + So don't you dare calling this function while manipulating the gap, + or during some other similar "critical section". */ void prepare_to_modify_buffer_1 (ptrdiff_t start, ptrdiff_t end, -- 2.39.2