From 633bc529e2643adbcd09a211887e0b788a69e6c2 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Wed, 26 Mar 2014 11:52:34 +0200 Subject: [PATCH] introspect: Use pa_direction_valid() to validate port direction There's no behavioral change, just nicer code. --- src/pulse/introspect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pulse/introspect.c b/src/pulse/introspect.c index 2d54fdb9..d7696df4 100644 --- a/src/pulse/introspect.c +++ b/src/pulse/introspect.c @@ -25,6 +25,7 @@ #endif #include +#include #include #include @@ -823,15 +824,14 @@ static int fill_card_port_info(pa_context *context, pa_tagstruct* t, pa_card_inf pa_tagstruct_getu32(t, &port->priority) < 0 || pa_tagstruct_getu32(t, &available) < 0 || pa_tagstruct_getu8(t, &direction) < 0 || + !pa_direction_valid(direction) || pa_tagstruct_get_proplist(t, port->proplist) < 0 || pa_tagstruct_getu32(t, &port->n_profiles) < 0) { return -PA_ERR_PROTOCOL; } - if (available > PA_PORT_AVAILABLE_YES || - direction > PA_DIRECTION_OUTPUT + PA_DIRECTION_INPUT) { - + if (available > PA_PORT_AVAILABLE_YES ) { return -PA_ERR_PROTOCOL; } -- 2.39.2