From 67dc1a5a0bbafc28b9a4811b42afff491ef9fc67 Mon Sep 17 00:00:00 2001 From: Peter Meerwald Date: Wed, 18 Dec 2013 17:12:25 +0100 Subject: [PATCH] modules: Remove dead code in position-event-sounds ma is always NULL in fail path, discovered by coverity Signed-off-by: Peter Meerwald --- src/modules/module-position-event-sounds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/modules/module-position-event-sounds.c b/src/modules/module-position-event-sounds.c index 531fee7a..3bcad6ae 100644 --- a/src/modules/module-position-event-sounds.c +++ b/src/modules/module-position-event-sounds.c @@ -144,7 +144,7 @@ static pa_hook_result_t sink_input_fixate_hook_callback(pa_core *core, pa_sink_i } int pa__init(pa_module*m) { - pa_modargs *ma = NULL; + pa_modargs *ma; struct userdata *u; pa_assert(m); @@ -165,9 +165,6 @@ int pa__init(pa_module*m) { fail: pa__done(m); - if (ma) - pa_modargs_free(ma); - return -1; } -- 2.39.2