From bbed792cdf6fe823837aaa0f5dcefcf4f5ac1917 Mon Sep 17 00:00:00 2001 From: Peter Meerwald Date: Mon, 16 Dec 2013 15:54:29 +0100 Subject: [PATCH] modules: Fix resource leak in stream-restore https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8726&defectInstanceId=3724&mergedDefectId=591260 Signed-off-by: Peter Meerwald --- src/modules/module-stream-restore.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/module-stream-restore.c b/src/modules/module-stream-restore.c index 7eb79ab5..9689e79b 100644 --- a/src/modules/module-stream-restore.c +++ b/src/modules/module-stream-restore.c @@ -2119,8 +2119,10 @@ static int extension_cb(pa_native_protocol *p, pa_module *m, pa_native_connectio pa_tagstruct_get_channel_map(t, &entry->channel_map) || pa_tagstruct_get_cvolume(t, &entry->volume) < 0 || pa_tagstruct_gets(t, &device) < 0 || - pa_tagstruct_get_boolean(t, &muted) < 0) + pa_tagstruct_get_boolean(t, &muted) < 0) { + entry_free(entry); goto fail; + } if (!name || !*name) { entry_free(entry); -- 2.39.2