code.delx.au - gnu-emacs-elpa/blob - tests/parser.el

   1 ;;; tests/parser.el --- Some tests for js2-mode.
   2
   3 ;; Copyright (C) 2009, 2011-2013  Free Software Foundation, Inc.
   4
   5 ;; This file is part of GNU Emacs.
   6
   7 ;; GNU Emacs is free software: you can redistribute it and/or modify
   8 ;; it under the terms of the GNU General Public License as published by
   9 ;; the Free Software Foundation, either version 3 of the License, or
  10 ;; (at your option) any later version.
  11
  12 ;; GNU Emacs is distributed in the hope that it will be useful,
  13 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
  14 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  15 ;; GNU General Public License for more details.
  16
  17 ;; You should have received a copy of the GNU General Public License
  18 ;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
  19
  20 ;;; Code:
  21
  22 (require 'ert)
  23 (require 'ert-x)
  24 (require 'js2-mode)
  25 (require 'cl-lib)
  26
  27 (defmacro js2-deftest (name buffer-contents &rest body)
  28   (declare (indent defun))
  29   `(ert-deftest ,(intern (format "js2-%s" name)) ()
  30      (with-temp-buffer
  31        (save-excursion
  32          (insert ,buffer-contents))
  33        (unwind-protect
  34            (progn
  35              ,@body)
  36          (fundamental-mode)))))
  37
  38 (defun js2-test-string-to-ast (s)
  39   (insert s)
  40   (js2-mode)
  41   (should (null js2-mode-buffer-dirty-p))
  42   js2-mode-ast)
  43
  44 (cl-defun js2-test-parse-string (code-string &key syntax-error errors-count
  45                                              reference)
  46   (ert-with-test-buffer (:name 'origin)
  47     (let ((ast (js2-test-string-to-ast code-string)))
  48       (if syntax-error
  49           (let ((errors (js2-ast-root-errors ast)))
  50             (should (= (or errors-count 1) (length errors)))
  51             (cl-destructuring-bind (_ pos len) (car (last errors))
  52               (should (string= syntax-error (substring code-string
  53                                                        (1- pos) (+ pos len -1))))))
  54         (should (= 0 (length (js2-ast-root-errors ast))))
  55         (ert-with-test-buffer (:name 'copy)
  56           (js2-print-tree ast)
  57           (skip-chars-backward " \t\n")
  58           (should (string= (or reference code-string)
  59                            (buffer-substring-no-properties
  60                             (point-min) (point)))))))))
  61
  62 (cl-defmacro js2-deftest-parse (name code-string &key bind syntax-error errors-count
  63                                      reference)
  64   "Parse CODE-STRING.  If SYNTAX-ERROR is nil, print syntax tree
  65 with `js2-print-tree' and assert the result to be equal to
  66 REFERENCE, if present, or the original string.  If SYNTAX-ERROR
  67 is passed, expect syntax error highlighting substring equal to
  68 SYNTAX-ERROR value.  BIND defines bindings to apply them around
  69 the test."
  70   (declare (indent defun))
  71   `(ert-deftest ,(intern (format "js2-%s" name)) ()
  72      (let ,(append bind '((js2-basic-offset 2)))
  73        (js2-test-parse-string ,code-string
  74                               :syntax-error ,syntax-error
  75                               :errors-count ,errors-count
  76                               :reference ,reference))))
  77
  78 ;;; Basics
  79
  80 (js2-deftest-parse variable-assignment
  81   "a = 1;")
  82
  83 (js2-deftest-parse empty-object-literal
  84   "b = {};")
  85
  86 (js2-deftest-parse empty-array-literal
  87   "c = [];")
  88
  89 (js2-deftest-parse array-with-missing-elements
  90   "var a = [1, 2, ,];")
  91
  92 (js2-deftest-parse comma-after-regexp
  93   "d = /eee/, 42;")
  94
  95 (js2-deftest-parse return-statement
  96   "function foo() {\n  return 2;\n}")
  97
  98 (js2-deftest-parse function-statement
  99   "function foo() {\n}")
 100
 101 (js2-deftest-parse function-statement-inside-block
 102   "if (true) {\n  function foo() {\n  }\n}")
 103
 104 (js2-deftest-parse function-expression-statements-are-verboten
 105   "function() {}" :syntax-error "(")
 106
 107 (js2-deftest-parse member-expr-as-function-name
 108   "function a.b.c[2](x, y) {\n}"
 109   :bind ((js2-allow-member-expr-as-function-name t)))
 110
 111 (js2-deftest-parse named-function-expression
 112   "a = function b() {};")
 113
 114 (js2-deftest-parse parenthesized-expression
 115   "(1 + 2);")
 116
 117 (js2-deftest-parse for-with-in-operator-in-parens
 118   "for (var y = (0 in []) in {}) {\n}")
 119
 120 (js2-deftest-parse for-with-in-operator-in-cond
 121   "for (var y = 1 ? 0 in [] : false in {}) {\n}")
 122
 123 (js2-deftest-parse let-expression
 124   "(let (x = 42) x);")
 125
 126 (js2-deftest-parse let-expression-statement
 127   "let (x = 42) x;")
 128
 129 ;;; Callers of `js2-valid-prop-name-token'
 130
 131 (js2-deftest-parse parse-property-access-when-not-keyword
 132   "A.foo = 3;")
 133
 134 (js2-deftest-parse parse-property-access-when-keyword
 135   "A.in = 3;"
 136   :bind ((js2-allow-keywords-as-property-names t)))
 137
 138 (js2-deftest-parse parse-property-access-when-keyword-no-xml
 139   "A.in = 3;"
 140   :bind ((js2-allow-keywords-as-property-names t)
 141          (js2-compiler-xml-available nil)))
 142
 143 (js2-deftest-parse parse-object-literal-when-not-keyword
 144   "a = {b: 1};")
 145
 146 (js2-deftest-parse parse-object-literal-when-keyword
 147   "a = {in: 1};"
 148   :bind ((js2-allow-keywords-as-property-names t)))
 149
 150 ;;; 'of' contextual keyword
 151
 152 (js2-deftest-parse parse-legacy-array-comp-loop-with-of
 153   "[a for (a of [])];")
 154
 155 (js2-deftest-parse parse-array-comp-loop
 156   "[for (a of []) a];")
 157
 158 (js2-deftest-parse parse-for-of
 159   "for (var a of []) {\n}")
 160
 161 (js2-deftest-parse of-can-be-var-name
 162   "var of = 3;")
 163
 164 (js2-deftest-parse of-can-be-function-name
 165   "function of() {\n}")
 166
 167 ;;; Destructuring binding
 168
 169 (js2-deftest-parse destruct-in-declaration
 170   "var {a, b} = {a: 1, b: 2};")
 171
 172 (js2-deftest-parse destruct-in-arguments
 173   "function f({a: aa, b: bb}) {\n}")
 174
 175 (js2-deftest-parse destruct-in-array-comp-loop
 176   "[a + b for ([a, b] in [[0, 1], [1, 2]])];")
 177
 178 (js2-deftest-parse destruct-in-catch-clause
 179   "try {\n} catch ({a, b}) {\n  a + b;\n}")
 180
 181 ;;; Object literals
 182
 183 (js2-deftest-parse object-literal-shorthand
 184   "var x = {a: 1, b, c: 1, d};")
 185
 186 (js2-deftest-parse object-literal-shorthard-with-number
 187   "var a = {1};" :syntax-error "}" :errors-count 2)
 188
 189 (js2-deftest-parse object-literal-method
 190   "var x = {f(y) {  return y;\n}};")
 191
 192 (js2-deftest-parse object-literal-getter-method
 193   "var x = {get f() {  return 42;\n}};")
 194
 195 (js2-deftest-parse object-literal-setter-method
 196   "var x = {set f(y) {  x = y;\n}};")
 197
 198 (js2-deftest-parse object-literal-computed-keys
 199   "var x = {[Symbol.iterator]: function() {}};")
 200
 201 (js2-deftest-parse object-literal-computed-function-keys
 202   "var x = {[foo + bar](y) {  return y;\n}};")
 203
 204 (js2-deftest-parse object-literal-computed-getter-key
 205   "var x = {get [foo + bar]() {  return 42;\n}};")
 206
 207 (js2-deftest-parse object-literal-generator
 208   "var x = {*foo() {  yield 42;\n}};")
 209
 210 (js2-deftest-parse object-literal-computed-generator-key
 211   "var x = {*[foo + bar]() {  yield 42;\n}};")
 212
 213 ;;; Function definition
 214
 215 (js2-deftest function-redeclaring-var "var gen = 3; function gen() {};"
 216   (js2-mode)
 217   (should (= (length (js2-ast-root-warnings js2-mode-ast)) 1)))
 218
 219 (js2-deftest function-expression-var-same-name "var gen = function gen() {};"
 220   (js2-mode)
 221   (should (null (js2-ast-root-warnings js2-mode-ast))))
 222
 223 ;;; Function parameters
 224
 225 (js2-deftest-parse function-with-default-parameters
 226   "function foo(a = 1, b = a + 1) {\n}")
 227
 228 (js2-deftest-parse function-with-no-default-after-default
 229   "function foo(a = 1, b) {\n}"
 230   :syntax-error "b")
 231
 232 (js2-deftest-parse function-with-destruct-after-default
 233   "function foo(a = 1, {b, c}) {\n}"
 234   :syntax-error "{")
 235
 236 (js2-deftest-parse function-with-rest-parameter
 237   "function foo(a, b, ...rest) {\n}")
 238
 239 (js2-deftest-parse function-with-param-after-rest-parameter
 240   "function foo(a, ...b, rest) {\n}"
 241   :syntax-error "rest")
 242
 243 (js2-deftest-parse function-with-destruct-after-rest-parameter
 244   "function foo(a, ...b, {}) {\n}"
 245   :syntax-error "{}")
 246
 247 (js2-deftest-parse function-with-rest-after-default-parameter
 248   "function foo(a = 1, ...rest) {\n}")
 249
 250 ;;; Strict identifiers
 251
 252 (js2-deftest-parse function-bad-strict-parameters
 253   "'use strict';\nfunction foo(eval, {arguments}, bar) {\n}"
 254   :syntax-error "eval" :errors-count 2)
 255
 256 (js2-deftest-parse function-retroactive-bad-strict-parameters
 257   "function foo(arguments) {'use strict';}"
 258   :syntax-error "arguments" :errors-count 1)
 259
 260 (js2-deftest-parse function-duplicate-strict-parameters
 261   "'use strict';\nfunction foo(a, a) {\n}"
 262   :syntax-error "a" :errors-count 1)
 263
 264 (js2-deftest-parse function-bad-strict-function-name
 265   "'use strict';\nfunction eval() {\n}"
 266   :syntax-error "eval" :errors-count 1)
 267
 268 (js2-deftest-parse function-bad-retroactive-strict-function-name
 269   "function arguments() {'use strict';}"
 270   :syntax-error "arguments" :errors-count 1)
 271
 272 (js2-deftest-parse function-bad-strict-catch-name
 273   "'use strict';\ntry {} catch (eval) {}"
 274   :syntax-error "eval" :errors-count 1)
 275
 276 (js2-deftest-parse function-bad-strict-variable-name
 277   "'use strict';\nvar eval = 'kekeke';"
 278   :syntax-error "eval" :errors-count 1)
 279
 280 (js2-deftest-parse function-bad-strict-assignment
 281   "'use strict';\narguments = 'fufufu';"
 282   :syntax-error "arguments" :errors-count 1)
 283
 284 ;;; Spread operator
 285
 286 (js2-deftest-parse spread-in-array-literal
 287   "[1, ...[2, 3], 4, ...[5, 6]];")
 288
 289 (js2-deftest-parse spread-in-function-call
 290   "f(3, ...[t(2), t(3)], 42, ...[t(4)]);")
 291
 292 ;;; Arrow functions
 293
 294 (js2-deftest-parse arrow-function-with-empty-args-and-no-curlies
 295   "() => false;" :reference "() => {false};")
 296
 297 (js2-deftest-parse arrow-function-with-args-and-curlies
 298   "(a, b = 1, ...c) => {  c;\n};")
 299
 300 (js2-deftest-parse arrow-function-with-destructuring
 301   "([{a}, b]) => {  a + b;\n};")
 302
 303 (js2-deftest-parse parenless-arrow-function-prohibits-rest
 304   "...b => {b + 1;};" :syntax-error "=>")
 305
 306 (js2-deftest-parse parenless-arrow-function-prohibits-destructuring
 307   "[a, b] => {a + b;};" :syntax-error "]" :errors-count 4)
 308
 309 (js2-deftest-parse arrow-function-recovers-from-error
 310   "[(,foo) => 1];" :syntax-error "," :errors-count 6)
 311
 312 ;;; Automatic semicolon insertion
 313
 314 (js2-deftest-parse no-auto-semi-insertion-after-if
 315   "if (true) {\n}")
 316
 317 (js2-deftest-parse auto-semi-insertion-after-function
 318   "a = function() {}" :reference "a = function() {};")
 319
 320 (js2-deftest-parse auto-semi-one-variable-per-line
 321   "x\ny" :reference "x;\ny;")
 322
 323 ;;; Labels
 324
 325 (js2-deftest-parse labeled-stmt-node
 326   "foo:\nbar:\nx = y + 1;")
 327
 328 (js2-deftest no-label-node-inside-expr "x = y:"
 329   (let (js2-parse-interruptable-p)
 330     (js2-mode))
 331   (let ((assignment (js2-expr-stmt-node-expr (car (js2-scope-kids js2-mode-ast)))))
 332     (should (js2-name-node-p (js2-assign-node-right assignment)))))
 333
 334 (js2-deftest-parse label-and-loops "for (; ; ) {
 335   loop:
 336   for (; ; ) {
 337     continue loop;
 338   }
 339 }")
 340
 341 ;;; Generators
 342
 343 (js2-deftest-parse legacy-generator "function foo() {\n  yield 1;\n}")
 344
 345 (js2-deftest-parse legacy-generator-cannot-return
 346   "function foo() {\n  yield 1;\n return 2;\n}" :syntax-error "return 2")
 347
 348 (js2-deftest-parse harmony-generator "function* bar() {\n  yield 2;\n  return 3;\n}")
 349
 350 (js2-deftest-parse harmony-generator-yield-star "(function*(a) {  yield* a;\n});")
 351
 352 ;;; Comprehensions
 353
 354 (js2-deftest-parse parse-legacy-array-comp-loop-with-filter
 355   "[a for (a in b) if (a == 2)];")
 356
 357 (js2-deftest-parse parse-array-comp-loop-with-filters
 358   "[for (a in b) if (a == 2) if (b != 10) a];")
 359
 360 (js2-deftest-parse parse-generator-comp-loop-with-filters
 361   "(for (x of y) if (x != 4) x);")
 362
 363 (js2-deftest-parse parse-array-comp-with-yield-is-ok
 364   "(function() {  return [for (x of []) yield x];\n});")
 365
 366 (js2-deftest-parse parse-generator-comp-with-yield-is-not-ok
 367   "(function() {  return (for (x of []) yield x);\n});"
 368   :syntax-error "yield")
 369
 370 (js2-deftest-parse parse-generator-comp-with-yield-inside-function-is-ok
 371   "(for (x of []) function*() {  yield x;\n});")
 372
 373 ;;; Numbers
 374
 375 (js2-deftest-parse decimal-starting-with-zero "081;" :reference "81;")
 376
 377 (js2-deftest-parse huge-hex "0x0123456789abcdefABCDEF;" :reference "-1;")
 378
 379 (js2-deftest-parse octal-without-o "071;" :reference "57;")
 380
 381 (js2-deftest-parse hex-number-okay "0x123;" :reference "291;")
 382
 383 (js2-deftest-parse hex-number-broken "0xz23;"
 384   :syntax-error "0xz" :errors-count 2)
 385
 386 (js2-deftest-parse binary-number-okay "0b101;" :reference "5;")
 387
 388 (js2-deftest-parse binary-number-broken "0b210;"
 389   :syntax-error "0b2" :errors-count 2)
 390
 391 (js2-deftest-parse octal-number-okay "0o765;" :reference "501;")
 392
 393 (js2-deftest-parse octal-number-broken "0o812;"
 394   :syntax-error "0o8" :errors-count 2)
 395
 396 ;;; Modules
 397
 398 (js2-deftest parse-export-bindings "{one, two as dos}"
 399   (js2-init-scanner)
 400   (should (js2-match-token js2-LC))
 401   (let ((imports (js2-parse-export-bindings)))
 402     (should (not (equal nil imports)))
 403     (should (= 2 (length imports)))
 404     (let ((first (nth 0 imports))
 405           (second (nth 1 imports)))
 406       (should (equal "one" (js2-name-node-name (js2-export-binding-node-extern-name first))))
 407       (should (equal "two" (js2-name-node-name (js2-export-binding-node-extern-name second))))
 408       (let ((first-name (js2-export-binding-node-local-name first))
 409             (second-name (js2-export-binding-node-local-name second)))
 410         (should (equal first (js2-node-parent first-name)))
 411         (should (equal 3 (js2-node-len first-name)))
 412         (should (equal "one" (js2-name-node-name first-name)))
 413         (should (equal second (js2-node-parent second-name)))
 414         (should (equal 3 (js2-node-len second-name)))
 415         (should (equal "dos" (js2-name-node-name second-name)))))))
 416
 417 (js2-deftest parse-export-binding-as-default "one as default"
 418   (js2-init-scanner)
 419   (let ((binding (js2-maybe-parse-export-binding)))
 420     (should binding)
 421     (should (js2-export-binding-node-p binding))
 422     (let ((name (js2-export-binding-node-local-name binding)))
 423       (should name)
 424       (should (equal "default" (js2-name-node-name name))))))
 425
 426 (js2-deftest parse-namepsace-import "* as lib;"
 427   (js2-init-scanner)
 428   (should (js2-match-token js2-MUL))
 429   (let ((namespace-import (js2-parse-namespace-import)))
 430     (should (not (equal nil namespace-import)))
 431     (should (js2-namespace-import-node-p namespace-import))
 432     (should (= 1 (js2-node-pos namespace-import)))
 433     (should (equal 8 (js2-node-len namespace-import)))
 434     (let ((name-node (js2-namespace-import-node-name namespace-import)))
 435       (should (equal "lib" (js2-name-node-name name-node)))
 436       (should (= 5 (js2-node-pos name-node))))))
 437
 438 (js2-deftest parse-from-clause "from 'foo/bar';"
 439   (js2-init-scanner)
 440   (let ((from (js2-parse-from-clause)))
 441     (should (not (equal nil from)))
 442     (should (= 1 (js2-node-pos from)))
 443     (should (= 14 (js2-node-len from)))
 444     (should (equal "foo/bar" (js2-from-clause-node-module-id from)))))
 445
 446 (js2-deftest parse-import-module-id-only "import 'src/lib'"
 447   (js2-init-scanner)
 448   (should (js2-match-token js2-IMPORT))
 449   (let ((import (js2-parse-import)))
 450     (should (not (equal nil import)))
 451     (should (= 1 (js2-node-pos import)))
 452     (should (= 16 (js2-node-len import)))
 453     (should (equal nil (js2-import-node-import import)))
 454     (should (equal nil (js2-import-node-from import)))))
 455
 456 (js2-deftest parse-imported-default-binding "import theDefault from 'src/lib'"
 457   (js2-push-scope (make-js2-scope :pos 0))
 458   (js2-init-scanner)
 459   (should (js2-match-token js2-IMPORT))
 460   (let ((import-node (js2-parse-import)))
 461     (should (not (equal nil import-node)))
 462     (should (equal "src/lib" (js2-import-node-module-id import-node)))
 463     (let ((import (js2-import-node-import import-node)))
 464       (should (not (equal nil import)))
 465       (should (equal nil (js2-import-clause-node-namespace-import import)))
 466       (should (equal nil (js2-import-clause-node-named-imports import)))
 467       (let ((default (js2-import-clause-node-default-binding import)))
 468         (should (not (equal nil default)))
 469         (should (js2-export-binding-node-p default))
 470         (should (equal "theDefault" (js2-name-node-name (js2-export-binding-node-extern-name default)))))))
 471   (should (js2-scope-get-symbol js2-current-scope "theDefault")))
 472
 473 (js2-deftest parse-import-namespace-binding "import * as lib from 'src/lib'"
 474   (js2-push-scope (make-js2-scope :pos 0))
 475   (js2-init-scanner)
 476   (should (js2-match-token js2-IMPORT))
 477   (let ((import-node (js2-parse-import)))
 478     (should (not (equal nil import-node)))
 479     (should (equal "src/lib" (js2-import-node-module-id import-node)))
 480     (let ((import (js2-import-node-import import-node)))
 481       (should (not (equal nil import)))
 482       (should (equal nil (js2-import-clause-node-default-binding import)))
 483       (should (equal nil (js2-import-clause-node-named-imports import)))
 484       (let ((ns-import (js2-import-clause-node-namespace-import import)))
 485         (should (not (equal nil ns-import)))
 486         (should (js2-namespace-import-node-p ns-import))
 487         (should (equal "lib" (js2-name-node-name (js2-namespace-import-node-name ns-import)))))))
 488   (should (js2-scope-get-symbol js2-current-scope "lib")))
 489
 490 (js2-deftest parse-import-named-imports "import {foo as bar, baz} from 'src/lib'"
 491   (js2-push-scope (make-js2-scope :pos 0))
 492   (js2-init-scanner)
 493   (should (js2-match-token js2-IMPORT))
 494   (let ((import-node (js2-parse-import)))
 495     (should (not (equal nil import-node)))
 496     (should (equal "src/lib" (js2-import-node-module-id import-node)))
 497     (let ((import (js2-import-node-import import-node)))
 498       (should (not (equal nil import)))
 499       (should (equal nil (js2-import-clause-node-default-binding import)))
 500       (should (equal nil (js2-import-clause-node-namespace-import import)))
 501       (let ((named-imports (js2-import-clause-node-named-imports import)))
 502         (should (not (equal nil named-imports)))
 503         (should (listp named-imports))
 504         (should (= 2 (length named-imports)))
 505         (let ((first (nth 0 named-imports))
 506               (second (nth 1 named-imports)))
 507           (should (equal "bar" (js2-name-node-name (js2-export-binding-node-local-name first))))
 508           (should (equal "baz" (js2-name-node-name (js2-export-binding-node-local-name second))))))))
 509   (should (js2-scope-get-symbol js2-current-scope "bar"))
 510   (should (js2-scope-get-symbol js2-current-scope "baz")))
 511
 512 (js2-deftest parse-import-default-and-namespace "import stuff, * as lib from 'src/lib'"
 513   (js2-push-scope (make-js2-scope :pos 0))
 514   (js2-init-scanner)
 515   (should (js2-match-token js2-IMPORT))
 516   (let ((import-node (js2-parse-import)))
 517     (should (not (equal nil import-node)))
 518     (should (equal "src/lib" (js2-import-node-module-id import-node)))
 519     (let ((import (js2-import-node-import import-node)))
 520       (should (not (equal nil import)))
 521       (should (equal nil (js2-import-clause-node-named-imports import)))
 522       (let ((default (js2-import-clause-node-default-binding import))
 523             (ns-import (js2-import-clause-node-namespace-import import)))
 524         (should (not (equal nil default)))
 525         (should (equal "stuff" (js2-name-node-name (js2-export-binding-node-local-name default))))
 526         (should (not (equal nil ns-import)))
 527         (should (js2-namespace-import-node-p ns-import))
 528         (should (equal "lib" (js2-name-node-name (js2-namespace-import-node-name ns-import)))))))
 529   (should (js2-scope-get-symbol js2-current-scope "stuff"))
 530   (should (js2-scope-get-symbol js2-current-scope "lib")))
 531
 532 (js2-deftest parse-import-default-and-named-imports
 533   "import robert as bob, {cookies, pi as PIE} from 'src/lib'"
 534   (js2-push-scope (make-js2-scope :pos 0))
 535   (js2-init-scanner)
 536   (should (js2-match-token js2-IMPORT))
 537   (let ((import-node (js2-parse-import)))
 538     (should (not (equal nil import-node)))
 539     (should (equal "src/lib" (js2-import-node-module-id import-node)))
 540     (let ((import (js2-import-node-import import-node)))
 541       (should (not (equal nil import)))
 542       (should (not (equal nil (js2-import-clause-node-named-imports import))))
 543       (let ((default (js2-import-clause-node-default-binding import))
 544             (named-imports (js2-import-clause-node-named-imports import)))
 545         (should (not (equal nil default)))
 546         (should (equal "bob" (js2-name-node-name (js2-export-binding-node-local-name default))))
 547         (should (not (equal nil named-imports)))
 548         (should (= 2 (length named-imports))))))
 549   (should (js2-scope-get-symbol js2-current-scope "bob"))
 550   (should (js2-scope-get-symbol js2-current-scope "cookies"))
 551   (should (js2-scope-get-symbol js2-current-scope "PIE")))
 552
 553 (js2-deftest parse-this-module-in-from-clause "import {url} from this module;"
 554   (js2-push-scope (make-js2-scope :pos 0))
 555   (js2-init-scanner)
 556   (should (js2-match-token js2-IMPORT))
 557   (let ((import-node (js2-parse-import)))
 558     (should import-node)
 559     (let ((from-clause (js2-import-node-from import-node)))
 560       (should from-clause)
 561       (should (equal "this" (js2-from-clause-node-module-id from-clause)))
 562       (should (js2-from-clause-node-metadata-p from-clause)))))
 563
 564 (js2-deftest-parse import-only-for-side-effects "import 'src/lib';")
 565 (js2-deftest-parse import-default-only "import theDefault from 'src/lib';")
 566 (js2-deftest-parse import-named-only "import {one, two} from 'src/lib';")
 567 (js2-deftest-parse import-default-and-named "import theDefault, {one, two} from 'src/lib';")
 568 (js2-deftest-parse import-renaming-default "import * as lib from 'src/mylib';")
 569 (js2-deftest-parse import-renaming-named "import {one as uno, two as dos} from 'src/lib';")
 570 (js2-deftest-parse import-default-and-namespace "import robert as bob, * as lib from 'src/lib';")
 571 (js2-deftest-parse import-from-this-module "import {url} from this module;")
 572
 573 ;; Module Exports
 574
 575 (js2-deftest export-rexport "export * from 'other/lib'"
 576   (js2-init-scanner)
 577   (should (js2-match-token js2-EXPORT))
 578   (let ((export-node (js2-parse-export)))
 579     (should export-node)
 580     (should (js2-export-node-from-clause export-node))))
 581
 582 (js2-deftest export-export-named-list "export {foo, bar as bang};"
 583   (js2-init-scanner)
 584   (should (js2-match-token js2-EXPORT))
 585   (let ((export-node (js2-parse-export)))
 586     (should export-node)
 587     (let ((exports (js2-export-node-exports-list export-node)))
 588       (should exports)
 589       (should (= 2 (length exports))))))
 590
 591 (js2-deftest re-export-named-list "export {foo, bar as bang} from 'other/lib'"
 592   (js2-init-scanner)
 593   (should (js2-match-token js2-EXPORT))
 594   (let ((export-node (js2-parse-export)))
 595     (should export-node)
 596     (should (js2-export-node-from-clause export-node))
 597     (let ((exports (js2-export-node-exports-list export-node)))
 598       (should exports)
 599       (should (= 2 (length exports))))))
 600
 601 (js2-deftest export-variable-statement "export var foo = 'bar', baz = 'bang';"
 602   (js2-init-scanner)
 603   (js2-push-scope (make-js2-scope :pos 0))
 604   (should (js2-match-token js2-EXPORT))
 605   (let ((export-node (js2-parse-export)))
 606     (should export-node)
 607     (should (js2-export-node-declaration export-node))))
 608
 609 (js2-deftest export-const-declaration "export const PI = Math.PI;"
 610   (js2-init-scanner)
 611   (js2-push-scope (make-js2-scope :pos 0))
 612   (should (js2-match-token js2-EXPORT))
 613   (let ((export-node (js2-parse-export)))
 614     (should export-node)
 615     (should (js2-export-node-declaration export-node))))
 616
 617 (js2-deftest export-let-declaration "export let foo = [1];"
 618   (js2-init-scanner)
 619   (js2-push-scope (make-js2-scope :pos 0))
 620   (should (js2-match-token js2-EXPORT))
 621   (let ((export-node (js2-parse-export)))
 622     (should export-node)
 623     (should (js2-var-decl-node-p (js2-export-node-declaration export-node)))))
 624
 625 (js2-deftest export-class-declaration "export class Foo {};"
 626   (js2-init-scanner)
 627   (js2-push-scope (make-js2-scope :pos 0))
 628   (should (js2-match-token js2-EXPORT))
 629   (let ((export-node (js2-parse-export)))
 630     (should export-node)
 631     (should (js2-class-node-p (js2-export-node-declaration export-node)))))
 632
 633 (js2-deftest export-function-declaration "export default function doStuff() {};"
 634   (js2-init-scanner)
 635   (js2-push-scope (make-js2-scope :pos 0))
 636   (should (js2-match-token js2-EXPORT))
 637   (let ((export-node (js2-parse-export)))
 638     (should export-node)
 639     (should (js2-export-node-default export-node))))
 640
 641 (js2-deftest export-generator-declaration "export default function* one() {};"
 642   (js2-init-scanner)
 643   (js2-push-scope (make-js2-scope :pos 0))
 644   (should (js2-match-token js2-EXPORT))
 645   (let ((export-node (js2-parse-export)))
 646     (should export-node)
 647     (should (js2-export-node-default export-node))))
 648
 649 (js2-deftest export-assignment-expression "export default a = b;"
 650   (js2-init-scanner)
 651   (js2-push-scope (make-js2-scope :pos 0))
 652   (should (js2-match-token js2-EXPORT))
 653   (let ((export-node (js2-parse-export)))
 654     (should export-node)
 655     (should (js2-export-node-default export-node))))
 656
 657 (js2-deftest export-function-no-semicolon "export default function foo() {}"
 658   (js2-mode)
 659   (should (equal nil js2-parsed-warnings)))
 660 (js2-deftest export-default-function-no-semicolon "export function foo() {}"
 661   (js2-mode)
 662   (should (equal nil js2-parsed-warnings)))
 663 (js2-deftest export-anything-else-does-require-a-semicolon "export var obj = {}"
 664   (js2-mode)
 665   (should (not (equal nil js2-parsed-warnings))))
 666
 667 (js2-deftest-parse parse-export-rexport "export * from 'other/lib';")
 668 (js2-deftest-parse parse-export-export-named-list "export {foo, bar as bang};")
 669 (js2-deftest-parse parse-re-export-named-list "export {foo, bar as bang} from 'other/lib';")
 670 (js2-deftest-parse parse-export-const-declaration "export const PI = Math.PI;")
 671 (js2-deftest-parse parse-export-let-declaration "export let foo = [1];")
 672 (js2-deftest-parse parse-export-function-declaration "export default function doStuff() {};")
 673 (js2-deftest-parse parse-export-generator-declaration "export default function* one() {};")
 674 (js2-deftest-parse parse-export-assignment-expression "export default a = b;")
 675
 676 ;;; Strings
 677
 678 (js2-deftest-parse string-literal
 679   "var x = 'y';")
 680
 681 (js2-deftest-parse object-get-string-literal
 682   "var x = {y: 5};\nvar z = x[\"y\"];")
 683
 684 (js2-deftest-parse template-no-substritutions
 685   "var x = `abc
 686             def`, y = `\\u0000`;")
 687
 688 (js2-deftest-parse template-with-substitutions
 689   "var y = `${a + b} ${d + e + f}`;")
 690
 691 (js2-deftest-parse tagged-template
 692   "foo.args`${++x, \"o\"}k`;")
 693
 694 ;;; Classes
 695
 696 (js2-deftest-parse parse-harmony-class-statement
 697   "class Foo {\n  get bar() {  return 42;\n}\n  set bar(x) {  y = x;\n}\n}")
 698
 699 (js2-deftest-parse parse-harmony-class-statement-without-name-is-not-ok
 700   "class {\n  get bar() {  return 42;\n}\n}"
 701   :syntax-error "{")
 702
 703 (js2-deftest-parse parse-harmony-class-expression
 704   "var Foo1 = class Foo {\n  bar() {  return 42;\n}\n};")
 705
 706 (js2-deftest-parse parse-harmony-anonymous-class-expression
 707   "var Foo = class {\n  set bar(x) {  bar = x;\n}\n};")
 708
 709 (js2-deftest-parse parse-harmony-class-with-extends
 710   "class Foo extends Bar {\n}")
 711
 712 (js2-deftest-parse parse-harmony-anonymous-class-with-extends
 713   "foo.Foo = class extends Bar {\n  set bar(x) {  bar = x;\n}\n};")
 714
 715 (js2-deftest-parse parse-harmony-class-with-complex-extends
 716   "class Foo extends foo[BAR][2].Baz {\n}")
 717
 718 (js2-deftest-parse parse-harmony-class-missing-extended-class-is-not-ok
 719   "class Foo extends {\n}"
 720   :syntax-error "extends")
 721
 722 (js2-deftest-parse parse-harmony-class-static-method
 723   "class Foo extends Bar {\n  static bar() {  return 42;\n}\n}")
 724
 725 (js2-deftest-parse parse-unterminated-class-is-not-okay
 726   "class Foo {\n  get bar() {  return 42;\n}"
 727   :syntax-error "}")
 728
 729 (js2-deftest-parse parse-super-keyword
 730   "class Foo {\n  constructor() {  super(42);\n}\n  foo() {  super.foo();\n}\n}")
 731
 732 (js2-deftest-parse parse-class-keywordlike-method
 733   "class C {\n  delete() {}\n  if() {}\n}")
 734
 735 ;;; Scopes
 736
 737 (js2-deftest ast-symbol-table-includes-fn-node "function foo() {}"
 738   (js2-mode)
 739   (let ((entry (js2-scope-get-symbol js2-mode-ast 'foo)))
 740     (should (= (js2-symbol-decl-type entry) js2-FUNCTION))
 741     (should (equal (js2-symbol-name entry) "foo"))
 742     (should (js2-function-node-p (js2-symbol-ast-node entry)))))
 743
 744 (js2-deftest fn-symbol-table-includes-nested-fn "function foo() {
 745   function bar() {}
 746   var x;
 747 }"
 748   (js2-mode)
 749   (let* ((scope (js2-node-at-point (point-min)))
 750          (fn-entry (js2-scope-get-symbol scope 'bar))
 751          (var-entry (js2-scope-get-symbol scope 'x)))
 752     (should (string= (js2-name-node-name (js2-function-node-name scope)) "foo"))
 753     (should (= (js2-symbol-decl-type fn-entry) js2-FUNCTION))
 754     (should (js2-function-node-p (js2-symbol-ast-node fn-entry)))
 755     (should (= (js2-symbol-decl-type var-entry) js2-VAR))
 756     (should (js2-name-node-p (js2-symbol-ast-node var-entry)))))
 757
 758 (defun js2-test-scope-of-nth-variable-satisifies-predicate (variable nth predicate)
 759   (goto-char (point-min))
 760   (dotimes (n (1+ nth)) (search-forward variable))
 761   (forward-char -1)
 762   (let ((scope (js2-node-get-enclosing-scope (js2-node-at-point))))
 763     (should (funcall predicate (js2-get-defining-scope scope variable)))))
 764
 765 (js2-deftest for-node-is-declaration-scope "for (let i = 0; i; ++i) {};"
 766   (js2-mode)
 767   (js2-test-scope-of-nth-variable-satisifies-predicate "i" 0 #'js2-for-node-p))
 768
 769 (js2-deftest const-scope-sloppy-script "{const a;} a;"
 770   (js2-mode)
 771   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 0 #'js2-script-node-p)
 772   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 1 #'js2-script-node-p))
 773
 774 (js2-deftest const-scope-strict-script "'use strict'; { const a; } a;"
 775   (js2-mode)
 776   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 0 #'js2-block-node-p)
 777   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 1 #'null))
 778
 779 (js2-deftest const-scope-sloppy-function "function f() { { const a; } a; }"
 780   (js2-mode)
 781   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 0 #'js2-function-node-p)
 782   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 1 #'js2-function-node-p))
 783
 784 (js2-deftest const-scope-strict-function "function f() { 'use strict'; { const a; } a; }"
 785   (js2-mode)
 786   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 0 #'js2-block-node-p)
 787   (js2-test-scope-of-nth-variable-satisifies-predicate "a" 1 #'null))
 788
 789 (js2-deftest array-comp-is-result-scope "[x * 2 for (x in y)];"
 790   (js2-mode)
 791   (js2-test-scope-of-nth-variable-satisifies-predicate "x" 0 #'js2-comp-loop-node-p))
 792
 793 (js2-deftest array-comp-has-parent-scope
 794              "var a,b=[for (i of [[1,2]]) for (j of i) j * a];"
 795   (js2-mode)
 796   (search-forward "for")
 797   (forward-char -3)
 798   (let ((node (js2-node-at-point)))
 799     (should (js2-scope-parent-scope node))
 800     (should (js2-get-defining-scope node "j"))))
 801
 802 ;;; Tokenizer
 803
 804 (js2-deftest get-token "(1+1)"
 805   (js2-init-scanner)
 806   (should (eq js2-LP (js2-next-token)))
 807   (should (eq js2-NUMBER (js2-next-token)))
 808   (should (eq js2-ADD (js2-next-token)))
 809   (should (eq js2-NUMBER (js2-next-token)))
 810   (should (eq js2-RP (js2-next-token))))
 811
 812 (js2-deftest unget-token "()"
 813   (js2-init-scanner)
 814   (should (eq js2-LP (js2-next-token)))
 815   (js2-unget-token)
 816   (should (eq js2-LP (js2-next-token)))
 817   (should (eq js2-RP (js2-next-token))))
 818
 819 (js2-deftest get-token-or-eol "x\n++;"
 820   (js2-init-scanner)
 821   (should (eq js2-NAME (js2-next-token)))
 822   (should (eq js2-EOL (js2-peek-token-or-eol)))
 823   (should (eq js2-INC (js2-next-token)))
 824   (should (eq js2-SEMI (js2-peek-token-or-eol))))
 825
 826 (js2-deftest unget-token-over-eol-and-comment "x\n//abc\ny"
 827   (js2-init-scanner)
 828   (should (eq js2-NAME (js2-next-token)))
 829   (should (eq js2-NAME (js2-next-token)))
 830   (should (equal "y" (js2-current-token-string)))
 831   (js2-unget-token)
 832   (should (eq js2-NAME (js2-current-token-type)))
 833   (should (equal "x" (js2-current-token-string))))
 834
 835 (js2-deftest ts-seek "(1+2)"
 836   (js2-init-scanner)
 837   (should (eq js2-LP (js2-next-token)))
 838   (should (eq js2-NUMBER (js2-next-token)))
 839   (js2-unget-token)
 840   (let ((state (make-js2-ts-state)))
 841     (should (eq js2-NUMBER (js2-next-token)))
 842     (should (eq js2-ADD (js2-next-token)))
 843     (js2-ts-seek state)
 844     (should (eq 1 js2-ti-lookahead))
 845     (should (eq js2-NUMBER (js2-next-token)))
 846     (should (eq 1 (js2-token-number
 847                    (js2-current-token))))))
 848
 849 (js2-deftest get-token-template-literal "`abc ${i} z ${j} def`"
 850   (js2-init-scanner)
 851   (should (eq js2-TEMPLATE_HEAD (js2-next-token)))
 852   (should (equal "abc " (js2-current-token-string)))
 853   (should (eq js2-NAME (js2-next-token)))
 854   (should (eq js2-RC (js2-next-token)))
 855   (should (eq js2-TEMPLATE_HEAD (js2-next-token 'TEMPLATE_TAIL)))
 856   (should (equal " z " (js2-current-token-string)))
 857   (should (eq js2-NAME (js2-next-token)))
 858   (should (eq js2-RC (js2-next-token)))
 859   (should (eq js2-NO_SUBS_TEMPLATE (js2-next-token 'TEMPLATE_TAIL)))
 860   (should (equal " def" (js2-current-token-string))))
 861
 862 ;;; Error handling
 863
 864 (js2-deftest for-node-with-error-len "for "
 865   (js2-mode)
 866   (let ((node (js2-node-at-point (point-min))))
 867     (should (= (js2-node-len (js2-node-parent node)) 4))))
 868
 869 (js2-deftest function-without-parens-error "function b {}"
 870   ;; Should finish the parse.
 871   (js2-mode))
 872
 873 ;;; Comments
 874
 875 (js2-deftest comment-node-length "//"
 876   (js2-mode)
 877   (let ((node (js2-node-at-point (point-min))))
 878     (should (= (js2-node-len node) 2))))
 879
 880 (js2-deftest comment-node-length-newline "//\n"
 881   (js2-mode)
 882   (let ((node (js2-node-at-point (point-min))))
 883     (should (= (js2-node-len node) 3))))
 884
 885 ;;; Variables classification
 886
 887 (defun js2--variables-summary (vars)
 888   (let (r)
 889     (setq vars (let (aslist)
 890                  (maphash (lambda (k v) (push (cons k v) aslist)) vars)
 891                  aslist))
 892     (dolist (v (sort vars (lambda (a b) (< (js2-node-abs-pos (js2-symbol-ast-node (car a)))
 893                                       (js2-node-abs-pos (js2-symbol-ast-node (car b)))))))
 894       (let* ((symbol (car v))
 895              (inition (cadr v))
 896              (uses (cddr v))
 897              (symn (js2-symbol-ast-node symbol))
 898              (namen (js2--get-name-node symn)))
 899         (push (format "%s@%s:%s"
 900                       (js2-symbol-name symbol)
 901                       (js2-node-abs-pos namen)
 902                       (if (eq inition ?P)
 903                           "P"
 904                         (if uses
 905                             (if inition "I" "N")
 906                           "U"))) r)
 907         (dolist (u (sort (cddr v) (lambda (a b) (< (js2-node-abs-pos a)
 908                                               (js2-node-abs-pos b)))))
 909           (push (js2-node-abs-pos u) r))))
 910     (reverse r)))
 911
 912 (defmacro js2-deftest-classify-variables (name buffer-contents summary)
 913  (declare (indent defun))
 914   `(ert-deftest ,(intern (format "js2-classify-variables-%s" name)) ()
 915      (with-temp-buffer
 916        (save-excursion
 917          (insert ,buffer-contents))
 918        (unwind-protect
 919            (progn
 920              (js2-mode)
 921              (should (equal ,summary (js2--variables-summary
 922                                       (js2--classify-variables)))))
 923          (fundamental-mode)))))
 924
 925 (js2-deftest-classify-variables incomplete-var-statement
 926   "var"
 927   '())
 928
 929 (js2-deftest-classify-variables unused-variable
 930   "function foo () { var x; return 42; }"
 931   '("foo@10:U" "x@23:U"))
 932
 933 (js2-deftest-classify-variables unused-variable-declared-twice
 934   "function foo (a) { var x; function bar () { var x; x=42; }; return a;}"
 935   '("foo@10:U" "a@15:P" 68 "x@24:U" "bar@36:U" "x@49:U"))
 936
 937 (js2-deftest-classify-variables assigned-variable
 938   "function foo () { var x; x=42; return x; }"
 939   '("foo@10:U" "x@23:I" 39))
 940
 941 (js2-deftest-classify-variables assignment-in-nested-function
 942   "function foo () { var x; function bar () { x=42; }; }"
 943   '("foo@10:U" "x@23:U" "bar@35:U"))
 944
 945 (js2-deftest-classify-variables unused-nested-function
 946   "function foo() { var i, j=1; function bar() { var x, y=42, z=i; return y; } return i; }"
 947   '("foo@10:U" "i@22:N" 62 84 "j@25:U" "bar@39:U" "x@51:U" "y@54:I" 72 "z@60:U"))
 948
 949 (js2-deftest-classify-variables prop-get-initialized
 950   "function foo () { var x, y={}; y.a=x; }"
 951   '("foo@10:U" "x@23:N" 36 "y@26:I" 32))
 952
 953 (js2-deftest-classify-variables prop-get-uninitialized
 954   "function foo () { var x; if(x.foo) alert('boom'); }"
 955   '("foo@10:U" "x@23:N" 29))
 956
 957 (js2-deftest-classify-variables prop-get-function-assignment
 958   "(function(w) { w.f = function() { var a=42, m; return a; }; })(window);"
 959   '("w@11:P" 11 16 "a@39:I" 55 "m@45:U"))
 960
 961 (js2-deftest-classify-variables let-declaration
 962   "function foo () { let x,y=1; return x; }"
 963   '("foo@10:U" "x@23:N" 37 "y@25:U"))
 964
 965 (js2-deftest-classify-variables external-function-call
 966   "function foo (m) { console.log(m, arguments); }"
 967   '("foo@10:U" "m@15:P" 32))
 968
 969 (js2-deftest-classify-variables global-function-call
 970   "function bar () { return 42; } function foo (a) { return bar(); }"
 971   '("bar@10:I" 58 "foo@41:U" "a@46:P"))
 972
 973 (js2-deftest-classify-variables let-declaration-for-scope
 974   "function foo () { for(let x=1,y; x<y; y++) {} }"
 975   '("foo@10:U" "x@27:I" 34 "y@31:N" 36 39))
 976
 977 (js2-deftest-classify-variables arguments-implicit-var
 978   "function foo () { var p; for(p in arguments) { return p; } }"
 979   '("foo@10:U" "p@23:I" 55))
 980
 981 (js2-deftest-classify-variables catch-error-variable
 982   "function foo () { try { throw 'Foo'; } catch (e) { console.log(e); }"
 983   '("foo@10:U" "e@47:I" 64))
 984
 985 (js2-deftest-classify-variables prop-get-assignment
 986   "function foo () { var x={y:{z:{}}}; x.y.z=42; }"
 987   '("foo@10:U" "x@23:I" 37))
 988
 989 (js2-deftest-classify-variables unused-function-argument
 990   "function foo (a) { return 42; }"
 991   '("foo@10:U" "a@15:P"))
 992
 993 (js2-deftest-classify-variables used-function-argument
 994   "function foo (a) { a=42; return a; }"
 995   '("foo@10:U" "a@15:P" 33))
 996
 997 (js2-deftest-classify-variables prop-get
 998   "function foo (a) { a=navigator.x||navigator.y; return a; }"
 999   '("foo@10:U" "a@15:P" 55))
1000
1001 (js2-deftest-classify-variables for-in-loop
1002   "function foo () { var d={}; for(var k in d) {var v=d[k]; } }"
1003   '("foo@10:U" "d@23:I" 42 52 "k@37:I" 54 "v@50:U"))
1004
1005 (js2-deftest-classify-variables array-comprehension-legacy
1006   "function foo() { var j,a=[for (i of [1,2,3]) i*j]; }"
1007   '("foo@10:U" "j@22:N" 48 "a@24:U" "i@32:I" 46))
1008
1009 (js2-deftest-classify-variables array-comprehension
1010   "function foo() { var j,a=[[i,j] for (i of [1,2,3])]; }"
1011   '("foo@10:U" "j@22:N" 30 "a@24:U" "i@38:I" 28))
1012
1013 (js2-deftest-classify-variables return-named-function
1014   "function foo() { var a=42; return function bar() { return a; } }"
1015   '("foo@10:U" "a@22:I" 59 "bar@44:I" 44))
1016
1017 (js2-deftest-classify-variables named-wrapper-function
1018   "function foo() { var a; (function bar() { a=42; })(); return a; }"
1019   '("foo@10:U" "a@22:I" 62 "bar@35:I" 35))