Clean-up previous change

* counsel.el (counsel--browse-history): Rename from `browse-history'.

(eshell-history-ring):
(comint-input-ring): Declare.
(counsel-esh-history): Add require.
(counsel-shell-history): Add require.
(** `counsel-esh-history'): Add an outline.

Fixes #459

diff --git a/counsel.el b/counsel.el
index 76daf6d94d7841224e65fc08f8c85582f37ae33c..864340a2a9df341b56a5cecd7f84ea7d38228277 100644 (file)
--- a/counsel.el
+++ b/counsel.el
@@ -1896,7 +1896,8 @@ And insert it into the minibuffer. Useful during
     (ivy-read "Expr: " (delete-dups read-expression-history)
               :action #'insert)))
 
-(defun browse-history (elements)
+;;** `counsel-esh-history'
+(defun counsel--browse-history (elements)
   "Use Ivy to navigate through ELEMENTS."
   (setq ivy-completion-beg (point))
   (setq ivy-completion-end (point))
@@ -1905,17 +1906,23 @@ And insert it into the minibuffer. Useful during
              (ring-elements elements))
             :action #'ivy-completion-in-region-action))
 
+(defvar eshell-history-ring)
+
 ;;;###autoload
 (defun counsel-esh-history ()
   "Browse Eshell history."
   (interactive)
-  (browse-history eshell-history-ring))
+  (require 'em-hist)
+  (counsel--browse-history eshell-history-ring))
+
+(defvar comint-input-ring)
 
 ;;;###autoload
 (defun counsel-shell-history ()
   "Browse shell history."
   (interactive)
-  (browse-history comint-input-ring))
+  (require 'comint)
+  (counsel--browse-history comint-input-ring))
 
 ;;* Misc OS
 ;;** `counsel-rhythmbox'