]> code.delx.au - gnu-emacs/blob - src/ChangeLog
src/bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
[gnu-emacs] / src / ChangeLog
1 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4
5 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * alloc.c (Fgc_status): Do not access beyond zombies array
8 boundary if nzombies > MAX_ZOMBIES.
9 * alloc.c (dump_zombies): Add missing format specifier.
10
11 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
12
13 * xdisp.c (set_cursor_from_row): Simplify conditionals,
14 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
15
16 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
17 Some packages use them to denote characters with modifiers.
18
19 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
20
21 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
22 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
23 matching a pp-number. Rename parameter var to var1.
24
25 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
26
27 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
28
29 2011-10-08 Glenn Morris <rgm@gnu.org>
30
31 * callint.c (Fcall_interactively): Give a more explicit error for the
32 'c' case with a non-character input. (Bug#8479)
33
34 2011-10-08 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
37 lines.
38 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
39 lines that are hscrolled on the left.
40
41 * dispnew.c (buffer_posn_from_coords): Account for a possible
42 presence of header-line. (Bug#4426)
43
44 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
45
46 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
47 advertise functionality which we discourage or doesn't work.
48
49 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
50
51 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
52 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
53 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
54 this makes Emacs dump core during garbage collection on rare
55 occasions. sizeof is obviously inferior to offsetof here, so
56 stick with offsetof.
57 (GC_POINTER_ALIGNMENT): New macro.
58 (mark_memory): Omit 3rd (offset) arg; caller changed.
59 Don't assume EMACS_INT alignment is the same as pointer alignment.
60
61 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
62
63 * keyboard.c (read_key_sequence_remapped): New var.
64 (read_key_sequence): Compute remapping in the right buffer.
65 (command_loop_1): Use read_key_sequence's remapping directly.
66
67 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * dired.c (file_name_completion): Don't expand file name.
70 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
71 before checking file name handler.
72
73 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
74 they've been requested explicitly (bug#9591).
75
76 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
77
78 * keymap.c (Fsingle_key_description): Use make_specified_string
79 instead of build_string to build string from push_key_description.
80 (Bug#5193)
81
82 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
83
84 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
85 This fixes a Y2038 bug on 64-bit hosts.
86 * buffer.c (reset_buffer):
87 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
88 (Fclear_buffer_auto_save_failure):
89 Use 0, not -1, to represent an unset failure time, since time_t
90 might not be signed.
91
92 Remove dependency on glibc malloc internals.
93 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
94 Move back here from lisp.h, but with their new implementations.
95 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
96 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
97 * charset.c (charset_table_init): New static var.
98 (syms_of_charset): Use it instead of xmalloc. This removes a
99 dependency on glibc malloc internals. See Eli Zaretskii's comment in
100 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
101 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
102 Move back to alloc.c.
103 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
104 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
105
106 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
107
108 * nsterm.m (windowDidResize): Call x_set_window_size only when
109 ns_in_resize is true. Otherwise set pixelwidth/height and
110 call change_frame_size (Bug#9628).
111
112 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
113
114 Port --enable-checking=all to Fedora 14 x86-64.
115 * charset.c (syms_of_charset): Also account for glibc malloc's
116 internal overhead when calculating the initial malloc maximum.
117
118 Port --enable-checking=all to Fedora 14 x86.
119 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
120 Move to lisp.h.
121 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
122 (overrun_check_realloc, overrun_check_free):
123 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
124 That way, xmalloc returns a properly-aligned pointer even if
125 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
126 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
127 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
128 into account when calculating the initial malloc maximum.
129 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
130 Move here from alloc.c, so that charset.c can use it too.
131 Properly align; the old code wasn't right for common 32-bit hosts
132 when configured with --enable-checking=all.
133 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
134 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
135
136 2011-09-29 Eli Zaretskii <eliz@gnu.org>
137
138 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
139 use EDOM.
140
141 2011-09-28 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (compute_display_string_end): If there's no display
144 string at CHARPOS, return -1.
145
146 * bidi.c (bidi_fetch_char): When compute_display_string_end
147 returns a negative value, treat the character as a normal
148 character not covered by a display string. (Bug#9624)
149
150 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
151
152 * lread.c (Fread_from_string): Fix typo in docstring.
153
154 2011-09-27 Eli Zaretskii <eliz@gnu.org>
155
156 * xdisp.c (handle_invisible_prop): If invisible text ends on a
157 newline, reseat the iterator instead of bidi-iterating there one
158 character at a time. (Bug#9610)
159 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
160 TO_CHARPOS if the bidi iterator is at base embedding level.
161
162 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
163
164 * lread.c (readevalloop): Use correct code for NBSP.
165 (read1): Likewise. (Bug#9608)
166
167 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
168
169 * dbusbind.c (Fdbus_register_signal): When service is not
170 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
171
172 2011-09-25 Glenn Morris <rgm@gnu.org>
173
174 * buffer.c (truncate-lines): Doc fix.
175
176 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
177
178 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
179 (Fset_window_next_buffers): Doc fix.
180
181 2011-09-24 Glenn Morris <rgm@gnu.org>
182
183 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
184
185 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
186
187 Fix minor problems found by static checking.
188 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
189 * indent.c (Fvertical_motion): Fix == vs = typo.
190
191 2011-09-24 Eli Zaretskii <eliz@gnu.org>
192
193 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
194 Default value is now t. Doc fix.
195
196 * indent.c (Fvertical_motion): Compute and apply the overshoot
197 logic when moving up, not only when moving down. Fix the
198 confusing name and values of the it_overshoot_expected variable;
199 logic changes accordingly. (Bug#9254) (Bug#9549)
200
201 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
202 CHARPOS is covered by a display string which includes newlines.
203 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
204 is covered by a display string with embedded newlines.
205
206 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
207
208 * dbusbind.c (Fdbus_register_signal): Add match rule to
209 Vdbus_registered_objects_table. (Bug#9581)
210 (Fdbus_register_method, Vdbus_registered_objects_table):
211 Fix docstring.
212
213 2011-09-24 Jim Meyering <meyering@redhat.com>
214
215 do not ignore write error for any output size
216 The previous change was incomplete.
217 While it makes emacs --batch detect the vast majority of stdout
218 write failures, errors were still ignored whenever the output size is
219 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
220 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
221 && echo FAIL: ignored write error
222 FAIL: ignored write error
223 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
224 && echo FAIL: ignored write error
225 FAIL: ignored write error
226 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
227
228 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
229
230 * emacs.c (Fkill_emacs): In noninteractive mode exit
231 non-successfully if a write error occurred on stdout. (Bug#9574)
232
233 2011-09-21 Eli Zaretskii <eliz@gnu.org>
234
235 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
236 the xassert test.
237
238 * dispextern.h (struct it): Update the comment documenting what
239 can it->OBJECT be.
240
241 2011-09-20 Eli Zaretskii <eliz@gnu.org>
242
243 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
244 a display string, extend search for cursor position to end of row.
245 (find_row_edges): If the row ends in a newline from a display
246 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
247 Handle the case of a display string with multiple newlines.
248 (Fcurrent_bidi_paragraph_direction): Fix search for previous
249 non-empty line. Fixes confusing cursor motion with arrow keys at
250 the beginning of a line that starts with whitespace.
251
252 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
253
254 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
255 (bug#9493).
256
257 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
258
259 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
260 boolean (Bug#9154).
261
262 2011-09-18 Eli Zaretskii <eliz@gnu.org>
263
264 * xdisp.c (display_line): Record maximum and minimum buffer
265 positions even if no glyphs were produced (e.g., by a zero-width
266 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
267 buffer positions that will be removed from the glyph row because
268 they don't fit.
269 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
270 column is beyond frame width: don't subtract 1 "pixel" when
271 computing width of the stretch.
272 (reseat_at_next_visible_line_start): Undo the change made on
273 2011-09-17 that saved paragraph information and restored it after
274 the call to `reseat'. (Bug#9545)
275
276 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
277
278 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
279 and turn window cursor on if cleared (Bug#9415).
280
281 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
282
283 * search.c (boyer_moore): Take unibyte characters from pattern
284 literally. (Bug#9458)
285
286 2011-09-18 Eli Zaretskii <eliz@gnu.org>
287
288 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
289
290 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
291
292 Fix minor problem found by static checking.
293 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
294 initialized, to pacify gcc -Wuninitialized.
295
296 * fileio.c: Report proper errno when syscall falls.
297 (Finsert_file_contents): Save and restore errno,
298 so that report_file_error outputs the correct diagnostic.
299 (Fwrite_region) [CLASH_DETECTION]: Likewise.
300
301 2011-09-18 Eli Zaretskii <eliz@gnu.org>
302
303 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
304
305 2011-09-17 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
308 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
309
310 2011-09-17 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (reseat_at_next_visible_line_start): Keep information
313 about the current paragraph and restore it after the call to
314 reseat.
315
316 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
317 (bidi_find_paragraph_start): Search back for paragraph beginning
318 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
319 (bidi_move_to_visually_next): Only trigger paragraph-related
320 computations when the last character is a newline or at EOB, not
321 just any NEUTRAL_B. (Bug#9470)
322
323 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
324 truncated lines if point is covered by a display string. (Bug#9524)
325
326 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
327
328 * xselect.c: Relax test for outgoing X longs (Bug#9498).
329 (cons_to_x_long): New function.
330 (lisp_data_to_selection_data): Use it. Correct the test for
331 short-versus-long data; it was negated. Break out of vector
332 loop, for efficiency, when a long datum is discovered.
333
334 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
335
336 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
337
338 2011-09-16 Eli Zaretskii <eliz@gnu.org>
339
340 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
341 GCC PR/17406) by declaring this function with external scope.
342
343 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
344
345 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
346 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
347
348 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
349
350 * editfns.c (Fformat): Correctly handle text properties on "%%".
351
352 2011-09-15 Eli Zaretskii <eliz@gnu.org>
353
354 * xterm.c (x_draw_composite_glyph_string_foreground):
355 * w32term.c (x_draw_composite_glyph_string_foreground):
356 * term.c (encode_terminal_code):
357 * composite.c (composition_update_it, get_composition_id):
358 * xdisp.c (get_next_display_element)
359 (fill_composite_glyph_string): Add comments about special meaning
360 of TAB characters in a composition.
361
362 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
363
364 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
365 This occurs when processing a multibyte format.
366 Problem reported by Wolfgang Jenker.
367
368 2011-09-15 Johan Bockgård <bojohan@gnu.org>
369
370 * xdisp.c (try_cursor_movement): Only check for exact match if
371 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
372
373 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
374
375 Remove unused external symbols.
376 * dispextern.h (calc_pixel_width_or_height): Remove decl.
377 * xdisp.c (calc_pixel_width_or_height): Now static.
378 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
379 * indent.c (check_display_width):
380 * w32term.c: Fix comment to match code.
381 * xterm.c, xterm.h (x_catching_errors): Remove.
382
383 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
384
385 * xselect.c: Use signed conversions more consistently (Bug#9498).
386 (selection_data_to_lisp_data): Assume incoming selection data are
387 signed integers, not unsigned. This is to be consistent with
388 outgoing selection data, which was modified to use signed integers
389 in as part of the fix to Bug#9196 in response to Jan D.'s comment
390 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
391 expects long, not unsigned long.
392
393 2011-09-14 Eli Zaretskii <eliz@gnu.org>
394
395 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
396 computation of loop end. Reported by Johan Bockgård
397 <bojohan@gnu.org>.
398
399 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
400
401 * frame.c (Fother_visible_frames_p): Function deleted.
402
403 2011-09-12 Eli Zaretskii <eliz@gnu.org>
404
405 * indent.c (compute_motion): Process display vector front to back
406 rather than the other way around. (Bug#2496)
407
408 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
409
410 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
411
412 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
413
414 * minibuf.c (Fread_from_minibuffer): Doc fix.
415
416 2011-09-11 Eli Zaretskii <eliz@gnu.org>
417
418 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
419 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
420
421 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
422
423 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
424 value for non-existent files.
425
426 2011-09-11 Eli Zaretskii <eliz@gnu.org>
427
428 * fileio.c (Finsert_file_contents): If the file cannot be opened,
429 set its "size" to -1. This will set the modtime_size field of
430 the corresponding buffer to -1, which is what
431 verify-visited-file-modtime expects for files that do not exist.
432 (Bug#9139)
433
434 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
435
436 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
437 here ...
438 * lisp.h: ... from here. push_key_description is no longer
439 defined in keyboard.c, so its declaration should not be in
440 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
441 logically belongs with push_key_description.
442
443 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
444
445 * buffer.h: Include <sys/types.h> instead of <time.h>.
446 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
447 Problem reported by Herbert J. Skuhra.
448
449 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
450
451 * xml.c (parse_region): Make the parsing work for
452 non-comment-starting XML files again (bug#9144).
453
454 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
455
456 * image.c (gif_load): Fix calculation of bottom and right corner.
457 (Bug#9468)
458
459 2011-09-10 Eli Zaretskii <eliz@gnu.org>
460
461 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
462 redisplay in small windows.
463
464 2011-09-09 Eli Zaretskii <eliz@gnu.org>
465
466 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
467
468 2011-09-08 Martin Rudalics <rudalics@gmx.at>
469
470 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
471 Operate on live windows only.
472
473 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
474
475 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
476
477 2011-09-07 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
480 only under bidi iteration.
481
482 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
483
484 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
485
486 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
487
488 isnan: Fix porting problem to Solaris 10 with bundled gcc.
489 Without this fix, the command to link temacs failed due to an
490 undefined symbol __builtin_isnan. This is because
491 /usr/include/iso/math_c99.h #defines isnan(x) to
492 __builtin_isnan(x), but the bundled gcc, which identifies itself
493 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
494 a __builtin_isnan.
495 * floatfns.c (isnan): #undef, and then #define to a clone of
496 what's in data.c.
497 (Fisnan): Always define, since it's always available now.
498 (syms_of_floatfns): Always define isnan at the Lisp level.
499
500 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
501
502 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
503
504 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
505
506 * fileio.c: Fix bugs with large file offsets (Bug#9428).
507 The previous code assumed that file offsets (off_t values) fit in
508 EMACS_INT variables, which is not true on typical 32-bit hosts.
509 The code messed up by falsely reporting buffer overflow in cases
510 such as (insert-file-contents "big" nil 1 2) into an empty buffer
511 when "big" contains more than 2**29 bytes, even though this
512 inserts just one byte and does not overflow the buffer.
513 (Finsert_file_contents): Store file offsets as off_t
514 values, not as EMACS_INT values. Check for overflow when
515 converting between EMACS_INT and off_t. When checking for
516 buffer overflow or for overlap, take the offsets into account.
517 Don't use EMACS_INT for small values where int suffices.
518 When checking for overlap, fix a typo: ZV was used where
519 ZV_BYTE was intended.
520 (Fwrite_region): Don't assume off_t fits into 'long'.
521 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
522
523 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
524
525 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
526
527 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
528
529 sprintf-related integer and memory overflow issues (Bug#9412).
530
531 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
532 (esprintf, exprintf, evxprintf): New functions.
533 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
534 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
535 (modify_event_symbol): Do not assume that the length of
536 name_alist_or_stem is safe to alloca and fits in int.
537 (Fexecute_extended_command): Likewise for function name and binding.
538 (Frecursion_depth): Wrap around reliably on integer overflow.
539 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
540 since some callers pass EMACS_INT values.
541 (Fsingle_key_description): Don't crash if symbol name contains more
542 than MAX_ALLOCA bytes.
543 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
544 (get_minibuffer): Arg is now EMACS_INT, not int.
545 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
546 (esprintf, exprintf, evxprintf): New decls.
547 * window.h (command_loop_level, minibuf_level): Reflect API changes.
548
549 * dbusbind.c (signature_cat): New function.
550 (xd_signature, Fdbus_register_signal):
551 Do not overrun buffer; instead, report string overflow.
552
553 * dispnew.c (add_window_display_history): Don't overrun buffer.
554 Truncate instead; this is OK since it's just a log.
555
556 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
557 even if the time zone offset is outlandishly large.
558 Don't mishandle offset == INT_MIN.
559
560 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
561 when creating daemon; the previous buffer-overflow check was incorrect.
562
563 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
564 which has the guts of the old verror function.
565
566 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
567 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
568
569 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
570 (font_unparse_xlfd): Don't blindly alloca long strings.
571 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
572 fits in int, when using sprintf. Use single snprintf to count
573 length of string rather than counting it via multiple sprintfs;
574 that's simpler and more reliable.
575 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
576 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
577 sprintf, in case result does not fit in int.
578
579 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
580 (fontset_from_font): Print it.
581
582 * frame.c (tty_frame_count): Now printmax_t, not int.
583 (make_terminal_frame, set_term_frame_name): Print it.
584 (x_report_frame_params): In X, window IDs are unsigned long,
585 not signed long, so print them as unsigned.
586 (validate_x_resource_name): Check for implausibly long names,
587 and don't assume name length fits in 'int'.
588 (x_get_resource_string): Don't blindly alloca invocation name;
589 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
590 not fit in int.
591
592 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
593 (xg_check_special_colors, xg_set_geometry):
594 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
595
596 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
597 Use esprintf, not sprintf, in case result does not fit in int.
598
599 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
600 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
601 it as a large positive number.
602 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
603 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
604
605 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
606 in case result does not fit in int.
607
608 * print.c (float_to_string): Detect width overflow more reliably.
609 (print_object): Make sprintf buffer a bit bigger, to avoid potential
610 buffer overrun. Don't assume list length fits in 'int'. Treat
611 print length of 0 as 0, not as infinity; to be consistent with other
612 uses of print length in this function. Don't overflow print length
613 index. Don't assume hash table size fits in 'long', or that
614 vectorlike size fits in 'unsigned long'.
615
616 * process.c (make_process): Use printmax_t, not int, to format
617 process-name gensyms.
618
619 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
620
621 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
622 to avoid potential buffer overrun.
623
624 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
625 if X resource line is longer than 512 bytes.
626
627 * xfns.c (x_window): Make sprintf buffer a bit bigger
628 to avoid potential buffer overrun.
629
630 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
631
632 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
633
634 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
635
636 Integer overflow fixes for scrolling, etc.
637 Without these, Emacs silently mishandles large integers sometimes.
638 For example, "C-u 4294967297 M-x recenter" was treated as if
639 it were "C-u 1 M-x recenter" on a typical 64-bit host.
640
641 * xdisp.c (try_window_id): Check Emacs fixnum range before
642 converting to 'int'.
643
644 * window.c (window_scroll_line_based, Frecenter):
645 Check that an Emacs fixnum is in range before assigning it to 'int'.
646 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
647 values converted from Emacs fixnums.
648 (Frecenter): Don't wrap around a line count if it is out of 'int'
649 range; instead, treat it as an extreme value.
650 (Fset_window_configuration, compare_window_configurations):
651 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
652
653 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
654 that can exceed INT_MAX. Check that EMACS_INT value is in range
655 before assigning it to the (possibly-narrower) index.
656 (match_limit): Don't assume that a fixnum can fit in 'int'.
657
658 * print.c (print_object): Use ptrdiff_t, not int, for index that can
659 exceed INT_MAX.
660
661 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
662 (Fvertical_motion): Don't wrap around LINES values that don't fit
663 in 'int'. Instead, treat them as extreme values. This is good
664 enough for windows, which can't have more than INT_MAX lines anyway.
665
666 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
667
668 * Require libxml/parser.h to avoid compilation warning.
669
670 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
671
672 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
673 since this reportedly can destroy thread storage.
674
675 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
676
677 * syntax.c (find_defun_start): Update all cache variables if
678 exiting early (Bug#9401).
679
680 2011-08-30 Eli Zaretskii <eliz@gnu.org>
681
682 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
683
684 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
685 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
686 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
687
688 * term.c (tty_append_glyph): New function.
689 (produce_stretch_glyph): Static function and its prototype deleted.
690
691 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
692 Add prototypes.
693
694 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
695
696 * image.c (parse_image_spec): Check for nonnegative, not for positive,
697 when checking :margin (Bug#9390).
698 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
699 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
700 so that the name doesn't mislead. All uses changed.
701
702 2011-08-28 Johan Bockgård <bojohan@gnu.org>
703
704 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
705 set_tty_hooks.
706
707 2011-08-27 Eli Zaretskii <eliz@gnu.org>
708
709 * xdisp.c (move_it_to): Don't bail out early when reaching
710 position beyond to_charpos, if we are scanning backwards.
711 (move_it_vertically_backward): When DY == 0, make sure we get to
712 the first character in the line after the newline.
713
714 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
715
716 * ccl.c: Improve and simplify overflow checking (Bug#9196).
717 (ccl_driver): Do not generate an out-of-range pointer.
718 (Fccl_execute_on_string): Remove unnecessary check for
719 integer overflow, noted by Stefan Monnier in
720 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
721 Remove a FIXME that didn't need fixing.
722 Simplify the newly-introduced buffer reallocation code.
723
724 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
725
726 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
727
728 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
729
730 Integer and memory overflow issues (Bug#9196).
731
732 * doc.c (get_doc_string): Rework so that
733 get_doc_string_buffer_size is the actual buffer size, rather than
734 being 1 less than the actual buffer size; this makes xpalloc more
735 convenient.
736
737 * image.c (x_allocate_bitmap_record, cache_image):
738 * xselect.c (Fx_register_dnd_atom):
739 Simplify previous changes by using xpalloc.
740
741 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
742 since either will do and ptrdiff_t is convenient with xpalloc.
743
744 * charset.c (charset_table_size)
745 (struct charset_sort_data.priority): Now ptrdiff_t.
746 (charset_compare): Don't overflow if priorities differ greatly.
747 (Fsort_charsets): Don't assume list length fits in int.
748 Check for size-calculation overflow when allocating sort data.
749 (syms_of_charset): Allocate an initial charset table that is
750 just under 64 KiB, to avoid problems with glibc malloc and mmap.
751
752 * cmds.c (internal_self_insert): Check for size-calculation overflow.
753
754 * composite.h (struct composition.glyph_len): Now int, not unsigned.
755 The actual value is always <= INT_MAX, and leaving it unsigned made
756 overflow checking harder.
757
758 * dispextern.h (struct glyph_matrix.rows_allocated)
759 (struct face_cache.size): Now ptrdiff_t, for convenience in use
760 with xpalloc. The values are still always <= INT_MAX.
761
762 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
763
764 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
765 (SAFE_NALLOCA): New macro.
766
767 * region-cache.c (struct boundary.pos, find_cache_boundary)
768 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
769 (set_cache_region, invalidate_region_cache)
770 (revalidate_region_cache, know_region_cache, region_cache_forward)
771 (region_cache_backward, pp_cache):
772 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
773 so that ptrdiff_t * can be passed to xpalloc.
774 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
775 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
776 (pp_cache): Don't assume cache_len fits in int.
777 * region-cache.h: Adjust extern decls to match.
778
779 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
780 EMACS_INT, since either will do, for xpalloc.
781
782 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
783 (xnmalloc, xnrealloc, xpalloc): New functions.
784
785 * bidi.c (bidi_shelve_header_size): New constant.
786 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
787 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
788
789 * bidi.c (bidi_cache_shrink):
790 * buffer.c (overlays_at, overlays_in, record_overlay_string)
791 (overlay_strings):
792 Don't update size of array until after memory allocation succeeds,
793 because xmalloc/xrealloc may not return.
794 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
795 now that we have proper integer overflow checking.
796 (record_overlay_string, overlay_strings): Catch overflows when
797 calculating size of overlay_str_buf.
798
799 * callproc.c (Fcall_process): Check for size overflow when
800 calculating size of args2.
801 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
802 Normally we prefer signed values, but sticking with ptrdiff_t would
803 require adding more-complicated checks.
804
805 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
806 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
807 Redo buffer-overflow calculations to avoid integer overflow.
808 Add a FIXME comment where memory seems to be over-allocated.
809
810 * character.c (Fstring): Check for size-calculation overflow.
811
812 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
813 unnecessary integer overflow. Check for size overflow.
814 (encode_coding_object): Don't update size until xmalloc succeeds.
815
816 * composite.c (get_composition_id): Check for overflow in glyph
817 length calculations.
818
819 Integer and memory overflow fixes for display code.
820 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
821 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
822 (scrolling_window): Check for overflow in size calculations.
823 (line_draw_cost, realloc_glyph_pool, add_row_entry):
824 Don't assume glyph table len fits in int.
825 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
826 (row_table_size): Now ptrdiff_t, not int.
827 (scrolling_window): Avoid overflow in size calculations.
828 Don't update size until allocation succeeds.
829 * fns.c (concat): Check for overflow in size calculations.
830 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
831 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
832 (NEXT_ALMOST_PRIME_LIMIT): New constant.
833
834 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
835 (get_doc_string): Check for size calculation overflow.
836 Don't update size until allocation succeeds.
837 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
838 EMACS_INT, where ptrdiff_t will do.
839 (Fsubstitute_command_keys): Check for string overflow.
840
841 * editfns.c (set_time_zone_rule): Don't assume environment length
842 fits in int.
843 (message_length): Now ptrdiff_t, not int.
844 (Fmessage_box): Don't update size until allocation succeeds.
845 Don't assume message length fits in int.
846 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
847
848 * emacs.c (main): Do not reallocate argv, since there is a null at
849 the end that can be overwritten, and this way there's no need to
850 worry about size-calculation overflow.
851 (sort_args): Check for size-calculation overflow.
852
853 * eval.c (init_eval_once, grow_specpdl): Don't update size until
854 alloc succeeds.
855 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
856
857 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
858 (x_set_scroll_bar_width, x_figure_window_size):
859 Check for integer overflow.
860 (x_set_alpha): Do not assume XINT fits in int.
861
862 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
863 This is for the members text_lines, text_cols, total_lines, total_cols,
864 where the system imposes an 'int' limit.
865
866 * fringe.c (Fdefine_fringe_bitmap):
867 Don't update size until alloc works.
868
869 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
870 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
871
872 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
873 Check for size-calculation overflow.
874 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
875 do, as we prefer signed integers.
876 (id_to_widget.max_size, id_to_widget.used)
877 (xg_store_widget_in_map, xg_remove_widget_from_map)
878 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
879 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
880 Use and return ptrdiff_t, not int.
881 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
882 * gtkutil.h: Change prototypes to match the above.
883
884 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
885 are duplicate now that they've been promoted to lisp.h.
886 (x_allocate_bitmap_record, x_alloc_image_color)
887 (make_image_cache, cache_image, xpm_load):
888 Don't update size until alloc is done.
889 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
890 (x_detect_edges):
891 Check for size calculation overflow.
892 (ct_colors_allocated_max): New constant.
893 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
894 overflow.
895
896 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
897 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
898 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
899 Use ptrdiff_t, not int, to count maps.
900 (read_char_minibuf_menu_prompt): Check for overflow in size
901 calculations. Don't update size until allocation succeeds.
902 Redo calculations to avoid overflow.
903 * keyboard.h: Change prototypes to match the above.
904
905 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
906 to count maps.
907 (current_minor_maps): Check for size calculation overflow.
908 * keymap.h: Change prototypes to match the above.
909
910 * lread.c (read1, init_obarray): Don't update size until alloc done.
911
912 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
913 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
914
915 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
916 Now ptrdiff_t, not int.
917 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
918 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
919
920 * process.c (Fnetwork_interface_list): Check for overflow
921 in size calculation.
922
923 * region-cache.c (move_cache_gap): Check for size calculation overflow.
924
925 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
926 overflow. Don't bother calling xmalloc when xrealloc will do.
927
928 * search.c (Freplace_match): Check for size calculation overflow.
929 (Fset_match_data): Don't assume list lengths fit in 'int'.
930
931 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
932 for command line length. Do not attempt to address one before the
933 beginning of an array, as that's not portable.
934
935 * term.c (max_frame_lines): Remove; unused.
936 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
937 not int.
938 (encode_terminal_code, calculate_costs): Check for size
939 calculation overflow.
940 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
941 table lengths and related sizes. Don't update size until alloc
942 done. Redo calculations to avoid overflow.
943 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
944
945 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
946 subtracting pointers.
947 (gobble_line): Check for overflow more carefully. Don't update size
948 until alloc done.
949
950 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
951 Don't update size until alloc done.
952 Redo size calculations to avoid overflow.
953 Check for size calculation overflow.
954 (main) [DEBUG]: Fix typo in invoking tparam1.
955
956 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
957 Use ptrdiff_t, not int, for sizes.
958 (store_mode_line_noprop_char): Don't update size until alloc done.
959
960 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
961 Use ptrdiff_t, not int, for sizes.
962 (Finternal_make_lisp_face, cache_face):
963 Check for size calculation overflow.
964 (cache_face): Treat size calculation overflows as if they were
965 memory exhaustion (the usual treatment), rather than aborting.
966
967 * xfns.c (x_encode_text, x_set_name_internal)
968 (Fx_change_window_property): Use ptrdiff_t, not int, to count
969 sizes, since they can exceed INT_MAX in size. Check for size
970 calculation overflow.
971
972 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
973 (xg_select): Check for size calculation overflow.
974 Don't update size until alloc done.
975
976 * xrdb.c (get_environ_db): Don't assume path length fits in int,
977 as sprintf is limited to int lengths.
978
979 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
980 (X_LONG_MIN): New macros.
981 Use them to make the following changes clearer.
982 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
983 This change doesn't affect the value now, but it may help remind
984 future maintainers not to raise the value too much later.
985 (SELECTION_QUANTUM): Remove, replacing with ...
986 (selection_quantum): ... new function, which avoids overflow.
987 All uses changed.
988 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
989 assumption that selection length fits in 'int'.
990 (x_reply_selection_request, x_handle_selection_request)
991 (x_get_window_property, receive_incremental_selection)
992 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
993 (lisp_data_to_selection_data, clean_local_selection_data):
994 Use ptrdiff_t, not int, to record length of selection.
995 (x_reply_selection_request, x_get_window_property)
996 (receive_incremental_selection, x_property_data_to_lisp):
997 Redo calculations to avoid overflow.
998 (x_reply_selection_request): When sending hint, ceiling it at
999 X_LONG_MAX rather than relying on wraparound overflow to send
1000 something.
1001 (x_get_window_property, receive_incremental_selection)
1002 (lisp_data_to_selection_data, x_property_data_to_lisp):
1003 Check for size-calculation overflow.
1004 (x_get_window_property, receive_incremental_selection)
1005 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1006 Don't store size until memory allocation succeeds.
1007 (x_get_window_property): Plug memory leak on memory exhaustion.
1008 Don't double-block input; malloc is safe here. Don't assume 2**34
1009 - 4 fits in unsigned long. Add an xassert to check
1010 XGetWindowProperty overflow. Be more careful about overflow
1011 calculations, and distinguish size from memory overflow better.
1012 (receive_incremental_selection): When tracing, don't assume
1013 unsigned int is less than INT_MAX.
1014 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1015 harmful) conversions of unsigned short to int.
1016 (lisp_data_to_selection_data): Don't assume that integers
1017 in the range -65535 through -1 fit in an X unsigned short.
1018 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1019 result parameters unless successful. Rely on cons_to_unsigned
1020 to report problems with elements; the old code wasn't right anyway.
1021 (x_check_property_data): Check for int overflow; we cannot use
1022 a wider type due to X limits.
1023 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1024
1025 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1026
1027 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1028 (x_term_init): Check for size calculation overflow.
1029 (x_color_cells): Don't store size until memory allocation succeeds.
1030 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1031 Don't assume alloca size is less than MAX_ALLOCA.
1032 (x_term_init): Don't assume length fits in int (sprintf is limited
1033 to int size).
1034
1035 Use ptrdiff_t for composition IDs.
1036 * character.c (lisp_string_width):
1037 * composite.c (composition_table_size, n_compositions)
1038 (get_composition_id, composition_gstring_from_id):
1039 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1040 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1041 * window.c (Frecenter):
1042 Use ptrdiff_t, not int, for composition IDs.
1043 * composite.c (get_composition_id): Check for integer overflow.
1044 * composite.h: Adjust prototypes to match the above changes.
1045
1046 Use ptrdiff_t for hash table indexes.
1047 * category.c (hash_get_category_set):
1048 * ccl.c (ccl_driver):
1049 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1050 * coding.c (coding_system_charset_list, detect_coding_system):
1051 * coding.h (struct coding_system.id):
1052 * composite.c (get_composition_id, gstring_lookup_cache):
1053 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1054 * image.c (xpm_get_color_table_h):
1055 * lisp.h (hash_lookup, hash_put):
1056 * minibuf.c (Ftest_completion):
1057 Use ptrdiff_t for hash table indexes, not int (which is too
1058 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1059 32-bit --with-wide-int hosts).
1060
1061 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1062 Add a FIXME comment about memory leaks.
1063 (syms_of_charset): Don't assume xmalloc returns.
1064
1065 Don't assume that stated character widths fit in int.
1066 * character.c (Fchar_width, c_string_width, lisp_string_width):
1067 * character.h (CHAR_WIDTH):
1068 * indent.c (MULTIBYTE_BYTES_WIDTH):
1069 Use sanitize_char_width to avoid undefined and/or bad behavior
1070 with outlandish widths.
1071 * character.h (sanitize_tab_width): Rename from sanitize_width,
1072 now that we have two such functions. All uses changed.
1073 (sanitize_char_width): New inline function.
1074
1075 Don't assume that tab-width fits in int.
1076 * character.h (sanitize_width): New inline function.
1077 (SANE_TAB_WIDTH): New macro.
1078 (ASCII_CHAR_WIDTH): Use it.
1079 * indent.c (sane_tab_width): Remove. All uses replaced by
1080 SANE_TAB_WIDTH (current_buffer).
1081 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1082
1083 * fileio.c: Integer overflow issues with file modes.
1084 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1085
1086 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1087 Remove unreachable code.
1088 (read_hex, load_charset_map_from_file): Check for integer overflow.
1089
1090 * xterm.c: don't go over XClientMessageEvent limit
1091 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1092 (x_send_scroll_bar_event): Likewise. Check that the size does not
1093 exceed limits imposed by XClientMessageEvent, as well as the usual
1094 ptrdiff_t and size_t limits.
1095
1096 * keyboard.c: Overflow, signedness and related fixes.
1097 (make_lispy_movement): Use same integer type in forward decl
1098 that is used in the definition.
1099 (read_key_sequence, keyremap_step):
1100 Change bufsize argument back to int, undoing my 2011-03-30 change.
1101 We prefer signed types, and int is wide enough here.
1102 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1103 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1104 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1105 length, not size_t. Use ptrdiff_t for index, not int.
1106 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1107 possibility of integer overflow.
1108
1109 Overflow, signedness and related fixes for images.
1110
1111 * dispextern.h (struct it.stack[0].u.image.image_id)
1112 (struct_it.image_id, struct image.id, struct image_cache.size)
1113 (struct image_cache.used, struct image_cache.ref_count):
1114 * gtkutil.c (update_frame_tool_bar):
1115 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1116 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1117 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1118 * nsmenu.m (update_frame_tool_bar):
1119 * xdisp.c (calc_pixel_width_or_height):
1120 * xfns.c (image_cache_refcount):
1121 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1122 on typical 64-bit hosts.
1123
1124 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1125 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1126 Omit unnecessary casts to int.
1127 (parse_image_spec): Check that integers fall into 'int' range
1128 when the callers expect that.
1129 (image_ascent): Redo ascent calculation to avoid int overflow.
1130 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1131 (lookup_image): Remove unnecessary tests.
1132 (xbm_image_p): Locals are now of int, not EMACS_INT,
1133 since parse_image_check makes sure they fit into int.
1134 (png_load, gif_load, svg_load_image):
1135 Prefer int to unsigned where either will do.
1136 (tiff_handler): New function, combining the cores of the
1137 old tiff_error_handler and tiff_warning_handler.
1138 This function is rewritten to use vsnprintf and thereby avoid
1139 stack buffer overflows. It uses only the features of vsnprintf
1140 that are common to both POSIX and native Microsoft.
1141 (tiff_error_handler, tiff_warning_handler): Use it.
1142 (tiff_load, gif_load, imagemagick_load_image):
1143 Don't assume :index value fits in 'int'.
1144 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1145 (imagemagick_load_image): Check that crop parameters fit into
1146 the integer types that MagickCropImage accepts. Don't assume
1147 Vimagemagick_render_type has a nonnegative value. Don't assume
1148 size_t fits in 'long'.
1149 (gs_load): Use printmax_t to print the widest integers possible.
1150 Check for integer overflow when computing image height and width.
1151
1152 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (redisplay_window): Don't force window start if point
1155 will be invisible in the resulting window. (Bug#9324)
1156
1157 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1160 the display spec is of the form `(space ...)'.
1161 (handle_display_spec): Return the value returned by
1162 handle_single_display_spec, not just 1 or zero.
1163 (handle_single_display_spec): If the display spec is of the form
1164 `(space ...)', and specifies display in the text area, return 2
1165 rather than 1.
1166 (try_cursor_movement): Check for the need to scroll more
1167 accurately, and prefer exact match for point under bidi.
1168 Don't advance `row' beyond the last row of the window.
1169
1170 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1171 into disp_prop; all users changed.
1172
1173 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1174 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1175 for the text covered by the display property.
1176
1177 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1178
1179 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1180 Change return value to nil.
1181 (Frecord_buffer): Delete unused function.
1182
1183 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1186 buffers, return left-to-right.
1187 (set_cursor_from_row): Consider candidate row a win if its glyph
1188 represents a newline and point is on that newline. Fixes cursor
1189 positioning on the newline at EOL of R2L text within L2R
1190 paragraph, and vice versa.
1191 (try_cursor_movement): Check continued rows, in addition to
1192 continuation rows. Fixes unwarranted scroll when point enters a
1193 continued line of R2L text within an L2R paragraph, or vice versa.
1194 (cursor_row_p): Consider the case of point being equal to
1195 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1196 from the end of a short line to the beginning of a continued line
1197 of R2L text within L2R paragraph.
1198 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1199 composed characters.
1200
1201 * bidi.c (bidi_check_type): Use xassert.
1202 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1203 members.
1204
1205 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1206
1207 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1208 a character.
1209
1210 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1211
1212 * nsfont.m (ns_otf_to_script): Fix typo.
1213
1214 2011-08-22 Kenichi Handa <handa@m17n.org>
1215
1216 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1217 extra slot even if the purpose is char-code-property-table.
1218
1219 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1220
1221 * xdisp.c (redisplay_window): When computing centering_position,
1222 account for the height of the header line. (Bug#8874)
1223
1224 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1225 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1226 candidate is selected by the mouse, and that candidate has a
1227 composed character under the mouse.
1228
1229 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1230 coordinates reported by pos-visible-in-window-p for a composed
1231 character in column zero.
1232
1233 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1234
1235 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1236
1237 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1240 consider it a hit if to_charpos is anywhere in the range of the
1241 composed buffer positions.
1242
1243 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1244
1245 * image.c (gif_load): Don't assume that each subimage has the same
1246 dimensions as the base image. Handle disposal method that is
1247 "undefined" by the gif spec (Bug#9335).
1248
1249 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1252 (Fcondition_case): Document `debug' symbol in error handler.
1253
1254 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1255
1256 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1257 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1258 from an Org mode buffer to a Speedbar frame.
1259
1260 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1261 a composition, take its buffer position from IT->cmp_it.charpos.
1262 Fixes cursor positioning at the beginning of a line that begins
1263 with a composed character.
1264
1265 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1266
1267 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1268 character bidirectional type, use STRONG_L instead. Fixes crashes
1269 in a buffer produced by `describe-categories'.
1270
1271 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1272 members before the level stack, so they would be saved and
1273 restored when copying iterator state. Fixes incorrect reordering
1274 around TABs covered by display properties.
1275
1276 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * process.c (Fnetwork_interface_list): Correctly determine buffer
1279 size.
1280
1281 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * eval.c (internal_condition_case, internal_condition_case_1)
1284 (internal_condition_case_2, internal_condition_case_n):
1285 Remove unnecessary aborts (Bug#9081).
1286
1287 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1288
1289 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1290 has no `load' handler, try opening the file locally. (Bug#9311)
1291
1292 2011-08-16 Ken Brown <kbrown@cornell.edu>
1293
1294 * gmalloc.c: Expand comment.
1295
1296 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1299 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1300
1301 2011-08-16 Ken Brown <kbrown@cornell.edu>
1302
1303 Fix memory allocation problems in Cygwin build (Bug#9273).
1304
1305 * unexcw.c ( __malloc_initialized): Declare external variable.
1306 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1307
1308 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1309 New variables.
1310 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1311 dumped emacs.
1312 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1313 in the static heap.
1314 [CYGWIN] (special_realloc): New function.
1315 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1316 requests to realloc storage in the static heap.
1317
1318 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * bidi.c (bidi_initialize): Remove unused local.
1321
1322 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1323
1324 * biditype.h: File removed.
1325
1326 * bidimirror.h: File removed.
1327
1328 * deps.mk (bidi.o): Remove biditype.h and
1329 bidimirror.h.
1330
1331 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1332 bidimirror.h.
1333
1334 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1335
1336 * chartab.c: Improve commentary for the uniprop_table API.
1337
1338 * bidi.c (bidi_paragraph_init): Support zero value of
1339 bidi_ignore_explicit_marks_for_paragraph_level.
1340 (bidi_initialize): Use uniprop_table instead of including
1341 biditype.h and bidimirror.h.
1342
1343 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1344 coordinates of the iterator when restoring from ppos_it.
1345 (Bug#9296)
1346
1347 2011-08-14 Kenichi Handa <handa@m17n.org>
1348
1349 * process.c (create_process): Call setup_process_coding_systems
1350 after the pid of the process is set to -1 (Bug#8162).
1351
1352 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (move_it_in_display_line_to): Don't invoke
1355 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1356 ppos_it. Fixes vertical cursor motion when line beginning is
1357 covered by an image. (Bug#9296)
1358
1359 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1360
1361 * nsterm.h (ns_run_ascript): Declare.
1362 (NSAPP_DATA2_RUNASSCRIPT): Define.
1363
1364 * nsfns.m (as_script, as_result, as_status): New static variables.
1365 (ns_run_ascript): New function.
1366 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1367 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1368 the event loop. Get status from as_status (Bug#7276).
1369
1370 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1371 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1372 the event loop (Bug#7276).
1373
1374 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1375
1376 * gnutls.c (QCgnutls_bootprop_priority)
1377 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1378 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1379 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1380 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1381 (QCgnutls_bootprop_verify_hostname_error)
1382 (QCgnutls_bootprop_callbacks_verify): Rename from
1383 Qgnutls_bootprop_..., all uses changed.
1384
1385 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1386 uses changed.
1387
1388 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 * xfaces.c (Qframe_set_background_mode): Now static.
1391 * dispextern.h (Qframe_set_background_mode): Remove decl.
1392
1393 * process.c (Fnetwork_interface_info): Declare local only if needed.
1394
1395 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1396
1397 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1398 (Fnetwork_interface_list): Allocate in increments of bytes instead
1399 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1400 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1401 sockaddr.
1402 (struct ifflag_def): notrailers is smart on OSX.
1403 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1404 Get hardware address with getifaddrs if available.
1405
1406 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (iterate_out_of_display_property): xassert that
1409 IT->position is set to within IT->object's boundaries. Break from
1410 the loop as soon as EOB is reached; avoids infloops in redisplay
1411 when IT->position is set up wrongly due to some bug.
1412 Set IT->current to match the bidi iterator unconditionally.
1413 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1414 entry. Force push_it to save on the stack the current
1415 buffer/string position, to be restored by pop_it. Fix flags in
1416 the iterator structure wrt the object coming from a display
1417 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1418 properties. (Bug#9284)
1419
1420 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1421
1422 * fontset.c (fontset_get_font_group): Add proper type checks.
1423 (Bug#9172)
1424
1425 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1426
1427 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1428 and LC_VERSION_MIN_MACOSX.
1429 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1430 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1431
1432 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1433
1434 * xdisp.c (forward_to_next_line_start): Allow to use the
1435 no-display-properties-and-no-overlays under bidi display.
1436 Set disp_pos in the bidi iterator to avoid searches for display
1437 properties and overlays.
1438
1439 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1440
1441 * editfns.c (Fset_time_zone_rule): Document relationship with the
1442 setenv function.
1443
1444 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1445 the font entity extracted from the cache (Bug#8109).
1446
1447 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1448
1449 * composite.c (autocmp_chars): Don't reset point. That is done by
1450 restore_point_unwind (Bug#5984).
1451
1452 2011-08-07 Juri Linkov <juri@jurta.org>
1453
1454 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1455 to show the arg `TIME' instead of `TIMEVAL'.
1456
1457 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1460 display property strides EOL and includes a newline, as in
1461 longlines-mode. (Bug#9254)
1462 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1463 word-wrap under bidirectional display. (Bug#9224)
1464
1465 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1466 is non-zero, even if the data buffer is NULL. Fixes a crash in
1467 vertical-motion with longlines-mode. (Bug#9254)
1468
1469 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1470
1471 * bidi.c <bidi_cache_total_alloc>: Now static.
1472 (bidi_initialize): Initialize bidi_cache_total_alloc.
1473
1474 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1475 cache. (Bug#9221)
1476
1477 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1478 amount allocated this far in `bidi_cache_total_alloc'.
1479 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1480 non-zero, only free the data buffer without restoring the cache
1481 contents. All callers changed.
1482
1483 * dispextern.h (bidi_unshelve_cache): Update prototype.
1484
1485 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1486 (move_it_in_display_line, move_it_to)
1487 (move_it_vertically_backward, move_it_by_lines): Replace the call
1488 to xfree to an equivalent call to bidi_unshelve_cache.
1489 (move_it_in_display_line_to): Fix logic of returning
1490 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1491
1492 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1493
1494 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1495 came from a string character with a `cursor' property. (Bug#9229)
1496
1497 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1498
1499 * Makefile.in (LIB_PTHREAD): New variable.
1500 (LIBES): Add LIB_PTHREAD (Bug#9216).
1501
1502 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1503 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1504
1505 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1506
1507 * regex.c (re_iswctype): Remove some redundant boolean
1508 conversions.
1509
1510 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1511
1512 * xterm.c (x_find_topmost_parent): New function.
1513 (x_set_frame_alpha): Find topmost parent window with
1514 x_find_topmost_parent and set the property there also (bug#9181).
1515 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1516
1517 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * callproc.c (Fcall_process): Avoid vfork clobbering
1520 the local vars buffer, coding_systems, current_dir.
1521
1522 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1523
1524 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1525
1526 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1529 so that it is not optimized away.
1530
1531 * xdisp.c (compute_display_string_pos): Remove unused local.
1532
1533 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1534
1535 Fix slow cursor motion and scrolling in large buffers with
1536 selective display, like Org Mode buffers. (Bug#9218)
1537
1538 * dispextern.h (struct bidi_it): New member disp_prop_p.
1539
1540 * xdisp.c: Remove one-slot cache of display string positions.
1541 (compute_display_string_pos): Accept an additional argument
1542 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1543 for a display string or property. If found, set DISP_PROP_P
1544 non-zero.
1545
1546 * bidi.c (bidi_fetch_char): Accept an additional argument
1547 DISP_PROP_P, and pass it to compute_display_string_pos.
1548 Only handle text covered by a display string if DISP_PROP_P is returned
1549 non-zero. All callers of bidi_fetch_char changed.
1550
1551 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1554
1555 2010-12-03 Don March <don@ohspite.net>
1556
1557 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1558 last character M-[char] is translated to ESC [char] (bug#7541).
1559
1560 2011-08-02 Kenichi Handa <handa@m17n.org>
1561
1562 * lisp.h (uniprop_table): Extern it.
1563
1564 * chartab.c (uniprop_table): Make it non-static.
1565
1566 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1567
1568 * xdisp.c (forward_to_next_line_start): Accept additional argument
1569 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1570 on the newline.
1571 (reseat_at_next_visible_line_start): Use the bidi iterator state
1572 returned by forward_to_next_line_start to restore the state of
1573 it->bidi_it after backing up to previous newline. (Bug#9212)
1574
1575 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1576
1577 * regex.c (re_comp): Protoize.
1578 (re_exec): Fix return type.
1579 (regexec): Fix type of `ret'. (Bug#9203)
1580
1581 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1584 This is needed if max-image-size is a floating-point number.
1585
1586 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1587
1588 * print.c (print_object): Print empty symbol as ##.
1589
1590 * lread.c (read1): Read ## as empty symbol.
1591
1592 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1593
1594 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1595 setting frame foreground color (Bug#9175).
1596 (x_set_background_color): Likewise.
1597
1598 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1599 contents (Bug#9176).
1600 (EmacsTooltip -init): Remove bezels and add shadows to
1601 tooltip windows.
1602
1603 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1604 or scroll bar (Bug#8470).
1605
1606 * nsfont.m (nsfont_open): Remove assignment to voffset and
1607 unnecessary vars hshink, expand, hd, full_height, min_height.
1608 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1609
1610 * nsterm.h (nsfont_info): Remove voffset field.
1611
1612 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1613
1614 Implement strike-through and overline on NextStep (Bug#8863).
1615
1616 * nsfont.m (nsfont_open): Use underline position provided by font,
1617 instead of hard-coded value of 2.
1618 (nsfont_draw): Call ns_draw_text_decoration instead.
1619
1620 * nsterm.h: Add declaration for ns_draw_text_decoration.
1621
1622 * nsterm.m (ns_draw_text_decoration): New function for drawing
1623 underline, overline, and strike-through.
1624 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1625 ns_draw_text_decoration. Change treatment of cursor drawing to
1626 accommodate underlining, etc.
1627
1628 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1629
1630 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1631 default.
1632
1633 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1636 Without this fix, if a signal arrives just after memory fills up,
1637 'malloc' might be invoked reentrantly.
1638
1639 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1640 In other words, assume that every image size is allowed, on non-X
1641 hosts. This assumption is probably wrong, but it lets Emacs compile.
1642
1643 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1644
1645 * regex.c (re_iswctype): Convert return values to boolean.
1646
1647 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1648
1649 * xdisp.c (compute_display_string_pos): Don't use cached display
1650 string position if the buffer had its restriction changed.
1651 (Bug#9184)
1652
1653 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1656
1657 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 Integer signedness and overflow and related fixes. (Bug#9079)
1660
1661 * bidi.c: Integer size and overflow fixes.
1662 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1663 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1664 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1665 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1666 (bidi_find_other_level_edge):
1667 Use ptrdiff_t instead of EMACS_INT where either will do.
1668 This works better on 32-bit hosts configured --with-wide-int.
1669 (bidi_cache_ensure_space): Check for size-calculation overflow.
1670 Use % rather than repeated addition, for better worst-case speed.
1671 Don't set bidi_cache_size until after xrealloc returns, because it
1672 might not return.
1673 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1674 (bidi_cache_ensure_space): Also check that the bidi cache size
1675 does not exceed that of the largest Lisp string or buffer. See Eli
1676 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1677
1678 * alloc.c (__malloc_size_t): Remove.
1679 All uses replaced by size_t. See Andreas Schwab's note
1680 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1681
1682 * image.c: Improve checking for integer overflow.
1683 (check_image_size): Assume that f is nonnull, since
1684 it is always nonnull in practice. This is one less thing to
1685 worry about when checking for integer overflow later.
1686 (x_check_image_size): New function, which checks for integer
1687 overflow issues inside X.
1688 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1689 This removes the need for a memory_full check.
1690 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1691 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1692 (xbm_read_bitmap_data): Change locals back to 'int', since
1693 their values must fit in 'int'.
1694 (xpm_load_image, png_load, tiff_load):
1695 Invoke x_create_x_image_and_pixmap earlier,
1696 to avoid much needless work if the image is too large.
1697 (tiff_load): Treat overly large images as if
1698 x_create_x_image_and_pixmap failed, not as malloc failures.
1699 (gs_load): Use x_check_image_size.
1700
1701 * gtkutil.c: Omit integer casts.
1702 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1703 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1704
1705 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1706
1707 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1708 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1709 would wrongly return t on a 64-bit host.
1710
1711 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1712 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1713 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1714 and therefore cause GCC to emit a bogus diagnostic in some cases.
1715
1716 * image.c: Integer signedness and overflow and related fixes.
1717 This is not an exhaustive set of fixes, but it's time to
1718 record what I've got.
1719 (lookup_pixel_color, check_image_size): Remove redundant decls.
1720 (check_image_size): Don't assume that arbitrary EMACS_INT values
1721 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1722 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1723 (tiff_load, imagemagick_load_image):
1724 Check for overflow in size calculations.
1725 (x_create_x_image_and_pixmap): Remove unnecessary test for
1726 xmalloc returning NULL; that can't happen.
1727 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1728 (xpm_color_bucket): Use better integer hashing function.
1729 (xpm_cache_color): Don't possibly over-allocate memory.
1730 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1731 (gif_memory_source):
1732 Use ptrdiff_t, not int or size_t, to record sizes.
1733 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1734 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1735 either works, as we prefer signed integers.
1736 (tiff_read_from_memory, tiff_write_from_memory):
1737 Return tsize_t, not size_t, since that's what the TIFF API wants.
1738 (tiff_read_from_memory): Don't fail simply because the read would
1739 go past EOF; instead, return a short read.
1740 (tiff_load): Omit no-longer-needed casts.
1741 (Fimagemagick_types): Don't assume size fits into 'int'.
1742
1743 Improve hashing quality when configured --with-wide-int.
1744 * fns.c (hash_string): New function, taken from sxhash_string.
1745 Do not discard information about ASCII character case; this
1746 discarding is no longer needed.
1747 (sxhash-string): Use it. Change sig to match it. Caller changed.
1748 * lisp.h: Declare it.
1749 * lread.c (hash_string): Remove, since we now use fns.c's version.
1750 The fns.c version returns a wider integer if --with-wide-int is
1751 specified, so this should help the quality of the hashing a bit.
1752
1753 * emacs.c: Integer overflow minor fix.
1754 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1755 Define only if GNU_LINUX.
1756 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1757
1758 * dispnew.c: Integer signedness and overflow fixes.
1759 Remove unnecessary forward decls, that were a maintenance hassle.
1760 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1761 All uses changed.
1762 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1763 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1764 (prepare_desired_row, line_draw_cost):
1765 Use int, not unsigned, where either works.
1766 (save_current_matrix, restore_current_matrix):
1767 Use ptrdiff_t, not size_t, where either works.
1768 (init_display): Check for overflow more accurately, and without
1769 relying on undefined behavior.
1770
1771 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1772 Remove, replacing with the new symbols in lisp.h. All uses changed.
1773 * fileio.c (make_temp_name):
1774 * filelock.c (lock_file_1, lock_file):
1775 * xdisp.c (message_dolog):
1776 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1777 Use pMd etc. instead.
1778 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1779 replacing the pWIDE etc. symbols removed from editfns.c.
1780
1781 * keyboard.h (num_input_events): Now uintmax_t.
1782 This is (very slightly) less likely to mess up due to wraparound.
1783 All uses changed.
1784
1785 * buffer.c: Integer signedness fixes.
1786 (alloc_buffer_text, enlarge_buffer_text):
1787 Use ptrdiff_t rather than size_t when either will do, as we prefer
1788 signed integers.
1789
1790 * alloc.c: Integer signedness and overflow fixes.
1791 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1792 (__malloc_size_t): Default to size_t, not to int.
1793 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1794 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1795 Prefer ptrdiff_t to size_t when either would do, as we prefer
1796 signed integers.
1797 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1798 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1799 Now const. Initialize with values that are in range even if char
1800 is signed.
1801 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1802 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1803 These functions do the right thing with sizes > 2**32.
1804 (check_depth): Now ptrdiff_t, not int.
1805 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1806 Adjust to new way of storing sizes. Check for size overflow bugs
1807 in rest of code.
1808 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1809 slightly wrong anyway, as it missed one instance of
1810 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1811 (refill_memory_reserve): Omit needless cast to size_t.
1812 (mark_object_loop_halt): Mark as externally visible.
1813
1814 * xselect.c: Integer signedness and overflow fixes.
1815 (Fx_register_dnd_atom, x_handle_dnd_message):
1816 Use ptrdiff_t, not size_t, since we prefer signed.
1817 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1818 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1819 x_dnd_atoms_size and x_dnd_atoms_length.
1820
1821 * doprnt.c: Prefer signed to unsigned when either works.
1822 * eval.c (verror):
1823 * doprnt.c (doprnt):
1824 * lisp.h (doprnt):
1825 * xdisp.c (vmessage):
1826 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1827 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1828 prefer signed arithmetic to avoid comparison confusion.
1829 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1830 but is a bit tricky.
1831
1832 Assume freestanding C89 headers, string.h, stdlib.h.
1833 * data.c, doprnt.c, floatfns.c, print.c:
1834 Include float.h unconditionally.
1835 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1836 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1837 * regex.c: Likewise for stddef.h, string.h.
1838 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1839 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1840 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1841 (STDC_HEADERS): Remove obsolete defines.
1842 * sysdep.c: Include limits.h unconditionally.
1843
1844 Assume support for memcmp, memcpy, memmove, memset.
1845 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1846 * regex.c (memcmp, memcpy):
1847 Remove; we assume C89 now.
1848
1849 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1850 (__malloc_safe_bcopy): Remove; no longer needed.
1851
1852 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1853 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1854 well either way, and we prefer signed to unsigned.
1855
1856 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1857
1858 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1859 closes the connection while we're reading (bug#9182).
1860
1861 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1862
1863 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1864 are specified (Bug#9168).
1865
1866 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1869 Found by GCC static checking and --with-wide-int on a 32-bit host.
1870
1871 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1872
1873 * xdisp.c (compute_display_string_pos): Fix logic of caching
1874 previous display string position. Initialize cached_prev_pos to
1875 -1. Fixes slow-down at the beginning of a buffer.
1876
1877 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1880 for attrs[LFACE_FONTSET_INDEX].
1881
1882 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * xml.c (parse_region): Remove unused local
1885 that was recently introduced.
1886
1887 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1888
1889 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1890 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1891
1892 * xdisp.c (move_it_in_display_line_to): Record the best matching
1893 position for TO_CHARPOS while scanning the line, and restore it on
1894 exit if none of the characters scanned was an exact match.
1895 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1896 when exact match is impossible due to invisible text, and the
1897 lines are truncated.
1898
1899 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1900
1901 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1902 for OSX >= 10.7.
1903
1904 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1905
1906 Fix a significant slow-down of cursor motion with C-n, C-p,
1907 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1908 auto-repeat under bidi redisplay in fontified buffers.
1909 * xdisp.c (compute_stop_pos_backwards): New function.
1910 (next_element_from_buffer): Call compute_stop_pos_backwards to
1911 find a suitable prev_stop when we find ourselves before
1912 base_level_stop.
1913 (reseat): Don't look for prev_stop, as that could mean a very long
1914 run.
1915 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1916 <cached_disp_overlay_modiff>: Cache for last found display string
1917 position.
1918 (compute_display_string_pos): Return the cached position if asked
1919 about the same buffer in the same area of character positions, and
1920 the buffer wasn't changed since the time the display string
1921 position was cached.
1922
1923 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1926 is an integer, which is important for empty lines. (Bug#9149)
1927
1928 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1929
1930 * frame.c (Fmodify_frame_parameters): In tty case, update the
1931 default face if necessary (Bug#4238).
1932
1933 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * editfns.c (Fstring_to_char): No need to explain what a character
1936 is in the docstring (Bug#6576).
1937
1938 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1939
1940 * xml.c (parse_region): Make sure we always return a tree.
1941
1942 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1943
1944 * xml.c (parse_region): If a document contains only comments,
1945 return that, too.
1946
1947 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1948
1949 * xml.c (make_dom): Return comments, too.
1950
1951 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Port to OpenBSD.
1954 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1955 and the surrounding thread.
1956 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1957 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1958 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1959 timer goes off.
1960 * s/openbsd.h (BROKEN_SIGIO): Define.
1961 * unexelf.c (unexec) [__OpenBSD__]:
1962 Don't update the .mdebug section of the Alpha COFF symbol table.
1963
1964 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1965
1966 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1967 (bug#8460).
1968
1969 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1972 This fixes some race conditions on the permissions of any newly
1973 created file.
1974
1975 * alloc.c (valid_pointer_p): Use pipe, not open.
1976 This fixes some permissions issues when debugging.
1977
1978 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1979 If fchown fails to set both uid and gid, try to set just gid,
1980 as that is sometimes allowed. Adjust the file's mode to eliminate
1981 setuid or setgid bits that are inappropriate if fchown fails.
1982
1983 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1984
1985 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1986 to compare Lisp_Objects.
1987 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1988 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1989 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1990
1991 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * lread.c (read_integer): Unread even EOF character.
1994 (read1): Likewise. Properly record start position of symbol.
1995
1996 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1997 symbol character follows.
1998
1999 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2002 This works around a problem with the previous change to Fcopy_file.
2003 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2004 and without this change, GCC might complain about discarding
2005 fchown's return value.
2006
2007 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2010
2011 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2014
2015 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2016
2017 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2018 it's used from the C level.
2019
2020 * process.c: Use the same condition for POLL_FOR_INPUT in both
2021 keyboard.c and process.c (bug#1858).
2022
2023 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2024
2025 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2026 (Fgnutls_boot): Use it.
2027
2028 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2029
2030 * doc.c (Fsubstitute_command_keys): Revert last change.
2031
2032 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2033
2034 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2035 quotes the next character, and doesn't affect other longer
2036 sequences (bug#8935).
2037
2038 * lread.c (syms_of_lread): Clarify that is isn't only
2039 `eval-buffer' and `eval-defun' that's affected by
2040 `lexical-binding' (bug#8460).
2041
2042 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2043
2044 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2045 bidi redisplay when a line includes both an image and is
2046 truncated.
2047
2048 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Fix minor problems found by static checking.
2051 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2052 (elsz): Now a signed constant, not a size_t var. We prefer signed
2053 types to unsigned, to avoid integer comparison confusion. Without
2054 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2055 "cannot optimize loop, the loop counter may overflow", a symptom
2056 of the confusion.
2057 * indent.c (Fvertical_motion): Mark locals as initialized.
2058 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2059
2060 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2061
2062 * search.c (Fre_search_backward): Mention `case-fold-search' in
2063 all the re_search_* functions (bug#8138).
2064
2065 * keyboard.c (Fopen_dribble_file): Document when the file is
2066 closed (bug#8056).
2067
2068 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2069
2070 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2071 bidi_cache_idx.
2072
2073 Support bidi reordering of display and overlay strings.
2074 * xdisp.c (compute_display_string_pos)
2075 (compute_display_string_end): Accept additional argument STRING.
2076 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2077 (reseat_to_string): Initialize bidi_it->string.s and
2078 bidi_it->string.schars.
2079 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2080 NULL (avoids a crash in bidi_paragraph_init).
2081 Initialize itb.string.lstring.
2082 (init_iterator): Call bidi_init_it only of a valid
2083 buffer position was specified. Initialize paragraph_embedding to
2084 L2R.
2085 (reseat_to_string): Initialize the bidi iterator.
2086 (display_string): If we need to ignore text properties of
2087 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2088 original value of -1 will not work with bidi.)
2089 (compute_display_string_pos): First arg is now struct
2090 `text_pos *'; all callers changed. Support display properties on
2091 Lisp strings.
2092 (compute_display_string_end): Support display properties on Lisp
2093 strings.
2094 (init_iterator, reseat_1, reseat_to_string): Initialize the
2095 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2096 when iterating on a string not from display properties).
2097 (compute_display_string_pos, compute_display_string_end):
2098 Fix calculation of the object to scan. Fixes an error when using
2099 arrow keys.
2100 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2101 base_level_stop; instead, set base_level_stop to BEGV.
2102 Fixes crashes in vertical-motion.
2103 (next_element_from_buffer): Improve commentary for when
2104 the iterator is before prev_stop.
2105 (init_iterator): Initialize bidi_p from the default value of
2106 bidi-display-reordering, not from buffer-local value. Use the
2107 buffer-local value only if initializing for buffer iteration.
2108 (handle_invisible_prop): Support invisible properties on strings
2109 that are being bidi-reordered.
2110 (set_iterator_to_next): Support bidi reordering of C strings and
2111 Lisp strings.
2112 (next_element_from_string): Support bidi reordering of Lisp
2113 strings.
2114 (handle_stop_backwards): Support Lisp strings as well.
2115 (display_string): Support display of R2L glyph rows.
2116 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2117 (init_iterator): Don't initialize it->bidi_p for strings
2118 here.
2119 (reseat_to_string): Initialize it->bidi_p for strings here.
2120 (next_element_from_string, next_element_from_c_string)
2121 (next_element_from_buffer): Add xassert's for correspondence
2122 between IT's object being iterated and it->bidi_it.string
2123 structure.
2124 (face_before_or_after_it_pos): Support bidi iteration.
2125 (next_element_from_c_string): Handle the case of the first string
2126 character that is not the first one in the visual order.
2127 (get_visually_first_element): New function, refactored from common
2128 parts of next_element_from_buffer, next_element_from_string, and
2129 next_element_from_c_string.
2130 (tool_bar_lines_needed, redisplay_tool_bar)
2131 (display_menu_bar): Force left-to-right direction. Add a FIXME
2132 comment for making that be controlled by a user option.
2133 (push_it, pop_it): Save and restore the state of the
2134 bidi iterator. Save and restore the bidi_p flag.
2135 (pop_it): Iterate out of display property for string iteration as
2136 well.
2137 (iterate_out_of_display_property): Support iteration over strings.
2138 (handle_single_display_spec): Set up it->bidi_it for iteration
2139 over a display string, and call bidi_init_it.
2140 (handle_single_display_spec, next_overlay_string)
2141 (get_overlay_strings_1, push_display_prop): Set up the bidi
2142 iterator for displaying display or overlay strings.
2143 (forward_to_next_line_start): Don't use the shortcut if
2144 bidi-iterating.
2145 (back_to_previous_visible_line_start): If handle_display_prop
2146 pushed the iterator stack, restore the internal state of the bidi
2147 iterator by calling bidi_pop_it same number of times.
2148 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2149 and we are bidi-iterating, don't decrement the iterator position;
2150 instead, set the first_elt flag in the bidi iterator, to produce
2151 the same effect.
2152 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2153 (push_display_prop): xassert that we are iterating a buffer.
2154 (push_it, pop_it): Save and restore paragraph_embedding member.
2155 (handle_single_display_spec, next_overlay_string)
2156 (get_overlay_strings_1, reseat_1, reseat_to_string)
2157 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2158 correctly. Don't assume unibyte strings are not bidi-reordered.
2159 (compute_display_string_pos)
2160 (compute_display_string_end): Fix handling the case of C string.
2161 (push_it, pop_it): Save and restore from_disp_prop_p.
2162 (handle_single_display_spec, push_display_prop): Set the
2163 from_disp_prop_p flag.
2164 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2165 (pop_it): Call iterate_out_of_display_property only if we are
2166 popping after iteration over a string that came from a display
2167 property. Fix a typo in popping stretch info. Add an assertion
2168 for verifying that the iterator position is in sync with the bidi
2169 iterator.
2170 (handle_single_display_spec, get_overlay_strings_1)
2171 (push_display_prop): Fix initialization of paragraph direction for
2172 string when that of the parent object is not yet determined.
2173 (reseat_1): Call bidi_init_it to resync the bidi
2174 iterator with IT's position. (Bug#7616)
2175 (find_row_edges): If ROW->start.pos gives position
2176 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2177 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2178 Reset the from_disp_prop_p flag.
2179 (SAVE_IT, RESTORE_IT): New macros.
2180 (pos_visible_p, face_before_or_after_it_pos)
2181 (back_to_previous_visible_line_start)
2182 (move_it_in_display_line_to, move_it_in_display_line)
2183 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2184 (try_scrolling, redisplay_window, display_line): Use them when
2185 saving a temporary copy of the iterator and restoring it back.
2186 (back_to_previous_visible_line_start, reseat_1)
2187 (init_iterator): Empty the bidi cache "stack".
2188 (move_it_in_display_line_to): If iterator ended up at
2189 EOL, but we never saw any buffer positions smaller than
2190 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2191 motion in bidi-reordered lines.
2192 (move_it_in_display_line_to): Record prev_method and prev_pos
2193 immediately before the call to set_iterator_to_next. Fixes cursor
2194 motion in bidi-reordered lines with stretch glyphs and strings
2195 displayed in margins. (Bug#8133) (Bug#8867)
2196 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2197 TO_CHARPOS.
2198 (pos_visible_p): Support positions in bidi-reordered lines.
2199 Save and restore bidi cache.
2200
2201 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2202 (bidi_paragraph_info): Delete unused struct.
2203 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2204 (bidi_cache_start): New variable.
2205 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2206 to zero.
2207 (bidi_cache_fetch_state, bidi_cache_search)
2208 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2209 (bidi_cache_find, bidi_peek_at_next_level)
2210 (bidi_level_of_next_char, bidi_find_other_level_edge)
2211 (bidi_move_to_visually_next): Compare cache index with
2212 bidi_cache_start rather than with zero.
2213 (bidi_fetch_char): Accept new argument STRING; all callers
2214 changed. Support iteration over a string. Support strings with
2215 display properties. Support unibyte strings. Fix the type of
2216 `len' according to what STRING_CHAR_AND_LENGTH expects.
2217 (bidi_paragraph_init, bidi_resolve_explicit_1)
2218 (bidi_resolve_explicit, bidi_resolve_weak)
2219 (bidi_level_of_next_char, bidi_move_to_visually_next):
2220 Support iteration over a string.
2221 (bidi_set_sor_type, bidi_resolve_explicit_1)
2222 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2223 can now be zero (for strings); special values 0 and -1 were
2224 changed to -1 and -2, respectively.
2225 (bidi_char_at_pos): New function.
2226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2227 Call it instead of FETCH_MULTIBYTE_CHAR.
2228 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2229 initialized to valid values.
2230 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2231 values.
2232 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2233 the test for valid cached positions. Fix the logic for looking up
2234 the sentinel state in the cache. GCPRO the Lisp string we are
2235 iterating.
2236 (bidi_push_it, bidi_pop_it): New functions.
2237 (bidi_initialize): Initialize the bidi cache start stack pointer.
2238 (bidi_cache_ensure_space): New function, refactored from part of
2239 bidi_cache_iterator_state. Don't assume the required size is just
2240 one BIDI_CACHE_CHUNK away.
2241 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2242 (bidi_count_bytes, bidi_char_at_pos): New functions.
2243 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2244 always valid if bidi_cache_idx is valid.
2245 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2246 is valid if it's going to be used.
2247 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2248 (bidi_cache_fetch_state, bidi_cache_search)
2249 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2250 (bidi_cache_iterator_state, bidi_cache_find)
2251 (bidi_find_other_level_edge, bidi_cache_start_stack):
2252 All variables related to cache indices are now EMACS_INT.
2253
2254 * dispextern.h (struct bidi_string_data): New structure.
2255 (struct bidi_it): New member `string'. Make flag members be 1-bit
2256 fields, and put them last in the struct.
2257 (compute_display_string_pos, compute_display_string_end):
2258 Update prototypes.
2259 (bidi_push_it, bidi_pop_it): Add prototypes.
2260 (struct iterator_stack_entry): New members bidi_p,
2261 paragraph_embedding, and from_disp_prop_p.
2262 (struct it): Member bidi_p is now a bit field 1 bit wide.
2263 (bidi_shelve_cache, bidi_unshelve_cache):
2264 Declare prototypes.
2265
2266 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2267 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2268 and vector-like objects.
2269
2270 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2271 cache around display iteration.
2272
2273 * window.c (Fwindow_end, window_scroll_pixel_based)
2274 (displayed_window_lines, Frecenter): Save and restore the bidi
2275 cache around display iteration.
2276
2277 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2278
2279 * editfns.c (Fdelete_region): Clarify the use of the named
2280 parameters (bug#6788).
2281
2282 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2283
2284 * indent.c (Fvertical_motion): Set and restore w->pointm when
2285 saving and restoring the window's buffer (Bug#9006).
2286
2287 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
2289 * editfns.c (Fstring_to_char): Clarify just what is returned
2290 (bug#6576). Text by Eli Zaretskii.
2291
2292 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2293
2294 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2295
2296 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2297
2298 * buffer.c (mmap_find): Fix a typo.
2299
2300 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2301
2302 Fix execution of x selection hooks.
2303 * xselect.c (Qx_lost_selection_functions)
2304 (Qx_sent_selection_functions): New vars.
2305 (syms_of_xselect): DEFSYM them.
2306 (x_handle_selection_request): Pass Qx_sent_selection_functions
2307 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2308 (x_handle_selection_clear,x_clear_frame_selections):
2309 Pass Qx_lost_selection_functions rather than
2310 Vx_lost_selection_functions to Frun_hook_with_args.
2311
2312 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2315 The old code sometimes used this field without initializing it.
2316
2317 * alloc.c (gc_sweep): Don't read past end of array.
2318 In theory, the old code could also have corrupted Emacs internals,
2319 though it'd be very unlikely.
2320
2321 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2322
2323 * character.c (Fcharacterp): Don't advertise optional ignored
2324 argument. (Bug#4026)
2325
2326 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327
2328 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2329 key" (bug#4257).
2330
2331 * window.c (Fset_window_start): Doc fix (bug#4199).
2332 (Fset_window_hscroll): Ditto.
2333
2334 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 Fix minor new problems caught by GCC 4.6.1.
2337 * term.c (init_tty): Remove unused local.
2338 * xsettings.c (store_monospaced_changed): Define this function only
2339 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2340 not used otherwise.
2341
2342 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2343
2344 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2345
2346 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2347
2348 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2349 are the mini-buffer and the echo area (bug#3320).
2350
2351 * term.c (init_tty): Remove support for supdup, c10 and perq
2352 terminals, which are no longer supported (bug#1482).
2353
2354 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2355
2356 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2357
2358 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2359
2360 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2361 for non-popups (Bug#3642).
2362
2363 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2364
2365 * alloc.c (reset_malloc_hooks): Protoize.
2366 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2367 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2368 * cm.c (losecursor): Likewise.
2369 * data.c (fmod): Likewise.
2370 * dispnew.c (swap_glyphs_in_rows): Likewise.
2371 * emacs.c (memory_warning_signal): Likewise.
2372 * floatfns.c (float_error): Likewise.
2373 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2374 (otf_open, font_otf_capability, generate_otf_features)
2375 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2376 Likewise.
2377 * image.c (pbm_read_file): Likewise.
2378 * indent.c (string_display_width): Likewise.
2379 * intervals.c (check_for_interval, search_for_interval)
2380 (inc_interval_count, count_intervals, root_interval)
2381 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2382 * lread.c (defalias): Likewise.
2383 * ralloc.c (r_alloc_check): Likewise.
2384 * regex.c (set_image_of_range_1, set_image_of_range)
2385 (regex_grow_registers): Likewise.
2386 * sysdep.c (strerror): Likewise.
2387 * termcap.c (valid_filename_p, tprint, main): Likewise.
2388 * tparam.c (main): Likewise.
2389 * unexhp9k800.c (run_time_remap, save_data_space)
2390 (update_file_ptrs, read_header, write_header, calculate_checksum)
2391 (copy_file, copy_rest, display_header): Likewise.
2392 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2393 Likewise.
2394 * xdisp.c (check_it): Likewise.
2395 * xfaces.c (register_color, unregister_color, unregister_colors):
2396 Likewise.
2397 * xfns.c (print_fontset_result): Likewise.
2398 * xrdb.c (member, fatal, main): Likewise.
2399
2400 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Fix minor problems found by static checking (Bug#9031).
2403 * chartab.c (char_table_set_range, map_sub_char_table):
2404 Remove unused locals.
2405 (uniprop_table): Now static.
2406 * composite.c (_work_char): Remove unused static var.
2407
2408 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2409
2410 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2411
2412 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2413
2414 * gtkutil.c (qttip_cb): Remove code without function.
2415
2416 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2417
2418 * w32.c (pthread_sigmask): New stub.
2419
2420 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 Use pthread_sigmask, not sigprocmask (Bug#9010).
2423 sigprocmask is portable only for single-threaded applications, and
2424 Emacs can be multi-threaded when it uses GTK.
2425 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2426 (LIBES): Use it.
2427 * callproc.c (Fcall_process):
2428 * process.c (create_process):
2429 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2430 Use pthread_sigmask, not sigprocmask.
2431
2432 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2433
2434 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2435 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2436 wrong (Bug#8591).
2437
2438 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2439
2440 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2441 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2442 (xg_hide_tooltip): Fix comment.
2443
2444 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2445 in registerServicesMenuSendTypes.
2446 (validRequestorForSendType): Don't check ns_return_types.
2447
2448 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2449 ns_return_type.
2450
2451 2011-07-08 Jason Rumney <jasonr@gnu.org>
2452
2453 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2454 frame struct members of non-existent frames (Bug#6284).
2455
2456 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2457
2458 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2459 variable firstTime not needed on OSX >= 10.6.
2460 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2461 >= 10.5. Use setKnobProportion, setDoubleValue.
2462
2463 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2464 (MAC_OS_X_VERSION_10_5): Define if not defined.
2465 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2466 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2467 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2468
2469 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2470 cString and lossyCString on OSX >= 10.4
2471
2472 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2473 sizeToFit on OSX >= 10.2.
2474
2475 * nsimage.m (allocInitFromFile): Don't use deprecated method
2476 bestRepresentationForDevice on OSX >= 10.6.
2477
2478 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2479 to avoid warning.
2480
2481 * emacs.c: Declare unexec_init_emacs_zone.
2482
2483 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2484
2485 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2486
2487 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2488 on svcsMenu (Bug#8842).
2489
2490 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2491 ns_return_types.
2492 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2493
2494 * nsterm.m (QUTF8_STRING): Declare.
2495 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2496 (validRequestorForSendType): Return type is (id).
2497 Change indexOfObjectIdenticalTo to indexOfObject.
2498 Check if we have local selection before returning self (Bug#8842).
2499 (writeSelectionToPasteboard): Put local selection into paste board
2500 if we have a local selection (Bug#8842).
2501 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2502
2503 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2504 (ns_get_local_selection): Declare.
2505
2506 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2507
2508 * keymap.c (describe_map_tree): Don't insert a double newline at
2509 the end of the buffer (bug#1169) and return whether we inserted
2510 something.
2511
2512 * callint.c (Fcall_interactively): Change "reading args" to
2513 "providing args" to try to clarify what it does (bug#1010).
2514
2515 2011-07-07 Kenichi Handa <handa@m17n.org>
2516
2517 * composite.c (composition_compute_stop_pos): Ignore a static
2518 composition starting before CHARPOS (Bug#8915).
2519
2520 * xdisp.c (handle_composition_prop): Likewise.
2521
2522 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2523
2524 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2525 (Bug#9015)
2526
2527 2011-07-07 Kenichi Handa <handa@m17n.org>
2528
2529 * character.h (unicode_category_t): New enum type.
2530
2531 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2532 (Qchar_code_property_table): New variable.
2533 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2534 (UNIPROP_COMPRESSED_FORM_P): New macros.
2535 (char_table_ascii): Uncompress the compressed values.
2536 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2537 Uncompress the compressed values.
2538 (sub_char_table_ref_and_range): Likewise.
2539 (char_table_ref_and_range): Uncompress the compressed values.
2540 (sub_char_table_set): New arg is_uniprop. Callers changed.
2541 Uncompress the compressed values.
2542 (sub_char_table_set_range): Args changed. Callers changed.
2543 (char_table_set_range): Adjuted for the above change.
2544 (map_sub_char_table): Delete args default_val and parent. Add arg
2545 top. Give decoded values to a Lisp function.
2546 (map_char_table): Adjust for the above change. Give decoded
2547 values to a Lisp function. Gcpro more variables.
2548 (uniprop_table_uncompress)
2549 (uniprop_decode_value_run_length): New functions.
2550 (uniprop_decoder, uniprop_decoder_count): New variables.
2551 (uniprop_get_decoder, uniprop_encode_value_character)
2552 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2553 New functions.
2554 (uniprop_encoder, uniprop_encoder_count): New variables.
2555 (uniprop_get_encoder, uniprop_table)
2556 (Funicode_property_table_internal, Fget_unicode_property_internal)
2557 (Fput_unicode_property_internal): New functions.
2558 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2559 Sunicode_property_table_internal, Sget_unicode_property_internal,
2560 and Sput_unicode_property_internal. Defvar_lisp
2561 char-code-property-alist.
2562
2563 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2564 Vunicode_category_table.
2565
2566 * font.c (font_range): Adjust for the change of
2567 Vunicode_category_table.
2568
2569 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2570
2571 * m/iris4d.h: Remove file, move contents ...
2572 * s/irix6-5.h: ... here.
2573
2574 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 Remove unportable assumption about struct layout (Bug#8884).
2577 * alloc.c (mark_buffer):
2578 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2579 (clone_per_buffer_values): Don't assume that
2580 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2581 This isn't true in general, and it's particularly not true
2582 if Emacs is configured with --with-wide-int.
2583 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2584 New macros, used in the buffer.c change.
2585
2586 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2587
2588 * xsettings.c: Use both GConf and GSettings if both are available.
2589 (store_config_changed_event): Add comment.
2590 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2591 (store_tool_bar_style_changed): New functions.
2592 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2593 (struct xsettings): Move font inside HAVE_XFT.
2594 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2595 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2596 Move inside HAVE_XFT.
2597 (something_changed_gsettingsCB): Rename from something_changedCB.
2598 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2599 also.
2600 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2601 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2602 (something_changed_gconfCB): Rename from something_changedCB.
2603 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2604 (parse_settings): Move check for font inside HAVE_XFT.
2605 (read_settings, apply_xft_settings): Add comment.
2606 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2607 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2608 call store_font_name_changed.
2609 (xft_settings_event): Add comment.
2610 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2611 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2612 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2613 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2614 (xsettings_initialize): Call init_gsettings last.
2615 (xsettings_get_system_font, xsettings_get_system_normal_font):
2616 Add comment.
2617
2618 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 Random fixes. E.g., (random) never returned negative values.
2621 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2622 subseconds part to the entropy, as that's a bit more random.
2623 Prefer signed to unsigned, since the signedness doesn't matter and
2624 in general we prefer signed. When given a limit, use a
2625 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2626 latter isn't right if USE_2_TAGS_FOR_INTS.
2627 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2628 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2629
2630 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * textprop.c (text_property_stickiness):
2633 Obey Vtext_property_default_nonsticky.
2634 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2635 * w32fns.c (syms_of_w32fns):
2636 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2637
2638 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2641 This is more efficient than Ffile_directory_p and avoids a minor race.
2642
2643 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2644
2645 * buffer.c (Foverlay_put): Say what the return value is
2646 (bug#7835).
2647
2648 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2649 is a directory before asking whether to use the file name
2650 (bug#7564).
2651 (barf_or_query_if_file_exists): Make the "File is a directory"
2652 error be more correct.
2653
2654 * fns.c (Frequire): Remove the mention of the .gz files, since
2655 that's installation-specific, but keep the mention of
2656 `get-load-suffixes'.
2657
2658 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2661 Report string overflow if the output is too long.
2662
2663 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2664
2665 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2666 (syms_of_gnutls): Remove duplicate DEFSYM for
2667 Qgnutls_bootprop_verify_hostname_error, an error for
2668 Qgnutls_bootprop_verify_error (which is no longer used).
2669
2670 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2671 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2672 Also (re)move comments that are misplaced or no longer relevant.
2673
2674 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2675
2676 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2677
2678 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2679
2680 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2681 and background color parameters if they have been changed.
2682
2683 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2684
2685 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2686
2687 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 * xsettings.c (SYSTEM_FONT): Define only when used.
2690 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2691
2692 * keymap.c (access_keymap_1): Now static.
2693
2694 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2697 leave any prefix arg for the up event (Bug#1586).
2698
2699 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2700
2701 * lread.c (syms_of_lread): Mention single symbols defined by
2702 `defvar' or `defconst' (bug#7154).
2703
2704 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2705 (Frequire): Mention get-load-suffixes.
2706
2707 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2708
2709 * window.h (window): Remove clone_number slot.
2710 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2711 Remove.
2712 (make_parent_window, make_window, saved_window)
2713 (Fset_window_configuration, save_window_save): Don't deal with
2714 clone numbers.
2715 * buffer.c (Qclone_number): Remove declaration.
2716 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2717
2718 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2719
2720 Add multiple inheritance to keymaps.
2721 * keymap.c (Fmake_composed_keymap): New function.
2722 (Fset_keymap_parent): Simplify.
2723 (fix_submap_inheritance): Remove.
2724 (access_keymap_1): New function extracted from access_keymap to handle
2725 embedded parents and handle lists of maps.
2726 (access_keymap): Use it.
2727 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2728 (Fcopy_keymap): Handle embedded parents.
2729 (Fcommand_remapping, define_as_prefix): Simplify.
2730 (Fkey_binding): Simplify.
2731 (syms_of_keymap): Move minibuffer-local-completion-map,
2732 minibuffer-local-filename-completion-map,
2733 minibuffer-local-must-match-map, and
2734 minibuffer-local-filename-must-match-map to Elisp.
2735 (syms_of_keymap): Defsubr make-composed-keymap.
2736 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2737 (parse_menu_item): Trivial simplification.
2738
2739 2011-07-01 Glenn Morris <rgm@gnu.org>
2740
2741 * Makefile.in (SETTINGS_LIBS): Fix typo.
2742
2743 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2744
2745 * coding.c (Fencode_coding_string): Record the last coding system
2746 used, as the function doc string says (bug#8738).
2747
2748 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2749
2750 * xsettings.c (store_monospaced_changed): Take new font as arg and
2751 check for change against current_mono_font.
2752 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2753 (emacs_settings_constructor, emacs_settings_get_property)
2754 (emacs_settings_set_property, emacs_settings_class_init)
2755 (emacs_settings_init, gsettings_obj): Remove.
2756 (something_changedCB): New function for HAVE_GSETTINGS.
2757 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2758 with value as argument.
2759 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2760 g_settings_new (Bug#8967). Do not create gsettings_obj.
2761 Remove calls to g_settings_bind. Connect something_changedCB to
2762 "changed".
2763
2764 * xgselect.c: Add defined (HAVE_GSETTINGS).
2765 (xgselect_initialize): Ditto.
2766
2767 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2768 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2769 xg_select.
2770
2771 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 * eval.c (struct backtrace): Simplify and port the data structure.
2774 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2775 signed bit field, as this assumption is not portable and it makes
2776 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2777 "char debug_on_exit : 1" as this is not portable either; instead,
2778 use the portable "unsigned int debug_on_exit : 1". Remove unused
2779 member evalargs. Remove obsolete comments about cc bombing out.
2780
2781 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2782
2783 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2784 Let HAVE_GSETTINGS override HAVE_GCONF.
2785 (store_monospaced_changed): New function.
2786 (EMACS_SETTINGS): A new type derived from GObject to handle
2787 GSettings notifications.
2788 (emacs_settings_constructor, emacs_settings_get_property)
2789 (emacs_settings_set_property, emacs_settings_class_init):
2790 New functions.
2791 (gsettings_client, gsettings_obj): New variables.
2792 (GSETTINGS_SCHEMA): New define.
2793 (something_changedCB): Call store_monospaced_changed.
2794 (init_gsettings): New function.
2795 (xsettings_initialize): Call init_gsettings.
2796 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2797 to NULL.
2798
2799 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2800 GCONF_CFLAGS/LIBS.
2801
2802 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2803
2804 * window.c (resize_root_window, grow_mini_window)
2805 (shrink_mini_window): Rename Qresize_root_window to
2806 Qwindow_resize_root_window and Qresize_root_window_vertically to
2807 Qwindow_resize_root_window_vertically.
2808
2809 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2812
2813 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2814
2815 * makefile.w32-in: Redesign dependencies so they reflect more
2816 clearly which files are directly included by each source file,
2817 and not through other includes.
2818
2819 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2820
2821 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2822 (sort_overlays, overlay_strings): When an overlay's clone number
2823 matches the window's clone number process the overlay even if
2824 the overlay's window property doesn't match the current window.
2825
2826 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2827 (Fwindow_hchild): Rename to Fwindow_left_child.
2828 (Fwindow_next): Rename to Fwindow_next_sibling.
2829 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2830 (resize_window_check): Rename to window_resize_check.
2831 (resize_window_apply): Rename to window_resize_apply.
2832 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2833 (Fdelete_other_windows_internal, resize_frame_windows)
2834 (Fsplit_window_internal, Fdelete_window_internal)
2835 (grow_mini_window, shrink_mini_window)
2836 (Fresize_mini_window_internal): Fix callers accordingly.
2837
2838 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2839
2840 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2841 (emacs_fixed_set_min_size): Remove.
2842 (emacs_fixed_new): Take frame as argument.
2843
2844 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2845 (_EmacsFixedPrivate): Remove minwidth/height.
2846 Add struct frame *f.
2847 (emacs_fixed_init): Initialize priv->f.
2848 (get_parent_class, emacs_fixed_set_min_size): Remove.
2849 (emacs_fixed_new): Set priv->f to argument.
2850 (emacs_fixed_get_preferred_width)
2851 (emacs_fixed_get_preferred_height): Use min_width/height from
2852 frames size_hint to set minimum and natural (Bug#8919).
2853 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2854 and use min_width/height from frames size_hint to set
2855 min_width/height (Bug#8919).
2856
2857 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2858 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2859 Fix indentation.
2860
2861 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2862
2863 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2864 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2865 called at ZV.
2866
2867 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * process.c (wait_reading_process_output): Bypass select if
2870 waiting for a cell while ignoring keyboard input, and input is
2871 pending. Suggested by Jan Djärv (Bug#8869).
2872
2873 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2874
2875 Use gnulib's dup2 module instead of rolling our own.
2876 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2877
2878 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2879
2880 * dispnew.c (scrolling_window): Before scrolling, turn off a
2881 mouse-highlight in the window being scrolled.
2882
2883 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2884
2885 Move DEFSYM to lisp.h and use everywhere.
2886
2887 * character.h (DEFSYM): Move declaration...
2888 * lisp.h (DEFSYM): ...here.
2889
2890 * gnutls.c:
2891 * minibuf.c:
2892 * w32menu.c:
2893 * w32proc.c:
2894 * w32select.c: Don't include character.h.
2895
2896 * alloc.c (syms_of_alloc):
2897 * buffer.c (syms_of_buffer):
2898 * bytecode.c (syms_of_bytecode):
2899 * callint.c (syms_of_callint):
2900 * casefiddle.c (syms_of_casefiddle):
2901 * casetab.c (init_casetab_once):
2902 * category.c (init_category_once, syms_of_category):
2903 * ccl.c (syms_of_ccl):
2904 * cmds.c (syms_of_cmds):
2905 * composite.c (syms_of_composite):
2906 * dbusbind.c (syms_of_dbusbind):
2907 * dired.c (syms_of_dired):
2908 * dispnew.c (syms_of_display):
2909 * doc.c (syms_of_doc):
2910 * editfns.c (syms_of_editfns):
2911 * emacs.c (syms_of_emacs):
2912 * eval.c (syms_of_eval):
2913 * fileio.c (syms_of_fileio):
2914 * fns.c (syms_of_fns):
2915 * frame.c (syms_of_frame):
2916 * fringe.c (syms_of_fringe):
2917 * insdel.c (syms_of_insdel):
2918 * keymap.c (syms_of_keymap):
2919 * lread.c (init_obarray, syms_of_lread):
2920 * macros.c (syms_of_macros):
2921 * msdos.c (syms_of_msdos):
2922 * print.c (syms_of_print):
2923 * process.c (syms_of_process):
2924 * search.c (syms_of_search):
2925 * sound.c (syms_of_sound):
2926 * syntax.c (init_syntax_once, syms_of_syntax):
2927 * terminal.c (syms_of_terminal):
2928 * textprop.c (syms_of_textprop):
2929 * undo.c (syms_of_undo):
2930 * w32.c (globals_of_w32):
2931 * window.c (syms_of_window):
2932 * xdisp.c (syms_of_xdisp):
2933 * xfaces.c (syms_of_xfaces):
2934 * xfns.c (syms_of_xfns):
2935 * xmenu.c (syms_of_xmenu):
2936 * xsettings.c (syms_of_xsettings):
2937 * xterm.c (syms_of_xterm): Use DEFSYM.
2938
2939 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2940
2941 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2942
2943 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 Integer and buffer overflow fixes (Bug#8873).
2946
2947 * print.c (printchar, strout): Check for string overflow.
2948 (PRINTPREPARE, printchar, strout):
2949 Don't set size unless allocation succeeds.
2950
2951 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2952 for sizes. Check for string overflow more accurately.
2953 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2954
2955 * macros.c: Integer and buffer overflow fixes.
2956 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2957 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2958 Use ptrdiff_t, not int, for sizes.
2959 Don't increment bufsize until after realloc succeeds.
2960 Check for size-calculation overflow.
2961 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2962
2963 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2964
2965 * lread.c: Integer overflow fixes.
2966 (read_integer): Radix is now EMACS_INT, not int,
2967 to improve quality of diagnostics for out-of-range radices.
2968 Calculate buffer size correctly for out-of-range radices.
2969 (read1): Check for integer overflow in radices, and in
2970 read-circle numbers.
2971 (read_escape): Avoid int overflow.
2972 (Fload, openp, read_buffer_size, read1)
2973 (substitute_object_recurse, read_vector, read_list, map_obarray):
2974 Use ptrdiff_t, not int, for sizes.
2975 (read1): Use EMACS_INT, not int, for sizes.
2976 Check for size overflow.
2977
2978 * image.c (cache_image): Check for size arithmetic overflow.
2979
2980 * lread.c: Integer overflow issues.
2981 (saved_doc_string_size, saved_doc_string_length)
2982 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2983 Now ptrdiff_t, not int.
2984 (read1): Don't assume doc string length fits in int. Check for
2985 out-of-range doc string lengths.
2986 (read_list): Don't assume file position fits in int.
2987 (read_escape): Check for hex character overflow.
2988
2989 2011-06-22 Leo Liu <sdl.web@gmail.com>
2990
2991 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2992 Move to minibuffer.el.
2993
2994 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2997 The following patches are for when GLYPH_DEBUG && !XASSERT.
2998 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2999 * dispnew.c (flush_stdout):
3000 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3001 Mark as externally visible.
3002 * dispnew.c (check_window_matrix_pointers): Now static.
3003 * dispnew.c (window_to_frame_vpos):
3004 * xfns.c (unwind_create_frame):
3005 * xterm.c (x_check_font): Remove unused local.
3006 * scroll.c (CHECK_BOUNDS):
3007 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3008 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3009 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3010 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3011 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3012 Now static.
3013 (debug_method_add): Use va_list and vsprintf rather than relying
3014 on undefined behavior with wrong number of arguments.
3015 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3016 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3017 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3018 since we're not interested in debugging glyphs with old libraries.
3019 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3020 GCC 4.6.0's static checking.
3021
3022 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 Integer overflow and signedness fixes (Bug#8873).
3025 A few related buffer overrun fixes, too.
3026
3027 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3028
3029 * dispextern.h (struct face.stipple):
3030 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3031 (x_bitmap_mask, x_allocate_bitmap_record)
3032 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3033 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3034 (x_create_bitmap_from_xpm_data):
3035 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3036 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3037 (.bitmaps_last):
3038 * xfaces.c (load_pixmap):
3039 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3040 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3041 (.bitmaps_last, struct x_output.icon_bitmap):
3042 Use ptrdiff_t, not int, for bitmap indexes.
3043 (x_allocate_bitmap_record): Check for size overflow.
3044 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3045
3046 Use ptrdiff_t, not int, for overlay counts.
3047 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3048 * editfns.c (overlays_around, get_pos_property):
3049 * textprop.c (get_char_property_and_overlay):
3050 * xdisp.c (next_overlay_change, note_mouse_highlight):
3051 * xfaces.c (face_at_buffer_position):
3052 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3053 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3054 (Fnext_overlay_change, Fprevious_overlay_change)
3055 (mouse_face_overlay_overlaps, Foverlays_in):
3056 Use ptrdiff_t, not int, for sizes.
3057 (overlays_at, overlays_in): Check for size-calculation overflow.
3058
3059 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3060
3061 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3062 (x_session_initialize): Do not assume string length fits in int.
3063
3064 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3065 This is unlikely, but can occur if DPI is outlandish.
3066
3067 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3068 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3069
3070 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3071 * xrdb.c (magic_file_p, search_magic_path):
3072 Omit last arg SUFFIX; it was always 0. All callers changed.
3073 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3074
3075 * xfont.c (xfont_match): Avoid need for strlen.
3076
3077 * xfns.c: Don't assume strlen fits in int.
3078 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3079
3080 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3081 not unsigned long, as we prefer signed integers. All callers changed.
3082 Detect integer overflow in repeat count.
3083 (message_dolog): Don't assume print length fits in 39 bytes.
3084 (display_mode_element): Don't assume strlen fits in int.
3085
3086 * termcap.c: Don't assume sizes fit in int and never overflow.
3087 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3088 (gobble_line): Check for size-calculation overflow.
3089
3090 * minibuf.c (Fread_buffer):
3091 * lread.c (intern, intern_c_string):
3092 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3093 Don't assume string length fits in int.
3094
3095 * keyboard.c (parse_tool_bar_item):
3096 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3097
3098 * font.c: Don't assume string length fits in int.
3099 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3100 Use ptrdiff_t, not int.
3101 (font_intern_prop): Don't assume string length fits in int.
3102 Don't assume integer property fits in fixnum.
3103 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3104
3105 * filelock.c: Fix some buffer overrun and integer overflow issues.
3106 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3107 Reformulate so as not to need the command string.
3108 Invoke gzip -cd rather than gunzip, as it's more portable.
3109 (lock_info_type, lock_file_1, lock_file):
3110 Don't assume pid_t and time_t fit in unsigned long.
3111 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3112 (current_lock_owner): Prefer signed type for sizes.
3113 Use memcpy, not strncpy, where memcpy is what is really wanted.
3114 Don't assume (via atoi) that time_t and pid_t fit in int.
3115 Check for time_t and/or pid_t out of range, e.g., via a network share.
3116 Don't alloca where an auto var works fine.
3117
3118 * fileio.c: Fix some integer overflow issues.
3119 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3120 Don't assume string length fits in int.
3121 (directory_file_name): Don't assume string length fits in long.
3122 (make_temp_name): Don't assume pid fits in int, or that its print
3123 length is less than 20.
3124
3125 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3126
3127 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3128
3129 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3130
3131 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3132 We prefer signed integers, even for size calculations.
3133
3134 * emacs.c: Don't assume string length fits in 'int'.
3135 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3136 (main): Don't invoke strlen when not needed.
3137
3138 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3139 (XD_DEBUG_MESSAGE): Don't waste a byte.
3140
3141 * callproc.c (getenv_internal_1, getenv_internal)
3142 (Fgetenv_internal):
3143 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3144
3145 * lread.c (invalid_syntax): Omit length argument.
3146 All uses changed. This doesn't fix a bug, but it simplifies the
3147 code away from its former Hollerith-constant appearance, and it's
3148 one less 'int' to worry about when looking at integer-overflow issues.
3149 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3150
3151 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3152 This didn't break anything, but it didn't help either.
3153 It's confusing to put a bogus integer in a place where the actual
3154 value does not matter.
3155 (LIST_END_P): Remove unused macro and its bogus comment.
3156 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3157
3158 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3159 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3160 implementation.
3161 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3162 We prefer signed types, and the value cannot exceed the EMACS_INT
3163 range anyway (because otherwise the length would not be representable).
3164 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3165 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3166 This avoids a GCC warning when WIDE_EMACS_INT.
3167
3168 * indent.c (sane_tab_width): New function.
3169 (current_column, scan_for_column, Findent_to, position_indentation)
3170 (compute_motion): Use it. This is just for clarity.
3171 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3172
3173 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3174
3175 * lisp.h (lint_assume): New macro.
3176 * composite.c (composition_gstring_put_cache):
3177 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3178
3179 * editfns.c, insdel.c:
3180 Omit unnecessary forward decls, to simplify future changes.
3181
3182 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3183
3184 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3185
3186 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3187 Use much-faster test for byte-length change.
3188 Don't assume string byte-length fits in 'int'.
3189 Check that character arg fits in 'int'.
3190 (mapcar1): Declare byte as byte, for clarity.
3191
3192 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3193
3194 * fns.c (concat): Catch string overflow earlier.
3195 Do not rely on integer wraparound.
3196
3197 * dispextern.h (struct it.overlay_strings_charpos)
3198 (struct it.selective): Now EMACS_INT, not int.
3199 * xdisp.c (forward_to_next_line_start)
3200 (back_to_previous_visible_line_start)
3201 (reseat_at_next_visible_line_start, next_element_from_buffer):
3202 Don't arbitrarily truncate the value of 'selective' to int.
3203
3204 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3205
3206 * composite.c: Don't truncate sizes to 'int'.
3207 (composition_gstring_p, composition_reseat_it)
3208 (composition_adjust_point): Use EMACS_INT, not int.
3209 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3210 not EMACS_UINT, for indexes.
3211
3212 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3213
3214 * buffer.c: Include <verify.h>.
3215 (struct sortvec.priority, struct sortstr.priority):
3216 Now EMACS_INT, not int.
3217 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3218 (struct sortstr.size, record_overlay_string)
3219 (struct sortstrlist.size, struct sortlist.used):
3220 Don't truncate size to int.
3221 (record_overlay_string): Check for size-calculation overflow.
3222 (init_buffer_once): Check at compile-time, not run-time.
3223
3224 2011-06-22 Jim Meyering <meyering@redhat.com>
3225
3226 Don't leak an XBM-image-sized buffer
3227 * image.c (xbm_load): Free the image buffer after using it.
3228
3229 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Port to Sun C.
3232 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3233 that Sun C diagnosed.
3234 * fns.c (secure_hash): Fix pointer signedness issue.
3235 * intervals.c (static_offset_intervals): New function.
3236 (offset_intervals): Use it.
3237
3238 2011-06-21 Leo Liu <sdl.web@gmail.com>
3239
3240 * deps.mk (fns.o):
3241 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3242 sha512.h.
3243
3244 * fns.c (secure_hash): Rename from crypto_hash_function and change
3245 the first arg to accept symbols.
3246 (Fsecure_hash): New primitive.
3247 (syms_of_fns): New symbols.
3248
3249 2011-06-20 Deniz Dogan <deniz@dogan.se>
3250
3251 * process.c (Fset_process_buffer): Clarify return value in
3252 docstring.
3253
3254 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3255
3256 * dispnew.c (add_window_display_history): Use BVAR.
3257
3258 * xdisp.c (debug_method_add): Use BVAR.
3259 (check_window_end, dump_glyph_matrix, dump_glyph)
3260 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3261
3262 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3263 Likewise.
3264
3265 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3266 check till after the cache is created in init_frame_faces.
3267
3268 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3269
3270 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3271
3272 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3275 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3276 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3277
3278 Improve buffer-overflow checking (Bug#8873).
3279 * fileio.c (Finsert_file_contents):
3280 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3281 Remove the old (too-loose) buffer overflow checks.
3282 They weren't needed, since make_gap checks for buffer overflow.
3283 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3284 The old code merely checked for Emacs fixnum overflow, and relied
3285 on undefined (wraparound) behavior. The new code avoids undefined
3286 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3287
3288 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3289 Tune. Don't use wider integers than needed. Don't use alloca.
3290 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3291
3292 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3293
3294 * insdel.c, lisp.h (buffer_overflow): New function.
3295 (insert_from_buffer_1, replace_range, replace_range_2):
3296 * insdel.c (make_gap_larger):
3297 * editfns.c (Finsert_char):
3298 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3299
3300 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3301
3302 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 Integer overflow and signedness fixes (Bug#8873).
3305
3306 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3307 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3308
3309 * fileio.c: Don't assume EMACS_INT fits in off_t.
3310 (emacs_lseek): New static function.
3311 (Finsert_file_contents, Fwrite_region): Use it.
3312 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3313
3314 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3315
3316 * fns.c: Don't overflow int when computing a list length.
3317 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3318 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3319 truncation on 64-bit hosts. Check for QUIT every
3320 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3321 faster and is responsive enough.
3322 (Flength): Report an error instead of overflowing an integer.
3323 (Fsafe_length): Return a float if the value is not representable
3324 as a fixnum. This shouldn't happen except in contrived situations.
3325 (Fnthcdr, Fsort): Don't assume list length fits in int.
3326 (Fcopy_sequence): Don't assume vector length fits in int.
3327
3328 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3329 (header_size, word_size): New constants.
3330 (allocate_vectorlike): Don't check size overflow here.
3331 (allocate_vector): Check it here instead, since this is the only
3332 caller of allocate_vectorlike that could cause overflow.
3333 Check that the new vector's length is representable as a fixnum.
3334
3335 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3336 The previous code was bogus. For example, next_almost_prime (32)
3337 returned 39, which is undesirable as it is a multiple of 3; and
3338 next_almost_prime (24) returned 25, which is a multiple of 5 so
3339 why was the code bothering to check for multiples of 7?
3340
3341 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3342
3343 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3344
3345 Variadic C functions now count arguments with ptrdiff_t.
3346 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3347 Back then I didn't know that the Emacs coding style prefers signed int.
3348 Also, in the meantime I found a few more instances where arguments
3349 were being counted with int, which may truncate counts on 64-bit
3350 machines, or EMACS_INT, which may be unnecessarily wide.
3351 * lisp.h (struct Lisp_Subr.function.aMANY)
3352 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3353 Arg counts are now ptrdiff_t, not size_t.
3354 All variadic functions and their callers changed accordingly.
3355 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3356 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3357 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3358 * callint.c (Fcall_interactively): Check arg count for overflow,
3359 to avoid potential buffer overrun. Use signed char, not 'int',
3360 for 'varies' array, so that we needn't bother to check its size
3361 calculation for overflow.
3362 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3363 * eval.c (apply_lambda):
3364 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3365 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3366 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3367
3368 * callint.c (Fcall_interactively): Don't use index var as event count.
3369
3370 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3371 * mem-limits.h (SIZE): Remove; no longer used.
3372
3373 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3374
3375 Remove unnecessary casts.
3376 * xterm.c (x_term_init):
3377 * xfns.c (x_set_border_pixel):
3378 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3379 These aren't needed now that we assume ANSI C.
3380
3381 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3382 It's more likely to cause problems (due to unsigned overflow)
3383 than to cure them.
3384
3385 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3386
3387 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3388
3389 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3390
3391 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3392
3393 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3394
3395 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3396
3397 GLYPH_CODE_FACE returns EMACS_INT, not int.
3398 * dispextern.h (merge_faces):
3399 * xfaces.c (merge_faces):
3400 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3401 Don't assume EMACS_INT fits in int.
3402
3403 * character.h (CHAR_VALID_P): Remove unused parameter.
3404 * fontset.c, lisp.h, xdisp.c: All uses changed.
3405
3406 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3407
3408 * fns.c (concat): Minor tuning based on overflow analysis.
3409 This doesn't fix any bugs. Use int to hold character, instead
3410 of constantly refetching from Emacs object. Use XFASTINT, not
3411 XINT, for value known to be a character. Don't bother comparing
3412 a single byte to 0400, as it's always less.
3413
3414 * floatfns.c (Fexpt):
3415 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3416
3417 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3418 for characters.
3419
3420 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3421
3422 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3423 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3424 incorrectly succeed when S was a string, because 4294967386 was
3425 truncated before it was used.
3426
3427 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3428 Otherwise, an out-of-range integer could cause undefined behavior
3429 on a 64-bit host.
3430
3431 * composite.c: Use int, not EMACS_INT, for characters.
3432 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3433 EMACS_INT, for values that are known to be in character range.
3434 This doesn't fix any bugs but is the usual style inside Emacs and
3435 may generate better code on 32-bit machines.
3436
3437 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3438 This is for reasons similar to the recent CHAR_STRING fix.
3439 * charset.c (Fencode_char): Check that character arg is actually
3440 a character. Pass an int to ENCODE_CHAR.
3441 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3442 wider than 'int', as a compile-time check to prevent future regressions
3443 in this area.
3444
3445 * character.c (char_string): Remove unnecessary casts.
3446
3447 Make sure a 64-bit char is never passed to CHAR_STRING.
3448 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3449 by silently ignoring the top 32 bits, allowing some values
3450 that were far too large to be valid characters.
3451 * character.h: Include <verify.h>.
3452 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3453 arguments are no wider than unsigned, as a compile-time check
3454 to prevent future regressions in this area.
3455 * data.c (Faset):
3456 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3457 (Fsubst_char_in_region):
3458 * fns.c (concat):
3459 * xdisp.c (decode_mode_spec_coding):
3460 Adjust to CHAR_STRING's new requirement.
3461 * editfns.c (Finsert_char, Fsubst_char_in_region):
3462 * fns.c (concat): Check that character args are actually
3463 characters. Without this test, these functions did the wrong
3464 thing with wildly out-of-range values on 64-bit hosts.
3465
3466 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3467 These casts should not be needed on 32-bit hosts, either.
3468 * keyboard.c (read_char):
3469 * lread.c (Fload): Remove casts to unsigned.
3470
3471 * lisp.h (UNSIGNED_CMP): New macro.
3472 This fixes comparison bugs on 64-bit hosts.
3473 (ASCII_CHAR_P): Use it.
3474 * casefiddle.c (casify_object):
3475 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3476 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3477 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3478 * dispextern.h (FACE_FROM_ID):
3479 * keyboard.c (read_char): Use UNSIGNED_CMP.
3480
3481 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3482 not to EMACS_INT, to avoid GCC warning.
3483
3484 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3485
3486 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3487 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3488 isn't needed on 32-bit machines.
3489
3490 * buffer.c (Fgenerate_new_buffer_name):
3491 Use EMACS_INT for count, not int.
3492 (advance_to_char_boundary): Return EMACS_INT, not int.
3493
3494 * data.c (Qcompiled_function): Now static.
3495
3496 * window.c (window_body_lines): Now static.
3497
3498 * image.c (gif_load): Rename local to avoid shadowing.
3499
3500 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3501 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3502 * alloc.c (make_save_value): Integer argument is now of type
3503 ptrdiff_t, not int.
3504 (mark_object): Use ptrdiff_t, not int.
3505 * lisp.h (pD): New macro.
3506 * print.c (print_object): Use it.
3507
3508 * alloc.c: Use EMACS_INT, not int, to count objects.
3509 (total_conses, total_markers, total_symbols, total_vector_size)
3510 (total_free_conses, total_free_markers, total_free_symbols)
3511 (total_free_floats, total_floats, total_free_intervals)
3512 (total_intervals, total_strings, total_free_strings):
3513 Now EMACS_INT, not int. All uses changed.
3514 (Fgarbage_collect): Compute overall total using a double, so that
3515 integer overflow is less likely to be a problem. Check for overflow
3516 when converting back to an integer.
3517 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3518 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3519 These were 'int' variables that could overflow on 64-bit hosts;
3520 they were never used, so remove them instead of repairing them.
3521 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3522 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3523 Previously, this ceilinged at INT_MAX, but that doesn't work on
3524 64-bit machines.
3525 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3526
3527 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3528 (allocate_vectorlike): Check for ptrdiff_t overflow.
3529 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3530 when a (possibly-narrower) signed value would do just as well.
3531 We prefer using signed arithmetic, to avoid comparison confusion.
3532
3533 * alloc.c: Catch some string size overflows that we were missing.
3534 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3535 for convenience in STRING_BYTES_MAX.
3536 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3537 The definition here is exact; the one in lisp.h was approximate.
3538 (allocate_string_data): Check for string overflow. This catches
3539 some instances we weren't catching before. Also, it catches
3540 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3541 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3542 and ptrdiff_t and EMACS_INT are both 64 bits.
3543
3544 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3545 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3546 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3547
3548 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3549
3550 * alloc.c (Fmake_string): Check for out-of-range init.
3551
3552 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3553
3554 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3555
3556 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3557
3558 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3559 xg_get_default_scrollbar_width.
3560
3561 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3562 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3563 (style_changed_cb): Call update_theme_scrollbar_width and call
3564 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3565 all frames (Bug#8505).
3566 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3567 Call gtk_window_set_resizable if HAVE_GTK3.
3568 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3569 and height if HAVE_GTK3 (Bug#8505).
3570 (scroll_bar_width_for_theme): New variable.
3571 (update_theme_scrollbar_width): New function.
3572 (xg_get_default_scrollbar_width): Move code to
3573 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3574 (xg_initialize): Call update_theme_scrollbar_width.
3575
3576 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3577
3578 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3579
3580 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3581
3582 * frame.c (make_frame): Call other_buffer_safely instead of
3583 other_buffer.
3584
3585 * window.c (temp_output_buffer_show): Call display_buffer with
3586 second argument Vtemp_buffer_show_specifiers and reset latter
3587 immediately after the call.
3588 (Vtemp_buffer_show_specifiers): New variable.
3589 (auto_window_vscroll_p, next_screen_context_lines)
3590 (Vscroll_preserve_screen_position): Remove leading asterisks from
3591 doc-strings.
3592
3593 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 Fix minor problems found by GCC 4.6.0 static checking.
3596 * buffer.c (Qclone_number): Remove for now, as it's unused.
3597 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3598 (record_buffer): Remove unused local.
3599 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3600 (set_frame_buffer_list): Remove; unused.
3601 * frame.h (other_visible_frames): Remove decl.
3602 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3603 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3604 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3605 if HAVE_GPM.
3606 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3607 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3608 Define only if HAVE_GPM.
3609 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3610 (update_hints_inhibit): Remove; never set. All uses removed.
3611 * widgetprv.h (emacsFrameClassRec): Remove decl.
3612 * window.c (delete_deletable_window): Now returns void, since it
3613 wasn't returning anything.
3614 (compare_window_configurations): Remove unused locals.
3615 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3616 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3617 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3618 the same widths as pointers. This follows up on the 2011-05-06 patch.
3619 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3620 * xterm.h: Likewise.
3621 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3622
3623 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * makefile.w32-in: Update dependencies.
3626 (LISP_H): Add lib/intprops.h.
3627
3628 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * image.c (gif_load): Add animation frame delay to the metadata.
3631 (syms_of_image): Use DEFSYM. New symbol `delay'.
3632
3633 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3634
3635 * window.c (delete_deletable_window): Re-add.
3636 (Fset_window_configuration): Rewrite to handle dead buffers and
3637 consequently deletable windows.
3638 (window_tree, Fwindow_tree): Remove. Supply functionality in
3639 window.el.
3640 (compare_window_configurations): Simplify code.
3641
3642 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * image.c (imagemagick_load_image): Fix type mismatch.
3645 (Fimagemagick_types): Likewise.
3646
3647 * window.h (replace_buffer_in_windows): Declare.
3648
3649 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3650
3651 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3652 Qclone_number. Remove external declaration of Qdelete_window.
3653 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3654 code.
3655 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3656 Run Qbuffer_list_update_hook if allowed.
3657 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3658 buffer list implementation.
3659 (other_buffer_safely): New function.
3660 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3661 calls to replace_buffer_in_windows and
3662 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3663 if allowed.
3664 (record_buffer): Inhibit quitting and rewrite using quittable
3665 functions. Run Qbuffer_list_update_hook if allowed.
3666 (Frecord_buffer, Funrecord_buffer): New functions.
3667 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3668 Move switch-to-buffer to window.el.
3669 (bury-buffer): Move to window.el.
3670 (Vbuffer_list_update_hook): New variable.
3671
3672 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3673 section.
3674
3675 * window.h (resize_frame_windows): Move up in code.
3676 (Fwindow_frame): Remove EXFUN.
3677 (replace_buffer_in_all_windows): Remove prototype.
3678 (replace_buffer_in_windows_safely): Add prototype.
3679
3680 * window.c: Declare Qdelete_window static again. Move down
3681 declaration of select_count.
3682 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3683 (Fother_window): Move to window.el.
3684 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3685 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3686 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3687 window.el.
3688 (replace_buffer_in_windows): Implement by calling
3689 Qreplace_buffer_in_windows.
3690 (replace_buffer_in_all_windows): Remove with some functionality
3691 moved into replace_buffer_in_windows_safely.
3692 (replace_buffer_in_windows_safely): New function.
3693 (select_window_norecord, select_frame_norecord): Move in front
3694 of run_window_configuration_change_hook. Remove now obsolete
3695 declarations.
3696 (Fset_window_buffer): Rewrite doc-string.
3697 Call Qrecord_window_buffer.
3698 (keys_of_window): Move binding for other-window to window.el.
3699
3700 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3701
3702 * dispextern.h (struct image): Replace data member, whose int_val
3703 and ptr_val fields were not used by anything, with a single
3704 lisp_val object.
3705
3706 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3707 (gif_clear_image, gif_load, imagemagick_load_image)
3708 (gs_clear_image, gs_load): Callers changed.
3709
3710 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 * buffer.h: Include <time.h>, for time_t.
3713 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3714
3715 Fix minor problems found by static checking.
3716
3717 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3718
3719 Make identifiers static if they are not used in other modules.
3720 * data.c (Qcompiled_function, Qframe, Qvector):
3721 * image.c (QimageMagick, Qsvg):
3722 * minibuf.c (Qmetadata):
3723 * window.c (resize_window_check, resize_root_window): Now static.
3724 * window.h (resize_window_check, resize_root_window): Remove decls.
3725
3726 * window.c (window_deletion_count, delete_deletable_window):
3727 Remove; unused.
3728 (window_body_lines): Now static.
3729 (Fdelete_other_windows_internal): Mark vars as initialized.
3730 Make sure 'resize_failed' is initialized.
3731 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3732 (resize_window_apply): Remove unused local.
3733 * window.h (delete_deletable_window): Remove decl.
3734
3735 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3736 (imagemagick_load_image): Fix pointer signedness problem by changing
3737 last arg from unsigned char * to char *. All uses changed.
3738 Also, fix a local for similar reasons.
3739 Remove unused locals. Remove locals to avoid shadowing.
3740 (fn_rsvg_handle_free): Remove; unused.
3741 (svg_load, svg_load_image): Fix pointer signedness problem.
3742 (imagemagick_load_image): Don't use garbage pointer image_wand.
3743
3744 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3745
3746 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3747
3748 * image.c (gif_load): Fix omitted cast error introduced by
3749 2011-06-06 change.
3750
3751 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3752
3753 * window.h (resize_proportionally, orig_total_lines)
3754 (orig_top_line): Remove from window structure.
3755 (set_window_height, set_window_width, change_window_heights)
3756 (Fdelete_window): Remove prototypes.
3757 (resize_frame_windows): Remove duplicate declaration.
3758
3759 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3760
3761 * window.h (resize_frame_windows, resize_window_check)
3762 (delete_deletable_window, resize_root_window)
3763 (resize_frame_windows): Declare prototypes.
3764
3765 * window.c (resize_window_apply): Make definition be "static" to
3766 match the prototype.
3767
3768 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3769
3770 * window.c: Remove declarations of Qwindow_size_fixed,
3771 window_min_size_1, window_min_size_2, window_min_size,
3772 size_window, window_fixed_size_p, enlarge_window, delete_window.
3773 Remove static from declaration of Qdelete_window, it's
3774 temporarily needed by Fbury_buffer.
3775 (replace_window): Don't assign orig_top_line and
3776 orig_total_lines.
3777 (Fdelete_window, delete_window): Remove. Window deletion is
3778 handled by window.el.
3779 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3780 Replace Fdelete_window calls with calls to Qdelete_window.
3781 (Fdelete_other_windows): Remove. Deleting other windows is
3782 handled by window.el.
3783 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3784 handled in window.el.
3785 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3786 Window minimum sizes are handled in window.el.
3787 (shrink_windows, size_window, set_window_height)
3788 (set_window_width, change_window_heights, window_height)
3789 (window_width, CURBEG, CURSIZE, enlarge_window)
3790 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3791 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3792 handled in window.el.
3793 (make_dummy_parent): Rename to make_parent_window and give it a
3794 second argument horflag.
3795 (make_window): Don't set resize_proportionally any more.
3796 (Fsplit_window): Remove. Windows are split in window.el.
3797 (save_restore_action, save_restore_orig_size)
3798 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3799 Resize mini windows in window.el.
3800 (grow_mini_window, shrink_mini_window): Implement by calling
3801 Qresize_root_window_vertically, resize_window_check and
3802 resize_window_apply.
3803 (saved_window, Fset_window_configuration, save_window_save):
3804 Do not handle orig_top_line, orig_total_lines, and
3805 resize_proportionally.
3806 (window_min_height, window_min_width): Move to window.el.
3807 (keys_of_window): Move bindings for delete-other-windows,
3808 split-window, delete-window and enlarge-window to window.el.
3809
3810 * buffer.c: Temporarily extern Qdelete_window.
3811 (Fbury_buffer): Temporarily call Qdelete_window instead of
3812 Fdelete_window (Fbury_buffer will move to window.el soon).
3813
3814 * frame.c (set_menu_bar_lines_1): Remove code handling
3815 orig_top_line and orig_total_lines.
3816
3817 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3818 set_window_height but set heights directly.
3819 (change_frame_size_1): Use resize_frame_windows.
3820
3821 * xdisp.c (init_xdisp): Don't use set_window_height but set
3822 heights directly.
3823
3824 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3825 Use resize_frame_windows instead of change_window_heights and run
3826 run_window_configuration_change_hook.
3827
3828 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3829 instead of change_window_heights and run
3830 run_window_configuration_change_hook.
3831
3832 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3833
3834 * window.c (replace_window): Rename second argument REPLACEMENT to
3835 NEW. New third argument SETFLAG. Rewrite.
3836 (delete_window, make_dummy_parent): Call replace_window with
3837 third argument 1.
3838 (window_list_1): Move down in code.
3839 (run_window_configuration_change_hook): Move set_buffer part
3840 before select_frame_norecord part in order to unwind correctly.
3841 Rename count1 to count.
3842 (recombine_windows, delete_deletable_window, resize_root_window)
3843 (Fdelete_other_windows_internal)
3844 (Frun_window_configuration_change_hook, make_parent_window)
3845 (resize_window_check, resize_window_apply, Fresize_window_apply)
3846 (resize_frame_windows, Fsplit_window_internal)
3847 (Fdelete_window_internal, Fresize_mini_window_internal):
3848 New functions.
3849 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3850
3851 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3852
3853 * window.h (window): Add some new members to window structure -
3854 normal_lines, normal_cols, new_total, new_normal, clone_number,
3855 splits, nest, prev_buffers, next_buffers.
3856 (WINDOW_TOTAL_SIZE): Move here from window.c.
3857 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3858
3859 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3860 Remove.
3861 (make_dummy_parent): Set new members of windows structure.
3862 (make_window): Move down in code. Handle new members of window
3863 structure.
3864 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3865 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3866 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3867 (Fset_window_prev_buffers, Fwindow_next_buffers)
3868 (Fset_window_next_buffers, Fset_window_clone_number):
3869 New functions.
3870 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3871 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3872 Doc-string fixes.
3873 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3874 Argument WINDOW can be now internal window too.
3875 (Fwindow_use_time): Move up in code.
3876 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3877 Rewrite doc-string.
3878 (Fset_window_configuration, saved_window)
3879 (Fcurrent_window_configuration, save_window_save): Handle new
3880 members of window structure.
3881 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3882 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3883 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3884 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3885 Qget_mru_window, Qresize_root_window,
3886 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3887 Qauto_buffer_name; staticpro them.
3888
3889 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3890
3891 * window.c (Fwindow_total_size, Fwindow_left_column)
3892 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3893 (Fwindow_list_1): New functions.
3894 (window_box_text_cols): Replace with window_body_cols.
3895 (Fwindow_width, Fscroll_left, Fscroll_right):
3896 Use window_body_cols instead of window_box_text_cols.
3897 (delete_window, Fset_window_configuration):
3898 Call delete_all_subwindows with window as argument.
3899 (delete_all_subwindows): Take a window as argument and not a
3900 structure. Rewrite.
3901 (window_loop): Remove handling of GET_LRU_WINDOW and
3902 GET_LARGEST_WINDOW.
3903 (Fget_lru_window, Fget_largest_window): Move to window.el.
3904
3905 * window.h: Extern window_body_cols instead of
3906 window_box_text_cols. delete_all_subwindows now takes a
3907 Lisp_Object as argument.
3908
3909 * indent.c (compute_motion, Fcompute_motion):
3910 Use window_body_cols instead of window_box_text_cols.
3911
3912 * frame.c (delete_frame): Call delete_all_subwindows with root
3913 window as argument.
3914
3915 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3916
3917 * fns.c (Fputhash): Document return value.
3918
3919 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3920
3921 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3922
3923 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 Cons<->int and similar integer overflow fixes (Bug#8794).
3926
3927 Check for overflow when converting integer to cons and back.
3928 * charset.c (Fdefine_charset_internal, Fdecode_char):
3929 Use cons_to_unsigned to catch overflow.
3930 (Fencode_char): Use INTEGER_TO_CONS.
3931 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3932 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3933 * data.c (long_to_cons, cons_to_long): Remove.
3934 (cons_to_unsigned, cons_to_signed): New functions.
3935 These signal an error for invalid or out-of-range values.
3936 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3937 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3938 * font.c (Ffont_variation_glyphs):
3939 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3940 * lisp.h: Include <intprops.h>.
3941 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3942 (cons_to_signed, cons_to_unsigned): New decls.
3943 (long_to_cons, cons_to_long): Remove decls.
3944 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3945 (Fprimitive_undo): Use CONS_TO_INTEGER.
3946 * xfns.c (Fx_window_property): Likewise.
3947 * xselect.c: Include <limits.h>.
3948 (x_own_selection, selection_data_to_lisp_data):
3949 Use INTEGER_TO_CONS.
3950 (x_handle_selection_request, x_handle_selection_clear)
3951 (x_get_foreign_selection, Fx_disown_selection_internal)
3952 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3953 (lisp_data_to_selection_data): Use cons_to_unsigned.
3954 (x_fill_property_data): Use cons_to_signed.
3955 Report values out of range.
3956
3957 Check for buffer and string overflow more precisely.
3958 * buffer.h (BUF_BYTES_MAX): New macro.
3959 * lisp.h (STRING_BYTES_MAX): New macro.
3960 * alloc.c (Fmake_string):
3961 * character.c (string_escape_byte8):
3962 * coding.c (coding_alloc_by_realloc):
3963 * doprnt.c (doprnt):
3964 * editfns.c (Fformat):
3965 * eval.c (verror):
3966 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3967 since they may not be the same number.
3968 * editfns.c (Finsert_char):
3969 * fileio.c (Finsert_file_contents):
3970 Likewise for BUF_BYTES_MAX.
3971
3972 * image.c: Use ptrdiff_t, not int, for sizes.
3973 (slurp_file): Switch from int to ptrdiff_t.
3974 All uses changed.
3975 (slurp_file): Check that file size fits in both size_t (for
3976 malloc) and ptrdiff_t (for sanity and safety).
3977
3978 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3979 if b->modtime has its maximal value.
3980
3981 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3982
3983 Don't assume time_t can fit into int.
3984 * buffer.h (struct buffer.modtime): Now time_t, not int.
3985 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3986 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3987
3988 Minor fixes for signed vs unsigned integers.
3989 * character.h (MAYBE_UNIFY_CHAR):
3990 * charset.c (maybe_unify_char):
3991 * keyboard.c (read_char, reorder_modifiers):
3992 XINT -> XFASTINT, since the integer must be nonnegative.
3993 * ftfont.c (ftfont_spec_pattern):
3994 * keymap.c (access_keymap, silly_event_symbol_error):
3995 XUINT -> XFASTINT, since the integer must be nonnegative.
3996 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3997 since it makes no difference and we prefer signed.
3998 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3999 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4000 nonnegative.
4001
4002 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4003
4004 * window.h (Fwindow_frame): Declare.
4005
4006 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4009 (SPARE_MEMORY): Always define.
4010 (LARGE_REQUEST): Remove.
4011 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4012
4013 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4014
4015 * lisp.h: Move EXFUNS for Fframe_root_window,
4016 Fframe_first_window and Fset_frame_selected_window to window.h.
4017
4018 * window.h: Move EXFUNS for Fframe_root_window,
4019 Fframe_first_window and Fset_frame_selected_window here from
4020 lisp.h.
4021
4022 * frame.c (Fwindow_frame, Fframe_first_window)
4023 (Fframe_root_window, Fframe_selected_window)
4024 (Fset_frame_selected_window): Move to window.c.
4025 (Factive_minibuffer_window): Move to minibuf.c.
4026 (Fother_visible_frames_p): New function.
4027
4028 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4029
4030 * window.c (decode_window, decode_any_window): Move up in code.
4031 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4032 (inhibit_frame_unsplittable): Remove unused variable.
4033 (Fwindow_buffer): Move up and rewrite doc-string.
4034 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4035 (Fwindow_prev): New functions.
4036 (Fwindow_frame): Move here from frame.c. Accept any window as
4037 argument.
4038 (Fframe_root_window, Fframe_first_window)
4039 (Fframe_selected_window): Move here from frame.c. Accept frame
4040 or arbitrary window as argument. Update doc-strings.
4041 (Fminibuffer_window): Move up in code.
4042 (Fwindow_minibuffer_p): Move up in code and simplify.
4043 (Fset_frame_selected_window): Move here from frame.c.
4044 Marginal rewrite.
4045 (Fselected_window, select_window, Fselect_window): Move up in
4046 code. Minor doc-string fixes.
4047
4048 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4049
4050 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4051 Do not assume that spare memory exists; that assumption is valid
4052 only if SYSTEM_MALLOC.
4053 (LARGE_REQUEST): New macro, so that the issue of large requests
4054 is separated from the issue of spare memory.
4055
4056 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4057
4058 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4059 format. (Bug#8806)
4060
4061 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4062
4063 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4064 before statements.
4065
4066 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4067
4068 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4069
4070 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4071
4072 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4073 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4074
4075 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4078
4079 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4080
4081 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4082 (x_clipboard_manager_save): Add return value.
4083 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4084 New error handlers.
4085 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4086 Obey Vx_select_enable_clipboard_manager. Catch errors in
4087 x_clipboard_manager_save (Bug#8779).
4088 (Vx_select_enable_clipboard_manager): New variable.
4089 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4090
4091 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4092
4093 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4094
4095 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4096
4097 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4098 in the current matrix if keep_current_p is non-zero.
4099
4100 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4101
4102 * bidi.c (bidi_level_of_next_char): Fix last change.
4103
4104 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4105
4106 Support bidi reordering of text covered by display properties.
4107
4108 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4109 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4110 (bidi_cache_search, bidi_cache_iterator_state)
4111 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4112 (bidi_level_of_next_char, bidi_move_to_visually_next):
4113 Support character positions inside a run of characters covered by a
4114 display string.
4115 (bidi_paragraph_init, bidi_resolve_explicit_1)
4116 (bidi_level_of_next_char): Call bidi_fetch_char and
4117 bidi_fetch_char_advance instead of FETCH_CHAR and
4118 FETCH_CHAR_ADVANCE.
4119 (bidi_init_it): Initialize new members.
4120 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4121 definitions.
4122 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4123 instead of using explicit *_CHAR codes.
4124 (bidi_resolve_explicit, bidi_resolve_weak):
4125 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4126 bidirectional text is supported only in multibyte buffers.
4127 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4128 it to initialize the frame_window_p member of struct bidi_it.
4129 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4130 (bidi_resolve_explicit, bidi_resolve_weak)
4131 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4132 bidi_it->nchars is non-positive.
4133 (bidi_level_of_next_char): Don't try to lookup the cache for the
4134 next/previous character if nothing is cached there yet, or if we
4135 were just reseat()'ed to a new position.
4136
4137 * xdisp.c (set_cursor_from_row): Set start and stop points
4138 according to the row's direction when priming the loop that looks
4139 for the glyph on which to display cursor.
4140 (single_display_spec_intangible_p): Function deleted.
4141 (display_prop_intangible_p): Reimplement to call
4142 handle_display_spec instead of single_display_spec_intangible_p.
4143 Accept 3 additional arguments needed by handle_display_spec.
4144 This fixes incorrect cursor motion across display property with complex
4145 values: lists, `(when COND...)' forms, etc.
4146 (single_display_spec_string_p): Support property values that are
4147 lists with the argument STRING its top-level element.
4148 (display_prop_string_p): Fix the condition for processing a
4149 property that is a list to be consistent with handle_display_spec.
4150 (handle_display_spec): New function, refactored from the
4151 last portion of handle_display_prop.
4152 (compute_display_string_pos): Accept additional argument
4153 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4154 value of a `display' property is a "replacing spec".
4155 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4156 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4157 the display property, but just return a value indicating whether
4158 the display property will replace the characters it covers.
4159 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4160 frame_window_p members of struct bidi_it.
4161 (compute_display_string_pos, compute_display_string_end):
4162 New functions.
4163 (push_it): Accept second argument POSITION, where pop_it should
4164 jump to continue iteration.
4165 (reseat_1): Initialize bidi_it.disp_pos.
4166
4167 * keyboard.c (adjust_point_for_property): Adjust the call to
4168 display_prop_intangible_p to its new signature.
4169
4170 * dispextern.h (struct bidi_it): New member frame_window_p.
4171 (bidi_init_it): Update prototypes.
4172 (display_prop_intangible_p): Update prototype.
4173 (compute_display_string_pos, compute_display_string_end):
4174 Declare prototypes.
4175 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4176 EMACS_INT.
4177
4178 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 Malloc failure behavior now depends on size of allocation.
4181 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4182 * lisp.h: Change signatures accordingly.
4183 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4184 All callers changed. (Bug#8762)
4185
4186 * gnutls.c: Use Emacs's memory allocators.
4187 Without this change, the gnutls library would invoke malloc etc.
4188 directly, which causes problems on non-SYNC_INPUT hosts, and which
4189 runs afoul of improving memory_full behavior. (Bug#8761)
4190 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4191 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4192 xfree instead of the default malloc, realloc, free.
4193 (Fgnutls_boot): No need to check for memory allocation failure,
4194 since xmalloc does that for us.
4195
4196 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4197 * category.c (hash_get_category_set):
4198 * ccl.c (ccl_driver):
4199 * charset.c (Fdefine_charset_internal):
4200 * charset.h (struct charset.hash_index):
4201 * composite.c (get_composition_id, gstring_lookup_cache)
4202 (composition_gstring_put_cache):
4203 * composite.h (struct composition.hash_index):
4204 * dispextern.h (struct image.hash):
4205 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4206 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4207 (hashfn_equal, hashfn_user_defined, make_hash_table)
4208 (maybe_resize_hash_table, hash_lookup, hash_put)
4209 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4210 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4211 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4212 * image.c (make_image, search_image_cache, lookup_image)
4213 (xpm_put_color_table_h):
4214 * lisp.h (struct Lisp_Hash_Table):
4215 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4216 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4217 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4218 * alloc.c (allocate_vectorlike):
4219 Check for overflow in vector size calculations.
4220 * ccl.c (ccl_driver):
4221 Check for overflow when converting EMACS_INT to int.
4222 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4223 need to be updated by these changes.
4224 * fns.c (make_hash_table, maybe_resize_hash_table):
4225 Check for integer overflow with large hash tables.
4226 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4227 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4228 (SXHASH_REDUCE): New macro.
4229 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4230 Use it instead of discarding useful hash info with large hash values.
4231 (sxhash_float): New function.
4232 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4233 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4234 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4235 Rewrite to use FIXNUM_BITS, as this simplifies things.
4236 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4237 Adjust signatures to match updated version of code.
4238 (consing_since_gc): Now EMACS_INT, since a single hash table can
4239 use more than INT_MAX bytes.
4240
4241 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4242
4243 Make it possible to build with GCC-4.6+ -O2 -flto.
4244
4245 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4246
4247 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4248
4249 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4250 Call minibuffer-inactive-mode.
4251
4252 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4255 Update dependencies.
4256
4257 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4258
4259 * data.c (init_data): Remove code for UTS, this system is not
4260 supported anymore.
4261
4262 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4263
4264 Don't force ./temacs to start in terminal mode.
4265
4266 * frame.c (make_initial_frame): Initialize faces in all cases, not
4267 only when CANNOT_DUMP is defined.
4268 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4269
4270 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4271
4272 * dispnew.c (add_window_display_history): Use const for the string
4273 pointer. Remove declaration, not needed.
4274
4275 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4276
4277 Use 'inline', not 'INLINE'.
4278 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4279 * alloc.c, fontset.c (INLINE): Remove.
4280 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4281 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4282 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4283 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4284 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4285
4286 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4287
4288 Make it possible to run ./temacs.
4289
4290 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4291 syms_of_callproc does the same thing. Remove test for
4292 "initialized", do it in the caller.
4293 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4294
4295 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4296
4297 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4298 (read_minibuf): Use get_minibuffer.
4299 (syms_of_minibuf): Use DEFSYM.
4300 (Qmetadata): New var.
4301 * data.c (Qbuffer): Don't make it static.
4302 (syms_of_data): Use DEFSYM.
4303
4304 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4307 (CCL_CODE_MIN): New macro.
4308
4309 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4312
4313 * eval.c (Qdebug): Now static.
4314 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4315 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4316 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4317
4318 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4319
4320 * image.c: Various fixes to ImageMagick code comments.
4321 (Fimagemagick_types): Doc fix.
4322
4323 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4324
4325 Minor fixes prompted by GCC 4.6.0 warnings.
4326
4327 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4328
4329 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4330 (x_clipboard_manager_save_all): Move extern decl to ...
4331 * xterm.h: ... here, so that it can be checked for consistency.
4332
4333 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4334
4335 * xselect.c (x_clipboard_manager_save_frame)
4336 (x_clipboard_manager_save_all): New functions.
4337 (Fx_clipboard_manager_save): Lisp function deleted.
4338
4339 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4340 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4341
4342 * xterm.h: Update prototype.
4343
4344 2011-05-28 William Xu <william.xwl@gmail.com>
4345
4346 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4347 exiting (Bug#8239).
4348
4349 2011-05-28 Jim Meyering <meyering@redhat.com>
4350
4351 Avoid a sign-extension bug in crypto_hash_function.
4352 * fns.c (to_uchar): Define.
4353 (crypto_hash_function): Use it to convert some newly-signed
4354 variables to unsigned, to avoid sign-extension bugs. For example,
4355 without this change, (md5 "truc") would evaluate to
4356 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4357 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4358 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4359
4360 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4361
4362 Integer overflow fixes.
4363
4364 * dbusbind.c: Serial number integer overflow fixes.
4365 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4366 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4367 to hold a serial number that is too large for a fixnum.
4368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4369 Check for serial numbers out of range. Decode any serial number
4370 that was so large that it became a float. (Bug#8722)
4371
4372 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4373 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4374 Use XFASTINT rather than XUINT when numbers are nonnegative.
4375 (xd_append_arg, Fdbus_method_return_internal):
4376 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4377 arguments, check that Lisp number is nonnegative, rather than
4378 silently wrapping negative numbers around. (Bug#8722)
4379 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4380 (Bug#8722)
4381
4382 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4383
4384 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4385
4386 ccl: add integer overflow checks
4387 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4388 (IN_INT_RANGE): New macros.
4389 (ccl_driver): Use them to check for integer overflow when
4390 decoding a CCL program. Many of the new checks are whether XINT (x)
4391 fits in int; it doesn't always, on 64-bit hosts. The new version
4392 doesn't catch all possible integer overflows, but it's an
4393 improvement. (Bug#8719)
4394
4395 * alloc.c (make_event_array): Use XINT, not XUINT.
4396 There's no need for unsigned here.
4397
4398 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4399 This follows up to the 2011-05-06 change that substituted uintptr_t
4400 for EMACS_INT. This case wasn't caught back then.
4401
4402 Rework Fformat to avoid integer overflow issues.
4403 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4404 now (part of C89). Include <verify.h>.
4405 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4406 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4407 (Fformat): Avoid the prepass trying to compute sizes; it was only
4408 approximate and thus did not catch overflow reliably. Instead, walk
4409 through the format just once, formatting and computing sizes as we go,
4410 checking for integer overflow at every step, and allocating a larger
4411 buffer as needed. Keep track separately whether the format is
4412 multibyte. Keep only the most-recently calculated precision, rather
4413 than them all. Record whether each argument has been converted to
4414 string. Use EMACS_INT, not int, for byte and char and arg counts.
4415 Support field widths and precisions larger than INT_MAX. Avoid
4416 sprintf's undefined behavior with conversion specifications such as %#d
4417 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4418 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4419 formatting out-of-range floating point numbers with int
4420 formats. (Bug#8668)
4421
4422 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4423
4424 * data.c: Avoid integer truncation in expressions involving floats.
4425 * data.c: Include <intprops.h>.
4426 (arith_driver): When there's an integer overflow in an expression
4427 involving floating point, convert the integers to floating point
4428 so that the resulting value does not suffer from catastrophic
4429 integer truncation. For example, on a 64-bit host (* 4
4430 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4431 Do not rely on undefined behavior after integer overflow.
4432
4433 merge count_size_as_multibyte, parse_str_to_multibyte
4434 * character.c, character.h (count_size_as_multibyte):
4435 Rename from parse_str_to_multibyte; all uses changed.
4436 Check for integer overflow.
4437 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4438 since it's now a duplicate of the other. This is more of
4439 a character than a buffer op, so better that it's in character.c.
4440 * fns.c, print.c: Adjust to above changes.
4441
4442 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4443
4444 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4445
4446 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4449 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4450 (x_clipboard_manager_save): Now static.
4451 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4452
4453 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4454 (crypto_hash_function): Now static.
4455 Fix pointer signedness problems. Avoid unnecessary initializations.
4456
4457 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4458
4459 * termhooks.h (Vselection_alist): Make it terminal-local.
4460
4461 * terminal.c (create_terminal): Initialize it.
4462
4463 * xselect.c: Support for clipboard managers.
4464 (Vselection_alist): Move to termhooks.h as terminal-local var.
4465 (LOCAL_SELECTION): New macro.
4466 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4467 (symbol_to_x_atom): Remove gratuitous arg.
4468 (x_handle_selection_request, lisp_data_to_selection_data)
4469 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4470 (x_own_selection, x_get_local_selection, x_convert_selection):
4471 New arg, specifying work frame. Use terminal-local Vselection_alist.
4472 (some_frame_on_display): Delete unused function.
4473 (Fx_own_selection_internal, Fx_get_selection_internal)
4474 (Fx_disown_selection_internal, Fx_selection_owner_p)
4475 (Fx_selection_exists_p): New optional frame arg.
4476 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4477 (x_handle_selection_clear): Don't treat other terminals with the
4478 same keyboard specially. Use the terminal-local Vselection_alist.
4479 (x_clear_frame_selections): Use Frun_hook_with_args.
4480
4481 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4482
4483 * xterm.h: Add support for those atoms.
4484
4485 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4486
4487 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4488 (converted_selections, conversion_fail_tag): New global variables.
4489 (x_selection_request_lisp_error): Free the above.
4490 (x_get_local_selection): Remove unnecessary code.
4491 (x_reply_selection_request): Args changed; handle arbitrary array
4492 of converted selections stored in converted_selections.
4493 Separate the XChangeProperty and SelectionNotify steps.
4494 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4495 (x_convert_selection): New function.
4496 (x_handle_selection_event): Simplify.
4497 (x_get_foreign_selection): Don't ignore incoming requests while
4498 waiting for an answer; this will fail when we implement
4499 SAVE_TARGETS, and seems unnecessary anyway.
4500 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4501 (Vx_sent_selection_functions): Doc fix.
4502
4503 2011-05-26 Leo Liu <sdl.web@gmail.com>
4504
4505 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4506
4507 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4508
4509 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4510
4511 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4512 for fringe update if it has periodic bitmap.
4513 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4514 and fringe_bitmap_periodic_p.
4515
4516 * fringe.c (get_fringe_bitmap_data): New function.
4517 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4518 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4519 row. Mark glyph row for fringe update if periodicity changed.
4520
4521 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4522 for fringe update unless it has periodic bitmap.
4523
4524 2011-05-25 Kenichi Handa <handa@m17n.org>
4525
4526 * xdisp.c (get_next_display_element): Set correct it->face_id for
4527 a static composition.
4528
4529 2011-05-24 Leo Liu <sdl.web@gmail.com>
4530
4531 * deps.mk (fns.o):
4532 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4533
4534 * fns.c (crypto_hash_function, Fsha1): New function.
4535 (Fmd5): Use crypto_hash_function.
4536 (syms_of_fns): Add Ssha1.
4537
4538 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * gnutls.c: Remove unused macros.
4541 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4542 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4543 Remove macros that are defined and never used.
4544 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4545
4546 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4547
4548 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4549 (Fx_get_selection_internal): Minor cleanup.
4550 (Fx_own_selection_internal): Rename arguments for consistency with
4551 select.el.
4552
4553 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4554
4555 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4556
4557 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4558
4559 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4560
4561 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4562
4563 * dispnew.c (scrolling_window): Don't exclude the case that the
4564 last enabled row in the desired matrix touches the bottom boundary.
4565
4566 2011-05-21 Glenn Morris <rgm@gnu.org>
4567
4568 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4569 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4570 and add some more files.
4571
4572 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4573
4574 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4575 report_file_error introduced by the change from 2011-05-07.
4576
4577 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 * systime.h (Time): Define only if emacs is defined.
4580 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4581 where the include path doesn't have X11/X.h by default. See
4582 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4583
4584 2011-05-20 Kenichi Handa <handa@m17n.org>
4585
4586 * composite.c (find_automatic_composition): Fix previous change.
4587
4588 2011-05-20 Glenn Morris <rgm@gnu.org>
4589
4590 * lisp.mk: New file, split from Makefile.in.
4591 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4592 (shortlisp): Remove.
4593 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4594
4595 2011-05-19 Glenn Morris <rgm@gnu.org>
4596
4597 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4598 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4599 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4600 (lisp): Set the order to that of loadup.el.
4601 (shortlisp): Make it a copy of $lisp.
4602 (SOME_MACHINE_LISP): Remove.
4603 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4604 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4605
4606 2011-05-18 Kenichi Handa <handa@m17n.org>
4607
4608 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4609 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4610 (find_automatic_composition): Mostly rewrite for efficiency.
4611
4612 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4613
4614 * makefile.w32-in: Update dependencies.
4615
4616 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4617
4618 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4619 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4620
4621 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 Fix some integer overflow issues, such as string length overflow.
4624
4625 * insdel.c (count_size_as_multibyte): Check for string overflow.
4626
4627 * character.c (lisp_string_width): Check for string overflow.
4628 Use EMACS_INT, not int, for string indexes and lengths; in
4629 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4630 the resulting string length overflows an EMACS_INT; instead,
4631 report a string overflow if no precision given. When checking for
4632 precision exhaustion, use a check that cannot possibly have
4633 integer overflow. (Bug#8675)
4634 * character.h (lisp_string_width): Adjust to new signature.
4635
4636 * alloc.c (string_overflow): New function.
4637 (Fmake_string): Use it. This doesn't change behavior, but saves
4638 a few bytes and will simplify future changes.
4639 * character.c (string_escape_byte8): Likewise.
4640 * lisp.h (string_overflow): New decl.
4641
4642 Fixups, following up to the user-interface timestamp change.
4643 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4644 for UI timestamps, instead of unsigned long.
4645 * msdos.c (mouse_get_pos): Likewise.
4646 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4647 * w32gui.h (Time): Define by including "systime.h" rather than by
4648 declaring it ourselves. (Bug#8664)
4649
4650 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4651 * image.c (clear_image_cache): Likewise.
4652
4653 * term.c (term_mouse_position): Don't assume time_t wraparound.
4654
4655 Be more systematic about user-interface timestamps.
4656 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4657 and sometimes 'EMACS_UINT', to represent these timestamps.
4658 This change causes it to use 'Time' uniformly, as that's what X uses.
4659 This makes the code easier to follow, and makes it easier to catch
4660 integer overflow bugs such as Bug#8664.
4661 * frame.c (Fmouse_position, Fmouse_pixel_position):
4662 Use Time, not unsigned long, for user-interface timestamps.
4663 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4664 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4665 * keyboard.h (last_event_timestamp): Likewise.
4666 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4667 * menu.h (xmenu_show): Likewise.
4668 * term.c (term_mouse_position): Likewise.
4669 * termhooks.h (struct input_event.timestamp): Likewise.
4670 (struct terminal.mouse_position_hook): Likewise.
4671 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4672 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4673 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4674 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4675 what it was before.
4676 * menu.h, termhooks.h: Include "systime.h", for Time.
4677
4678 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4679 Don't assume that the difference between two unsigned long values
4680 can fit into an integer. At this point, we know button_down_time
4681 <= event->timestamp, so the difference must be nonnegative, so
4682 there's no need to cast the result if double-click-time is
4683 nonnegative, as it should be; check that it's nonnegative, just in
4684 case. This bug is triggered when events are more than 2**31 ms
4685 apart (about 25 days). (Bug#8664)
4686
4687 * xselect.c (last_event_timestamp): Remove duplicate decl.
4688 (x_own_selection): Remove needless cast to unsigned long.
4689
4690 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4691 that always fit in int. Use a sentinel instead of a counter, to
4692 avoid a temp and to allay GCC's concerns about possible int overflow.
4693 * frame.h (struct frame): Use int for menu_bar_items_used
4694 instead of EMACS_INT, since it always fits in int.
4695
4696 * menu.c (grow_menu_items): Check for int overflow.
4697
4698 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4699
4700 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4701 Before, the code was not consistent. These values cannot exceed
4702 2**31 - 1 so there's no need to make them unsigned.
4703 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4704 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4705 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4706 as modifiers.
4707 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4708
4709 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4710 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4711 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4712 presumably because the widths might not match.
4713
4714 * window.c (size_window): Avoid needless test at loop start.
4715
4716 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4717
4718 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4719
4720 2011-05-12 Drew Adams <drew.adams@oracle.com>
4721
4722 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4723
4724 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4725
4726 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4727 `width' to `bar_area_x' and `bar_area_width', respectively.
4728 (x_scroll_run): Take account of fringe background extension.
4729
4730 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4731 Rename local vars `left' and `width' to `bar_area_x' and
4732 `bar_area_width', respectively.
4733 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4734 background extension.
4735
4736 2011-05-10 Jim Meyering <meyering@redhat.com>
4737
4738 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4739
4740 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4741
4742 * image.c (Finit_image_library): Return t for built-in image types,
4743 like pbm and xbm. (Bug#8640)
4744
4745 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4746
4747 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4748
4749 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4750
4751 * w32console.c (Fset_screen_color): Doc fix.
4752 (Fget_screen_color): New function.
4753 (syms_of_ntterm): Defsubr it.
4754
4755 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4756 unlink the temporary file if Fcall_process didn't create it in the
4757 first place.
4758 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4759 child process will be redirected to a file specified with `:file'.
4760 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4761 cue to call_process_cleanup not to close that handle.
4762
4763 2011-05-07 Ben Key <bkey76@gmail.com>
4764
4765 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4766 one of two shell specific rules, either bootstrap-temacs-CMD or
4767 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4768 to the previous implementation of the bootstrap-temacs rule.
4769 The bootstrap-temacs-CMD rule is similar to the previous
4770 implementation of the bootstrap-temacs rule except that it
4771 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4772 variable.
4773
4774 These changes, along with some changes to nt/configure.bat,
4775 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4776 earlier fix to add support for --cflags and --ldflags options
4777 that include quotes so that it works whether make uses cmd or
4778 sh as the shell.
4779
4780 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4781
4782 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4783 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4784 is a constant.
4785 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4786 a string. Handle both cases.
4787 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4788 (Fdbus_register_method): Use Qinvalid_function.
4789
4790 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4791
4792 * makefile.w32-in: Update dependencies.
4793 (LISP_H): Add inttypes.h and stdin.h.
4794 (PROCESS_H): Add unistd.h.
4795
4796 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4797
4798 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4799 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4800
4801 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4804
4805 * term.c (vfatal): Remove stray call to va_end.
4806 It's not needed and the C Standard doesn't allow it here anyway.
4807
4808 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4809 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4810
4811 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4812 bytes.
4813
4814 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4815
4816 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4817
4818 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4819
4820 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4821
4822 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4823
4824 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4825 * charset.c (Fdefine_charset_internal): Don't initialize
4826 charset.code_space[15]. The value was garbage, on hosts with
4827 32-bit int (Bug#8600).
4828
4829 * lread.c (read_integer): Be more consistent with string-to-number.
4830 Use string_to_number to do the actual conversion; this avoids
4831 rounding errors and fixes some other screwups. Without this fix,
4832 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4833 (digit_to_number): Move earlier, for benefit of read_integer.
4834 Return -1 if the digit is out of range for the base, -2 if it is
4835 not a digit in any supported base. (Bug#8602)
4836
4837 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4838
4839 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4840 to match comment at start of function. This also removes a
4841 GCC warning about overflow in a 32+64-bit port.
4842
4843 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4844
4845 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4846 Reported by Stefan Monnier in
4847 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4848 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4849 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4850
4851 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4852 (EMACS_UINTPTR): Likewise, with uintptr_t.
4853
4854 * lisp.h: Prefer 64-bit EMACS_INT if available.
4855 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4856 on 32-bit hosts that have 64-bit int, so that they can access
4857 large files.
4858 However, temporarily disable this change unless the temporary
4859 symbol WIDE_EMACS_INT is defined.
4860
4861 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4862
4863 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4864 This removes an assumption that EMACS_INT and long are the same
4865 width as pointers. The assumption is true for Emacs porting targets
4866 now, but we want to make other targets possible.
4867 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4868 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4869 In the rest of the code, change types of integers that hold casted
4870 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4871 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4872 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4873 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4874 No need to cast type when ORing.
4875 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4876 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4877 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4878 assume EMACS_INT is the same width as char *.
4879 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4880 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4881 Remove no-longer-needed casts.
4882 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4883 (xg_tool_bar_help_callback, xg_make_tool_item):
4884 Use EMACS_INTPTR to hold an integer
4885 that will be cast to void *; this can avoid a GCC warning
4886 if EMACS_INT is not the same width as void *.
4887 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4888 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4889 (current_message_1, set_message_1):
4890 Use a local to convert to proper width without a cast.
4891 * xmenu.c (dialog_selection_callback): Likewise.
4892
4893 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4894 Also, don't assume VALBITS / RAND_BITS is less than 5,
4895 and don't rely on undefined behavior when shifting a 1 left into
4896 the sign bit.
4897 * lisp.h (get_random): Change signature to match.
4898
4899 * lread.c (hash_string): Use size_t, not int, for hash computation.
4900 Normally we prefer signed values; but hashing is special, because
4901 it's better to use unsigned division on hash table sizes so that
4902 the remainder is nonnegative. Also, size_t is the natural width
4903 for hashing into memory. The previous code used 'int', which doesn't
4904 retain enough info to hash well into very large tables.
4905 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4906
4907 * dbusbind.c: Don't possibly lose pointer info when converting.
4908 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4909 Use XPNTR rather than XHASH, so that the high-order bits of
4910 the pointer aren't lost when converting through void *.
4911
4912 * eval.c (Fautoload): Don't double-shift a pointer.
4913
4914 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4915
4916 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4917
4918 * gnutls.c (DEF_GNUTLS_FN):
4919 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4920
4921 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4922
4923 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4924 marker. (Bug#8610)
4925
4926 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4927
4928 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4929 New version that can reserve upto 2GB of heap space.
4930
4931 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4932
4933 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4934
4935 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4936
4937 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4938 `gnutls_certificate_set_x509_key_file'.
4939
4940 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4943 Update dependencies.
4944
4945 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4946
4947 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4948 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4949 Remove unused parameter `fildes'.
4950 * process.c (read_process_output, send_process): Don't pass it.
4951
4952 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4953
4954 Fix previous change: the library cache is defined in w32.c.
4955 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4956 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4957
4958 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4959
4960 Implement dynamic loading of GnuTLS on Windows.
4961
4962 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4963 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4964 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4965 Declare.
4966
4967 * gnutls.c (Qgnutls_dll): Define.
4968 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4969 (gnutls_*): Declare function pointers.
4970 (init_gnutls_functions): New function to initialize function pointers.
4971 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4972 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4973 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4974 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4975 (emacs_gnutls_write, emacs_gnutls_read)
4976 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4977 (Fgnutls_available_p): New function.
4978 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4979 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4980 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4981
4982 * image.c: Include w32.h.
4983 (Vimage_type_cache): Delete.
4984 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4985 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4986 (w32_delayed_load): Move to w32.c.
4987
4988 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4989
4990 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4991 (w32_delayed_load): Move from image.c. When loading a library, record
4992 its filename in the :loaded-from property of the library id.
4993 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4994 Initialize and staticpro them.
4995 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4996
4997 * process.c: Include lisp.h before w32.h, not after.
4998 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4999 instead of gnutls_record_check_pending.
5000
5001 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5002
5003 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5004
5005 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5006 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5007 as passed in.
5008
5009 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5010
5011 * xterm.c (x_set_frame_alpha): Do not set property on anything
5012 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5013
5014 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5015
5016 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5017
5018 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5021 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5022 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5023 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5024 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5025 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5026 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5027 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5028 (Qgnutls_bootprop_callbacks_verify): Make static.
5029
5030 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5031
5032 * callproc.c: Indentation fixup.
5033
5034 * sysdep.c (wait_for_termination_1): Make static.
5035 (wait_for_termination, interruptible_wait_for_termination):
5036 Move after wait_for_termination_1.
5037
5038 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5039
5040 * sysdep.c (interruptible_wait_for_termination): New function
5041 which is like wait_for_termination, but allows keyboard
5042 interruptions.
5043
5044 * callproc.c (Fcall_process): Add (:file "file") as an option for
5045 the STDOUT buffer.
5046 (Fcall_process_region): Ditto.
5047
5048 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5049
5050 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5051 rather than `XVECTOR (FOO)->size'.
5052
5053 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5054 inttypes.h, as a gnulib replacement is used if it not available in
5055 system headers.
5056
5057 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5058
5059 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5060 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5061 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5062
5063 * coding.c (coding_alloc_by_realloc): Error out if destination
5064 will grow beyond MOST_POSITIVE_FIXNUM.
5065 (decode_coding_emacs_mule): Abort if there isn't enough place in
5066 charbuf for the composition carryover bytes. Reserve an extra
5067 space for up to 2 characters produced in a loop.
5068 (decode_coding_iso_2022): Abort if there isn't enough place in
5069 charbuf for the composition carryover bytes.
5070
5071 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5072
5073 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5074 aborting when %lld or %lll format is passed.
5075 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5076 %llo or %llx format is passed. (Bug#8545)
5077
5078 * window.c (window_scroll_line_based): Use a marker instead of
5079 simple variables to record original value of point. (Bug#7952)
5080
5081 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5082 produced by %s or %c overflows available buffer space. (Bug#8545)
5083
5084 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5085
5086 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5087 (SIZE_MAX): Move defn after all includes, as they might #define it.
5088
5089 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5090
5091 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5092
5093 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * keyboard.c (Qdelayed_warnings_hook): Define.
5096 (command_loop_1): Run `delayed-warnings-hook'
5097 if Vdelayed_warnings_list is non-nil.
5098 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5099 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5100
5101 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5102
5103 * doprnt.c (doprnt): Don't return value smaller than the buffer
5104 size if the message was truncated. (Bug#8545).
5105
5106 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5109 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5110
5111 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5114
5115 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5116
5117 * makefile.w32-in: Update dependencies.
5118
5119 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5120
5121 Improve `doprnt' and its usage. (Bug#8545)
5122 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5123 `format_end'. Remove support for %l as a conversion specifier.
5124 Don't use xrealloc. Improve diagnostics when the %l size modifier
5125 is used. Update the commentary.
5126
5127 * eval.c (verror): Simplify calculation of size_t.
5128
5129 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5130 messages.
5131
5132 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5133
5134 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5135 change.
5136
5137 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5138
5139 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5140 This makes this file independent of the recent pseudovector change.
5141
5142 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5145
5146 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5147 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5148 Remove unused local.
5149 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5150
5151 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5152 GCC 4.6.0 optimizes based on type-based alias analysis.
5153 For example, if b is of type struct buffer * and v of type struct
5154 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5155 != &v->size, and therefore "v->size = 1; b->size = 2; return
5156 v->size;" must therefore return 1. This assumption is incorrect
5157 for Emacs, since it type-puns struct Lisp_Vector * with many other
5158 types. To fix this problem, this patch adds a new type struct
5159 vectorlike_header that documents the constraints on layout of vectors
5160 and pseudovectors, and helps optimizing compilers not get fooled
5161 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5162 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5163 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5164 the size member.
5165 (XSETPVECTYPE): Rewrite in terms of new macro.
5166 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5167 This is a bit clearer, and further avoids the possibility of
5168 undesirable aliasing.
5169 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5170 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5171 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5172 since Lisp_Subr is a special case (no "next" field).
5173 (ASIZE): Now uses header.size rather than size.
5174 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5175 to avoid the hassle of writing XVECTOR (foo)->header.size.
5176 (struct vectorlike_header): New type.
5177 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5178 object, to help avoid aliasing.
5179 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5180 (SUBRP): Likewise, since Lisp_Subr is a special case.
5181 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5182 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5183 (struct Lisp_Hash_Table): Combine first two members into a single
5184 struct vectorlike_header member. All uses of "size" and "next" members
5185 changed to be "header.size" and "header.next".
5186 * buffer.h (struct buffer): Likewise.
5187 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5188 * frame.h (struct frame): Likewise.
5189 * process.h (struct Lisp_Process): Likewise.
5190 * termhooks.h (struct terminal): Likewise.
5191 * window.c (struct save_window_data, struct saved_window): Likewise.
5192 * window.h (struct window): Likewise.
5193 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5194 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5195 * buffer.c (init_buffer_once): Likewise.
5196 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5197 special case.
5198 * process.c (Fformat_network_address): Use local var for size,
5199 for brevity.
5200
5201 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5202
5203 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5204 * data.c (atof): Remove decl; no longer used or needed.
5205 (digit_to_number): Move to lread.c.
5206 (Fstring_to_number): Use new string_to_number function, to be
5207 consistent with how the Lisp reader treats infinities and NaNs.
5208 Do not assume that floating-point numbers represent EMACS_INT
5209 without losing information; this is not true on most 64-bit hosts.
5210 Avoid double-rounding errors, by insisting on integers when
5211 parsing non-base-10 numbers, as the documentation specifies.
5212 * lisp.h (string_to_number): New decl, replacing ...
5213 (isfloat_string): Remove.
5214 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5215 (read1): Do not accept +. and -. as integers; this
5216 appears to have been a coding error. Similarly, do not accept
5217 strings like +-1e0 as floating point numbers. Do not report
5218 overflow for integer overflows unless the base is not 10 which
5219 means we have no simple and reliable way to continue.
5220 Break out the floating-point parsing into a new
5221 function string_to_number, so that Fstring_to_number parses
5222 floating point numbers consistently with the Lisp reader.
5223 (digit_to_number): Move here from data.c. Make it static inline.
5224 (E_CHAR, EXP_INT): Remove, replacing with ...
5225 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5226 (string_to_number): New function, replacing isfloat_string.
5227 This function checks for valid syntax and produces the resulting
5228 Lisp float number too. Rework it so that string-to-number
5229 no longer mishandles examples like "1.0e+". Use strtoumax,
5230 so that overflow for non-base-10 numbers is reported only when
5231 there's no portable and simple way to convert to floating point.
5232
5233 * textprop.c (set_text_properties_1): Rewrite for clarity,
5234 and to avoid GCC warning about integer overflow.
5235
5236 * intervals.h (struct interval): Use EMACS_INT for members
5237 where EMACS_UINT might cause problems. See
5238 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5239 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5240 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5241 All uses changed.
5242 (offset_intervals): Tell GCC not to worry about length overflow
5243 when negating a negative length.
5244
5245 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5246 (overrun_check_free): Likewise.
5247
5248 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5249 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5250 word size.
5251
5252 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5253 (gnutls_make_error): Rename local to avoid shadowing.
5254 (gnutls_emacs_global_deinit): ifdef out; not used.
5255 (Fgnutls_boot): Use const for pointer to readonly storage.
5256 Comment out unused local. Fix pointer signedness problems.
5257
5258 * lread.c (openp): Don't stuff size_t into an 'int'.
5259 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5260 about possible signed overflow.
5261
5262 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5263 (GDK_KEY_g): Don't define if already defined.
5264 (xg_prepare_tooltip): Avoid pointer signedness problem.
5265 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5266
5267 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5268 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5269
5270 * xfns.c (Fx_window_property): Simplify a bit,
5271 to make a bit faster and to avoid GCC 4.6.0 warning.
5272 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5273
5274 * fns.c (internal_equal): Don't assume size_t fits in int.
5275
5276 * alloc.c (compact_small_strings): Tighten assertion a little.
5277
5278 Replace pEd with more-general pI, and fix some printf arg casts.
5279 * lisp.h (pI): New macro, generalizing old pEd macro to other
5280 conversion specifiers. For example, use "...%"pI"d..." rather
5281 than "...%"pEd"...".
5282 (pEd): Remove. All uses replaced with similar uses of pI.
5283 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5284 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5285 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5286 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5287 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5288 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5289 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5290 64-bit hosts.
5291 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5292 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5293 * print.c (safe_debug_print, print_object): Likewise.
5294 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5295 to int.
5296 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5297 avoiding the 0 flag, which is not portable.
5298 * process.c (Fmake_network_process): Use pI to avoid cast.
5299 * region-cache.c (pp_cache): Likewise.
5300 * xdisp.c (decode_mode_spec): Likewise.
5301 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5302 behavior on 64-bit hosts with printf arg.
5303 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5304 (x_stop_queuing_selection_requests): Likewise.
5305 (x_get_window_property): Don't truncate byte count to an 'int'
5306 when tracing.
5307
5308 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5309 here, since it parses constructs like leading '-' and spaces,
5310 which are not wanted; and it overflows with large numbers.
5311 Instead, simply match F[0-9]+, which is what is wanted anyway.
5312
5313 * alloc.c: Remove unportable assumptions about struct layout.
5314 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5315 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5316 (allocate_vectorlike, make_pure_vector): Use the new macros,
5317 plus offsetof, to remove unportable assumptions about struct layout.
5318 These assumptions hold on all porting targets that I know of, but
5319 they are not guaranteed, they're easy to remove, and removing them
5320 makes further changes easier.
5321
5322 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5323 This doesn't fix a bug but makes the code clearer.
5324 (string_overrun_cookie): Now const. Use initializers that
5325 don't formally overflow signed char, to avoid warnings.
5326 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5327 can cause Emacs to crash when string overrun checking is enabled.
5328 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5329 multiple of sizeof (EMACS_INT); it need not be, if
5330 alignof(EMACS_INT) < sizeof (EMACS_INT).
5331 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5332
5333 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5334
5335 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5336
5337 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5338
5339 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5340 supposed to be handshaking. (Bug#8556)
5341 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5342
5343 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5344
5345 * lisp.h (Qdebug): List symbol.
5346 * eval.c (Qdebug): Restore global linkage.
5347 * keyboard.c (debug-on-event): New variable.
5348 (handle_user_signal): Break into debugger when debug-on-event
5349 matches the current signal symbol.
5350
5351 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5352
5353 * alloc.c (check_sblock, check_string_bytes)
5354 (check_string_free_list): Convert to standard C.
5355
5356 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5357
5358 * w32.c (emacs_gnutls_push): Fix typo.
5359
5360 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5361
5362 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5363 "cast to pointer from integer of different size".
5364
5365 Improve doprnt and its use in verror. (Bug#8545)
5366 * doprnt.c (doprnt): Document the set of format control sequences
5367 supported by the function. Use SAFE_ALLOCA instead of always
5368 using `alloca'.
5369
5370 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5371 is one byte too soon. Don't use xrealloc; instead xfree and
5372 xmalloc anew.
5373
5374 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5375
5376 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5377 callbacks stage.
5378
5379 * gnutls.c: Renamed global_initialized to
5380 gnutls_global_initialized. Added internals for the
5381 :verify-hostname-error, :verify-error, and :verify-flags
5382 parameters of `gnutls-boot' and documented those parameters in the
5383 docstring. Start callback support.
5384 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5385 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5386 on error. Return error code.
5387 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5388 (emacs_gnutls_read): Likewise.
5389 (Fgnutls_boot): Return handshake error code.
5390 (emacs_gnutls_handle_error): New function.
5391 (wsaerror_to_errno): Likewise.
5392
5393 * w32.h (emacs_gnutls_pull): Add prototype.
5394 (emacs_gnutls_push): Likewise.
5395
5396 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5397 (emacs_gnutls_push): Likewise.
5398
5399 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5400
5401 * process.c (wait_reading_process_output): Check if GnuTLS
5402 buffered some data internally if no FDs are set for TLS
5403 connections.
5404
5405 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5406 (LIBS): Link to USER_LIBS.
5407 ($(BLD)/gnutls.$(0)): New target.
5408
5409 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5410
5411 * xdisp.c (handle_single_display_spec): Rename the
5412 display_replaced_before_p argument into display_replaced_p, to
5413 make it consistent with the commentary. Fix typos in the
5414 commentary.
5415
5416 * textprop.c (syms_of_textprop): Remove dead code.
5417 (copy_text_properties): Delete obsolete commentary about an
5418 interface that was deleted long ago. Fix typos in the description
5419 of arguments.
5420
5421 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5422 to changes in oldXMenu/XMenu.h from 2011-04-16.
5423 <menu_help_message, prev_menu_help_message>: Constify.
5424 (IT_menu_make_room): menu->help_text is now `const char **';
5425 adjust.
5426
5427 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5428 to changes in oldXMenu/XMenu.h from 2011-04-16.
5429 (struct XMenu): Declare `help_text' `const char **'.
5430
5431 * xfaces.c <Qunspecified>: Make extern again.
5432
5433 * syntax.c: Include sys/types.h before including regex.h, as
5434 required by Posix.
5435
5436 * doc.c (get_doc_string): Improve the format passed to `error'.
5437
5438 * doprnt.c (doprnt): Improve commentary.
5439
5440 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5441
5442 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5443 them with etags.
5444
5445 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5446 changes in globals.h immediately force recompilation.
5447 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5448 $(CURDIR)/s/ms-w32.h.
5449 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5450
5451 * character.c (Fchar_direction): Function deleted.
5452 (syms_of_character): Don't defsubr it.
5453 <char-direction-table>: Deleted.
5454
5455 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5456
5457 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5458 * doprnt.c: Include limits.h.
5459 (SIZE_MAX): New macro.
5460 (doprnt): Return a size_t value. 2nd arg is now size_t.
5461 Many local variables are now size_t instead of int or unsigned.
5462 Improve overflow protection. Support `l' modifier for integer
5463 conversions. Support %l conversion. Don't assume an EMACS_INT
5464 argument for integer conversions and for %c.
5465
5466 * lisp.h (doprnt): Restore prototype.
5467
5468 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5469 $(SRC)/character.h.
5470
5471 * Makefile.in (base_obj): Add back doprnt.o.
5472
5473 * deps.mk (doprnt.o): Add back prerequisites.
5474 (callint.o): Depend on character.h.
5475
5476 * eval.c (internal_lisp_condition_case): Include the handler
5477 representation in the error message.
5478 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5479 when breaking from the loop.
5480
5481 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5482
5483 * callint.c (Fcall_interactively): When displaying error message
5484 about invalid control letter, pass the character's codepoint, not
5485 a pointer to its multibyte form. Improve display of the character
5486 in octal and display also its hex code.
5487
5488 * character.c (char_string): Use %x to display the (unsigned)
5489 codepoint of an invalid character, to avoid displaying a bogus
5490 negative value.
5491
5492 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5493 `error', not SYMBOL_NAME itself.
5494
5495 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5496 character arguments to `error'.
5497
5498 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5499 to `error' in error message about FINAL_CHAR argument. Make sure
5500 FINAL_CHAR is a character, and use %c when it is passed as
5501 argument to `error'.
5502
5503 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5504
5505 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5506
5507 * w32.c: Include <time.h>.
5508 (sys_localtime): New function.
5509
5510 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5511
5512 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5513
5514 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5515
5516 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5517
5518 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5519 zombies (Bug#8467).
5520
5521 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5522
5523 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5524 gl_state.e_property when gl_state.object is Qt.
5525
5526 * insdel.c (make_gap_larger): Remove limitation of buffer size
5527 to <= INT_MAX.
5528
5529 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5530
5531 * xdisp.c (lookup_glyphless_char_display)
5532 (produce_glyphless_glyph): Handle cons cell entry in
5533 glyphless-char-display.
5534 (Vglyphless_char_display): Document it.
5535
5536 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5537 glyphless-char-display.
5538
5539 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5540
5541 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5542
5543 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5544
5545 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5546 definition for no-X builds.
5547
5548 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5549
5550 Static checks with GCC 4.6.0 and non-default toolkits.
5551
5552 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5553
5554 * process.c (keyboard_bit_set): Define only if SIGIO.
5555 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5556 (send_process): Repair possible setjmp clobbering.
5557
5558 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5559
5560 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5561
5562 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5563
5564 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5565 Define only if needed.
5566
5567 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5568 by pacifying GCC about it. Maybe it's time to retire it?
5569 * xfaces.c (USG, __TIMEVAL__): Likewise.
5570
5571 * dispextern.h (struct redisplay_interface): Rename param
5572 to avoid shadowing.
5573 * termhooks.h (struct terminal): Likewise.
5574 * xterm.c (xembed_send_message): Likewise.
5575
5576 * insdel.c (make_gap_smaller): Define only if
5577 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5578
5579 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5580 it.
5581
5582 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5583 so that we aren't warned about unused symbols.
5584
5585 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5586
5587 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5588
5589 * xfns.c (x_real_positions): Mark locals as initialized.
5590
5591 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5592
5593 * xterm.c: Fix problems found by static analysis with other toolkits.
5594 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5595 (x_dispatch_event): Declare static if USE_GTK, and
5596 define if USE_GTK || USE_X_TOOLKIT.
5597 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5598 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5599 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5600 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5601
5602 * xmenu.c (menu_help_callback): Pointer type fixes.
5603 Use const pointers when pointing at readonly data. Avoid pointer
5604 signedness clashes.
5605 (FALSE): Remove unused macro.
5606 (update_frame_menubar): Remove unused decl.
5607
5608 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5609
5610 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5611 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5612 (single_menu_item): Rename local to avoid shadowing.
5613
5614 * keyboard.c (make_lispy_event): Remove unused local var.
5615
5616 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5617 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5618
5619 * bitmaps: Change bitmaps from unsigned char back to the X11
5620 compatible char. Avoid the old compiler warnings about
5621 out-of-range initializers by using, for example, '\xab' rather
5622 than 0xab.
5623
5624 * xgselect.c (xgselect_initialize): Check vs interface
5625 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5626
5627 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5628
5629 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5630 to read-only memory.
5631
5632 * fns.c (vector): Remove; this old hack is no longer needed.
5633
5634 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5635 Remove unused var.
5636 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5637
5638 * xrdb.c (x_load_resources): Omit unused local.
5639
5640 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5641 (x_window): Rename locals to avoid shadowing.
5642 (USG): Use the kludged USG macro, to pacify gcc.
5643
5644 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5645 (x_term_init): Remove local to avoid shadowing.
5646
5647 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5648
5649 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5650 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5651
5652 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5653
5654 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5655
5656 Fix regex.c, syntax.c and friends for buffers > 2GB.
5657 * syntax.h (struct gl_state_s): Declare character position members
5658 EMACS_INT.
5659
5660 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5661
5662 * textprop.c (verify_interval_modification, interval_of):
5663 Declare arguments EMACS_INT.
5664
5665 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5666 EMACS_INT.
5667
5668 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5669
5670 * indent.c (Fvertical_motion): Local variable it_start is now
5671 EMACS_INT.
5672
5673 * regex.c (re_match, re_match_2, re_match_2_internal)
5674 (bcmp_translate, regcomp, regexec, print_double_string)
5675 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5676 (re_compile_pattern, re_exec): Declare arguments and local
5677 variables `size_t' and `ssize_t' and return values `regoff_t', as
5678 appropriate.
5679 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5680 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5681 <compile_stack_type>: `size' and `avail' are now `size_t'.
5682
5683 * regex.h <regoff_t>: Use ssize_t, not int.
5684 (re_search, re_search_2, re_match, re_match_2): Arguments that
5685 specify buffer/string position and length are now ssize_t and
5686 size_t. Return type is regoff_t.
5687
5688 2011-04-16 Ben Key <bkey76@gmail.com>
5689
5690 * nsfont.m: Fixed bugs in ns_get_family and
5691 ns_descriptor_to_entity that were caused by using free to
5692 deallocate memory blocks that were allocated by xmalloc (via
5693 xstrdup). This caused Emacs to crash when compiled with
5694 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5695 --enable-checking=xmallocoverrun). xfree is now used to
5696 deallocate these memory blocks.
5697
5698 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5701
5702 emacs_write: Accept and return EMACS_INT for sizes.
5703 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5704 et seq.
5705 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5706 Accept and return EMACS_INT.
5707 (emacs_gnutls_write): Return the number of bytes written on
5708 partial writes.
5709 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5710 (emacs_read, emacs_write): Remove check for negative size, as the
5711 Emacs source code has been audited now.
5712 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5713 (emacs_read, emacs_write): Use it.
5714 * process.c (send_process): Adjust to the new signatures of
5715 emacs_write and emacs_gnutls_write. Do not attempt to store
5716 a byte offset into an 'int'; it might overflow.
5717 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5718
5719 * sound.c: Don't assume sizes fit in 'int'.
5720 (struct sound_device.period_size, alsa_period_size):
5721 Return EMACS_INT, not int.
5722 (struct sound_device.write, vox_write, alsa_write):
5723 Accept EMACS_INT, not int.
5724 (wav_play, au_play): Use EMACS_INT to store sizes and to
5725 record read return values.
5726
5727 2011-04-15 Ben Key <bkey76@gmail.com>
5728
5729 * keyboard.c (Qundefined): Don't declare static since it is used
5730 in nsfns.m.
5731 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5732 static since they are used in nsfont.m.
5733
5734 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5735
5736 * process.c (Qprocessp): Don't declare static.
5737 * lisp.h (Qprocessp): Declare again.
5738
5739 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5740
5741 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5742
5743 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5744
5745 Improve C-level modularity by making more things 'static'.
5746
5747 Don't publish debugger-only interfaces to other modules.
5748 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5749 (verify_bytepos, count_markers): Move decls to the only modules
5750 that need them.
5751 * region-cache.h (pp_cache): Likewise.
5752 * window.h (check_all_windows): Likewise.
5753 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5754
5755 * sysdep.c (croak): Now static, if
5756 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5757 * syssignal.h (croak): Declare only if not static.
5758
5759 * alloc.c (refill_memory_reserve): Now static if
5760 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5761 * lisp.h (refill_memory_reserve): Declare only if not static.
5762
5763 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5764 Define only if USE_LUCID.
5765
5766 * xrdb.c (x_customization_string, x_rm_string): Now static.
5767
5768 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5769 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5770
5771 * xdisp.c (draw_row_with_mouse_face): Now static.
5772 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5773
5774 * window.h (check_all_windows): Mark externally visible.
5775
5776 * window.c (window_deletion_count): Now static.
5777
5778 * undo.c: Make symbols static if they're not exported.
5779 (last_undo_buffer, last_boundary_position, pending_boundary):
5780 Now static.
5781
5782 * textprop.c (interval_insert_behind_hooks): Now static.
5783 (interval_insert_in_front_hooks): Likewise.
5784
5785 * term.c: Make symbols static if they're not exported.
5786 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5787 (max_frame_lines, tty_set_terminal_modes):
5788 (tty_reset_terminal_modes, tty_turn_off_highlight):
5789 (get_tty_terminal): Now static.
5790 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5791 * termhooks.h (term_mouse_moveto): Do not declare if
5792 HAVE_WINDOW_SYSTEM.
5793 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5794 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5795
5796 * sysdep.c: Make symbols static if they're not exported.
5797 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5798 Now static.
5799 (sigprocmask_set, full_mask): Remove; unused.
5800 (wait_debugging): Mark as visible.
5801 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5802 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5803
5804 * syntax.c (syntax_temp): Define only if !__GNUC__.
5805
5806 * sound.c (current_sound_device, current_sound): Now static.
5807
5808 * search.c (searchbufs, searchbuf_head): Now static.
5809
5810 * scroll.c (scroll_cost): Remove; unused.
5811 * dispextern.h (scroll_cost): Remove decl.
5812
5813 * region-cache.h (pp_cache): Mark as externally visible.
5814
5815 * process.c: Make symbols static if they're not exported.
5816 (process_tick, update_tick, create_process, chan_process):
5817 (Vprocess_alist, proc_buffered_char, datagram_access):
5818 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5819 (deactivate_process): Mark defn as static, as well as decl.
5820 * lisp.h (create_process): Remove decl.
5821 * process.h (chan_process, Vprocess_alist): Remove decls.
5822
5823 * print.c: Make symbols static if they're not exported.
5824 (print_depth, new_backquote_output, being_printed, print_buffer):
5825 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5826 (print_interval, print_number_index, initial_stderr_stream):
5827 Now static.
5828 * lisp.h (Fprinc): Remove decl.
5829 (debug_output_compilation_hack): Mark as externally visible.
5830
5831 * sysdep.c (croak): Move decl from here to syssignal.h.
5832 * syssignal.h (croak): Put it here, so the API can be checked when
5833 'croak' is called from dissociate_if_controlling_tty.
5834
5835 * minibuf.c: Make symbols static if they're not exported.
5836 (minibuf_save_list, choose_minibuf_frame): Now static.
5837 * lisp.h (choose_minibuf_frame): Remove decl.
5838
5839 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5840
5841 * lread.c: Make symbols static if they're not exported.
5842 (read_objects, initial_obarray, oblookup_last_bucket_number):
5843 Now static.
5844 (make_symbol): Remove; unused.
5845 * lisp.h (initial_obarray, make_symbol): Remove decls.
5846
5847 * keyboard.c: Make symbols static if they're not exported.
5848 (single_kboard, recent_keys_index, total_keys, recent_keys):
5849 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5850 (this_single_command_key_start, echoing, last_auto_save):
5851 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5852 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5853 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5854 (Vlispy_mouse_stem, double_click_count):
5855 Now static.
5856 (force_auto_save_soon): Define only if SIGDANGER.
5857 (ignore_mouse_drag_p): Now static if
5858 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5859 (print_help): Remove; unused.
5860 (stop_character, last_timer_event): Mark as externally visible.
5861 * keyboard.h (ignore_mouse_drag_p): Declare only if
5862 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5863 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5864 * lisp.h (echoing): Remove decl.
5865 (force_auto_save_soon): Declare only if SIGDANGER.
5866 * xdisp.c (redisplay_window): Simplify code, to make it more
5867 obvious that ignore_mouse_drag_p is not accessed if !defined
5868 USE_GTK && !defined HAVE_NS.
5869
5870 * intervals.c: Make symbols static if they're not exported.
5871 (merge_properties_sticky, merge_interval_right, delete_interval):
5872 Now static.
5873 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5874
5875 * insdel.c: Make symbols static if they're not exported.
5876 However, leave prepare_to_modify_buffer alone. It's never
5877 called from outside this function, but that appears to be a bug.
5878 (combine_after_change_list, combine_after_change_buffer):
5879 (adjust_after_replace, signal_before_change): Now static.
5880 (adjust_after_replace_noundo): Remove; unused.
5881 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5882 (signal_before_change): Remove decls.
5883
5884 * indent.c (val_compute_motion, val_vmotion): Now static.
5885
5886 * image.c: Make symbols static if they're not exported.
5887 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5888 if USE_GTK.
5889 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5890 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5891
5892 * fringe.c (standard_bitmaps): Now static.
5893 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5894
5895 * frame.c: Make symbols static if they're not exported.
5896 (x_report_frame_params, make_terminal_frame): Now static.
5897 (get_frame_param): Now static, unless HAVE_NS.
5898 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5899 (x_get_resource_string): Remove; not used.
5900 * frame.h (make_terminal_frame, x_report_frame_params):
5901 (x_get_resource_string); Remove decls.
5902 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5903 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5904
5905 * font.c, fontset.c: Make symbols static if they're not exported.
5906 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5907 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5908 * font.c (font_close_object): Now static.
5909 * font.h (font_close_object): Remove.
5910 * fontset.c (FONTSET_OBJLIST): Remove.
5911 (free_realized_fontset) #if-0 the body, which does nothing.
5912 (face_suitable_for_char_p): #if-0, as it's never called.
5913 * fontset.h (face_suitable_for_char_p): Remove decl.
5914 * xfaces.c (face_at_string_position):
5915 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5916 since 0 is always ASCII.
5917
5918 * fns.c (weak_hash_tables): Now static.
5919
5920 * fileio.c: Make symbols static if they're not exported.
5921 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5922 (Vwrite_region_annotation_buffers): Now static.
5923
5924 * eval.c: Make symbols static if they're not exported.
5925 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5926 * lisp.h (backtrace_list): Remove decl.
5927
5928 * emacs.c: Make symbols static if they're not exported.
5929 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5930 (fatal_error_code, fatal_error_signal_hook, standard_args):
5931 Now static.
5932 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5933 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5934 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5935 * lisp.h (fatal_error_signal_hook): Remove decl.
5936 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5937
5938 * editfns.c: Move a (normally-unused) function to its only use.
5939 * editfns.c, lisp.h (get_operating_system_release): Remove.
5940 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5941 worth the hassle of breaking this out.
5942
5943 * xterm.c: Make symbols static if they're not exported.
5944 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5945 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5946 (x_destroy_window, x_delete_display):
5947 Now static.
5948 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5949 (x_mouse_leave): Remove; unused.
5950 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5951 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5952 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5953 Remove decls.
5954 (x_mouse_leave): Declare only if WINDOWSNT.
5955 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5956 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5957 USE_X_TOOLKIT.
5958
5959 * ftxfont.c: Make symbols static if they're not exported.
5960 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5961 HAVE_FREETYPE.
5962 * font.h (ftxfont_driver): Likewise.
5963
5964 * xfns.c: Make symbols static if they're not exported.
5965 (x_last_font_name, x_display_info_for_name):
5966 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5967 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5968 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5969 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5970 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5971 (last_show_tip_args): Now static.
5972 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5973 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5974 (x_screen_planes): Remove; unused.
5975 * dispextern.h (x_screen_planes): Remove decl.
5976
5977 * dispnew.c: Make symbols static if they're not exported.
5978 * dispextern.h (redraw_garbaged_frames, scrolling):
5979 (increment_row_positions): Remove.
5980 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5981 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5982 Now static.
5983 (redraw_garbaged_frames): Remove; unused.
5984
5985 * xfaces.c: Make symbols static if they're not exported.
5986 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5987 Remove decls.
5988 * xterm.h (defined_color): Remove decls.
5989 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5990 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5991 (menu_face_changed_default, defined_color, free_realized_face):
5992 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5993 (ascii_face_of_lisp_face): Remove; unused.
5994
5995 * xdisp.c: Make symbols static if they're not exported.
5996 * dispextern.h (scratch_glyph_row, window_box_edges):
5997 (glyph_to_pixel_coords, set_cursor_from_row):
5998 (get_next_display_element, set_iterator_to_next):
5999 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6000 (show_mouse_face): Remove decls
6001 * frame.h (message_buf_print): Likewise.
6002 * lisp.h (pop_message, set_message, check_point_in_composition):
6003 Likewise.
6004 * xterm.h (set_vertical_scroll_bar): Likewise.
6005 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6006 (message_buf_print, scratch_glyph_row, displayed_buffer):
6007 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6008 (get_next_display_element, show_mouse_face, window_box_edges):
6009 (frame_to_window_pixel_xy, check_point_in_composition):
6010 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6011 (glyph_to_pixel_coords): Remove; unused.
6012
6013 * dired.c (file_name_completion): Now static.
6014
6015 * dbusbind.c (xd_in_read_queued_messages): Now static.
6016
6017 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6018 * data.c (circular_list_error): Remove.
6019
6020 * commands.h (last_point_position, last_point_position_buffer):
6021 (last_point_position_window): Remove decls.
6022 * keyboard.c: Make these variables static.
6023
6024 * coding.h (coding, code_convert_region, encode_coding_gap):
6025 Remove decls.
6026 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6027 (iso_code_class, detect_coding, code_convert_region): Now static.
6028 (encode_coding_gap): Remove; unused.
6029
6030 * chartab.c (chartab_chars, chartab_bits): Now static.
6031
6032 * charset.h (charset_iso_8859_1): Remove decl.
6033 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6034 Now static.
6035
6036 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6037 * ccl.c (Vccl_program_table): Now static.
6038 (check_ccl_update): Remove; unused.
6039
6040 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6041 * category.h: ... from here.
6042 * category.c (check_category_table, set_category_set): Now static.
6043
6044 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6045 * lisp.h: Remove these decls.
6046
6047 * buffer.c (buffer_count): Remove unused var.
6048
6049 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6050 so that it's not optimized away.
6051 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6052 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6053 exported only to the debugger.
6054
6055 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6056 * atimer.h (run_all_atimers): Remove; not exported.
6057
6058 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6059 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6060 was inaccessible from Lisp.
6061 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6062 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6063
6064 alloc.c: Import and export fewer symbols, and remove unused items.
6065 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6066 is defined.
6067 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6068 it's not optimized away by whole-program optimization.
6069 (message_enable_multibyte, free_misc): Remove.
6070 (catchlist, handlerlist, mark_backtrace):
6071 Declare only if BYTE_MARK_STACK.
6072 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6073 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6074 (message_enable_multibyte): Remove decl.
6075 (free_misc, interval_free_list, float_block, float_block_index):
6076 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6077 (cons_free_list, last_marked_index):
6078 Now static.
6079 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6080 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6081 (mark_backtrace): Define only if BYTE_MARK_STACK.
6082 * xdisp.c (message_enable_multibyte): Now static.
6083
6084 Declare Lisp_Object Q* variables to be 'static' if not exported.
6085 This makes it easier for human readers (and static analyzers)
6086 to see whether these variables are used from other modules.
6087 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6088 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6089 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6090 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6091 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6092 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6093 * xmenu.c, xselect.c:
6094 Declare Q* vars static if they are not used in other modules.
6095 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6096 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6097 Remove decls of unexported vars.
6098 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6099
6100 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6101
6102 Make Emacs functions such as Fatom 'static' by default.
6103 This makes it easier for human readers (and static analyzers)
6104 to see whether these functions can be called from other modules.
6105 DEFUN now defines a static function. To make the function external
6106 so that it can be used in other C modules, use the new macro DEFUE.
6107 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6108 (Finit_image_library):
6109 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6110 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6111 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6112 Remove decls, since these functions are now static.
6113 (Funintern, Fget_internal_run_time): New decls, since these functions
6114 were already external.
6115
6116 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6117 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6118 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6119 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6120 * keyboard.c, keymap.c, lread.c:
6121 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6122 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6123 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6124 Mark functions with DEFUE instead of DEFUN,
6125 if they are used in other modules.
6126 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6127 decls for now-static functions.
6128 * buffer.h (Fdelete_overlay): Remove decl.
6129 * callproc.c (Fgetenv_internal): Mark as internal.
6130 * composite.c (Fremove_list_of_text_properties): Remove decl.
6131 (Fcomposition_get_gstring): New forward static decl.
6132 * composite.h (Fcomposite_get_gstring): Remove decl.
6133 * dired.c (Ffile_attributes): New forward static decl.
6134 * doc.c (Fdocumntation_property): New forward static decl.
6135 * eval.c (Ffetch_bytecode): New forward static decl.
6136 (Funintern): Remove extern decl; now in .h file where it belongs.
6137 * fileio.c (Fmake_symbolic_link): New forward static decl.
6138 * image.c (Finit_image_library): New forward static decl.
6139 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6140 * intervals.h (Fprevious_property_change):
6141 (Fremove_list_of_text_properties): Remove decls.
6142 * keyboard.c (Fthis_command_keys): Remove decl.
6143 (Fcommand_execute): New forward static decl.
6144 * keymap.c (Flookup_key): New forward static decl.
6145 (Fcopy_keymap): Now static.
6146 * keymap.h (Flookup_key): Remove decl.
6147 * process.c (Fget_process): New forward static decl.
6148 (Fprocess_datagram_address): Mark as internal.
6149 * syntax.c (Fsyntax_table_p): New forward static decl.
6150 (skip_chars): Remove duplicate decl.
6151 * textprop.c (Fprevious_property_change): New forward static decl.
6152 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6153 Now internal.
6154 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6155 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6156
6157 * editfns.c (Fformat): Remove unreachable code.
6158
6159 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6160
6161 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6162 change. (Bug#8496)
6163
6164 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6165
6166 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6167 when at ZV. (Bug#8487)
6168
6169 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6170
6171 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6172 (Bug#8437)
6173 * keyboard.c (parse_tool_bar_item): Likewise.
6174 * sound.c (sound_cleanup, alsa_close): Likewise.
6175 * termcap.c (tgetent): Likewise.
6176 * xfns.c (x_default_font_parameter): Likewise.
6177 * xsettings.c (read_and_apply_settings): Likewise.
6178
6179 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6180 (overrun_check_free): Protoize.
6181
6182 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6185 since callers should never pass a negative size.
6186 Change the signature to match that of plain 'read' and 'write'; see
6187 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6188 * lisp.h: Update prototypes of emacs_write and emacs_read.
6189
6190 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6191
6192 * xdisp.c (redisplay_window): Don't try to determine the character
6193 position of the scroll margin if the window start point w->startp
6194 is outside the buffer's accessible region. (Bug#8468)
6195
6196 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6197
6198 Fix write-region and its subroutines for buffers > 2GB.
6199 * fileio.c (a_write, e_write): Modify declaration of arguments and
6200 local variables to support buffers larger than 2GB.
6201 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6202
6203 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6204 argument, local variables, and return value.
6205
6206 * lisp.h: Update prototypes of emacs_write and emacs_read.
6207
6208 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6209
6210 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6211
6212 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6213
6214 Fix more problems found by GCC 4.6.0's static checks.
6215
6216 * xdisp.c (vmessage): Use a better test for character truncation.
6217
6218 * charset.c (load_charset_map): <, not <=, for optimization,
6219 and to avoid potential problems with integer overflow.
6220 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6221 * casetab.c (set_identity, shuffle): Likewise.
6222 * editfns.c (Fformat): Likewise.
6223 * syntax.c (skip_chars): Likewise.
6224
6225 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6226 This also lets GCC 4.6.0 generate slightly better loop code.
6227
6228 * callint.c (Fcall_interactively): <, not <=, for optimization.
6229 (Fcall_interactively): Count the number of arguments produced,
6230 not the number of arguments given. This is simpler and lets GCC
6231 4.6.0 generate slightly better code.
6232
6233 * ftfont.c: Distingish more carefully between FcChar8 and char.
6234 The previous code passed unsigned char * to a functions like
6235 strlen and xstrcasecmp that expect char *, which does not
6236 conform to the C standard.
6237 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6238 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6239 char * when the C standard requires it.
6240
6241 * keyboard.c (read_char): Remove unused var.
6242
6243 * eval.c: Port to Windows vsnprintf (Bug#8435).
6244 Include <limits.h>.
6245 (SIZE_MAX): Define if the headers do not.
6246 (verror): Do not give up if vsnprintf returns a negative count.
6247 Instead, grow the buffer. This ports to Windows vsnprintf, which
6248 does not conform to C99. Problem reported by Eli Zaretskii.
6249 Also, simplify the allocation scheme, by avoiding the need for
6250 calling realloc, and removing the ALLOCATED variable.
6251
6252 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6253
6254 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6255 But keep the doprint source code for now, as we might revamp it
6256 and use it again (Bug#8435).
6257 * lisp.h (doprnt): Remove.
6258 * Makefile.in (base_obj): Remove doprnt.o.
6259 * deps.mk (doprnt.o): Remove.
6260
6261 error: Print 32- and 64-bit integers portably (Bug#8435).
6262 Without this change, on typical 64-bit hosts error ("...%d...", N)
6263 was used to print both 32- and 64-bit integers N, which relied on
6264 undefined behavior.
6265 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6266 New macro.
6267 * lisp.h (error, verror): Mark as printf-like functions.
6268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6269 Report overflow in size calculations when allocating printf buffer.
6270 Do not truncate output string at its first null byte.
6271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6272 Truncate the output at a character boundary, since vsnprintf does not
6273 do that.
6274 * charset.c (check_iso_charset_parameter): Convert internal
6275 character to string before calling 'error', since %c now has the
6276 printf meaning.
6277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6278 overflow when computing char to be passed to 'error'. Do not
6279 pass Lisp_Object to 'error'; pass the integer instead.
6280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6281 formatted with plain %d.
6282
6283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6284
6285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6286
6287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6288
6289 * xterm.c (x_catch_errors): Remove duplicate declaration.
6290
6291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6292
6293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6294
6295 2011-04-10 Jim Meyering <meyering@redhat.com>
6296
6297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6299 return ssize_t not "int", and use size_t as the buffer length.
6300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6301 * gnutls.h: Update declarations.
6302 * process.c (read_process_output): Use ssize_t, to match.
6303 (send_process): Likewise.
6304
6305 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6308
6309 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6310
6311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6312 Use unsigned char, to match FcChar8 type definition.
6313
6314 * xterm.c (handle_one_xevent):
6315 * xmenu.c (create_and_show_popup_menu):
6316 * xselect.c (x_decline_selection_request)
6317 (x_reply_selection_request): Avoid type-punned deref of X events.
6318
6319 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6320
6321 Fix some uses of `int' instead of EMACS_INT.
6322 * search.c (string_match_1, fast_string_match)
6323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6324 (scan_buffer, find_next_newline_no_quit)
6325 (find_before_next_newline, search_command, Freplace_match)
6326 (Fmatch_data): Make some `int' variables be EMACS_INT.
6327
6328 * xdisp.c (display_count_lines): 3rd argument and return value now
6329 EMACS_INT. All callers changed.
6330 (pint2hrstr): Last argument is now EMACS_INT.
6331
6332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6335 (decode_coding_utf_16, decode_coding_emacs_mule)
6336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6337 (decode_coding_ccl, decode_coding_charset)
6338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6339 (decode_coding_iso_2022, decode_coding_emacs_mule)
6340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6341 <char_offset, last_offset>: Declare EMACS_INT.
6342 (encode_coding_utf_8, encode_coding_utf_16)
6343 (encode_coding_emacs_mule, encode_invocation_designation)
6344 (encode_designation_at_bol, encode_coding_iso_2022)
6345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6347 Declare EMACS_INT.
6348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6349 (encode_invocation_designation): Last argument P_NCHARS is now
6350 EMACS_INT.
6351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6353
6354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6355 All users changed.
6356
6357 * ccl.c (Fccl_execute_on_string): Declare some variables
6358 EMACS_INT.
6359
6360 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6361
6362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6363
6364 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6365
6366 * process.c (Fformat_network_address): Doc fix.
6367
6368 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6369
6370 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6371
6372 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6373
6374 * keyboard.c (read_char): Call Lisp function help-form-show,
6375 instead of using internal_with_output_to_temp_buffer.
6376 (Qhelp_form_show): New var.
6377 (syms_of_keyboard): Use DEFSYM macro.
6378
6379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6380
6381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6382
6383 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6384
6385 * process.c (Flist_processes): Remove to Lisp.
6386 (list_processes_1): Delete.
6387
6388 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6389
6390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6391
6392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6393
6394 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6395
6396 Fix more problems found by GCC 4.6.0's static checks.
6397
6398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6399
6400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6401
6402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6403
6404 * xdisp.c (vmessage): Mark as a printf-like function.
6405
6406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6407
6408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6409
6410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6411 printf-like functions.
6412 (tiff_load): Add casts to remove these marks before passing them
6413 to system-supplied API.
6414
6415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6416
6417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6418 This avoids several warnings with gcc -Wstrict-overflow.
6419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6420 directly, rather than having caller test rule sign. This avoids
6421 some unnecessary tests.
6422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6425
6426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6427 (xfont_open): Avoid unnecessary tests.
6428
6429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6430
6431 * composite.h, composite.c (composition_gstring_put_cache):
6432 Use EMACS_INT, not int, for length.
6433
6434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6435 breaking out part of COMPOSITION_DECODE_RULE.
6436 (COMPOSITION_DECODE_RULE): Use it.
6437 * composite.c (get_composition_id): Remove unused local vars,
6438 by using the new macro.
6439
6440 * textprop.c (set_text_properties_1): Change while to do-while,
6441 since the condition is always true at first.
6442
6443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6444 (interval_deletion_adjustment): Return unsigned value.
6445 All uses changed.
6446
6447 * process.c (list_processes_1, create_pty, read_process_output):
6448 (exec_sentinel): Remove vars that were set but not used.
6449 (create_pty): Remove unnecessary "volatile"s.
6450 (Fnetwork_interface_info): Avoid possibility of int overflow.
6451 (read_process_output): Do adaptive read buffering even if carryover.
6452 (read_process_output): Simplify nbytes computation if buffered.
6453
6454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6455
6456 * syntax.c (scan_words): Remove var that was set but not used.
6457 (update_syntax_table): Use unsigned instead of int.
6458
6459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6462
6463 * print.c (print_error_message): Avoid int overflow.
6464
6465 * font.c (font_list_entities): Redo for clarity,
6466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6467
6468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6469 (font_score): Avoid potential overflow in diff calculation.
6470
6471 * fns.c (substring_both): Remove var that is set but not used.
6472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6473
6474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6475
6476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6478 can always succeed if overflow has undefined behavior.
6479
6480 * search.c (boyer_moore, wordify): Remove vars set but not used.
6481 (wordify): Omit three unnecessary tests.
6482
6483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6484 All callers changed. This avoids the need for an unused var.
6485
6486 * casefiddle.c (casify_region): Remove var that is set but not used.
6487
6488 * dired.c (file_name_completion): Remove var that is set but not used.
6489
6490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6491
6492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6493 (Finsert_file_contents): Remove unnecessary code checking fd.
6494
6495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6496 Check for integer overflow on size calculations.
6497
6498 * buffer.c (Fprevious_overlay_change): Remove var that is set
6499 but not used.
6500
6501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6502 Remove vars that are set but not used.
6503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6504 (timer_check_2): Mark vars as initialized.
6505
6506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6507
6508 * image.c (lookup_image): Remove var that is set but not used.
6509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6510
6511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6512 that are set but not used.
6513
6514 * xfns.c (make_invisible_cursor): Don't return garbage
6515 if XCreateBitmapFromData fails (Bug#8410).
6516
6517 * xselect.c (x_get_local_selection, x_handle_property_notify):
6518 Remove vars that are set but not used.
6519
6520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6522
6523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6524 Remove var that is set but not used.
6525 (scroll_bar_windows_size): Now size_t, not int.
6526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6527 Check for overflow.
6528
6529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6530 (map_tty_color) [!defined MSDOS]: Likewise.
6531
6532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6533
6534 * coding.c: Remove vars that are set but not used.
6535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6536 All callers changed.
6537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6539 (decode_coding_charset): Remove vars that are set but not used.
6540
6541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6542 that is set but not used.
6543
6544 * print.c (print_object): Remove var that is set but not used.
6545
6546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6547 The gnulib version avoids calling malloc in the usual case,
6548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6550 * filelock.c (current_lock_owner): Likewise.
6551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6552 * sysdep.c: Include allocator.h, careadlinkat.h.
6553 (emacs_no_realloc_allocator): New static constant.
6554 (emacs_readlink): New function.
6555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6556 ../lib/careadlinkat.h.
6557
6558 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6559
6560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6561 first non-nil return value).
6562
6563 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6564
6565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6566 if not defined (Bug#8403).
6567
6568 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * xdisp.c (display_count_lines): Remove parameter `start',
6571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6576 and thereabouts. All callers changed.
6577 (get_per_char_metric): Remove parameter `f', unused since
6578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6579
6580 2011-04-02 Jim Meyering <meyering@redhat.com>
6581
6582 do not dereference NULL upon failed strdup
6583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6584 (ns_get_family): Likewise.
6585
6586 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6587
6588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6589
6590 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6591
6592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6593 later (Bug#8403).
6594
6595 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6596
6597 Add lexical binding.
6598
6599 * window.c (Ftemp_output_buffer_show): New fun.
6600 (Fsave_window_excursion):
6601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6602
6603 * lread.c (lisp_file_lexically_bound_p): New function.
6604 (Fload): Bind Qlexical_binding.
6605 (readevalloop): Remove `evalfun' arg.
6606 Bind Qinternal_interpreter_environment.
6607 (Feval_buffer): Bind Qlexical_binding.
6608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6609 Mark as dynamic.
6610 (syms_of_lread): Declare `lexical-binding'.
6611
6612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6613
6614 * keyboard.c (eval_dyn): New fun.
6615 (menu_item_eval_property): Use it.
6616
6617 * image.c (parse_image_spec): Use Ffunctionp.
6618
6619 * fns.c (concat, mapcar1): Accept byte-code-functions.
6620
6621 * eval.c (Fsetq): Handle lexical vars.
6622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6624 (FletX, Flet): Obey lexical binding.
6625 (Fcommandp): Handle closures.
6626 (Feval): New `lexical' arg.
6627 (eval_sub): New function extracted from Feval. Use it almost
6628 everywhere where Feval was used. Look up vars in lexical env.
6629 Handle closures.
6630 (Ffunctionp): Move from subr.el.
6631 (Ffuncall): Handle closures.
6632 (apply_lambda): Remove `eval_flags'.
6633 (funcall_lambda): Handle closures and new byte-code-functions.
6634 (Fspecial_variable_p): New function.
6635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6636 but without exporting it to Lisp.
6637
6638 * doc.c (Fdocumentation, store_function_docstring):
6639 * data.c (Finteractive_form): Handle closures.
6640
6641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6642 interactive spec.
6643
6644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6645 New byte-codes.
6646 (exec_byte_code): New function extracted from Fbyte_code to handle new
6647 calling convention for byte-code-functions. Add new byte-codes.
6648
6649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6650
6651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6652
6653 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6654
6655 * xdisp.c (redisplay_internal): Fix prototype.
6656
6657 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6658
6659 * xdisp.c (SCROLL_LIMIT): New macro.
6660 (try_scrolling): Use it when setting scroll_limit.
6661 Limit scrolling to 100 screen lines.
6662 (redisplay_window): Even when falling back on "recentering",
6663 position point in the window according to scroll-conservatively,
6664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6665
6666 (try_scrolling): When point is above the window, allow searching
6667 as far as scroll_max, or one screenful, to compute vertical
6668 distance from PT to the scroll margin position. This prevents
6669 try_scrolling from unnecessarily failing when
6670 scroll-conservatively is set to a value slightly larger than the
6671 window height. Clean up the case of PT below the margin at bottom
6672 of window: scroll_max can no longer be INT_MAX. When aggressive
6673 scrolling is in use, don't let point enter the opposite scroll
6674 margin as result of the scroll.
6675 (syms_of_xdisp) <scroll-conservatively>: Document the
6676 threshold of 100 lines for never-recentering scrolling.
6677
6678 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6679
6680 * dispextern.h (move_it_by_lines):
6681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6683 (message_log_check_duplicate): Remove parameters `prev_bol' and
6684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6685 (redisplay_internal): Remove parameter `preserve_echo_area',
6686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6687
6688 * indent.c (Fvertical_motion):
6689 * window.c (window_scroll_pixel_based, Frecenter):
6690 Don't pass `need_y_p' to `move_it_by_lines'.
6691
6692 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6693
6694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6695 steal a few bits to be more compact.
6696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6697 Remove unneeded casts.
6698
6699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6700
6701 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6702
6703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6704 binding" message (bug#7967).
6705
6706 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 Fix more problems found by GCC 4.6.0's static checks.
6709
6710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6711 Remove unused local var.
6712
6713 * editfns.c (Fmessage_box): Remove unused local var.
6714
6715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6717 Omit unused local vars.
6718 * window.c (shrink_windows): Omit unused local var.
6719 * menu.c (digest_single_submenu): Omit unused local var.
6720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6721 Omit unused local var.
6722
6723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6724 Don't assume string length fits in int.
6725 (keyremap_step, read_key_sequence): Use size_t for sizes.
6726 (read_key_sequence): Don't check last_real_key_start redundantly.
6727
6728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6729 instead of alloca (Bug#8344).
6730
6731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6732 (Fbacktrace_frame): Don't assume nframes fits in int.
6733
6734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6735
6736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6737 concerns.
6738
6739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6740
6741 * cm.c (calccost): Turn while-do into do-while, for clarity.
6742
6743 * keyboard.c (syms_of_keyboard): Use the same style as later
6744 in this function when indexing through an array. This also
6745 works around GCC bug 48267.
6746
6747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6748
6749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6750
6751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6753
6754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6755 This avoids undefined behavior on integer overflow, and is a bit
6756 more convenient anyway since it is compared to a size_t variable.
6757
6758 Variadic C functions now count arguments with size_t, not int.
6759 This avoids an unnecessary limitation on 64-bit machines, which
6760 caused (substring ...) to crash on large vectors (Bug#8344).
6761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6763 All variadic functions and their callers changed accordingly.
6764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6765 * data.c (arith_driver, float_arith_driver): Likewise.
6766 * editfns.c (general_insert_function): Likewise.
6767 * eval.c (struct backtrace.nargs, interactive_p)
6768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6769 (funcall_lambda, mark_backtrace): Likewise.
6770 * fns.c (concat): Likewise.
6771 * frame.c (x_set_frame_parameters): Likewise.
6772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6773 0 if not found, not -1. All callers changed.
6774
6775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6776 (stack_copy_size): Now size_t, not int.
6777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6778
6779 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6780
6781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6783 All callers changed.
6784
6785 * lisp.h (multibyte_char_to_unibyte):
6786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6788 * character.h (CHAR_TO_BYTE8):
6789 * cmds.c (internal_self_insert):
6790 * editfns.c (general_insert_function):
6791 * keymap.c (push_key_description):
6792 * search.c (Freplace_match):
6793 * xdisp.c (message_dolog, set_message_1): All callers changed.
6794
6795 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6796
6797 * keyboard.c (safe_run_hook_funcall): New function.
6798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6799 don't set the hook to nil, but remove the offending function instead.
6800 (Qcommand_hook_internal): Remove, unused.
6801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6802 Vcommand_hook_internal.
6803
6804 * eval.c (enum run_hooks_condition): Remove.
6805 (funcall_nil, funcall_not): New functions.
6806 (run_hook_with_args): Call each function through a `funcall' argument.
6807 Remove `cond' argument, now redundant.
6808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6809 (Frun_hook_with_args_until_failure): Adjust accordingly.
6810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6811
6812 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6813
6814 * dispextern.h (string_buffer_position): Remove declaration.
6815
6816 * print.c (strout): Remove parameter `multibyte', unused since
6817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6818
6819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6821 All callers changed.
6822
6823 * w32.c (_wsa_errlist): Use braces for struct initializers.
6824
6825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6827 All callers changed.
6828 (string_buffer_position): Likewise. Also, make static (it's never
6829 used outside xdisp.c).
6830 (cursor_row_p): Remove parameter `w', unused since
6831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6832 (decode_mode_spec): Remove parameter `precision', introduced during
6833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6834 All callers changed.
6835
6836 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6837
6838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6839
6840 2011-03-27 Anders Lindgren <andlind@gmail.com>
6841
6842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6844 (ns_update_auto_hide_menu_bar): New functions.
6845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6847 ns_constrain_all_frames.
6848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6850
6851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6852
6853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6854
6855 2011-03-27 Glenn Morris <rgm@gnu.org>
6856
6857 * syssignal.h: Replace RETSIGTYPE with void.
6858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6860 Replace SIGTYPE with void everywhere.
6861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6862 * s/template.h (SIGTYPE): Remove commented out definition.
6863
6864 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6865
6866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6868
6869 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * w32.c (read_unc_volume): Use parameter `henum', instead of
6872 global variable `wget_enum_handle'.
6873
6874 * keymap.c (describe_vector): Remove parameters `indices' and
6875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6877
6878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6879
6880 * keyboard.c (timer_check): Remove parameter `do_it_now',
6881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6884
6885 * keyboard.c (read_char):
6886 * w32menu.c (w32_menu_display_help):
6887 * xmenu.c (show_help_event, menu_help_callback):
6888 Adjust calls to `show_help_echo'.
6889
6890 * gtkutil.c (xg_maybe_add_timer):
6891 * keyboard.c (readable_events):
6892 * process.c (wait_reading_process_output):
6893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6894
6895 * insdel.c (adjust_markers_gap_motion):
6896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6897 (gap_left, gap_right): Don't call it.
6898
6899 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6900
6901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6902 incurred during fontification.
6903
6904 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6907 (DEFVAR_PER_BUFFER): Don't pass it.
6908
6909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6910 (scrolling_window): Don't pass it.
6911
6912 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6913
6914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6915
6916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6917 and `suffix'.
6918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6919 of variables specific to SELinux and computation of `encoded_absname'.
6920
6921 * image.c (XPutPixel): Remove unused variable `height'.
6922
6923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6924
6925 * unexw32.c (get_section_info): Remove unused variable `section'.
6926
6927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6928 (system_process_attributes): Remove unused variable `sess'.
6929 (sys_read): Remove unused variable `err'.
6930
6931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6932 (w32_wnd_proc): Remove unused variable `isdead'.
6933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6935 (x_create_tip_frame): Remove unused variable `tem'.
6936
6937 * w32inevt.c (w32_console_read_socket):
6938 Remove unused variable `no_events'.
6939
6940 * w32term.c (x_draw_composite_glyph_string_foreground):
6941 Remove unused variable `width'.
6942
6943 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6944
6945 * w32term.c (x_set_glyph_string_clipping):
6946 Don't pass uninitialized region to CombineRgn.
6947
6948 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6952 (Fx_close_connection): Remove unused variable `i'.
6953
6954 * w32font.c (w32font_draw): Return number of glyphs.
6955 (w32font_open_internal): Remove unused variable `i'.
6956 (w32font_driver): Add missing initializer.
6957
6958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6959 (fill_in_menu): Remove unused variable `items_added'.
6960
6961 * w32term.c (last_mouse_press_frame): Remove static global variable.
6962 (w32_clip_to_row): Remove unused variable `f'.
6963 (x_delete_terminal): Remove unused variable `i'.
6964
6965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6966 (NOTHING): Remove unused static global variable.
6967 (uniscribe_check_otf): Remove unused variable `table'.
6968 (uniscribe_font_driver): Add missing initializers.
6969
6970 2011-03-23 Julien Danjou <julien@danjou.info>
6971
6972 * term.c (Fsuspend_tty, Fresume_tty):
6973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6974 * window.c (temp_output_buffer_show):
6975 * insdel.c (signal_before_change):
6976 * frame.c (Fhandle_switch_frame):
6977 * fileio.c (Fdo_auto_save):
6978 * emacs.c (Fkill_emacs):
6979 * editfns.c (save_excursion_restore):
6980 * cmds.c (internal_self_insert):
6981 * callint.c (Fcall_interactively):
6982 * buffer.c (Fkill_all_local_variables):
6983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6984 Use Frun_hooks.
6985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6986 unconditionnaly since it does the check itself.
6987
6988 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 Fix more problems found by GCC 4.5.2's static checks.
6991
6992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6993 the first time through the loop, since we know p0 < p1 then.
6994 This also avoids a gcc -Wstrict-overflow warning.
6995
6996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6997 leading to a memory leak, possible in functions like
6998 load_charset_map_from_file that can allocate an unbounded number
6999 of objects (Bug#8318).
7000
7001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7002 that could (at least in theory) be that large.
7003
7004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7005 This is less likely to overflow, and avoids undefined behavior if
7006 overflow does occur. All callers changed. Use strtoul to scan
7007 for the unsigned long integer.
7008 (pint2hrstr): Simplify and tune code slightly.
7009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7010
7011 * scroll.c (do_scrolling): Work around GCC bug 48228.
7012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7013
7014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7015 This also avoids a warning with gcc -Wstrict-overflow.
7016 (validate_x_resource_name): Simplify count usage.
7017 This also avoids a warning with gcc -Wstrict-overflow.
7018
7019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7020 fail (Bug#8306).
7021
7022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7023
7024 * process.c (Fmake_network_process): Use socklen_t, not int,
7025 where POSIX says socklen_t is required in portable programs.
7026 This fixes a porting bug on hosts like 64-bit HP-UX, where
7027 socklen_t is wider than int (Bug#8277).
7028 (Fmake_network_process, server_accept_connection):
7029 (wait_reading_process_output, read_process_output):
7030 Likewise.
7031
7032 * process.c: Rename or move locals to avoid shadowing.
7033 (list_processes_1, Fmake_network_process):
7034 (read_process_output_error_handler, exec_sentinel_error_handler):
7035 Rename or move locals.
7036 (Fmake_network_process): Define label "retry_connect" only if needed.
7037 (Fnetwork_interface_info): Fix pointer signedness.
7038 (process_send_signal): Add cast to avoid pointer signedness problem.
7039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7041
7042 Make tparam.h and terminfo.c consistent.
7043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7044 Include tparam.h instead, since it declares them.
7045 * cm.h (PC): Remove extern decl; tparam.h now does this.
7046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7047 * terminfo.c: Include tparam.h, to check interfaces.
7048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7049 (tparam): Adjust signature to match interface in tparam.h;
7050 this removes some undefined behavior. Check that outstring and len
7051 are zero, which they always are with Emacs.
7052 * tparam.h (PC, BC, UP): New extern decls.
7053
7054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7055 (xftfont_open): Rename locals to avoid shadowing.
7056
7057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7059 (OTF_TAG_SYM): Omit macro if not needed.
7060 (ftfont_list): Remove unused local.
7061 (get_adstyle_property, ftfont_pattern_entity):
7062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7063 Rename locals to avoid shadowing.
7064
7065 * xfont.c (xfont_list_family): Mark var as initialized.
7066
7067 * xml.c (make_dom): Now static.
7068
7069 * composite.c (composition_compute_stop_pos): Rename local to
7070 avoid shadowing.
7071 (composition_reseat_it): Remove unused locals.
7072 (find_automatic_composition, composition_adjust_point): Likewise.
7073 (composition_update_it): Mark var as initialized.
7074 (find_automatic_composition): Mark vars as initialized,
7075 with a FIXME (Bug#8290).
7076
7077 character.h: Rename locals to avoid shadowing.
7078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7082 to avoid shadowing.
7083
7084 * textprop.c (property_change_between_p): Remove; unused.
7085
7086 * intervals.c (interval_start_pos): Now static.
7087
7088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7089
7090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7091 Rename locals to avoid shadowing.
7092
7093 * sound.c (wav_play, au_play, Fplay_sound_internal):
7094 Fix pointer signedness.
7095 (alsa_choose_format): Remove unused local var.
7096 (wav_play): Initialize a variable to 0, to prevent undefined
7097 behavior (Bug#8278).
7098
7099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7100
7101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7102
7103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7104 clobbering (Bug#8298).
7105 * sysdep.c (sys_subshell): Likewise.
7106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7107
7108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7109 This should get cleaned up, so that child_setup has the
7110 same signature on all platforms.
7111
7112 * callproc.c (call_process_cleanup): Now static.
7113 (relocate_fd): Rename locals to avoid shadowing.
7114
7115 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7118 not to be necessary, and produces flickering.
7119
7120 2011-03-20 Glenn Morris <rgm@gnu.org>
7121
7122 * config.in: Remove file.
7123
7124 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7125
7126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7127 are now in src/globals.h.
7128 (syms_of_minibuf): Remove spurious & from previous change.
7129
7130 2011-03-20 Leo <sdl.web@gmail.com>
7131
7132 * minibuf.c (completing-read-function): New variable.
7133 (completing-read-default): Rename from completing-read.
7134 (completing-read): Call completing-read-function.
7135
7136 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7137
7138 * xfaces.c (Fx_load_color_file):
7139 Read color file from absolute filename (bug#8250).
7140
7141 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7142
7143 * makefile.w32-in: Update dependencies.
7144
7145 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7146
7147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7148
7149 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7150
7151 Fix more problems found by GCC 4.5.2's static checks.
7152
7153 * process.c (make_serial_process_unwind, send_process_trap):
7154 (sigchld_handler): Now static.
7155
7156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7157 That way, the code declares only the vars that it needs.
7158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7159 * s/cygwin.h (PTY_ITERATION): Likewise.
7160 * s/darwin.h (PTY_ITERATION): Likewise.
7161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7162
7163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7164 * process.c (allocate_pty): Don't declare stb unless it's needed.
7165
7166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7167 (CONSTANTLIM): Remove; unused.
7168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7169 Define only if needed.
7170
7171 * unexelf.c (unexec): Name an expression,
7172 to avoid gcc -Wbad-function-cast warning.
7173 Use a different way to cause a compilation error if anyone uses
7174 n rather than nn, a way that does not involve shadowing.
7175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7176
7177 * deps.mk (unexalpha.o): Remove; unused.
7178
7179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7180 * unexec.h: New file.
7181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7183 Depend on unexec.h.
7184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7187 Change as necessary to match prototype in unexec.h.
7188
7189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7190 shadowing.
7191 (back_comment, skip_chars): Mark vars as initialized.
7192
7193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7194 Rename locals to avoid shadowing.
7195
7196 * lread.c (read1): Rewrite so as not to use empty "else".
7197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7198
7199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7200
7201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7202 warning when compiling print.c.
7203
7204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7205 instead of using an uninitialized var.
7206 (font_sort_entities): Mark var as initialized.
7207
7208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7209
7210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7211 pointers to constants.
7212 (font_parse_fcname): Remove unused vars.
7213 (font_delete_unmatched): Now static.
7214 (font_get_spec): Remove; unused.
7215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7217 Rename or move locals to avoid shadowing.
7218
7219 * fns.c (require_nesting_list, require_unwind): Now static.
7220 (Ffillarray): Rename locals to avoid shadowing.
7221
7222 * floatfns.c (domain_error2): Define only if needed.
7223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7224
7225 * alloc.c (mark_backtrace): Move decl from here ...
7226 * lisp.h: ... to here, so that it can be checked.
7227
7228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7229 (Fdefvar): Rewrite so as not to use empty "else".
7230 (lisp_indirect_variable): Name an expression,
7231 to avoid gcc -Wbad-function-cast warning.
7232 (Fdefvar): Rename locals to avoid shadowing.
7233
7234 * callint.c (quotify_arg, quotify_args): Now static.
7235 (Fcall_interactively): Rename locals to avoid shadowing.
7236 Use const pointer when appropriate.
7237
7238 * lisp.h (get_system_name, get_operating_system_release):
7239 Move decls here, to check interfaces.
7240 * process.c (get_operating_system_release): Move decl to lisp.h.
7241 * xrdb.c (get_system_name): Likewise.
7242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7244 some of which prompt warnings from gcc -Wbad-function-cast.
7245 (Fformat_time_string, Fencode_time, Finsert_char):
7246 (Ftranslate_region_internal, Fformat):
7247 Rename or remove local vars to avoid shadowing.
7248 (Ftranslate_region_internal): Mark var as initialized.
7249
7250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7251 avoid shadowing.
7252
7253 * lisp.h (eassert): Check that the argument compiles, even if
7254 ENABLE_CHECKING is not defined.
7255
7256 * data.c (Findirect_variable): Name an expression, to avoid
7257 gcc -Wbad-function-cast warning.
7258 (default_value, arithcompare, arith_driver, arith_error): Now static.
7259 (store_symval_forwarding): Rename local to avoid shadowing.
7260 (Fmake_variable_buffer_local, Fmake_local_variable):
7261 Mark variables as initialized.
7262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7263
7264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7266 Rename locals to avoid shadowing.
7267 (mark_stack): Move local variables into the #ifdef region where
7268 they're used.
7269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7271 needed otherwise.
7272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7273 (GC_STRING_CHARS): Remove; not used.
7274 (Fmemory_limit): Cast sbrk's returned value to char *.
7275
7276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7277 avoids undefined behavior in theory.
7278
7279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7280
7281 Use functions, not macros, for up- and down-casing (Bug#8254).
7282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7284 to use the following functions instead of these macros.
7285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7286 EMACS_INT, since callers assume the returned value fits in int.
7287 (upcase1): Likewise, for UPCASE_TABLE.
7288 (uppercasep, lowercasep, upcase): New static inline functions.
7289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7290 the race-condition problem in the old DOWNCASE.
7291
7292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7293 Rename locals to avoid shadowing.
7294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7295 (regex_compile, re_search_2, re_match_2_internal):
7296 Remove unused local vars.
7297 (FREE_VAR): Rewrite so as not to use empty "else",
7298 which gcc can warn about.
7299 (regex_compile, re_match_2_internal): Mark locals as initialized.
7300 (RETALLOC_IF): Define only if needed.
7301 (WORDCHAR_P): Likewise. This one is never needed, but is used
7302 only in a comment talking about a compiler bug, so put inside
7303 the #if 0 of that comment.
7304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7306 Remove; unused.
7307
7308 * search.c (boyer_moore): Rename locals to avoid shadowing.
7309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7310 (PREV_CHAR_BOUNDARY): Likewise.
7311
7312 * search.c (simple_search): Remove unused var.
7313
7314 * dired.c (compile_pattern): Move decl from here ...
7315 * lisp.h: ... to here, so that it can be checked.
7316 (struct re_registers): New forward decl.
7317
7318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7319
7320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7321 All uses changed.
7322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7323 Rename locals to avoid shadowing.
7324 (Fvertical_motion): Mark locals as initialized.
7325
7326 * casefiddle.c (casify_object, casify_region): Now static.
7327 (casify_region): Mark local as initialized.
7328
7329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7330
7331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7332 New macros, so that the caller can use some names other than
7333 gcpro1, gcpro2, etc.
7334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7335 of the new macros.
7336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7337 argument, for consistency with GCPRO2_VAR, etc: it is now the
7338 prefix of the variable, not the variable itself. All uses
7339 changed.
7340 * dired.c (directory_files_internal, file_name_completion):
7341 Rename locals to avoid shadowing.
7342
7343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7345 dired.c's scmp function, had undefined behavior.
7346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7348 * buffer.h: ... to here, because these macros use current_buffer,
7349 and the new implementation with inline functions needs to have
7350 current_buffer in scope now, rather than later when the macros
7351 are used.
7352 (downcase, upcase1): New static inline functions.
7353 (DOWNCASE, UPCASE1): Reimplement using these functions.
7354 This avoids undefined behavior in expressions like
7355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7356 from race conditions in accessing the global variables
7357 case_temp1 and case_temp2.
7358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7359 * lisp.h (case_temp1, case_temp2): Remove their decls.
7360 * character.h (ASCII_CHAR_P): Move from here ...
7361 * lisp.h: ... to here, so that the inline functions mentioned
7362 above can use them.
7363
7364 * dired.c (directory_files_internal_unwind): Now static.
7365
7366 * fileio.c (file_name_as_directory, directory_file_name):
7367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7368 Now static.
7369 (file_name_as_directory): Use const pointers when appropriate.
7370 (Fexpand_file_name): Likewise. In particular, newdir might
7371 point at constant storage, so make it a const pointer.
7372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7374 signedness issues.
7375 (Fset_file_times, Finsert_file_contents, auto_save_error):
7376 Rename locals to avoid shadowing.
7377
7378 * minibuf.c (choose_minibuf_frame_1): Now static.
7379 (Ftry_completion, Fall_completions): Rename or remove locals
7380 to avoid shadowing.
7381
7382 * marker.c (bytepos_to_charpos): Remove; unused.
7383
7384 * lisp.h (verify_bytepos, count_markers): New decls,
7385 so that gcc does not warn that these functions aren't declared.
7386
7387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7390 (copy_text): Remove unused local var.
7391
7392 * filelock.c (within_one_second): Now static.
7393 (lock_file_1): Rename local to avoid shadowing.
7394
7395 * buffer.c (fix_overlays_before): Mark locals as initialized.
7396 (fix_start_end_in_overlays): Likewise. This function should be
7397 simplified by using pointers-to-pointers, but that's a different
7398 matter.
7399 (switch_to_buffer_1): Now static.
7400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7401 (report_overlay_modification): Rename locals to avoid shadowing.
7402
7403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7404 Fix pointer signedness issue.
7405 (sys_subshell): Mark local as volatile if checking for lint,
7406 to suppress a gcc -Wclobbered warning that does not seem to be right.
7407 (MAXPATHLEN): Define only if needed.
7408
7409 * process.c (serial_open, serial_configure): Move decls from here ...
7410 * systty.h: ... to here, so that they can be checked.
7411
7412 * fns.c (get_random, seed_random): Move extern decls from here ...
7413 * lisp.h: ... to here, so that they can be checked.
7414
7415 * sysdep.c (reset_io): Now static.
7416 (wait_for_termination_signal): Remove; unused.
7417
7418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7419 (copy_keymap_item, append_key, push_text_char_description):
7420 Now static.
7421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7422 (DENSE_TABLE_SIZE): Remove; unused.
7423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7424 (describe_map_tree):
7425 Rename locals to avoid shadowing.
7426
7427 * keyboard.c: Declare functions static if they are not used elsewhere.
7428 (echo_char, echo_dash, cmd_error, top_level_2):
7429 (poll_for_input, handle_async_input): Now static.
7430 (read_char, kbd_buffer_get_event, make_lispy_position):
7431 (make_lispy_event, make_lispy_movement, apply_modifiers):
7432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7435 (read_key_sequence, read_char): Mark locals as initialized.
7436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7437
7438 * keyboard.h (make_ctrl_char): New decl.
7439 (mark_kboards): Move decl here ...
7440 * alloc.c (mark_kboards): ... from here.
7441
7442 * lisp.h (force_auto_save_soon): New decl.
7443
7444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7445 (DEFINE_DUMMY_FUNCTION): New macro.
7446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7447 Use it.
7448 (main): Add casts to avoid warnings
7449 if GCC considers string literals to be constants.
7450
7451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7452
7453 * dbusbind.c: Pointer signedness fixes.
7454 (xd_signature, xd_append_arg, xd_initialize):
7455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7459
7460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7461 if GCC considers string literals to be constants.
7462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7463
7464 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7465
7466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7467 (print_preprocess, print_object): New macro to fix last change.
7468
7469 * print.c (print_preprocess): Don't forget font objects.
7470
7471 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7472
7473 * emacs.c (USAGE3): Doc fixes.
7474
7475 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7476
7477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7478 structure.
7479
7480 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7481
7482 * lisp.h (VWindow_system, Qfile_name_history):
7483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7486
7487 * w32select.c: Don't #include "keyboard.h".
7488 (run_protected): Add extern declaration for waiting_for_input.
7489
7490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7491 * w32console.c (detect_input_pending, read_input_pending)
7492 (encode_terminal_code):
7493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7495 (w32_system_caret_y, Qfile_name_history):
7496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7500 * w32proc.c (Qlocal, report_file_error):
7501 * w32term.c (Vwindow_system, updating_frame):
7502 * w32uniscribe.c (initialized, uniscribe_font_driver):
7503 Remove unneeded extern declarations.
7504
7505 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7506
7507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7508
7509 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7510
7511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7513 These macros can no longer be used for assignment.
7514
7515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7516 Assign struct members directly, instead of using BUF_BEGV etc.
7517 (record_buffer_markers, fetch_buffer_markers): New functions for
7518 recording and fetching special buffer markers.
7519 (set_buffer_internal_1, set_buffer_temp): Use them.
7520
7521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7522
7523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7524
7525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7527
7528 * xdisp.c (hscroll_window_tree):
7529 (reconsider_clip_changes): Use PT instead of BUF_PT.
7530
7531 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7532
7533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7534 $(EMACS_ROOT)/lib/intprops.h.
7535
7536 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7537
7538 Fix more problems found by GCC 4.5.2's static checks.
7539
7540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7541 to unsigned char * to avoid compiler diagnostic.
7542 (xg_free_frame_widgets): Make it clear that a local variable is
7543 needed only if USE_GTK_TOOLTIP.
7544 (gdk_window_get_screen): Make it clear that this macro is needed
7545 only if USE_GTK_TOOLTIP.
7546 (int_gtk_range_get_value): New function, which avoids a diagnostic
7547 from gcc -Wbad-function-cast.
7548 (xg_set_toolkit_scroll_bar_thumb): Use it.
7549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7550 diagnostic from gcc -Wbad-function-cast.
7551 (get_utf8_string, xg_get_file_with_chooser):
7552 Rename locals to avoid shadowing.
7553 (create_dialog): Move locals to avoid shadowing.
7554
7555 * xgselect.c (xg_select): Remove unused var.
7556
7557 * image.c (four_corners_best): Mark locals as initialized.
7558 (gif_load): Initialize transparent_p to zero (Bug#8238).
7559 Mark another local as initialized.
7560 (my_png_error, my_error_exit): Mark with NO_RETURN.
7561
7562 * image.c (clear_image_cache): Now static.
7563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7565 (x_edge_detection): Remove unnecessary cast that
7566 gcc -Wbad-function-cast diagnoses.
7567 (gif_load): Fix pointer signedness.
7568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7570
7571 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7572
7573 Improve quality of tests for time stamp overflow.
7574 For example, without this patch (encode-time 0 0 0 1 1
7575 1152921504606846976) returns the obviously-bogus value (-948597
7576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7577 reports time overflow. See
7578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7580 * editfns.c: Include limits.h and intprops.h.
7581 (TIME_T_MIN, TIME_T_MAX): New macros.
7582 (time_overflow): Move earlier, to before first use.
7583 (hi_time, lo_time): New functions, for an accurate test for
7584 out-of-range times.
7585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7586 (Fget_internal_run_time): Don't assume time_t fits in int.
7587 (make_time): Use list2 instead of Fcons twice.
7588 (Fdecode_time): More accurate test for out-of-range times.
7589 (check_tm_member): New function.
7590 (Fencode_time): Use it, to test for out-of-range times.
7591 (lisp_time_argument): Don't rely on undefined left-shift and
7592 right-shift behavior when checking for time stamp overflow.
7593
7594 * editfns.c (time_overflow): New function, refactoring common code.
7595 (Fformat_time_string, Fdecode_time, Fencode_time):
7596 (Fcurrent_time_string): Use it.
7597
7598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7599 * dired.c (make_time): Move to ...
7600 * editfns.c (make_time): ... here.
7601 * systime.h: Note the move.
7602
7603 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7604
7605 * fringe.c (update_window_fringes): Remove unused variables.
7606
7607 * unexmacosx.c (copy_data_segment): Also copy __got section.
7608 (Bug#8223)
7609
7610 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7611
7612 * termcap.c [MSDOS]: Include "msdos.h".
7613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7614 Constify `char *' arguments and their references according to
7615 prototypes in tparam.h.
7616
7617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7618
7619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7620 Adapt all references accordingly.
7621
7622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7623
7624 2011-03-11 Tom Tromey <tromey@redhat.com>
7625
7626 * buffer.c (syms_of_buffer): Remove obsolete comment.
7627
7628 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7629
7630 * termhooks.h (encode_terminal_code): Declare prototype.
7631
7632 * msdos.c (encode_terminal_code): Don't declare prototype.
7633
7634 * term.c (encode_terminal_code): Now external again, used by
7635 w32console.c and msdos.c.
7636
7637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7639
7640 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 Fix some minor problems found by GCC 4.5.2's static checks.
7643
7644 * fringe.c (update_window_fringes): Mark locals as initialized
7645 (Bug#8227).
7646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7647
7648 * alloc.c (mark_fringe_data): Move decl from here ...
7649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7650 to check its interface.
7651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7652
7653 * fontset.c (free_realized_fontset): Now static.
7654 (Fset_fontset_font): Rename local to avoid shadowing.
7655 (fontset_font): Mark local as initialized.
7656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7657
7658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7659
7660 * xselect.c (x_disown_buffer_selections): Remove; not used.
7661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7662 (x_own_selection, Fx_disown_selection_internal): Rename locals
7663 to avoid shadowing.
7664 (x_handle_dnd_message): Remove local to avoid shadowing.
7665
7666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7667 so that the caller can use some name other than gcpro1.
7668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7670 (Fx_backspace_delete_keys_p):
7671 Use them to avoid shadowing, and rename vars to avoid shadowing.
7672 (x_decode_color, x_set_name, x_window): Now static.
7673 (Fx_create_frame): Add braces to silence GCC warning.
7674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7676 Remove unused locals.
7677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7680 macros.
7681
7682 * xterm.h (x_mouse_leave): New decl.
7683
7684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7685 Remove unused functions.
7686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7687 (x_calc_absolute_position): Now static.
7688 (XTread_socket): Don't define label "out" unless it's used.
7689 Don't declare local "event" unless it's used.
7690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7691 unless they are used.
7692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7693 (x_fatal_error_signal): Remove; not used.
7694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7696 (x_error_catcher, x_connection_closed, x_error_handler):
7697 (x_error_quitter, xembed_send_message, x_iconify_frame):
7698 (my_log_handler): Rename locals to avoid shadowing.
7699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7701
7702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7703 Rename or move locals to avoid shadowing.
7704 (tty_defined_color, merge_face_heights): Now static.
7705 (free_realized_faces_for_fontset): Remove; not used.
7706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7707 does not deduce is never used uninitialized.
7708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7710
7711 * terminal.c (store_terminal_param): Now static.
7712
7713 * xmenu.c (menu_highlight_callback): Now static.
7714 (set_frame_menubar): Remove unused local.
7715 (xmenu_show): Rename parameter to avoid shadowing.
7716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7717 since they might point to immutable storage.
7718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7719 since it's unused otherwise.
7720
7721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7724 avoids a gcc -Wuninitialized diagnostic.
7725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7727 does not deduce are never used uninitialized.
7728
7729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7730
7731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7732 * window.c (window_loop, size_window):
7733 (run_window_configuration_change_hook, enlarge_window): Likewise.
7734
7735 * window.c (display_buffer): Now static.
7736 (size_window): Mark variables that gcc -Wuninitialized
7737 does not deduce are never used uninitialized.
7738 * window.h (check_all_windows): New decl, to forestall
7739 gcc -Wmissing-prototypes diagnostic.
7740 * dispextern.h (bidi_dump_cached_states): Likewise.
7741
7742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7743 shadowing.
7744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7745 Include <limits.h>.
7746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7747 and to avoid gcc -Wuninitialized warning.
7748 (load_charset_map): Mark variables that gcc -Wuninitialized
7749 does not deduce are never used uninitialized.
7750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7751
7752 * coding.c (coding_set_source, coding_set_destination):
7753 Use "else { /* comment */ }" rather than "else /* comment */;"
7754 for clarity, and to avoid gcc -Wempty-body warning.
7755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7756 a block, when the outer 'i' will do.
7757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7762 Rename locals to avoid shadowing.
7763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7764 * coding.c (emacs_mule_char, encode_invocation_designation):
7765 Now static, since they're not used elsewhere.
7766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7767 (decode_coding_object, encode_coding_object, detect_coding_system):
7768 (decode_coding_emacs_mule): Mark variables that gcc
7769 -Wuninitialized does not deduce are never used uninitialized.
7770 (detect_coding_iso_2022): Initialize a local variable that might
7771 be used uninitialized. Leave a FIXME because it's not clear that
7772 this initialization is needed. (Bug#8211)
7773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7777 Remove unused macros.
7778
7779 * category.c (hash_get_category_set): Remove unused local var.
7780 (copy_category_table): Now static, since it's not used elsewhere.
7781 * character.c (string_count_byte8): Likewise.
7782
7783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7785
7786 * chartab.c (copy_sub_char_table): Now static, since it's not used
7787 elsewhere.
7788 (sub_char_table_ref_and_range, char_table_ref_and_range):
7789 Rename locals to avoid shadowing.
7790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7791
7792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7793 (BIDI_BOB): Remove unused macro.
7794
7795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7796 deduce are never used uninitialized.
7797 * term.c (encode_terminal_code): Likewise.
7798
7799 * term.c (encode_terminal_code): Now static. Remove unused local.
7800
7801 * tparam.h: New file.
7802 * term.c, tparam.h: Include it.
7803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7805 Move these decls to tparam.h, and make them agree with what
7806 is actually in tparam.c. The previous trick of using incompatible
7807 decls in different modules does not conform to the C standard.
7808 All callers of tparam changed to use tparam's actual API.
7809 * tparam.c (tparam1, tparam, tgoto):
7810 Use const pointers where appropriate.
7811
7812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7813 * cm.h (struct cm): Likewise.
7814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7818 (turn_on_face, init_tty): Likewise.
7819 * termchar.h (struct tty_display_info): Likewise.
7820
7821 * term.c (term_mouse_position): Rename local to avoid shadowing.
7822
7823 * alloc.c (mark_ttys): Move decl from here ...
7824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7825
7826 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7827
7828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7829
7830 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7831
7832 * search.c (compile_pattern_1): Remove argument regp, unused since
7833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7834 (compile_pattern): Don't pass it.
7835
7836 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7837
7838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7840 for ! HAVE_GTK3.
7841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7842
7843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7844
7845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7846 gdk_window_get_screen, gdk_window_get_geometry,
7847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7849 (xg_get_pixbuf_from_pixmap): New function.
7850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7852 Call xg_get_pixbuf_from_pixmap instead of
7853 gdk_pixbuf_get_from_drawable.
7854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7856 (xg_check_special_colors): Use GtkStyleContext and its functions
7857 for HAVE_GTK3.
7858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7862 Call gtk_widget_get_preferred_size.
7863 (xg_frame_resized): gdk_window_get_geometry only takes 5
7864 parameters.
7865 (xg_win_to_widget, xg_event_is_for_menubar):
7866 Call gdk_x11_window_lookup_for_display.
7867 (xg_set_widget_bg): New function.
7868 (delete_cb): New function.
7869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7870 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7871 (xg_set_background_color): Call xg_set_widget_bg.
7872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7876 if ! HAVE_GTK3.
7877 (update_frame_tool_bar): Call gtk_widget_hide.
7878 (xg_initialize): Use GDK_KEY_g.
7879
7880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7881 if ! HAVE_GTK3
7882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7883
7884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7887
7888 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * w32xfns.c (select_palette): Check success of RealizePalette against
7891 GDI_ERROR, not zero.
7892
7893 See ChangeLog.11 for earlier changes.
7894
7895 ;; Local Variables:
7896 ;; coding: utf-8
7897 ;; End:
7898
7899 Copyright (C) 2011 Free Software Foundation, Inc.
7900
7901 This file is part of GNU Emacs.
7902
7903 GNU Emacs is free software: you can redistribute it and/or modify
7904 it under the terms of the GNU General Public License as published by
7905 the Free Software Foundation, either version 3 of the License, or
7906 (at your option) any later version.
7907
7908 GNU Emacs is distributed in the hope that it will be useful,
7909 but WITHOUT ANY WARRANTY; without even the implied warranty of
7910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7911 GNU General Public License for more details.
7912
7913 You should have received a copy of the GNU General Public License
7914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.