]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Don't assume time_t can fit into int.
[gnu-emacs] / src / ChangeLog
1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 Don't assume time_t can fit into int.
4 * buffer.h (struct buffer.modtime): Now time_t, not int.
5 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7
8 Minor fixes for signed vs unsigned integers.
9 * character.h (MAYBE_UNIFY_CHAR):
10 * charset.c (maybe_unify_char):
11 * keyboard.c (read_char, reorder_modifiers):
12 XINT -> XFASTINT, since the integer must be nonnegative.
13 * ftfont.c (ftfont_spec_pattern):
14 * keymap.c (access_keymap, silly_event_symbol_error):
15 XUINT -> XFASTINT, since the integer must be nonnegative.
16 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
17 since it makes no difference and we prefer signed.
18 * keyboard.c (record_char): Use XUINT when all the neighbors do.
19 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
20 nonnegative.
21
22 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
23
24 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
25 Do not assume that spare memory exists; that assumption is valid
26 only if SYSTEM_MALLOC.
27 (LARGE_REQUEST): New macro, so that the issue of large requests
28 is separated from the issue of spare memory.
29
30 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
31
32 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
33 format. (Bug#8806)
34
35 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
36
37 * xfns.c (x_set_scroll_bar_default_width): Move declarations
38 before statements.
39
40 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
41
42 * gtkutil.c (xg_get_default_scrollbar_width): New function.
43
44 * gtkutil.h: Declare xg_get_default_scrollbar_width.
45
46 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
47 min width by calling x_set_scroll_bar_default_width (Bug#8505).
48
49 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
50
51 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
52
53 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
54
55 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
56 (x_clipboard_manager_save): Add return value.
57 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
58 error handlers.
59 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
60 Obey Vx_select_enable_clipboard_manager. Catch errors in
61 x_clipboard_manager_save (Bug#8779).
62 (Vx_select_enable_clipboard_manager): New variable.
63 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
64
65 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
66
67 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
68
69 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
70
71 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
72 in the current matrix if keep_current_p is non-zero.
73
74 2011-06-04 Eli Zaretskii <eliz@gnu.org>
75
76 * bidi.c (bidi_level_of_next_char): Fix last change.
77
78 2011-06-03 Eli Zaretskii <eliz@gnu.org>
79
80 Support bidi reordering of text covered by display properties.
81
82 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
83 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
84 (bidi_cache_search, bidi_cache_iterator_state)
85 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
86 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
87 character positions inside a run of characters covered by a
88 display string.
89 (bidi_paragraph_init, bidi_resolve_explicit_1)
90 (bidi_level_of_next_char): Call bidi_fetch_char and
91 bidi_fetch_char_advance instead of FETCH_CHAR and
92 FETCH_CHAR_ADVANCE.
93 (bidi_init_it): Initialize new members.
94 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
95 definitions.
96 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
97 instead of using explicit *_CHAR codes.
98 (bidi_resolve_explicit, bidi_resolve_weak): Use
99 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
100 bidirectional text is supported only in multibyte buffers.
101 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
102 it to initialize the frame_window_p member of struct bidi_it.
103 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
104 (bidi_resolve_explicit, bidi_resolve_weak)
105 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
106 bidi_it->nchars is non-positive.
107 (bidi_level_of_next_char): Don't try to lookup the cache for the
108 next/previous character if nothing is cached there yet, or if we
109 were just reseat()'ed to a new position.
110
111 * xdisp.c (set_cursor_from_row): Set start and stop points
112 according to the row's direction when priming the loop that looks
113 for the glyph on which to display cursor.
114 (single_display_spec_intangible_p): Function deleted.
115 (display_prop_intangible_p): Reimplement to call
116 handle_display_spec instead of single_display_spec_intangible_p.
117 Accept 3 additional arguments needed by handle_display_spec. This
118 fixes incorrect cursor motion across display property with complex
119 values: lists, `(when COND...)' forms, etc.
120 (single_display_spec_string_p): Support property values that are
121 lists with the argument STRING its top-level element.
122 (display_prop_string_p): Fix the condition for processing a
123 property that is a list to be consistent with handle_display_spec.
124 (handle_display_spec): New function, refactored from the
125 last portion of handle_display_prop.
126 (compute_display_string_pos): Accept additional argument
127 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
128 value of a `display' property is a "replacing spec".
129 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
130 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
131 the display property, but just return a value indicating whether
132 the display property will replace the characters it covers.
133 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
134 frame_window_p members of struct bidi_it.
135 (compute_display_string_pos, compute_display_string_end): New
136 functions.
137 (push_it): Accept second argument POSITION, where pop_it should
138 jump to continue iteration.
139 (reseat_1): Initialize bidi_it.disp_pos.
140
141 * keyboard.c (adjust_point_for_property): Adjust the call to
142 display_prop_intangible_p to its new signature.
143
144 * dispextern.h (struct bidi_it): New member frame_window_p.
145 (bidi_init_it): Update prototypes.
146 (display_prop_intangible_p): Update prototype.
147 (compute_display_string_pos, compute_display_string_end): Declare
148 prototypes.
149 (struct bidi_it): New members nchars and disp_pos. ch_len is now
150 EMACS_INT.
151
152 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
153
154 Malloc failure behavior now depends on size of allocation.
155 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
156 * lisp.h: Change signatures accordingly.
157 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
158 All callers changed. (Bug#8762)
159
160 * gnutls.c: Use Emacs's memory allocators.
161 Without this change, the gnutls library would invoke malloc etc.
162 directly, which causes problems on non-SYNC_INPUT hosts, and which
163 runs afoul of improving memory_full behavior. (Bug#8761)
164 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
165 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
166 xfree instead of the default malloc, realloc, free.
167 (Fgnutls_boot): No need to check for memory allocation failure,
168 since xmalloc does that for us.
169
170 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
171 * category.c (hash_get_category_set):
172 * ccl.c (ccl_driver):
173 * charset.c (Fdefine_charset_internal):
174 * charset.h (struct charset.hash_index):
175 * composite.c (get_composition_id, gstring_lookup_cache)
176 (composition_gstring_put_cache):
177 * composite.h (struct composition.hash_index):
178 * dispextern.h (struct image.hash):
179 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
180 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
181 (hashfn_equal, hashfn_user_defined, make_hash_table)
182 (maybe_resize_hash_table, hash_lookup, hash_put)
183 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
184 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
185 (Fsxhash, Fgethash, Fputhash, Fmaphash):
186 * image.c (make_image, search_image_cache, lookup_image)
187 (xpm_put_color_table_h):
188 * lisp.h (struct Lisp_Hash_Table):
189 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
190 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
191 for hashes and hash indexes, instead of 'unsigned' and 'int'.
192 * alloc.c (allocate_vectorlike):
193 Check for overflow in vector size calculations.
194 * ccl.c (ccl_driver):
195 Check for overflow when converting EMACS_INT to int.
196 * fns.c, image.c: Remove unnecessary static decls that would otherwise
197 need to be updated by these changes.
198 * fns.c (make_hash_table, maybe_resize_hash_table):
199 Check for integer overflow with large hash tables.
200 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
201 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
202 (SXHASH_REDUCE): New macro.
203 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
204 Use it instead of discarding useful hash info with large hash values.
205 (sxhash_float): New function.
206 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
207 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
208 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
209 Rewrite to use FIXNUM_BITS, as this simplifies things.
210 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
211 Adjust signatures to match updated version of code.
212 (consing_since_gc): Now EMACS_INT, since a single hash table can
213 use more than INT_MAX bytes.
214
215 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
216
217 Make it possible to build with GCC-4.6+ -O2 -flto.
218
219 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
220
221 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
222
223 * minibuf.c (get_minibuffer, read_minibuf_unwind):
224 Call minibuffer-inactive-mode.
225
226 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
227
228 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
229 Update dependencies.
230
231 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
232
233 * data.c (init_data): Remove code for UTS, this system is not
234 supported anymore.
235
236 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
237
238 Don't force ./temacs to start in terminal mode.
239
240 * frame.c (make_initial_frame): Initialize faces in all cases, not
241 only when CANNOT_DUMP is defined.
242 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
243
244 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
245
246 * dispnew.c (add_window_display_history): Use const for the string
247 pointer. Remove declaration, not needed.
248
249 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
250
251 Use 'inline', not 'INLINE'.
252 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
253 * alloc.c, fontset.c (INLINE): Remove.
254 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
255 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
256 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
257 * gmalloc.c (register_heapinfo): Use inline unconditionally.
258 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
259
260 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
261
262 Make it possible to run ./temacs.
263
264 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
265 syms_of_callproc does the same thing. Remove test for
266 "initialized", do it in the caller.
267 * emacs.c (main): Avoid calling set_initial_environment when dumping.
268
269 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
270
271 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
272 (read_minibuf): Use get_minibuffer.
273 (syms_of_minibuf): Use DEFSYM.
274 (Qmetadata): New var.
275 * data.c (Qbuffer): Don't make it static.
276 (syms_of_data): Use DEFSYM.
277
278 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
279
280 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
281 (CCL_CODE_MIN): New macro.
282
283 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
284
285 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
286
287 * eval.c (Qdebug): Now static.
288 * lisp.h (Qdebug): Remove decl. This reverts a part of the
289 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
290 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
291
292 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
293
294 * image.c: Various fixes to ImageMagick code comments.
295 (Fimagemagick_types): Doc fix.
296
297 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
298
299 Minor fixes prompted by GCC 4.6.0 warnings.
300
301 * xselect.c (converted_selections, conversion_fail_tag): Now static.
302
303 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
304 (x_clipboard_manager_save_all): Move extern decl to ...
305 * xterm.h: ... here, so that it can be checked for consistency.
306
307 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
308
309 * xselect.c (x_clipboard_manager_save_frame)
310 (x_clipboard_manager_save_all): New functions.
311 (Fx_clipboard_manager_save): Lisp function deleted.
312
313 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
314 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
315
316 * xterm.h: Update prototype.
317
318 2011-05-28 William Xu <william.xwl@gmail.com>
319
320 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
321 exiting (Bug#8239).
322
323 2011-05-28 Jim Meyering <meyering@redhat.com>
324
325 Avoid a sign-extension bug in crypto_hash_function.
326 * fns.c (to_uchar): Define.
327 (crypto_hash_function): Use it to convert some newly-signed
328 variables to unsigned, to avoid sign-extension bugs. For example,
329 without this change, (md5 "truc") would evaluate to
330 45723a2aff78ff4fff7fff1114760e62 rather than the expected
331 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
332 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
333
334 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
335
336 Integer overflow fixes.
337
338 * dbusbind.c: Serial number integer overflow fixes.
339 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
340 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
341 to hold a serial number that is too large for a fixnum.
342 (Fdbus_method_return_internal, Fdbus_method_error_internal):
343 Check for serial numbers out of range. Decode any serial number
344 that was so large that it became a float. (Bug#8722)
345
346 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
348 Use XFASTINT rather than XUINT when numbers are nonnegative.
349 (xd_append_arg, Fdbus_method_return_internal):
350 (Fdbus_method_error_internal): Likewise. Also, for unsigned
351 arguments, check that Lisp number is nonnegative, rather than
352 silently wrapping negative numbers around. (Bug#8722)
353 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
354 (Bug#8722)
355
356 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
357
358 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
359
360 ccl: add integer overflow checks
361 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
362 (IN_INT_RANGE): New macros.
363 (ccl_driver): Use them to check for integer overflow when
364 decoding a CCL program. Many of the new checks are whether XINT (x)
365 fits in int; it doesn't always, on 64-bit hosts. The new version
366 doesn't catch all possible integer overflows, but it's an
367 improvement. (Bug#8719)
368
369 * alloc.c (make_event_array): Use XINT, not XUINT.
370 There's no need for unsigned here.
371
372 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
373 This follows up to the 2011-05-06 change that substituted uintptr_t
374 for EMACS_INT. This case wasn't caught back then.
375
376 Rework Fformat to avoid integer overflow issues.
377 * editfns.c: Include <float.h> unconditionally, as it's everywhere
378 now (part of C89). Include <verify.h>.
379 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
380 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
381 (Fformat): Avoid the prepass trying to compute sizes; it was only
382 approximate and thus did not catch overflow reliably. Instead, walk
383 through the format just once, formatting and computing sizes as we go,
384 checking for integer overflow at every step, and allocating a larger
385 buffer as needed. Keep track separately whether the format is
386 multibyte. Keep only the most-recently calculated precision, rather
387 than them all. Record whether each argument has been converted to
388 string. Use EMACS_INT, not int, for byte and char and arg counts.
389 Support field widths and precisions larger than INT_MAX. Avoid
390 sprintf's undefined behavior with conversion specifications such as %#d
391 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
392 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
393 formatting out-of-range floating point numbers with int
394 formats. (Bug#8668)
395
396 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
397
398 * data.c: Avoid integer truncation in expressions involving floats.
399 * data.c: Include <intprops.h>.
400 (arith_driver): When there's an integer overflow in an expression
401 involving floating point, convert the integers to floating point
402 so that the resulting value does not suffer from catastrophic
403 integer truncation. For example, on a 64-bit host (* 4
404 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
405 Do not rely on undefined behavior after integer overflow.
406
407 merge count_size_as_multibyte, parse_str_to_multibyte
408 * character.c, character.h (count_size_as_multibyte):
409 Rename from parse_str_to_multibyte; all uses changed.
410 Check for integer overflow.
411 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
412 since it's now a duplicate of the other. This is more of
413 a character than a buffer op, so better that it's in character.c.
414 * fns.c, print.c: Adjust to above changes.
415
416 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
417
418 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
419
420 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
421
422 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
423 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
424 (x_clipboard_manager_save): Now static.
425 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
426
427 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
428 (crypto_hash_function): Now static.
429 Fix pointer signedness problems. Avoid unnecessary initializations.
430
431 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
432
433 * termhooks.h (Vselection_alist): Make it terminal-local.
434
435 * terminal.c (create_terminal): Initialize it.
436
437 * xselect.c: Support for clipboard managers.
438 (Vselection_alist): Move to termhooks.h as terminal-local var.
439 (LOCAL_SELECTION): New macro.
440 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
441 (symbol_to_x_atom): Remove gratuitous arg.
442 (x_handle_selection_request, lisp_data_to_selection_data)
443 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
444 (x_own_selection, x_get_local_selection, x_convert_selection):
445 New arg, specifying work frame. Use terminal-local Vselection_alist.
446 (some_frame_on_display): Delete unused function.
447 (Fx_own_selection_internal, Fx_get_selection_internal)
448 (Fx_disown_selection_internal, Fx_selection_owner_p)
449 (Fx_selection_exists_p): New optional frame arg.
450 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
451 (x_handle_selection_clear): Don't treat other terminals with the
452 same keyboard specially. Use the terminal-local Vselection_alist.
453 (x_clear_frame_selections): Use Frun_hook_with_args.
454
455 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
456
457 * xterm.h: Add support for those atoms.
458
459 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
460
461 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
462 (converted_selections, conversion_fail_tag): New global variables.
463 (x_selection_request_lisp_error): Free the above.
464 (x_get_local_selection): Remove unnecessary code.
465 (x_reply_selection_request): Args changed; handle arbitrary array
466 of converted selections stored in converted_selections.
467 Separate the XChangeProperty and SelectionNotify steps.
468 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
469 (x_convert_selection): New function.
470 (x_handle_selection_event): Simplify.
471 (x_get_foreign_selection): Don't ignore incoming requests while
472 waiting for an answer; this will fail when we implement
473 SAVE_TARGETS, and seems unnecessary anyway.
474 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
475 (Vx_sent_selection_functions): Doc fix.
476
477 2011-05-26 Leo Liu <sdl.web@gmail.com>
478
479 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
480
481 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
482
483 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
484
485 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
486 for fringe update if it has periodic bitmap.
487 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
488 and fringe_bitmap_periodic_p.
489
490 * fringe.c (get_fringe_bitmap_data): New function.
491 (draw_fringe_bitmap_1, update_window_fringes): Use it.
492 (update_window_fringes): Record periodicity of fringe bitmap in glyph
493 row. Mark glyph row for fringe update if periodicity changed.
494
495 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
496 for fringe update unless it has periodic bitmap.
497
498 2011-05-25 Kenichi Handa <handa@m17n.org>
499
500 * xdisp.c (get_next_display_element): Set correct it->face_id for
501 a static composition.
502
503 2011-05-24 Leo Liu <sdl.web@gmail.com>
504
505 * deps.mk (fns.o):
506 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
507
508 * fns.c (crypto_hash_function, Fsha1): New function.
509 (Fmd5): Use crypto_hash_function.
510 (syms_of_fns): Add Ssha1.
511
512 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
513
514 * gnutls.c: Remove unused macros.
515 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
516 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
517 Remove macros that are defined and never used.
518 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
519
520 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
521
522 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
523 (Fx_get_selection_internal): Minor cleanup.
524 (Fx_own_selection_internal): Rename arguments for consistency with
525 select.el.
526
527 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
528
529 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
530
531 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
532
533 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
534
535 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
536
537 * dispnew.c (scrolling_window): Don't exclude the case that the
538 last enabled row in the desired matrix touches the bottom boundary.
539
540 2011-05-21 Glenn Morris <rgm@gnu.org>
541
542 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
543 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
544 and add some more files.
545
546 2011-05-20 Eli Zaretskii <eliz@gnu.org>
547
548 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
549 report_file_error introduced by the change from 2011-05-07.
550
551 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
552
553 * systime.h (Time): Define only if emacs is defined.
554 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
555 where the include path doesn't have X11/X.h by default. See
556 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
557
558 2011-05-20 Kenichi Handa <handa@m17n.org>
559
560 * composite.c (find_automatic_composition): Fix previous change.
561
562 2011-05-20 Glenn Morris <rgm@gnu.org>
563
564 * lisp.mk: New file, split from Makefile.in.
565 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
566 (shortlisp): Remove.
567 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
568
569 2011-05-19 Glenn Morris <rgm@gnu.org>
570
571 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
572 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
573 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
574 (lisp): Set the order to that of loadup.el.
575 (shortlisp): Make it a copy of $lisp.
576 (SOME_MACHINE_LISP): Remove.
577 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
578 Use just $shortlisp, not $SOME_MACHINE_LISP too.
579
580 2011-05-18 Kenichi Handa <handa@m17n.org>
581
582 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
583 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
584 (find_automatic_composition): Mostly rewrite for efficiency.
585
586 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
587
588 * makefile.w32-in: Update dependencies.
589
590 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
591
592 * menu.c: Include limits.h (fixes the MS-Windows build broken by
593 revision 104625).
594
595 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
596
597 Fix some integer overflow issues, such as string length overflow.
598
599 * insdel.c (count_size_as_multibyte): Check for string overflow.
600
601 * character.c (lisp_string_width): Check for string overflow.
602 Use EMACS_INT, not int, for string indexes and lengths; in
603 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
604 the resulting string length overflows an EMACS_INT; instead,
605 report a string overflow if no precision given. When checking for
606 precision exhaustion, use a check that cannot possibly have
607 integer overflow. (Bug#8675)
608 * character.h (lisp_string_width): Adjust to new signature.
609
610 * alloc.c (string_overflow): New function.
611 (Fmake_string): Use it. This doesn't change behavior, but saves
612 a few bytes and will simplify future changes.
613 * character.c (string_escape_byte8): Likewise.
614 * lisp.h (string_overflow): New decl.
615
616 Fixups, following up to the user-interface timestamp change.
617 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
618 for UI timestamps, instead of unsigned long.
619 * msdos.c (mouse_get_pos): Likewise.
620 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
621 * w32gui.h (Time): Define by including "systime.h" rather than by
622 declaring it ourselves. (Bug#8664)
623
624 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
625 * image.c (clear_image_cache): Likewise.
626
627 * term.c (term_mouse_position): Don't assume time_t wraparound.
628
629 Be more systematic about user-interface timestamps.
630 Before, the code sometimes used 'Time', sometimes 'unsigned long',
631 and sometimes 'EMACS_UINT', to represent these timestamps.
632 This change causes it to use 'Time' uniformly, as that's what X uses.
633 This makes the code easier to follow, and makes it easier to catch
634 integer overflow bugs such as Bug#8664.
635 * frame.c (Fmouse_position, Fmouse_pixel_position):
636 Use Time, not unsigned long, for user-interface timestamps.
637 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
638 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
639 * keyboard.h (last_event_timestamp): Likewise.
640 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
641 * menu.h (xmenu_show): Likewise.
642 * term.c (term_mouse_position): Likewise.
643 * termhooks.h (struct input_event.timestamp): Likewise.
644 (struct terminal.mouse_position_hook): Likewise.
645 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
646 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
647 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
648 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
649 what it was before.
650 * menu.h, termhooks.h: Include "systime.h", for Time.
651
652 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
653 Don't assume that the difference between two unsigned long values
654 can fit into an integer. At this point, we know button_down_time
655 <= event->timestamp, so the difference must be nonnegative, so
656 there's no need to cast the result if double-click-time is
657 nonnegative, as it should be; check that it's nonnegative, just in
658 case. This bug is triggered when events are more than 2**31 ms
659 apart (about 25 days). (Bug#8664)
660
661 * xselect.c (last_event_timestamp): Remove duplicate decl.
662 (x_own_selection): Remove needless cast to unsigned long.
663
664 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
665 that always fit in int. Use a sentinel instead of a counter, to
666 avoid a temp and to allay GCC's concerns about possible int overflow.
667 * frame.h (struct frame): Use int for menu_bar_items_used
668 instead of EMACS_INT, since it always fits in int.
669
670 * menu.c (grow_menu_items): Check for int overflow.
671
672 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
673
674 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
675 Before, the code was not consistent. These values cannot exceed
676 2**31 - 1 so there's no need to make them unsigned.
677 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
678 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
679 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
680 as modifiers.
681 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
682
683 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
684 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
685 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
686 presumably because the widths might not match.
687
688 * window.c (size_window): Avoid needless test at loop start.
689
690 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
691
692 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
693
694 2011-05-12 Drew Adams <drew.adams@oracle.com>
695
696 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
697
698 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
699
700 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
701 `width' to `bar_area_x' and `bar_area_width', respectively.
702 (x_scroll_run): Take account of fringe background extension.
703
704 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
705 Rename local vars `left' and `width' to `bar_area_x' and
706 `bar_area_width', respectively.
707 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
708 background extension.
709
710 2011-05-10 Jim Meyering <meyering@redhat.com>
711
712 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
713
714 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
715
716 * image.c (Finit_image_library): Return t for built-in image types,
717 like pbm and xbm. (Bug#8640)
718
719 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
720
721 * w32menu.c (set_frame_menubar): Fix submenu allocation.
722
723 2011-05-07 Eli Zaretskii <eliz@gnu.org>
724
725 * w32console.c (Fset_screen_color): Doc fix.
726 (Fget_screen_color): New function.
727 (syms_of_ntterm): Defsubr it.
728
729 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
730 unlink the temporary file if Fcall_process didn't create it in the
731 first place.
732 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
733 child process will be redirected to a file specified with `:file'.
734 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
735 cue to call_process_cleanup not to close that handle.
736
737 2011-05-07 Ben Key <bkey76@gmail.com>
738
739 * makefile.w32-in: The bootstrap-temacs rule now makes use of
740 one of two shell specific rules, either bootstrap-temacs-CMD or
741 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
742 to the previous implementation of the bootstrap-temacs rule.
743 The bootstrap-temacs-CMD rule is similar to the previous
744 implementation of the bootstrap-temacs rule except that it
745 makes use of the ESC_CFLAGS variable instead of the CFLAGS
746 variable.
747
748 These changes, along with some changes to nt/configure.bat,
749 nt/gmake.defs, and nt/nmake.defs, are required to extend my
750 earlier fix to add support for --cflags and --ldflags options
751 that include quotes so that it works whether make uses cmd or
752 sh as the shell.
753
754 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
755
756 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
757 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
758 is a constant.
759 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
760 a string. Handle both cases.
761 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
762 (Fdbus_register_method): Use Qinvalid_function.
763
764 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
765
766 * makefile.w32-in: Update dependencies.
767 (LISP_H): Add inttypes.h and stdin.h.
768 (PROCESS_H): Add unistd.h.
769
770 2011-05-06 Eli Zaretskii <eliz@gnu.org>
771
772 * lread.c: Include limits.h (fixes the MS-Windows build broken by
773 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
774
775 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
776
777 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
778
779 * term.c (vfatal): Remove stray call to va_end.
780 It's not needed and the C Standard doesn't allow it here anyway.
781
782 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
783 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
784
785 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
786 bytes.
787
788 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
789
790 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
791
792 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
793
794 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
795
796 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
797
798 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
799 * charset.c (Fdefine_charset_internal): Don't initialize
800 charset.code_space[15]. The value was garbage, on hosts with
801 32-bit int (Bug#8600).
802
803 * lread.c (read_integer): Be more consistent with string-to-number.
804 Use string_to_number to do the actual conversion; this avoids
805 rounding errors and fixes some other screwups. Without this fix,
806 for example, #x1fffffffffffffff was misread as -2305843009213693952.
807 (digit_to_number): Move earlier, for benefit of read_integer.
808 Return -1 if the digit is out of range for the base, -2 if it is
809 not a digit in any supported base. (Bug#8602)
810
811 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
812
813 * dispnew.c (scrolling_window): Return 1 if we scrolled,
814 to match comment at start of function. This also removes a
815 GCC warning about overflow in a 32+64-bit port.
816
817 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
818
819 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
820 Reported by Stefan Monnier in
821 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
822 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
823 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
824
825 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
826 (EMACS_UINTPTR): Likewise, with uintptr_t.
827
828 * lisp.h: Prefer 64-bit EMACS_INT if available.
829 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
830 on 32-bit hosts that have 64-bit int, so that they can access
831 large files.
832 However, temporarily disable this change unless the temporary
833 symbol WIDE_EMACS_INT is defined.
834
835 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
836
837 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
838 This removes an assumption that EMACS_INT and long are the same
839 width as pointers. The assumption is true for Emacs porting targets
840 now, but we want to make other targets possible.
841 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
842 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
843 In the rest of the code, change types of integers that hold casted
844 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
845 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
846 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
847 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
848 No need to cast type when ORing.
849 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
850 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
851 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
852 assume EMACS_INT is the same width as char *.
853 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
854 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
855 Remove no-longer-needed casts.
856 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
857 (xg_tool_bar_help_callback, xg_make_tool_item):
858 Use EMACS_INTPTR to hold an integer
859 that will be cast to void *; this can avoid a GCC warning
860 if EMACS_INT is not the same width as void *.
861 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
862 * xdisp.c (display_echo_area_1, resize_mini_window_1):
863 (current_message_1, set_message_1):
864 Use a local to convert to proper width without a cast.
865 * xmenu.c (dialog_selection_callback): Likewise.
866
867 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
868 Also, don't assume VALBITS / RAND_BITS is less than 5,
869 and don't rely on undefined behavior when shifting a 1 left into
870 the sign bit.
871 * lisp.h (get_random): Change signature to match.
872
873 * lread.c (hash_string): Use size_t, not int, for hash computation.
874 Normally we prefer signed values; but hashing is special, because
875 it's better to use unsigned division on hash table sizes so that
876 the remainder is nonnegative. Also, size_t is the natural width
877 for hashing into memory. The previous code used 'int', which doesn't
878 retain enough info to hash well into very large tables.
879 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
880
881 * dbusbind.c: Don't possibly lose pointer info when converting.
882 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
883 Use XPNTR rather than XHASH, so that the high-order bits of
884 the pointer aren't lost when converting through void *.
885
886 * eval.c (Fautoload): Don't double-shift a pointer.
887
888 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
889
890 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
891
892 * gnutls.c (DEF_GNUTLS_FN):
893 * image.c (DEF_IMGLIB_FN): Make function pointers static.
894
895 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
896
897 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
898 marker. (Bug#8610)
899
900 2011-05-05 Eli Zaretskii <eliz@gnu.org>
901
902 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
903 New version that can reserve upto 2GB of heap space.
904
905 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
906
907 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
908
909 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
910
911 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
912 `gnutls_certificate_set_x509_key_file'.
913
914 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
915
916 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
917 Update dependencies.
918
919 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
920
921 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
922 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
923 Remove unused parameter `fildes'.
924 * process.c (read_process_output, send_process): Don't pass it.
925
926 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
927
928 Fix previous change: the library cache is defined in w32.c.
929 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
930 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
931
932 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
933
934 Implement dynamic loading of GnuTLS on Windows.
935
936 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
937 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
938 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
939 Declare.
940
941 * gnutls.c (Qgnutls_dll): Define.
942 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
943 (gnutls_*): Declare function pointers.
944 (init_gnutls_functions): New function to initialize function pointers.
945 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
946 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
947 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
948 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
949 (emacs_gnutls_write, emacs_gnutls_read)
950 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
951 (Fgnutls_available_p): New function.
952 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
953 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
954 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
955
956 * image.c: Include w32.h.
957 (Vimage_type_cache): Delete.
958 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
959 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
960 (w32_delayed_load): Move to w32.c.
961
962 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
963
964 * w32.c (QCloaded_from, Vlibrary_cache): Define.
965 (w32_delayed_load): Move from image.c. When loading a library, record
966 its filename in the :loaded-from property of the library id.
967 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
968 Initialize and staticpro them.
969 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
970
971 * process.c: Include lisp.h before w32.h, not after.
972 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
973 instead of gnutls_record_check_pending.
974
975 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
976
977 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
978
979 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
980 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
981 as passed in.
982
983 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
984
985 * xterm.c (x_set_frame_alpha): Do not set property on anything
986 else than FRAME_X_OUTER_WINDOW (Bug#8608).
987
988 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
989
990 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
991
992 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
993
994 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
995 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
996 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
997 (gnutls_global_initialized, Qgnutls_bootprop_priority)
998 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
999 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1000 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1001 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1002 (Qgnutls_bootprop_callbacks_verify): Make static.
1003
1004 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1005
1006 * callproc.c: Indentation fixup.
1007
1008 * sysdep.c (wait_for_termination_1): Make static.
1009 (wait_for_termination, interruptible_wait_for_termination):
1010 Move after wait_for_termination_1.
1011
1012 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1013
1014 * sysdep.c (interruptible_wait_for_termination): New function
1015 which is like wait_for_termination, but allows keyboard
1016 interruptions.
1017
1018 * callproc.c (Fcall_process): Add (:file "file") as an option for
1019 the STDOUT buffer.
1020 (Fcall_process_region): Ditto.
1021
1022 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1023
1024 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1025 rather than `XVECTOR (FOO)->size'.
1026
1027 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1028 inttypes.h, as a gnulib replacement is used if it not available in
1029 system headers.
1030
1031 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1032
1033 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1034 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1035 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1036
1037 * coding.c (coding_alloc_by_realloc): Error out if destination
1038 will grow beyond MOST_POSITIVE_FIXNUM.
1039 (decode_coding_emacs_mule): Abort if there isn't enough place in
1040 charbuf for the composition carryover bytes. Reserve an extra
1041 space for up to 2 characters produced in a loop.
1042 (decode_coding_iso_2022): Abort if there isn't enough place in
1043 charbuf for the composition carryover bytes.
1044
1045 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1046
1047 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1048 aborting when %lld or %lll format is passed.
1049 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1050 %llo or %llx format is passed. (Bug#8545)
1051
1052 * window.c (window_scroll_line_based): Use a marker instead of
1053 simple variables to record original value of point. (Bug#7952)
1054
1055 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1056 produced by %s or %c overflows available buffer space. (Bug#8545)
1057
1058 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1061 (SIZE_MAX): Move defn after all includes, as they might #define it.
1062
1063 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1064
1065 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1066
1067 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * keyboard.c (Qdelayed_warnings_hook): Define.
1070 (command_loop_1): Run `delayed-warnings-hook'
1071 if Vdelayed_warnings_list is non-nil.
1072 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1073 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1074
1075 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1076
1077 * doprnt.c (doprnt): Don't return value smaller than the buffer
1078 size if the message was truncated. (Bug#8545).
1079
1080 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1083 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1084
1085 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1088
1089 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * makefile.w32-in: Update dependencies.
1092
1093 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1094
1095 Improve `doprnt' and its usage. (Bug#8545)
1096 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1097 `format_end'. Remove support for %l as a conversion specifier.
1098 Don't use xrealloc. Improve diagnostics when the %l size modifier
1099 is used. Update the commentary.
1100
1101 * eval.c (verror): Simplify calculation of size_t.
1102
1103 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1104 messages.
1105
1106 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1107
1108 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1109 change.
1110
1111 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1114 This makes this file independent of the recent pseudovector change.
1115
1116 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1119
1120 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1121 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1122 Remove unused local.
1123 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1124
1125 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1126 GCC 4.6.0 optimizes based on type-based alias analysis.
1127 For example, if b is of type struct buffer * and v of type struct
1128 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1129 != &v->size, and therefore "v->size = 1; b->size = 2; return
1130 v->size;" must therefore return 1. This assumption is incorrect
1131 for Emacs, since it type-puns struct Lisp_Vector * with many other
1132 types. To fix this problem, this patch adds a new type struct
1133 vectorlike_header that documents the constraints on layout of vectors
1134 and pseudovectors, and helps optimizing compilers not get fooled
1135 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1136 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1137 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1138 the size member.
1139 (XSETPVECTYPE): Rewrite in terms of new macro.
1140 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1141 This is a bit clearer, and further avoids the possibility of
1142 undesirable aliasing.
1143 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1144 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1145 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1146 since Lisp_Subr is a special case (no "next" field).
1147 (ASIZE): Now uses header.size rather than size.
1148 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1149 to avoid the hassle of writing XVECTOR (foo)->header.size.
1150 (struct vectorlike_header): New type.
1151 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1152 object, to help avoid aliasing.
1153 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1154 (SUBRP): Likewise, since Lisp_Subr is a special case.
1155 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1156 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1157 (struct Lisp_Hash_Table): Combine first two members into a single
1158 struct vectorlike_header member. All uses of "size" and "next" members
1159 changed to be "header.size" and "header.next".
1160 * buffer.h (struct buffer): Likewise.
1161 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1162 * frame.h (struct frame): Likewise.
1163 * process.h (struct Lisp_Process): Likewise.
1164 * termhooks.h (struct terminal): Likewise.
1165 * window.c (struct save_window_data, struct saved_window): Likewise.
1166 * window.h (struct window): Likewise.
1167 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1168 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1169 * buffer.c (init_buffer_once): Likewise.
1170 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1171 special case.
1172 * process.c (Fformat_network_address): Use local var for size,
1173 for brevity.
1174
1175 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1176
1177 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1178 * data.c (atof): Remove decl; no longer used or needed.
1179 (digit_to_number): Move to lread.c.
1180 (Fstring_to_number): Use new string_to_number function, to be
1181 consistent with how the Lisp reader treats infinities and NaNs.
1182 Do not assume that floating-point numbers represent EMACS_INT
1183 without losing information; this is not true on most 64-bit hosts.
1184 Avoid double-rounding errors, by insisting on integers when
1185 parsing non-base-10 numbers, as the documentation specifies.
1186 * lisp.h (string_to_number): New decl, replacing ...
1187 (isfloat_string): Remove.
1188 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1189 (read1): Do not accept +. and -. as integers; this
1190 appears to have been a coding error. Similarly, do not accept
1191 strings like +-1e0 as floating point numbers. Do not report
1192 overflow for integer overflows unless the base is not 10 which
1193 means we have no simple and reliable way to continue.
1194 Break out the floating-point parsing into a new
1195 function string_to_number, so that Fstring_to_number parses
1196 floating point numbers consistently with the Lisp reader.
1197 (digit_to_number): Move here from data.c. Make it static inline.
1198 (E_CHAR, EXP_INT): Remove, replacing with ...
1199 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1200 (string_to_number): New function, replacing isfloat_string.
1201 This function checks for valid syntax and produces the resulting
1202 Lisp float number too. Rework it so that string-to-number
1203 no longer mishandles examples like "1.0e+". Use strtoumax,
1204 so that overflow for non-base-10 numbers is reported only when
1205 there's no portable and simple way to convert to floating point.
1206
1207 * textprop.c (set_text_properties_1): Rewrite for clarity,
1208 and to avoid GCC warning about integer overflow.
1209
1210 * intervals.h (struct interval): Use EMACS_INT for members
1211 where EMACS_UINT might cause problems. See
1212 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1213 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1214 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1215 All uses changed.
1216 (offset_intervals): Tell GCC not to worry about length overflow
1217 when negating a negative length.
1218
1219 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1220 (overrun_check_free): Likewise.
1221
1222 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1223 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1224 word size.
1225
1226 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1227 (gnutls_make_error): Rename local to avoid shadowing.
1228 (gnutls_emacs_global_deinit): ifdef out; not used.
1229 (Fgnutls_boot): Use const for pointer to readonly storage.
1230 Comment out unused local. Fix pointer signedness problems.
1231
1232 * lread.c (openp): Don't stuff size_t into an 'int'.
1233 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1234 about possible signed overflow.
1235
1236 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1237 (GDK_KEY_g): Don't define if already defined.
1238 (xg_prepare_tooltip): Avoid pointer signedness problem.
1239 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1240
1241 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1242 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1243
1244 * xfns.c (Fx_window_property): Simplify a bit,
1245 to make a bit faster and to avoid GCC 4.6.0 warning.
1246 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1247
1248 * fns.c (internal_equal): Don't assume size_t fits in int.
1249
1250 * alloc.c (compact_small_strings): Tighten assertion a little.
1251
1252 Replace pEd with more-general pI, and fix some printf arg casts.
1253 * lisp.h (pI): New macro, generalizing old pEd macro to other
1254 conversion specifiers. For example, use "...%"pI"d..." rather
1255 than "...%"pEd"...".
1256 (pEd): Remove. All uses replaced with similar uses of pI.
1257 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1258 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1259 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1260 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1261 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1262 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1263 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1264 64-bit hosts.
1265 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1266 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1267 * print.c (safe_debug_print, print_object): Likewise.
1268 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1269 to int.
1270 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1271 avoiding the 0 flag, which is not portable.
1272 * process.c (Fmake_network_process): Use pI to avoid cast.
1273 * region-cache.c (pp_cache): Likewise.
1274 * xdisp.c (decode_mode_spec): Likewise.
1275 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1276 behavior on 64-bit hosts with printf arg.
1277 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1278 (x_stop_queuing_selection_requests): Likewise.
1279 (x_get_window_property): Don't truncate byte count to an 'int'
1280 when tracing.
1281
1282 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1283 here, since it parses constructs like leading '-' and spaces,
1284 which are not wanted; and it overflows with large numbers.
1285 Instead, simply match F[0-9]+, which is what is wanted anyway.
1286
1287 * alloc.c: Remove unportable assumptions about struct layout.
1288 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1289 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1290 (allocate_vectorlike, make_pure_vector): Use the new macros,
1291 plus offsetof, to remove unportable assumptions about struct layout.
1292 These assumptions hold on all porting targets that I know of, but
1293 they are not guaranteed, they're easy to remove, and removing them
1294 makes further changes easier.
1295
1296 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1297 This doesn't fix a bug but makes the code clearer.
1298 (string_overrun_cookie): Now const. Use initializers that
1299 don't formally overflow signed char, to avoid warnings.
1300 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1301 can cause Emacs to crash when string overrun checking is enabled.
1302 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1303 multiple of sizeof (EMACS_INT); it need not be, if
1304 alignof(EMACS_INT) < sizeof (EMACS_INT).
1305 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1306
1307 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1308
1309 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1310
1311 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1312
1313 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1314 supposed to be handshaking. (Bug#8556)
1315 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1316
1317 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1318
1319 * lisp.h (Qdebug): List symbol.
1320 * eval.c (Qdebug): Restore global linkage.
1321 * keyboard.c (debug-on-event): New variable.
1322 (handle_user_signal): Break into debugger when debug-on-event
1323 matches the current signal symbol.
1324
1325 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1326
1327 * alloc.c (check_sblock, check_string_bytes)
1328 (check_string_free_list): Convert to standard C.
1329
1330 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1331
1332 * w32.c (emacs_gnutls_push): Fix typo.
1333
1334 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1335
1336 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1337 "cast to pointer from integer of different size".
1338
1339 Improve doprnt and its use in verror. (Bug#8545)
1340 * doprnt.c (doprnt): Document the set of format control sequences
1341 supported by the function. Use SAFE_ALLOCA instead of always
1342 using `alloca'.
1343
1344 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1345 is one byte too soon. Don't use xrealloc; instead xfree and
1346 xmalloc anew.
1347
1348 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1349
1350 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1351 callbacks stage.
1352
1353 * gnutls.c: Renamed global_initialized to
1354 gnutls_global_initialized. Added internals for the
1355 :verify-hostname-error, :verify-error, and :verify-flags
1356 parameters of `gnutls-boot' and documented those parameters in the
1357 docstring. Start callback support.
1358 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1359 unless a fatal error occured. Call gnutls_alert_send_appropriate
1360 on error. Return error code.
1361 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1362 (emacs_gnutls_read): Likewise.
1363 (Fgnutls_boot): Return handshake error code.
1364 (emacs_gnutls_handle_error): New function.
1365 (wsaerror_to_errno): Likewise.
1366
1367 * w32.h (emacs_gnutls_pull): Add prototype.
1368 (emacs_gnutls_push): Likewise.
1369
1370 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1371 (emacs_gnutls_push): Likewise.
1372
1373 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1374
1375 * process.c (wait_reading_process_output): Check if GnuTLS
1376 buffered some data internally if no FDs are set for TLS
1377 connections.
1378
1379 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1380 (LIBS): Link to USER_LIBS.
1381 ($(BLD)/gnutls.$(0)): New target.
1382
1383 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1384
1385 * xdisp.c (handle_single_display_spec): Rename the
1386 display_replaced_before_p argument into display_replaced_p, to
1387 make it consistent with the commentary. Fix typos in the
1388 commentary.
1389
1390 * textprop.c (syms_of_textprop): Remove dead code.
1391 (copy_text_properties): Delete obsolete commentary about an
1392 interface that was deleted long ago. Fix typos in the description
1393 of arguments.
1394
1395 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1396 to changes in oldXMenu/XMenu.h from 2011-04-16.
1397 <menu_help_message, prev_menu_help_message>: Constify.
1398 (IT_menu_make_room): menu->help_text is now `const char **';
1399 adjust.
1400
1401 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1402 to changes in oldXMenu/XMenu.h from 2011-04-16.
1403 (struct XMenu): Declare `help_text' `const char **'.
1404
1405 * xfaces.c <Qunspecified>: Make extern again.
1406
1407 * syntax.c: Include sys/types.h before including regex.h, as
1408 required by Posix.
1409
1410 * doc.c (get_doc_string): Improve the format passed to `error'.
1411
1412 * doprnt.c (doprnt): Improve commentary.
1413
1414 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1415
1416 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1417 them with etags.
1418
1419 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1420 changes in globals.h immediately force recompilation.
1421 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1422 $(CURDIR)/s/ms-w32.h.
1423 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1424
1425 * character.c (Fchar_direction): Function deleted.
1426 (syms_of_character): Don't defsubr it.
1427 <char-direction-table>: Deleted.
1428
1429 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1430
1431 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1432 * doprnt.c: Include limits.h.
1433 (SIZE_MAX): New macro.
1434 (doprnt): Return a size_t value. 2nd arg is now size_t.
1435 Many local variables are now size_t instead of int or unsigned.
1436 Improve overflow protection. Support `l' modifier for integer
1437 conversions. Support %l conversion. Don't assume an EMACS_INT
1438 argument for integer conversions and for %c.
1439
1440 * lisp.h (doprnt): Restore prototype.
1441
1442 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1443 $(SRC)/character.h.
1444
1445 * Makefile.in (base_obj): Add back doprnt.o.
1446
1447 * deps.mk (doprnt.o): Add back prerequisites.
1448 (callint.o): Depend on character.h.
1449
1450 * eval.c (internal_lisp_condition_case): Include the handler
1451 representation in the error message.
1452 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1453 when breaking from the loop.
1454
1455 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1456
1457 * callint.c (Fcall_interactively): When displaying error message
1458 about invalid control letter, pass the character's codepoint, not
1459 a pointer to its multibyte form. Improve display of the character
1460 in octal and display also its hex code.
1461
1462 * character.c (char_string): Use %x to display the (unsigned)
1463 codepoint of an invalid character, to avoid displaying a bogus
1464 negative value.
1465
1466 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1467 `error', not SYMBOL_NAME itself.
1468
1469 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1470 character arguments to `error'.
1471
1472 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1473 to `error' in error message about FINAL_CHAR argument. Make sure
1474 FINAL_CHAR is a character, and use %c when it is passed as
1475 argument to `error'.
1476
1477 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1478
1479 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1480
1481 * w32.c: Include <time.h>.
1482 (sys_localtime): New function.
1483
1484 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1485
1486 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1487
1488 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1489
1490 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1491
1492 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1493 zombies (Bug#8467).
1494
1495 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1496
1497 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1498 gl_state.e_property when gl_state.object is Qt.
1499
1500 * insdel.c (make_gap_larger): Remove limitation of buffer size
1501 to <= INT_MAX.
1502
1503 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1504
1505 * xdisp.c (lookup_glyphless_char_display)
1506 (produce_glyphless_glyph): Handle cons cell entry in
1507 glyphless-char-display.
1508 (Vglyphless_char_display): Document it.
1509
1510 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1511 glyphless-char-display.
1512
1513 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1514
1515 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1516
1517 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1518
1519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1520 definition for no-X builds.
1521
1522 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Static checks with GCC 4.6.0 and non-default toolkits.
1525
1526 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1527
1528 * process.c (keyboard_bit_set): Define only if SIGIO.
1529 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1530 (send_process): Repair possible setjmp clobbering.
1531
1532 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1533
1534 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1535
1536 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1537
1538 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1539 Define only if needed.
1540
1541 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1542 by pacifying GCC about it. Maybe it's time to retire it?
1543 * xfaces.c (USG, __TIMEVAL__): Likewise.
1544
1545 * dispextern.h (struct redisplay_interface): Rename param
1546 to avoid shadowing.
1547 * termhooks.h (struct terminal): Likewise.
1548 * xterm.c (xembed_send_message): Likewise.
1549
1550 * insdel.c (make_gap_smaller): Define only if
1551 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1552
1553 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1554 it.
1555
1556 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1557 so that we aren't warned about unused symbols.
1558
1559 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1560
1561 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1562
1563 * xfns.c (x_real_positions): Mark locals as initialized.
1564
1565 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1566
1567 * xterm.c: Fix problems found by static analysis with other toolkits.
1568 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1569 (x_dispatch_event): Declare static if USE_GTK, and
1570 define if USE_GTK || USE_X_TOOLKIT.
1571 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1572 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1573 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1574 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1575
1576 * xmenu.c (menu_help_callback): Pointer type fixes.
1577 Use const pointers when pointing at readonly data. Avoid pointer
1578 signedness clashes.
1579 (FALSE): Remove unused macro.
1580 (update_frame_menubar): Remove unused decl.
1581
1582 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1583
1584 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1585 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1586 (single_menu_item): Rename local to avoid shadowing.
1587
1588 * keyboard.c (make_lispy_event): Remove unused local var.
1589
1590 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1591 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1592
1593 * bitmaps: Change bitmaps from unsigned char back to the X11
1594 compatible char. Avoid the old compiler warnings about
1595 out-of-range initializers by using, for example, '\xab' rather
1596 than 0xab.
1597
1598 * xgselect.c (xgselect_initialize): Check vs interface
1599 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1600
1601 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1602
1603 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1604 to read-only memory.
1605
1606 * fns.c (vector): Remove; this old hack is no longer needed.
1607
1608 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1609 Remove unused var.
1610 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1611
1612 * xrdb.c (x_load_resources): Omit unused local.
1613
1614 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1615 (x_window): Rename locals to avoid shadowing.
1616 (USG): Use the kludged USG macro, to pacify gcc.
1617
1618 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1619 (x_term_init): Remove local to avoid shadowing.
1620
1621 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1622
1623 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1624 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1625
1626 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1627
1628 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1629
1630 Fix regex.c, syntax.c and friends for buffers > 2GB.
1631 * syntax.h (struct gl_state_s): Declare character position members
1632 EMACS_INT.
1633
1634 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1635
1636 * textprop.c (verify_interval_modification, interval_of):
1637 Declare arguments EMACS_INT.
1638
1639 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1640 EMACS_INT.
1641
1642 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1643
1644 * indent.c (Fvertical_motion): Local variable it_start is now
1645 EMACS_INT.
1646
1647 * regex.c (re_match, re_match_2, re_match_2_internal)
1648 (bcmp_translate, regcomp, regexec, print_double_string)
1649 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1650 (re_compile_pattern, re_exec): Declare arguments and local
1651 variables `size_t' and `ssize_t' and return values `regoff_t', as
1652 appropriate.
1653 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1654 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1655 <compile_stack_type>: `size' and `avail' are now `size_t'.
1656
1657 * regex.h <regoff_t>: Use ssize_t, not int.
1658 (re_search, re_search_2, re_match, re_match_2): Arguments that
1659 specify buffer/string position and length are now ssize_t and
1660 size_t. Return type is regoff_t.
1661
1662 2011-04-16 Ben Key <bkey76@gmail.com>
1663
1664 * nsfont.m: Fixed bugs in ns_get_family and
1665 ns_descriptor_to_entity that were caused by using free to
1666 deallocate memory blocks that were allocated by xmalloc (via
1667 xstrdup). This caused Emacs to crash when compiled with
1668 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1669 --enable-checking=xmallocoverrun). xfree is now used to
1670 deallocate these memory blocks.
1671
1672 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1675
1676 emacs_write: Accept and return EMACS_INT for sizes.
1677 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1678 et seq.
1679 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1680 Accept and return EMACS_INT.
1681 (emacs_gnutls_write): Return the number of bytes written on
1682 partial writes.
1683 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1684 (emacs_read, emacs_write): Remove check for negative size, as the
1685 Emacs source code has been audited now.
1686 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1687 (emacs_read, emacs_write): Use it.
1688 * process.c (send_process): Adjust to the new signatures of
1689 emacs_write and emacs_gnutls_write. Do not attempt to store
1690 a byte offset into an 'int'; it might overflow.
1691 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1692
1693 * sound.c: Don't assume sizes fit in 'int'.
1694 (struct sound_device.period_size, alsa_period_size):
1695 Return EMACS_INT, not int.
1696 (struct sound_device.write, vox_write, alsa_write):
1697 Accept EMACS_INT, not int.
1698 (wav_play, au_play): Use EMACS_INT to store sizes and to
1699 record read return values.
1700
1701 2011-04-15 Ben Key <bkey76@gmail.com>
1702
1703 * keyboard.c (Qundefined): Don't declare static since it is used
1704 in nsfns.m.
1705 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1706 static since they are used in nsfont.m.
1707
1708 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1709
1710 * process.c (Qprocessp): Don't declare static.
1711 * lisp.h (Qprocessp): Declare again.
1712
1713 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1714
1715 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1716
1717 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 Improve C-level modularity by making more things 'static'.
1720
1721 Don't publish debugger-only interfaces to other modules.
1722 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1723 (verify_bytepos, count_markers): Move decls to the only modules
1724 that need them.
1725 * region-cache.h (pp_cache): Likewise.
1726 * window.h (check_all_windows): Likewise.
1727 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1728
1729 * sysdep.c (croak): Now static, if
1730 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1731 * syssignal.h (croak): Declare only if not static.
1732
1733 * alloc.c (refill_memory_reserve): Now static if
1734 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1735 * lisp.h (refill_memory_reserve): Declare only if not static.
1736
1737 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1738 Define only if USE_LUCID.
1739
1740 * xrdb.c (x_customization_string, x_rm_string): Now static.
1741
1742 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1743 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1744
1745 * xdisp.c (draw_row_with_mouse_face): Now static.
1746 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1747
1748 * window.h (check_all_windows): Mark externally visible.
1749
1750 * window.c (window_deletion_count): Now static.
1751
1752 * undo.c: Make symbols static if they're not exported.
1753 (last_undo_buffer, last_boundary_position, pending_boundary):
1754 Now static.
1755
1756 * textprop.c (interval_insert_behind_hooks): Now static.
1757 (interval_insert_in_front_hooks): Likewise.
1758
1759 * term.c: Make symbols static if they're not exported.
1760 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1761 (max_frame_lines, tty_set_terminal_modes):
1762 (tty_reset_terminal_modes, tty_turn_off_highlight):
1763 (get_tty_terminal): Now static.
1764 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1765 * termhooks.h (term_mouse_moveto): Do not declare if
1766 HAVE_WINDOW_SYSTEM.
1767 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1768 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1769
1770 * sysdep.c: Make symbols static if they're not exported.
1771 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1772 Now static.
1773 (sigprocmask_set, full_mask): Remove; unused.
1774 (wait_debugging): Mark as visible.
1775 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1776 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1777
1778 * syntax.c (syntax_temp): Define only if !__GNUC__.
1779
1780 * sound.c (current_sound_device, current_sound): Now static.
1781
1782 * search.c (searchbufs, searchbuf_head): Now static.
1783
1784 * scroll.c (scroll_cost): Remove; unused.
1785 * dispextern.h (scroll_cost): Remove decl.
1786
1787 * region-cache.h (pp_cache): Mark as externally visible.
1788
1789 * process.c: Make symbols static if they're not exported.
1790 (process_tick, update_tick, create_process, chan_process):
1791 (Vprocess_alist, proc_buffered_char, datagram_access):
1792 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1793 (deactivate_process): Mark defn as static, as well as decl.
1794 * lisp.h (create_process): Remove decl.
1795 * process.h (chan_process, Vprocess_alist): Remove decls.
1796
1797 * print.c: Make symbols static if they're not exported.
1798 (print_depth, new_backquote_output, being_printed, print_buffer):
1799 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1800 (print_interval, print_number_index, initial_stderr_stream):
1801 Now static.
1802 * lisp.h (Fprinc): Remove decl.
1803 (debug_output_compilation_hack): Mark as externally visible.
1804
1805 * sysdep.c (croak): Move decl from here to syssignal.h.
1806 * syssignal.h (croak): Put it here, so the API can be checked when
1807 'croak' is called from dissociate_if_controlling_tty.
1808
1809 * minibuf.c: Make symbols static if they're not exported.
1810 (minibuf_save_list, choose_minibuf_frame): Now static.
1811 * lisp.h (choose_minibuf_frame): Remove decl.
1812
1813 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1814
1815 * lread.c: Make symbols static if they're not exported.
1816 (read_objects, initial_obarray, oblookup_last_bucket_number):
1817 Now static.
1818 (make_symbol): Remove; unused.
1819 * lisp.h (initial_obarray, make_symbol): Remove decls.
1820
1821 * keyboard.c: Make symbols static if they're not exported.
1822 (single_kboard, recent_keys_index, total_keys, recent_keys):
1823 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1824 (this_single_command_key_start, echoing, last_auto_save):
1825 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1826 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1827 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1828 (Vlispy_mouse_stem, double_click_count):
1829 Now static.
1830 (force_auto_save_soon): Define only if SIGDANGER.
1831 (ignore_mouse_drag_p): Now static if
1832 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1833 (print_help): Remove; unused.
1834 (stop_character, last_timer_event): Mark as externally visible.
1835 * keyboard.h (ignore_mouse_drag_p): Declare only if
1836 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1837 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1838 * lisp.h (echoing): Remove decl.
1839 (force_auto_save_soon): Declare only if SIGDANGER.
1840 * xdisp.c (redisplay_window): Simplify code, to make it more
1841 obvious that ignore_mouse_drag_p is not accessed if !defined
1842 USE_GTK && !defined HAVE_NS.
1843
1844 * intervals.c: Make symbols static if they're not exported.
1845 (merge_properties_sticky, merge_interval_right, delete_interval):
1846 Now static.
1847 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1848
1849 * insdel.c: Make symbols static if they're not exported.
1850 However, leave prepare_to_modify_buffer alone. It's never
1851 called from outside this function, but that appears to be a bug.
1852 (combine_after_change_list, combine_after_change_buffer):
1853 (adjust_after_replace, signal_before_change): Now static.
1854 (adjust_after_replace_noundo): Remove; unused.
1855 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1856 (signal_before_change): Remove decls.
1857
1858 * indent.c (val_compute_motion, val_vmotion): Now static.
1859
1860 * image.c: Make symbols static if they're not exported.
1861 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1862 if USE_GTK.
1863 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1864 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1865
1866 * fringe.c (standard_bitmaps): Now static.
1867 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1868
1869 * frame.c: Make symbols static if they're not exported.
1870 (x_report_frame_params, make_terminal_frame): Now static.
1871 (get_frame_param): Now static, unless HAVE_NS.
1872 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1873 (x_get_resource_string): Remove; not used.
1874 * frame.h (make_terminal_frame, x_report_frame_params):
1875 (x_get_resource_string); Remove decls.
1876 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1877 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1878
1879 * font.c, fontset.c: Make symbols static if they're not exported.
1880 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1881 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1882 * font.c (font_close_object): Now static.
1883 * font.h (font_close_object): Remove.
1884 * fontset.c (FONTSET_OBJLIST): Remove.
1885 (free_realized_fontset) #if-0 the body, which does nothing.
1886 (face_suitable_for_char_p): #if-0, as it's never called.
1887 * fontset.h (face_suitable_for_char_p): Remove decl.
1888 * xfaces.c (face_at_string_position):
1889 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1890 since 0 is always ASCII.
1891
1892 * fns.c (weak_hash_tables): Now static.
1893
1894 * fileio.c: Make symbols static if they're not exported.
1895 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1896 (Vwrite_region_annotation_buffers): Now static.
1897
1898 * eval.c: Make symbols static if they're not exported.
1899 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1900 * lisp.h (backtrace_list): Remove decl.
1901
1902 * emacs.c: Make symbols static if they're not exported.
1903 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1904 (fatal_error_code, fatal_error_signal_hook, standard_args):
1905 Now static.
1906 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1907 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1908 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1909 * lisp.h (fatal_error_signal_hook): Remove decl.
1910 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1911
1912 * editfns.c: Move a (normally-unused) function to its only use.
1913 * editfns.c, lisp.h (get_operating_system_release): Remove.
1914 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1915 worth the hassle of breaking this out.
1916
1917 * xterm.c: Make symbols static if they're not exported.
1918 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1919 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1920 (x_destroy_window, x_delete_display):
1921 Now static.
1922 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1923 (x_mouse_leave): Remove; unused.
1924 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1925 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1926 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1927 Remove decls.
1928 (x_mouse_leave): Declare only if WINDOWSNT.
1929 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1930 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1931 USE_X_TOOLKIT.
1932
1933 * ftxfont.c: Make symbols static if they're not exported.
1934 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1935 HAVE_FREETYPE.
1936 * font.h (ftxfont_driver): Likewise.
1937
1938 * xfns.c: Make symbols static if they're not exported.
1939 (x_last_font_name, x_display_info_for_name):
1940 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1941 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1942 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1943 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1944 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1945 (last_show_tip_args): Now static.
1946 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1947 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1948 (x_screen_planes): Remove; unused.
1949 * dispextern.h (x_screen_planes): Remove decl.
1950
1951 * dispnew.c: Make symbols static if they're not exported.
1952 * dispextern.h (redraw_garbaged_frames, scrolling):
1953 (increment_row_positions): Remove.
1954 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1955 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1956 Now static.
1957 (redraw_garbaged_frames): Remove; unused.
1958
1959 * xfaces.c: Make symbols static if they're not exported.
1960 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1961 Remove decls.
1962 * xterm.h (defined_color): Remove decls.
1963 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1964 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1965 (menu_face_changed_default, defined_color, free_realized_face):
1966 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1967 (ascii_face_of_lisp_face): Remove; unused.
1968
1969 * xdisp.c: Make symbols static if they're not exported.
1970 * dispextern.h (scratch_glyph_row, window_box_edges):
1971 (glyph_to_pixel_coords, set_cursor_from_row):
1972 (get_next_display_element, set_iterator_to_next):
1973 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1974 (show_mouse_face): Remove decls
1975 * frame.h (message_buf_print): Likewise.
1976 * lisp.h (pop_message, set_message, check_point_in_composition):
1977 Likewise.
1978 * xterm.h (set_vertical_scroll_bar): Likewise.
1979 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1980 (message_buf_print, scratch_glyph_row, displayed_buffer):
1981 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1982 (get_next_display_element, show_mouse_face, window_box_edges):
1983 (frame_to_window_pixel_xy, check_point_in_composition):
1984 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1985 (glyph_to_pixel_coords): Remove; unused.
1986
1987 * dired.c (file_name_completion): Now static.
1988
1989 * dbusbind.c (xd_in_read_queued_messages): Now static.
1990
1991 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1992 * data.c (circular_list_error): Remove.
1993
1994 * commands.h (last_point_position, last_point_position_buffer):
1995 (last_point_position_window): Remove decls.
1996 * keyboard.c: Make these variables static.
1997
1998 * coding.h (coding, code_convert_region, encode_coding_gap):
1999 Remove decls.
2000 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2001 (iso_code_class, detect_coding, code_convert_region): Now static.
2002 (encode_coding_gap): Remove; unused.
2003
2004 * chartab.c (chartab_chars, chartab_bits): Now static.
2005
2006 * charset.h (charset_iso_8859_1): Remove decl.
2007 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2008 Now static.
2009
2010 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2011 * ccl.c (Vccl_program_table): Now static.
2012 (check_ccl_update): Remove; unused.
2013
2014 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2015 * category.h: ... from here.
2016 * category.c (check_category_table, set_category_set): Now static.
2017
2018 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2019 * lisp.h: Remove these decls.
2020
2021 * buffer.c (buffer_count): Remove unused var.
2022
2023 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2024 so that it's not optimized away.
2025 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2026 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2027 exported only to the debugger.
2028
2029 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2030 * atimer.h (run_all_atimers): Remove; not exported.
2031
2032 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2033 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2034 was inaccessible from Lisp.
2035 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2036 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2037
2038 alloc.c: Import and export fewer symbols, and remove unused items.
2039 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2040 is defined.
2041 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2042 it's not optimized away by whole-program optimization.
2043 (message_enable_multibyte, free_misc): Remove.
2044 (catchlist, handlerlist, mark_backtrace):
2045 Declare only if BYTE_MARK_STACK.
2046 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2047 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2048 (message_enable_multibyte): Remove decl.
2049 (free_misc, interval_free_list, float_block, float_block_index):
2050 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2051 (cons_free_list, last_marked_index):
2052 Now static.
2053 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2054 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2055 (mark_backtrace): Define only if BYTE_MARK_STACK.
2056 * xdisp.c (message_enable_multibyte): Now static.
2057
2058 Declare Lisp_Object Q* variables to be 'static' if not exported.
2059 This makes it easier for human readers (and static analyzers)
2060 to see whether these variables are used from other modules.
2061 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2062 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2063 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2064 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2065 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2066 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2067 * xmenu.c, xselect.c:
2068 Declare Q* vars static if they are not used in other modules.
2069 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2070 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2071 Remove decls of unexported vars.
2072 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2073
2074 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2075
2076 Make Emacs functions such as Fatom 'static' by default.
2077 This makes it easier for human readers (and static analyzers)
2078 to see whether these functions can be called from other modules.
2079 DEFUN now defines a static function. To make the function external
2080 so that it can be used in other C modules, use the new macro DEFUE.
2081 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2082 (Finit_image_library):
2083 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2084 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2085 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2086 Remove decls, since these functions are now static.
2087 (Funintern, Fget_internal_run_time): New decls, since these functions
2088 were already external.
2089
2090 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2091 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2092 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2093 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2094 * keyboard.c, keymap.c, lread.c:
2095 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2096 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2097 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2098 Mark functions with DEFUE instead of DEFUN,
2099 if they are used in other modules.
2100 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2101 decls for now-static functions.
2102 * buffer.h (Fdelete_overlay): Remove decl.
2103 * callproc.c (Fgetenv_internal): Mark as internal.
2104 * composite.c (Fremove_list_of_text_properties): Remove decl.
2105 (Fcomposition_get_gstring): New forward static decl.
2106 * composite.h (Fcomposite_get_gstring): Remove decl.
2107 * dired.c (Ffile_attributes): New forward static decl.
2108 * doc.c (Fdocumntation_property): New forward static decl.
2109 * eval.c (Ffetch_bytecode): New forward static decl.
2110 (Funintern): Remove extern decl; now in .h file where it belongs.
2111 * fileio.c (Fmake_symbolic_link): New forward static decl.
2112 * image.c (Finit_image_library): New forward static decl.
2113 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2114 * intervals.h (Fprevious_property_change):
2115 (Fremove_list_of_text_properties): Remove decls.
2116 * keyboard.c (Fthis_command_keys): Remove decl.
2117 (Fcommand_execute): New forward static decl.
2118 * keymap.c (Flookup_key): New forward static decl.
2119 (Fcopy_keymap): Now static.
2120 * keymap.h (Flookup_key): Remove decl.
2121 * process.c (Fget_process): New forward static decl.
2122 (Fprocess_datagram_address): Mark as internal.
2123 * syntax.c (Fsyntax_table_p): New forward static decl.
2124 (skip_chars): Remove duplicate decl.
2125 * textprop.c (Fprevious_property_change): New forward static decl.
2126 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2127 Now internal.
2128 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2129 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2130
2131 * editfns.c (Fformat): Remove unreachable code.
2132
2133 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2134
2135 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2136 change. (Bug#8496)
2137
2138 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2139
2140 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2141 when at ZV. (Bug#8487)
2142
2143 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2144
2145 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2146 (Bug#8437)
2147 * keyboard.c (parse_tool_bar_item): Likewise.
2148 * sound.c (sound_cleanup, alsa_close): Likewise.
2149 * termcap.c (tgetent): Likewise.
2150 * xfns.c (x_default_font_parameter): Likewise.
2151 * xsettings.c (read_and_apply_settings): Likewise.
2152
2153 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2154 (overrun_check_free): Protoize.
2155
2156 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2159 since callers should never pass a negative size.
2160 Change the signature to match that of plain 'read' and 'write'; see
2161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2162 * lisp.h: Update prototypes of emacs_write and emacs_read.
2163
2164 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (redisplay_window): Don't try to determine the character
2167 position of the scroll margin if the window start point w->startp
2168 is outside the buffer's accessible region. (Bug#8468)
2169
2170 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2171
2172 Fix write-region and its subroutines for buffers > 2GB.
2173 * fileio.c (a_write, e_write): Modify declaration of arguments and
2174 local variables to support buffers larger than 2GB.
2175 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2176
2177 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2178 argument, local variables, and return value.
2179
2180 * lisp.h: Update prototypes of emacs_write and emacs_read.
2181
2182 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2183
2184 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2187
2188 Fix more problems found by GCC 4.6.0's static checks.
2189
2190 * xdisp.c (vmessage): Use a better test for character truncation.
2191
2192 * charset.c (load_charset_map): <, not <=, for optimization,
2193 and to avoid potential problems with integer overflow.
2194 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2195 * casetab.c (set_identity, shuffle): Likewise.
2196 * editfns.c (Fformat): Likewise.
2197 * syntax.c (skip_chars): Likewise.
2198
2199 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2200 This also lets GCC 4.6.0 generate slightly better loop code.
2201
2202 * callint.c (Fcall_interactively): <, not <=, for optimization.
2203 (Fcall_interactively): Count the number of arguments produced,
2204 not the number of arguments given. This is simpler and lets GCC
2205 4.6.0 generate slightly better code.
2206
2207 * ftfont.c: Distingish more carefully between FcChar8 and char.
2208 The previous code passed unsigned char * to a functions like
2209 strlen and xstrcasecmp that expect char *, which does not
2210 conform to the C standard.
2211 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2212 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2213 char * when the C standard requires it.
2214
2215 * keyboard.c (read_char): Remove unused var.
2216
2217 * eval.c: Port to Windows vsnprintf (Bug#8435).
2218 Include <limits.h>.
2219 (SIZE_MAX): Define if the headers do not.
2220 (verror): Do not give up if vsnprintf returns a negative count.
2221 Instead, grow the buffer. This ports to Windows vsnprintf, which
2222 does not conform to C99. Problem reported by Eli Zaretskii.
2223 Also, simplify the allocation scheme, by avoiding the need for
2224 calling realloc, and removing the ALLOCATED variable.
2225
2226 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2227
2228 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2229 But keep the doprint source code for now, as we might revamp it
2230 and use it again (Bug#8435).
2231 * lisp.h (doprnt): Remove.
2232 * Makefile.in (base_obj): Remove doprnt.o.
2233 * deps.mk (doprnt.o): Remove.
2234
2235 error: Print 32- and 64-bit integers portably (Bug#8435).
2236 Without this change, on typical 64-bit hosts error ("...%d...", N)
2237 was used to print both 32- and 64-bit integers N, which relied on
2238 undefined behavior.
2239 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2240 New macro.
2241 * lisp.h (error, verror): Mark as printf-like functions.
2242 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2243 Report overflow in size calculations when allocating printf buffer.
2244 Do not truncate output string at its first null byte.
2245 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2246 Truncate the output at a character boundary, since vsnprintf does not
2247 do that.
2248 * charset.c (check_iso_charset_parameter): Convert internal
2249 character to string before calling 'error', since %c now has the
2250 printf meaning.
2251 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2252 overflow when computing char to be passed to 'error'. Do not
2253 pass Lisp_Object to 'error'; pass the integer instead.
2254 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2255 formatted with plain %d.
2256
2257 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2258
2259 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2260
2261 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2262
2263 * xterm.c (x_catch_errors): Remove duplicate declaration.
2264
2265 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2266
2267 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2268
2269 2011-04-10 Jim Meyering <meyering@redhat.com>
2270
2271 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2272 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2273 return ssize_t not "int", and use size_t as the buffer length.
2274 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2275 * gnutls.h: Update declarations.
2276 * process.c (read_process_output): Use ssize_t, to match.
2277 (send_process): Likewise.
2278
2279 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2280
2281 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2282
2283 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2284
2285 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2286 Use unsigned char, to match FcChar8 type definition.
2287
2288 * xterm.c (handle_one_xevent):
2289 * xmenu.c (create_and_show_popup_menu):
2290 * xselect.c (x_decline_selection_request)
2291 (x_reply_selection_request): Avoid type-punned deref of X events.
2292
2293 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2294
2295 Fix some uses of `int' instead of EMACS_INT.
2296 * search.c (string_match_1, fast_string_match)
2297 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2298 (scan_buffer, find_next_newline_no_quit)
2299 (find_before_next_newline, search_command, Freplace_match)
2300 (Fmatch_data): Make some `int' variables be EMACS_INT.
2301
2302 * xdisp.c (display_count_lines): 3rd argument and return value now
2303 EMACS_INT. All callers changed.
2304 (pint2hrstr): Last argument is now EMACS_INT.
2305
2306 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2307 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2308 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2309 (decode_coding_utf_16, decode_coding_emacs_mule)
2310 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2311 (decode_coding_ccl, decode_coding_charset)
2312 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2313 (decode_coding_iso_2022, decode_coding_emacs_mule)
2314 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2315 <char_offset, last_offset>: Declare EMACS_INT.
2316 (encode_coding_utf_8, encode_coding_utf_16)
2317 (encode_coding_emacs_mule, encode_invocation_designation)
2318 (encode_designation_at_bol, encode_coding_iso_2022)
2319 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2320 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2321 Declare EMACS_INT.
2322 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2323 (encode_invocation_designation): Last argument P_NCHARS is now
2324 EMACS_INT.
2325 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2326 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2327
2328 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2329 All users changed.
2330
2331 * ccl.c (Fccl_execute_on_string): Declare some variables
2332 EMACS_INT.
2333
2334 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2335
2336 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2337
2338 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2339
2340 * process.c (Fformat_network_address): Doc fix.
2341
2342 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2343
2344 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2345
2346 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2347
2348 * keyboard.c (read_char): Call Lisp function help-form-show,
2349 instead of using internal_with_output_to_temp_buffer.
2350 (Qhelp_form_show): New var.
2351 (syms_of_keyboard): Use DEFSYM macro.
2352
2353 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2354
2355 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2356
2357 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2358
2359 * process.c (Flist_processes): Remove to Lisp.
2360 (list_processes_1): Delete.
2361
2362 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2363
2364 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2365
2366 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2367
2368 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 Fix more problems found by GCC 4.6.0's static checks.
2371
2372 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2373
2374 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2375
2376 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2377
2378 * xdisp.c (vmessage): Mark as a printf-like function.
2379
2380 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2381
2382 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2383
2384 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2385 printf-like functions.
2386 (tiff_load): Add casts to remove these marks before passing them
2387 to system-supplied API.
2388
2389 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2390
2391 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2392 This avoids several warnings with gcc -Wstrict-overflow.
2393 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2394 directly, rather than having caller test rule sign. This avoids
2395 some unnecessary tests.
2396 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2397 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2398 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2399
2400 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2401 (xfont_open): Avoid unnecessary tests.
2402
2403 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2404
2405 * composite.h, composite.c (composition_gstring_put_cache):
2406 Use EMACS_INT, not int, for length.
2407
2408 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2409 breaking out part of COMPOSITION_DECODE_RULE.
2410 (COMPOSITION_DECODE_RULE): Use it.
2411 * composite.c (get_composition_id): Remove unused local vars,
2412 by using the new macro.
2413
2414 * textprop.c (set_text_properties_1): Change while to do-while,
2415 since the condition is always true at first.
2416
2417 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2418 (interval_deletion_adjustment): Return unsigned value.
2419 All uses changed.
2420
2421 * process.c (list_processes_1, create_pty, read_process_output):
2422 (exec_sentinel): Remove vars that were set but not used.
2423 (create_pty): Remove unnecessary "volatile"s.
2424 (Fnetwork_interface_info): Avoid possibility of int overflow.
2425 (read_process_output): Do adaptive read buffering even if carryover.
2426 (read_process_output): Simplify nbytes computation if buffered.
2427
2428 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2429
2430 * syntax.c (scan_words): Remove var that was set but not used.
2431 (update_syntax_table): Use unsigned instead of int.
2432
2433 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2434 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2435 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2436
2437 * print.c (print_error_message): Avoid int overflow.
2438
2439 * font.c (font_list_entities): Redo for clarity,
2440 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2441
2442 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2443 (font_score): Avoid potential overflow in diff calculation.
2444
2445 * fns.c (substring_both): Remove var that is set but not used.
2446 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2447
2448 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2449
2450 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2451 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2452 can always succeed if overflow has undefined behavior.
2453
2454 * search.c (boyer_moore, wordify): Remove vars set but not used.
2455 (wordify): Omit three unnecessary tests.
2456
2457 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2458 All callers changed. This avoids the need for an unused var.
2459
2460 * casefiddle.c (casify_region): Remove var that is set but not used.
2461
2462 * dired.c (file_name_completion): Remove var that is set but not used.
2463
2464 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2465
2466 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2467 (Finsert_file_contents): Remove unnecessary code checking fd.
2468
2469 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2470 Check for integer overflow on size calculations.
2471
2472 * buffer.c (Fprevious_overlay_change): Remove var that is set
2473 but not used.
2474
2475 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2476 Remove vars that are set but not used.
2477 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2478 (timer_check_2): Mark vars as initialized.
2479
2480 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2481
2482 * image.c (lookup_image): Remove var that is set but not used.
2483 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2484
2485 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2486 that are set but not used.
2487
2488 * xfns.c (make_invisible_cursor): Don't return garbage
2489 if XCreateBitmapFromData fails (Bug#8410).
2490
2491 * xselect.c (x_get_local_selection, x_handle_property_notify):
2492 Remove vars that are set but not used.
2493
2494 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2495 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2496
2497 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2498 Remove var that is set but not used.
2499 (scroll_bar_windows_size): Now size_t, not int.
2500 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2501 Check for overflow.
2502
2503 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2504 (map_tty_color) [!defined MSDOS]: Likewise.
2505
2506 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2507
2508 * coding.c: Remove vars that are set but not used.
2509 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2510 All callers changed.
2511 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2512 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2513 (decode_coding_charset): Remove vars that are set but not used.
2514
2515 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2516 that is set but not used.
2517
2518 * print.c (print_object): Remove var that is set but not used.
2519
2520 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2521 The gnulib version avoids calling malloc in the usual case,
2522 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2523 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2524 * filelock.c (current_lock_owner): Likewise.
2525 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2526 * sysdep.c: Include allocator.h, careadlinkat.h.
2527 (emacs_no_realloc_allocator): New static constant.
2528 (emacs_readlink): New function.
2529 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2530 ../lib/careadlinkat.h.
2531
2532 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2533
2534 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2535 first non-nil return value).
2536
2537 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2538
2539 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2540 if not defined (Bug#8403).
2541
2542 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * xdisp.c (display_count_lines): Remove parameter `start',
2545 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2546 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2547 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2548 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2549 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2550 and thereabouts. All callers changed.
2551 (get_per_char_metric): Remove parameter `f', unused since
2552 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2553
2554 2011-04-02 Jim Meyering <meyering@redhat.com>
2555
2556 do not dereference NULL upon failed strdup
2557 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2558 (ns_get_family): Likewise.
2559
2560 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2563
2564 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2565
2566 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2567 later (Bug#8403).
2568
2569 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2570
2571 Add lexical binding.
2572
2573 * window.c (Ftemp_output_buffer_show): New fun.
2574 (Fsave_window_excursion):
2575 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2576
2577 * lread.c (lisp_file_lexically_bound_p): New function.
2578 (Fload): Bind Qlexical_binding.
2579 (readevalloop): Remove `evalfun' arg.
2580 Bind Qinternal_interpreter_environment.
2581 (Feval_buffer): Bind Qlexical_binding.
2582 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2583 Mark as dynamic.
2584 (syms_of_lread): Declare `lexical-binding'.
2585
2586 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2587
2588 * keyboard.c (eval_dyn): New fun.
2589 (menu_item_eval_property): Use it.
2590
2591 * image.c (parse_image_spec): Use Ffunctionp.
2592
2593 * fns.c (concat, mapcar1): Accept byte-code-functions.
2594
2595 * eval.c (Fsetq): Handle lexical vars.
2596 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2597 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2598 (FletX, Flet): Obey lexical binding.
2599 (Fcommandp): Handle closures.
2600 (Feval): New `lexical' arg.
2601 (eval_sub): New function extracted from Feval. Use it almost
2602 everywhere where Feval was used. Look up vars in lexical env.
2603 Handle closures.
2604 (Ffunctionp): Move from subr.el.
2605 (Ffuncall): Handle closures.
2606 (apply_lambda): Remove `eval_flags'.
2607 (funcall_lambda): Handle closures and new byte-code-functions.
2608 (Fspecial_variable_p): New function.
2609 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2610 but without exporting it to Lisp.
2611
2612 * doc.c (Fdocumentation, store_function_docstring):
2613 * data.c (Finteractive_form): Handle closures.
2614
2615 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2616 interactive spec.
2617
2618 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2619 New byte-codes.
2620 (exec_byte_code): New function extracted from Fbyte_code to handle new
2621 calling convention for byte-code-functions. Add new byte-codes.
2622
2623 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2624
2625 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2626
2627 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2628
2629 * xdisp.c (redisplay_internal): Fix prototype.
2630
2631 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (SCROLL_LIMIT): New macro.
2634 (try_scrolling): Use it when setting scroll_limit.
2635 Limit scrolling to 100 screen lines.
2636 (redisplay_window): Even when falling back on "recentering",
2637 position point in the window according to scroll-conservatively,
2638 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2639
2640 (try_scrolling): When point is above the window, allow searching
2641 as far as scroll_max, or one screenful, to compute vertical
2642 distance from PT to the scroll margin position. This prevents
2643 try_scrolling from unnecessarily failing when
2644 scroll-conservatively is set to a value slightly larger than the
2645 window height. Clean up the case of PT below the margin at bottom
2646 of window: scroll_max can no longer be INT_MAX. When aggressive
2647 scrolling is in use, don't let point enter the opposite scroll
2648 margin as result of the scroll.
2649 (syms_of_xdisp) <scroll-conservatively>: Document the
2650 threshold of 100 lines for never-recentering scrolling.
2651
2652 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * dispextern.h (move_it_by_lines):
2655 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2656 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2657 (message_log_check_duplicate): Remove parameters `prev_bol' and
2658 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2659 (redisplay_internal): Remove parameter `preserve_echo_area',
2660 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2661
2662 * indent.c (Fvertical_motion):
2663 * window.c (window_scroll_pixel_based, Frecenter):
2664 Don't pass `need_y_p' to `move_it_by_lines'.
2665
2666 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2667
2668 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2669 steal a few bits to be more compact.
2670 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2671 Remove unneeded casts.
2672
2673 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2674
2675 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2676
2677 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2678 binding" message (bug#7967).
2679
2680 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 Fix more problems found by GCC 4.6.0's static checks.
2683
2684 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2685 Remove unused local var.
2686
2687 * editfns.c (Fmessage_box): Remove unused local var.
2688
2689 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2690 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2691 Omit unused local vars.
2692 * window.c (shrink_windows): Omit unused local var.
2693 * menu.c (digest_single_submenu): Omit unused local var.
2694 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2695 Omit unused local var.
2696
2697 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2698 Don't assume string length fits in int.
2699 (keyremap_step, read_key_sequence): Use size_t for sizes.
2700 (read_key_sequence): Don't check last_real_key_start redundantly.
2701
2702 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2703 instead of alloca (Bug#8344).
2704
2705 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2706 (Fbacktrace_frame): Don't assume nframes fits in int.
2707
2708 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2709
2710 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2711 concerns.
2712
2713 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2714
2715 * cm.c (calccost): Turn while-do into do-while, for clarity.
2716
2717 * keyboard.c (syms_of_keyboard): Use the same style as later
2718 in this function when indexing through an array. This also
2719 works around GCC bug 48267.
2720
2721 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2722
2723 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2724
2725 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2726 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2727
2728 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2729 This avoids undefined behavior on integer overflow, and is a bit
2730 more convenient anyway since it is compared to a size_t variable.
2731
2732 Variadic C functions now count arguments with size_t, not int.
2733 This avoids an unnecessary limitation on 64-bit machines, which
2734 caused (substring ...) to crash on large vectors (Bug#8344).
2735 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2736 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2737 All variadic functions and their callers changed accordingly.
2738 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2739 * data.c (arith_driver, float_arith_driver): Likewise.
2740 * editfns.c (general_insert_function): Likewise.
2741 * eval.c (struct backtrace.nargs, interactive_p)
2742 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2743 (funcall_lambda, mark_backtrace): Likewise.
2744 * fns.c (concat): Likewise.
2745 * frame.c (x_set_frame_parameters): Likewise.
2746 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2747 0 if not found, not -1. All callers changed.
2748
2749 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2750 (stack_copy_size): Now size_t, not int.
2751 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2752
2753 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2754
2755 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2756 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2757 All callers changed.
2758
2759 * lisp.h (multibyte_char_to_unibyte):
2760 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2761 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2762 * character.h (CHAR_TO_BYTE8):
2763 * cmds.c (internal_self_insert):
2764 * editfns.c (general_insert_function):
2765 * keymap.c (push_key_description):
2766 * search.c (Freplace_match):
2767 * xdisp.c (message_dolog, set_message_1): All callers changed.
2768
2769 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2770
2771 * keyboard.c (safe_run_hook_funcall): New function.
2772 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2773 don't set the hook to nil, but remove the offending function instead.
2774 (Qcommand_hook_internal): Remove, unused.
2775 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2776 Vcommand_hook_internal.
2777
2778 * eval.c (enum run_hooks_condition): Remove.
2779 (funcall_nil, funcall_not): New functions.
2780 (run_hook_with_args): Call each function through a `funcall' argument.
2781 Remove `cond' argument, now redundant.
2782 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2783 (Frun_hook_with_args_until_failure): Adjust accordingly.
2784 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2785
2786 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2787
2788 * dispextern.h (string_buffer_position): Remove declaration.
2789
2790 * print.c (strout): Remove parameter `multibyte', unused since
2791 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2792
2793 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2794 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2795 All callers changed.
2796
2797 * w32.c (_wsa_errlist): Use braces for struct initializers.
2798
2799 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2800 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2801 All callers changed.
2802 (string_buffer_position): Likewise. Also, make static (it's never
2803 used outside xdisp.c).
2804 (cursor_row_p): Remove parameter `w', unused since
2805 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2806 (decode_mode_spec): Remove parameter `precision', introduced during
2807 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2808 All callers changed.
2809
2810 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2811
2812 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2813
2814 2011-03-27 Anders Lindgren <andlind@gmail.com>
2815
2816 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2817 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2818 (ns_update_auto_hide_menu_bar): New functions.
2819 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2820 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2821 ns_constrain_all_frames.
2822 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2823 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2824
2825 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2826
2827 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2828
2829 2011-03-27 Glenn Morris <rgm@gnu.org>
2830
2831 * syssignal.h: Replace RETSIGTYPE with void.
2832 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2833 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2834 Replace SIGTYPE with void everywhere.
2835 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2836 * s/template.h (SIGTYPE): Remove commented out definition.
2837
2838 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2839
2840 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2841 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2842
2843 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2844
2845 * w32.c (read_unc_volume): Use parameter `henum', instead of
2846 global variable `wget_enum_handle'.
2847
2848 * keymap.c (describe_vector): Remove parameters `indices' and
2849 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2850 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2851
2852 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2853
2854 * keyboard.c (timer_check): Remove parameter `do_it_now',
2855 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2856 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2857 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2858
2859 * keyboard.c (read_char):
2860 * w32menu.c (w32_menu_display_help):
2861 * xmenu.c (show_help_event, menu_help_callback):
2862 Adjust calls to `show_help_echo'.
2863
2864 * gtkutil.c (xg_maybe_add_timer):
2865 * keyboard.c (readable_events):
2866 * process.c (wait_reading_process_output):
2867 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2868
2869 * insdel.c (adjust_markers_gap_motion):
2870 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2871 (gap_left, gap_right): Don't call it.
2872
2873 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2874
2875 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2876 incurred during fontification.
2877
2878 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2879
2880 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2881 (DEFVAR_PER_BUFFER): Don't pass it.
2882
2883 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2884 (scrolling_window): Don't pass it.
2885
2886 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2887
2888 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2889
2890 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2891 and `suffix'.
2892 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2893 of variables specific to SELinux and computation of `encoded_absname'.
2894
2895 * image.c (XPutPixel): Remove unused variable `height'.
2896
2897 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2898
2899 * unexw32.c (get_section_info): Remove unused variable `section'.
2900
2901 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2902 (system_process_attributes): Remove unused variable `sess'.
2903 (sys_read): Remove unused variable `err'.
2904
2905 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2906 (w32_wnd_proc): Remove unused variable `isdead'.
2907 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2908 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2909 (x_create_tip_frame): Remove unused variable `tem'.
2910
2911 * w32inevt.c (w32_console_read_socket):
2912 Remove unused variable `no_events'.
2913
2914 * w32term.c (x_draw_composite_glyph_string_foreground):
2915 Remove unused variable `width'.
2916
2917 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * w32term.c (x_set_glyph_string_clipping):
2920 Don't pass uninitialized region to CombineRgn.
2921
2922 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2925 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2926 (Fx_close_connection): Remove unused variable `i'.
2927
2928 * w32font.c (w32font_draw): Return number of glyphs.
2929 (w32font_open_internal): Remove unused variable `i'.
2930 (w32font_driver): Add missing initializer.
2931
2932 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2933 (fill_in_menu): Remove unused variable `items_added'.
2934
2935 * w32term.c (last_mouse_press_frame): Remove static global variable.
2936 (w32_clip_to_row): Remove unused variable `f'.
2937 (x_delete_terminal): Remove unused variable `i'.
2938
2939 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2940 (NOTHING): Remove unused static global variable.
2941 (uniscribe_check_otf): Remove unused variable `table'.
2942 (uniscribe_font_driver): Add missing initializers.
2943
2944 2011-03-23 Julien Danjou <julien@danjou.info>
2945
2946 * term.c (Fsuspend_tty, Fresume_tty):
2947 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2948 * window.c (temp_output_buffer_show):
2949 * insdel.c (signal_before_change):
2950 * frame.c (Fhandle_switch_frame):
2951 * fileio.c (Fdo_auto_save):
2952 * emacs.c (Fkill_emacs):
2953 * editfns.c (save_excursion_restore):
2954 * cmds.c (internal_self_insert):
2955 * callint.c (Fcall_interactively):
2956 * buffer.c (Fkill_all_local_variables):
2957 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2958 Use Frun_hooks.
2959 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2960 unconditionnaly since it does the check itself.
2961
2962 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 Fix more problems found by GCC 4.5.2's static checks.
2965
2966 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2967 the first time through the loop, since we know p0 < p1 then.
2968 This also avoids a gcc -Wstrict-overflow warning.
2969
2970 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2971 leading to a memory leak, possible in functions like
2972 load_charset_map_from_file that can allocate an unbounded number
2973 of objects (Bug#8318).
2974
2975 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2976 that could (at least in theory) be that large.
2977
2978 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2979 This is less likely to overflow, and avoids undefined behavior if
2980 overflow does occur. All callers changed. Use strtoul to scan
2981 for the unsigned long integer.
2982 (pint2hrstr): Simplify and tune code slightly.
2983 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2984
2985 * scroll.c (do_scrolling): Work around GCC bug 48228.
2986 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2987
2988 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2989 This also avoids a warning with gcc -Wstrict-overflow.
2990 (validate_x_resource_name): Simplify count usage.
2991 This also avoids a warning with gcc -Wstrict-overflow.
2992
2993 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2994 fail (Bug#8306).
2995
2996 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2997
2998 * process.c (Fmake_network_process): Use socklen_t, not int,
2999 where POSIX says socklen_t is required in portable programs.
3000 This fixes a porting bug on hosts like 64-bit HP-UX, where
3001 socklen_t is wider than int (Bug#8277).
3002 (Fmake_network_process, server_accept_connection):
3003 (wait_reading_process_output, read_process_output):
3004 Likewise.
3005
3006 * process.c: Rename or move locals to avoid shadowing.
3007 (list_processes_1, Fmake_network_process):
3008 (read_process_output_error_handler, exec_sentinel_error_handler):
3009 Rename or move locals.
3010 (Fmake_network_process): Define label "retry_connect" only if needed.
3011 (Fnetwork_interface_info): Fix pointer signedness.
3012 (process_send_signal): Add cast to avoid pointer signedness problem.
3013 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3014 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3015
3016 Make tparam.h and terminfo.c consistent.
3017 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3018 Include tparam.h instead, since it declares them.
3019 * cm.h (PC): Remove extern decl; tparam.h now does this.
3020 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3021 * terminfo.c: Include tparam.h, to check interfaces.
3022 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3023 (tparam): Adjust signature to match interface in tparam.h;
3024 this removes some undefined behavior. Check that outstring and len
3025 are zero, which they always are with Emacs.
3026 * tparam.h (PC, BC, UP): New extern decls.
3027
3028 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3029 (xftfont_open): Rename locals to avoid shadowing.
3030
3031 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3032 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3033 (OTF_TAG_SYM): Omit macro if not needed.
3034 (ftfont_list): Remove unused local.
3035 (get_adstyle_property, ftfont_pattern_entity):
3036 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3037 Rename locals to avoid shadowing.
3038
3039 * xfont.c (xfont_list_family): Mark var as initialized.
3040
3041 * xml.c (make_dom): Now static.
3042
3043 * composite.c (composition_compute_stop_pos): Rename local to
3044 avoid shadowing.
3045 (composition_reseat_it): Remove unused locals.
3046 (find_automatic_composition, composition_adjust_point): Likewise.
3047 (composition_update_it): Mark var as initialized.
3048 (find_automatic_composition): Mark vars as initialized,
3049 with a FIXME (Bug#8290).
3050
3051 character.h: Rename locals to avoid shadowing.
3052 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3053 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3054 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3055 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3056 to avoid shadowing.
3057
3058 * textprop.c (property_change_between_p): Remove; unused.
3059
3060 * intervals.c (interval_start_pos): Now static.
3061
3062 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3063
3064 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3065 Rename locals to avoid shadowing.
3066
3067 * sound.c (wav_play, au_play, Fplay_sound_internal):
3068 Fix pointer signedness.
3069 (alsa_choose_format): Remove unused local var.
3070 (wav_play): Initialize a variable to 0, to prevent undefined
3071 behavior (Bug#8278).
3072
3073 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3074
3075 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3076
3077 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3078 clobbering (Bug#8298).
3079 * sysdep.c (sys_subshell): Likewise.
3080 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3081
3082 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3083 This should get cleaned up, so that child_setup has the
3084 same signature on all platforms.
3085
3086 * callproc.c (call_process_cleanup): Now static.
3087 (relocate_fd): Rename locals to avoid shadowing.
3088
3089 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3090
3091 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3092 not to be necessary, and produces flickering.
3093
3094 2011-03-20 Glenn Morris <rgm@gnu.org>
3095
3096 * config.in: Remove file.
3097
3098 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3099
3100 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3101 are now in src/globals.h.
3102 (syms_of_minibuf): Remove spurious & from previous change.
3103
3104 2011-03-20 Leo <sdl.web@gmail.com>
3105
3106 * minibuf.c (completing-read-function): New variable.
3107 (completing-read-default): Rename from completing-read.
3108 (completing-read): Call completing-read-function.
3109
3110 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3111
3112 * xfaces.c (Fx_load_color_file):
3113 Read color file from absolute filename (bug#8250).
3114
3115 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * makefile.w32-in: Update dependencies.
3118
3119 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3120
3121 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3122
3123 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 Fix more problems found by GCC 4.5.2's static checks.
3126
3127 * process.c (make_serial_process_unwind, send_process_trap):
3128 (sigchld_handler): Now static.
3129
3130 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3131 That way, the code declares only the vars that it needs.
3132 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3133 * s/cygwin.h (PTY_ITERATION): Likewise.
3134 * s/darwin.h (PTY_ITERATION): Likewise.
3135 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3136
3137 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3138 * process.c (allocate_pty): Don't declare stb unless it's needed.
3139
3140 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3141 (CONSTANTLIM): Remove; unused.
3142 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3143 Define only if needed.
3144
3145 * unexelf.c (unexec): Name an expression,
3146 to avoid gcc -Wbad-function-cast warning.
3147 Use a different way to cause a compilation error if anyone uses
3148 n rather than nn, a way that does not involve shadowing.
3149 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3150
3151 * deps.mk (unexalpha.o): Remove; unused.
3152
3153 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3154 * unexec.h: New file.
3155 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3156 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3157 Depend on unexec.h.
3158 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3159 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3160 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3161 Change as necessary to match prototype in unexec.h.
3162
3163 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3164 shadowing.
3165 (back_comment, skip_chars): Mark vars as initialized.
3166
3167 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3168 Rename locals to avoid shadowing.
3169
3170 * lread.c (read1): Rewrite so as not to use empty "else".
3171 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3172
3173 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3174
3175 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3176 warning when compiling print.c.
3177
3178 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3179 instead of using an uninitialized var.
3180 (font_sort_entities): Mark var as initialized.
3181
3182 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3183
3184 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3185 pointers to constants.
3186 (font_parse_fcname): Remove unused vars.
3187 (font_delete_unmatched): Now static.
3188 (font_get_spec): Remove; unused.
3189 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3190 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3191 Rename or move locals to avoid shadowing.
3192
3193 * fns.c (require_nesting_list, require_unwind): Now static.
3194 (Ffillarray): Rename locals to avoid shadowing.
3195
3196 * floatfns.c (domain_error2): Define only if needed.
3197 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3198
3199 * alloc.c (mark_backtrace): Move decl from here ...
3200 * lisp.h: ... to here, so that it can be checked.
3201
3202 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3203 (Fdefvar): Rewrite so as not to use empty "else".
3204 (lisp_indirect_variable): Name an expression,
3205 to avoid gcc -Wbad-function-cast warning.
3206 (Fdefvar): Rename locals to avoid shadowing.
3207
3208 * callint.c (quotify_arg, quotify_args): Now static.
3209 (Fcall_interactively): Rename locals to avoid shadowing.
3210 Use const pointer when appropriate.
3211
3212 * lisp.h (get_system_name, get_operating_system_release):
3213 Move decls here, to check interfaces.
3214 * process.c (get_operating_system_release): Move decl to lisp.h.
3215 * xrdb.c (get_system_name): Likewise.
3216 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3217 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3218 some of which prompt warnings from gcc -Wbad-function-cast.
3219 (Fformat_time_string, Fencode_time, Finsert_char):
3220 (Ftranslate_region_internal, Fformat):
3221 Rename or remove local vars to avoid shadowing.
3222 (Ftranslate_region_internal): Mark var as initialized.
3223
3224 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3225 avoid shadowing.
3226
3227 * lisp.h (eassert): Check that the argument compiles, even if
3228 ENABLE_CHECKING is not defined.
3229
3230 * data.c (Findirect_variable): Name an expression, to avoid
3231 gcc -Wbad-function-cast warning.
3232 (default_value, arithcompare, arith_driver, arith_error): Now static.
3233 (store_symval_forwarding): Rename local to avoid shadowing.
3234 (Fmake_variable_buffer_local, Fmake_local_variable):
3235 Mark variables as initialized.
3236 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3237
3238 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3239 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3240 Rename locals to avoid shadowing.
3241 (mark_stack): Move local variables into the #ifdef region where
3242 they're used.
3243 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3244 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3245 needed otherwise.
3246 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3247 (GC_STRING_CHARS): Remove; not used.
3248 (Fmemory_limit): Cast sbrk's returned value to char *.
3249
3250 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3251 avoids undefined behavior in theory.
3252
3253 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3254
3255 Use functions, not macros, for up- and down-casing (Bug#8254).
3256 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3257 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3258 to use the following functions instead of these macros.
3259 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3260 EMACS_INT, since callers assume the returned value fits in int.
3261 (upcase1): Likewise, for UPCASE_TABLE.
3262 (uppercasep, lowercasep, upcase): New static inline functions.
3263 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3264 the race-condition problem in the old DOWNCASE.
3265
3266 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3267 Rename locals to avoid shadowing.
3268 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3269 (regex_compile, re_search_2, re_match_2_internal):
3270 Remove unused local vars.
3271 (FREE_VAR): Rewrite so as not to use empty "else",
3272 which gcc can warn about.
3273 (regex_compile, re_match_2_internal): Mark locals as initialized.
3274 (RETALLOC_IF): Define only if needed.
3275 (WORDCHAR_P): Likewise. This one is never needed, but is used
3276 only in a comment talking about a compiler bug, so put inside
3277 the #if 0 of that comment.
3278 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3279 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3280 Remove; unused.
3281
3282 * search.c (boyer_moore): Rename locals to avoid shadowing.
3283 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3284 (PREV_CHAR_BOUNDARY): Likewise.
3285
3286 * search.c (simple_search): Remove unused var.
3287
3288 * dired.c (compile_pattern): Move decl from here ...
3289 * lisp.h: ... to here, so that it can be checked.
3290 (struct re_registers): New forward decl.
3291
3292 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3293
3294 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3295 All uses changed.
3296 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3297 Rename locals to avoid shadowing.
3298 (Fvertical_motion): Mark locals as initialized.
3299
3300 * casefiddle.c (casify_object, casify_region): Now static.
3301 (casify_region): Mark local as initialized.
3302
3303 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3304
3305 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3306 New macros, so that the caller can use some names other than
3307 gcpro1, gcpro2, etc.
3308 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3309 of the new macros.
3310 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3311 argument, for consistency with GCPRO2_VAR, etc: it is now the
3312 prefix of the variable, not the variable itself. All uses
3313 changed.
3314 * dired.c (directory_files_internal, file_name_completion):
3315 Rename locals to avoid shadowing.
3316
3317 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3318 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3319 dired.c's scmp function, had undefined behavior.
3320 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3321 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3322 * buffer.h: ... to here, because these macros use current_buffer,
3323 and the new implementation with inline functions needs to have
3324 current_buffer in scope now, rather than later when the macros
3325 are used.
3326 (downcase, upcase1): New static inline functions.
3327 (DOWNCASE, UPCASE1): Reimplement using these functions.
3328 This avoids undefined behavior in expressions like
3329 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3330 from race conditions in accessing the global variables
3331 case_temp1 and case_temp2.
3332 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3333 * lisp.h (case_temp1, case_temp2): Remove their decls.
3334 * character.h (ASCII_CHAR_P): Move from here ...
3335 * lisp.h: ... to here, so that the inline functions mentioned
3336 above can use them.
3337
3338 * dired.c (directory_files_internal_unwind): Now static.
3339
3340 * fileio.c (file_name_as_directory, directory_file_name):
3341 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3342 Now static.
3343 (file_name_as_directory): Use const pointers when appropriate.
3344 (Fexpand_file_name): Likewise. In particular, newdir might
3345 point at constant storage, so make it a const pointer.
3346 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3347 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3348 signedness issues.
3349 (Fset_file_times, Finsert_file_contents, auto_save_error):
3350 Rename locals to avoid shadowing.
3351
3352 * minibuf.c (choose_minibuf_frame_1): Now static.
3353 (Ftry_completion, Fall_completions): Rename or remove locals
3354 to avoid shadowing.
3355
3356 * marker.c (bytepos_to_charpos): Remove; unused.
3357
3358 * lisp.h (verify_bytepos, count_markers): New decls,
3359 so that gcc does not warn that these functions aren't declared.
3360
3361 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3362 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3363 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3364 (copy_text): Remove unused local var.
3365
3366 * filelock.c (within_one_second): Now static.
3367 (lock_file_1): Rename local to avoid shadowing.
3368
3369 * buffer.c (fix_overlays_before): Mark locals as initialized.
3370 (fix_start_end_in_overlays): Likewise. This function should be
3371 simplified by using pointers-to-pointers, but that's a different
3372 matter.
3373 (switch_to_buffer_1): Now static.
3374 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3375 (report_overlay_modification): Rename locals to avoid shadowing.
3376
3377 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3378 Fix pointer signedness issue.
3379 (sys_subshell): Mark local as volatile if checking for lint,
3380 to suppress a gcc -Wclobbered warning that does not seem to be right.
3381 (MAXPATHLEN): Define only if needed.
3382
3383 * process.c (serial_open, serial_configure): Move decls from here ...
3384 * systty.h: ... to here, so that they can be checked.
3385
3386 * fns.c (get_random, seed_random): Move extern decls from here ...
3387 * lisp.h: ... to here, so that they can be checked.
3388
3389 * sysdep.c (reset_io): Now static.
3390 (wait_for_termination_signal): Remove; unused.
3391
3392 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3393 (copy_keymap_item, append_key, push_text_char_description):
3394 Now static.
3395 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3396 (DENSE_TABLE_SIZE): Remove; unused.
3397 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3398 (describe_map_tree):
3399 Rename locals to avoid shadowing.
3400
3401 * keyboard.c: Declare functions static if they are not used elsewhere.
3402 (echo_char, echo_dash, cmd_error, top_level_2):
3403 (poll_for_input, handle_async_input): Now static.
3404 (read_char, kbd_buffer_get_event, make_lispy_position):
3405 (make_lispy_event, make_lispy_movement, apply_modifiers):
3406 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3407 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3408 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3409 (read_key_sequence, read_char): Mark locals as initialized.
3410 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3411
3412 * keyboard.h (make_ctrl_char): New decl.
3413 (mark_kboards): Move decl here ...
3414 * alloc.c (mark_kboards): ... from here.
3415
3416 * lisp.h (force_auto_save_soon): New decl.
3417
3418 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3419 (DEFINE_DUMMY_FUNCTION): New macro.
3420 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3421 Use it.
3422 (main): Add casts to avoid warnings
3423 if GCC considers string literals to be constants.
3424
3425 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3426
3427 * dbusbind.c: Pointer signedness fixes.
3428 (xd_signature, xd_append_arg, xd_initialize):
3429 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3430 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3431 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3432 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3433
3434 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3435 if GCC considers string literals to be constants.
3436 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3437
3438 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3439
3440 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3441 (print_preprocess, print_object): New macro to fix last change.
3442
3443 * print.c (print_preprocess): Don't forget font objects.
3444
3445 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * emacs.c (USAGE3): Doc fixes.
3448
3449 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3450
3451 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3452 structure.
3453
3454 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3455
3456 * lisp.h (VWindow_system, Qfile_name_history):
3457 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3458 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3459 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3460
3461 * w32select.c: Don't #include "keyboard.h".
3462 (run_protected): Add extern declaration for waiting_for_input.
3463
3464 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3465 * w32console.c (detect_input_pending, read_input_pending)
3466 (encode_terminal_code):
3467 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3468 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3469 (w32_system_caret_y, Qfile_name_history):
3470 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3471 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3472 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3473 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3474 * w32proc.c (Qlocal, report_file_error):
3475 * w32term.c (Vwindow_system, updating_frame):
3476 * w32uniscribe.c (initialized, uniscribe_font_driver):
3477 Remove unneeded extern declarations.
3478
3479 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3480
3481 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3482
3483 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3484
3485 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3486 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3487 These macros can no longer be used for assignment.
3488
3489 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3490 Assign struct members directly, instead of using BUF_BEGV etc.
3491 (record_buffer_markers, fetch_buffer_markers): New functions for
3492 recording and fetching special buffer markers.
3493 (set_buffer_internal_1, set_buffer_temp): Use them.
3494
3495 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3496
3497 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3498
3499 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3500 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3501
3502 * xdisp.c (hscroll_window_tree):
3503 (reconsider_clip_changes): Use PT instead of BUF_PT.
3504
3505 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3506
3507 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3508 $(EMACS_ROOT)/lib/intprops.h.
3509
3510 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 Fix more problems found by GCC 4.5.2's static checks.
3513
3514 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3515 to unsigned char * to avoid compiler diagnostic.
3516 (xg_free_frame_widgets): Make it clear that a local variable is
3517 needed only if USE_GTK_TOOLTIP.
3518 (gdk_window_get_screen): Make it clear that this macro is needed
3519 only if USE_GTK_TOOLTIP.
3520 (int_gtk_range_get_value): New function, which avoids a diagnostic
3521 from gcc -Wbad-function-cast.
3522 (xg_set_toolkit_scroll_bar_thumb): Use it.
3523 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3524 diagnostic from gcc -Wbad-function-cast.
3525 (get_utf8_string, xg_get_file_with_chooser):
3526 Rename locals to avoid shadowing.
3527 (create_dialog): Move locals to avoid shadowing.
3528
3529 * xgselect.c (xg_select): Remove unused var.
3530
3531 * image.c (four_corners_best): Mark locals as initialized.
3532 (gif_load): Initialize transparent_p to zero (Bug#8238).
3533 Mark another local as initialized.
3534 (my_png_error, my_error_exit): Mark with NO_RETURN.
3535
3536 * image.c (clear_image_cache): Now static.
3537 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3538 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3539 (x_edge_detection): Remove unnecessary cast that
3540 gcc -Wbad-function-cast diagnoses.
3541 (gif_load): Fix pointer signedness.
3542 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3543 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3544
3545 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 Improve quality of tests for time stamp overflow.
3548 For example, without this patch (encode-time 0 0 0 1 1
3549 1152921504606846976) returns the obviously-bogus value (-948597
3550 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3551 reports time overflow. See
3552 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3553 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3554 * editfns.c: Include limits.h and intprops.h.
3555 (TIME_T_MIN, TIME_T_MAX): New macros.
3556 (time_overflow): Move earlier, to before first use.
3557 (hi_time, lo_time): New functions, for an accurate test for
3558 out-of-range times.
3559 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3560 (Fget_internal_run_time): Don't assume time_t fits in int.
3561 (make_time): Use list2 instead of Fcons twice.
3562 (Fdecode_time): More accurate test for out-of-range times.
3563 (check_tm_member): New function.
3564 (Fencode_time): Use it, to test for out-of-range times.
3565 (lisp_time_argument): Don't rely on undefined left-shift and
3566 right-shift behavior when checking for time stamp overflow.
3567
3568 * editfns.c (time_overflow): New function, refactoring common code.
3569 (Fformat_time_string, Fdecode_time, Fencode_time):
3570 (Fcurrent_time_string): Use it.
3571
3572 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3573 * dired.c (make_time): Move to ...
3574 * editfns.c (make_time): ... here.
3575 * systime.h: Note the move.
3576
3577 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3578
3579 * fringe.c (update_window_fringes): Remove unused variables.
3580
3581 * unexmacosx.c (copy_data_segment): Also copy __got section.
3582 (Bug#8223)
3583
3584 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3585
3586 * termcap.c [MSDOS]: Include "msdos.h".
3587 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3588 Constify `char *' arguments and their references according to
3589 prototypes in tparam.h.
3590
3591 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3592
3593 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3594 Adapt all references accordingly.
3595
3596 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3597
3598 2011-03-11 Tom Tromey <tromey@redhat.com>
3599
3600 * buffer.c (syms_of_buffer): Remove obsolete comment.
3601
3602 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3603
3604 * termhooks.h (encode_terminal_code): Declare prototype.
3605
3606 * msdos.c (encode_terminal_code): Don't declare prototype.
3607
3608 * term.c (encode_terminal_code): Now external again, used by
3609 w32console.c and msdos.c.
3610
3611 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3612 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3613
3614 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Fix some minor problems found by GCC 4.5.2's static checks.
3617
3618 * fringe.c (update_window_fringes): Mark locals as initialized
3619 (Bug#8227).
3620 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3621
3622 * alloc.c (mark_fringe_data): Move decl from here ...
3623 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3624 to check its interface.
3625 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3626
3627 * fontset.c (free_realized_fontset): Now static.
3628 (Fset_fontset_font): Rename local to avoid shadowing.
3629 (fontset_font): Mark local as initialized.
3630 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3631
3632 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3633
3634 * xselect.c (x_disown_buffer_selections): Remove; not used.
3635 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3636 (x_own_selection, Fx_disown_selection_internal): Rename locals
3637 to avoid shadowing.
3638 (x_handle_dnd_message): Remove local to avoid shadowing.
3639
3640 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3641 so that the caller can use some name other than gcpro1.
3642 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3643 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3644 (Fx_backspace_delete_keys_p):
3645 Use them to avoid shadowing, and rename vars to avoid shadowing.
3646 (x_decode_color, x_set_name, x_window): Now static.
3647 (Fx_create_frame): Add braces to silence GCC warning.
3648 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3649 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3650 Remove unused locals.
3651 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3652 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3653 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3654 macros.
3655
3656 * xterm.h (x_mouse_leave): New decl.
3657
3658 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3659 Remove unused functions.
3660 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3661 (x_calc_absolute_position): Now static.
3662 (XTread_socket): Don't define label "out" unless it's used.
3663 Don't declare local "event" unless it's used.
3664 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3665 unless they are used.
3666 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3667 (x_fatal_error_signal): Remove; not used.
3668 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3669 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3670 (x_error_catcher, x_connection_closed, x_error_handler):
3671 (x_error_quitter, xembed_send_message, x_iconify_frame):
3672 (my_log_handler): Rename locals to avoid shadowing.
3673 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3674 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3675
3676 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3677 Rename or move locals to avoid shadowing.
3678 (tty_defined_color, merge_face_heights): Now static.
3679 (free_realized_faces_for_fontset): Remove; not used.
3680 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3681 does not deduce is never used uninitialized.
3682 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3683 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3684
3685 * terminal.c (store_terminal_param): Now static.
3686
3687 * xmenu.c (menu_highlight_callback): Now static.
3688 (set_frame_menubar): Remove unused local.
3689 (xmenu_show): Rename parameter to avoid shadowing.
3690 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3691 since they might point to immutable storage.
3692 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3693 since it's unused otherwise.
3694
3695 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3696 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3697 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3698 avoids a gcc -Wuninitialized diagnostic.
3699 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3700 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3701 does not deduce are never used uninitialized.
3702
3703 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3704
3705 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3706 * window.c (window_loop, size_window):
3707 (run_window_configuration_change_hook, enlarge_window): Likewise.
3708
3709 * window.c (display_buffer): Now static.
3710 (size_window): Mark variables that gcc -Wuninitialized
3711 does not deduce are never used uninitialized.
3712 * window.h (check_all_windows): New decl, to forestall
3713 gcc -Wmissing-prototypes diagnostic.
3714 * dispextern.h (bidi_dump_cached_states): Likewise.
3715
3716 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3717 shadowing.
3718 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3719 Include <limits.h>.
3720 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3721 and to avoid gcc -Wuninitialized warning.
3722 (load_charset_map): Mark variables that gcc -Wuninitialized
3723 does not deduce are never used uninitialized.
3724 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3725
3726 * coding.c (coding_set_source, coding_set_destination):
3727 Use "else { /* comment */ }" rather than "else /* comment */;"
3728 for clarity, and to avoid gcc -Wempty-body warning.
3729 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3730 a block, when the outer 'i' will do.
3731 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3732 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3734 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3735 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3736 Rename locals to avoid shadowing.
3737 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3738 * coding.c (emacs_mule_char, encode_invocation_designation):
3739 Now static, since they're not used elsewhere.
3740 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3741 (decode_coding_object, encode_coding_object, detect_coding_system):
3742 (decode_coding_emacs_mule): Mark variables that gcc
3743 -Wuninitialized does not deduce are never used uninitialized.
3744 (detect_coding_iso_2022): Initialize a local variable that might
3745 be used uninitialized. Leave a FIXME because it's not clear that
3746 this initialization is needed. (Bug#8211)
3747 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3748 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3749 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3750 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3751 Remove unused macros.
3752
3753 * category.c (hash_get_category_set): Remove unused local var.
3754 (copy_category_table): Now static, since it's not used elsewhere.
3755 * character.c (string_count_byte8): Likewise.
3756
3757 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3758 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3759
3760 * chartab.c (copy_sub_char_table): Now static, since it's not used
3761 elsewhere.
3762 (sub_char_table_ref_and_range, char_table_ref_and_range):
3763 Rename locals to avoid shadowing.
3764 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3765
3766 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3767 (BIDI_BOB): Remove unused macro.
3768
3769 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3770 deduce are never used uninitialized.
3771 * term.c (encode_terminal_code): Likewise.
3772
3773 * term.c (encode_terminal_code): Now static. Remove unused local.
3774
3775 * tparam.h: New file.
3776 * term.c, tparam.h: Include it.
3777 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3778 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3779 Move these decls to tparam.h, and make them agree with what
3780 is actually in tparam.c. The previous trick of using incompatible
3781 decls in different modules does not conform to the C standard.
3782 All callers of tparam changed to use tparam's actual API.
3783 * tparam.c (tparam1, tparam, tgoto):
3784 Use const pointers where appropriate.
3785
3786 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3787 * cm.h (struct cm): Likewise.
3788 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3789 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3790 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3791 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3792 (turn_on_face, init_tty): Likewise.
3793 * termchar.h (struct tty_display_info): Likewise.
3794
3795 * term.c (term_mouse_position): Rename local to avoid shadowing.
3796
3797 * alloc.c (mark_ttys): Move decl from here ...
3798 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3799
3800 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3801
3802 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3803
3804 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3805
3806 * search.c (compile_pattern_1): Remove argument regp, unused since
3807 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3808 (compile_pattern): Don't pass it.
3809
3810 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3813 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3814 for ! HAVE_GTK3.
3815 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3816
3817 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3818
3819 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3820 gdk_window_get_screen, gdk_window_get_geometry,
3821 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3822 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3823 (xg_get_pixbuf_from_pixmap): New function.
3824 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3825 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3826 Call xg_get_pixbuf_from_pixmap instead of
3827 gdk_pixbuf_get_from_drawable.
3828 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3829 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3830 (xg_check_special_colors): Use GtkStyleContext and its functions
3831 for HAVE_GTK3.
3832 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3833 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3834 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3835 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3836 Call gtk_widget_get_preferred_size.
3837 (xg_frame_resized): gdk_window_get_geometry only takes 5
3838 parameters.
3839 (xg_win_to_widget, xg_event_is_for_menubar):
3840 Call gdk_x11_window_lookup_for_display.
3841 (xg_set_widget_bg): New function.
3842 (delete_cb): New function.
3843 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3844 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3845 (xg_set_background_color): Call xg_set_widget_bg.
3846 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3847 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3848 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3849 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3850 if ! HAVE_GTK3.
3851 (update_frame_tool_bar): Call gtk_widget_hide.
3852 (xg_initialize): Use GDK_KEY_g.
3853
3854 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3855 if ! HAVE_GTK3
3856 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3857
3858 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3859 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3860 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3861
3862 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * w32xfns.c (select_palette): Check success of RealizePalette against
3865 GDI_ERROR, not zero.
3866
3867 See ChangeLog.11 for earlier changes.
3868
3869 ;; Local Variables:
3870 ;; coding: utf-8
3871 ;; End:
3872
3873 Copyright (C) 2011 Free Software Foundation, Inc.
3874
3875 This file is part of GNU Emacs.
3876
3877 GNU Emacs is free software: you can redistribute it and/or modify
3878 it under the terms of the GNU General Public License as published by
3879 the Free Software Foundation, either version 3 of the License, or
3880 (at your option) any later version.
3881
3882 GNU Emacs is distributed in the hope that it will be useful,
3883 but WITHOUT ANY WARRANTY; without even the implied warranty of
3884 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3885 GNU General Public License for more details.
3886
3887 You should have received a copy of the GNU General Public License
3888 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.