1 2012-06-30 Eli Zaretskii <eliz@gnu.org>
3 * sysselect.h [DOS_NT]: Don't include sys/select.h.
5 * s/ms-w32.h (select, pselect): Don't define here, they are
8 * sysselect.h (pselect) [!HAVE_PSELECT]: Redirect to sys_select.
10 * sysdep.c: Don't include dos.h and dosfns.h.
12 * process.c (sys_select):
13 * msdos.c (sys_select): Accept one more argument and ignore it.
15 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
16 adapt data types and code to that.
19 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
20 which clashes with the gnulib function of the same name.
22 2012-06-29 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (try_window_id): Undo last change.
26 * w32.c (getwd): Adjust commentary about startup_dir.
27 (init_environment): Always call sys_access, even in non-MSVC
28 builds. Don't chdir to the directory of the Emacs executable.
29 This undoes code from 1997 which was justified by the need to
30 "avoid conflicts when removing and renaming directories". But its
31 downside was that every relative file name was being interpreted
32 relative to the directory of the Emacs executable, which can never
33 be TRT. In particular, it broke sys_access when called with
35 (sys_access): Map GetLastError to errno.
37 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
39 * window.h (struct window): Change type of 'fringes_outside_margins'
40 to bitfield. Fix comment. Adjust users accordingly.
41 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
43 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
46 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
48 * gnutls.c (emacs_gnutls_handshake):
49 Add QUIT to make the loop interruptible.
51 2012-06-29 Glenn Morris <rgm@gnu.org>
53 * charset.c (init_charset): Make lack of etc/charsets fatal.
55 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
57 * editfns.c (region_limit): Fix type mismatch.
59 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
61 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
62 undefined. Convert from xassert to eassert.
63 * nsmenu.m: Convert from xassert to eassert.
66 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
68 * editfns.c (region_limit): Clip to narrowing (bug#11770).
70 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
72 Avoid integer overflow on scroll-left and scroll-right.
73 * window.c (HSCROLL_MAX): New macro.
74 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
75 overflow when requested scroll falls outside ptrdiff_t range.
77 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
79 * window.h (struct window): Change type of 'hscroll',
80 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
81 'last_modified' and 'last_overlay_modified' to EMACS_INT.
82 Adjust users accordingly.
83 * xdisp.c (try_cursor_movement): Replace type check with eassert.
84 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
85 from EMACS_INT to ptrdiff_t.
86 (make_window): Omit redundant initialization.
88 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
90 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
92 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
94 * window.h (struct window): Change type of 'use_time' and
95 'sequence_number' from Lisp_Object to int.
96 * frame.c (make_frame): Adjust users accordingly.
97 * print.c (print_object): Likewise.
98 * window.c (select_window, Fwindow_use_time, make_parent_window)
99 (make_window): Likewise.
101 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
103 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
104 enabled with --enable-checking=[all,glyphs] configure option.
105 Fix GLYPH_DEBUG usage assuming that it may be undefined,
106 adjust comments accordingly.
107 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
108 undefined, adjust comments accordingly.
110 * scroll.c: Likewise.
111 * w32fns.c: Likewise.
112 * w32term.c: Likewise.
114 * xfaces.c: Likewise.
118 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
120 Generalize run-time debugging checks.
121 * dispextern.h (XASSERTS): Remove.
122 * fontset.c (xassert): Remove.
123 Convert from xassert to eassert.
124 * alloc.c: Convert from xassert to eassert.
126 * dispnew.c: Likewise.
128 * fringe.c: Likewise.
129 * ftfont.c: Likewise.
130 * gtkutil.c: Likewise.
132 * keyboard.c: Likewise.
134 * process.c: Likewise.
135 * scroll.c: Likewise.
138 * w32console.c: Likewise.
139 * w32fns.c: Likewise.
140 * w32term.c: Likewise.
141 * window.c: Likewise.
143 * xfaces.c: Likewise.
145 * xselect.c: Likewise.
148 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
150 * fns.c (maybe_resize_hash_table): Output message when growing the
153 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
155 * alloc.c (allocate_string_data): Remove dead code.
156 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
157 avoid GCC warning about unused macro.
159 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
161 * alloc.c (allocate_string): Omit intervals initialization.
162 * alloc.c (make_uninit_multibyte_string): Initialize intervals
163 as in make_pure_string and make_pure_c_string.
165 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
167 * alloc.c (allocate_string): Fix last change.
169 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
171 * alloc.c (allocate_string): Remove two redundant calls
172 to memset, add explicit initialization where appropriate.
174 2012-06-27 Glenn Morris <rgm@gnu.org>
176 * lisp.mk (lisp): Remove paths.elc.
178 2012-06-27 Chong Yidong <cyd@gnu.org>
180 * doc.c (Fsubstitute_command_keys): Fix punctuation.
182 2012-06-26 John Wiegley <johnw@newartisans.com>
184 * unexmacosx.c (copy_data_segment): Add two section names used
185 on Mac OS X Lion: __mod_init_func and __mod_term_func.
187 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
188 when building with Clang.
190 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
192 * eval.c (Fapply): Allow calling it with a single argument.
194 2012-06-26 Eli Zaretskii <eliz@gnu.org>
196 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
197 _stricmp and _strnicmp.
198 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
200 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
202 * alloc.c (allocate_window): Zero out non-Lisp part of newly
204 (allocate_process): Likewise for new process.
205 (allocate_terminal): Change to use offsetof.
206 (allocate_frame): Likewise.
207 * frame.c (make_frame): Omit redundant initialization.
208 * window.c (make_parent_window): Use memset.
209 (make_window): Omit redundant initialization.
210 * process.c (make_process): Omit redundant initialization.
211 * terminal.c (create_terminal): Likewise.
213 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
215 * term.c (delete_tty): Remove redundant call to memset.
217 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
219 * alloc.c: Remove build_string.
220 * lisp.h: Define build_string as static inline. This provides
221 a better opportunity to optimize away calls to strlen when the
222 function is called with compile-time constant argument.
223 * image.c (imagemagick_error): Convert to build_string.
224 * w32proc.c (sys_spawnve): Likewise.
225 * xterm.c (x_term_init): Likewise.
227 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
229 Use sprintf return value instead of invoking strlen on result.
230 In the old days this wasn't portable, since some sprintf
231 implementations returned char *. But they died out years ago and
232 Emacs already assumes sprintf returns int.
233 Similarly for float_to_string.
234 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
235 * ccl.c (ccl_driver):
236 * character.c (string_escape_byte8):
237 * data.c (Fnumber_to_string):
239 * print.c (print_object):
240 * xdisp.c (message_dolog):
241 * xfns.c (syms_of_xfns):
242 Use sprintf or float_to_string result to avoid need to call strlen.
243 * data.c (Fnumber_to_string):
244 Use make_unibyte_string, since the string must be ASCII.
245 * lisp.h, print.c (float_to_string): Now returns int length.
246 * term.c (produce_glyphless_glyph):
247 Use sprintf result rather than recomputing it.
249 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
250 * Makefile.in (ALL_CFLAGS):
251 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
252 * gmalloc.c, regex.c: Include <config.h> unconditionally.
254 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
256 * dispextern.h (xstrcasecmp): Define to library function
257 strcasecmp if available.
258 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
260 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
262 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
263 Avoid comma operator.
264 * menu.c (push_submenu_start, push_submenu_end)
265 (push_left_right_boundary, push_menu_pane): Likewise.
266 * msdos.c (dos_rawgetc): Likewise.
268 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
270 * xfns.c (xic_create_fontsetname): Remove redundant calls
273 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
275 * gtkutil.c (get_utf8_string): Remove redundant assignment.
276 sprintf already null-terminates its output.
278 * xfns.c (x_window): Remove redundant cast.
280 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
282 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
283 `const char *' to `char *' to avoid compiler warning.
285 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
287 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
288 instead of truncating it to 63 (admittedly a generous limit).
290 * process.c: Fix spelling and caps in comments.
292 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
294 * emacs.c (setpgrp): Remove definition, unused.
295 * sysdep.c (setpgrp): Remove definition, not used in this file.
297 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
299 * makefile.w32-in: Update dependencies.
301 2012-06-24 Eli Zaretskii <eliz@gnu.org>
303 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
304 (SYSTIME_H): Add nt/inc/sys/time.h.
306 * systime.h [WINDOWSNT]: Include sys/time.h.
308 * s/ms-w32.h (struct timespec): Definition moved from
309 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
311 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
313 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
314 * buffer.h (buffer_slot_type_mismatch):
315 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
316 * eval.c (unwind_to_catch):
317 * image.c (my_png_error, my_error_exit):
318 * keyboard.c (quit_throw_to_read_char, user_error)
319 (Fexit_recursive_edit, Fabort_recursive_edit):
320 * lisp.h (die, args_out_of_range, args_out_of_range_3)
321 (wrong_type_argument, buffer_overflow, __executable_start)
322 (memory_full, buffer_memory_full, string_overflow, Fthrow)
323 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
324 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
326 (child_setup) [!DOS_NT]:
327 * lread.c (end_of_file_error, invalid_syntax):
328 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
329 * puresize.h (pure_write_error):
330 * search.c (matcher_overflow):
331 * sound.c (sound_perror, alsa_sound_perror):
332 * sysdep.c, syssignal.h (croak):
333 * term.c (maybe_fatal, vfatal):
334 * textprop.c (text_read_only):
335 * undo.c (user_error):
336 * unexmacosx.c (unexec_error):
337 * xterm.c (x_ins_del_lines, x_delete_glyphs):
338 Use _Noreturn rather than NO_RETURN.
339 No need for separate decl merely because of _Noreturn.
340 * sound.c (sound_warning, parse_sound):
341 Remove unnecessary forward decls.
343 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
345 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
346 * lisp.h (WAIT_READING_MAX): New macro.
347 * dispnew.c (Fsleep_for, sit_for):
348 * keyboard.c (kbd_buffer_get_event):
349 * process.c (Faccept_process_output):
350 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
351 This improves on the previous patch, which introduced a bug
352 when time_t is unsigned and as wide as intmax_t.
353 See <http://bugs.gnu.org/9000#51>.
355 2012-06-23 Eli Zaretskii <eliz@gnu.org>
357 * dispnew.c (sit_for, Fsleep_for):
358 * keyboard.c (kbd_buffer_get_event):
359 * process.c (Faccept_process_output): Avoid compiler warnings when
360 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
362 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
364 * makefile.w32-in: Update dependencies.
366 * w32.c (ltime): Add return type and declare static.
367 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
369 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
371 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
372 Privately reported by Herbert J. Skuhra.
373 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
375 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
376 not make_lisp_timeval, when the argument is of type EMACS_TIME.
378 2012-06-23 Eli Zaretskii <eliz@gnu.org>
380 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
381 last argument of make_unibyte_string.
383 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
384 language ID in the event parameters.
386 * w32term.c (w32_read_socket): Put the new keyboard codepage into
387 event.code, not the obscure "character set ID".
389 2012-06-23 Chong Yidong <cyd@gnu.org>
391 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
393 2012-06-23 Eli Zaretskii <eliz@gnu.org>
395 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
396 * w32.c (fdutimens): New function.
398 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
400 * s/ms-w32.h (pselect): Redirect to sys_select.
402 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
404 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
405 in the logic of incrementing and decrementing the value of
406 use_relocatable_buffers.
408 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
410 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
411 Privately reported by Herbert J. Skuhra.
412 [__FreeBSD__]: Remove "*/" typo after "#include".
413 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
414 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
415 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
416 Don't assume EMACS_TIME and struct timeval are the same type.
418 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
420 Support higher-resolution time stamps (Bug#9000).
421 The time stamps are only nanosecond-resolution at the C level,
422 since that's the best that any real-world system supports now.
423 But they are picosecond-resolution at the Lisp level, as that's
424 easy, and leaves room for future OS improvements.
426 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
429 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
430 Don't get current time unless it's needed.
432 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
433 now provides it if it's absent.
434 (start_atimer): Port to higher-res time stamps.
435 Check for time stamp overflow. Don't get current time more
436 often than is needed.
438 * buffer.h (struct buffer): Buffer modtime now has high resolution.
439 Include systime.h, not time.h.
440 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
442 * dired.c: Include stat-time.h.
443 (Ffile-attributes): File times now have higher resolution.
445 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
446 (struct image): Timestamp now has higher resolution.
448 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
449 has at least microseconds now. All uses removed.
450 (update_frame, update_single_window, update_window, update_frame_1)
451 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
453 * editfns.c (time_overflow): Now extern.
454 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
455 (float-time, Fformat_time_string, Fcurrent_time_string)
456 (Fcurrent_time_zone): Accept and generate higher-resolution
458 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
459 (decode_time_components, lisp_seconds_argument): New functions.
460 (make_time): Now static.
461 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
462 Report an error if the time is invalid, rather than having the caller
465 * fileio.c: Include <stat-time.h>
466 (Fcopy_file): Copy higher-resolution time stamps.
467 Prefer to set the time stamp via a file descriptor if that works.
468 (Fset_file_times, Finsert_file_contents, Fwrite_region)
469 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
470 (Fvisited_file_modtime, Fset_visited_file_modtime):
471 Support higher-resolution time stamps.
473 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
475 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
477 * image.c (prepare_image_for_display, clear_image_cache)
478 (lookup_image): Port to higer-resolution time stamps.
480 * keyboard.c (start_polling, bind_polling_period):
481 Check for time stamp overflow.
482 (read_char, kbd_buffer_get_event, timer_start_idle)
483 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
484 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
485 Port to higher-resolution time stamps. Do not assume time_t is signed.
486 (decode_timer): New function. Timers are now vectors of length 9,
487 not 8, to accommodate the picosecond component.
488 (timer_check_2): Use it.
490 * nsterm.m (select_timeout, timeval_subtract): Remove.
491 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
492 as they're a bit more accurate and handle overflow better.
493 (ns_select): Change prototype to be compatible with pselect.
494 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
495 * nsterm.h (ns_select): Adjust prototype.
497 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
498 us-resolution time stamps.
499 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
501 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
503 * lisp.h (time_overflow): New decl.
504 (wait_reading_process_output): First arg is now intmax_t, not int,
505 to accommodate larger waits.
507 * process.h (struct Lisp_Process.read_output_delay):
508 Now counts nanoseconds, not microseconds.
509 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
511 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
512 (wait_reading_process_output):
513 Port to ns-resolution time stamps.
514 (Faccept_process_output, wait_reading_process_output):
515 Check for time stamp overflow. Do not assume time_t is signed.
516 (select_wrapper): Remove; we now use pselect.
517 (Fprocess_attributes): Now generates ns-resolution time stamps.
519 * sysdep.c: Include utimens.h. Don't include utime.h
520 or worry about struct utimbuf; gnulib does that for us now.
521 (gettimeofday): Remove; gnulib provides a substitute.
522 (make_timeval): New function.
523 (set_file_times): Now sets ns-resolution time stamps.
524 New arg FD; all uses changed.
525 (time_from_jiffies, ltime_from_jiffies, get_up_time)
526 (system_process_attributes):
527 Now returns ns-resolution time stamp. All uses changed.
528 Check for time stamp overflow.
530 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
531 provides a substitute now.
533 * systime.h: Include timespec.h rather than sys/time.h and time.h,
534 since it guarantees struct timespec.
535 (EMACS_TIME): Now struct timespec, so that we can support
536 ns-resolution time stamps.
537 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
538 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
539 (EMACS_USECS): Remove.
540 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
541 so multiply the arg by 1000 before storing it.
542 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
544 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
545 Port to ns-resolution time stamps.
546 (EMACS_TIME_NEG_P): Remove; replaced by....
547 (EMACS_TIME_SIGN): New macro.
548 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
549 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
550 (set_file_times, make_time, lisp_time_argument): Adjust signature.
551 (make_timeval, make_lisp_time, decode_time_components): New decls.
552 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
553 that it mishandled time_t overflow. You can't compare by subtracting!
554 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
555 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
557 * term.c: Include <sys/time.h>.
558 (timeval_to_Time): New function, for proper overflow wraparound.
559 (term_mouse_position, term_mouse_click): Use it.
561 * undo.c (record_first_change): Support higher-resolution time stamps
563 (Fprimitive_undo): Use them when restoring time stamps.
565 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
566 (w32_get_internal_run_time):
567 Port to higher-resolution Emacs time stamps.
568 (ltime): Now accepts single 64-bit integer, as that's more convenient
571 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
573 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
574 for compatibility with pselect. Support ns-resolution time stamps.
576 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
578 * xselect.c (wait_for_property_change, x_get_foreign_selection):
579 Check for time stamp overflow, and support ns-resolution time stamps.
581 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
582 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
583 (timeval_subtract): Remove; no longer needed.
584 (XTflash, XTring_bell, x_wait_for_event):
585 Port to ns-resolution time stamps. Don't assume time_t is signed.
587 2012-06-22 Chong Yidong <cyd@gnu.org>
589 * xdisp.c (x_consider_frame_title): Revert last change.
591 2012-06-22 Eli Zaretskii <eliz@gnu.org>
593 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
594 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
595 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
596 staticidx goes up to 1597 out of 1600 = 0x640.)
598 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
600 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
601 Otherwise, the umask might be mistakenly 0 while handling input signals.
603 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
605 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
607 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
609 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
610 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
611 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
612 access to `contents' member of Lisp_Vector objects with AREF and ASET
615 2012-06-19 Chong Yidong <cyd@gnu.org>
617 * frame.c (delete_frame): When selecting a frame on a different
618 text terminal, do not alter the terminal's top-frame.
620 * xdisp.c (format_mode_line_unwind_data): Record the target
621 frame's selected window and its terminal's top-frame.
622 (unwind_format_mode_line): Restore them.
623 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
625 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
626 since tty frames can be explicitly named.
627 (prepare_menu_bars): Likewise.
629 * term.c (Ftty_top_frame): New function.
631 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
633 Port byte-code-meter to modern targets.
634 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
635 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
636 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
637 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
638 (METER_1, METER_2): Simplify.
640 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
642 * data.c (Fdefalias): Return `symbol' (bug#11686).
644 2012-06-18 Martin Rudalics <rudalics@gmx.at>
646 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
647 gets killed during executing of this function (Bug#11665).
648 Try to always return Qt when the buffer has been actually killed.
649 (Vkill_buffer_query_functions): In doc-string say that functions
650 run by this hook should not change the current buffer.
652 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
654 Fix recently-introduced process.c problems found by static checking.
655 * process.c (write_queue_push, write_queue_pop, send_process):
656 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
657 (write_queue_pop): Fix pointer signedness problem.
658 (send_process): Remove unused local.
660 2012-06-17 Chong Yidong <cyd@gnu.org>
662 * xdisp.c (redisplay_internal): No need to redisplay terminal
663 frames that are not on top.
665 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
667 * process.c (make_process): Initialize write_queue.
668 (write_queue_push, write_queue_pop): New functions.
669 (send_process): Use them to maintain correct ordering of process
672 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
674 * lisp.h (eassert): Assume C89 or later.
675 This removes the need for CHECK.
676 (CHECK): Remove. Its comments about always evaluating its
677 argument were confusing, as 'eassert' typically does not evaluate
680 * coding.c (produce_chars): Use ptrdiff_t, not int.
682 * xterm.c (x_draw_underwave): Check for integer overflow.
683 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
685 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
687 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
688 referenced (Bug#11583).
690 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
692 Implement wave-style variant of underlining.
693 * dispextern.h (face_underline_type): New enum.
694 (face): Add field for underline type.
695 * nsterm.m (ns_draw_underwave): New function.
696 (ns_draw_text_decoration): Use it.
697 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
699 (x_draw_glyph_string): Use them.
700 * xfaces.c (Qline, Qwave): New Lisp objects.
701 (check_lface_attrs, merge_face_ref)
702 (Finternal_set_lisp_face_attribute, realize_x_face):
703 Handle wave-style underline face attributes.
704 * xterm.c (x_draw_underwave): New function.
705 (x_draw_glyph_string): Use it.
707 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
709 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
710 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
711 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
712 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
713 ($(BLD)/w32select.$(O)): Update dependencies.
715 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
717 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
718 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
719 * character.c (_fetch_multibyte_char_p): Remove.
720 * alloc.c: Include "character.h" before "buffer.h".
722 * buffer.c: Likewise.
723 * bytecode.c: Likewise.
724 * callint.c: Likewise.
725 * callproc.c: Likewise.
726 * casefiddle.c: Likewise.
727 * casetab.c: Likewise.
728 * category.c: Likewise.
730 * coding.c: Likewise.
731 * composite.c: Likewise.
733 * dispnew.c: Likewise.
735 * dosfns.c: Likewise.
736 * editfns.c: Likewise.
738 * fileio.c: Likewise.
739 * filelock.c: Likewise.
741 * fontset.c: Likewise.
742 * fringe.c: Likewise.
743 * indent.c: Likewise.
744 * insdel.c: Likewise.
745 * intervals.c: Likewise.
746 * keyboard.c: Likewise.
747 * keymap.c: Likewise.
749 * macros.c: Likewise.
750 * marker.c: Likewise.
751 * minibuf.c: Likewise.
753 * nsmenu.m: Likewise.
755 * process.c: Likewise.
757 * region-cache.c: Likewise.
758 * search.c: Likewise.
759 * syntax.c: Likewise.
761 * textprop.c: Likewise.
763 * unexsol.c: Likewise.
764 * w16select.c: Likewise.
765 * w32fns.c: Likewise.
766 * w32menu.c: Likewise.
767 * window.c: Likewise.
772 * xselect.c: Likewise.
774 2012-06-16 Eli Zaretskii <eliz@gnu.org>
776 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
777 If all the glyphs of the glyph row came from strings, and we have no
778 cursor positioning clues, put the cursor on the first glyph of the
780 (handle_face_prop): Use chunk-relative overlay string index when
781 indexing into it->string_overlays array. (Bug#11653)
782 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
783 the rightmost. (Bug#11720)
785 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
787 * category.h (CHAR_HAS_CATEGORY): Define as inline.
788 (CATEGORY_MEMBER): Enforce 1/0 value.
789 * category.c (_temp_category_set): Remove.
791 2012-06-16 Eli Zaretskii <eliz@gnu.org>
793 * window.c (Fdelete_other_windows_internal)
794 (Fdelete_window_internal): Don't access frame's mouse highlight
795 info of the initial frame. (Bug#11677)
797 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
799 * .gdbinit (xgetint): Fix recently-introduced paren typo.
800 Assume USE_2_TAGS_FOR_INTS.
801 (xreload): Adjust $tagmask width to match recent lisp.h change.
803 Simplify lisp.h in minor ways that should not affect code.
804 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
805 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
806 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
807 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
808 (INTTYPEBITS): New macro, for clarity.
809 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
810 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
811 Simplify now that USE_LSB_TAG is always defined.
812 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
813 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
815 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
817 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
819 2012-06-13 Glenn Morris <rgm@gnu.org>
821 * s/bsd-common.h (BSD4_3):
822 * s/usg5-4-common.h (USG5_4): No longer define; unused.
824 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
826 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
829 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
831 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
832 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
833 * alloc.c (widen_to_Lisp_Object): Remove.
834 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
835 * frame.c (delete_frame): Remove outdated comment.
836 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
838 (Fw32_unregister_hot_key): Likewise.
839 (Fw32_toggle_lock_key): Likewise.
840 * w32menu.c (add_menu_item): Likewise.
841 (w32_menu_display_help): Use XIL instead of checking
843 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
844 (init_heap): Likewise.
845 * w32term.c (w32_read_socket): Update comment.
847 2012-06-13 Glenn Morris <rgm@gnu.org>
849 * s/usg5-4-common.h, src/s/unixware.h:
850 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
852 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
854 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
856 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
857 * alloc.c (make_number) [!defined make_number]:
858 Remove, as lisp.h always defines this now.
859 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
860 (roundup_size): Verify that it is a power of 2.
861 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
862 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
863 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
864 -DUSE_LSB_TAG=0, to override the automatically-selected default.
865 USE_LSB_TAG now is always defined to be either 0 or 1.
867 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
868 code works fine either way, and efficiency is not a concern here,
869 as the union type is for debugging, not for production.
870 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
871 Use an inline function on all platforms when using the union type,
872 since this is simpler and 'static inline' can be used portably
874 (LISP_INITIALLY_ZERO): New macro.
875 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
876 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
878 2012-06-12 Glenn Morris <rgm@gnu.org>
880 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
882 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
884 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
885 Move BROKEN_SIGIO to configure.
887 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
888 Move NO_TERMIO to configure.
890 2012-06-12 Chong Yidong <cyd@gnu.org>
892 * image.c (imagemagick_load_image): Use MagickFlattenImage if
893 MagickMergeImageLayers is undefined. Use pixel pusher loop if
894 MagickExportImagePixels is undefined.
896 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
898 * image.c (imagemagick_load_image): Remove unused label.
900 2012-06-11 Glenn Morris <rgm@gnu.org>
902 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
903 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
904 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
905 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
907 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
909 * alloc.c (make_byte_code): New function.
910 (Fmake_byte_code): Use it. Don't purify here.
911 * lread.c (read1): Use it as well to avoid extra allocation.
913 2012-06-11 Chong Yidong <cyd@gnu.org>
915 * image.c (imagemagick_load_image): Implement transparency.
917 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
919 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
920 account for preceding backslashes. (Bug#11663)
922 2012-06-09 Chong Yidong <cyd@gnu.org>
924 * term.c: Support italics in capable terminals (Bug#9652).
925 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
926 (turn_on_face): Output using TS_enter_italic_mode if available.
927 Don't handle unused blinking and alt-charset cases.
928 (turn_off_face): Handle italic case; discard unused tty_blinking_p
929 and tty_alt_charset_p cases.
930 (tty_capable_p, init_tty): Support italics.
932 * termchar.h (struct tty_display_info): Add field for italics.
933 Remove unused blink field.
935 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
938 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
939 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
940 tty_alt_charset_p. Add tty_italic_p.
942 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
944 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
945 dbus_type_is_basic if available.
946 (xd_extract_signed, xd_extract_unsigned): Rename from
947 extract_signed and extract_unsigned, respectively. Adapt callers.
949 2012-06-09 Chong Yidong <cyd@gnu.org>
951 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
953 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
956 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
958 * xdisp.c (vmessage): Treat frame message as multibyte.
959 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
960 would generate the diagnostic "Making \302\247 buffer-local while
963 2012-06-08 Eli Zaretskii <eliz@gnu.org>
965 * dispnew.c (showing_window_margins_p): Undo last change, which
966 was done due to an inadvertent commit.
967 (adjust_frame_glyphs_for_frame_redisplay): Do call
968 showing_window_margins_p.
970 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
972 * eval.c (Fmake_var_non_special): New primitive.
973 (syms_of_eval): Defsubr it.
974 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
976 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
978 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
979 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
981 2012-06-08 Eli Zaretskii <eliz@gnu.org>
983 * alloc.c (allocate_vectorlike): Fix last change.
985 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
987 Block-based vector allocation of small vectors.
988 * lisp.h (struct vectorlike_header): New field `nbytes',
989 adjust comment accordingly.
990 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
991 to denote vector blocks. Adjust users (live_vector_p,
992 mark_maybe_pointer, valid_lisp_object_p) accordingly.
993 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
994 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
995 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
996 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
997 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
998 (roundup_size): New constant.
999 (struct vector_block): New data type.
1000 (vector_blocks, vector_free_lists, zero_vector): New variables.
1001 (all_vectors): Rename to `large_vectors'.
1002 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1003 (sweep_vectors): New functions.
1004 (allocate_vectorlike): Return `zero_vector' as the only vector of
1005 0 items. Allocate new vector from block if vector size is less than
1006 or equal to VBLOCK_BYTES_MAX.
1007 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1008 (init_alloc_once): Add call to init_vectors.
1010 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1012 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1014 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1016 * doprnt.c (doprnt): Truncate multibyte char correctly.
1017 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1018 would mishandle a string argument "Xc" if X was a multibyte
1019 character of length 2: it would truncate after X's first byte
1020 rather than including all of X.
1022 2012-06-06 Chong Yidong <cyd@gnu.org>
1024 * buffer.c (word_wrap): Doc fix.
1026 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1028 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1030 2012-06-03 Glenn Morris <rgm@gnu.org>
1032 * xdisp.c (tool-bar-style): Doc fix.
1034 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1036 * Makefile.in (PAXCTL): Define.
1037 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1038 binary via PaX flags if the paxctl utility is available.
1039 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1040 Restore PaX flags to their default. (Bug#11398)
1042 2012-06-03 Chong Yidong <cyd@gnu.org>
1044 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1047 2012-06-03 Chong Yidong <cyd@gnu.org>
1049 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1050 (note_mode_line_or_margin_highlight): If there is no help echo,
1051 use mode-line-default-help-echo. Handle the case where the mouse
1052 position is past the end of the mode line string.
1054 * buffer.c (buffer_local_value_1): New function, split from
1055 Fbuffer_local_value; can return Qunbound.
1056 (Fbuffer_local_value): Use it.
1057 (Vmode_line_format): Docstring tweaks.
1059 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1061 * sysdep.c (system_process_attributes): Improve comment.
1063 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1065 * keyboard.c: Export real-this-command to Elisp.
1066 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1067 and DEFVAR it. Update all users.
1069 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1071 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1073 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1074 Convert pctcpu and pctmem to Lisp float properly.
1075 Let the compiler fold better, as 100.0/0x8000 is exact.
1077 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1079 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1082 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1084 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1086 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1088 For a 'struct window', replace some Lisp_Object fields to
1089 bitfields where appropriate, remove unused fields.
1090 * window.h (struct window): Remove unused 'last_mark_x' and
1091 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1092 change it's type from Lisp_Object to bitfield.
1093 Change type of 'force_start', 'optional_new_start',
1094 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1095 fields from Lisp_Object to bitfield. Adjust users accordingly.
1097 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1099 Pacify gcc -Wdouble-precision when using Xaw.
1100 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1101 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1102 Use 'float' consistently, rather than 'float' in most places
1103 and 'double' in a couple of places.
1105 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1107 * xdisp.c (handle_stop): Detect whether we have overlay strings
1108 loaded by testing it->current.overlay_string_index to be
1109 non-negative, instead of checking whether n_overlay_strings is
1110 positive. (Bug#11587)
1112 2012-05-31 Chong Yidong <cyd@gnu.org>
1114 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1116 * doc.c (Fsubstitute_command_keys): Doc fix.
1118 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1120 * search.c (search_buffer): Remove calls to
1121 r_alloc_inhibit_buffer_relocation, as it is now called by
1122 maybe_unify_char, which was the cause of relocation of buffer text
1125 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1127 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1128 for the duration of call to load_charset, to avoid problems with
1129 callers of maybe_unify_char that access buffer text through C
1132 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1133 decrement the inhibition flag, instead of just setting or
1136 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1138 Remove obsolete '#define static' cruft.
1139 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1140 This #undef was "temporary" in 2000; it is no longer needed
1141 now that '#define static' has gone away.
1142 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1143 (gray_bitmap_bits): Remove; no longer needed.
1144 All uses replaced with definiens.
1145 * xterm.c: Include "bitmaps/gray.xbm".
1147 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1149 Clean up __executable_start, monstartup when --enable-profiling.
1150 The following changes affect the code only when profiling.
1151 * dispnew.c (__executable_start): Rename from safe_bcopy.
1152 Define only on platforms that need it.
1153 * emacs.c: Include <sys/gmon.h> when profiling.
1154 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1155 (__executable_start): Remove decl, since lisp.h does it now.
1156 (safe_bcopy): Remove decl; no longer has that name.
1157 (main): Coalesce #if into single bit of code, for simplicity.
1158 Cast pointers to uintptr_t, since standard libraries want integers
1160 * lisp.h (__executable_start): New decl.
1162 2012-05-31 Glenn Morris <rgm@gnu.org>
1164 * image.c (Fimagemagick_types): Doc fix.
1166 2012-05-30 Jim Meyering <meyering@redhat.com>
1168 * callproc.c (Fcall_process_region): Include directory component
1169 in mkstemp error message (Bug#11586).
1171 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1173 * alloc.c, lisp.h (make_pure_vector): Now static.
1175 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1177 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1178 Move to byte-run.el.
1179 (Fautoload): Do the hash-doc more carefully.
1180 * data.c (Fdefalias): Purify definition, except for keymaps.
1181 (Qdefun): Move from eval.c.
1182 * lisp.h (Qdefun): Remove.
1183 * lread.c (read1): Tiny simplification.
1185 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1187 Do not create empty overlays with the evaporate property (Bug#9642).
1188 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1189 Bug#9642, but explicitly check that the buffer the overlay would
1190 be moved to is live and rearrange lines to make sure that errors
1191 will not put the overlay in an inconsistent state.
1192 (Fdelete_overlay): Cosmetics.
1194 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1196 * w32term.c (my_bring_window_to_top): New function.
1197 (x_raise_frame): Use handle returned by DeferWindowPos, which
1198 could be different from the original one.
1199 Call my_bring_window_to_top instead of my_set_foreground_window.
1202 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1203 by calling BringWindowToTop.
1205 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1206 (WM_EMACS_END): Increase by one.
1208 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1210 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1211 This avoids undefined behavior that might cause the eassert
1212 to not catch an out-of-range value.
1214 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1216 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1217 Update dependencies.
1219 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1221 * bidi.c (bidi_mirror_char): Fix last change.
1223 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1225 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1226 when referring to sectname field in printf format.
1228 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1230 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1231 Only r_alloc_inhibit_buffer_relocation needed to be added;
1232 the others were already declared.
1234 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1235 before checking whether it's out of range. Put the check inside
1237 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1239 2012-05-27 Ken Brown <kbrown@cornell.edu>
1241 * callproc.c (Fcall_process): Restore a line that was accidentally
1242 commented out in the 2011-02-13 change (bug#11547).
1244 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1246 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1247 defined on ralloc.c.
1249 * buffer.c [REL_ALLOC]: Remove prototypes of
1250 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1251 they are now on lisp.h.
1253 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1255 * search.c (search_buffer): Use it to inhibit relocation of buffer
1256 text while re_search_2 is doing its job, because re_search_2 is
1257 passed C pointers to buffer text. (Bug#11519)
1259 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1262 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1263 state after an additional call to move_it_in_display_line_to, keep
1264 the values of it->max_ascent and it->max_descent found for the
1266 (pos_visible_p): Revert the comparison against bottom_y to what it
1267 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1270 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1272 Fix coding-related core dumps with gcc -ftrapv.
1273 The code was computing A - B, where A and B are pointers, and B is
1274 random garbage. This can lead to core dumps on platforms that
1275 have special pointer registers, and it also leads to core dumps on
1276 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1277 A - B only when B is initialized properly.
1278 * coding.c (coding_set_source, coding_set_destination): Return void.
1279 (coding_change_source, coding_change_destinations): New functions,
1280 with the old behaviors of coding_set_source and coding_set_destination.
1281 All callers that need an offset changed to use these new functions.
1283 2012-05-26 Glenn Morris <rgm@gnu.org>
1285 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1287 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1289 Extend mouse support on W32 text-mode console.
1290 * xdisp.c (draw_row_with_mouse_face):
1291 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1293 * w32console.c: Include window.h.
1294 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1296 (initialize_w32_display): Initialize mouse-highlight data.
1298 * w32inevt.c: Include termchar.h and window.h.
1299 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1300 moves, call note_mouse_highlight. If help_echo changed, call
1301 gen_help_event to produce help-echo message in the echo area.
1302 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1305 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1307 * lread.c (read1): Simplify slightly to avoid an overflow warning
1308 with GCC 4.7.0 on x86-64.
1310 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1312 * bidi.c (bidi_mirror_char): Revert last change: an int is
1313 definitely wide enough here.
1315 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1317 Fix integer width and related bugs (Bug#9874).
1318 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1319 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1320 (string_bytes, check_sblock, allocate_string_data):
1321 (compact_small_strings, Fmake_bool_vector, make_string)
1322 (make_unibyte_string, make_multibyte_string)
1323 (make_string_from_bytes, make_specified_string)
1324 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1325 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1328 (allocate_pseudovector):
1329 Use int, not EMACS_INT, where int is wide enough.
1330 (inhibit_garbage_collection, Fgarbage_collect):
1331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1332 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1333 int might not be wide enough.
1334 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1335 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1336 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1337 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1338 (bidi_level_of_next_char, bidi_move_to_visually_next):
1339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1340 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1341 (Fkill_buffer, Fset_buffer_major_mode)
1342 (advance_to_char_boundary, Fbuffer_swap_text)
1343 (Fset_buffer_multibyte, overlays_at, overlays_in)
1344 (overlay_touches_p, struct sortvec, record_overlay_string)
1345 (overlay_strings, recenter_overlay_lists)
1346 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1347 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1348 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1349 (Foverlay_recenter, last_overlay_modification_hooks_used)
1350 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1352 (validate_region): Omit unnecessary test for b <= e,
1353 since that's guaranteed by the previous test.
1354 (adjust_overlays_for_delete): Avoid pos + length overflow.
1355 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1356 (report_overlay_modification):
1357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1358 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1359 Omit pointer cast, which isn't needed anyway, and doesn't work
1360 after the EMACS_INT -> ptrdiff_t change.
1361 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1362 * buffer.h: Adjust decls to match defn changes elsewhere.
1363 (struct buffer_text, struct buffer):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 Use EMACS_INT, not int, where int might not be wide enough.
1366 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1367 not int, to avoid needless 32-bit limit on 64-bit hosts.
1368 (exec_byte_code): Use tighter memory-full test, one that checks
1369 for alloca overflow. Don't compute the address of the object just
1370 before an array, as that's not portable. Use EMACS_INT, not
1371 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1372 * callint.c (Fcall_interactively):
1373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1374 * callproc.c (call_process_kill, Fcall_process):
1375 Don't assume pid_t fits into an Emacs fixnum.
1376 (call_process_cleanup, Fcall_process, child_setup):
1377 Don't assume pid_t fits into int.
1378 (call_process_cleanup, Fcall_process, delete_temp_file)
1379 (Fcall_process_region):
1380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1381 (Fcall_process): Simplify handling of volatile integers.
1382 Use int, not EMACS_INT, where int will do.
1383 * casefiddle.c (casify_object, casify_region, operate_on_word)
1384 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1386 (casify_object): Avoid integer overflow when overallocating buffer.
1387 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1388 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1389 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1390 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1391 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1392 integers are now checked earlier. All uses replaced with XINT.
1394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1395 For CCL_MapSingle, check that content and value are in int range.
1396 (ccl_driver, Fregister_code_conversion_map):
1397 Check that Vcode_version_map_vector is a vector.
1398 (resolve_symbol_ccl_program): Check that vector header is in range.
1399 Always copy the vector, so that we can check its contents reliably
1400 now rather than having to recheck each instruction as it's being
1401 executed. Check that vector words fit in 'int'.
1402 (ccl_get_compiled_code, Fregister_ccl_program)
1403 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1404 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1405 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1406 contents are in range.
1407 (Fccl_execute_on_string): Check that status is in range.
1408 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1409 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1410 Accept and return EMACS_INT, not int, because callers can pass values
1412 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1413 (multibyte_chars_in_text, parse_str_as_multibyte)
1414 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1415 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1416 (string_escape_byte8, Fget_byte):
1417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1418 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1419 avoid mishandling large integers.
1420 * character.h: Adjust decls to match defn changes elsewhere.
1421 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1422 (Ffind_charset_region):
1423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1424 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1425 (load_charset_map_from_vector, Fdefine_charset_internal):
1426 Don't assume fixnum fits in int.
1427 (load_charset_map_from_vector, Fmap_charset_chars):
1428 Remove now-unnecessary CHECK_NATNUMs.
1429 (Fdefine_charset_internal): Check ranges here, more carefully.
1430 Don't rely on undefined behavior with signed left shift overflow.
1431 Don't assume unsigned int fits into fixnum, or that fixnum fits
1432 into unsigned int. Don't require max_code to be a valid fixnum;
1433 that's not true for gb10830 4-byte on a 32-bit host. Allow
1434 invalid_code to be a cons, for the same reason. Require code_offset
1435 to be a character. Avoid int overflow if max_char is close
1437 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1438 this is intended anyway and avoids some undefined behavior.
1439 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1440 INDEX_TO_CODE_POINT, as that's what it expects.
1441 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1442 * charset.h (DECODE_CHAR): Return int, not unsigned;
1443 this is what was intended anyway, and it avoids undefined behavior.
1444 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1445 integer-overflow issues.
1446 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1447 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1448 where the argument is EMACS_INT, and this behavior is not intended.
1449 * chartab.c (Fmake_char_table, Fset_char_table_range)
1450 (uniprop_get_decoder, uniprop_get_encoder):
1451 Don't assume fixnum fits in int.
1452 * cmds.c (move_point): New function, that does the gist of
1453 Fforward_char and Fbackward_char, but does so while checking
1454 for integer overflow more accurately.
1455 (Fforward_char, Fbackward_char): Use it.
1456 (Fforward_line, Fend_of_line, internal_self_insert)
1457 (internal_self_insert):
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 Fix a FIXME, by checking for integer overflow when calculating
1460 target_clm and actual_clm.
1461 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1462 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1463 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1464 (coding_alloc_by_making_gap, alloc_destination)
1465 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1466 (encode_coding_utf_16, detect_coding_emacs_mule)
1467 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1468 (detect_coding_iso_2022, decode_coding_iso_2022)
1469 (encode_invocation_designation, encode_designation_at_bol)
1470 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1471 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1472 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1473 (encode_coding_ccl, encode_coding_raw_text)
1474 (detect_coding_charset, decode_coding_charset)
1475 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1476 (produce_composition, produce_charset, produce_annotation)
1477 (decode_coding, handle_composition_annotation)
1478 (handle_charset_annotation, consume_chars, decode_coding_gap)
1479 (decode_coding_object, encode_coding_object, detect_coding_system)
1480 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1481 (code_convert_region, code_convert_string)
1482 (Fdefine_coding_system_internal)
1483 (coding_set_source, coding_set_destination):
1484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1485 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1486 (Fdefine_coding_system_internal):
1487 Don't assume fixnums fit in int.
1488 (decode_coding_gap, decode_coding_object, encode_coding_object)
1489 (Fread_coding_system, Fdetect_coding_region)
1490 (Funencodable_char_position, Fcheck_coding_systems_region)
1491 (get_translation, handle_composition_annotation, consume_chars):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 (consume_chars): Rewrite to not calculate an address outside buffer.
1494 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1495 Don't access memory outside of the args array.
1496 (Fdefine_coding_system_internal): Check for charset-id overflow.
1497 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1498 result of ENCODE_CHAR.
1499 * coding.h: Adjust decls to match defn changes elsewhere.
1500 (struct coding_system):
1501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1502 * composite.c (get_composition_id, find_composition)
1503 (run_composition_function, update_compositions)
1504 (compose_text, composition_gstring_put_cache)
1505 (composition_gstring_p, composition_gstring_width)
1506 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1507 (composition_compute_stop_pos, composition_reseat_it)
1508 (composition_update_it, struct position_record)
1509 (find_automatic_composition, composition_adjust_point)
1510 (Fcomposition_get_gstring, Ffind_composition_internal):
1511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1512 (update_compositions):
1513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1514 * composite.h: Adjust decls to match defn changes elsewhere.
1515 (struct composition):
1516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1517 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1518 Do not attempt to compute the address of the object just before a
1519 buffer; this is not portable.
1521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1522 (Faset): Use int, not EMACS_INT, where int is wide enough.
1523 (Fstring_to_number): Don't assume fixnums fit in int.
1524 (Frem): Don't assume arg is nonnegative.
1525 * dbusbind.c (xd_append_arg): Check for integers out of range.
1526 (Fdbus_call_method): Don't overflow the timeout int.
1527 (extract_signed, extract_unsigned): New functions.
1528 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1529 (xd_get_connection_references): Return ptrdiff_t, not int.
1531 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1532 (xd_read_message_1):
1533 Use int, not unsigned, where the dbus API uses int.
1534 (Fdbus_message_internal): Don't overflow mtype.
1535 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1536 * dired.c (directory_files_internal, file_name_completion, scmp)
1537 (file_name_completion_stat):
1538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1539 (file_name_completion): Don't overflow matchcount.
1540 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1541 * dispextern.h: Adjust decls to match defn changes elsewhere.
1542 (struct text_pos, struct glyph, struct bidi_saved_info)
1543 (struct bidi_string_data, struct bidi_it, struct composition_it)
1545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1546 (struct display_pos, struct composition_it, struct it):
1547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1548 * dispnew.c (increment_matrix_positions)
1549 (increment_row_positions, mode_line_string)
1550 (marginal_area_string):
1551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1552 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 (duration_to_sec_usec): New function, to check for overflow better.
1555 (Fsleep_for, sit_for): Use it.
1556 * doc.c (get_doc_string, store_function_docstring):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 (get_doc_string, Fsnarf_documentation):
1559 Use int, not EMACS_INT, where int is wide enough.
1561 Use SAFE_ALLOCA, not alloca.
1562 Check for overflow when converting EMACS_INT to off_t.
1563 * doprnt.c (doprnt):
1564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1565 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1566 Don't assume uid_t fits into fixnum.
1567 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1568 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1569 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1570 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1571 (general_insert_function)
1572 (Finsert_char, make_buffer_string, make_buffer_string_both)
1573 (update_buffer_properties, Fbuffer_substring)
1574 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1575 (Fsubst_char_in_region, check_translation)
1576 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1577 (transpose_markers, Ftranspose_regions):
1578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1579 (clip_to_bounds): Move to lisp.h as an inline function).
1580 (Fconstrain_to_field): Don't assume integers are nonnegative.
1581 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1582 (Fsubst_char_in_region, Fsave_restriction):
1583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1584 (Femacs_pid): Don't assume pid_t fits into fixnum.
1585 (lo_time): Use int, not EMACS_INT, when int suffices.
1586 (lisp_time_argument): Check for usec out of range.
1587 (Fencode_time): Don't assume fixnum fits in int.
1588 (Fuser_login_name, Fuser_full_name): Signal an error
1589 if a uid argument is out of range, rather than relying on
1591 (Fformat_time_string): Remove now-unnecessary check.
1592 lisp_time_argument checks for out-of-range usec now.
1593 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1594 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1595 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1596 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1597 (init_cmdargs, Fdump_emacs):
1598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1599 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1600 the bottom (typically) 32 bits of the fixnum.
1601 * eval.c (specpdl_size, call_debugger):
1602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1603 (when_entered_debugger, Fbacktrace_debug):
1604 Don't assume fixnum can fit in int.
1605 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1606 the object just before a buffer; this is not portable.
1607 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1608 (grow_specpdl, unbind_to):
1609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1610 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1611 (grow_specpdl): Simplify allocation by using xpalloc.
1612 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1613 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1614 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1616 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1619 (Fcopy_file, non_regular_nbytes, read_non_regular)
1620 (Finsert_file_contents):
1621 Use int, not EMACS_INT, where int is wide enough.
1622 (READ_BUF_SIZE): Verify that it fits in int.
1623 (Finsert_file_contents): Check that counts are in proper range,
1624 rather than assuming fixnums fit into ptrdiff_t etc.
1625 Don't assume fixnums fit into int.
1626 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1627 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1628 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1629 (string_char_to_byte, string_byte_to_char)
1630 (string_make_multibyte, string_to_multibyte)
1631 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1632 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1633 (substring_both, Fdelete, internal_equal, Ffillarray)
1634 (Fclear_string, mapcar1)
1635 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1636 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1637 (larger_vector, make_hash_table, maybe_resize_hash_table)
1638 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1639 (Fmaphash, secure_hash):
1640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1641 (concat): Check for string index and length overflow.
1642 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1645 (larger_vector): New API (vec, incr_min, size_max) replaces old
1646 one (vec, new_size, init). This catches size overflow.
1647 INIT was removed because it was always Qnil.
1648 All callers changed.
1649 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1650 the upper bound on a hash table index size.
1651 (make_hash_table, maybe_resize_hash_table): Use it.
1652 (secure_hash): Computer start_byte and end_byte only after
1653 they're known to be in ptrdiff_t range.
1654 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1655 (Ffont_get_glyphs, Ffont_at):
1656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1657 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1658 (Flist_fonts, Fopen_font):
1659 Don't assume fixnum can fit in int.
1660 (check_gstring): Don't assume index can fit in int.
1661 (font_match_p): Check that fixnum is a character, not a nonnegative
1662 fixnum, since the later code needs to stuff it into an int.
1663 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1664 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1665 conversion overflow issues.
1666 (Fopen_font): Check for integer out of range.
1667 (Ffont_get_glyphs): Don't assume index can fit in int.
1668 * font.h: Adjust decls to match defn changes elsewhere.
1669 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1671 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1672 printmax_t, where ptrdiff_t is wide enough.
1673 (Finternal_char_font):
1674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1675 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1676 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1677 (Fset_frame_position, x_set_frame_parameters)
1678 (x_set_line_spacing, x_set_border_width)
1679 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1680 Check that fixnums are in proper range for system types.
1681 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1683 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1684 Use SAFE_ALLOCA_LISP, not alloca.
1685 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1686 intptr_t is wide enough.
1687 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1688 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1689 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1690 Check for fixnum out of range.
1691 * ftfont.c (ftfont_list): Don't assume index fits in int.
1692 Check that fixnums are in proper range for system types.
1693 (ftfont_shape_by_flt):
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1695 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1697 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1698 Check that fixnums are in proper range for system types.
1699 * gnutls.h: Adjust decls to match defn changes elsewhere.
1700 * gtkutil.c (xg_dialog_run):
1701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1702 (update_frame_tool_bar):
1703 Check that fixnums are in proper range for system types.
1704 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1705 (lookup_image): Check that fixnums are in range for system types.
1706 * indent.c (last_known_column, last_known_column_point):
1707 (current_column_bol_cache):
1708 (skip_invisible, current_column, check_display_width):
1709 (check_display_width, scan_for_column, current_column_1)
1710 (Findent_to, Fcurrent_indentation, position_indentation)
1711 (indented_beyond_p, Fmove_to_column, compute_motion):
1712 (Fcompute_motion, Fvertical_motion):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1714 (last_known_column_modified): Use EMACS_INT, not int.
1715 (check_display_width):
1717 Check that fixnums and floats are in proper range for system types.
1718 (compute_motion): Don't assume index or fixnum fits in int.
1719 (compute_motion, Fcompute_motion):
1720 Use int, not EMACS_INT, when it is wide enough.
1721 (vmotion): Omit local var start_hpos that is always 0; that way
1722 we don't need to worry about overflow in expressions involving it.
1723 * indent.h: Adjust decls to match defn changes elsewhere.
1725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1726 Use int, not EMACS_INT, where int is wide enough.
1727 Remove unused members ovstring_chars_done and tab_offset;
1729 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1730 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1731 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1732 (make_gap, copy_text, insert, insert_and_inherit)
1733 (insert_before_markers, insert_before_markers_and_inherit)
1734 (insert_1, count_combining_before, count_combining_after)
1735 (insert_1_both, insert_from_string)
1736 (insert_from_string_before_markers, insert_from_string_1)
1737 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1738 (adjust_after_replace, adjust_after_insert, replace_range)
1739 (replace_range_2, del_range, del_range_1, del_range_byte)
1740 (del_range_both, del_range_2, modify_region)
1741 (prepare_to_modify_buffer, signal_before_change)
1742 (signal_after_change, Fcombine_after_change_execute):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1745 (balance_an_interval, split_interval_right, split_interval_left)
1746 (find_interval, next_interval, update_interval)
1747 (adjust_intervals_for_insertion, delete_node, delete_interval)
1748 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1749 (static_offset_intervals, offset_intervals)
1750 (merge_interval_right, merge_interval_left, make_new_interval)
1751 (graft_intervals_into_buffer, temp_set_point_both)
1752 (temp_set_point, set_point, adjust_for_invis_intang)
1753 (set_point_both, move_if_not_intangible, get_property_and_range)
1754 (get_local_map, copy_intervals, copy_intervals_to_string)
1755 (compare_string_intervals, set_intervals_multibyte_1):
1756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1757 * intervals.h: Adjust decls to match defn changes elsewhere.
1759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1760 * keyboard.c (this_command_key_count, this_single_command_key_start)
1761 (before_command_key_count, before_command_echo_length, echo_now)
1762 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1763 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1764 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1765 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1767 (last_non_minibuf_size, last_point_position, echo_truncate)
1768 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1769 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1770 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1771 (stuff_buffered_input):
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1773 (last_auto_save, command_loop_1, read_char):
1774 Use EMACS_INT, not int, to avoid integer overflow.
1775 (record_char): Avoid overflow in total_keys computation.
1776 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1777 * keyboard.h: Adjust decls to match defn changes elsewhere.
1778 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1779 (Fkey_description, Fdescribe_vector, Flookup_key):
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 (click_position): New function, to check that positions are in range.
1782 (Fcurrent_active_maps):
1784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1785 (Faccessible_keymaps, Fkey_description):
1786 (preferred_sequence_p):
1787 Don't assume fixnum can fit into int.
1788 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1789 Check for integer overflow in size calculations.
1790 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1791 avoid mishandling large integers.
1792 * lisp.h: Adjust decls to match defn changes elsewhere.
1793 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1794 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1795 (struct Lisp_Marker):
1796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1797 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1798 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1799 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1800 All callers changed.
1801 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1802 Assume the arg has valid form, since it always does.
1803 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1804 unsigned integer system type.
1805 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1806 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1808 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1809 (duration_to_sec_usec): New decl.
1810 * lread.c (read_from_string_index, read_from_string_index_byte)
1811 (read_from_string_limit, readchar, unreadchar, openp)
1812 (read_internal_start, read1, oblookup):
1813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1814 (Fload, readevalloop, Feval_buffer, Feval_region):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 (openp): Check for out-of-range argument to 'access'.
1817 (read1): Use int, not EMACS_INT, where int is wide enough.
1818 Don't assume fixnum fits into int.
1819 Fix off-by-one error that can read outside a buffer.
1820 (read_filtered_event): Use duration_to_sec_usec
1821 to do proper overflow checking on durations.
1822 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1823 in size calculation.
1824 (Fexecute_kbd_macro):
1825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1826 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1827 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1828 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1829 (set_marker_both, set_marker_restricted_both, marker_position)
1830 (marker_byte_position, Fbuffer_has_markers_at):
1831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1832 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1833 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1834 It now merely ensures that the menu is large enough, without
1835 necessarily growing it, as this avoids some integer overflow issues.
1836 All callers changed.
1837 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1839 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1840 Use SAFE_ALLOCA_LISP, not alloca.
1841 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1842 to EMACS_INT. Check that fixnums are in proper range for system types.
1843 * minibuf.c (minibuf_prompt_width, string_to_object)
1844 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1845 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1847 (get_minibuffer, read_minibuf_unwind):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1850 this simplifies overflow checking. All callers changed.
1851 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1854 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1855 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1856 Check that fixnums are in proper range for system types.
1857 (Fx_create_frame, Fx_show_tip):
1858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1859 * nsfont.m (ns_findfonts, nsfont_list_family):
1860 Don't assume fixnum fits in long.
1861 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1863 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1865 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1868 (PRINTDECLARE, PRINTPREPARE):
1869 (strout, print_string):
1870 (print, print_preprocess, print_check_string_charset_prop)
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1874 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1877 (printchar, strout): Use xpalloc to catch size calculation overflow.
1878 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1879 (print_error_message): Use SAFE_ALLOCA, not alloca.
1880 (print_object): Use int, not EMACS_INT, where int is wide enough.
1881 (print_depth, new_backquote_output, print_number_index):
1882 Use ptrdiff_t, not int, where int might not be wide enough.
1883 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1884 (Fset_process_window_size, Fformat_network_address)
1885 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1887 Check that fixnums are in proper range for system types.
1888 (Fsignal_process): Simplify by avoiding a goto.
1889 Check for process-ids out of pid_t range rather than relying on
1891 (process_tick, update_tick): Use EMACS_INT, not int.
1892 (Fformat_network_address, read_process_output, send_process)
1893 (Fprocess_send_region, status_notify):
1894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1895 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1896 (wait_reading_process_output, read_process_output, exec_sentinel):
1897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1898 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1899 (Faccept_process_output): Use duration_to_sec_usec to do proper
1900 overflow checking on durations.
1901 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1902 Don't assume pid_t fits in int.
1903 * process.h (struct Lisp_Process): Members tick and update_tick
1904 are now of type EMACS_INT, not int.
1905 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1906 configured --with-wide-int.
1907 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1908 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1909 * search.c (looking_at_1, string_match_1):
1910 (fast_string_match, fast_c_string_match_ignore_case)
1911 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1912 (scan_newline, find_before_next_newline, search_command)
1913 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1914 (set_search_regs, wordify):
1917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1918 (string_match_1, search_buffer, set_search_regs):
1920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1921 (wordify): Check for overflow in size calculation.
1922 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1923 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1924 Check that fixnums are in proper range for system types.
1925 * sound.c (struct sound_device)
1926 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (Fplay_sound_internal):
1929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1930 * syntax.c (struct lisp_parse_state, find_start_modiff)
1931 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1932 (Fparse_partial_sexp):
1933 Don't assume fixnums can fit in int.
1934 (struct lisp_parse_state, find_start_pos, find_start_value)
1935 (find_start_value_byte, find_start_begv)
1936 (update_syntax_table, char_quoted, dec_bytepos)
1937 (find_defun_start, prev_char_comend_first, back_comment):
1938 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1939 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1941 (Finternal_describe_syntax_value): Check that match_lisp is a
1942 character, not an integer, since the code stuffs it into int.
1943 (scan_words, scan_sexps_forward):
1944 Check that fixnums are in proper range for system types.
1946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1947 (scan_sexps_forward):
1948 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1949 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1950 * syntax.h: Adjust decls to match defn changes elsewhere.
1951 (struct gl_state_s):
1952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1953 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1954 MOST_POSITIVE_FIXNUM.
1955 * sysdep.c (wait_for_termination_1, wait_for_termination)
1956 (interruptible_wait_for_termination, mkdir):
1957 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1958 (emacs_read, emacs_write):
1959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1960 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1961 and double all fit in int.
1962 * term.c (set_tty_color_mode):
1963 Check that fixnums are in proper range for system types.
1964 * termhooks.h (struct input_event):
1965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1966 * textprop.c (validate_interval_range, interval_of)
1967 (Fadd_text_properties, set_text_properties_1)
1968 (Fremove_text_properties, Fremove_list_of_text_properties)
1969 (Ftext_property_any, Ftext_property_not_all)
1970 (copy_text_properties, text_property_list, extend_property_ranges)
1971 (verify_interval_modification):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (Fnext_single_char_property_change)
1974 (Fprevious_single_char_property_change):
1975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1976 (copy_text_properties):
1977 Check for integer overflow in index calculation.
1978 * undo.c (last_boundary_position, record_point, record_insert)
1979 (record_delete, record_marker_adjustment, record_change)
1980 (record_property_change):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1984 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1985 (Fx_hide_tip, Fx_file_dialog):
1986 * w32menu.c (set_frame_menubar):
1987 Use ptrdiff_t, not int, for consistency with rest of code.
1988 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1989 (select_window, Fdelete_other_windows_internal)
1990 (window_scroll_pixel_based, window_scroll_line_based)
1991 (Frecenter, Fset_window_configuration):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (Fset_window_hscroll, run_window_configuration_change_hook)
1994 (set_window_buffer, temp_output_buffer_show, scroll_command)
1995 (Fscroll_other_window, Frecenter):
1996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1997 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1998 Don't assume fixnum fits in int.
1999 (Fset_window_scroll_bars):
2000 Check that fixnums are in proper range for system types.
2001 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2002 (string_pos, c_string_pos, number_of_chars, init_iterator)
2003 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2004 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2005 (compute_display_string_end, handle_face_prop)
2006 (face_before_or_after_it_pos, handle_invisible_prop)
2007 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2008 (display_prop_intangible_p, string_buffer_position_lim)
2009 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2010 (get_overlay_strings_1, get_overlay_strings)
2011 (iterate_out_of_display_property, forward_to_next_line_start)
2012 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2013 (get_next_display_element, set_iterator_to_next)
2014 (get_visually_first_element, compute_stop_pos_backwards)
2015 (handle_stop_backwards, next_element_from_buffer)
2016 (move_it_in_display_line_to, move_it_in_display_line)
2017 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2018 (add_to_log, message_dolog, message_log_check_duplicate)
2019 (message2, message2_nolog, message3, message3_nolog
2020 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2021 (current_message_1, truncate_echo_area, truncate_message_1)
2022 (set_message, set_message_1, store_mode_line_noprop)
2023 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2024 (text_outside_line_unchanged_p, check_point_in_composition)
2025 (reconsider_clip_changes)
2026 (redisplay_internal, set_cursor_from_row, try_scrolling)
2027 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2028 (redisplay_window, find_last_unchanged_at_beg_row)
2029 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2030 (trailing_whitespace_p, find_row_edges, display_line)
2031 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2032 (display_mode_element, store_mode_line_string)
2033 (pint2str, pint2hrstr, decode_mode_spec)
2034 (display_count_lines, display_string, draw_glyphs)
2035 (x_produce_glyphs, x_insert_glyphs)
2036 (rows_from_pos_range, mouse_face_from_buffer_pos)
2037 (fast_find_string_pos, mouse_face_from_string_pos)
2038 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2040 (safe_call, init_from_display_pos, handle_fontified_prop)
2041 (handle_single_display_spec, load_overlay_strings)
2042 (with_echo_area_buffer, setup_echo_area_for_printing)
2043 (display_echo_area, echo_area_display)
2044 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2045 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2046 (redisplay_window, dump_glyph_row, display_mode_line)
2047 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2048 (handle_display_spec, display_prop_string_p):
2049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2050 (handle_single_display_spec, build_desired_tool_bar_string)
2051 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2052 (get_specified_cursor_type):
2053 Check that fixnums are in proper range for system types.
2054 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2055 (Flookup_image_map):
2056 Don't assume fixnums fit in int.
2057 (compare_overlay_entries):
2058 Avoid mishandling comparisons due to subtraction overflow.
2059 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2060 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2061 (handle_tool_bar_click):
2062 Use int, not unsigned, since we prefer signed and the signedness
2063 doesn't matter here.
2064 (get_next_display_element, next_element_from_display_vector):
2065 Use int, not EMACS_INT, when int is wide enough.
2066 (start_hourglass): Use duration_to_sec_usec to do proper
2067 overflow checking on durations.
2068 * xfaces.c (Fbitmap_spec_p):
2069 Check that fixnums are in proper range for system types.
2070 (compare_fonts_by_sort_order):
2071 Avoid mishandling comparisons due to subtraction overflow.
2072 (Fx_family_fonts, realize_basic_faces):
2073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2075 Don't assume fixnum fits in int.
2076 Use SAFE_ALLOCA_LISP, not alloca.
2077 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2078 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2079 (face_at_buffer_position, face_for_overlay_string)
2080 (face_at_string_position):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2082 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2083 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2085 Check that fixnums are in proper range for system types.
2086 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2087 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2089 (Fx_change_window_property): Don't assume fixnums fit in int.
2090 * xfont.c (xfont_chars_supported):
2091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2092 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2093 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2095 * xml.c (parse_region):
2096 * xrdb.c (magic_file_p):
2097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2098 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2099 (x_get_local_selection, x_reply_selection_request)
2100 (x_handle_selection_request, wait_for_property_change):
2101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2102 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2103 short is wide enough.
2104 (x_send_client_event): Don't assume fixnum fits in int.
2105 * xterm.c (x_x_to_emacs_modifiers):
2106 Don't assume EMACS_INT overflows nicely into int.
2107 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2109 (handle_one_xevent): NATNUMP can eval its arg twice.
2110 (x_connection_closed):
2111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2112 * xterm.h: Adjust decls to match defn changes elsewhere.
2113 (struct scroll_bar): Use struct vectorlike_header
2114 rather than rolling our own approximation.
2115 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2117 2012-05-25 Glenn Morris <rgm@gnu.org>
2119 * lisp.mk (lisp): Update for more files being compiled now.
2121 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2123 * lread.c: Remove `read_pure' which makes no difference.
2124 (read_pure): Remove var.
2125 (unreadpure): Remove function.
2126 (readevalloop): Don't call read_list with -1 flag.
2127 (read1, read_vector): Don't test read_pure any more.
2128 (read_list): Simplify.
2130 * fileio.c, character.h: Minor style tweaks.
2132 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2134 * window.h (clip_changed): Remove useless declaration.
2136 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2138 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2139 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2141 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2144 This directory predates autoconf and is no longer needed nowadays.
2145 Move its few remaining bits of functionality to where they're needed.
2146 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2147 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2148 * m/template.h: Remove.
2149 * Makefile.in (M_FILE): Remove. All uses removed.
2150 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2151 * lisp.h (USE_LSB_TAG):
2152 * mem-limits.h (EXCEEDS_LISP_PTR):
2153 Use VAL_MAX, not VALBITS, in #if.
2154 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2155 (EMACS_UINT): Define unconditionally now.
2156 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2157 (BITS_PER_EMACS_INT): New constants, replacing
2158 what used to be in config.h, but not useful in #if.
2159 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2160 define them any more.
2161 (VAL_MAX): New macro.
2163 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2164 BITS_PER_EMACS_INT, in #if.
2165 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2166 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2167 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2168 * s/ms-w32.h (DATA_START):
2169 Move here from removed file m/intel386.h.
2170 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2171 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2173 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2175 Assume C89 or later.
2176 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2177 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2179 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2180 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2181 * textprop.c, tparam.c (NULL): Remove.
2182 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2183 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2184 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2185 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2186 * xterm.c (input_signal_count): Assume volatile works.
2188 2012-05-21 Ken Brown <kbrown@cornell.edu>
2190 * xgselect.c (xg_select): Fix first argument in call to 'select'
2193 2012-05-20 Ken Brown <kbrown@cornell.edu>
2195 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2196 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2198 2012-05-19 Ken Brown <kbrown@cornell.edu>
2200 * xfns.c (x_in_use): Remove `static' qualifier.
2201 * xterm.h (x_in_use): Declare.
2202 * xgselect.c: Include xterm.h.
2203 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2204 and `display_arg' (bug#9754).
2206 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2208 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2210 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2211 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2213 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2215 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2217 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2218 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2220 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2221 reference to image_cache->refcount.
2222 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2224 2012-05-17 Juri Linkov <juri@jurta.org>
2226 * search.c (Fword_search_regexp, Fword_search_backward)
2227 (Fword_search_forward, Fword_search_backward_lax)
2228 (Fword_search_forward_lax): Move functions to isearch.el
2229 (bug#10145, bug#11381).
2231 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2233 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2235 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2237 * lread.c (init_obarray): Declare Qt and Qnil as special.
2239 2012-05-14 Glenn Morris <rgm@gnu.org>
2241 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2242 Put "libexec" before "bin", for the sake of init_callproc_1.
2244 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2246 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2248 * unexaix.c: Port to more-recent AIX compilers.
2249 (report_error, report_error_1, make_hdr, copy_sym)
2250 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2251 Make arguments const char *, not char *, to avoid violations of C
2252 standard and to fix some AIX warnings reported by Gilles Pion.
2254 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2256 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2257 already have overlays loaded.
2258 (handle_single_display_spec): Before returning without displaying
2259 fringe bitmap, synchronize the bidi iterator with the main display
2260 iterator, by calling iterate_out_of_display_property.
2261 (iterate_out_of_display_property): Detect buffer iteration by
2262 testing that it->string is a Lisp string.
2263 (get_next_display_element): When the current object is exhausted,
2264 and there's something on it->stack, call set_iterator_to_next to
2265 proceed with what's on the stack, instead of returning zero.
2266 (set_iterator_to_next): If called at the end of a Lisp string,
2267 proceed to consider_string_end without incrementing string
2268 position. Don't increment display vector index past the end of
2269 the display vector. (Bug#11417)
2270 (pos_visible_p): Don't report a position visible when move_it_to
2271 stopped at the last line of window, which happens to be scanned
2272 backwards by the bidi iteration. (Bug#11464)
2274 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2276 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2277 and right-margin display specs even if the spec is invalid or we
2278 are on a TTY, and thus unable to display on the fringes.
2279 That's because the text with the property will not be displayed anyway,
2280 so we need to signal to the caller that this is a "replacing"
2281 display spec. This fixes display when the spec is invalid or we
2284 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2286 * unexaix.c (make_hdr): Fix typo in prototype.
2287 This bug broke the build on AIX. Problem reported by Gilles Pion.
2289 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2291 * keyboard.c (kbd_buffer_get_event): Read special events also in
2292 batch mode. (Bug#11415)
2294 2012-05-12 Glenn Morris <rgm@gnu.org>
2296 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2298 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2300 * lisp.mk (lisp): Add newcomment.elc.
2302 2012-05-12 Glenn Morris <rgm@gnu.org>
2304 * Makefile.in (MKDIR_P): New, set by configure.
2305 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2307 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2309 Remove unused function hourglass_started.
2310 * dispextern.h (hourglass_started):
2311 * w32fns.c (hourglass_started):
2312 * xdisp.c (hourglass_started): Remove.
2314 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2316 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2317 Update dependencies.
2319 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2321 * xgselect.c (xg_select): Put maxfds+1 into a var.
2322 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2324 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2326 2012-05-10 Dave Abrahams <dave@boostpro.com>
2328 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2329 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2331 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2333 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2334 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2335 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2336 Initialize xd_registered_buses.
2338 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2340 Untag more efficiently if USE_LSB_TAG.
2341 This is based on a proposal by YAMAMOTO Mitsuharu in
2342 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2343 For an admittedly artificial (nth 8000 longlist) benchmark on
2344 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2345 Emacs's overall text size by 1%.
2346 * lisp.h (XUNTAG): New macro.
2347 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2348 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2349 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2350 * eval.c (Fautoload):
2351 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2352 * frame.h (XFRAME): Use XUNTAG.
2354 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2355 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2356 Remove unportable assumptions about print widths of types like
2358 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2359 intptr_t when converting between pointer and integer, to avoid GCC
2360 warnings about wrong width.
2362 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2364 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2365 stack for each reader_thread, instead of defaulting to 8MB
2366 determined by the linker. This avoids failures in creating
2367 subprocesses on Windows 7, see the discussion in this thread:
2368 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2370 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2372 Fix up display of the *Minibuf-0* buffer in the mini window.
2373 * keyboard.c (read_char): Don't clear the echo area if there's no
2375 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2376 contents of *Minibuf-0*) if there's no message displayed in its stead.
2378 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2380 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2383 2012-05-06 Chong Yidong <cyd@gnu.org>
2385 * lisp.mk (lisp): Update.
2387 2012-05-05 Jim Meyering <meyering@redhat.com>
2389 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2391 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2393 * data.c (PUT_ERROR): New macro.
2394 (syms_of_data): Use it. Add new error type `user-error'.
2395 * undo.c (user_error): New function.
2396 (Fprimitive_undo): Use it.
2397 * print.c (print_error_message): Adjust print style for `user-error'.
2398 * keyboard.c (user_error): New function.
2399 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2401 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2403 Do not limit current-time-string to years 1000..9999.
2404 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2405 (Fcurrent_time_string): Support any year that is supported by the
2406 underlying localtime representation. Don't use asctime, as it
2407 has undefined behavior for years outside the range -999..9999.
2409 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2411 Fix race conditions involving setenv, gmtime, localtime, asctime.
2412 Without this fix, interrupts could mess up code that uses these
2413 nonreentrant functions, since setting TZ invalidates existing
2414 tm_zone or tzname values, and since most of these functions return
2415 pointers to static storage.
2416 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2417 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2418 Grow the critical sections to include not just invoking
2419 localtime/gmtime, but also accessing these functions' results
2420 including their tm_zone values if any, and any related TZ setting.
2421 (format_time_string): Last arg is now struct tm *, not struct tm **,
2422 so that the struct tm is saved in the critical section.
2423 All callers changed. Simplify allocation of initial buffer, partly
2424 motivated by the fact that memory allocation needs to be outside
2425 the critical section.
2427 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2429 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2430 with RESET_INTERVAL.
2432 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2433 Remove duplicated buffer name initialization.
2435 2012-05-02 Jim Meyering <jim@meyering.net>
2437 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2439 * xfns.c (x_window): Use xstrdup (Bug#11375).
2441 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2443 * xdisp.c (pos_visible_p): If already at a newline from the
2444 display string before the 'while' loop, don't walk back the glyphs
2445 from it3.glyph_row. Solves assertion violation when the display
2446 string begins with a newline (egg.el). (Bug#11367)
2448 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2450 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2453 2012-05-01 Glenn Morris <rgm@gnu.org>
2455 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2456 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2457 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2458 All were removed before 23.1.
2460 * dispnew.c: Remove HAVE_LIBNCURSES test;
2461 it is always true on relevant platforms.
2463 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2464 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2466 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2468 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2470 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2471 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2474 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2476 Do not avoid creating empty evaporating overlays (Bug#9642).
2477 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2478 That is, do not delete an evaporating overlay if it becomes
2479 empty after its bounds are adjusted to fit within its buffer.
2480 This fix caused other problems, and I'm reverting it until we get
2481 to the bottom of them.
2483 2012-04-27 Chong Yidong <cyd@gnu.org>
2485 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2487 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2489 * xdisp.c (pos_visible_p): If the window start position is beyond
2490 ZV, start the display from buffer beginning. Prevents assertion
2491 violation in init_iterator when the minibuffer window is scrolled
2494 * window.c (window_scroll_pixel_based): Likewise.
2496 2012-04-27 Chong Yidong <cyd@gnu.org>
2498 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2500 2012-04-27 Glenn Morris <rgm@gnu.org>
2502 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2503 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2505 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2507 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2508 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2510 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2512 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2513 display element, check also the underlying string or buffer
2514 character. (Bug#11341)
2516 * w32menu.c: Include w32heap.h.
2517 (add_menu_item): If the call to AppendMenuW (via
2518 unicode_append_menu) fails, disable Unicode menus only if we are
2519 running on Windows 9X/Me.
2521 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2523 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2524 (xgetint): Add missing shift for LSB tags.
2526 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2528 * keyboard.c (read_char): Don't wipe echo area for select window
2529 events: These might get delayed via `mouse-autoselect-window'
2532 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2534 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2535 manipulation of :loaded-from data.
2537 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2539 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2540 now a cons (bug#11311).
2542 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2544 Do not create empty overlays with the evaporate property (Bug#9642).
2545 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2546 if it becomes empty after its bounds are adjusted to fit within
2547 its buffer. Without this fix, in a nonempty buffer (let ((o
2548 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2549 yields an empty overlay that has the evaporate property, which is
2550 not supposed to happen.
2552 Fix minor GTK3 problems found by static checking.
2553 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2554 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2555 (struct _EmacsFixedClass, emacs_fixed_get_type):
2556 Move decls here from emacsgtkfixed.h, since they needn't be public.
2557 (emacs_fixed_get_type): Now static.
2558 (emacs_fixed_class_init): Omit unused local.
2559 (emacs_fixed_child_type): Remove; unused.
2560 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2561 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2562 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2563 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2564 (EMACS_FIXED_GET_CLASS): Remove; unused.
2565 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2567 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2568 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2570 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2572 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2573 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2574 (__malloc_size_t, __malloc_ptrdiff_t):
2575 Remove. All uses removed, replaced by the definiens if needed,
2576 since we can assume C89 or better now.
2577 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2578 (protect_malloc_state, align, get_contiguous_space)
2579 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2580 (malloc_atfork_handler_child, malloc_enable_thread)
2581 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2582 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2583 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2584 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2585 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2586 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2587 Define using prototypes, not old style.
2588 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2589 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2590 (align): Don't assume that signed integer overflow wraps around.
2591 Omit unused local var.
2592 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2593 (_free_internal_nolock, memalign, mallochook, reallochook):
2594 Omit no-longer-needed casts.
2595 (valloc): Use getpagesize, not __getpagesize.
2596 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2597 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2599 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2601 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2603 Move functions from C to Lisp. Make non-blocking method calls
2604 the default. Implement further D-Bus standard interfaces.
2606 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2607 (QCdbus_request_name_allow_replacement)
2608 (QCdbus_request_name_replace_existing)
2609 (QCdbus_request_name_do_not_queue)
2610 (QCdbus_request_name_reply_primary_owner)
2611 (QCdbus_request_name_reply_in_queue)
2612 (QCdbus_request_name_reply_exists)
2613 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2614 (QCdbus_registered_serial, QCdbus_registered_method)
2615 (QCdbus_registered_signal): New Lisp objects.
2616 (XD_DEBUG_MESSAGE): Use sizeof.
2617 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2618 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2619 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2620 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2621 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2622 (xd_signature, xd_append_arg): Allow float for integer types.
2623 (xd_get_connection_references): New function.
2624 (xd_get_connection_address): Rename from xd_initialize.
2625 Return cached address.
2626 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2627 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2629 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2630 Return number of refcounts.
2631 (Fdbus_get_unique_name): Make stronger parameter check.
2632 (Fdbus_message_internal): New defun.
2633 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2634 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2635 (Fdbus_send_signal, Fdbus_register_service)
2636 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2637 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2638 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2639 (Vdbus_compiled_version, Vdbus_runtime_version)
2640 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2641 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2642 (Vdbus_message_type_signal): New defvars.
2643 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2646 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2648 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2649 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2650 Do not assume ptrdiff_t is the same width as 'int'.
2652 * alloc.c: Handle unusual debugging option combinations.
2653 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2654 since the two debugging options are incompatible.
2655 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2657 (mem_init, mem_insert, mem_insert_fixup):
2658 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2659 (NEED_MEM_INSERT): Remove; no longer needed.
2661 2012-04-22 Leo Liu <sdl.web@gmail.com>
2663 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2665 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2667 * sysdep.c [__FreeBSD__]: Minor cleanups.
2668 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2669 Use Emacs indenting style more consistently. Avoid some casts.
2670 Use 'double' consistently rather than mixing 'float' and 'double'.
2672 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2674 * sysdep.c (list_system_processes, system_process_attributes):
2675 Add implementation for FreeBSD (Bug#5243).
2677 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2679 * lisp.mk (lisp): Update.
2681 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2683 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2684 It is never used otherwise.
2686 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2688 * print.c (print_preprocess): Only check print_depth if print-circle
2690 (print_object): Check for cycles even when print-circle is nil and
2691 print-gensym is t, but only check print_depth if print-circle is nil.
2693 2012-04-20 Chong Yidong <cyd@gnu.org>
2695 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2696 set the status to "failed" and ensure that sentinel is run.
2698 2012-04-20 Glenn Morris <rgm@gnu.org>
2700 * process.c (Fset_process_inherit_coding_system_flag)
2701 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2702 (Fmake_network_process, Fmake_serial_process): Doc fix.
2704 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2706 * xdisp.c (string_buffer_position_lim): Limit starting position to
2708 (set_cursor_from_row): If called for a mode-line or header-line
2709 row, return zero immediately.
2710 (try_cursor_movement): If inside continuation line, don't back up
2711 farther than the first row after the header line, if any.
2712 Don't consider the header-line row as "partially visible", even if
2713 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2715 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2717 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2720 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2721 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2723 configure: new option --enable-gcc-warnings (Bug#11207)
2724 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2725 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2726 (ALL_CFLAGS): Use new macros rather than old.
2727 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2728 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2729 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2730 -Wunused-result, -Wunused-variable. This should go away once
2731 the Emacs and Gnulib regex code is merged.
2732 (xmalloc, xrealloc): Now static.
2734 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2736 * dired.c (Fsystem_groups): Remove unused local.
2738 2012-04-17 Glenn Morris <rgm@gnu.org>
2740 * dired.c (Fsystem_users): Doc fix.
2742 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2744 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2745 (syms_of_dired): Add them.
2747 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2749 Fix minor alloc.c problems found by static checking.
2750 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2751 New extern decls, to avoid calling undeclared functions.
2752 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2753 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2754 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2755 (NEED_MEM_INSERT): New macro.
2756 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2757 Remove one incorrect comment and fix another.
2759 Fix minor ralloc.c problems found by static checking.
2760 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2761 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2762 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2763 (r_alloc_sbrk): Now static.
2765 Improve ralloc.c interface checking.
2766 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2767 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2768 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2769 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2770 [REL_ALLOC]: ... to here, to check interface.
2771 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2772 Remove decls. This fixes an "It stinks!".
2774 * alloc.c (which_symbols): Fix alignment issue / type clash.
2776 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2778 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2779 (struct Lisp_Misc_Any): Likewise.
2780 (struct Lisp_Free): Likewise.
2781 * alloc.c (union aligned_Lisp_Symbol): Define.
2782 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2783 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2784 (union aligned_Lisp_Misc): Define.
2785 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2786 aligned_Lisp_Misc instead of union Lisp_Misc.
2787 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2789 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2791 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2792 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2793 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2794 * s/netbsd.h, s/sol2-6.h:
2795 Remove definition of GC_MARK_STACK, since the default now works.
2796 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2797 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2798 no longer the default.
2799 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2801 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2803 * lread.c (lisp_file_lexically_bound_p):
2804 Fix hang at ";-*-\n" (bug#11238).
2806 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2808 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2809 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2811 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2813 * nsterm.m (constrainFrameRect): Always constrain when there is only
2814 one screen (Bug#10962).
2816 2012-04-13 Ken Brown <kbrown@cornell.edu>
2818 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2820 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2822 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2824 2012-04-11 Daniel Colascione <dancol@dancol.org>
2826 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2827 against is gone. It's better to use vfork now so that when Cygwin
2828 gains a new, working vfork, we use it automatically (bug#10398).
2830 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2832 * window.c (save_window_save): Obey window-point-insertion-type.
2834 2012-04-11 Glenn Morris <rgm@gnu.org>
2836 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2838 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2840 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2842 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2844 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2845 (force_quit_count): New var.
2846 (handle_interrupt): Use it.
2848 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2850 * w32.c (w32_delayed_load): Record the full path of the library
2851 being loaded (bug#10424).
2853 2012-04-09 Glenn Morris <rgm@gnu.org>
2855 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2856 not just in the obarray, before snarfing them. (Bug#11036)
2858 * Makefile.in ($(leimdir)/leim-list.el):
2859 Pass EMACS rather than BUILT_EMACS.
2861 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2863 * process.c (make_process):
2864 * process.h: Add integer `gnutls_handshakes_tried' member to
2867 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2868 Add convenience `GNUTLS_LOG2i' macro.
2870 * gnutls.c (gnutls_log_function2i): Convenience log function.
2871 (emacs_gnutls_read): Use new log functions,
2872 `gnutls_handshakes_tried' process member, and
2873 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2874 attempts per process (connection).
2876 2012-04-09 Chong Yidong <cyd@gnu.org>
2878 * eval.c (Fuser_variable_p, user_variable_p_eh)
2879 (lisp_indirect_variable): Functions deleted.
2880 (Fdefvar): Caller changed.
2882 * callint.c (Finteractive, Fcall_interactively):
2883 * minibuf.c (Fread_variable): Callers changed.
2885 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2887 * xdisp.c (set_cursor_from_row): If the display string appears in
2888 the buffer at position that is closer to point than the position
2889 after the display string, display the cursor on the first glyph of
2890 the display string. Fixes cursor display when a 'display' text
2891 property immediately follows invisible text. (Bug#11094)
2893 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2895 composite.c: use 'double' consistently
2896 * composite.c (get_composition_id): Use 'double' consistently
2897 instead of converting 'float' to 'double' and vice versa; this is
2898 easier to understand and avoids a GCC warning.
2900 2012-04-09 Glenn Morris <rgm@gnu.org>
2902 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2903 preparation for dumping it with emacs. (Bug#4789)
2904 (leimdir): New variable.
2905 ($(leimdir)/leim-list.el): New rule.
2906 (emacs$(EXEEXT)): Depend on leim-list.el.
2908 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2909 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2910 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2912 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2914 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2917 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2919 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2920 Remove unused local variable.
2922 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2924 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2925 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2926 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2927 objects, as mark_maybe_pointer will catch them otherwise.
2928 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2929 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2931 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2933 Fix typo that broke non-Windows builds.
2934 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2936 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2938 Support building on MS-Windows with libxml2.
2940 * makefile.w32-in (OBJ2): Add xml.$(O).
2941 (GLOBAL_SOURCES): Add xml.c.
2942 ($(BLD)/xml.$(O)): New dependency list.
2944 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2945 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2946 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2947 [!WINDOWSNT]: New macros.
2948 (init_libxml2_functions, libxml2_loaded_p): New functions.
2949 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2950 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2951 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2952 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2954 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2955 Call init_libxml2_functions before calling libxml2 functions.
2956 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2958 * emacs.c: Don't include libxml/parser.h.
2959 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2960 xmlCleanupParser directly.
2962 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2964 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2966 * indent.c (Fvertical_motion): If there is a display string at
2967 point, use it.vpos to compute how many lines to backtrack after
2968 move_it_to point. (Bug#11133)
2970 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2972 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2973 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2974 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2975 macros related to unification of CJK characters. For the details,
2976 see the discussion following the message here:
2977 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2979 2012-04-04 Chong Yidong <cyd@gnu.org>
2981 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2983 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2985 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2986 instead of alloca. (Bug#11138)
2988 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2990 * w32menu.c (is_simple_dialog): Properly check lisp types.
2993 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2995 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2996 position we get to after a call to move_it_to fails the
2997 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2998 only if we wind up in a string from display property. (Bug#11063)
3000 * window.c (Fdelete_other_windows_internal): Invalidate the row
3001 and column information about mouse highlight, so that redisplay
3002 restores it after reallocating the glyph matrices. (Bug#7464)
3004 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3005 string comes from a `display' text property, use the buffer
3006 position of that property as if we actually saw that position in
3008 (move_it_by_lines): Remove the assertion that
3009 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3010 violated when there's a before-string at the beginning of a line.
3013 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3015 * xdisp.c (append_space_for_newline): If the default face was
3016 remapped, use the remapped face for the appended newline.
3017 (extend_face_to_end_of_line): Use the remapped default face for
3018 extending the face to the end of the line.
3019 (display_line): Call extend_face_to_end_of_line when the default
3020 face was remapped. (Bug#11068)
3022 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3024 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3026 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3028 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3030 2012-03-27 Glenn Morris <rgm@gnu.org>
3032 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3035 2012-03-26 Kenichi Handa <handa@m17n.org>
3037 * dispextern.h (struct glyph): Fix previous change. Change the
3038 bit length of glyphless.ch to 25 (Bug#11082).
3040 2012-03-26 Chong Yidong <cyd@gnu.org>
3042 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3043 (command_loop_1): Use it; inhibit selection update for
3044 handle-select-window too (Bug#8996).
3046 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3048 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3050 2012-03-25 Kenichi Handa <handa@m17n.org>
3052 * dispextern.h (struct glyph): Change the bit length of
3053 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3055 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3057 * s/ms-w32.h (tzname): Include time.h before redirecting to
3058 _tzname. Fixes the MSVC build. (Bug#9960)
3060 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3062 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3065 * xterm.c (XTread_socket): Only modify handling_signal if
3066 !SYNC_INPUT. (Bug#11080)
3068 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3070 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3071 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3072 when fetching a multibyte character consumes more bytes than
3073 CHAR_BYTES returns, due to unification of CJK characters in
3074 string_char. (Bug#11073)
3076 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3078 * process.c (wait_reading_process_output): Handle pty disconnect
3079 by refraining from sending oneself a SIGCHLD (bug#10933).
3081 2012-03-22 Chong Yidong <cyd@gnu.org>
3083 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3085 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3086 Mark string as coming from a prefix property.
3087 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3088 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3090 2012-03-21 Chong Yidong <cyd@gnu.org>
3092 * xfaces.c (Vface_remapping_alist): Doc fix.
3094 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3096 * w32proc.c (Fw32_set_console_codepage)
3097 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3100 2012-03-20 Chong Yidong <cyd@gnu.org>
3102 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3103 to reflect default non-nil value of redisplay-dont-pause.
3105 2012-03-19 Kenichi Handa <handa@m17n.org>
3107 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3108 it fit in a valid range (Bug#11003).
3110 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3112 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3113 that is not from display property, accept the row as a "cursor
3114 row" if one of the string's character has a non-nil `cursor'
3115 property. Fixes cursor positioning when there are newlines in
3116 overlay strings, e.g. in icomplete.el. (Bug#11035)
3118 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3120 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3122 2012-03-12 Chong Yidong <cyd@gnu.org>
3124 * eval.c (inhibit_lisp_code): Rename from
3125 inhibit_window_configuration_change_hook; move from window.c.
3127 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3128 * window.c (run_window_configuration_change_hook)
3129 (syms_of_window): Callers changed.
3131 2012-03-11 Chong Yidong <cyd@gnu.org>
3133 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3135 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3137 2012-03-10 Chong Yidong <cyd@gnu.org>
3139 * frame.c (other_visible_frames): Don't assume the selected frame
3140 is visible (Bug#10955).
3142 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3144 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3146 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3148 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3149 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3152 2012-03-03 Glenn Morris <rgm@gnu.org>
3154 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3156 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3158 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3159 position past the first glyph_row that ends at ZV. (Bug#10902)
3160 (redisplay_window, next_element_from_string): Fix typos in
3162 (redisplay_window): Pass to move_it_vertically the margin in
3163 pixels, not in screen lines.
3165 2012-03-02 Glenn Morris <rgm@gnu.org>
3167 * buffer.c (buffer-list-update-hook): Doc fix.
3169 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3171 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3172 push_it before setting up the iterator for the first overlay
3173 string, even if we have an empty string loaded.
3174 (next_overlay_string): If there's an empty string on the iterator
3175 stack, pop the stack. (Bug#10903)
3177 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3179 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3180 Suggested by Stefan Monnier in
3181 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3182 * alloc.c (widen_to_Lisp_Object): New static function.
3183 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3184 and widening them to Lisp_Objects. This would work even if
3185 USE_LSB_TAG is defined and wide integers are used, which might
3186 happen in a future version of Emacs.
3188 2012-02-25 Chong Yidong <cyd@gnu.org>
3190 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3193 * xselect.c (Fx_selection_exists_p): Doc fix.
3194 (x_clipboard_manager_save_all): Print an informative message
3195 before saving to clipboard manager.
3197 2012-02-24 Chong Yidong <cyd@gnu.org>
3199 * keyboard.c (process_special_events): Handle all X selection
3200 requests in kbd_buffer, not just the next one (Bug#8869).
3202 2012-02-23 Chong Yidong <cyd@gnu.org>
3204 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3205 call when setting menu-bar-lines and tool-bar-lines parameters.
3206 (unwind_create_frame_1): New helper function.
3208 * window.c (inhibit_window_configuration_change_hook): New var.
3209 (run_window_configuration_change_hook): Obey it.
3210 (syms_of_window): Initialize it.
3212 2012-02-22 Chong Yidong <cyd@gnu.org>
3214 * xterm.c (x_draw_image_relief): Add missing type check for
3215 Vtool_bar_button_margin (Bug#10743).
3217 2012-02-21 Chong Yidong <cyd@gnu.org>
3219 * fileio.c (Vfile_name_handler_alist): Doc fix.
3221 * buffer.c (Fget_file_buffer): Protect against invalid file
3222 handler return value.
3224 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3226 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3227 when computing $valmask.
3229 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3230 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3231 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3232 It's useless in that case, and it can cause problems on hosts
3233 that allocate halves of EMACS_INT values separately.
3234 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3235 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3236 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3237 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3238 it avoids undefined behavior on hosts where shifting right by more
3239 than the word width has undefined behavior.
3241 2012-02-19 Chong Yidong <cyd@gnu.org>
3243 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3244 (Funhandled_file_name_directory, Ffile_name_as_directory)
3245 (Fdirectory_file_name, Fexpand_file_name)
3246 (Fsubstitute_in_file_name): Protect against invalid file handler
3247 return values (Bug#10845).
3249 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3251 * .gdbinit (pitx): Fix incorrect references to fields of the
3254 2012-02-17 Chong Yidong <cyd@gnu.org>
3256 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3258 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3260 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3261 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3263 2012-02-15 Chong Yidong <cyd@gnu.org>
3265 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3266 marked as special. Also, starting docstrings with * is obsolete.
3268 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3270 * gnutls.c (emacs_gnutls_write): Fix last change.
3272 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3274 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3277 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3279 * keymap.c (Fsingle_key_description): Handle char ranges.
3281 2012-02-12 Chong Yidong <cyd@gnu.org>
3283 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3284 as that creates a dangerous corner case.
3286 * window.c (Fdelete_window_internal): Invalidate the mouse
3287 highlight (Bug#9904).
3289 2012-02-12 Glenn Morris <rgm@gnu.org>
3291 * xselect.c (Fx_own_selection_internal)
3292 (Fx_get_selection_internal, Fx_disown_selection_internal)
3293 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3294 * nsselect.m (Fx_own_selection_internal)
3295 (Fx_disown_selection_internal, Fx_selection_exists_p)
3296 (Fx_selection_owner_p, Fx_get_selection_internal):
3297 Sync docs and argument specs with the xselect.c versions.
3299 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3301 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3303 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3305 * w32select.c (Fx_selection_exists_p): Sync doc string and
3306 argument list with xselect.c. (Bug#10783)
3308 * w16select.c (Fx_selection_exists_p): Sync doc string and
3309 argument list with xselect.c. (Bug#10783)
3311 2012-02-10 Glenn Morris <rgm@gnu.org>
3313 * fns.c (Fsecure_hash): Doc fix.
3315 2012-02-09 Kenichi Handa <handa@m17n.org>
3317 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3319 2012-02-07 Chong Yidong <cyd@gnu.org>
3321 * buffer.c (Fbuffer_local_variables)
3322 (buffer_lisp_local_variables): Handle unbound vars correctly;
3323 don't let Qunbound leak into Lisp.
3325 2012-02-07 Glenn Morris <rgm@gnu.org>
3327 * image.c (Fimagemagick_types): Doc fix.
3329 * image.c (imagemagick-render-type): Change it from a lisp object
3330 to an integer. Move the doc here from the lisp manual.
3331 Treat all values not equal to 0 the same.
3333 2012-02-06 Chong Yidong <cyd@gnu.org>
3335 * doc.c (store_function_docstring): Avoid applying docstring of
3336 alias to base function (Bug#2603).
3338 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3340 * .gdbinit (pp1, pv1): Remove redundant defines.
3343 2012-02-04 Chong Yidong <cyd@gnu.org>
3345 * nsterm.m: Declare a global (Bug#10694).
3347 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3349 * w32.c (get_emacs_configuration_options):
3350 Include --enable-checking, if specified, in the return value.
3352 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3354 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3355 after rounding frame sizes. (Bug#9723)
3357 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3359 * keyboard.c (adjust_point_for_property): Don't position point
3360 before BEGV. (Bug#10696)
3362 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3364 Handle overflow when computing char display width (Bug#9496).
3365 * character.c (char_width): Return EMACS_INT, not int.
3366 (char_width, c_string_width): Check for overflow when
3367 computing the width; this is possible now that individual
3368 characters can have unbounded width. Problem introduced
3369 by merge from Emacs 23 on 2012-01-19.
3371 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3373 * dbusbind.c (Fdbus_register_method): Mention the return value
3374 :ignore in the docstring.
3376 2012-02-02 Glenn Morris <rgm@gnu.org>
3378 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3380 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3381 Unconditionally set to t. (Bug#10673)
3382 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3383 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3384 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3386 2012-02-02 Kenichi Handa <handa@m17n.org>
3388 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3389 0, do not call append_composite_glyph.
3391 2012-02-02 Kenichi Handa <handa@m17n.org>
3393 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3395 (x_produce_glyphs): If the component of a composition is a null
3396 string, set it->pixel_width to 1 to avoid zero-width glyph.
3398 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3400 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3401 first 2 arguments are identical. This makes inserting large
3402 output from a subprocess an order of magnitude faster on
3403 MS-Windows, where all sbrk'ed memory is always contiguous.
3405 2012-01-31 Glenn Morris <rgm@gnu.org>
3407 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3408 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3409 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3411 2012-01-29 Glenn Morris <rgm@gnu.org>
3413 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3415 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3417 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3419 2012-01-28 Chong Yidong <cyd@gnu.org>
3421 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3423 2012-01-26 Chong Yidong <cyd@gnu.org>
3425 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3427 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3428 repeat counts (Bug#10507).
3430 2012-01-26 Glenn Morris <rgm@gnu.org>
3432 * lread.c (syms_of_lread): Doc fix.
3434 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3436 * coding.c (encode_designation_at_bol): Change return value to
3439 2012-01-25 Chong Yidong <cyd@gnu.org>
3441 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3443 2012-01-21 Chong Yidong <cyd@gnu.org>
3445 * floatfns.c (Fcopysign): Make the second argument non-optional,
3446 since nil is not allowed anyway.
3448 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3450 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3451 (send_process): Likewise.
3453 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3455 * window.c (save_window_save, Fcurrent_window_configuration)
3456 (Vwindow_persistent_parameters): Do not use Qstate.
3457 Rewrite doc-strings.
3459 2012-01-19 Kenichi Handa <handa@m17n.org>
3461 * character.c (char_width): New function.
3462 (Fchar_width, c_string_width, lisp_string_width):
3463 Use char_width (Bug#9496).
3465 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3467 * window.c (Vwindow_persistent_parameters): New variable.
3468 (Fset_window_configuration, save_window_save): Handle persistent
3471 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3473 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3474 thrashing the stack of the thread. (Bug#9087)
3476 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3478 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3480 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3482 * xdisp.c (rows_from_pos_range): Handle the case where the
3483 highlight ends on a newline. (Bug#10464)
3484 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3485 he end column for display of highlight that ends on a newline
3488 2012-01-11 Glenn Morris <rgm@gnu.org>
3490 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3491 from load-path also when installation-directory is nil. (Bug#10208)
3493 2012-01-10 Glenn Morris <rgm@gnu.org>
3495 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3497 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3498 Update template values to be closer to their typical values these days.
3500 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3502 * xdisp.c (rows_from_pos_range): Accept additional argument
3503 DISP_STRING, and accept any glyph in a row whose object is that
3504 string as eligible for mouse highlight. Fixes mouse highlight of
3505 display strings from overlays. (Bug#10464)
3507 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3509 emacs: fix an auto-save permissions race condition (Bug#10400)
3510 * fileio.c (auto_saving_dir_umask): New static var.
3511 (Fmake_directory_internal): Use it.
3512 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3513 creating the directory. The old code temporarily assigns
3514 too-generous permissions to the directory.
3515 (do_auto_save_eh): Clear it.
3516 (Fdo_auto_save): Catch all errors, not just file errors, so
3517 that the var is always cleared.
3519 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3521 * search.c (scan_buffer): Pass character positions to
3522 know_region_cache, not byte positions. (Bug#6540)
3524 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3526 * w32.c (sys_rename): Report EXDEV when rename of a directory
3527 fails because the target is on another logical disk. (Bug#10284)
3529 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3531 * xterm.c (x_embed_request_focus): New function.
3533 * xterm.h: Add prototype.
3535 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3537 2012-01-05 Glenn Morris <rgm@gnu.org>
3539 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3541 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3543 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3544 Load gnutls_transport_set_lowat only if GnuTLS version is below
3546 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3547 GnuTLS versions below 2.11.1.
3549 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3551 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3552 to the doc string advising against its use for altering the way
3553 windows are scrolled.
3555 2011-12-28 Kenichi Handa <handa@m17n.org>
3557 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3558 coding-system ASCII compatible only when it does not produce BOM
3559 on encoding (Bug#10383).
3561 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3563 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3565 (create_and_show_popup_menu): Always use menu_position_func for
3568 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3570 * callint.c (Fcall_interactively): Don't truncate prompt string.
3572 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3574 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3575 property that ends at ZV, so that the bidi iteration could be
3576 resumed from there (after widening). (Bug#10360)
3578 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3580 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3582 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3584 * nsterm.m (x_free_frame_resources):
3585 Release f->output_data.ns->miniimage.
3586 (ns_index_color): Fix indentation. Do not retain
3587 color_table->colors[i].
3589 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3592 * nsfns.m (x_set_background_color): Assign return value from
3593 ns_index_color to face-background instead of NSColor*.
3594 (ns_implicitly_set_icon_type): Fix indentation.
3595 Change assignment in for loop to comparison.
3597 * emacs.c (ns_pool): New variable.
3598 (main): Assign ns_pool.
3599 (Fkill_emacs): Call ns_release_autorelease_pool.
3601 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3602 autorelease fdesc, release fdAttrs and tdict.
3603 (ns_get_covering_families): Release charset.
3604 (ns_findfonts): Release NSFontDescriptor created with new.
3605 (ns_uni_to_glyphs): Fix indentation.
3606 (setString): Release attrStr before assigning new value.
3608 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3610 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3612 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3613 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3615 2011-12-18 David Reitter <reitter@cmu.edu>
3617 * nsterm.m (ns_term_init): Subscribe for notifications
3618 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3619 to method trackingNotification in EmacsMenu.
3621 * nsmenu.m (trackingMenu): New variable.
3622 (trackingNotification): New method (from Aquamacs).
3623 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3624 from Aquamacs (Bug#7030).
3626 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3628 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3629 (symbol_to_nsstring): Fix indentation.
3630 (ns_symbol_to_pb): New function.
3631 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3632 (Fns_rotate_cut_buffers_internal): Remove.
3633 (Fns_store_selection_internal): Rename from
3634 Fns_store_cut_buffer_internal.
3635 (ns_get_foreign_selection, Fx_own_selection_internal)
3636 (Fx_disown_selection_internal, Fx_selection_exists_p)
3637 (Fns_get_selection_internal, Fns_store_selection_internal):
3638 Use ns_symbol_to_pb and check if return value is nil.
3639 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3640 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3641 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3642 renamed to Sns_store_selection_internal.
3643 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3644 and remove this function.
3645 (ns_handle_selection_clear): Remove, never used.
3646 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3649 2011-12-17 Ken Brown <kbrown@cornell.edu>
3651 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3652 GID is unknown (Bug#10257).
3654 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3656 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3657 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3658 which caused a build failure on GNU/Linux IA-64. This problem was
3659 introduced by my 2011-10-07 patch.
3661 2011-12-15 Juri Linkov <juri@jurta.org>
3663 * image.c (imagemagick_error): New function. (Bug#10112)
3664 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3665 Use `imagemagick_error' where ImageMagick functions return
3667 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3670 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3672 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3673 fill background (Bug#8992).
3675 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3677 * window.c (Vwindow_combination_resize)
3678 (Vwindow_combination_limit): Use t instead of non-nil in
3680 (Vrecenter_redisplay): Add first sentence of doc-string on
3682 (Frecenter): Fix doc-string typo.
3684 2011-12-11 Kenichi Handa <handa@m17n.org>
3686 * coding.c (Funencodable_char_position): Pay attention to the
3687 buffer text relocation (Bug#9389).
3689 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3691 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3692 gtk_init (Bug#10100).
3694 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3696 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3697 IT->string is nil. (Bug#10263)
3699 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3701 * nsterm.h (x_free_frame_resources): Declare.
3703 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3704 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3706 * nsterm.h (ns_get_defaults_value): Declare.
3708 * nsterm.m (ns_default): Call ns_get_defaults_value.
3710 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3712 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3715 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3717 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3718 that where the value of an _OBJC_* symbol points to is in the .bss
3719 section (Bug#10240).
3721 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3723 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3724 after the loop to call ccl_driver at least once (Bug#8619).
3726 2011-12-08 Kenichi Handa <handa@m17n.org>
3728 * ftfont.c (get_adstyle_property): Fix previous change
3731 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3733 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3734 dirs from the default value of EMACSLOADPATH (bug#10208).
3736 2011-12-07 Glenn Morris <rgm@gnu.org>
3738 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3739 installation and source directories as well. (Bug#10208)
3741 2011-12-06 Chong Yidong <cyd@gnu.org>
3743 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3745 2011-12-06 Glenn Morris <rgm@gnu.org>
3747 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3748 as an error, not just -1. (Bug#10217)
3750 2011-12-05 Chong Yidong <cyd@gnu.org>
3752 * keyboard.c (process_special_events): New function.
3753 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3755 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3757 * coding.c (encode_designation_at_bol): Don't use uninitialized
3758 local variable (Bug#9318).
3760 2011-12-05 Kenichi Handa <handa@m17n.org>
3762 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3763 return Qnil (Bug#8046, Bug#10193).
3765 2011-12-05 Kenichi Handa <handa@m17n.org>
3767 * coding.c (encode_designation_at_bol): New args charbuf_end and
3768 dst. Return the number of produced bytes. Callers changed.
3769 (coding_set_source): Return how many bytes coding->source was
3771 (coding_set_destination): Return how many bytes
3772 coding->destination was relocated.
3773 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3774 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3776 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3778 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3779 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3782 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3784 The following changes are to fix Bug#9318.
3786 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3787 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3788 (encode_coding_iso_2022, encode_coding_sjis)
3789 (encode_coding_big5, encode_coding_charset): Use the above macros.
3791 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3793 * lisp.h (process_quit_flag): Fix external declaration.
3795 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3797 Don't macro-inline non-performance-critical code.
3798 * eval.c (process_quit_flag): New function.
3799 * lisp.h (QUIT): Use it.
3801 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3803 * nsfns.m (get_geometry_from_preferences): New function.
3804 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3806 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3808 * emacs.c (Qkill_emacs): Define.
3809 (syms_of_emacs): Initialize it.
3810 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3811 Qquit_flag to `kill-emacs' instead.
3812 (quit_throw_to_read_char): Add parameter `from_signal'.
3813 All callers changed. Call Fkill_emacs if requested and safe.
3814 * lisp.h (QUIT): Call Fkill_emacs if requested.
3816 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3818 * widget.c (update_wm_hints): Return if wmshell is null.
3819 (widget_update_wm_size_hints): New function.
3821 * widget.h (widget_update_wm_size_hints): Declare.
3823 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3824 widget_update_wm_size_hints (Bug#10104).
3826 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3828 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3829 before a newline, prepare the bidi iterator for consuming the
3830 newline, and keep the current paragraph direction. (Bug#10183)
3831 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3833 2011-12-02 Juri Linkov <juri@jurta.org>
3835 * search.c (Fword_search_regexp): New Lisp function created from
3836 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3837 (Fword_search_backward, Fword_search_forward)
3838 (Fword_search_backward_lax, Fword_search_forward_lax):
3839 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3840 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3842 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3844 * fileio.c (Finsert_file_contents): Move after-change-function call
3845 to before the "handled:" label, since all "goto handled" appear in
3846 cases where the *-change-functions have already been properly called
3849 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3851 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3852 waiting for input. (Bug#10169)
3854 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3856 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3857 verifies glyph row's hash code--we have just reallocated the
3858 glyphs, so their contents can be complete garbage. (Bug#10164)
3860 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3862 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3864 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3866 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3867 attributes are tested _before_ calling verify_row_hash, to protect
3868 against GCC re-ordering of the tests. (Bug#10164)
3870 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3872 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3874 * xterm.c (handle_one_xevent): Only set async_visible and friends
3875 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3876 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3877 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3879 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3881 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3882 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3883 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3884 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3885 All uses changed to use GCPRO1 etc.
3886 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3887 Revert to old implementation (i.e., before 2011-03-11).
3889 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3891 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3892 of scroll runs so as to avoid assigning disabled bogus rows and
3893 unnecessary graphics copy operations.
3895 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3897 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3898 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3899 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3900 (malloc, free, realloc, calloc): Redirect to e_* only when
3903 * lisp.h (GCTYPEBITS): Move before first use.
3904 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3905 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3906 this macro definition.
3908 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3911 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3913 * gtkutil.c (xg_create_frame_widgets):
3914 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3915 present with Gtk+ 2.0.
3917 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3919 * fileio.c (Finsert_file_contents): Undo previous change; see
3920 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3922 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3924 Rename locals to avoid shadowing.
3925 * fileio.c (Finsert_file_contents):
3926 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3927 * process.c (wait_reading_process_output):
3928 Rename inner 'proc' to 'p' to avoid shadowing.
3929 Indent for consistency with usual Emacs style.
3931 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3933 * xdisp.c (redisplay_window): If cursor row is not fully visible
3934 after recentering, and scroll-conservatively is set to a large
3935 number, scroll window by a few more lines to make the cursor fully
3936 visible and out of scroll-margin. (Bug#10105)
3937 (start_display): Don't move to the next line if the display should
3938 start at a newline that is part of a display vector or an overlay
3941 2011-11-24 Juri Linkov <juri@jurta.org>
3943 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3944 after the `MagickPingImage' call. (Bug#10112)
3946 2011-11-23 Chong Yidong <cyd@gnu.org>
3948 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3950 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3952 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3953 making another buffer current. (Bug#10114)
3955 2011-11-23 Glenn Morris <rgm@gnu.org>
3957 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3959 2011-11-23 Chong Yidong <cyd@gnu.org>
3961 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3962 using it (Bug#5984).
3964 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3966 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3967 and header-lines, as they don't have one computed for them.
3970 * .gdbinit (prow): Make displayed values more self-explaining.
3971 Add row's hash code.
3973 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3975 * process.c (wait_reading_process_output): Fix asynchrounous
3976 GnuTLS socket handling on some versions of the GnuTLS library.
3977 (wait_reading_process_output): Add comment and URL.
3979 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3981 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3983 2011-11-21 Chong Yidong <cyd@gnu.org>
3985 * window.c (Fnext_window, Fprevious_window): Doc fix.
3987 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3989 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3991 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3993 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3995 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3997 * window.c (Fset_window_combination_limit): Rename argument
3999 (Vwindow_combination_limit): Remove "status" from doc-string.
4001 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4003 * m/ibms390.h: Remove.
4004 * m/ibms390x.h: Don't include "ibms390.h".
4006 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4008 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4009 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4011 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4013 * casetab.c (Fset_case_table):
4014 * charset.c (Fcharset_after): Fix typos.
4016 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4018 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4019 Otherwise, valgrind does not work on some platforms.
4020 Problem reported by Andreas Schwab in
4021 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4022 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4023 is set, removing the need for VIRT_ADDRESS_VARIES.
4024 (PURE_P): Use a more-efficient implementation that needs just one
4025 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4026 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4027 to 4 (xorl, subq, cmpq, setbe).
4028 * alloc.c (pure): Always extern now, since that's the
4029 VIRT_ADDR_VARIES behavior.
4030 (PURE_POINTER_P): Use a single comparison, not two, for
4031 consistency with the new puresize.h.
4032 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4033 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4034 Remove VIRT_ADDR_VARIES no longer needed.
4036 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4038 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4039 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4040 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4041 behave as if the cursor position were at the window margin.
4043 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4044 and the cursor position is out of bounds, behave as if the cursor
4045 position were at the window margin. (Bug#10075)
4047 2011-11-18 Chong Yidong <cyd@gnu.org>
4049 * window.c (Fwindow_combination_limit): Make first argument
4050 non-optional, since it is meaningless for live windows like the
4053 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4055 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4057 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4059 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4060 (graft_intervals_into_buffer): Simplify.
4062 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4064 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4065 hash values of the two rows.
4066 (copy_row_except_pointers): Preserve the used[] arrays and the
4067 hash values of the two rows. (Bug#10035)
4068 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4070 * xdisp.c (row_hash): New function, body extracted from
4071 compute_line_metrics.
4072 (compute_line_metrics): Call row_hash, instead of computing the
4075 * dispnew.c (verify_row_hash): Call row_hash for computing the
4076 hash code of a row, instead of duplicating code from xdisp.c.
4078 * dispextern.h (row_hash): Add prototype.
4080 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4082 * frame.c (delete_frame): Don't delete the terminal when the last
4083 X frame is closed if emacs is built with GTK toolkit.
4085 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4087 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4089 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4091 * window.c (Vwindow_splits): Rename to
4092 Vwindow_combination_resize. Suggested by Juri Linkov.
4093 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4096 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4098 * nsfns.m (Fns_font_name):
4099 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4101 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4103 * window.h (window): Rename slot "nest" to "combination_limit".
4104 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4105 (Fset_window_nest): Rename to Fset_window_combination_limit.
4106 (Vwindow_nest): Rename to Vwindow_combination_limit.
4107 (recombine_windows, make_parent_window, make_window)
4108 (Fsplit_window_internal, saved_window)
4109 (Fset_window_configuration, save_window_save): Rename all
4110 occurrences of window_nest to window_combination_limit.
4112 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4114 * image.c (imagemagick_load_image): Fix typo.
4116 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4118 * xdisp.c (display_line): Move the call to
4119 highlight_trailing_whitespace before the call to
4120 compute_line_metrics, since the latter needs to see the final
4121 faces of all the glyphs to compute ROW's hash value.
4122 Fixes assertion violations in row_equal_p. (Bug#10035)
4124 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4126 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4127 just return (bug#10044).
4129 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4131 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4132 with user-defined heap size. Bump the default size of the temacs
4133 heap to 27MB, to avoid memory warning when running temacs.
4134 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4136 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4137 current_matrix and desired_matrix. (Bug#9990)
4138 (verify_row_hash) [XASSERTS]: New function.
4139 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4140 that the hash value of glyph rows is correct.
4142 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4144 * window.h (window): Remove splits slot.
4145 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4146 (Fdelete_other_windows_internal, make_parent_window)
4147 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4148 (Fset_window_configuration, save_window_save): Don't deal with
4149 split status of windows.
4150 (saved_window): Remove splits slot.
4151 (Vwindow_splits): Rewrite doc-string.
4153 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4155 * xfns.c (unwind_create_frame):
4156 * nsfns.m (unwind_create_frame):
4157 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4158 Vframe_list (Bug#9999).
4160 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4162 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4164 2011-11-11 Kenichi Handa <handa@m17n.org>
4166 * callproc.c (Fcall_process): Set the member dst_multibyte of
4169 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4171 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4172 avoid a crash (bug#9496).
4174 2011-11-09 Chong Yidong <cyd@gnu.org>
4176 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4177 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4179 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4181 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4183 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4185 Avoid some portability problems by eschewing 'extern inline' functions.
4186 The trivial performance wins aren't worth the portability hassles; see
4187 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4189 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4190 (window_box_width, window_box_left, window_box_left_offset)
4191 (window_box_right, window_box_right_offset): Undo previous change,
4192 by removing the "extern"s.
4193 * intervals.c (adjust_intervals_for_insertion)
4194 (adjust_intervals_for_deletion): Undo previous change,
4195 making these static again.
4196 (offset_intervals, temp_set_point_both, temp_set_point)
4197 (copy_intervals_to_string): No longer inline.
4198 * xdisp.c (window_text_bottom_y, window_box_width)
4199 (window_box_height, window_box_left_offset)
4200 (window_box_right_offset, window_box_left, window_box_right)
4201 (window_box): No longer inline.
4203 2011-11-08 Chong Yidong <cyd@gnu.org>
4205 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4206 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4207 Signal an error if not a live window.
4208 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4209 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4211 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4213 * lisp.h (syms_of_abbrev): Remove declaration.
4214 Reported by CHENG Gao <chenggao@royau.me>.
4216 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4218 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4219 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4220 of temacs in GUI mode.
4222 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4224 * window.h: Declare delete_all_child_windows instead of
4225 delete_all_subwindows.
4226 * window.c (Fwindow_nest, Fset_window_nest)
4227 (Fset_window_new_total, Fset_window_new_normal)
4228 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4229 (delete_all_subwindows): Rename to delete_all_child_windows.
4230 (Fdelete_other_windows_internal, Fset_window_configuration):
4231 Call delete_all_child_windows instead of delete_all_subwindows.
4232 * frame.c (delete_frame): Call delete_all_child_windows instead
4233 of delete_all_subwindows.
4235 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4237 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4238 This is also needed for porting to any host where GC_MARK_STACK is
4239 not GC_MAKE_GCPROS_NOOPS.
4240 (which_symbols): Use it.
4242 2011-11-07 Kenichi Handa <handa@m17n.org>
4244 * coding.c (coding_set_destination): Check coding->src_pos only
4245 when coding->src_object is a buffer (bug#9910).
4247 * process.c (send_process): Set the member src_multibyte of coding
4248 to 0 (bug#9911) when sending a unibyte text.
4250 * callproc.c (Fcall_process): Set the member src_multibyte of
4251 process_coding to 0 (bug#9912).
4253 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4255 * xmenu.c (cleanup_widget_value_tree): New function.
4256 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4257 calling free_menubar_widget_value_tree directly (Bug#9830).
4259 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4261 Fix some portability problems with 'inline'.
4262 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4263 (window_box_width, window_box_left, window_box_left_offset)
4264 (window_box_right, window_box_right_offset): Declare extern.
4265 Otherwise, these inline functions do not conform to C99 and
4266 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4267 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4268 * intervals.c (adjust_intervals_for_insertion)
4269 (adjust_intervals_for_deletion): Now extern, because otherwise the
4270 extern inline functions 'offset_intervals' couldn't refer to it.
4271 (static_offset_intervals): Remove.
4272 (offset_intervals): Rewrite using the old contents of
4273 static_offset_intervals. The old version didn't conform to C99
4274 because an extern inline function contained a reference to an
4275 identifier with static linkage.
4277 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4279 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4282 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4284 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4285 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4286 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4287 return Qleft_to_right.
4289 2011-11-06 Chong Yidong <cyd@gnu.org>
4291 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4292 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4293 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4294 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4295 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4296 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4297 (Fwindow_vscroll): Doc fix.
4298 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4299 argument, since it makes no sense to pass a live window and for
4300 consistency with window-child.
4302 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4304 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4307 2011-11-05 Jason Rumney <jasonr@gnu.org>
4309 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4310 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4312 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4313 bitwise arithmetic preventing use of unicode-sip and non-truetype
4316 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4318 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4321 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4322 initialization code to keep similarity to xfns.c after changes
4325 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4327 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4328 (unwind_create_frame): New function (Bug#9943).
4329 (Fx_create_frame): Restructure code to be more similar to the one in
4330 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4331 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4332 Move terminal->reference_count++ just before making the frame official
4335 * nsterm.m (x_free_frame_resources): New function.
4336 (x_destroy_window): Move code to x_free_frame_resources.
4338 * xfns.c (unwind_create_frame): Fix comment.
4339 (Fx_create_frame, x_create_tip_frame):
4340 Move terminal->reference_count++ just before making the frame
4341 official. Move initialization of image_cache_refcount and
4342 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4344 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4346 Support MSVC build with newer versions of Visual Studio.
4347 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4348 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4351 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4352 which are not supported by MSVC.
4353 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4354 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4356 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4358 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4360 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4362 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4364 Support MSVC build with newer versions of Visual Studio.
4365 * w32.c: Don't include w32api.h for MSVC.
4366 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4368 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4369 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4370 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4371 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4373 (alloca) [_MSC_VER]: Define to _alloca.
4375 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4377 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4379 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4381 * xdisp.c (note_mouse_highlight): If either of
4382 previous/next-single-property-change returns nil, treat that as
4383 the beginning or the end of the buffer. (Bug#9955)
4385 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4387 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4388 label is not null (Bug#9951).
4389 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4392 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4394 * window.c (Fwindow_body_size): Mention in the doc string that the
4395 return value is in frame's canonical units. (Bug#9949)
4397 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4399 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4401 * w32fns.c (unwind_create_frame): If needed, free the glyph
4402 matrices of the partially constructed frame. (Bug#9943)
4403 * xfns.c (unwind_create_frame): Likewise.
4405 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4407 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4408 Don't stop backward scan on the continuation glyph, even though
4409 its CHARPOS is positive.
4410 (mouse_face_from_buffer_pos, note_mouse_highlight):
4411 Rename cover_string to disp_string.
4413 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4415 * window.c (temp_output_buffer_show): Don't use
4416 Vtemp_buffer_show_specifiers.
4417 (Vtemp_buffer_show_specifiers): Remove unused variable.
4419 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4421 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4422 past the beginning of the current glyph matrix.
4424 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4426 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4427 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4428 HAVE_GTK3 (Bug#9869).
4430 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4431 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4433 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4435 * xterm.c: Declare x_handle_net_wm_state to return int.
4436 (handle_one_xevent): Check if we are iconified but don't have
4437 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4438 (get_current_wm_state): Return non-zero if not hidden,
4439 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4440 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4441 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4442 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4444 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4446 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4447 so that this new function doesn't get optimized away by a
4448 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4450 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4452 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4454 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4456 Fix the `xbytecode' command.
4457 * .gdbinit (xprintbytestr): New command.
4458 (xwhichsymbols): Rename from `which'; all callers changed.
4459 (xbytecode): Print the byte-code string as well.
4461 2011-10-29 Kim Storm <storm@cua.dk>
4463 * alloc.c (which_symbols): New function.
4465 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4467 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4470 2011-10-29 Glenn Morris <rgm@gnu.org>
4472 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4473 Not clear what it was for, and it causes various bugs. (Bug#9839)
4475 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4477 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4478 possible random value that matches one of those tested as
4479 condition to clear the mouse face.
4481 2011-10-28 Chong Yidong <cyd@gnu.org>
4483 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4485 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4487 * window.c (make_window): Initialize phys_cursor_on_p.
4489 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4491 * lisp.h (struct Lisp_Symbol): Update comments.
4493 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4495 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4497 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4499 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4500 <oslsachem@gmail.com> for helping to debug this.
4502 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4503 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4504 (g_b_init_get_glyph_outline_w): New static variables.
4505 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4506 (GetGlyphOutlineW_Proc): New typedefs.
4507 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4508 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4510 (w32font_open_internal, compute_metrics):
4511 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4512 instead of calling the "wide" APIs directly.
4514 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4516 * w32.h (syms_of_w32font): Add prototype.
4518 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4520 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4521 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4522 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4523 (Fmove_to_window_line): Doc fix.
4525 2011-10-27 Chong Yidong <cyd@gnu.org>
4527 * process.c (make_process): Set gnutls_state to NULL.
4529 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4530 non-NULL, regardless of GNUTLS_INITSTAGE.
4531 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4532 an error. Set process slots as soon as we allocate them.
4534 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4536 2011-10-27 Chong Yidong <cyd@gnu.org>
4538 * gnutls.c (emacs_gnutls_deinit): New function.
4539 Deallocate credentials structures as well as calling gnutls_deinit.
4540 (Fgnutls_deinit, Fgnutls_boot): Use it.
4542 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4543 (deactivate_process): Call emacs_gnutls_deinit.
4545 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4547 * image.c (x_create_x_image_and_pixmap):
4548 * w32.c (sys_rename, w32_delayed_load):
4549 * w32font.c (fill_in_logfont):
4550 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4552 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4554 * w32fns.c (w32_default_color_map): New function,
4555 extracted from Fw32_default_color_map.
4556 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4558 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4560 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4562 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4564 * keyboard.c (test_undefined): New function (bug#9751).
4565 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4567 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4569 * sysdep.c (init_sys_modes): Fix the check for the controlling
4570 terminal (Bug#6649).
4572 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4574 * dispextern.h (struct bidi_it): New member next_en_type.
4576 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4577 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4578 current character, check also for next_en_type being WEAK_EN.
4579 (bidi_resolve_weak): Don't enter the expensive loop if the current
4580 position is before next_en_pos. Record the bidi type of the first
4581 non-ET, non-BN character we find, in addition to its position.
4582 (bidi_level_of_next_char): Invalidate next_en_type when
4583 next_en_pos is over-stepped.
4585 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4587 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4588 * editfns.c: Rewrite current-time-zone so that it invokes
4589 the equivalent of (format-time-string "%Z") to get the time zone name.
4590 This fixes a bug when the time zone name contains characters that
4591 need converting from the system time locale to Emacs internal format.
4592 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4593 that patch fixed format-time-string to do the conversion, but
4594 I forgot to fix current-time-zone.
4595 (format_time_string): New function, containing most of
4596 what Fformat_time_string used to contain.
4597 (Fformat_time_string): Rewrite in terms of format_time_string.
4598 This doesn't change this function's behavior.
4599 (current-time-zone): Rewrite to use format_time_string.
4600 This fixes the bug reported by Michael Schierl in
4601 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4602 Jason Rumney's 2007-06-07 change worked around this bug, but
4604 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4606 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (start_display): If the character at POS is displayed
4609 via a display vector, reset IT->current.dpvec_index to zero.
4610 (try_window_reusing_current_matrix): If a line ends in a display
4611 vector or the next line starts in a display vector, continue
4612 redrawing the window even though the character position of
4613 start_row was reached.
4616 2011-10-18 Chong Yidong <cyd@gnu.org>
4618 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4619 with nobreak-char-display too.
4621 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4623 Fix part 3 of bug#9771.
4624 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4625 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4626 non-neutral characters if the current character is a paragraph
4627 separator (a.k.a. Newline). This avoids running the same
4628 expensive loop twice, once when we consume the preceding newline
4629 and the other time when the line actually needs to be displayed.
4630 Avoid the loop when we see neutrals on the base embedding level
4631 following a character whose directionality is the same as the
4632 paragraph's. This avoids running the expensive loop when a line
4633 ends in a long sequence of neutrals, like control characters.
4634 Add assertion against STRONG_AL type. Slightly rearrange code
4635 that determines the type of a neutral given the first non-neutral
4637 (bidi_level_of_next_char): Set next_en_pos to zero when
4638 invalidating its info.
4640 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4642 * xdisp.c (push_display_prop): Determine whether to record string
4643 or buffer position by IT->string, not by IT->method. Allow
4644 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4645 (move_it_vertically_backward): Don't look for character position
4646 immediately after the newline when in a continuation line.
4649 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4651 * window.c (coordinates_in_window): Rewrite and delabelize
4652 vertical border check. (Bug#5357) (Bug#9618)
4654 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4656 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4657 errors in XSetWindowBorder (bug#9310).
4659 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4661 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4662 avoid crash when xmalloc overrun checking is enabled.
4664 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4666 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4667 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4668 cursor motion with <left> and <right> arrow keys.
4670 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4671 some callers set that themselves.
4673 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4675 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4676 display string and the previous row comes from the same string and
4677 is empty. (Bug#9739) (Bug#9738)
4679 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4681 * doc.c (get_doc_string): Encode file name (bug#9735).
4683 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4685 * bidi.c (bidi_level_of_next_char):
4686 * xdisp.c (get_visually_first_element): Remove old incorrect
4687 comments regarding the Unicode Line Separator character.
4689 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4691 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4693 * alloc.c (Fgc_status): Do not access beyond zombies array
4694 boundary if nzombies > MAX_ZOMBIES.
4695 * alloc.c (dump_zombies): Add missing format specifier.
4697 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4699 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4700 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4702 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4703 Some packages use them to denote characters with modifiers.
4705 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4707 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4708 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4709 matching a pp-number. Rename parameter var to var1.
4711 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4713 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4715 2011-10-08 Glenn Morris <rgm@gnu.org>
4717 * callint.c (Fcall_interactively): Give a more explicit error for the
4718 'c' case with a non-character input. (Bug#8479)
4720 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4722 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4724 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4725 lines that are hscrolled on the left.
4727 * dispnew.c (buffer_posn_from_coords): Account for a possible
4728 presence of header-line. (Bug#4426)
4730 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4732 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4733 Don't advertise functionality which we discourage or doesn't work.
4735 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4737 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4738 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4739 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4740 this makes Emacs dump core during garbage collection on rare
4741 occasions. sizeof is obviously inferior to offsetof here, so
4742 stick with offsetof.
4743 (GC_POINTER_ALIGNMENT): New macro.
4744 (mark_memory): Omit 3rd (offset) arg; caller changed.
4745 Don't assume EMACS_INT alignment is the same as pointer alignment.
4747 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4749 * keyboard.c (read_key_sequence_remapped): New var.
4750 (read_key_sequence): Compute remapping in the right buffer.
4751 (command_loop_1): Use read_key_sequence's remapping directly.
4753 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4755 * dired.c (file_name_completion): Don't expand file name.
4756 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4757 before checking file name handler.
4759 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4760 they've been requested explicitly (bug#9591).
4762 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4764 * keymap.c (Fsingle_key_description): Use make_specified_string
4765 instead of build_string to build string from push_key_description.
4768 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4770 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4771 This fixes a Y2038 bug on 64-bit hosts.
4772 * buffer.c (reset_buffer):
4773 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4774 (Fclear_buffer_auto_save_failure):
4775 Use 0, not -1, to represent an unset failure time, since time_t
4776 might not be signed.
4778 Remove dependency on glibc malloc internals.
4779 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4780 Move back here from lisp.h, but with their new implementations.
4781 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4782 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4783 * charset.c (charset_table_init): New static var.
4784 (syms_of_charset): Use it instead of xmalloc. This removes a
4785 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4786 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4787 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4788 Move back to alloc.c.
4789 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4790 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4792 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4794 * nsterm.m (windowDidResize): Call x_set_window_size only when
4795 ns_in_resize is true. Otherwise set pixelwidth/height and
4796 call change_frame_size (Bug#9628).
4798 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4800 Port --enable-checking=all to Fedora 14 x86-64.
4801 * charset.c (syms_of_charset): Also account for glibc malloc's
4802 internal overhead when calculating the initial malloc maximum.
4804 Port --enable-checking=all to Fedora 14 x86.
4805 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4807 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4808 (overrun_check_realloc, overrun_check_free):
4809 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4810 That way, xmalloc returns a properly-aligned pointer even if
4811 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4812 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4813 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4814 into account when calculating the initial malloc maximum.
4815 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4816 Move here from alloc.c, so that charset.c can use it too.
4817 Properly align; the old code wasn't right for common 32-bit hosts
4818 when configured with --enable-checking=all.
4819 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4820 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4822 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4824 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4827 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4829 * xdisp.c (compute_display_string_end): If there's no display
4830 string at CHARPOS, return -1.
4832 * bidi.c (bidi_fetch_char): When compute_display_string_end
4833 returns a negative value, treat the character as a normal
4834 character not covered by a display string. (Bug#9624)
4836 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4838 * lread.c (Fread_from_string): Fix typo in docstring.
4840 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4842 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4843 newline, reseat the iterator instead of bidi-iterating there one
4844 character at a time. (Bug#9610)
4845 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4846 TO_CHARPOS if the bidi iterator is at base embedding level.
4848 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4850 * lread.c (readevalloop): Use correct code for NBSP.
4851 (read1): Likewise. (Bug#9608)
4853 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4855 * dbusbind.c (Fdbus_register_signal): When service is not
4856 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4858 2011-09-25 Glenn Morris <rgm@gnu.org>
4860 * buffer.c (truncate-lines): Doc fix.
4862 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4864 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4865 (Fset_window_next_buffers): Doc fix.
4867 2011-09-24 Glenn Morris <rgm@gnu.org>
4869 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4871 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4873 Fix minor problems found by static checking.
4874 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4875 * indent.c (Fvertical_motion): Fix == vs = typo.
4877 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4879 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4880 Default value is now t. Doc fix.
4882 * indent.c (Fvertical_motion): Compute and apply the overshoot
4883 logic when moving up, not only when moving down. Fix the
4884 confusing name and values of the it_overshoot_expected variable;
4885 logic changes accordingly. (Bug#9254) (Bug#9549)
4887 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4888 CHARPOS is covered by a display string which includes newlines.
4889 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4890 is covered by a display string with embedded newlines.
4892 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4894 * dbusbind.c (Fdbus_register_signal): Add match rule to
4895 Vdbus_registered_objects_table. (Bug#9581)
4896 (Fdbus_register_method, Vdbus_registered_objects_table):
4899 2011-09-24 Jim Meyering <meyering@redhat.com>
4901 do not ignore write error for any output size
4902 The previous change was incomplete.
4903 While it makes emacs --batch detect the vast majority of stdout
4904 write failures, errors were still ignored whenever the output size is
4905 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4906 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4907 && echo FAIL: ignored write error
4908 FAIL: ignored write error
4909 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4910 && echo FAIL: ignored write error
4911 FAIL: ignored write error
4912 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4914 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4916 * emacs.c (Fkill_emacs): In noninteractive mode exit
4917 non-successfully if a write error occurred on stdout. (Bug#9574)
4919 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4921 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4924 * dispextern.h (struct it): Update the comment documenting what
4927 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4929 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4930 a display string, extend search for cursor position to end of row.
4931 (find_row_edges): If the row ends in a newline from a display
4932 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4933 Handle the case of a display string with multiple newlines.
4934 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4935 non-empty line. Fixes confusing cursor motion with arrow keys at
4936 the beginning of a line that starts with whitespace.
4938 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4940 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4943 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4945 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4948 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4950 * xdisp.c (display_line): Record maximum and minimum buffer
4951 positions even if no glyphs were produced (e.g., by a zero-width
4952 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4953 buffer positions that will be removed from the glyph row because
4955 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4956 column is beyond frame width: don't subtract 1 "pixel" when
4957 computing width of the stretch.
4958 (reseat_at_next_visible_line_start): Undo the change made on
4959 2011-09-17 that saved paragraph information and restored it after
4960 the call to `reseat'. (Bug#9545)
4962 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4964 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4965 and turn window cursor on if cleared (Bug#9415).
4967 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4969 * search.c (boyer_moore): Take unibyte characters from pattern
4970 literally. (Bug#9458)
4972 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4974 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4976 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4978 Fix minor problem found by static checking.
4979 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4980 initialized, to pacify gcc -Wuninitialized.
4982 * fileio.c: Report proper errno when syscall falls.
4983 (Finsert_file_contents): Save and restore errno,
4984 so that report_file_error outputs the correct diagnostic.
4985 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4987 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4989 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4991 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4993 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4994 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4996 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4998 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4999 about the current paragraph and restore it after the call to reseat.
5001 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5002 (bidi_find_paragraph_start): Search back for paragraph beginning
5003 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5004 (bidi_move_to_visually_next): Only trigger paragraph-related
5005 computations when the last character is a newline or at EOB, not
5006 just any NEUTRAL_B. (Bug#9470)
5008 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5009 truncated lines if point is covered by a display string. (Bug#9524)
5011 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5013 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5014 (cons_to_x_long): New function.
5015 (lisp_data_to_selection_data): Use it. Correct the test for
5016 short-versus-long data; it was negated. Break out of vector
5017 loop, for efficiency, when a long datum is discovered.
5019 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5021 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5023 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5025 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5026 GCC PR/17406) by declaring this function with external scope.
5028 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5030 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5031 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5033 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5035 * editfns.c (Fformat): Correctly handle text properties on "%%".
5037 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5039 * xterm.c (x_draw_composite_glyph_string_foreground):
5040 * w32term.c (x_draw_composite_glyph_string_foreground):
5041 * term.c (encode_terminal_code):
5042 * composite.c (composition_update_it, get_composition_id):
5043 * xdisp.c (get_next_display_element)
5044 (fill_composite_glyph_string): Add comments about special meaning
5045 of TAB characters in a composition.
5047 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5049 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5050 This occurs when processing a multibyte format.
5051 Problem reported by Wolfgang Jenker.
5053 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5055 * xdisp.c (try_cursor_movement): Only check for exact match if
5056 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5058 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5060 Remove unused external symbols.
5061 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5062 * xdisp.c (calc_pixel_width_or_height): Now static.
5063 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5064 * indent.c (check_display_width):
5065 * w32term.c: Fix comment to match code.
5066 * xterm.c, xterm.h (x_catching_errors): Remove.
5068 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5070 * xselect.c: Use signed conversions more consistently (Bug#9498).
5071 (selection_data_to_lisp_data): Assume incoming selection data are
5072 signed integers, not unsigned. This is to be consistent with
5073 outgoing selection data, which was modified to use signed integers
5074 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5075 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5076 expects long, not unsigned long.
5078 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5080 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5081 computation of loop end. Reported by Johan Bockgård
5084 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5086 * frame.c (Fother_visible_frames_p): Function deleted.
5088 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5090 * indent.c (compute_motion): Process display vector front to back
5091 rather than the other way around. (Bug#2496)
5093 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5095 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5097 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5099 * minibuf.c (Fread_from_minibuffer): Doc fix.
5101 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5103 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5104 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5106 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5108 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5109 value for non-existent files.
5111 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5113 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5114 set its "size" to -1. This will set the modtime_size field of
5115 the corresponding buffer to -1, which is what
5116 verify-visited-file-modtime expects for files that do not exist.
5119 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5121 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5123 * lisp.h: ... from here. push_key_description is no longer
5124 defined in keyboard.c, so its declaration should not be in
5125 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5126 logically belongs with push_key_description.
5128 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5130 * buffer.h: Include <sys/types.h> instead of <time.h>.
5131 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5132 Problem reported by Herbert J. Skuhra.
5134 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5136 * xml.c (parse_region): Make the parsing work for
5137 non-comment-starting XML files again (bug#9144).
5139 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5141 * image.c (gif_load): Fix calculation of bottom and right corner.
5144 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5146 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5147 redisplay in small windows.
5149 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5151 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5153 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5155 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5156 Operate on live windows only.
5158 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5160 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5162 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5164 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5165 only under bidi iteration.
5167 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5169 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5171 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5173 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5174 Without this fix, the command to link temacs failed due to an
5175 undefined symbol __builtin_isnan. This is because
5176 /usr/include/iso/math_c99.h #defines isnan(x) to
5177 __builtin_isnan(x), but the bundled gcc, which identifies itself
5178 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5180 * floatfns.c (isnan): #undef, and then #define to a clone of
5182 (Fisnan): Always define, since it's always available now.
5183 (syms_of_floatfns): Always define isnan at the Lisp level.
5185 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5187 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5189 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5191 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5192 The previous code assumed that file offsets (off_t values) fit in
5193 EMACS_INT variables, which is not true on typical 32-bit hosts.
5194 The code messed up by falsely reporting buffer overflow in cases
5195 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5196 when "big" contains more than 2**29 bytes, even though this
5197 inserts just one byte and does not overflow the buffer.
5198 (Finsert_file_contents): Store file offsets as off_t
5199 values, not as EMACS_INT values. Check for overflow when
5200 converting between EMACS_INT and off_t. When checking for
5201 buffer overflow or for overlap, take the offsets into account.
5202 Don't use EMACS_INT for small values where int suffices.
5203 When checking for overlap, fix a typo: ZV was used where
5204 ZV_BYTE was intended.
5205 (Fwrite_region): Don't assume off_t fits into 'long'.
5206 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5208 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5210 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5212 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5214 sprintf-related integer and memory overflow issues (Bug#9412).
5216 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5217 (esprintf, exprintf, evxprintf): New functions.
5218 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5219 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5220 (modify_event_symbol): Do not assume that the length of
5221 name_alist_or_stem is safe to alloca and fits in int.
5222 (Fexecute_extended_command): Likewise for function name and binding.
5223 (Frecursion_depth): Wrap around reliably on integer overflow.
5224 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5225 since some callers pass EMACS_INT values.
5226 (Fsingle_key_description): Don't crash if symbol name contains more
5227 than MAX_ALLOCA bytes.
5228 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5229 (get_minibuffer): Arg is now EMACS_INT, not int.
5230 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5231 (esprintf, exprintf, evxprintf): New decls.
5232 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5234 * dbusbind.c (signature_cat): New function.
5235 (xd_signature, Fdbus_register_signal):
5236 Do not overrun buffer; instead, report string overflow.
5238 * dispnew.c (add_window_display_history): Don't overrun buffer.
5239 Truncate instead; this is OK since it's just a log.
5241 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5242 even if the time zone offset is outlandishly large.
5243 Don't mishandle offset == INT_MIN.
5245 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5246 when creating daemon; the previous buffer-overflow check was incorrect.
5248 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5249 which has the guts of the old verror function.
5251 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5252 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5254 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5255 (font_unparse_xlfd): Don't blindly alloca long strings.
5256 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5257 fits in int, when using sprintf. Use single snprintf to count
5258 length of string rather than counting it via multiple sprintfs;
5259 that's simpler and more reliable.
5260 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5261 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5262 sprintf, in case result does not fit in int.
5264 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5265 (fontset_from_font): Print it.
5267 * frame.c (tty_frame_count): Now printmax_t, not int.
5268 (make_terminal_frame, set_term_frame_name): Print it.
5269 (x_report_frame_params): In X, window IDs are unsigned long,
5270 not signed long, so print them as unsigned.
5271 (validate_x_resource_name): Check for implausibly long names,
5272 and don't assume name length fits in 'int'.
5273 (x_get_resource_string): Don't blindly alloca invocation name;
5274 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5277 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5278 (xg_check_special_colors, xg_set_geometry):
5279 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5281 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5282 Use esprintf, not sprintf, in case result does not fit in int.
5284 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5285 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5286 it as a large positive number.
5287 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5288 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5290 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5291 in case result does not fit in int.
5293 * print.c (float_to_string): Detect width overflow more reliably.
5294 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5295 buffer overrun. Don't assume list length fits in 'int'. Treat
5296 print length of 0 as 0, not as infinity; to be consistent with other
5297 uses of print length in this function. Don't overflow print length
5298 index. Don't assume hash table size fits in 'long', or that
5299 vectorlike size fits in 'unsigned long'.
5301 * process.c (make_process): Use printmax_t, not int, to format
5302 process-name gensyms.
5304 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5306 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5307 to avoid potential buffer overrun.
5309 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5310 if X resource line is longer than 512 bytes.
5312 * xfns.c (x_window): Make sprintf buffer a bit bigger
5313 to avoid potential buffer overrun.
5315 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5317 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5319 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5321 Integer overflow fixes for scrolling, etc.
5322 Without these, Emacs silently mishandles large integers sometimes.
5323 For example, "C-u 4294967297 M-x recenter" was treated as if
5324 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5326 * xdisp.c (try_window_id): Check Emacs fixnum range before
5327 converting to 'int'.
5329 * window.c (window_scroll_line_based, Frecenter):
5330 Check that an Emacs fixnum is in range before assigning it to 'int'.
5331 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5332 values converted from Emacs fixnums.
5333 (Frecenter): Don't wrap around a line count if it is out of 'int'
5334 range; instead, treat it as an extreme value.
5335 (Fset_window_configuration, compare_window_configurations):
5336 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5338 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5339 that can exceed INT_MAX. Check that EMACS_INT value is in range
5340 before assigning it to the (possibly-narrower) index.
5341 (match_limit): Don't assume that a fixnum can fit in 'int'.
5343 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5346 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5347 (Fvertical_motion): Don't wrap around LINES values that don't fit
5348 in 'int'. Instead, treat them as extreme values. This is good
5349 enough for windows, which can't have more than INT_MAX lines anyway.
5351 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5353 * Require libxml/parser.h to avoid compilation warning.
5355 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5357 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5358 since this reportedly can destroy thread storage.
5360 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5362 * syntax.c (find_defun_start): Update all cache variables if
5363 exiting early (Bug#9401).
5365 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5367 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5369 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5370 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5371 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5373 * term.c (tty_append_glyph): New function.
5374 (produce_stretch_glyph): Static function and its prototype deleted.
5376 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5379 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5381 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5382 when checking :margin (Bug#9390).
5383 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5384 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5385 so that the name doesn't mislead. All uses changed.
5387 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5389 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5392 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5394 * xdisp.c (move_it_to): Don't bail out early when reaching
5395 position beyond to_charpos, if we are scanning backwards.
5396 (move_it_vertically_backward): When DY == 0, make sure we get to
5397 the first character in the line after the newline.
5399 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5401 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5402 (ccl_driver): Do not generate an out-of-range pointer.
5403 (Fccl_execute_on_string): Remove unnecessary check for
5404 integer overflow, noted by Stefan Monnier in
5405 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5406 Remove a FIXME that didn't need fixing.
5407 Simplify the newly-introduced buffer reallocation code.
5409 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5411 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5413 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5415 Integer and memory overflow issues (Bug#9196).
5417 * doc.c (get_doc_string): Rework so that
5418 get_doc_string_buffer_size is the actual buffer size, rather than
5419 being 1 less than the actual buffer size; this makes xpalloc more
5422 * image.c (x_allocate_bitmap_record, cache_image):
5423 * xselect.c (Fx_register_dnd_atom):
5424 Simplify previous changes by using xpalloc.
5426 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5427 since either will do and ptrdiff_t is convenient with xpalloc.
5429 * charset.c (charset_table_size)
5430 (struct charset_sort_data.priority): Now ptrdiff_t.
5431 (charset_compare): Don't overflow if priorities differ greatly.
5432 (Fsort_charsets): Don't assume list length fits in int.
5433 Check for size-calculation overflow when allocating sort data.
5434 (syms_of_charset): Allocate an initial charset table that is
5435 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5437 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5439 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5440 The actual value is always <= INT_MAX, and leaving it unsigned made
5441 overflow checking harder.
5443 * dispextern.h (struct glyph_matrix.rows_allocated)
5444 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5445 with xpalloc. The values are still always <= INT_MAX.
5447 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5449 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5450 (SAFE_NALLOCA): New macro.
5452 * region-cache.c (struct boundary.pos, find_cache_boundary)
5453 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5454 (set_cache_region, invalidate_region_cache)
5455 (revalidate_region_cache, know_region_cache, region_cache_forward)
5456 (region_cache_backward, pp_cache):
5457 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5458 so that ptrdiff_t * can be passed to xpalloc.
5459 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5460 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5461 (pp_cache): Don't assume cache_len fits in int.
5462 * region-cache.h: Adjust extern decls to match.
5464 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5465 EMACS_INT, since either will do, for xpalloc.
5467 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5468 (xnmalloc, xnrealloc, xpalloc): New functions.
5470 * bidi.c (bidi_shelve_header_size): New constant.
5471 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5472 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5474 * bidi.c (bidi_cache_shrink):
5475 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5477 Don't update size of array until after memory allocation succeeds,
5478 because xmalloc/xrealloc may not return.
5479 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5480 now that we have proper integer overflow checking.
5481 (record_overlay_string, overlay_strings): Catch overflows when
5482 calculating size of overlay_str_buf.
5484 * callproc.c (Fcall_process): Check for size overflow when
5485 calculating size of args2.
5486 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5487 Normally we prefer signed values, but sticking with ptrdiff_t would
5488 require adding more-complicated checks.
5490 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5491 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5492 Redo buffer-overflow calculations to avoid integer overflow.
5493 Add a FIXME comment where memory seems to be over-allocated.
5495 * character.c (Fstring): Check for size-calculation overflow.
5497 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5498 unnecessary integer overflow. Check for size overflow.
5499 (encode_coding_object): Don't update size until xmalloc succeeds.
5501 * composite.c (get_composition_id): Check for overflow in glyph
5502 length calculations.
5504 Integer and memory overflow fixes for display code.
5505 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5506 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5507 (scrolling_window): Check for overflow in size calculations.
5508 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5509 Don't assume glyph table len fits in int.
5510 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5511 (row_table_size): Now ptrdiff_t, not int.
5512 (scrolling_window): Avoid overflow in size calculations.
5513 Don't update size until allocation succeeds.
5514 * fns.c (concat): Check for overflow in size calculations.
5515 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5516 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5517 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5519 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5520 (get_doc_string): Check for size calculation overflow.
5521 Don't update size until allocation succeeds.
5522 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5523 EMACS_INT, where ptrdiff_t will do.
5524 (Fsubstitute_command_keys): Check for string overflow.
5526 * editfns.c (set_time_zone_rule): Don't assume environment length
5528 (message_length): Now ptrdiff_t, not int.
5529 (Fmessage_box): Don't update size until allocation succeeds.
5530 Don't assume message length fits in int.
5531 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5533 * emacs.c (main): Do not reallocate argv, since there is a null at
5534 the end that can be overwritten, and this way there's no need to
5535 worry about size-calculation overflow.
5536 (sort_args): Check for size-calculation overflow.
5538 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5540 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5542 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5543 (x_set_scroll_bar_width, x_figure_window_size):
5544 Check for integer overflow.
5545 (x_set_alpha): Do not assume XINT fits in int.
5547 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5548 This is for the members text_lines, text_cols, total_lines, total_cols,
5549 where the system imposes an 'int' limit.
5551 * fringe.c (Fdefine_fringe_bitmap):
5552 Don't update size until alloc works.
5554 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5555 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5557 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5558 Check for size-calculation overflow.
5559 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5560 do, as we prefer signed integers.
5561 (id_to_widget.max_size, id_to_widget.used)
5562 (xg_store_widget_in_map, xg_remove_widget_from_map)
5563 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5564 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5565 Use and return ptrdiff_t, not int.
5566 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5567 * gtkutil.h: Change prototypes to match the above.
5569 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5570 are duplicate now that they've been promoted to lisp.h.
5571 (x_allocate_bitmap_record, x_alloc_image_color)
5572 (make_image_cache, cache_image, xpm_load):
5573 Don't update size until alloc is done.
5574 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5576 Check for size calculation overflow.
5577 (ct_colors_allocated_max): New constant.
5578 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5581 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5582 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5583 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5584 Use ptrdiff_t, not int, to count maps.
5585 (read_char_minibuf_menu_prompt): Check for overflow in size
5586 calculations. Don't update size until allocation succeeds.
5587 Redo calculations to avoid overflow.
5588 * keyboard.h: Change prototypes to match the above.
5590 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5592 (current_minor_maps): Check for size calculation overflow.
5593 * keymap.h: Change prototypes to match the above.
5595 * lread.c (read1, init_obarray): Don't update size until alloc done.
5597 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5598 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5600 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5601 Now ptrdiff_t, not int.
5602 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5603 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5605 * process.c (Fnetwork_interface_list): Check for overflow
5606 in size calculation.
5608 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5610 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5611 overflow. Don't bother calling xmalloc when xrealloc will do.
5613 * search.c (Freplace_match): Check for size calculation overflow.
5614 (Fset_match_data): Don't assume list lengths fit in 'int'.
5616 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5617 for command line length. Do not attempt to address one before the
5618 beginning of an array, as that's not portable.
5620 * term.c (max_frame_lines): Remove; unused.
5621 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5623 (encode_terminal_code, calculate_costs): Check for size
5624 calculation overflow.
5625 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5626 table lengths and related sizes. Don't update size until alloc
5627 done. Redo calculations to avoid overflow.
5628 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5630 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5631 subtracting pointers.
5632 (gobble_line): Check for overflow more carefully. Don't update size
5635 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5636 Don't update size until alloc done.
5637 Redo size calculations to avoid overflow.
5638 Check for size calculation overflow.
5639 (main) [DEBUG]: Fix typo in invoking tparam1.
5641 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5642 Use ptrdiff_t, not int, for sizes.
5643 (store_mode_line_noprop_char): Don't update size until alloc done.
5645 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5646 Use ptrdiff_t, not int, for sizes.
5647 (Finternal_make_lisp_face, cache_face):
5648 Check for size calculation overflow.
5649 (cache_face): Treat size calculation overflows as if they were
5650 memory exhaustion (the usual treatment), rather than aborting.
5652 * xfns.c (x_encode_text, x_set_name_internal)
5653 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5654 sizes, since they can exceed INT_MAX in size. Check for size
5655 calculation overflow.
5657 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5658 (xg_select): Check for size calculation overflow.
5659 Don't update size until alloc done.
5661 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5662 as sprintf is limited to int lengths.
5664 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5665 (X_LONG_MIN): New macros.
5666 Use them to make the following changes clearer.
5667 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5668 This change doesn't affect the value now, but it may help remind
5669 future maintainers not to raise the value too much later.
5670 (SELECTION_QUANTUM): Remove, replacing with ...
5671 (selection_quantum): ... new function, which avoids overflow.
5673 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5674 assumption that selection length fits in 'int'.
5675 (x_reply_selection_request, x_handle_selection_request)
5676 (x_get_window_property, receive_incremental_selection)
5677 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5678 (lisp_data_to_selection_data, clean_local_selection_data):
5679 Use ptrdiff_t, not int, to record length of selection.
5680 (x_reply_selection_request, x_get_window_property)
5681 (receive_incremental_selection, x_property_data_to_lisp):
5682 Redo calculations to avoid overflow.
5683 (x_reply_selection_request): When sending hint, ceiling it at
5684 X_LONG_MAX rather than relying on wraparound overflow to send
5686 (x_get_window_property, receive_incremental_selection)
5687 (lisp_data_to_selection_data, x_property_data_to_lisp):
5688 Check for size-calculation overflow.
5689 (x_get_window_property, receive_incremental_selection)
5690 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5691 Don't store size until memory allocation succeeds.
5692 (x_get_window_property): Plug memory leak on memory exhaustion.
5693 Don't double-block input; malloc is safe here. Don't assume 2**34
5694 - 4 fits in unsigned long. Add an xassert to check
5695 XGetWindowProperty overflow. Be more careful about overflow
5696 calculations, and distinguish size from memory overflow better.
5697 (receive_incremental_selection): When tracing, don't assume
5698 unsigned int is less than INT_MAX.
5699 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5700 harmful) conversions of unsigned short to int.
5701 (lisp_data_to_selection_data): Don't assume that integers
5702 in the range -65535 through -1 fit in an X unsigned short.
5703 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5704 result parameters unless successful. Rely on cons_to_unsigned
5705 to report problems with elements; the old code wasn't right anyway.
5706 (x_check_property_data): Check for int overflow; we cannot use
5707 a wider type due to X limits.
5708 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5710 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5712 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5713 (x_term_init): Check for size calculation overflow.
5714 (x_color_cells): Don't store size until memory allocation succeeds.
5715 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5716 Don't assume alloca size is less than MAX_ALLOCA.
5717 (x_term_init): Don't assume length fits in int (sprintf is limited
5720 Use ptrdiff_t for composition IDs.
5721 * character.c (lisp_string_width):
5722 * composite.c (composition_table_size, n_compositions)
5723 (get_composition_id, composition_gstring_from_id):
5724 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5725 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5726 * window.c (Frecenter):
5727 Use ptrdiff_t, not int, for composition IDs.
5728 * composite.c (get_composition_id): Check for integer overflow.
5729 * composite.h: Adjust prototypes to match the above changes.
5731 Use ptrdiff_t for hash table indexes.
5732 * category.c (hash_get_category_set):
5733 * ccl.c (ccl_driver):
5734 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5735 * coding.c (coding_system_charset_list, detect_coding_system):
5736 * coding.h (struct coding_system.id):
5737 * composite.c (get_composition_id, gstring_lookup_cache):
5738 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5739 * image.c (xpm_get_color_table_h):
5740 * lisp.h (hash_lookup, hash_put):
5741 * minibuf.c (Ftest_completion):
5742 Use ptrdiff_t for hash table indexes, not int (which is too
5743 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5744 32-bit --with-wide-int hosts).
5746 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5747 Add a FIXME comment about memory leaks.
5748 (syms_of_charset): Don't assume xmalloc returns.
5750 Don't assume that stated character widths fit in int.
5751 * character.c (Fchar_width, c_string_width, lisp_string_width):
5752 * character.h (CHAR_WIDTH):
5753 * indent.c (MULTIBYTE_BYTES_WIDTH):
5754 Use sanitize_char_width to avoid undefined and/or bad behavior
5755 with outlandish widths.
5756 * character.h (sanitize_tab_width): Rename from sanitize_width,
5757 now that we have two such functions. All uses changed.
5758 (sanitize_char_width): New inline function.
5760 Don't assume that tab-width fits in int.
5761 * character.h (sanitize_width): New inline function.
5762 (SANE_TAB_WIDTH): New macro.
5763 (ASCII_CHAR_WIDTH): Use it.
5764 * indent.c (sane_tab_width): Remove. All uses replaced by
5765 SANE_TAB_WIDTH (current_buffer).
5766 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5768 * fileio.c: Integer overflow issues with file modes.
5769 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5771 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5772 Remove unreachable code.
5773 (read_hex, load_charset_map_from_file): Check for integer overflow.
5775 * xterm.c: Don't go over XClientMessageEvent limit.
5776 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5777 (x_send_scroll_bar_event): Likewise. Check that the size does not
5778 exceed limits imposed by XClientMessageEvent, as well as the usual
5779 ptrdiff_t and size_t limits.
5781 * keyboard.c: Overflow, signedness and related fixes.
5782 (make_lispy_movement): Use same integer type in forward decl
5783 that is used in the definition.
5784 (read_key_sequence, keyremap_step):
5785 Change bufsize argument back to int, undoing my 2011-03-30 change.
5786 We prefer signed types, and int is wide enough here.
5787 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5788 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5789 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5790 length, not size_t. Use ptrdiff_t for index, not int.
5791 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5792 possibility of integer overflow.
5794 Overflow, signedness and related fixes for images.
5796 * dispextern.h (struct it.stack[0].u.image.image_id)
5797 (struct_it.image_id, struct image.id, struct image_cache.size)
5798 (struct image_cache.used, struct image_cache.ref_count):
5799 * gtkutil.c (update_frame_tool_bar):
5800 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5801 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5802 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5803 * nsmenu.m (update_frame_tool_bar):
5804 * xdisp.c (calc_pixel_width_or_height):
5805 * xfns.c (image_cache_refcount):
5806 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5807 on typical 64-bit hosts.
5809 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5810 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5811 Omit unnecessary casts to int.
5812 (parse_image_spec): Check that integers fall into 'int' range
5813 when the callers expect that.
5814 (image_ascent): Redo ascent calculation to avoid int overflow.
5815 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5816 (lookup_image): Remove unnecessary tests.
5817 (xbm_image_p): Locals are now of int, not EMACS_INT,
5818 since parse_image_check makes sure they fit into int.
5819 (png_load, gif_load, svg_load_image):
5820 Prefer int to unsigned where either will do.
5821 (tiff_handler): New function, combining the cores of the
5822 old tiff_error_handler and tiff_warning_handler.
5823 This function is rewritten to use vsnprintf and thereby avoid
5824 stack buffer overflows. It uses only the features of vsnprintf
5825 that are common to both POSIX and native Microsoft.
5826 (tiff_error_handler, tiff_warning_handler): Use it.
5827 (tiff_load, gif_load, imagemagick_load_image):
5828 Don't assume :index value fits in 'int'.
5829 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5830 (imagemagick_load_image): Check that crop parameters fit into
5831 the integer types that MagickCropImage accepts. Don't assume
5832 Vimagemagick_render_type has a nonnegative value. Don't assume
5833 size_t fits in 'long'.
5834 (gs_load): Use printmax_t to print the widest integers possible.
5835 Check for integer overflow when computing image height and width.
5837 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5839 * xdisp.c (redisplay_window): Don't force window start if point
5840 will be invisible in the resulting window. (Bug#9324)
5842 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5844 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5845 the display spec is of the form `(space ...)'.
5846 (handle_display_spec): Return the value returned by
5847 handle_single_display_spec, not just 1 or zero.
5848 (handle_single_display_spec): If the display spec is of the form
5849 `(space ...)', and specifies display in the text area, return 2
5851 (try_cursor_movement): Check for the need to scroll more
5852 accurately, and prefer exact match for point under bidi.
5853 Don't advance `row' beyond the last row of the window.
5855 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5856 into disp_prop; all users changed.
5858 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5859 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5860 for the text covered by the display property.
5862 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5864 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5865 Change return value to nil.
5866 (Frecord_buffer): Delete unused function.
5868 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5870 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5871 buffers, return left-to-right.
5872 (set_cursor_from_row): Consider candidate row a win if its glyph
5873 represents a newline and point is on that newline. Fixes cursor
5874 positioning on the newline at EOL of R2L text within L2R
5875 paragraph, and vice versa.
5876 (try_cursor_movement): Check continued rows, in addition to
5877 continuation rows. Fixes unwarranted scroll when point enters a
5878 continued line of R2L text within an L2R paragraph, or vice versa.
5879 (cursor_row_p): Consider the case of point being equal to
5880 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5881 from the end of a short line to the beginning of a continued line
5882 of R2L text within L2R paragraph.
5883 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5884 composed characters.
5886 * bidi.c (bidi_check_type): Use xassert.
5887 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5890 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5892 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5895 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5897 * nsfont.m (ns_otf_to_script): Fix typo.
5899 2011-08-22 Kenichi Handa <handa@m17n.org>
5901 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5902 extra slot even if the purpose is char-code-property-table.
5904 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5906 * xdisp.c (redisplay_window): When computing centering_position,
5907 account for the height of the header line. (Bug#8874)
5909 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5910 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5911 candidate is selected by the mouse, and that candidate has a
5912 composed character under the mouse.
5914 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5915 coordinates reported by pos-visible-in-window-p for a composed
5916 character in column zero.
5918 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5920 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5922 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5924 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5925 consider it a hit if to_charpos is anywhere in the range of the
5926 composed buffer positions.
5928 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5930 * image.c (gif_load): Don't assume that each subimage has the same
5931 dimensions as the base image. Handle disposal method that is
5932 "undefined" by the gif spec (Bug#9335).
5934 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5936 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5937 (Fcondition_case): Document `debug' symbol in error handler.
5939 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5941 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5942 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5943 from an Org mode buffer to a Speedbar frame.
5945 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5946 a composition, take its buffer position from IT->cmp_it.charpos.
5947 Fixes cursor positioning at the beginning of a line that begins
5948 with a composed character.
5950 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5952 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5953 character bidirectional type, use STRONG_L instead. Fixes crashes
5954 in a buffer produced by `describe-categories'.
5956 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5957 members before the level stack, so they would be saved and
5958 restored when copying iterator state. Fixes incorrect reordering
5959 around TABs covered by display properties.
5961 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5963 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5965 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5967 * eval.c (internal_condition_case, internal_condition_case_1)
5968 (internal_condition_case_2, internal_condition_case_n):
5969 Remove unnecessary aborts (Bug#9081).
5971 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5973 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5974 has no `load' handler, try opening the file locally. (Bug#9311)
5976 2011-08-16 Ken Brown <kbrown@cornell.edu>
5978 * gmalloc.c: Expand comment.
5980 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5982 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5983 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5985 2011-08-16 Ken Brown <kbrown@cornell.edu>
5987 Fix memory allocation problems in Cygwin build (Bug#9273).
5989 * unexcw.c ( __malloc_initialized): Declare external variable.
5990 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5992 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5994 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5996 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5998 [CYGWIN] (special_realloc): New function.
5999 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6000 requests to realloc storage in the static heap.
6002 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6004 * bidi.c (bidi_initialize): Remove unused local.
6006 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6009 * biditype.h: Remove file.
6010 * makefile.w32-in ($(BLD)/bidi.$(O)):
6011 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6013 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6015 * chartab.c: Improve commentary for the uniprop_table API.
6017 * bidi.c (bidi_paragraph_init): Support zero value of
6018 bidi_ignore_explicit_marks_for_paragraph_level.
6019 (bidi_initialize): Use uniprop_table instead of including
6020 biditype.h and bidimirror.h.
6022 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6023 coordinates of the iterator when restoring from ppos_it.
6026 2011-08-14 Kenichi Handa <handa@m17n.org>
6028 * process.c (create_process): Call setup_process_coding_systems
6029 after the pid of the process is set to -1 (Bug#8162).
6031 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6033 * xdisp.c (move_it_in_display_line_to): Don't invoke
6034 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6035 ppos_it. Fixes vertical cursor motion when line beginning is
6036 covered by an image. (Bug#9296)
6038 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6040 * nsterm.h (ns_run_ascript): Declare.
6041 (NSAPP_DATA2_RUNASSCRIPT): Define.
6043 * nsfns.m (as_script, as_result, as_status): New static variables.
6044 (ns_run_ascript): New function.
6045 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6046 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6047 the event loop. Get status from as_status (Bug#7276).
6049 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6050 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6051 the event loop (Bug#7276).
6053 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6055 * gnutls.c (QCgnutls_bootprop_priority)
6056 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6057 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6058 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6059 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6060 (QCgnutls_bootprop_verify_hostname_error)
6061 (QCgnutls_bootprop_callbacks_verify): Rename from
6062 Qgnutls_bootprop_..., all uses changed.
6064 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6067 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6069 * xfaces.c (Qframe_set_background_mode): Now static.
6070 * dispextern.h (Qframe_set_background_mode): Remove decl.
6072 * process.c (Fnetwork_interface_info): Declare local only if needed.
6074 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6076 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6077 (Fnetwork_interface_list): Allocate in increments of bytes instead
6078 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6079 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6081 (struct ifflag_def): notrailers is smart on OSX.
6082 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6083 Get hardware address with getifaddrs if available.
6085 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6087 * xdisp.c (iterate_out_of_display_property): xassert that
6088 IT->position is set to within IT->object's boundaries. Break from
6089 the loop as soon as EOB is reached; avoids infloops in redisplay
6090 when IT->position is set up wrongly due to some bug.
6091 Set IT->current to match the bidi iterator unconditionally.
6092 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6093 entry. Force push_it to save on the stack the current
6094 buffer/string position, to be restored by pop_it. Fix flags in
6095 the iterator structure wrt the object coming from a display
6096 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6097 properties. (Bug#9284)
6099 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6101 * fontset.c (fontset_get_font_group): Add proper type checks.
6104 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6106 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6107 and LC_VERSION_MIN_MACOSX.
6108 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6109 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6111 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6113 * xdisp.c (forward_to_next_line_start): Allow to use the
6114 no-display-properties-and-no-overlays under bidi display.
6115 Set disp_pos in the bidi iterator to avoid searches for display
6116 properties and overlays.
6118 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6120 * editfns.c (Fset_time_zone_rule): Document relationship with the
6123 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6124 the font entity extracted from the cache (Bug#8109).
6126 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6128 * composite.c (autocmp_chars): Don't reset point. That is done by
6129 restore_point_unwind (Bug#5984).
6131 2011-08-07 Juri Linkov <juri@jurta.org>
6133 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6134 to show the arg `TIME' instead of `TIMEVAL'.
6136 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6138 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6139 display property strides EOL and includes a newline, as in
6140 longlines-mode. (Bug#9254)
6141 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6142 word-wrap under bidirectional display. (Bug#9224)
6144 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6145 is non-zero, even if the data buffer is NULL. Fixes a crash in
6146 vertical-motion with longlines-mode. (Bug#9254)
6148 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6150 * bidi.c <bidi_cache_total_alloc>: Now static.
6151 (bidi_initialize): Initialize bidi_cache_total_alloc.
6153 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6156 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6157 amount allocated this far in `bidi_cache_total_alloc'.
6158 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6159 non-zero, only free the data buffer without restoring the cache
6160 contents. All callers changed.
6162 * dispextern.h (bidi_unshelve_cache): Update prototype.
6164 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6165 (move_it_in_display_line, move_it_to)
6166 (move_it_vertically_backward, move_it_by_lines): Replace the call
6167 to xfree to an equivalent call to bidi_unshelve_cache.
6168 (move_it_in_display_line_to): Fix logic of returning
6169 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6171 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6173 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6174 came from a string character with a `cursor' property. (Bug#9229)
6176 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6178 * Makefile.in (LIB_PTHREAD): New variable.
6179 (LIBES): Add LIB_PTHREAD (Bug#9216).
6181 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6182 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6184 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6186 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6188 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6190 * xterm.c (x_find_topmost_parent): New function.
6191 (x_set_frame_alpha): Find topmost parent window with
6192 x_find_topmost_parent and set the property there also (bug#9181).
6193 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6195 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6197 * callproc.c (Fcall_process): Avoid vfork clobbering
6198 the local vars buffer, coding_systems, current_dir.
6200 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6202 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6204 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6206 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6207 so that it is not optimized away.
6209 * xdisp.c (compute_display_string_pos): Remove unused local.
6211 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6213 Fix slow cursor motion and scrolling in large buffers with
6214 selective display, like Org Mode buffers. (Bug#9218)
6216 * dispextern.h (struct bidi_it): New member disp_prop_p.
6218 * xdisp.c: Remove one-slot cache of display string positions.
6219 (compute_display_string_pos): Accept an additional argument
6220 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6221 for a display string or property. If found, set DISP_PROP_P
6224 * bidi.c (bidi_fetch_char): Accept an additional argument
6225 DISP_PROP_P, and pass it to compute_display_string_pos.
6226 Only handle text covered by a display string if DISP_PROP_P is returned
6227 non-zero. All callers of bidi_fetch_char changed.
6229 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6231 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6233 2010-12-03 Don March <don@ohspite.net>
6235 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6236 last character M-[char] is translated to ESC [char] (bug#7541).
6238 2011-08-02 Kenichi Handa <handa@m17n.org>
6240 * lisp.h (uniprop_table): Extern it.
6242 * chartab.c (uniprop_table): Make it non-static.
6244 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6246 * xdisp.c (forward_to_next_line_start): Accept additional argument
6247 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6249 (reseat_at_next_visible_line_start): Use the bidi iterator state
6250 returned by forward_to_next_line_start to restore the state of
6251 it->bidi_it after backing up to previous newline. (Bug#9212)
6253 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6255 * regex.c (re_comp): Protoize.
6256 (re_exec): Fix return type.
6257 (regexec): Fix type of `ret'. (Bug#9203)
6259 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6261 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6262 This is needed if max-image-size is a floating-point number.
6264 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6266 * print.c (print_object): Print empty symbol as ##.
6268 * lread.c (read1): Read ## as empty symbol.
6270 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6272 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6273 setting frame foreground color (Bug#9175).
6274 (x_set_background_color): Likewise.
6276 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6277 contents (Bug#9176).
6278 (EmacsTooltip -init): Remove bezels and add shadows to
6281 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6282 or scroll bar (Bug#8470).
6284 * nsfont.m (nsfont_open): Remove assignment to voffset and
6285 unnecessary vars hshink, expand, hd, full_height, min_height.
6286 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6288 * nsterm.h (nsfont_info): Remove voffset field.
6290 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6292 Implement strike-through and overline on NextStep (Bug#8863).
6294 * nsfont.m (nsfont_open): Use underline position provided by font,
6295 instead of hard-coded value of 2.
6296 (nsfont_draw): Call ns_draw_text_decoration instead.
6298 * nsterm.h: Add declaration for ns_draw_text_decoration.
6300 * nsterm.m (ns_draw_text_decoration): New function for drawing
6301 underline, overline, and strike-through.
6302 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6303 ns_draw_text_decoration. Change treatment of cursor drawing to
6304 accommodate underlining, etc.
6306 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6308 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6311 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6313 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6314 Without this fix, if a signal arrives just after memory fills up,
6315 'malloc' might be invoked reentrantly.
6317 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6318 In other words, assume that every image size is allowed, on non-X
6319 hosts. This assumption is probably wrong, but it lets Emacs compile.
6321 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6323 * regex.c (re_iswctype): Convert return values to boolean.
6325 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6327 * xdisp.c (compute_display_string_pos): Don't use cached display
6328 string position if the buffer had its restriction changed.
6331 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6333 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6335 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6337 Integer signedness and overflow and related fixes. (Bug#9079)
6339 * bidi.c: Integer size and overflow fixes.
6340 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6341 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6342 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6343 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6344 (bidi_find_other_level_edge):
6345 Use ptrdiff_t instead of EMACS_INT where either will do.
6346 This works better on 32-bit hosts configured --with-wide-int.
6347 (bidi_cache_ensure_space): Check for size-calculation overflow.
6348 Use % rather than repeated addition, for better worst-case speed.
6349 Don't set bidi_cache_size until after xrealloc returns, because it
6351 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6352 (bidi_cache_ensure_space): Also check that the bidi cache size
6353 does not exceed that of the largest Lisp string or buffer. See Eli
6354 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6356 * alloc.c (__malloc_size_t): Remove.
6357 All uses replaced by size_t. See Andreas Schwab's note
6358 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6360 * image.c: Improve checking for integer overflow.
6361 (check_image_size): Assume that f is nonnull, since
6362 it is always nonnull in practice. This is one less thing to
6363 worry about when checking for integer overflow later.
6364 (x_check_image_size): New function, which checks for integer
6365 overflow issues inside X.
6366 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6367 This removes the need for a memory_full check.
6368 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6369 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6370 (xbm_read_bitmap_data): Change locals back to 'int', since
6371 their values must fit in 'int'.
6372 (xpm_load_image, png_load, tiff_load):
6373 Invoke x_create_x_image_and_pixmap earlier,
6374 to avoid much needless work if the image is too large.
6375 (tiff_load): Treat overly large images as if
6376 x_create_x_image_and_pixmap failed, not as malloc failures.
6377 (gs_load): Use x_check_image_size.
6379 * gtkutil.c: Omit integer casts.
6380 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6381 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6383 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6385 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6386 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6387 would wrongly return t on a 64-bit host.
6389 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6390 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6391 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6392 and therefore cause GCC to emit a bogus diagnostic in some cases.
6394 * image.c: Integer signedness and overflow and related fixes.
6395 This is not an exhaustive set of fixes, but it's time to
6396 record what I've got.
6397 (lookup_pixel_color, check_image_size): Remove redundant decls.
6398 (check_image_size): Don't assume that arbitrary EMACS_INT values
6399 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6400 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6401 (tiff_load, imagemagick_load_image):
6402 Check for overflow in size calculations.
6403 (x_create_x_image_and_pixmap): Remove unnecessary test for
6404 xmalloc returning NULL; that can't happen.
6405 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6406 (xpm_color_bucket): Use better integer hashing function.
6407 (xpm_cache_color): Don't possibly over-allocate memory.
6408 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6409 (gif_memory_source):
6410 Use ptrdiff_t, not int or size_t, to record sizes.
6411 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6412 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6413 either works, as we prefer signed integers.
6414 (tiff_read_from_memory, tiff_write_from_memory):
6415 Return tsize_t, not size_t, since that's what the TIFF API wants.
6416 (tiff_read_from_memory): Don't fail simply because the read would
6417 go past EOF; instead, return a short read.
6418 (tiff_load): Omit no-longer-needed casts.
6419 (Fimagemagick_types): Don't assume size fits into 'int'.
6421 Improve hashing quality when configured --with-wide-int.
6422 * fns.c (hash_string): New function, taken from sxhash_string.
6423 Do not discard information about ASCII character case; this
6424 discarding is no longer needed.
6425 (sxhash-string): Use it. Change sig to match it. Caller changed.
6426 * lisp.h: Declare it.
6427 * lread.c (hash_string): Remove, since we now use fns.c's version.
6428 The fns.c version returns a wider integer if --with-wide-int is
6429 specified, so this should help the quality of the hashing a bit.
6431 * emacs.c: Integer overflow minor fix.
6432 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6433 Define only if GNU_LINUX.
6434 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6436 * dispnew.c: Integer signedness and overflow fixes.
6437 Remove unnecessary forward decls, that were a maintenance hassle.
6438 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6440 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6441 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6442 (prepare_desired_row, line_draw_cost):
6443 Use int, not unsigned, where either works.
6444 (save_current_matrix, restore_current_matrix):
6445 Use ptrdiff_t, not size_t, where either works.
6446 (init_display): Check for overflow more accurately, and without
6447 relying on undefined behavior.
6449 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6450 Remove, replacing with the new symbols in lisp.h. All uses changed.
6451 * fileio.c (make_temp_name):
6452 * filelock.c (lock_file_1, lock_file):
6453 * xdisp.c (message_dolog):
6454 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6455 Use pMd etc. instead.
6456 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6457 replacing the pWIDE etc. symbols removed from editfns.c.
6459 * keyboard.h (num_input_events): Now uintmax_t.
6460 This is (very slightly) less likely to mess up due to wraparound.
6463 * buffer.c: Integer signedness fixes.
6464 (alloc_buffer_text, enlarge_buffer_text):
6465 Use ptrdiff_t rather than size_t when either will do, as we prefer
6468 * alloc.c: Integer signedness and overflow fixes.
6469 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6470 (__malloc_size_t): Default to size_t, not to int.
6471 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6472 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6473 Prefer ptrdiff_t to size_t when either would do, as we prefer
6475 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6476 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6477 Now const. Initialize with values that are in range even if char
6479 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6480 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6481 These functions do the right thing with sizes > 2**32.
6482 (check_depth): Now ptrdiff_t, not int.
6483 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6484 Adjust to new way of storing sizes. Check for size overflow bugs
6486 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6487 slightly wrong anyway, as it missed one instance of
6488 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6489 (refill_memory_reserve): Omit needless cast to size_t.
6490 (mark_object_loop_halt): Mark as externally visible.
6492 * xselect.c: Integer signedness and overflow fixes.
6493 (Fx_register_dnd_atom, x_handle_dnd_message):
6494 Use ptrdiff_t, not size_t, since we prefer signed.
6495 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6496 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6497 x_dnd_atoms_size and x_dnd_atoms_length.
6499 * doprnt.c: Prefer signed to unsigned when either works.
6501 * doprnt.c (doprnt):
6503 * xdisp.c (vmessage):
6504 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6505 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6506 prefer signed arithmetic to avoid comparison confusion.
6507 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6508 but is a bit tricky.
6510 Assume freestanding C89 headers, string.h, stdlib.h.
6511 * data.c, doprnt.c, floatfns.c, print.c:
6512 Include float.h unconditionally.
6513 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6514 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6515 * regex.c: Likewise for stddef.h, string.h.
6516 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6517 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6518 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6519 (STDC_HEADERS): Remove obsolete defines.
6520 * sysdep.c: Include limits.h unconditionally.
6522 Assume support for memcmp, memcpy, memmove, memset.
6523 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6524 * regex.c (memcmp, memcpy):
6525 Remove; we assume C89 now.
6527 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6528 (__malloc_safe_bcopy): Remove; no longer needed.
6530 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6531 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6532 well either way, and we prefer signed to unsigned.
6534 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6536 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6537 closes the connection while we're reading (bug#9182).
6539 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6541 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6542 are specified (Bug#9168).
6544 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6546 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6547 Found by GCC static checking and --with-wide-int on a 32-bit host.
6549 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6551 * xdisp.c (compute_display_string_pos): Fix logic of caching
6552 previous display string position. Initialize cached_prev_pos to
6553 -1. Fixes slow-down at the beginning of a buffer.
6555 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6557 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6558 for attrs[LFACE_FONTSET_INDEX].
6560 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6562 * xml.c (parse_region): Remove unused local
6563 that was recently introduced.
6565 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6567 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6568 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6570 * xdisp.c (move_it_in_display_line_to): Record the best matching
6571 position for TO_CHARPOS while scanning the line, and restore it on
6572 exit if none of the characters scanned was an exact match.
6573 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6574 when exact match is impossible due to invisible text, and the
6575 lines are truncated.
6577 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6579 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6582 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6584 Fix a significant slow-down of cursor motion with C-n, C-p,
6585 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6586 auto-repeat under bidi redisplay in fontified buffers.
6587 * xdisp.c (compute_stop_pos_backwards): New function.
6588 (next_element_from_buffer): Call compute_stop_pos_backwards to
6589 find a suitable prev_stop when we find ourselves before
6591 (reseat): Don't look for prev_stop, as that could mean a very long
6593 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6594 <cached_disp_overlay_modiff>: Cache for last found display string
6596 (compute_display_string_pos): Return the cached position if asked
6597 about the same buffer in the same area of character positions, and
6598 the buffer wasn't changed since the time the display string
6599 position was cached.
6601 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6603 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6604 is an integer, which is important for empty lines. (Bug#9149)
6606 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6608 * frame.c (Fmodify_frame_parameters): In tty case, update the
6609 default face if necessary (Bug#4238).
6611 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6613 * editfns.c (Fstring_to_char): No need to explain what a character
6614 is in the docstring (Bug#6576).
6616 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6618 * xml.c (parse_region): Make sure we always return a tree.
6620 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6622 * xml.c (parse_region): If a document contains only comments,
6625 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6627 * xml.c (make_dom): Return comments, too.
6629 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6632 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6633 and the surrounding thread.
6634 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6635 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6636 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6638 * s/openbsd.h (BROKEN_SIGIO): Define.
6639 * unexelf.c (unexec) [__OpenBSD__]:
6640 Don't update the .mdebug section of the Alpha COFF symbol table.
6642 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6644 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6647 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6649 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6650 This fixes some race conditions on the permissions of any newly
6653 * alloc.c (valid_pointer_p): Use pipe, not open.
6654 This fixes some permissions issues when debugging.
6656 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6657 If fchown fails to set both uid and gid, try to set just gid,
6658 as that is sometimes allowed. Adjust the file's mode to eliminate
6659 setuid or setgid bits that are inappropriate if fchown fails.
6661 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6663 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6664 to compare Lisp_Objects.
6665 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6666 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6667 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6669 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6671 * lread.c (read_integer): Unread even EOF character.
6672 (read1): Likewise. Properly record start position of symbol.
6674 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6675 symbol character follows.
6677 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6679 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6680 This works around a problem with the previous change to Fcopy_file.
6681 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6682 and without this change, GCC might complain about discarding
6683 fchown's return value.
6685 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6687 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6689 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6691 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6693 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6695 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6696 it's used from the C level.
6698 * process.c: Use the same condition for POLL_FOR_INPUT in both
6699 keyboard.c and process.c (bug#1858).
6701 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6703 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6704 (Fgnutls_boot): Use it.
6706 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6708 * doc.c (Fsubstitute_command_keys): Revert last change.
6710 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6712 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6713 quotes the next character, and doesn't affect other longer
6714 sequences (bug#8935).
6716 * lread.c (syms_of_lread): Clarify that is isn't only
6717 `eval-buffer' and `eval-defun' that's affected by
6718 `lexical-binding' (bug#8460).
6720 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6722 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6723 bidi redisplay when a line includes both an image and is truncated.
6725 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6727 Fix minor problems found by static checking.
6728 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6729 (elsz): Now a signed constant, not a size_t var. We prefer signed
6730 types to unsigned, to avoid integer comparison confusion. Without
6731 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6732 "cannot optimize loop, the loop counter may overflow", a symptom
6734 * indent.c (Fvertical_motion): Mark locals as initialized.
6735 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6737 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6739 * search.c (Fre_search_backward): Mention `case-fold-search' in
6740 all the re_search_* functions (bug#8138).
6742 * keyboard.c (Fopen_dribble_file): Document when the file is
6745 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6747 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6750 Support bidi reordering of display and overlay strings.
6751 * xdisp.c (compute_display_string_pos)
6752 (compute_display_string_end): Accept additional argument STRING.
6753 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6754 (reseat_to_string): Initialize bidi_it->string.s and
6755 bidi_it->string.schars.
6756 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6757 NULL (avoids a crash in bidi_paragraph_init).
6758 Initialize itb.string.lstring.
6759 (init_iterator): Call bidi_init_it only of a valid
6760 buffer position was specified. Initialize paragraph_embedding to
6762 (reseat_to_string): Initialize the bidi iterator.
6763 (display_string): If we need to ignore text properties of
6764 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6765 original value of -1 will not work with bidi.)
6766 (compute_display_string_pos): First arg is now struct
6767 `text_pos *'; all callers changed. Support display properties on
6769 (compute_display_string_end): Support display properties on Lisp
6771 (init_iterator, reseat_1, reseat_to_string): Initialize the
6772 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6773 when iterating on a string not from display properties).
6774 (compute_display_string_pos, compute_display_string_end):
6775 Fix calculation of the object to scan. Fixes an error when using
6777 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6778 base_level_stop; instead, set base_level_stop to BEGV.
6779 Fixes crashes in vertical-motion.
6780 (next_element_from_buffer): Improve commentary for when
6781 the iterator is before prev_stop.
6782 (init_iterator): Initialize bidi_p from the default value of
6783 bidi-display-reordering, not from buffer-local value. Use the
6784 buffer-local value only if initializing for buffer iteration.
6785 (handle_invisible_prop): Support invisible properties on strings
6786 that are being bidi-reordered.
6787 (set_iterator_to_next): Support bidi reordering of C strings and
6789 (next_element_from_string): Support bidi reordering of Lisp
6791 (handle_stop_backwards): Support Lisp strings as well.
6792 (display_string): Support display of R2L glyph rows.
6793 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6794 (init_iterator): Don't initialize it->bidi_p for strings
6796 (reseat_to_string): Initialize it->bidi_p for strings here.
6797 (next_element_from_string, next_element_from_c_string)
6798 (next_element_from_buffer): Add xassert's for correspondence
6799 between IT's object being iterated and it->bidi_it.string
6801 (face_before_or_after_it_pos): Support bidi iteration.
6802 (next_element_from_c_string): Handle the case of the first string
6803 character that is not the first one in the visual order.
6804 (get_visually_first_element): New function, refactored from common
6805 parts of next_element_from_buffer, next_element_from_string, and
6806 next_element_from_c_string.
6807 (tool_bar_lines_needed, redisplay_tool_bar)
6808 (display_menu_bar): Force left-to-right direction. Add a FIXME
6809 comment for making that be controlled by a user option.
6810 (push_it, pop_it): Save and restore the state of the
6811 bidi iterator. Save and restore the bidi_p flag.
6812 (pop_it): Iterate out of display property for string iteration as
6814 (iterate_out_of_display_property): Support iteration over strings.
6815 (handle_single_display_spec): Set up it->bidi_it for iteration
6816 over a display string, and call bidi_init_it.
6817 (handle_single_display_spec, next_overlay_string)
6818 (get_overlay_strings_1, push_display_prop): Set up the bidi
6819 iterator for displaying display or overlay strings.
6820 (forward_to_next_line_start): Don't use the shortcut if
6822 (back_to_previous_visible_line_start): If handle_display_prop
6823 pushed the iterator stack, restore the internal state of the bidi
6824 iterator by calling bidi_pop_it same number of times.
6825 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6826 and we are bidi-iterating, don't decrement the iterator position;
6827 instead, set the first_elt flag in the bidi iterator, to produce
6829 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6830 (push_display_prop): xassert that we are iterating a buffer.
6831 (push_it, pop_it): Save and restore paragraph_embedding member.
6832 (handle_single_display_spec, next_overlay_string)
6833 (get_overlay_strings_1, reseat_1, reseat_to_string)
6834 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6835 correctly. Don't assume unibyte strings are not bidi-reordered.
6836 (compute_display_string_pos)
6837 (compute_display_string_end): Fix handling the case of C string.
6838 (push_it, pop_it): Save and restore from_disp_prop_p.
6839 (handle_single_display_spec, push_display_prop): Set the
6840 from_disp_prop_p flag.
6841 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6842 (pop_it): Call iterate_out_of_display_property only if we are
6843 popping after iteration over a string that came from a display
6844 property. Fix a typo in popping stretch info. Add an assertion
6845 for verifying that the iterator position is in sync with the bidi
6847 (handle_single_display_spec, get_overlay_strings_1)
6848 (push_display_prop): Fix initialization of paragraph direction for
6849 string when that of the parent object is not yet determined.
6850 (reseat_1): Call bidi_init_it to resync the bidi
6851 iterator with IT's position. (Bug#7616)
6852 (find_row_edges): If ROW->start.pos gives position
6853 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6854 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6855 Reset the from_disp_prop_p flag.
6856 (SAVE_IT, RESTORE_IT): New macros.
6857 (pos_visible_p, face_before_or_after_it_pos)
6858 (back_to_previous_visible_line_start)
6859 (move_it_in_display_line_to, move_it_in_display_line)
6860 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6861 (try_scrolling, redisplay_window, display_line): Use them when
6862 saving a temporary copy of the iterator and restoring it back.
6863 (back_to_previous_visible_line_start, reseat_1)
6864 (init_iterator): Empty the bidi cache "stack".
6865 (move_it_in_display_line_to): If iterator ended up at
6866 EOL, but we never saw any buffer positions smaller than
6867 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6868 motion in bidi-reordered lines.
6869 (move_it_in_display_line_to): Record prev_method and prev_pos
6870 immediately before the call to set_iterator_to_next. Fixes cursor
6871 motion in bidi-reordered lines with stretch glyphs and strings
6872 displayed in margins. (Bug#8133) (Bug#8867)
6873 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6875 (pos_visible_p): Support positions in bidi-reordered lines.
6876 Save and restore bidi cache.
6878 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6879 (bidi_paragraph_info): Delete unused struct.
6880 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6881 (bidi_cache_start): New variable.
6882 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6884 (bidi_cache_fetch_state, bidi_cache_search)
6885 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6886 (bidi_cache_find, bidi_peek_at_next_level)
6887 (bidi_level_of_next_char, bidi_find_other_level_edge)
6888 (bidi_move_to_visually_next): Compare cache index with
6889 bidi_cache_start rather than with zero.
6890 (bidi_fetch_char): Accept new argument STRING; all callers
6891 changed. Support iteration over a string. Support strings with
6892 display properties. Support unibyte strings. Fix the type of
6893 `len' according to what STRING_CHAR_AND_LENGTH expects.
6894 (bidi_paragraph_init, bidi_resolve_explicit_1)
6895 (bidi_resolve_explicit, bidi_resolve_weak)
6896 (bidi_level_of_next_char, bidi_move_to_visually_next):
6897 Support iteration over a string.
6898 (bidi_set_sor_type, bidi_resolve_explicit_1)
6899 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6900 can now be zero (for strings); special values 0 and -1 were
6901 changed to -1 and -2, respectively.
6902 (bidi_char_at_pos): New function.
6903 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6904 Call it instead of FETCH_MULTIBYTE_CHAR.
6905 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6906 initialized to valid values.
6907 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6909 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6910 the test for valid cached positions. Fix the logic for looking up
6911 the sentinel state in the cache. GCPRO the Lisp string we are
6913 (bidi_push_it, bidi_pop_it): New functions.
6914 (bidi_initialize): Initialize the bidi cache start stack pointer.
6915 (bidi_cache_ensure_space): New function, refactored from part of
6916 bidi_cache_iterator_state. Don't assume the required size is just
6917 one BIDI_CACHE_CHUNK away.
6918 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6919 (bidi_count_bytes, bidi_char_at_pos): New functions.
6920 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6921 always valid if bidi_cache_idx is valid.
6922 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6923 is valid if it's going to be used.
6924 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6925 (bidi_cache_fetch_state, bidi_cache_search)
6926 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6927 (bidi_cache_iterator_state, bidi_cache_find)
6928 (bidi_find_other_level_edge, bidi_cache_start_stack):
6929 All variables related to cache indices are now EMACS_INT.
6931 * dispextern.h (struct bidi_string_data): New structure.
6932 (struct bidi_it): New member `string'. Make flag members be 1-bit
6933 fields, and put them last in the struct.
6934 (compute_display_string_pos, compute_display_string_end):
6936 (bidi_push_it, bidi_pop_it): Add prototypes.
6937 (struct iterator_stack_entry): New members bidi_p,
6938 paragraph_embedding, and from_disp_prop_p.
6939 (struct it): Member bidi_p is now a bit field 1 bit wide.
6940 (bidi_shelve_cache, bidi_unshelve_cache):
6943 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6944 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6945 and vector-like objects.
6947 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6948 cache around display iteration.
6950 * window.c (Fwindow_end, window_scroll_pixel_based)
6951 (displayed_window_lines, Frecenter): Save and restore the bidi
6952 cache around display iteration.
6954 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6956 * editfns.c (Fdelete_region): Clarify the use of the named
6957 parameters (bug#6788).
6959 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6961 * indent.c (Fvertical_motion): Set and restore w->pointm when
6962 saving and restoring the window's buffer (Bug#9006).
6964 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6966 * editfns.c (Fstring_to_char): Clarify just what is returned
6967 (bug#6576). Text by Eli Zaretskii.
6969 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6971 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6973 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6975 * buffer.c (mmap_find): Fix a typo.
6977 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6979 Fix execution of x selection hooks.
6980 * xselect.c (Qx_lost_selection_functions)
6981 (Qx_sent_selection_functions): New vars.
6982 (syms_of_xselect): DEFSYM them.
6983 (x_handle_selection_request): Pass Qx_sent_selection_functions
6984 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6985 (x_handle_selection_clear,x_clear_frame_selections):
6986 Pass Qx_lost_selection_functions rather than
6987 Vx_lost_selection_functions to Frun_hook_with_args.
6989 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6991 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6992 The old code sometimes used this field without initializing it.
6994 * alloc.c (gc_sweep): Don't read past end of array.
6995 In theory, the old code could also have corrupted Emacs internals,
6996 though it'd be very unlikely.
6998 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7000 * character.c (Fcharacterp): Don't advertise optional ignored
7001 argument. (Bug#4026)
7003 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7005 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7008 * window.c (Fset_window_start): Doc fix (bug#4199).
7009 (Fset_window_hscroll): Ditto.
7011 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7013 Fix minor new problems caught by GCC 4.6.1.
7014 * term.c (init_tty): Remove unused local.
7015 * xsettings.c (store_monospaced_changed): Define this function only
7016 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7019 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7021 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7023 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7025 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7026 are the mini-buffer and the echo area (bug#3320).
7028 * term.c (init_tty): Remove support for supdup, c10 and perq
7029 terminals, which are no longer supported (bug#1482).
7031 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7033 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7035 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7037 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7038 for non-popups (Bug#3642).
7040 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7042 * alloc.c (reset_malloc_hooks): Protoize.
7043 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7044 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7045 * cm.c (losecursor): Likewise.
7046 * data.c (fmod): Likewise.
7047 * dispnew.c (swap_glyphs_in_rows): Likewise.
7048 * emacs.c (memory_warning_signal): Likewise.
7049 * floatfns.c (float_error): Likewise.
7050 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7051 (otf_open, font_otf_capability, generate_otf_features)
7052 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7054 * image.c (pbm_read_file): Likewise.
7055 * indent.c (string_display_width): Likewise.
7056 * intervals.c (check_for_interval, search_for_interval)
7057 (inc_interval_count, count_intervals, root_interval)
7058 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7059 * lread.c (defalias): Likewise.
7060 * ralloc.c (r_alloc_check): Likewise.
7061 * regex.c (set_image_of_range_1, set_image_of_range)
7062 (regex_grow_registers): Likewise.
7063 * sysdep.c (strerror): Likewise.
7064 * termcap.c (valid_filename_p, tprint, main): Likewise.
7065 * tparam.c (main): Likewise.
7066 * unexhp9k800.c (run_time_remap, save_data_space)
7067 (update_file_ptrs, read_header, write_header, calculate_checksum)
7068 (copy_file, copy_rest, display_header): Likewise.
7069 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7071 * xdisp.c (check_it): Likewise.
7072 * xfaces.c (register_color, unregister_color, unregister_colors):
7074 * xfns.c (print_fontset_result): Likewise.
7075 * xrdb.c (member, fatal, main): Likewise.
7077 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7079 Fix minor problems found by static checking (Bug#9031).
7080 * chartab.c (char_table_set_range, map_sub_char_table):
7081 Remove unused locals.
7082 (uniprop_table): Now static.
7083 * composite.c (_work_char): Remove unused static var.
7085 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7087 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7089 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7091 * gtkutil.c (qttip_cb): Remove code without function.
7093 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7095 * w32.c (pthread_sigmask): New stub.
7097 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7099 Use pthread_sigmask, not sigprocmask (Bug#9010).
7100 sigprocmask is portable only for single-threaded applications, and
7101 Emacs can be multi-threaded when it uses GTK.
7102 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7104 * callproc.c (Fcall_process):
7105 * process.c (create_process):
7106 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7107 Use pthread_sigmask, not sigprocmask.
7109 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7111 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7112 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7115 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7117 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7118 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7119 (xg_hide_tooltip): Fix comment.
7121 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7122 in registerServicesMenuSendTypes.
7123 (validRequestorForSendType): Don't check ns_return_types.
7125 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7128 2011-07-08 Jason Rumney <jasonr@gnu.org>
7130 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7131 SH_SHOW for hidden windows (Bug#5482).
7133 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7134 frame struct members of non-existent frames (Bug#6284).
7136 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7138 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7139 variable firstTime not needed on OSX >= 10.6.
7140 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7141 >= 10.5. Use setKnobProportion, setDoubleValue.
7143 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7144 (MAC_OS_X_VERSION_10_5): Define if not defined.
7145 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7146 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7147 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7149 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7150 cString and lossyCString on OSX >= 10.4
7152 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7153 sizeToFit on OSX >= 10.2.
7155 * nsimage.m (allocInitFromFile): Don't use deprecated method
7156 bestRepresentationForDevice on OSX >= 10.6.
7158 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7161 * emacs.c: Declare unexec_init_emacs_zone.
7163 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7165 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7167 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7168 on svcsMenu (Bug#8842).
7170 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7172 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7174 * nsterm.m (QUTF8_STRING): Declare.
7175 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7176 (validRequestorForSendType): Return type is (id).
7177 Change indexOfObjectIdenticalTo to indexOfObject.
7178 Check if we have local selection before returning self (Bug#8842).
7179 (writeSelectionToPasteboard): Put local selection into paste board
7180 if we have a local selection (Bug#8842).
7181 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7183 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7184 (ns_get_local_selection): Declare.
7186 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7188 * keymap.c (describe_map_tree): Don't insert a double newline at
7189 the end of the buffer (bug#1169) and return whether we inserted
7192 * callint.c (Fcall_interactively): Change "reading args" to
7193 "providing args" to try to clarify what it does (bug#1010).
7195 2011-07-07 Kenichi Handa <handa@m17n.org>
7197 * composite.c (composition_compute_stop_pos): Ignore a static
7198 composition starting before CHARPOS (Bug#8915).
7200 * xdisp.c (handle_composition_prop): Likewise.
7202 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7204 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7207 2011-07-07 Kenichi Handa <handa@m17n.org>
7209 * character.h (unicode_category_t): New enum type.
7211 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7212 (Qchar_code_property_table): New variable.
7213 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7214 (UNIPROP_COMPRESSED_FORM_P): New macros.
7215 (char_table_ascii): Uncompress the compressed values.
7216 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7217 Uncompress the compressed values.
7218 (sub_char_table_ref_and_range): Likewise.
7219 (char_table_ref_and_range): Uncompress the compressed values.
7220 (sub_char_table_set): New arg is_uniprop. Callers changed.
7221 Uncompress the compressed values.
7222 (sub_char_table_set_range): Args changed. Callers changed.
7223 (char_table_set_range): Adjuted for the above change.
7224 (map_sub_char_table): Delete args default_val and parent. Add arg
7225 top. Give decoded values to a Lisp function.
7226 (map_char_table): Adjust for the above change. Give decoded
7227 values to a Lisp function. Gcpro more variables.
7228 (uniprop_table_uncompress)
7229 (uniprop_decode_value_run_length): New functions.
7230 (uniprop_decoder, uniprop_decoder_count): New variables.
7231 (uniprop_get_decoder, uniprop_encode_value_character)
7232 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7234 (uniprop_encoder, uniprop_encoder_count): New variables.
7235 (uniprop_get_encoder, uniprop_table)
7236 (Funicode_property_table_internal, Fget_unicode_property_internal)
7237 (Fput_unicode_property_internal): New functions.
7238 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7239 Sunicode_property_table_internal, Sget_unicode_property_internal,
7240 and Sput_unicode_property_internal. Defvar_lisp
7241 char-code-property-alist.
7243 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7244 Vunicode_category_table.
7246 * font.c (font_range): Adjust for the change of
7247 Vunicode_category_table.
7249 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7251 * m/iris4d.h: Remove file, move contents ...
7252 * s/irix6-5.h: ... here.
7254 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7256 Remove unportable assumption about struct layout (Bug#8884).
7257 * alloc.c (mark_buffer):
7258 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7259 (clone_per_buffer_values): Don't assume that
7260 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7261 This isn't true in general, and it's particularly not true
7262 if Emacs is configured with --with-wide-int.
7263 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7264 New macros, used in the buffer.c change.
7266 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7268 * xsettings.c: Use both GConf and GSettings if both are available.
7269 (store_config_changed_event): Add comment.
7270 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7271 (store_tool_bar_style_changed): New functions.
7272 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7273 (struct xsettings): Move font inside HAVE_XFT.
7274 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7275 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7276 Move inside HAVE_XFT.
7277 (something_changed_gsettingsCB): Rename from something_changedCB.
7278 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7280 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7281 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7282 (something_changed_gconfCB): Rename from something_changedCB.
7283 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7284 (parse_settings): Move check for font inside HAVE_XFT.
7285 (read_settings, apply_xft_settings): Add comment.
7286 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7287 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7288 call store_font_name_changed.
7289 (xft_settings_event): Add comment.
7290 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7291 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7292 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7293 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7294 (xsettings_initialize): Call init_gsettings last.
7295 (xsettings_get_system_font, xsettings_get_system_normal_font):
7298 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7300 Random fixes. E.g., (random) never returned negative values.
7301 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7302 subseconds part to the entropy, as that's a bit more random.
7303 Prefer signed to unsigned, since the signedness doesn't matter and
7304 in general we prefer signed. When given a limit, use a
7305 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7306 latter isn't right if USE_2_TAGS_FOR_INTS.
7307 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7308 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7310 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7312 * textprop.c (text_property_stickiness):
7313 Obey Vtext_property_default_nonsticky.
7314 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7315 * w32fns.c (syms_of_w32fns):
7316 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7318 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7320 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7321 This is more efficient than Ffile_directory_p and avoids a minor race.
7323 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7325 * buffer.c (Foverlay_put): Say what the return value is
7328 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7329 is a directory before asking whether to use the file name
7331 (barf_or_query_if_file_exists): Make the "File is a directory"
7332 error be more correct.
7334 * fns.c (Frequire): Remove the mention of the .gz files, since
7335 that's installation-specific, but keep the mention of
7336 `get-load-suffixes'.
7338 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7340 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7341 Report string overflow if the output is too long.
7343 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7345 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7346 (syms_of_gnutls): Remove duplicate DEFSYM for
7347 Qgnutls_bootprop_verify_hostname_error, an error for
7348 Qgnutls_bootprop_verify_error (which is no longer used).
7350 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7351 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7352 Also (re)move comments that are misplaced or no longer relevant.
7354 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7356 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7358 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7360 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7361 and background color parameters if they have been changed.
7363 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7365 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7367 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7369 * xsettings.c (SYSTEM_FONT): Define only when used.
7370 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7372 * keymap.c (access_keymap_1): Now static.
7374 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7376 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7377 leave any prefix arg for the up event (Bug#1586).
7379 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7381 * lread.c (syms_of_lread): Mention single symbols defined by
7382 `defvar' or `defconst' (bug#7154).
7384 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7385 (Frequire): Mention get-load-suffixes.
7387 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7389 * window.h (window): Remove clone_number slot.
7390 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7392 (make_parent_window, make_window, saved_window)
7393 (Fset_window_configuration, save_window_save): Don't deal with
7395 * buffer.c (Qclone_number): Remove declaration.
7396 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7398 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7400 Add multiple inheritance to keymaps.
7401 * keymap.c (Fmake_composed_keymap): New function.
7402 (Fset_keymap_parent): Simplify.
7403 (fix_submap_inheritance): Remove.
7404 (access_keymap_1): New function extracted from access_keymap to handle
7405 embedded parents and handle lists of maps.
7406 (access_keymap): Use it.
7407 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7408 (Fcopy_keymap): Handle embedded parents.
7409 (Fcommand_remapping, define_as_prefix): Simplify.
7410 (Fkey_binding): Simplify.
7411 (syms_of_keymap): Move minibuffer-local-completion-map,
7412 minibuffer-local-filename-completion-map,
7413 minibuffer-local-must-match-map, and
7414 minibuffer-local-filename-must-match-map to Elisp.
7415 (syms_of_keymap): Defsubr make-composed-keymap.
7416 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7417 (parse_menu_item): Trivial simplification.
7419 2011-07-01 Glenn Morris <rgm@gnu.org>
7421 * Makefile.in (SETTINGS_LIBS): Fix typo.
7423 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7425 * coding.c (Fencode_coding_string): Record the last coding system
7426 used, as the function doc string says (bug#8738).
7428 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7430 * xsettings.c (store_monospaced_changed): Take new font as arg and
7431 check for change against current_mono_font.
7432 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7433 (emacs_settings_constructor, emacs_settings_get_property)
7434 (emacs_settings_set_property, emacs_settings_class_init)
7435 (emacs_settings_init, gsettings_obj): Remove.
7436 (something_changedCB): New function for HAVE_GSETTINGS.
7437 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7438 with value as argument.
7439 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7440 g_settings_new (Bug#8967). Do not create gsettings_obj.
7441 Remove calls to g_settings_bind. Connect something_changedCB to
7444 * xgselect.c: Add defined (HAVE_GSETTINGS).
7445 (xgselect_initialize): Ditto.
7447 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7448 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7451 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7453 * eval.c (struct backtrace): Simplify and port the data structure.
7454 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7455 signed bit field, as this assumption is not portable and it makes
7456 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7457 "char debug_on_exit : 1" as this is not portable either; instead,
7458 use the portable "unsigned int debug_on_exit : 1". Remove unused
7459 member evalargs. Remove obsolete comments about cc bombing out.
7461 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7463 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7464 Let HAVE_GSETTINGS override HAVE_GCONF.
7465 (store_monospaced_changed): New function.
7466 (EMACS_SETTINGS): A new type derived from GObject to handle
7467 GSettings notifications.
7468 (emacs_settings_constructor, emacs_settings_get_property)
7469 (emacs_settings_set_property, emacs_settings_class_init):
7471 (gsettings_client, gsettings_obj): New variables.
7472 (GSETTINGS_SCHEMA): New define.
7473 (something_changedCB): Call store_monospaced_changed.
7474 (init_gsettings): New function.
7475 (xsettings_initialize): Call init_gsettings.
7476 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7479 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7482 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7484 * window.c (resize_root_window, grow_mini_window)
7485 (shrink_mini_window): Rename Qresize_root_window to
7486 Qwindow_resize_root_window and Qresize_root_window_vertically to
7487 Qwindow_resize_root_window_vertically.
7489 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7491 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7493 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7495 * makefile.w32-in: Redesign dependencies so they reflect more
7496 clearly which files are directly included by each source file,
7497 and not through other includes.
7499 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7501 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7502 (sort_overlays, overlay_strings): When an overlay's clone number
7503 matches the window's clone number process the overlay even if
7504 the overlay's window property doesn't match the current window.
7506 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7507 (Fwindow_hchild): Rename to Fwindow_left_child.
7508 (Fwindow_next): Rename to Fwindow_next_sibling.
7509 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7510 (resize_window_check): Rename to window_resize_check.
7511 (resize_window_apply): Rename to window_resize_apply.
7512 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7513 (Fdelete_other_windows_internal, resize_frame_windows)
7514 (Fsplit_window_internal, Fdelete_window_internal)
7515 (grow_mini_window, shrink_mini_window)
7516 (Fresize_mini_window_internal): Fix callers accordingly.
7518 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7520 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7521 (emacs_fixed_set_min_size): Remove.
7522 (emacs_fixed_new): Take frame as argument.
7524 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7525 (_EmacsFixedPrivate): Remove minwidth/height.
7526 Add struct frame *f.
7527 (emacs_fixed_init): Initialize priv->f.
7528 (get_parent_class, emacs_fixed_set_min_size): Remove.
7529 (emacs_fixed_new): Set priv->f to argument.
7530 (emacs_fixed_get_preferred_width)
7531 (emacs_fixed_get_preferred_height): Use min_width/height from
7532 frames size_hint to set minimum and natural (Bug#8919).
7533 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7534 and use min_width/height from frames size_hint to set
7535 min_width/height (Bug#8919).
7537 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7538 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7541 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7543 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7544 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7547 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7549 * process.c (wait_reading_process_output): Bypass select if
7550 waiting for a cell while ignoring keyboard input, and input is
7551 pending. Suggested by Jan Djärv (Bug#8869).
7553 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7555 Use gnulib's dup2 module instead of rolling our own.
7556 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7558 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7560 * dispnew.c (scrolling_window): Before scrolling, turn off a
7561 mouse-highlight in the window being scrolled.
7563 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7565 Move DEFSYM to lisp.h and use everywhere.
7567 * character.h (DEFSYM): Move declaration...
7568 * lisp.h (DEFSYM): ...here.
7574 * w32select.c: Don't include character.h.
7576 * alloc.c (syms_of_alloc):
7577 * buffer.c (syms_of_buffer):
7578 * bytecode.c (syms_of_bytecode):
7579 * callint.c (syms_of_callint):
7580 * casefiddle.c (syms_of_casefiddle):
7581 * casetab.c (init_casetab_once):
7582 * category.c (init_category_once, syms_of_category):
7583 * ccl.c (syms_of_ccl):
7584 * cmds.c (syms_of_cmds):
7585 * composite.c (syms_of_composite):
7586 * dbusbind.c (syms_of_dbusbind):
7587 * dired.c (syms_of_dired):
7588 * dispnew.c (syms_of_display):
7589 * doc.c (syms_of_doc):
7590 * editfns.c (syms_of_editfns):
7591 * emacs.c (syms_of_emacs):
7592 * eval.c (syms_of_eval):
7593 * fileio.c (syms_of_fileio):
7594 * fns.c (syms_of_fns):
7595 * frame.c (syms_of_frame):
7596 * fringe.c (syms_of_fringe):
7597 * insdel.c (syms_of_insdel):
7598 * keymap.c (syms_of_keymap):
7599 * lread.c (init_obarray, syms_of_lread):
7600 * macros.c (syms_of_macros):
7601 * msdos.c (syms_of_msdos):
7602 * print.c (syms_of_print):
7603 * process.c (syms_of_process):
7604 * search.c (syms_of_search):
7605 * sound.c (syms_of_sound):
7606 * syntax.c (init_syntax_once, syms_of_syntax):
7607 * terminal.c (syms_of_terminal):
7608 * textprop.c (syms_of_textprop):
7609 * undo.c (syms_of_undo):
7610 * w32.c (globals_of_w32):
7611 * window.c (syms_of_window):
7612 * xdisp.c (syms_of_xdisp):
7613 * xfaces.c (syms_of_xfaces):
7614 * xfns.c (syms_of_xfns):
7615 * xmenu.c (syms_of_xmenu):
7616 * xsettings.c (syms_of_xsettings):
7617 * xterm.c (syms_of_xterm): Use DEFSYM.
7619 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7621 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7623 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7625 Integer and buffer overflow fixes (Bug#8873).
7627 * print.c (printchar, strout): Check for string overflow.
7628 (PRINTPREPARE, printchar, strout):
7629 Don't set size unless allocation succeeds.
7631 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7632 for sizes. Check for string overflow more accurately.
7633 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7635 * macros.c: Integer and buffer overflow fixes.
7636 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7637 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7638 Use ptrdiff_t, not int, for sizes.
7639 Don't increment bufsize until after realloc succeeds.
7640 Check for size-calculation overflow.
7641 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7643 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7645 * lread.c: Integer overflow fixes.
7646 (read_integer): Radix is now EMACS_INT, not int,
7647 to improve quality of diagnostics for out-of-range radices.
7648 Calculate buffer size correctly for out-of-range radices.
7649 (read1): Check for integer overflow in radices, and in
7650 read-circle numbers.
7651 (read_escape): Avoid int overflow.
7652 (Fload, openp, read_buffer_size, read1)
7653 (substitute_object_recurse, read_vector, read_list, map_obarray):
7654 Use ptrdiff_t, not int, for sizes.
7655 (read1): Use EMACS_INT, not int, for sizes.
7656 Check for size overflow.
7658 * image.c (cache_image): Check for size arithmetic overflow.
7660 * lread.c: Integer overflow issues.
7661 (saved_doc_string_size, saved_doc_string_length)
7662 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7663 Now ptrdiff_t, not int.
7664 (read1): Don't assume doc string length fits in int. Check for
7665 out-of-range doc string lengths.
7666 (read_list): Don't assume file position fits in int.
7667 (read_escape): Check for hex character overflow.
7669 2011-06-22 Leo Liu <sdl.web@gmail.com>
7671 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7672 Move to minibuffer.el.
7674 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7676 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7677 The following patches are for when GLYPH_DEBUG && !XASSERT.
7678 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7679 * dispnew.c (flush_stdout):
7680 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7681 Mark as externally visible.
7682 * dispnew.c (check_window_matrix_pointers): Now static.
7683 * dispnew.c (window_to_frame_vpos):
7684 * xfns.c (unwind_create_frame):
7685 * xterm.c (x_check_font): Remove unused local.
7686 * scroll.c (CHECK_BOUNDS):
7687 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7688 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7689 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7690 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7691 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7693 (debug_method_add): Use va_list and vsprintf rather than relying
7694 on undefined behavior with wrong number of arguments.
7695 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7696 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7697 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7698 since we're not interested in debugging glyphs with old libraries.
7699 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7700 GCC 4.6.0's static checking.
7702 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7704 Integer overflow and signedness fixes (Bug#8873).
7705 A few related buffer overrun fixes, too.
7707 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7709 * dispextern.h (struct face.stipple):
7710 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7711 (x_bitmap_mask, x_allocate_bitmap_record)
7712 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7713 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7714 (x_create_bitmap_from_xpm_data):
7715 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7716 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7718 * xfaces.c (load_pixmap):
7719 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7720 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7721 (.bitmaps_last, struct x_output.icon_bitmap):
7722 Use ptrdiff_t, not int, for bitmap indexes.
7723 (x_allocate_bitmap_record): Check for size overflow.
7724 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7726 Use ptrdiff_t, not int, for overlay counts.
7727 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7728 * editfns.c (overlays_around, get_pos_property):
7729 * textprop.c (get_char_property_and_overlay):
7730 * xdisp.c (next_overlay_change, note_mouse_highlight):
7731 * xfaces.c (face_at_buffer_position):
7732 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7733 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7734 (Fnext_overlay_change, Fprevious_overlay_change)
7735 (mouse_face_overlay_overlaps, Foverlays_in):
7736 Use ptrdiff_t, not int, for sizes.
7737 (overlays_at, overlays_in): Check for size-calculation overflow.
7739 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7741 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7742 (x_session_initialize): Do not assume string length fits in int.
7744 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7745 This is unlikely, but can occur if DPI is outlandish.
7747 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7748 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7750 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7751 * xrdb.c (magic_file_p, search_magic_path):
7752 Omit last arg SUFFIX; it was always 0. All callers changed.
7753 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7755 * xfont.c (xfont_match): Avoid need for strlen.
7757 * xfns.c: Don't assume strlen fits in int.
7758 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7760 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7761 not unsigned long, as we prefer signed integers. All callers changed.
7762 Detect integer overflow in repeat count.
7763 (message_dolog): Don't assume print length fits in 39 bytes.
7764 (display_mode_element): Don't assume strlen fits in int.
7766 * termcap.c: Don't assume sizes fit in int and never overflow.
7767 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7768 (gobble_line): Check for size-calculation overflow.
7770 * minibuf.c (Fread_buffer):
7771 * lread.c (intern, intern_c_string):
7772 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7773 Don't assume string length fits in int.
7775 * keyboard.c (parse_tool_bar_item):
7776 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7778 * font.c: Don't assume string length fits in int.
7779 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7780 Use ptrdiff_t, not int.
7781 (font_intern_prop): Don't assume string length fits in int.
7782 Don't assume integer property fits in fixnum.
7783 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7785 * filelock.c: Fix some buffer overrun and integer overflow issues.
7786 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7787 Reformulate so as not to need the command string.
7788 Invoke gzip -cd rather than gunzip, as it's more portable.
7789 (lock_info_type, lock_file_1, lock_file):
7790 Don't assume pid_t and time_t fit in unsigned long.
7791 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7792 (current_lock_owner): Prefer signed type for sizes.
7793 Use memcpy, not strncpy, where memcpy is what is really wanted.
7794 Don't assume (via atoi) that time_t and pid_t fit in int.
7795 Check for time_t and/or pid_t out of range, e.g., via a network share.
7796 Don't alloca where an auto var works fine.
7798 * fileio.c: Fix some integer overflow issues.
7799 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7800 Don't assume string length fits in int.
7801 (directory_file_name): Don't assume string length fits in long.
7802 (make_temp_name): Don't assume pid fits in int, or that its print
7803 length is less than 20.
7805 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7807 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7809 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7811 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7812 We prefer signed integers, even for size calculations.
7814 * emacs.c: Don't assume string length fits in 'int'.
7815 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7816 (main): Don't invoke strlen when not needed.
7818 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7819 (XD_DEBUG_MESSAGE): Don't waste a byte.
7821 * callproc.c (getenv_internal_1, getenv_internal)
7823 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7825 * lread.c (invalid_syntax): Omit length argument.
7826 All uses changed. This doesn't fix a bug, but it simplifies the
7827 code away from its former Hollerith-constant appearance, and it's
7828 one less 'int' to worry about when looking at integer-overflow issues.
7829 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7831 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7832 This didn't break anything, but it didn't help either.
7833 It's confusing to put a bogus integer in a place where the actual
7834 value does not matter.
7835 (LIST_END_P): Remove unused macro and its bogus comment.
7836 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7838 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7839 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7841 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7842 We prefer signed types, and the value cannot exceed the EMACS_INT
7843 range anyway (because otherwise the length would not be representable).
7844 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7845 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7846 This avoids a GCC warning when WIDE_EMACS_INT.
7848 * indent.c (sane_tab_width): New function.
7849 (current_column, scan_for_column, Findent_to, position_indentation)
7850 (compute_motion): Use it. This is just for clarity.
7851 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7853 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7855 * lisp.h (lint_assume): New macro.
7856 * composite.c (composition_gstring_put_cache):
7857 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7859 * editfns.c, insdel.c:
7860 Omit unnecessary forward decls, to simplify future changes.
7862 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7864 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7866 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7867 Use much-faster test for byte-length change.
7868 Don't assume string byte-length fits in 'int'.
7869 Check that character arg fits in 'int'.
7870 (mapcar1): Declare byte as byte, for clarity.
7872 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7874 * fns.c (concat): Catch string overflow earlier.
7875 Do not rely on integer wraparound.
7877 * dispextern.h (struct it.overlay_strings_charpos)
7878 (struct it.selective): Now EMACS_INT, not int.
7879 * xdisp.c (forward_to_next_line_start)
7880 (back_to_previous_visible_line_start)
7881 (reseat_at_next_visible_line_start, next_element_from_buffer):
7882 Don't arbitrarily truncate the value of 'selective' to int.
7884 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7886 * composite.c: Don't truncate sizes to 'int'.
7887 (composition_gstring_p, composition_reseat_it)
7888 (composition_adjust_point): Use EMACS_INT, not int.
7889 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7890 not EMACS_UINT, for indexes.
7892 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7894 * buffer.c: Include <verify.h>.
7895 (struct sortvec.priority, struct sortstr.priority):
7896 Now EMACS_INT, not int.
7897 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7898 (struct sortstr.size, record_overlay_string)
7899 (struct sortstrlist.size, struct sortlist.used):
7900 Don't truncate size to int.
7901 (record_overlay_string): Check for size-calculation overflow.
7902 (init_buffer_once): Check at compile-time, not run-time.
7904 2011-06-22 Jim Meyering <meyering@redhat.com>
7906 Don't leak an XBM-image-sized buffer
7907 * image.c (xbm_load): Free the image buffer after using it.
7909 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7912 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7913 that Sun C diagnosed.
7914 * fns.c (secure_hash): Fix pointer signedness issue.
7915 * intervals.c (static_offset_intervals): New function.
7916 (offset_intervals): Use it.
7918 2011-06-21 Leo Liu <sdl.web@gmail.com>
7921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7924 * fns.c (secure_hash): Rename from crypto_hash_function and change
7925 the first arg to accept symbols.
7926 (Fsecure_hash): New primitive.
7927 (syms_of_fns): New symbols.
7929 2011-06-20 Deniz Dogan <deniz@dogan.se>
7931 * process.c (Fset_process_buffer): Clarify return value in
7934 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7936 * dispnew.c (add_window_display_history): Use BVAR.
7938 * xdisp.c (debug_method_add): Use BVAR.
7939 (check_window_end, dump_glyph_matrix, dump_glyph)
7940 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7942 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7945 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7946 check till after the cache is created in init_frame_faces.
7948 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7950 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7952 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7954 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7955 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7956 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7958 Improve buffer-overflow checking (Bug#8873).
7959 * fileio.c (Finsert_file_contents):
7960 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7961 Remove the old (too-loose) buffer overflow checks.
7962 They weren't needed, since make_gap checks for buffer overflow.
7963 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7964 The old code merely checked for Emacs fixnum overflow, and relied
7965 on undefined (wraparound) behavior. The new code avoids undefined
7966 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7968 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7969 Tune. Don't use wider integers than needed. Don't use alloca.
7970 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7972 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7974 * insdel.c, lisp.h (buffer_overflow): New function.
7975 (insert_from_buffer_1, replace_range, replace_range_2):
7976 * insdel.c (make_gap_larger):
7977 * editfns.c (Finsert_char):
7978 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7980 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7982 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7984 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7986 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7987 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7989 * fileio.c: Don't assume EMACS_INT fits in off_t.
7990 (emacs_lseek): New static function.
7991 (Finsert_file_contents, Fwrite_region): Use it.
7992 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7994 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7996 * fns.c: Don't overflow int when computing a list length.
7997 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7998 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7999 truncation on 64-bit hosts. Check for QUIT every
8000 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8001 faster and is responsive enough.
8002 (Flength): Report an error instead of overflowing an integer.
8003 (Fsafe_length): Return a float if the value is not representable
8004 as a fixnum. This shouldn't happen except in contrived situations.
8005 (Fnthcdr, Fsort): Don't assume list length fits in int.
8006 (Fcopy_sequence): Don't assume vector length fits in int.
8008 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8009 (header_size, word_size): New constants.
8010 (allocate_vectorlike): Don't check size overflow here.
8011 (allocate_vector): Check it here instead, since this is the only
8012 caller of allocate_vectorlike that could cause overflow.
8013 Check that the new vector's length is representable as a fixnum.
8015 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8016 The previous code was bogus. For example, next_almost_prime (32)
8017 returned 39, which is undesirable as it is a multiple of 3; and
8018 next_almost_prime (24) returned 25, which is a multiple of 5 so
8019 why was the code bothering to check for multiples of 7?
8021 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8023 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8025 Variadic C functions now count arguments with ptrdiff_t.
8026 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8027 Back then I didn't know that the Emacs coding style prefers signed int.
8028 Also, in the meantime I found a few more instances where arguments
8029 were being counted with int, which may truncate counts on 64-bit
8030 machines, or EMACS_INT, which may be unnecessarily wide.
8031 * lisp.h (struct Lisp_Subr.function.aMANY)
8032 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8033 Arg counts are now ptrdiff_t, not size_t.
8034 All variadic functions and their callers changed accordingly.
8035 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8036 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8037 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8038 * callint.c (Fcall_interactively): Check arg count for overflow,
8039 to avoid potential buffer overrun. Use signed char, not 'int',
8040 for 'varies' array, so that we needn't bother to check its size
8041 calculation for overflow.
8042 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8043 * eval.c (apply_lambda):
8044 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8045 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8046 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8048 * callint.c (Fcall_interactively): Don't use index var as event count.
8050 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8051 * mem-limits.h (SIZE): Remove; no longer used.
8053 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8055 Remove unnecessary casts.
8056 * xterm.c (x_term_init):
8057 * xfns.c (x_set_border_pixel):
8058 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8059 These aren't needed now that we assume ANSI C.
8061 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8062 It's more likely to cause problems (due to unsigned overflow)
8065 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8067 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8069 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8071 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8073 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8075 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8077 GLYPH_CODE_FACE returns EMACS_INT, not int.
8078 * dispextern.h (merge_faces):
8079 * xfaces.c (merge_faces):
8080 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8081 Don't assume EMACS_INT fits in int.
8083 * character.h (CHAR_VALID_P): Remove unused parameter.
8084 * fontset.c, lisp.h, xdisp.c: All uses changed.
8086 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8088 * fns.c (concat): Minor tuning based on overflow analysis.
8089 This doesn't fix any bugs. Use int to hold character, instead
8090 of constantly refetching from Emacs object. Use XFASTINT, not
8091 XINT, for value known to be a character. Don't bother comparing
8092 a single byte to 0400, as it's always less.
8094 * floatfns.c (Fexpt):
8095 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8097 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8100 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8102 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8103 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8104 incorrectly succeed when S was a string, because 4294967386 was
8105 truncated before it was used.
8107 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8108 Otherwise, an out-of-range integer could cause undefined behavior
8111 * composite.c: Use int, not EMACS_INT, for characters.
8112 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8113 EMACS_INT, for values that are known to be in character range.
8114 This doesn't fix any bugs but is the usual style inside Emacs and
8115 may generate better code on 32-bit machines.
8117 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8118 This is for reasons similar to the recent CHAR_STRING fix.
8119 * charset.c (Fencode_char): Check that character arg is actually
8120 a character. Pass an int to ENCODE_CHAR.
8121 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8122 wider than 'int', as a compile-time check to prevent future regressions
8125 * character.c (char_string): Remove unnecessary casts.
8127 Make sure a 64-bit char is never passed to CHAR_STRING.
8128 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8129 by silently ignoring the top 32 bits, allowing some values
8130 that were far too large to be valid characters.
8131 * character.h: Include <verify.h>.
8132 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8133 arguments are no wider than unsigned, as a compile-time check
8134 to prevent future regressions in this area.
8136 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8137 (Fsubst_char_in_region):
8139 * xdisp.c (decode_mode_spec_coding):
8140 Adjust to CHAR_STRING's new requirement.
8141 * editfns.c (Finsert_char, Fsubst_char_in_region):
8142 * fns.c (concat): Check that character args are actually
8143 characters. Without this test, these functions did the wrong
8144 thing with wildly out-of-range values on 64-bit hosts.
8146 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8147 These casts should not be needed on 32-bit hosts, either.
8148 * keyboard.c (read_char):
8149 * lread.c (Fload): Remove casts to unsigned.
8151 * lisp.h (UNSIGNED_CMP): New macro.
8152 This fixes comparison bugs on 64-bit hosts.
8153 (ASCII_CHAR_P): Use it.
8154 * casefiddle.c (casify_object):
8155 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8156 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8157 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8158 * dispextern.h (FACE_FROM_ID):
8159 * keyboard.c (read_char): Use UNSIGNED_CMP.
8161 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8162 not to EMACS_INT, to avoid GCC warning.
8164 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8166 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8167 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8168 isn't needed on 32-bit machines.
8170 * buffer.c (Fgenerate_new_buffer_name):
8171 Use EMACS_INT for count, not int.
8172 (advance_to_char_boundary): Return EMACS_INT, not int.
8174 * data.c (Qcompiled_function): Now static.
8176 * window.c (window_body_lines): Now static.
8178 * image.c (gif_load): Rename local to avoid shadowing.
8180 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8181 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8182 * alloc.c (make_save_value): Integer argument is now of type
8184 (mark_object): Use ptrdiff_t, not int.
8185 * lisp.h (pD): New macro.
8186 * print.c (print_object): Use it.
8188 * alloc.c: Use EMACS_INT, not int, to count objects.
8189 (total_conses, total_markers, total_symbols, total_vector_size)
8190 (total_free_conses, total_free_markers, total_free_symbols)
8191 (total_free_floats, total_floats, total_free_intervals)
8192 (total_intervals, total_strings, total_free_strings):
8193 Now EMACS_INT, not int. All uses changed.
8194 (Fgarbage_collect): Compute overall total using a double, so that
8195 integer overflow is less likely to be a problem. Check for overflow
8196 when converting back to an integer.
8197 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8198 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8199 These were 'int' variables that could overflow on 64-bit hosts;
8200 they were never used, so remove them instead of repairing them.
8201 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8202 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8203 Previously, this ceilinged at INT_MAX, but that doesn't work on
8205 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8207 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8208 (allocate_vectorlike): Check for ptrdiff_t overflow.
8209 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8210 when a (possibly-narrower) signed value would do just as well.
8211 We prefer using signed arithmetic, to avoid comparison confusion.
8213 * alloc.c: Catch some string size overflows that we were missing.
8214 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8215 for convenience in STRING_BYTES_MAX.
8216 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8217 The definition here is exact; the one in lisp.h was approximate.
8218 (allocate_string_data): Check for string overflow. This catches
8219 some instances we weren't catching before. Also, it catches
8220 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8221 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8222 and ptrdiff_t and EMACS_INT are both 64 bits.
8224 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8225 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8226 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8228 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8230 * alloc.c (Fmake_string): Check for out-of-range init.
8232 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8234 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8236 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8238 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8239 xg_get_default_scrollbar_width.
8241 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8242 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8243 (style_changed_cb): Call update_theme_scrollbar_width and call
8244 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8245 all frames (Bug#8505).
8246 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8247 Call gtk_window_set_resizable if HAVE_GTK3.
8248 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8249 and height if HAVE_GTK3 (Bug#8505).
8250 (scroll_bar_width_for_theme): New variable.
8251 (update_theme_scrollbar_width): New function.
8252 (xg_get_default_scrollbar_width): Move code to
8253 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8254 (xg_initialize): Call update_theme_scrollbar_width.
8256 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8258 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8260 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8262 * frame.c (make_frame): Call other_buffer_safely instead of
8265 * window.c (temp_output_buffer_show): Call display_buffer with
8266 second argument Vtemp_buffer_show_specifiers and reset latter
8267 immediately after the call.
8268 (Vtemp_buffer_show_specifiers): New variable.
8269 (auto_window_vscroll_p, next_screen_context_lines)
8270 (Vscroll_preserve_screen_position): Remove leading asterisks from
8273 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8275 Fix minor problems found by GCC 4.6.0 static checking.
8276 * buffer.c (Qclone_number): Remove for now, as it's unused.
8277 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8278 (record_buffer): Remove unused local.
8279 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8280 (set_frame_buffer_list): Remove; unused.
8281 * frame.h (other_visible_frames): Remove decl.
8282 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8283 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8284 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8286 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8287 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8288 Define only if HAVE_GPM.
8289 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8290 (update_hints_inhibit): Remove; never set. All uses removed.
8291 * widgetprv.h (emacsFrameClassRec): Remove decl.
8292 * window.c (delete_deletable_window): Now returns void, since it
8293 wasn't returning anything.
8294 (compare_window_configurations): Remove unused locals.
8295 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8296 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8297 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8298 the same widths as pointers. This follows up on the 2011-05-06 patch.
8299 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8300 * xterm.h: Likewise.
8301 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8303 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8305 * makefile.w32-in: Update dependencies.
8306 (LISP_H): Add lib/intprops.h.
8308 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8310 * image.c (gif_load): Add animation frame delay to the metadata.
8311 (syms_of_image): Use DEFSYM. New symbol `delay'.
8313 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8315 * window.c (delete_deletable_window): Re-add.
8316 (Fset_window_configuration): Rewrite to handle dead buffers and
8317 consequently deletable windows.
8318 (window_tree, Fwindow_tree): Remove. Supply functionality in
8320 (compare_window_configurations): Simplify code.
8322 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8324 * image.c (imagemagick_load_image): Fix type mismatch.
8325 (Fimagemagick_types): Likewise.
8327 * window.h (replace_buffer_in_windows): Declare.
8329 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8331 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8332 Qclone_number. Remove external declaration of Qdelete_window.
8333 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8335 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8336 Run Qbuffer_list_update_hook if allowed.
8337 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8338 buffer list implementation.
8339 (other_buffer_safely): New function.
8340 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8341 calls to replace_buffer_in_windows and
8342 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8344 (record_buffer): Inhibit quitting and rewrite using quittable
8345 functions. Run Qbuffer_list_update_hook if allowed.
8346 (Frecord_buffer, Funrecord_buffer): New functions.
8347 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8348 Move switch-to-buffer to window.el.
8349 (bury-buffer): Move to window.el.
8350 (Vbuffer_list_update_hook): New variable.
8352 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8355 * window.h (resize_frame_windows): Move up in code.
8356 (Fwindow_frame): Remove EXFUN.
8357 (replace_buffer_in_all_windows): Remove prototype.
8358 (replace_buffer_in_windows_safely): Add prototype.
8360 * window.c: Declare Qdelete_window static again. Move down
8361 declaration of select_count.
8362 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8363 (Fother_window): Move to window.el.
8364 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8365 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8366 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8368 (replace_buffer_in_windows): Implement by calling
8369 Qreplace_buffer_in_windows.
8370 (replace_buffer_in_all_windows): Remove with some functionality
8371 moved into replace_buffer_in_windows_safely.
8372 (replace_buffer_in_windows_safely): New function.
8373 (select_window_norecord, select_frame_norecord): Move in front
8374 of run_window_configuration_change_hook. Remove now obsolete
8376 (Fset_window_buffer): Rewrite doc-string.
8377 Call Qrecord_window_buffer.
8378 (keys_of_window): Move binding for other-window to window.el.
8380 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8382 * dispextern.h (struct image): Replace data member, whose int_val
8383 and ptr_val fields were not used by anything, with a single
8386 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8387 (gif_clear_image, gif_load, imagemagick_load_image)
8388 (gs_clear_image, gs_load): Callers changed.
8390 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8392 * buffer.h: Include <time.h>, for time_t.
8393 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8395 Fix minor problems found by static checking.
8397 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8399 Make identifiers static if they are not used in other modules.
8400 * data.c (Qcompiled_function, Qframe, Qvector):
8401 * image.c (QimageMagick, Qsvg):
8402 * minibuf.c (Qmetadata):
8403 * window.c (resize_window_check, resize_root_window): Now static.
8404 * window.h (resize_window_check, resize_root_window): Remove decls.
8406 * window.c (window_deletion_count, delete_deletable_window):
8408 (window_body_lines): Now static.
8409 (Fdelete_other_windows_internal): Mark vars as initialized.
8410 Make sure 'resize_failed' is initialized.
8411 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8412 (resize_window_apply): Remove unused local.
8413 * window.h (delete_deletable_window): Remove decl.
8415 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8416 (imagemagick_load_image): Fix pointer signedness problem by changing
8417 last arg from unsigned char * to char *. All uses changed.
8418 Also, fix a local for similar reasons.
8419 Remove unused locals. Remove locals to avoid shadowing.
8420 (fn_rsvg_handle_free): Remove; unused.
8421 (svg_load, svg_load_image): Fix pointer signedness problem.
8422 (imagemagick_load_image): Don't use garbage pointer image_wand.
8424 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8426 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8428 * image.c (gif_load): Fix omitted cast error introduced by
8431 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8433 * window.h (resize_proportionally, orig_total_lines)
8434 (orig_top_line): Remove from window structure.
8435 (set_window_height, set_window_width, change_window_heights)
8436 (Fdelete_window): Remove prototypes.
8437 (resize_frame_windows): Remove duplicate declaration.
8439 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8441 * window.h (resize_frame_windows, resize_window_check)
8442 (delete_deletable_window, resize_root_window)
8443 (resize_frame_windows): Declare prototypes.
8445 * window.c (resize_window_apply): Make definition be "static" to
8446 match the prototype.
8448 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8450 * window.c: Remove declarations of Qwindow_size_fixed,
8451 window_min_size_1, window_min_size_2, window_min_size,
8452 size_window, window_fixed_size_p, enlarge_window, delete_window.
8453 Remove static from declaration of Qdelete_window, it's
8454 temporarily needed by Fbury_buffer.
8455 (replace_window): Don't assign orig_top_line and
8457 (Fdelete_window, delete_window): Remove. Window deletion is
8458 handled by window.el.
8459 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8460 Replace Fdelete_window calls with calls to Qdelete_window.
8461 (Fdelete_other_windows): Remove. Deleting other windows is
8462 handled by window.el.
8463 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8464 handled in window.el.
8465 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8466 Window minimum sizes are handled in window.el.
8467 (shrink_windows, size_window, set_window_height)
8468 (set_window_width, change_window_heights, window_height)
8469 (window_width, CURBEG, CURSIZE, enlarge_window)
8470 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8471 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8472 handled in window.el.
8473 (make_dummy_parent): Rename to make_parent_window and give it a
8474 second argument horflag.
8475 (make_window): Don't set resize_proportionally any more.
8476 (Fsplit_window): Remove. Windows are split in window.el.
8477 (save_restore_action, save_restore_orig_size)
8478 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8479 Resize mini windows in window.el.
8480 (grow_mini_window, shrink_mini_window): Implement by calling
8481 Qresize_root_window_vertically, resize_window_check and
8482 resize_window_apply.
8483 (saved_window, Fset_window_configuration, save_window_save):
8484 Do not handle orig_top_line, orig_total_lines, and
8485 resize_proportionally.
8486 (window_min_height, window_min_width): Move to window.el.
8487 (keys_of_window): Move bindings for delete-other-windows,
8488 split-window, delete-window and enlarge-window to window.el.
8490 * buffer.c: Temporarily extern Qdelete_window.
8491 (Fbury_buffer): Temporarily call Qdelete_window instead of
8492 Fdelete_window (Fbury_buffer will move to window.el soon).
8494 * frame.c (set_menu_bar_lines_1): Remove code handling
8495 orig_top_line and orig_total_lines.
8497 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8498 set_window_height but set heights directly.
8499 (change_frame_size_1): Use resize_frame_windows.
8501 * xdisp.c (init_xdisp): Don't use set_window_height but set
8504 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8505 Use resize_frame_windows instead of change_window_heights and run
8506 run_window_configuration_change_hook.
8508 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8509 instead of change_window_heights and run
8510 run_window_configuration_change_hook.
8512 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8514 * window.c (replace_window): Rename second argument REPLACEMENT to
8515 NEW. New third argument SETFLAG. Rewrite.
8516 (delete_window, make_dummy_parent): Call replace_window with
8518 (window_list_1): Move down in code.
8519 (run_window_configuration_change_hook): Move set_buffer part
8520 before select_frame_norecord part in order to unwind correctly.
8521 Rename count1 to count.
8522 (recombine_windows, delete_deletable_window, resize_root_window)
8523 (Fdelete_other_windows_internal)
8524 (Frun_window_configuration_change_hook, make_parent_window)
8525 (resize_window_check, resize_window_apply, Fresize_window_apply)
8526 (resize_frame_windows, Fsplit_window_internal)
8527 (Fdelete_window_internal, Fresize_mini_window_internal):
8529 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8531 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8533 * window.h (window): Add some new members to window structure -
8534 normal_lines, normal_cols, new_total, new_normal, clone_number,
8535 splits, nest, prev_buffers, next_buffers.
8536 (WINDOW_TOTAL_SIZE): Move here from window.c.
8537 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8539 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8541 (make_dummy_parent): Set new members of windows structure.
8542 (make_window): Move down in code. Handle new members of window
8544 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8545 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8546 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8547 (Fset_window_prev_buffers, Fwindow_next_buffers)
8548 (Fset_window_next_buffers, Fset_window_clone_number):
8550 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8551 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8553 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8554 Argument WINDOW can be now internal window too.
8555 (Fwindow_use_time): Move up in code.
8556 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8558 (Fset_window_configuration, saved_window)
8559 (Fcurrent_window_configuration, save_window_save): Handle new
8560 members of window structure.
8561 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8562 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8563 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8564 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8565 Qget_mru_window, Qresize_root_window,
8566 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8567 Qauto_buffer_name; staticpro them.
8569 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8571 * window.c (Fwindow_total_size, Fwindow_left_column)
8572 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8573 (Fwindow_list_1): New functions.
8574 (window_box_text_cols): Replace with window_body_cols.
8575 (Fwindow_width, Fscroll_left, Fscroll_right):
8576 Use window_body_cols instead of window_box_text_cols.
8577 (delete_window, Fset_window_configuration):
8578 Call delete_all_subwindows with window as argument.
8579 (delete_all_subwindows): Take a window as argument and not a
8581 (window_loop): Remove handling of GET_LRU_WINDOW and
8583 (Fget_lru_window, Fget_largest_window): Move to window.el.
8585 * window.h: Extern window_body_cols instead of
8586 window_box_text_cols. delete_all_subwindows now takes a
8587 Lisp_Object as argument.
8589 * indent.c (compute_motion, Fcompute_motion):
8590 Use window_body_cols instead of window_box_text_cols.
8592 * frame.c (delete_frame): Call delete_all_subwindows with root
8595 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8597 * fns.c (Fputhash): Document return value.
8599 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8601 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8603 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8605 Cons<->int and similar integer overflow fixes (Bug#8794).
8607 Check for overflow when converting integer to cons and back.
8608 * charset.c (Fdefine_charset_internal, Fdecode_char):
8609 Use cons_to_unsigned to catch overflow.
8610 (Fencode_char): Use INTEGER_TO_CONS.
8611 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8612 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8613 * data.c (long_to_cons, cons_to_long): Remove.
8614 (cons_to_unsigned, cons_to_signed): New functions.
8615 These signal an error for invalid or out-of-range values.
8616 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8617 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8618 * font.c (Ffont_variation_glyphs):
8619 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8620 * lisp.h: Include <intprops.h>.
8621 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8622 (cons_to_signed, cons_to_unsigned): New decls.
8623 (long_to_cons, cons_to_long): Remove decls.
8624 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8625 (Fprimitive_undo): Use CONS_TO_INTEGER.
8626 * xfns.c (Fx_window_property): Likewise.
8627 * xselect.c: Include <limits.h>.
8628 (x_own_selection, selection_data_to_lisp_data):
8629 Use INTEGER_TO_CONS.
8630 (x_handle_selection_request, x_handle_selection_clear)
8631 (x_get_foreign_selection, Fx_disown_selection_internal)
8632 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8633 (lisp_data_to_selection_data): Use cons_to_unsigned.
8634 (x_fill_property_data): Use cons_to_signed.
8635 Report values out of range.
8637 Check for buffer and string overflow more precisely.
8638 * buffer.h (BUF_BYTES_MAX): New macro.
8639 * lisp.h (STRING_BYTES_MAX): New macro.
8640 * alloc.c (Fmake_string):
8641 * character.c (string_escape_byte8):
8642 * coding.c (coding_alloc_by_realloc):
8643 * doprnt.c (doprnt):
8644 * editfns.c (Fformat):
8646 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8647 since they may not be the same number.
8648 * editfns.c (Finsert_char):
8649 * fileio.c (Finsert_file_contents):
8650 Likewise for BUF_BYTES_MAX.
8652 * image.c: Use ptrdiff_t, not int, for sizes.
8653 (slurp_file): Switch from int to ptrdiff_t.
8655 (slurp_file): Check that file size fits in both size_t (for
8656 malloc) and ptrdiff_t (for sanity and safety).
8658 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8659 if b->modtime has its maximal value.
8661 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8663 Don't assume time_t can fit into int.
8664 * buffer.h (struct buffer.modtime): Now time_t, not int.
8665 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8666 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8668 Minor fixes for signed vs unsigned integers.
8669 * character.h (MAYBE_UNIFY_CHAR):
8670 * charset.c (maybe_unify_char):
8671 * keyboard.c (read_char, reorder_modifiers):
8672 XINT -> XFASTINT, since the integer must be nonnegative.
8673 * ftfont.c (ftfont_spec_pattern):
8674 * keymap.c (access_keymap, silly_event_symbol_error):
8675 XUINT -> XFASTINT, since the integer must be nonnegative.
8676 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8677 since it makes no difference and we prefer signed.
8678 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8679 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8682 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8684 * window.h (Fwindow_frame): Declare.
8686 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8688 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8689 (SPARE_MEMORY): Always define.
8690 (LARGE_REQUEST): Remove.
8691 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8693 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8695 * lisp.h: Move EXFUNS for Fframe_root_window,
8696 Fframe_first_window and Fset_frame_selected_window to window.h.
8698 * window.h: Move EXFUNS for Fframe_root_window,
8699 Fframe_first_window and Fset_frame_selected_window here from
8702 * frame.c (Fwindow_frame, Fframe_first_window)
8703 (Fframe_root_window, Fframe_selected_window)
8704 (Fset_frame_selected_window): Move to window.c.
8705 (Factive_minibuffer_window): Move to minibuf.c.
8706 (Fother_visible_frames_p): New function.
8708 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8710 * window.c (decode_window, decode_any_window): Move up in code.
8711 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8712 (inhibit_frame_unsplittable): Remove unused variable.
8713 (Fwindow_buffer): Move up and rewrite doc-string.
8714 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8715 (Fwindow_prev): New functions.
8716 (Fwindow_frame): Move here from frame.c. Accept any window as
8718 (Fframe_root_window, Fframe_first_window)
8719 (Fframe_selected_window): Move here from frame.c. Accept frame
8720 or arbitrary window as argument. Update doc-strings.
8721 (Fminibuffer_window): Move up in code.
8722 (Fwindow_minibuffer_p): Move up in code and simplify.
8723 (Fset_frame_selected_window): Move here from frame.c.
8725 (Fselected_window, select_window, Fselect_window): Move up in
8726 code. Minor doc-string fixes.
8728 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8730 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8731 Do not assume that spare memory exists; that assumption is valid
8732 only if SYSTEM_MALLOC.
8733 (LARGE_REQUEST): New macro, so that the issue of large requests
8734 is separated from the issue of spare memory.
8736 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8738 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8741 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8743 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8746 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8748 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8750 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8752 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8753 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8755 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8757 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8759 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8761 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8762 (x_clipboard_manager_save): Add return value.
8763 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8765 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8766 Obey Vx_select_enable_clipboard_manager. Catch errors in
8767 x_clipboard_manager_save (Bug#8779).
8768 (Vx_select_enable_clipboard_manager): New variable.
8769 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8771 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8773 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8775 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8777 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8778 in the current matrix if keep_current_p is non-zero.
8780 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8782 * bidi.c (bidi_level_of_next_char): Fix last change.
8784 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8786 Support bidi reordering of text covered by display properties.
8788 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8789 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8790 (bidi_cache_search, bidi_cache_iterator_state)
8791 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8792 (bidi_level_of_next_char, bidi_move_to_visually_next):
8793 Support character positions inside a run of characters covered by a
8795 (bidi_paragraph_init, bidi_resolve_explicit_1)
8796 (bidi_level_of_next_char): Call bidi_fetch_char and
8797 bidi_fetch_char_advance instead of FETCH_CHAR and
8799 (bidi_init_it): Initialize new members.
8800 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8802 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8803 instead of using explicit *_CHAR codes.
8804 (bidi_resolve_explicit, bidi_resolve_weak):
8805 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8806 bidirectional text is supported only in multibyte buffers.
8807 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8808 it to initialize the frame_window_p member of struct bidi_it.
8809 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8810 (bidi_resolve_explicit, bidi_resolve_weak)
8811 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8812 bidi_it->nchars is non-positive.
8813 (bidi_level_of_next_char): Don't try to lookup the cache for the
8814 next/previous character if nothing is cached there yet, or if we
8815 were just reseat()'ed to a new position.
8817 * xdisp.c (set_cursor_from_row): Set start and stop points
8818 according to the row's direction when priming the loop that looks
8819 for the glyph on which to display cursor.
8820 (single_display_spec_intangible_p): Function deleted.
8821 (display_prop_intangible_p): Reimplement to call
8822 handle_display_spec instead of single_display_spec_intangible_p.
8823 Accept 3 additional arguments needed by handle_display_spec.
8824 This fixes incorrect cursor motion across display property with complex
8825 values: lists, `(when COND...)' forms, etc.
8826 (single_display_spec_string_p): Support property values that are
8827 lists with the argument STRING its top-level element.
8828 (display_prop_string_p): Fix the condition for processing a
8829 property that is a list to be consistent with handle_display_spec.
8830 (handle_display_spec): New function, refactored from the
8831 last portion of handle_display_prop.
8832 (compute_display_string_pos): Accept additional argument
8833 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8834 value of a `display' property is a "replacing spec".
8835 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8836 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8837 the display property, but just return a value indicating whether
8838 the display property will replace the characters it covers.
8839 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8840 frame_window_p members of struct bidi_it.
8841 (compute_display_string_pos, compute_display_string_end):
8843 (push_it): Accept second argument POSITION, where pop_it should
8844 jump to continue iteration.
8845 (reseat_1): Initialize bidi_it.disp_pos.
8847 * keyboard.c (adjust_point_for_property): Adjust the call to
8848 display_prop_intangible_p to its new signature.
8850 * dispextern.h (struct bidi_it): New member frame_window_p.
8851 (bidi_init_it): Update prototypes.
8852 (display_prop_intangible_p): Update prototype.
8853 (compute_display_string_pos, compute_display_string_end):
8855 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8858 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8860 Malloc failure behavior now depends on size of allocation.
8861 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8862 * lisp.h: Change signatures accordingly.
8863 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8864 All callers changed. (Bug#8762)
8866 * gnutls.c: Use Emacs's memory allocators.
8867 Without this change, the gnutls library would invoke malloc etc.
8868 directly, which causes problems on non-SYNC_INPUT hosts, and which
8869 runs afoul of improving memory_full behavior. (Bug#8761)
8870 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8871 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8872 xfree instead of the default malloc, realloc, free.
8873 (Fgnutls_boot): No need to check for memory allocation failure,
8874 since xmalloc does that for us.
8876 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8877 * category.c (hash_get_category_set):
8878 * ccl.c (ccl_driver):
8879 * charset.c (Fdefine_charset_internal):
8880 * charset.h (struct charset.hash_index):
8881 * composite.c (get_composition_id, gstring_lookup_cache)
8882 (composition_gstring_put_cache):
8883 * composite.h (struct composition.hash_index):
8884 * dispextern.h (struct image.hash):
8885 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8886 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8887 (hashfn_equal, hashfn_user_defined, make_hash_table)
8888 (maybe_resize_hash_table, hash_lookup, hash_put)
8889 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8890 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8891 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8892 * image.c (make_image, search_image_cache, lookup_image)
8893 (xpm_put_color_table_h):
8894 * lisp.h (struct Lisp_Hash_Table):
8895 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8896 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8897 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8898 * alloc.c (allocate_vectorlike):
8899 Check for overflow in vector size calculations.
8900 * ccl.c (ccl_driver):
8901 Check for overflow when converting EMACS_INT to int.
8902 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8903 need to be updated by these changes.
8904 * fns.c (make_hash_table, maybe_resize_hash_table):
8905 Check for integer overflow with large hash tables.
8906 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8907 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8908 (SXHASH_REDUCE): New macro.
8909 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8910 Use it instead of discarding useful hash info with large hash values.
8911 (sxhash_float): New function.
8912 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8913 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8914 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8915 Rewrite to use FIXNUM_BITS, as this simplifies things.
8916 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8917 Adjust signatures to match updated version of code.
8918 (consing_since_gc): Now EMACS_INT, since a single hash table can
8919 use more than INT_MAX bytes.
8921 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8923 Make it possible to build with GCC-4.6+ -O2 -flto.
8925 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8927 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8929 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8930 Call minibuffer-inactive-mode.
8932 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8934 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8935 Update dependencies.
8937 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8939 * data.c (init_data): Remove code for UTS, this system is not
8942 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8944 Don't force ./temacs to start in terminal mode.
8946 * frame.c (make_initial_frame): Initialize faces in all cases, not
8947 only when CANNOT_DUMP is defined.
8948 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8950 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8952 * dispnew.c (add_window_display_history): Use const for the string
8953 pointer. Remove declaration, not needed.
8955 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8957 Use 'inline', not 'INLINE'.
8958 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8959 * alloc.c, fontset.c (INLINE): Remove.
8960 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8961 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8962 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8963 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8964 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8966 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8968 Make it possible to run ./temacs.
8970 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8971 syms_of_callproc does the same thing. Remove test for
8972 "initialized", do it in the caller.
8973 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8975 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8977 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8978 (read_minibuf): Use get_minibuffer.
8979 (syms_of_minibuf): Use DEFSYM.
8980 (Qmetadata): New var.
8981 * data.c (Qbuffer): Don't make it static.
8982 (syms_of_data): Use DEFSYM.
8984 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8986 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8987 (CCL_CODE_MIN): New macro.
8989 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8991 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8993 * eval.c (Qdebug): Now static.
8994 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8995 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8996 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8998 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9000 * image.c: Various fixes to ImageMagick code comments.
9001 (Fimagemagick_types): Doc fix.
9003 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9005 Minor fixes prompted by GCC 4.6.0 warnings.
9007 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9009 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9010 (x_clipboard_manager_save_all): Move extern decl to ...
9011 * xterm.h: ... here, so that it can be checked for consistency.
9013 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9015 * xselect.c (x_clipboard_manager_save_frame)
9016 (x_clipboard_manager_save_all): New functions.
9017 (Fx_clipboard_manager_save): Lisp function deleted.
9019 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9020 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9022 * xterm.h: Update prototype.
9024 2011-05-28 William Xu <william.xwl@gmail.com>
9026 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9029 2011-05-28 Jim Meyering <meyering@redhat.com>
9031 Avoid a sign-extension bug in crypto_hash_function.
9032 * fns.c (to_uchar): Define.
9033 (crypto_hash_function): Use it to convert some newly-signed
9034 variables to unsigned, to avoid sign-extension bugs. For example,
9035 without this change, (md5 "truc") would evaluate to
9036 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9037 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9038 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9040 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9042 Integer overflow fixes.
9044 * dbusbind.c: Serial number integer overflow fixes.
9045 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9046 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9047 to hold a serial number that is too large for a fixnum.
9048 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9049 Check for serial numbers out of range. Decode any serial number
9050 that was so large that it became a float. (Bug#8722)
9052 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9054 Use XFASTINT rather than XUINT when numbers are nonnegative.
9055 (xd_append_arg, Fdbus_method_return_internal):
9056 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9057 arguments, check that Lisp number is nonnegative, rather than
9058 silently wrapping negative numbers around. (Bug#8722)
9059 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9062 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9064 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9066 ccl: Add integer overflow checks.
9067 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9068 (IN_INT_RANGE): New macros.
9069 (ccl_driver): Use them to check for integer overflow when
9070 decoding a CCL program. Many of the new checks are whether XINT (x)
9071 fits in int; it doesn't always, on 64-bit hosts. The new version
9072 doesn't catch all possible integer overflows, but it's an
9073 improvement. (Bug#8719)
9075 * alloc.c (make_event_array): Use XINT, not XUINT.
9076 There's no need for unsigned here.
9078 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9079 This follows up to the 2011-05-06 change that substituted uintptr_t
9080 for EMACS_INT. This case wasn't caught back then.
9082 Rework Fformat to avoid integer overflow issues.
9083 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9084 now (part of C89). Include <verify.h>.
9085 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9086 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9087 (Fformat): Avoid the prepass trying to compute sizes; it was only
9088 approximate and thus did not catch overflow reliably. Instead, walk
9089 through the format just once, formatting and computing sizes as we go,
9090 checking for integer overflow at every step, and allocating a larger
9091 buffer as needed. Keep track separately whether the format is
9092 multibyte. Keep only the most-recently calculated precision, rather
9093 than them all. Record whether each argument has been converted to
9094 string. Use EMACS_INT, not int, for byte and char and arg counts.
9095 Support field widths and precisions larger than INT_MAX. Avoid
9096 sprintf's undefined behavior with conversion specifications such as %#d
9097 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9098 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9099 formatting out-of-range floating point numbers with int
9102 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9104 * data.c: Avoid integer truncation in expressions involving floats.
9105 * data.c: Include <intprops.h>.
9106 (arith_driver): When there's an integer overflow in an expression
9107 involving floating point, convert the integers to floating point
9108 so that the resulting value does not suffer from catastrophic
9109 integer truncation. For example, on a 64-bit host (* 4
9110 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9111 Do not rely on undefined behavior after integer overflow.
9113 merge count_size_as_multibyte, parse_str_to_multibyte
9114 * character.c, character.h (count_size_as_multibyte):
9115 Rename from parse_str_to_multibyte; all uses changed.
9116 Check for integer overflow.
9117 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9118 since it's now a duplicate of the other. This is more of
9119 a character than a buffer op, so better that it's in character.c.
9120 * fns.c, print.c: Adjust to above changes.
9122 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9124 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9126 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9128 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9129 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9130 (x_clipboard_manager_save): Now static.
9131 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9133 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9134 (crypto_hash_function): Now static.
9135 Fix pointer signedness problems. Avoid unnecessary initializations.
9137 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9139 * termhooks.h (Vselection_alist): Make it terminal-local.
9141 * terminal.c (create_terminal): Initialize it.
9143 * xselect.c: Support for clipboard managers.
9144 (Vselection_alist): Move to termhooks.h as terminal-local var.
9145 (LOCAL_SELECTION): New macro.
9146 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9147 (symbol_to_x_atom): Remove gratuitous arg.
9148 (x_handle_selection_request, lisp_data_to_selection_data)
9149 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9150 (x_own_selection, x_get_local_selection, x_convert_selection):
9151 New arg, specifying work frame. Use terminal-local Vselection_alist.
9152 (some_frame_on_display): Delete unused function.
9153 (Fx_own_selection_internal, Fx_get_selection_internal)
9154 (Fx_disown_selection_internal, Fx_selection_owner_p)
9155 (Fx_selection_exists_p): New optional frame arg.
9156 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9157 (x_handle_selection_clear): Don't treat other terminals with the
9158 same keyboard specially. Use the terminal-local Vselection_alist.
9159 (x_clear_frame_selections): Use Frun_hook_with_args.
9161 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9163 * xterm.h: Add support for those atoms.
9165 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9167 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9168 (converted_selections, conversion_fail_tag): New global variables.
9169 (x_selection_request_lisp_error): Free the above.
9170 (x_get_local_selection): Remove unnecessary code.
9171 (x_reply_selection_request): Args changed; handle arbitrary array
9172 of converted selections stored in converted_selections.
9173 Separate the XChangeProperty and SelectionNotify steps.
9174 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9175 (x_convert_selection): New function.
9176 (x_handle_selection_event): Simplify.
9177 (x_get_foreign_selection): Don't ignore incoming requests while
9178 waiting for an answer; this will fail when we implement
9179 SAVE_TARGETS, and seems unnecessary anyway.
9180 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9181 (Vx_sent_selection_functions): Doc fix.
9183 2011-05-26 Leo Liu <sdl.web@gmail.com>
9185 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9187 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9189 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9191 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9192 for fringe update if it has periodic bitmap.
9193 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9194 and fringe_bitmap_periodic_p.
9196 * fringe.c (get_fringe_bitmap_data): New function.
9197 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9198 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9199 row. Mark glyph row for fringe update if periodicity changed.
9201 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9202 for fringe update unless it has periodic bitmap.
9204 2011-05-25 Kenichi Handa <handa@m17n.org>
9206 * xdisp.c (get_next_display_element): Set correct it->face_id for
9207 a static composition.
9209 2011-05-24 Leo Liu <sdl.web@gmail.com>
9212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9214 * fns.c (crypto_hash_function, Fsha1): New function.
9215 (Fmd5): Use crypto_hash_function.
9216 (syms_of_fns): Add Ssha1.
9218 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9220 * gnutls.c: Remove unused macros.
9221 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9222 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9223 Remove macros that are defined and never used.
9224 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9226 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9228 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9229 (Fx_get_selection_internal): Minor cleanup.
9230 (Fx_own_selection_internal): Rename arguments for consistency with
9233 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9235 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9237 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9239 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9241 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9243 * dispnew.c (scrolling_window): Don't exclude the case that the
9244 last enabled row in the desired matrix touches the bottom boundary.
9246 2011-05-21 Glenn Morris <rgm@gnu.org>
9248 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9249 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9250 and add some more files.
9252 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9254 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9255 report_file_error introduced by the change from 2011-05-07.
9257 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9259 * systime.h (Time): Define only if emacs is defined.
9260 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9261 where the include path doesn't have X11/X.h by default. See
9262 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9264 2011-05-20 Kenichi Handa <handa@m17n.org>
9266 * composite.c (find_automatic_composition): Fix previous change.
9268 2011-05-20 Glenn Morris <rgm@gnu.org>
9270 * lisp.mk: New file, split from Makefile.in.
9271 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9272 (shortlisp): Remove.
9273 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9275 2011-05-19 Glenn Morris <rgm@gnu.org>
9277 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9278 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9279 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9280 (lisp): Set the order to that of loadup.el.
9281 (shortlisp): Make it a copy of $lisp.
9282 (SOME_MACHINE_LISP): Remove.
9283 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9284 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9286 2011-05-18 Kenichi Handa <handa@m17n.org>
9288 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9289 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9290 (find_automatic_composition): Mostly rewrite for efficiency.
9292 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9294 * makefile.w32-in: Update dependencies.
9296 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9298 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9299 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9301 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9303 Fix some integer overflow issues, such as string length overflow.
9305 * insdel.c (count_size_as_multibyte): Check for string overflow.
9307 * character.c (lisp_string_width): Check for string overflow.
9308 Use EMACS_INT, not int, for string indexes and lengths; in
9309 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9310 the resulting string length overflows an EMACS_INT; instead,
9311 report a string overflow if no precision given. When checking for
9312 precision exhaustion, use a check that cannot possibly have
9313 integer overflow. (Bug#8675)
9314 * character.h (lisp_string_width): Adjust to new signature.
9316 * alloc.c (string_overflow): New function.
9317 (Fmake_string): Use it. This doesn't change behavior, but saves
9318 a few bytes and will simplify future changes.
9319 * character.c (string_escape_byte8): Likewise.
9320 * lisp.h (string_overflow): New decl.
9322 Fixups, following up to the user-interface timestamp change.
9323 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9324 for UI timestamps, instead of unsigned long.
9325 * msdos.c (mouse_get_pos): Likewise.
9326 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9327 * w32gui.h (Time): Define by including "systime.h" rather than by
9328 declaring it ourselves. (Bug#8664)
9330 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9331 * image.c (clear_image_cache): Likewise.
9333 * term.c (term_mouse_position): Don't assume time_t wraparound.
9335 Be more systematic about user-interface timestamps.
9336 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9337 and sometimes 'EMACS_UINT', to represent these timestamps.
9338 This change causes it to use 'Time' uniformly, as that's what X uses.
9339 This makes the code easier to follow, and makes it easier to catch
9340 integer overflow bugs such as Bug#8664.
9341 * frame.c (Fmouse_position, Fmouse_pixel_position):
9342 Use Time, not unsigned long, for user-interface timestamps.
9343 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9344 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9345 * keyboard.h (last_event_timestamp): Likewise.
9346 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9347 * menu.h (xmenu_show): Likewise.
9348 * term.c (term_mouse_position): Likewise.
9349 * termhooks.h (struct input_event.timestamp): Likewise.
9350 (struct terminal.mouse_position_hook): Likewise.
9351 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9352 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9353 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9354 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9356 * menu.h, termhooks.h: Include "systime.h", for Time.
9358 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9359 Don't assume that the difference between two unsigned long values
9360 can fit into an integer. At this point, we know button_down_time
9361 <= event->timestamp, so the difference must be nonnegative, so
9362 there's no need to cast the result if double-click-time is
9363 nonnegative, as it should be; check that it's nonnegative, just in
9364 case. This bug is triggered when events are more than 2**31 ms
9365 apart (about 25 days). (Bug#8664)
9367 * xselect.c (last_event_timestamp): Remove duplicate decl.
9368 (x_own_selection): Remove needless cast to unsigned long.
9370 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9371 that always fit in int. Use a sentinel instead of a counter, to
9372 avoid a temp and to allay GCC's concerns about possible int overflow.
9373 * frame.h (struct frame): Use int for menu_bar_items_used
9374 instead of EMACS_INT, since it always fits in int.
9376 * menu.c (grow_menu_items): Check for int overflow.
9378 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9380 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9381 Before, the code was not consistent. These values cannot exceed
9382 2**31 - 1 so there's no need to make them unsigned.
9383 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9384 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9385 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9387 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9389 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9390 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9391 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9392 presumably because the widths might not match.
9394 * window.c (size_window): Avoid needless test at loop start.
9396 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9398 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9400 2011-05-12 Drew Adams <drew.adams@oracle.com>
9402 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9404 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9406 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9407 `width' to `bar_area_x' and `bar_area_width', respectively.
9408 (x_scroll_run): Take account of fringe background extension.
9410 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9411 Rename local vars `left' and `width' to `bar_area_x' and
9412 `bar_area_width', respectively.
9413 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9414 background extension.
9416 2011-05-10 Jim Meyering <meyering@redhat.com>
9418 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9420 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9422 * image.c (Finit_image_library): Return t for built-in image types,
9423 like pbm and xbm. (Bug#8640)
9425 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9427 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9429 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9431 * w32console.c (Fset_screen_color): Doc fix.
9432 (Fget_screen_color): New function.
9433 (syms_of_ntterm): Defsubr it.
9435 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9436 unlink the temporary file if Fcall_process didn't create it in the
9438 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9439 child process will be redirected to a file specified with `:file'.
9440 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9441 cue to call_process_cleanup not to close that handle.
9443 2011-05-07 Ben Key <bkey76@gmail.com>
9445 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9446 one of two shell specific rules, either bootstrap-temacs-CMD or
9447 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9448 to the previous implementation of the bootstrap-temacs rule.
9449 The bootstrap-temacs-CMD rule is similar to the previous
9450 implementation of the bootstrap-temacs rule except that it
9451 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9454 These changes, along with some changes to nt/configure.bat,
9455 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9456 earlier fix to add support for --cflags and --ldflags options
9457 that include quotes so that it works whether make uses cmd or
9460 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9462 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9463 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9465 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9466 a string. Handle both cases.
9467 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9468 (Fdbus_register_method): Use Qinvalid_function.
9470 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9472 * makefile.w32-in: Update dependencies.
9473 (LISP_H): Add inttypes.h and stdin.h.
9474 (PROCESS_H): Add unistd.h.
9476 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9478 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9479 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9481 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9483 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9485 * term.c (vfatal): Remove stray call to va_end.
9486 It's not needed and the C Standard doesn't allow it here anyway.
9488 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9489 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9491 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9494 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9498 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9500 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9502 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9504 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9505 * charset.c (Fdefine_charset_internal): Don't initialize
9506 charset.code_space[15]. The value was garbage, on hosts with
9507 32-bit int (Bug#8600).
9509 * lread.c (read_integer): Be more consistent with string-to-number.
9510 Use string_to_number to do the actual conversion; this avoids
9511 rounding errors and fixes some other screwups. Without this fix,
9512 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9513 (digit_to_number): Move earlier, for benefit of read_integer.
9514 Return -1 if the digit is out of range for the base, -2 if it is
9515 not a digit in any supported base. (Bug#8602)
9517 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9519 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9520 to match comment at start of function. This also removes a
9521 GCC warning about overflow in a 32+64-bit port.
9523 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9525 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9526 Reported by Stefan Monnier in
9527 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9528 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9529 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9531 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9532 (EMACS_UINTPTR): Likewise, with uintptr_t.
9534 * lisp.h: Prefer 64-bit EMACS_INT if available.
9535 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9536 on 32-bit hosts that have 64-bit int, so that they can access
9538 However, temporarily disable this change unless the temporary
9539 symbol WIDE_EMACS_INT is defined.
9541 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9543 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9544 This removes an assumption that EMACS_INT and long are the same
9545 width as pointers. The assumption is true for Emacs porting targets
9546 now, but we want to make other targets possible.
9547 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9548 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9549 In the rest of the code, change types of integers that hold casted
9550 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9551 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9552 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9553 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9554 No need to cast type when ORing.
9555 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9556 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9557 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9558 assume EMACS_INT is the same width as char *.
9559 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9560 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9561 Remove no-longer-needed casts.
9562 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9563 (xg_tool_bar_help_callback, xg_make_tool_item):
9564 Use EMACS_INTPTR to hold an integer
9565 that will be cast to void *; this can avoid a GCC warning
9566 if EMACS_INT is not the same width as void *.
9567 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9568 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9569 (current_message_1, set_message_1):
9570 Use a local to convert to proper width without a cast.
9571 * xmenu.c (dialog_selection_callback): Likewise.
9573 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9574 Also, don't assume VALBITS / RAND_BITS is less than 5,
9575 and don't rely on undefined behavior when shifting a 1 left into
9577 * lisp.h (get_random): Change signature to match.
9579 * lread.c (hash_string): Use size_t, not int, for hash computation.
9580 Normally we prefer signed values; but hashing is special, because
9581 it's better to use unsigned division on hash table sizes so that
9582 the remainder is nonnegative. Also, size_t is the natural width
9583 for hashing into memory. The previous code used 'int', which doesn't
9584 retain enough info to hash well into very large tables.
9585 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9587 * dbusbind.c: Don't possibly lose pointer info when converting.
9588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9589 Use XPNTR rather than XHASH, so that the high-order bits of
9590 the pointer aren't lost when converting through void *.
9592 * eval.c (Fautoload): Don't double-shift a pointer.
9594 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9596 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9598 * gnutls.c (DEF_GNUTLS_FN):
9599 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9601 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9603 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9606 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9608 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9609 New version that can reserve upto 2GB of heap space.
9611 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9613 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9615 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9617 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9618 `gnutls_certificate_set_x509_key_file'.
9620 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9622 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9623 Update dependencies.
9625 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9627 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9628 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9629 Remove unused parameter `fildes'.
9630 * process.c (read_process_output, send_process): Don't pass it.
9632 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9634 Fix previous change: the library cache is defined in w32.c.
9635 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9636 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9638 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9640 Implement dynamic loading of GnuTLS on Windows.
9642 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9643 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9644 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9647 * gnutls.c (Qgnutls_dll): Define.
9648 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9649 (gnutls_*): Declare function pointers.
9650 (init_gnutls_functions): New function to initialize function pointers.
9651 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9652 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9653 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9654 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9655 (emacs_gnutls_write, emacs_gnutls_read)
9656 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9657 (Fgnutls_available_p): New function.
9658 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9659 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9660 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9662 * image.c: Include w32.h.
9663 (Vimage_type_cache): Delete.
9664 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9665 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9666 (w32_delayed_load): Move to w32.c.
9668 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9670 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9671 (w32_delayed_load): Move from image.c. When loading a library, record
9672 its filename in the :loaded-from property of the library id.
9673 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9674 Initialize and staticpro them.
9675 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9677 * process.c: Include lisp.h before w32.h, not after.
9678 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9679 instead of gnutls_record_check_pending.
9681 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9683 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9685 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9686 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9689 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9691 * xterm.c (x_set_frame_alpha): Do not set property on anything
9692 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9694 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9696 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9698 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9700 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9701 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9702 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9703 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9704 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9705 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9706 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9707 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9708 (Qgnutls_bootprop_callbacks_verify): Make static.
9710 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9712 * callproc.c: Indentation fixup.
9714 * sysdep.c (wait_for_termination_1): Make static.
9715 (wait_for_termination, interruptible_wait_for_termination):
9716 Move after wait_for_termination_1.
9718 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9720 * sysdep.c (interruptible_wait_for_termination): New function
9721 which is like wait_for_termination, but allows keyboard
9724 * callproc.c (Fcall_process): Add (:file "file") as an option for
9726 (Fcall_process_region): Ditto.
9728 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9730 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9731 rather than `XVECTOR (FOO)->size'.
9733 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9734 inttypes.h, as a gnulib replacement is used if it not available in
9737 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9739 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9740 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9741 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9743 * coding.c (coding_alloc_by_realloc): Error out if destination
9744 will grow beyond MOST_POSITIVE_FIXNUM.
9745 (decode_coding_emacs_mule): Abort if there isn't enough place in
9746 charbuf for the composition carryover bytes. Reserve an extra
9747 space for up to 2 characters produced in a loop.
9748 (decode_coding_iso_2022): Abort if there isn't enough place in
9749 charbuf for the composition carryover bytes.
9751 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9753 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9754 aborting when %lld or %lll format is passed.
9755 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9756 %llo or %llx format is passed. (Bug#8545)
9758 * window.c (window_scroll_line_based): Use a marker instead of
9759 simple variables to record original value of point. (Bug#7952)
9761 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9762 produced by %s or %c overflows available buffer space. (Bug#8545)
9764 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9766 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9767 (SIZE_MAX): Move defn after all includes, as they might #define it.
9769 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9771 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9773 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9775 * keyboard.c (Qdelayed_warnings_hook): Define.
9776 (command_loop_1): Run `delayed-warnings-hook'
9777 if Vdelayed_warnings_list is non-nil.
9778 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9779 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9781 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9783 * doprnt.c (doprnt): Don't return value smaller than the buffer
9784 size if the message was truncated. (Bug#8545).
9786 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9788 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9789 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9791 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9793 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9795 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9797 * makefile.w32-in: Update dependencies.
9799 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9801 Improve `doprnt' and its usage. (Bug#8545)
9802 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9803 `format_end'. Remove support for %l as a conversion specifier.
9804 Don't use xrealloc. Improve diagnostics when the %l size modifier
9805 is used. Update the commentary.
9807 * eval.c (verror): Simplify calculation of size_t.
9809 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9812 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9814 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9817 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9819 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9820 This makes this file independent of the recent pseudovector change.
9822 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9824 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9826 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9827 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9828 Remove unused local.
9829 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9831 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9832 GCC 4.6.0 optimizes based on type-based alias analysis.
9833 For example, if b is of type struct buffer * and v of type struct
9834 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9835 != &v->size, and therefore "v->size = 1; b->size = 2; return
9836 v->size;" must therefore return 1. This assumption is incorrect
9837 for Emacs, since it type-puns struct Lisp_Vector * with many other
9838 types. To fix this problem, this patch adds a new type struct
9839 vectorlike_header that documents the constraints on layout of vectors
9840 and pseudovectors, and helps optimizing compilers not get fooled
9841 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9842 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9843 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9845 (XSETPVECTYPE): Rewrite in terms of new macro.
9846 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9847 This is a bit clearer, and further avoids the possibility of
9848 undesirable aliasing.
9849 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9850 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9851 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9852 since Lisp_Subr is a special case (no "next" field).
9853 (ASIZE): Now uses header.size rather than size.
9854 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9855 to avoid the hassle of writing XVECTOR (foo)->header.size.
9856 (struct vectorlike_header): New type.
9857 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9858 object, to help avoid aliasing.
9859 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9860 (SUBRP): Likewise, since Lisp_Subr is a special case.
9861 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9862 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9863 (struct Lisp_Hash_Table): Combine first two members into a single
9864 struct vectorlike_header member. All uses of "size" and "next" members
9865 changed to be "header.size" and "header.next".
9866 * buffer.h (struct buffer): Likewise.
9867 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9868 * frame.h (struct frame): Likewise.
9869 * process.h (struct Lisp_Process): Likewise.
9870 * termhooks.h (struct terminal): Likewise.
9871 * window.c (struct save_window_data, struct saved_window): Likewise.
9872 * window.h (struct window): Likewise.
9873 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9874 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9875 * buffer.c (init_buffer_once): Likewise.
9876 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9878 * process.c (Fformat_network_address): Use local var for size,
9881 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9883 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9884 * data.c (atof): Remove decl; no longer used or needed.
9885 (digit_to_number): Move to lread.c.
9886 (Fstring_to_number): Use new string_to_number function, to be
9887 consistent with how the Lisp reader treats infinities and NaNs.
9888 Do not assume that floating-point numbers represent EMACS_INT
9889 without losing information; this is not true on most 64-bit hosts.
9890 Avoid double-rounding errors, by insisting on integers when
9891 parsing non-base-10 numbers, as the documentation specifies.
9892 * lisp.h (string_to_number): New decl, replacing ...
9893 (isfloat_string): Remove.
9894 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9895 (read1): Do not accept +. and -. as integers; this
9896 appears to have been a coding error. Similarly, do not accept
9897 strings like +-1e0 as floating point numbers. Do not report
9898 overflow for integer overflows unless the base is not 10 which
9899 means we have no simple and reliable way to continue.
9900 Break out the floating-point parsing into a new
9901 function string_to_number, so that Fstring_to_number parses
9902 floating point numbers consistently with the Lisp reader.
9903 (digit_to_number): Move here from data.c. Make it static inline.
9904 (E_CHAR, EXP_INT): Remove, replacing with ...
9905 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9906 (string_to_number): New function, replacing isfloat_string.
9907 This function checks for valid syntax and produces the resulting
9908 Lisp float number too. Rework it so that string-to-number
9909 no longer mishandles examples like "1.0e+". Use strtoumax,
9910 so that overflow for non-base-10 numbers is reported only when
9911 there's no portable and simple way to convert to floating point.
9913 * textprop.c (set_text_properties_1): Rewrite for clarity,
9914 and to avoid GCC warning about integer overflow.
9916 * intervals.h (struct interval): Use EMACS_INT for members
9917 where EMACS_UINT might cause problems. See
9918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9919 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9920 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9922 (offset_intervals): Tell GCC not to worry about length overflow
9923 when negating a negative length.
9925 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9926 (overrun_check_free): Likewise.
9928 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9929 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9932 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9933 (gnutls_make_error): Rename local to avoid shadowing.
9934 (gnutls_emacs_global_deinit): ifdef out; not used.
9935 (Fgnutls_boot): Use const for pointer to readonly storage.
9936 Comment out unused local. Fix pointer signedness problems.
9938 * lread.c (openp): Don't stuff size_t into an 'int'.
9939 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9940 about possible signed overflow.
9942 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9943 (GDK_KEY_g): Don't define if already defined.
9944 (xg_prepare_tooltip): Avoid pointer signedness problem.
9945 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9947 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9948 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9950 * xfns.c (Fx_window_property): Simplify a bit,
9951 to make a bit faster and to avoid GCC 4.6.0 warning.
9952 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9954 * fns.c (internal_equal): Don't assume size_t fits in int.
9956 * alloc.c (compact_small_strings): Tighten assertion a little.
9958 Replace pEd with more-general pI, and fix some printf arg casts.
9959 * lisp.h (pI): New macro, generalizing old pEd macro to other
9960 conversion specifiers. For example, use "...%"pI"d..." rather
9961 than "...%"pEd"...".
9962 (pEd): Remove. All uses replaced with similar uses of pI.
9963 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9964 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9965 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9966 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9967 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9968 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9969 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9971 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9972 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9973 * print.c (safe_debug_print, print_object): Likewise.
9974 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9976 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9977 avoiding the 0 flag, which is not portable.
9978 * process.c (Fmake_network_process): Use pI to avoid cast.
9979 * region-cache.c (pp_cache): Likewise.
9980 * xdisp.c (decode_mode_spec): Likewise.
9981 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9982 behavior on 64-bit hosts with printf arg.
9983 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9984 (x_stop_queuing_selection_requests): Likewise.
9985 (x_get_window_property): Don't truncate byte count to an 'int'
9988 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9989 here, since it parses constructs like leading '-' and spaces,
9990 which are not wanted; and it overflows with large numbers.
9991 Instead, simply match F[0-9]+, which is what is wanted anyway.
9993 * alloc.c: Remove unportable assumptions about struct layout.
9994 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9995 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9996 (allocate_vectorlike, make_pure_vector): Use the new macros,
9997 plus offsetof, to remove unportable assumptions about struct layout.
9998 These assumptions hold on all porting targets that I know of, but
9999 they are not guaranteed, they're easy to remove, and removing them
10000 makes further changes easier.
10002 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10003 This doesn't fix a bug but makes the code clearer.
10004 (string_overrun_cookie): Now const. Use initializers that
10005 don't formally overflow signed char, to avoid warnings.
10006 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10007 can cause Emacs to crash when string overrun checking is enabled.
10008 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10009 multiple of sizeof (EMACS_INT); it need not be, if
10010 alignof(EMACS_INT) < sizeof (EMACS_INT).
10011 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10013 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10015 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10017 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10019 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10020 supposed to be handshaking. (Bug#8556)
10021 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10023 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10025 * lisp.h (Qdebug): List symbol.
10026 * eval.c (Qdebug): Restore global linkage.
10027 * keyboard.c (debug-on-event): New variable.
10028 (handle_user_signal): Break into debugger when debug-on-event
10029 matches the current signal symbol.
10031 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10033 * alloc.c (check_sblock, check_string_bytes)
10034 (check_string_free_list): Convert to standard C.
10036 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10038 * w32.c (emacs_gnutls_push): Fix typo.
10040 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10042 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10043 "cast to pointer from integer of different size".
10045 Improve doprnt and its use in verror. (Bug#8545)
10046 * doprnt.c (doprnt): Document the set of format control sequences
10047 supported by the function. Use SAFE_ALLOCA instead of always
10050 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10051 is one byte too soon. Don't use xrealloc; instead xfree and
10054 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10056 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10059 * gnutls.c: Renamed global_initialized to
10060 gnutls_global_initialized. Added internals for the
10061 :verify-hostname-error, :verify-error, and :verify-flags
10062 parameters of `gnutls-boot' and documented those parameters in the
10063 docstring. Start callback support.
10064 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10065 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10066 on error. Return error code.
10067 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10068 (emacs_gnutls_read): Likewise.
10069 (Fgnutls_boot): Return handshake error code.
10070 (emacs_gnutls_handle_error): New function.
10071 (wsaerror_to_errno): Likewise.
10073 * w32.h (emacs_gnutls_pull): Add prototype.
10074 (emacs_gnutls_push): Likewise.
10076 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10077 (emacs_gnutls_push): Likewise.
10079 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10081 * process.c (wait_reading_process_output): Check if GnuTLS
10082 buffered some data internally if no FDs are set for TLS
10085 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10086 (LIBS): Link to USER_LIBS.
10087 ($(BLD)/gnutls.$(0)): New target.
10089 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10091 * xdisp.c (handle_single_display_spec): Rename the
10092 display_replaced_before_p argument into display_replaced_p, to
10093 make it consistent with the commentary. Fix typos in the
10096 * textprop.c (syms_of_textprop): Remove dead code.
10097 (copy_text_properties): Delete obsolete commentary about an
10098 interface that was deleted long ago. Fix typos in the description
10101 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10102 to changes in oldXMenu/XMenu.h from 2011-04-16.
10103 <menu_help_message, prev_menu_help_message>: Constify.
10104 (IT_menu_make_room): menu->help_text is now `const char **';
10107 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10108 to changes in oldXMenu/XMenu.h from 2011-04-16.
10109 (struct XMenu): Declare `help_text' `const char **'.
10111 * xfaces.c <Qunspecified>: Make extern again.
10113 * syntax.c: Include sys/types.h before including regex.h, as
10116 * doc.c (get_doc_string): Improve the format passed to `error'.
10118 * doprnt.c (doprnt): Improve commentary.
10120 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10122 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10125 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10126 changes in globals.h immediately force recompilation.
10127 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10128 $(CURDIR)/s/ms-w32.h.
10129 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10131 * character.c (Fchar_direction): Function deleted.
10132 (syms_of_character): Don't defsubr it.
10133 <char-direction-table>: Deleted.
10135 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10137 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10138 * doprnt.c: Include limits.h.
10139 (SIZE_MAX): New macro.
10140 (doprnt): Return a size_t value. 2nd arg is now size_t.
10141 Many local variables are now size_t instead of int or unsigned.
10142 Improve overflow protection. Support `l' modifier for integer
10143 conversions. Support %l conversion. Don't assume an EMACS_INT
10144 argument for integer conversions and for %c.
10146 * lisp.h (doprnt): Restore prototype.
10148 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10149 $(SRC)/character.h.
10151 * Makefile.in (base_obj): Add back doprnt.o.
10153 * deps.mk (doprnt.o): Add back prerequisites.
10154 (callint.o): Depend on character.h.
10156 * eval.c (internal_lisp_condition_case): Include the handler
10157 representation in the error message.
10158 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10159 when breaking from the loop.
10161 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10163 * callint.c (Fcall_interactively): When displaying error message
10164 about invalid control letter, pass the character's codepoint, not
10165 a pointer to its multibyte form. Improve display of the character
10166 in octal and display also its hex code.
10168 * character.c (char_string): Use %x to display the (unsigned)
10169 codepoint of an invalid character, to avoid displaying a bogus
10172 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10173 `error', not SYMBOL_NAME itself.
10175 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10176 character arguments to `error'.
10178 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10179 to `error' in error message about FINAL_CHAR argument. Make sure
10180 FINAL_CHAR is a character, and use %c when it is passed as
10181 argument to `error'.
10183 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10185 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10187 * w32.c: Include <time.h>.
10188 (sys_localtime): New function.
10190 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10192 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10194 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10196 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10198 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10199 zombies (Bug#8467).
10201 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10203 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10204 gl_state.e_property when gl_state.object is Qt.
10206 * insdel.c (make_gap_larger): Remove limitation of buffer size
10209 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10211 * xdisp.c (lookup_glyphless_char_display)
10212 (produce_glyphless_glyph): Handle cons cell entry in
10213 glyphless-char-display.
10214 (Vglyphless_char_display): Document it.
10216 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10217 glyphless-char-display.
10219 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10221 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10223 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10226 definition for no-X builds.
10228 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10230 Static checks with GCC 4.6.0 and non-default toolkits.
10232 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10234 * process.c (keyboard_bit_set): Define only if SIGIO.
10235 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10236 (send_process): Repair possible setjmp clobbering.
10238 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10240 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10242 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10244 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10245 Define only if needed.
10247 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10248 by pacifying GCC about it. Maybe it's time to retire it?
10249 * xfaces.c (USG, __TIMEVAL__): Likewise.
10251 * dispextern.h (struct redisplay_interface): Rename param
10252 to avoid shadowing.
10253 * termhooks.h (struct terminal): Likewise.
10254 * xterm.c (xembed_send_message): Likewise.
10256 * insdel.c (make_gap_smaller): Define only if
10257 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10259 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10262 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10263 so that we aren't warned about unused symbols.
10265 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10267 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10269 * xfns.c (x_real_positions): Mark locals as initialized.
10271 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10273 * xterm.c: Fix problems found by static analysis with other toolkits.
10274 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10275 (x_dispatch_event): Declare static if USE_GTK, and
10276 define if USE_GTK || USE_X_TOOLKIT.
10277 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10278 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10279 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10280 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10282 * xmenu.c (menu_help_callback): Pointer type fixes.
10283 Use const pointers when pointing at readonly data. Avoid pointer
10284 signedness clashes.
10285 (FALSE): Remove unused macro.
10286 (update_frame_menubar): Remove unused decl.
10288 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10290 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10291 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10292 (single_menu_item): Rename local to avoid shadowing.
10294 * keyboard.c (make_lispy_event): Remove unused local var.
10296 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10297 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10299 * bitmaps: Change bitmaps from unsigned char back to the X11
10300 compatible char. Avoid the old compiler warnings about
10301 out-of-range initializers by using, for example, '\xab' rather
10304 * xgselect.c (xgselect_initialize): Check vs interface
10305 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10307 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10309 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10310 to read-only memory.
10312 * fns.c (vector): Remove; this old hack is no longer needed.
10314 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10316 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10318 * xrdb.c (x_load_resources): Omit unused local.
10320 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10321 (x_window): Rename locals to avoid shadowing.
10322 (USG): Use the kludged USG macro, to pacify gcc.
10324 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10325 (x_term_init): Remove local to avoid shadowing.
10327 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10329 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10330 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10332 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10334 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10336 Fix regex.c, syntax.c and friends for buffers > 2GB.
10337 * syntax.h (struct gl_state_s): Declare character position members
10340 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10342 * textprop.c (verify_interval_modification, interval_of):
10343 Declare arguments EMACS_INT.
10345 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10348 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10350 * indent.c (Fvertical_motion): Local variable it_start is now
10353 * regex.c (re_match, re_match_2, re_match_2_internal)
10354 (bcmp_translate, regcomp, regexec, print_double_string)
10355 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10356 (re_compile_pattern, re_exec): Declare arguments and local
10357 variables `size_t' and `ssize_t' and return values `regoff_t', as
10359 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10360 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10361 <compile_stack_type>: `size' and `avail' are now `size_t'.
10363 * regex.h <regoff_t>: Use ssize_t, not int.
10364 (re_search, re_search_2, re_match, re_match_2): Arguments that
10365 specify buffer/string position and length are now ssize_t and
10366 size_t. Return type is regoff_t.
10368 2011-04-16 Ben Key <bkey76@gmail.com>
10370 * nsfont.m: Fixed bugs in ns_get_family and
10371 ns_descriptor_to_entity that were caused by using free to
10372 deallocate memory blocks that were allocated by xmalloc (via
10373 xstrdup). This caused Emacs to crash when compiled with
10374 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10375 --enable-checking=xmallocoverrun). xfree is now used to
10376 deallocate these memory blocks.
10378 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10380 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10382 emacs_write: Accept and return EMACS_INT for sizes.
10383 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10385 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10386 Accept and return EMACS_INT.
10387 (emacs_gnutls_write): Return the number of bytes written on
10389 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10390 (emacs_read, emacs_write): Remove check for negative size, as the
10391 Emacs source code has been audited now.
10392 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10393 (emacs_read, emacs_write): Use it.
10394 * process.c (send_process): Adjust to the new signatures of
10395 emacs_write and emacs_gnutls_write. Do not attempt to store
10396 a byte offset into an 'int'; it might overflow.
10397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10399 * sound.c: Don't assume sizes fit in 'int'.
10400 (struct sound_device.period_size, alsa_period_size):
10401 Return EMACS_INT, not int.
10402 (struct sound_device.write, vox_write, alsa_write):
10403 Accept EMACS_INT, not int.
10404 (wav_play, au_play): Use EMACS_INT to store sizes and to
10405 record read return values.
10407 2011-04-15 Ben Key <bkey76@gmail.com>
10409 * keyboard.c (Qundefined): Don't declare static since it is used
10411 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10412 static since they are used in nsfont.m.
10414 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10416 * process.c (Qprocessp): Don't declare static.
10417 * lisp.h (Qprocessp): Declare again.
10419 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10421 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10423 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10425 Improve C-level modularity by making more things 'static'.
10427 Don't publish debugger-only interfaces to other modules.
10428 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10429 (verify_bytepos, count_markers): Move decls to the only modules
10431 * region-cache.h (pp_cache): Likewise.
10432 * window.h (check_all_windows): Likewise.
10433 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10435 * sysdep.c (croak): Now static, if
10436 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10437 * syssignal.h (croak): Declare only if not static.
10439 * alloc.c (refill_memory_reserve): Now static if
10440 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10441 * lisp.h (refill_memory_reserve): Declare only if not static.
10443 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10444 Define only if USE_LUCID.
10446 * xrdb.c (x_customization_string, x_rm_string): Now static.
10448 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10449 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10451 * xdisp.c (draw_row_with_mouse_face): Now static.
10452 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10454 * window.h (check_all_windows): Mark externally visible.
10456 * window.c (window_deletion_count): Now static.
10458 * undo.c: Make symbols static if they're not exported.
10459 (last_undo_buffer, last_boundary_position, pending_boundary):
10462 * textprop.c (interval_insert_behind_hooks): Now static.
10463 (interval_insert_in_front_hooks): Likewise.
10465 * term.c: Make symbols static if they're not exported.
10466 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10467 (max_frame_lines, tty_set_terminal_modes):
10468 (tty_reset_terminal_modes, tty_turn_off_highlight):
10469 (get_tty_terminal): Now static.
10470 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10471 * termhooks.h (term_mouse_moveto): Do not declare if
10472 HAVE_WINDOW_SYSTEM.
10473 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10474 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10476 * sysdep.c: Make symbols static if they're not exported.
10477 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10479 (sigprocmask_set, full_mask): Remove; unused.
10480 (wait_debugging): Mark as visible.
10481 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10482 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10484 * syntax.c (syntax_temp): Define only if !__GNUC__.
10486 * sound.c (current_sound_device, current_sound): Now static.
10488 * search.c (searchbufs, searchbuf_head): Now static.
10490 * scroll.c (scroll_cost): Remove; unused.
10491 * dispextern.h (scroll_cost): Remove decl.
10493 * region-cache.h (pp_cache): Mark as externally visible.
10495 * process.c: Make symbols static if they're not exported.
10496 (process_tick, update_tick, create_process, chan_process):
10497 (Vprocess_alist, proc_buffered_char, datagram_access):
10498 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10499 (deactivate_process): Mark defn as static, as well as decl.
10500 * lisp.h (create_process): Remove decl.
10501 * process.h (chan_process, Vprocess_alist): Remove decls.
10503 * print.c: Make symbols static if they're not exported.
10504 (print_depth, new_backquote_output, being_printed, print_buffer):
10505 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10506 (print_interval, print_number_index, initial_stderr_stream):
10508 * lisp.h (Fprinc): Remove decl.
10509 (debug_output_compilation_hack): Mark as externally visible.
10511 * sysdep.c (croak): Move decl from here to syssignal.h.
10512 * syssignal.h (croak): Put it here, so the API can be checked when
10513 'croak' is called from dissociate_if_controlling_tty.
10515 * minibuf.c: Make symbols static if they're not exported.
10516 (minibuf_save_list, choose_minibuf_frame): Now static.
10517 * lisp.h (choose_minibuf_frame): Remove decl.
10519 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10521 * lread.c: Make symbols static if they're not exported.
10522 (read_objects, initial_obarray, oblookup_last_bucket_number):
10524 (make_symbol): Remove; unused.
10525 * lisp.h (initial_obarray, make_symbol): Remove decls.
10527 * keyboard.c: Make symbols static if they're not exported.
10528 (single_kboard, recent_keys_index, total_keys, recent_keys):
10529 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10530 (this_single_command_key_start, echoing, last_auto_save):
10531 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10532 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10533 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10534 (Vlispy_mouse_stem, double_click_count):
10536 (force_auto_save_soon): Define only if SIGDANGER.
10537 (ignore_mouse_drag_p): Now static if
10538 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10539 (print_help): Remove; unused.
10540 (stop_character, last_timer_event): Mark as externally visible.
10541 * keyboard.h (ignore_mouse_drag_p): Declare only if
10542 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10543 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10544 * lisp.h (echoing): Remove decl.
10545 (force_auto_save_soon): Declare only if SIGDANGER.
10546 * xdisp.c (redisplay_window): Simplify code, to make it more
10547 obvious that ignore_mouse_drag_p is not accessed if !defined
10548 USE_GTK && !defined HAVE_NS.
10550 * intervals.c: Make symbols static if they're not exported.
10551 (merge_properties_sticky, merge_interval_right, delete_interval):
10553 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10555 * insdel.c: Make symbols static if they're not exported.
10556 However, leave prepare_to_modify_buffer alone. It's never
10557 called from outside this function, but that appears to be a bug.
10558 (combine_after_change_list, combine_after_change_buffer):
10559 (adjust_after_replace, signal_before_change): Now static.
10560 (adjust_after_replace_noundo): Remove; unused.
10561 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10562 (signal_before_change): Remove decls.
10564 * indent.c (val_compute_motion, val_vmotion): Now static.
10566 * image.c: Make symbols static if they're not exported.
10567 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10569 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10570 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10572 * fringe.c (standard_bitmaps): Now static.
10573 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10575 * frame.c: Make symbols static if they're not exported.
10576 (x_report_frame_params, make_terminal_frame): Now static.
10577 (get_frame_param): Now static, unless HAVE_NS.
10578 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10579 (x_get_resource_string): Remove; not used.
10580 * frame.h (make_terminal_frame, x_report_frame_params):
10581 (x_get_resource_string); Remove decls.
10582 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10583 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10585 * font.c, fontset.c: Make symbols static if they're not exported.
10586 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10587 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10588 * font.c (font_close_object): Now static.
10589 * font.h (font_close_object): Remove.
10590 * fontset.c (FONTSET_OBJLIST): Remove.
10591 (free_realized_fontset) #if-0 the body, which does nothing.
10592 (face_suitable_for_char_p): #if-0, as it's never called.
10593 * fontset.h (face_suitable_for_char_p): Remove decl.
10594 * xfaces.c (face_at_string_position):
10595 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10596 since 0 is always ASCII.
10598 * fns.c (weak_hash_tables): Now static.
10600 * fileio.c: Make symbols static if they're not exported.
10601 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10602 (Vwrite_region_annotation_buffers): Now static.
10604 * eval.c: Make symbols static if they're not exported.
10605 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10606 * lisp.h (backtrace_list): Remove decl.
10608 * emacs.c: Make symbols static if they're not exported.
10609 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10610 (fatal_error_code, fatal_error_signal_hook, standard_args):
10612 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10613 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10614 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10615 * lisp.h (fatal_error_signal_hook): Remove decl.
10616 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10618 * editfns.c: Move a (normally-unused) function to its only use.
10619 * editfns.c, lisp.h (get_operating_system_release): Remove.
10620 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10621 worth the hassle of breaking this out.
10623 * xterm.c: Make symbols static if they're not exported.
10624 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10625 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10626 (x_destroy_window, x_delete_display):
10628 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10629 (x_mouse_leave): Remove; unused.
10630 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10631 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10632 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10634 (x_mouse_leave): Declare only if WINDOWSNT.
10635 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10636 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10639 * ftxfont.c: Make symbols static if they're not exported.
10640 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10642 * font.h (ftxfont_driver): Likewise.
10644 * xfns.c: Make symbols static if they're not exported.
10645 (x_last_font_name, x_display_info_for_name):
10646 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10647 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10648 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10649 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10650 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10651 (last_show_tip_args): Now static.
10652 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10653 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10654 (x_screen_planes): Remove; unused.
10655 * dispextern.h (x_screen_planes): Remove decl.
10657 * dispnew.c: Make symbols static if they're not exported.
10658 * dispextern.h (redraw_garbaged_frames, scrolling):
10659 (increment_row_positions): Remove.
10660 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10661 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10663 (redraw_garbaged_frames): Remove; unused.
10665 * xfaces.c: Make symbols static if they're not exported.
10666 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10668 * xterm.h (defined_color): Remove decls.
10669 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10670 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10671 (menu_face_changed_default, defined_color, free_realized_face):
10672 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10673 (ascii_face_of_lisp_face): Remove; unused.
10675 * xdisp.c: Make symbols static if they're not exported.
10676 * dispextern.h (scratch_glyph_row, window_box_edges):
10677 (glyph_to_pixel_coords, set_cursor_from_row):
10678 (get_next_display_element, set_iterator_to_next):
10679 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10680 (show_mouse_face): Remove decls
10681 * frame.h (message_buf_print): Likewise.
10682 * lisp.h (pop_message, set_message, check_point_in_composition):
10684 * xterm.h (set_vertical_scroll_bar): Likewise.
10685 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10686 (message_buf_print, scratch_glyph_row, displayed_buffer):
10687 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10688 (get_next_display_element, show_mouse_face, window_box_edges):
10689 (frame_to_window_pixel_xy, check_point_in_composition):
10690 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10691 (glyph_to_pixel_coords): Remove; unused.
10693 * dired.c (file_name_completion): Now static.
10695 * dbusbind.c (xd_in_read_queued_messages): Now static.
10697 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10698 * data.c (circular_list_error): Remove.
10700 * commands.h (last_point_position, last_point_position_buffer):
10701 (last_point_position_window): Remove decls.
10702 * keyboard.c: Make these variables static.
10704 * coding.h (coding, code_convert_region, encode_coding_gap):
10706 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10707 (iso_code_class, detect_coding, code_convert_region): Now static.
10708 (encode_coding_gap): Remove; unused.
10710 * chartab.c (chartab_chars, chartab_bits): Now static.
10712 * charset.h (charset_iso_8859_1): Remove decl.
10713 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10716 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10717 * ccl.c (Vccl_program_table): Now static.
10718 (check_ccl_update): Remove; unused.
10720 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10721 * category.h: ... from here.
10722 * category.c (check_category_table, set_category_set): Now static.
10724 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10725 * lisp.h: Remove these decls.
10727 * buffer.c (buffer_count): Remove unused var.
10729 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10730 so that it's not optimized away.
10731 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10732 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10733 exported only to the debugger.
10735 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10736 * atimer.h (run_all_atimers): Remove; not exported.
10738 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10739 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10740 was inaccessible from Lisp.
10741 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10742 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10744 alloc.c: Import and export fewer symbols, and remove unused items.
10745 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10747 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10748 it's not optimized away by whole-program optimization.
10749 (message_enable_multibyte, free_misc): Remove.
10750 (catchlist, handlerlist, mark_backtrace):
10751 Declare only if BYTE_MARK_STACK.
10752 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10753 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10754 (message_enable_multibyte): Remove decl.
10755 (free_misc, interval_free_list, float_block, float_block_index):
10756 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10757 (cons_free_list, last_marked_index):
10759 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10760 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10761 (mark_backtrace): Define only if BYTE_MARK_STACK.
10762 * xdisp.c (message_enable_multibyte): Now static.
10764 Declare Lisp_Object Q* variables to be 'static' if not exported.
10765 This makes it easier for human readers (and static analyzers)
10766 to see whether these variables are used from other modules.
10767 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10768 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10769 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10770 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10771 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10772 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10773 * xmenu.c, xselect.c:
10774 Declare Q* vars static if they are not used in other modules.
10775 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10776 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10777 Remove decls of unexported vars.
10778 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10780 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10782 Make Emacs functions such as Fatom 'static' by default.
10783 This makes it easier for human readers (and static analyzers)
10784 to see whether these functions can be called from other modules.
10785 DEFUN now defines a static function. To make the function external
10786 so that it can be used in other C modules, use the new macro DEFUE.
10787 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10788 (Finit_image_library):
10789 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10790 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10791 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10792 Remove decls, since these functions are now static.
10793 (Funintern, Fget_internal_run_time): New decls, since these functions
10794 were already external.
10796 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10797 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10798 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10799 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10800 * keyboard.c, keymap.c, lread.c:
10801 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10802 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10803 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10804 Mark functions with DEFUE instead of DEFUN,
10805 if they are used in other modules.
10806 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10807 decls for now-static functions.
10808 * buffer.h (Fdelete_overlay): Remove decl.
10809 * callproc.c (Fgetenv_internal): Mark as internal.
10810 * composite.c (Fremove_list_of_text_properties): Remove decl.
10811 (Fcomposition_get_gstring): New forward static decl.
10812 * composite.h (Fcomposite_get_gstring): Remove decl.
10813 * dired.c (Ffile_attributes): New forward static decl.
10814 * doc.c (Fdocumntation_property): New forward static decl.
10815 * eval.c (Ffetch_bytecode): New forward static decl.
10816 (Funintern): Remove extern decl; now in .h file where it belongs.
10817 * fileio.c (Fmake_symbolic_link): New forward static decl.
10818 * image.c (Finit_image_library): New forward static decl.
10819 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10820 * intervals.h (Fprevious_property_change):
10821 (Fremove_list_of_text_properties): Remove decls.
10822 * keyboard.c (Fthis_command_keys): Remove decl.
10823 (Fcommand_execute): New forward static decl.
10824 * keymap.c (Flookup_key): New forward static decl.
10825 (Fcopy_keymap): Now static.
10826 * keymap.h (Flookup_key): Remove decl.
10827 * process.c (Fget_process): New forward static decl.
10828 (Fprocess_datagram_address): Mark as internal.
10829 * syntax.c (Fsyntax_table_p): New forward static decl.
10830 (skip_chars): Remove duplicate decl.
10831 * textprop.c (Fprevious_property_change): New forward static decl.
10832 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10834 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10835 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10837 * editfns.c (Fformat): Remove unreachable code.
10839 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10841 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10844 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10846 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10847 when at ZV. (Bug#8487)
10849 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10851 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10853 * keyboard.c (parse_tool_bar_item): Likewise.
10854 * sound.c (sound_cleanup, alsa_close): Likewise.
10855 * termcap.c (tgetent): Likewise.
10856 * xfns.c (x_default_font_parameter): Likewise.
10857 * xsettings.c (read_and_apply_settings): Likewise.
10859 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10860 (overrun_check_free): Protoize.
10862 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10864 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10865 since callers should never pass a negative size.
10866 Change the signature to match that of plain 'read' and 'write'; see
10867 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10868 * lisp.h: Update prototypes of emacs_write and emacs_read.
10870 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10872 * xdisp.c (redisplay_window): Don't try to determine the character
10873 position of the scroll margin if the window start point w->startp
10874 is outside the buffer's accessible region. (Bug#8468)
10876 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10878 Fix write-region and its subroutines for buffers > 2GB.
10879 * fileio.c (a_write, e_write): Modify declaration of arguments and
10880 local variables to support buffers larger than 2GB.
10881 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10883 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10884 argument, local variables, and return value.
10886 * lisp.h: Update prototypes of emacs_write and emacs_read.
10888 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10890 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10892 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10894 Fix more problems found by GCC 4.6.0's static checks.
10896 * xdisp.c (vmessage): Use a better test for character truncation.
10898 * charset.c (load_charset_map): <, not <=, for optimization,
10899 and to avoid potential problems with integer overflow.
10900 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10901 * casetab.c (set_identity, shuffle): Likewise.
10902 * editfns.c (Fformat): Likewise.
10903 * syntax.c (skip_chars): Likewise.
10905 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10906 This also lets GCC 4.6.0 generate slightly better loop code.
10908 * callint.c (Fcall_interactively): <, not <=, for optimization.
10909 (Fcall_interactively): Count the number of arguments produced,
10910 not the number of arguments given. This is simpler and lets GCC
10911 4.6.0 generate slightly better code.
10913 * ftfont.c: Distingish more carefully between FcChar8 and char.
10914 The previous code passed unsigned char * to a functions like
10915 strlen and xstrcasecmp that expect char *, which does not
10916 conform to the C standard.
10917 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10918 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10919 char * when the C standard requires it.
10921 * keyboard.c (read_char): Remove unused var.
10923 * eval.c: Port to Windows vsnprintf (Bug#8435).
10924 Include <limits.h>.
10925 (SIZE_MAX): Define if the headers do not.
10926 (verror): Do not give up if vsnprintf returns a negative count.
10927 Instead, grow the buffer. This ports to Windows vsnprintf, which
10928 does not conform to C99. Problem reported by Eli Zaretskii.
10929 Also, simplify the allocation scheme, by avoiding the need for
10930 calling realloc, and removing the ALLOCATED variable.
10932 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10934 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10935 But keep the doprint source code for now, as we might revamp it
10936 and use it again (Bug#8435).
10937 * lisp.h (doprnt): Remove.
10938 * Makefile.in (base_obj): Remove doprnt.o.
10939 * deps.mk (doprnt.o): Remove.
10941 error: Print 32- and 64-bit integers portably (Bug#8435).
10942 Without this change, on typical 64-bit hosts error ("...%d...", N)
10943 was used to print both 32- and 64-bit integers N, which relied on
10944 undefined behavior.
10945 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10946 * lisp.h (error, verror): Mark as printf-like functions.
10947 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10948 Report overflow in size calculations when allocating printf buffer.
10949 Do not truncate output string at its first null byte.
10950 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10951 Truncate the output at a character boundary, since vsnprintf does not
10953 * charset.c (check_iso_charset_parameter): Convert internal
10954 character to string before calling 'error', since %c now has the
10956 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10957 overflow when computing char to be passed to 'error'. Do not
10958 pass Lisp_Object to 'error'; pass the integer instead.
10959 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10960 formatted with plain %d.
10962 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10964 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10966 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10968 * xterm.c (x_catch_errors): Remove duplicate declaration.
10970 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10972 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10974 2011-04-10 Jim Meyering <meyering@redhat.com>
10976 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10977 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10978 return ssize_t not "int", and use size_t as the buffer length.
10979 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10980 * gnutls.h: Update declarations.
10981 * process.c (read_process_output): Use ssize_t, to match.
10982 (send_process): Likewise.
10984 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10986 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10988 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10990 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10991 Use unsigned char, to match FcChar8 type definition.
10993 * xterm.c (handle_one_xevent):
10994 * xmenu.c (create_and_show_popup_menu):
10995 * xselect.c (x_decline_selection_request)
10996 (x_reply_selection_request): Avoid type-punned deref of X events.
10998 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11000 Fix some uses of `int' instead of EMACS_INT.
11001 * search.c (string_match_1, fast_string_match)
11002 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11003 (scan_buffer, find_next_newline_no_quit)
11004 (find_before_next_newline, search_command, Freplace_match)
11005 (Fmatch_data): Make some `int' variables be EMACS_INT.
11007 * xdisp.c (display_count_lines): 3rd argument and return value now
11008 EMACS_INT. All callers changed.
11009 (pint2hrstr): Last argument is now EMACS_INT.
11011 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11012 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11013 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11014 (decode_coding_utf_16, decode_coding_emacs_mule)
11015 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11016 (decode_coding_ccl, decode_coding_charset)
11017 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11018 (decode_coding_iso_2022, decode_coding_emacs_mule)
11019 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11020 <char_offset, last_offset>: Declare EMACS_INT.
11021 (encode_coding_utf_8, encode_coding_utf_16)
11022 (encode_coding_emacs_mule, encode_invocation_designation)
11023 (encode_designation_at_bol, encode_coding_iso_2022)
11024 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11025 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11027 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11028 (encode_invocation_designation): Last argument P_NCHARS is now
11030 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11031 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11033 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11036 * ccl.c (Fccl_execute_on_string): Declare some variables
11039 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11041 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11043 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11045 * process.c (Fformat_network_address): Doc fix.
11047 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11049 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11051 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11053 * keyboard.c (read_char): Call Lisp function help-form-show,
11054 instead of using internal_with_output_to_temp_buffer.
11055 (Qhelp_form_show): New var.
11056 (syms_of_keyboard): Use DEFSYM macro.
11058 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11060 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11062 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11064 * process.c (Flist_processes): Remove to Lisp.
11065 (list_processes_1): Delete.
11067 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11069 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11071 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11073 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11075 Fix more problems found by GCC 4.6.0's static checks.
11077 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11079 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11081 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11083 * xdisp.c (vmessage): Mark as a printf-like function.
11085 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11087 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11089 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11090 printf-like functions.
11091 (tiff_load): Add casts to remove these marks before passing them
11092 to system-supplied API.
11094 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11096 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11097 This avoids several warnings with gcc -Wstrict-overflow.
11098 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11099 directly, rather than having caller test rule sign. This avoids
11100 some unnecessary tests.
11101 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11102 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11103 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11105 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11106 (xfont_open): Avoid unnecessary tests.
11108 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11110 * composite.h, composite.c (composition_gstring_put_cache):
11111 Use EMACS_INT, not int, for length.
11113 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11114 breaking out part of COMPOSITION_DECODE_RULE.
11115 (COMPOSITION_DECODE_RULE): Use it.
11116 * composite.c (get_composition_id): Remove unused local vars,
11117 by using the new macro.
11119 * textprop.c (set_text_properties_1): Change while to do-while,
11120 since the condition is always true at first.
11122 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11123 (interval_deletion_adjustment): Return unsigned value.
11126 * process.c (list_processes_1, create_pty, read_process_output):
11127 (exec_sentinel): Remove vars that were set but not used.
11128 (create_pty): Remove unnecessary "volatile"s.
11129 (Fnetwork_interface_info): Avoid possibility of int overflow.
11130 (read_process_output): Do adaptive read buffering even if carryover.
11131 (read_process_output): Simplify nbytes computation if buffered.
11133 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11135 * syntax.c (scan_words): Remove var that was set but not used.
11136 (update_syntax_table): Use unsigned instead of int.
11138 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11139 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11140 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11142 * print.c (print_error_message): Avoid int overflow.
11144 * font.c (font_list_entities): Redo for clarity,
11145 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11147 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11148 (font_score): Avoid potential overflow in diff calculation.
11150 * fns.c (substring_both): Remove var that is set but not used.
11151 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11153 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11155 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11156 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11157 can always succeed if overflow has undefined behavior.
11159 * search.c (boyer_moore, wordify): Remove vars set but not used.
11160 (wordify): Omit three unnecessary tests.
11162 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11163 All callers changed. This avoids the need for an unused var.
11165 * casefiddle.c (casify_region): Remove var that is set but not used.
11167 * dired.c (file_name_completion): Remove var that is set but not used.
11169 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11171 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11172 (Finsert_file_contents): Remove unnecessary code checking fd.
11174 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11175 Check for integer overflow on size calculations.
11177 * buffer.c (Fprevious_overlay_change): Remove var that is set
11180 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11181 Remove vars that are set but not used.
11182 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11183 (timer_check_2): Mark vars as initialized.
11185 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11187 * image.c (lookup_image): Remove var that is set but not used.
11188 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11190 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11191 that are set but not used.
11193 * xfns.c (make_invisible_cursor): Don't return garbage
11194 if XCreateBitmapFromData fails (Bug#8410).
11196 * xselect.c (x_get_local_selection, x_handle_property_notify):
11197 Remove vars that are set but not used.
11199 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11200 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11202 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11203 Remove var that is set but not used.
11204 (scroll_bar_windows_size): Now size_t, not int.
11205 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11206 Check for overflow.
11208 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11209 (map_tty_color) [!defined MSDOS]: Likewise.
11211 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11213 * coding.c: Remove vars that are set but not used.
11214 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11215 All callers changed.
11216 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11217 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11218 (decode_coding_charset): Remove vars that are set but not used.
11220 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11221 that is set but not used.
11223 * print.c (print_object): Remove var that is set but not used.
11225 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11226 The gnulib version avoids calling malloc in the usual case,
11227 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11228 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11229 * filelock.c (current_lock_owner): Likewise.
11230 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11231 * sysdep.c: Include allocator.h, careadlinkat.h.
11232 (emacs_no_realloc_allocator): New static constant.
11233 (emacs_readlink): New function.
11234 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11235 ../lib/careadlinkat.h.
11237 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11239 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11240 first non-nil return value).
11242 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11244 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11245 if not defined (Bug#8403).
11247 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11249 * xdisp.c (display_count_lines): Remove parameter `start',
11250 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11251 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11252 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11253 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11254 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11255 and thereabouts. All callers changed.
11256 (get_per_char_metric): Remove parameter `f', unused since
11257 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11259 2011-04-02 Jim Meyering <meyering@redhat.com>
11261 do not dereference NULL upon failed strdup
11262 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11263 (ns_get_family): Likewise.
11265 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11267 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11269 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11271 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11274 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11276 Add lexical binding.
11278 * window.c (Ftemp_output_buffer_show): New fun.
11279 (Fsave_window_excursion):
11280 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11282 * lread.c (lisp_file_lexically_bound_p): New function.
11283 (Fload): Bind Qlexical_binding.
11284 (readevalloop): Remove `evalfun' arg.
11285 Bind Qinternal_interpreter_environment.
11286 (Feval_buffer): Bind Qlexical_binding.
11287 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11289 (syms_of_lread): Declare `lexical-binding'.
11291 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11293 * keyboard.c (eval_dyn): New fun.
11294 (menu_item_eval_property): Use it.
11296 * image.c (parse_image_spec): Use Ffunctionp.
11298 * fns.c (concat, mapcar1): Accept byte-code-functions.
11300 * eval.c (Fsetq): Handle lexical vars.
11301 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11302 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11303 (FletX, Flet): Obey lexical binding.
11304 (Fcommandp): Handle closures.
11305 (Feval): New `lexical' arg.
11306 (eval_sub): New function extracted from Feval. Use it almost
11307 everywhere where Feval was used. Look up vars in lexical env.
11309 (Ffunctionp): Move from subr.el.
11310 (Ffuncall): Handle closures.
11311 (apply_lambda): Remove `eval_flags'.
11312 (funcall_lambda): Handle closures and new byte-code-functions.
11313 (Fspecial_variable_p): New function.
11314 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11315 but without exporting it to Lisp.
11317 * doc.c (Fdocumentation, store_function_docstring):
11318 * data.c (Finteractive_form): Handle closures.
11320 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11323 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11325 (exec_byte_code): New function extracted from Fbyte_code to handle new
11326 calling convention for byte-code-functions. Add new byte-codes.
11328 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11330 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11332 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11334 * xdisp.c (redisplay_internal): Fix prototype.
11336 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11338 * xdisp.c (SCROLL_LIMIT): New macro.
11339 (try_scrolling): Use it when setting scroll_limit.
11340 Limit scrolling to 100 screen lines.
11341 (redisplay_window): Even when falling back on "recentering",
11342 position point in the window according to scroll-conservatively,
11343 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11345 (try_scrolling): When point is above the window, allow searching
11346 as far as scroll_max, or one screenful, to compute vertical
11347 distance from PT to the scroll margin position. This prevents
11348 try_scrolling from unnecessarily failing when
11349 scroll-conservatively is set to a value slightly larger than the
11350 window height. Clean up the case of PT below the margin at bottom
11351 of window: scroll_max can no longer be INT_MAX. When aggressive
11352 scrolling is in use, don't let point enter the opposite scroll
11353 margin as result of the scroll.
11354 (syms_of_xdisp) <scroll-conservatively>: Document the
11355 threshold of 100 lines for never-recentering scrolling.
11357 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11359 * dispextern.h (move_it_by_lines):
11360 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11361 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11362 (message_log_check_duplicate): Remove parameters `prev_bol' and
11363 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11364 (redisplay_internal): Remove parameter `preserve_echo_area',
11365 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11367 * indent.c (Fvertical_motion):
11368 * window.c (window_scroll_pixel_based, Frecenter):
11369 Don't pass `need_y_p' to `move_it_by_lines'.
11371 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11373 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11374 steal a few bits to be more compact.
11375 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11376 Remove unneeded casts.
11378 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11380 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11382 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11383 binding" message (bug#7967).
11385 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11387 Fix more problems found by GCC 4.6.0's static checks.
11389 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11390 Remove unused local var.
11392 * editfns.c (Fmessage_box): Remove unused local var.
11394 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11395 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11396 Omit unused local vars.
11397 * window.c (shrink_windows): Omit unused local var.
11398 * menu.c (digest_single_submenu): Omit unused local var.
11399 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11400 Omit unused local var.
11402 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11403 Don't assume string length fits in int.
11404 (keyremap_step, read_key_sequence): Use size_t for sizes.
11405 (read_key_sequence): Don't check last_real_key_start redundantly.
11407 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11408 instead of alloca (Bug#8344).
11410 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11411 (Fbacktrace_frame): Don't assume nframes fits in int.
11413 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11415 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11418 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11420 * cm.c (calccost): Turn while-do into do-while, for clarity.
11422 * keyboard.c (syms_of_keyboard): Use the same style as later
11423 in this function when indexing through an array. This also
11424 works around GCC bug 48267.
11426 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11428 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11430 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11431 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11433 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11434 This avoids undefined behavior on integer overflow, and is a bit
11435 more convenient anyway since it is compared to a size_t variable.
11437 Variadic C functions now count arguments with size_t, not int.
11438 This avoids an unnecessary limitation on 64-bit machines, which
11439 caused (substring ...) to crash on large vectors (Bug#8344).
11440 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11441 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11442 All variadic functions and their callers changed accordingly.
11443 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11444 * data.c (arith_driver, float_arith_driver): Likewise.
11445 * editfns.c (general_insert_function): Likewise.
11446 * eval.c (struct backtrace.nargs, interactive_p)
11447 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11448 (funcall_lambda, mark_backtrace): Likewise.
11449 * fns.c (concat): Likewise.
11450 * frame.c (x_set_frame_parameters): Likewise.
11451 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11452 0 if not found, not -1. All callers changed.
11454 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11455 (stack_copy_size): Now size_t, not int.
11456 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11458 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11460 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11461 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11462 All callers changed.
11464 * lisp.h (multibyte_char_to_unibyte):
11465 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11466 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11467 * character.h (CHAR_TO_BYTE8):
11468 * cmds.c (internal_self_insert):
11469 * editfns.c (general_insert_function):
11470 * keymap.c (push_key_description):
11471 * search.c (Freplace_match):
11472 * xdisp.c (message_dolog, set_message_1): All callers changed.
11474 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11476 * keyboard.c (safe_run_hook_funcall): New function.
11477 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11478 don't set the hook to nil, but remove the offending function instead.
11479 (Qcommand_hook_internal): Remove, unused.
11480 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11481 Vcommand_hook_internal.
11483 * eval.c (enum run_hooks_condition): Remove.
11484 (funcall_nil, funcall_not): New functions.
11485 (run_hook_with_args): Call each function through a `funcall' argument.
11486 Remove `cond' argument, now redundant.
11487 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11488 (Frun_hook_with_args_until_failure): Adjust accordingly.
11489 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11491 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11493 * dispextern.h (string_buffer_position): Remove declaration.
11495 * print.c (strout): Remove parameter `multibyte', unused since
11496 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11498 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11499 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11500 All callers changed.
11502 * w32.c (_wsa_errlist): Use braces for struct initializers.
11504 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11505 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11506 All callers changed.
11507 (string_buffer_position): Likewise. Also, make static (it's never
11508 used outside xdisp.c).
11509 (cursor_row_p): Remove parameter `w', unused since
11510 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11511 (decode_mode_spec): Remove parameter `precision', introduced during
11512 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11513 All callers changed.
11515 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11517 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11519 2011-03-27 Anders Lindgren <andlind@gmail.com>
11521 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11522 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11523 (ns_update_auto_hide_menu_bar): New functions.
11524 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11525 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11526 ns_constrain_all_frames.
11527 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11528 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11530 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11532 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11534 2011-03-27 Glenn Morris <rgm@gnu.org>
11536 * syssignal.h: Replace RETSIGTYPE with void.
11537 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11538 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11539 Replace SIGTYPE with void everywhere.
11540 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11541 * s/template.h (SIGTYPE): Remove commented out definition.
11543 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11545 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11546 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11548 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11550 * w32.c (read_unc_volume): Use parameter `henum', instead of
11551 global variable `wget_enum_handle'.
11553 * keymap.c (describe_vector): Remove parameters `indices' and
11554 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11555 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11557 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11559 * keyboard.c (timer_check): Remove parameter `do_it_now',
11560 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11561 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11562 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11564 * keyboard.c (read_char):
11565 * w32menu.c (w32_menu_display_help):
11566 * xmenu.c (show_help_event, menu_help_callback):
11567 Adjust calls to `show_help_echo'.
11569 * gtkutil.c (xg_maybe_add_timer):
11570 * keyboard.c (readable_events):
11571 * process.c (wait_reading_process_output):
11572 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11574 * insdel.c (adjust_markers_gap_motion):
11575 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11576 (gap_left, gap_right): Don't call it.
11578 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11580 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11581 incurred during fontification.
11583 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11585 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11586 (DEFVAR_PER_BUFFER): Don't pass it.
11588 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11589 (scrolling_window): Don't pass it.
11591 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11593 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11595 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11597 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11598 of variables specific to SELinux and computation of `encoded_absname'.
11600 * image.c (XPutPixel): Remove unused variable `height'.
11602 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11604 * unexw32.c (get_section_info): Remove unused variable `section'.
11606 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11607 (system_process_attributes): Remove unused variable `sess'.
11608 (sys_read): Remove unused variable `err'.
11610 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11611 (w32_wnd_proc): Remove unused variable `isdead'.
11612 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11613 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11614 (x_create_tip_frame): Remove unused variable `tem'.
11616 * w32inevt.c (w32_console_read_socket):
11617 Remove unused variable `no_events'.
11619 * w32term.c (x_draw_composite_glyph_string_foreground):
11620 Remove unused variable `width'.
11622 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11624 * w32term.c (x_set_glyph_string_clipping):
11625 Don't pass uninitialized region to CombineRgn.
11627 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11629 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11630 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11631 (Fx_close_connection): Remove unused variable `i'.
11633 * w32font.c (w32font_draw): Return number of glyphs.
11634 (w32font_open_internal): Remove unused variable `i'.
11635 (w32font_driver): Add missing initializer.
11637 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11638 (fill_in_menu): Remove unused variable `items_added'.
11640 * w32term.c (last_mouse_press_frame): Remove static global variable.
11641 (w32_clip_to_row): Remove unused variable `f'.
11642 (x_delete_terminal): Remove unused variable `i'.
11644 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11645 (NOTHING): Remove unused static global variable.
11646 (uniscribe_check_otf): Remove unused variable `table'.
11647 (uniscribe_font_driver): Add missing initializers.
11649 2011-03-23 Julien Danjou <julien@danjou.info>
11651 * term.c (Fsuspend_tty, Fresume_tty):
11652 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11653 * window.c (temp_output_buffer_show):
11654 * insdel.c (signal_before_change):
11655 * frame.c (Fhandle_switch_frame):
11656 * fileio.c (Fdo_auto_save):
11657 * emacs.c (Fkill_emacs):
11658 * editfns.c (save_excursion_restore):
11659 * cmds.c (internal_self_insert):
11660 * callint.c (Fcall_interactively):
11661 * buffer.c (Fkill_all_local_variables):
11662 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11664 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11665 unconditionally since it does the check itself.
11667 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11669 Fix more problems found by GCC 4.5.2's static checks.
11671 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11672 the first time through the loop, since we know p0 < p1 then.
11673 This also avoids a gcc -Wstrict-overflow warning.
11675 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11676 leading to a memory leak, possible in functions like
11677 load_charset_map_from_file that can allocate an unbounded number
11678 of objects (Bug#8318).
11680 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11681 that could (at least in theory) be that large.
11683 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11684 This is less likely to overflow, and avoids undefined behavior if
11685 overflow does occur. All callers changed. Use strtoul to scan
11686 for the unsigned long integer.
11687 (pint2hrstr): Simplify and tune code slightly.
11688 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11690 * scroll.c (do_scrolling): Work around GCC bug 48228.
11691 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11693 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11694 This also avoids a warning with gcc -Wstrict-overflow.
11695 (validate_x_resource_name): Simplify count usage.
11696 This also avoids a warning with gcc -Wstrict-overflow.
11698 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11701 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11703 * process.c (Fmake_network_process): Use socklen_t, not int,
11704 where POSIX says socklen_t is required in portable programs.
11705 This fixes a porting bug on hosts like 64-bit HP-UX, where
11706 socklen_t is wider than int (Bug#8277).
11707 (Fmake_network_process, server_accept_connection):
11708 (wait_reading_process_output, read_process_output):
11711 * process.c: Rename or move locals to avoid shadowing.
11712 (list_processes_1, Fmake_network_process):
11713 (read_process_output_error_handler, exec_sentinel_error_handler):
11714 Rename or move locals.
11715 (Fmake_network_process): Define label "retry_connect" only if needed.
11716 (Fnetwork_interface_info): Fix pointer signedness.
11717 (process_send_signal): Add cast to avoid pointer signedness problem.
11718 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11719 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11721 Make tparam.h and terminfo.c consistent.
11722 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11723 Include tparam.h instead, since it declares them.
11724 * cm.h (PC): Remove extern decl; tparam.h now does this.
11725 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11726 * terminfo.c: Include tparam.h, to check interfaces.
11727 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11728 (tparam): Adjust signature to match interface in tparam.h;
11729 this removes some undefined behavior. Check that outstring and len
11730 are zero, which they always are with Emacs.
11731 * tparam.h (PC, BC, UP): New extern decls.
11733 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11734 (xftfont_open): Rename locals to avoid shadowing.
11736 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11737 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11738 (OTF_TAG_SYM): Omit macro if not needed.
11739 (ftfont_list): Remove unused local.
11740 (get_adstyle_property, ftfont_pattern_entity):
11741 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11742 Rename locals to avoid shadowing.
11744 * xfont.c (xfont_list_family): Mark var as initialized.
11746 * xml.c (make_dom): Now static.
11748 * composite.c (composition_compute_stop_pos): Rename local to
11750 (composition_reseat_it): Remove unused locals.
11751 (find_automatic_composition, composition_adjust_point): Likewise.
11752 (composition_update_it): Mark var as initialized.
11753 (find_automatic_composition): Mark vars as initialized,
11754 with a FIXME (Bug#8290).
11756 character.h: Rename locals to avoid shadowing.
11757 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11758 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11759 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11760 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11761 to avoid shadowing.
11763 * textprop.c (property_change_between_p): Remove; unused.
11765 * intervals.c (interval_start_pos): Now static.
11767 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11769 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11770 Rename locals to avoid shadowing.
11772 * sound.c (wav_play, au_play, Fplay_sound_internal):
11773 Fix pointer signedness.
11774 (alsa_choose_format): Remove unused local var.
11775 (wav_play): Initialize a variable to 0, to prevent undefined
11776 behavior (Bug#8278).
11778 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11780 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11782 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11783 clobbering (Bug#8298).
11784 * sysdep.c (sys_subshell): Likewise.
11785 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11787 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11788 This should get cleaned up, so that child_setup has the
11789 same signature on all platforms.
11791 * callproc.c (call_process_cleanup): Now static.
11792 (relocate_fd): Rename locals to avoid shadowing.
11794 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11796 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11797 not to be necessary, and produces flickering.
11799 2011-03-20 Glenn Morris <rgm@gnu.org>
11801 * config.in: Remove file.
11803 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11805 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11806 are now in src/globals.h.
11807 (syms_of_minibuf): Remove spurious & from previous change.
11809 2011-03-20 Leo Liu <sdl.web@gmail.com>
11811 * minibuf.c (completing-read-function): New variable.
11812 (completing-read-default): Rename from completing-read.
11813 (completing-read): Call completing-read-function.
11815 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11817 * xfaces.c (Fx_load_color_file):
11818 Read color file from absolute filename (bug#8250).
11820 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11822 * makefile.w32-in: Update dependencies.
11824 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11826 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11828 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11830 Fix more problems found by GCC 4.5.2's static checks.
11832 * process.c (make_serial_process_unwind, send_process_trap):
11833 (sigchld_handler): Now static.
11835 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11836 That way, the code declares only the vars that it needs.
11837 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11838 * s/cygwin.h (PTY_ITERATION): Likewise.
11839 * s/darwin.h (PTY_ITERATION): Likewise.
11840 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11842 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11843 * process.c (allocate_pty): Don't declare stb unless it's needed.
11845 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11846 (CONSTANTLIM): Remove; unused.
11847 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11848 Define only if needed.
11850 * unexelf.c (unexec): Name an expression,
11851 to avoid gcc -Wbad-function-cast warning.
11852 Use a different way to cause a compilation error if anyone uses
11853 n rather than nn, a way that does not involve shadowing.
11854 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11856 * deps.mk (unexalpha.o): Remove; unused.
11858 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11859 * unexec.h: New file.
11860 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11861 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11862 Depend on unexec.h.
11863 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11864 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11865 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11866 Change as necessary to match prototype in unexec.h.
11868 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11870 (back_comment, skip_chars): Mark vars as initialized.
11872 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11873 Rename locals to avoid shadowing.
11875 * lread.c (read1): Rewrite so as not to use empty "else".
11876 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11878 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11880 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11881 warning when compiling print.c.
11883 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11884 instead of using an uninitialized var.
11885 (font_sort_entities): Mark var as initialized.
11887 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11889 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11890 pointers to constants.
11891 (font_parse_fcname): Remove unused vars.
11892 (font_delete_unmatched): Now static.
11893 (font_get_spec): Remove; unused.
11894 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11895 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11896 Rename or move locals to avoid shadowing.
11898 * fns.c (require_nesting_list, require_unwind): Now static.
11899 (Ffillarray): Rename locals to avoid shadowing.
11901 * floatfns.c (domain_error2): Define only if needed.
11902 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11904 * alloc.c (mark_backtrace): Move decl from here ...
11905 * lisp.h: ... to here, so that it can be checked.
11907 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11908 (Fdefvar): Rewrite so as not to use empty "else".
11909 (lisp_indirect_variable): Name an expression,
11910 to avoid gcc -Wbad-function-cast warning.
11911 (Fdefvar): Rename locals to avoid shadowing.
11913 * callint.c (quotify_arg, quotify_args): Now static.
11914 (Fcall_interactively): Rename locals to avoid shadowing.
11915 Use const pointer when appropriate.
11917 * lisp.h (get_system_name, get_operating_system_release):
11918 Move decls here, to check interfaces.
11919 * process.c (get_operating_system_release): Move decl to lisp.h.
11920 * xrdb.c (get_system_name): Likewise.
11921 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11922 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11923 some of which prompt warnings from gcc -Wbad-function-cast.
11924 (Fformat_time_string, Fencode_time, Finsert_char):
11925 (Ftranslate_region_internal, Fformat):
11926 Rename or remove local vars to avoid shadowing.
11927 (Ftranslate_region_internal): Mark var as initialized.
11929 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11932 * lisp.h (eassert): Check that the argument compiles, even if
11933 ENABLE_CHECKING is not defined.
11935 * data.c (Findirect_variable): Name an expression, to avoid
11936 gcc -Wbad-function-cast warning.
11937 (default_value, arithcompare, arith_driver, arith_error): Now static.
11938 (store_symval_forwarding): Rename local to avoid shadowing.
11939 (Fmake_variable_buffer_local, Fmake_local_variable):
11940 Mark variables as initialized.
11941 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11943 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11944 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11945 Rename locals to avoid shadowing.
11946 (mark_stack): Move local variables into the #ifdef region where
11948 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11949 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11951 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11952 (GC_STRING_CHARS): Remove; not used.
11953 (Fmemory_limit): Cast sbrk's returned value to char *.
11955 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11956 avoids undefined behavior in theory.
11958 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11960 Use functions, not macros, for up- and down-casing (Bug#8254).
11961 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11962 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11963 to use the following functions instead of these macros.
11964 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11965 EMACS_INT, since callers assume the returned value fits in int.
11966 (upcase1): Likewise, for UPCASE_TABLE.
11967 (uppercasep, lowercasep, upcase): New static inline functions.
11968 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11969 the race-condition problem in the old DOWNCASE.
11971 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11972 Rename locals to avoid shadowing.
11973 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11974 (regex_compile, re_search_2, re_match_2_internal):
11975 Remove unused local vars.
11976 (FREE_VAR): Rewrite so as not to use empty "else",
11977 which gcc can warn about.
11978 (regex_compile, re_match_2_internal): Mark locals as initialized.
11979 (RETALLOC_IF): Define only if needed.
11980 (WORDCHAR_P): Likewise. This one is never needed, but is used
11981 only in a comment talking about a compiler bug, so put inside
11982 the #if 0 of that comment.
11983 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11984 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11987 * search.c (boyer_moore): Rename locals to avoid shadowing.
11988 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11989 (PREV_CHAR_BOUNDARY): Likewise.
11991 * search.c (simple_search): Remove unused var.
11993 * dired.c (compile_pattern): Move decl from here ...
11994 * lisp.h: ... to here, so that it can be checked.
11995 (struct re_registers): New forward decl.
11997 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11999 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12001 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12002 Rename locals to avoid shadowing.
12003 (Fvertical_motion): Mark locals as initialized.
12005 * casefiddle.c (casify_object, casify_region): Now static.
12006 (casify_region): Mark local as initialized.
12008 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12010 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12011 New macros, so that the caller can use some names other than
12012 gcpro1, gcpro2, etc.
12013 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12015 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12016 argument, for consistency with GCPRO2_VAR, etc: it is now the
12017 prefix of the variable, not the variable itself. All uses
12019 * dired.c (directory_files_internal, file_name_completion):
12020 Rename locals to avoid shadowing.
12022 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12023 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12024 dired.c's scmp function, had undefined behavior.
12025 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12026 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12027 * buffer.h: ... to here, because these macros use current_buffer,
12028 and the new implementation with inline functions needs to have
12029 current_buffer in scope now, rather than later when the macros
12031 (downcase, upcase1): New static inline functions.
12032 (DOWNCASE, UPCASE1): Reimplement using these functions.
12033 This avoids undefined behavior in expressions like
12034 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12035 from race conditions in accessing the global variables
12036 case_temp1 and case_temp2.
12037 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12038 * lisp.h (case_temp1, case_temp2): Remove their decls.
12039 * character.h (ASCII_CHAR_P): Move from here ...
12040 * lisp.h: ... to here, so that the inline functions mentioned
12041 above can use them.
12043 * dired.c (directory_files_internal_unwind): Now static.
12045 * fileio.c (file_name_as_directory, directory_file_name):
12046 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12048 (file_name_as_directory): Use const pointers when appropriate.
12049 (Fexpand_file_name): Likewise. In particular, newdir might
12050 point at constant storage, so make it a const pointer.
12051 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12052 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12054 (Fset_file_times, Finsert_file_contents, auto_save_error):
12055 Rename locals to avoid shadowing.
12057 * minibuf.c (choose_minibuf_frame_1): Now static.
12058 (Ftry_completion, Fall_completions): Rename or remove locals
12059 to avoid shadowing.
12061 * marker.c (bytepos_to_charpos): Remove; unused.
12063 * lisp.h (verify_bytepos, count_markers): New decls,
12064 so that gcc does not warn that these functions aren't declared.
12066 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12067 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12068 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12069 (copy_text): Remove unused local var.
12071 * filelock.c (within_one_second): Now static.
12072 (lock_file_1): Rename local to avoid shadowing.
12074 * buffer.c (fix_overlays_before): Mark locals as initialized.
12075 (fix_start_end_in_overlays): Likewise. This function should be
12076 simplified by using pointers-to-pointers, but that's a different
12078 (switch_to_buffer_1): Now static.
12079 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12080 (report_overlay_modification): Rename locals to avoid shadowing.
12082 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12083 Fix pointer signedness issue.
12084 (sys_subshell): Mark local as volatile if checking for lint,
12085 to suppress a gcc -Wclobbered warning that does not seem to be right.
12086 (MAXPATHLEN): Define only if needed.
12088 * process.c (serial_open, serial_configure): Move decls from here ...
12089 * systty.h: ... to here, so that they can be checked.
12091 * fns.c (get_random, seed_random): Move extern decls from here ...
12092 * lisp.h: ... to here, so that they can be checked.
12094 * sysdep.c (reset_io): Now static.
12095 (wait_for_termination_signal): Remove; unused.
12097 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12098 (copy_keymap_item, append_key, push_text_char_description):
12100 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12101 (DENSE_TABLE_SIZE): Remove; unused.
12102 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12103 (describe_map_tree):
12104 Rename locals to avoid shadowing.
12106 * keyboard.c: Declare functions static if they are not used elsewhere.
12107 (echo_char, echo_dash, cmd_error, top_level_2):
12108 (poll_for_input, handle_async_input): Now static.
12109 (read_char, kbd_buffer_get_event, make_lispy_position):
12110 (make_lispy_event, make_lispy_movement, apply_modifiers):
12111 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12112 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12113 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12114 (read_key_sequence, read_char): Mark locals as initialized.
12115 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12117 * keyboard.h (make_ctrl_char): New decl.
12118 (mark_kboards): Move decl here ...
12119 * alloc.c (mark_kboards): ... from here.
12121 * lisp.h (force_auto_save_soon): New decl.
12123 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12124 (DEFINE_DUMMY_FUNCTION): New macro.
12125 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12127 (main): Add casts to avoid warnings
12128 if GCC considers string literals to be constants.
12130 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12132 * dbusbind.c: Pointer signedness fixes.
12133 (xd_signature, xd_append_arg, xd_initialize):
12134 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12135 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12136 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12137 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12139 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12140 if GCC considers string literals to be constants.
12141 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12143 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12145 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12146 (print_preprocess, print_object): New macro to fix last change.
12148 * print.c (print_preprocess): Don't forget font objects.
12150 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12152 * emacs.c (USAGE3): Doc fixes.
12154 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12156 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12159 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12161 * lisp.h (VWindow_system, Qfile_name_history):
12162 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12163 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12164 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12166 * w32select.c: Don't #include "keyboard.h".
12167 (run_protected): Add extern declaration for waiting_for_input.
12169 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12170 * w32console.c (detect_input_pending, read_input_pending)
12171 (encode_terminal_code):
12172 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12173 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12174 (w32_system_caret_y, Qfile_name_history):
12175 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12176 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12177 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12178 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12179 * w32proc.c (Qlocal, report_file_error):
12180 * w32term.c (Vwindow_system, updating_frame):
12181 * w32uniscribe.c (initialized, uniscribe_font_driver):
12182 Remove unneeded extern declarations.
12184 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12186 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12188 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12190 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12191 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12192 These macros can no longer be used for assignment.
12194 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12195 Assign struct members directly, instead of using BUF_BEGV etc.
12196 (record_buffer_markers, fetch_buffer_markers): New functions for
12197 recording and fetching special buffer markers.
12198 (set_buffer_internal_1, set_buffer_temp): Use them.
12200 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12202 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12204 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12205 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12207 * xdisp.c (hscroll_window_tree):
12208 (reconsider_clip_changes): Use PT instead of BUF_PT.
12210 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12212 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12213 $(EMACS_ROOT)/lib/intprops.h.
12215 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12217 Fix more problems found by GCC 4.5.2's static checks.
12219 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12220 to unsigned char * to avoid compiler diagnostic.
12221 (xg_free_frame_widgets): Make it clear that a local variable is
12222 needed only if USE_GTK_TOOLTIP.
12223 (gdk_window_get_screen): Make it clear that this macro is needed
12224 only if USE_GTK_TOOLTIP.
12225 (int_gtk_range_get_value): New function, which avoids a diagnostic
12226 from gcc -Wbad-function-cast.
12227 (xg_set_toolkit_scroll_bar_thumb): Use it.
12228 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12229 diagnostic from gcc -Wbad-function-cast.
12230 (get_utf8_string, xg_get_file_with_chooser):
12231 Rename locals to avoid shadowing.
12232 (create_dialog): Move locals to avoid shadowing.
12234 * xgselect.c (xg_select): Remove unused var.
12236 * image.c (four_corners_best): Mark locals as initialized.
12237 (gif_load): Initialize transparent_p to zero (Bug#8238).
12238 Mark another local as initialized.
12239 (my_png_error, my_error_exit): Mark with NO_RETURN.
12241 * image.c (clear_image_cache): Now static.
12242 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12243 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12244 (x_edge_detection): Remove unnecessary cast that
12245 gcc -Wbad-function-cast diagnoses.
12246 (gif_load): Fix pointer signedness.
12247 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12248 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12250 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12252 Improve quality of tests for time stamp overflow.
12253 For example, without this patch (encode-time 0 0 0 1 1
12254 1152921504606846976) returns the obviously-bogus value (-948597
12255 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12256 reports time overflow. See
12257 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12258 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12259 * editfns.c: Include limits.h and intprops.h.
12260 (TIME_T_MIN, TIME_T_MAX): New macros.
12261 (time_overflow): Move earlier, to before first use.
12262 (hi_time, lo_time): New functions, for an accurate test for
12263 out-of-range times.
12264 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12265 (Fget_internal_run_time): Don't assume time_t fits in int.
12266 (make_time): Use list2 instead of Fcons twice.
12267 (Fdecode_time): More accurate test for out-of-range times.
12268 (check_tm_member): New function.
12269 (Fencode_time): Use it, to test for out-of-range times.
12270 (lisp_time_argument): Don't rely on undefined left-shift and
12271 right-shift behavior when checking for time stamp overflow.
12273 * editfns.c (time_overflow): New function, refactoring common code.
12274 (Fformat_time_string, Fdecode_time, Fencode_time):
12275 (Fcurrent_time_string): Use it.
12277 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12278 * dired.c (make_time): Move to ...
12279 * editfns.c (make_time): ... here.
12280 * systime.h: Note the move.
12282 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12284 * fringe.c (update_window_fringes): Remove unused variables.
12286 * unexmacosx.c (copy_data_segment): Also copy __got section.
12289 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12291 * termcap.c [MSDOS]: Include "msdos.h".
12292 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12293 Constify `char *' arguments and their references according to
12294 prototypes in tparam.h.
12296 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12298 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12299 Adapt all references accordingly.
12301 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12303 2011-03-11 Tom Tromey <tromey@redhat.com>
12305 * buffer.c (syms_of_buffer): Remove obsolete comment.
12307 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12309 * termhooks.h (encode_terminal_code): Declare prototype.
12311 * msdos.c (encode_terminal_code): Don't declare prototype.
12313 * term.c (encode_terminal_code): Now external again, used by
12314 w32console.c and msdos.c.
12316 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12317 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12319 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12321 Fix some minor problems found by GCC 4.5.2's static checks.
12323 * fringe.c (update_window_fringes): Mark locals as initialized
12325 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12327 * alloc.c (mark_fringe_data): Move decl from here ...
12328 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12329 to check its interface.
12330 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12332 * fontset.c (free_realized_fontset): Now static.
12333 (Fset_fontset_font): Rename local to avoid shadowing.
12334 (fontset_font): Mark local as initialized.
12335 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12337 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12339 * xselect.c (x_disown_buffer_selections): Remove; not used.
12340 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12341 (x_own_selection, Fx_disown_selection_internal): Rename locals
12342 to avoid shadowing.
12343 (x_handle_dnd_message): Remove local to avoid shadowing.
12345 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12346 so that the caller can use some name other than gcpro1.
12347 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12348 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12349 (Fx_backspace_delete_keys_p):
12350 Use them to avoid shadowing, and rename vars to avoid shadowing.
12351 (x_decode_color, x_set_name, x_window): Now static.
12352 (Fx_create_frame): Add braces to silence GCC warning.
12353 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12354 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12355 Remove unused locals.
12356 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12357 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12358 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12361 * xterm.h (x_mouse_leave): New decl.
12363 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12364 Remove unused functions.
12365 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12366 (x_calc_absolute_position): Now static.
12367 (XTread_socket): Don't define label "out" unless it's used.
12368 Don't declare local "event" unless it's used.
12369 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12370 unless they are used.
12371 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12372 (x_fatal_error_signal): Remove; not used.
12373 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12374 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12375 (x_error_catcher, x_connection_closed, x_error_handler):
12376 (x_error_quitter, xembed_send_message, x_iconify_frame):
12377 (my_log_handler): Rename locals to avoid shadowing.
12378 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12379 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12381 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12382 Rename or move locals to avoid shadowing.
12383 (tty_defined_color, merge_face_heights): Now static.
12384 (free_realized_faces_for_fontset): Remove; not used.
12385 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12386 does not deduce is never used uninitialized.
12387 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12388 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12390 * terminal.c (store_terminal_param): Now static.
12392 * xmenu.c (menu_highlight_callback): Now static.
12393 (set_frame_menubar): Remove unused local.
12394 (xmenu_show): Rename parameter to avoid shadowing.
12395 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12396 since they might point to immutable storage.
12397 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12398 since it's unused otherwise.
12400 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12401 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12402 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12403 avoids a gcc -Wuninitialized diagnostic.
12404 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12405 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12406 does not deduce are never used uninitialized.
12408 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12410 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12411 * window.c (window_loop, size_window):
12412 (run_window_configuration_change_hook, enlarge_window): Likewise.
12414 * window.c (display_buffer): Now static.
12415 (size_window): Mark variables that gcc -Wuninitialized
12416 does not deduce are never used uninitialized.
12417 * window.h (check_all_windows): New decl, to forestall
12418 gcc -Wmissing-prototypes diagnostic.
12419 * dispextern.h (bidi_dump_cached_states): Likewise.
12421 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12423 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12424 Include <limits.h>.
12425 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12426 and to avoid gcc -Wuninitialized warning.
12427 (load_charset_map): Mark variables that gcc -Wuninitialized
12428 does not deduce are never used uninitialized.
12429 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12431 * coding.c (coding_set_source, coding_set_destination):
12432 Use "else { /* comment */ }" rather than "else /* comment */;"
12433 for clarity, and to avoid gcc -Wempty-body warning.
12434 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12435 a block, when the outer 'i' will do.
12436 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12437 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12438 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12439 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12440 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12441 Rename locals to avoid shadowing.
12442 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12443 * coding.c (emacs_mule_char, encode_invocation_designation):
12444 Now static, since they're not used elsewhere.
12445 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12446 (decode_coding_object, encode_coding_object, detect_coding_system):
12447 (decode_coding_emacs_mule): Mark variables that gcc
12448 -Wuninitialized does not deduce are never used uninitialized.
12449 (detect_coding_iso_2022): Initialize a local variable that might
12450 be used uninitialized. Leave a FIXME because it's not clear that
12451 this initialization is needed. (Bug#8211)
12452 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12453 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12454 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12455 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12456 Remove unused macros.
12458 * category.c (hash_get_category_set): Remove unused local var.
12459 (copy_category_table): Now static, since it's not used elsewhere.
12460 * character.c (string_count_byte8): Likewise.
12462 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12463 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12465 * chartab.c (copy_sub_char_table): Now static, since it's not used
12467 (sub_char_table_ref_and_range, char_table_ref_and_range):
12468 Rename locals to avoid shadowing.
12469 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12471 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12472 (BIDI_BOB): Remove unused macro.
12474 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12475 deduce are never used uninitialized.
12476 * term.c (encode_terminal_code): Likewise.
12478 * term.c (encode_terminal_code): Now static. Remove unused local.
12480 * tparam.h: New file.
12481 * term.c, tparam.h: Include it.
12482 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12483 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12484 Move these decls to tparam.h, and make them agree with what
12485 is actually in tparam.c. The previous trick of using incompatible
12486 decls in different modules does not conform to the C standard.
12487 All callers of tparam changed to use tparam's actual API.
12488 * tparam.c (tparam1, tparam, tgoto):
12489 Use const pointers where appropriate.
12491 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12492 * cm.h (struct cm): Likewise.
12493 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12494 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12495 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12496 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12497 (turn_on_face, init_tty): Likewise.
12498 * termchar.h (struct tty_display_info): Likewise.
12500 * term.c (term_mouse_position): Rename local to avoid shadowing.
12502 * alloc.c (mark_ttys): Move decl from here ...
12503 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12505 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12507 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12509 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12511 * search.c (compile_pattern_1): Remove argument regp, unused since
12512 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12513 (compile_pattern): Don't pass it.
12515 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12517 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12518 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12520 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12522 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12524 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12525 gdk_window_get_screen, gdk_window_get_geometry,
12526 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12527 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12528 (xg_get_pixbuf_from_pixmap): New function.
12529 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12530 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12531 Call xg_get_pixbuf_from_pixmap instead of
12532 gdk_pixbuf_get_from_drawable.
12533 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12534 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12535 (xg_check_special_colors): Use GtkStyleContext and its functions
12537 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12538 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12539 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12540 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12541 Call gtk_widget_get_preferred_size.
12542 (xg_frame_resized): gdk_window_get_geometry only takes 5
12544 (xg_win_to_widget, xg_event_is_for_menubar):
12545 Call gdk_x11_window_lookup_for_display.
12546 (xg_set_widget_bg): New function.
12547 (delete_cb): New function.
12548 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12549 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12550 (xg_set_background_color): Call xg_set_widget_bg.
12551 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12552 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12553 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12554 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12556 (update_frame_tool_bar): Call gtk_widget_hide.
12557 (xg_initialize): Use GDK_KEY_g.
12559 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12561 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12563 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12564 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12565 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12567 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12569 * w32xfns.c (select_palette): Check success of RealizePalette against
12570 GDI_ERROR, not zero.
12572 See ChangeLog.11 for earlier changes.
12574 ;; Local Variables:
12578 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12580 This file is part of GNU Emacs.
12582 GNU Emacs is free software: you can redistribute it and/or modify
12583 it under the terms of the GNU General Public License as published by
12584 the Free Software Foundation, either version 3 of the License, or
12585 (at your option) any later version.
12587 GNU Emacs is distributed in the hope that it will be useful,
12588 but WITHOUT ANY WARRANTY; without even the implied warranty of
12589 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12590 GNU General Public License for more details.
12592 You should have received a copy of the GNU General Public License
12593 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.