]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-08-05 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer and memory overflow issues.
4
5 * charset.c (charset_table_size)
6 (struct charset_sort_data.priority): Now ptrdiff_t.
7 (charset_compare): Don't overflow if priorities differ greatly.
8 (Fsort_charsets): Don't assume list length fits in int.
9 Check for size-calculation overflow when allocating sort data.
10 (syms_of_charset): Allocate an initial charset table that is
11 just under 64 KiB, to avoid problems with glibc malloc and mmap.
12
13 * cmds.c (internal_self_insert): Check for size-calculation overflow.
14
15 * composite.h (struct composition.glyph_len): Now int, not unsigned.
16 The actual value is always <= INT_MAX, and leaving it unsigned made
17 overflow checking harder.
18
19 * dispextern.h (struct glyph_matrix.rows_allocated)
20 (struct face_cache.size): Now ptrdiff_t, for convenience in use
21 with xpalloc. The values are still always <= INT_MAX.
22
23 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
24
25 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
26 (SAFE_NALLOCA): New macro.
27
28 * region-cache.c (struct boundary.pos, find_cache_boundary)
29 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
30 (set_cache_region, invalidate_region_cache)
31 (revalidate_region_cache, know_region_cache, region_cache_forward)
32 (region_cache_backward, pp_cache):
33 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
34 so that ptrdiff_t * can be passed to xpalloc.
35 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
36 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
37 (pp_cache): Don't assume cache_len fits in int.
38 * region-cache.h: Adjust extern decls to match.
39
40 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
41 EMACS_INT, since either will do, for xpalloc.
42
43 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
44 (xnmalloc, xnrealloc, xpalloc): New functions.
45
46 * bidi.c (bidi_shelve_header_size): New constant.
47 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
48 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
49
50 * buffer.c (overlays_at, overlays_in, record_overlay_string)
51 (overlay_strings):
52 Don't update size of array until after memory allocation succeeds,
53 because xmalloc/xrealloc may not return.
54 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
55 now that we have proper integer overflow checking.
56 (record_overlay_string, overlay_strings): Catch overflows when
57 calculating size of overlay_str_buf.
58
59 * callproc.c (Fcall_process): Check for size overflow when
60 calculating size of args2.
61 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
62 Normally we prefer signed values, but sticking with ptrdiff_t would
63 require adding more-complicated checks.
64
65 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
66 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
67 Redo buffer-overflow calculations to avoid integer overflow.
68 Add a FIXME comment where memory seems to be over-allocated.
69
70 * character.c (Fstring): Check for size-calculation overflow.
71
72 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
73 unnecessary integer overflow. Check for size overflow.
74 (encode_coding_object): Don't update size until xmalloc succeeds.
75
76 * composite.c (get_composition_id): Check for overflow in glyph
77 length calculations.
78
79 Integer and memory overflow fixes for display code.
80 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
81 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
82 (scrolling_window): Check for overflow in size calculations.
83 (line_draw_cost, realloc_glyph_pool, add_row_entry):
84 Don't assume glyph table len fits in int.
85 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
86 (row_table_size): Now ptrdiff_t, not int.
87 (scrolling_window): Avoid overflow in size calculations.
88 Don't update size until allocation succeeds.
89 * fns.c (concat): Check for overflow in size calculations.
90 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
91 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
92 (NEXT_ALMOST_PRIME_LIMIT): New constant.
93
94 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
95 (get_doc_string): Check for size calculation overflow.
96 Don't update size until allocation succeeds.
97 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
98 EMACS_INT, where ptrdiff_t will do.
99 (Fsubstitute_command_keys): Check for string overflow.
100
101 * editfns.c (set_time_zone_rule): Don't assume environment length
102 fits in int.
103 (message_length): Now ptrdiff_t, not int.
104 (Fmessage_box): Don't update size until allocation succeeds.
105 Don't assume message length fits in int.
106 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
107
108 * emacs.c (main): Do not reallocate argv, since there is a null at
109 the end that can be overwritten, and this way there's no need to
110 worry about size-calculation overflow.
111 (sort_args): Check for size-calculation overflow.
112
113 * eval.c (init_eval_once, grow_specpdl): Don't update size until
114 alloc succeeds.
115 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
116
117 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
118 (x_set_scroll_bar_width, x_figure_window_size):
119 Check for integer overflow.
120 (x_set_alpha): Do not assume XINT fits in int.
121
122 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
123 This is for the members text_lines, text_cols, total_lines, total_cols,
124 where the system imposes an 'int' limit.
125
126 * fringe.c (Fdefine_fringe_bitmap):
127 Don't update size until alloc works.
128
129 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
130 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
131
132 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
133 Check for size-calculation overflow.
134 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
135 do, as we prefer signed integers.
136 (id_to_widget.max_size, id_to_widget.used)
137 (xg_store_widget_in_map, xg_remove_widget_from_map)
138 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
139 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
140 Use and return ptrdiff_t, not int.
141 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
142 * gtkutil.h: Change prototypes to match the above.
143
144 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
145 are duplicate now that they've been promoted to lisp.h.
146 (x_allocate_bitmap_record, x_alloc_image_color)
147 (make_image_cache, cache_image, xpm_load):
148 Don't update size until alloc is done.
149 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
150 (x_detect_edges):
151 Check for size calculation overflow.
152 (ct_colors_allocated_max): New constant.
153 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
154 overflow.
155
156 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
157 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
158 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
159 Use ptrdiff_t, not int, to count maps.
160 (read_char_minibuf_menu_prompt): Check for overflow in size
161 calculations. Don't update size until allocation succeeds. Redo
162 calculations to avoid overflow.
163 * keyboard.h: Change prototypes to match the above.
164
165 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
166 to count maps.
167 (current_minor_maps): Check for size calculation overflow.
168 * keymap.h: Change prototypes to match the above.
169
170 * lread.c (read1, init_obarray): Don't update size until alloc done.
171
172 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
173 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
174
175 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
176 Now ptrdiff_t, not int.
177 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
178 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
179
180 * process.c (Fnetwork_interface_list): Check for overflow
181 in size calculation.
182
183 * region-cache.c (move_cache_gap): Check for size calculation overflow.
184
185 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
186 overflow. Don't bother calling xmalloc when xrealloc will do.
187
188 * search.c (Freplace_match): Check for size calculation overflow.
189 (Fset_match_data): Don't assume list lengths fit in 'int'.
190
191 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
192 for command line length. Do not attempt to address one before the
193 beginning of an array, as that's not portable.
194
195 * term.c (max_frame_lines): Remove; unused.
196 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
197 not int.
198 (encode_terminal_code, calculate_costs): Check for size
199 calculation overflow.
200 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
201 table lengths and related sizes. Don't update size until alloc
202 done. Redo calculations to avoid overflow.
203 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
204
205 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
206 subtracting pointers.
207 (gobble_line): Check for overflow more carefully. Don't update size
208 until alloc done.
209
210 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
211 Don't update size until alloc done.
212 Redo size calculations to avoid overflow.
213 Check for size calculation overflow.
214 (main) [DEBUG]: Fix typo in invoking tparam1.
215
216 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
217 Use ptrdiff_t, not int, for sizes.
218 (store_mode_line_noprop_char): Don't update size until alloc done.
219
220 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
221 Use ptrdiff_t, not int, for sizes.
222 (Finternal_make_lisp_face, cache_face):
223 Check for size calculation overflow.
224 (cache_face): Treat size calculation overflows as if they were
225 memory exhaustion (the usual treatment), rather than aborting.
226
227 * xfns.c (x_encode_text, x_set_name_internal)
228 (Fx_change_window_property): Use ptrdiff_t, not int, to count
229 sizes, since they can exceed INT_MAX in size. Check for size
230 calculation overflow.
231
232 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
233 (xg_select): Check for size calculation overflow.
234 Don't update size until alloc done.
235
236 * xrdb.c (get_environ_db): Don't assume path length fits in int,
237 as sprintf is limited to int lengths.
238
239 * xselect.c (X_LONG_SIZE, X_USHRT_MAX, X_ULONG_MAX): New macros.
240 Use them to make the following changes clearer.
241 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
242 This change doesn't affect the value now, but it may help remind
243 future maintainers not to raise the value too much later.
244 (SELECTION_QUANTUM): Remove, replacing with ...
245 (selection_quantum): ... new function, which avoids overflow.
246 All uses changed.
247 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
248 assumption that selection length fits in 'int'.
249 (x_reply_selection_request, x_handle_selection_request)
250 (x_get_window_property, receive_incremental_selection)
251 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
252 (lisp_data_to_selection_data, clean_local_selection_data):
253 Use ptrdiff_t, not int, to record length of selection.
254 (x_reply_selection_request, x_get_window_property)
255 (receive_incremental_selection, x_property_data_to_lisp):
256 Redo calculations to avoid overflow.
257 (x_reply_selection_request): When sending hint, ceiling it at
258 X_ULONG_MAX rather than relying on wraparound overflow to send
259 something.
260 (x_get_window_property, receive_incremental_selection)
261 (lisp_data_to_selection_data, x_property_data_to_lisp):
262 Check for size-calculation overflow.
263 (x_get_window_property, receive_incremental_selection)
264 (lisp_data_to_selection_data, Fx_register_dnd_atom):
265 Don't store size until memory allocation succeeds.
266 (x_get_window_property): Plug memory leak on memory exhaustion.
267 Don't double-block input; malloc is safe here. Don't assume 2**34
268 - 4 fits in unsigned long. Add an xassert to check
269 XGetWindowProperty overflow. Be more careful about overflow
270 calculations, and distinguish size from memory overflow better.
271 (receive_incremental_selection): When tracing, don't assume
272 unsigned int is less than INT_MAX.
273 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
274 harmful) conversions of unsigned short to int.
275 (lisp_data_to_selection_data): Don't assume that integers
276 in the range -65535 through -1 fit in an X unsigned short.
277 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
278 result parameters unless successful. Rely on cons_to_unsigned
279 to report problems with elements; the old code wasn't right anyway.
280 (x_check_property_data): Check for int overflow; we cannot use
281 a wider type due to X limits.
282 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
283
284 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
285
286 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
287 (x_term_init): Check for size calculation overflow.
288 (x_color_cells): Don't store size until memory allocation succeeds.
289 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
290 Don't assume alloca size is less than MAX_ALLOCA.
291 (x_term_init): Don't assume length fits in int (sprintf is limited
292 to int size).
293
294 Use ptrdiff_t for composition IDs.
295 * character.c (lisp_string_width):
296 * composite.c (composition_table_size, n_compositions)
297 (get_composition_id, composition_gstring_from_id):
298 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
299 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
300 * window.c (Frecenter):
301 Use ptrdiff_t, not int, for composition IDs.
302 * composite.c (get_composition_id): Check for integer overflow.
303 * composite.h: Adjust prototypes to match the above changes.
304
305 Use ptrdiff_t for hash table indexes.
306 * category.c (hash_get_category_set):
307 * ccl.c (ccl_driver):
308 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
309 * coding.c (coding_system_charset_list, detect_coding_system):
310 * coding.h (struct coding_system.id):
311 * composite.c (get_composition_id, gstring_lookup_cache):
312 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
313 * image.c (xpm_get_color_table_h):
314 * lisp.h (hash_lookup, hash_put):
315 * minibuf.c (Ftest_completion):
316 Use ptrdiff_t for hash table indexes, not int (which is too
317 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
318 32-bit --with-wide-int hosts).
319
320 * charset.c (Fdefine_charset_internal): Check for integer overflow.
321 Add a FIXME comment about memory leaks.
322 (syms_of_charset): Don't assume xmalloc returns.
323
324 Don't assume that stated character widths fit in int.
325 * character.c (Fchar_width, c_string_width, lisp_string_width):
326 * character.h (CHAR_WIDTH):
327 * indent.c (MULTIBYTE_BYTES_WIDTH):
328 Use sanitize_char_width to avoid undefined and/or bad behavior
329 with outlandish widths.
330 * character.h (sanitize_tab_width): Renamed from sanitize_width,
331 now that we have two such functions. All uses changed.
332 (sanitize_char_width): New inline function.
333
334 Don't assume that tab-width fits in int.
335 * character.h (sanitize_width): New inline function.
336 (SANE_TAB_WIDTH): New macro.
337 (ASCII_CHAR_WIDTH): Use it.
338 * indent.c (sane_tab_width): Remove. All uses replaced by
339 SANE_TAB_WIDTH (current_buffer).
340 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
341
342 * fileio.c: Integer overflow issues with file modes.
343 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
344
345 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
346 Remove unreachable code.
347 (read_hex, load_charset_map_from_file): Check for integer overflow.
348
349 * xterm.c: don't go over XClientMessageEvent limit
350 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
351 (x_send_scroll_bar_event): Likewise. Check that the size does not
352 exceed limits imposed by XClientMessageEvent, as well as the usual
353 ptrdiff_t and size_t limits.
354
355 * keyboard.c: Overflow, signedness and related fixes.
356 (make_lispy_movement): Use same integer type in forward decl
357 that is used in the definition.
358 (read_key_sequence, keyremap_step):
359 Change bufsize argument back to int, undoing my 2011-03-30 change.
360 We prefer signed types, and int is wide enough here.
361 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
362 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
363 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
364 length, not size_t. Use ptrdiff_t for index, not int.
365 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
366 possibility of integer overflow.
367
368 Overflow, signedness and related fixes for images.
369
370 * dispextern.h (struct it.stack[0].u.image.image_id)
371 (struct_it.image_id, struct image.id, struct image_cache.size)
372 (struct image_cache.used, struct image_cache.ref_count):
373 * gtkutil.c (update_frame_tool_bar):
374 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
375 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
376 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
377 * nsmenu.m (update_frame_tool_bar):
378 * xdisp.c (calc_pixel_width_or_height):
379 * xfns.c (image_cache_refcount):
380 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
381 on typical 64-bit hosts.
382
383 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
384 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
385 Omit unnecessary casts to int.
386 (parse_image_spec): Check that integers fall into 'int' range
387 when the callers expect that.
388 (image_ascent): Redo ascent calculation to avoid int overflow.
389 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
390 (lookup_image): Remove unnecessary tests.
391 (xbm_image_p): Locals are now of int, not EMACS_INT,
392 since parse_image_check makes sure they fit into int.
393 (png_load, gif_load, svg_load_image):
394 Prefer int to unsigned where either will do.
395 (tiff_handler): New function, combining the cores of the
396 old tiff_error_handler and tiff_warning_handler. This
397 function is rewritten to use vsnprintf and thereby avoid
398 stack buffer overflows. It uses only the features of vsnprintf
399 that are common to both POSIX and native Microsoft.
400 (tiff_error_handler, tiff_warning_handler): Use it.
401 (tiff_load, gif_load, imagemagick_load_image):
402 Don't assume :index value fits in 'int'.
403 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
404 (imagemagick_load_image): Check that crop parameters fit into
405 the integer types that MagickCropImage accepts. Don't assume
406 Vimagemagick_render_type has a nonnegative value. Don't assume
407 size_t fits in 'long'.
408 (gs_load): Use printmax_t to print the widest integers possible.
409 Check for integer overflow when computing image height and width.
410
411 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
412
413 * Makefile.in (LIB_PTHREAD): New variable.
414 (LIBES): Add LIB_PTHREAD (Bug#9216).
415
416 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
417 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
418
419 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
420
421 * regex.c (re_iswctype): Remove some redundant boolean
422 conversions.
423
424 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
425
426 * xterm.c (x_find_topmost_parent): New function.
427 (x_set_frame_alpha): Find topmost parent window with
428 x_find_topmost_parent and set the property there also (bug#9181).
429 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
430
431 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
432
433 * callproc.c (Fcall_process): Avoid vfork clobbering
434 the local vars buffer, coding_systems, current_dir.
435
436 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
437
438 * keymap.c (Fmake_composed_keymap): Move to subr.el.
439
440 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
441
442 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
443 so that it is not optimized away.
444
445 * xdisp.c (compute_display_string_pos): Remove unused local.
446
447 2011-08-02 Eli Zaretskii <eliz@gnu.org>
448
449 Fix slow cursor motion and scrolling in large buffers with
450 selective display, like Org Mode buffers. (Bug#9218)
451
452 * dispextern.h (struct bidi_it): New member disp_prop_p.
453
454 * xdisp.c: Remove one-slot cache of display string positions.
455 (compute_display_string_pos): Accept an additional argument
456 DISP_PROP_P; callers changed. Scan at most 5K characters forward
457 for a display string or property. If found, set DISP_PROP_P
458 non-zero.
459
460 * bidi.c (bidi_fetch_char): Accept an additional argument
461 DISP_PROP_P, and pass it to compute_display_string_pos.
462 Only handle text covered by a display string if DISP_PROP_P is returned
463 non-zero. All callers of bidi_fetch_char changed.
464
465 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
466
467 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
468
469 2010-12-03 Don March <don@ohspite.net>
470
471 * keymap.c (Fdefine_key): Fix non-prefix key error message when
472 last character M-[char] is translated to ESC [char] (bug#7541).
473
474 2011-08-02 Kenichi Handa <handa@m17n.org>
475
476 * lisp.h (uniprop_table): Extern it.
477
478 * chartab.c (uniprop_table): Make it non-static.
479
480 2011-08-01 Eli Zaretskii <eliz@gnu.org>
481
482 * xdisp.c (forward_to_next_line_start): Accept additional argument
483 BIDI_IT_PREV, and store into it the state of the bidi iterator had
484 on the newline.
485 (reseat_at_next_visible_line_start): Use the bidi iterator state
486 returned by forward_to_next_line_start to restore the state of
487 it->bidi_it after backing up to previous newline. (Bug#9212)
488
489 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
490
491 * regex.c (re_comp): Protoize.
492 (re_exec): Fix return type.
493 (regexec): Fix type of `ret'. (Bug#9203)
494
495 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
496
497 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
498 This is needed if max-image-size is a floating-point number.
499
500 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
501
502 * print.c (print_object): Print empty symbol as ##.
503
504 * lread.c (read1): Read ## as empty symbol.
505
506 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
507
508 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
509 setting frame foreground color (Bug#9175).
510 (x_set_background_color): Likewise.
511
512 * nsmenu.m (-setText): Size tooltip dimensions precisely to
513 contents (Bug#9176).
514 (EmacsTooltip -init): Remove bezels and add shadows to
515 tooltip windows.
516
517 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
518 or scroll bar (Bug#8470).
519
520 * nsfont.m (nsfont_open): Remove assignment to voffset and
521 unnecessary vars hshink, expand, hd, full_height, min_height.
522 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
523
524 * nsterm.h (nsfont_info): Remove voffset field.
525
526 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
527
528 Implement strike-through and overline on NextStep (Bug#8863).
529
530 * nsfont.m (nsfont_open): Use underline position provided by font,
531 instead of hard-coded value of 2.
532 (nsfont_draw): Call ns_draw_text_decoration instead.
533
534 * nsterm.h: Add declaration for ns_draw_text_decoration.
535
536 * nsterm.m (ns_draw_text_decoration): New function for drawing
537 underline, overline, and strike-through.
538 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
539 ns_draw_text_decoration. Change treatment of cursor drawing to
540 accomodate underlining, etc.
541
542 2011-07-28 Eli Zaretskii <eliz@gnu.org>
543
544 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
545 default.
546
547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
548
549 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
550 Without this fix, if a signal arrives just after memory fills up,
551 'malloc' might be invoked reentrantly.
552
553 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
554 In other words, assume that every image size is allowed, on non-X
555 hosts. This assumption is probably wrong, but it lets Emacs compile.
556
557 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
558
559 * regex.c (re_iswctype): Convert return values to boolean.
560
561 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
562
563 * xdisp.c (compute_display_string_pos): Don't use cached display
564 string position if the buffer had its restriction changed.
565 (Bug#9184)
566
567 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
568
569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
570
571 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
572
573 Integer signedness and overflow and related fixes. (Bug#9079)
574
575 * bidi.c: Integer size and overflow fixes.
576 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
577 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
578 (bidi_cache_find_level_change, bidi_cache_ensure_space)
579 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
580 (bidi_find_other_level_edge):
581 Use ptrdiff_t instead of EMACS_INT where either will do.
582 This works better on 32-bit hosts configured --with-wide-int.
583 (bidi_cache_ensure_space): Check for size-calculation overflow.
584 Use % rather than repeated addition, for better worst-case speed.
585 Don't set bidi_cache_size until after xrealloc returns, because it
586 might not return.
587 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
588 (bidi_cache_ensure_space): Also check that the bidi cache size
589 does not exceed that of the largest Lisp string or buffer. See Eli
590 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
591
592 * alloc.c (__malloc_size_t): Remove.
593 All uses replaced by size_t. See Andreas Schwab's note
594 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
595
596 * image.c: Improve checking for integer overflow.
597 (check_image_size): Assume that f is nonnull, since
598 it is always nonnull in practice. This is one less thing to
599 worry about when checking for integer overflow later.
600 (x_check_image_size): New function, which checks for integer
601 overflow issues inside X.
602 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
603 This removes the need for a memory_full check.
604 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
605 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
606 (xbm_read_bitmap_data): Change locals back to 'int', since
607 their values must fit in 'int'.
608 (xpm_load_image, png_load, tiff_load):
609 Invoke x_create_x_image_and_pixmap earlier,
610 to avoid much needless work if the image is too large.
611 (tiff_load): Treat overly large images as if
612 x_create_x_image_and_pixmap failed, not as malloc failures.
613 (gs_load): Use x_check_image_size.
614
615 * gtkutil.c: Omit integer casts.
616 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
617 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
618
619 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
620
621 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
622 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
623 would wrongly return t on a 64-bit host.
624
625 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
626 The plain *_OVERFLOW macros run afoul of GCC bug 49705
627 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
628 and therefore cause GCC to emit a bogus diagnostic in some cases.
629
630 * image.c: Integer signedness and overflow and related fixes.
631 This is not an exhaustive set of fixes, but it's time to
632 record what I've got.
633 (lookup_pixel_color, check_image_size): Remove redundant decls.
634 (check_image_size): Don't assume that arbitrary EMACS_INT values
635 fit in 'int', or that arbitrary 'double' values fit in 'int'.
636 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
637 (tiff_load, imagemagick_load_image):
638 Check for overflow in size calculations.
639 (x_create_x_image_and_pixmap): Remove unnecessary test for
640 xmalloc returning NULL; that can't happen.
641 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
642 (xpm_color_bucket): Use better integer hashing function.
643 (xpm_cache_color): Don't possibly over-allocate memory.
644 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
645 (gif_memory_source):
646 Use ptrdiff_t, not int or size_t, to record sizes.
647 (png_load): Don't assume values greater than 2**31 fit in 'int'.
648 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
649 either works, as we prefer signed integers.
650 (tiff_read_from_memory, tiff_write_from_memory):
651 Return tsize_t, not size_t, since that's what the TIFF API wants.
652 (tiff_read_from_memory): Don't fail simply because the read would
653 go past EOF; instead, return a short read.
654 (tiff_load): Omit no-longer-needed casts.
655 (Fimagemagick_types): Don't assume size fits into 'int'.
656
657 Improve hashing quality when configured --with-wide-int.
658 * fns.c (hash_string): New function, taken from sxhash_string.
659 Do not discard information about ASCII character case; this
660 discarding is no longer needed.
661 (sxhash-string): Use it. Change sig to match it. Caller changed.
662 * lisp.h: Declare it.
663 * lread.c (hash_string): Remove, since we now use fns.c's version.
664 The fns.c version returns a wider integer if --with-wide-int is
665 specified, so this should help the quality of the hashing a bit.
666
667 * emacs.c: Integer overflow minor fix.
668 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
669 Define only if GNU_LINUX.
670 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
671
672 * dispnew.c: Integer signedness and overflow fixes.
673 Remove unnecessary forward decls, that were a maintenance hassle.
674 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
675 All uses changed.
676 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
677 (scrolling_window): Use ptrdiff_t, not int, for byte count.
678 (prepare_desired_row, line_draw_cost):
679 Use int, not unsigned, where either works.
680 (save_current_matrix, restore_current_matrix):
681 Use ptrdiff_t, not size_t, where either works.
682 (init_display): Check for overflow more accurately, and without
683 relying on undefined behavior.
684
685 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
686 Remove, replacing with the new symbols in lisp.h. All uses changed.
687 * fileio.c (make_temp_name):
688 * filelock.c (lock_file_1, lock_file):
689 * xdisp.c (message_dolog):
690 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
691 Use pMd etc. instead.
692 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
693 replacing the pWIDE etc. symbols removed from editfns.c.
694
695 * keyboard.h (num_input_events): Now uintmax_t.
696 This is (very slightly) less likely to mess up due to wraparound.
697 All uses changed.
698
699 * buffer.c: Integer signedness fixes.
700 (alloc_buffer_text, enlarge_buffer_text):
701 Use ptrdiff_t rather than size_t when either will do, as we prefer
702 signed integers.
703
704 * alloc.c: Integer signedness and overflow fixes.
705 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
706 (__malloc_size_t): Default to size_t, not to int.
707 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
708 (Fgarbage_collect, mark_object_loop_halt, mark_object):
709 Prefer ptrdiff_t to size_t when either would do, as we prefer
710 signed integers.
711 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
712 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
713 Now const. Initialize with values that are in range even if char
714 is signed.
715 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
716 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
717 These functions do the right thing with sizes > 2**32.
718 (check_depth): Now ptrdiff_t, not int.
719 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
720 Adjust to new way of storing sizes. Check for size overflow bugs
721 in rest of code.
722 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
723 slightly wrong anyway, as it missed one instance of
724 XMALLOC_OVERRUN_CHECK_OVERHEAD.
725 (refill_memory_reserve): Omit needless cast to size_t.
726 (mark_object_loop_halt): Mark as externally visible.
727
728 * xselect.c: Integer signedness and overflow fixes.
729 (Fx_register_dnd_atom, x_handle_dnd_message):
730 Use ptrdiff_t, not size_t, since we prefer signed.
731 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
732 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
733 x_dnd_atoms_size and x_dnd_atoms_length.
734
735 * doprnt.c: Prefer signed to unsigned when either works.
736 * eval.c (verror):
737 * doprnt.c (doprnt):
738 * lisp.h (doprnt):
739 * xdisp.c (vmessage):
740 Use ptrdiff_t, not size_t, when using or implementing doprnt,
741 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
742 prefer signed arithmetic to avoid comparison confusion.
743 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
744 but is a bit tricky.
745
746 Assume freestanding C89 headers, string.h, stdlib.h.
747 * data.c, doprnt.c, floatfns.c, print.c:
748 Include float.h unconditionally.
749 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
750 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
751 * regex.c: Likewise for stddef.h, string.h.
752 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
753 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
754 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
755 (STDC_HEADERS): Remove obsolete defines.
756 * sysdep.c: Include limits.h unconditionally.
757
758 Assume support for memcmp, memcpy, memmove, memset.
759 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
760 * regex.c (memcmp, memcpy):
761 Remove; we assume C89 now.
762
763 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
764 (__malloc_safe_bcopy): Remove; no longer needed.
765
766 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
767 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
768 well either way, and we prefer signed to unsigned.
769
770 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
771
772 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
773 closes the connection while we're reading (bug#9182).
774
775 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
776
777 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
778 are specified (Bug#9168).
779
780 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
781
782 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
783 Found by GCC static checking and --with-wide-int on a 32-bit host.
784
785 2011-07-25 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (compute_display_string_pos): Fix logic of caching
788 previous display string position. Initialize cached_prev_pos to
789 -1. Fixes slow-down at the beginning of a buffer.
790
791 2011-07-24 Eli Zaretskii <eliz@gnu.org>
792
793 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
794 for attrs[LFACE_FONTSET_INDEX].
795
796 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
797
798 * xml.c (parse_region): Remove unused local
799 that was recently introduced.
800
801 2011-07-23 Eli Zaretskii <eliz@gnu.org>
802
803 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
804 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
805
806 * xdisp.c (move_it_in_display_line_to): Record the best matching
807 position for TO_CHARPOS while scanning the line, and restore it on
808 exit if none of the characters scanned was an exact match.
809 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
810 when exact match is impossible due to invisible text, and the
811 lines are truncated.
812
813 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
814
815 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
816 for OSX >= 10.7.
817
818 2011-07-22 Eli Zaretskii <eliz@gnu.org>
819
820 Fix a significant slow-down of cursor motion with C-n, C-p,
821 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
822 auto-repeat under bidi redisplay in fontified buffers.
823 * xdisp.c (compute_stop_pos_backwards): New function.
824 (next_element_from_buffer): Call compute_stop_pos_backwards to
825 find a suitable prev_stop when we find ourselves before
826 base_level_stop.
827 (reseat): Don't look for prev_stop, as that could mean a very long
828 run.
829 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
830 <cached_disp_overlay_modiff>: Cache for last found display string
831 position.
832 (compute_display_string_pos): Return the cached position if asked
833 about the same buffer in the same area of character positions, and
834 the buffer wasn't changed since the time the display string
835 position was cached.
836
837 2011-07-22 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
840 is an integer, which is important for empty lines. (Bug#9149)
841
842 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
843
844 * frame.c (Fmodify_frame_parameters): In tty case, update the
845 default face if necessary (Bug#4238).
846
847 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
848
849 * editfns.c (Fstring_to_char): No need to explain what a character
850 is in the docstring (Bug#6576).
851
852 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
853
854 * xml.c (parse_region): Make sure we always return a tree.
855
856 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
857
858 * xml.c (parse_region): If a document contains only comments,
859 return that, too.
860
861 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
862
863 * xml.c (make_dom): Return comments, too.
864
865 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
866
867 Port to OpenBSD.
868 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
869 and the surrounding thread.
870 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
871 rather than fgets, and retry after EINTR. Otherwise, 'emacs
872 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
873 timer goes off.
874 * s/openbsd.h (BROKEN_SIGIO): Define.
875 * unexelf.c (unexec) [__OpenBSD__]:
876 Don't update the .mdebug section of the Alpha COFF symbol table.
877
878 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
879
880 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
881 (bug#8460).
882
883 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
884
885 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
886 This fixes some race conditions on the permissions of any newly
887 created file.
888
889 * alloc.c (valid_pointer_p): Use pipe, not open.
890 This fixes some permissions issues when debugging.
891
892 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
893 If fchown fails to set both uid and gid, try to set just gid,
894 as that is sometimes allowed. Adjust the file's mode to eliminate
895 setuid or setgid bits that are inappropriate if fchown fails.
896
897 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
898
899 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
900 to compare Lisp_Objects.
901 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
902 global_gnutls_log_level, don't mistake it for a Lisp_Object.
903 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
904
905 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
906
907 * lread.c (read_integer): Unread even EOF character.
908 (read1): Likewise. Properly record start position of symbol.
909
910 * lread.c (read1): Read `#:' as empty uninterned symbol if no
911 symbol character follows.
912
913 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
914
915 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
916 This works around a problem with the previous change to Fcopy_file.
917 Recent glibc declares fchown with __attribute__((warn_unused_result)),
918 and without this change, GCC might complain about discarding
919 fchown's return value.
920
921 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
922
923 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
924
925 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
926
927 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
928
929 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
930
931 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
932 it's used from the C level.
933
934 * process.c: Use the same condition for POLL_FOR_INPUT in both
935 keyboard.c and process.c (bug#1858).
936
937 2011-07-09 Lawrence Mitchell <wence@gmx.li>
938
939 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
940 (Fgnutls_boot): Use it.
941
942 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
943
944 * doc.c (Fsubstitute_command_keys): Revert last change.
945
946 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
947
948 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
949 quotes the next character, and doesn't affect other longer
950 sequences (bug#8935).
951
952 * lread.c (syms_of_lread): Clarify that is isn't only
953 `eval-buffer' and `eval-defun' that's affected by
954 `lexical-binding' (bug#8460).
955
956 2011-07-15 Eli Zaretskii <eliz@gnu.org>
957
958 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
959 bidi redisplay when a line includes both an image and is
960 truncated.
961
962 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
963
964 Fix minor problems found by static checking.
965 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
966 (elsz): Now a signed constant, not a size_t var. We prefer signed
967 types to unsigned, to avoid integer comparison confusion. Without
968 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
969 "cannot optimize loop, the loop counter may overflow", a symptom
970 of the confusion.
971 * indent.c (Fvertical_motion): Mark locals as initialized.
972 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
973
974 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
975
976 * search.c (Fre_search_backward): Mention `case-fold-search' in
977 all the re_search_* functions (bug#8138).
978
979 * keyboard.c (Fopen_dribble_file): Document when the file is
980 closed (bug#8056).
981
982 2011-07-14 Eli Zaretskii <eliz@gnu.org>
983
984 * bidi.c (bidi_dump_cached_states): Fix format of displaying
985 bidi_cache_idx.
986
987 Support bidi reordering of display and overlay strings.
988 * xdisp.c (compute_display_string_pos)
989 (compute_display_string_end): Accept additional argument STRING.
990 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
991 (reseat_to_string): Initialize bidi_it->string.s and
992 bidi_it->string.schars.
993 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
994 NULL (avoids a crash in bidi_paragraph_init).
995 Initialize itb.string.lstring.
996 (init_iterator): Call bidi_init_it only of a valid
997 buffer position was specified. Initialize paragraph_embedding to
998 L2R.
999 (reseat_to_string): Initialize the bidi iterator.
1000 (display_string): If we need to ignore text properties of
1001 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1002 original value of -1 will not work with bidi.)
1003 (compute_display_string_pos): First arg is now struct
1004 `text_pos *'; all callers changed. Support display properties on
1005 Lisp strings.
1006 (compute_display_string_end): Support display properties on Lisp
1007 strings.
1008 (init_iterator, reseat_1, reseat_to_string): Initialize the
1009 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1010 when iterating on a string not from display properties).
1011 (compute_display_string_pos, compute_display_string_end):
1012 Fix calculation of the object to scan. Fixes an error when using
1013 arrow keys.
1014 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1015 base_level_stop; instead, set base_level_stop to BEGV.
1016 Fixes crashes in vertical-motion.
1017 (next_element_from_buffer): Improve commentary for when
1018 the iterator is before prev_stop.
1019 (init_iterator): Initialize bidi_p from the default value of
1020 bidi-display-reordering, not from buffer-local value. Use the
1021 buffer-local value only if initializing for buffer iteration.
1022 (handle_invisible_prop): Support invisible properties on strings
1023 that are being bidi-reordered.
1024 (set_iterator_to_next): Support bidi reordering of C strings and
1025 Lisp strings.
1026 (next_element_from_string): Support bidi reordering of Lisp
1027 strings.
1028 (handle_stop_backwards): Support Lisp strings as well.
1029 (display_string): Support display of R2L glyph rows.
1030 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1031 (init_iterator): Don't initialize it->bidi_p for strings
1032 here.
1033 (reseat_to_string): Initialize it->bidi_p for strings here.
1034 (next_element_from_string, next_element_from_c_string)
1035 (next_element_from_buffer): Add xassert's for correspondence
1036 between IT's object being iterated and it->bidi_it.string
1037 structure.
1038 (face_before_or_after_it_pos): Support bidi iteration.
1039 (next_element_from_c_string): Handle the case of the first string
1040 character that is not the first one in the visual order.
1041 (get_visually_first_element): New function, refactored from common
1042 parts of next_element_from_buffer, next_element_from_string, and
1043 next_element_from_c_string.
1044 (tool_bar_lines_needed, redisplay_tool_bar)
1045 (display_menu_bar): Force left-to-right direction. Add a FIXME
1046 comment for making that be controlled by a user option.
1047 (push_it, pop_it): Save and restore the state of the
1048 bidi iterator. Save and restore the bidi_p flag.
1049 (pop_it): Iterate out of display property for string iteration as
1050 well.
1051 (iterate_out_of_display_property): Support iteration over strings.
1052 (handle_single_display_spec): Set up it->bidi_it for iteration
1053 over a display string, and call bidi_init_it.
1054 (handle_single_display_spec, next_overlay_string)
1055 (get_overlay_strings_1, push_display_prop): Set up the bidi
1056 iterator for displaying display or overlay strings.
1057 (forward_to_next_line_start): Don't use the shortcut if
1058 bidi-iterating.
1059 (back_to_previous_visible_line_start): If handle_display_prop
1060 pushed the iterator stack, restore the internal state of the bidi
1061 iterator by calling bidi_pop_it same number of times.
1062 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1063 and we are bidi-iterating, don't decrement the iterator position;
1064 instead, set the first_elt flag in the bidi iterator, to produce
1065 the same effect.
1066 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1067 (push_display_prop): xassert that we are iterating a buffer.
1068 (push_it, pop_it): Save and restore paragraph_embedding member.
1069 (handle_single_display_spec, next_overlay_string)
1070 (get_overlay_strings_1, reseat_1, reseat_to_string)
1071 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1072 correctly. Don't assume unibyte strings are not bidi-reordered.
1073 (compute_display_string_pos)
1074 (compute_display_string_end): Fix handling the case of C string.
1075 (push_it, pop_it): Save and restore from_disp_prop_p.
1076 (handle_single_display_spec, push_display_prop): Set the
1077 from_disp_prop_p flag.
1078 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1079 (pop_it): Call iterate_out_of_display_property only if we are
1080 popping after iteration over a string that came from a display
1081 property. Fix a typo in popping stretch info. Add an assertion
1082 for verifying that the iterator position is in sync with the bidi
1083 iterator.
1084 (handle_single_display_spec, get_overlay_strings_1)
1085 (push_display_prop): Fix initialization of paragraph direction for
1086 string when that of the parent object is not yet determined.
1087 (reseat_1): Call bidi_init_it to resync the bidi
1088 iterator with IT's position. (Bug#7616)
1089 (find_row_edges): If ROW->start.pos gives position
1090 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1091 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1092 Reset the from_disp_prop_p flag.
1093 (SAVE_IT, RESTORE_IT): New macros.
1094 (pos_visible_p, face_before_or_after_it_pos)
1095 (back_to_previous_visible_line_start)
1096 (move_it_in_display_line_to, move_it_in_display_line)
1097 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1098 (try_scrolling, redisplay_window, display_line): Use them when
1099 saving a temporary copy of the iterator and restoring it back.
1100 (back_to_previous_visible_line_start, reseat_1)
1101 (init_iterator): Empty the bidi cache "stack".
1102 (move_it_in_display_line_to): If iterator ended up at
1103 EOL, but we never saw any buffer positions smaller than
1104 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1105 motion in bidi-reordered lines.
1106 (move_it_in_display_line_to): Record prev_method and prev_pos
1107 immediately before the call to set_iterator_to_next. Fixes cursor
1108 motion in bidi-reordered lines with stretch glyphs and strings
1109 displayed in margins. (Bug#8133) (Bug#8867)
1110 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1111 TO_CHARPOS.
1112 (pos_visible_p): Support positions in bidi-reordered lines.
1113 Save and restore bidi cache.
1114
1115 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1116 (bidi_paragraph_info): Delete unused struct.
1117 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1118 (bidi_cache_start): New variable.
1119 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1120 to zero.
1121 (bidi_cache_fetch_state, bidi_cache_search)
1122 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1123 (bidi_cache_find, bidi_peek_at_next_level)
1124 (bidi_level_of_next_char, bidi_find_other_level_edge)
1125 (bidi_move_to_visually_next): Compare cache index with
1126 bidi_cache_start rather than with zero.
1127 (bidi_fetch_char): Accept new argument STRING; all callers
1128 changed. Support iteration over a string. Support strings with
1129 display properties. Support unibyte strings. Fix the type of
1130 `len' according to what STRING_CHAR_AND_LENGTH expects.
1131 (bidi_paragraph_init, bidi_resolve_explicit_1)
1132 (bidi_resolve_explicit, bidi_resolve_weak)
1133 (bidi_level_of_next_char, bidi_move_to_visually_next):
1134 Support iteration over a string.
1135 (bidi_set_sor_type, bidi_resolve_explicit_1)
1136 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1137 can now be zero (for strings); special values 0 and -1 were
1138 changed to -1 and -2, respectively.
1139 (bidi_char_at_pos): New function.
1140 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1141 Call it instead of FETCH_MULTIBYTE_CHAR.
1142 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1143 initialized to valid values.
1144 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1145 values.
1146 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1147 the test for valid cached positions. Fix the logic for looking up
1148 the sentinel state in the cache. GCPRO the Lisp string we are
1149 iterating.
1150 (bidi_push_it, bidi_pop_it): New functions.
1151 (bidi_initialize): Initialize the bidi cache start stack pointer.
1152 (bidi_cache_ensure_space): New function, refactored from part of
1153 bidi_cache_iterator_state. Don't assume the required size is just
1154 one BIDI_CACHE_CHUNK away.
1155 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1156 (bidi_count_bytes, bidi_char_at_pos): New functions.
1157 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1158 always valid if bidi_cache_idx is valid.
1159 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1160 is valid if it's going to be used.
1161 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1162 (bidi_cache_fetch_state, bidi_cache_search)
1163 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1164 (bidi_cache_iterator_state, bidi_cache_find)
1165 (bidi_find_other_level_edge, bidi_cache_start_stack):
1166 All variables related to cache indices are now EMACS_INT.
1167
1168 * dispextern.h (struct bidi_string_data): New structure.
1169 (struct bidi_it): New member `string'. Make flag members be 1-bit
1170 fields, and put them last in the struct.
1171 (compute_display_string_pos, compute_display_string_end):
1172 Update prototypes.
1173 (bidi_push_it, bidi_pop_it): Add prototypes.
1174 (struct iterator_stack_entry): New members bidi_p,
1175 paragraph_embedding, and from_disp_prop_p.
1176 (struct it): Member bidi_p is now a bit field 1 bit wide.
1177 (bidi_shelve_cache, bidi_unshelve_cache):
1178 Declare prototypes.
1179
1180 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1181 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1182 and vector-like objects.
1183
1184 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1185 cache around display iteration.
1186
1187 * window.c (Fwindow_end, window_scroll_pixel_based)
1188 (displayed_window_lines, Frecenter): Save and restore the bidi
1189 cache around display iteration.
1190
1191 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1192
1193 * editfns.c (Fdelete_region): Clarify the use of the named
1194 parameters (bug#6788).
1195
1196 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1197
1198 * indent.c (Fvertical_motion): Set and restore w->pointm when
1199 saving and restoring the window's buffer (Bug#9006).
1200
1201 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1202
1203 * editfns.c (Fstring_to_char): Clarify just what is returned
1204 (bug#6576). Text by Eli Zaretskii.
1205
1206 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1209
1210 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1211
1212 * buffer.c (mmap_find): Fix a typo.
1213
1214 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1215
1216 Fix execution of x selection hooks.
1217 * xselect.c (Qx_lost_selection_functions)
1218 (Qx_sent_selection_functions): New vars.
1219 (syms_of_xselect): DEFSYM them.
1220 (x_handle_selection_request): Pass Qx_sent_selection_functions
1221 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1222 (x_handle_selection_clear,x_clear_frame_selections):
1223 Pass Qx_lost_selection_functions rather than
1224 Vx_lost_selection_functions to Frun_hook_with_args.
1225
1226 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1229 The old code sometimes used this field without initializing it.
1230
1231 * alloc.c (gc_sweep): Don't read past end of array.
1232 In theory, the old code could also have corrupted Emacs internals,
1233 though it'd be very unlikely.
1234
1235 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1236
1237 * character.c (Fcharacterp): Don't advertise optional ignored
1238 argument. (Bug#4026)
1239
1240 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1241
1242 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1243 key" (bug#4257).
1244
1245 * window.c (Fset_window_start): Doc fix (bug#4199).
1246 (Fset_window_hscroll): Ditto.
1247
1248 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 Fix minor new problems caught by GCC 4.6.1.
1251 * term.c (init_tty): Remove unused local.
1252 * xsettings.c (store_monospaced_changed): Define this function only
1253 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1254 not used otherwise.
1255
1256 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1257
1258 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1259
1260 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1261
1262 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1263 are the mini-buffer and the echo area (bug#3320).
1264
1265 * term.c (init_tty): Remove support for supdup, c10 and perq
1266 terminals, which are no longer supported (bug#1482).
1267
1268 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1269
1270 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1271
1272 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1273
1274 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1275 for non-popups (Bug#3642).
1276
1277 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1278
1279 * alloc.c (reset_malloc_hooks): Protoize.
1280 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1281 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1282 * cm.c (losecursor): Likewise.
1283 * data.c (fmod): Likewise.
1284 * dispnew.c (swap_glyphs_in_rows): Likewise.
1285 * emacs.c (memory_warning_signal): Likewise.
1286 * floatfns.c (float_error): Likewise.
1287 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1288 (otf_open, font_otf_capability, generate_otf_features)
1289 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1290 Likewise.
1291 * image.c (pbm_read_file): Likewise.
1292 * indent.c (string_display_width): Likewise.
1293 * intervals.c (check_for_interval, search_for_interval)
1294 (inc_interval_count, count_intervals, root_interval)
1295 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1296 * lread.c (defalias): Likewise.
1297 * ralloc.c (r_alloc_check): Likewise.
1298 * regex.c (set_image_of_range_1, set_image_of_range)
1299 (regex_grow_registers): Likewise.
1300 * sysdep.c (strerror): Likewise.
1301 * termcap.c (valid_filename_p, tprint, main): Likewise.
1302 * tparam.c (main): Likewise.
1303 * unexhp9k800.c (run_time_remap, save_data_space)
1304 (update_file_ptrs, read_header, write_header, calculate_checksum)
1305 (copy_file, copy_rest, display_header): Likewise.
1306 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1307 Likewise.
1308 * xdisp.c (check_it): Likewise.
1309 * xfaces.c (register_color, unregister_color, unregister_colors):
1310 Likewise.
1311 * xfns.c (print_fontset_result): Likewise.
1312 * xrdb.c (member, fatal, main): Likewise.
1313
1314 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 Fix minor problems found by static checking (Bug#9031).
1317 * chartab.c (char_table_set_range, map_sub_char_table):
1318 Remove unused locals.
1319 (uniprop_table): Now static.
1320 * composite.c (_work_char): Remove unused static var.
1321
1322 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1323
1324 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1325
1326 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1327
1328 * gtkutil.c (qttip_cb): Remove code without function.
1329
1330 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1331
1332 * w32.c (pthread_sigmask): New stub.
1333
1334 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 Use pthread_sigmask, not sigprocmask (Bug#9010).
1337 sigprocmask is portable only for single-threaded applications, and
1338 Emacs can be multi-threaded when it uses GTK.
1339 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1340 (LIBES): Use it.
1341 * callproc.c (Fcall_process):
1342 * process.c (create_process):
1343 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1344 Use pthread_sigmask, not sigprocmask.
1345
1346 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1347
1348 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1349 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1350 wrong (Bug#8591).
1351
1352 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1353
1354 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1355 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1356 (xg_hide_tooltip): Fix comment.
1357
1358 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1359 in registerServicesMenuSendTypes.
1360 (validRequestorForSendType): Don't check ns_return_types.
1361
1362 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1363 ns_return_type.
1364
1365 2011-07-08 Jason Rumney <jasonr@gnu.org>
1366
1367 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1368 frame struct members of non-existent frames (Bug#6284).
1369
1370 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1371
1372 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1373 variable firstTime not needed on OSX >= 10.6.
1374 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1375 >= 10.5. Use setKnobProportion, setDoubleValue.
1376
1377 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1378 (MAC_OS_X_VERSION_10_5): Define if not defined.
1379 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1380 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1381 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1382
1383 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1384 cString and lossyCString on OSX >= 10.4
1385
1386 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1387 sizeToFit on OSX >= 10.2.
1388
1389 * nsimage.m (allocInitFromFile): Don't use deprecated method
1390 bestRepresentationForDevice on OSX >= 10.6.
1391
1392 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1393 to avoid warning.
1394
1395 * emacs.c: Declare unexec_init_emacs_zone.
1396
1397 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1398
1399 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1400
1401 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1402 on svcsMenu (Bug#8842).
1403
1404 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1405 ns_return_types.
1406 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1407
1408 * nsterm.m (QUTF8_STRING): Declare.
1409 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1410 (validRequestorForSendType): Return type is (id).
1411 Change indexOfObjectIdenticalTo to indexOfObject.
1412 Check if we have local selection before returning self (Bug#8842).
1413 (writeSelectionToPasteboard): Put local selection into paste board
1414 if we have a local selection (Bug#8842).
1415 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1416
1417 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1418 (ns_get_local_selection): Declare.
1419
1420 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1421
1422 * keymap.c (describe_map_tree): Don't insert a double newline at
1423 the end of the buffer (bug#1169) and return whether we inserted
1424 something.
1425
1426 * callint.c (Fcall_interactively): Change "reading args" to
1427 "providing args" to try to clarify what it does (bug#1010).
1428
1429 2011-07-07 Kenichi Handa <handa@m17n.org>
1430
1431 * composite.c (composition_compute_stop_pos): Ignore a static
1432 composition starting before CHARPOS (Bug#8915).
1433
1434 * xdisp.c (handle_composition_prop): Likewise.
1435
1436 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1437
1438 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1439 (Bug#9015)
1440
1441 2011-07-07 Kenichi Handa <handa@m17n.org>
1442
1443 * character.h (unicode_category_t): New enum type.
1444
1445 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1446 (Qchar_code_property_table): New variable.
1447 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1448 (UNIPROP_COMPRESSED_FORM_P): New macros.
1449 (char_table_ascii): Uncompress the compressed values.
1450 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1451 Uncompress the compressed values.
1452 (sub_char_table_ref_and_range): Likewise.
1453 (char_table_ref_and_range): Uncompress the compressed values.
1454 (sub_char_table_set): New arg is_uniprop. Callers changed.
1455 Uncompress the compressed values.
1456 (sub_char_table_set_range): Args changed. Callers changed.
1457 (char_table_set_range): Adjuted for the above change.
1458 (map_sub_char_table): Delete args default_val and parent. Add arg
1459 top. Give decoded values to a Lisp function.
1460 (map_char_table): Adjust for the above change. Give decoded
1461 values to a Lisp function. Gcpro more variables.
1462 (uniprop_table_uncompress)
1463 (uniprop_decode_value_run_length): New functions.
1464 (uniprop_decoder, uniprop_decoder_count): New variables.
1465 (uniprop_get_decoder, uniprop_encode_value_character)
1466 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1467 New functions.
1468 (uniprop_encoder, uniprop_encoder_count): New variables.
1469 (uniprop_get_encoder, uniprop_table)
1470 (Funicode_property_table_internal, Fget_unicode_property_internal)
1471 (Fput_unicode_property_internal): New functions.
1472 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1473 Sunicode_property_table_internal, Sget_unicode_property_internal,
1474 and Sput_unicode_property_internal. Defvar_lisp
1475 char-code-property-alist.
1476
1477 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1478 Vunicode_category_table.
1479
1480 * font.c (font_range): Adjust for the change of
1481 Vunicode_category_table.
1482
1483 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1484
1485 * m/iris4d.h: Remove file, move contents ...
1486 * s/irix6-5.h: ... here.
1487
1488 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 Remove unportable assumption about struct layout (Bug#8884).
1491 * alloc.c (mark_buffer):
1492 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1493 (clone_per_buffer_values): Don't assume that
1494 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1495 This isn't true in general, and it's particularly not true
1496 if Emacs is configured with --with-wide-int.
1497 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1498 New macros, used in the buffer.c change.
1499
1500 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1501
1502 * xsettings.c: Use both GConf and GSettings if both are available.
1503 (store_config_changed_event): Add comment.
1504 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1505 (store_tool_bar_style_changed): New functions.
1506 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1507 (struct xsettings): Move font inside HAVE_XFT.
1508 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1509 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1510 Move inside HAVE_XFT.
1511 (something_changed_gsettingsCB): Rename from something_changedCB.
1512 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1513 also.
1514 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1515 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1516 (something_changed_gconfCB): Rename from something_changedCB.
1517 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1518 (parse_settings): Move check for font inside HAVE_XFT.
1519 (read_settings, apply_xft_settings): Add comment.
1520 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1521 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1522 call store_font_name_changed.
1523 (xft_settings_event): Add comment.
1524 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1525 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1526 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1527 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1528 (xsettings_initialize): Call init_gsettings last.
1529 (xsettings_get_system_font, xsettings_get_system_normal_font):
1530 Add comment.
1531
1532 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 Random fixes. E.g., (random) never returned negative values.
1535 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1536 subseconds part to the entropy, as that's a bit more random.
1537 Prefer signed to unsigned, since the signedness doesn't matter and
1538 in general we prefer signed. When given a limit, use a
1539 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1540 latter isn't right if USE_2_TAGS_FOR_INTS.
1541 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1542 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1543
1544 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1545
1546 * textprop.c (text_property_stickiness):
1547 Obey Vtext_property_default_nonsticky.
1548 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1549 * w32fns.c (syms_of_w32fns):
1550 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1551
1552 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1555 This is more efficient than Ffile_directory_p and avoids a minor race.
1556
1557 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558
1559 * buffer.c (Foverlay_put): Say what the return value is
1560 (bug#7835).
1561
1562 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1563 is a directory before asking whether to use the file name
1564 (bug#7564).
1565 (barf_or_query_if_file_exists): Make the "File is a directory"
1566 error be more correct.
1567
1568 * fns.c (Frequire): Remove the mention of the .gz files, since
1569 that's installation-specific, but keep the mention of
1570 `get-load-suffixes'.
1571
1572 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1575 Report string overflow if the output is too long.
1576
1577 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1578
1579 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1580 (syms_of_gnutls): Remove duplicate DEFSYM for
1581 Qgnutls_bootprop_verify_hostname_error, an error for
1582 Qgnutls_bootprop_verify_error (which is no longer used).
1583
1584 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1585 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1586 Also (re)move comments that are misplaced or no longer relevant.
1587
1588 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1589
1590 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1591
1592 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1593
1594 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1595 and background color parameters if they have been changed.
1596
1597 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1598
1599 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1600
1601 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 * xsettings.c (SYSTEM_FONT): Define only when used.
1604 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1605
1606 * keymap.c (access_keymap_1): Now static.
1607
1608 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1611 leave any prefix arg for the up event (Bug#1586).
1612
1613 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * lread.c (syms_of_lread): Mention single symbols defined by
1616 `defvar' or `defconst' (bug#7154).
1617
1618 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1619 (Frequire): Mention get-load-suffixes.
1620
1621 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1622
1623 * window.h (window): Remove clone_number slot.
1624 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1625 Remove.
1626 (make_parent_window, make_window, saved_window)
1627 (Fset_window_configuration, save_window_save): Don't deal with
1628 clone numbers.
1629 * buffer.c (Qclone_number): Remove declaration.
1630 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1631
1632 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1633
1634 Add multiple inheritance to keymaps.
1635 * keymap.c (Fmake_composed_keymap): New function.
1636 (Fset_keymap_parent): Simplify.
1637 (fix_submap_inheritance): Remove.
1638 (access_keymap_1): New function extracted from access_keymap to handle
1639 embedded parents and handle lists of maps.
1640 (access_keymap): Use it.
1641 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1642 (Fcopy_keymap): Handle embedded parents.
1643 (Fcommand_remapping, define_as_prefix): Simplify.
1644 (Fkey_binding): Simplify.
1645 (syms_of_keymap): Move minibuffer-local-completion-map,
1646 minibuffer-local-filename-completion-map,
1647 minibuffer-local-must-match-map, and
1648 minibuffer-local-filename-must-match-map to Elisp.
1649 (syms_of_keymap): Defsubr make-composed-keymap.
1650 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1651 (parse_menu_item): Trivial simplification.
1652
1653 2011-07-01 Glenn Morris <rgm@gnu.org>
1654
1655 * Makefile.in (SETTINGS_LIBS): Fix typo.
1656
1657 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1658
1659 * coding.c (Fencode_coding_string): Record the last coding system
1660 used, as the function doc string says (bug#8738).
1661
1662 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1663
1664 * xsettings.c (store_monospaced_changed): Take new font as arg and
1665 check for change against current_mono_font.
1666 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1667 (emacs_settings_constructor, emacs_settings_get_property)
1668 (emacs_settings_set_property, emacs_settings_class_init)
1669 (emacs_settings_init, gsettings_obj): Remove.
1670 (something_changedCB): New function for HAVE_GSETTINGS.
1671 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1672 with value as argument.
1673 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1674 g_settings_new (Bug#8967). Do not create gsettings_obj.
1675 Remove calls to g_settings_bind. Connect something_changedCB to
1676 "changed".
1677
1678 * xgselect.c: Add defined (HAVE_GSETTINGS).
1679 (xgselect_initialize): Ditto.
1680
1681 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1682 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1683 xg_select.
1684
1685 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1686
1687 * eval.c (struct backtrace): Simplify and port the data structure.
1688 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1689 signed bit field, as this assumption is not portable and it makes
1690 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1691 "char debug_on_exit : 1" as this is not portable either; instead,
1692 use the portable "unsigned int debug_on_exit : 1". Remove unused
1693 member evalargs. Remove obsolete comments about cc bombing out.
1694
1695 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1696
1697 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1698 Let HAVE_GSETTINGS override HAVE_GCONF.
1699 (store_monospaced_changed): New function.
1700 (EMACS_SETTINGS): A new type derived from GObject to handle
1701 GSettings notifications.
1702 (emacs_settings_constructor, emacs_settings_get_property)
1703 (emacs_settings_set_property, emacs_settings_class_init):
1704 New functions.
1705 (gsettings_client, gsettings_obj): New variables.
1706 (GSETTINGS_SCHEMA): New define.
1707 (something_changedCB): Call store_monospaced_changed.
1708 (init_gsettings): New function.
1709 (xsettings_initialize): Call init_gsettings.
1710 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1711 to NULL.
1712
1713 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1714 GCONF_CFLAGS/LIBS.
1715
1716 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1717
1718 * window.c (resize_root_window, grow_mini_window)
1719 (shrink_mini_window): Rename Qresize_root_window to
1720 Qwindow_resize_root_window and Qresize_root_window_vertically to
1721 Qwindow_resize_root_window_vertically.
1722
1723 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1726
1727 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * makefile.w32-in: Redesign dependencies so they reflect more
1730 clearly which files are directly included by each source file,
1731 and not through other includes.
1732
1733 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1734
1735 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1736 (sort_overlays, overlay_strings): When an overlay's clone number
1737 matches the window's clone number process the overlay even if
1738 the overlay's window property doesn't match the current window.
1739
1740 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1741 (Fwindow_hchild): Rename to Fwindow_left_child.
1742 (Fwindow_next): Rename to Fwindow_next_sibling.
1743 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1744 (resize_window_check): Rename to window_resize_check.
1745 (resize_window_apply): Rename to window_resize_apply.
1746 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1747 (Fdelete_other_windows_internal, resize_frame_windows)
1748 (Fsplit_window_internal, Fdelete_window_internal)
1749 (grow_mini_window, shrink_mini_window)
1750 (Fresize_mini_window_internal): Fix callers accordingly.
1751
1752 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1753
1754 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1755 (emacs_fixed_set_min_size): Remove.
1756 (emacs_fixed_new): Take frame as argument.
1757
1758 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1759 (_EmacsFixedPrivate): Remove minwidth/height.
1760 Add struct frame *f.
1761 (emacs_fixed_init): Initialize priv->f.
1762 (get_parent_class, emacs_fixed_set_min_size): Remove.
1763 (emacs_fixed_new): Set priv->f to argument.
1764 (emacs_fixed_get_preferred_width)
1765 (emacs_fixed_get_preferred_height): Use min_width/height from
1766 frames size_hint to set minimum and natural (Bug#8919).
1767 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1768 and use min_width/height from frames size_hint to set
1769 min_width/height (Bug#8919).
1770
1771 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1772 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1773 Fix indentation.
1774
1775 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1776
1777 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1778 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1779 called at ZV.
1780
1781 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1782
1783 * process.c (wait_reading_process_output): Bypass select if
1784 waiting for a cell while ignoring keyboard input, and input is
1785 pending. Suggested by Jan Djärv (Bug#8869).
1786
1787 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Use gnulib's dup2 module instead of rolling our own.
1790 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1791
1792 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1793
1794 * dispnew.c (scrolling_window): Before scrolling, turn off a
1795 mouse-highlight in the window being scrolled.
1796
1797 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1798
1799 Move DEFSYM to lisp.h and use everywhere.
1800
1801 * character.h (DEFSYM): Move declaration...
1802 * lisp.h (DEFSYM): ...here.
1803
1804 * gnutls.c:
1805 * minibuf.c:
1806 * w32menu.c:
1807 * w32proc.c:
1808 * w32select.c: Don't include character.h.
1809
1810 * alloc.c (syms_of_alloc):
1811 * buffer.c (syms_of_buffer):
1812 * bytecode.c (syms_of_bytecode):
1813 * callint.c (syms_of_callint):
1814 * casefiddle.c (syms_of_casefiddle):
1815 * casetab.c (init_casetab_once):
1816 * category.c (init_category_once, syms_of_category):
1817 * ccl.c (syms_of_ccl):
1818 * cmds.c (syms_of_cmds):
1819 * composite.c (syms_of_composite):
1820 * dbusbind.c (syms_of_dbusbind):
1821 * dired.c (syms_of_dired):
1822 * dispnew.c (syms_of_display):
1823 * doc.c (syms_of_doc):
1824 * editfns.c (syms_of_editfns):
1825 * emacs.c (syms_of_emacs):
1826 * eval.c (syms_of_eval):
1827 * fileio.c (syms_of_fileio):
1828 * fns.c (syms_of_fns):
1829 * frame.c (syms_of_frame):
1830 * fringe.c (syms_of_fringe):
1831 * insdel.c (syms_of_insdel):
1832 * keymap.c (syms_of_keymap):
1833 * lread.c (init_obarray, syms_of_lread):
1834 * macros.c (syms_of_macros):
1835 * msdos.c (syms_of_msdos):
1836 * print.c (syms_of_print):
1837 * process.c (syms_of_process):
1838 * search.c (syms_of_search):
1839 * sound.c (syms_of_sound):
1840 * syntax.c (init_syntax_once, syms_of_syntax):
1841 * terminal.c (syms_of_terminal):
1842 * textprop.c (syms_of_textprop):
1843 * undo.c (syms_of_undo):
1844 * w32.c (globals_of_w32):
1845 * window.c (syms_of_window):
1846 * xdisp.c (syms_of_xdisp):
1847 * xfaces.c (syms_of_xfaces):
1848 * xfns.c (syms_of_xfns):
1849 * xmenu.c (syms_of_xmenu):
1850 * xsettings.c (syms_of_xsettings):
1851 * xterm.c (syms_of_xterm): Use DEFSYM.
1852
1853 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1854
1855 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1856
1857 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Integer and buffer overflow fixes (Bug#8873).
1860
1861 * print.c (printchar, strout): Check for string overflow.
1862 (PRINTPREPARE, printchar, strout):
1863 Don't set size unless allocation succeeds.
1864
1865 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1866 for sizes. Check for string overflow more accurately.
1867 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1868
1869 * macros.c: Integer and buffer overflow fixes.
1870 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1871 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1872 Use ptrdiff_t, not int, for sizes.
1873 Don't increment bufsize until after realloc succeeds.
1874 Check for size-calculation overflow.
1875 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1876
1877 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1878
1879 * lread.c: Integer overflow fixes.
1880 (read_integer): Radix is now EMACS_INT, not int,
1881 to improve quality of diagnostics for out-of-range radices.
1882 Calculate buffer size correctly for out-of-range radices.
1883 (read1): Check for integer overflow in radices, and in
1884 read-circle numbers.
1885 (read_escape): Avoid int overflow.
1886 (Fload, openp, read_buffer_size, read1)
1887 (substitute_object_recurse, read_vector, read_list, map_obarray):
1888 Use ptrdiff_t, not int, for sizes.
1889 (read1): Use EMACS_INT, not int, for sizes.
1890 Check for size overflow.
1891
1892 * image.c (cache_image): Check for size arithmetic overflow.
1893
1894 * lread.c: Integer overflow issues.
1895 (saved_doc_string_size, saved_doc_string_length)
1896 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1897 Now ptrdiff_t, not int.
1898 (read1): Don't assume doc string length fits in int. Check for
1899 out-of-range doc string lengths.
1900 (read_list): Don't assume file position fits in int.
1901 (read_escape): Check for hex character overflow.
1902
1903 2011-06-22 Leo Liu <sdl.web@gmail.com>
1904
1905 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1906 Move to minibuffer.el.
1907
1908 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1911 The following patches are for when GLYPH_DEBUG && !XASSERT.
1912 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1913 * dispnew.c (flush_stdout):
1914 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1915 Mark as externally visible.
1916 * dispnew.c (check_window_matrix_pointers): Now static.
1917 * dispnew.c (window_to_frame_vpos):
1918 * xfns.c (unwind_create_frame):
1919 * xterm.c (x_check_font): Remove unused local.
1920 * scroll.c (CHECK_BOUNDS):
1921 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1922 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1923 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1924 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1925 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1926 Now static.
1927 (debug_method_add): Use va_list and vsprintf rather than relying
1928 on undefined behavior with wrong number of arguments.
1929 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1930 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1931 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1932 since we're not interested in debugging glyphs with old libraries.
1933 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1934 GCC 4.6.0's static checking.
1935
1936 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 Integer overflow and signedness fixes (Bug#8873).
1939 A few related buffer overrun fixes, too.
1940
1941 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1942
1943 * dispextern.h (struct face.stipple):
1944 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1945 (x_bitmap_mask, x_allocate_bitmap_record)
1946 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1947 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1948 (x_create_bitmap_from_xpm_data):
1949 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1950 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1951 (.bitmaps_last):
1952 * xfaces.c (load_pixmap):
1953 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1954 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1955 (.bitmaps_last, struct x_output.icon_bitmap):
1956 Use ptrdiff_t, not int, for bitmap indexes.
1957 (x_allocate_bitmap_record): Check for size overflow.
1958 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1959
1960 Use ptrdiff_t, not int, for overlay counts.
1961 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1962 * editfns.c (overlays_around, get_pos_property):
1963 * textprop.c (get_char_property_and_overlay):
1964 * xdisp.c (next_overlay_change, note_mouse_highlight):
1965 * xfaces.c (face_at_buffer_position):
1966 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1967 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1968 (Fnext_overlay_change, Fprevious_overlay_change)
1969 (mouse_face_overlay_overlaps, Foverlays_in):
1970 Use ptrdiff_t, not int, for sizes.
1971 (overlays_at, overlays_in): Check for size-calculation overflow.
1972
1973 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1974
1975 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1976 (x_session_initialize): Do not assume string length fits in int.
1977
1978 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1979 This is unlikely, but can occur if DPI is outlandish.
1980
1981 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1982 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1983
1984 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1985 * xrdb.c (magic_file_p, search_magic_path):
1986 Omit last arg SUFFIX; it was always 0. All callers changed.
1987 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1988
1989 * xfont.c (xfont_match): Avoid need for strlen.
1990
1991 * xfns.c: Don't assume strlen fits in int.
1992 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1993
1994 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1995 not unsigned long, as we prefer signed integers. All callers changed.
1996 Detect integer overflow in repeat count.
1997 (message_dolog): Don't assume print length fits in 39 bytes.
1998 (display_mode_element): Don't assume strlen fits in int.
1999
2000 * termcap.c: Don't assume sizes fit in int and never overflow.
2001 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2002 (gobble_line): Check for size-calculation overflow.
2003
2004 * minibuf.c (Fread_buffer):
2005 * lread.c (intern, intern_c_string):
2006 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2007 Don't assume string length fits in int.
2008
2009 * keyboard.c (parse_tool_bar_item):
2010 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2011
2012 * font.c: Don't assume string length fits in int.
2013 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2014 Use ptrdiff_t, not int.
2015 (font_intern_prop): Don't assume string length fits in int.
2016 Don't assume integer property fits in fixnum.
2017 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2018
2019 * filelock.c: Fix some buffer overrun and integer overflow issues.
2020 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2021 Reformulate so as not to need the command string.
2022 Invoke gzip -cd rather than gunzip, as it's more portable.
2023 (lock_info_type, lock_file_1, lock_file):
2024 Don't assume pid_t and time_t fit in unsigned long.
2025 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2026 (current_lock_owner): Prefer signed type for sizes.
2027 Use memcpy, not strncpy, where memcpy is what is really wanted.
2028 Don't assume (via atoi) that time_t and pid_t fit in int.
2029 Check for time_t and/or pid_t out of range, e.g., via a network share.
2030 Don't alloca where an auto var works fine.
2031
2032 * fileio.c: Fix some integer overflow issues.
2033 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2034 Don't assume string length fits in int.
2035 (directory_file_name): Don't assume string length fits in long.
2036 (make_temp_name): Don't assume pid fits in int, or that its print
2037 length is less than 20.
2038
2039 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2040
2041 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2042
2043 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2044
2045 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2046 We prefer signed integers, even for size calculations.
2047
2048 * emacs.c: Don't assume string length fits in 'int'.
2049 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2050 (main): Don't invoke strlen when not needed.
2051
2052 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2053 (XD_DEBUG_MESSAGE): Don't waste a byte.
2054
2055 * callproc.c (getenv_internal_1, getenv_internal)
2056 (Fgetenv_internal):
2057 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2058
2059 * lread.c (invalid_syntax): Omit length argument.
2060 All uses changed. This doesn't fix a bug, but it simplifies the
2061 code away from its former Hollerith-constant appearance, and it's
2062 one less 'int' to worry about when looking at integer-overflow issues.
2063 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2064
2065 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2066 This didn't break anything, but it didn't help either.
2067 It's confusing to put a bogus integer in a place where the actual
2068 value does not matter.
2069 (LIST_END_P): Remove unused macro and its bogus comment.
2070 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2071
2072 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2073 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2074 implementation.
2075 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2076 We prefer signed types, and the value cannot exceed the EMACS_INT
2077 range anyway (because otherwise the length would not be representable).
2078 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2079 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2080 This avoids a GCC warning when WIDE_EMACS_INT.
2081
2082 * indent.c (sane_tab_width): New function.
2083 (current_column, scan_for_column, Findent_to, position_indentation)
2084 (compute_motion): Use it. This is just for clarity.
2085 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2086
2087 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2088
2089 * lisp.h (lint_assume): New macro.
2090 * composite.c (composition_gstring_put_cache):
2091 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2092
2093 * editfns.c, insdel.c:
2094 Omit unnecessary forward decls, to simplify future changes.
2095
2096 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2097
2098 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2099
2100 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2101 Use much-faster test for byte-length change.
2102 Don't assume string byte-length fits in 'int'.
2103 Check that character arg fits in 'int'.
2104 (mapcar1): Declare byte as byte, for clarity.
2105
2106 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2107
2108 * fns.c (concat): Catch string overflow earlier.
2109 Do not rely on integer wraparound.
2110
2111 * dispextern.h (struct it.overlay_strings_charpos)
2112 (struct it.selective): Now EMACS_INT, not int.
2113 * xdisp.c (forward_to_next_line_start)
2114 (back_to_previous_visible_line_start)
2115 (reseat_at_next_visible_line_start, next_element_from_buffer):
2116 Don't arbitrarily truncate the value of 'selective' to int.
2117
2118 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2119
2120 * composite.c: Don't truncate sizes to 'int'.
2121 (composition_gstring_p, composition_reseat_it)
2122 (composition_adjust_point): Use EMACS_INT, not int.
2123 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2124 not EMACS_UINT, for indexes.
2125
2126 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2127
2128 * buffer.c: Include <verify.h>.
2129 (struct sortvec.priority, struct sortstr.priority):
2130 Now EMACS_INT, not int.
2131 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2132 (struct sortstr.size, record_overlay_string)
2133 (struct sortstrlist.size, struct sortlist.used):
2134 Don't truncate size to int.
2135 (record_overlay_string): Check for size-calculation overflow.
2136 (init_buffer_once): Check at compile-time, not run-time.
2137
2138 2011-06-22 Jim Meyering <meyering@redhat.com>
2139
2140 Don't leak an XBM-image-sized buffer
2141 * image.c (xbm_load): Free the image buffer after using it.
2142
2143 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 Port to Sun C.
2146 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2147 that Sun C diagnosed.
2148 * fns.c (secure_hash): Fix pointer signedness issue.
2149 * intervals.c (static_offset_intervals): New function.
2150 (offset_intervals): Use it.
2151
2152 2011-06-21 Leo Liu <sdl.web@gmail.com>
2153
2154 * deps.mk (fns.o):
2155 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2156 sha512.h.
2157
2158 * fns.c (secure_hash): Rename from crypto_hash_function and change
2159 the first arg to accept symbols.
2160 (Fsecure_hash): New primitive.
2161 (syms_of_fns): New symbols.
2162
2163 2011-06-20 Deniz Dogan <deniz@dogan.se>
2164
2165 * process.c (Fset_process_buffer): Clarify return value in
2166 docstring.
2167
2168 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2169
2170 * dispnew.c (add_window_display_history): Use BVAR.
2171
2172 * xdisp.c (debug_method_add): Use BVAR.
2173 (check_window_end, dump_glyph_matrix, dump_glyph)
2174 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2175
2176 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2177 Likewise.
2178
2179 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2180 check till after the cache is created in init_frame_faces.
2181
2182 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2183
2184 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2185
2186 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2189 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2190 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2191
2192 Improve buffer-overflow checking (Bug#8873).
2193 * fileio.c (Finsert_file_contents):
2194 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2195 Remove the old (too-loose) buffer overflow checks.
2196 They weren't needed, since make_gap checks for buffer overflow.
2197 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2198 The old code merely checked for Emacs fixnum overflow, and relied
2199 on undefined (wraparound) behavior. The new code avoids undefined
2200 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2201
2202 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2203 Tune. Don't use wider integers than needed. Don't use alloca.
2204 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2205
2206 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2207
2208 * insdel.c, lisp.h (buffer_overflow): New function.
2209 (insert_from_buffer_1, replace_range, replace_range_2):
2210 * insdel.c (make_gap_larger):
2211 * editfns.c (Finsert_char):
2212 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2213
2214 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2215
2216 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 Integer overflow and signedness fixes (Bug#8873).
2219
2220 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2221 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2222
2223 * fileio.c: Don't assume EMACS_INT fits in off_t.
2224 (emacs_lseek): New static function.
2225 (Finsert_file_contents, Fwrite_region): Use it.
2226 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2227
2228 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2229
2230 * fns.c: Don't overflow int when computing a list length.
2231 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2232 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2233 truncation on 64-bit hosts. Check for QUIT every
2234 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2235 faster and is responsive enough.
2236 (Flength): Report an error instead of overflowing an integer.
2237 (Fsafe_length): Return a float if the value is not representable
2238 as a fixnum. This shouldn't happen except in contrived situations.
2239 (Fnthcdr, Fsort): Don't assume list length fits in int.
2240 (Fcopy_sequence): Don't assume vector length fits in int.
2241
2242 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2243 (header_size, word_size): New constants.
2244 (allocate_vectorlike): Don't check size overflow here.
2245 (allocate_vector): Check it here instead, since this is the only
2246 caller of allocate_vectorlike that could cause overflow.
2247 Check that the new vector's length is representable as a fixnum.
2248
2249 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2250 The previous code was bogus. For example, next_almost_prime (32)
2251 returned 39, which is undesirable as it is a multiple of 3; and
2252 next_almost_prime (24) returned 25, which is a multiple of 5 so
2253 why was the code bothering to check for multiples of 7?
2254
2255 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2256
2257 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2258
2259 Variadic C functions now count arguments with ptrdiff_t.
2260 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2261 Back then I didn't know that the Emacs coding style prefers signed int.
2262 Also, in the meantime I found a few more instances where arguments
2263 were being counted with int, which may truncate counts on 64-bit
2264 machines, or EMACS_INT, which may be unnecessarily wide.
2265 * lisp.h (struct Lisp_Subr.function.aMANY)
2266 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2267 Arg counts are now ptrdiff_t, not size_t.
2268 All variadic functions and their callers changed accordingly.
2269 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2270 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2271 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2272 * callint.c (Fcall_interactively): Check arg count for overflow,
2273 to avoid potential buffer overrun. Use signed char, not 'int',
2274 for 'varies' array, so that we needn't bother to check its size
2275 calculation for overflow.
2276 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2277 * eval.c (apply_lambda):
2278 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2279 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2280 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2281
2282 * callint.c (Fcall_interactively): Don't use index var as event count.
2283
2284 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2285 * mem-limits.h (SIZE): Remove; no longer used.
2286
2287 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2288
2289 Remove unnecessary casts.
2290 * xterm.c (x_term_init):
2291 * xfns.c (x_set_border_pixel):
2292 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2293 These aren't needed now that we assume ANSI C.
2294
2295 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2296 It's more likely to cause problems (due to unsigned overflow)
2297 than to cure them.
2298
2299 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2300
2301 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2302
2303 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2304
2305 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2306
2307 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2308
2309 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2310
2311 GLYPH_CODE_FACE returns EMACS_INT, not int.
2312 * dispextern.h (merge_faces):
2313 * xfaces.c (merge_faces):
2314 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2315 Don't assume EMACS_INT fits in int.
2316
2317 * character.h (CHAR_VALID_P): Remove unused parameter.
2318 * fontset.c, lisp.h, xdisp.c: All uses changed.
2319
2320 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2321
2322 * fns.c (concat): Minor tuning based on overflow analysis.
2323 This doesn't fix any bugs. Use int to hold character, instead
2324 of constantly refetching from Emacs object. Use XFASTINT, not
2325 XINT, for value known to be a character. Don't bother comparing
2326 a single byte to 0400, as it's always less.
2327
2328 * floatfns.c (Fexpt):
2329 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2330
2331 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2332 for characters.
2333
2334 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2335
2336 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2337 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2338 incorrectly succeed when S was a string, because 4294967386 was
2339 truncated before it was used.
2340
2341 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2342 Otherwise, an out-of-range integer could cause undefined behavior
2343 on a 64-bit host.
2344
2345 * composite.c: Use int, not EMACS_INT, for characters.
2346 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2347 EMACS_INT, for values that are known to be in character range.
2348 This doesn't fix any bugs but is the usual style inside Emacs and
2349 may generate better code on 32-bit machines.
2350
2351 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2352 This is for reasons similar to the recent CHAR_STRING fix.
2353 * charset.c (Fencode_char): Check that character arg is actually
2354 a character. Pass an int to ENCODE_CHAR.
2355 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2356 wider than 'int', as a compile-time check to prevent future regressions
2357 in this area.
2358
2359 * character.c (char_string): Remove unnecessary casts.
2360
2361 Make sure a 64-bit char is never passed to CHAR_STRING.
2362 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2363 by silently ignoring the top 32 bits, allowing some values
2364 that were far too large to be valid characters.
2365 * character.h: Include <verify.h>.
2366 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2367 arguments are no wider than unsigned, as a compile-time check
2368 to prevent future regressions in this area.
2369 * data.c (Faset):
2370 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2371 (Fsubst_char_in_region):
2372 * fns.c (concat):
2373 * xdisp.c (decode_mode_spec_coding):
2374 Adjust to CHAR_STRING's new requirement.
2375 * editfns.c (Finsert_char, Fsubst_char_in_region):
2376 * fns.c (concat): Check that character args are actually
2377 characters. Without this test, these functions did the wrong
2378 thing with wildly out-of-range values on 64-bit hosts.
2379
2380 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2381 These casts should not be needed on 32-bit hosts, either.
2382 * keyboard.c (read_char):
2383 * lread.c (Fload): Remove casts to unsigned.
2384
2385 * lisp.h (UNSIGNED_CMP): New macro.
2386 This fixes comparison bugs on 64-bit hosts.
2387 (ASCII_CHAR_P): Use it.
2388 * casefiddle.c (casify_object):
2389 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2390 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2391 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2392 * dispextern.h (FACE_FROM_ID):
2393 * keyboard.c (read_char): Use UNSIGNED_CMP.
2394
2395 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2396 not to EMACS_INT, to avoid GCC warning.
2397
2398 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2399
2400 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2401 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2402 isn't needed on 32-bit machines.
2403
2404 * buffer.c (Fgenerate_new_buffer_name):
2405 Use EMACS_INT for count, not int.
2406 (advance_to_char_boundary): Return EMACS_INT, not int.
2407
2408 * data.c (Qcompiled_function): Now static.
2409
2410 * window.c (window_body_lines): Now static.
2411
2412 * image.c (gif_load): Rename local to avoid shadowing.
2413
2414 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2415 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2416 * alloc.c (make_save_value): Integer argument is now of type
2417 ptrdiff_t, not int.
2418 (mark_object): Use ptrdiff_t, not int.
2419 * lisp.h (pD): New macro.
2420 * print.c (print_object): Use it.
2421
2422 * alloc.c: Use EMACS_INT, not int, to count objects.
2423 (total_conses, total_markers, total_symbols, total_vector_size)
2424 (total_free_conses, total_free_markers, total_free_symbols)
2425 (total_free_floats, total_floats, total_free_intervals)
2426 (total_intervals, total_strings, total_free_strings):
2427 Now EMACS_INT, not int. All uses changed.
2428 (Fgarbage_collect): Compute overall total using a double, so that
2429 integer overflow is less likely to be a problem. Check for overflow
2430 when converting back to an integer.
2431 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2432 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2433 These were 'int' variables that could overflow on 64-bit hosts;
2434 they were never used, so remove them instead of repairing them.
2435 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2436 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2437 Previously, this ceilinged at INT_MAX, but that doesn't work on
2438 64-bit machines.
2439 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2440
2441 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2442 (allocate_vectorlike): Check for ptrdiff_t overflow.
2443 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2444 when a (possibly-narrower) signed value would do just as well.
2445 We prefer using signed arithmetic, to avoid comparison confusion.
2446
2447 * alloc.c: Catch some string size overflows that we were missing.
2448 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2449 for convenience in STRING_BYTES_MAX.
2450 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2451 The definition here is exact; the one in lisp.h was approximate.
2452 (allocate_string_data): Check for string overflow. This catches
2453 some instances we weren't catching before. Also, it catches
2454 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2455 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2456 and ptrdiff_t and EMACS_INT are both 64 bits.
2457
2458 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2459 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2460 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2461
2462 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2463
2464 * alloc.c (Fmake_string): Check for out-of-range init.
2465
2466 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2467
2468 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2469
2470 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2471
2472 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2473 xg_get_default_scrollbar_width.
2474
2475 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2476 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2477 (style_changed_cb): Call update_theme_scrollbar_width and call
2478 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2479 all frames (Bug#8505).
2480 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2481 Call gtk_window_set_resizable if HAVE_GTK3.
2482 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2483 and height if HAVE_GTK3 (Bug#8505).
2484 (scroll_bar_width_for_theme): New variable.
2485 (update_theme_scrollbar_width): New function.
2486 (xg_get_default_scrollbar_width): Move code to
2487 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2488 (xg_initialize): Call update_theme_scrollbar_width.
2489
2490 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2491
2492 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2493
2494 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2495
2496 * frame.c (make_frame): Call other_buffer_safely instead of
2497 other_buffer.
2498
2499 * window.c (temp_output_buffer_show): Call display_buffer with
2500 second argument Vtemp_buffer_show_specifiers and reset latter
2501 immediately after the call.
2502 (Vtemp_buffer_show_specifiers): New variable.
2503 (auto_window_vscroll_p, next_screen_context_lines)
2504 (Vscroll_preserve_screen_position): Remove leading asterisks from
2505 doc-strings.
2506
2507 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 Fix minor problems found by GCC 4.6.0 static checking.
2510 * buffer.c (Qclone_number): Remove for now, as it's unused.
2511 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2512 (record_buffer): Remove unused local.
2513 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2514 (set_frame_buffer_list): Remove; unused.
2515 * frame.h (other_visible_frames): Remove decl.
2516 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2517 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2518 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2519 if HAVE_GPM.
2520 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2521 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2522 Define only if HAVE_GPM.
2523 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2524 (update_hints_inhibit): Remove; never set. All uses removed.
2525 * widgetprv.h (emacsFrameClassRec): Remove decl.
2526 * window.c (delete_deletable_window): Now returns void, since it
2527 wasn't returning anything.
2528 (compare_window_configurations): Remove unused locals.
2529 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2530 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2531 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2532 the same widths as pointers. This follows up on the 2011-05-06 patch.
2533 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2534 * xterm.h: Likewise.
2535 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2536
2537 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * makefile.w32-in: Update dependencies.
2540 (LISP_H): Add lib/intprops.h.
2541
2542 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2543
2544 * image.c (gif_load): Add animation frame delay to the metadata.
2545 (syms_of_image): Use DEFSYM. New symbol `delay'.
2546
2547 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2548
2549 * window.c (delete_deletable_window): Re-add.
2550 (Fset_window_configuration): Rewrite to handle dead buffers and
2551 consequently deletable windows.
2552 (window_tree, Fwindow_tree): Remove. Supply functionality in
2553 window.el.
2554 (compare_window_configurations): Simplify code.
2555
2556 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2557
2558 * image.c (imagemagick_load_image): Fix type mismatch.
2559 (Fimagemagick_types): Likewise.
2560
2561 * window.h (replace_buffer_in_windows): Declare.
2562
2563 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2564
2565 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2566 Qclone_number. Remove external declaration of Qdelete_window.
2567 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2568 code.
2569 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2570 Run Qbuffer_list_update_hook if allowed.
2571 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2572 buffer list implementation.
2573 (other_buffer_safely): New function.
2574 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2575 calls to replace_buffer_in_windows and
2576 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2577 if allowed.
2578 (record_buffer): Inhibit quitting and rewrite using quittable
2579 functions. Run Qbuffer_list_update_hook if allowed.
2580 (Frecord_buffer, Funrecord_buffer): New functions.
2581 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2582 Move switch-to-buffer to window.el.
2583 (bury-buffer): Move to window.el.
2584 (Vbuffer_list_update_hook): New variable.
2585
2586 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2587 section.
2588
2589 * window.h (resize_frame_windows): Move up in code.
2590 (Fwindow_frame): Remove EXFUN.
2591 (replace_buffer_in_all_windows): Remove prototype.
2592 (replace_buffer_in_windows_safely): Add prototype.
2593
2594 * window.c: Declare Qdelete_window static again. Move down
2595 declaration of select_count.
2596 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2597 (Fother_window): Move to window.el.
2598 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2599 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2600 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2601 window.el.
2602 (replace_buffer_in_windows): Implement by calling
2603 Qreplace_buffer_in_windows.
2604 (replace_buffer_in_all_windows): Remove with some functionality
2605 moved into replace_buffer_in_windows_safely.
2606 (replace_buffer_in_windows_safely): New function.
2607 (select_window_norecord, select_frame_norecord): Move in front
2608 of run_window_configuration_change_hook. Remove now obsolete
2609 declarations.
2610 (Fset_window_buffer): Rewrite doc-string.
2611 Call Qrecord_window_buffer.
2612 (keys_of_window): Move binding for other-window to window.el.
2613
2614 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2615
2616 * dispextern.h (struct image): Replace data member, whose int_val
2617 and ptr_val fields were not used by anything, with a single
2618 lisp_val object.
2619
2620 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2621 (gif_clear_image, gif_load, imagemagick_load_image)
2622 (gs_clear_image, gs_load): Callers changed.
2623
2624 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2625
2626 * buffer.h: Include <time.h>, for time_t.
2627 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2628
2629 Fix minor problems found by static checking.
2630
2631 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2632
2633 Make identifiers static if they are not used in other modules.
2634 * data.c (Qcompiled_function, Qframe, Qvector):
2635 * image.c (QimageMagick, Qsvg):
2636 * minibuf.c (Qmetadata):
2637 * window.c (resize_window_check, resize_root_window): Now static.
2638 * window.h (resize_window_check, resize_root_window): Remove decls.
2639
2640 * window.c (window_deletion_count, delete_deletable_window):
2641 Remove; unused.
2642 (window_body_lines): Now static.
2643 (Fdelete_other_windows_internal): Mark vars as initialized.
2644 Make sure 'resize_failed' is initialized.
2645 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2646 (resize_window_apply): Remove unused local.
2647 * window.h (delete_deletable_window): Remove decl.
2648
2649 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2650 (imagemagick_load_image): Fix pointer signedness problem by changing
2651 last arg from unsigned char * to char *. All uses changed.
2652 Also, fix a local for similar reasons.
2653 Remove unused locals. Remove locals to avoid shadowing.
2654 (fn_rsvg_handle_free): Remove; unused.
2655 (svg_load, svg_load_image): Fix pointer signedness problem.
2656 (imagemagick_load_image): Don't use garbage pointer image_wand.
2657
2658 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2659
2660 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2661
2662 * image.c (gif_load): Fix omitted cast error introduced by
2663 2011-06-06 change.
2664
2665 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2666
2667 * window.h (resize_proportionally, orig_total_lines)
2668 (orig_top_line): Remove from window structure.
2669 (set_window_height, set_window_width, change_window_heights)
2670 (Fdelete_window): Remove prototypes.
2671 (resize_frame_windows): Remove duplicate declaration.
2672
2673 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2674
2675 * window.h (resize_frame_windows, resize_window_check)
2676 (delete_deletable_window, resize_root_window)
2677 (resize_frame_windows): Declare prototypes.
2678
2679 * window.c (resize_window_apply): Make definition be "static" to
2680 match the prototype.
2681
2682 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2683
2684 * window.c: Remove declarations of Qwindow_size_fixed,
2685 window_min_size_1, window_min_size_2, window_min_size,
2686 size_window, window_fixed_size_p, enlarge_window, delete_window.
2687 Remove static from declaration of Qdelete_window, it's
2688 temporarily needed by Fbury_buffer.
2689 (replace_window): Don't assign orig_top_line and
2690 orig_total_lines.
2691 (Fdelete_window, delete_window): Remove. Window deletion is
2692 handled by window.el.
2693 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2694 Replace Fdelete_window calls with calls to Qdelete_window.
2695 (Fdelete_other_windows): Remove. Deleting other windows is
2696 handled by window.el.
2697 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2698 handled in window.el.
2699 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2700 Window minimum sizes are handled in window.el.
2701 (shrink_windows, size_window, set_window_height)
2702 (set_window_width, change_window_heights, window_height)
2703 (window_width, CURBEG, CURSIZE, enlarge_window)
2704 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2705 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2706 handled in window.el.
2707 (make_dummy_parent): Rename to make_parent_window and give it a
2708 second argument horflag.
2709 (make_window): Don't set resize_proportionally any more.
2710 (Fsplit_window): Remove. Windows are split in window.el.
2711 (save_restore_action, save_restore_orig_size)
2712 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2713 Resize mini windows in window.el.
2714 (grow_mini_window, shrink_mini_window): Implement by calling
2715 Qresize_root_window_vertically, resize_window_check and
2716 resize_window_apply.
2717 (saved_window, Fset_window_configuration, save_window_save):
2718 Do not handle orig_top_line, orig_total_lines, and
2719 resize_proportionally.
2720 (window_min_height, window_min_width): Move to window.el.
2721 (keys_of_window): Move bindings for delete-other-windows,
2722 split-window, delete-window and enlarge-window to window.el.
2723
2724 * buffer.c: Temporarily extern Qdelete_window.
2725 (Fbury_buffer): Temporarily call Qdelete_window instead of
2726 Fdelete_window (Fbury_buffer will move to window.el soon).
2727
2728 * frame.c (set_menu_bar_lines_1): Remove code handling
2729 orig_top_line and orig_total_lines.
2730
2731 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2732 set_window_height but set heights directly.
2733 (change_frame_size_1): Use resize_frame_windows.
2734
2735 * xdisp.c (init_xdisp): Don't use set_window_height but set
2736 heights directly.
2737
2738 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2739 Use resize_frame_windows instead of change_window_heights and run
2740 run_window_configuration_change_hook.
2741
2742 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2743 instead of change_window_heights and run
2744 run_window_configuration_change_hook.
2745
2746 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2747
2748 * window.c (replace_window): Rename second argument REPLACEMENT to
2749 NEW. New third argument SETFLAG. Rewrite.
2750 (delete_window, make_dummy_parent): Call replace_window with
2751 third argument 1.
2752 (window_list_1): Move down in code.
2753 (run_window_configuration_change_hook): Move set_buffer part
2754 before select_frame_norecord part in order to unwind correctly.
2755 Rename count1 to count.
2756 (recombine_windows, delete_deletable_window, resize_root_window)
2757 (Fdelete_other_windows_internal)
2758 (Frun_window_configuration_change_hook, make_parent_window)
2759 (resize_window_check, resize_window_apply, Fresize_window_apply)
2760 (resize_frame_windows, Fsplit_window_internal)
2761 (Fdelete_window_internal, Fresize_mini_window_internal):
2762 New functions.
2763 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2764
2765 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2766
2767 * window.h (window): Add some new members to window structure -
2768 normal_lines, normal_cols, new_total, new_normal, clone_number,
2769 splits, nest, prev_buffers, next_buffers.
2770 (WINDOW_TOTAL_SIZE): Move here from window.c.
2771 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2772
2773 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2774 Remove.
2775 (make_dummy_parent): Set new members of windows structure.
2776 (make_window): Move down in code. Handle new members of window
2777 structure.
2778 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2779 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2780 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2781 (Fset_window_prev_buffers, Fwindow_next_buffers)
2782 (Fset_window_next_buffers, Fset_window_clone_number):
2783 New functions.
2784 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2785 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2786 Doc-string fixes.
2787 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2788 Argument WINDOW can be now internal window too.
2789 (Fwindow_use_time): Move up in code.
2790 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2791 Rewrite doc-string.
2792 (Fset_window_configuration, saved_window)
2793 (Fcurrent_window_configuration, save_window_save): Handle new
2794 members of window structure.
2795 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2796 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2797 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2798 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2799 Qget_mru_window, Qresize_root_window,
2800 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2801 Qauto_buffer_name; staticpro them.
2802
2803 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2804
2805 * window.c (Fwindow_total_size, Fwindow_left_column)
2806 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2807 (Fwindow_list_1): New functions.
2808 (window_box_text_cols): Replace with window_body_cols.
2809 (Fwindow_width, Fscroll_left, Fscroll_right):
2810 Use window_body_cols instead of window_box_text_cols.
2811 (delete_window, Fset_window_configuration):
2812 Call delete_all_subwindows with window as argument.
2813 (delete_all_subwindows): Take a window as argument and not a
2814 structure. Rewrite.
2815 (window_loop): Remove handling of GET_LRU_WINDOW and
2816 GET_LARGEST_WINDOW.
2817 (Fget_lru_window, Fget_largest_window): Move to window.el.
2818
2819 * window.h: Extern window_body_cols instead of
2820 window_box_text_cols. delete_all_subwindows now takes a
2821 Lisp_Object as argument.
2822
2823 * indent.c (compute_motion, Fcompute_motion):
2824 Use window_body_cols instead of window_box_text_cols.
2825
2826 * frame.c (delete_frame): Call delete_all_subwindows with root
2827 window as argument.
2828
2829 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2830
2831 * fns.c (Fputhash): Document return value.
2832
2833 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2834
2835 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2836
2837 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Cons<->int and similar integer overflow fixes (Bug#8794).
2840
2841 Check for overflow when converting integer to cons and back.
2842 * charset.c (Fdefine_charset_internal, Fdecode_char):
2843 Use cons_to_unsigned to catch overflow.
2844 (Fencode_char): Use INTEGER_TO_CONS.
2845 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2846 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2847 * data.c (long_to_cons, cons_to_long): Remove.
2848 (cons_to_unsigned, cons_to_signed): New functions.
2849 These signal an error for invalid or out-of-range values.
2850 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2851 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2852 * font.c (Ffont_variation_glyphs):
2853 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2854 * lisp.h: Include <intprops.h>.
2855 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2856 (cons_to_signed, cons_to_unsigned): New decls.
2857 (long_to_cons, cons_to_long): Remove decls.
2858 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2859 (Fprimitive_undo): Use CONS_TO_INTEGER.
2860 * xfns.c (Fx_window_property): Likewise.
2861 * xselect.c: Include <limits.h>.
2862 (x_own_selection, selection_data_to_lisp_data):
2863 Use INTEGER_TO_CONS.
2864 (x_handle_selection_request, x_handle_selection_clear)
2865 (x_get_foreign_selection, Fx_disown_selection_internal)
2866 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2867 (lisp_data_to_selection_data): Use cons_to_unsigned.
2868 (x_fill_property_data): Use cons_to_signed.
2869 Report values out of range.
2870
2871 Check for buffer and string overflow more precisely.
2872 * buffer.h (BUF_BYTES_MAX): New macro.
2873 * lisp.h (STRING_BYTES_MAX): New macro.
2874 * alloc.c (Fmake_string):
2875 * character.c (string_escape_byte8):
2876 * coding.c (coding_alloc_by_realloc):
2877 * doprnt.c (doprnt):
2878 * editfns.c (Fformat):
2879 * eval.c (verror):
2880 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2881 since they may not be the same number.
2882 * editfns.c (Finsert_char):
2883 * fileio.c (Finsert_file_contents):
2884 Likewise for BUF_BYTES_MAX.
2885
2886 * image.c: Use ptrdiff_t, not int, for sizes.
2887 (slurp_file): Switch from int to ptrdiff_t.
2888 All uses changed.
2889 (slurp_file): Check that file size fits in both size_t (for
2890 malloc) and ptrdiff_t (for sanity and safety).
2891
2892 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2893 if b->modtime has its maximal value.
2894
2895 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2896
2897 Don't assume time_t can fit into int.
2898 * buffer.h (struct buffer.modtime): Now time_t, not int.
2899 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2900 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2901
2902 Minor fixes for signed vs unsigned integers.
2903 * character.h (MAYBE_UNIFY_CHAR):
2904 * charset.c (maybe_unify_char):
2905 * keyboard.c (read_char, reorder_modifiers):
2906 XINT -> XFASTINT, since the integer must be nonnegative.
2907 * ftfont.c (ftfont_spec_pattern):
2908 * keymap.c (access_keymap, silly_event_symbol_error):
2909 XUINT -> XFASTINT, since the integer must be nonnegative.
2910 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2911 since it makes no difference and we prefer signed.
2912 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2913 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2914 nonnegative.
2915
2916 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2917
2918 * window.h (Fwindow_frame): Declare.
2919
2920 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2923 (SPARE_MEMORY): Always define.
2924 (LARGE_REQUEST): Remove.
2925 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2926
2927 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2928
2929 * lisp.h: Move EXFUNS for Fframe_root_window,
2930 Fframe_first_window and Fset_frame_selected_window to window.h.
2931
2932 * window.h: Move EXFUNS for Fframe_root_window,
2933 Fframe_first_window and Fset_frame_selected_window here from
2934 lisp.h.
2935
2936 * frame.c (Fwindow_frame, Fframe_first_window)
2937 (Fframe_root_window, Fframe_selected_window)
2938 (Fset_frame_selected_window): Move to window.c.
2939 (Factive_minibuffer_window): Move to minibuf.c.
2940 (Fother_visible_frames_p): New function.
2941
2942 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2943
2944 * window.c (decode_window, decode_any_window): Move up in code.
2945 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2946 (inhibit_frame_unsplittable): Remove unused variable.
2947 (Fwindow_buffer): Move up and rewrite doc-string.
2948 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2949 (Fwindow_prev): New functions.
2950 (Fwindow_frame): Move here from frame.c. Accept any window as
2951 argument.
2952 (Fframe_root_window, Fframe_first_window)
2953 (Fframe_selected_window): Move here from frame.c. Accept frame
2954 or arbitrary window as argument. Update doc-strings.
2955 (Fminibuffer_window): Move up in code.
2956 (Fwindow_minibuffer_p): Move up in code and simplify.
2957 (Fset_frame_selected_window): Move here from frame.c.
2958 Marginal rewrite.
2959 (Fselected_window, select_window, Fselect_window): Move up in
2960 code. Minor doc-string fixes.
2961
2962 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2965 Do not assume that spare memory exists; that assumption is valid
2966 only if SYSTEM_MALLOC.
2967 (LARGE_REQUEST): New macro, so that the issue of large requests
2968 is separated from the issue of spare memory.
2969
2970 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2971
2972 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2973 format. (Bug#8806)
2974
2975 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2976
2977 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2978 before statements.
2979
2980 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2983
2984 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2985
2986 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2987 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2988
2989 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2990
2991 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2992
2993 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2994
2995 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2996 (x_clipboard_manager_save): Add return value.
2997 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2998 New error handlers.
2999 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3000 Obey Vx_select_enable_clipboard_manager. Catch errors in
3001 x_clipboard_manager_save (Bug#8779).
3002 (Vx_select_enable_clipboard_manager): New variable.
3003 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3004
3005 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3006
3007 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3008
3009 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3010
3011 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3012 in the current matrix if keep_current_p is non-zero.
3013
3014 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3015
3016 * bidi.c (bidi_level_of_next_char): Fix last change.
3017
3018 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3019
3020 Support bidi reordering of text covered by display properties.
3021
3022 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3023 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3024 (bidi_cache_search, bidi_cache_iterator_state)
3025 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3026 (bidi_level_of_next_char, bidi_move_to_visually_next):
3027 Support character positions inside a run of characters covered by a
3028 display string.
3029 (bidi_paragraph_init, bidi_resolve_explicit_1)
3030 (bidi_level_of_next_char): Call bidi_fetch_char and
3031 bidi_fetch_char_advance instead of FETCH_CHAR and
3032 FETCH_CHAR_ADVANCE.
3033 (bidi_init_it): Initialize new members.
3034 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3035 definitions.
3036 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3037 instead of using explicit *_CHAR codes.
3038 (bidi_resolve_explicit, bidi_resolve_weak):
3039 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3040 bidirectional text is supported only in multibyte buffers.
3041 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3042 it to initialize the frame_window_p member of struct bidi_it.
3043 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3044 (bidi_resolve_explicit, bidi_resolve_weak)
3045 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3046 bidi_it->nchars is non-positive.
3047 (bidi_level_of_next_char): Don't try to lookup the cache for the
3048 next/previous character if nothing is cached there yet, or if we
3049 were just reseat()'ed to a new position.
3050
3051 * xdisp.c (set_cursor_from_row): Set start and stop points
3052 according to the row's direction when priming the loop that looks
3053 for the glyph on which to display cursor.
3054 (single_display_spec_intangible_p): Function deleted.
3055 (display_prop_intangible_p): Reimplement to call
3056 handle_display_spec instead of single_display_spec_intangible_p.
3057 Accept 3 additional arguments needed by handle_display_spec.
3058 This fixes incorrect cursor motion across display property with complex
3059 values: lists, `(when COND...)' forms, etc.
3060 (single_display_spec_string_p): Support property values that are
3061 lists with the argument STRING its top-level element.
3062 (display_prop_string_p): Fix the condition for processing a
3063 property that is a list to be consistent with handle_display_spec.
3064 (handle_display_spec): New function, refactored from the
3065 last portion of handle_display_prop.
3066 (compute_display_string_pos): Accept additional argument
3067 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3068 value of a `display' property is a "replacing spec".
3069 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3070 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3071 the display property, but just return a value indicating whether
3072 the display property will replace the characters it covers.
3073 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3074 frame_window_p members of struct bidi_it.
3075 (compute_display_string_pos, compute_display_string_end):
3076 New functions.
3077 (push_it): Accept second argument POSITION, where pop_it should
3078 jump to continue iteration.
3079 (reseat_1): Initialize bidi_it.disp_pos.
3080
3081 * keyboard.c (adjust_point_for_property): Adjust the call to
3082 display_prop_intangible_p to its new signature.
3083
3084 * dispextern.h (struct bidi_it): New member frame_window_p.
3085 (bidi_init_it): Update prototypes.
3086 (display_prop_intangible_p): Update prototype.
3087 (compute_display_string_pos, compute_display_string_end):
3088 Declare prototypes.
3089 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3090 EMACS_INT.
3091
3092 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Malloc failure behavior now depends on size of allocation.
3095 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3096 * lisp.h: Change signatures accordingly.
3097 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3098 All callers changed. (Bug#8762)
3099
3100 * gnutls.c: Use Emacs's memory allocators.
3101 Without this change, the gnutls library would invoke malloc etc.
3102 directly, which causes problems on non-SYNC_INPUT hosts, and which
3103 runs afoul of improving memory_full behavior. (Bug#8761)
3104 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3105 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3106 xfree instead of the default malloc, realloc, free.
3107 (Fgnutls_boot): No need to check for memory allocation failure,
3108 since xmalloc does that for us.
3109
3110 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3111 * category.c (hash_get_category_set):
3112 * ccl.c (ccl_driver):
3113 * charset.c (Fdefine_charset_internal):
3114 * charset.h (struct charset.hash_index):
3115 * composite.c (get_composition_id, gstring_lookup_cache)
3116 (composition_gstring_put_cache):
3117 * composite.h (struct composition.hash_index):
3118 * dispextern.h (struct image.hash):
3119 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3120 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3121 (hashfn_equal, hashfn_user_defined, make_hash_table)
3122 (maybe_resize_hash_table, hash_lookup, hash_put)
3123 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3124 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3125 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3126 * image.c (make_image, search_image_cache, lookup_image)
3127 (xpm_put_color_table_h):
3128 * lisp.h (struct Lisp_Hash_Table):
3129 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3130 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3131 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3132 * alloc.c (allocate_vectorlike):
3133 Check for overflow in vector size calculations.
3134 * ccl.c (ccl_driver):
3135 Check for overflow when converting EMACS_INT to int.
3136 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3137 need to be updated by these changes.
3138 * fns.c (make_hash_table, maybe_resize_hash_table):
3139 Check for integer overflow with large hash tables.
3140 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3141 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3142 (SXHASH_REDUCE): New macro.
3143 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3144 Use it instead of discarding useful hash info with large hash values.
3145 (sxhash_float): New function.
3146 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3147 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3148 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3149 Rewrite to use FIXNUM_BITS, as this simplifies things.
3150 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3151 Adjust signatures to match updated version of code.
3152 (consing_since_gc): Now EMACS_INT, since a single hash table can
3153 use more than INT_MAX bytes.
3154
3155 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3156
3157 Make it possible to build with GCC-4.6+ -O2 -flto.
3158
3159 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3160
3161 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3162
3163 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3164 Call minibuffer-inactive-mode.
3165
3166 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3169 Update dependencies.
3170
3171 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3172
3173 * data.c (init_data): Remove code for UTS, this system is not
3174 supported anymore.
3175
3176 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3177
3178 Don't force ./temacs to start in terminal mode.
3179
3180 * frame.c (make_initial_frame): Initialize faces in all cases, not
3181 only when CANNOT_DUMP is defined.
3182 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3183
3184 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3185
3186 * dispnew.c (add_window_display_history): Use const for the string
3187 pointer. Remove declaration, not needed.
3188
3189 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 Use 'inline', not 'INLINE'.
3192 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3193 * alloc.c, fontset.c (INLINE): Remove.
3194 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3195 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3196 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3197 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3198 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3199
3200 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3201
3202 Make it possible to run ./temacs.
3203
3204 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3205 syms_of_callproc does the same thing. Remove test for
3206 "initialized", do it in the caller.
3207 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3208
3209 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3210
3211 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3212 (read_minibuf): Use get_minibuffer.
3213 (syms_of_minibuf): Use DEFSYM.
3214 (Qmetadata): New var.
3215 * data.c (Qbuffer): Don't make it static.
3216 (syms_of_data): Use DEFSYM.
3217
3218 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3221 (CCL_CODE_MIN): New macro.
3222
3223 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3226
3227 * eval.c (Qdebug): Now static.
3228 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3229 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3230 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3231
3232 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3233
3234 * image.c: Various fixes to ImageMagick code comments.
3235 (Fimagemagick_types): Doc fix.
3236
3237 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3238
3239 Minor fixes prompted by GCC 4.6.0 warnings.
3240
3241 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3242
3243 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3244 (x_clipboard_manager_save_all): Move extern decl to ...
3245 * xterm.h: ... here, so that it can be checked for consistency.
3246
3247 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * xselect.c (x_clipboard_manager_save_frame)
3250 (x_clipboard_manager_save_all): New functions.
3251 (Fx_clipboard_manager_save): Lisp function deleted.
3252
3253 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3254 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3255
3256 * xterm.h: Update prototype.
3257
3258 2011-05-28 William Xu <william.xwl@gmail.com>
3259
3260 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3261 exiting (Bug#8239).
3262
3263 2011-05-28 Jim Meyering <meyering@redhat.com>
3264
3265 Avoid a sign-extension bug in crypto_hash_function.
3266 * fns.c (to_uchar): Define.
3267 (crypto_hash_function): Use it to convert some newly-signed
3268 variables to unsigned, to avoid sign-extension bugs. For example,
3269 without this change, (md5 "truc") would evaluate to
3270 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3271 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3272 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3273
3274 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 Integer overflow fixes.
3277
3278 * dbusbind.c: Serial number integer overflow fixes.
3279 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3280 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3281 to hold a serial number that is too large for a fixnum.
3282 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3283 Check for serial numbers out of range. Decode any serial number
3284 that was so large that it became a float. (Bug#8722)
3285
3286 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3287 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3288 Use XFASTINT rather than XUINT when numbers are nonnegative.
3289 (xd_append_arg, Fdbus_method_return_internal):
3290 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3291 arguments, check that Lisp number is nonnegative, rather than
3292 silently wrapping negative numbers around. (Bug#8722)
3293 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3294 (Bug#8722)
3295
3296 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3297
3298 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3299
3300 ccl: add integer overflow checks
3301 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3302 (IN_INT_RANGE): New macros.
3303 (ccl_driver): Use them to check for integer overflow when
3304 decoding a CCL program. Many of the new checks are whether XINT (x)
3305 fits in int; it doesn't always, on 64-bit hosts. The new version
3306 doesn't catch all possible integer overflows, but it's an
3307 improvement. (Bug#8719)
3308
3309 * alloc.c (make_event_array): Use XINT, not XUINT.
3310 There's no need for unsigned here.
3311
3312 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3313 This follows up to the 2011-05-06 change that substituted uintptr_t
3314 for EMACS_INT. This case wasn't caught back then.
3315
3316 Rework Fformat to avoid integer overflow issues.
3317 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3318 now (part of C89). Include <verify.h>.
3319 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3320 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3321 (Fformat): Avoid the prepass trying to compute sizes; it was only
3322 approximate and thus did not catch overflow reliably. Instead, walk
3323 through the format just once, formatting and computing sizes as we go,
3324 checking for integer overflow at every step, and allocating a larger
3325 buffer as needed. Keep track separately whether the format is
3326 multibyte. Keep only the most-recently calculated precision, rather
3327 than them all. Record whether each argument has been converted to
3328 string. Use EMACS_INT, not int, for byte and char and arg counts.
3329 Support field widths and precisions larger than INT_MAX. Avoid
3330 sprintf's undefined behavior with conversion specifications such as %#d
3331 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3332 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3333 formatting out-of-range floating point numbers with int
3334 formats. (Bug#8668)
3335
3336 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3337
3338 * data.c: Avoid integer truncation in expressions involving floats.
3339 * data.c: Include <intprops.h>.
3340 (arith_driver): When there's an integer overflow in an expression
3341 involving floating point, convert the integers to floating point
3342 so that the resulting value does not suffer from catastrophic
3343 integer truncation. For example, on a 64-bit host (* 4
3344 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3345 Do not rely on undefined behavior after integer overflow.
3346
3347 merge count_size_as_multibyte, parse_str_to_multibyte
3348 * character.c, character.h (count_size_as_multibyte):
3349 Rename from parse_str_to_multibyte; all uses changed.
3350 Check for integer overflow.
3351 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3352 since it's now a duplicate of the other. This is more of
3353 a character than a buffer op, so better that it's in character.c.
3354 * fns.c, print.c: Adjust to above changes.
3355
3356 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3357
3358 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3359
3360 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3363 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3364 (x_clipboard_manager_save): Now static.
3365 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3366
3367 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3368 (crypto_hash_function): Now static.
3369 Fix pointer signedness problems. Avoid unnecessary initializations.
3370
3371 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3372
3373 * termhooks.h (Vselection_alist): Make it terminal-local.
3374
3375 * terminal.c (create_terminal): Initialize it.
3376
3377 * xselect.c: Support for clipboard managers.
3378 (Vselection_alist): Move to termhooks.h as terminal-local var.
3379 (LOCAL_SELECTION): New macro.
3380 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3381 (symbol_to_x_atom): Remove gratuitous arg.
3382 (x_handle_selection_request, lisp_data_to_selection_data)
3383 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3384 (x_own_selection, x_get_local_selection, x_convert_selection):
3385 New arg, specifying work frame. Use terminal-local Vselection_alist.
3386 (some_frame_on_display): Delete unused function.
3387 (Fx_own_selection_internal, Fx_get_selection_internal)
3388 (Fx_disown_selection_internal, Fx_selection_owner_p)
3389 (Fx_selection_exists_p): New optional frame arg.
3390 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3391 (x_handle_selection_clear): Don't treat other terminals with the
3392 same keyboard specially. Use the terminal-local Vselection_alist.
3393 (x_clear_frame_selections): Use Frun_hook_with_args.
3394
3395 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3396
3397 * xterm.h: Add support for those atoms.
3398
3399 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3400
3401 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3402 (converted_selections, conversion_fail_tag): New global variables.
3403 (x_selection_request_lisp_error): Free the above.
3404 (x_get_local_selection): Remove unnecessary code.
3405 (x_reply_selection_request): Args changed; handle arbitrary array
3406 of converted selections stored in converted_selections.
3407 Separate the XChangeProperty and SelectionNotify steps.
3408 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3409 (x_convert_selection): New function.
3410 (x_handle_selection_event): Simplify.
3411 (x_get_foreign_selection): Don't ignore incoming requests while
3412 waiting for an answer; this will fail when we implement
3413 SAVE_TARGETS, and seems unnecessary anyway.
3414 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3415 (Vx_sent_selection_functions): Doc fix.
3416
3417 2011-05-26 Leo Liu <sdl.web@gmail.com>
3418
3419 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3420
3421 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3422
3423 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3424
3425 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3426 for fringe update if it has periodic bitmap.
3427 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3428 and fringe_bitmap_periodic_p.
3429
3430 * fringe.c (get_fringe_bitmap_data): New function.
3431 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3432 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3433 row. Mark glyph row for fringe update if periodicity changed.
3434
3435 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3436 for fringe update unless it has periodic bitmap.
3437
3438 2011-05-25 Kenichi Handa <handa@m17n.org>
3439
3440 * xdisp.c (get_next_display_element): Set correct it->face_id for
3441 a static composition.
3442
3443 2011-05-24 Leo Liu <sdl.web@gmail.com>
3444
3445 * deps.mk (fns.o):
3446 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3447
3448 * fns.c (crypto_hash_function, Fsha1): New function.
3449 (Fmd5): Use crypto_hash_function.
3450 (syms_of_fns): Add Ssha1.
3451
3452 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3453
3454 * gnutls.c: Remove unused macros.
3455 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3456 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3457 Remove macros that are defined and never used.
3458 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3459
3460 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3461
3462 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3463 (Fx_get_selection_internal): Minor cleanup.
3464 (Fx_own_selection_internal): Rename arguments for consistency with
3465 select.el.
3466
3467 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3468
3469 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3470
3471 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3474
3475 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3476
3477 * dispnew.c (scrolling_window): Don't exclude the case that the
3478 last enabled row in the desired matrix touches the bottom boundary.
3479
3480 2011-05-21 Glenn Morris <rgm@gnu.org>
3481
3482 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3483 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3484 and add some more files.
3485
3486 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3487
3488 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3489 report_file_error introduced by the change from 2011-05-07.
3490
3491 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3492
3493 * systime.h (Time): Define only if emacs is defined.
3494 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3495 where the include path doesn't have X11/X.h by default. See
3496 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3497
3498 2011-05-20 Kenichi Handa <handa@m17n.org>
3499
3500 * composite.c (find_automatic_composition): Fix previous change.
3501
3502 2011-05-20 Glenn Morris <rgm@gnu.org>
3503
3504 * lisp.mk: New file, split from Makefile.in.
3505 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3506 (shortlisp): Remove.
3507 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3508
3509 2011-05-19 Glenn Morris <rgm@gnu.org>
3510
3511 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3512 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3513 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3514 (lisp): Set the order to that of loadup.el.
3515 (shortlisp): Make it a copy of $lisp.
3516 (SOME_MACHINE_LISP): Remove.
3517 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3518 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3519
3520 2011-05-18 Kenichi Handa <handa@m17n.org>
3521
3522 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3523 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3524 (find_automatic_composition): Mostly rewrite for efficiency.
3525
3526 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * makefile.w32-in: Update dependencies.
3529
3530 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3531
3532 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3533 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3534
3535 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 Fix some integer overflow issues, such as string length overflow.
3538
3539 * insdel.c (count_size_as_multibyte): Check for string overflow.
3540
3541 * character.c (lisp_string_width): Check for string overflow.
3542 Use EMACS_INT, not int, for string indexes and lengths; in
3543 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3544 the resulting string length overflows an EMACS_INT; instead,
3545 report a string overflow if no precision given. When checking for
3546 precision exhaustion, use a check that cannot possibly have
3547 integer overflow. (Bug#8675)
3548 * character.h (lisp_string_width): Adjust to new signature.
3549
3550 * alloc.c (string_overflow): New function.
3551 (Fmake_string): Use it. This doesn't change behavior, but saves
3552 a few bytes and will simplify future changes.
3553 * character.c (string_escape_byte8): Likewise.
3554 * lisp.h (string_overflow): New decl.
3555
3556 Fixups, following up to the user-interface timestamp change.
3557 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3558 for UI timestamps, instead of unsigned long.
3559 * msdos.c (mouse_get_pos): Likewise.
3560 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3561 * w32gui.h (Time): Define by including "systime.h" rather than by
3562 declaring it ourselves. (Bug#8664)
3563
3564 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3565 * image.c (clear_image_cache): Likewise.
3566
3567 * term.c (term_mouse_position): Don't assume time_t wraparound.
3568
3569 Be more systematic about user-interface timestamps.
3570 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3571 and sometimes 'EMACS_UINT', to represent these timestamps.
3572 This change causes it to use 'Time' uniformly, as that's what X uses.
3573 This makes the code easier to follow, and makes it easier to catch
3574 integer overflow bugs such as Bug#8664.
3575 * frame.c (Fmouse_position, Fmouse_pixel_position):
3576 Use Time, not unsigned long, for user-interface timestamps.
3577 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3578 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3579 * keyboard.h (last_event_timestamp): Likewise.
3580 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3581 * menu.h (xmenu_show): Likewise.
3582 * term.c (term_mouse_position): Likewise.
3583 * termhooks.h (struct input_event.timestamp): Likewise.
3584 (struct terminal.mouse_position_hook): Likewise.
3585 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3586 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3587 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3588 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3589 what it was before.
3590 * menu.h, termhooks.h: Include "systime.h", for Time.
3591
3592 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3593 Don't assume that the difference between two unsigned long values
3594 can fit into an integer. At this point, we know button_down_time
3595 <= event->timestamp, so the difference must be nonnegative, so
3596 there's no need to cast the result if double-click-time is
3597 nonnegative, as it should be; check that it's nonnegative, just in
3598 case. This bug is triggered when events are more than 2**31 ms
3599 apart (about 25 days). (Bug#8664)
3600
3601 * xselect.c (last_event_timestamp): Remove duplicate decl.
3602 (x_own_selection): Remove needless cast to unsigned long.
3603
3604 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3605 that always fit in int. Use a sentinel instead of a counter, to
3606 avoid a temp and to allay GCC's concerns about possible int overflow.
3607 * frame.h (struct frame): Use int for menu_bar_items_used
3608 instead of EMACS_INT, since it always fits in int.
3609
3610 * menu.c (grow_menu_items): Check for int overflow.
3611
3612 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3613
3614 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3615 Before, the code was not consistent. These values cannot exceed
3616 2**31 - 1 so there's no need to make them unsigned.
3617 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3618 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3619 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3620 as modifiers.
3621 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3622
3623 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3624 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3625 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3626 presumably because the widths might not match.
3627
3628 * window.c (size_window): Avoid needless test at loop start.
3629
3630 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3631
3632 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3633
3634 2011-05-12 Drew Adams <drew.adams@oracle.com>
3635
3636 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3637
3638 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3639
3640 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3641 `width' to `bar_area_x' and `bar_area_width', respectively.
3642 (x_scroll_run): Take account of fringe background extension.
3643
3644 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3645 Rename local vars `left' and `width' to `bar_area_x' and
3646 `bar_area_width', respectively.
3647 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3648 background extension.
3649
3650 2011-05-10 Jim Meyering <meyering@redhat.com>
3651
3652 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3653
3654 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3655
3656 * image.c (Finit_image_library): Return t for built-in image types,
3657 like pbm and xbm. (Bug#8640)
3658
3659 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3660
3661 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3662
3663 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3664
3665 * w32console.c (Fset_screen_color): Doc fix.
3666 (Fget_screen_color): New function.
3667 (syms_of_ntterm): Defsubr it.
3668
3669 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3670 unlink the temporary file if Fcall_process didn't create it in the
3671 first place.
3672 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3673 child process will be redirected to a file specified with `:file'.
3674 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3675 cue to call_process_cleanup not to close that handle.
3676
3677 2011-05-07 Ben Key <bkey76@gmail.com>
3678
3679 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3680 one of two shell specific rules, either bootstrap-temacs-CMD or
3681 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3682 to the previous implementation of the bootstrap-temacs rule.
3683 The bootstrap-temacs-CMD rule is similar to the previous
3684 implementation of the bootstrap-temacs rule except that it
3685 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3686 variable.
3687
3688 These changes, along with some changes to nt/configure.bat,
3689 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3690 earlier fix to add support for --cflags and --ldflags options
3691 that include quotes so that it works whether make uses cmd or
3692 sh as the shell.
3693
3694 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3695
3696 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3697 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3698 is a constant.
3699 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3700 a string. Handle both cases.
3701 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3702 (Fdbus_register_method): Use Qinvalid_function.
3703
3704 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * makefile.w32-in: Update dependencies.
3707 (LISP_H): Add inttypes.h and stdin.h.
3708 (PROCESS_H): Add unistd.h.
3709
3710 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3711
3712 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3713 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3714
3715 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3718
3719 * term.c (vfatal): Remove stray call to va_end.
3720 It's not needed and the C Standard doesn't allow it here anyway.
3721
3722 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3723 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3724
3725 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3726 bytes.
3727
3728 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3729
3730 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3731
3732 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3733
3734 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3735
3736 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3737
3738 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3739 * charset.c (Fdefine_charset_internal): Don't initialize
3740 charset.code_space[15]. The value was garbage, on hosts with
3741 32-bit int (Bug#8600).
3742
3743 * lread.c (read_integer): Be more consistent with string-to-number.
3744 Use string_to_number to do the actual conversion; this avoids
3745 rounding errors and fixes some other screwups. Without this fix,
3746 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3747 (digit_to_number): Move earlier, for benefit of read_integer.
3748 Return -1 if the digit is out of range for the base, -2 if it is
3749 not a digit in any supported base. (Bug#8602)
3750
3751 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3752
3753 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3754 to match comment at start of function. This also removes a
3755 GCC warning about overflow in a 32+64-bit port.
3756
3757 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3758
3759 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3760 Reported by Stefan Monnier in
3761 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3762 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3763 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3764
3765 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3766 (EMACS_UINTPTR): Likewise, with uintptr_t.
3767
3768 * lisp.h: Prefer 64-bit EMACS_INT if available.
3769 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3770 on 32-bit hosts that have 64-bit int, so that they can access
3771 large files.
3772 However, temporarily disable this change unless the temporary
3773 symbol WIDE_EMACS_INT is defined.
3774
3775 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3776
3777 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3778 This removes an assumption that EMACS_INT and long are the same
3779 width as pointers. The assumption is true for Emacs porting targets
3780 now, but we want to make other targets possible.
3781 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3782 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3783 In the rest of the code, change types of integers that hold casted
3784 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3785 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3786 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3787 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3788 No need to cast type when ORing.
3789 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3790 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3791 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3792 assume EMACS_INT is the same width as char *.
3793 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3794 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3795 Remove no-longer-needed casts.
3796 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3797 (xg_tool_bar_help_callback, xg_make_tool_item):
3798 Use EMACS_INTPTR to hold an integer
3799 that will be cast to void *; this can avoid a GCC warning
3800 if EMACS_INT is not the same width as void *.
3801 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3802 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3803 (current_message_1, set_message_1):
3804 Use a local to convert to proper width without a cast.
3805 * xmenu.c (dialog_selection_callback): Likewise.
3806
3807 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3808 Also, don't assume VALBITS / RAND_BITS is less than 5,
3809 and don't rely on undefined behavior when shifting a 1 left into
3810 the sign bit.
3811 * lisp.h (get_random): Change signature to match.
3812
3813 * lread.c (hash_string): Use size_t, not int, for hash computation.
3814 Normally we prefer signed values; but hashing is special, because
3815 it's better to use unsigned division on hash table sizes so that
3816 the remainder is nonnegative. Also, size_t is the natural width
3817 for hashing into memory. The previous code used 'int', which doesn't
3818 retain enough info to hash well into very large tables.
3819 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3820
3821 * dbusbind.c: Don't possibly lose pointer info when converting.
3822 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3823 Use XPNTR rather than XHASH, so that the high-order bits of
3824 the pointer aren't lost when converting through void *.
3825
3826 * eval.c (Fautoload): Don't double-shift a pointer.
3827
3828 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3829
3830 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3831
3832 * gnutls.c (DEF_GNUTLS_FN):
3833 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3834
3835 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3836
3837 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3838 marker. (Bug#8610)
3839
3840 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3841
3842 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3843 New version that can reserve upto 2GB of heap space.
3844
3845 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3846
3847 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3848
3849 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3850
3851 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3852 `gnutls_certificate_set_x509_key_file'.
3853
3854 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3855
3856 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3857 Update dependencies.
3858
3859 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3862 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3863 Remove unused parameter `fildes'.
3864 * process.c (read_process_output, send_process): Don't pass it.
3865
3866 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3867
3868 Fix previous change: the library cache is defined in w32.c.
3869 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3870 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3871
3872 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3873
3874 Implement dynamic loading of GnuTLS on Windows.
3875
3876 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3877 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3878 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3879 Declare.
3880
3881 * gnutls.c (Qgnutls_dll): Define.
3882 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3883 (gnutls_*): Declare function pointers.
3884 (init_gnutls_functions): New function to initialize function pointers.
3885 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3886 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3887 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3888 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3889 (emacs_gnutls_write, emacs_gnutls_read)
3890 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3891 (Fgnutls_available_p): New function.
3892 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3893 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3894 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3895
3896 * image.c: Include w32.h.
3897 (Vimage_type_cache): Delete.
3898 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3899 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3900 (w32_delayed_load): Move to w32.c.
3901
3902 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3903
3904 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3905 (w32_delayed_load): Move from image.c. When loading a library, record
3906 its filename in the :loaded-from property of the library id.
3907 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3908 Initialize and staticpro them.
3909 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3910
3911 * process.c: Include lisp.h before w32.h, not after.
3912 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3913 instead of gnutls_record_check_pending.
3914
3915 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3916
3917 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3918
3919 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3920 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3921 as passed in.
3922
3923 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3924
3925 * xterm.c (x_set_frame_alpha): Do not set property on anything
3926 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3927
3928 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3929
3930 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3931
3932 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3935 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3936 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3937 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3938 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3939 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3940 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3941 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3942 (Qgnutls_bootprop_callbacks_verify): Make static.
3943
3944 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3945
3946 * callproc.c: Indentation fixup.
3947
3948 * sysdep.c (wait_for_termination_1): Make static.
3949 (wait_for_termination, interruptible_wait_for_termination):
3950 Move after wait_for_termination_1.
3951
3952 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3953
3954 * sysdep.c (interruptible_wait_for_termination): New function
3955 which is like wait_for_termination, but allows keyboard
3956 interruptions.
3957
3958 * callproc.c (Fcall_process): Add (:file "file") as an option for
3959 the STDOUT buffer.
3960 (Fcall_process_region): Ditto.
3961
3962 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3963
3964 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3965 rather than `XVECTOR (FOO)->size'.
3966
3967 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3968 inttypes.h, as a gnulib replacement is used if it not available in
3969 system headers.
3970
3971 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3972
3973 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3974 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3975 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3976
3977 * coding.c (coding_alloc_by_realloc): Error out if destination
3978 will grow beyond MOST_POSITIVE_FIXNUM.
3979 (decode_coding_emacs_mule): Abort if there isn't enough place in
3980 charbuf for the composition carryover bytes. Reserve an extra
3981 space for up to 2 characters produced in a loop.
3982 (decode_coding_iso_2022): Abort if there isn't enough place in
3983 charbuf for the composition carryover bytes.
3984
3985 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3986
3987 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3988 aborting when %lld or %lll format is passed.
3989 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3990 %llo or %llx format is passed. (Bug#8545)
3991
3992 * window.c (window_scroll_line_based): Use a marker instead of
3993 simple variables to record original value of point. (Bug#7952)
3994
3995 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3996 produced by %s or %c overflows available buffer space. (Bug#8545)
3997
3998 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3999
4000 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4001 (SIZE_MAX): Move defn after all includes, as they might #define it.
4002
4003 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4004
4005 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4006
4007 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4008
4009 * keyboard.c (Qdelayed_warnings_hook): Define.
4010 (command_loop_1): Run `delayed-warnings-hook'
4011 if Vdelayed_warnings_list is non-nil.
4012 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4013 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4014
4015 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4016
4017 * doprnt.c (doprnt): Don't return value smaller than the buffer
4018 size if the message was truncated. (Bug#8545).
4019
4020 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4021
4022 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4023 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4024
4025 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4028
4029 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4030
4031 * makefile.w32-in: Update dependencies.
4032
4033 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4034
4035 Improve `doprnt' and its usage. (Bug#8545)
4036 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4037 `format_end'. Remove support for %l as a conversion specifier.
4038 Don't use xrealloc. Improve diagnostics when the %l size modifier
4039 is used. Update the commentary.
4040
4041 * eval.c (verror): Simplify calculation of size_t.
4042
4043 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4044 messages.
4045
4046 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4047
4048 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4049 change.
4050
4051 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4054 This makes this file independent of the recent pseudovector change.
4055
4056 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4059
4060 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4061 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4062 Remove unused local.
4063 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4064
4065 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4066 GCC 4.6.0 optimizes based on type-based alias analysis.
4067 For example, if b is of type struct buffer * and v of type struct
4068 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4069 != &v->size, and therefore "v->size = 1; b->size = 2; return
4070 v->size;" must therefore return 1. This assumption is incorrect
4071 for Emacs, since it type-puns struct Lisp_Vector * with many other
4072 types. To fix this problem, this patch adds a new type struct
4073 vectorlike_header that documents the constraints on layout of vectors
4074 and pseudovectors, and helps optimizing compilers not get fooled
4075 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4076 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4077 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4078 the size member.
4079 (XSETPVECTYPE): Rewrite in terms of new macro.
4080 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4081 This is a bit clearer, and further avoids the possibility of
4082 undesirable aliasing.
4083 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4084 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4085 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4086 since Lisp_Subr is a special case (no "next" field).
4087 (ASIZE): Now uses header.size rather than size.
4088 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4089 to avoid the hassle of writing XVECTOR (foo)->header.size.
4090 (struct vectorlike_header): New type.
4091 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4092 object, to help avoid aliasing.
4093 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4094 (SUBRP): Likewise, since Lisp_Subr is a special case.
4095 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4096 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4097 (struct Lisp_Hash_Table): Combine first two members into a single
4098 struct vectorlike_header member. All uses of "size" and "next" members
4099 changed to be "header.size" and "header.next".
4100 * buffer.h (struct buffer): Likewise.
4101 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4102 * frame.h (struct frame): Likewise.
4103 * process.h (struct Lisp_Process): Likewise.
4104 * termhooks.h (struct terminal): Likewise.
4105 * window.c (struct save_window_data, struct saved_window): Likewise.
4106 * window.h (struct window): Likewise.
4107 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4108 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4109 * buffer.c (init_buffer_once): Likewise.
4110 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4111 special case.
4112 * process.c (Fformat_network_address): Use local var for size,
4113 for brevity.
4114
4115 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4116
4117 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4118 * data.c (atof): Remove decl; no longer used or needed.
4119 (digit_to_number): Move to lread.c.
4120 (Fstring_to_number): Use new string_to_number function, to be
4121 consistent with how the Lisp reader treats infinities and NaNs.
4122 Do not assume that floating-point numbers represent EMACS_INT
4123 without losing information; this is not true on most 64-bit hosts.
4124 Avoid double-rounding errors, by insisting on integers when
4125 parsing non-base-10 numbers, as the documentation specifies.
4126 * lisp.h (string_to_number): New decl, replacing ...
4127 (isfloat_string): Remove.
4128 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4129 (read1): Do not accept +. and -. as integers; this
4130 appears to have been a coding error. Similarly, do not accept
4131 strings like +-1e0 as floating point numbers. Do not report
4132 overflow for integer overflows unless the base is not 10 which
4133 means we have no simple and reliable way to continue.
4134 Break out the floating-point parsing into a new
4135 function string_to_number, so that Fstring_to_number parses
4136 floating point numbers consistently with the Lisp reader.
4137 (digit_to_number): Move here from data.c. Make it static inline.
4138 (E_CHAR, EXP_INT): Remove, replacing with ...
4139 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4140 (string_to_number): New function, replacing isfloat_string.
4141 This function checks for valid syntax and produces the resulting
4142 Lisp float number too. Rework it so that string-to-number
4143 no longer mishandles examples like "1.0e+". Use strtoumax,
4144 so that overflow for non-base-10 numbers is reported only when
4145 there's no portable and simple way to convert to floating point.
4146
4147 * textprop.c (set_text_properties_1): Rewrite for clarity,
4148 and to avoid GCC warning about integer overflow.
4149
4150 * intervals.h (struct interval): Use EMACS_INT for members
4151 where EMACS_UINT might cause problems. See
4152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4153 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4154 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4155 All uses changed.
4156 (offset_intervals): Tell GCC not to worry about length overflow
4157 when negating a negative length.
4158
4159 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4160 (overrun_check_free): Likewise.
4161
4162 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4163 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4164 word size.
4165
4166 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4167 (gnutls_make_error): Rename local to avoid shadowing.
4168 (gnutls_emacs_global_deinit): ifdef out; not used.
4169 (Fgnutls_boot): Use const for pointer to readonly storage.
4170 Comment out unused local. Fix pointer signedness problems.
4171
4172 * lread.c (openp): Don't stuff size_t into an 'int'.
4173 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4174 about possible signed overflow.
4175
4176 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4177 (GDK_KEY_g): Don't define if already defined.
4178 (xg_prepare_tooltip): Avoid pointer signedness problem.
4179 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4180
4181 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4182 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4183
4184 * xfns.c (Fx_window_property): Simplify a bit,
4185 to make a bit faster and to avoid GCC 4.6.0 warning.
4186 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4187
4188 * fns.c (internal_equal): Don't assume size_t fits in int.
4189
4190 * alloc.c (compact_small_strings): Tighten assertion a little.
4191
4192 Replace pEd with more-general pI, and fix some printf arg casts.
4193 * lisp.h (pI): New macro, generalizing old pEd macro to other
4194 conversion specifiers. For example, use "...%"pI"d..." rather
4195 than "...%"pEd"...".
4196 (pEd): Remove. All uses replaced with similar uses of pI.
4197 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4198 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4199 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4200 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4201 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4202 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4203 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4204 64-bit hosts.
4205 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4206 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4207 * print.c (safe_debug_print, print_object): Likewise.
4208 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4209 to int.
4210 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4211 avoiding the 0 flag, which is not portable.
4212 * process.c (Fmake_network_process): Use pI to avoid cast.
4213 * region-cache.c (pp_cache): Likewise.
4214 * xdisp.c (decode_mode_spec): Likewise.
4215 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4216 behavior on 64-bit hosts with printf arg.
4217 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4218 (x_stop_queuing_selection_requests): Likewise.
4219 (x_get_window_property): Don't truncate byte count to an 'int'
4220 when tracing.
4221
4222 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4223 here, since it parses constructs like leading '-' and spaces,
4224 which are not wanted; and it overflows with large numbers.
4225 Instead, simply match F[0-9]+, which is what is wanted anyway.
4226
4227 * alloc.c: Remove unportable assumptions about struct layout.
4228 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4229 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4230 (allocate_vectorlike, make_pure_vector): Use the new macros,
4231 plus offsetof, to remove unportable assumptions about struct layout.
4232 These assumptions hold on all porting targets that I know of, but
4233 they are not guaranteed, they're easy to remove, and removing them
4234 makes further changes easier.
4235
4236 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4237 This doesn't fix a bug but makes the code clearer.
4238 (string_overrun_cookie): Now const. Use initializers that
4239 don't formally overflow signed char, to avoid warnings.
4240 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4241 can cause Emacs to crash when string overrun checking is enabled.
4242 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4243 multiple of sizeof (EMACS_INT); it need not be, if
4244 alignof(EMACS_INT) < sizeof (EMACS_INT).
4245 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4246
4247 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4250
4251 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4252
4253 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4254 supposed to be handshaking. (Bug#8556)
4255 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4256
4257 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4258
4259 * lisp.h (Qdebug): List symbol.
4260 * eval.c (Qdebug): Restore global linkage.
4261 * keyboard.c (debug-on-event): New variable.
4262 (handle_user_signal): Break into debugger when debug-on-event
4263 matches the current signal symbol.
4264
4265 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4266
4267 * alloc.c (check_sblock, check_string_bytes)
4268 (check_string_free_list): Convert to standard C.
4269
4270 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4271
4272 * w32.c (emacs_gnutls_push): Fix typo.
4273
4274 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4275
4276 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4277 "cast to pointer from integer of different size".
4278
4279 Improve doprnt and its use in verror. (Bug#8545)
4280 * doprnt.c (doprnt): Document the set of format control sequences
4281 supported by the function. Use SAFE_ALLOCA instead of always
4282 using `alloca'.
4283
4284 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4285 is one byte too soon. Don't use xrealloc; instead xfree and
4286 xmalloc anew.
4287
4288 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4289
4290 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4291 callbacks stage.
4292
4293 * gnutls.c: Renamed global_initialized to
4294 gnutls_global_initialized. Added internals for the
4295 :verify-hostname-error, :verify-error, and :verify-flags
4296 parameters of `gnutls-boot' and documented those parameters in the
4297 docstring. Start callback support.
4298 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4299 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4300 on error. Return error code.
4301 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4302 (emacs_gnutls_read): Likewise.
4303 (Fgnutls_boot): Return handshake error code.
4304 (emacs_gnutls_handle_error): New function.
4305 (wsaerror_to_errno): Likewise.
4306
4307 * w32.h (emacs_gnutls_pull): Add prototype.
4308 (emacs_gnutls_push): Likewise.
4309
4310 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4311 (emacs_gnutls_push): Likewise.
4312
4313 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4314
4315 * process.c (wait_reading_process_output): Check if GnuTLS
4316 buffered some data internally if no FDs are set for TLS
4317 connections.
4318
4319 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4320 (LIBS): Link to USER_LIBS.
4321 ($(BLD)/gnutls.$(0)): New target.
4322
4323 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4324
4325 * xdisp.c (handle_single_display_spec): Rename the
4326 display_replaced_before_p argument into display_replaced_p, to
4327 make it consistent with the commentary. Fix typos in the
4328 commentary.
4329
4330 * textprop.c (syms_of_textprop): Remove dead code.
4331 (copy_text_properties): Delete obsolete commentary about an
4332 interface that was deleted long ago. Fix typos in the description
4333 of arguments.
4334
4335 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4336 to changes in oldXMenu/XMenu.h from 2011-04-16.
4337 <menu_help_message, prev_menu_help_message>: Constify.
4338 (IT_menu_make_room): menu->help_text is now `const char **';
4339 adjust.
4340
4341 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4342 to changes in oldXMenu/XMenu.h from 2011-04-16.
4343 (struct XMenu): Declare `help_text' `const char **'.
4344
4345 * xfaces.c <Qunspecified>: Make extern again.
4346
4347 * syntax.c: Include sys/types.h before including regex.h, as
4348 required by Posix.
4349
4350 * doc.c (get_doc_string): Improve the format passed to `error'.
4351
4352 * doprnt.c (doprnt): Improve commentary.
4353
4354 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4355
4356 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4357 them with etags.
4358
4359 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4360 changes in globals.h immediately force recompilation.
4361 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4362 $(CURDIR)/s/ms-w32.h.
4363 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4364
4365 * character.c (Fchar_direction): Function deleted.
4366 (syms_of_character): Don't defsubr it.
4367 <char-direction-table>: Deleted.
4368
4369 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4370
4371 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4372 * doprnt.c: Include limits.h.
4373 (SIZE_MAX): New macro.
4374 (doprnt): Return a size_t value. 2nd arg is now size_t.
4375 Many local variables are now size_t instead of int or unsigned.
4376 Improve overflow protection. Support `l' modifier for integer
4377 conversions. Support %l conversion. Don't assume an EMACS_INT
4378 argument for integer conversions and for %c.
4379
4380 * lisp.h (doprnt): Restore prototype.
4381
4382 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4383 $(SRC)/character.h.
4384
4385 * Makefile.in (base_obj): Add back doprnt.o.
4386
4387 * deps.mk (doprnt.o): Add back prerequisites.
4388 (callint.o): Depend on character.h.
4389
4390 * eval.c (internal_lisp_condition_case): Include the handler
4391 representation in the error message.
4392 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4393 when breaking from the loop.
4394
4395 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4396
4397 * callint.c (Fcall_interactively): When displaying error message
4398 about invalid control letter, pass the character's codepoint, not
4399 a pointer to its multibyte form. Improve display of the character
4400 in octal and display also its hex code.
4401
4402 * character.c (char_string): Use %x to display the (unsigned)
4403 codepoint of an invalid character, to avoid displaying a bogus
4404 negative value.
4405
4406 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4407 `error', not SYMBOL_NAME itself.
4408
4409 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4410 character arguments to `error'.
4411
4412 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4413 to `error' in error message about FINAL_CHAR argument. Make sure
4414 FINAL_CHAR is a character, and use %c when it is passed as
4415 argument to `error'.
4416
4417 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4418
4419 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4420
4421 * w32.c: Include <time.h>.
4422 (sys_localtime): New function.
4423
4424 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4425
4426 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4427
4428 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4429
4430 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4431
4432 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4433 zombies (Bug#8467).
4434
4435 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4436
4437 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4438 gl_state.e_property when gl_state.object is Qt.
4439
4440 * insdel.c (make_gap_larger): Remove limitation of buffer size
4441 to <= INT_MAX.
4442
4443 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4444
4445 * xdisp.c (lookup_glyphless_char_display)
4446 (produce_glyphless_glyph): Handle cons cell entry in
4447 glyphless-char-display.
4448 (Vglyphless_char_display): Document it.
4449
4450 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4451 glyphless-char-display.
4452
4453 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4456
4457 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4458
4459 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4460 definition for no-X builds.
4461
4462 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 Static checks with GCC 4.6.0 and non-default toolkits.
4465
4466 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4467
4468 * process.c (keyboard_bit_set): Define only if SIGIO.
4469 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4470 (send_process): Repair possible setjmp clobbering.
4471
4472 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4473
4474 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4475
4476 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4477
4478 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4479 Define only if needed.
4480
4481 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4482 by pacifying GCC about it. Maybe it's time to retire it?
4483 * xfaces.c (USG, __TIMEVAL__): Likewise.
4484
4485 * dispextern.h (struct redisplay_interface): Rename param
4486 to avoid shadowing.
4487 * termhooks.h (struct terminal): Likewise.
4488 * xterm.c (xembed_send_message): Likewise.
4489
4490 * insdel.c (make_gap_smaller): Define only if
4491 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4492
4493 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4494 it.
4495
4496 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4497 so that we aren't warned about unused symbols.
4498
4499 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4500
4501 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4502
4503 * xfns.c (x_real_positions): Mark locals as initialized.
4504
4505 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4506
4507 * xterm.c: Fix problems found by static analysis with other toolkits.
4508 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4509 (x_dispatch_event): Declare static if USE_GTK, and
4510 define if USE_GTK || USE_X_TOOLKIT.
4511 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4512 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4513 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4514 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4515
4516 * xmenu.c (menu_help_callback): Pointer type fixes.
4517 Use const pointers when pointing at readonly data. Avoid pointer
4518 signedness clashes.
4519 (FALSE): Remove unused macro.
4520 (update_frame_menubar): Remove unused decl.
4521
4522 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4523
4524 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4525 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4526 (single_menu_item): Rename local to avoid shadowing.
4527
4528 * keyboard.c (make_lispy_event): Remove unused local var.
4529
4530 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4531 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4532
4533 * bitmaps: Change bitmaps from unsigned char back to the X11
4534 compatible char. Avoid the old compiler warnings about
4535 out-of-range initializers by using, for example, '\xab' rather
4536 than 0xab.
4537
4538 * xgselect.c (xgselect_initialize): Check vs interface
4539 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4540
4541 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4542
4543 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4544 to read-only memory.
4545
4546 * fns.c (vector): Remove; this old hack is no longer needed.
4547
4548 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4549 Remove unused var.
4550 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4551
4552 * xrdb.c (x_load_resources): Omit unused local.
4553
4554 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4555 (x_window): Rename locals to avoid shadowing.
4556 (USG): Use the kludged USG macro, to pacify gcc.
4557
4558 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4559 (x_term_init): Remove local to avoid shadowing.
4560
4561 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4562
4563 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4564 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4565
4566 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4567
4568 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4569
4570 Fix regex.c, syntax.c and friends for buffers > 2GB.
4571 * syntax.h (struct gl_state_s): Declare character position members
4572 EMACS_INT.
4573
4574 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4575
4576 * textprop.c (verify_interval_modification, interval_of):
4577 Declare arguments EMACS_INT.
4578
4579 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4580 EMACS_INT.
4581
4582 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4583
4584 * indent.c (Fvertical_motion): Local variable it_start is now
4585 EMACS_INT.
4586
4587 * regex.c (re_match, re_match_2, re_match_2_internal)
4588 (bcmp_translate, regcomp, regexec, print_double_string)
4589 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4590 (re_compile_pattern, re_exec): Declare arguments and local
4591 variables `size_t' and `ssize_t' and return values `regoff_t', as
4592 appropriate.
4593 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4594 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4595 <compile_stack_type>: `size' and `avail' are now `size_t'.
4596
4597 * regex.h <regoff_t>: Use ssize_t, not int.
4598 (re_search, re_search_2, re_match, re_match_2): Arguments that
4599 specify buffer/string position and length are now ssize_t and
4600 size_t. Return type is regoff_t.
4601
4602 2011-04-16 Ben Key <bkey76@gmail.com>
4603
4604 * nsfont.m: Fixed bugs in ns_get_family and
4605 ns_descriptor_to_entity that were caused by using free to
4606 deallocate memory blocks that were allocated by xmalloc (via
4607 xstrdup). This caused Emacs to crash when compiled with
4608 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4609 --enable-checking=xmallocoverrun). xfree is now used to
4610 deallocate these memory blocks.
4611
4612 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4613
4614 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4615
4616 emacs_write: Accept and return EMACS_INT for sizes.
4617 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4618 et seq.
4619 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4620 Accept and return EMACS_INT.
4621 (emacs_gnutls_write): Return the number of bytes written on
4622 partial writes.
4623 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4624 (emacs_read, emacs_write): Remove check for negative size, as the
4625 Emacs source code has been audited now.
4626 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4627 (emacs_read, emacs_write): Use it.
4628 * process.c (send_process): Adjust to the new signatures of
4629 emacs_write and emacs_gnutls_write. Do not attempt to store
4630 a byte offset into an 'int'; it might overflow.
4631 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4632
4633 * sound.c: Don't assume sizes fit in 'int'.
4634 (struct sound_device.period_size, alsa_period_size):
4635 Return EMACS_INT, not int.
4636 (struct sound_device.write, vox_write, alsa_write):
4637 Accept EMACS_INT, not int.
4638 (wav_play, au_play): Use EMACS_INT to store sizes and to
4639 record read return values.
4640
4641 2011-04-15 Ben Key <bkey76@gmail.com>
4642
4643 * keyboard.c (Qundefined): Don't declare static since it is used
4644 in nsfns.m.
4645 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4646 static since they are used in nsfont.m.
4647
4648 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4649
4650 * process.c (Qprocessp): Don't declare static.
4651 * lisp.h (Qprocessp): Declare again.
4652
4653 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4654
4655 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4656
4657 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4658
4659 Improve C-level modularity by making more things 'static'.
4660
4661 Don't publish debugger-only interfaces to other modules.
4662 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4663 (verify_bytepos, count_markers): Move decls to the only modules
4664 that need them.
4665 * region-cache.h (pp_cache): Likewise.
4666 * window.h (check_all_windows): Likewise.
4667 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4668
4669 * sysdep.c (croak): Now static, if
4670 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4671 * syssignal.h (croak): Declare only if not static.
4672
4673 * alloc.c (refill_memory_reserve): Now static if
4674 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4675 * lisp.h (refill_memory_reserve): Declare only if not static.
4676
4677 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4678 Define only if USE_LUCID.
4679
4680 * xrdb.c (x_customization_string, x_rm_string): Now static.
4681
4682 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4683 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4684
4685 * xdisp.c (draw_row_with_mouse_face): Now static.
4686 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4687
4688 * window.h (check_all_windows): Mark externally visible.
4689
4690 * window.c (window_deletion_count): Now static.
4691
4692 * undo.c: Make symbols static if they're not exported.
4693 (last_undo_buffer, last_boundary_position, pending_boundary):
4694 Now static.
4695
4696 * textprop.c (interval_insert_behind_hooks): Now static.
4697 (interval_insert_in_front_hooks): Likewise.
4698
4699 * term.c: Make symbols static if they're not exported.
4700 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4701 (max_frame_lines, tty_set_terminal_modes):
4702 (tty_reset_terminal_modes, tty_turn_off_highlight):
4703 (get_tty_terminal): Now static.
4704 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4705 * termhooks.h (term_mouse_moveto): Do not declare if
4706 HAVE_WINDOW_SYSTEM.
4707 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4708 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4709
4710 * sysdep.c: Make symbols static if they're not exported.
4711 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4712 Now static.
4713 (sigprocmask_set, full_mask): Remove; unused.
4714 (wait_debugging): Mark as visible.
4715 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4716 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4717
4718 * syntax.c (syntax_temp): Define only if !__GNUC__.
4719
4720 * sound.c (current_sound_device, current_sound): Now static.
4721
4722 * search.c (searchbufs, searchbuf_head): Now static.
4723
4724 * scroll.c (scroll_cost): Remove; unused.
4725 * dispextern.h (scroll_cost): Remove decl.
4726
4727 * region-cache.h (pp_cache): Mark as externally visible.
4728
4729 * process.c: Make symbols static if they're not exported.
4730 (process_tick, update_tick, create_process, chan_process):
4731 (Vprocess_alist, proc_buffered_char, datagram_access):
4732 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4733 (deactivate_process): Mark defn as static, as well as decl.
4734 * lisp.h (create_process): Remove decl.
4735 * process.h (chan_process, Vprocess_alist): Remove decls.
4736
4737 * print.c: Make symbols static if they're not exported.
4738 (print_depth, new_backquote_output, being_printed, print_buffer):
4739 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4740 (print_interval, print_number_index, initial_stderr_stream):
4741 Now static.
4742 * lisp.h (Fprinc): Remove decl.
4743 (debug_output_compilation_hack): Mark as externally visible.
4744
4745 * sysdep.c (croak): Move decl from here to syssignal.h.
4746 * syssignal.h (croak): Put it here, so the API can be checked when
4747 'croak' is called from dissociate_if_controlling_tty.
4748
4749 * minibuf.c: Make symbols static if they're not exported.
4750 (minibuf_save_list, choose_minibuf_frame): Now static.
4751 * lisp.h (choose_minibuf_frame): Remove decl.
4752
4753 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4754
4755 * lread.c: Make symbols static if they're not exported.
4756 (read_objects, initial_obarray, oblookup_last_bucket_number):
4757 Now static.
4758 (make_symbol): Remove; unused.
4759 * lisp.h (initial_obarray, make_symbol): Remove decls.
4760
4761 * keyboard.c: Make symbols static if they're not exported.
4762 (single_kboard, recent_keys_index, total_keys, recent_keys):
4763 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4764 (this_single_command_key_start, echoing, last_auto_save):
4765 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4766 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4767 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4768 (Vlispy_mouse_stem, double_click_count):
4769 Now static.
4770 (force_auto_save_soon): Define only if SIGDANGER.
4771 (ignore_mouse_drag_p): Now static if
4772 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4773 (print_help): Remove; unused.
4774 (stop_character, last_timer_event): Mark as externally visible.
4775 * keyboard.h (ignore_mouse_drag_p): Declare only if
4776 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4777 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4778 * lisp.h (echoing): Remove decl.
4779 (force_auto_save_soon): Declare only if SIGDANGER.
4780 * xdisp.c (redisplay_window): Simplify code, to make it more
4781 obvious that ignore_mouse_drag_p is not accessed if !defined
4782 USE_GTK && !defined HAVE_NS.
4783
4784 * intervals.c: Make symbols static if they're not exported.
4785 (merge_properties_sticky, merge_interval_right, delete_interval):
4786 Now static.
4787 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4788
4789 * insdel.c: Make symbols static if they're not exported.
4790 However, leave prepare_to_modify_buffer alone. It's never
4791 called from outside this function, but that appears to be a bug.
4792 (combine_after_change_list, combine_after_change_buffer):
4793 (adjust_after_replace, signal_before_change): Now static.
4794 (adjust_after_replace_noundo): Remove; unused.
4795 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4796 (signal_before_change): Remove decls.
4797
4798 * indent.c (val_compute_motion, val_vmotion): Now static.
4799
4800 * image.c: Make symbols static if they're not exported.
4801 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4802 if USE_GTK.
4803 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4804 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4805
4806 * fringe.c (standard_bitmaps): Now static.
4807 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4808
4809 * frame.c: Make symbols static if they're not exported.
4810 (x_report_frame_params, make_terminal_frame): Now static.
4811 (get_frame_param): Now static, unless HAVE_NS.
4812 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4813 (x_get_resource_string): Remove; not used.
4814 * frame.h (make_terminal_frame, x_report_frame_params):
4815 (x_get_resource_string); Remove decls.
4816 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4817 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4818
4819 * font.c, fontset.c: Make symbols static if they're not exported.
4820 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4821 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4822 * font.c (font_close_object): Now static.
4823 * font.h (font_close_object): Remove.
4824 * fontset.c (FONTSET_OBJLIST): Remove.
4825 (free_realized_fontset) #if-0 the body, which does nothing.
4826 (face_suitable_for_char_p): #if-0, as it's never called.
4827 * fontset.h (face_suitable_for_char_p): Remove decl.
4828 * xfaces.c (face_at_string_position):
4829 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4830 since 0 is always ASCII.
4831
4832 * fns.c (weak_hash_tables): Now static.
4833
4834 * fileio.c: Make symbols static if they're not exported.
4835 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4836 (Vwrite_region_annotation_buffers): Now static.
4837
4838 * eval.c: Make symbols static if they're not exported.
4839 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4840 * lisp.h (backtrace_list): Remove decl.
4841
4842 * emacs.c: Make symbols static if they're not exported.
4843 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4844 (fatal_error_code, fatal_error_signal_hook, standard_args):
4845 Now static.
4846 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4847 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4848 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4849 * lisp.h (fatal_error_signal_hook): Remove decl.
4850 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4851
4852 * editfns.c: Move a (normally-unused) function to its only use.
4853 * editfns.c, lisp.h (get_operating_system_release): Remove.
4854 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4855 worth the hassle of breaking this out.
4856
4857 * xterm.c: Make symbols static if they're not exported.
4858 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4859 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4860 (x_destroy_window, x_delete_display):
4861 Now static.
4862 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4863 (x_mouse_leave): Remove; unused.
4864 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4865 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4866 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4867 Remove decls.
4868 (x_mouse_leave): Declare only if WINDOWSNT.
4869 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4870 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4871 USE_X_TOOLKIT.
4872
4873 * ftxfont.c: Make symbols static if they're not exported.
4874 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4875 HAVE_FREETYPE.
4876 * font.h (ftxfont_driver): Likewise.
4877
4878 * xfns.c: Make symbols static if they're not exported.
4879 (x_last_font_name, x_display_info_for_name):
4880 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4881 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4882 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4883 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4884 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4885 (last_show_tip_args): Now static.
4886 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4887 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4888 (x_screen_planes): Remove; unused.
4889 * dispextern.h (x_screen_planes): Remove decl.
4890
4891 * dispnew.c: Make symbols static if they're not exported.
4892 * dispextern.h (redraw_garbaged_frames, scrolling):
4893 (increment_row_positions): Remove.
4894 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4895 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4896 Now static.
4897 (redraw_garbaged_frames): Remove; unused.
4898
4899 * xfaces.c: Make symbols static if they're not exported.
4900 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4901 Remove decls.
4902 * xterm.h (defined_color): Remove decls.
4903 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4904 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4905 (menu_face_changed_default, defined_color, free_realized_face):
4906 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4907 (ascii_face_of_lisp_face): Remove; unused.
4908
4909 * xdisp.c: Make symbols static if they're not exported.
4910 * dispextern.h (scratch_glyph_row, window_box_edges):
4911 (glyph_to_pixel_coords, set_cursor_from_row):
4912 (get_next_display_element, set_iterator_to_next):
4913 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4914 (show_mouse_face): Remove decls
4915 * frame.h (message_buf_print): Likewise.
4916 * lisp.h (pop_message, set_message, check_point_in_composition):
4917 Likewise.
4918 * xterm.h (set_vertical_scroll_bar): Likewise.
4919 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4920 (message_buf_print, scratch_glyph_row, displayed_buffer):
4921 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4922 (get_next_display_element, show_mouse_face, window_box_edges):
4923 (frame_to_window_pixel_xy, check_point_in_composition):
4924 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4925 (glyph_to_pixel_coords): Remove; unused.
4926
4927 * dired.c (file_name_completion): Now static.
4928
4929 * dbusbind.c (xd_in_read_queued_messages): Now static.
4930
4931 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4932 * data.c (circular_list_error): Remove.
4933
4934 * commands.h (last_point_position, last_point_position_buffer):
4935 (last_point_position_window): Remove decls.
4936 * keyboard.c: Make these variables static.
4937
4938 * coding.h (coding, code_convert_region, encode_coding_gap):
4939 Remove decls.
4940 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4941 (iso_code_class, detect_coding, code_convert_region): Now static.
4942 (encode_coding_gap): Remove; unused.
4943
4944 * chartab.c (chartab_chars, chartab_bits): Now static.
4945
4946 * charset.h (charset_iso_8859_1): Remove decl.
4947 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4948 Now static.
4949
4950 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4951 * ccl.c (Vccl_program_table): Now static.
4952 (check_ccl_update): Remove; unused.
4953
4954 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4955 * category.h: ... from here.
4956 * category.c (check_category_table, set_category_set): Now static.
4957
4958 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4959 * lisp.h: Remove these decls.
4960
4961 * buffer.c (buffer_count): Remove unused var.
4962
4963 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4964 so that it's not optimized away.
4965 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4966 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4967 exported only to the debugger.
4968
4969 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4970 * atimer.h (run_all_atimers): Remove; not exported.
4971
4972 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4973 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4974 was inaccessible from Lisp.
4975 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4976 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4977
4978 alloc.c: Import and export fewer symbols, and remove unused items.
4979 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4980 is defined.
4981 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4982 it's not optimized away by whole-program optimization.
4983 (message_enable_multibyte, free_misc): Remove.
4984 (catchlist, handlerlist, mark_backtrace):
4985 Declare only if BYTE_MARK_STACK.
4986 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4987 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4988 (message_enable_multibyte): Remove decl.
4989 (free_misc, interval_free_list, float_block, float_block_index):
4990 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4991 (cons_free_list, last_marked_index):
4992 Now static.
4993 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4994 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4995 (mark_backtrace): Define only if BYTE_MARK_STACK.
4996 * xdisp.c (message_enable_multibyte): Now static.
4997
4998 Declare Lisp_Object Q* variables to be 'static' if not exported.
4999 This makes it easier for human readers (and static analyzers)
5000 to see whether these variables are used from other modules.
5001 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5002 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5003 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5004 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5005 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5006 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5007 * xmenu.c, xselect.c:
5008 Declare Q* vars static if they are not used in other modules.
5009 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5010 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5011 Remove decls of unexported vars.
5012 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5013
5014 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5015
5016 Make Emacs functions such as Fatom 'static' by default.
5017 This makes it easier for human readers (and static analyzers)
5018 to see whether these functions can be called from other modules.
5019 DEFUN now defines a static function. To make the function external
5020 so that it can be used in other C modules, use the new macro DEFUE.
5021 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5022 (Finit_image_library):
5023 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5024 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5025 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5026 Remove decls, since these functions are now static.
5027 (Funintern, Fget_internal_run_time): New decls, since these functions
5028 were already external.
5029
5030 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5031 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5032 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5033 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5034 * keyboard.c, keymap.c, lread.c:
5035 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5036 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5037 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5038 Mark functions with DEFUE instead of DEFUN,
5039 if they are used in other modules.
5040 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5041 decls for now-static functions.
5042 * buffer.h (Fdelete_overlay): Remove decl.
5043 * callproc.c (Fgetenv_internal): Mark as internal.
5044 * composite.c (Fremove_list_of_text_properties): Remove decl.
5045 (Fcomposition_get_gstring): New forward static decl.
5046 * composite.h (Fcomposite_get_gstring): Remove decl.
5047 * dired.c (Ffile_attributes): New forward static decl.
5048 * doc.c (Fdocumntation_property): New forward static decl.
5049 * eval.c (Ffetch_bytecode): New forward static decl.
5050 (Funintern): Remove extern decl; now in .h file where it belongs.
5051 * fileio.c (Fmake_symbolic_link): New forward static decl.
5052 * image.c (Finit_image_library): New forward static decl.
5053 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5054 * intervals.h (Fprevious_property_change):
5055 (Fremove_list_of_text_properties): Remove decls.
5056 * keyboard.c (Fthis_command_keys): Remove decl.
5057 (Fcommand_execute): New forward static decl.
5058 * keymap.c (Flookup_key): New forward static decl.
5059 (Fcopy_keymap): Now static.
5060 * keymap.h (Flookup_key): Remove decl.
5061 * process.c (Fget_process): New forward static decl.
5062 (Fprocess_datagram_address): Mark as internal.
5063 * syntax.c (Fsyntax_table_p): New forward static decl.
5064 (skip_chars): Remove duplicate decl.
5065 * textprop.c (Fprevious_property_change): New forward static decl.
5066 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5067 Now internal.
5068 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5069 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5070
5071 * editfns.c (Fformat): Remove unreachable code.
5072
5073 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5074
5075 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5076 change. (Bug#8496)
5077
5078 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5079
5080 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5081 when at ZV. (Bug#8487)
5082
5083 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5084
5085 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5086 (Bug#8437)
5087 * keyboard.c (parse_tool_bar_item): Likewise.
5088 * sound.c (sound_cleanup, alsa_close): Likewise.
5089 * termcap.c (tgetent): Likewise.
5090 * xfns.c (x_default_font_parameter): Likewise.
5091 * xsettings.c (read_and_apply_settings): Likewise.
5092
5093 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5094 (overrun_check_free): Protoize.
5095
5096 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5099 since callers should never pass a negative size.
5100 Change the signature to match that of plain 'read' and 'write'; see
5101 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5102 * lisp.h: Update prototypes of emacs_write and emacs_read.
5103
5104 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5105
5106 * xdisp.c (redisplay_window): Don't try to determine the character
5107 position of the scroll margin if the window start point w->startp
5108 is outside the buffer's accessible region. (Bug#8468)
5109
5110 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5111
5112 Fix write-region and its subroutines for buffers > 2GB.
5113 * fileio.c (a_write, e_write): Modify declaration of arguments and
5114 local variables to support buffers larger than 2GB.
5115 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5116
5117 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5118 argument, local variables, and return value.
5119
5120 * lisp.h: Update prototypes of emacs_write and emacs_read.
5121
5122 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5123
5124 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5127
5128 Fix more problems found by GCC 4.6.0's static checks.
5129
5130 * xdisp.c (vmessage): Use a better test for character truncation.
5131
5132 * charset.c (load_charset_map): <, not <=, for optimization,
5133 and to avoid potential problems with integer overflow.
5134 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5135 * casetab.c (set_identity, shuffle): Likewise.
5136 * editfns.c (Fformat): Likewise.
5137 * syntax.c (skip_chars): Likewise.
5138
5139 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5140 This also lets GCC 4.6.0 generate slightly better loop code.
5141
5142 * callint.c (Fcall_interactively): <, not <=, for optimization.
5143 (Fcall_interactively): Count the number of arguments produced,
5144 not the number of arguments given. This is simpler and lets GCC
5145 4.6.0 generate slightly better code.
5146
5147 * ftfont.c: Distingish more carefully between FcChar8 and char.
5148 The previous code passed unsigned char * to a functions like
5149 strlen and xstrcasecmp that expect char *, which does not
5150 conform to the C standard.
5151 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5152 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5153 char * when the C standard requires it.
5154
5155 * keyboard.c (read_char): Remove unused var.
5156
5157 * eval.c: Port to Windows vsnprintf (Bug#8435).
5158 Include <limits.h>.
5159 (SIZE_MAX): Define if the headers do not.
5160 (verror): Do not give up if vsnprintf returns a negative count.
5161 Instead, grow the buffer. This ports to Windows vsnprintf, which
5162 does not conform to C99. Problem reported by Eli Zaretskii.
5163 Also, simplify the allocation scheme, by avoiding the need for
5164 calling realloc, and removing the ALLOCATED variable.
5165
5166 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5167
5168 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5169 But keep the doprint source code for now, as we might revamp it
5170 and use it again (Bug#8435).
5171 * lisp.h (doprnt): Remove.
5172 * Makefile.in (base_obj): Remove doprnt.o.
5173 * deps.mk (doprnt.o): Remove.
5174
5175 error: Print 32- and 64-bit integers portably (Bug#8435).
5176 Without this change, on typical 64-bit hosts error ("...%d...", N)
5177 was used to print both 32- and 64-bit integers N, which relied on
5178 undefined behavior.
5179 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5180 New macro.
5181 * lisp.h (error, verror): Mark as printf-like functions.
5182 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5183 Report overflow in size calculations when allocating printf buffer.
5184 Do not truncate output string at its first null byte.
5185 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5186 Truncate the output at a character boundary, since vsnprintf does not
5187 do that.
5188 * charset.c (check_iso_charset_parameter): Convert internal
5189 character to string before calling 'error', since %c now has the
5190 printf meaning.
5191 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5192 overflow when computing char to be passed to 'error'. Do not
5193 pass Lisp_Object to 'error'; pass the integer instead.
5194 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5195 formatted with plain %d.
5196
5197 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5198
5199 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5200
5201 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5202
5203 * xterm.c (x_catch_errors): Remove duplicate declaration.
5204
5205 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5206
5207 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5208
5209 2011-04-10 Jim Meyering <meyering@redhat.com>
5210
5211 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5212 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5213 return ssize_t not "int", and use size_t as the buffer length.
5214 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5215 * gnutls.h: Update declarations.
5216 * process.c (read_process_output): Use ssize_t, to match.
5217 (send_process): Likewise.
5218
5219 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5220
5221 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5222
5223 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5224
5225 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5226 Use unsigned char, to match FcChar8 type definition.
5227
5228 * xterm.c (handle_one_xevent):
5229 * xmenu.c (create_and_show_popup_menu):
5230 * xselect.c (x_decline_selection_request)
5231 (x_reply_selection_request): Avoid type-punned deref of X events.
5232
5233 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5234
5235 Fix some uses of `int' instead of EMACS_INT.
5236 * search.c (string_match_1, fast_string_match)
5237 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5238 (scan_buffer, find_next_newline_no_quit)
5239 (find_before_next_newline, search_command, Freplace_match)
5240 (Fmatch_data): Make some `int' variables be EMACS_INT.
5241
5242 * xdisp.c (display_count_lines): 3rd argument and return value now
5243 EMACS_INT. All callers changed.
5244 (pint2hrstr): Last argument is now EMACS_INT.
5245
5246 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5247 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5248 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5249 (decode_coding_utf_16, decode_coding_emacs_mule)
5250 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5251 (decode_coding_ccl, decode_coding_charset)
5252 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5253 (decode_coding_iso_2022, decode_coding_emacs_mule)
5254 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5255 <char_offset, last_offset>: Declare EMACS_INT.
5256 (encode_coding_utf_8, encode_coding_utf_16)
5257 (encode_coding_emacs_mule, encode_invocation_designation)
5258 (encode_designation_at_bol, encode_coding_iso_2022)
5259 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5260 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5261 Declare EMACS_INT.
5262 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5263 (encode_invocation_designation): Last argument P_NCHARS is now
5264 EMACS_INT.
5265 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5266 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5267
5268 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5269 All users changed.
5270
5271 * ccl.c (Fccl_execute_on_string): Declare some variables
5272 EMACS_INT.
5273
5274 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5275
5276 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5277
5278 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5279
5280 * process.c (Fformat_network_address): Doc fix.
5281
5282 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5283
5284 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5285
5286 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5287
5288 * keyboard.c (read_char): Call Lisp function help-form-show,
5289 instead of using internal_with_output_to_temp_buffer.
5290 (Qhelp_form_show): New var.
5291 (syms_of_keyboard): Use DEFSYM macro.
5292
5293 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5294
5295 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5296
5297 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * process.c (Flist_processes): Remove to Lisp.
5300 (list_processes_1): Delete.
5301
5302 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5303
5304 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5305
5306 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5307
5308 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5309
5310 Fix more problems found by GCC 4.6.0's static checks.
5311
5312 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5313
5314 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5315
5316 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5317
5318 * xdisp.c (vmessage): Mark as a printf-like function.
5319
5320 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5321
5322 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5323
5324 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5325 printf-like functions.
5326 (tiff_load): Add casts to remove these marks before passing them
5327 to system-supplied API.
5328
5329 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5330
5331 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5332 This avoids several warnings with gcc -Wstrict-overflow.
5333 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5334 directly, rather than having caller test rule sign. This avoids
5335 some unnecessary tests.
5336 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5337 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5338 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5339
5340 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5341 (xfont_open): Avoid unnecessary tests.
5342
5343 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5344
5345 * composite.h, composite.c (composition_gstring_put_cache):
5346 Use EMACS_INT, not int, for length.
5347
5348 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5349 breaking out part of COMPOSITION_DECODE_RULE.
5350 (COMPOSITION_DECODE_RULE): Use it.
5351 * composite.c (get_composition_id): Remove unused local vars,
5352 by using the new macro.
5353
5354 * textprop.c (set_text_properties_1): Change while to do-while,
5355 since the condition is always true at first.
5356
5357 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5358 (interval_deletion_adjustment): Return unsigned value.
5359 All uses changed.
5360
5361 * process.c (list_processes_1, create_pty, read_process_output):
5362 (exec_sentinel): Remove vars that were set but not used.
5363 (create_pty): Remove unnecessary "volatile"s.
5364 (Fnetwork_interface_info): Avoid possibility of int overflow.
5365 (read_process_output): Do adaptive read buffering even if carryover.
5366 (read_process_output): Simplify nbytes computation if buffered.
5367
5368 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5369
5370 * syntax.c (scan_words): Remove var that was set but not used.
5371 (update_syntax_table): Use unsigned instead of int.
5372
5373 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5374 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5375 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5376
5377 * print.c (print_error_message): Avoid int overflow.
5378
5379 * font.c (font_list_entities): Redo for clarity,
5380 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5381
5382 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5383 (font_score): Avoid potential overflow in diff calculation.
5384
5385 * fns.c (substring_both): Remove var that is set but not used.
5386 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5387
5388 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5389
5390 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5391 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5392 can always succeed if overflow has undefined behavior.
5393
5394 * search.c (boyer_moore, wordify): Remove vars set but not used.
5395 (wordify): Omit three unnecessary tests.
5396
5397 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5398 All callers changed. This avoids the need for an unused var.
5399
5400 * casefiddle.c (casify_region): Remove var that is set but not used.
5401
5402 * dired.c (file_name_completion): Remove var that is set but not used.
5403
5404 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5405
5406 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5407 (Finsert_file_contents): Remove unnecessary code checking fd.
5408
5409 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5410 Check for integer overflow on size calculations.
5411
5412 * buffer.c (Fprevious_overlay_change): Remove var that is set
5413 but not used.
5414
5415 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5416 Remove vars that are set but not used.
5417 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5418 (timer_check_2): Mark vars as initialized.
5419
5420 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5421
5422 * image.c (lookup_image): Remove var that is set but not used.
5423 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5424
5425 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5426 that are set but not used.
5427
5428 * xfns.c (make_invisible_cursor): Don't return garbage
5429 if XCreateBitmapFromData fails (Bug#8410).
5430
5431 * xselect.c (x_get_local_selection, x_handle_property_notify):
5432 Remove vars that are set but not used.
5433
5434 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5435 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5436
5437 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5438 Remove var that is set but not used.
5439 (scroll_bar_windows_size): Now size_t, not int.
5440 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5441 Check for overflow.
5442
5443 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5444 (map_tty_color) [!defined MSDOS]: Likewise.
5445
5446 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5447
5448 * coding.c: Remove vars that are set but not used.
5449 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5450 All callers changed.
5451 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5452 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5453 (decode_coding_charset): Remove vars that are set but not used.
5454
5455 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5456 that is set but not used.
5457
5458 * print.c (print_object): Remove var that is set but not used.
5459
5460 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5461 The gnulib version avoids calling malloc in the usual case,
5462 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5463 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5464 * filelock.c (current_lock_owner): Likewise.
5465 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5466 * sysdep.c: Include allocator.h, careadlinkat.h.
5467 (emacs_no_realloc_allocator): New static constant.
5468 (emacs_readlink): New function.
5469 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5470 ../lib/careadlinkat.h.
5471
5472 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5473
5474 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5475 first non-nil return value).
5476
5477 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5478
5479 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5480 if not defined (Bug#8403).
5481
5482 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5483
5484 * xdisp.c (display_count_lines): Remove parameter `start',
5485 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5486 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5487 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5488 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5489 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5490 and thereabouts. All callers changed.
5491 (get_per_char_metric): Remove parameter `f', unused since
5492 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5493
5494 2011-04-02 Jim Meyering <meyering@redhat.com>
5495
5496 do not dereference NULL upon failed strdup
5497 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5498 (ns_get_family): Likewise.
5499
5500 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5501
5502 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5503
5504 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5505
5506 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5507 later (Bug#8403).
5508
5509 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5510
5511 Add lexical binding.
5512
5513 * window.c (Ftemp_output_buffer_show): New fun.
5514 (Fsave_window_excursion):
5515 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5516
5517 * lread.c (lisp_file_lexically_bound_p): New function.
5518 (Fload): Bind Qlexical_binding.
5519 (readevalloop): Remove `evalfun' arg.
5520 Bind Qinternal_interpreter_environment.
5521 (Feval_buffer): Bind Qlexical_binding.
5522 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5523 Mark as dynamic.
5524 (syms_of_lread): Declare `lexical-binding'.
5525
5526 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5527
5528 * keyboard.c (eval_dyn): New fun.
5529 (menu_item_eval_property): Use it.
5530
5531 * image.c (parse_image_spec): Use Ffunctionp.
5532
5533 * fns.c (concat, mapcar1): Accept byte-code-functions.
5534
5535 * eval.c (Fsetq): Handle lexical vars.
5536 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5537 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5538 (FletX, Flet): Obey lexical binding.
5539 (Fcommandp): Handle closures.
5540 (Feval): New `lexical' arg.
5541 (eval_sub): New function extracted from Feval. Use it almost
5542 everywhere where Feval was used. Look up vars in lexical env.
5543 Handle closures.
5544 (Ffunctionp): Move from subr.el.
5545 (Ffuncall): Handle closures.
5546 (apply_lambda): Remove `eval_flags'.
5547 (funcall_lambda): Handle closures and new byte-code-functions.
5548 (Fspecial_variable_p): New function.
5549 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5550 but without exporting it to Lisp.
5551
5552 * doc.c (Fdocumentation, store_function_docstring):
5553 * data.c (Finteractive_form): Handle closures.
5554
5555 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5556 interactive spec.
5557
5558 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5559 New byte-codes.
5560 (exec_byte_code): New function extracted from Fbyte_code to handle new
5561 calling convention for byte-code-functions. Add new byte-codes.
5562
5563 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5564
5565 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5566
5567 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5568
5569 * xdisp.c (redisplay_internal): Fix prototype.
5570
5571 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5572
5573 * xdisp.c (SCROLL_LIMIT): New macro.
5574 (try_scrolling): Use it when setting scroll_limit.
5575 Limit scrolling to 100 screen lines.
5576 (redisplay_window): Even when falling back on "recentering",
5577 position point in the window according to scroll-conservatively,
5578 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5579
5580 (try_scrolling): When point is above the window, allow searching
5581 as far as scroll_max, or one screenful, to compute vertical
5582 distance from PT to the scroll margin position. This prevents
5583 try_scrolling from unnecessarily failing when
5584 scroll-conservatively is set to a value slightly larger than the
5585 window height. Clean up the case of PT below the margin at bottom
5586 of window: scroll_max can no longer be INT_MAX. When aggressive
5587 scrolling is in use, don't let point enter the opposite scroll
5588 margin as result of the scroll.
5589 (syms_of_xdisp) <scroll-conservatively>: Document the
5590 threshold of 100 lines for never-recentering scrolling.
5591
5592 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5593
5594 * dispextern.h (move_it_by_lines):
5595 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5596 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5597 (message_log_check_duplicate): Remove parameters `prev_bol' and
5598 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5599 (redisplay_internal): Remove parameter `preserve_echo_area',
5600 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5601
5602 * indent.c (Fvertical_motion):
5603 * window.c (window_scroll_pixel_based, Frecenter):
5604 Don't pass `need_y_p' to `move_it_by_lines'.
5605
5606 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5607
5608 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5609 steal a few bits to be more compact.
5610 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5611 Remove unneeded casts.
5612
5613 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5614
5615 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5616
5617 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5618 binding" message (bug#7967).
5619
5620 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5621
5622 Fix more problems found by GCC 4.6.0's static checks.
5623
5624 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5625 Remove unused local var.
5626
5627 * editfns.c (Fmessage_box): Remove unused local var.
5628
5629 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5630 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5631 Omit unused local vars.
5632 * window.c (shrink_windows): Omit unused local var.
5633 * menu.c (digest_single_submenu): Omit unused local var.
5634 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5635 Omit unused local var.
5636
5637 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5638 Don't assume string length fits in int.
5639 (keyremap_step, read_key_sequence): Use size_t for sizes.
5640 (read_key_sequence): Don't check last_real_key_start redundantly.
5641
5642 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5643 instead of alloca (Bug#8344).
5644
5645 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5646 (Fbacktrace_frame): Don't assume nframes fits in int.
5647
5648 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5649
5650 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5651 concerns.
5652
5653 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5654
5655 * cm.c (calccost): Turn while-do into do-while, for clarity.
5656
5657 * keyboard.c (syms_of_keyboard): Use the same style as later
5658 in this function when indexing through an array. This also
5659 works around GCC bug 48267.
5660
5661 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5662
5663 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5664
5665 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5666 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5667
5668 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5669 This avoids undefined behavior on integer overflow, and is a bit
5670 more convenient anyway since it is compared to a size_t variable.
5671
5672 Variadic C functions now count arguments with size_t, not int.
5673 This avoids an unnecessary limitation on 64-bit machines, which
5674 caused (substring ...) to crash on large vectors (Bug#8344).
5675 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5676 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5677 All variadic functions and their callers changed accordingly.
5678 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5679 * data.c (arith_driver, float_arith_driver): Likewise.
5680 * editfns.c (general_insert_function): Likewise.
5681 * eval.c (struct backtrace.nargs, interactive_p)
5682 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5683 (funcall_lambda, mark_backtrace): Likewise.
5684 * fns.c (concat): Likewise.
5685 * frame.c (x_set_frame_parameters): Likewise.
5686 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5687 0 if not found, not -1. All callers changed.
5688
5689 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5690 (stack_copy_size): Now size_t, not int.
5691 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5692
5693 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5694
5695 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5696 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5697 All callers changed.
5698
5699 * lisp.h (multibyte_char_to_unibyte):
5700 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5701 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5702 * character.h (CHAR_TO_BYTE8):
5703 * cmds.c (internal_self_insert):
5704 * editfns.c (general_insert_function):
5705 * keymap.c (push_key_description):
5706 * search.c (Freplace_match):
5707 * xdisp.c (message_dolog, set_message_1): All callers changed.
5708
5709 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5710
5711 * keyboard.c (safe_run_hook_funcall): New function.
5712 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5713 don't set the hook to nil, but remove the offending function instead.
5714 (Qcommand_hook_internal): Remove, unused.
5715 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5716 Vcommand_hook_internal.
5717
5718 * eval.c (enum run_hooks_condition): Remove.
5719 (funcall_nil, funcall_not): New functions.
5720 (run_hook_with_args): Call each function through a `funcall' argument.
5721 Remove `cond' argument, now redundant.
5722 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5723 (Frun_hook_with_args_until_failure): Adjust accordingly.
5724 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5725
5726 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5727
5728 * dispextern.h (string_buffer_position): Remove declaration.
5729
5730 * print.c (strout): Remove parameter `multibyte', unused since
5731 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5732
5733 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5734 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5735 All callers changed.
5736
5737 * w32.c (_wsa_errlist): Use braces for struct initializers.
5738
5739 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5740 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5741 All callers changed.
5742 (string_buffer_position): Likewise. Also, make static (it's never
5743 used outside xdisp.c).
5744 (cursor_row_p): Remove parameter `w', unused since
5745 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5746 (decode_mode_spec): Remove parameter `precision', introduced during
5747 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5748 All callers changed.
5749
5750 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5751
5752 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5753
5754 2011-03-27 Anders Lindgren <andlind@gmail.com>
5755
5756 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5757 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5758 (ns_update_auto_hide_menu_bar): New functions.
5759 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5760 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5761 ns_constrain_all_frames.
5762 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5763 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5764
5765 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5766
5767 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5768
5769 2011-03-27 Glenn Morris <rgm@gnu.org>
5770
5771 * syssignal.h: Replace RETSIGTYPE with void.
5772 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5773 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5774 Replace SIGTYPE with void everywhere.
5775 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5776 * s/template.h (SIGTYPE): Remove commented out definition.
5777
5778 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5781 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5782
5783 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5784
5785 * w32.c (read_unc_volume): Use parameter `henum', instead of
5786 global variable `wget_enum_handle'.
5787
5788 * keymap.c (describe_vector): Remove parameters `indices' and
5789 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5790 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5791
5792 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5793
5794 * keyboard.c (timer_check): Remove parameter `do_it_now',
5795 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5796 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5797 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5798
5799 * keyboard.c (read_char):
5800 * w32menu.c (w32_menu_display_help):
5801 * xmenu.c (show_help_event, menu_help_callback):
5802 Adjust calls to `show_help_echo'.
5803
5804 * gtkutil.c (xg_maybe_add_timer):
5805 * keyboard.c (readable_events):
5806 * process.c (wait_reading_process_output):
5807 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5808
5809 * insdel.c (adjust_markers_gap_motion):
5810 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5811 (gap_left, gap_right): Don't call it.
5812
5813 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5814
5815 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5816 incurred during fontification.
5817
5818 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5819
5820 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5821 (DEFVAR_PER_BUFFER): Don't pass it.
5822
5823 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5824 (scrolling_window): Don't pass it.
5825
5826 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5827
5828 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5829
5830 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5831 and `suffix'.
5832 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5833 of variables specific to SELinux and computation of `encoded_absname'.
5834
5835 * image.c (XPutPixel): Remove unused variable `height'.
5836
5837 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5838
5839 * unexw32.c (get_section_info): Remove unused variable `section'.
5840
5841 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5842 (system_process_attributes): Remove unused variable `sess'.
5843 (sys_read): Remove unused variable `err'.
5844
5845 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5846 (w32_wnd_proc): Remove unused variable `isdead'.
5847 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5848 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5849 (x_create_tip_frame): Remove unused variable `tem'.
5850
5851 * w32inevt.c (w32_console_read_socket):
5852 Remove unused variable `no_events'.
5853
5854 * w32term.c (x_draw_composite_glyph_string_foreground):
5855 Remove unused variable `width'.
5856
5857 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5858
5859 * w32term.c (x_set_glyph_string_clipping):
5860 Don't pass uninitialized region to CombineRgn.
5861
5862 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5865 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5866 (Fx_close_connection): Remove unused variable `i'.
5867
5868 * w32font.c (w32font_draw): Return number of glyphs.
5869 (w32font_open_internal): Remove unused variable `i'.
5870 (w32font_driver): Add missing initializer.
5871
5872 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5873 (fill_in_menu): Remove unused variable `items_added'.
5874
5875 * w32term.c (last_mouse_press_frame): Remove static global variable.
5876 (w32_clip_to_row): Remove unused variable `f'.
5877 (x_delete_terminal): Remove unused variable `i'.
5878
5879 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5880 (NOTHING): Remove unused static global variable.
5881 (uniscribe_check_otf): Remove unused variable `table'.
5882 (uniscribe_font_driver): Add missing initializers.
5883
5884 2011-03-23 Julien Danjou <julien@danjou.info>
5885
5886 * term.c (Fsuspend_tty, Fresume_tty):
5887 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5888 * window.c (temp_output_buffer_show):
5889 * insdel.c (signal_before_change):
5890 * frame.c (Fhandle_switch_frame):
5891 * fileio.c (Fdo_auto_save):
5892 * emacs.c (Fkill_emacs):
5893 * editfns.c (save_excursion_restore):
5894 * cmds.c (internal_self_insert):
5895 * callint.c (Fcall_interactively):
5896 * buffer.c (Fkill_all_local_variables):
5897 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5898 Use Frun_hooks.
5899 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5900 unconditionnaly since it does the check itself.
5901
5902 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5903
5904 Fix more problems found by GCC 4.5.2's static checks.
5905
5906 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5907 the first time through the loop, since we know p0 < p1 then.
5908 This also avoids a gcc -Wstrict-overflow warning.
5909
5910 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5911 leading to a memory leak, possible in functions like
5912 load_charset_map_from_file that can allocate an unbounded number
5913 of objects (Bug#8318).
5914
5915 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5916 that could (at least in theory) be that large.
5917
5918 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5919 This is less likely to overflow, and avoids undefined behavior if
5920 overflow does occur. All callers changed. Use strtoul to scan
5921 for the unsigned long integer.
5922 (pint2hrstr): Simplify and tune code slightly.
5923 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5924
5925 * scroll.c (do_scrolling): Work around GCC bug 48228.
5926 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5927
5928 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5929 This also avoids a warning with gcc -Wstrict-overflow.
5930 (validate_x_resource_name): Simplify count usage.
5931 This also avoids a warning with gcc -Wstrict-overflow.
5932
5933 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5934 fail (Bug#8306).
5935
5936 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5937
5938 * process.c (Fmake_network_process): Use socklen_t, not int,
5939 where POSIX says socklen_t is required in portable programs.
5940 This fixes a porting bug on hosts like 64-bit HP-UX, where
5941 socklen_t is wider than int (Bug#8277).
5942 (Fmake_network_process, server_accept_connection):
5943 (wait_reading_process_output, read_process_output):
5944 Likewise.
5945
5946 * process.c: Rename or move locals to avoid shadowing.
5947 (list_processes_1, Fmake_network_process):
5948 (read_process_output_error_handler, exec_sentinel_error_handler):
5949 Rename or move locals.
5950 (Fmake_network_process): Define label "retry_connect" only if needed.
5951 (Fnetwork_interface_info): Fix pointer signedness.
5952 (process_send_signal): Add cast to avoid pointer signedness problem.
5953 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5954 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5955
5956 Make tparam.h and terminfo.c consistent.
5957 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5958 Include tparam.h instead, since it declares them.
5959 * cm.h (PC): Remove extern decl; tparam.h now does this.
5960 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5961 * terminfo.c: Include tparam.h, to check interfaces.
5962 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5963 (tparam): Adjust signature to match interface in tparam.h;
5964 this removes some undefined behavior. Check that outstring and len
5965 are zero, which they always are with Emacs.
5966 * tparam.h (PC, BC, UP): New extern decls.
5967
5968 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5969 (xftfont_open): Rename locals to avoid shadowing.
5970
5971 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5972 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5973 (OTF_TAG_SYM): Omit macro if not needed.
5974 (ftfont_list): Remove unused local.
5975 (get_adstyle_property, ftfont_pattern_entity):
5976 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5977 Rename locals to avoid shadowing.
5978
5979 * xfont.c (xfont_list_family): Mark var as initialized.
5980
5981 * xml.c (make_dom): Now static.
5982
5983 * composite.c (composition_compute_stop_pos): Rename local to
5984 avoid shadowing.
5985 (composition_reseat_it): Remove unused locals.
5986 (find_automatic_composition, composition_adjust_point): Likewise.
5987 (composition_update_it): Mark var as initialized.
5988 (find_automatic_composition): Mark vars as initialized,
5989 with a FIXME (Bug#8290).
5990
5991 character.h: Rename locals to avoid shadowing.
5992 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5993 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5994 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5995 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5996 to avoid shadowing.
5997
5998 * textprop.c (property_change_between_p): Remove; unused.
5999
6000 * intervals.c (interval_start_pos): Now static.
6001
6002 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6003
6004 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6005 Rename locals to avoid shadowing.
6006
6007 * sound.c (wav_play, au_play, Fplay_sound_internal):
6008 Fix pointer signedness.
6009 (alsa_choose_format): Remove unused local var.
6010 (wav_play): Initialize a variable to 0, to prevent undefined
6011 behavior (Bug#8278).
6012
6013 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6014
6015 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6016
6017 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6018 clobbering (Bug#8298).
6019 * sysdep.c (sys_subshell): Likewise.
6020 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6021
6022 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6023 This should get cleaned up, so that child_setup has the
6024 same signature on all platforms.
6025
6026 * callproc.c (call_process_cleanup): Now static.
6027 (relocate_fd): Rename locals to avoid shadowing.
6028
6029 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6030
6031 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6032 not to be necessary, and produces flickering.
6033
6034 2011-03-20 Glenn Morris <rgm@gnu.org>
6035
6036 * config.in: Remove file.
6037
6038 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6039
6040 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6041 are now in src/globals.h.
6042 (syms_of_minibuf): Remove spurious & from previous change.
6043
6044 2011-03-20 Leo <sdl.web@gmail.com>
6045
6046 * minibuf.c (completing-read-function): New variable.
6047 (completing-read-default): Rename from completing-read.
6048 (completing-read): Call completing-read-function.
6049
6050 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6051
6052 * xfaces.c (Fx_load_color_file):
6053 Read color file from absolute filename (bug#8250).
6054
6055 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * makefile.w32-in: Update dependencies.
6058
6059 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6060
6061 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6062
6063 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 Fix more problems found by GCC 4.5.2's static checks.
6066
6067 * process.c (make_serial_process_unwind, send_process_trap):
6068 (sigchld_handler): Now static.
6069
6070 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6071 That way, the code declares only the vars that it needs.
6072 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6073 * s/cygwin.h (PTY_ITERATION): Likewise.
6074 * s/darwin.h (PTY_ITERATION): Likewise.
6075 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6076
6077 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6078 * process.c (allocate_pty): Don't declare stb unless it's needed.
6079
6080 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6081 (CONSTANTLIM): Remove; unused.
6082 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6083 Define only if needed.
6084
6085 * unexelf.c (unexec): Name an expression,
6086 to avoid gcc -Wbad-function-cast warning.
6087 Use a different way to cause a compilation error if anyone uses
6088 n rather than nn, a way that does not involve shadowing.
6089 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6090
6091 * deps.mk (unexalpha.o): Remove; unused.
6092
6093 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6094 * unexec.h: New file.
6095 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6096 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6097 Depend on unexec.h.
6098 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6099 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6100 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6101 Change as necessary to match prototype in unexec.h.
6102
6103 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6104 shadowing.
6105 (back_comment, skip_chars): Mark vars as initialized.
6106
6107 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6108 Rename locals to avoid shadowing.
6109
6110 * lread.c (read1): Rewrite so as not to use empty "else".
6111 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6112
6113 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6114
6115 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6116 warning when compiling print.c.
6117
6118 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6119 instead of using an uninitialized var.
6120 (font_sort_entities): Mark var as initialized.
6121
6122 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6123
6124 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6125 pointers to constants.
6126 (font_parse_fcname): Remove unused vars.
6127 (font_delete_unmatched): Now static.
6128 (font_get_spec): Remove; unused.
6129 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6130 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6131 Rename or move locals to avoid shadowing.
6132
6133 * fns.c (require_nesting_list, require_unwind): Now static.
6134 (Ffillarray): Rename locals to avoid shadowing.
6135
6136 * floatfns.c (domain_error2): Define only if needed.
6137 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6138
6139 * alloc.c (mark_backtrace): Move decl from here ...
6140 * lisp.h: ... to here, so that it can be checked.
6141
6142 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6143 (Fdefvar): Rewrite so as not to use empty "else".
6144 (lisp_indirect_variable): Name an expression,
6145 to avoid gcc -Wbad-function-cast warning.
6146 (Fdefvar): Rename locals to avoid shadowing.
6147
6148 * callint.c (quotify_arg, quotify_args): Now static.
6149 (Fcall_interactively): Rename locals to avoid shadowing.
6150 Use const pointer when appropriate.
6151
6152 * lisp.h (get_system_name, get_operating_system_release):
6153 Move decls here, to check interfaces.
6154 * process.c (get_operating_system_release): Move decl to lisp.h.
6155 * xrdb.c (get_system_name): Likewise.
6156 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6157 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6158 some of which prompt warnings from gcc -Wbad-function-cast.
6159 (Fformat_time_string, Fencode_time, Finsert_char):
6160 (Ftranslate_region_internal, Fformat):
6161 Rename or remove local vars to avoid shadowing.
6162 (Ftranslate_region_internal): Mark var as initialized.
6163
6164 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6165 avoid shadowing.
6166
6167 * lisp.h (eassert): Check that the argument compiles, even if
6168 ENABLE_CHECKING is not defined.
6169
6170 * data.c (Findirect_variable): Name an expression, to avoid
6171 gcc -Wbad-function-cast warning.
6172 (default_value, arithcompare, arith_driver, arith_error): Now static.
6173 (store_symval_forwarding): Rename local to avoid shadowing.
6174 (Fmake_variable_buffer_local, Fmake_local_variable):
6175 Mark variables as initialized.
6176 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6177
6178 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6179 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6180 Rename locals to avoid shadowing.
6181 (mark_stack): Move local variables into the #ifdef region where
6182 they're used.
6183 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6184 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6185 needed otherwise.
6186 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6187 (GC_STRING_CHARS): Remove; not used.
6188 (Fmemory_limit): Cast sbrk's returned value to char *.
6189
6190 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6191 avoids undefined behavior in theory.
6192
6193 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6194
6195 Use functions, not macros, for up- and down-casing (Bug#8254).
6196 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6197 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6198 to use the following functions instead of these macros.
6199 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6200 EMACS_INT, since callers assume the returned value fits in int.
6201 (upcase1): Likewise, for UPCASE_TABLE.
6202 (uppercasep, lowercasep, upcase): New static inline functions.
6203 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6204 the race-condition problem in the old DOWNCASE.
6205
6206 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6207 Rename locals to avoid shadowing.
6208 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6209 (regex_compile, re_search_2, re_match_2_internal):
6210 Remove unused local vars.
6211 (FREE_VAR): Rewrite so as not to use empty "else",
6212 which gcc can warn about.
6213 (regex_compile, re_match_2_internal): Mark locals as initialized.
6214 (RETALLOC_IF): Define only if needed.
6215 (WORDCHAR_P): Likewise. This one is never needed, but is used
6216 only in a comment talking about a compiler bug, so put inside
6217 the #if 0 of that comment.
6218 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6219 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6220 Remove; unused.
6221
6222 * search.c (boyer_moore): Rename locals to avoid shadowing.
6223 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6224 (PREV_CHAR_BOUNDARY): Likewise.
6225
6226 * search.c (simple_search): Remove unused var.
6227
6228 * dired.c (compile_pattern): Move decl from here ...
6229 * lisp.h: ... to here, so that it can be checked.
6230 (struct re_registers): New forward decl.
6231
6232 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6233
6234 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6235 All uses changed.
6236 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6237 Rename locals to avoid shadowing.
6238 (Fvertical_motion): Mark locals as initialized.
6239
6240 * casefiddle.c (casify_object, casify_region): Now static.
6241 (casify_region): Mark local as initialized.
6242
6243 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6244
6245 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6246 New macros, so that the caller can use some names other than
6247 gcpro1, gcpro2, etc.
6248 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6249 of the new macros.
6250 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6251 argument, for consistency with GCPRO2_VAR, etc: it is now the
6252 prefix of the variable, not the variable itself. All uses
6253 changed.
6254 * dired.c (directory_files_internal, file_name_completion):
6255 Rename locals to avoid shadowing.
6256
6257 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6258 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6259 dired.c's scmp function, had undefined behavior.
6260 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6261 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6262 * buffer.h: ... to here, because these macros use current_buffer,
6263 and the new implementation with inline functions needs to have
6264 current_buffer in scope now, rather than later when the macros
6265 are used.
6266 (downcase, upcase1): New static inline functions.
6267 (DOWNCASE, UPCASE1): Reimplement using these functions.
6268 This avoids undefined behavior in expressions like
6269 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6270 from race conditions in accessing the global variables
6271 case_temp1 and case_temp2.
6272 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6273 * lisp.h (case_temp1, case_temp2): Remove their decls.
6274 * character.h (ASCII_CHAR_P): Move from here ...
6275 * lisp.h: ... to here, so that the inline functions mentioned
6276 above can use them.
6277
6278 * dired.c (directory_files_internal_unwind): Now static.
6279
6280 * fileio.c (file_name_as_directory, directory_file_name):
6281 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6282 Now static.
6283 (file_name_as_directory): Use const pointers when appropriate.
6284 (Fexpand_file_name): Likewise. In particular, newdir might
6285 point at constant storage, so make it a const pointer.
6286 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6287 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6288 signedness issues.
6289 (Fset_file_times, Finsert_file_contents, auto_save_error):
6290 Rename locals to avoid shadowing.
6291
6292 * minibuf.c (choose_minibuf_frame_1): Now static.
6293 (Ftry_completion, Fall_completions): Rename or remove locals
6294 to avoid shadowing.
6295
6296 * marker.c (bytepos_to_charpos): Remove; unused.
6297
6298 * lisp.h (verify_bytepos, count_markers): New decls,
6299 so that gcc does not warn that these functions aren't declared.
6300
6301 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6302 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6303 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6304 (copy_text): Remove unused local var.
6305
6306 * filelock.c (within_one_second): Now static.
6307 (lock_file_1): Rename local to avoid shadowing.
6308
6309 * buffer.c (fix_overlays_before): Mark locals as initialized.
6310 (fix_start_end_in_overlays): Likewise. This function should be
6311 simplified by using pointers-to-pointers, but that's a different
6312 matter.
6313 (switch_to_buffer_1): Now static.
6314 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6315 (report_overlay_modification): Rename locals to avoid shadowing.
6316
6317 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6318 Fix pointer signedness issue.
6319 (sys_subshell): Mark local as volatile if checking for lint,
6320 to suppress a gcc -Wclobbered warning that does not seem to be right.
6321 (MAXPATHLEN): Define only if needed.
6322
6323 * process.c (serial_open, serial_configure): Move decls from here ...
6324 * systty.h: ... to here, so that they can be checked.
6325
6326 * fns.c (get_random, seed_random): Move extern decls from here ...
6327 * lisp.h: ... to here, so that they can be checked.
6328
6329 * sysdep.c (reset_io): Now static.
6330 (wait_for_termination_signal): Remove; unused.
6331
6332 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6333 (copy_keymap_item, append_key, push_text_char_description):
6334 Now static.
6335 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6336 (DENSE_TABLE_SIZE): Remove; unused.
6337 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6338 (describe_map_tree):
6339 Rename locals to avoid shadowing.
6340
6341 * keyboard.c: Declare functions static if they are not used elsewhere.
6342 (echo_char, echo_dash, cmd_error, top_level_2):
6343 (poll_for_input, handle_async_input): Now static.
6344 (read_char, kbd_buffer_get_event, make_lispy_position):
6345 (make_lispy_event, make_lispy_movement, apply_modifiers):
6346 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6347 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6348 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6349 (read_key_sequence, read_char): Mark locals as initialized.
6350 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6351
6352 * keyboard.h (make_ctrl_char): New decl.
6353 (mark_kboards): Move decl here ...
6354 * alloc.c (mark_kboards): ... from here.
6355
6356 * lisp.h (force_auto_save_soon): New decl.
6357
6358 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6359 (DEFINE_DUMMY_FUNCTION): New macro.
6360 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6361 Use it.
6362 (main): Add casts to avoid warnings
6363 if GCC considers string literals to be constants.
6364
6365 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6366
6367 * dbusbind.c: Pointer signedness fixes.
6368 (xd_signature, xd_append_arg, xd_initialize):
6369 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6370 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6371 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6372 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6373
6374 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6375 if GCC considers string literals to be constants.
6376 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6377
6378 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6381 (print_preprocess, print_object): New macro to fix last change.
6382
6383 * print.c (print_preprocess): Don't forget font objects.
6384
6385 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * emacs.c (USAGE3): Doc fixes.
6388
6389 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6390
6391 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6392 structure.
6393
6394 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6395
6396 * lisp.h (VWindow_system, Qfile_name_history):
6397 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6398 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6399 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6400
6401 * w32select.c: Don't #include "keyboard.h".
6402 (run_protected): Add extern declaration for waiting_for_input.
6403
6404 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6405 * w32console.c (detect_input_pending, read_input_pending)
6406 (encode_terminal_code):
6407 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6408 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6409 (w32_system_caret_y, Qfile_name_history):
6410 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6411 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6412 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6413 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6414 * w32proc.c (Qlocal, report_file_error):
6415 * w32term.c (Vwindow_system, updating_frame):
6416 * w32uniscribe.c (initialized, uniscribe_font_driver):
6417 Remove unneeded extern declarations.
6418
6419 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6420
6421 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6422
6423 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6424
6425 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6426 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6427 These macros can no longer be used for assignment.
6428
6429 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6430 Assign struct members directly, instead of using BUF_BEGV etc.
6431 (record_buffer_markers, fetch_buffer_markers): New functions for
6432 recording and fetching special buffer markers.
6433 (set_buffer_internal_1, set_buffer_temp): Use them.
6434
6435 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6436
6437 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6438
6439 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6440 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6441
6442 * xdisp.c (hscroll_window_tree):
6443 (reconsider_clip_changes): Use PT instead of BUF_PT.
6444
6445 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6446
6447 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6448 $(EMACS_ROOT)/lib/intprops.h.
6449
6450 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6451
6452 Fix more problems found by GCC 4.5.2's static checks.
6453
6454 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6455 to unsigned char * to avoid compiler diagnostic.
6456 (xg_free_frame_widgets): Make it clear that a local variable is
6457 needed only if USE_GTK_TOOLTIP.
6458 (gdk_window_get_screen): Make it clear that this macro is needed
6459 only if USE_GTK_TOOLTIP.
6460 (int_gtk_range_get_value): New function, which avoids a diagnostic
6461 from gcc -Wbad-function-cast.
6462 (xg_set_toolkit_scroll_bar_thumb): Use it.
6463 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6464 diagnostic from gcc -Wbad-function-cast.
6465 (get_utf8_string, xg_get_file_with_chooser):
6466 Rename locals to avoid shadowing.
6467 (create_dialog): Move locals to avoid shadowing.
6468
6469 * xgselect.c (xg_select): Remove unused var.
6470
6471 * image.c (four_corners_best): Mark locals as initialized.
6472 (gif_load): Initialize transparent_p to zero (Bug#8238).
6473 Mark another local as initialized.
6474 (my_png_error, my_error_exit): Mark with NO_RETURN.
6475
6476 * image.c (clear_image_cache): Now static.
6477 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6478 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6479 (x_edge_detection): Remove unnecessary cast that
6480 gcc -Wbad-function-cast diagnoses.
6481 (gif_load): Fix pointer signedness.
6482 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6483 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6484
6485 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 Improve quality of tests for time stamp overflow.
6488 For example, without this patch (encode-time 0 0 0 1 1
6489 1152921504606846976) returns the obviously-bogus value (-948597
6490 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6491 reports time overflow. See
6492 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6493 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6494 * editfns.c: Include limits.h and intprops.h.
6495 (TIME_T_MIN, TIME_T_MAX): New macros.
6496 (time_overflow): Move earlier, to before first use.
6497 (hi_time, lo_time): New functions, for an accurate test for
6498 out-of-range times.
6499 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6500 (Fget_internal_run_time): Don't assume time_t fits in int.
6501 (make_time): Use list2 instead of Fcons twice.
6502 (Fdecode_time): More accurate test for out-of-range times.
6503 (check_tm_member): New function.
6504 (Fencode_time): Use it, to test for out-of-range times.
6505 (lisp_time_argument): Don't rely on undefined left-shift and
6506 right-shift behavior when checking for time stamp overflow.
6507
6508 * editfns.c (time_overflow): New function, refactoring common code.
6509 (Fformat_time_string, Fdecode_time, Fencode_time):
6510 (Fcurrent_time_string): Use it.
6511
6512 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6513 * dired.c (make_time): Move to ...
6514 * editfns.c (make_time): ... here.
6515 * systime.h: Note the move.
6516
6517 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6518
6519 * fringe.c (update_window_fringes): Remove unused variables.
6520
6521 * unexmacosx.c (copy_data_segment): Also copy __got section.
6522 (Bug#8223)
6523
6524 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6525
6526 * termcap.c [MSDOS]: Include "msdos.h".
6527 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6528 Constify `char *' arguments and their references according to
6529 prototypes in tparam.h.
6530
6531 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6532
6533 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6534 Adapt all references accordingly.
6535
6536 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6537
6538 2011-03-11 Tom Tromey <tromey@redhat.com>
6539
6540 * buffer.c (syms_of_buffer): Remove obsolete comment.
6541
6542 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6543
6544 * termhooks.h (encode_terminal_code): Declare prototype.
6545
6546 * msdos.c (encode_terminal_code): Don't declare prototype.
6547
6548 * term.c (encode_terminal_code): Now external again, used by
6549 w32console.c and msdos.c.
6550
6551 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6552 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6553
6554 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6555
6556 Fix some minor problems found by GCC 4.5.2's static checks.
6557
6558 * fringe.c (update_window_fringes): Mark locals as initialized
6559 (Bug#8227).
6560 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6561
6562 * alloc.c (mark_fringe_data): Move decl from here ...
6563 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6564 to check its interface.
6565 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6566
6567 * fontset.c (free_realized_fontset): Now static.
6568 (Fset_fontset_font): Rename local to avoid shadowing.
6569 (fontset_font): Mark local as initialized.
6570 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6571
6572 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6573
6574 * xselect.c (x_disown_buffer_selections): Remove; not used.
6575 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6576 (x_own_selection, Fx_disown_selection_internal): Rename locals
6577 to avoid shadowing.
6578 (x_handle_dnd_message): Remove local to avoid shadowing.
6579
6580 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6581 so that the caller can use some name other than gcpro1.
6582 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6583 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6584 (Fx_backspace_delete_keys_p):
6585 Use them to avoid shadowing, and rename vars to avoid shadowing.
6586 (x_decode_color, x_set_name, x_window): Now static.
6587 (Fx_create_frame): Add braces to silence GCC warning.
6588 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6589 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6590 Remove unused locals.
6591 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6592 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6593 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6594 macros.
6595
6596 * xterm.h (x_mouse_leave): New decl.
6597
6598 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6599 Remove unused functions.
6600 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6601 (x_calc_absolute_position): Now static.
6602 (XTread_socket): Don't define label "out" unless it's used.
6603 Don't declare local "event" unless it's used.
6604 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6605 unless they are used.
6606 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6607 (x_fatal_error_signal): Remove; not used.
6608 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6609 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6610 (x_error_catcher, x_connection_closed, x_error_handler):
6611 (x_error_quitter, xembed_send_message, x_iconify_frame):
6612 (my_log_handler): Rename locals to avoid shadowing.
6613 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6614 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6615
6616 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6617 Rename or move locals to avoid shadowing.
6618 (tty_defined_color, merge_face_heights): Now static.
6619 (free_realized_faces_for_fontset): Remove; not used.
6620 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6621 does not deduce is never used uninitialized.
6622 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6623 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6624
6625 * terminal.c (store_terminal_param): Now static.
6626
6627 * xmenu.c (menu_highlight_callback): Now static.
6628 (set_frame_menubar): Remove unused local.
6629 (xmenu_show): Rename parameter to avoid shadowing.
6630 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6631 since they might point to immutable storage.
6632 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6633 since it's unused otherwise.
6634
6635 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6636 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6637 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6638 avoids a gcc -Wuninitialized diagnostic.
6639 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6640 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6641 does not deduce are never used uninitialized.
6642
6643 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6644
6645 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6646 * window.c (window_loop, size_window):
6647 (run_window_configuration_change_hook, enlarge_window): Likewise.
6648
6649 * window.c (display_buffer): Now static.
6650 (size_window): Mark variables that gcc -Wuninitialized
6651 does not deduce are never used uninitialized.
6652 * window.h (check_all_windows): New decl, to forestall
6653 gcc -Wmissing-prototypes diagnostic.
6654 * dispextern.h (bidi_dump_cached_states): Likewise.
6655
6656 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6657 shadowing.
6658 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6659 Include <limits.h>.
6660 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6661 and to avoid gcc -Wuninitialized warning.
6662 (load_charset_map): Mark variables that gcc -Wuninitialized
6663 does not deduce are never used uninitialized.
6664 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6665
6666 * coding.c (coding_set_source, coding_set_destination):
6667 Use "else { /* comment */ }" rather than "else /* comment */;"
6668 for clarity, and to avoid gcc -Wempty-body warning.
6669 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6670 a block, when the outer 'i' will do.
6671 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6672 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6673 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6674 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6675 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6676 Rename locals to avoid shadowing.
6677 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6678 * coding.c (emacs_mule_char, encode_invocation_designation):
6679 Now static, since they're not used elsewhere.
6680 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6681 (decode_coding_object, encode_coding_object, detect_coding_system):
6682 (decode_coding_emacs_mule): Mark variables that gcc
6683 -Wuninitialized does not deduce are never used uninitialized.
6684 (detect_coding_iso_2022): Initialize a local variable that might
6685 be used uninitialized. Leave a FIXME because it's not clear that
6686 this initialization is needed. (Bug#8211)
6687 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6688 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6689 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6690 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6691 Remove unused macros.
6692
6693 * category.c (hash_get_category_set): Remove unused local var.
6694 (copy_category_table): Now static, since it's not used elsewhere.
6695 * character.c (string_count_byte8): Likewise.
6696
6697 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6698 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6699
6700 * chartab.c (copy_sub_char_table): Now static, since it's not used
6701 elsewhere.
6702 (sub_char_table_ref_and_range, char_table_ref_and_range):
6703 Rename locals to avoid shadowing.
6704 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6705
6706 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6707 (BIDI_BOB): Remove unused macro.
6708
6709 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6710 deduce are never used uninitialized.
6711 * term.c (encode_terminal_code): Likewise.
6712
6713 * term.c (encode_terminal_code): Now static. Remove unused local.
6714
6715 * tparam.h: New file.
6716 * term.c, tparam.h: Include it.
6717 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6718 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6719 Move these decls to tparam.h, and make them agree with what
6720 is actually in tparam.c. The previous trick of using incompatible
6721 decls in different modules does not conform to the C standard.
6722 All callers of tparam changed to use tparam's actual API.
6723 * tparam.c (tparam1, tparam, tgoto):
6724 Use const pointers where appropriate.
6725
6726 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6727 * cm.h (struct cm): Likewise.
6728 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6729 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6730 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6731 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6732 (turn_on_face, init_tty): Likewise.
6733 * termchar.h (struct tty_display_info): Likewise.
6734
6735 * term.c (term_mouse_position): Rename local to avoid shadowing.
6736
6737 * alloc.c (mark_ttys): Move decl from here ...
6738 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6739
6740 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6741
6742 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6743
6744 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * search.c (compile_pattern_1): Remove argument regp, unused since
6747 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6748 (compile_pattern): Don't pass it.
6749
6750 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6751
6752 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6753 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6754 for ! HAVE_GTK3.
6755 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6756
6757 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6758
6759 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6760 gdk_window_get_screen, gdk_window_get_geometry,
6761 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6762 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6763 (xg_get_pixbuf_from_pixmap): New function.
6764 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6765 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6766 Call xg_get_pixbuf_from_pixmap instead of
6767 gdk_pixbuf_get_from_drawable.
6768 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6769 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6770 (xg_check_special_colors): Use GtkStyleContext and its functions
6771 for HAVE_GTK3.
6772 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6773 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6774 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6775 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6776 Call gtk_widget_get_preferred_size.
6777 (xg_frame_resized): gdk_window_get_geometry only takes 5
6778 parameters.
6779 (xg_win_to_widget, xg_event_is_for_menubar):
6780 Call gdk_x11_window_lookup_for_display.
6781 (xg_set_widget_bg): New function.
6782 (delete_cb): New function.
6783 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6784 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6785 (xg_set_background_color): Call xg_set_widget_bg.
6786 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6787 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6788 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6789 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6790 if ! HAVE_GTK3.
6791 (update_frame_tool_bar): Call gtk_widget_hide.
6792 (xg_initialize): Use GDK_KEY_g.
6793
6794 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6795 if ! HAVE_GTK3
6796 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6797
6798 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6799 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6800 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6801
6802 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * w32xfns.c (select_palette): Check success of RealizePalette against
6805 GDI_ERROR, not zero.
6806
6807 See ChangeLog.11 for earlier changes.
6808
6809 ;; Local Variables:
6810 ;; coding: utf-8
6811 ;; End:
6812
6813 Copyright (C) 2011 Free Software Foundation, Inc.
6814
6815 This file is part of GNU Emacs.
6816
6817 GNU Emacs is free software: you can redistribute it and/or modify
6818 it under the terms of the GNU General Public License as published by
6819 the Free Software Foundation, either version 3 of the License, or
6820 (at your option) any later version.
6821
6822 GNU Emacs is distributed in the hope that it will be useful,
6823 but WITHOUT ANY WARRANTY; without even the implied warranty of
6824 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6825 GNU General Public License for more details.
6826
6827 You should have received a copy of the GNU General Public License
6828 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.