]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2
3 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4
5 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6
7 * gtkutil.c (qttip_cb): Remove code without function.
8
9 2011-07-09 Eli Zaretskii <eliz@gnu.org>
10
11 * w32.c (pthread_sigmask): New stub.
12
13 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
14
15 Fix minor problems found by static checking (Bug#9031).
16 * chartab.c (char_table_set_range, map_sub_char_table)
17 (uniprop_table_uncompress): Remove unused locals.
18 (uniprop_table): Now static.
19 * composite.c (_work_char): Remove unused static var.
20 * gtkutil.c (qttip_cb): Remove stray no-effect statement.
21
22 Use pthread_sigmask, not sigprocmask (Bug#9010).
23 sigprocmask is portable only for single-threaded applications, and
24 Emacs can be multi-threaded when it uses GTK.
25 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
26 (LIBES): Use it.
27 * callproc.c (Fcall_process):
28 * process.c (create_process):
29 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
30 Use pthread_sigmask, not sigprocmask.
31
32 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
33
34 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
35 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
36 wrong (Bug#8591).
37
38 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
39
40 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
41 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
42 (xg_hide_tooltip): Fix comment.
43
44 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
45 in registerServicesMenuSendTypes.
46 (validRequestorForSendType): Don't check ns_return_types.
47
48 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
49 ns_return_type.
50
51 2011-07-08 Jason Rumney <jasonr@gnu.org>
52
53 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
54 frame struct members of non-existent frames (Bug#6284).
55
56 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
57
58 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
59 variable firstTime not needed on OSX >= 10.6.
60 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
61 >= 10.5. Use setKnobProportion, setDoubleValue.
62
63 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
64 (MAC_OS_X_VERSION_10_5): Define if not defined.
65 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
66 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
67 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
68
69 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
70 cString and lossyCString on OSX >= 10.4
71
72 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
73 sizeToFit on OSX >= 10.2.
74
75 * nsimage.m (allocInitFromFile): Don't use deprecated method
76 bestRepresentationForDevice on OSX >= 10.6.
77
78 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
79 to avoid warning.
80
81 * emacs.c: Declare unexec_init_emacs_zone.
82
83 * nsgui.h: Fix compiler warning about gnulib redefining verify.
84
85 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
86
87 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
88 on svcsMenu (Bug#8842).
89
90 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
91 ns_return_types.
92 (Fns_list_services): Just return Qnil on 10.6, code not working there.
93
94 * nsterm.m (QUTF8_STRING): Declare.
95 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
96 (validRequestorForSendType): Return type is (id).
97 Change indexOfObjectIdenticalTo to indexOfObject.
98 Check if we have local selection before returning self (Bug#8842).
99 (writeSelectionToPasteboard): Put local selection into paste board
100 if we have a local selection (Bug#8842).
101 (syms_of_nsterm): DEFSYM QUTF8_STRING.
102
103 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
104 (ns_get_local_selection): Declare.
105
106 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
107
108 * keymap.c (describe_map_tree): Don't insert a double newline at
109 the end of the buffer (bug#1169) and return whether we inserted
110 something.
111
112 * callint.c (Fcall_interactively): Change "reading args" to
113 "providing args" to try to clarify what it does (bug#1010).
114
115 2011-07-07 Kenichi Handa <handa@m17n.org>
116
117 * composite.c (composition_compute_stop_pos): Ignore a static
118 composition starting before CHARPOS (Bug#8915).
119
120 * xdisp.c (handle_composition_prop): Likewise.
121
122 2011-07-07 Eli Zaretskii <eliz@gnu.org>
123
124 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
125 (Bug#9015)
126
127 2011-07-07 Kenichi Handa <handa@m17n.org>
128
129 * character.h (unicode_category_t): New enum type.
130
131 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
132 (Qchar_code_property_table): New variable.
133 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
134 (UNIPROP_COMPRESSED_FORM_P): New macros.
135 (char_table_ascii): Uncompress the compressed values.
136 (sub_char_table_ref): New arg is_uniprop. Callers changed.
137 Uncompress the compressed values.
138 (sub_char_table_ref_and_range): Likewise.
139 (char_table_ref_and_range): Uncompress the compressed values.
140 (sub_char_table_set): New arg is_uniprop. Callers changed.
141 Uncompress the compressed values.
142 (sub_char_table_set_range): Args changed. Callers changed.
143 (char_table_set_range): Adjuted for the above change.
144 (map_sub_char_table): Delete args default_val and parent. Add arg
145 top. Give decoded values to a Lisp function.
146 (map_char_table): Adjusted for the above change. Give decoded
147 values to a Lisp function. Gcpro more variables.
148 (uniprop_table_uncompress)
149 (uniprop_decode_value_run_length): New functions.
150 (uniprop_decoder, uniprop_decoder_count): New variables.
151 (uniprop_get_decoder, uniprop_encode_value_character)
152 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
153 New functions.
154 (uniprop_encoder, uniprop_encoder_count): New variables.
155 (uniprop_get_encoder, uniprop_table)
156 (Funicode_property_table_internal, Fget_unicode_property_internal)
157 (Fput_unicode_property_internal): New functions.
158 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
159 Sunicode_property_table_internal, Sget_unicode_property_internal,
160 and Sput_unicode_property_internal. Defvar_lisp
161 char-code-property-alist.
162
163 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
164 Vunicode_category_table.
165
166 * font.c (font_range): Adjusted for the change of
167 Vunicode_category_table.
168
169 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
170
171 * m/iris4d.h: Remove file, move contents ...
172 * s/irix6-5.h: ... here.
173
174 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
175
176 Remove unportable assumption about struct layout (Bug#8884).
177 * alloc.c (mark_buffer):
178 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
179 (clone_per_buffer_values): Don't assume that
180 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
181 This isn't true in general, and it's particularly not true
182 if Emacs is configured with --with-wide-int.
183 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
184 New macros, used in the buffer.c change.
185
186 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
187
188 * xsettings.c: Use both GConf and GSettings if both are available.
189 (store_config_changed_event): Add comment.
190 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
191 (store_tool_bar_style_changed): New functions.
192 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
193 (struct xsettings): Move font inside HAVE_XFT.
194 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
195 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
196 Move inside HAVE_XFT.
197 (something_changed_gsettingsCB): Renamed from something_changedCB.
198 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
199 also.
200 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
201 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
202 (something_changed_gconfCB): Renamed from something_changedCB.
203 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
204 (parse_settings): Move check for font inside HAVE_XFT.
205 (read_settings, apply_xft_settings): Add comment.
206 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
207 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
208 call store_font_name_changed.
209 (xft_settings_event): Add comment.
210 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
211 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
212 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
213 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
214 (xsettings_initialize): Call init_gsettings last.
215 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
216 comment.
217
218 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
219
220 Random fixes. E.g., (random) never returned negative values.
221 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
222 subseconds part to the entropy, as that's a bit more random.
223 Prefer signed to unsigned, since the signedness doesn't matter and
224 in general we prefer signed. When given a limit, use a
225 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
226 latter isn't right if USE_2_TAGS_FOR_INTS.
227 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
228 not 0..VALMASK. Don't discard "excess" bits that random () returns.
229
230 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
231
232 * textprop.c (text_property_stickiness):
233 Obey Vtext_property_default_nonsticky.
234 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
235 * w32fns.c (syms_of_w32fns):
236 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
237
238 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
239
240 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
241 This is more efficient than Ffile_directory_p and avoids a minor race.
242
243 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
244
245 * buffer.c (Foverlay_put): Say what the return value is
246 (bug#7835).
247
248 * fileio.c (barf_or_query_if_file_exists): Check first if the file
249 is a directory before asking whether to use the file name
250 (bug#7564).
251 (barf_or_query_if_file_exists): Make the "File is a directory"
252 error be more correct.
253
254 * fns.c (Frequire): Remove the mention of the .gz files, since
255 that's installation-specific, but keep the mention of
256 `get-load-suffixes'.
257
258 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
259
260 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
261 Report string overflow if the output is too long.
262
263 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
264
265 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
266 (syms_of_gnutls): Remove duplicate DEFSYM for
267 Qgnutls_bootprop_verify_hostname_error, an error for
268 Qgnutls_bootprop_verify_error (which is no longer used).
269
270 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
271 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
272 Also (re)move comments that are misplaced or no longer relevant.
273
274 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
275
276 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
277
278 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
279
280 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
281 and background color parameters if they have been changed.
282
283 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
284
285 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
286
287 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
288
289 * xsettings.c (SYSTEM_FONT): Define only when used.
290 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
291
292 * keymap.c (access_keymap_1): Now static.
293
294 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
295
296 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
297 leave any prefix arg for the up event (Bug#1586).
298
299 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
300
301 * lread.c (syms_of_lread): Mention single symbols defined by
302 `defvar' or `defconst' (bug#7154).
303
304 * fns.c (Frequire): Mention .el.gz files (bug#7314).
305 (Frequire): Mention get-load-suffixes.
306
307 2011-07-02 Martin Rudalics <rudalics@gmx.at>
308
309 * window.h (window): Remove clone_number slot.
310 * window.c (Fwindow_clone_number, Fset_window_clone_number):
311 Remove.
312 (make_parent_window, make_window, saved_window)
313 (Fset_window_configuration, save_window_save): Don't deal with
314 clone numbers.
315 * buffer.c (Qclone_number): Remove declaration.
316 (sort_overlays, overlay_strings): Don't deal with clone numbers.
317
318 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
319
320 Add multiple inheritance to keymaps.
321 * keymap.c (Fmake_composed_keymap): New function.
322 (Fset_keymap_parent): Simplify.
323 (fix_submap_inheritance): Remove.
324 (access_keymap_1): New function extracted from access_keymap to handle
325 embedded parents and handle lists of maps.
326 (access_keymap): Use it.
327 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
328 (Fcopy_keymap): Handle embedded parents.
329 (Fcommand_remapping, define_as_prefix): Simplify.
330 (Fkey_binding): Simplify.
331 (syms_of_keymap): Move minibuffer-local-completion-map,
332 minibuffer-local-filename-completion-map,
333 minibuffer-local-must-match-map, and
334 minibuffer-local-filename-must-match-map to Elisp.
335 (syms_of_keymap): Defsubr make-composed-keymap.
336 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
337 (parse_menu_item): Trivial simplification.
338
339 2011-07-01 Glenn Morris <rgm@gnu.org>
340
341 * Makefile.in (SETTINGS_LIBS): Fix typo.
342
343 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
344
345 * coding.c (Fencode_coding_string): Record the last coding system
346 used, as the function doc string says (bug#8738).
347
348 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
349
350 * xsettings.c (store_monospaced_changed): Take new font as arg and
351 check for change against current_mono_font.
352 (EMACS_TYPE_SETTINGS): Remove this and related defines.
353 (emacs_settings_constructor, emacs_settings_get_property)
354 (emacs_settings_set_property, emacs_settings_class_init)
355 (emacs_settings_init, gsettings_obj): Remove.
356 (something_changedCB): New function for HAVE_GSETTINGS.
357 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
358 with value as argument.
359 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
360 g_settings_new (Bug#8967). Do not create gsettings_obj.
361 Remove calls to g_settings_bind. Connect something_changedCB to
362 "changed".
363
364 * xgselect.c: Add defined (HAVE_GSETTINGS).
365 (xgselect_initialize): Ditto.
366
367 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
368 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
369 xg_select.
370
371 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
372
373 * eval.c (struct backtrace): Simplify and port the data structure.
374 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
375 signed bit field, as this assumption is not portable and it makes
376 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
377 "char debug_on_exit : 1" as this is not portable either; instead,
378 use the portable "unsigned int debug_on_exit : 1". Remove unused
379 member evalargs. Remove obsolete comments about cc bombing out.
380
381 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
382
383 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
384 Let HAVE_GSETTINGS override HAVE_GCONF.
385 (store_monospaced_changed): New function.
386 (EMACS_SETTINGS): A new type derived from GObject to handle
387 GSettings notifications.
388 (emacs_settings_constructor, emacs_settings_get_property)
389 (emacs_settings_set_property, emacs_settings_class_init):
390 New functions.
391 (gsettings_client, gsettings_obj): New variables.
392 (GSETTINGS_SCHEMA): New define.
393 (something_changedCB): Call store_monospaced_changed.
394 (init_gsettings): New function.
395 (xsettings_initialize): Call init_gsettings.
396 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
397 to NULL.
398
399 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
400 GCONF_CFLAGS/LIBS.
401
402 2011-06-29 Martin Rudalics <rudalics@gmx.at>
403
404 * window.c (resize_root_window, grow_mini_window)
405 (shrink_mini_window): Rename Qresize_root_window to
406 Qwindow_resize_root_window and Qresize_root_window_vertically to
407 Qwindow_resize_root_window_vertically.
408
409 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
410
411 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
412
413 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
414
415 * makefile.w32-in: Redesign dependencies so they reflect more
416 clearly which files are directly included by each source file,
417 and not through other includes.
418
419 2011-06-27 Martin Rudalics <rudalics@gmx.at>
420
421 * buffer.c (Qclone_number): Declare static and DEFSYM it.
422 (sort_overlays, overlay_strings): When an overlay's clone number
423 matches the window's clone number process the overlay even if
424 the overlay's window property doesn't match the current window.
425
426 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
427 (Fwindow_hchild): Rename to Fwindow_left_child.
428 (Fwindow_next): Rename to Fwindow_next_sibling.
429 (Fwindow_prev): Rename to Fwindow_prev_sibling.
430 (resize_window_check): Rename to window_resize_check.
431 (resize_window_apply): Rename to window_resize_apply.
432 (Fresize_window_apply): Rename to Fwindow_resize_apply.
433 (Fdelete_other_windows_internal, resize_frame_windows)
434 (Fsplit_window_internal, Fdelete_window_internal)
435 (grow_mini_window, shrink_mini_window)
436 (Fresize_mini_window_internal): Fix callers accordingly.
437
438 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
439
440 * emacsgtkfixed.h: State that this is only used with Gtk+3.
441 (emacs_fixed_set_min_size): Remove.
442 (emacs_fixed_new): Take frame as argument.
443
444 * emacsgtkfixed.c: State that this is only used with Gtk+3.
445 (_EmacsFixedPrivate): Remove minwidth/height.
446 Add struct frame *f.
447 (emacs_fixed_init): Initialize priv->f.
448 (get_parent_class, emacs_fixed_set_min_size): Remove.
449 (emacs_fixed_new): Set priv->f to argument.
450 (emacs_fixed_get_preferred_width)
451 (emacs_fixed_get_preferred_height): Use min_width/height from
452 frames size_hint to set minimum and natural (Bug#8919).
453 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
454 and use min_width/height from frames size_hint to set
455 min_width/height (Bug#8919).
456
457 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
458 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
459 Fix indentation.
460
461 2011-06-26 Eli Zaretskii <eliz@gnu.org>
462
463 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
464 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
465 called at ZV.
466
467 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
468
469 * process.c (wait_reading_process_output): Bypass select if
470 waiting for a cell while ignoring keyboard input, and input is
471 pending. Suggested by Jan Djärv (Bug#8869).
472
473 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
474
475 Use gnulib's dup2 module instead of rolling our own.
476 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
477
478 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
479
480 * dispnew.c (scrolling_window): Before scrolling, turn off a
481 mouse-highlight in the window being scrolled.
482
483 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
484
485 Move DEFSYM to lisp.h and use everywhere.
486
487 * character.h (DEFSYM): Move declaration...
488 * lisp.h (DEFSYM): ...here.
489
490 * gnutls.c:
491 * minibuf.c:
492 * w32menu.c:
493 * w32proc.c:
494 * w32select.c: Don't include character.h.
495
496 * alloc.c (syms_of_alloc):
497 * buffer.c (syms_of_buffer):
498 * bytecode.c (syms_of_bytecode):
499 * callint.c (syms_of_callint):
500 * casefiddle.c (syms_of_casefiddle):
501 * casetab.c (init_casetab_once):
502 * category.c (init_category_once, syms_of_category):
503 * ccl.c (syms_of_ccl):
504 * cmds.c (syms_of_cmds):
505 * composite.c (syms_of_composite):
506 * dbusbind.c (syms_of_dbusbind):
507 * dired.c (syms_of_dired):
508 * dispnew.c (syms_of_display):
509 * doc.c (syms_of_doc):
510 * editfns.c (syms_of_editfns):
511 * emacs.c (syms_of_emacs):
512 * eval.c (syms_of_eval):
513 * fileio.c (syms_of_fileio):
514 * fns.c (syms_of_fns):
515 * frame.c (syms_of_frame):
516 * fringe.c (syms_of_fringe):
517 * insdel.c (syms_of_insdel):
518 * keymap.c (syms_of_keymap):
519 * lread.c (init_obarray, syms_of_lread):
520 * macros.c (syms_of_macros):
521 * msdos.c (syms_of_msdos):
522 * print.c (syms_of_print):
523 * process.c (syms_of_process):
524 * search.c (syms_of_search):
525 * sound.c (syms_of_sound):
526 * syntax.c (init_syntax_once, syms_of_syntax):
527 * terminal.c (syms_of_terminal):
528 * textprop.c (syms_of_textprop):
529 * undo.c (syms_of_undo):
530 * w32.c (globals_of_w32):
531 * window.c (syms_of_window):
532 * xdisp.c (syms_of_xdisp):
533 * xfaces.c (syms_of_xfaces):
534 * xfns.c (syms_of_xfns):
535 * xmenu.c (syms_of_xmenu):
536 * xsettings.c (syms_of_xsettings):
537 * xterm.c (syms_of_xterm): Use DEFSYM.
538
539 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
540
541 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
542
543 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
544
545 Integer and buffer overflow fixes (Bug#8873).
546
547 * print.c (printchar, strout): Check for string overflow.
548 (PRINTPREPARE, printchar, strout):
549 Don't set size unless allocation succeeds.
550
551 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
552 for sizes. Check for string overflow more accurately.
553 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
554
555 * macros.c: Integer and buffer overflow fixes.
556 * keyboard.h (struct keyboard.kbd_macro_bufsize):
557 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
558 Use ptrdiff_t, not int, for sizes.
559 Don't increment bufsize until after realloc succeeds.
560 Check for size-calculation overflow.
561 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
562
563 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
564
565 * lread.c: Integer overflow fixes.
566 (read_integer): Radix is now EMACS_INT, not int,
567 to improve quality of diagnostics for out-of-range radices.
568 Calculate buffer size correctly for out-of-range radices.
569 (read1): Check for integer overflow in radices, and in
570 read-circle numbers.
571 (read_escape): Avoid int overflow.
572 (Fload, openp, read_buffer_size, read1)
573 (substitute_object_recurse, read_vector, read_list, map_obarray):
574 Use ptrdiff_t, not int, for sizes.
575 (read1): Use EMACS_INT, not int, for sizes.
576 Check for size overflow.
577
578 * image.c (cache_image): Check for size arithmetic overflow.
579
580 * lread.c: Integer overflow issues.
581 (saved_doc_string_size, saved_doc_string_length)
582 (prev_saved_doc_string_size, prev_saved_doc_string_length):
583 Now ptrdiff_t, not int.
584 (read1): Don't assume doc string length fits in int. Check for
585 out-of-range doc string lengths.
586 (read_list): Don't assume file position fits in int.
587 (read_escape): Check for hex character overflow.
588
589 2011-06-22 Leo Liu <sdl.web@gmail.com>
590
591 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
592 Move to minibuffer.el.
593
594 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
595
596 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
597 The following patches are for when GLYPH_DEBUG && !XASSERT.
598 * dispextern.h (trace_redisplay_p, dump_glyph_string):
599 * dispnew.c (flush_stdout):
600 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
601 Mark as externally visible.
602 * dispnew.c (check_window_matrix_pointers): Now static.
603 * dispnew.c (window_to_frame_vpos):
604 * xfns.c (unwind_create_frame):
605 * xterm.c (x_check_font): Remove unused local.
606 * scroll.c (CHECK_BOUNDS):
607 * xfaces.c (cache_fache): Rename local to avoid shadowing.
608 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
609 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
610 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
611 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
612 Now static.
613 (debug_method_add): Use va_list and vsprintf rather than relying
614 on undefined behavior with wrong number of arguments.
615 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
616 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
617 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
618 since we're not interested in debugging glyphs with old libraries.
619 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
620 GCC 4.6.0's static checking.
621
622 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
623
624 Integer overflow and signedness fixes (Bug#8873).
625 A few related buffer overrun fixes, too.
626
627 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
628
629 * dispextern.h (struct face.stipple):
630 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
631 (x_bitmap_mask, x_allocate_bitmap_record)
632 (x_create_bitmap_from_data, x_create_bitmap_from_file)
633 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
634 (x_create_bitmap_from_xpm_data):
635 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
636 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
637 (.bitmaps_last):
638 * xfaces.c (load_pixmap):
639 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
640 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
641 (.bitmaps_last, struct x_output.icon_bitmap):
642 Use ptrdiff_t, not int, for bitmap indexes.
643 (x_allocate_bitmap_record): Check for size overflow.
644 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
645
646 Use ptrdiff_t, not int, for overlay counts.
647 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
648 * editfns.c (overlays_around, get_pos_property):
649 * textprop.c (get_char_property_and_overlay):
650 * xdisp.c (next_overlay_change, note_mouse_highlight):
651 * xfaces.c (face_at_buffer_position):
652 * buffer.c (OVERLAY_COUNT_MAX): New macro.
653 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
654 (Fnext_overlay_change, Fprevious_overlay_change)
655 (mouse_face_overlay_overlaps, Foverlays_in):
656 Use ptrdiff_t, not int, for sizes.
657 (overlays_at, overlays_in): Check for size-calculation overflow.
658
659 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
660
661 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
662 (x_session_initialize): Do not assume string length fits in int.
663
664 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
665 This is unlikely, but can occur if DPI is outlandish.
666
667 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
668 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
669
670 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
671 * xrdb.c (magic_file_p, search_magic_path):
672 Omit last arg SUFFIX; it was always 0. All callers changed.
673 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
674
675 * xfont.c (xfont_match): Avoid need for strlen.
676
677 * xfns.c: Don't assume strlen fits in int.
678 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
679
680 * xdisp.c (message_log_check_duplicate): Return intmax_t,
681 not unsigned long, as we prefer signed integers. All callers changed.
682 Detect integer overflow in repeat count.
683 (message_dolog): Don't assume print length fits in 39 bytes.
684 (display_mode_element): Don't assume strlen fits in int.
685
686 * termcap.c: Don't assume sizes fit in int and never overflow.
687 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
688 (gobble_line): Check for size-calculation overflow.
689
690 * minibuf.c (Fread_buffer):
691 * lread.c (intern, intern_c_string):
692 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
693 Don't assume string length fits in int.
694
695 * keyboard.c (parse_tool_bar_item):
696 * gtkutil.c (style_changed_cb): Avoid need for strlen.
697
698 * font.c: Don't assume string length fits in int.
699 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
700 Use ptrdiff_t, not int.
701 (font_intern_prop): Don't assume string length fits in int.
702 Don't assume integer property fits in fixnum.
703 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
704
705 * filelock.c: Fix some buffer overrun and integer overflow issues.
706 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
707 Reformulate so as not to need the command string.
708 Invoke gzip -cd rather than gunzip, as it's more portable.
709 (lock_info_type, lock_file_1, lock_file):
710 Don't assume pid_t and time_t fit in unsigned long.
711 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
712 (current_lock_owner): Prefer signed type for sizes.
713 Use memcpy, not strncpy, where memcpy is what is really wanted.
714 Don't assume (via atoi) that time_t and pid_t fit in int.
715 Check for time_t and/or pid_t out of range, e.g., via a network share.
716 Don't alloca where an auto var works fine.
717
718 * fileio.c: Fix some integer overflow issues.
719 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
720 Don't assume string length fits in int.
721 (directory_file_name): Don't assume string length fits in long.
722 (make_temp_name): Don't assume pid fits in int, or that its print
723 length is less than 20.
724
725 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
726
727 * coding.c (make_subsidiaries): Don't assume string length fits in int.
728
729 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
730
731 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
732 We prefer signed integers, even for size calculations.
733
734 * emacs.c: Don't assume string length fits in 'int'.
735 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
736 (main): Don't invoke strlen when not needed.
737
738 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
739 (XD_DEBUG_MESSAGE): Don't waste a byte.
740
741 * callproc.c (getenv_internal_1, getenv_internal)
742 (Fgetenv_internal):
743 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
744
745 * lread.c (invalid_syntax): Omit length argument.
746 All uses changed. This doesn't fix a bug, but it simplifies the
747 code away from its former Hollerith-constant appearance, and it's
748 one less 'int' to worry about when looking at integer-overflow issues.
749 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
750
751 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
752 This didn't break anything, but it didn't help either.
753 It's confusing to put a bogus integer in a place where the actual
754 value does not matter.
755 (LIST_END_P): Remove unused macro and its bogus comment.
756 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
757
758 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
759 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
760 implementation.
761 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
762 We prefer signed types, and the value cannot exceed the EMACS_INT
763 range anyway (because otherwise the length would not be representable).
764 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
765 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
766 This avoids a GCC warning when WIDE_EMACS_INT.
767
768 * indent.c (sane_tab_width): New function.
769 (current_column, scan_for_column, Findent_to, position_indentation)
770 (compute_motion): Use it. This is just for clarity.
771 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
772
773 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
774
775 * lisp.h (lint_assume): New macro.
776 * composite.c (composition_gstring_put_cache):
777 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
778
779 * editfns.c, insdel.c:
780 Omit unnecessary forward decls, to simplify future changes.
781
782 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
783
784 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
785
786 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
787 Use much-faster test for byte-length change.
788 Don't assume string byte-length fits in 'int'.
789 Check that character arg fits in 'int'.
790 (mapcar1): Declare byte as byte, for clarity.
791
792 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
793
794 * fns.c (concat): Catch string overflow earlier.
795 Do not rely on integer wraparound.
796
797 * dispextern.h (struct it.overlay_strings_charpos)
798 (struct it.selective): Now EMACS_INT, not int.
799 * xdisp.c (forward_to_next_line_start)
800 (back_to_previous_visible_line_start)
801 (reseat_at_next_visible_line_start, next_element_from_buffer):
802 Don't arbitrarily truncate the value of 'selective' to int.
803
804 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
805
806 * composite.c: Don't truncate sizes to 'int'.
807 (composition_gstring_p, composition_reseat_it)
808 (composition_adjust_point): Use EMACS_INT, not int.
809 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
810 not EMACS_UINT, for indexes.
811
812 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
813
814 * buffer.c: Include <verify.h>.
815 (struct sortvec.priority, struct sortstr.priority):
816 Now EMACS_INT, not int.
817 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
818 (struct sortstr.size, record_overlay_string)
819 (struct sortstrlist.size, struct sortlist.used):
820 Don't truncate size to int.
821 (record_overlay_string): Check for size-calculation overflow.
822 (init_buffer_once): Check at compile-time, not run-time.
823
824 2011-06-22 Jim Meyering <meyering@redhat.com>
825
826 Don't leak an XBM-image-sized buffer
827 * image.c (xbm_load): Free the image buffer after using it.
828
829 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
830
831 Port to Sun C.
832 * composite.c (find_automatic_composition): Omit needless 'return 0;'
833 that Sun C diagnosed.
834 * fns.c (secure_hash): Fix pointer signedness issue.
835 * intervals.c (static_offset_intervals): New function.
836 (offset_intervals): Use it.
837
838 2011-06-21 Leo Liu <sdl.web@gmail.com>
839
840 * deps.mk (fns.o):
841 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
842 sha512.h.
843
844 * fns.c (secure_hash): Rename from crypto_hash_function and change
845 the first arg to accept symbols.
846 (Fsecure_hash): New primitive.
847 (syms_of_fns): New symbols.
848
849 2011-06-20 Deniz Dogan <deniz@dogan.se>
850
851 * process.c (Fset_process_buffer): Clarify return value in
852 docstring.
853
854 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
855
856 * dispnew.c (add_window_display_history): Use BVAR.
857
858 * xdisp.c (debug_method_add): Use BVAR.
859 (check_window_end, dump_glyph_matrix, dump_glyph)
860 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
861
862 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
863 Likewise.
864
865 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
866 check till after the cache is created in init_frame_faces.
867
868 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
869
870 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
871
872 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
873
874 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
875 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
876 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
877
878 Improve buffer-overflow checking (Bug#8873).
879 * fileio.c (Finsert_file_contents):
880 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
881 Remove the old (too-loose) buffer overflow checks.
882 They weren't needed, since make_gap checks for buffer overflow.
883 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
884 The old code merely checked for Emacs fixnum overflow, and relied
885 on undefined (wraparound) behavior. The new code avoids undefined
886 behavior, and also checks for ptrdiff_t and/or size_t overflow.
887
888 * editfns.c (Finsert_char): Don't dump core with very negative counts.
889 Tune. Don't use wider integers than needed. Don't use alloca.
890 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
891
892 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
893
894 * insdel.c, lisp.h (buffer_overflow): New function.
895 (insert_from_buffer_1, replace_range, replace_range_2):
896 * insdel.c (make_gap_larger):
897 * editfns.c (Finsert_char):
898 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
899
900 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
901
902 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
903
904 Integer overflow and signedness fixes (Bug#8873).
905
906 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
907 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
908
909 * fileio.c: Don't assume EMACS_INT fits in off_t.
910 (emacs_lseek): New static function.
911 (Finsert_file_contents, Fwrite_region): Use it.
912 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
913
914 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
915
916 * fns.c: Don't overflow int when computing a list length.
917 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
918 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
919 truncation on 64-bit hosts. Check for QUIT every
920 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
921 faster and is responsive enough.
922 (Flength): Report an error instead of overflowing an integer.
923 (Fsafe_length): Return a float if the value is not representable
924 as a fixnum. This shouldn't happen except in contrived situations.
925 (Fnthcdr, Fsort): Don't assume list length fits in int.
926 (Fcopy_sequence): Don't assume vector length fits in int.
927
928 * alloc.c: Check that resized vectors' lengths fit in fixnums.
929 (header_size, word_size): New constants.
930 (allocate_vectorlike): Don't check size overflow here.
931 (allocate_vector): Check it here instead, since this is the only
932 caller of allocate_vectorlike that could cause overflow.
933 Check that the new vector's length is representable as a fixnum.
934
935 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
936 The previous code was bogus. For example, next_almost_prime (32)
937 returned 39, which is undesirable as it is a multiple of 3; and
938 next_almost_prime (24) returned 25, which is a multiple of 5 so
939 why was the code bothering to check for multiples of 7?
940
941 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
942
943 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
944
945 Variadic C functions now count arguments with ptrdiff_t.
946 This partly undoes my 2011-03-30 change, which replaced int with size_t.
947 Back then I didn't know that the Emacs coding style prefers signed int.
948 Also, in the meantime I found a few more instances where arguments
949 were being counted with int, which may truncate counts on 64-bit
950 machines, or EMACS_INT, which may be unnecessarily wide.
951 * lisp.h (struct Lisp_Subr.function.aMANY)
952 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
953 Arg counts are now ptrdiff_t, not size_t.
954 All variadic functions and their callers changed accordingly.
955 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
956 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
957 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
958 * callint.c (Fcall_interactively): Check arg count for overflow,
959 to avoid potential buffer overrun. Use signed char, not 'int',
960 for 'varies' array, so that we needn't bother to check its size
961 calculation for overflow.
962 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
963 * eval.c (apply_lambda):
964 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
965 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
966 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
967
968 * callint.c (Fcall_interactively): Don't use index var as event count.
969
970 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
971 * mem-limits.h (SIZE): Remove; no longer used.
972
973 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
974
975 Remove unnecessary casts.
976 * xterm.c (x_term_init):
977 * xfns.c (x_set_border_pixel):
978 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
979 These aren't needed now that we assume ANSI C.
980
981 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
982 It's more likely to cause problems (due to unsigned overflow)
983 than to cure them.
984
985 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
986
987 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
988
989 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
990
991 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
992
993 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
994
995 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
996
997 GLYPH_CODE_FACE returns EMACS_INT, not int.
998 * dispextern.h (merge_faces):
999 * xfaces.c (merge_faces):
1000 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1001 Don't assume EMACS_INT fits in int.
1002
1003 * character.h (CHAR_VALID_P): Remove unused parameter.
1004 * fontset.c, lisp.h, xdisp.c: All uses changed.
1005
1006 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1007
1008 * fns.c (concat): Minor tuning based on overflow analysis.
1009 This doesn't fix any bugs. Use int to hold character, instead
1010 of constantly refetching from Emacs object. Use XFASTINT, not
1011 XINT, for value known to be a character. Don't bother comparing
1012 a single byte to 0400, as it's always less.
1013
1014 * floatfns.c (Fexpt):
1015 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1016
1017 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1018 for characters.
1019
1020 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1021
1022 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1023 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1024 incorrectly succeed when S was a string, because 4294967386 was
1025 truncated before it was used.
1026
1027 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1028 Otherwise, an out-of-range integer could cause undefined behavior
1029 on a 64-bit host.
1030
1031 * composite.c: Use int, not EMACS_INT, for characters.
1032 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1033 EMACS_INT, for values that are known to be in character range.
1034 This doesn't fix any bugs but is the usual style inside Emacs and
1035 may generate better code on 32-bit machines.
1036
1037 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1038 This is for reasons similar to the recent CHAR_STRING fix.
1039 * charset.c (Fencode_char): Check that character arg is actually
1040 a character. Pass an int to ENCODE_CHAR.
1041 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1042 wider than 'int', as a compile-time check to prevent future regressions
1043 in this area.
1044
1045 * character.c (char_string): Remove unnecessary casts.
1046
1047 Make sure a 64-bit char is never passed to CHAR_STRING.
1048 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1049 by silently ignoring the top 32 bits, allowing some values
1050 that were far too large to be valid characters.
1051 * character.h: Include <verify.h>.
1052 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1053 arguments are no wider than unsigned, as a compile-time check
1054 to prevent future regressions in this area.
1055 * data.c (Faset):
1056 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1057 (Fsubst_char_in_region):
1058 * fns.c (concat):
1059 * xdisp.c (decode_mode_spec_coding):
1060 Adjust to CHAR_STRING's new requirement.
1061 * editfns.c (Finsert_char, Fsubst_char_in_region):
1062 * fns.c (concat): Check that character args are actually
1063 characters. Without this test, these functions did the wrong
1064 thing with wildly out-of-range values on 64-bit hosts.
1065
1066 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1067 These casts should not be needed on 32-bit hosts, either.
1068 * keyboard.c (read_char):
1069 * lread.c (Fload): Remove casts to unsigned.
1070
1071 * lisp.h (UNSIGNED_CMP): New macro.
1072 This fixes comparison bugs on 64-bit hosts.
1073 (ASCII_CHAR_P): Use it.
1074 * casefiddle.c (casify_object):
1075 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1076 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1077 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1078 * dispextern.h (FACE_FROM_ID):
1079 * keyboard.c (read_char): Use UNSIGNED_CMP.
1080
1081 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1082 not to EMACS_INT, to avoid GCC warning.
1083
1084 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1085
1086 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1087 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1088 isn't needed on 32-bit machines.
1089
1090 * buffer.c (Fgenerate_new_buffer_name):
1091 Use EMACS_INT for count, not int.
1092 (advance_to_char_boundary): Return EMACS_INT, not int.
1093
1094 * data.c (Qcompiled_function): Now static.
1095
1096 * window.c (window_body_lines): Now static.
1097
1098 * image.c (gif_load): Rename local to avoid shadowing.
1099
1100 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1101 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1102 * alloc.c (make_save_value): Integer argument is now of type
1103 ptrdiff_t, not int.
1104 (mark_object): Use ptrdiff_t, not int.
1105 * lisp.h (pD): New macro.
1106 * print.c (print_object): Use it.
1107
1108 * alloc.c: Use EMACS_INT, not int, to count objects.
1109 (total_conses, total_markers, total_symbols, total_vector_size)
1110 (total_free_conses, total_free_markers, total_free_symbols)
1111 (total_free_floats, total_floats, total_free_intervals)
1112 (total_intervals, total_strings, total_free_strings):
1113 Now EMACS_INT, not int. All uses changed.
1114 (Fgarbage_collect): Compute overall total using a double, so that
1115 integer overflow is less likely to be a problem. Check for overflow
1116 when converting back to an integer.
1117 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1118 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1119 These were 'int' variables that could overflow on 64-bit hosts;
1120 they were never used, so remove them instead of repairing them.
1121 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1122 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1123 Previously, this ceilinged at INT_MAX, but that doesn't work on
1124 64-bit machines.
1125 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1126
1127 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1128 (allocate_vectorlike): Check for ptrdiff_t overflow.
1129 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1130 when a (possibly-narrower) signed value would do just as well.
1131 We prefer using signed arithmetic, to avoid comparison confusion.
1132
1133 * alloc.c: Catch some string size overflows that we were missing.
1134 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1135 for convenience in STRING_BYTES_MAX.
1136 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1137 The definition here is exact; the one in lisp.h was approximate.
1138 (allocate_string_data): Check for string overflow. This catches
1139 some instances we weren't catching before. Also, it catches
1140 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1141 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1142 and ptrdiff_t and EMACS_INT are both 64 bits.
1143
1144 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1145 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1146 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1147
1148 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1149
1150 * alloc.c (Fmake_string): Check for out-of-range init.
1151
1152 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1153
1154 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1155
1156 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1157
1158 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1159 xg_get_default_scrollbar_width.
1160
1161 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1162 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1163 (style_changed_cb): Call update_theme_scrollbar_width and call
1164 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1165 all frames (Bug#8505).
1166 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1167 Call gtk_window_set_resizable if HAVE_GTK3.
1168 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1169 and height if HAVE_GTK3 (Bug#8505).
1170 (scroll_bar_width_for_theme): New variable.
1171 (update_theme_scrollbar_width): New function.
1172 (xg_get_default_scrollbar_width): Move code to
1173 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1174 (xg_initialize): Call update_theme_scrollbar_width.
1175
1176 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1177
1178 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1179
1180 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1181
1182 * frame.c (make_frame): Call other_buffer_safely instead of
1183 other_buffer.
1184
1185 * window.c (temp_output_buffer_show): Call display_buffer with
1186 second argument Vtemp_buffer_show_specifiers and reset latter
1187 immediately after the call.
1188 (Vtemp_buffer_show_specifiers): New variable.
1189 (auto_window_vscroll_p, next_screen_context_lines)
1190 (Vscroll_preserve_screen_position): Remove leading asterisks from
1191 doc-strings.
1192
1193 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 Fix minor problems found by GCC 4.6.0 static checking.
1196 * buffer.c (Qclone_number): Remove for now, as it's unused.
1197 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1198 (record_buffer): Remove unused local.
1199 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1200 (set_frame_buffer_list): Remove; unused.
1201 * frame.h (other_visible_frames): Remove decl.
1202 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1203 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1204 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1205 if HAVE_GPM.
1206 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1207 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1208 Define only if HAVE_GPM.
1209 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1210 (update_hints_inhibit): Remove; never set. All uses removed.
1211 * widgetprv.h (emacsFrameClassRec): Remove decl.
1212 * window.c (delete_deletable_window): Now returns void, since it
1213 wasn't returning anything.
1214 (compare_window_configurations): Remove unused locals.
1215 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1216 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1217 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1218 the same widths as pointers. This follows up on the 2011-05-06 patch.
1219 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1220 * xterm.h: Likewise.
1221 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1222
1223 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * makefile.w32-in: Update dependencies.
1226 (LISP_H): Add lib/intprops.h.
1227
1228 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1229
1230 * image.c (gif_load): Add animation frame delay to the metadata.
1231 (syms_of_image): Use DEFSYM. New symbol `delay'.
1232
1233 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1234
1235 * window.c (delete_deletable_window): Re-add.
1236 (Fset_window_configuration): Rewrite to handle dead buffers and
1237 consequently deletable windows.
1238 (window_tree, Fwindow_tree): Remove. Supply functionality in
1239 window.el.
1240 (compare_window_configurations): Simplify code.
1241
1242 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * image.c (imagemagick_load_image): Fix type mismatch.
1245 (Fimagemagick_types): Likewise.
1246
1247 * window.h (replace_buffer_in_windows): Declare.
1248
1249 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1250
1251 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1252 Qclone_number. Remove external declaration of Qdelete_window.
1253 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1254 code.
1255 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1256 Qbuffer_list_update_hook if allowed.
1257 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1258 buffer list implementation.
1259 (other_buffer_safely): New function.
1260 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1261 calls to replace_buffer_in_windows and
1262 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1263 if allowed.
1264 (record_buffer): Inhibit quitting and rewrite using quittable
1265 functions. Run Qbuffer_list_update_hook if allowed.
1266 (Frecord_buffer, Funrecord_buffer): New functions.
1267 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1268 switch-to-buffer to window.el.
1269 (bury-buffer): Move to window.el.
1270 (Vbuffer_list_update_hook): New variable.
1271
1272 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1273 section.
1274
1275 * window.h (resize_frame_windows): Move up in code.
1276 (Fwindow_frame): Remove EXFUN.
1277 (replace_buffer_in_all_windows): Remove prototype.
1278 (replace_buffer_in_windows_safely): Add prototype.
1279
1280 * window.c: Declare Qdelete_window static again. Move down
1281 declaration of select_count.
1282 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1283 (Fother_window): Move to window.el.
1284 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1285 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1286 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1287 window.el.
1288 (replace_buffer_in_windows): Implement by calling
1289 Qreplace_buffer_in_windows.
1290 (replace_buffer_in_all_windows): Remove with some functionality
1291 moved into replace_buffer_in_windows_safely.
1292 (replace_buffer_in_windows_safely): New function.
1293 (select_window_norecord, select_frame_norecord): Move in front
1294 of run_window_configuration_change_hook. Remove now obsolete
1295 declarations.
1296 (Fset_window_buffer): Rewrite doc-string. Call
1297 Qrecord_window_buffer.
1298 (keys_of_window): Move binding for other-window to window.el.
1299
1300 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1301
1302 * dispextern.h (struct image): Replace data member, whose int_val
1303 and ptr_val fields were not used by anything, with a single
1304 lisp_val object.
1305
1306 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1307 (gif_clear_image, gif_load, imagemagick_load_image)
1308 (gs_clear_image, gs_load): Callers changed.
1309
1310 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * buffer.h: Include <time.h>, for time_t.
1313 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1314
1315 Fix minor problems found by static checking.
1316
1317 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1318
1319 Make identifiers static if they are not used in other modules.
1320 * data.c (Qcompiled_function, Qframe, Qvector):
1321 * image.c (QimageMagick, Qsvg):
1322 * minibuf.c (Qmetadata):
1323 * window.c (resize_window_check, resize_root_window): Now static.
1324 * window.h (resize_window_check, resize_root_window): Remove decls.
1325
1326 * window.c (window_deletion_count, delete_deletable_window):
1327 Remove; unused.
1328 (window_body_lines): Now static.
1329 (Fdelete_other_windows_internal): Mark vars as initialized.
1330 Make sure 'resize_failed' is initialized.
1331 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1332 (resize_window_apply): Remove unused local.
1333 * window.h (delete_deletable_window): Remove decl.
1334
1335 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1336 (imagemagick_load_image): Fix pointer signedness problem by changing
1337 last arg from unsigned char * to char *. All uses changed.
1338 Also, fix a local for similar reasons.
1339 Remove unused locals. Remove locals to avoid shadowing.
1340 (fn_rsvg_handle_free): Remove; unused.
1341 (svg_load, svg_load_image): Fix pointer signedness problem.
1342 (imagemagick_load_image): Don't use garbage pointer image_wand.
1343
1344 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1345
1346 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * image.c (gif_load): Fix omitted cast error introduced by
1349 2011-06-06 change.
1350
1351 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1352
1353 * window.h (resize_proportionally, orig_total_lines)
1354 (orig_top_line): Remove from window structure.
1355 (set_window_height, set_window_width, change_window_heights)
1356 (Fdelete_window): Remove prototypes.
1357 (resize_frame_windows): Remove duplicate declaration.
1358
1359 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1360
1361 * window.h (resize_frame_windows, resize_window_check)
1362 (delete_deletable_window, resize_root_window)
1363 (resize_frame_windows): Declare prototypes.
1364
1365 * window.c (resize_window_apply): Make definition be "static" to
1366 match the prototype.
1367
1368 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1369
1370 * window.c: Remove declarations of Qwindow_size_fixed,
1371 window_min_size_1, window_min_size_2, window_min_size,
1372 size_window, window_fixed_size_p, enlarge_window, delete_window.
1373 Remove static from declaration of Qdelete_window, it's
1374 temporarily needed by Fbury_buffer.
1375 (replace_window): Don't assign orig_top_line and
1376 orig_total_lines.
1377 (Fdelete_window, delete_window): Remove. Window deletion is
1378 handled by window.el.
1379 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1380 Fdelete_window calls with calls to Qdelete_window.
1381 (Fdelete_other_windows): Remove. Deleting other windows is
1382 handled by window.el.
1383 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1384 handled in window.el.
1385 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1386 Window minimum sizes are handled in window.el.
1387 (shrink_windows, size_window, set_window_height)
1388 (set_window_width, change_window_heights, window_height)
1389 (window_width, CURBEG, CURSIZE, enlarge_window)
1390 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1391 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1392 handled in window.el.
1393 (make_dummy_parent): Rename to make_parent_window and give it a
1394 second argument horflag.
1395 (make_window): Don't set resize_proportionally any more.
1396 (Fsplit_window): Remove. Windows are split in window.el.
1397 (save_restore_action, save_restore_orig_size)
1398 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1399 Resize mini windows in window.el.
1400 (grow_mini_window, shrink_mini_window): Implement by calling
1401 Qresize_root_window_vertically, resize_window_check and
1402 resize_window_apply.
1403 (saved_window, Fset_window_configuration, save_window_save): Do
1404 not handle orig_top_line, orig_total_lines, and
1405 resize_proportionally.
1406 (window_min_height, window_min_width): Move to window.el.
1407 (keys_of_window): Move bindings for delete-other-windows,
1408 split-window, delete-window and enlarge-window to window.el.
1409
1410 * buffer.c: Temporarily extern Qdelete_window.
1411 (Fbury_buffer): Temporarily call Qdelete_window instead of
1412 Fdelete_window (Fbury_buffer will move to window.el soon).
1413
1414 * frame.c (set_menu_bar_lines_1): Remove code handling
1415 orig_top_line and orig_total_lines.
1416
1417 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1418 set_window_height but set heights directly.
1419 (change_frame_size_1): Use resize_frame_windows.
1420
1421 * xdisp.c (init_xdisp): Don't use set_window_height but set
1422 heights directly.
1423
1424 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1425 resize_frame_windows instead of change_window_heights and run
1426 run_window_configuration_change_hook.
1427
1428 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1429 instead of change_window_heights and run
1430 run_window_configuration_change_hook.
1431
1432 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1433
1434 * window.c (replace_window): Rename second argument REPLACEMENT to
1435 NEW. New third argument SETFLAG. Rewrite.
1436 (delete_window, make_dummy_parent): Call replace_window with
1437 third argument 1.
1438 (window_list_1): Move down in code.
1439 (run_window_configuration_change_hook): Move set_buffer part
1440 before select_frame_norecord part in order to unwind correctly.
1441 Rename count1 to count.
1442 (recombine_windows, delete_deletable_window, resize_root_window)
1443 (Fdelete_other_windows_internal)
1444 (Frun_window_configuration_change_hook, make_parent_window)
1445 (resize_window_check, resize_window_apply, Fresize_window_apply)
1446 (resize_frame_windows, Fsplit_window_internal)
1447 (Fdelete_window_internal, Fresize_mini_window_internal): New
1448 functions.
1449 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1450
1451 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1452
1453 * window.h (window): Add some new members to window structure -
1454 normal_lines, normal_cols, new_total, new_normal, clone_number,
1455 splits, nest, prev_buffers, next_buffers.
1456 (WINDOW_TOTAL_SIZE): Move here from window.c.
1457 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1458
1459 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1460 Remove.
1461 (make_dummy_parent): Set new members of windows structure.
1462 (make_window): Move down in code. Handle new members of window
1463 structure.
1464 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1465 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1466 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1467 (Fset_window_prev_buffers, Fwindow_next_buffers)
1468 (Fset_window_next_buffers, Fset_window_clone_number): New
1469 functions.
1470 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1471 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1472 Doc-string fixes.
1473 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1474 Argument WINDOW can be now internal window too.
1475 (Fwindow_use_time): Move up in code.
1476 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1477 Rewrite doc-string.
1478 (Fset_window_configuration, saved_window)
1479 (Fcurrent_window_configuration, save_window_save): Handle new
1480 members of window structure.
1481 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1482 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1483 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1484 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1485 Qget_mru_window, Qresize_root_window,
1486 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1487 Qauto_buffer_name; staticpro them.
1488
1489 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1490
1491 * window.c (Fwindow_total_size, Fwindow_left_column)
1492 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1493 (Fwindow_list_1): New functions.
1494 (window_box_text_cols): Replace with window_body_cols.
1495 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1496 window_body_cols instead of window_box_text_cols.
1497 (delete_window, Fset_window_configuration): Call
1498 delete_all_subwindows with window as argument.
1499 (delete_all_subwindows): Take a window as argument and not a
1500 structure. Rewrite.
1501 (window_loop): Remove handling of GET_LRU_WINDOW and
1502 GET_LARGEST_WINDOW.
1503 (Fget_lru_window, Fget_largest_window): Move to window.el.
1504
1505 * window.h: Extern window_body_cols instead of
1506 window_box_text_cols. delete_all_subwindows now takes a
1507 Lisp_Object as argument.
1508
1509 * indent.c (compute_motion, Fcompute_motion): Use
1510 window_body_cols instead of window_box_text_cols.
1511
1512 * frame.c (delete_frame): Call delete_all_subwindows with root
1513 window as argument.
1514
1515 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1516
1517 * fns.c (Fputhash): Document return value.
1518
1519 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1520
1521 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1522
1523 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Cons<->int and similar integer overflow fixes (Bug#8794).
1526
1527 Check for overflow when converting integer to cons and back.
1528 * charset.c (Fdefine_charset_internal, Fdecode_char):
1529 Use cons_to_unsigned to catch overflow.
1530 (Fencode_char): Use INTEGER_TO_CONS.
1531 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1532 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1533 * data.c (long_to_cons, cons_to_long): Remove.
1534 (cons_to_unsigned, cons_to_signed): New functions.
1535 These signal an error for invalid or out-of-range values.
1536 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1537 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1538 * font.c (Ffont_variation_glyphs):
1539 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1540 * lisp.h: Include <intprops.h>.
1541 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1542 (cons_to_signed, cons_to_unsigned): New decls.
1543 (long_to_cons, cons_to_long): Remove decls.
1544 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1545 (Fprimitive_undo): Use CONS_TO_INTEGER.
1546 * xfns.c (Fx_window_property): Likewise.
1547 * xselect.c: Include <limits.h>.
1548 (x_own_selection, selection_data_to_lisp_data):
1549 Use INTEGER_TO_CONS.
1550 (x_handle_selection_request, x_handle_selection_clear)
1551 (x_get_foreign_selection, Fx_disown_selection_internal)
1552 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1553 (lisp_data_to_selection_data): Use cons_to_unsigned.
1554 (x_fill_property_data): Use cons_to_signed.
1555 Report values out of range.
1556
1557 Check for buffer and string overflow more precisely.
1558 * buffer.h (BUF_BYTES_MAX): New macro.
1559 * lisp.h (STRING_BYTES_MAX): New macro.
1560 * alloc.c (Fmake_string):
1561 * character.c (string_escape_byte8):
1562 * coding.c (coding_alloc_by_realloc):
1563 * doprnt.c (doprnt):
1564 * editfns.c (Fformat):
1565 * eval.c (verror):
1566 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1567 since they may not be the same number.
1568 * editfns.c (Finsert_char):
1569 * fileio.c (Finsert_file_contents):
1570 Likewise for BUF_BYTES_MAX.
1571
1572 * image.c: Use ptrdiff_t, not int, for sizes.
1573 (slurp_file): Switch from int to ptrdiff_t.
1574 All uses changed.
1575 (slurp_file): Check that file size fits in both size_t (for
1576 malloc) and ptrdiff_t (for sanity and safety).
1577
1578 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1579 if b->modtime has its maximal value.
1580
1581 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1582
1583 Don't assume time_t can fit into int.
1584 * buffer.h (struct buffer.modtime): Now time_t, not int.
1585 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1586 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1587
1588 Minor fixes for signed vs unsigned integers.
1589 * character.h (MAYBE_UNIFY_CHAR):
1590 * charset.c (maybe_unify_char):
1591 * keyboard.c (read_char, reorder_modifiers):
1592 XINT -> XFASTINT, since the integer must be nonnegative.
1593 * ftfont.c (ftfont_spec_pattern):
1594 * keymap.c (access_keymap, silly_event_symbol_error):
1595 XUINT -> XFASTINT, since the integer must be nonnegative.
1596 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1597 since it makes no difference and we prefer signed.
1598 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1599 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1600 nonnegative.
1601
1602 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1603
1604 * window.h (Fwindow_frame): Declare.
1605
1606 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1609 (SPARE_MEMORY): Always define.
1610 (LARGE_REQUEST): Remove.
1611 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1612
1613 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1614
1615 * lisp.h: Move EXFUNS for Fframe_root_window,
1616 Fframe_first_window and Fset_frame_selected_window to window.h.
1617
1618 * window.h: Move EXFUNS for Fframe_root_window,
1619 Fframe_first_window and Fset_frame_selected_window here from
1620 lisp.h.
1621
1622 * frame.c (Fwindow_frame, Fframe_first_window)
1623 (Fframe_root_window, Fframe_selected_window)
1624 (Fset_frame_selected_window): Move to window.c.
1625 (Factive_minibuffer_window): Move to minibuf.c.
1626 (Fother_visible_frames_p): New function.
1627
1628 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1629
1630 * window.c (decode_window, decode_any_window): Move up in code.
1631 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1632 (inhibit_frame_unsplittable): Remove unused variable.
1633 (Fwindow_buffer): Move up and rewrite doc-string.
1634 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1635 (Fwindow_prev): New functions.
1636 (Fwindow_frame): Move here from frame.c. Accept any window as
1637 argument.
1638 (Fframe_root_window, Fframe_first_window)
1639 (Fframe_selected_window): Move here from frame.c. Accept frame
1640 or arbitrary window as argument. Update doc-strings.
1641 (Fminibuffer_window): Move up in code.
1642 (Fwindow_minibuffer_p): Move up in code and simplify.
1643 (Fset_frame_selected_window): Move here from frame.c.
1644 Marginal rewrite.
1645 (Fselected_window, select_window, Fselect_window): Move up in
1646 code. Minor doc-string fixes.
1647
1648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1651 Do not assume that spare memory exists; that assumption is valid
1652 only if SYSTEM_MALLOC.
1653 (LARGE_REQUEST): New macro, so that the issue of large requests
1654 is separated from the issue of spare memory.
1655
1656 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1657
1658 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1659 format. (Bug#8806)
1660
1661 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1662
1663 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1664 before statements.
1665
1666 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1667
1668 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1669
1670 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1671
1672 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1673 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1674
1675 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1676
1677 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1678
1679 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1680
1681 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1682 (x_clipboard_manager_save): Add return value.
1683 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1684 New error handlers.
1685 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1686 Obey Vx_select_enable_clipboard_manager. Catch errors in
1687 x_clipboard_manager_save (Bug#8779).
1688 (Vx_select_enable_clipboard_manager): New variable.
1689 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1690
1691 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1692
1693 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1694
1695 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1696
1697 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1698 in the current matrix if keep_current_p is non-zero.
1699
1700 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1701
1702 * bidi.c (bidi_level_of_next_char): Fix last change.
1703
1704 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1705
1706 Support bidi reordering of text covered by display properties.
1707
1708 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1709 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1710 (bidi_cache_search, bidi_cache_iterator_state)
1711 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1712 (bidi_level_of_next_char, bidi_move_to_visually_next):
1713 Support character positions inside a run of characters covered by a
1714 display string.
1715 (bidi_paragraph_init, bidi_resolve_explicit_1)
1716 (bidi_level_of_next_char): Call bidi_fetch_char and
1717 bidi_fetch_char_advance instead of FETCH_CHAR and
1718 FETCH_CHAR_ADVANCE.
1719 (bidi_init_it): Initialize new members.
1720 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1721 definitions.
1722 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1723 instead of using explicit *_CHAR codes.
1724 (bidi_resolve_explicit, bidi_resolve_weak):
1725 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1726 bidirectional text is supported only in multibyte buffers.
1727 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1728 it to initialize the frame_window_p member of struct bidi_it.
1729 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1730 (bidi_resolve_explicit, bidi_resolve_weak)
1731 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1732 bidi_it->nchars is non-positive.
1733 (bidi_level_of_next_char): Don't try to lookup the cache for the
1734 next/previous character if nothing is cached there yet, or if we
1735 were just reseat()'ed to a new position.
1736
1737 * xdisp.c (set_cursor_from_row): Set start and stop points
1738 according to the row's direction when priming the loop that looks
1739 for the glyph on which to display cursor.
1740 (single_display_spec_intangible_p): Function deleted.
1741 (display_prop_intangible_p): Reimplement to call
1742 handle_display_spec instead of single_display_spec_intangible_p.
1743 Accept 3 additional arguments needed by handle_display_spec.
1744 This fixes incorrect cursor motion across display property with complex
1745 values: lists, `(when COND...)' forms, etc.
1746 (single_display_spec_string_p): Support property values that are
1747 lists with the argument STRING its top-level element.
1748 (display_prop_string_p): Fix the condition for processing a
1749 property that is a list to be consistent with handle_display_spec.
1750 (handle_display_spec): New function, refactored from the
1751 last portion of handle_display_prop.
1752 (compute_display_string_pos): Accept additional argument
1753 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1754 value of a `display' property is a "replacing spec".
1755 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1756 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1757 the display property, but just return a value indicating whether
1758 the display property will replace the characters it covers.
1759 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1760 frame_window_p members of struct bidi_it.
1761 (compute_display_string_pos, compute_display_string_end):
1762 New functions.
1763 (push_it): Accept second argument POSITION, where pop_it should
1764 jump to continue iteration.
1765 (reseat_1): Initialize bidi_it.disp_pos.
1766
1767 * keyboard.c (adjust_point_for_property): Adjust the call to
1768 display_prop_intangible_p to its new signature.
1769
1770 * dispextern.h (struct bidi_it): New member frame_window_p.
1771 (bidi_init_it): Update prototypes.
1772 (display_prop_intangible_p): Update prototype.
1773 (compute_display_string_pos, compute_display_string_end):
1774 Declare prototypes.
1775 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1776 EMACS_INT.
1777
1778 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 Malloc failure behavior now depends on size of allocation.
1781 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1782 * lisp.h: Change signatures accordingly.
1783 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1784 All callers changed. (Bug#8762)
1785
1786 * gnutls.c: Use Emacs's memory allocators.
1787 Without this change, the gnutls library would invoke malloc etc.
1788 directly, which causes problems on non-SYNC_INPUT hosts, and which
1789 runs afoul of improving memory_full behavior. (Bug#8761)
1790 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1791 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1792 xfree instead of the default malloc, realloc, free.
1793 (Fgnutls_boot): No need to check for memory allocation failure,
1794 since xmalloc does that for us.
1795
1796 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1797 * category.c (hash_get_category_set):
1798 * ccl.c (ccl_driver):
1799 * charset.c (Fdefine_charset_internal):
1800 * charset.h (struct charset.hash_index):
1801 * composite.c (get_composition_id, gstring_lookup_cache)
1802 (composition_gstring_put_cache):
1803 * composite.h (struct composition.hash_index):
1804 * dispextern.h (struct image.hash):
1805 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1806 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1807 (hashfn_equal, hashfn_user_defined, make_hash_table)
1808 (maybe_resize_hash_table, hash_lookup, hash_put)
1809 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1810 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1811 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1812 * image.c (make_image, search_image_cache, lookup_image)
1813 (xpm_put_color_table_h):
1814 * lisp.h (struct Lisp_Hash_Table):
1815 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1816 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1817 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1818 * alloc.c (allocate_vectorlike):
1819 Check for overflow in vector size calculations.
1820 * ccl.c (ccl_driver):
1821 Check for overflow when converting EMACS_INT to int.
1822 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1823 need to be updated by these changes.
1824 * fns.c (make_hash_table, maybe_resize_hash_table):
1825 Check for integer overflow with large hash tables.
1826 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1827 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1828 (SXHASH_REDUCE): New macro.
1829 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1830 Use it instead of discarding useful hash info with large hash values.
1831 (sxhash_float): New function.
1832 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1833 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1834 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1835 Rewrite to use FIXNUM_BITS, as this simplifies things.
1836 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1837 Adjust signatures to match updated version of code.
1838 (consing_since_gc): Now EMACS_INT, since a single hash table can
1839 use more than INT_MAX bytes.
1840
1841 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1842
1843 Make it possible to build with GCC-4.6+ -O2 -flto.
1844
1845 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1846
1847 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1848
1849 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1850 Call minibuffer-inactive-mode.
1851
1852 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1853
1854 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1855 Update dependencies.
1856
1857 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1858
1859 * data.c (init_data): Remove code for UTS, this system is not
1860 supported anymore.
1861
1862 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1863
1864 Don't force ./temacs to start in terminal mode.
1865
1866 * frame.c (make_initial_frame): Initialize faces in all cases, not
1867 only when CANNOT_DUMP is defined.
1868 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1869
1870 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1871
1872 * dispnew.c (add_window_display_history): Use const for the string
1873 pointer. Remove declaration, not needed.
1874
1875 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Use 'inline', not 'INLINE'.
1878 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1879 * alloc.c, fontset.c (INLINE): Remove.
1880 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1881 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1882 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1883 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1884 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1885
1886 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1887
1888 Make it possible to run ./temacs.
1889
1890 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1891 syms_of_callproc does the same thing. Remove test for
1892 "initialized", do it in the caller.
1893 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1894
1895 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1896
1897 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1898 (read_minibuf): Use get_minibuffer.
1899 (syms_of_minibuf): Use DEFSYM.
1900 (Qmetadata): New var.
1901 * data.c (Qbuffer): Don't make it static.
1902 (syms_of_data): Use DEFSYM.
1903
1904 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1907 (CCL_CODE_MIN): New macro.
1908
1909 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1912
1913 * eval.c (Qdebug): Now static.
1914 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1915 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1916 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1917
1918 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1919
1920 * image.c: Various fixes to ImageMagick code comments.
1921 (Fimagemagick_types): Doc fix.
1922
1923 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 Minor fixes prompted by GCC 4.6.0 warnings.
1926
1927 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1928
1929 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1930 (x_clipboard_manager_save_all): Move extern decl to ...
1931 * xterm.h: ... here, so that it can be checked for consistency.
1932
1933 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * xselect.c (x_clipboard_manager_save_frame)
1936 (x_clipboard_manager_save_all): New functions.
1937 (Fx_clipboard_manager_save): Lisp function deleted.
1938
1939 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1940 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1941
1942 * xterm.h: Update prototype.
1943
1944 2011-05-28 William Xu <william.xwl@gmail.com>
1945
1946 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1947 exiting (Bug#8239).
1948
1949 2011-05-28 Jim Meyering <meyering@redhat.com>
1950
1951 Avoid a sign-extension bug in crypto_hash_function.
1952 * fns.c (to_uchar): Define.
1953 (crypto_hash_function): Use it to convert some newly-signed
1954 variables to unsigned, to avoid sign-extension bugs. For example,
1955 without this change, (md5 "truc") would evaluate to
1956 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1957 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1958 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1959
1960 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 Integer overflow fixes.
1963
1964 * dbusbind.c: Serial number integer overflow fixes.
1965 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1966 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1967 to hold a serial number that is too large for a fixnum.
1968 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1969 Check for serial numbers out of range. Decode any serial number
1970 that was so large that it became a float. (Bug#8722)
1971
1972 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1973 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1974 Use XFASTINT rather than XUINT when numbers are nonnegative.
1975 (xd_append_arg, Fdbus_method_return_internal):
1976 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1977 arguments, check that Lisp number is nonnegative, rather than
1978 silently wrapping negative numbers around. (Bug#8722)
1979 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1980 (Bug#8722)
1981
1982 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1983
1984 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1985
1986 ccl: add integer overflow checks
1987 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1988 (IN_INT_RANGE): New macros.
1989 (ccl_driver): Use them to check for integer overflow when
1990 decoding a CCL program. Many of the new checks are whether XINT (x)
1991 fits in int; it doesn't always, on 64-bit hosts. The new version
1992 doesn't catch all possible integer overflows, but it's an
1993 improvement. (Bug#8719)
1994
1995 * alloc.c (make_event_array): Use XINT, not XUINT.
1996 There's no need for unsigned here.
1997
1998 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1999 This follows up to the 2011-05-06 change that substituted uintptr_t
2000 for EMACS_INT. This case wasn't caught back then.
2001
2002 Rework Fformat to avoid integer overflow issues.
2003 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2004 now (part of C89). Include <verify.h>.
2005 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2006 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2007 (Fformat): Avoid the prepass trying to compute sizes; it was only
2008 approximate and thus did not catch overflow reliably. Instead, walk
2009 through the format just once, formatting and computing sizes as we go,
2010 checking for integer overflow at every step, and allocating a larger
2011 buffer as needed. Keep track separately whether the format is
2012 multibyte. Keep only the most-recently calculated precision, rather
2013 than them all. Record whether each argument has been converted to
2014 string. Use EMACS_INT, not int, for byte and char and arg counts.
2015 Support field widths and precisions larger than INT_MAX. Avoid
2016 sprintf's undefined behavior with conversion specifications such as %#d
2017 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2018 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2019 formatting out-of-range floating point numbers with int
2020 formats. (Bug#8668)
2021
2022 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2023
2024 * data.c: Avoid integer truncation in expressions involving floats.
2025 * data.c: Include <intprops.h>.
2026 (arith_driver): When there's an integer overflow in an expression
2027 involving floating point, convert the integers to floating point
2028 so that the resulting value does not suffer from catastrophic
2029 integer truncation. For example, on a 64-bit host (* 4
2030 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2031 Do not rely on undefined behavior after integer overflow.
2032
2033 merge count_size_as_multibyte, parse_str_to_multibyte
2034 * character.c, character.h (count_size_as_multibyte):
2035 Rename from parse_str_to_multibyte; all uses changed.
2036 Check for integer overflow.
2037 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2038 since it's now a duplicate of the other. This is more of
2039 a character than a buffer op, so better that it's in character.c.
2040 * fns.c, print.c: Adjust to above changes.
2041
2042 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2045
2046 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2049 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2050 (x_clipboard_manager_save): Now static.
2051 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2052
2053 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2054 (crypto_hash_function): Now static.
2055 Fix pointer signedness problems. Avoid unnecessary initializations.
2056
2057 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * termhooks.h (Vselection_alist): Make it terminal-local.
2060
2061 * terminal.c (create_terminal): Initialize it.
2062
2063 * xselect.c: Support for clipboard managers.
2064 (Vselection_alist): Move to termhooks.h as terminal-local var.
2065 (LOCAL_SELECTION): New macro.
2066 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2067 (symbol_to_x_atom): Remove gratuitous arg.
2068 (x_handle_selection_request, lisp_data_to_selection_data)
2069 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2070 (x_own_selection, x_get_local_selection, x_convert_selection):
2071 New arg, specifying work frame. Use terminal-local Vselection_alist.
2072 (some_frame_on_display): Delete unused function.
2073 (Fx_own_selection_internal, Fx_get_selection_internal)
2074 (Fx_disown_selection_internal, Fx_selection_owner_p)
2075 (Fx_selection_exists_p): New optional frame arg.
2076 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2077 (x_handle_selection_clear): Don't treat other terminals with the
2078 same keyboard specially. Use the terminal-local Vselection_alist.
2079 (x_clear_frame_selections): Use Frun_hook_with_args.
2080
2081 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2082
2083 * xterm.h: Add support for those atoms.
2084
2085 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2086
2087 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2088 (converted_selections, conversion_fail_tag): New global variables.
2089 (x_selection_request_lisp_error): Free the above.
2090 (x_get_local_selection): Remove unnecessary code.
2091 (x_reply_selection_request): Args changed; handle arbitrary array
2092 of converted selections stored in converted_selections.
2093 Separate the XChangeProperty and SelectionNotify steps.
2094 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2095 (x_convert_selection): New function.
2096 (x_handle_selection_event): Simplify.
2097 (x_get_foreign_selection): Don't ignore incoming requests while
2098 waiting for an answer; this will fail when we implement
2099 SAVE_TARGETS, and seems unnecessary anyway.
2100 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2101 (Vx_sent_selection_functions): Doc fix.
2102
2103 2011-05-26 Leo Liu <sdl.web@gmail.com>
2104
2105 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2106
2107 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2108
2109 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2110
2111 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2112 for fringe update if it has periodic bitmap.
2113 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2114 and fringe_bitmap_periodic_p.
2115
2116 * fringe.c (get_fringe_bitmap_data): New function.
2117 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2118 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2119 row. Mark glyph row for fringe update if periodicity changed.
2120
2121 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2122 for fringe update unless it has periodic bitmap.
2123
2124 2011-05-25 Kenichi Handa <handa@m17n.org>
2125
2126 * xdisp.c (get_next_display_element): Set correct it->face_id for
2127 a static composition.
2128
2129 2011-05-24 Leo Liu <sdl.web@gmail.com>
2130
2131 * deps.mk (fns.o):
2132 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2133
2134 * fns.c (crypto_hash_function, Fsha1): New function.
2135 (Fmd5): Use crypto_hash_function.
2136 (syms_of_fns): Add Ssha1.
2137
2138 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * gnutls.c: Remove unused macros.
2141 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2142 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2143 Remove macros that are defined and never used.
2144 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2145
2146 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2147
2148 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2149 (Fx_get_selection_internal): Minor cleanup.
2150 (Fx_own_selection_internal): Rename arguments for consistency with
2151 select.el.
2152
2153 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2156
2157 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2158
2159 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2160
2161 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2162
2163 * dispnew.c (scrolling_window): Don't exclude the case that the
2164 last enabled row in the desired matrix touches the bottom boundary.
2165
2166 2011-05-21 Glenn Morris <rgm@gnu.org>
2167
2168 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2169 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2170 and add some more files.
2171
2172 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2173
2174 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2175 report_file_error introduced by the change from 2011-05-07.
2176
2177 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * systime.h (Time): Define only if emacs is defined.
2180 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2181 where the include path doesn't have X11/X.h by default. See
2182 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2183
2184 2011-05-20 Kenichi Handa <handa@m17n.org>
2185
2186 * composite.c (find_automatic_composition): Fix previous change.
2187
2188 2011-05-20 Glenn Morris <rgm@gnu.org>
2189
2190 * lisp.mk: New file, split from Makefile.in.
2191 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2192 (shortlisp): Remove.
2193 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2194
2195 2011-05-19 Glenn Morris <rgm@gnu.org>
2196
2197 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2198 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2199 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2200 (lisp): Set the order to that of loadup.el.
2201 (shortlisp): Make it a copy of $lisp.
2202 (SOME_MACHINE_LISP): Remove.
2203 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2204 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2205
2206 2011-05-18 Kenichi Handa <handa@m17n.org>
2207
2208 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2209 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2210 (find_automatic_composition): Mostly rewrite for efficiency.
2211
2212 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * makefile.w32-in: Update dependencies.
2215
2216 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2217
2218 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2219 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2220
2221 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 Fix some integer overflow issues, such as string length overflow.
2224
2225 * insdel.c (count_size_as_multibyte): Check for string overflow.
2226
2227 * character.c (lisp_string_width): Check for string overflow.
2228 Use EMACS_INT, not int, for string indexes and lengths; in
2229 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2230 the resulting string length overflows an EMACS_INT; instead,
2231 report a string overflow if no precision given. When checking for
2232 precision exhaustion, use a check that cannot possibly have
2233 integer overflow. (Bug#8675)
2234 * character.h (lisp_string_width): Adjust to new signature.
2235
2236 * alloc.c (string_overflow): New function.
2237 (Fmake_string): Use it. This doesn't change behavior, but saves
2238 a few bytes and will simplify future changes.
2239 * character.c (string_escape_byte8): Likewise.
2240 * lisp.h (string_overflow): New decl.
2241
2242 Fixups, following up to the user-interface timestamp change.
2243 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2244 for UI timestamps, instead of unsigned long.
2245 * msdos.c (mouse_get_pos): Likewise.
2246 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2247 * w32gui.h (Time): Define by including "systime.h" rather than by
2248 declaring it ourselves. (Bug#8664)
2249
2250 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2251 * image.c (clear_image_cache): Likewise.
2252
2253 * term.c (term_mouse_position): Don't assume time_t wraparound.
2254
2255 Be more systematic about user-interface timestamps.
2256 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2257 and sometimes 'EMACS_UINT', to represent these timestamps.
2258 This change causes it to use 'Time' uniformly, as that's what X uses.
2259 This makes the code easier to follow, and makes it easier to catch
2260 integer overflow bugs such as Bug#8664.
2261 * frame.c (Fmouse_position, Fmouse_pixel_position):
2262 Use Time, not unsigned long, for user-interface timestamps.
2263 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2264 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2265 * keyboard.h (last_event_timestamp): Likewise.
2266 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2267 * menu.h (xmenu_show): Likewise.
2268 * term.c (term_mouse_position): Likewise.
2269 * termhooks.h (struct input_event.timestamp): Likewise.
2270 (struct terminal.mouse_position_hook): Likewise.
2271 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2272 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2273 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2274 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2275 what it was before.
2276 * menu.h, termhooks.h: Include "systime.h", for Time.
2277
2278 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2279 Don't assume that the difference between two unsigned long values
2280 can fit into an integer. At this point, we know button_down_time
2281 <= event->timestamp, so the difference must be nonnegative, so
2282 there's no need to cast the result if double-click-time is
2283 nonnegative, as it should be; check that it's nonnegative, just in
2284 case. This bug is triggered when events are more than 2**31 ms
2285 apart (about 25 days). (Bug#8664)
2286
2287 * xselect.c (last_event_timestamp): Remove duplicate decl.
2288 (x_own_selection): Remove needless cast to unsigned long.
2289
2290 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2291 that always fit in int. Use a sentinel instead of a counter, to
2292 avoid a temp and to allay GCC's concerns about possible int overflow.
2293 * frame.h (struct frame): Use int for menu_bar_items_used
2294 instead of EMACS_INT, since it always fits in int.
2295
2296 * menu.c (grow_menu_items): Check for int overflow.
2297
2298 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2299
2300 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2301 Before, the code was not consistent. These values cannot exceed
2302 2**31 - 1 so there's no need to make them unsigned.
2303 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2304 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2305 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2306 as modifiers.
2307 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2308
2309 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2310 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2311 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2312 presumably because the widths might not match.
2313
2314 * window.c (size_window): Avoid needless test at loop start.
2315
2316 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2317
2318 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2319
2320 2011-05-12 Drew Adams <drew.adams@oracle.com>
2321
2322 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2323
2324 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2325
2326 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2327 `width' to `bar_area_x' and `bar_area_width', respectively.
2328 (x_scroll_run): Take account of fringe background extension.
2329
2330 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2331 Rename local vars `left' and `width' to `bar_area_x' and
2332 `bar_area_width', respectively.
2333 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2334 background extension.
2335
2336 2011-05-10 Jim Meyering <meyering@redhat.com>
2337
2338 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2339
2340 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2341
2342 * image.c (Finit_image_library): Return t for built-in image types,
2343 like pbm and xbm. (Bug#8640)
2344
2345 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2346
2347 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2348
2349 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2350
2351 * w32console.c (Fset_screen_color): Doc fix.
2352 (Fget_screen_color): New function.
2353 (syms_of_ntterm): Defsubr it.
2354
2355 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2356 unlink the temporary file if Fcall_process didn't create it in the
2357 first place.
2358 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2359 child process will be redirected to a file specified with `:file'.
2360 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2361 cue to call_process_cleanup not to close that handle.
2362
2363 2011-05-07 Ben Key <bkey76@gmail.com>
2364
2365 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2366 one of two shell specific rules, either bootstrap-temacs-CMD or
2367 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2368 to the previous implementation of the bootstrap-temacs rule.
2369 The bootstrap-temacs-CMD rule is similar to the previous
2370 implementation of the bootstrap-temacs rule except that it
2371 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2372 variable.
2373
2374 These changes, along with some changes to nt/configure.bat,
2375 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2376 earlier fix to add support for --cflags and --ldflags options
2377 that include quotes so that it works whether make uses cmd or
2378 sh as the shell.
2379
2380 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2381
2382 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2383 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2384 is a constant.
2385 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2386 a string. Handle both cases.
2387 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2388 (Fdbus_register_method): Use Qinvalid_function.
2389
2390 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2391
2392 * makefile.w32-in: Update dependencies.
2393 (LISP_H): Add inttypes.h and stdin.h.
2394 (PROCESS_H): Add unistd.h.
2395
2396 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2397
2398 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2399 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2400
2401 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2404
2405 * term.c (vfatal): Remove stray call to va_end.
2406 It's not needed and the C Standard doesn't allow it here anyway.
2407
2408 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2409 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2410
2411 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2412 bytes.
2413
2414 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2415
2416 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2417
2418 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2419
2420 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2421
2422 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2423
2424 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2425 * charset.c (Fdefine_charset_internal): Don't initialize
2426 charset.code_space[15]. The value was garbage, on hosts with
2427 32-bit int (Bug#8600).
2428
2429 * lread.c (read_integer): Be more consistent with string-to-number.
2430 Use string_to_number to do the actual conversion; this avoids
2431 rounding errors and fixes some other screwups. Without this fix,
2432 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2433 (digit_to_number): Move earlier, for benefit of read_integer.
2434 Return -1 if the digit is out of range for the base, -2 if it is
2435 not a digit in any supported base. (Bug#8602)
2436
2437 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2438
2439 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2440 to match comment at start of function. This also removes a
2441 GCC warning about overflow in a 32+64-bit port.
2442
2443 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2444
2445 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2446 Reported by Stefan Monnier in
2447 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2448 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2449 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2450
2451 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2452 (EMACS_UINTPTR): Likewise, with uintptr_t.
2453
2454 * lisp.h: Prefer 64-bit EMACS_INT if available.
2455 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2456 on 32-bit hosts that have 64-bit int, so that they can access
2457 large files.
2458 However, temporarily disable this change unless the temporary
2459 symbol WIDE_EMACS_INT is defined.
2460
2461 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2462
2463 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2464 This removes an assumption that EMACS_INT and long are the same
2465 width as pointers. The assumption is true for Emacs porting targets
2466 now, but we want to make other targets possible.
2467 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2468 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2469 In the rest of the code, change types of integers that hold casted
2470 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2471 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2472 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2473 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2474 No need to cast type when ORing.
2475 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2476 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2477 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2478 assume EMACS_INT is the same width as char *.
2479 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2480 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2481 Remove no-longer-needed casts.
2482 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2483 (xg_tool_bar_help_callback, xg_make_tool_item):
2484 Use EMACS_INTPTR to hold an integer
2485 that will be cast to void *; this can avoid a GCC warning
2486 if EMACS_INT is not the same width as void *.
2487 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2488 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2489 (current_message_1, set_message_1):
2490 Use a local to convert to proper width without a cast.
2491 * xmenu.c (dialog_selection_callback): Likewise.
2492
2493 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2494 Also, don't assume VALBITS / RAND_BITS is less than 5,
2495 and don't rely on undefined behavior when shifting a 1 left into
2496 the sign bit.
2497 * lisp.h (get_random): Change signature to match.
2498
2499 * lread.c (hash_string): Use size_t, not int, for hash computation.
2500 Normally we prefer signed values; but hashing is special, because
2501 it's better to use unsigned division on hash table sizes so that
2502 the remainder is nonnegative. Also, size_t is the natural width
2503 for hashing into memory. The previous code used 'int', which doesn't
2504 retain enough info to hash well into very large tables.
2505 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2506
2507 * dbusbind.c: Don't possibly lose pointer info when converting.
2508 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2509 Use XPNTR rather than XHASH, so that the high-order bits of
2510 the pointer aren't lost when converting through void *.
2511
2512 * eval.c (Fautoload): Don't double-shift a pointer.
2513
2514 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2515
2516 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * gnutls.c (DEF_GNUTLS_FN):
2519 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2520
2521 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2522
2523 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2524 marker. (Bug#8610)
2525
2526 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2527
2528 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2529 New version that can reserve upto 2GB of heap space.
2530
2531 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2532
2533 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2534
2535 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2536
2537 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2538 `gnutls_certificate_set_x509_key_file'.
2539
2540 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2541
2542 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2543 Update dependencies.
2544
2545 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2546
2547 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2548 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2549 Remove unused parameter `fildes'.
2550 * process.c (read_process_output, send_process): Don't pass it.
2551
2552 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2553
2554 Fix previous change: the library cache is defined in w32.c.
2555 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2556 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2557
2558 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2559
2560 Implement dynamic loading of GnuTLS on Windows.
2561
2562 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2563 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2564 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2565 Declare.
2566
2567 * gnutls.c (Qgnutls_dll): Define.
2568 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2569 (gnutls_*): Declare function pointers.
2570 (init_gnutls_functions): New function to initialize function pointers.
2571 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2572 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2573 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2574 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2575 (emacs_gnutls_write, emacs_gnutls_read)
2576 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2577 (Fgnutls_available_p): New function.
2578 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2579 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2580 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2581
2582 * image.c: Include w32.h.
2583 (Vimage_type_cache): Delete.
2584 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2585 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2586 (w32_delayed_load): Move to w32.c.
2587
2588 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2589
2590 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2591 (w32_delayed_load): Move from image.c. When loading a library, record
2592 its filename in the :loaded-from property of the library id.
2593 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2594 Initialize and staticpro them.
2595 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2596
2597 * process.c: Include lisp.h before w32.h, not after.
2598 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2599 instead of gnutls_record_check_pending.
2600
2601 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2602
2603 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2604
2605 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2606 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2607 as passed in.
2608
2609 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2610
2611 * xterm.c (x_set_frame_alpha): Do not set property on anything
2612 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2613
2614 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2615
2616 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2617
2618 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2619
2620 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2621 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2622 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2623 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2624 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2625 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2626 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2627 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2628 (Qgnutls_bootprop_callbacks_verify): Make static.
2629
2630 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2631
2632 * callproc.c: Indentation fixup.
2633
2634 * sysdep.c (wait_for_termination_1): Make static.
2635 (wait_for_termination, interruptible_wait_for_termination):
2636 Move after wait_for_termination_1.
2637
2638 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2639
2640 * sysdep.c (interruptible_wait_for_termination): New function
2641 which is like wait_for_termination, but allows keyboard
2642 interruptions.
2643
2644 * callproc.c (Fcall_process): Add (:file "file") as an option for
2645 the STDOUT buffer.
2646 (Fcall_process_region): Ditto.
2647
2648 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2649
2650 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2651 rather than `XVECTOR (FOO)->size'.
2652
2653 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2654 inttypes.h, as a gnulib replacement is used if it not available in
2655 system headers.
2656
2657 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2658
2659 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2660 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2661 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2662
2663 * coding.c (coding_alloc_by_realloc): Error out if destination
2664 will grow beyond MOST_POSITIVE_FIXNUM.
2665 (decode_coding_emacs_mule): Abort if there isn't enough place in
2666 charbuf for the composition carryover bytes. Reserve an extra
2667 space for up to 2 characters produced in a loop.
2668 (decode_coding_iso_2022): Abort if there isn't enough place in
2669 charbuf for the composition carryover bytes.
2670
2671 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2672
2673 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2674 aborting when %lld or %lll format is passed.
2675 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2676 %llo or %llx format is passed. (Bug#8545)
2677
2678 * window.c (window_scroll_line_based): Use a marker instead of
2679 simple variables to record original value of point. (Bug#7952)
2680
2681 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2682 produced by %s or %c overflows available buffer space. (Bug#8545)
2683
2684 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2687 (SIZE_MAX): Move defn after all includes, as they might #define it.
2688
2689 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2690
2691 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2692
2693 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2694
2695 * keyboard.c (Qdelayed_warnings_hook): Define.
2696 (command_loop_1): Run `delayed-warnings-hook'
2697 if Vdelayed_warnings_list is non-nil.
2698 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2699 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2700
2701 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2702
2703 * doprnt.c (doprnt): Don't return value smaller than the buffer
2704 size if the message was truncated. (Bug#8545).
2705
2706 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2707
2708 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2709 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2710
2711 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2714
2715 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2716
2717 * makefile.w32-in: Update dependencies.
2718
2719 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2720
2721 Improve `doprnt' and its usage. (Bug#8545)
2722 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2723 `format_end'. Remove support for %l as a conversion specifier.
2724 Don't use xrealloc. Improve diagnostics when the %l size modifier
2725 is used. Update the commentary.
2726
2727 * eval.c (verror): Simplify calculation of size_t.
2728
2729 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2730 messages.
2731
2732 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2733
2734 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2735 change.
2736
2737 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2740 This makes this file independent of the recent pseudovector change.
2741
2742 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2745
2746 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2747 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2748 Remove unused local.
2749 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2750
2751 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2752 GCC 4.6.0 optimizes based on type-based alias analysis.
2753 For example, if b is of type struct buffer * and v of type struct
2754 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2755 != &v->size, and therefore "v->size = 1; b->size = 2; return
2756 v->size;" must therefore return 1. This assumption is incorrect
2757 for Emacs, since it type-puns struct Lisp_Vector * with many other
2758 types. To fix this problem, this patch adds a new type struct
2759 vectorlike_header that documents the constraints on layout of vectors
2760 and pseudovectors, and helps optimizing compilers not get fooled
2761 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2762 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2763 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2764 the size member.
2765 (XSETPVECTYPE): Rewrite in terms of new macro.
2766 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2767 This is a bit clearer, and further avoids the possibility of
2768 undesirable aliasing.
2769 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2770 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2771 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2772 since Lisp_Subr is a special case (no "next" field).
2773 (ASIZE): Now uses header.size rather than size.
2774 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2775 to avoid the hassle of writing XVECTOR (foo)->header.size.
2776 (struct vectorlike_header): New type.
2777 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2778 object, to help avoid aliasing.
2779 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2780 (SUBRP): Likewise, since Lisp_Subr is a special case.
2781 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2782 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2783 (struct Lisp_Hash_Table): Combine first two members into a single
2784 struct vectorlike_header member. All uses of "size" and "next" members
2785 changed to be "header.size" and "header.next".
2786 * buffer.h (struct buffer): Likewise.
2787 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2788 * frame.h (struct frame): Likewise.
2789 * process.h (struct Lisp_Process): Likewise.
2790 * termhooks.h (struct terminal): Likewise.
2791 * window.c (struct save_window_data, struct saved_window): Likewise.
2792 * window.h (struct window): Likewise.
2793 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2794 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2795 * buffer.c (init_buffer_once): Likewise.
2796 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2797 special case.
2798 * process.c (Fformat_network_address): Use local var for size,
2799 for brevity.
2800
2801 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2802
2803 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2804 * data.c (atof): Remove decl; no longer used or needed.
2805 (digit_to_number): Move to lread.c.
2806 (Fstring_to_number): Use new string_to_number function, to be
2807 consistent with how the Lisp reader treats infinities and NaNs.
2808 Do not assume that floating-point numbers represent EMACS_INT
2809 without losing information; this is not true on most 64-bit hosts.
2810 Avoid double-rounding errors, by insisting on integers when
2811 parsing non-base-10 numbers, as the documentation specifies.
2812 * lisp.h (string_to_number): New decl, replacing ...
2813 (isfloat_string): Remove.
2814 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2815 (read1): Do not accept +. and -. as integers; this
2816 appears to have been a coding error. Similarly, do not accept
2817 strings like +-1e0 as floating point numbers. Do not report
2818 overflow for integer overflows unless the base is not 10 which
2819 means we have no simple and reliable way to continue.
2820 Break out the floating-point parsing into a new
2821 function string_to_number, so that Fstring_to_number parses
2822 floating point numbers consistently with the Lisp reader.
2823 (digit_to_number): Move here from data.c. Make it static inline.
2824 (E_CHAR, EXP_INT): Remove, replacing with ...
2825 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2826 (string_to_number): New function, replacing isfloat_string.
2827 This function checks for valid syntax and produces the resulting
2828 Lisp float number too. Rework it so that string-to-number
2829 no longer mishandles examples like "1.0e+". Use strtoumax,
2830 so that overflow for non-base-10 numbers is reported only when
2831 there's no portable and simple way to convert to floating point.
2832
2833 * textprop.c (set_text_properties_1): Rewrite for clarity,
2834 and to avoid GCC warning about integer overflow.
2835
2836 * intervals.h (struct interval): Use EMACS_INT for members
2837 where EMACS_UINT might cause problems. See
2838 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2839 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2840 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2841 All uses changed.
2842 (offset_intervals): Tell GCC not to worry about length overflow
2843 when negating a negative length.
2844
2845 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2846 (overrun_check_free): Likewise.
2847
2848 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2849 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2850 word size.
2851
2852 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2853 (gnutls_make_error): Rename local to avoid shadowing.
2854 (gnutls_emacs_global_deinit): ifdef out; not used.
2855 (Fgnutls_boot): Use const for pointer to readonly storage.
2856 Comment out unused local. Fix pointer signedness problems.
2857
2858 * lread.c (openp): Don't stuff size_t into an 'int'.
2859 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2860 about possible signed overflow.
2861
2862 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2863 (GDK_KEY_g): Don't define if already defined.
2864 (xg_prepare_tooltip): Avoid pointer signedness problem.
2865 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2866
2867 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2868 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2869
2870 * xfns.c (Fx_window_property): Simplify a bit,
2871 to make a bit faster and to avoid GCC 4.6.0 warning.
2872 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2873
2874 * fns.c (internal_equal): Don't assume size_t fits in int.
2875
2876 * alloc.c (compact_small_strings): Tighten assertion a little.
2877
2878 Replace pEd with more-general pI, and fix some printf arg casts.
2879 * lisp.h (pI): New macro, generalizing old pEd macro to other
2880 conversion specifiers. For example, use "...%"pI"d..." rather
2881 than "...%"pEd"...".
2882 (pEd): Remove. All uses replaced with similar uses of pI.
2883 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2884 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2885 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2886 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2887 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2888 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2889 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2890 64-bit hosts.
2891 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2892 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2893 * print.c (safe_debug_print, print_object): Likewise.
2894 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2895 to int.
2896 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2897 avoiding the 0 flag, which is not portable.
2898 * process.c (Fmake_network_process): Use pI to avoid cast.
2899 * region-cache.c (pp_cache): Likewise.
2900 * xdisp.c (decode_mode_spec): Likewise.
2901 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2902 behavior on 64-bit hosts with printf arg.
2903 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2904 (x_stop_queuing_selection_requests): Likewise.
2905 (x_get_window_property): Don't truncate byte count to an 'int'
2906 when tracing.
2907
2908 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2909 here, since it parses constructs like leading '-' and spaces,
2910 which are not wanted; and it overflows with large numbers.
2911 Instead, simply match F[0-9]+, which is what is wanted anyway.
2912
2913 * alloc.c: Remove unportable assumptions about struct layout.
2914 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2915 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2916 (allocate_vectorlike, make_pure_vector): Use the new macros,
2917 plus offsetof, to remove unportable assumptions about struct layout.
2918 These assumptions hold on all porting targets that I know of, but
2919 they are not guaranteed, they're easy to remove, and removing them
2920 makes further changes easier.
2921
2922 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2923 This doesn't fix a bug but makes the code clearer.
2924 (string_overrun_cookie): Now const. Use initializers that
2925 don't formally overflow signed char, to avoid warnings.
2926 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2927 can cause Emacs to crash when string overrun checking is enabled.
2928 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2929 multiple of sizeof (EMACS_INT); it need not be, if
2930 alignof(EMACS_INT) < sizeof (EMACS_INT).
2931 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2932
2933 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2934
2935 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2936
2937 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2938
2939 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2940 supposed to be handshaking. (Bug#8556)
2941 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2942
2943 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2944
2945 * lisp.h (Qdebug): List symbol.
2946 * eval.c (Qdebug): Restore global linkage.
2947 * keyboard.c (debug-on-event): New variable.
2948 (handle_user_signal): Break into debugger when debug-on-event
2949 matches the current signal symbol.
2950
2951 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2952
2953 * alloc.c (check_sblock, check_string_bytes)
2954 (check_string_free_list): Convert to standard C.
2955
2956 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2957
2958 * w32.c (emacs_gnutls_push): Fix typo.
2959
2960 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2961
2962 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2963 "cast to pointer from integer of different size".
2964
2965 Improve doprnt and its use in verror. (Bug#8545)
2966 * doprnt.c (doprnt): Document the set of format control sequences
2967 supported by the function. Use SAFE_ALLOCA instead of always
2968 using `alloca'.
2969
2970 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2971 is one byte too soon. Don't use xrealloc; instead xfree and
2972 xmalloc anew.
2973
2974 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2975
2976 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2977 callbacks stage.
2978
2979 * gnutls.c: Renamed global_initialized to
2980 gnutls_global_initialized. Added internals for the
2981 :verify-hostname-error, :verify-error, and :verify-flags
2982 parameters of `gnutls-boot' and documented those parameters in the
2983 docstring. Start callback support.
2984 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2985 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2986 on error. Return error code.
2987 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2988 (emacs_gnutls_read): Likewise.
2989 (Fgnutls_boot): Return handshake error code.
2990 (emacs_gnutls_handle_error): New function.
2991 (wsaerror_to_errno): Likewise.
2992
2993 * w32.h (emacs_gnutls_pull): Add prototype.
2994 (emacs_gnutls_push): Likewise.
2995
2996 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2997 (emacs_gnutls_push): Likewise.
2998
2999 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3000
3001 * process.c (wait_reading_process_output): Check if GnuTLS
3002 buffered some data internally if no FDs are set for TLS
3003 connections.
3004
3005 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3006 (LIBS): Link to USER_LIBS.
3007 ($(BLD)/gnutls.$(0)): New target.
3008
3009 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3010
3011 * xdisp.c (handle_single_display_spec): Rename the
3012 display_replaced_before_p argument into display_replaced_p, to
3013 make it consistent with the commentary. Fix typos in the
3014 commentary.
3015
3016 * textprop.c (syms_of_textprop): Remove dead code.
3017 (copy_text_properties): Delete obsolete commentary about an
3018 interface that was deleted long ago. Fix typos in the description
3019 of arguments.
3020
3021 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3022 to changes in oldXMenu/XMenu.h from 2011-04-16.
3023 <menu_help_message, prev_menu_help_message>: Constify.
3024 (IT_menu_make_room): menu->help_text is now `const char **';
3025 adjust.
3026
3027 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3028 to changes in oldXMenu/XMenu.h from 2011-04-16.
3029 (struct XMenu): Declare `help_text' `const char **'.
3030
3031 * xfaces.c <Qunspecified>: Make extern again.
3032
3033 * syntax.c: Include sys/types.h before including regex.h, as
3034 required by Posix.
3035
3036 * doc.c (get_doc_string): Improve the format passed to `error'.
3037
3038 * doprnt.c (doprnt): Improve commentary.
3039
3040 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3041
3042 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3043 them with etags.
3044
3045 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3046 changes in globals.h immediately force recompilation.
3047 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3048 $(CURDIR)/s/ms-w32.h.
3049 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3050
3051 * character.c (Fchar_direction): Function deleted.
3052 (syms_of_character): Don't defsubr it.
3053 <char-direction-table>: Deleted.
3054
3055 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3056
3057 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3058 * doprnt.c: Include limits.h.
3059 (SIZE_MAX): New macro.
3060 (doprnt): Return a size_t value. 2nd arg is now size_t.
3061 Many local variables are now size_t instead of int or unsigned.
3062 Improve overflow protection. Support `l' modifier for integer
3063 conversions. Support %l conversion. Don't assume an EMACS_INT
3064 argument for integer conversions and for %c.
3065
3066 * lisp.h (doprnt): Restore prototype.
3067
3068 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3069 $(SRC)/character.h.
3070
3071 * Makefile.in (base_obj): Add back doprnt.o.
3072
3073 * deps.mk (doprnt.o): Add back prerequisites.
3074 (callint.o): Depend on character.h.
3075
3076 * eval.c (internal_lisp_condition_case): Include the handler
3077 representation in the error message.
3078 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3079 when breaking from the loop.
3080
3081 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3082
3083 * callint.c (Fcall_interactively): When displaying error message
3084 about invalid control letter, pass the character's codepoint, not
3085 a pointer to its multibyte form. Improve display of the character
3086 in octal and display also its hex code.
3087
3088 * character.c (char_string): Use %x to display the (unsigned)
3089 codepoint of an invalid character, to avoid displaying a bogus
3090 negative value.
3091
3092 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3093 `error', not SYMBOL_NAME itself.
3094
3095 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3096 character arguments to `error'.
3097
3098 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3099 to `error' in error message about FINAL_CHAR argument. Make sure
3100 FINAL_CHAR is a character, and use %c when it is passed as
3101 argument to `error'.
3102
3103 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3104
3105 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3106
3107 * w32.c: Include <time.h>.
3108 (sys_localtime): New function.
3109
3110 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3113
3114 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3115
3116 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3117
3118 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3119 zombies (Bug#8467).
3120
3121 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3122
3123 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3124 gl_state.e_property when gl_state.object is Qt.
3125
3126 * insdel.c (make_gap_larger): Remove limitation of buffer size
3127 to <= INT_MAX.
3128
3129 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3130
3131 * xdisp.c (lookup_glyphless_char_display)
3132 (produce_glyphless_glyph): Handle cons cell entry in
3133 glyphless-char-display.
3134 (Vglyphless_char_display): Document it.
3135
3136 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3137 glyphless-char-display.
3138
3139 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3140
3141 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3142
3143 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3144
3145 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3146 definition for no-X builds.
3147
3148 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 Static checks with GCC 4.6.0 and non-default toolkits.
3151
3152 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3153
3154 * process.c (keyboard_bit_set): Define only if SIGIO.
3155 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3156 (send_process): Repair possible setjmp clobbering.
3157
3158 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3159
3160 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3161
3162 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3163
3164 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3165 Define only if needed.
3166
3167 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3168 by pacifying GCC about it. Maybe it's time to retire it?
3169 * xfaces.c (USG, __TIMEVAL__): Likewise.
3170
3171 * dispextern.h (struct redisplay_interface): Rename param
3172 to avoid shadowing.
3173 * termhooks.h (struct terminal): Likewise.
3174 * xterm.c (xembed_send_message): Likewise.
3175
3176 * insdel.c (make_gap_smaller): Define only if
3177 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3178
3179 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3180 it.
3181
3182 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3183 so that we aren't warned about unused symbols.
3184
3185 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3186
3187 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3188
3189 * xfns.c (x_real_positions): Mark locals as initialized.
3190
3191 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3192
3193 * xterm.c: Fix problems found by static analysis with other toolkits.
3194 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3195 (x_dispatch_event): Declare static if USE_GTK, and
3196 define if USE_GTK || USE_X_TOOLKIT.
3197 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3198 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3199 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3200 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3201
3202 * xmenu.c (menu_help_callback): Pointer type fixes.
3203 Use const pointers when pointing at readonly data. Avoid pointer
3204 signedness clashes.
3205 (FALSE): Remove unused macro.
3206 (update_frame_menubar): Remove unused decl.
3207
3208 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3209
3210 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3211 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3212 (single_menu_item): Rename local to avoid shadowing.
3213
3214 * keyboard.c (make_lispy_event): Remove unused local var.
3215
3216 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3217 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3218
3219 * bitmaps: Change bitmaps from unsigned char back to the X11
3220 compatible char. Avoid the old compiler warnings about
3221 out-of-range initializers by using, for example, '\xab' rather
3222 than 0xab.
3223
3224 * xgselect.c (xgselect_initialize): Check vs interface
3225 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3226
3227 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3228
3229 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3230 to read-only memory.
3231
3232 * fns.c (vector): Remove; this old hack is no longer needed.
3233
3234 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3235 Remove unused var.
3236 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3237
3238 * xrdb.c (x_load_resources): Omit unused local.
3239
3240 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3241 (x_window): Rename locals to avoid shadowing.
3242 (USG): Use the kludged USG macro, to pacify gcc.
3243
3244 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3245 (x_term_init): Remove local to avoid shadowing.
3246
3247 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3248
3249 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3250 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3251
3252 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3253
3254 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3255
3256 Fix regex.c, syntax.c and friends for buffers > 2GB.
3257 * syntax.h (struct gl_state_s): Declare character position members
3258 EMACS_INT.
3259
3260 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3261
3262 * textprop.c (verify_interval_modification, interval_of):
3263 Declare arguments EMACS_INT.
3264
3265 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3266 EMACS_INT.
3267
3268 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3269
3270 * indent.c (Fvertical_motion): Local variable it_start is now
3271 EMACS_INT.
3272
3273 * regex.c (re_match, re_match_2, re_match_2_internal)
3274 (bcmp_translate, regcomp, regexec, print_double_string)
3275 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3276 (re_compile_pattern, re_exec): Declare arguments and local
3277 variables `size_t' and `ssize_t' and return values `regoff_t', as
3278 appropriate.
3279 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3280 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3281 <compile_stack_type>: `size' and `avail' are now `size_t'.
3282
3283 * regex.h <regoff_t>: Use ssize_t, not int.
3284 (re_search, re_search_2, re_match, re_match_2): Arguments that
3285 specify buffer/string position and length are now ssize_t and
3286 size_t. Return type is regoff_t.
3287
3288 2011-04-16 Ben Key <bkey76@gmail.com>
3289
3290 * nsfont.m: Fixed bugs in ns_get_family and
3291 ns_descriptor_to_entity that were caused by using free to
3292 deallocate memory blocks that were allocated by xmalloc (via
3293 xstrdup). This caused Emacs to crash when compiled with
3294 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3295 --enable-checking=xmallocoverrun). xfree is now used to
3296 deallocate these memory blocks.
3297
3298 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3301
3302 emacs_write: Accept and return EMACS_INT for sizes.
3303 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3304 et seq.
3305 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3306 Accept and return EMACS_INT.
3307 (emacs_gnutls_write): Return the number of bytes written on
3308 partial writes.
3309 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3310 (emacs_read, emacs_write): Remove check for negative size, as the
3311 Emacs source code has been audited now.
3312 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3313 (emacs_read, emacs_write): Use it.
3314 * process.c (send_process): Adjust to the new signatures of
3315 emacs_write and emacs_gnutls_write. Do not attempt to store
3316 a byte offset into an 'int'; it might overflow.
3317 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3318
3319 * sound.c: Don't assume sizes fit in 'int'.
3320 (struct sound_device.period_size, alsa_period_size):
3321 Return EMACS_INT, not int.
3322 (struct sound_device.write, vox_write, alsa_write):
3323 Accept EMACS_INT, not int.
3324 (wav_play, au_play): Use EMACS_INT to store sizes and to
3325 record read return values.
3326
3327 2011-04-15 Ben Key <bkey76@gmail.com>
3328
3329 * keyboard.c (Qundefined): Don't declare static since it is used
3330 in nsfns.m.
3331 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3332 static since they are used in nsfont.m.
3333
3334 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3335
3336 * process.c (Qprocessp): Don't declare static.
3337 * lisp.h (Qprocessp): Declare again.
3338
3339 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3342
3343 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Improve C-level modularity by making more things 'static'.
3346
3347 Don't publish debugger-only interfaces to other modules.
3348 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3349 (verify_bytepos, count_markers): Move decls to the only modules
3350 that need them.
3351 * region-cache.h (pp_cache): Likewise.
3352 * window.h (check_all_windows): Likewise.
3353 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3354
3355 * sysdep.c (croak): Now static, if
3356 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3357 * syssignal.h (croak): Declare only if not static.
3358
3359 * alloc.c (refill_memory_reserve): Now static if
3360 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3361 * lisp.h (refill_memory_reserve): Declare only if not static.
3362
3363 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3364 Define only if USE_LUCID.
3365
3366 * xrdb.c (x_customization_string, x_rm_string): Now static.
3367
3368 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3369 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3370
3371 * xdisp.c (draw_row_with_mouse_face): Now static.
3372 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3373
3374 * window.h (check_all_windows): Mark externally visible.
3375
3376 * window.c (window_deletion_count): Now static.
3377
3378 * undo.c: Make symbols static if they're not exported.
3379 (last_undo_buffer, last_boundary_position, pending_boundary):
3380 Now static.
3381
3382 * textprop.c (interval_insert_behind_hooks): Now static.
3383 (interval_insert_in_front_hooks): Likewise.
3384
3385 * term.c: Make symbols static if they're not exported.
3386 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3387 (max_frame_lines, tty_set_terminal_modes):
3388 (tty_reset_terminal_modes, tty_turn_off_highlight):
3389 (get_tty_terminal): Now static.
3390 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3391 * termhooks.h (term_mouse_moveto): Do not declare if
3392 HAVE_WINDOW_SYSTEM.
3393 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3394 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3395
3396 * sysdep.c: Make symbols static if they're not exported.
3397 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3398 Now static.
3399 (sigprocmask_set, full_mask): Remove; unused.
3400 (wait_debugging): Mark as visible.
3401 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3402 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3403
3404 * syntax.c (syntax_temp): Define only if !__GNUC__.
3405
3406 * sound.c (current_sound_device, current_sound): Now static.
3407
3408 * search.c (searchbufs, searchbuf_head): Now static.
3409
3410 * scroll.c (scroll_cost): Remove; unused.
3411 * dispextern.h (scroll_cost): Remove decl.
3412
3413 * region-cache.h (pp_cache): Mark as externally visible.
3414
3415 * process.c: Make symbols static if they're not exported.
3416 (process_tick, update_tick, create_process, chan_process):
3417 (Vprocess_alist, proc_buffered_char, datagram_access):
3418 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3419 (deactivate_process): Mark defn as static, as well as decl.
3420 * lisp.h (create_process): Remove decl.
3421 * process.h (chan_process, Vprocess_alist): Remove decls.
3422
3423 * print.c: Make symbols static if they're not exported.
3424 (print_depth, new_backquote_output, being_printed, print_buffer):
3425 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3426 (print_interval, print_number_index, initial_stderr_stream):
3427 Now static.
3428 * lisp.h (Fprinc): Remove decl.
3429 (debug_output_compilation_hack): Mark as externally visible.
3430
3431 * sysdep.c (croak): Move decl from here to syssignal.h.
3432 * syssignal.h (croak): Put it here, so the API can be checked when
3433 'croak' is called from dissociate_if_controlling_tty.
3434
3435 * minibuf.c: Make symbols static if they're not exported.
3436 (minibuf_save_list, choose_minibuf_frame): Now static.
3437 * lisp.h (choose_minibuf_frame): Remove decl.
3438
3439 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3440
3441 * lread.c: Make symbols static if they're not exported.
3442 (read_objects, initial_obarray, oblookup_last_bucket_number):
3443 Now static.
3444 (make_symbol): Remove; unused.
3445 * lisp.h (initial_obarray, make_symbol): Remove decls.
3446
3447 * keyboard.c: Make symbols static if they're not exported.
3448 (single_kboard, recent_keys_index, total_keys, recent_keys):
3449 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3450 (this_single_command_key_start, echoing, last_auto_save):
3451 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3452 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3453 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3454 (Vlispy_mouse_stem, double_click_count):
3455 Now static.
3456 (force_auto_save_soon): Define only if SIGDANGER.
3457 (ignore_mouse_drag_p): Now static if
3458 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3459 (print_help): Remove; unused.
3460 (stop_character, last_timer_event): Mark as externally visible.
3461 * keyboard.h (ignore_mouse_drag_p): Declare only if
3462 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3463 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3464 * lisp.h (echoing): Remove decl.
3465 (force_auto_save_soon): Declare only if SIGDANGER.
3466 * xdisp.c (redisplay_window): Simplify code, to make it more
3467 obvious that ignore_mouse_drag_p is not accessed if !defined
3468 USE_GTK && !defined HAVE_NS.
3469
3470 * intervals.c: Make symbols static if they're not exported.
3471 (merge_properties_sticky, merge_interval_right, delete_interval):
3472 Now static.
3473 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3474
3475 * insdel.c: Make symbols static if they're not exported.
3476 However, leave prepare_to_modify_buffer alone. It's never
3477 called from outside this function, but that appears to be a bug.
3478 (combine_after_change_list, combine_after_change_buffer):
3479 (adjust_after_replace, signal_before_change): Now static.
3480 (adjust_after_replace_noundo): Remove; unused.
3481 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3482 (signal_before_change): Remove decls.
3483
3484 * indent.c (val_compute_motion, val_vmotion): Now static.
3485
3486 * image.c: Make symbols static if they're not exported.
3487 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3488 if USE_GTK.
3489 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3490 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3491
3492 * fringe.c (standard_bitmaps): Now static.
3493 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3494
3495 * frame.c: Make symbols static if they're not exported.
3496 (x_report_frame_params, make_terminal_frame): Now static.
3497 (get_frame_param): Now static, unless HAVE_NS.
3498 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3499 (x_get_resource_string): Remove; not used.
3500 * frame.h (make_terminal_frame, x_report_frame_params):
3501 (x_get_resource_string); Remove decls.
3502 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3503 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3504
3505 * font.c, fontset.c: Make symbols static if they're not exported.
3506 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3507 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3508 * font.c (font_close_object): Now static.
3509 * font.h (font_close_object): Remove.
3510 * fontset.c (FONTSET_OBJLIST): Remove.
3511 (free_realized_fontset) #if-0 the body, which does nothing.
3512 (face_suitable_for_char_p): #if-0, as it's never called.
3513 * fontset.h (face_suitable_for_char_p): Remove decl.
3514 * xfaces.c (face_at_string_position):
3515 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3516 since 0 is always ASCII.
3517
3518 * fns.c (weak_hash_tables): Now static.
3519
3520 * fileio.c: Make symbols static if they're not exported.
3521 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3522 (Vwrite_region_annotation_buffers): Now static.
3523
3524 * eval.c: Make symbols static if they're not exported.
3525 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3526 * lisp.h (backtrace_list): Remove decl.
3527
3528 * emacs.c: Make symbols static if they're not exported.
3529 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3530 (fatal_error_code, fatal_error_signal_hook, standard_args):
3531 Now static.
3532 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3533 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3534 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3535 * lisp.h (fatal_error_signal_hook): Remove decl.
3536 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3537
3538 * editfns.c: Move a (normally-unused) function to its only use.
3539 * editfns.c, lisp.h (get_operating_system_release): Remove.
3540 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3541 worth the hassle of breaking this out.
3542
3543 * xterm.c: Make symbols static if they're not exported.
3544 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3545 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3546 (x_destroy_window, x_delete_display):
3547 Now static.
3548 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3549 (x_mouse_leave): Remove; unused.
3550 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3551 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3552 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3553 Remove decls.
3554 (x_mouse_leave): Declare only if WINDOWSNT.
3555 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3556 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3557 USE_X_TOOLKIT.
3558
3559 * ftxfont.c: Make symbols static if they're not exported.
3560 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3561 HAVE_FREETYPE.
3562 * font.h (ftxfont_driver): Likewise.
3563
3564 * xfns.c: Make symbols static if they're not exported.
3565 (x_last_font_name, x_display_info_for_name):
3566 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3567 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3568 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3569 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3570 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3571 (last_show_tip_args): Now static.
3572 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3573 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3574 (x_screen_planes): Remove; unused.
3575 * dispextern.h (x_screen_planes): Remove decl.
3576
3577 * dispnew.c: Make symbols static if they're not exported.
3578 * dispextern.h (redraw_garbaged_frames, scrolling):
3579 (increment_row_positions): Remove.
3580 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3581 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3582 Now static.
3583 (redraw_garbaged_frames): Remove; unused.
3584
3585 * xfaces.c: Make symbols static if they're not exported.
3586 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3587 Remove decls.
3588 * xterm.h (defined_color): Remove decls.
3589 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3590 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3591 (menu_face_changed_default, defined_color, free_realized_face):
3592 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3593 (ascii_face_of_lisp_face): Remove; unused.
3594
3595 * xdisp.c: Make symbols static if they're not exported.
3596 * dispextern.h (scratch_glyph_row, window_box_edges):
3597 (glyph_to_pixel_coords, set_cursor_from_row):
3598 (get_next_display_element, set_iterator_to_next):
3599 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3600 (show_mouse_face): Remove decls
3601 * frame.h (message_buf_print): Likewise.
3602 * lisp.h (pop_message, set_message, check_point_in_composition):
3603 Likewise.
3604 * xterm.h (set_vertical_scroll_bar): Likewise.
3605 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3606 (message_buf_print, scratch_glyph_row, displayed_buffer):
3607 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3608 (get_next_display_element, show_mouse_face, window_box_edges):
3609 (frame_to_window_pixel_xy, check_point_in_composition):
3610 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3611 (glyph_to_pixel_coords): Remove; unused.
3612
3613 * dired.c (file_name_completion): Now static.
3614
3615 * dbusbind.c (xd_in_read_queued_messages): Now static.
3616
3617 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3618 * data.c (circular_list_error): Remove.
3619
3620 * commands.h (last_point_position, last_point_position_buffer):
3621 (last_point_position_window): Remove decls.
3622 * keyboard.c: Make these variables static.
3623
3624 * coding.h (coding, code_convert_region, encode_coding_gap):
3625 Remove decls.
3626 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3627 (iso_code_class, detect_coding, code_convert_region): Now static.
3628 (encode_coding_gap): Remove; unused.
3629
3630 * chartab.c (chartab_chars, chartab_bits): Now static.
3631
3632 * charset.h (charset_iso_8859_1): Remove decl.
3633 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3634 Now static.
3635
3636 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3637 * ccl.c (Vccl_program_table): Now static.
3638 (check_ccl_update): Remove; unused.
3639
3640 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3641 * category.h: ... from here.
3642 * category.c (check_category_table, set_category_set): Now static.
3643
3644 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3645 * lisp.h: Remove these decls.
3646
3647 * buffer.c (buffer_count): Remove unused var.
3648
3649 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3650 so that it's not optimized away.
3651 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3652 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3653 exported only to the debugger.
3654
3655 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3656 * atimer.h (run_all_atimers): Remove; not exported.
3657
3658 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3659 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3660 was inaccessible from Lisp.
3661 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3662 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3663
3664 alloc.c: Import and export fewer symbols, and remove unused items.
3665 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3666 is defined.
3667 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3668 it's not optimized away by whole-program optimization.
3669 (message_enable_multibyte, free_misc): Remove.
3670 (catchlist, handlerlist, mark_backtrace):
3671 Declare only if BYTE_MARK_STACK.
3672 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3673 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3674 (message_enable_multibyte): Remove decl.
3675 (free_misc, interval_free_list, float_block, float_block_index):
3676 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3677 (cons_free_list, last_marked_index):
3678 Now static.
3679 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3680 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3681 (mark_backtrace): Define only if BYTE_MARK_STACK.
3682 * xdisp.c (message_enable_multibyte): Now static.
3683
3684 Declare Lisp_Object Q* variables to be 'static' if not exported.
3685 This makes it easier for human readers (and static analyzers)
3686 to see whether these variables are used from other modules.
3687 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3688 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3689 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3690 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3691 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3692 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3693 * xmenu.c, xselect.c:
3694 Declare Q* vars static if they are not used in other modules.
3695 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3696 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3697 Remove decls of unexported vars.
3698 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3699
3700 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3701
3702 Make Emacs functions such as Fatom 'static' by default.
3703 This makes it easier for human readers (and static analyzers)
3704 to see whether these functions can be called from other modules.
3705 DEFUN now defines a static function. To make the function external
3706 so that it can be used in other C modules, use the new macro DEFUE.
3707 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3708 (Finit_image_library):
3709 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3710 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3711 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3712 Remove decls, since these functions are now static.
3713 (Funintern, Fget_internal_run_time): New decls, since these functions
3714 were already external.
3715
3716 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3717 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3718 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3719 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3720 * keyboard.c, keymap.c, lread.c:
3721 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3722 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3723 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3724 Mark functions with DEFUE instead of DEFUN,
3725 if they are used in other modules.
3726 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3727 decls for now-static functions.
3728 * buffer.h (Fdelete_overlay): Remove decl.
3729 * callproc.c (Fgetenv_internal): Mark as internal.
3730 * composite.c (Fremove_list_of_text_properties): Remove decl.
3731 (Fcomposition_get_gstring): New forward static decl.
3732 * composite.h (Fcomposite_get_gstring): Remove decl.
3733 * dired.c (Ffile_attributes): New forward static decl.
3734 * doc.c (Fdocumntation_property): New forward static decl.
3735 * eval.c (Ffetch_bytecode): New forward static decl.
3736 (Funintern): Remove extern decl; now in .h file where it belongs.
3737 * fileio.c (Fmake_symbolic_link): New forward static decl.
3738 * image.c (Finit_image_library): New forward static decl.
3739 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3740 * intervals.h (Fprevious_property_change):
3741 (Fremove_list_of_text_properties): Remove decls.
3742 * keyboard.c (Fthis_command_keys): Remove decl.
3743 (Fcommand_execute): New forward static decl.
3744 * keymap.c (Flookup_key): New forward static decl.
3745 (Fcopy_keymap): Now static.
3746 * keymap.h (Flookup_key): Remove decl.
3747 * process.c (Fget_process): New forward static decl.
3748 (Fprocess_datagram_address): Mark as internal.
3749 * syntax.c (Fsyntax_table_p): New forward static decl.
3750 (skip_chars): Remove duplicate decl.
3751 * textprop.c (Fprevious_property_change): New forward static decl.
3752 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3753 Now internal.
3754 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3755 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3756
3757 * editfns.c (Fformat): Remove unreachable code.
3758
3759 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3760
3761 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3762 change. (Bug#8496)
3763
3764 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3765
3766 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3767 when at ZV. (Bug#8487)
3768
3769 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3770
3771 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3772 (Bug#8437)
3773 * keyboard.c (parse_tool_bar_item): Likewise.
3774 * sound.c (sound_cleanup, alsa_close): Likewise.
3775 * termcap.c (tgetent): Likewise.
3776 * xfns.c (x_default_font_parameter): Likewise.
3777 * xsettings.c (read_and_apply_settings): Likewise.
3778
3779 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3780 (overrun_check_free): Protoize.
3781
3782 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3785 since callers should never pass a negative size.
3786 Change the signature to match that of plain 'read' and 'write'; see
3787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3788 * lisp.h: Update prototypes of emacs_write and emacs_read.
3789
3790 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3791
3792 * xdisp.c (redisplay_window): Don't try to determine the character
3793 position of the scroll margin if the window start point w->startp
3794 is outside the buffer's accessible region. (Bug#8468)
3795
3796 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3797
3798 Fix write-region and its subroutines for buffers > 2GB.
3799 * fileio.c (a_write, e_write): Modify declaration of arguments and
3800 local variables to support buffers larger than 2GB.
3801 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3802
3803 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3804 argument, local variables, and return value.
3805
3806 * lisp.h: Update prototypes of emacs_write and emacs_read.
3807
3808 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3809
3810 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3813
3814 Fix more problems found by GCC 4.6.0's static checks.
3815
3816 * xdisp.c (vmessage): Use a better test for character truncation.
3817
3818 * charset.c (load_charset_map): <, not <=, for optimization,
3819 and to avoid potential problems with integer overflow.
3820 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3821 * casetab.c (set_identity, shuffle): Likewise.
3822 * editfns.c (Fformat): Likewise.
3823 * syntax.c (skip_chars): Likewise.
3824
3825 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3826 This also lets GCC 4.6.0 generate slightly better loop code.
3827
3828 * callint.c (Fcall_interactively): <, not <=, for optimization.
3829 (Fcall_interactively): Count the number of arguments produced,
3830 not the number of arguments given. This is simpler and lets GCC
3831 4.6.0 generate slightly better code.
3832
3833 * ftfont.c: Distingish more carefully between FcChar8 and char.
3834 The previous code passed unsigned char * to a functions like
3835 strlen and xstrcasecmp that expect char *, which does not
3836 conform to the C standard.
3837 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3838 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3839 char * when the C standard requires it.
3840
3841 * keyboard.c (read_char): Remove unused var.
3842
3843 * eval.c: Port to Windows vsnprintf (Bug#8435).
3844 Include <limits.h>.
3845 (SIZE_MAX): Define if the headers do not.
3846 (verror): Do not give up if vsnprintf returns a negative count.
3847 Instead, grow the buffer. This ports to Windows vsnprintf, which
3848 does not conform to C99. Problem reported by Eli Zaretskii.
3849 Also, simplify the allocation scheme, by avoiding the need for
3850 calling realloc, and removing the ALLOCATED variable.
3851
3852 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3853
3854 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3855 But keep the doprint source code for now, as we might revamp it
3856 and use it again (Bug#8435).
3857 * lisp.h (doprnt): Remove.
3858 * Makefile.in (base_obj): Remove doprnt.o.
3859 * deps.mk (doprnt.o): Remove.
3860
3861 error: Print 32- and 64-bit integers portably (Bug#8435).
3862 Without this change, on typical 64-bit hosts error ("...%d...", N)
3863 was used to print both 32- and 64-bit integers N, which relied on
3864 undefined behavior.
3865 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3866 New macro.
3867 * lisp.h (error, verror): Mark as printf-like functions.
3868 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3869 Report overflow in size calculations when allocating printf buffer.
3870 Do not truncate output string at its first null byte.
3871 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3872 Truncate the output at a character boundary, since vsnprintf does not
3873 do that.
3874 * charset.c (check_iso_charset_parameter): Convert internal
3875 character to string before calling 'error', since %c now has the
3876 printf meaning.
3877 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3878 overflow when computing char to be passed to 'error'. Do not
3879 pass Lisp_Object to 'error'; pass the integer instead.
3880 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3881 formatted with plain %d.
3882
3883 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3884
3885 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3886
3887 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3888
3889 * xterm.c (x_catch_errors): Remove duplicate declaration.
3890
3891 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3892
3893 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3894
3895 2011-04-10 Jim Meyering <meyering@redhat.com>
3896
3897 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3898 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3899 return ssize_t not "int", and use size_t as the buffer length.
3900 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3901 * gnutls.h: Update declarations.
3902 * process.c (read_process_output): Use ssize_t, to match.
3903 (send_process): Likewise.
3904
3905 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3906
3907 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3908
3909 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3910
3911 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3912 Use unsigned char, to match FcChar8 type definition.
3913
3914 * xterm.c (handle_one_xevent):
3915 * xmenu.c (create_and_show_popup_menu):
3916 * xselect.c (x_decline_selection_request)
3917 (x_reply_selection_request): Avoid type-punned deref of X events.
3918
3919 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3920
3921 Fix some uses of `int' instead of EMACS_INT.
3922 * search.c (string_match_1, fast_string_match)
3923 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3924 (scan_buffer, find_next_newline_no_quit)
3925 (find_before_next_newline, search_command, Freplace_match)
3926 (Fmatch_data): Make some `int' variables be EMACS_INT.
3927
3928 * xdisp.c (display_count_lines): 3rd argument and return value now
3929 EMACS_INT. All callers changed.
3930 (pint2hrstr): Last argument is now EMACS_INT.
3931
3932 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3933 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3934 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3935 (decode_coding_utf_16, decode_coding_emacs_mule)
3936 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3937 (decode_coding_ccl, decode_coding_charset)
3938 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3939 (decode_coding_iso_2022, decode_coding_emacs_mule)
3940 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3941 <char_offset, last_offset>: Declare EMACS_INT.
3942 (encode_coding_utf_8, encode_coding_utf_16)
3943 (encode_coding_emacs_mule, encode_invocation_designation)
3944 (encode_designation_at_bol, encode_coding_iso_2022)
3945 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3946 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3947 Declare EMACS_INT.
3948 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3949 (encode_invocation_designation): Last argument P_NCHARS is now
3950 EMACS_INT.
3951 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3952 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3953
3954 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3955 All users changed.
3956
3957 * ccl.c (Fccl_execute_on_string): Declare some variables
3958 EMACS_INT.
3959
3960 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3961
3962 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3963
3964 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3965
3966 * process.c (Fformat_network_address): Doc fix.
3967
3968 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3969
3970 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3971
3972 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3973
3974 * keyboard.c (read_char): Call Lisp function help-form-show,
3975 instead of using internal_with_output_to_temp_buffer.
3976 (Qhelp_form_show): New var.
3977 (syms_of_keyboard): Use DEFSYM macro.
3978
3979 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3980
3981 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3982
3983 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3984
3985 * process.c (Flist_processes): Remove to Lisp.
3986 (list_processes_1): Delete.
3987
3988 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3989
3990 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3991
3992 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3993
3994 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 Fix more problems found by GCC 4.6.0's static checks.
3997
3998 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3999
4000 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4001
4002 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4003
4004 * xdisp.c (vmessage): Mark as a printf-like function.
4005
4006 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4007
4008 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4009
4010 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4011 printf-like functions.
4012 (tiff_load): Add casts to remove these marks before passing them
4013 to system-supplied API.
4014
4015 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4016
4017 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4018 This avoids several warnings with gcc -Wstrict-overflow.
4019 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4020 directly, rather than having caller test rule sign. This avoids
4021 some unnecessary tests.
4022 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4023 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4024 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4025
4026 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4027 (xfont_open): Avoid unnecessary tests.
4028
4029 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4030
4031 * composite.h, composite.c (composition_gstring_put_cache):
4032 Use EMACS_INT, not int, for length.
4033
4034 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4035 breaking out part of COMPOSITION_DECODE_RULE.
4036 (COMPOSITION_DECODE_RULE): Use it.
4037 * composite.c (get_composition_id): Remove unused local vars,
4038 by using the new macro.
4039
4040 * textprop.c (set_text_properties_1): Change while to do-while,
4041 since the condition is always true at first.
4042
4043 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4044 (interval_deletion_adjustment): Return unsigned value.
4045 All uses changed.
4046
4047 * process.c (list_processes_1, create_pty, read_process_output):
4048 (exec_sentinel): Remove vars that were set but not used.
4049 (create_pty): Remove unnecessary "volatile"s.
4050 (Fnetwork_interface_info): Avoid possibility of int overflow.
4051 (read_process_output): Do adaptive read buffering even if carryover.
4052 (read_process_output): Simplify nbytes computation if buffered.
4053
4054 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4055
4056 * syntax.c (scan_words): Remove var that was set but not used.
4057 (update_syntax_table): Use unsigned instead of int.
4058
4059 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4060 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4061 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4062
4063 * print.c (print_error_message): Avoid int overflow.
4064
4065 * font.c (font_list_entities): Redo for clarity,
4066 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4067
4068 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4069 (font_score): Avoid potential overflow in diff calculation.
4070
4071 * fns.c (substring_both): Remove var that is set but not used.
4072 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4073
4074 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4075
4076 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4077 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4078 can always succeed if overflow has undefined behavior.
4079
4080 * search.c (boyer_moore, wordify): Remove vars set but not used.
4081 (wordify): Omit three unnecessary tests.
4082
4083 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4084 All callers changed. This avoids the need for an unused var.
4085
4086 * casefiddle.c (casify_region): Remove var that is set but not used.
4087
4088 * dired.c (file_name_completion): Remove var that is set but not used.
4089
4090 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4091
4092 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4093 (Finsert_file_contents): Remove unnecessary code checking fd.
4094
4095 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4096 Check for integer overflow on size calculations.
4097
4098 * buffer.c (Fprevious_overlay_change): Remove var that is set
4099 but not used.
4100
4101 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4102 Remove vars that are set but not used.
4103 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4104 (timer_check_2): Mark vars as initialized.
4105
4106 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4107
4108 * image.c (lookup_image): Remove var that is set but not used.
4109 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4110
4111 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4112 that are set but not used.
4113
4114 * xfns.c (make_invisible_cursor): Don't return garbage
4115 if XCreateBitmapFromData fails (Bug#8410).
4116
4117 * xselect.c (x_get_local_selection, x_handle_property_notify):
4118 Remove vars that are set but not used.
4119
4120 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4121 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4122
4123 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4124 Remove var that is set but not used.
4125 (scroll_bar_windows_size): Now size_t, not int.
4126 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4127 Check for overflow.
4128
4129 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4130 (map_tty_color) [!defined MSDOS]: Likewise.
4131
4132 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4133
4134 * coding.c: Remove vars that are set but not used.
4135 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4136 All callers changed.
4137 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4138 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4139 (decode_coding_charset): Remove vars that are set but not used.
4140
4141 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4142 that is set but not used.
4143
4144 * print.c (print_object): Remove var that is set but not used.
4145
4146 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4147 The gnulib version avoids calling malloc in the usual case,
4148 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4149 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4150 * filelock.c (current_lock_owner): Likewise.
4151 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4152 * sysdep.c: Include allocator.h, careadlinkat.h.
4153 (emacs_no_realloc_allocator): New static constant.
4154 (emacs_readlink): New function.
4155 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4156 ../lib/careadlinkat.h.
4157
4158 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4161 first non-nil return value).
4162
4163 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4166 if not defined (Bug#8403).
4167
4168 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4169
4170 * xdisp.c (display_count_lines): Remove parameter `start',
4171 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4172 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4173 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4174 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4175 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4176 and thereabouts. All callers changed.
4177 (get_per_char_metric): Remove parameter `f', unused since
4178 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4179
4180 2011-04-02 Jim Meyering <meyering@redhat.com>
4181
4182 do not dereference NULL upon failed strdup
4183 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4184 (ns_get_family): Likewise.
4185
4186 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4189
4190 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4191
4192 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4193 later (Bug#8403).
4194
4195 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4196
4197 Add lexical binding.
4198
4199 * window.c (Ftemp_output_buffer_show): New fun.
4200 (Fsave_window_excursion):
4201 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4202
4203 * lread.c (lisp_file_lexically_bound_p): New function.
4204 (Fload): Bind Qlexical_binding.
4205 (readevalloop): Remove `evalfun' arg.
4206 Bind Qinternal_interpreter_environment.
4207 (Feval_buffer): Bind Qlexical_binding.
4208 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4209 Mark as dynamic.
4210 (syms_of_lread): Declare `lexical-binding'.
4211
4212 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4213
4214 * keyboard.c (eval_dyn): New fun.
4215 (menu_item_eval_property): Use it.
4216
4217 * image.c (parse_image_spec): Use Ffunctionp.
4218
4219 * fns.c (concat, mapcar1): Accept byte-code-functions.
4220
4221 * eval.c (Fsetq): Handle lexical vars.
4222 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4223 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4224 (FletX, Flet): Obey lexical binding.
4225 (Fcommandp): Handle closures.
4226 (Feval): New `lexical' arg.
4227 (eval_sub): New function extracted from Feval. Use it almost
4228 everywhere where Feval was used. Look up vars in lexical env.
4229 Handle closures.
4230 (Ffunctionp): Move from subr.el.
4231 (Ffuncall): Handle closures.
4232 (apply_lambda): Remove `eval_flags'.
4233 (funcall_lambda): Handle closures and new byte-code-functions.
4234 (Fspecial_variable_p): New function.
4235 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4236 but without exporting it to Lisp.
4237
4238 * doc.c (Fdocumentation, store_function_docstring):
4239 * data.c (Finteractive_form): Handle closures.
4240
4241 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4242 interactive spec.
4243
4244 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4245 New byte-codes.
4246 (exec_byte_code): New function extracted from Fbyte_code to handle new
4247 calling convention for byte-code-functions. Add new byte-codes.
4248
4249 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4250
4251 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4252
4253 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * xdisp.c (redisplay_internal): Fix prototype.
4256
4257 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4258
4259 * xdisp.c (SCROLL_LIMIT): New macro.
4260 (try_scrolling): Use it when setting scroll_limit.
4261 Limit scrolling to 100 screen lines.
4262 (redisplay_window): Even when falling back on "recentering",
4263 position point in the window according to scroll-conservatively,
4264 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4265
4266 (try_scrolling): When point is above the window, allow searching
4267 as far as scroll_max, or one screenful, to compute vertical
4268 distance from PT to the scroll margin position. This prevents
4269 try_scrolling from unnecessarily failing when
4270 scroll-conservatively is set to a value slightly larger than the
4271 window height. Clean up the case of PT below the margin at bottom
4272 of window: scroll_max can no longer be INT_MAX. When aggressive
4273 scrolling is in use, don't let point enter the opposite scroll
4274 margin as result of the scroll.
4275 (syms_of_xdisp) <scroll-conservatively>: Document the
4276 threshold of 100 lines for never-recentering scrolling.
4277
4278 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * dispextern.h (move_it_by_lines):
4281 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4282 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4283 (message_log_check_duplicate): Remove parameters `prev_bol' and
4284 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4285 (redisplay_internal): Remove parameter `preserve_echo_area',
4286 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4287
4288 * indent.c (Fvertical_motion):
4289 * window.c (window_scroll_pixel_based, Frecenter):
4290 Don't pass `need_y_p' to `move_it_by_lines'.
4291
4292 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4293
4294 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4295 steal a few bits to be more compact.
4296 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4297 Remove unneeded casts.
4298
4299 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4300
4301 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4302
4303 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4304 binding" message (bug#7967).
4305
4306 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 Fix more problems found by GCC 4.6.0's static checks.
4309
4310 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4311 Remove unused local var.
4312
4313 * editfns.c (Fmessage_box): Remove unused local var.
4314
4315 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4316 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4317 Omit unused local vars.
4318 * window.c (shrink_windows): Omit unused local var.
4319 * menu.c (digest_single_submenu): Omit unused local var.
4320 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4321 Omit unused local var.
4322
4323 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4324 Don't assume string length fits in int.
4325 (keyremap_step, read_key_sequence): Use size_t for sizes.
4326 (read_key_sequence): Don't check last_real_key_start redundantly.
4327
4328 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4329 instead of alloca (Bug#8344).
4330
4331 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4332 (Fbacktrace_frame): Don't assume nframes fits in int.
4333
4334 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4335
4336 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4337 concerns.
4338
4339 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4340
4341 * cm.c (calccost): Turn while-do into do-while, for clarity.
4342
4343 * keyboard.c (syms_of_keyboard): Use the same style as later
4344 in this function when indexing through an array. This also
4345 works around GCC bug 48267.
4346
4347 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4348
4349 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4350
4351 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4352 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4353
4354 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4355 This avoids undefined behavior on integer overflow, and is a bit
4356 more convenient anyway since it is compared to a size_t variable.
4357
4358 Variadic C functions now count arguments with size_t, not int.
4359 This avoids an unnecessary limitation on 64-bit machines, which
4360 caused (substring ...) to crash on large vectors (Bug#8344).
4361 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4362 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4363 All variadic functions and their callers changed accordingly.
4364 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4365 * data.c (arith_driver, float_arith_driver): Likewise.
4366 * editfns.c (general_insert_function): Likewise.
4367 * eval.c (struct backtrace.nargs, interactive_p)
4368 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4369 (funcall_lambda, mark_backtrace): Likewise.
4370 * fns.c (concat): Likewise.
4371 * frame.c (x_set_frame_parameters): Likewise.
4372 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4373 0 if not found, not -1. All callers changed.
4374
4375 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4376 (stack_copy_size): Now size_t, not int.
4377 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4378
4379 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4380
4381 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4382 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4383 All callers changed.
4384
4385 * lisp.h (multibyte_char_to_unibyte):
4386 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4387 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4388 * character.h (CHAR_TO_BYTE8):
4389 * cmds.c (internal_self_insert):
4390 * editfns.c (general_insert_function):
4391 * keymap.c (push_key_description):
4392 * search.c (Freplace_match):
4393 * xdisp.c (message_dolog, set_message_1): All callers changed.
4394
4395 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4396
4397 * keyboard.c (safe_run_hook_funcall): New function.
4398 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4399 don't set the hook to nil, but remove the offending function instead.
4400 (Qcommand_hook_internal): Remove, unused.
4401 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4402 Vcommand_hook_internal.
4403
4404 * eval.c (enum run_hooks_condition): Remove.
4405 (funcall_nil, funcall_not): New functions.
4406 (run_hook_with_args): Call each function through a `funcall' argument.
4407 Remove `cond' argument, now redundant.
4408 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4409 (Frun_hook_with_args_until_failure): Adjust accordingly.
4410 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4411
4412 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4413
4414 * dispextern.h (string_buffer_position): Remove declaration.
4415
4416 * print.c (strout): Remove parameter `multibyte', unused since
4417 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4418
4419 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4420 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4421 All callers changed.
4422
4423 * w32.c (_wsa_errlist): Use braces for struct initializers.
4424
4425 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4426 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4427 All callers changed.
4428 (string_buffer_position): Likewise. Also, make static (it's never
4429 used outside xdisp.c).
4430 (cursor_row_p): Remove parameter `w', unused since
4431 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4432 (decode_mode_spec): Remove parameter `precision', introduced during
4433 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4434 All callers changed.
4435
4436 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4437
4438 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4439
4440 2011-03-27 Anders Lindgren <andlind@gmail.com>
4441
4442 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4443 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4444 (ns_update_auto_hide_menu_bar): New functions.
4445 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4446 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4447 ns_constrain_all_frames.
4448 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4449 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4450
4451 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4452
4453 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4454
4455 2011-03-27 Glenn Morris <rgm@gnu.org>
4456
4457 * syssignal.h: Replace RETSIGTYPE with void.
4458 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4459 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4460 Replace SIGTYPE with void everywhere.
4461 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4462 * s/template.h (SIGTYPE): Remove commented out definition.
4463
4464 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4465
4466 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4467 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4468
4469 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4470
4471 * w32.c (read_unc_volume): Use parameter `henum', instead of
4472 global variable `wget_enum_handle'.
4473
4474 * keymap.c (describe_vector): Remove parameters `indices' and
4475 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4476 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4477
4478 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4479
4480 * keyboard.c (timer_check): Remove parameter `do_it_now',
4481 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4482 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4483 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4484
4485 * keyboard.c (read_char):
4486 * w32menu.c (w32_menu_display_help):
4487 * xmenu.c (show_help_event, menu_help_callback):
4488 Adjust calls to `show_help_echo'.
4489
4490 * gtkutil.c (xg_maybe_add_timer):
4491 * keyboard.c (readable_events):
4492 * process.c (wait_reading_process_output):
4493 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4494
4495 * insdel.c (adjust_markers_gap_motion):
4496 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4497 (gap_left, gap_right): Don't call it.
4498
4499 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4500
4501 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4502 incurred during fontification.
4503
4504 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4505
4506 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4507 (DEFVAR_PER_BUFFER): Don't pass it.
4508
4509 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4510 (scrolling_window): Don't pass it.
4511
4512 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4513
4514 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4515
4516 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4517 and `suffix'.
4518 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4519 of variables specific to SELinux and computation of `encoded_absname'.
4520
4521 * image.c (XPutPixel): Remove unused variable `height'.
4522
4523 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4524
4525 * unexw32.c (get_section_info): Remove unused variable `section'.
4526
4527 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4528 (system_process_attributes): Remove unused variable `sess'.
4529 (sys_read): Remove unused variable `err'.
4530
4531 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4532 (w32_wnd_proc): Remove unused variable `isdead'.
4533 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4534 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4535 (x_create_tip_frame): Remove unused variable `tem'.
4536
4537 * w32inevt.c (w32_console_read_socket):
4538 Remove unused variable `no_events'.
4539
4540 * w32term.c (x_draw_composite_glyph_string_foreground):
4541 Remove unused variable `width'.
4542
4543 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4544
4545 * w32term.c (x_set_glyph_string_clipping):
4546 Don't pass uninitialized region to CombineRgn.
4547
4548 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4551 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4552 (Fx_close_connection): Remove unused variable `i'.
4553
4554 * w32font.c (w32font_draw): Return number of glyphs.
4555 (w32font_open_internal): Remove unused variable `i'.
4556 (w32font_driver): Add missing initializer.
4557
4558 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4559 (fill_in_menu): Remove unused variable `items_added'.
4560
4561 * w32term.c (last_mouse_press_frame): Remove static global variable.
4562 (w32_clip_to_row): Remove unused variable `f'.
4563 (x_delete_terminal): Remove unused variable `i'.
4564
4565 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4566 (NOTHING): Remove unused static global variable.
4567 (uniscribe_check_otf): Remove unused variable `table'.
4568 (uniscribe_font_driver): Add missing initializers.
4569
4570 2011-03-23 Julien Danjou <julien@danjou.info>
4571
4572 * term.c (Fsuspend_tty, Fresume_tty):
4573 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4574 * window.c (temp_output_buffer_show):
4575 * insdel.c (signal_before_change):
4576 * frame.c (Fhandle_switch_frame):
4577 * fileio.c (Fdo_auto_save):
4578 * emacs.c (Fkill_emacs):
4579 * editfns.c (save_excursion_restore):
4580 * cmds.c (internal_self_insert):
4581 * callint.c (Fcall_interactively):
4582 * buffer.c (Fkill_all_local_variables):
4583 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4584 Use Frun_hooks.
4585 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4586 unconditionnaly since it does the check itself.
4587
4588 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 Fix more problems found by GCC 4.5.2's static checks.
4591
4592 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4593 the first time through the loop, since we know p0 < p1 then.
4594 This also avoids a gcc -Wstrict-overflow warning.
4595
4596 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4597 leading to a memory leak, possible in functions like
4598 load_charset_map_from_file that can allocate an unbounded number
4599 of objects (Bug#8318).
4600
4601 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4602 that could (at least in theory) be that large.
4603
4604 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4605 This is less likely to overflow, and avoids undefined behavior if
4606 overflow does occur. All callers changed. Use strtoul to scan
4607 for the unsigned long integer.
4608 (pint2hrstr): Simplify and tune code slightly.
4609 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4610
4611 * scroll.c (do_scrolling): Work around GCC bug 48228.
4612 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4613
4614 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4615 This also avoids a warning with gcc -Wstrict-overflow.
4616 (validate_x_resource_name): Simplify count usage.
4617 This also avoids a warning with gcc -Wstrict-overflow.
4618
4619 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4620 fail (Bug#8306).
4621
4622 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4623
4624 * process.c (Fmake_network_process): Use socklen_t, not int,
4625 where POSIX says socklen_t is required in portable programs.
4626 This fixes a porting bug on hosts like 64-bit HP-UX, where
4627 socklen_t is wider than int (Bug#8277).
4628 (Fmake_network_process, server_accept_connection):
4629 (wait_reading_process_output, read_process_output):
4630 Likewise.
4631
4632 * process.c: Rename or move locals to avoid shadowing.
4633 (list_processes_1, Fmake_network_process):
4634 (read_process_output_error_handler, exec_sentinel_error_handler):
4635 Rename or move locals.
4636 (Fmake_network_process): Define label "retry_connect" only if needed.
4637 (Fnetwork_interface_info): Fix pointer signedness.
4638 (process_send_signal): Add cast to avoid pointer signedness problem.
4639 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4640 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4641
4642 Make tparam.h and terminfo.c consistent.
4643 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4644 Include tparam.h instead, since it declares them.
4645 * cm.h (PC): Remove extern decl; tparam.h now does this.
4646 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4647 * terminfo.c: Include tparam.h, to check interfaces.
4648 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4649 (tparam): Adjust signature to match interface in tparam.h;
4650 this removes some undefined behavior. Check that outstring and len
4651 are zero, which they always are with Emacs.
4652 * tparam.h (PC, BC, UP): New extern decls.
4653
4654 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4655 (xftfont_open): Rename locals to avoid shadowing.
4656
4657 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4658 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4659 (OTF_TAG_SYM): Omit macro if not needed.
4660 (ftfont_list): Remove unused local.
4661 (get_adstyle_property, ftfont_pattern_entity):
4662 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4663 Rename locals to avoid shadowing.
4664
4665 * xfont.c (xfont_list_family): Mark var as initialized.
4666
4667 * xml.c (make_dom): Now static.
4668
4669 * composite.c (composition_compute_stop_pos): Rename local to
4670 avoid shadowing.
4671 (composition_reseat_it): Remove unused locals.
4672 (find_automatic_composition, composition_adjust_point): Likewise.
4673 (composition_update_it): Mark var as initialized.
4674 (find_automatic_composition): Mark vars as initialized,
4675 with a FIXME (Bug#8290).
4676
4677 character.h: Rename locals to avoid shadowing.
4678 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4679 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4680 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4681 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4682 to avoid shadowing.
4683
4684 * textprop.c (property_change_between_p): Remove; unused.
4685
4686 * intervals.c (interval_start_pos): Now static.
4687
4688 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4689
4690 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4691 Rename locals to avoid shadowing.
4692
4693 * sound.c (wav_play, au_play, Fplay_sound_internal):
4694 Fix pointer signedness.
4695 (alsa_choose_format): Remove unused local var.
4696 (wav_play): Initialize a variable to 0, to prevent undefined
4697 behavior (Bug#8278).
4698
4699 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4700
4701 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4702
4703 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4704 clobbering (Bug#8298).
4705 * sysdep.c (sys_subshell): Likewise.
4706 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4707
4708 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4709 This should get cleaned up, so that child_setup has the
4710 same signature on all platforms.
4711
4712 * callproc.c (call_process_cleanup): Now static.
4713 (relocate_fd): Rename locals to avoid shadowing.
4714
4715 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4716
4717 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4718 not to be necessary, and produces flickering.
4719
4720 2011-03-20 Glenn Morris <rgm@gnu.org>
4721
4722 * config.in: Remove file.
4723
4724 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4725
4726 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4727 are now in src/globals.h.
4728 (syms_of_minibuf): Remove spurious & from previous change.
4729
4730 2011-03-20 Leo <sdl.web@gmail.com>
4731
4732 * minibuf.c (completing-read-function): New variable.
4733 (completing-read-default): Rename from completing-read.
4734 (completing-read): Call completing-read-function.
4735
4736 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4737
4738 * xfaces.c (Fx_load_color_file):
4739 Read color file from absolute filename (bug#8250).
4740
4741 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * makefile.w32-in: Update dependencies.
4744
4745 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4746
4747 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4748
4749 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 Fix more problems found by GCC 4.5.2's static checks.
4752
4753 * process.c (make_serial_process_unwind, send_process_trap):
4754 (sigchld_handler): Now static.
4755
4756 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4757 That way, the code declares only the vars that it needs.
4758 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4759 * s/cygwin.h (PTY_ITERATION): Likewise.
4760 * s/darwin.h (PTY_ITERATION): Likewise.
4761 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4762
4763 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4764 * process.c (allocate_pty): Don't declare stb unless it's needed.
4765
4766 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4767 (CONSTANTLIM): Remove; unused.
4768 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4769 Define only if needed.
4770
4771 * unexelf.c (unexec): Name an expression,
4772 to avoid gcc -Wbad-function-cast warning.
4773 Use a different way to cause a compilation error if anyone uses
4774 n rather than nn, a way that does not involve shadowing.
4775 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4776
4777 * deps.mk (unexalpha.o): Remove; unused.
4778
4779 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4780 * unexec.h: New file.
4781 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4782 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4783 Depend on unexec.h.
4784 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4785 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4786 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4787 Change as necessary to match prototype in unexec.h.
4788
4789 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4790 shadowing.
4791 (back_comment, skip_chars): Mark vars as initialized.
4792
4793 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4794 Rename locals to avoid shadowing.
4795
4796 * lread.c (read1): Rewrite so as not to use empty "else".
4797 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4798
4799 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4800
4801 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4802 warning when compiling print.c.
4803
4804 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4805 instead of using an uninitialized var.
4806 (font_sort_entities): Mark var as initialized.
4807
4808 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4809
4810 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4811 pointers to constants.
4812 (font_parse_fcname): Remove unused vars.
4813 (font_delete_unmatched): Now static.
4814 (font_get_spec): Remove; unused.
4815 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4816 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4817 Rename or move locals to avoid shadowing.
4818
4819 * fns.c (require_nesting_list, require_unwind): Now static.
4820 (Ffillarray): Rename locals to avoid shadowing.
4821
4822 * floatfns.c (domain_error2): Define only if needed.
4823 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4824
4825 * alloc.c (mark_backtrace): Move decl from here ...
4826 * lisp.h: ... to here, so that it can be checked.
4827
4828 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4829 (Fdefvar): Rewrite so as not to use empty "else".
4830 (lisp_indirect_variable): Name an expression,
4831 to avoid gcc -Wbad-function-cast warning.
4832 (Fdefvar): Rename locals to avoid shadowing.
4833
4834 * callint.c (quotify_arg, quotify_args): Now static.
4835 (Fcall_interactively): Rename locals to avoid shadowing.
4836 Use const pointer when appropriate.
4837
4838 * lisp.h (get_system_name, get_operating_system_release):
4839 Move decls here, to check interfaces.
4840 * process.c (get_operating_system_release): Move decl to lisp.h.
4841 * xrdb.c (get_system_name): Likewise.
4842 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4843 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4844 some of which prompt warnings from gcc -Wbad-function-cast.
4845 (Fformat_time_string, Fencode_time, Finsert_char):
4846 (Ftranslate_region_internal, Fformat):
4847 Rename or remove local vars to avoid shadowing.
4848 (Ftranslate_region_internal): Mark var as initialized.
4849
4850 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4851 avoid shadowing.
4852
4853 * lisp.h (eassert): Check that the argument compiles, even if
4854 ENABLE_CHECKING is not defined.
4855
4856 * data.c (Findirect_variable): Name an expression, to avoid
4857 gcc -Wbad-function-cast warning.
4858 (default_value, arithcompare, arith_driver, arith_error): Now static.
4859 (store_symval_forwarding): Rename local to avoid shadowing.
4860 (Fmake_variable_buffer_local, Fmake_local_variable):
4861 Mark variables as initialized.
4862 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4863
4864 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4865 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4866 Rename locals to avoid shadowing.
4867 (mark_stack): Move local variables into the #ifdef region where
4868 they're used.
4869 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4870 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4871 needed otherwise.
4872 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4873 (GC_STRING_CHARS): Remove; not used.
4874 (Fmemory_limit): Cast sbrk's returned value to char *.
4875
4876 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4877 avoids undefined behavior in theory.
4878
4879 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4880
4881 Use functions, not macros, for up- and down-casing (Bug#8254).
4882 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4883 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4884 to use the following functions instead of these macros.
4885 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4886 EMACS_INT, since callers assume the returned value fits in int.
4887 (upcase1): Likewise, for UPCASE_TABLE.
4888 (uppercasep, lowercasep, upcase): New static inline functions.
4889 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4890 the race-condition problem in the old DOWNCASE.
4891
4892 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4893 Rename locals to avoid shadowing.
4894 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4895 (regex_compile, re_search_2, re_match_2_internal):
4896 Remove unused local vars.
4897 (FREE_VAR): Rewrite so as not to use empty "else",
4898 which gcc can warn about.
4899 (regex_compile, re_match_2_internal): Mark locals as initialized.
4900 (RETALLOC_IF): Define only if needed.
4901 (WORDCHAR_P): Likewise. This one is never needed, but is used
4902 only in a comment talking about a compiler bug, so put inside
4903 the #if 0 of that comment.
4904 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4905 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4906 Remove; unused.
4907
4908 * search.c (boyer_moore): Rename locals to avoid shadowing.
4909 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4910 (PREV_CHAR_BOUNDARY): Likewise.
4911
4912 * search.c (simple_search): Remove unused var.
4913
4914 * dired.c (compile_pattern): Move decl from here ...
4915 * lisp.h: ... to here, so that it can be checked.
4916 (struct re_registers): New forward decl.
4917
4918 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4919
4920 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4921 All uses changed.
4922 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4923 Rename locals to avoid shadowing.
4924 (Fvertical_motion): Mark locals as initialized.
4925
4926 * casefiddle.c (casify_object, casify_region): Now static.
4927 (casify_region): Mark local as initialized.
4928
4929 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4930
4931 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4932 New macros, so that the caller can use some names other than
4933 gcpro1, gcpro2, etc.
4934 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4935 of the new macros.
4936 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4937 argument, for consistency with GCPRO2_VAR, etc: it is now the
4938 prefix of the variable, not the variable itself. All uses
4939 changed.
4940 * dired.c (directory_files_internal, file_name_completion):
4941 Rename locals to avoid shadowing.
4942
4943 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4944 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4945 dired.c's scmp function, had undefined behavior.
4946 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4947 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4948 * buffer.h: ... to here, because these macros use current_buffer,
4949 and the new implementation with inline functions needs to have
4950 current_buffer in scope now, rather than later when the macros
4951 are used.
4952 (downcase, upcase1): New static inline functions.
4953 (DOWNCASE, UPCASE1): Reimplement using these functions.
4954 This avoids undefined behavior in expressions like
4955 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4956 from race conditions in accessing the global variables
4957 case_temp1 and case_temp2.
4958 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4959 * lisp.h (case_temp1, case_temp2): Remove their decls.
4960 * character.h (ASCII_CHAR_P): Move from here ...
4961 * lisp.h: ... to here, so that the inline functions mentioned
4962 above can use them.
4963
4964 * dired.c (directory_files_internal_unwind): Now static.
4965
4966 * fileio.c (file_name_as_directory, directory_file_name):
4967 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4968 Now static.
4969 (file_name_as_directory): Use const pointers when appropriate.
4970 (Fexpand_file_name): Likewise. In particular, newdir might
4971 point at constant storage, so make it a const pointer.
4972 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4973 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4974 signedness issues.
4975 (Fset_file_times, Finsert_file_contents, auto_save_error):
4976 Rename locals to avoid shadowing.
4977
4978 * minibuf.c (choose_minibuf_frame_1): Now static.
4979 (Ftry_completion, Fall_completions): Rename or remove locals
4980 to avoid shadowing.
4981
4982 * marker.c (bytepos_to_charpos): Remove; unused.
4983
4984 * lisp.h (verify_bytepos, count_markers): New decls,
4985 so that gcc does not warn that these functions aren't declared.
4986
4987 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4988 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4989 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4990 (copy_text): Remove unused local var.
4991
4992 * filelock.c (within_one_second): Now static.
4993 (lock_file_1): Rename local to avoid shadowing.
4994
4995 * buffer.c (fix_overlays_before): Mark locals as initialized.
4996 (fix_start_end_in_overlays): Likewise. This function should be
4997 simplified by using pointers-to-pointers, but that's a different
4998 matter.
4999 (switch_to_buffer_1): Now static.
5000 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5001 (report_overlay_modification): Rename locals to avoid shadowing.
5002
5003 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5004 Fix pointer signedness issue.
5005 (sys_subshell): Mark local as volatile if checking for lint,
5006 to suppress a gcc -Wclobbered warning that does not seem to be right.
5007 (MAXPATHLEN): Define only if needed.
5008
5009 * process.c (serial_open, serial_configure): Move decls from here ...
5010 * systty.h: ... to here, so that they can be checked.
5011
5012 * fns.c (get_random, seed_random): Move extern decls from here ...
5013 * lisp.h: ... to here, so that they can be checked.
5014
5015 * sysdep.c (reset_io): Now static.
5016 (wait_for_termination_signal): Remove; unused.
5017
5018 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5019 (copy_keymap_item, append_key, push_text_char_description):
5020 Now static.
5021 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5022 (DENSE_TABLE_SIZE): Remove; unused.
5023 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5024 (describe_map_tree):
5025 Rename locals to avoid shadowing.
5026
5027 * keyboard.c: Declare functions static if they are not used elsewhere.
5028 (echo_char, echo_dash, cmd_error, top_level_2):
5029 (poll_for_input, handle_async_input): Now static.
5030 (read_char, kbd_buffer_get_event, make_lispy_position):
5031 (make_lispy_event, make_lispy_movement, apply_modifiers):
5032 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5033 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5034 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5035 (read_key_sequence, read_char): Mark locals as initialized.
5036 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5037
5038 * keyboard.h (make_ctrl_char): New decl.
5039 (mark_kboards): Move decl here ...
5040 * alloc.c (mark_kboards): ... from here.
5041
5042 * lisp.h (force_auto_save_soon): New decl.
5043
5044 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5045 (DEFINE_DUMMY_FUNCTION): New macro.
5046 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5047 Use it.
5048 (main): Add casts to avoid warnings
5049 if GCC considers string literals to be constants.
5050
5051 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5052
5053 * dbusbind.c: Pointer signedness fixes.
5054 (xd_signature, xd_append_arg, xd_initialize):
5055 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5056 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5057 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5058 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5059
5060 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5061 if GCC considers string literals to be constants.
5062 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5063
5064 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5065
5066 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5067 (print_preprocess, print_object): New macro to fix last change.
5068
5069 * print.c (print_preprocess): Don't forget font objects.
5070
5071 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * emacs.c (USAGE3): Doc fixes.
5074
5075 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5076
5077 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5078 structure.
5079
5080 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * lisp.h (VWindow_system, Qfile_name_history):
5083 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5084 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5085 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5086
5087 * w32select.c: Don't #include "keyboard.h".
5088 (run_protected): Add extern declaration for waiting_for_input.
5089
5090 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5091 * w32console.c (detect_input_pending, read_input_pending)
5092 (encode_terminal_code):
5093 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5094 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5095 (w32_system_caret_y, Qfile_name_history):
5096 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5097 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5098 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5099 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5100 * w32proc.c (Qlocal, report_file_error):
5101 * w32term.c (Vwindow_system, updating_frame):
5102 * w32uniscribe.c (initialized, uniscribe_font_driver):
5103 Remove unneeded extern declarations.
5104
5105 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5106
5107 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5108
5109 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5110
5111 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5112 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5113 These macros can no longer be used for assignment.
5114
5115 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5116 Assign struct members directly, instead of using BUF_BEGV etc.
5117 (record_buffer_markers, fetch_buffer_markers): New functions for
5118 recording and fetching special buffer markers.
5119 (set_buffer_internal_1, set_buffer_temp): Use them.
5120
5121 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5122
5123 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5124
5125 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5126 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5127
5128 * xdisp.c (hscroll_window_tree):
5129 (reconsider_clip_changes): Use PT instead of BUF_PT.
5130
5131 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5132
5133 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5134 $(EMACS_ROOT)/lib/intprops.h.
5135
5136 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 Fix more problems found by GCC 4.5.2's static checks.
5139
5140 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5141 to unsigned char * to avoid compiler diagnostic.
5142 (xg_free_frame_widgets): Make it clear that a local variable is
5143 needed only if USE_GTK_TOOLTIP.
5144 (gdk_window_get_screen): Make it clear that this macro is needed
5145 only if USE_GTK_TOOLTIP.
5146 (int_gtk_range_get_value): New function, which avoids a diagnostic
5147 from gcc -Wbad-function-cast.
5148 (xg_set_toolkit_scroll_bar_thumb): Use it.
5149 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5150 diagnostic from gcc -Wbad-function-cast.
5151 (get_utf8_string, xg_get_file_with_chooser):
5152 Rename locals to avoid shadowing.
5153 (create_dialog): Move locals to avoid shadowing.
5154
5155 * xgselect.c (xg_select): Remove unused var.
5156
5157 * image.c (four_corners_best): Mark locals as initialized.
5158 (gif_load): Initialize transparent_p to zero (Bug#8238).
5159 Mark another local as initialized.
5160 (my_png_error, my_error_exit): Mark with NO_RETURN.
5161
5162 * image.c (clear_image_cache): Now static.
5163 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5164 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5165 (x_edge_detection): Remove unnecessary cast that
5166 gcc -Wbad-function-cast diagnoses.
5167 (gif_load): Fix pointer signedness.
5168 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5169 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5170
5171 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 Improve quality of tests for time stamp overflow.
5174 For example, without this patch (encode-time 0 0 0 1 1
5175 1152921504606846976) returns the obviously-bogus value (-948597
5176 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5177 reports time overflow. See
5178 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5179 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5180 * editfns.c: Include limits.h and intprops.h.
5181 (TIME_T_MIN, TIME_T_MAX): New macros.
5182 (time_overflow): Move earlier, to before first use.
5183 (hi_time, lo_time): New functions, for an accurate test for
5184 out-of-range times.
5185 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5186 (Fget_internal_run_time): Don't assume time_t fits in int.
5187 (make_time): Use list2 instead of Fcons twice.
5188 (Fdecode_time): More accurate test for out-of-range times.
5189 (check_tm_member): New function.
5190 (Fencode_time): Use it, to test for out-of-range times.
5191 (lisp_time_argument): Don't rely on undefined left-shift and
5192 right-shift behavior when checking for time stamp overflow.
5193
5194 * editfns.c (time_overflow): New function, refactoring common code.
5195 (Fformat_time_string, Fdecode_time, Fencode_time):
5196 (Fcurrent_time_string): Use it.
5197
5198 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5199 * dired.c (make_time): Move to ...
5200 * editfns.c (make_time): ... here.
5201 * systime.h: Note the move.
5202
5203 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5204
5205 * fringe.c (update_window_fringes): Remove unused variables.
5206
5207 * unexmacosx.c (copy_data_segment): Also copy __got section.
5208 (Bug#8223)
5209
5210 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5211
5212 * termcap.c [MSDOS]: Include "msdos.h".
5213 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5214 Constify `char *' arguments and their references according to
5215 prototypes in tparam.h.
5216
5217 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5218
5219 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5220 Adapt all references accordingly.
5221
5222 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5223
5224 2011-03-11 Tom Tromey <tromey@redhat.com>
5225
5226 * buffer.c (syms_of_buffer): Remove obsolete comment.
5227
5228 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5229
5230 * termhooks.h (encode_terminal_code): Declare prototype.
5231
5232 * msdos.c (encode_terminal_code): Don't declare prototype.
5233
5234 * term.c (encode_terminal_code): Now external again, used by
5235 w32console.c and msdos.c.
5236
5237 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5238 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5239
5240 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 Fix some minor problems found by GCC 4.5.2's static checks.
5243
5244 * fringe.c (update_window_fringes): Mark locals as initialized
5245 (Bug#8227).
5246 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5247
5248 * alloc.c (mark_fringe_data): Move decl from here ...
5249 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5250 to check its interface.
5251 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5252
5253 * fontset.c (free_realized_fontset): Now static.
5254 (Fset_fontset_font): Rename local to avoid shadowing.
5255 (fontset_font): Mark local as initialized.
5256 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5257
5258 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5259
5260 * xselect.c (x_disown_buffer_selections): Remove; not used.
5261 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5262 (x_own_selection, Fx_disown_selection_internal): Rename locals
5263 to avoid shadowing.
5264 (x_handle_dnd_message): Remove local to avoid shadowing.
5265
5266 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5267 so that the caller can use some name other than gcpro1.
5268 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5269 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5270 (Fx_backspace_delete_keys_p):
5271 Use them to avoid shadowing, and rename vars to avoid shadowing.
5272 (x_decode_color, x_set_name, x_window): Now static.
5273 (Fx_create_frame): Add braces to silence GCC warning.
5274 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5275 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5276 Remove unused locals.
5277 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5278 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5279 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5280 macros.
5281
5282 * xterm.h (x_mouse_leave): New decl.
5283
5284 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5285 Remove unused functions.
5286 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5287 (x_calc_absolute_position): Now static.
5288 (XTread_socket): Don't define label "out" unless it's used.
5289 Don't declare local "event" unless it's used.
5290 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5291 unless they are used.
5292 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5293 (x_fatal_error_signal): Remove; not used.
5294 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5295 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5296 (x_error_catcher, x_connection_closed, x_error_handler):
5297 (x_error_quitter, xembed_send_message, x_iconify_frame):
5298 (my_log_handler): Rename locals to avoid shadowing.
5299 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5300 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5301
5302 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5303 Rename or move locals to avoid shadowing.
5304 (tty_defined_color, merge_face_heights): Now static.
5305 (free_realized_faces_for_fontset): Remove; not used.
5306 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5307 does not deduce is never used uninitialized.
5308 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5309 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5310
5311 * terminal.c (store_terminal_param): Now static.
5312
5313 * xmenu.c (menu_highlight_callback): Now static.
5314 (set_frame_menubar): Remove unused local.
5315 (xmenu_show): Rename parameter to avoid shadowing.
5316 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5317 since they might point to immutable storage.
5318 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5319 since it's unused otherwise.
5320
5321 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5322 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5323 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5324 avoids a gcc -Wuninitialized diagnostic.
5325 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5326 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5327 does not deduce are never used uninitialized.
5328
5329 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5330
5331 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5332 * window.c (window_loop, size_window):
5333 (run_window_configuration_change_hook, enlarge_window): Likewise.
5334
5335 * window.c (display_buffer): Now static.
5336 (size_window): Mark variables that gcc -Wuninitialized
5337 does not deduce are never used uninitialized.
5338 * window.h (check_all_windows): New decl, to forestall
5339 gcc -Wmissing-prototypes diagnostic.
5340 * dispextern.h (bidi_dump_cached_states): Likewise.
5341
5342 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5343 shadowing.
5344 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5345 Include <limits.h>.
5346 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5347 and to avoid gcc -Wuninitialized warning.
5348 (load_charset_map): Mark variables that gcc -Wuninitialized
5349 does not deduce are never used uninitialized.
5350 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5351
5352 * coding.c (coding_set_source, coding_set_destination):
5353 Use "else { /* comment */ }" rather than "else /* comment */;"
5354 for clarity, and to avoid gcc -Wempty-body warning.
5355 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5356 a block, when the outer 'i' will do.
5357 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5358 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5359 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5360 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5361 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5362 Rename locals to avoid shadowing.
5363 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5364 * coding.c (emacs_mule_char, encode_invocation_designation):
5365 Now static, since they're not used elsewhere.
5366 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5367 (decode_coding_object, encode_coding_object, detect_coding_system):
5368 (decode_coding_emacs_mule): Mark variables that gcc
5369 -Wuninitialized does not deduce are never used uninitialized.
5370 (detect_coding_iso_2022): Initialize a local variable that might
5371 be used uninitialized. Leave a FIXME because it's not clear that
5372 this initialization is needed. (Bug#8211)
5373 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5374 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5375 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5376 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5377 Remove unused macros.
5378
5379 * category.c (hash_get_category_set): Remove unused local var.
5380 (copy_category_table): Now static, since it's not used elsewhere.
5381 * character.c (string_count_byte8): Likewise.
5382
5383 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5384 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5385
5386 * chartab.c (copy_sub_char_table): Now static, since it's not used
5387 elsewhere.
5388 (sub_char_table_ref_and_range, char_table_ref_and_range):
5389 Rename locals to avoid shadowing.
5390 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5391
5392 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5393 (BIDI_BOB): Remove unused macro.
5394
5395 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5396 deduce are never used uninitialized.
5397 * term.c (encode_terminal_code): Likewise.
5398
5399 * term.c (encode_terminal_code): Now static. Remove unused local.
5400
5401 * tparam.h: New file.
5402 * term.c, tparam.h: Include it.
5403 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5404 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5405 Move these decls to tparam.h, and make them agree with what
5406 is actually in tparam.c. The previous trick of using incompatible
5407 decls in different modules does not conform to the C standard.
5408 All callers of tparam changed to use tparam's actual API.
5409 * tparam.c (tparam1, tparam, tgoto):
5410 Use const pointers where appropriate.
5411
5412 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5413 * cm.h (struct cm): Likewise.
5414 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5415 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5416 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5417 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5418 (turn_on_face, init_tty): Likewise.
5419 * termchar.h (struct tty_display_info): Likewise.
5420
5421 * term.c (term_mouse_position): Rename local to avoid shadowing.
5422
5423 * alloc.c (mark_ttys): Move decl from here ...
5424 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5425
5426 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5427
5428 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5429
5430 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5431
5432 * search.c (compile_pattern_1): Remove argument regp, unused since
5433 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5434 (compile_pattern): Don't pass it.
5435
5436 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5437
5438 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5439 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5440 for ! HAVE_GTK3.
5441 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5442
5443 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5444
5445 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5446 gdk_window_get_screen, gdk_window_get_geometry,
5447 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5448 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5449 (xg_get_pixbuf_from_pixmap): New function.
5450 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5451 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5452 Call xg_get_pixbuf_from_pixmap instead of
5453 gdk_pixbuf_get_from_drawable.
5454 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5455 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5456 (xg_check_special_colors): Use GtkStyleContext and its functions
5457 for HAVE_GTK3.
5458 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5459 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5460 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5461 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5462 Call gtk_widget_get_preferred_size.
5463 (xg_frame_resized): gdk_window_get_geometry only takes 5
5464 parameters.
5465 (xg_win_to_widget, xg_event_is_for_menubar):
5466 Call gdk_x11_window_lookup_for_display.
5467 (xg_set_widget_bg): New function.
5468 (delete_cb): New function.
5469 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5470 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5471 (xg_set_background_color): Call xg_set_widget_bg.
5472 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5473 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5474 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5475 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5476 if ! HAVE_GTK3.
5477 (update_frame_tool_bar): Call gtk_widget_hide.
5478 (xg_initialize): Use GDK_KEY_g.
5479
5480 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5481 if ! HAVE_GTK3
5482 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5483
5484 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5485 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5486 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5487
5488 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5489
5490 * w32xfns.c (select_palette): Check success of RealizePalette against
5491 GDI_ERROR, not zero.
5492
5493 See ChangeLog.11 for earlier changes.
5494
5495 ;; Local Variables:
5496 ;; coding: utf-8
5497 ;; End:
5498
5499 Copyright (C) 2011 Free Software Foundation, Inc.
5500
5501 This file is part of GNU Emacs.
5502
5503 GNU Emacs is free software: you can redistribute it and/or modify
5504 it under the terms of the GNU General Public License as published by
5505 the Free Software Foundation, either version 3 of the License, or
5506 (at your option) any later version.
5507
5508 GNU Emacs is distributed in the hope that it will be useful,
5509 but WITHOUT ANY WARRANTY; without even the implied warranty of
5510 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5511 GNU General Public License for more details.
5512
5513 You should have received a copy of the GNU General Public License
5514 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.