1 2012-01-19 Kenichi Handa <handa@m17n.org>
3 * character.c (char_width): New function.
4 (Fchar_width, c_string_width, lisp_string_width):
5 Use char_width (Bug#9496).
7 2012-01-16 Martin Rudalics <rudalics@gmx.at>
9 * window.c (Vwindow_persistent_parameters): New variable.
10 (Fset_window_configuration, save_window_save): Handle persistent
13 2012-01-14 Eli Zaretskii <eliz@gnu.org>
15 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
16 thrashing the stack of the thread. (Bug#9087)
18 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
20 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
22 2012-01-11 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (rows_from_pos_range): Handle the case where the
25 highlight ends on a newline. (Bug#10464)
26 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
27 he end column for display of highlight that ends on a newline
30 2012-01-11 Glenn Morris <rgm@gnu.org>
32 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
33 from load-path also when installation-directory is nil. (Bug#10208)
35 2012-01-10 Glenn Morris <rgm@gnu.org>
37 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
39 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
40 Update template values to be closer to their typical values these days.
42 2012-01-09 Eli Zaretskii <eliz@gnu.org>
44 * xdisp.c (rows_from_pos_range): Accept additional argument
45 DISP_STRING, and accept any glyph in a row whose object is that
46 string as eligible for mouse highlight. Fixes mouse highlight of
47 display strings from overlays. (Bug#10464)
49 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
51 emacs: fix an auto-save permissions race condition (Bug#10400)
52 * fileio.c (auto_saving_dir_umask): New static var.
53 (Fmake_directory_internal): Use it.
54 (do_auto_save_make_dir): Set it, instead of invoking chmod after
55 creating the directory. The old code temporarily assigns
56 too-generous permissions to the directory.
57 (do_auto_save_eh): Clear it.
58 (Fdo_auto_save): Catch all errors, not just file errors, so
59 that the var is always cleared.
61 2012-01-07 Eli Zaretskii <eliz@gnu.org>
63 * search.c (scan_buffer): Pass character positions to
64 know_region_cache, not byte positions. (Bug#6540)
66 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
68 * w32.c (sys_rename): Report EXDEV when rename of a directory
69 fails because the target is on another logical disk. (Bug#10284)
71 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
73 * xterm.c (x_embed_request_focus): New function.
75 * xterm.h: Add prototype.
77 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
79 2012-01-05 Glenn Morris <rgm@gnu.org>
81 * emacs.c (emacs_copyright): Update short copyright year to 2012.
83 2012-01-01 Eli Zaretskii <eliz@gnu.org>
85 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
86 Load gnutls_transport_set_lowat only if GnuTLS version is below
88 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
89 GnuTLS versions below 2.11.1.
91 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
93 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
94 to the doc string advising against its use for altering the way
97 2011-12-28 Kenichi Handa <handa@m17n.org>
99 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
100 coding-system ASCII compatible only when it does not produce BOM
101 on encoding (Bug#10383).
103 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
105 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
107 (create_and_show_popup_menu): Always use menu_position_func for
110 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
112 * callint.c (Fcall_interactively): Don't truncate prompt string.
114 2011-12-23 Eli Zaretskii <eliz@gnu.org>
116 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
117 property that ends at ZV, so that the bidi iteration could be
118 resumed from there (after widening). (Bug#10360)
120 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
122 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
124 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
126 * nsterm.m (x_free_frame_resources):
127 Release f->output_data.ns->miniimage.
128 (ns_index_color): Fix indentation. Do not retain
129 color_table->colors[i].
131 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
134 * nsfns.m (x_set_background_color): Assign return value from
135 ns_index_color to face-background instead of NSColor*.
136 (ns_implicitly_set_icon_type): Fix indentation.
137 Change assignment in for loop to comparison.
139 * emacs.c (ns_pool): New variable.
140 (main): Assign ns_pool.
141 (Fkill_emacs): Call ns_release_autorelease_pool.
143 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
144 autorelease fdesc, release fdAttrs and tdict.
145 (ns_get_covering_families): Release charset.
146 (ns_findfonts): Release NSFontDescriptor created with new.
147 (ns_uni_to_glyphs): Fix indentation.
148 (setString): Release attrStr before assigning new value.
150 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
152 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
154 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
155 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
157 2011-12-18 David Reitter <reitter@cmu.edu>
159 * nsterm.m (ns_term_init): Subscribe for notifications
160 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
161 to method trackingNotification in EmacsMenu.
163 * nsmenu.m (trackingMenu): New variable.
164 (trackingNotification): New method (from Aquamacs).
165 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
166 from Aquamacs (Bug#7030).
168 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
170 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
171 (symbol_to_nsstring): Fix indentation.
172 (ns_symbol_to_pb): New function.
173 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
174 (Fns_rotate_cut_buffers_internal): Removed.
175 (Fns_store_selection_internal): Renamed from
176 Fns_store_cut_buffer_internal.
177 (ns_get_foreign_selection, Fx_own_selection_internal)
178 (Fx_disown_selection_internal, Fx_selection_exists_p)
179 (Fns_get_selection_internal, Fns_store_selection_internal):
180 Use ns_symbol_to_pb and check if return value is nil.
181 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
182 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
183 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
184 renamed to Sns_store_selection_internal.
185 (ns_handle_selection_request): Move code to Fx_own_selection_internal
186 and remove this function.
187 (ns_handle_selection_clear): Remove, never used.
188 (Fx_own_selection_internal): Move code from ns_handle_selection_request
191 2011-12-17 Ken Brown <kbrown@cornell.edu>
193 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
194 GID is unknown (Bug#10257).
196 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
198 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
199 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
200 which caused a build failure on GNU/Linux IA-64. This problem was
201 introduced by my 2011-10-07 patch.
203 2011-12-15 Juri Linkov <juri@jurta.org>
205 * image.c (imagemagick_error): New function. (Bug#10112)
206 (imagemagick_load_image): Comment out `MagickSetResolution' call.
207 Use `imagemagick_error' where ImageMagick functions return
209 (Fimagemagick_types): Add `Fnreverse' to return the list in the
212 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
214 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
215 fill background (Bug#8992).
217 2011-12-13 Martin Rudalics <rudalics@gmx.at>
219 * window.c (Vwindow_combination_resize)
220 (Vwindow_combination_limit): Use t instead of non-nil in
222 (Vrecenter_redisplay): Add first sentence of doc-string on
224 (Frecenter): Fix doc-string typo.
226 2011-12-11 Kenichi Handa <handa@m17n.org>
228 * coding.c (Funencodable_char_position): Pay attention to the
229 buffer text relocation (Bug#9389).
231 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
233 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
234 gtk_init (Bug#10100).
236 2011-12-10 Eli Zaretskii <eliz@gnu.org>
238 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
239 IT->string is nil. (Bug#10263)
241 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
243 * nsterm.h (x_free_frame_resources): Declare.
245 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
246 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
248 * nsterm.h (ns_get_defaults_value): Declare.
250 * nsterm.m (ns_default): Call ns_get_defaults_value.
252 2011-12-09 Eli Zaretskii <eliz@gnu.org>
254 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
257 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
259 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
260 that where the value of an _OBJC_* symbol points to is in the .bss
263 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
265 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
266 after the loop to call ccl_driver at least once (Bug#8619).
268 2011-12-08 Kenichi Handa <handa@m17n.org>
270 * ftfont.c (get_adstyle_property): Fix previous change
273 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
275 * w32.c (init_environment): If no_site_lisp, remove site-lisp
276 dirs from the default value of EMACSLOADPATH (bug#10208).
278 2011-12-07 Glenn Morris <rgm@gnu.org>
280 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
281 installation and source directories as well. (Bug#10208)
283 2011-12-06 Chong Yidong <cyd@gnu.org>
285 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
287 2011-12-06 Glenn Morris <rgm@gnu.org>
289 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
290 as an error, not just -1. (Bug#10217)
292 2011-12-05 Chong Yidong <cyd@gnu.org>
294 * keyboard.c (process_special_events): New function.
295 (swallow_events, Finput_pending_p): Use it (Bug#10195).
297 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
299 * coding.c (encode_designation_at_bol): Don't use uninitialized
300 local variable (Bug#9318).
302 2011-12-05 Kenichi Handa <handa@m17n.org>
304 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
305 return Qnil (Bug#8046, Bug#10193).
307 2011-12-05 Kenichi Handa <handa@m17n.org>
309 * coding.c (encode_designation_at_bol): New args charbuf_end and
310 dst. Return the number of produced bytes. Callers changed.
311 (coding_set_source): Return how many bytes coding->source was
313 (coding_set_destination): Return how many bytes
314 coding->destination was relocated.
315 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
316 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
318 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
320 * coding.c (CODING_CHAR_CHARSET_P): New macro.
321 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
324 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
326 The following changes are to fix Bug#9318.
328 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
329 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
330 (encode_coding_iso_2022, encode_coding_sjis)
331 (encode_coding_big5, encode_coding_charset): Use the above macros.
333 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
335 * lisp.h (process_quit_flag): Fix external declaration.
337 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
339 Don't macro-inline non-performance-critical code.
340 * eval.c (process_quit_flag): New function.
341 * lisp.h (QUIT): Use it.
343 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
345 * nsfns.m (get_geometry_from_preferences): New function.
346 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
348 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
350 * emacs.c (Qkill_emacs): Define.
351 (syms_of_emacs): Initialize it.
352 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
353 Qquit_flag to `kill-emacs' instead.
354 (quit_throw_to_read_char): Add parameter `from_signal'.
355 All callers changed. Call Fkill_emacs if requested and safe.
356 * lisp.h (QUIT): Call Fkill_emacs if requested.
358 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
360 * widget.c (update_wm_hints): Return if wmshell is null.
361 (widget_update_wm_size_hints): New function.
363 * widget.h (widget_update_wm_size_hints): Declare.
365 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
366 widget_update_wm_size_hints (Bug#10104).
368 2011-12-03 Eli Zaretskii <eliz@gnu.org>
370 * xdisp.c (handle_invisible_prop): If the invisible text ends just
371 before a newline, prepare the bidi iterator for consuming the
372 newline, and keep the current paragraph direction. (Bug#10183)
373 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
375 2011-12-02 Juri Linkov <juri@jurta.org>
377 * search.c (Fword_search_regexp): New Lisp function created from
378 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
379 (Fword_search_backward, Fword_search_forward)
380 (Fword_search_backward_lax, Fword_search_forward_lax):
381 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
382 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
384 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
386 * fileio.c (Finsert_file_contents): Move after-change-function call
387 to before the "handled:" label, since all "goto handled" appear in
388 cases where the *-change-functions have already been properly called
391 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
393 * keyboard.c (interrupt_signal): Don't call kill-emacs when
394 waiting for input. (Bug#10169)
396 2011-11-30 Eli Zaretskii <eliz@gnu.org>
398 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
399 verifies glyph row's hash code--we have just reallocated the
400 glyphs, so their contents can be complete garbage. (Bug#10164)
402 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
404 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
406 2011-11-30 Eli Zaretskii <eliz@gnu.org>
408 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
409 attributes are tested _before_ calling verify_row_hash, to protect
410 against GCC re-ordering of the tests. (Bug#10164)
412 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
414 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
416 * xterm.c (handle_one_xevent): Only set async_visible and friends
417 if net_wm_state_hidden_seen is non-zero (Bug#10002)
418 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
419 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
421 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
423 Remove GCPRO-related macros that exist only to avoid shadowing locals.
424 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
425 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
426 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
427 All uses changed to use GCPRO1 etc.
428 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
429 Revert to old implementation (i.e., before 2011-03-11).
431 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
433 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
434 of scroll runs so as to avoid assigning disabled bogus rows and
435 unnecessary graphics copy operations.
437 2011-11-27 Eli Zaretskii <eliz@gnu.org>
439 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
440 (snprintf) [_MSC_VER]: Redirect to _snprintf.
441 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
442 (malloc, free, realloc, calloc): Redirect to e_* only when
445 * lisp.h (GCTYPEBITS): Move before first use.
446 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
447 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
448 this macro definition.
450 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
453 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
455 * gtkutil.c (xg_create_frame_widgets):
456 Call gtk_window_set_has_resize_grip (FALSE) if that function is
457 present with Gtk+ 2.0.
459 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
461 * fileio.c (Finsert_file_contents): Undo previous change; see
462 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
464 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
466 Rename locals to avoid shadowing.
467 * fileio.c (Finsert_file_contents):
468 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
469 * process.c (wait_reading_process_output):
470 Rename inner 'proc' to 'p' to avoid shadowing.
471 Indent for consistency with usual Emacs style.
473 2011-11-25 Eli Zaretskii <eliz@gnu.org>
475 * xdisp.c (redisplay_window): If cursor row is not fully visible
476 after recentering, and scroll-conservatively is set to a large
477 number, scroll window by a few more lines to make the cursor fully
478 visible and out of scroll-margin. (Bug#10105)
479 (start_display): Don't move to the next line if the display should
480 start at a newline that is part of a display vector or an overlay
483 2011-11-24 Juri Linkov <juri@jurta.org>
485 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
486 after the `MagickPingImage' call. (Bug#10112)
488 2011-11-23 Chong Yidong <cyd@gnu.org>
490 * window.c (Fcoordinates_in_window_p): Accept only live windows.
492 2011-11-23 Martin Rudalics <rudalics@gmx.at>
494 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
495 making another buffer current. (Bug#10114)
497 2011-11-23 Glenn Morris <rgm@gnu.org>
499 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
501 2011-11-23 Chong Yidong <cyd@gnu.org>
503 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
506 2011-11-22 Eli Zaretskii <eliz@gnu.org>
508 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
509 and header-lines, as they don't have one computed for them.
512 * .gdbinit (prow): Make displayed values more self-explaining.
515 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
517 * process.c (wait_reading_process_output): Fix asynchrounous
518 GnuTLS socket handling on some versions of the GnuTLS library.
519 (wait_reading_process_output): Add comment and URL.
521 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
523 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
525 2011-11-21 Chong Yidong <cyd@gnu.org>
527 * window.c (Fnext_window, Fprevious_window): Doc fix.
529 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
531 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
533 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
535 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
537 2011-11-20 Martin Rudalics <rudalics@gmx.at>
539 * window.c (Fset_window_combination_limit): Rename argument
541 (Vwindow_combination_limit): Remove "status" from doc-string.
543 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
545 * m/ibms390.h: Remove.
546 * m/ibms390x.h: Don't include "ibms390.h".
548 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
550 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
551 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
553 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
555 * casetab.c (Fset_case_table):
556 * charset.c (Fcharset_after): Fix typos.
558 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
560 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
561 Otherwise, valgrind does not work on some platforms.
562 Problem reported by Andreas Schwab in
563 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
564 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
565 is set, removing the need for VIRT_ADDRESS_VARIES.
566 (PURE_P): Use a more-efficient implementation that needs just one
567 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
568 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
569 to 4 (xorl, subq, cmpq, setbe).
570 * alloc.c (pure): Always extern now, since that's the
571 VIRT_ADDR_VARIES behavior.
572 (PURE_POINTER_P): Use a single comparison, not two, for
573 consistency with the new puresize.h.
574 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
575 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
576 Remove VIRT_ADDR_VARIES no longer needed.
578 2011-11-19 Eli Zaretskii <eliz@gnu.org>
580 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
581 (erase_phys_cursor, update_window_cursor, show_mouse_face)
582 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
583 behave as if the cursor position were at the window margin.
585 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
586 and the cursor position is out of bounds, behave as if the cursor
587 position were at the window margin. (Bug#10075)
589 2011-11-18 Chong Yidong <cyd@gnu.org>
591 * window.c (Fwindow_combination_limit): Make first argument
592 non-optional, since it is meaningless for live windows like the
595 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
597 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
599 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
601 * intervals.c: Fix grafting over the whole buffer (bug#10071).
602 (graft_intervals_into_buffer): Simplify.
604 2011-11-18 Eli Zaretskii <eliz@gnu.org>
606 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
607 hash values of the two rows.
608 (copy_row_except_pointers): Preserve the used[] arrays and the
609 hash values of the two rows. (Bug#10035)
610 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
612 * xdisp.c (row_hash): New function, body extracted from
613 compute_line_metrics.
614 (compute_line_metrics): Call row_hash, instead of computing the
617 * dispnew.c (verify_row_hash): Call row_hash for computing the
618 hash code of a row, instead of duplicating code from xdisp.c.
620 * dispextern.h (row_hash): Add prototype.
622 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
624 * frame.c (delete_frame): Don't delete the terminal when the last
625 X frame is closed if emacs is built with GTK toolkit.
627 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
629 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
631 2011-11-17 Martin Rudalics <rudalics@gmx.at>
633 * window.c (Vwindow_splits): Rename to
634 Vwindow_combination_resize. Suggested by Juri Linkov.
635 (Fsplit_window_internal): Use Vwindow_combination_resize instead
638 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
640 * nsfns.m (Fns_font_name):
641 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
643 2011-11-16 Martin Rudalics <rudalics@gmx.at>
645 * window.h (window): Rename slot "nest" to "combination_limit".
646 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
647 (Fset_window_nest): Rename to Fset_window_combination_limit.
648 (Vwindow_nest): Rename to Vwindow_combination_limit.
649 (recombine_windows, make_parent_window, make_window)
650 (Fsplit_window_internal, saved_window)
651 (Fset_window_configuration, save_window_save): Rename all
652 occurrences of window_nest to window_combination_limit.
654 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
656 * image.c (imagemagick_load_image): Fix typo.
658 2011-11-14 Eli Zaretskii <eliz@gnu.org>
660 * xdisp.c (display_line): Move the call to
661 highlight_trailing_whitespace before the call to
662 compute_line_metrics, since the latter needs to see the final
663 faces of all the glyphs to compute ROW's hash value.
664 Fixes assertion violations in row_equal_p. (Bug#10035)
666 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
668 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
669 just return (bug#10044).
671 2011-11-12 Eli Zaretskii <eliz@gnu.org>
673 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
674 with user-defined heap size. Bump the default size of the temacs
675 heap to 27MB, to avoid memory warning when running temacs.
676 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
678 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
679 current_matrix and desired_matrix. (Bug#9990)
680 (verify_row_hash) [XASSERTS]: New function.
681 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
682 that the hash value of glyph rows is correct.
684 2011-11-12 Martin Rudalics <rudalics@gmx.at>
686 * window.h (window): Remove splits slot.
687 * window.c (Fwindow_splits, Fset_window_splits): Remove.
688 (Fdelete_other_windows_internal, make_parent_window)
689 (make_window, Fsplit_window_internal, Fdelete_window_internal)
690 (Fset_window_configuration, save_window_save): Don't deal with
691 split status of windows.
692 (saved_window): Remove splits slot.
693 (Vwindow_splits): Rewrite doc-string.
695 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
697 * xfns.c (unwind_create_frame):
698 * nsfns.m (unwind_create_frame):
699 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
700 Vframe_list (Bug#9999).
702 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
704 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
706 2011-11-11 Kenichi Handa <handa@m17n.org>
708 * callproc.c (Fcall_process): Set the member dst_multibyte of
711 2011-11-11 Johan Bockgård <bojohan@gnu.org>
713 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
714 avoid a crash (bug#9496).
716 2011-11-09 Chong Yidong <cyd@gnu.org>
718 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
719 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
721 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
723 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
725 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
727 Avoid some portability problems by eschewing 'extern inline' functions.
728 The trivial performance wins aren't worth the portability hassles; see
729 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
731 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
732 (window_box_width, window_box_left, window_box_left_offset)
733 (window_box_right, window_box_right_offset): Undo previous change,
734 by removing the "extern"s.
735 * intervals.c (adjust_intervals_for_insertion)
736 (adjust_intervals_for_deletion): Undo previous change,
737 making these static again.
738 (offset_intervals, temp_set_point_both, temp_set_point)
739 (copy_intervals_to_string): No longer inline.
740 * xdisp.c (window_text_bottom_y, window_box_width)
741 (window_box_height, window_box_left_offset)
742 (window_box_right_offset, window_box_left, window_box_right)
743 (window_box): No longer inline.
745 2011-11-08 Chong Yidong <cyd@gnu.org>
747 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
748 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
749 Signal an error if not a live window.
750 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
751 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
753 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
755 * lisp.h (syms_of_abbrev): Remove declaration.
756 Reported by CHENG Gao <chenggao@royau.me>.
758 2011-11-07 Eli Zaretskii <eliz@gnu.org>
760 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
761 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
762 of temacs in GUI mode.
764 2011-11-07 Martin Rudalics <rudalics@gmx.at>
766 * window.h: Declare delete_all_child_windows instead of
767 delete_all_subwindows.
768 * window.c (Fwindow_nest, Fset_window_nest)
769 (Fset_window_new_total, Fset_window_new_normal)
770 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
771 (delete_all_subwindows): Rename to delete_all_child_windows.
772 (Fdelete_other_windows_internal, Fset_window_configuration):
773 Call delete_all_child_windows instead of delete_all_subwindows.
774 * frame.c (delete_frame): Call delete_all_child_windows instead
775 of delete_all_subwindows.
777 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
779 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
780 This is also needed for porting to any host where GC_MARK_STACK is
781 not GC_MAKE_GCPROS_NOOPS.
782 (which_symbols): Use it.
784 2011-11-07 Kenichi Handa <handa@m17n.org>
786 * coding.c (coding_set_destination): Check coding->src_pos only
787 when coding->src_object is a buffer (bug#9910).
789 * process.c (send_process): Set the member src_multibyte of coding
790 to 0 (bug#9911) when sending a unibyte text.
792 * callproc.c (Fcall_process): Set the member src_multibyte of
793 process_coding to 0 (bug#9912).
795 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
797 * xmenu.c (cleanup_widget_value_tree): New function.
798 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
799 calling free_menubar_widget_value_tree directly (Bug#9830).
801 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
803 Fix some portability problems with 'inline'.
804 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
805 (window_box_width, window_box_left, window_box_left_offset)
806 (window_box_right, window_box_right_offset): Declare extern.
807 Otherwise, these inline functions do not conform to C99 and
808 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
809 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
810 * intervals.c (adjust_intervals_for_insertion)
811 (adjust_intervals_for_deletion): Now extern, because otherwise the
812 extern inline functions 'offset_intervals' couldn't refer to it.
813 (static_offset_intervals): Remove.
814 (offset_intervals): Rewrite using the old contents of
815 static_offset_intervals. The old version didn't conform to C99
816 because an extern inline function contained a reference to an
817 identifier with static linkage.
819 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
821 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
824 2011-11-06 Eli Zaretskii <eliz@gnu.org>
826 * xdisp.c (init_iterator, reseat_to_string): Don't set the
827 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
828 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
829 return Qleft_to_right.
831 2011-11-06 Chong Yidong <cyd@gnu.org>
833 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
834 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
835 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
836 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
837 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
838 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
839 (Fwindow_vscroll): Doc fix.
840 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
841 argument, since it makes no sense to pass a live window and for
842 consistency with window-child.
844 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
846 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
849 2011-11-05 Jason Rumney <jasonr@gnu.org>
851 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
852 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
854 (add_font_entity_to_list): Fix logic errors in mixed boolean and
855 bitwise arithmetic preventing use of unicode-sip and non-truetype
858 2011-11-05 Eli Zaretskii <eliz@gnu.org>
860 * s/ms-w32.h (fstat, stat, utime): Move redirections to
863 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
864 initialization code to keep similarity to xfns.c after changes
867 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
869 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
870 (unwind_create_frame): New function (Bug#9943).
871 (Fx_create_frame): Restructure code to be more similar to the one in
872 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
873 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
874 Move terminal->reference_count++ just before making the frame official
877 * nsterm.m (x_free_frame_resources): New function.
878 (x_destroy_window): Move code to x_free_frame_resources.
880 * xfns.c (unwind_create_frame): Fix comment.
881 (Fx_create_frame, x_create_tip_frame):
882 Move terminal->reference_count++ just before making the frame
883 official. Move initialization of image_cache_refcount and
884 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
886 2011-11-05 Eli Zaretskii <eliz@gnu.org>
888 Support MSVC build with newer versions of Visual Studio.
889 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
890 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
893 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
894 which are not supported by MSVC.
895 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
896 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
898 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
900 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
902 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
904 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
906 Support MSVC build with newer versions of Visual Studio.
907 * w32.c: Don't include w32api.h for MSVC.
908 (init_environment) [_MSC_VER]: Call sys_access, not _access.
910 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
911 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
912 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
913 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
915 (alloca) [_MSC_VER]: Define to _alloca.
917 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
919 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
921 2011-11-04 Eli Zaretskii <eliz@gnu.org>
923 * xdisp.c (note_mouse_highlight): If either of
924 previous/next-single-property-change returns nil, treat that as
925 the beginning or the end of the buffer. (Bug#9955)
927 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
929 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
930 label is not null (Bug#9951).
931 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
934 2011-11-04 Eli Zaretskii <eliz@gnu.org>
936 * window.c (Fwindow_body_size): Mention in the doc string that the
937 return value is in frame's canonical units. (Bug#9949)
939 2011-11-03 Eli Zaretskii <eliz@gnu.org>
941 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
943 * w32fns.c (unwind_create_frame): If needed, free the glyph
944 matrices of the partially constructed frame. (Bug#9943)
945 * xfns.c (unwind_create_frame): Likewise.
947 2011-11-01 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
950 Don't stop backward scan on the continuation glyph, even though
951 its CHARPOS is positive.
952 (mouse_face_from_buffer_pos, note_mouse_highlight):
953 Rename cover_string to disp_string.
955 2011-11-01 Martin Rudalics <rudalics@gmx.at>
957 * window.c (temp_output_buffer_show): Don't use
958 Vtemp_buffer_show_specifiers.
959 (Vtemp_buffer_show_specifiers): Remove unused variable.
961 2011-10-30 Eli Zaretskii <eliz@gnu.org>
963 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
964 past the beginning of the current glyph matrix.
966 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
968 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
969 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
970 HAVE_GTK3 (Bug#9869).
972 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
973 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
975 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
977 * xterm.c: Declare x_handle_net_wm_state to return int.
978 (handle_one_xevent): Check if we are iconified but don't have
979 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
980 (get_current_wm_state): Return non-zero if not hidden,
981 check for _NET_WM_STATE_HIDDEN (Bug#9893).
982 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
983 (x_handle_net_wm_state): Return what get_current_wm_state returns.
984 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
986 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
988 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
989 so that this new function doesn't get optimized away by a
990 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
992 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
994 * frame.h (MOUSE_HL_INFO): Remove excess parens.
996 2011-10-29 Eli Zaretskii <eliz@gnu.org>
998 Fix the `xbytecode' command.
999 * .gdbinit (xprintbytestr): New command.
1000 (xwhichsymbols): Rename from `which'; all callers changed.
1001 (xbytecode): Print the byte-code string as well.
1003 2011-10-29 Kim Storm <storm@cua.dk>
1005 * alloc.c (which_symbols): New function.
1007 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1009 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1012 2011-10-29 Glenn Morris <rgm@gnu.org>
1014 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1015 Not clear what it was for, and it causes various bugs. (Bug#9839)
1017 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1020 possible random value that matches one of those tested as
1021 condition to clear the mouse face.
1023 2011-10-28 Chong Yidong <cyd@gnu.org>
1025 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1027 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1029 * window.c (make_window): Initialize phys_cursor_on_p.
1031 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1033 * lisp.h (struct Lisp_Symbol): Update comments.
1035 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1037 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1039 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1041 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1042 <oslsachem@gmail.com> for helping to debug this.
1044 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1045 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1046 (g_b_init_get_glyph_outline_w): New static variables.
1047 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1048 (GetGlyphOutlineW_Proc): New typedefs.
1049 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1050 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1052 (w32font_open_internal, compute_metrics):
1053 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1054 instead of calling the "wide" APIs directly.
1056 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1058 * w32.h (syms_of_w32font): Add prototype.
1060 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1062 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1063 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1064 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1065 (Fmove_to_window_line): Doc fix.
1067 2011-10-27 Chong Yidong <cyd@gnu.org>
1069 * process.c (make_process): Set gnutls_state to NULL.
1071 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1072 non-NULL, regardless of GNUTLS_INITSTAGE.
1073 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1074 an error. Set process slots as soon as we allocate them.
1076 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1078 2011-10-27 Chong Yidong <cyd@gnu.org>
1080 * gnutls.c (emacs_gnutls_deinit): New function.
1081 Deallocate credentials structures as well as calling gnutls_deinit.
1082 (Fgnutls_deinit, Fgnutls_boot): Use it.
1084 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1085 (deactivate_process): Call emacs_gnutls_deinit.
1087 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1089 * image.c (x_create_x_image_and_pixmap):
1090 * w32.c (sys_rename, w32_delayed_load):
1091 * w32font.c (fill_in_logfont):
1092 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1094 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1096 * w32fns.c (w32_default_color_map): New function,
1097 extracted from Fw32_default_color_map.
1098 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1100 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1102 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1104 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1106 * keyboard.c (test_undefined): New function (bug#9751).
1107 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1109 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1111 * sysdep.c (init_sys_modes): Fix the check for the controlling
1112 terminal (Bug#6649).
1114 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1116 * dispextern.h (struct bidi_it): New member next_en_type.
1118 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1119 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1120 current character, check also for next_en_type being WEAK_EN.
1121 (bidi_resolve_weak): Don't enter the expensive loop if the current
1122 position is before next_en_pos. Record the bidi type of the first
1123 non-ET, non-BN character we find, in addition to its position.
1124 (bidi_level_of_next_char): Invalidate next_en_type when
1125 next_en_pos is over-stepped.
1127 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1129 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1130 * editfns.c: Rewrite current-time-zone so that it invokes
1131 the equivalent of (format-time-string "%Z") to get the time zone name.
1132 This fixes a bug when the time zone name contains characters that
1133 need converting from the system time locale to Emacs internal format.
1134 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1135 that patch fixed format-time-string to do the conversion, but
1136 I forgot to fix current-time-zone.
1137 (format_time_string): New function, containing most of
1138 what Fformat_time_string used to contain.
1139 (Fformat_time_string): Rewrite in terms of format_time_string.
1140 This doesn't change this function's behavior.
1141 (current-time-zone): Rewrite to use format_time_string.
1142 This fixes the bug reported by Michael Schierl in
1143 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1144 Jason Rumney's 2007-06-07 change worked around this bug, but
1146 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1148 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1150 * xdisp.c (start_display): If the character at POS is displayed
1151 via a display vector, reset IT->current.dpvec_index to zero.
1152 (try_window_reusing_current_matrix): If a line ends in a display
1153 vector or the next line starts in a display vector, continue
1154 redrawing the window even though the character position of
1155 start_row was reached.
1158 2011-10-18 Chong Yidong <cyd@gnu.org>
1160 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1161 with nobreak-char-display too.
1163 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1165 Fix part 3 of bug#9771.
1166 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1167 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1168 non-neutral characters if the current character is a paragraph
1169 separator (a.k.a. Newline). This avoids running the same
1170 expensive loop twice, once when we consume the preceding newline
1171 and the other time when the line actually needs to be displayed.
1172 Avoid the loop when we see neutrals on the base embedding level
1173 following a character whose directionality is the same as the
1174 paragraph's. This avoids running the expensive loop when a line
1175 ends in a long sequence of neutrals, like control characters.
1176 Add assertion against STRONG_AL type. Slightly rearrange code
1177 that determines the type of a neutral given the first non-neutral
1179 (bidi_level_of_next_char): Set next_en_pos to zero when
1180 invalidating its info.
1182 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1184 * xdisp.c (push_display_prop): Determine whether to record string
1185 or buffer position by IT->string, not by IT->method. Allow
1186 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1187 (move_it_vertically_backward): Don't look for character position
1188 immediately after the newline when in a continuation line.
1191 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1193 * window.c (coordinates_in_window): Rewrite and delabelize
1194 vertical border check. (Bug#5357) (Bug#9618)
1196 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1198 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1199 errors in XSetWindowBorder (bug#9310).
1201 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1203 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1204 avoid crash when xmalloc overrun checking is enabled.
1206 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1208 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1209 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1210 cursor motion with <left> and <right> arrow keys.
1212 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1213 some callers set that themselves.
1215 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1217 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1218 display string and the previous row comes from the same string and
1219 is empty. (Bug#9739) (Bug#9738)
1221 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1223 * doc.c (get_doc_string): Encode file name (bug#9735).
1225 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1227 * bidi.c (bidi_level_of_next_char):
1228 * xdisp.c (get_visually_first_element): Remove old incorrect
1229 comments regarding the Unicode Line Separator character.
1231 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1233 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1235 * alloc.c (Fgc_status): Do not access beyond zombies array
1236 boundary if nzombies > MAX_ZOMBIES.
1237 * alloc.c (dump_zombies): Add missing format specifier.
1239 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1241 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1242 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1244 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1245 Some packages use them to denote characters with modifiers.
1247 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1249 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1250 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1251 matching a pp-number. Rename parameter var to var1.
1253 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1255 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1257 2011-10-08 Glenn Morris <rgm@gnu.org>
1259 * callint.c (Fcall_interactively): Give a more explicit error for the
1260 'c' case with a non-character input. (Bug#8479)
1262 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1266 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1267 lines that are hscrolled on the left.
1269 * dispnew.c (buffer_posn_from_coords): Account for a possible
1270 presence of header-line. (Bug#4426)
1272 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1274 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1275 Don't advertise functionality which we discourage or doesn't work.
1277 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1279 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1280 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1281 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1282 this makes Emacs dump core during garbage collection on rare
1283 occasions. sizeof is obviously inferior to offsetof here, so
1284 stick with offsetof.
1285 (GC_POINTER_ALIGNMENT): New macro.
1286 (mark_memory): Omit 3rd (offset) arg; caller changed.
1287 Don't assume EMACS_INT alignment is the same as pointer alignment.
1289 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1291 * keyboard.c (read_key_sequence_remapped): New var.
1292 (read_key_sequence): Compute remapping in the right buffer.
1293 (command_loop_1): Use read_key_sequence's remapping directly.
1295 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1297 * dired.c (file_name_completion): Don't expand file name.
1298 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1299 before checking file name handler.
1301 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1302 they've been requested explicitly (bug#9591).
1304 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1306 * keymap.c (Fsingle_key_description): Use make_specified_string
1307 instead of build_string to build string from push_key_description.
1310 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1312 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1313 This fixes a Y2038 bug on 64-bit hosts.
1314 * buffer.c (reset_buffer):
1315 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1316 (Fclear_buffer_auto_save_failure):
1317 Use 0, not -1, to represent an unset failure time, since time_t
1318 might not be signed.
1320 Remove dependency on glibc malloc internals.
1321 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1322 Move back here from lisp.h, but with their new implementations.
1323 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1324 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1325 * charset.c (charset_table_init): New static var.
1326 (syms_of_charset): Use it instead of xmalloc. This removes a
1327 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1328 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1329 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1330 Move back to alloc.c.
1331 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1332 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1334 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1336 * nsterm.m (windowDidResize): Call x_set_window_size only when
1337 ns_in_resize is true. Otherwise set pixelwidth/height and
1338 call change_frame_size (Bug#9628).
1340 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1342 Port --enable-checking=all to Fedora 14 x86-64.
1343 * charset.c (syms_of_charset): Also account for glibc malloc's
1344 internal overhead when calculating the initial malloc maximum.
1346 Port --enable-checking=all to Fedora 14 x86.
1347 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1349 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1350 (overrun_check_realloc, overrun_check_free):
1351 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1352 That way, xmalloc returns a properly-aligned pointer even if
1353 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1354 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1355 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1356 into account when calculating the initial malloc maximum.
1357 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1358 Move here from alloc.c, so that charset.c can use it too.
1359 Properly align; the old code wasn't right for common 32-bit hosts
1360 when configured with --enable-checking=all.
1361 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1362 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1364 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1366 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1369 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1371 * xdisp.c (compute_display_string_end): If there's no display
1372 string at CHARPOS, return -1.
1374 * bidi.c (bidi_fetch_char): When compute_display_string_end
1375 returns a negative value, treat the character as a normal
1376 character not covered by a display string. (Bug#9624)
1378 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1380 * lread.c (Fread_from_string): Fix typo in docstring.
1382 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1385 newline, reseat the iterator instead of bidi-iterating there one
1386 character at a time. (Bug#9610)
1387 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1388 TO_CHARPOS if the bidi iterator is at base embedding level.
1390 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1392 * lread.c (readevalloop): Use correct code for NBSP.
1393 (read1): Likewise. (Bug#9608)
1395 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1397 * dbusbind.c (Fdbus_register_signal): When service is not
1398 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1400 2011-09-25 Glenn Morris <rgm@gnu.org>
1402 * buffer.c (truncate-lines): Doc fix.
1404 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1406 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1407 (Fset_window_next_buffers): Doc fix.
1409 2011-09-24 Glenn Morris <rgm@gnu.org>
1411 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1413 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1415 Fix minor problems found by static checking.
1416 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1417 * indent.c (Fvertical_motion): Fix == vs = typo.
1419 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1421 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1422 Default value is now t. Doc fix.
1424 * indent.c (Fvertical_motion): Compute and apply the overshoot
1425 logic when moving up, not only when moving down. Fix the
1426 confusing name and values of the it_overshoot_expected variable;
1427 logic changes accordingly. (Bug#9254) (Bug#9549)
1429 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1430 CHARPOS is covered by a display string which includes newlines.
1431 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1432 is covered by a display string with embedded newlines.
1434 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1436 * dbusbind.c (Fdbus_register_signal): Add match rule to
1437 Vdbus_registered_objects_table. (Bug#9581)
1438 (Fdbus_register_method, Vdbus_registered_objects_table):
1441 2011-09-24 Jim Meyering <meyering@redhat.com>
1443 do not ignore write error for any output size
1444 The previous change was incomplete.
1445 While it makes emacs --batch detect the vast majority of stdout
1446 write failures, errors were still ignored whenever the output size is
1447 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1448 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1449 && echo FAIL: ignored write error
1450 FAIL: ignored write error
1451 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1452 && echo FAIL: ignored write error
1453 FAIL: ignored write error
1454 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1456 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1458 * emacs.c (Fkill_emacs): In noninteractive mode exit
1459 non-successfully if a write error occurred on stdout. (Bug#9574)
1461 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1463 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1466 * dispextern.h (struct it): Update the comment documenting what
1469 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1471 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1472 a display string, extend search for cursor position to end of row.
1473 (find_row_edges): If the row ends in a newline from a display
1474 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1475 Handle the case of a display string with multiple newlines.
1476 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1477 non-empty line. Fixes confusing cursor motion with arrow keys at
1478 the beginning of a line that starts with whitespace.
1480 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1482 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1485 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1487 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1490 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1492 * xdisp.c (display_line): Record maximum and minimum buffer
1493 positions even if no glyphs were produced (e.g., by a zero-width
1494 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1495 buffer positions that will be removed from the glyph row because
1497 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1498 column is beyond frame width: don't subtract 1 "pixel" when
1499 computing width of the stretch.
1500 (reseat_at_next_visible_line_start): Undo the change made on
1501 2011-09-17 that saved paragraph information and restored it after
1502 the call to `reseat'. (Bug#9545)
1504 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1506 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1507 and turn window cursor on if cleared (Bug#9415).
1509 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1511 * search.c (boyer_moore): Take unibyte characters from pattern
1512 literally. (Bug#9458)
1514 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1516 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1518 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1520 Fix minor problem found by static checking.
1521 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1522 initialized, to pacify gcc -Wuninitialized.
1524 * fileio.c: Report proper errno when syscall falls.
1525 (Finsert_file_contents): Save and restore errno,
1526 so that report_file_error outputs the correct diagnostic.
1527 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1529 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1531 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1533 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1535 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1536 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1538 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1540 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1541 about the current paragraph and restore it after the call to reseat.
1543 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1544 (bidi_find_paragraph_start): Search back for paragraph beginning
1545 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1546 (bidi_move_to_visually_next): Only trigger paragraph-related
1547 computations when the last character is a newline or at EOB, not
1548 just any NEUTRAL_B. (Bug#9470)
1550 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1551 truncated lines if point is covered by a display string. (Bug#9524)
1553 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1555 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1556 (cons_to_x_long): New function.
1557 (lisp_data_to_selection_data): Use it. Correct the test for
1558 short-versus-long data; it was negated. Break out of vector
1559 loop, for efficiency, when a long datum is discovered.
1561 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1563 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1565 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1567 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1568 GCC PR/17406) by declaring this function with external scope.
1570 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1572 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1573 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1575 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1577 * editfns.c (Fformat): Correctly handle text properties on "%%".
1579 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1581 * xterm.c (x_draw_composite_glyph_string_foreground):
1582 * w32term.c (x_draw_composite_glyph_string_foreground):
1583 * term.c (encode_terminal_code):
1584 * composite.c (composition_update_it, get_composition_id):
1585 * xdisp.c (get_next_display_element)
1586 (fill_composite_glyph_string): Add comments about special meaning
1587 of TAB characters in a composition.
1589 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1591 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1592 This occurs when processing a multibyte format.
1593 Problem reported by Wolfgang Jenker.
1595 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1597 * xdisp.c (try_cursor_movement): Only check for exact match if
1598 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1600 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1602 Remove unused external symbols.
1603 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1604 * xdisp.c (calc_pixel_width_or_height): Now static.
1605 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1606 * indent.c (check_display_width):
1607 * w32term.c: Fix comment to match code.
1608 * xterm.c, xterm.h (x_catching_errors): Remove.
1610 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1612 * xselect.c: Use signed conversions more consistently (Bug#9498).
1613 (selection_data_to_lisp_data): Assume incoming selection data are
1614 signed integers, not unsigned. This is to be consistent with
1615 outgoing selection data, which was modified to use signed integers
1616 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1617 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1618 expects long, not unsigned long.
1620 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1622 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1623 computation of loop end. Reported by Johan Bockgård
1626 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1628 * frame.c (Fother_visible_frames_p): Function deleted.
1630 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1632 * indent.c (compute_motion): Process display vector front to back
1633 rather than the other way around. (Bug#2496)
1635 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1637 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1639 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1641 * minibuf.c (Fread_from_minibuffer): Doc fix.
1643 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1645 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1646 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1648 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1650 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1651 value for non-existent files.
1653 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1655 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1656 set its "size" to -1. This will set the modtime_size field of
1657 the corresponding buffer to -1, which is what
1658 verify-visited-file-modtime expects for files that do not exist.
1661 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1663 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1665 * lisp.h: ... from here. push_key_description is no longer
1666 defined in keyboard.c, so its declaration should not be in
1667 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1668 logically belongs with push_key_description.
1670 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1672 * buffer.h: Include <sys/types.h> instead of <time.h>.
1673 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1674 Problem reported by Herbert J. Skuhra.
1676 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1678 * xml.c (parse_region): Make the parsing work for
1679 non-comment-starting XML files again (bug#9144).
1681 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1683 * image.c (gif_load): Fix calculation of bottom and right corner.
1686 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1688 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1689 redisplay in small windows.
1691 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1693 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1695 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1697 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1698 Operate on live windows only.
1700 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1702 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1704 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1706 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1707 only under bidi iteration.
1709 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1711 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1713 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1715 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1716 Without this fix, the command to link temacs failed due to an
1717 undefined symbol __builtin_isnan. This is because
1718 /usr/include/iso/math_c99.h #defines isnan(x) to
1719 __builtin_isnan(x), but the bundled gcc, which identifies itself
1720 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1722 * floatfns.c (isnan): #undef, and then #define to a clone of
1724 (Fisnan): Always define, since it's always available now.
1725 (syms_of_floatfns): Always define isnan at the Lisp level.
1727 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1729 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1731 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1733 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1734 The previous code assumed that file offsets (off_t values) fit in
1735 EMACS_INT variables, which is not true on typical 32-bit hosts.
1736 The code messed up by falsely reporting buffer overflow in cases
1737 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1738 when "big" contains more than 2**29 bytes, even though this
1739 inserts just one byte and does not overflow the buffer.
1740 (Finsert_file_contents): Store file offsets as off_t
1741 values, not as EMACS_INT values. Check for overflow when
1742 converting between EMACS_INT and off_t. When checking for
1743 buffer overflow or for overlap, take the offsets into account.
1744 Don't use EMACS_INT for small values where int suffices.
1745 When checking for overlap, fix a typo: ZV was used where
1746 ZV_BYTE was intended.
1747 (Fwrite_region): Don't assume off_t fits into 'long'.
1748 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1750 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1752 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1754 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1756 sprintf-related integer and memory overflow issues (Bug#9412).
1758 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1759 (esprintf, exprintf, evxprintf): New functions.
1760 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1761 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1762 (modify_event_symbol): Do not assume that the length of
1763 name_alist_or_stem is safe to alloca and fits in int.
1764 (Fexecute_extended_command): Likewise for function name and binding.
1765 (Frecursion_depth): Wrap around reliably on integer overflow.
1766 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1767 since some callers pass EMACS_INT values.
1768 (Fsingle_key_description): Don't crash if symbol name contains more
1769 than MAX_ALLOCA bytes.
1770 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1771 (get_minibuffer): Arg is now EMACS_INT, not int.
1772 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1773 (esprintf, exprintf, evxprintf): New decls.
1774 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1776 * dbusbind.c (signature_cat): New function.
1777 (xd_signature, Fdbus_register_signal):
1778 Do not overrun buffer; instead, report string overflow.
1780 * dispnew.c (add_window_display_history): Don't overrun buffer.
1781 Truncate instead; this is OK since it's just a log.
1783 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1784 even if the time zone offset is outlandishly large.
1785 Don't mishandle offset == INT_MIN.
1787 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1788 when creating daemon; the previous buffer-overflow check was incorrect.
1790 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1791 which has the guts of the old verror function.
1793 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1794 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1796 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1797 (font_unparse_xlfd): Don't blindly alloca long strings.
1798 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1799 fits in int, when using sprintf. Use single snprintf to count
1800 length of string rather than counting it via multiple sprintfs;
1801 that's simpler and more reliable.
1802 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1803 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1804 sprintf, in case result does not fit in int.
1806 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1807 (fontset_from_font): Print it.
1809 * frame.c (tty_frame_count): Now printmax_t, not int.
1810 (make_terminal_frame, set_term_frame_name): Print it.
1811 (x_report_frame_params): In X, window IDs are unsigned long,
1812 not signed long, so print them as unsigned.
1813 (validate_x_resource_name): Check for implausibly long names,
1814 and don't assume name length fits in 'int'.
1815 (x_get_resource_string): Don't blindly alloca invocation name;
1816 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1819 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1820 (xg_check_special_colors, xg_set_geometry):
1821 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1823 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1824 Use esprintf, not sprintf, in case result does not fit in int.
1826 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1827 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1828 it as a large positive number.
1829 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1830 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1832 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1833 in case result does not fit in int.
1835 * print.c (float_to_string): Detect width overflow more reliably.
1836 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1837 buffer overrun. Don't assume list length fits in 'int'. Treat
1838 print length of 0 as 0, not as infinity; to be consistent with other
1839 uses of print length in this function. Don't overflow print length
1840 index. Don't assume hash table size fits in 'long', or that
1841 vectorlike size fits in 'unsigned long'.
1843 * process.c (make_process): Use printmax_t, not int, to format
1844 process-name gensyms.
1846 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1848 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1849 to avoid potential buffer overrun.
1851 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1852 if X resource line is longer than 512 bytes.
1854 * xfns.c (x_window): Make sprintf buffer a bit bigger
1855 to avoid potential buffer overrun.
1857 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1859 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1861 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1863 Integer overflow fixes for scrolling, etc.
1864 Without these, Emacs silently mishandles large integers sometimes.
1865 For example, "C-u 4294967297 M-x recenter" was treated as if
1866 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1868 * xdisp.c (try_window_id): Check Emacs fixnum range before
1869 converting to 'int'.
1871 * window.c (window_scroll_line_based, Frecenter):
1872 Check that an Emacs fixnum is in range before assigning it to 'int'.
1873 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1874 values converted from Emacs fixnums.
1875 (Frecenter): Don't wrap around a line count if it is out of 'int'
1876 range; instead, treat it as an extreme value.
1877 (Fset_window_configuration, compare_window_configurations):
1878 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1880 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1881 that can exceed INT_MAX. Check that EMACS_INT value is in range
1882 before assigning it to the (possibly-narrower) index.
1883 (match_limit): Don't assume that a fixnum can fit in 'int'.
1885 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1888 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1889 (Fvertical_motion): Don't wrap around LINES values that don't fit
1890 in 'int'. Instead, treat them as extreme values. This is good
1891 enough for windows, which can't have more than INT_MAX lines anyway.
1893 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1895 * Require libxml/parser.h to avoid compilation warning.
1897 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1899 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1900 since this reportedly can destroy thread storage.
1902 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1904 * syntax.c (find_defun_start): Update all cache variables if
1905 exiting early (Bug#9401).
1907 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1909 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1911 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1912 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1913 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1915 * term.c (tty_append_glyph): New function.
1916 (produce_stretch_glyph): Static function and its prototype deleted.
1918 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1921 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1923 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1924 when checking :margin (Bug#9390).
1925 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1926 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1927 so that the name doesn't mislead. All uses changed.
1929 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1931 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1934 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1936 * xdisp.c (move_it_to): Don't bail out early when reaching
1937 position beyond to_charpos, if we are scanning backwards.
1938 (move_it_vertically_backward): When DY == 0, make sure we get to
1939 the first character in the line after the newline.
1941 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1943 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1944 (ccl_driver): Do not generate an out-of-range pointer.
1945 (Fccl_execute_on_string): Remove unnecessary check for
1946 integer overflow, noted by Stefan Monnier in
1947 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1948 Remove a FIXME that didn't need fixing.
1949 Simplify the newly-introduced buffer reallocation code.
1951 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1953 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1955 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1957 Integer and memory overflow issues (Bug#9196).
1959 * doc.c (get_doc_string): Rework so that
1960 get_doc_string_buffer_size is the actual buffer size, rather than
1961 being 1 less than the actual buffer size; this makes xpalloc more
1964 * image.c (x_allocate_bitmap_record, cache_image):
1965 * xselect.c (Fx_register_dnd_atom):
1966 Simplify previous changes by using xpalloc.
1968 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1969 since either will do and ptrdiff_t is convenient with xpalloc.
1971 * charset.c (charset_table_size)
1972 (struct charset_sort_data.priority): Now ptrdiff_t.
1973 (charset_compare): Don't overflow if priorities differ greatly.
1974 (Fsort_charsets): Don't assume list length fits in int.
1975 Check for size-calculation overflow when allocating sort data.
1976 (syms_of_charset): Allocate an initial charset table that is
1977 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1979 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1981 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1982 The actual value is always <= INT_MAX, and leaving it unsigned made
1983 overflow checking harder.
1985 * dispextern.h (struct glyph_matrix.rows_allocated)
1986 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1987 with xpalloc. The values are still always <= INT_MAX.
1989 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1991 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1992 (SAFE_NALLOCA): New macro.
1994 * region-cache.c (struct boundary.pos, find_cache_boundary)
1995 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1996 (set_cache_region, invalidate_region_cache)
1997 (revalidate_region_cache, know_region_cache, region_cache_forward)
1998 (region_cache_backward, pp_cache):
1999 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2000 so that ptrdiff_t * can be passed to xpalloc.
2001 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2002 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2003 (pp_cache): Don't assume cache_len fits in int.
2004 * region-cache.h: Adjust extern decls to match.
2006 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2007 EMACS_INT, since either will do, for xpalloc.
2009 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2010 (xnmalloc, xnrealloc, xpalloc): New functions.
2012 * bidi.c (bidi_shelve_header_size): New constant.
2013 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2014 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2016 * bidi.c (bidi_cache_shrink):
2017 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2019 Don't update size of array until after memory allocation succeeds,
2020 because xmalloc/xrealloc may not return.
2021 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2022 now that we have proper integer overflow checking.
2023 (record_overlay_string, overlay_strings): Catch overflows when
2024 calculating size of overlay_str_buf.
2026 * callproc.c (Fcall_process): Check for size overflow when
2027 calculating size of args2.
2028 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2029 Normally we prefer signed values, but sticking with ptrdiff_t would
2030 require adding more-complicated checks.
2032 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2033 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2034 Redo buffer-overflow calculations to avoid integer overflow.
2035 Add a FIXME comment where memory seems to be over-allocated.
2037 * character.c (Fstring): Check for size-calculation overflow.
2039 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2040 unnecessary integer overflow. Check for size overflow.
2041 (encode_coding_object): Don't update size until xmalloc succeeds.
2043 * composite.c (get_composition_id): Check for overflow in glyph
2044 length calculations.
2046 Integer and memory overflow fixes for display code.
2047 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2048 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2049 (scrolling_window): Check for overflow in size calculations.
2050 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2051 Don't assume glyph table len fits in int.
2052 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2053 (row_table_size): Now ptrdiff_t, not int.
2054 (scrolling_window): Avoid overflow in size calculations.
2055 Don't update size until allocation succeeds.
2056 * fns.c (concat): Check for overflow in size calculations.
2057 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2058 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2059 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2061 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2062 (get_doc_string): Check for size calculation overflow.
2063 Don't update size until allocation succeeds.
2064 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2065 EMACS_INT, where ptrdiff_t will do.
2066 (Fsubstitute_command_keys): Check for string overflow.
2068 * editfns.c (set_time_zone_rule): Don't assume environment length
2070 (message_length): Now ptrdiff_t, not int.
2071 (Fmessage_box): Don't update size until allocation succeeds.
2072 Don't assume message length fits in int.
2073 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2075 * emacs.c (main): Do not reallocate argv, since there is a null at
2076 the end that can be overwritten, and this way there's no need to
2077 worry about size-calculation overflow.
2078 (sort_args): Check for size-calculation overflow.
2080 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2082 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2084 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2085 (x_set_scroll_bar_width, x_figure_window_size):
2086 Check for integer overflow.
2087 (x_set_alpha): Do not assume XINT fits in int.
2089 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2090 This is for the members text_lines, text_cols, total_lines, total_cols,
2091 where the system imposes an 'int' limit.
2093 * fringe.c (Fdefine_fringe_bitmap):
2094 Don't update size until alloc works.
2096 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2097 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2099 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2100 Check for size-calculation overflow.
2101 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2102 do, as we prefer signed integers.
2103 (id_to_widget.max_size, id_to_widget.used)
2104 (xg_store_widget_in_map, xg_remove_widget_from_map)
2105 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2106 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2107 Use and return ptrdiff_t, not int.
2108 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2109 * gtkutil.h: Change prototypes to match the above.
2111 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2112 are duplicate now that they've been promoted to lisp.h.
2113 (x_allocate_bitmap_record, x_alloc_image_color)
2114 (make_image_cache, cache_image, xpm_load):
2115 Don't update size until alloc is done.
2116 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2118 Check for size calculation overflow.
2119 (ct_colors_allocated_max): New constant.
2120 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2123 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2124 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2125 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2126 Use ptrdiff_t, not int, to count maps.
2127 (read_char_minibuf_menu_prompt): Check for overflow in size
2128 calculations. Don't update size until allocation succeeds.
2129 Redo calculations to avoid overflow.
2130 * keyboard.h: Change prototypes to match the above.
2132 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2134 (current_minor_maps): Check for size calculation overflow.
2135 * keymap.h: Change prototypes to match the above.
2137 * lread.c (read1, init_obarray): Don't update size until alloc done.
2139 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2140 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2142 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2143 Now ptrdiff_t, not int.
2144 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2145 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2147 * process.c (Fnetwork_interface_list): Check for overflow
2148 in size calculation.
2150 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2152 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2153 overflow. Don't bother calling xmalloc when xrealloc will do.
2155 * search.c (Freplace_match): Check for size calculation overflow.
2156 (Fset_match_data): Don't assume list lengths fit in 'int'.
2158 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2159 for command line length. Do not attempt to address one before the
2160 beginning of an array, as that's not portable.
2162 * term.c (max_frame_lines): Remove; unused.
2163 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2165 (encode_terminal_code, calculate_costs): Check for size
2166 calculation overflow.
2167 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2168 table lengths and related sizes. Don't update size until alloc
2169 done. Redo calculations to avoid overflow.
2170 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2172 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2173 subtracting pointers.
2174 (gobble_line): Check for overflow more carefully. Don't update size
2177 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2178 Don't update size until alloc done.
2179 Redo size calculations to avoid overflow.
2180 Check for size calculation overflow.
2181 (main) [DEBUG]: Fix typo in invoking tparam1.
2183 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2184 Use ptrdiff_t, not int, for sizes.
2185 (store_mode_line_noprop_char): Don't update size until alloc done.
2187 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2188 Use ptrdiff_t, not int, for sizes.
2189 (Finternal_make_lisp_face, cache_face):
2190 Check for size calculation overflow.
2191 (cache_face): Treat size calculation overflows as if they were
2192 memory exhaustion (the usual treatment), rather than aborting.
2194 * xfns.c (x_encode_text, x_set_name_internal)
2195 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2196 sizes, since they can exceed INT_MAX in size. Check for size
2197 calculation overflow.
2199 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2200 (xg_select): Check for size calculation overflow.
2201 Don't update size until alloc done.
2203 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2204 as sprintf is limited to int lengths.
2206 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2207 (X_LONG_MIN): New macros.
2208 Use them to make the following changes clearer.
2209 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2210 This change doesn't affect the value now, but it may help remind
2211 future maintainers not to raise the value too much later.
2212 (SELECTION_QUANTUM): Remove, replacing with ...
2213 (selection_quantum): ... new function, which avoids overflow.
2215 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2216 assumption that selection length fits in 'int'.
2217 (x_reply_selection_request, x_handle_selection_request)
2218 (x_get_window_property, receive_incremental_selection)
2219 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2220 (lisp_data_to_selection_data, clean_local_selection_data):
2221 Use ptrdiff_t, not int, to record length of selection.
2222 (x_reply_selection_request, x_get_window_property)
2223 (receive_incremental_selection, x_property_data_to_lisp):
2224 Redo calculations to avoid overflow.
2225 (x_reply_selection_request): When sending hint, ceiling it at
2226 X_LONG_MAX rather than relying on wraparound overflow to send
2228 (x_get_window_property, receive_incremental_selection)
2229 (lisp_data_to_selection_data, x_property_data_to_lisp):
2230 Check for size-calculation overflow.
2231 (x_get_window_property, receive_incremental_selection)
2232 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2233 Don't store size until memory allocation succeeds.
2234 (x_get_window_property): Plug memory leak on memory exhaustion.
2235 Don't double-block input; malloc is safe here. Don't assume 2**34
2236 - 4 fits in unsigned long. Add an xassert to check
2237 XGetWindowProperty overflow. Be more careful about overflow
2238 calculations, and distinguish size from memory overflow better.
2239 (receive_incremental_selection): When tracing, don't assume
2240 unsigned int is less than INT_MAX.
2241 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2242 harmful) conversions of unsigned short to int.
2243 (lisp_data_to_selection_data): Don't assume that integers
2244 in the range -65535 through -1 fit in an X unsigned short.
2245 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2246 result parameters unless successful. Rely on cons_to_unsigned
2247 to report problems with elements; the old code wasn't right anyway.
2248 (x_check_property_data): Check for int overflow; we cannot use
2249 a wider type due to X limits.
2250 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2252 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2254 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2255 (x_term_init): Check for size calculation overflow.
2256 (x_color_cells): Don't store size until memory allocation succeeds.
2257 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2258 Don't assume alloca size is less than MAX_ALLOCA.
2259 (x_term_init): Don't assume length fits in int (sprintf is limited
2262 Use ptrdiff_t for composition IDs.
2263 * character.c (lisp_string_width):
2264 * composite.c (composition_table_size, n_compositions)
2265 (get_composition_id, composition_gstring_from_id):
2266 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2267 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2268 * window.c (Frecenter):
2269 Use ptrdiff_t, not int, for composition IDs.
2270 * composite.c (get_composition_id): Check for integer overflow.
2271 * composite.h: Adjust prototypes to match the above changes.
2273 Use ptrdiff_t for hash table indexes.
2274 * category.c (hash_get_category_set):
2275 * ccl.c (ccl_driver):
2276 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2277 * coding.c (coding_system_charset_list, detect_coding_system):
2278 * coding.h (struct coding_system.id):
2279 * composite.c (get_composition_id, gstring_lookup_cache):
2280 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2281 * image.c (xpm_get_color_table_h):
2282 * lisp.h (hash_lookup, hash_put):
2283 * minibuf.c (Ftest_completion):
2284 Use ptrdiff_t for hash table indexes, not int (which is too
2285 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2286 32-bit --with-wide-int hosts).
2288 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2289 Add a FIXME comment about memory leaks.
2290 (syms_of_charset): Don't assume xmalloc returns.
2292 Don't assume that stated character widths fit in int.
2293 * character.c (Fchar_width, c_string_width, lisp_string_width):
2294 * character.h (CHAR_WIDTH):
2295 * indent.c (MULTIBYTE_BYTES_WIDTH):
2296 Use sanitize_char_width to avoid undefined and/or bad behavior
2297 with outlandish widths.
2298 * character.h (sanitize_tab_width): Rename from sanitize_width,
2299 now that we have two such functions. All uses changed.
2300 (sanitize_char_width): New inline function.
2302 Don't assume that tab-width fits in int.
2303 * character.h (sanitize_width): New inline function.
2304 (SANE_TAB_WIDTH): New macro.
2305 (ASCII_CHAR_WIDTH): Use it.
2306 * indent.c (sane_tab_width): Remove. All uses replaced by
2307 SANE_TAB_WIDTH (current_buffer).
2308 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2310 * fileio.c: Integer overflow issues with file modes.
2311 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2313 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2314 Remove unreachable code.
2315 (read_hex, load_charset_map_from_file): Check for integer overflow.
2317 * xterm.c: don't go over XClientMessageEvent limit
2318 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2319 (x_send_scroll_bar_event): Likewise. Check that the size does not
2320 exceed limits imposed by XClientMessageEvent, as well as the usual
2321 ptrdiff_t and size_t limits.
2323 * keyboard.c: Overflow, signedness and related fixes.
2324 (make_lispy_movement): Use same integer type in forward decl
2325 that is used in the definition.
2326 (read_key_sequence, keyremap_step):
2327 Change bufsize argument back to int, undoing my 2011-03-30 change.
2328 We prefer signed types, and int is wide enough here.
2329 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2330 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2331 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2332 length, not size_t. Use ptrdiff_t for index, not int.
2333 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2334 possibility of integer overflow.
2336 Overflow, signedness and related fixes for images.
2338 * dispextern.h (struct it.stack[0].u.image.image_id)
2339 (struct_it.image_id, struct image.id, struct image_cache.size)
2340 (struct image_cache.used, struct image_cache.ref_count):
2341 * gtkutil.c (update_frame_tool_bar):
2342 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2343 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2344 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2345 * nsmenu.m (update_frame_tool_bar):
2346 * xdisp.c (calc_pixel_width_or_height):
2347 * xfns.c (image_cache_refcount):
2348 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2349 on typical 64-bit hosts.
2351 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2352 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2353 Omit unnecessary casts to int.
2354 (parse_image_spec): Check that integers fall into 'int' range
2355 when the callers expect that.
2356 (image_ascent): Redo ascent calculation to avoid int overflow.
2357 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2358 (lookup_image): Remove unnecessary tests.
2359 (xbm_image_p): Locals are now of int, not EMACS_INT,
2360 since parse_image_check makes sure they fit into int.
2361 (png_load, gif_load, svg_load_image):
2362 Prefer int to unsigned where either will do.
2363 (tiff_handler): New function, combining the cores of the
2364 old tiff_error_handler and tiff_warning_handler.
2365 This function is rewritten to use vsnprintf and thereby avoid
2366 stack buffer overflows. It uses only the features of vsnprintf
2367 that are common to both POSIX and native Microsoft.
2368 (tiff_error_handler, tiff_warning_handler): Use it.
2369 (tiff_load, gif_load, imagemagick_load_image):
2370 Don't assume :index value fits in 'int'.
2371 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2372 (imagemagick_load_image): Check that crop parameters fit into
2373 the integer types that MagickCropImage accepts. Don't assume
2374 Vimagemagick_render_type has a nonnegative value. Don't assume
2375 size_t fits in 'long'.
2376 (gs_load): Use printmax_t to print the widest integers possible.
2377 Check for integer overflow when computing image height and width.
2379 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2381 * xdisp.c (redisplay_window): Don't force window start if point
2382 will be invisible in the resulting window. (Bug#9324)
2384 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2386 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2387 the display spec is of the form `(space ...)'.
2388 (handle_display_spec): Return the value returned by
2389 handle_single_display_spec, not just 1 or zero.
2390 (handle_single_display_spec): If the display spec is of the form
2391 `(space ...)', and specifies display in the text area, return 2
2393 (try_cursor_movement): Check for the need to scroll more
2394 accurately, and prefer exact match for point under bidi.
2395 Don't advance `row' beyond the last row of the window.
2397 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2398 into disp_prop; all users changed.
2400 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2401 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2402 for the text covered by the display property.
2404 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2406 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2407 Change return value to nil.
2408 (Frecord_buffer): Delete unused function.
2410 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2412 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2413 buffers, return left-to-right.
2414 (set_cursor_from_row): Consider candidate row a win if its glyph
2415 represents a newline and point is on that newline. Fixes cursor
2416 positioning on the newline at EOL of R2L text within L2R
2417 paragraph, and vice versa.
2418 (try_cursor_movement): Check continued rows, in addition to
2419 continuation rows. Fixes unwarranted scroll when point enters a
2420 continued line of R2L text within an L2R paragraph, or vice versa.
2421 (cursor_row_p): Consider the case of point being equal to
2422 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2423 from the end of a short line to the beginning of a continued line
2424 of R2L text within L2R paragraph.
2425 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2426 composed characters.
2428 * bidi.c (bidi_check_type): Use xassert.
2429 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2432 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2434 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2437 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2439 * nsfont.m (ns_otf_to_script): Fix typo.
2441 2011-08-22 Kenichi Handa <handa@m17n.org>
2443 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2444 extra slot even if the purpose is char-code-property-table.
2446 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2448 * xdisp.c (redisplay_window): When computing centering_position,
2449 account for the height of the header line. (Bug#8874)
2451 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2452 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2453 candidate is selected by the mouse, and that candidate has a
2454 composed character under the mouse.
2456 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2457 coordinates reported by pos-visible-in-window-p for a composed
2458 character in column zero.
2460 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2462 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2464 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2466 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2467 consider it a hit if to_charpos is anywhere in the range of the
2468 composed buffer positions.
2470 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2472 * image.c (gif_load): Don't assume that each subimage has the same
2473 dimensions as the base image. Handle disposal method that is
2474 "undefined" by the gif spec (Bug#9335).
2476 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2478 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2479 (Fcondition_case): Document `debug' symbol in error handler.
2481 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2483 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2484 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2485 from an Org mode buffer to a Speedbar frame.
2487 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2488 a composition, take its buffer position from IT->cmp_it.charpos.
2489 Fixes cursor positioning at the beginning of a line that begins
2490 with a composed character.
2492 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2494 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2495 character bidirectional type, use STRONG_L instead. Fixes crashes
2496 in a buffer produced by `describe-categories'.
2498 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2499 members before the level stack, so they would be saved and
2500 restored when copying iterator state. Fixes incorrect reordering
2501 around TABs covered by display properties.
2503 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2505 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2507 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2509 * eval.c (internal_condition_case, internal_condition_case_1)
2510 (internal_condition_case_2, internal_condition_case_n):
2511 Remove unnecessary aborts (Bug#9081).
2513 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2515 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2516 has no `load' handler, try opening the file locally. (Bug#9311)
2518 2011-08-16 Ken Brown <kbrown@cornell.edu>
2520 * gmalloc.c: Expand comment.
2522 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2524 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2525 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2527 2011-08-16 Ken Brown <kbrown@cornell.edu>
2529 Fix memory allocation problems in Cygwin build (Bug#9273).
2531 * unexcw.c ( __malloc_initialized): Declare external variable.
2532 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2534 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2536 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2538 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2540 [CYGWIN] (special_realloc): New function.
2541 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2542 requests to realloc storage in the static heap.
2544 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2546 * bidi.c (bidi_initialize): Remove unused local.
2548 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2551 * biditype.h: Remove file.
2552 * makefile.w32-in ($(BLD)/bidi.$(O)):
2553 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2555 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2557 * chartab.c: Improve commentary for the uniprop_table API.
2559 * bidi.c (bidi_paragraph_init): Support zero value of
2560 bidi_ignore_explicit_marks_for_paragraph_level.
2561 (bidi_initialize): Use uniprop_table instead of including
2562 biditype.h and bidimirror.h.
2564 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2565 coordinates of the iterator when restoring from ppos_it.
2568 2011-08-14 Kenichi Handa <handa@m17n.org>
2570 * process.c (create_process): Call setup_process_coding_systems
2571 after the pid of the process is set to -1 (Bug#8162).
2573 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2575 * xdisp.c (move_it_in_display_line_to): Don't invoke
2576 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2577 ppos_it. Fixes vertical cursor motion when line beginning is
2578 covered by an image. (Bug#9296)
2580 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2582 * nsterm.h (ns_run_ascript): Declare.
2583 (NSAPP_DATA2_RUNASSCRIPT): Define.
2585 * nsfns.m (as_script, as_result, as_status): New static variables.
2586 (ns_run_ascript): New function.
2587 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2588 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2589 the event loop. Get status from as_status (Bug#7276).
2591 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2592 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2593 the event loop (Bug#7276).
2595 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2597 * gnutls.c (QCgnutls_bootprop_priority)
2598 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2599 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2600 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2601 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2602 (QCgnutls_bootprop_verify_hostname_error)
2603 (QCgnutls_bootprop_callbacks_verify): Rename from
2604 Qgnutls_bootprop_..., all uses changed.
2606 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2609 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2611 * xfaces.c (Qframe_set_background_mode): Now static.
2612 * dispextern.h (Qframe_set_background_mode): Remove decl.
2614 * process.c (Fnetwork_interface_info): Declare local only if needed.
2616 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2618 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2619 (Fnetwork_interface_list): Allocate in increments of bytes instead
2620 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2621 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2623 (struct ifflag_def): notrailers is smart on OSX.
2624 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2625 Get hardware address with getifaddrs if available.
2627 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2629 * xdisp.c (iterate_out_of_display_property): xassert that
2630 IT->position is set to within IT->object's boundaries. Break from
2631 the loop as soon as EOB is reached; avoids infloops in redisplay
2632 when IT->position is set up wrongly due to some bug.
2633 Set IT->current to match the bidi iterator unconditionally.
2634 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2635 entry. Force push_it to save on the stack the current
2636 buffer/string position, to be restored by pop_it. Fix flags in
2637 the iterator structure wrt the object coming from a display
2638 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2639 properties. (Bug#9284)
2641 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2643 * fontset.c (fontset_get_font_group): Add proper type checks.
2646 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2648 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2649 and LC_VERSION_MIN_MACOSX.
2650 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2651 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2653 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2655 * xdisp.c (forward_to_next_line_start): Allow to use the
2656 no-display-properties-and-no-overlays under bidi display.
2657 Set disp_pos in the bidi iterator to avoid searches for display
2658 properties and overlays.
2660 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2662 * editfns.c (Fset_time_zone_rule): Document relationship with the
2665 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2666 the font entity extracted from the cache (Bug#8109).
2668 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2670 * composite.c (autocmp_chars): Don't reset point. That is done by
2671 restore_point_unwind (Bug#5984).
2673 2011-08-07 Juri Linkov <juri@jurta.org>
2675 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2676 to show the arg `TIME' instead of `TIMEVAL'.
2678 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2680 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2681 display property strides EOL and includes a newline, as in
2682 longlines-mode. (Bug#9254)
2683 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2684 word-wrap under bidirectional display. (Bug#9224)
2686 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2687 is non-zero, even if the data buffer is NULL. Fixes a crash in
2688 vertical-motion with longlines-mode. (Bug#9254)
2690 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2692 * bidi.c <bidi_cache_total_alloc>: Now static.
2693 (bidi_initialize): Initialize bidi_cache_total_alloc.
2695 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2698 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2699 amount allocated this far in `bidi_cache_total_alloc'.
2700 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2701 non-zero, only free the data buffer without restoring the cache
2702 contents. All callers changed.
2704 * dispextern.h (bidi_unshelve_cache): Update prototype.
2706 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2707 (move_it_in_display_line, move_it_to)
2708 (move_it_vertically_backward, move_it_by_lines): Replace the call
2709 to xfree to an equivalent call to bidi_unshelve_cache.
2710 (move_it_in_display_line_to): Fix logic of returning
2711 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2713 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2715 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2716 came from a string character with a `cursor' property. (Bug#9229)
2718 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2720 * Makefile.in (LIB_PTHREAD): New variable.
2721 (LIBES): Add LIB_PTHREAD (Bug#9216).
2723 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2724 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2726 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2728 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2730 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2732 * xterm.c (x_find_topmost_parent): New function.
2733 (x_set_frame_alpha): Find topmost parent window with
2734 x_find_topmost_parent and set the property there also (bug#9181).
2735 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2737 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2739 * callproc.c (Fcall_process): Avoid vfork clobbering
2740 the local vars buffer, coding_systems, current_dir.
2742 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2744 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2746 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2748 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2749 so that it is not optimized away.
2751 * xdisp.c (compute_display_string_pos): Remove unused local.
2753 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2755 Fix slow cursor motion and scrolling in large buffers with
2756 selective display, like Org Mode buffers. (Bug#9218)
2758 * dispextern.h (struct bidi_it): New member disp_prop_p.
2760 * xdisp.c: Remove one-slot cache of display string positions.
2761 (compute_display_string_pos): Accept an additional argument
2762 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2763 for a display string or property. If found, set DISP_PROP_P
2766 * bidi.c (bidi_fetch_char): Accept an additional argument
2767 DISP_PROP_P, and pass it to compute_display_string_pos.
2768 Only handle text covered by a display string if DISP_PROP_P is returned
2769 non-zero. All callers of bidi_fetch_char changed.
2771 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2773 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2775 2010-12-03 Don March <don@ohspite.net>
2777 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2778 last character M-[char] is translated to ESC [char] (bug#7541).
2780 2011-08-02 Kenichi Handa <handa@m17n.org>
2782 * lisp.h (uniprop_table): Extern it.
2784 * chartab.c (uniprop_table): Make it non-static.
2786 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2788 * xdisp.c (forward_to_next_line_start): Accept additional argument
2789 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2791 (reseat_at_next_visible_line_start): Use the bidi iterator state
2792 returned by forward_to_next_line_start to restore the state of
2793 it->bidi_it after backing up to previous newline. (Bug#9212)
2795 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2797 * regex.c (re_comp): Protoize.
2798 (re_exec): Fix return type.
2799 (regexec): Fix type of `ret'. (Bug#9203)
2801 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2803 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2804 This is needed if max-image-size is a floating-point number.
2806 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2808 * print.c (print_object): Print empty symbol as ##.
2810 * lread.c (read1): Read ## as empty symbol.
2812 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2814 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2815 setting frame foreground color (Bug#9175).
2816 (x_set_background_color): Likewise.
2818 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2819 contents (Bug#9176).
2820 (EmacsTooltip -init): Remove bezels and add shadows to
2823 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2824 or scroll bar (Bug#8470).
2826 * nsfont.m (nsfont_open): Remove assignment to voffset and
2827 unnecessary vars hshink, expand, hd, full_height, min_height.
2828 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2830 * nsterm.h (nsfont_info): Remove voffset field.
2832 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2834 Implement strike-through and overline on NextStep (Bug#8863).
2836 * nsfont.m (nsfont_open): Use underline position provided by font,
2837 instead of hard-coded value of 2.
2838 (nsfont_draw): Call ns_draw_text_decoration instead.
2840 * nsterm.h: Add declaration for ns_draw_text_decoration.
2842 * nsterm.m (ns_draw_text_decoration): New function for drawing
2843 underline, overline, and strike-through.
2844 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2845 ns_draw_text_decoration. Change treatment of cursor drawing to
2846 accommodate underlining, etc.
2848 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2850 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2853 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2855 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2856 Without this fix, if a signal arrives just after memory fills up,
2857 'malloc' might be invoked reentrantly.
2859 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2860 In other words, assume that every image size is allowed, on non-X
2861 hosts. This assumption is probably wrong, but it lets Emacs compile.
2863 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2865 * regex.c (re_iswctype): Convert return values to boolean.
2867 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2869 * xdisp.c (compute_display_string_pos): Don't use cached display
2870 string position if the buffer had its restriction changed.
2873 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2875 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2877 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2879 Integer signedness and overflow and related fixes. (Bug#9079)
2881 * bidi.c: Integer size and overflow fixes.
2882 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2883 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2884 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2885 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2886 (bidi_find_other_level_edge):
2887 Use ptrdiff_t instead of EMACS_INT where either will do.
2888 This works better on 32-bit hosts configured --with-wide-int.
2889 (bidi_cache_ensure_space): Check for size-calculation overflow.
2890 Use % rather than repeated addition, for better worst-case speed.
2891 Don't set bidi_cache_size until after xrealloc returns, because it
2893 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2894 (bidi_cache_ensure_space): Also check that the bidi cache size
2895 does not exceed that of the largest Lisp string or buffer. See Eli
2896 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2898 * alloc.c (__malloc_size_t): Remove.
2899 All uses replaced by size_t. See Andreas Schwab's note
2900 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2902 * image.c: Improve checking for integer overflow.
2903 (check_image_size): Assume that f is nonnull, since
2904 it is always nonnull in practice. This is one less thing to
2905 worry about when checking for integer overflow later.
2906 (x_check_image_size): New function, which checks for integer
2907 overflow issues inside X.
2908 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2909 This removes the need for a memory_full check.
2910 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2911 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2912 (xbm_read_bitmap_data): Change locals back to 'int', since
2913 their values must fit in 'int'.
2914 (xpm_load_image, png_load, tiff_load):
2915 Invoke x_create_x_image_and_pixmap earlier,
2916 to avoid much needless work if the image is too large.
2917 (tiff_load): Treat overly large images as if
2918 x_create_x_image_and_pixmap failed, not as malloc failures.
2919 (gs_load): Use x_check_image_size.
2921 * gtkutil.c: Omit integer casts.
2922 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2923 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2925 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2927 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2928 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2929 would wrongly return t on a 64-bit host.
2931 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2932 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2933 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2934 and therefore cause GCC to emit a bogus diagnostic in some cases.
2936 * image.c: Integer signedness and overflow and related fixes.
2937 This is not an exhaustive set of fixes, but it's time to
2938 record what I've got.
2939 (lookup_pixel_color, check_image_size): Remove redundant decls.
2940 (check_image_size): Don't assume that arbitrary EMACS_INT values
2941 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2942 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2943 (tiff_load, imagemagick_load_image):
2944 Check for overflow in size calculations.
2945 (x_create_x_image_and_pixmap): Remove unnecessary test for
2946 xmalloc returning NULL; that can't happen.
2947 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2948 (xpm_color_bucket): Use better integer hashing function.
2949 (xpm_cache_color): Don't possibly over-allocate memory.
2950 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2951 (gif_memory_source):
2952 Use ptrdiff_t, not int or size_t, to record sizes.
2953 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2954 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2955 either works, as we prefer signed integers.
2956 (tiff_read_from_memory, tiff_write_from_memory):
2957 Return tsize_t, not size_t, since that's what the TIFF API wants.
2958 (tiff_read_from_memory): Don't fail simply because the read would
2959 go past EOF; instead, return a short read.
2960 (tiff_load): Omit no-longer-needed casts.
2961 (Fimagemagick_types): Don't assume size fits into 'int'.
2963 Improve hashing quality when configured --with-wide-int.
2964 * fns.c (hash_string): New function, taken from sxhash_string.
2965 Do not discard information about ASCII character case; this
2966 discarding is no longer needed.
2967 (sxhash-string): Use it. Change sig to match it. Caller changed.
2968 * lisp.h: Declare it.
2969 * lread.c (hash_string): Remove, since we now use fns.c's version.
2970 The fns.c version returns a wider integer if --with-wide-int is
2971 specified, so this should help the quality of the hashing a bit.
2973 * emacs.c: Integer overflow minor fix.
2974 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2975 Define only if GNU_LINUX.
2976 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2978 * dispnew.c: Integer signedness and overflow fixes.
2979 Remove unnecessary forward decls, that were a maintenance hassle.
2980 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2982 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2983 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2984 (prepare_desired_row, line_draw_cost):
2985 Use int, not unsigned, where either works.
2986 (save_current_matrix, restore_current_matrix):
2987 Use ptrdiff_t, not size_t, where either works.
2988 (init_display): Check for overflow more accurately, and without
2989 relying on undefined behavior.
2991 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2992 Remove, replacing with the new symbols in lisp.h. All uses changed.
2993 * fileio.c (make_temp_name):
2994 * filelock.c (lock_file_1, lock_file):
2995 * xdisp.c (message_dolog):
2996 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2997 Use pMd etc. instead.
2998 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2999 replacing the pWIDE etc. symbols removed from editfns.c.
3001 * keyboard.h (num_input_events): Now uintmax_t.
3002 This is (very slightly) less likely to mess up due to wraparound.
3005 * buffer.c: Integer signedness fixes.
3006 (alloc_buffer_text, enlarge_buffer_text):
3007 Use ptrdiff_t rather than size_t when either will do, as we prefer
3010 * alloc.c: Integer signedness and overflow fixes.
3011 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3012 (__malloc_size_t): Default to size_t, not to int.
3013 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3014 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3015 Prefer ptrdiff_t to size_t when either would do, as we prefer
3017 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3018 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3019 Now const. Initialize with values that are in range even if char
3021 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3022 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3023 These functions do the right thing with sizes > 2**32.
3024 (check_depth): Now ptrdiff_t, not int.
3025 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3026 Adjust to new way of storing sizes. Check for size overflow bugs
3028 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3029 slightly wrong anyway, as it missed one instance of
3030 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3031 (refill_memory_reserve): Omit needless cast to size_t.
3032 (mark_object_loop_halt): Mark as externally visible.
3034 * xselect.c: Integer signedness and overflow fixes.
3035 (Fx_register_dnd_atom, x_handle_dnd_message):
3036 Use ptrdiff_t, not size_t, since we prefer signed.
3037 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3038 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3039 x_dnd_atoms_size and x_dnd_atoms_length.
3041 * doprnt.c: Prefer signed to unsigned when either works.
3043 * doprnt.c (doprnt):
3045 * xdisp.c (vmessage):
3046 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3047 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3048 prefer signed arithmetic to avoid comparison confusion.
3049 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3050 but is a bit tricky.
3052 Assume freestanding C89 headers, string.h, stdlib.h.
3053 * data.c, doprnt.c, floatfns.c, print.c:
3054 Include float.h unconditionally.
3055 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3056 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3057 * regex.c: Likewise for stddef.h, string.h.
3058 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3059 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3060 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3061 (STDC_HEADERS): Remove obsolete defines.
3062 * sysdep.c: Include limits.h unconditionally.
3064 Assume support for memcmp, memcpy, memmove, memset.
3065 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3066 * regex.c (memcmp, memcpy):
3067 Remove; we assume C89 now.
3069 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3070 (__malloc_safe_bcopy): Remove; no longer needed.
3072 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3073 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3074 well either way, and we prefer signed to unsigned.
3076 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3078 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3079 closes the connection while we're reading (bug#9182).
3081 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3083 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3084 are specified (Bug#9168).
3086 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3088 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3089 Found by GCC static checking and --with-wide-int on a 32-bit host.
3091 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3093 * xdisp.c (compute_display_string_pos): Fix logic of caching
3094 previous display string position. Initialize cached_prev_pos to
3095 -1. Fixes slow-down at the beginning of a buffer.
3097 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3099 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3100 for attrs[LFACE_FONTSET_INDEX].
3102 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3104 * xml.c (parse_region): Remove unused local
3105 that was recently introduced.
3107 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3109 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3110 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3112 * xdisp.c (move_it_in_display_line_to): Record the best matching
3113 position for TO_CHARPOS while scanning the line, and restore it on
3114 exit if none of the characters scanned was an exact match.
3115 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3116 when exact match is impossible due to invisible text, and the
3117 lines are truncated.
3119 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3121 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3124 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3126 Fix a significant slow-down of cursor motion with C-n, C-p,
3127 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3128 auto-repeat under bidi redisplay in fontified buffers.
3129 * xdisp.c (compute_stop_pos_backwards): New function.
3130 (next_element_from_buffer): Call compute_stop_pos_backwards to
3131 find a suitable prev_stop when we find ourselves before
3133 (reseat): Don't look for prev_stop, as that could mean a very long
3135 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3136 <cached_disp_overlay_modiff>: Cache for last found display string
3138 (compute_display_string_pos): Return the cached position if asked
3139 about the same buffer in the same area of character positions, and
3140 the buffer wasn't changed since the time the display string
3141 position was cached.
3143 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3145 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3146 is an integer, which is important for empty lines. (Bug#9149)
3148 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3150 * frame.c (Fmodify_frame_parameters): In tty case, update the
3151 default face if necessary (Bug#4238).
3153 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3155 * editfns.c (Fstring_to_char): No need to explain what a character
3156 is in the docstring (Bug#6576).
3158 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160 * xml.c (parse_region): Make sure we always return a tree.
3162 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3164 * xml.c (parse_region): If a document contains only comments,
3167 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3169 * xml.c (make_dom): Return comments, too.
3171 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3174 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3175 and the surrounding thread.
3176 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3177 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3178 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3180 * s/openbsd.h (BROKEN_SIGIO): Define.
3181 * unexelf.c (unexec) [__OpenBSD__]:
3182 Don't update the .mdebug section of the Alpha COFF symbol table.
3184 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3186 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3189 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3191 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3192 This fixes some race conditions on the permissions of any newly
3195 * alloc.c (valid_pointer_p): Use pipe, not open.
3196 This fixes some permissions issues when debugging.
3198 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3199 If fchown fails to set both uid and gid, try to set just gid,
3200 as that is sometimes allowed. Adjust the file's mode to eliminate
3201 setuid or setgid bits that are inappropriate if fchown fails.
3203 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3205 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3206 to compare Lisp_Objects.
3207 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3208 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3209 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3211 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3213 * lread.c (read_integer): Unread even EOF character.
3214 (read1): Likewise. Properly record start position of symbol.
3216 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3217 symbol character follows.
3219 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3221 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3222 This works around a problem with the previous change to Fcopy_file.
3223 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3224 and without this change, GCC might complain about discarding
3225 fchown's return value.
3227 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3229 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3231 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3233 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3235 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3237 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3238 it's used from the C level.
3240 * process.c: Use the same condition for POLL_FOR_INPUT in both
3241 keyboard.c and process.c (bug#1858).
3243 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3245 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3246 (Fgnutls_boot): Use it.
3248 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3250 * doc.c (Fsubstitute_command_keys): Revert last change.
3252 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3254 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3255 quotes the next character, and doesn't affect other longer
3256 sequences (bug#8935).
3258 * lread.c (syms_of_lread): Clarify that is isn't only
3259 `eval-buffer' and `eval-defun' that's affected by
3260 `lexical-binding' (bug#8460).
3262 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3264 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3265 bidi redisplay when a line includes both an image and is truncated.
3267 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3269 Fix minor problems found by static checking.
3270 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3271 (elsz): Now a signed constant, not a size_t var. We prefer signed
3272 types to unsigned, to avoid integer comparison confusion. Without
3273 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3274 "cannot optimize loop, the loop counter may overflow", a symptom
3276 * indent.c (Fvertical_motion): Mark locals as initialized.
3277 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3279 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3281 * search.c (Fre_search_backward): Mention `case-fold-search' in
3282 all the re_search_* functions (bug#8138).
3284 * keyboard.c (Fopen_dribble_file): Document when the file is
3287 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3289 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3292 Support bidi reordering of display and overlay strings.
3293 * xdisp.c (compute_display_string_pos)
3294 (compute_display_string_end): Accept additional argument STRING.
3295 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3296 (reseat_to_string): Initialize bidi_it->string.s and
3297 bidi_it->string.schars.
3298 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3299 NULL (avoids a crash in bidi_paragraph_init).
3300 Initialize itb.string.lstring.
3301 (init_iterator): Call bidi_init_it only of a valid
3302 buffer position was specified. Initialize paragraph_embedding to
3304 (reseat_to_string): Initialize the bidi iterator.
3305 (display_string): If we need to ignore text properties of
3306 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3307 original value of -1 will not work with bidi.)
3308 (compute_display_string_pos): First arg is now struct
3309 `text_pos *'; all callers changed. Support display properties on
3311 (compute_display_string_end): Support display properties on Lisp
3313 (init_iterator, reseat_1, reseat_to_string): Initialize the
3314 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3315 when iterating on a string not from display properties).
3316 (compute_display_string_pos, compute_display_string_end):
3317 Fix calculation of the object to scan. Fixes an error when using
3319 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3320 base_level_stop; instead, set base_level_stop to BEGV.
3321 Fixes crashes in vertical-motion.
3322 (next_element_from_buffer): Improve commentary for when
3323 the iterator is before prev_stop.
3324 (init_iterator): Initialize bidi_p from the default value of
3325 bidi-display-reordering, not from buffer-local value. Use the
3326 buffer-local value only if initializing for buffer iteration.
3327 (handle_invisible_prop): Support invisible properties on strings
3328 that are being bidi-reordered.
3329 (set_iterator_to_next): Support bidi reordering of C strings and
3331 (next_element_from_string): Support bidi reordering of Lisp
3333 (handle_stop_backwards): Support Lisp strings as well.
3334 (display_string): Support display of R2L glyph rows.
3335 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3336 (init_iterator): Don't initialize it->bidi_p for strings
3338 (reseat_to_string): Initialize it->bidi_p for strings here.
3339 (next_element_from_string, next_element_from_c_string)
3340 (next_element_from_buffer): Add xassert's for correspondence
3341 between IT's object being iterated and it->bidi_it.string
3343 (face_before_or_after_it_pos): Support bidi iteration.
3344 (next_element_from_c_string): Handle the case of the first string
3345 character that is not the first one in the visual order.
3346 (get_visually_first_element): New function, refactored from common
3347 parts of next_element_from_buffer, next_element_from_string, and
3348 next_element_from_c_string.
3349 (tool_bar_lines_needed, redisplay_tool_bar)
3350 (display_menu_bar): Force left-to-right direction. Add a FIXME
3351 comment for making that be controlled by a user option.
3352 (push_it, pop_it): Save and restore the state of the
3353 bidi iterator. Save and restore the bidi_p flag.
3354 (pop_it): Iterate out of display property for string iteration as
3356 (iterate_out_of_display_property): Support iteration over strings.
3357 (handle_single_display_spec): Set up it->bidi_it for iteration
3358 over a display string, and call bidi_init_it.
3359 (handle_single_display_spec, next_overlay_string)
3360 (get_overlay_strings_1, push_display_prop): Set up the bidi
3361 iterator for displaying display or overlay strings.
3362 (forward_to_next_line_start): Don't use the shortcut if
3364 (back_to_previous_visible_line_start): If handle_display_prop
3365 pushed the iterator stack, restore the internal state of the bidi
3366 iterator by calling bidi_pop_it same number of times.
3367 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3368 and we are bidi-iterating, don't decrement the iterator position;
3369 instead, set the first_elt flag in the bidi iterator, to produce
3371 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3372 (push_display_prop): xassert that we are iterating a buffer.
3373 (push_it, pop_it): Save and restore paragraph_embedding member.
3374 (handle_single_display_spec, next_overlay_string)
3375 (get_overlay_strings_1, reseat_1, reseat_to_string)
3376 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3377 correctly. Don't assume unibyte strings are not bidi-reordered.
3378 (compute_display_string_pos)
3379 (compute_display_string_end): Fix handling the case of C string.
3380 (push_it, pop_it): Save and restore from_disp_prop_p.
3381 (handle_single_display_spec, push_display_prop): Set the
3382 from_disp_prop_p flag.
3383 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3384 (pop_it): Call iterate_out_of_display_property only if we are
3385 popping after iteration over a string that came from a display
3386 property. Fix a typo in popping stretch info. Add an assertion
3387 for verifying that the iterator position is in sync with the bidi
3389 (handle_single_display_spec, get_overlay_strings_1)
3390 (push_display_prop): Fix initialization of paragraph direction for
3391 string when that of the parent object is not yet determined.
3392 (reseat_1): Call bidi_init_it to resync the bidi
3393 iterator with IT's position. (Bug#7616)
3394 (find_row_edges): If ROW->start.pos gives position
3395 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3396 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3397 Reset the from_disp_prop_p flag.
3398 (SAVE_IT, RESTORE_IT): New macros.
3399 (pos_visible_p, face_before_or_after_it_pos)
3400 (back_to_previous_visible_line_start)
3401 (move_it_in_display_line_to, move_it_in_display_line)
3402 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3403 (try_scrolling, redisplay_window, display_line): Use them when
3404 saving a temporary copy of the iterator and restoring it back.
3405 (back_to_previous_visible_line_start, reseat_1)
3406 (init_iterator): Empty the bidi cache "stack".
3407 (move_it_in_display_line_to): If iterator ended up at
3408 EOL, but we never saw any buffer positions smaller than
3409 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3410 motion in bidi-reordered lines.
3411 (move_it_in_display_line_to): Record prev_method and prev_pos
3412 immediately before the call to set_iterator_to_next. Fixes cursor
3413 motion in bidi-reordered lines with stretch glyphs and strings
3414 displayed in margins. (Bug#8133) (Bug#8867)
3415 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3417 (pos_visible_p): Support positions in bidi-reordered lines.
3418 Save and restore bidi cache.
3420 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3421 (bidi_paragraph_info): Delete unused struct.
3422 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3423 (bidi_cache_start): New variable.
3424 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3426 (bidi_cache_fetch_state, bidi_cache_search)
3427 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3428 (bidi_cache_find, bidi_peek_at_next_level)
3429 (bidi_level_of_next_char, bidi_find_other_level_edge)
3430 (bidi_move_to_visually_next): Compare cache index with
3431 bidi_cache_start rather than with zero.
3432 (bidi_fetch_char): Accept new argument STRING; all callers
3433 changed. Support iteration over a string. Support strings with
3434 display properties. Support unibyte strings. Fix the type of
3435 `len' according to what STRING_CHAR_AND_LENGTH expects.
3436 (bidi_paragraph_init, bidi_resolve_explicit_1)
3437 (bidi_resolve_explicit, bidi_resolve_weak)
3438 (bidi_level_of_next_char, bidi_move_to_visually_next):
3439 Support iteration over a string.
3440 (bidi_set_sor_type, bidi_resolve_explicit_1)
3441 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3442 can now be zero (for strings); special values 0 and -1 were
3443 changed to -1 and -2, respectively.
3444 (bidi_char_at_pos): New function.
3445 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3446 Call it instead of FETCH_MULTIBYTE_CHAR.
3447 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3448 initialized to valid values.
3449 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3451 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3452 the test for valid cached positions. Fix the logic for looking up
3453 the sentinel state in the cache. GCPRO the Lisp string we are
3455 (bidi_push_it, bidi_pop_it): New functions.
3456 (bidi_initialize): Initialize the bidi cache start stack pointer.
3457 (bidi_cache_ensure_space): New function, refactored from part of
3458 bidi_cache_iterator_state. Don't assume the required size is just
3459 one BIDI_CACHE_CHUNK away.
3460 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3461 (bidi_count_bytes, bidi_char_at_pos): New functions.
3462 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3463 always valid if bidi_cache_idx is valid.
3464 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3465 is valid if it's going to be used.
3466 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3467 (bidi_cache_fetch_state, bidi_cache_search)
3468 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3469 (bidi_cache_iterator_state, bidi_cache_find)
3470 (bidi_find_other_level_edge, bidi_cache_start_stack):
3471 All variables related to cache indices are now EMACS_INT.
3473 * dispextern.h (struct bidi_string_data): New structure.
3474 (struct bidi_it): New member `string'. Make flag members be 1-bit
3475 fields, and put them last in the struct.
3476 (compute_display_string_pos, compute_display_string_end):
3478 (bidi_push_it, bidi_pop_it): Add prototypes.
3479 (struct iterator_stack_entry): New members bidi_p,
3480 paragraph_embedding, and from_disp_prop_p.
3481 (struct it): Member bidi_p is now a bit field 1 bit wide.
3482 (bidi_shelve_cache, bidi_unshelve_cache):
3485 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3486 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3487 and vector-like objects.
3489 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3490 cache around display iteration.
3492 * window.c (Fwindow_end, window_scroll_pixel_based)
3493 (displayed_window_lines, Frecenter): Save and restore the bidi
3494 cache around display iteration.
3496 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498 * editfns.c (Fdelete_region): Clarify the use of the named
3499 parameters (bug#6788).
3501 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3503 * indent.c (Fvertical_motion): Set and restore w->pointm when
3504 saving and restoring the window's buffer (Bug#9006).
3506 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3508 * editfns.c (Fstring_to_char): Clarify just what is returned
3509 (bug#6576). Text by Eli Zaretskii.
3511 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3513 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3515 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3517 * buffer.c (mmap_find): Fix a typo.
3519 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3521 Fix execution of x selection hooks.
3522 * xselect.c (Qx_lost_selection_functions)
3523 (Qx_sent_selection_functions): New vars.
3524 (syms_of_xselect): DEFSYM them.
3525 (x_handle_selection_request): Pass Qx_sent_selection_functions
3526 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3527 (x_handle_selection_clear,x_clear_frame_selections):
3528 Pass Qx_lost_selection_functions rather than
3529 Vx_lost_selection_functions to Frun_hook_with_args.
3531 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3533 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3534 The old code sometimes used this field without initializing it.
3536 * alloc.c (gc_sweep): Don't read past end of array.
3537 In theory, the old code could also have corrupted Emacs internals,
3538 though it'd be very unlikely.
3540 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3542 * character.c (Fcharacterp): Don't advertise optional ignored
3543 argument. (Bug#4026)
3545 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3547 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3550 * window.c (Fset_window_start): Doc fix (bug#4199).
3551 (Fset_window_hscroll): Ditto.
3553 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3555 Fix minor new problems caught by GCC 4.6.1.
3556 * term.c (init_tty): Remove unused local.
3557 * xsettings.c (store_monospaced_changed): Define this function only
3558 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3561 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3563 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3565 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3567 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3568 are the mini-buffer and the echo area (bug#3320).
3570 * term.c (init_tty): Remove support for supdup, c10 and perq
3571 terminals, which are no longer supported (bug#1482).
3573 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3575 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3577 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3579 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3580 for non-popups (Bug#3642).
3582 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3584 * alloc.c (reset_malloc_hooks): Protoize.
3585 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3586 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3587 * cm.c (losecursor): Likewise.
3588 * data.c (fmod): Likewise.
3589 * dispnew.c (swap_glyphs_in_rows): Likewise.
3590 * emacs.c (memory_warning_signal): Likewise.
3591 * floatfns.c (float_error): Likewise.
3592 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3593 (otf_open, font_otf_capability, generate_otf_features)
3594 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3596 * image.c (pbm_read_file): Likewise.
3597 * indent.c (string_display_width): Likewise.
3598 * intervals.c (check_for_interval, search_for_interval)
3599 (inc_interval_count, count_intervals, root_interval)
3600 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3601 * lread.c (defalias): Likewise.
3602 * ralloc.c (r_alloc_check): Likewise.
3603 * regex.c (set_image_of_range_1, set_image_of_range)
3604 (regex_grow_registers): Likewise.
3605 * sysdep.c (strerror): Likewise.
3606 * termcap.c (valid_filename_p, tprint, main): Likewise.
3607 * tparam.c (main): Likewise.
3608 * unexhp9k800.c (run_time_remap, save_data_space)
3609 (update_file_ptrs, read_header, write_header, calculate_checksum)
3610 (copy_file, copy_rest, display_header): Likewise.
3611 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3613 * xdisp.c (check_it): Likewise.
3614 * xfaces.c (register_color, unregister_color, unregister_colors):
3616 * xfns.c (print_fontset_result): Likewise.
3617 * xrdb.c (member, fatal, main): Likewise.
3619 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3621 Fix minor problems found by static checking (Bug#9031).
3622 * chartab.c (char_table_set_range, map_sub_char_table):
3623 Remove unused locals.
3624 (uniprop_table): Now static.
3625 * composite.c (_work_char): Remove unused static var.
3627 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3629 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3631 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3633 * gtkutil.c (qttip_cb): Remove code without function.
3635 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3637 * w32.c (pthread_sigmask): New stub.
3639 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3641 Use pthread_sigmask, not sigprocmask (Bug#9010).
3642 sigprocmask is portable only for single-threaded applications, and
3643 Emacs can be multi-threaded when it uses GTK.
3644 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3646 * callproc.c (Fcall_process):
3647 * process.c (create_process):
3648 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3649 Use pthread_sigmask, not sigprocmask.
3651 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3653 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3654 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3657 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3659 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3660 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3661 (xg_hide_tooltip): Fix comment.
3663 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3664 in registerServicesMenuSendTypes.
3665 (validRequestorForSendType): Don't check ns_return_types.
3667 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3670 2011-07-08 Jason Rumney <jasonr@gnu.org>
3672 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3673 SH_SHOW for hidden windows (Bug#5482).
3675 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3676 frame struct members of non-existent frames (Bug#6284).
3678 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3680 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3681 variable firstTime not needed on OSX >= 10.6.
3682 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3683 >= 10.5. Use setKnobProportion, setDoubleValue.
3685 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3686 (MAC_OS_X_VERSION_10_5): Define if not defined.
3687 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3688 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3689 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3691 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3692 cString and lossyCString on OSX >= 10.4
3694 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3695 sizeToFit on OSX >= 10.2.
3697 * nsimage.m (allocInitFromFile): Don't use deprecated method
3698 bestRepresentationForDevice on OSX >= 10.6.
3700 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3703 * emacs.c: Declare unexec_init_emacs_zone.
3705 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3707 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3709 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3710 on svcsMenu (Bug#8842).
3712 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3714 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3716 * nsterm.m (QUTF8_STRING): Declare.
3717 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3718 (validRequestorForSendType): Return type is (id).
3719 Change indexOfObjectIdenticalTo to indexOfObject.
3720 Check if we have local selection before returning self (Bug#8842).
3721 (writeSelectionToPasteboard): Put local selection into paste board
3722 if we have a local selection (Bug#8842).
3723 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3725 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3726 (ns_get_local_selection): Declare.
3728 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3730 * keymap.c (describe_map_tree): Don't insert a double newline at
3731 the end of the buffer (bug#1169) and return whether we inserted
3734 * callint.c (Fcall_interactively): Change "reading args" to
3735 "providing args" to try to clarify what it does (bug#1010).
3737 2011-07-07 Kenichi Handa <handa@m17n.org>
3739 * composite.c (composition_compute_stop_pos): Ignore a static
3740 composition starting before CHARPOS (Bug#8915).
3742 * xdisp.c (handle_composition_prop): Likewise.
3744 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3746 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3749 2011-07-07 Kenichi Handa <handa@m17n.org>
3751 * character.h (unicode_category_t): New enum type.
3753 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3754 (Qchar_code_property_table): New variable.
3755 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3756 (UNIPROP_COMPRESSED_FORM_P): New macros.
3757 (char_table_ascii): Uncompress the compressed values.
3758 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3759 Uncompress the compressed values.
3760 (sub_char_table_ref_and_range): Likewise.
3761 (char_table_ref_and_range): Uncompress the compressed values.
3762 (sub_char_table_set): New arg is_uniprop. Callers changed.
3763 Uncompress the compressed values.
3764 (sub_char_table_set_range): Args changed. Callers changed.
3765 (char_table_set_range): Adjuted for the above change.
3766 (map_sub_char_table): Delete args default_val and parent. Add arg
3767 top. Give decoded values to a Lisp function.
3768 (map_char_table): Adjust for the above change. Give decoded
3769 values to a Lisp function. Gcpro more variables.
3770 (uniprop_table_uncompress)
3771 (uniprop_decode_value_run_length): New functions.
3772 (uniprop_decoder, uniprop_decoder_count): New variables.
3773 (uniprop_get_decoder, uniprop_encode_value_character)
3774 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3776 (uniprop_encoder, uniprop_encoder_count): New variables.
3777 (uniprop_get_encoder, uniprop_table)
3778 (Funicode_property_table_internal, Fget_unicode_property_internal)
3779 (Fput_unicode_property_internal): New functions.
3780 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3781 Sunicode_property_table_internal, Sget_unicode_property_internal,
3782 and Sput_unicode_property_internal. Defvar_lisp
3783 char-code-property-alist.
3785 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3786 Vunicode_category_table.
3788 * font.c (font_range): Adjust for the change of
3789 Vunicode_category_table.
3791 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3793 * m/iris4d.h: Remove file, move contents ...
3794 * s/irix6-5.h: ... here.
3796 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3798 Remove unportable assumption about struct layout (Bug#8884).
3799 * alloc.c (mark_buffer):
3800 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3801 (clone_per_buffer_values): Don't assume that
3802 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3803 This isn't true in general, and it's particularly not true
3804 if Emacs is configured with --with-wide-int.
3805 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3806 New macros, used in the buffer.c change.
3808 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3810 * xsettings.c: Use both GConf and GSettings if both are available.
3811 (store_config_changed_event): Add comment.
3812 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3813 (store_tool_bar_style_changed): New functions.
3814 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3815 (struct xsettings): Move font inside HAVE_XFT.
3816 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3817 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3818 Move inside HAVE_XFT.
3819 (something_changed_gsettingsCB): Rename from something_changedCB.
3820 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3822 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3823 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3824 (something_changed_gconfCB): Rename from something_changedCB.
3825 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3826 (parse_settings): Move check for font inside HAVE_XFT.
3827 (read_settings, apply_xft_settings): Add comment.
3828 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3829 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3830 call store_font_name_changed.
3831 (xft_settings_event): Add comment.
3832 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3833 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3834 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3835 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3836 (xsettings_initialize): Call init_gsettings last.
3837 (xsettings_get_system_font, xsettings_get_system_normal_font):
3840 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3842 Random fixes. E.g., (random) never returned negative values.
3843 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3844 subseconds part to the entropy, as that's a bit more random.
3845 Prefer signed to unsigned, since the signedness doesn't matter and
3846 in general we prefer signed. When given a limit, use a
3847 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3848 latter isn't right if USE_2_TAGS_FOR_INTS.
3849 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3850 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3852 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3854 * textprop.c (text_property_stickiness):
3855 Obey Vtext_property_default_nonsticky.
3856 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3857 * w32fns.c (syms_of_w32fns):
3858 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3860 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3862 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3863 This is more efficient than Ffile_directory_p and avoids a minor race.
3865 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3867 * buffer.c (Foverlay_put): Say what the return value is
3870 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3871 is a directory before asking whether to use the file name
3873 (barf_or_query_if_file_exists): Make the "File is a directory"
3874 error be more correct.
3876 * fns.c (Frequire): Remove the mention of the .gz files, since
3877 that's installation-specific, but keep the mention of
3878 `get-load-suffixes'.
3880 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3882 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3883 Report string overflow if the output is too long.
3885 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3887 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3888 (syms_of_gnutls): Remove duplicate DEFSYM for
3889 Qgnutls_bootprop_verify_hostname_error, an error for
3890 Qgnutls_bootprop_verify_error (which is no longer used).
3892 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3893 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3894 Also (re)move comments that are misplaced or no longer relevant.
3896 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3898 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3900 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3902 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3903 and background color parameters if they have been changed.
3905 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3907 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3909 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3911 * xsettings.c (SYSTEM_FONT): Define only when used.
3912 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3914 * keymap.c (access_keymap_1): Now static.
3916 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3918 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3919 leave any prefix arg for the up event (Bug#1586).
3921 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3923 * lread.c (syms_of_lread): Mention single symbols defined by
3924 `defvar' or `defconst' (bug#7154).
3926 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3927 (Frequire): Mention get-load-suffixes.
3929 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3931 * window.h (window): Remove clone_number slot.
3932 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3934 (make_parent_window, make_window, saved_window)
3935 (Fset_window_configuration, save_window_save): Don't deal with
3937 * buffer.c (Qclone_number): Remove declaration.
3938 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3940 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3942 Add multiple inheritance to keymaps.
3943 * keymap.c (Fmake_composed_keymap): New function.
3944 (Fset_keymap_parent): Simplify.
3945 (fix_submap_inheritance): Remove.
3946 (access_keymap_1): New function extracted from access_keymap to handle
3947 embedded parents and handle lists of maps.
3948 (access_keymap): Use it.
3949 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3950 (Fcopy_keymap): Handle embedded parents.
3951 (Fcommand_remapping, define_as_prefix): Simplify.
3952 (Fkey_binding): Simplify.
3953 (syms_of_keymap): Move minibuffer-local-completion-map,
3954 minibuffer-local-filename-completion-map,
3955 minibuffer-local-must-match-map, and
3956 minibuffer-local-filename-must-match-map to Elisp.
3957 (syms_of_keymap): Defsubr make-composed-keymap.
3958 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3959 (parse_menu_item): Trivial simplification.
3961 2011-07-01 Glenn Morris <rgm@gnu.org>
3963 * Makefile.in (SETTINGS_LIBS): Fix typo.
3965 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3967 * coding.c (Fencode_coding_string): Record the last coding system
3968 used, as the function doc string says (bug#8738).
3970 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3972 * xsettings.c (store_monospaced_changed): Take new font as arg and
3973 check for change against current_mono_font.
3974 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3975 (emacs_settings_constructor, emacs_settings_get_property)
3976 (emacs_settings_set_property, emacs_settings_class_init)
3977 (emacs_settings_init, gsettings_obj): Remove.
3978 (something_changedCB): New function for HAVE_GSETTINGS.
3979 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3980 with value as argument.
3981 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3982 g_settings_new (Bug#8967). Do not create gsettings_obj.
3983 Remove calls to g_settings_bind. Connect something_changedCB to
3986 * xgselect.c: Add defined (HAVE_GSETTINGS).
3987 (xgselect_initialize): Ditto.
3989 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3990 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3993 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3995 * eval.c (struct backtrace): Simplify and port the data structure.
3996 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3997 signed bit field, as this assumption is not portable and it makes
3998 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3999 "char debug_on_exit : 1" as this is not portable either; instead,
4000 use the portable "unsigned int debug_on_exit : 1". Remove unused
4001 member evalargs. Remove obsolete comments about cc bombing out.
4003 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4005 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4006 Let HAVE_GSETTINGS override HAVE_GCONF.
4007 (store_monospaced_changed): New function.
4008 (EMACS_SETTINGS): A new type derived from GObject to handle
4009 GSettings notifications.
4010 (emacs_settings_constructor, emacs_settings_get_property)
4011 (emacs_settings_set_property, emacs_settings_class_init):
4013 (gsettings_client, gsettings_obj): New variables.
4014 (GSETTINGS_SCHEMA): New define.
4015 (something_changedCB): Call store_monospaced_changed.
4016 (init_gsettings): New function.
4017 (xsettings_initialize): Call init_gsettings.
4018 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4021 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4024 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4026 * window.c (resize_root_window, grow_mini_window)
4027 (shrink_mini_window): Rename Qresize_root_window to
4028 Qwindow_resize_root_window and Qresize_root_window_vertically to
4029 Qwindow_resize_root_window_vertically.
4031 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4033 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4035 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4037 * makefile.w32-in: Redesign dependencies so they reflect more
4038 clearly which files are directly included by each source file,
4039 and not through other includes.
4041 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4043 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4044 (sort_overlays, overlay_strings): When an overlay's clone number
4045 matches the window's clone number process the overlay even if
4046 the overlay's window property doesn't match the current window.
4048 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4049 (Fwindow_hchild): Rename to Fwindow_left_child.
4050 (Fwindow_next): Rename to Fwindow_next_sibling.
4051 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4052 (resize_window_check): Rename to window_resize_check.
4053 (resize_window_apply): Rename to window_resize_apply.
4054 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4055 (Fdelete_other_windows_internal, resize_frame_windows)
4056 (Fsplit_window_internal, Fdelete_window_internal)
4057 (grow_mini_window, shrink_mini_window)
4058 (Fresize_mini_window_internal): Fix callers accordingly.
4060 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4062 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4063 (emacs_fixed_set_min_size): Remove.
4064 (emacs_fixed_new): Take frame as argument.
4066 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4067 (_EmacsFixedPrivate): Remove minwidth/height.
4068 Add struct frame *f.
4069 (emacs_fixed_init): Initialize priv->f.
4070 (get_parent_class, emacs_fixed_set_min_size): Remove.
4071 (emacs_fixed_new): Set priv->f to argument.
4072 (emacs_fixed_get_preferred_width)
4073 (emacs_fixed_get_preferred_height): Use min_width/height from
4074 frames size_hint to set minimum and natural (Bug#8919).
4075 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4076 and use min_width/height from frames size_hint to set
4077 min_width/height (Bug#8919).
4079 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4080 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4083 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4085 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4086 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4089 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4091 * process.c (wait_reading_process_output): Bypass select if
4092 waiting for a cell while ignoring keyboard input, and input is
4093 pending. Suggested by Jan Djärv (Bug#8869).
4095 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4097 Use gnulib's dup2 module instead of rolling our own.
4098 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4100 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4102 * dispnew.c (scrolling_window): Before scrolling, turn off a
4103 mouse-highlight in the window being scrolled.
4105 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4107 Move DEFSYM to lisp.h and use everywhere.
4109 * character.h (DEFSYM): Move declaration...
4110 * lisp.h (DEFSYM): ...here.
4116 * w32select.c: Don't include character.h.
4118 * alloc.c (syms_of_alloc):
4119 * buffer.c (syms_of_buffer):
4120 * bytecode.c (syms_of_bytecode):
4121 * callint.c (syms_of_callint):
4122 * casefiddle.c (syms_of_casefiddle):
4123 * casetab.c (init_casetab_once):
4124 * category.c (init_category_once, syms_of_category):
4125 * ccl.c (syms_of_ccl):
4126 * cmds.c (syms_of_cmds):
4127 * composite.c (syms_of_composite):
4128 * dbusbind.c (syms_of_dbusbind):
4129 * dired.c (syms_of_dired):
4130 * dispnew.c (syms_of_display):
4131 * doc.c (syms_of_doc):
4132 * editfns.c (syms_of_editfns):
4133 * emacs.c (syms_of_emacs):
4134 * eval.c (syms_of_eval):
4135 * fileio.c (syms_of_fileio):
4136 * fns.c (syms_of_fns):
4137 * frame.c (syms_of_frame):
4138 * fringe.c (syms_of_fringe):
4139 * insdel.c (syms_of_insdel):
4140 * keymap.c (syms_of_keymap):
4141 * lread.c (init_obarray, syms_of_lread):
4142 * macros.c (syms_of_macros):
4143 * msdos.c (syms_of_msdos):
4144 * print.c (syms_of_print):
4145 * process.c (syms_of_process):
4146 * search.c (syms_of_search):
4147 * sound.c (syms_of_sound):
4148 * syntax.c (init_syntax_once, syms_of_syntax):
4149 * terminal.c (syms_of_terminal):
4150 * textprop.c (syms_of_textprop):
4151 * undo.c (syms_of_undo):
4152 * w32.c (globals_of_w32):
4153 * window.c (syms_of_window):
4154 * xdisp.c (syms_of_xdisp):
4155 * xfaces.c (syms_of_xfaces):
4156 * xfns.c (syms_of_xfns):
4157 * xmenu.c (syms_of_xmenu):
4158 * xsettings.c (syms_of_xsettings):
4159 * xterm.c (syms_of_xterm): Use DEFSYM.
4161 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4163 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4165 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4167 Integer and buffer overflow fixes (Bug#8873).
4169 * print.c (printchar, strout): Check for string overflow.
4170 (PRINTPREPARE, printchar, strout):
4171 Don't set size unless allocation succeeds.
4173 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4174 for sizes. Check for string overflow more accurately.
4175 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4177 * macros.c: Integer and buffer overflow fixes.
4178 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4179 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4180 Use ptrdiff_t, not int, for sizes.
4181 Don't increment bufsize until after realloc succeeds.
4182 Check for size-calculation overflow.
4183 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4185 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4187 * lread.c: Integer overflow fixes.
4188 (read_integer): Radix is now EMACS_INT, not int,
4189 to improve quality of diagnostics for out-of-range radices.
4190 Calculate buffer size correctly for out-of-range radices.
4191 (read1): Check for integer overflow in radices, and in
4192 read-circle numbers.
4193 (read_escape): Avoid int overflow.
4194 (Fload, openp, read_buffer_size, read1)
4195 (substitute_object_recurse, read_vector, read_list, map_obarray):
4196 Use ptrdiff_t, not int, for sizes.
4197 (read1): Use EMACS_INT, not int, for sizes.
4198 Check for size overflow.
4200 * image.c (cache_image): Check for size arithmetic overflow.
4202 * lread.c: Integer overflow issues.
4203 (saved_doc_string_size, saved_doc_string_length)
4204 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4205 Now ptrdiff_t, not int.
4206 (read1): Don't assume doc string length fits in int. Check for
4207 out-of-range doc string lengths.
4208 (read_list): Don't assume file position fits in int.
4209 (read_escape): Check for hex character overflow.
4211 2011-06-22 Leo Liu <sdl.web@gmail.com>
4213 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4214 Move to minibuffer.el.
4216 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4218 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4219 The following patches are for when GLYPH_DEBUG && !XASSERT.
4220 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4221 * dispnew.c (flush_stdout):
4222 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4223 Mark as externally visible.
4224 * dispnew.c (check_window_matrix_pointers): Now static.
4225 * dispnew.c (window_to_frame_vpos):
4226 * xfns.c (unwind_create_frame):
4227 * xterm.c (x_check_font): Remove unused local.
4228 * scroll.c (CHECK_BOUNDS):
4229 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4230 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4231 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4232 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4233 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4235 (debug_method_add): Use va_list and vsprintf rather than relying
4236 on undefined behavior with wrong number of arguments.
4237 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4238 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4239 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4240 since we're not interested in debugging glyphs with old libraries.
4241 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4242 GCC 4.6.0's static checking.
4244 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4246 Integer overflow and signedness fixes (Bug#8873).
4247 A few related buffer overrun fixes, too.
4249 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4251 * dispextern.h (struct face.stipple):
4252 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4253 (x_bitmap_mask, x_allocate_bitmap_record)
4254 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4255 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4256 (x_create_bitmap_from_xpm_data):
4257 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4258 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4260 * xfaces.c (load_pixmap):
4261 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4262 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4263 (.bitmaps_last, struct x_output.icon_bitmap):
4264 Use ptrdiff_t, not int, for bitmap indexes.
4265 (x_allocate_bitmap_record): Check for size overflow.
4266 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4268 Use ptrdiff_t, not int, for overlay counts.
4269 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4270 * editfns.c (overlays_around, get_pos_property):
4271 * textprop.c (get_char_property_and_overlay):
4272 * xdisp.c (next_overlay_change, note_mouse_highlight):
4273 * xfaces.c (face_at_buffer_position):
4274 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4275 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4276 (Fnext_overlay_change, Fprevious_overlay_change)
4277 (mouse_face_overlay_overlaps, Foverlays_in):
4278 Use ptrdiff_t, not int, for sizes.
4279 (overlays_at, overlays_in): Check for size-calculation overflow.
4281 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4283 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4284 (x_session_initialize): Do not assume string length fits in int.
4286 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4287 This is unlikely, but can occur if DPI is outlandish.
4289 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4290 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4292 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4293 * xrdb.c (magic_file_p, search_magic_path):
4294 Omit last arg SUFFIX; it was always 0. All callers changed.
4295 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4297 * xfont.c (xfont_match): Avoid need for strlen.
4299 * xfns.c: Don't assume strlen fits in int.
4300 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4302 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4303 not unsigned long, as we prefer signed integers. All callers changed.
4304 Detect integer overflow in repeat count.
4305 (message_dolog): Don't assume print length fits in 39 bytes.
4306 (display_mode_element): Don't assume strlen fits in int.
4308 * termcap.c: Don't assume sizes fit in int and never overflow.
4309 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4310 (gobble_line): Check for size-calculation overflow.
4312 * minibuf.c (Fread_buffer):
4313 * lread.c (intern, intern_c_string):
4314 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4315 Don't assume string length fits in int.
4317 * keyboard.c (parse_tool_bar_item):
4318 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4320 * font.c: Don't assume string length fits in int.
4321 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4322 Use ptrdiff_t, not int.
4323 (font_intern_prop): Don't assume string length fits in int.
4324 Don't assume integer property fits in fixnum.
4325 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4327 * filelock.c: Fix some buffer overrun and integer overflow issues.
4328 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4329 Reformulate so as not to need the command string.
4330 Invoke gzip -cd rather than gunzip, as it's more portable.
4331 (lock_info_type, lock_file_1, lock_file):
4332 Don't assume pid_t and time_t fit in unsigned long.
4333 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4334 (current_lock_owner): Prefer signed type for sizes.
4335 Use memcpy, not strncpy, where memcpy is what is really wanted.
4336 Don't assume (via atoi) that time_t and pid_t fit in int.
4337 Check for time_t and/or pid_t out of range, e.g., via a network share.
4338 Don't alloca where an auto var works fine.
4340 * fileio.c: Fix some integer overflow issues.
4341 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4342 Don't assume string length fits in int.
4343 (directory_file_name): Don't assume string length fits in long.
4344 (make_temp_name): Don't assume pid fits in int, or that its print
4345 length is less than 20.
4347 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4349 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4351 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4353 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4354 We prefer signed integers, even for size calculations.
4356 * emacs.c: Don't assume string length fits in 'int'.
4357 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4358 (main): Don't invoke strlen when not needed.
4360 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4361 (XD_DEBUG_MESSAGE): Don't waste a byte.
4363 * callproc.c (getenv_internal_1, getenv_internal)
4365 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4367 * lread.c (invalid_syntax): Omit length argument.
4368 All uses changed. This doesn't fix a bug, but it simplifies the
4369 code away from its former Hollerith-constant appearance, and it's
4370 one less 'int' to worry about when looking at integer-overflow issues.
4371 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4373 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4374 This didn't break anything, but it didn't help either.
4375 It's confusing to put a bogus integer in a place where the actual
4376 value does not matter.
4377 (LIST_END_P): Remove unused macro and its bogus comment.
4378 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4380 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4381 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4383 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4384 We prefer signed types, and the value cannot exceed the EMACS_INT
4385 range anyway (because otherwise the length would not be representable).
4386 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4387 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4388 This avoids a GCC warning when WIDE_EMACS_INT.
4390 * indent.c (sane_tab_width): New function.
4391 (current_column, scan_for_column, Findent_to, position_indentation)
4392 (compute_motion): Use it. This is just for clarity.
4393 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4395 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4397 * lisp.h (lint_assume): New macro.
4398 * composite.c (composition_gstring_put_cache):
4399 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4401 * editfns.c, insdel.c:
4402 Omit unnecessary forward decls, to simplify future changes.
4404 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4406 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4408 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4409 Use much-faster test for byte-length change.
4410 Don't assume string byte-length fits in 'int'.
4411 Check that character arg fits in 'int'.
4412 (mapcar1): Declare byte as byte, for clarity.
4414 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4416 * fns.c (concat): Catch string overflow earlier.
4417 Do not rely on integer wraparound.
4419 * dispextern.h (struct it.overlay_strings_charpos)
4420 (struct it.selective): Now EMACS_INT, not int.
4421 * xdisp.c (forward_to_next_line_start)
4422 (back_to_previous_visible_line_start)
4423 (reseat_at_next_visible_line_start, next_element_from_buffer):
4424 Don't arbitrarily truncate the value of 'selective' to int.
4426 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4428 * composite.c: Don't truncate sizes to 'int'.
4429 (composition_gstring_p, composition_reseat_it)
4430 (composition_adjust_point): Use EMACS_INT, not int.
4431 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4432 not EMACS_UINT, for indexes.
4434 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4436 * buffer.c: Include <verify.h>.
4437 (struct sortvec.priority, struct sortstr.priority):
4438 Now EMACS_INT, not int.
4439 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4440 (struct sortstr.size, record_overlay_string)
4441 (struct sortstrlist.size, struct sortlist.used):
4442 Don't truncate size to int.
4443 (record_overlay_string): Check for size-calculation overflow.
4444 (init_buffer_once): Check at compile-time, not run-time.
4446 2011-06-22 Jim Meyering <meyering@redhat.com>
4448 Don't leak an XBM-image-sized buffer
4449 * image.c (xbm_load): Free the image buffer after using it.
4451 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4454 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4455 that Sun C diagnosed.
4456 * fns.c (secure_hash): Fix pointer signedness issue.
4457 * intervals.c (static_offset_intervals): New function.
4458 (offset_intervals): Use it.
4460 2011-06-21 Leo Liu <sdl.web@gmail.com>
4463 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4466 * fns.c (secure_hash): Rename from crypto_hash_function and change
4467 the first arg to accept symbols.
4468 (Fsecure_hash): New primitive.
4469 (syms_of_fns): New symbols.
4471 2011-06-20 Deniz Dogan <deniz@dogan.se>
4473 * process.c (Fset_process_buffer): Clarify return value in
4476 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4478 * dispnew.c (add_window_display_history): Use BVAR.
4480 * xdisp.c (debug_method_add): Use BVAR.
4481 (check_window_end, dump_glyph_matrix, dump_glyph)
4482 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4484 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4487 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4488 check till after the cache is created in init_frame_faces.
4490 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4492 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4494 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4496 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4497 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4498 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4500 Improve buffer-overflow checking (Bug#8873).
4501 * fileio.c (Finsert_file_contents):
4502 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4503 Remove the old (too-loose) buffer overflow checks.
4504 They weren't needed, since make_gap checks for buffer overflow.
4505 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4506 The old code merely checked for Emacs fixnum overflow, and relied
4507 on undefined (wraparound) behavior. The new code avoids undefined
4508 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4510 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4511 Tune. Don't use wider integers than needed. Don't use alloca.
4512 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4514 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4516 * insdel.c, lisp.h (buffer_overflow): New function.
4517 (insert_from_buffer_1, replace_range, replace_range_2):
4518 * insdel.c (make_gap_larger):
4519 * editfns.c (Finsert_char):
4520 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4522 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4524 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4526 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4528 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4529 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4531 * fileio.c: Don't assume EMACS_INT fits in off_t.
4532 (emacs_lseek): New static function.
4533 (Finsert_file_contents, Fwrite_region): Use it.
4534 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4536 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4538 * fns.c: Don't overflow int when computing a list length.
4539 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4540 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4541 truncation on 64-bit hosts. Check for QUIT every
4542 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4543 faster and is responsive enough.
4544 (Flength): Report an error instead of overflowing an integer.
4545 (Fsafe_length): Return a float if the value is not representable
4546 as a fixnum. This shouldn't happen except in contrived situations.
4547 (Fnthcdr, Fsort): Don't assume list length fits in int.
4548 (Fcopy_sequence): Don't assume vector length fits in int.
4550 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4551 (header_size, word_size): New constants.
4552 (allocate_vectorlike): Don't check size overflow here.
4553 (allocate_vector): Check it here instead, since this is the only
4554 caller of allocate_vectorlike that could cause overflow.
4555 Check that the new vector's length is representable as a fixnum.
4557 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4558 The previous code was bogus. For example, next_almost_prime (32)
4559 returned 39, which is undesirable as it is a multiple of 3; and
4560 next_almost_prime (24) returned 25, which is a multiple of 5 so
4561 why was the code bothering to check for multiples of 7?
4563 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4565 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4567 Variadic C functions now count arguments with ptrdiff_t.
4568 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4569 Back then I didn't know that the Emacs coding style prefers signed int.
4570 Also, in the meantime I found a few more instances where arguments
4571 were being counted with int, which may truncate counts on 64-bit
4572 machines, or EMACS_INT, which may be unnecessarily wide.
4573 * lisp.h (struct Lisp_Subr.function.aMANY)
4574 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4575 Arg counts are now ptrdiff_t, not size_t.
4576 All variadic functions and their callers changed accordingly.
4577 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4578 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4579 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4580 * callint.c (Fcall_interactively): Check arg count for overflow,
4581 to avoid potential buffer overrun. Use signed char, not 'int',
4582 for 'varies' array, so that we needn't bother to check its size
4583 calculation for overflow.
4584 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4585 * eval.c (apply_lambda):
4586 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4587 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4588 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4590 * callint.c (Fcall_interactively): Don't use index var as event count.
4592 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4593 * mem-limits.h (SIZE): Remove; no longer used.
4595 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4597 Remove unnecessary casts.
4598 * xterm.c (x_term_init):
4599 * xfns.c (x_set_border_pixel):
4600 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4601 These aren't needed now that we assume ANSI C.
4603 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4604 It's more likely to cause problems (due to unsigned overflow)
4607 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4609 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4611 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4613 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4615 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4617 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4619 GLYPH_CODE_FACE returns EMACS_INT, not int.
4620 * dispextern.h (merge_faces):
4621 * xfaces.c (merge_faces):
4622 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4623 Don't assume EMACS_INT fits in int.
4625 * character.h (CHAR_VALID_P): Remove unused parameter.
4626 * fontset.c, lisp.h, xdisp.c: All uses changed.
4628 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4630 * fns.c (concat): Minor tuning based on overflow analysis.
4631 This doesn't fix any bugs. Use int to hold character, instead
4632 of constantly refetching from Emacs object. Use XFASTINT, not
4633 XINT, for value known to be a character. Don't bother comparing
4634 a single byte to 0400, as it's always less.
4636 * floatfns.c (Fexpt):
4637 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4639 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4642 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4644 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4645 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4646 incorrectly succeed when S was a string, because 4294967386 was
4647 truncated before it was used.
4649 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4650 Otherwise, an out-of-range integer could cause undefined behavior
4653 * composite.c: Use int, not EMACS_INT, for characters.
4654 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4655 EMACS_INT, for values that are known to be in character range.
4656 This doesn't fix any bugs but is the usual style inside Emacs and
4657 may generate better code on 32-bit machines.
4659 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4660 This is for reasons similar to the recent CHAR_STRING fix.
4661 * charset.c (Fencode_char): Check that character arg is actually
4662 a character. Pass an int to ENCODE_CHAR.
4663 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4664 wider than 'int', as a compile-time check to prevent future regressions
4667 * character.c (char_string): Remove unnecessary casts.
4669 Make sure a 64-bit char is never passed to CHAR_STRING.
4670 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4671 by silently ignoring the top 32 bits, allowing some values
4672 that were far too large to be valid characters.
4673 * character.h: Include <verify.h>.
4674 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4675 arguments are no wider than unsigned, as a compile-time check
4676 to prevent future regressions in this area.
4678 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4679 (Fsubst_char_in_region):
4681 * xdisp.c (decode_mode_spec_coding):
4682 Adjust to CHAR_STRING's new requirement.
4683 * editfns.c (Finsert_char, Fsubst_char_in_region):
4684 * fns.c (concat): Check that character args are actually
4685 characters. Without this test, these functions did the wrong
4686 thing with wildly out-of-range values on 64-bit hosts.
4688 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4689 These casts should not be needed on 32-bit hosts, either.
4690 * keyboard.c (read_char):
4691 * lread.c (Fload): Remove casts to unsigned.
4693 * lisp.h (UNSIGNED_CMP): New macro.
4694 This fixes comparison bugs on 64-bit hosts.
4695 (ASCII_CHAR_P): Use it.
4696 * casefiddle.c (casify_object):
4697 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4698 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4699 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4700 * dispextern.h (FACE_FROM_ID):
4701 * keyboard.c (read_char): Use UNSIGNED_CMP.
4703 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4704 not to EMACS_INT, to avoid GCC warning.
4706 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4708 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4709 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4710 isn't needed on 32-bit machines.
4712 * buffer.c (Fgenerate_new_buffer_name):
4713 Use EMACS_INT for count, not int.
4714 (advance_to_char_boundary): Return EMACS_INT, not int.
4716 * data.c (Qcompiled_function): Now static.
4718 * window.c (window_body_lines): Now static.
4720 * image.c (gif_load): Rename local to avoid shadowing.
4722 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4723 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4724 * alloc.c (make_save_value): Integer argument is now of type
4726 (mark_object): Use ptrdiff_t, not int.
4727 * lisp.h (pD): New macro.
4728 * print.c (print_object): Use it.
4730 * alloc.c: Use EMACS_INT, not int, to count objects.
4731 (total_conses, total_markers, total_symbols, total_vector_size)
4732 (total_free_conses, total_free_markers, total_free_symbols)
4733 (total_free_floats, total_floats, total_free_intervals)
4734 (total_intervals, total_strings, total_free_strings):
4735 Now EMACS_INT, not int. All uses changed.
4736 (Fgarbage_collect): Compute overall total using a double, so that
4737 integer overflow is less likely to be a problem. Check for overflow
4738 when converting back to an integer.
4739 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4740 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4741 These were 'int' variables that could overflow on 64-bit hosts;
4742 they were never used, so remove them instead of repairing them.
4743 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4744 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4745 Previously, this ceilinged at INT_MAX, but that doesn't work on
4747 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4749 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4750 (allocate_vectorlike): Check for ptrdiff_t overflow.
4751 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4752 when a (possibly-narrower) signed value would do just as well.
4753 We prefer using signed arithmetic, to avoid comparison confusion.
4755 * alloc.c: Catch some string size overflows that we were missing.
4756 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4757 for convenience in STRING_BYTES_MAX.
4758 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4759 The definition here is exact; the one in lisp.h was approximate.
4760 (allocate_string_data): Check for string overflow. This catches
4761 some instances we weren't catching before. Also, it catches
4762 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4763 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4764 and ptrdiff_t and EMACS_INT are both 64 bits.
4766 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4767 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4768 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4770 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4772 * alloc.c (Fmake_string): Check for out-of-range init.
4774 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4776 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4778 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4780 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4781 xg_get_default_scrollbar_width.
4783 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4784 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4785 (style_changed_cb): Call update_theme_scrollbar_width and call
4786 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4787 all frames (Bug#8505).
4788 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4789 Call gtk_window_set_resizable if HAVE_GTK3.
4790 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4791 and height if HAVE_GTK3 (Bug#8505).
4792 (scroll_bar_width_for_theme): New variable.
4793 (update_theme_scrollbar_width): New function.
4794 (xg_get_default_scrollbar_width): Move code to
4795 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4796 (xg_initialize): Call update_theme_scrollbar_width.
4798 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4800 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4802 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4804 * frame.c (make_frame): Call other_buffer_safely instead of
4807 * window.c (temp_output_buffer_show): Call display_buffer with
4808 second argument Vtemp_buffer_show_specifiers and reset latter
4809 immediately after the call.
4810 (Vtemp_buffer_show_specifiers): New variable.
4811 (auto_window_vscroll_p, next_screen_context_lines)
4812 (Vscroll_preserve_screen_position): Remove leading asterisks from
4815 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4817 Fix minor problems found by GCC 4.6.0 static checking.
4818 * buffer.c (Qclone_number): Remove for now, as it's unused.
4819 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4820 (record_buffer): Remove unused local.
4821 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4822 (set_frame_buffer_list): Remove; unused.
4823 * frame.h (other_visible_frames): Remove decl.
4824 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4825 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4826 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4828 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4829 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4830 Define only if HAVE_GPM.
4831 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4832 (update_hints_inhibit): Remove; never set. All uses removed.
4833 * widgetprv.h (emacsFrameClassRec): Remove decl.
4834 * window.c (delete_deletable_window): Now returns void, since it
4835 wasn't returning anything.
4836 (compare_window_configurations): Remove unused locals.
4837 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4838 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4839 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4840 the same widths as pointers. This follows up on the 2011-05-06 patch.
4841 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4842 * xterm.h: Likewise.
4843 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4845 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4847 * makefile.w32-in: Update dependencies.
4848 (LISP_H): Add lib/intprops.h.
4850 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4852 * image.c (gif_load): Add animation frame delay to the metadata.
4853 (syms_of_image): Use DEFSYM. New symbol `delay'.
4855 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4857 * window.c (delete_deletable_window): Re-add.
4858 (Fset_window_configuration): Rewrite to handle dead buffers and
4859 consequently deletable windows.
4860 (window_tree, Fwindow_tree): Remove. Supply functionality in
4862 (compare_window_configurations): Simplify code.
4864 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4866 * image.c (imagemagick_load_image): Fix type mismatch.
4867 (Fimagemagick_types): Likewise.
4869 * window.h (replace_buffer_in_windows): Declare.
4871 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4873 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4874 Qclone_number. Remove external declaration of Qdelete_window.
4875 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4877 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4878 Run Qbuffer_list_update_hook if allowed.
4879 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4880 buffer list implementation.
4881 (other_buffer_safely): New function.
4882 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4883 calls to replace_buffer_in_windows and
4884 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4886 (record_buffer): Inhibit quitting and rewrite using quittable
4887 functions. Run Qbuffer_list_update_hook if allowed.
4888 (Frecord_buffer, Funrecord_buffer): New functions.
4889 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4890 Move switch-to-buffer to window.el.
4891 (bury-buffer): Move to window.el.
4892 (Vbuffer_list_update_hook): New variable.
4894 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4897 * window.h (resize_frame_windows): Move up in code.
4898 (Fwindow_frame): Remove EXFUN.
4899 (replace_buffer_in_all_windows): Remove prototype.
4900 (replace_buffer_in_windows_safely): Add prototype.
4902 * window.c: Declare Qdelete_window static again. Move down
4903 declaration of select_count.
4904 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4905 (Fother_window): Move to window.el.
4906 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4907 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4908 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4910 (replace_buffer_in_windows): Implement by calling
4911 Qreplace_buffer_in_windows.
4912 (replace_buffer_in_all_windows): Remove with some functionality
4913 moved into replace_buffer_in_windows_safely.
4914 (replace_buffer_in_windows_safely): New function.
4915 (select_window_norecord, select_frame_norecord): Move in front
4916 of run_window_configuration_change_hook. Remove now obsolete
4918 (Fset_window_buffer): Rewrite doc-string.
4919 Call Qrecord_window_buffer.
4920 (keys_of_window): Move binding for other-window to window.el.
4922 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4924 * dispextern.h (struct image): Replace data member, whose int_val
4925 and ptr_val fields were not used by anything, with a single
4928 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4929 (gif_clear_image, gif_load, imagemagick_load_image)
4930 (gs_clear_image, gs_load): Callers changed.
4932 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4934 * buffer.h: Include <time.h>, for time_t.
4935 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4937 Fix minor problems found by static checking.
4939 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4941 Make identifiers static if they are not used in other modules.
4942 * data.c (Qcompiled_function, Qframe, Qvector):
4943 * image.c (QimageMagick, Qsvg):
4944 * minibuf.c (Qmetadata):
4945 * window.c (resize_window_check, resize_root_window): Now static.
4946 * window.h (resize_window_check, resize_root_window): Remove decls.
4948 * window.c (window_deletion_count, delete_deletable_window):
4950 (window_body_lines): Now static.
4951 (Fdelete_other_windows_internal): Mark vars as initialized.
4952 Make sure 'resize_failed' is initialized.
4953 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4954 (resize_window_apply): Remove unused local.
4955 * window.h (delete_deletable_window): Remove decl.
4957 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4958 (imagemagick_load_image): Fix pointer signedness problem by changing
4959 last arg from unsigned char * to char *. All uses changed.
4960 Also, fix a local for similar reasons.
4961 Remove unused locals. Remove locals to avoid shadowing.
4962 (fn_rsvg_handle_free): Remove; unused.
4963 (svg_load, svg_load_image): Fix pointer signedness problem.
4964 (imagemagick_load_image): Don't use garbage pointer image_wand.
4966 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4968 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4970 * image.c (gif_load): Fix omitted cast error introduced by
4973 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4975 * window.h (resize_proportionally, orig_total_lines)
4976 (orig_top_line): Remove from window structure.
4977 (set_window_height, set_window_width, change_window_heights)
4978 (Fdelete_window): Remove prototypes.
4979 (resize_frame_windows): Remove duplicate declaration.
4981 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4983 * window.h (resize_frame_windows, resize_window_check)
4984 (delete_deletable_window, resize_root_window)
4985 (resize_frame_windows): Declare prototypes.
4987 * window.c (resize_window_apply): Make definition be "static" to
4988 match the prototype.
4990 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4992 * window.c: Remove declarations of Qwindow_size_fixed,
4993 window_min_size_1, window_min_size_2, window_min_size,
4994 size_window, window_fixed_size_p, enlarge_window, delete_window.
4995 Remove static from declaration of Qdelete_window, it's
4996 temporarily needed by Fbury_buffer.
4997 (replace_window): Don't assign orig_top_line and
4999 (Fdelete_window, delete_window): Remove. Window deletion is
5000 handled by window.el.
5001 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5002 Replace Fdelete_window calls with calls to Qdelete_window.
5003 (Fdelete_other_windows): Remove. Deleting other windows is
5004 handled by window.el.
5005 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5006 handled in window.el.
5007 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5008 Window minimum sizes are handled in window.el.
5009 (shrink_windows, size_window, set_window_height)
5010 (set_window_width, change_window_heights, window_height)
5011 (window_width, CURBEG, CURSIZE, enlarge_window)
5012 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5013 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5014 handled in window.el.
5015 (make_dummy_parent): Rename to make_parent_window and give it a
5016 second argument horflag.
5017 (make_window): Don't set resize_proportionally any more.
5018 (Fsplit_window): Remove. Windows are split in window.el.
5019 (save_restore_action, save_restore_orig_size)
5020 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5021 Resize mini windows in window.el.
5022 (grow_mini_window, shrink_mini_window): Implement by calling
5023 Qresize_root_window_vertically, resize_window_check and
5024 resize_window_apply.
5025 (saved_window, Fset_window_configuration, save_window_save):
5026 Do not handle orig_top_line, orig_total_lines, and
5027 resize_proportionally.
5028 (window_min_height, window_min_width): Move to window.el.
5029 (keys_of_window): Move bindings for delete-other-windows,
5030 split-window, delete-window and enlarge-window to window.el.
5032 * buffer.c: Temporarily extern Qdelete_window.
5033 (Fbury_buffer): Temporarily call Qdelete_window instead of
5034 Fdelete_window (Fbury_buffer will move to window.el soon).
5036 * frame.c (set_menu_bar_lines_1): Remove code handling
5037 orig_top_line and orig_total_lines.
5039 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5040 set_window_height but set heights directly.
5041 (change_frame_size_1): Use resize_frame_windows.
5043 * xdisp.c (init_xdisp): Don't use set_window_height but set
5046 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5047 Use resize_frame_windows instead of change_window_heights and run
5048 run_window_configuration_change_hook.
5050 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5051 instead of change_window_heights and run
5052 run_window_configuration_change_hook.
5054 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5056 * window.c (replace_window): Rename second argument REPLACEMENT to
5057 NEW. New third argument SETFLAG. Rewrite.
5058 (delete_window, make_dummy_parent): Call replace_window with
5060 (window_list_1): Move down in code.
5061 (run_window_configuration_change_hook): Move set_buffer part
5062 before select_frame_norecord part in order to unwind correctly.
5063 Rename count1 to count.
5064 (recombine_windows, delete_deletable_window, resize_root_window)
5065 (Fdelete_other_windows_internal)
5066 (Frun_window_configuration_change_hook, make_parent_window)
5067 (resize_window_check, resize_window_apply, Fresize_window_apply)
5068 (resize_frame_windows, Fsplit_window_internal)
5069 (Fdelete_window_internal, Fresize_mini_window_internal):
5071 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5073 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5075 * window.h (window): Add some new members to window structure -
5076 normal_lines, normal_cols, new_total, new_normal, clone_number,
5077 splits, nest, prev_buffers, next_buffers.
5078 (WINDOW_TOTAL_SIZE): Move here from window.c.
5079 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5081 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5083 (make_dummy_parent): Set new members of windows structure.
5084 (make_window): Move down in code. Handle new members of window
5086 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5087 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5088 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5089 (Fset_window_prev_buffers, Fwindow_next_buffers)
5090 (Fset_window_next_buffers, Fset_window_clone_number):
5092 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5093 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5095 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5096 Argument WINDOW can be now internal window too.
5097 (Fwindow_use_time): Move up in code.
5098 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5100 (Fset_window_configuration, saved_window)
5101 (Fcurrent_window_configuration, save_window_save): Handle new
5102 members of window structure.
5103 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5104 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5105 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5106 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5107 Qget_mru_window, Qresize_root_window,
5108 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5109 Qauto_buffer_name; staticpro them.
5111 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5113 * window.c (Fwindow_total_size, Fwindow_left_column)
5114 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5115 (Fwindow_list_1): New functions.
5116 (window_box_text_cols): Replace with window_body_cols.
5117 (Fwindow_width, Fscroll_left, Fscroll_right):
5118 Use window_body_cols instead of window_box_text_cols.
5119 (delete_window, Fset_window_configuration):
5120 Call delete_all_subwindows with window as argument.
5121 (delete_all_subwindows): Take a window as argument and not a
5123 (window_loop): Remove handling of GET_LRU_WINDOW and
5125 (Fget_lru_window, Fget_largest_window): Move to window.el.
5127 * window.h: Extern window_body_cols instead of
5128 window_box_text_cols. delete_all_subwindows now takes a
5129 Lisp_Object as argument.
5131 * indent.c (compute_motion, Fcompute_motion):
5132 Use window_body_cols instead of window_box_text_cols.
5134 * frame.c (delete_frame): Call delete_all_subwindows with root
5137 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5139 * fns.c (Fputhash): Document return value.
5141 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5143 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5145 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5147 Cons<->int and similar integer overflow fixes (Bug#8794).
5149 Check for overflow when converting integer to cons and back.
5150 * charset.c (Fdefine_charset_internal, Fdecode_char):
5151 Use cons_to_unsigned to catch overflow.
5152 (Fencode_char): Use INTEGER_TO_CONS.
5153 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5154 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5155 * data.c (long_to_cons, cons_to_long): Remove.
5156 (cons_to_unsigned, cons_to_signed): New functions.
5157 These signal an error for invalid or out-of-range values.
5158 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5159 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5160 * font.c (Ffont_variation_glyphs):
5161 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5162 * lisp.h: Include <intprops.h>.
5163 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5164 (cons_to_signed, cons_to_unsigned): New decls.
5165 (long_to_cons, cons_to_long): Remove decls.
5166 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5167 (Fprimitive_undo): Use CONS_TO_INTEGER.
5168 * xfns.c (Fx_window_property): Likewise.
5169 * xselect.c: Include <limits.h>.
5170 (x_own_selection, selection_data_to_lisp_data):
5171 Use INTEGER_TO_CONS.
5172 (x_handle_selection_request, x_handle_selection_clear)
5173 (x_get_foreign_selection, Fx_disown_selection_internal)
5174 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5175 (lisp_data_to_selection_data): Use cons_to_unsigned.
5176 (x_fill_property_data): Use cons_to_signed.
5177 Report values out of range.
5179 Check for buffer and string overflow more precisely.
5180 * buffer.h (BUF_BYTES_MAX): New macro.
5181 * lisp.h (STRING_BYTES_MAX): New macro.
5182 * alloc.c (Fmake_string):
5183 * character.c (string_escape_byte8):
5184 * coding.c (coding_alloc_by_realloc):
5185 * doprnt.c (doprnt):
5186 * editfns.c (Fformat):
5188 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5189 since they may not be the same number.
5190 * editfns.c (Finsert_char):
5191 * fileio.c (Finsert_file_contents):
5192 Likewise for BUF_BYTES_MAX.
5194 * image.c: Use ptrdiff_t, not int, for sizes.
5195 (slurp_file): Switch from int to ptrdiff_t.
5197 (slurp_file): Check that file size fits in both size_t (for
5198 malloc) and ptrdiff_t (for sanity and safety).
5200 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5201 if b->modtime has its maximal value.
5203 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5205 Don't assume time_t can fit into int.
5206 * buffer.h (struct buffer.modtime): Now time_t, not int.
5207 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5208 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5210 Minor fixes for signed vs unsigned integers.
5211 * character.h (MAYBE_UNIFY_CHAR):
5212 * charset.c (maybe_unify_char):
5213 * keyboard.c (read_char, reorder_modifiers):
5214 XINT -> XFASTINT, since the integer must be nonnegative.
5215 * ftfont.c (ftfont_spec_pattern):
5216 * keymap.c (access_keymap, silly_event_symbol_error):
5217 XUINT -> XFASTINT, since the integer must be nonnegative.
5218 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5219 since it makes no difference and we prefer signed.
5220 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5221 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5224 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5226 * window.h (Fwindow_frame): Declare.
5228 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5230 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5231 (SPARE_MEMORY): Always define.
5232 (LARGE_REQUEST): Remove.
5233 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5235 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5237 * lisp.h: Move EXFUNS for Fframe_root_window,
5238 Fframe_first_window and Fset_frame_selected_window to window.h.
5240 * window.h: Move EXFUNS for Fframe_root_window,
5241 Fframe_first_window and Fset_frame_selected_window here from
5244 * frame.c (Fwindow_frame, Fframe_first_window)
5245 (Fframe_root_window, Fframe_selected_window)
5246 (Fset_frame_selected_window): Move to window.c.
5247 (Factive_minibuffer_window): Move to minibuf.c.
5248 (Fother_visible_frames_p): New function.
5250 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5252 * window.c (decode_window, decode_any_window): Move up in code.
5253 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5254 (inhibit_frame_unsplittable): Remove unused variable.
5255 (Fwindow_buffer): Move up and rewrite doc-string.
5256 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5257 (Fwindow_prev): New functions.
5258 (Fwindow_frame): Move here from frame.c. Accept any window as
5260 (Fframe_root_window, Fframe_first_window)
5261 (Fframe_selected_window): Move here from frame.c. Accept frame
5262 or arbitrary window as argument. Update doc-strings.
5263 (Fminibuffer_window): Move up in code.
5264 (Fwindow_minibuffer_p): Move up in code and simplify.
5265 (Fset_frame_selected_window): Move here from frame.c.
5267 (Fselected_window, select_window, Fselect_window): Move up in
5268 code. Minor doc-string fixes.
5270 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5272 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5273 Do not assume that spare memory exists; that assumption is valid
5274 only if SYSTEM_MALLOC.
5275 (LARGE_REQUEST): New macro, so that the issue of large requests
5276 is separated from the issue of spare memory.
5278 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5280 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5283 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5285 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5288 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5290 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5292 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5294 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5295 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5297 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5299 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5301 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5303 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5304 (x_clipboard_manager_save): Add return value.
5305 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5307 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5308 Obey Vx_select_enable_clipboard_manager. Catch errors in
5309 x_clipboard_manager_save (Bug#8779).
5310 (Vx_select_enable_clipboard_manager): New variable.
5311 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5313 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5315 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5317 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5319 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5320 in the current matrix if keep_current_p is non-zero.
5322 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5324 * bidi.c (bidi_level_of_next_char): Fix last change.
5326 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5328 Support bidi reordering of text covered by display properties.
5330 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5331 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5332 (bidi_cache_search, bidi_cache_iterator_state)
5333 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5334 (bidi_level_of_next_char, bidi_move_to_visually_next):
5335 Support character positions inside a run of characters covered by a
5337 (bidi_paragraph_init, bidi_resolve_explicit_1)
5338 (bidi_level_of_next_char): Call bidi_fetch_char and
5339 bidi_fetch_char_advance instead of FETCH_CHAR and
5341 (bidi_init_it): Initialize new members.
5342 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5344 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5345 instead of using explicit *_CHAR codes.
5346 (bidi_resolve_explicit, bidi_resolve_weak):
5347 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5348 bidirectional text is supported only in multibyte buffers.
5349 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5350 it to initialize the frame_window_p member of struct bidi_it.
5351 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5352 (bidi_resolve_explicit, bidi_resolve_weak)
5353 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5354 bidi_it->nchars is non-positive.
5355 (bidi_level_of_next_char): Don't try to lookup the cache for the
5356 next/previous character if nothing is cached there yet, or if we
5357 were just reseat()'ed to a new position.
5359 * xdisp.c (set_cursor_from_row): Set start and stop points
5360 according to the row's direction when priming the loop that looks
5361 for the glyph on which to display cursor.
5362 (single_display_spec_intangible_p): Function deleted.
5363 (display_prop_intangible_p): Reimplement to call
5364 handle_display_spec instead of single_display_spec_intangible_p.
5365 Accept 3 additional arguments needed by handle_display_spec.
5366 This fixes incorrect cursor motion across display property with complex
5367 values: lists, `(when COND...)' forms, etc.
5368 (single_display_spec_string_p): Support property values that are
5369 lists with the argument STRING its top-level element.
5370 (display_prop_string_p): Fix the condition for processing a
5371 property that is a list to be consistent with handle_display_spec.
5372 (handle_display_spec): New function, refactored from the
5373 last portion of handle_display_prop.
5374 (compute_display_string_pos): Accept additional argument
5375 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5376 value of a `display' property is a "replacing spec".
5377 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5378 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5379 the display property, but just return a value indicating whether
5380 the display property will replace the characters it covers.
5381 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5382 frame_window_p members of struct bidi_it.
5383 (compute_display_string_pos, compute_display_string_end):
5385 (push_it): Accept second argument POSITION, where pop_it should
5386 jump to continue iteration.
5387 (reseat_1): Initialize bidi_it.disp_pos.
5389 * keyboard.c (adjust_point_for_property): Adjust the call to
5390 display_prop_intangible_p to its new signature.
5392 * dispextern.h (struct bidi_it): New member frame_window_p.
5393 (bidi_init_it): Update prototypes.
5394 (display_prop_intangible_p): Update prototype.
5395 (compute_display_string_pos, compute_display_string_end):
5397 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5400 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5402 Malloc failure behavior now depends on size of allocation.
5403 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5404 * lisp.h: Change signatures accordingly.
5405 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5406 All callers changed. (Bug#8762)
5408 * gnutls.c: Use Emacs's memory allocators.
5409 Without this change, the gnutls library would invoke malloc etc.
5410 directly, which causes problems on non-SYNC_INPUT hosts, and which
5411 runs afoul of improving memory_full behavior. (Bug#8761)
5412 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5413 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5414 xfree instead of the default malloc, realloc, free.
5415 (Fgnutls_boot): No need to check for memory allocation failure,
5416 since xmalloc does that for us.
5418 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5419 * category.c (hash_get_category_set):
5420 * ccl.c (ccl_driver):
5421 * charset.c (Fdefine_charset_internal):
5422 * charset.h (struct charset.hash_index):
5423 * composite.c (get_composition_id, gstring_lookup_cache)
5424 (composition_gstring_put_cache):
5425 * composite.h (struct composition.hash_index):
5426 * dispextern.h (struct image.hash):
5427 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5428 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5429 (hashfn_equal, hashfn_user_defined, make_hash_table)
5430 (maybe_resize_hash_table, hash_lookup, hash_put)
5431 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5432 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5433 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5434 * image.c (make_image, search_image_cache, lookup_image)
5435 (xpm_put_color_table_h):
5436 * lisp.h (struct Lisp_Hash_Table):
5437 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5438 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5439 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5440 * alloc.c (allocate_vectorlike):
5441 Check for overflow in vector size calculations.
5442 * ccl.c (ccl_driver):
5443 Check for overflow when converting EMACS_INT to int.
5444 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5445 need to be updated by these changes.
5446 * fns.c (make_hash_table, maybe_resize_hash_table):
5447 Check for integer overflow with large hash tables.
5448 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5449 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5450 (SXHASH_REDUCE): New macro.
5451 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5452 Use it instead of discarding useful hash info with large hash values.
5453 (sxhash_float): New function.
5454 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5455 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5456 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5457 Rewrite to use FIXNUM_BITS, as this simplifies things.
5458 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5459 Adjust signatures to match updated version of code.
5460 (consing_since_gc): Now EMACS_INT, since a single hash table can
5461 use more than INT_MAX bytes.
5463 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5465 Make it possible to build with GCC-4.6+ -O2 -flto.
5467 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5469 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5471 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5472 Call minibuffer-inactive-mode.
5474 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5476 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5477 Update dependencies.
5479 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5481 * data.c (init_data): Remove code for UTS, this system is not
5484 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5486 Don't force ./temacs to start in terminal mode.
5488 * frame.c (make_initial_frame): Initialize faces in all cases, not
5489 only when CANNOT_DUMP is defined.
5490 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5492 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5494 * dispnew.c (add_window_display_history): Use const for the string
5495 pointer. Remove declaration, not needed.
5497 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5499 Use 'inline', not 'INLINE'.
5500 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5501 * alloc.c, fontset.c (INLINE): Remove.
5502 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5503 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5504 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5505 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5506 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5510 Make it possible to run ./temacs.
5512 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5513 syms_of_callproc does the same thing. Remove test for
5514 "initialized", do it in the caller.
5515 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5517 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5519 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5520 (read_minibuf): Use get_minibuffer.
5521 (syms_of_minibuf): Use DEFSYM.
5522 (Qmetadata): New var.
5523 * data.c (Qbuffer): Don't make it static.
5524 (syms_of_data): Use DEFSYM.
5526 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5528 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5529 (CCL_CODE_MIN): New macro.
5531 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5533 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5535 * eval.c (Qdebug): Now static.
5536 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5537 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5538 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5540 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5542 * image.c: Various fixes to ImageMagick code comments.
5543 (Fimagemagick_types): Doc fix.
5545 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5547 Minor fixes prompted by GCC 4.6.0 warnings.
5549 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5551 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5552 (x_clipboard_manager_save_all): Move extern decl to ...
5553 * xterm.h: ... here, so that it can be checked for consistency.
5555 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5557 * xselect.c (x_clipboard_manager_save_frame)
5558 (x_clipboard_manager_save_all): New functions.
5559 (Fx_clipboard_manager_save): Lisp function deleted.
5561 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5562 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5564 * xterm.h: Update prototype.
5566 2011-05-28 William Xu <william.xwl@gmail.com>
5568 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5571 2011-05-28 Jim Meyering <meyering@redhat.com>
5573 Avoid a sign-extension bug in crypto_hash_function.
5574 * fns.c (to_uchar): Define.
5575 (crypto_hash_function): Use it to convert some newly-signed
5576 variables to unsigned, to avoid sign-extension bugs. For example,
5577 without this change, (md5 "truc") would evaluate to
5578 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5579 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5580 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5582 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5584 Integer overflow fixes.
5586 * dbusbind.c: Serial number integer overflow fixes.
5587 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5588 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5589 to hold a serial number that is too large for a fixnum.
5590 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5591 Check for serial numbers out of range. Decode any serial number
5592 that was so large that it became a float. (Bug#8722)
5594 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5596 Use XFASTINT rather than XUINT when numbers are nonnegative.
5597 (xd_append_arg, Fdbus_method_return_internal):
5598 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5599 arguments, check that Lisp number is nonnegative, rather than
5600 silently wrapping negative numbers around. (Bug#8722)
5601 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5604 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5606 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5608 ccl: add integer overflow checks
5609 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5610 (IN_INT_RANGE): New macros.
5611 (ccl_driver): Use them to check for integer overflow when
5612 decoding a CCL program. Many of the new checks are whether XINT (x)
5613 fits in int; it doesn't always, on 64-bit hosts. The new version
5614 doesn't catch all possible integer overflows, but it's an
5615 improvement. (Bug#8719)
5617 * alloc.c (make_event_array): Use XINT, not XUINT.
5618 There's no need for unsigned here.
5620 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5621 This follows up to the 2011-05-06 change that substituted uintptr_t
5622 for EMACS_INT. This case wasn't caught back then.
5624 Rework Fformat to avoid integer overflow issues.
5625 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5626 now (part of C89). Include <verify.h>.
5627 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5628 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5629 (Fformat): Avoid the prepass trying to compute sizes; it was only
5630 approximate and thus did not catch overflow reliably. Instead, walk
5631 through the format just once, formatting and computing sizes as we go,
5632 checking for integer overflow at every step, and allocating a larger
5633 buffer as needed. Keep track separately whether the format is
5634 multibyte. Keep only the most-recently calculated precision, rather
5635 than them all. Record whether each argument has been converted to
5636 string. Use EMACS_INT, not int, for byte and char and arg counts.
5637 Support field widths and precisions larger than INT_MAX. Avoid
5638 sprintf's undefined behavior with conversion specifications such as %#d
5639 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5640 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5641 formatting out-of-range floating point numbers with int
5644 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5646 * data.c: Avoid integer truncation in expressions involving floats.
5647 * data.c: Include <intprops.h>.
5648 (arith_driver): When there's an integer overflow in an expression
5649 involving floating point, convert the integers to floating point
5650 so that the resulting value does not suffer from catastrophic
5651 integer truncation. For example, on a 64-bit host (* 4
5652 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5653 Do not rely on undefined behavior after integer overflow.
5655 merge count_size_as_multibyte, parse_str_to_multibyte
5656 * character.c, character.h (count_size_as_multibyte):
5657 Rename from parse_str_to_multibyte; all uses changed.
5658 Check for integer overflow.
5659 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5660 since it's now a duplicate of the other. This is more of
5661 a character than a buffer op, so better that it's in character.c.
5662 * fns.c, print.c: Adjust to above changes.
5664 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5666 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5668 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5670 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5671 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5672 (x_clipboard_manager_save): Now static.
5673 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5675 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5676 (crypto_hash_function): Now static.
5677 Fix pointer signedness problems. Avoid unnecessary initializations.
5679 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5681 * termhooks.h (Vselection_alist): Make it terminal-local.
5683 * terminal.c (create_terminal): Initialize it.
5685 * xselect.c: Support for clipboard managers.
5686 (Vselection_alist): Move to termhooks.h as terminal-local var.
5687 (LOCAL_SELECTION): New macro.
5688 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5689 (symbol_to_x_atom): Remove gratuitous arg.
5690 (x_handle_selection_request, lisp_data_to_selection_data)
5691 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5692 (x_own_selection, x_get_local_selection, x_convert_selection):
5693 New arg, specifying work frame. Use terminal-local Vselection_alist.
5694 (some_frame_on_display): Delete unused function.
5695 (Fx_own_selection_internal, Fx_get_selection_internal)
5696 (Fx_disown_selection_internal, Fx_selection_owner_p)
5697 (Fx_selection_exists_p): New optional frame arg.
5698 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5699 (x_handle_selection_clear): Don't treat other terminals with the
5700 same keyboard specially. Use the terminal-local Vselection_alist.
5701 (x_clear_frame_selections): Use Frun_hook_with_args.
5703 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5705 * xterm.h: Add support for those atoms.
5707 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5709 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5710 (converted_selections, conversion_fail_tag): New global variables.
5711 (x_selection_request_lisp_error): Free the above.
5712 (x_get_local_selection): Remove unnecessary code.
5713 (x_reply_selection_request): Args changed; handle arbitrary array
5714 of converted selections stored in converted_selections.
5715 Separate the XChangeProperty and SelectionNotify steps.
5716 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5717 (x_convert_selection): New function.
5718 (x_handle_selection_event): Simplify.
5719 (x_get_foreign_selection): Don't ignore incoming requests while
5720 waiting for an answer; this will fail when we implement
5721 SAVE_TARGETS, and seems unnecessary anyway.
5722 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5723 (Vx_sent_selection_functions): Doc fix.
5725 2011-05-26 Leo Liu <sdl.web@gmail.com>
5727 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5729 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5731 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5733 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5734 for fringe update if it has periodic bitmap.
5735 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5736 and fringe_bitmap_periodic_p.
5738 * fringe.c (get_fringe_bitmap_data): New function.
5739 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5740 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5741 row. Mark glyph row for fringe update if periodicity changed.
5743 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5744 for fringe update unless it has periodic bitmap.
5746 2011-05-25 Kenichi Handa <handa@m17n.org>
5748 * xdisp.c (get_next_display_element): Set correct it->face_id for
5749 a static composition.
5751 2011-05-24 Leo Liu <sdl.web@gmail.com>
5754 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5756 * fns.c (crypto_hash_function, Fsha1): New function.
5757 (Fmd5): Use crypto_hash_function.
5758 (syms_of_fns): Add Ssha1.
5760 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5762 * gnutls.c: Remove unused macros.
5763 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5764 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5765 Remove macros that are defined and never used.
5766 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5768 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5770 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5771 (Fx_get_selection_internal): Minor cleanup.
5772 (Fx_own_selection_internal): Rename arguments for consistency with
5775 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5777 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5779 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5781 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5783 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5785 * dispnew.c (scrolling_window): Don't exclude the case that the
5786 last enabled row in the desired matrix touches the bottom boundary.
5788 2011-05-21 Glenn Morris <rgm@gnu.org>
5790 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5791 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5792 and add some more files.
5794 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5796 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5797 report_file_error introduced by the change from 2011-05-07.
5799 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5801 * systime.h (Time): Define only if emacs is defined.
5802 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5803 where the include path doesn't have X11/X.h by default. See
5804 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5806 2011-05-20 Kenichi Handa <handa@m17n.org>
5808 * composite.c (find_automatic_composition): Fix previous change.
5810 2011-05-20 Glenn Morris <rgm@gnu.org>
5812 * lisp.mk: New file, split from Makefile.in.
5813 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5814 (shortlisp): Remove.
5815 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5817 2011-05-19 Glenn Morris <rgm@gnu.org>
5819 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5820 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5821 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5822 (lisp): Set the order to that of loadup.el.
5823 (shortlisp): Make it a copy of $lisp.
5824 (SOME_MACHINE_LISP): Remove.
5825 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5826 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5828 2011-05-18 Kenichi Handa <handa@m17n.org>
5830 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5831 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5832 (find_automatic_composition): Mostly rewrite for efficiency.
5834 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5836 * makefile.w32-in: Update dependencies.
5838 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5840 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5841 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5843 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5845 Fix some integer overflow issues, such as string length overflow.
5847 * insdel.c (count_size_as_multibyte): Check for string overflow.
5849 * character.c (lisp_string_width): Check for string overflow.
5850 Use EMACS_INT, not int, for string indexes and lengths; in
5851 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5852 the resulting string length overflows an EMACS_INT; instead,
5853 report a string overflow if no precision given. When checking for
5854 precision exhaustion, use a check that cannot possibly have
5855 integer overflow. (Bug#8675)
5856 * character.h (lisp_string_width): Adjust to new signature.
5858 * alloc.c (string_overflow): New function.
5859 (Fmake_string): Use it. This doesn't change behavior, but saves
5860 a few bytes and will simplify future changes.
5861 * character.c (string_escape_byte8): Likewise.
5862 * lisp.h (string_overflow): New decl.
5864 Fixups, following up to the user-interface timestamp change.
5865 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5866 for UI timestamps, instead of unsigned long.
5867 * msdos.c (mouse_get_pos): Likewise.
5868 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5869 * w32gui.h (Time): Define by including "systime.h" rather than by
5870 declaring it ourselves. (Bug#8664)
5872 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5873 * image.c (clear_image_cache): Likewise.
5875 * term.c (term_mouse_position): Don't assume time_t wraparound.
5877 Be more systematic about user-interface timestamps.
5878 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5879 and sometimes 'EMACS_UINT', to represent these timestamps.
5880 This change causes it to use 'Time' uniformly, as that's what X uses.
5881 This makes the code easier to follow, and makes it easier to catch
5882 integer overflow bugs such as Bug#8664.
5883 * frame.c (Fmouse_position, Fmouse_pixel_position):
5884 Use Time, not unsigned long, for user-interface timestamps.
5885 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5886 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5887 * keyboard.h (last_event_timestamp): Likewise.
5888 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5889 * menu.h (xmenu_show): Likewise.
5890 * term.c (term_mouse_position): Likewise.
5891 * termhooks.h (struct input_event.timestamp): Likewise.
5892 (struct terminal.mouse_position_hook): Likewise.
5893 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5894 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5895 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5896 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5898 * menu.h, termhooks.h: Include "systime.h", for Time.
5900 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5901 Don't assume that the difference between two unsigned long values
5902 can fit into an integer. At this point, we know button_down_time
5903 <= event->timestamp, so the difference must be nonnegative, so
5904 there's no need to cast the result if double-click-time is
5905 nonnegative, as it should be; check that it's nonnegative, just in
5906 case. This bug is triggered when events are more than 2**31 ms
5907 apart (about 25 days). (Bug#8664)
5909 * xselect.c (last_event_timestamp): Remove duplicate decl.
5910 (x_own_selection): Remove needless cast to unsigned long.
5912 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5913 that always fit in int. Use a sentinel instead of a counter, to
5914 avoid a temp and to allay GCC's concerns about possible int overflow.
5915 * frame.h (struct frame): Use int for menu_bar_items_used
5916 instead of EMACS_INT, since it always fits in int.
5918 * menu.c (grow_menu_items): Check for int overflow.
5920 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5922 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5923 Before, the code was not consistent. These values cannot exceed
5924 2**31 - 1 so there's no need to make them unsigned.
5925 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5926 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5927 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5929 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5931 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5932 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5933 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5934 presumably because the widths might not match.
5936 * window.c (size_window): Avoid needless test at loop start.
5938 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5940 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5942 2011-05-12 Drew Adams <drew.adams@oracle.com>
5944 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5946 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5948 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5949 `width' to `bar_area_x' and `bar_area_width', respectively.
5950 (x_scroll_run): Take account of fringe background extension.
5952 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5953 Rename local vars `left' and `width' to `bar_area_x' and
5954 `bar_area_width', respectively.
5955 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5956 background extension.
5958 2011-05-10 Jim Meyering <meyering@redhat.com>
5960 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5962 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5964 * image.c (Finit_image_library): Return t for built-in image types,
5965 like pbm and xbm. (Bug#8640)
5967 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5969 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5971 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5973 * w32console.c (Fset_screen_color): Doc fix.
5974 (Fget_screen_color): New function.
5975 (syms_of_ntterm): Defsubr it.
5977 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5978 unlink the temporary file if Fcall_process didn't create it in the
5980 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5981 child process will be redirected to a file specified with `:file'.
5982 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5983 cue to call_process_cleanup not to close that handle.
5985 2011-05-07 Ben Key <bkey76@gmail.com>
5987 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5988 one of two shell specific rules, either bootstrap-temacs-CMD or
5989 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5990 to the previous implementation of the bootstrap-temacs rule.
5991 The bootstrap-temacs-CMD rule is similar to the previous
5992 implementation of the bootstrap-temacs rule except that it
5993 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5996 These changes, along with some changes to nt/configure.bat,
5997 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5998 earlier fix to add support for --cflags and --ldflags options
5999 that include quotes so that it works whether make uses cmd or
6002 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6004 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6005 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6007 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6008 a string. Handle both cases.
6009 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6010 (Fdbus_register_method): Use Qinvalid_function.
6012 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6014 * makefile.w32-in: Update dependencies.
6015 (LISP_H): Add inttypes.h and stdin.h.
6016 (PROCESS_H): Add unistd.h.
6018 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6020 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6021 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6023 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6025 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6027 * term.c (vfatal): Remove stray call to va_end.
6028 It's not needed and the C Standard doesn't allow it here anyway.
6030 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6031 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6033 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6036 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6038 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6040 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6042 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6044 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6046 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6047 * charset.c (Fdefine_charset_internal): Don't initialize
6048 charset.code_space[15]. The value was garbage, on hosts with
6049 32-bit int (Bug#8600).
6051 * lread.c (read_integer): Be more consistent with string-to-number.
6052 Use string_to_number to do the actual conversion; this avoids
6053 rounding errors and fixes some other screwups. Without this fix,
6054 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6055 (digit_to_number): Move earlier, for benefit of read_integer.
6056 Return -1 if the digit is out of range for the base, -2 if it is
6057 not a digit in any supported base. (Bug#8602)
6059 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6061 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6062 to match comment at start of function. This also removes a
6063 GCC warning about overflow in a 32+64-bit port.
6065 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6067 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6068 Reported by Stefan Monnier in
6069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6070 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6071 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6073 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6074 (EMACS_UINTPTR): Likewise, with uintptr_t.
6076 * lisp.h: Prefer 64-bit EMACS_INT if available.
6077 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6078 on 32-bit hosts that have 64-bit int, so that they can access
6080 However, temporarily disable this change unless the temporary
6081 symbol WIDE_EMACS_INT is defined.
6083 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6085 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6086 This removes an assumption that EMACS_INT and long are the same
6087 width as pointers. The assumption is true for Emacs porting targets
6088 now, but we want to make other targets possible.
6089 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6090 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6091 In the rest of the code, change types of integers that hold casted
6092 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6093 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6094 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6095 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6096 No need to cast type when ORing.
6097 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6098 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6099 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6100 assume EMACS_INT is the same width as char *.
6101 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6102 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6103 Remove no-longer-needed casts.
6104 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6105 (xg_tool_bar_help_callback, xg_make_tool_item):
6106 Use EMACS_INTPTR to hold an integer
6107 that will be cast to void *; this can avoid a GCC warning
6108 if EMACS_INT is not the same width as void *.
6109 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6110 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6111 (current_message_1, set_message_1):
6112 Use a local to convert to proper width without a cast.
6113 * xmenu.c (dialog_selection_callback): Likewise.
6115 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6116 Also, don't assume VALBITS / RAND_BITS is less than 5,
6117 and don't rely on undefined behavior when shifting a 1 left into
6119 * lisp.h (get_random): Change signature to match.
6121 * lread.c (hash_string): Use size_t, not int, for hash computation.
6122 Normally we prefer signed values; but hashing is special, because
6123 it's better to use unsigned division on hash table sizes so that
6124 the remainder is nonnegative. Also, size_t is the natural width
6125 for hashing into memory. The previous code used 'int', which doesn't
6126 retain enough info to hash well into very large tables.
6127 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6129 * dbusbind.c: Don't possibly lose pointer info when converting.
6130 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6131 Use XPNTR rather than XHASH, so that the high-order bits of
6132 the pointer aren't lost when converting through void *.
6134 * eval.c (Fautoload): Don't double-shift a pointer.
6136 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6138 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6140 * gnutls.c (DEF_GNUTLS_FN):
6141 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6143 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6145 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6148 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6150 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6151 New version that can reserve upto 2GB of heap space.
6153 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6155 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6157 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6159 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6160 `gnutls_certificate_set_x509_key_file'.
6162 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6164 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6165 Update dependencies.
6167 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6169 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6170 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6171 Remove unused parameter `fildes'.
6172 * process.c (read_process_output, send_process): Don't pass it.
6174 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6176 Fix previous change: the library cache is defined in w32.c.
6177 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6178 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6180 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6182 Implement dynamic loading of GnuTLS on Windows.
6184 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6185 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6186 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6189 * gnutls.c (Qgnutls_dll): Define.
6190 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6191 (gnutls_*): Declare function pointers.
6192 (init_gnutls_functions): New function to initialize function pointers.
6193 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6194 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6195 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6196 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6197 (emacs_gnutls_write, emacs_gnutls_read)
6198 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6199 (Fgnutls_available_p): New function.
6200 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6201 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6202 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6204 * image.c: Include w32.h.
6205 (Vimage_type_cache): Delete.
6206 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6207 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6208 (w32_delayed_load): Move to w32.c.
6210 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6212 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6213 (w32_delayed_load): Move from image.c. When loading a library, record
6214 its filename in the :loaded-from property of the library id.
6215 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6216 Initialize and staticpro them.
6217 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6219 * process.c: Include lisp.h before w32.h, not after.
6220 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6221 instead of gnutls_record_check_pending.
6223 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6225 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6227 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6228 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6231 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6233 * xterm.c (x_set_frame_alpha): Do not set property on anything
6234 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6236 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6238 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6240 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6242 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6243 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6244 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6245 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6246 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6247 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6248 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6249 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6250 (Qgnutls_bootprop_callbacks_verify): Make static.
6252 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6254 * callproc.c: Indentation fixup.
6256 * sysdep.c (wait_for_termination_1): Make static.
6257 (wait_for_termination, interruptible_wait_for_termination):
6258 Move after wait_for_termination_1.
6260 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6262 * sysdep.c (interruptible_wait_for_termination): New function
6263 which is like wait_for_termination, but allows keyboard
6266 * callproc.c (Fcall_process): Add (:file "file") as an option for
6268 (Fcall_process_region): Ditto.
6270 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6272 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6273 rather than `XVECTOR (FOO)->size'.
6275 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6276 inttypes.h, as a gnulib replacement is used if it not available in
6279 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6281 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6282 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6283 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6285 * coding.c (coding_alloc_by_realloc): Error out if destination
6286 will grow beyond MOST_POSITIVE_FIXNUM.
6287 (decode_coding_emacs_mule): Abort if there isn't enough place in
6288 charbuf for the composition carryover bytes. Reserve an extra
6289 space for up to 2 characters produced in a loop.
6290 (decode_coding_iso_2022): Abort if there isn't enough place in
6291 charbuf for the composition carryover bytes.
6293 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6295 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6296 aborting when %lld or %lll format is passed.
6297 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6298 %llo or %llx format is passed. (Bug#8545)
6300 * window.c (window_scroll_line_based): Use a marker instead of
6301 simple variables to record original value of point. (Bug#7952)
6303 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6304 produced by %s or %c overflows available buffer space. (Bug#8545)
6306 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6308 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6309 (SIZE_MAX): Move defn after all includes, as they might #define it.
6311 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6313 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6315 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6317 * keyboard.c (Qdelayed_warnings_hook): Define.
6318 (command_loop_1): Run `delayed-warnings-hook'
6319 if Vdelayed_warnings_list is non-nil.
6320 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6321 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6323 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6325 * doprnt.c (doprnt): Don't return value smaller than the buffer
6326 size if the message was truncated. (Bug#8545).
6328 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6330 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6331 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6333 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6335 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6337 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6339 * makefile.w32-in: Update dependencies.
6341 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6343 Improve `doprnt' and its usage. (Bug#8545)
6344 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6345 `format_end'. Remove support for %l as a conversion specifier.
6346 Don't use xrealloc. Improve diagnostics when the %l size modifier
6347 is used. Update the commentary.
6349 * eval.c (verror): Simplify calculation of size_t.
6351 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6354 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6356 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6359 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6361 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6362 This makes this file independent of the recent pseudovector change.
6364 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6366 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6368 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6369 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6370 Remove unused local.
6371 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6373 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6374 GCC 4.6.0 optimizes based on type-based alias analysis.
6375 For example, if b is of type struct buffer * and v of type struct
6376 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6377 != &v->size, and therefore "v->size = 1; b->size = 2; return
6378 v->size;" must therefore return 1. This assumption is incorrect
6379 for Emacs, since it type-puns struct Lisp_Vector * with many other
6380 types. To fix this problem, this patch adds a new type struct
6381 vectorlike_header that documents the constraints on layout of vectors
6382 and pseudovectors, and helps optimizing compilers not get fooled
6383 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6384 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6385 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6387 (XSETPVECTYPE): Rewrite in terms of new macro.
6388 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6389 This is a bit clearer, and further avoids the possibility of
6390 undesirable aliasing.
6391 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6392 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6393 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6394 since Lisp_Subr is a special case (no "next" field).
6395 (ASIZE): Now uses header.size rather than size.
6396 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6397 to avoid the hassle of writing XVECTOR (foo)->header.size.
6398 (struct vectorlike_header): New type.
6399 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6400 object, to help avoid aliasing.
6401 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6402 (SUBRP): Likewise, since Lisp_Subr is a special case.
6403 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6404 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6405 (struct Lisp_Hash_Table): Combine first two members into a single
6406 struct vectorlike_header member. All uses of "size" and "next" members
6407 changed to be "header.size" and "header.next".
6408 * buffer.h (struct buffer): Likewise.
6409 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6410 * frame.h (struct frame): Likewise.
6411 * process.h (struct Lisp_Process): Likewise.
6412 * termhooks.h (struct terminal): Likewise.
6413 * window.c (struct save_window_data, struct saved_window): Likewise.
6414 * window.h (struct window): Likewise.
6415 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6416 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6417 * buffer.c (init_buffer_once): Likewise.
6418 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6420 * process.c (Fformat_network_address): Use local var for size,
6423 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6425 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6426 * data.c (atof): Remove decl; no longer used or needed.
6427 (digit_to_number): Move to lread.c.
6428 (Fstring_to_number): Use new string_to_number function, to be
6429 consistent with how the Lisp reader treats infinities and NaNs.
6430 Do not assume that floating-point numbers represent EMACS_INT
6431 without losing information; this is not true on most 64-bit hosts.
6432 Avoid double-rounding errors, by insisting on integers when
6433 parsing non-base-10 numbers, as the documentation specifies.
6434 * lisp.h (string_to_number): New decl, replacing ...
6435 (isfloat_string): Remove.
6436 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6437 (read1): Do not accept +. and -. as integers; this
6438 appears to have been a coding error. Similarly, do not accept
6439 strings like +-1e0 as floating point numbers. Do not report
6440 overflow for integer overflows unless the base is not 10 which
6441 means we have no simple and reliable way to continue.
6442 Break out the floating-point parsing into a new
6443 function string_to_number, so that Fstring_to_number parses
6444 floating point numbers consistently with the Lisp reader.
6445 (digit_to_number): Move here from data.c. Make it static inline.
6446 (E_CHAR, EXP_INT): Remove, replacing with ...
6447 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6448 (string_to_number): New function, replacing isfloat_string.
6449 This function checks for valid syntax and produces the resulting
6450 Lisp float number too. Rework it so that string-to-number
6451 no longer mishandles examples like "1.0e+". Use strtoumax,
6452 so that overflow for non-base-10 numbers is reported only when
6453 there's no portable and simple way to convert to floating point.
6455 * textprop.c (set_text_properties_1): Rewrite for clarity,
6456 and to avoid GCC warning about integer overflow.
6458 * intervals.h (struct interval): Use EMACS_INT for members
6459 where EMACS_UINT might cause problems. See
6460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6461 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6462 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6464 (offset_intervals): Tell GCC not to worry about length overflow
6465 when negating a negative length.
6467 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6468 (overrun_check_free): Likewise.
6470 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6471 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6474 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6475 (gnutls_make_error): Rename local to avoid shadowing.
6476 (gnutls_emacs_global_deinit): ifdef out; not used.
6477 (Fgnutls_boot): Use const for pointer to readonly storage.
6478 Comment out unused local. Fix pointer signedness problems.
6480 * lread.c (openp): Don't stuff size_t into an 'int'.
6481 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6482 about possible signed overflow.
6484 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6485 (GDK_KEY_g): Don't define if already defined.
6486 (xg_prepare_tooltip): Avoid pointer signedness problem.
6487 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6489 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6490 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6492 * xfns.c (Fx_window_property): Simplify a bit,
6493 to make a bit faster and to avoid GCC 4.6.0 warning.
6494 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6496 * fns.c (internal_equal): Don't assume size_t fits in int.
6498 * alloc.c (compact_small_strings): Tighten assertion a little.
6500 Replace pEd with more-general pI, and fix some printf arg casts.
6501 * lisp.h (pI): New macro, generalizing old pEd macro to other
6502 conversion specifiers. For example, use "...%"pI"d..." rather
6503 than "...%"pEd"...".
6504 (pEd): Remove. All uses replaced with similar uses of pI.
6505 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6506 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6507 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6508 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6509 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6510 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6511 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6513 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6514 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6515 * print.c (safe_debug_print, print_object): Likewise.
6516 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6518 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6519 avoiding the 0 flag, which is not portable.
6520 * process.c (Fmake_network_process): Use pI to avoid cast.
6521 * region-cache.c (pp_cache): Likewise.
6522 * xdisp.c (decode_mode_spec): Likewise.
6523 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6524 behavior on 64-bit hosts with printf arg.
6525 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6526 (x_stop_queuing_selection_requests): Likewise.
6527 (x_get_window_property): Don't truncate byte count to an 'int'
6530 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6531 here, since it parses constructs like leading '-' and spaces,
6532 which are not wanted; and it overflows with large numbers.
6533 Instead, simply match F[0-9]+, which is what is wanted anyway.
6535 * alloc.c: Remove unportable assumptions about struct layout.
6536 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6537 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6538 (allocate_vectorlike, make_pure_vector): Use the new macros,
6539 plus offsetof, to remove unportable assumptions about struct layout.
6540 These assumptions hold on all porting targets that I know of, but
6541 they are not guaranteed, they're easy to remove, and removing them
6542 makes further changes easier.
6544 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6545 This doesn't fix a bug but makes the code clearer.
6546 (string_overrun_cookie): Now const. Use initializers that
6547 don't formally overflow signed char, to avoid warnings.
6548 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6549 can cause Emacs to crash when string overrun checking is enabled.
6550 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6551 multiple of sizeof (EMACS_INT); it need not be, if
6552 alignof(EMACS_INT) < sizeof (EMACS_INT).
6553 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6555 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6557 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6559 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6561 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6562 supposed to be handshaking. (Bug#8556)
6563 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6565 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6567 * lisp.h (Qdebug): List symbol.
6568 * eval.c (Qdebug): Restore global linkage.
6569 * keyboard.c (debug-on-event): New variable.
6570 (handle_user_signal): Break into debugger when debug-on-event
6571 matches the current signal symbol.
6573 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6575 * alloc.c (check_sblock, check_string_bytes)
6576 (check_string_free_list): Convert to standard C.
6578 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6580 * w32.c (emacs_gnutls_push): Fix typo.
6582 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6584 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6585 "cast to pointer from integer of different size".
6587 Improve doprnt and its use in verror. (Bug#8545)
6588 * doprnt.c (doprnt): Document the set of format control sequences
6589 supported by the function. Use SAFE_ALLOCA instead of always
6592 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6593 is one byte too soon. Don't use xrealloc; instead xfree and
6596 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6598 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6601 * gnutls.c: Renamed global_initialized to
6602 gnutls_global_initialized. Added internals for the
6603 :verify-hostname-error, :verify-error, and :verify-flags
6604 parameters of `gnutls-boot' and documented those parameters in the
6605 docstring. Start callback support.
6606 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6607 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6608 on error. Return error code.
6609 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6610 (emacs_gnutls_read): Likewise.
6611 (Fgnutls_boot): Return handshake error code.
6612 (emacs_gnutls_handle_error): New function.
6613 (wsaerror_to_errno): Likewise.
6615 * w32.h (emacs_gnutls_pull): Add prototype.
6616 (emacs_gnutls_push): Likewise.
6618 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6619 (emacs_gnutls_push): Likewise.
6621 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6623 * process.c (wait_reading_process_output): Check if GnuTLS
6624 buffered some data internally if no FDs are set for TLS
6627 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6628 (LIBS): Link to USER_LIBS.
6629 ($(BLD)/gnutls.$(0)): New target.
6631 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6633 * xdisp.c (handle_single_display_spec): Rename the
6634 display_replaced_before_p argument into display_replaced_p, to
6635 make it consistent with the commentary. Fix typos in the
6638 * textprop.c (syms_of_textprop): Remove dead code.
6639 (copy_text_properties): Delete obsolete commentary about an
6640 interface that was deleted long ago. Fix typos in the description
6643 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6644 to changes in oldXMenu/XMenu.h from 2011-04-16.
6645 <menu_help_message, prev_menu_help_message>: Constify.
6646 (IT_menu_make_room): menu->help_text is now `const char **';
6649 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6650 to changes in oldXMenu/XMenu.h from 2011-04-16.
6651 (struct XMenu): Declare `help_text' `const char **'.
6653 * xfaces.c <Qunspecified>: Make extern again.
6655 * syntax.c: Include sys/types.h before including regex.h, as
6658 * doc.c (get_doc_string): Improve the format passed to `error'.
6660 * doprnt.c (doprnt): Improve commentary.
6662 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6664 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6667 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6668 changes in globals.h immediately force recompilation.
6669 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6670 $(CURDIR)/s/ms-w32.h.
6671 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6673 * character.c (Fchar_direction): Function deleted.
6674 (syms_of_character): Don't defsubr it.
6675 <char-direction-table>: Deleted.
6677 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6679 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6680 * doprnt.c: Include limits.h.
6681 (SIZE_MAX): New macro.
6682 (doprnt): Return a size_t value. 2nd arg is now size_t.
6683 Many local variables are now size_t instead of int or unsigned.
6684 Improve overflow protection. Support `l' modifier for integer
6685 conversions. Support %l conversion. Don't assume an EMACS_INT
6686 argument for integer conversions and for %c.
6688 * lisp.h (doprnt): Restore prototype.
6690 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6693 * Makefile.in (base_obj): Add back doprnt.o.
6695 * deps.mk (doprnt.o): Add back prerequisites.
6696 (callint.o): Depend on character.h.
6698 * eval.c (internal_lisp_condition_case): Include the handler
6699 representation in the error message.
6700 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6701 when breaking from the loop.
6703 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6705 * callint.c (Fcall_interactively): When displaying error message
6706 about invalid control letter, pass the character's codepoint, not
6707 a pointer to its multibyte form. Improve display of the character
6708 in octal and display also its hex code.
6710 * character.c (char_string): Use %x to display the (unsigned)
6711 codepoint of an invalid character, to avoid displaying a bogus
6714 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6715 `error', not SYMBOL_NAME itself.
6717 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6718 character arguments to `error'.
6720 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6721 to `error' in error message about FINAL_CHAR argument. Make sure
6722 FINAL_CHAR is a character, and use %c when it is passed as
6723 argument to `error'.
6725 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6727 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6729 * w32.c: Include <time.h>.
6730 (sys_localtime): New function.
6732 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6734 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6736 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6738 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6740 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6743 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6745 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6746 gl_state.e_property when gl_state.object is Qt.
6748 * insdel.c (make_gap_larger): Remove limitation of buffer size
6751 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6753 * xdisp.c (lookup_glyphless_char_display)
6754 (produce_glyphless_glyph): Handle cons cell entry in
6755 glyphless-char-display.
6756 (Vglyphless_char_display): Document it.
6758 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6759 glyphless-char-display.
6761 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6763 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6765 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6767 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6768 definition for no-X builds.
6770 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6772 Static checks with GCC 4.6.0 and non-default toolkits.
6774 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6776 * process.c (keyboard_bit_set): Define only if SIGIO.
6777 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6778 (send_process): Repair possible setjmp clobbering.
6780 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6782 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6784 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6786 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6787 Define only if needed.
6789 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6790 by pacifying GCC about it. Maybe it's time to retire it?
6791 * xfaces.c (USG, __TIMEVAL__): Likewise.
6793 * dispextern.h (struct redisplay_interface): Rename param
6795 * termhooks.h (struct terminal): Likewise.
6796 * xterm.c (xembed_send_message): Likewise.
6798 * insdel.c (make_gap_smaller): Define only if
6799 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6801 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6804 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6805 so that we aren't warned about unused symbols.
6807 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6809 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6811 * xfns.c (x_real_positions): Mark locals as initialized.
6813 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6815 * xterm.c: Fix problems found by static analysis with other toolkits.
6816 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6817 (x_dispatch_event): Declare static if USE_GTK, and
6818 define if USE_GTK || USE_X_TOOLKIT.
6819 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6820 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6821 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6822 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6824 * xmenu.c (menu_help_callback): Pointer type fixes.
6825 Use const pointers when pointing at readonly data. Avoid pointer
6827 (FALSE): Remove unused macro.
6828 (update_frame_menubar): Remove unused decl.
6830 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6832 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6833 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6834 (single_menu_item): Rename local to avoid shadowing.
6836 * keyboard.c (make_lispy_event): Remove unused local var.
6838 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6839 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6841 * bitmaps: Change bitmaps from unsigned char back to the X11
6842 compatible char. Avoid the old compiler warnings about
6843 out-of-range initializers by using, for example, '\xab' rather
6846 * xgselect.c (xgselect_initialize): Check vs interface
6847 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6849 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6851 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6852 to read-only memory.
6854 * fns.c (vector): Remove; this old hack is no longer needed.
6856 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6858 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6860 * xrdb.c (x_load_resources): Omit unused local.
6862 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6863 (x_window): Rename locals to avoid shadowing.
6864 (USG): Use the kludged USG macro, to pacify gcc.
6866 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6867 (x_term_init): Remove local to avoid shadowing.
6869 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6871 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6872 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6874 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6876 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6878 Fix regex.c, syntax.c and friends for buffers > 2GB.
6879 * syntax.h (struct gl_state_s): Declare character position members
6882 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6884 * textprop.c (verify_interval_modification, interval_of):
6885 Declare arguments EMACS_INT.
6887 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6890 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6892 * indent.c (Fvertical_motion): Local variable it_start is now
6895 * regex.c (re_match, re_match_2, re_match_2_internal)
6896 (bcmp_translate, regcomp, regexec, print_double_string)
6897 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6898 (re_compile_pattern, re_exec): Declare arguments and local
6899 variables `size_t' and `ssize_t' and return values `regoff_t', as
6901 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6902 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6903 <compile_stack_type>: `size' and `avail' are now `size_t'.
6905 * regex.h <regoff_t>: Use ssize_t, not int.
6906 (re_search, re_search_2, re_match, re_match_2): Arguments that
6907 specify buffer/string position and length are now ssize_t and
6908 size_t. Return type is regoff_t.
6910 2011-04-16 Ben Key <bkey76@gmail.com>
6912 * nsfont.m: Fixed bugs in ns_get_family and
6913 ns_descriptor_to_entity that were caused by using free to
6914 deallocate memory blocks that were allocated by xmalloc (via
6915 xstrdup). This caused Emacs to crash when compiled with
6916 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6917 --enable-checking=xmallocoverrun). xfree is now used to
6918 deallocate these memory blocks.
6920 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6922 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6924 emacs_write: Accept and return EMACS_INT for sizes.
6925 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6927 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6928 Accept and return EMACS_INT.
6929 (emacs_gnutls_write): Return the number of bytes written on
6931 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6932 (emacs_read, emacs_write): Remove check for negative size, as the
6933 Emacs source code has been audited now.
6934 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6935 (emacs_read, emacs_write): Use it.
6936 * process.c (send_process): Adjust to the new signatures of
6937 emacs_write and emacs_gnutls_write. Do not attempt to store
6938 a byte offset into an 'int'; it might overflow.
6939 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6941 * sound.c: Don't assume sizes fit in 'int'.
6942 (struct sound_device.period_size, alsa_period_size):
6943 Return EMACS_INT, not int.
6944 (struct sound_device.write, vox_write, alsa_write):
6945 Accept EMACS_INT, not int.
6946 (wav_play, au_play): Use EMACS_INT to store sizes and to
6947 record read return values.
6949 2011-04-15 Ben Key <bkey76@gmail.com>
6951 * keyboard.c (Qundefined): Don't declare static since it is used
6953 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6954 static since they are used in nsfont.m.
6956 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6958 * process.c (Qprocessp): Don't declare static.
6959 * lisp.h (Qprocessp): Declare again.
6961 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6963 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6965 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6967 Improve C-level modularity by making more things 'static'.
6969 Don't publish debugger-only interfaces to other modules.
6970 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6971 (verify_bytepos, count_markers): Move decls to the only modules
6973 * region-cache.h (pp_cache): Likewise.
6974 * window.h (check_all_windows): Likewise.
6975 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6977 * sysdep.c (croak): Now static, if
6978 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6979 * syssignal.h (croak): Declare only if not static.
6981 * alloc.c (refill_memory_reserve): Now static if
6982 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6983 * lisp.h (refill_memory_reserve): Declare only if not static.
6985 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6986 Define only if USE_LUCID.
6988 * xrdb.c (x_customization_string, x_rm_string): Now static.
6990 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6991 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6993 * xdisp.c (draw_row_with_mouse_face): Now static.
6994 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6996 * window.h (check_all_windows): Mark externally visible.
6998 * window.c (window_deletion_count): Now static.
7000 * undo.c: Make symbols static if they're not exported.
7001 (last_undo_buffer, last_boundary_position, pending_boundary):
7004 * textprop.c (interval_insert_behind_hooks): Now static.
7005 (interval_insert_in_front_hooks): Likewise.
7007 * term.c: Make symbols static if they're not exported.
7008 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7009 (max_frame_lines, tty_set_terminal_modes):
7010 (tty_reset_terminal_modes, tty_turn_off_highlight):
7011 (get_tty_terminal): Now static.
7012 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7013 * termhooks.h (term_mouse_moveto): Do not declare if
7015 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7016 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7018 * sysdep.c: Make symbols static if they're not exported.
7019 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7021 (sigprocmask_set, full_mask): Remove; unused.
7022 (wait_debugging): Mark as visible.
7023 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7024 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7026 * syntax.c (syntax_temp): Define only if !__GNUC__.
7028 * sound.c (current_sound_device, current_sound): Now static.
7030 * search.c (searchbufs, searchbuf_head): Now static.
7032 * scroll.c (scroll_cost): Remove; unused.
7033 * dispextern.h (scroll_cost): Remove decl.
7035 * region-cache.h (pp_cache): Mark as externally visible.
7037 * process.c: Make symbols static if they're not exported.
7038 (process_tick, update_tick, create_process, chan_process):
7039 (Vprocess_alist, proc_buffered_char, datagram_access):
7040 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7041 (deactivate_process): Mark defn as static, as well as decl.
7042 * lisp.h (create_process): Remove decl.
7043 * process.h (chan_process, Vprocess_alist): Remove decls.
7045 * print.c: Make symbols static if they're not exported.
7046 (print_depth, new_backquote_output, being_printed, print_buffer):
7047 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7048 (print_interval, print_number_index, initial_stderr_stream):
7050 * lisp.h (Fprinc): Remove decl.
7051 (debug_output_compilation_hack): Mark as externally visible.
7053 * sysdep.c (croak): Move decl from here to syssignal.h.
7054 * syssignal.h (croak): Put it here, so the API can be checked when
7055 'croak' is called from dissociate_if_controlling_tty.
7057 * minibuf.c: Make symbols static if they're not exported.
7058 (minibuf_save_list, choose_minibuf_frame): Now static.
7059 * lisp.h (choose_minibuf_frame): Remove decl.
7061 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7063 * lread.c: Make symbols static if they're not exported.
7064 (read_objects, initial_obarray, oblookup_last_bucket_number):
7066 (make_symbol): Remove; unused.
7067 * lisp.h (initial_obarray, make_symbol): Remove decls.
7069 * keyboard.c: Make symbols static if they're not exported.
7070 (single_kboard, recent_keys_index, total_keys, recent_keys):
7071 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7072 (this_single_command_key_start, echoing, last_auto_save):
7073 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7074 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7075 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7076 (Vlispy_mouse_stem, double_click_count):
7078 (force_auto_save_soon): Define only if SIGDANGER.
7079 (ignore_mouse_drag_p): Now static if
7080 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7081 (print_help): Remove; unused.
7082 (stop_character, last_timer_event): Mark as externally visible.
7083 * keyboard.h (ignore_mouse_drag_p): Declare only if
7084 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7085 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7086 * lisp.h (echoing): Remove decl.
7087 (force_auto_save_soon): Declare only if SIGDANGER.
7088 * xdisp.c (redisplay_window): Simplify code, to make it more
7089 obvious that ignore_mouse_drag_p is not accessed if !defined
7090 USE_GTK && !defined HAVE_NS.
7092 * intervals.c: Make symbols static if they're not exported.
7093 (merge_properties_sticky, merge_interval_right, delete_interval):
7095 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7097 * insdel.c: Make symbols static if they're not exported.
7098 However, leave prepare_to_modify_buffer alone. It's never
7099 called from outside this function, but that appears to be a bug.
7100 (combine_after_change_list, combine_after_change_buffer):
7101 (adjust_after_replace, signal_before_change): Now static.
7102 (adjust_after_replace_noundo): Remove; unused.
7103 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7104 (signal_before_change): Remove decls.
7106 * indent.c (val_compute_motion, val_vmotion): Now static.
7108 * image.c: Make symbols static if they're not exported.
7109 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7111 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7112 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7114 * fringe.c (standard_bitmaps): Now static.
7115 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7117 * frame.c: Make symbols static if they're not exported.
7118 (x_report_frame_params, make_terminal_frame): Now static.
7119 (get_frame_param): Now static, unless HAVE_NS.
7120 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7121 (x_get_resource_string): Remove; not used.
7122 * frame.h (make_terminal_frame, x_report_frame_params):
7123 (x_get_resource_string); Remove decls.
7124 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7125 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7127 * font.c, fontset.c: Make symbols static if they're not exported.
7128 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7129 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7130 * font.c (font_close_object): Now static.
7131 * font.h (font_close_object): Remove.
7132 * fontset.c (FONTSET_OBJLIST): Remove.
7133 (free_realized_fontset) #if-0 the body, which does nothing.
7134 (face_suitable_for_char_p): #if-0, as it's never called.
7135 * fontset.h (face_suitable_for_char_p): Remove decl.
7136 * xfaces.c (face_at_string_position):
7137 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7138 since 0 is always ASCII.
7140 * fns.c (weak_hash_tables): Now static.
7142 * fileio.c: Make symbols static if they're not exported.
7143 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7144 (Vwrite_region_annotation_buffers): Now static.
7146 * eval.c: Make symbols static if they're not exported.
7147 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7148 * lisp.h (backtrace_list): Remove decl.
7150 * emacs.c: Make symbols static if they're not exported.
7151 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7152 (fatal_error_code, fatal_error_signal_hook, standard_args):
7154 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7155 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7156 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7157 * lisp.h (fatal_error_signal_hook): Remove decl.
7158 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7160 * editfns.c: Move a (normally-unused) function to its only use.
7161 * editfns.c, lisp.h (get_operating_system_release): Remove.
7162 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7163 worth the hassle of breaking this out.
7165 * xterm.c: Make symbols static if they're not exported.
7166 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7167 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7168 (x_destroy_window, x_delete_display):
7170 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7171 (x_mouse_leave): Remove; unused.
7172 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7173 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7174 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7176 (x_mouse_leave): Declare only if WINDOWSNT.
7177 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7178 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7181 * ftxfont.c: Make symbols static if they're not exported.
7182 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7184 * font.h (ftxfont_driver): Likewise.
7186 * xfns.c: Make symbols static if they're not exported.
7187 (x_last_font_name, x_display_info_for_name):
7188 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7189 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7190 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7191 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7192 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7193 (last_show_tip_args): Now static.
7194 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7195 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7196 (x_screen_planes): Remove; unused.
7197 * dispextern.h (x_screen_planes): Remove decl.
7199 * dispnew.c: Make symbols static if they're not exported.
7200 * dispextern.h (redraw_garbaged_frames, scrolling):
7201 (increment_row_positions): Remove.
7202 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7203 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7205 (redraw_garbaged_frames): Remove; unused.
7207 * xfaces.c: Make symbols static if they're not exported.
7208 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7210 * xterm.h (defined_color): Remove decls.
7211 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7212 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7213 (menu_face_changed_default, defined_color, free_realized_face):
7214 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7215 (ascii_face_of_lisp_face): Remove; unused.
7217 * xdisp.c: Make symbols static if they're not exported.
7218 * dispextern.h (scratch_glyph_row, window_box_edges):
7219 (glyph_to_pixel_coords, set_cursor_from_row):
7220 (get_next_display_element, set_iterator_to_next):
7221 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7222 (show_mouse_face): Remove decls
7223 * frame.h (message_buf_print): Likewise.
7224 * lisp.h (pop_message, set_message, check_point_in_composition):
7226 * xterm.h (set_vertical_scroll_bar): Likewise.
7227 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7228 (message_buf_print, scratch_glyph_row, displayed_buffer):
7229 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7230 (get_next_display_element, show_mouse_face, window_box_edges):
7231 (frame_to_window_pixel_xy, check_point_in_composition):
7232 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7233 (glyph_to_pixel_coords): Remove; unused.
7235 * dired.c (file_name_completion): Now static.
7237 * dbusbind.c (xd_in_read_queued_messages): Now static.
7239 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7240 * data.c (circular_list_error): Remove.
7242 * commands.h (last_point_position, last_point_position_buffer):
7243 (last_point_position_window): Remove decls.
7244 * keyboard.c: Make these variables static.
7246 * coding.h (coding, code_convert_region, encode_coding_gap):
7248 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7249 (iso_code_class, detect_coding, code_convert_region): Now static.
7250 (encode_coding_gap): Remove; unused.
7252 * chartab.c (chartab_chars, chartab_bits): Now static.
7254 * charset.h (charset_iso_8859_1): Remove decl.
7255 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7258 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7259 * ccl.c (Vccl_program_table): Now static.
7260 (check_ccl_update): Remove; unused.
7262 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7263 * category.h: ... from here.
7264 * category.c (check_category_table, set_category_set): Now static.
7266 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7267 * lisp.h: Remove these decls.
7269 * buffer.c (buffer_count): Remove unused var.
7271 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7272 so that it's not optimized away.
7273 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7274 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7275 exported only to the debugger.
7277 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7278 * atimer.h (run_all_atimers): Remove; not exported.
7280 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7281 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7282 was inaccessible from Lisp.
7283 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7284 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7286 alloc.c: Import and export fewer symbols, and remove unused items.
7287 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7289 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7290 it's not optimized away by whole-program optimization.
7291 (message_enable_multibyte, free_misc): Remove.
7292 (catchlist, handlerlist, mark_backtrace):
7293 Declare only if BYTE_MARK_STACK.
7294 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7295 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7296 (message_enable_multibyte): Remove decl.
7297 (free_misc, interval_free_list, float_block, float_block_index):
7298 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7299 (cons_free_list, last_marked_index):
7301 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7302 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7303 (mark_backtrace): Define only if BYTE_MARK_STACK.
7304 * xdisp.c (message_enable_multibyte): Now static.
7306 Declare Lisp_Object Q* variables to be 'static' if not exported.
7307 This makes it easier for human readers (and static analyzers)
7308 to see whether these variables are used from other modules.
7309 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7310 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7311 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7312 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7313 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7314 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7315 * xmenu.c, xselect.c:
7316 Declare Q* vars static if they are not used in other modules.
7317 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7318 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7319 Remove decls of unexported vars.
7320 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7322 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7324 Make Emacs functions such as Fatom 'static' by default.
7325 This makes it easier for human readers (and static analyzers)
7326 to see whether these functions can be called from other modules.
7327 DEFUN now defines a static function. To make the function external
7328 so that it can be used in other C modules, use the new macro DEFUE.
7329 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7330 (Finit_image_library):
7331 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7332 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7333 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7334 Remove decls, since these functions are now static.
7335 (Funintern, Fget_internal_run_time): New decls, since these functions
7336 were already external.
7338 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7339 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7340 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7341 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7342 * keyboard.c, keymap.c, lread.c:
7343 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7344 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7345 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7346 Mark functions with DEFUE instead of DEFUN,
7347 if they are used in other modules.
7348 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7349 decls for now-static functions.
7350 * buffer.h (Fdelete_overlay): Remove decl.
7351 * callproc.c (Fgetenv_internal): Mark as internal.
7352 * composite.c (Fremove_list_of_text_properties): Remove decl.
7353 (Fcomposition_get_gstring): New forward static decl.
7354 * composite.h (Fcomposite_get_gstring): Remove decl.
7355 * dired.c (Ffile_attributes): New forward static decl.
7356 * doc.c (Fdocumntation_property): New forward static decl.
7357 * eval.c (Ffetch_bytecode): New forward static decl.
7358 (Funintern): Remove extern decl; now in .h file where it belongs.
7359 * fileio.c (Fmake_symbolic_link): New forward static decl.
7360 * image.c (Finit_image_library): New forward static decl.
7361 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7362 * intervals.h (Fprevious_property_change):
7363 (Fremove_list_of_text_properties): Remove decls.
7364 * keyboard.c (Fthis_command_keys): Remove decl.
7365 (Fcommand_execute): New forward static decl.
7366 * keymap.c (Flookup_key): New forward static decl.
7367 (Fcopy_keymap): Now static.
7368 * keymap.h (Flookup_key): Remove decl.
7369 * process.c (Fget_process): New forward static decl.
7370 (Fprocess_datagram_address): Mark as internal.
7371 * syntax.c (Fsyntax_table_p): New forward static decl.
7372 (skip_chars): Remove duplicate decl.
7373 * textprop.c (Fprevious_property_change): New forward static decl.
7374 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7376 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7377 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7379 * editfns.c (Fformat): Remove unreachable code.
7381 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7383 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7386 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7388 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7389 when at ZV. (Bug#8487)
7391 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7393 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7395 * keyboard.c (parse_tool_bar_item): Likewise.
7396 * sound.c (sound_cleanup, alsa_close): Likewise.
7397 * termcap.c (tgetent): Likewise.
7398 * xfns.c (x_default_font_parameter): Likewise.
7399 * xsettings.c (read_and_apply_settings): Likewise.
7401 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7402 (overrun_check_free): Protoize.
7404 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7406 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7407 since callers should never pass a negative size.
7408 Change the signature to match that of plain 'read' and 'write'; see
7409 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7410 * lisp.h: Update prototypes of emacs_write and emacs_read.
7412 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7414 * xdisp.c (redisplay_window): Don't try to determine the character
7415 position of the scroll margin if the window start point w->startp
7416 is outside the buffer's accessible region. (Bug#8468)
7418 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7420 Fix write-region and its subroutines for buffers > 2GB.
7421 * fileio.c (a_write, e_write): Modify declaration of arguments and
7422 local variables to support buffers larger than 2GB.
7423 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7425 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7426 argument, local variables, and return value.
7428 * lisp.h: Update prototypes of emacs_write and emacs_read.
7430 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7432 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7434 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7436 Fix more problems found by GCC 4.6.0's static checks.
7438 * xdisp.c (vmessage): Use a better test for character truncation.
7440 * charset.c (load_charset_map): <, not <=, for optimization,
7441 and to avoid potential problems with integer overflow.
7442 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7443 * casetab.c (set_identity, shuffle): Likewise.
7444 * editfns.c (Fformat): Likewise.
7445 * syntax.c (skip_chars): Likewise.
7447 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7448 This also lets GCC 4.6.0 generate slightly better loop code.
7450 * callint.c (Fcall_interactively): <, not <=, for optimization.
7451 (Fcall_interactively): Count the number of arguments produced,
7452 not the number of arguments given. This is simpler and lets GCC
7453 4.6.0 generate slightly better code.
7455 * ftfont.c: Distingish more carefully between FcChar8 and char.
7456 The previous code passed unsigned char * to a functions like
7457 strlen and xstrcasecmp that expect char *, which does not
7458 conform to the C standard.
7459 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7460 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7461 char * when the C standard requires it.
7463 * keyboard.c (read_char): Remove unused var.
7465 * eval.c: Port to Windows vsnprintf (Bug#8435).
7467 (SIZE_MAX): Define if the headers do not.
7468 (verror): Do not give up if vsnprintf returns a negative count.
7469 Instead, grow the buffer. This ports to Windows vsnprintf, which
7470 does not conform to C99. Problem reported by Eli Zaretskii.
7471 Also, simplify the allocation scheme, by avoiding the need for
7472 calling realloc, and removing the ALLOCATED variable.
7474 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7476 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7477 But keep the doprint source code for now, as we might revamp it
7478 and use it again (Bug#8435).
7479 * lisp.h (doprnt): Remove.
7480 * Makefile.in (base_obj): Remove doprnt.o.
7481 * deps.mk (doprnt.o): Remove.
7483 error: Print 32- and 64-bit integers portably (Bug#8435).
7484 Without this change, on typical 64-bit hosts error ("...%d...", N)
7485 was used to print both 32- and 64-bit integers N, which relied on
7487 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7489 * lisp.h (error, verror): Mark as printf-like functions.
7490 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7491 Report overflow in size calculations when allocating printf buffer.
7492 Do not truncate output string at its first null byte.
7493 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7494 Truncate the output at a character boundary, since vsnprintf does not
7496 * charset.c (check_iso_charset_parameter): Convert internal
7497 character to string before calling 'error', since %c now has the
7499 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7500 overflow when computing char to be passed to 'error'. Do not
7501 pass Lisp_Object to 'error'; pass the integer instead.
7502 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7503 formatted with plain %d.
7505 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7507 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7509 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7511 * xterm.c (x_catch_errors): Remove duplicate declaration.
7513 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7515 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7517 2011-04-10 Jim Meyering <meyering@redhat.com>
7519 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7520 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7521 return ssize_t not "int", and use size_t as the buffer length.
7522 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7523 * gnutls.h: Update declarations.
7524 * process.c (read_process_output): Use ssize_t, to match.
7525 (send_process): Likewise.
7527 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7529 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7531 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7533 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7534 Use unsigned char, to match FcChar8 type definition.
7536 * xterm.c (handle_one_xevent):
7537 * xmenu.c (create_and_show_popup_menu):
7538 * xselect.c (x_decline_selection_request)
7539 (x_reply_selection_request): Avoid type-punned deref of X events.
7541 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7543 Fix some uses of `int' instead of EMACS_INT.
7544 * search.c (string_match_1, fast_string_match)
7545 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7546 (scan_buffer, find_next_newline_no_quit)
7547 (find_before_next_newline, search_command, Freplace_match)
7548 (Fmatch_data): Make some `int' variables be EMACS_INT.
7550 * xdisp.c (display_count_lines): 3rd argument and return value now
7551 EMACS_INT. All callers changed.
7552 (pint2hrstr): Last argument is now EMACS_INT.
7554 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7555 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7556 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7557 (decode_coding_utf_16, decode_coding_emacs_mule)
7558 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7559 (decode_coding_ccl, decode_coding_charset)
7560 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7561 (decode_coding_iso_2022, decode_coding_emacs_mule)
7562 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7563 <char_offset, last_offset>: Declare EMACS_INT.
7564 (encode_coding_utf_8, encode_coding_utf_16)
7565 (encode_coding_emacs_mule, encode_invocation_designation)
7566 (encode_designation_at_bol, encode_coding_iso_2022)
7567 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7568 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7570 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7571 (encode_invocation_designation): Last argument P_NCHARS is now
7573 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7574 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7576 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7579 * ccl.c (Fccl_execute_on_string): Declare some variables
7582 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7584 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7586 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7588 * process.c (Fformat_network_address): Doc fix.
7590 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7592 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7594 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7596 * keyboard.c (read_char): Call Lisp function help-form-show,
7597 instead of using internal_with_output_to_temp_buffer.
7598 (Qhelp_form_show): New var.
7599 (syms_of_keyboard): Use DEFSYM macro.
7601 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7603 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7605 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7607 * process.c (Flist_processes): Remove to Lisp.
7608 (list_processes_1): Delete.
7610 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7612 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7614 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7616 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7618 Fix more problems found by GCC 4.6.0's static checks.
7620 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7622 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7624 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7626 * xdisp.c (vmessage): Mark as a printf-like function.
7628 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7630 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7632 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7633 printf-like functions.
7634 (tiff_load): Add casts to remove these marks before passing them
7635 to system-supplied API.
7637 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7639 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7640 This avoids several warnings with gcc -Wstrict-overflow.
7641 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7642 directly, rather than having caller test rule sign. This avoids
7643 some unnecessary tests.
7644 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7645 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7646 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7648 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7649 (xfont_open): Avoid unnecessary tests.
7651 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7653 * composite.h, composite.c (composition_gstring_put_cache):
7654 Use EMACS_INT, not int, for length.
7656 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7657 breaking out part of COMPOSITION_DECODE_RULE.
7658 (COMPOSITION_DECODE_RULE): Use it.
7659 * composite.c (get_composition_id): Remove unused local vars,
7660 by using the new macro.
7662 * textprop.c (set_text_properties_1): Change while to do-while,
7663 since the condition is always true at first.
7665 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7666 (interval_deletion_adjustment): Return unsigned value.
7669 * process.c (list_processes_1, create_pty, read_process_output):
7670 (exec_sentinel): Remove vars that were set but not used.
7671 (create_pty): Remove unnecessary "volatile"s.
7672 (Fnetwork_interface_info): Avoid possibility of int overflow.
7673 (read_process_output): Do adaptive read buffering even if carryover.
7674 (read_process_output): Simplify nbytes computation if buffered.
7676 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7678 * syntax.c (scan_words): Remove var that was set but not used.
7679 (update_syntax_table): Use unsigned instead of int.
7681 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7682 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7683 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7685 * print.c (print_error_message): Avoid int overflow.
7687 * font.c (font_list_entities): Redo for clarity,
7688 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7690 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7691 (font_score): Avoid potential overflow in diff calculation.
7693 * fns.c (substring_both): Remove var that is set but not used.
7694 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7696 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7698 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7699 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7700 can always succeed if overflow has undefined behavior.
7702 * search.c (boyer_moore, wordify): Remove vars set but not used.
7703 (wordify): Omit three unnecessary tests.
7705 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7706 All callers changed. This avoids the need for an unused var.
7708 * casefiddle.c (casify_region): Remove var that is set but not used.
7710 * dired.c (file_name_completion): Remove var that is set but not used.
7712 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7714 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7715 (Finsert_file_contents): Remove unnecessary code checking fd.
7717 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7718 Check for integer overflow on size calculations.
7720 * buffer.c (Fprevious_overlay_change): Remove var that is set
7723 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7724 Remove vars that are set but not used.
7725 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7726 (timer_check_2): Mark vars as initialized.
7728 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7730 * image.c (lookup_image): Remove var that is set but not used.
7731 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7733 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7734 that are set but not used.
7736 * xfns.c (make_invisible_cursor): Don't return garbage
7737 if XCreateBitmapFromData fails (Bug#8410).
7739 * xselect.c (x_get_local_selection, x_handle_property_notify):
7740 Remove vars that are set but not used.
7742 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7743 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7745 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7746 Remove var that is set but not used.
7747 (scroll_bar_windows_size): Now size_t, not int.
7748 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7751 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7752 (map_tty_color) [!defined MSDOS]: Likewise.
7754 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7756 * coding.c: Remove vars that are set but not used.
7757 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7758 All callers changed.
7759 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7760 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7761 (decode_coding_charset): Remove vars that are set but not used.
7763 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7764 that is set but not used.
7766 * print.c (print_object): Remove var that is set but not used.
7768 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7769 The gnulib version avoids calling malloc in the usual case,
7770 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7771 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7772 * filelock.c (current_lock_owner): Likewise.
7773 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7774 * sysdep.c: Include allocator.h, careadlinkat.h.
7775 (emacs_no_realloc_allocator): New static constant.
7776 (emacs_readlink): New function.
7777 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7778 ../lib/careadlinkat.h.
7780 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7782 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7783 first non-nil return value).
7785 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7787 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7788 if not defined (Bug#8403).
7790 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7792 * xdisp.c (display_count_lines): Remove parameter `start',
7793 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7794 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7795 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7796 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7797 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7798 and thereabouts. All callers changed.
7799 (get_per_char_metric): Remove parameter `f', unused since
7800 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7802 2011-04-02 Jim Meyering <meyering@redhat.com>
7804 do not dereference NULL upon failed strdup
7805 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7806 (ns_get_family): Likewise.
7808 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7810 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7812 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7814 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7817 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7819 Add lexical binding.
7821 * window.c (Ftemp_output_buffer_show): New fun.
7822 (Fsave_window_excursion):
7823 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7825 * lread.c (lisp_file_lexically_bound_p): New function.
7826 (Fload): Bind Qlexical_binding.
7827 (readevalloop): Remove `evalfun' arg.
7828 Bind Qinternal_interpreter_environment.
7829 (Feval_buffer): Bind Qlexical_binding.
7830 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7832 (syms_of_lread): Declare `lexical-binding'.
7834 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7836 * keyboard.c (eval_dyn): New fun.
7837 (menu_item_eval_property): Use it.
7839 * image.c (parse_image_spec): Use Ffunctionp.
7841 * fns.c (concat, mapcar1): Accept byte-code-functions.
7843 * eval.c (Fsetq): Handle lexical vars.
7844 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7845 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7846 (FletX, Flet): Obey lexical binding.
7847 (Fcommandp): Handle closures.
7848 (Feval): New `lexical' arg.
7849 (eval_sub): New function extracted from Feval. Use it almost
7850 everywhere where Feval was used. Look up vars in lexical env.
7852 (Ffunctionp): Move from subr.el.
7853 (Ffuncall): Handle closures.
7854 (apply_lambda): Remove `eval_flags'.
7855 (funcall_lambda): Handle closures and new byte-code-functions.
7856 (Fspecial_variable_p): New function.
7857 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7858 but without exporting it to Lisp.
7860 * doc.c (Fdocumentation, store_function_docstring):
7861 * data.c (Finteractive_form): Handle closures.
7863 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7866 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7868 (exec_byte_code): New function extracted from Fbyte_code to handle new
7869 calling convention for byte-code-functions. Add new byte-codes.
7871 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7873 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7875 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7877 * xdisp.c (redisplay_internal): Fix prototype.
7879 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7881 * xdisp.c (SCROLL_LIMIT): New macro.
7882 (try_scrolling): Use it when setting scroll_limit.
7883 Limit scrolling to 100 screen lines.
7884 (redisplay_window): Even when falling back on "recentering",
7885 position point in the window according to scroll-conservatively,
7886 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7888 (try_scrolling): When point is above the window, allow searching
7889 as far as scroll_max, or one screenful, to compute vertical
7890 distance from PT to the scroll margin position. This prevents
7891 try_scrolling from unnecessarily failing when
7892 scroll-conservatively is set to a value slightly larger than the
7893 window height. Clean up the case of PT below the margin at bottom
7894 of window: scroll_max can no longer be INT_MAX. When aggressive
7895 scrolling is in use, don't let point enter the opposite scroll
7896 margin as result of the scroll.
7897 (syms_of_xdisp) <scroll-conservatively>: Document the
7898 threshold of 100 lines for never-recentering scrolling.
7900 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7902 * dispextern.h (move_it_by_lines):
7903 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7904 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7905 (message_log_check_duplicate): Remove parameters `prev_bol' and
7906 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7907 (redisplay_internal): Remove parameter `preserve_echo_area',
7908 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7910 * indent.c (Fvertical_motion):
7911 * window.c (window_scroll_pixel_based, Frecenter):
7912 Don't pass `need_y_p' to `move_it_by_lines'.
7914 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7916 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7917 steal a few bits to be more compact.
7918 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7919 Remove unneeded casts.
7921 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7923 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7925 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7926 binding" message (bug#7967).
7928 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7930 Fix more problems found by GCC 4.6.0's static checks.
7932 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7933 Remove unused local var.
7935 * editfns.c (Fmessage_box): Remove unused local var.
7937 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7938 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7939 Omit unused local vars.
7940 * window.c (shrink_windows): Omit unused local var.
7941 * menu.c (digest_single_submenu): Omit unused local var.
7942 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7943 Omit unused local var.
7945 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7946 Don't assume string length fits in int.
7947 (keyremap_step, read_key_sequence): Use size_t for sizes.
7948 (read_key_sequence): Don't check last_real_key_start redundantly.
7950 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7951 instead of alloca (Bug#8344).
7953 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7954 (Fbacktrace_frame): Don't assume nframes fits in int.
7956 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7958 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7961 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7963 * cm.c (calccost): Turn while-do into do-while, for clarity.
7965 * keyboard.c (syms_of_keyboard): Use the same style as later
7966 in this function when indexing through an array. This also
7967 works around GCC bug 48267.
7969 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7971 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7973 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7974 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7976 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7977 This avoids undefined behavior on integer overflow, and is a bit
7978 more convenient anyway since it is compared to a size_t variable.
7980 Variadic C functions now count arguments with size_t, not int.
7981 This avoids an unnecessary limitation on 64-bit machines, which
7982 caused (substring ...) to crash on large vectors (Bug#8344).
7983 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7984 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7985 All variadic functions and their callers changed accordingly.
7986 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7987 * data.c (arith_driver, float_arith_driver): Likewise.
7988 * editfns.c (general_insert_function): Likewise.
7989 * eval.c (struct backtrace.nargs, interactive_p)
7990 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7991 (funcall_lambda, mark_backtrace): Likewise.
7992 * fns.c (concat): Likewise.
7993 * frame.c (x_set_frame_parameters): Likewise.
7994 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7995 0 if not found, not -1. All callers changed.
7997 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7998 (stack_copy_size): Now size_t, not int.
7999 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8001 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8003 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8004 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8005 All callers changed.
8007 * lisp.h (multibyte_char_to_unibyte):
8008 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8009 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8010 * character.h (CHAR_TO_BYTE8):
8011 * cmds.c (internal_self_insert):
8012 * editfns.c (general_insert_function):
8013 * keymap.c (push_key_description):
8014 * search.c (Freplace_match):
8015 * xdisp.c (message_dolog, set_message_1): All callers changed.
8017 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8019 * keyboard.c (safe_run_hook_funcall): New function.
8020 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8021 don't set the hook to nil, but remove the offending function instead.
8022 (Qcommand_hook_internal): Remove, unused.
8023 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8024 Vcommand_hook_internal.
8026 * eval.c (enum run_hooks_condition): Remove.
8027 (funcall_nil, funcall_not): New functions.
8028 (run_hook_with_args): Call each function through a `funcall' argument.
8029 Remove `cond' argument, now redundant.
8030 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8031 (Frun_hook_with_args_until_failure): Adjust accordingly.
8032 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8034 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8036 * dispextern.h (string_buffer_position): Remove declaration.
8038 * print.c (strout): Remove parameter `multibyte', unused since
8039 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8041 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8042 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8043 All callers changed.
8045 * w32.c (_wsa_errlist): Use braces for struct initializers.
8047 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8048 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8049 All callers changed.
8050 (string_buffer_position): Likewise. Also, make static (it's never
8051 used outside xdisp.c).
8052 (cursor_row_p): Remove parameter `w', unused since
8053 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8054 (decode_mode_spec): Remove parameter `precision', introduced during
8055 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8056 All callers changed.
8058 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8060 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8062 2011-03-27 Anders Lindgren <andlind@gmail.com>
8064 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8065 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8066 (ns_update_auto_hide_menu_bar): New functions.
8067 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8068 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8069 ns_constrain_all_frames.
8070 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8071 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8073 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8075 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8077 2011-03-27 Glenn Morris <rgm@gnu.org>
8079 * syssignal.h: Replace RETSIGTYPE with void.
8080 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8081 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8082 Replace SIGTYPE with void everywhere.
8083 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8084 * s/template.h (SIGTYPE): Remove commented out definition.
8086 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8088 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8089 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8091 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8093 * w32.c (read_unc_volume): Use parameter `henum', instead of
8094 global variable `wget_enum_handle'.
8096 * keymap.c (describe_vector): Remove parameters `indices' and
8097 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8098 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8100 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8102 * keyboard.c (timer_check): Remove parameter `do_it_now',
8103 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8104 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8105 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8107 * keyboard.c (read_char):
8108 * w32menu.c (w32_menu_display_help):
8109 * xmenu.c (show_help_event, menu_help_callback):
8110 Adjust calls to `show_help_echo'.
8112 * gtkutil.c (xg_maybe_add_timer):
8113 * keyboard.c (readable_events):
8114 * process.c (wait_reading_process_output):
8115 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8117 * insdel.c (adjust_markers_gap_motion):
8118 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8119 (gap_left, gap_right): Don't call it.
8121 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8123 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8124 incurred during fontification.
8126 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8128 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8129 (DEFVAR_PER_BUFFER): Don't pass it.
8131 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8132 (scrolling_window): Don't pass it.
8134 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8136 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8138 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8140 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8141 of variables specific to SELinux and computation of `encoded_absname'.
8143 * image.c (XPutPixel): Remove unused variable `height'.
8145 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8147 * unexw32.c (get_section_info): Remove unused variable `section'.
8149 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8150 (system_process_attributes): Remove unused variable `sess'.
8151 (sys_read): Remove unused variable `err'.
8153 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8154 (w32_wnd_proc): Remove unused variable `isdead'.
8155 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8156 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8157 (x_create_tip_frame): Remove unused variable `tem'.
8159 * w32inevt.c (w32_console_read_socket):
8160 Remove unused variable `no_events'.
8162 * w32term.c (x_draw_composite_glyph_string_foreground):
8163 Remove unused variable `width'.
8165 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8167 * w32term.c (x_set_glyph_string_clipping):
8168 Don't pass uninitialized region to CombineRgn.
8170 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8172 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8173 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8174 (Fx_close_connection): Remove unused variable `i'.
8176 * w32font.c (w32font_draw): Return number of glyphs.
8177 (w32font_open_internal): Remove unused variable `i'.
8178 (w32font_driver): Add missing initializer.
8180 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8181 (fill_in_menu): Remove unused variable `items_added'.
8183 * w32term.c (last_mouse_press_frame): Remove static global variable.
8184 (w32_clip_to_row): Remove unused variable `f'.
8185 (x_delete_terminal): Remove unused variable `i'.
8187 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8188 (NOTHING): Remove unused static global variable.
8189 (uniscribe_check_otf): Remove unused variable `table'.
8190 (uniscribe_font_driver): Add missing initializers.
8192 2011-03-23 Julien Danjou <julien@danjou.info>
8194 * term.c (Fsuspend_tty, Fresume_tty):
8195 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8196 * window.c (temp_output_buffer_show):
8197 * insdel.c (signal_before_change):
8198 * frame.c (Fhandle_switch_frame):
8199 * fileio.c (Fdo_auto_save):
8200 * emacs.c (Fkill_emacs):
8201 * editfns.c (save_excursion_restore):
8202 * cmds.c (internal_self_insert):
8203 * callint.c (Fcall_interactively):
8204 * buffer.c (Fkill_all_local_variables):
8205 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8207 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8208 unconditionally since it does the check itself.
8210 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8212 Fix more problems found by GCC 4.5.2's static checks.
8214 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8215 the first time through the loop, since we know p0 < p1 then.
8216 This also avoids a gcc -Wstrict-overflow warning.
8218 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8219 leading to a memory leak, possible in functions like
8220 load_charset_map_from_file that can allocate an unbounded number
8221 of objects (Bug#8318).
8223 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8224 that could (at least in theory) be that large.
8226 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8227 This is less likely to overflow, and avoids undefined behavior if
8228 overflow does occur. All callers changed. Use strtoul to scan
8229 for the unsigned long integer.
8230 (pint2hrstr): Simplify and tune code slightly.
8231 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8233 * scroll.c (do_scrolling): Work around GCC bug 48228.
8234 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8236 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8237 This also avoids a warning with gcc -Wstrict-overflow.
8238 (validate_x_resource_name): Simplify count usage.
8239 This also avoids a warning with gcc -Wstrict-overflow.
8241 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8244 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8246 * process.c (Fmake_network_process): Use socklen_t, not int,
8247 where POSIX says socklen_t is required in portable programs.
8248 This fixes a porting bug on hosts like 64-bit HP-UX, where
8249 socklen_t is wider than int (Bug#8277).
8250 (Fmake_network_process, server_accept_connection):
8251 (wait_reading_process_output, read_process_output):
8254 * process.c: Rename or move locals to avoid shadowing.
8255 (list_processes_1, Fmake_network_process):
8256 (read_process_output_error_handler, exec_sentinel_error_handler):
8257 Rename or move locals.
8258 (Fmake_network_process): Define label "retry_connect" only if needed.
8259 (Fnetwork_interface_info): Fix pointer signedness.
8260 (process_send_signal): Add cast to avoid pointer signedness problem.
8261 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8262 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8264 Make tparam.h and terminfo.c consistent.
8265 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8266 Include tparam.h instead, since it declares them.
8267 * cm.h (PC): Remove extern decl; tparam.h now does this.
8268 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8269 * terminfo.c: Include tparam.h, to check interfaces.
8270 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8271 (tparam): Adjust signature to match interface in tparam.h;
8272 this removes some undefined behavior. Check that outstring and len
8273 are zero, which they always are with Emacs.
8274 * tparam.h (PC, BC, UP): New extern decls.
8276 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8277 (xftfont_open): Rename locals to avoid shadowing.
8279 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8280 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8281 (OTF_TAG_SYM): Omit macro if not needed.
8282 (ftfont_list): Remove unused local.
8283 (get_adstyle_property, ftfont_pattern_entity):
8284 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8285 Rename locals to avoid shadowing.
8287 * xfont.c (xfont_list_family): Mark var as initialized.
8289 * xml.c (make_dom): Now static.
8291 * composite.c (composition_compute_stop_pos): Rename local to
8293 (composition_reseat_it): Remove unused locals.
8294 (find_automatic_composition, composition_adjust_point): Likewise.
8295 (composition_update_it): Mark var as initialized.
8296 (find_automatic_composition): Mark vars as initialized,
8297 with a FIXME (Bug#8290).
8299 character.h: Rename locals to avoid shadowing.
8300 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8301 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8302 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8303 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8306 * textprop.c (property_change_between_p): Remove; unused.
8308 * intervals.c (interval_start_pos): Now static.
8310 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8312 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8313 Rename locals to avoid shadowing.
8315 * sound.c (wav_play, au_play, Fplay_sound_internal):
8316 Fix pointer signedness.
8317 (alsa_choose_format): Remove unused local var.
8318 (wav_play): Initialize a variable to 0, to prevent undefined
8319 behavior (Bug#8278).
8321 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8323 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8326 clobbering (Bug#8298).
8327 * sysdep.c (sys_subshell): Likewise.
8328 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8330 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8331 This should get cleaned up, so that child_setup has the
8332 same signature on all platforms.
8334 * callproc.c (call_process_cleanup): Now static.
8335 (relocate_fd): Rename locals to avoid shadowing.
8337 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8339 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8340 not to be necessary, and produces flickering.
8342 2011-03-20 Glenn Morris <rgm@gnu.org>
8344 * config.in: Remove file.
8346 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8348 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8349 are now in src/globals.h.
8350 (syms_of_minibuf): Remove spurious & from previous change.
8352 2011-03-20 Leo Liu <sdl.web@gmail.com>
8354 * minibuf.c (completing-read-function): New variable.
8355 (completing-read-default): Rename from completing-read.
8356 (completing-read): Call completing-read-function.
8358 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8360 * xfaces.c (Fx_load_color_file):
8361 Read color file from absolute filename (bug#8250).
8363 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8365 * makefile.w32-in: Update dependencies.
8367 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8369 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8371 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8373 Fix more problems found by GCC 4.5.2's static checks.
8375 * process.c (make_serial_process_unwind, send_process_trap):
8376 (sigchld_handler): Now static.
8378 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8379 That way, the code declares only the vars that it needs.
8380 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8381 * s/cygwin.h (PTY_ITERATION): Likewise.
8382 * s/darwin.h (PTY_ITERATION): Likewise.
8383 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8385 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8386 * process.c (allocate_pty): Don't declare stb unless it's needed.
8388 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8389 (CONSTANTLIM): Remove; unused.
8390 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8391 Define only if needed.
8393 * unexelf.c (unexec): Name an expression,
8394 to avoid gcc -Wbad-function-cast warning.
8395 Use a different way to cause a compilation error if anyone uses
8396 n rather than nn, a way that does not involve shadowing.
8397 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8399 * deps.mk (unexalpha.o): Remove; unused.
8401 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8402 * unexec.h: New file.
8403 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8404 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8406 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8407 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8408 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8409 Change as necessary to match prototype in unexec.h.
8411 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8413 (back_comment, skip_chars): Mark vars as initialized.
8415 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8416 Rename locals to avoid shadowing.
8418 * lread.c (read1): Rewrite so as not to use empty "else".
8419 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8421 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8423 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8424 warning when compiling print.c.
8426 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8427 instead of using an uninitialized var.
8428 (font_sort_entities): Mark var as initialized.
8430 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8432 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8433 pointers to constants.
8434 (font_parse_fcname): Remove unused vars.
8435 (font_delete_unmatched): Now static.
8436 (font_get_spec): Remove; unused.
8437 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8438 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8439 Rename or move locals to avoid shadowing.
8441 * fns.c (require_nesting_list, require_unwind): Now static.
8442 (Ffillarray): Rename locals to avoid shadowing.
8444 * floatfns.c (domain_error2): Define only if needed.
8445 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8447 * alloc.c (mark_backtrace): Move decl from here ...
8448 * lisp.h: ... to here, so that it can be checked.
8450 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8451 (Fdefvar): Rewrite so as not to use empty "else".
8452 (lisp_indirect_variable): Name an expression,
8453 to avoid gcc -Wbad-function-cast warning.
8454 (Fdefvar): Rename locals to avoid shadowing.
8456 * callint.c (quotify_arg, quotify_args): Now static.
8457 (Fcall_interactively): Rename locals to avoid shadowing.
8458 Use const pointer when appropriate.
8460 * lisp.h (get_system_name, get_operating_system_release):
8461 Move decls here, to check interfaces.
8462 * process.c (get_operating_system_release): Move decl to lisp.h.
8463 * xrdb.c (get_system_name): Likewise.
8464 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8465 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8466 some of which prompt warnings from gcc -Wbad-function-cast.
8467 (Fformat_time_string, Fencode_time, Finsert_char):
8468 (Ftranslate_region_internal, Fformat):
8469 Rename or remove local vars to avoid shadowing.
8470 (Ftranslate_region_internal): Mark var as initialized.
8472 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8475 * lisp.h (eassert): Check that the argument compiles, even if
8476 ENABLE_CHECKING is not defined.
8478 * data.c (Findirect_variable): Name an expression, to avoid
8479 gcc -Wbad-function-cast warning.
8480 (default_value, arithcompare, arith_driver, arith_error): Now static.
8481 (store_symval_forwarding): Rename local to avoid shadowing.
8482 (Fmake_variable_buffer_local, Fmake_local_variable):
8483 Mark variables as initialized.
8484 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8486 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8487 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8488 Rename locals to avoid shadowing.
8489 (mark_stack): Move local variables into the #ifdef region where
8491 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8492 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8494 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8495 (GC_STRING_CHARS): Remove; not used.
8496 (Fmemory_limit): Cast sbrk's returned value to char *.
8498 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8499 avoids undefined behavior in theory.
8501 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8503 Use functions, not macros, for up- and down-casing (Bug#8254).
8504 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8505 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8506 to use the following functions instead of these macros.
8507 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8508 EMACS_INT, since callers assume the returned value fits in int.
8509 (upcase1): Likewise, for UPCASE_TABLE.
8510 (uppercasep, lowercasep, upcase): New static inline functions.
8511 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8512 the race-condition problem in the old DOWNCASE.
8514 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8515 Rename locals to avoid shadowing.
8516 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8517 (regex_compile, re_search_2, re_match_2_internal):
8518 Remove unused local vars.
8519 (FREE_VAR): Rewrite so as not to use empty "else",
8520 which gcc can warn about.
8521 (regex_compile, re_match_2_internal): Mark locals as initialized.
8522 (RETALLOC_IF): Define only if needed.
8523 (WORDCHAR_P): Likewise. This one is never needed, but is used
8524 only in a comment talking about a compiler bug, so put inside
8525 the #if 0 of that comment.
8526 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8527 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8530 * search.c (boyer_moore): Rename locals to avoid shadowing.
8531 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8532 (PREV_CHAR_BOUNDARY): Likewise.
8534 * search.c (simple_search): Remove unused var.
8536 * dired.c (compile_pattern): Move decl from here ...
8537 * lisp.h: ... to here, so that it can be checked.
8538 (struct re_registers): New forward decl.
8540 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8542 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8544 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8545 Rename locals to avoid shadowing.
8546 (Fvertical_motion): Mark locals as initialized.
8548 * casefiddle.c (casify_object, casify_region): Now static.
8549 (casify_region): Mark local as initialized.
8551 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8553 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8554 New macros, so that the caller can use some names other than
8555 gcpro1, gcpro2, etc.
8556 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8558 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8559 argument, for consistency with GCPRO2_VAR, etc: it is now the
8560 prefix of the variable, not the variable itself. All uses
8562 * dired.c (directory_files_internal, file_name_completion):
8563 Rename locals to avoid shadowing.
8565 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8566 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8567 dired.c's scmp function, had undefined behavior.
8568 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8569 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8570 * buffer.h: ... to here, because these macros use current_buffer,
8571 and the new implementation with inline functions needs to have
8572 current_buffer in scope now, rather than later when the macros
8574 (downcase, upcase1): New static inline functions.
8575 (DOWNCASE, UPCASE1): Reimplement using these functions.
8576 This avoids undefined behavior in expressions like
8577 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8578 from race conditions in accessing the global variables
8579 case_temp1 and case_temp2.
8580 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8581 * lisp.h (case_temp1, case_temp2): Remove their decls.
8582 * character.h (ASCII_CHAR_P): Move from here ...
8583 * lisp.h: ... to here, so that the inline functions mentioned
8586 * dired.c (directory_files_internal_unwind): Now static.
8588 * fileio.c (file_name_as_directory, directory_file_name):
8589 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8591 (file_name_as_directory): Use const pointers when appropriate.
8592 (Fexpand_file_name): Likewise. In particular, newdir might
8593 point at constant storage, so make it a const pointer.
8594 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8595 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8597 (Fset_file_times, Finsert_file_contents, auto_save_error):
8598 Rename locals to avoid shadowing.
8600 * minibuf.c (choose_minibuf_frame_1): Now static.
8601 (Ftry_completion, Fall_completions): Rename or remove locals
8604 * marker.c (bytepos_to_charpos): Remove; unused.
8606 * lisp.h (verify_bytepos, count_markers): New decls,
8607 so that gcc does not warn that these functions aren't declared.
8609 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8610 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8611 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8612 (copy_text): Remove unused local var.
8614 * filelock.c (within_one_second): Now static.
8615 (lock_file_1): Rename local to avoid shadowing.
8617 * buffer.c (fix_overlays_before): Mark locals as initialized.
8618 (fix_start_end_in_overlays): Likewise. This function should be
8619 simplified by using pointers-to-pointers, but that's a different
8621 (switch_to_buffer_1): Now static.
8622 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8623 (report_overlay_modification): Rename locals to avoid shadowing.
8625 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8626 Fix pointer signedness issue.
8627 (sys_subshell): Mark local as volatile if checking for lint,
8628 to suppress a gcc -Wclobbered warning that does not seem to be right.
8629 (MAXPATHLEN): Define only if needed.
8631 * process.c (serial_open, serial_configure): Move decls from here ...
8632 * systty.h: ... to here, so that they can be checked.
8634 * fns.c (get_random, seed_random): Move extern decls from here ...
8635 * lisp.h: ... to here, so that they can be checked.
8637 * sysdep.c (reset_io): Now static.
8638 (wait_for_termination_signal): Remove; unused.
8640 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8641 (copy_keymap_item, append_key, push_text_char_description):
8643 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8644 (DENSE_TABLE_SIZE): Remove; unused.
8645 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8646 (describe_map_tree):
8647 Rename locals to avoid shadowing.
8649 * keyboard.c: Declare functions static if they are not used elsewhere.
8650 (echo_char, echo_dash, cmd_error, top_level_2):
8651 (poll_for_input, handle_async_input): Now static.
8652 (read_char, kbd_buffer_get_event, make_lispy_position):
8653 (make_lispy_event, make_lispy_movement, apply_modifiers):
8654 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8655 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8656 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8657 (read_key_sequence, read_char): Mark locals as initialized.
8658 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8660 * keyboard.h (make_ctrl_char): New decl.
8661 (mark_kboards): Move decl here ...
8662 * alloc.c (mark_kboards): ... from here.
8664 * lisp.h (force_auto_save_soon): New decl.
8666 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8667 (DEFINE_DUMMY_FUNCTION): New macro.
8668 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8670 (main): Add casts to avoid warnings
8671 if GCC considers string literals to be constants.
8673 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8675 * dbusbind.c: Pointer signedness fixes.
8676 (xd_signature, xd_append_arg, xd_initialize):
8677 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8678 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8679 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8680 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8682 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8683 if GCC considers string literals to be constants.
8684 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8686 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8688 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8689 (print_preprocess, print_object): New macro to fix last change.
8691 * print.c (print_preprocess): Don't forget font objects.
8693 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8695 * emacs.c (USAGE3): Doc fixes.
8697 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8699 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8702 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8704 * lisp.h (VWindow_system, Qfile_name_history):
8705 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8706 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8707 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8709 * w32select.c: Don't #include "keyboard.h".
8710 (run_protected): Add extern declaration for waiting_for_input.
8712 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8713 * w32console.c (detect_input_pending, read_input_pending)
8714 (encode_terminal_code):
8715 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8716 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8717 (w32_system_caret_y, Qfile_name_history):
8718 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8719 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8720 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8721 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8722 * w32proc.c (Qlocal, report_file_error):
8723 * w32term.c (Vwindow_system, updating_frame):
8724 * w32uniscribe.c (initialized, uniscribe_font_driver):
8725 Remove unneeded extern declarations.
8727 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8729 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8731 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8733 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8734 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8735 These macros can no longer be used for assignment.
8737 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8738 Assign struct members directly, instead of using BUF_BEGV etc.
8739 (record_buffer_markers, fetch_buffer_markers): New functions for
8740 recording and fetching special buffer markers.
8741 (set_buffer_internal_1, set_buffer_temp): Use them.
8743 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8745 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8747 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8748 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8750 * xdisp.c (hscroll_window_tree):
8751 (reconsider_clip_changes): Use PT instead of BUF_PT.
8753 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8755 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8756 $(EMACS_ROOT)/lib/intprops.h.
8758 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8760 Fix more problems found by GCC 4.5.2's static checks.
8762 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8763 to unsigned char * to avoid compiler diagnostic.
8764 (xg_free_frame_widgets): Make it clear that a local variable is
8765 needed only if USE_GTK_TOOLTIP.
8766 (gdk_window_get_screen): Make it clear that this macro is needed
8767 only if USE_GTK_TOOLTIP.
8768 (int_gtk_range_get_value): New function, which avoids a diagnostic
8769 from gcc -Wbad-function-cast.
8770 (xg_set_toolkit_scroll_bar_thumb): Use it.
8771 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8772 diagnostic from gcc -Wbad-function-cast.
8773 (get_utf8_string, xg_get_file_with_chooser):
8774 Rename locals to avoid shadowing.
8775 (create_dialog): Move locals to avoid shadowing.
8777 * xgselect.c (xg_select): Remove unused var.
8779 * image.c (four_corners_best): Mark locals as initialized.
8780 (gif_load): Initialize transparent_p to zero (Bug#8238).
8781 Mark another local as initialized.
8782 (my_png_error, my_error_exit): Mark with NO_RETURN.
8784 * image.c (clear_image_cache): Now static.
8785 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8786 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8787 (x_edge_detection): Remove unnecessary cast that
8788 gcc -Wbad-function-cast diagnoses.
8789 (gif_load): Fix pointer signedness.
8790 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8791 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8793 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8795 Improve quality of tests for time stamp overflow.
8796 For example, without this patch (encode-time 0 0 0 1 1
8797 1152921504606846976) returns the obviously-bogus value (-948597
8798 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8799 reports time overflow. See
8800 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8801 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8802 * editfns.c: Include limits.h and intprops.h.
8803 (TIME_T_MIN, TIME_T_MAX): New macros.
8804 (time_overflow): Move earlier, to before first use.
8805 (hi_time, lo_time): New functions, for an accurate test for
8807 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8808 (Fget_internal_run_time): Don't assume time_t fits in int.
8809 (make_time): Use list2 instead of Fcons twice.
8810 (Fdecode_time): More accurate test for out-of-range times.
8811 (check_tm_member): New function.
8812 (Fencode_time): Use it, to test for out-of-range times.
8813 (lisp_time_argument): Don't rely on undefined left-shift and
8814 right-shift behavior when checking for time stamp overflow.
8816 * editfns.c (time_overflow): New function, refactoring common code.
8817 (Fformat_time_string, Fdecode_time, Fencode_time):
8818 (Fcurrent_time_string): Use it.
8820 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8821 * dired.c (make_time): Move to ...
8822 * editfns.c (make_time): ... here.
8823 * systime.h: Note the move.
8825 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8827 * fringe.c (update_window_fringes): Remove unused variables.
8829 * unexmacosx.c (copy_data_segment): Also copy __got section.
8832 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8834 * termcap.c [MSDOS]: Include "msdos.h".
8835 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8836 Constify `char *' arguments and their references according to
8837 prototypes in tparam.h.
8839 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8841 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8842 Adapt all references accordingly.
8844 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8846 2011-03-11 Tom Tromey <tromey@redhat.com>
8848 * buffer.c (syms_of_buffer): Remove obsolete comment.
8850 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8852 * termhooks.h (encode_terminal_code): Declare prototype.
8854 * msdos.c (encode_terminal_code): Don't declare prototype.
8856 * term.c (encode_terminal_code): Now external again, used by
8857 w32console.c and msdos.c.
8859 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8860 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8862 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8864 Fix some minor problems found by GCC 4.5.2's static checks.
8866 * fringe.c (update_window_fringes): Mark locals as initialized
8868 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8870 * alloc.c (mark_fringe_data): Move decl from here ...
8871 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8872 to check its interface.
8873 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8875 * fontset.c (free_realized_fontset): Now static.
8876 (Fset_fontset_font): Rename local to avoid shadowing.
8877 (fontset_font): Mark local as initialized.
8878 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8880 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8882 * xselect.c (x_disown_buffer_selections): Remove; not used.
8883 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8884 (x_own_selection, Fx_disown_selection_internal): Rename locals
8886 (x_handle_dnd_message): Remove local to avoid shadowing.
8888 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8889 so that the caller can use some name other than gcpro1.
8890 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8891 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8892 (Fx_backspace_delete_keys_p):
8893 Use them to avoid shadowing, and rename vars to avoid shadowing.
8894 (x_decode_color, x_set_name, x_window): Now static.
8895 (Fx_create_frame): Add braces to silence GCC warning.
8896 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8897 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8898 Remove unused locals.
8899 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8900 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8901 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8904 * xterm.h (x_mouse_leave): New decl.
8906 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8907 Remove unused functions.
8908 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8909 (x_calc_absolute_position): Now static.
8910 (XTread_socket): Don't define label "out" unless it's used.
8911 Don't declare local "event" unless it's used.
8912 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8913 unless they are used.
8914 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8915 (x_fatal_error_signal): Remove; not used.
8916 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8917 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8918 (x_error_catcher, x_connection_closed, x_error_handler):
8919 (x_error_quitter, xembed_send_message, x_iconify_frame):
8920 (my_log_handler): Rename locals to avoid shadowing.
8921 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8922 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8924 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8925 Rename or move locals to avoid shadowing.
8926 (tty_defined_color, merge_face_heights): Now static.
8927 (free_realized_faces_for_fontset): Remove; not used.
8928 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8929 does not deduce is never used uninitialized.
8930 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8931 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8933 * terminal.c (store_terminal_param): Now static.
8935 * xmenu.c (menu_highlight_callback): Now static.
8936 (set_frame_menubar): Remove unused local.
8937 (xmenu_show): Rename parameter to avoid shadowing.
8938 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8939 since they might point to immutable storage.
8940 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8941 since it's unused otherwise.
8943 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8944 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8945 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8946 avoids a gcc -Wuninitialized diagnostic.
8947 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8948 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8949 does not deduce are never used uninitialized.
8951 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8953 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8954 * window.c (window_loop, size_window):
8955 (run_window_configuration_change_hook, enlarge_window): Likewise.
8957 * window.c (display_buffer): Now static.
8958 (size_window): Mark variables that gcc -Wuninitialized
8959 does not deduce are never used uninitialized.
8960 * window.h (check_all_windows): New decl, to forestall
8961 gcc -Wmissing-prototypes diagnostic.
8962 * dispextern.h (bidi_dump_cached_states): Likewise.
8964 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8966 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8968 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8969 and to avoid gcc -Wuninitialized warning.
8970 (load_charset_map): Mark variables that gcc -Wuninitialized
8971 does not deduce are never used uninitialized.
8972 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8974 * coding.c (coding_set_source, coding_set_destination):
8975 Use "else { /* comment */ }" rather than "else /* comment */;"
8976 for clarity, and to avoid gcc -Wempty-body warning.
8977 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8978 a block, when the outer 'i' will do.
8979 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8980 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8982 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8983 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8984 Rename locals to avoid shadowing.
8985 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8986 * coding.c (emacs_mule_char, encode_invocation_designation):
8987 Now static, since they're not used elsewhere.
8988 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8989 (decode_coding_object, encode_coding_object, detect_coding_system):
8990 (decode_coding_emacs_mule): Mark variables that gcc
8991 -Wuninitialized does not deduce are never used uninitialized.
8992 (detect_coding_iso_2022): Initialize a local variable that might
8993 be used uninitialized. Leave a FIXME because it's not clear that
8994 this initialization is needed. (Bug#8211)
8995 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8996 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8997 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8998 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8999 Remove unused macros.
9001 * category.c (hash_get_category_set): Remove unused local var.
9002 (copy_category_table): Now static, since it's not used elsewhere.
9003 * character.c (string_count_byte8): Likewise.
9005 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9006 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9008 * chartab.c (copy_sub_char_table): Now static, since it's not used
9010 (sub_char_table_ref_and_range, char_table_ref_and_range):
9011 Rename locals to avoid shadowing.
9012 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9014 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9015 (BIDI_BOB): Remove unused macro.
9017 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9018 deduce are never used uninitialized.
9019 * term.c (encode_terminal_code): Likewise.
9021 * term.c (encode_terminal_code): Now static. Remove unused local.
9023 * tparam.h: New file.
9024 * term.c, tparam.h: Include it.
9025 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9026 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9027 Move these decls to tparam.h, and make them agree with what
9028 is actually in tparam.c. The previous trick of using incompatible
9029 decls in different modules does not conform to the C standard.
9030 All callers of tparam changed to use tparam's actual API.
9031 * tparam.c (tparam1, tparam, tgoto):
9032 Use const pointers where appropriate.
9034 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9035 * cm.h (struct cm): Likewise.
9036 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9037 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9038 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9039 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9040 (turn_on_face, init_tty): Likewise.
9041 * termchar.h (struct tty_display_info): Likewise.
9043 * term.c (term_mouse_position): Rename local to avoid shadowing.
9045 * alloc.c (mark_ttys): Move decl from here ...
9046 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9048 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9050 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9052 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9054 * search.c (compile_pattern_1): Remove argument regp, unused since
9055 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9056 (compile_pattern): Don't pass it.
9058 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9060 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9061 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9063 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9065 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9067 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9068 gdk_window_get_screen, gdk_window_get_geometry,
9069 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9070 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9071 (xg_get_pixbuf_from_pixmap): New function.
9072 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9073 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9074 Call xg_get_pixbuf_from_pixmap instead of
9075 gdk_pixbuf_get_from_drawable.
9076 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9077 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9078 (xg_check_special_colors): Use GtkStyleContext and its functions
9080 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9081 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9082 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9083 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9084 Call gtk_widget_get_preferred_size.
9085 (xg_frame_resized): gdk_window_get_geometry only takes 5
9087 (xg_win_to_widget, xg_event_is_for_menubar):
9088 Call gdk_x11_window_lookup_for_display.
9089 (xg_set_widget_bg): New function.
9090 (delete_cb): New function.
9091 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9092 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9093 (xg_set_background_color): Call xg_set_widget_bg.
9094 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9095 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9096 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9097 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9099 (update_frame_tool_bar): Call gtk_widget_hide.
9100 (xg_initialize): Use GDK_KEY_g.
9102 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9104 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9106 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9107 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9108 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9110 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9112 * w32xfns.c (select_palette): Check success of RealizePalette against
9113 GDI_ERROR, not zero.
9115 See ChangeLog.11 for earlier changes.
9121 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9123 This file is part of GNU Emacs.
9125 GNU Emacs is free software: you can redistribute it and/or modify
9126 it under the terms of the GNU General Public License as published by
9127 the Free Software Foundation, either version 3 of the License, or
9128 (at your option) any later version.
9130 GNU Emacs is distributed in the hope that it will be useful,
9131 but WITHOUT ANY WARRANTY; without even the implied warranty of
9132 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9133 GNU General Public License for more details.
9135 You should have received a copy of the GNU General Public License
9136 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.