1 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3 * ftxfont.c: Make symbols static if they're not exported.
4 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6 * font.h (ftxfont_driver): Likewise.
8 * xfns.c: Make symbols static if they're not exported.
9 (x_last_font_name, x_display_info_for_name):
10 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15 (last_show_tip_args): Now static.
16 (xic_defaut_fontset, xic_create_fontsetname): Define only if
17 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
18 (x_screen_planes): Remove; unused.
19 * dispextern.h (x_screen_planes): Remove decl.
21 * dispnew.c: Make symbols static if they're not exported.
22 * dispextern.h (redraw_garbaged_frames, scrolling):
23 (increment_row_positions): Remove.
24 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
25 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
27 (redraw_garbaged_frames): Remove; unused.
29 * xfaces.c: Make symbols static if they're not exported.
30 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
32 * xterm.h (defined_color): Remove decls.
33 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
34 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
35 (menu_face_changed_default, defined_color, free_realized_face):
36 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
37 (ascii_face_of_lisp_face): Remove; unused.
39 * xdisp.c: Make symbols static if they're not exported.
40 * dispextern.h (scratch_glyph_row, window_box_edges):
41 (glyph_to_pixel_coords, set_cursor_from_row):
42 (get_next_display_element, set_iterator_to_next):
43 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
44 (show_mouse_face): Remove decls
45 * frame.h (message_buf_print): Likewise.
46 * lisp.h (pop_message, set_message, check_point_in_composition):
48 * xterm.h (set_vertical_scroll_bar): Likewise.
49 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
50 (message_buf_print, scratch_glyph_row, displayed_buffer):
51 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
52 (get_next_display_element, show_mouse_face, window_box_edges):
53 (frame_to_window_pixel_xy, check_point_in_composition):
54 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
55 (glyph_to_pixel_coords): Remove; unused.
57 * dired.c (file_name_completion): Now static.
59 * dbusbind.c (xd_in_read_queued_messages): Now static.
61 * lisp.h (circular_list_error, FOREACH): Remove; unused.
62 * data.c (circular_list_error): Remove.
64 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
66 * commands.h (last_point_position, last_point_position_buffer):
67 (last_point_position_window): Remove decls.
68 * keyboard.c: Make these variables static.
70 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
72 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
73 (iso_code_class, detect_coding, code_convert_region): Now static.
74 (encode_coding_gap): Remove; unused.
76 * chartab.c (chartab_chars, chartab_bits): Now static.
78 * charset.h (charset_iso_8859_1): Remove decl.
79 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
82 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
83 * ccl.c (Vccl_program_table): Now static.
84 (check_ccl_update): Remove; unused.
86 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
87 * category.h: ... from here.
88 * category.c (check_category_table, set_category_set): Now static.
90 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
91 * lisp.h: Remove these decls.
93 * buffer.c (buffer_count): Remove unused var.
95 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
96 so that it's not optimized away.
97 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
98 * dispextern.h (bidi_dump_cached_states): Remove, since it's
99 exported only to the debugger.
101 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
102 * atimer.h (run_all_atimers): Removed; not exported.
104 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
105 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
106 was inaccessible from Lisp.
107 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
108 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
110 alloc.c: Import and export fewer symbols, and remove unused items.
111 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
113 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
114 it's not optimized away by whole-program optimization.
115 (message_enable_multibyte, free_misc): Remove.
116 (catchlist, handlerlist, mark_backtrace):
117 Declare only if BYTE_MARK_STACK.
118 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
119 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
120 (message_enable_multibyte): Remove decl.
121 (free_misc, interval_free_list, float_block, float_block_index):
122 (n_float_blocks, float_free_list, cons_block, cons_block_index):
123 (cons_free_list, last_marked_index):
125 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
126 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
127 (mark_backtrace): Define only if BYTE_MARK_STACK.
128 * xdisp.c (message_enable_multibyte): Now static.
130 Declare Lisp_Object Q* variables to be 'static' if not exproted.
131 This makes it easier for human readers (and static analyzers)
132 to see whether these variables are used from other modules.
133 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
134 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
135 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
136 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
137 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
138 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
139 * xmenu.c, xselect.c:
140 Declare Q* vars static if they are not used in other modules.
141 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
142 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
143 Remove decls of unexported vars.
144 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
146 * lisp.h (DEFINE_FUNC): Make sname 'static'.
148 Make Emacs functions such as Fatom 'static' by default.
149 This makes it easier for human readers (and static analyzers)
150 to see whether these functions can be called from other modules.
151 DEFUN now defines a static function. To make the function external
152 so that it can be used in other C modules, use the new macro DEFUE.
153 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
154 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
155 static function definition. Use DEFUE if you want an extern one.
156 (DEFUE, INFUN): New macros.
157 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
158 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
159 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
160 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
161 Remove decls, since these functions are now static.
162 (Funintern, Fget_internal_run_time): New decls, since these functions
163 were already external.
165 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
166 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
167 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
168 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
169 * keyboard.c, keymap.c, lread.c:
170 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
171 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
172 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
173 Mark functions with DEFUE instead of DEFUN,
174 if they are used in other modules.
175 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
176 decls for now-static functions.
177 * buffer.h (Fdelete_overlay): Remove decl.
178 * callproc.c (Fgetenv_internal): Mark as internal.
179 * composite.c (Fremove_list_of_text_properties): Remove decl.
180 (Fcomposition_get_gstring): New forward static decl.
181 * composite.h (Fcomposite_get_gstring): Remove decl.
182 * dired.c (Ffile_attributes): New forward static decl.
183 * doc.c (Fdocumntation_property): New forward static decl.
184 * eval.c (Ffetch_bytecode): New forward static decl.
185 (Funintern): Remove extern decl; now in .h file where it belongs.
186 * fileio.c (Fmake_symbolic_link): New forward static decl.
187 * image.c (Finit_image_library): New forward static decl.
188 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
189 * intervals.h (Fprevious_property_change):
190 (Fremove_list_of_text_properties): Remove decls.
191 * keyboard.c (Fthis_command_keys): Remove decl.
192 (Fcommand_execute): New forward static decl.
193 * keymap.c (Flookup_key): New forward static decl.
194 (Fcopy_keymap): Now static.
195 * keymap.h (Flookup_key): Remove decl.
196 * process.c (Fget_process): New forward static decl.
197 (Fprocess_datagram_address): Mark as internal.
198 * syntax.c (Fsyntax_table_p): New forward static decl.
199 (skip_chars): Remove duplicate decl.
200 * textprop.c (Fprevious_property_change): New forward static decl.
201 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
203 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
204 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
206 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
208 * editfns.c (Fformat): Remove unreachable code.
210 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
212 Fix more problems found by GCC 4.6.0's static checks.
214 * xdisp.c (vmessage): Use a better test for character truncation.
216 * charset.c (load_charset_map): <, not <=, for optimization,
217 and to avoid potential problems with integer overflow.
218 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
219 * casetab.c (set_identity, shuffle): Likewise.
220 * editfns.c (Fformat): Likewise.
221 * syntax.c (skip_chars): Likewise.
223 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
224 This also lets GCC 4.6.0 generate slightly better loop code.
226 * callint.c (Fcall_interactively): <, not <=, for optimization.
227 (Fcall_interactively): Count the number of arguments produced,
228 not the number of arguments given. This is simpler and lets GCC
229 4.6.0 generate slightly better code.
231 * ftfont.c: Distingish more carefully between FcChar8 and char.
232 The previous code passed unsigned char * to a functions like
233 strlen and xstrcasecmp that expect char *, which does not
234 conform to the C standard.
235 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
236 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
237 char * when the C standard requires it.
239 * keyboard.c (read_char): Remove unused var.
241 * eval.c: Port to Windows vsnprintf (Bug#8435).
243 (SIZE_MAX): Define if the headers do not.
244 (verror): Do not give up if vsnprintf returns a negative count.
245 Instead, grow the buffer. This ports to Windows vsnprintf, which
246 does not conform to C99. Problem reported by Eli Zaretskii.
247 Also, simplify the allocation scheme, by avoiding the need for
248 calling realloc, and removing the ALLOCATED variable.
250 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
252 Remove invocations of doprnt, as Emacs now uses vsnprintf.
253 But keep the doprint source code for now, as we might revamp it
254 and use it again (Bug#8435).
255 * lisp.h (doprnt): Remove.
256 * Makefile.in (base_obj): Remove doprnt.o.
257 * deps.mk (doprnt.o): Remove.
259 error: Print 32- and 64-bit integers portably (Bug#8435).
260 Without this change, on typical 64-bit hosts error ("...%d...", N)
261 was used to print both 32- and 64-bit integers N, which relied on
263 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
265 * lisp.h (error, verror): Mark as printf-like functions.
266 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
267 Report overflow in size calculations when allocating printf buffer.
268 Do not truncate output string at its first null byte.
269 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
270 Truncate the output at a character boundary, since vsnprintf does not
272 * charset.c (check_iso_charset_parameter): Convert internal
273 character to string before calling 'error', since %c now has the
275 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
276 overflow when computing char to be passed to 'error'. Do not
277 pass Lisp_Object to 'error'; pass the integer instead.
278 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
279 formatted with plain %d.
281 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
283 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
285 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
287 * xterm.c (x_catch_errors): Remove duplicate declaration.
289 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
291 * xdisp.c, lisp.h (message_nolog): Remove; unused.
293 2011-04-10 Jim Meyering <meyering@redhat.com>
295 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
296 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
297 return ssize_t not "int", and use size_t as the buffer length.
298 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
299 * gnutls.h: Update declarations.
300 * process.c (read_process_output): Use ssize_t, to match.
301 (send_process): Likewise.
303 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
305 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
307 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
309 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
310 unsigned char, to match FcChar8 type definition.
312 * xterm.c (handle_one_xevent):
313 * xmenu.c (create_and_show_popup_menu):
314 * xselect.c (x_decline_selection_request)
315 (x_reply_selection_request): Avoid type-punned deref of X events.
317 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
319 Fix some uses of `int' instead of EMACS_INT.
320 * search.c (string_match_1, fast_string_match)
321 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
322 (scan_buffer, find_next_newline_no_quit)
323 (find_before_next_newline, search_command, Freplace_match)
324 (Fmatch_data): Make some `int' variables be EMACS_INT.
326 * xdisp.c (display_count_lines): 3rd argument and return value now
327 EMACS_INT. All callers changed.
328 (pint2hrstr): Last argument is now EMACS_INT.
330 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
331 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
332 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
333 (decode_coding_utf_16, decode_coding_emacs_mule)
334 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
335 (decode_coding_ccl, decode_coding_charset)
336 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
337 (decode_coding_iso_2022, decode_coding_emacs_mule)
338 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
339 <char_offset, last_offset>: Declare EMACS_INT.
340 (encode_coding_utf_8, encode_coding_utf_16)
341 (encode_coding_emacs_mule, encode_invocation_designation)
342 (encode_designation_at_bol, encode_coding_iso_2022)
343 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
344 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
346 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
347 (encode_invocation_designation): Last argument P_NCHARS is now
349 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
350 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
352 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
355 * ccl.c (Fccl_execute_on_string): Declare some variables
358 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
360 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
362 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
364 * process.c (Fformat_network_address): Doc fix.
366 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
368 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
370 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
372 * keyboard.c (read_char): Call Lisp function help-form-show,
373 instead of using internal_with_output_to_temp_buffer.
374 (Qhelp_form_show): New var.
375 (syms_of_keyboard): Use DEFSYM macro.
377 * print.c (internal_with_output_to_temp_buffer): Function deleted.
379 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
381 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
383 * process.c (Flist_processes): Removed to Lisp.
384 (list_processes_1): Deleted.
386 2011-04-06 Eli Zaretskii <eliz@gnu.org>
388 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
390 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
392 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
394 Fix more problems found by GCC 4.6.0's static checks.
396 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
398 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
400 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
402 * xdisp.c (vmessage): Mark as a printf-like function.
404 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
406 * sound.c (sound_warning): Don't crash if arg contains a printf format.
408 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
409 printf-like functions.
410 (tiff_load): Add casts to remove these marks before passing them
411 to system-supplied API.
413 * eval.c (Fsignal): Remove excess argument to 'fatal'.
415 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
416 This avoids several warnings with gcc -Wstrict-overflow.
417 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
418 directly, rather than having caller test rule sign. This avoids
419 some unnecessary tests.
420 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
421 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
422 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
424 * xfont.c (xfont_text_extents): Remove var that was set but not used.
425 (xfont_open): Avoid unnecessary tests.
427 * composite.c (composition_gstring_put_cache): Use unsigned integer.
429 * composite.h, composite.c (composition_gstring_put_cache):
430 Use EMACS_INT, not int, for length.
432 * composite.h (COMPOSITION_DECODE_REFS): New macro,
433 breaking out part of COMPOSITION_DECODE_RULE.
434 (COMPOSITION_DECODE_RULE): Use it.
435 * composite.c (get_composition_id): Remove unused local vars,
436 by using the new macro.
438 * textprop.c (set_text_properties_1): Change while to do-while,
439 since the condition is always true at first.
441 * intervals.c (graft_intervals_into_buffer): Mark var as used.
442 (interval_deletion_adjustment): Return unsigned value.
445 * process.c (list_processes_1, create_pty, read_process_output):
446 (exec_sentinel): Remove vars that were set but not used.
447 (create_pty): Remove unnecessary "volatile"s.
448 (Fnetwork_interface_info): Avoid possibility of int overflow.
449 (read_process_output): Do adaptive read buffering even if carryover.
450 (read_process_output): Simplify nbytes computation if buffered.
452 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
454 * syntax.c (scan_words): Remove var that was set but not used.
455 (update_syntax_table): Use unsigned instead of int.
457 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
458 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
459 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
461 * print.c (print_error_message): Avoid int overflow.
463 * font.c (font_list_entities): Redo for clarity,
464 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
466 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
467 (font_score): Avoid potential overflow in diff calculation.
469 * fns.c (substring_both): Remove var that is set but not used.
470 (sxhash): Redo loop for clarity and to avoid wraparound warning.
472 * eval.c (funcall_lambda): Rename local to avoid shadowing.
474 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
475 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
476 can always succeed if overflow has undefined behavior.
478 * search.c (boyer_moore, wordify): Remove vars set but not used.
479 (wordify): Omit three unnecessary tests.
481 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
482 All callers changed. This avoids the need for an unused var.
484 * casefiddle.c (casify_region): Remove var that is set but not used.
486 * dired.c (file_name_completion): Remove var that is set but not used.
488 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
490 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
491 (Finsert_file_contents): Remove unnecessary code checking fd.
493 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
494 Check for integer overflow on size calculations.
496 * buffer.c (Fprevious_overlay_change): Remove var that is set
499 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
500 Remove vars that are set but not used.
501 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
502 (timer_check_2): Mark vars as initialized.
504 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
506 * image.c (lookup_image): Remove var that is set but not used.
507 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
509 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
510 that are set but not used.
512 * xfns.c (make_invisible_cursor): Don't return garbage
513 if XCreateBitmapFromData fails (Bug#8410).
515 * xselect.c (x_get_local_selection, x_handle_property_notify):
516 Remove vars that are set but not used.
518 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
519 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
521 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
522 Remove var that is set but not used.
523 (scroll_bar_windows_size): Now size_t, not int.
524 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
527 * xfaces.c (realize_named_face): Remove vars that are set but not used.
528 (map_tty_color) [!defined MSDOS]: Likewise.
530 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
532 * coding.c: Remove vars that are set but not used.
533 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
535 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
536 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
537 (decode_coding_charset): Remove vars that are set but not used.
539 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
540 that is set but not used.
542 * print.c (print_object): Remove var that is set but not used.
544 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
545 The gnulib version avoids calling malloc in the usual case,
546 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
547 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
548 * filelock.c (current_lock_owner): Likewise.
549 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
550 * sysdep.c: Include allocator.h, careadlinkat.h.
551 (emacs_no_realloc_allocator): New static constant.
552 (emacs_readlink): New function.
553 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
554 ../lib/careadlinkat.h.
556 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
558 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
559 first non-nil return value).
561 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
563 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
564 if not defined (Bug#8403).
566 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
568 * xdisp.c (display_count_lines): Remove parameter `start',
569 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
570 (get_char_face_and_encoding): Remove parameter `multibyte_p',
571 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
572 (fill_stretch_glyph_string): Remove parameters `row' and `area',
573 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
574 and thereabouts. All callers changed.
575 (get_per_char_metric): Remove parameter `f', unused since
576 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
578 2011-04-02 Jim Meyering <meyering@redhat.com>
580 do not dereference NULL upon failed strdup
581 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
582 (ns_get_family): Likewise.
584 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
586 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
588 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
590 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
593 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
597 * window.c (Ftemp_output_buffer_show): New fun.
598 (Fsave_window_excursion):
599 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
601 * lread.c (lisp_file_lexically_bound_p): New function.
602 (Fload): Bind Qlexical_binding.
603 (readevalloop): Remove `evalfun' arg.
604 Bind Qinternal_interpreter_environment.
605 (Feval_buffer): Bind Qlexical_binding.
606 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
608 (syms_of_lread): Declare `lexical-binding'.
610 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
612 * keyboard.c (eval_dyn): New fun.
613 (menu_item_eval_property): Use it.
615 * image.c (parse_image_spec): Use Ffunctionp.
617 * fns.c (concat, mapcar1): Accept byte-code-functions.
619 * eval.c (Fsetq): Handle lexical vars.
620 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
621 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
622 (FletX, Flet): Obey lexical binding.
623 (Fcommandp): Handle closures.
624 (Feval): New `lexical' arg.
625 (eval_sub): New function extracted from Feval. Use it almost
626 everywhere where Feval was used. Look up vars in lexical env.
628 (Ffunctionp): Move from subr.el.
629 (Ffuncall): Handle closures.
630 (apply_lambda): Remove `eval_flags'.
631 (funcall_lambda): Handle closures and new byte-code-functions.
632 (Fspecial_variable_p): New function.
633 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
634 but without exporting it to Lisp.
636 * doc.c (Fdocumentation, store_function_docstring):
637 * data.c (Finteractive_form): Handle closures.
639 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
642 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
644 (exec_byte_code): New function extracted from Fbyte_code to handle new
645 calling convention for byte-code-functions. Add new byte-codes.
647 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
649 * alloc.c (Fmake_symbol): Init new `declared_special' field.
651 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
653 * xdisp.c (redisplay_internal): Fix prototype.
655 2011-03-31 Eli Zaretskii <eliz@gnu.org>
657 * xdisp.c (SCROLL_LIMIT): New macro.
658 (try_scrolling): Use it when setting scroll_limit. Limit
659 scrolling to 100 screen lines.
660 (redisplay_window): Even when falling back on "recentering",
661 position point in the window according to scroll-conservatively,
662 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
664 (try_scrolling): When point is above the window, allow searching
665 as far as scroll_max, or one screenful, to compute vertical
666 distance from PT to the scroll margin position. This prevents
667 try_scrolling from unnecessarily failing when
668 scroll-conservatively is set to a value slightly larger than the
669 window height. Clean up the case of PT below the margin at bottom
670 of window: scroll_max can no longer be INT_MAX. When aggressive
671 scrolling is in use, don't let point enter the opposite scroll
672 margin as result of the scroll.
673 (syms_of_xdisp) <scroll-conservatively>: Document the
674 threshold of 100 lines for never-recentering scrolling.
676 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
678 * dispextern.h (move_it_by_lines):
679 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
680 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
681 (message_log_check_duplicate): Remove parameters `prev_bol' and
682 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
683 (redisplay_internal): Remove parameter `preserve_echo_area',
684 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
686 * indent.c (Fvertical_motion):
687 * window.c (window_scroll_pixel_based, Frecenter):
688 Don't pass `need_y_p' to `move_it_by_lines'.
690 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
692 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
693 steal a few bits to be more compact.
694 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
695 Remove unneeded casts.
697 * bytecode.c (Fbyte_code): CAR and CDR can GC.
699 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
701 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
702 binding" message (bug#7967).
704 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
706 Fix more problems found by GCC 4.6.0's static checks.
708 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
709 Remove unused local var.
711 * editfns.c (Fmessage_box): Remove unused local var.
713 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
714 (note_mode_line_or_margin_highlight, note_mouse_highlight):
715 Omit unused local vars.
716 * window.c (shrink_windows): Omit unused local var.
717 * menu.c (digest_single_submenu): Omit unused local var.
718 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
719 Omit unused local var.
721 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
722 Don't assume string length fits in int.
723 (keyremap_step, read_key_sequence): Use size_t for sizes.
724 (read_key_sequence): Don't check last_real_key_start redundantly.
726 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
727 instead of alloca (Bug#8344).
729 * eval.c (Fbacktrace): Don't assume nargs fits in int.
730 (Fbacktrace_frame): Don't assume nframes fits in int.
732 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
734 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
737 * term.c (produce_glyphless_glyph): Remove unnecessary test.
739 * cm.c (calccost): Turn while-do into do-while, for clarity.
741 * keyboard.c (syms_of_keyboard): Use the same style as later
742 in this function when indexing through an array. This also
743 works around GCC bug 48267.
745 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
747 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
749 * chartab.c (sub_char_table_ref_and_range): Redo for slight
750 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
752 * keyboard.c, keyboard.h (num_input_events): Now size_t.
753 This avoids undefined behavior on integer overflow, and is a bit
754 more convenient anyway since it is compared to a size_t variable.
756 Variadic C functions now count arguments with size_t, not int.
757 This avoids an unnecessary limitation on 64-bit machines, which
758 caused (substring ...) to crash on large vectors (Bug#8344).
759 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
760 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
761 All variadic functions and their callers changed accordingly.
762 (struct gcpro.nvars): Now size_t, not int. All uses changed.
763 * data.c (arith_driver, float_arith_driver): Likewise.
764 * editfns.c (general_insert_function): Likewise.
765 * eval.c (struct backtrace.nargs, interactive_p)
766 (internal_condition_case_n, run_hook_with_args, apply_lambda)
767 (funcall_lambda, mark_backtrace): Likewise.
768 * fns.c (concat): Likewise.
769 * frame.c (x_set_frame_parameters): Likewise.
770 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
771 0 if not found, not -1. All callers changed.
773 * alloc.c (garbage_collect): Don't assume stack size fits in int.
774 (stack_copy_size): Now size_t, not int.
775 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
777 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
779 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
780 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
783 * lisp.h (multibyte_char_to_unibyte):
784 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
785 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
786 * character.h (CHAR_TO_BYTE8):
787 * cmds.c (internal_self_insert):
788 * editfns.c (general_insert_function):
789 * keymap.c (push_key_description):
790 * search.c (Freplace_match):
791 * xdisp.c (message_dolog, set_message_1): All callers changed.
793 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
795 * keyboard.c (safe_run_hook_funcall): New function.
796 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
797 don't set the hook to nil, but remove the offending function instead.
798 (Qcommand_hook_internal): Remove, unused.
799 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
800 Vcommand_hook_internal.
802 * eval.c (enum run_hooks_condition): Remove.
803 (funcall_nil, funcall_not): New functions.
804 (run_hook_with_args): Call each function through a `funcall' argument.
805 Remove `cond' argument, now redundant.
806 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
807 (Frun_hook_with_args_until_failure): Adjust accordingly.
808 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
810 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
812 * dispextern.h (string_buffer_position): Remove declaration.
814 * print.c (strout): Remove parameter `multibyte', unused since
815 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
817 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
818 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
821 * w32.c (_wsa_errlist): Use braces for struct initializers.
823 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
824 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
826 (string_buffer_position): Likewise. Also, make static (it's never
827 used outside xdisp.c).
828 (cursor_row_p): Remove parameter `w', unused since
829 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
830 (decode_mode_spec): Remove parameter `precision', introduced during
831 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
834 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
836 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
838 2011-03-27 Anders Lindgren <andlind@gmail.com>
840 * nsterm.m (ns_menu_bar_is_hidden): New variable.
841 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
842 (ns_update_auto_hide_menu_bar): New functions.
843 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
844 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
845 ns_constrain_all_frames.
846 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
847 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
849 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
851 * nsmenu.m (runDialogAt): Remove argument to timer_check.
853 2011-03-27 Glenn Morris <rgm@gnu.org>
855 * syssignal.h: Replace RETSIGTYPE with void.
856 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
857 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
858 Replace SIGTYPE with void everywhere.
859 * s/usg5-4-common.h (SIGTYPE): Remove definition.
860 * s/template.h (SIGTYPE): Remove commented out definition.
862 2011-03-26 Eli Zaretskii <eliz@gnu.org>
864 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
865 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
867 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
869 * w32.c (read_unc_volume): Use parameter `henum', instead of
870 global variable `wget_enum_handle'.
872 * keymap.c (describe_vector): Remove parameters `indices' and
873 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
874 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
876 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
878 * keyboard.c (timer_check): Remove parameter `do_it_now',
879 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
880 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
881 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
883 * keyboard.c (read_char):
884 * w32menu.c (w32_menu_display_help):
885 * xmenu.c (show_help_event, menu_help_callback):
886 Adjust calls to `show_help_echo'.
888 * gtkutil.c (xg_maybe_add_timer):
889 * keyboard.c (readable_events):
890 * process.c (wait_reading_process_output):
891 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
893 * insdel.c (adjust_markers_gap_motion):
894 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
895 (gap_left, gap_right): Don't call it.
897 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
899 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
900 incurred during fontification.
902 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
904 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
905 (DEFVAR_PER_BUFFER): Don't pass it.
907 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
908 (scrolling_window): Don't pass it.
910 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
912 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
914 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
916 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
917 of variables specific to SELinux and computation of `encoded_absname'.
919 * image.c (XPutPixel): Remove unused variable `height'.
921 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
923 * unexw32.c (get_section_info): Remove unused variable `section'.
925 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
926 (system_process_attributes): Remove unused variable `sess'.
927 (sys_read): Remove unused variable `err'.
929 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
930 (w32_wnd_proc): Remove unused variable `isdead'.
931 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
932 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
933 (x_create_tip_frame): Remove unused variable `tem'.
935 * w32inevt.c (w32_console_read_socket):
936 Remove unused variable `no_events'.
938 * w32term.c (x_draw_composite_glyph_string_foreground):
939 Remove unused variable `width'.
941 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
943 * w32term.c (x_set_glyph_string_clipping):
944 Don't pass uninitialized region to CombineRgn.
946 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
948 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
949 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
950 (Fx_close_connection): Remove unused variable `i'.
952 * w32font.c (w32font_draw): Return number of glyphs.
953 (w32font_open_internal): Remove unused variable `i'.
954 (w32font_driver): Add missing initializer.
956 * w32menu.c (utf8to16): Remove unused variable `utf16'.
957 (fill_in_menu): Remove unused variable `items_added'.
959 * w32term.c (last_mouse_press_frame): Remove static global variable.
960 (w32_clip_to_row): Remove unused variable `f'.
961 (x_delete_terminal): Remove unused variable `i'.
963 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
964 (NOTHING): Remove unused static global variable.
965 (uniscribe_check_otf): Remove unused variable `table'.
966 (uniscribe_font_driver): Add missing initializers.
968 2011-03-23 Julien Danjou <julien@danjou.info>
970 * term.c (Fsuspend_tty, Fresume_tty):
971 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
972 * window.c (temp_output_buffer_show):
973 * insdel.c (signal_before_change):
974 * frame.c (Fhandle_switch_frame):
975 * fileio.c (Fdo_auto_save):
976 * emacs.c (Fkill_emacs):
977 * editfns.c (save_excursion_restore):
978 * cmds.c (internal_self_insert):
979 * callint.c (Fcall_interactively):
980 * buffer.c (Fkill_all_local_variables):
981 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
983 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
984 unconditionnaly since it does the check itself.
986 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
988 Fix more problems found by GCC 4.5.2's static checks.
990 * coding.c (encode_coding_raw_text): Avoid unnecessary test
991 the first time through the loop, since we know p0 < p1 then.
992 This also avoids a gcc -Wstrict-overflow warning.
994 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
995 leading to a memory leak, possible in functions like
996 load_charset_map_from_file that can allocate an unbounded number
997 of objects (Bug#8318).
999 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1000 that could (at least in theory) be that large.
1002 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1003 This is less likely to overflow, and avoids undefined behavior if
1004 overflow does occur. All callers changed. Use strtoul to scan
1005 for the unsigned long integer.
1006 (pint2hrstr): Simplify and tune code slightly.
1007 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1009 * scroll.c (do_scrolling): Work around GCC bug 48228.
1010 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1012 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1013 This also avoids a warning with gcc -Wstrict-overflow.
1014 (validate_x_resource_name): Simplify count usage.
1015 This also avoids a warning with gcc -Wstrict-overflow.
1017 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1020 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1022 * process.c (Fmake_network_process): Use socklen_t, not int,
1023 where POSIX says socklen_t is required in portable programs.
1024 This fixes a porting bug on hosts like 64-bit HP-UX, where
1025 socklen_t is wider than int (Bug#8277).
1026 (Fmake_network_process, server_accept_connection):
1027 (wait_reading_process_output, read_process_output):
1030 * process.c: Rename or move locals to avoid shadowing.
1031 (list_processes_1, Fmake_network_process):
1032 (read_process_output_error_handler, exec_sentinel_error_handler):
1033 Rename or move locals.
1034 (Fmake_network_process): Define label "retry_connect" only if needed.
1035 (Fnetwork_interface_info): Fix pointer signedness.
1036 (process_send_signal): Add cast to avoid pointer signedness problem.
1037 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1038 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1040 Make tparam.h and terminfo.c consistent.
1041 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1042 Include tparam.h instead, since it declares them.
1043 * cm.h (PC): Remove extern decl; tparam.h now does this.
1044 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1045 * terminfo.c: Include tparam.h, to check interfaces.
1046 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1047 (tparam): Adjust signature to match interface in tparam.h;
1048 this removes some undefined behavior. Check that outstring and len
1049 are zero, which they always are with Emacs.
1050 * tparam.h (PC, BC, UP): New extern decls.
1052 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1053 (xftfont_open): Rename locals to avoid shadowing.
1055 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1056 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1057 (OTF_TAG_SYM): Omit macro if not needed.
1058 (ftfont_list): Remove unused local.
1059 (get_adstyle_property, ftfont_pattern_entity):
1060 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1061 Rename locals to avoid shadowing.
1063 * xfont.c (xfont_list_family): Mark var as initialized.
1065 * xml.c (make_dom): Now static.
1067 * composite.c (composition_compute_stop_pos): Rename local to
1069 (composition_reseat_it): Remove unused locals.
1070 (find_automatic_composition, composition_adjust_point): Likewise.
1071 (composition_update_it): Mark var as initialized.
1072 (find_automatic_composition): Mark vars as initialized,
1073 with a FIXME (Bug#8290).
1075 character.h: Rename locals to avoid shadowing.
1076 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1077 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1078 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1079 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1082 * textprop.c (property_change_between_p): Remove; unused.
1084 * intervals.c (interval_start_pos): Now static.
1086 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1088 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1089 Rename locals to avoid shadowing.
1091 * sound.c (wav_play, au_play, Fplay_sound_internal):
1092 Fix pointer signedness.
1093 (alsa_choose_format): Remove unused local var.
1094 (wav_play): Initialize a variable to 0, to prevent undefined
1095 behavior (Bug#8278).
1097 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1099 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1101 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1102 clobbering (Bug#8298).
1103 * sysdep.c (sys_subshell): Likewise.
1104 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1106 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1107 This should get cleaned up, so that child_setup has the
1108 same signature on all platforms.
1110 * callproc.c (call_process_cleanup): Now static.
1111 (relocate_fd): Rename locals to avoid shadowing.
1113 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1115 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1116 not to be necessary, and produces flickering.
1118 2011-03-20 Glenn Morris <rgm@gnu.org>
1120 * config.in: Remove file.
1122 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1124 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1125 are now in src/globals.h.
1126 (syms_of_minibuf): Remove spurious & from previous change.
1128 2011-03-20 Leo <sdl.web@gmail.com>
1130 * minibuf.c (completing-read-function): New variable.
1131 (completing-read-default): Rename from completing-read.
1132 (completing-read): Call completing-read-function.
1134 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1136 * xfaces.c (Fx_load_color_file):
1137 Read color file from absolute filename (bug#8250).
1139 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1141 * makefile.w32-in: Update dependencies.
1143 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1145 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1147 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1149 Fix more problems found by GCC 4.5.2's static checks.
1151 * process.c (make_serial_process_unwind, send_process_trap):
1152 (sigchld_handler): Now static.
1154 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1155 That way, the code declares only the vars that it needs.
1156 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1157 * s/cygwin.h (PTY_ITERATION): Likewise.
1158 * s/darwin.h (PTY_ITERATION): Likewise.
1159 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1161 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1162 * process.c (allocate_pty): Don't declare stb unless it's needed.
1164 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1165 (CONSTANTLIM): Remove; unused.
1166 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1167 Define only if needed.
1169 * unexelf.c (unexec): Name an expression,
1170 to avoid gcc -Wbad-function-cast warning.
1171 Use a different way to cause a compilation error if anyone uses
1172 n rather than nn, a way that does not involve shadowing.
1173 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1175 * deps.mk (unexalpha.o): Remove; unused.
1177 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1178 * unexec.h: New file.
1179 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1180 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1182 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1183 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1184 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1185 Change as necessary to match prototype in unexec.h.
1187 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1189 (back_comment, skip_chars): Mark vars as initialized.
1191 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1192 Rename locals to avoid shadowing.
1194 * lread.c (read1): Rewrite so as not to use empty "else".
1195 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1197 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1199 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1200 warning when compiling print.c.
1202 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1203 instead of using an uninitialized var.
1204 (font_sort_entities): Mark var as initialized.
1206 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1208 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1209 pointers to constants.
1210 (font_parse_fcname): Remove unused vars.
1211 (font_delete_unmatched): Now static.
1212 (font_get_spec): Remove; unused.
1213 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1214 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1215 Rename or move locals to avoid shadowing.
1217 * fns.c (require_nesting_list, require_unwind): Now static.
1218 (Ffillarray): Rename locals to avoid shadowing.
1220 * floatfns.c (domain_error2): Define only if needed.
1221 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1223 * alloc.c (mark_backtrace): Move decl from here ...
1224 * lisp.h: ... to here, so that it can be checked.
1226 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1227 (Fdefvar): Rewrite so as not to use empty "else".
1228 (lisp_indirect_variable): Name an expression,
1229 to avoid gcc -Wbad-function-cast warning.
1230 (Fdefvar): Rename locals to avoid shadowing.
1232 * callint.c (quotify_arg, quotify_args): Now static.
1233 (Fcall_interactively): Rename locals to avoid shadowing.
1234 Use const pointer when appropriate.
1236 * lisp.h (get_system_name, get_operating_system_release):
1237 Move decls here, to check interfaces.
1238 * process.c (get_operating_system_release): Move decl to lisp.h.
1239 * xrdb.c (get_system_name): Likewise.
1240 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1241 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1242 some of which prompt warnings from gcc -Wbad-function-cast.
1243 (Fformat_time_string, Fencode_time, Finsert_char):
1244 (Ftranslate_region_internal, Fformat):
1245 Rename or remove local vars to avoid shadowing.
1246 (Ftranslate_region_internal): Mark var as initialized.
1248 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1251 * lisp.h (eassert): Check that the argument compiles, even if
1252 ENABLE_CHECKING is not defined.
1254 * data.c (Findirect_variable): Name an expression, to avoid
1255 gcc -Wbad-function-cast warning.
1256 (default_value, arithcompare, arith_driver, arith_error): Now static.
1257 (store_symval_forwarding): Rename local to avoid shadowing.
1258 (Fmake_variable_buffer_local, Fmake_local_variable):
1259 Mark variables as initialized.
1260 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1262 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1263 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1264 Rename locals to avoid shadowing.
1265 (mark_stack): Move local variables into the #ifdef region where
1267 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1268 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1270 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1271 (GC_STRING_CHARS): Remove; not used.
1272 (Fmemory_limit): Cast sbrk's returned value to char *.
1274 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1275 avoids undefined behavior in theory.
1277 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1279 Use functions, not macros, for up- and down-casing (Bug#8254).
1280 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1281 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1282 to use the following functions instead of these macros.
1283 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1284 EMACS_INT, since callers assume the returned value fits in int.
1285 (upcase1): Likewise, for UPCASE_TABLE.
1286 (uppercasep, lowercasep, upcase): New static inline functions.
1287 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1288 the race-condition problem in the old DOWNCASE.
1290 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1291 Rename locals to avoid shadowing.
1292 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1293 (regex_compile, re_search_2, re_match_2_internal):
1294 Remove unused local vars.
1295 (FREE_VAR): Rewrite so as not to use empty "else",
1296 which gcc can warn about.
1297 (regex_compile, re_match_2_internal): Mark locals as initialized.
1298 (RETALLOC_IF): Define only if needed.
1299 (WORDCHAR_P): Likewise. This one is never needed, but is used
1300 only in a comment talking about a compiler bug, so put inside
1301 the #if 0 of that comment.
1302 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1303 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1306 * search.c (boyer_moore): Rename locals to avoid shadowing.
1307 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1308 (PREV_CHAR_BOUNDARY): Likewise.
1310 * search.c (simple_search): Remove unused var.
1312 * dired.c (compile_pattern): Move decl from here ...
1313 * lisp.h: ... to here, so that it can be checked.
1314 (struct re_registers): New forward decl.
1316 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1318 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1320 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1321 Rename locals to avoid shadowing.
1322 (Fvertical_motion): Mark locals as initialized.
1324 * casefiddle.c (casify_object, casify_region): Now static.
1325 (casify_region): Mark local as initialized.
1327 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1329 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1330 New macros, so that the caller can use some names other than
1331 gcpro1, gcpro2, etc.
1332 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1334 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1335 argument, for consistency with GCPRO2_VAR, etc: it is now the
1336 prefix of the variable, not the variable itself. All uses
1338 * dired.c (directory_files_internal, file_name_completion):
1339 Rename locals to avoid shadowing.
1341 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1342 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1343 dired.c's scmp function, had undefined behavior.
1344 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1345 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1346 * buffer.h: ... to here, because these macros use current_buffer,
1347 and the new implementation with inline functions needs to have
1348 current_buffer in scope now, rather than later when the macros
1350 (downcase, upcase1): New static inline functions.
1351 (DOWNCASE, UPCASE1): Reimplement using these functions.
1352 This avoids undefined behavior in expressions like
1353 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1354 from race conditions in accessing the global variables
1355 case_temp1 and case_temp2.
1356 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1357 * lisp.h (case_temp1, case_temp2): Remove their decls.
1358 * character.h (ASCII_CHAR_P): Move from here ...
1359 * lisp.h: ... to here, so that the inline functions mentioned
1362 * dired.c (directory_files_internal_unwind): Now static.
1364 * fileio.c (file_name_as_directory, directory_file_name):
1365 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1367 (file_name_as_directory): Use const pointers when appropriate.
1368 (Fexpand_file_name): Likewise. In particular, newdir might
1369 point at constant storage, so make it a const pointer.
1370 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1371 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1373 (Fset_file_times, Finsert_file_contents, auto_save_error):
1374 Rename locals to avoid shadowing.
1376 * minibuf.c (choose_minibuf_frame_1): Now static.
1377 (Ftry_completion, Fall_completions): Rename or remove locals
1380 * marker.c (bytepos_to_charpos): Remove; unused.
1382 * lisp.h (verify_bytepos, count_markers): New decls,
1383 so that gcc does not warn that these functions aren't declared.
1385 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1386 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1387 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1388 (copy_text): Remove unused local var.
1390 * filelock.c (within_one_second): Now static.
1391 (lock_file_1): Rename local to avoid shadowing.
1393 * buffer.c (fix_overlays_before): Mark locals as initialized.
1394 (fix_start_end_in_overlays): Likewise. This function should be
1395 simplified by using pointers-to-pointers, but that's a different
1397 (switch_to_buffer_1): Now static.
1398 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1399 (report_overlay_modification): Rename locals to avoid shadowing.
1401 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1402 Fix pointer signedness issue.
1403 (sys_subshell): Mark local as volatile if checking for lint,
1404 to suppress a gcc -Wclobbered warning that does not seem to be right.
1405 (MAXPATHLEN): Define only if needed.
1407 * process.c (serial_open, serial_configure): Move decls from here ...
1408 * systty.h: ... to here, so that they can be checked.
1410 * fns.c (get_random, seed_random): Move extern decls from here ...
1411 * lisp.h: ... to here, so that they can be checked.
1413 * sysdep.c (reset_io): Now static.
1414 (wait_for_termination_signal): Remove; unused.
1416 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1417 (copy_keymap_item, append_key, push_text_char_description):
1419 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1420 (DENSE_TABLE_SIZE): Remove; unused.
1421 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1422 (describe_map_tree):
1423 Rename locals to avoid shadowing.
1425 * keyboard.c: Declare functions static if they are not used elsewhere.
1426 (echo_char, echo_dash, cmd_error, top_level_2):
1427 (poll_for_input, handle_async_input): Now static.
1428 (read_char, kbd_buffer_get_event, make_lispy_position):
1429 (make_lispy_event, make_lispy_movement, apply_modifiers):
1430 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1431 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1432 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1433 (read_key_sequence, read_char): Mark locals as initialized.
1434 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1436 * keyboard.h (make_ctrl_char): New decl.
1437 (mark_kboards): Move decl here ...
1438 * alloc.c (mark_kboards): ... from here.
1440 * lisp.h (force_auto_save_soon): New decl.
1442 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1443 (DEFINE_DUMMY_FUNCTION): New macro.
1444 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1446 (main): Add casts to avoid warnings
1447 if GCC considers string literals to be constants.
1449 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1451 * dbusbind.c: Pointer signedness fixes.
1452 (xd_signature, xd_append_arg, xd_initialize):
1453 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1454 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1455 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1456 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1458 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1459 if GCC considers string literals to be constants.
1460 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1462 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1464 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1465 (print_preprocess, print_object): New macro to fix last change.
1467 * print.c (print_preprocess): Don't forget font objects.
1469 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1471 * emacs.c (USAGE3): Doc fixes.
1473 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1475 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1478 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1480 * lisp.h (VWindow_system, Qfile_name_history):
1481 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1482 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1483 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1485 * w32select.c: Don't #include "keyboard.h".
1486 (run_protected): Add extern declaration for waiting_for_input.
1488 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1489 * w32console.c (detect_input_pending, read_input_pending)
1490 (encode_terminal_code):
1491 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1492 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1493 (w32_system_caret_y, Qfile_name_history):
1494 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1495 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1496 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1497 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1498 * w32proc.c (Qlocal, report_file_error):
1499 * w32term.c (Vwindow_system, updating_frame):
1500 * w32uniscribe.c (initialized, uniscribe_font_driver):
1501 Remove unneeded extern declarations.
1503 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1505 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1507 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1509 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1510 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1511 These macros can no longer be used for assignment.
1513 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1514 Assign struct members directly, instead of using BUF_BEGV etc.
1515 (record_buffer_markers, fetch_buffer_markers): New functions for
1516 recording and fetching special buffer markers.
1517 (set_buffer_internal_1, set_buffer_temp): Use them.
1519 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1521 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1523 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1524 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1526 * xdisp.c (hscroll_window_tree):
1527 (reconsider_clip_changes): Use PT instead of BUF_PT.
1529 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1531 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1532 $(EMACS_ROOT)/lib/intprops.h.
1534 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1536 Fix more problems found by GCC 4.5.2's static checks.
1538 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1539 to unsigned char * to avoid compiler diagnostic.
1540 (xg_free_frame_widgets): Make it clear that a local variable is
1541 needed only if USE_GTK_TOOLTIP.
1542 (gdk_window_get_screen): Make it clear that this macro is needed
1543 only if USE_GTK_TOOLTIP.
1544 (int_gtk_range_get_value): New function, which avoids a diagnostic
1545 from gcc -Wbad-function-cast.
1546 (xg_set_toolkit_scroll_bar_thumb): Use it.
1547 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1548 diagnostic from gcc -Wbad-function-cast.
1549 (get_utf8_string, xg_get_file_with_chooser):
1550 Rename locals to avoid shadowing.
1551 (create_dialog): Move locals to avoid shadowing.
1553 * xgselect.c (xg_select): Remove unused var.
1555 * image.c (four_corners_best): Mark locals as initialized.
1556 (gif_load): Initialize transparent_p to zero (Bug#8238).
1557 Mark another local as initialized.
1558 (my_png_error, my_error_exit): Mark with NO_RETURN.
1560 * image.c (clear_image_cache): Now static.
1561 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1562 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1563 (x_edge_detection): Remove unnecessary cast that
1564 gcc -Wbad-function-cast diagnoses.
1565 (gif_load): Fix pointer signedness.
1566 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1567 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1569 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1571 Improve quality of tests for time stamp overflow.
1572 For example, without this patch (encode-time 0 0 0 1 1
1573 1152921504606846976) returns the obviously-bogus value (-948597
1574 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1575 reports time overflow. See
1576 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1577 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1578 * editfns.c: Include limits.h and intprops.h.
1579 (TIME_T_MIN, TIME_T_MAX): New macros.
1580 (time_overflow): Move earlier, to before first use.
1581 (hi_time, lo_time): New functions, for an accurate test for
1583 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1584 (Fget_internal_run_time): Don't assume time_t fits in int.
1585 (make_time): Use list2 instead of Fcons twice.
1586 (Fdecode_time): More accurate test for out-of-range times.
1587 (check_tm_member): New function.
1588 (Fencode_time): Use it, to test for out-of-range times.
1589 (lisp_time_argument): Don't rely on undefined left-shift and
1590 right-shift behavior when checking for time stamp overflow.
1592 * editfns.c (time_overflow): New function, refactoring common code.
1593 (Fformat_time_string, Fdecode_time, Fencode_time):
1594 (Fcurrent_time_string): Use it.
1596 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1597 * dired.c (make_time): Move to ...
1598 * editfns.c (make_time): ... here.
1599 * systime.h: Note the move.
1601 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1603 * fringe.c (update_window_fringes): Remove unused variables.
1605 * unexmacosx.c (copy_data_segment): Also copy __got section.
1608 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1610 * termcap.c [MSDOS]: Include "msdos.h".
1611 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1612 Constify `char *' arguments and their references according to
1613 prototypes in tparam.h.
1615 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1617 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1618 Adapt all references accordingly.
1620 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1622 2011-03-11 Tom Tromey <tromey@redhat.com>
1624 * buffer.c (syms_of_buffer): Remove obsolete comment.
1626 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1628 * termhooks.h (encode_terminal_code): Declare prototype.
1630 * msdos.c (encode_terminal_code): Don't declare prototype.
1632 * term.c (encode_terminal_code): Now external again, used by
1633 w32console.c and msdos.c.
1635 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1636 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1638 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1640 Fix some minor problems found by GCC 4.5.2's static checks.
1642 * fringe.c (update_window_fringes): Mark locals as initialized
1644 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1646 * alloc.c (mark_fringe_data): Move decl from here ...
1647 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1648 to check its interface.
1649 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1651 * fontset.c (free_realized_fontset): Now static.
1652 (Fset_fontset_font): Rename local to avoid shadowing.
1653 (fontset_font): Mark local as initialized.
1654 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1656 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1658 * xselect.c (x_disown_buffer_selections): Remove; not used.
1659 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1660 (x_own_selection, Fx_disown_selection_internal): Rename locals
1662 (x_handle_dnd_message): Remove local to avoid shadowing.
1664 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1665 so that the caller can use some name other than gcpro1.
1666 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1667 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1668 (Fx_backspace_delete_keys_p):
1669 Use them to avoid shadowing, and rename vars to avoid shadowing.
1670 (x_decode_color, x_set_name, x_window): Now static.
1671 (Fx_create_frame): Add braces to silence GCC warning.
1672 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1673 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1674 Remove unused locals.
1675 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1676 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1677 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1680 * xterm.h (x_mouse_leave): New decl.
1682 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1683 Remove unused functions.
1684 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1685 (x_calc_absolute_position): Now static.
1686 (XTread_socket): Don't define label "out" unless it's used.
1687 Don't declare local "event" unless it's used.
1688 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1689 unless they are used.
1690 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1691 (x_fatal_error_signal): Remove; not used.
1692 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1693 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1694 (x_error_catcher, x_connection_closed, x_error_handler):
1695 (x_error_quitter, xembed_send_message, x_iconify_frame):
1696 (my_log_handler): Rename locals to avoid shadowing.
1697 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1698 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1700 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1701 Rename or move locals to avoid shadowing.
1702 (tty_defined_color, merge_face_heights): Now static.
1703 (free_realized_faces_for_fontset): Remove; not used.
1704 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1705 does not deduce is never used uninitialized.
1706 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1707 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1709 * terminal.c (store_terminal_param): Now static.
1711 * xmenu.c (menu_highlight_callback): Now static.
1712 (set_frame_menubar): Remove unused local.
1713 (xmenu_show): Rename parameter to avoid shadowing.
1714 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1715 since they might point to immutable storage.
1716 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1717 since it's unused otherwise.
1719 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1720 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1721 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1722 avoids a gcc -Wuninitialized diagnostic.
1723 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1724 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1725 does not deduce are never used uninitialized.
1727 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1729 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1730 * window.c (window_loop, size_window):
1731 (run_window_configuration_change_hook, enlarge_window): Likewise.
1733 * window.c (display_buffer): Now static.
1734 (size_window): Mark variables that gcc -Wuninitialized
1735 does not deduce are never used uninitialized.
1736 * window.h (check_all_windows): New decl, to forestall
1737 gcc -Wmissing-prototypes diagnostic.
1738 * dispextern.h (bidi_dump_cached_states): Likewise.
1740 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1742 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1744 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1745 and to avoid gcc -Wuninitialized warning.
1746 (load_charset_map): Mark variables that gcc -Wuninitialized
1747 does not deduce are never used uninitialized.
1748 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1750 * coding.c (coding_set_source, coding_set_destination):
1751 Use "else { /* comment */ }" rather than "else /* comment */;"
1752 for clarity, and to avoid gcc -Wempty-body warning.
1753 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1754 a block, when the outer 'i' will do.
1755 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1756 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1757 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1758 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1759 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1760 Rename locals to avoid shadowing.
1761 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1762 * coding.c (emacs_mule_char, encode_invocation_designation):
1763 Now static, since they're not used elsewhere.
1764 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1765 (decode_coding_object, encode_coding_object, detect_coding_system):
1766 (decode_coding_emacs_mule): Mark variables that gcc
1767 -Wuninitialized does not deduce are never used uninitialized.
1768 (detect_coding_iso_2022): Initialize a local variable that might
1769 be used uninitialized. Leave a FIXME because it's not clear that
1770 this initialization is needed. (Bug#8211)
1771 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1772 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1773 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1774 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1775 Remove unused macros.
1777 * category.c (hash_get_category_set): Remove unused local var.
1778 (copy_category_table): Now static, since it's not used elsewhere.
1779 * character.c (string_count_byte8): Likewise.
1781 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1782 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1784 * chartab.c (copy_sub_char_table): Now static, since it's not used
1786 (sub_char_table_ref_and_range, char_table_ref_and_range):
1787 Rename locals to avoid shadowing.
1788 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1790 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1791 (BIDI_BOB): Remove unused macro.
1793 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1794 deduce are never used uninitialized.
1795 * term.c (encode_terminal_code): Likewise.
1797 * term.c (encode_terminal_code): Now static. Remove unused local.
1799 * tparam.h: New file.
1800 * term.c, tparam.h: Include it.
1801 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1802 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1803 Move these decls to tparam.h, and make them agree with what
1804 is actually in tparam.c. The previous trick of using incompatible
1805 decls in different modules does not conform to the C standard.
1806 All callers of tparam changed to use tparam's actual API.
1807 * tparam.c (tparam1, tparam, tgoto):
1808 Use const pointers where appropriate.
1810 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1811 * cm.h (struct cm): Likewise.
1812 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1813 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1814 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1815 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1816 (turn_on_face, init_tty): Likewise.
1817 * termchar.h (struct tty_display_info): Likewise.
1819 * term.c (term_mouse_position): Rename local to avoid shadowing.
1821 * alloc.c (mark_ttys): Move decl from here ...
1822 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1824 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1826 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1828 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1830 * search.c (compile_pattern_1): Remove argument regp, unused since
1831 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1832 (compile_pattern): Don't pass it.
1834 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1836 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1837 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1839 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1841 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1843 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1844 gdk_window_get_screen, gdk_window_get_geometry,
1845 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1846 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1847 (xg_get_pixbuf_from_pixmap): New function.
1848 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1849 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1850 Call xg_get_pixbuf_from_pixmap instead of
1851 gdk_pixbuf_get_from_drawable.
1852 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1853 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1854 (xg_check_special_colors): Use GtkStyleContext and its functions
1856 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1857 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1858 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1859 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1860 Call gtk_widget_get_preferred_size.
1861 (xg_frame_resized): gdk_window_get_geometry only takes 5
1863 (xg_win_to_widget, xg_event_is_for_menubar):
1864 Call gdk_x11_window_lookup_for_display.
1865 (xg_set_widget_bg): New function.
1866 (delete_cb): New function.
1867 (xg_create_frame_widgets): connect delete-event to delete_cb.
1868 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1869 (xg_set_background_color): Call xg_set_widget_bg.
1870 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1871 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1872 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1873 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1875 (update_frame_tool_bar): Call gtk_widget_hide.
1876 (xg_initialize): Use GDK_KEY_g.
1878 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1880 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1882 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1883 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1884 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1886 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1888 * w32xfns.c (select_palette): Check success of RealizePalette against
1889 GDI_ERROR, not zero.
1891 See ChangeLog.11 for earlier changes.
1897 Copyright (C) 2011 Free Software Foundation, Inc.
1899 This file is part of GNU Emacs.
1901 GNU Emacs is free software: you can redistribute it and/or modify
1902 it under the terms of the GNU General Public License as published by
1903 the Free Software Foundation, either version 3 of the License, or
1904 (at your option) any later version.
1906 GNU Emacs is distributed in the hope that it will be useful,
1907 but WITHOUT ANY WARRANTY; without even the implied warranty of
1908 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1909 GNU General Public License for more details.
1911 You should have received a copy of the GNU General Public License
1912 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.