]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
76
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
79
80 * print.c (float_to_string): Detect width overflow more reliably.
81 (print_object): Make sprintf buffer a bit bigger, to avoid potential
82 buffer overrun. Don't assume list length fits in 'int'. Treat
83 print length of 0 as 0, not as infinity; to be consistent with other
84 uses of print length in this function. Don't overflow print length
85 index. Don't assume hash table size fits in 'long', or that
86 vectorlike size fits in 'unsigned long'.
87
88 * process.c (make_process): Use printmax_t, not int, to format
89 process-name gensyms.
90
91 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
92 to avoid potential buffer overrun.
93
94 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
95 if X resource line is longer than 512 bytes.
96
97 * xfns.c (x_window): Make sprintf buffer a bit bigger
98 to avoid potential buffer overrun.
99
100 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
101
102 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
103
104 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
105
106 * image.c (parse_image_spec): Check for nonnegative, not for positive,
107 when checking :margin (Bug#9390).
108 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
109 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
110 so that the name doesn't mislead. All uses changed.
111
112 2011-08-28 Johan Bockgård <bojohan@gnu.org>
113
114 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
115 set_tty_hooks.
116
117 2011-08-27 Eli Zaretskii <eliz@gnu.org>
118
119 * xdisp.c (move_it_to): Don't bail out early when reaching
120 position beyond to_charpos, if we are scanning backwards.
121 (move_it_vertically_backward): When DY == 0, make sure we get to
122 the first character in the line after the newline.
123
124 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
125
126 * ccl.c: Improve and simplify overflow checking (Bug#9196).
127 (ccl_driver): Do not generate an out-of-range pointer.
128 (Fccl_execute_on_string): Remove unnecessary check for
129 integer overflow, noted by Stefan Monnier in
130 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
131 Remove a FIXME that didn't need fixing.
132 Simplify the newly-introduced buffer reallocation code.
133
134 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
135
136 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
137
138 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
139
140 Integer and memory overflow issues (Bug#9196).
141
142 * doc.c (get_doc_string): Rework so that
143 get_doc_string_buffer_size is the actual buffer size, rather than
144 being 1 less than the actual buffer size; this makes xpalloc more
145 convenient.
146
147 * image.c (x_allocate_bitmap_record, cache_image):
148 * xselect.c (Fx_register_dnd_atom):
149 Simplify previous changes by using xpalloc.
150
151 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
152 since either will do and ptrdiff_t is convenient with xpalloc.
153
154 * charset.c (charset_table_size)
155 (struct charset_sort_data.priority): Now ptrdiff_t.
156 (charset_compare): Don't overflow if priorities differ greatly.
157 (Fsort_charsets): Don't assume list length fits in int.
158 Check for size-calculation overflow when allocating sort data.
159 (syms_of_charset): Allocate an initial charset table that is
160 just under 64 KiB, to avoid problems with glibc malloc and mmap.
161
162 * cmds.c (internal_self_insert): Check for size-calculation overflow.
163
164 * composite.h (struct composition.glyph_len): Now int, not unsigned.
165 The actual value is always <= INT_MAX, and leaving it unsigned made
166 overflow checking harder.
167
168 * dispextern.h (struct glyph_matrix.rows_allocated)
169 (struct face_cache.size): Now ptrdiff_t, for convenience in use
170 with xpalloc. The values are still always <= INT_MAX.
171
172 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
173
174 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
175 (SAFE_NALLOCA): New macro.
176
177 * region-cache.c (struct boundary.pos, find_cache_boundary)
178 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
179 (set_cache_region, invalidate_region_cache)
180 (revalidate_region_cache, know_region_cache, region_cache_forward)
181 (region_cache_backward, pp_cache):
182 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
183 so that ptrdiff_t * can be passed to xpalloc.
184 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
185 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
186 (pp_cache): Don't assume cache_len fits in int.
187 * region-cache.h: Adjust extern decls to match.
188
189 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
190 EMACS_INT, since either will do, for xpalloc.
191
192 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
193 (xnmalloc, xnrealloc, xpalloc): New functions.
194
195 * bidi.c (bidi_shelve_header_size): New constant.
196 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
197 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
198
199 * bidi.c (bidi_cache_shrink):
200 * buffer.c (overlays_at, overlays_in, record_overlay_string)
201 (overlay_strings):
202 Don't update size of array until after memory allocation succeeds,
203 because xmalloc/xrealloc may not return.
204 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
205 now that we have proper integer overflow checking.
206 (record_overlay_string, overlay_strings): Catch overflows when
207 calculating size of overlay_str_buf.
208
209 * callproc.c (Fcall_process): Check for size overflow when
210 calculating size of args2.
211 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
212 Normally we prefer signed values, but sticking with ptrdiff_t would
213 require adding more-complicated checks.
214
215 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
216 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
217 Redo buffer-overflow calculations to avoid integer overflow.
218 Add a FIXME comment where memory seems to be over-allocated.
219
220 * character.c (Fstring): Check for size-calculation overflow.
221
222 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
223 unnecessary integer overflow. Check for size overflow.
224 (encode_coding_object): Don't update size until xmalloc succeeds.
225
226 * composite.c (get_composition_id): Check for overflow in glyph
227 length calculations.
228
229 Integer and memory overflow fixes for display code.
230 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
231 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
232 (scrolling_window): Check for overflow in size calculations.
233 (line_draw_cost, realloc_glyph_pool, add_row_entry):
234 Don't assume glyph table len fits in int.
235 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
236 (row_table_size): Now ptrdiff_t, not int.
237 (scrolling_window): Avoid overflow in size calculations.
238 Don't update size until allocation succeeds.
239 * fns.c (concat): Check for overflow in size calculations.
240 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
241 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
242 (NEXT_ALMOST_PRIME_LIMIT): New constant.
243
244 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
245 (get_doc_string): Check for size calculation overflow.
246 Don't update size until allocation succeeds.
247 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
248 EMACS_INT, where ptrdiff_t will do.
249 (Fsubstitute_command_keys): Check for string overflow.
250
251 * editfns.c (set_time_zone_rule): Don't assume environment length
252 fits in int.
253 (message_length): Now ptrdiff_t, not int.
254 (Fmessage_box): Don't update size until allocation succeeds.
255 Don't assume message length fits in int.
256 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
257
258 * emacs.c (main): Do not reallocate argv, since there is a null at
259 the end that can be overwritten, and this way there's no need to
260 worry about size-calculation overflow.
261 (sort_args): Check for size-calculation overflow.
262
263 * eval.c (init_eval_once, grow_specpdl): Don't update size until
264 alloc succeeds.
265 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
266
267 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
268 (x_set_scroll_bar_width, x_figure_window_size):
269 Check for integer overflow.
270 (x_set_alpha): Do not assume XINT fits in int.
271
272 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
273 This is for the members text_lines, text_cols, total_lines, total_cols,
274 where the system imposes an 'int' limit.
275
276 * fringe.c (Fdefine_fringe_bitmap):
277 Don't update size until alloc works.
278
279 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
280 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
281
282 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
283 Check for size-calculation overflow.
284 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
285 do, as we prefer signed integers.
286 (id_to_widget.max_size, id_to_widget.used)
287 (xg_store_widget_in_map, xg_remove_widget_from_map)
288 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
289 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
290 Use and return ptrdiff_t, not int.
291 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
292 * gtkutil.h: Change prototypes to match the above.
293
294 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
295 are duplicate now that they've been promoted to lisp.h.
296 (x_allocate_bitmap_record, x_alloc_image_color)
297 (make_image_cache, cache_image, xpm_load):
298 Don't update size until alloc is done.
299 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
300 (x_detect_edges):
301 Check for size calculation overflow.
302 (ct_colors_allocated_max): New constant.
303 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
304 overflow.
305
306 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
307 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
308 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
309 Use ptrdiff_t, not int, to count maps.
310 (read_char_minibuf_menu_prompt): Check for overflow in size
311 calculations. Don't update size until allocation succeeds. Redo
312 calculations to avoid overflow.
313 * keyboard.h: Change prototypes to match the above.
314
315 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
316 to count maps.
317 (current_minor_maps): Check for size calculation overflow.
318 * keymap.h: Change prototypes to match the above.
319
320 * lread.c (read1, init_obarray): Don't update size until alloc done.
321
322 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
323 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
324
325 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
326 Now ptrdiff_t, not int.
327 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
328 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
329
330 * process.c (Fnetwork_interface_list): Check for overflow
331 in size calculation.
332
333 * region-cache.c (move_cache_gap): Check for size calculation overflow.
334
335 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
336 overflow. Don't bother calling xmalloc when xrealloc will do.
337
338 * search.c (Freplace_match): Check for size calculation overflow.
339 (Fset_match_data): Don't assume list lengths fit in 'int'.
340
341 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
342 for command line length. Do not attempt to address one before the
343 beginning of an array, as that's not portable.
344
345 * term.c (max_frame_lines): Remove; unused.
346 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
347 not int.
348 (encode_terminal_code, calculate_costs): Check for size
349 calculation overflow.
350 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
351 table lengths and related sizes. Don't update size until alloc
352 done. Redo calculations to avoid overflow.
353 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
354
355 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
356 subtracting pointers.
357 (gobble_line): Check for overflow more carefully. Don't update size
358 until alloc done.
359
360 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
361 Don't update size until alloc done.
362 Redo size calculations to avoid overflow.
363 Check for size calculation overflow.
364 (main) [DEBUG]: Fix typo in invoking tparam1.
365
366 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
367 Use ptrdiff_t, not int, for sizes.
368 (store_mode_line_noprop_char): Don't update size until alloc done.
369
370 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
371 Use ptrdiff_t, not int, for sizes.
372 (Finternal_make_lisp_face, cache_face):
373 Check for size calculation overflow.
374 (cache_face): Treat size calculation overflows as if they were
375 memory exhaustion (the usual treatment), rather than aborting.
376
377 * xfns.c (x_encode_text, x_set_name_internal)
378 (Fx_change_window_property): Use ptrdiff_t, not int, to count
379 sizes, since they can exceed INT_MAX in size. Check for size
380 calculation overflow.
381
382 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
383 (xg_select): Check for size calculation overflow.
384 Don't update size until alloc done.
385
386 * xrdb.c (get_environ_db): Don't assume path length fits in int,
387 as sprintf is limited to int lengths.
388
389 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
390 (X_LONG_MIN): New macros.
391 Use them to make the following changes clearer.
392 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
393 This change doesn't affect the value now, but it may help remind
394 future maintainers not to raise the value too much later.
395 (SELECTION_QUANTUM): Remove, replacing with ...
396 (selection_quantum): ... new function, which avoids overflow.
397 All uses changed.
398 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
399 assumption that selection length fits in 'int'.
400 (x_reply_selection_request, x_handle_selection_request)
401 (x_get_window_property, receive_incremental_selection)
402 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
403 (lisp_data_to_selection_data, clean_local_selection_data):
404 Use ptrdiff_t, not int, to record length of selection.
405 (x_reply_selection_request, x_get_window_property)
406 (receive_incremental_selection, x_property_data_to_lisp):
407 Redo calculations to avoid overflow.
408 (x_reply_selection_request): When sending hint, ceiling it at
409 X_LONG_MAX rather than relying on wraparound overflow to send
410 something.
411 (x_get_window_property, receive_incremental_selection)
412 (lisp_data_to_selection_data, x_property_data_to_lisp):
413 Check for size-calculation overflow.
414 (x_get_window_property, receive_incremental_selection)
415 (lisp_data_to_selection_data, Fx_register_dnd_atom):
416 Don't store size until memory allocation succeeds.
417 (x_get_window_property): Plug memory leak on memory exhaustion.
418 Don't double-block input; malloc is safe here. Don't assume 2**34
419 - 4 fits in unsigned long. Add an xassert to check
420 XGetWindowProperty overflow. Be more careful about overflow
421 calculations, and distinguish size from memory overflow better.
422 (receive_incremental_selection): When tracing, don't assume
423 unsigned int is less than INT_MAX.
424 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
425 harmful) conversions of unsigned short to int.
426 (lisp_data_to_selection_data): Don't assume that integers
427 in the range -65535 through -1 fit in an X unsigned short.
428 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
429 result parameters unless successful. Rely on cons_to_unsigned
430 to report problems with elements; the old code wasn't right anyway.
431 (x_check_property_data): Check for int overflow; we cannot use
432 a wider type due to X limits.
433 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
434
435 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
436
437 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
438 (x_term_init): Check for size calculation overflow.
439 (x_color_cells): Don't store size until memory allocation succeeds.
440 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
441 Don't assume alloca size is less than MAX_ALLOCA.
442 (x_term_init): Don't assume length fits in int (sprintf is limited
443 to int size).
444
445 Use ptrdiff_t for composition IDs.
446 * character.c (lisp_string_width):
447 * composite.c (composition_table_size, n_compositions)
448 (get_composition_id, composition_gstring_from_id):
449 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
450 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
451 * window.c (Frecenter):
452 Use ptrdiff_t, not int, for composition IDs.
453 * composite.c (get_composition_id): Check for integer overflow.
454 * composite.h: Adjust prototypes to match the above changes.
455
456 Use ptrdiff_t for hash table indexes.
457 * category.c (hash_get_category_set):
458 * ccl.c (ccl_driver):
459 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
460 * coding.c (coding_system_charset_list, detect_coding_system):
461 * coding.h (struct coding_system.id):
462 * composite.c (get_composition_id, gstring_lookup_cache):
463 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
464 * image.c (xpm_get_color_table_h):
465 * lisp.h (hash_lookup, hash_put):
466 * minibuf.c (Ftest_completion):
467 Use ptrdiff_t for hash table indexes, not int (which is too
468 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
469 32-bit --with-wide-int hosts).
470
471 * charset.c (Fdefine_charset_internal): Check for integer overflow.
472 Add a FIXME comment about memory leaks.
473 (syms_of_charset): Don't assume xmalloc returns.
474
475 Don't assume that stated character widths fit in int.
476 * character.c (Fchar_width, c_string_width, lisp_string_width):
477 * character.h (CHAR_WIDTH):
478 * indent.c (MULTIBYTE_BYTES_WIDTH):
479 Use sanitize_char_width to avoid undefined and/or bad behavior
480 with outlandish widths.
481 * character.h (sanitize_tab_width): Renamed from sanitize_width,
482 now that we have two such functions. All uses changed.
483 (sanitize_char_width): New inline function.
484
485 Don't assume that tab-width fits in int.
486 * character.h (sanitize_width): New inline function.
487 (SANE_TAB_WIDTH): New macro.
488 (ASCII_CHAR_WIDTH): Use it.
489 * indent.c (sane_tab_width): Remove. All uses replaced by
490 SANE_TAB_WIDTH (current_buffer).
491 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
492
493 * fileio.c: Integer overflow issues with file modes.
494 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
495
496 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
497 Remove unreachable code.
498 (read_hex, load_charset_map_from_file): Check for integer overflow.
499
500 * xterm.c: don't go over XClientMessageEvent limit
501 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
502 (x_send_scroll_bar_event): Likewise. Check that the size does not
503 exceed limits imposed by XClientMessageEvent, as well as the usual
504 ptrdiff_t and size_t limits.
505
506 * keyboard.c: Overflow, signedness and related fixes.
507 (make_lispy_movement): Use same integer type in forward decl
508 that is used in the definition.
509 (read_key_sequence, keyremap_step):
510 Change bufsize argument back to int, undoing my 2011-03-30 change.
511 We prefer signed types, and int is wide enough here.
512 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
513 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
514 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
515 length, not size_t. Use ptrdiff_t for index, not int.
516 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
517 possibility of integer overflow.
518
519 Overflow, signedness and related fixes for images.
520
521 * dispextern.h (struct it.stack[0].u.image.image_id)
522 (struct_it.image_id, struct image.id, struct image_cache.size)
523 (struct image_cache.used, struct image_cache.ref_count):
524 * gtkutil.c (update_frame_tool_bar):
525 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
526 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
527 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
528 * nsmenu.m (update_frame_tool_bar):
529 * xdisp.c (calc_pixel_width_or_height):
530 * xfns.c (image_cache_refcount):
531 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
532 on typical 64-bit hosts.
533
534 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
535 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
536 Omit unnecessary casts to int.
537 (parse_image_spec): Check that integers fall into 'int' range
538 when the callers expect that.
539 (image_ascent): Redo ascent calculation to avoid int overflow.
540 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
541 (lookup_image): Remove unnecessary tests.
542 (xbm_image_p): Locals are now of int, not EMACS_INT,
543 since parse_image_check makes sure they fit into int.
544 (png_load, gif_load, svg_load_image):
545 Prefer int to unsigned where either will do.
546 (tiff_handler): New function, combining the cores of the
547 old tiff_error_handler and tiff_warning_handler. This
548 function is rewritten to use vsnprintf and thereby avoid
549 stack buffer overflows. It uses only the features of vsnprintf
550 that are common to both POSIX and native Microsoft.
551 (tiff_error_handler, tiff_warning_handler): Use it.
552 (tiff_load, gif_load, imagemagick_load_image):
553 Don't assume :index value fits in 'int'.
554 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
555 (imagemagick_load_image): Check that crop parameters fit into
556 the integer types that MagickCropImage accepts. Don't assume
557 Vimagemagick_render_type has a nonnegative value. Don't assume
558 size_t fits in 'long'.
559 (gs_load): Use printmax_t to print the widest integers possible.
560 Check for integer overflow when computing image height and width.
561
562 2011-08-26 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (redisplay_window): Don't force window start if point
565 will be invisible in the resulting window. (Bug#9324)
566
567 2011-08-25 Eli Zaretskii <eliz@gnu.org>
568
569 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
570 the display spec is of the form `(space ...)'.
571 (handle_display_spec): Return the value returned by
572 handle_single_display_spec, not just 1 or zero.
573 (handle_single_display_spec): If the display spec is of the form
574 `(space ...)', and specifies display in the text area, return 2
575 rather than 1.
576 (try_cursor_movement): Check for the need to scroll more
577 accurately, and prefer exact match for point under bidi. Don't
578 advance `row' beyond the last row of the window.
579
580 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
581 into disp_prop; all users changed.
582
583 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
584 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
585 for the text covered by the display property.
586
587 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
588
589 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
590 Change return value to nil.
591 (Frecord_buffer): Delete unused function.
592
593 2011-08-24 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
596 buffers, return left-to-right.
597 (set_cursor_from_row): Consider candidate row a win if its glyph
598 represents a newline and point is on that newline. Fixes cursor
599 positioning on the newline at EOL of R2L text within L2R
600 paragraph, and vice versa.
601 (try_cursor_movement): Check continued rows, in addition to
602 continuation rows. Fixes unwarranted scroll when point enters a
603 continued line of R2L text within an L2R paragraph, or vice versa.
604 (cursor_row_p): Consider the case of point being equal to
605 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
606 from the end of a short line to the beginning of a continued line
607 of R2L text within L2R paragraph.
608 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
609 composed characters.
610
611 * bidi.c (bidi_check_type): Use xassert.
612 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
613 members.
614
615 2011-08-23 Eli Zaretskii <eliz@gnu.org>
616
617 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
618 a character.
619
620 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
621
622 * nsfont.m (ns_otf_to_script): Fix typo.
623
624 2011-08-22 Kenichi Handa <handa@m17n.org>
625
626 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
627 extra slot even if the purpose is char-code-property-table.
628
629 2011-08-23 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (redisplay_window): When computing centering_position,
632 account for the height of the header line. (Bug#8874)
633
634 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
635 instead of CHAR_TO_BYTE. Fixes a crash when a completion
636 candidate is selected by the mouse, and that candidate has a
637 composed character under the mouse.
638
639 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
640 coordinates reported by pos-visible-in-window-p for a composed
641 character in column zero.
642
643 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
644
645 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
646
647 2011-08-22 Eli Zaretskii <eliz@gnu.org>
648
649 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
650 consider it a hit if to_charpos is anywhere in the range of the
651 composed buffer positions.
652
653 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
654
655 * image.c (gif_load): Don't assume that each subimage has the same
656 dimensions as the base image. Handle disposal method that is
657 "undefined" by the gif spec (Bug#9335).
658
659 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
660
661 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
662 (Fcondition_case): Document `debug' symbol in error handler.
663
664 2011-08-19 Eli Zaretskii <eliz@gnu.org>
665
666 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
667 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
668 from an Org mode buffer to a Speedbar frame.
669
670 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
671 a composition, take its buffer position from IT->cmp_it.charpos.
672 Fixes cursor positioning at the beginning of a line that begins
673 with a composed character.
674
675 2011-08-18 Eli Zaretskii <eliz@gnu.org>
676
677 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
678 character bidirectional type, use STRONG_L instead. Fixes crashes
679 in a buffer produced by `describe-categories'.
680
681 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
682 members before the level stack, so they would be saved and
683 restored when copying iterator state. Fixes incorrect reordering
684 around TABs covered by display properties.
685
686 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
687
688 * process.c (Fnetwork_interface_list): Correctly determine buffer
689 size.
690
691 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
692
693 * eval.c (internal_condition_case, internal_condition_case_1)
694 (internal_condition_case_2, internal_condition_case_n):
695 Remove unnecessary aborts (Bug#9081).
696
697 2011-08-17 Eli Zaretskii <eliz@gnu.org>
698
699 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
700 has no `load' handler, try opening the file locally. (Bug#9311)
701
702 2011-08-16 Ken Brown <kbrown@cornell.edu>
703
704 * gmalloc.c: Expand comment.
705
706 2011-08-16 Eli Zaretskii <eliz@gnu.org>
707
708 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
709 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
710
711 2011-08-16 Ken Brown <kbrown@cornell.edu>
712
713 Fix memory allocation problems in Cygwin build (Bug#9273).
714
715 * unexcw.c ( __malloc_initialized): Declare external variable.
716 (fixup_executable): Force the dumped emacs to reinitialize malloc.
717
718 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
719 New variables.
720 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
721 dumped emacs.
722 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
723 in the static heap.
724 [CYGWIN] (special_realloc): New function.
725 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
726 requests to realloc storage in the static heap.
727
728 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
729
730 * bidi.c (bidi_initialize): Remove unused local.
731
732 2011-08-15 Eli Zaretskii <eliz@gnu.org>
733
734 * biditype.h: File removed.
735
736 * bidimirror.h: File removed.
737
738 * deps.mk (bidi.o): Remove biditype.h and
739 bidimirror.h.
740
741 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
742 bidimirror.h.
743
744 * dispextern.h: Fix a typo in the comment to bidi_type_t.
745
746 * chartab.c: Improve commentary for the uniprop_table API.
747
748 * bidi.c (bidi_paragraph_init): Support zero value of
749 bidi_ignore_explicit_marks_for_paragraph_level.
750 (bidi_initialize): Use uniprop_table instead of including
751 biditype.h and bidimirror.h.
752
753 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
754 coordinates of the iterator when restoring from ppos_it.
755 (Bug#9296)
756
757 2011-08-14 Kenichi Handa <handa@m17n.org>
758
759 * process.c (create_process): Call setup_process_coding_systems
760 after the pid of the process is set to -1 (Bug#8162).
761
762 2011-08-14 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (move_it_in_display_line_to): Don't invoke
765 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
766 ppos_it. Fixes vertical cursor motion when line beginning is
767 covered by an image. (Bug#9296)
768
769 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
770
771 * nsterm.h (ns_run_ascript): Declare.
772 (NSAPP_DATA2_RUNASSCRIPT): Define.
773
774 * nsfns.m (as_script, as_result, as_status): New static variables.
775 (ns_run_ascript): New function.
776 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
777 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
778 the event loop. Get status from as_status (Bug#7276).
779
780 * nsterm.m (sendEvent): If event is NSApplicationDefined and
781 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
782 the event loop (Bug#7276).
783
784 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
785
786 * gnutls.c (QCgnutls_bootprop_priority)
787 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
788 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
789 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
790 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
791 (QCgnutls_bootprop_verify_hostname_error)
792 (QCgnutls_bootprop_callbacks_verify): Rename from
793 Qgnutls_bootprop_..., all uses changed.
794
795 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
796 uses changed.
797
798 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
799
800 * xfaces.c (Qframe_set_background_mode): Now static.
801 * dispextern.h (Qframe_set_background_mode): Remove decl.
802
803 * process.c (Fnetwork_interface_info): Declare local only if needed.
804
805 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
806
807 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
808 (Fnetwork_interface_list): Allocate in increments of bytes instead
809 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
810 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
811 sockaddr.
812 (struct ifflag_def): notrailers is smart on OSX.
813 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
814 Get hardware address with getifaddrs if available.
815
816 2011-08-12 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (iterate_out_of_display_property): xassert that
819 IT->position is set to within IT->object's boundaries. Break from
820 the loop as soon as EOB is reached; avoids infloops in redisplay
821 when IT->position is set up wrongly due to some bug.
822 Set IT->current to match the bidi iterator unconditionally.
823 (push_display_prop): Allow GET_FROM_STRING as IT->method on
824 entry. Force push_it to save on the stack the current
825 buffer/string position, to be restored by pop_it. Fix flags in
826 the iterator structure wrt the object coming from a display
827 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
828 properties. (Bug#9284)
829
830 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
831
832 * fontset.c (fontset_get_font_group): Add proper type checks.
833 (Bug#9172)
834
835 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
836
837 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
838 and LC_VERSION_MIN_MACOSX.
839 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
840 (dump_it) [LC_FUNCTION_STARTS]: Use it.
841
842 2011-08-08 Eli Zaretskii <eliz@gnu.org>
843
844 * xdisp.c (forward_to_next_line_start): Allow to use the
845 no-display-properties-and-no-overlays under bidi display.
846 Set disp_pos in the bidi iterator to avoid searches for display
847 properties and overlays.
848
849 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
850
851 * editfns.c (Fset_time_zone_rule): Document relationship with the
852 setenv function.
853
854 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
855 the font entity extracted from the cache (Bug#8109).
856
857 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
858
859 * composite.c (autocmp_chars): Don't reset point. That is done by
860 restore_point_unwind (Bug#5984).
861
862 2011-08-07 Juri Linkov <juri@jurta.org>
863
864 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
865 to show the arg `TIME' instead of `TIMEVAL'.
866
867 2011-08-06 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
870 display property strides EOL and includes a newline, as in
871 longlines-mode. (Bug#9254)
872 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
873 word-wrap under bidirectional display. (Bug#9224)
874
875 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
876 is non-zero, even if the data buffer is NULL. Fixes a crash in
877 vertical-motion with longlines-mode. (Bug#9254)
878
879 2011-08-05 Eli Zaretskii <eliz@gnu.org>
880
881 * bidi.c <bidi_cache_total_alloc>: Now static.
882 (bidi_initialize): Initialize bidi_cache_total_alloc.
883
884 * xdisp.c (display_line): Release buffer allocated for shelved bidi
885 cache. (Bug#9221)
886
887 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
888 amount allocated this far in `bidi_cache_total_alloc'.
889 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
890 non-zero, only free the data buffer without restoring the cache
891 contents. All callers changed.
892
893 * dispextern.h (bidi_unshelve_cache): Update prototype.
894
895 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
896 (move_it_in_display_line, move_it_to)
897 (move_it_vertically_backward, move_it_by_lines): Replace the call
898 to xfree to an equivalent call to bidi_unshelve_cache.
899 (move_it_in_display_line_to): Fix logic of returning
900 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
901
902 2011-08-05 Eli Zaretskii <eliz@gnu.org>
903
904 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
905 came from a string character with a `cursor' property. (Bug#9229)
906
907 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
908
909 * Makefile.in (LIB_PTHREAD): New variable.
910 (LIBES): Add LIB_PTHREAD (Bug#9216).
911
912 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
913 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
914
915 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
916
917 * regex.c (re_iswctype): Remove some redundant boolean
918 conversions.
919
920 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
921
922 * xterm.c (x_find_topmost_parent): New function.
923 (x_set_frame_alpha): Find topmost parent window with
924 x_find_topmost_parent and set the property there also (bug#9181).
925 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
926
927 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
928
929 * callproc.c (Fcall_process): Avoid vfork clobbering
930 the local vars buffer, coding_systems, current_dir.
931
932 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
933
934 * keymap.c (Fmake_composed_keymap): Move to subr.el.
935
936 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
937
938 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
939 so that it is not optimized away.
940
941 * xdisp.c (compute_display_string_pos): Remove unused local.
942
943 2011-08-02 Eli Zaretskii <eliz@gnu.org>
944
945 Fix slow cursor motion and scrolling in large buffers with
946 selective display, like Org Mode buffers. (Bug#9218)
947
948 * dispextern.h (struct bidi_it): New member disp_prop_p.
949
950 * xdisp.c: Remove one-slot cache of display string positions.
951 (compute_display_string_pos): Accept an additional argument
952 DISP_PROP_P; callers changed. Scan at most 5K characters forward
953 for a display string or property. If found, set DISP_PROP_P
954 non-zero.
955
956 * bidi.c (bidi_fetch_char): Accept an additional argument
957 DISP_PROP_P, and pass it to compute_display_string_pos.
958 Only handle text covered by a display string if DISP_PROP_P is returned
959 non-zero. All callers of bidi_fetch_char changed.
960
961 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
962
963 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
964
965 2010-12-03 Don March <don@ohspite.net>
966
967 * keymap.c (Fdefine_key): Fix non-prefix key error message when
968 last character M-[char] is translated to ESC [char] (bug#7541).
969
970 2011-08-02 Kenichi Handa <handa@m17n.org>
971
972 * lisp.h (uniprop_table): Extern it.
973
974 * chartab.c (uniprop_table): Make it non-static.
975
976 2011-08-01 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (forward_to_next_line_start): Accept additional argument
979 BIDI_IT_PREV, and store into it the state of the bidi iterator had
980 on the newline.
981 (reseat_at_next_visible_line_start): Use the bidi iterator state
982 returned by forward_to_next_line_start to restore the state of
983 it->bidi_it after backing up to previous newline. (Bug#9212)
984
985 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
986
987 * regex.c (re_comp): Protoize.
988 (re_exec): Fix return type.
989 (regexec): Fix type of `ret'. (Bug#9203)
990
991 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
992
993 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
994 This is needed if max-image-size is a floating-point number.
995
996 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
997
998 * print.c (print_object): Print empty symbol as ##.
999
1000 * lread.c (read1): Read ## as empty symbol.
1001
1002 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1003
1004 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1005 setting frame foreground color (Bug#9175).
1006 (x_set_background_color): Likewise.
1007
1008 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1009 contents (Bug#9176).
1010 (EmacsTooltip -init): Remove bezels and add shadows to
1011 tooltip windows.
1012
1013 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1014 or scroll bar (Bug#8470).
1015
1016 * nsfont.m (nsfont_open): Remove assignment to voffset and
1017 unnecessary vars hshink, expand, hd, full_height, min_height.
1018 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1019
1020 * nsterm.h (nsfont_info): Remove voffset field.
1021
1022 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1023
1024 Implement strike-through and overline on NextStep (Bug#8863).
1025
1026 * nsfont.m (nsfont_open): Use underline position provided by font,
1027 instead of hard-coded value of 2.
1028 (nsfont_draw): Call ns_draw_text_decoration instead.
1029
1030 * nsterm.h: Add declaration for ns_draw_text_decoration.
1031
1032 * nsterm.m (ns_draw_text_decoration): New function for drawing
1033 underline, overline, and strike-through.
1034 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1035 ns_draw_text_decoration. Change treatment of cursor drawing to
1036 accomodate underlining, etc.
1037
1038 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1039
1040 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1041 default.
1042
1043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1046 Without this fix, if a signal arrives just after memory fills up,
1047 'malloc' might be invoked reentrantly.
1048
1049 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1050 In other words, assume that every image size is allowed, on non-X
1051 hosts. This assumption is probably wrong, but it lets Emacs compile.
1052
1053 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1054
1055 * regex.c (re_iswctype): Convert return values to boolean.
1056
1057 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1058
1059 * xdisp.c (compute_display_string_pos): Don't use cached display
1060 string position if the buffer had its restriction changed.
1061 (Bug#9184)
1062
1063 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1066
1067 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 Integer signedness and overflow and related fixes. (Bug#9079)
1070
1071 * bidi.c: Integer size and overflow fixes.
1072 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1073 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1074 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1075 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1076 (bidi_find_other_level_edge):
1077 Use ptrdiff_t instead of EMACS_INT where either will do.
1078 This works better on 32-bit hosts configured --with-wide-int.
1079 (bidi_cache_ensure_space): Check for size-calculation overflow.
1080 Use % rather than repeated addition, for better worst-case speed.
1081 Don't set bidi_cache_size until after xrealloc returns, because it
1082 might not return.
1083 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1084 (bidi_cache_ensure_space): Also check that the bidi cache size
1085 does not exceed that of the largest Lisp string or buffer. See Eli
1086 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1087
1088 * alloc.c (__malloc_size_t): Remove.
1089 All uses replaced by size_t. See Andreas Schwab's note
1090 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1091
1092 * image.c: Improve checking for integer overflow.
1093 (check_image_size): Assume that f is nonnull, since
1094 it is always nonnull in practice. This is one less thing to
1095 worry about when checking for integer overflow later.
1096 (x_check_image_size): New function, which checks for integer
1097 overflow issues inside X.
1098 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1099 This removes the need for a memory_full check.
1100 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1101 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1102 (xbm_read_bitmap_data): Change locals back to 'int', since
1103 their values must fit in 'int'.
1104 (xpm_load_image, png_load, tiff_load):
1105 Invoke x_create_x_image_and_pixmap earlier,
1106 to avoid much needless work if the image is too large.
1107 (tiff_load): Treat overly large images as if
1108 x_create_x_image_and_pixmap failed, not as malloc failures.
1109 (gs_load): Use x_check_image_size.
1110
1111 * gtkutil.c: Omit integer casts.
1112 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1113 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1114
1115 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1116
1117 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1118 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1119 would wrongly return t on a 64-bit host.
1120
1121 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1122 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1123 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1124 and therefore cause GCC to emit a bogus diagnostic in some cases.
1125
1126 * image.c: Integer signedness and overflow and related fixes.
1127 This is not an exhaustive set of fixes, but it's time to
1128 record what I've got.
1129 (lookup_pixel_color, check_image_size): Remove redundant decls.
1130 (check_image_size): Don't assume that arbitrary EMACS_INT values
1131 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1132 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1133 (tiff_load, imagemagick_load_image):
1134 Check for overflow in size calculations.
1135 (x_create_x_image_and_pixmap): Remove unnecessary test for
1136 xmalloc returning NULL; that can't happen.
1137 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1138 (xpm_color_bucket): Use better integer hashing function.
1139 (xpm_cache_color): Don't possibly over-allocate memory.
1140 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1141 (gif_memory_source):
1142 Use ptrdiff_t, not int or size_t, to record sizes.
1143 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1144 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1145 either works, as we prefer signed integers.
1146 (tiff_read_from_memory, tiff_write_from_memory):
1147 Return tsize_t, not size_t, since that's what the TIFF API wants.
1148 (tiff_read_from_memory): Don't fail simply because the read would
1149 go past EOF; instead, return a short read.
1150 (tiff_load): Omit no-longer-needed casts.
1151 (Fimagemagick_types): Don't assume size fits into 'int'.
1152
1153 Improve hashing quality when configured --with-wide-int.
1154 * fns.c (hash_string): New function, taken from sxhash_string.
1155 Do not discard information about ASCII character case; this
1156 discarding is no longer needed.
1157 (sxhash-string): Use it. Change sig to match it. Caller changed.
1158 * lisp.h: Declare it.
1159 * lread.c (hash_string): Remove, since we now use fns.c's version.
1160 The fns.c version returns a wider integer if --with-wide-int is
1161 specified, so this should help the quality of the hashing a bit.
1162
1163 * emacs.c: Integer overflow minor fix.
1164 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1165 Define only if GNU_LINUX.
1166 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1167
1168 * dispnew.c: Integer signedness and overflow fixes.
1169 Remove unnecessary forward decls, that were a maintenance hassle.
1170 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1171 All uses changed.
1172 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1173 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1174 (prepare_desired_row, line_draw_cost):
1175 Use int, not unsigned, where either works.
1176 (save_current_matrix, restore_current_matrix):
1177 Use ptrdiff_t, not size_t, where either works.
1178 (init_display): Check for overflow more accurately, and without
1179 relying on undefined behavior.
1180
1181 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1182 Remove, replacing with the new symbols in lisp.h. All uses changed.
1183 * fileio.c (make_temp_name):
1184 * filelock.c (lock_file_1, lock_file):
1185 * xdisp.c (message_dolog):
1186 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1187 Use pMd etc. instead.
1188 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1189 replacing the pWIDE etc. symbols removed from editfns.c.
1190
1191 * keyboard.h (num_input_events): Now uintmax_t.
1192 This is (very slightly) less likely to mess up due to wraparound.
1193 All uses changed.
1194
1195 * buffer.c: Integer signedness fixes.
1196 (alloc_buffer_text, enlarge_buffer_text):
1197 Use ptrdiff_t rather than size_t when either will do, as we prefer
1198 signed integers.
1199
1200 * alloc.c: Integer signedness and overflow fixes.
1201 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1202 (__malloc_size_t): Default to size_t, not to int.
1203 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1204 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1205 Prefer ptrdiff_t to size_t when either would do, as we prefer
1206 signed integers.
1207 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1208 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1209 Now const. Initialize with values that are in range even if char
1210 is signed.
1211 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1212 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1213 These functions do the right thing with sizes > 2**32.
1214 (check_depth): Now ptrdiff_t, not int.
1215 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1216 Adjust to new way of storing sizes. Check for size overflow bugs
1217 in rest of code.
1218 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1219 slightly wrong anyway, as it missed one instance of
1220 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1221 (refill_memory_reserve): Omit needless cast to size_t.
1222 (mark_object_loop_halt): Mark as externally visible.
1223
1224 * xselect.c: Integer signedness and overflow fixes.
1225 (Fx_register_dnd_atom, x_handle_dnd_message):
1226 Use ptrdiff_t, not size_t, since we prefer signed.
1227 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1228 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1229 x_dnd_atoms_size and x_dnd_atoms_length.
1230
1231 * doprnt.c: Prefer signed to unsigned when either works.
1232 * eval.c (verror):
1233 * doprnt.c (doprnt):
1234 * lisp.h (doprnt):
1235 * xdisp.c (vmessage):
1236 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1237 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1238 prefer signed arithmetic to avoid comparison confusion.
1239 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1240 but is a bit tricky.
1241
1242 Assume freestanding C89 headers, string.h, stdlib.h.
1243 * data.c, doprnt.c, floatfns.c, print.c:
1244 Include float.h unconditionally.
1245 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1246 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1247 * regex.c: Likewise for stddef.h, string.h.
1248 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1249 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1250 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1251 (STDC_HEADERS): Remove obsolete defines.
1252 * sysdep.c: Include limits.h unconditionally.
1253
1254 Assume support for memcmp, memcpy, memmove, memset.
1255 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1256 * regex.c (memcmp, memcpy):
1257 Remove; we assume C89 now.
1258
1259 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1260 (__malloc_safe_bcopy): Remove; no longer needed.
1261
1262 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1263 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1264 well either way, and we prefer signed to unsigned.
1265
1266 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1267
1268 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1269 closes the connection while we're reading (bug#9182).
1270
1271 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1272
1273 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1274 are specified (Bug#9168).
1275
1276 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1279 Found by GCC static checking and --with-wide-int on a 32-bit host.
1280
1281 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1282
1283 * xdisp.c (compute_display_string_pos): Fix logic of caching
1284 previous display string position. Initialize cached_prev_pos to
1285 -1. Fixes slow-down at the beginning of a buffer.
1286
1287 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1288
1289 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1290 for attrs[LFACE_FONTSET_INDEX].
1291
1292 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * xml.c (parse_region): Remove unused local
1295 that was recently introduced.
1296
1297 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1298
1299 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1300 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1301
1302 * xdisp.c (move_it_in_display_line_to): Record the best matching
1303 position for TO_CHARPOS while scanning the line, and restore it on
1304 exit if none of the characters scanned was an exact match.
1305 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1306 when exact match is impossible due to invisible text, and the
1307 lines are truncated.
1308
1309 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1310
1311 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1312 for OSX >= 10.7.
1313
1314 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1315
1316 Fix a significant slow-down of cursor motion with C-n, C-p,
1317 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1318 auto-repeat under bidi redisplay in fontified buffers.
1319 * xdisp.c (compute_stop_pos_backwards): New function.
1320 (next_element_from_buffer): Call compute_stop_pos_backwards to
1321 find a suitable prev_stop when we find ourselves before
1322 base_level_stop.
1323 (reseat): Don't look for prev_stop, as that could mean a very long
1324 run.
1325 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1326 <cached_disp_overlay_modiff>: Cache for last found display string
1327 position.
1328 (compute_display_string_pos): Return the cached position if asked
1329 about the same buffer in the same area of character positions, and
1330 the buffer wasn't changed since the time the display string
1331 position was cached.
1332
1333 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1334
1335 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1336 is an integer, which is important for empty lines. (Bug#9149)
1337
1338 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1339
1340 * frame.c (Fmodify_frame_parameters): In tty case, update the
1341 default face if necessary (Bug#4238).
1342
1343 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1344
1345 * editfns.c (Fstring_to_char): No need to explain what a character
1346 is in the docstring (Bug#6576).
1347
1348 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1349
1350 * xml.c (parse_region): Make sure we always return a tree.
1351
1352 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1353
1354 * xml.c (parse_region): If a document contains only comments,
1355 return that, too.
1356
1357 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1358
1359 * xml.c (make_dom): Return comments, too.
1360
1361 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 Port to OpenBSD.
1364 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1365 and the surrounding thread.
1366 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1367 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1368 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1369 timer goes off.
1370 * s/openbsd.h (BROKEN_SIGIO): Define.
1371 * unexelf.c (unexec) [__OpenBSD__]:
1372 Don't update the .mdebug section of the Alpha COFF symbol table.
1373
1374 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1375
1376 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1377 (bug#8460).
1378
1379 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1382 This fixes some race conditions on the permissions of any newly
1383 created file.
1384
1385 * alloc.c (valid_pointer_p): Use pipe, not open.
1386 This fixes some permissions issues when debugging.
1387
1388 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1389 If fchown fails to set both uid and gid, try to set just gid,
1390 as that is sometimes allowed. Adjust the file's mode to eliminate
1391 setuid or setgid bits that are inappropriate if fchown fails.
1392
1393 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1394
1395 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1396 to compare Lisp_Objects.
1397 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1398 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1399 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1400
1401 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1402
1403 * lread.c (read_integer): Unread even EOF character.
1404 (read1): Likewise. Properly record start position of symbol.
1405
1406 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1407 symbol character follows.
1408
1409 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1412 This works around a problem with the previous change to Fcopy_file.
1413 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1414 and without this change, GCC might complain about discarding
1415 fchown's return value.
1416
1417 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1420
1421 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1424
1425 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1426
1427 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1428 it's used from the C level.
1429
1430 * process.c: Use the same condition for POLL_FOR_INPUT in both
1431 keyboard.c and process.c (bug#1858).
1432
1433 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1434
1435 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1436 (Fgnutls_boot): Use it.
1437
1438 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * doc.c (Fsubstitute_command_keys): Revert last change.
1441
1442 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443
1444 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1445 quotes the next character, and doesn't affect other longer
1446 sequences (bug#8935).
1447
1448 * lread.c (syms_of_lread): Clarify that is isn't only
1449 `eval-buffer' and `eval-defun' that's affected by
1450 `lexical-binding' (bug#8460).
1451
1452 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1453
1454 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1455 bidi redisplay when a line includes both an image and is
1456 truncated.
1457
1458 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 Fix minor problems found by static checking.
1461 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1462 (elsz): Now a signed constant, not a size_t var. We prefer signed
1463 types to unsigned, to avoid integer comparison confusion. Without
1464 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1465 "cannot optimize loop, the loop counter may overflow", a symptom
1466 of the confusion.
1467 * indent.c (Fvertical_motion): Mark locals as initialized.
1468 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1469
1470 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1471
1472 * search.c (Fre_search_backward): Mention `case-fold-search' in
1473 all the re_search_* functions (bug#8138).
1474
1475 * keyboard.c (Fopen_dribble_file): Document when the file is
1476 closed (bug#8056).
1477
1478 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1479
1480 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1481 bidi_cache_idx.
1482
1483 Support bidi reordering of display and overlay strings.
1484 * xdisp.c (compute_display_string_pos)
1485 (compute_display_string_end): Accept additional argument STRING.
1486 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1487 (reseat_to_string): Initialize bidi_it->string.s and
1488 bidi_it->string.schars.
1489 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1490 NULL (avoids a crash in bidi_paragraph_init).
1491 Initialize itb.string.lstring.
1492 (init_iterator): Call bidi_init_it only of a valid
1493 buffer position was specified. Initialize paragraph_embedding to
1494 L2R.
1495 (reseat_to_string): Initialize the bidi iterator.
1496 (display_string): If we need to ignore text properties of
1497 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1498 original value of -1 will not work with bidi.)
1499 (compute_display_string_pos): First arg is now struct
1500 `text_pos *'; all callers changed. Support display properties on
1501 Lisp strings.
1502 (compute_display_string_end): Support display properties on Lisp
1503 strings.
1504 (init_iterator, reseat_1, reseat_to_string): Initialize the
1505 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1506 when iterating on a string not from display properties).
1507 (compute_display_string_pos, compute_display_string_end):
1508 Fix calculation of the object to scan. Fixes an error when using
1509 arrow keys.
1510 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1511 base_level_stop; instead, set base_level_stop to BEGV.
1512 Fixes crashes in vertical-motion.
1513 (next_element_from_buffer): Improve commentary for when
1514 the iterator is before prev_stop.
1515 (init_iterator): Initialize bidi_p from the default value of
1516 bidi-display-reordering, not from buffer-local value. Use the
1517 buffer-local value only if initializing for buffer iteration.
1518 (handle_invisible_prop): Support invisible properties on strings
1519 that are being bidi-reordered.
1520 (set_iterator_to_next): Support bidi reordering of C strings and
1521 Lisp strings.
1522 (next_element_from_string): Support bidi reordering of Lisp
1523 strings.
1524 (handle_stop_backwards): Support Lisp strings as well.
1525 (display_string): Support display of R2L glyph rows.
1526 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1527 (init_iterator): Don't initialize it->bidi_p for strings
1528 here.
1529 (reseat_to_string): Initialize it->bidi_p for strings here.
1530 (next_element_from_string, next_element_from_c_string)
1531 (next_element_from_buffer): Add xassert's for correspondence
1532 between IT's object being iterated and it->bidi_it.string
1533 structure.
1534 (face_before_or_after_it_pos): Support bidi iteration.
1535 (next_element_from_c_string): Handle the case of the first string
1536 character that is not the first one in the visual order.
1537 (get_visually_first_element): New function, refactored from common
1538 parts of next_element_from_buffer, next_element_from_string, and
1539 next_element_from_c_string.
1540 (tool_bar_lines_needed, redisplay_tool_bar)
1541 (display_menu_bar): Force left-to-right direction. Add a FIXME
1542 comment for making that be controlled by a user option.
1543 (push_it, pop_it): Save and restore the state of the
1544 bidi iterator. Save and restore the bidi_p flag.
1545 (pop_it): Iterate out of display property for string iteration as
1546 well.
1547 (iterate_out_of_display_property): Support iteration over strings.
1548 (handle_single_display_spec): Set up it->bidi_it for iteration
1549 over a display string, and call bidi_init_it.
1550 (handle_single_display_spec, next_overlay_string)
1551 (get_overlay_strings_1, push_display_prop): Set up the bidi
1552 iterator for displaying display or overlay strings.
1553 (forward_to_next_line_start): Don't use the shortcut if
1554 bidi-iterating.
1555 (back_to_previous_visible_line_start): If handle_display_prop
1556 pushed the iterator stack, restore the internal state of the bidi
1557 iterator by calling bidi_pop_it same number of times.
1558 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1559 and we are bidi-iterating, don't decrement the iterator position;
1560 instead, set the first_elt flag in the bidi iterator, to produce
1561 the same effect.
1562 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1563 (push_display_prop): xassert that we are iterating a buffer.
1564 (push_it, pop_it): Save and restore paragraph_embedding member.
1565 (handle_single_display_spec, next_overlay_string)
1566 (get_overlay_strings_1, reseat_1, reseat_to_string)
1567 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1568 correctly. Don't assume unibyte strings are not bidi-reordered.
1569 (compute_display_string_pos)
1570 (compute_display_string_end): Fix handling the case of C string.
1571 (push_it, pop_it): Save and restore from_disp_prop_p.
1572 (handle_single_display_spec, push_display_prop): Set the
1573 from_disp_prop_p flag.
1574 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1575 (pop_it): Call iterate_out_of_display_property only if we are
1576 popping after iteration over a string that came from a display
1577 property. Fix a typo in popping stretch info. Add an assertion
1578 for verifying that the iterator position is in sync with the bidi
1579 iterator.
1580 (handle_single_display_spec, get_overlay_strings_1)
1581 (push_display_prop): Fix initialization of paragraph direction for
1582 string when that of the parent object is not yet determined.
1583 (reseat_1): Call bidi_init_it to resync the bidi
1584 iterator with IT's position. (Bug#7616)
1585 (find_row_edges): If ROW->start.pos gives position
1586 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1587 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1588 Reset the from_disp_prop_p flag.
1589 (SAVE_IT, RESTORE_IT): New macros.
1590 (pos_visible_p, face_before_or_after_it_pos)
1591 (back_to_previous_visible_line_start)
1592 (move_it_in_display_line_to, move_it_in_display_line)
1593 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1594 (try_scrolling, redisplay_window, display_line): Use them when
1595 saving a temporary copy of the iterator and restoring it back.
1596 (back_to_previous_visible_line_start, reseat_1)
1597 (init_iterator): Empty the bidi cache "stack".
1598 (move_it_in_display_line_to): If iterator ended up at
1599 EOL, but we never saw any buffer positions smaller than
1600 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1601 motion in bidi-reordered lines.
1602 (move_it_in_display_line_to): Record prev_method and prev_pos
1603 immediately before the call to set_iterator_to_next. Fixes cursor
1604 motion in bidi-reordered lines with stretch glyphs and strings
1605 displayed in margins. (Bug#8133) (Bug#8867)
1606 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1607 TO_CHARPOS.
1608 (pos_visible_p): Support positions in bidi-reordered lines.
1609 Save and restore bidi cache.
1610
1611 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1612 (bidi_paragraph_info): Delete unused struct.
1613 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1614 (bidi_cache_start): New variable.
1615 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1616 to zero.
1617 (bidi_cache_fetch_state, bidi_cache_search)
1618 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1619 (bidi_cache_find, bidi_peek_at_next_level)
1620 (bidi_level_of_next_char, bidi_find_other_level_edge)
1621 (bidi_move_to_visually_next): Compare cache index with
1622 bidi_cache_start rather than with zero.
1623 (bidi_fetch_char): Accept new argument STRING; all callers
1624 changed. Support iteration over a string. Support strings with
1625 display properties. Support unibyte strings. Fix the type of
1626 `len' according to what STRING_CHAR_AND_LENGTH expects.
1627 (bidi_paragraph_init, bidi_resolve_explicit_1)
1628 (bidi_resolve_explicit, bidi_resolve_weak)
1629 (bidi_level_of_next_char, bidi_move_to_visually_next):
1630 Support iteration over a string.
1631 (bidi_set_sor_type, bidi_resolve_explicit_1)
1632 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1633 can now be zero (for strings); special values 0 and -1 were
1634 changed to -1 and -2, respectively.
1635 (bidi_char_at_pos): New function.
1636 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1637 Call it instead of FETCH_MULTIBYTE_CHAR.
1638 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1639 initialized to valid values.
1640 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1641 values.
1642 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1643 the test for valid cached positions. Fix the logic for looking up
1644 the sentinel state in the cache. GCPRO the Lisp string we are
1645 iterating.
1646 (bidi_push_it, bidi_pop_it): New functions.
1647 (bidi_initialize): Initialize the bidi cache start stack pointer.
1648 (bidi_cache_ensure_space): New function, refactored from part of
1649 bidi_cache_iterator_state. Don't assume the required size is just
1650 one BIDI_CACHE_CHUNK away.
1651 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1652 (bidi_count_bytes, bidi_char_at_pos): New functions.
1653 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1654 always valid if bidi_cache_idx is valid.
1655 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1656 is valid if it's going to be used.
1657 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1658 (bidi_cache_fetch_state, bidi_cache_search)
1659 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1660 (bidi_cache_iterator_state, bidi_cache_find)
1661 (bidi_find_other_level_edge, bidi_cache_start_stack):
1662 All variables related to cache indices are now EMACS_INT.
1663
1664 * dispextern.h (struct bidi_string_data): New structure.
1665 (struct bidi_it): New member `string'. Make flag members be 1-bit
1666 fields, and put them last in the struct.
1667 (compute_display_string_pos, compute_display_string_end):
1668 Update prototypes.
1669 (bidi_push_it, bidi_pop_it): Add prototypes.
1670 (struct iterator_stack_entry): New members bidi_p,
1671 paragraph_embedding, and from_disp_prop_p.
1672 (struct it): Member bidi_p is now a bit field 1 bit wide.
1673 (bidi_shelve_cache, bidi_unshelve_cache):
1674 Declare prototypes.
1675
1676 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1677 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1678 and vector-like objects.
1679
1680 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1681 cache around display iteration.
1682
1683 * window.c (Fwindow_end, window_scroll_pixel_based)
1684 (displayed_window_lines, Frecenter): Save and restore the bidi
1685 cache around display iteration.
1686
1687 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1688
1689 * editfns.c (Fdelete_region): Clarify the use of the named
1690 parameters (bug#6788).
1691
1692 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1693
1694 * indent.c (Fvertical_motion): Set and restore w->pointm when
1695 saving and restoring the window's buffer (Bug#9006).
1696
1697 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698
1699 * editfns.c (Fstring_to_char): Clarify just what is returned
1700 (bug#6576). Text by Eli Zaretskii.
1701
1702 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1703
1704 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1705
1706 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1707
1708 * buffer.c (mmap_find): Fix a typo.
1709
1710 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1711
1712 Fix execution of x selection hooks.
1713 * xselect.c (Qx_lost_selection_functions)
1714 (Qx_sent_selection_functions): New vars.
1715 (syms_of_xselect): DEFSYM them.
1716 (x_handle_selection_request): Pass Qx_sent_selection_functions
1717 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1718 (x_handle_selection_clear,x_clear_frame_selections):
1719 Pass Qx_lost_selection_functions rather than
1720 Vx_lost_selection_functions to Frun_hook_with_args.
1721
1722 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1725 The old code sometimes used this field without initializing it.
1726
1727 * alloc.c (gc_sweep): Don't read past end of array.
1728 In theory, the old code could also have corrupted Emacs internals,
1729 though it'd be very unlikely.
1730
1731 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1732
1733 * character.c (Fcharacterp): Don't advertise optional ignored
1734 argument. (Bug#4026)
1735
1736 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1737
1738 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1739 key" (bug#4257).
1740
1741 * window.c (Fset_window_start): Doc fix (bug#4199).
1742 (Fset_window_hscroll): Ditto.
1743
1744 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Fix minor new problems caught by GCC 4.6.1.
1747 * term.c (init_tty): Remove unused local.
1748 * xsettings.c (store_monospaced_changed): Define this function only
1749 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1750 not used otherwise.
1751
1752 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1753
1754 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1755
1756 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1757
1758 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1759 are the mini-buffer and the echo area (bug#3320).
1760
1761 * term.c (init_tty): Remove support for supdup, c10 and perq
1762 terminals, which are no longer supported (bug#1482).
1763
1764 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1765
1766 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1767
1768 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1769
1770 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1771 for non-popups (Bug#3642).
1772
1773 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1774
1775 * alloc.c (reset_malloc_hooks): Protoize.
1776 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1777 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1778 * cm.c (losecursor): Likewise.
1779 * data.c (fmod): Likewise.
1780 * dispnew.c (swap_glyphs_in_rows): Likewise.
1781 * emacs.c (memory_warning_signal): Likewise.
1782 * floatfns.c (float_error): Likewise.
1783 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1784 (otf_open, font_otf_capability, generate_otf_features)
1785 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1786 Likewise.
1787 * image.c (pbm_read_file): Likewise.
1788 * indent.c (string_display_width): Likewise.
1789 * intervals.c (check_for_interval, search_for_interval)
1790 (inc_interval_count, count_intervals, root_interval)
1791 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1792 * lread.c (defalias): Likewise.
1793 * ralloc.c (r_alloc_check): Likewise.
1794 * regex.c (set_image_of_range_1, set_image_of_range)
1795 (regex_grow_registers): Likewise.
1796 * sysdep.c (strerror): Likewise.
1797 * termcap.c (valid_filename_p, tprint, main): Likewise.
1798 * tparam.c (main): Likewise.
1799 * unexhp9k800.c (run_time_remap, save_data_space)
1800 (update_file_ptrs, read_header, write_header, calculate_checksum)
1801 (copy_file, copy_rest, display_header): Likewise.
1802 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1803 Likewise.
1804 * xdisp.c (check_it): Likewise.
1805 * xfaces.c (register_color, unregister_color, unregister_colors):
1806 Likewise.
1807 * xfns.c (print_fontset_result): Likewise.
1808 * xrdb.c (member, fatal, main): Likewise.
1809
1810 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 Fix minor problems found by static checking (Bug#9031).
1813 * chartab.c (char_table_set_range, map_sub_char_table):
1814 Remove unused locals.
1815 (uniprop_table): Now static.
1816 * composite.c (_work_char): Remove unused static var.
1817
1818 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1821
1822 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1823
1824 * gtkutil.c (qttip_cb): Remove code without function.
1825
1826 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1827
1828 * w32.c (pthread_sigmask): New stub.
1829
1830 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 Use pthread_sigmask, not sigprocmask (Bug#9010).
1833 sigprocmask is portable only for single-threaded applications, and
1834 Emacs can be multi-threaded when it uses GTK.
1835 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1836 (LIBES): Use it.
1837 * callproc.c (Fcall_process):
1838 * process.c (create_process):
1839 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1840 Use pthread_sigmask, not sigprocmask.
1841
1842 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1843
1844 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1845 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1846 wrong (Bug#8591).
1847
1848 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1849
1850 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1851 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1852 (xg_hide_tooltip): Fix comment.
1853
1854 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1855 in registerServicesMenuSendTypes.
1856 (validRequestorForSendType): Don't check ns_return_types.
1857
1858 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1859 ns_return_type.
1860
1861 2011-07-08 Jason Rumney <jasonr@gnu.org>
1862
1863 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1864 frame struct members of non-existent frames (Bug#6284).
1865
1866 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1867
1868 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1869 variable firstTime not needed on OSX >= 10.6.
1870 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1871 >= 10.5. Use setKnobProportion, setDoubleValue.
1872
1873 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1874 (MAC_OS_X_VERSION_10_5): Define if not defined.
1875 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1876 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1877 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1878
1879 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1880 cString and lossyCString on OSX >= 10.4
1881
1882 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1883 sizeToFit on OSX >= 10.2.
1884
1885 * nsimage.m (allocInitFromFile): Don't use deprecated method
1886 bestRepresentationForDevice on OSX >= 10.6.
1887
1888 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1889 to avoid warning.
1890
1891 * emacs.c: Declare unexec_init_emacs_zone.
1892
1893 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1894
1895 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1896
1897 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1898 on svcsMenu (Bug#8842).
1899
1900 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1901 ns_return_types.
1902 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1903
1904 * nsterm.m (QUTF8_STRING): Declare.
1905 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1906 (validRequestorForSendType): Return type is (id).
1907 Change indexOfObjectIdenticalTo to indexOfObject.
1908 Check if we have local selection before returning self (Bug#8842).
1909 (writeSelectionToPasteboard): Put local selection into paste board
1910 if we have a local selection (Bug#8842).
1911 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1912
1913 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1914 (ns_get_local_selection): Declare.
1915
1916 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1917
1918 * keymap.c (describe_map_tree): Don't insert a double newline at
1919 the end of the buffer (bug#1169) and return whether we inserted
1920 something.
1921
1922 * callint.c (Fcall_interactively): Change "reading args" to
1923 "providing args" to try to clarify what it does (bug#1010).
1924
1925 2011-07-07 Kenichi Handa <handa@m17n.org>
1926
1927 * composite.c (composition_compute_stop_pos): Ignore a static
1928 composition starting before CHARPOS (Bug#8915).
1929
1930 * xdisp.c (handle_composition_prop): Likewise.
1931
1932 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1933
1934 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1935 (Bug#9015)
1936
1937 2011-07-07 Kenichi Handa <handa@m17n.org>
1938
1939 * character.h (unicode_category_t): New enum type.
1940
1941 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1942 (Qchar_code_property_table): New variable.
1943 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1944 (UNIPROP_COMPRESSED_FORM_P): New macros.
1945 (char_table_ascii): Uncompress the compressed values.
1946 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1947 Uncompress the compressed values.
1948 (sub_char_table_ref_and_range): Likewise.
1949 (char_table_ref_and_range): Uncompress the compressed values.
1950 (sub_char_table_set): New arg is_uniprop. Callers changed.
1951 Uncompress the compressed values.
1952 (sub_char_table_set_range): Args changed. Callers changed.
1953 (char_table_set_range): Adjuted for the above change.
1954 (map_sub_char_table): Delete args default_val and parent. Add arg
1955 top. Give decoded values to a Lisp function.
1956 (map_char_table): Adjust for the above change. Give decoded
1957 values to a Lisp function. Gcpro more variables.
1958 (uniprop_table_uncompress)
1959 (uniprop_decode_value_run_length): New functions.
1960 (uniprop_decoder, uniprop_decoder_count): New variables.
1961 (uniprop_get_decoder, uniprop_encode_value_character)
1962 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1963 New functions.
1964 (uniprop_encoder, uniprop_encoder_count): New variables.
1965 (uniprop_get_encoder, uniprop_table)
1966 (Funicode_property_table_internal, Fget_unicode_property_internal)
1967 (Fput_unicode_property_internal): New functions.
1968 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1969 Sunicode_property_table_internal, Sget_unicode_property_internal,
1970 and Sput_unicode_property_internal. Defvar_lisp
1971 char-code-property-alist.
1972
1973 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1974 Vunicode_category_table.
1975
1976 * font.c (font_range): Adjust for the change of
1977 Vunicode_category_table.
1978
1979 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1980
1981 * m/iris4d.h: Remove file, move contents ...
1982 * s/irix6-5.h: ... here.
1983
1984 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 Remove unportable assumption about struct layout (Bug#8884).
1987 * alloc.c (mark_buffer):
1988 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1989 (clone_per_buffer_values): Don't assume that
1990 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1991 This isn't true in general, and it's particularly not true
1992 if Emacs is configured with --with-wide-int.
1993 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1994 New macros, used in the buffer.c change.
1995
1996 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1997
1998 * xsettings.c: Use both GConf and GSettings if both are available.
1999 (store_config_changed_event): Add comment.
2000 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2001 (store_tool_bar_style_changed): New functions.
2002 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2003 (struct xsettings): Move font inside HAVE_XFT.
2004 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2005 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2006 Move inside HAVE_XFT.
2007 (something_changed_gsettingsCB): Rename from something_changedCB.
2008 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2009 also.
2010 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2011 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2012 (something_changed_gconfCB): Rename from something_changedCB.
2013 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2014 (parse_settings): Move check for font inside HAVE_XFT.
2015 (read_settings, apply_xft_settings): Add comment.
2016 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2017 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2018 call store_font_name_changed.
2019 (xft_settings_event): Add comment.
2020 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2021 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2022 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2023 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2024 (xsettings_initialize): Call init_gsettings last.
2025 (xsettings_get_system_font, xsettings_get_system_normal_font):
2026 Add comment.
2027
2028 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 Random fixes. E.g., (random) never returned negative values.
2031 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2032 subseconds part to the entropy, as that's a bit more random.
2033 Prefer signed to unsigned, since the signedness doesn't matter and
2034 in general we prefer signed. When given a limit, use a
2035 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2036 latter isn't right if USE_2_TAGS_FOR_INTS.
2037 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2038 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2039
2040 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2041
2042 * textprop.c (text_property_stickiness):
2043 Obey Vtext_property_default_nonsticky.
2044 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2045 * w32fns.c (syms_of_w32fns):
2046 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2047
2048 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2051 This is more efficient than Ffile_directory_p and avoids a minor race.
2052
2053 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2054
2055 * buffer.c (Foverlay_put): Say what the return value is
2056 (bug#7835).
2057
2058 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2059 is a directory before asking whether to use the file name
2060 (bug#7564).
2061 (barf_or_query_if_file_exists): Make the "File is a directory"
2062 error be more correct.
2063
2064 * fns.c (Frequire): Remove the mention of the .gz files, since
2065 that's installation-specific, but keep the mention of
2066 `get-load-suffixes'.
2067
2068 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2071 Report string overflow if the output is too long.
2072
2073 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2076 (syms_of_gnutls): Remove duplicate DEFSYM for
2077 Qgnutls_bootprop_verify_hostname_error, an error for
2078 Qgnutls_bootprop_verify_error (which is no longer used).
2079
2080 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2081 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2082 Also (re)move comments that are misplaced or no longer relevant.
2083
2084 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2085
2086 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2087
2088 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2089
2090 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2091 and background color parameters if they have been changed.
2092
2093 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2094
2095 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2096
2097 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * xsettings.c (SYSTEM_FONT): Define only when used.
2100 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2101
2102 * keymap.c (access_keymap_1): Now static.
2103
2104 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2105
2106 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2107 leave any prefix arg for the up event (Bug#1586).
2108
2109 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2110
2111 * lread.c (syms_of_lread): Mention single symbols defined by
2112 `defvar' or `defconst' (bug#7154).
2113
2114 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2115 (Frequire): Mention get-load-suffixes.
2116
2117 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2118
2119 * window.h (window): Remove clone_number slot.
2120 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2121 Remove.
2122 (make_parent_window, make_window, saved_window)
2123 (Fset_window_configuration, save_window_save): Don't deal with
2124 clone numbers.
2125 * buffer.c (Qclone_number): Remove declaration.
2126 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2127
2128 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2129
2130 Add multiple inheritance to keymaps.
2131 * keymap.c (Fmake_composed_keymap): New function.
2132 (Fset_keymap_parent): Simplify.
2133 (fix_submap_inheritance): Remove.
2134 (access_keymap_1): New function extracted from access_keymap to handle
2135 embedded parents and handle lists of maps.
2136 (access_keymap): Use it.
2137 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2138 (Fcopy_keymap): Handle embedded parents.
2139 (Fcommand_remapping, define_as_prefix): Simplify.
2140 (Fkey_binding): Simplify.
2141 (syms_of_keymap): Move minibuffer-local-completion-map,
2142 minibuffer-local-filename-completion-map,
2143 minibuffer-local-must-match-map, and
2144 minibuffer-local-filename-must-match-map to Elisp.
2145 (syms_of_keymap): Defsubr make-composed-keymap.
2146 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2147 (parse_menu_item): Trivial simplification.
2148
2149 2011-07-01 Glenn Morris <rgm@gnu.org>
2150
2151 * Makefile.in (SETTINGS_LIBS): Fix typo.
2152
2153 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2154
2155 * coding.c (Fencode_coding_string): Record the last coding system
2156 used, as the function doc string says (bug#8738).
2157
2158 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2159
2160 * xsettings.c (store_monospaced_changed): Take new font as arg and
2161 check for change against current_mono_font.
2162 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2163 (emacs_settings_constructor, emacs_settings_get_property)
2164 (emacs_settings_set_property, emacs_settings_class_init)
2165 (emacs_settings_init, gsettings_obj): Remove.
2166 (something_changedCB): New function for HAVE_GSETTINGS.
2167 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2168 with value as argument.
2169 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2170 g_settings_new (Bug#8967). Do not create gsettings_obj.
2171 Remove calls to g_settings_bind. Connect something_changedCB to
2172 "changed".
2173
2174 * xgselect.c: Add defined (HAVE_GSETTINGS).
2175 (xgselect_initialize): Ditto.
2176
2177 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2178 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2179 xg_select.
2180
2181 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * eval.c (struct backtrace): Simplify and port the data structure.
2184 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2185 signed bit field, as this assumption is not portable and it makes
2186 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2187 "char debug_on_exit : 1" as this is not portable either; instead,
2188 use the portable "unsigned int debug_on_exit : 1". Remove unused
2189 member evalargs. Remove obsolete comments about cc bombing out.
2190
2191 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2192
2193 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2194 Let HAVE_GSETTINGS override HAVE_GCONF.
2195 (store_monospaced_changed): New function.
2196 (EMACS_SETTINGS): A new type derived from GObject to handle
2197 GSettings notifications.
2198 (emacs_settings_constructor, emacs_settings_get_property)
2199 (emacs_settings_set_property, emacs_settings_class_init):
2200 New functions.
2201 (gsettings_client, gsettings_obj): New variables.
2202 (GSETTINGS_SCHEMA): New define.
2203 (something_changedCB): Call store_monospaced_changed.
2204 (init_gsettings): New function.
2205 (xsettings_initialize): Call init_gsettings.
2206 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2207 to NULL.
2208
2209 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2210 GCONF_CFLAGS/LIBS.
2211
2212 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2213
2214 * window.c (resize_root_window, grow_mini_window)
2215 (shrink_mini_window): Rename Qresize_root_window to
2216 Qwindow_resize_root_window and Qresize_root_window_vertically to
2217 Qwindow_resize_root_window_vertically.
2218
2219 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2222
2223 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * makefile.w32-in: Redesign dependencies so they reflect more
2226 clearly which files are directly included by each source file,
2227 and not through other includes.
2228
2229 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2230
2231 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2232 (sort_overlays, overlay_strings): When an overlay's clone number
2233 matches the window's clone number process the overlay even if
2234 the overlay's window property doesn't match the current window.
2235
2236 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2237 (Fwindow_hchild): Rename to Fwindow_left_child.
2238 (Fwindow_next): Rename to Fwindow_next_sibling.
2239 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2240 (resize_window_check): Rename to window_resize_check.
2241 (resize_window_apply): Rename to window_resize_apply.
2242 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2243 (Fdelete_other_windows_internal, resize_frame_windows)
2244 (Fsplit_window_internal, Fdelete_window_internal)
2245 (grow_mini_window, shrink_mini_window)
2246 (Fresize_mini_window_internal): Fix callers accordingly.
2247
2248 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2249
2250 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2251 (emacs_fixed_set_min_size): Remove.
2252 (emacs_fixed_new): Take frame as argument.
2253
2254 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2255 (_EmacsFixedPrivate): Remove minwidth/height.
2256 Add struct frame *f.
2257 (emacs_fixed_init): Initialize priv->f.
2258 (get_parent_class, emacs_fixed_set_min_size): Remove.
2259 (emacs_fixed_new): Set priv->f to argument.
2260 (emacs_fixed_get_preferred_width)
2261 (emacs_fixed_get_preferred_height): Use min_width/height from
2262 frames size_hint to set minimum and natural (Bug#8919).
2263 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2264 and use min_width/height from frames size_hint to set
2265 min_width/height (Bug#8919).
2266
2267 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2268 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2269 Fix indentation.
2270
2271 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2272
2273 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2274 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2275 called at ZV.
2276
2277 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2278
2279 * process.c (wait_reading_process_output): Bypass select if
2280 waiting for a cell while ignoring keyboard input, and input is
2281 pending. Suggested by Jan Djärv (Bug#8869).
2282
2283 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2284
2285 Use gnulib's dup2 module instead of rolling our own.
2286 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2287
2288 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2289
2290 * dispnew.c (scrolling_window): Before scrolling, turn off a
2291 mouse-highlight in the window being scrolled.
2292
2293 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2294
2295 Move DEFSYM to lisp.h and use everywhere.
2296
2297 * character.h (DEFSYM): Move declaration...
2298 * lisp.h (DEFSYM): ...here.
2299
2300 * gnutls.c:
2301 * minibuf.c:
2302 * w32menu.c:
2303 * w32proc.c:
2304 * w32select.c: Don't include character.h.
2305
2306 * alloc.c (syms_of_alloc):
2307 * buffer.c (syms_of_buffer):
2308 * bytecode.c (syms_of_bytecode):
2309 * callint.c (syms_of_callint):
2310 * casefiddle.c (syms_of_casefiddle):
2311 * casetab.c (init_casetab_once):
2312 * category.c (init_category_once, syms_of_category):
2313 * ccl.c (syms_of_ccl):
2314 * cmds.c (syms_of_cmds):
2315 * composite.c (syms_of_composite):
2316 * dbusbind.c (syms_of_dbusbind):
2317 * dired.c (syms_of_dired):
2318 * dispnew.c (syms_of_display):
2319 * doc.c (syms_of_doc):
2320 * editfns.c (syms_of_editfns):
2321 * emacs.c (syms_of_emacs):
2322 * eval.c (syms_of_eval):
2323 * fileio.c (syms_of_fileio):
2324 * fns.c (syms_of_fns):
2325 * frame.c (syms_of_frame):
2326 * fringe.c (syms_of_fringe):
2327 * insdel.c (syms_of_insdel):
2328 * keymap.c (syms_of_keymap):
2329 * lread.c (init_obarray, syms_of_lread):
2330 * macros.c (syms_of_macros):
2331 * msdos.c (syms_of_msdos):
2332 * print.c (syms_of_print):
2333 * process.c (syms_of_process):
2334 * search.c (syms_of_search):
2335 * sound.c (syms_of_sound):
2336 * syntax.c (init_syntax_once, syms_of_syntax):
2337 * terminal.c (syms_of_terminal):
2338 * textprop.c (syms_of_textprop):
2339 * undo.c (syms_of_undo):
2340 * w32.c (globals_of_w32):
2341 * window.c (syms_of_window):
2342 * xdisp.c (syms_of_xdisp):
2343 * xfaces.c (syms_of_xfaces):
2344 * xfns.c (syms_of_xfns):
2345 * xmenu.c (syms_of_xmenu):
2346 * xsettings.c (syms_of_xsettings):
2347 * xterm.c (syms_of_xterm): Use DEFSYM.
2348
2349 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2350
2351 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2352
2353 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 Integer and buffer overflow fixes (Bug#8873).
2356
2357 * print.c (printchar, strout): Check for string overflow.
2358 (PRINTPREPARE, printchar, strout):
2359 Don't set size unless allocation succeeds.
2360
2361 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2362 for sizes. Check for string overflow more accurately.
2363 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2364
2365 * macros.c: Integer and buffer overflow fixes.
2366 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2367 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2368 Use ptrdiff_t, not int, for sizes.
2369 Don't increment bufsize until after realloc succeeds.
2370 Check for size-calculation overflow.
2371 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2372
2373 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2374
2375 * lread.c: Integer overflow fixes.
2376 (read_integer): Radix is now EMACS_INT, not int,
2377 to improve quality of diagnostics for out-of-range radices.
2378 Calculate buffer size correctly for out-of-range radices.
2379 (read1): Check for integer overflow in radices, and in
2380 read-circle numbers.
2381 (read_escape): Avoid int overflow.
2382 (Fload, openp, read_buffer_size, read1)
2383 (substitute_object_recurse, read_vector, read_list, map_obarray):
2384 Use ptrdiff_t, not int, for sizes.
2385 (read1): Use EMACS_INT, not int, for sizes.
2386 Check for size overflow.
2387
2388 * image.c (cache_image): Check for size arithmetic overflow.
2389
2390 * lread.c: Integer overflow issues.
2391 (saved_doc_string_size, saved_doc_string_length)
2392 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2393 Now ptrdiff_t, not int.
2394 (read1): Don't assume doc string length fits in int. Check for
2395 out-of-range doc string lengths.
2396 (read_list): Don't assume file position fits in int.
2397 (read_escape): Check for hex character overflow.
2398
2399 2011-06-22 Leo Liu <sdl.web@gmail.com>
2400
2401 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2402 Move to minibuffer.el.
2403
2404 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2407 The following patches are for when GLYPH_DEBUG && !XASSERT.
2408 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2409 * dispnew.c (flush_stdout):
2410 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2411 Mark as externally visible.
2412 * dispnew.c (check_window_matrix_pointers): Now static.
2413 * dispnew.c (window_to_frame_vpos):
2414 * xfns.c (unwind_create_frame):
2415 * xterm.c (x_check_font): Remove unused local.
2416 * scroll.c (CHECK_BOUNDS):
2417 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2418 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2419 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2420 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2421 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2422 Now static.
2423 (debug_method_add): Use va_list and vsprintf rather than relying
2424 on undefined behavior with wrong number of arguments.
2425 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2426 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2427 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2428 since we're not interested in debugging glyphs with old libraries.
2429 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2430 GCC 4.6.0's static checking.
2431
2432 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Integer overflow and signedness fixes (Bug#8873).
2435 A few related buffer overrun fixes, too.
2436
2437 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2438
2439 * dispextern.h (struct face.stipple):
2440 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2441 (x_bitmap_mask, x_allocate_bitmap_record)
2442 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2443 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2444 (x_create_bitmap_from_xpm_data):
2445 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2446 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2447 (.bitmaps_last):
2448 * xfaces.c (load_pixmap):
2449 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2450 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2451 (.bitmaps_last, struct x_output.icon_bitmap):
2452 Use ptrdiff_t, not int, for bitmap indexes.
2453 (x_allocate_bitmap_record): Check for size overflow.
2454 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2455
2456 Use ptrdiff_t, not int, for overlay counts.
2457 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2458 * editfns.c (overlays_around, get_pos_property):
2459 * textprop.c (get_char_property_and_overlay):
2460 * xdisp.c (next_overlay_change, note_mouse_highlight):
2461 * xfaces.c (face_at_buffer_position):
2462 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2463 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2464 (Fnext_overlay_change, Fprevious_overlay_change)
2465 (mouse_face_overlay_overlaps, Foverlays_in):
2466 Use ptrdiff_t, not int, for sizes.
2467 (overlays_at, overlays_in): Check for size-calculation overflow.
2468
2469 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2470
2471 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2472 (x_session_initialize): Do not assume string length fits in int.
2473
2474 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2475 This is unlikely, but can occur if DPI is outlandish.
2476
2477 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2478 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2479
2480 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2481 * xrdb.c (magic_file_p, search_magic_path):
2482 Omit last arg SUFFIX; it was always 0. All callers changed.
2483 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2484
2485 * xfont.c (xfont_match): Avoid need for strlen.
2486
2487 * xfns.c: Don't assume strlen fits in int.
2488 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2489
2490 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2491 not unsigned long, as we prefer signed integers. All callers changed.
2492 Detect integer overflow in repeat count.
2493 (message_dolog): Don't assume print length fits in 39 bytes.
2494 (display_mode_element): Don't assume strlen fits in int.
2495
2496 * termcap.c: Don't assume sizes fit in int and never overflow.
2497 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2498 (gobble_line): Check for size-calculation overflow.
2499
2500 * minibuf.c (Fread_buffer):
2501 * lread.c (intern, intern_c_string):
2502 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2503 Don't assume string length fits in int.
2504
2505 * keyboard.c (parse_tool_bar_item):
2506 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2507
2508 * font.c: Don't assume string length fits in int.
2509 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2510 Use ptrdiff_t, not int.
2511 (font_intern_prop): Don't assume string length fits in int.
2512 Don't assume integer property fits in fixnum.
2513 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2514
2515 * filelock.c: Fix some buffer overrun and integer overflow issues.
2516 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2517 Reformulate so as not to need the command string.
2518 Invoke gzip -cd rather than gunzip, as it's more portable.
2519 (lock_info_type, lock_file_1, lock_file):
2520 Don't assume pid_t and time_t fit in unsigned long.
2521 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2522 (current_lock_owner): Prefer signed type for sizes.
2523 Use memcpy, not strncpy, where memcpy is what is really wanted.
2524 Don't assume (via atoi) that time_t and pid_t fit in int.
2525 Check for time_t and/or pid_t out of range, e.g., via a network share.
2526 Don't alloca where an auto var works fine.
2527
2528 * fileio.c: Fix some integer overflow issues.
2529 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2530 Don't assume string length fits in int.
2531 (directory_file_name): Don't assume string length fits in long.
2532 (make_temp_name): Don't assume pid fits in int, or that its print
2533 length is less than 20.
2534
2535 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2536
2537 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2538
2539 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2540
2541 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2542 We prefer signed integers, even for size calculations.
2543
2544 * emacs.c: Don't assume string length fits in 'int'.
2545 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2546 (main): Don't invoke strlen when not needed.
2547
2548 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2549 (XD_DEBUG_MESSAGE): Don't waste a byte.
2550
2551 * callproc.c (getenv_internal_1, getenv_internal)
2552 (Fgetenv_internal):
2553 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2554
2555 * lread.c (invalid_syntax): Omit length argument.
2556 All uses changed. This doesn't fix a bug, but it simplifies the
2557 code away from its former Hollerith-constant appearance, and it's
2558 one less 'int' to worry about when looking at integer-overflow issues.
2559 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2560
2561 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2562 This didn't break anything, but it didn't help either.
2563 It's confusing to put a bogus integer in a place where the actual
2564 value does not matter.
2565 (LIST_END_P): Remove unused macro and its bogus comment.
2566 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2567
2568 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2569 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2570 implementation.
2571 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2572 We prefer signed types, and the value cannot exceed the EMACS_INT
2573 range anyway (because otherwise the length would not be representable).
2574 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2575 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2576 This avoids a GCC warning when WIDE_EMACS_INT.
2577
2578 * indent.c (sane_tab_width): New function.
2579 (current_column, scan_for_column, Findent_to, position_indentation)
2580 (compute_motion): Use it. This is just for clarity.
2581 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2582
2583 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2584
2585 * lisp.h (lint_assume): New macro.
2586 * composite.c (composition_gstring_put_cache):
2587 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2588
2589 * editfns.c, insdel.c:
2590 Omit unnecessary forward decls, to simplify future changes.
2591
2592 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2593
2594 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2595
2596 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2597 Use much-faster test for byte-length change.
2598 Don't assume string byte-length fits in 'int'.
2599 Check that character arg fits in 'int'.
2600 (mapcar1): Declare byte as byte, for clarity.
2601
2602 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2603
2604 * fns.c (concat): Catch string overflow earlier.
2605 Do not rely on integer wraparound.
2606
2607 * dispextern.h (struct it.overlay_strings_charpos)
2608 (struct it.selective): Now EMACS_INT, not int.
2609 * xdisp.c (forward_to_next_line_start)
2610 (back_to_previous_visible_line_start)
2611 (reseat_at_next_visible_line_start, next_element_from_buffer):
2612 Don't arbitrarily truncate the value of 'selective' to int.
2613
2614 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2615
2616 * composite.c: Don't truncate sizes to 'int'.
2617 (composition_gstring_p, composition_reseat_it)
2618 (composition_adjust_point): Use EMACS_INT, not int.
2619 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2620 not EMACS_UINT, for indexes.
2621
2622 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2623
2624 * buffer.c: Include <verify.h>.
2625 (struct sortvec.priority, struct sortstr.priority):
2626 Now EMACS_INT, not int.
2627 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2628 (struct sortstr.size, record_overlay_string)
2629 (struct sortstrlist.size, struct sortlist.used):
2630 Don't truncate size to int.
2631 (record_overlay_string): Check for size-calculation overflow.
2632 (init_buffer_once): Check at compile-time, not run-time.
2633
2634 2011-06-22 Jim Meyering <meyering@redhat.com>
2635
2636 Don't leak an XBM-image-sized buffer
2637 * image.c (xbm_load): Free the image buffer after using it.
2638
2639 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2640
2641 Port to Sun C.
2642 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2643 that Sun C diagnosed.
2644 * fns.c (secure_hash): Fix pointer signedness issue.
2645 * intervals.c (static_offset_intervals): New function.
2646 (offset_intervals): Use it.
2647
2648 2011-06-21 Leo Liu <sdl.web@gmail.com>
2649
2650 * deps.mk (fns.o):
2651 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2652 sha512.h.
2653
2654 * fns.c (secure_hash): Rename from crypto_hash_function and change
2655 the first arg to accept symbols.
2656 (Fsecure_hash): New primitive.
2657 (syms_of_fns): New symbols.
2658
2659 2011-06-20 Deniz Dogan <deniz@dogan.se>
2660
2661 * process.c (Fset_process_buffer): Clarify return value in
2662 docstring.
2663
2664 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2665
2666 * dispnew.c (add_window_display_history): Use BVAR.
2667
2668 * xdisp.c (debug_method_add): Use BVAR.
2669 (check_window_end, dump_glyph_matrix, dump_glyph)
2670 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2671
2672 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2673 Likewise.
2674
2675 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2676 check till after the cache is created in init_frame_faces.
2677
2678 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2679
2680 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2681
2682 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2685 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2686 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2687
2688 Improve buffer-overflow checking (Bug#8873).
2689 * fileio.c (Finsert_file_contents):
2690 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2691 Remove the old (too-loose) buffer overflow checks.
2692 They weren't needed, since make_gap checks for buffer overflow.
2693 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2694 The old code merely checked for Emacs fixnum overflow, and relied
2695 on undefined (wraparound) behavior. The new code avoids undefined
2696 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2697
2698 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2699 Tune. Don't use wider integers than needed. Don't use alloca.
2700 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2701
2702 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2703
2704 * insdel.c, lisp.h (buffer_overflow): New function.
2705 (insert_from_buffer_1, replace_range, replace_range_2):
2706 * insdel.c (make_gap_larger):
2707 * editfns.c (Finsert_char):
2708 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2709
2710 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2711
2712 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 Integer overflow and signedness fixes (Bug#8873).
2715
2716 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2717 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2718
2719 * fileio.c: Don't assume EMACS_INT fits in off_t.
2720 (emacs_lseek): New static function.
2721 (Finsert_file_contents, Fwrite_region): Use it.
2722 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2723
2724 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2725
2726 * fns.c: Don't overflow int when computing a list length.
2727 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2728 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2729 truncation on 64-bit hosts. Check for QUIT every
2730 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2731 faster and is responsive enough.
2732 (Flength): Report an error instead of overflowing an integer.
2733 (Fsafe_length): Return a float if the value is not representable
2734 as a fixnum. This shouldn't happen except in contrived situations.
2735 (Fnthcdr, Fsort): Don't assume list length fits in int.
2736 (Fcopy_sequence): Don't assume vector length fits in int.
2737
2738 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2739 (header_size, word_size): New constants.
2740 (allocate_vectorlike): Don't check size overflow here.
2741 (allocate_vector): Check it here instead, since this is the only
2742 caller of allocate_vectorlike that could cause overflow.
2743 Check that the new vector's length is representable as a fixnum.
2744
2745 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2746 The previous code was bogus. For example, next_almost_prime (32)
2747 returned 39, which is undesirable as it is a multiple of 3; and
2748 next_almost_prime (24) returned 25, which is a multiple of 5 so
2749 why was the code bothering to check for multiples of 7?
2750
2751 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2752
2753 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2754
2755 Variadic C functions now count arguments with ptrdiff_t.
2756 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2757 Back then I didn't know that the Emacs coding style prefers signed int.
2758 Also, in the meantime I found a few more instances where arguments
2759 were being counted with int, which may truncate counts on 64-bit
2760 machines, or EMACS_INT, which may be unnecessarily wide.
2761 * lisp.h (struct Lisp_Subr.function.aMANY)
2762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2763 Arg counts are now ptrdiff_t, not size_t.
2764 All variadic functions and their callers changed accordingly.
2765 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2766 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2767 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2768 * callint.c (Fcall_interactively): Check arg count for overflow,
2769 to avoid potential buffer overrun. Use signed char, not 'int',
2770 for 'varies' array, so that we needn't bother to check its size
2771 calculation for overflow.
2772 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2773 * eval.c (apply_lambda):
2774 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2775 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2776 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2777
2778 * callint.c (Fcall_interactively): Don't use index var as event count.
2779
2780 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2781 * mem-limits.h (SIZE): Remove; no longer used.
2782
2783 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2784
2785 Remove unnecessary casts.
2786 * xterm.c (x_term_init):
2787 * xfns.c (x_set_border_pixel):
2788 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2789 These aren't needed now that we assume ANSI C.
2790
2791 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2792 It's more likely to cause problems (due to unsigned overflow)
2793 than to cure them.
2794
2795 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2796
2797 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2798
2799 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2800
2801 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2802
2803 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2804
2805 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2806
2807 GLYPH_CODE_FACE returns EMACS_INT, not int.
2808 * dispextern.h (merge_faces):
2809 * xfaces.c (merge_faces):
2810 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2811 Don't assume EMACS_INT fits in int.
2812
2813 * character.h (CHAR_VALID_P): Remove unused parameter.
2814 * fontset.c, lisp.h, xdisp.c: All uses changed.
2815
2816 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2817
2818 * fns.c (concat): Minor tuning based on overflow analysis.
2819 This doesn't fix any bugs. Use int to hold character, instead
2820 of constantly refetching from Emacs object. Use XFASTINT, not
2821 XINT, for value known to be a character. Don't bother comparing
2822 a single byte to 0400, as it's always less.
2823
2824 * floatfns.c (Fexpt):
2825 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2826
2827 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2828 for characters.
2829
2830 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2831
2832 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2833 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2834 incorrectly succeed when S was a string, because 4294967386 was
2835 truncated before it was used.
2836
2837 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2838 Otherwise, an out-of-range integer could cause undefined behavior
2839 on a 64-bit host.
2840
2841 * composite.c: Use int, not EMACS_INT, for characters.
2842 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2843 EMACS_INT, for values that are known to be in character range.
2844 This doesn't fix any bugs but is the usual style inside Emacs and
2845 may generate better code on 32-bit machines.
2846
2847 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2848 This is for reasons similar to the recent CHAR_STRING fix.
2849 * charset.c (Fencode_char): Check that character arg is actually
2850 a character. Pass an int to ENCODE_CHAR.
2851 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2852 wider than 'int', as a compile-time check to prevent future regressions
2853 in this area.
2854
2855 * character.c (char_string): Remove unnecessary casts.
2856
2857 Make sure a 64-bit char is never passed to CHAR_STRING.
2858 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2859 by silently ignoring the top 32 bits, allowing some values
2860 that were far too large to be valid characters.
2861 * character.h: Include <verify.h>.
2862 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2863 arguments are no wider than unsigned, as a compile-time check
2864 to prevent future regressions in this area.
2865 * data.c (Faset):
2866 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2867 (Fsubst_char_in_region):
2868 * fns.c (concat):
2869 * xdisp.c (decode_mode_spec_coding):
2870 Adjust to CHAR_STRING's new requirement.
2871 * editfns.c (Finsert_char, Fsubst_char_in_region):
2872 * fns.c (concat): Check that character args are actually
2873 characters. Without this test, these functions did the wrong
2874 thing with wildly out-of-range values on 64-bit hosts.
2875
2876 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2877 These casts should not be needed on 32-bit hosts, either.
2878 * keyboard.c (read_char):
2879 * lread.c (Fload): Remove casts to unsigned.
2880
2881 * lisp.h (UNSIGNED_CMP): New macro.
2882 This fixes comparison bugs on 64-bit hosts.
2883 (ASCII_CHAR_P): Use it.
2884 * casefiddle.c (casify_object):
2885 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2886 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2887 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2888 * dispextern.h (FACE_FROM_ID):
2889 * keyboard.c (read_char): Use UNSIGNED_CMP.
2890
2891 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2892 not to EMACS_INT, to avoid GCC warning.
2893
2894 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2895
2896 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2897 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2898 isn't needed on 32-bit machines.
2899
2900 * buffer.c (Fgenerate_new_buffer_name):
2901 Use EMACS_INT for count, not int.
2902 (advance_to_char_boundary): Return EMACS_INT, not int.
2903
2904 * data.c (Qcompiled_function): Now static.
2905
2906 * window.c (window_body_lines): Now static.
2907
2908 * image.c (gif_load): Rename local to avoid shadowing.
2909
2910 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2911 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2912 * alloc.c (make_save_value): Integer argument is now of type
2913 ptrdiff_t, not int.
2914 (mark_object): Use ptrdiff_t, not int.
2915 * lisp.h (pD): New macro.
2916 * print.c (print_object): Use it.
2917
2918 * alloc.c: Use EMACS_INT, not int, to count objects.
2919 (total_conses, total_markers, total_symbols, total_vector_size)
2920 (total_free_conses, total_free_markers, total_free_symbols)
2921 (total_free_floats, total_floats, total_free_intervals)
2922 (total_intervals, total_strings, total_free_strings):
2923 Now EMACS_INT, not int. All uses changed.
2924 (Fgarbage_collect): Compute overall total using a double, so that
2925 integer overflow is less likely to be a problem. Check for overflow
2926 when converting back to an integer.
2927 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2928 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2929 These were 'int' variables that could overflow on 64-bit hosts;
2930 they were never used, so remove them instead of repairing them.
2931 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2932 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2933 Previously, this ceilinged at INT_MAX, but that doesn't work on
2934 64-bit machines.
2935 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2936
2937 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2938 (allocate_vectorlike): Check for ptrdiff_t overflow.
2939 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2940 when a (possibly-narrower) signed value would do just as well.
2941 We prefer using signed arithmetic, to avoid comparison confusion.
2942
2943 * alloc.c: Catch some string size overflows that we were missing.
2944 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2945 for convenience in STRING_BYTES_MAX.
2946 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2947 The definition here is exact; the one in lisp.h was approximate.
2948 (allocate_string_data): Check for string overflow. This catches
2949 some instances we weren't catching before. Also, it catches
2950 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2951 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2952 and ptrdiff_t and EMACS_INT are both 64 bits.
2953
2954 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2955 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2956 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2957
2958 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2959
2960 * alloc.c (Fmake_string): Check for out-of-range init.
2961
2962 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2963
2964 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2965
2966 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2967
2968 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2969 xg_get_default_scrollbar_width.
2970
2971 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2972 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2973 (style_changed_cb): Call update_theme_scrollbar_width and call
2974 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2975 all frames (Bug#8505).
2976 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2977 Call gtk_window_set_resizable if HAVE_GTK3.
2978 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2979 and height if HAVE_GTK3 (Bug#8505).
2980 (scroll_bar_width_for_theme): New variable.
2981 (update_theme_scrollbar_width): New function.
2982 (xg_get_default_scrollbar_width): Move code to
2983 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2984 (xg_initialize): Call update_theme_scrollbar_width.
2985
2986 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2987
2988 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2989
2990 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2991
2992 * frame.c (make_frame): Call other_buffer_safely instead of
2993 other_buffer.
2994
2995 * window.c (temp_output_buffer_show): Call display_buffer with
2996 second argument Vtemp_buffer_show_specifiers and reset latter
2997 immediately after the call.
2998 (Vtemp_buffer_show_specifiers): New variable.
2999 (auto_window_vscroll_p, next_screen_context_lines)
3000 (Vscroll_preserve_screen_position): Remove leading asterisks from
3001 doc-strings.
3002
3003 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 Fix minor problems found by GCC 4.6.0 static checking.
3006 * buffer.c (Qclone_number): Remove for now, as it's unused.
3007 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3008 (record_buffer): Remove unused local.
3009 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3010 (set_frame_buffer_list): Remove; unused.
3011 * frame.h (other_visible_frames): Remove decl.
3012 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3013 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3014 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3015 if HAVE_GPM.
3016 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3017 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3018 Define only if HAVE_GPM.
3019 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3020 (update_hints_inhibit): Remove; never set. All uses removed.
3021 * widgetprv.h (emacsFrameClassRec): Remove decl.
3022 * window.c (delete_deletable_window): Now returns void, since it
3023 wasn't returning anything.
3024 (compare_window_configurations): Remove unused locals.
3025 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3026 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3027 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3028 the same widths as pointers. This follows up on the 2011-05-06 patch.
3029 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3030 * xterm.h: Likewise.
3031 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3032
3033 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * makefile.w32-in: Update dependencies.
3036 (LISP_H): Add lib/intprops.h.
3037
3038 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * image.c (gif_load): Add animation frame delay to the metadata.
3041 (syms_of_image): Use DEFSYM. New symbol `delay'.
3042
3043 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3044
3045 * window.c (delete_deletable_window): Re-add.
3046 (Fset_window_configuration): Rewrite to handle dead buffers and
3047 consequently deletable windows.
3048 (window_tree, Fwindow_tree): Remove. Supply functionality in
3049 window.el.
3050 (compare_window_configurations): Simplify code.
3051
3052 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3053
3054 * image.c (imagemagick_load_image): Fix type mismatch.
3055 (Fimagemagick_types): Likewise.
3056
3057 * window.h (replace_buffer_in_windows): Declare.
3058
3059 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3060
3061 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3062 Qclone_number. Remove external declaration of Qdelete_window.
3063 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3064 code.
3065 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3066 Run Qbuffer_list_update_hook if allowed.
3067 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3068 buffer list implementation.
3069 (other_buffer_safely): New function.
3070 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3071 calls to replace_buffer_in_windows and
3072 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3073 if allowed.
3074 (record_buffer): Inhibit quitting and rewrite using quittable
3075 functions. Run Qbuffer_list_update_hook if allowed.
3076 (Frecord_buffer, Funrecord_buffer): New functions.
3077 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3078 Move switch-to-buffer to window.el.
3079 (bury-buffer): Move to window.el.
3080 (Vbuffer_list_update_hook): New variable.
3081
3082 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3083 section.
3084
3085 * window.h (resize_frame_windows): Move up in code.
3086 (Fwindow_frame): Remove EXFUN.
3087 (replace_buffer_in_all_windows): Remove prototype.
3088 (replace_buffer_in_windows_safely): Add prototype.
3089
3090 * window.c: Declare Qdelete_window static again. Move down
3091 declaration of select_count.
3092 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3093 (Fother_window): Move to window.el.
3094 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3095 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3096 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3097 window.el.
3098 (replace_buffer_in_windows): Implement by calling
3099 Qreplace_buffer_in_windows.
3100 (replace_buffer_in_all_windows): Remove with some functionality
3101 moved into replace_buffer_in_windows_safely.
3102 (replace_buffer_in_windows_safely): New function.
3103 (select_window_norecord, select_frame_norecord): Move in front
3104 of run_window_configuration_change_hook. Remove now obsolete
3105 declarations.
3106 (Fset_window_buffer): Rewrite doc-string.
3107 Call Qrecord_window_buffer.
3108 (keys_of_window): Move binding for other-window to window.el.
3109
3110 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * dispextern.h (struct image): Replace data member, whose int_val
3113 and ptr_val fields were not used by anything, with a single
3114 lisp_val object.
3115
3116 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3117 (gif_clear_image, gif_load, imagemagick_load_image)
3118 (gs_clear_image, gs_load): Callers changed.
3119
3120 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 * buffer.h: Include <time.h>, for time_t.
3123 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3124
3125 Fix minor problems found by static checking.
3126
3127 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3128
3129 Make identifiers static if they are not used in other modules.
3130 * data.c (Qcompiled_function, Qframe, Qvector):
3131 * image.c (QimageMagick, Qsvg):
3132 * minibuf.c (Qmetadata):
3133 * window.c (resize_window_check, resize_root_window): Now static.
3134 * window.h (resize_window_check, resize_root_window): Remove decls.
3135
3136 * window.c (window_deletion_count, delete_deletable_window):
3137 Remove; unused.
3138 (window_body_lines): Now static.
3139 (Fdelete_other_windows_internal): Mark vars as initialized.
3140 Make sure 'resize_failed' is initialized.
3141 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3142 (resize_window_apply): Remove unused local.
3143 * window.h (delete_deletable_window): Remove decl.
3144
3145 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3146 (imagemagick_load_image): Fix pointer signedness problem by changing
3147 last arg from unsigned char * to char *. All uses changed.
3148 Also, fix a local for similar reasons.
3149 Remove unused locals. Remove locals to avoid shadowing.
3150 (fn_rsvg_handle_free): Remove; unused.
3151 (svg_load, svg_load_image): Fix pointer signedness problem.
3152 (imagemagick_load_image): Don't use garbage pointer image_wand.
3153
3154 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3155
3156 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3157
3158 * image.c (gif_load): Fix omitted cast error introduced by
3159 2011-06-06 change.
3160
3161 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3162
3163 * window.h (resize_proportionally, orig_total_lines)
3164 (orig_top_line): Remove from window structure.
3165 (set_window_height, set_window_width, change_window_heights)
3166 (Fdelete_window): Remove prototypes.
3167 (resize_frame_windows): Remove duplicate declaration.
3168
3169 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3170
3171 * window.h (resize_frame_windows, resize_window_check)
3172 (delete_deletable_window, resize_root_window)
3173 (resize_frame_windows): Declare prototypes.
3174
3175 * window.c (resize_window_apply): Make definition be "static" to
3176 match the prototype.
3177
3178 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3179
3180 * window.c: Remove declarations of Qwindow_size_fixed,
3181 window_min_size_1, window_min_size_2, window_min_size,
3182 size_window, window_fixed_size_p, enlarge_window, delete_window.
3183 Remove static from declaration of Qdelete_window, it's
3184 temporarily needed by Fbury_buffer.
3185 (replace_window): Don't assign orig_top_line and
3186 orig_total_lines.
3187 (Fdelete_window, delete_window): Remove. Window deletion is
3188 handled by window.el.
3189 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3190 Replace Fdelete_window calls with calls to Qdelete_window.
3191 (Fdelete_other_windows): Remove. Deleting other windows is
3192 handled by window.el.
3193 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3194 handled in window.el.
3195 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3196 Window minimum sizes are handled in window.el.
3197 (shrink_windows, size_window, set_window_height)
3198 (set_window_width, change_window_heights, window_height)
3199 (window_width, CURBEG, CURSIZE, enlarge_window)
3200 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3201 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3202 handled in window.el.
3203 (make_dummy_parent): Rename to make_parent_window and give it a
3204 second argument horflag.
3205 (make_window): Don't set resize_proportionally any more.
3206 (Fsplit_window): Remove. Windows are split in window.el.
3207 (save_restore_action, save_restore_orig_size)
3208 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3209 Resize mini windows in window.el.
3210 (grow_mini_window, shrink_mini_window): Implement by calling
3211 Qresize_root_window_vertically, resize_window_check and
3212 resize_window_apply.
3213 (saved_window, Fset_window_configuration, save_window_save):
3214 Do not handle orig_top_line, orig_total_lines, and
3215 resize_proportionally.
3216 (window_min_height, window_min_width): Move to window.el.
3217 (keys_of_window): Move bindings for delete-other-windows,
3218 split-window, delete-window and enlarge-window to window.el.
3219
3220 * buffer.c: Temporarily extern Qdelete_window.
3221 (Fbury_buffer): Temporarily call Qdelete_window instead of
3222 Fdelete_window (Fbury_buffer will move to window.el soon).
3223
3224 * frame.c (set_menu_bar_lines_1): Remove code handling
3225 orig_top_line and orig_total_lines.
3226
3227 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3228 set_window_height but set heights directly.
3229 (change_frame_size_1): Use resize_frame_windows.
3230
3231 * xdisp.c (init_xdisp): Don't use set_window_height but set
3232 heights directly.
3233
3234 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3235 Use resize_frame_windows instead of change_window_heights and run
3236 run_window_configuration_change_hook.
3237
3238 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3239 instead of change_window_heights and run
3240 run_window_configuration_change_hook.
3241
3242 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3243
3244 * window.c (replace_window): Rename second argument REPLACEMENT to
3245 NEW. New third argument SETFLAG. Rewrite.
3246 (delete_window, make_dummy_parent): Call replace_window with
3247 third argument 1.
3248 (window_list_1): Move down in code.
3249 (run_window_configuration_change_hook): Move set_buffer part
3250 before select_frame_norecord part in order to unwind correctly.
3251 Rename count1 to count.
3252 (recombine_windows, delete_deletable_window, resize_root_window)
3253 (Fdelete_other_windows_internal)
3254 (Frun_window_configuration_change_hook, make_parent_window)
3255 (resize_window_check, resize_window_apply, Fresize_window_apply)
3256 (resize_frame_windows, Fsplit_window_internal)
3257 (Fdelete_window_internal, Fresize_mini_window_internal):
3258 New functions.
3259 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3260
3261 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3262
3263 * window.h (window): Add some new members to window structure -
3264 normal_lines, normal_cols, new_total, new_normal, clone_number,
3265 splits, nest, prev_buffers, next_buffers.
3266 (WINDOW_TOTAL_SIZE): Move here from window.c.
3267 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3268
3269 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3270 Remove.
3271 (make_dummy_parent): Set new members of windows structure.
3272 (make_window): Move down in code. Handle new members of window
3273 structure.
3274 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3275 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3276 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3277 (Fset_window_prev_buffers, Fwindow_next_buffers)
3278 (Fset_window_next_buffers, Fset_window_clone_number):
3279 New functions.
3280 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3281 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3282 Doc-string fixes.
3283 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3284 Argument WINDOW can be now internal window too.
3285 (Fwindow_use_time): Move up in code.
3286 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3287 Rewrite doc-string.
3288 (Fset_window_configuration, saved_window)
3289 (Fcurrent_window_configuration, save_window_save): Handle new
3290 members of window structure.
3291 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3292 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3293 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3294 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3295 Qget_mru_window, Qresize_root_window,
3296 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3297 Qauto_buffer_name; staticpro them.
3298
3299 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3300
3301 * window.c (Fwindow_total_size, Fwindow_left_column)
3302 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3303 (Fwindow_list_1): New functions.
3304 (window_box_text_cols): Replace with window_body_cols.
3305 (Fwindow_width, Fscroll_left, Fscroll_right):
3306 Use window_body_cols instead of window_box_text_cols.
3307 (delete_window, Fset_window_configuration):
3308 Call delete_all_subwindows with window as argument.
3309 (delete_all_subwindows): Take a window as argument and not a
3310 structure. Rewrite.
3311 (window_loop): Remove handling of GET_LRU_WINDOW and
3312 GET_LARGEST_WINDOW.
3313 (Fget_lru_window, Fget_largest_window): Move to window.el.
3314
3315 * window.h: Extern window_body_cols instead of
3316 window_box_text_cols. delete_all_subwindows now takes a
3317 Lisp_Object as argument.
3318
3319 * indent.c (compute_motion, Fcompute_motion):
3320 Use window_body_cols instead of window_box_text_cols.
3321
3322 * frame.c (delete_frame): Call delete_all_subwindows with root
3323 window as argument.
3324
3325 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3326
3327 * fns.c (Fputhash): Document return value.
3328
3329 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3330
3331 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3332
3333 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 Cons<->int and similar integer overflow fixes (Bug#8794).
3336
3337 Check for overflow when converting integer to cons and back.
3338 * charset.c (Fdefine_charset_internal, Fdecode_char):
3339 Use cons_to_unsigned to catch overflow.
3340 (Fencode_char): Use INTEGER_TO_CONS.
3341 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3342 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3343 * data.c (long_to_cons, cons_to_long): Remove.
3344 (cons_to_unsigned, cons_to_signed): New functions.
3345 These signal an error for invalid or out-of-range values.
3346 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3347 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3348 * font.c (Ffont_variation_glyphs):
3349 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3350 * lisp.h: Include <intprops.h>.
3351 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3352 (cons_to_signed, cons_to_unsigned): New decls.
3353 (long_to_cons, cons_to_long): Remove decls.
3354 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3355 (Fprimitive_undo): Use CONS_TO_INTEGER.
3356 * xfns.c (Fx_window_property): Likewise.
3357 * xselect.c: Include <limits.h>.
3358 (x_own_selection, selection_data_to_lisp_data):
3359 Use INTEGER_TO_CONS.
3360 (x_handle_selection_request, x_handle_selection_clear)
3361 (x_get_foreign_selection, Fx_disown_selection_internal)
3362 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3363 (lisp_data_to_selection_data): Use cons_to_unsigned.
3364 (x_fill_property_data): Use cons_to_signed.
3365 Report values out of range.
3366
3367 Check for buffer and string overflow more precisely.
3368 * buffer.h (BUF_BYTES_MAX): New macro.
3369 * lisp.h (STRING_BYTES_MAX): New macro.
3370 * alloc.c (Fmake_string):
3371 * character.c (string_escape_byte8):
3372 * coding.c (coding_alloc_by_realloc):
3373 * doprnt.c (doprnt):
3374 * editfns.c (Fformat):
3375 * eval.c (verror):
3376 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3377 since they may not be the same number.
3378 * editfns.c (Finsert_char):
3379 * fileio.c (Finsert_file_contents):
3380 Likewise for BUF_BYTES_MAX.
3381
3382 * image.c: Use ptrdiff_t, not int, for sizes.
3383 (slurp_file): Switch from int to ptrdiff_t.
3384 All uses changed.
3385 (slurp_file): Check that file size fits in both size_t (for
3386 malloc) and ptrdiff_t (for sanity and safety).
3387
3388 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3389 if b->modtime has its maximal value.
3390
3391 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3392
3393 Don't assume time_t can fit into int.
3394 * buffer.h (struct buffer.modtime): Now time_t, not int.
3395 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3396 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3397
3398 Minor fixes for signed vs unsigned integers.
3399 * character.h (MAYBE_UNIFY_CHAR):
3400 * charset.c (maybe_unify_char):
3401 * keyboard.c (read_char, reorder_modifiers):
3402 XINT -> XFASTINT, since the integer must be nonnegative.
3403 * ftfont.c (ftfont_spec_pattern):
3404 * keymap.c (access_keymap, silly_event_symbol_error):
3405 XUINT -> XFASTINT, since the integer must be nonnegative.
3406 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3407 since it makes no difference and we prefer signed.
3408 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3409 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3410 nonnegative.
3411
3412 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3413
3414 * window.h (Fwindow_frame): Declare.
3415
3416 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3419 (SPARE_MEMORY): Always define.
3420 (LARGE_REQUEST): Remove.
3421 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3422
3423 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3424
3425 * lisp.h: Move EXFUNS for Fframe_root_window,
3426 Fframe_first_window and Fset_frame_selected_window to window.h.
3427
3428 * window.h: Move EXFUNS for Fframe_root_window,
3429 Fframe_first_window and Fset_frame_selected_window here from
3430 lisp.h.
3431
3432 * frame.c (Fwindow_frame, Fframe_first_window)
3433 (Fframe_root_window, Fframe_selected_window)
3434 (Fset_frame_selected_window): Move to window.c.
3435 (Factive_minibuffer_window): Move to minibuf.c.
3436 (Fother_visible_frames_p): New function.
3437
3438 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3439
3440 * window.c (decode_window, decode_any_window): Move up in code.
3441 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3442 (inhibit_frame_unsplittable): Remove unused variable.
3443 (Fwindow_buffer): Move up and rewrite doc-string.
3444 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3445 (Fwindow_prev): New functions.
3446 (Fwindow_frame): Move here from frame.c. Accept any window as
3447 argument.
3448 (Fframe_root_window, Fframe_first_window)
3449 (Fframe_selected_window): Move here from frame.c. Accept frame
3450 or arbitrary window as argument. Update doc-strings.
3451 (Fminibuffer_window): Move up in code.
3452 (Fwindow_minibuffer_p): Move up in code and simplify.
3453 (Fset_frame_selected_window): Move here from frame.c.
3454 Marginal rewrite.
3455 (Fselected_window, select_window, Fselect_window): Move up in
3456 code. Minor doc-string fixes.
3457
3458 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3461 Do not assume that spare memory exists; that assumption is valid
3462 only if SYSTEM_MALLOC.
3463 (LARGE_REQUEST): New macro, so that the issue of large requests
3464 is separated from the issue of spare memory.
3465
3466 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3469 format. (Bug#8806)
3470
3471 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3472
3473 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3474 before statements.
3475
3476 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3477
3478 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3479
3480 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3481
3482 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3483 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3484
3485 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3488
3489 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3490
3491 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3492 (x_clipboard_manager_save): Add return value.
3493 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3494 New error handlers.
3495 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3496 Obey Vx_select_enable_clipboard_manager. Catch errors in
3497 x_clipboard_manager_save (Bug#8779).
3498 (Vx_select_enable_clipboard_manager): New variable.
3499 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3500
3501 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3502
3503 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3504
3505 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3506
3507 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3508 in the current matrix if keep_current_p is non-zero.
3509
3510 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3511
3512 * bidi.c (bidi_level_of_next_char): Fix last change.
3513
3514 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3515
3516 Support bidi reordering of text covered by display properties.
3517
3518 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3519 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3520 (bidi_cache_search, bidi_cache_iterator_state)
3521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3522 (bidi_level_of_next_char, bidi_move_to_visually_next):
3523 Support character positions inside a run of characters covered by a
3524 display string.
3525 (bidi_paragraph_init, bidi_resolve_explicit_1)
3526 (bidi_level_of_next_char): Call bidi_fetch_char and
3527 bidi_fetch_char_advance instead of FETCH_CHAR and
3528 FETCH_CHAR_ADVANCE.
3529 (bidi_init_it): Initialize new members.
3530 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3531 definitions.
3532 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3533 instead of using explicit *_CHAR codes.
3534 (bidi_resolve_explicit, bidi_resolve_weak):
3535 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3536 bidirectional text is supported only in multibyte buffers.
3537 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3538 it to initialize the frame_window_p member of struct bidi_it.
3539 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3540 (bidi_resolve_explicit, bidi_resolve_weak)
3541 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3542 bidi_it->nchars is non-positive.
3543 (bidi_level_of_next_char): Don't try to lookup the cache for the
3544 next/previous character if nothing is cached there yet, or if we
3545 were just reseat()'ed to a new position.
3546
3547 * xdisp.c (set_cursor_from_row): Set start and stop points
3548 according to the row's direction when priming the loop that looks
3549 for the glyph on which to display cursor.
3550 (single_display_spec_intangible_p): Function deleted.
3551 (display_prop_intangible_p): Reimplement to call
3552 handle_display_spec instead of single_display_spec_intangible_p.
3553 Accept 3 additional arguments needed by handle_display_spec.
3554 This fixes incorrect cursor motion across display property with complex
3555 values: lists, `(when COND...)' forms, etc.
3556 (single_display_spec_string_p): Support property values that are
3557 lists with the argument STRING its top-level element.
3558 (display_prop_string_p): Fix the condition for processing a
3559 property that is a list to be consistent with handle_display_spec.
3560 (handle_display_spec): New function, refactored from the
3561 last portion of handle_display_prop.
3562 (compute_display_string_pos): Accept additional argument
3563 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3564 value of a `display' property is a "replacing spec".
3565 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3566 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3567 the display property, but just return a value indicating whether
3568 the display property will replace the characters it covers.
3569 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3570 frame_window_p members of struct bidi_it.
3571 (compute_display_string_pos, compute_display_string_end):
3572 New functions.
3573 (push_it): Accept second argument POSITION, where pop_it should
3574 jump to continue iteration.
3575 (reseat_1): Initialize bidi_it.disp_pos.
3576
3577 * keyboard.c (adjust_point_for_property): Adjust the call to
3578 display_prop_intangible_p to its new signature.
3579
3580 * dispextern.h (struct bidi_it): New member frame_window_p.
3581 (bidi_init_it): Update prototypes.
3582 (display_prop_intangible_p): Update prototype.
3583 (compute_display_string_pos, compute_display_string_end):
3584 Declare prototypes.
3585 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3586 EMACS_INT.
3587
3588 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3589
3590 Malloc failure behavior now depends on size of allocation.
3591 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3592 * lisp.h: Change signatures accordingly.
3593 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3594 All callers changed. (Bug#8762)
3595
3596 * gnutls.c: Use Emacs's memory allocators.
3597 Without this change, the gnutls library would invoke malloc etc.
3598 directly, which causes problems on non-SYNC_INPUT hosts, and which
3599 runs afoul of improving memory_full behavior. (Bug#8761)
3600 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3601 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3602 xfree instead of the default malloc, realloc, free.
3603 (Fgnutls_boot): No need to check for memory allocation failure,
3604 since xmalloc does that for us.
3605
3606 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3607 * category.c (hash_get_category_set):
3608 * ccl.c (ccl_driver):
3609 * charset.c (Fdefine_charset_internal):
3610 * charset.h (struct charset.hash_index):
3611 * composite.c (get_composition_id, gstring_lookup_cache)
3612 (composition_gstring_put_cache):
3613 * composite.h (struct composition.hash_index):
3614 * dispextern.h (struct image.hash):
3615 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3616 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3617 (hashfn_equal, hashfn_user_defined, make_hash_table)
3618 (maybe_resize_hash_table, hash_lookup, hash_put)
3619 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3620 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3621 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3622 * image.c (make_image, search_image_cache, lookup_image)
3623 (xpm_put_color_table_h):
3624 * lisp.h (struct Lisp_Hash_Table):
3625 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3626 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3627 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3628 * alloc.c (allocate_vectorlike):
3629 Check for overflow in vector size calculations.
3630 * ccl.c (ccl_driver):
3631 Check for overflow when converting EMACS_INT to int.
3632 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3633 need to be updated by these changes.
3634 * fns.c (make_hash_table, maybe_resize_hash_table):
3635 Check for integer overflow with large hash tables.
3636 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3637 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3638 (SXHASH_REDUCE): New macro.
3639 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3640 Use it instead of discarding useful hash info with large hash values.
3641 (sxhash_float): New function.
3642 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3643 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3644 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3645 Rewrite to use FIXNUM_BITS, as this simplifies things.
3646 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3647 Adjust signatures to match updated version of code.
3648 (consing_since_gc): Now EMACS_INT, since a single hash table can
3649 use more than INT_MAX bytes.
3650
3651 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3652
3653 Make it possible to build with GCC-4.6+ -O2 -flto.
3654
3655 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3656
3657 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3658
3659 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3660 Call minibuffer-inactive-mode.
3661
3662 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3663
3664 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3665 Update dependencies.
3666
3667 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3668
3669 * data.c (init_data): Remove code for UTS, this system is not
3670 supported anymore.
3671
3672 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3673
3674 Don't force ./temacs to start in terminal mode.
3675
3676 * frame.c (make_initial_frame): Initialize faces in all cases, not
3677 only when CANNOT_DUMP is defined.
3678 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3679
3680 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3681
3682 * dispnew.c (add_window_display_history): Use const for the string
3683 pointer. Remove declaration, not needed.
3684
3685 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 Use 'inline', not 'INLINE'.
3688 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3689 * alloc.c, fontset.c (INLINE): Remove.
3690 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3691 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3692 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3693 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3694 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3695
3696 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3697
3698 Make it possible to run ./temacs.
3699
3700 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3701 syms_of_callproc does the same thing. Remove test for
3702 "initialized", do it in the caller.
3703 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3704
3705 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3706
3707 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3708 (read_minibuf): Use get_minibuffer.
3709 (syms_of_minibuf): Use DEFSYM.
3710 (Qmetadata): New var.
3711 * data.c (Qbuffer): Don't make it static.
3712 (syms_of_data): Use DEFSYM.
3713
3714 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3715
3716 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3717 (CCL_CODE_MIN): New macro.
3718
3719 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3720
3721 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3722
3723 * eval.c (Qdebug): Now static.
3724 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3725 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3726 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3727
3728 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3729
3730 * image.c: Various fixes to ImageMagick code comments.
3731 (Fimagemagick_types): Doc fix.
3732
3733 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3734
3735 Minor fixes prompted by GCC 4.6.0 warnings.
3736
3737 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3738
3739 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3740 (x_clipboard_manager_save_all): Move extern decl to ...
3741 * xterm.h: ... here, so that it can be checked for consistency.
3742
3743 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3744
3745 * xselect.c (x_clipboard_manager_save_frame)
3746 (x_clipboard_manager_save_all): New functions.
3747 (Fx_clipboard_manager_save): Lisp function deleted.
3748
3749 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3750 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3751
3752 * xterm.h: Update prototype.
3753
3754 2011-05-28 William Xu <william.xwl@gmail.com>
3755
3756 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3757 exiting (Bug#8239).
3758
3759 2011-05-28 Jim Meyering <meyering@redhat.com>
3760
3761 Avoid a sign-extension bug in crypto_hash_function.
3762 * fns.c (to_uchar): Define.
3763 (crypto_hash_function): Use it to convert some newly-signed
3764 variables to unsigned, to avoid sign-extension bugs. For example,
3765 without this change, (md5 "truc") would evaluate to
3766 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3767 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3768 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3769
3770 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3771
3772 Integer overflow fixes.
3773
3774 * dbusbind.c: Serial number integer overflow fixes.
3775 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3776 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3777 to hold a serial number that is too large for a fixnum.
3778 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3779 Check for serial numbers out of range. Decode any serial number
3780 that was so large that it became a float. (Bug#8722)
3781
3782 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3783 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3784 Use XFASTINT rather than XUINT when numbers are nonnegative.
3785 (xd_append_arg, Fdbus_method_return_internal):
3786 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3787 arguments, check that Lisp number is nonnegative, rather than
3788 silently wrapping negative numbers around. (Bug#8722)
3789 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3790 (Bug#8722)
3791
3792 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3793
3794 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3795
3796 ccl: add integer overflow checks
3797 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3798 (IN_INT_RANGE): New macros.
3799 (ccl_driver): Use them to check for integer overflow when
3800 decoding a CCL program. Many of the new checks are whether XINT (x)
3801 fits in int; it doesn't always, on 64-bit hosts. The new version
3802 doesn't catch all possible integer overflows, but it's an
3803 improvement. (Bug#8719)
3804
3805 * alloc.c (make_event_array): Use XINT, not XUINT.
3806 There's no need for unsigned here.
3807
3808 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3809 This follows up to the 2011-05-06 change that substituted uintptr_t
3810 for EMACS_INT. This case wasn't caught back then.
3811
3812 Rework Fformat to avoid integer overflow issues.
3813 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3814 now (part of C89). Include <verify.h>.
3815 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3816 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3817 (Fformat): Avoid the prepass trying to compute sizes; it was only
3818 approximate and thus did not catch overflow reliably. Instead, walk
3819 through the format just once, formatting and computing sizes as we go,
3820 checking for integer overflow at every step, and allocating a larger
3821 buffer as needed. Keep track separately whether the format is
3822 multibyte. Keep only the most-recently calculated precision, rather
3823 than them all. Record whether each argument has been converted to
3824 string. Use EMACS_INT, not int, for byte and char and arg counts.
3825 Support field widths and precisions larger than INT_MAX. Avoid
3826 sprintf's undefined behavior with conversion specifications such as %#d
3827 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3828 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3829 formatting out-of-range floating point numbers with int
3830 formats. (Bug#8668)
3831
3832 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3833
3834 * data.c: Avoid integer truncation in expressions involving floats.
3835 * data.c: Include <intprops.h>.
3836 (arith_driver): When there's an integer overflow in an expression
3837 involving floating point, convert the integers to floating point
3838 so that the resulting value does not suffer from catastrophic
3839 integer truncation. For example, on a 64-bit host (* 4
3840 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3841 Do not rely on undefined behavior after integer overflow.
3842
3843 merge count_size_as_multibyte, parse_str_to_multibyte
3844 * character.c, character.h (count_size_as_multibyte):
3845 Rename from parse_str_to_multibyte; all uses changed.
3846 Check for integer overflow.
3847 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3848 since it's now a duplicate of the other. This is more of
3849 a character than a buffer op, so better that it's in character.c.
3850 * fns.c, print.c: Adjust to above changes.
3851
3852 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3853
3854 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3855
3856 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3859 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3860 (x_clipboard_manager_save): Now static.
3861 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3862
3863 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3864 (crypto_hash_function): Now static.
3865 Fix pointer signedness problems. Avoid unnecessary initializations.
3866
3867 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3868
3869 * termhooks.h (Vselection_alist): Make it terminal-local.
3870
3871 * terminal.c (create_terminal): Initialize it.
3872
3873 * xselect.c: Support for clipboard managers.
3874 (Vselection_alist): Move to termhooks.h as terminal-local var.
3875 (LOCAL_SELECTION): New macro.
3876 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3877 (symbol_to_x_atom): Remove gratuitous arg.
3878 (x_handle_selection_request, lisp_data_to_selection_data)
3879 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3880 (x_own_selection, x_get_local_selection, x_convert_selection):
3881 New arg, specifying work frame. Use terminal-local Vselection_alist.
3882 (some_frame_on_display): Delete unused function.
3883 (Fx_own_selection_internal, Fx_get_selection_internal)
3884 (Fx_disown_selection_internal, Fx_selection_owner_p)
3885 (Fx_selection_exists_p): New optional frame arg.
3886 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3887 (x_handle_selection_clear): Don't treat other terminals with the
3888 same keyboard specially. Use the terminal-local Vselection_alist.
3889 (x_clear_frame_selections): Use Frun_hook_with_args.
3890
3891 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3892
3893 * xterm.h: Add support for those atoms.
3894
3895 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3896
3897 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3898 (converted_selections, conversion_fail_tag): New global variables.
3899 (x_selection_request_lisp_error): Free the above.
3900 (x_get_local_selection): Remove unnecessary code.
3901 (x_reply_selection_request): Args changed; handle arbitrary array
3902 of converted selections stored in converted_selections.
3903 Separate the XChangeProperty and SelectionNotify steps.
3904 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3905 (x_convert_selection): New function.
3906 (x_handle_selection_event): Simplify.
3907 (x_get_foreign_selection): Don't ignore incoming requests while
3908 waiting for an answer; this will fail when we implement
3909 SAVE_TARGETS, and seems unnecessary anyway.
3910 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3911 (Vx_sent_selection_functions): Doc fix.
3912
3913 2011-05-26 Leo Liu <sdl.web@gmail.com>
3914
3915 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3916
3917 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3918
3919 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3920
3921 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3922 for fringe update if it has periodic bitmap.
3923 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3924 and fringe_bitmap_periodic_p.
3925
3926 * fringe.c (get_fringe_bitmap_data): New function.
3927 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3928 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3929 row. Mark glyph row for fringe update if periodicity changed.
3930
3931 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3932 for fringe update unless it has periodic bitmap.
3933
3934 2011-05-25 Kenichi Handa <handa@m17n.org>
3935
3936 * xdisp.c (get_next_display_element): Set correct it->face_id for
3937 a static composition.
3938
3939 2011-05-24 Leo Liu <sdl.web@gmail.com>
3940
3941 * deps.mk (fns.o):
3942 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3943
3944 * fns.c (crypto_hash_function, Fsha1): New function.
3945 (Fmd5): Use crypto_hash_function.
3946 (syms_of_fns): Add Ssha1.
3947
3948 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * gnutls.c: Remove unused macros.
3951 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3952 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3953 Remove macros that are defined and never used.
3954 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3955
3956 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3957
3958 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3959 (Fx_get_selection_internal): Minor cleanup.
3960 (Fx_own_selection_internal): Rename arguments for consistency with
3961 select.el.
3962
3963 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3966
3967 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3968
3969 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3970
3971 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3972
3973 * dispnew.c (scrolling_window): Don't exclude the case that the
3974 last enabled row in the desired matrix touches the bottom boundary.
3975
3976 2011-05-21 Glenn Morris <rgm@gnu.org>
3977
3978 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3979 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3980 and add some more files.
3981
3982 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3983
3984 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3985 report_file_error introduced by the change from 2011-05-07.
3986
3987 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 * systime.h (Time): Define only if emacs is defined.
3990 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3991 where the include path doesn't have X11/X.h by default. See
3992 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3993
3994 2011-05-20 Kenichi Handa <handa@m17n.org>
3995
3996 * composite.c (find_automatic_composition): Fix previous change.
3997
3998 2011-05-20 Glenn Morris <rgm@gnu.org>
3999
4000 * lisp.mk: New file, split from Makefile.in.
4001 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4002 (shortlisp): Remove.
4003 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4004
4005 2011-05-19 Glenn Morris <rgm@gnu.org>
4006
4007 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4008 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4009 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4010 (lisp): Set the order to that of loadup.el.
4011 (shortlisp): Make it a copy of $lisp.
4012 (SOME_MACHINE_LISP): Remove.
4013 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4014 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4015
4016 2011-05-18 Kenichi Handa <handa@m17n.org>
4017
4018 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4019 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4020 (find_automatic_composition): Mostly rewrite for efficiency.
4021
4022 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * makefile.w32-in: Update dependencies.
4025
4026 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4027
4028 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4029 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4030
4031 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 Fix some integer overflow issues, such as string length overflow.
4034
4035 * insdel.c (count_size_as_multibyte): Check for string overflow.
4036
4037 * character.c (lisp_string_width): Check for string overflow.
4038 Use EMACS_INT, not int, for string indexes and lengths; in
4039 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4040 the resulting string length overflows an EMACS_INT; instead,
4041 report a string overflow if no precision given. When checking for
4042 precision exhaustion, use a check that cannot possibly have
4043 integer overflow. (Bug#8675)
4044 * character.h (lisp_string_width): Adjust to new signature.
4045
4046 * alloc.c (string_overflow): New function.
4047 (Fmake_string): Use it. This doesn't change behavior, but saves
4048 a few bytes and will simplify future changes.
4049 * character.c (string_escape_byte8): Likewise.
4050 * lisp.h (string_overflow): New decl.
4051
4052 Fixups, following up to the user-interface timestamp change.
4053 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4054 for UI timestamps, instead of unsigned long.
4055 * msdos.c (mouse_get_pos): Likewise.
4056 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4057 * w32gui.h (Time): Define by including "systime.h" rather than by
4058 declaring it ourselves. (Bug#8664)
4059
4060 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4061 * image.c (clear_image_cache): Likewise.
4062
4063 * term.c (term_mouse_position): Don't assume time_t wraparound.
4064
4065 Be more systematic about user-interface timestamps.
4066 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4067 and sometimes 'EMACS_UINT', to represent these timestamps.
4068 This change causes it to use 'Time' uniformly, as that's what X uses.
4069 This makes the code easier to follow, and makes it easier to catch
4070 integer overflow bugs such as Bug#8664.
4071 * frame.c (Fmouse_position, Fmouse_pixel_position):
4072 Use Time, not unsigned long, for user-interface timestamps.
4073 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4074 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4075 * keyboard.h (last_event_timestamp): Likewise.
4076 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4077 * menu.h (xmenu_show): Likewise.
4078 * term.c (term_mouse_position): Likewise.
4079 * termhooks.h (struct input_event.timestamp): Likewise.
4080 (struct terminal.mouse_position_hook): Likewise.
4081 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4082 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4083 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4084 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4085 what it was before.
4086 * menu.h, termhooks.h: Include "systime.h", for Time.
4087
4088 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4089 Don't assume that the difference between two unsigned long values
4090 can fit into an integer. At this point, we know button_down_time
4091 <= event->timestamp, so the difference must be nonnegative, so
4092 there's no need to cast the result if double-click-time is
4093 nonnegative, as it should be; check that it's nonnegative, just in
4094 case. This bug is triggered when events are more than 2**31 ms
4095 apart (about 25 days). (Bug#8664)
4096
4097 * xselect.c (last_event_timestamp): Remove duplicate decl.
4098 (x_own_selection): Remove needless cast to unsigned long.
4099
4100 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4101 that always fit in int. Use a sentinel instead of a counter, to
4102 avoid a temp and to allay GCC's concerns about possible int overflow.
4103 * frame.h (struct frame): Use int for menu_bar_items_used
4104 instead of EMACS_INT, since it always fits in int.
4105
4106 * menu.c (grow_menu_items): Check for int overflow.
4107
4108 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4109
4110 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4111 Before, the code was not consistent. These values cannot exceed
4112 2**31 - 1 so there's no need to make them unsigned.
4113 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4114 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4115 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4116 as modifiers.
4117 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4118
4119 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4120 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4121 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4122 presumably because the widths might not match.
4123
4124 * window.c (size_window): Avoid needless test at loop start.
4125
4126 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4127
4128 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4129
4130 2011-05-12 Drew Adams <drew.adams@oracle.com>
4131
4132 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4133
4134 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4135
4136 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4137 `width' to `bar_area_x' and `bar_area_width', respectively.
4138 (x_scroll_run): Take account of fringe background extension.
4139
4140 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4141 Rename local vars `left' and `width' to `bar_area_x' and
4142 `bar_area_width', respectively.
4143 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4144 background extension.
4145
4146 2011-05-10 Jim Meyering <meyering@redhat.com>
4147
4148 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4149
4150 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * image.c (Finit_image_library): Return t for built-in image types,
4153 like pbm and xbm. (Bug#8640)
4154
4155 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4156
4157 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4158
4159 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4160
4161 * w32console.c (Fset_screen_color): Doc fix.
4162 (Fget_screen_color): New function.
4163 (syms_of_ntterm): Defsubr it.
4164
4165 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4166 unlink the temporary file if Fcall_process didn't create it in the
4167 first place.
4168 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4169 child process will be redirected to a file specified with `:file'.
4170 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4171 cue to call_process_cleanup not to close that handle.
4172
4173 2011-05-07 Ben Key <bkey76@gmail.com>
4174
4175 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4176 one of two shell specific rules, either bootstrap-temacs-CMD or
4177 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4178 to the previous implementation of the bootstrap-temacs rule.
4179 The bootstrap-temacs-CMD rule is similar to the previous
4180 implementation of the bootstrap-temacs rule except that it
4181 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4182 variable.
4183
4184 These changes, along with some changes to nt/configure.bat,
4185 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4186 earlier fix to add support for --cflags and --ldflags options
4187 that include quotes so that it works whether make uses cmd or
4188 sh as the shell.
4189
4190 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4191
4192 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4193 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4194 is a constant.
4195 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4196 a string. Handle both cases.
4197 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4198 (Fdbus_register_method): Use Qinvalid_function.
4199
4200 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4201
4202 * makefile.w32-in: Update dependencies.
4203 (LISP_H): Add inttypes.h and stdin.h.
4204 (PROCESS_H): Add unistd.h.
4205
4206 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4207
4208 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4209 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4210
4211 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4214
4215 * term.c (vfatal): Remove stray call to va_end.
4216 It's not needed and the C Standard doesn't allow it here anyway.
4217
4218 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4219 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4220
4221 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4222 bytes.
4223
4224 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4225
4226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4227
4228 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4229
4230 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4231
4232 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4233
4234 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4235 * charset.c (Fdefine_charset_internal): Don't initialize
4236 charset.code_space[15]. The value was garbage, on hosts with
4237 32-bit int (Bug#8600).
4238
4239 * lread.c (read_integer): Be more consistent with string-to-number.
4240 Use string_to_number to do the actual conversion; this avoids
4241 rounding errors and fixes some other screwups. Without this fix,
4242 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4243 (digit_to_number): Move earlier, for benefit of read_integer.
4244 Return -1 if the digit is out of range for the base, -2 if it is
4245 not a digit in any supported base. (Bug#8602)
4246
4247 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4248
4249 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4250 to match comment at start of function. This also removes a
4251 GCC warning about overflow in a 32+64-bit port.
4252
4253 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4254
4255 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4256 Reported by Stefan Monnier in
4257 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4258 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4259 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4260
4261 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4262 (EMACS_UINTPTR): Likewise, with uintptr_t.
4263
4264 * lisp.h: Prefer 64-bit EMACS_INT if available.
4265 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4266 on 32-bit hosts that have 64-bit int, so that they can access
4267 large files.
4268 However, temporarily disable this change unless the temporary
4269 symbol WIDE_EMACS_INT is defined.
4270
4271 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4272
4273 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4274 This removes an assumption that EMACS_INT and long are the same
4275 width as pointers. The assumption is true for Emacs porting targets
4276 now, but we want to make other targets possible.
4277 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4278 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4279 In the rest of the code, change types of integers that hold casted
4280 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4281 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4282 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4283 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4284 No need to cast type when ORing.
4285 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4286 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4287 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4288 assume EMACS_INT is the same width as char *.
4289 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4290 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4291 Remove no-longer-needed casts.
4292 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4293 (xg_tool_bar_help_callback, xg_make_tool_item):
4294 Use EMACS_INTPTR to hold an integer
4295 that will be cast to void *; this can avoid a GCC warning
4296 if EMACS_INT is not the same width as void *.
4297 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4298 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4299 (current_message_1, set_message_1):
4300 Use a local to convert to proper width without a cast.
4301 * xmenu.c (dialog_selection_callback): Likewise.
4302
4303 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4304 Also, don't assume VALBITS / RAND_BITS is less than 5,
4305 and don't rely on undefined behavior when shifting a 1 left into
4306 the sign bit.
4307 * lisp.h (get_random): Change signature to match.
4308
4309 * lread.c (hash_string): Use size_t, not int, for hash computation.
4310 Normally we prefer signed values; but hashing is special, because
4311 it's better to use unsigned division on hash table sizes so that
4312 the remainder is nonnegative. Also, size_t is the natural width
4313 for hashing into memory. The previous code used 'int', which doesn't
4314 retain enough info to hash well into very large tables.
4315 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4316
4317 * dbusbind.c: Don't possibly lose pointer info when converting.
4318 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4319 Use XPNTR rather than XHASH, so that the high-order bits of
4320 the pointer aren't lost when converting through void *.
4321
4322 * eval.c (Fautoload): Don't double-shift a pointer.
4323
4324 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4325
4326 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4327
4328 * gnutls.c (DEF_GNUTLS_FN):
4329 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4330
4331 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4332
4333 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4334 marker. (Bug#8610)
4335
4336 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4337
4338 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4339 New version that can reserve upto 2GB of heap space.
4340
4341 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4342
4343 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4344
4345 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4346
4347 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4348 `gnutls_certificate_set_x509_key_file'.
4349
4350 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4351
4352 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4353 Update dependencies.
4354
4355 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4356
4357 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4358 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4359 Remove unused parameter `fildes'.
4360 * process.c (read_process_output, send_process): Don't pass it.
4361
4362 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4363
4364 Fix previous change: the library cache is defined in w32.c.
4365 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4366 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4367
4368 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4369
4370 Implement dynamic loading of GnuTLS on Windows.
4371
4372 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4373 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4374 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4375 Declare.
4376
4377 * gnutls.c (Qgnutls_dll): Define.
4378 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4379 (gnutls_*): Declare function pointers.
4380 (init_gnutls_functions): New function to initialize function pointers.
4381 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4382 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4383 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4384 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4385 (emacs_gnutls_write, emacs_gnutls_read)
4386 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4387 (Fgnutls_available_p): New function.
4388 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4389 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4390 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4391
4392 * image.c: Include w32.h.
4393 (Vimage_type_cache): Delete.
4394 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4395 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4396 (w32_delayed_load): Move to w32.c.
4397
4398 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4399
4400 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4401 (w32_delayed_load): Move from image.c. When loading a library, record
4402 its filename in the :loaded-from property of the library id.
4403 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4404 Initialize and staticpro them.
4405 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4406
4407 * process.c: Include lisp.h before w32.h, not after.
4408 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4409 instead of gnutls_record_check_pending.
4410
4411 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4412
4413 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4414
4415 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4416 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4417 as passed in.
4418
4419 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4420
4421 * xterm.c (x_set_frame_alpha): Do not set property on anything
4422 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4423
4424 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4425
4426 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4427
4428 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4431 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4432 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4433 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4434 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4435 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4436 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4437 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4438 (Qgnutls_bootprop_callbacks_verify): Make static.
4439
4440 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4441
4442 * callproc.c: Indentation fixup.
4443
4444 * sysdep.c (wait_for_termination_1): Make static.
4445 (wait_for_termination, interruptible_wait_for_termination):
4446 Move after wait_for_termination_1.
4447
4448 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4449
4450 * sysdep.c (interruptible_wait_for_termination): New function
4451 which is like wait_for_termination, but allows keyboard
4452 interruptions.
4453
4454 * callproc.c (Fcall_process): Add (:file "file") as an option for
4455 the STDOUT buffer.
4456 (Fcall_process_region): Ditto.
4457
4458 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4459
4460 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4461 rather than `XVECTOR (FOO)->size'.
4462
4463 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4464 inttypes.h, as a gnulib replacement is used if it not available in
4465 system headers.
4466
4467 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4468
4469 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4470 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4471 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4472
4473 * coding.c (coding_alloc_by_realloc): Error out if destination
4474 will grow beyond MOST_POSITIVE_FIXNUM.
4475 (decode_coding_emacs_mule): Abort if there isn't enough place in
4476 charbuf for the composition carryover bytes. Reserve an extra
4477 space for up to 2 characters produced in a loop.
4478 (decode_coding_iso_2022): Abort if there isn't enough place in
4479 charbuf for the composition carryover bytes.
4480
4481 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4482
4483 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4484 aborting when %lld or %lll format is passed.
4485 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4486 %llo or %llx format is passed. (Bug#8545)
4487
4488 * window.c (window_scroll_line_based): Use a marker instead of
4489 simple variables to record original value of point. (Bug#7952)
4490
4491 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4492 produced by %s or %c overflows available buffer space. (Bug#8545)
4493
4494 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4495
4496 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4497 (SIZE_MAX): Move defn after all includes, as they might #define it.
4498
4499 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4500
4501 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4502
4503 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * keyboard.c (Qdelayed_warnings_hook): Define.
4506 (command_loop_1): Run `delayed-warnings-hook'
4507 if Vdelayed_warnings_list is non-nil.
4508 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4509 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4510
4511 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4512
4513 * doprnt.c (doprnt): Don't return value smaller than the buffer
4514 size if the message was truncated. (Bug#8545).
4515
4516 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4517
4518 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4519 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4520
4521 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4522
4523 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4524
4525 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4526
4527 * makefile.w32-in: Update dependencies.
4528
4529 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4530
4531 Improve `doprnt' and its usage. (Bug#8545)
4532 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4533 `format_end'. Remove support for %l as a conversion specifier.
4534 Don't use xrealloc. Improve diagnostics when the %l size modifier
4535 is used. Update the commentary.
4536
4537 * eval.c (verror): Simplify calculation of size_t.
4538
4539 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4540 messages.
4541
4542 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4543
4544 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4545 change.
4546
4547 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4548
4549 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4550 This makes this file independent of the recent pseudovector change.
4551
4552 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4555
4556 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4557 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4558 Remove unused local.
4559 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4560
4561 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4562 GCC 4.6.0 optimizes based on type-based alias analysis.
4563 For example, if b is of type struct buffer * and v of type struct
4564 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4565 != &v->size, and therefore "v->size = 1; b->size = 2; return
4566 v->size;" must therefore return 1. This assumption is incorrect
4567 for Emacs, since it type-puns struct Lisp_Vector * with many other
4568 types. To fix this problem, this patch adds a new type struct
4569 vectorlike_header that documents the constraints on layout of vectors
4570 and pseudovectors, and helps optimizing compilers not get fooled
4571 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4572 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4573 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4574 the size member.
4575 (XSETPVECTYPE): Rewrite in terms of new macro.
4576 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4577 This is a bit clearer, and further avoids the possibility of
4578 undesirable aliasing.
4579 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4580 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4581 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4582 since Lisp_Subr is a special case (no "next" field).
4583 (ASIZE): Now uses header.size rather than size.
4584 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4585 to avoid the hassle of writing XVECTOR (foo)->header.size.
4586 (struct vectorlike_header): New type.
4587 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4588 object, to help avoid aliasing.
4589 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4590 (SUBRP): Likewise, since Lisp_Subr is a special case.
4591 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4592 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4593 (struct Lisp_Hash_Table): Combine first two members into a single
4594 struct vectorlike_header member. All uses of "size" and "next" members
4595 changed to be "header.size" and "header.next".
4596 * buffer.h (struct buffer): Likewise.
4597 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4598 * frame.h (struct frame): Likewise.
4599 * process.h (struct Lisp_Process): Likewise.
4600 * termhooks.h (struct terminal): Likewise.
4601 * window.c (struct save_window_data, struct saved_window): Likewise.
4602 * window.h (struct window): Likewise.
4603 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4604 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4605 * buffer.c (init_buffer_once): Likewise.
4606 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4607 special case.
4608 * process.c (Fformat_network_address): Use local var for size,
4609 for brevity.
4610
4611 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4612
4613 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4614 * data.c (atof): Remove decl; no longer used or needed.
4615 (digit_to_number): Move to lread.c.
4616 (Fstring_to_number): Use new string_to_number function, to be
4617 consistent with how the Lisp reader treats infinities and NaNs.
4618 Do not assume that floating-point numbers represent EMACS_INT
4619 without losing information; this is not true on most 64-bit hosts.
4620 Avoid double-rounding errors, by insisting on integers when
4621 parsing non-base-10 numbers, as the documentation specifies.
4622 * lisp.h (string_to_number): New decl, replacing ...
4623 (isfloat_string): Remove.
4624 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4625 (read1): Do not accept +. and -. as integers; this
4626 appears to have been a coding error. Similarly, do not accept
4627 strings like +-1e0 as floating point numbers. Do not report
4628 overflow for integer overflows unless the base is not 10 which
4629 means we have no simple and reliable way to continue.
4630 Break out the floating-point parsing into a new
4631 function string_to_number, so that Fstring_to_number parses
4632 floating point numbers consistently with the Lisp reader.
4633 (digit_to_number): Move here from data.c. Make it static inline.
4634 (E_CHAR, EXP_INT): Remove, replacing with ...
4635 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4636 (string_to_number): New function, replacing isfloat_string.
4637 This function checks for valid syntax and produces the resulting
4638 Lisp float number too. Rework it so that string-to-number
4639 no longer mishandles examples like "1.0e+". Use strtoumax,
4640 so that overflow for non-base-10 numbers is reported only when
4641 there's no portable and simple way to convert to floating point.
4642
4643 * textprop.c (set_text_properties_1): Rewrite for clarity,
4644 and to avoid GCC warning about integer overflow.
4645
4646 * intervals.h (struct interval): Use EMACS_INT for members
4647 where EMACS_UINT might cause problems. See
4648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4649 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4650 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4651 All uses changed.
4652 (offset_intervals): Tell GCC not to worry about length overflow
4653 when negating a negative length.
4654
4655 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4656 (overrun_check_free): Likewise.
4657
4658 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4659 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4660 word size.
4661
4662 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4663 (gnutls_make_error): Rename local to avoid shadowing.
4664 (gnutls_emacs_global_deinit): ifdef out; not used.
4665 (Fgnutls_boot): Use const for pointer to readonly storage.
4666 Comment out unused local. Fix pointer signedness problems.
4667
4668 * lread.c (openp): Don't stuff size_t into an 'int'.
4669 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4670 about possible signed overflow.
4671
4672 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4673 (GDK_KEY_g): Don't define if already defined.
4674 (xg_prepare_tooltip): Avoid pointer signedness problem.
4675 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4676
4677 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4678 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4679
4680 * xfns.c (Fx_window_property): Simplify a bit,
4681 to make a bit faster and to avoid GCC 4.6.0 warning.
4682 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4683
4684 * fns.c (internal_equal): Don't assume size_t fits in int.
4685
4686 * alloc.c (compact_small_strings): Tighten assertion a little.
4687
4688 Replace pEd with more-general pI, and fix some printf arg casts.
4689 * lisp.h (pI): New macro, generalizing old pEd macro to other
4690 conversion specifiers. For example, use "...%"pI"d..." rather
4691 than "...%"pEd"...".
4692 (pEd): Remove. All uses replaced with similar uses of pI.
4693 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4694 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4695 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4696 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4697 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4698 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4699 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4700 64-bit hosts.
4701 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4702 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4703 * print.c (safe_debug_print, print_object): Likewise.
4704 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4705 to int.
4706 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4707 avoiding the 0 flag, which is not portable.
4708 * process.c (Fmake_network_process): Use pI to avoid cast.
4709 * region-cache.c (pp_cache): Likewise.
4710 * xdisp.c (decode_mode_spec): Likewise.
4711 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4712 behavior on 64-bit hosts with printf arg.
4713 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4714 (x_stop_queuing_selection_requests): Likewise.
4715 (x_get_window_property): Don't truncate byte count to an 'int'
4716 when tracing.
4717
4718 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4719 here, since it parses constructs like leading '-' and spaces,
4720 which are not wanted; and it overflows with large numbers.
4721 Instead, simply match F[0-9]+, which is what is wanted anyway.
4722
4723 * alloc.c: Remove unportable assumptions about struct layout.
4724 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4725 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4726 (allocate_vectorlike, make_pure_vector): Use the new macros,
4727 plus offsetof, to remove unportable assumptions about struct layout.
4728 These assumptions hold on all porting targets that I know of, but
4729 they are not guaranteed, they're easy to remove, and removing them
4730 makes further changes easier.
4731
4732 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4733 This doesn't fix a bug but makes the code clearer.
4734 (string_overrun_cookie): Now const. Use initializers that
4735 don't formally overflow signed char, to avoid warnings.
4736 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4737 can cause Emacs to crash when string overrun checking is enabled.
4738 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4739 multiple of sizeof (EMACS_INT); it need not be, if
4740 alignof(EMACS_INT) < sizeof (EMACS_INT).
4741 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4742
4743 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4744
4745 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4746
4747 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4748
4749 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4750 supposed to be handshaking. (Bug#8556)
4751 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4752
4753 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4754
4755 * lisp.h (Qdebug): List symbol.
4756 * eval.c (Qdebug): Restore global linkage.
4757 * keyboard.c (debug-on-event): New variable.
4758 (handle_user_signal): Break into debugger when debug-on-event
4759 matches the current signal symbol.
4760
4761 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4762
4763 * alloc.c (check_sblock, check_string_bytes)
4764 (check_string_free_list): Convert to standard C.
4765
4766 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4767
4768 * w32.c (emacs_gnutls_push): Fix typo.
4769
4770 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4771
4772 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4773 "cast to pointer from integer of different size".
4774
4775 Improve doprnt and its use in verror. (Bug#8545)
4776 * doprnt.c (doprnt): Document the set of format control sequences
4777 supported by the function. Use SAFE_ALLOCA instead of always
4778 using `alloca'.
4779
4780 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4781 is one byte too soon. Don't use xrealloc; instead xfree and
4782 xmalloc anew.
4783
4784 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4785
4786 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4787 callbacks stage.
4788
4789 * gnutls.c: Renamed global_initialized to
4790 gnutls_global_initialized. Added internals for the
4791 :verify-hostname-error, :verify-error, and :verify-flags
4792 parameters of `gnutls-boot' and documented those parameters in the
4793 docstring. Start callback support.
4794 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4795 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4796 on error. Return error code.
4797 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4798 (emacs_gnutls_read): Likewise.
4799 (Fgnutls_boot): Return handshake error code.
4800 (emacs_gnutls_handle_error): New function.
4801 (wsaerror_to_errno): Likewise.
4802
4803 * w32.h (emacs_gnutls_pull): Add prototype.
4804 (emacs_gnutls_push): Likewise.
4805
4806 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4807 (emacs_gnutls_push): Likewise.
4808
4809 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4810
4811 * process.c (wait_reading_process_output): Check if GnuTLS
4812 buffered some data internally if no FDs are set for TLS
4813 connections.
4814
4815 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4816 (LIBS): Link to USER_LIBS.
4817 ($(BLD)/gnutls.$(0)): New target.
4818
4819 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4820
4821 * xdisp.c (handle_single_display_spec): Rename the
4822 display_replaced_before_p argument into display_replaced_p, to
4823 make it consistent with the commentary. Fix typos in the
4824 commentary.
4825
4826 * textprop.c (syms_of_textprop): Remove dead code.
4827 (copy_text_properties): Delete obsolete commentary about an
4828 interface that was deleted long ago. Fix typos in the description
4829 of arguments.
4830
4831 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4832 to changes in oldXMenu/XMenu.h from 2011-04-16.
4833 <menu_help_message, prev_menu_help_message>: Constify.
4834 (IT_menu_make_room): menu->help_text is now `const char **';
4835 adjust.
4836
4837 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4838 to changes in oldXMenu/XMenu.h from 2011-04-16.
4839 (struct XMenu): Declare `help_text' `const char **'.
4840
4841 * xfaces.c <Qunspecified>: Make extern again.
4842
4843 * syntax.c: Include sys/types.h before including regex.h, as
4844 required by Posix.
4845
4846 * doc.c (get_doc_string): Improve the format passed to `error'.
4847
4848 * doprnt.c (doprnt): Improve commentary.
4849
4850 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4851
4852 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4853 them with etags.
4854
4855 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4856 changes in globals.h immediately force recompilation.
4857 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4858 $(CURDIR)/s/ms-w32.h.
4859 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4860
4861 * character.c (Fchar_direction): Function deleted.
4862 (syms_of_character): Don't defsubr it.
4863 <char-direction-table>: Deleted.
4864
4865 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4866
4867 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4868 * doprnt.c: Include limits.h.
4869 (SIZE_MAX): New macro.
4870 (doprnt): Return a size_t value. 2nd arg is now size_t.
4871 Many local variables are now size_t instead of int or unsigned.
4872 Improve overflow protection. Support `l' modifier for integer
4873 conversions. Support %l conversion. Don't assume an EMACS_INT
4874 argument for integer conversions and for %c.
4875
4876 * lisp.h (doprnt): Restore prototype.
4877
4878 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4879 $(SRC)/character.h.
4880
4881 * Makefile.in (base_obj): Add back doprnt.o.
4882
4883 * deps.mk (doprnt.o): Add back prerequisites.
4884 (callint.o): Depend on character.h.
4885
4886 * eval.c (internal_lisp_condition_case): Include the handler
4887 representation in the error message.
4888 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4889 when breaking from the loop.
4890
4891 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4892
4893 * callint.c (Fcall_interactively): When displaying error message
4894 about invalid control letter, pass the character's codepoint, not
4895 a pointer to its multibyte form. Improve display of the character
4896 in octal and display also its hex code.
4897
4898 * character.c (char_string): Use %x to display the (unsigned)
4899 codepoint of an invalid character, to avoid displaying a bogus
4900 negative value.
4901
4902 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4903 `error', not SYMBOL_NAME itself.
4904
4905 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4906 character arguments to `error'.
4907
4908 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4909 to `error' in error message about FINAL_CHAR argument. Make sure
4910 FINAL_CHAR is a character, and use %c when it is passed as
4911 argument to `error'.
4912
4913 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4914
4915 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4916
4917 * w32.c: Include <time.h>.
4918 (sys_localtime): New function.
4919
4920 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4921
4922 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4923
4924 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4925
4926 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4927
4928 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4929 zombies (Bug#8467).
4930
4931 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4932
4933 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4934 gl_state.e_property when gl_state.object is Qt.
4935
4936 * insdel.c (make_gap_larger): Remove limitation of buffer size
4937 to <= INT_MAX.
4938
4939 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4940
4941 * xdisp.c (lookup_glyphless_char_display)
4942 (produce_glyphless_glyph): Handle cons cell entry in
4943 glyphless-char-display.
4944 (Vglyphless_char_display): Document it.
4945
4946 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4947 glyphless-char-display.
4948
4949 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4950
4951 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4952
4953 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4954
4955 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4956 definition for no-X builds.
4957
4958 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 Static checks with GCC 4.6.0 and non-default toolkits.
4961
4962 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4963
4964 * process.c (keyboard_bit_set): Define only if SIGIO.
4965 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4966 (send_process): Repair possible setjmp clobbering.
4967
4968 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4969
4970 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4971
4972 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4973
4974 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4975 Define only if needed.
4976
4977 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4978 by pacifying GCC about it. Maybe it's time to retire it?
4979 * xfaces.c (USG, __TIMEVAL__): Likewise.
4980
4981 * dispextern.h (struct redisplay_interface): Rename param
4982 to avoid shadowing.
4983 * termhooks.h (struct terminal): Likewise.
4984 * xterm.c (xembed_send_message): Likewise.
4985
4986 * insdel.c (make_gap_smaller): Define only if
4987 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4988
4989 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4990 it.
4991
4992 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4993 so that we aren't warned about unused symbols.
4994
4995 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4996
4997 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4998
4999 * xfns.c (x_real_positions): Mark locals as initialized.
5000
5001 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5002
5003 * xterm.c: Fix problems found by static analysis with other toolkits.
5004 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5005 (x_dispatch_event): Declare static if USE_GTK, and
5006 define if USE_GTK || USE_X_TOOLKIT.
5007 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5008 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5009 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5010 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5011
5012 * xmenu.c (menu_help_callback): Pointer type fixes.
5013 Use const pointers when pointing at readonly data. Avoid pointer
5014 signedness clashes.
5015 (FALSE): Remove unused macro.
5016 (update_frame_menubar): Remove unused decl.
5017
5018 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5019
5020 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5021 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5022 (single_menu_item): Rename local to avoid shadowing.
5023
5024 * keyboard.c (make_lispy_event): Remove unused local var.
5025
5026 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5027 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5028
5029 * bitmaps: Change bitmaps from unsigned char back to the X11
5030 compatible char. Avoid the old compiler warnings about
5031 out-of-range initializers by using, for example, '\xab' rather
5032 than 0xab.
5033
5034 * xgselect.c (xgselect_initialize): Check vs interface
5035 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5036
5037 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5038
5039 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5040 to read-only memory.
5041
5042 * fns.c (vector): Remove; this old hack is no longer needed.
5043
5044 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5045 Remove unused var.
5046 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5047
5048 * xrdb.c (x_load_resources): Omit unused local.
5049
5050 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5051 (x_window): Rename locals to avoid shadowing.
5052 (USG): Use the kludged USG macro, to pacify gcc.
5053
5054 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5055 (x_term_init): Remove local to avoid shadowing.
5056
5057 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5058
5059 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5060 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5061
5062 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5063
5064 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5065
5066 Fix regex.c, syntax.c and friends for buffers > 2GB.
5067 * syntax.h (struct gl_state_s): Declare character position members
5068 EMACS_INT.
5069
5070 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5071
5072 * textprop.c (verify_interval_modification, interval_of):
5073 Declare arguments EMACS_INT.
5074
5075 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5076 EMACS_INT.
5077
5078 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5079
5080 * indent.c (Fvertical_motion): Local variable it_start is now
5081 EMACS_INT.
5082
5083 * regex.c (re_match, re_match_2, re_match_2_internal)
5084 (bcmp_translate, regcomp, regexec, print_double_string)
5085 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5086 (re_compile_pattern, re_exec): Declare arguments and local
5087 variables `size_t' and `ssize_t' and return values `regoff_t', as
5088 appropriate.
5089 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5090 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5091 <compile_stack_type>: `size' and `avail' are now `size_t'.
5092
5093 * regex.h <regoff_t>: Use ssize_t, not int.
5094 (re_search, re_search_2, re_match, re_match_2): Arguments that
5095 specify buffer/string position and length are now ssize_t and
5096 size_t. Return type is regoff_t.
5097
5098 2011-04-16 Ben Key <bkey76@gmail.com>
5099
5100 * nsfont.m: Fixed bugs in ns_get_family and
5101 ns_descriptor_to_entity that were caused by using free to
5102 deallocate memory blocks that were allocated by xmalloc (via
5103 xstrdup). This caused Emacs to crash when compiled with
5104 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5105 --enable-checking=xmallocoverrun). xfree is now used to
5106 deallocate these memory blocks.
5107
5108 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5111
5112 emacs_write: Accept and return EMACS_INT for sizes.
5113 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5114 et seq.
5115 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5116 Accept and return EMACS_INT.
5117 (emacs_gnutls_write): Return the number of bytes written on
5118 partial writes.
5119 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5120 (emacs_read, emacs_write): Remove check for negative size, as the
5121 Emacs source code has been audited now.
5122 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5123 (emacs_read, emacs_write): Use it.
5124 * process.c (send_process): Adjust to the new signatures of
5125 emacs_write and emacs_gnutls_write. Do not attempt to store
5126 a byte offset into an 'int'; it might overflow.
5127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5128
5129 * sound.c: Don't assume sizes fit in 'int'.
5130 (struct sound_device.period_size, alsa_period_size):
5131 Return EMACS_INT, not int.
5132 (struct sound_device.write, vox_write, alsa_write):
5133 Accept EMACS_INT, not int.
5134 (wav_play, au_play): Use EMACS_INT to store sizes and to
5135 record read return values.
5136
5137 2011-04-15 Ben Key <bkey76@gmail.com>
5138
5139 * keyboard.c (Qundefined): Don't declare static since it is used
5140 in nsfns.m.
5141 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5142 static since they are used in nsfont.m.
5143
5144 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5145
5146 * process.c (Qprocessp): Don't declare static.
5147 * lisp.h (Qprocessp): Declare again.
5148
5149 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5150
5151 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5152
5153 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 Improve C-level modularity by making more things 'static'.
5156
5157 Don't publish debugger-only interfaces to other modules.
5158 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5159 (verify_bytepos, count_markers): Move decls to the only modules
5160 that need them.
5161 * region-cache.h (pp_cache): Likewise.
5162 * window.h (check_all_windows): Likewise.
5163 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5164
5165 * sysdep.c (croak): Now static, if
5166 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5167 * syssignal.h (croak): Declare only if not static.
5168
5169 * alloc.c (refill_memory_reserve): Now static if
5170 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5171 * lisp.h (refill_memory_reserve): Declare only if not static.
5172
5173 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5174 Define only if USE_LUCID.
5175
5176 * xrdb.c (x_customization_string, x_rm_string): Now static.
5177
5178 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5179 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5180
5181 * xdisp.c (draw_row_with_mouse_face): Now static.
5182 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5183
5184 * window.h (check_all_windows): Mark externally visible.
5185
5186 * window.c (window_deletion_count): Now static.
5187
5188 * undo.c: Make symbols static if they're not exported.
5189 (last_undo_buffer, last_boundary_position, pending_boundary):
5190 Now static.
5191
5192 * textprop.c (interval_insert_behind_hooks): Now static.
5193 (interval_insert_in_front_hooks): Likewise.
5194
5195 * term.c: Make symbols static if they're not exported.
5196 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5197 (max_frame_lines, tty_set_terminal_modes):
5198 (tty_reset_terminal_modes, tty_turn_off_highlight):
5199 (get_tty_terminal): Now static.
5200 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5201 * termhooks.h (term_mouse_moveto): Do not declare if
5202 HAVE_WINDOW_SYSTEM.
5203 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5204 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5205
5206 * sysdep.c: Make symbols static if they're not exported.
5207 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5208 Now static.
5209 (sigprocmask_set, full_mask): Remove; unused.
5210 (wait_debugging): Mark as visible.
5211 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5212 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5213
5214 * syntax.c (syntax_temp): Define only if !__GNUC__.
5215
5216 * sound.c (current_sound_device, current_sound): Now static.
5217
5218 * search.c (searchbufs, searchbuf_head): Now static.
5219
5220 * scroll.c (scroll_cost): Remove; unused.
5221 * dispextern.h (scroll_cost): Remove decl.
5222
5223 * region-cache.h (pp_cache): Mark as externally visible.
5224
5225 * process.c: Make symbols static if they're not exported.
5226 (process_tick, update_tick, create_process, chan_process):
5227 (Vprocess_alist, proc_buffered_char, datagram_access):
5228 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5229 (deactivate_process): Mark defn as static, as well as decl.
5230 * lisp.h (create_process): Remove decl.
5231 * process.h (chan_process, Vprocess_alist): Remove decls.
5232
5233 * print.c: Make symbols static if they're not exported.
5234 (print_depth, new_backquote_output, being_printed, print_buffer):
5235 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5236 (print_interval, print_number_index, initial_stderr_stream):
5237 Now static.
5238 * lisp.h (Fprinc): Remove decl.
5239 (debug_output_compilation_hack): Mark as externally visible.
5240
5241 * sysdep.c (croak): Move decl from here to syssignal.h.
5242 * syssignal.h (croak): Put it here, so the API can be checked when
5243 'croak' is called from dissociate_if_controlling_tty.
5244
5245 * minibuf.c: Make symbols static if they're not exported.
5246 (minibuf_save_list, choose_minibuf_frame): Now static.
5247 * lisp.h (choose_minibuf_frame): Remove decl.
5248
5249 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5250
5251 * lread.c: Make symbols static if they're not exported.
5252 (read_objects, initial_obarray, oblookup_last_bucket_number):
5253 Now static.
5254 (make_symbol): Remove; unused.
5255 * lisp.h (initial_obarray, make_symbol): Remove decls.
5256
5257 * keyboard.c: Make symbols static if they're not exported.
5258 (single_kboard, recent_keys_index, total_keys, recent_keys):
5259 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5260 (this_single_command_key_start, echoing, last_auto_save):
5261 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5262 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5263 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5264 (Vlispy_mouse_stem, double_click_count):
5265 Now static.
5266 (force_auto_save_soon): Define only if SIGDANGER.
5267 (ignore_mouse_drag_p): Now static if
5268 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5269 (print_help): Remove; unused.
5270 (stop_character, last_timer_event): Mark as externally visible.
5271 * keyboard.h (ignore_mouse_drag_p): Declare only if
5272 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5273 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5274 * lisp.h (echoing): Remove decl.
5275 (force_auto_save_soon): Declare only if SIGDANGER.
5276 * xdisp.c (redisplay_window): Simplify code, to make it more
5277 obvious that ignore_mouse_drag_p is not accessed if !defined
5278 USE_GTK && !defined HAVE_NS.
5279
5280 * intervals.c: Make symbols static if they're not exported.
5281 (merge_properties_sticky, merge_interval_right, delete_interval):
5282 Now static.
5283 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5284
5285 * insdel.c: Make symbols static if they're not exported.
5286 However, leave prepare_to_modify_buffer alone. It's never
5287 called from outside this function, but that appears to be a bug.
5288 (combine_after_change_list, combine_after_change_buffer):
5289 (adjust_after_replace, signal_before_change): Now static.
5290 (adjust_after_replace_noundo): Remove; unused.
5291 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5292 (signal_before_change): Remove decls.
5293
5294 * indent.c (val_compute_motion, val_vmotion): Now static.
5295
5296 * image.c: Make symbols static if they're not exported.
5297 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5298 if USE_GTK.
5299 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5300 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5301
5302 * fringe.c (standard_bitmaps): Now static.
5303 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5304
5305 * frame.c: Make symbols static if they're not exported.
5306 (x_report_frame_params, make_terminal_frame): Now static.
5307 (get_frame_param): Now static, unless HAVE_NS.
5308 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5309 (x_get_resource_string): Remove; not used.
5310 * frame.h (make_terminal_frame, x_report_frame_params):
5311 (x_get_resource_string); Remove decls.
5312 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5313 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5314
5315 * font.c, fontset.c: Make symbols static if they're not exported.
5316 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5317 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5318 * font.c (font_close_object): Now static.
5319 * font.h (font_close_object): Remove.
5320 * fontset.c (FONTSET_OBJLIST): Remove.
5321 (free_realized_fontset) #if-0 the body, which does nothing.
5322 (face_suitable_for_char_p): #if-0, as it's never called.
5323 * fontset.h (face_suitable_for_char_p): Remove decl.
5324 * xfaces.c (face_at_string_position):
5325 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5326 since 0 is always ASCII.
5327
5328 * fns.c (weak_hash_tables): Now static.
5329
5330 * fileio.c: Make symbols static if they're not exported.
5331 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5332 (Vwrite_region_annotation_buffers): Now static.
5333
5334 * eval.c: Make symbols static if they're not exported.
5335 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5336 * lisp.h (backtrace_list): Remove decl.
5337
5338 * emacs.c: Make symbols static if they're not exported.
5339 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5340 (fatal_error_code, fatal_error_signal_hook, standard_args):
5341 Now static.
5342 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5343 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5344 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5345 * lisp.h (fatal_error_signal_hook): Remove decl.
5346 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5347
5348 * editfns.c: Move a (normally-unused) function to its only use.
5349 * editfns.c, lisp.h (get_operating_system_release): Remove.
5350 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5351 worth the hassle of breaking this out.
5352
5353 * xterm.c: Make symbols static if they're not exported.
5354 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5355 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5356 (x_destroy_window, x_delete_display):
5357 Now static.
5358 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5359 (x_mouse_leave): Remove; unused.
5360 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5361 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5362 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5363 Remove decls.
5364 (x_mouse_leave): Declare only if WINDOWSNT.
5365 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5366 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5367 USE_X_TOOLKIT.
5368
5369 * ftxfont.c: Make symbols static if they're not exported.
5370 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5371 HAVE_FREETYPE.
5372 * font.h (ftxfont_driver): Likewise.
5373
5374 * xfns.c: Make symbols static if they're not exported.
5375 (x_last_font_name, x_display_info_for_name):
5376 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5377 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5378 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5379 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5380 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5381 (last_show_tip_args): Now static.
5382 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5383 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5384 (x_screen_planes): Remove; unused.
5385 * dispextern.h (x_screen_planes): Remove decl.
5386
5387 * dispnew.c: Make symbols static if they're not exported.
5388 * dispextern.h (redraw_garbaged_frames, scrolling):
5389 (increment_row_positions): Remove.
5390 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5391 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5392 Now static.
5393 (redraw_garbaged_frames): Remove; unused.
5394
5395 * xfaces.c: Make symbols static if they're not exported.
5396 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5397 Remove decls.
5398 * xterm.h (defined_color): Remove decls.
5399 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5400 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5401 (menu_face_changed_default, defined_color, free_realized_face):
5402 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5403 (ascii_face_of_lisp_face): Remove; unused.
5404
5405 * xdisp.c: Make symbols static if they're not exported.
5406 * dispextern.h (scratch_glyph_row, window_box_edges):
5407 (glyph_to_pixel_coords, set_cursor_from_row):
5408 (get_next_display_element, set_iterator_to_next):
5409 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5410 (show_mouse_face): Remove decls
5411 * frame.h (message_buf_print): Likewise.
5412 * lisp.h (pop_message, set_message, check_point_in_composition):
5413 Likewise.
5414 * xterm.h (set_vertical_scroll_bar): Likewise.
5415 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5416 (message_buf_print, scratch_glyph_row, displayed_buffer):
5417 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5418 (get_next_display_element, show_mouse_face, window_box_edges):
5419 (frame_to_window_pixel_xy, check_point_in_composition):
5420 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5421 (glyph_to_pixel_coords): Remove; unused.
5422
5423 * dired.c (file_name_completion): Now static.
5424
5425 * dbusbind.c (xd_in_read_queued_messages): Now static.
5426
5427 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5428 * data.c (circular_list_error): Remove.
5429
5430 * commands.h (last_point_position, last_point_position_buffer):
5431 (last_point_position_window): Remove decls.
5432 * keyboard.c: Make these variables static.
5433
5434 * coding.h (coding, code_convert_region, encode_coding_gap):
5435 Remove decls.
5436 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5437 (iso_code_class, detect_coding, code_convert_region): Now static.
5438 (encode_coding_gap): Remove; unused.
5439
5440 * chartab.c (chartab_chars, chartab_bits): Now static.
5441
5442 * charset.h (charset_iso_8859_1): Remove decl.
5443 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5444 Now static.
5445
5446 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5447 * ccl.c (Vccl_program_table): Now static.
5448 (check_ccl_update): Remove; unused.
5449
5450 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5451 * category.h: ... from here.
5452 * category.c (check_category_table, set_category_set): Now static.
5453
5454 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5455 * lisp.h: Remove these decls.
5456
5457 * buffer.c (buffer_count): Remove unused var.
5458
5459 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5460 so that it's not optimized away.
5461 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5462 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5463 exported only to the debugger.
5464
5465 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5466 * atimer.h (run_all_atimers): Remove; not exported.
5467
5468 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5469 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5470 was inaccessible from Lisp.
5471 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5472 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5473
5474 alloc.c: Import and export fewer symbols, and remove unused items.
5475 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5476 is defined.
5477 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5478 it's not optimized away by whole-program optimization.
5479 (message_enable_multibyte, free_misc): Remove.
5480 (catchlist, handlerlist, mark_backtrace):
5481 Declare only if BYTE_MARK_STACK.
5482 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5483 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5484 (message_enable_multibyte): Remove decl.
5485 (free_misc, interval_free_list, float_block, float_block_index):
5486 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5487 (cons_free_list, last_marked_index):
5488 Now static.
5489 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5490 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5491 (mark_backtrace): Define only if BYTE_MARK_STACK.
5492 * xdisp.c (message_enable_multibyte): Now static.
5493
5494 Declare Lisp_Object Q* variables to be 'static' if not exported.
5495 This makes it easier for human readers (and static analyzers)
5496 to see whether these variables are used from other modules.
5497 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5498 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5499 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5500 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5501 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5502 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5503 * xmenu.c, xselect.c:
5504 Declare Q* vars static if they are not used in other modules.
5505 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5506 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5507 Remove decls of unexported vars.
5508 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5509
5510 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5511
5512 Make Emacs functions such as Fatom 'static' by default.
5513 This makes it easier for human readers (and static analyzers)
5514 to see whether these functions can be called from other modules.
5515 DEFUN now defines a static function. To make the function external
5516 so that it can be used in other C modules, use the new macro DEFUE.
5517 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5518 (Finit_image_library):
5519 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5520 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5521 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5522 Remove decls, since these functions are now static.
5523 (Funintern, Fget_internal_run_time): New decls, since these functions
5524 were already external.
5525
5526 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5527 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5528 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5529 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5530 * keyboard.c, keymap.c, lread.c:
5531 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5532 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5533 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5534 Mark functions with DEFUE instead of DEFUN,
5535 if they are used in other modules.
5536 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5537 decls for now-static functions.
5538 * buffer.h (Fdelete_overlay): Remove decl.
5539 * callproc.c (Fgetenv_internal): Mark as internal.
5540 * composite.c (Fremove_list_of_text_properties): Remove decl.
5541 (Fcomposition_get_gstring): New forward static decl.
5542 * composite.h (Fcomposite_get_gstring): Remove decl.
5543 * dired.c (Ffile_attributes): New forward static decl.
5544 * doc.c (Fdocumntation_property): New forward static decl.
5545 * eval.c (Ffetch_bytecode): New forward static decl.
5546 (Funintern): Remove extern decl; now in .h file where it belongs.
5547 * fileio.c (Fmake_symbolic_link): New forward static decl.
5548 * image.c (Finit_image_library): New forward static decl.
5549 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5550 * intervals.h (Fprevious_property_change):
5551 (Fremove_list_of_text_properties): Remove decls.
5552 * keyboard.c (Fthis_command_keys): Remove decl.
5553 (Fcommand_execute): New forward static decl.
5554 * keymap.c (Flookup_key): New forward static decl.
5555 (Fcopy_keymap): Now static.
5556 * keymap.h (Flookup_key): Remove decl.
5557 * process.c (Fget_process): New forward static decl.
5558 (Fprocess_datagram_address): Mark as internal.
5559 * syntax.c (Fsyntax_table_p): New forward static decl.
5560 (skip_chars): Remove duplicate decl.
5561 * textprop.c (Fprevious_property_change): New forward static decl.
5562 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5563 Now internal.
5564 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5565 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5566
5567 * editfns.c (Fformat): Remove unreachable code.
5568
5569 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5570
5571 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5572 change. (Bug#8496)
5573
5574 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5575
5576 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5577 when at ZV. (Bug#8487)
5578
5579 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5580
5581 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5582 (Bug#8437)
5583 * keyboard.c (parse_tool_bar_item): Likewise.
5584 * sound.c (sound_cleanup, alsa_close): Likewise.
5585 * termcap.c (tgetent): Likewise.
5586 * xfns.c (x_default_font_parameter): Likewise.
5587 * xsettings.c (read_and_apply_settings): Likewise.
5588
5589 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5590 (overrun_check_free): Protoize.
5591
5592 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5593
5594 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5595 since callers should never pass a negative size.
5596 Change the signature to match that of plain 'read' and 'write'; see
5597 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5598 * lisp.h: Update prototypes of emacs_write and emacs_read.
5599
5600 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5601
5602 * xdisp.c (redisplay_window): Don't try to determine the character
5603 position of the scroll margin if the window start point w->startp
5604 is outside the buffer's accessible region. (Bug#8468)
5605
5606 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5607
5608 Fix write-region and its subroutines for buffers > 2GB.
5609 * fileio.c (a_write, e_write): Modify declaration of arguments and
5610 local variables to support buffers larger than 2GB.
5611 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5612
5613 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5614 argument, local variables, and return value.
5615
5616 * lisp.h: Update prototypes of emacs_write and emacs_read.
5617
5618 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5619
5620 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5621
5622 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5623
5624 Fix more problems found by GCC 4.6.0's static checks.
5625
5626 * xdisp.c (vmessage): Use a better test for character truncation.
5627
5628 * charset.c (load_charset_map): <, not <=, for optimization,
5629 and to avoid potential problems with integer overflow.
5630 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5631 * casetab.c (set_identity, shuffle): Likewise.
5632 * editfns.c (Fformat): Likewise.
5633 * syntax.c (skip_chars): Likewise.
5634
5635 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5636 This also lets GCC 4.6.0 generate slightly better loop code.
5637
5638 * callint.c (Fcall_interactively): <, not <=, for optimization.
5639 (Fcall_interactively): Count the number of arguments produced,
5640 not the number of arguments given. This is simpler and lets GCC
5641 4.6.0 generate slightly better code.
5642
5643 * ftfont.c: Distingish more carefully between FcChar8 and char.
5644 The previous code passed unsigned char * to a functions like
5645 strlen and xstrcasecmp that expect char *, which does not
5646 conform to the C standard.
5647 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5648 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5649 char * when the C standard requires it.
5650
5651 * keyboard.c (read_char): Remove unused var.
5652
5653 * eval.c: Port to Windows vsnprintf (Bug#8435).
5654 Include <limits.h>.
5655 (SIZE_MAX): Define if the headers do not.
5656 (verror): Do not give up if vsnprintf returns a negative count.
5657 Instead, grow the buffer. This ports to Windows vsnprintf, which
5658 does not conform to C99. Problem reported by Eli Zaretskii.
5659 Also, simplify the allocation scheme, by avoiding the need for
5660 calling realloc, and removing the ALLOCATED variable.
5661
5662 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5663
5664 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5665 But keep the doprint source code for now, as we might revamp it
5666 and use it again (Bug#8435).
5667 * lisp.h (doprnt): Remove.
5668 * Makefile.in (base_obj): Remove doprnt.o.
5669 * deps.mk (doprnt.o): Remove.
5670
5671 error: Print 32- and 64-bit integers portably (Bug#8435).
5672 Without this change, on typical 64-bit hosts error ("...%d...", N)
5673 was used to print both 32- and 64-bit integers N, which relied on
5674 undefined behavior.
5675 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5676 New macro.
5677 * lisp.h (error, verror): Mark as printf-like functions.
5678 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5679 Report overflow in size calculations when allocating printf buffer.
5680 Do not truncate output string at its first null byte.
5681 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5682 Truncate the output at a character boundary, since vsnprintf does not
5683 do that.
5684 * charset.c (check_iso_charset_parameter): Convert internal
5685 character to string before calling 'error', since %c now has the
5686 printf meaning.
5687 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5688 overflow when computing char to be passed to 'error'. Do not
5689 pass Lisp_Object to 'error'; pass the integer instead.
5690 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5691 formatted with plain %d.
5692
5693 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5694
5695 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5696
5697 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5698
5699 * xterm.c (x_catch_errors): Remove duplicate declaration.
5700
5701 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5702
5703 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5704
5705 2011-04-10 Jim Meyering <meyering@redhat.com>
5706
5707 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5708 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5709 return ssize_t not "int", and use size_t as the buffer length.
5710 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5711 * gnutls.h: Update declarations.
5712 * process.c (read_process_output): Use ssize_t, to match.
5713 (send_process): Likewise.
5714
5715 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5716
5717 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5718
5719 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5720
5721 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5722 Use unsigned char, to match FcChar8 type definition.
5723
5724 * xterm.c (handle_one_xevent):
5725 * xmenu.c (create_and_show_popup_menu):
5726 * xselect.c (x_decline_selection_request)
5727 (x_reply_selection_request): Avoid type-punned deref of X events.
5728
5729 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5730
5731 Fix some uses of `int' instead of EMACS_INT.
5732 * search.c (string_match_1, fast_string_match)
5733 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5734 (scan_buffer, find_next_newline_no_quit)
5735 (find_before_next_newline, search_command, Freplace_match)
5736 (Fmatch_data): Make some `int' variables be EMACS_INT.
5737
5738 * xdisp.c (display_count_lines): 3rd argument and return value now
5739 EMACS_INT. All callers changed.
5740 (pint2hrstr): Last argument is now EMACS_INT.
5741
5742 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5743 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5744 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5745 (decode_coding_utf_16, decode_coding_emacs_mule)
5746 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5747 (decode_coding_ccl, decode_coding_charset)
5748 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5749 (decode_coding_iso_2022, decode_coding_emacs_mule)
5750 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5751 <char_offset, last_offset>: Declare EMACS_INT.
5752 (encode_coding_utf_8, encode_coding_utf_16)
5753 (encode_coding_emacs_mule, encode_invocation_designation)
5754 (encode_designation_at_bol, encode_coding_iso_2022)
5755 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5756 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5757 Declare EMACS_INT.
5758 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5759 (encode_invocation_designation): Last argument P_NCHARS is now
5760 EMACS_INT.
5761 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5762 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5763
5764 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5765 All users changed.
5766
5767 * ccl.c (Fccl_execute_on_string): Declare some variables
5768 EMACS_INT.
5769
5770 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5771
5772 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5773
5774 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5775
5776 * process.c (Fformat_network_address): Doc fix.
5777
5778 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5779
5780 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5781
5782 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5783
5784 * keyboard.c (read_char): Call Lisp function help-form-show,
5785 instead of using internal_with_output_to_temp_buffer.
5786 (Qhelp_form_show): New var.
5787 (syms_of_keyboard): Use DEFSYM macro.
5788
5789 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5790
5791 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5792
5793 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5794
5795 * process.c (Flist_processes): Remove to Lisp.
5796 (list_processes_1): Delete.
5797
5798 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5799
5800 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5801
5802 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5803
5804 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5805
5806 Fix more problems found by GCC 4.6.0's static checks.
5807
5808 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5809
5810 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5811
5812 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5813
5814 * xdisp.c (vmessage): Mark as a printf-like function.
5815
5816 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5817
5818 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5819
5820 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5821 printf-like functions.
5822 (tiff_load): Add casts to remove these marks before passing them
5823 to system-supplied API.
5824
5825 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5826
5827 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5828 This avoids several warnings with gcc -Wstrict-overflow.
5829 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5830 directly, rather than having caller test rule sign. This avoids
5831 some unnecessary tests.
5832 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5833 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5834 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5835
5836 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5837 (xfont_open): Avoid unnecessary tests.
5838
5839 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5840
5841 * composite.h, composite.c (composition_gstring_put_cache):
5842 Use EMACS_INT, not int, for length.
5843
5844 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5845 breaking out part of COMPOSITION_DECODE_RULE.
5846 (COMPOSITION_DECODE_RULE): Use it.
5847 * composite.c (get_composition_id): Remove unused local vars,
5848 by using the new macro.
5849
5850 * textprop.c (set_text_properties_1): Change while to do-while,
5851 since the condition is always true at first.
5852
5853 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5854 (interval_deletion_adjustment): Return unsigned value.
5855 All uses changed.
5856
5857 * process.c (list_processes_1, create_pty, read_process_output):
5858 (exec_sentinel): Remove vars that were set but not used.
5859 (create_pty): Remove unnecessary "volatile"s.
5860 (Fnetwork_interface_info): Avoid possibility of int overflow.
5861 (read_process_output): Do adaptive read buffering even if carryover.
5862 (read_process_output): Simplify nbytes computation if buffered.
5863
5864 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5865
5866 * syntax.c (scan_words): Remove var that was set but not used.
5867 (update_syntax_table): Use unsigned instead of int.
5868
5869 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5870 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5871 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5872
5873 * print.c (print_error_message): Avoid int overflow.
5874
5875 * font.c (font_list_entities): Redo for clarity,
5876 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5877
5878 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5879 (font_score): Avoid potential overflow in diff calculation.
5880
5881 * fns.c (substring_both): Remove var that is set but not used.
5882 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5883
5884 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5885
5886 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5887 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5888 can always succeed if overflow has undefined behavior.
5889
5890 * search.c (boyer_moore, wordify): Remove vars set but not used.
5891 (wordify): Omit three unnecessary tests.
5892
5893 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5894 All callers changed. This avoids the need for an unused var.
5895
5896 * casefiddle.c (casify_region): Remove var that is set but not used.
5897
5898 * dired.c (file_name_completion): Remove var that is set but not used.
5899
5900 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5901
5902 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5903 (Finsert_file_contents): Remove unnecessary code checking fd.
5904
5905 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5906 Check for integer overflow on size calculations.
5907
5908 * buffer.c (Fprevious_overlay_change): Remove var that is set
5909 but not used.
5910
5911 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5912 Remove vars that are set but not used.
5913 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5914 (timer_check_2): Mark vars as initialized.
5915
5916 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5917
5918 * image.c (lookup_image): Remove var that is set but not used.
5919 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5920
5921 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5922 that are set but not used.
5923
5924 * xfns.c (make_invisible_cursor): Don't return garbage
5925 if XCreateBitmapFromData fails (Bug#8410).
5926
5927 * xselect.c (x_get_local_selection, x_handle_property_notify):
5928 Remove vars that are set but not used.
5929
5930 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5931 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5932
5933 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5934 Remove var that is set but not used.
5935 (scroll_bar_windows_size): Now size_t, not int.
5936 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5937 Check for overflow.
5938
5939 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5940 (map_tty_color) [!defined MSDOS]: Likewise.
5941
5942 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5943
5944 * coding.c: Remove vars that are set but not used.
5945 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5946 All callers changed.
5947 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5948 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5949 (decode_coding_charset): Remove vars that are set but not used.
5950
5951 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5952 that is set but not used.
5953
5954 * print.c (print_object): Remove var that is set but not used.
5955
5956 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5957 The gnulib version avoids calling malloc in the usual case,
5958 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5959 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5960 * filelock.c (current_lock_owner): Likewise.
5961 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5962 * sysdep.c: Include allocator.h, careadlinkat.h.
5963 (emacs_no_realloc_allocator): New static constant.
5964 (emacs_readlink): New function.
5965 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5966 ../lib/careadlinkat.h.
5967
5968 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5969
5970 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5971 first non-nil return value).
5972
5973 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5974
5975 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5976 if not defined (Bug#8403).
5977
5978 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * xdisp.c (display_count_lines): Remove parameter `start',
5981 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5982 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5983 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5984 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5985 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5986 and thereabouts. All callers changed.
5987 (get_per_char_metric): Remove parameter `f', unused since
5988 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5989
5990 2011-04-02 Jim Meyering <meyering@redhat.com>
5991
5992 do not dereference NULL upon failed strdup
5993 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5994 (ns_get_family): Likewise.
5995
5996 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5997
5998 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5999
6000 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6001
6002 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6003 later (Bug#8403).
6004
6005 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6006
6007 Add lexical binding.
6008
6009 * window.c (Ftemp_output_buffer_show): New fun.
6010 (Fsave_window_excursion):
6011 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6012
6013 * lread.c (lisp_file_lexically_bound_p): New function.
6014 (Fload): Bind Qlexical_binding.
6015 (readevalloop): Remove `evalfun' arg.
6016 Bind Qinternal_interpreter_environment.
6017 (Feval_buffer): Bind Qlexical_binding.
6018 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6019 Mark as dynamic.
6020 (syms_of_lread): Declare `lexical-binding'.
6021
6022 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6023
6024 * keyboard.c (eval_dyn): New fun.
6025 (menu_item_eval_property): Use it.
6026
6027 * image.c (parse_image_spec): Use Ffunctionp.
6028
6029 * fns.c (concat, mapcar1): Accept byte-code-functions.
6030
6031 * eval.c (Fsetq): Handle lexical vars.
6032 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6033 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6034 (FletX, Flet): Obey lexical binding.
6035 (Fcommandp): Handle closures.
6036 (Feval): New `lexical' arg.
6037 (eval_sub): New function extracted from Feval. Use it almost
6038 everywhere where Feval was used. Look up vars in lexical env.
6039 Handle closures.
6040 (Ffunctionp): Move from subr.el.
6041 (Ffuncall): Handle closures.
6042 (apply_lambda): Remove `eval_flags'.
6043 (funcall_lambda): Handle closures and new byte-code-functions.
6044 (Fspecial_variable_p): New function.
6045 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6046 but without exporting it to Lisp.
6047
6048 * doc.c (Fdocumentation, store_function_docstring):
6049 * data.c (Finteractive_form): Handle closures.
6050
6051 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6052 interactive spec.
6053
6054 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6055 New byte-codes.
6056 (exec_byte_code): New function extracted from Fbyte_code to handle new
6057 calling convention for byte-code-functions. Add new byte-codes.
6058
6059 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6060
6061 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6062
6063 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6064
6065 * xdisp.c (redisplay_internal): Fix prototype.
6066
6067 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6068
6069 * xdisp.c (SCROLL_LIMIT): New macro.
6070 (try_scrolling): Use it when setting scroll_limit.
6071 Limit scrolling to 100 screen lines.
6072 (redisplay_window): Even when falling back on "recentering",
6073 position point in the window according to scroll-conservatively,
6074 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6075
6076 (try_scrolling): When point is above the window, allow searching
6077 as far as scroll_max, or one screenful, to compute vertical
6078 distance from PT to the scroll margin position. This prevents
6079 try_scrolling from unnecessarily failing when
6080 scroll-conservatively is set to a value slightly larger than the
6081 window height. Clean up the case of PT below the margin at bottom
6082 of window: scroll_max can no longer be INT_MAX. When aggressive
6083 scrolling is in use, don't let point enter the opposite scroll
6084 margin as result of the scroll.
6085 (syms_of_xdisp) <scroll-conservatively>: Document the
6086 threshold of 100 lines for never-recentering scrolling.
6087
6088 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6089
6090 * dispextern.h (move_it_by_lines):
6091 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6092 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6093 (message_log_check_duplicate): Remove parameters `prev_bol' and
6094 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6095 (redisplay_internal): Remove parameter `preserve_echo_area',
6096 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6097
6098 * indent.c (Fvertical_motion):
6099 * window.c (window_scroll_pixel_based, Frecenter):
6100 Don't pass `need_y_p' to `move_it_by_lines'.
6101
6102 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6103
6104 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6105 steal a few bits to be more compact.
6106 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6107 Remove unneeded casts.
6108
6109 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6110
6111 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6112
6113 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6114 binding" message (bug#7967).
6115
6116 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6117
6118 Fix more problems found by GCC 4.6.0's static checks.
6119
6120 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6121 Remove unused local var.
6122
6123 * editfns.c (Fmessage_box): Remove unused local var.
6124
6125 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6126 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6127 Omit unused local vars.
6128 * window.c (shrink_windows): Omit unused local var.
6129 * menu.c (digest_single_submenu): Omit unused local var.
6130 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6131 Omit unused local var.
6132
6133 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6134 Don't assume string length fits in int.
6135 (keyremap_step, read_key_sequence): Use size_t for sizes.
6136 (read_key_sequence): Don't check last_real_key_start redundantly.
6137
6138 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6139 instead of alloca (Bug#8344).
6140
6141 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6142 (Fbacktrace_frame): Don't assume nframes fits in int.
6143
6144 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6145
6146 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6147 concerns.
6148
6149 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6150
6151 * cm.c (calccost): Turn while-do into do-while, for clarity.
6152
6153 * keyboard.c (syms_of_keyboard): Use the same style as later
6154 in this function when indexing through an array. This also
6155 works around GCC bug 48267.
6156
6157 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6158
6159 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6160
6161 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6162 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6163
6164 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6165 This avoids undefined behavior on integer overflow, and is a bit
6166 more convenient anyway since it is compared to a size_t variable.
6167
6168 Variadic C functions now count arguments with size_t, not int.
6169 This avoids an unnecessary limitation on 64-bit machines, which
6170 caused (substring ...) to crash on large vectors (Bug#8344).
6171 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6172 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6173 All variadic functions and their callers changed accordingly.
6174 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6175 * data.c (arith_driver, float_arith_driver): Likewise.
6176 * editfns.c (general_insert_function): Likewise.
6177 * eval.c (struct backtrace.nargs, interactive_p)
6178 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6179 (funcall_lambda, mark_backtrace): Likewise.
6180 * fns.c (concat): Likewise.
6181 * frame.c (x_set_frame_parameters): Likewise.
6182 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6183 0 if not found, not -1. All callers changed.
6184
6185 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6186 (stack_copy_size): Now size_t, not int.
6187 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6188
6189 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6190
6191 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6192 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6193 All callers changed.
6194
6195 * lisp.h (multibyte_char_to_unibyte):
6196 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6197 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6198 * character.h (CHAR_TO_BYTE8):
6199 * cmds.c (internal_self_insert):
6200 * editfns.c (general_insert_function):
6201 * keymap.c (push_key_description):
6202 * search.c (Freplace_match):
6203 * xdisp.c (message_dolog, set_message_1): All callers changed.
6204
6205 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6206
6207 * keyboard.c (safe_run_hook_funcall): New function.
6208 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6209 don't set the hook to nil, but remove the offending function instead.
6210 (Qcommand_hook_internal): Remove, unused.
6211 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6212 Vcommand_hook_internal.
6213
6214 * eval.c (enum run_hooks_condition): Remove.
6215 (funcall_nil, funcall_not): New functions.
6216 (run_hook_with_args): Call each function through a `funcall' argument.
6217 Remove `cond' argument, now redundant.
6218 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6219 (Frun_hook_with_args_until_failure): Adjust accordingly.
6220 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6221
6222 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6223
6224 * dispextern.h (string_buffer_position): Remove declaration.
6225
6226 * print.c (strout): Remove parameter `multibyte', unused since
6227 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6228
6229 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6230 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6231 All callers changed.
6232
6233 * w32.c (_wsa_errlist): Use braces for struct initializers.
6234
6235 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6236 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6237 All callers changed.
6238 (string_buffer_position): Likewise. Also, make static (it's never
6239 used outside xdisp.c).
6240 (cursor_row_p): Remove parameter `w', unused since
6241 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6242 (decode_mode_spec): Remove parameter `precision', introduced during
6243 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6244 All callers changed.
6245
6246 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6247
6248 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6249
6250 2011-03-27 Anders Lindgren <andlind@gmail.com>
6251
6252 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6253 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6254 (ns_update_auto_hide_menu_bar): New functions.
6255 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6256 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6257 ns_constrain_all_frames.
6258 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6259 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6260
6261 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6262
6263 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6264
6265 2011-03-27 Glenn Morris <rgm@gnu.org>
6266
6267 * syssignal.h: Replace RETSIGTYPE with void.
6268 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6269 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6270 Replace SIGTYPE with void everywhere.
6271 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6272 * s/template.h (SIGTYPE): Remove commented out definition.
6273
6274 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6275
6276 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6277 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6278
6279 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6280
6281 * w32.c (read_unc_volume): Use parameter `henum', instead of
6282 global variable `wget_enum_handle'.
6283
6284 * keymap.c (describe_vector): Remove parameters `indices' and
6285 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6286 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6287
6288 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6289
6290 * keyboard.c (timer_check): Remove parameter `do_it_now',
6291 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6292 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6293 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6294
6295 * keyboard.c (read_char):
6296 * w32menu.c (w32_menu_display_help):
6297 * xmenu.c (show_help_event, menu_help_callback):
6298 Adjust calls to `show_help_echo'.
6299
6300 * gtkutil.c (xg_maybe_add_timer):
6301 * keyboard.c (readable_events):
6302 * process.c (wait_reading_process_output):
6303 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6304
6305 * insdel.c (adjust_markers_gap_motion):
6306 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6307 (gap_left, gap_right): Don't call it.
6308
6309 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6310
6311 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6312 incurred during fontification.
6313
6314 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6315
6316 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6317 (DEFVAR_PER_BUFFER): Don't pass it.
6318
6319 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6320 (scrolling_window): Don't pass it.
6321
6322 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6323
6324 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6325
6326 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6327 and `suffix'.
6328 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6329 of variables specific to SELinux and computation of `encoded_absname'.
6330
6331 * image.c (XPutPixel): Remove unused variable `height'.
6332
6333 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6334
6335 * unexw32.c (get_section_info): Remove unused variable `section'.
6336
6337 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6338 (system_process_attributes): Remove unused variable `sess'.
6339 (sys_read): Remove unused variable `err'.
6340
6341 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6342 (w32_wnd_proc): Remove unused variable `isdead'.
6343 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6344 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6345 (x_create_tip_frame): Remove unused variable `tem'.
6346
6347 * w32inevt.c (w32_console_read_socket):
6348 Remove unused variable `no_events'.
6349
6350 * w32term.c (x_draw_composite_glyph_string_foreground):
6351 Remove unused variable `width'.
6352
6353 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * w32term.c (x_set_glyph_string_clipping):
6356 Don't pass uninitialized region to CombineRgn.
6357
6358 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6361 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6362 (Fx_close_connection): Remove unused variable `i'.
6363
6364 * w32font.c (w32font_draw): Return number of glyphs.
6365 (w32font_open_internal): Remove unused variable `i'.
6366 (w32font_driver): Add missing initializer.
6367
6368 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6369 (fill_in_menu): Remove unused variable `items_added'.
6370
6371 * w32term.c (last_mouse_press_frame): Remove static global variable.
6372 (w32_clip_to_row): Remove unused variable `f'.
6373 (x_delete_terminal): Remove unused variable `i'.
6374
6375 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6376 (NOTHING): Remove unused static global variable.
6377 (uniscribe_check_otf): Remove unused variable `table'.
6378 (uniscribe_font_driver): Add missing initializers.
6379
6380 2011-03-23 Julien Danjou <julien@danjou.info>
6381
6382 * term.c (Fsuspend_tty, Fresume_tty):
6383 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6384 * window.c (temp_output_buffer_show):
6385 * insdel.c (signal_before_change):
6386 * frame.c (Fhandle_switch_frame):
6387 * fileio.c (Fdo_auto_save):
6388 * emacs.c (Fkill_emacs):
6389 * editfns.c (save_excursion_restore):
6390 * cmds.c (internal_self_insert):
6391 * callint.c (Fcall_interactively):
6392 * buffer.c (Fkill_all_local_variables):
6393 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6394 Use Frun_hooks.
6395 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6396 unconditionnaly since it does the check itself.
6397
6398 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6399
6400 Fix more problems found by GCC 4.5.2's static checks.
6401
6402 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6403 the first time through the loop, since we know p0 < p1 then.
6404 This also avoids a gcc -Wstrict-overflow warning.
6405
6406 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6407 leading to a memory leak, possible in functions like
6408 load_charset_map_from_file that can allocate an unbounded number
6409 of objects (Bug#8318).
6410
6411 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6412 that could (at least in theory) be that large.
6413
6414 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6415 This is less likely to overflow, and avoids undefined behavior if
6416 overflow does occur. All callers changed. Use strtoul to scan
6417 for the unsigned long integer.
6418 (pint2hrstr): Simplify and tune code slightly.
6419 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6420
6421 * scroll.c (do_scrolling): Work around GCC bug 48228.
6422 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6423
6424 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6425 This also avoids a warning with gcc -Wstrict-overflow.
6426 (validate_x_resource_name): Simplify count usage.
6427 This also avoids a warning with gcc -Wstrict-overflow.
6428
6429 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6430 fail (Bug#8306).
6431
6432 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6433
6434 * process.c (Fmake_network_process): Use socklen_t, not int,
6435 where POSIX says socklen_t is required in portable programs.
6436 This fixes a porting bug on hosts like 64-bit HP-UX, where
6437 socklen_t is wider than int (Bug#8277).
6438 (Fmake_network_process, server_accept_connection):
6439 (wait_reading_process_output, read_process_output):
6440 Likewise.
6441
6442 * process.c: Rename or move locals to avoid shadowing.
6443 (list_processes_1, Fmake_network_process):
6444 (read_process_output_error_handler, exec_sentinel_error_handler):
6445 Rename or move locals.
6446 (Fmake_network_process): Define label "retry_connect" only if needed.
6447 (Fnetwork_interface_info): Fix pointer signedness.
6448 (process_send_signal): Add cast to avoid pointer signedness problem.
6449 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6450 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6451
6452 Make tparam.h and terminfo.c consistent.
6453 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6454 Include tparam.h instead, since it declares them.
6455 * cm.h (PC): Remove extern decl; tparam.h now does this.
6456 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6457 * terminfo.c: Include tparam.h, to check interfaces.
6458 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6459 (tparam): Adjust signature to match interface in tparam.h;
6460 this removes some undefined behavior. Check that outstring and len
6461 are zero, which they always are with Emacs.
6462 * tparam.h (PC, BC, UP): New extern decls.
6463
6464 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6465 (xftfont_open): Rename locals to avoid shadowing.
6466
6467 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6468 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6469 (OTF_TAG_SYM): Omit macro if not needed.
6470 (ftfont_list): Remove unused local.
6471 (get_adstyle_property, ftfont_pattern_entity):
6472 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6473 Rename locals to avoid shadowing.
6474
6475 * xfont.c (xfont_list_family): Mark var as initialized.
6476
6477 * xml.c (make_dom): Now static.
6478
6479 * composite.c (composition_compute_stop_pos): Rename local to
6480 avoid shadowing.
6481 (composition_reseat_it): Remove unused locals.
6482 (find_automatic_composition, composition_adjust_point): Likewise.
6483 (composition_update_it): Mark var as initialized.
6484 (find_automatic_composition): Mark vars as initialized,
6485 with a FIXME (Bug#8290).
6486
6487 character.h: Rename locals to avoid shadowing.
6488 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6489 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6490 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6491 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6492 to avoid shadowing.
6493
6494 * textprop.c (property_change_between_p): Remove; unused.
6495
6496 * intervals.c (interval_start_pos): Now static.
6497
6498 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6499
6500 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6501 Rename locals to avoid shadowing.
6502
6503 * sound.c (wav_play, au_play, Fplay_sound_internal):
6504 Fix pointer signedness.
6505 (alsa_choose_format): Remove unused local var.
6506 (wav_play): Initialize a variable to 0, to prevent undefined
6507 behavior (Bug#8278).
6508
6509 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6510
6511 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6512
6513 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6514 clobbering (Bug#8298).
6515 * sysdep.c (sys_subshell): Likewise.
6516 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6517
6518 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6519 This should get cleaned up, so that child_setup has the
6520 same signature on all platforms.
6521
6522 * callproc.c (call_process_cleanup): Now static.
6523 (relocate_fd): Rename locals to avoid shadowing.
6524
6525 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6526
6527 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6528 not to be necessary, and produces flickering.
6529
6530 2011-03-20 Glenn Morris <rgm@gnu.org>
6531
6532 * config.in: Remove file.
6533
6534 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6535
6536 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6537 are now in src/globals.h.
6538 (syms_of_minibuf): Remove spurious & from previous change.
6539
6540 2011-03-20 Leo <sdl.web@gmail.com>
6541
6542 * minibuf.c (completing-read-function): New variable.
6543 (completing-read-default): Rename from completing-read.
6544 (completing-read): Call completing-read-function.
6545
6546 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6547
6548 * xfaces.c (Fx_load_color_file):
6549 Read color file from absolute filename (bug#8250).
6550
6551 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * makefile.w32-in: Update dependencies.
6554
6555 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6556
6557 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6558
6559 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6560
6561 Fix more problems found by GCC 4.5.2's static checks.
6562
6563 * process.c (make_serial_process_unwind, send_process_trap):
6564 (sigchld_handler): Now static.
6565
6566 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6567 That way, the code declares only the vars that it needs.
6568 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6569 * s/cygwin.h (PTY_ITERATION): Likewise.
6570 * s/darwin.h (PTY_ITERATION): Likewise.
6571 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6572
6573 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6574 * process.c (allocate_pty): Don't declare stb unless it's needed.
6575
6576 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6577 (CONSTANTLIM): Remove; unused.
6578 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6579 Define only if needed.
6580
6581 * unexelf.c (unexec): Name an expression,
6582 to avoid gcc -Wbad-function-cast warning.
6583 Use a different way to cause a compilation error if anyone uses
6584 n rather than nn, a way that does not involve shadowing.
6585 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6586
6587 * deps.mk (unexalpha.o): Remove; unused.
6588
6589 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6590 * unexec.h: New file.
6591 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6592 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6593 Depend on unexec.h.
6594 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6595 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6596 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6597 Change as necessary to match prototype in unexec.h.
6598
6599 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6600 shadowing.
6601 (back_comment, skip_chars): Mark vars as initialized.
6602
6603 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6604 Rename locals to avoid shadowing.
6605
6606 * lread.c (read1): Rewrite so as not to use empty "else".
6607 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6608
6609 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6610
6611 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6612 warning when compiling print.c.
6613
6614 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6615 instead of using an uninitialized var.
6616 (font_sort_entities): Mark var as initialized.
6617
6618 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6619
6620 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6621 pointers to constants.
6622 (font_parse_fcname): Remove unused vars.
6623 (font_delete_unmatched): Now static.
6624 (font_get_spec): Remove; unused.
6625 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6626 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6627 Rename or move locals to avoid shadowing.
6628
6629 * fns.c (require_nesting_list, require_unwind): Now static.
6630 (Ffillarray): Rename locals to avoid shadowing.
6631
6632 * floatfns.c (domain_error2): Define only if needed.
6633 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6634
6635 * alloc.c (mark_backtrace): Move decl from here ...
6636 * lisp.h: ... to here, so that it can be checked.
6637
6638 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6639 (Fdefvar): Rewrite so as not to use empty "else".
6640 (lisp_indirect_variable): Name an expression,
6641 to avoid gcc -Wbad-function-cast warning.
6642 (Fdefvar): Rename locals to avoid shadowing.
6643
6644 * callint.c (quotify_arg, quotify_args): Now static.
6645 (Fcall_interactively): Rename locals to avoid shadowing.
6646 Use const pointer when appropriate.
6647
6648 * lisp.h (get_system_name, get_operating_system_release):
6649 Move decls here, to check interfaces.
6650 * process.c (get_operating_system_release): Move decl to lisp.h.
6651 * xrdb.c (get_system_name): Likewise.
6652 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6653 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6654 some of which prompt warnings from gcc -Wbad-function-cast.
6655 (Fformat_time_string, Fencode_time, Finsert_char):
6656 (Ftranslate_region_internal, Fformat):
6657 Rename or remove local vars to avoid shadowing.
6658 (Ftranslate_region_internal): Mark var as initialized.
6659
6660 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6661 avoid shadowing.
6662
6663 * lisp.h (eassert): Check that the argument compiles, even if
6664 ENABLE_CHECKING is not defined.
6665
6666 * data.c (Findirect_variable): Name an expression, to avoid
6667 gcc -Wbad-function-cast warning.
6668 (default_value, arithcompare, arith_driver, arith_error): Now static.
6669 (store_symval_forwarding): Rename local to avoid shadowing.
6670 (Fmake_variable_buffer_local, Fmake_local_variable):
6671 Mark variables as initialized.
6672 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6673
6674 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6675 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6676 Rename locals to avoid shadowing.
6677 (mark_stack): Move local variables into the #ifdef region where
6678 they're used.
6679 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6680 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6681 needed otherwise.
6682 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6683 (GC_STRING_CHARS): Remove; not used.
6684 (Fmemory_limit): Cast sbrk's returned value to char *.
6685
6686 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6687 avoids undefined behavior in theory.
6688
6689 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6690
6691 Use functions, not macros, for up- and down-casing (Bug#8254).
6692 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6693 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6694 to use the following functions instead of these macros.
6695 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6696 EMACS_INT, since callers assume the returned value fits in int.
6697 (upcase1): Likewise, for UPCASE_TABLE.
6698 (uppercasep, lowercasep, upcase): New static inline functions.
6699 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6700 the race-condition problem in the old DOWNCASE.
6701
6702 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6703 Rename locals to avoid shadowing.
6704 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6705 (regex_compile, re_search_2, re_match_2_internal):
6706 Remove unused local vars.
6707 (FREE_VAR): Rewrite so as not to use empty "else",
6708 which gcc can warn about.
6709 (regex_compile, re_match_2_internal): Mark locals as initialized.
6710 (RETALLOC_IF): Define only if needed.
6711 (WORDCHAR_P): Likewise. This one is never needed, but is used
6712 only in a comment talking about a compiler bug, so put inside
6713 the #if 0 of that comment.
6714 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6715 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6716 Remove; unused.
6717
6718 * search.c (boyer_moore): Rename locals to avoid shadowing.
6719 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6720 (PREV_CHAR_BOUNDARY): Likewise.
6721
6722 * search.c (simple_search): Remove unused var.
6723
6724 * dired.c (compile_pattern): Move decl from here ...
6725 * lisp.h: ... to here, so that it can be checked.
6726 (struct re_registers): New forward decl.
6727
6728 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6729
6730 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6731 All uses changed.
6732 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6733 Rename locals to avoid shadowing.
6734 (Fvertical_motion): Mark locals as initialized.
6735
6736 * casefiddle.c (casify_object, casify_region): Now static.
6737 (casify_region): Mark local as initialized.
6738
6739 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6740
6741 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6742 New macros, so that the caller can use some names other than
6743 gcpro1, gcpro2, etc.
6744 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6745 of the new macros.
6746 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6747 argument, for consistency with GCPRO2_VAR, etc: it is now the
6748 prefix of the variable, not the variable itself. All uses
6749 changed.
6750 * dired.c (directory_files_internal, file_name_completion):
6751 Rename locals to avoid shadowing.
6752
6753 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6754 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6755 dired.c's scmp function, had undefined behavior.
6756 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6757 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6758 * buffer.h: ... to here, because these macros use current_buffer,
6759 and the new implementation with inline functions needs to have
6760 current_buffer in scope now, rather than later when the macros
6761 are used.
6762 (downcase, upcase1): New static inline functions.
6763 (DOWNCASE, UPCASE1): Reimplement using these functions.
6764 This avoids undefined behavior in expressions like
6765 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6766 from race conditions in accessing the global variables
6767 case_temp1 and case_temp2.
6768 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6769 * lisp.h (case_temp1, case_temp2): Remove their decls.
6770 * character.h (ASCII_CHAR_P): Move from here ...
6771 * lisp.h: ... to here, so that the inline functions mentioned
6772 above can use them.
6773
6774 * dired.c (directory_files_internal_unwind): Now static.
6775
6776 * fileio.c (file_name_as_directory, directory_file_name):
6777 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6778 Now static.
6779 (file_name_as_directory): Use const pointers when appropriate.
6780 (Fexpand_file_name): Likewise. In particular, newdir might
6781 point at constant storage, so make it a const pointer.
6782 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6783 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6784 signedness issues.
6785 (Fset_file_times, Finsert_file_contents, auto_save_error):
6786 Rename locals to avoid shadowing.
6787
6788 * minibuf.c (choose_minibuf_frame_1): Now static.
6789 (Ftry_completion, Fall_completions): Rename or remove locals
6790 to avoid shadowing.
6791
6792 * marker.c (bytepos_to_charpos): Remove; unused.
6793
6794 * lisp.h (verify_bytepos, count_markers): New decls,
6795 so that gcc does not warn that these functions aren't declared.
6796
6797 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6798 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6799 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6800 (copy_text): Remove unused local var.
6801
6802 * filelock.c (within_one_second): Now static.
6803 (lock_file_1): Rename local to avoid shadowing.
6804
6805 * buffer.c (fix_overlays_before): Mark locals as initialized.
6806 (fix_start_end_in_overlays): Likewise. This function should be
6807 simplified by using pointers-to-pointers, but that's a different
6808 matter.
6809 (switch_to_buffer_1): Now static.
6810 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6811 (report_overlay_modification): Rename locals to avoid shadowing.
6812
6813 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6814 Fix pointer signedness issue.
6815 (sys_subshell): Mark local as volatile if checking for lint,
6816 to suppress a gcc -Wclobbered warning that does not seem to be right.
6817 (MAXPATHLEN): Define only if needed.
6818
6819 * process.c (serial_open, serial_configure): Move decls from here ...
6820 * systty.h: ... to here, so that they can be checked.
6821
6822 * fns.c (get_random, seed_random): Move extern decls from here ...
6823 * lisp.h: ... to here, so that they can be checked.
6824
6825 * sysdep.c (reset_io): Now static.
6826 (wait_for_termination_signal): Remove; unused.
6827
6828 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6829 (copy_keymap_item, append_key, push_text_char_description):
6830 Now static.
6831 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6832 (DENSE_TABLE_SIZE): Remove; unused.
6833 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6834 (describe_map_tree):
6835 Rename locals to avoid shadowing.
6836
6837 * keyboard.c: Declare functions static if they are not used elsewhere.
6838 (echo_char, echo_dash, cmd_error, top_level_2):
6839 (poll_for_input, handle_async_input): Now static.
6840 (read_char, kbd_buffer_get_event, make_lispy_position):
6841 (make_lispy_event, make_lispy_movement, apply_modifiers):
6842 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6843 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6844 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6845 (read_key_sequence, read_char): Mark locals as initialized.
6846 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6847
6848 * keyboard.h (make_ctrl_char): New decl.
6849 (mark_kboards): Move decl here ...
6850 * alloc.c (mark_kboards): ... from here.
6851
6852 * lisp.h (force_auto_save_soon): New decl.
6853
6854 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6855 (DEFINE_DUMMY_FUNCTION): New macro.
6856 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6857 Use it.
6858 (main): Add casts to avoid warnings
6859 if GCC considers string literals to be constants.
6860
6861 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6862
6863 * dbusbind.c: Pointer signedness fixes.
6864 (xd_signature, xd_append_arg, xd_initialize):
6865 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6866 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6867 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6868 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6869
6870 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6871 if GCC considers string literals to be constants.
6872 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6873
6874 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6875
6876 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6877 (print_preprocess, print_object): New macro to fix last change.
6878
6879 * print.c (print_preprocess): Don't forget font objects.
6880
6881 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6882
6883 * emacs.c (USAGE3): Doc fixes.
6884
6885 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6886
6887 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6888 structure.
6889
6890 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6891
6892 * lisp.h (VWindow_system, Qfile_name_history):
6893 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6894 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6895 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6896
6897 * w32select.c: Don't #include "keyboard.h".
6898 (run_protected): Add extern declaration for waiting_for_input.
6899
6900 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6901 * w32console.c (detect_input_pending, read_input_pending)
6902 (encode_terminal_code):
6903 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6904 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6905 (w32_system_caret_y, Qfile_name_history):
6906 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6907 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6908 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6909 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6910 * w32proc.c (Qlocal, report_file_error):
6911 * w32term.c (Vwindow_system, updating_frame):
6912 * w32uniscribe.c (initialized, uniscribe_font_driver):
6913 Remove unneeded extern declarations.
6914
6915 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6916
6917 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6918
6919 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6920
6921 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6922 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6923 These macros can no longer be used for assignment.
6924
6925 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6926 Assign struct members directly, instead of using BUF_BEGV etc.
6927 (record_buffer_markers, fetch_buffer_markers): New functions for
6928 recording and fetching special buffer markers.
6929 (set_buffer_internal_1, set_buffer_temp): Use them.
6930
6931 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6932
6933 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6934
6935 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6936 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6937
6938 * xdisp.c (hscroll_window_tree):
6939 (reconsider_clip_changes): Use PT instead of BUF_PT.
6940
6941 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6942
6943 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6944 $(EMACS_ROOT)/lib/intprops.h.
6945
6946 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6947
6948 Fix more problems found by GCC 4.5.2's static checks.
6949
6950 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6951 to unsigned char * to avoid compiler diagnostic.
6952 (xg_free_frame_widgets): Make it clear that a local variable is
6953 needed only if USE_GTK_TOOLTIP.
6954 (gdk_window_get_screen): Make it clear that this macro is needed
6955 only if USE_GTK_TOOLTIP.
6956 (int_gtk_range_get_value): New function, which avoids a diagnostic
6957 from gcc -Wbad-function-cast.
6958 (xg_set_toolkit_scroll_bar_thumb): Use it.
6959 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6960 diagnostic from gcc -Wbad-function-cast.
6961 (get_utf8_string, xg_get_file_with_chooser):
6962 Rename locals to avoid shadowing.
6963 (create_dialog): Move locals to avoid shadowing.
6964
6965 * xgselect.c (xg_select): Remove unused var.
6966
6967 * image.c (four_corners_best): Mark locals as initialized.
6968 (gif_load): Initialize transparent_p to zero (Bug#8238).
6969 Mark another local as initialized.
6970 (my_png_error, my_error_exit): Mark with NO_RETURN.
6971
6972 * image.c (clear_image_cache): Now static.
6973 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6974 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6975 (x_edge_detection): Remove unnecessary cast that
6976 gcc -Wbad-function-cast diagnoses.
6977 (gif_load): Fix pointer signedness.
6978 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6979 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6980
6981 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6982
6983 Improve quality of tests for time stamp overflow.
6984 For example, without this patch (encode-time 0 0 0 1 1
6985 1152921504606846976) returns the obviously-bogus value (-948597
6986 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6987 reports time overflow. See
6988 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6989 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6990 * editfns.c: Include limits.h and intprops.h.
6991 (TIME_T_MIN, TIME_T_MAX): New macros.
6992 (time_overflow): Move earlier, to before first use.
6993 (hi_time, lo_time): New functions, for an accurate test for
6994 out-of-range times.
6995 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6996 (Fget_internal_run_time): Don't assume time_t fits in int.
6997 (make_time): Use list2 instead of Fcons twice.
6998 (Fdecode_time): More accurate test for out-of-range times.
6999 (check_tm_member): New function.
7000 (Fencode_time): Use it, to test for out-of-range times.
7001 (lisp_time_argument): Don't rely on undefined left-shift and
7002 right-shift behavior when checking for time stamp overflow.
7003
7004 * editfns.c (time_overflow): New function, refactoring common code.
7005 (Fformat_time_string, Fdecode_time, Fencode_time):
7006 (Fcurrent_time_string): Use it.
7007
7008 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7009 * dired.c (make_time): Move to ...
7010 * editfns.c (make_time): ... here.
7011 * systime.h: Note the move.
7012
7013 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7014
7015 * fringe.c (update_window_fringes): Remove unused variables.
7016
7017 * unexmacosx.c (copy_data_segment): Also copy __got section.
7018 (Bug#8223)
7019
7020 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7021
7022 * termcap.c [MSDOS]: Include "msdos.h".
7023 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7024 Constify `char *' arguments and their references according to
7025 prototypes in tparam.h.
7026
7027 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7028
7029 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7030 Adapt all references accordingly.
7031
7032 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7033
7034 2011-03-11 Tom Tromey <tromey@redhat.com>
7035
7036 * buffer.c (syms_of_buffer): Remove obsolete comment.
7037
7038 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7039
7040 * termhooks.h (encode_terminal_code): Declare prototype.
7041
7042 * msdos.c (encode_terminal_code): Don't declare prototype.
7043
7044 * term.c (encode_terminal_code): Now external again, used by
7045 w32console.c and msdos.c.
7046
7047 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7048 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7049
7050 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7051
7052 Fix some minor problems found by GCC 4.5.2's static checks.
7053
7054 * fringe.c (update_window_fringes): Mark locals as initialized
7055 (Bug#8227).
7056 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7057
7058 * alloc.c (mark_fringe_data): Move decl from here ...
7059 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7060 to check its interface.
7061 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7062
7063 * fontset.c (free_realized_fontset): Now static.
7064 (Fset_fontset_font): Rename local to avoid shadowing.
7065 (fontset_font): Mark local as initialized.
7066 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7067
7068 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7069
7070 * xselect.c (x_disown_buffer_selections): Remove; not used.
7071 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7072 (x_own_selection, Fx_disown_selection_internal): Rename locals
7073 to avoid shadowing.
7074 (x_handle_dnd_message): Remove local to avoid shadowing.
7075
7076 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7077 so that the caller can use some name other than gcpro1.
7078 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7079 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7080 (Fx_backspace_delete_keys_p):
7081 Use them to avoid shadowing, and rename vars to avoid shadowing.
7082 (x_decode_color, x_set_name, x_window): Now static.
7083 (Fx_create_frame): Add braces to silence GCC warning.
7084 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7085 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7086 Remove unused locals.
7087 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7088 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7089 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7090 macros.
7091
7092 * xterm.h (x_mouse_leave): New decl.
7093
7094 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7095 Remove unused functions.
7096 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7097 (x_calc_absolute_position): Now static.
7098 (XTread_socket): Don't define label "out" unless it's used.
7099 Don't declare local "event" unless it's used.
7100 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7101 unless they are used.
7102 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7103 (x_fatal_error_signal): Remove; not used.
7104 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7105 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7106 (x_error_catcher, x_connection_closed, x_error_handler):
7107 (x_error_quitter, xembed_send_message, x_iconify_frame):
7108 (my_log_handler): Rename locals to avoid shadowing.
7109 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7110 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7111
7112 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7113 Rename or move locals to avoid shadowing.
7114 (tty_defined_color, merge_face_heights): Now static.
7115 (free_realized_faces_for_fontset): Remove; not used.
7116 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7117 does not deduce is never used uninitialized.
7118 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7119 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7120
7121 * terminal.c (store_terminal_param): Now static.
7122
7123 * xmenu.c (menu_highlight_callback): Now static.
7124 (set_frame_menubar): Remove unused local.
7125 (xmenu_show): Rename parameter to avoid shadowing.
7126 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7127 since they might point to immutable storage.
7128 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7129 since it's unused otherwise.
7130
7131 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7132 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7133 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7134 avoids a gcc -Wuninitialized diagnostic.
7135 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7136 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7137 does not deduce are never used uninitialized.
7138
7139 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7140
7141 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7142 * window.c (window_loop, size_window):
7143 (run_window_configuration_change_hook, enlarge_window): Likewise.
7144
7145 * window.c (display_buffer): Now static.
7146 (size_window): Mark variables that gcc -Wuninitialized
7147 does not deduce are never used uninitialized.
7148 * window.h (check_all_windows): New decl, to forestall
7149 gcc -Wmissing-prototypes diagnostic.
7150 * dispextern.h (bidi_dump_cached_states): Likewise.
7151
7152 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7153 shadowing.
7154 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7155 Include <limits.h>.
7156 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7157 and to avoid gcc -Wuninitialized warning.
7158 (load_charset_map): Mark variables that gcc -Wuninitialized
7159 does not deduce are never used uninitialized.
7160 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7161
7162 * coding.c (coding_set_source, coding_set_destination):
7163 Use "else { /* comment */ }" rather than "else /* comment */;"
7164 for clarity, and to avoid gcc -Wempty-body warning.
7165 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7166 a block, when the outer 'i' will do.
7167 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7168 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7169 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7170 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7171 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7172 Rename locals to avoid shadowing.
7173 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7174 * coding.c (emacs_mule_char, encode_invocation_designation):
7175 Now static, since they're not used elsewhere.
7176 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7177 (decode_coding_object, encode_coding_object, detect_coding_system):
7178 (decode_coding_emacs_mule): Mark variables that gcc
7179 -Wuninitialized does not deduce are never used uninitialized.
7180 (detect_coding_iso_2022): Initialize a local variable that might
7181 be used uninitialized. Leave a FIXME because it's not clear that
7182 this initialization is needed. (Bug#8211)
7183 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7184 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7185 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7186 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7187 Remove unused macros.
7188
7189 * category.c (hash_get_category_set): Remove unused local var.
7190 (copy_category_table): Now static, since it's not used elsewhere.
7191 * character.c (string_count_byte8): Likewise.
7192
7193 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7194 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7195
7196 * chartab.c (copy_sub_char_table): Now static, since it's not used
7197 elsewhere.
7198 (sub_char_table_ref_and_range, char_table_ref_and_range):
7199 Rename locals to avoid shadowing.
7200 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7201
7202 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7203 (BIDI_BOB): Remove unused macro.
7204
7205 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7206 deduce are never used uninitialized.
7207 * term.c (encode_terminal_code): Likewise.
7208
7209 * term.c (encode_terminal_code): Now static. Remove unused local.
7210
7211 * tparam.h: New file.
7212 * term.c, tparam.h: Include it.
7213 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7214 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7215 Move these decls to tparam.h, and make them agree with what
7216 is actually in tparam.c. The previous trick of using incompatible
7217 decls in different modules does not conform to the C standard.
7218 All callers of tparam changed to use tparam's actual API.
7219 * tparam.c (tparam1, tparam, tgoto):
7220 Use const pointers where appropriate.
7221
7222 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7223 * cm.h (struct cm): Likewise.
7224 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7225 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7226 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7227 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7228 (turn_on_face, init_tty): Likewise.
7229 * termchar.h (struct tty_display_info): Likewise.
7230
7231 * term.c (term_mouse_position): Rename local to avoid shadowing.
7232
7233 * alloc.c (mark_ttys): Move decl from here ...
7234 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7235
7236 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7237
7238 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7239
7240 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * search.c (compile_pattern_1): Remove argument regp, unused since
7243 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7244 (compile_pattern): Don't pass it.
7245
7246 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7247
7248 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7249 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7250 for ! HAVE_GTK3.
7251 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7252
7253 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7254
7255 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7256 gdk_window_get_screen, gdk_window_get_geometry,
7257 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7258 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7259 (xg_get_pixbuf_from_pixmap): New function.
7260 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7261 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7262 Call xg_get_pixbuf_from_pixmap instead of
7263 gdk_pixbuf_get_from_drawable.
7264 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7265 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7266 (xg_check_special_colors): Use GtkStyleContext and its functions
7267 for HAVE_GTK3.
7268 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7269 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7270 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7271 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7272 Call gtk_widget_get_preferred_size.
7273 (xg_frame_resized): gdk_window_get_geometry only takes 5
7274 parameters.
7275 (xg_win_to_widget, xg_event_is_for_menubar):
7276 Call gdk_x11_window_lookup_for_display.
7277 (xg_set_widget_bg): New function.
7278 (delete_cb): New function.
7279 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7280 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7281 (xg_set_background_color): Call xg_set_widget_bg.
7282 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7283 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7284 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7285 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7286 if ! HAVE_GTK3.
7287 (update_frame_tool_bar): Call gtk_widget_hide.
7288 (xg_initialize): Use GDK_KEY_g.
7289
7290 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7291 if ! HAVE_GTK3
7292 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7293
7294 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7295 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7296 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7297
7298 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * w32xfns.c (select_palette): Check success of RealizePalette against
7301 GDI_ERROR, not zero.
7302
7303 See ChangeLog.11 for earlier changes.
7304
7305 ;; Local Variables:
7306 ;; coding: utf-8
7307 ;; End:
7308
7309 Copyright (C) 2011 Free Software Foundation, Inc.
7310
7311 This file is part of GNU Emacs.
7312
7313 GNU Emacs is free software: you can redistribute it and/or modify
7314 it under the terms of the GNU General Public License as published by
7315 the Free Software Foundation, either version 3 of the License, or
7316 (at your option) any later version.
7317
7318 GNU Emacs is distributed in the hope that it will be useful,
7319 but WITHOUT ANY WARRANTY; without even the implied warranty of
7320 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7321 GNU General Public License for more details.
7322
7323 You should have received a copy of the GNU General Public License
7324 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.