]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Improve buffer-overflow checking.
[gnu-emacs] / src / ChangeLog
1 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 Improve buffer-overflow checking.
4 * fileio.c (Finsert_file_contents):
5 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6 Remove the old (too-loose) buffer overflow checks.
7 They weren't needed, since make_gap checks for buffer overflow.
8 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9 The old code merely checked for Emacs fixnum overflow, and relied
10 on undefined (wraparound) behavior. The new code avoids undefined
11 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12
13 * editfns.c (Finsert_char): Don't dump core with very negative counts.
14 Tune. Don't use wider integers than needed. Don't use alloca.
15 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
16
17 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
18
19 * insdel.c, lisp.h (buffer_overflow): New function.
20 (insert_from_buffer_1, replace_range, replace_range_2):
21 * insdel.c (make_gap_larger):
22 * editfns.c (Finsert_char):
23 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
24
25 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
26
27 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
28
29 Integer overflow and signedness fixes (Bug#8873).
30
31 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
32 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
33
34 * fileio.c: Don't assume EMACS_INT fits in off_t.
35 (emacs_lseek): New static function.
36 (Finsert_file_contents, Fwrite_region): Use it.
37 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
38
39 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
40
41 * fns.c: Don't overflow int when computing a list length.
42 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
43 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
44 truncation on 64-bit hosts. Check for QUIT every
45 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
46 faster and is responsive enough.
47 (Flength): Report an error instead of overflowing an integer.
48 (Fsafe_length): Return a float if the value is not representable
49 as a fixnum. This shouldn't happen except in contrived situations.
50 (Fnthcdr, Fsort): Don't assume list length fits in int.
51 (Fcopy_sequence): Don't assume vector length fits in int.
52
53 * alloc.c: Check that resized vectors' lengths fit in fixnums.
54 (header_size, word_size): New constants.
55 (allocate_vectorlike): Don't check size overflow here.
56 (allocate_vector): Check it here instead, since this is the only
57 caller of allocate_vectorlike that could cause overflow.
58 Check that the new vector's length is representable as a fixnum.
59
60 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
61 The previous code was bogus. For example, next_almost_prime (32)
62 returned 39, which is undesirable as it is a multiple of 3; and
63 next_almost_prime (24) returned 25, which is a multiple of 5 so
64 why was the code bothering to check for multiples of 7?
65
66 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
67
68 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
69
70 Variadic C functions now count arguments with ptrdiff_t.
71 This partly undoes my 2011-03-30 change, which replaced int with size_t.
72 Back then I didn't know that the Emacs coding style prefers signed int.
73 Also, in the meantime I found a few more instances where arguments
74 were being counted with int, which may truncate counts on 64-bit
75 machines, or EMACS_INT, which may be unnecessarily wide.
76 * lisp.h (struct Lisp_Subr.function.aMANY)
77 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
78 Arg counts are now ptrdiff_t, not size_t.
79 All variadic functions and their callers changed accordingly.
80 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
81 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
82 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
83 * callint.c (Fcall_interactively): Check arg count for overflow,
84 to avoid potential buffer overrun. Use signed char, not 'int',
85 for 'varies' array, so that we needn't bother to check its size
86 calculation for overflow.
87 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
88 * eval.c (apply_lambda):
89 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
90 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
91 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
92
93 * callint.c (Fcall_interactively): Don't use index var as event count.
94
95 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
96 * mem-limits.h (SIZE): Remove; no longer used.
97
98 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
99
100 Remove unnecessary casts.
101 * xterm.c (x_term_init):
102 * xfns.c (x_set_border_pixel):
103 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
104 These aren't needed now that we assume ANSI C.
105
106 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
107 It's more likely to cause problems (due to unsigned overflow)
108 than to cure them.
109
110 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
111
112 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
113
114 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
115
116 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
117
118 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
119
120 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
121
122 GLYPH_CODE_FACE returns EMACS_INT, not int.
123 * dispextern.h (merge_faces):
124 * xfaces.c (merge_faces):
125 * xdisp.c (get_next_display_element, next_element_from_display_vector):
126 Don't assume EMACS_INT fits in int.
127
128 * character.h (CHAR_VALID_P): Remove unused parameter.
129 * fontset.c, lisp.h, xdisp.c: All uses changed.
130
131 * editfns.c (Ftranslate_region_internal): Omit redundant test.
132
133 * fns.c (concat): Minor tuning based on overflow analysis.
134 This doesn't fix any bugs. Use int to hold character, instead
135 of constantly refetching from Emacs object. Use XFASTINT, not
136 XINT, for value known to be a character. Don't bother comparing
137 a single byte to 0400, as it's always less.
138
139 * floatfns.c (Fexpt):
140 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
141
142 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
143 for characters.
144
145 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
146
147 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
148 Without this fix, on a 64-bit host (aset S 0 4294967386) would
149 incorrectly succeed when S was a string, because 4294967386 was
150 truncated before it was used.
151
152 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
153 Otherwise, an out-of-range integer could cause undefined behavior
154 on a 64-bit host.
155
156 * composite.c: Use int, not EMACS_INT, for characters.
157 (fill_gstring_body, composition_compute_stop_pos): Use int, not
158 EMACS_INT, for values that are known to be in character range.
159 This doesn't fix any bugs but is the usual style inside Emacs and
160 may generate better code on 32-bit machines.
161
162 Make sure a 64-bit char is never passed to ENCODE_CHAR.
163 This is for reasons similar to the recent CHAR_STRING fix.
164 * charset.c (Fencode_char): Check that character arg is actually
165 a character. Pass an int to ENCODE_CHAR.
166 * charset.h (ENCODE_CHAR): Verify that the character argument is no
167 wider than 'int', as a compile-time check to prevent future regressions
168 in this area.
169
170 * character.c (char_string): Remove unnecessary casts.
171
172 Make sure a 64-bit char is never passed to CHAR_STRING.
173 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
174 by silently ignoring the top 32 bits, allowing some values
175 that were far too large to be valid characters.
176 * character.h: Include <verify.h>.
177 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
178 arguments are no wider than unsigned, as a compile-time check
179 to prevent future regressions in this area.
180 * data.c (Faset):
181 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
182 (Fsubst_char_in_region):
183 * fns.c (concat):
184 * xdisp.c (decode_mode_spec_coding):
185 Adjust to CHAR_STRING's new requirement.
186 * editfns.c (Finsert_char, Fsubst_char_in_region):
187 * fns.c (concat): Check that character args are actually
188 characters. Without this test, these functions did the wrong
189 thing with wildly out-of-range values on 64-bit hosts.
190
191 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
192 These casts should not be needed on 32-bit hosts, either.
193 * keyboard.c (read_char):
194 * lread.c (Fload): Remove casts to unsigned.
195
196 * lisp.h (UNSIGNED_CMP): New macro.
197 This fixes comparison bugs on 64-bit hosts.
198 (ASCII_CHAR_P): Use it.
199 * casefiddle.c (casify_object):
200 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
201 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
202 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
203 * dispextern.h (FACE_FROM_ID):
204 * keyboard.c (read_char): Use UNSIGNED_CMP.
205
206 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
207 not to EMACS_INT, to avoid GCC warning.
208
209 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
210
211 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
212 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
213 isn't needed on 32-bit machines.
214
215 * buffer.c (Fgenerate_new_buffer_name):
216 Use EMACS_INT for count, not int.
217 (advance_to_char_boundary): Return EMACS_INT, not int.
218
219 * data.c (Qcompiled_function): Now static.
220
221 * window.c (window_body_lines): Now static.
222
223 * image.c (gif_load): Rename local to avoid shadowing.
224
225 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
226 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
227 * alloc.c (make_save_value): Integer argument is now of type
228 ptrdiff_t, not int.
229 (mark_object): Use ptrdiff_t, not int.
230 * lisp.h (pD): New macro.
231 * print.c (print_object): Use it.
232
233 * alloc.c: Use EMACS_INT, not int, to count objects.
234 (total_conses, total_markers, total_symbols, total_vector_size)
235 (total_free_conses, total_free_markers, total_free_symbols)
236 (total_free_floats, total_floats, total_free_intervals)
237 (total_intervals, total_strings, total_free_strings):
238 Now EMACS_INT, not int. All uses changed.
239 (Fgarbage_collect): Compute overall total using a double, so that
240 integer overflow is less likely to be a problem. Check for overflow
241 when converting back to an integer.
242 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
243 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
244 These were 'int' variables that could overflow on 64-bit hosts;
245 they were never used, so remove them instead of repairing them.
246 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
247 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
248 Previously, this ceilinged at INT_MAX, but that doesn't work on
249 64-bit machines.
250 (allocate_pseudovector): Don't use EMACS_INT when int would do.
251
252 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
253 (allocate_vectorlike): Check for ptrdiff_t overflow.
254 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
255 when a (possibly-narrower) signed value would do just as well.
256 We prefer using signed arithmetic, to avoid comparison confusion.
257
258 * alloc.c: Catch some string size overflows that we were missing.
259 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
260 for convenience in STRING_BYTES_MAX.
261 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
262 The definition here is exact; the one in lisp.h was approximate.
263 (allocate_string_data): Check for string overflow. This catches
264 some instances we weren't catching before. Also, it catches
265 size_t overflow on (unusual) hosts where SIZE_MAX <= min
266 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
267 and ptrdiff_t and EMACS_INT are both 64 bits.
268
269 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
270 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
271 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
272
273 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
274
275 * alloc.c (Fmake_string): Check for out-of-range init.
276
277 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
278
279 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
280
281 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
282
283 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
284 xg_get_default_scrollbar_width.
285
286 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
287 (int_gtk_range_get_value): Move to the scroll bar part of the file.
288 (style_changed_cb): Call update_theme_scrollbar_width and call
289 x_set_scroll_bar_default_width and xg_frame_set_char_size for
290 all frames (Bug#8505).
291 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
292 Call gtk_window_set_resizable if HAVE_GTK3.
293 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
294 and height if HAVE_GTK3 (Bug#8505).
295 (scroll_bar_width_for_theme): New variable.
296 (update_theme_scrollbar_width): New function.
297 (xg_get_default_scrollbar_width): Move code to
298 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
299 (xg_initialize): Call update_theme_scrollbar_width.
300
301 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
302
303 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
304
305 2011-06-12 Martin Rudalics <rudalics@gmx.at>
306
307 * frame.c (make_frame): Call other_buffer_safely instead of
308 other_buffer.
309
310 * window.c (temp_output_buffer_show): Call display_buffer with
311 second argument Vtemp_buffer_show_specifiers and reset latter
312 immediately after the call.
313 (Vtemp_buffer_show_specifiers): New variable.
314 (auto_window_vscroll_p, next_screen_context_lines)
315 (Vscroll_preserve_screen_position): Remove leading asterisks from
316 doc-strings.
317
318 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
319
320 Fix minor problems found by GCC 4.6.0 static checking.
321 * buffer.c (Qclone_number): Remove for now, as it's unused.
322 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
323 (record_buffer): Remove unused local.
324 * frame.c (other_visible_frames, frame_buffer_list): Now static.
325 (set_frame_buffer_list): Remove; unused.
326 * frame.h (other_visible_frames): Remove decl.
327 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
328 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
329 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
330 if HAVE_GPM.
331 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
332 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
333 Define only if HAVE_GPM.
334 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
335 (update_hints_inhibit): Remove; never set. All uses removed.
336 * widgetprv.h (emacsFrameClassRec): Remove decl.
337 * window.c (delete_deletable_window): Now returns void, since it
338 wasn't returning anything.
339 (compare_window_configurations): Remove unused locals.
340 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
341 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
342 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
343 the same widths as pointers. This follows up on the 2011-05-06 patch.
344 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
345 * xterm.h: Likewise.
346 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
347
348 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
349
350 * makefile.w32-in: Update dependencies.
351 (LISP_H): Add lib/intprops.h.
352
353 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
354
355 * image.c (gif_load): Add animation frame delay to the metadata.
356 (syms_of_image): Use DEFSYM. New symbol `delay'.
357
358 2011-06-11 Martin Rudalics <rudalics@gmx.at>
359
360 * window.c (delete_deletable_window): Re-add.
361 (Fset_window_configuration): Rewrite to handle dead buffers and
362 consequently deletable windows.
363 (window_tree, Fwindow_tree): Remove. Supply functionality in
364 window.el.
365 (compare_window_configurations): Simplify code.
366
367 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
368
369 * image.c (imagemagick_load_image): Fix type mismatch.
370 (Fimagemagick_types): Likewise.
371
372 * window.h (replace_buffer_in_windows): Declare.
373
374 2011-06-11 Martin Rudalics <rudalics@gmx.at>
375
376 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
377 Qclone_number. Remove external declaration of Qdelete_window.
378 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
379 code.
380 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
381 Qbuffer_list_update_hook if allowed.
382 (Fother_buffer): Rewrite doc-string. Major rewrite for new
383 buffer list implementation.
384 (other_buffer_safely): New function.
385 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
386 calls to replace_buffer_in_windows and
387 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
388 if allowed.
389 (record_buffer): Inhibit quitting and rewrite using quittable
390 functions. Run Qbuffer_list_update_hook if allowed.
391 (Frecord_buffer, Funrecord_buffer): New functions.
392 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
393 switch-to-buffer to window.el.
394 (bury-buffer): Move to window.el.
395 (Vbuffer_list_update_hook): New variable.
396
397 * lisp.h (other_buffer_safely): Add prototype in buffer.c
398 section.
399
400 * window.h (resize_frame_windows): Move up in code.
401 (Fwindow_frame): Remove EXFUN.
402 (replace_buffer_in_all_windows): Remove prototype.
403 (replace_buffer_in_windows_safely): Add prototype.
404
405 * window.c: Declare Qdelete_window static again. Move down
406 declaration of select_count.
407 (Fnext_window, Fprevious_window): Rewrite doc-strings.
408 (Fother_window): Move to window.el.
409 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
410 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
411 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
412 window.el.
413 (replace_buffer_in_windows): Implement by calling
414 Qreplace_buffer_in_windows.
415 (replace_buffer_in_all_windows): Remove with some functionality
416 moved into replace_buffer_in_windows_safely.
417 (replace_buffer_in_windows_safely): New function.
418 (select_window_norecord, select_frame_norecord): Move in front
419 of run_window_configuration_change_hook. Remove now obsolete
420 declarations.
421 (Fset_window_buffer): Rewrite doc-string. Call
422 Qrecord_window_buffer.
423 (keys_of_window): Move binding for other-window to window.el.
424
425 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
426
427 * dispextern.h (struct image): Replace data member, whose int_val
428 and ptr_val fields were not used by anything, with a single
429 lisp_val object.
430
431 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
432 (gif_clear_image, gif_load, imagemagick_load_image)
433 (gs_clear_image, gs_load): Callers changed.
434
435 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
436
437 * buffer.h: Include <time.h>, for time_t.
438 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
439
440 Fix minor problems found by static checking.
441
442 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
443
444 Make identifiers static if they are not used in other modules.
445 * data.c (Qcompiled_function, Qframe, Qvector):
446 * image.c (QimageMagick, Qsvg):
447 * minibuf.c (Qmetadata):
448 * window.c (resize_window_check, resize_root_window): Now static.
449 * window.h (resize_window_check, resize_root_window): Remove decls.
450
451 * window.c (window_deletion_count, delete_deletable_window):
452 Remove; unused.
453 (window_body_lines): Now static.
454 (Fdelete_other_windows_internal): Mark vars as initialized.
455 Make sure 'resize_failed' is initialized.
456 (run_window_configuration_change_hook): Rename local to avoid shadowing.
457 (resize_window_apply): Remove unused local.
458 * window.h (delete_deletable_window): Remove decl.
459
460 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
461 (imagemagick_load_image): Fix pointer signedness problem by changing
462 last arg from unsigned char * to char *. All uses changed.
463 Also, fix a local for similar reasons.
464 Remove unused locals. Remove locals to avoid shadowing.
465 (fn_rsvg_handle_free): Remove; unused.
466 (svg_load, svg_load_image): Fix pointer signedness problem.
467 (imagemagick_load_image): Don't use garbage pointer image_wand.
468
469 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
470
471 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
472
473 * image.c (gif_load): Fix omitted cast error introduced by
474 2011-06-06 change.
475
476 2011-06-10 Martin Rudalics <rudalics@gmx.at>
477
478 * window.h (resize_proportionally, orig_total_lines)
479 (orig_top_line): Remove from window structure.
480 (set_window_height, set_window_width, change_window_heights)
481 (Fdelete_window): Remove prototypes.
482 (resize_frame_windows): Remove duplicate declaration.
483
484 2011-06-10 Eli Zaretskii <eliz@gnu.org>
485
486 * window.h (resize_frame_windows, resize_window_check)
487 (delete_deletable_window, resize_root_window)
488 (resize_frame_windows): Declare prototypes.
489
490 * window.c (resize_window_apply): Make definition be "static" to
491 match the prototype.
492
493 2011-06-10 Martin Rudalics <rudalics@gmx.at>
494
495 * window.c: Remove declarations of Qwindow_size_fixed,
496 window_min_size_1, window_min_size_2, window_min_size,
497 size_window, window_fixed_size_p, enlarge_window, delete_window.
498 Remove static from declaration of Qdelete_window, it's
499 temporarily needed by Fbury_buffer.
500 (replace_window): Don't assign orig_top_line and
501 orig_total_lines.
502 (Fdelete_window, delete_window): Remove. Window deletion is
503 handled by window.el.
504 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
505 Fdelete_window calls with calls to Qdelete_window.
506 (Fdelete_other_windows): Remove. Deleting other windows is
507 handled by window.el.
508 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
509 handled in window.el.
510 (window_min_size_2, window_min_size_1, window_min_size): Remove.
511 Window minimum sizes are handled in window.el.
512 (shrink_windows, size_window, set_window_height)
513 (set_window_width, change_window_heights, window_height)
514 (window_width, CURBEG, CURSIZE, enlarge_window)
515 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
516 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
517 handled in window.el.
518 (make_dummy_parent): Rename to make_parent_window and give it a
519 second argument horflag.
520 (make_window): Don't set resize_proportionally any more.
521 (Fsplit_window): Remove. Windows are split in window.el.
522 (save_restore_action, save_restore_orig_size)
523 (shrink_window_lowest_first, save_restore_orig_size): Remove.
524 Resize mini windows in window.el.
525 (grow_mini_window, shrink_mini_window): Implement by calling
526 Qresize_root_window_vertically, resize_window_check and
527 resize_window_apply.
528 (saved_window, Fset_window_configuration, save_window_save): Do
529 not handle orig_top_line, orig_total_lines, and
530 resize_proportionally.
531 (window_min_height, window_min_width): Move to window.el.
532 (keys_of_window): Move bindings for delete-other-windows,
533 split-window, delete-window and enlarge-window to window.el.
534
535 * buffer.c: Temporarily extern Qdelete_window.
536 (Fbury_buffer): Temporarily call Qdelete_window instead of
537 Fdelete_window (Fbury_buffer will move to window.el soon).
538
539 * frame.c (set_menu_bar_lines_1): Remove code handling
540 orig_top_line and orig_total_lines.
541
542 * dispnew.c (adjust_frame_glyphs_initially): Don't use
543 set_window_height but set heights directly.
544 (change_frame_size_1): Use resize_frame_windows.
545
546 * xdisp.c (init_xdisp): Don't use set_window_height but set
547 heights directly.
548
549 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
550 resize_frame_windows instead of change_window_heights and run
551 run_window_configuration_change_hook.
552
553 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
554 instead of change_window_heights and run
555 run_window_configuration_change_hook.
556
557 2011-06-09 Martin Rudalics <rudalics@gmx.at>
558
559 * window.c (replace_window): Rename second argument REPLACEMENT to
560 NEW. New third argument SETFLAG. Rewrite.
561 (delete_window, make_dummy_parent): Call replace_window with
562 third argument 1.
563 (window_list_1): Move down in code.
564 (run_window_configuration_change_hook): Move set_buffer part
565 before select_frame_norecord part in order to unwind correctly.
566 Rename count1 to count.
567 (recombine_windows, delete_deletable_window, resize_root_window)
568 (Fdelete_other_windows_internal)
569 (Frun_window_configuration_change_hook, make_parent_window)
570 (resize_window_check, resize_window_apply, Fresize_window_apply)
571 (resize_frame_windows, Fsplit_window_internal)
572 (Fdelete_window_internal, Fresize_mini_window_internal): New
573 functions.
574 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
575
576 2011-06-08 Martin Rudalics <rudalics@gmx.at>
577
578 * window.h (window): Add some new members to window structure -
579 normal_lines, normal_cols, new_total, new_normal, clone_number,
580 splits, nest, prev_buffers, next_buffers.
581 (WINDOW_TOTAL_SIZE): Move here from window.c.
582 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
583
584 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
585 Remove.
586 (make_dummy_parent): Set new members of windows structure.
587 (make_window): Move down in code. Handle new members of window
588 structure.
589 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
590 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
591 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
592 (Fset_window_prev_buffers, Fwindow_next_buffers)
593 (Fset_window_next_buffers, Fset_window_clone_number): New
594 functions.
595 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
596 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
597 Doc-string fixes.
598 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
599 Argument WINDOW can be now internal window too.
600 (Fwindow_use_time): Move up in code.
601 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
602 Rewrite doc-string.
603 (Fset_window_configuration, saved_window)
604 (Fcurrent_window_configuration, save_window_save): Handle new
605 members of window structure.
606 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
607 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
608 (syms_of_window): New Lisp objects Qrecord_window_buffer,
609 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
610 Qget_mru_window, Qresize_root_window,
611 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
612 Qauto_buffer_name; staticpro them.
613
614 2011-06-07 Martin Rudalics <rudalics@gmx.at>
615
616 * window.c (Fwindow_total_size, Fwindow_left_column)
617 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
618 (Fwindow_list_1): New functions.
619 (window_box_text_cols): Replace with window_body_cols.
620 (Fwindow_width, Fscroll_left, Fscroll_right): Use
621 window_body_cols instead of window_box_text_cols.
622 (delete_window, Fset_window_configuration): Call
623 delete_all_subwindows with window as argument.
624 (delete_all_subwindows): Take a window as argument and not a
625 structure. Rewrite.
626 (window_loop): Remove handling of GET_LRU_WINDOW and
627 GET_LARGEST_WINDOW.
628 (Fget_lru_window, Fget_largest_window): Move to window.el.
629
630 * window.h: Extern window_body_cols instead of
631 window_box_text_cols. delete_all_subwindows now takes a
632 Lisp_Object as argument.
633
634 * indent.c (compute_motion, Fcompute_motion): Use
635 window_body_cols instead of window_box_text_cols.
636
637 * frame.c (delete_frame): Call delete_all_subwindows with root
638 window as argument.
639
640 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
641
642 * fns.c (Fputhash): Document return value.
643
644 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
645
646 * image.c (gif_load): Implement gif89a spec "no disposal" method.
647
648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
649
650 Cons<->int and similar integer overflow fixes (Bug#8794).
651
652 Check for overflow when converting integer to cons and back.
653 * charset.c (Fdefine_charset_internal, Fdecode_char):
654 Use cons_to_unsigned to catch overflow.
655 (Fencode_char): Use INTEGER_TO_CONS.
656 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
657 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
658 * data.c (long_to_cons, cons_to_long): Remove.
659 (cons_to_unsigned, cons_to_signed): New functions.
660 These signal an error for invalid or out-of-range values.
661 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
662 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
663 * font.c (Ffont_variation_glyphs):
664 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
665 * lisp.h: Include <intprops.h>.
666 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
667 (cons_to_signed, cons_to_unsigned): New decls.
668 (long_to_cons, cons_to_long): Remove decls.
669 * undo.c (record_first_change): Use INTEGER_TO_CONS.
670 (Fprimitive_undo): Use CONS_TO_INTEGER.
671 * xfns.c (Fx_window_property): Likewise.
672 * xselect.c: Include <limits.h>.
673 (x_own_selection, selection_data_to_lisp_data):
674 Use INTEGER_TO_CONS.
675 (x_handle_selection_request, x_handle_selection_clear)
676 (x_get_foreign_selection, Fx_disown_selection_internal)
677 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
678 (lisp_data_to_selection_data): Use cons_to_unsigned.
679 (x_fill_property_data): Use cons_to_signed.
680 Report values out of range.
681
682 Check for buffer and string overflow more precisely.
683 * buffer.h (BUF_BYTES_MAX): New macro.
684 * lisp.h (STRING_BYTES_MAX): New macro.
685 * alloc.c (Fmake_string):
686 * character.c (string_escape_byte8):
687 * coding.c (coding_alloc_by_realloc):
688 * doprnt.c (doprnt):
689 * editfns.c (Fformat):
690 * eval.c (verror):
691 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
692 since they may not be the same number.
693 * editfns.c (Finsert_char):
694 * fileio.c (Finsert_file_contents):
695 Likewise for BUF_BYTES_MAX.
696
697 * image.c: Use ptrdiff_t, not int, for sizes.
698 (slurp_file): Switch from int to ptrdiff_t.
699 All uses changed.
700 (slurp_file): Check that file size fits in both size_t (for
701 malloc) and ptrdiff_t (for sanity and safety).
702
703 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
704 if b->modtime has its maximal value.
705
706 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
707
708 Don't assume time_t can fit into int.
709 * buffer.h (struct buffer.modtime): Now time_t, not int.
710 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
711 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
712
713 Minor fixes for signed vs unsigned integers.
714 * character.h (MAYBE_UNIFY_CHAR):
715 * charset.c (maybe_unify_char):
716 * keyboard.c (read_char, reorder_modifiers):
717 XINT -> XFASTINT, since the integer must be nonnegative.
718 * ftfont.c (ftfont_spec_pattern):
719 * keymap.c (access_keymap, silly_event_symbol_error):
720 XUINT -> XFASTINT, since the integer must be nonnegative.
721 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
722 since it makes no difference and we prefer signed.
723 * keyboard.c (record_char): Use XUINT when all the neighbors do.
724 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
725 nonnegative.
726
727 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
728
729 * window.h (Fwindow_frame): Declare.
730
731 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
732
733 * alloc.c: Simplify handling of large-request failures (Bug#8800).
734 (SPARE_MEMORY): Always define.
735 (LARGE_REQUEST): Remove.
736 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
737
738 2011-06-06 Martin Rudalics <rudalics@gmx.at>
739
740 * lisp.h: Move EXFUNS for Fframe_root_window,
741 Fframe_first_window and Fset_frame_selected_window to window.h.
742
743 * window.h: Move EXFUNS for Fframe_root_window,
744 Fframe_first_window and Fset_frame_selected_window here from
745 lisp.h.
746
747 * frame.c (Fwindow_frame, Fframe_first_window)
748 (Fframe_root_window, Fframe_selected_window)
749 (Fset_frame_selected_window): Move to window.c.
750 (Factive_minibuffer_window): Move to minibuf.c.
751 (Fother_visible_frames_p): New function.
752
753 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
754
755 * window.c (decode_window, decode_any_window): Move up in code.
756 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
757 (inhibit_frame_unsplittable): Remove unused variable.
758 (Fwindow_buffer): Move up and rewrite doc-string.
759 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
760 (Fwindow_prev): New functions.
761 (Fwindow_frame): Move here from frame.c. Accept any window as
762 argument.
763 (Fframe_root_window, Fframe_first_window)
764 (Fframe_selected_window): Move here from frame.c. Accept frame
765 or arbitrary window as argument. Update doc-strings.
766 (Fminibuffer_window): Move up in code.
767 (Fwindow_minibuffer_p): Move up in code and simplify.
768 (Fset_frame_selected_window): Move here from frame.c.
769 Marginal rewrite.
770 (Fselected_window, select_window, Fselect_window): Move up in
771 code. Minor doc-string fixes.
772
773 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
774
775 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
776 Do not assume that spare memory exists; that assumption is valid
777 only if SYSTEM_MALLOC.
778 (LARGE_REQUEST): New macro, so that the issue of large requests
779 is separated from the issue of spare memory.
780
781 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
782
783 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
784 format. (Bug#8806)
785
786 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
787
788 * xfns.c (x_set_scroll_bar_default_width): Move declarations
789 before statements.
790
791 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
792
793 * gtkutil.c (xg_get_default_scrollbar_width): New function.
794
795 * gtkutil.h: Declare xg_get_default_scrollbar_width.
796
797 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
798 min width by calling x_set_scroll_bar_default_width (Bug#8505).
799
800 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
801
802 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
803
804 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
805
806 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
807 (x_clipboard_manager_save): Add return value.
808 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
809 New error handlers.
810 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
811 Obey Vx_select_enable_clipboard_manager. Catch errors in
812 x_clipboard_manager_save (Bug#8779).
813 (Vx_select_enable_clipboard_manager): New variable.
814 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
815
816 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
817
818 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
819
820 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
821
822 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
823 in the current matrix if keep_current_p is non-zero.
824
825 2011-06-04 Eli Zaretskii <eliz@gnu.org>
826
827 * bidi.c (bidi_level_of_next_char): Fix last change.
828
829 2011-06-03 Eli Zaretskii <eliz@gnu.org>
830
831 Support bidi reordering of text covered by display properties.
832
833 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
834 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
835 (bidi_cache_search, bidi_cache_iterator_state)
836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
837 (bidi_level_of_next_char, bidi_move_to_visually_next):
838 Support character positions inside a run of characters covered by a
839 display string.
840 (bidi_paragraph_init, bidi_resolve_explicit_1)
841 (bidi_level_of_next_char): Call bidi_fetch_char and
842 bidi_fetch_char_advance instead of FETCH_CHAR and
843 FETCH_CHAR_ADVANCE.
844 (bidi_init_it): Initialize new members.
845 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
846 definitions.
847 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
848 instead of using explicit *_CHAR codes.
849 (bidi_resolve_explicit, bidi_resolve_weak):
850 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
851 bidirectional text is supported only in multibyte buffers.
852 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
853 it to initialize the frame_window_p member of struct bidi_it.
854 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
855 (bidi_resolve_explicit, bidi_resolve_weak)
856 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
857 bidi_it->nchars is non-positive.
858 (bidi_level_of_next_char): Don't try to lookup the cache for the
859 next/previous character if nothing is cached there yet, or if we
860 were just reseat()'ed to a new position.
861
862 * xdisp.c (set_cursor_from_row): Set start and stop points
863 according to the row's direction when priming the loop that looks
864 for the glyph on which to display cursor.
865 (single_display_spec_intangible_p): Function deleted.
866 (display_prop_intangible_p): Reimplement to call
867 handle_display_spec instead of single_display_spec_intangible_p.
868 Accept 3 additional arguments needed by handle_display_spec.
869 This fixes incorrect cursor motion across display property with complex
870 values: lists, `(when COND...)' forms, etc.
871 (single_display_spec_string_p): Support property values that are
872 lists with the argument STRING its top-level element.
873 (display_prop_string_p): Fix the condition for processing a
874 property that is a list to be consistent with handle_display_spec.
875 (handle_display_spec): New function, refactored from the
876 last portion of handle_display_prop.
877 (compute_display_string_pos): Accept additional argument
878 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
879 value of a `display' property is a "replacing spec".
880 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
881 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
882 the display property, but just return a value indicating whether
883 the display property will replace the characters it covers.
884 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
885 frame_window_p members of struct bidi_it.
886 (compute_display_string_pos, compute_display_string_end):
887 New functions.
888 (push_it): Accept second argument POSITION, where pop_it should
889 jump to continue iteration.
890 (reseat_1): Initialize bidi_it.disp_pos.
891
892 * keyboard.c (adjust_point_for_property): Adjust the call to
893 display_prop_intangible_p to its new signature.
894
895 * dispextern.h (struct bidi_it): New member frame_window_p.
896 (bidi_init_it): Update prototypes.
897 (display_prop_intangible_p): Update prototype.
898 (compute_display_string_pos, compute_display_string_end):
899 Declare prototypes.
900 (struct bidi_it): New members nchars and disp_pos. ch_len is now
901 EMACS_INT.
902
903 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
904
905 Malloc failure behavior now depends on size of allocation.
906 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
907 * lisp.h: Change signatures accordingly.
908 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
909 All callers changed. (Bug#8762)
910
911 * gnutls.c: Use Emacs's memory allocators.
912 Without this change, the gnutls library would invoke malloc etc.
913 directly, which causes problems on non-SYNC_INPUT hosts, and which
914 runs afoul of improving memory_full behavior. (Bug#8761)
915 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
916 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
917 xfree instead of the default malloc, realloc, free.
918 (Fgnutls_boot): No need to check for memory allocation failure,
919 since xmalloc does that for us.
920
921 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
922 * category.c (hash_get_category_set):
923 * ccl.c (ccl_driver):
924 * charset.c (Fdefine_charset_internal):
925 * charset.h (struct charset.hash_index):
926 * composite.c (get_composition_id, gstring_lookup_cache)
927 (composition_gstring_put_cache):
928 * composite.h (struct composition.hash_index):
929 * dispextern.h (struct image.hash):
930 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
931 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
932 (hashfn_equal, hashfn_user_defined, make_hash_table)
933 (maybe_resize_hash_table, hash_lookup, hash_put)
934 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
935 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
936 (Fsxhash, Fgethash, Fputhash, Fmaphash):
937 * image.c (make_image, search_image_cache, lookup_image)
938 (xpm_put_color_table_h):
939 * lisp.h (struct Lisp_Hash_Table):
940 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
941 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
942 for hashes and hash indexes, instead of 'unsigned' and 'int'.
943 * alloc.c (allocate_vectorlike):
944 Check for overflow in vector size calculations.
945 * ccl.c (ccl_driver):
946 Check for overflow when converting EMACS_INT to int.
947 * fns.c, image.c: Remove unnecessary static decls that would otherwise
948 need to be updated by these changes.
949 * fns.c (make_hash_table, maybe_resize_hash_table):
950 Check for integer overflow with large hash tables.
951 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
952 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
953 (SXHASH_REDUCE): New macro.
954 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
955 Use it instead of discarding useful hash info with large hash values.
956 (sxhash_float): New function.
957 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
958 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
959 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
960 Rewrite to use FIXNUM_BITS, as this simplifies things.
961 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
962 Adjust signatures to match updated version of code.
963 (consing_since_gc): Now EMACS_INT, since a single hash table can
964 use more than INT_MAX bytes.
965
966 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
967
968 Make it possible to build with GCC-4.6+ -O2 -flto.
969
970 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
971
972 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
973
974 * minibuf.c (get_minibuffer, read_minibuf_unwind):
975 Call minibuffer-inactive-mode.
976
977 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
978
979 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
980 Update dependencies.
981
982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
983
984 * data.c (init_data): Remove code for UTS, this system is not
985 supported anymore.
986
987 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
988
989 Don't force ./temacs to start in terminal mode.
990
991 * frame.c (make_initial_frame): Initialize faces in all cases, not
992 only when CANNOT_DUMP is defined.
993 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
994
995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
996
997 * dispnew.c (add_window_display_history): Use const for the string
998 pointer. Remove declaration, not needed.
999
1000 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Use 'inline', not 'INLINE'.
1003 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1004 * alloc.c, fontset.c (INLINE): Remove.
1005 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1006 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1007 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1008 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1009 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1010
1011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1012
1013 Make it possible to run ./temacs.
1014
1015 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1016 syms_of_callproc does the same thing. Remove test for
1017 "initialized", do it in the caller.
1018 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1019
1020 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1021
1022 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1023 (read_minibuf): Use get_minibuffer.
1024 (syms_of_minibuf): Use DEFSYM.
1025 (Qmetadata): New var.
1026 * data.c (Qbuffer): Don't make it static.
1027 (syms_of_data): Use DEFSYM.
1028
1029 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1032 (CCL_CODE_MIN): New macro.
1033
1034 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1037
1038 * eval.c (Qdebug): Now static.
1039 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1040 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1041 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1042
1043 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1044
1045 * image.c: Various fixes to ImageMagick code comments.
1046 (Fimagemagick_types): Doc fix.
1047
1048 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 Minor fixes prompted by GCC 4.6.0 warnings.
1051
1052 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1053
1054 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1055 (x_clipboard_manager_save_all): Move extern decl to ...
1056 * xterm.h: ... here, so that it can be checked for consistency.
1057
1058 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1059
1060 * xselect.c (x_clipboard_manager_save_frame)
1061 (x_clipboard_manager_save_all): New functions.
1062 (Fx_clipboard_manager_save): Lisp function deleted.
1063
1064 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1065 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1066
1067 * xterm.h: Update prototype.
1068
1069 2011-05-28 William Xu <william.xwl@gmail.com>
1070
1071 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1072 exiting (Bug#8239).
1073
1074 2011-05-28 Jim Meyering <meyering@redhat.com>
1075
1076 Avoid a sign-extension bug in crypto_hash_function.
1077 * fns.c (to_uchar): Define.
1078 (crypto_hash_function): Use it to convert some newly-signed
1079 variables to unsigned, to avoid sign-extension bugs. For example,
1080 without this change, (md5 "truc") would evaluate to
1081 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1082 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1083 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1084
1085 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 Integer overflow fixes.
1088
1089 * dbusbind.c: Serial number integer overflow fixes.
1090 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1091 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1092 to hold a serial number that is too large for a fixnum.
1093 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1094 Check for serial numbers out of range. Decode any serial number
1095 that was so large that it became a float. (Bug#8722)
1096
1097 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1098 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1099 Use XFASTINT rather than XUINT when numbers are nonnegative.
1100 (xd_append_arg, Fdbus_method_return_internal):
1101 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1102 arguments, check that Lisp number is nonnegative, rather than
1103 silently wrapping negative numbers around. (Bug#8722)
1104 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1105 (Bug#8722)
1106
1107 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1108
1109 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1110
1111 ccl: add integer overflow checks
1112 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1113 (IN_INT_RANGE): New macros.
1114 (ccl_driver): Use them to check for integer overflow when
1115 decoding a CCL program. Many of the new checks are whether XINT (x)
1116 fits in int; it doesn't always, on 64-bit hosts. The new version
1117 doesn't catch all possible integer overflows, but it's an
1118 improvement. (Bug#8719)
1119
1120 * alloc.c (make_event_array): Use XINT, not XUINT.
1121 There's no need for unsigned here.
1122
1123 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1124 This follows up to the 2011-05-06 change that substituted uintptr_t
1125 for EMACS_INT. This case wasn't caught back then.
1126
1127 Rework Fformat to avoid integer overflow issues.
1128 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1129 now (part of C89). Include <verify.h>.
1130 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1131 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1132 (Fformat): Avoid the prepass trying to compute sizes; it was only
1133 approximate and thus did not catch overflow reliably. Instead, walk
1134 through the format just once, formatting and computing sizes as we go,
1135 checking for integer overflow at every step, and allocating a larger
1136 buffer as needed. Keep track separately whether the format is
1137 multibyte. Keep only the most-recently calculated precision, rather
1138 than them all. Record whether each argument has been converted to
1139 string. Use EMACS_INT, not int, for byte and char and arg counts.
1140 Support field widths and precisions larger than INT_MAX. Avoid
1141 sprintf's undefined behavior with conversion specifications such as %#d
1142 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1143 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1144 formatting out-of-range floating point numbers with int
1145 formats. (Bug#8668)
1146
1147 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1148
1149 * data.c: Avoid integer truncation in expressions involving floats.
1150 * data.c: Include <intprops.h>.
1151 (arith_driver): When there's an integer overflow in an expression
1152 involving floating point, convert the integers to floating point
1153 so that the resulting value does not suffer from catastrophic
1154 integer truncation. For example, on a 64-bit host (* 4
1155 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1156 Do not rely on undefined behavior after integer overflow.
1157
1158 merge count_size_as_multibyte, parse_str_to_multibyte
1159 * character.c, character.h (count_size_as_multibyte):
1160 Rename from parse_str_to_multibyte; all uses changed.
1161 Check for integer overflow.
1162 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1163 since it's now a duplicate of the other. This is more of
1164 a character than a buffer op, so better that it's in character.c.
1165 * fns.c, print.c: Adjust to above changes.
1166
1167 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1168
1169 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1170
1171 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1174 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1175 (x_clipboard_manager_save): Now static.
1176 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1177
1178 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1179 (crypto_hash_function): Now static.
1180 Fix pointer signedness problems. Avoid unnecessary initializations.
1181
1182 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * termhooks.h (Vselection_alist): Make it terminal-local.
1185
1186 * terminal.c (create_terminal): Initialize it.
1187
1188 * xselect.c: Support for clipboard managers.
1189 (Vselection_alist): Move to termhooks.h as terminal-local var.
1190 (LOCAL_SELECTION): New macro.
1191 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1192 (symbol_to_x_atom): Remove gratuitous arg.
1193 (x_handle_selection_request, lisp_data_to_selection_data)
1194 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1195 (x_own_selection, x_get_local_selection, x_convert_selection):
1196 New arg, specifying work frame. Use terminal-local Vselection_alist.
1197 (some_frame_on_display): Delete unused function.
1198 (Fx_own_selection_internal, Fx_get_selection_internal)
1199 (Fx_disown_selection_internal, Fx_selection_owner_p)
1200 (Fx_selection_exists_p): New optional frame arg.
1201 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1202 (x_handle_selection_clear): Don't treat other terminals with the
1203 same keyboard specially. Use the terminal-local Vselection_alist.
1204 (x_clear_frame_selections): Use Frun_hook_with_args.
1205
1206 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1207
1208 * xterm.h: Add support for those atoms.
1209
1210 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1211
1212 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1213 (converted_selections, conversion_fail_tag): New global variables.
1214 (x_selection_request_lisp_error): Free the above.
1215 (x_get_local_selection): Remove unnecessary code.
1216 (x_reply_selection_request): Args changed; handle arbitrary array
1217 of converted selections stored in converted_selections.
1218 Separate the XChangeProperty and SelectionNotify steps.
1219 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1220 (x_convert_selection): New function.
1221 (x_handle_selection_event): Simplify.
1222 (x_get_foreign_selection): Don't ignore incoming requests while
1223 waiting for an answer; this will fail when we implement
1224 SAVE_TARGETS, and seems unnecessary anyway.
1225 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1226 (Vx_sent_selection_functions): Doc fix.
1227
1228 2011-05-26 Leo Liu <sdl.web@gmail.com>
1229
1230 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1231
1232 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1233
1234 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1235
1236 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1237 for fringe update if it has periodic bitmap.
1238 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1239 and fringe_bitmap_periodic_p.
1240
1241 * fringe.c (get_fringe_bitmap_data): New function.
1242 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1243 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1244 row. Mark glyph row for fringe update if periodicity changed.
1245
1246 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1247 for fringe update unless it has periodic bitmap.
1248
1249 2011-05-25 Kenichi Handa <handa@m17n.org>
1250
1251 * xdisp.c (get_next_display_element): Set correct it->face_id for
1252 a static composition.
1253
1254 2011-05-24 Leo Liu <sdl.web@gmail.com>
1255
1256 * deps.mk (fns.o):
1257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1258
1259 * fns.c (crypto_hash_function, Fsha1): New function.
1260 (Fmd5): Use crypto_hash_function.
1261 (syms_of_fns): Add Ssha1.
1262
1263 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 * gnutls.c: Remove unused macros.
1266 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1267 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1268 Remove macros that are defined and never used.
1269 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1270
1271 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1274 (Fx_get_selection_internal): Minor cleanup.
1275 (Fx_own_selection_internal): Rename arguments for consistency with
1276 select.el.
1277
1278 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1281
1282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1285
1286 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1287
1288 * dispnew.c (scrolling_window): Don't exclude the case that the
1289 last enabled row in the desired matrix touches the bottom boundary.
1290
1291 2011-05-21 Glenn Morris <rgm@gnu.org>
1292
1293 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1294 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1295 and add some more files.
1296
1297 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1298
1299 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1300 report_file_error introduced by the change from 2011-05-07.
1301
1302 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * systime.h (Time): Define only if emacs is defined.
1305 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1306 where the include path doesn't have X11/X.h by default. See
1307 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1308
1309 2011-05-20 Kenichi Handa <handa@m17n.org>
1310
1311 * composite.c (find_automatic_composition): Fix previous change.
1312
1313 2011-05-20 Glenn Morris <rgm@gnu.org>
1314
1315 * lisp.mk: New file, split from Makefile.in.
1316 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1317 (shortlisp): Remove.
1318 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1319
1320 2011-05-19 Glenn Morris <rgm@gnu.org>
1321
1322 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1323 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1324 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1325 (lisp): Set the order to that of loadup.el.
1326 (shortlisp): Make it a copy of $lisp.
1327 (SOME_MACHINE_LISP): Remove.
1328 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1329 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1330
1331 2011-05-18 Kenichi Handa <handa@m17n.org>
1332
1333 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1334 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1335 (find_automatic_composition): Mostly rewrite for efficiency.
1336
1337 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * makefile.w32-in: Update dependencies.
1340
1341 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1342
1343 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1344 revision 104625).
1345
1346 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 Fix some integer overflow issues, such as string length overflow.
1349
1350 * insdel.c (count_size_as_multibyte): Check for string overflow.
1351
1352 * character.c (lisp_string_width): Check for string overflow.
1353 Use EMACS_INT, not int, for string indexes and lengths; in
1354 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1355 the resulting string length overflows an EMACS_INT; instead,
1356 report a string overflow if no precision given. When checking for
1357 precision exhaustion, use a check that cannot possibly have
1358 integer overflow. (Bug#8675)
1359 * character.h (lisp_string_width): Adjust to new signature.
1360
1361 * alloc.c (string_overflow): New function.
1362 (Fmake_string): Use it. This doesn't change behavior, but saves
1363 a few bytes and will simplify future changes.
1364 * character.c (string_escape_byte8): Likewise.
1365 * lisp.h (string_overflow): New decl.
1366
1367 Fixups, following up to the user-interface timestamp change.
1368 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1369 for UI timestamps, instead of unsigned long.
1370 * msdos.c (mouse_get_pos): Likewise.
1371 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1372 * w32gui.h (Time): Define by including "systime.h" rather than by
1373 declaring it ourselves. (Bug#8664)
1374
1375 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1376 * image.c (clear_image_cache): Likewise.
1377
1378 * term.c (term_mouse_position): Don't assume time_t wraparound.
1379
1380 Be more systematic about user-interface timestamps.
1381 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1382 and sometimes 'EMACS_UINT', to represent these timestamps.
1383 This change causes it to use 'Time' uniformly, as that's what X uses.
1384 This makes the code easier to follow, and makes it easier to catch
1385 integer overflow bugs such as Bug#8664.
1386 * frame.c (Fmouse_position, Fmouse_pixel_position):
1387 Use Time, not unsigned long, for user-interface timestamps.
1388 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1389 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1390 * keyboard.h (last_event_timestamp): Likewise.
1391 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1392 * menu.h (xmenu_show): Likewise.
1393 * term.c (term_mouse_position): Likewise.
1394 * termhooks.h (struct input_event.timestamp): Likewise.
1395 (struct terminal.mouse_position_hook): Likewise.
1396 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1397 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1398 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1399 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1400 what it was before.
1401 * menu.h, termhooks.h: Include "systime.h", for Time.
1402
1403 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1404 Don't assume that the difference between two unsigned long values
1405 can fit into an integer. At this point, we know button_down_time
1406 <= event->timestamp, so the difference must be nonnegative, so
1407 there's no need to cast the result if double-click-time is
1408 nonnegative, as it should be; check that it's nonnegative, just in
1409 case. This bug is triggered when events are more than 2**31 ms
1410 apart (about 25 days). (Bug#8664)
1411
1412 * xselect.c (last_event_timestamp): Remove duplicate decl.
1413 (x_own_selection): Remove needless cast to unsigned long.
1414
1415 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1416 that always fit in int. Use a sentinel instead of a counter, to
1417 avoid a temp and to allay GCC's concerns about possible int overflow.
1418 * frame.h (struct frame): Use int for menu_bar_items_used
1419 instead of EMACS_INT, since it always fits in int.
1420
1421 * menu.c (grow_menu_items): Check for int overflow.
1422
1423 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1424
1425 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1426 Before, the code was not consistent. These values cannot exceed
1427 2**31 - 1 so there's no need to make them unsigned.
1428 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1429 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1430 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1431 as modifiers.
1432 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1433
1434 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1435 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1436 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1437 presumably because the widths might not match.
1438
1439 * window.c (size_window): Avoid needless test at loop start.
1440
1441 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1442
1443 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1444
1445 2011-05-12 Drew Adams <drew.adams@oracle.com>
1446
1447 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1448
1449 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1450
1451 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1452 `width' to `bar_area_x' and `bar_area_width', respectively.
1453 (x_scroll_run): Take account of fringe background extension.
1454
1455 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1456 Rename local vars `left' and `width' to `bar_area_x' and
1457 `bar_area_width', respectively.
1458 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1459 background extension.
1460
1461 2011-05-10 Jim Meyering <meyering@redhat.com>
1462
1463 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1464
1465 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1466
1467 * image.c (Finit_image_library): Return t for built-in image types,
1468 like pbm and xbm. (Bug#8640)
1469
1470 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1473
1474 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1475
1476 * w32console.c (Fset_screen_color): Doc fix.
1477 (Fget_screen_color): New function.
1478 (syms_of_ntterm): Defsubr it.
1479
1480 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1481 unlink the temporary file if Fcall_process didn't create it in the
1482 first place.
1483 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1484 child process will be redirected to a file specified with `:file'.
1485 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1486 cue to call_process_cleanup not to close that handle.
1487
1488 2011-05-07 Ben Key <bkey76@gmail.com>
1489
1490 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1491 one of two shell specific rules, either bootstrap-temacs-CMD or
1492 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1493 to the previous implementation of the bootstrap-temacs rule.
1494 The bootstrap-temacs-CMD rule is similar to the previous
1495 implementation of the bootstrap-temacs rule except that it
1496 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1497 variable.
1498
1499 These changes, along with some changes to nt/configure.bat,
1500 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1501 earlier fix to add support for --cflags and --ldflags options
1502 that include quotes so that it works whether make uses cmd or
1503 sh as the shell.
1504
1505 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1506
1507 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1508 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1509 is a constant.
1510 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1511 a string. Handle both cases.
1512 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1513 (Fdbus_register_method): Use Qinvalid_function.
1514
1515 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1516
1517 * makefile.w32-in: Update dependencies.
1518 (LISP_H): Add inttypes.h and stdin.h.
1519 (PROCESS_H): Add unistd.h.
1520
1521 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1522
1523 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1524 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1525
1526 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1529
1530 * term.c (vfatal): Remove stray call to va_end.
1531 It's not needed and the C Standard doesn't allow it here anyway.
1532
1533 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1534 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1535
1536 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1537 bytes.
1538
1539 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1540
1541 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1542
1543 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1544
1545 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1546
1547 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1548
1549 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1550 * charset.c (Fdefine_charset_internal): Don't initialize
1551 charset.code_space[15]. The value was garbage, on hosts with
1552 32-bit int (Bug#8600).
1553
1554 * lread.c (read_integer): Be more consistent with string-to-number.
1555 Use string_to_number to do the actual conversion; this avoids
1556 rounding errors and fixes some other screwups. Without this fix,
1557 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1558 (digit_to_number): Move earlier, for benefit of read_integer.
1559 Return -1 if the digit is out of range for the base, -2 if it is
1560 not a digit in any supported base. (Bug#8602)
1561
1562 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1563
1564 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1565 to match comment at start of function. This also removes a
1566 GCC warning about overflow in a 32+64-bit port.
1567
1568 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1569
1570 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1571 Reported by Stefan Monnier in
1572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1573 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1574 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1575
1576 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1577 (EMACS_UINTPTR): Likewise, with uintptr_t.
1578
1579 * lisp.h: Prefer 64-bit EMACS_INT if available.
1580 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1581 on 32-bit hosts that have 64-bit int, so that they can access
1582 large files.
1583 However, temporarily disable this change unless the temporary
1584 symbol WIDE_EMACS_INT is defined.
1585
1586 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1587
1588 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1589 This removes an assumption that EMACS_INT and long are the same
1590 width as pointers. The assumption is true for Emacs porting targets
1591 now, but we want to make other targets possible.
1592 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1593 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1594 In the rest of the code, change types of integers that hold casted
1595 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1596 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1597 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1598 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1599 No need to cast type when ORing.
1600 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1601 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1602 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1603 assume EMACS_INT is the same width as char *.
1604 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1605 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1606 Remove no-longer-needed casts.
1607 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1608 (xg_tool_bar_help_callback, xg_make_tool_item):
1609 Use EMACS_INTPTR to hold an integer
1610 that will be cast to void *; this can avoid a GCC warning
1611 if EMACS_INT is not the same width as void *.
1612 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1613 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1614 (current_message_1, set_message_1):
1615 Use a local to convert to proper width without a cast.
1616 * xmenu.c (dialog_selection_callback): Likewise.
1617
1618 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1619 Also, don't assume VALBITS / RAND_BITS is less than 5,
1620 and don't rely on undefined behavior when shifting a 1 left into
1621 the sign bit.
1622 * lisp.h (get_random): Change signature to match.
1623
1624 * lread.c (hash_string): Use size_t, not int, for hash computation.
1625 Normally we prefer signed values; but hashing is special, because
1626 it's better to use unsigned division on hash table sizes so that
1627 the remainder is nonnegative. Also, size_t is the natural width
1628 for hashing into memory. The previous code used 'int', which doesn't
1629 retain enough info to hash well into very large tables.
1630 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1631
1632 * dbusbind.c: Don't possibly lose pointer info when converting.
1633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1634 Use XPNTR rather than XHASH, so that the high-order bits of
1635 the pointer aren't lost when converting through void *.
1636
1637 * eval.c (Fautoload): Don't double-shift a pointer.
1638
1639 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1640
1641 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1642
1643 * gnutls.c (DEF_GNUTLS_FN):
1644 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1645
1646 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1647
1648 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1649 marker. (Bug#8610)
1650
1651 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1652
1653 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1654 New version that can reserve upto 2GB of heap space.
1655
1656 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1659
1660 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1661
1662 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1663 `gnutls_certificate_set_x509_key_file'.
1664
1665 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1666
1667 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1668 Update dependencies.
1669
1670 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1673 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1674 Remove unused parameter `fildes'.
1675 * process.c (read_process_output, send_process): Don't pass it.
1676
1677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1678
1679 Fix previous change: the library cache is defined in w32.c.
1680 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1681 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1682
1683 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1684
1685 Implement dynamic loading of GnuTLS on Windows.
1686
1687 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1688 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1689 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1690 Declare.
1691
1692 * gnutls.c (Qgnutls_dll): Define.
1693 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1694 (gnutls_*): Declare function pointers.
1695 (init_gnutls_functions): New function to initialize function pointers.
1696 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1697 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1699 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1700 (emacs_gnutls_write, emacs_gnutls_read)
1701 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1702 (Fgnutls_available_p): New function.
1703 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1704 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1705 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1706
1707 * image.c: Include w32.h.
1708 (Vimage_type_cache): Delete.
1709 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1710 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1711 (w32_delayed_load): Move to w32.c.
1712
1713 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1714
1715 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1716 (w32_delayed_load): Move from image.c. When loading a library, record
1717 its filename in the :loaded-from property of the library id.
1718 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1719 Initialize and staticpro them.
1720 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1721
1722 * process.c: Include lisp.h before w32.h, not after.
1723 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1724 instead of gnutls_record_check_pending.
1725
1726 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1727
1728 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1729
1730 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1731 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1732 as passed in.
1733
1734 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1735
1736 * xterm.c (x_set_frame_alpha): Do not set property on anything
1737 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1738
1739 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1740
1741 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1742
1743 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1746 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1747 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1748 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1749 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1750 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1751 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1752 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1753 (Qgnutls_bootprop_callbacks_verify): Make static.
1754
1755 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1756
1757 * callproc.c: Indentation fixup.
1758
1759 * sysdep.c (wait_for_termination_1): Make static.
1760 (wait_for_termination, interruptible_wait_for_termination):
1761 Move after wait_for_termination_1.
1762
1763 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1764
1765 * sysdep.c (interruptible_wait_for_termination): New function
1766 which is like wait_for_termination, but allows keyboard
1767 interruptions.
1768
1769 * callproc.c (Fcall_process): Add (:file "file") as an option for
1770 the STDOUT buffer.
1771 (Fcall_process_region): Ditto.
1772
1773 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1774
1775 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1776 rather than `XVECTOR (FOO)->size'.
1777
1778 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1779 inttypes.h, as a gnulib replacement is used if it not available in
1780 system headers.
1781
1782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1783
1784 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1785 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1786 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1787
1788 * coding.c (coding_alloc_by_realloc): Error out if destination
1789 will grow beyond MOST_POSITIVE_FIXNUM.
1790 (decode_coding_emacs_mule): Abort if there isn't enough place in
1791 charbuf for the composition carryover bytes. Reserve an extra
1792 space for up to 2 characters produced in a loop.
1793 (decode_coding_iso_2022): Abort if there isn't enough place in
1794 charbuf for the composition carryover bytes.
1795
1796 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1797
1798 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1799 aborting when %lld or %lll format is passed.
1800 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1801 %llo or %llx format is passed. (Bug#8545)
1802
1803 * window.c (window_scroll_line_based): Use a marker instead of
1804 simple variables to record original value of point. (Bug#7952)
1805
1806 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1807 produced by %s or %c overflows available buffer space. (Bug#8545)
1808
1809 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1812 (SIZE_MAX): Move defn after all includes, as they might #define it.
1813
1814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1815
1816 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1817
1818 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * keyboard.c (Qdelayed_warnings_hook): Define.
1821 (command_loop_1): Run `delayed-warnings-hook'
1822 if Vdelayed_warnings_list is non-nil.
1823 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1824 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1825
1826 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1827
1828 * doprnt.c (doprnt): Don't return value smaller than the buffer
1829 size if the message was truncated. (Bug#8545).
1830
1831 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1832
1833 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1834 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1835
1836 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1839
1840 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * makefile.w32-in: Update dependencies.
1843
1844 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1845
1846 Improve `doprnt' and its usage. (Bug#8545)
1847 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1848 `format_end'. Remove support for %l as a conversion specifier.
1849 Don't use xrealloc. Improve diagnostics when the %l size modifier
1850 is used. Update the commentary.
1851
1852 * eval.c (verror): Simplify calculation of size_t.
1853
1854 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1855 messages.
1856
1857 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1858
1859 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1860 change.
1861
1862 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1865 This makes this file independent of the recent pseudovector change.
1866
1867 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1870
1871 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1872 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1873 Remove unused local.
1874 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1875
1876 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1877 GCC 4.6.0 optimizes based on type-based alias analysis.
1878 For example, if b is of type struct buffer * and v of type struct
1879 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1880 != &v->size, and therefore "v->size = 1; b->size = 2; return
1881 v->size;" must therefore return 1. This assumption is incorrect
1882 for Emacs, since it type-puns struct Lisp_Vector * with many other
1883 types. To fix this problem, this patch adds a new type struct
1884 vectorlike_header that documents the constraints on layout of vectors
1885 and pseudovectors, and helps optimizing compilers not get fooled
1886 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1887 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1888 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1889 the size member.
1890 (XSETPVECTYPE): Rewrite in terms of new macro.
1891 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1892 This is a bit clearer, and further avoids the possibility of
1893 undesirable aliasing.
1894 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1895 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1896 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1897 since Lisp_Subr is a special case (no "next" field).
1898 (ASIZE): Now uses header.size rather than size.
1899 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1900 to avoid the hassle of writing XVECTOR (foo)->header.size.
1901 (struct vectorlike_header): New type.
1902 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1903 object, to help avoid aliasing.
1904 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1905 (SUBRP): Likewise, since Lisp_Subr is a special case.
1906 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1907 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1908 (struct Lisp_Hash_Table): Combine first two members into a single
1909 struct vectorlike_header member. All uses of "size" and "next" members
1910 changed to be "header.size" and "header.next".
1911 * buffer.h (struct buffer): Likewise.
1912 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1913 * frame.h (struct frame): Likewise.
1914 * process.h (struct Lisp_Process): Likewise.
1915 * termhooks.h (struct terminal): Likewise.
1916 * window.c (struct save_window_data, struct saved_window): Likewise.
1917 * window.h (struct window): Likewise.
1918 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1919 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1920 * buffer.c (init_buffer_once): Likewise.
1921 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1922 special case.
1923 * process.c (Fformat_network_address): Use local var for size,
1924 for brevity.
1925
1926 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1927
1928 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1929 * data.c (atof): Remove decl; no longer used or needed.
1930 (digit_to_number): Move to lread.c.
1931 (Fstring_to_number): Use new string_to_number function, to be
1932 consistent with how the Lisp reader treats infinities and NaNs.
1933 Do not assume that floating-point numbers represent EMACS_INT
1934 without losing information; this is not true on most 64-bit hosts.
1935 Avoid double-rounding errors, by insisting on integers when
1936 parsing non-base-10 numbers, as the documentation specifies.
1937 * lisp.h (string_to_number): New decl, replacing ...
1938 (isfloat_string): Remove.
1939 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1940 (read1): Do not accept +. and -. as integers; this
1941 appears to have been a coding error. Similarly, do not accept
1942 strings like +-1e0 as floating point numbers. Do not report
1943 overflow for integer overflows unless the base is not 10 which
1944 means we have no simple and reliable way to continue.
1945 Break out the floating-point parsing into a new
1946 function string_to_number, so that Fstring_to_number parses
1947 floating point numbers consistently with the Lisp reader.
1948 (digit_to_number): Move here from data.c. Make it static inline.
1949 (E_CHAR, EXP_INT): Remove, replacing with ...
1950 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1951 (string_to_number): New function, replacing isfloat_string.
1952 This function checks for valid syntax and produces the resulting
1953 Lisp float number too. Rework it so that string-to-number
1954 no longer mishandles examples like "1.0e+". Use strtoumax,
1955 so that overflow for non-base-10 numbers is reported only when
1956 there's no portable and simple way to convert to floating point.
1957
1958 * textprop.c (set_text_properties_1): Rewrite for clarity,
1959 and to avoid GCC warning about integer overflow.
1960
1961 * intervals.h (struct interval): Use EMACS_INT for members
1962 where EMACS_UINT might cause problems. See
1963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1964 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1965 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1966 All uses changed.
1967 (offset_intervals): Tell GCC not to worry about length overflow
1968 when negating a negative length.
1969
1970 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1971 (overrun_check_free): Likewise.
1972
1973 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1974 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1975 word size.
1976
1977 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1978 (gnutls_make_error): Rename local to avoid shadowing.
1979 (gnutls_emacs_global_deinit): ifdef out; not used.
1980 (Fgnutls_boot): Use const for pointer to readonly storage.
1981 Comment out unused local. Fix pointer signedness problems.
1982
1983 * lread.c (openp): Don't stuff size_t into an 'int'.
1984 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1985 about possible signed overflow.
1986
1987 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1988 (GDK_KEY_g): Don't define if already defined.
1989 (xg_prepare_tooltip): Avoid pointer signedness problem.
1990 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1991
1992 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1993 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1994
1995 * xfns.c (Fx_window_property): Simplify a bit,
1996 to make a bit faster and to avoid GCC 4.6.0 warning.
1997 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1998
1999 * fns.c (internal_equal): Don't assume size_t fits in int.
2000
2001 * alloc.c (compact_small_strings): Tighten assertion a little.
2002
2003 Replace pEd with more-general pI, and fix some printf arg casts.
2004 * lisp.h (pI): New macro, generalizing old pEd macro to other
2005 conversion specifiers. For example, use "...%"pI"d..." rather
2006 than "...%"pEd"...".
2007 (pEd): Remove. All uses replaced with similar uses of pI.
2008 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2009 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2010 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2011 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2012 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2013 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2014 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2015 64-bit hosts.
2016 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2017 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2018 * print.c (safe_debug_print, print_object): Likewise.
2019 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2020 to int.
2021 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2022 avoiding the 0 flag, which is not portable.
2023 * process.c (Fmake_network_process): Use pI to avoid cast.
2024 * region-cache.c (pp_cache): Likewise.
2025 * xdisp.c (decode_mode_spec): Likewise.
2026 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2027 behavior on 64-bit hosts with printf arg.
2028 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2029 (x_stop_queuing_selection_requests): Likewise.
2030 (x_get_window_property): Don't truncate byte count to an 'int'
2031 when tracing.
2032
2033 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2034 here, since it parses constructs like leading '-' and spaces,
2035 which are not wanted; and it overflows with large numbers.
2036 Instead, simply match F[0-9]+, which is what is wanted anyway.
2037
2038 * alloc.c: Remove unportable assumptions about struct layout.
2039 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2040 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2041 (allocate_vectorlike, make_pure_vector): Use the new macros,
2042 plus offsetof, to remove unportable assumptions about struct layout.
2043 These assumptions hold on all porting targets that I know of, but
2044 they are not guaranteed, they're easy to remove, and removing them
2045 makes further changes easier.
2046
2047 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2048 This doesn't fix a bug but makes the code clearer.
2049 (string_overrun_cookie): Now const. Use initializers that
2050 don't formally overflow signed char, to avoid warnings.
2051 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2052 can cause Emacs to crash when string overrun checking is enabled.
2053 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2054 multiple of sizeof (EMACS_INT); it need not be, if
2055 alignof(EMACS_INT) < sizeof (EMACS_INT).
2056 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2057
2058 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2061
2062 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2063
2064 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2065 supposed to be handshaking. (Bug#8556)
2066 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2067
2068 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2069
2070 * lisp.h (Qdebug): List symbol.
2071 * eval.c (Qdebug): Restore global linkage.
2072 * keyboard.c (debug-on-event): New variable.
2073 (handle_user_signal): Break into debugger when debug-on-event
2074 matches the current signal symbol.
2075
2076 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2077
2078 * alloc.c (check_sblock, check_string_bytes)
2079 (check_string_free_list): Convert to standard C.
2080
2081 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2082
2083 * w32.c (emacs_gnutls_push): Fix typo.
2084
2085 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2086
2087 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2088 "cast to pointer from integer of different size".
2089
2090 Improve doprnt and its use in verror. (Bug#8545)
2091 * doprnt.c (doprnt): Document the set of format control sequences
2092 supported by the function. Use SAFE_ALLOCA instead of always
2093 using `alloca'.
2094
2095 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2096 is one byte too soon. Don't use xrealloc; instead xfree and
2097 xmalloc anew.
2098
2099 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2100
2101 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2102 callbacks stage.
2103
2104 * gnutls.c: Renamed global_initialized to
2105 gnutls_global_initialized. Added internals for the
2106 :verify-hostname-error, :verify-error, and :verify-flags
2107 parameters of `gnutls-boot' and documented those parameters in the
2108 docstring. Start callback support.
2109 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2110 unless a fatal error occured. Call gnutls_alert_send_appropriate
2111 on error. Return error code.
2112 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2113 (emacs_gnutls_read): Likewise.
2114 (Fgnutls_boot): Return handshake error code.
2115 (emacs_gnutls_handle_error): New function.
2116 (wsaerror_to_errno): Likewise.
2117
2118 * w32.h (emacs_gnutls_pull): Add prototype.
2119 (emacs_gnutls_push): Likewise.
2120
2121 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2122 (emacs_gnutls_push): Likewise.
2123
2124 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2125
2126 * process.c (wait_reading_process_output): Check if GnuTLS
2127 buffered some data internally if no FDs are set for TLS
2128 connections.
2129
2130 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2131 (LIBS): Link to USER_LIBS.
2132 ($(BLD)/gnutls.$(0)): New target.
2133
2134 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (handle_single_display_spec): Rename the
2137 display_replaced_before_p argument into display_replaced_p, to
2138 make it consistent with the commentary. Fix typos in the
2139 commentary.
2140
2141 * textprop.c (syms_of_textprop): Remove dead code.
2142 (copy_text_properties): Delete obsolete commentary about an
2143 interface that was deleted long ago. Fix typos in the description
2144 of arguments.
2145
2146 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2147 to changes in oldXMenu/XMenu.h from 2011-04-16.
2148 <menu_help_message, prev_menu_help_message>: Constify.
2149 (IT_menu_make_room): menu->help_text is now `const char **';
2150 adjust.
2151
2152 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2153 to changes in oldXMenu/XMenu.h from 2011-04-16.
2154 (struct XMenu): Declare `help_text' `const char **'.
2155
2156 * xfaces.c <Qunspecified>: Make extern again.
2157
2158 * syntax.c: Include sys/types.h before including regex.h, as
2159 required by Posix.
2160
2161 * doc.c (get_doc_string): Improve the format passed to `error'.
2162
2163 * doprnt.c (doprnt): Improve commentary.
2164
2165 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2166
2167 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2168 them with etags.
2169
2170 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2171 changes in globals.h immediately force recompilation.
2172 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2173 $(CURDIR)/s/ms-w32.h.
2174 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2175
2176 * character.c (Fchar_direction): Function deleted.
2177 (syms_of_character): Don't defsubr it.
2178 <char-direction-table>: Deleted.
2179
2180 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2181
2182 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2183 * doprnt.c: Include limits.h.
2184 (SIZE_MAX): New macro.
2185 (doprnt): Return a size_t value. 2nd arg is now size_t.
2186 Many local variables are now size_t instead of int or unsigned.
2187 Improve overflow protection. Support `l' modifier for integer
2188 conversions. Support %l conversion. Don't assume an EMACS_INT
2189 argument for integer conversions and for %c.
2190
2191 * lisp.h (doprnt): Restore prototype.
2192
2193 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2194 $(SRC)/character.h.
2195
2196 * Makefile.in (base_obj): Add back doprnt.o.
2197
2198 * deps.mk (doprnt.o): Add back prerequisites.
2199 (callint.o): Depend on character.h.
2200
2201 * eval.c (internal_lisp_condition_case): Include the handler
2202 representation in the error message.
2203 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2204 when breaking from the loop.
2205
2206 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2207
2208 * callint.c (Fcall_interactively): When displaying error message
2209 about invalid control letter, pass the character's codepoint, not
2210 a pointer to its multibyte form. Improve display of the character
2211 in octal and display also its hex code.
2212
2213 * character.c (char_string): Use %x to display the (unsigned)
2214 codepoint of an invalid character, to avoid displaying a bogus
2215 negative value.
2216
2217 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2218 `error', not SYMBOL_NAME itself.
2219
2220 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2221 character arguments to `error'.
2222
2223 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2224 to `error' in error message about FINAL_CHAR argument. Make sure
2225 FINAL_CHAR is a character, and use %c when it is passed as
2226 argument to `error'.
2227
2228 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2229
2230 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2231
2232 * w32.c: Include <time.h>.
2233 (sys_localtime): New function.
2234
2235 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2236
2237 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2238
2239 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2240
2241 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2242
2243 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2244 zombies (Bug#8467).
2245
2246 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2247
2248 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2249 gl_state.e_property when gl_state.object is Qt.
2250
2251 * insdel.c (make_gap_larger): Remove limitation of buffer size
2252 to <= INT_MAX.
2253
2254 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2255
2256 * xdisp.c (lookup_glyphless_char_display)
2257 (produce_glyphless_glyph): Handle cons cell entry in
2258 glyphless-char-display.
2259 (Vglyphless_char_display): Document it.
2260
2261 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2262 glyphless-char-display.
2263
2264 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2265
2266 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2267
2268 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2269
2270 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2271 definition for no-X builds.
2272
2273 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 Static checks with GCC 4.6.0 and non-default toolkits.
2276
2277 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2278
2279 * process.c (keyboard_bit_set): Define only if SIGIO.
2280 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2281 (send_process): Repair possible setjmp clobbering.
2282
2283 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2284
2285 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2286
2287 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2288
2289 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2290 Define only if needed.
2291
2292 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2293 by pacifying GCC about it. Maybe it's time to retire it?
2294 * xfaces.c (USG, __TIMEVAL__): Likewise.
2295
2296 * dispextern.h (struct redisplay_interface): Rename param
2297 to avoid shadowing.
2298 * termhooks.h (struct terminal): Likewise.
2299 * xterm.c (xembed_send_message): Likewise.
2300
2301 * insdel.c (make_gap_smaller): Define only if
2302 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2303
2304 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2305 it.
2306
2307 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2308 so that we aren't warned about unused symbols.
2309
2310 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2311
2312 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2313
2314 * xfns.c (x_real_positions): Mark locals as initialized.
2315
2316 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2317
2318 * xterm.c: Fix problems found by static analysis with other toolkits.
2319 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2320 (x_dispatch_event): Declare static if USE_GTK, and
2321 define if USE_GTK || USE_X_TOOLKIT.
2322 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2323 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2324 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2325 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2326
2327 * xmenu.c (menu_help_callback): Pointer type fixes.
2328 Use const pointers when pointing at readonly data. Avoid pointer
2329 signedness clashes.
2330 (FALSE): Remove unused macro.
2331 (update_frame_menubar): Remove unused decl.
2332
2333 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2334
2335 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2336 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2337 (single_menu_item): Rename local to avoid shadowing.
2338
2339 * keyboard.c (make_lispy_event): Remove unused local var.
2340
2341 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2342 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2343
2344 * bitmaps: Change bitmaps from unsigned char back to the X11
2345 compatible char. Avoid the old compiler warnings about
2346 out-of-range initializers by using, for example, '\xab' rather
2347 than 0xab.
2348
2349 * xgselect.c (xgselect_initialize): Check vs interface
2350 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2351
2352 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2353
2354 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2355 to read-only memory.
2356
2357 * fns.c (vector): Remove; this old hack is no longer needed.
2358
2359 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2360 Remove unused var.
2361 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2362
2363 * xrdb.c (x_load_resources): Omit unused local.
2364
2365 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2366 (x_window): Rename locals to avoid shadowing.
2367 (USG): Use the kludged USG macro, to pacify gcc.
2368
2369 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2370 (x_term_init): Remove local to avoid shadowing.
2371
2372 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2373
2374 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2375 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2376
2377 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2378
2379 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2380
2381 Fix regex.c, syntax.c and friends for buffers > 2GB.
2382 * syntax.h (struct gl_state_s): Declare character position members
2383 EMACS_INT.
2384
2385 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2386
2387 * textprop.c (verify_interval_modification, interval_of):
2388 Declare arguments EMACS_INT.
2389
2390 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2391 EMACS_INT.
2392
2393 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2394
2395 * indent.c (Fvertical_motion): Local variable it_start is now
2396 EMACS_INT.
2397
2398 * regex.c (re_match, re_match_2, re_match_2_internal)
2399 (bcmp_translate, regcomp, regexec, print_double_string)
2400 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2401 (re_compile_pattern, re_exec): Declare arguments and local
2402 variables `size_t' and `ssize_t' and return values `regoff_t', as
2403 appropriate.
2404 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2405 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2406 <compile_stack_type>: `size' and `avail' are now `size_t'.
2407
2408 * regex.h <regoff_t>: Use ssize_t, not int.
2409 (re_search, re_search_2, re_match, re_match_2): Arguments that
2410 specify buffer/string position and length are now ssize_t and
2411 size_t. Return type is regoff_t.
2412
2413 2011-04-16 Ben Key <bkey76@gmail.com>
2414
2415 * nsfont.m: Fixed bugs in ns_get_family and
2416 ns_descriptor_to_entity that were caused by using free to
2417 deallocate memory blocks that were allocated by xmalloc (via
2418 xstrdup). This caused Emacs to crash when compiled with
2419 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2420 --enable-checking=xmallocoverrun). xfree is now used to
2421 deallocate these memory blocks.
2422
2423 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2426
2427 emacs_write: Accept and return EMACS_INT for sizes.
2428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2429 et seq.
2430 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2431 Accept and return EMACS_INT.
2432 (emacs_gnutls_write): Return the number of bytes written on
2433 partial writes.
2434 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2435 (emacs_read, emacs_write): Remove check for negative size, as the
2436 Emacs source code has been audited now.
2437 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2438 (emacs_read, emacs_write): Use it.
2439 * process.c (send_process): Adjust to the new signatures of
2440 emacs_write and emacs_gnutls_write. Do not attempt to store
2441 a byte offset into an 'int'; it might overflow.
2442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2443
2444 * sound.c: Don't assume sizes fit in 'int'.
2445 (struct sound_device.period_size, alsa_period_size):
2446 Return EMACS_INT, not int.
2447 (struct sound_device.write, vox_write, alsa_write):
2448 Accept EMACS_INT, not int.
2449 (wav_play, au_play): Use EMACS_INT to store sizes and to
2450 record read return values.
2451
2452 2011-04-15 Ben Key <bkey76@gmail.com>
2453
2454 * keyboard.c (Qundefined): Don't declare static since it is used
2455 in nsfns.m.
2456 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2457 static since they are used in nsfont.m.
2458
2459 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2460
2461 * process.c (Qprocessp): Don't declare static.
2462 * lisp.h (Qprocessp): Declare again.
2463
2464 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2467
2468 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 Improve C-level modularity by making more things 'static'.
2471
2472 Don't publish debugger-only interfaces to other modules.
2473 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2474 (verify_bytepos, count_markers): Move decls to the only modules
2475 that need them.
2476 * region-cache.h (pp_cache): Likewise.
2477 * window.h (check_all_windows): Likewise.
2478 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2479
2480 * sysdep.c (croak): Now static, if
2481 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2482 * syssignal.h (croak): Declare only if not static.
2483
2484 * alloc.c (refill_memory_reserve): Now static if
2485 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2486 * lisp.h (refill_memory_reserve): Declare only if not static.
2487
2488 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2489 Define only if USE_LUCID.
2490
2491 * xrdb.c (x_customization_string, x_rm_string): Now static.
2492
2493 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2494 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2495
2496 * xdisp.c (draw_row_with_mouse_face): Now static.
2497 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2498
2499 * window.h (check_all_windows): Mark externally visible.
2500
2501 * window.c (window_deletion_count): Now static.
2502
2503 * undo.c: Make symbols static if they're not exported.
2504 (last_undo_buffer, last_boundary_position, pending_boundary):
2505 Now static.
2506
2507 * textprop.c (interval_insert_behind_hooks): Now static.
2508 (interval_insert_in_front_hooks): Likewise.
2509
2510 * term.c: Make symbols static if they're not exported.
2511 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2512 (max_frame_lines, tty_set_terminal_modes):
2513 (tty_reset_terminal_modes, tty_turn_off_highlight):
2514 (get_tty_terminal): Now static.
2515 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2516 * termhooks.h (term_mouse_moveto): Do not declare if
2517 HAVE_WINDOW_SYSTEM.
2518 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2519 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2520
2521 * sysdep.c: Make symbols static if they're not exported.
2522 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2523 Now static.
2524 (sigprocmask_set, full_mask): Remove; unused.
2525 (wait_debugging): Mark as visible.
2526 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2527 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2528
2529 * syntax.c (syntax_temp): Define only if !__GNUC__.
2530
2531 * sound.c (current_sound_device, current_sound): Now static.
2532
2533 * search.c (searchbufs, searchbuf_head): Now static.
2534
2535 * scroll.c (scroll_cost): Remove; unused.
2536 * dispextern.h (scroll_cost): Remove decl.
2537
2538 * region-cache.h (pp_cache): Mark as externally visible.
2539
2540 * process.c: Make symbols static if they're not exported.
2541 (process_tick, update_tick, create_process, chan_process):
2542 (Vprocess_alist, proc_buffered_char, datagram_access):
2543 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2544 (deactivate_process): Mark defn as static, as well as decl.
2545 * lisp.h (create_process): Remove decl.
2546 * process.h (chan_process, Vprocess_alist): Remove decls.
2547
2548 * print.c: Make symbols static if they're not exported.
2549 (print_depth, new_backquote_output, being_printed, print_buffer):
2550 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2551 (print_interval, print_number_index, initial_stderr_stream):
2552 Now static.
2553 * lisp.h (Fprinc): Remove decl.
2554 (debug_output_compilation_hack): Mark as externally visible.
2555
2556 * sysdep.c (croak): Move decl from here to syssignal.h.
2557 * syssignal.h (croak): Put it here, so the API can be checked when
2558 'croak' is called from dissociate_if_controlling_tty.
2559
2560 * minibuf.c: Make symbols static if they're not exported.
2561 (minibuf_save_list, choose_minibuf_frame): Now static.
2562 * lisp.h (choose_minibuf_frame): Remove decl.
2563
2564 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2565
2566 * lread.c: Make symbols static if they're not exported.
2567 (read_objects, initial_obarray, oblookup_last_bucket_number):
2568 Now static.
2569 (make_symbol): Remove; unused.
2570 * lisp.h (initial_obarray, make_symbol): Remove decls.
2571
2572 * keyboard.c: Make symbols static if they're not exported.
2573 (single_kboard, recent_keys_index, total_keys, recent_keys):
2574 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2575 (this_single_command_key_start, echoing, last_auto_save):
2576 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2577 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2578 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2579 (Vlispy_mouse_stem, double_click_count):
2580 Now static.
2581 (force_auto_save_soon): Define only if SIGDANGER.
2582 (ignore_mouse_drag_p): Now static if
2583 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2584 (print_help): Remove; unused.
2585 (stop_character, last_timer_event): Mark as externally visible.
2586 * keyboard.h (ignore_mouse_drag_p): Declare only if
2587 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2588 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2589 * lisp.h (echoing): Remove decl.
2590 (force_auto_save_soon): Declare only if SIGDANGER.
2591 * xdisp.c (redisplay_window): Simplify code, to make it more
2592 obvious that ignore_mouse_drag_p is not accessed if !defined
2593 USE_GTK && !defined HAVE_NS.
2594
2595 * intervals.c: Make symbols static if they're not exported.
2596 (merge_properties_sticky, merge_interval_right, delete_interval):
2597 Now static.
2598 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2599
2600 * insdel.c: Make symbols static if they're not exported.
2601 However, leave prepare_to_modify_buffer alone. It's never
2602 called from outside this function, but that appears to be a bug.
2603 (combine_after_change_list, combine_after_change_buffer):
2604 (adjust_after_replace, signal_before_change): Now static.
2605 (adjust_after_replace_noundo): Remove; unused.
2606 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2607 (signal_before_change): Remove decls.
2608
2609 * indent.c (val_compute_motion, val_vmotion): Now static.
2610
2611 * image.c: Make symbols static if they're not exported.
2612 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2613 if USE_GTK.
2614 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2615 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2616
2617 * fringe.c (standard_bitmaps): Now static.
2618 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2619
2620 * frame.c: Make symbols static if they're not exported.
2621 (x_report_frame_params, make_terminal_frame): Now static.
2622 (get_frame_param): Now static, unless HAVE_NS.
2623 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2624 (x_get_resource_string): Remove; not used.
2625 * frame.h (make_terminal_frame, x_report_frame_params):
2626 (x_get_resource_string); Remove decls.
2627 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2628 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2629
2630 * font.c, fontset.c: Make symbols static if they're not exported.
2631 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2632 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2633 * font.c (font_close_object): Now static.
2634 * font.h (font_close_object): Remove.
2635 * fontset.c (FONTSET_OBJLIST): Remove.
2636 (free_realized_fontset) #if-0 the body, which does nothing.
2637 (face_suitable_for_char_p): #if-0, as it's never called.
2638 * fontset.h (face_suitable_for_char_p): Remove decl.
2639 * xfaces.c (face_at_string_position):
2640 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2641 since 0 is always ASCII.
2642
2643 * fns.c (weak_hash_tables): Now static.
2644
2645 * fileio.c: Make symbols static if they're not exported.
2646 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2647 (Vwrite_region_annotation_buffers): Now static.
2648
2649 * eval.c: Make symbols static if they're not exported.
2650 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2651 * lisp.h (backtrace_list): Remove decl.
2652
2653 * emacs.c: Make symbols static if they're not exported.
2654 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2655 (fatal_error_code, fatal_error_signal_hook, standard_args):
2656 Now static.
2657 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2658 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2659 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2660 * lisp.h (fatal_error_signal_hook): Remove decl.
2661 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2662
2663 * editfns.c: Move a (normally-unused) function to its only use.
2664 * editfns.c, lisp.h (get_operating_system_release): Remove.
2665 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2666 worth the hassle of breaking this out.
2667
2668 * xterm.c: Make symbols static if they're not exported.
2669 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2670 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2671 (x_destroy_window, x_delete_display):
2672 Now static.
2673 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2674 (x_mouse_leave): Remove; unused.
2675 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2676 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2677 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2678 Remove decls.
2679 (x_mouse_leave): Declare only if WINDOWSNT.
2680 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2681 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2682 USE_X_TOOLKIT.
2683
2684 * ftxfont.c: Make symbols static if they're not exported.
2685 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2686 HAVE_FREETYPE.
2687 * font.h (ftxfont_driver): Likewise.
2688
2689 * xfns.c: Make symbols static if they're not exported.
2690 (x_last_font_name, x_display_info_for_name):
2691 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2692 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2693 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2694 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2695 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2696 (last_show_tip_args): Now static.
2697 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2698 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2699 (x_screen_planes): Remove; unused.
2700 * dispextern.h (x_screen_planes): Remove decl.
2701
2702 * dispnew.c: Make symbols static if they're not exported.
2703 * dispextern.h (redraw_garbaged_frames, scrolling):
2704 (increment_row_positions): Remove.
2705 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2706 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2707 Now static.
2708 (redraw_garbaged_frames): Remove; unused.
2709
2710 * xfaces.c: Make symbols static if they're not exported.
2711 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2712 Remove decls.
2713 * xterm.h (defined_color): Remove decls.
2714 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2715 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2716 (menu_face_changed_default, defined_color, free_realized_face):
2717 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2718 (ascii_face_of_lisp_face): Remove; unused.
2719
2720 * xdisp.c: Make symbols static if they're not exported.
2721 * dispextern.h (scratch_glyph_row, window_box_edges):
2722 (glyph_to_pixel_coords, set_cursor_from_row):
2723 (get_next_display_element, set_iterator_to_next):
2724 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2725 (show_mouse_face): Remove decls
2726 * frame.h (message_buf_print): Likewise.
2727 * lisp.h (pop_message, set_message, check_point_in_composition):
2728 Likewise.
2729 * xterm.h (set_vertical_scroll_bar): Likewise.
2730 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2731 (message_buf_print, scratch_glyph_row, displayed_buffer):
2732 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2733 (get_next_display_element, show_mouse_face, window_box_edges):
2734 (frame_to_window_pixel_xy, check_point_in_composition):
2735 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2736 (glyph_to_pixel_coords): Remove; unused.
2737
2738 * dired.c (file_name_completion): Now static.
2739
2740 * dbusbind.c (xd_in_read_queued_messages): Now static.
2741
2742 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2743 * data.c (circular_list_error): Remove.
2744
2745 * commands.h (last_point_position, last_point_position_buffer):
2746 (last_point_position_window): Remove decls.
2747 * keyboard.c: Make these variables static.
2748
2749 * coding.h (coding, code_convert_region, encode_coding_gap):
2750 Remove decls.
2751 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2752 (iso_code_class, detect_coding, code_convert_region): Now static.
2753 (encode_coding_gap): Remove; unused.
2754
2755 * chartab.c (chartab_chars, chartab_bits): Now static.
2756
2757 * charset.h (charset_iso_8859_1): Remove decl.
2758 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2759 Now static.
2760
2761 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2762 * ccl.c (Vccl_program_table): Now static.
2763 (check_ccl_update): Remove; unused.
2764
2765 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2766 * category.h: ... from here.
2767 * category.c (check_category_table, set_category_set): Now static.
2768
2769 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2770 * lisp.h: Remove these decls.
2771
2772 * buffer.c (buffer_count): Remove unused var.
2773
2774 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2775 so that it's not optimized away.
2776 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2777 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2778 exported only to the debugger.
2779
2780 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2781 * atimer.h (run_all_atimers): Remove; not exported.
2782
2783 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2784 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2785 was inaccessible from Lisp.
2786 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2787 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2788
2789 alloc.c: Import and export fewer symbols, and remove unused items.
2790 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2791 is defined.
2792 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2793 it's not optimized away by whole-program optimization.
2794 (message_enable_multibyte, free_misc): Remove.
2795 (catchlist, handlerlist, mark_backtrace):
2796 Declare only if BYTE_MARK_STACK.
2797 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2798 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2799 (message_enable_multibyte): Remove decl.
2800 (free_misc, interval_free_list, float_block, float_block_index):
2801 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2802 (cons_free_list, last_marked_index):
2803 Now static.
2804 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2805 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2806 (mark_backtrace): Define only if BYTE_MARK_STACK.
2807 * xdisp.c (message_enable_multibyte): Now static.
2808
2809 Declare Lisp_Object Q* variables to be 'static' if not exported.
2810 This makes it easier for human readers (and static analyzers)
2811 to see whether these variables are used from other modules.
2812 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2813 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2814 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2815 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2816 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2817 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2818 * xmenu.c, xselect.c:
2819 Declare Q* vars static if they are not used in other modules.
2820 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2821 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2822 Remove decls of unexported vars.
2823 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2824
2825 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2826
2827 Make Emacs functions such as Fatom 'static' by default.
2828 This makes it easier for human readers (and static analyzers)
2829 to see whether these functions can be called from other modules.
2830 DEFUN now defines a static function. To make the function external
2831 so that it can be used in other C modules, use the new macro DEFUE.
2832 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2833 (Finit_image_library):
2834 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2835 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2836 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2837 Remove decls, since these functions are now static.
2838 (Funintern, Fget_internal_run_time): New decls, since these functions
2839 were already external.
2840
2841 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2842 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2843 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2844 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2845 * keyboard.c, keymap.c, lread.c:
2846 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2847 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2848 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2849 Mark functions with DEFUE instead of DEFUN,
2850 if they are used in other modules.
2851 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2852 decls for now-static functions.
2853 * buffer.h (Fdelete_overlay): Remove decl.
2854 * callproc.c (Fgetenv_internal): Mark as internal.
2855 * composite.c (Fremove_list_of_text_properties): Remove decl.
2856 (Fcomposition_get_gstring): New forward static decl.
2857 * composite.h (Fcomposite_get_gstring): Remove decl.
2858 * dired.c (Ffile_attributes): New forward static decl.
2859 * doc.c (Fdocumntation_property): New forward static decl.
2860 * eval.c (Ffetch_bytecode): New forward static decl.
2861 (Funintern): Remove extern decl; now in .h file where it belongs.
2862 * fileio.c (Fmake_symbolic_link): New forward static decl.
2863 * image.c (Finit_image_library): New forward static decl.
2864 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2865 * intervals.h (Fprevious_property_change):
2866 (Fremove_list_of_text_properties): Remove decls.
2867 * keyboard.c (Fthis_command_keys): Remove decl.
2868 (Fcommand_execute): New forward static decl.
2869 * keymap.c (Flookup_key): New forward static decl.
2870 (Fcopy_keymap): Now static.
2871 * keymap.h (Flookup_key): Remove decl.
2872 * process.c (Fget_process): New forward static decl.
2873 (Fprocess_datagram_address): Mark as internal.
2874 * syntax.c (Fsyntax_table_p): New forward static decl.
2875 (skip_chars): Remove duplicate decl.
2876 * textprop.c (Fprevious_property_change): New forward static decl.
2877 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2878 Now internal.
2879 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2880 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2881
2882 * editfns.c (Fformat): Remove unreachable code.
2883
2884 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2885
2886 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2887 change. (Bug#8496)
2888
2889 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2890
2891 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2892 when at ZV. (Bug#8487)
2893
2894 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2895
2896 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2897 (Bug#8437)
2898 * keyboard.c (parse_tool_bar_item): Likewise.
2899 * sound.c (sound_cleanup, alsa_close): Likewise.
2900 * termcap.c (tgetent): Likewise.
2901 * xfns.c (x_default_font_parameter): Likewise.
2902 * xsettings.c (read_and_apply_settings): Likewise.
2903
2904 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2905 (overrun_check_free): Protoize.
2906
2907 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2908
2909 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2910 since callers should never pass a negative size.
2911 Change the signature to match that of plain 'read' and 'write'; see
2912 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2913 * lisp.h: Update prototypes of emacs_write and emacs_read.
2914
2915 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2916
2917 * xdisp.c (redisplay_window): Don't try to determine the character
2918 position of the scroll margin if the window start point w->startp
2919 is outside the buffer's accessible region. (Bug#8468)
2920
2921 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2922
2923 Fix write-region and its subroutines for buffers > 2GB.
2924 * fileio.c (a_write, e_write): Modify declaration of arguments and
2925 local variables to support buffers larger than 2GB.
2926 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2927
2928 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2929 argument, local variables, and return value.
2930
2931 * lisp.h: Update prototypes of emacs_write and emacs_read.
2932
2933 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2934
2935 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2938
2939 Fix more problems found by GCC 4.6.0's static checks.
2940
2941 * xdisp.c (vmessage): Use a better test for character truncation.
2942
2943 * charset.c (load_charset_map): <, not <=, for optimization,
2944 and to avoid potential problems with integer overflow.
2945 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2946 * casetab.c (set_identity, shuffle): Likewise.
2947 * editfns.c (Fformat): Likewise.
2948 * syntax.c (skip_chars): Likewise.
2949
2950 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2951 This also lets GCC 4.6.0 generate slightly better loop code.
2952
2953 * callint.c (Fcall_interactively): <, not <=, for optimization.
2954 (Fcall_interactively): Count the number of arguments produced,
2955 not the number of arguments given. This is simpler and lets GCC
2956 4.6.0 generate slightly better code.
2957
2958 * ftfont.c: Distingish more carefully between FcChar8 and char.
2959 The previous code passed unsigned char * to a functions like
2960 strlen and xstrcasecmp that expect char *, which does not
2961 conform to the C standard.
2962 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2963 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2964 char * when the C standard requires it.
2965
2966 * keyboard.c (read_char): Remove unused var.
2967
2968 * eval.c: Port to Windows vsnprintf (Bug#8435).
2969 Include <limits.h>.
2970 (SIZE_MAX): Define if the headers do not.
2971 (verror): Do not give up if vsnprintf returns a negative count.
2972 Instead, grow the buffer. This ports to Windows vsnprintf, which
2973 does not conform to C99. Problem reported by Eli Zaretskii.
2974 Also, simplify the allocation scheme, by avoiding the need for
2975 calling realloc, and removing the ALLOCATED variable.
2976
2977 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2978
2979 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2980 But keep the doprint source code for now, as we might revamp it
2981 and use it again (Bug#8435).
2982 * lisp.h (doprnt): Remove.
2983 * Makefile.in (base_obj): Remove doprnt.o.
2984 * deps.mk (doprnt.o): Remove.
2985
2986 error: Print 32- and 64-bit integers portably (Bug#8435).
2987 Without this change, on typical 64-bit hosts error ("...%d...", N)
2988 was used to print both 32- and 64-bit integers N, which relied on
2989 undefined behavior.
2990 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2991 New macro.
2992 * lisp.h (error, verror): Mark as printf-like functions.
2993 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2994 Report overflow in size calculations when allocating printf buffer.
2995 Do not truncate output string at its first null byte.
2996 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2997 Truncate the output at a character boundary, since vsnprintf does not
2998 do that.
2999 * charset.c (check_iso_charset_parameter): Convert internal
3000 character to string before calling 'error', since %c now has the
3001 printf meaning.
3002 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3003 overflow when computing char to be passed to 'error'. Do not
3004 pass Lisp_Object to 'error'; pass the integer instead.
3005 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3006 formatted with plain %d.
3007
3008 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3009
3010 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3011
3012 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3013
3014 * xterm.c (x_catch_errors): Remove duplicate declaration.
3015
3016 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3017
3018 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3019
3020 2011-04-10 Jim Meyering <meyering@redhat.com>
3021
3022 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3023 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3024 return ssize_t not "int", and use size_t as the buffer length.
3025 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3026 * gnutls.h: Update declarations.
3027 * process.c (read_process_output): Use ssize_t, to match.
3028 (send_process): Likewise.
3029
3030 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3031
3032 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3033
3034 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3035
3036 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3037 Use unsigned char, to match FcChar8 type definition.
3038
3039 * xterm.c (handle_one_xevent):
3040 * xmenu.c (create_and_show_popup_menu):
3041 * xselect.c (x_decline_selection_request)
3042 (x_reply_selection_request): Avoid type-punned deref of X events.
3043
3044 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3045
3046 Fix some uses of `int' instead of EMACS_INT.
3047 * search.c (string_match_1, fast_string_match)
3048 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3049 (scan_buffer, find_next_newline_no_quit)
3050 (find_before_next_newline, search_command, Freplace_match)
3051 (Fmatch_data): Make some `int' variables be EMACS_INT.
3052
3053 * xdisp.c (display_count_lines): 3rd argument and return value now
3054 EMACS_INT. All callers changed.
3055 (pint2hrstr): Last argument is now EMACS_INT.
3056
3057 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3058 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3059 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3060 (decode_coding_utf_16, decode_coding_emacs_mule)
3061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3062 (decode_coding_ccl, decode_coding_charset)
3063 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3064 (decode_coding_iso_2022, decode_coding_emacs_mule)
3065 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3066 <char_offset, last_offset>: Declare EMACS_INT.
3067 (encode_coding_utf_8, encode_coding_utf_16)
3068 (encode_coding_emacs_mule, encode_invocation_designation)
3069 (encode_designation_at_bol, encode_coding_iso_2022)
3070 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3071 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3072 Declare EMACS_INT.
3073 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3074 (encode_invocation_designation): Last argument P_NCHARS is now
3075 EMACS_INT.
3076 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3077 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3078
3079 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3080 All users changed.
3081
3082 * ccl.c (Fccl_execute_on_string): Declare some variables
3083 EMACS_INT.
3084
3085 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3086
3087 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3088
3089 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3090
3091 * process.c (Fformat_network_address): Doc fix.
3092
3093 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3094
3095 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3096
3097 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3098
3099 * keyboard.c (read_char): Call Lisp function help-form-show,
3100 instead of using internal_with_output_to_temp_buffer.
3101 (Qhelp_form_show): New var.
3102 (syms_of_keyboard): Use DEFSYM macro.
3103
3104 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3105
3106 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3107
3108 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3109
3110 * process.c (Flist_processes): Remove to Lisp.
3111 (list_processes_1): Delete.
3112
3113 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3114
3115 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3116
3117 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3118
3119 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 Fix more problems found by GCC 4.6.0's static checks.
3122
3123 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3124
3125 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3126
3127 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3128
3129 * xdisp.c (vmessage): Mark as a printf-like function.
3130
3131 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3132
3133 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3134
3135 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3136 printf-like functions.
3137 (tiff_load): Add casts to remove these marks before passing them
3138 to system-supplied API.
3139
3140 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3141
3142 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3143 This avoids several warnings with gcc -Wstrict-overflow.
3144 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3145 directly, rather than having caller test rule sign. This avoids
3146 some unnecessary tests.
3147 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3148 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3149 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3150
3151 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3152 (xfont_open): Avoid unnecessary tests.
3153
3154 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3155
3156 * composite.h, composite.c (composition_gstring_put_cache):
3157 Use EMACS_INT, not int, for length.
3158
3159 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3160 breaking out part of COMPOSITION_DECODE_RULE.
3161 (COMPOSITION_DECODE_RULE): Use it.
3162 * composite.c (get_composition_id): Remove unused local vars,
3163 by using the new macro.
3164
3165 * textprop.c (set_text_properties_1): Change while to do-while,
3166 since the condition is always true at first.
3167
3168 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3169 (interval_deletion_adjustment): Return unsigned value.
3170 All uses changed.
3171
3172 * process.c (list_processes_1, create_pty, read_process_output):
3173 (exec_sentinel): Remove vars that were set but not used.
3174 (create_pty): Remove unnecessary "volatile"s.
3175 (Fnetwork_interface_info): Avoid possibility of int overflow.
3176 (read_process_output): Do adaptive read buffering even if carryover.
3177 (read_process_output): Simplify nbytes computation if buffered.
3178
3179 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3180
3181 * syntax.c (scan_words): Remove var that was set but not used.
3182 (update_syntax_table): Use unsigned instead of int.
3183
3184 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3185 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3186 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3187
3188 * print.c (print_error_message): Avoid int overflow.
3189
3190 * font.c (font_list_entities): Redo for clarity,
3191 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3192
3193 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3194 (font_score): Avoid potential overflow in diff calculation.
3195
3196 * fns.c (substring_both): Remove var that is set but not used.
3197 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3198
3199 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3200
3201 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3202 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3203 can always succeed if overflow has undefined behavior.
3204
3205 * search.c (boyer_moore, wordify): Remove vars set but not used.
3206 (wordify): Omit three unnecessary tests.
3207
3208 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3209 All callers changed. This avoids the need for an unused var.
3210
3211 * casefiddle.c (casify_region): Remove var that is set but not used.
3212
3213 * dired.c (file_name_completion): Remove var that is set but not used.
3214
3215 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3216
3217 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3218 (Finsert_file_contents): Remove unnecessary code checking fd.
3219
3220 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3221 Check for integer overflow on size calculations.
3222
3223 * buffer.c (Fprevious_overlay_change): Remove var that is set
3224 but not used.
3225
3226 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3227 Remove vars that are set but not used.
3228 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3229 (timer_check_2): Mark vars as initialized.
3230
3231 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3232
3233 * image.c (lookup_image): Remove var that is set but not used.
3234 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3235
3236 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3237 that are set but not used.
3238
3239 * xfns.c (make_invisible_cursor): Don't return garbage
3240 if XCreateBitmapFromData fails (Bug#8410).
3241
3242 * xselect.c (x_get_local_selection, x_handle_property_notify):
3243 Remove vars that are set but not used.
3244
3245 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3246 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3247
3248 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3249 Remove var that is set but not used.
3250 (scroll_bar_windows_size): Now size_t, not int.
3251 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3252 Check for overflow.
3253
3254 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3255 (map_tty_color) [!defined MSDOS]: Likewise.
3256
3257 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3258
3259 * coding.c: Remove vars that are set but not used.
3260 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3261 All callers changed.
3262 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3263 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3264 (decode_coding_charset): Remove vars that are set but not used.
3265
3266 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3267 that is set but not used.
3268
3269 * print.c (print_object): Remove var that is set but not used.
3270
3271 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3272 The gnulib version avoids calling malloc in the usual case,
3273 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3274 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3275 * filelock.c (current_lock_owner): Likewise.
3276 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3277 * sysdep.c: Include allocator.h, careadlinkat.h.
3278 (emacs_no_realloc_allocator): New static constant.
3279 (emacs_readlink): New function.
3280 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3281 ../lib/careadlinkat.h.
3282
3283 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3284
3285 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3286 first non-nil return value).
3287
3288 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3289
3290 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3291 if not defined (Bug#8403).
3292
3293 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3294
3295 * xdisp.c (display_count_lines): Remove parameter `start',
3296 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3297 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3298 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3299 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3300 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3301 and thereabouts. All callers changed.
3302 (get_per_char_metric): Remove parameter `f', unused since
3303 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3304
3305 2011-04-02 Jim Meyering <meyering@redhat.com>
3306
3307 do not dereference NULL upon failed strdup
3308 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3309 (ns_get_family): Likewise.
3310
3311 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3314
3315 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3318 later (Bug#8403).
3319
3320 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3321
3322 Add lexical binding.
3323
3324 * window.c (Ftemp_output_buffer_show): New fun.
3325 (Fsave_window_excursion):
3326 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3327
3328 * lread.c (lisp_file_lexically_bound_p): New function.
3329 (Fload): Bind Qlexical_binding.
3330 (readevalloop): Remove `evalfun' arg.
3331 Bind Qinternal_interpreter_environment.
3332 (Feval_buffer): Bind Qlexical_binding.
3333 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3334 Mark as dynamic.
3335 (syms_of_lread): Declare `lexical-binding'.
3336
3337 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3338
3339 * keyboard.c (eval_dyn): New fun.
3340 (menu_item_eval_property): Use it.
3341
3342 * image.c (parse_image_spec): Use Ffunctionp.
3343
3344 * fns.c (concat, mapcar1): Accept byte-code-functions.
3345
3346 * eval.c (Fsetq): Handle lexical vars.
3347 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3348 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3349 (FletX, Flet): Obey lexical binding.
3350 (Fcommandp): Handle closures.
3351 (Feval): New `lexical' arg.
3352 (eval_sub): New function extracted from Feval. Use it almost
3353 everywhere where Feval was used. Look up vars in lexical env.
3354 Handle closures.
3355 (Ffunctionp): Move from subr.el.
3356 (Ffuncall): Handle closures.
3357 (apply_lambda): Remove `eval_flags'.
3358 (funcall_lambda): Handle closures and new byte-code-functions.
3359 (Fspecial_variable_p): New function.
3360 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3361 but without exporting it to Lisp.
3362
3363 * doc.c (Fdocumentation, store_function_docstring):
3364 * data.c (Finteractive_form): Handle closures.
3365
3366 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3367 interactive spec.
3368
3369 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3370 New byte-codes.
3371 (exec_byte_code): New function extracted from Fbyte_code to handle new
3372 calling convention for byte-code-functions. Add new byte-codes.
3373
3374 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3375
3376 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3377
3378 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3379
3380 * xdisp.c (redisplay_internal): Fix prototype.
3381
3382 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3383
3384 * xdisp.c (SCROLL_LIMIT): New macro.
3385 (try_scrolling): Use it when setting scroll_limit.
3386 Limit scrolling to 100 screen lines.
3387 (redisplay_window): Even when falling back on "recentering",
3388 position point in the window according to scroll-conservatively,
3389 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3390
3391 (try_scrolling): When point is above the window, allow searching
3392 as far as scroll_max, or one screenful, to compute vertical
3393 distance from PT to the scroll margin position. This prevents
3394 try_scrolling from unnecessarily failing when
3395 scroll-conservatively is set to a value slightly larger than the
3396 window height. Clean up the case of PT below the margin at bottom
3397 of window: scroll_max can no longer be INT_MAX. When aggressive
3398 scrolling is in use, don't let point enter the opposite scroll
3399 margin as result of the scroll.
3400 (syms_of_xdisp) <scroll-conservatively>: Document the
3401 threshold of 100 lines for never-recentering scrolling.
3402
3403 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * dispextern.h (move_it_by_lines):
3406 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3407 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3408 (message_log_check_duplicate): Remove parameters `prev_bol' and
3409 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3410 (redisplay_internal): Remove parameter `preserve_echo_area',
3411 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3412
3413 * indent.c (Fvertical_motion):
3414 * window.c (window_scroll_pixel_based, Frecenter):
3415 Don't pass `need_y_p' to `move_it_by_lines'.
3416
3417 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3418
3419 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3420 steal a few bits to be more compact.
3421 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3422 Remove unneeded casts.
3423
3424 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3425
3426 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3427
3428 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3429 binding" message (bug#7967).
3430
3431 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 Fix more problems found by GCC 4.6.0's static checks.
3434
3435 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3436 Remove unused local var.
3437
3438 * editfns.c (Fmessage_box): Remove unused local var.
3439
3440 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3441 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3442 Omit unused local vars.
3443 * window.c (shrink_windows): Omit unused local var.
3444 * menu.c (digest_single_submenu): Omit unused local var.
3445 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3446 Omit unused local var.
3447
3448 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3449 Don't assume string length fits in int.
3450 (keyremap_step, read_key_sequence): Use size_t for sizes.
3451 (read_key_sequence): Don't check last_real_key_start redundantly.
3452
3453 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3454 instead of alloca (Bug#8344).
3455
3456 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3457 (Fbacktrace_frame): Don't assume nframes fits in int.
3458
3459 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3460
3461 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3462 concerns.
3463
3464 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3465
3466 * cm.c (calccost): Turn while-do into do-while, for clarity.
3467
3468 * keyboard.c (syms_of_keyboard): Use the same style as later
3469 in this function when indexing through an array. This also
3470 works around GCC bug 48267.
3471
3472 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3473
3474 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3475
3476 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3477 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3478
3479 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3480 This avoids undefined behavior on integer overflow, and is a bit
3481 more convenient anyway since it is compared to a size_t variable.
3482
3483 Variadic C functions now count arguments with size_t, not int.
3484 This avoids an unnecessary limitation on 64-bit machines, which
3485 caused (substring ...) to crash on large vectors (Bug#8344).
3486 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3487 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3488 All variadic functions and their callers changed accordingly.
3489 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3490 * data.c (arith_driver, float_arith_driver): Likewise.
3491 * editfns.c (general_insert_function): Likewise.
3492 * eval.c (struct backtrace.nargs, interactive_p)
3493 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3494 (funcall_lambda, mark_backtrace): Likewise.
3495 * fns.c (concat): Likewise.
3496 * frame.c (x_set_frame_parameters): Likewise.
3497 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3498 0 if not found, not -1. All callers changed.
3499
3500 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3501 (stack_copy_size): Now size_t, not int.
3502 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3503
3504 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3507 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3508 All callers changed.
3509
3510 * lisp.h (multibyte_char_to_unibyte):
3511 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3512 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3513 * character.h (CHAR_TO_BYTE8):
3514 * cmds.c (internal_self_insert):
3515 * editfns.c (general_insert_function):
3516 * keymap.c (push_key_description):
3517 * search.c (Freplace_match):
3518 * xdisp.c (message_dolog, set_message_1): All callers changed.
3519
3520 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * keyboard.c (safe_run_hook_funcall): New function.
3523 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3524 don't set the hook to nil, but remove the offending function instead.
3525 (Qcommand_hook_internal): Remove, unused.
3526 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3527 Vcommand_hook_internal.
3528
3529 * eval.c (enum run_hooks_condition): Remove.
3530 (funcall_nil, funcall_not): New functions.
3531 (run_hook_with_args): Call each function through a `funcall' argument.
3532 Remove `cond' argument, now redundant.
3533 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3534 (Frun_hook_with_args_until_failure): Adjust accordingly.
3535 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3536
3537 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3538
3539 * dispextern.h (string_buffer_position): Remove declaration.
3540
3541 * print.c (strout): Remove parameter `multibyte', unused since
3542 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3543
3544 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3545 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3546 All callers changed.
3547
3548 * w32.c (_wsa_errlist): Use braces for struct initializers.
3549
3550 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3551 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3552 All callers changed.
3553 (string_buffer_position): Likewise. Also, make static (it's never
3554 used outside xdisp.c).
3555 (cursor_row_p): Remove parameter `w', unused since
3556 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3557 (decode_mode_spec): Remove parameter `precision', introduced during
3558 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3559 All callers changed.
3560
3561 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3562
3563 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3564
3565 2011-03-27 Anders Lindgren <andlind@gmail.com>
3566
3567 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3568 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3569 (ns_update_auto_hide_menu_bar): New functions.
3570 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3571 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3572 ns_constrain_all_frames.
3573 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3574 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3575
3576 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3577
3578 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3579
3580 2011-03-27 Glenn Morris <rgm@gnu.org>
3581
3582 * syssignal.h: Replace RETSIGTYPE with void.
3583 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3584 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3585 Replace SIGTYPE with void everywhere.
3586 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3587 * s/template.h (SIGTYPE): Remove commented out definition.
3588
3589 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3590
3591 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3592 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3593
3594 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * w32.c (read_unc_volume): Use parameter `henum', instead of
3597 global variable `wget_enum_handle'.
3598
3599 * keymap.c (describe_vector): Remove parameters `indices' and
3600 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3601 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3602
3603 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3604
3605 * keyboard.c (timer_check): Remove parameter `do_it_now',
3606 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3607 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3608 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3609
3610 * keyboard.c (read_char):
3611 * w32menu.c (w32_menu_display_help):
3612 * xmenu.c (show_help_event, menu_help_callback):
3613 Adjust calls to `show_help_echo'.
3614
3615 * gtkutil.c (xg_maybe_add_timer):
3616 * keyboard.c (readable_events):
3617 * process.c (wait_reading_process_output):
3618 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3619
3620 * insdel.c (adjust_markers_gap_motion):
3621 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3622 (gap_left, gap_right): Don't call it.
3623
3624 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3627 incurred during fontification.
3628
3629 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3632 (DEFVAR_PER_BUFFER): Don't pass it.
3633
3634 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3635 (scrolling_window): Don't pass it.
3636
3637 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3638
3639 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3640
3641 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3642 and `suffix'.
3643 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3644 of variables specific to SELinux and computation of `encoded_absname'.
3645
3646 * image.c (XPutPixel): Remove unused variable `height'.
3647
3648 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3649
3650 * unexw32.c (get_section_info): Remove unused variable `section'.
3651
3652 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3653 (system_process_attributes): Remove unused variable `sess'.
3654 (sys_read): Remove unused variable `err'.
3655
3656 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3657 (w32_wnd_proc): Remove unused variable `isdead'.
3658 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3659 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3660 (x_create_tip_frame): Remove unused variable `tem'.
3661
3662 * w32inevt.c (w32_console_read_socket):
3663 Remove unused variable `no_events'.
3664
3665 * w32term.c (x_draw_composite_glyph_string_foreground):
3666 Remove unused variable `width'.
3667
3668 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * w32term.c (x_set_glyph_string_clipping):
3671 Don't pass uninitialized region to CombineRgn.
3672
3673 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3674
3675 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3676 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3677 (Fx_close_connection): Remove unused variable `i'.
3678
3679 * w32font.c (w32font_draw): Return number of glyphs.
3680 (w32font_open_internal): Remove unused variable `i'.
3681 (w32font_driver): Add missing initializer.
3682
3683 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3684 (fill_in_menu): Remove unused variable `items_added'.
3685
3686 * w32term.c (last_mouse_press_frame): Remove static global variable.
3687 (w32_clip_to_row): Remove unused variable `f'.
3688 (x_delete_terminal): Remove unused variable `i'.
3689
3690 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3691 (NOTHING): Remove unused static global variable.
3692 (uniscribe_check_otf): Remove unused variable `table'.
3693 (uniscribe_font_driver): Add missing initializers.
3694
3695 2011-03-23 Julien Danjou <julien@danjou.info>
3696
3697 * term.c (Fsuspend_tty, Fresume_tty):
3698 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3699 * window.c (temp_output_buffer_show):
3700 * insdel.c (signal_before_change):
3701 * frame.c (Fhandle_switch_frame):
3702 * fileio.c (Fdo_auto_save):
3703 * emacs.c (Fkill_emacs):
3704 * editfns.c (save_excursion_restore):
3705 * cmds.c (internal_self_insert):
3706 * callint.c (Fcall_interactively):
3707 * buffer.c (Fkill_all_local_variables):
3708 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3709 Use Frun_hooks.
3710 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3711 unconditionnaly since it does the check itself.
3712
3713 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 Fix more problems found by GCC 4.5.2's static checks.
3716
3717 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3718 the first time through the loop, since we know p0 < p1 then.
3719 This also avoids a gcc -Wstrict-overflow warning.
3720
3721 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3722 leading to a memory leak, possible in functions like
3723 load_charset_map_from_file that can allocate an unbounded number
3724 of objects (Bug#8318).
3725
3726 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3727 that could (at least in theory) be that large.
3728
3729 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3730 This is less likely to overflow, and avoids undefined behavior if
3731 overflow does occur. All callers changed. Use strtoul to scan
3732 for the unsigned long integer.
3733 (pint2hrstr): Simplify and tune code slightly.
3734 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3735
3736 * scroll.c (do_scrolling): Work around GCC bug 48228.
3737 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3738
3739 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3740 This also avoids a warning with gcc -Wstrict-overflow.
3741 (validate_x_resource_name): Simplify count usage.
3742 This also avoids a warning with gcc -Wstrict-overflow.
3743
3744 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3745 fail (Bug#8306).
3746
3747 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3748
3749 * process.c (Fmake_network_process): Use socklen_t, not int,
3750 where POSIX says socklen_t is required in portable programs.
3751 This fixes a porting bug on hosts like 64-bit HP-UX, where
3752 socklen_t is wider than int (Bug#8277).
3753 (Fmake_network_process, server_accept_connection):
3754 (wait_reading_process_output, read_process_output):
3755 Likewise.
3756
3757 * process.c: Rename or move locals to avoid shadowing.
3758 (list_processes_1, Fmake_network_process):
3759 (read_process_output_error_handler, exec_sentinel_error_handler):
3760 Rename or move locals.
3761 (Fmake_network_process): Define label "retry_connect" only if needed.
3762 (Fnetwork_interface_info): Fix pointer signedness.
3763 (process_send_signal): Add cast to avoid pointer signedness problem.
3764 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3765 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3766
3767 Make tparam.h and terminfo.c consistent.
3768 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3769 Include tparam.h instead, since it declares them.
3770 * cm.h (PC): Remove extern decl; tparam.h now does this.
3771 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3772 * terminfo.c: Include tparam.h, to check interfaces.
3773 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3774 (tparam): Adjust signature to match interface in tparam.h;
3775 this removes some undefined behavior. Check that outstring and len
3776 are zero, which they always are with Emacs.
3777 * tparam.h (PC, BC, UP): New extern decls.
3778
3779 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3780 (xftfont_open): Rename locals to avoid shadowing.
3781
3782 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3783 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3784 (OTF_TAG_SYM): Omit macro if not needed.
3785 (ftfont_list): Remove unused local.
3786 (get_adstyle_property, ftfont_pattern_entity):
3787 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3788 Rename locals to avoid shadowing.
3789
3790 * xfont.c (xfont_list_family): Mark var as initialized.
3791
3792 * xml.c (make_dom): Now static.
3793
3794 * composite.c (composition_compute_stop_pos): Rename local to
3795 avoid shadowing.
3796 (composition_reseat_it): Remove unused locals.
3797 (find_automatic_composition, composition_adjust_point): Likewise.
3798 (composition_update_it): Mark var as initialized.
3799 (find_automatic_composition): Mark vars as initialized,
3800 with a FIXME (Bug#8290).
3801
3802 character.h: Rename locals to avoid shadowing.
3803 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3804 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3805 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3806 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3807 to avoid shadowing.
3808
3809 * textprop.c (property_change_between_p): Remove; unused.
3810
3811 * intervals.c (interval_start_pos): Now static.
3812
3813 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3814
3815 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3816 Rename locals to avoid shadowing.
3817
3818 * sound.c (wav_play, au_play, Fplay_sound_internal):
3819 Fix pointer signedness.
3820 (alsa_choose_format): Remove unused local var.
3821 (wav_play): Initialize a variable to 0, to prevent undefined
3822 behavior (Bug#8278).
3823
3824 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3825
3826 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3827
3828 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3829 clobbering (Bug#8298).
3830 * sysdep.c (sys_subshell): Likewise.
3831 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3832
3833 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3834 This should get cleaned up, so that child_setup has the
3835 same signature on all platforms.
3836
3837 * callproc.c (call_process_cleanup): Now static.
3838 (relocate_fd): Rename locals to avoid shadowing.
3839
3840 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3841
3842 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3843 not to be necessary, and produces flickering.
3844
3845 2011-03-20 Glenn Morris <rgm@gnu.org>
3846
3847 * config.in: Remove file.
3848
3849 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3850
3851 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3852 are now in src/globals.h.
3853 (syms_of_minibuf): Remove spurious & from previous change.
3854
3855 2011-03-20 Leo <sdl.web@gmail.com>
3856
3857 * minibuf.c (completing-read-function): New variable.
3858 (completing-read-default): Rename from completing-read.
3859 (completing-read): Call completing-read-function.
3860
3861 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3862
3863 * xfaces.c (Fx_load_color_file):
3864 Read color file from absolute filename (bug#8250).
3865
3866 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3867
3868 * makefile.w32-in: Update dependencies.
3869
3870 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3871
3872 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3873
3874 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Fix more problems found by GCC 4.5.2's static checks.
3877
3878 * process.c (make_serial_process_unwind, send_process_trap):
3879 (sigchld_handler): Now static.
3880
3881 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3882 That way, the code declares only the vars that it needs.
3883 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3884 * s/cygwin.h (PTY_ITERATION): Likewise.
3885 * s/darwin.h (PTY_ITERATION): Likewise.
3886 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3887
3888 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3889 * process.c (allocate_pty): Don't declare stb unless it's needed.
3890
3891 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3892 (CONSTANTLIM): Remove; unused.
3893 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3894 Define only if needed.
3895
3896 * unexelf.c (unexec): Name an expression,
3897 to avoid gcc -Wbad-function-cast warning.
3898 Use a different way to cause a compilation error if anyone uses
3899 n rather than nn, a way that does not involve shadowing.
3900 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3901
3902 * deps.mk (unexalpha.o): Remove; unused.
3903
3904 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3905 * unexec.h: New file.
3906 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3907 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3908 Depend on unexec.h.
3909 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3910 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3911 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3912 Change as necessary to match prototype in unexec.h.
3913
3914 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3915 shadowing.
3916 (back_comment, skip_chars): Mark vars as initialized.
3917
3918 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3919 Rename locals to avoid shadowing.
3920
3921 * lread.c (read1): Rewrite so as not to use empty "else".
3922 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3923
3924 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3925
3926 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3927 warning when compiling print.c.
3928
3929 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3930 instead of using an uninitialized var.
3931 (font_sort_entities): Mark var as initialized.
3932
3933 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3934
3935 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3936 pointers to constants.
3937 (font_parse_fcname): Remove unused vars.
3938 (font_delete_unmatched): Now static.
3939 (font_get_spec): Remove; unused.
3940 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3941 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3942 Rename or move locals to avoid shadowing.
3943
3944 * fns.c (require_nesting_list, require_unwind): Now static.
3945 (Ffillarray): Rename locals to avoid shadowing.
3946
3947 * floatfns.c (domain_error2): Define only if needed.
3948 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3949
3950 * alloc.c (mark_backtrace): Move decl from here ...
3951 * lisp.h: ... to here, so that it can be checked.
3952
3953 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3954 (Fdefvar): Rewrite so as not to use empty "else".
3955 (lisp_indirect_variable): Name an expression,
3956 to avoid gcc -Wbad-function-cast warning.
3957 (Fdefvar): Rename locals to avoid shadowing.
3958
3959 * callint.c (quotify_arg, quotify_args): Now static.
3960 (Fcall_interactively): Rename locals to avoid shadowing.
3961 Use const pointer when appropriate.
3962
3963 * lisp.h (get_system_name, get_operating_system_release):
3964 Move decls here, to check interfaces.
3965 * process.c (get_operating_system_release): Move decl to lisp.h.
3966 * xrdb.c (get_system_name): Likewise.
3967 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3968 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3969 some of which prompt warnings from gcc -Wbad-function-cast.
3970 (Fformat_time_string, Fencode_time, Finsert_char):
3971 (Ftranslate_region_internal, Fformat):
3972 Rename or remove local vars to avoid shadowing.
3973 (Ftranslate_region_internal): Mark var as initialized.
3974
3975 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3976 avoid shadowing.
3977
3978 * lisp.h (eassert): Check that the argument compiles, even if
3979 ENABLE_CHECKING is not defined.
3980
3981 * data.c (Findirect_variable): Name an expression, to avoid
3982 gcc -Wbad-function-cast warning.
3983 (default_value, arithcompare, arith_driver, arith_error): Now static.
3984 (store_symval_forwarding): Rename local to avoid shadowing.
3985 (Fmake_variable_buffer_local, Fmake_local_variable):
3986 Mark variables as initialized.
3987 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3988
3989 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3990 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3991 Rename locals to avoid shadowing.
3992 (mark_stack): Move local variables into the #ifdef region where
3993 they're used.
3994 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3995 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3996 needed otherwise.
3997 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3998 (GC_STRING_CHARS): Remove; not used.
3999 (Fmemory_limit): Cast sbrk's returned value to char *.
4000
4001 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4002 avoids undefined behavior in theory.
4003
4004 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4005
4006 Use functions, not macros, for up- and down-casing (Bug#8254).
4007 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4008 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4009 to use the following functions instead of these macros.
4010 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4011 EMACS_INT, since callers assume the returned value fits in int.
4012 (upcase1): Likewise, for UPCASE_TABLE.
4013 (uppercasep, lowercasep, upcase): New static inline functions.
4014 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4015 the race-condition problem in the old DOWNCASE.
4016
4017 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4018 Rename locals to avoid shadowing.
4019 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4020 (regex_compile, re_search_2, re_match_2_internal):
4021 Remove unused local vars.
4022 (FREE_VAR): Rewrite so as not to use empty "else",
4023 which gcc can warn about.
4024 (regex_compile, re_match_2_internal): Mark locals as initialized.
4025 (RETALLOC_IF): Define only if needed.
4026 (WORDCHAR_P): Likewise. This one is never needed, but is used
4027 only in a comment talking about a compiler bug, so put inside
4028 the #if 0 of that comment.
4029 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4030 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4031 Remove; unused.
4032
4033 * search.c (boyer_moore): Rename locals to avoid shadowing.
4034 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4035 (PREV_CHAR_BOUNDARY): Likewise.
4036
4037 * search.c (simple_search): Remove unused var.
4038
4039 * dired.c (compile_pattern): Move decl from here ...
4040 * lisp.h: ... to here, so that it can be checked.
4041 (struct re_registers): New forward decl.
4042
4043 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4044
4045 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4046 All uses changed.
4047 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4048 Rename locals to avoid shadowing.
4049 (Fvertical_motion): Mark locals as initialized.
4050
4051 * casefiddle.c (casify_object, casify_region): Now static.
4052 (casify_region): Mark local as initialized.
4053
4054 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4055
4056 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4057 New macros, so that the caller can use some names other than
4058 gcpro1, gcpro2, etc.
4059 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4060 of the new macros.
4061 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4062 argument, for consistency with GCPRO2_VAR, etc: it is now the
4063 prefix of the variable, not the variable itself. All uses
4064 changed.
4065 * dired.c (directory_files_internal, file_name_completion):
4066 Rename locals to avoid shadowing.
4067
4068 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4069 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4070 dired.c's scmp function, had undefined behavior.
4071 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4072 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4073 * buffer.h: ... to here, because these macros use current_buffer,
4074 and the new implementation with inline functions needs to have
4075 current_buffer in scope now, rather than later when the macros
4076 are used.
4077 (downcase, upcase1): New static inline functions.
4078 (DOWNCASE, UPCASE1): Reimplement using these functions.
4079 This avoids undefined behavior in expressions like
4080 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4081 from race conditions in accessing the global variables
4082 case_temp1 and case_temp2.
4083 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4084 * lisp.h (case_temp1, case_temp2): Remove their decls.
4085 * character.h (ASCII_CHAR_P): Move from here ...
4086 * lisp.h: ... to here, so that the inline functions mentioned
4087 above can use them.
4088
4089 * dired.c (directory_files_internal_unwind): Now static.
4090
4091 * fileio.c (file_name_as_directory, directory_file_name):
4092 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4093 Now static.
4094 (file_name_as_directory): Use const pointers when appropriate.
4095 (Fexpand_file_name): Likewise. In particular, newdir might
4096 point at constant storage, so make it a const pointer.
4097 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4098 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4099 signedness issues.
4100 (Fset_file_times, Finsert_file_contents, auto_save_error):
4101 Rename locals to avoid shadowing.
4102
4103 * minibuf.c (choose_minibuf_frame_1): Now static.
4104 (Ftry_completion, Fall_completions): Rename or remove locals
4105 to avoid shadowing.
4106
4107 * marker.c (bytepos_to_charpos): Remove; unused.
4108
4109 * lisp.h (verify_bytepos, count_markers): New decls,
4110 so that gcc does not warn that these functions aren't declared.
4111
4112 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4113 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4114 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4115 (copy_text): Remove unused local var.
4116
4117 * filelock.c (within_one_second): Now static.
4118 (lock_file_1): Rename local to avoid shadowing.
4119
4120 * buffer.c (fix_overlays_before): Mark locals as initialized.
4121 (fix_start_end_in_overlays): Likewise. This function should be
4122 simplified by using pointers-to-pointers, but that's a different
4123 matter.
4124 (switch_to_buffer_1): Now static.
4125 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4126 (report_overlay_modification): Rename locals to avoid shadowing.
4127
4128 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4129 Fix pointer signedness issue.
4130 (sys_subshell): Mark local as volatile if checking for lint,
4131 to suppress a gcc -Wclobbered warning that does not seem to be right.
4132 (MAXPATHLEN): Define only if needed.
4133
4134 * process.c (serial_open, serial_configure): Move decls from here ...
4135 * systty.h: ... to here, so that they can be checked.
4136
4137 * fns.c (get_random, seed_random): Move extern decls from here ...
4138 * lisp.h: ... to here, so that they can be checked.
4139
4140 * sysdep.c (reset_io): Now static.
4141 (wait_for_termination_signal): Remove; unused.
4142
4143 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4144 (copy_keymap_item, append_key, push_text_char_description):
4145 Now static.
4146 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4147 (DENSE_TABLE_SIZE): Remove; unused.
4148 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4149 (describe_map_tree):
4150 Rename locals to avoid shadowing.
4151
4152 * keyboard.c: Declare functions static if they are not used elsewhere.
4153 (echo_char, echo_dash, cmd_error, top_level_2):
4154 (poll_for_input, handle_async_input): Now static.
4155 (read_char, kbd_buffer_get_event, make_lispy_position):
4156 (make_lispy_event, make_lispy_movement, apply_modifiers):
4157 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4158 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4159 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4160 (read_key_sequence, read_char): Mark locals as initialized.
4161 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4162
4163 * keyboard.h (make_ctrl_char): New decl.
4164 (mark_kboards): Move decl here ...
4165 * alloc.c (mark_kboards): ... from here.
4166
4167 * lisp.h (force_auto_save_soon): New decl.
4168
4169 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4170 (DEFINE_DUMMY_FUNCTION): New macro.
4171 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4172 Use it.
4173 (main): Add casts to avoid warnings
4174 if GCC considers string literals to be constants.
4175
4176 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4177
4178 * dbusbind.c: Pointer signedness fixes.
4179 (xd_signature, xd_append_arg, xd_initialize):
4180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4181 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4182 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4183 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4184
4185 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4186 if GCC considers string literals to be constants.
4187 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4188
4189 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4192 (print_preprocess, print_object): New macro to fix last change.
4193
4194 * print.c (print_preprocess): Don't forget font objects.
4195
4196 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4197
4198 * emacs.c (USAGE3): Doc fixes.
4199
4200 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4201
4202 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4203 structure.
4204
4205 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4206
4207 * lisp.h (VWindow_system, Qfile_name_history):
4208 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4209 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4210 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4211
4212 * w32select.c: Don't #include "keyboard.h".
4213 (run_protected): Add extern declaration for waiting_for_input.
4214
4215 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4216 * w32console.c (detect_input_pending, read_input_pending)
4217 (encode_terminal_code):
4218 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4219 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4220 (w32_system_caret_y, Qfile_name_history):
4221 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4222 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4223 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4224 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4225 * w32proc.c (Qlocal, report_file_error):
4226 * w32term.c (Vwindow_system, updating_frame):
4227 * w32uniscribe.c (initialized, uniscribe_font_driver):
4228 Remove unneeded extern declarations.
4229
4230 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4231
4232 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4233
4234 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4235
4236 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4237 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4238 These macros can no longer be used for assignment.
4239
4240 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4241 Assign struct members directly, instead of using BUF_BEGV etc.
4242 (record_buffer_markers, fetch_buffer_markers): New functions for
4243 recording and fetching special buffer markers.
4244 (set_buffer_internal_1, set_buffer_temp): Use them.
4245
4246 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4247
4248 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4249
4250 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4251 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4252
4253 * xdisp.c (hscroll_window_tree):
4254 (reconsider_clip_changes): Use PT instead of BUF_PT.
4255
4256 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4257
4258 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4259 $(EMACS_ROOT)/lib/intprops.h.
4260
4261 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 Fix more problems found by GCC 4.5.2's static checks.
4264
4265 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4266 to unsigned char * to avoid compiler diagnostic.
4267 (xg_free_frame_widgets): Make it clear that a local variable is
4268 needed only if USE_GTK_TOOLTIP.
4269 (gdk_window_get_screen): Make it clear that this macro is needed
4270 only if USE_GTK_TOOLTIP.
4271 (int_gtk_range_get_value): New function, which avoids a diagnostic
4272 from gcc -Wbad-function-cast.
4273 (xg_set_toolkit_scroll_bar_thumb): Use it.
4274 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4275 diagnostic from gcc -Wbad-function-cast.
4276 (get_utf8_string, xg_get_file_with_chooser):
4277 Rename locals to avoid shadowing.
4278 (create_dialog): Move locals to avoid shadowing.
4279
4280 * xgselect.c (xg_select): Remove unused var.
4281
4282 * image.c (four_corners_best): Mark locals as initialized.
4283 (gif_load): Initialize transparent_p to zero (Bug#8238).
4284 Mark another local as initialized.
4285 (my_png_error, my_error_exit): Mark with NO_RETURN.
4286
4287 * image.c (clear_image_cache): Now static.
4288 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4289 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4290 (x_edge_detection): Remove unnecessary cast that
4291 gcc -Wbad-function-cast diagnoses.
4292 (gif_load): Fix pointer signedness.
4293 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4294 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4295
4296 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 Improve quality of tests for time stamp overflow.
4299 For example, without this patch (encode-time 0 0 0 1 1
4300 1152921504606846976) returns the obviously-bogus value (-948597
4301 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4302 reports time overflow. See
4303 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4304 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4305 * editfns.c: Include limits.h and intprops.h.
4306 (TIME_T_MIN, TIME_T_MAX): New macros.
4307 (time_overflow): Move earlier, to before first use.
4308 (hi_time, lo_time): New functions, for an accurate test for
4309 out-of-range times.
4310 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4311 (Fget_internal_run_time): Don't assume time_t fits in int.
4312 (make_time): Use list2 instead of Fcons twice.
4313 (Fdecode_time): More accurate test for out-of-range times.
4314 (check_tm_member): New function.
4315 (Fencode_time): Use it, to test for out-of-range times.
4316 (lisp_time_argument): Don't rely on undefined left-shift and
4317 right-shift behavior when checking for time stamp overflow.
4318
4319 * editfns.c (time_overflow): New function, refactoring common code.
4320 (Fformat_time_string, Fdecode_time, Fencode_time):
4321 (Fcurrent_time_string): Use it.
4322
4323 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4324 * dired.c (make_time): Move to ...
4325 * editfns.c (make_time): ... here.
4326 * systime.h: Note the move.
4327
4328 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4329
4330 * fringe.c (update_window_fringes): Remove unused variables.
4331
4332 * unexmacosx.c (copy_data_segment): Also copy __got section.
4333 (Bug#8223)
4334
4335 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4336
4337 * termcap.c [MSDOS]: Include "msdos.h".
4338 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4339 Constify `char *' arguments and their references according to
4340 prototypes in tparam.h.
4341
4342 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4343
4344 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4345 Adapt all references accordingly.
4346
4347 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4348
4349 2011-03-11 Tom Tromey <tromey@redhat.com>
4350
4351 * buffer.c (syms_of_buffer): Remove obsolete comment.
4352
4353 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4354
4355 * termhooks.h (encode_terminal_code): Declare prototype.
4356
4357 * msdos.c (encode_terminal_code): Don't declare prototype.
4358
4359 * term.c (encode_terminal_code): Now external again, used by
4360 w32console.c and msdos.c.
4361
4362 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4363 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4364
4365 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 Fix some minor problems found by GCC 4.5.2's static checks.
4368
4369 * fringe.c (update_window_fringes): Mark locals as initialized
4370 (Bug#8227).
4371 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4372
4373 * alloc.c (mark_fringe_data): Move decl from here ...
4374 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4375 to check its interface.
4376 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4377
4378 * fontset.c (free_realized_fontset): Now static.
4379 (Fset_fontset_font): Rename local to avoid shadowing.
4380 (fontset_font): Mark local as initialized.
4381 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4382
4383 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4384
4385 * xselect.c (x_disown_buffer_selections): Remove; not used.
4386 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4387 (x_own_selection, Fx_disown_selection_internal): Rename locals
4388 to avoid shadowing.
4389 (x_handle_dnd_message): Remove local to avoid shadowing.
4390
4391 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4392 so that the caller can use some name other than gcpro1.
4393 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4394 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4395 (Fx_backspace_delete_keys_p):
4396 Use them to avoid shadowing, and rename vars to avoid shadowing.
4397 (x_decode_color, x_set_name, x_window): Now static.
4398 (Fx_create_frame): Add braces to silence GCC warning.
4399 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4400 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4401 Remove unused locals.
4402 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4403 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4404 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4405 macros.
4406
4407 * xterm.h (x_mouse_leave): New decl.
4408
4409 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4410 Remove unused functions.
4411 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4412 (x_calc_absolute_position): Now static.
4413 (XTread_socket): Don't define label "out" unless it's used.
4414 Don't declare local "event" unless it's used.
4415 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4416 unless they are used.
4417 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4418 (x_fatal_error_signal): Remove; not used.
4419 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4420 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4421 (x_error_catcher, x_connection_closed, x_error_handler):
4422 (x_error_quitter, xembed_send_message, x_iconify_frame):
4423 (my_log_handler): Rename locals to avoid shadowing.
4424 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4425 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4426
4427 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4428 Rename or move locals to avoid shadowing.
4429 (tty_defined_color, merge_face_heights): Now static.
4430 (free_realized_faces_for_fontset): Remove; not used.
4431 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4432 does not deduce is never used uninitialized.
4433 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4434 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4435
4436 * terminal.c (store_terminal_param): Now static.
4437
4438 * xmenu.c (menu_highlight_callback): Now static.
4439 (set_frame_menubar): Remove unused local.
4440 (xmenu_show): Rename parameter to avoid shadowing.
4441 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4442 since they might point to immutable storage.
4443 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4444 since it's unused otherwise.
4445
4446 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4447 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4448 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4449 avoids a gcc -Wuninitialized diagnostic.
4450 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4451 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4452 does not deduce are never used uninitialized.
4453
4454 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4455
4456 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4457 * window.c (window_loop, size_window):
4458 (run_window_configuration_change_hook, enlarge_window): Likewise.
4459
4460 * window.c (display_buffer): Now static.
4461 (size_window): Mark variables that gcc -Wuninitialized
4462 does not deduce are never used uninitialized.
4463 * window.h (check_all_windows): New decl, to forestall
4464 gcc -Wmissing-prototypes diagnostic.
4465 * dispextern.h (bidi_dump_cached_states): Likewise.
4466
4467 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4468 shadowing.
4469 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4470 Include <limits.h>.
4471 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4472 and to avoid gcc -Wuninitialized warning.
4473 (load_charset_map): Mark variables that gcc -Wuninitialized
4474 does not deduce are never used uninitialized.
4475 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4476
4477 * coding.c (coding_set_source, coding_set_destination):
4478 Use "else { /* comment */ }" rather than "else /* comment */;"
4479 for clarity, and to avoid gcc -Wempty-body warning.
4480 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4481 a block, when the outer 'i' will do.
4482 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4483 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4484 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4485 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4486 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4487 Rename locals to avoid shadowing.
4488 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4489 * coding.c (emacs_mule_char, encode_invocation_designation):
4490 Now static, since they're not used elsewhere.
4491 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4492 (decode_coding_object, encode_coding_object, detect_coding_system):
4493 (decode_coding_emacs_mule): Mark variables that gcc
4494 -Wuninitialized does not deduce are never used uninitialized.
4495 (detect_coding_iso_2022): Initialize a local variable that might
4496 be used uninitialized. Leave a FIXME because it's not clear that
4497 this initialization is needed. (Bug#8211)
4498 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4499 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4500 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4501 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4502 Remove unused macros.
4503
4504 * category.c (hash_get_category_set): Remove unused local var.
4505 (copy_category_table): Now static, since it's not used elsewhere.
4506 * character.c (string_count_byte8): Likewise.
4507
4508 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4509 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4510
4511 * chartab.c (copy_sub_char_table): Now static, since it's not used
4512 elsewhere.
4513 (sub_char_table_ref_and_range, char_table_ref_and_range):
4514 Rename locals to avoid shadowing.
4515 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4516
4517 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4518 (BIDI_BOB): Remove unused macro.
4519
4520 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4521 deduce are never used uninitialized.
4522 * term.c (encode_terminal_code): Likewise.
4523
4524 * term.c (encode_terminal_code): Now static. Remove unused local.
4525
4526 * tparam.h: New file.
4527 * term.c, tparam.h: Include it.
4528 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4529 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4530 Move these decls to tparam.h, and make them agree with what
4531 is actually in tparam.c. The previous trick of using incompatible
4532 decls in different modules does not conform to the C standard.
4533 All callers of tparam changed to use tparam's actual API.
4534 * tparam.c (tparam1, tparam, tgoto):
4535 Use const pointers where appropriate.
4536
4537 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4538 * cm.h (struct cm): Likewise.
4539 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4540 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4541 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4542 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4543 (turn_on_face, init_tty): Likewise.
4544 * termchar.h (struct tty_display_info): Likewise.
4545
4546 * term.c (term_mouse_position): Rename local to avoid shadowing.
4547
4548 * alloc.c (mark_ttys): Move decl from here ...
4549 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4550
4551 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4552
4553 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4554
4555 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * search.c (compile_pattern_1): Remove argument regp, unused since
4558 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4559 (compile_pattern): Don't pass it.
4560
4561 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4564 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4565 for ! HAVE_GTK3.
4566 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4567
4568 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4569
4570 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4571 gdk_window_get_screen, gdk_window_get_geometry,
4572 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4573 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4574 (xg_get_pixbuf_from_pixmap): New function.
4575 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4576 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4577 Call xg_get_pixbuf_from_pixmap instead of
4578 gdk_pixbuf_get_from_drawable.
4579 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4580 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4581 (xg_check_special_colors): Use GtkStyleContext and its functions
4582 for HAVE_GTK3.
4583 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4584 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4585 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4586 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4587 Call gtk_widget_get_preferred_size.
4588 (xg_frame_resized): gdk_window_get_geometry only takes 5
4589 parameters.
4590 (xg_win_to_widget, xg_event_is_for_menubar):
4591 Call gdk_x11_window_lookup_for_display.
4592 (xg_set_widget_bg): New function.
4593 (delete_cb): New function.
4594 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4595 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4596 (xg_set_background_color): Call xg_set_widget_bg.
4597 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4598 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4599 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4600 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4601 if ! HAVE_GTK3.
4602 (update_frame_tool_bar): Call gtk_widget_hide.
4603 (xg_initialize): Use GDK_KEY_g.
4604
4605 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4606 if ! HAVE_GTK3
4607 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4608
4609 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4610 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4611 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4612
4613 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4614
4615 * w32xfns.c (select_palette): Check success of RealizePalette against
4616 GDI_ERROR, not zero.
4617
4618 See ChangeLog.11 for earlier changes.
4619
4620 ;; Local Variables:
4621 ;; coding: utf-8
4622 ;; End:
4623
4624 Copyright (C) 2011 Free Software Foundation, Inc.
4625
4626 This file is part of GNU Emacs.
4627
4628 GNU Emacs is free software: you can redistribute it and/or modify
4629 it under the terms of the GNU General Public License as published by
4630 the Free Software Foundation, either version 3 of the License, or
4631 (at your option) any later version.
4632
4633 GNU Emacs is distributed in the hope that it will be useful,
4634 but WITHOUT ANY WARRANTY; without even the implied warranty of
4635 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4636 GNU General Public License for more details.
4637
4638 You should have received a copy of the GNU General Public License
4639 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.