1 2012-06-13 Glenn Morris <rgm@gnu.org>
3 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
7 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
8 * alloc.c (make_number) [!defined make_number]:
9 Remove, as lisp.h always defines this now.
10 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
11 (roundup_size): Verify that it is a power of 2.
12 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
13 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
14 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
15 -DUSE_LSB_TAG=0, to override the automatically-selected default.
16 USE_LSB_TAG now is always defined to be either 0 or 1.
18 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
19 code works fine either way, and efficiency is not a concern here,
20 as the union type is for debugging, not for production.
21 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
22 Use an inline function on all platforms when using the union type,
23 since this is simpler and 'static inline' can be used portably
25 (LISP_INITIALLY_ZERO): New macro.
26 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
27 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
29 2012-06-12 Glenn Morris <rgm@gnu.org>
31 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
33 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
35 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
36 Move BROKEN_SIGIO to configure.
38 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
39 Move NO_TERMIO to configure.
41 2012-06-12 Chong Yidong <cyd@gnu.org>
43 * image.c (imagemagick_load_image): Use MagickFlattenImage if
44 MagickMergeImageLayers is undefined. Use pixel pusher loop if
45 MagickExportImagePixels is undefined.
47 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
49 * image.c (imagemagick_load_image): Remove unused label.
51 2012-06-11 Glenn Morris <rgm@gnu.org>
53 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
54 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
55 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
56 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
58 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
60 * alloc.c (make_byte_code): New function.
61 (Fmake_byte_code): Use it. Don't purify here.
62 * lread.c (read1): Use it as well to avoid extra allocation.
64 2012-06-11 Chong Yidong <cyd@gnu.org>
66 * image.c (imagemagick_load_image): Implement transparency.
68 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
70 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
71 account for preceding backslashes. (Bug#11663)
73 2012-06-09 Chong Yidong <cyd@gnu.org>
75 * term.c: Support italics in capable terminals (Bug#9652).
76 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
77 (turn_on_face): Output using TS_enter_italic_mode if available.
78 Don't handle unused blinking and alt-charset cases.
79 (turn_off_face): Handle italic case; discard unused tty_blinking_p
80 and tty_alt_charset_p cases.
81 (tty_capable_p, init_tty): Support italics.
83 * termchar.h (struct tty_display_info): Add field for italics.
84 Remove unused blink field.
86 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
89 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
90 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
91 tty_alt_charset_p. Add tty_italic_p.
93 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
95 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
96 dbus_type_is_basic if available.
97 (xd_extract_signed, xd_extract_unsigned): Rename from
98 extract_signed and extract_unsigned, respectively. Adapt callers.
100 2012-06-09 Chong Yidong <cyd@gnu.org>
102 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
104 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
107 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
109 * xdisp.c (vmessage): Treat frame message as multibyte.
110 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
111 would generate the diagnostic "Making \302\247 buffer-local while
114 2012-06-08 Eli Zaretskii <eliz@gnu.org>
116 * dispnew.c (showing_window_margins_p): Undo last change, which
117 was done due to an inadvertent commit.
118 (adjust_frame_glyphs_for_frame_redisplay): Do call
119 showing_window_margins_p.
121 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
123 * eval.c (Fmake_var_non_special): New primitive.
124 (syms_of_eval): Defsubr it.
125 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
127 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
129 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
130 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
132 2012-06-08 Eli Zaretskii <eliz@gnu.org>
134 * alloc.c (allocate_vectorlike): Fix last change.
136 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
138 Block-based vector allocation of small vectors.
139 * lisp.h (struct vectorlike_header): New field `nbytes',
140 adjust comment accordingly.
141 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
142 to denote vector blocks. Adjust users (live_vector_p,
143 mark_maybe_pointer, valid_lisp_object_p) accordingly.
144 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
145 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
146 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
147 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
148 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
149 (roundup_size): New constant.
150 (struct vector_block): New data type.
151 (vector_blocks, vector_free_lists, zero_vector): New variables.
152 (all_vectors): Rename to `large_vectors'.
153 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
154 (sweep_vectors): New functions.
155 (allocate_vectorlike): Return `zero_vector' as the only vector of
156 0 items. Allocate new vector from block if vector size is less than
157 or equal to VBLOCK_BYTES_MAX.
158 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
159 (init_alloc_once): Add call to init_vectors.
161 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
163 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
165 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
167 * doprnt.c (doprnt): Truncate multibyte char correctly.
168 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
169 would mishandle a string argument "Xc" if X was a multibyte
170 character of length 2: it would truncate after X's first byte
171 rather than including all of X.
173 2012-06-06 Chong Yidong <cyd@gnu.org>
175 * buffer.c (word_wrap): Doc fix.
177 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
179 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
181 2012-06-03 Glenn Morris <rgm@gnu.org>
183 * xdisp.c (tool-bar-style): Doc fix.
185 2012-06-03 Ulrich Müller <ulm@gentoo.org>
187 * Makefile.in (PAXCTL): Define.
188 (temacs$(EXEEXT)): Disable memory randomization for the temacs
189 binary via PaX flags if the paxctl utility is available.
190 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
191 Restore PaX flags to their default. (Bug#11398)
193 2012-06-03 Chong Yidong <cyd@gnu.org>
195 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
198 2012-06-03 Chong Yidong <cyd@gnu.org>
200 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
201 (note_mode_line_or_margin_highlight): If there is no help echo,
202 use mode-line-default-help-echo. Handle the case where the mouse
203 position is past the end of the mode line string.
205 * buffer.c (buffer_local_value_1): New function, split from
206 Fbuffer_local_value; can return Qunbound.
207 (Fbuffer_local_value): Use it.
208 (Vmode_line_format): Docstring tweaks.
210 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
212 * sysdep.c (system_process_attributes): Improve comment.
214 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
216 * keyboard.c: Export real-this-command to Elisp.
217 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
218 and DEFVAR it. Update all users.
220 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
222 * minibuf.c (Fassoc_string): Remove duplicate declaration.
224 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
225 Convert pctcpu and pctmem to Lisp float properly.
226 Let the compiler fold better, as 100.0/0x8000 is exact.
228 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
230 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
233 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
235 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
237 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
239 For a 'struct window', replace some Lisp_Object fields to
240 bitfields where appropriate, remove unused fields.
241 * window.h (struct window): Remove unused 'last_mark_x' and
242 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
243 change it's type from Lisp_Object to bitfield.
244 Change type of 'force_start', 'optional_new_start',
245 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
246 fields from Lisp_Object to bitfield. Adjust users accordingly.
248 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
250 Pacify gcc -Wdouble-precision when using Xaw.
251 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
252 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
253 Use 'float' consistently, rather than 'float' in most places
254 and 'double' in a couple of places.
256 2012-05-31 Eli Zaretskii <eliz@gnu.org>
258 * xdisp.c (handle_stop): Detect whether we have overlay strings
259 loaded by testing it->current.overlay_string_index to be
260 non-negative, instead of checking whether n_overlay_strings is
261 positive. (Bug#11587)
263 2012-05-31 Chong Yidong <cyd@gnu.org>
265 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
267 * doc.c (Fsubstitute_command_keys): Doc fix.
269 2012-05-31 Eli Zaretskii <eliz@gnu.org>
271 * search.c (search_buffer): Remove calls to
272 r_alloc_inhibit_buffer_relocation, as it is now called by
273 maybe_unify_char, which was the cause of relocation of buffer text
276 2012-05-31 Eli Zaretskii <eliz@gnu.org>
278 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
279 for the duration of call to load_charset, to avoid problems with
280 callers of maybe_unify_char that access buffer text through C
283 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
284 decrement the inhibition flag, instead of just setting or
287 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
289 Remove obsolete '#define static' cruft.
290 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
291 This #undef was "temporary" in 2000; it is no longer needed
292 now that '#define static' has gone away.
293 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
294 (gray_bitmap_bits): Remove; no longer needed.
295 All uses replaced with definiens.
296 * xterm.c: Include "bitmaps/gray.xbm".
298 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
300 Clean up __executable_start, monstartup when --enable-profiling.
301 The following changes affect the code only when profiling.
302 * dispnew.c (__executable_start): Rename from safe_bcopy.
303 Define only on platforms that need it.
304 * emacs.c: Include <sys/gmon.h> when profiling.
305 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
306 (__executable_start): Remove decl, since lisp.h does it now.
307 (safe_bcopy): Remove decl; no longer has that name.
308 (main): Coalesce #if into single bit of code, for simplicity.
309 Cast pointers to uintptr_t, since standard libraries want integers
311 * lisp.h (__executable_start): New decl.
313 2012-05-31 Glenn Morris <rgm@gnu.org>
315 * image.c (Fimagemagick_types): Doc fix.
317 2012-05-30 Jim Meyering <meyering@redhat.com>
319 * callproc.c (Fcall_process_region): Include directory component
320 in mkstemp error message (Bug#11586).
322 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
324 * alloc.c, lisp.h (make_pure_vector): Now static.
326 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
328 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
330 (Fautoload): Do the hash-doc more carefully.
331 * data.c (Fdefalias): Purify definition, except for keymaps.
332 (Qdefun): Move from eval.c.
333 * lisp.h (Qdefun): Remove.
334 * lread.c (read1): Tiny simplification.
336 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
338 Do not create empty overlays with the evaporate property (Bug#9642).
339 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
340 Bug#9642, but explicitly check that the buffer the overlay would
341 be moved to is live and rearrange lines to make sure that errors
342 will not put the overlay in an inconsistent state.
343 (Fdelete_overlay): Cosmetics.
345 2012-05-28 Eli Zaretskii <eliz@gnu.org>
347 * w32term.c (my_bring_window_to_top): New function.
348 (x_raise_frame): Use handle returned by DeferWindowPos, which
349 could be different from the original one.
350 Call my_bring_window_to_top instead of my_set_foreground_window.
353 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
354 by calling BringWindowToTop.
356 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
357 (WM_EMACS_END): Increase by one.
359 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
361 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
362 This avoids undefined behavior that might cause the eassert
363 to not catch an out-of-range value.
365 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
367 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
370 2012-05-27 Eli Zaretskii <eliz@gnu.org>
372 * bidi.c (bidi_mirror_char): Fix last change.
374 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
376 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
377 when referring to sectname field in printf format.
379 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
381 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
382 Only r_alloc_inhibit_buffer_relocation needed to be added;
383 the others were already declared.
385 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
386 before checking whether it's out of range. Put the check inside
388 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
390 2012-05-27 Ken Brown <kbrown@cornell.edu>
392 * callproc.c (Fcall_process): Restore a line that was accidentally
393 commented out in the 2011-02-13 change (bug#11547).
395 2012-05-27 Eli Zaretskii <eliz@gnu.org>
397 * lisp.h [REL_ALLOC]: Add prototypes for external functions
400 * buffer.c [REL_ALLOC]: Remove prototypes of
401 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
402 they are now on lisp.h.
404 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
406 * search.c (search_buffer): Use it to inhibit relocation of buffer
407 text while re_search_2 is doing its job, because re_search_2 is
408 passed C pointers to buffer text. (Bug#11519)
410 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
413 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
414 state after an additional call to move_it_in_display_line_to, keep
415 the values of it->max_ascent and it->max_descent found for the
417 (pos_visible_p): Revert the comparison against bottom_y to what it
418 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
421 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
423 Fix coding-related core dumps with gcc -ftrapv.
424 The code was computing A - B, where A and B are pointers, and B is
425 random garbage. This can lead to core dumps on platforms that
426 have special pointer registers, and it also leads to core dumps on
427 x86-64 when compiled with gcc -ftrapv. The fix is to compute
428 A - B only when B is initialized properly.
429 * coding.c (coding_set_source, coding_set_destination): Return void.
430 (coding_change_source, coding_change_destinations): New functions,
431 with the old behaviors of coding_set_source and coding_set_destination.
432 All callers that need an offset changed to use these new functions.
434 2012-05-26 Glenn Morris <rgm@gnu.org>
436 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
438 2012-05-26 Eli Zaretskii <eliz@gnu.org>
440 Extend mouse support on W32 text-mode console.
441 * xdisp.c (draw_row_with_mouse_face):
442 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
444 * w32console.c: Include window.h.
445 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
447 (initialize_w32_display): Initialize mouse-highlight data.
449 * w32inevt.c: Include termchar.h and window.h.
450 (do_mouse_event): Support mouse-autoselect-window. When the mouse
451 moves, call note_mouse_highlight. If help_echo changed, call
452 gen_help_event to produce help-echo message in the echo area.
453 Call clear_mouse_face if mouse_face_hidden is set in the mouse
456 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
458 * lread.c (read1): Simplify slightly to avoid an overflow warning
459 with GCC 4.7.0 on x86-64.
461 2012-05-26 Eli Zaretskii <eliz@gnu.org>
463 * bidi.c (bidi_mirror_char): Revert last change: an int is
464 definitely wide enough here.
466 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
468 Fix integer width and related bugs (Bug#9874).
469 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
470 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
471 (string_bytes, check_sblock, allocate_string_data):
472 (compact_small_strings, Fmake_bool_vector, make_string)
473 (make_unibyte_string, make_multibyte_string)
474 (make_string_from_bytes, make_specified_string)
475 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
476 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 (allocate_pseudovector):
480 Use int, not EMACS_INT, where int is wide enough.
481 (inhibit_garbage_collection, Fgarbage_collect):
482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
483 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
484 int might not be wide enough.
485 (bidi_cache_search, bidi_cache_find, bidi_init_it)
486 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
487 (bidi_at_paragraph_end, bidi_find_paragraph_start)
488 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
489 (bidi_level_of_next_char, bidi_move_to_visually_next):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
492 (Fkill_buffer, Fset_buffer_major_mode)
493 (advance_to_char_boundary, Fbuffer_swap_text)
494 (Fset_buffer_multibyte, overlays_at, overlays_in)
495 (overlay_touches_p, struct sortvec, record_overlay_string)
496 (overlay_strings, recenter_overlay_lists)
497 (adjust_overlays_for_insert, adjust_overlays_for_delete)
498 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
499 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
500 (Foverlay_recenter, last_overlay_modification_hooks_used)
501 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
503 (validate_region): Omit unnecessary test for b <= e,
504 since that's guaranteed by the previous test.
505 (adjust_overlays_for_delete): Avoid pos + length overflow.
506 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
507 (report_overlay_modification):
508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
509 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
510 Omit pointer cast, which isn't needed anyway, and doesn't work
511 after the EMACS_INT -> ptrdiff_t change.
512 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
513 * buffer.h: Adjust decls to match defn changes elsewhere.
514 (struct buffer_text, struct buffer):
515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
516 Use EMACS_INT, not int, where int might not be wide enough.
517 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
518 not int, to avoid needless 32-bit limit on 64-bit hosts.
519 (exec_byte_code): Use tighter memory-full test, one that checks
520 for alloca overflow. Don't compute the address of the object just
521 before an array, as that's not portable. Use EMACS_INT, not
522 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
523 * callint.c (Fcall_interactively):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 * callproc.c (call_process_kill, Fcall_process):
526 Don't assume pid_t fits into an Emacs fixnum.
527 (call_process_cleanup, Fcall_process, child_setup):
528 Don't assume pid_t fits into int.
529 (call_process_cleanup, Fcall_process, delete_temp_file)
530 (Fcall_process_region):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 (Fcall_process): Simplify handling of volatile integers.
533 Use int, not EMACS_INT, where int will do.
534 * casefiddle.c (casify_object, casify_region, operate_on_word)
535 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (casify_object): Avoid integer overflow when overallocating buffer.
538 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
539 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
540 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
541 * category.h (CATEGORYP): Don't assume arg is nonnegative.
542 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
543 integers are now checked earlier. All uses replaced with XINT.
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 For CCL_MapSingle, check that content and value are in int range.
547 (ccl_driver, Fregister_code_conversion_map):
548 Check that Vcode_version_map_vector is a vector.
549 (resolve_symbol_ccl_program): Check that vector header is in range.
550 Always copy the vector, so that we can check its contents reliably
551 now rather than having to recheck each instruction as it's being
552 executed. Check that vector words fit in 'int'.
553 (ccl_get_compiled_code, Fregister_ccl_program)
554 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
555 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
556 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
557 contents are in range.
558 (Fccl_execute_on_string): Check that status is in range.
559 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
560 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
561 Accept and return EMACS_INT, not int, because callers can pass values
563 (c_string_width, strwidth, lisp_string_width, chars_in_text)
564 (multibyte_chars_in_text, parse_str_as_multibyte)
565 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
566 (str_as_unibyte, str_to_unibyte, string_count_byte8)
567 (string_escape_byte8, Fget_byte):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
570 avoid mishandling large integers.
571 * character.h: Adjust decls to match defn changes elsewhere.
572 * charset.c (load_charset_map_from_file, find_charsets_in_text)
573 (Ffind_charset_region):
574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
575 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
576 (load_charset_map_from_vector, Fdefine_charset_internal):
577 Don't assume fixnum fits in int.
578 (load_charset_map_from_vector, Fmap_charset_chars):
579 Remove now-unnecessary CHECK_NATNUMs.
580 (Fdefine_charset_internal): Check ranges here, more carefully.
581 Don't rely on undefined behavior with signed left shift overflow.
582 Don't assume unsigned int fits into fixnum, or that fixnum fits
583 into unsigned int. Don't require max_code to be a valid fixnum;
584 that's not true for gb10830 4-byte on a 32-bit host. Allow
585 invalid_code to be a cons, for the same reason. Require code_offset
586 to be a character. Avoid int overflow if max_char is close
588 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
589 this is intended anyway and avoids some undefined behavior.
590 (load_charset_map): Pass unsigned, not int, as 2nd arg of
591 INDEX_TO_CODE_POINT, as that's what it expects.
592 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
593 * charset.h (DECODE_CHAR): Return int, not unsigned;
594 this is what was intended anyway, and it avoids undefined behavior.
595 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
596 integer-overflow issues.
597 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
598 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
599 where the argument is EMACS_INT, and this behavior is not intended.
600 * chartab.c (Fmake_char_table, Fset_char_table_range)
601 (uniprop_get_decoder, uniprop_get_encoder):
602 Don't assume fixnum fits in int.
603 * cmds.c (move_point): New function, that does the gist of
604 Fforward_char and Fbackward_char, but does so while checking
605 for integer overflow more accurately.
606 (Fforward_char, Fbackward_char): Use it.
607 (Fforward_line, Fend_of_line, internal_self_insert)
608 (internal_self_insert):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 Fix a FIXME, by checking for integer overflow when calculating
611 target_clm and actual_clm.
612 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
613 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
614 (ASSURE_DESTINATION, coding_alloc_by_realloc)
615 (coding_alloc_by_making_gap, alloc_destination)
616 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
617 (encode_coding_utf_16, detect_coding_emacs_mule)
618 (decode_coding_emacs_mule, encode_coding_emacs_mule)
619 (detect_coding_iso_2022, decode_coding_iso_2022)
620 (encode_invocation_designation, encode_designation_at_bol)
621 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
622 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
623 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
624 (encode_coding_ccl, encode_coding_raw_text)
625 (detect_coding_charset, decode_coding_charset)
626 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
627 (produce_composition, produce_charset, produce_annotation)
628 (decode_coding, handle_composition_annotation)
629 (handle_charset_annotation, consume_chars, decode_coding_gap)
630 (decode_coding_object, encode_coding_object, detect_coding_system)
631 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
632 (code_convert_region, code_convert_string)
633 (Fdefine_coding_system_internal)
634 (coding_set_source, coding_set_destination):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
637 (Fdefine_coding_system_internal):
638 Don't assume fixnums fit in int.
639 (decode_coding_gap, decode_coding_object, encode_coding_object)
640 (Fread_coding_system, Fdetect_coding_region)
641 (Funencodable_char_position, Fcheck_coding_systems_region)
642 (get_translation, handle_composition_annotation, consume_chars):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 (consume_chars): Rewrite to not calculate an address outside buffer.
645 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
646 Don't access memory outside of the args array.
647 (Fdefine_coding_system_internal): Check for charset-id overflow.
648 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
649 result of ENCODE_CHAR.
650 * coding.h: Adjust decls to match defn changes elsewhere.
651 (struct coding_system):
652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
653 * composite.c (get_composition_id, find_composition)
654 (run_composition_function, update_compositions)
655 (compose_text, composition_gstring_put_cache)
656 (composition_gstring_p, composition_gstring_width)
657 (fill_gstring_header, fill_gstring_body, autocmp_chars)
658 (composition_compute_stop_pos, composition_reseat_it)
659 (composition_update_it, struct position_record)
660 (find_automatic_composition, composition_adjust_point)
661 (Fcomposition_get_gstring, Ffind_composition_internal):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (update_compositions):
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 * composite.h: Adjust decls to match defn changes elsewhere.
666 (struct composition):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
669 Do not attempt to compute the address of the object just before a
670 buffer; this is not portable.
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (Faset): Use int, not EMACS_INT, where int is wide enough.
674 (Fstring_to_number): Don't assume fixnums fit in int.
675 (Frem): Don't assume arg is nonnegative.
676 * dbusbind.c (xd_append_arg): Check for integers out of range.
677 (Fdbus_call_method): Don't overflow the timeout int.
678 (extract_signed, extract_unsigned): New functions.
679 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
680 (xd_get_connection_references): Return ptrdiff_t, not int.
682 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
684 Use int, not unsigned, where the dbus API uses int.
685 (Fdbus_message_internal): Don't overflow mtype.
686 (syms_of_dbusbind): Allocate right-sized buffer for integers.
687 * dired.c (directory_files_internal, file_name_completion, scmp)
688 (file_name_completion_stat):
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 (file_name_completion): Don't overflow matchcount.
691 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
692 * dispextern.h: Adjust decls to match defn changes elsewhere.
693 (struct text_pos, struct glyph, struct bidi_saved_info)
694 (struct bidi_string_data, struct bidi_it, struct composition_it)
696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
697 (struct display_pos, struct composition_it, struct it):
698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
699 * dispnew.c (increment_matrix_positions)
700 (increment_row_positions, mode_line_string)
701 (marginal_area_string):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 (duration_to_sec_usec): New function, to check for overflow better.
706 (Fsleep_for, sit_for): Use it.
707 * doc.c (get_doc_string, store_function_docstring):
708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (get_doc_string, Fsnarf_documentation):
710 Use int, not EMACS_INT, where int is wide enough.
712 Use SAFE_ALLOCA, not alloca.
713 Check for overflow when converting EMACS_INT to off_t.
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
717 Don't assume uid_t fits into fixnum.
718 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
719 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
720 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
721 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
722 (general_insert_function)
723 (Finsert_char, make_buffer_string, make_buffer_string_both)
724 (update_buffer_properties, Fbuffer_substring)
725 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
726 (Fsubst_char_in_region, check_translation)
727 (Ftranslate_region_internal, save_restriction_restore, Fformat)
728 (transpose_markers, Ftranspose_regions):
729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
730 (clip_to_bounds): Move to lisp.h as an inline function).
731 (Fconstrain_to_field): Don't assume integers are nonnegative.
732 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
733 (Fsubst_char_in_region, Fsave_restriction):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 (Femacs_pid): Don't assume pid_t fits into fixnum.
736 (lo_time): Use int, not EMACS_INT, when int suffices.
737 (lisp_time_argument): Check for usec out of range.
738 (Fencode_time): Don't assume fixnum fits in int.
739 (Fuser_login_name, Fuser_full_name): Signal an error
740 if a uid argument is out of range, rather than relying on
742 (Fformat_time_string): Remove now-unnecessary check.
743 lisp_time_argument checks for out-of-range usec now.
744 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
745 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
746 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
747 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
748 (init_cmdargs, Fdump_emacs):
749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
750 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
751 the bottom (typically) 32 bits of the fixnum.
752 * eval.c (specpdl_size, call_debugger):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (when_entered_debugger, Fbacktrace_debug):
755 Don't assume fixnum can fit in int.
756 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
757 the object just before a buffer; this is not portable.
758 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
759 (grow_specpdl, unbind_to):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
762 (grow_specpdl): Simplify allocation by using xpalloc.
763 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
764 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
765 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 (Fcopy_file, non_regular_nbytes, read_non_regular)
771 (Finsert_file_contents):
772 Use int, not EMACS_INT, where int is wide enough.
773 (READ_BUF_SIZE): Verify that it fits in int.
774 (Finsert_file_contents): Check that counts are in proper range,
775 rather than assuming fixnums fit into ptrdiff_t etc.
776 Don't assume fixnums fit into int.
777 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
778 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
779 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
780 (string_char_to_byte, string_byte_to_char)
781 (string_make_multibyte, string_to_multibyte)
782 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
783 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
784 (substring_both, Fdelete, internal_equal, Ffillarray)
785 (Fclear_string, mapcar1)
786 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
787 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
788 (larger_vector, make_hash_table, maybe_resize_hash_table)
789 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
790 (Fmaphash, secure_hash):
791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
792 (concat): Check for string index and length overflow.
793 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
796 (larger_vector): New API (vec, incr_min, size_max) replaces old
797 one (vec, new_size, init). This catches size overflow.
798 INIT was removed because it was always Qnil.
800 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
801 the upper bound on a hash table index size.
802 (make_hash_table, maybe_resize_hash_table): Use it.
803 (secure_hash): Computer start_byte and end_byte only after
804 they're known to be in ptrdiff_t range.
805 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
806 (Ffont_get_glyphs, Ffont_at):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
809 (Flist_fonts, Fopen_font):
810 Don't assume fixnum can fit in int.
811 (check_gstring): Don't assume index can fit in int.
812 (font_match_p): Check that fixnum is a character, not a nonnegative
813 fixnum, since the later code needs to stuff it into an int.
814 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
815 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
816 conversion overflow issues.
817 (Fopen_font): Check for integer out of range.
818 (Ffont_get_glyphs): Don't assume index can fit in int.
819 * font.h: Adjust decls to match defn changes elsewhere.
820 * fontset.c (reorder_font_vector): Redo score calculation to avoid
822 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
823 printmax_t, where ptrdiff_t is wide enough.
824 (Finternal_char_font):
825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
826 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
827 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
828 (Fset_frame_position, x_set_frame_parameters)
829 (x_set_line_spacing, x_set_border_width)
830 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
831 Check that fixnums are in proper range for system types.
832 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
834 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
835 Use SAFE_ALLOCA_LISP, not alloca.
836 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
837 intptr_t is wide enough.
838 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
839 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
840 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
841 Check for fixnum out of range.
842 * ftfont.c (ftfont_list): Don't assume index fits in int.
843 Check that fixnums are in proper range for system types.
844 (ftfont_shape_by_flt):
845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
846 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
849 Check that fixnums are in proper range for system types.
850 * gnutls.h: Adjust decls to match defn changes elsewhere.
851 * gtkutil.c (xg_dialog_run):
852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
853 (update_frame_tool_bar):
854 Check that fixnums are in proper range for system types.
855 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
856 (lookup_image): Check that fixnums are in range for system types.
857 * indent.c (last_known_column, last_known_column_point):
858 (current_column_bol_cache):
859 (skip_invisible, current_column, check_display_width):
860 (check_display_width, scan_for_column, current_column_1)
861 (Findent_to, Fcurrent_indentation, position_indentation)
862 (indented_beyond_p, Fmove_to_column, compute_motion):
863 (Fcompute_motion, Fvertical_motion):
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 (last_known_column_modified): Use EMACS_INT, not int.
866 (check_display_width):
868 Check that fixnums and floats are in proper range for system types.
869 (compute_motion): Don't assume index or fixnum fits in int.
870 (compute_motion, Fcompute_motion):
871 Use int, not EMACS_INT, when it is wide enough.
872 (vmotion): Omit local var start_hpos that is always 0; that way
873 we don't need to worry about overflow in expressions involving it.
874 * indent.h: Adjust decls to match defn changes elsewhere.
876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
877 Use int, not EMACS_INT, where int is wide enough.
878 Remove unused members ovstring_chars_done and tab_offset;
880 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
881 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
882 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
883 (make_gap, copy_text, insert, insert_and_inherit)
884 (insert_before_markers, insert_before_markers_and_inherit)
885 (insert_1, count_combining_before, count_combining_after)
886 (insert_1_both, insert_from_string)
887 (insert_from_string_before_markers, insert_from_string_1)
888 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
889 (adjust_after_replace, adjust_after_insert, replace_range)
890 (replace_range_2, del_range, del_range_1, del_range_byte)
891 (del_range_both, del_range_2, modify_region)
892 (prepare_to_modify_buffer, signal_before_change)
893 (signal_after_change, Fcombine_after_change_execute):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 * intervals.c (traverse_intervals, rotate_right, rotate_left)
896 (balance_an_interval, split_interval_right, split_interval_left)
897 (find_interval, next_interval, update_interval)
898 (adjust_intervals_for_insertion, delete_node, delete_interval)
899 (interval_deletion_adjustment, adjust_intervals_for_deletion)
900 (static_offset_intervals, offset_intervals)
901 (merge_interval_right, merge_interval_left, make_new_interval)
902 (graft_intervals_into_buffer, temp_set_point_both)
903 (temp_set_point, set_point, adjust_for_invis_intang)
904 (set_point_both, move_if_not_intangible, get_property_and_range)
905 (get_local_map, copy_intervals, copy_intervals_to_string)
906 (compare_string_intervals, set_intervals_multibyte_1):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 * intervals.h: Adjust decls to match defn changes elsewhere.
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 * keyboard.c (this_command_key_count, this_single_command_key_start)
912 (before_command_key_count, before_command_echo_length, echo_now)
913 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
914 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
915 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
916 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (last_non_minibuf_size, last_point_position, echo_truncate)
919 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
920 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
921 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
922 (stuff_buffered_input):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 (last_auto_save, command_loop_1, read_char):
925 Use EMACS_INT, not int, to avoid integer overflow.
926 (record_char): Avoid overflow in total_keys computation.
927 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
928 * keyboard.h: Adjust decls to match defn changes elsewhere.
929 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
930 (Fkey_description, Fdescribe_vector, Flookup_key):
931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
932 (click_position): New function, to check that positions are in range.
933 (Fcurrent_active_maps):
935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
936 (Faccessible_keymaps, Fkey_description):
937 (preferred_sequence_p):
938 Don't assume fixnum can fit into int.
939 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
940 Check for integer overflow in size calculations.
941 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
942 avoid mishandling large integers.
943 * lisp.h: Adjust decls to match defn changes elsewhere.
944 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
945 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
946 (struct Lisp_Marker):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (clip_to_bounds): Now an inline function, moved here from editfns.c.
949 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
950 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
952 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
953 Assume the arg has valid form, since it always does.
954 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
955 unsigned integer system type.
956 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
957 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
959 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
960 (duration_to_sec_usec): New decl.
961 * lread.c (read_from_string_index, read_from_string_index_byte)
962 (read_from_string_limit, readchar, unreadchar, openp)
963 (read_internal_start, read1, oblookup):
964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
965 (Fload, readevalloop, Feval_buffer, Feval_region):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (openp): Check for out-of-range argument to 'access'.
968 (read1): Use int, not EMACS_INT, where int is wide enough.
969 Don't assume fixnum fits into int.
970 Fix off-by-one error that can read outside a buffer.
971 (read_filtered_event): Use duration_to_sec_usec
972 to do proper overflow checking on durations.
973 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
975 (Fexecute_kbd_macro):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
978 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
979 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
980 (set_marker_both, set_marker_restricted_both, marker_position)
981 (marker_byte_position, Fbuffer_has_markers_at):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
984 * menu.c (ensure_menu_items): Rename from grow_menu_items.
985 It now merely ensures that the menu is large enough, without
986 necessarily growing it, as this avoids some integer overflow issues.
988 (keymap_panes, parse_single_submenu, Fx_popup_menu):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
991 Use SAFE_ALLOCA_LISP, not alloca.
992 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
993 to EMACS_INT. Check that fixnums are in proper range for system types.
994 * minibuf.c (minibuf_prompt_width, string_to_object)
995 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
996 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (get_minibuffer, read_minibuf_unwind):
999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1001 this simplifies overflow checking. All callers changed.
1002 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1005 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1006 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1007 Check that fixnums are in proper range for system types.
1008 (Fx_create_frame, Fx_show_tip):
1009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1010 * nsfont.m (ns_findfonts, nsfont_list_family):
1011 Don't assume fixnum fits in long.
1012 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1016 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1018 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1019 (PRINTDECLARE, PRINTPREPARE):
1020 (strout, print_string):
1021 (print, print_preprocess, print_check_string_charset_prop)
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1025 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1027 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1028 (printchar, strout): Use xpalloc to catch size calculation overflow.
1029 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1030 (print_error_message): Use SAFE_ALLOCA, not alloca.
1031 (print_object): Use int, not EMACS_INT, where int is wide enough.
1032 (print_depth, new_backquote_output, print_number_index):
1033 Use ptrdiff_t, not int, where int might not be wide enough.
1034 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1035 (Fset_process_window_size, Fformat_network_address)
1036 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1038 Check that fixnums are in proper range for system types.
1039 (Fsignal_process): Simplify by avoiding a goto.
1040 Check for process-ids out of pid_t range rather than relying on
1042 (process_tick, update_tick): Use EMACS_INT, not int.
1043 (Fformat_network_address, read_process_output, send_process)
1044 (Fprocess_send_region, status_notify):
1045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1046 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1047 (wait_reading_process_output, read_process_output, exec_sentinel):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1050 (Faccept_process_output): Use duration_to_sec_usec to do proper
1051 overflow checking on durations.
1052 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1053 Don't assume pid_t fits in int.
1054 * process.h (struct Lisp_Process): Members tick and update_tick
1055 are now of type EMACS_INT, not int.
1056 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1057 configured --with-wide-int.
1058 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1059 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1060 * search.c (looking_at_1, string_match_1):
1061 (fast_string_match, fast_c_string_match_ignore_case)
1062 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1063 (scan_newline, find_before_next_newline, search_command)
1064 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1065 (set_search_regs, wordify):
1068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1069 (string_match_1, search_buffer, set_search_regs):
1071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1072 (wordify): Check for overflow in size calculation.
1073 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1074 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1075 Check that fixnums are in proper range for system types.
1076 * sound.c (struct sound_device)
1077 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1079 (Fplay_sound_internal):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 * syntax.c (struct lisp_parse_state, find_start_modiff)
1082 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1083 (Fparse_partial_sexp):
1084 Don't assume fixnums can fit in int.
1085 (struct lisp_parse_state, find_start_pos, find_start_value)
1086 (find_start_value_byte, find_start_begv)
1087 (update_syntax_table, char_quoted, dec_bytepos)
1088 (find_defun_start, prev_char_comend_first, back_comment):
1089 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1090 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1092 (Finternal_describe_syntax_value): Check that match_lisp is a
1093 character, not an integer, since the code stuffs it into int.
1094 (scan_words, scan_sexps_forward):
1095 Check that fixnums are in proper range for system types.
1097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1098 (scan_sexps_forward):
1099 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1100 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1101 * syntax.h: Adjust decls to match defn changes elsewhere.
1102 (struct gl_state_s):
1103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1104 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1105 MOST_POSITIVE_FIXNUM.
1106 * sysdep.c (wait_for_termination_1, wait_for_termination)
1107 (interruptible_wait_for_termination, mkdir):
1108 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1109 (emacs_read, emacs_write):
1110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1111 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1112 and double all fit in int.
1113 * term.c (set_tty_color_mode):
1114 Check that fixnums are in proper range for system types.
1115 * termhooks.h (struct input_event):
1116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1117 * textprop.c (validate_interval_range, interval_of)
1118 (Fadd_text_properties, set_text_properties_1)
1119 (Fremove_text_properties, Fremove_list_of_text_properties)
1120 (Ftext_property_any, Ftext_property_not_all)
1121 (copy_text_properties, text_property_list, extend_property_ranges)
1122 (verify_interval_modification):
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 (Fnext_single_char_property_change)
1125 (Fprevious_single_char_property_change):
1126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1127 (copy_text_properties):
1128 Check for integer overflow in index calculation.
1129 * undo.c (last_boundary_position, record_point, record_insert)
1130 (record_delete, record_marker_adjustment, record_change)
1131 (record_property_change):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1135 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1136 (Fx_hide_tip, Fx_file_dialog):
1137 * w32menu.c (set_frame_menubar):
1138 Use ptrdiff_t, not int, for consistency with rest of code.
1139 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1140 (select_window, Fdelete_other_windows_internal)
1141 (window_scroll_pixel_based, window_scroll_line_based)
1142 (Frecenter, Fset_window_configuration):
1143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1144 (Fset_window_hscroll, run_window_configuration_change_hook)
1145 (set_window_buffer, temp_output_buffer_show, scroll_command)
1146 (Fscroll_other_window, Frecenter):
1147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1148 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1149 Don't assume fixnum fits in int.
1150 (Fset_window_scroll_bars):
1151 Check that fixnums are in proper range for system types.
1152 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1153 (string_pos, c_string_pos, number_of_chars, init_iterator)
1154 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1155 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1156 (compute_display_string_end, handle_face_prop)
1157 (face_before_or_after_it_pos, handle_invisible_prop)
1158 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1159 (display_prop_intangible_p, string_buffer_position_lim)
1160 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1161 (get_overlay_strings_1, get_overlay_strings)
1162 (iterate_out_of_display_property, forward_to_next_line_start)
1163 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1164 (get_next_display_element, set_iterator_to_next)
1165 (get_visually_first_element, compute_stop_pos_backwards)
1166 (handle_stop_backwards, next_element_from_buffer)
1167 (move_it_in_display_line_to, move_it_in_display_line)
1168 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1169 (add_to_log, message_dolog, message_log_check_duplicate)
1170 (message2, message2_nolog, message3, message3_nolog
1171 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1172 (current_message_1, truncate_echo_area, truncate_message_1)
1173 (set_message, set_message_1, store_mode_line_noprop)
1174 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1175 (text_outside_line_unchanged_p, check_point_in_composition)
1176 (reconsider_clip_changes)
1177 (redisplay_internal, set_cursor_from_row, try_scrolling)
1178 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1179 (redisplay_window, find_last_unchanged_at_beg_row)
1180 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1181 (trailing_whitespace_p, find_row_edges, display_line)
1182 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1183 (display_mode_element, store_mode_line_string)
1184 (pint2str, pint2hrstr, decode_mode_spec)
1185 (display_count_lines, display_string, draw_glyphs)
1186 (x_produce_glyphs, x_insert_glyphs)
1187 (rows_from_pos_range, mouse_face_from_buffer_pos)
1188 (fast_find_string_pos, mouse_face_from_string_pos)
1189 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1191 (safe_call, init_from_display_pos, handle_fontified_prop)
1192 (handle_single_display_spec, load_overlay_strings)
1193 (with_echo_area_buffer, setup_echo_area_for_printing)
1194 (display_echo_area, echo_area_display)
1195 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1196 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1197 (redisplay_window, dump_glyph_row, display_mode_line)
1198 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1199 (handle_display_spec, display_prop_string_p):
1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1201 (handle_single_display_spec, build_desired_tool_bar_string)
1202 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1203 (get_specified_cursor_type):
1204 Check that fixnums are in proper range for system types.
1205 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1206 (Flookup_image_map):
1207 Don't assume fixnums fit in int.
1208 (compare_overlay_entries):
1209 Avoid mishandling comparisons due to subtraction overflow.
1210 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1211 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1212 (handle_tool_bar_click):
1213 Use int, not unsigned, since we prefer signed and the signedness
1214 doesn't matter here.
1215 (get_next_display_element, next_element_from_display_vector):
1216 Use int, not EMACS_INT, when int is wide enough.
1217 (start_hourglass): Use duration_to_sec_usec to do proper
1218 overflow checking on durations.
1219 * xfaces.c (Fbitmap_spec_p):
1220 Check that fixnums are in proper range for system types.
1221 (compare_fonts_by_sort_order):
1222 Avoid mishandling comparisons due to subtraction overflow.
1223 (Fx_family_fonts, realize_basic_faces):
1224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1226 Don't assume fixnum fits in int.
1227 Use SAFE_ALLOCA_LISP, not alloca.
1228 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1229 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1230 (face_at_buffer_position, face_for_overlay_string)
1231 (face_at_string_position):
1232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1233 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1234 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1236 Check that fixnums are in proper range for system types.
1237 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1238 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1240 (Fx_change_window_property): Don't assume fixnums fit in int.
1241 * xfont.c (xfont_chars_supported):
1242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1243 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1244 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1246 * xml.c (parse_region):
1247 * xrdb.c (magic_file_p):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1250 (x_get_local_selection, x_reply_selection_request)
1251 (x_handle_selection_request, wait_for_property_change):
1252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1253 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1254 short is wide enough.
1255 (x_send_client_event): Don't assume fixnum fits in int.
1256 * xterm.c (x_x_to_emacs_modifiers):
1257 Don't assume EMACS_INT overflows nicely into int.
1258 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1260 (handle_one_xevent): NATNUMP can eval its arg twice.
1261 (x_connection_closed):
1262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1263 * xterm.h: Adjust decls to match defn changes elsewhere.
1264 (struct scroll_bar): Use struct vectorlike_header
1265 rather than rolling our own approximation.
1266 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1268 2012-05-25 Glenn Morris <rgm@gnu.org>
1270 * lisp.mk (lisp): Update for more files being compiled now.
1272 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1274 * lread.c: Remove `read_pure' which makes no difference.
1275 (read_pure): Remove var.
1276 (unreadpure): Remove function.
1277 (readevalloop): Don't call read_list with -1 flag.
1278 (read1, read_vector): Don't test read_pure any more.
1279 (read_list): Simplify.
1281 * fileio.c, character.h: Minor style tweaks.
1283 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1285 * window.h (clip_changed): Remove useless declaration.
1287 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1289 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1290 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1292 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1295 This directory predates autoconf and is no longer needed nowadays.
1296 Move its few remaining bits of functionality to where they're needed.
1297 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1298 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1299 * m/template.h: Remove.
1300 * Makefile.in (M_FILE): Remove. All uses removed.
1301 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1302 * lisp.h (USE_LSB_TAG):
1303 * mem-limits.h (EXCEEDS_LISP_PTR):
1304 Use VAL_MAX, not VALBITS, in #if.
1305 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1306 (EMACS_UINT): Define unconditionally now.
1307 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1308 (BITS_PER_EMACS_INT): New constants, replacing
1309 what used to be in config.h, but not useful in #if.
1310 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1311 define them any more.
1312 (VAL_MAX): New macro.
1314 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1315 BITS_PER_EMACS_INT, in #if.
1316 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1317 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1318 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1319 * s/ms-w32.h (DATA_START):
1320 Move here from removed file m/intel386.h.
1321 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1322 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1324 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1326 Assume C89 or later.
1327 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1328 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1330 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1331 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1332 * textprop.c, tparam.c (NULL): Remove.
1333 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1334 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1335 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1336 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1337 * xterm.c (input_signal_count): Assume volatile works.
1339 2012-05-21 Ken Brown <kbrown@cornell.edu>
1341 * xgselect.c (xg_select): Fix first argument in call to 'select'
1344 2012-05-20 Ken Brown <kbrown@cornell.edu>
1346 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1347 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1349 2012-05-19 Ken Brown <kbrown@cornell.edu>
1351 * xfns.c (x_in_use): Remove `static' qualifier.
1352 * xterm.h (x_in_use): Declare.
1353 * xgselect.c: Include xterm.h.
1354 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1355 and `display_arg' (bug#9754).
1357 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1359 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1361 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1362 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1364 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1366 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1368 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1369 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1371 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1372 reference to image_cache->refcount.
1373 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1375 2012-05-17 Juri Linkov <juri@jurta.org>
1377 * search.c (Fword_search_regexp, Fword_search_backward)
1378 (Fword_search_forward, Fword_search_backward_lax)
1379 (Fword_search_forward_lax): Move functions to isearch.el
1380 (bug#10145, bug#11381).
1382 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1384 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1386 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1388 * lread.c (init_obarray): Declare Qt and Qnil as special.
1390 2012-05-14 Glenn Morris <rgm@gnu.org>
1392 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1393 Put "libexec" before "bin", for the sake of init_callproc_1.
1395 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1397 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1399 * unexaix.c: Port to more-recent AIX compilers.
1400 (report_error, report_error_1, make_hdr, copy_sym)
1401 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1402 Make arguments const char *, not char *, to avoid violations of C
1403 standard and to fix some AIX warnings reported by Gilles Pion.
1405 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1407 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1408 already have overlays loaded.
1409 (handle_single_display_spec): Before returning without displaying
1410 fringe bitmap, synchronize the bidi iterator with the main display
1411 iterator, by calling iterate_out_of_display_property.
1412 (iterate_out_of_display_property): Detect buffer iteration by
1413 testing that it->string is a Lisp string.
1414 (get_next_display_element): When the current object is exhausted,
1415 and there's something on it->stack, call set_iterator_to_next to
1416 proceed with what's on the stack, instead of returning zero.
1417 (set_iterator_to_next): If called at the end of a Lisp string,
1418 proceed to consider_string_end without incrementing string
1419 position. Don't increment display vector index past the end of
1420 the display vector. (Bug#11417)
1421 (pos_visible_p): Don't report a position visible when move_it_to
1422 stopped at the last line of window, which happens to be scanned
1423 backwards by the bidi iteration. (Bug#11464)
1425 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1428 and right-margin display specs even if the spec is invalid or we
1429 are on a TTY, and thus unable to display on the fringes.
1430 That's because the text with the property will not be displayed anyway,
1431 so we need to signal to the caller that this is a "replacing"
1432 display spec. This fixes display when the spec is invalid or we
1435 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1437 * unexaix.c (make_hdr): Fix typo in prototype.
1438 This bug broke the build on AIX. Problem reported by Gilles Pion.
1440 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1442 * keyboard.c (kbd_buffer_get_event): Read special events also in
1443 batch mode. (Bug#11415)
1445 2012-05-12 Glenn Morris <rgm@gnu.org>
1447 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1449 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1451 * lisp.mk (lisp): Add newcomment.elc.
1453 2012-05-12 Glenn Morris <rgm@gnu.org>
1455 * Makefile.in (MKDIR_P): New, set by configure.
1456 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1458 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1460 Remove unused function hourglass_started.
1461 * dispextern.h (hourglass_started):
1462 * w32fns.c (hourglass_started):
1463 * xdisp.c (hourglass_started): Remove.
1465 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1467 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1468 Update dependencies.
1470 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1472 * xgselect.c (xg_select): Put maxfds+1 into a var.
1473 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1475 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1477 2012-05-10 Dave Abrahams <dave@boostpro.com>
1479 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1480 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1482 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1484 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1485 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1486 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1487 Initialize xd_registered_buses.
1489 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1491 Untag more efficiently if USE_LSB_TAG.
1492 This is based on a proposal by YAMAMOTO Mitsuharu in
1493 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1494 For an admittedly artificial (nth 8000 longlist) benchmark on
1495 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1496 Emacs's overall text size by 1%.
1497 * lisp.h (XUNTAG): New macro.
1498 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1499 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1500 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1501 * eval.c (Fautoload):
1502 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1503 * frame.h (XFRAME): Use XUNTAG.
1505 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1506 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1507 Remove unportable assumptions about print widths of types like
1509 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1510 intptr_t when converting between pointer and integer, to avoid GCC
1511 warnings about wrong width.
1513 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1515 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1516 stack for each reader_thread, instead of defaulting to 8MB
1517 determined by the linker. This avoids failures in creating
1518 subprocesses on Windows 7, see the discussion in this thread:
1519 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1521 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1523 Fix up display of the *Minibuf-0* buffer in the mini window.
1524 * keyboard.c (read_char): Don't clear the echo area if there's no
1526 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1527 contents of *Minibuf-0*) if there's no message displayed in its stead.
1529 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1531 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1534 2012-05-06 Chong Yidong <cyd@gnu.org>
1536 * lisp.mk (lisp): Update.
1538 2012-05-05 Jim Meyering <meyering@redhat.com>
1540 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1542 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1544 * data.c (PUT_ERROR): New macro.
1545 (syms_of_data): Use it. Add new error type `user-error'.
1546 * undo.c (user_error): New function.
1547 (Fprimitive_undo): Use it.
1548 * print.c (print_error_message): Adjust print style for `user-error'.
1549 * keyboard.c (user_error): New function.
1550 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1552 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1554 Do not limit current-time-string to years 1000..9999.
1555 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1556 (Fcurrent_time_string): Support any year that is supported by the
1557 underlying localtime representation. Don't use asctime, as it
1558 has undefined behavior for years outside the range -999..9999.
1560 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1562 Fix race conditions involving setenv, gmtime, localtime, asctime.
1563 Without this fix, interrupts could mess up code that uses these
1564 nonreentrant functions, since setting TZ invalidates existing
1565 tm_zone or tzname values, and since most of these functions return
1566 pointers to static storage.
1567 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1568 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1569 Grow the critical sections to include not just invoking
1570 localtime/gmtime, but also accessing these functions' results
1571 including their tm_zone values if any, and any related TZ setting.
1572 (format_time_string): Last arg is now struct tm *, not struct tm **,
1573 so that the struct tm is saved in the critical section.
1574 All callers changed. Simplify allocation of initial buffer, partly
1575 motivated by the fact that memory allocation needs to be outside
1576 the critical section.
1578 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1580 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1581 with RESET_INTERVAL.
1583 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1584 Remove duplicated buffer name initialization.
1586 2012-05-02 Jim Meyering <jim@meyering.net>
1588 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1590 * xfns.c (x_window): Use xstrdup (Bug#11375).
1592 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1594 * xdisp.c (pos_visible_p): If already at a newline from the
1595 display string before the 'while' loop, don't walk back the glyphs
1596 from it3.glyph_row. Solves assertion violation when the display
1597 string begins with a newline (egg.el). (Bug#11367)
1599 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1601 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1604 2012-05-01 Glenn Morris <rgm@gnu.org>
1606 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1607 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1608 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1609 All were removed before 23.1.
1611 * dispnew.c: Remove HAVE_LIBNCURSES test;
1612 it is always true on relevant platforms.
1614 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1615 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1617 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1619 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1621 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1622 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1625 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1627 Do not avoid creating empty evaporating overlays (Bug#9642).
1628 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1629 That is, do not delete an evaporating overlay if it becomes
1630 empty after its bounds are adjusted to fit within its buffer.
1631 This fix caused other problems, and I'm reverting it until we get
1632 to the bottom of them.
1634 2012-04-27 Chong Yidong <cyd@gnu.org>
1636 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1638 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1640 * xdisp.c (pos_visible_p): If the window start position is beyond
1641 ZV, start the display from buffer beginning. Prevents assertion
1642 violation in init_iterator when the minibuffer window is scrolled
1645 * window.c (window_scroll_pixel_based): Likewise.
1647 2012-04-27 Chong Yidong <cyd@gnu.org>
1649 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1651 2012-04-27 Glenn Morris <rgm@gnu.org>
1653 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1654 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1656 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1658 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1659 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1661 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1663 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1664 display element, check also the underlying string or buffer
1665 character. (Bug#11341)
1667 * w32menu.c: Include w32heap.h.
1668 (add_menu_item): If the call to AppendMenuW (via
1669 unicode_append_menu) fails, disable Unicode menus only if we are
1670 running on Windows 9X/Me.
1672 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1674 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1675 (xgetint): Add missing shift for LSB tags.
1677 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1679 * keyboard.c (read_char): Don't wipe echo area for select window
1680 events: These might get delayed via `mouse-autoselect-window'
1683 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1685 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1686 manipulation of :loaded-from data.
1688 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1690 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1691 now a cons (bug#11311).
1693 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1695 Do not create empty overlays with the evaporate property (Bug#9642).
1696 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1697 if it becomes empty after its bounds are adjusted to fit within
1698 its buffer. Without this fix, in a nonempty buffer (let ((o
1699 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1700 yields an empty overlay that has the evaporate property, which is
1701 not supposed to happen.
1703 Fix minor GTK3 problems found by static checking.
1704 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1705 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1706 (struct _EmacsFixedClass, emacs_fixed_get_type):
1707 Move decls here from emacsgtkfixed.h, since they needn't be public.
1708 (emacs_fixed_get_type): Now static.
1709 (emacs_fixed_class_init): Omit unused local.
1710 (emacs_fixed_child_type): Remove; unused.
1711 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1712 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1713 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1714 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1715 (EMACS_FIXED_GET_CLASS): Remove; unused.
1716 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1718 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1719 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1721 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1723 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1724 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1725 (__malloc_size_t, __malloc_ptrdiff_t):
1726 Remove. All uses removed, replaced by the definiens if needed,
1727 since we can assume C89 or better now.
1728 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1729 (protect_malloc_state, align, get_contiguous_space)
1730 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1731 (malloc_atfork_handler_child, malloc_enable_thread)
1732 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1733 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1734 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1735 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1736 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1737 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1738 Define using prototypes, not old style.
1739 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1740 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1741 (align): Don't assume that signed integer overflow wraps around.
1742 Omit unused local var.
1743 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1744 (_free_internal_nolock, memalign, mallochook, reallochook):
1745 Omit no-longer-needed casts.
1746 (valloc): Use getpagesize, not __getpagesize.
1747 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1748 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1750 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1752 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1754 Move functions from C to Lisp. Make non-blocking method calls
1755 the default. Implement further D-Bus standard interfaces.
1757 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1758 (QCdbus_request_name_allow_replacement)
1759 (QCdbus_request_name_replace_existing)
1760 (QCdbus_request_name_do_not_queue)
1761 (QCdbus_request_name_reply_primary_owner)
1762 (QCdbus_request_name_reply_in_queue)
1763 (QCdbus_request_name_reply_exists)
1764 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1765 (QCdbus_registered_serial, QCdbus_registered_method)
1766 (QCdbus_registered_signal): New Lisp objects.
1767 (XD_DEBUG_MESSAGE): Use sizeof.
1768 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1769 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1770 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1771 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1772 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1773 (xd_signature, xd_append_arg): Allow float for integer types.
1774 (xd_get_connection_references): New function.
1775 (xd_get_connection_address): Rename from xd_initialize.
1776 Return cached address.
1777 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1778 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1780 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1781 Return number of refcounts.
1782 (Fdbus_get_unique_name): Make stronger parameter check.
1783 (Fdbus_message_internal): New defun.
1784 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1785 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1786 (Fdbus_send_signal, Fdbus_register_service)
1787 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1788 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1789 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1790 (Vdbus_compiled_version, Vdbus_runtime_version)
1791 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1792 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1793 (Vdbus_message_type_signal): New defvars.
1794 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1797 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1799 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1800 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1801 Do not assume ptrdiff_t is the same width as 'int'.
1803 * alloc.c: Handle unusual debugging option combinations.
1804 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1805 since the two debugging options are incompatible.
1806 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1808 (mem_init, mem_insert, mem_insert_fixup):
1809 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1810 (NEED_MEM_INSERT): Remove; no longer needed.
1812 2012-04-22 Leo Liu <sdl.web@gmail.com>
1814 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1816 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1818 * sysdep.c [__FreeBSD__]: Minor cleanups.
1819 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1820 Use Emacs indenting style more consistently. Avoid some casts.
1821 Use 'double' consistently rather than mixing 'float' and 'double'.
1823 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1825 * sysdep.c (list_system_processes, system_process_attributes):
1826 Add implementation for FreeBSD (Bug#5243).
1828 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1830 * lisp.mk (lisp): Update.
1832 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1834 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1835 It is never used otherwise.
1837 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1839 * print.c (print_preprocess): Only check print_depth if print-circle
1841 (print_object): Check for cycles even when print-circle is nil and
1842 print-gensym is t, but only check print_depth if print-circle is nil.
1844 2012-04-20 Chong Yidong <cyd@gnu.org>
1846 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1847 set the status to "failed" and ensure that sentinel is run.
1849 2012-04-20 Glenn Morris <rgm@gnu.org>
1851 * process.c (Fset_process_inherit_coding_system_flag)
1852 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1853 (Fmake_network_process, Fmake_serial_process): Doc fix.
1855 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (string_buffer_position_lim): Limit starting position to
1859 (set_cursor_from_row): If called for a mode-line or header-line
1860 row, return zero immediately.
1861 (try_cursor_movement): If inside continuation line, don't back up
1862 farther than the first row after the header line, if any.
1863 Don't consider the header-line row as "partially visible", even if
1864 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1866 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1868 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1871 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1872 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1874 configure: new option --enable-gcc-warnings (Bug#11207)
1875 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1876 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1877 (ALL_CFLAGS): Use new macros rather than old.
1878 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1879 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1880 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1881 -Wunused-result, -Wunused-variable. This should go away once
1882 the Emacs and Gnulib regex code is merged.
1883 (xmalloc, xrealloc): Now static.
1885 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1887 * dired.c (Fsystem_groups): Remove unused local.
1889 2012-04-17 Glenn Morris <rgm@gnu.org>
1891 * dired.c (Fsystem_users): Doc fix.
1893 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1895 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1896 (syms_of_dired): Add them.
1898 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1900 Fix minor alloc.c problems found by static checking.
1901 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1902 New extern decls, to avoid calling undeclared functions.
1903 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1904 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1905 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1906 (NEED_MEM_INSERT): New macro.
1907 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1908 Remove one incorrect comment and fix another.
1910 Fix minor ralloc.c problems found by static checking.
1911 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1912 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1913 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1914 (r_alloc_sbrk): Now static.
1916 Improve ralloc.c interface checking.
1917 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1918 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1919 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1920 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1921 [REL_ALLOC]: ... to here, to check interface.
1922 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1923 Remove decls. This fixes an "It stinks!".
1925 * alloc.c (which_symbols): Fix alignment issue / type clash.
1927 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1929 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1930 (struct Lisp_Misc_Any): Likewise.
1931 (struct Lisp_Free): Likewise.
1932 * alloc.c (union aligned_Lisp_Symbol): Define.
1933 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1934 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1935 (union aligned_Lisp_Misc): Define.
1936 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1937 aligned_Lisp_Misc instead of union Lisp_Misc.
1938 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1940 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1942 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1943 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1944 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1945 * s/netbsd.h, s/sol2-6.h:
1946 Remove definition of GC_MARK_STACK, since the default now works.
1947 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1948 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1949 no longer the default.
1950 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1952 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1954 * lread.c (lisp_file_lexically_bound_p):
1955 Fix hang at ";-*-\n" (bug#11238).
1957 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1960 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1962 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1964 * nsterm.m (constrainFrameRect): Always constrain when there is only
1965 one screen (Bug#10962).
1967 2012-04-13 Ken Brown <kbrown@cornell.edu>
1969 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1971 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1973 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1975 2012-04-11 Daniel Colascione <dancol@dancol.org>
1977 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1978 against is gone. It's better to use vfork now so that when Cygwin
1979 gains a new, working vfork, we use it automatically (bug#10398).
1981 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1983 * window.c (save_window_save): Obey window-point-insertion-type.
1985 2012-04-11 Glenn Morris <rgm@gnu.org>
1987 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1989 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1991 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1993 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1995 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1996 (force_quit_count): New var.
1997 (handle_interrupt): Use it.
1999 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2001 * w32.c (w32_delayed_load): Record the full path of the library
2002 being loaded (bug#10424).
2004 2012-04-09 Glenn Morris <rgm@gnu.org>
2006 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2007 not just in the obarray, before snarfing them. (Bug#11036)
2009 * Makefile.in ($(leimdir)/leim-list.el):
2010 Pass EMACS rather than BUILT_EMACS.
2012 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2014 * process.c (make_process):
2015 * process.h: Add integer `gnutls_handshakes_tried' member to
2018 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2019 Add convenience `GNUTLS_LOG2i' macro.
2021 * gnutls.c (gnutls_log_function2i): Convenience log function.
2022 (emacs_gnutls_read): Use new log functions,
2023 `gnutls_handshakes_tried' process member, and
2024 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2025 attempts per process (connection).
2027 2012-04-09 Chong Yidong <cyd@gnu.org>
2029 * eval.c (Fuser_variable_p, user_variable_p_eh)
2030 (lisp_indirect_variable): Functions deleted.
2031 (Fdefvar): Caller changed.
2033 * callint.c (Finteractive, Fcall_interactively):
2034 * minibuf.c (Fread_variable): Callers changed.
2036 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2038 * xdisp.c (set_cursor_from_row): If the display string appears in
2039 the buffer at position that is closer to point than the position
2040 after the display string, display the cursor on the first glyph of
2041 the display string. Fixes cursor display when a 'display' text
2042 property immediately follows invisible text. (Bug#11094)
2044 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2046 composite.c: use 'double' consistently
2047 * composite.c (get_composition_id): Use 'double' consistently
2048 instead of converting 'float' to 'double' and vice versa; this is
2049 easier to understand and avoids a GCC warning.
2051 2012-04-09 Glenn Morris <rgm@gnu.org>
2053 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2054 preparation for dumping it with emacs. (Bug#4789)
2055 (leimdir): New variable.
2056 ($(leimdir)/leim-list.el): New rule.
2057 (emacs$(EXEEXT)): Depend on leim-list.el.
2059 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2060 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2061 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2063 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2065 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2068 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2070 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2071 Remove unused local variable.
2073 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2075 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2076 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2077 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2078 objects, as mark_maybe_pointer will catch them otherwise.
2079 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2080 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2082 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2084 Fix typo that broke non-Windows builds.
2085 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2087 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2089 Support building on MS-Windows with libxml2.
2091 * makefile.w32-in (OBJ2): Add xml.$(O).
2092 (GLOBAL_SOURCES): Add xml.c.
2093 ($(BLD)/xml.$(O)): New dependency list.
2095 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2096 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2097 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2098 [!WINDOWSNT]: New macros.
2099 (init_libxml2_functions, libxml2_loaded_p): New functions.
2100 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2101 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2102 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2103 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2105 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2106 Call init_libxml2_functions before calling libxml2 functions.
2107 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2109 * emacs.c: Don't include libxml/parser.h.
2110 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2111 xmlCleanupParser directly.
2113 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2115 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2117 * indent.c (Fvertical_motion): If there is a display string at
2118 point, use it.vpos to compute how many lines to backtrack after
2119 move_it_to point. (Bug#11133)
2121 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2123 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2124 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2125 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2126 macros related to unification of CJK characters. For the details,
2127 see the discussion following the message here:
2128 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2130 2012-04-04 Chong Yidong <cyd@gnu.org>
2132 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2134 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2136 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2137 instead of alloca. (Bug#11138)
2139 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2141 * w32menu.c (is_simple_dialog): Properly check lisp types.
2144 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2147 position we get to after a call to move_it_to fails the
2148 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2149 only if we wind up in a string from display property. (Bug#11063)
2151 * window.c (Fdelete_other_windows_internal): Invalidate the row
2152 and column information about mouse highlight, so that redisplay
2153 restores it after reallocating the glyph matrices. (Bug#7464)
2155 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2156 string comes from a `display' text property, use the buffer
2157 position of that property as if we actually saw that position in
2159 (move_it_by_lines): Remove the assertion that
2160 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2161 violated when there's a before-string at the beginning of a line.
2164 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2166 * xdisp.c (append_space_for_newline): If the default face was
2167 remapped, use the remapped face for the appended newline.
2168 (extend_face_to_end_of_line): Use the remapped default face for
2169 extending the face to the end of the line.
2170 (display_line): Call extend_face_to_end_of_line when the default
2171 face was remapped. (Bug#11068)
2173 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2175 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2177 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2179 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2181 2012-03-27 Glenn Morris <rgm@gnu.org>
2183 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2186 2012-03-26 Kenichi Handa <handa@m17n.org>
2188 * dispextern.h (struct glyph): Fix previous change. Change the
2189 bit length of glyphless.ch to 25 (Bug#11082).
2191 2012-03-26 Chong Yidong <cyd@gnu.org>
2193 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2194 (command_loop_1): Use it; inhibit selection update for
2195 handle-select-window too (Bug#8996).
2197 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2199 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2201 2012-03-25 Kenichi Handa <handa@m17n.org>
2203 * dispextern.h (struct glyph): Change the bit length of
2204 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2206 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2208 * s/ms-w32.h (tzname): Include time.h before redirecting to
2209 _tzname. Fixes the MSVC build. (Bug#9960)
2211 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2213 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2216 * xterm.c (XTread_socket): Only modify handling_signal if
2217 !SYNC_INPUT. (Bug#11080)
2219 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2221 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2222 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2223 when fetching a multibyte character consumes more bytes than
2224 CHAR_BYTES returns, due to unification of CJK characters in
2225 string_char. (Bug#11073)
2227 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2229 * process.c (wait_reading_process_output): Handle pty disconnect
2230 by refraining from sending oneself a SIGCHLD (bug#10933).
2232 2012-03-22 Chong Yidong <cyd@gnu.org>
2234 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2236 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2237 Mark string as coming from a prefix property.
2238 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2239 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2241 2012-03-21 Chong Yidong <cyd@gnu.org>
2243 * xfaces.c (Vface_remapping_alist): Doc fix.
2245 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2247 * w32proc.c (Fw32_set_console_codepage)
2248 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2251 2012-03-20 Chong Yidong <cyd@gnu.org>
2253 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2254 to reflect default non-nil value of redisplay-dont-pause.
2256 2012-03-19 Kenichi Handa <handa@m17n.org>
2258 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2259 it fit in a valid range (Bug#11003).
2261 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2263 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2264 that is not from display property, accept the row as a "cursor
2265 row" if one of the string's character has a non-nil `cursor'
2266 property. Fixes cursor positioning when there are newlines in
2267 overlay strings, e.g. in icomplete.el. (Bug#11035)
2269 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2271 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2273 2012-03-12 Chong Yidong <cyd@gnu.org>
2275 * eval.c (inhibit_lisp_code): Rename from
2276 inhibit_window_configuration_change_hook; move from window.c.
2278 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2279 * window.c (run_window_configuration_change_hook)
2280 (syms_of_window): Callers changed.
2282 2012-03-11 Chong Yidong <cyd@gnu.org>
2284 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2286 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2288 2012-03-10 Chong Yidong <cyd@gnu.org>
2290 * frame.c (other_visible_frames): Don't assume the selected frame
2291 is visible (Bug#10955).
2293 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2295 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2297 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2299 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2300 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2303 2012-03-03 Glenn Morris <rgm@gnu.org>
2305 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2307 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2309 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2310 position past the first glyph_row that ends at ZV. (Bug#10902)
2311 (redisplay_window, next_element_from_string): Fix typos in
2313 (redisplay_window): Pass to move_it_vertically the margin in
2314 pixels, not in screen lines.
2316 2012-03-02 Glenn Morris <rgm@gnu.org>
2318 * buffer.c (buffer-list-update-hook): Doc fix.
2320 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2323 push_it before setting up the iterator for the first overlay
2324 string, even if we have an empty string loaded.
2325 (next_overlay_string): If there's an empty string on the iterator
2326 stack, pop the stack. (Bug#10903)
2328 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2330 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2331 Suggested by Stefan Monnier in
2332 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2333 * alloc.c (widen_to_Lisp_Object): New static function.
2334 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2335 and widening them to Lisp_Objects. This would work even if
2336 USE_LSB_TAG is defined and wide integers are used, which might
2337 happen in a future version of Emacs.
2339 2012-02-25 Chong Yidong <cyd@gnu.org>
2341 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2344 * xselect.c (Fx_selection_exists_p): Doc fix.
2345 (x_clipboard_manager_save_all): Print an informative message
2346 before saving to clipboard manager.
2348 2012-02-24 Chong Yidong <cyd@gnu.org>
2350 * keyboard.c (process_special_events): Handle all X selection
2351 requests in kbd_buffer, not just the next one (Bug#8869).
2353 2012-02-23 Chong Yidong <cyd@gnu.org>
2355 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2356 call when setting menu-bar-lines and tool-bar-lines parameters.
2357 (unwind_create_frame_1): New helper function.
2359 * window.c (inhibit_window_configuration_change_hook): New var.
2360 (run_window_configuration_change_hook): Obey it.
2361 (syms_of_window): Initialize it.
2363 2012-02-22 Chong Yidong <cyd@gnu.org>
2365 * xterm.c (x_draw_image_relief): Add missing type check for
2366 Vtool_bar_button_margin (Bug#10743).
2368 2012-02-21 Chong Yidong <cyd@gnu.org>
2370 * fileio.c (Vfile_name_handler_alist): Doc fix.
2372 * buffer.c (Fget_file_buffer): Protect against invalid file
2373 handler return value.
2375 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2377 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2378 when computing $valmask.
2380 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2381 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2382 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2383 It's useless in that case, and it can cause problems on hosts
2384 that allocate halves of EMACS_INT values separately.
2385 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2386 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2387 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2388 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2389 it avoids undefined behavior on hosts where shifting right by more
2390 than the word width has undefined behavior.
2392 2012-02-19 Chong Yidong <cyd@gnu.org>
2394 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2395 (Funhandled_file_name_directory, Ffile_name_as_directory)
2396 (Fdirectory_file_name, Fexpand_file_name)
2397 (Fsubstitute_in_file_name): Protect against invalid file handler
2398 return values (Bug#10845).
2400 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2402 * .gdbinit (pitx): Fix incorrect references to fields of the
2405 2012-02-17 Chong Yidong <cyd@gnu.org>
2407 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2409 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2411 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2412 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2414 2012-02-15 Chong Yidong <cyd@gnu.org>
2416 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2417 marked as special. Also, starting docstrings with * is obsolete.
2419 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2421 * gnutls.c (emacs_gnutls_write): Fix last change.
2423 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2425 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2428 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2430 * keymap.c (Fsingle_key_description): Handle char ranges.
2432 2012-02-12 Chong Yidong <cyd@gnu.org>
2434 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2435 as that creates a dangerous corner case.
2437 * window.c (Fdelete_window_internal): Invalidate the mouse
2438 highlight (Bug#9904).
2440 2012-02-12 Glenn Morris <rgm@gnu.org>
2442 * xselect.c (Fx_own_selection_internal)
2443 (Fx_get_selection_internal, Fx_disown_selection_internal)
2444 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2445 * nsselect.m (Fx_own_selection_internal)
2446 (Fx_disown_selection_internal, Fx_selection_exists_p)
2447 (Fx_selection_owner_p, Fx_get_selection_internal):
2448 Sync docs and argument specs with the xselect.c versions.
2450 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2452 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2454 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2456 * w32select.c (Fx_selection_exists_p): Sync doc string and
2457 argument list with xselect.c. (Bug#10783)
2459 * w16select.c (Fx_selection_exists_p): Sync doc string and
2460 argument list with xselect.c. (Bug#10783)
2462 2012-02-10 Glenn Morris <rgm@gnu.org>
2464 * fns.c (Fsecure_hash): Doc fix.
2466 2012-02-09 Kenichi Handa <handa@m17n.org>
2468 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2470 2012-02-07 Chong Yidong <cyd@gnu.org>
2472 * buffer.c (Fbuffer_local_variables)
2473 (buffer_lisp_local_variables): Handle unbound vars correctly;
2474 don't let Qunbound leak into Lisp.
2476 2012-02-07 Glenn Morris <rgm@gnu.org>
2478 * image.c (Fimagemagick_types): Doc fix.
2480 * image.c (imagemagick-render-type): Change it from a lisp object
2481 to an integer. Move the doc here from the lisp manual.
2482 Treat all values not equal to 0 the same.
2484 2012-02-06 Chong Yidong <cyd@gnu.org>
2486 * doc.c (store_function_docstring): Avoid applying docstring of
2487 alias to base function (Bug#2603).
2489 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2491 * .gdbinit (pp1, pv1): Remove redundant defines.
2494 2012-02-04 Chong Yidong <cyd@gnu.org>
2496 * nsterm.m: Declare a global (Bug#10694).
2498 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2500 * w32.c (get_emacs_configuration_options):
2501 Include --enable-checking, if specified, in the return value.
2503 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2505 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2506 after rounding frame sizes. (Bug#9723)
2508 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2510 * keyboard.c (adjust_point_for_property): Don't position point
2511 before BEGV. (Bug#10696)
2513 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2515 Handle overflow when computing char display width (Bug#9496).
2516 * character.c (char_width): Return EMACS_INT, not int.
2517 (char_width, c_string_width): Check for overflow when
2518 computing the width; this is possible now that individual
2519 characters can have unbounded width. Problem introduced
2520 by merge from Emacs 23 on 2012-01-19.
2522 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2524 * dbusbind.c (Fdbus_register_method): Mention the return value
2525 :ignore in the docstring.
2527 2012-02-02 Glenn Morris <rgm@gnu.org>
2529 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2531 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2532 Unconditionally set to t. (Bug#10673)
2533 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2534 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2535 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2537 2012-02-02 Kenichi Handa <handa@m17n.org>
2539 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2540 0, do not call append_composite_glyph.
2542 2012-02-02 Kenichi Handa <handa@m17n.org>
2544 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2546 (x_produce_glyphs): If the component of a composition is a null
2547 string, set it->pixel_width to 1 to avoid zero-width glyph.
2549 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2551 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2552 first 2 arguments are identical. This makes inserting large
2553 output from a subprocess an order of magnitude faster on
2554 MS-Windows, where all sbrk'ed memory is always contiguous.
2556 2012-01-31 Glenn Morris <rgm@gnu.org>
2558 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2559 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2560 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2562 2012-01-29 Glenn Morris <rgm@gnu.org>
2564 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2566 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2568 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2570 2012-01-28 Chong Yidong <cyd@gnu.org>
2572 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2574 2012-01-26 Chong Yidong <cyd@gnu.org>
2576 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2578 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2579 repeat counts (Bug#10507).
2581 2012-01-26 Glenn Morris <rgm@gnu.org>
2583 * lread.c (syms_of_lread): Doc fix.
2585 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2587 * coding.c (encode_designation_at_bol): Change return value to
2590 2012-01-25 Chong Yidong <cyd@gnu.org>
2592 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2594 2012-01-21 Chong Yidong <cyd@gnu.org>
2596 * floatfns.c (Fcopysign): Make the second argument non-optional,
2597 since nil is not allowed anyway.
2599 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2601 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2602 (send_process): Likewise.
2604 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2606 * window.c (save_window_save, Fcurrent_window_configuration)
2607 (Vwindow_persistent_parameters): Do not use Qstate.
2608 Rewrite doc-strings.
2610 2012-01-19 Kenichi Handa <handa@m17n.org>
2612 * character.c (char_width): New function.
2613 (Fchar_width, c_string_width, lisp_string_width):
2614 Use char_width (Bug#9496).
2616 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2618 * window.c (Vwindow_persistent_parameters): New variable.
2619 (Fset_window_configuration, save_window_save): Handle persistent
2622 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2624 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2625 thrashing the stack of the thread. (Bug#9087)
2627 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2629 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2631 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2633 * xdisp.c (rows_from_pos_range): Handle the case where the
2634 highlight ends on a newline. (Bug#10464)
2635 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2636 he end column for display of highlight that ends on a newline
2639 2012-01-11 Glenn Morris <rgm@gnu.org>
2641 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2642 from load-path also when installation-directory is nil. (Bug#10208)
2644 2012-01-10 Glenn Morris <rgm@gnu.org>
2646 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2648 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2649 Update template values to be closer to their typical values these days.
2651 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2653 * xdisp.c (rows_from_pos_range): Accept additional argument
2654 DISP_STRING, and accept any glyph in a row whose object is that
2655 string as eligible for mouse highlight. Fixes mouse highlight of
2656 display strings from overlays. (Bug#10464)
2658 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2660 emacs: fix an auto-save permissions race condition (Bug#10400)
2661 * fileio.c (auto_saving_dir_umask): New static var.
2662 (Fmake_directory_internal): Use it.
2663 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2664 creating the directory. The old code temporarily assigns
2665 too-generous permissions to the directory.
2666 (do_auto_save_eh): Clear it.
2667 (Fdo_auto_save): Catch all errors, not just file errors, so
2668 that the var is always cleared.
2670 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2672 * search.c (scan_buffer): Pass character positions to
2673 know_region_cache, not byte positions. (Bug#6540)
2675 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2677 * w32.c (sys_rename): Report EXDEV when rename of a directory
2678 fails because the target is on another logical disk. (Bug#10284)
2680 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2682 * xterm.c (x_embed_request_focus): New function.
2684 * xterm.h: Add prototype.
2686 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2688 2012-01-05 Glenn Morris <rgm@gnu.org>
2690 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2692 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2694 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2695 Load gnutls_transport_set_lowat only if GnuTLS version is below
2697 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2698 GnuTLS versions below 2.11.1.
2700 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2702 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2703 to the doc string advising against its use for altering the way
2704 windows are scrolled.
2706 2011-12-28 Kenichi Handa <handa@m17n.org>
2708 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2709 coding-system ASCII compatible only when it does not produce BOM
2710 on encoding (Bug#10383).
2712 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2714 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2716 (create_and_show_popup_menu): Always use menu_position_func for
2719 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2721 * callint.c (Fcall_interactively): Don't truncate prompt string.
2723 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2725 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2726 property that ends at ZV, so that the bidi iteration could be
2727 resumed from there (after widening). (Bug#10360)
2729 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2731 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2733 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2735 * nsterm.m (x_free_frame_resources):
2736 Release f->output_data.ns->miniimage.
2737 (ns_index_color): Fix indentation. Do not retain
2738 color_table->colors[i].
2740 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2743 * nsfns.m (x_set_background_color): Assign return value from
2744 ns_index_color to face-background instead of NSColor*.
2745 (ns_implicitly_set_icon_type): Fix indentation.
2746 Change assignment in for loop to comparison.
2748 * emacs.c (ns_pool): New variable.
2749 (main): Assign ns_pool.
2750 (Fkill_emacs): Call ns_release_autorelease_pool.
2752 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2753 autorelease fdesc, release fdAttrs and tdict.
2754 (ns_get_covering_families): Release charset.
2755 (ns_findfonts): Release NSFontDescriptor created with new.
2756 (ns_uni_to_glyphs): Fix indentation.
2757 (setString): Release attrStr before assigning new value.
2759 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2761 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2763 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2764 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2766 2011-12-18 David Reitter <reitter@cmu.edu>
2768 * nsterm.m (ns_term_init): Subscribe for notifications
2769 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2770 to method trackingNotification in EmacsMenu.
2772 * nsmenu.m (trackingMenu): New variable.
2773 (trackingNotification): New method (from Aquamacs).
2774 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2775 from Aquamacs (Bug#7030).
2777 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2779 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2780 (symbol_to_nsstring): Fix indentation.
2781 (ns_symbol_to_pb): New function.
2782 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2783 (Fns_rotate_cut_buffers_internal): Remove.
2784 (Fns_store_selection_internal): Rename from
2785 Fns_store_cut_buffer_internal.
2786 (ns_get_foreign_selection, Fx_own_selection_internal)
2787 (Fx_disown_selection_internal, Fx_selection_exists_p)
2788 (Fns_get_selection_internal, Fns_store_selection_internal):
2789 Use ns_symbol_to_pb and check if return value is nil.
2790 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2791 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2792 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2793 renamed to Sns_store_selection_internal.
2794 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2795 and remove this function.
2796 (ns_handle_selection_clear): Remove, never used.
2797 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2800 2011-12-17 Ken Brown <kbrown@cornell.edu>
2802 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2803 GID is unknown (Bug#10257).
2805 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2807 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2808 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2809 which caused a build failure on GNU/Linux IA-64. This problem was
2810 introduced by my 2011-10-07 patch.
2812 2011-12-15 Juri Linkov <juri@jurta.org>
2814 * image.c (imagemagick_error): New function. (Bug#10112)
2815 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2816 Use `imagemagick_error' where ImageMagick functions return
2818 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2821 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2823 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2824 fill background (Bug#8992).
2826 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2828 * window.c (Vwindow_combination_resize)
2829 (Vwindow_combination_limit): Use t instead of non-nil in
2831 (Vrecenter_redisplay): Add first sentence of doc-string on
2833 (Frecenter): Fix doc-string typo.
2835 2011-12-11 Kenichi Handa <handa@m17n.org>
2837 * coding.c (Funencodable_char_position): Pay attention to the
2838 buffer text relocation (Bug#9389).
2840 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2842 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2843 gtk_init (Bug#10100).
2845 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2847 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2848 IT->string is nil. (Bug#10263)
2850 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2852 * nsterm.h (x_free_frame_resources): Declare.
2854 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2855 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2857 * nsterm.h (ns_get_defaults_value): Declare.
2859 * nsterm.m (ns_default): Call ns_get_defaults_value.
2861 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2863 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2866 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2868 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2869 that where the value of an _OBJC_* symbol points to is in the .bss
2870 section (Bug#10240).
2872 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2874 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2875 after the loop to call ccl_driver at least once (Bug#8619).
2877 2011-12-08 Kenichi Handa <handa@m17n.org>
2879 * ftfont.c (get_adstyle_property): Fix previous change
2882 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2884 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2885 dirs from the default value of EMACSLOADPATH (bug#10208).
2887 2011-12-07 Glenn Morris <rgm@gnu.org>
2889 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2890 installation and source directories as well. (Bug#10208)
2892 2011-12-06 Chong Yidong <cyd@gnu.org>
2894 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2896 2011-12-06 Glenn Morris <rgm@gnu.org>
2898 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2899 as an error, not just -1. (Bug#10217)
2901 2011-12-05 Chong Yidong <cyd@gnu.org>
2903 * keyboard.c (process_special_events): New function.
2904 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2906 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2908 * coding.c (encode_designation_at_bol): Don't use uninitialized
2909 local variable (Bug#9318).
2911 2011-12-05 Kenichi Handa <handa@m17n.org>
2913 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2914 return Qnil (Bug#8046, Bug#10193).
2916 2011-12-05 Kenichi Handa <handa@m17n.org>
2918 * coding.c (encode_designation_at_bol): New args charbuf_end and
2919 dst. Return the number of produced bytes. Callers changed.
2920 (coding_set_source): Return how many bytes coding->source was
2922 (coding_set_destination): Return how many bytes
2923 coding->destination was relocated.
2924 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2925 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2927 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2929 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2930 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2933 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2935 The following changes are to fix Bug#9318.
2937 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2938 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2939 (encode_coding_iso_2022, encode_coding_sjis)
2940 (encode_coding_big5, encode_coding_charset): Use the above macros.
2942 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2944 * lisp.h (process_quit_flag): Fix external declaration.
2946 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2948 Don't macro-inline non-performance-critical code.
2949 * eval.c (process_quit_flag): New function.
2950 * lisp.h (QUIT): Use it.
2952 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2954 * nsfns.m (get_geometry_from_preferences): New function.
2955 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2957 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2959 * emacs.c (Qkill_emacs): Define.
2960 (syms_of_emacs): Initialize it.
2961 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2962 Qquit_flag to `kill-emacs' instead.
2963 (quit_throw_to_read_char): Add parameter `from_signal'.
2964 All callers changed. Call Fkill_emacs if requested and safe.
2965 * lisp.h (QUIT): Call Fkill_emacs if requested.
2967 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2969 * widget.c (update_wm_hints): Return if wmshell is null.
2970 (widget_update_wm_size_hints): New function.
2972 * widget.h (widget_update_wm_size_hints): Declare.
2974 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2975 widget_update_wm_size_hints (Bug#10104).
2977 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2979 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2980 before a newline, prepare the bidi iterator for consuming the
2981 newline, and keep the current paragraph direction. (Bug#10183)
2982 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2984 2011-12-02 Juri Linkov <juri@jurta.org>
2986 * search.c (Fword_search_regexp): New Lisp function created from
2987 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2988 (Fword_search_backward, Fword_search_forward)
2989 (Fword_search_backward_lax, Fword_search_forward_lax):
2990 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2991 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2993 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2995 * fileio.c (Finsert_file_contents): Move after-change-function call
2996 to before the "handled:" label, since all "goto handled" appear in
2997 cases where the *-change-functions have already been properly called
3000 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3002 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3003 waiting for input. (Bug#10169)
3005 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3007 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3008 verifies glyph row's hash code--we have just reallocated the
3009 glyphs, so their contents can be complete garbage. (Bug#10164)
3011 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3013 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3015 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3017 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3018 attributes are tested _before_ calling verify_row_hash, to protect
3019 against GCC re-ordering of the tests. (Bug#10164)
3021 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3023 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3025 * xterm.c (handle_one_xevent): Only set async_visible and friends
3026 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3027 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3028 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3030 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3032 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3033 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3034 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3035 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3036 All uses changed to use GCPRO1 etc.
3037 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3038 Revert to old implementation (i.e., before 2011-03-11).
3040 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3042 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3043 of scroll runs so as to avoid assigning disabled bogus rows and
3044 unnecessary graphics copy operations.
3046 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3048 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3049 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3050 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3051 (malloc, free, realloc, calloc): Redirect to e_* only when
3054 * lisp.h (GCTYPEBITS): Move before first use.
3055 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3056 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3057 this macro definition.
3059 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3062 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3064 * gtkutil.c (xg_create_frame_widgets):
3065 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3066 present with Gtk+ 2.0.
3068 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3070 * fileio.c (Finsert_file_contents): Undo previous change; see
3071 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3073 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3075 Rename locals to avoid shadowing.
3076 * fileio.c (Finsert_file_contents):
3077 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3078 * process.c (wait_reading_process_output):
3079 Rename inner 'proc' to 'p' to avoid shadowing.
3080 Indent for consistency with usual Emacs style.
3082 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3084 * xdisp.c (redisplay_window): If cursor row is not fully visible
3085 after recentering, and scroll-conservatively is set to a large
3086 number, scroll window by a few more lines to make the cursor fully
3087 visible and out of scroll-margin. (Bug#10105)
3088 (start_display): Don't move to the next line if the display should
3089 start at a newline that is part of a display vector or an overlay
3092 2011-11-24 Juri Linkov <juri@jurta.org>
3094 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3095 after the `MagickPingImage' call. (Bug#10112)
3097 2011-11-23 Chong Yidong <cyd@gnu.org>
3099 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3101 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3103 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3104 making another buffer current. (Bug#10114)
3106 2011-11-23 Glenn Morris <rgm@gnu.org>
3108 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3110 2011-11-23 Chong Yidong <cyd@gnu.org>
3112 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3113 using it (Bug#5984).
3115 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3117 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3118 and header-lines, as they don't have one computed for them.
3121 * .gdbinit (prow): Make displayed values more self-explaining.
3122 Add row's hash code.
3124 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3126 * process.c (wait_reading_process_output): Fix asynchrounous
3127 GnuTLS socket handling on some versions of the GnuTLS library.
3128 (wait_reading_process_output): Add comment and URL.
3130 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3132 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3134 2011-11-21 Chong Yidong <cyd@gnu.org>
3136 * window.c (Fnext_window, Fprevious_window): Doc fix.
3138 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3140 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3142 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3144 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3146 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3148 * window.c (Fset_window_combination_limit): Rename argument
3150 (Vwindow_combination_limit): Remove "status" from doc-string.
3152 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3154 * m/ibms390.h: Remove.
3155 * m/ibms390x.h: Don't include "ibms390.h".
3157 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3159 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3160 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3162 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3164 * casetab.c (Fset_case_table):
3165 * charset.c (Fcharset_after): Fix typos.
3167 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3169 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3170 Otherwise, valgrind does not work on some platforms.
3171 Problem reported by Andreas Schwab in
3172 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3173 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3174 is set, removing the need for VIRT_ADDRESS_VARIES.
3175 (PURE_P): Use a more-efficient implementation that needs just one
3176 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3177 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3178 to 4 (xorl, subq, cmpq, setbe).
3179 * alloc.c (pure): Always extern now, since that's the
3180 VIRT_ADDR_VARIES behavior.
3181 (PURE_POINTER_P): Use a single comparison, not two, for
3182 consistency with the new puresize.h.
3183 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3184 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3185 Remove VIRT_ADDR_VARIES no longer needed.
3187 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3189 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3190 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3191 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3192 behave as if the cursor position were at the window margin.
3194 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3195 and the cursor position is out of bounds, behave as if the cursor
3196 position were at the window margin. (Bug#10075)
3198 2011-11-18 Chong Yidong <cyd@gnu.org>
3200 * window.c (Fwindow_combination_limit): Make first argument
3201 non-optional, since it is meaningless for live windows like the
3204 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3206 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3208 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3210 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3211 (graft_intervals_into_buffer): Simplify.
3213 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3215 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3216 hash values of the two rows.
3217 (copy_row_except_pointers): Preserve the used[] arrays and the
3218 hash values of the two rows. (Bug#10035)
3219 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3221 * xdisp.c (row_hash): New function, body extracted from
3222 compute_line_metrics.
3223 (compute_line_metrics): Call row_hash, instead of computing the
3226 * dispnew.c (verify_row_hash): Call row_hash for computing the
3227 hash code of a row, instead of duplicating code from xdisp.c.
3229 * dispextern.h (row_hash): Add prototype.
3231 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3233 * frame.c (delete_frame): Don't delete the terminal when the last
3234 X frame is closed if emacs is built with GTK toolkit.
3236 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3238 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3240 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3242 * window.c (Vwindow_splits): Rename to
3243 Vwindow_combination_resize. Suggested by Juri Linkov.
3244 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3247 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3249 * nsfns.m (Fns_font_name):
3250 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3252 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3254 * window.h (window): Rename slot "nest" to "combination_limit".
3255 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3256 (Fset_window_nest): Rename to Fset_window_combination_limit.
3257 (Vwindow_nest): Rename to Vwindow_combination_limit.
3258 (recombine_windows, make_parent_window, make_window)
3259 (Fsplit_window_internal, saved_window)
3260 (Fset_window_configuration, save_window_save): Rename all
3261 occurrences of window_nest to window_combination_limit.
3263 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3265 * image.c (imagemagick_load_image): Fix typo.
3267 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3269 * xdisp.c (display_line): Move the call to
3270 highlight_trailing_whitespace before the call to
3271 compute_line_metrics, since the latter needs to see the final
3272 faces of all the glyphs to compute ROW's hash value.
3273 Fixes assertion violations in row_equal_p. (Bug#10035)
3275 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3277 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3278 just return (bug#10044).
3280 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3282 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3283 with user-defined heap size. Bump the default size of the temacs
3284 heap to 27MB, to avoid memory warning when running temacs.
3285 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3287 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3288 current_matrix and desired_matrix. (Bug#9990)
3289 (verify_row_hash) [XASSERTS]: New function.
3290 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3291 that the hash value of glyph rows is correct.
3293 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3295 * window.h (window): Remove splits slot.
3296 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3297 (Fdelete_other_windows_internal, make_parent_window)
3298 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3299 (Fset_window_configuration, save_window_save): Don't deal with
3300 split status of windows.
3301 (saved_window): Remove splits slot.
3302 (Vwindow_splits): Rewrite doc-string.
3304 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3306 * xfns.c (unwind_create_frame):
3307 * nsfns.m (unwind_create_frame):
3308 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3309 Vframe_list (Bug#9999).
3311 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3313 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3315 2011-11-11 Kenichi Handa <handa@m17n.org>
3317 * callproc.c (Fcall_process): Set the member dst_multibyte of
3320 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3322 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3323 avoid a crash (bug#9496).
3325 2011-11-09 Chong Yidong <cyd@gnu.org>
3327 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3328 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3330 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3332 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3334 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3336 Avoid some portability problems by eschewing 'extern inline' functions.
3337 The trivial performance wins aren't worth the portability hassles; see
3338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3340 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3341 (window_box_width, window_box_left, window_box_left_offset)
3342 (window_box_right, window_box_right_offset): Undo previous change,
3343 by removing the "extern"s.
3344 * intervals.c (adjust_intervals_for_insertion)
3345 (adjust_intervals_for_deletion): Undo previous change,
3346 making these static again.
3347 (offset_intervals, temp_set_point_both, temp_set_point)
3348 (copy_intervals_to_string): No longer inline.
3349 * xdisp.c (window_text_bottom_y, window_box_width)
3350 (window_box_height, window_box_left_offset)
3351 (window_box_right_offset, window_box_left, window_box_right)
3352 (window_box): No longer inline.
3354 2011-11-08 Chong Yidong <cyd@gnu.org>
3356 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3357 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3358 Signal an error if not a live window.
3359 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3360 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3362 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3364 * lisp.h (syms_of_abbrev): Remove declaration.
3365 Reported by CHENG Gao <chenggao@royau.me>.
3367 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3369 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3370 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3371 of temacs in GUI mode.
3373 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3375 * window.h: Declare delete_all_child_windows instead of
3376 delete_all_subwindows.
3377 * window.c (Fwindow_nest, Fset_window_nest)
3378 (Fset_window_new_total, Fset_window_new_normal)
3379 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3380 (delete_all_subwindows): Rename to delete_all_child_windows.
3381 (Fdelete_other_windows_internal, Fset_window_configuration):
3382 Call delete_all_child_windows instead of delete_all_subwindows.
3383 * frame.c (delete_frame): Call delete_all_child_windows instead
3384 of delete_all_subwindows.
3386 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3388 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3389 This is also needed for porting to any host where GC_MARK_STACK is
3390 not GC_MAKE_GCPROS_NOOPS.
3391 (which_symbols): Use it.
3393 2011-11-07 Kenichi Handa <handa@m17n.org>
3395 * coding.c (coding_set_destination): Check coding->src_pos only
3396 when coding->src_object is a buffer (bug#9910).
3398 * process.c (send_process): Set the member src_multibyte of coding
3399 to 0 (bug#9911) when sending a unibyte text.
3401 * callproc.c (Fcall_process): Set the member src_multibyte of
3402 process_coding to 0 (bug#9912).
3404 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3406 * xmenu.c (cleanup_widget_value_tree): New function.
3407 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3408 calling free_menubar_widget_value_tree directly (Bug#9830).
3410 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3412 Fix some portability problems with 'inline'.
3413 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3414 (window_box_width, window_box_left, window_box_left_offset)
3415 (window_box_right, window_box_right_offset): Declare extern.
3416 Otherwise, these inline functions do not conform to C99 and
3417 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3418 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3419 * intervals.c (adjust_intervals_for_insertion)
3420 (adjust_intervals_for_deletion): Now extern, because otherwise the
3421 extern inline functions 'offset_intervals' couldn't refer to it.
3422 (static_offset_intervals): Remove.
3423 (offset_intervals): Rewrite using the old contents of
3424 static_offset_intervals. The old version didn't conform to C99
3425 because an extern inline function contained a reference to an
3426 identifier with static linkage.
3428 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3430 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3433 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3436 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3437 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3438 return Qleft_to_right.
3440 2011-11-06 Chong Yidong <cyd@gnu.org>
3442 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3443 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3444 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3445 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3446 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3447 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3448 (Fwindow_vscroll): Doc fix.
3449 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3450 argument, since it makes no sense to pass a live window and for
3451 consistency with window-child.
3453 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3455 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3458 2011-11-05 Jason Rumney <jasonr@gnu.org>
3460 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3461 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3463 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3464 bitwise arithmetic preventing use of unicode-sip and non-truetype
3467 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3469 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3472 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3473 initialization code to keep similarity to xfns.c after changes
3476 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3478 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3479 (unwind_create_frame): New function (Bug#9943).
3480 (Fx_create_frame): Restructure code to be more similar to the one in
3481 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3482 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3483 Move terminal->reference_count++ just before making the frame official
3486 * nsterm.m (x_free_frame_resources): New function.
3487 (x_destroy_window): Move code to x_free_frame_resources.
3489 * xfns.c (unwind_create_frame): Fix comment.
3490 (Fx_create_frame, x_create_tip_frame):
3491 Move terminal->reference_count++ just before making the frame
3492 official. Move initialization of image_cache_refcount and
3493 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3495 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3497 Support MSVC build with newer versions of Visual Studio.
3498 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3499 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3502 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3503 which are not supported by MSVC.
3504 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3505 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3507 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3509 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3511 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3513 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3515 Support MSVC build with newer versions of Visual Studio.
3516 * w32.c: Don't include w32api.h for MSVC.
3517 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3519 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3520 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3521 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3522 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3524 (alloca) [_MSC_VER]: Define to _alloca.
3526 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3528 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3530 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3532 * xdisp.c (note_mouse_highlight): If either of
3533 previous/next-single-property-change returns nil, treat that as
3534 the beginning or the end of the buffer. (Bug#9955)
3536 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3538 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3539 label is not null (Bug#9951).
3540 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3543 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3545 * window.c (Fwindow_body_size): Mention in the doc string that the
3546 return value is in frame's canonical units. (Bug#9949)
3548 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3550 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3552 * w32fns.c (unwind_create_frame): If needed, free the glyph
3553 matrices of the partially constructed frame. (Bug#9943)
3554 * xfns.c (unwind_create_frame): Likewise.
3556 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3558 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3559 Don't stop backward scan on the continuation glyph, even though
3560 its CHARPOS is positive.
3561 (mouse_face_from_buffer_pos, note_mouse_highlight):
3562 Rename cover_string to disp_string.
3564 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3566 * window.c (temp_output_buffer_show): Don't use
3567 Vtemp_buffer_show_specifiers.
3568 (Vtemp_buffer_show_specifiers): Remove unused variable.
3570 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3572 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3573 past the beginning of the current glyph matrix.
3575 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3577 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3578 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3579 HAVE_GTK3 (Bug#9869).
3581 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3582 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3584 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3586 * xterm.c: Declare x_handle_net_wm_state to return int.
3587 (handle_one_xevent): Check if we are iconified but don't have
3588 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3589 (get_current_wm_state): Return non-zero if not hidden,
3590 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3591 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3592 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3593 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3595 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3597 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3598 so that this new function doesn't get optimized away by a
3599 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3601 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3603 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3605 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3607 Fix the `xbytecode' command.
3608 * .gdbinit (xprintbytestr): New command.
3609 (xwhichsymbols): Rename from `which'; all callers changed.
3610 (xbytecode): Print the byte-code string as well.
3612 2011-10-29 Kim Storm <storm@cua.dk>
3614 * alloc.c (which_symbols): New function.
3616 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3618 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3621 2011-10-29 Glenn Morris <rgm@gnu.org>
3623 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3624 Not clear what it was for, and it causes various bugs. (Bug#9839)
3626 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3628 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3629 possible random value that matches one of those tested as
3630 condition to clear the mouse face.
3632 2011-10-28 Chong Yidong <cyd@gnu.org>
3634 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3636 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3638 * window.c (make_window): Initialize phys_cursor_on_p.
3640 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3642 * lisp.h (struct Lisp_Symbol): Update comments.
3644 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3646 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3648 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3650 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3651 <oslsachem@gmail.com> for helping to debug this.
3653 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3654 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3655 (g_b_init_get_glyph_outline_w): New static variables.
3656 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3657 (GetGlyphOutlineW_Proc): New typedefs.
3658 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3659 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3661 (w32font_open_internal, compute_metrics):
3662 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3663 instead of calling the "wide" APIs directly.
3665 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3667 * w32.h (syms_of_w32font): Add prototype.
3669 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3671 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3672 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3673 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3674 (Fmove_to_window_line): Doc fix.
3676 2011-10-27 Chong Yidong <cyd@gnu.org>
3678 * process.c (make_process): Set gnutls_state to NULL.
3680 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3681 non-NULL, regardless of GNUTLS_INITSTAGE.
3682 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3683 an error. Set process slots as soon as we allocate them.
3685 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3687 2011-10-27 Chong Yidong <cyd@gnu.org>
3689 * gnutls.c (emacs_gnutls_deinit): New function.
3690 Deallocate credentials structures as well as calling gnutls_deinit.
3691 (Fgnutls_deinit, Fgnutls_boot): Use it.
3693 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3694 (deactivate_process): Call emacs_gnutls_deinit.
3696 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3698 * image.c (x_create_x_image_and_pixmap):
3699 * w32.c (sys_rename, w32_delayed_load):
3700 * w32font.c (fill_in_logfont):
3701 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3703 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3705 * w32fns.c (w32_default_color_map): New function,
3706 extracted from Fw32_default_color_map.
3707 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3709 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3711 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3713 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3715 * keyboard.c (test_undefined): New function (bug#9751).
3716 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3718 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3720 * sysdep.c (init_sys_modes): Fix the check for the controlling
3721 terminal (Bug#6649).
3723 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3725 * dispextern.h (struct bidi_it): New member next_en_type.
3727 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3728 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3729 current character, check also for next_en_type being WEAK_EN.
3730 (bidi_resolve_weak): Don't enter the expensive loop if the current
3731 position is before next_en_pos. Record the bidi type of the first
3732 non-ET, non-BN character we find, in addition to its position.
3733 (bidi_level_of_next_char): Invalidate next_en_type when
3734 next_en_pos is over-stepped.
3736 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3738 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3739 * editfns.c: Rewrite current-time-zone so that it invokes
3740 the equivalent of (format-time-string "%Z") to get the time zone name.
3741 This fixes a bug when the time zone name contains characters that
3742 need converting from the system time locale to Emacs internal format.
3743 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3744 that patch fixed format-time-string to do the conversion, but
3745 I forgot to fix current-time-zone.
3746 (format_time_string): New function, containing most of
3747 what Fformat_time_string used to contain.
3748 (Fformat_time_string): Rewrite in terms of format_time_string.
3749 This doesn't change this function's behavior.
3750 (current-time-zone): Rewrite to use format_time_string.
3751 This fixes the bug reported by Michael Schierl in
3752 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3753 Jason Rumney's 2007-06-07 change worked around this bug, but
3755 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3757 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3759 * xdisp.c (start_display): If the character at POS is displayed
3760 via a display vector, reset IT->current.dpvec_index to zero.
3761 (try_window_reusing_current_matrix): If a line ends in a display
3762 vector or the next line starts in a display vector, continue
3763 redrawing the window even though the character position of
3764 start_row was reached.
3767 2011-10-18 Chong Yidong <cyd@gnu.org>
3769 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3770 with nobreak-char-display too.
3772 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3774 Fix part 3 of bug#9771.
3775 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3776 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3777 non-neutral characters if the current character is a paragraph
3778 separator (a.k.a. Newline). This avoids running the same
3779 expensive loop twice, once when we consume the preceding newline
3780 and the other time when the line actually needs to be displayed.
3781 Avoid the loop when we see neutrals on the base embedding level
3782 following a character whose directionality is the same as the
3783 paragraph's. This avoids running the expensive loop when a line
3784 ends in a long sequence of neutrals, like control characters.
3785 Add assertion against STRONG_AL type. Slightly rearrange code
3786 that determines the type of a neutral given the first non-neutral
3788 (bidi_level_of_next_char): Set next_en_pos to zero when
3789 invalidating its info.
3791 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3793 * xdisp.c (push_display_prop): Determine whether to record string
3794 or buffer position by IT->string, not by IT->method. Allow
3795 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3796 (move_it_vertically_backward): Don't look for character position
3797 immediately after the newline when in a continuation line.
3800 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3802 * window.c (coordinates_in_window): Rewrite and delabelize
3803 vertical border check. (Bug#5357) (Bug#9618)
3805 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3807 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3808 errors in XSetWindowBorder (bug#9310).
3810 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3812 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3813 avoid crash when xmalloc overrun checking is enabled.
3815 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3817 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3818 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3819 cursor motion with <left> and <right> arrow keys.
3821 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3822 some callers set that themselves.
3824 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3826 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3827 display string and the previous row comes from the same string and
3828 is empty. (Bug#9739) (Bug#9738)
3830 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3832 * doc.c (get_doc_string): Encode file name (bug#9735).
3834 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3836 * bidi.c (bidi_level_of_next_char):
3837 * xdisp.c (get_visually_first_element): Remove old incorrect
3838 comments regarding the Unicode Line Separator character.
3840 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3842 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3844 * alloc.c (Fgc_status): Do not access beyond zombies array
3845 boundary if nzombies > MAX_ZOMBIES.
3846 * alloc.c (dump_zombies): Add missing format specifier.
3848 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3850 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3851 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3853 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3854 Some packages use them to denote characters with modifiers.
3856 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3858 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3859 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3860 matching a pp-number. Rename parameter var to var1.
3862 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3864 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3866 2011-10-08 Glenn Morris <rgm@gnu.org>
3868 * callint.c (Fcall_interactively): Give a more explicit error for the
3869 'c' case with a non-character input. (Bug#8479)
3871 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3873 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3875 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3876 lines that are hscrolled on the left.
3878 * dispnew.c (buffer_posn_from_coords): Account for a possible
3879 presence of header-line. (Bug#4426)
3881 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3883 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3884 Don't advertise functionality which we discourage or doesn't work.
3886 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3888 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3889 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3890 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3891 this makes Emacs dump core during garbage collection on rare
3892 occasions. sizeof is obviously inferior to offsetof here, so
3893 stick with offsetof.
3894 (GC_POINTER_ALIGNMENT): New macro.
3895 (mark_memory): Omit 3rd (offset) arg; caller changed.
3896 Don't assume EMACS_INT alignment is the same as pointer alignment.
3898 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3900 * keyboard.c (read_key_sequence_remapped): New var.
3901 (read_key_sequence): Compute remapping in the right buffer.
3902 (command_loop_1): Use read_key_sequence's remapping directly.
3904 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3906 * dired.c (file_name_completion): Don't expand file name.
3907 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3908 before checking file name handler.
3910 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3911 they've been requested explicitly (bug#9591).
3913 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3915 * keymap.c (Fsingle_key_description): Use make_specified_string
3916 instead of build_string to build string from push_key_description.
3919 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3921 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3922 This fixes a Y2038 bug on 64-bit hosts.
3923 * buffer.c (reset_buffer):
3924 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3925 (Fclear_buffer_auto_save_failure):
3926 Use 0, not -1, to represent an unset failure time, since time_t
3927 might not be signed.
3929 Remove dependency on glibc malloc internals.
3930 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3931 Move back here from lisp.h, but with their new implementations.
3932 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3933 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3934 * charset.c (charset_table_init): New static var.
3935 (syms_of_charset): Use it instead of xmalloc. This removes a
3936 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3937 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3938 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3939 Move back to alloc.c.
3940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3941 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3943 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3945 * nsterm.m (windowDidResize): Call x_set_window_size only when
3946 ns_in_resize is true. Otherwise set pixelwidth/height and
3947 call change_frame_size (Bug#9628).
3949 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3951 Port --enable-checking=all to Fedora 14 x86-64.
3952 * charset.c (syms_of_charset): Also account for glibc malloc's
3953 internal overhead when calculating the initial malloc maximum.
3955 Port --enable-checking=all to Fedora 14 x86.
3956 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3958 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3959 (overrun_check_realloc, overrun_check_free):
3960 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3961 That way, xmalloc returns a properly-aligned pointer even if
3962 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3963 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3964 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3965 into account when calculating the initial malloc maximum.
3966 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3967 Move here from alloc.c, so that charset.c can use it too.
3968 Properly align; the old code wasn't right for common 32-bit hosts
3969 when configured with --enable-checking=all.
3970 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3971 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3973 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3975 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3978 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3980 * xdisp.c (compute_display_string_end): If there's no display
3981 string at CHARPOS, return -1.
3983 * bidi.c (bidi_fetch_char): When compute_display_string_end
3984 returns a negative value, treat the character as a normal
3985 character not covered by a display string. (Bug#9624)
3987 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3989 * lread.c (Fread_from_string): Fix typo in docstring.
3991 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3993 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3994 newline, reseat the iterator instead of bidi-iterating there one
3995 character at a time. (Bug#9610)
3996 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3997 TO_CHARPOS if the bidi iterator is at base embedding level.
3999 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4001 * lread.c (readevalloop): Use correct code for NBSP.
4002 (read1): Likewise. (Bug#9608)
4004 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4006 * dbusbind.c (Fdbus_register_signal): When service is not
4007 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4009 2011-09-25 Glenn Morris <rgm@gnu.org>
4011 * buffer.c (truncate-lines): Doc fix.
4013 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4015 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4016 (Fset_window_next_buffers): Doc fix.
4018 2011-09-24 Glenn Morris <rgm@gnu.org>
4020 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4022 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4024 Fix minor problems found by static checking.
4025 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4026 * indent.c (Fvertical_motion): Fix == vs = typo.
4028 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4030 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4031 Default value is now t. Doc fix.
4033 * indent.c (Fvertical_motion): Compute and apply the overshoot
4034 logic when moving up, not only when moving down. Fix the
4035 confusing name and values of the it_overshoot_expected variable;
4036 logic changes accordingly. (Bug#9254) (Bug#9549)
4038 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4039 CHARPOS is covered by a display string which includes newlines.
4040 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4041 is covered by a display string with embedded newlines.
4043 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4045 * dbusbind.c (Fdbus_register_signal): Add match rule to
4046 Vdbus_registered_objects_table. (Bug#9581)
4047 (Fdbus_register_method, Vdbus_registered_objects_table):
4050 2011-09-24 Jim Meyering <meyering@redhat.com>
4052 do not ignore write error for any output size
4053 The previous change was incomplete.
4054 While it makes emacs --batch detect the vast majority of stdout
4055 write failures, errors were still ignored whenever the output size is
4056 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4057 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4058 && echo FAIL: ignored write error
4059 FAIL: ignored write error
4060 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4061 && echo FAIL: ignored write error
4062 FAIL: ignored write error
4063 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4065 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4067 * emacs.c (Fkill_emacs): In noninteractive mode exit
4068 non-successfully if a write error occurred on stdout. (Bug#9574)
4070 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4072 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4075 * dispextern.h (struct it): Update the comment documenting what
4078 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4080 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4081 a display string, extend search for cursor position to end of row.
4082 (find_row_edges): If the row ends in a newline from a display
4083 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4084 Handle the case of a display string with multiple newlines.
4085 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4086 non-empty line. Fixes confusing cursor motion with arrow keys at
4087 the beginning of a line that starts with whitespace.
4089 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4091 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4094 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4096 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4099 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4101 * xdisp.c (display_line): Record maximum and minimum buffer
4102 positions even if no glyphs were produced (e.g., by a zero-width
4103 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4104 buffer positions that will be removed from the glyph row because
4106 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4107 column is beyond frame width: don't subtract 1 "pixel" when
4108 computing width of the stretch.
4109 (reseat_at_next_visible_line_start): Undo the change made on
4110 2011-09-17 that saved paragraph information and restored it after
4111 the call to `reseat'. (Bug#9545)
4113 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4115 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4116 and turn window cursor on if cleared (Bug#9415).
4118 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4120 * search.c (boyer_moore): Take unibyte characters from pattern
4121 literally. (Bug#9458)
4123 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4125 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4127 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4129 Fix minor problem found by static checking.
4130 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4131 initialized, to pacify gcc -Wuninitialized.
4133 * fileio.c: Report proper errno when syscall falls.
4134 (Finsert_file_contents): Save and restore errno,
4135 so that report_file_error outputs the correct diagnostic.
4136 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4138 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4140 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4142 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4144 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4145 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4147 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4149 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4150 about the current paragraph and restore it after the call to reseat.
4152 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4153 (bidi_find_paragraph_start): Search back for paragraph beginning
4154 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4155 (bidi_move_to_visually_next): Only trigger paragraph-related
4156 computations when the last character is a newline or at EOB, not
4157 just any NEUTRAL_B. (Bug#9470)
4159 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4160 truncated lines if point is covered by a display string. (Bug#9524)
4162 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4164 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4165 (cons_to_x_long): New function.
4166 (lisp_data_to_selection_data): Use it. Correct the test for
4167 short-versus-long data; it was negated. Break out of vector
4168 loop, for efficiency, when a long datum is discovered.
4170 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4172 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4174 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4176 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4177 GCC PR/17406) by declaring this function with external scope.
4179 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4181 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4182 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4184 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4186 * editfns.c (Fformat): Correctly handle text properties on "%%".
4188 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4190 * xterm.c (x_draw_composite_glyph_string_foreground):
4191 * w32term.c (x_draw_composite_glyph_string_foreground):
4192 * term.c (encode_terminal_code):
4193 * composite.c (composition_update_it, get_composition_id):
4194 * xdisp.c (get_next_display_element)
4195 (fill_composite_glyph_string): Add comments about special meaning
4196 of TAB characters in a composition.
4198 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4200 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4201 This occurs when processing a multibyte format.
4202 Problem reported by Wolfgang Jenker.
4204 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4206 * xdisp.c (try_cursor_movement): Only check for exact match if
4207 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4209 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4211 Remove unused external symbols.
4212 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4213 * xdisp.c (calc_pixel_width_or_height): Now static.
4214 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4215 * indent.c (check_display_width):
4216 * w32term.c: Fix comment to match code.
4217 * xterm.c, xterm.h (x_catching_errors): Remove.
4219 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4221 * xselect.c: Use signed conversions more consistently (Bug#9498).
4222 (selection_data_to_lisp_data): Assume incoming selection data are
4223 signed integers, not unsigned. This is to be consistent with
4224 outgoing selection data, which was modified to use signed integers
4225 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4226 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4227 expects long, not unsigned long.
4229 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4231 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4232 computation of loop end. Reported by Johan Bockgård
4235 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4237 * frame.c (Fother_visible_frames_p): Function deleted.
4239 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4241 * indent.c (compute_motion): Process display vector front to back
4242 rather than the other way around. (Bug#2496)
4244 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4246 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4248 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4250 * minibuf.c (Fread_from_minibuffer): Doc fix.
4252 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4254 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4255 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4257 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4259 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4260 value for non-existent files.
4262 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4264 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4265 set its "size" to -1. This will set the modtime_size field of
4266 the corresponding buffer to -1, which is what
4267 verify-visited-file-modtime expects for files that do not exist.
4270 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4272 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4274 * lisp.h: ... from here. push_key_description is no longer
4275 defined in keyboard.c, so its declaration should not be in
4276 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4277 logically belongs with push_key_description.
4279 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4281 * buffer.h: Include <sys/types.h> instead of <time.h>.
4282 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4283 Problem reported by Herbert J. Skuhra.
4285 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4287 * xml.c (parse_region): Make the parsing work for
4288 non-comment-starting XML files again (bug#9144).
4290 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4292 * image.c (gif_load): Fix calculation of bottom and right corner.
4295 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4297 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4298 redisplay in small windows.
4300 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4302 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4304 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4306 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4307 Operate on live windows only.
4309 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4311 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4313 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4315 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4316 only under bidi iteration.
4318 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4320 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4322 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4324 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4325 Without this fix, the command to link temacs failed due to an
4326 undefined symbol __builtin_isnan. This is because
4327 /usr/include/iso/math_c99.h #defines isnan(x) to
4328 __builtin_isnan(x), but the bundled gcc, which identifies itself
4329 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4331 * floatfns.c (isnan): #undef, and then #define to a clone of
4333 (Fisnan): Always define, since it's always available now.
4334 (syms_of_floatfns): Always define isnan at the Lisp level.
4336 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4338 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4340 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4342 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4343 The previous code assumed that file offsets (off_t values) fit in
4344 EMACS_INT variables, which is not true on typical 32-bit hosts.
4345 The code messed up by falsely reporting buffer overflow in cases
4346 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4347 when "big" contains more than 2**29 bytes, even though this
4348 inserts just one byte and does not overflow the buffer.
4349 (Finsert_file_contents): Store file offsets as off_t
4350 values, not as EMACS_INT values. Check for overflow when
4351 converting between EMACS_INT and off_t. When checking for
4352 buffer overflow or for overlap, take the offsets into account.
4353 Don't use EMACS_INT for small values where int suffices.
4354 When checking for overlap, fix a typo: ZV was used where
4355 ZV_BYTE was intended.
4356 (Fwrite_region): Don't assume off_t fits into 'long'.
4357 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4359 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4361 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4363 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4365 sprintf-related integer and memory overflow issues (Bug#9412).
4367 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4368 (esprintf, exprintf, evxprintf): New functions.
4369 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4370 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4371 (modify_event_symbol): Do not assume that the length of
4372 name_alist_or_stem is safe to alloca and fits in int.
4373 (Fexecute_extended_command): Likewise for function name and binding.
4374 (Frecursion_depth): Wrap around reliably on integer overflow.
4375 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4376 since some callers pass EMACS_INT values.
4377 (Fsingle_key_description): Don't crash if symbol name contains more
4378 than MAX_ALLOCA bytes.
4379 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4380 (get_minibuffer): Arg is now EMACS_INT, not int.
4381 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4382 (esprintf, exprintf, evxprintf): New decls.
4383 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4385 * dbusbind.c (signature_cat): New function.
4386 (xd_signature, Fdbus_register_signal):
4387 Do not overrun buffer; instead, report string overflow.
4389 * dispnew.c (add_window_display_history): Don't overrun buffer.
4390 Truncate instead; this is OK since it's just a log.
4392 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4393 even if the time zone offset is outlandishly large.
4394 Don't mishandle offset == INT_MIN.
4396 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4397 when creating daemon; the previous buffer-overflow check was incorrect.
4399 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4400 which has the guts of the old verror function.
4402 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4403 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4405 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4406 (font_unparse_xlfd): Don't blindly alloca long strings.
4407 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4408 fits in int, when using sprintf. Use single snprintf to count
4409 length of string rather than counting it via multiple sprintfs;
4410 that's simpler and more reliable.
4411 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4412 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4413 sprintf, in case result does not fit in int.
4415 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4416 (fontset_from_font): Print it.
4418 * frame.c (tty_frame_count): Now printmax_t, not int.
4419 (make_terminal_frame, set_term_frame_name): Print it.
4420 (x_report_frame_params): In X, window IDs are unsigned long,
4421 not signed long, so print them as unsigned.
4422 (validate_x_resource_name): Check for implausibly long names,
4423 and don't assume name length fits in 'int'.
4424 (x_get_resource_string): Don't blindly alloca invocation name;
4425 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4428 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4429 (xg_check_special_colors, xg_set_geometry):
4430 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4432 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4433 Use esprintf, not sprintf, in case result does not fit in int.
4435 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4436 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4437 it as a large positive number.
4438 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4439 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4441 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4442 in case result does not fit in int.
4444 * print.c (float_to_string): Detect width overflow more reliably.
4445 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4446 buffer overrun. Don't assume list length fits in 'int'. Treat
4447 print length of 0 as 0, not as infinity; to be consistent with other
4448 uses of print length in this function. Don't overflow print length
4449 index. Don't assume hash table size fits in 'long', or that
4450 vectorlike size fits in 'unsigned long'.
4452 * process.c (make_process): Use printmax_t, not int, to format
4453 process-name gensyms.
4455 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4457 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4458 to avoid potential buffer overrun.
4460 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4461 if X resource line is longer than 512 bytes.
4463 * xfns.c (x_window): Make sprintf buffer a bit bigger
4464 to avoid potential buffer overrun.
4466 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4468 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4470 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4472 Integer overflow fixes for scrolling, etc.
4473 Without these, Emacs silently mishandles large integers sometimes.
4474 For example, "C-u 4294967297 M-x recenter" was treated as if
4475 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4477 * xdisp.c (try_window_id): Check Emacs fixnum range before
4478 converting to 'int'.
4480 * window.c (window_scroll_line_based, Frecenter):
4481 Check that an Emacs fixnum is in range before assigning it to 'int'.
4482 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4483 values converted from Emacs fixnums.
4484 (Frecenter): Don't wrap around a line count if it is out of 'int'
4485 range; instead, treat it as an extreme value.
4486 (Fset_window_configuration, compare_window_configurations):
4487 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4489 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4490 that can exceed INT_MAX. Check that EMACS_INT value is in range
4491 before assigning it to the (possibly-narrower) index.
4492 (match_limit): Don't assume that a fixnum can fit in 'int'.
4494 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4497 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4498 (Fvertical_motion): Don't wrap around LINES values that don't fit
4499 in 'int'. Instead, treat them as extreme values. This is good
4500 enough for windows, which can't have more than INT_MAX lines anyway.
4502 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504 * Require libxml/parser.h to avoid compilation warning.
4506 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4508 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4509 since this reportedly can destroy thread storage.
4511 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4513 * syntax.c (find_defun_start): Update all cache variables if
4514 exiting early (Bug#9401).
4516 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4518 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4520 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4521 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4522 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4524 * term.c (tty_append_glyph): New function.
4525 (produce_stretch_glyph): Static function and its prototype deleted.
4527 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4530 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4532 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4533 when checking :margin (Bug#9390).
4534 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4535 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4536 so that the name doesn't mislead. All uses changed.
4538 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4540 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4543 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4545 * xdisp.c (move_it_to): Don't bail out early when reaching
4546 position beyond to_charpos, if we are scanning backwards.
4547 (move_it_vertically_backward): When DY == 0, make sure we get to
4548 the first character in the line after the newline.
4550 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4552 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4553 (ccl_driver): Do not generate an out-of-range pointer.
4554 (Fccl_execute_on_string): Remove unnecessary check for
4555 integer overflow, noted by Stefan Monnier in
4556 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4557 Remove a FIXME that didn't need fixing.
4558 Simplify the newly-introduced buffer reallocation code.
4560 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4562 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4564 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4566 Integer and memory overflow issues (Bug#9196).
4568 * doc.c (get_doc_string): Rework so that
4569 get_doc_string_buffer_size is the actual buffer size, rather than
4570 being 1 less than the actual buffer size; this makes xpalloc more
4573 * image.c (x_allocate_bitmap_record, cache_image):
4574 * xselect.c (Fx_register_dnd_atom):
4575 Simplify previous changes by using xpalloc.
4577 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4578 since either will do and ptrdiff_t is convenient with xpalloc.
4580 * charset.c (charset_table_size)
4581 (struct charset_sort_data.priority): Now ptrdiff_t.
4582 (charset_compare): Don't overflow if priorities differ greatly.
4583 (Fsort_charsets): Don't assume list length fits in int.
4584 Check for size-calculation overflow when allocating sort data.
4585 (syms_of_charset): Allocate an initial charset table that is
4586 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4588 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4590 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4591 The actual value is always <= INT_MAX, and leaving it unsigned made
4592 overflow checking harder.
4594 * dispextern.h (struct glyph_matrix.rows_allocated)
4595 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4596 with xpalloc. The values are still always <= INT_MAX.
4598 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4600 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4601 (SAFE_NALLOCA): New macro.
4603 * region-cache.c (struct boundary.pos, find_cache_boundary)
4604 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4605 (set_cache_region, invalidate_region_cache)
4606 (revalidate_region_cache, know_region_cache, region_cache_forward)
4607 (region_cache_backward, pp_cache):
4608 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4609 so that ptrdiff_t * can be passed to xpalloc.
4610 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4611 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4612 (pp_cache): Don't assume cache_len fits in int.
4613 * region-cache.h: Adjust extern decls to match.
4615 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4616 EMACS_INT, since either will do, for xpalloc.
4618 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4619 (xnmalloc, xnrealloc, xpalloc): New functions.
4621 * bidi.c (bidi_shelve_header_size): New constant.
4622 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4623 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4625 * bidi.c (bidi_cache_shrink):
4626 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4628 Don't update size of array until after memory allocation succeeds,
4629 because xmalloc/xrealloc may not return.
4630 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4631 now that we have proper integer overflow checking.
4632 (record_overlay_string, overlay_strings): Catch overflows when
4633 calculating size of overlay_str_buf.
4635 * callproc.c (Fcall_process): Check for size overflow when
4636 calculating size of args2.
4637 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4638 Normally we prefer signed values, but sticking with ptrdiff_t would
4639 require adding more-complicated checks.
4641 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4642 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4643 Redo buffer-overflow calculations to avoid integer overflow.
4644 Add a FIXME comment where memory seems to be over-allocated.
4646 * character.c (Fstring): Check for size-calculation overflow.
4648 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4649 unnecessary integer overflow. Check for size overflow.
4650 (encode_coding_object): Don't update size until xmalloc succeeds.
4652 * composite.c (get_composition_id): Check for overflow in glyph
4653 length calculations.
4655 Integer and memory overflow fixes for display code.
4656 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4657 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4658 (scrolling_window): Check for overflow in size calculations.
4659 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4660 Don't assume glyph table len fits in int.
4661 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4662 (row_table_size): Now ptrdiff_t, not int.
4663 (scrolling_window): Avoid overflow in size calculations.
4664 Don't update size until allocation succeeds.
4665 * fns.c (concat): Check for overflow in size calculations.
4666 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4667 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4668 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4670 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4671 (get_doc_string): Check for size calculation overflow.
4672 Don't update size until allocation succeeds.
4673 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4674 EMACS_INT, where ptrdiff_t will do.
4675 (Fsubstitute_command_keys): Check for string overflow.
4677 * editfns.c (set_time_zone_rule): Don't assume environment length
4679 (message_length): Now ptrdiff_t, not int.
4680 (Fmessage_box): Don't update size until allocation succeeds.
4681 Don't assume message length fits in int.
4682 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4684 * emacs.c (main): Do not reallocate argv, since there is a null at
4685 the end that can be overwritten, and this way there's no need to
4686 worry about size-calculation overflow.
4687 (sort_args): Check for size-calculation overflow.
4689 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4691 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4693 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4694 (x_set_scroll_bar_width, x_figure_window_size):
4695 Check for integer overflow.
4696 (x_set_alpha): Do not assume XINT fits in int.
4698 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4699 This is for the members text_lines, text_cols, total_lines, total_cols,
4700 where the system imposes an 'int' limit.
4702 * fringe.c (Fdefine_fringe_bitmap):
4703 Don't update size until alloc works.
4705 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4706 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4708 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4709 Check for size-calculation overflow.
4710 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4711 do, as we prefer signed integers.
4712 (id_to_widget.max_size, id_to_widget.used)
4713 (xg_store_widget_in_map, xg_remove_widget_from_map)
4714 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4715 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4716 Use and return ptrdiff_t, not int.
4717 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4718 * gtkutil.h: Change prototypes to match the above.
4720 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4721 are duplicate now that they've been promoted to lisp.h.
4722 (x_allocate_bitmap_record, x_alloc_image_color)
4723 (make_image_cache, cache_image, xpm_load):
4724 Don't update size until alloc is done.
4725 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4727 Check for size calculation overflow.
4728 (ct_colors_allocated_max): New constant.
4729 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4732 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4733 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4734 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4735 Use ptrdiff_t, not int, to count maps.
4736 (read_char_minibuf_menu_prompt): Check for overflow in size
4737 calculations. Don't update size until allocation succeeds.
4738 Redo calculations to avoid overflow.
4739 * keyboard.h: Change prototypes to match the above.
4741 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4743 (current_minor_maps): Check for size calculation overflow.
4744 * keymap.h: Change prototypes to match the above.
4746 * lread.c (read1, init_obarray): Don't update size until alloc done.
4748 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4749 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4751 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4752 Now ptrdiff_t, not int.
4753 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4754 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4756 * process.c (Fnetwork_interface_list): Check for overflow
4757 in size calculation.
4759 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4761 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4762 overflow. Don't bother calling xmalloc when xrealloc will do.
4764 * search.c (Freplace_match): Check for size calculation overflow.
4765 (Fset_match_data): Don't assume list lengths fit in 'int'.
4767 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4768 for command line length. Do not attempt to address one before the
4769 beginning of an array, as that's not portable.
4771 * term.c (max_frame_lines): Remove; unused.
4772 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4774 (encode_terminal_code, calculate_costs): Check for size
4775 calculation overflow.
4776 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4777 table lengths and related sizes. Don't update size until alloc
4778 done. Redo calculations to avoid overflow.
4779 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4781 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4782 subtracting pointers.
4783 (gobble_line): Check for overflow more carefully. Don't update size
4786 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4787 Don't update size until alloc done.
4788 Redo size calculations to avoid overflow.
4789 Check for size calculation overflow.
4790 (main) [DEBUG]: Fix typo in invoking tparam1.
4792 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4793 Use ptrdiff_t, not int, for sizes.
4794 (store_mode_line_noprop_char): Don't update size until alloc done.
4796 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4797 Use ptrdiff_t, not int, for sizes.
4798 (Finternal_make_lisp_face, cache_face):
4799 Check for size calculation overflow.
4800 (cache_face): Treat size calculation overflows as if they were
4801 memory exhaustion (the usual treatment), rather than aborting.
4803 * xfns.c (x_encode_text, x_set_name_internal)
4804 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4805 sizes, since they can exceed INT_MAX in size. Check for size
4806 calculation overflow.
4808 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4809 (xg_select): Check for size calculation overflow.
4810 Don't update size until alloc done.
4812 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4813 as sprintf is limited to int lengths.
4815 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4816 (X_LONG_MIN): New macros.
4817 Use them to make the following changes clearer.
4818 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4819 This change doesn't affect the value now, but it may help remind
4820 future maintainers not to raise the value too much later.
4821 (SELECTION_QUANTUM): Remove, replacing with ...
4822 (selection_quantum): ... new function, which avoids overflow.
4824 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4825 assumption that selection length fits in 'int'.
4826 (x_reply_selection_request, x_handle_selection_request)
4827 (x_get_window_property, receive_incremental_selection)
4828 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4829 (lisp_data_to_selection_data, clean_local_selection_data):
4830 Use ptrdiff_t, not int, to record length of selection.
4831 (x_reply_selection_request, x_get_window_property)
4832 (receive_incremental_selection, x_property_data_to_lisp):
4833 Redo calculations to avoid overflow.
4834 (x_reply_selection_request): When sending hint, ceiling it at
4835 X_LONG_MAX rather than relying on wraparound overflow to send
4837 (x_get_window_property, receive_incremental_selection)
4838 (lisp_data_to_selection_data, x_property_data_to_lisp):
4839 Check for size-calculation overflow.
4840 (x_get_window_property, receive_incremental_selection)
4841 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4842 Don't store size until memory allocation succeeds.
4843 (x_get_window_property): Plug memory leak on memory exhaustion.
4844 Don't double-block input; malloc is safe here. Don't assume 2**34
4845 - 4 fits in unsigned long. Add an xassert to check
4846 XGetWindowProperty overflow. Be more careful about overflow
4847 calculations, and distinguish size from memory overflow better.
4848 (receive_incremental_selection): When tracing, don't assume
4849 unsigned int is less than INT_MAX.
4850 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4851 harmful) conversions of unsigned short to int.
4852 (lisp_data_to_selection_data): Don't assume that integers
4853 in the range -65535 through -1 fit in an X unsigned short.
4854 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4855 result parameters unless successful. Rely on cons_to_unsigned
4856 to report problems with elements; the old code wasn't right anyway.
4857 (x_check_property_data): Check for int overflow; we cannot use
4858 a wider type due to X limits.
4859 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4861 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4863 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4864 (x_term_init): Check for size calculation overflow.
4865 (x_color_cells): Don't store size until memory allocation succeeds.
4866 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4867 Don't assume alloca size is less than MAX_ALLOCA.
4868 (x_term_init): Don't assume length fits in int (sprintf is limited
4871 Use ptrdiff_t for composition IDs.
4872 * character.c (lisp_string_width):
4873 * composite.c (composition_table_size, n_compositions)
4874 (get_composition_id, composition_gstring_from_id):
4875 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4876 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4877 * window.c (Frecenter):
4878 Use ptrdiff_t, not int, for composition IDs.
4879 * composite.c (get_composition_id): Check for integer overflow.
4880 * composite.h: Adjust prototypes to match the above changes.
4882 Use ptrdiff_t for hash table indexes.
4883 * category.c (hash_get_category_set):
4884 * ccl.c (ccl_driver):
4885 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4886 * coding.c (coding_system_charset_list, detect_coding_system):
4887 * coding.h (struct coding_system.id):
4888 * composite.c (get_composition_id, gstring_lookup_cache):
4889 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4890 * image.c (xpm_get_color_table_h):
4891 * lisp.h (hash_lookup, hash_put):
4892 * minibuf.c (Ftest_completion):
4893 Use ptrdiff_t for hash table indexes, not int (which is too
4894 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4895 32-bit --with-wide-int hosts).
4897 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4898 Add a FIXME comment about memory leaks.
4899 (syms_of_charset): Don't assume xmalloc returns.
4901 Don't assume that stated character widths fit in int.
4902 * character.c (Fchar_width, c_string_width, lisp_string_width):
4903 * character.h (CHAR_WIDTH):
4904 * indent.c (MULTIBYTE_BYTES_WIDTH):
4905 Use sanitize_char_width to avoid undefined and/or bad behavior
4906 with outlandish widths.
4907 * character.h (sanitize_tab_width): Rename from sanitize_width,
4908 now that we have two such functions. All uses changed.
4909 (sanitize_char_width): New inline function.
4911 Don't assume that tab-width fits in int.
4912 * character.h (sanitize_width): New inline function.
4913 (SANE_TAB_WIDTH): New macro.
4914 (ASCII_CHAR_WIDTH): Use it.
4915 * indent.c (sane_tab_width): Remove. All uses replaced by
4916 SANE_TAB_WIDTH (current_buffer).
4917 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4919 * fileio.c: Integer overflow issues with file modes.
4920 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4922 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4923 Remove unreachable code.
4924 (read_hex, load_charset_map_from_file): Check for integer overflow.
4926 * xterm.c: Don't go over XClientMessageEvent limit.
4927 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4928 (x_send_scroll_bar_event): Likewise. Check that the size does not
4929 exceed limits imposed by XClientMessageEvent, as well as the usual
4930 ptrdiff_t and size_t limits.
4932 * keyboard.c: Overflow, signedness and related fixes.
4933 (make_lispy_movement): Use same integer type in forward decl
4934 that is used in the definition.
4935 (read_key_sequence, keyremap_step):
4936 Change bufsize argument back to int, undoing my 2011-03-30 change.
4937 We prefer signed types, and int is wide enough here.
4938 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4939 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4940 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4941 length, not size_t. Use ptrdiff_t for index, not int.
4942 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4943 possibility of integer overflow.
4945 Overflow, signedness and related fixes for images.
4947 * dispextern.h (struct it.stack[0].u.image.image_id)
4948 (struct_it.image_id, struct image.id, struct image_cache.size)
4949 (struct image_cache.used, struct image_cache.ref_count):
4950 * gtkutil.c (update_frame_tool_bar):
4951 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4952 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4953 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4954 * nsmenu.m (update_frame_tool_bar):
4955 * xdisp.c (calc_pixel_width_or_height):
4956 * xfns.c (image_cache_refcount):
4957 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4958 on typical 64-bit hosts.
4960 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4961 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4962 Omit unnecessary casts to int.
4963 (parse_image_spec): Check that integers fall into 'int' range
4964 when the callers expect that.
4965 (image_ascent): Redo ascent calculation to avoid int overflow.
4966 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4967 (lookup_image): Remove unnecessary tests.
4968 (xbm_image_p): Locals are now of int, not EMACS_INT,
4969 since parse_image_check makes sure they fit into int.
4970 (png_load, gif_load, svg_load_image):
4971 Prefer int to unsigned where either will do.
4972 (tiff_handler): New function, combining the cores of the
4973 old tiff_error_handler and tiff_warning_handler.
4974 This function is rewritten to use vsnprintf and thereby avoid
4975 stack buffer overflows. It uses only the features of vsnprintf
4976 that are common to both POSIX and native Microsoft.
4977 (tiff_error_handler, tiff_warning_handler): Use it.
4978 (tiff_load, gif_load, imagemagick_load_image):
4979 Don't assume :index value fits in 'int'.
4980 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4981 (imagemagick_load_image): Check that crop parameters fit into
4982 the integer types that MagickCropImage accepts. Don't assume
4983 Vimagemagick_render_type has a nonnegative value. Don't assume
4984 size_t fits in 'long'.
4985 (gs_load): Use printmax_t to print the widest integers possible.
4986 Check for integer overflow when computing image height and width.
4988 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4990 * xdisp.c (redisplay_window): Don't force window start if point
4991 will be invisible in the resulting window. (Bug#9324)
4993 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4995 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4996 the display spec is of the form `(space ...)'.
4997 (handle_display_spec): Return the value returned by
4998 handle_single_display_spec, not just 1 or zero.
4999 (handle_single_display_spec): If the display spec is of the form
5000 `(space ...)', and specifies display in the text area, return 2
5002 (try_cursor_movement): Check for the need to scroll more
5003 accurately, and prefer exact match for point under bidi.
5004 Don't advance `row' beyond the last row of the window.
5006 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5007 into disp_prop; all users changed.
5009 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5010 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5011 for the text covered by the display property.
5013 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5015 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5016 Change return value to nil.
5017 (Frecord_buffer): Delete unused function.
5019 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5021 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5022 buffers, return left-to-right.
5023 (set_cursor_from_row): Consider candidate row a win if its glyph
5024 represents a newline and point is on that newline. Fixes cursor
5025 positioning on the newline at EOL of R2L text within L2R
5026 paragraph, and vice versa.
5027 (try_cursor_movement): Check continued rows, in addition to
5028 continuation rows. Fixes unwarranted scroll when point enters a
5029 continued line of R2L text within an L2R paragraph, or vice versa.
5030 (cursor_row_p): Consider the case of point being equal to
5031 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5032 from the end of a short line to the beginning of a continued line
5033 of R2L text within L2R paragraph.
5034 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5035 composed characters.
5037 * bidi.c (bidi_check_type): Use xassert.
5038 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5041 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5043 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5046 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5048 * nsfont.m (ns_otf_to_script): Fix typo.
5050 2011-08-22 Kenichi Handa <handa@m17n.org>
5052 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5053 extra slot even if the purpose is char-code-property-table.
5055 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5057 * xdisp.c (redisplay_window): When computing centering_position,
5058 account for the height of the header line. (Bug#8874)
5060 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5061 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5062 candidate is selected by the mouse, and that candidate has a
5063 composed character under the mouse.
5065 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5066 coordinates reported by pos-visible-in-window-p for a composed
5067 character in column zero.
5069 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5071 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5073 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5075 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5076 consider it a hit if to_charpos is anywhere in the range of the
5077 composed buffer positions.
5079 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5081 * image.c (gif_load): Don't assume that each subimage has the same
5082 dimensions as the base image. Handle disposal method that is
5083 "undefined" by the gif spec (Bug#9335).
5085 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5087 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5088 (Fcondition_case): Document `debug' symbol in error handler.
5090 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5092 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5093 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5094 from an Org mode buffer to a Speedbar frame.
5096 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5097 a composition, take its buffer position from IT->cmp_it.charpos.
5098 Fixes cursor positioning at the beginning of a line that begins
5099 with a composed character.
5101 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5103 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5104 character bidirectional type, use STRONG_L instead. Fixes crashes
5105 in a buffer produced by `describe-categories'.
5107 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5108 members before the level stack, so they would be saved and
5109 restored when copying iterator state. Fixes incorrect reordering
5110 around TABs covered by display properties.
5112 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5114 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5116 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5118 * eval.c (internal_condition_case, internal_condition_case_1)
5119 (internal_condition_case_2, internal_condition_case_n):
5120 Remove unnecessary aborts (Bug#9081).
5122 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5124 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5125 has no `load' handler, try opening the file locally. (Bug#9311)
5127 2011-08-16 Ken Brown <kbrown@cornell.edu>
5129 * gmalloc.c: Expand comment.
5131 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5133 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5134 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5136 2011-08-16 Ken Brown <kbrown@cornell.edu>
5138 Fix memory allocation problems in Cygwin build (Bug#9273).
5140 * unexcw.c ( __malloc_initialized): Declare external variable.
5141 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5143 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5145 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5147 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5149 [CYGWIN] (special_realloc): New function.
5150 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5151 requests to realloc storage in the static heap.
5153 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5155 * bidi.c (bidi_initialize): Remove unused local.
5157 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5160 * biditype.h: Remove file.
5161 * makefile.w32-in ($(BLD)/bidi.$(O)):
5162 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5164 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5166 * chartab.c: Improve commentary for the uniprop_table API.
5168 * bidi.c (bidi_paragraph_init): Support zero value of
5169 bidi_ignore_explicit_marks_for_paragraph_level.
5170 (bidi_initialize): Use uniprop_table instead of including
5171 biditype.h and bidimirror.h.
5173 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5174 coordinates of the iterator when restoring from ppos_it.
5177 2011-08-14 Kenichi Handa <handa@m17n.org>
5179 * process.c (create_process): Call setup_process_coding_systems
5180 after the pid of the process is set to -1 (Bug#8162).
5182 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5184 * xdisp.c (move_it_in_display_line_to): Don't invoke
5185 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5186 ppos_it. Fixes vertical cursor motion when line beginning is
5187 covered by an image. (Bug#9296)
5189 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5191 * nsterm.h (ns_run_ascript): Declare.
5192 (NSAPP_DATA2_RUNASSCRIPT): Define.
5194 * nsfns.m (as_script, as_result, as_status): New static variables.
5195 (ns_run_ascript): New function.
5196 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5197 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5198 the event loop. Get status from as_status (Bug#7276).
5200 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5201 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5202 the event loop (Bug#7276).
5204 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5206 * gnutls.c (QCgnutls_bootprop_priority)
5207 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5208 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5209 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5210 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5211 (QCgnutls_bootprop_verify_hostname_error)
5212 (QCgnutls_bootprop_callbacks_verify): Rename from
5213 Qgnutls_bootprop_..., all uses changed.
5215 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5218 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5220 * xfaces.c (Qframe_set_background_mode): Now static.
5221 * dispextern.h (Qframe_set_background_mode): Remove decl.
5223 * process.c (Fnetwork_interface_info): Declare local only if needed.
5225 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5227 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5228 (Fnetwork_interface_list): Allocate in increments of bytes instead
5229 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5230 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5232 (struct ifflag_def): notrailers is smart on OSX.
5233 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5234 Get hardware address with getifaddrs if available.
5236 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5238 * xdisp.c (iterate_out_of_display_property): xassert that
5239 IT->position is set to within IT->object's boundaries. Break from
5240 the loop as soon as EOB is reached; avoids infloops in redisplay
5241 when IT->position is set up wrongly due to some bug.
5242 Set IT->current to match the bidi iterator unconditionally.
5243 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5244 entry. Force push_it to save on the stack the current
5245 buffer/string position, to be restored by pop_it. Fix flags in
5246 the iterator structure wrt the object coming from a display
5247 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5248 properties. (Bug#9284)
5250 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5252 * fontset.c (fontset_get_font_group): Add proper type checks.
5255 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5257 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5258 and LC_VERSION_MIN_MACOSX.
5259 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5260 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5262 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5264 * xdisp.c (forward_to_next_line_start): Allow to use the
5265 no-display-properties-and-no-overlays under bidi display.
5266 Set disp_pos in the bidi iterator to avoid searches for display
5267 properties and overlays.
5269 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5271 * editfns.c (Fset_time_zone_rule): Document relationship with the
5274 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5275 the font entity extracted from the cache (Bug#8109).
5277 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5279 * composite.c (autocmp_chars): Don't reset point. That is done by
5280 restore_point_unwind (Bug#5984).
5282 2011-08-07 Juri Linkov <juri@jurta.org>
5284 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5285 to show the arg `TIME' instead of `TIMEVAL'.
5287 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5289 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5290 display property strides EOL and includes a newline, as in
5291 longlines-mode. (Bug#9254)
5292 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5293 word-wrap under bidirectional display. (Bug#9224)
5295 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5296 is non-zero, even if the data buffer is NULL. Fixes a crash in
5297 vertical-motion with longlines-mode. (Bug#9254)
5299 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5301 * bidi.c <bidi_cache_total_alloc>: Now static.
5302 (bidi_initialize): Initialize bidi_cache_total_alloc.
5304 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5307 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5308 amount allocated this far in `bidi_cache_total_alloc'.
5309 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5310 non-zero, only free the data buffer without restoring the cache
5311 contents. All callers changed.
5313 * dispextern.h (bidi_unshelve_cache): Update prototype.
5315 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5316 (move_it_in_display_line, move_it_to)
5317 (move_it_vertically_backward, move_it_by_lines): Replace the call
5318 to xfree to an equivalent call to bidi_unshelve_cache.
5319 (move_it_in_display_line_to): Fix logic of returning
5320 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5322 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5324 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5325 came from a string character with a `cursor' property. (Bug#9229)
5327 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5329 * Makefile.in (LIB_PTHREAD): New variable.
5330 (LIBES): Add LIB_PTHREAD (Bug#9216).
5332 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5333 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5335 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5337 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5339 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5341 * xterm.c (x_find_topmost_parent): New function.
5342 (x_set_frame_alpha): Find topmost parent window with
5343 x_find_topmost_parent and set the property there also (bug#9181).
5344 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5346 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5348 * callproc.c (Fcall_process): Avoid vfork clobbering
5349 the local vars buffer, coding_systems, current_dir.
5351 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5353 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5355 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5357 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5358 so that it is not optimized away.
5360 * xdisp.c (compute_display_string_pos): Remove unused local.
5362 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5364 Fix slow cursor motion and scrolling in large buffers with
5365 selective display, like Org Mode buffers. (Bug#9218)
5367 * dispextern.h (struct bidi_it): New member disp_prop_p.
5369 * xdisp.c: Remove one-slot cache of display string positions.
5370 (compute_display_string_pos): Accept an additional argument
5371 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5372 for a display string or property. If found, set DISP_PROP_P
5375 * bidi.c (bidi_fetch_char): Accept an additional argument
5376 DISP_PROP_P, and pass it to compute_display_string_pos.
5377 Only handle text covered by a display string if DISP_PROP_P is returned
5378 non-zero. All callers of bidi_fetch_char changed.
5380 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5382 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5384 2010-12-03 Don March <don@ohspite.net>
5386 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5387 last character M-[char] is translated to ESC [char] (bug#7541).
5389 2011-08-02 Kenichi Handa <handa@m17n.org>
5391 * lisp.h (uniprop_table): Extern it.
5393 * chartab.c (uniprop_table): Make it non-static.
5395 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5397 * xdisp.c (forward_to_next_line_start): Accept additional argument
5398 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5400 (reseat_at_next_visible_line_start): Use the bidi iterator state
5401 returned by forward_to_next_line_start to restore the state of
5402 it->bidi_it after backing up to previous newline. (Bug#9212)
5404 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5406 * regex.c (re_comp): Protoize.
5407 (re_exec): Fix return type.
5408 (regexec): Fix type of `ret'. (Bug#9203)
5410 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5412 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5413 This is needed if max-image-size is a floating-point number.
5415 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5417 * print.c (print_object): Print empty symbol as ##.
5419 * lread.c (read1): Read ## as empty symbol.
5421 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5423 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5424 setting frame foreground color (Bug#9175).
5425 (x_set_background_color): Likewise.
5427 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5428 contents (Bug#9176).
5429 (EmacsTooltip -init): Remove bezels and add shadows to
5432 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5433 or scroll bar (Bug#8470).
5435 * nsfont.m (nsfont_open): Remove assignment to voffset and
5436 unnecessary vars hshink, expand, hd, full_height, min_height.
5437 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5439 * nsterm.h (nsfont_info): Remove voffset field.
5441 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5443 Implement strike-through and overline on NextStep (Bug#8863).
5445 * nsfont.m (nsfont_open): Use underline position provided by font,
5446 instead of hard-coded value of 2.
5447 (nsfont_draw): Call ns_draw_text_decoration instead.
5449 * nsterm.h: Add declaration for ns_draw_text_decoration.
5451 * nsterm.m (ns_draw_text_decoration): New function for drawing
5452 underline, overline, and strike-through.
5453 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5454 ns_draw_text_decoration. Change treatment of cursor drawing to
5455 accommodate underlining, etc.
5457 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5459 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5462 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5464 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5465 Without this fix, if a signal arrives just after memory fills up,
5466 'malloc' might be invoked reentrantly.
5468 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5469 In other words, assume that every image size is allowed, on non-X
5470 hosts. This assumption is probably wrong, but it lets Emacs compile.
5472 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5474 * regex.c (re_iswctype): Convert return values to boolean.
5476 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5478 * xdisp.c (compute_display_string_pos): Don't use cached display
5479 string position if the buffer had its restriction changed.
5482 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5484 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5486 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5488 Integer signedness and overflow and related fixes. (Bug#9079)
5490 * bidi.c: Integer size and overflow fixes.
5491 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5492 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5493 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5494 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5495 (bidi_find_other_level_edge):
5496 Use ptrdiff_t instead of EMACS_INT where either will do.
5497 This works better on 32-bit hosts configured --with-wide-int.
5498 (bidi_cache_ensure_space): Check for size-calculation overflow.
5499 Use % rather than repeated addition, for better worst-case speed.
5500 Don't set bidi_cache_size until after xrealloc returns, because it
5502 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5503 (bidi_cache_ensure_space): Also check that the bidi cache size
5504 does not exceed that of the largest Lisp string or buffer. See Eli
5505 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5507 * alloc.c (__malloc_size_t): Remove.
5508 All uses replaced by size_t. See Andreas Schwab's note
5509 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5511 * image.c: Improve checking for integer overflow.
5512 (check_image_size): Assume that f is nonnull, since
5513 it is always nonnull in practice. This is one less thing to
5514 worry about when checking for integer overflow later.
5515 (x_check_image_size): New function, which checks for integer
5516 overflow issues inside X.
5517 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5518 This removes the need for a memory_full check.
5519 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5520 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5521 (xbm_read_bitmap_data): Change locals back to 'int', since
5522 their values must fit in 'int'.
5523 (xpm_load_image, png_load, tiff_load):
5524 Invoke x_create_x_image_and_pixmap earlier,
5525 to avoid much needless work if the image is too large.
5526 (tiff_load): Treat overly large images as if
5527 x_create_x_image_and_pixmap failed, not as malloc failures.
5528 (gs_load): Use x_check_image_size.
5530 * gtkutil.c: Omit integer casts.
5531 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5532 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5534 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5536 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5537 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5538 would wrongly return t on a 64-bit host.
5540 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5541 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5542 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5543 and therefore cause GCC to emit a bogus diagnostic in some cases.
5545 * image.c: Integer signedness and overflow and related fixes.
5546 This is not an exhaustive set of fixes, but it's time to
5547 record what I've got.
5548 (lookup_pixel_color, check_image_size): Remove redundant decls.
5549 (check_image_size): Don't assume that arbitrary EMACS_INT values
5550 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5551 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5552 (tiff_load, imagemagick_load_image):
5553 Check for overflow in size calculations.
5554 (x_create_x_image_and_pixmap): Remove unnecessary test for
5555 xmalloc returning NULL; that can't happen.
5556 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5557 (xpm_color_bucket): Use better integer hashing function.
5558 (xpm_cache_color): Don't possibly over-allocate memory.
5559 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5560 (gif_memory_source):
5561 Use ptrdiff_t, not int or size_t, to record sizes.
5562 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5563 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5564 either works, as we prefer signed integers.
5565 (tiff_read_from_memory, tiff_write_from_memory):
5566 Return tsize_t, not size_t, since that's what the TIFF API wants.
5567 (tiff_read_from_memory): Don't fail simply because the read would
5568 go past EOF; instead, return a short read.
5569 (tiff_load): Omit no-longer-needed casts.
5570 (Fimagemagick_types): Don't assume size fits into 'int'.
5572 Improve hashing quality when configured --with-wide-int.
5573 * fns.c (hash_string): New function, taken from sxhash_string.
5574 Do not discard information about ASCII character case; this
5575 discarding is no longer needed.
5576 (sxhash-string): Use it. Change sig to match it. Caller changed.
5577 * lisp.h: Declare it.
5578 * lread.c (hash_string): Remove, since we now use fns.c's version.
5579 The fns.c version returns a wider integer if --with-wide-int is
5580 specified, so this should help the quality of the hashing a bit.
5582 * emacs.c: Integer overflow minor fix.
5583 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5584 Define only if GNU_LINUX.
5585 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5587 * dispnew.c: Integer signedness and overflow fixes.
5588 Remove unnecessary forward decls, that were a maintenance hassle.
5589 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5591 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5592 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5593 (prepare_desired_row, line_draw_cost):
5594 Use int, not unsigned, where either works.
5595 (save_current_matrix, restore_current_matrix):
5596 Use ptrdiff_t, not size_t, where either works.
5597 (init_display): Check for overflow more accurately, and without
5598 relying on undefined behavior.
5600 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5601 Remove, replacing with the new symbols in lisp.h. All uses changed.
5602 * fileio.c (make_temp_name):
5603 * filelock.c (lock_file_1, lock_file):
5604 * xdisp.c (message_dolog):
5605 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5606 Use pMd etc. instead.
5607 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5608 replacing the pWIDE etc. symbols removed from editfns.c.
5610 * keyboard.h (num_input_events): Now uintmax_t.
5611 This is (very slightly) less likely to mess up due to wraparound.
5614 * buffer.c: Integer signedness fixes.
5615 (alloc_buffer_text, enlarge_buffer_text):
5616 Use ptrdiff_t rather than size_t when either will do, as we prefer
5619 * alloc.c: Integer signedness and overflow fixes.
5620 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5621 (__malloc_size_t): Default to size_t, not to int.
5622 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5623 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5624 Prefer ptrdiff_t to size_t when either would do, as we prefer
5626 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5627 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5628 Now const. Initialize with values that are in range even if char
5630 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5631 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5632 These functions do the right thing with sizes > 2**32.
5633 (check_depth): Now ptrdiff_t, not int.
5634 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5635 Adjust to new way of storing sizes. Check for size overflow bugs
5637 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5638 slightly wrong anyway, as it missed one instance of
5639 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5640 (refill_memory_reserve): Omit needless cast to size_t.
5641 (mark_object_loop_halt): Mark as externally visible.
5643 * xselect.c: Integer signedness and overflow fixes.
5644 (Fx_register_dnd_atom, x_handle_dnd_message):
5645 Use ptrdiff_t, not size_t, since we prefer signed.
5646 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5647 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5648 x_dnd_atoms_size and x_dnd_atoms_length.
5650 * doprnt.c: Prefer signed to unsigned when either works.
5652 * doprnt.c (doprnt):
5654 * xdisp.c (vmessage):
5655 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5656 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5657 prefer signed arithmetic to avoid comparison confusion.
5658 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5659 but is a bit tricky.
5661 Assume freestanding C89 headers, string.h, stdlib.h.
5662 * data.c, doprnt.c, floatfns.c, print.c:
5663 Include float.h unconditionally.
5664 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5665 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5666 * regex.c: Likewise for stddef.h, string.h.
5667 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5668 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5669 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5670 (STDC_HEADERS): Remove obsolete defines.
5671 * sysdep.c: Include limits.h unconditionally.
5673 Assume support for memcmp, memcpy, memmove, memset.
5674 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5675 * regex.c (memcmp, memcpy):
5676 Remove; we assume C89 now.
5678 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5679 (__malloc_safe_bcopy): Remove; no longer needed.
5681 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5682 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5683 well either way, and we prefer signed to unsigned.
5685 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5687 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5688 closes the connection while we're reading (bug#9182).
5690 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5692 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5693 are specified (Bug#9168).
5695 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5697 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5698 Found by GCC static checking and --with-wide-int on a 32-bit host.
5700 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5702 * xdisp.c (compute_display_string_pos): Fix logic of caching
5703 previous display string position. Initialize cached_prev_pos to
5704 -1. Fixes slow-down at the beginning of a buffer.
5706 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5708 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5709 for attrs[LFACE_FONTSET_INDEX].
5711 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5713 * xml.c (parse_region): Remove unused local
5714 that was recently introduced.
5716 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5718 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5719 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5721 * xdisp.c (move_it_in_display_line_to): Record the best matching
5722 position for TO_CHARPOS while scanning the line, and restore it on
5723 exit if none of the characters scanned was an exact match.
5724 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5725 when exact match is impossible due to invisible text, and the
5726 lines are truncated.
5728 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5730 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5733 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5735 Fix a significant slow-down of cursor motion with C-n, C-p,
5736 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5737 auto-repeat under bidi redisplay in fontified buffers.
5738 * xdisp.c (compute_stop_pos_backwards): New function.
5739 (next_element_from_buffer): Call compute_stop_pos_backwards to
5740 find a suitable prev_stop when we find ourselves before
5742 (reseat): Don't look for prev_stop, as that could mean a very long
5744 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5745 <cached_disp_overlay_modiff>: Cache for last found display string
5747 (compute_display_string_pos): Return the cached position if asked
5748 about the same buffer in the same area of character positions, and
5749 the buffer wasn't changed since the time the display string
5750 position was cached.
5752 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5754 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5755 is an integer, which is important for empty lines. (Bug#9149)
5757 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5759 * frame.c (Fmodify_frame_parameters): In tty case, update the
5760 default face if necessary (Bug#4238).
5762 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5764 * editfns.c (Fstring_to_char): No need to explain what a character
5765 is in the docstring (Bug#6576).
5767 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5769 * xml.c (parse_region): Make sure we always return a tree.
5771 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5773 * xml.c (parse_region): If a document contains only comments,
5776 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5778 * xml.c (make_dom): Return comments, too.
5780 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5783 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5784 and the surrounding thread.
5785 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5786 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5787 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5789 * s/openbsd.h (BROKEN_SIGIO): Define.
5790 * unexelf.c (unexec) [__OpenBSD__]:
5791 Don't update the .mdebug section of the Alpha COFF symbol table.
5793 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5795 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5798 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5800 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5801 This fixes some race conditions on the permissions of any newly
5804 * alloc.c (valid_pointer_p): Use pipe, not open.
5805 This fixes some permissions issues when debugging.
5807 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5808 If fchown fails to set both uid and gid, try to set just gid,
5809 as that is sometimes allowed. Adjust the file's mode to eliminate
5810 setuid or setgid bits that are inappropriate if fchown fails.
5812 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5814 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5815 to compare Lisp_Objects.
5816 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5817 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5818 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5820 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5822 * lread.c (read_integer): Unread even EOF character.
5823 (read1): Likewise. Properly record start position of symbol.
5825 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5826 symbol character follows.
5828 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5830 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5831 This works around a problem with the previous change to Fcopy_file.
5832 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5833 and without this change, GCC might complain about discarding
5834 fchown's return value.
5836 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5838 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5840 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5842 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5844 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5846 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5847 it's used from the C level.
5849 * process.c: Use the same condition for POLL_FOR_INPUT in both
5850 keyboard.c and process.c (bug#1858).
5852 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5854 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5855 (Fgnutls_boot): Use it.
5857 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5859 * doc.c (Fsubstitute_command_keys): Revert last change.
5861 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5863 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5864 quotes the next character, and doesn't affect other longer
5865 sequences (bug#8935).
5867 * lread.c (syms_of_lread): Clarify that is isn't only
5868 `eval-buffer' and `eval-defun' that's affected by
5869 `lexical-binding' (bug#8460).
5871 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5873 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5874 bidi redisplay when a line includes both an image and is truncated.
5876 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5878 Fix minor problems found by static checking.
5879 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5880 (elsz): Now a signed constant, not a size_t var. We prefer signed
5881 types to unsigned, to avoid integer comparison confusion. Without
5882 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5883 "cannot optimize loop, the loop counter may overflow", a symptom
5885 * indent.c (Fvertical_motion): Mark locals as initialized.
5886 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5888 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5890 * search.c (Fre_search_backward): Mention `case-fold-search' in
5891 all the re_search_* functions (bug#8138).
5893 * keyboard.c (Fopen_dribble_file): Document when the file is
5896 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5898 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5901 Support bidi reordering of display and overlay strings.
5902 * xdisp.c (compute_display_string_pos)
5903 (compute_display_string_end): Accept additional argument STRING.
5904 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5905 (reseat_to_string): Initialize bidi_it->string.s and
5906 bidi_it->string.schars.
5907 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5908 NULL (avoids a crash in bidi_paragraph_init).
5909 Initialize itb.string.lstring.
5910 (init_iterator): Call bidi_init_it only of a valid
5911 buffer position was specified. Initialize paragraph_embedding to
5913 (reseat_to_string): Initialize the bidi iterator.
5914 (display_string): If we need to ignore text properties of
5915 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5916 original value of -1 will not work with bidi.)
5917 (compute_display_string_pos): First arg is now struct
5918 `text_pos *'; all callers changed. Support display properties on
5920 (compute_display_string_end): Support display properties on Lisp
5922 (init_iterator, reseat_1, reseat_to_string): Initialize the
5923 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5924 when iterating on a string not from display properties).
5925 (compute_display_string_pos, compute_display_string_end):
5926 Fix calculation of the object to scan. Fixes an error when using
5928 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5929 base_level_stop; instead, set base_level_stop to BEGV.
5930 Fixes crashes in vertical-motion.
5931 (next_element_from_buffer): Improve commentary for when
5932 the iterator is before prev_stop.
5933 (init_iterator): Initialize bidi_p from the default value of
5934 bidi-display-reordering, not from buffer-local value. Use the
5935 buffer-local value only if initializing for buffer iteration.
5936 (handle_invisible_prop): Support invisible properties on strings
5937 that are being bidi-reordered.
5938 (set_iterator_to_next): Support bidi reordering of C strings and
5940 (next_element_from_string): Support bidi reordering of Lisp
5942 (handle_stop_backwards): Support Lisp strings as well.
5943 (display_string): Support display of R2L glyph rows.
5944 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5945 (init_iterator): Don't initialize it->bidi_p for strings
5947 (reseat_to_string): Initialize it->bidi_p for strings here.
5948 (next_element_from_string, next_element_from_c_string)
5949 (next_element_from_buffer): Add xassert's for correspondence
5950 between IT's object being iterated and it->bidi_it.string
5952 (face_before_or_after_it_pos): Support bidi iteration.
5953 (next_element_from_c_string): Handle the case of the first string
5954 character that is not the first one in the visual order.
5955 (get_visually_first_element): New function, refactored from common
5956 parts of next_element_from_buffer, next_element_from_string, and
5957 next_element_from_c_string.
5958 (tool_bar_lines_needed, redisplay_tool_bar)
5959 (display_menu_bar): Force left-to-right direction. Add a FIXME
5960 comment for making that be controlled by a user option.
5961 (push_it, pop_it): Save and restore the state of the
5962 bidi iterator. Save and restore the bidi_p flag.
5963 (pop_it): Iterate out of display property for string iteration as
5965 (iterate_out_of_display_property): Support iteration over strings.
5966 (handle_single_display_spec): Set up it->bidi_it for iteration
5967 over a display string, and call bidi_init_it.
5968 (handle_single_display_spec, next_overlay_string)
5969 (get_overlay_strings_1, push_display_prop): Set up the bidi
5970 iterator for displaying display or overlay strings.
5971 (forward_to_next_line_start): Don't use the shortcut if
5973 (back_to_previous_visible_line_start): If handle_display_prop
5974 pushed the iterator stack, restore the internal state of the bidi
5975 iterator by calling bidi_pop_it same number of times.
5976 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5977 and we are bidi-iterating, don't decrement the iterator position;
5978 instead, set the first_elt flag in the bidi iterator, to produce
5980 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5981 (push_display_prop): xassert that we are iterating a buffer.
5982 (push_it, pop_it): Save and restore paragraph_embedding member.
5983 (handle_single_display_spec, next_overlay_string)
5984 (get_overlay_strings_1, reseat_1, reseat_to_string)
5985 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5986 correctly. Don't assume unibyte strings are not bidi-reordered.
5987 (compute_display_string_pos)
5988 (compute_display_string_end): Fix handling the case of C string.
5989 (push_it, pop_it): Save and restore from_disp_prop_p.
5990 (handle_single_display_spec, push_display_prop): Set the
5991 from_disp_prop_p flag.
5992 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5993 (pop_it): Call iterate_out_of_display_property only if we are
5994 popping after iteration over a string that came from a display
5995 property. Fix a typo in popping stretch info. Add an assertion
5996 for verifying that the iterator position is in sync with the bidi
5998 (handle_single_display_spec, get_overlay_strings_1)
5999 (push_display_prop): Fix initialization of paragraph direction for
6000 string when that of the parent object is not yet determined.
6001 (reseat_1): Call bidi_init_it to resync the bidi
6002 iterator with IT's position. (Bug#7616)
6003 (find_row_edges): If ROW->start.pos gives position
6004 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6005 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6006 Reset the from_disp_prop_p flag.
6007 (SAVE_IT, RESTORE_IT): New macros.
6008 (pos_visible_p, face_before_or_after_it_pos)
6009 (back_to_previous_visible_line_start)
6010 (move_it_in_display_line_to, move_it_in_display_line)
6011 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6012 (try_scrolling, redisplay_window, display_line): Use them when
6013 saving a temporary copy of the iterator and restoring it back.
6014 (back_to_previous_visible_line_start, reseat_1)
6015 (init_iterator): Empty the bidi cache "stack".
6016 (move_it_in_display_line_to): If iterator ended up at
6017 EOL, but we never saw any buffer positions smaller than
6018 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6019 motion in bidi-reordered lines.
6020 (move_it_in_display_line_to): Record prev_method and prev_pos
6021 immediately before the call to set_iterator_to_next. Fixes cursor
6022 motion in bidi-reordered lines with stretch glyphs and strings
6023 displayed in margins. (Bug#8133) (Bug#8867)
6024 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6026 (pos_visible_p): Support positions in bidi-reordered lines.
6027 Save and restore bidi cache.
6029 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6030 (bidi_paragraph_info): Delete unused struct.
6031 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6032 (bidi_cache_start): New variable.
6033 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6035 (bidi_cache_fetch_state, bidi_cache_search)
6036 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6037 (bidi_cache_find, bidi_peek_at_next_level)
6038 (bidi_level_of_next_char, bidi_find_other_level_edge)
6039 (bidi_move_to_visually_next): Compare cache index with
6040 bidi_cache_start rather than with zero.
6041 (bidi_fetch_char): Accept new argument STRING; all callers
6042 changed. Support iteration over a string. Support strings with
6043 display properties. Support unibyte strings. Fix the type of
6044 `len' according to what STRING_CHAR_AND_LENGTH expects.
6045 (bidi_paragraph_init, bidi_resolve_explicit_1)
6046 (bidi_resolve_explicit, bidi_resolve_weak)
6047 (bidi_level_of_next_char, bidi_move_to_visually_next):
6048 Support iteration over a string.
6049 (bidi_set_sor_type, bidi_resolve_explicit_1)
6050 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6051 can now be zero (for strings); special values 0 and -1 were
6052 changed to -1 and -2, respectively.
6053 (bidi_char_at_pos): New function.
6054 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6055 Call it instead of FETCH_MULTIBYTE_CHAR.
6056 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6057 initialized to valid values.
6058 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6060 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6061 the test for valid cached positions. Fix the logic for looking up
6062 the sentinel state in the cache. GCPRO the Lisp string we are
6064 (bidi_push_it, bidi_pop_it): New functions.
6065 (bidi_initialize): Initialize the bidi cache start stack pointer.
6066 (bidi_cache_ensure_space): New function, refactored from part of
6067 bidi_cache_iterator_state. Don't assume the required size is just
6068 one BIDI_CACHE_CHUNK away.
6069 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6070 (bidi_count_bytes, bidi_char_at_pos): New functions.
6071 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6072 always valid if bidi_cache_idx is valid.
6073 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6074 is valid if it's going to be used.
6075 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6076 (bidi_cache_fetch_state, bidi_cache_search)
6077 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6078 (bidi_cache_iterator_state, bidi_cache_find)
6079 (bidi_find_other_level_edge, bidi_cache_start_stack):
6080 All variables related to cache indices are now EMACS_INT.
6082 * dispextern.h (struct bidi_string_data): New structure.
6083 (struct bidi_it): New member `string'. Make flag members be 1-bit
6084 fields, and put them last in the struct.
6085 (compute_display_string_pos, compute_display_string_end):
6087 (bidi_push_it, bidi_pop_it): Add prototypes.
6088 (struct iterator_stack_entry): New members bidi_p,
6089 paragraph_embedding, and from_disp_prop_p.
6090 (struct it): Member bidi_p is now a bit field 1 bit wide.
6091 (bidi_shelve_cache, bidi_unshelve_cache):
6094 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6095 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6096 and vector-like objects.
6098 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6099 cache around display iteration.
6101 * window.c (Fwindow_end, window_scroll_pixel_based)
6102 (displayed_window_lines, Frecenter): Save and restore the bidi
6103 cache around display iteration.
6105 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6107 * editfns.c (Fdelete_region): Clarify the use of the named
6108 parameters (bug#6788).
6110 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6112 * indent.c (Fvertical_motion): Set and restore w->pointm when
6113 saving and restoring the window's buffer (Bug#9006).
6115 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6117 * editfns.c (Fstring_to_char): Clarify just what is returned
6118 (bug#6576). Text by Eli Zaretskii.
6120 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6122 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6124 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6126 * buffer.c (mmap_find): Fix a typo.
6128 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6130 Fix execution of x selection hooks.
6131 * xselect.c (Qx_lost_selection_functions)
6132 (Qx_sent_selection_functions): New vars.
6133 (syms_of_xselect): DEFSYM them.
6134 (x_handle_selection_request): Pass Qx_sent_selection_functions
6135 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6136 (x_handle_selection_clear,x_clear_frame_selections):
6137 Pass Qx_lost_selection_functions rather than
6138 Vx_lost_selection_functions to Frun_hook_with_args.
6140 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6142 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6143 The old code sometimes used this field without initializing it.
6145 * alloc.c (gc_sweep): Don't read past end of array.
6146 In theory, the old code could also have corrupted Emacs internals,
6147 though it'd be very unlikely.
6149 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6151 * character.c (Fcharacterp): Don't advertise optional ignored
6152 argument. (Bug#4026)
6154 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6156 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6159 * window.c (Fset_window_start): Doc fix (bug#4199).
6160 (Fset_window_hscroll): Ditto.
6162 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6164 Fix minor new problems caught by GCC 4.6.1.
6165 * term.c (init_tty): Remove unused local.
6166 * xsettings.c (store_monospaced_changed): Define this function only
6167 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6170 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6172 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6174 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6176 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6177 are the mini-buffer and the echo area (bug#3320).
6179 * term.c (init_tty): Remove support for supdup, c10 and perq
6180 terminals, which are no longer supported (bug#1482).
6182 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6184 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6186 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6188 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6189 for non-popups (Bug#3642).
6191 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6193 * alloc.c (reset_malloc_hooks): Protoize.
6194 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6195 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6196 * cm.c (losecursor): Likewise.
6197 * data.c (fmod): Likewise.
6198 * dispnew.c (swap_glyphs_in_rows): Likewise.
6199 * emacs.c (memory_warning_signal): Likewise.
6200 * floatfns.c (float_error): Likewise.
6201 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6202 (otf_open, font_otf_capability, generate_otf_features)
6203 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6205 * image.c (pbm_read_file): Likewise.
6206 * indent.c (string_display_width): Likewise.
6207 * intervals.c (check_for_interval, search_for_interval)
6208 (inc_interval_count, count_intervals, root_interval)
6209 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6210 * lread.c (defalias): Likewise.
6211 * ralloc.c (r_alloc_check): Likewise.
6212 * regex.c (set_image_of_range_1, set_image_of_range)
6213 (regex_grow_registers): Likewise.
6214 * sysdep.c (strerror): Likewise.
6215 * termcap.c (valid_filename_p, tprint, main): Likewise.
6216 * tparam.c (main): Likewise.
6217 * unexhp9k800.c (run_time_remap, save_data_space)
6218 (update_file_ptrs, read_header, write_header, calculate_checksum)
6219 (copy_file, copy_rest, display_header): Likewise.
6220 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6222 * xdisp.c (check_it): Likewise.
6223 * xfaces.c (register_color, unregister_color, unregister_colors):
6225 * xfns.c (print_fontset_result): Likewise.
6226 * xrdb.c (member, fatal, main): Likewise.
6228 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6230 Fix minor problems found by static checking (Bug#9031).
6231 * chartab.c (char_table_set_range, map_sub_char_table):
6232 Remove unused locals.
6233 (uniprop_table): Now static.
6234 * composite.c (_work_char): Remove unused static var.
6236 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6238 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6240 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6242 * gtkutil.c (qttip_cb): Remove code without function.
6244 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6246 * w32.c (pthread_sigmask): New stub.
6248 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6250 Use pthread_sigmask, not sigprocmask (Bug#9010).
6251 sigprocmask is portable only for single-threaded applications, and
6252 Emacs can be multi-threaded when it uses GTK.
6253 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6255 * callproc.c (Fcall_process):
6256 * process.c (create_process):
6257 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6258 Use pthread_sigmask, not sigprocmask.
6260 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6262 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6263 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6266 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6268 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6269 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6270 (xg_hide_tooltip): Fix comment.
6272 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6273 in registerServicesMenuSendTypes.
6274 (validRequestorForSendType): Don't check ns_return_types.
6276 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6279 2011-07-08 Jason Rumney <jasonr@gnu.org>
6281 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6282 SH_SHOW for hidden windows (Bug#5482).
6284 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6285 frame struct members of non-existent frames (Bug#6284).
6287 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6289 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6290 variable firstTime not needed on OSX >= 10.6.
6291 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6292 >= 10.5. Use setKnobProportion, setDoubleValue.
6294 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6295 (MAC_OS_X_VERSION_10_5): Define if not defined.
6296 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6297 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6298 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6300 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6301 cString and lossyCString on OSX >= 10.4
6303 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6304 sizeToFit on OSX >= 10.2.
6306 * nsimage.m (allocInitFromFile): Don't use deprecated method
6307 bestRepresentationForDevice on OSX >= 10.6.
6309 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6312 * emacs.c: Declare unexec_init_emacs_zone.
6314 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6316 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6318 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6319 on svcsMenu (Bug#8842).
6321 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6323 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6325 * nsterm.m (QUTF8_STRING): Declare.
6326 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6327 (validRequestorForSendType): Return type is (id).
6328 Change indexOfObjectIdenticalTo to indexOfObject.
6329 Check if we have local selection before returning self (Bug#8842).
6330 (writeSelectionToPasteboard): Put local selection into paste board
6331 if we have a local selection (Bug#8842).
6332 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6334 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6335 (ns_get_local_selection): Declare.
6337 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6339 * keymap.c (describe_map_tree): Don't insert a double newline at
6340 the end of the buffer (bug#1169) and return whether we inserted
6343 * callint.c (Fcall_interactively): Change "reading args" to
6344 "providing args" to try to clarify what it does (bug#1010).
6346 2011-07-07 Kenichi Handa <handa@m17n.org>
6348 * composite.c (composition_compute_stop_pos): Ignore a static
6349 composition starting before CHARPOS (Bug#8915).
6351 * xdisp.c (handle_composition_prop): Likewise.
6353 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6355 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6358 2011-07-07 Kenichi Handa <handa@m17n.org>
6360 * character.h (unicode_category_t): New enum type.
6362 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6363 (Qchar_code_property_table): New variable.
6364 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6365 (UNIPROP_COMPRESSED_FORM_P): New macros.
6366 (char_table_ascii): Uncompress the compressed values.
6367 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6368 Uncompress the compressed values.
6369 (sub_char_table_ref_and_range): Likewise.
6370 (char_table_ref_and_range): Uncompress the compressed values.
6371 (sub_char_table_set): New arg is_uniprop. Callers changed.
6372 Uncompress the compressed values.
6373 (sub_char_table_set_range): Args changed. Callers changed.
6374 (char_table_set_range): Adjuted for the above change.
6375 (map_sub_char_table): Delete args default_val and parent. Add arg
6376 top. Give decoded values to a Lisp function.
6377 (map_char_table): Adjust for the above change. Give decoded
6378 values to a Lisp function. Gcpro more variables.
6379 (uniprop_table_uncompress)
6380 (uniprop_decode_value_run_length): New functions.
6381 (uniprop_decoder, uniprop_decoder_count): New variables.
6382 (uniprop_get_decoder, uniprop_encode_value_character)
6383 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6385 (uniprop_encoder, uniprop_encoder_count): New variables.
6386 (uniprop_get_encoder, uniprop_table)
6387 (Funicode_property_table_internal, Fget_unicode_property_internal)
6388 (Fput_unicode_property_internal): New functions.
6389 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6390 Sunicode_property_table_internal, Sget_unicode_property_internal,
6391 and Sput_unicode_property_internal. Defvar_lisp
6392 char-code-property-alist.
6394 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6395 Vunicode_category_table.
6397 * font.c (font_range): Adjust for the change of
6398 Vunicode_category_table.
6400 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6402 * m/iris4d.h: Remove file, move contents ...
6403 * s/irix6-5.h: ... here.
6405 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6407 Remove unportable assumption about struct layout (Bug#8884).
6408 * alloc.c (mark_buffer):
6409 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6410 (clone_per_buffer_values): Don't assume that
6411 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6412 This isn't true in general, and it's particularly not true
6413 if Emacs is configured with --with-wide-int.
6414 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6415 New macros, used in the buffer.c change.
6417 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6419 * xsettings.c: Use both GConf and GSettings if both are available.
6420 (store_config_changed_event): Add comment.
6421 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6422 (store_tool_bar_style_changed): New functions.
6423 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6424 (struct xsettings): Move font inside HAVE_XFT.
6425 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6426 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6427 Move inside HAVE_XFT.
6428 (something_changed_gsettingsCB): Rename from something_changedCB.
6429 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6431 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6432 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6433 (something_changed_gconfCB): Rename from something_changedCB.
6434 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6435 (parse_settings): Move check for font inside HAVE_XFT.
6436 (read_settings, apply_xft_settings): Add comment.
6437 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6438 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6439 call store_font_name_changed.
6440 (xft_settings_event): Add comment.
6441 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6442 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6443 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6444 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6445 (xsettings_initialize): Call init_gsettings last.
6446 (xsettings_get_system_font, xsettings_get_system_normal_font):
6449 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6451 Random fixes. E.g., (random) never returned negative values.
6452 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6453 subseconds part to the entropy, as that's a bit more random.
6454 Prefer signed to unsigned, since the signedness doesn't matter and
6455 in general we prefer signed. When given a limit, use a
6456 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6457 latter isn't right if USE_2_TAGS_FOR_INTS.
6458 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6459 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6461 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6463 * textprop.c (text_property_stickiness):
6464 Obey Vtext_property_default_nonsticky.
6465 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6466 * w32fns.c (syms_of_w32fns):
6467 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6469 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6471 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6472 This is more efficient than Ffile_directory_p and avoids a minor race.
6474 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6476 * buffer.c (Foverlay_put): Say what the return value is
6479 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6480 is a directory before asking whether to use the file name
6482 (barf_or_query_if_file_exists): Make the "File is a directory"
6483 error be more correct.
6485 * fns.c (Frequire): Remove the mention of the .gz files, since
6486 that's installation-specific, but keep the mention of
6487 `get-load-suffixes'.
6489 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6491 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6492 Report string overflow if the output is too long.
6494 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6496 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6497 (syms_of_gnutls): Remove duplicate DEFSYM for
6498 Qgnutls_bootprop_verify_hostname_error, an error for
6499 Qgnutls_bootprop_verify_error (which is no longer used).
6501 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6502 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6503 Also (re)move comments that are misplaced or no longer relevant.
6505 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6507 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6509 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6511 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6512 and background color parameters if they have been changed.
6514 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6516 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6518 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6520 * xsettings.c (SYSTEM_FONT): Define only when used.
6521 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6523 * keymap.c (access_keymap_1): Now static.
6525 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6527 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6528 leave any prefix arg for the up event (Bug#1586).
6530 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6532 * lread.c (syms_of_lread): Mention single symbols defined by
6533 `defvar' or `defconst' (bug#7154).
6535 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6536 (Frequire): Mention get-load-suffixes.
6538 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6540 * window.h (window): Remove clone_number slot.
6541 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6543 (make_parent_window, make_window, saved_window)
6544 (Fset_window_configuration, save_window_save): Don't deal with
6546 * buffer.c (Qclone_number): Remove declaration.
6547 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6549 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6551 Add multiple inheritance to keymaps.
6552 * keymap.c (Fmake_composed_keymap): New function.
6553 (Fset_keymap_parent): Simplify.
6554 (fix_submap_inheritance): Remove.
6555 (access_keymap_1): New function extracted from access_keymap to handle
6556 embedded parents and handle lists of maps.
6557 (access_keymap): Use it.
6558 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6559 (Fcopy_keymap): Handle embedded parents.
6560 (Fcommand_remapping, define_as_prefix): Simplify.
6561 (Fkey_binding): Simplify.
6562 (syms_of_keymap): Move minibuffer-local-completion-map,
6563 minibuffer-local-filename-completion-map,
6564 minibuffer-local-must-match-map, and
6565 minibuffer-local-filename-must-match-map to Elisp.
6566 (syms_of_keymap): Defsubr make-composed-keymap.
6567 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6568 (parse_menu_item): Trivial simplification.
6570 2011-07-01 Glenn Morris <rgm@gnu.org>
6572 * Makefile.in (SETTINGS_LIBS): Fix typo.
6574 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6576 * coding.c (Fencode_coding_string): Record the last coding system
6577 used, as the function doc string says (bug#8738).
6579 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6581 * xsettings.c (store_monospaced_changed): Take new font as arg and
6582 check for change against current_mono_font.
6583 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6584 (emacs_settings_constructor, emacs_settings_get_property)
6585 (emacs_settings_set_property, emacs_settings_class_init)
6586 (emacs_settings_init, gsettings_obj): Remove.
6587 (something_changedCB): New function for HAVE_GSETTINGS.
6588 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6589 with value as argument.
6590 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6591 g_settings_new (Bug#8967). Do not create gsettings_obj.
6592 Remove calls to g_settings_bind. Connect something_changedCB to
6595 * xgselect.c: Add defined (HAVE_GSETTINGS).
6596 (xgselect_initialize): Ditto.
6598 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6599 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6602 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6604 * eval.c (struct backtrace): Simplify and port the data structure.
6605 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6606 signed bit field, as this assumption is not portable and it makes
6607 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6608 "char debug_on_exit : 1" as this is not portable either; instead,
6609 use the portable "unsigned int debug_on_exit : 1". Remove unused
6610 member evalargs. Remove obsolete comments about cc bombing out.
6612 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6614 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6615 Let HAVE_GSETTINGS override HAVE_GCONF.
6616 (store_monospaced_changed): New function.
6617 (EMACS_SETTINGS): A new type derived from GObject to handle
6618 GSettings notifications.
6619 (emacs_settings_constructor, emacs_settings_get_property)
6620 (emacs_settings_set_property, emacs_settings_class_init):
6622 (gsettings_client, gsettings_obj): New variables.
6623 (GSETTINGS_SCHEMA): New define.
6624 (something_changedCB): Call store_monospaced_changed.
6625 (init_gsettings): New function.
6626 (xsettings_initialize): Call init_gsettings.
6627 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6630 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6633 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6635 * window.c (resize_root_window, grow_mini_window)
6636 (shrink_mini_window): Rename Qresize_root_window to
6637 Qwindow_resize_root_window and Qresize_root_window_vertically to
6638 Qwindow_resize_root_window_vertically.
6640 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6642 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6644 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6646 * makefile.w32-in: Redesign dependencies so they reflect more
6647 clearly which files are directly included by each source file,
6648 and not through other includes.
6650 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6652 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6653 (sort_overlays, overlay_strings): When an overlay's clone number
6654 matches the window's clone number process the overlay even if
6655 the overlay's window property doesn't match the current window.
6657 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6658 (Fwindow_hchild): Rename to Fwindow_left_child.
6659 (Fwindow_next): Rename to Fwindow_next_sibling.
6660 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6661 (resize_window_check): Rename to window_resize_check.
6662 (resize_window_apply): Rename to window_resize_apply.
6663 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6664 (Fdelete_other_windows_internal, resize_frame_windows)
6665 (Fsplit_window_internal, Fdelete_window_internal)
6666 (grow_mini_window, shrink_mini_window)
6667 (Fresize_mini_window_internal): Fix callers accordingly.
6669 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6671 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6672 (emacs_fixed_set_min_size): Remove.
6673 (emacs_fixed_new): Take frame as argument.
6675 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6676 (_EmacsFixedPrivate): Remove minwidth/height.
6677 Add struct frame *f.
6678 (emacs_fixed_init): Initialize priv->f.
6679 (get_parent_class, emacs_fixed_set_min_size): Remove.
6680 (emacs_fixed_new): Set priv->f to argument.
6681 (emacs_fixed_get_preferred_width)
6682 (emacs_fixed_get_preferred_height): Use min_width/height from
6683 frames size_hint to set minimum and natural (Bug#8919).
6684 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6685 and use min_width/height from frames size_hint to set
6686 min_width/height (Bug#8919).
6688 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6689 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6692 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6694 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6695 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6698 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6700 * process.c (wait_reading_process_output): Bypass select if
6701 waiting for a cell while ignoring keyboard input, and input is
6702 pending. Suggested by Jan Djärv (Bug#8869).
6704 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6706 Use gnulib's dup2 module instead of rolling our own.
6707 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6709 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6711 * dispnew.c (scrolling_window): Before scrolling, turn off a
6712 mouse-highlight in the window being scrolled.
6714 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6716 Move DEFSYM to lisp.h and use everywhere.
6718 * character.h (DEFSYM): Move declaration...
6719 * lisp.h (DEFSYM): ...here.
6725 * w32select.c: Don't include character.h.
6727 * alloc.c (syms_of_alloc):
6728 * buffer.c (syms_of_buffer):
6729 * bytecode.c (syms_of_bytecode):
6730 * callint.c (syms_of_callint):
6731 * casefiddle.c (syms_of_casefiddle):
6732 * casetab.c (init_casetab_once):
6733 * category.c (init_category_once, syms_of_category):
6734 * ccl.c (syms_of_ccl):
6735 * cmds.c (syms_of_cmds):
6736 * composite.c (syms_of_composite):
6737 * dbusbind.c (syms_of_dbusbind):
6738 * dired.c (syms_of_dired):
6739 * dispnew.c (syms_of_display):
6740 * doc.c (syms_of_doc):
6741 * editfns.c (syms_of_editfns):
6742 * emacs.c (syms_of_emacs):
6743 * eval.c (syms_of_eval):
6744 * fileio.c (syms_of_fileio):
6745 * fns.c (syms_of_fns):
6746 * frame.c (syms_of_frame):
6747 * fringe.c (syms_of_fringe):
6748 * insdel.c (syms_of_insdel):
6749 * keymap.c (syms_of_keymap):
6750 * lread.c (init_obarray, syms_of_lread):
6751 * macros.c (syms_of_macros):
6752 * msdos.c (syms_of_msdos):
6753 * print.c (syms_of_print):
6754 * process.c (syms_of_process):
6755 * search.c (syms_of_search):
6756 * sound.c (syms_of_sound):
6757 * syntax.c (init_syntax_once, syms_of_syntax):
6758 * terminal.c (syms_of_terminal):
6759 * textprop.c (syms_of_textprop):
6760 * undo.c (syms_of_undo):
6761 * w32.c (globals_of_w32):
6762 * window.c (syms_of_window):
6763 * xdisp.c (syms_of_xdisp):
6764 * xfaces.c (syms_of_xfaces):
6765 * xfns.c (syms_of_xfns):
6766 * xmenu.c (syms_of_xmenu):
6767 * xsettings.c (syms_of_xsettings):
6768 * xterm.c (syms_of_xterm): Use DEFSYM.
6770 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6772 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6774 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6776 Integer and buffer overflow fixes (Bug#8873).
6778 * print.c (printchar, strout): Check for string overflow.
6779 (PRINTPREPARE, printchar, strout):
6780 Don't set size unless allocation succeeds.
6782 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6783 for sizes. Check for string overflow more accurately.
6784 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6786 * macros.c: Integer and buffer overflow fixes.
6787 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6788 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6789 Use ptrdiff_t, not int, for sizes.
6790 Don't increment bufsize until after realloc succeeds.
6791 Check for size-calculation overflow.
6792 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6794 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6796 * lread.c: Integer overflow fixes.
6797 (read_integer): Radix is now EMACS_INT, not int,
6798 to improve quality of diagnostics for out-of-range radices.
6799 Calculate buffer size correctly for out-of-range radices.
6800 (read1): Check for integer overflow in radices, and in
6801 read-circle numbers.
6802 (read_escape): Avoid int overflow.
6803 (Fload, openp, read_buffer_size, read1)
6804 (substitute_object_recurse, read_vector, read_list, map_obarray):
6805 Use ptrdiff_t, not int, for sizes.
6806 (read1): Use EMACS_INT, not int, for sizes.
6807 Check for size overflow.
6809 * image.c (cache_image): Check for size arithmetic overflow.
6811 * lread.c: Integer overflow issues.
6812 (saved_doc_string_size, saved_doc_string_length)
6813 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6814 Now ptrdiff_t, not int.
6815 (read1): Don't assume doc string length fits in int. Check for
6816 out-of-range doc string lengths.
6817 (read_list): Don't assume file position fits in int.
6818 (read_escape): Check for hex character overflow.
6820 2011-06-22 Leo Liu <sdl.web@gmail.com>
6822 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6823 Move to minibuffer.el.
6825 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6827 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6828 The following patches are for when GLYPH_DEBUG && !XASSERT.
6829 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6830 * dispnew.c (flush_stdout):
6831 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6832 Mark as externally visible.
6833 * dispnew.c (check_window_matrix_pointers): Now static.
6834 * dispnew.c (window_to_frame_vpos):
6835 * xfns.c (unwind_create_frame):
6836 * xterm.c (x_check_font): Remove unused local.
6837 * scroll.c (CHECK_BOUNDS):
6838 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6839 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6840 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6841 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6842 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6844 (debug_method_add): Use va_list and vsprintf rather than relying
6845 on undefined behavior with wrong number of arguments.
6846 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6847 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6848 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6849 since we're not interested in debugging glyphs with old libraries.
6850 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6851 GCC 4.6.0's static checking.
6853 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6855 Integer overflow and signedness fixes (Bug#8873).
6856 A few related buffer overrun fixes, too.
6858 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6860 * dispextern.h (struct face.stipple):
6861 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6862 (x_bitmap_mask, x_allocate_bitmap_record)
6863 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6864 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6865 (x_create_bitmap_from_xpm_data):
6866 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6867 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6869 * xfaces.c (load_pixmap):
6870 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6871 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6872 (.bitmaps_last, struct x_output.icon_bitmap):
6873 Use ptrdiff_t, not int, for bitmap indexes.
6874 (x_allocate_bitmap_record): Check for size overflow.
6875 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6877 Use ptrdiff_t, not int, for overlay counts.
6878 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6879 * editfns.c (overlays_around, get_pos_property):
6880 * textprop.c (get_char_property_and_overlay):
6881 * xdisp.c (next_overlay_change, note_mouse_highlight):
6882 * xfaces.c (face_at_buffer_position):
6883 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6884 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6885 (Fnext_overlay_change, Fprevious_overlay_change)
6886 (mouse_face_overlay_overlaps, Foverlays_in):
6887 Use ptrdiff_t, not int, for sizes.
6888 (overlays_at, overlays_in): Check for size-calculation overflow.
6890 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6892 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6893 (x_session_initialize): Do not assume string length fits in int.
6895 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6896 This is unlikely, but can occur if DPI is outlandish.
6898 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6899 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6901 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6902 * xrdb.c (magic_file_p, search_magic_path):
6903 Omit last arg SUFFIX; it was always 0. All callers changed.
6904 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6906 * xfont.c (xfont_match): Avoid need for strlen.
6908 * xfns.c: Don't assume strlen fits in int.
6909 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6911 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6912 not unsigned long, as we prefer signed integers. All callers changed.
6913 Detect integer overflow in repeat count.
6914 (message_dolog): Don't assume print length fits in 39 bytes.
6915 (display_mode_element): Don't assume strlen fits in int.
6917 * termcap.c: Don't assume sizes fit in int and never overflow.
6918 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6919 (gobble_line): Check for size-calculation overflow.
6921 * minibuf.c (Fread_buffer):
6922 * lread.c (intern, intern_c_string):
6923 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6924 Don't assume string length fits in int.
6926 * keyboard.c (parse_tool_bar_item):
6927 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6929 * font.c: Don't assume string length fits in int.
6930 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6931 Use ptrdiff_t, not int.
6932 (font_intern_prop): Don't assume string length fits in int.
6933 Don't assume integer property fits in fixnum.
6934 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6936 * filelock.c: Fix some buffer overrun and integer overflow issues.
6937 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6938 Reformulate so as not to need the command string.
6939 Invoke gzip -cd rather than gunzip, as it's more portable.
6940 (lock_info_type, lock_file_1, lock_file):
6941 Don't assume pid_t and time_t fit in unsigned long.
6942 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6943 (current_lock_owner): Prefer signed type for sizes.
6944 Use memcpy, not strncpy, where memcpy is what is really wanted.
6945 Don't assume (via atoi) that time_t and pid_t fit in int.
6946 Check for time_t and/or pid_t out of range, e.g., via a network share.
6947 Don't alloca where an auto var works fine.
6949 * fileio.c: Fix some integer overflow issues.
6950 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6951 Don't assume string length fits in int.
6952 (directory_file_name): Don't assume string length fits in long.
6953 (make_temp_name): Don't assume pid fits in int, or that its print
6954 length is less than 20.
6956 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6958 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6960 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6962 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6963 We prefer signed integers, even for size calculations.
6965 * emacs.c: Don't assume string length fits in 'int'.
6966 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6967 (main): Don't invoke strlen when not needed.
6969 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6970 (XD_DEBUG_MESSAGE): Don't waste a byte.
6972 * callproc.c (getenv_internal_1, getenv_internal)
6974 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6976 * lread.c (invalid_syntax): Omit length argument.
6977 All uses changed. This doesn't fix a bug, but it simplifies the
6978 code away from its former Hollerith-constant appearance, and it's
6979 one less 'int' to worry about when looking at integer-overflow issues.
6980 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6982 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6983 This didn't break anything, but it didn't help either.
6984 It's confusing to put a bogus integer in a place where the actual
6985 value does not matter.
6986 (LIST_END_P): Remove unused macro and its bogus comment.
6987 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6989 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6990 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6992 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6993 We prefer signed types, and the value cannot exceed the EMACS_INT
6994 range anyway (because otherwise the length would not be representable).
6995 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6996 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6997 This avoids a GCC warning when WIDE_EMACS_INT.
6999 * indent.c (sane_tab_width): New function.
7000 (current_column, scan_for_column, Findent_to, position_indentation)
7001 (compute_motion): Use it. This is just for clarity.
7002 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7004 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7006 * lisp.h (lint_assume): New macro.
7007 * composite.c (composition_gstring_put_cache):
7008 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7010 * editfns.c, insdel.c:
7011 Omit unnecessary forward decls, to simplify future changes.
7013 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7015 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7017 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7018 Use much-faster test for byte-length change.
7019 Don't assume string byte-length fits in 'int'.
7020 Check that character arg fits in 'int'.
7021 (mapcar1): Declare byte as byte, for clarity.
7023 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7025 * fns.c (concat): Catch string overflow earlier.
7026 Do not rely on integer wraparound.
7028 * dispextern.h (struct it.overlay_strings_charpos)
7029 (struct it.selective): Now EMACS_INT, not int.
7030 * xdisp.c (forward_to_next_line_start)
7031 (back_to_previous_visible_line_start)
7032 (reseat_at_next_visible_line_start, next_element_from_buffer):
7033 Don't arbitrarily truncate the value of 'selective' to int.
7035 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7037 * composite.c: Don't truncate sizes to 'int'.
7038 (composition_gstring_p, composition_reseat_it)
7039 (composition_adjust_point): Use EMACS_INT, not int.
7040 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7041 not EMACS_UINT, for indexes.
7043 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7045 * buffer.c: Include <verify.h>.
7046 (struct sortvec.priority, struct sortstr.priority):
7047 Now EMACS_INT, not int.
7048 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7049 (struct sortstr.size, record_overlay_string)
7050 (struct sortstrlist.size, struct sortlist.used):
7051 Don't truncate size to int.
7052 (record_overlay_string): Check for size-calculation overflow.
7053 (init_buffer_once): Check at compile-time, not run-time.
7055 2011-06-22 Jim Meyering <meyering@redhat.com>
7057 Don't leak an XBM-image-sized buffer
7058 * image.c (xbm_load): Free the image buffer after using it.
7060 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7063 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7064 that Sun C diagnosed.
7065 * fns.c (secure_hash): Fix pointer signedness issue.
7066 * intervals.c (static_offset_intervals): New function.
7067 (offset_intervals): Use it.
7069 2011-06-21 Leo Liu <sdl.web@gmail.com>
7072 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7075 * fns.c (secure_hash): Rename from crypto_hash_function and change
7076 the first arg to accept symbols.
7077 (Fsecure_hash): New primitive.
7078 (syms_of_fns): New symbols.
7080 2011-06-20 Deniz Dogan <deniz@dogan.se>
7082 * process.c (Fset_process_buffer): Clarify return value in
7085 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7087 * dispnew.c (add_window_display_history): Use BVAR.
7089 * xdisp.c (debug_method_add): Use BVAR.
7090 (check_window_end, dump_glyph_matrix, dump_glyph)
7091 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7093 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7096 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7097 check till after the cache is created in init_frame_faces.
7099 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7101 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7103 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7105 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7106 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7107 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7109 Improve buffer-overflow checking (Bug#8873).
7110 * fileio.c (Finsert_file_contents):
7111 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7112 Remove the old (too-loose) buffer overflow checks.
7113 They weren't needed, since make_gap checks for buffer overflow.
7114 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7115 The old code merely checked for Emacs fixnum overflow, and relied
7116 on undefined (wraparound) behavior. The new code avoids undefined
7117 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7119 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7120 Tune. Don't use wider integers than needed. Don't use alloca.
7121 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7123 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7125 * insdel.c, lisp.h (buffer_overflow): New function.
7126 (insert_from_buffer_1, replace_range, replace_range_2):
7127 * insdel.c (make_gap_larger):
7128 * editfns.c (Finsert_char):
7129 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7131 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7133 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7135 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7137 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7138 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7140 * fileio.c: Don't assume EMACS_INT fits in off_t.
7141 (emacs_lseek): New static function.
7142 (Finsert_file_contents, Fwrite_region): Use it.
7143 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7145 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7147 * fns.c: Don't overflow int when computing a list length.
7148 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7149 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7150 truncation on 64-bit hosts. Check for QUIT every
7151 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7152 faster and is responsive enough.
7153 (Flength): Report an error instead of overflowing an integer.
7154 (Fsafe_length): Return a float if the value is not representable
7155 as a fixnum. This shouldn't happen except in contrived situations.
7156 (Fnthcdr, Fsort): Don't assume list length fits in int.
7157 (Fcopy_sequence): Don't assume vector length fits in int.
7159 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7160 (header_size, word_size): New constants.
7161 (allocate_vectorlike): Don't check size overflow here.
7162 (allocate_vector): Check it here instead, since this is the only
7163 caller of allocate_vectorlike that could cause overflow.
7164 Check that the new vector's length is representable as a fixnum.
7166 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7167 The previous code was bogus. For example, next_almost_prime (32)
7168 returned 39, which is undesirable as it is a multiple of 3; and
7169 next_almost_prime (24) returned 25, which is a multiple of 5 so
7170 why was the code bothering to check for multiples of 7?
7172 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7174 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7176 Variadic C functions now count arguments with ptrdiff_t.
7177 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7178 Back then I didn't know that the Emacs coding style prefers signed int.
7179 Also, in the meantime I found a few more instances where arguments
7180 were being counted with int, which may truncate counts on 64-bit
7181 machines, or EMACS_INT, which may be unnecessarily wide.
7182 * lisp.h (struct Lisp_Subr.function.aMANY)
7183 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7184 Arg counts are now ptrdiff_t, not size_t.
7185 All variadic functions and their callers changed accordingly.
7186 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7187 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7188 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7189 * callint.c (Fcall_interactively): Check arg count for overflow,
7190 to avoid potential buffer overrun. Use signed char, not 'int',
7191 for 'varies' array, so that we needn't bother to check its size
7192 calculation for overflow.
7193 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7194 * eval.c (apply_lambda):
7195 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7196 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7197 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7199 * callint.c (Fcall_interactively): Don't use index var as event count.
7201 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7202 * mem-limits.h (SIZE): Remove; no longer used.
7204 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7206 Remove unnecessary casts.
7207 * xterm.c (x_term_init):
7208 * xfns.c (x_set_border_pixel):
7209 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7210 These aren't needed now that we assume ANSI C.
7212 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7213 It's more likely to cause problems (due to unsigned overflow)
7216 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7218 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7220 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7222 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7224 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7226 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7228 GLYPH_CODE_FACE returns EMACS_INT, not int.
7229 * dispextern.h (merge_faces):
7230 * xfaces.c (merge_faces):
7231 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7232 Don't assume EMACS_INT fits in int.
7234 * character.h (CHAR_VALID_P): Remove unused parameter.
7235 * fontset.c, lisp.h, xdisp.c: All uses changed.
7237 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7239 * fns.c (concat): Minor tuning based on overflow analysis.
7240 This doesn't fix any bugs. Use int to hold character, instead
7241 of constantly refetching from Emacs object. Use XFASTINT, not
7242 XINT, for value known to be a character. Don't bother comparing
7243 a single byte to 0400, as it's always less.
7245 * floatfns.c (Fexpt):
7246 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7248 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7251 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7253 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7254 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7255 incorrectly succeed when S was a string, because 4294967386 was
7256 truncated before it was used.
7258 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7259 Otherwise, an out-of-range integer could cause undefined behavior
7262 * composite.c: Use int, not EMACS_INT, for characters.
7263 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7264 EMACS_INT, for values that are known to be in character range.
7265 This doesn't fix any bugs but is the usual style inside Emacs and
7266 may generate better code on 32-bit machines.
7268 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7269 This is for reasons similar to the recent CHAR_STRING fix.
7270 * charset.c (Fencode_char): Check that character arg is actually
7271 a character. Pass an int to ENCODE_CHAR.
7272 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7273 wider than 'int', as a compile-time check to prevent future regressions
7276 * character.c (char_string): Remove unnecessary casts.
7278 Make sure a 64-bit char is never passed to CHAR_STRING.
7279 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7280 by silently ignoring the top 32 bits, allowing some values
7281 that were far too large to be valid characters.
7282 * character.h: Include <verify.h>.
7283 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7284 arguments are no wider than unsigned, as a compile-time check
7285 to prevent future regressions in this area.
7287 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7288 (Fsubst_char_in_region):
7290 * xdisp.c (decode_mode_spec_coding):
7291 Adjust to CHAR_STRING's new requirement.
7292 * editfns.c (Finsert_char, Fsubst_char_in_region):
7293 * fns.c (concat): Check that character args are actually
7294 characters. Without this test, these functions did the wrong
7295 thing with wildly out-of-range values on 64-bit hosts.
7297 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7298 These casts should not be needed on 32-bit hosts, either.
7299 * keyboard.c (read_char):
7300 * lread.c (Fload): Remove casts to unsigned.
7302 * lisp.h (UNSIGNED_CMP): New macro.
7303 This fixes comparison bugs on 64-bit hosts.
7304 (ASCII_CHAR_P): Use it.
7305 * casefiddle.c (casify_object):
7306 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7307 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7308 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7309 * dispextern.h (FACE_FROM_ID):
7310 * keyboard.c (read_char): Use UNSIGNED_CMP.
7312 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7313 not to EMACS_INT, to avoid GCC warning.
7315 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7317 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7318 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7319 isn't needed on 32-bit machines.
7321 * buffer.c (Fgenerate_new_buffer_name):
7322 Use EMACS_INT for count, not int.
7323 (advance_to_char_boundary): Return EMACS_INT, not int.
7325 * data.c (Qcompiled_function): Now static.
7327 * window.c (window_body_lines): Now static.
7329 * image.c (gif_load): Rename local to avoid shadowing.
7331 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7332 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7333 * alloc.c (make_save_value): Integer argument is now of type
7335 (mark_object): Use ptrdiff_t, not int.
7336 * lisp.h (pD): New macro.
7337 * print.c (print_object): Use it.
7339 * alloc.c: Use EMACS_INT, not int, to count objects.
7340 (total_conses, total_markers, total_symbols, total_vector_size)
7341 (total_free_conses, total_free_markers, total_free_symbols)
7342 (total_free_floats, total_floats, total_free_intervals)
7343 (total_intervals, total_strings, total_free_strings):
7344 Now EMACS_INT, not int. All uses changed.
7345 (Fgarbage_collect): Compute overall total using a double, so that
7346 integer overflow is less likely to be a problem. Check for overflow
7347 when converting back to an integer.
7348 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7349 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7350 These were 'int' variables that could overflow on 64-bit hosts;
7351 they were never used, so remove them instead of repairing them.
7352 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7353 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7354 Previously, this ceilinged at INT_MAX, but that doesn't work on
7356 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7358 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7359 (allocate_vectorlike): Check for ptrdiff_t overflow.
7360 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7361 when a (possibly-narrower) signed value would do just as well.
7362 We prefer using signed arithmetic, to avoid comparison confusion.
7364 * alloc.c: Catch some string size overflows that we were missing.
7365 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7366 for convenience in STRING_BYTES_MAX.
7367 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7368 The definition here is exact; the one in lisp.h was approximate.
7369 (allocate_string_data): Check for string overflow. This catches
7370 some instances we weren't catching before. Also, it catches
7371 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7372 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7373 and ptrdiff_t and EMACS_INT are both 64 bits.
7375 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7376 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7377 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7379 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7381 * alloc.c (Fmake_string): Check for out-of-range init.
7383 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7385 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7387 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7389 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7390 xg_get_default_scrollbar_width.
7392 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7393 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7394 (style_changed_cb): Call update_theme_scrollbar_width and call
7395 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7396 all frames (Bug#8505).
7397 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7398 Call gtk_window_set_resizable if HAVE_GTK3.
7399 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7400 and height if HAVE_GTK3 (Bug#8505).
7401 (scroll_bar_width_for_theme): New variable.
7402 (update_theme_scrollbar_width): New function.
7403 (xg_get_default_scrollbar_width): Move code to
7404 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7405 (xg_initialize): Call update_theme_scrollbar_width.
7407 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7409 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7411 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7413 * frame.c (make_frame): Call other_buffer_safely instead of
7416 * window.c (temp_output_buffer_show): Call display_buffer with
7417 second argument Vtemp_buffer_show_specifiers and reset latter
7418 immediately after the call.
7419 (Vtemp_buffer_show_specifiers): New variable.
7420 (auto_window_vscroll_p, next_screen_context_lines)
7421 (Vscroll_preserve_screen_position): Remove leading asterisks from
7424 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7426 Fix minor problems found by GCC 4.6.0 static checking.
7427 * buffer.c (Qclone_number): Remove for now, as it's unused.
7428 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7429 (record_buffer): Remove unused local.
7430 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7431 (set_frame_buffer_list): Remove; unused.
7432 * frame.h (other_visible_frames): Remove decl.
7433 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7434 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7435 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7437 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7438 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7439 Define only if HAVE_GPM.
7440 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7441 (update_hints_inhibit): Remove; never set. All uses removed.
7442 * widgetprv.h (emacsFrameClassRec): Remove decl.
7443 * window.c (delete_deletable_window): Now returns void, since it
7444 wasn't returning anything.
7445 (compare_window_configurations): Remove unused locals.
7446 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7447 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7448 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7449 the same widths as pointers. This follows up on the 2011-05-06 patch.
7450 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7451 * xterm.h: Likewise.
7452 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7454 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7456 * makefile.w32-in: Update dependencies.
7457 (LISP_H): Add lib/intprops.h.
7459 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7461 * image.c (gif_load): Add animation frame delay to the metadata.
7462 (syms_of_image): Use DEFSYM. New symbol `delay'.
7464 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7466 * window.c (delete_deletable_window): Re-add.
7467 (Fset_window_configuration): Rewrite to handle dead buffers and
7468 consequently deletable windows.
7469 (window_tree, Fwindow_tree): Remove. Supply functionality in
7471 (compare_window_configurations): Simplify code.
7473 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7475 * image.c (imagemagick_load_image): Fix type mismatch.
7476 (Fimagemagick_types): Likewise.
7478 * window.h (replace_buffer_in_windows): Declare.
7480 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7482 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7483 Qclone_number. Remove external declaration of Qdelete_window.
7484 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7486 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7487 Run Qbuffer_list_update_hook if allowed.
7488 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7489 buffer list implementation.
7490 (other_buffer_safely): New function.
7491 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7492 calls to replace_buffer_in_windows and
7493 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7495 (record_buffer): Inhibit quitting and rewrite using quittable
7496 functions. Run Qbuffer_list_update_hook if allowed.
7497 (Frecord_buffer, Funrecord_buffer): New functions.
7498 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7499 Move switch-to-buffer to window.el.
7500 (bury-buffer): Move to window.el.
7501 (Vbuffer_list_update_hook): New variable.
7503 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7506 * window.h (resize_frame_windows): Move up in code.
7507 (Fwindow_frame): Remove EXFUN.
7508 (replace_buffer_in_all_windows): Remove prototype.
7509 (replace_buffer_in_windows_safely): Add prototype.
7511 * window.c: Declare Qdelete_window static again. Move down
7512 declaration of select_count.
7513 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7514 (Fother_window): Move to window.el.
7515 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7516 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7517 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7519 (replace_buffer_in_windows): Implement by calling
7520 Qreplace_buffer_in_windows.
7521 (replace_buffer_in_all_windows): Remove with some functionality
7522 moved into replace_buffer_in_windows_safely.
7523 (replace_buffer_in_windows_safely): New function.
7524 (select_window_norecord, select_frame_norecord): Move in front
7525 of run_window_configuration_change_hook. Remove now obsolete
7527 (Fset_window_buffer): Rewrite doc-string.
7528 Call Qrecord_window_buffer.
7529 (keys_of_window): Move binding for other-window to window.el.
7531 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7533 * dispextern.h (struct image): Replace data member, whose int_val
7534 and ptr_val fields were not used by anything, with a single
7537 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7538 (gif_clear_image, gif_load, imagemagick_load_image)
7539 (gs_clear_image, gs_load): Callers changed.
7541 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7543 * buffer.h: Include <time.h>, for time_t.
7544 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7546 Fix minor problems found by static checking.
7548 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7550 Make identifiers static if they are not used in other modules.
7551 * data.c (Qcompiled_function, Qframe, Qvector):
7552 * image.c (QimageMagick, Qsvg):
7553 * minibuf.c (Qmetadata):
7554 * window.c (resize_window_check, resize_root_window): Now static.
7555 * window.h (resize_window_check, resize_root_window): Remove decls.
7557 * window.c (window_deletion_count, delete_deletable_window):
7559 (window_body_lines): Now static.
7560 (Fdelete_other_windows_internal): Mark vars as initialized.
7561 Make sure 'resize_failed' is initialized.
7562 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7563 (resize_window_apply): Remove unused local.
7564 * window.h (delete_deletable_window): Remove decl.
7566 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7567 (imagemagick_load_image): Fix pointer signedness problem by changing
7568 last arg from unsigned char * to char *. All uses changed.
7569 Also, fix a local for similar reasons.
7570 Remove unused locals. Remove locals to avoid shadowing.
7571 (fn_rsvg_handle_free): Remove; unused.
7572 (svg_load, svg_load_image): Fix pointer signedness problem.
7573 (imagemagick_load_image): Don't use garbage pointer image_wand.
7575 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7577 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7579 * image.c (gif_load): Fix omitted cast error introduced by
7582 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7584 * window.h (resize_proportionally, orig_total_lines)
7585 (orig_top_line): Remove from window structure.
7586 (set_window_height, set_window_width, change_window_heights)
7587 (Fdelete_window): Remove prototypes.
7588 (resize_frame_windows): Remove duplicate declaration.
7590 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7592 * window.h (resize_frame_windows, resize_window_check)
7593 (delete_deletable_window, resize_root_window)
7594 (resize_frame_windows): Declare prototypes.
7596 * window.c (resize_window_apply): Make definition be "static" to
7597 match the prototype.
7599 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7601 * window.c: Remove declarations of Qwindow_size_fixed,
7602 window_min_size_1, window_min_size_2, window_min_size,
7603 size_window, window_fixed_size_p, enlarge_window, delete_window.
7604 Remove static from declaration of Qdelete_window, it's
7605 temporarily needed by Fbury_buffer.
7606 (replace_window): Don't assign orig_top_line and
7608 (Fdelete_window, delete_window): Remove. Window deletion is
7609 handled by window.el.
7610 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7611 Replace Fdelete_window calls with calls to Qdelete_window.
7612 (Fdelete_other_windows): Remove. Deleting other windows is
7613 handled by window.el.
7614 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7615 handled in window.el.
7616 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7617 Window minimum sizes are handled in window.el.
7618 (shrink_windows, size_window, set_window_height)
7619 (set_window_width, change_window_heights, window_height)
7620 (window_width, CURBEG, CURSIZE, enlarge_window)
7621 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7622 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7623 handled in window.el.
7624 (make_dummy_parent): Rename to make_parent_window and give it a
7625 second argument horflag.
7626 (make_window): Don't set resize_proportionally any more.
7627 (Fsplit_window): Remove. Windows are split in window.el.
7628 (save_restore_action, save_restore_orig_size)
7629 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7630 Resize mini windows in window.el.
7631 (grow_mini_window, shrink_mini_window): Implement by calling
7632 Qresize_root_window_vertically, resize_window_check and
7633 resize_window_apply.
7634 (saved_window, Fset_window_configuration, save_window_save):
7635 Do not handle orig_top_line, orig_total_lines, and
7636 resize_proportionally.
7637 (window_min_height, window_min_width): Move to window.el.
7638 (keys_of_window): Move bindings for delete-other-windows,
7639 split-window, delete-window and enlarge-window to window.el.
7641 * buffer.c: Temporarily extern Qdelete_window.
7642 (Fbury_buffer): Temporarily call Qdelete_window instead of
7643 Fdelete_window (Fbury_buffer will move to window.el soon).
7645 * frame.c (set_menu_bar_lines_1): Remove code handling
7646 orig_top_line and orig_total_lines.
7648 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7649 set_window_height but set heights directly.
7650 (change_frame_size_1): Use resize_frame_windows.
7652 * xdisp.c (init_xdisp): Don't use set_window_height but set
7655 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7656 Use resize_frame_windows instead of change_window_heights and run
7657 run_window_configuration_change_hook.
7659 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7660 instead of change_window_heights and run
7661 run_window_configuration_change_hook.
7663 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7665 * window.c (replace_window): Rename second argument REPLACEMENT to
7666 NEW. New third argument SETFLAG. Rewrite.
7667 (delete_window, make_dummy_parent): Call replace_window with
7669 (window_list_1): Move down in code.
7670 (run_window_configuration_change_hook): Move set_buffer part
7671 before select_frame_norecord part in order to unwind correctly.
7672 Rename count1 to count.
7673 (recombine_windows, delete_deletable_window, resize_root_window)
7674 (Fdelete_other_windows_internal)
7675 (Frun_window_configuration_change_hook, make_parent_window)
7676 (resize_window_check, resize_window_apply, Fresize_window_apply)
7677 (resize_frame_windows, Fsplit_window_internal)
7678 (Fdelete_window_internal, Fresize_mini_window_internal):
7680 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7682 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7684 * window.h (window): Add some new members to window structure -
7685 normal_lines, normal_cols, new_total, new_normal, clone_number,
7686 splits, nest, prev_buffers, next_buffers.
7687 (WINDOW_TOTAL_SIZE): Move here from window.c.
7688 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7690 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7692 (make_dummy_parent): Set new members of windows structure.
7693 (make_window): Move down in code. Handle new members of window
7695 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7696 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7697 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7698 (Fset_window_prev_buffers, Fwindow_next_buffers)
7699 (Fset_window_next_buffers, Fset_window_clone_number):
7701 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7702 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7704 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7705 Argument WINDOW can be now internal window too.
7706 (Fwindow_use_time): Move up in code.
7707 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7709 (Fset_window_configuration, saved_window)
7710 (Fcurrent_window_configuration, save_window_save): Handle new
7711 members of window structure.
7712 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7713 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7714 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7715 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7716 Qget_mru_window, Qresize_root_window,
7717 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7718 Qauto_buffer_name; staticpro them.
7720 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7722 * window.c (Fwindow_total_size, Fwindow_left_column)
7723 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7724 (Fwindow_list_1): New functions.
7725 (window_box_text_cols): Replace with window_body_cols.
7726 (Fwindow_width, Fscroll_left, Fscroll_right):
7727 Use window_body_cols instead of window_box_text_cols.
7728 (delete_window, Fset_window_configuration):
7729 Call delete_all_subwindows with window as argument.
7730 (delete_all_subwindows): Take a window as argument and not a
7732 (window_loop): Remove handling of GET_LRU_WINDOW and
7734 (Fget_lru_window, Fget_largest_window): Move to window.el.
7736 * window.h: Extern window_body_cols instead of
7737 window_box_text_cols. delete_all_subwindows now takes a
7738 Lisp_Object as argument.
7740 * indent.c (compute_motion, Fcompute_motion):
7741 Use window_body_cols instead of window_box_text_cols.
7743 * frame.c (delete_frame): Call delete_all_subwindows with root
7746 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7748 * fns.c (Fputhash): Document return value.
7750 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7752 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7754 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7756 Cons<->int and similar integer overflow fixes (Bug#8794).
7758 Check for overflow when converting integer to cons and back.
7759 * charset.c (Fdefine_charset_internal, Fdecode_char):
7760 Use cons_to_unsigned to catch overflow.
7761 (Fencode_char): Use INTEGER_TO_CONS.
7762 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7763 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7764 * data.c (long_to_cons, cons_to_long): Remove.
7765 (cons_to_unsigned, cons_to_signed): New functions.
7766 These signal an error for invalid or out-of-range values.
7767 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7768 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7769 * font.c (Ffont_variation_glyphs):
7770 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7771 * lisp.h: Include <intprops.h>.
7772 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7773 (cons_to_signed, cons_to_unsigned): New decls.
7774 (long_to_cons, cons_to_long): Remove decls.
7775 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7776 (Fprimitive_undo): Use CONS_TO_INTEGER.
7777 * xfns.c (Fx_window_property): Likewise.
7778 * xselect.c: Include <limits.h>.
7779 (x_own_selection, selection_data_to_lisp_data):
7780 Use INTEGER_TO_CONS.
7781 (x_handle_selection_request, x_handle_selection_clear)
7782 (x_get_foreign_selection, Fx_disown_selection_internal)
7783 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7784 (lisp_data_to_selection_data): Use cons_to_unsigned.
7785 (x_fill_property_data): Use cons_to_signed.
7786 Report values out of range.
7788 Check for buffer and string overflow more precisely.
7789 * buffer.h (BUF_BYTES_MAX): New macro.
7790 * lisp.h (STRING_BYTES_MAX): New macro.
7791 * alloc.c (Fmake_string):
7792 * character.c (string_escape_byte8):
7793 * coding.c (coding_alloc_by_realloc):
7794 * doprnt.c (doprnt):
7795 * editfns.c (Fformat):
7797 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7798 since they may not be the same number.
7799 * editfns.c (Finsert_char):
7800 * fileio.c (Finsert_file_contents):
7801 Likewise for BUF_BYTES_MAX.
7803 * image.c: Use ptrdiff_t, not int, for sizes.
7804 (slurp_file): Switch from int to ptrdiff_t.
7806 (slurp_file): Check that file size fits in both size_t (for
7807 malloc) and ptrdiff_t (for sanity and safety).
7809 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7810 if b->modtime has its maximal value.
7812 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7814 Don't assume time_t can fit into int.
7815 * buffer.h (struct buffer.modtime): Now time_t, not int.
7816 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7817 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7819 Minor fixes for signed vs unsigned integers.
7820 * character.h (MAYBE_UNIFY_CHAR):
7821 * charset.c (maybe_unify_char):
7822 * keyboard.c (read_char, reorder_modifiers):
7823 XINT -> XFASTINT, since the integer must be nonnegative.
7824 * ftfont.c (ftfont_spec_pattern):
7825 * keymap.c (access_keymap, silly_event_symbol_error):
7826 XUINT -> XFASTINT, since the integer must be nonnegative.
7827 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7828 since it makes no difference and we prefer signed.
7829 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7830 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7833 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7835 * window.h (Fwindow_frame): Declare.
7837 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7839 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7840 (SPARE_MEMORY): Always define.
7841 (LARGE_REQUEST): Remove.
7842 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7844 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7846 * lisp.h: Move EXFUNS for Fframe_root_window,
7847 Fframe_first_window and Fset_frame_selected_window to window.h.
7849 * window.h: Move EXFUNS for Fframe_root_window,
7850 Fframe_first_window and Fset_frame_selected_window here from
7853 * frame.c (Fwindow_frame, Fframe_first_window)
7854 (Fframe_root_window, Fframe_selected_window)
7855 (Fset_frame_selected_window): Move to window.c.
7856 (Factive_minibuffer_window): Move to minibuf.c.
7857 (Fother_visible_frames_p): New function.
7859 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7861 * window.c (decode_window, decode_any_window): Move up in code.
7862 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7863 (inhibit_frame_unsplittable): Remove unused variable.
7864 (Fwindow_buffer): Move up and rewrite doc-string.
7865 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7866 (Fwindow_prev): New functions.
7867 (Fwindow_frame): Move here from frame.c. Accept any window as
7869 (Fframe_root_window, Fframe_first_window)
7870 (Fframe_selected_window): Move here from frame.c. Accept frame
7871 or arbitrary window as argument. Update doc-strings.
7872 (Fminibuffer_window): Move up in code.
7873 (Fwindow_minibuffer_p): Move up in code and simplify.
7874 (Fset_frame_selected_window): Move here from frame.c.
7876 (Fselected_window, select_window, Fselect_window): Move up in
7877 code. Minor doc-string fixes.
7879 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7881 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7882 Do not assume that spare memory exists; that assumption is valid
7883 only if SYSTEM_MALLOC.
7884 (LARGE_REQUEST): New macro, so that the issue of large requests
7885 is separated from the issue of spare memory.
7887 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7889 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7892 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7894 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7897 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7899 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7901 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7903 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7904 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7906 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7908 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7910 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7912 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7913 (x_clipboard_manager_save): Add return value.
7914 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7916 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7917 Obey Vx_select_enable_clipboard_manager. Catch errors in
7918 x_clipboard_manager_save (Bug#8779).
7919 (Vx_select_enable_clipboard_manager): New variable.
7920 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7922 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7924 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7926 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7928 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7929 in the current matrix if keep_current_p is non-zero.
7931 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7933 * bidi.c (bidi_level_of_next_char): Fix last change.
7935 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7937 Support bidi reordering of text covered by display properties.
7939 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7940 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7941 (bidi_cache_search, bidi_cache_iterator_state)
7942 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7943 (bidi_level_of_next_char, bidi_move_to_visually_next):
7944 Support character positions inside a run of characters covered by a
7946 (bidi_paragraph_init, bidi_resolve_explicit_1)
7947 (bidi_level_of_next_char): Call bidi_fetch_char and
7948 bidi_fetch_char_advance instead of FETCH_CHAR and
7950 (bidi_init_it): Initialize new members.
7951 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7953 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7954 instead of using explicit *_CHAR codes.
7955 (bidi_resolve_explicit, bidi_resolve_weak):
7956 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7957 bidirectional text is supported only in multibyte buffers.
7958 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7959 it to initialize the frame_window_p member of struct bidi_it.
7960 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7961 (bidi_resolve_explicit, bidi_resolve_weak)
7962 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7963 bidi_it->nchars is non-positive.
7964 (bidi_level_of_next_char): Don't try to lookup the cache for the
7965 next/previous character if nothing is cached there yet, or if we
7966 were just reseat()'ed to a new position.
7968 * xdisp.c (set_cursor_from_row): Set start and stop points
7969 according to the row's direction when priming the loop that looks
7970 for the glyph on which to display cursor.
7971 (single_display_spec_intangible_p): Function deleted.
7972 (display_prop_intangible_p): Reimplement to call
7973 handle_display_spec instead of single_display_spec_intangible_p.
7974 Accept 3 additional arguments needed by handle_display_spec.
7975 This fixes incorrect cursor motion across display property with complex
7976 values: lists, `(when COND...)' forms, etc.
7977 (single_display_spec_string_p): Support property values that are
7978 lists with the argument STRING its top-level element.
7979 (display_prop_string_p): Fix the condition for processing a
7980 property that is a list to be consistent with handle_display_spec.
7981 (handle_display_spec): New function, refactored from the
7982 last portion of handle_display_prop.
7983 (compute_display_string_pos): Accept additional argument
7984 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7985 value of a `display' property is a "replacing spec".
7986 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7987 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7988 the display property, but just return a value indicating whether
7989 the display property will replace the characters it covers.
7990 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7991 frame_window_p members of struct bidi_it.
7992 (compute_display_string_pos, compute_display_string_end):
7994 (push_it): Accept second argument POSITION, where pop_it should
7995 jump to continue iteration.
7996 (reseat_1): Initialize bidi_it.disp_pos.
7998 * keyboard.c (adjust_point_for_property): Adjust the call to
7999 display_prop_intangible_p to its new signature.
8001 * dispextern.h (struct bidi_it): New member frame_window_p.
8002 (bidi_init_it): Update prototypes.
8003 (display_prop_intangible_p): Update prototype.
8004 (compute_display_string_pos, compute_display_string_end):
8006 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8009 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8011 Malloc failure behavior now depends on size of allocation.
8012 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8013 * lisp.h: Change signatures accordingly.
8014 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8015 All callers changed. (Bug#8762)
8017 * gnutls.c: Use Emacs's memory allocators.
8018 Without this change, the gnutls library would invoke malloc etc.
8019 directly, which causes problems on non-SYNC_INPUT hosts, and which
8020 runs afoul of improving memory_full behavior. (Bug#8761)
8021 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8022 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8023 xfree instead of the default malloc, realloc, free.
8024 (Fgnutls_boot): No need to check for memory allocation failure,
8025 since xmalloc does that for us.
8027 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8028 * category.c (hash_get_category_set):
8029 * ccl.c (ccl_driver):
8030 * charset.c (Fdefine_charset_internal):
8031 * charset.h (struct charset.hash_index):
8032 * composite.c (get_composition_id, gstring_lookup_cache)
8033 (composition_gstring_put_cache):
8034 * composite.h (struct composition.hash_index):
8035 * dispextern.h (struct image.hash):
8036 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8037 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8038 (hashfn_equal, hashfn_user_defined, make_hash_table)
8039 (maybe_resize_hash_table, hash_lookup, hash_put)
8040 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8042 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8043 * image.c (make_image, search_image_cache, lookup_image)
8044 (xpm_put_color_table_h):
8045 * lisp.h (struct Lisp_Hash_Table):
8046 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8047 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8048 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8049 * alloc.c (allocate_vectorlike):
8050 Check for overflow in vector size calculations.
8051 * ccl.c (ccl_driver):
8052 Check for overflow when converting EMACS_INT to int.
8053 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8054 need to be updated by these changes.
8055 * fns.c (make_hash_table, maybe_resize_hash_table):
8056 Check for integer overflow with large hash tables.
8057 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8058 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8059 (SXHASH_REDUCE): New macro.
8060 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8061 Use it instead of discarding useful hash info with large hash values.
8062 (sxhash_float): New function.
8063 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8064 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8065 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8066 Rewrite to use FIXNUM_BITS, as this simplifies things.
8067 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8068 Adjust signatures to match updated version of code.
8069 (consing_since_gc): Now EMACS_INT, since a single hash table can
8070 use more than INT_MAX bytes.
8072 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8074 Make it possible to build with GCC-4.6+ -O2 -flto.
8076 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8078 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8080 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8081 Call minibuffer-inactive-mode.
8083 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8085 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8086 Update dependencies.
8088 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8090 * data.c (init_data): Remove code for UTS, this system is not
8093 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8095 Don't force ./temacs to start in terminal mode.
8097 * frame.c (make_initial_frame): Initialize faces in all cases, not
8098 only when CANNOT_DUMP is defined.
8099 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8101 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8103 * dispnew.c (add_window_display_history): Use const for the string
8104 pointer. Remove declaration, not needed.
8106 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8108 Use 'inline', not 'INLINE'.
8109 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8110 * alloc.c, fontset.c (INLINE): Remove.
8111 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8112 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8113 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8114 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8115 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8117 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8119 Make it possible to run ./temacs.
8121 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8122 syms_of_callproc does the same thing. Remove test for
8123 "initialized", do it in the caller.
8124 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8126 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8128 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8129 (read_minibuf): Use get_minibuffer.
8130 (syms_of_minibuf): Use DEFSYM.
8131 (Qmetadata): New var.
8132 * data.c (Qbuffer): Don't make it static.
8133 (syms_of_data): Use DEFSYM.
8135 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8137 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8138 (CCL_CODE_MIN): New macro.
8140 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8142 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8144 * eval.c (Qdebug): Now static.
8145 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8146 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8147 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8149 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8151 * image.c: Various fixes to ImageMagick code comments.
8152 (Fimagemagick_types): Doc fix.
8154 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8156 Minor fixes prompted by GCC 4.6.0 warnings.
8158 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8160 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8161 (x_clipboard_manager_save_all): Move extern decl to ...
8162 * xterm.h: ... here, so that it can be checked for consistency.
8164 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8166 * xselect.c (x_clipboard_manager_save_frame)
8167 (x_clipboard_manager_save_all): New functions.
8168 (Fx_clipboard_manager_save): Lisp function deleted.
8170 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8171 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8173 * xterm.h: Update prototype.
8175 2011-05-28 William Xu <william.xwl@gmail.com>
8177 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8180 2011-05-28 Jim Meyering <meyering@redhat.com>
8182 Avoid a sign-extension bug in crypto_hash_function.
8183 * fns.c (to_uchar): Define.
8184 (crypto_hash_function): Use it to convert some newly-signed
8185 variables to unsigned, to avoid sign-extension bugs. For example,
8186 without this change, (md5 "truc") would evaluate to
8187 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8188 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8189 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8191 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8193 Integer overflow fixes.
8195 * dbusbind.c: Serial number integer overflow fixes.
8196 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8197 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8198 to hold a serial number that is too large for a fixnum.
8199 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8200 Check for serial numbers out of range. Decode any serial number
8201 that was so large that it became a float. (Bug#8722)
8203 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8204 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8205 Use XFASTINT rather than XUINT when numbers are nonnegative.
8206 (xd_append_arg, Fdbus_method_return_internal):
8207 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8208 arguments, check that Lisp number is nonnegative, rather than
8209 silently wrapping negative numbers around. (Bug#8722)
8210 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8213 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8215 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8217 ccl: Add integer overflow checks.
8218 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8219 (IN_INT_RANGE): New macros.
8220 (ccl_driver): Use them to check for integer overflow when
8221 decoding a CCL program. Many of the new checks are whether XINT (x)
8222 fits in int; it doesn't always, on 64-bit hosts. The new version
8223 doesn't catch all possible integer overflows, but it's an
8224 improvement. (Bug#8719)
8226 * alloc.c (make_event_array): Use XINT, not XUINT.
8227 There's no need for unsigned here.
8229 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8230 This follows up to the 2011-05-06 change that substituted uintptr_t
8231 for EMACS_INT. This case wasn't caught back then.
8233 Rework Fformat to avoid integer overflow issues.
8234 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8235 now (part of C89). Include <verify.h>.
8236 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8237 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8238 (Fformat): Avoid the prepass trying to compute sizes; it was only
8239 approximate and thus did not catch overflow reliably. Instead, walk
8240 through the format just once, formatting and computing sizes as we go,
8241 checking for integer overflow at every step, and allocating a larger
8242 buffer as needed. Keep track separately whether the format is
8243 multibyte. Keep only the most-recently calculated precision, rather
8244 than them all. Record whether each argument has been converted to
8245 string. Use EMACS_INT, not int, for byte and char and arg counts.
8246 Support field widths and precisions larger than INT_MAX. Avoid
8247 sprintf's undefined behavior with conversion specifications such as %#d
8248 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8249 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8250 formatting out-of-range floating point numbers with int
8253 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8255 * data.c: Avoid integer truncation in expressions involving floats.
8256 * data.c: Include <intprops.h>.
8257 (arith_driver): When there's an integer overflow in an expression
8258 involving floating point, convert the integers to floating point
8259 so that the resulting value does not suffer from catastrophic
8260 integer truncation. For example, on a 64-bit host (* 4
8261 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8262 Do not rely on undefined behavior after integer overflow.
8264 merge count_size_as_multibyte, parse_str_to_multibyte
8265 * character.c, character.h (count_size_as_multibyte):
8266 Rename from parse_str_to_multibyte; all uses changed.
8267 Check for integer overflow.
8268 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8269 since it's now a duplicate of the other. This is more of
8270 a character than a buffer op, so better that it's in character.c.
8271 * fns.c, print.c: Adjust to above changes.
8273 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8275 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8277 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8279 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8280 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8281 (x_clipboard_manager_save): Now static.
8282 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8284 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8285 (crypto_hash_function): Now static.
8286 Fix pointer signedness problems. Avoid unnecessary initializations.
8288 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8290 * termhooks.h (Vselection_alist): Make it terminal-local.
8292 * terminal.c (create_terminal): Initialize it.
8294 * xselect.c: Support for clipboard managers.
8295 (Vselection_alist): Move to termhooks.h as terminal-local var.
8296 (LOCAL_SELECTION): New macro.
8297 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8298 (symbol_to_x_atom): Remove gratuitous arg.
8299 (x_handle_selection_request, lisp_data_to_selection_data)
8300 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8301 (x_own_selection, x_get_local_selection, x_convert_selection):
8302 New arg, specifying work frame. Use terminal-local Vselection_alist.
8303 (some_frame_on_display): Delete unused function.
8304 (Fx_own_selection_internal, Fx_get_selection_internal)
8305 (Fx_disown_selection_internal, Fx_selection_owner_p)
8306 (Fx_selection_exists_p): New optional frame arg.
8307 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8308 (x_handle_selection_clear): Don't treat other terminals with the
8309 same keyboard specially. Use the terminal-local Vselection_alist.
8310 (x_clear_frame_selections): Use Frun_hook_with_args.
8312 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8314 * xterm.h: Add support for those atoms.
8316 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8318 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8319 (converted_selections, conversion_fail_tag): New global variables.
8320 (x_selection_request_lisp_error): Free the above.
8321 (x_get_local_selection): Remove unnecessary code.
8322 (x_reply_selection_request): Args changed; handle arbitrary array
8323 of converted selections stored in converted_selections.
8324 Separate the XChangeProperty and SelectionNotify steps.
8325 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8326 (x_convert_selection): New function.
8327 (x_handle_selection_event): Simplify.
8328 (x_get_foreign_selection): Don't ignore incoming requests while
8329 waiting for an answer; this will fail when we implement
8330 SAVE_TARGETS, and seems unnecessary anyway.
8331 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8332 (Vx_sent_selection_functions): Doc fix.
8334 2011-05-26 Leo Liu <sdl.web@gmail.com>
8336 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8338 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8340 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8342 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8343 for fringe update if it has periodic bitmap.
8344 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8345 and fringe_bitmap_periodic_p.
8347 * fringe.c (get_fringe_bitmap_data): New function.
8348 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8349 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8350 row. Mark glyph row for fringe update if periodicity changed.
8352 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8353 for fringe update unless it has periodic bitmap.
8355 2011-05-25 Kenichi Handa <handa@m17n.org>
8357 * xdisp.c (get_next_display_element): Set correct it->face_id for
8358 a static composition.
8360 2011-05-24 Leo Liu <sdl.web@gmail.com>
8363 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8365 * fns.c (crypto_hash_function, Fsha1): New function.
8366 (Fmd5): Use crypto_hash_function.
8367 (syms_of_fns): Add Ssha1.
8369 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8371 * gnutls.c: Remove unused macros.
8372 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8373 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8374 Remove macros that are defined and never used.
8375 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8377 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8379 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8380 (Fx_get_selection_internal): Minor cleanup.
8381 (Fx_own_selection_internal): Rename arguments for consistency with
8384 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8386 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8388 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8390 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8392 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8394 * dispnew.c (scrolling_window): Don't exclude the case that the
8395 last enabled row in the desired matrix touches the bottom boundary.
8397 2011-05-21 Glenn Morris <rgm@gnu.org>
8399 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8400 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8401 and add some more files.
8403 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8405 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8406 report_file_error introduced by the change from 2011-05-07.
8408 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8410 * systime.h (Time): Define only if emacs is defined.
8411 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8412 where the include path doesn't have X11/X.h by default. See
8413 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8415 2011-05-20 Kenichi Handa <handa@m17n.org>
8417 * composite.c (find_automatic_composition): Fix previous change.
8419 2011-05-20 Glenn Morris <rgm@gnu.org>
8421 * lisp.mk: New file, split from Makefile.in.
8422 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8423 (shortlisp): Remove.
8424 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8426 2011-05-19 Glenn Morris <rgm@gnu.org>
8428 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8429 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8430 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8431 (lisp): Set the order to that of loadup.el.
8432 (shortlisp): Make it a copy of $lisp.
8433 (SOME_MACHINE_LISP): Remove.
8434 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8435 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8437 2011-05-18 Kenichi Handa <handa@m17n.org>
8439 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8440 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8441 (find_automatic_composition): Mostly rewrite for efficiency.
8443 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8445 * makefile.w32-in: Update dependencies.
8447 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8449 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8450 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8452 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8454 Fix some integer overflow issues, such as string length overflow.
8456 * insdel.c (count_size_as_multibyte): Check for string overflow.
8458 * character.c (lisp_string_width): Check for string overflow.
8459 Use EMACS_INT, not int, for string indexes and lengths; in
8460 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8461 the resulting string length overflows an EMACS_INT; instead,
8462 report a string overflow if no precision given. When checking for
8463 precision exhaustion, use a check that cannot possibly have
8464 integer overflow. (Bug#8675)
8465 * character.h (lisp_string_width): Adjust to new signature.
8467 * alloc.c (string_overflow): New function.
8468 (Fmake_string): Use it. This doesn't change behavior, but saves
8469 a few bytes and will simplify future changes.
8470 * character.c (string_escape_byte8): Likewise.
8471 * lisp.h (string_overflow): New decl.
8473 Fixups, following up to the user-interface timestamp change.
8474 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8475 for UI timestamps, instead of unsigned long.
8476 * msdos.c (mouse_get_pos): Likewise.
8477 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8478 * w32gui.h (Time): Define by including "systime.h" rather than by
8479 declaring it ourselves. (Bug#8664)
8481 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8482 * image.c (clear_image_cache): Likewise.
8484 * term.c (term_mouse_position): Don't assume time_t wraparound.
8486 Be more systematic about user-interface timestamps.
8487 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8488 and sometimes 'EMACS_UINT', to represent these timestamps.
8489 This change causes it to use 'Time' uniformly, as that's what X uses.
8490 This makes the code easier to follow, and makes it easier to catch
8491 integer overflow bugs such as Bug#8664.
8492 * frame.c (Fmouse_position, Fmouse_pixel_position):
8493 Use Time, not unsigned long, for user-interface timestamps.
8494 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8495 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8496 * keyboard.h (last_event_timestamp): Likewise.
8497 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8498 * menu.h (xmenu_show): Likewise.
8499 * term.c (term_mouse_position): Likewise.
8500 * termhooks.h (struct input_event.timestamp): Likewise.
8501 (struct terminal.mouse_position_hook): Likewise.
8502 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8503 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8504 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8505 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8507 * menu.h, termhooks.h: Include "systime.h", for Time.
8509 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8510 Don't assume that the difference between two unsigned long values
8511 can fit into an integer. At this point, we know button_down_time
8512 <= event->timestamp, so the difference must be nonnegative, so
8513 there's no need to cast the result if double-click-time is
8514 nonnegative, as it should be; check that it's nonnegative, just in
8515 case. This bug is triggered when events are more than 2**31 ms
8516 apart (about 25 days). (Bug#8664)
8518 * xselect.c (last_event_timestamp): Remove duplicate decl.
8519 (x_own_selection): Remove needless cast to unsigned long.
8521 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8522 that always fit in int. Use a sentinel instead of a counter, to
8523 avoid a temp and to allay GCC's concerns about possible int overflow.
8524 * frame.h (struct frame): Use int for menu_bar_items_used
8525 instead of EMACS_INT, since it always fits in int.
8527 * menu.c (grow_menu_items): Check for int overflow.
8529 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8531 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8532 Before, the code was not consistent. These values cannot exceed
8533 2**31 - 1 so there's no need to make them unsigned.
8534 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8535 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8536 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8538 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8540 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8541 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8542 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8543 presumably because the widths might not match.
8545 * window.c (size_window): Avoid needless test at loop start.
8547 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8549 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8551 2011-05-12 Drew Adams <drew.adams@oracle.com>
8553 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8555 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8557 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8558 `width' to `bar_area_x' and `bar_area_width', respectively.
8559 (x_scroll_run): Take account of fringe background extension.
8561 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8562 Rename local vars `left' and `width' to `bar_area_x' and
8563 `bar_area_width', respectively.
8564 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8565 background extension.
8567 2011-05-10 Jim Meyering <meyering@redhat.com>
8569 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8571 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8573 * image.c (Finit_image_library): Return t for built-in image types,
8574 like pbm and xbm. (Bug#8640)
8576 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8578 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8580 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8582 * w32console.c (Fset_screen_color): Doc fix.
8583 (Fget_screen_color): New function.
8584 (syms_of_ntterm): Defsubr it.
8586 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8587 unlink the temporary file if Fcall_process didn't create it in the
8589 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8590 child process will be redirected to a file specified with `:file'.
8591 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8592 cue to call_process_cleanup not to close that handle.
8594 2011-05-07 Ben Key <bkey76@gmail.com>
8596 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8597 one of two shell specific rules, either bootstrap-temacs-CMD or
8598 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8599 to the previous implementation of the bootstrap-temacs rule.
8600 The bootstrap-temacs-CMD rule is similar to the previous
8601 implementation of the bootstrap-temacs rule except that it
8602 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8605 These changes, along with some changes to nt/configure.bat,
8606 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8607 earlier fix to add support for --cflags and --ldflags options
8608 that include quotes so that it works whether make uses cmd or
8611 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8613 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8614 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8616 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8617 a string. Handle both cases.
8618 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8619 (Fdbus_register_method): Use Qinvalid_function.
8621 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8623 * makefile.w32-in: Update dependencies.
8624 (LISP_H): Add inttypes.h and stdin.h.
8625 (PROCESS_H): Add unistd.h.
8627 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8629 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8630 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8632 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8634 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8636 * term.c (vfatal): Remove stray call to va_end.
8637 It's not needed and the C Standard doesn't allow it here anyway.
8639 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8640 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8642 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8645 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8647 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8649 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8651 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8653 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8655 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8656 * charset.c (Fdefine_charset_internal): Don't initialize
8657 charset.code_space[15]. The value was garbage, on hosts with
8658 32-bit int (Bug#8600).
8660 * lread.c (read_integer): Be more consistent with string-to-number.
8661 Use string_to_number to do the actual conversion; this avoids
8662 rounding errors and fixes some other screwups. Without this fix,
8663 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8664 (digit_to_number): Move earlier, for benefit of read_integer.
8665 Return -1 if the digit is out of range for the base, -2 if it is
8666 not a digit in any supported base. (Bug#8602)
8668 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8670 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8671 to match comment at start of function. This also removes a
8672 GCC warning about overflow in a 32+64-bit port.
8674 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8676 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8677 Reported by Stefan Monnier in
8678 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8679 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8680 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8682 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8683 (EMACS_UINTPTR): Likewise, with uintptr_t.
8685 * lisp.h: Prefer 64-bit EMACS_INT if available.
8686 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8687 on 32-bit hosts that have 64-bit int, so that they can access
8689 However, temporarily disable this change unless the temporary
8690 symbol WIDE_EMACS_INT is defined.
8692 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8694 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8695 This removes an assumption that EMACS_INT and long are the same
8696 width as pointers. The assumption is true for Emacs porting targets
8697 now, but we want to make other targets possible.
8698 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8699 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8700 In the rest of the code, change types of integers that hold casted
8701 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8702 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8703 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8704 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8705 No need to cast type when ORing.
8706 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8707 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8708 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8709 assume EMACS_INT is the same width as char *.
8710 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8711 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8712 Remove no-longer-needed casts.
8713 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8714 (xg_tool_bar_help_callback, xg_make_tool_item):
8715 Use EMACS_INTPTR to hold an integer
8716 that will be cast to void *; this can avoid a GCC warning
8717 if EMACS_INT is not the same width as void *.
8718 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8719 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8720 (current_message_1, set_message_1):
8721 Use a local to convert to proper width without a cast.
8722 * xmenu.c (dialog_selection_callback): Likewise.
8724 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8725 Also, don't assume VALBITS / RAND_BITS is less than 5,
8726 and don't rely on undefined behavior when shifting a 1 left into
8728 * lisp.h (get_random): Change signature to match.
8730 * lread.c (hash_string): Use size_t, not int, for hash computation.
8731 Normally we prefer signed values; but hashing is special, because
8732 it's better to use unsigned division on hash table sizes so that
8733 the remainder is nonnegative. Also, size_t is the natural width
8734 for hashing into memory. The previous code used 'int', which doesn't
8735 retain enough info to hash well into very large tables.
8736 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8738 * dbusbind.c: Don't possibly lose pointer info when converting.
8739 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8740 Use XPNTR rather than XHASH, so that the high-order bits of
8741 the pointer aren't lost when converting through void *.
8743 * eval.c (Fautoload): Don't double-shift a pointer.
8745 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8747 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8749 * gnutls.c (DEF_GNUTLS_FN):
8750 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8752 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8754 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8757 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8759 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8760 New version that can reserve upto 2GB of heap space.
8762 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8764 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8766 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8768 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8769 `gnutls_certificate_set_x509_key_file'.
8771 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8773 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8774 Update dependencies.
8776 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8778 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8779 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8780 Remove unused parameter `fildes'.
8781 * process.c (read_process_output, send_process): Don't pass it.
8783 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8785 Fix previous change: the library cache is defined in w32.c.
8786 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8787 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8789 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8791 Implement dynamic loading of GnuTLS on Windows.
8793 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8794 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8795 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8798 * gnutls.c (Qgnutls_dll): Define.
8799 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8800 (gnutls_*): Declare function pointers.
8801 (init_gnutls_functions): New function to initialize function pointers.
8802 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8803 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8804 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8805 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8806 (emacs_gnutls_write, emacs_gnutls_read)
8807 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8808 (Fgnutls_available_p): New function.
8809 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8810 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8811 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8813 * image.c: Include w32.h.
8814 (Vimage_type_cache): Delete.
8815 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8816 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8817 (w32_delayed_load): Move to w32.c.
8819 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8821 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8822 (w32_delayed_load): Move from image.c. When loading a library, record
8823 its filename in the :loaded-from property of the library id.
8824 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8825 Initialize and staticpro them.
8826 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8828 * process.c: Include lisp.h before w32.h, not after.
8829 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8830 instead of gnutls_record_check_pending.
8832 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8834 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8836 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8837 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8840 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8842 * xterm.c (x_set_frame_alpha): Do not set property on anything
8843 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8845 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8847 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8849 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8851 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8852 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8853 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8854 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8855 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8856 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8857 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8858 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8859 (Qgnutls_bootprop_callbacks_verify): Make static.
8861 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8863 * callproc.c: Indentation fixup.
8865 * sysdep.c (wait_for_termination_1): Make static.
8866 (wait_for_termination, interruptible_wait_for_termination):
8867 Move after wait_for_termination_1.
8869 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8871 * sysdep.c (interruptible_wait_for_termination): New function
8872 which is like wait_for_termination, but allows keyboard
8875 * callproc.c (Fcall_process): Add (:file "file") as an option for
8877 (Fcall_process_region): Ditto.
8879 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8881 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8882 rather than `XVECTOR (FOO)->size'.
8884 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8885 inttypes.h, as a gnulib replacement is used if it not available in
8888 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8890 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8891 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8892 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8894 * coding.c (coding_alloc_by_realloc): Error out if destination
8895 will grow beyond MOST_POSITIVE_FIXNUM.
8896 (decode_coding_emacs_mule): Abort if there isn't enough place in
8897 charbuf for the composition carryover bytes. Reserve an extra
8898 space for up to 2 characters produced in a loop.
8899 (decode_coding_iso_2022): Abort if there isn't enough place in
8900 charbuf for the composition carryover bytes.
8902 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8904 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8905 aborting when %lld or %lll format is passed.
8906 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8907 %llo or %llx format is passed. (Bug#8545)
8909 * window.c (window_scroll_line_based): Use a marker instead of
8910 simple variables to record original value of point. (Bug#7952)
8912 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8913 produced by %s or %c overflows available buffer space. (Bug#8545)
8915 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8917 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8918 (SIZE_MAX): Move defn after all includes, as they might #define it.
8920 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8922 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8924 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8926 * keyboard.c (Qdelayed_warnings_hook): Define.
8927 (command_loop_1): Run `delayed-warnings-hook'
8928 if Vdelayed_warnings_list is non-nil.
8929 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8930 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8932 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8934 * doprnt.c (doprnt): Don't return value smaller than the buffer
8935 size if the message was truncated. (Bug#8545).
8937 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8939 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8940 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8942 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8944 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8946 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8948 * makefile.w32-in: Update dependencies.
8950 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8952 Improve `doprnt' and its usage. (Bug#8545)
8953 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8954 `format_end'. Remove support for %l as a conversion specifier.
8955 Don't use xrealloc. Improve diagnostics when the %l size modifier
8956 is used. Update the commentary.
8958 * eval.c (verror): Simplify calculation of size_t.
8960 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8963 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8965 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8968 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8970 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8971 This makes this file independent of the recent pseudovector change.
8973 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8975 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8977 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8978 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8979 Remove unused local.
8980 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8982 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8983 GCC 4.6.0 optimizes based on type-based alias analysis.
8984 For example, if b is of type struct buffer * and v of type struct
8985 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8986 != &v->size, and therefore "v->size = 1; b->size = 2; return
8987 v->size;" must therefore return 1. This assumption is incorrect
8988 for Emacs, since it type-puns struct Lisp_Vector * with many other
8989 types. To fix this problem, this patch adds a new type struct
8990 vectorlike_header that documents the constraints on layout of vectors
8991 and pseudovectors, and helps optimizing compilers not get fooled
8992 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8993 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8994 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8996 (XSETPVECTYPE): Rewrite in terms of new macro.
8997 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8998 This is a bit clearer, and further avoids the possibility of
8999 undesirable aliasing.
9000 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9001 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9002 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9003 since Lisp_Subr is a special case (no "next" field).
9004 (ASIZE): Now uses header.size rather than size.
9005 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9006 to avoid the hassle of writing XVECTOR (foo)->header.size.
9007 (struct vectorlike_header): New type.
9008 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9009 object, to help avoid aliasing.
9010 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9011 (SUBRP): Likewise, since Lisp_Subr is a special case.
9012 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9013 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9014 (struct Lisp_Hash_Table): Combine first two members into a single
9015 struct vectorlike_header member. All uses of "size" and "next" members
9016 changed to be "header.size" and "header.next".
9017 * buffer.h (struct buffer): Likewise.
9018 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9019 * frame.h (struct frame): Likewise.
9020 * process.h (struct Lisp_Process): Likewise.
9021 * termhooks.h (struct terminal): Likewise.
9022 * window.c (struct save_window_data, struct saved_window): Likewise.
9023 * window.h (struct window): Likewise.
9024 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9025 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9026 * buffer.c (init_buffer_once): Likewise.
9027 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9029 * process.c (Fformat_network_address): Use local var for size,
9032 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9034 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9035 * data.c (atof): Remove decl; no longer used or needed.
9036 (digit_to_number): Move to lread.c.
9037 (Fstring_to_number): Use new string_to_number function, to be
9038 consistent with how the Lisp reader treats infinities and NaNs.
9039 Do not assume that floating-point numbers represent EMACS_INT
9040 without losing information; this is not true on most 64-bit hosts.
9041 Avoid double-rounding errors, by insisting on integers when
9042 parsing non-base-10 numbers, as the documentation specifies.
9043 * lisp.h (string_to_number): New decl, replacing ...
9044 (isfloat_string): Remove.
9045 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9046 (read1): Do not accept +. and -. as integers; this
9047 appears to have been a coding error. Similarly, do not accept
9048 strings like +-1e0 as floating point numbers. Do not report
9049 overflow for integer overflows unless the base is not 10 which
9050 means we have no simple and reliable way to continue.
9051 Break out the floating-point parsing into a new
9052 function string_to_number, so that Fstring_to_number parses
9053 floating point numbers consistently with the Lisp reader.
9054 (digit_to_number): Move here from data.c. Make it static inline.
9055 (E_CHAR, EXP_INT): Remove, replacing with ...
9056 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9057 (string_to_number): New function, replacing isfloat_string.
9058 This function checks for valid syntax and produces the resulting
9059 Lisp float number too. Rework it so that string-to-number
9060 no longer mishandles examples like "1.0e+". Use strtoumax,
9061 so that overflow for non-base-10 numbers is reported only when
9062 there's no portable and simple way to convert to floating point.
9064 * textprop.c (set_text_properties_1): Rewrite for clarity,
9065 and to avoid GCC warning about integer overflow.
9067 * intervals.h (struct interval): Use EMACS_INT for members
9068 where EMACS_UINT might cause problems. See
9069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9070 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9071 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9073 (offset_intervals): Tell GCC not to worry about length overflow
9074 when negating a negative length.
9076 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9077 (overrun_check_free): Likewise.
9079 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9080 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9083 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9084 (gnutls_make_error): Rename local to avoid shadowing.
9085 (gnutls_emacs_global_deinit): ifdef out; not used.
9086 (Fgnutls_boot): Use const for pointer to readonly storage.
9087 Comment out unused local. Fix pointer signedness problems.
9089 * lread.c (openp): Don't stuff size_t into an 'int'.
9090 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9091 about possible signed overflow.
9093 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9094 (GDK_KEY_g): Don't define if already defined.
9095 (xg_prepare_tooltip): Avoid pointer signedness problem.
9096 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9098 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9099 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9101 * xfns.c (Fx_window_property): Simplify a bit,
9102 to make a bit faster and to avoid GCC 4.6.0 warning.
9103 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9105 * fns.c (internal_equal): Don't assume size_t fits in int.
9107 * alloc.c (compact_small_strings): Tighten assertion a little.
9109 Replace pEd with more-general pI, and fix some printf arg casts.
9110 * lisp.h (pI): New macro, generalizing old pEd macro to other
9111 conversion specifiers. For example, use "...%"pI"d..." rather
9112 than "...%"pEd"...".
9113 (pEd): Remove. All uses replaced with similar uses of pI.
9114 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9115 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9116 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9117 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9118 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9119 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9120 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9122 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9123 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9124 * print.c (safe_debug_print, print_object): Likewise.
9125 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9127 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9128 avoiding the 0 flag, which is not portable.
9129 * process.c (Fmake_network_process): Use pI to avoid cast.
9130 * region-cache.c (pp_cache): Likewise.
9131 * xdisp.c (decode_mode_spec): Likewise.
9132 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9133 behavior on 64-bit hosts with printf arg.
9134 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9135 (x_stop_queuing_selection_requests): Likewise.
9136 (x_get_window_property): Don't truncate byte count to an 'int'
9139 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9140 here, since it parses constructs like leading '-' and spaces,
9141 which are not wanted; and it overflows with large numbers.
9142 Instead, simply match F[0-9]+, which is what is wanted anyway.
9144 * alloc.c: Remove unportable assumptions about struct layout.
9145 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9146 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9147 (allocate_vectorlike, make_pure_vector): Use the new macros,
9148 plus offsetof, to remove unportable assumptions about struct layout.
9149 These assumptions hold on all porting targets that I know of, but
9150 they are not guaranteed, they're easy to remove, and removing them
9151 makes further changes easier.
9153 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9154 This doesn't fix a bug but makes the code clearer.
9155 (string_overrun_cookie): Now const. Use initializers that
9156 don't formally overflow signed char, to avoid warnings.
9157 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9158 can cause Emacs to crash when string overrun checking is enabled.
9159 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9160 multiple of sizeof (EMACS_INT); it need not be, if
9161 alignof(EMACS_INT) < sizeof (EMACS_INT).
9162 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9164 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9166 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9168 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9170 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9171 supposed to be handshaking. (Bug#8556)
9172 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9174 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9176 * lisp.h (Qdebug): List symbol.
9177 * eval.c (Qdebug): Restore global linkage.
9178 * keyboard.c (debug-on-event): New variable.
9179 (handle_user_signal): Break into debugger when debug-on-event
9180 matches the current signal symbol.
9182 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9184 * alloc.c (check_sblock, check_string_bytes)
9185 (check_string_free_list): Convert to standard C.
9187 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9189 * w32.c (emacs_gnutls_push): Fix typo.
9191 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9193 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9194 "cast to pointer from integer of different size".
9196 Improve doprnt and its use in verror. (Bug#8545)
9197 * doprnt.c (doprnt): Document the set of format control sequences
9198 supported by the function. Use SAFE_ALLOCA instead of always
9201 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9202 is one byte too soon. Don't use xrealloc; instead xfree and
9205 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9207 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9210 * gnutls.c: Renamed global_initialized to
9211 gnutls_global_initialized. Added internals for the
9212 :verify-hostname-error, :verify-error, and :verify-flags
9213 parameters of `gnutls-boot' and documented those parameters in the
9214 docstring. Start callback support.
9215 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9216 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9217 on error. Return error code.
9218 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9219 (emacs_gnutls_read): Likewise.
9220 (Fgnutls_boot): Return handshake error code.
9221 (emacs_gnutls_handle_error): New function.
9222 (wsaerror_to_errno): Likewise.
9224 * w32.h (emacs_gnutls_pull): Add prototype.
9225 (emacs_gnutls_push): Likewise.
9227 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9228 (emacs_gnutls_push): Likewise.
9230 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9232 * process.c (wait_reading_process_output): Check if GnuTLS
9233 buffered some data internally if no FDs are set for TLS
9236 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9237 (LIBS): Link to USER_LIBS.
9238 ($(BLD)/gnutls.$(0)): New target.
9240 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9242 * xdisp.c (handle_single_display_spec): Rename the
9243 display_replaced_before_p argument into display_replaced_p, to
9244 make it consistent with the commentary. Fix typos in the
9247 * textprop.c (syms_of_textprop): Remove dead code.
9248 (copy_text_properties): Delete obsolete commentary about an
9249 interface that was deleted long ago. Fix typos in the description
9252 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9253 to changes in oldXMenu/XMenu.h from 2011-04-16.
9254 <menu_help_message, prev_menu_help_message>: Constify.
9255 (IT_menu_make_room): menu->help_text is now `const char **';
9258 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9259 to changes in oldXMenu/XMenu.h from 2011-04-16.
9260 (struct XMenu): Declare `help_text' `const char **'.
9262 * xfaces.c <Qunspecified>: Make extern again.
9264 * syntax.c: Include sys/types.h before including regex.h, as
9267 * doc.c (get_doc_string): Improve the format passed to `error'.
9269 * doprnt.c (doprnt): Improve commentary.
9271 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9273 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9276 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9277 changes in globals.h immediately force recompilation.
9278 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9279 $(CURDIR)/s/ms-w32.h.
9280 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9282 * character.c (Fchar_direction): Function deleted.
9283 (syms_of_character): Don't defsubr it.
9284 <char-direction-table>: Deleted.
9286 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9288 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9289 * doprnt.c: Include limits.h.
9290 (SIZE_MAX): New macro.
9291 (doprnt): Return a size_t value. 2nd arg is now size_t.
9292 Many local variables are now size_t instead of int or unsigned.
9293 Improve overflow protection. Support `l' modifier for integer
9294 conversions. Support %l conversion. Don't assume an EMACS_INT
9295 argument for integer conversions and for %c.
9297 * lisp.h (doprnt): Restore prototype.
9299 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9302 * Makefile.in (base_obj): Add back doprnt.o.
9304 * deps.mk (doprnt.o): Add back prerequisites.
9305 (callint.o): Depend on character.h.
9307 * eval.c (internal_lisp_condition_case): Include the handler
9308 representation in the error message.
9309 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9310 when breaking from the loop.
9312 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9314 * callint.c (Fcall_interactively): When displaying error message
9315 about invalid control letter, pass the character's codepoint, not
9316 a pointer to its multibyte form. Improve display of the character
9317 in octal and display also its hex code.
9319 * character.c (char_string): Use %x to display the (unsigned)
9320 codepoint of an invalid character, to avoid displaying a bogus
9323 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9324 `error', not SYMBOL_NAME itself.
9326 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9327 character arguments to `error'.
9329 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9330 to `error' in error message about FINAL_CHAR argument. Make sure
9331 FINAL_CHAR is a character, and use %c when it is passed as
9332 argument to `error'.
9334 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9336 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9338 * w32.c: Include <time.h>.
9339 (sys_localtime): New function.
9341 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9343 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9345 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9347 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9349 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9352 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9354 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9355 gl_state.e_property when gl_state.object is Qt.
9357 * insdel.c (make_gap_larger): Remove limitation of buffer size
9360 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9362 * xdisp.c (lookup_glyphless_char_display)
9363 (produce_glyphless_glyph): Handle cons cell entry in
9364 glyphless-char-display.
9365 (Vglyphless_char_display): Document it.
9367 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9368 glyphless-char-display.
9370 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9372 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9374 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9376 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9377 definition for no-X builds.
9379 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9381 Static checks with GCC 4.6.0 and non-default toolkits.
9383 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9385 * process.c (keyboard_bit_set): Define only if SIGIO.
9386 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9387 (send_process): Repair possible setjmp clobbering.
9389 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9391 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9393 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9395 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9396 Define only if needed.
9398 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9399 by pacifying GCC about it. Maybe it's time to retire it?
9400 * xfaces.c (USG, __TIMEVAL__): Likewise.
9402 * dispextern.h (struct redisplay_interface): Rename param
9404 * termhooks.h (struct terminal): Likewise.
9405 * xterm.c (xembed_send_message): Likewise.
9407 * insdel.c (make_gap_smaller): Define only if
9408 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9410 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9413 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9414 so that we aren't warned about unused symbols.
9416 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9418 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9420 * xfns.c (x_real_positions): Mark locals as initialized.
9422 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9424 * xterm.c: Fix problems found by static analysis with other toolkits.
9425 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9426 (x_dispatch_event): Declare static if USE_GTK, and
9427 define if USE_GTK || USE_X_TOOLKIT.
9428 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9429 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9430 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9431 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9433 * xmenu.c (menu_help_callback): Pointer type fixes.
9434 Use const pointers when pointing at readonly data. Avoid pointer
9436 (FALSE): Remove unused macro.
9437 (update_frame_menubar): Remove unused decl.
9439 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9441 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9442 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9443 (single_menu_item): Rename local to avoid shadowing.
9445 * keyboard.c (make_lispy_event): Remove unused local var.
9447 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9448 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9450 * bitmaps: Change bitmaps from unsigned char back to the X11
9451 compatible char. Avoid the old compiler warnings about
9452 out-of-range initializers by using, for example, '\xab' rather
9455 * xgselect.c (xgselect_initialize): Check vs interface
9456 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9458 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9460 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9461 to read-only memory.
9463 * fns.c (vector): Remove; this old hack is no longer needed.
9465 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9467 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9469 * xrdb.c (x_load_resources): Omit unused local.
9471 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9472 (x_window): Rename locals to avoid shadowing.
9473 (USG): Use the kludged USG macro, to pacify gcc.
9475 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9476 (x_term_init): Remove local to avoid shadowing.
9478 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9480 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9481 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9483 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9485 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9487 Fix regex.c, syntax.c and friends for buffers > 2GB.
9488 * syntax.h (struct gl_state_s): Declare character position members
9491 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9493 * textprop.c (verify_interval_modification, interval_of):
9494 Declare arguments EMACS_INT.
9496 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9499 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9501 * indent.c (Fvertical_motion): Local variable it_start is now
9504 * regex.c (re_match, re_match_2, re_match_2_internal)
9505 (bcmp_translate, regcomp, regexec, print_double_string)
9506 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9507 (re_compile_pattern, re_exec): Declare arguments and local
9508 variables `size_t' and `ssize_t' and return values `regoff_t', as
9510 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9511 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9512 <compile_stack_type>: `size' and `avail' are now `size_t'.
9514 * regex.h <regoff_t>: Use ssize_t, not int.
9515 (re_search, re_search_2, re_match, re_match_2): Arguments that
9516 specify buffer/string position and length are now ssize_t and
9517 size_t. Return type is regoff_t.
9519 2011-04-16 Ben Key <bkey76@gmail.com>
9521 * nsfont.m: Fixed bugs in ns_get_family and
9522 ns_descriptor_to_entity that were caused by using free to
9523 deallocate memory blocks that were allocated by xmalloc (via
9524 xstrdup). This caused Emacs to crash when compiled with
9525 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9526 --enable-checking=xmallocoverrun). xfree is now used to
9527 deallocate these memory blocks.
9529 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9531 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9533 emacs_write: Accept and return EMACS_INT for sizes.
9534 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9536 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9537 Accept and return EMACS_INT.
9538 (emacs_gnutls_write): Return the number of bytes written on
9540 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9541 (emacs_read, emacs_write): Remove check for negative size, as the
9542 Emacs source code has been audited now.
9543 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9544 (emacs_read, emacs_write): Use it.
9545 * process.c (send_process): Adjust to the new signatures of
9546 emacs_write and emacs_gnutls_write. Do not attempt to store
9547 a byte offset into an 'int'; it might overflow.
9548 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9550 * sound.c: Don't assume sizes fit in 'int'.
9551 (struct sound_device.period_size, alsa_period_size):
9552 Return EMACS_INT, not int.
9553 (struct sound_device.write, vox_write, alsa_write):
9554 Accept EMACS_INT, not int.
9555 (wav_play, au_play): Use EMACS_INT to store sizes and to
9556 record read return values.
9558 2011-04-15 Ben Key <bkey76@gmail.com>
9560 * keyboard.c (Qundefined): Don't declare static since it is used
9562 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9563 static since they are used in nsfont.m.
9565 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9567 * process.c (Qprocessp): Don't declare static.
9568 * lisp.h (Qprocessp): Declare again.
9570 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9572 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9574 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9576 Improve C-level modularity by making more things 'static'.
9578 Don't publish debugger-only interfaces to other modules.
9579 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9580 (verify_bytepos, count_markers): Move decls to the only modules
9582 * region-cache.h (pp_cache): Likewise.
9583 * window.h (check_all_windows): Likewise.
9584 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9586 * sysdep.c (croak): Now static, if
9587 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9588 * syssignal.h (croak): Declare only if not static.
9590 * alloc.c (refill_memory_reserve): Now static if
9591 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9592 * lisp.h (refill_memory_reserve): Declare only if not static.
9594 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9595 Define only if USE_LUCID.
9597 * xrdb.c (x_customization_string, x_rm_string): Now static.
9599 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9600 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9602 * xdisp.c (draw_row_with_mouse_face): Now static.
9603 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9605 * window.h (check_all_windows): Mark externally visible.
9607 * window.c (window_deletion_count): Now static.
9609 * undo.c: Make symbols static if they're not exported.
9610 (last_undo_buffer, last_boundary_position, pending_boundary):
9613 * textprop.c (interval_insert_behind_hooks): Now static.
9614 (interval_insert_in_front_hooks): Likewise.
9616 * term.c: Make symbols static if they're not exported.
9617 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9618 (max_frame_lines, tty_set_terminal_modes):
9619 (tty_reset_terminal_modes, tty_turn_off_highlight):
9620 (get_tty_terminal): Now static.
9621 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9622 * termhooks.h (term_mouse_moveto): Do not declare if
9624 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9625 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9627 * sysdep.c: Make symbols static if they're not exported.
9628 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9630 (sigprocmask_set, full_mask): Remove; unused.
9631 (wait_debugging): Mark as visible.
9632 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9633 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9635 * syntax.c (syntax_temp): Define only if !__GNUC__.
9637 * sound.c (current_sound_device, current_sound): Now static.
9639 * search.c (searchbufs, searchbuf_head): Now static.
9641 * scroll.c (scroll_cost): Remove; unused.
9642 * dispextern.h (scroll_cost): Remove decl.
9644 * region-cache.h (pp_cache): Mark as externally visible.
9646 * process.c: Make symbols static if they're not exported.
9647 (process_tick, update_tick, create_process, chan_process):
9648 (Vprocess_alist, proc_buffered_char, datagram_access):
9649 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9650 (deactivate_process): Mark defn as static, as well as decl.
9651 * lisp.h (create_process): Remove decl.
9652 * process.h (chan_process, Vprocess_alist): Remove decls.
9654 * print.c: Make symbols static if they're not exported.
9655 (print_depth, new_backquote_output, being_printed, print_buffer):
9656 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9657 (print_interval, print_number_index, initial_stderr_stream):
9659 * lisp.h (Fprinc): Remove decl.
9660 (debug_output_compilation_hack): Mark as externally visible.
9662 * sysdep.c (croak): Move decl from here to syssignal.h.
9663 * syssignal.h (croak): Put it here, so the API can be checked when
9664 'croak' is called from dissociate_if_controlling_tty.
9666 * minibuf.c: Make symbols static if they're not exported.
9667 (minibuf_save_list, choose_minibuf_frame): Now static.
9668 * lisp.h (choose_minibuf_frame): Remove decl.
9670 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9672 * lread.c: Make symbols static if they're not exported.
9673 (read_objects, initial_obarray, oblookup_last_bucket_number):
9675 (make_symbol): Remove; unused.
9676 * lisp.h (initial_obarray, make_symbol): Remove decls.
9678 * keyboard.c: Make symbols static if they're not exported.
9679 (single_kboard, recent_keys_index, total_keys, recent_keys):
9680 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9681 (this_single_command_key_start, echoing, last_auto_save):
9682 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9683 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9684 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9685 (Vlispy_mouse_stem, double_click_count):
9687 (force_auto_save_soon): Define only if SIGDANGER.
9688 (ignore_mouse_drag_p): Now static if
9689 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9690 (print_help): Remove; unused.
9691 (stop_character, last_timer_event): Mark as externally visible.
9692 * keyboard.h (ignore_mouse_drag_p): Declare only if
9693 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9694 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9695 * lisp.h (echoing): Remove decl.
9696 (force_auto_save_soon): Declare only if SIGDANGER.
9697 * xdisp.c (redisplay_window): Simplify code, to make it more
9698 obvious that ignore_mouse_drag_p is not accessed if !defined
9699 USE_GTK && !defined HAVE_NS.
9701 * intervals.c: Make symbols static if they're not exported.
9702 (merge_properties_sticky, merge_interval_right, delete_interval):
9704 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9706 * insdel.c: Make symbols static if they're not exported.
9707 However, leave prepare_to_modify_buffer alone. It's never
9708 called from outside this function, but that appears to be a bug.
9709 (combine_after_change_list, combine_after_change_buffer):
9710 (adjust_after_replace, signal_before_change): Now static.
9711 (adjust_after_replace_noundo): Remove; unused.
9712 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9713 (signal_before_change): Remove decls.
9715 * indent.c (val_compute_motion, val_vmotion): Now static.
9717 * image.c: Make symbols static if they're not exported.
9718 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9720 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9721 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9723 * fringe.c (standard_bitmaps): Now static.
9724 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9726 * frame.c: Make symbols static if they're not exported.
9727 (x_report_frame_params, make_terminal_frame): Now static.
9728 (get_frame_param): Now static, unless HAVE_NS.
9729 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9730 (x_get_resource_string): Remove; not used.
9731 * frame.h (make_terminal_frame, x_report_frame_params):
9732 (x_get_resource_string); Remove decls.
9733 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9734 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9736 * font.c, fontset.c: Make symbols static if they're not exported.
9737 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9738 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9739 * font.c (font_close_object): Now static.
9740 * font.h (font_close_object): Remove.
9741 * fontset.c (FONTSET_OBJLIST): Remove.
9742 (free_realized_fontset) #if-0 the body, which does nothing.
9743 (face_suitable_for_char_p): #if-0, as it's never called.
9744 * fontset.h (face_suitable_for_char_p): Remove decl.
9745 * xfaces.c (face_at_string_position):
9746 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9747 since 0 is always ASCII.
9749 * fns.c (weak_hash_tables): Now static.
9751 * fileio.c: Make symbols static if they're not exported.
9752 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9753 (Vwrite_region_annotation_buffers): Now static.
9755 * eval.c: Make symbols static if they're not exported.
9756 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9757 * lisp.h (backtrace_list): Remove decl.
9759 * emacs.c: Make symbols static if they're not exported.
9760 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9761 (fatal_error_code, fatal_error_signal_hook, standard_args):
9763 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9764 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9765 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9766 * lisp.h (fatal_error_signal_hook): Remove decl.
9767 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9769 * editfns.c: Move a (normally-unused) function to its only use.
9770 * editfns.c, lisp.h (get_operating_system_release): Remove.
9771 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9772 worth the hassle of breaking this out.
9774 * xterm.c: Make symbols static if they're not exported.
9775 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9776 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9777 (x_destroy_window, x_delete_display):
9779 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9780 (x_mouse_leave): Remove; unused.
9781 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9782 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9783 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9785 (x_mouse_leave): Declare only if WINDOWSNT.
9786 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9787 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9790 * ftxfont.c: Make symbols static if they're not exported.
9791 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9793 * font.h (ftxfont_driver): Likewise.
9795 * xfns.c: Make symbols static if they're not exported.
9796 (x_last_font_name, x_display_info_for_name):
9797 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9798 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9799 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9800 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9801 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9802 (last_show_tip_args): Now static.
9803 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9804 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9805 (x_screen_planes): Remove; unused.
9806 * dispextern.h (x_screen_planes): Remove decl.
9808 * dispnew.c: Make symbols static if they're not exported.
9809 * dispextern.h (redraw_garbaged_frames, scrolling):
9810 (increment_row_positions): Remove.
9811 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9812 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9814 (redraw_garbaged_frames): Remove; unused.
9816 * xfaces.c: Make symbols static if they're not exported.
9817 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9819 * xterm.h (defined_color): Remove decls.
9820 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9821 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9822 (menu_face_changed_default, defined_color, free_realized_face):
9823 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9824 (ascii_face_of_lisp_face): Remove; unused.
9826 * xdisp.c: Make symbols static if they're not exported.
9827 * dispextern.h (scratch_glyph_row, window_box_edges):
9828 (glyph_to_pixel_coords, set_cursor_from_row):
9829 (get_next_display_element, set_iterator_to_next):
9830 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9831 (show_mouse_face): Remove decls
9832 * frame.h (message_buf_print): Likewise.
9833 * lisp.h (pop_message, set_message, check_point_in_composition):
9835 * xterm.h (set_vertical_scroll_bar): Likewise.
9836 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9837 (message_buf_print, scratch_glyph_row, displayed_buffer):
9838 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9839 (get_next_display_element, show_mouse_face, window_box_edges):
9840 (frame_to_window_pixel_xy, check_point_in_composition):
9841 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9842 (glyph_to_pixel_coords): Remove; unused.
9844 * dired.c (file_name_completion): Now static.
9846 * dbusbind.c (xd_in_read_queued_messages): Now static.
9848 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9849 * data.c (circular_list_error): Remove.
9851 * commands.h (last_point_position, last_point_position_buffer):
9852 (last_point_position_window): Remove decls.
9853 * keyboard.c: Make these variables static.
9855 * coding.h (coding, code_convert_region, encode_coding_gap):
9857 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9858 (iso_code_class, detect_coding, code_convert_region): Now static.
9859 (encode_coding_gap): Remove; unused.
9861 * chartab.c (chartab_chars, chartab_bits): Now static.
9863 * charset.h (charset_iso_8859_1): Remove decl.
9864 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9867 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9868 * ccl.c (Vccl_program_table): Now static.
9869 (check_ccl_update): Remove; unused.
9871 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9872 * category.h: ... from here.
9873 * category.c (check_category_table, set_category_set): Now static.
9875 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9876 * lisp.h: Remove these decls.
9878 * buffer.c (buffer_count): Remove unused var.
9880 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9881 so that it's not optimized away.
9882 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9883 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9884 exported only to the debugger.
9886 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9887 * atimer.h (run_all_atimers): Remove; not exported.
9889 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9890 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9891 was inaccessible from Lisp.
9892 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9893 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9895 alloc.c: Import and export fewer symbols, and remove unused items.
9896 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9898 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9899 it's not optimized away by whole-program optimization.
9900 (message_enable_multibyte, free_misc): Remove.
9901 (catchlist, handlerlist, mark_backtrace):
9902 Declare only if BYTE_MARK_STACK.
9903 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9904 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9905 (message_enable_multibyte): Remove decl.
9906 (free_misc, interval_free_list, float_block, float_block_index):
9907 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9908 (cons_free_list, last_marked_index):
9910 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9911 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9912 (mark_backtrace): Define only if BYTE_MARK_STACK.
9913 * xdisp.c (message_enable_multibyte): Now static.
9915 Declare Lisp_Object Q* variables to be 'static' if not exported.
9916 This makes it easier for human readers (and static analyzers)
9917 to see whether these variables are used from other modules.
9918 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9919 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9920 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9921 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9922 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9923 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9924 * xmenu.c, xselect.c:
9925 Declare Q* vars static if they are not used in other modules.
9926 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9927 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9928 Remove decls of unexported vars.
9929 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9931 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9933 Make Emacs functions such as Fatom 'static' by default.
9934 This makes it easier for human readers (and static analyzers)
9935 to see whether these functions can be called from other modules.
9936 DEFUN now defines a static function. To make the function external
9937 so that it can be used in other C modules, use the new macro DEFUE.
9938 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9939 (Finit_image_library):
9940 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9941 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9942 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9943 Remove decls, since these functions are now static.
9944 (Funintern, Fget_internal_run_time): New decls, since these functions
9945 were already external.
9947 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9948 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9949 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9950 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9951 * keyboard.c, keymap.c, lread.c:
9952 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9953 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9954 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9955 Mark functions with DEFUE instead of DEFUN,
9956 if they are used in other modules.
9957 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9958 decls for now-static functions.
9959 * buffer.h (Fdelete_overlay): Remove decl.
9960 * callproc.c (Fgetenv_internal): Mark as internal.
9961 * composite.c (Fremove_list_of_text_properties): Remove decl.
9962 (Fcomposition_get_gstring): New forward static decl.
9963 * composite.h (Fcomposite_get_gstring): Remove decl.
9964 * dired.c (Ffile_attributes): New forward static decl.
9965 * doc.c (Fdocumntation_property): New forward static decl.
9966 * eval.c (Ffetch_bytecode): New forward static decl.
9967 (Funintern): Remove extern decl; now in .h file where it belongs.
9968 * fileio.c (Fmake_symbolic_link): New forward static decl.
9969 * image.c (Finit_image_library): New forward static decl.
9970 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9971 * intervals.h (Fprevious_property_change):
9972 (Fremove_list_of_text_properties): Remove decls.
9973 * keyboard.c (Fthis_command_keys): Remove decl.
9974 (Fcommand_execute): New forward static decl.
9975 * keymap.c (Flookup_key): New forward static decl.
9976 (Fcopy_keymap): Now static.
9977 * keymap.h (Flookup_key): Remove decl.
9978 * process.c (Fget_process): New forward static decl.
9979 (Fprocess_datagram_address): Mark as internal.
9980 * syntax.c (Fsyntax_table_p): New forward static decl.
9981 (skip_chars): Remove duplicate decl.
9982 * textprop.c (Fprevious_property_change): New forward static decl.
9983 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9985 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9986 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9988 * editfns.c (Fformat): Remove unreachable code.
9990 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9992 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9995 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9997 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9998 when at ZV. (Bug#8487)
10000 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10002 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10004 * keyboard.c (parse_tool_bar_item): Likewise.
10005 * sound.c (sound_cleanup, alsa_close): Likewise.
10006 * termcap.c (tgetent): Likewise.
10007 * xfns.c (x_default_font_parameter): Likewise.
10008 * xsettings.c (read_and_apply_settings): Likewise.
10010 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10011 (overrun_check_free): Protoize.
10013 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10015 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10016 since callers should never pass a negative size.
10017 Change the signature to match that of plain 'read' and 'write'; see
10018 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10019 * lisp.h: Update prototypes of emacs_write and emacs_read.
10021 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10023 * xdisp.c (redisplay_window): Don't try to determine the character
10024 position of the scroll margin if the window start point w->startp
10025 is outside the buffer's accessible region. (Bug#8468)
10027 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10029 Fix write-region and its subroutines for buffers > 2GB.
10030 * fileio.c (a_write, e_write): Modify declaration of arguments and
10031 local variables to support buffers larger than 2GB.
10032 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10034 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10035 argument, local variables, and return value.
10037 * lisp.h: Update prototypes of emacs_write and emacs_read.
10039 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10041 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10043 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10045 Fix more problems found by GCC 4.6.0's static checks.
10047 * xdisp.c (vmessage): Use a better test for character truncation.
10049 * charset.c (load_charset_map): <, not <=, for optimization,
10050 and to avoid potential problems with integer overflow.
10051 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10052 * casetab.c (set_identity, shuffle): Likewise.
10053 * editfns.c (Fformat): Likewise.
10054 * syntax.c (skip_chars): Likewise.
10056 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10057 This also lets GCC 4.6.0 generate slightly better loop code.
10059 * callint.c (Fcall_interactively): <, not <=, for optimization.
10060 (Fcall_interactively): Count the number of arguments produced,
10061 not the number of arguments given. This is simpler and lets GCC
10062 4.6.0 generate slightly better code.
10064 * ftfont.c: Distingish more carefully between FcChar8 and char.
10065 The previous code passed unsigned char * to a functions like
10066 strlen and xstrcasecmp that expect char *, which does not
10067 conform to the C standard.
10068 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10069 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10070 char * when the C standard requires it.
10072 * keyboard.c (read_char): Remove unused var.
10074 * eval.c: Port to Windows vsnprintf (Bug#8435).
10075 Include <limits.h>.
10076 (SIZE_MAX): Define if the headers do not.
10077 (verror): Do not give up if vsnprintf returns a negative count.
10078 Instead, grow the buffer. This ports to Windows vsnprintf, which
10079 does not conform to C99. Problem reported by Eli Zaretskii.
10080 Also, simplify the allocation scheme, by avoiding the need for
10081 calling realloc, and removing the ALLOCATED variable.
10083 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10085 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10086 But keep the doprint source code for now, as we might revamp it
10087 and use it again (Bug#8435).
10088 * lisp.h (doprnt): Remove.
10089 * Makefile.in (base_obj): Remove doprnt.o.
10090 * deps.mk (doprnt.o): Remove.
10092 error: Print 32- and 64-bit integers portably (Bug#8435).
10093 Without this change, on typical 64-bit hosts error ("...%d...", N)
10094 was used to print both 32- and 64-bit integers N, which relied on
10095 undefined behavior.
10096 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10097 * lisp.h (error, verror): Mark as printf-like functions.
10098 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10099 Report overflow in size calculations when allocating printf buffer.
10100 Do not truncate output string at its first null byte.
10101 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10102 Truncate the output at a character boundary, since vsnprintf does not
10104 * charset.c (check_iso_charset_parameter): Convert internal
10105 character to string before calling 'error', since %c now has the
10107 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10108 overflow when computing char to be passed to 'error'. Do not
10109 pass Lisp_Object to 'error'; pass the integer instead.
10110 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10111 formatted with plain %d.
10113 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10115 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10117 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10119 * xterm.c (x_catch_errors): Remove duplicate declaration.
10121 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10123 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10125 2011-04-10 Jim Meyering <meyering@redhat.com>
10127 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10128 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10129 return ssize_t not "int", and use size_t as the buffer length.
10130 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10131 * gnutls.h: Update declarations.
10132 * process.c (read_process_output): Use ssize_t, to match.
10133 (send_process): Likewise.
10135 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10137 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10139 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10141 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10142 Use unsigned char, to match FcChar8 type definition.
10144 * xterm.c (handle_one_xevent):
10145 * xmenu.c (create_and_show_popup_menu):
10146 * xselect.c (x_decline_selection_request)
10147 (x_reply_selection_request): Avoid type-punned deref of X events.
10149 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10151 Fix some uses of `int' instead of EMACS_INT.
10152 * search.c (string_match_1, fast_string_match)
10153 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10154 (scan_buffer, find_next_newline_no_quit)
10155 (find_before_next_newline, search_command, Freplace_match)
10156 (Fmatch_data): Make some `int' variables be EMACS_INT.
10158 * xdisp.c (display_count_lines): 3rd argument and return value now
10159 EMACS_INT. All callers changed.
10160 (pint2hrstr): Last argument is now EMACS_INT.
10162 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10163 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10164 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10165 (decode_coding_utf_16, decode_coding_emacs_mule)
10166 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10167 (decode_coding_ccl, decode_coding_charset)
10168 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10169 (decode_coding_iso_2022, decode_coding_emacs_mule)
10170 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10171 <char_offset, last_offset>: Declare EMACS_INT.
10172 (encode_coding_utf_8, encode_coding_utf_16)
10173 (encode_coding_emacs_mule, encode_invocation_designation)
10174 (encode_designation_at_bol, encode_coding_iso_2022)
10175 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10176 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10178 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10179 (encode_invocation_designation): Last argument P_NCHARS is now
10181 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10182 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10184 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10187 * ccl.c (Fccl_execute_on_string): Declare some variables
10190 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10192 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10194 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10196 * process.c (Fformat_network_address): Doc fix.
10198 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10200 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10202 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10204 * keyboard.c (read_char): Call Lisp function help-form-show,
10205 instead of using internal_with_output_to_temp_buffer.
10206 (Qhelp_form_show): New var.
10207 (syms_of_keyboard): Use DEFSYM macro.
10209 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10211 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10213 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10215 * process.c (Flist_processes): Remove to Lisp.
10216 (list_processes_1): Delete.
10218 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10220 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10222 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10224 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10226 Fix more problems found by GCC 4.6.0's static checks.
10228 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10230 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10232 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10234 * xdisp.c (vmessage): Mark as a printf-like function.
10236 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10238 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10240 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10241 printf-like functions.
10242 (tiff_load): Add casts to remove these marks before passing them
10243 to system-supplied API.
10245 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10247 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10248 This avoids several warnings with gcc -Wstrict-overflow.
10249 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10250 directly, rather than having caller test rule sign. This avoids
10251 some unnecessary tests.
10252 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10253 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10254 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10256 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10257 (xfont_open): Avoid unnecessary tests.
10259 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10261 * composite.h, composite.c (composition_gstring_put_cache):
10262 Use EMACS_INT, not int, for length.
10264 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10265 breaking out part of COMPOSITION_DECODE_RULE.
10266 (COMPOSITION_DECODE_RULE): Use it.
10267 * composite.c (get_composition_id): Remove unused local vars,
10268 by using the new macro.
10270 * textprop.c (set_text_properties_1): Change while to do-while,
10271 since the condition is always true at first.
10273 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10274 (interval_deletion_adjustment): Return unsigned value.
10277 * process.c (list_processes_1, create_pty, read_process_output):
10278 (exec_sentinel): Remove vars that were set but not used.
10279 (create_pty): Remove unnecessary "volatile"s.
10280 (Fnetwork_interface_info): Avoid possibility of int overflow.
10281 (read_process_output): Do adaptive read buffering even if carryover.
10282 (read_process_output): Simplify nbytes computation if buffered.
10284 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10286 * syntax.c (scan_words): Remove var that was set but not used.
10287 (update_syntax_table): Use unsigned instead of int.
10289 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10290 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10291 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10293 * print.c (print_error_message): Avoid int overflow.
10295 * font.c (font_list_entities): Redo for clarity,
10296 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10298 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10299 (font_score): Avoid potential overflow in diff calculation.
10301 * fns.c (substring_both): Remove var that is set but not used.
10302 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10304 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10306 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10307 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10308 can always succeed if overflow has undefined behavior.
10310 * search.c (boyer_moore, wordify): Remove vars set but not used.
10311 (wordify): Omit three unnecessary tests.
10313 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10314 All callers changed. This avoids the need for an unused var.
10316 * casefiddle.c (casify_region): Remove var that is set but not used.
10318 * dired.c (file_name_completion): Remove var that is set but not used.
10320 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10322 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10323 (Finsert_file_contents): Remove unnecessary code checking fd.
10325 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10326 Check for integer overflow on size calculations.
10328 * buffer.c (Fprevious_overlay_change): Remove var that is set
10331 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10332 Remove vars that are set but not used.
10333 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10334 (timer_check_2): Mark vars as initialized.
10336 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10338 * image.c (lookup_image): Remove var that is set but not used.
10339 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10341 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10342 that are set but not used.
10344 * xfns.c (make_invisible_cursor): Don't return garbage
10345 if XCreateBitmapFromData fails (Bug#8410).
10347 * xselect.c (x_get_local_selection, x_handle_property_notify):
10348 Remove vars that are set but not used.
10350 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10351 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10353 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10354 Remove var that is set but not used.
10355 (scroll_bar_windows_size): Now size_t, not int.
10356 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10357 Check for overflow.
10359 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10360 (map_tty_color) [!defined MSDOS]: Likewise.
10362 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10364 * coding.c: Remove vars that are set but not used.
10365 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10366 All callers changed.
10367 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10368 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10369 (decode_coding_charset): Remove vars that are set but not used.
10371 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10372 that is set but not used.
10374 * print.c (print_object): Remove var that is set but not used.
10376 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10377 The gnulib version avoids calling malloc in the usual case,
10378 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10379 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10380 * filelock.c (current_lock_owner): Likewise.
10381 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10382 * sysdep.c: Include allocator.h, careadlinkat.h.
10383 (emacs_no_realloc_allocator): New static constant.
10384 (emacs_readlink): New function.
10385 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10386 ../lib/careadlinkat.h.
10388 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10390 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10391 first non-nil return value).
10393 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10395 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10396 if not defined (Bug#8403).
10398 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10400 * xdisp.c (display_count_lines): Remove parameter `start',
10401 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10402 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10403 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10404 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10405 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10406 and thereabouts. All callers changed.
10407 (get_per_char_metric): Remove parameter `f', unused since
10408 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10410 2011-04-02 Jim Meyering <meyering@redhat.com>
10412 do not dereference NULL upon failed strdup
10413 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10414 (ns_get_family): Likewise.
10416 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10418 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10420 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10422 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10425 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10427 Add lexical binding.
10429 * window.c (Ftemp_output_buffer_show): New fun.
10430 (Fsave_window_excursion):
10431 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10433 * lread.c (lisp_file_lexically_bound_p): New function.
10434 (Fload): Bind Qlexical_binding.
10435 (readevalloop): Remove `evalfun' arg.
10436 Bind Qinternal_interpreter_environment.
10437 (Feval_buffer): Bind Qlexical_binding.
10438 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10440 (syms_of_lread): Declare `lexical-binding'.
10442 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10444 * keyboard.c (eval_dyn): New fun.
10445 (menu_item_eval_property): Use it.
10447 * image.c (parse_image_spec): Use Ffunctionp.
10449 * fns.c (concat, mapcar1): Accept byte-code-functions.
10451 * eval.c (Fsetq): Handle lexical vars.
10452 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10453 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10454 (FletX, Flet): Obey lexical binding.
10455 (Fcommandp): Handle closures.
10456 (Feval): New `lexical' arg.
10457 (eval_sub): New function extracted from Feval. Use it almost
10458 everywhere where Feval was used. Look up vars in lexical env.
10460 (Ffunctionp): Move from subr.el.
10461 (Ffuncall): Handle closures.
10462 (apply_lambda): Remove `eval_flags'.
10463 (funcall_lambda): Handle closures and new byte-code-functions.
10464 (Fspecial_variable_p): New function.
10465 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10466 but without exporting it to Lisp.
10468 * doc.c (Fdocumentation, store_function_docstring):
10469 * data.c (Finteractive_form): Handle closures.
10471 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10474 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10476 (exec_byte_code): New function extracted from Fbyte_code to handle new
10477 calling convention for byte-code-functions. Add new byte-codes.
10479 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10481 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10483 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10485 * xdisp.c (redisplay_internal): Fix prototype.
10487 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10489 * xdisp.c (SCROLL_LIMIT): New macro.
10490 (try_scrolling): Use it when setting scroll_limit.
10491 Limit scrolling to 100 screen lines.
10492 (redisplay_window): Even when falling back on "recentering",
10493 position point in the window according to scroll-conservatively,
10494 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10496 (try_scrolling): When point is above the window, allow searching
10497 as far as scroll_max, or one screenful, to compute vertical
10498 distance from PT to the scroll margin position. This prevents
10499 try_scrolling from unnecessarily failing when
10500 scroll-conservatively is set to a value slightly larger than the
10501 window height. Clean up the case of PT below the margin at bottom
10502 of window: scroll_max can no longer be INT_MAX. When aggressive
10503 scrolling is in use, don't let point enter the opposite scroll
10504 margin as result of the scroll.
10505 (syms_of_xdisp) <scroll-conservatively>: Document the
10506 threshold of 100 lines for never-recentering scrolling.
10508 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10510 * dispextern.h (move_it_by_lines):
10511 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10512 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10513 (message_log_check_duplicate): Remove parameters `prev_bol' and
10514 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10515 (redisplay_internal): Remove parameter `preserve_echo_area',
10516 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10518 * indent.c (Fvertical_motion):
10519 * window.c (window_scroll_pixel_based, Frecenter):
10520 Don't pass `need_y_p' to `move_it_by_lines'.
10522 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10524 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10525 steal a few bits to be more compact.
10526 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10527 Remove unneeded casts.
10529 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10531 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10533 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10534 binding" message (bug#7967).
10536 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10538 Fix more problems found by GCC 4.6.0's static checks.
10540 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10541 Remove unused local var.
10543 * editfns.c (Fmessage_box): Remove unused local var.
10545 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10546 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10547 Omit unused local vars.
10548 * window.c (shrink_windows): Omit unused local var.
10549 * menu.c (digest_single_submenu): Omit unused local var.
10550 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10551 Omit unused local var.
10553 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10554 Don't assume string length fits in int.
10555 (keyremap_step, read_key_sequence): Use size_t for sizes.
10556 (read_key_sequence): Don't check last_real_key_start redundantly.
10558 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10559 instead of alloca (Bug#8344).
10561 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10562 (Fbacktrace_frame): Don't assume nframes fits in int.
10564 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10566 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10569 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10571 * cm.c (calccost): Turn while-do into do-while, for clarity.
10573 * keyboard.c (syms_of_keyboard): Use the same style as later
10574 in this function when indexing through an array. This also
10575 works around GCC bug 48267.
10577 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10579 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10581 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10582 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10584 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10585 This avoids undefined behavior on integer overflow, and is a bit
10586 more convenient anyway since it is compared to a size_t variable.
10588 Variadic C functions now count arguments with size_t, not int.
10589 This avoids an unnecessary limitation on 64-bit machines, which
10590 caused (substring ...) to crash on large vectors (Bug#8344).
10591 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10592 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10593 All variadic functions and their callers changed accordingly.
10594 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10595 * data.c (arith_driver, float_arith_driver): Likewise.
10596 * editfns.c (general_insert_function): Likewise.
10597 * eval.c (struct backtrace.nargs, interactive_p)
10598 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10599 (funcall_lambda, mark_backtrace): Likewise.
10600 * fns.c (concat): Likewise.
10601 * frame.c (x_set_frame_parameters): Likewise.
10602 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10603 0 if not found, not -1. All callers changed.
10605 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10606 (stack_copy_size): Now size_t, not int.
10607 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10609 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10611 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10612 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10613 All callers changed.
10615 * lisp.h (multibyte_char_to_unibyte):
10616 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10617 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10618 * character.h (CHAR_TO_BYTE8):
10619 * cmds.c (internal_self_insert):
10620 * editfns.c (general_insert_function):
10621 * keymap.c (push_key_description):
10622 * search.c (Freplace_match):
10623 * xdisp.c (message_dolog, set_message_1): All callers changed.
10625 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10627 * keyboard.c (safe_run_hook_funcall): New function.
10628 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10629 don't set the hook to nil, but remove the offending function instead.
10630 (Qcommand_hook_internal): Remove, unused.
10631 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10632 Vcommand_hook_internal.
10634 * eval.c (enum run_hooks_condition): Remove.
10635 (funcall_nil, funcall_not): New functions.
10636 (run_hook_with_args): Call each function through a `funcall' argument.
10637 Remove `cond' argument, now redundant.
10638 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10639 (Frun_hook_with_args_until_failure): Adjust accordingly.
10640 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10642 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10644 * dispextern.h (string_buffer_position): Remove declaration.
10646 * print.c (strout): Remove parameter `multibyte', unused since
10647 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10649 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10650 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10651 All callers changed.
10653 * w32.c (_wsa_errlist): Use braces for struct initializers.
10655 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10656 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10657 All callers changed.
10658 (string_buffer_position): Likewise. Also, make static (it's never
10659 used outside xdisp.c).
10660 (cursor_row_p): Remove parameter `w', unused since
10661 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10662 (decode_mode_spec): Remove parameter `precision', introduced during
10663 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10664 All callers changed.
10666 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10668 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10670 2011-03-27 Anders Lindgren <andlind@gmail.com>
10672 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10673 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10674 (ns_update_auto_hide_menu_bar): New functions.
10675 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10676 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10677 ns_constrain_all_frames.
10678 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10679 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10681 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10683 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10685 2011-03-27 Glenn Morris <rgm@gnu.org>
10687 * syssignal.h: Replace RETSIGTYPE with void.
10688 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10689 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10690 Replace SIGTYPE with void everywhere.
10691 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10692 * s/template.h (SIGTYPE): Remove commented out definition.
10694 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10696 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10697 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10699 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10701 * w32.c (read_unc_volume): Use parameter `henum', instead of
10702 global variable `wget_enum_handle'.
10704 * keymap.c (describe_vector): Remove parameters `indices' and
10705 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10706 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10708 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10710 * keyboard.c (timer_check): Remove parameter `do_it_now',
10711 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10712 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10713 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10715 * keyboard.c (read_char):
10716 * w32menu.c (w32_menu_display_help):
10717 * xmenu.c (show_help_event, menu_help_callback):
10718 Adjust calls to `show_help_echo'.
10720 * gtkutil.c (xg_maybe_add_timer):
10721 * keyboard.c (readable_events):
10722 * process.c (wait_reading_process_output):
10723 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10725 * insdel.c (adjust_markers_gap_motion):
10726 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10727 (gap_left, gap_right): Don't call it.
10729 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10731 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10732 incurred during fontification.
10734 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10736 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10737 (DEFVAR_PER_BUFFER): Don't pass it.
10739 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10740 (scrolling_window): Don't pass it.
10742 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10744 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10746 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10748 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10749 of variables specific to SELinux and computation of `encoded_absname'.
10751 * image.c (XPutPixel): Remove unused variable `height'.
10753 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10755 * unexw32.c (get_section_info): Remove unused variable `section'.
10757 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10758 (system_process_attributes): Remove unused variable `sess'.
10759 (sys_read): Remove unused variable `err'.
10761 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10762 (w32_wnd_proc): Remove unused variable `isdead'.
10763 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10764 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10765 (x_create_tip_frame): Remove unused variable `tem'.
10767 * w32inevt.c (w32_console_read_socket):
10768 Remove unused variable `no_events'.
10770 * w32term.c (x_draw_composite_glyph_string_foreground):
10771 Remove unused variable `width'.
10773 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10775 * w32term.c (x_set_glyph_string_clipping):
10776 Don't pass uninitialized region to CombineRgn.
10778 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10780 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10781 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10782 (Fx_close_connection): Remove unused variable `i'.
10784 * w32font.c (w32font_draw): Return number of glyphs.
10785 (w32font_open_internal): Remove unused variable `i'.
10786 (w32font_driver): Add missing initializer.
10788 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10789 (fill_in_menu): Remove unused variable `items_added'.
10791 * w32term.c (last_mouse_press_frame): Remove static global variable.
10792 (w32_clip_to_row): Remove unused variable `f'.
10793 (x_delete_terminal): Remove unused variable `i'.
10795 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10796 (NOTHING): Remove unused static global variable.
10797 (uniscribe_check_otf): Remove unused variable `table'.
10798 (uniscribe_font_driver): Add missing initializers.
10800 2011-03-23 Julien Danjou <julien@danjou.info>
10802 * term.c (Fsuspend_tty, Fresume_tty):
10803 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10804 * window.c (temp_output_buffer_show):
10805 * insdel.c (signal_before_change):
10806 * frame.c (Fhandle_switch_frame):
10807 * fileio.c (Fdo_auto_save):
10808 * emacs.c (Fkill_emacs):
10809 * editfns.c (save_excursion_restore):
10810 * cmds.c (internal_self_insert):
10811 * callint.c (Fcall_interactively):
10812 * buffer.c (Fkill_all_local_variables):
10813 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10815 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10816 unconditionally since it does the check itself.
10818 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10820 Fix more problems found by GCC 4.5.2's static checks.
10822 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10823 the first time through the loop, since we know p0 < p1 then.
10824 This also avoids a gcc -Wstrict-overflow warning.
10826 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10827 leading to a memory leak, possible in functions like
10828 load_charset_map_from_file that can allocate an unbounded number
10829 of objects (Bug#8318).
10831 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10832 that could (at least in theory) be that large.
10834 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10835 This is less likely to overflow, and avoids undefined behavior if
10836 overflow does occur. All callers changed. Use strtoul to scan
10837 for the unsigned long integer.
10838 (pint2hrstr): Simplify and tune code slightly.
10839 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10841 * scroll.c (do_scrolling): Work around GCC bug 48228.
10842 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10844 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10845 This also avoids a warning with gcc -Wstrict-overflow.
10846 (validate_x_resource_name): Simplify count usage.
10847 This also avoids a warning with gcc -Wstrict-overflow.
10849 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10852 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10854 * process.c (Fmake_network_process): Use socklen_t, not int,
10855 where POSIX says socklen_t is required in portable programs.
10856 This fixes a porting bug on hosts like 64-bit HP-UX, where
10857 socklen_t is wider than int (Bug#8277).
10858 (Fmake_network_process, server_accept_connection):
10859 (wait_reading_process_output, read_process_output):
10862 * process.c: Rename or move locals to avoid shadowing.
10863 (list_processes_1, Fmake_network_process):
10864 (read_process_output_error_handler, exec_sentinel_error_handler):
10865 Rename or move locals.
10866 (Fmake_network_process): Define label "retry_connect" only if needed.
10867 (Fnetwork_interface_info): Fix pointer signedness.
10868 (process_send_signal): Add cast to avoid pointer signedness problem.
10869 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10870 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10872 Make tparam.h and terminfo.c consistent.
10873 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10874 Include tparam.h instead, since it declares them.
10875 * cm.h (PC): Remove extern decl; tparam.h now does this.
10876 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10877 * terminfo.c: Include tparam.h, to check interfaces.
10878 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10879 (tparam): Adjust signature to match interface in tparam.h;
10880 this removes some undefined behavior. Check that outstring and len
10881 are zero, which they always are with Emacs.
10882 * tparam.h (PC, BC, UP): New extern decls.
10884 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10885 (xftfont_open): Rename locals to avoid shadowing.
10887 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10888 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10889 (OTF_TAG_SYM): Omit macro if not needed.
10890 (ftfont_list): Remove unused local.
10891 (get_adstyle_property, ftfont_pattern_entity):
10892 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10893 Rename locals to avoid shadowing.
10895 * xfont.c (xfont_list_family): Mark var as initialized.
10897 * xml.c (make_dom): Now static.
10899 * composite.c (composition_compute_stop_pos): Rename local to
10901 (composition_reseat_it): Remove unused locals.
10902 (find_automatic_composition, composition_adjust_point): Likewise.
10903 (composition_update_it): Mark var as initialized.
10904 (find_automatic_composition): Mark vars as initialized,
10905 with a FIXME (Bug#8290).
10907 character.h: Rename locals to avoid shadowing.
10908 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10909 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10910 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10911 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10912 to avoid shadowing.
10914 * textprop.c (property_change_between_p): Remove; unused.
10916 * intervals.c (interval_start_pos): Now static.
10918 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10920 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10921 Rename locals to avoid shadowing.
10923 * sound.c (wav_play, au_play, Fplay_sound_internal):
10924 Fix pointer signedness.
10925 (alsa_choose_format): Remove unused local var.
10926 (wav_play): Initialize a variable to 0, to prevent undefined
10927 behavior (Bug#8278).
10929 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10931 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10933 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10934 clobbering (Bug#8298).
10935 * sysdep.c (sys_subshell): Likewise.
10936 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10938 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10939 This should get cleaned up, so that child_setup has the
10940 same signature on all platforms.
10942 * callproc.c (call_process_cleanup): Now static.
10943 (relocate_fd): Rename locals to avoid shadowing.
10945 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10947 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10948 not to be necessary, and produces flickering.
10950 2011-03-20 Glenn Morris <rgm@gnu.org>
10952 * config.in: Remove file.
10954 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10956 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10957 are now in src/globals.h.
10958 (syms_of_minibuf): Remove spurious & from previous change.
10960 2011-03-20 Leo Liu <sdl.web@gmail.com>
10962 * minibuf.c (completing-read-function): New variable.
10963 (completing-read-default): Rename from completing-read.
10964 (completing-read): Call completing-read-function.
10966 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10968 * xfaces.c (Fx_load_color_file):
10969 Read color file from absolute filename (bug#8250).
10971 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10973 * makefile.w32-in: Update dependencies.
10975 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10977 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10979 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10981 Fix more problems found by GCC 4.5.2's static checks.
10983 * process.c (make_serial_process_unwind, send_process_trap):
10984 (sigchld_handler): Now static.
10986 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10987 That way, the code declares only the vars that it needs.
10988 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10989 * s/cygwin.h (PTY_ITERATION): Likewise.
10990 * s/darwin.h (PTY_ITERATION): Likewise.
10991 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10993 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10994 * process.c (allocate_pty): Don't declare stb unless it's needed.
10996 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10997 (CONSTANTLIM): Remove; unused.
10998 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10999 Define only if needed.
11001 * unexelf.c (unexec): Name an expression,
11002 to avoid gcc -Wbad-function-cast warning.
11003 Use a different way to cause a compilation error if anyone uses
11004 n rather than nn, a way that does not involve shadowing.
11005 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11007 * deps.mk (unexalpha.o): Remove; unused.
11009 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11010 * unexec.h: New file.
11011 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11012 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11013 Depend on unexec.h.
11014 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11015 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11016 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11017 Change as necessary to match prototype in unexec.h.
11019 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11021 (back_comment, skip_chars): Mark vars as initialized.
11023 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11024 Rename locals to avoid shadowing.
11026 * lread.c (read1): Rewrite so as not to use empty "else".
11027 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11029 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11031 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11032 warning when compiling print.c.
11034 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11035 instead of using an uninitialized var.
11036 (font_sort_entities): Mark var as initialized.
11038 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11040 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11041 pointers to constants.
11042 (font_parse_fcname): Remove unused vars.
11043 (font_delete_unmatched): Now static.
11044 (font_get_spec): Remove; unused.
11045 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11046 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11047 Rename or move locals to avoid shadowing.
11049 * fns.c (require_nesting_list, require_unwind): Now static.
11050 (Ffillarray): Rename locals to avoid shadowing.
11052 * floatfns.c (domain_error2): Define only if needed.
11053 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11055 * alloc.c (mark_backtrace): Move decl from here ...
11056 * lisp.h: ... to here, so that it can be checked.
11058 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11059 (Fdefvar): Rewrite so as not to use empty "else".
11060 (lisp_indirect_variable): Name an expression,
11061 to avoid gcc -Wbad-function-cast warning.
11062 (Fdefvar): Rename locals to avoid shadowing.
11064 * callint.c (quotify_arg, quotify_args): Now static.
11065 (Fcall_interactively): Rename locals to avoid shadowing.
11066 Use const pointer when appropriate.
11068 * lisp.h (get_system_name, get_operating_system_release):
11069 Move decls here, to check interfaces.
11070 * process.c (get_operating_system_release): Move decl to lisp.h.
11071 * xrdb.c (get_system_name): Likewise.
11072 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11073 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11074 some of which prompt warnings from gcc -Wbad-function-cast.
11075 (Fformat_time_string, Fencode_time, Finsert_char):
11076 (Ftranslate_region_internal, Fformat):
11077 Rename or remove local vars to avoid shadowing.
11078 (Ftranslate_region_internal): Mark var as initialized.
11080 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11083 * lisp.h (eassert): Check that the argument compiles, even if
11084 ENABLE_CHECKING is not defined.
11086 * data.c (Findirect_variable): Name an expression, to avoid
11087 gcc -Wbad-function-cast warning.
11088 (default_value, arithcompare, arith_driver, arith_error): Now static.
11089 (store_symval_forwarding): Rename local to avoid shadowing.
11090 (Fmake_variable_buffer_local, Fmake_local_variable):
11091 Mark variables as initialized.
11092 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11094 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11095 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11096 Rename locals to avoid shadowing.
11097 (mark_stack): Move local variables into the #ifdef region where
11099 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11100 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11102 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11103 (GC_STRING_CHARS): Remove; not used.
11104 (Fmemory_limit): Cast sbrk's returned value to char *.
11106 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11107 avoids undefined behavior in theory.
11109 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11111 Use functions, not macros, for up- and down-casing (Bug#8254).
11112 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11113 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11114 to use the following functions instead of these macros.
11115 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11116 EMACS_INT, since callers assume the returned value fits in int.
11117 (upcase1): Likewise, for UPCASE_TABLE.
11118 (uppercasep, lowercasep, upcase): New static inline functions.
11119 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11120 the race-condition problem in the old DOWNCASE.
11122 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11123 Rename locals to avoid shadowing.
11124 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11125 (regex_compile, re_search_2, re_match_2_internal):
11126 Remove unused local vars.
11127 (FREE_VAR): Rewrite so as not to use empty "else",
11128 which gcc can warn about.
11129 (regex_compile, re_match_2_internal): Mark locals as initialized.
11130 (RETALLOC_IF): Define only if needed.
11131 (WORDCHAR_P): Likewise. This one is never needed, but is used
11132 only in a comment talking about a compiler bug, so put inside
11133 the #if 0 of that comment.
11134 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11135 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11138 * search.c (boyer_moore): Rename locals to avoid shadowing.
11139 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11140 (PREV_CHAR_BOUNDARY): Likewise.
11142 * search.c (simple_search): Remove unused var.
11144 * dired.c (compile_pattern): Move decl from here ...
11145 * lisp.h: ... to here, so that it can be checked.
11146 (struct re_registers): New forward decl.
11148 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11150 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11152 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11153 Rename locals to avoid shadowing.
11154 (Fvertical_motion): Mark locals as initialized.
11156 * casefiddle.c (casify_object, casify_region): Now static.
11157 (casify_region): Mark local as initialized.
11159 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11161 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11162 New macros, so that the caller can use some names other than
11163 gcpro1, gcpro2, etc.
11164 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11166 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11167 argument, for consistency with GCPRO2_VAR, etc: it is now the
11168 prefix of the variable, not the variable itself. All uses
11170 * dired.c (directory_files_internal, file_name_completion):
11171 Rename locals to avoid shadowing.
11173 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11174 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11175 dired.c's scmp function, had undefined behavior.
11176 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11177 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11178 * buffer.h: ... to here, because these macros use current_buffer,
11179 and the new implementation with inline functions needs to have
11180 current_buffer in scope now, rather than later when the macros
11182 (downcase, upcase1): New static inline functions.
11183 (DOWNCASE, UPCASE1): Reimplement using these functions.
11184 This avoids undefined behavior in expressions like
11185 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11186 from race conditions in accessing the global variables
11187 case_temp1 and case_temp2.
11188 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11189 * lisp.h (case_temp1, case_temp2): Remove their decls.
11190 * character.h (ASCII_CHAR_P): Move from here ...
11191 * lisp.h: ... to here, so that the inline functions mentioned
11192 above can use them.
11194 * dired.c (directory_files_internal_unwind): Now static.
11196 * fileio.c (file_name_as_directory, directory_file_name):
11197 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11199 (file_name_as_directory): Use const pointers when appropriate.
11200 (Fexpand_file_name): Likewise. In particular, newdir might
11201 point at constant storage, so make it a const pointer.
11202 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11203 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11205 (Fset_file_times, Finsert_file_contents, auto_save_error):
11206 Rename locals to avoid shadowing.
11208 * minibuf.c (choose_minibuf_frame_1): Now static.
11209 (Ftry_completion, Fall_completions): Rename or remove locals
11210 to avoid shadowing.
11212 * marker.c (bytepos_to_charpos): Remove; unused.
11214 * lisp.h (verify_bytepos, count_markers): New decls,
11215 so that gcc does not warn that these functions aren't declared.
11217 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11218 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11219 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11220 (copy_text): Remove unused local var.
11222 * filelock.c (within_one_second): Now static.
11223 (lock_file_1): Rename local to avoid shadowing.
11225 * buffer.c (fix_overlays_before): Mark locals as initialized.
11226 (fix_start_end_in_overlays): Likewise. This function should be
11227 simplified by using pointers-to-pointers, but that's a different
11229 (switch_to_buffer_1): Now static.
11230 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11231 (report_overlay_modification): Rename locals to avoid shadowing.
11233 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11234 Fix pointer signedness issue.
11235 (sys_subshell): Mark local as volatile if checking for lint,
11236 to suppress a gcc -Wclobbered warning that does not seem to be right.
11237 (MAXPATHLEN): Define only if needed.
11239 * process.c (serial_open, serial_configure): Move decls from here ...
11240 * systty.h: ... to here, so that they can be checked.
11242 * fns.c (get_random, seed_random): Move extern decls from here ...
11243 * lisp.h: ... to here, so that they can be checked.
11245 * sysdep.c (reset_io): Now static.
11246 (wait_for_termination_signal): Remove; unused.
11248 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11249 (copy_keymap_item, append_key, push_text_char_description):
11251 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11252 (DENSE_TABLE_SIZE): Remove; unused.
11253 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11254 (describe_map_tree):
11255 Rename locals to avoid shadowing.
11257 * keyboard.c: Declare functions static if they are not used elsewhere.
11258 (echo_char, echo_dash, cmd_error, top_level_2):
11259 (poll_for_input, handle_async_input): Now static.
11260 (read_char, kbd_buffer_get_event, make_lispy_position):
11261 (make_lispy_event, make_lispy_movement, apply_modifiers):
11262 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11263 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11264 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11265 (read_key_sequence, read_char): Mark locals as initialized.
11266 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11268 * keyboard.h (make_ctrl_char): New decl.
11269 (mark_kboards): Move decl here ...
11270 * alloc.c (mark_kboards): ... from here.
11272 * lisp.h (force_auto_save_soon): New decl.
11274 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11275 (DEFINE_DUMMY_FUNCTION): New macro.
11276 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11278 (main): Add casts to avoid warnings
11279 if GCC considers string literals to be constants.
11281 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11283 * dbusbind.c: Pointer signedness fixes.
11284 (xd_signature, xd_append_arg, xd_initialize):
11285 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11286 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11287 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11288 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11290 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11291 if GCC considers string literals to be constants.
11292 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11294 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11296 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11297 (print_preprocess, print_object): New macro to fix last change.
11299 * print.c (print_preprocess): Don't forget font objects.
11301 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11303 * emacs.c (USAGE3): Doc fixes.
11305 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11307 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11310 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11312 * lisp.h (VWindow_system, Qfile_name_history):
11313 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11314 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11315 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11317 * w32select.c: Don't #include "keyboard.h".
11318 (run_protected): Add extern declaration for waiting_for_input.
11320 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11321 * w32console.c (detect_input_pending, read_input_pending)
11322 (encode_terminal_code):
11323 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11324 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11325 (w32_system_caret_y, Qfile_name_history):
11326 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11327 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11328 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11329 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11330 * w32proc.c (Qlocal, report_file_error):
11331 * w32term.c (Vwindow_system, updating_frame):
11332 * w32uniscribe.c (initialized, uniscribe_font_driver):
11333 Remove unneeded extern declarations.
11335 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11337 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11339 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11341 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11342 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11343 These macros can no longer be used for assignment.
11345 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11346 Assign struct members directly, instead of using BUF_BEGV etc.
11347 (record_buffer_markers, fetch_buffer_markers): New functions for
11348 recording and fetching special buffer markers.
11349 (set_buffer_internal_1, set_buffer_temp): Use them.
11351 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11353 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11355 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11356 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11358 * xdisp.c (hscroll_window_tree):
11359 (reconsider_clip_changes): Use PT instead of BUF_PT.
11361 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11363 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11364 $(EMACS_ROOT)/lib/intprops.h.
11366 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11368 Fix more problems found by GCC 4.5.2's static checks.
11370 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11371 to unsigned char * to avoid compiler diagnostic.
11372 (xg_free_frame_widgets): Make it clear that a local variable is
11373 needed only if USE_GTK_TOOLTIP.
11374 (gdk_window_get_screen): Make it clear that this macro is needed
11375 only if USE_GTK_TOOLTIP.
11376 (int_gtk_range_get_value): New function, which avoids a diagnostic
11377 from gcc -Wbad-function-cast.
11378 (xg_set_toolkit_scroll_bar_thumb): Use it.
11379 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11380 diagnostic from gcc -Wbad-function-cast.
11381 (get_utf8_string, xg_get_file_with_chooser):
11382 Rename locals to avoid shadowing.
11383 (create_dialog): Move locals to avoid shadowing.
11385 * xgselect.c (xg_select): Remove unused var.
11387 * image.c (four_corners_best): Mark locals as initialized.
11388 (gif_load): Initialize transparent_p to zero (Bug#8238).
11389 Mark another local as initialized.
11390 (my_png_error, my_error_exit): Mark with NO_RETURN.
11392 * image.c (clear_image_cache): Now static.
11393 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11394 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11395 (x_edge_detection): Remove unnecessary cast that
11396 gcc -Wbad-function-cast diagnoses.
11397 (gif_load): Fix pointer signedness.
11398 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11399 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11401 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11403 Improve quality of tests for time stamp overflow.
11404 For example, without this patch (encode-time 0 0 0 1 1
11405 1152921504606846976) returns the obviously-bogus value (-948597
11406 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11407 reports time overflow. See
11408 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11409 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11410 * editfns.c: Include limits.h and intprops.h.
11411 (TIME_T_MIN, TIME_T_MAX): New macros.
11412 (time_overflow): Move earlier, to before first use.
11413 (hi_time, lo_time): New functions, for an accurate test for
11414 out-of-range times.
11415 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11416 (Fget_internal_run_time): Don't assume time_t fits in int.
11417 (make_time): Use list2 instead of Fcons twice.
11418 (Fdecode_time): More accurate test for out-of-range times.
11419 (check_tm_member): New function.
11420 (Fencode_time): Use it, to test for out-of-range times.
11421 (lisp_time_argument): Don't rely on undefined left-shift and
11422 right-shift behavior when checking for time stamp overflow.
11424 * editfns.c (time_overflow): New function, refactoring common code.
11425 (Fformat_time_string, Fdecode_time, Fencode_time):
11426 (Fcurrent_time_string): Use it.
11428 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11429 * dired.c (make_time): Move to ...
11430 * editfns.c (make_time): ... here.
11431 * systime.h: Note the move.
11433 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11435 * fringe.c (update_window_fringes): Remove unused variables.
11437 * unexmacosx.c (copy_data_segment): Also copy __got section.
11440 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11442 * termcap.c [MSDOS]: Include "msdos.h".
11443 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11444 Constify `char *' arguments and their references according to
11445 prototypes in tparam.h.
11447 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11449 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11450 Adapt all references accordingly.
11452 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11454 2011-03-11 Tom Tromey <tromey@redhat.com>
11456 * buffer.c (syms_of_buffer): Remove obsolete comment.
11458 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11460 * termhooks.h (encode_terminal_code): Declare prototype.
11462 * msdos.c (encode_terminal_code): Don't declare prototype.
11464 * term.c (encode_terminal_code): Now external again, used by
11465 w32console.c and msdos.c.
11467 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11468 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11470 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11472 Fix some minor problems found by GCC 4.5.2's static checks.
11474 * fringe.c (update_window_fringes): Mark locals as initialized
11476 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11478 * alloc.c (mark_fringe_data): Move decl from here ...
11479 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11480 to check its interface.
11481 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11483 * fontset.c (free_realized_fontset): Now static.
11484 (Fset_fontset_font): Rename local to avoid shadowing.
11485 (fontset_font): Mark local as initialized.
11486 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11488 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11490 * xselect.c (x_disown_buffer_selections): Remove; not used.
11491 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11492 (x_own_selection, Fx_disown_selection_internal): Rename locals
11493 to avoid shadowing.
11494 (x_handle_dnd_message): Remove local to avoid shadowing.
11496 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11497 so that the caller can use some name other than gcpro1.
11498 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11499 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11500 (Fx_backspace_delete_keys_p):
11501 Use them to avoid shadowing, and rename vars to avoid shadowing.
11502 (x_decode_color, x_set_name, x_window): Now static.
11503 (Fx_create_frame): Add braces to silence GCC warning.
11504 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11505 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11506 Remove unused locals.
11507 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11508 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11509 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11512 * xterm.h (x_mouse_leave): New decl.
11514 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11515 Remove unused functions.
11516 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11517 (x_calc_absolute_position): Now static.
11518 (XTread_socket): Don't define label "out" unless it's used.
11519 Don't declare local "event" unless it's used.
11520 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11521 unless they are used.
11522 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11523 (x_fatal_error_signal): Remove; not used.
11524 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11525 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11526 (x_error_catcher, x_connection_closed, x_error_handler):
11527 (x_error_quitter, xembed_send_message, x_iconify_frame):
11528 (my_log_handler): Rename locals to avoid shadowing.
11529 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11530 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11532 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11533 Rename or move locals to avoid shadowing.
11534 (tty_defined_color, merge_face_heights): Now static.
11535 (free_realized_faces_for_fontset): Remove; not used.
11536 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11537 does not deduce is never used uninitialized.
11538 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11539 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11541 * terminal.c (store_terminal_param): Now static.
11543 * xmenu.c (menu_highlight_callback): Now static.
11544 (set_frame_menubar): Remove unused local.
11545 (xmenu_show): Rename parameter to avoid shadowing.
11546 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11547 since they might point to immutable storage.
11548 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11549 since it's unused otherwise.
11551 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11552 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11553 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11554 avoids a gcc -Wuninitialized diagnostic.
11555 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11556 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11557 does not deduce are never used uninitialized.
11559 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11561 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11562 * window.c (window_loop, size_window):
11563 (run_window_configuration_change_hook, enlarge_window): Likewise.
11565 * window.c (display_buffer): Now static.
11566 (size_window): Mark variables that gcc -Wuninitialized
11567 does not deduce are never used uninitialized.
11568 * window.h (check_all_windows): New decl, to forestall
11569 gcc -Wmissing-prototypes diagnostic.
11570 * dispextern.h (bidi_dump_cached_states): Likewise.
11572 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11574 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11575 Include <limits.h>.
11576 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11577 and to avoid gcc -Wuninitialized warning.
11578 (load_charset_map): Mark variables that gcc -Wuninitialized
11579 does not deduce are never used uninitialized.
11580 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11582 * coding.c (coding_set_source, coding_set_destination):
11583 Use "else { /* comment */ }" rather than "else /* comment */;"
11584 for clarity, and to avoid gcc -Wempty-body warning.
11585 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11586 a block, when the outer 'i' will do.
11587 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11588 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11589 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11590 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11591 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11592 Rename locals to avoid shadowing.
11593 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11594 * coding.c (emacs_mule_char, encode_invocation_designation):
11595 Now static, since they're not used elsewhere.
11596 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11597 (decode_coding_object, encode_coding_object, detect_coding_system):
11598 (decode_coding_emacs_mule): Mark variables that gcc
11599 -Wuninitialized does not deduce are never used uninitialized.
11600 (detect_coding_iso_2022): Initialize a local variable that might
11601 be used uninitialized. Leave a FIXME because it's not clear that
11602 this initialization is needed. (Bug#8211)
11603 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11604 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11605 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11606 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11607 Remove unused macros.
11609 * category.c (hash_get_category_set): Remove unused local var.
11610 (copy_category_table): Now static, since it's not used elsewhere.
11611 * character.c (string_count_byte8): Likewise.
11613 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11614 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11616 * chartab.c (copy_sub_char_table): Now static, since it's not used
11618 (sub_char_table_ref_and_range, char_table_ref_and_range):
11619 Rename locals to avoid shadowing.
11620 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11622 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11623 (BIDI_BOB): Remove unused macro.
11625 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11626 deduce are never used uninitialized.
11627 * term.c (encode_terminal_code): Likewise.
11629 * term.c (encode_terminal_code): Now static. Remove unused local.
11631 * tparam.h: New file.
11632 * term.c, tparam.h: Include it.
11633 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11634 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11635 Move these decls to tparam.h, and make them agree with what
11636 is actually in tparam.c. The previous trick of using incompatible
11637 decls in different modules does not conform to the C standard.
11638 All callers of tparam changed to use tparam's actual API.
11639 * tparam.c (tparam1, tparam, tgoto):
11640 Use const pointers where appropriate.
11642 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11643 * cm.h (struct cm): Likewise.
11644 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11645 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11646 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11647 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11648 (turn_on_face, init_tty): Likewise.
11649 * termchar.h (struct tty_display_info): Likewise.
11651 * term.c (term_mouse_position): Rename local to avoid shadowing.
11653 * alloc.c (mark_ttys): Move decl from here ...
11654 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11656 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11658 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11660 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11662 * search.c (compile_pattern_1): Remove argument regp, unused since
11663 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11664 (compile_pattern): Don't pass it.
11666 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11668 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11669 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11671 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11673 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11675 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11676 gdk_window_get_screen, gdk_window_get_geometry,
11677 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11678 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11679 (xg_get_pixbuf_from_pixmap): New function.
11680 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11681 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11682 Call xg_get_pixbuf_from_pixmap instead of
11683 gdk_pixbuf_get_from_drawable.
11684 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11685 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11686 (xg_check_special_colors): Use GtkStyleContext and its functions
11688 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11689 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11690 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11691 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11692 Call gtk_widget_get_preferred_size.
11693 (xg_frame_resized): gdk_window_get_geometry only takes 5
11695 (xg_win_to_widget, xg_event_is_for_menubar):
11696 Call gdk_x11_window_lookup_for_display.
11697 (xg_set_widget_bg): New function.
11698 (delete_cb): New function.
11699 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11700 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11701 (xg_set_background_color): Call xg_set_widget_bg.
11702 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11703 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11704 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11705 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11707 (update_frame_tool_bar): Call gtk_widget_hide.
11708 (xg_initialize): Use GDK_KEY_g.
11710 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11712 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11714 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11715 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11716 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11718 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11720 * w32xfns.c (select_palette): Check success of RealizePalette against
11721 GDI_ERROR, not zero.
11723 See ChangeLog.11 for earlier changes.
11725 ;; Local Variables:
11729 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11731 This file is part of GNU Emacs.
11733 GNU Emacs is free software: you can redistribute it and/or modify
11734 it under the terms of the GNU General Public License as published by
11735 the Free Software Foundation, either version 3 of the License, or
11736 (at your option) any later version.
11738 GNU Emacs is distributed in the hope that it will be useful,
11739 but WITHOUT ANY WARRANTY; without even the implied warranty of
11740 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11741 GNU General Public License for more details.
11743 You should have received a copy of the GNU General Public License
11744 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.