]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
[gnu-emacs] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4 Now ptrdiff_t, not int.
5 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7
8 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
9 on memory overflow.
10
11 * macros.c: Integer and memory overflow fixes.
12 (Fstart_kbd_macro): Don't update size until alloc done.
13 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
14
15 * lread.c (read1, init_obarray): Don't update size until alloc done.
16
17 * keymap.c: Integer overflow fixes.
18 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
19 (current_minor_maps): Check for size calculation overflow.
20 * keymap.h: Change prototypes to match the above.
21
22 * keyboard.c: Integer and memory overflow fixes.
23 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
24 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
25 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
26 (read_char_minibuf_menu_prompt): Check for overflow in size
27 calculations. Don't update size until allocation succeeds. Redo
28 calculations to avoid overflow.
29 * keyboard.h: Change prototypes to match the above.
30
31 * image.c: Integer and memory overflow fixes.
32 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
33 now that they've been promoted to lisp.h.
34 (x_allocate_bitmap_record, x_alloc_image_color)
35 (make_image_cache, cache_image, xpm_load):
36 Don't update size until alloc is done.
37 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
38 (x_detect_edges):
39 Check for size calculation overflow.
40 (ct_colors_allocated_max): New constant.
41 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
42 overflow.
43
44 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
45
46 * gtkutil.c: Integer overflow fixes.
47 (get_utf8_string, xg_store_widget_in_map):
48 Check for size-calculation overflow.
49 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
50 do, as we prefer signed integers.
51 (id_to_widget.max_size, id_to_widget.used)
52 (xg_store_widget_in_map, xg_remove_widget_from_map)
53 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
54 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
55 Use and return ptrdiff_t, not int.
56 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
57 * gtkutil.h: Change prototypes to match the above.
58
59 * ftfont.c: Check for size overflow.
60 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
61 Check for integer overflow in size calculations.
62
63 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
64
65 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
66 This is for the members text_lines, text_cols, total_lines, total_cols,
67 where the system imposes an 'int' limit.
68
69 * frame.c: Integer overflow fixes.
70 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
71 (x_figure_window_size): Check for integer overflow.
72 (x_set_alpha): Do not assume XINT fits in int.
73
74 * eval.c: Integer and memory overflow fixes.
75 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
76 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
77
78 * emacs.c (main, sort_args): Check for size-calculation overflow.
79
80 * editfns.c: Integer and memory overflow fixes.
81 (set_time_zone_rule): Don't assume environment length fits in int.
82 (message_length): Now ptrdiff_t, not int.
83 (Fmessage_box): Don't update size until allocation succeeds.
84 Don't assume message length fits in int.
85 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
86
87 * doc.c: Integer and memory overflow fixes.
88 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
89 (get_doc_string): Check for size calculation overflow.
90 Don't update size until allocation succeeds.
91 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
92 EMACS_INT, where ptrdiff_t will do.
93 (Fsubstitute_command_keys): Check for string overflow.
94
95 Integer and memory overflow fixes for display code.
96 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
97 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
98 Check for overflow in size calculations.
99 (line_draw_cost, realloc_glyph_pool, add_row_entry):
100 Don't assume glyph table len fits in int.
101 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
102 (row_table_size): Now ptrdiff_t, not int.
103 (scrolling_window): Avoid overflow in size calculations.
104 Don't update size until allocation succeeds.
105 * fns.c (concat): Check for overflow in size calculations.
106 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
107 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
108 (NEXT_ALMOST_PRIME_LIMIT): New constant.
109
110 * composite.c: Integer overflow fixes.
111 (get_composition_id): Check for overflow in glyph length calculations.
112
113 * coding.c: Integer and memory overflow fixes.
114 (produce_chars): Redo buffer-overflow calculations to avoid
115 unnecessary integer overflow. Check for size overflow.
116 (encode_coding_object): Don't update size until xmalloc succeeds.
117
118 * character.c (Fstring): Check for size-calculation overflow.
119
120 * ccl.c: Integer and memory overflow fixes.
121 (Fccl_execute_on_string): Check for memory overflow.
122 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
123 Redo buffer-overflow calculations to avoid integer overflow.
124
125 * callproc.c (child_setup): Don't assume strlen fits in int.
126
127 * buffer.c: Memory overflow fixes.
128 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
129 Don't update size of array until after memory allocation succeeds,
130 because xmalloc/xrealloc may not return.
131
132 * bidi.c: Integer overflow fix.
133 (bidi_shelve_header_size): New constant.
134 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
135 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
136
137 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
138
139 Use ptrdiff_t for composition IDs.
140 * character.c (lisp_string_width):
141 * composite.c (composition_table_size, n_compositions)
142 (get_composition_id, composition_gstring_from_id):
143 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
144 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
145 * window.c (Frecenter):
146 Use ptrdiff_t, not int, for composition IDs.
147 * composite.c (get_composition_id): Check for integer overflow.
148 * composite.h: Adjust prototypes to match the above changes.
149
150 Use ptrdiff_t for hash table indexes.
151 * category.c (hash_get_category_set):
152 * ccl.c (ccl_driver):
153 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
154 * coding.c (coding_system_charset_list, detect_coding_system):
155 * coding.h (struct coding_system.id):
156 * composite.c (get_composition_id, gstring_lookup_cache):
157 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
158 * image.c (xpm_get_color_table_h):
159 * lisp.h (hash_lookup, hash_put):
160 * minibuf.c (Ftest_completion):
161 Use ptrdiff_t for hash table indexes, not int (which is too
162 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
163 32-bit --with-wide-int hosts).
164
165 * charset.c (Fdefine_charset_internal): Check for integer overflow.
166 Add a FIXME comment about memory leaks.
167 (syms_of_charset): Don't assume xmalloc returns.
168
169 Don't assume that stated character widths fit in int.
170 * character.c (Fchar_width, c_string_width, lisp_string_width):
171 * character.h (CHAR_WIDTH):
172 * indent.c (MULTIBYTE_BYTES_WIDTH):
173 Use sanitize_char_width to avoid undefined and/or bad behavior
174 with outlandish widths.
175 * character.h (sanitize_tab_width): Renamed from sanitize_width,
176 now that we have two such functions. All uses changed.
177 (sanitize_char_width): New inline function.
178
179 Don't assume that tab-width fits in int.
180 * character.h (sanitize_width): New inline function.
181 (SANE_TAB_WIDTH): New macro.
182 (ASCII_CHAR_WIDTH): Use it.
183 * indent.c (sane_tab_width): Remove. All uses replaced by
184 SANE_TAB_WIDTH (current_buffer).
185 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
186
187 * fileio.c: Integer overflow issues with file modes.
188 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
189
190 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
191 Remove unreachable code.
192 (read_hex, load_charset_map_from_file): Check for integer overflow.
193
194 * xterm.c: don't go over XClientMessageEvent limit
195 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
196 (x_send_scroll_bar_event): Likewise. Check that the size does not
197 exceed limits imposed by XClientMessageEvent, as well as the usual
198 ptrdiff_t and size_t limits.
199
200 * keyboard.c: Overflow, signedness and related fixes.
201 (make_lispy_movement): Use same integer type in forward decl
202 that is used in the definition.
203 (read_key_sequence, keyremap_step):
204 Change bufsize argument back to int, undoing my 2011-03-30 change.
205 We prefer signed types, and int is wide enough here.
206 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
207 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
208 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
209 length, not size_t. Use ptrdiff_t for index, not int.
210 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
211 possibility of integer overflow.
212
213 Overflow, signedness and related fixes for images.
214
215 * dispextern.h (struct it.stack[0].u.image.image_id)
216 (struct_it.image_id, struct image.id, struct image_cache.size)
217 (struct image_cache.used, struct image_cache.ref_count):
218 * gtkutil.c (update_frame_tool_bar):
219 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
220 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
221 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
222 * nsmenu.m (update_frame_tool_bar):
223 * xdisp.c (calc_pixel_width_or_height):
224 * xfns.c (image_cache_refcount):
225 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
226 on typical 64-bit hosts.
227
228 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
229 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
230 Omit unnecessary casts to int.
231 (parse_image_spec): Check that integers fall into 'int' range
232 when the callers expect that.
233 (image_ascent): Redo ascent calculation to avoid int overflow.
234 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
235 (lookup_image): Remove unnecessary tests.
236 (xbm_image_p): Locals are now of int, not EMACS_INT,
237 since parse_image_check makes sure they fit into int.
238 (png_load, gif_load, svg_load_image):
239 Prefer int to unsigned where either will do.
240 (tiff_handler): New function, combining the cores of the
241 old tiff_error_handler and tiff_warning_handler. This
242 function is rewritten to use vsnprintf and thereby avoid
243 stack buffer overflows. It uses only the features of vsnprintf
244 that are common to both POSIX and native Microsoft.
245 (tiff_error_handler, tiff_warning_handler): Use it.
246 (tiff_load, gif_load, imagemagick_load_image):
247 Don't assume :index value fits in 'int'.
248 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
249 (imagemagick_load_image): Check that crop parameters fit into
250 the integer types that MagickCropImage accepts. Don't assume
251 Vimagemagick_render_type has a nonnegative value. Don't assume
252 size_t fits in 'long'.
253 (gs_load): Use printmax_t to print the widest integers possible.
254 Check for integer overflow when computing image height and width.
255
256 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
257
258 Integer signedness and overflow and related fixes. (Bug#9079)
259
260 * bidi.c: Integer size and overflow fixes.
261 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
262 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
263 (bidi_cache_find_level_change, bidi_cache_ensure_space)
264 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
265 (bidi_find_other_level_edge):
266 Use ptrdiff_t instead of EMACS_INT where either will do.
267 This works better on 32-bit hosts configured --with-wide-int.
268 (bidi_cache_ensure_space): Check for size-calculation overflow.
269 Use % rather than repeated addition, for better worst-case speed.
270 Don't set bidi_cache_size until after xrealloc returns, because it
271 might not return.
272 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
273 (bidi_cache_ensure_space): Also check that the bidi cache size
274 does not exceed that of the largest Lisp string or buffer. See Eli
275 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
276
277 * alloc.c (__malloc_size_t): Remove.
278 All uses replaced by size_t. See Andreas Schwab's note
279 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
280
281 * image.c: Improve checking for integer overflow.
282 (check_image_size): Assume that f is nonnull, since
283 it is always nonnull in practice. This is one less thing to
284 worry about when checking for integer overflow later.
285 (x_check_image_size): New function, which checks for integer
286 overflow issues inside X.
287 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
288 This removes the need for a memory_full check.
289 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
290 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
291 (xbm_read_bitmap_data): Change locals back to 'int', since
292 their values must fit in 'int'.
293 (xpm_load_image, png_load, tiff_load):
294 Invoke x_create_x_image_and_pixmap earlier,
295 to avoid much needless work if the image is too large.
296 (tiff_load): Treat overly large images as if
297 x_create_x_image_and_pixmap failed, not as malloc failures.
298 (gs_load): Use x_check_image_size.
299
300 * gtkutil.c: Omit integer casts.
301 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
302 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
303
304 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
305
306 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
307 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
308 would wrongly return t on a 64-bit host.
309
310 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
311 The plain *_OVERFLOW macros run afoul of GCC bug 49705
312 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
313 and therefore cause GCC to emit a bogus diagnostic in some cases.
314
315 * image.c: Integer signedness and overflow and related fixes.
316 This is not an exhaustive set of fixes, but it's time to
317 record what I've got.
318 (lookup_pixel_color, check_image_size): Remove redundant decls.
319 (check_image_size): Don't assume that arbitrary EMACS_INT values
320 fit in 'int', or that arbitrary 'double' values fit in 'int'.
321 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
322 (tiff_load, imagemagick_load_image):
323 Check for overflow in size calculations.
324 (x_create_x_image_and_pixmap): Remove unnecessary test for
325 xmalloc returning NULL; that can't happen.
326 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
327 (xpm_color_bucket): Use better integer hashing function.
328 (xpm_cache_color): Don't possibly over-allocate memory.
329 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
330 (gif_memory_source):
331 Use ptrdiff_t, not int or size_t, to record sizes.
332 (png_load): Don't assume values greater than 2**31 fit in 'int'.
333 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
334 either works, as we prefer signed integers.
335 (tiff_read_from_memory, tiff_write_from_memory):
336 Return tsize_t, not size_t, since that's what the TIFF API wants.
337 (tiff_read_from_memory): Don't fail simply because the read would
338 go past EOF; instead, return a short read.
339 (tiff_load): Omit no-longer-needed casts.
340 (Fimagemagick_types): Don't assume size fits into 'int'.
341
342 Improve hashing quality when configured --with-wide-int.
343 * fns.c (hash_string): New function, taken from sxhash_string.
344 Do not discard information about ASCII character case; this
345 discarding is no longer needed.
346 (sxhash-string): Use it. Change sig to match it. Caller changed.
347 * lisp.h: Declare it.
348 * lread.c (hash_string): Remove, since we now use fns.c's version.
349 The fns.c version returns a wider integer if --with-wide-int is
350 specified, so this should help the quality of the hashing a bit.
351
352 * emacs.c: Integer overflow minor fix.
353 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
354 Define only if GNU_LINUX.
355 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
356
357 * dispnew.c: Integer signedness and overflow fixes.
358 Remove unnecessary forward decls, that were a maintenance hassle.
359 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
360 All uses changed.
361 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
362 (scrolling_window): Use ptrdiff_t, not int, for byte count.
363 (prepare_desired_row, line_draw_cost):
364 Use int, not unsigned, where either works.
365 (save_current_matrix, restore_current_matrix):
366 Use ptrdiff_t, not size_t, where either works.
367 (init_display): Check for overflow more accurately, and without
368 relying on undefined behavior.
369
370 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
371 Remove, replacing with the new symbols in lisp.h. All uses changed.
372 * fileio.c (make_temp_name):
373 * filelock.c (lock_file_1, lock_file):
374 * xdisp.c (message_dolog):
375 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
376 Use pMd etc. instead.
377 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
378 replacing the pWIDE etc. symbols removed from editfns.c.
379
380 * keyboard.h (num_input_events): Now uintmax_t.
381 This is (very slightly) less likely to mess up due to wraparound.
382 All uses changed.
383
384 * buffer.c: Integer signedness fixes.
385 (alloc_buffer_text, enlarge_buffer_text):
386 Use ptrdiff_t rather than size_t when either will do, as we prefer
387 signed integers.
388
389 * alloc.c: Integer signedness and overflow fixes.
390 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
391 (__malloc_size_t): Default to size_t, not to int.
392 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
393 (Fgarbage_collect, mark_object_loop_halt, mark_object):
394 Prefer ptrdiff_t to size_t when either would do, as we prefer
395 signed integers.
396 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
397 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
398 Now const. Initialize with values that are in range even if char
399 is signed.
400 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
401 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
402 These functions do the right thing with sizes > 2**32.
403 (check_depth): Now ptrdiff_t, not int.
404 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
405 Adjust to new way of storing sizes. Check for size overflow bugs
406 in rest of code.
407 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
408 slightly wrong anyway, as it missed one instance of
409 XMALLOC_OVERRUN_CHECK_OVERHEAD.
410 (refill_memory_reserve): Omit needless cast to size_t.
411 (mark_object_loop_halt): Mark as externally visible.
412
413 * xselect.c: Integer signedness and overflow fixes.
414 (Fx_register_dnd_atom, x_handle_dnd_message):
415 Use ptrdiff_t, not size_t, since we prefer signed.
416 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
417 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
418 x_dnd_atoms_size and x_dnd_atoms_length.
419
420 * doprnt.c: Prefer signed to unsigned when either works.
421 * eval.c (verror):
422 * doprnt.c (doprnt):
423 * lisp.h (doprnt):
424 * xdisp.c (vmessage):
425 Use ptrdiff_t, not size_t, when using or implementing doprnt,
426 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
427 prefer signed arithmetic to avoid comparison confusion.
428 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
429 but is a bit tricky.
430
431 Assume freestanding C89 headers, string.h, stdlib.h.
432 * data.c, doprnt.c, floatfns.c, print.c:
433 Include float.h unconditionally.
434 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
435 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
436 * regex.c: Likewise for stddef.h, string.h.
437 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
438 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
439 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
440 (STDC_HEADERS): Remove obsolete defines.
441 * sysdep.c: Include limits.h unconditionally.
442
443 Assume support for memcmp, memcpy, memmove, memset.
444 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
445 * regex.c (memcmp, memcpy):
446 Remove; we assume C89 now.
447
448 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
449 (__malloc_safe_bcopy): Remove; no longer needed.
450
451 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
452 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
453 well either way, and we prefer signed to unsigned.
454
455 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
456
457 Port to OpenBSD.
458 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
459 and the surrounding thread.
460 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
461 rather than fgets, and retry after EINTR. Otherwise, 'emacs
462 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
463 timer goes off.
464 * s/openbsd.h (BROKEN_SIGIO): Define.
465 * unexelf.c (unexec) [__OpenBSD__]:
466 Don't update the .mdebug section of the Alpha COFF symbol table.
467
468 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
469
470 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
471 (bug#8460).
472
473 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
474
475 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
476 This fixes some race conditions on the permissions of any newly
477 created file.
478
479 * alloc.c (valid_pointer_p): Use pipe, not open.
480 This fixes some permissions issues when debugging.
481
482 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
483 If fchown fails to set both uid and gid, try to set just gid,
484 as that is sometimes allowed. Adjust the file's mode to eliminate
485 setuid or setgid bits that are inappropriate if fchown fails.
486
487 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
488
489 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
490 to compare Lisp_Objects.
491 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
492 global_gnutls_log_level, don't mistake it for a Lisp_Object.
493 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
494
495 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
496
497 * lread.c (read_integer): Unread even EOF character.
498 (read1): Likewise. Properly record start position of symbol.
499
500 * lread.c (read1): Read `#:' as empty uninterned symbol if no
501 symbol character follows.
502
503 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
504
505 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
506 This works around a problem with the previous change to Fcopy_file.
507 Recent glibc declares fchown with __attribute__((warn_unused_result)),
508 and without this change, GCC might complain about discarding
509 fchown's return value.
510
511 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
512
513 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
514
515 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
516
517 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
518
519 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
520
521 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
522 it's used from the C level.
523
524 * process.c: Use the same condition for POLL_FOR_INPUT in both
525 keyboard.c and process.c (bug#1858).
526
527 2011-07-09 Lawrence Mitchell <wence@gmx.li>
528
529 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
530 (Fgnutls_boot): Use it.
531
532 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
533
534 * doc.c (Fsubstitute_command_keys): Revert last change.
535
536 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
537
538 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
539 quotes the next character, and doesn't affect other longer
540 sequences (bug#8935).
541
542 * lread.c (syms_of_lread): Clarify that is isn't only
543 `eval-buffer' and `eval-defun' that's affected by
544 `lexical-binding' (bug#8460).
545
546 2011-07-15 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
549 bidi redisplay when a line includes both an image and is
550 truncated.
551
552 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
553
554 Fix minor problems found by static checking.
555 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
556 (elsz): Now a signed constant, not a size_t var. We prefer signed
557 types to unsigned, to avoid integer comparison confusion. Without
558 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
559 "cannot optimize loop, the loop counter may overflow", a symptom
560 of the confusion.
561 * indent.c (Fvertical_motion): Mark locals as initialized.
562 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
563
564 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
565
566 * search.c (Fre_search_backward): Mention `case-fold-search' in
567 all the re_search_* functions (bug#8138).
568
569 * keyboard.c (Fopen_dribble_file): Document when the file is
570 closed (bug#8056).
571
572 2011-07-14 Eli Zaretskii <eliz@gnu.org>
573
574 * bidi.c (bidi_dump_cached_states): Fix format of displaying
575 bidi_cache_idx.
576
577 Support bidi reordering of display and overlay strings.
578 * xdisp.c (compute_display_string_pos)
579 (compute_display_string_end): Accept additional argument STRING.
580 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
581 (reseat_to_string): Initialize bidi_it->string.s and
582 bidi_it->string.schars.
583 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
584 NULL (avoids a crash in bidi_paragraph_init). Initialize
585 itb.string.lstring.
586 (init_iterator): Call bidi_init_it only of a valid
587 buffer position was specified. Initialize paragraph_embedding to
588 L2R.
589 (reseat_to_string): Initialize the bidi iterator.
590 (display_string): If we need to ignore text properties of
591 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
592 original value of -1 will not work with bidi.)
593 (compute_display_string_pos): First arg is now struct
594 `text_pos *'; all callers changed. Support display properties on
595 Lisp strings.
596 (compute_display_string_end): Support display properties on Lisp
597 strings.
598 (init_iterator, reseat_1, reseat_to_string): Initialize the
599 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
600 when iterating on a string not from display properties).
601 (compute_display_string_pos, compute_display_string_end): Fix
602 calculation of the object to scan. Fixes an error when using
603 arrow keys.
604 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
605 base_level_stop; instead, set base_level_stop to BEGV. Fixes
606 crashes in vertical-motion.
607 (next_element_from_buffer): Improve commentary for when
608 the iterator is before prev_stop.
609 (init_iterator): Initialize bidi_p from the default value of
610 bidi-display-reordering, not from buffer-local value. Use the
611 buffer-local value only if initializing for buffer iteration.
612 (handle_invisible_prop): Support invisible properties on strings
613 that are being bidi-reordered.
614 (set_iterator_to_next): Support bidi reordering of C strings and
615 Lisp strings.
616 (next_element_from_string): Support bidi reordering of Lisp
617 strings.
618 (handle_stop_backwards): Support Lisp strings as well.
619 (display_string): Support display of R2L glyph rows. Use
620 IT_STRING_CHARPOS when displaying from a Lisp string.
621 (init_iterator): Don't initialize it->bidi_p for strings
622 here.
623 (reseat_to_string): Initialize it->bidi_p for strings here.
624 (next_element_from_string, next_element_from_c_string)
625 (next_element_from_buffer): Add xassert's for correspondence
626 between IT's object being iterated and it->bidi_it.string
627 structure.
628 (face_before_or_after_it_pos): Support bidi iteration.
629 (next_element_from_c_string): Handle the case of the first string
630 character that is not the first one in the visual order.
631 (get_visually_first_element): New function, refactored from common
632 parts of next_element_from_buffer, next_element_from_string, and
633 next_element_from_c_string.
634 (tool_bar_lines_needed, redisplay_tool_bar)
635 (display_menu_bar): Force left-to-right direction. Add a FIXME
636 comment for making that be controlled by a user option.
637 (push_it, pop_it): Save and restore the state of the
638 bidi iterator. Save and restore the bidi_p flag.
639 (pop_it): Iterate out of display property for string iteration as
640 well.
641 (iterate_out_of_display_property): Support iteration over strings.
642 (handle_single_display_spec): Set up it->bidi_it for iteration
643 over a display string, and call bidi_init_it.
644 (handle_single_display_spec, next_overlay_string)
645 (get_overlay_strings_1, push_display_prop): Set up the bidi
646 iterator for displaying display or overlay strings.
647 (forward_to_next_line_start): Don't use the shortcut if
648 bidi-iterating.
649 (back_to_previous_visible_line_start): If handle_display_prop
650 pushed the iterator stack, restore the internal state of the bidi
651 iterator by calling bidi_pop_it same number of times.
652 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
653 and we are bidi-iterating, don't decrement the iterator position;
654 instead, set the first_elt flag in the bidi iterator, to produce
655 the same effect.
656 (reseat_1): Remove redundant setting of string_from_display_prop_p.
657 (push_display_prop): xassert that we are iterating a buffer.
658 (push_it, pop_it): Save and restore paragraph_embedding member.
659 (handle_single_display_spec, next_overlay_string)
660 (get_overlay_strings_1, reseat_1, reseat_to_string)
661 (push_display_prop): Set up the `unibyte' member of bidi_it.string
662 correctly. Don't assume unibyte strings are not bidi-reordered.
663 (compute_display_string_pos)
664 (compute_display_string_end): Fix handling the case of C string.
665 (push_it, pop_it): Save and restore from_disp_prop_p.
666 (handle_single_display_spec, push_display_prop): Set the
667 from_disp_prop_p flag.
668 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
669 (pop_it): Call iterate_out_of_display_property only if we are
670 popping after iteration over a string that came from a display
671 property. Fix a typo in popping stretch info. Add an assertion
672 for verifying that the iterator position is in sync with the bidi
673 iterator.
674 (handle_single_display_spec, get_overlay_strings_1)
675 (push_display_prop): Fix initialization of paragraph direction for
676 string when that of the parent object is not yet determined.
677 (reseat_1): Call bidi_init_it to resync the bidi
678 iterator with IT's position. (Bug#7616)
679 (find_row_edges): If ROW->start.pos gives position
680 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
681 (handle_stop, back_to_previous_visible_line_start, reseat_1):
682 Reset the from_disp_prop_p flag.
683 (SAVE_IT, RESTORE_IT): New macros.
684 (pos_visible_p, face_before_or_after_it_pos)
685 (back_to_previous_visible_line_start)
686 (move_it_in_display_line_to, move_it_in_display_line)
687 (move_it_to, move_it_vertically_backward, move_it_by_lines)
688 (try_scrolling, redisplay_window, display_line): Use them when
689 saving a temporary copy of the iterator and restoring it back.
690 (back_to_previous_visible_line_start, reseat_1)
691 (init_iterator): Empty the bidi cache "stack".
692 (move_it_in_display_line_to): If iterator ended up at
693 EOL, but we never saw any buffer positions smaller than
694 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
695 motion in bidi-reordered lines.
696 (move_it_in_display_line_to): Record prev_method and prev_pos
697 immediately before the call to set_iterator_to_next. Fixes cursor
698 motion in bidi-reordered lines with stretch glyphs and strings
699 displayed in margins. (Bug#8133) (Bug#8867)
700 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
701 TO_CHARPOS.
702 (pos_visible_p): Support positions in bidi-reordered lines. Save
703 and restore bidi cache.
704
705 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
706 (bidi_paragraph_info): Delete unused struct.
707 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
708 (bidi_cache_start): New variable.
709 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
710 to zero.
711 (bidi_cache_fetch_state, bidi_cache_search)
712 (bidi_cache_find_level_change, bidi_cache_iterator_state)
713 (bidi_cache_find, bidi_peek_at_next_level)
714 (bidi_level_of_next_char, bidi_find_other_level_edge)
715 (bidi_move_to_visually_next): Compare cache index with
716 bidi_cache_start rather than with zero.
717 (bidi_fetch_char): Accept new argument STRING; all callers
718 changed. Support iteration over a string. Support strings with
719 display properties. Support unibyte strings. Fix the type of
720 `len' according to what STRING_CHAR_AND_LENGTH expects.
721 (bidi_paragraph_init, bidi_resolve_explicit_1)
722 (bidi_resolve_explicit, bidi_resolve_weak)
723 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
724 iteration over a string.
725 (bidi_set_sor_type, bidi_resolve_explicit_1)
726 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
727 can now be zero (for strings); special values 0 and -1 were
728 changed to -1 and -2, respectively.
729 (bidi_char_at_pos): New function.
730 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
731 Call it instead of FETCH_MULTIBYTE_CHAR.
732 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
733 initialized to valid values.
734 (bidi_init_it): Don't initialize charpos and bytepos with invalid
735 values.
736 (bidi_level_of_next_char): Allow the sentinel "position" to pass
737 the test for valid cached positions. Fix the logic for looking up
738 the sentinel state in the cache. GCPRO the Lisp string we are
739 iterating.
740 (bidi_push_it, bidi_pop_it): New functions.
741 (bidi_initialize): Initialize the bidi cache start stack pointer.
742 (bidi_cache_ensure_space): New function, refactored from part of
743 bidi_cache_iterator_state. Don't assume the required size is just
744 one BIDI_CACHE_CHUNK away.
745 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
746 (bidi_count_bytes, bidi_char_at_pos): New functions.
747 (bidi_cache_search): Don't assume bidi_cache_last_idx is
748 always valid if bidi_cache_idx is valid.
749 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
750 is valid if it's going to be used.
751 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
752 (bidi_cache_fetch_state, bidi_cache_search)
753 (bidi_cache_find_level_change, bidi_cache_ensure_space)
754 (bidi_cache_iterator_state, bidi_cache_find)
755 (bidi_find_other_level_edge, bidi_cache_start_stack): All
756 variables related to cache indices are now EMACS_INT.
757
758 * dispextern.h (struct bidi_string_data): New structure.
759 (struct bidi_it): New member `string'. Make flag members be 1-bit
760 fields, and put them last in the struct.
761 (compute_display_string_pos, compute_display_string_end): Update
762 prototypes.
763 (bidi_push_it, bidi_pop_it): Add prototypes.
764 (struct iterator_stack_entry): New members bidi_p,
765 paragraph_embedding, and from_disp_prop_p.
766 (struct it): Member bidi_p is now a bit field 1 bit wide.
767 (bidi_shelve_cache, bidi_unshelve_cache): Declare
768 prototypes.
769
770 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
771 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
772 and vector-like objects.
773
774 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
775 cache around display iteration.
776
777 * window.c (Fwindow_end, window_scroll_pixel_based)
778 (displayed_window_lines, Frecenter): Save and restore the bidi
779 cache around display iteration.
780
781 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
782
783 * editfns.c (Fdelete_region): Clarify the use of the named
784 parameters (bug#6788).
785
786 2011-07-14 Martin Rudalics <rudalics@gmx.at>
787
788 * indent.c (Fvertical_motion): Set and restore w->pointm when
789 saving and restoring the window's buffer (Bug#9006).
790
791 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
792
793 * editfns.c (Fstring_to_char): Clarify just what is returned
794 (bug#6576). Text by Eli Zaretskii.
795
796 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
797
798 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
799
800 2011-07-13 Eli Zaretskii <eliz@gnu.org>
801
802 * buffer.c (mmap_find): Fix a typo.
803
804 2011-07-13 Johan Bockgård <bojohan@gnu.org>
805
806 Fix execution of x selection hooks.
807 * xselect.c (Qx_lost_selection_functions)
808 (Qx_sent_selection_functions): New vars.
809 (syms_of_xselect): DEFSYM them.
810 (x_handle_selection_request): Pass Qx_sent_selection_functions
811 rather than Vx_sent_selection_functions to Frun_hook_with_args.
812 (x_handle_selection_clear,x_clear_frame_selections):
813 Pass Qx_lost_selection_functions rather than
814 Vx_lost_selection_functions to Frun_hook_with_args.
815
816 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
817
818 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
819 The old code sometimes used this field without initializing it.
820
821 * alloc.c (gc_sweep): Don't read past end of array.
822 In theory, the old code could also have corrupted Emacs internals,
823 though it'd be very unlikely.
824
825 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
826
827 * character.c (Fcharacterp): Don't advertise optional ignored
828 argument. (Bug#4026)
829
830 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
831
832 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
833 key" (bug#4257).
834
835 * window.c (Fset_window_start): Doc fix (bug#4199).
836 (Fset_window_hscroll): Ditto.
837
838 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
839
840 Fix minor new problems caught by GCC 4.6.1.
841 * term.c (init_tty): Remove unused local.
842 * xsettings.c (store_monospaced_changed): Define this function only
843 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
844 not used otherwise.
845
846 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
847
848 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
849
850 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
851
852 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
853 are the mini-buffer and the echo area (bug#3320).
854
855 * term.c (init_tty): Remove support for supdup, c10 and perq
856 terminals, which are no longer supported (bug#1482).
857
858 2011-07-10 Johan Bockgård <bojohan@gnu.org>
859
860 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
861
862 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
863
864 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
865 for non-popups (Bug#3642).
866
867 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
868
869 * alloc.c (reset_malloc_hooks): Protoize.
870 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
871 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
872 * cm.c (losecursor): Likewise.
873 * data.c (fmod): Likewise.
874 * dispnew.c (swap_glyphs_in_rows): Likewise.
875 * emacs.c (memory_warning_signal): Likewise.
876 * floatfns.c (float_error): Likewise.
877 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
878 (otf_open, font_otf_capability, generate_otf_features)
879 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
880 Likewise.
881 * image.c (pbm_read_file): Likewise.
882 * indent.c (string_display_width): Likewise.
883 * intervals.c (check_for_interval, search_for_interval)
884 (inc_interval_count, count_intervals, root_interval)
885 (adjust_intervals_for_insertion, make_new_interval): Likewise.
886 * lread.c (defalias): Likewise.
887 * ralloc.c (r_alloc_check): Likewise.
888 * regex.c (set_image_of_range_1, set_image_of_range)
889 (regex_grow_registers): Likewise.
890 * sysdep.c (strerror): Likewise.
891 * termcap.c (valid_filename_p, tprint, main): Likewise.
892 * tparam.c (main): Likewise.
893 * unexhp9k800.c (run_time_remap, save_data_space)
894 (update_file_ptrs, read_header, write_header, calculate_checksum)
895 (copy_file, copy_rest, display_header): Likewise.
896 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
897 Likewise.
898 * xdisp.c (check_it): Likewise.
899 * xfaces.c (register_color, unregister_color, unregister_colors):
900 Likewise.
901 * xfns.c (print_fontset_result): Likewise.
902 * xrdb.c (member, fatal, main): Likewise.
903
904 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
905
906 Fix minor problems found by static checking (Bug#9031).
907 * chartab.c (char_table_set_range, map_sub_char_table):
908 Remove unused locals.
909 (uniprop_table): Now static.
910 * composite.c (_work_char): Remove unused static var.
911
912 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
913
914 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
915
916 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
917
918 * gtkutil.c (qttip_cb): Remove code without function.
919
920 2011-07-09 Eli Zaretskii <eliz@gnu.org>
921
922 * w32.c (pthread_sigmask): New stub.
923
924 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
925
926 Use pthread_sigmask, not sigprocmask (Bug#9010).
927 sigprocmask is portable only for single-threaded applications, and
928 Emacs can be multi-threaded when it uses GTK.
929 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
930 (LIBES): Use it.
931 * callproc.c (Fcall_process):
932 * process.c (create_process):
933 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
934 Use pthread_sigmask, not sigprocmask.
935
936 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
937
938 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
939 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
940 wrong (Bug#8591).
941
942 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
943
944 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
945 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
946 (xg_hide_tooltip): Fix comment.
947
948 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
949 in registerServicesMenuSendTypes.
950 (validRequestorForSendType): Don't check ns_return_types.
951
952 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
953 ns_return_type.
954
955 2011-07-08 Jason Rumney <jasonr@gnu.org>
956
957 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
958 frame struct members of non-existent frames (Bug#6284).
959
960 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
961
962 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
963 variable firstTime not needed on OSX >= 10.6.
964 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
965 >= 10.5. Use setKnobProportion, setDoubleValue.
966
967 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
968 (MAC_OS_X_VERSION_10_5): Define if not defined.
969 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
970 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
971 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
972
973 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
974 cString and lossyCString on OSX >= 10.4
975
976 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
977 sizeToFit on OSX >= 10.2.
978
979 * nsimage.m (allocInitFromFile): Don't use deprecated method
980 bestRepresentationForDevice on OSX >= 10.6.
981
982 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
983 to avoid warning.
984
985 * emacs.c: Declare unexec_init_emacs_zone.
986
987 * nsgui.h: Fix compiler warning about gnulib redefining verify.
988
989 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
990
991 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
992 on svcsMenu (Bug#8842).
993
994 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
995 ns_return_types.
996 (Fns_list_services): Just return Qnil on 10.6, code not working there.
997
998 * nsterm.m (QUTF8_STRING): Declare.
999 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1000 (validRequestorForSendType): Return type is (id).
1001 Change indexOfObjectIdenticalTo to indexOfObject.
1002 Check if we have local selection before returning self (Bug#8842).
1003 (writeSelectionToPasteboard): Put local selection into paste board
1004 if we have a local selection (Bug#8842).
1005 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1006
1007 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1008 (ns_get_local_selection): Declare.
1009
1010 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1011
1012 * keymap.c (describe_map_tree): Don't insert a double newline at
1013 the end of the buffer (bug#1169) and return whether we inserted
1014 something.
1015
1016 * callint.c (Fcall_interactively): Change "reading args" to
1017 "providing args" to try to clarify what it does (bug#1010).
1018
1019 2011-07-07 Kenichi Handa <handa@m17n.org>
1020
1021 * composite.c (composition_compute_stop_pos): Ignore a static
1022 composition starting before CHARPOS (Bug#8915).
1023
1024 * xdisp.c (handle_composition_prop): Likewise.
1025
1026 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1027
1028 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1029 (Bug#9015)
1030
1031 2011-07-07 Kenichi Handa <handa@m17n.org>
1032
1033 * character.h (unicode_category_t): New enum type.
1034
1035 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1036 (Qchar_code_property_table): New variable.
1037 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1038 (UNIPROP_COMPRESSED_FORM_P): New macros.
1039 (char_table_ascii): Uncompress the compressed values.
1040 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1041 Uncompress the compressed values.
1042 (sub_char_table_ref_and_range): Likewise.
1043 (char_table_ref_and_range): Uncompress the compressed values.
1044 (sub_char_table_set): New arg is_uniprop. Callers changed.
1045 Uncompress the compressed values.
1046 (sub_char_table_set_range): Args changed. Callers changed.
1047 (char_table_set_range): Adjuted for the above change.
1048 (map_sub_char_table): Delete args default_val and parent. Add arg
1049 top. Give decoded values to a Lisp function.
1050 (map_char_table): Adjusted for the above change. Give decoded
1051 values to a Lisp function. Gcpro more variables.
1052 (uniprop_table_uncompress)
1053 (uniprop_decode_value_run_length): New functions.
1054 (uniprop_decoder, uniprop_decoder_count): New variables.
1055 (uniprop_get_decoder, uniprop_encode_value_character)
1056 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1057 New functions.
1058 (uniprop_encoder, uniprop_encoder_count): New variables.
1059 (uniprop_get_encoder, uniprop_table)
1060 (Funicode_property_table_internal, Fget_unicode_property_internal)
1061 (Fput_unicode_property_internal): New functions.
1062 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1063 Sunicode_property_table_internal, Sget_unicode_property_internal,
1064 and Sput_unicode_property_internal. Defvar_lisp
1065 char-code-property-alist.
1066
1067 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1068 Vunicode_category_table.
1069
1070 * font.c (font_range): Adjusted for the change of
1071 Vunicode_category_table.
1072
1073 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1074
1075 * m/iris4d.h: Remove file, move contents ...
1076 * s/irix6-5.h: ... here.
1077
1078 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 Remove unportable assumption about struct layout (Bug#8884).
1081 * alloc.c (mark_buffer):
1082 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1083 (clone_per_buffer_values): Don't assume that
1084 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1085 This isn't true in general, and it's particularly not true
1086 if Emacs is configured with --with-wide-int.
1087 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1088 New macros, used in the buffer.c change.
1089
1090 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * xsettings.c: Use both GConf and GSettings if both are available.
1093 (store_config_changed_event): Add comment.
1094 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1095 (store_tool_bar_style_changed): New functions.
1096 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1097 (struct xsettings): Move font inside HAVE_XFT.
1098 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1099 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1100 Move inside HAVE_XFT.
1101 (something_changed_gsettingsCB): Renamed from something_changedCB.
1102 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1103 also.
1104 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1105 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1106 (something_changed_gconfCB): Renamed from something_changedCB.
1107 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1108 (parse_settings): Move check for font inside HAVE_XFT.
1109 (read_settings, apply_xft_settings): Add comment.
1110 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1111 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1112 call store_font_name_changed.
1113 (xft_settings_event): Add comment.
1114 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1115 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1116 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1117 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1118 (xsettings_initialize): Call init_gsettings last.
1119 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1120 comment.
1121
1122 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Random fixes. E.g., (random) never returned negative values.
1125 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1126 subseconds part to the entropy, as that's a bit more random.
1127 Prefer signed to unsigned, since the signedness doesn't matter and
1128 in general we prefer signed. When given a limit, use a
1129 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1130 latter isn't right if USE_2_TAGS_FOR_INTS.
1131 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1132 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1133
1134 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * textprop.c (text_property_stickiness):
1137 Obey Vtext_property_default_nonsticky.
1138 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1139 * w32fns.c (syms_of_w32fns):
1140 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1141
1142 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1145 This is more efficient than Ffile_directory_p and avoids a minor race.
1146
1147 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1148
1149 * buffer.c (Foverlay_put): Say what the return value is
1150 (bug#7835).
1151
1152 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1153 is a directory before asking whether to use the file name
1154 (bug#7564).
1155 (barf_or_query_if_file_exists): Make the "File is a directory"
1156 error be more correct.
1157
1158 * fns.c (Frequire): Remove the mention of the .gz files, since
1159 that's installation-specific, but keep the mention of
1160 `get-load-suffixes'.
1161
1162 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1165 Report string overflow if the output is too long.
1166
1167 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1170 (syms_of_gnutls): Remove duplicate DEFSYM for
1171 Qgnutls_bootprop_verify_hostname_error, an error for
1172 Qgnutls_bootprop_verify_error (which is no longer used).
1173
1174 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1175 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1176 Also (re)move comments that are misplaced or no longer relevant.
1177
1178 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1179
1180 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1181
1182 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1185 and background color parameters if they have been changed.
1186
1187 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1188
1189 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1190
1191 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 * xsettings.c (SYSTEM_FONT): Define only when used.
1194 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1195
1196 * keymap.c (access_keymap_1): Now static.
1197
1198 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1199
1200 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1201 leave any prefix arg for the up event (Bug#1586).
1202
1203 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1204
1205 * lread.c (syms_of_lread): Mention single symbols defined by
1206 `defvar' or `defconst' (bug#7154).
1207
1208 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1209 (Frequire): Mention get-load-suffixes.
1210
1211 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1212
1213 * window.h (window): Remove clone_number slot.
1214 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1215 Remove.
1216 (make_parent_window, make_window, saved_window)
1217 (Fset_window_configuration, save_window_save): Don't deal with
1218 clone numbers.
1219 * buffer.c (Qclone_number): Remove declaration.
1220 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1221
1222 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1223
1224 Add multiple inheritance to keymaps.
1225 * keymap.c (Fmake_composed_keymap): New function.
1226 (Fset_keymap_parent): Simplify.
1227 (fix_submap_inheritance): Remove.
1228 (access_keymap_1): New function extracted from access_keymap to handle
1229 embedded parents and handle lists of maps.
1230 (access_keymap): Use it.
1231 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1232 (Fcopy_keymap): Handle embedded parents.
1233 (Fcommand_remapping, define_as_prefix): Simplify.
1234 (Fkey_binding): Simplify.
1235 (syms_of_keymap): Move minibuffer-local-completion-map,
1236 minibuffer-local-filename-completion-map,
1237 minibuffer-local-must-match-map, and
1238 minibuffer-local-filename-must-match-map to Elisp.
1239 (syms_of_keymap): Defsubr make-composed-keymap.
1240 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1241 (parse_menu_item): Trivial simplification.
1242
1243 2011-07-01 Glenn Morris <rgm@gnu.org>
1244
1245 * Makefile.in (SETTINGS_LIBS): Fix typo.
1246
1247 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1248
1249 * coding.c (Fencode_coding_string): Record the last coding system
1250 used, as the function doc string says (bug#8738).
1251
1252 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1253
1254 * xsettings.c (store_monospaced_changed): Take new font as arg and
1255 check for change against current_mono_font.
1256 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1257 (emacs_settings_constructor, emacs_settings_get_property)
1258 (emacs_settings_set_property, emacs_settings_class_init)
1259 (emacs_settings_init, gsettings_obj): Remove.
1260 (something_changedCB): New function for HAVE_GSETTINGS.
1261 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1262 with value as argument.
1263 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1264 g_settings_new (Bug#8967). Do not create gsettings_obj.
1265 Remove calls to g_settings_bind. Connect something_changedCB to
1266 "changed".
1267
1268 * xgselect.c: Add defined (HAVE_GSETTINGS).
1269 (xgselect_initialize): Ditto.
1270
1271 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1272 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1273 xg_select.
1274
1275 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1276
1277 * eval.c (struct backtrace): Simplify and port the data structure.
1278 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1279 signed bit field, as this assumption is not portable and it makes
1280 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1281 "char debug_on_exit : 1" as this is not portable either; instead,
1282 use the portable "unsigned int debug_on_exit : 1". Remove unused
1283 member evalargs. Remove obsolete comments about cc bombing out.
1284
1285 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1286
1287 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1288 Let HAVE_GSETTINGS override HAVE_GCONF.
1289 (store_monospaced_changed): New function.
1290 (EMACS_SETTINGS): A new type derived from GObject to handle
1291 GSettings notifications.
1292 (emacs_settings_constructor, emacs_settings_get_property)
1293 (emacs_settings_set_property, emacs_settings_class_init):
1294 New functions.
1295 (gsettings_client, gsettings_obj): New variables.
1296 (GSETTINGS_SCHEMA): New define.
1297 (something_changedCB): Call store_monospaced_changed.
1298 (init_gsettings): New function.
1299 (xsettings_initialize): Call init_gsettings.
1300 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1301 to NULL.
1302
1303 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1304 GCONF_CFLAGS/LIBS.
1305
1306 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1307
1308 * window.c (resize_root_window, grow_mini_window)
1309 (shrink_mini_window): Rename Qresize_root_window to
1310 Qwindow_resize_root_window and Qresize_root_window_vertically to
1311 Qwindow_resize_root_window_vertically.
1312
1313 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1316
1317 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * makefile.w32-in: Redesign dependencies so they reflect more
1320 clearly which files are directly included by each source file,
1321 and not through other includes.
1322
1323 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1324
1325 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1326 (sort_overlays, overlay_strings): When an overlay's clone number
1327 matches the window's clone number process the overlay even if
1328 the overlay's window property doesn't match the current window.
1329
1330 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1331 (Fwindow_hchild): Rename to Fwindow_left_child.
1332 (Fwindow_next): Rename to Fwindow_next_sibling.
1333 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1334 (resize_window_check): Rename to window_resize_check.
1335 (resize_window_apply): Rename to window_resize_apply.
1336 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1337 (Fdelete_other_windows_internal, resize_frame_windows)
1338 (Fsplit_window_internal, Fdelete_window_internal)
1339 (grow_mini_window, shrink_mini_window)
1340 (Fresize_mini_window_internal): Fix callers accordingly.
1341
1342 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1343
1344 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1345 (emacs_fixed_set_min_size): Remove.
1346 (emacs_fixed_new): Take frame as argument.
1347
1348 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1349 (_EmacsFixedPrivate): Remove minwidth/height.
1350 Add struct frame *f.
1351 (emacs_fixed_init): Initialize priv->f.
1352 (get_parent_class, emacs_fixed_set_min_size): Remove.
1353 (emacs_fixed_new): Set priv->f to argument.
1354 (emacs_fixed_get_preferred_width)
1355 (emacs_fixed_get_preferred_height): Use min_width/height from
1356 frames size_hint to set minimum and natural (Bug#8919).
1357 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1358 and use min_width/height from frames size_hint to set
1359 min_width/height (Bug#8919).
1360
1361 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1362 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1363 Fix indentation.
1364
1365 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1366
1367 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1368 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1369 called at ZV.
1370
1371 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1372
1373 * process.c (wait_reading_process_output): Bypass select if
1374 waiting for a cell while ignoring keyboard input, and input is
1375 pending. Suggested by Jan Djärv (Bug#8869).
1376
1377 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 Use gnulib's dup2 module instead of rolling our own.
1380 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1381
1382 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1383
1384 * dispnew.c (scrolling_window): Before scrolling, turn off a
1385 mouse-highlight in the window being scrolled.
1386
1387 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1388
1389 Move DEFSYM to lisp.h and use everywhere.
1390
1391 * character.h (DEFSYM): Move declaration...
1392 * lisp.h (DEFSYM): ...here.
1393
1394 * gnutls.c:
1395 * minibuf.c:
1396 * w32menu.c:
1397 * w32proc.c:
1398 * w32select.c: Don't include character.h.
1399
1400 * alloc.c (syms_of_alloc):
1401 * buffer.c (syms_of_buffer):
1402 * bytecode.c (syms_of_bytecode):
1403 * callint.c (syms_of_callint):
1404 * casefiddle.c (syms_of_casefiddle):
1405 * casetab.c (init_casetab_once):
1406 * category.c (init_category_once, syms_of_category):
1407 * ccl.c (syms_of_ccl):
1408 * cmds.c (syms_of_cmds):
1409 * composite.c (syms_of_composite):
1410 * dbusbind.c (syms_of_dbusbind):
1411 * dired.c (syms_of_dired):
1412 * dispnew.c (syms_of_display):
1413 * doc.c (syms_of_doc):
1414 * editfns.c (syms_of_editfns):
1415 * emacs.c (syms_of_emacs):
1416 * eval.c (syms_of_eval):
1417 * fileio.c (syms_of_fileio):
1418 * fns.c (syms_of_fns):
1419 * frame.c (syms_of_frame):
1420 * fringe.c (syms_of_fringe):
1421 * insdel.c (syms_of_insdel):
1422 * keymap.c (syms_of_keymap):
1423 * lread.c (init_obarray, syms_of_lread):
1424 * macros.c (syms_of_macros):
1425 * msdos.c (syms_of_msdos):
1426 * print.c (syms_of_print):
1427 * process.c (syms_of_process):
1428 * search.c (syms_of_search):
1429 * sound.c (syms_of_sound):
1430 * syntax.c (init_syntax_once, syms_of_syntax):
1431 * terminal.c (syms_of_terminal):
1432 * textprop.c (syms_of_textprop):
1433 * undo.c (syms_of_undo):
1434 * w32.c (globals_of_w32):
1435 * window.c (syms_of_window):
1436 * xdisp.c (syms_of_xdisp):
1437 * xfaces.c (syms_of_xfaces):
1438 * xfns.c (syms_of_xfns):
1439 * xmenu.c (syms_of_xmenu):
1440 * xsettings.c (syms_of_xsettings):
1441 * xterm.c (syms_of_xterm): Use DEFSYM.
1442
1443 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1444
1445 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1446
1447 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 Integer and buffer overflow fixes (Bug#8873).
1450
1451 * print.c (printchar, strout): Check for string overflow.
1452 (PRINTPREPARE, printchar, strout):
1453 Don't set size unless allocation succeeds.
1454
1455 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1456 for sizes. Check for string overflow more accurately.
1457 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1458
1459 * macros.c: Integer and buffer overflow fixes.
1460 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1461 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1462 Use ptrdiff_t, not int, for sizes.
1463 Don't increment bufsize until after realloc succeeds.
1464 Check for size-calculation overflow.
1465 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1466
1467 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1468
1469 * lread.c: Integer overflow fixes.
1470 (read_integer): Radix is now EMACS_INT, not int,
1471 to improve quality of diagnostics for out-of-range radices.
1472 Calculate buffer size correctly for out-of-range radices.
1473 (read1): Check for integer overflow in radices, and in
1474 read-circle numbers.
1475 (read_escape): Avoid int overflow.
1476 (Fload, openp, read_buffer_size, read1)
1477 (substitute_object_recurse, read_vector, read_list, map_obarray):
1478 Use ptrdiff_t, not int, for sizes.
1479 (read1): Use EMACS_INT, not int, for sizes.
1480 Check for size overflow.
1481
1482 * image.c (cache_image): Check for size arithmetic overflow.
1483
1484 * lread.c: Integer overflow issues.
1485 (saved_doc_string_size, saved_doc_string_length)
1486 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1487 Now ptrdiff_t, not int.
1488 (read1): Don't assume doc string length fits in int. Check for
1489 out-of-range doc string lengths.
1490 (read_list): Don't assume file position fits in int.
1491 (read_escape): Check for hex character overflow.
1492
1493 2011-06-22 Leo Liu <sdl.web@gmail.com>
1494
1495 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1496 Move to minibuffer.el.
1497
1498 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1501 The following patches are for when GLYPH_DEBUG && !XASSERT.
1502 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1503 * dispnew.c (flush_stdout):
1504 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1505 Mark as externally visible.
1506 * dispnew.c (check_window_matrix_pointers): Now static.
1507 * dispnew.c (window_to_frame_vpos):
1508 * xfns.c (unwind_create_frame):
1509 * xterm.c (x_check_font): Remove unused local.
1510 * scroll.c (CHECK_BOUNDS):
1511 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1512 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1513 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1514 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1515 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1516 Now static.
1517 (debug_method_add): Use va_list and vsprintf rather than relying
1518 on undefined behavior with wrong number of arguments.
1519 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1520 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1521 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1522 since we're not interested in debugging glyphs with old libraries.
1523 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1524 GCC 4.6.0's static checking.
1525
1526 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 Integer overflow and signedness fixes (Bug#8873).
1529 A few related buffer overrun fixes, too.
1530
1531 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1532
1533 * dispextern.h (struct face.stipple):
1534 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1535 (x_bitmap_mask, x_allocate_bitmap_record)
1536 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1537 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1538 (x_create_bitmap_from_xpm_data):
1539 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1540 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1541 (.bitmaps_last):
1542 * xfaces.c (load_pixmap):
1543 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1544 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1545 (.bitmaps_last, struct x_output.icon_bitmap):
1546 Use ptrdiff_t, not int, for bitmap indexes.
1547 (x_allocate_bitmap_record): Check for size overflow.
1548 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1549
1550 Use ptrdiff_t, not int, for overlay counts.
1551 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1552 * editfns.c (overlays_around, get_pos_property):
1553 * textprop.c (get_char_property_and_overlay):
1554 * xdisp.c (next_overlay_change, note_mouse_highlight):
1555 * xfaces.c (face_at_buffer_position):
1556 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1557 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1558 (Fnext_overlay_change, Fprevious_overlay_change)
1559 (mouse_face_overlay_overlaps, Foverlays_in):
1560 Use ptrdiff_t, not int, for sizes.
1561 (overlays_at, overlays_in): Check for size-calculation overflow.
1562
1563 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1564
1565 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1566 (x_session_initialize): Do not assume string length fits in int.
1567
1568 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1569 This is unlikely, but can occur if DPI is outlandish.
1570
1571 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1572 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1573
1574 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1575 * xrdb.c (magic_file_p, search_magic_path):
1576 Omit last arg SUFFIX; it was always 0. All callers changed.
1577 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1578
1579 * xfont.c (xfont_match): Avoid need for strlen.
1580
1581 * xfns.c: Don't assume strlen fits in int.
1582 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1583
1584 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1585 not unsigned long, as we prefer signed integers. All callers changed.
1586 Detect integer overflow in repeat count.
1587 (message_dolog): Don't assume print length fits in 39 bytes.
1588 (display_mode_element): Don't assume strlen fits in int.
1589
1590 * termcap.c: Don't assume sizes fit in int and never overflow.
1591 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1592 (gobble_line): Check for size-calculation overflow.
1593
1594 * minibuf.c (Fread_buffer):
1595 * lread.c (intern, intern_c_string):
1596 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1597 Don't assume string length fits in int.
1598
1599 * keyboard.c (parse_tool_bar_item):
1600 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1601
1602 * font.c: Don't assume string length fits in int.
1603 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1604 Use ptrdiff_t, not int.
1605 (font_intern_prop): Don't assume string length fits in int.
1606 Don't assume integer property fits in fixnum.
1607 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1608
1609 * filelock.c: Fix some buffer overrun and integer overflow issues.
1610 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1611 Reformulate so as not to need the command string.
1612 Invoke gzip -cd rather than gunzip, as it's more portable.
1613 (lock_info_type, lock_file_1, lock_file):
1614 Don't assume pid_t and time_t fit in unsigned long.
1615 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1616 (current_lock_owner): Prefer signed type for sizes.
1617 Use memcpy, not strncpy, where memcpy is what is really wanted.
1618 Don't assume (via atoi) that time_t and pid_t fit in int.
1619 Check for time_t and/or pid_t out of range, e.g., via a network share.
1620 Don't alloca where an auto var works fine.
1621
1622 * fileio.c: Fix some integer overflow issues.
1623 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1624 Don't assume string length fits in int.
1625 (directory_file_name): Don't assume string length fits in long.
1626 (make_temp_name): Don't assume pid fits in int, or that its print
1627 length is less than 20.
1628
1629 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1630
1631 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1632
1633 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1634
1635 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1636 We prefer signed integers, even for size calculations.
1637
1638 * emacs.c: Don't assume string length fits in 'int'.
1639 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1640 (main): Don't invoke strlen when not needed.
1641
1642 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1643 (XD_DEBUG_MESSAGE): Don't waste a byte.
1644
1645 * callproc.c (getenv_internal_1, getenv_internal)
1646 (Fgetenv_internal):
1647 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1648
1649 * lread.c (invalid_syntax): Omit length argument.
1650 All uses changed. This doesn't fix a bug, but it simplifies the
1651 code away from its former Hollerith-constant appearance, and it's
1652 one less 'int' to worry about when looking at integer-overflow issues.
1653 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1654
1655 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1656 This didn't break anything, but it didn't help either.
1657 It's confusing to put a bogus integer in a place where the actual
1658 value does not matter.
1659 (LIST_END_P): Remove unused macro and its bogus comment.
1660 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1661
1662 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1663 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1664 implementation.
1665 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1666 We prefer signed types, and the value cannot exceed the EMACS_INT
1667 range anyway (because otherwise the length would not be representable).
1668 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1669 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1670 This avoids a GCC warning when WIDE_EMACS_INT.
1671
1672 * indent.c (sane_tab_width): New function.
1673 (current_column, scan_for_column, Findent_to, position_indentation)
1674 (compute_motion): Use it. This is just for clarity.
1675 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1676
1677 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1678
1679 * lisp.h (lint_assume): New macro.
1680 * composite.c (composition_gstring_put_cache):
1681 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1682
1683 * editfns.c, insdel.c:
1684 Omit unnecessary forward decls, to simplify future changes.
1685
1686 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1687
1688 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1689
1690 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1691 Use much-faster test for byte-length change.
1692 Don't assume string byte-length fits in 'int'.
1693 Check that character arg fits in 'int'.
1694 (mapcar1): Declare byte as byte, for clarity.
1695
1696 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1697
1698 * fns.c (concat): Catch string overflow earlier.
1699 Do not rely on integer wraparound.
1700
1701 * dispextern.h (struct it.overlay_strings_charpos)
1702 (struct it.selective): Now EMACS_INT, not int.
1703 * xdisp.c (forward_to_next_line_start)
1704 (back_to_previous_visible_line_start)
1705 (reseat_at_next_visible_line_start, next_element_from_buffer):
1706 Don't arbitrarily truncate the value of 'selective' to int.
1707
1708 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1709
1710 * composite.c: Don't truncate sizes to 'int'.
1711 (composition_gstring_p, composition_reseat_it)
1712 (composition_adjust_point): Use EMACS_INT, not int.
1713 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1714 not EMACS_UINT, for indexes.
1715
1716 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1717
1718 * buffer.c: Include <verify.h>.
1719 (struct sortvec.priority, struct sortstr.priority):
1720 Now EMACS_INT, not int.
1721 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1722 (struct sortstr.size, record_overlay_string)
1723 (struct sortstrlist.size, struct sortlist.used):
1724 Don't truncate size to int.
1725 (record_overlay_string): Check for size-calculation overflow.
1726 (init_buffer_once): Check at compile-time, not run-time.
1727
1728 2011-06-22 Jim Meyering <meyering@redhat.com>
1729
1730 Don't leak an XBM-image-sized buffer
1731 * image.c (xbm_load): Free the image buffer after using it.
1732
1733 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 Port to Sun C.
1736 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1737 that Sun C diagnosed.
1738 * fns.c (secure_hash): Fix pointer signedness issue.
1739 * intervals.c (static_offset_intervals): New function.
1740 (offset_intervals): Use it.
1741
1742 2011-06-21 Leo Liu <sdl.web@gmail.com>
1743
1744 * deps.mk (fns.o):
1745 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1746 sha512.h.
1747
1748 * fns.c (secure_hash): Rename from crypto_hash_function and change
1749 the first arg to accept symbols.
1750 (Fsecure_hash): New primitive.
1751 (syms_of_fns): New symbols.
1752
1753 2011-06-20 Deniz Dogan <deniz@dogan.se>
1754
1755 * process.c (Fset_process_buffer): Clarify return value in
1756 docstring.
1757
1758 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1759
1760 * dispnew.c (add_window_display_history): Use BVAR.
1761
1762 * xdisp.c (debug_method_add): Use BVAR.
1763 (check_window_end, dump_glyph_matrix, dump_glyph)
1764 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1765
1766 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1767 Likewise.
1768
1769 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1770 check till after the cache is created in init_frame_faces.
1771
1772 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1773
1774 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1775
1776 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1779 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1780 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1781
1782 Improve buffer-overflow checking (Bug#8873).
1783 * fileio.c (Finsert_file_contents):
1784 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1785 Remove the old (too-loose) buffer overflow checks.
1786 They weren't needed, since make_gap checks for buffer overflow.
1787 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1788 The old code merely checked for Emacs fixnum overflow, and relied
1789 on undefined (wraparound) behavior. The new code avoids undefined
1790 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1791
1792 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1793 Tune. Don't use wider integers than needed. Don't use alloca.
1794 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1795
1796 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1797
1798 * insdel.c, lisp.h (buffer_overflow): New function.
1799 (insert_from_buffer_1, replace_range, replace_range_2):
1800 * insdel.c (make_gap_larger):
1801 * editfns.c (Finsert_char):
1802 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1803
1804 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1805
1806 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1807
1808 Integer overflow and signedness fixes (Bug#8873).
1809
1810 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1811 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1812
1813 * fileio.c: Don't assume EMACS_INT fits in off_t.
1814 (emacs_lseek): New static function.
1815 (Finsert_file_contents, Fwrite_region): Use it.
1816 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1817
1818 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1819
1820 * fns.c: Don't overflow int when computing a list length.
1821 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1822 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1823 truncation on 64-bit hosts. Check for QUIT every
1824 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1825 faster and is responsive enough.
1826 (Flength): Report an error instead of overflowing an integer.
1827 (Fsafe_length): Return a float if the value is not representable
1828 as a fixnum. This shouldn't happen except in contrived situations.
1829 (Fnthcdr, Fsort): Don't assume list length fits in int.
1830 (Fcopy_sequence): Don't assume vector length fits in int.
1831
1832 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1833 (header_size, word_size): New constants.
1834 (allocate_vectorlike): Don't check size overflow here.
1835 (allocate_vector): Check it here instead, since this is the only
1836 caller of allocate_vectorlike that could cause overflow.
1837 Check that the new vector's length is representable as a fixnum.
1838
1839 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1840 The previous code was bogus. For example, next_almost_prime (32)
1841 returned 39, which is undesirable as it is a multiple of 3; and
1842 next_almost_prime (24) returned 25, which is a multiple of 5 so
1843 why was the code bothering to check for multiples of 7?
1844
1845 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1846
1847 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1848
1849 Variadic C functions now count arguments with ptrdiff_t.
1850 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1851 Back then I didn't know that the Emacs coding style prefers signed int.
1852 Also, in the meantime I found a few more instances where arguments
1853 were being counted with int, which may truncate counts on 64-bit
1854 machines, or EMACS_INT, which may be unnecessarily wide.
1855 * lisp.h (struct Lisp_Subr.function.aMANY)
1856 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1857 Arg counts are now ptrdiff_t, not size_t.
1858 All variadic functions and their callers changed accordingly.
1859 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1860 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1861 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1862 * callint.c (Fcall_interactively): Check arg count for overflow,
1863 to avoid potential buffer overrun. Use signed char, not 'int',
1864 for 'varies' array, so that we needn't bother to check its size
1865 calculation for overflow.
1866 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1867 * eval.c (apply_lambda):
1868 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1869 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1870 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1871
1872 * callint.c (Fcall_interactively): Don't use index var as event count.
1873
1874 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1875 * mem-limits.h (SIZE): Remove; no longer used.
1876
1877 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1878
1879 Remove unnecessary casts.
1880 * xterm.c (x_term_init):
1881 * xfns.c (x_set_border_pixel):
1882 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1883 These aren't needed now that we assume ANSI C.
1884
1885 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1886 It's more likely to cause problems (due to unsigned overflow)
1887 than to cure them.
1888
1889 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1890
1891 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1892
1893 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1894
1895 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1896
1897 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1898
1899 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1900
1901 GLYPH_CODE_FACE returns EMACS_INT, not int.
1902 * dispextern.h (merge_faces):
1903 * xfaces.c (merge_faces):
1904 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1905 Don't assume EMACS_INT fits in int.
1906
1907 * character.h (CHAR_VALID_P): Remove unused parameter.
1908 * fontset.c, lisp.h, xdisp.c: All uses changed.
1909
1910 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1911
1912 * fns.c (concat): Minor tuning based on overflow analysis.
1913 This doesn't fix any bugs. Use int to hold character, instead
1914 of constantly refetching from Emacs object. Use XFASTINT, not
1915 XINT, for value known to be a character. Don't bother comparing
1916 a single byte to 0400, as it's always less.
1917
1918 * floatfns.c (Fexpt):
1919 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1920
1921 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1922 for characters.
1923
1924 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1925
1926 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1927 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1928 incorrectly succeed when S was a string, because 4294967386 was
1929 truncated before it was used.
1930
1931 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1932 Otherwise, an out-of-range integer could cause undefined behavior
1933 on a 64-bit host.
1934
1935 * composite.c: Use int, not EMACS_INT, for characters.
1936 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1937 EMACS_INT, for values that are known to be in character range.
1938 This doesn't fix any bugs but is the usual style inside Emacs and
1939 may generate better code on 32-bit machines.
1940
1941 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1942 This is for reasons similar to the recent CHAR_STRING fix.
1943 * charset.c (Fencode_char): Check that character arg is actually
1944 a character. Pass an int to ENCODE_CHAR.
1945 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1946 wider than 'int', as a compile-time check to prevent future regressions
1947 in this area.
1948
1949 * character.c (char_string): Remove unnecessary casts.
1950
1951 Make sure a 64-bit char is never passed to CHAR_STRING.
1952 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1953 by silently ignoring the top 32 bits, allowing some values
1954 that were far too large to be valid characters.
1955 * character.h: Include <verify.h>.
1956 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1957 arguments are no wider than unsigned, as a compile-time check
1958 to prevent future regressions in this area.
1959 * data.c (Faset):
1960 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1961 (Fsubst_char_in_region):
1962 * fns.c (concat):
1963 * xdisp.c (decode_mode_spec_coding):
1964 Adjust to CHAR_STRING's new requirement.
1965 * editfns.c (Finsert_char, Fsubst_char_in_region):
1966 * fns.c (concat): Check that character args are actually
1967 characters. Without this test, these functions did the wrong
1968 thing with wildly out-of-range values on 64-bit hosts.
1969
1970 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1971 These casts should not be needed on 32-bit hosts, either.
1972 * keyboard.c (read_char):
1973 * lread.c (Fload): Remove casts to unsigned.
1974
1975 * lisp.h (UNSIGNED_CMP): New macro.
1976 This fixes comparison bugs on 64-bit hosts.
1977 (ASCII_CHAR_P): Use it.
1978 * casefiddle.c (casify_object):
1979 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1980 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1981 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1982 * dispextern.h (FACE_FROM_ID):
1983 * keyboard.c (read_char): Use UNSIGNED_CMP.
1984
1985 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1986 not to EMACS_INT, to avoid GCC warning.
1987
1988 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1989
1990 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1991 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1992 isn't needed on 32-bit machines.
1993
1994 * buffer.c (Fgenerate_new_buffer_name):
1995 Use EMACS_INT for count, not int.
1996 (advance_to_char_boundary): Return EMACS_INT, not int.
1997
1998 * data.c (Qcompiled_function): Now static.
1999
2000 * window.c (window_body_lines): Now static.
2001
2002 * image.c (gif_load): Rename local to avoid shadowing.
2003
2004 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2005 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2006 * alloc.c (make_save_value): Integer argument is now of type
2007 ptrdiff_t, not int.
2008 (mark_object): Use ptrdiff_t, not int.
2009 * lisp.h (pD): New macro.
2010 * print.c (print_object): Use it.
2011
2012 * alloc.c: Use EMACS_INT, not int, to count objects.
2013 (total_conses, total_markers, total_symbols, total_vector_size)
2014 (total_free_conses, total_free_markers, total_free_symbols)
2015 (total_free_floats, total_floats, total_free_intervals)
2016 (total_intervals, total_strings, total_free_strings):
2017 Now EMACS_INT, not int. All uses changed.
2018 (Fgarbage_collect): Compute overall total using a double, so that
2019 integer overflow is less likely to be a problem. Check for overflow
2020 when converting back to an integer.
2021 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2022 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2023 These were 'int' variables that could overflow on 64-bit hosts;
2024 they were never used, so remove them instead of repairing them.
2025 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2026 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2027 Previously, this ceilinged at INT_MAX, but that doesn't work on
2028 64-bit machines.
2029 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2030
2031 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2032 (allocate_vectorlike): Check for ptrdiff_t overflow.
2033 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2034 when a (possibly-narrower) signed value would do just as well.
2035 We prefer using signed arithmetic, to avoid comparison confusion.
2036
2037 * alloc.c: Catch some string size overflows that we were missing.
2038 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2039 for convenience in STRING_BYTES_MAX.
2040 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2041 The definition here is exact; the one in lisp.h was approximate.
2042 (allocate_string_data): Check for string overflow. This catches
2043 some instances we weren't catching before. Also, it catches
2044 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2045 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2046 and ptrdiff_t and EMACS_INT are both 64 bits.
2047
2048 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2049 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2050 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2051
2052 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2053
2054 * alloc.c (Fmake_string): Check for out-of-range init.
2055
2056 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2059
2060 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2061
2062 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2063 xg_get_default_scrollbar_width.
2064
2065 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2066 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2067 (style_changed_cb): Call update_theme_scrollbar_width and call
2068 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2069 all frames (Bug#8505).
2070 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2071 Call gtk_window_set_resizable if HAVE_GTK3.
2072 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2073 and height if HAVE_GTK3 (Bug#8505).
2074 (scroll_bar_width_for_theme): New variable.
2075 (update_theme_scrollbar_width): New function.
2076 (xg_get_default_scrollbar_width): Move code to
2077 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2078 (xg_initialize): Call update_theme_scrollbar_width.
2079
2080 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2081
2082 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2083
2084 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2085
2086 * frame.c (make_frame): Call other_buffer_safely instead of
2087 other_buffer.
2088
2089 * window.c (temp_output_buffer_show): Call display_buffer with
2090 second argument Vtemp_buffer_show_specifiers and reset latter
2091 immediately after the call.
2092 (Vtemp_buffer_show_specifiers): New variable.
2093 (auto_window_vscroll_p, next_screen_context_lines)
2094 (Vscroll_preserve_screen_position): Remove leading asterisks from
2095 doc-strings.
2096
2097 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 Fix minor problems found by GCC 4.6.0 static checking.
2100 * buffer.c (Qclone_number): Remove for now, as it's unused.
2101 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2102 (record_buffer): Remove unused local.
2103 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2104 (set_frame_buffer_list): Remove; unused.
2105 * frame.h (other_visible_frames): Remove decl.
2106 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2107 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2108 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2109 if HAVE_GPM.
2110 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2111 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2112 Define only if HAVE_GPM.
2113 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2114 (update_hints_inhibit): Remove; never set. All uses removed.
2115 * widgetprv.h (emacsFrameClassRec): Remove decl.
2116 * window.c (delete_deletable_window): Now returns void, since it
2117 wasn't returning anything.
2118 (compare_window_configurations): Remove unused locals.
2119 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2120 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2121 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2122 the same widths as pointers. This follows up on the 2011-05-06 patch.
2123 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2124 * xterm.h: Likewise.
2125 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2126
2127 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * makefile.w32-in: Update dependencies.
2130 (LISP_H): Add lib/intprops.h.
2131
2132 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2133
2134 * image.c (gif_load): Add animation frame delay to the metadata.
2135 (syms_of_image): Use DEFSYM. New symbol `delay'.
2136
2137 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2138
2139 * window.c (delete_deletable_window): Re-add.
2140 (Fset_window_configuration): Rewrite to handle dead buffers and
2141 consequently deletable windows.
2142 (window_tree, Fwindow_tree): Remove. Supply functionality in
2143 window.el.
2144 (compare_window_configurations): Simplify code.
2145
2146 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2147
2148 * image.c (imagemagick_load_image): Fix type mismatch.
2149 (Fimagemagick_types): Likewise.
2150
2151 * window.h (replace_buffer_in_windows): Declare.
2152
2153 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2154
2155 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2156 Qclone_number. Remove external declaration of Qdelete_window.
2157 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2158 code.
2159 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2160 Qbuffer_list_update_hook if allowed.
2161 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2162 buffer list implementation.
2163 (other_buffer_safely): New function.
2164 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2165 calls to replace_buffer_in_windows and
2166 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2167 if allowed.
2168 (record_buffer): Inhibit quitting and rewrite using quittable
2169 functions. Run Qbuffer_list_update_hook if allowed.
2170 (Frecord_buffer, Funrecord_buffer): New functions.
2171 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2172 switch-to-buffer to window.el.
2173 (bury-buffer): Move to window.el.
2174 (Vbuffer_list_update_hook): New variable.
2175
2176 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2177 section.
2178
2179 * window.h (resize_frame_windows): Move up in code.
2180 (Fwindow_frame): Remove EXFUN.
2181 (replace_buffer_in_all_windows): Remove prototype.
2182 (replace_buffer_in_windows_safely): Add prototype.
2183
2184 * window.c: Declare Qdelete_window static again. Move down
2185 declaration of select_count.
2186 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2187 (Fother_window): Move to window.el.
2188 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2189 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2190 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2191 window.el.
2192 (replace_buffer_in_windows): Implement by calling
2193 Qreplace_buffer_in_windows.
2194 (replace_buffer_in_all_windows): Remove with some functionality
2195 moved into replace_buffer_in_windows_safely.
2196 (replace_buffer_in_windows_safely): New function.
2197 (select_window_norecord, select_frame_norecord): Move in front
2198 of run_window_configuration_change_hook. Remove now obsolete
2199 declarations.
2200 (Fset_window_buffer): Rewrite doc-string. Call
2201 Qrecord_window_buffer.
2202 (keys_of_window): Move binding for other-window to window.el.
2203
2204 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2205
2206 * dispextern.h (struct image): Replace data member, whose int_val
2207 and ptr_val fields were not used by anything, with a single
2208 lisp_val object.
2209
2210 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2211 (gif_clear_image, gif_load, imagemagick_load_image)
2212 (gs_clear_image, gs_load): Callers changed.
2213
2214 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 * buffer.h: Include <time.h>, for time_t.
2217 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2218
2219 Fix minor problems found by static checking.
2220
2221 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2222
2223 Make identifiers static if they are not used in other modules.
2224 * data.c (Qcompiled_function, Qframe, Qvector):
2225 * image.c (QimageMagick, Qsvg):
2226 * minibuf.c (Qmetadata):
2227 * window.c (resize_window_check, resize_root_window): Now static.
2228 * window.h (resize_window_check, resize_root_window): Remove decls.
2229
2230 * window.c (window_deletion_count, delete_deletable_window):
2231 Remove; unused.
2232 (window_body_lines): Now static.
2233 (Fdelete_other_windows_internal): Mark vars as initialized.
2234 Make sure 'resize_failed' is initialized.
2235 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2236 (resize_window_apply): Remove unused local.
2237 * window.h (delete_deletable_window): Remove decl.
2238
2239 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2240 (imagemagick_load_image): Fix pointer signedness problem by changing
2241 last arg from unsigned char * to char *. All uses changed.
2242 Also, fix a local for similar reasons.
2243 Remove unused locals. Remove locals to avoid shadowing.
2244 (fn_rsvg_handle_free): Remove; unused.
2245 (svg_load, svg_load_image): Fix pointer signedness problem.
2246 (imagemagick_load_image): Don't use garbage pointer image_wand.
2247
2248 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2249
2250 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * image.c (gif_load): Fix omitted cast error introduced by
2253 2011-06-06 change.
2254
2255 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2256
2257 * window.h (resize_proportionally, orig_total_lines)
2258 (orig_top_line): Remove from window structure.
2259 (set_window_height, set_window_width, change_window_heights)
2260 (Fdelete_window): Remove prototypes.
2261 (resize_frame_windows): Remove duplicate declaration.
2262
2263 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2264
2265 * window.h (resize_frame_windows, resize_window_check)
2266 (delete_deletable_window, resize_root_window)
2267 (resize_frame_windows): Declare prototypes.
2268
2269 * window.c (resize_window_apply): Make definition be "static" to
2270 match the prototype.
2271
2272 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2273
2274 * window.c: Remove declarations of Qwindow_size_fixed,
2275 window_min_size_1, window_min_size_2, window_min_size,
2276 size_window, window_fixed_size_p, enlarge_window, delete_window.
2277 Remove static from declaration of Qdelete_window, it's
2278 temporarily needed by Fbury_buffer.
2279 (replace_window): Don't assign orig_top_line and
2280 orig_total_lines.
2281 (Fdelete_window, delete_window): Remove. Window deletion is
2282 handled by window.el.
2283 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2284 Fdelete_window calls with calls to Qdelete_window.
2285 (Fdelete_other_windows): Remove. Deleting other windows is
2286 handled by window.el.
2287 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2288 handled in window.el.
2289 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2290 Window minimum sizes are handled in window.el.
2291 (shrink_windows, size_window, set_window_height)
2292 (set_window_width, change_window_heights, window_height)
2293 (window_width, CURBEG, CURSIZE, enlarge_window)
2294 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2295 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2296 handled in window.el.
2297 (make_dummy_parent): Rename to make_parent_window and give it a
2298 second argument horflag.
2299 (make_window): Don't set resize_proportionally any more.
2300 (Fsplit_window): Remove. Windows are split in window.el.
2301 (save_restore_action, save_restore_orig_size)
2302 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2303 Resize mini windows in window.el.
2304 (grow_mini_window, shrink_mini_window): Implement by calling
2305 Qresize_root_window_vertically, resize_window_check and
2306 resize_window_apply.
2307 (saved_window, Fset_window_configuration, save_window_save): Do
2308 not handle orig_top_line, orig_total_lines, and
2309 resize_proportionally.
2310 (window_min_height, window_min_width): Move to window.el.
2311 (keys_of_window): Move bindings for delete-other-windows,
2312 split-window, delete-window and enlarge-window to window.el.
2313
2314 * buffer.c: Temporarily extern Qdelete_window.
2315 (Fbury_buffer): Temporarily call Qdelete_window instead of
2316 Fdelete_window (Fbury_buffer will move to window.el soon).
2317
2318 * frame.c (set_menu_bar_lines_1): Remove code handling
2319 orig_top_line and orig_total_lines.
2320
2321 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2322 set_window_height but set heights directly.
2323 (change_frame_size_1): Use resize_frame_windows.
2324
2325 * xdisp.c (init_xdisp): Don't use set_window_height but set
2326 heights directly.
2327
2328 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2329 resize_frame_windows instead of change_window_heights and run
2330 run_window_configuration_change_hook.
2331
2332 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2333 instead of change_window_heights and run
2334 run_window_configuration_change_hook.
2335
2336 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2337
2338 * window.c (replace_window): Rename second argument REPLACEMENT to
2339 NEW. New third argument SETFLAG. Rewrite.
2340 (delete_window, make_dummy_parent): Call replace_window with
2341 third argument 1.
2342 (window_list_1): Move down in code.
2343 (run_window_configuration_change_hook): Move set_buffer part
2344 before select_frame_norecord part in order to unwind correctly.
2345 Rename count1 to count.
2346 (recombine_windows, delete_deletable_window, resize_root_window)
2347 (Fdelete_other_windows_internal)
2348 (Frun_window_configuration_change_hook, make_parent_window)
2349 (resize_window_check, resize_window_apply, Fresize_window_apply)
2350 (resize_frame_windows, Fsplit_window_internal)
2351 (Fdelete_window_internal, Fresize_mini_window_internal): New
2352 functions.
2353 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2354
2355 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2356
2357 * window.h (window): Add some new members to window structure -
2358 normal_lines, normal_cols, new_total, new_normal, clone_number,
2359 splits, nest, prev_buffers, next_buffers.
2360 (WINDOW_TOTAL_SIZE): Move here from window.c.
2361 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2362
2363 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2364 Remove.
2365 (make_dummy_parent): Set new members of windows structure.
2366 (make_window): Move down in code. Handle new members of window
2367 structure.
2368 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2369 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2370 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2371 (Fset_window_prev_buffers, Fwindow_next_buffers)
2372 (Fset_window_next_buffers, Fset_window_clone_number): New
2373 functions.
2374 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2375 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2376 Doc-string fixes.
2377 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2378 Argument WINDOW can be now internal window too.
2379 (Fwindow_use_time): Move up in code.
2380 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2381 Rewrite doc-string.
2382 (Fset_window_configuration, saved_window)
2383 (Fcurrent_window_configuration, save_window_save): Handle new
2384 members of window structure.
2385 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2386 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2387 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2388 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2389 Qget_mru_window, Qresize_root_window,
2390 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2391 Qauto_buffer_name; staticpro them.
2392
2393 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2394
2395 * window.c (Fwindow_total_size, Fwindow_left_column)
2396 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2397 (Fwindow_list_1): New functions.
2398 (window_box_text_cols): Replace with window_body_cols.
2399 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2400 window_body_cols instead of window_box_text_cols.
2401 (delete_window, Fset_window_configuration): Call
2402 delete_all_subwindows with window as argument.
2403 (delete_all_subwindows): Take a window as argument and not a
2404 structure. Rewrite.
2405 (window_loop): Remove handling of GET_LRU_WINDOW and
2406 GET_LARGEST_WINDOW.
2407 (Fget_lru_window, Fget_largest_window): Move to window.el.
2408
2409 * window.h: Extern window_body_cols instead of
2410 window_box_text_cols. delete_all_subwindows now takes a
2411 Lisp_Object as argument.
2412
2413 * indent.c (compute_motion, Fcompute_motion): Use
2414 window_body_cols instead of window_box_text_cols.
2415
2416 * frame.c (delete_frame): Call delete_all_subwindows with root
2417 window as argument.
2418
2419 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2420
2421 * fns.c (Fputhash): Document return value.
2422
2423 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2424
2425 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2426
2427 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 Cons<->int and similar integer overflow fixes (Bug#8794).
2430
2431 Check for overflow when converting integer to cons and back.
2432 * charset.c (Fdefine_charset_internal, Fdecode_char):
2433 Use cons_to_unsigned to catch overflow.
2434 (Fencode_char): Use INTEGER_TO_CONS.
2435 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2436 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2437 * data.c (long_to_cons, cons_to_long): Remove.
2438 (cons_to_unsigned, cons_to_signed): New functions.
2439 These signal an error for invalid or out-of-range values.
2440 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2441 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2442 * font.c (Ffont_variation_glyphs):
2443 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2444 * lisp.h: Include <intprops.h>.
2445 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2446 (cons_to_signed, cons_to_unsigned): New decls.
2447 (long_to_cons, cons_to_long): Remove decls.
2448 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2449 (Fprimitive_undo): Use CONS_TO_INTEGER.
2450 * xfns.c (Fx_window_property): Likewise.
2451 * xselect.c: Include <limits.h>.
2452 (x_own_selection, selection_data_to_lisp_data):
2453 Use INTEGER_TO_CONS.
2454 (x_handle_selection_request, x_handle_selection_clear)
2455 (x_get_foreign_selection, Fx_disown_selection_internal)
2456 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2457 (lisp_data_to_selection_data): Use cons_to_unsigned.
2458 (x_fill_property_data): Use cons_to_signed.
2459 Report values out of range.
2460
2461 Check for buffer and string overflow more precisely.
2462 * buffer.h (BUF_BYTES_MAX): New macro.
2463 * lisp.h (STRING_BYTES_MAX): New macro.
2464 * alloc.c (Fmake_string):
2465 * character.c (string_escape_byte8):
2466 * coding.c (coding_alloc_by_realloc):
2467 * doprnt.c (doprnt):
2468 * editfns.c (Fformat):
2469 * eval.c (verror):
2470 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2471 since they may not be the same number.
2472 * editfns.c (Finsert_char):
2473 * fileio.c (Finsert_file_contents):
2474 Likewise for BUF_BYTES_MAX.
2475
2476 * image.c: Use ptrdiff_t, not int, for sizes.
2477 (slurp_file): Switch from int to ptrdiff_t.
2478 All uses changed.
2479 (slurp_file): Check that file size fits in both size_t (for
2480 malloc) and ptrdiff_t (for sanity and safety).
2481
2482 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2483 if b->modtime has its maximal value.
2484
2485 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2486
2487 Don't assume time_t can fit into int.
2488 * buffer.h (struct buffer.modtime): Now time_t, not int.
2489 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2490 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2491
2492 Minor fixes for signed vs unsigned integers.
2493 * character.h (MAYBE_UNIFY_CHAR):
2494 * charset.c (maybe_unify_char):
2495 * keyboard.c (read_char, reorder_modifiers):
2496 XINT -> XFASTINT, since the integer must be nonnegative.
2497 * ftfont.c (ftfont_spec_pattern):
2498 * keymap.c (access_keymap, silly_event_symbol_error):
2499 XUINT -> XFASTINT, since the integer must be nonnegative.
2500 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2501 since it makes no difference and we prefer signed.
2502 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2503 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2504 nonnegative.
2505
2506 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2507
2508 * window.h (Fwindow_frame): Declare.
2509
2510 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2513 (SPARE_MEMORY): Always define.
2514 (LARGE_REQUEST): Remove.
2515 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2516
2517 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2518
2519 * lisp.h: Move EXFUNS for Fframe_root_window,
2520 Fframe_first_window and Fset_frame_selected_window to window.h.
2521
2522 * window.h: Move EXFUNS for Fframe_root_window,
2523 Fframe_first_window and Fset_frame_selected_window here from
2524 lisp.h.
2525
2526 * frame.c (Fwindow_frame, Fframe_first_window)
2527 (Fframe_root_window, Fframe_selected_window)
2528 (Fset_frame_selected_window): Move to window.c.
2529 (Factive_minibuffer_window): Move to minibuf.c.
2530 (Fother_visible_frames_p): New function.
2531
2532 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2533
2534 * window.c (decode_window, decode_any_window): Move up in code.
2535 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2536 (inhibit_frame_unsplittable): Remove unused variable.
2537 (Fwindow_buffer): Move up and rewrite doc-string.
2538 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2539 (Fwindow_prev): New functions.
2540 (Fwindow_frame): Move here from frame.c. Accept any window as
2541 argument.
2542 (Fframe_root_window, Fframe_first_window)
2543 (Fframe_selected_window): Move here from frame.c. Accept frame
2544 or arbitrary window as argument. Update doc-strings.
2545 (Fminibuffer_window): Move up in code.
2546 (Fwindow_minibuffer_p): Move up in code and simplify.
2547 (Fset_frame_selected_window): Move here from frame.c.
2548 Marginal rewrite.
2549 (Fselected_window, select_window, Fselect_window): Move up in
2550 code. Minor doc-string fixes.
2551
2552 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2555 Do not assume that spare memory exists; that assumption is valid
2556 only if SYSTEM_MALLOC.
2557 (LARGE_REQUEST): New macro, so that the issue of large requests
2558 is separated from the issue of spare memory.
2559
2560 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2561
2562 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2563 format. (Bug#8806)
2564
2565 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2566
2567 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2568 before statements.
2569
2570 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2571
2572 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2573
2574 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2575
2576 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2577 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2578
2579 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2580
2581 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2582
2583 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2584
2585 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2586 (x_clipboard_manager_save): Add return value.
2587 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2588 New error handlers.
2589 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2590 Obey Vx_select_enable_clipboard_manager. Catch errors in
2591 x_clipboard_manager_save (Bug#8779).
2592 (Vx_select_enable_clipboard_manager): New variable.
2593 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2594
2595 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2596
2597 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2598
2599 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2600
2601 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2602 in the current matrix if keep_current_p is non-zero.
2603
2604 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2605
2606 * bidi.c (bidi_level_of_next_char): Fix last change.
2607
2608 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2609
2610 Support bidi reordering of text covered by display properties.
2611
2612 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2613 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2614 (bidi_cache_search, bidi_cache_iterator_state)
2615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2616 (bidi_level_of_next_char, bidi_move_to_visually_next):
2617 Support character positions inside a run of characters covered by a
2618 display string.
2619 (bidi_paragraph_init, bidi_resolve_explicit_1)
2620 (bidi_level_of_next_char): Call bidi_fetch_char and
2621 bidi_fetch_char_advance instead of FETCH_CHAR and
2622 FETCH_CHAR_ADVANCE.
2623 (bidi_init_it): Initialize new members.
2624 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2625 definitions.
2626 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2627 instead of using explicit *_CHAR codes.
2628 (bidi_resolve_explicit, bidi_resolve_weak):
2629 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2630 bidirectional text is supported only in multibyte buffers.
2631 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2632 it to initialize the frame_window_p member of struct bidi_it.
2633 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2634 (bidi_resolve_explicit, bidi_resolve_weak)
2635 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2636 bidi_it->nchars is non-positive.
2637 (bidi_level_of_next_char): Don't try to lookup the cache for the
2638 next/previous character if nothing is cached there yet, or if we
2639 were just reseat()'ed to a new position.
2640
2641 * xdisp.c (set_cursor_from_row): Set start and stop points
2642 according to the row's direction when priming the loop that looks
2643 for the glyph on which to display cursor.
2644 (single_display_spec_intangible_p): Function deleted.
2645 (display_prop_intangible_p): Reimplement to call
2646 handle_display_spec instead of single_display_spec_intangible_p.
2647 Accept 3 additional arguments needed by handle_display_spec.
2648 This fixes incorrect cursor motion across display property with complex
2649 values: lists, `(when COND...)' forms, etc.
2650 (single_display_spec_string_p): Support property values that are
2651 lists with the argument STRING its top-level element.
2652 (display_prop_string_p): Fix the condition for processing a
2653 property that is a list to be consistent with handle_display_spec.
2654 (handle_display_spec): New function, refactored from the
2655 last portion of handle_display_prop.
2656 (compute_display_string_pos): Accept additional argument
2657 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2658 value of a `display' property is a "replacing spec".
2659 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2660 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2661 the display property, but just return a value indicating whether
2662 the display property will replace the characters it covers.
2663 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2664 frame_window_p members of struct bidi_it.
2665 (compute_display_string_pos, compute_display_string_end):
2666 New functions.
2667 (push_it): Accept second argument POSITION, where pop_it should
2668 jump to continue iteration.
2669 (reseat_1): Initialize bidi_it.disp_pos.
2670
2671 * keyboard.c (adjust_point_for_property): Adjust the call to
2672 display_prop_intangible_p to its new signature.
2673
2674 * dispextern.h (struct bidi_it): New member frame_window_p.
2675 (bidi_init_it): Update prototypes.
2676 (display_prop_intangible_p): Update prototype.
2677 (compute_display_string_pos, compute_display_string_end):
2678 Declare prototypes.
2679 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2680 EMACS_INT.
2681
2682 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 Malloc failure behavior now depends on size of allocation.
2685 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2686 * lisp.h: Change signatures accordingly.
2687 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2688 All callers changed. (Bug#8762)
2689
2690 * gnutls.c: Use Emacs's memory allocators.
2691 Without this change, the gnutls library would invoke malloc etc.
2692 directly, which causes problems on non-SYNC_INPUT hosts, and which
2693 runs afoul of improving memory_full behavior. (Bug#8761)
2694 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2695 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2696 xfree instead of the default malloc, realloc, free.
2697 (Fgnutls_boot): No need to check for memory allocation failure,
2698 since xmalloc does that for us.
2699
2700 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2701 * category.c (hash_get_category_set):
2702 * ccl.c (ccl_driver):
2703 * charset.c (Fdefine_charset_internal):
2704 * charset.h (struct charset.hash_index):
2705 * composite.c (get_composition_id, gstring_lookup_cache)
2706 (composition_gstring_put_cache):
2707 * composite.h (struct composition.hash_index):
2708 * dispextern.h (struct image.hash):
2709 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2710 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2711 (hashfn_equal, hashfn_user_defined, make_hash_table)
2712 (maybe_resize_hash_table, hash_lookup, hash_put)
2713 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2714 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2715 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2716 * image.c (make_image, search_image_cache, lookup_image)
2717 (xpm_put_color_table_h):
2718 * lisp.h (struct Lisp_Hash_Table):
2719 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2720 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2721 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2722 * alloc.c (allocate_vectorlike):
2723 Check for overflow in vector size calculations.
2724 * ccl.c (ccl_driver):
2725 Check for overflow when converting EMACS_INT to int.
2726 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2727 need to be updated by these changes.
2728 * fns.c (make_hash_table, maybe_resize_hash_table):
2729 Check for integer overflow with large hash tables.
2730 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2731 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2732 (SXHASH_REDUCE): New macro.
2733 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2734 Use it instead of discarding useful hash info with large hash values.
2735 (sxhash_float): New function.
2736 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2737 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2738 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2739 Rewrite to use FIXNUM_BITS, as this simplifies things.
2740 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2741 Adjust signatures to match updated version of code.
2742 (consing_since_gc): Now EMACS_INT, since a single hash table can
2743 use more than INT_MAX bytes.
2744
2745 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2746
2747 Make it possible to build with GCC-4.6+ -O2 -flto.
2748
2749 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2750
2751 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2752
2753 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2754 Call minibuffer-inactive-mode.
2755
2756 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2757
2758 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2759 Update dependencies.
2760
2761 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2762
2763 * data.c (init_data): Remove code for UTS, this system is not
2764 supported anymore.
2765
2766 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2767
2768 Don't force ./temacs to start in terminal mode.
2769
2770 * frame.c (make_initial_frame): Initialize faces in all cases, not
2771 only when CANNOT_DUMP is defined.
2772 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2773
2774 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2775
2776 * dispnew.c (add_window_display_history): Use const for the string
2777 pointer. Remove declaration, not needed.
2778
2779 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 Use 'inline', not 'INLINE'.
2782 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2783 * alloc.c, fontset.c (INLINE): Remove.
2784 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2785 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2786 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2787 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2788 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2789
2790 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2791
2792 Make it possible to run ./temacs.
2793
2794 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2795 syms_of_callproc does the same thing. Remove test for
2796 "initialized", do it in the caller.
2797 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2798
2799 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2800
2801 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2802 (read_minibuf): Use get_minibuffer.
2803 (syms_of_minibuf): Use DEFSYM.
2804 (Qmetadata): New var.
2805 * data.c (Qbuffer): Don't make it static.
2806 (syms_of_data): Use DEFSYM.
2807
2808 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2811 (CCL_CODE_MIN): New macro.
2812
2813 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2816
2817 * eval.c (Qdebug): Now static.
2818 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2819 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2820 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2821
2822 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2823
2824 * image.c: Various fixes to ImageMagick code comments.
2825 (Fimagemagick_types): Doc fix.
2826
2827 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2828
2829 Minor fixes prompted by GCC 4.6.0 warnings.
2830
2831 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2832
2833 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2834 (x_clipboard_manager_save_all): Move extern decl to ...
2835 * xterm.h: ... here, so that it can be checked for consistency.
2836
2837 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2838
2839 * xselect.c (x_clipboard_manager_save_frame)
2840 (x_clipboard_manager_save_all): New functions.
2841 (Fx_clipboard_manager_save): Lisp function deleted.
2842
2843 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2844 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2845
2846 * xterm.h: Update prototype.
2847
2848 2011-05-28 William Xu <william.xwl@gmail.com>
2849
2850 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2851 exiting (Bug#8239).
2852
2853 2011-05-28 Jim Meyering <meyering@redhat.com>
2854
2855 Avoid a sign-extension bug in crypto_hash_function.
2856 * fns.c (to_uchar): Define.
2857 (crypto_hash_function): Use it to convert some newly-signed
2858 variables to unsigned, to avoid sign-extension bugs. For example,
2859 without this change, (md5 "truc") would evaluate to
2860 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2861 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2862 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2863
2864 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 Integer overflow fixes.
2867
2868 * dbusbind.c: Serial number integer overflow fixes.
2869 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2870 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2871 to hold a serial number that is too large for a fixnum.
2872 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2873 Check for serial numbers out of range. Decode any serial number
2874 that was so large that it became a float. (Bug#8722)
2875
2876 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2877 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2878 Use XFASTINT rather than XUINT when numbers are nonnegative.
2879 (xd_append_arg, Fdbus_method_return_internal):
2880 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2881 arguments, check that Lisp number is nonnegative, rather than
2882 silently wrapping negative numbers around. (Bug#8722)
2883 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2884 (Bug#8722)
2885
2886 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2887
2888 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2889
2890 ccl: add integer overflow checks
2891 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2892 (IN_INT_RANGE): New macros.
2893 (ccl_driver): Use them to check for integer overflow when
2894 decoding a CCL program. Many of the new checks are whether XINT (x)
2895 fits in int; it doesn't always, on 64-bit hosts. The new version
2896 doesn't catch all possible integer overflows, but it's an
2897 improvement. (Bug#8719)
2898
2899 * alloc.c (make_event_array): Use XINT, not XUINT.
2900 There's no need for unsigned here.
2901
2902 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2903 This follows up to the 2011-05-06 change that substituted uintptr_t
2904 for EMACS_INT. This case wasn't caught back then.
2905
2906 Rework Fformat to avoid integer overflow issues.
2907 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2908 now (part of C89). Include <verify.h>.
2909 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2910 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2911 (Fformat): Avoid the prepass trying to compute sizes; it was only
2912 approximate and thus did not catch overflow reliably. Instead, walk
2913 through the format just once, formatting and computing sizes as we go,
2914 checking for integer overflow at every step, and allocating a larger
2915 buffer as needed. Keep track separately whether the format is
2916 multibyte. Keep only the most-recently calculated precision, rather
2917 than them all. Record whether each argument has been converted to
2918 string. Use EMACS_INT, not int, for byte and char and arg counts.
2919 Support field widths and precisions larger than INT_MAX. Avoid
2920 sprintf's undefined behavior with conversion specifications such as %#d
2921 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2922 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2923 formatting out-of-range floating point numbers with int
2924 formats. (Bug#8668)
2925
2926 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2927
2928 * data.c: Avoid integer truncation in expressions involving floats.
2929 * data.c: Include <intprops.h>.
2930 (arith_driver): When there's an integer overflow in an expression
2931 involving floating point, convert the integers to floating point
2932 so that the resulting value does not suffer from catastrophic
2933 integer truncation. For example, on a 64-bit host (* 4
2934 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2935 Do not rely on undefined behavior after integer overflow.
2936
2937 merge count_size_as_multibyte, parse_str_to_multibyte
2938 * character.c, character.h (count_size_as_multibyte):
2939 Rename from parse_str_to_multibyte; all uses changed.
2940 Check for integer overflow.
2941 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2942 since it's now a duplicate of the other. This is more of
2943 a character than a buffer op, so better that it's in character.c.
2944 * fns.c, print.c: Adjust to above changes.
2945
2946 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2949
2950 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2953 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2954 (x_clipboard_manager_save): Now static.
2955 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2956
2957 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2958 (crypto_hash_function): Now static.
2959 Fix pointer signedness problems. Avoid unnecessary initializations.
2960
2961 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2962
2963 * termhooks.h (Vselection_alist): Make it terminal-local.
2964
2965 * terminal.c (create_terminal): Initialize it.
2966
2967 * xselect.c: Support for clipboard managers.
2968 (Vselection_alist): Move to termhooks.h as terminal-local var.
2969 (LOCAL_SELECTION): New macro.
2970 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2971 (symbol_to_x_atom): Remove gratuitous arg.
2972 (x_handle_selection_request, lisp_data_to_selection_data)
2973 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2974 (x_own_selection, x_get_local_selection, x_convert_selection):
2975 New arg, specifying work frame. Use terminal-local Vselection_alist.
2976 (some_frame_on_display): Delete unused function.
2977 (Fx_own_selection_internal, Fx_get_selection_internal)
2978 (Fx_disown_selection_internal, Fx_selection_owner_p)
2979 (Fx_selection_exists_p): New optional frame arg.
2980 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2981 (x_handle_selection_clear): Don't treat other terminals with the
2982 same keyboard specially. Use the terminal-local Vselection_alist.
2983 (x_clear_frame_selections): Use Frun_hook_with_args.
2984
2985 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2986
2987 * xterm.h: Add support for those atoms.
2988
2989 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2990
2991 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2992 (converted_selections, conversion_fail_tag): New global variables.
2993 (x_selection_request_lisp_error): Free the above.
2994 (x_get_local_selection): Remove unnecessary code.
2995 (x_reply_selection_request): Args changed; handle arbitrary array
2996 of converted selections stored in converted_selections.
2997 Separate the XChangeProperty and SelectionNotify steps.
2998 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2999 (x_convert_selection): New function.
3000 (x_handle_selection_event): Simplify.
3001 (x_get_foreign_selection): Don't ignore incoming requests while
3002 waiting for an answer; this will fail when we implement
3003 SAVE_TARGETS, and seems unnecessary anyway.
3004 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3005 (Vx_sent_selection_functions): Doc fix.
3006
3007 2011-05-26 Leo Liu <sdl.web@gmail.com>
3008
3009 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3010
3011 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3012
3013 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3014
3015 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3016 for fringe update if it has periodic bitmap.
3017 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3018 and fringe_bitmap_periodic_p.
3019
3020 * fringe.c (get_fringe_bitmap_data): New function.
3021 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3022 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3023 row. Mark glyph row for fringe update if periodicity changed.
3024
3025 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3026 for fringe update unless it has periodic bitmap.
3027
3028 2011-05-25 Kenichi Handa <handa@m17n.org>
3029
3030 * xdisp.c (get_next_display_element): Set correct it->face_id for
3031 a static composition.
3032
3033 2011-05-24 Leo Liu <sdl.web@gmail.com>
3034
3035 * deps.mk (fns.o):
3036 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3037
3038 * fns.c (crypto_hash_function, Fsha1): New function.
3039 (Fmd5): Use crypto_hash_function.
3040 (syms_of_fns): Add Ssha1.
3041
3042 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * gnutls.c: Remove unused macros.
3045 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3046 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3047 Remove macros that are defined and never used.
3048 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3049
3050 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3051
3052 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3053 (Fx_get_selection_internal): Minor cleanup.
3054 (Fx_own_selection_internal): Rename arguments for consistency with
3055 select.el.
3056
3057 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3060
3061 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3064
3065 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3066
3067 * dispnew.c (scrolling_window): Don't exclude the case that the
3068 last enabled row in the desired matrix touches the bottom boundary.
3069
3070 2011-05-21 Glenn Morris <rgm@gnu.org>
3071
3072 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3073 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3074 and add some more files.
3075
3076 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3077
3078 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3079 report_file_error introduced by the change from 2011-05-07.
3080
3081 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * systime.h (Time): Define only if emacs is defined.
3084 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3085 where the include path doesn't have X11/X.h by default. See
3086 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3087
3088 2011-05-20 Kenichi Handa <handa@m17n.org>
3089
3090 * composite.c (find_automatic_composition): Fix previous change.
3091
3092 2011-05-20 Glenn Morris <rgm@gnu.org>
3093
3094 * lisp.mk: New file, split from Makefile.in.
3095 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3096 (shortlisp): Remove.
3097 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3098
3099 2011-05-19 Glenn Morris <rgm@gnu.org>
3100
3101 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3102 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3103 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3104 (lisp): Set the order to that of loadup.el.
3105 (shortlisp): Make it a copy of $lisp.
3106 (SOME_MACHINE_LISP): Remove.
3107 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3108 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3109
3110 2011-05-18 Kenichi Handa <handa@m17n.org>
3111
3112 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3113 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3114 (find_automatic_composition): Mostly rewrite for efficiency.
3115
3116 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3117
3118 * makefile.w32-in: Update dependencies.
3119
3120 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3121
3122 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3123 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3124
3125 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Fix some integer overflow issues, such as string length overflow.
3128
3129 * insdel.c (count_size_as_multibyte): Check for string overflow.
3130
3131 * character.c (lisp_string_width): Check for string overflow.
3132 Use EMACS_INT, not int, for string indexes and lengths; in
3133 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3134 the resulting string length overflows an EMACS_INT; instead,
3135 report a string overflow if no precision given. When checking for
3136 precision exhaustion, use a check that cannot possibly have
3137 integer overflow. (Bug#8675)
3138 * character.h (lisp_string_width): Adjust to new signature.
3139
3140 * alloc.c (string_overflow): New function.
3141 (Fmake_string): Use it. This doesn't change behavior, but saves
3142 a few bytes and will simplify future changes.
3143 * character.c (string_escape_byte8): Likewise.
3144 * lisp.h (string_overflow): New decl.
3145
3146 Fixups, following up to the user-interface timestamp change.
3147 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3148 for UI timestamps, instead of unsigned long.
3149 * msdos.c (mouse_get_pos): Likewise.
3150 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3151 * w32gui.h (Time): Define by including "systime.h" rather than by
3152 declaring it ourselves. (Bug#8664)
3153
3154 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3155 * image.c (clear_image_cache): Likewise.
3156
3157 * term.c (term_mouse_position): Don't assume time_t wraparound.
3158
3159 Be more systematic about user-interface timestamps.
3160 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3161 and sometimes 'EMACS_UINT', to represent these timestamps.
3162 This change causes it to use 'Time' uniformly, as that's what X uses.
3163 This makes the code easier to follow, and makes it easier to catch
3164 integer overflow bugs such as Bug#8664.
3165 * frame.c (Fmouse_position, Fmouse_pixel_position):
3166 Use Time, not unsigned long, for user-interface timestamps.
3167 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3168 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3169 * keyboard.h (last_event_timestamp): Likewise.
3170 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3171 * menu.h (xmenu_show): Likewise.
3172 * term.c (term_mouse_position): Likewise.
3173 * termhooks.h (struct input_event.timestamp): Likewise.
3174 (struct terminal.mouse_position_hook): Likewise.
3175 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3176 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3177 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3178 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3179 what it was before.
3180 * menu.h, termhooks.h: Include "systime.h", for Time.
3181
3182 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3183 Don't assume that the difference between two unsigned long values
3184 can fit into an integer. At this point, we know button_down_time
3185 <= event->timestamp, so the difference must be nonnegative, so
3186 there's no need to cast the result if double-click-time is
3187 nonnegative, as it should be; check that it's nonnegative, just in
3188 case. This bug is triggered when events are more than 2**31 ms
3189 apart (about 25 days). (Bug#8664)
3190
3191 * xselect.c (last_event_timestamp): Remove duplicate decl.
3192 (x_own_selection): Remove needless cast to unsigned long.
3193
3194 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3195 that always fit in int. Use a sentinel instead of a counter, to
3196 avoid a temp and to allay GCC's concerns about possible int overflow.
3197 * frame.h (struct frame): Use int for menu_bar_items_used
3198 instead of EMACS_INT, since it always fits in int.
3199
3200 * menu.c (grow_menu_items): Check for int overflow.
3201
3202 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3203
3204 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3205 Before, the code was not consistent. These values cannot exceed
3206 2**31 - 1 so there's no need to make them unsigned.
3207 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3208 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3209 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3210 as modifiers.
3211 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3212
3213 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3214 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3215 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3216 presumably because the widths might not match.
3217
3218 * window.c (size_window): Avoid needless test at loop start.
3219
3220 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3221
3222 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3223
3224 2011-05-12 Drew Adams <drew.adams@oracle.com>
3225
3226 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3227
3228 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3229
3230 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3231 `width' to `bar_area_x' and `bar_area_width', respectively.
3232 (x_scroll_run): Take account of fringe background extension.
3233
3234 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3235 Rename local vars `left' and `width' to `bar_area_x' and
3236 `bar_area_width', respectively.
3237 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3238 background extension.
3239
3240 2011-05-10 Jim Meyering <meyering@redhat.com>
3241
3242 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3243
3244 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * image.c (Finit_image_library): Return t for built-in image types,
3247 like pbm and xbm. (Bug#8640)
3248
3249 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3250
3251 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3252
3253 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3254
3255 * w32console.c (Fset_screen_color): Doc fix.
3256 (Fget_screen_color): New function.
3257 (syms_of_ntterm): Defsubr it.
3258
3259 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3260 unlink the temporary file if Fcall_process didn't create it in the
3261 first place.
3262 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3263 child process will be redirected to a file specified with `:file'.
3264 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3265 cue to call_process_cleanup not to close that handle.
3266
3267 2011-05-07 Ben Key <bkey76@gmail.com>
3268
3269 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3270 one of two shell specific rules, either bootstrap-temacs-CMD or
3271 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3272 to the previous implementation of the bootstrap-temacs rule.
3273 The bootstrap-temacs-CMD rule is similar to the previous
3274 implementation of the bootstrap-temacs rule except that it
3275 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3276 variable.
3277
3278 These changes, along with some changes to nt/configure.bat,
3279 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3280 earlier fix to add support for --cflags and --ldflags options
3281 that include quotes so that it works whether make uses cmd or
3282 sh as the shell.
3283
3284 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3285
3286 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3287 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3288 is a constant.
3289 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3290 a string. Handle both cases.
3291 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3292 (Fdbus_register_method): Use Qinvalid_function.
3293
3294 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3295
3296 * makefile.w32-in: Update dependencies.
3297 (LISP_H): Add inttypes.h and stdin.h.
3298 (PROCESS_H): Add unistd.h.
3299
3300 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3301
3302 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3303 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3304
3305 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3308
3309 * term.c (vfatal): Remove stray call to va_end.
3310 It's not needed and the C Standard doesn't allow it here anyway.
3311
3312 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3313 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3314
3315 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3316 bytes.
3317
3318 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3319
3320 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3321
3322 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3323
3324 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3325
3326 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3327
3328 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3329 * charset.c (Fdefine_charset_internal): Don't initialize
3330 charset.code_space[15]. The value was garbage, on hosts with
3331 32-bit int (Bug#8600).
3332
3333 * lread.c (read_integer): Be more consistent with string-to-number.
3334 Use string_to_number to do the actual conversion; this avoids
3335 rounding errors and fixes some other screwups. Without this fix,
3336 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3337 (digit_to_number): Move earlier, for benefit of read_integer.
3338 Return -1 if the digit is out of range for the base, -2 if it is
3339 not a digit in any supported base. (Bug#8602)
3340
3341 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3342
3343 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3344 to match comment at start of function. This also removes a
3345 GCC warning about overflow in a 32+64-bit port.
3346
3347 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3348
3349 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3350 Reported by Stefan Monnier in
3351 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3352 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3353 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3354
3355 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3356 (EMACS_UINTPTR): Likewise, with uintptr_t.
3357
3358 * lisp.h: Prefer 64-bit EMACS_INT if available.
3359 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3360 on 32-bit hosts that have 64-bit int, so that they can access
3361 large files.
3362 However, temporarily disable this change unless the temporary
3363 symbol WIDE_EMACS_INT is defined.
3364
3365 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3366
3367 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3368 This removes an assumption that EMACS_INT and long are the same
3369 width as pointers. The assumption is true for Emacs porting targets
3370 now, but we want to make other targets possible.
3371 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3372 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3373 In the rest of the code, change types of integers that hold casted
3374 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3375 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3376 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3377 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3378 No need to cast type when ORing.
3379 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3380 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3381 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3382 assume EMACS_INT is the same width as char *.
3383 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3384 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3385 Remove no-longer-needed casts.
3386 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3387 (xg_tool_bar_help_callback, xg_make_tool_item):
3388 Use EMACS_INTPTR to hold an integer
3389 that will be cast to void *; this can avoid a GCC warning
3390 if EMACS_INT is not the same width as void *.
3391 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3392 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3393 (current_message_1, set_message_1):
3394 Use a local to convert to proper width without a cast.
3395 * xmenu.c (dialog_selection_callback): Likewise.
3396
3397 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3398 Also, don't assume VALBITS / RAND_BITS is less than 5,
3399 and don't rely on undefined behavior when shifting a 1 left into
3400 the sign bit.
3401 * lisp.h (get_random): Change signature to match.
3402
3403 * lread.c (hash_string): Use size_t, not int, for hash computation.
3404 Normally we prefer signed values; but hashing is special, because
3405 it's better to use unsigned division on hash table sizes so that
3406 the remainder is nonnegative. Also, size_t is the natural width
3407 for hashing into memory. The previous code used 'int', which doesn't
3408 retain enough info to hash well into very large tables.
3409 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3410
3411 * dbusbind.c: Don't possibly lose pointer info when converting.
3412 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3413 Use XPNTR rather than XHASH, so that the high-order bits of
3414 the pointer aren't lost when converting through void *.
3415
3416 * eval.c (Fautoload): Don't double-shift a pointer.
3417
3418 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3419
3420 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * gnutls.c (DEF_GNUTLS_FN):
3423 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3424
3425 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3426
3427 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3428 marker. (Bug#8610)
3429
3430 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3431
3432 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3433 New version that can reserve upto 2GB of heap space.
3434
3435 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3436
3437 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3438
3439 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3440
3441 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3442 `gnutls_certificate_set_x509_key_file'.
3443
3444 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3447 Update dependencies.
3448
3449 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3452 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3453 Remove unused parameter `fildes'.
3454 * process.c (read_process_output, send_process): Don't pass it.
3455
3456 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3457
3458 Fix previous change: the library cache is defined in w32.c.
3459 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3460 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3461
3462 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3463
3464 Implement dynamic loading of GnuTLS on Windows.
3465
3466 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3467 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3468 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3469 Declare.
3470
3471 * gnutls.c (Qgnutls_dll): Define.
3472 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3473 (gnutls_*): Declare function pointers.
3474 (init_gnutls_functions): New function to initialize function pointers.
3475 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3476 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3477 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3478 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3479 (emacs_gnutls_write, emacs_gnutls_read)
3480 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3481 (Fgnutls_available_p): New function.
3482 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3483 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3484 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3485
3486 * image.c: Include w32.h.
3487 (Vimage_type_cache): Delete.
3488 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3489 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3490 (w32_delayed_load): Move to w32.c.
3491
3492 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3493
3494 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3495 (w32_delayed_load): Move from image.c. When loading a library, record
3496 its filename in the :loaded-from property of the library id.
3497 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3498 Initialize and staticpro them.
3499 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3500
3501 * process.c: Include lisp.h before w32.h, not after.
3502 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3503 instead of gnutls_record_check_pending.
3504
3505 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3506
3507 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3508
3509 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3510 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3511 as passed in.
3512
3513 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3514
3515 * xterm.c (x_set_frame_alpha): Do not set property on anything
3516 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3517
3518 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3521
3522 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3525 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3526 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3527 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3528 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3529 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3530 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3531 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3532 (Qgnutls_bootprop_callbacks_verify): Make static.
3533
3534 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * callproc.c: Indentation fixup.
3537
3538 * sysdep.c (wait_for_termination_1): Make static.
3539 (wait_for_termination, interruptible_wait_for_termination):
3540 Move after wait_for_termination_1.
3541
3542 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543
3544 * sysdep.c (interruptible_wait_for_termination): New function
3545 which is like wait_for_termination, but allows keyboard
3546 interruptions.
3547
3548 * callproc.c (Fcall_process): Add (:file "file") as an option for
3549 the STDOUT buffer.
3550 (Fcall_process_region): Ditto.
3551
3552 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3553
3554 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3555 rather than `XVECTOR (FOO)->size'.
3556
3557 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3558 inttypes.h, as a gnulib replacement is used if it not available in
3559 system headers.
3560
3561 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3562
3563 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3564 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3565 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3566
3567 * coding.c (coding_alloc_by_realloc): Error out if destination
3568 will grow beyond MOST_POSITIVE_FIXNUM.
3569 (decode_coding_emacs_mule): Abort if there isn't enough place in
3570 charbuf for the composition carryover bytes. Reserve an extra
3571 space for up to 2 characters produced in a loop.
3572 (decode_coding_iso_2022): Abort if there isn't enough place in
3573 charbuf for the composition carryover bytes.
3574
3575 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3576
3577 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3578 aborting when %lld or %lll format is passed.
3579 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3580 %llo or %llx format is passed. (Bug#8545)
3581
3582 * window.c (window_scroll_line_based): Use a marker instead of
3583 simple variables to record original value of point. (Bug#7952)
3584
3585 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3586 produced by %s or %c overflows available buffer space. (Bug#8545)
3587
3588 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3589
3590 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3591 (SIZE_MAX): Move defn after all includes, as they might #define it.
3592
3593 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3594
3595 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3596
3597 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * keyboard.c (Qdelayed_warnings_hook): Define.
3600 (command_loop_1): Run `delayed-warnings-hook'
3601 if Vdelayed_warnings_list is non-nil.
3602 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3603 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3604
3605 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3606
3607 * doprnt.c (doprnt): Don't return value smaller than the buffer
3608 size if the message was truncated. (Bug#8545).
3609
3610 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3611
3612 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3613 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3614
3615 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3618
3619 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * makefile.w32-in: Update dependencies.
3622
3623 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3624
3625 Improve `doprnt' and its usage. (Bug#8545)
3626 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3627 `format_end'. Remove support for %l as a conversion specifier.
3628 Don't use xrealloc. Improve diagnostics when the %l size modifier
3629 is used. Update the commentary.
3630
3631 * eval.c (verror): Simplify calculation of size_t.
3632
3633 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3634 messages.
3635
3636 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3637
3638 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3639 change.
3640
3641 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3644 This makes this file independent of the recent pseudovector change.
3645
3646 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3649
3650 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3651 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3652 Remove unused local.
3653 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3654
3655 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3656 GCC 4.6.0 optimizes based on type-based alias analysis.
3657 For example, if b is of type struct buffer * and v of type struct
3658 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3659 != &v->size, and therefore "v->size = 1; b->size = 2; return
3660 v->size;" must therefore return 1. This assumption is incorrect
3661 for Emacs, since it type-puns struct Lisp_Vector * with many other
3662 types. To fix this problem, this patch adds a new type struct
3663 vectorlike_header that documents the constraints on layout of vectors
3664 and pseudovectors, and helps optimizing compilers not get fooled
3665 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3666 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3667 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3668 the size member.
3669 (XSETPVECTYPE): Rewrite in terms of new macro.
3670 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3671 This is a bit clearer, and further avoids the possibility of
3672 undesirable aliasing.
3673 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3674 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3675 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3676 since Lisp_Subr is a special case (no "next" field).
3677 (ASIZE): Now uses header.size rather than size.
3678 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3679 to avoid the hassle of writing XVECTOR (foo)->header.size.
3680 (struct vectorlike_header): New type.
3681 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3682 object, to help avoid aliasing.
3683 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3684 (SUBRP): Likewise, since Lisp_Subr is a special case.
3685 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3686 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3687 (struct Lisp_Hash_Table): Combine first two members into a single
3688 struct vectorlike_header member. All uses of "size" and "next" members
3689 changed to be "header.size" and "header.next".
3690 * buffer.h (struct buffer): Likewise.
3691 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3692 * frame.h (struct frame): Likewise.
3693 * process.h (struct Lisp_Process): Likewise.
3694 * termhooks.h (struct terminal): Likewise.
3695 * window.c (struct save_window_data, struct saved_window): Likewise.
3696 * window.h (struct window): Likewise.
3697 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3698 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3699 * buffer.c (init_buffer_once): Likewise.
3700 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3701 special case.
3702 * process.c (Fformat_network_address): Use local var for size,
3703 for brevity.
3704
3705 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3706
3707 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3708 * data.c (atof): Remove decl; no longer used or needed.
3709 (digit_to_number): Move to lread.c.
3710 (Fstring_to_number): Use new string_to_number function, to be
3711 consistent with how the Lisp reader treats infinities and NaNs.
3712 Do not assume that floating-point numbers represent EMACS_INT
3713 without losing information; this is not true on most 64-bit hosts.
3714 Avoid double-rounding errors, by insisting on integers when
3715 parsing non-base-10 numbers, as the documentation specifies.
3716 * lisp.h (string_to_number): New decl, replacing ...
3717 (isfloat_string): Remove.
3718 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3719 (read1): Do not accept +. and -. as integers; this
3720 appears to have been a coding error. Similarly, do not accept
3721 strings like +-1e0 as floating point numbers. Do not report
3722 overflow for integer overflows unless the base is not 10 which
3723 means we have no simple and reliable way to continue.
3724 Break out the floating-point parsing into a new
3725 function string_to_number, so that Fstring_to_number parses
3726 floating point numbers consistently with the Lisp reader.
3727 (digit_to_number): Move here from data.c. Make it static inline.
3728 (E_CHAR, EXP_INT): Remove, replacing with ...
3729 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3730 (string_to_number): New function, replacing isfloat_string.
3731 This function checks for valid syntax and produces the resulting
3732 Lisp float number too. Rework it so that string-to-number
3733 no longer mishandles examples like "1.0e+". Use strtoumax,
3734 so that overflow for non-base-10 numbers is reported only when
3735 there's no portable and simple way to convert to floating point.
3736
3737 * textprop.c (set_text_properties_1): Rewrite for clarity,
3738 and to avoid GCC warning about integer overflow.
3739
3740 * intervals.h (struct interval): Use EMACS_INT for members
3741 where EMACS_UINT might cause problems. See
3742 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3743 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3744 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3745 All uses changed.
3746 (offset_intervals): Tell GCC not to worry about length overflow
3747 when negating a negative length.
3748
3749 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3750 (overrun_check_free): Likewise.
3751
3752 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3753 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3754 word size.
3755
3756 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3757 (gnutls_make_error): Rename local to avoid shadowing.
3758 (gnutls_emacs_global_deinit): ifdef out; not used.
3759 (Fgnutls_boot): Use const for pointer to readonly storage.
3760 Comment out unused local. Fix pointer signedness problems.
3761
3762 * lread.c (openp): Don't stuff size_t into an 'int'.
3763 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3764 about possible signed overflow.
3765
3766 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3767 (GDK_KEY_g): Don't define if already defined.
3768 (xg_prepare_tooltip): Avoid pointer signedness problem.
3769 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3770
3771 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3772 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3773
3774 * xfns.c (Fx_window_property): Simplify a bit,
3775 to make a bit faster and to avoid GCC 4.6.0 warning.
3776 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3777
3778 * fns.c (internal_equal): Don't assume size_t fits in int.
3779
3780 * alloc.c (compact_small_strings): Tighten assertion a little.
3781
3782 Replace pEd with more-general pI, and fix some printf arg casts.
3783 * lisp.h (pI): New macro, generalizing old pEd macro to other
3784 conversion specifiers. For example, use "...%"pI"d..." rather
3785 than "...%"pEd"...".
3786 (pEd): Remove. All uses replaced with similar uses of pI.
3787 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3788 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3789 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3790 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3791 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3792 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3793 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3794 64-bit hosts.
3795 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3796 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3797 * print.c (safe_debug_print, print_object): Likewise.
3798 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3799 to int.
3800 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3801 avoiding the 0 flag, which is not portable.
3802 * process.c (Fmake_network_process): Use pI to avoid cast.
3803 * region-cache.c (pp_cache): Likewise.
3804 * xdisp.c (decode_mode_spec): Likewise.
3805 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3806 behavior on 64-bit hosts with printf arg.
3807 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3808 (x_stop_queuing_selection_requests): Likewise.
3809 (x_get_window_property): Don't truncate byte count to an 'int'
3810 when tracing.
3811
3812 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3813 here, since it parses constructs like leading '-' and spaces,
3814 which are not wanted; and it overflows with large numbers.
3815 Instead, simply match F[0-9]+, which is what is wanted anyway.
3816
3817 * alloc.c: Remove unportable assumptions about struct layout.
3818 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3819 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3820 (allocate_vectorlike, make_pure_vector): Use the new macros,
3821 plus offsetof, to remove unportable assumptions about struct layout.
3822 These assumptions hold on all porting targets that I know of, but
3823 they are not guaranteed, they're easy to remove, and removing them
3824 makes further changes easier.
3825
3826 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3827 This doesn't fix a bug but makes the code clearer.
3828 (string_overrun_cookie): Now const. Use initializers that
3829 don't formally overflow signed char, to avoid warnings.
3830 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3831 can cause Emacs to crash when string overrun checking is enabled.
3832 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3833 multiple of sizeof (EMACS_INT); it need not be, if
3834 alignof(EMACS_INT) < sizeof (EMACS_INT).
3835 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3836
3837 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3838
3839 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3840
3841 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3842
3843 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3844 supposed to be handshaking. (Bug#8556)
3845 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3846
3847 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3848
3849 * lisp.h (Qdebug): List symbol.
3850 * eval.c (Qdebug): Restore global linkage.
3851 * keyboard.c (debug-on-event): New variable.
3852 (handle_user_signal): Break into debugger when debug-on-event
3853 matches the current signal symbol.
3854
3855 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3856
3857 * alloc.c (check_sblock, check_string_bytes)
3858 (check_string_free_list): Convert to standard C.
3859
3860 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3861
3862 * w32.c (emacs_gnutls_push): Fix typo.
3863
3864 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3865
3866 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3867 "cast to pointer from integer of different size".
3868
3869 Improve doprnt and its use in verror. (Bug#8545)
3870 * doprnt.c (doprnt): Document the set of format control sequences
3871 supported by the function. Use SAFE_ALLOCA instead of always
3872 using `alloca'.
3873
3874 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3875 is one byte too soon. Don't use xrealloc; instead xfree and
3876 xmalloc anew.
3877
3878 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3879
3880 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3881 callbacks stage.
3882
3883 * gnutls.c: Renamed global_initialized to
3884 gnutls_global_initialized. Added internals for the
3885 :verify-hostname-error, :verify-error, and :verify-flags
3886 parameters of `gnutls-boot' and documented those parameters in the
3887 docstring. Start callback support.
3888 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3889 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3890 on error. Return error code.
3891 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3892 (emacs_gnutls_read): Likewise.
3893 (Fgnutls_boot): Return handshake error code.
3894 (emacs_gnutls_handle_error): New function.
3895 (wsaerror_to_errno): Likewise.
3896
3897 * w32.h (emacs_gnutls_pull): Add prototype.
3898 (emacs_gnutls_push): Likewise.
3899
3900 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3901 (emacs_gnutls_push): Likewise.
3902
3903 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3904
3905 * process.c (wait_reading_process_output): Check if GnuTLS
3906 buffered some data internally if no FDs are set for TLS
3907 connections.
3908
3909 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3910 (LIBS): Link to USER_LIBS.
3911 ($(BLD)/gnutls.$(0)): New target.
3912
3913 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3914
3915 * xdisp.c (handle_single_display_spec): Rename the
3916 display_replaced_before_p argument into display_replaced_p, to
3917 make it consistent with the commentary. Fix typos in the
3918 commentary.
3919
3920 * textprop.c (syms_of_textprop): Remove dead code.
3921 (copy_text_properties): Delete obsolete commentary about an
3922 interface that was deleted long ago. Fix typos in the description
3923 of arguments.
3924
3925 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3926 to changes in oldXMenu/XMenu.h from 2011-04-16.
3927 <menu_help_message, prev_menu_help_message>: Constify.
3928 (IT_menu_make_room): menu->help_text is now `const char **';
3929 adjust.
3930
3931 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3932 to changes in oldXMenu/XMenu.h from 2011-04-16.
3933 (struct XMenu): Declare `help_text' `const char **'.
3934
3935 * xfaces.c <Qunspecified>: Make extern again.
3936
3937 * syntax.c: Include sys/types.h before including regex.h, as
3938 required by Posix.
3939
3940 * doc.c (get_doc_string): Improve the format passed to `error'.
3941
3942 * doprnt.c (doprnt): Improve commentary.
3943
3944 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3945
3946 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3947 them with etags.
3948
3949 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3950 changes in globals.h immediately force recompilation.
3951 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3952 $(CURDIR)/s/ms-w32.h.
3953 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3954
3955 * character.c (Fchar_direction): Function deleted.
3956 (syms_of_character): Don't defsubr it.
3957 <char-direction-table>: Deleted.
3958
3959 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3960
3961 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3962 * doprnt.c: Include limits.h.
3963 (SIZE_MAX): New macro.
3964 (doprnt): Return a size_t value. 2nd arg is now size_t.
3965 Many local variables are now size_t instead of int or unsigned.
3966 Improve overflow protection. Support `l' modifier for integer
3967 conversions. Support %l conversion. Don't assume an EMACS_INT
3968 argument for integer conversions and for %c.
3969
3970 * lisp.h (doprnt): Restore prototype.
3971
3972 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3973 $(SRC)/character.h.
3974
3975 * Makefile.in (base_obj): Add back doprnt.o.
3976
3977 * deps.mk (doprnt.o): Add back prerequisites.
3978 (callint.o): Depend on character.h.
3979
3980 * eval.c (internal_lisp_condition_case): Include the handler
3981 representation in the error message.
3982 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3983 when breaking from the loop.
3984
3985 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3986
3987 * callint.c (Fcall_interactively): When displaying error message
3988 about invalid control letter, pass the character's codepoint, not
3989 a pointer to its multibyte form. Improve display of the character
3990 in octal and display also its hex code.
3991
3992 * character.c (char_string): Use %x to display the (unsigned)
3993 codepoint of an invalid character, to avoid displaying a bogus
3994 negative value.
3995
3996 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3997 `error', not SYMBOL_NAME itself.
3998
3999 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4000 character arguments to `error'.
4001
4002 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4003 to `error' in error message about FINAL_CHAR argument. Make sure
4004 FINAL_CHAR is a character, and use %c when it is passed as
4005 argument to `error'.
4006
4007 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4008
4009 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4010
4011 * w32.c: Include <time.h>.
4012 (sys_localtime): New function.
4013
4014 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4015
4016 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4017
4018 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4019
4020 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4021
4022 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4023 zombies (Bug#8467).
4024
4025 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4026
4027 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4028 gl_state.e_property when gl_state.object is Qt.
4029
4030 * insdel.c (make_gap_larger): Remove limitation of buffer size
4031 to <= INT_MAX.
4032
4033 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4034
4035 * xdisp.c (lookup_glyphless_char_display)
4036 (produce_glyphless_glyph): Handle cons cell entry in
4037 glyphless-char-display.
4038 (Vglyphless_char_display): Document it.
4039
4040 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4041 glyphless-char-display.
4042
4043 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4044
4045 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4046
4047 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4048
4049 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4050 definition for no-X builds.
4051
4052 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 Static checks with GCC 4.6.0 and non-default toolkits.
4055
4056 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4057
4058 * process.c (keyboard_bit_set): Define only if SIGIO.
4059 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4060 (send_process): Repair possible setjmp clobbering.
4061
4062 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4063
4064 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4065
4066 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4067
4068 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4069 Define only if needed.
4070
4071 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4072 by pacifying GCC about it. Maybe it's time to retire it?
4073 * xfaces.c (USG, __TIMEVAL__): Likewise.
4074
4075 * dispextern.h (struct redisplay_interface): Rename param
4076 to avoid shadowing.
4077 * termhooks.h (struct terminal): Likewise.
4078 * xterm.c (xembed_send_message): Likewise.
4079
4080 * insdel.c (make_gap_smaller): Define only if
4081 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4082
4083 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4084 it.
4085
4086 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4087 so that we aren't warned about unused symbols.
4088
4089 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4090
4091 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4092
4093 * xfns.c (x_real_positions): Mark locals as initialized.
4094
4095 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4096
4097 * xterm.c: Fix problems found by static analysis with other toolkits.
4098 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4099 (x_dispatch_event): Declare static if USE_GTK, and
4100 define if USE_GTK || USE_X_TOOLKIT.
4101 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4102 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4103 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4104 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4105
4106 * xmenu.c (menu_help_callback): Pointer type fixes.
4107 Use const pointers when pointing at readonly data. Avoid pointer
4108 signedness clashes.
4109 (FALSE): Remove unused macro.
4110 (update_frame_menubar): Remove unused decl.
4111
4112 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4113
4114 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4115 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4116 (single_menu_item): Rename local to avoid shadowing.
4117
4118 * keyboard.c (make_lispy_event): Remove unused local var.
4119
4120 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4121 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4122
4123 * bitmaps: Change bitmaps from unsigned char back to the X11
4124 compatible char. Avoid the old compiler warnings about
4125 out-of-range initializers by using, for example, '\xab' rather
4126 than 0xab.
4127
4128 * xgselect.c (xgselect_initialize): Check vs interface
4129 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4130
4131 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4132
4133 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4134 to read-only memory.
4135
4136 * fns.c (vector): Remove; this old hack is no longer needed.
4137
4138 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4139 Remove unused var.
4140 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4141
4142 * xrdb.c (x_load_resources): Omit unused local.
4143
4144 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4145 (x_window): Rename locals to avoid shadowing.
4146 (USG): Use the kludged USG macro, to pacify gcc.
4147
4148 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4149 (x_term_init): Remove local to avoid shadowing.
4150
4151 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4152
4153 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4154 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4155
4156 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4157
4158 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4159
4160 Fix regex.c, syntax.c and friends for buffers > 2GB.
4161 * syntax.h (struct gl_state_s): Declare character position members
4162 EMACS_INT.
4163
4164 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4165
4166 * textprop.c (verify_interval_modification, interval_of):
4167 Declare arguments EMACS_INT.
4168
4169 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4170 EMACS_INT.
4171
4172 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4173
4174 * indent.c (Fvertical_motion): Local variable it_start is now
4175 EMACS_INT.
4176
4177 * regex.c (re_match, re_match_2, re_match_2_internal)
4178 (bcmp_translate, regcomp, regexec, print_double_string)
4179 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4180 (re_compile_pattern, re_exec): Declare arguments and local
4181 variables `size_t' and `ssize_t' and return values `regoff_t', as
4182 appropriate.
4183 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4184 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4185 <compile_stack_type>: `size' and `avail' are now `size_t'.
4186
4187 * regex.h <regoff_t>: Use ssize_t, not int.
4188 (re_search, re_search_2, re_match, re_match_2): Arguments that
4189 specify buffer/string position and length are now ssize_t and
4190 size_t. Return type is regoff_t.
4191
4192 2011-04-16 Ben Key <bkey76@gmail.com>
4193
4194 * nsfont.m: Fixed bugs in ns_get_family and
4195 ns_descriptor_to_entity that were caused by using free to
4196 deallocate memory blocks that were allocated by xmalloc (via
4197 xstrdup). This caused Emacs to crash when compiled with
4198 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4199 --enable-checking=xmallocoverrun). xfree is now used to
4200 deallocate these memory blocks.
4201
4202 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4203
4204 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4205
4206 emacs_write: Accept and return EMACS_INT for sizes.
4207 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4208 et seq.
4209 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4210 Accept and return EMACS_INT.
4211 (emacs_gnutls_write): Return the number of bytes written on
4212 partial writes.
4213 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4214 (emacs_read, emacs_write): Remove check for negative size, as the
4215 Emacs source code has been audited now.
4216 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4217 (emacs_read, emacs_write): Use it.
4218 * process.c (send_process): Adjust to the new signatures of
4219 emacs_write and emacs_gnutls_write. Do not attempt to store
4220 a byte offset into an 'int'; it might overflow.
4221 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4222
4223 * sound.c: Don't assume sizes fit in 'int'.
4224 (struct sound_device.period_size, alsa_period_size):
4225 Return EMACS_INT, not int.
4226 (struct sound_device.write, vox_write, alsa_write):
4227 Accept EMACS_INT, not int.
4228 (wav_play, au_play): Use EMACS_INT to store sizes and to
4229 record read return values.
4230
4231 2011-04-15 Ben Key <bkey76@gmail.com>
4232
4233 * keyboard.c (Qundefined): Don't declare static since it is used
4234 in nsfns.m.
4235 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4236 static since they are used in nsfont.m.
4237
4238 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4239
4240 * process.c (Qprocessp): Don't declare static.
4241 * lisp.h (Qprocessp): Declare again.
4242
4243 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4244
4245 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4246
4247 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 Improve C-level modularity by making more things 'static'.
4250
4251 Don't publish debugger-only interfaces to other modules.
4252 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4253 (verify_bytepos, count_markers): Move decls to the only modules
4254 that need them.
4255 * region-cache.h (pp_cache): Likewise.
4256 * window.h (check_all_windows): Likewise.
4257 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4258
4259 * sysdep.c (croak): Now static, if
4260 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4261 * syssignal.h (croak): Declare only if not static.
4262
4263 * alloc.c (refill_memory_reserve): Now static if
4264 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4265 * lisp.h (refill_memory_reserve): Declare only if not static.
4266
4267 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4268 Define only if USE_LUCID.
4269
4270 * xrdb.c (x_customization_string, x_rm_string): Now static.
4271
4272 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4273 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4274
4275 * xdisp.c (draw_row_with_mouse_face): Now static.
4276 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4277
4278 * window.h (check_all_windows): Mark externally visible.
4279
4280 * window.c (window_deletion_count): Now static.
4281
4282 * undo.c: Make symbols static if they're not exported.
4283 (last_undo_buffer, last_boundary_position, pending_boundary):
4284 Now static.
4285
4286 * textprop.c (interval_insert_behind_hooks): Now static.
4287 (interval_insert_in_front_hooks): Likewise.
4288
4289 * term.c: Make symbols static if they're not exported.
4290 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4291 (max_frame_lines, tty_set_terminal_modes):
4292 (tty_reset_terminal_modes, tty_turn_off_highlight):
4293 (get_tty_terminal): Now static.
4294 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4295 * termhooks.h (term_mouse_moveto): Do not declare if
4296 HAVE_WINDOW_SYSTEM.
4297 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4298 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4299
4300 * sysdep.c: Make symbols static if they're not exported.
4301 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4302 Now static.
4303 (sigprocmask_set, full_mask): Remove; unused.
4304 (wait_debugging): Mark as visible.
4305 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4306 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4307
4308 * syntax.c (syntax_temp): Define only if !__GNUC__.
4309
4310 * sound.c (current_sound_device, current_sound): Now static.
4311
4312 * search.c (searchbufs, searchbuf_head): Now static.
4313
4314 * scroll.c (scroll_cost): Remove; unused.
4315 * dispextern.h (scroll_cost): Remove decl.
4316
4317 * region-cache.h (pp_cache): Mark as externally visible.
4318
4319 * process.c: Make symbols static if they're not exported.
4320 (process_tick, update_tick, create_process, chan_process):
4321 (Vprocess_alist, proc_buffered_char, datagram_access):
4322 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4323 (deactivate_process): Mark defn as static, as well as decl.
4324 * lisp.h (create_process): Remove decl.
4325 * process.h (chan_process, Vprocess_alist): Remove decls.
4326
4327 * print.c: Make symbols static if they're not exported.
4328 (print_depth, new_backquote_output, being_printed, print_buffer):
4329 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4330 (print_interval, print_number_index, initial_stderr_stream):
4331 Now static.
4332 * lisp.h (Fprinc): Remove decl.
4333 (debug_output_compilation_hack): Mark as externally visible.
4334
4335 * sysdep.c (croak): Move decl from here to syssignal.h.
4336 * syssignal.h (croak): Put it here, so the API can be checked when
4337 'croak' is called from dissociate_if_controlling_tty.
4338
4339 * minibuf.c: Make symbols static if they're not exported.
4340 (minibuf_save_list, choose_minibuf_frame): Now static.
4341 * lisp.h (choose_minibuf_frame): Remove decl.
4342
4343 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4344
4345 * lread.c: Make symbols static if they're not exported.
4346 (read_objects, initial_obarray, oblookup_last_bucket_number):
4347 Now static.
4348 (make_symbol): Remove; unused.
4349 * lisp.h (initial_obarray, make_symbol): Remove decls.
4350
4351 * keyboard.c: Make symbols static if they're not exported.
4352 (single_kboard, recent_keys_index, total_keys, recent_keys):
4353 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4354 (this_single_command_key_start, echoing, last_auto_save):
4355 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4356 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4357 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4358 (Vlispy_mouse_stem, double_click_count):
4359 Now static.
4360 (force_auto_save_soon): Define only if SIGDANGER.
4361 (ignore_mouse_drag_p): Now static if
4362 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4363 (print_help): Remove; unused.
4364 (stop_character, last_timer_event): Mark as externally visible.
4365 * keyboard.h (ignore_mouse_drag_p): Declare only if
4366 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4367 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4368 * lisp.h (echoing): Remove decl.
4369 (force_auto_save_soon): Declare only if SIGDANGER.
4370 * xdisp.c (redisplay_window): Simplify code, to make it more
4371 obvious that ignore_mouse_drag_p is not accessed if !defined
4372 USE_GTK && !defined HAVE_NS.
4373
4374 * intervals.c: Make symbols static if they're not exported.
4375 (merge_properties_sticky, merge_interval_right, delete_interval):
4376 Now static.
4377 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4378
4379 * insdel.c: Make symbols static if they're not exported.
4380 However, leave prepare_to_modify_buffer alone. It's never
4381 called from outside this function, but that appears to be a bug.
4382 (combine_after_change_list, combine_after_change_buffer):
4383 (adjust_after_replace, signal_before_change): Now static.
4384 (adjust_after_replace_noundo): Remove; unused.
4385 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4386 (signal_before_change): Remove decls.
4387
4388 * indent.c (val_compute_motion, val_vmotion): Now static.
4389
4390 * image.c: Make symbols static if they're not exported.
4391 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4392 if USE_GTK.
4393 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4394 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4395
4396 * fringe.c (standard_bitmaps): Now static.
4397 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4398
4399 * frame.c: Make symbols static if they're not exported.
4400 (x_report_frame_params, make_terminal_frame): Now static.
4401 (get_frame_param): Now static, unless HAVE_NS.
4402 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4403 (x_get_resource_string): Remove; not used.
4404 * frame.h (make_terminal_frame, x_report_frame_params):
4405 (x_get_resource_string); Remove decls.
4406 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4407 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4408
4409 * font.c, fontset.c: Make symbols static if they're not exported.
4410 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4411 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4412 * font.c (font_close_object): Now static.
4413 * font.h (font_close_object): Remove.
4414 * fontset.c (FONTSET_OBJLIST): Remove.
4415 (free_realized_fontset) #if-0 the body, which does nothing.
4416 (face_suitable_for_char_p): #if-0, as it's never called.
4417 * fontset.h (face_suitable_for_char_p): Remove decl.
4418 * xfaces.c (face_at_string_position):
4419 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4420 since 0 is always ASCII.
4421
4422 * fns.c (weak_hash_tables): Now static.
4423
4424 * fileio.c: Make symbols static if they're not exported.
4425 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4426 (Vwrite_region_annotation_buffers): Now static.
4427
4428 * eval.c: Make symbols static if they're not exported.
4429 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4430 * lisp.h (backtrace_list): Remove decl.
4431
4432 * emacs.c: Make symbols static if they're not exported.
4433 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4434 (fatal_error_code, fatal_error_signal_hook, standard_args):
4435 Now static.
4436 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4437 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4438 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4439 * lisp.h (fatal_error_signal_hook): Remove decl.
4440 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4441
4442 * editfns.c: Move a (normally-unused) function to its only use.
4443 * editfns.c, lisp.h (get_operating_system_release): Remove.
4444 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4445 worth the hassle of breaking this out.
4446
4447 * xterm.c: Make symbols static if they're not exported.
4448 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4449 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4450 (x_destroy_window, x_delete_display):
4451 Now static.
4452 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4453 (x_mouse_leave): Remove; unused.
4454 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4455 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4456 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4457 Remove decls.
4458 (x_mouse_leave): Declare only if WINDOWSNT.
4459 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4460 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4461 USE_X_TOOLKIT.
4462
4463 * ftxfont.c: Make symbols static if they're not exported.
4464 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4465 HAVE_FREETYPE.
4466 * font.h (ftxfont_driver): Likewise.
4467
4468 * xfns.c: Make symbols static if they're not exported.
4469 (x_last_font_name, x_display_info_for_name):
4470 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4471 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4472 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4473 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4474 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4475 (last_show_tip_args): Now static.
4476 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4477 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4478 (x_screen_planes): Remove; unused.
4479 * dispextern.h (x_screen_planes): Remove decl.
4480
4481 * dispnew.c: Make symbols static if they're not exported.
4482 * dispextern.h (redraw_garbaged_frames, scrolling):
4483 (increment_row_positions): Remove.
4484 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4485 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4486 Now static.
4487 (redraw_garbaged_frames): Remove; unused.
4488
4489 * xfaces.c: Make symbols static if they're not exported.
4490 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4491 Remove decls.
4492 * xterm.h (defined_color): Remove decls.
4493 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4494 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4495 (menu_face_changed_default, defined_color, free_realized_face):
4496 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4497 (ascii_face_of_lisp_face): Remove; unused.
4498
4499 * xdisp.c: Make symbols static if they're not exported.
4500 * dispextern.h (scratch_glyph_row, window_box_edges):
4501 (glyph_to_pixel_coords, set_cursor_from_row):
4502 (get_next_display_element, set_iterator_to_next):
4503 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4504 (show_mouse_face): Remove decls
4505 * frame.h (message_buf_print): Likewise.
4506 * lisp.h (pop_message, set_message, check_point_in_composition):
4507 Likewise.
4508 * xterm.h (set_vertical_scroll_bar): Likewise.
4509 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4510 (message_buf_print, scratch_glyph_row, displayed_buffer):
4511 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4512 (get_next_display_element, show_mouse_face, window_box_edges):
4513 (frame_to_window_pixel_xy, check_point_in_composition):
4514 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4515 (glyph_to_pixel_coords): Remove; unused.
4516
4517 * dired.c (file_name_completion): Now static.
4518
4519 * dbusbind.c (xd_in_read_queued_messages): Now static.
4520
4521 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4522 * data.c (circular_list_error): Remove.
4523
4524 * commands.h (last_point_position, last_point_position_buffer):
4525 (last_point_position_window): Remove decls.
4526 * keyboard.c: Make these variables static.
4527
4528 * coding.h (coding, code_convert_region, encode_coding_gap):
4529 Remove decls.
4530 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4531 (iso_code_class, detect_coding, code_convert_region): Now static.
4532 (encode_coding_gap): Remove; unused.
4533
4534 * chartab.c (chartab_chars, chartab_bits): Now static.
4535
4536 * charset.h (charset_iso_8859_1): Remove decl.
4537 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4538 Now static.
4539
4540 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4541 * ccl.c (Vccl_program_table): Now static.
4542 (check_ccl_update): Remove; unused.
4543
4544 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4545 * category.h: ... from here.
4546 * category.c (check_category_table, set_category_set): Now static.
4547
4548 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4549 * lisp.h: Remove these decls.
4550
4551 * buffer.c (buffer_count): Remove unused var.
4552
4553 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4554 so that it's not optimized away.
4555 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4556 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4557 exported only to the debugger.
4558
4559 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4560 * atimer.h (run_all_atimers): Remove; not exported.
4561
4562 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4563 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4564 was inaccessible from Lisp.
4565 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4566 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4567
4568 alloc.c: Import and export fewer symbols, and remove unused items.
4569 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4570 is defined.
4571 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4572 it's not optimized away by whole-program optimization.
4573 (message_enable_multibyte, free_misc): Remove.
4574 (catchlist, handlerlist, mark_backtrace):
4575 Declare only if BYTE_MARK_STACK.
4576 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4577 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4578 (message_enable_multibyte): Remove decl.
4579 (free_misc, interval_free_list, float_block, float_block_index):
4580 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4581 (cons_free_list, last_marked_index):
4582 Now static.
4583 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4584 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4585 (mark_backtrace): Define only if BYTE_MARK_STACK.
4586 * xdisp.c (message_enable_multibyte): Now static.
4587
4588 Declare Lisp_Object Q* variables to be 'static' if not exported.
4589 This makes it easier for human readers (and static analyzers)
4590 to see whether these variables are used from other modules.
4591 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4592 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4593 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4594 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4595 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4596 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4597 * xmenu.c, xselect.c:
4598 Declare Q* vars static if they are not used in other modules.
4599 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4600 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4601 Remove decls of unexported vars.
4602 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4603
4604 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4605
4606 Make Emacs functions such as Fatom 'static' by default.
4607 This makes it easier for human readers (and static analyzers)
4608 to see whether these functions can be called from other modules.
4609 DEFUN now defines a static function. To make the function external
4610 so that it can be used in other C modules, use the new macro DEFUE.
4611 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4612 (Finit_image_library):
4613 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4614 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4615 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4616 Remove decls, since these functions are now static.
4617 (Funintern, Fget_internal_run_time): New decls, since these functions
4618 were already external.
4619
4620 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4621 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4622 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4623 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4624 * keyboard.c, keymap.c, lread.c:
4625 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4626 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4627 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4628 Mark functions with DEFUE instead of DEFUN,
4629 if they are used in other modules.
4630 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4631 decls for now-static functions.
4632 * buffer.h (Fdelete_overlay): Remove decl.
4633 * callproc.c (Fgetenv_internal): Mark as internal.
4634 * composite.c (Fremove_list_of_text_properties): Remove decl.
4635 (Fcomposition_get_gstring): New forward static decl.
4636 * composite.h (Fcomposite_get_gstring): Remove decl.
4637 * dired.c (Ffile_attributes): New forward static decl.
4638 * doc.c (Fdocumntation_property): New forward static decl.
4639 * eval.c (Ffetch_bytecode): New forward static decl.
4640 (Funintern): Remove extern decl; now in .h file where it belongs.
4641 * fileio.c (Fmake_symbolic_link): New forward static decl.
4642 * image.c (Finit_image_library): New forward static decl.
4643 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4644 * intervals.h (Fprevious_property_change):
4645 (Fremove_list_of_text_properties): Remove decls.
4646 * keyboard.c (Fthis_command_keys): Remove decl.
4647 (Fcommand_execute): New forward static decl.
4648 * keymap.c (Flookup_key): New forward static decl.
4649 (Fcopy_keymap): Now static.
4650 * keymap.h (Flookup_key): Remove decl.
4651 * process.c (Fget_process): New forward static decl.
4652 (Fprocess_datagram_address): Mark as internal.
4653 * syntax.c (Fsyntax_table_p): New forward static decl.
4654 (skip_chars): Remove duplicate decl.
4655 * textprop.c (Fprevious_property_change): New forward static decl.
4656 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4657 Now internal.
4658 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4659 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4660
4661 * editfns.c (Fformat): Remove unreachable code.
4662
4663 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4664
4665 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4666 change. (Bug#8496)
4667
4668 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4669
4670 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4671 when at ZV. (Bug#8487)
4672
4673 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4674
4675 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4676 (Bug#8437)
4677 * keyboard.c (parse_tool_bar_item): Likewise.
4678 * sound.c (sound_cleanup, alsa_close): Likewise.
4679 * termcap.c (tgetent): Likewise.
4680 * xfns.c (x_default_font_parameter): Likewise.
4681 * xsettings.c (read_and_apply_settings): Likewise.
4682
4683 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4684 (overrun_check_free): Protoize.
4685
4686 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4687
4688 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4689 since callers should never pass a negative size.
4690 Change the signature to match that of plain 'read' and 'write'; see
4691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4692 * lisp.h: Update prototypes of emacs_write and emacs_read.
4693
4694 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4695
4696 * xdisp.c (redisplay_window): Don't try to determine the character
4697 position of the scroll margin if the window start point w->startp
4698 is outside the buffer's accessible region. (Bug#8468)
4699
4700 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4701
4702 Fix write-region and its subroutines for buffers > 2GB.
4703 * fileio.c (a_write, e_write): Modify declaration of arguments and
4704 local variables to support buffers larger than 2GB.
4705 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4706
4707 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4708 argument, local variables, and return value.
4709
4710 * lisp.h: Update prototypes of emacs_write and emacs_read.
4711
4712 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4713
4714 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4715
4716 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4717
4718 Fix more problems found by GCC 4.6.0's static checks.
4719
4720 * xdisp.c (vmessage): Use a better test for character truncation.
4721
4722 * charset.c (load_charset_map): <, not <=, for optimization,
4723 and to avoid potential problems with integer overflow.
4724 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4725 * casetab.c (set_identity, shuffle): Likewise.
4726 * editfns.c (Fformat): Likewise.
4727 * syntax.c (skip_chars): Likewise.
4728
4729 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4730 This also lets GCC 4.6.0 generate slightly better loop code.
4731
4732 * callint.c (Fcall_interactively): <, not <=, for optimization.
4733 (Fcall_interactively): Count the number of arguments produced,
4734 not the number of arguments given. This is simpler and lets GCC
4735 4.6.0 generate slightly better code.
4736
4737 * ftfont.c: Distingish more carefully between FcChar8 and char.
4738 The previous code passed unsigned char * to a functions like
4739 strlen and xstrcasecmp that expect char *, which does not
4740 conform to the C standard.
4741 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4742 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4743 char * when the C standard requires it.
4744
4745 * keyboard.c (read_char): Remove unused var.
4746
4747 * eval.c: Port to Windows vsnprintf (Bug#8435).
4748 Include <limits.h>.
4749 (SIZE_MAX): Define if the headers do not.
4750 (verror): Do not give up if vsnprintf returns a negative count.
4751 Instead, grow the buffer. This ports to Windows vsnprintf, which
4752 does not conform to C99. Problem reported by Eli Zaretskii.
4753 Also, simplify the allocation scheme, by avoiding the need for
4754 calling realloc, and removing the ALLOCATED variable.
4755
4756 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4757
4758 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4759 But keep the doprint source code for now, as we might revamp it
4760 and use it again (Bug#8435).
4761 * lisp.h (doprnt): Remove.
4762 * Makefile.in (base_obj): Remove doprnt.o.
4763 * deps.mk (doprnt.o): Remove.
4764
4765 error: Print 32- and 64-bit integers portably (Bug#8435).
4766 Without this change, on typical 64-bit hosts error ("...%d...", N)
4767 was used to print both 32- and 64-bit integers N, which relied on
4768 undefined behavior.
4769 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4770 New macro.
4771 * lisp.h (error, verror): Mark as printf-like functions.
4772 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4773 Report overflow in size calculations when allocating printf buffer.
4774 Do not truncate output string at its first null byte.
4775 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4776 Truncate the output at a character boundary, since vsnprintf does not
4777 do that.
4778 * charset.c (check_iso_charset_parameter): Convert internal
4779 character to string before calling 'error', since %c now has the
4780 printf meaning.
4781 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4782 overflow when computing char to be passed to 'error'. Do not
4783 pass Lisp_Object to 'error'; pass the integer instead.
4784 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4785 formatted with plain %d.
4786
4787 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4788
4789 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4790
4791 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4792
4793 * xterm.c (x_catch_errors): Remove duplicate declaration.
4794
4795 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4796
4797 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4798
4799 2011-04-10 Jim Meyering <meyering@redhat.com>
4800
4801 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4802 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4803 return ssize_t not "int", and use size_t as the buffer length.
4804 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4805 * gnutls.h: Update declarations.
4806 * process.c (read_process_output): Use ssize_t, to match.
4807 (send_process): Likewise.
4808
4809 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4810
4811 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4812
4813 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4816 Use unsigned char, to match FcChar8 type definition.
4817
4818 * xterm.c (handle_one_xevent):
4819 * xmenu.c (create_and_show_popup_menu):
4820 * xselect.c (x_decline_selection_request)
4821 (x_reply_selection_request): Avoid type-punned deref of X events.
4822
4823 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4824
4825 Fix some uses of `int' instead of EMACS_INT.
4826 * search.c (string_match_1, fast_string_match)
4827 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4828 (scan_buffer, find_next_newline_no_quit)
4829 (find_before_next_newline, search_command, Freplace_match)
4830 (Fmatch_data): Make some `int' variables be EMACS_INT.
4831
4832 * xdisp.c (display_count_lines): 3rd argument and return value now
4833 EMACS_INT. All callers changed.
4834 (pint2hrstr): Last argument is now EMACS_INT.
4835
4836 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4837 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4838 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4839 (decode_coding_utf_16, decode_coding_emacs_mule)
4840 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4841 (decode_coding_ccl, decode_coding_charset)
4842 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4843 (decode_coding_iso_2022, decode_coding_emacs_mule)
4844 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4845 <char_offset, last_offset>: Declare EMACS_INT.
4846 (encode_coding_utf_8, encode_coding_utf_16)
4847 (encode_coding_emacs_mule, encode_invocation_designation)
4848 (encode_designation_at_bol, encode_coding_iso_2022)
4849 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4850 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4851 Declare EMACS_INT.
4852 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4853 (encode_invocation_designation): Last argument P_NCHARS is now
4854 EMACS_INT.
4855 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4856 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4857
4858 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4859 All users changed.
4860
4861 * ccl.c (Fccl_execute_on_string): Declare some variables
4862 EMACS_INT.
4863
4864 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4865
4866 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4867
4868 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4869
4870 * process.c (Fformat_network_address): Doc fix.
4871
4872 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4873
4874 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4875
4876 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4877
4878 * keyboard.c (read_char): Call Lisp function help-form-show,
4879 instead of using internal_with_output_to_temp_buffer.
4880 (Qhelp_form_show): New var.
4881 (syms_of_keyboard): Use DEFSYM macro.
4882
4883 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4884
4885 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4886
4887 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4888
4889 * process.c (Flist_processes): Remove to Lisp.
4890 (list_processes_1): Delete.
4891
4892 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4893
4894 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4895
4896 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4897
4898 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 Fix more problems found by GCC 4.6.0's static checks.
4901
4902 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4903
4904 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4905
4906 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4907
4908 * xdisp.c (vmessage): Mark as a printf-like function.
4909
4910 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4911
4912 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4913
4914 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4915 printf-like functions.
4916 (tiff_load): Add casts to remove these marks before passing them
4917 to system-supplied API.
4918
4919 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4920
4921 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4922 This avoids several warnings with gcc -Wstrict-overflow.
4923 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4924 directly, rather than having caller test rule sign. This avoids
4925 some unnecessary tests.
4926 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4927 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4928 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4929
4930 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4931 (xfont_open): Avoid unnecessary tests.
4932
4933 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4934
4935 * composite.h, composite.c (composition_gstring_put_cache):
4936 Use EMACS_INT, not int, for length.
4937
4938 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4939 breaking out part of COMPOSITION_DECODE_RULE.
4940 (COMPOSITION_DECODE_RULE): Use it.
4941 * composite.c (get_composition_id): Remove unused local vars,
4942 by using the new macro.
4943
4944 * textprop.c (set_text_properties_1): Change while to do-while,
4945 since the condition is always true at first.
4946
4947 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4948 (interval_deletion_adjustment): Return unsigned value.
4949 All uses changed.
4950
4951 * process.c (list_processes_1, create_pty, read_process_output):
4952 (exec_sentinel): Remove vars that were set but not used.
4953 (create_pty): Remove unnecessary "volatile"s.
4954 (Fnetwork_interface_info): Avoid possibility of int overflow.
4955 (read_process_output): Do adaptive read buffering even if carryover.
4956 (read_process_output): Simplify nbytes computation if buffered.
4957
4958 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4959
4960 * syntax.c (scan_words): Remove var that was set but not used.
4961 (update_syntax_table): Use unsigned instead of int.
4962
4963 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4964 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4965 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4966
4967 * print.c (print_error_message): Avoid int overflow.
4968
4969 * font.c (font_list_entities): Redo for clarity,
4970 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4971
4972 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4973 (font_score): Avoid potential overflow in diff calculation.
4974
4975 * fns.c (substring_both): Remove var that is set but not used.
4976 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4977
4978 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4979
4980 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4981 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4982 can always succeed if overflow has undefined behavior.
4983
4984 * search.c (boyer_moore, wordify): Remove vars set but not used.
4985 (wordify): Omit three unnecessary tests.
4986
4987 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4988 All callers changed. This avoids the need for an unused var.
4989
4990 * casefiddle.c (casify_region): Remove var that is set but not used.
4991
4992 * dired.c (file_name_completion): Remove var that is set but not used.
4993
4994 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4995
4996 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4997 (Finsert_file_contents): Remove unnecessary code checking fd.
4998
4999 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5000 Check for integer overflow on size calculations.
5001
5002 * buffer.c (Fprevious_overlay_change): Remove var that is set
5003 but not used.
5004
5005 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5006 Remove vars that are set but not used.
5007 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5008 (timer_check_2): Mark vars as initialized.
5009
5010 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5011
5012 * image.c (lookup_image): Remove var that is set but not used.
5013 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5014
5015 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5016 that are set but not used.
5017
5018 * xfns.c (make_invisible_cursor): Don't return garbage
5019 if XCreateBitmapFromData fails (Bug#8410).
5020
5021 * xselect.c (x_get_local_selection, x_handle_property_notify):
5022 Remove vars that are set but not used.
5023
5024 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5025 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5026
5027 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5028 Remove var that is set but not used.
5029 (scroll_bar_windows_size): Now size_t, not int.
5030 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5031 Check for overflow.
5032
5033 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5034 (map_tty_color) [!defined MSDOS]: Likewise.
5035
5036 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5037
5038 * coding.c: Remove vars that are set but not used.
5039 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5040 All callers changed.
5041 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5042 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5043 (decode_coding_charset): Remove vars that are set but not used.
5044
5045 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5046 that is set but not used.
5047
5048 * print.c (print_object): Remove var that is set but not used.
5049
5050 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5051 The gnulib version avoids calling malloc in the usual case,
5052 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5053 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5054 * filelock.c (current_lock_owner): Likewise.
5055 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5056 * sysdep.c: Include allocator.h, careadlinkat.h.
5057 (emacs_no_realloc_allocator): New static constant.
5058 (emacs_readlink): New function.
5059 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5060 ../lib/careadlinkat.h.
5061
5062 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5063
5064 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5065 first non-nil return value).
5066
5067 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5068
5069 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5070 if not defined (Bug#8403).
5071
5072 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * xdisp.c (display_count_lines): Remove parameter `start',
5075 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5076 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5077 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5078 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5079 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5080 and thereabouts. All callers changed.
5081 (get_per_char_metric): Remove parameter `f', unused since
5082 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5083
5084 2011-04-02 Jim Meyering <meyering@redhat.com>
5085
5086 do not dereference NULL upon failed strdup
5087 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5088 (ns_get_family): Likewise.
5089
5090 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5091
5092 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5093
5094 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5095
5096 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5097 later (Bug#8403).
5098
5099 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5100
5101 Add lexical binding.
5102
5103 * window.c (Ftemp_output_buffer_show): New fun.
5104 (Fsave_window_excursion):
5105 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5106
5107 * lread.c (lisp_file_lexically_bound_p): New function.
5108 (Fload): Bind Qlexical_binding.
5109 (readevalloop): Remove `evalfun' arg.
5110 Bind Qinternal_interpreter_environment.
5111 (Feval_buffer): Bind Qlexical_binding.
5112 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5113 Mark as dynamic.
5114 (syms_of_lread): Declare `lexical-binding'.
5115
5116 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5117
5118 * keyboard.c (eval_dyn): New fun.
5119 (menu_item_eval_property): Use it.
5120
5121 * image.c (parse_image_spec): Use Ffunctionp.
5122
5123 * fns.c (concat, mapcar1): Accept byte-code-functions.
5124
5125 * eval.c (Fsetq): Handle lexical vars.
5126 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5127 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5128 (FletX, Flet): Obey lexical binding.
5129 (Fcommandp): Handle closures.
5130 (Feval): New `lexical' arg.
5131 (eval_sub): New function extracted from Feval. Use it almost
5132 everywhere where Feval was used. Look up vars in lexical env.
5133 Handle closures.
5134 (Ffunctionp): Move from subr.el.
5135 (Ffuncall): Handle closures.
5136 (apply_lambda): Remove `eval_flags'.
5137 (funcall_lambda): Handle closures and new byte-code-functions.
5138 (Fspecial_variable_p): New function.
5139 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5140 but without exporting it to Lisp.
5141
5142 * doc.c (Fdocumentation, store_function_docstring):
5143 * data.c (Finteractive_form): Handle closures.
5144
5145 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5146 interactive spec.
5147
5148 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5149 New byte-codes.
5150 (exec_byte_code): New function extracted from Fbyte_code to handle new
5151 calling convention for byte-code-functions. Add new byte-codes.
5152
5153 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5154
5155 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5156
5157 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5158
5159 * xdisp.c (redisplay_internal): Fix prototype.
5160
5161 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5162
5163 * xdisp.c (SCROLL_LIMIT): New macro.
5164 (try_scrolling): Use it when setting scroll_limit.
5165 Limit scrolling to 100 screen lines.
5166 (redisplay_window): Even when falling back on "recentering",
5167 position point in the window according to scroll-conservatively,
5168 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5169
5170 (try_scrolling): When point is above the window, allow searching
5171 as far as scroll_max, or one screenful, to compute vertical
5172 distance from PT to the scroll margin position. This prevents
5173 try_scrolling from unnecessarily failing when
5174 scroll-conservatively is set to a value slightly larger than the
5175 window height. Clean up the case of PT below the margin at bottom
5176 of window: scroll_max can no longer be INT_MAX. When aggressive
5177 scrolling is in use, don't let point enter the opposite scroll
5178 margin as result of the scroll.
5179 (syms_of_xdisp) <scroll-conservatively>: Document the
5180 threshold of 100 lines for never-recentering scrolling.
5181
5182 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * dispextern.h (move_it_by_lines):
5185 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5186 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5187 (message_log_check_duplicate): Remove parameters `prev_bol' and
5188 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5189 (redisplay_internal): Remove parameter `preserve_echo_area',
5190 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5191
5192 * indent.c (Fvertical_motion):
5193 * window.c (window_scroll_pixel_based, Frecenter):
5194 Don't pass `need_y_p' to `move_it_by_lines'.
5195
5196 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5197
5198 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5199 steal a few bits to be more compact.
5200 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5201 Remove unneeded casts.
5202
5203 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5204
5205 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5206
5207 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5208 binding" message (bug#7967).
5209
5210 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5211
5212 Fix more problems found by GCC 4.6.0's static checks.
5213
5214 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5215 Remove unused local var.
5216
5217 * editfns.c (Fmessage_box): Remove unused local var.
5218
5219 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5220 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5221 Omit unused local vars.
5222 * window.c (shrink_windows): Omit unused local var.
5223 * menu.c (digest_single_submenu): Omit unused local var.
5224 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5225 Omit unused local var.
5226
5227 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5228 Don't assume string length fits in int.
5229 (keyremap_step, read_key_sequence): Use size_t for sizes.
5230 (read_key_sequence): Don't check last_real_key_start redundantly.
5231
5232 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5233 instead of alloca (Bug#8344).
5234
5235 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5236 (Fbacktrace_frame): Don't assume nframes fits in int.
5237
5238 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5239
5240 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5241 concerns.
5242
5243 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5244
5245 * cm.c (calccost): Turn while-do into do-while, for clarity.
5246
5247 * keyboard.c (syms_of_keyboard): Use the same style as later
5248 in this function when indexing through an array. This also
5249 works around GCC bug 48267.
5250
5251 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5252
5253 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5254
5255 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5256 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5257
5258 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5259 This avoids undefined behavior on integer overflow, and is a bit
5260 more convenient anyway since it is compared to a size_t variable.
5261
5262 Variadic C functions now count arguments with size_t, not int.
5263 This avoids an unnecessary limitation on 64-bit machines, which
5264 caused (substring ...) to crash on large vectors (Bug#8344).
5265 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5266 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5267 All variadic functions and their callers changed accordingly.
5268 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5269 * data.c (arith_driver, float_arith_driver): Likewise.
5270 * editfns.c (general_insert_function): Likewise.
5271 * eval.c (struct backtrace.nargs, interactive_p)
5272 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5273 (funcall_lambda, mark_backtrace): Likewise.
5274 * fns.c (concat): Likewise.
5275 * frame.c (x_set_frame_parameters): Likewise.
5276 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5277 0 if not found, not -1. All callers changed.
5278
5279 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5280 (stack_copy_size): Now size_t, not int.
5281 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5282
5283 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5284
5285 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5286 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5287 All callers changed.
5288
5289 * lisp.h (multibyte_char_to_unibyte):
5290 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5291 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5292 * character.h (CHAR_TO_BYTE8):
5293 * cmds.c (internal_self_insert):
5294 * editfns.c (general_insert_function):
5295 * keymap.c (push_key_description):
5296 * search.c (Freplace_match):
5297 * xdisp.c (message_dolog, set_message_1): All callers changed.
5298
5299 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5300
5301 * keyboard.c (safe_run_hook_funcall): New function.
5302 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5303 don't set the hook to nil, but remove the offending function instead.
5304 (Qcommand_hook_internal): Remove, unused.
5305 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5306 Vcommand_hook_internal.
5307
5308 * eval.c (enum run_hooks_condition): Remove.
5309 (funcall_nil, funcall_not): New functions.
5310 (run_hook_with_args): Call each function through a `funcall' argument.
5311 Remove `cond' argument, now redundant.
5312 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5313 (Frun_hook_with_args_until_failure): Adjust accordingly.
5314 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5315
5316 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * dispextern.h (string_buffer_position): Remove declaration.
5319
5320 * print.c (strout): Remove parameter `multibyte', unused since
5321 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5322
5323 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5324 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5325 All callers changed.
5326
5327 * w32.c (_wsa_errlist): Use braces for struct initializers.
5328
5329 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5330 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5331 All callers changed.
5332 (string_buffer_position): Likewise. Also, make static (it's never
5333 used outside xdisp.c).
5334 (cursor_row_p): Remove parameter `w', unused since
5335 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5336 (decode_mode_spec): Remove parameter `precision', introduced during
5337 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5338 All callers changed.
5339
5340 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5341
5342 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5343
5344 2011-03-27 Anders Lindgren <andlind@gmail.com>
5345
5346 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5347 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5348 (ns_update_auto_hide_menu_bar): New functions.
5349 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5350 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5351 ns_constrain_all_frames.
5352 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5353 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5354
5355 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5356
5357 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5358
5359 2011-03-27 Glenn Morris <rgm@gnu.org>
5360
5361 * syssignal.h: Replace RETSIGTYPE with void.
5362 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5363 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5364 Replace SIGTYPE with void everywhere.
5365 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5366 * s/template.h (SIGTYPE): Remove commented out definition.
5367
5368 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5369
5370 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5371 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5372
5373 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * w32.c (read_unc_volume): Use parameter `henum', instead of
5376 global variable `wget_enum_handle'.
5377
5378 * keymap.c (describe_vector): Remove parameters `indices' and
5379 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5380 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5381
5382 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5383
5384 * keyboard.c (timer_check): Remove parameter `do_it_now',
5385 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5386 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5387 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5388
5389 * keyboard.c (read_char):
5390 * w32menu.c (w32_menu_display_help):
5391 * xmenu.c (show_help_event, menu_help_callback):
5392 Adjust calls to `show_help_echo'.
5393
5394 * gtkutil.c (xg_maybe_add_timer):
5395 * keyboard.c (readable_events):
5396 * process.c (wait_reading_process_output):
5397 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5398
5399 * insdel.c (adjust_markers_gap_motion):
5400 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5401 (gap_left, gap_right): Don't call it.
5402
5403 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5404
5405 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5406 incurred during fontification.
5407
5408 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5409
5410 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5411 (DEFVAR_PER_BUFFER): Don't pass it.
5412
5413 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5414 (scrolling_window): Don't pass it.
5415
5416 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5417
5418 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5419
5420 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5421 and `suffix'.
5422 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5423 of variables specific to SELinux and computation of `encoded_absname'.
5424
5425 * image.c (XPutPixel): Remove unused variable `height'.
5426
5427 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5428
5429 * unexw32.c (get_section_info): Remove unused variable `section'.
5430
5431 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5432 (system_process_attributes): Remove unused variable `sess'.
5433 (sys_read): Remove unused variable `err'.
5434
5435 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5436 (w32_wnd_proc): Remove unused variable `isdead'.
5437 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5438 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5439 (x_create_tip_frame): Remove unused variable `tem'.
5440
5441 * w32inevt.c (w32_console_read_socket):
5442 Remove unused variable `no_events'.
5443
5444 * w32term.c (x_draw_composite_glyph_string_foreground):
5445 Remove unused variable `width'.
5446
5447 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * w32term.c (x_set_glyph_string_clipping):
5450 Don't pass uninitialized region to CombineRgn.
5451
5452 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5453
5454 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5455 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5456 (Fx_close_connection): Remove unused variable `i'.
5457
5458 * w32font.c (w32font_draw): Return number of glyphs.
5459 (w32font_open_internal): Remove unused variable `i'.
5460 (w32font_driver): Add missing initializer.
5461
5462 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5463 (fill_in_menu): Remove unused variable `items_added'.
5464
5465 * w32term.c (last_mouse_press_frame): Remove static global variable.
5466 (w32_clip_to_row): Remove unused variable `f'.
5467 (x_delete_terminal): Remove unused variable `i'.
5468
5469 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5470 (NOTHING): Remove unused static global variable.
5471 (uniscribe_check_otf): Remove unused variable `table'.
5472 (uniscribe_font_driver): Add missing initializers.
5473
5474 2011-03-23 Julien Danjou <julien@danjou.info>
5475
5476 * term.c (Fsuspend_tty, Fresume_tty):
5477 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5478 * window.c (temp_output_buffer_show):
5479 * insdel.c (signal_before_change):
5480 * frame.c (Fhandle_switch_frame):
5481 * fileio.c (Fdo_auto_save):
5482 * emacs.c (Fkill_emacs):
5483 * editfns.c (save_excursion_restore):
5484 * cmds.c (internal_self_insert):
5485 * callint.c (Fcall_interactively):
5486 * buffer.c (Fkill_all_local_variables):
5487 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5488 Use Frun_hooks.
5489 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5490 unconditionnaly since it does the check itself.
5491
5492 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5493
5494 Fix more problems found by GCC 4.5.2's static checks.
5495
5496 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5497 the first time through the loop, since we know p0 < p1 then.
5498 This also avoids a gcc -Wstrict-overflow warning.
5499
5500 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5501 leading to a memory leak, possible in functions like
5502 load_charset_map_from_file that can allocate an unbounded number
5503 of objects (Bug#8318).
5504
5505 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5506 that could (at least in theory) be that large.
5507
5508 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5509 This is less likely to overflow, and avoids undefined behavior if
5510 overflow does occur. All callers changed. Use strtoul to scan
5511 for the unsigned long integer.
5512 (pint2hrstr): Simplify and tune code slightly.
5513 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5514
5515 * scroll.c (do_scrolling): Work around GCC bug 48228.
5516 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5517
5518 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5519 This also avoids a warning with gcc -Wstrict-overflow.
5520 (validate_x_resource_name): Simplify count usage.
5521 This also avoids a warning with gcc -Wstrict-overflow.
5522
5523 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5524 fail (Bug#8306).
5525
5526 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5527
5528 * process.c (Fmake_network_process): Use socklen_t, not int,
5529 where POSIX says socklen_t is required in portable programs.
5530 This fixes a porting bug on hosts like 64-bit HP-UX, where
5531 socklen_t is wider than int (Bug#8277).
5532 (Fmake_network_process, server_accept_connection):
5533 (wait_reading_process_output, read_process_output):
5534 Likewise.
5535
5536 * process.c: Rename or move locals to avoid shadowing.
5537 (list_processes_1, Fmake_network_process):
5538 (read_process_output_error_handler, exec_sentinel_error_handler):
5539 Rename or move locals.
5540 (Fmake_network_process): Define label "retry_connect" only if needed.
5541 (Fnetwork_interface_info): Fix pointer signedness.
5542 (process_send_signal): Add cast to avoid pointer signedness problem.
5543 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5544 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5545
5546 Make tparam.h and terminfo.c consistent.
5547 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5548 Include tparam.h instead, since it declares them.
5549 * cm.h (PC): Remove extern decl; tparam.h now does this.
5550 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5551 * terminfo.c: Include tparam.h, to check interfaces.
5552 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5553 (tparam): Adjust signature to match interface in tparam.h;
5554 this removes some undefined behavior. Check that outstring and len
5555 are zero, which they always are with Emacs.
5556 * tparam.h (PC, BC, UP): New extern decls.
5557
5558 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5559 (xftfont_open): Rename locals to avoid shadowing.
5560
5561 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5562 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5563 (OTF_TAG_SYM): Omit macro if not needed.
5564 (ftfont_list): Remove unused local.
5565 (get_adstyle_property, ftfont_pattern_entity):
5566 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5567 Rename locals to avoid shadowing.
5568
5569 * xfont.c (xfont_list_family): Mark var as initialized.
5570
5571 * xml.c (make_dom): Now static.
5572
5573 * composite.c (composition_compute_stop_pos): Rename local to
5574 avoid shadowing.
5575 (composition_reseat_it): Remove unused locals.
5576 (find_automatic_composition, composition_adjust_point): Likewise.
5577 (composition_update_it): Mark var as initialized.
5578 (find_automatic_composition): Mark vars as initialized,
5579 with a FIXME (Bug#8290).
5580
5581 character.h: Rename locals to avoid shadowing.
5582 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5583 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5584 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5585 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5586 to avoid shadowing.
5587
5588 * textprop.c (property_change_between_p): Remove; unused.
5589
5590 * intervals.c (interval_start_pos): Now static.
5591
5592 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5593
5594 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5595 Rename locals to avoid shadowing.
5596
5597 * sound.c (wav_play, au_play, Fplay_sound_internal):
5598 Fix pointer signedness.
5599 (alsa_choose_format): Remove unused local var.
5600 (wav_play): Initialize a variable to 0, to prevent undefined
5601 behavior (Bug#8278).
5602
5603 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5604
5605 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5606
5607 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5608 clobbering (Bug#8298).
5609 * sysdep.c (sys_subshell): Likewise.
5610 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5611
5612 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5613 This should get cleaned up, so that child_setup has the
5614 same signature on all platforms.
5615
5616 * callproc.c (call_process_cleanup): Now static.
5617 (relocate_fd): Rename locals to avoid shadowing.
5618
5619 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5620
5621 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5622 not to be necessary, and produces flickering.
5623
5624 2011-03-20 Glenn Morris <rgm@gnu.org>
5625
5626 * config.in: Remove file.
5627
5628 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5629
5630 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5631 are now in src/globals.h.
5632 (syms_of_minibuf): Remove spurious & from previous change.
5633
5634 2011-03-20 Leo <sdl.web@gmail.com>
5635
5636 * minibuf.c (completing-read-function): New variable.
5637 (completing-read-default): Rename from completing-read.
5638 (completing-read): Call completing-read-function.
5639
5640 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5641
5642 * xfaces.c (Fx_load_color_file):
5643 Read color file from absolute filename (bug#8250).
5644
5645 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * makefile.w32-in: Update dependencies.
5648
5649 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5650
5651 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5652
5653 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5654
5655 Fix more problems found by GCC 4.5.2's static checks.
5656
5657 * process.c (make_serial_process_unwind, send_process_trap):
5658 (sigchld_handler): Now static.
5659
5660 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5661 That way, the code declares only the vars that it needs.
5662 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5663 * s/cygwin.h (PTY_ITERATION): Likewise.
5664 * s/darwin.h (PTY_ITERATION): Likewise.
5665 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5666
5667 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5668 * process.c (allocate_pty): Don't declare stb unless it's needed.
5669
5670 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5671 (CONSTANTLIM): Remove; unused.
5672 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5673 Define only if needed.
5674
5675 * unexelf.c (unexec): Name an expression,
5676 to avoid gcc -Wbad-function-cast warning.
5677 Use a different way to cause a compilation error if anyone uses
5678 n rather than nn, a way that does not involve shadowing.
5679 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5680
5681 * deps.mk (unexalpha.o): Remove; unused.
5682
5683 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5684 * unexec.h: New file.
5685 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5686 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5687 Depend on unexec.h.
5688 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5689 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5690 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5691 Change as necessary to match prototype in unexec.h.
5692
5693 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5694 shadowing.
5695 (back_comment, skip_chars): Mark vars as initialized.
5696
5697 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5698 Rename locals to avoid shadowing.
5699
5700 * lread.c (read1): Rewrite so as not to use empty "else".
5701 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5702
5703 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5704
5705 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5706 warning when compiling print.c.
5707
5708 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5709 instead of using an uninitialized var.
5710 (font_sort_entities): Mark var as initialized.
5711
5712 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5713
5714 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5715 pointers to constants.
5716 (font_parse_fcname): Remove unused vars.
5717 (font_delete_unmatched): Now static.
5718 (font_get_spec): Remove; unused.
5719 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5720 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5721 Rename or move locals to avoid shadowing.
5722
5723 * fns.c (require_nesting_list, require_unwind): Now static.
5724 (Ffillarray): Rename locals to avoid shadowing.
5725
5726 * floatfns.c (domain_error2): Define only if needed.
5727 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5728
5729 * alloc.c (mark_backtrace): Move decl from here ...
5730 * lisp.h: ... to here, so that it can be checked.
5731
5732 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5733 (Fdefvar): Rewrite so as not to use empty "else".
5734 (lisp_indirect_variable): Name an expression,
5735 to avoid gcc -Wbad-function-cast warning.
5736 (Fdefvar): Rename locals to avoid shadowing.
5737
5738 * callint.c (quotify_arg, quotify_args): Now static.
5739 (Fcall_interactively): Rename locals to avoid shadowing.
5740 Use const pointer when appropriate.
5741
5742 * lisp.h (get_system_name, get_operating_system_release):
5743 Move decls here, to check interfaces.
5744 * process.c (get_operating_system_release): Move decl to lisp.h.
5745 * xrdb.c (get_system_name): Likewise.
5746 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5747 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5748 some of which prompt warnings from gcc -Wbad-function-cast.
5749 (Fformat_time_string, Fencode_time, Finsert_char):
5750 (Ftranslate_region_internal, Fformat):
5751 Rename or remove local vars to avoid shadowing.
5752 (Ftranslate_region_internal): Mark var as initialized.
5753
5754 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5755 avoid shadowing.
5756
5757 * lisp.h (eassert): Check that the argument compiles, even if
5758 ENABLE_CHECKING is not defined.
5759
5760 * data.c (Findirect_variable): Name an expression, to avoid
5761 gcc -Wbad-function-cast warning.
5762 (default_value, arithcompare, arith_driver, arith_error): Now static.
5763 (store_symval_forwarding): Rename local to avoid shadowing.
5764 (Fmake_variable_buffer_local, Fmake_local_variable):
5765 Mark variables as initialized.
5766 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5767
5768 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5769 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5770 Rename locals to avoid shadowing.
5771 (mark_stack): Move local variables into the #ifdef region where
5772 they're used.
5773 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5774 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5775 needed otherwise.
5776 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5777 (GC_STRING_CHARS): Remove; not used.
5778 (Fmemory_limit): Cast sbrk's returned value to char *.
5779
5780 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5781 avoids undefined behavior in theory.
5782
5783 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5784
5785 Use functions, not macros, for up- and down-casing (Bug#8254).
5786 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5787 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5788 to use the following functions instead of these macros.
5789 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5790 EMACS_INT, since callers assume the returned value fits in int.
5791 (upcase1): Likewise, for UPCASE_TABLE.
5792 (uppercasep, lowercasep, upcase): New static inline functions.
5793 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5794 the race-condition problem in the old DOWNCASE.
5795
5796 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5797 Rename locals to avoid shadowing.
5798 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5799 (regex_compile, re_search_2, re_match_2_internal):
5800 Remove unused local vars.
5801 (FREE_VAR): Rewrite so as not to use empty "else",
5802 which gcc can warn about.
5803 (regex_compile, re_match_2_internal): Mark locals as initialized.
5804 (RETALLOC_IF): Define only if needed.
5805 (WORDCHAR_P): Likewise. This one is never needed, but is used
5806 only in a comment talking about a compiler bug, so put inside
5807 the #if 0 of that comment.
5808 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5809 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5810 Remove; unused.
5811
5812 * search.c (boyer_moore): Rename locals to avoid shadowing.
5813 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5814 (PREV_CHAR_BOUNDARY): Likewise.
5815
5816 * search.c (simple_search): Remove unused var.
5817
5818 * dired.c (compile_pattern): Move decl from here ...
5819 * lisp.h: ... to here, so that it can be checked.
5820 (struct re_registers): New forward decl.
5821
5822 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5823
5824 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5825 All uses changed.
5826 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5827 Rename locals to avoid shadowing.
5828 (Fvertical_motion): Mark locals as initialized.
5829
5830 * casefiddle.c (casify_object, casify_region): Now static.
5831 (casify_region): Mark local as initialized.
5832
5833 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5834
5835 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5836 New macros, so that the caller can use some names other than
5837 gcpro1, gcpro2, etc.
5838 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5839 of the new macros.
5840 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5841 argument, for consistency with GCPRO2_VAR, etc: it is now the
5842 prefix of the variable, not the variable itself. All uses
5843 changed.
5844 * dired.c (directory_files_internal, file_name_completion):
5845 Rename locals to avoid shadowing.
5846
5847 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5848 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5849 dired.c's scmp function, had undefined behavior.
5850 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5851 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5852 * buffer.h: ... to here, because these macros use current_buffer,
5853 and the new implementation with inline functions needs to have
5854 current_buffer in scope now, rather than later when the macros
5855 are used.
5856 (downcase, upcase1): New static inline functions.
5857 (DOWNCASE, UPCASE1): Reimplement using these functions.
5858 This avoids undefined behavior in expressions like
5859 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5860 from race conditions in accessing the global variables
5861 case_temp1 and case_temp2.
5862 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5863 * lisp.h (case_temp1, case_temp2): Remove their decls.
5864 * character.h (ASCII_CHAR_P): Move from here ...
5865 * lisp.h: ... to here, so that the inline functions mentioned
5866 above can use them.
5867
5868 * dired.c (directory_files_internal_unwind): Now static.
5869
5870 * fileio.c (file_name_as_directory, directory_file_name):
5871 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5872 Now static.
5873 (file_name_as_directory): Use const pointers when appropriate.
5874 (Fexpand_file_name): Likewise. In particular, newdir might
5875 point at constant storage, so make it a const pointer.
5876 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5877 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5878 signedness issues.
5879 (Fset_file_times, Finsert_file_contents, auto_save_error):
5880 Rename locals to avoid shadowing.
5881
5882 * minibuf.c (choose_minibuf_frame_1): Now static.
5883 (Ftry_completion, Fall_completions): Rename or remove locals
5884 to avoid shadowing.
5885
5886 * marker.c (bytepos_to_charpos): Remove; unused.
5887
5888 * lisp.h (verify_bytepos, count_markers): New decls,
5889 so that gcc does not warn that these functions aren't declared.
5890
5891 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5892 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5893 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5894 (copy_text): Remove unused local var.
5895
5896 * filelock.c (within_one_second): Now static.
5897 (lock_file_1): Rename local to avoid shadowing.
5898
5899 * buffer.c (fix_overlays_before): Mark locals as initialized.
5900 (fix_start_end_in_overlays): Likewise. This function should be
5901 simplified by using pointers-to-pointers, but that's a different
5902 matter.
5903 (switch_to_buffer_1): Now static.
5904 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5905 (report_overlay_modification): Rename locals to avoid shadowing.
5906
5907 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5908 Fix pointer signedness issue.
5909 (sys_subshell): Mark local as volatile if checking for lint,
5910 to suppress a gcc -Wclobbered warning that does not seem to be right.
5911 (MAXPATHLEN): Define only if needed.
5912
5913 * process.c (serial_open, serial_configure): Move decls from here ...
5914 * systty.h: ... to here, so that they can be checked.
5915
5916 * fns.c (get_random, seed_random): Move extern decls from here ...
5917 * lisp.h: ... to here, so that they can be checked.
5918
5919 * sysdep.c (reset_io): Now static.
5920 (wait_for_termination_signal): Remove; unused.
5921
5922 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5923 (copy_keymap_item, append_key, push_text_char_description):
5924 Now static.
5925 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5926 (DENSE_TABLE_SIZE): Remove; unused.
5927 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5928 (describe_map_tree):
5929 Rename locals to avoid shadowing.
5930
5931 * keyboard.c: Declare functions static if they are not used elsewhere.
5932 (echo_char, echo_dash, cmd_error, top_level_2):
5933 (poll_for_input, handle_async_input): Now static.
5934 (read_char, kbd_buffer_get_event, make_lispy_position):
5935 (make_lispy_event, make_lispy_movement, apply_modifiers):
5936 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5937 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5938 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5939 (read_key_sequence, read_char): Mark locals as initialized.
5940 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5941
5942 * keyboard.h (make_ctrl_char): New decl.
5943 (mark_kboards): Move decl here ...
5944 * alloc.c (mark_kboards): ... from here.
5945
5946 * lisp.h (force_auto_save_soon): New decl.
5947
5948 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5949 (DEFINE_DUMMY_FUNCTION): New macro.
5950 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5951 Use it.
5952 (main): Add casts to avoid warnings
5953 if GCC considers string literals to be constants.
5954
5955 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5956
5957 * dbusbind.c: Pointer signedness fixes.
5958 (xd_signature, xd_append_arg, xd_initialize):
5959 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5960 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5961 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5962 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5963
5964 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5965 if GCC considers string literals to be constants.
5966 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5967
5968 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5969
5970 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5971 (print_preprocess, print_object): New macro to fix last change.
5972
5973 * print.c (print_preprocess): Don't forget font objects.
5974
5975 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5976
5977 * emacs.c (USAGE3): Doc fixes.
5978
5979 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5980
5981 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5982 structure.
5983
5984 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5985
5986 * lisp.h (VWindow_system, Qfile_name_history):
5987 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5988 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5989 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5990
5991 * w32select.c: Don't #include "keyboard.h".
5992 (run_protected): Add extern declaration for waiting_for_input.
5993
5994 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5995 * w32console.c (detect_input_pending, read_input_pending)
5996 (encode_terminal_code):
5997 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5998 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5999 (w32_system_caret_y, Qfile_name_history):
6000 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6001 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6002 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6003 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6004 * w32proc.c (Qlocal, report_file_error):
6005 * w32term.c (Vwindow_system, updating_frame):
6006 * w32uniscribe.c (initialized, uniscribe_font_driver):
6007 Remove unneeded extern declarations.
6008
6009 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6010
6011 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6012
6013 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6014
6015 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6016 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6017 These macros can no longer be used for assignment.
6018
6019 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6020 Assign struct members directly, instead of using BUF_BEGV etc.
6021 (record_buffer_markers, fetch_buffer_markers): New functions for
6022 recording and fetching special buffer markers.
6023 (set_buffer_internal_1, set_buffer_temp): Use them.
6024
6025 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6026
6027 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6028
6029 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6030 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6031
6032 * xdisp.c (hscroll_window_tree):
6033 (reconsider_clip_changes): Use PT instead of BUF_PT.
6034
6035 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6036
6037 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6038 $(EMACS_ROOT)/lib/intprops.h.
6039
6040 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 Fix more problems found by GCC 4.5.2's static checks.
6043
6044 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6045 to unsigned char * to avoid compiler diagnostic.
6046 (xg_free_frame_widgets): Make it clear that a local variable is
6047 needed only if USE_GTK_TOOLTIP.
6048 (gdk_window_get_screen): Make it clear that this macro is needed
6049 only if USE_GTK_TOOLTIP.
6050 (int_gtk_range_get_value): New function, which avoids a diagnostic
6051 from gcc -Wbad-function-cast.
6052 (xg_set_toolkit_scroll_bar_thumb): Use it.
6053 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6054 diagnostic from gcc -Wbad-function-cast.
6055 (get_utf8_string, xg_get_file_with_chooser):
6056 Rename locals to avoid shadowing.
6057 (create_dialog): Move locals to avoid shadowing.
6058
6059 * xgselect.c (xg_select): Remove unused var.
6060
6061 * image.c (four_corners_best): Mark locals as initialized.
6062 (gif_load): Initialize transparent_p to zero (Bug#8238).
6063 Mark another local as initialized.
6064 (my_png_error, my_error_exit): Mark with NO_RETURN.
6065
6066 * image.c (clear_image_cache): Now static.
6067 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6068 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6069 (x_edge_detection): Remove unnecessary cast that
6070 gcc -Wbad-function-cast diagnoses.
6071 (gif_load): Fix pointer signedness.
6072 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6073 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6074
6075 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6076
6077 Improve quality of tests for time stamp overflow.
6078 For example, without this patch (encode-time 0 0 0 1 1
6079 1152921504606846976) returns the obviously-bogus value (-948597
6080 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6081 reports time overflow. See
6082 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6083 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6084 * editfns.c: Include limits.h and intprops.h.
6085 (TIME_T_MIN, TIME_T_MAX): New macros.
6086 (time_overflow): Move earlier, to before first use.
6087 (hi_time, lo_time): New functions, for an accurate test for
6088 out-of-range times.
6089 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6090 (Fget_internal_run_time): Don't assume time_t fits in int.
6091 (make_time): Use list2 instead of Fcons twice.
6092 (Fdecode_time): More accurate test for out-of-range times.
6093 (check_tm_member): New function.
6094 (Fencode_time): Use it, to test for out-of-range times.
6095 (lisp_time_argument): Don't rely on undefined left-shift and
6096 right-shift behavior when checking for time stamp overflow.
6097
6098 * editfns.c (time_overflow): New function, refactoring common code.
6099 (Fformat_time_string, Fdecode_time, Fencode_time):
6100 (Fcurrent_time_string): Use it.
6101
6102 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6103 * dired.c (make_time): Move to ...
6104 * editfns.c (make_time): ... here.
6105 * systime.h: Note the move.
6106
6107 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6108
6109 * fringe.c (update_window_fringes): Remove unused variables.
6110
6111 * unexmacosx.c (copy_data_segment): Also copy __got section.
6112 (Bug#8223)
6113
6114 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6115
6116 * termcap.c [MSDOS]: Include "msdos.h".
6117 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6118 Constify `char *' arguments and their references according to
6119 prototypes in tparam.h.
6120
6121 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6122
6123 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6124 Adapt all references accordingly.
6125
6126 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6127
6128 2011-03-11 Tom Tromey <tromey@redhat.com>
6129
6130 * buffer.c (syms_of_buffer): Remove obsolete comment.
6131
6132 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6133
6134 * termhooks.h (encode_terminal_code): Declare prototype.
6135
6136 * msdos.c (encode_terminal_code): Don't declare prototype.
6137
6138 * term.c (encode_terminal_code): Now external again, used by
6139 w32console.c and msdos.c.
6140
6141 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6142 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6143
6144 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6145
6146 Fix some minor problems found by GCC 4.5.2's static checks.
6147
6148 * fringe.c (update_window_fringes): Mark locals as initialized
6149 (Bug#8227).
6150 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6151
6152 * alloc.c (mark_fringe_data): Move decl from here ...
6153 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6154 to check its interface.
6155 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6156
6157 * fontset.c (free_realized_fontset): Now static.
6158 (Fset_fontset_font): Rename local to avoid shadowing.
6159 (fontset_font): Mark local as initialized.
6160 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6161
6162 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6163
6164 * xselect.c (x_disown_buffer_selections): Remove; not used.
6165 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6166 (x_own_selection, Fx_disown_selection_internal): Rename locals
6167 to avoid shadowing.
6168 (x_handle_dnd_message): Remove local to avoid shadowing.
6169
6170 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6171 so that the caller can use some name other than gcpro1.
6172 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6173 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6174 (Fx_backspace_delete_keys_p):
6175 Use them to avoid shadowing, and rename vars to avoid shadowing.
6176 (x_decode_color, x_set_name, x_window): Now static.
6177 (Fx_create_frame): Add braces to silence GCC warning.
6178 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6179 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6180 Remove unused locals.
6181 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6182 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6183 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6184 macros.
6185
6186 * xterm.h (x_mouse_leave): New decl.
6187
6188 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6189 Remove unused functions.
6190 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6191 (x_calc_absolute_position): Now static.
6192 (XTread_socket): Don't define label "out" unless it's used.
6193 Don't declare local "event" unless it's used.
6194 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6195 unless they are used.
6196 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6197 (x_fatal_error_signal): Remove; not used.
6198 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6199 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6200 (x_error_catcher, x_connection_closed, x_error_handler):
6201 (x_error_quitter, xembed_send_message, x_iconify_frame):
6202 (my_log_handler): Rename locals to avoid shadowing.
6203 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6204 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6205
6206 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6207 Rename or move locals to avoid shadowing.
6208 (tty_defined_color, merge_face_heights): Now static.
6209 (free_realized_faces_for_fontset): Remove; not used.
6210 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6211 does not deduce is never used uninitialized.
6212 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6213 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6214
6215 * terminal.c (store_terminal_param): Now static.
6216
6217 * xmenu.c (menu_highlight_callback): Now static.
6218 (set_frame_menubar): Remove unused local.
6219 (xmenu_show): Rename parameter to avoid shadowing.
6220 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6221 since they might point to immutable storage.
6222 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6223 since it's unused otherwise.
6224
6225 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6226 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6227 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6228 avoids a gcc -Wuninitialized diagnostic.
6229 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6230 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6231 does not deduce are never used uninitialized.
6232
6233 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6234
6235 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6236 * window.c (window_loop, size_window):
6237 (run_window_configuration_change_hook, enlarge_window): Likewise.
6238
6239 * window.c (display_buffer): Now static.
6240 (size_window): Mark variables that gcc -Wuninitialized
6241 does not deduce are never used uninitialized.
6242 * window.h (check_all_windows): New decl, to forestall
6243 gcc -Wmissing-prototypes diagnostic.
6244 * dispextern.h (bidi_dump_cached_states): Likewise.
6245
6246 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6247 shadowing.
6248 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6249 Include <limits.h>.
6250 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6251 and to avoid gcc -Wuninitialized warning.
6252 (load_charset_map): Mark variables that gcc -Wuninitialized
6253 does not deduce are never used uninitialized.
6254 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6255
6256 * coding.c (coding_set_source, coding_set_destination):
6257 Use "else { /* comment */ }" rather than "else /* comment */;"
6258 for clarity, and to avoid gcc -Wempty-body warning.
6259 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6260 a block, when the outer 'i' will do.
6261 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6262 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6263 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6264 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6265 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6266 Rename locals to avoid shadowing.
6267 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6268 * coding.c (emacs_mule_char, encode_invocation_designation):
6269 Now static, since they're not used elsewhere.
6270 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6271 (decode_coding_object, encode_coding_object, detect_coding_system):
6272 (decode_coding_emacs_mule): Mark variables that gcc
6273 -Wuninitialized does not deduce are never used uninitialized.
6274 (detect_coding_iso_2022): Initialize a local variable that might
6275 be used uninitialized. Leave a FIXME because it's not clear that
6276 this initialization is needed. (Bug#8211)
6277 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6278 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6279 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6280 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6281 Remove unused macros.
6282
6283 * category.c (hash_get_category_set): Remove unused local var.
6284 (copy_category_table): Now static, since it's not used elsewhere.
6285 * character.c (string_count_byte8): Likewise.
6286
6287 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6288 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6289
6290 * chartab.c (copy_sub_char_table): Now static, since it's not used
6291 elsewhere.
6292 (sub_char_table_ref_and_range, char_table_ref_and_range):
6293 Rename locals to avoid shadowing.
6294 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6295
6296 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6297 (BIDI_BOB): Remove unused macro.
6298
6299 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6300 deduce are never used uninitialized.
6301 * term.c (encode_terminal_code): Likewise.
6302
6303 * term.c (encode_terminal_code): Now static. Remove unused local.
6304
6305 * tparam.h: New file.
6306 * term.c, tparam.h: Include it.
6307 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6308 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6309 Move these decls to tparam.h, and make them agree with what
6310 is actually in tparam.c. The previous trick of using incompatible
6311 decls in different modules does not conform to the C standard.
6312 All callers of tparam changed to use tparam's actual API.
6313 * tparam.c (tparam1, tparam, tgoto):
6314 Use const pointers where appropriate.
6315
6316 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6317 * cm.h (struct cm): Likewise.
6318 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6319 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6320 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6321 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6322 (turn_on_face, init_tty): Likewise.
6323 * termchar.h (struct tty_display_info): Likewise.
6324
6325 * term.c (term_mouse_position): Rename local to avoid shadowing.
6326
6327 * alloc.c (mark_ttys): Move decl from here ...
6328 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6329
6330 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6331
6332 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6333
6334 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6335
6336 * search.c (compile_pattern_1): Remove argument regp, unused since
6337 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6338 (compile_pattern): Don't pass it.
6339
6340 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6341
6342 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6343 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6344 for ! HAVE_GTK3.
6345 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6346
6347 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6348
6349 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6350 gdk_window_get_screen, gdk_window_get_geometry,
6351 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6352 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6353 (xg_get_pixbuf_from_pixmap): New function.
6354 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6355 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6356 Call xg_get_pixbuf_from_pixmap instead of
6357 gdk_pixbuf_get_from_drawable.
6358 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6359 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6360 (xg_check_special_colors): Use GtkStyleContext and its functions
6361 for HAVE_GTK3.
6362 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6363 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6364 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6365 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6366 Call gtk_widget_get_preferred_size.
6367 (xg_frame_resized): gdk_window_get_geometry only takes 5
6368 parameters.
6369 (xg_win_to_widget, xg_event_is_for_menubar):
6370 Call gdk_x11_window_lookup_for_display.
6371 (xg_set_widget_bg): New function.
6372 (delete_cb): New function.
6373 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6374 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6375 (xg_set_background_color): Call xg_set_widget_bg.
6376 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6377 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6378 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6379 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6380 if ! HAVE_GTK3.
6381 (update_frame_tool_bar): Call gtk_widget_hide.
6382 (xg_initialize): Use GDK_KEY_g.
6383
6384 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6385 if ! HAVE_GTK3
6386 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6387
6388 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6389 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6390 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6391
6392 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6393
6394 * w32xfns.c (select_palette): Check success of RealizePalette against
6395 GDI_ERROR, not zero.
6396
6397 See ChangeLog.11 for earlier changes.
6398
6399 ;; Local Variables:
6400 ;; coding: utf-8
6401 ;; End:
6402
6403 Copyright (C) 2011 Free Software Foundation, Inc.
6404
6405 This file is part of GNU Emacs.
6406
6407 GNU Emacs is free software: you can redistribute it and/or modify
6408 it under the terms of the GNU General Public License as published by
6409 the Free Software Foundation, either version 3 of the License, or
6410 (at your option) any later version.
6411
6412 GNU Emacs is distributed in the hope that it will be useful,
6413 but WITHOUT ANY WARRANTY; without even the implied warranty of
6414 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6415 GNU General Public License for more details.
6416
6417 You should have received a copy of the GNU General Public License
6418 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.