]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from gnulib, using build-aux to remove clutter.
[gnu-emacs] / src / ChangeLog
1 2011-07-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * Makefile.in (gl-stamp): move-if-change is now in build-aux.
4
5 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6
7 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8 for attrs[LFACE_FONTSET_INDEX].
9
10 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11
12 * xml.c (parse_region): Remove unused local
13 that was recently introduced.
14
15 2011-07-23 Eli Zaretskii <eliz@gnu.org>
16
17 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
18 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
19
20 * xdisp.c (move_it_in_display_line_to): Record the best matching
21 position for TO_CHARPOS while scanning the line, and restore it on
22 exit if none of the characters scanned was an exact match. Fixes
23 vertical-motion and pos-visible-in-window-p under bidi redisplay
24 when exact match is impossible due to invisible text, and the
25 lines are truncated.
26
27 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
28
29 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
30 for OSX >= 10.7.
31
32 2011-07-22 Eli Zaretskii <eliz@gnu.org>
33
34 Fix a significant slow-down of cursor motion with C-n, C-p,
35 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
36 auto-repeat under bidi redisplay in fontified buffers.
37 * xdisp.c (compute_stop_pos_backwards): New function.
38 (next_element_from_buffer): Call compute_stop_pos_backwards to
39 find a suitable prev_stop when we find ourselves before
40 base_level_stop.
41 (reseat): Don't look for prev_stop, as that could mean a very long
42 run.
43 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
44 <cached_disp_overlay_modiff>: Cache for last found display string
45 position.
46 (compute_display_string_pos): Return the cached position if asked
47 about the same buffer in the same area of character positions, and
48 the buffer wasn't changed since the time the display string
49 position was cached.
50
51 2011-07-22 Eli Zaretskii <eliz@gnu.org>
52
53 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
54 is an integer, which is important for empty lines. (Bug#9149)
55
56 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
57
58 * frame.c (Fmodify_frame_parameters): In tty case, update the
59 default face if necessary (Bug#4238).
60
61 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
62
63 * editfns.c (Fstring_to_char): No need to explain what a character
64 is in the docstring (Bug#6576).
65
66 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
67
68 * xml.c (parse_region): Make sure we always return a tree.
69
70 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
71
72 * xml.c (parse_region): If a document contains only comments,
73 return that, too.
74
75 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
76
77 * xml.c (make_dom): Return comments, too.
78
79 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
80
81 Port to OpenBSD.
82 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
83 and the surrounding thread.
84 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
85 rather than fgets, and retry after EINTR. Otherwise, 'emacs
86 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
87 timer goes off.
88 * s/openbsd.h (BROKEN_SIGIO): Define.
89 * unexelf.c (unexec) [__OpenBSD__]:
90 Don't update the .mdebug section of the Alpha COFF symbol table.
91
92 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
93
94 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
95 (bug#8460).
96
97 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
98
99 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
100 This fixes some race conditions on the permissions of any newly
101 created file.
102
103 * alloc.c (valid_pointer_p): Use pipe, not open.
104 This fixes some permissions issues when debugging.
105
106 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
107 If fchown fails to set both uid and gid, try to set just gid,
108 as that is sometimes allowed. Adjust the file's mode to eliminate
109 setuid or setgid bits that are inappropriate if fchown fails.
110
111 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
112
113 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
114 to compare Lisp_Objects.
115 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
116 global_gnutls_log_level, don't mistake it for a Lisp_Object.
117 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
118
119 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
120
121 * lread.c (read_integer): Unread even EOF character.
122 (read1): Likewise. Properly record start position of symbol.
123
124 * lread.c (read1): Read `#:' as empty uninterned symbol if no
125 symbol character follows.
126
127 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
128
129 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
130 This works around a problem with the previous change to Fcopy_file.
131 Recent glibc declares fchown with __attribute__((warn_unused_result)),
132 and without this change, GCC might complain about discarding
133 fchown's return value.
134
135 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
136
137 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
138
139 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
140
141 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
142
143 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
144
145 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
146 it's used from the C level.
147
148 * process.c: Use the same condition for POLL_FOR_INPUT in both
149 keyboard.c and process.c (bug#1858).
150
151 2011-07-09 Lawrence Mitchell <wence@gmx.li>
152
153 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
154 (Fgnutls_boot): Use it.
155
156 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
157
158 * doc.c (Fsubstitute_command_keys): Revert last change.
159
160 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
161
162 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
163 quotes the next character, and doesn't affect other longer
164 sequences (bug#8935).
165
166 * lread.c (syms_of_lread): Clarify that is isn't only
167 `eval-buffer' and `eval-defun' that's affected by
168 `lexical-binding' (bug#8460).
169
170 2011-07-15 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
173 bidi redisplay when a line includes both an image and is
174 truncated.
175
176 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
177
178 Fix minor problems found by static checking.
179 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
180 (elsz): Now a signed constant, not a size_t var. We prefer signed
181 types to unsigned, to avoid integer comparison confusion. Without
182 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
183 "cannot optimize loop, the loop counter may overflow", a symptom
184 of the confusion.
185 * indent.c (Fvertical_motion): Mark locals as initialized.
186 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
187
188 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
189
190 * search.c (Fre_search_backward): Mention `case-fold-search' in
191 all the re_search_* functions (bug#8138).
192
193 * keyboard.c (Fopen_dribble_file): Document when the file is
194 closed (bug#8056).
195
196 2011-07-14 Eli Zaretskii <eliz@gnu.org>
197
198 * bidi.c (bidi_dump_cached_states): Fix format of displaying
199 bidi_cache_idx.
200
201 Support bidi reordering of display and overlay strings.
202 * xdisp.c (compute_display_string_pos)
203 (compute_display_string_end): Accept additional argument STRING.
204 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
205 (reseat_to_string): Initialize bidi_it->string.s and
206 bidi_it->string.schars.
207 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
208 NULL (avoids a crash in bidi_paragraph_init). Initialize
209 itb.string.lstring.
210 (init_iterator): Call bidi_init_it only of a valid
211 buffer position was specified. Initialize paragraph_embedding to
212 L2R.
213 (reseat_to_string): Initialize the bidi iterator.
214 (display_string): If we need to ignore text properties of
215 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
216 original value of -1 will not work with bidi.)
217 (compute_display_string_pos): First arg is now struct
218 `text_pos *'; all callers changed. Support display properties on
219 Lisp strings.
220 (compute_display_string_end): Support display properties on Lisp
221 strings.
222 (init_iterator, reseat_1, reseat_to_string): Initialize the
223 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
224 when iterating on a string not from display properties).
225 (compute_display_string_pos, compute_display_string_end): Fix
226 calculation of the object to scan. Fixes an error when using
227 arrow keys.
228 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
229 base_level_stop; instead, set base_level_stop to BEGV. Fixes
230 crashes in vertical-motion.
231 (next_element_from_buffer): Improve commentary for when
232 the iterator is before prev_stop.
233 (init_iterator): Initialize bidi_p from the default value of
234 bidi-display-reordering, not from buffer-local value. Use the
235 buffer-local value only if initializing for buffer iteration.
236 (handle_invisible_prop): Support invisible properties on strings
237 that are being bidi-reordered.
238 (set_iterator_to_next): Support bidi reordering of C strings and
239 Lisp strings.
240 (next_element_from_string): Support bidi reordering of Lisp
241 strings.
242 (handle_stop_backwards): Support Lisp strings as well.
243 (display_string): Support display of R2L glyph rows. Use
244 IT_STRING_CHARPOS when displaying from a Lisp string.
245 (init_iterator): Don't initialize it->bidi_p for strings
246 here.
247 (reseat_to_string): Initialize it->bidi_p for strings here.
248 (next_element_from_string, next_element_from_c_string)
249 (next_element_from_buffer): Add xassert's for correspondence
250 between IT's object being iterated and it->bidi_it.string
251 structure.
252 (face_before_or_after_it_pos): Support bidi iteration.
253 (next_element_from_c_string): Handle the case of the first string
254 character that is not the first one in the visual order.
255 (get_visually_first_element): New function, refactored from common
256 parts of next_element_from_buffer, next_element_from_string, and
257 next_element_from_c_string.
258 (tool_bar_lines_needed, redisplay_tool_bar)
259 (display_menu_bar): Force left-to-right direction. Add a FIXME
260 comment for making that be controlled by a user option.
261 (push_it, pop_it): Save and restore the state of the
262 bidi iterator. Save and restore the bidi_p flag.
263 (pop_it): Iterate out of display property for string iteration as
264 well.
265 (iterate_out_of_display_property): Support iteration over strings.
266 (handle_single_display_spec): Set up it->bidi_it for iteration
267 over a display string, and call bidi_init_it.
268 (handle_single_display_spec, next_overlay_string)
269 (get_overlay_strings_1, push_display_prop): Set up the bidi
270 iterator for displaying display or overlay strings.
271 (forward_to_next_line_start): Don't use the shortcut if
272 bidi-iterating.
273 (back_to_previous_visible_line_start): If handle_display_prop
274 pushed the iterator stack, restore the internal state of the bidi
275 iterator by calling bidi_pop_it same number of times.
276 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
277 and we are bidi-iterating, don't decrement the iterator position;
278 instead, set the first_elt flag in the bidi iterator, to produce
279 the same effect.
280 (reseat_1): Remove redundant setting of string_from_display_prop_p.
281 (push_display_prop): xassert that we are iterating a buffer.
282 (push_it, pop_it): Save and restore paragraph_embedding member.
283 (handle_single_display_spec, next_overlay_string)
284 (get_overlay_strings_1, reseat_1, reseat_to_string)
285 (push_display_prop): Set up the `unibyte' member of bidi_it.string
286 correctly. Don't assume unibyte strings are not bidi-reordered.
287 (compute_display_string_pos)
288 (compute_display_string_end): Fix handling the case of C string.
289 (push_it, pop_it): Save and restore from_disp_prop_p.
290 (handle_single_display_spec, push_display_prop): Set the
291 from_disp_prop_p flag.
292 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
293 (pop_it): Call iterate_out_of_display_property only if we are
294 popping after iteration over a string that came from a display
295 property. Fix a typo in popping stretch info. Add an assertion
296 for verifying that the iterator position is in sync with the bidi
297 iterator.
298 (handle_single_display_spec, get_overlay_strings_1)
299 (push_display_prop): Fix initialization of paragraph direction for
300 string when that of the parent object is not yet determined.
301 (reseat_1): Call bidi_init_it to resync the bidi
302 iterator with IT's position. (Bug#7616)
303 (find_row_edges): If ROW->start.pos gives position
304 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
305 (handle_stop, back_to_previous_visible_line_start, reseat_1):
306 Reset the from_disp_prop_p flag.
307 (SAVE_IT, RESTORE_IT): New macros.
308 (pos_visible_p, face_before_or_after_it_pos)
309 (back_to_previous_visible_line_start)
310 (move_it_in_display_line_to, move_it_in_display_line)
311 (move_it_to, move_it_vertically_backward, move_it_by_lines)
312 (try_scrolling, redisplay_window, display_line): Use them when
313 saving a temporary copy of the iterator and restoring it back.
314 (back_to_previous_visible_line_start, reseat_1)
315 (init_iterator): Empty the bidi cache "stack".
316 (move_it_in_display_line_to): If iterator ended up at
317 EOL, but we never saw any buffer positions smaller than
318 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
319 motion in bidi-reordered lines.
320 (move_it_in_display_line_to): Record prev_method and prev_pos
321 immediately before the call to set_iterator_to_next. Fixes cursor
322 motion in bidi-reordered lines with stretch glyphs and strings
323 displayed in margins. (Bug#8133) (Bug#8867)
324 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
325 TO_CHARPOS.
326 (pos_visible_p): Support positions in bidi-reordered lines. Save
327 and restore bidi cache.
328
329 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
330 (bidi_paragraph_info): Delete unused struct.
331 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
332 (bidi_cache_start): New variable.
333 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
334 to zero.
335 (bidi_cache_fetch_state, bidi_cache_search)
336 (bidi_cache_find_level_change, bidi_cache_iterator_state)
337 (bidi_cache_find, bidi_peek_at_next_level)
338 (bidi_level_of_next_char, bidi_find_other_level_edge)
339 (bidi_move_to_visually_next): Compare cache index with
340 bidi_cache_start rather than with zero.
341 (bidi_fetch_char): Accept new argument STRING; all callers
342 changed. Support iteration over a string. Support strings with
343 display properties. Support unibyte strings. Fix the type of
344 `len' according to what STRING_CHAR_AND_LENGTH expects.
345 (bidi_paragraph_init, bidi_resolve_explicit_1)
346 (bidi_resolve_explicit, bidi_resolve_weak)
347 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
348 iteration over a string.
349 (bidi_set_sor_type, bidi_resolve_explicit_1)
350 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
351 can now be zero (for strings); special values 0 and -1 were
352 changed to -1 and -2, respectively.
353 (bidi_char_at_pos): New function.
354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
355 Call it instead of FETCH_MULTIBYTE_CHAR.
356 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
357 initialized to valid values.
358 (bidi_init_it): Don't initialize charpos and bytepos with invalid
359 values.
360 (bidi_level_of_next_char): Allow the sentinel "position" to pass
361 the test for valid cached positions. Fix the logic for looking up
362 the sentinel state in the cache. GCPRO the Lisp string we are
363 iterating.
364 (bidi_push_it, bidi_pop_it): New functions.
365 (bidi_initialize): Initialize the bidi cache start stack pointer.
366 (bidi_cache_ensure_space): New function, refactored from part of
367 bidi_cache_iterator_state. Don't assume the required size is just
368 one BIDI_CACHE_CHUNK away.
369 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
370 (bidi_count_bytes, bidi_char_at_pos): New functions.
371 (bidi_cache_search): Don't assume bidi_cache_last_idx is
372 always valid if bidi_cache_idx is valid.
373 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
374 is valid if it's going to be used.
375 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
376 (bidi_cache_fetch_state, bidi_cache_search)
377 (bidi_cache_find_level_change, bidi_cache_ensure_space)
378 (bidi_cache_iterator_state, bidi_cache_find)
379 (bidi_find_other_level_edge, bidi_cache_start_stack): All
380 variables related to cache indices are now EMACS_INT.
381
382 * dispextern.h (struct bidi_string_data): New structure.
383 (struct bidi_it): New member `string'. Make flag members be 1-bit
384 fields, and put them last in the struct.
385 (compute_display_string_pos, compute_display_string_end): Update
386 prototypes.
387 (bidi_push_it, bidi_pop_it): Add prototypes.
388 (struct iterator_stack_entry): New members bidi_p,
389 paragraph_embedding, and from_disp_prop_p.
390 (struct it): Member bidi_p is now a bit field 1 bit wide.
391 (bidi_shelve_cache, bidi_unshelve_cache): Declare
392 prototypes.
393
394 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
395 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
396 and vector-like objects.
397
398 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
399 cache around display iteration.
400
401 * window.c (Fwindow_end, window_scroll_pixel_based)
402 (displayed_window_lines, Frecenter): Save and restore the bidi
403 cache around display iteration.
404
405 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
406
407 * editfns.c (Fdelete_region): Clarify the use of the named
408 parameters (bug#6788).
409
410 2011-07-14 Martin Rudalics <rudalics@gmx.at>
411
412 * indent.c (Fvertical_motion): Set and restore w->pointm when
413 saving and restoring the window's buffer (Bug#9006).
414
415 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
416
417 * editfns.c (Fstring_to_char): Clarify just what is returned
418 (bug#6576). Text by Eli Zaretskii.
419
420 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
421
422 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
423
424 2011-07-13 Eli Zaretskii <eliz@gnu.org>
425
426 * buffer.c (mmap_find): Fix a typo.
427
428 2011-07-13 Johan Bockgård <bojohan@gnu.org>
429
430 Fix execution of x selection hooks.
431 * xselect.c (Qx_lost_selection_functions)
432 (Qx_sent_selection_functions): New vars.
433 (syms_of_xselect): DEFSYM them.
434 (x_handle_selection_request): Pass Qx_sent_selection_functions
435 rather than Vx_sent_selection_functions to Frun_hook_with_args.
436 (x_handle_selection_clear,x_clear_frame_selections):
437 Pass Qx_lost_selection_functions rather than
438 Vx_lost_selection_functions to Frun_hook_with_args.
439
440 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
441
442 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
443 The old code sometimes used this field without initializing it.
444
445 * alloc.c (gc_sweep): Don't read past end of array.
446 In theory, the old code could also have corrupted Emacs internals,
447 though it'd be very unlikely.
448
449 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
450
451 * character.c (Fcharacterp): Don't advertise optional ignored
452 argument. (Bug#4026)
453
454 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
455
456 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
457 key" (bug#4257).
458
459 * window.c (Fset_window_start): Doc fix (bug#4199).
460 (Fset_window_hscroll): Ditto.
461
462 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
463
464 Fix minor new problems caught by GCC 4.6.1.
465 * term.c (init_tty): Remove unused local.
466 * xsettings.c (store_monospaced_changed): Define this function only
467 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
468 not used otherwise.
469
470 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
471
472 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
473
474 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
475
476 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
477 are the mini-buffer and the echo area (bug#3320).
478
479 * term.c (init_tty): Remove support for supdup, c10 and perq
480 terminals, which are no longer supported (bug#1482).
481
482 2011-07-10 Johan Bockgård <bojohan@gnu.org>
483
484 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
485
486 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
487
488 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
489 for non-popups (Bug#3642).
490
491 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
492
493 * alloc.c (reset_malloc_hooks): Protoize.
494 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
495 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
496 * cm.c (losecursor): Likewise.
497 * data.c (fmod): Likewise.
498 * dispnew.c (swap_glyphs_in_rows): Likewise.
499 * emacs.c (memory_warning_signal): Likewise.
500 * floatfns.c (float_error): Likewise.
501 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
502 (otf_open, font_otf_capability, generate_otf_features)
503 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
504 Likewise.
505 * image.c (pbm_read_file): Likewise.
506 * indent.c (string_display_width): Likewise.
507 * intervals.c (check_for_interval, search_for_interval)
508 (inc_interval_count, count_intervals, root_interval)
509 (adjust_intervals_for_insertion, make_new_interval): Likewise.
510 * lread.c (defalias): Likewise.
511 * ralloc.c (r_alloc_check): Likewise.
512 * regex.c (set_image_of_range_1, set_image_of_range)
513 (regex_grow_registers): Likewise.
514 * sysdep.c (strerror): Likewise.
515 * termcap.c (valid_filename_p, tprint, main): Likewise.
516 * tparam.c (main): Likewise.
517 * unexhp9k800.c (run_time_remap, save_data_space)
518 (update_file_ptrs, read_header, write_header, calculate_checksum)
519 (copy_file, copy_rest, display_header): Likewise.
520 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
521 Likewise.
522 * xdisp.c (check_it): Likewise.
523 * xfaces.c (register_color, unregister_color, unregister_colors):
524 Likewise.
525 * xfns.c (print_fontset_result): Likewise.
526 * xrdb.c (member, fatal, main): Likewise.
527
528 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
529
530 Fix minor problems found by static checking (Bug#9031).
531 * chartab.c (char_table_set_range, map_sub_char_table):
532 Remove unused locals.
533 (uniprop_table): Now static.
534 * composite.c (_work_char): Remove unused static var.
535
536 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
537
538 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
539
540 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
541
542 * gtkutil.c (qttip_cb): Remove code without function.
543
544 2011-07-09 Eli Zaretskii <eliz@gnu.org>
545
546 * w32.c (pthread_sigmask): New stub.
547
548 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
549
550 Use pthread_sigmask, not sigprocmask (Bug#9010).
551 sigprocmask is portable only for single-threaded applications, and
552 Emacs can be multi-threaded when it uses GTK.
553 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
554 (LIBES): Use it.
555 * callproc.c (Fcall_process):
556 * process.c (create_process):
557 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
558 Use pthread_sigmask, not sigprocmask.
559
560 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
561
562 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
563 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
564 wrong (Bug#8591).
565
566 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
567
568 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
569 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
570 (xg_hide_tooltip): Fix comment.
571
572 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
573 in registerServicesMenuSendTypes.
574 (validRequestorForSendType): Don't check ns_return_types.
575
576 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
577 ns_return_type.
578
579 2011-07-08 Jason Rumney <jasonr@gnu.org>
580
581 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
582 frame struct members of non-existent frames (Bug#6284).
583
584 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
585
586 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
587 variable firstTime not needed on OSX >= 10.6.
588 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
589 >= 10.5. Use setKnobProportion, setDoubleValue.
590
591 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
592 (MAC_OS_X_VERSION_10_5): Define if not defined.
593 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
594 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
595 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
596
597 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
598 cString and lossyCString on OSX >= 10.4
599
600 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
601 sizeToFit on OSX >= 10.2.
602
603 * nsimage.m (allocInitFromFile): Don't use deprecated method
604 bestRepresentationForDevice on OSX >= 10.6.
605
606 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
607 to avoid warning.
608
609 * emacs.c: Declare unexec_init_emacs_zone.
610
611 * nsgui.h: Fix compiler warning about gnulib redefining verify.
612
613 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
614
615 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
616 on svcsMenu (Bug#8842).
617
618 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
619 ns_return_types.
620 (Fns_list_services): Just return Qnil on 10.6, code not working there.
621
622 * nsterm.m (QUTF8_STRING): Declare.
623 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
624 (validRequestorForSendType): Return type is (id).
625 Change indexOfObjectIdenticalTo to indexOfObject.
626 Check if we have local selection before returning self (Bug#8842).
627 (writeSelectionToPasteboard): Put local selection into paste board
628 if we have a local selection (Bug#8842).
629 (syms_of_nsterm): DEFSYM QUTF8_STRING.
630
631 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
632 (ns_get_local_selection): Declare.
633
634 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
635
636 * keymap.c (describe_map_tree): Don't insert a double newline at
637 the end of the buffer (bug#1169) and return whether we inserted
638 something.
639
640 * callint.c (Fcall_interactively): Change "reading args" to
641 "providing args" to try to clarify what it does (bug#1010).
642
643 2011-07-07 Kenichi Handa <handa@m17n.org>
644
645 * composite.c (composition_compute_stop_pos): Ignore a static
646 composition starting before CHARPOS (Bug#8915).
647
648 * xdisp.c (handle_composition_prop): Likewise.
649
650 2011-07-07 Eli Zaretskii <eliz@gnu.org>
651
652 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
653 (Bug#9015)
654
655 2011-07-07 Kenichi Handa <handa@m17n.org>
656
657 * character.h (unicode_category_t): New enum type.
658
659 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
660 (Qchar_code_property_table): New variable.
661 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
662 (UNIPROP_COMPRESSED_FORM_P): New macros.
663 (char_table_ascii): Uncompress the compressed values.
664 (sub_char_table_ref): New arg is_uniprop. Callers changed.
665 Uncompress the compressed values.
666 (sub_char_table_ref_and_range): Likewise.
667 (char_table_ref_and_range): Uncompress the compressed values.
668 (sub_char_table_set): New arg is_uniprop. Callers changed.
669 Uncompress the compressed values.
670 (sub_char_table_set_range): Args changed. Callers changed.
671 (char_table_set_range): Adjuted for the above change.
672 (map_sub_char_table): Delete args default_val and parent. Add arg
673 top. Give decoded values to a Lisp function.
674 (map_char_table): Adjusted for the above change. Give decoded
675 values to a Lisp function. Gcpro more variables.
676 (uniprop_table_uncompress)
677 (uniprop_decode_value_run_length): New functions.
678 (uniprop_decoder, uniprop_decoder_count): New variables.
679 (uniprop_get_decoder, uniprop_encode_value_character)
680 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
681 New functions.
682 (uniprop_encoder, uniprop_encoder_count): New variables.
683 (uniprop_get_encoder, uniprop_table)
684 (Funicode_property_table_internal, Fget_unicode_property_internal)
685 (Fput_unicode_property_internal): New functions.
686 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
687 Sunicode_property_table_internal, Sget_unicode_property_internal,
688 and Sput_unicode_property_internal. Defvar_lisp
689 char-code-property-alist.
690
691 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
692 Vunicode_category_table.
693
694 * font.c (font_range): Adjusted for the change of
695 Vunicode_category_table.
696
697 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
698
699 * m/iris4d.h: Remove file, move contents ...
700 * s/irix6-5.h: ... here.
701
702 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
703
704 Remove unportable assumption about struct layout (Bug#8884).
705 * alloc.c (mark_buffer):
706 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
707 (clone_per_buffer_values): Don't assume that
708 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
709 This isn't true in general, and it's particularly not true
710 if Emacs is configured with --with-wide-int.
711 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
712 New macros, used in the buffer.c change.
713
714 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
715
716 * xsettings.c: Use both GConf and GSettings if both are available.
717 (store_config_changed_event): Add comment.
718 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
719 (store_tool_bar_style_changed): New functions.
720 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
721 (struct xsettings): Move font inside HAVE_XFT.
722 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
723 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
724 Move inside HAVE_XFT.
725 (something_changed_gsettingsCB): Renamed from something_changedCB.
726 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
727 also.
728 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
729 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
730 (something_changed_gconfCB): Renamed from something_changedCB.
731 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
732 (parse_settings): Move check for font inside HAVE_XFT.
733 (read_settings, apply_xft_settings): Add comment.
734 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
735 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
736 call store_font_name_changed.
737 (xft_settings_event): Add comment.
738 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
739 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
740 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
741 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
742 (xsettings_initialize): Call init_gsettings last.
743 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
744 comment.
745
746 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
747
748 Random fixes. E.g., (random) never returned negative values.
749 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
750 subseconds part to the entropy, as that's a bit more random.
751 Prefer signed to unsigned, since the signedness doesn't matter and
752 in general we prefer signed. When given a limit, use a
753 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
754 latter isn't right if USE_2_TAGS_FOR_INTS.
755 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
756 not 0..VALMASK. Don't discard "excess" bits that random () returns.
757
758 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
759
760 * textprop.c (text_property_stickiness):
761 Obey Vtext_property_default_nonsticky.
762 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
763 * w32fns.c (syms_of_w32fns):
764 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
765
766 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
767
768 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
769 This is more efficient than Ffile_directory_p and avoids a minor race.
770
771 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
772
773 * buffer.c (Foverlay_put): Say what the return value is
774 (bug#7835).
775
776 * fileio.c (barf_or_query_if_file_exists): Check first if the file
777 is a directory before asking whether to use the file name
778 (bug#7564).
779 (barf_or_query_if_file_exists): Make the "File is a directory"
780 error be more correct.
781
782 * fns.c (Frequire): Remove the mention of the .gz files, since
783 that's installation-specific, but keep the mention of
784 `get-load-suffixes'.
785
786 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
787
788 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
789 Report string overflow if the output is too long.
790
791 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
792
793 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
794 (syms_of_gnutls): Remove duplicate DEFSYM for
795 Qgnutls_bootprop_verify_hostname_error, an error for
796 Qgnutls_bootprop_verify_error (which is no longer used).
797
798 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
799 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
800 Also (re)move comments that are misplaced or no longer relevant.
801
802 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
803
804 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
805
806 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
807
808 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
809 and background color parameters if they have been changed.
810
811 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
812
813 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
814
815 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
816
817 * xsettings.c (SYSTEM_FONT): Define only when used.
818 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
819
820 * keymap.c (access_keymap_1): Now static.
821
822 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
823
824 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
825 leave any prefix arg for the up event (Bug#1586).
826
827 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
828
829 * lread.c (syms_of_lread): Mention single symbols defined by
830 `defvar' or `defconst' (bug#7154).
831
832 * fns.c (Frequire): Mention .el.gz files (bug#7314).
833 (Frequire): Mention get-load-suffixes.
834
835 2011-07-02 Martin Rudalics <rudalics@gmx.at>
836
837 * window.h (window): Remove clone_number slot.
838 * window.c (Fwindow_clone_number, Fset_window_clone_number):
839 Remove.
840 (make_parent_window, make_window, saved_window)
841 (Fset_window_configuration, save_window_save): Don't deal with
842 clone numbers.
843 * buffer.c (Qclone_number): Remove declaration.
844 (sort_overlays, overlay_strings): Don't deal with clone numbers.
845
846 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
847
848 Add multiple inheritance to keymaps.
849 * keymap.c (Fmake_composed_keymap): New function.
850 (Fset_keymap_parent): Simplify.
851 (fix_submap_inheritance): Remove.
852 (access_keymap_1): New function extracted from access_keymap to handle
853 embedded parents and handle lists of maps.
854 (access_keymap): Use it.
855 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
856 (Fcopy_keymap): Handle embedded parents.
857 (Fcommand_remapping, define_as_prefix): Simplify.
858 (Fkey_binding): Simplify.
859 (syms_of_keymap): Move minibuffer-local-completion-map,
860 minibuffer-local-filename-completion-map,
861 minibuffer-local-must-match-map, and
862 minibuffer-local-filename-must-match-map to Elisp.
863 (syms_of_keymap): Defsubr make-composed-keymap.
864 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
865 (parse_menu_item): Trivial simplification.
866
867 2011-07-01 Glenn Morris <rgm@gnu.org>
868
869 * Makefile.in (SETTINGS_LIBS): Fix typo.
870
871 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
872
873 * coding.c (Fencode_coding_string): Record the last coding system
874 used, as the function doc string says (bug#8738).
875
876 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
877
878 * xsettings.c (store_monospaced_changed): Take new font as arg and
879 check for change against current_mono_font.
880 (EMACS_TYPE_SETTINGS): Remove this and related defines.
881 (emacs_settings_constructor, emacs_settings_get_property)
882 (emacs_settings_set_property, emacs_settings_class_init)
883 (emacs_settings_init, gsettings_obj): Remove.
884 (something_changedCB): New function for HAVE_GSETTINGS.
885 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
886 with value as argument.
887 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
888 g_settings_new (Bug#8967). Do not create gsettings_obj.
889 Remove calls to g_settings_bind. Connect something_changedCB to
890 "changed".
891
892 * xgselect.c: Add defined (HAVE_GSETTINGS).
893 (xgselect_initialize): Ditto.
894
895 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
896 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
897 xg_select.
898
899 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
900
901 * eval.c (struct backtrace): Simplify and port the data structure.
902 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
903 signed bit field, as this assumption is not portable and it makes
904 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
905 "char debug_on_exit : 1" as this is not portable either; instead,
906 use the portable "unsigned int debug_on_exit : 1". Remove unused
907 member evalargs. Remove obsolete comments about cc bombing out.
908
909 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
910
911 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
912 Let HAVE_GSETTINGS override HAVE_GCONF.
913 (store_monospaced_changed): New function.
914 (EMACS_SETTINGS): A new type derived from GObject to handle
915 GSettings notifications.
916 (emacs_settings_constructor, emacs_settings_get_property)
917 (emacs_settings_set_property, emacs_settings_class_init):
918 New functions.
919 (gsettings_client, gsettings_obj): New variables.
920 (GSETTINGS_SCHEMA): New define.
921 (something_changedCB): Call store_monospaced_changed.
922 (init_gsettings): New function.
923 (xsettings_initialize): Call init_gsettings.
924 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
925 to NULL.
926
927 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
928 GCONF_CFLAGS/LIBS.
929
930 2011-06-29 Martin Rudalics <rudalics@gmx.at>
931
932 * window.c (resize_root_window, grow_mini_window)
933 (shrink_mini_window): Rename Qresize_root_window to
934 Qwindow_resize_root_window and Qresize_root_window_vertically to
935 Qwindow_resize_root_window_vertically.
936
937 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
938
939 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
940
941 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
942
943 * makefile.w32-in: Redesign dependencies so they reflect more
944 clearly which files are directly included by each source file,
945 and not through other includes.
946
947 2011-06-27 Martin Rudalics <rudalics@gmx.at>
948
949 * buffer.c (Qclone_number): Declare static and DEFSYM it.
950 (sort_overlays, overlay_strings): When an overlay's clone number
951 matches the window's clone number process the overlay even if
952 the overlay's window property doesn't match the current window.
953
954 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
955 (Fwindow_hchild): Rename to Fwindow_left_child.
956 (Fwindow_next): Rename to Fwindow_next_sibling.
957 (Fwindow_prev): Rename to Fwindow_prev_sibling.
958 (resize_window_check): Rename to window_resize_check.
959 (resize_window_apply): Rename to window_resize_apply.
960 (Fresize_window_apply): Rename to Fwindow_resize_apply.
961 (Fdelete_other_windows_internal, resize_frame_windows)
962 (Fsplit_window_internal, Fdelete_window_internal)
963 (grow_mini_window, shrink_mini_window)
964 (Fresize_mini_window_internal): Fix callers accordingly.
965
966 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
967
968 * emacsgtkfixed.h: State that this is only used with Gtk+3.
969 (emacs_fixed_set_min_size): Remove.
970 (emacs_fixed_new): Take frame as argument.
971
972 * emacsgtkfixed.c: State that this is only used with Gtk+3.
973 (_EmacsFixedPrivate): Remove minwidth/height.
974 Add struct frame *f.
975 (emacs_fixed_init): Initialize priv->f.
976 (get_parent_class, emacs_fixed_set_min_size): Remove.
977 (emacs_fixed_new): Set priv->f to argument.
978 (emacs_fixed_get_preferred_width)
979 (emacs_fixed_get_preferred_height): Use min_width/height from
980 frames size_hint to set minimum and natural (Bug#8919).
981 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
982 and use min_width/height from frames size_hint to set
983 min_width/height (Bug#8919).
984
985 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
986 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
987 Fix indentation.
988
989 2011-06-26 Eli Zaretskii <eliz@gnu.org>
990
991 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
992 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
993 called at ZV.
994
995 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
996
997 * process.c (wait_reading_process_output): Bypass select if
998 waiting for a cell while ignoring keyboard input, and input is
999 pending. Suggested by Jan Djärv (Bug#8869).
1000
1001 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1002
1003 Use gnulib's dup2 module instead of rolling our own.
1004 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1005
1006 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1007
1008 * dispnew.c (scrolling_window): Before scrolling, turn off a
1009 mouse-highlight in the window being scrolled.
1010
1011 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1012
1013 Move DEFSYM to lisp.h and use everywhere.
1014
1015 * character.h (DEFSYM): Move declaration...
1016 * lisp.h (DEFSYM): ...here.
1017
1018 * gnutls.c:
1019 * minibuf.c:
1020 * w32menu.c:
1021 * w32proc.c:
1022 * w32select.c: Don't include character.h.
1023
1024 * alloc.c (syms_of_alloc):
1025 * buffer.c (syms_of_buffer):
1026 * bytecode.c (syms_of_bytecode):
1027 * callint.c (syms_of_callint):
1028 * casefiddle.c (syms_of_casefiddle):
1029 * casetab.c (init_casetab_once):
1030 * category.c (init_category_once, syms_of_category):
1031 * ccl.c (syms_of_ccl):
1032 * cmds.c (syms_of_cmds):
1033 * composite.c (syms_of_composite):
1034 * dbusbind.c (syms_of_dbusbind):
1035 * dired.c (syms_of_dired):
1036 * dispnew.c (syms_of_display):
1037 * doc.c (syms_of_doc):
1038 * editfns.c (syms_of_editfns):
1039 * emacs.c (syms_of_emacs):
1040 * eval.c (syms_of_eval):
1041 * fileio.c (syms_of_fileio):
1042 * fns.c (syms_of_fns):
1043 * frame.c (syms_of_frame):
1044 * fringe.c (syms_of_fringe):
1045 * insdel.c (syms_of_insdel):
1046 * keymap.c (syms_of_keymap):
1047 * lread.c (init_obarray, syms_of_lread):
1048 * macros.c (syms_of_macros):
1049 * msdos.c (syms_of_msdos):
1050 * print.c (syms_of_print):
1051 * process.c (syms_of_process):
1052 * search.c (syms_of_search):
1053 * sound.c (syms_of_sound):
1054 * syntax.c (init_syntax_once, syms_of_syntax):
1055 * terminal.c (syms_of_terminal):
1056 * textprop.c (syms_of_textprop):
1057 * undo.c (syms_of_undo):
1058 * w32.c (globals_of_w32):
1059 * window.c (syms_of_window):
1060 * xdisp.c (syms_of_xdisp):
1061 * xfaces.c (syms_of_xfaces):
1062 * xfns.c (syms_of_xfns):
1063 * xmenu.c (syms_of_xmenu):
1064 * xsettings.c (syms_of_xsettings):
1065 * xterm.c (syms_of_xterm): Use DEFSYM.
1066
1067 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1068
1069 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1070
1071 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Integer and buffer overflow fixes (Bug#8873).
1074
1075 * print.c (printchar, strout): Check for string overflow.
1076 (PRINTPREPARE, printchar, strout):
1077 Don't set size unless allocation succeeds.
1078
1079 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1080 for sizes. Check for string overflow more accurately.
1081 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1082
1083 * macros.c: Integer and buffer overflow fixes.
1084 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1085 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1086 Use ptrdiff_t, not int, for sizes.
1087 Don't increment bufsize until after realloc succeeds.
1088 Check for size-calculation overflow.
1089 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1090
1091 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1092
1093 * lread.c: Integer overflow fixes.
1094 (read_integer): Radix is now EMACS_INT, not int,
1095 to improve quality of diagnostics for out-of-range radices.
1096 Calculate buffer size correctly for out-of-range radices.
1097 (read1): Check for integer overflow in radices, and in
1098 read-circle numbers.
1099 (read_escape): Avoid int overflow.
1100 (Fload, openp, read_buffer_size, read1)
1101 (substitute_object_recurse, read_vector, read_list, map_obarray):
1102 Use ptrdiff_t, not int, for sizes.
1103 (read1): Use EMACS_INT, not int, for sizes.
1104 Check for size overflow.
1105
1106 * image.c (cache_image): Check for size arithmetic overflow.
1107
1108 * lread.c: Integer overflow issues.
1109 (saved_doc_string_size, saved_doc_string_length)
1110 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1111 Now ptrdiff_t, not int.
1112 (read1): Don't assume doc string length fits in int. Check for
1113 out-of-range doc string lengths.
1114 (read_list): Don't assume file position fits in int.
1115 (read_escape): Check for hex character overflow.
1116
1117 2011-06-22 Leo Liu <sdl.web@gmail.com>
1118
1119 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1120 Move to minibuffer.el.
1121
1122 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1125 The following patches are for when GLYPH_DEBUG && !XASSERT.
1126 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1127 * dispnew.c (flush_stdout):
1128 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1129 Mark as externally visible.
1130 * dispnew.c (check_window_matrix_pointers): Now static.
1131 * dispnew.c (window_to_frame_vpos):
1132 * xfns.c (unwind_create_frame):
1133 * xterm.c (x_check_font): Remove unused local.
1134 * scroll.c (CHECK_BOUNDS):
1135 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1136 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1137 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1138 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1139 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1140 Now static.
1141 (debug_method_add): Use va_list and vsprintf rather than relying
1142 on undefined behavior with wrong number of arguments.
1143 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1144 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1145 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1146 since we're not interested in debugging glyphs with old libraries.
1147 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1148 GCC 4.6.0's static checking.
1149
1150 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Integer overflow and signedness fixes (Bug#8873).
1153 A few related buffer overrun fixes, too.
1154
1155 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1156
1157 * dispextern.h (struct face.stipple):
1158 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1159 (x_bitmap_mask, x_allocate_bitmap_record)
1160 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1161 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1162 (x_create_bitmap_from_xpm_data):
1163 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1164 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1165 (.bitmaps_last):
1166 * xfaces.c (load_pixmap):
1167 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1168 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1169 (.bitmaps_last, struct x_output.icon_bitmap):
1170 Use ptrdiff_t, not int, for bitmap indexes.
1171 (x_allocate_bitmap_record): Check for size overflow.
1172 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1173
1174 Use ptrdiff_t, not int, for overlay counts.
1175 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1176 * editfns.c (overlays_around, get_pos_property):
1177 * textprop.c (get_char_property_and_overlay):
1178 * xdisp.c (next_overlay_change, note_mouse_highlight):
1179 * xfaces.c (face_at_buffer_position):
1180 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1181 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1182 (Fnext_overlay_change, Fprevious_overlay_change)
1183 (mouse_face_overlay_overlaps, Foverlays_in):
1184 Use ptrdiff_t, not int, for sizes.
1185 (overlays_at, overlays_in): Check for size-calculation overflow.
1186
1187 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1188
1189 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1190 (x_session_initialize): Do not assume string length fits in int.
1191
1192 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1193 This is unlikely, but can occur if DPI is outlandish.
1194
1195 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1196 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1197
1198 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1199 * xrdb.c (magic_file_p, search_magic_path):
1200 Omit last arg SUFFIX; it was always 0. All callers changed.
1201 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1202
1203 * xfont.c (xfont_match): Avoid need for strlen.
1204
1205 * xfns.c: Don't assume strlen fits in int.
1206 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1207
1208 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1209 not unsigned long, as we prefer signed integers. All callers changed.
1210 Detect integer overflow in repeat count.
1211 (message_dolog): Don't assume print length fits in 39 bytes.
1212 (display_mode_element): Don't assume strlen fits in int.
1213
1214 * termcap.c: Don't assume sizes fit in int and never overflow.
1215 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1216 (gobble_line): Check for size-calculation overflow.
1217
1218 * minibuf.c (Fread_buffer):
1219 * lread.c (intern, intern_c_string):
1220 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1221 Don't assume string length fits in int.
1222
1223 * keyboard.c (parse_tool_bar_item):
1224 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1225
1226 * font.c: Don't assume string length fits in int.
1227 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1228 Use ptrdiff_t, not int.
1229 (font_intern_prop): Don't assume string length fits in int.
1230 Don't assume integer property fits in fixnum.
1231 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1232
1233 * filelock.c: Fix some buffer overrun and integer overflow issues.
1234 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1235 Reformulate so as not to need the command string.
1236 Invoke gzip -cd rather than gunzip, as it's more portable.
1237 (lock_info_type, lock_file_1, lock_file):
1238 Don't assume pid_t and time_t fit in unsigned long.
1239 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1240 (current_lock_owner): Prefer signed type for sizes.
1241 Use memcpy, not strncpy, where memcpy is what is really wanted.
1242 Don't assume (via atoi) that time_t and pid_t fit in int.
1243 Check for time_t and/or pid_t out of range, e.g., via a network share.
1244 Don't alloca where an auto var works fine.
1245
1246 * fileio.c: Fix some integer overflow issues.
1247 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1248 Don't assume string length fits in int.
1249 (directory_file_name): Don't assume string length fits in long.
1250 (make_temp_name): Don't assume pid fits in int, or that its print
1251 length is less than 20.
1252
1253 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1254
1255 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1256
1257 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1258
1259 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1260 We prefer signed integers, even for size calculations.
1261
1262 * emacs.c: Don't assume string length fits in 'int'.
1263 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1264 (main): Don't invoke strlen when not needed.
1265
1266 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1267 (XD_DEBUG_MESSAGE): Don't waste a byte.
1268
1269 * callproc.c (getenv_internal_1, getenv_internal)
1270 (Fgetenv_internal):
1271 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1272
1273 * lread.c (invalid_syntax): Omit length argument.
1274 All uses changed. This doesn't fix a bug, but it simplifies the
1275 code away from its former Hollerith-constant appearance, and it's
1276 one less 'int' to worry about when looking at integer-overflow issues.
1277 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1278
1279 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1280 This didn't break anything, but it didn't help either.
1281 It's confusing to put a bogus integer in a place where the actual
1282 value does not matter.
1283 (LIST_END_P): Remove unused macro and its bogus comment.
1284 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1285
1286 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1287 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1288 implementation.
1289 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1290 We prefer signed types, and the value cannot exceed the EMACS_INT
1291 range anyway (because otherwise the length would not be representable).
1292 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1293 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1294 This avoids a GCC warning when WIDE_EMACS_INT.
1295
1296 * indent.c (sane_tab_width): New function.
1297 (current_column, scan_for_column, Findent_to, position_indentation)
1298 (compute_motion): Use it. This is just for clarity.
1299 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1300
1301 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1302
1303 * lisp.h (lint_assume): New macro.
1304 * composite.c (composition_gstring_put_cache):
1305 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1306
1307 * editfns.c, insdel.c:
1308 Omit unnecessary forward decls, to simplify future changes.
1309
1310 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1311
1312 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1313
1314 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1315 Use much-faster test for byte-length change.
1316 Don't assume string byte-length fits in 'int'.
1317 Check that character arg fits in 'int'.
1318 (mapcar1): Declare byte as byte, for clarity.
1319
1320 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1321
1322 * fns.c (concat): Catch string overflow earlier.
1323 Do not rely on integer wraparound.
1324
1325 * dispextern.h (struct it.overlay_strings_charpos)
1326 (struct it.selective): Now EMACS_INT, not int.
1327 * xdisp.c (forward_to_next_line_start)
1328 (back_to_previous_visible_line_start)
1329 (reseat_at_next_visible_line_start, next_element_from_buffer):
1330 Don't arbitrarily truncate the value of 'selective' to int.
1331
1332 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1333
1334 * composite.c: Don't truncate sizes to 'int'.
1335 (composition_gstring_p, composition_reseat_it)
1336 (composition_adjust_point): Use EMACS_INT, not int.
1337 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1338 not EMACS_UINT, for indexes.
1339
1340 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1341
1342 * buffer.c: Include <verify.h>.
1343 (struct sortvec.priority, struct sortstr.priority):
1344 Now EMACS_INT, not int.
1345 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1346 (struct sortstr.size, record_overlay_string)
1347 (struct sortstrlist.size, struct sortlist.used):
1348 Don't truncate size to int.
1349 (record_overlay_string): Check for size-calculation overflow.
1350 (init_buffer_once): Check at compile-time, not run-time.
1351
1352 2011-06-22 Jim Meyering <meyering@redhat.com>
1353
1354 Don't leak an XBM-image-sized buffer
1355 * image.c (xbm_load): Free the image buffer after using it.
1356
1357 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Port to Sun C.
1360 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1361 that Sun C diagnosed.
1362 * fns.c (secure_hash): Fix pointer signedness issue.
1363 * intervals.c (static_offset_intervals): New function.
1364 (offset_intervals): Use it.
1365
1366 2011-06-21 Leo Liu <sdl.web@gmail.com>
1367
1368 * deps.mk (fns.o):
1369 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1370 sha512.h.
1371
1372 * fns.c (secure_hash): Rename from crypto_hash_function and change
1373 the first arg to accept symbols.
1374 (Fsecure_hash): New primitive.
1375 (syms_of_fns): New symbols.
1376
1377 2011-06-20 Deniz Dogan <deniz@dogan.se>
1378
1379 * process.c (Fset_process_buffer): Clarify return value in
1380 docstring.
1381
1382 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1383
1384 * dispnew.c (add_window_display_history): Use BVAR.
1385
1386 * xdisp.c (debug_method_add): Use BVAR.
1387 (check_window_end, dump_glyph_matrix, dump_glyph)
1388 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1389
1390 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1391 Likewise.
1392
1393 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1394 check till after the cache is created in init_frame_faces.
1395
1396 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1397
1398 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1399
1400 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1401
1402 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1403 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1404 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1405
1406 Improve buffer-overflow checking (Bug#8873).
1407 * fileio.c (Finsert_file_contents):
1408 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1409 Remove the old (too-loose) buffer overflow checks.
1410 They weren't needed, since make_gap checks for buffer overflow.
1411 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1412 The old code merely checked for Emacs fixnum overflow, and relied
1413 on undefined (wraparound) behavior. The new code avoids undefined
1414 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1415
1416 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1417 Tune. Don't use wider integers than needed. Don't use alloca.
1418 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1419
1420 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1421
1422 * insdel.c, lisp.h (buffer_overflow): New function.
1423 (insert_from_buffer_1, replace_range, replace_range_2):
1424 * insdel.c (make_gap_larger):
1425 * editfns.c (Finsert_char):
1426 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1427
1428 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1429
1430 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 Integer overflow and signedness fixes (Bug#8873).
1433
1434 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1435 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1436
1437 * fileio.c: Don't assume EMACS_INT fits in off_t.
1438 (emacs_lseek): New static function.
1439 (Finsert_file_contents, Fwrite_region): Use it.
1440 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1441
1442 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1443
1444 * fns.c: Don't overflow int when computing a list length.
1445 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1446 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1447 truncation on 64-bit hosts. Check for QUIT every
1448 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1449 faster and is responsive enough.
1450 (Flength): Report an error instead of overflowing an integer.
1451 (Fsafe_length): Return a float if the value is not representable
1452 as a fixnum. This shouldn't happen except in contrived situations.
1453 (Fnthcdr, Fsort): Don't assume list length fits in int.
1454 (Fcopy_sequence): Don't assume vector length fits in int.
1455
1456 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1457 (header_size, word_size): New constants.
1458 (allocate_vectorlike): Don't check size overflow here.
1459 (allocate_vector): Check it here instead, since this is the only
1460 caller of allocate_vectorlike that could cause overflow.
1461 Check that the new vector's length is representable as a fixnum.
1462
1463 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1464 The previous code was bogus. For example, next_almost_prime (32)
1465 returned 39, which is undesirable as it is a multiple of 3; and
1466 next_almost_prime (24) returned 25, which is a multiple of 5 so
1467 why was the code bothering to check for multiples of 7?
1468
1469 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1470
1471 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1472
1473 Variadic C functions now count arguments with ptrdiff_t.
1474 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1475 Back then I didn't know that the Emacs coding style prefers signed int.
1476 Also, in the meantime I found a few more instances where arguments
1477 were being counted with int, which may truncate counts on 64-bit
1478 machines, or EMACS_INT, which may be unnecessarily wide.
1479 * lisp.h (struct Lisp_Subr.function.aMANY)
1480 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1481 Arg counts are now ptrdiff_t, not size_t.
1482 All variadic functions and their callers changed accordingly.
1483 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1484 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1485 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1486 * callint.c (Fcall_interactively): Check arg count for overflow,
1487 to avoid potential buffer overrun. Use signed char, not 'int',
1488 for 'varies' array, so that we needn't bother to check its size
1489 calculation for overflow.
1490 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1491 * eval.c (apply_lambda):
1492 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1493 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1494 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1495
1496 * callint.c (Fcall_interactively): Don't use index var as event count.
1497
1498 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1499 * mem-limits.h (SIZE): Remove; no longer used.
1500
1501 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1502
1503 Remove unnecessary casts.
1504 * xterm.c (x_term_init):
1505 * xfns.c (x_set_border_pixel):
1506 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1507 These aren't needed now that we assume ANSI C.
1508
1509 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1510 It's more likely to cause problems (due to unsigned overflow)
1511 than to cure them.
1512
1513 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1514
1515 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1516
1517 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1518
1519 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1520
1521 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1522
1523 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1524
1525 GLYPH_CODE_FACE returns EMACS_INT, not int.
1526 * dispextern.h (merge_faces):
1527 * xfaces.c (merge_faces):
1528 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1529 Don't assume EMACS_INT fits in int.
1530
1531 * character.h (CHAR_VALID_P): Remove unused parameter.
1532 * fontset.c, lisp.h, xdisp.c: All uses changed.
1533
1534 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1535
1536 * fns.c (concat): Minor tuning based on overflow analysis.
1537 This doesn't fix any bugs. Use int to hold character, instead
1538 of constantly refetching from Emacs object. Use XFASTINT, not
1539 XINT, for value known to be a character. Don't bother comparing
1540 a single byte to 0400, as it's always less.
1541
1542 * floatfns.c (Fexpt):
1543 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1544
1545 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1546 for characters.
1547
1548 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1549
1550 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1551 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1552 incorrectly succeed when S was a string, because 4294967386 was
1553 truncated before it was used.
1554
1555 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1556 Otherwise, an out-of-range integer could cause undefined behavior
1557 on a 64-bit host.
1558
1559 * composite.c: Use int, not EMACS_INT, for characters.
1560 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1561 EMACS_INT, for values that are known to be in character range.
1562 This doesn't fix any bugs but is the usual style inside Emacs and
1563 may generate better code on 32-bit machines.
1564
1565 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1566 This is for reasons similar to the recent CHAR_STRING fix.
1567 * charset.c (Fencode_char): Check that character arg is actually
1568 a character. Pass an int to ENCODE_CHAR.
1569 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1570 wider than 'int', as a compile-time check to prevent future regressions
1571 in this area.
1572
1573 * character.c (char_string): Remove unnecessary casts.
1574
1575 Make sure a 64-bit char is never passed to CHAR_STRING.
1576 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1577 by silently ignoring the top 32 bits, allowing some values
1578 that were far too large to be valid characters.
1579 * character.h: Include <verify.h>.
1580 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1581 arguments are no wider than unsigned, as a compile-time check
1582 to prevent future regressions in this area.
1583 * data.c (Faset):
1584 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1585 (Fsubst_char_in_region):
1586 * fns.c (concat):
1587 * xdisp.c (decode_mode_spec_coding):
1588 Adjust to CHAR_STRING's new requirement.
1589 * editfns.c (Finsert_char, Fsubst_char_in_region):
1590 * fns.c (concat): Check that character args are actually
1591 characters. Without this test, these functions did the wrong
1592 thing with wildly out-of-range values on 64-bit hosts.
1593
1594 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1595 These casts should not be needed on 32-bit hosts, either.
1596 * keyboard.c (read_char):
1597 * lread.c (Fload): Remove casts to unsigned.
1598
1599 * lisp.h (UNSIGNED_CMP): New macro.
1600 This fixes comparison bugs on 64-bit hosts.
1601 (ASCII_CHAR_P): Use it.
1602 * casefiddle.c (casify_object):
1603 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1604 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1605 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1606 * dispextern.h (FACE_FROM_ID):
1607 * keyboard.c (read_char): Use UNSIGNED_CMP.
1608
1609 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1610 not to EMACS_INT, to avoid GCC warning.
1611
1612 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1613
1614 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1615 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1616 isn't needed on 32-bit machines.
1617
1618 * buffer.c (Fgenerate_new_buffer_name):
1619 Use EMACS_INT for count, not int.
1620 (advance_to_char_boundary): Return EMACS_INT, not int.
1621
1622 * data.c (Qcompiled_function): Now static.
1623
1624 * window.c (window_body_lines): Now static.
1625
1626 * image.c (gif_load): Rename local to avoid shadowing.
1627
1628 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1629 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1630 * alloc.c (make_save_value): Integer argument is now of type
1631 ptrdiff_t, not int.
1632 (mark_object): Use ptrdiff_t, not int.
1633 * lisp.h (pD): New macro.
1634 * print.c (print_object): Use it.
1635
1636 * alloc.c: Use EMACS_INT, not int, to count objects.
1637 (total_conses, total_markers, total_symbols, total_vector_size)
1638 (total_free_conses, total_free_markers, total_free_symbols)
1639 (total_free_floats, total_floats, total_free_intervals)
1640 (total_intervals, total_strings, total_free_strings):
1641 Now EMACS_INT, not int. All uses changed.
1642 (Fgarbage_collect): Compute overall total using a double, so that
1643 integer overflow is less likely to be a problem. Check for overflow
1644 when converting back to an integer.
1645 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1646 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1647 These were 'int' variables that could overflow on 64-bit hosts;
1648 they were never used, so remove them instead of repairing them.
1649 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1650 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1651 Previously, this ceilinged at INT_MAX, but that doesn't work on
1652 64-bit machines.
1653 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1654
1655 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1656 (allocate_vectorlike): Check for ptrdiff_t overflow.
1657 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1658 when a (possibly-narrower) signed value would do just as well.
1659 We prefer using signed arithmetic, to avoid comparison confusion.
1660
1661 * alloc.c: Catch some string size overflows that we were missing.
1662 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1663 for convenience in STRING_BYTES_MAX.
1664 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1665 The definition here is exact; the one in lisp.h was approximate.
1666 (allocate_string_data): Check for string overflow. This catches
1667 some instances we weren't catching before. Also, it catches
1668 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1669 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1670 and ptrdiff_t and EMACS_INT are both 64 bits.
1671
1672 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1673 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1674 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1675
1676 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1677
1678 * alloc.c (Fmake_string): Check for out-of-range init.
1679
1680 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1681
1682 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1683
1684 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1685
1686 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1687 xg_get_default_scrollbar_width.
1688
1689 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1690 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1691 (style_changed_cb): Call update_theme_scrollbar_width and call
1692 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1693 all frames (Bug#8505).
1694 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1695 Call gtk_window_set_resizable if HAVE_GTK3.
1696 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1697 and height if HAVE_GTK3 (Bug#8505).
1698 (scroll_bar_width_for_theme): New variable.
1699 (update_theme_scrollbar_width): New function.
1700 (xg_get_default_scrollbar_width): Move code to
1701 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1702 (xg_initialize): Call update_theme_scrollbar_width.
1703
1704 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1705
1706 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1707
1708 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1709
1710 * frame.c (make_frame): Call other_buffer_safely instead of
1711 other_buffer.
1712
1713 * window.c (temp_output_buffer_show): Call display_buffer with
1714 second argument Vtemp_buffer_show_specifiers and reset latter
1715 immediately after the call.
1716 (Vtemp_buffer_show_specifiers): New variable.
1717 (auto_window_vscroll_p, next_screen_context_lines)
1718 (Vscroll_preserve_screen_position): Remove leading asterisks from
1719 doc-strings.
1720
1721 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 Fix minor problems found by GCC 4.6.0 static checking.
1724 * buffer.c (Qclone_number): Remove for now, as it's unused.
1725 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1726 (record_buffer): Remove unused local.
1727 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1728 (set_frame_buffer_list): Remove; unused.
1729 * frame.h (other_visible_frames): Remove decl.
1730 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1731 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1732 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1733 if HAVE_GPM.
1734 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1735 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1736 Define only if HAVE_GPM.
1737 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1738 (update_hints_inhibit): Remove; never set. All uses removed.
1739 * widgetprv.h (emacsFrameClassRec): Remove decl.
1740 * window.c (delete_deletable_window): Now returns void, since it
1741 wasn't returning anything.
1742 (compare_window_configurations): Remove unused locals.
1743 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1744 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1745 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1746 the same widths as pointers. This follows up on the 2011-05-06 patch.
1747 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1748 * xterm.h: Likewise.
1749 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1750
1751 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * makefile.w32-in: Update dependencies.
1754 (LISP_H): Add lib/intprops.h.
1755
1756 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * image.c (gif_load): Add animation frame delay to the metadata.
1759 (syms_of_image): Use DEFSYM. New symbol `delay'.
1760
1761 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1762
1763 * window.c (delete_deletable_window): Re-add.
1764 (Fset_window_configuration): Rewrite to handle dead buffers and
1765 consequently deletable windows.
1766 (window_tree, Fwindow_tree): Remove. Supply functionality in
1767 window.el.
1768 (compare_window_configurations): Simplify code.
1769
1770 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * image.c (imagemagick_load_image): Fix type mismatch.
1773 (Fimagemagick_types): Likewise.
1774
1775 * window.h (replace_buffer_in_windows): Declare.
1776
1777 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1778
1779 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1780 Qclone_number. Remove external declaration of Qdelete_window.
1781 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1782 code.
1783 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1784 Qbuffer_list_update_hook if allowed.
1785 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1786 buffer list implementation.
1787 (other_buffer_safely): New function.
1788 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1789 calls to replace_buffer_in_windows and
1790 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1791 if allowed.
1792 (record_buffer): Inhibit quitting and rewrite using quittable
1793 functions. Run Qbuffer_list_update_hook if allowed.
1794 (Frecord_buffer, Funrecord_buffer): New functions.
1795 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1796 switch-to-buffer to window.el.
1797 (bury-buffer): Move to window.el.
1798 (Vbuffer_list_update_hook): New variable.
1799
1800 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1801 section.
1802
1803 * window.h (resize_frame_windows): Move up in code.
1804 (Fwindow_frame): Remove EXFUN.
1805 (replace_buffer_in_all_windows): Remove prototype.
1806 (replace_buffer_in_windows_safely): Add prototype.
1807
1808 * window.c: Declare Qdelete_window static again. Move down
1809 declaration of select_count.
1810 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1811 (Fother_window): Move to window.el.
1812 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1813 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1814 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1815 window.el.
1816 (replace_buffer_in_windows): Implement by calling
1817 Qreplace_buffer_in_windows.
1818 (replace_buffer_in_all_windows): Remove with some functionality
1819 moved into replace_buffer_in_windows_safely.
1820 (replace_buffer_in_windows_safely): New function.
1821 (select_window_norecord, select_frame_norecord): Move in front
1822 of run_window_configuration_change_hook. Remove now obsolete
1823 declarations.
1824 (Fset_window_buffer): Rewrite doc-string. Call
1825 Qrecord_window_buffer.
1826 (keys_of_window): Move binding for other-window to window.el.
1827
1828 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * dispextern.h (struct image): Replace data member, whose int_val
1831 and ptr_val fields were not used by anything, with a single
1832 lisp_val object.
1833
1834 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1835 (gif_clear_image, gif_load, imagemagick_load_image)
1836 (gs_clear_image, gs_load): Callers changed.
1837
1838 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * buffer.h: Include <time.h>, for time_t.
1841 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1842
1843 Fix minor problems found by static checking.
1844
1845 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1846
1847 Make identifiers static if they are not used in other modules.
1848 * data.c (Qcompiled_function, Qframe, Qvector):
1849 * image.c (QimageMagick, Qsvg):
1850 * minibuf.c (Qmetadata):
1851 * window.c (resize_window_check, resize_root_window): Now static.
1852 * window.h (resize_window_check, resize_root_window): Remove decls.
1853
1854 * window.c (window_deletion_count, delete_deletable_window):
1855 Remove; unused.
1856 (window_body_lines): Now static.
1857 (Fdelete_other_windows_internal): Mark vars as initialized.
1858 Make sure 'resize_failed' is initialized.
1859 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1860 (resize_window_apply): Remove unused local.
1861 * window.h (delete_deletable_window): Remove decl.
1862
1863 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1864 (imagemagick_load_image): Fix pointer signedness problem by changing
1865 last arg from unsigned char * to char *. All uses changed.
1866 Also, fix a local for similar reasons.
1867 Remove unused locals. Remove locals to avoid shadowing.
1868 (fn_rsvg_handle_free): Remove; unused.
1869 (svg_load, svg_load_image): Fix pointer signedness problem.
1870 (imagemagick_load_image): Don't use garbage pointer image_wand.
1871
1872 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1873
1874 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1875
1876 * image.c (gif_load): Fix omitted cast error introduced by
1877 2011-06-06 change.
1878
1879 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1880
1881 * window.h (resize_proportionally, orig_total_lines)
1882 (orig_top_line): Remove from window structure.
1883 (set_window_height, set_window_width, change_window_heights)
1884 (Fdelete_window): Remove prototypes.
1885 (resize_frame_windows): Remove duplicate declaration.
1886
1887 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1888
1889 * window.h (resize_frame_windows, resize_window_check)
1890 (delete_deletable_window, resize_root_window)
1891 (resize_frame_windows): Declare prototypes.
1892
1893 * window.c (resize_window_apply): Make definition be "static" to
1894 match the prototype.
1895
1896 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1897
1898 * window.c: Remove declarations of Qwindow_size_fixed,
1899 window_min_size_1, window_min_size_2, window_min_size,
1900 size_window, window_fixed_size_p, enlarge_window, delete_window.
1901 Remove static from declaration of Qdelete_window, it's
1902 temporarily needed by Fbury_buffer.
1903 (replace_window): Don't assign orig_top_line and
1904 orig_total_lines.
1905 (Fdelete_window, delete_window): Remove. Window deletion is
1906 handled by window.el.
1907 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1908 Fdelete_window calls with calls to Qdelete_window.
1909 (Fdelete_other_windows): Remove. Deleting other windows is
1910 handled by window.el.
1911 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1912 handled in window.el.
1913 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1914 Window minimum sizes are handled in window.el.
1915 (shrink_windows, size_window, set_window_height)
1916 (set_window_width, change_window_heights, window_height)
1917 (window_width, CURBEG, CURSIZE, enlarge_window)
1918 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1919 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1920 handled in window.el.
1921 (make_dummy_parent): Rename to make_parent_window and give it a
1922 second argument horflag.
1923 (make_window): Don't set resize_proportionally any more.
1924 (Fsplit_window): Remove. Windows are split in window.el.
1925 (save_restore_action, save_restore_orig_size)
1926 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1927 Resize mini windows in window.el.
1928 (grow_mini_window, shrink_mini_window): Implement by calling
1929 Qresize_root_window_vertically, resize_window_check and
1930 resize_window_apply.
1931 (saved_window, Fset_window_configuration, save_window_save): Do
1932 not handle orig_top_line, orig_total_lines, and
1933 resize_proportionally.
1934 (window_min_height, window_min_width): Move to window.el.
1935 (keys_of_window): Move bindings for delete-other-windows,
1936 split-window, delete-window and enlarge-window to window.el.
1937
1938 * buffer.c: Temporarily extern Qdelete_window.
1939 (Fbury_buffer): Temporarily call Qdelete_window instead of
1940 Fdelete_window (Fbury_buffer will move to window.el soon).
1941
1942 * frame.c (set_menu_bar_lines_1): Remove code handling
1943 orig_top_line and orig_total_lines.
1944
1945 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1946 set_window_height but set heights directly.
1947 (change_frame_size_1): Use resize_frame_windows.
1948
1949 * xdisp.c (init_xdisp): Don't use set_window_height but set
1950 heights directly.
1951
1952 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1953 resize_frame_windows instead of change_window_heights and run
1954 run_window_configuration_change_hook.
1955
1956 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1957 instead of change_window_heights and run
1958 run_window_configuration_change_hook.
1959
1960 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1961
1962 * window.c (replace_window): Rename second argument REPLACEMENT to
1963 NEW. New third argument SETFLAG. Rewrite.
1964 (delete_window, make_dummy_parent): Call replace_window with
1965 third argument 1.
1966 (window_list_1): Move down in code.
1967 (run_window_configuration_change_hook): Move set_buffer part
1968 before select_frame_norecord part in order to unwind correctly.
1969 Rename count1 to count.
1970 (recombine_windows, delete_deletable_window, resize_root_window)
1971 (Fdelete_other_windows_internal)
1972 (Frun_window_configuration_change_hook, make_parent_window)
1973 (resize_window_check, resize_window_apply, Fresize_window_apply)
1974 (resize_frame_windows, Fsplit_window_internal)
1975 (Fdelete_window_internal, Fresize_mini_window_internal): New
1976 functions.
1977 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1978
1979 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1980
1981 * window.h (window): Add some new members to window structure -
1982 normal_lines, normal_cols, new_total, new_normal, clone_number,
1983 splits, nest, prev_buffers, next_buffers.
1984 (WINDOW_TOTAL_SIZE): Move here from window.c.
1985 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1986
1987 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1988 Remove.
1989 (make_dummy_parent): Set new members of windows structure.
1990 (make_window): Move down in code. Handle new members of window
1991 structure.
1992 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1993 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1994 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1995 (Fset_window_prev_buffers, Fwindow_next_buffers)
1996 (Fset_window_next_buffers, Fset_window_clone_number): New
1997 functions.
1998 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1999 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2000 Doc-string fixes.
2001 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2002 Argument WINDOW can be now internal window too.
2003 (Fwindow_use_time): Move up in code.
2004 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2005 Rewrite doc-string.
2006 (Fset_window_configuration, saved_window)
2007 (Fcurrent_window_configuration, save_window_save): Handle new
2008 members of window structure.
2009 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2010 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2011 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2012 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2013 Qget_mru_window, Qresize_root_window,
2014 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2015 Qauto_buffer_name; staticpro them.
2016
2017 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2018
2019 * window.c (Fwindow_total_size, Fwindow_left_column)
2020 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2021 (Fwindow_list_1): New functions.
2022 (window_box_text_cols): Replace with window_body_cols.
2023 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2024 window_body_cols instead of window_box_text_cols.
2025 (delete_window, Fset_window_configuration): Call
2026 delete_all_subwindows with window as argument.
2027 (delete_all_subwindows): Take a window as argument and not a
2028 structure. Rewrite.
2029 (window_loop): Remove handling of GET_LRU_WINDOW and
2030 GET_LARGEST_WINDOW.
2031 (Fget_lru_window, Fget_largest_window): Move to window.el.
2032
2033 * window.h: Extern window_body_cols instead of
2034 window_box_text_cols. delete_all_subwindows now takes a
2035 Lisp_Object as argument.
2036
2037 * indent.c (compute_motion, Fcompute_motion): Use
2038 window_body_cols instead of window_box_text_cols.
2039
2040 * frame.c (delete_frame): Call delete_all_subwindows with root
2041 window as argument.
2042
2043 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2044
2045 * fns.c (Fputhash): Document return value.
2046
2047 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2048
2049 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2050
2051 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 Cons<->int and similar integer overflow fixes (Bug#8794).
2054
2055 Check for overflow when converting integer to cons and back.
2056 * charset.c (Fdefine_charset_internal, Fdecode_char):
2057 Use cons_to_unsigned to catch overflow.
2058 (Fencode_char): Use INTEGER_TO_CONS.
2059 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2060 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2061 * data.c (long_to_cons, cons_to_long): Remove.
2062 (cons_to_unsigned, cons_to_signed): New functions.
2063 These signal an error for invalid or out-of-range values.
2064 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2065 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2066 * font.c (Ffont_variation_glyphs):
2067 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2068 * lisp.h: Include <intprops.h>.
2069 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2070 (cons_to_signed, cons_to_unsigned): New decls.
2071 (long_to_cons, cons_to_long): Remove decls.
2072 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2073 (Fprimitive_undo): Use CONS_TO_INTEGER.
2074 * xfns.c (Fx_window_property): Likewise.
2075 * xselect.c: Include <limits.h>.
2076 (x_own_selection, selection_data_to_lisp_data):
2077 Use INTEGER_TO_CONS.
2078 (x_handle_selection_request, x_handle_selection_clear)
2079 (x_get_foreign_selection, Fx_disown_selection_internal)
2080 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2081 (lisp_data_to_selection_data): Use cons_to_unsigned.
2082 (x_fill_property_data): Use cons_to_signed.
2083 Report values out of range.
2084
2085 Check for buffer and string overflow more precisely.
2086 * buffer.h (BUF_BYTES_MAX): New macro.
2087 * lisp.h (STRING_BYTES_MAX): New macro.
2088 * alloc.c (Fmake_string):
2089 * character.c (string_escape_byte8):
2090 * coding.c (coding_alloc_by_realloc):
2091 * doprnt.c (doprnt):
2092 * editfns.c (Fformat):
2093 * eval.c (verror):
2094 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2095 since they may not be the same number.
2096 * editfns.c (Finsert_char):
2097 * fileio.c (Finsert_file_contents):
2098 Likewise for BUF_BYTES_MAX.
2099
2100 * image.c: Use ptrdiff_t, not int, for sizes.
2101 (slurp_file): Switch from int to ptrdiff_t.
2102 All uses changed.
2103 (slurp_file): Check that file size fits in both size_t (for
2104 malloc) and ptrdiff_t (for sanity and safety).
2105
2106 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2107 if b->modtime has its maximal value.
2108
2109 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2110
2111 Don't assume time_t can fit into int.
2112 * buffer.h (struct buffer.modtime): Now time_t, not int.
2113 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2114 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2115
2116 Minor fixes for signed vs unsigned integers.
2117 * character.h (MAYBE_UNIFY_CHAR):
2118 * charset.c (maybe_unify_char):
2119 * keyboard.c (read_char, reorder_modifiers):
2120 XINT -> XFASTINT, since the integer must be nonnegative.
2121 * ftfont.c (ftfont_spec_pattern):
2122 * keymap.c (access_keymap, silly_event_symbol_error):
2123 XUINT -> XFASTINT, since the integer must be nonnegative.
2124 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2125 since it makes no difference and we prefer signed.
2126 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2127 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2128 nonnegative.
2129
2130 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2131
2132 * window.h (Fwindow_frame): Declare.
2133
2134 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2137 (SPARE_MEMORY): Always define.
2138 (LARGE_REQUEST): Remove.
2139 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2140
2141 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2142
2143 * lisp.h: Move EXFUNS for Fframe_root_window,
2144 Fframe_first_window and Fset_frame_selected_window to window.h.
2145
2146 * window.h: Move EXFUNS for Fframe_root_window,
2147 Fframe_first_window and Fset_frame_selected_window here from
2148 lisp.h.
2149
2150 * frame.c (Fwindow_frame, Fframe_first_window)
2151 (Fframe_root_window, Fframe_selected_window)
2152 (Fset_frame_selected_window): Move to window.c.
2153 (Factive_minibuffer_window): Move to minibuf.c.
2154 (Fother_visible_frames_p): New function.
2155
2156 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2157
2158 * window.c (decode_window, decode_any_window): Move up in code.
2159 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2160 (inhibit_frame_unsplittable): Remove unused variable.
2161 (Fwindow_buffer): Move up and rewrite doc-string.
2162 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2163 (Fwindow_prev): New functions.
2164 (Fwindow_frame): Move here from frame.c. Accept any window as
2165 argument.
2166 (Fframe_root_window, Fframe_first_window)
2167 (Fframe_selected_window): Move here from frame.c. Accept frame
2168 or arbitrary window as argument. Update doc-strings.
2169 (Fminibuffer_window): Move up in code.
2170 (Fwindow_minibuffer_p): Move up in code and simplify.
2171 (Fset_frame_selected_window): Move here from frame.c.
2172 Marginal rewrite.
2173 (Fselected_window, select_window, Fselect_window): Move up in
2174 code. Minor doc-string fixes.
2175
2176 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2179 Do not assume that spare memory exists; that assumption is valid
2180 only if SYSTEM_MALLOC.
2181 (LARGE_REQUEST): New macro, so that the issue of large requests
2182 is separated from the issue of spare memory.
2183
2184 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2185
2186 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2187 format. (Bug#8806)
2188
2189 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2190
2191 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2192 before statements.
2193
2194 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2195
2196 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2197
2198 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2199
2200 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2201 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2202
2203 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2206
2207 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2208
2209 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2210 (x_clipboard_manager_save): Add return value.
2211 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2212 New error handlers.
2213 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2214 Obey Vx_select_enable_clipboard_manager. Catch errors in
2215 x_clipboard_manager_save (Bug#8779).
2216 (Vx_select_enable_clipboard_manager): New variable.
2217 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2218
2219 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2220
2221 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2222
2223 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2224
2225 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2226 in the current matrix if keep_current_p is non-zero.
2227
2228 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2229
2230 * bidi.c (bidi_level_of_next_char): Fix last change.
2231
2232 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2233
2234 Support bidi reordering of text covered by display properties.
2235
2236 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2237 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2238 (bidi_cache_search, bidi_cache_iterator_state)
2239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2240 (bidi_level_of_next_char, bidi_move_to_visually_next):
2241 Support character positions inside a run of characters covered by a
2242 display string.
2243 (bidi_paragraph_init, bidi_resolve_explicit_1)
2244 (bidi_level_of_next_char): Call bidi_fetch_char and
2245 bidi_fetch_char_advance instead of FETCH_CHAR and
2246 FETCH_CHAR_ADVANCE.
2247 (bidi_init_it): Initialize new members.
2248 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2249 definitions.
2250 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2251 instead of using explicit *_CHAR codes.
2252 (bidi_resolve_explicit, bidi_resolve_weak):
2253 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2254 bidirectional text is supported only in multibyte buffers.
2255 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2256 it to initialize the frame_window_p member of struct bidi_it.
2257 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2258 (bidi_resolve_explicit, bidi_resolve_weak)
2259 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2260 bidi_it->nchars is non-positive.
2261 (bidi_level_of_next_char): Don't try to lookup the cache for the
2262 next/previous character if nothing is cached there yet, or if we
2263 were just reseat()'ed to a new position.
2264
2265 * xdisp.c (set_cursor_from_row): Set start and stop points
2266 according to the row's direction when priming the loop that looks
2267 for the glyph on which to display cursor.
2268 (single_display_spec_intangible_p): Function deleted.
2269 (display_prop_intangible_p): Reimplement to call
2270 handle_display_spec instead of single_display_spec_intangible_p.
2271 Accept 3 additional arguments needed by handle_display_spec.
2272 This fixes incorrect cursor motion across display property with complex
2273 values: lists, `(when COND...)' forms, etc.
2274 (single_display_spec_string_p): Support property values that are
2275 lists with the argument STRING its top-level element.
2276 (display_prop_string_p): Fix the condition for processing a
2277 property that is a list to be consistent with handle_display_spec.
2278 (handle_display_spec): New function, refactored from the
2279 last portion of handle_display_prop.
2280 (compute_display_string_pos): Accept additional argument
2281 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2282 value of a `display' property is a "replacing spec".
2283 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2284 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2285 the display property, but just return a value indicating whether
2286 the display property will replace the characters it covers.
2287 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2288 frame_window_p members of struct bidi_it.
2289 (compute_display_string_pos, compute_display_string_end):
2290 New functions.
2291 (push_it): Accept second argument POSITION, where pop_it should
2292 jump to continue iteration.
2293 (reseat_1): Initialize bidi_it.disp_pos.
2294
2295 * keyboard.c (adjust_point_for_property): Adjust the call to
2296 display_prop_intangible_p to its new signature.
2297
2298 * dispextern.h (struct bidi_it): New member frame_window_p.
2299 (bidi_init_it): Update prototypes.
2300 (display_prop_intangible_p): Update prototype.
2301 (compute_display_string_pos, compute_display_string_end):
2302 Declare prototypes.
2303 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2304 EMACS_INT.
2305
2306 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Malloc failure behavior now depends on size of allocation.
2309 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2310 * lisp.h: Change signatures accordingly.
2311 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2312 All callers changed. (Bug#8762)
2313
2314 * gnutls.c: Use Emacs's memory allocators.
2315 Without this change, the gnutls library would invoke malloc etc.
2316 directly, which causes problems on non-SYNC_INPUT hosts, and which
2317 runs afoul of improving memory_full behavior. (Bug#8761)
2318 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2319 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2320 xfree instead of the default malloc, realloc, free.
2321 (Fgnutls_boot): No need to check for memory allocation failure,
2322 since xmalloc does that for us.
2323
2324 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2325 * category.c (hash_get_category_set):
2326 * ccl.c (ccl_driver):
2327 * charset.c (Fdefine_charset_internal):
2328 * charset.h (struct charset.hash_index):
2329 * composite.c (get_composition_id, gstring_lookup_cache)
2330 (composition_gstring_put_cache):
2331 * composite.h (struct composition.hash_index):
2332 * dispextern.h (struct image.hash):
2333 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2334 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2335 (hashfn_equal, hashfn_user_defined, make_hash_table)
2336 (maybe_resize_hash_table, hash_lookup, hash_put)
2337 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2338 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2339 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2340 * image.c (make_image, search_image_cache, lookup_image)
2341 (xpm_put_color_table_h):
2342 * lisp.h (struct Lisp_Hash_Table):
2343 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2344 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2345 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2346 * alloc.c (allocate_vectorlike):
2347 Check for overflow in vector size calculations.
2348 * ccl.c (ccl_driver):
2349 Check for overflow when converting EMACS_INT to int.
2350 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2351 need to be updated by these changes.
2352 * fns.c (make_hash_table, maybe_resize_hash_table):
2353 Check for integer overflow with large hash tables.
2354 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2355 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2356 (SXHASH_REDUCE): New macro.
2357 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2358 Use it instead of discarding useful hash info with large hash values.
2359 (sxhash_float): New function.
2360 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2361 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2362 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2363 Rewrite to use FIXNUM_BITS, as this simplifies things.
2364 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2365 Adjust signatures to match updated version of code.
2366 (consing_since_gc): Now EMACS_INT, since a single hash table can
2367 use more than INT_MAX bytes.
2368
2369 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2370
2371 Make it possible to build with GCC-4.6+ -O2 -flto.
2372
2373 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2374
2375 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2378 Call minibuffer-inactive-mode.
2379
2380 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2383 Update dependencies.
2384
2385 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2386
2387 * data.c (init_data): Remove code for UTS, this system is not
2388 supported anymore.
2389
2390 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2391
2392 Don't force ./temacs to start in terminal mode.
2393
2394 * frame.c (make_initial_frame): Initialize faces in all cases, not
2395 only when CANNOT_DUMP is defined.
2396 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2397
2398 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2399
2400 * dispnew.c (add_window_display_history): Use const for the string
2401 pointer. Remove declaration, not needed.
2402
2403 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 Use 'inline', not 'INLINE'.
2406 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2407 * alloc.c, fontset.c (INLINE): Remove.
2408 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2409 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2410 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2411 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2412 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2413
2414 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2415
2416 Make it possible to run ./temacs.
2417
2418 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2419 syms_of_callproc does the same thing. Remove test for
2420 "initialized", do it in the caller.
2421 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2422
2423 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2424
2425 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2426 (read_minibuf): Use get_minibuffer.
2427 (syms_of_minibuf): Use DEFSYM.
2428 (Qmetadata): New var.
2429 * data.c (Qbuffer): Don't make it static.
2430 (syms_of_data): Use DEFSYM.
2431
2432 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2435 (CCL_CODE_MIN): New macro.
2436
2437 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2440
2441 * eval.c (Qdebug): Now static.
2442 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2443 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2444 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2445
2446 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2447
2448 * image.c: Various fixes to ImageMagick code comments.
2449 (Fimagemagick_types): Doc fix.
2450
2451 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 Minor fixes prompted by GCC 4.6.0 warnings.
2454
2455 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2456
2457 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2458 (x_clipboard_manager_save_all): Move extern decl to ...
2459 * xterm.h: ... here, so that it can be checked for consistency.
2460
2461 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * xselect.c (x_clipboard_manager_save_frame)
2464 (x_clipboard_manager_save_all): New functions.
2465 (Fx_clipboard_manager_save): Lisp function deleted.
2466
2467 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2468 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2469
2470 * xterm.h: Update prototype.
2471
2472 2011-05-28 William Xu <william.xwl@gmail.com>
2473
2474 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2475 exiting (Bug#8239).
2476
2477 2011-05-28 Jim Meyering <meyering@redhat.com>
2478
2479 Avoid a sign-extension bug in crypto_hash_function.
2480 * fns.c (to_uchar): Define.
2481 (crypto_hash_function): Use it to convert some newly-signed
2482 variables to unsigned, to avoid sign-extension bugs. For example,
2483 without this change, (md5 "truc") would evaluate to
2484 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2485 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2486 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2487
2488 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 Integer overflow fixes.
2491
2492 * dbusbind.c: Serial number integer overflow fixes.
2493 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2494 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2495 to hold a serial number that is too large for a fixnum.
2496 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2497 Check for serial numbers out of range. Decode any serial number
2498 that was so large that it became a float. (Bug#8722)
2499
2500 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2501 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2502 Use XFASTINT rather than XUINT when numbers are nonnegative.
2503 (xd_append_arg, Fdbus_method_return_internal):
2504 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2505 arguments, check that Lisp number is nonnegative, rather than
2506 silently wrapping negative numbers around. (Bug#8722)
2507 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2508 (Bug#8722)
2509
2510 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2511
2512 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2513
2514 ccl: add integer overflow checks
2515 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2516 (IN_INT_RANGE): New macros.
2517 (ccl_driver): Use them to check for integer overflow when
2518 decoding a CCL program. Many of the new checks are whether XINT (x)
2519 fits in int; it doesn't always, on 64-bit hosts. The new version
2520 doesn't catch all possible integer overflows, but it's an
2521 improvement. (Bug#8719)
2522
2523 * alloc.c (make_event_array): Use XINT, not XUINT.
2524 There's no need for unsigned here.
2525
2526 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2527 This follows up to the 2011-05-06 change that substituted uintptr_t
2528 for EMACS_INT. This case wasn't caught back then.
2529
2530 Rework Fformat to avoid integer overflow issues.
2531 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2532 now (part of C89). Include <verify.h>.
2533 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2534 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2535 (Fformat): Avoid the prepass trying to compute sizes; it was only
2536 approximate and thus did not catch overflow reliably. Instead, walk
2537 through the format just once, formatting and computing sizes as we go,
2538 checking for integer overflow at every step, and allocating a larger
2539 buffer as needed. Keep track separately whether the format is
2540 multibyte. Keep only the most-recently calculated precision, rather
2541 than them all. Record whether each argument has been converted to
2542 string. Use EMACS_INT, not int, for byte and char and arg counts.
2543 Support field widths and precisions larger than INT_MAX. Avoid
2544 sprintf's undefined behavior with conversion specifications such as %#d
2545 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2546 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2547 formatting out-of-range floating point numbers with int
2548 formats. (Bug#8668)
2549
2550 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2551
2552 * data.c: Avoid integer truncation in expressions involving floats.
2553 * data.c: Include <intprops.h>.
2554 (arith_driver): When there's an integer overflow in an expression
2555 involving floating point, convert the integers to floating point
2556 so that the resulting value does not suffer from catastrophic
2557 integer truncation. For example, on a 64-bit host (* 4
2558 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2559 Do not rely on undefined behavior after integer overflow.
2560
2561 merge count_size_as_multibyte, parse_str_to_multibyte
2562 * character.c, character.h (count_size_as_multibyte):
2563 Rename from parse_str_to_multibyte; all uses changed.
2564 Check for integer overflow.
2565 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2566 since it's now a duplicate of the other. This is more of
2567 a character than a buffer op, so better that it's in character.c.
2568 * fns.c, print.c: Adjust to above changes.
2569
2570 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2571
2572 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2573
2574 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2577 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2578 (x_clipboard_manager_save): Now static.
2579 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2580
2581 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2582 (crypto_hash_function): Now static.
2583 Fix pointer signedness problems. Avoid unnecessary initializations.
2584
2585 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2586
2587 * termhooks.h (Vselection_alist): Make it terminal-local.
2588
2589 * terminal.c (create_terminal): Initialize it.
2590
2591 * xselect.c: Support for clipboard managers.
2592 (Vselection_alist): Move to termhooks.h as terminal-local var.
2593 (LOCAL_SELECTION): New macro.
2594 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2595 (symbol_to_x_atom): Remove gratuitous arg.
2596 (x_handle_selection_request, lisp_data_to_selection_data)
2597 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2598 (x_own_selection, x_get_local_selection, x_convert_selection):
2599 New arg, specifying work frame. Use terminal-local Vselection_alist.
2600 (some_frame_on_display): Delete unused function.
2601 (Fx_own_selection_internal, Fx_get_selection_internal)
2602 (Fx_disown_selection_internal, Fx_selection_owner_p)
2603 (Fx_selection_exists_p): New optional frame arg.
2604 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2605 (x_handle_selection_clear): Don't treat other terminals with the
2606 same keyboard specially. Use the terminal-local Vselection_alist.
2607 (x_clear_frame_selections): Use Frun_hook_with_args.
2608
2609 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2610
2611 * xterm.h: Add support for those atoms.
2612
2613 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2614
2615 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2616 (converted_selections, conversion_fail_tag): New global variables.
2617 (x_selection_request_lisp_error): Free the above.
2618 (x_get_local_selection): Remove unnecessary code.
2619 (x_reply_selection_request): Args changed; handle arbitrary array
2620 of converted selections stored in converted_selections.
2621 Separate the XChangeProperty and SelectionNotify steps.
2622 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2623 (x_convert_selection): New function.
2624 (x_handle_selection_event): Simplify.
2625 (x_get_foreign_selection): Don't ignore incoming requests while
2626 waiting for an answer; this will fail when we implement
2627 SAVE_TARGETS, and seems unnecessary anyway.
2628 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2629 (Vx_sent_selection_functions): Doc fix.
2630
2631 2011-05-26 Leo Liu <sdl.web@gmail.com>
2632
2633 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2634
2635 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2636
2637 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2638
2639 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2640 for fringe update if it has periodic bitmap.
2641 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2642 and fringe_bitmap_periodic_p.
2643
2644 * fringe.c (get_fringe_bitmap_data): New function.
2645 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2646 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2647 row. Mark glyph row for fringe update if periodicity changed.
2648
2649 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2650 for fringe update unless it has periodic bitmap.
2651
2652 2011-05-25 Kenichi Handa <handa@m17n.org>
2653
2654 * xdisp.c (get_next_display_element): Set correct it->face_id for
2655 a static composition.
2656
2657 2011-05-24 Leo Liu <sdl.web@gmail.com>
2658
2659 * deps.mk (fns.o):
2660 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2661
2662 * fns.c (crypto_hash_function, Fsha1): New function.
2663 (Fmd5): Use crypto_hash_function.
2664 (syms_of_fns): Add Ssha1.
2665
2666 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * gnutls.c: Remove unused macros.
2669 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2670 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2671 Remove macros that are defined and never used.
2672 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2673
2674 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2677 (Fx_get_selection_internal): Minor cleanup.
2678 (Fx_own_selection_internal): Rename arguments for consistency with
2679 select.el.
2680
2681 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2684
2685 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2686
2687 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2688
2689 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2690
2691 * dispnew.c (scrolling_window): Don't exclude the case that the
2692 last enabled row in the desired matrix touches the bottom boundary.
2693
2694 2011-05-21 Glenn Morris <rgm@gnu.org>
2695
2696 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2697 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2698 and add some more files.
2699
2700 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2701
2702 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2703 report_file_error introduced by the change from 2011-05-07.
2704
2705 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 * systime.h (Time): Define only if emacs is defined.
2708 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2709 where the include path doesn't have X11/X.h by default. See
2710 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2711
2712 2011-05-20 Kenichi Handa <handa@m17n.org>
2713
2714 * composite.c (find_automatic_composition): Fix previous change.
2715
2716 2011-05-20 Glenn Morris <rgm@gnu.org>
2717
2718 * lisp.mk: New file, split from Makefile.in.
2719 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2720 (shortlisp): Remove.
2721 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2722
2723 2011-05-19 Glenn Morris <rgm@gnu.org>
2724
2725 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2726 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2727 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2728 (lisp): Set the order to that of loadup.el.
2729 (shortlisp): Make it a copy of $lisp.
2730 (SOME_MACHINE_LISP): Remove.
2731 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2732 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2733
2734 2011-05-18 Kenichi Handa <handa@m17n.org>
2735
2736 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2737 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2738 (find_automatic_composition): Mostly rewrite for efficiency.
2739
2740 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2741
2742 * makefile.w32-in: Update dependencies.
2743
2744 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2745
2746 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2747 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2748
2749 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 Fix some integer overflow issues, such as string length overflow.
2752
2753 * insdel.c (count_size_as_multibyte): Check for string overflow.
2754
2755 * character.c (lisp_string_width): Check for string overflow.
2756 Use EMACS_INT, not int, for string indexes and lengths; in
2757 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2758 the resulting string length overflows an EMACS_INT; instead,
2759 report a string overflow if no precision given. When checking for
2760 precision exhaustion, use a check that cannot possibly have
2761 integer overflow. (Bug#8675)
2762 * character.h (lisp_string_width): Adjust to new signature.
2763
2764 * alloc.c (string_overflow): New function.
2765 (Fmake_string): Use it. This doesn't change behavior, but saves
2766 a few bytes and will simplify future changes.
2767 * character.c (string_escape_byte8): Likewise.
2768 * lisp.h (string_overflow): New decl.
2769
2770 Fixups, following up to the user-interface timestamp change.
2771 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2772 for UI timestamps, instead of unsigned long.
2773 * msdos.c (mouse_get_pos): Likewise.
2774 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2775 * w32gui.h (Time): Define by including "systime.h" rather than by
2776 declaring it ourselves. (Bug#8664)
2777
2778 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2779 * image.c (clear_image_cache): Likewise.
2780
2781 * term.c (term_mouse_position): Don't assume time_t wraparound.
2782
2783 Be more systematic about user-interface timestamps.
2784 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2785 and sometimes 'EMACS_UINT', to represent these timestamps.
2786 This change causes it to use 'Time' uniformly, as that's what X uses.
2787 This makes the code easier to follow, and makes it easier to catch
2788 integer overflow bugs such as Bug#8664.
2789 * frame.c (Fmouse_position, Fmouse_pixel_position):
2790 Use Time, not unsigned long, for user-interface timestamps.
2791 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2792 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2793 * keyboard.h (last_event_timestamp): Likewise.
2794 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2795 * menu.h (xmenu_show): Likewise.
2796 * term.c (term_mouse_position): Likewise.
2797 * termhooks.h (struct input_event.timestamp): Likewise.
2798 (struct terminal.mouse_position_hook): Likewise.
2799 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2800 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2801 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2802 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2803 what it was before.
2804 * menu.h, termhooks.h: Include "systime.h", for Time.
2805
2806 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2807 Don't assume that the difference between two unsigned long values
2808 can fit into an integer. At this point, we know button_down_time
2809 <= event->timestamp, so the difference must be nonnegative, so
2810 there's no need to cast the result if double-click-time is
2811 nonnegative, as it should be; check that it's nonnegative, just in
2812 case. This bug is triggered when events are more than 2**31 ms
2813 apart (about 25 days). (Bug#8664)
2814
2815 * xselect.c (last_event_timestamp): Remove duplicate decl.
2816 (x_own_selection): Remove needless cast to unsigned long.
2817
2818 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2819 that always fit in int. Use a sentinel instead of a counter, to
2820 avoid a temp and to allay GCC's concerns about possible int overflow.
2821 * frame.h (struct frame): Use int for menu_bar_items_used
2822 instead of EMACS_INT, since it always fits in int.
2823
2824 * menu.c (grow_menu_items): Check for int overflow.
2825
2826 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2827
2828 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2829 Before, the code was not consistent. These values cannot exceed
2830 2**31 - 1 so there's no need to make them unsigned.
2831 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2832 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2833 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2834 as modifiers.
2835 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2836
2837 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2838 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2839 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2840 presumably because the widths might not match.
2841
2842 * window.c (size_window): Avoid needless test at loop start.
2843
2844 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2845
2846 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2847
2848 2011-05-12 Drew Adams <drew.adams@oracle.com>
2849
2850 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2851
2852 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2853
2854 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2855 `width' to `bar_area_x' and `bar_area_width', respectively.
2856 (x_scroll_run): Take account of fringe background extension.
2857
2858 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2859 Rename local vars `left' and `width' to `bar_area_x' and
2860 `bar_area_width', respectively.
2861 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2862 background extension.
2863
2864 2011-05-10 Jim Meyering <meyering@redhat.com>
2865
2866 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2867
2868 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2869
2870 * image.c (Finit_image_library): Return t for built-in image types,
2871 like pbm and xbm. (Bug#8640)
2872
2873 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2874
2875 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2876
2877 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2878
2879 * w32console.c (Fset_screen_color): Doc fix.
2880 (Fget_screen_color): New function.
2881 (syms_of_ntterm): Defsubr it.
2882
2883 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2884 unlink the temporary file if Fcall_process didn't create it in the
2885 first place.
2886 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2887 child process will be redirected to a file specified with `:file'.
2888 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2889 cue to call_process_cleanup not to close that handle.
2890
2891 2011-05-07 Ben Key <bkey76@gmail.com>
2892
2893 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2894 one of two shell specific rules, either bootstrap-temacs-CMD or
2895 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2896 to the previous implementation of the bootstrap-temacs rule.
2897 The bootstrap-temacs-CMD rule is similar to the previous
2898 implementation of the bootstrap-temacs rule except that it
2899 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2900 variable.
2901
2902 These changes, along with some changes to nt/configure.bat,
2903 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2904 earlier fix to add support for --cflags and --ldflags options
2905 that include quotes so that it works whether make uses cmd or
2906 sh as the shell.
2907
2908 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2909
2910 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2911 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2912 is a constant.
2913 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2914 a string. Handle both cases.
2915 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2916 (Fdbus_register_method): Use Qinvalid_function.
2917
2918 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2919
2920 * makefile.w32-in: Update dependencies.
2921 (LISP_H): Add inttypes.h and stdin.h.
2922 (PROCESS_H): Add unistd.h.
2923
2924 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2925
2926 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2927 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2928
2929 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2932
2933 * term.c (vfatal): Remove stray call to va_end.
2934 It's not needed and the C Standard doesn't allow it here anyway.
2935
2936 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2937 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2938
2939 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2940 bytes.
2941
2942 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2943
2944 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2945
2946 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2947
2948 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2949
2950 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2951
2952 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2953 * charset.c (Fdefine_charset_internal): Don't initialize
2954 charset.code_space[15]. The value was garbage, on hosts with
2955 32-bit int (Bug#8600).
2956
2957 * lread.c (read_integer): Be more consistent with string-to-number.
2958 Use string_to_number to do the actual conversion; this avoids
2959 rounding errors and fixes some other screwups. Without this fix,
2960 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2961 (digit_to_number): Move earlier, for benefit of read_integer.
2962 Return -1 if the digit is out of range for the base, -2 if it is
2963 not a digit in any supported base. (Bug#8602)
2964
2965 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2966
2967 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2968 to match comment at start of function. This also removes a
2969 GCC warning about overflow in a 32+64-bit port.
2970
2971 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2972
2973 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2974 Reported by Stefan Monnier in
2975 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2976 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2977 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2978
2979 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2980 (EMACS_UINTPTR): Likewise, with uintptr_t.
2981
2982 * lisp.h: Prefer 64-bit EMACS_INT if available.
2983 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2984 on 32-bit hosts that have 64-bit int, so that they can access
2985 large files.
2986 However, temporarily disable this change unless the temporary
2987 symbol WIDE_EMACS_INT is defined.
2988
2989 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2990
2991 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2992 This removes an assumption that EMACS_INT and long are the same
2993 width as pointers. The assumption is true for Emacs porting targets
2994 now, but we want to make other targets possible.
2995 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2996 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2997 In the rest of the code, change types of integers that hold casted
2998 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2999 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3000 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3001 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3002 No need to cast type when ORing.
3003 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3004 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3005 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3006 assume EMACS_INT is the same width as char *.
3007 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3008 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3009 Remove no-longer-needed casts.
3010 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3011 (xg_tool_bar_help_callback, xg_make_tool_item):
3012 Use EMACS_INTPTR to hold an integer
3013 that will be cast to void *; this can avoid a GCC warning
3014 if EMACS_INT is not the same width as void *.
3015 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3016 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3017 (current_message_1, set_message_1):
3018 Use a local to convert to proper width without a cast.
3019 * xmenu.c (dialog_selection_callback): Likewise.
3020
3021 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3022 Also, don't assume VALBITS / RAND_BITS is less than 5,
3023 and don't rely on undefined behavior when shifting a 1 left into
3024 the sign bit.
3025 * lisp.h (get_random): Change signature to match.
3026
3027 * lread.c (hash_string): Use size_t, not int, for hash computation.
3028 Normally we prefer signed values; but hashing is special, because
3029 it's better to use unsigned division on hash table sizes so that
3030 the remainder is nonnegative. Also, size_t is the natural width
3031 for hashing into memory. The previous code used 'int', which doesn't
3032 retain enough info to hash well into very large tables.
3033 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3034
3035 * dbusbind.c: Don't possibly lose pointer info when converting.
3036 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3037 Use XPNTR rather than XHASH, so that the high-order bits of
3038 the pointer aren't lost when converting through void *.
3039
3040 * eval.c (Fautoload): Don't double-shift a pointer.
3041
3042 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3043
3044 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3045
3046 * gnutls.c (DEF_GNUTLS_FN):
3047 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3048
3049 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3052 marker. (Bug#8610)
3053
3054 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3055
3056 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3057 New version that can reserve upto 2GB of heap space.
3058
3059 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3060
3061 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3062
3063 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3064
3065 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3066 `gnutls_certificate_set_x509_key_file'.
3067
3068 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3069
3070 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3071 Update dependencies.
3072
3073 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3074
3075 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3076 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3077 Remove unused parameter `fildes'.
3078 * process.c (read_process_output, send_process): Don't pass it.
3079
3080 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3081
3082 Fix previous change: the library cache is defined in w32.c.
3083 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3084 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3085
3086 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3087
3088 Implement dynamic loading of GnuTLS on Windows.
3089
3090 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3091 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3092 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3093 Declare.
3094
3095 * gnutls.c (Qgnutls_dll): Define.
3096 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3097 (gnutls_*): Declare function pointers.
3098 (init_gnutls_functions): New function to initialize function pointers.
3099 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3100 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3101 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3102 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3103 (emacs_gnutls_write, emacs_gnutls_read)
3104 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3105 (Fgnutls_available_p): New function.
3106 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3107 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3108 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3109
3110 * image.c: Include w32.h.
3111 (Vimage_type_cache): Delete.
3112 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3113 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3114 (w32_delayed_load): Move to w32.c.
3115
3116 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3117
3118 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3119 (w32_delayed_load): Move from image.c. When loading a library, record
3120 its filename in the :loaded-from property of the library id.
3121 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3122 Initialize and staticpro them.
3123 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3124
3125 * process.c: Include lisp.h before w32.h, not after.
3126 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3127 instead of gnutls_record_check_pending.
3128
3129 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3130
3131 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3132
3133 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3134 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3135 as passed in.
3136
3137 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3138
3139 * xterm.c (x_set_frame_alpha): Do not set property on anything
3140 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3141
3142 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3143
3144 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3145
3146 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3147
3148 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3149 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3150 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3151 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3152 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3153 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3154 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3155 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3156 (Qgnutls_bootprop_callbacks_verify): Make static.
3157
3158 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3159
3160 * callproc.c: Indentation fixup.
3161
3162 * sysdep.c (wait_for_termination_1): Make static.
3163 (wait_for_termination, interruptible_wait_for_termination):
3164 Move after wait_for_termination_1.
3165
3166 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3167
3168 * sysdep.c (interruptible_wait_for_termination): New function
3169 which is like wait_for_termination, but allows keyboard
3170 interruptions.
3171
3172 * callproc.c (Fcall_process): Add (:file "file") as an option for
3173 the STDOUT buffer.
3174 (Fcall_process_region): Ditto.
3175
3176 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3177
3178 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3179 rather than `XVECTOR (FOO)->size'.
3180
3181 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3182 inttypes.h, as a gnulib replacement is used if it not available in
3183 system headers.
3184
3185 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3186
3187 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3188 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3189 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3190
3191 * coding.c (coding_alloc_by_realloc): Error out if destination
3192 will grow beyond MOST_POSITIVE_FIXNUM.
3193 (decode_coding_emacs_mule): Abort if there isn't enough place in
3194 charbuf for the composition carryover bytes. Reserve an extra
3195 space for up to 2 characters produced in a loop.
3196 (decode_coding_iso_2022): Abort if there isn't enough place in
3197 charbuf for the composition carryover bytes.
3198
3199 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3200
3201 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3202 aborting when %lld or %lll format is passed.
3203 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3204 %llo or %llx format is passed. (Bug#8545)
3205
3206 * window.c (window_scroll_line_based): Use a marker instead of
3207 simple variables to record original value of point. (Bug#7952)
3208
3209 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3210 produced by %s or %c overflows available buffer space. (Bug#8545)
3211
3212 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3215 (SIZE_MAX): Move defn after all includes, as they might #define it.
3216
3217 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3220
3221 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3222
3223 * keyboard.c (Qdelayed_warnings_hook): Define.
3224 (command_loop_1): Run `delayed-warnings-hook'
3225 if Vdelayed_warnings_list is non-nil.
3226 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3227 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3228
3229 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3230
3231 * doprnt.c (doprnt): Don't return value smaller than the buffer
3232 size if the message was truncated. (Bug#8545).
3233
3234 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3237 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3238
3239 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3242
3243 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * makefile.w32-in: Update dependencies.
3246
3247 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3248
3249 Improve `doprnt' and its usage. (Bug#8545)
3250 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3251 `format_end'. Remove support for %l as a conversion specifier.
3252 Don't use xrealloc. Improve diagnostics when the %l size modifier
3253 is used. Update the commentary.
3254
3255 * eval.c (verror): Simplify calculation of size_t.
3256
3257 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3258 messages.
3259
3260 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3261
3262 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3263 change.
3264
3265 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3268 This makes this file independent of the recent pseudovector change.
3269
3270 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3271
3272 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3273
3274 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3275 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3276 Remove unused local.
3277 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3278
3279 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3280 GCC 4.6.0 optimizes based on type-based alias analysis.
3281 For example, if b is of type struct buffer * and v of type struct
3282 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3283 != &v->size, and therefore "v->size = 1; b->size = 2; return
3284 v->size;" must therefore return 1. This assumption is incorrect
3285 for Emacs, since it type-puns struct Lisp_Vector * with many other
3286 types. To fix this problem, this patch adds a new type struct
3287 vectorlike_header that documents the constraints on layout of vectors
3288 and pseudovectors, and helps optimizing compilers not get fooled
3289 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3290 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3291 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3292 the size member.
3293 (XSETPVECTYPE): Rewrite in terms of new macro.
3294 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3295 This is a bit clearer, and further avoids the possibility of
3296 undesirable aliasing.
3297 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3298 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3299 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3300 since Lisp_Subr is a special case (no "next" field).
3301 (ASIZE): Now uses header.size rather than size.
3302 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3303 to avoid the hassle of writing XVECTOR (foo)->header.size.
3304 (struct vectorlike_header): New type.
3305 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3306 object, to help avoid aliasing.
3307 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3308 (SUBRP): Likewise, since Lisp_Subr is a special case.
3309 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3310 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3311 (struct Lisp_Hash_Table): Combine first two members into a single
3312 struct vectorlike_header member. All uses of "size" and "next" members
3313 changed to be "header.size" and "header.next".
3314 * buffer.h (struct buffer): Likewise.
3315 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3316 * frame.h (struct frame): Likewise.
3317 * process.h (struct Lisp_Process): Likewise.
3318 * termhooks.h (struct terminal): Likewise.
3319 * window.c (struct save_window_data, struct saved_window): Likewise.
3320 * window.h (struct window): Likewise.
3321 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3322 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3323 * buffer.c (init_buffer_once): Likewise.
3324 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3325 special case.
3326 * process.c (Fformat_network_address): Use local var for size,
3327 for brevity.
3328
3329 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3330
3331 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3332 * data.c (atof): Remove decl; no longer used or needed.
3333 (digit_to_number): Move to lread.c.
3334 (Fstring_to_number): Use new string_to_number function, to be
3335 consistent with how the Lisp reader treats infinities and NaNs.
3336 Do not assume that floating-point numbers represent EMACS_INT
3337 without losing information; this is not true on most 64-bit hosts.
3338 Avoid double-rounding errors, by insisting on integers when
3339 parsing non-base-10 numbers, as the documentation specifies.
3340 * lisp.h (string_to_number): New decl, replacing ...
3341 (isfloat_string): Remove.
3342 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3343 (read1): Do not accept +. and -. as integers; this
3344 appears to have been a coding error. Similarly, do not accept
3345 strings like +-1e0 as floating point numbers. Do not report
3346 overflow for integer overflows unless the base is not 10 which
3347 means we have no simple and reliable way to continue.
3348 Break out the floating-point parsing into a new
3349 function string_to_number, so that Fstring_to_number parses
3350 floating point numbers consistently with the Lisp reader.
3351 (digit_to_number): Move here from data.c. Make it static inline.
3352 (E_CHAR, EXP_INT): Remove, replacing with ...
3353 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3354 (string_to_number): New function, replacing isfloat_string.
3355 This function checks for valid syntax and produces the resulting
3356 Lisp float number too. Rework it so that string-to-number
3357 no longer mishandles examples like "1.0e+". Use strtoumax,
3358 so that overflow for non-base-10 numbers is reported only when
3359 there's no portable and simple way to convert to floating point.
3360
3361 * textprop.c (set_text_properties_1): Rewrite for clarity,
3362 and to avoid GCC warning about integer overflow.
3363
3364 * intervals.h (struct interval): Use EMACS_INT for members
3365 where EMACS_UINT might cause problems. See
3366 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3367 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3368 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3369 All uses changed.
3370 (offset_intervals): Tell GCC not to worry about length overflow
3371 when negating a negative length.
3372
3373 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3374 (overrun_check_free): Likewise.
3375
3376 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3377 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3378 word size.
3379
3380 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3381 (gnutls_make_error): Rename local to avoid shadowing.
3382 (gnutls_emacs_global_deinit): ifdef out; not used.
3383 (Fgnutls_boot): Use const for pointer to readonly storage.
3384 Comment out unused local. Fix pointer signedness problems.
3385
3386 * lread.c (openp): Don't stuff size_t into an 'int'.
3387 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3388 about possible signed overflow.
3389
3390 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3391 (GDK_KEY_g): Don't define if already defined.
3392 (xg_prepare_tooltip): Avoid pointer signedness problem.
3393 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3394
3395 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3396 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3397
3398 * xfns.c (Fx_window_property): Simplify a bit,
3399 to make a bit faster and to avoid GCC 4.6.0 warning.
3400 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3401
3402 * fns.c (internal_equal): Don't assume size_t fits in int.
3403
3404 * alloc.c (compact_small_strings): Tighten assertion a little.
3405
3406 Replace pEd with more-general pI, and fix some printf arg casts.
3407 * lisp.h (pI): New macro, generalizing old pEd macro to other
3408 conversion specifiers. For example, use "...%"pI"d..." rather
3409 than "...%"pEd"...".
3410 (pEd): Remove. All uses replaced with similar uses of pI.
3411 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3412 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3413 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3414 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3415 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3416 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3417 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3418 64-bit hosts.
3419 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3420 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3421 * print.c (safe_debug_print, print_object): Likewise.
3422 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3423 to int.
3424 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3425 avoiding the 0 flag, which is not portable.
3426 * process.c (Fmake_network_process): Use pI to avoid cast.
3427 * region-cache.c (pp_cache): Likewise.
3428 * xdisp.c (decode_mode_spec): Likewise.
3429 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3430 behavior on 64-bit hosts with printf arg.
3431 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3432 (x_stop_queuing_selection_requests): Likewise.
3433 (x_get_window_property): Don't truncate byte count to an 'int'
3434 when tracing.
3435
3436 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3437 here, since it parses constructs like leading '-' and spaces,
3438 which are not wanted; and it overflows with large numbers.
3439 Instead, simply match F[0-9]+, which is what is wanted anyway.
3440
3441 * alloc.c: Remove unportable assumptions about struct layout.
3442 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3443 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3444 (allocate_vectorlike, make_pure_vector): Use the new macros,
3445 plus offsetof, to remove unportable assumptions about struct layout.
3446 These assumptions hold on all porting targets that I know of, but
3447 they are not guaranteed, they're easy to remove, and removing them
3448 makes further changes easier.
3449
3450 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3451 This doesn't fix a bug but makes the code clearer.
3452 (string_overrun_cookie): Now const. Use initializers that
3453 don't formally overflow signed char, to avoid warnings.
3454 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3455 can cause Emacs to crash when string overrun checking is enabled.
3456 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3457 multiple of sizeof (EMACS_INT); it need not be, if
3458 alignof(EMACS_INT) < sizeof (EMACS_INT).
3459 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3460
3461 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3462
3463 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3464
3465 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3466
3467 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3468 supposed to be handshaking. (Bug#8556)
3469 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3470
3471 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3472
3473 * lisp.h (Qdebug): List symbol.
3474 * eval.c (Qdebug): Restore global linkage.
3475 * keyboard.c (debug-on-event): New variable.
3476 (handle_user_signal): Break into debugger when debug-on-event
3477 matches the current signal symbol.
3478
3479 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3480
3481 * alloc.c (check_sblock, check_string_bytes)
3482 (check_string_free_list): Convert to standard C.
3483
3484 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3485
3486 * w32.c (emacs_gnutls_push): Fix typo.
3487
3488 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3489
3490 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3491 "cast to pointer from integer of different size".
3492
3493 Improve doprnt and its use in verror. (Bug#8545)
3494 * doprnt.c (doprnt): Document the set of format control sequences
3495 supported by the function. Use SAFE_ALLOCA instead of always
3496 using `alloca'.
3497
3498 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3499 is one byte too soon. Don't use xrealloc; instead xfree and
3500 xmalloc anew.
3501
3502 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3503
3504 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3505 callbacks stage.
3506
3507 * gnutls.c: Renamed global_initialized to
3508 gnutls_global_initialized. Added internals for the
3509 :verify-hostname-error, :verify-error, and :verify-flags
3510 parameters of `gnutls-boot' and documented those parameters in the
3511 docstring. Start callback support.
3512 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3513 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3514 on error. Return error code.
3515 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3516 (emacs_gnutls_read): Likewise.
3517 (Fgnutls_boot): Return handshake error code.
3518 (emacs_gnutls_handle_error): New function.
3519 (wsaerror_to_errno): Likewise.
3520
3521 * w32.h (emacs_gnutls_pull): Add prototype.
3522 (emacs_gnutls_push): Likewise.
3523
3524 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3525 (emacs_gnutls_push): Likewise.
3526
3527 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3528
3529 * process.c (wait_reading_process_output): Check if GnuTLS
3530 buffered some data internally if no FDs are set for TLS
3531 connections.
3532
3533 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3534 (LIBS): Link to USER_LIBS.
3535 ($(BLD)/gnutls.$(0)): New target.
3536
3537 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3538
3539 * xdisp.c (handle_single_display_spec): Rename the
3540 display_replaced_before_p argument into display_replaced_p, to
3541 make it consistent with the commentary. Fix typos in the
3542 commentary.
3543
3544 * textprop.c (syms_of_textprop): Remove dead code.
3545 (copy_text_properties): Delete obsolete commentary about an
3546 interface that was deleted long ago. Fix typos in the description
3547 of arguments.
3548
3549 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3550 to changes in oldXMenu/XMenu.h from 2011-04-16.
3551 <menu_help_message, prev_menu_help_message>: Constify.
3552 (IT_menu_make_room): menu->help_text is now `const char **';
3553 adjust.
3554
3555 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3556 to changes in oldXMenu/XMenu.h from 2011-04-16.
3557 (struct XMenu): Declare `help_text' `const char **'.
3558
3559 * xfaces.c <Qunspecified>: Make extern again.
3560
3561 * syntax.c: Include sys/types.h before including regex.h, as
3562 required by Posix.
3563
3564 * doc.c (get_doc_string): Improve the format passed to `error'.
3565
3566 * doprnt.c (doprnt): Improve commentary.
3567
3568 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3569
3570 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3571 them with etags.
3572
3573 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3574 changes in globals.h immediately force recompilation.
3575 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3576 $(CURDIR)/s/ms-w32.h.
3577 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3578
3579 * character.c (Fchar_direction): Function deleted.
3580 (syms_of_character): Don't defsubr it.
3581 <char-direction-table>: Deleted.
3582
3583 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3584
3585 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3586 * doprnt.c: Include limits.h.
3587 (SIZE_MAX): New macro.
3588 (doprnt): Return a size_t value. 2nd arg is now size_t.
3589 Many local variables are now size_t instead of int or unsigned.
3590 Improve overflow protection. Support `l' modifier for integer
3591 conversions. Support %l conversion. Don't assume an EMACS_INT
3592 argument for integer conversions and for %c.
3593
3594 * lisp.h (doprnt): Restore prototype.
3595
3596 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3597 $(SRC)/character.h.
3598
3599 * Makefile.in (base_obj): Add back doprnt.o.
3600
3601 * deps.mk (doprnt.o): Add back prerequisites.
3602 (callint.o): Depend on character.h.
3603
3604 * eval.c (internal_lisp_condition_case): Include the handler
3605 representation in the error message.
3606 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3607 when breaking from the loop.
3608
3609 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3610
3611 * callint.c (Fcall_interactively): When displaying error message
3612 about invalid control letter, pass the character's codepoint, not
3613 a pointer to its multibyte form. Improve display of the character
3614 in octal and display also its hex code.
3615
3616 * character.c (char_string): Use %x to display the (unsigned)
3617 codepoint of an invalid character, to avoid displaying a bogus
3618 negative value.
3619
3620 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3621 `error', not SYMBOL_NAME itself.
3622
3623 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3624 character arguments to `error'.
3625
3626 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3627 to `error' in error message about FINAL_CHAR argument. Make sure
3628 FINAL_CHAR is a character, and use %c when it is passed as
3629 argument to `error'.
3630
3631 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3632
3633 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3634
3635 * w32.c: Include <time.h>.
3636 (sys_localtime): New function.
3637
3638 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3639
3640 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3641
3642 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3643
3644 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3645
3646 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3647 zombies (Bug#8467).
3648
3649 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3650
3651 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3652 gl_state.e_property when gl_state.object is Qt.
3653
3654 * insdel.c (make_gap_larger): Remove limitation of buffer size
3655 to <= INT_MAX.
3656
3657 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3658
3659 * xdisp.c (lookup_glyphless_char_display)
3660 (produce_glyphless_glyph): Handle cons cell entry in
3661 glyphless-char-display.
3662 (Vglyphless_char_display): Document it.
3663
3664 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3665 glyphless-char-display.
3666
3667 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3668
3669 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3670
3671 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3672
3673 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3674 definition for no-X builds.
3675
3676 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 Static checks with GCC 4.6.0 and non-default toolkits.
3679
3680 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3681
3682 * process.c (keyboard_bit_set): Define only if SIGIO.
3683 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3684 (send_process): Repair possible setjmp clobbering.
3685
3686 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3687
3688 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3689
3690 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3691
3692 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3693 Define only if needed.
3694
3695 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3696 by pacifying GCC about it. Maybe it's time to retire it?
3697 * xfaces.c (USG, __TIMEVAL__): Likewise.
3698
3699 * dispextern.h (struct redisplay_interface): Rename param
3700 to avoid shadowing.
3701 * termhooks.h (struct terminal): Likewise.
3702 * xterm.c (xembed_send_message): Likewise.
3703
3704 * insdel.c (make_gap_smaller): Define only if
3705 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3706
3707 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3708 it.
3709
3710 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3711 so that we aren't warned about unused symbols.
3712
3713 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3714
3715 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3716
3717 * xfns.c (x_real_positions): Mark locals as initialized.
3718
3719 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3720
3721 * xterm.c: Fix problems found by static analysis with other toolkits.
3722 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3723 (x_dispatch_event): Declare static if USE_GTK, and
3724 define if USE_GTK || USE_X_TOOLKIT.
3725 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3726 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3727 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3728 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3729
3730 * xmenu.c (menu_help_callback): Pointer type fixes.
3731 Use const pointers when pointing at readonly data. Avoid pointer
3732 signedness clashes.
3733 (FALSE): Remove unused macro.
3734 (update_frame_menubar): Remove unused decl.
3735
3736 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3737
3738 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3739 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3740 (single_menu_item): Rename local to avoid shadowing.
3741
3742 * keyboard.c (make_lispy_event): Remove unused local var.
3743
3744 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3745 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3746
3747 * bitmaps: Change bitmaps from unsigned char back to the X11
3748 compatible char. Avoid the old compiler warnings about
3749 out-of-range initializers by using, for example, '\xab' rather
3750 than 0xab.
3751
3752 * xgselect.c (xgselect_initialize): Check vs interface
3753 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3754
3755 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3756
3757 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3758 to read-only memory.
3759
3760 * fns.c (vector): Remove; this old hack is no longer needed.
3761
3762 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3763 Remove unused var.
3764 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3765
3766 * xrdb.c (x_load_resources): Omit unused local.
3767
3768 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3769 (x_window): Rename locals to avoid shadowing.
3770 (USG): Use the kludged USG macro, to pacify gcc.
3771
3772 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3773 (x_term_init): Remove local to avoid shadowing.
3774
3775 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3776
3777 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3778 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3779
3780 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3781
3782 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3783
3784 Fix regex.c, syntax.c and friends for buffers > 2GB.
3785 * syntax.h (struct gl_state_s): Declare character position members
3786 EMACS_INT.
3787
3788 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3789
3790 * textprop.c (verify_interval_modification, interval_of):
3791 Declare arguments EMACS_INT.
3792
3793 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3794 EMACS_INT.
3795
3796 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3797
3798 * indent.c (Fvertical_motion): Local variable it_start is now
3799 EMACS_INT.
3800
3801 * regex.c (re_match, re_match_2, re_match_2_internal)
3802 (bcmp_translate, regcomp, regexec, print_double_string)
3803 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3804 (re_compile_pattern, re_exec): Declare arguments and local
3805 variables `size_t' and `ssize_t' and return values `regoff_t', as
3806 appropriate.
3807 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3808 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3809 <compile_stack_type>: `size' and `avail' are now `size_t'.
3810
3811 * regex.h <regoff_t>: Use ssize_t, not int.
3812 (re_search, re_search_2, re_match, re_match_2): Arguments that
3813 specify buffer/string position and length are now ssize_t and
3814 size_t. Return type is regoff_t.
3815
3816 2011-04-16 Ben Key <bkey76@gmail.com>
3817
3818 * nsfont.m: Fixed bugs in ns_get_family and
3819 ns_descriptor_to_entity that were caused by using free to
3820 deallocate memory blocks that were allocated by xmalloc (via
3821 xstrdup). This caused Emacs to crash when compiled with
3822 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3823 --enable-checking=xmallocoverrun). xfree is now used to
3824 deallocate these memory blocks.
3825
3826 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3829
3830 emacs_write: Accept and return EMACS_INT for sizes.
3831 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3832 et seq.
3833 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3834 Accept and return EMACS_INT.
3835 (emacs_gnutls_write): Return the number of bytes written on
3836 partial writes.
3837 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3838 (emacs_read, emacs_write): Remove check for negative size, as the
3839 Emacs source code has been audited now.
3840 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3841 (emacs_read, emacs_write): Use it.
3842 * process.c (send_process): Adjust to the new signatures of
3843 emacs_write and emacs_gnutls_write. Do not attempt to store
3844 a byte offset into an 'int'; it might overflow.
3845 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3846
3847 * sound.c: Don't assume sizes fit in 'int'.
3848 (struct sound_device.period_size, alsa_period_size):
3849 Return EMACS_INT, not int.
3850 (struct sound_device.write, vox_write, alsa_write):
3851 Accept EMACS_INT, not int.
3852 (wav_play, au_play): Use EMACS_INT to store sizes and to
3853 record read return values.
3854
3855 2011-04-15 Ben Key <bkey76@gmail.com>
3856
3857 * keyboard.c (Qundefined): Don't declare static since it is used
3858 in nsfns.m.
3859 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3860 static since they are used in nsfont.m.
3861
3862 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3863
3864 * process.c (Qprocessp): Don't declare static.
3865 * lisp.h (Qprocessp): Declare again.
3866
3867 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3868
3869 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3870
3871 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 Improve C-level modularity by making more things 'static'.
3874
3875 Don't publish debugger-only interfaces to other modules.
3876 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3877 (verify_bytepos, count_markers): Move decls to the only modules
3878 that need them.
3879 * region-cache.h (pp_cache): Likewise.
3880 * window.h (check_all_windows): Likewise.
3881 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3882
3883 * sysdep.c (croak): Now static, if
3884 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3885 * syssignal.h (croak): Declare only if not static.
3886
3887 * alloc.c (refill_memory_reserve): Now static if
3888 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3889 * lisp.h (refill_memory_reserve): Declare only if not static.
3890
3891 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3892 Define only if USE_LUCID.
3893
3894 * xrdb.c (x_customization_string, x_rm_string): Now static.
3895
3896 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3897 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3898
3899 * xdisp.c (draw_row_with_mouse_face): Now static.
3900 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3901
3902 * window.h (check_all_windows): Mark externally visible.
3903
3904 * window.c (window_deletion_count): Now static.
3905
3906 * undo.c: Make symbols static if they're not exported.
3907 (last_undo_buffer, last_boundary_position, pending_boundary):
3908 Now static.
3909
3910 * textprop.c (interval_insert_behind_hooks): Now static.
3911 (interval_insert_in_front_hooks): Likewise.
3912
3913 * term.c: Make symbols static if they're not exported.
3914 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3915 (max_frame_lines, tty_set_terminal_modes):
3916 (tty_reset_terminal_modes, tty_turn_off_highlight):
3917 (get_tty_terminal): Now static.
3918 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3919 * termhooks.h (term_mouse_moveto): Do not declare if
3920 HAVE_WINDOW_SYSTEM.
3921 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3922 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3923
3924 * sysdep.c: Make symbols static if they're not exported.
3925 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3926 Now static.
3927 (sigprocmask_set, full_mask): Remove; unused.
3928 (wait_debugging): Mark as visible.
3929 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3930 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3931
3932 * syntax.c (syntax_temp): Define only if !__GNUC__.
3933
3934 * sound.c (current_sound_device, current_sound): Now static.
3935
3936 * search.c (searchbufs, searchbuf_head): Now static.
3937
3938 * scroll.c (scroll_cost): Remove; unused.
3939 * dispextern.h (scroll_cost): Remove decl.
3940
3941 * region-cache.h (pp_cache): Mark as externally visible.
3942
3943 * process.c: Make symbols static if they're not exported.
3944 (process_tick, update_tick, create_process, chan_process):
3945 (Vprocess_alist, proc_buffered_char, datagram_access):
3946 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3947 (deactivate_process): Mark defn as static, as well as decl.
3948 * lisp.h (create_process): Remove decl.
3949 * process.h (chan_process, Vprocess_alist): Remove decls.
3950
3951 * print.c: Make symbols static if they're not exported.
3952 (print_depth, new_backquote_output, being_printed, print_buffer):
3953 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3954 (print_interval, print_number_index, initial_stderr_stream):
3955 Now static.
3956 * lisp.h (Fprinc): Remove decl.
3957 (debug_output_compilation_hack): Mark as externally visible.
3958
3959 * sysdep.c (croak): Move decl from here to syssignal.h.
3960 * syssignal.h (croak): Put it here, so the API can be checked when
3961 'croak' is called from dissociate_if_controlling_tty.
3962
3963 * minibuf.c: Make symbols static if they're not exported.
3964 (minibuf_save_list, choose_minibuf_frame): Now static.
3965 * lisp.h (choose_minibuf_frame): Remove decl.
3966
3967 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3968
3969 * lread.c: Make symbols static if they're not exported.
3970 (read_objects, initial_obarray, oblookup_last_bucket_number):
3971 Now static.
3972 (make_symbol): Remove; unused.
3973 * lisp.h (initial_obarray, make_symbol): Remove decls.
3974
3975 * keyboard.c: Make symbols static if they're not exported.
3976 (single_kboard, recent_keys_index, total_keys, recent_keys):
3977 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3978 (this_single_command_key_start, echoing, last_auto_save):
3979 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3980 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3981 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3982 (Vlispy_mouse_stem, double_click_count):
3983 Now static.
3984 (force_auto_save_soon): Define only if SIGDANGER.
3985 (ignore_mouse_drag_p): Now static if
3986 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3987 (print_help): Remove; unused.
3988 (stop_character, last_timer_event): Mark as externally visible.
3989 * keyboard.h (ignore_mouse_drag_p): Declare only if
3990 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3991 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3992 * lisp.h (echoing): Remove decl.
3993 (force_auto_save_soon): Declare only if SIGDANGER.
3994 * xdisp.c (redisplay_window): Simplify code, to make it more
3995 obvious that ignore_mouse_drag_p is not accessed if !defined
3996 USE_GTK && !defined HAVE_NS.
3997
3998 * intervals.c: Make symbols static if they're not exported.
3999 (merge_properties_sticky, merge_interval_right, delete_interval):
4000 Now static.
4001 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4002
4003 * insdel.c: Make symbols static if they're not exported.
4004 However, leave prepare_to_modify_buffer alone. It's never
4005 called from outside this function, but that appears to be a bug.
4006 (combine_after_change_list, combine_after_change_buffer):
4007 (adjust_after_replace, signal_before_change): Now static.
4008 (adjust_after_replace_noundo): Remove; unused.
4009 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4010 (signal_before_change): Remove decls.
4011
4012 * indent.c (val_compute_motion, val_vmotion): Now static.
4013
4014 * image.c: Make symbols static if they're not exported.
4015 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4016 if USE_GTK.
4017 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4018 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4019
4020 * fringe.c (standard_bitmaps): Now static.
4021 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4022
4023 * frame.c: Make symbols static if they're not exported.
4024 (x_report_frame_params, make_terminal_frame): Now static.
4025 (get_frame_param): Now static, unless HAVE_NS.
4026 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4027 (x_get_resource_string): Remove; not used.
4028 * frame.h (make_terminal_frame, x_report_frame_params):
4029 (x_get_resource_string); Remove decls.
4030 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4031 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4032
4033 * font.c, fontset.c: Make symbols static if they're not exported.
4034 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4035 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4036 * font.c (font_close_object): Now static.
4037 * font.h (font_close_object): Remove.
4038 * fontset.c (FONTSET_OBJLIST): Remove.
4039 (free_realized_fontset) #if-0 the body, which does nothing.
4040 (face_suitable_for_char_p): #if-0, as it's never called.
4041 * fontset.h (face_suitable_for_char_p): Remove decl.
4042 * xfaces.c (face_at_string_position):
4043 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4044 since 0 is always ASCII.
4045
4046 * fns.c (weak_hash_tables): Now static.
4047
4048 * fileio.c: Make symbols static if they're not exported.
4049 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4050 (Vwrite_region_annotation_buffers): Now static.
4051
4052 * eval.c: Make symbols static if they're not exported.
4053 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4054 * lisp.h (backtrace_list): Remove decl.
4055
4056 * emacs.c: Make symbols static if they're not exported.
4057 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4058 (fatal_error_code, fatal_error_signal_hook, standard_args):
4059 Now static.
4060 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4061 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4062 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4063 * lisp.h (fatal_error_signal_hook): Remove decl.
4064 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4065
4066 * editfns.c: Move a (normally-unused) function to its only use.
4067 * editfns.c, lisp.h (get_operating_system_release): Remove.
4068 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4069 worth the hassle of breaking this out.
4070
4071 * xterm.c: Make symbols static if they're not exported.
4072 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4073 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4074 (x_destroy_window, x_delete_display):
4075 Now static.
4076 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4077 (x_mouse_leave): Remove; unused.
4078 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4079 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4080 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4081 Remove decls.
4082 (x_mouse_leave): Declare only if WINDOWSNT.
4083 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4084 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4085 USE_X_TOOLKIT.
4086
4087 * ftxfont.c: Make symbols static if they're not exported.
4088 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4089 HAVE_FREETYPE.
4090 * font.h (ftxfont_driver): Likewise.
4091
4092 * xfns.c: Make symbols static if they're not exported.
4093 (x_last_font_name, x_display_info_for_name):
4094 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4095 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4096 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4097 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4098 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4099 (last_show_tip_args): Now static.
4100 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4101 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4102 (x_screen_planes): Remove; unused.
4103 * dispextern.h (x_screen_planes): Remove decl.
4104
4105 * dispnew.c: Make symbols static if they're not exported.
4106 * dispextern.h (redraw_garbaged_frames, scrolling):
4107 (increment_row_positions): Remove.
4108 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4109 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4110 Now static.
4111 (redraw_garbaged_frames): Remove; unused.
4112
4113 * xfaces.c: Make symbols static if they're not exported.
4114 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4115 Remove decls.
4116 * xterm.h (defined_color): Remove decls.
4117 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4118 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4119 (menu_face_changed_default, defined_color, free_realized_face):
4120 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4121 (ascii_face_of_lisp_face): Remove; unused.
4122
4123 * xdisp.c: Make symbols static if they're not exported.
4124 * dispextern.h (scratch_glyph_row, window_box_edges):
4125 (glyph_to_pixel_coords, set_cursor_from_row):
4126 (get_next_display_element, set_iterator_to_next):
4127 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4128 (show_mouse_face): Remove decls
4129 * frame.h (message_buf_print): Likewise.
4130 * lisp.h (pop_message, set_message, check_point_in_composition):
4131 Likewise.
4132 * xterm.h (set_vertical_scroll_bar): Likewise.
4133 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4134 (message_buf_print, scratch_glyph_row, displayed_buffer):
4135 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4136 (get_next_display_element, show_mouse_face, window_box_edges):
4137 (frame_to_window_pixel_xy, check_point_in_composition):
4138 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4139 (glyph_to_pixel_coords): Remove; unused.
4140
4141 * dired.c (file_name_completion): Now static.
4142
4143 * dbusbind.c (xd_in_read_queued_messages): Now static.
4144
4145 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4146 * data.c (circular_list_error): Remove.
4147
4148 * commands.h (last_point_position, last_point_position_buffer):
4149 (last_point_position_window): Remove decls.
4150 * keyboard.c: Make these variables static.
4151
4152 * coding.h (coding, code_convert_region, encode_coding_gap):
4153 Remove decls.
4154 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4155 (iso_code_class, detect_coding, code_convert_region): Now static.
4156 (encode_coding_gap): Remove; unused.
4157
4158 * chartab.c (chartab_chars, chartab_bits): Now static.
4159
4160 * charset.h (charset_iso_8859_1): Remove decl.
4161 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4162 Now static.
4163
4164 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4165 * ccl.c (Vccl_program_table): Now static.
4166 (check_ccl_update): Remove; unused.
4167
4168 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4169 * category.h: ... from here.
4170 * category.c (check_category_table, set_category_set): Now static.
4171
4172 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4173 * lisp.h: Remove these decls.
4174
4175 * buffer.c (buffer_count): Remove unused var.
4176
4177 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4178 so that it's not optimized away.
4179 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4180 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4181 exported only to the debugger.
4182
4183 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4184 * atimer.h (run_all_atimers): Remove; not exported.
4185
4186 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4187 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4188 was inaccessible from Lisp.
4189 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4190 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4191
4192 alloc.c: Import and export fewer symbols, and remove unused items.
4193 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4194 is defined.
4195 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4196 it's not optimized away by whole-program optimization.
4197 (message_enable_multibyte, free_misc): Remove.
4198 (catchlist, handlerlist, mark_backtrace):
4199 Declare only if BYTE_MARK_STACK.
4200 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4201 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4202 (message_enable_multibyte): Remove decl.
4203 (free_misc, interval_free_list, float_block, float_block_index):
4204 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4205 (cons_free_list, last_marked_index):
4206 Now static.
4207 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4208 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4209 (mark_backtrace): Define only if BYTE_MARK_STACK.
4210 * xdisp.c (message_enable_multibyte): Now static.
4211
4212 Declare Lisp_Object Q* variables to be 'static' if not exported.
4213 This makes it easier for human readers (and static analyzers)
4214 to see whether these variables are used from other modules.
4215 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4216 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4217 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4218 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4219 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4220 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4221 * xmenu.c, xselect.c:
4222 Declare Q* vars static if they are not used in other modules.
4223 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4224 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4225 Remove decls of unexported vars.
4226 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4227
4228 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4229
4230 Make Emacs functions such as Fatom 'static' by default.
4231 This makes it easier for human readers (and static analyzers)
4232 to see whether these functions can be called from other modules.
4233 DEFUN now defines a static function. To make the function external
4234 so that it can be used in other C modules, use the new macro DEFUE.
4235 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4236 (Finit_image_library):
4237 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4238 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4239 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4240 Remove decls, since these functions are now static.
4241 (Funintern, Fget_internal_run_time): New decls, since these functions
4242 were already external.
4243
4244 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4245 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4246 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4247 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4248 * keyboard.c, keymap.c, lread.c:
4249 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4250 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4251 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4252 Mark functions with DEFUE instead of DEFUN,
4253 if they are used in other modules.
4254 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4255 decls for now-static functions.
4256 * buffer.h (Fdelete_overlay): Remove decl.
4257 * callproc.c (Fgetenv_internal): Mark as internal.
4258 * composite.c (Fremove_list_of_text_properties): Remove decl.
4259 (Fcomposition_get_gstring): New forward static decl.
4260 * composite.h (Fcomposite_get_gstring): Remove decl.
4261 * dired.c (Ffile_attributes): New forward static decl.
4262 * doc.c (Fdocumntation_property): New forward static decl.
4263 * eval.c (Ffetch_bytecode): New forward static decl.
4264 (Funintern): Remove extern decl; now in .h file where it belongs.
4265 * fileio.c (Fmake_symbolic_link): New forward static decl.
4266 * image.c (Finit_image_library): New forward static decl.
4267 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4268 * intervals.h (Fprevious_property_change):
4269 (Fremove_list_of_text_properties): Remove decls.
4270 * keyboard.c (Fthis_command_keys): Remove decl.
4271 (Fcommand_execute): New forward static decl.
4272 * keymap.c (Flookup_key): New forward static decl.
4273 (Fcopy_keymap): Now static.
4274 * keymap.h (Flookup_key): Remove decl.
4275 * process.c (Fget_process): New forward static decl.
4276 (Fprocess_datagram_address): Mark as internal.
4277 * syntax.c (Fsyntax_table_p): New forward static decl.
4278 (skip_chars): Remove duplicate decl.
4279 * textprop.c (Fprevious_property_change): New forward static decl.
4280 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4281 Now internal.
4282 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4283 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4284
4285 * editfns.c (Fformat): Remove unreachable code.
4286
4287 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4288
4289 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4290 change. (Bug#8496)
4291
4292 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4293
4294 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4295 when at ZV. (Bug#8487)
4296
4297 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4298
4299 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4300 (Bug#8437)
4301 * keyboard.c (parse_tool_bar_item): Likewise.
4302 * sound.c (sound_cleanup, alsa_close): Likewise.
4303 * termcap.c (tgetent): Likewise.
4304 * xfns.c (x_default_font_parameter): Likewise.
4305 * xsettings.c (read_and_apply_settings): Likewise.
4306
4307 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4308 (overrun_check_free): Protoize.
4309
4310 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4313 since callers should never pass a negative size.
4314 Change the signature to match that of plain 'read' and 'write'; see
4315 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4316 * lisp.h: Update prototypes of emacs_write and emacs_read.
4317
4318 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4319
4320 * xdisp.c (redisplay_window): Don't try to determine the character
4321 position of the scroll margin if the window start point w->startp
4322 is outside the buffer's accessible region. (Bug#8468)
4323
4324 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4325
4326 Fix write-region and its subroutines for buffers > 2GB.
4327 * fileio.c (a_write, e_write): Modify declaration of arguments and
4328 local variables to support buffers larger than 2GB.
4329 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4330
4331 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4332 argument, local variables, and return value.
4333
4334 * lisp.h: Update prototypes of emacs_write and emacs_read.
4335
4336 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4337
4338 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4341
4342 Fix more problems found by GCC 4.6.0's static checks.
4343
4344 * xdisp.c (vmessage): Use a better test for character truncation.
4345
4346 * charset.c (load_charset_map): <, not <=, for optimization,
4347 and to avoid potential problems with integer overflow.
4348 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4349 * casetab.c (set_identity, shuffle): Likewise.
4350 * editfns.c (Fformat): Likewise.
4351 * syntax.c (skip_chars): Likewise.
4352
4353 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4354 This also lets GCC 4.6.0 generate slightly better loop code.
4355
4356 * callint.c (Fcall_interactively): <, not <=, for optimization.
4357 (Fcall_interactively): Count the number of arguments produced,
4358 not the number of arguments given. This is simpler and lets GCC
4359 4.6.0 generate slightly better code.
4360
4361 * ftfont.c: Distingish more carefully between FcChar8 and char.
4362 The previous code passed unsigned char * to a functions like
4363 strlen and xstrcasecmp that expect char *, which does not
4364 conform to the C standard.
4365 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4366 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4367 char * when the C standard requires it.
4368
4369 * keyboard.c (read_char): Remove unused var.
4370
4371 * eval.c: Port to Windows vsnprintf (Bug#8435).
4372 Include <limits.h>.
4373 (SIZE_MAX): Define if the headers do not.
4374 (verror): Do not give up if vsnprintf returns a negative count.
4375 Instead, grow the buffer. This ports to Windows vsnprintf, which
4376 does not conform to C99. Problem reported by Eli Zaretskii.
4377 Also, simplify the allocation scheme, by avoiding the need for
4378 calling realloc, and removing the ALLOCATED variable.
4379
4380 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4381
4382 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4383 But keep the doprint source code for now, as we might revamp it
4384 and use it again (Bug#8435).
4385 * lisp.h (doprnt): Remove.
4386 * Makefile.in (base_obj): Remove doprnt.o.
4387 * deps.mk (doprnt.o): Remove.
4388
4389 error: Print 32- and 64-bit integers portably (Bug#8435).
4390 Without this change, on typical 64-bit hosts error ("...%d...", N)
4391 was used to print both 32- and 64-bit integers N, which relied on
4392 undefined behavior.
4393 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4394 New macro.
4395 * lisp.h (error, verror): Mark as printf-like functions.
4396 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4397 Report overflow in size calculations when allocating printf buffer.
4398 Do not truncate output string at its first null byte.
4399 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4400 Truncate the output at a character boundary, since vsnprintf does not
4401 do that.
4402 * charset.c (check_iso_charset_parameter): Convert internal
4403 character to string before calling 'error', since %c now has the
4404 printf meaning.
4405 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4406 overflow when computing char to be passed to 'error'. Do not
4407 pass Lisp_Object to 'error'; pass the integer instead.
4408 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4409 formatted with plain %d.
4410
4411 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4412
4413 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4414
4415 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4416
4417 * xterm.c (x_catch_errors): Remove duplicate declaration.
4418
4419 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4420
4421 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4422
4423 2011-04-10 Jim Meyering <meyering@redhat.com>
4424
4425 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4426 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4427 return ssize_t not "int", and use size_t as the buffer length.
4428 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4429 * gnutls.h: Update declarations.
4430 * process.c (read_process_output): Use ssize_t, to match.
4431 (send_process): Likewise.
4432
4433 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4434
4435 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4436
4437 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4438
4439 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4440 Use unsigned char, to match FcChar8 type definition.
4441
4442 * xterm.c (handle_one_xevent):
4443 * xmenu.c (create_and_show_popup_menu):
4444 * xselect.c (x_decline_selection_request)
4445 (x_reply_selection_request): Avoid type-punned deref of X events.
4446
4447 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4448
4449 Fix some uses of `int' instead of EMACS_INT.
4450 * search.c (string_match_1, fast_string_match)
4451 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4452 (scan_buffer, find_next_newline_no_quit)
4453 (find_before_next_newline, search_command, Freplace_match)
4454 (Fmatch_data): Make some `int' variables be EMACS_INT.
4455
4456 * xdisp.c (display_count_lines): 3rd argument and return value now
4457 EMACS_INT. All callers changed.
4458 (pint2hrstr): Last argument is now EMACS_INT.
4459
4460 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4461 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4462 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4463 (decode_coding_utf_16, decode_coding_emacs_mule)
4464 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4465 (decode_coding_ccl, decode_coding_charset)
4466 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4467 (decode_coding_iso_2022, decode_coding_emacs_mule)
4468 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4469 <char_offset, last_offset>: Declare EMACS_INT.
4470 (encode_coding_utf_8, encode_coding_utf_16)
4471 (encode_coding_emacs_mule, encode_invocation_designation)
4472 (encode_designation_at_bol, encode_coding_iso_2022)
4473 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4474 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4475 Declare EMACS_INT.
4476 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4477 (encode_invocation_designation): Last argument P_NCHARS is now
4478 EMACS_INT.
4479 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4480 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4481
4482 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4483 All users changed.
4484
4485 * ccl.c (Fccl_execute_on_string): Declare some variables
4486 EMACS_INT.
4487
4488 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4489
4490 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4491
4492 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4493
4494 * process.c (Fformat_network_address): Doc fix.
4495
4496 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4497
4498 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4499
4500 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4501
4502 * keyboard.c (read_char): Call Lisp function help-form-show,
4503 instead of using internal_with_output_to_temp_buffer.
4504 (Qhelp_form_show): New var.
4505 (syms_of_keyboard): Use DEFSYM macro.
4506
4507 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4508
4509 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4510
4511 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * process.c (Flist_processes): Remove to Lisp.
4514 (list_processes_1): Delete.
4515
4516 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4517
4518 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4519
4520 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4521
4522 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 Fix more problems found by GCC 4.6.0's static checks.
4525
4526 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4527
4528 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4529
4530 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4531
4532 * xdisp.c (vmessage): Mark as a printf-like function.
4533
4534 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4535
4536 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4537
4538 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4539 printf-like functions.
4540 (tiff_load): Add casts to remove these marks before passing them
4541 to system-supplied API.
4542
4543 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4544
4545 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4546 This avoids several warnings with gcc -Wstrict-overflow.
4547 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4548 directly, rather than having caller test rule sign. This avoids
4549 some unnecessary tests.
4550 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4551 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4552 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4553
4554 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4555 (xfont_open): Avoid unnecessary tests.
4556
4557 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4558
4559 * composite.h, composite.c (composition_gstring_put_cache):
4560 Use EMACS_INT, not int, for length.
4561
4562 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4563 breaking out part of COMPOSITION_DECODE_RULE.
4564 (COMPOSITION_DECODE_RULE): Use it.
4565 * composite.c (get_composition_id): Remove unused local vars,
4566 by using the new macro.
4567
4568 * textprop.c (set_text_properties_1): Change while to do-while,
4569 since the condition is always true at first.
4570
4571 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4572 (interval_deletion_adjustment): Return unsigned value.
4573 All uses changed.
4574
4575 * process.c (list_processes_1, create_pty, read_process_output):
4576 (exec_sentinel): Remove vars that were set but not used.
4577 (create_pty): Remove unnecessary "volatile"s.
4578 (Fnetwork_interface_info): Avoid possibility of int overflow.
4579 (read_process_output): Do adaptive read buffering even if carryover.
4580 (read_process_output): Simplify nbytes computation if buffered.
4581
4582 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4583
4584 * syntax.c (scan_words): Remove var that was set but not used.
4585 (update_syntax_table): Use unsigned instead of int.
4586
4587 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4588 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4589 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4590
4591 * print.c (print_error_message): Avoid int overflow.
4592
4593 * font.c (font_list_entities): Redo for clarity,
4594 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4595
4596 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4597 (font_score): Avoid potential overflow in diff calculation.
4598
4599 * fns.c (substring_both): Remove var that is set but not used.
4600 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4601
4602 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4603
4604 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4605 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4606 can always succeed if overflow has undefined behavior.
4607
4608 * search.c (boyer_moore, wordify): Remove vars set but not used.
4609 (wordify): Omit three unnecessary tests.
4610
4611 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4612 All callers changed. This avoids the need for an unused var.
4613
4614 * casefiddle.c (casify_region): Remove var that is set but not used.
4615
4616 * dired.c (file_name_completion): Remove var that is set but not used.
4617
4618 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4619
4620 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4621 (Finsert_file_contents): Remove unnecessary code checking fd.
4622
4623 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4624 Check for integer overflow on size calculations.
4625
4626 * buffer.c (Fprevious_overlay_change): Remove var that is set
4627 but not used.
4628
4629 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4630 Remove vars that are set but not used.
4631 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4632 (timer_check_2): Mark vars as initialized.
4633
4634 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4635
4636 * image.c (lookup_image): Remove var that is set but not used.
4637 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4638
4639 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4640 that are set but not used.
4641
4642 * xfns.c (make_invisible_cursor): Don't return garbage
4643 if XCreateBitmapFromData fails (Bug#8410).
4644
4645 * xselect.c (x_get_local_selection, x_handle_property_notify):
4646 Remove vars that are set but not used.
4647
4648 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4649 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4650
4651 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4652 Remove var that is set but not used.
4653 (scroll_bar_windows_size): Now size_t, not int.
4654 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4655 Check for overflow.
4656
4657 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4658 (map_tty_color) [!defined MSDOS]: Likewise.
4659
4660 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4661
4662 * coding.c: Remove vars that are set but not used.
4663 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4664 All callers changed.
4665 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4666 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4667 (decode_coding_charset): Remove vars that are set but not used.
4668
4669 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4670 that is set but not used.
4671
4672 * print.c (print_object): Remove var that is set but not used.
4673
4674 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4675 The gnulib version avoids calling malloc in the usual case,
4676 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4677 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4678 * filelock.c (current_lock_owner): Likewise.
4679 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4680 * sysdep.c: Include allocator.h, careadlinkat.h.
4681 (emacs_no_realloc_allocator): New static constant.
4682 (emacs_readlink): New function.
4683 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4684 ../lib/careadlinkat.h.
4685
4686 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4687
4688 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4689 first non-nil return value).
4690
4691 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4692
4693 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4694 if not defined (Bug#8403).
4695
4696 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4697
4698 * xdisp.c (display_count_lines): Remove parameter `start',
4699 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4700 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4701 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4702 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4703 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4704 and thereabouts. All callers changed.
4705 (get_per_char_metric): Remove parameter `f', unused since
4706 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4707
4708 2011-04-02 Jim Meyering <meyering@redhat.com>
4709
4710 do not dereference NULL upon failed strdup
4711 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4712 (ns_get_family): Likewise.
4713
4714 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4715
4716 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4717
4718 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4719
4720 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4721 later (Bug#8403).
4722
4723 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 Add lexical binding.
4726
4727 * window.c (Ftemp_output_buffer_show): New fun.
4728 (Fsave_window_excursion):
4729 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4730
4731 * lread.c (lisp_file_lexically_bound_p): New function.
4732 (Fload): Bind Qlexical_binding.
4733 (readevalloop): Remove `evalfun' arg.
4734 Bind Qinternal_interpreter_environment.
4735 (Feval_buffer): Bind Qlexical_binding.
4736 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4737 Mark as dynamic.
4738 (syms_of_lread): Declare `lexical-binding'.
4739
4740 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4741
4742 * keyboard.c (eval_dyn): New fun.
4743 (menu_item_eval_property): Use it.
4744
4745 * image.c (parse_image_spec): Use Ffunctionp.
4746
4747 * fns.c (concat, mapcar1): Accept byte-code-functions.
4748
4749 * eval.c (Fsetq): Handle lexical vars.
4750 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4751 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4752 (FletX, Flet): Obey lexical binding.
4753 (Fcommandp): Handle closures.
4754 (Feval): New `lexical' arg.
4755 (eval_sub): New function extracted from Feval. Use it almost
4756 everywhere where Feval was used. Look up vars in lexical env.
4757 Handle closures.
4758 (Ffunctionp): Move from subr.el.
4759 (Ffuncall): Handle closures.
4760 (apply_lambda): Remove `eval_flags'.
4761 (funcall_lambda): Handle closures and new byte-code-functions.
4762 (Fspecial_variable_p): New function.
4763 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4764 but without exporting it to Lisp.
4765
4766 * doc.c (Fdocumentation, store_function_docstring):
4767 * data.c (Finteractive_form): Handle closures.
4768
4769 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4770 interactive spec.
4771
4772 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4773 New byte-codes.
4774 (exec_byte_code): New function extracted from Fbyte_code to handle new
4775 calling convention for byte-code-functions. Add new byte-codes.
4776
4777 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4778
4779 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4780
4781 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * xdisp.c (redisplay_internal): Fix prototype.
4784
4785 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4786
4787 * xdisp.c (SCROLL_LIMIT): New macro.
4788 (try_scrolling): Use it when setting scroll_limit.
4789 Limit scrolling to 100 screen lines.
4790 (redisplay_window): Even when falling back on "recentering",
4791 position point in the window according to scroll-conservatively,
4792 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4793
4794 (try_scrolling): When point is above the window, allow searching
4795 as far as scroll_max, or one screenful, to compute vertical
4796 distance from PT to the scroll margin position. This prevents
4797 try_scrolling from unnecessarily failing when
4798 scroll-conservatively is set to a value slightly larger than the
4799 window height. Clean up the case of PT below the margin at bottom
4800 of window: scroll_max can no longer be INT_MAX. When aggressive
4801 scrolling is in use, don't let point enter the opposite scroll
4802 margin as result of the scroll.
4803 (syms_of_xdisp) <scroll-conservatively>: Document the
4804 threshold of 100 lines for never-recentering scrolling.
4805
4806 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * dispextern.h (move_it_by_lines):
4809 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4810 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4811 (message_log_check_duplicate): Remove parameters `prev_bol' and
4812 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4813 (redisplay_internal): Remove parameter `preserve_echo_area',
4814 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4815
4816 * indent.c (Fvertical_motion):
4817 * window.c (window_scroll_pixel_based, Frecenter):
4818 Don't pass `need_y_p' to `move_it_by_lines'.
4819
4820 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4821
4822 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4823 steal a few bits to be more compact.
4824 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4825 Remove unneeded casts.
4826
4827 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4828
4829 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4830
4831 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4832 binding" message (bug#7967).
4833
4834 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Fix more problems found by GCC 4.6.0's static checks.
4837
4838 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4839 Remove unused local var.
4840
4841 * editfns.c (Fmessage_box): Remove unused local var.
4842
4843 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4844 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4845 Omit unused local vars.
4846 * window.c (shrink_windows): Omit unused local var.
4847 * menu.c (digest_single_submenu): Omit unused local var.
4848 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4849 Omit unused local var.
4850
4851 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4852 Don't assume string length fits in int.
4853 (keyremap_step, read_key_sequence): Use size_t for sizes.
4854 (read_key_sequence): Don't check last_real_key_start redundantly.
4855
4856 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4857 instead of alloca (Bug#8344).
4858
4859 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4860 (Fbacktrace_frame): Don't assume nframes fits in int.
4861
4862 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4863
4864 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4865 concerns.
4866
4867 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4868
4869 * cm.c (calccost): Turn while-do into do-while, for clarity.
4870
4871 * keyboard.c (syms_of_keyboard): Use the same style as later
4872 in this function when indexing through an array. This also
4873 works around GCC bug 48267.
4874
4875 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4876
4877 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4878
4879 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4880 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4881
4882 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4883 This avoids undefined behavior on integer overflow, and is a bit
4884 more convenient anyway since it is compared to a size_t variable.
4885
4886 Variadic C functions now count arguments with size_t, not int.
4887 This avoids an unnecessary limitation on 64-bit machines, which
4888 caused (substring ...) to crash on large vectors (Bug#8344).
4889 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4890 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4891 All variadic functions and their callers changed accordingly.
4892 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4893 * data.c (arith_driver, float_arith_driver): Likewise.
4894 * editfns.c (general_insert_function): Likewise.
4895 * eval.c (struct backtrace.nargs, interactive_p)
4896 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4897 (funcall_lambda, mark_backtrace): Likewise.
4898 * fns.c (concat): Likewise.
4899 * frame.c (x_set_frame_parameters): Likewise.
4900 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4901 0 if not found, not -1. All callers changed.
4902
4903 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4904 (stack_copy_size): Now size_t, not int.
4905 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4906
4907 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4908
4909 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4910 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4911 All callers changed.
4912
4913 * lisp.h (multibyte_char_to_unibyte):
4914 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4915 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4916 * character.h (CHAR_TO_BYTE8):
4917 * cmds.c (internal_self_insert):
4918 * editfns.c (general_insert_function):
4919 * keymap.c (push_key_description):
4920 * search.c (Freplace_match):
4921 * xdisp.c (message_dolog, set_message_1): All callers changed.
4922
4923 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4924
4925 * keyboard.c (safe_run_hook_funcall): New function.
4926 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4927 don't set the hook to nil, but remove the offending function instead.
4928 (Qcommand_hook_internal): Remove, unused.
4929 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4930 Vcommand_hook_internal.
4931
4932 * eval.c (enum run_hooks_condition): Remove.
4933 (funcall_nil, funcall_not): New functions.
4934 (run_hook_with_args): Call each function through a `funcall' argument.
4935 Remove `cond' argument, now redundant.
4936 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4937 (Frun_hook_with_args_until_failure): Adjust accordingly.
4938 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4939
4940 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * dispextern.h (string_buffer_position): Remove declaration.
4943
4944 * print.c (strout): Remove parameter `multibyte', unused since
4945 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4946
4947 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4948 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4949 All callers changed.
4950
4951 * w32.c (_wsa_errlist): Use braces for struct initializers.
4952
4953 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4954 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4955 All callers changed.
4956 (string_buffer_position): Likewise. Also, make static (it's never
4957 used outside xdisp.c).
4958 (cursor_row_p): Remove parameter `w', unused since
4959 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4960 (decode_mode_spec): Remove parameter `precision', introduced during
4961 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4962 All callers changed.
4963
4964 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4965
4966 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4967
4968 2011-03-27 Anders Lindgren <andlind@gmail.com>
4969
4970 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4971 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4972 (ns_update_auto_hide_menu_bar): New functions.
4973 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4974 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4975 ns_constrain_all_frames.
4976 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4977 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4978
4979 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4980
4981 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4982
4983 2011-03-27 Glenn Morris <rgm@gnu.org>
4984
4985 * syssignal.h: Replace RETSIGTYPE with void.
4986 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4987 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4988 Replace SIGTYPE with void everywhere.
4989 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4990 * s/template.h (SIGTYPE): Remove commented out definition.
4991
4992 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4993
4994 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4995 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4996
4997 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * w32.c (read_unc_volume): Use parameter `henum', instead of
5000 global variable `wget_enum_handle'.
5001
5002 * keymap.c (describe_vector): Remove parameters `indices' and
5003 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5004 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5005
5006 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5007
5008 * keyboard.c (timer_check): Remove parameter `do_it_now',
5009 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5010 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5011 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5012
5013 * keyboard.c (read_char):
5014 * w32menu.c (w32_menu_display_help):
5015 * xmenu.c (show_help_event, menu_help_callback):
5016 Adjust calls to `show_help_echo'.
5017
5018 * gtkutil.c (xg_maybe_add_timer):
5019 * keyboard.c (readable_events):
5020 * process.c (wait_reading_process_output):
5021 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5022
5023 * insdel.c (adjust_markers_gap_motion):
5024 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5025 (gap_left, gap_right): Don't call it.
5026
5027 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5028
5029 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5030 incurred during fontification.
5031
5032 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5033
5034 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5035 (DEFVAR_PER_BUFFER): Don't pass it.
5036
5037 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5038 (scrolling_window): Don't pass it.
5039
5040 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5043
5044 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5045 and `suffix'.
5046 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5047 of variables specific to SELinux and computation of `encoded_absname'.
5048
5049 * image.c (XPutPixel): Remove unused variable `height'.
5050
5051 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5052
5053 * unexw32.c (get_section_info): Remove unused variable `section'.
5054
5055 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5056 (system_process_attributes): Remove unused variable `sess'.
5057 (sys_read): Remove unused variable `err'.
5058
5059 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5060 (w32_wnd_proc): Remove unused variable `isdead'.
5061 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5062 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5063 (x_create_tip_frame): Remove unused variable `tem'.
5064
5065 * w32inevt.c (w32_console_read_socket):
5066 Remove unused variable `no_events'.
5067
5068 * w32term.c (x_draw_composite_glyph_string_foreground):
5069 Remove unused variable `width'.
5070
5071 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * w32term.c (x_set_glyph_string_clipping):
5074 Don't pass uninitialized region to CombineRgn.
5075
5076 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5077
5078 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5079 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5080 (Fx_close_connection): Remove unused variable `i'.
5081
5082 * w32font.c (w32font_draw): Return number of glyphs.
5083 (w32font_open_internal): Remove unused variable `i'.
5084 (w32font_driver): Add missing initializer.
5085
5086 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5087 (fill_in_menu): Remove unused variable `items_added'.
5088
5089 * w32term.c (last_mouse_press_frame): Remove static global variable.
5090 (w32_clip_to_row): Remove unused variable `f'.
5091 (x_delete_terminal): Remove unused variable `i'.
5092
5093 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5094 (NOTHING): Remove unused static global variable.
5095 (uniscribe_check_otf): Remove unused variable `table'.
5096 (uniscribe_font_driver): Add missing initializers.
5097
5098 2011-03-23 Julien Danjou <julien@danjou.info>
5099
5100 * term.c (Fsuspend_tty, Fresume_tty):
5101 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5102 * window.c (temp_output_buffer_show):
5103 * insdel.c (signal_before_change):
5104 * frame.c (Fhandle_switch_frame):
5105 * fileio.c (Fdo_auto_save):
5106 * emacs.c (Fkill_emacs):
5107 * editfns.c (save_excursion_restore):
5108 * cmds.c (internal_self_insert):
5109 * callint.c (Fcall_interactively):
5110 * buffer.c (Fkill_all_local_variables):
5111 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5112 Use Frun_hooks.
5113 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5114 unconditionnaly since it does the check itself.
5115
5116 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5117
5118 Fix more problems found by GCC 4.5.2's static checks.
5119
5120 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5121 the first time through the loop, since we know p0 < p1 then.
5122 This also avoids a gcc -Wstrict-overflow warning.
5123
5124 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5125 leading to a memory leak, possible in functions like
5126 load_charset_map_from_file that can allocate an unbounded number
5127 of objects (Bug#8318).
5128
5129 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5130 that could (at least in theory) be that large.
5131
5132 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5133 This is less likely to overflow, and avoids undefined behavior if
5134 overflow does occur. All callers changed. Use strtoul to scan
5135 for the unsigned long integer.
5136 (pint2hrstr): Simplify and tune code slightly.
5137 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5138
5139 * scroll.c (do_scrolling): Work around GCC bug 48228.
5140 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5141
5142 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5143 This also avoids a warning with gcc -Wstrict-overflow.
5144 (validate_x_resource_name): Simplify count usage.
5145 This also avoids a warning with gcc -Wstrict-overflow.
5146
5147 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5148 fail (Bug#8306).
5149
5150 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5151
5152 * process.c (Fmake_network_process): Use socklen_t, not int,
5153 where POSIX says socklen_t is required in portable programs.
5154 This fixes a porting bug on hosts like 64-bit HP-UX, where
5155 socklen_t is wider than int (Bug#8277).
5156 (Fmake_network_process, server_accept_connection):
5157 (wait_reading_process_output, read_process_output):
5158 Likewise.
5159
5160 * process.c: Rename or move locals to avoid shadowing.
5161 (list_processes_1, Fmake_network_process):
5162 (read_process_output_error_handler, exec_sentinel_error_handler):
5163 Rename or move locals.
5164 (Fmake_network_process): Define label "retry_connect" only if needed.
5165 (Fnetwork_interface_info): Fix pointer signedness.
5166 (process_send_signal): Add cast to avoid pointer signedness problem.
5167 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5168 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5169
5170 Make tparam.h and terminfo.c consistent.
5171 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5172 Include tparam.h instead, since it declares them.
5173 * cm.h (PC): Remove extern decl; tparam.h now does this.
5174 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5175 * terminfo.c: Include tparam.h, to check interfaces.
5176 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5177 (tparam): Adjust signature to match interface in tparam.h;
5178 this removes some undefined behavior. Check that outstring and len
5179 are zero, which they always are with Emacs.
5180 * tparam.h (PC, BC, UP): New extern decls.
5181
5182 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5183 (xftfont_open): Rename locals to avoid shadowing.
5184
5185 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5186 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5187 (OTF_TAG_SYM): Omit macro if not needed.
5188 (ftfont_list): Remove unused local.
5189 (get_adstyle_property, ftfont_pattern_entity):
5190 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5191 Rename locals to avoid shadowing.
5192
5193 * xfont.c (xfont_list_family): Mark var as initialized.
5194
5195 * xml.c (make_dom): Now static.
5196
5197 * composite.c (composition_compute_stop_pos): Rename local to
5198 avoid shadowing.
5199 (composition_reseat_it): Remove unused locals.
5200 (find_automatic_composition, composition_adjust_point): Likewise.
5201 (composition_update_it): Mark var as initialized.
5202 (find_automatic_composition): Mark vars as initialized,
5203 with a FIXME (Bug#8290).
5204
5205 character.h: Rename locals to avoid shadowing.
5206 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5207 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5208 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5209 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5210 to avoid shadowing.
5211
5212 * textprop.c (property_change_between_p): Remove; unused.
5213
5214 * intervals.c (interval_start_pos): Now static.
5215
5216 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5217
5218 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5219 Rename locals to avoid shadowing.
5220
5221 * sound.c (wav_play, au_play, Fplay_sound_internal):
5222 Fix pointer signedness.
5223 (alsa_choose_format): Remove unused local var.
5224 (wav_play): Initialize a variable to 0, to prevent undefined
5225 behavior (Bug#8278).
5226
5227 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5228
5229 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5230
5231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5232 clobbering (Bug#8298).
5233 * sysdep.c (sys_subshell): Likewise.
5234 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5235
5236 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5237 This should get cleaned up, so that child_setup has the
5238 same signature on all platforms.
5239
5240 * callproc.c (call_process_cleanup): Now static.
5241 (relocate_fd): Rename locals to avoid shadowing.
5242
5243 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5244
5245 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5246 not to be necessary, and produces flickering.
5247
5248 2011-03-20 Glenn Morris <rgm@gnu.org>
5249
5250 * config.in: Remove file.
5251
5252 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5253
5254 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5255 are now in src/globals.h.
5256 (syms_of_minibuf): Remove spurious & from previous change.
5257
5258 2011-03-20 Leo <sdl.web@gmail.com>
5259
5260 * minibuf.c (completing-read-function): New variable.
5261 (completing-read-default): Rename from completing-read.
5262 (completing-read): Call completing-read-function.
5263
5264 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5265
5266 * xfaces.c (Fx_load_color_file):
5267 Read color file from absolute filename (bug#8250).
5268
5269 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * makefile.w32-in: Update dependencies.
5272
5273 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5274
5275 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5276
5277 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5278
5279 Fix more problems found by GCC 4.5.2's static checks.
5280
5281 * process.c (make_serial_process_unwind, send_process_trap):
5282 (sigchld_handler): Now static.
5283
5284 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5285 That way, the code declares only the vars that it needs.
5286 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5287 * s/cygwin.h (PTY_ITERATION): Likewise.
5288 * s/darwin.h (PTY_ITERATION): Likewise.
5289 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5290
5291 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5292 * process.c (allocate_pty): Don't declare stb unless it's needed.
5293
5294 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5295 (CONSTANTLIM): Remove; unused.
5296 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5297 Define only if needed.
5298
5299 * unexelf.c (unexec): Name an expression,
5300 to avoid gcc -Wbad-function-cast warning.
5301 Use a different way to cause a compilation error if anyone uses
5302 n rather than nn, a way that does not involve shadowing.
5303 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5304
5305 * deps.mk (unexalpha.o): Remove; unused.
5306
5307 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5308 * unexec.h: New file.
5309 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5310 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5311 Depend on unexec.h.
5312 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5313 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5314 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5315 Change as necessary to match prototype in unexec.h.
5316
5317 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5318 shadowing.
5319 (back_comment, skip_chars): Mark vars as initialized.
5320
5321 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5322 Rename locals to avoid shadowing.
5323
5324 * lread.c (read1): Rewrite so as not to use empty "else".
5325 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5326
5327 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5328
5329 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5330 warning when compiling print.c.
5331
5332 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5333 instead of using an uninitialized var.
5334 (font_sort_entities): Mark var as initialized.
5335
5336 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5337
5338 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5339 pointers to constants.
5340 (font_parse_fcname): Remove unused vars.
5341 (font_delete_unmatched): Now static.
5342 (font_get_spec): Remove; unused.
5343 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5344 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5345 Rename or move locals to avoid shadowing.
5346
5347 * fns.c (require_nesting_list, require_unwind): Now static.
5348 (Ffillarray): Rename locals to avoid shadowing.
5349
5350 * floatfns.c (domain_error2): Define only if needed.
5351 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5352
5353 * alloc.c (mark_backtrace): Move decl from here ...
5354 * lisp.h: ... to here, so that it can be checked.
5355
5356 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5357 (Fdefvar): Rewrite so as not to use empty "else".
5358 (lisp_indirect_variable): Name an expression,
5359 to avoid gcc -Wbad-function-cast warning.
5360 (Fdefvar): Rename locals to avoid shadowing.
5361
5362 * callint.c (quotify_arg, quotify_args): Now static.
5363 (Fcall_interactively): Rename locals to avoid shadowing.
5364 Use const pointer when appropriate.
5365
5366 * lisp.h (get_system_name, get_operating_system_release):
5367 Move decls here, to check interfaces.
5368 * process.c (get_operating_system_release): Move decl to lisp.h.
5369 * xrdb.c (get_system_name): Likewise.
5370 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5371 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5372 some of which prompt warnings from gcc -Wbad-function-cast.
5373 (Fformat_time_string, Fencode_time, Finsert_char):
5374 (Ftranslate_region_internal, Fformat):
5375 Rename or remove local vars to avoid shadowing.
5376 (Ftranslate_region_internal): Mark var as initialized.
5377
5378 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5379 avoid shadowing.
5380
5381 * lisp.h (eassert): Check that the argument compiles, even if
5382 ENABLE_CHECKING is not defined.
5383
5384 * data.c (Findirect_variable): Name an expression, to avoid
5385 gcc -Wbad-function-cast warning.
5386 (default_value, arithcompare, arith_driver, arith_error): Now static.
5387 (store_symval_forwarding): Rename local to avoid shadowing.
5388 (Fmake_variable_buffer_local, Fmake_local_variable):
5389 Mark variables as initialized.
5390 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5391
5392 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5393 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5394 Rename locals to avoid shadowing.
5395 (mark_stack): Move local variables into the #ifdef region where
5396 they're used.
5397 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5398 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5399 needed otherwise.
5400 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5401 (GC_STRING_CHARS): Remove; not used.
5402 (Fmemory_limit): Cast sbrk's returned value to char *.
5403
5404 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5405 avoids undefined behavior in theory.
5406
5407 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5408
5409 Use functions, not macros, for up- and down-casing (Bug#8254).
5410 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5411 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5412 to use the following functions instead of these macros.
5413 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5414 EMACS_INT, since callers assume the returned value fits in int.
5415 (upcase1): Likewise, for UPCASE_TABLE.
5416 (uppercasep, lowercasep, upcase): New static inline functions.
5417 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5418 the race-condition problem in the old DOWNCASE.
5419
5420 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5421 Rename locals to avoid shadowing.
5422 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5423 (regex_compile, re_search_2, re_match_2_internal):
5424 Remove unused local vars.
5425 (FREE_VAR): Rewrite so as not to use empty "else",
5426 which gcc can warn about.
5427 (regex_compile, re_match_2_internal): Mark locals as initialized.
5428 (RETALLOC_IF): Define only if needed.
5429 (WORDCHAR_P): Likewise. This one is never needed, but is used
5430 only in a comment talking about a compiler bug, so put inside
5431 the #if 0 of that comment.
5432 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5433 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5434 Remove; unused.
5435
5436 * search.c (boyer_moore): Rename locals to avoid shadowing.
5437 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5438 (PREV_CHAR_BOUNDARY): Likewise.
5439
5440 * search.c (simple_search): Remove unused var.
5441
5442 * dired.c (compile_pattern): Move decl from here ...
5443 * lisp.h: ... to here, so that it can be checked.
5444 (struct re_registers): New forward decl.
5445
5446 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5447
5448 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5449 All uses changed.
5450 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5451 Rename locals to avoid shadowing.
5452 (Fvertical_motion): Mark locals as initialized.
5453
5454 * casefiddle.c (casify_object, casify_region): Now static.
5455 (casify_region): Mark local as initialized.
5456
5457 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5458
5459 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5460 New macros, so that the caller can use some names other than
5461 gcpro1, gcpro2, etc.
5462 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5463 of the new macros.
5464 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5465 argument, for consistency with GCPRO2_VAR, etc: it is now the
5466 prefix of the variable, not the variable itself. All uses
5467 changed.
5468 * dired.c (directory_files_internal, file_name_completion):
5469 Rename locals to avoid shadowing.
5470
5471 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5472 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5473 dired.c's scmp function, had undefined behavior.
5474 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5475 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5476 * buffer.h: ... to here, because these macros use current_buffer,
5477 and the new implementation with inline functions needs to have
5478 current_buffer in scope now, rather than later when the macros
5479 are used.
5480 (downcase, upcase1): New static inline functions.
5481 (DOWNCASE, UPCASE1): Reimplement using these functions.
5482 This avoids undefined behavior in expressions like
5483 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5484 from race conditions in accessing the global variables
5485 case_temp1 and case_temp2.
5486 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5487 * lisp.h (case_temp1, case_temp2): Remove their decls.
5488 * character.h (ASCII_CHAR_P): Move from here ...
5489 * lisp.h: ... to here, so that the inline functions mentioned
5490 above can use them.
5491
5492 * dired.c (directory_files_internal_unwind): Now static.
5493
5494 * fileio.c (file_name_as_directory, directory_file_name):
5495 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5496 Now static.
5497 (file_name_as_directory): Use const pointers when appropriate.
5498 (Fexpand_file_name): Likewise. In particular, newdir might
5499 point at constant storage, so make it a const pointer.
5500 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5501 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5502 signedness issues.
5503 (Fset_file_times, Finsert_file_contents, auto_save_error):
5504 Rename locals to avoid shadowing.
5505
5506 * minibuf.c (choose_minibuf_frame_1): Now static.
5507 (Ftry_completion, Fall_completions): Rename or remove locals
5508 to avoid shadowing.
5509
5510 * marker.c (bytepos_to_charpos): Remove; unused.
5511
5512 * lisp.h (verify_bytepos, count_markers): New decls,
5513 so that gcc does not warn that these functions aren't declared.
5514
5515 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5516 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5517 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5518 (copy_text): Remove unused local var.
5519
5520 * filelock.c (within_one_second): Now static.
5521 (lock_file_1): Rename local to avoid shadowing.
5522
5523 * buffer.c (fix_overlays_before): Mark locals as initialized.
5524 (fix_start_end_in_overlays): Likewise. This function should be
5525 simplified by using pointers-to-pointers, but that's a different
5526 matter.
5527 (switch_to_buffer_1): Now static.
5528 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5529 (report_overlay_modification): Rename locals to avoid shadowing.
5530
5531 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5532 Fix pointer signedness issue.
5533 (sys_subshell): Mark local as volatile if checking for lint,
5534 to suppress a gcc -Wclobbered warning that does not seem to be right.
5535 (MAXPATHLEN): Define only if needed.
5536
5537 * process.c (serial_open, serial_configure): Move decls from here ...
5538 * systty.h: ... to here, so that they can be checked.
5539
5540 * fns.c (get_random, seed_random): Move extern decls from here ...
5541 * lisp.h: ... to here, so that they can be checked.
5542
5543 * sysdep.c (reset_io): Now static.
5544 (wait_for_termination_signal): Remove; unused.
5545
5546 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5547 (copy_keymap_item, append_key, push_text_char_description):
5548 Now static.
5549 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5550 (DENSE_TABLE_SIZE): Remove; unused.
5551 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5552 (describe_map_tree):
5553 Rename locals to avoid shadowing.
5554
5555 * keyboard.c: Declare functions static if they are not used elsewhere.
5556 (echo_char, echo_dash, cmd_error, top_level_2):
5557 (poll_for_input, handle_async_input): Now static.
5558 (read_char, kbd_buffer_get_event, make_lispy_position):
5559 (make_lispy_event, make_lispy_movement, apply_modifiers):
5560 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5561 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5562 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5563 (read_key_sequence, read_char): Mark locals as initialized.
5564 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5565
5566 * keyboard.h (make_ctrl_char): New decl.
5567 (mark_kboards): Move decl here ...
5568 * alloc.c (mark_kboards): ... from here.
5569
5570 * lisp.h (force_auto_save_soon): New decl.
5571
5572 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5573 (DEFINE_DUMMY_FUNCTION): New macro.
5574 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5575 Use it.
5576 (main): Add casts to avoid warnings
5577 if GCC considers string literals to be constants.
5578
5579 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5580
5581 * dbusbind.c: Pointer signedness fixes.
5582 (xd_signature, xd_append_arg, xd_initialize):
5583 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5584 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5585 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5586 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5587
5588 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5589 if GCC considers string literals to be constants.
5590 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5591
5592 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5593
5594 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5595 (print_preprocess, print_object): New macro to fix last change.
5596
5597 * print.c (print_preprocess): Don't forget font objects.
5598
5599 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * emacs.c (USAGE3): Doc fixes.
5602
5603 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5604
5605 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5606 structure.
5607
5608 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5609
5610 * lisp.h (VWindow_system, Qfile_name_history):
5611 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5612 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5613 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5614
5615 * w32select.c: Don't #include "keyboard.h".
5616 (run_protected): Add extern declaration for waiting_for_input.
5617
5618 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5619 * w32console.c (detect_input_pending, read_input_pending)
5620 (encode_terminal_code):
5621 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5622 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5623 (w32_system_caret_y, Qfile_name_history):
5624 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5625 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5626 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5627 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5628 * w32proc.c (Qlocal, report_file_error):
5629 * w32term.c (Vwindow_system, updating_frame):
5630 * w32uniscribe.c (initialized, uniscribe_font_driver):
5631 Remove unneeded extern declarations.
5632
5633 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5634
5635 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5636
5637 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5638
5639 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5640 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5641 These macros can no longer be used for assignment.
5642
5643 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5644 Assign struct members directly, instead of using BUF_BEGV etc.
5645 (record_buffer_markers, fetch_buffer_markers): New functions for
5646 recording and fetching special buffer markers.
5647 (set_buffer_internal_1, set_buffer_temp): Use them.
5648
5649 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5650
5651 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5652
5653 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5654 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5655
5656 * xdisp.c (hscroll_window_tree):
5657 (reconsider_clip_changes): Use PT instead of BUF_PT.
5658
5659 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5660
5661 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5662 $(EMACS_ROOT)/lib/intprops.h.
5663
5664 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 Fix more problems found by GCC 4.5.2's static checks.
5667
5668 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5669 to unsigned char * to avoid compiler diagnostic.
5670 (xg_free_frame_widgets): Make it clear that a local variable is
5671 needed only if USE_GTK_TOOLTIP.
5672 (gdk_window_get_screen): Make it clear that this macro is needed
5673 only if USE_GTK_TOOLTIP.
5674 (int_gtk_range_get_value): New function, which avoids a diagnostic
5675 from gcc -Wbad-function-cast.
5676 (xg_set_toolkit_scroll_bar_thumb): Use it.
5677 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5678 diagnostic from gcc -Wbad-function-cast.
5679 (get_utf8_string, xg_get_file_with_chooser):
5680 Rename locals to avoid shadowing.
5681 (create_dialog): Move locals to avoid shadowing.
5682
5683 * xgselect.c (xg_select): Remove unused var.
5684
5685 * image.c (four_corners_best): Mark locals as initialized.
5686 (gif_load): Initialize transparent_p to zero (Bug#8238).
5687 Mark another local as initialized.
5688 (my_png_error, my_error_exit): Mark with NO_RETURN.
5689
5690 * image.c (clear_image_cache): Now static.
5691 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5692 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5693 (x_edge_detection): Remove unnecessary cast that
5694 gcc -Wbad-function-cast diagnoses.
5695 (gif_load): Fix pointer signedness.
5696 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5697 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5698
5699 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5700
5701 Improve quality of tests for time stamp overflow.
5702 For example, without this patch (encode-time 0 0 0 1 1
5703 1152921504606846976) returns the obviously-bogus value (-948597
5704 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5705 reports time overflow. See
5706 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5707 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5708 * editfns.c: Include limits.h and intprops.h.
5709 (TIME_T_MIN, TIME_T_MAX): New macros.
5710 (time_overflow): Move earlier, to before first use.
5711 (hi_time, lo_time): New functions, for an accurate test for
5712 out-of-range times.
5713 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5714 (Fget_internal_run_time): Don't assume time_t fits in int.
5715 (make_time): Use list2 instead of Fcons twice.
5716 (Fdecode_time): More accurate test for out-of-range times.
5717 (check_tm_member): New function.
5718 (Fencode_time): Use it, to test for out-of-range times.
5719 (lisp_time_argument): Don't rely on undefined left-shift and
5720 right-shift behavior when checking for time stamp overflow.
5721
5722 * editfns.c (time_overflow): New function, refactoring common code.
5723 (Fformat_time_string, Fdecode_time, Fencode_time):
5724 (Fcurrent_time_string): Use it.
5725
5726 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5727 * dired.c (make_time): Move to ...
5728 * editfns.c (make_time): ... here.
5729 * systime.h: Note the move.
5730
5731 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5732
5733 * fringe.c (update_window_fringes): Remove unused variables.
5734
5735 * unexmacosx.c (copy_data_segment): Also copy __got section.
5736 (Bug#8223)
5737
5738 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5739
5740 * termcap.c [MSDOS]: Include "msdos.h".
5741 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5742 Constify `char *' arguments and their references according to
5743 prototypes in tparam.h.
5744
5745 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5746
5747 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5748 Adapt all references accordingly.
5749
5750 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5751
5752 2011-03-11 Tom Tromey <tromey@redhat.com>
5753
5754 * buffer.c (syms_of_buffer): Remove obsolete comment.
5755
5756 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5757
5758 * termhooks.h (encode_terminal_code): Declare prototype.
5759
5760 * msdos.c (encode_terminal_code): Don't declare prototype.
5761
5762 * term.c (encode_terminal_code): Now external again, used by
5763 w32console.c and msdos.c.
5764
5765 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5766 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5767
5768 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5769
5770 Fix some minor problems found by GCC 4.5.2's static checks.
5771
5772 * fringe.c (update_window_fringes): Mark locals as initialized
5773 (Bug#8227).
5774 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5775
5776 * alloc.c (mark_fringe_data): Move decl from here ...
5777 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5778 to check its interface.
5779 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5780
5781 * fontset.c (free_realized_fontset): Now static.
5782 (Fset_fontset_font): Rename local to avoid shadowing.
5783 (fontset_font): Mark local as initialized.
5784 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5785
5786 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5787
5788 * xselect.c (x_disown_buffer_selections): Remove; not used.
5789 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5790 (x_own_selection, Fx_disown_selection_internal): Rename locals
5791 to avoid shadowing.
5792 (x_handle_dnd_message): Remove local to avoid shadowing.
5793
5794 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5795 so that the caller can use some name other than gcpro1.
5796 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5797 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5798 (Fx_backspace_delete_keys_p):
5799 Use them to avoid shadowing, and rename vars to avoid shadowing.
5800 (x_decode_color, x_set_name, x_window): Now static.
5801 (Fx_create_frame): Add braces to silence GCC warning.
5802 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5803 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5804 Remove unused locals.
5805 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5806 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5807 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5808 macros.
5809
5810 * xterm.h (x_mouse_leave): New decl.
5811
5812 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5813 Remove unused functions.
5814 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5815 (x_calc_absolute_position): Now static.
5816 (XTread_socket): Don't define label "out" unless it's used.
5817 Don't declare local "event" unless it's used.
5818 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5819 unless they are used.
5820 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5821 (x_fatal_error_signal): Remove; not used.
5822 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5823 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5824 (x_error_catcher, x_connection_closed, x_error_handler):
5825 (x_error_quitter, xembed_send_message, x_iconify_frame):
5826 (my_log_handler): Rename locals to avoid shadowing.
5827 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5828 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5829
5830 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5831 Rename or move locals to avoid shadowing.
5832 (tty_defined_color, merge_face_heights): Now static.
5833 (free_realized_faces_for_fontset): Remove; not used.
5834 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5835 does not deduce is never used uninitialized.
5836 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5837 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5838
5839 * terminal.c (store_terminal_param): Now static.
5840
5841 * xmenu.c (menu_highlight_callback): Now static.
5842 (set_frame_menubar): Remove unused local.
5843 (xmenu_show): Rename parameter to avoid shadowing.
5844 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5845 since they might point to immutable storage.
5846 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5847 since it's unused otherwise.
5848
5849 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5850 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5851 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5852 avoids a gcc -Wuninitialized diagnostic.
5853 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5854 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5855 does not deduce are never used uninitialized.
5856
5857 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5858
5859 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5860 * window.c (window_loop, size_window):
5861 (run_window_configuration_change_hook, enlarge_window): Likewise.
5862
5863 * window.c (display_buffer): Now static.
5864 (size_window): Mark variables that gcc -Wuninitialized
5865 does not deduce are never used uninitialized.
5866 * window.h (check_all_windows): New decl, to forestall
5867 gcc -Wmissing-prototypes diagnostic.
5868 * dispextern.h (bidi_dump_cached_states): Likewise.
5869
5870 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5871 shadowing.
5872 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5873 Include <limits.h>.
5874 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5875 and to avoid gcc -Wuninitialized warning.
5876 (load_charset_map): Mark variables that gcc -Wuninitialized
5877 does not deduce are never used uninitialized.
5878 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5879
5880 * coding.c (coding_set_source, coding_set_destination):
5881 Use "else { /* comment */ }" rather than "else /* comment */;"
5882 for clarity, and to avoid gcc -Wempty-body warning.
5883 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5884 a block, when the outer 'i' will do.
5885 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5886 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5887 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5888 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5889 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5890 Rename locals to avoid shadowing.
5891 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5892 * coding.c (emacs_mule_char, encode_invocation_designation):
5893 Now static, since they're not used elsewhere.
5894 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5895 (decode_coding_object, encode_coding_object, detect_coding_system):
5896 (decode_coding_emacs_mule): Mark variables that gcc
5897 -Wuninitialized does not deduce are never used uninitialized.
5898 (detect_coding_iso_2022): Initialize a local variable that might
5899 be used uninitialized. Leave a FIXME because it's not clear that
5900 this initialization is needed. (Bug#8211)
5901 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5902 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5903 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5904 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5905 Remove unused macros.
5906
5907 * category.c (hash_get_category_set): Remove unused local var.
5908 (copy_category_table): Now static, since it's not used elsewhere.
5909 * character.c (string_count_byte8): Likewise.
5910
5911 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5912 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5913
5914 * chartab.c (copy_sub_char_table): Now static, since it's not used
5915 elsewhere.
5916 (sub_char_table_ref_and_range, char_table_ref_and_range):
5917 Rename locals to avoid shadowing.
5918 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5919
5920 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5921 (BIDI_BOB): Remove unused macro.
5922
5923 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5924 deduce are never used uninitialized.
5925 * term.c (encode_terminal_code): Likewise.
5926
5927 * term.c (encode_terminal_code): Now static. Remove unused local.
5928
5929 * tparam.h: New file.
5930 * term.c, tparam.h: Include it.
5931 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5932 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5933 Move these decls to tparam.h, and make them agree with what
5934 is actually in tparam.c. The previous trick of using incompatible
5935 decls in different modules does not conform to the C standard.
5936 All callers of tparam changed to use tparam's actual API.
5937 * tparam.c (tparam1, tparam, tgoto):
5938 Use const pointers where appropriate.
5939
5940 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5941 * cm.h (struct cm): Likewise.
5942 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5943 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5944 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5945 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5946 (turn_on_face, init_tty): Likewise.
5947 * termchar.h (struct tty_display_info): Likewise.
5948
5949 * term.c (term_mouse_position): Rename local to avoid shadowing.
5950
5951 * alloc.c (mark_ttys): Move decl from here ...
5952 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5953
5954 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5955
5956 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5957
5958 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5959
5960 * search.c (compile_pattern_1): Remove argument regp, unused since
5961 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5962 (compile_pattern): Don't pass it.
5963
5964 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5965
5966 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5967 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5968 for ! HAVE_GTK3.
5969 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5970
5971 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5972
5973 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5974 gdk_window_get_screen, gdk_window_get_geometry,
5975 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5976 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5977 (xg_get_pixbuf_from_pixmap): New function.
5978 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5979 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5980 Call xg_get_pixbuf_from_pixmap instead of
5981 gdk_pixbuf_get_from_drawable.
5982 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5983 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5984 (xg_check_special_colors): Use GtkStyleContext and its functions
5985 for HAVE_GTK3.
5986 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5987 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5988 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5989 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5990 Call gtk_widget_get_preferred_size.
5991 (xg_frame_resized): gdk_window_get_geometry only takes 5
5992 parameters.
5993 (xg_win_to_widget, xg_event_is_for_menubar):
5994 Call gdk_x11_window_lookup_for_display.
5995 (xg_set_widget_bg): New function.
5996 (delete_cb): New function.
5997 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5998 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5999 (xg_set_background_color): Call xg_set_widget_bg.
6000 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6001 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6002 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6003 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6004 if ! HAVE_GTK3.
6005 (update_frame_tool_bar): Call gtk_widget_hide.
6006 (xg_initialize): Use GDK_KEY_g.
6007
6008 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6009 if ! HAVE_GTK3
6010 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6011
6012 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6013 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6014 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6015
6016 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6017
6018 * w32xfns.c (select_palette): Check success of RealizePalette against
6019 GDI_ERROR, not zero.
6020
6021 See ChangeLog.11 for earlier changes.
6022
6023 ;; Local Variables:
6024 ;; coding: utf-8
6025 ;; End:
6026
6027 Copyright (C) 2011 Free Software Foundation, Inc.
6028
6029 This file is part of GNU Emacs.
6030
6031 GNU Emacs is free software: you can redistribute it and/or modify
6032 it under the terms of the GNU General Public License as published by
6033 the Free Software Foundation, either version 3 of the License, or
6034 (at your option) any later version.
6035
6036 GNU Emacs is distributed in the hope that it will be useful,
6037 but WITHOUT ANY WARRANTY; without even the implied warranty of
6038 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6039 GNU General Public License for more details.
6040
6041 You should have received a copy of the GNU General Public License
6042 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.