]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* mh-letter.el (mh-letter-mode-map, mh-letter-complete)
[gnu-emacs] / src / ChangeLog
1 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xsettings.c (SYSTEM_FONT): Define only when used.
4 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5
6 * keymap.c (access_keymap_1): Now static.
7
8 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9
10 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11 leave any prefix arg for the up event (Bug#1586).
12
13 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
14
15 * lread.c (syms_of_lread): Mention single symbols defined by
16 `defvar' or `defconst' (bug#7154).
17
18 * fns.c (Frequire): Mention .el.gz files (bug#7314).
19 (Frequire): Mention get-load-suffixes.
20
21 2011-07-02 Martin Rudalics <rudalics@gmx.at>
22
23 * window.h (window): Remove clone_number slot.
24 * window.c (Fwindow_clone_number, Fset_window_clone_number):
25 Remove.
26 (make_parent_window, make_window, saved_window)
27 (Fset_window_configuration, save_window_save): Don't deal with
28 clone numbers.
29 * buffer.c (Qclone_number): Remove declaration.
30 (sort_overlays, overlay_strings): Don't deal with clone numbers.
31
32 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
33
34 Add multiple inheritance to keymaps.
35 * keymap.c (Fmake_composed_keymap): New function.
36 (Fset_keymap_parent): Simplify.
37 (fix_submap_inheritance): Remove.
38 (access_keymap_1): New function extracted from access_keymap to handle
39 embedded parents and handle lists of maps.
40 (access_keymap): Use it.
41 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
42 (Fcopy_keymap): Handle embedded parents.
43 (Fcommand_remapping, define_as_prefix): Simplify.
44 (Fkey_binding): Simplify.
45 (syms_of_keymap): Move minibuffer-local-completion-map,
46 minibuffer-local-filename-completion-map,
47 minibuffer-local-must-match-map, and
48 minibuffer-local-filename-must-match-map to Elisp.
49 (syms_of_keymap): Defsubr make-composed-keymap.
50 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
51 (parse_menu_item): Trivial simplification.
52
53 2011-07-01 Glenn Morris <rgm@gnu.org>
54
55 * Makefile.in (SETTINGS_LIBS): Fix typo.
56
57 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
58
59 * coding.c (Fencode_coding_string): Record the last coding system
60 used, as the function doc string says (bug#8738).
61
62 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
63
64 * xsettings.c (store_monospaced_changed): Take new font as arg and
65 check for change against current_mono_font.
66 (EMACS_TYPE_SETTINGS): Remove this and related defines.
67 (emacs_settings_constructor, emacs_settings_get_property)
68 (emacs_settings_set_property, emacs_settings_class_init)
69 (emacs_settings_init, gsettings_obj): Remove.
70 (something_changedCB): New function for HAVE_GSETTINGS.
71 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
72 with value as argument.
73 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
74 g_settings_new (Bug#8967). Do not create gsettings_obj.
75 Remove calls to g_settings_bind. Connect something_changedCB to
76 "changed".
77
78 * xgselect.c: Add defined (HAVE_GSETTINGS).
79 (xgselect_initialize): Ditto.
80
81 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
82 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
83 xg_select.
84
85 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
86
87 * eval.c (struct backtrace): Simplify and port the data structure.
88 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
89 signed bit field, as this assumption is not portable and it makes
90 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
91 "char debug_on_exit : 1" as this is not portable either; instead,
92 use the portable "unsigned int debug_on_exit : 1". Remove unused
93 member evalargs. Remove obsolete comments about cc bombing out.
94
95 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
96
97 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
98 Let HAVE_GSETTINGS override HAVE_GCONF.
99 (store_monospaced_changed): New function.
100 (EMACS_SETTINGS): A new type derived from GObject to handle
101 GSettings notifications.
102 (emacs_settings_constructor, emacs_settings_get_property)
103 (emacs_settings_set_property, emacs_settings_class_init):
104 New functions.
105 (gsettings_client, gsettings_obj): New variables.
106 (GSETTINGS_SCHEMA): New define.
107 (something_changedCB): Call store_monospaced_changed.
108 (init_gsettings): New function.
109 (xsettings_initialize): Call init_gsettings.
110 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
111 to NULL.
112
113 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
114 GCONF_CFLAGS/LIBS.
115
116 2011-06-29 Martin Rudalics <rudalics@gmx.at>
117
118 * window.c (resize_root_window, grow_mini_window)
119 (shrink_mini_window): Rename Qresize_root_window to
120 Qwindow_resize_root_window and Qresize_root_window_vertically to
121 Qwindow_resize_root_window_vertically.
122
123 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
124
125 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
126
127 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
128
129 * makefile.w32-in: Redesign dependencies so they reflect more
130 clearly which files are directly included by each source file,
131 and not through other includes.
132
133 2011-06-27 Martin Rudalics <rudalics@gmx.at>
134
135 * buffer.c (Qclone_number): Declare static and DEFSYM it.
136 (sort_overlays, overlay_strings): When an overlay's clone number
137 matches the window's clone number process the overlay even if
138 the overlay's window property doesn't match the current window.
139
140 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
141 (Fwindow_hchild): Rename to Fwindow_left_child.
142 (Fwindow_next): Rename to Fwindow_next_sibling.
143 (Fwindow_prev): Rename to Fwindow_prev_sibling.
144 (resize_window_check): Rename to window_resize_check.
145 (resize_window_apply): Rename to window_resize_apply.
146 (Fresize_window_apply): Rename to Fwindow_resize_apply.
147 (Fdelete_other_windows_internal, resize_frame_windows)
148 (Fsplit_window_internal, Fdelete_window_internal)
149 (grow_mini_window, shrink_mini_window)
150 (Fresize_mini_window_internal): Fix callers accordingly.
151
152 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
153
154 * emacsgtkfixed.h: State that this is only used with Gtk+3.
155 (emacs_fixed_set_min_size): Remove.
156 (emacs_fixed_new): Take frame as argument.
157
158 * emacsgtkfixed.c: State that this is only used with Gtk+3.
159 (_EmacsFixedPrivate): Remove minwidth/height.
160 Add struct frame *f.
161 (emacs_fixed_init): Initialize priv->f.
162 (get_parent_class, emacs_fixed_set_min_size): Remove.
163 (emacs_fixed_new): Set priv->f to argument.
164 (emacs_fixed_get_preferred_width)
165 (emacs_fixed_get_preferred_height): Use min_width/height from
166 frames size_hint to set minimum and natural (Bug#8919).
167 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
168 and use min_width/height from frames size_hint to set
169 min_width/height (Bug#8919).
170
171 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
172 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
173 indentation.
174
175 2011-06-26 Eli Zaretskii <eliz@gnu.org>
176
177 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
178 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
179 called at ZV.
180
181 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
182
183 * process.c (wait_reading_process_output): Bypass select if
184 waiting for a cell while ignoring keyboard input, and input is
185 pending. Suggested by Jan Djärv (Bug#8869).
186
187 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
188
189 Use gnulib's dup2 module instead of rolling our own.
190 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
191
192 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
193
194 * dispnew.c (scrolling_window): Before scrolling, turn off a
195 mouse-highlight in the window being scrolled.
196
197 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
198
199 Move DEFSYM to lisp.h and use everywhere.
200
201 * character.h (DEFSYM): Move declaration...
202 * lisp.h (DEFSYM): ...here.
203
204 * gnutls.c:
205 * minibuf.c:
206 * w32menu.c:
207 * w32proc.c:
208 * w32select.c: Don't include character.h.
209
210 * alloc.c (syms_of_alloc):
211 * buffer.c (syms_of_buffer):
212 * bytecode.c (syms_of_bytecode):
213 * callint.c (syms_of_callint):
214 * casefiddle.c (syms_of_casefiddle):
215 * casetab.c (init_casetab_once):
216 * category.c (init_category_once, syms_of_category):
217 * ccl.c (syms_of_ccl):
218 * cmds.c (syms_of_cmds):
219 * composite.c (syms_of_composite):
220 * dbusbind.c (syms_of_dbusbind):
221 * dired.c (syms_of_dired):
222 * dispnew.c (syms_of_display):
223 * doc.c (syms_of_doc):
224 * editfns.c (syms_of_editfns):
225 * emacs.c (syms_of_emacs):
226 * eval.c (syms_of_eval):
227 * fileio.c (syms_of_fileio):
228 * fns.c (syms_of_fns):
229 * frame.c (syms_of_frame):
230 * fringe.c (syms_of_fringe):
231 * insdel.c (syms_of_insdel):
232 * keymap.c (syms_of_keymap):
233 * lread.c (init_obarray, syms_of_lread):
234 * macros.c (syms_of_macros):
235 * msdos.c (syms_of_msdos):
236 * print.c (syms_of_print):
237 * process.c (syms_of_process):
238 * search.c (syms_of_search):
239 * sound.c (syms_of_sound):
240 * syntax.c (init_syntax_once, syms_of_syntax):
241 * terminal.c (syms_of_terminal):
242 * textprop.c (syms_of_textprop):
243 * undo.c (syms_of_undo):
244 * w32.c (globals_of_w32):
245 * window.c (syms_of_window):
246 * xdisp.c (syms_of_xdisp):
247 * xfaces.c (syms_of_xfaces):
248 * xfns.c (syms_of_xfns):
249 * xmenu.c (syms_of_xmenu):
250 * xsettings.c (syms_of_xsettings):
251 * xterm.c (syms_of_xterm): Use DEFSYM.
252
253 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
254
255 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
256
257 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
258
259 Integer and buffer overflow fixes (Bug#8873).
260
261 * print.c (printchar, strout): Check for string overflow.
262 (PRINTPREPARE, printchar, strout):
263 Don't set size unless allocation succeeds.
264
265 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
266 for sizes. Check for string overflow more accurately.
267 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
268
269 * macros.c: Integer and buffer overflow fixes.
270 * keyboard.h (struct keyboard.kbd_macro_bufsize):
271 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
272 Use ptrdiff_t, not int, for sizes.
273 Don't increment bufsize until after realloc succeeds.
274 Check for size-calculation overflow.
275 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
276
277 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
278
279 * lread.c: Integer overflow fixes.
280 (read_integer): Radix is now EMACS_INT, not int,
281 to improve quality of diagnostics for out-of-range radices.
282 Calculate buffer size correctly for out-of-range radices.
283 (read1): Check for integer overflow in radices, and in
284 read-circle numbers.
285 (read_escape): Avoid int overflow.
286 (Fload, openp, read_buffer_size, read1)
287 (substitute_object_recurse, read_vector, read_list, map_obarray):
288 Use ptrdiff_t, not int, for sizes.
289 (read1): Use EMACS_INT, not int, for sizes.
290 Check for size overflow.
291
292 * image.c (cache_image): Check for size arithmetic overflow.
293
294 * lread.c: Integer overflow issues.
295 (saved_doc_string_size, saved_doc_string_length)
296 (prev_saved_doc_string_size, prev_saved_doc_string_length):
297 Now ptrdiff_t, not int.
298 (read1): Don't assume doc string length fits in int. Check for
299 out-of-range doc string lengths.
300 (read_list): Don't assume file position fits in int.
301 (read_escape): Check for hex character overflow.
302
303 2011-06-22 Leo Liu <sdl.web@gmail.com>
304
305 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
306 Move to minibuffer.el.
307
308 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
309
310 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
311 The following patches are for when GLYPH_DEBUG && !XASSERT.
312 * dispextern.h (trace_redisplay_p, dump_glyph_string):
313 * dispnew.c (flush_stdout):
314 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
315 Mark as externally visible.
316 * dispnew.c (check_window_matrix_pointers): Now static.
317 * dispnew.c (window_to_frame_vpos):
318 * xfns.c (unwind_create_frame):
319 * xterm.c (x_check_font): Remove unused local.
320 * scroll.c (CHECK_BOUNDS):
321 * xfaces.c (cache_fache): Rename local to avoid shadowing.
322 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
323 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
324 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
325 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
326 Now static.
327 (debug_method_add): Use va_list and vsprintf rather than relying
328 on undefined behavior with wrong number of arguments.
329 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
330 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
331 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
332 since we're not interested in debugging glyphs with old libraries.
333 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
334 GCC 4.6.0's static checking.
335
336 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
337
338 Integer overflow and signedness fixes (Bug#8873).
339 A few related buffer overrun fixes, too.
340
341 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
342
343 * dispextern.h (struct face.stipple):
344 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
345 (x_bitmap_mask, x_allocate_bitmap_record)
346 (x_create_bitmap_from_data, x_create_bitmap_from_file)
347 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
348 (x_create_bitmap_from_xpm_data):
349 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
350 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
351 (.bitmaps_last):
352 * xfaces.c (load_pixmap):
353 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
354 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
355 (.bitmaps_last, struct x_output.icon_bitmap):
356 Use ptrdiff_t, not int, for bitmap indexes.
357 (x_allocate_bitmap_record): Check for size overflow.
358 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
359
360 Use ptrdiff_t, not int, for overlay counts.
361 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
362 * editfns.c (overlays_around, get_pos_property):
363 * textprop.c (get_char_property_and_overlay):
364 * xdisp.c (next_overlay_change, note_mouse_highlight):
365 * xfaces.c (face_at_buffer_position):
366 * buffer.c (OVERLAY_COUNT_MAX): New macro.
367 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
368 (Fnext_overlay_change, Fprevious_overlay_change)
369 (mouse_face_overlay_overlaps, Foverlays_in):
370 Use ptrdiff_t, not int, for sizes.
371 (overlays_at, overlays_in): Check for size-calculation overflow.
372
373 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
374
375 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
376 (x_session_initialize): Do not assume string length fits in int.
377
378 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
379 This is unlikely, but can occur if DPI is outlandish.
380
381 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
382 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
383
384 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
385 * xrdb.c (magic_file_p, search_magic_path):
386 Omit last arg SUFFIX; it was always 0. All callers changed.
387 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
388
389 * xfont.c (xfont_match): Avoid need for strlen.
390
391 * xfns.c: Don't assume strlen fits in int.
392 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
393
394 * xdisp.c (message_log_check_duplicate): Return intmax_t,
395 not unsigned long, as we prefer signed integers. All callers changed.
396 Detect integer overflow in repeat count.
397 (message_dolog): Don't assume print length fits in 39 bytes.
398 (display_mode_element): Don't assume strlen fits in int.
399
400 * termcap.c: Don't assume sizes fit in int and never overflow.
401 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
402 (gobble_line): Check for size-calculation overflow.
403
404 * minibuf.c (Fread_buffer):
405 * lread.c (intern, intern_c_string):
406 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
407 Don't assume string length fits in int.
408
409 * keyboard.c (parse_tool_bar_item):
410 * gtkutil.c (style_changed_cb): Avoid need for strlen.
411
412 * font.c: Don't assume string length fits in int.
413 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
414 Use ptrdiff_t, not int.
415 (font_intern_prop): Don't assume string length fits in int.
416 Don't assume integer property fits in fixnum.
417 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
418
419 * filelock.c: Fix some buffer overrun and integer overflow issues.
420 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
421 Reformulate so as not to need the command string.
422 Invoke gzip -cd rather than gunzip, as it's more portable.
423 (lock_info_type, lock_file_1, lock_file):
424 Don't assume pid_t and time_t fit in unsigned long.
425 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
426 (current_lock_owner): Prefer signed type for sizes.
427 Use memcpy, not strncpy, where memcpy is what is really wanted.
428 Don't assume (via atoi) that time_t and pid_t fit in int.
429 Check for time_t and/or pid_t out of range, e.g., via a network share.
430 Don't alloca where an auto var works fine.
431
432 * fileio.c: Fix some integer overflow issues.
433 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
434 Don't assume string length fits in int.
435 (directory_file_name): Don't assume string length fits in long.
436 (make_temp_name): Don't assume pid fits in int, or that its print
437 length is less than 20.
438
439 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
440
441 * coding.c (make_subsidiaries): Don't assume string length fits in int.
442
443 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
444
445 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
446 We prefer signed integers, even for size calculations.
447
448 * emacs.c: Don't assume string length fits in 'int'.
449 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
450 (main): Don't invoke strlen when not needed.
451
452 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
453 (XD_DEBUG_MESSAGE): Don't waste a byte.
454
455 * callproc.c (getenv_internal_1, getenv_internal)
456 (Fgetenv_internal):
457 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
458
459 * lread.c (invalid_syntax): Omit length argument.
460 All uses changed. This doesn't fix a bug, but it simplifies the
461 code away from its former Hollerith-constant appearance, and it's
462 one less 'int' to worry about when looking at integer-overflow issues.
463 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
464
465 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
466 This didn't break anything, but it didn't help either.
467 It's confusing to put a bogus integer in a place where the actual
468 value does not matter.
469 (LIST_END_P): Remove unused macro and its bogus comment.
470 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
471
472 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
473 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
474 implementation.
475 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
476 We prefer signed types, and the value cannot exceed the EMACS_INT
477 range anyway (because otherwise the length would not be representable).
478 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
479 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
480 This avoids a GCC warning when WIDE_EMACS_INT.
481
482 * indent.c (sane_tab_width): New function.
483 (current_column, scan_for_column, Findent_to, position_indentation)
484 (compute_motion): Use it. This is just for clarity.
485 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
486
487 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
488
489 * lisp.h (lint_assume): New macro.
490 * composite.c (composition_gstring_put_cache):
491 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
492
493 * editfns.c, insdel.c:
494 Omit unnecessary forward decls, to simplify future changes.
495
496 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
497
498 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
499
500 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
501 Use much-faster test for byte-length change.
502 Don't assume string byte-length fits in 'int'.
503 Check that character arg fits in 'int'.
504 (mapcar1): Declare byte as byte, for clarity.
505
506 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
507
508 * fns.c (concat): Catch string overflow earlier.
509 Do not rely on integer wraparound.
510
511 * dispextern.h (struct it.overlay_strings_charpos)
512 (struct it.selective): Now EMACS_INT, not int.
513 * xdisp.c (forward_to_next_line_start)
514 (back_to_previous_visible_line_start)
515 (reseat_at_next_visible_line_start, next_element_from_buffer):
516 Don't arbitrarily truncate the value of 'selective' to int.
517
518 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
519
520 * composite.c: Don't truncate sizes to 'int'.
521 (composition_gstring_p, composition_reseat_it)
522 (composition_adjust_point): Use EMACS_INT, not int.
523 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
524 not EMACS_UINT, for indexes.
525
526 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
527
528 * buffer.c: Include <verify.h>.
529 (struct sortvec.priority, struct sortstr.priority):
530 Now EMACS_INT, not int.
531 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
532 (struct sortstr.size, record_overlay_string)
533 (struct sortstrlist.size, struct sortlist.used):
534 Don't truncate size to int.
535 (record_overlay_string): Check for size-calculation overflow.
536 (init_buffer_once): Check at compile-time, not run-time.
537
538 2011-06-22 Jim Meyering <meyering@redhat.com>
539
540 Don't leak an XBM-image-sized buffer
541 * image.c (xbm_load): Free the image buffer after using it.
542
543 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
544
545 Port to Sun C.
546 * composite.c (find_automatic_composition): Omit needless 'return 0;'
547 that Sun C diagnosed.
548 * fns.c (secure_hash): Fix pointer signedness issue.
549 * intervals.c (static_offset_intervals): New function.
550 (offset_intervals): Use it.
551
552 2011-06-21 Leo Liu <sdl.web@gmail.com>
553
554 * deps.mk (fns.o):
555 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
556 sha512.h.
557
558 * fns.c (secure_hash): Rename from crypto_hash_function and change
559 the first arg to accept symbols.
560 (Fsecure_hash): New primitive.
561 (syms_of_fns): New symbols.
562
563 2011-06-20 Deniz Dogan <deniz@dogan.se>
564
565 * process.c (Fset_process_buffer): Clarify return value in
566 docstring.
567
568 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
569
570 * dispnew.c (add_window_display_history): Use BVAR.
571
572 * xdisp.c (debug_method_add): Use BVAR.
573 (check_window_end, dump_glyph_matrix, dump_glyph)
574 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
575
576 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
577 Likewise.
578
579 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
580 check till after the cache is created in init_frame_faces.
581
582 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
583
584 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
585
586 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
587
588 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
589 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
590 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
591
592 Improve buffer-overflow checking (Bug#8873).
593 * fileio.c (Finsert_file_contents):
594 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
595 Remove the old (too-loose) buffer overflow checks.
596 They weren't needed, since make_gap checks for buffer overflow.
597 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
598 The old code merely checked for Emacs fixnum overflow, and relied
599 on undefined (wraparound) behavior. The new code avoids undefined
600 behavior, and also checks for ptrdiff_t and/or size_t overflow.
601
602 * editfns.c (Finsert_char): Don't dump core with very negative counts.
603 Tune. Don't use wider integers than needed. Don't use alloca.
604 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
605
606 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
607
608 * insdel.c, lisp.h (buffer_overflow): New function.
609 (insert_from_buffer_1, replace_range, replace_range_2):
610 * insdel.c (make_gap_larger):
611 * editfns.c (Finsert_char):
612 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
613
614 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
615
616 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
617
618 Integer overflow and signedness fixes (Bug#8873).
619
620 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
621 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
622
623 * fileio.c: Don't assume EMACS_INT fits in off_t.
624 (emacs_lseek): New static function.
625 (Finsert_file_contents, Fwrite_region): Use it.
626 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
627
628 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
629
630 * fns.c: Don't overflow int when computing a list length.
631 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
632 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
633 truncation on 64-bit hosts. Check for QUIT every
634 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
635 faster and is responsive enough.
636 (Flength): Report an error instead of overflowing an integer.
637 (Fsafe_length): Return a float if the value is not representable
638 as a fixnum. This shouldn't happen except in contrived situations.
639 (Fnthcdr, Fsort): Don't assume list length fits in int.
640 (Fcopy_sequence): Don't assume vector length fits in int.
641
642 * alloc.c: Check that resized vectors' lengths fit in fixnums.
643 (header_size, word_size): New constants.
644 (allocate_vectorlike): Don't check size overflow here.
645 (allocate_vector): Check it here instead, since this is the only
646 caller of allocate_vectorlike that could cause overflow.
647 Check that the new vector's length is representable as a fixnum.
648
649 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
650 The previous code was bogus. For example, next_almost_prime (32)
651 returned 39, which is undesirable as it is a multiple of 3; and
652 next_almost_prime (24) returned 25, which is a multiple of 5 so
653 why was the code bothering to check for multiples of 7?
654
655 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
656
657 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
658
659 Variadic C functions now count arguments with ptrdiff_t.
660 This partly undoes my 2011-03-30 change, which replaced int with size_t.
661 Back then I didn't know that the Emacs coding style prefers signed int.
662 Also, in the meantime I found a few more instances where arguments
663 were being counted with int, which may truncate counts on 64-bit
664 machines, or EMACS_INT, which may be unnecessarily wide.
665 * lisp.h (struct Lisp_Subr.function.aMANY)
666 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
667 Arg counts are now ptrdiff_t, not size_t.
668 All variadic functions and their callers changed accordingly.
669 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
670 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
671 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
672 * callint.c (Fcall_interactively): Check arg count for overflow,
673 to avoid potential buffer overrun. Use signed char, not 'int',
674 for 'varies' array, so that we needn't bother to check its size
675 calculation for overflow.
676 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
677 * eval.c (apply_lambda):
678 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
679 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
680 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
681
682 * callint.c (Fcall_interactively): Don't use index var as event count.
683
684 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
685 * mem-limits.h (SIZE): Remove; no longer used.
686
687 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
688
689 Remove unnecessary casts.
690 * xterm.c (x_term_init):
691 * xfns.c (x_set_border_pixel):
692 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
693 These aren't needed now that we assume ANSI C.
694
695 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
696 It's more likely to cause problems (due to unsigned overflow)
697 than to cure them.
698
699 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
700
701 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
702
703 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
704
705 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
706
707 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
708
709 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
710
711 GLYPH_CODE_FACE returns EMACS_INT, not int.
712 * dispextern.h (merge_faces):
713 * xfaces.c (merge_faces):
714 * xdisp.c (get_next_display_element, next_element_from_display_vector):
715 Don't assume EMACS_INT fits in int.
716
717 * character.h (CHAR_VALID_P): Remove unused parameter.
718 * fontset.c, lisp.h, xdisp.c: All uses changed.
719
720 * editfns.c (Ftranslate_region_internal): Omit redundant test.
721
722 * fns.c (concat): Minor tuning based on overflow analysis.
723 This doesn't fix any bugs. Use int to hold character, instead
724 of constantly refetching from Emacs object. Use XFASTINT, not
725 XINT, for value known to be a character. Don't bother comparing
726 a single byte to 0400, as it's always less.
727
728 * floatfns.c (Fexpt):
729 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
730
731 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
732 for characters.
733
734 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
735
736 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
737 Without this fix, on a 64-bit host (aset S 0 4294967386) would
738 incorrectly succeed when S was a string, because 4294967386 was
739 truncated before it was used.
740
741 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
742 Otherwise, an out-of-range integer could cause undefined behavior
743 on a 64-bit host.
744
745 * composite.c: Use int, not EMACS_INT, for characters.
746 (fill_gstring_body, composition_compute_stop_pos): Use int, not
747 EMACS_INT, for values that are known to be in character range.
748 This doesn't fix any bugs but is the usual style inside Emacs and
749 may generate better code on 32-bit machines.
750
751 Make sure a 64-bit char is never passed to ENCODE_CHAR.
752 This is for reasons similar to the recent CHAR_STRING fix.
753 * charset.c (Fencode_char): Check that character arg is actually
754 a character. Pass an int to ENCODE_CHAR.
755 * charset.h (ENCODE_CHAR): Verify that the character argument is no
756 wider than 'int', as a compile-time check to prevent future regressions
757 in this area.
758
759 * character.c (char_string): Remove unnecessary casts.
760
761 Make sure a 64-bit char is never passed to CHAR_STRING.
762 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
763 by silently ignoring the top 32 bits, allowing some values
764 that were far too large to be valid characters.
765 * character.h: Include <verify.h>.
766 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
767 arguments are no wider than unsigned, as a compile-time check
768 to prevent future regressions in this area.
769 * data.c (Faset):
770 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
771 (Fsubst_char_in_region):
772 * fns.c (concat):
773 * xdisp.c (decode_mode_spec_coding):
774 Adjust to CHAR_STRING's new requirement.
775 * editfns.c (Finsert_char, Fsubst_char_in_region):
776 * fns.c (concat): Check that character args are actually
777 characters. Without this test, these functions did the wrong
778 thing with wildly out-of-range values on 64-bit hosts.
779
780 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
781 These casts should not be needed on 32-bit hosts, either.
782 * keyboard.c (read_char):
783 * lread.c (Fload): Remove casts to unsigned.
784
785 * lisp.h (UNSIGNED_CMP): New macro.
786 This fixes comparison bugs on 64-bit hosts.
787 (ASCII_CHAR_P): Use it.
788 * casefiddle.c (casify_object):
789 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
790 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
791 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
792 * dispextern.h (FACE_FROM_ID):
793 * keyboard.c (read_char): Use UNSIGNED_CMP.
794
795 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
796 not to EMACS_INT, to avoid GCC warning.
797
798 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
799
800 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
801 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
802 isn't needed on 32-bit machines.
803
804 * buffer.c (Fgenerate_new_buffer_name):
805 Use EMACS_INT for count, not int.
806 (advance_to_char_boundary): Return EMACS_INT, not int.
807
808 * data.c (Qcompiled_function): Now static.
809
810 * window.c (window_body_lines): Now static.
811
812 * image.c (gif_load): Rename local to avoid shadowing.
813
814 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
815 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
816 * alloc.c (make_save_value): Integer argument is now of type
817 ptrdiff_t, not int.
818 (mark_object): Use ptrdiff_t, not int.
819 * lisp.h (pD): New macro.
820 * print.c (print_object): Use it.
821
822 * alloc.c: Use EMACS_INT, not int, to count objects.
823 (total_conses, total_markers, total_symbols, total_vector_size)
824 (total_free_conses, total_free_markers, total_free_symbols)
825 (total_free_floats, total_floats, total_free_intervals)
826 (total_intervals, total_strings, total_free_strings):
827 Now EMACS_INT, not int. All uses changed.
828 (Fgarbage_collect): Compute overall total using a double, so that
829 integer overflow is less likely to be a problem. Check for overflow
830 when converting back to an integer.
831 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
832 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
833 These were 'int' variables that could overflow on 64-bit hosts;
834 they were never used, so remove them instead of repairing them.
835 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
836 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
837 Previously, this ceilinged at INT_MAX, but that doesn't work on
838 64-bit machines.
839 (allocate_pseudovector): Don't use EMACS_INT when int would do.
840
841 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
842 (allocate_vectorlike): Check for ptrdiff_t overflow.
843 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
844 when a (possibly-narrower) signed value would do just as well.
845 We prefer using signed arithmetic, to avoid comparison confusion.
846
847 * alloc.c: Catch some string size overflows that we were missing.
848 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
849 for convenience in STRING_BYTES_MAX.
850 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
851 The definition here is exact; the one in lisp.h was approximate.
852 (allocate_string_data): Check for string overflow. This catches
853 some instances we weren't catching before. Also, it catches
854 size_t overflow on (unusual) hosts where SIZE_MAX <= min
855 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
856 and ptrdiff_t and EMACS_INT are both 64 bits.
857
858 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
859 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
860 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
861
862 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
863
864 * alloc.c (Fmake_string): Check for out-of-range init.
865
866 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
869
870 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
871
872 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
873 xg_get_default_scrollbar_width.
874
875 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
876 (int_gtk_range_get_value): Move to the scroll bar part of the file.
877 (style_changed_cb): Call update_theme_scrollbar_width and call
878 x_set_scroll_bar_default_width and xg_frame_set_char_size for
879 all frames (Bug#8505).
880 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
881 Call gtk_window_set_resizable if HAVE_GTK3.
882 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
883 and height if HAVE_GTK3 (Bug#8505).
884 (scroll_bar_width_for_theme): New variable.
885 (update_theme_scrollbar_width): New function.
886 (xg_get_default_scrollbar_width): Move code to
887 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
888 (xg_initialize): Call update_theme_scrollbar_width.
889
890 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
891
892 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
893
894 2011-06-12 Martin Rudalics <rudalics@gmx.at>
895
896 * frame.c (make_frame): Call other_buffer_safely instead of
897 other_buffer.
898
899 * window.c (temp_output_buffer_show): Call display_buffer with
900 second argument Vtemp_buffer_show_specifiers and reset latter
901 immediately after the call.
902 (Vtemp_buffer_show_specifiers): New variable.
903 (auto_window_vscroll_p, next_screen_context_lines)
904 (Vscroll_preserve_screen_position): Remove leading asterisks from
905 doc-strings.
906
907 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
908
909 Fix minor problems found by GCC 4.6.0 static checking.
910 * buffer.c (Qclone_number): Remove for now, as it's unused.
911 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
912 (record_buffer): Remove unused local.
913 * frame.c (other_visible_frames, frame_buffer_list): Now static.
914 (set_frame_buffer_list): Remove; unused.
915 * frame.h (other_visible_frames): Remove decl.
916 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
917 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
918 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
919 if HAVE_GPM.
920 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
921 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
922 Define only if HAVE_GPM.
923 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
924 (update_hints_inhibit): Remove; never set. All uses removed.
925 * widgetprv.h (emacsFrameClassRec): Remove decl.
926 * window.c (delete_deletable_window): Now returns void, since it
927 wasn't returning anything.
928 (compare_window_configurations): Remove unused locals.
929 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
930 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
931 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
932 the same widths as pointers. This follows up on the 2011-05-06 patch.
933 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
934 * xterm.h: Likewise.
935 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
936
937 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
938
939 * makefile.w32-in: Update dependencies.
940 (LISP_H): Add lib/intprops.h.
941
942 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
943
944 * image.c (gif_load): Add animation frame delay to the metadata.
945 (syms_of_image): Use DEFSYM. New symbol `delay'.
946
947 2011-06-11 Martin Rudalics <rudalics@gmx.at>
948
949 * window.c (delete_deletable_window): Re-add.
950 (Fset_window_configuration): Rewrite to handle dead buffers and
951 consequently deletable windows.
952 (window_tree, Fwindow_tree): Remove. Supply functionality in
953 window.el.
954 (compare_window_configurations): Simplify code.
955
956 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
957
958 * image.c (imagemagick_load_image): Fix type mismatch.
959 (Fimagemagick_types): Likewise.
960
961 * window.h (replace_buffer_in_windows): Declare.
962
963 2011-06-11 Martin Rudalics <rudalics@gmx.at>
964
965 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
966 Qclone_number. Remove external declaration of Qdelete_window.
967 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
968 code.
969 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
970 Qbuffer_list_update_hook if allowed.
971 (Fother_buffer): Rewrite doc-string. Major rewrite for new
972 buffer list implementation.
973 (other_buffer_safely): New function.
974 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
975 calls to replace_buffer_in_windows and
976 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
977 if allowed.
978 (record_buffer): Inhibit quitting and rewrite using quittable
979 functions. Run Qbuffer_list_update_hook if allowed.
980 (Frecord_buffer, Funrecord_buffer): New functions.
981 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
982 switch-to-buffer to window.el.
983 (bury-buffer): Move to window.el.
984 (Vbuffer_list_update_hook): New variable.
985
986 * lisp.h (other_buffer_safely): Add prototype in buffer.c
987 section.
988
989 * window.h (resize_frame_windows): Move up in code.
990 (Fwindow_frame): Remove EXFUN.
991 (replace_buffer_in_all_windows): Remove prototype.
992 (replace_buffer_in_windows_safely): Add prototype.
993
994 * window.c: Declare Qdelete_window static again. Move down
995 declaration of select_count.
996 (Fnext_window, Fprevious_window): Rewrite doc-strings.
997 (Fother_window): Move to window.el.
998 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
999 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1000 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1001 window.el.
1002 (replace_buffer_in_windows): Implement by calling
1003 Qreplace_buffer_in_windows.
1004 (replace_buffer_in_all_windows): Remove with some functionality
1005 moved into replace_buffer_in_windows_safely.
1006 (replace_buffer_in_windows_safely): New function.
1007 (select_window_norecord, select_frame_norecord): Move in front
1008 of run_window_configuration_change_hook. Remove now obsolete
1009 declarations.
1010 (Fset_window_buffer): Rewrite doc-string. Call
1011 Qrecord_window_buffer.
1012 (keys_of_window): Move binding for other-window to window.el.
1013
1014 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1015
1016 * dispextern.h (struct image): Replace data member, whose int_val
1017 and ptr_val fields were not used by anything, with a single
1018 lisp_val object.
1019
1020 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1021 (gif_clear_image, gif_load, imagemagick_load_image)
1022 (gs_clear_image, gs_load): Callers changed.
1023
1024 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * buffer.h: Include <time.h>, for time_t.
1027 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1028
1029 Fix minor problems found by static checking.
1030
1031 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1032
1033 Make identifiers static if they are not used in other modules.
1034 * data.c (Qcompiled_function, Qframe, Qvector):
1035 * image.c (QimageMagick, Qsvg):
1036 * minibuf.c (Qmetadata):
1037 * window.c (resize_window_check, resize_root_window): Now static.
1038 * window.h (resize_window_check, resize_root_window): Remove decls.
1039
1040 * window.c (window_deletion_count, delete_deletable_window):
1041 Remove; unused.
1042 (window_body_lines): Now static.
1043 (Fdelete_other_windows_internal): Mark vars as initialized.
1044 Make sure 'resize_failed' is initialized.
1045 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1046 (resize_window_apply): Remove unused local.
1047 * window.h (delete_deletable_window): Remove decl.
1048
1049 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1050 (imagemagick_load_image): Fix pointer signedness problem by changing
1051 last arg from unsigned char * to char *. All uses changed.
1052 Also, fix a local for similar reasons.
1053 Remove unused locals. Remove locals to avoid shadowing.
1054 (fn_rsvg_handle_free): Remove; unused.
1055 (svg_load, svg_load_image): Fix pointer signedness problem.
1056 (imagemagick_load_image): Don't use garbage pointer image_wand.
1057
1058 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1059
1060 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1061
1062 * image.c (gif_load): Fix omitted cast error introduced by
1063 2011-06-06 change.
1064
1065 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1066
1067 * window.h (resize_proportionally, orig_total_lines)
1068 (orig_top_line): Remove from window structure.
1069 (set_window_height, set_window_width, change_window_heights)
1070 (Fdelete_window): Remove prototypes.
1071 (resize_frame_windows): Remove duplicate declaration.
1072
1073 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1074
1075 * window.h (resize_frame_windows, resize_window_check)
1076 (delete_deletable_window, resize_root_window)
1077 (resize_frame_windows): Declare prototypes.
1078
1079 * window.c (resize_window_apply): Make definition be "static" to
1080 match the prototype.
1081
1082 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1083
1084 * window.c: Remove declarations of Qwindow_size_fixed,
1085 window_min_size_1, window_min_size_2, window_min_size,
1086 size_window, window_fixed_size_p, enlarge_window, delete_window.
1087 Remove static from declaration of Qdelete_window, it's
1088 temporarily needed by Fbury_buffer.
1089 (replace_window): Don't assign orig_top_line and
1090 orig_total_lines.
1091 (Fdelete_window, delete_window): Remove. Window deletion is
1092 handled by window.el.
1093 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1094 Fdelete_window calls with calls to Qdelete_window.
1095 (Fdelete_other_windows): Remove. Deleting other windows is
1096 handled by window.el.
1097 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1098 handled in window.el.
1099 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1100 Window minimum sizes are handled in window.el.
1101 (shrink_windows, size_window, set_window_height)
1102 (set_window_width, change_window_heights, window_height)
1103 (window_width, CURBEG, CURSIZE, enlarge_window)
1104 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1105 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1106 handled in window.el.
1107 (make_dummy_parent): Rename to make_parent_window and give it a
1108 second argument horflag.
1109 (make_window): Don't set resize_proportionally any more.
1110 (Fsplit_window): Remove. Windows are split in window.el.
1111 (save_restore_action, save_restore_orig_size)
1112 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1113 Resize mini windows in window.el.
1114 (grow_mini_window, shrink_mini_window): Implement by calling
1115 Qresize_root_window_vertically, resize_window_check and
1116 resize_window_apply.
1117 (saved_window, Fset_window_configuration, save_window_save): Do
1118 not handle orig_top_line, orig_total_lines, and
1119 resize_proportionally.
1120 (window_min_height, window_min_width): Move to window.el.
1121 (keys_of_window): Move bindings for delete-other-windows,
1122 split-window, delete-window and enlarge-window to window.el.
1123
1124 * buffer.c: Temporarily extern Qdelete_window.
1125 (Fbury_buffer): Temporarily call Qdelete_window instead of
1126 Fdelete_window (Fbury_buffer will move to window.el soon).
1127
1128 * frame.c (set_menu_bar_lines_1): Remove code handling
1129 orig_top_line and orig_total_lines.
1130
1131 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1132 set_window_height but set heights directly.
1133 (change_frame_size_1): Use resize_frame_windows.
1134
1135 * xdisp.c (init_xdisp): Don't use set_window_height but set
1136 heights directly.
1137
1138 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1139 resize_frame_windows instead of change_window_heights and run
1140 run_window_configuration_change_hook.
1141
1142 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1143 instead of change_window_heights and run
1144 run_window_configuration_change_hook.
1145
1146 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1147
1148 * window.c (replace_window): Rename second argument REPLACEMENT to
1149 NEW. New third argument SETFLAG. Rewrite.
1150 (delete_window, make_dummy_parent): Call replace_window with
1151 third argument 1.
1152 (window_list_1): Move down in code.
1153 (run_window_configuration_change_hook): Move set_buffer part
1154 before select_frame_norecord part in order to unwind correctly.
1155 Rename count1 to count.
1156 (recombine_windows, delete_deletable_window, resize_root_window)
1157 (Fdelete_other_windows_internal)
1158 (Frun_window_configuration_change_hook, make_parent_window)
1159 (resize_window_check, resize_window_apply, Fresize_window_apply)
1160 (resize_frame_windows, Fsplit_window_internal)
1161 (Fdelete_window_internal, Fresize_mini_window_internal): New
1162 functions.
1163 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1164
1165 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1166
1167 * window.h (window): Add some new members to window structure -
1168 normal_lines, normal_cols, new_total, new_normal, clone_number,
1169 splits, nest, prev_buffers, next_buffers.
1170 (WINDOW_TOTAL_SIZE): Move here from window.c.
1171 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1172
1173 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1174 Remove.
1175 (make_dummy_parent): Set new members of windows structure.
1176 (make_window): Move down in code. Handle new members of window
1177 structure.
1178 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1179 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1180 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1181 (Fset_window_prev_buffers, Fwindow_next_buffers)
1182 (Fset_window_next_buffers, Fset_window_clone_number): New
1183 functions.
1184 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1185 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1186 Doc-string fixes.
1187 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1188 Argument WINDOW can be now internal window too.
1189 (Fwindow_use_time): Move up in code.
1190 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1191 Rewrite doc-string.
1192 (Fset_window_configuration, saved_window)
1193 (Fcurrent_window_configuration, save_window_save): Handle new
1194 members of window structure.
1195 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1196 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1197 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1198 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1199 Qget_mru_window, Qresize_root_window,
1200 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1201 Qauto_buffer_name; staticpro them.
1202
1203 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1204
1205 * window.c (Fwindow_total_size, Fwindow_left_column)
1206 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1207 (Fwindow_list_1): New functions.
1208 (window_box_text_cols): Replace with window_body_cols.
1209 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1210 window_body_cols instead of window_box_text_cols.
1211 (delete_window, Fset_window_configuration): Call
1212 delete_all_subwindows with window as argument.
1213 (delete_all_subwindows): Take a window as argument and not a
1214 structure. Rewrite.
1215 (window_loop): Remove handling of GET_LRU_WINDOW and
1216 GET_LARGEST_WINDOW.
1217 (Fget_lru_window, Fget_largest_window): Move to window.el.
1218
1219 * window.h: Extern window_body_cols instead of
1220 window_box_text_cols. delete_all_subwindows now takes a
1221 Lisp_Object as argument.
1222
1223 * indent.c (compute_motion, Fcompute_motion): Use
1224 window_body_cols instead of window_box_text_cols.
1225
1226 * frame.c (delete_frame): Call delete_all_subwindows with root
1227 window as argument.
1228
1229 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1230
1231 * fns.c (Fputhash): Document return value.
1232
1233 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1234
1235 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1236
1237 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 Cons<->int and similar integer overflow fixes (Bug#8794).
1240
1241 Check for overflow when converting integer to cons and back.
1242 * charset.c (Fdefine_charset_internal, Fdecode_char):
1243 Use cons_to_unsigned to catch overflow.
1244 (Fencode_char): Use INTEGER_TO_CONS.
1245 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1246 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1247 * data.c (long_to_cons, cons_to_long): Remove.
1248 (cons_to_unsigned, cons_to_signed): New functions.
1249 These signal an error for invalid or out-of-range values.
1250 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1251 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1252 * font.c (Ffont_variation_glyphs):
1253 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1254 * lisp.h: Include <intprops.h>.
1255 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1256 (cons_to_signed, cons_to_unsigned): New decls.
1257 (long_to_cons, cons_to_long): Remove decls.
1258 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1259 (Fprimitive_undo): Use CONS_TO_INTEGER.
1260 * xfns.c (Fx_window_property): Likewise.
1261 * xselect.c: Include <limits.h>.
1262 (x_own_selection, selection_data_to_lisp_data):
1263 Use INTEGER_TO_CONS.
1264 (x_handle_selection_request, x_handle_selection_clear)
1265 (x_get_foreign_selection, Fx_disown_selection_internal)
1266 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1267 (lisp_data_to_selection_data): Use cons_to_unsigned.
1268 (x_fill_property_data): Use cons_to_signed.
1269 Report values out of range.
1270
1271 Check for buffer and string overflow more precisely.
1272 * buffer.h (BUF_BYTES_MAX): New macro.
1273 * lisp.h (STRING_BYTES_MAX): New macro.
1274 * alloc.c (Fmake_string):
1275 * character.c (string_escape_byte8):
1276 * coding.c (coding_alloc_by_realloc):
1277 * doprnt.c (doprnt):
1278 * editfns.c (Fformat):
1279 * eval.c (verror):
1280 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1281 since they may not be the same number.
1282 * editfns.c (Finsert_char):
1283 * fileio.c (Finsert_file_contents):
1284 Likewise for BUF_BYTES_MAX.
1285
1286 * image.c: Use ptrdiff_t, not int, for sizes.
1287 (slurp_file): Switch from int to ptrdiff_t.
1288 All uses changed.
1289 (slurp_file): Check that file size fits in both size_t (for
1290 malloc) and ptrdiff_t (for sanity and safety).
1291
1292 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1293 if b->modtime has its maximal value.
1294
1295 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1296
1297 Don't assume time_t can fit into int.
1298 * buffer.h (struct buffer.modtime): Now time_t, not int.
1299 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1300 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1301
1302 Minor fixes for signed vs unsigned integers.
1303 * character.h (MAYBE_UNIFY_CHAR):
1304 * charset.c (maybe_unify_char):
1305 * keyboard.c (read_char, reorder_modifiers):
1306 XINT -> XFASTINT, since the integer must be nonnegative.
1307 * ftfont.c (ftfont_spec_pattern):
1308 * keymap.c (access_keymap, silly_event_symbol_error):
1309 XUINT -> XFASTINT, since the integer must be nonnegative.
1310 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1311 since it makes no difference and we prefer signed.
1312 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1313 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1314 nonnegative.
1315
1316 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1317
1318 * window.h (Fwindow_frame): Declare.
1319
1320 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1323 (SPARE_MEMORY): Always define.
1324 (LARGE_REQUEST): Remove.
1325 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1326
1327 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1328
1329 * lisp.h: Move EXFUNS for Fframe_root_window,
1330 Fframe_first_window and Fset_frame_selected_window to window.h.
1331
1332 * window.h: Move EXFUNS for Fframe_root_window,
1333 Fframe_first_window and Fset_frame_selected_window here from
1334 lisp.h.
1335
1336 * frame.c (Fwindow_frame, Fframe_first_window)
1337 (Fframe_root_window, Fframe_selected_window)
1338 (Fset_frame_selected_window): Move to window.c.
1339 (Factive_minibuffer_window): Move to minibuf.c.
1340 (Fother_visible_frames_p): New function.
1341
1342 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1343
1344 * window.c (decode_window, decode_any_window): Move up in code.
1345 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1346 (inhibit_frame_unsplittable): Remove unused variable.
1347 (Fwindow_buffer): Move up and rewrite doc-string.
1348 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1349 (Fwindow_prev): New functions.
1350 (Fwindow_frame): Move here from frame.c. Accept any window as
1351 argument.
1352 (Fframe_root_window, Fframe_first_window)
1353 (Fframe_selected_window): Move here from frame.c. Accept frame
1354 or arbitrary window as argument. Update doc-strings.
1355 (Fminibuffer_window): Move up in code.
1356 (Fwindow_minibuffer_p): Move up in code and simplify.
1357 (Fset_frame_selected_window): Move here from frame.c.
1358 Marginal rewrite.
1359 (Fselected_window, select_window, Fselect_window): Move up in
1360 code. Minor doc-string fixes.
1361
1362 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1365 Do not assume that spare memory exists; that assumption is valid
1366 only if SYSTEM_MALLOC.
1367 (LARGE_REQUEST): New macro, so that the issue of large requests
1368 is separated from the issue of spare memory.
1369
1370 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1371
1372 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1373 format. (Bug#8806)
1374
1375 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1376
1377 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1378 before statements.
1379
1380 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1381
1382 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1383
1384 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1385
1386 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1387 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1388
1389 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1392
1393 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1394
1395 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1396 (x_clipboard_manager_save): Add return value.
1397 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1398 New error handlers.
1399 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1400 Obey Vx_select_enable_clipboard_manager. Catch errors in
1401 x_clipboard_manager_save (Bug#8779).
1402 (Vx_select_enable_clipboard_manager): New variable.
1403 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1404
1405 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1406
1407 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1408
1409 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1410
1411 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1412 in the current matrix if keep_current_p is non-zero.
1413
1414 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1415
1416 * bidi.c (bidi_level_of_next_char): Fix last change.
1417
1418 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1419
1420 Support bidi reordering of text covered by display properties.
1421
1422 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1423 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1424 (bidi_cache_search, bidi_cache_iterator_state)
1425 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1426 (bidi_level_of_next_char, bidi_move_to_visually_next):
1427 Support character positions inside a run of characters covered by a
1428 display string.
1429 (bidi_paragraph_init, bidi_resolve_explicit_1)
1430 (bidi_level_of_next_char): Call bidi_fetch_char and
1431 bidi_fetch_char_advance instead of FETCH_CHAR and
1432 FETCH_CHAR_ADVANCE.
1433 (bidi_init_it): Initialize new members.
1434 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1435 definitions.
1436 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1437 instead of using explicit *_CHAR codes.
1438 (bidi_resolve_explicit, bidi_resolve_weak):
1439 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1440 bidirectional text is supported only in multibyte buffers.
1441 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1442 it to initialize the frame_window_p member of struct bidi_it.
1443 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1444 (bidi_resolve_explicit, bidi_resolve_weak)
1445 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1446 bidi_it->nchars is non-positive.
1447 (bidi_level_of_next_char): Don't try to lookup the cache for the
1448 next/previous character if nothing is cached there yet, or if we
1449 were just reseat()'ed to a new position.
1450
1451 * xdisp.c (set_cursor_from_row): Set start and stop points
1452 according to the row's direction when priming the loop that looks
1453 for the glyph on which to display cursor.
1454 (single_display_spec_intangible_p): Function deleted.
1455 (display_prop_intangible_p): Reimplement to call
1456 handle_display_spec instead of single_display_spec_intangible_p.
1457 Accept 3 additional arguments needed by handle_display_spec.
1458 This fixes incorrect cursor motion across display property with complex
1459 values: lists, `(when COND...)' forms, etc.
1460 (single_display_spec_string_p): Support property values that are
1461 lists with the argument STRING its top-level element.
1462 (display_prop_string_p): Fix the condition for processing a
1463 property that is a list to be consistent with handle_display_spec.
1464 (handle_display_spec): New function, refactored from the
1465 last portion of handle_display_prop.
1466 (compute_display_string_pos): Accept additional argument
1467 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1468 value of a `display' property is a "replacing spec".
1469 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1470 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1471 the display property, but just return a value indicating whether
1472 the display property will replace the characters it covers.
1473 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1474 frame_window_p members of struct bidi_it.
1475 (compute_display_string_pos, compute_display_string_end):
1476 New functions.
1477 (push_it): Accept second argument POSITION, where pop_it should
1478 jump to continue iteration.
1479 (reseat_1): Initialize bidi_it.disp_pos.
1480
1481 * keyboard.c (adjust_point_for_property): Adjust the call to
1482 display_prop_intangible_p to its new signature.
1483
1484 * dispextern.h (struct bidi_it): New member frame_window_p.
1485 (bidi_init_it): Update prototypes.
1486 (display_prop_intangible_p): Update prototype.
1487 (compute_display_string_pos, compute_display_string_end):
1488 Declare prototypes.
1489 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1490 EMACS_INT.
1491
1492 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Malloc failure behavior now depends on size of allocation.
1495 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1496 * lisp.h: Change signatures accordingly.
1497 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1498 All callers changed. (Bug#8762)
1499
1500 * gnutls.c: Use Emacs's memory allocators.
1501 Without this change, the gnutls library would invoke malloc etc.
1502 directly, which causes problems on non-SYNC_INPUT hosts, and which
1503 runs afoul of improving memory_full behavior. (Bug#8761)
1504 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1505 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1506 xfree instead of the default malloc, realloc, free.
1507 (Fgnutls_boot): No need to check for memory allocation failure,
1508 since xmalloc does that for us.
1509
1510 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1511 * category.c (hash_get_category_set):
1512 * ccl.c (ccl_driver):
1513 * charset.c (Fdefine_charset_internal):
1514 * charset.h (struct charset.hash_index):
1515 * composite.c (get_composition_id, gstring_lookup_cache)
1516 (composition_gstring_put_cache):
1517 * composite.h (struct composition.hash_index):
1518 * dispextern.h (struct image.hash):
1519 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1520 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1521 (hashfn_equal, hashfn_user_defined, make_hash_table)
1522 (maybe_resize_hash_table, hash_lookup, hash_put)
1523 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1524 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1525 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1526 * image.c (make_image, search_image_cache, lookup_image)
1527 (xpm_put_color_table_h):
1528 * lisp.h (struct Lisp_Hash_Table):
1529 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1530 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1531 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1532 * alloc.c (allocate_vectorlike):
1533 Check for overflow in vector size calculations.
1534 * ccl.c (ccl_driver):
1535 Check for overflow when converting EMACS_INT to int.
1536 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1537 need to be updated by these changes.
1538 * fns.c (make_hash_table, maybe_resize_hash_table):
1539 Check for integer overflow with large hash tables.
1540 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1541 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1542 (SXHASH_REDUCE): New macro.
1543 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1544 Use it instead of discarding useful hash info with large hash values.
1545 (sxhash_float): New function.
1546 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1547 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1548 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1549 Rewrite to use FIXNUM_BITS, as this simplifies things.
1550 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1551 Adjust signatures to match updated version of code.
1552 (consing_since_gc): Now EMACS_INT, since a single hash table can
1553 use more than INT_MAX bytes.
1554
1555 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1556
1557 Make it possible to build with GCC-4.6+ -O2 -flto.
1558
1559 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1560
1561 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1564 Call minibuffer-inactive-mode.
1565
1566 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1567
1568 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1569 Update dependencies.
1570
1571 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1572
1573 * data.c (init_data): Remove code for UTS, this system is not
1574 supported anymore.
1575
1576 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1577
1578 Don't force ./temacs to start in terminal mode.
1579
1580 * frame.c (make_initial_frame): Initialize faces in all cases, not
1581 only when CANNOT_DUMP is defined.
1582 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1583
1584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1585
1586 * dispnew.c (add_window_display_history): Use const for the string
1587 pointer. Remove declaration, not needed.
1588
1589 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 Use 'inline', not 'INLINE'.
1592 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1593 * alloc.c, fontset.c (INLINE): Remove.
1594 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1595 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1596 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1597 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1598 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1599
1600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1601
1602 Make it possible to run ./temacs.
1603
1604 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1605 syms_of_callproc does the same thing. Remove test for
1606 "initialized", do it in the caller.
1607 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1608
1609 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1610
1611 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1612 (read_minibuf): Use get_minibuffer.
1613 (syms_of_minibuf): Use DEFSYM.
1614 (Qmetadata): New var.
1615 * data.c (Qbuffer): Don't make it static.
1616 (syms_of_data): Use DEFSYM.
1617
1618 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1621 (CCL_CODE_MIN): New macro.
1622
1623 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1626
1627 * eval.c (Qdebug): Now static.
1628 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1629 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1630 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1631
1632 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1633
1634 * image.c: Various fixes to ImageMagick code comments.
1635 (Fimagemagick_types): Doc fix.
1636
1637 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 Minor fixes prompted by GCC 4.6.0 warnings.
1640
1641 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1642
1643 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1644 (x_clipboard_manager_save_all): Move extern decl to ...
1645 * xterm.h: ... here, so that it can be checked for consistency.
1646
1647 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1648
1649 * xselect.c (x_clipboard_manager_save_frame)
1650 (x_clipboard_manager_save_all): New functions.
1651 (Fx_clipboard_manager_save): Lisp function deleted.
1652
1653 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1654 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1655
1656 * xterm.h: Update prototype.
1657
1658 2011-05-28 William Xu <william.xwl@gmail.com>
1659
1660 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1661 exiting (Bug#8239).
1662
1663 2011-05-28 Jim Meyering <meyering@redhat.com>
1664
1665 Avoid a sign-extension bug in crypto_hash_function.
1666 * fns.c (to_uchar): Define.
1667 (crypto_hash_function): Use it to convert some newly-signed
1668 variables to unsigned, to avoid sign-extension bugs. For example,
1669 without this change, (md5 "truc") would evaluate to
1670 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1671 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1672 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1673
1674 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 Integer overflow fixes.
1677
1678 * dbusbind.c: Serial number integer overflow fixes.
1679 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1680 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1681 to hold a serial number that is too large for a fixnum.
1682 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1683 Check for serial numbers out of range. Decode any serial number
1684 that was so large that it became a float. (Bug#8722)
1685
1686 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1687 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1688 Use XFASTINT rather than XUINT when numbers are nonnegative.
1689 (xd_append_arg, Fdbus_method_return_internal):
1690 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1691 arguments, check that Lisp number is nonnegative, rather than
1692 silently wrapping negative numbers around. (Bug#8722)
1693 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1694 (Bug#8722)
1695
1696 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1697
1698 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1699
1700 ccl: add integer overflow checks
1701 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1702 (IN_INT_RANGE): New macros.
1703 (ccl_driver): Use them to check for integer overflow when
1704 decoding a CCL program. Many of the new checks are whether XINT (x)
1705 fits in int; it doesn't always, on 64-bit hosts. The new version
1706 doesn't catch all possible integer overflows, but it's an
1707 improvement. (Bug#8719)
1708
1709 * alloc.c (make_event_array): Use XINT, not XUINT.
1710 There's no need for unsigned here.
1711
1712 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1713 This follows up to the 2011-05-06 change that substituted uintptr_t
1714 for EMACS_INT. This case wasn't caught back then.
1715
1716 Rework Fformat to avoid integer overflow issues.
1717 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1718 now (part of C89). Include <verify.h>.
1719 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1720 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1721 (Fformat): Avoid the prepass trying to compute sizes; it was only
1722 approximate and thus did not catch overflow reliably. Instead, walk
1723 through the format just once, formatting and computing sizes as we go,
1724 checking for integer overflow at every step, and allocating a larger
1725 buffer as needed. Keep track separately whether the format is
1726 multibyte. Keep only the most-recently calculated precision, rather
1727 than them all. Record whether each argument has been converted to
1728 string. Use EMACS_INT, not int, for byte and char and arg counts.
1729 Support field widths and precisions larger than INT_MAX. Avoid
1730 sprintf's undefined behavior with conversion specifications such as %#d
1731 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1732 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1733 formatting out-of-range floating point numbers with int
1734 formats. (Bug#8668)
1735
1736 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1737
1738 * data.c: Avoid integer truncation in expressions involving floats.
1739 * data.c: Include <intprops.h>.
1740 (arith_driver): When there's an integer overflow in an expression
1741 involving floating point, convert the integers to floating point
1742 so that the resulting value does not suffer from catastrophic
1743 integer truncation. For example, on a 64-bit host (* 4
1744 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1745 Do not rely on undefined behavior after integer overflow.
1746
1747 merge count_size_as_multibyte, parse_str_to_multibyte
1748 * character.c, character.h (count_size_as_multibyte):
1749 Rename from parse_str_to_multibyte; all uses changed.
1750 Check for integer overflow.
1751 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1752 since it's now a duplicate of the other. This is more of
1753 a character than a buffer op, so better that it's in character.c.
1754 * fns.c, print.c: Adjust to above changes.
1755
1756 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1757
1758 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1759
1760 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1763 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1764 (x_clipboard_manager_save): Now static.
1765 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1766
1767 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1768 (crypto_hash_function): Now static.
1769 Fix pointer signedness problems. Avoid unnecessary initializations.
1770
1771 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1772
1773 * termhooks.h (Vselection_alist): Make it terminal-local.
1774
1775 * terminal.c (create_terminal): Initialize it.
1776
1777 * xselect.c: Support for clipboard managers.
1778 (Vselection_alist): Move to termhooks.h as terminal-local var.
1779 (LOCAL_SELECTION): New macro.
1780 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1781 (symbol_to_x_atom): Remove gratuitous arg.
1782 (x_handle_selection_request, lisp_data_to_selection_data)
1783 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1784 (x_own_selection, x_get_local_selection, x_convert_selection):
1785 New arg, specifying work frame. Use terminal-local Vselection_alist.
1786 (some_frame_on_display): Delete unused function.
1787 (Fx_own_selection_internal, Fx_get_selection_internal)
1788 (Fx_disown_selection_internal, Fx_selection_owner_p)
1789 (Fx_selection_exists_p): New optional frame arg.
1790 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1791 (x_handle_selection_clear): Don't treat other terminals with the
1792 same keyboard specially. Use the terminal-local Vselection_alist.
1793 (x_clear_frame_selections): Use Frun_hook_with_args.
1794
1795 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1796
1797 * xterm.h: Add support for those atoms.
1798
1799 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1800
1801 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1802 (converted_selections, conversion_fail_tag): New global variables.
1803 (x_selection_request_lisp_error): Free the above.
1804 (x_get_local_selection): Remove unnecessary code.
1805 (x_reply_selection_request): Args changed; handle arbitrary array
1806 of converted selections stored in converted_selections.
1807 Separate the XChangeProperty and SelectionNotify steps.
1808 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1809 (x_convert_selection): New function.
1810 (x_handle_selection_event): Simplify.
1811 (x_get_foreign_selection): Don't ignore incoming requests while
1812 waiting for an answer; this will fail when we implement
1813 SAVE_TARGETS, and seems unnecessary anyway.
1814 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1815 (Vx_sent_selection_functions): Doc fix.
1816
1817 2011-05-26 Leo Liu <sdl.web@gmail.com>
1818
1819 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1820
1821 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1822
1823 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1824
1825 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1826 for fringe update if it has periodic bitmap.
1827 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1828 and fringe_bitmap_periodic_p.
1829
1830 * fringe.c (get_fringe_bitmap_data): New function.
1831 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1832 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1833 row. Mark glyph row for fringe update if periodicity changed.
1834
1835 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1836 for fringe update unless it has periodic bitmap.
1837
1838 2011-05-25 Kenichi Handa <handa@m17n.org>
1839
1840 * xdisp.c (get_next_display_element): Set correct it->face_id for
1841 a static composition.
1842
1843 2011-05-24 Leo Liu <sdl.web@gmail.com>
1844
1845 * deps.mk (fns.o):
1846 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1847
1848 * fns.c (crypto_hash_function, Fsha1): New function.
1849 (Fmd5): Use crypto_hash_function.
1850 (syms_of_fns): Add Ssha1.
1851
1852 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * gnutls.c: Remove unused macros.
1855 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1856 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1857 Remove macros that are defined and never used.
1858 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1859
1860 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1861
1862 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1863 (Fx_get_selection_internal): Minor cleanup.
1864 (Fx_own_selection_internal): Rename arguments for consistency with
1865 select.el.
1866
1867 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1870
1871 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1872
1873 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1874
1875 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1876
1877 * dispnew.c (scrolling_window): Don't exclude the case that the
1878 last enabled row in the desired matrix touches the bottom boundary.
1879
1880 2011-05-21 Glenn Morris <rgm@gnu.org>
1881
1882 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1883 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1884 and add some more files.
1885
1886 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1887
1888 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1889 report_file_error introduced by the change from 2011-05-07.
1890
1891 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * systime.h (Time): Define only if emacs is defined.
1894 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1895 where the include path doesn't have X11/X.h by default. See
1896 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1897
1898 2011-05-20 Kenichi Handa <handa@m17n.org>
1899
1900 * composite.c (find_automatic_composition): Fix previous change.
1901
1902 2011-05-20 Glenn Morris <rgm@gnu.org>
1903
1904 * lisp.mk: New file, split from Makefile.in.
1905 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1906 (shortlisp): Remove.
1907 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1908
1909 2011-05-19 Glenn Morris <rgm@gnu.org>
1910
1911 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1912 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1913 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1914 (lisp): Set the order to that of loadup.el.
1915 (shortlisp): Make it a copy of $lisp.
1916 (SOME_MACHINE_LISP): Remove.
1917 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1918 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1919
1920 2011-05-18 Kenichi Handa <handa@m17n.org>
1921
1922 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1923 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1924 (find_automatic_composition): Mostly rewrite for efficiency.
1925
1926 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * makefile.w32-in: Update dependencies.
1929
1930 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1931
1932 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1933 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1934
1935 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 Fix some integer overflow issues, such as string length overflow.
1938
1939 * insdel.c (count_size_as_multibyte): Check for string overflow.
1940
1941 * character.c (lisp_string_width): Check for string overflow.
1942 Use EMACS_INT, not int, for string indexes and lengths; in
1943 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1944 the resulting string length overflows an EMACS_INT; instead,
1945 report a string overflow if no precision given. When checking for
1946 precision exhaustion, use a check that cannot possibly have
1947 integer overflow. (Bug#8675)
1948 * character.h (lisp_string_width): Adjust to new signature.
1949
1950 * alloc.c (string_overflow): New function.
1951 (Fmake_string): Use it. This doesn't change behavior, but saves
1952 a few bytes and will simplify future changes.
1953 * character.c (string_escape_byte8): Likewise.
1954 * lisp.h (string_overflow): New decl.
1955
1956 Fixups, following up to the user-interface timestamp change.
1957 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1958 for UI timestamps, instead of unsigned long.
1959 * msdos.c (mouse_get_pos): Likewise.
1960 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1961 * w32gui.h (Time): Define by including "systime.h" rather than by
1962 declaring it ourselves. (Bug#8664)
1963
1964 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1965 * image.c (clear_image_cache): Likewise.
1966
1967 * term.c (term_mouse_position): Don't assume time_t wraparound.
1968
1969 Be more systematic about user-interface timestamps.
1970 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1971 and sometimes 'EMACS_UINT', to represent these timestamps.
1972 This change causes it to use 'Time' uniformly, as that's what X uses.
1973 This makes the code easier to follow, and makes it easier to catch
1974 integer overflow bugs such as Bug#8664.
1975 * frame.c (Fmouse_position, Fmouse_pixel_position):
1976 Use Time, not unsigned long, for user-interface timestamps.
1977 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1978 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1979 * keyboard.h (last_event_timestamp): Likewise.
1980 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1981 * menu.h (xmenu_show): Likewise.
1982 * term.c (term_mouse_position): Likewise.
1983 * termhooks.h (struct input_event.timestamp): Likewise.
1984 (struct terminal.mouse_position_hook): Likewise.
1985 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1986 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1987 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1988 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1989 what it was before.
1990 * menu.h, termhooks.h: Include "systime.h", for Time.
1991
1992 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1993 Don't assume that the difference between two unsigned long values
1994 can fit into an integer. At this point, we know button_down_time
1995 <= event->timestamp, so the difference must be nonnegative, so
1996 there's no need to cast the result if double-click-time is
1997 nonnegative, as it should be; check that it's nonnegative, just in
1998 case. This bug is triggered when events are more than 2**31 ms
1999 apart (about 25 days). (Bug#8664)
2000
2001 * xselect.c (last_event_timestamp): Remove duplicate decl.
2002 (x_own_selection): Remove needless cast to unsigned long.
2003
2004 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2005 that always fit in int. Use a sentinel instead of a counter, to
2006 avoid a temp and to allay GCC's concerns about possible int overflow.
2007 * frame.h (struct frame): Use int for menu_bar_items_used
2008 instead of EMACS_INT, since it always fits in int.
2009
2010 * menu.c (grow_menu_items): Check for int overflow.
2011
2012 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2013
2014 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2015 Before, the code was not consistent. These values cannot exceed
2016 2**31 - 1 so there's no need to make them unsigned.
2017 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2018 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2019 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2020 as modifiers.
2021 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2022
2023 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2024 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2025 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2026 presumably because the widths might not match.
2027
2028 * window.c (size_window): Avoid needless test at loop start.
2029
2030 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2031
2032 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2033
2034 2011-05-12 Drew Adams <drew.adams@oracle.com>
2035
2036 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2037
2038 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2039
2040 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2041 `width' to `bar_area_x' and `bar_area_width', respectively.
2042 (x_scroll_run): Take account of fringe background extension.
2043
2044 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2045 Rename local vars `left' and `width' to `bar_area_x' and
2046 `bar_area_width', respectively.
2047 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2048 background extension.
2049
2050 2011-05-10 Jim Meyering <meyering@redhat.com>
2051
2052 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2053
2054 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2055
2056 * image.c (Finit_image_library): Return t for built-in image types,
2057 like pbm and xbm. (Bug#8640)
2058
2059 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2060
2061 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2062
2063 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2064
2065 * w32console.c (Fset_screen_color): Doc fix.
2066 (Fget_screen_color): New function.
2067 (syms_of_ntterm): Defsubr it.
2068
2069 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2070 unlink the temporary file if Fcall_process didn't create it in the
2071 first place.
2072 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2073 child process will be redirected to a file specified with `:file'.
2074 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2075 cue to call_process_cleanup not to close that handle.
2076
2077 2011-05-07 Ben Key <bkey76@gmail.com>
2078
2079 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2080 one of two shell specific rules, either bootstrap-temacs-CMD or
2081 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2082 to the previous implementation of the bootstrap-temacs rule.
2083 The bootstrap-temacs-CMD rule is similar to the previous
2084 implementation of the bootstrap-temacs rule except that it
2085 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2086 variable.
2087
2088 These changes, along with some changes to nt/configure.bat,
2089 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2090 earlier fix to add support for --cflags and --ldflags options
2091 that include quotes so that it works whether make uses cmd or
2092 sh as the shell.
2093
2094 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2095
2096 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2097 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2098 is a constant.
2099 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2100 a string. Handle both cases.
2101 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2102 (Fdbus_register_method): Use Qinvalid_function.
2103
2104 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2105
2106 * makefile.w32-in: Update dependencies.
2107 (LISP_H): Add inttypes.h and stdin.h.
2108 (PROCESS_H): Add unistd.h.
2109
2110 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2111
2112 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2113 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2114
2115 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2118
2119 * term.c (vfatal): Remove stray call to va_end.
2120 It's not needed and the C Standard doesn't allow it here anyway.
2121
2122 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2123 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2124
2125 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2126 bytes.
2127
2128 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2129
2130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2131
2132 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2133
2134 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2135
2136 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2137
2138 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2139 * charset.c (Fdefine_charset_internal): Don't initialize
2140 charset.code_space[15]. The value was garbage, on hosts with
2141 32-bit int (Bug#8600).
2142
2143 * lread.c (read_integer): Be more consistent with string-to-number.
2144 Use string_to_number to do the actual conversion; this avoids
2145 rounding errors and fixes some other screwups. Without this fix,
2146 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2147 (digit_to_number): Move earlier, for benefit of read_integer.
2148 Return -1 if the digit is out of range for the base, -2 if it is
2149 not a digit in any supported base. (Bug#8602)
2150
2151 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2152
2153 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2154 to match comment at start of function. This also removes a
2155 GCC warning about overflow in a 32+64-bit port.
2156
2157 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2158
2159 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2160 Reported by Stefan Monnier in
2161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2162 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2163 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2164
2165 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2166 (EMACS_UINTPTR): Likewise, with uintptr_t.
2167
2168 * lisp.h: Prefer 64-bit EMACS_INT if available.
2169 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2170 on 32-bit hosts that have 64-bit int, so that they can access
2171 large files.
2172 However, temporarily disable this change unless the temporary
2173 symbol WIDE_EMACS_INT is defined.
2174
2175 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2176
2177 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2178 This removes an assumption that EMACS_INT and long are the same
2179 width as pointers. The assumption is true for Emacs porting targets
2180 now, but we want to make other targets possible.
2181 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2182 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2183 In the rest of the code, change types of integers that hold casted
2184 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2185 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2186 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2187 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2188 No need to cast type when ORing.
2189 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2190 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2191 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2192 assume EMACS_INT is the same width as char *.
2193 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2194 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2195 Remove no-longer-needed casts.
2196 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2197 (xg_tool_bar_help_callback, xg_make_tool_item):
2198 Use EMACS_INTPTR to hold an integer
2199 that will be cast to void *; this can avoid a GCC warning
2200 if EMACS_INT is not the same width as void *.
2201 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2202 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2203 (current_message_1, set_message_1):
2204 Use a local to convert to proper width without a cast.
2205 * xmenu.c (dialog_selection_callback): Likewise.
2206
2207 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2208 Also, don't assume VALBITS / RAND_BITS is less than 5,
2209 and don't rely on undefined behavior when shifting a 1 left into
2210 the sign bit.
2211 * lisp.h (get_random): Change signature to match.
2212
2213 * lread.c (hash_string): Use size_t, not int, for hash computation.
2214 Normally we prefer signed values; but hashing is special, because
2215 it's better to use unsigned division on hash table sizes so that
2216 the remainder is nonnegative. Also, size_t is the natural width
2217 for hashing into memory. The previous code used 'int', which doesn't
2218 retain enough info to hash well into very large tables.
2219 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2220
2221 * dbusbind.c: Don't possibly lose pointer info when converting.
2222 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2223 Use XPNTR rather than XHASH, so that the high-order bits of
2224 the pointer aren't lost when converting through void *.
2225
2226 * eval.c (Fautoload): Don't double-shift a pointer.
2227
2228 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2229
2230 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * gnutls.c (DEF_GNUTLS_FN):
2233 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2234
2235 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2236
2237 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2238 marker. (Bug#8610)
2239
2240 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2241
2242 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2243 New version that can reserve upto 2GB of heap space.
2244
2245 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2248
2249 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2250
2251 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2252 `gnutls_certificate_set_x509_key_file'.
2253
2254 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2255
2256 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2257 Update dependencies.
2258
2259 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2262 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2263 Remove unused parameter `fildes'.
2264 * process.c (read_process_output, send_process): Don't pass it.
2265
2266 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2267
2268 Fix previous change: the library cache is defined in w32.c.
2269 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2270 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2271
2272 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2273
2274 Implement dynamic loading of GnuTLS on Windows.
2275
2276 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2277 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2278 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2279 Declare.
2280
2281 * gnutls.c (Qgnutls_dll): Define.
2282 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2283 (gnutls_*): Declare function pointers.
2284 (init_gnutls_functions): New function to initialize function pointers.
2285 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2286 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2287 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2288 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2289 (emacs_gnutls_write, emacs_gnutls_read)
2290 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2291 (Fgnutls_available_p): New function.
2292 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2293 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2294 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2295
2296 * image.c: Include w32.h.
2297 (Vimage_type_cache): Delete.
2298 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2299 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2300 (w32_delayed_load): Move to w32.c.
2301
2302 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2303
2304 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2305 (w32_delayed_load): Move from image.c. When loading a library, record
2306 its filename in the :loaded-from property of the library id.
2307 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2308 Initialize and staticpro them.
2309 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2310
2311 * process.c: Include lisp.h before w32.h, not after.
2312 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2313 instead of gnutls_record_check_pending.
2314
2315 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2316
2317 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2318
2319 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2320 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2321 as passed in.
2322
2323 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2324
2325 * xterm.c (x_set_frame_alpha): Do not set property on anything
2326 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2327
2328 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2331
2332 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2333
2334 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2335 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2336 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2337 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2338 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2339 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2340 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2341 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2342 (Qgnutls_bootprop_callbacks_verify): Make static.
2343
2344 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2345
2346 * callproc.c: Indentation fixup.
2347
2348 * sysdep.c (wait_for_termination_1): Make static.
2349 (wait_for_termination, interruptible_wait_for_termination):
2350 Move after wait_for_termination_1.
2351
2352 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2353
2354 * sysdep.c (interruptible_wait_for_termination): New function
2355 which is like wait_for_termination, but allows keyboard
2356 interruptions.
2357
2358 * callproc.c (Fcall_process): Add (:file "file") as an option for
2359 the STDOUT buffer.
2360 (Fcall_process_region): Ditto.
2361
2362 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2363
2364 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2365 rather than `XVECTOR (FOO)->size'.
2366
2367 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2368 inttypes.h, as a gnulib replacement is used if it not available in
2369 system headers.
2370
2371 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2372
2373 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2374 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2375 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2376
2377 * coding.c (coding_alloc_by_realloc): Error out if destination
2378 will grow beyond MOST_POSITIVE_FIXNUM.
2379 (decode_coding_emacs_mule): Abort if there isn't enough place in
2380 charbuf for the composition carryover bytes. Reserve an extra
2381 space for up to 2 characters produced in a loop.
2382 (decode_coding_iso_2022): Abort if there isn't enough place in
2383 charbuf for the composition carryover bytes.
2384
2385 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2386
2387 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2388 aborting when %lld or %lll format is passed.
2389 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2390 %llo or %llx format is passed. (Bug#8545)
2391
2392 * window.c (window_scroll_line_based): Use a marker instead of
2393 simple variables to record original value of point. (Bug#7952)
2394
2395 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2396 produced by %s or %c overflows available buffer space. (Bug#8545)
2397
2398 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2401 (SIZE_MAX): Move defn after all includes, as they might #define it.
2402
2403 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2404
2405 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2406
2407 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * keyboard.c (Qdelayed_warnings_hook): Define.
2410 (command_loop_1): Run `delayed-warnings-hook'
2411 if Vdelayed_warnings_list is non-nil.
2412 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2413 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2414
2415 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2416
2417 * doprnt.c (doprnt): Don't return value smaller than the buffer
2418 size if the message was truncated. (Bug#8545).
2419
2420 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2423 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2424
2425 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2428
2429 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2430
2431 * makefile.w32-in: Update dependencies.
2432
2433 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2434
2435 Improve `doprnt' and its usage. (Bug#8545)
2436 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2437 `format_end'. Remove support for %l as a conversion specifier.
2438 Don't use xrealloc. Improve diagnostics when the %l size modifier
2439 is used. Update the commentary.
2440
2441 * eval.c (verror): Simplify calculation of size_t.
2442
2443 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2444 messages.
2445
2446 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2447
2448 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2449 change.
2450
2451 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2454 This makes this file independent of the recent pseudovector change.
2455
2456 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2459
2460 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2461 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2462 Remove unused local.
2463 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2464
2465 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2466 GCC 4.6.0 optimizes based on type-based alias analysis.
2467 For example, if b is of type struct buffer * and v of type struct
2468 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2469 != &v->size, and therefore "v->size = 1; b->size = 2; return
2470 v->size;" must therefore return 1. This assumption is incorrect
2471 for Emacs, since it type-puns struct Lisp_Vector * with many other
2472 types. To fix this problem, this patch adds a new type struct
2473 vectorlike_header that documents the constraints on layout of vectors
2474 and pseudovectors, and helps optimizing compilers not get fooled
2475 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2476 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2477 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2478 the size member.
2479 (XSETPVECTYPE): Rewrite in terms of new macro.
2480 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2481 This is a bit clearer, and further avoids the possibility of
2482 undesirable aliasing.
2483 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2484 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2485 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2486 since Lisp_Subr is a special case (no "next" field).
2487 (ASIZE): Now uses header.size rather than size.
2488 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2489 to avoid the hassle of writing XVECTOR (foo)->header.size.
2490 (struct vectorlike_header): New type.
2491 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2492 object, to help avoid aliasing.
2493 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2494 (SUBRP): Likewise, since Lisp_Subr is a special case.
2495 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2496 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2497 (struct Lisp_Hash_Table): Combine first two members into a single
2498 struct vectorlike_header member. All uses of "size" and "next" members
2499 changed to be "header.size" and "header.next".
2500 * buffer.h (struct buffer): Likewise.
2501 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2502 * frame.h (struct frame): Likewise.
2503 * process.h (struct Lisp_Process): Likewise.
2504 * termhooks.h (struct terminal): Likewise.
2505 * window.c (struct save_window_data, struct saved_window): Likewise.
2506 * window.h (struct window): Likewise.
2507 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2508 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2509 * buffer.c (init_buffer_once): Likewise.
2510 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2511 special case.
2512 * process.c (Fformat_network_address): Use local var for size,
2513 for brevity.
2514
2515 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2516
2517 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2518 * data.c (atof): Remove decl; no longer used or needed.
2519 (digit_to_number): Move to lread.c.
2520 (Fstring_to_number): Use new string_to_number function, to be
2521 consistent with how the Lisp reader treats infinities and NaNs.
2522 Do not assume that floating-point numbers represent EMACS_INT
2523 without losing information; this is not true on most 64-bit hosts.
2524 Avoid double-rounding errors, by insisting on integers when
2525 parsing non-base-10 numbers, as the documentation specifies.
2526 * lisp.h (string_to_number): New decl, replacing ...
2527 (isfloat_string): Remove.
2528 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2529 (read1): Do not accept +. and -. as integers; this
2530 appears to have been a coding error. Similarly, do not accept
2531 strings like +-1e0 as floating point numbers. Do not report
2532 overflow for integer overflows unless the base is not 10 which
2533 means we have no simple and reliable way to continue.
2534 Break out the floating-point parsing into a new
2535 function string_to_number, so that Fstring_to_number parses
2536 floating point numbers consistently with the Lisp reader.
2537 (digit_to_number): Move here from data.c. Make it static inline.
2538 (E_CHAR, EXP_INT): Remove, replacing with ...
2539 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2540 (string_to_number): New function, replacing isfloat_string.
2541 This function checks for valid syntax and produces the resulting
2542 Lisp float number too. Rework it so that string-to-number
2543 no longer mishandles examples like "1.0e+". Use strtoumax,
2544 so that overflow for non-base-10 numbers is reported only when
2545 there's no portable and simple way to convert to floating point.
2546
2547 * textprop.c (set_text_properties_1): Rewrite for clarity,
2548 and to avoid GCC warning about integer overflow.
2549
2550 * intervals.h (struct interval): Use EMACS_INT for members
2551 where EMACS_UINT might cause problems. See
2552 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2553 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2554 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2555 All uses changed.
2556 (offset_intervals): Tell GCC not to worry about length overflow
2557 when negating a negative length.
2558
2559 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2560 (overrun_check_free): Likewise.
2561
2562 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2563 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2564 word size.
2565
2566 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2567 (gnutls_make_error): Rename local to avoid shadowing.
2568 (gnutls_emacs_global_deinit): ifdef out; not used.
2569 (Fgnutls_boot): Use const for pointer to readonly storage.
2570 Comment out unused local. Fix pointer signedness problems.
2571
2572 * lread.c (openp): Don't stuff size_t into an 'int'.
2573 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2574 about possible signed overflow.
2575
2576 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2577 (GDK_KEY_g): Don't define if already defined.
2578 (xg_prepare_tooltip): Avoid pointer signedness problem.
2579 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2580
2581 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2582 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2583
2584 * xfns.c (Fx_window_property): Simplify a bit,
2585 to make a bit faster and to avoid GCC 4.6.0 warning.
2586 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2587
2588 * fns.c (internal_equal): Don't assume size_t fits in int.
2589
2590 * alloc.c (compact_small_strings): Tighten assertion a little.
2591
2592 Replace pEd with more-general pI, and fix some printf arg casts.
2593 * lisp.h (pI): New macro, generalizing old pEd macro to other
2594 conversion specifiers. For example, use "...%"pI"d..." rather
2595 than "...%"pEd"...".
2596 (pEd): Remove. All uses replaced with similar uses of pI.
2597 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2598 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2599 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2600 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2601 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2602 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2603 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2604 64-bit hosts.
2605 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2606 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2607 * print.c (safe_debug_print, print_object): Likewise.
2608 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2609 to int.
2610 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2611 avoiding the 0 flag, which is not portable.
2612 * process.c (Fmake_network_process): Use pI to avoid cast.
2613 * region-cache.c (pp_cache): Likewise.
2614 * xdisp.c (decode_mode_spec): Likewise.
2615 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2616 behavior on 64-bit hosts with printf arg.
2617 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2618 (x_stop_queuing_selection_requests): Likewise.
2619 (x_get_window_property): Don't truncate byte count to an 'int'
2620 when tracing.
2621
2622 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2623 here, since it parses constructs like leading '-' and spaces,
2624 which are not wanted; and it overflows with large numbers.
2625 Instead, simply match F[0-9]+, which is what is wanted anyway.
2626
2627 * alloc.c: Remove unportable assumptions about struct layout.
2628 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2629 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2630 (allocate_vectorlike, make_pure_vector): Use the new macros,
2631 plus offsetof, to remove unportable assumptions about struct layout.
2632 These assumptions hold on all porting targets that I know of, but
2633 they are not guaranteed, they're easy to remove, and removing them
2634 makes further changes easier.
2635
2636 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2637 This doesn't fix a bug but makes the code clearer.
2638 (string_overrun_cookie): Now const. Use initializers that
2639 don't formally overflow signed char, to avoid warnings.
2640 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2641 can cause Emacs to crash when string overrun checking is enabled.
2642 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2643 multiple of sizeof (EMACS_INT); it need not be, if
2644 alignof(EMACS_INT) < sizeof (EMACS_INT).
2645 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2646
2647 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2648
2649 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2650
2651 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2652
2653 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2654 supposed to be handshaking. (Bug#8556)
2655 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2656
2657 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2658
2659 * lisp.h (Qdebug): List symbol.
2660 * eval.c (Qdebug): Restore global linkage.
2661 * keyboard.c (debug-on-event): New variable.
2662 (handle_user_signal): Break into debugger when debug-on-event
2663 matches the current signal symbol.
2664
2665 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2666
2667 * alloc.c (check_sblock, check_string_bytes)
2668 (check_string_free_list): Convert to standard C.
2669
2670 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2671
2672 * w32.c (emacs_gnutls_push): Fix typo.
2673
2674 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2675
2676 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2677 "cast to pointer from integer of different size".
2678
2679 Improve doprnt and its use in verror. (Bug#8545)
2680 * doprnt.c (doprnt): Document the set of format control sequences
2681 supported by the function. Use SAFE_ALLOCA instead of always
2682 using `alloca'.
2683
2684 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2685 is one byte too soon. Don't use xrealloc; instead xfree and
2686 xmalloc anew.
2687
2688 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2689
2690 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2691 callbacks stage.
2692
2693 * gnutls.c: Renamed global_initialized to
2694 gnutls_global_initialized. Added internals for the
2695 :verify-hostname-error, :verify-error, and :verify-flags
2696 parameters of `gnutls-boot' and documented those parameters in the
2697 docstring. Start callback support.
2698 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2699 unless a fatal error occured. Call gnutls_alert_send_appropriate
2700 on error. Return error code.
2701 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2702 (emacs_gnutls_read): Likewise.
2703 (Fgnutls_boot): Return handshake error code.
2704 (emacs_gnutls_handle_error): New function.
2705 (wsaerror_to_errno): Likewise.
2706
2707 * w32.h (emacs_gnutls_pull): Add prototype.
2708 (emacs_gnutls_push): Likewise.
2709
2710 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2711 (emacs_gnutls_push): Likewise.
2712
2713 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2714
2715 * process.c (wait_reading_process_output): Check if GnuTLS
2716 buffered some data internally if no FDs are set for TLS
2717 connections.
2718
2719 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2720 (LIBS): Link to USER_LIBS.
2721 ($(BLD)/gnutls.$(0)): New target.
2722
2723 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2724
2725 * xdisp.c (handle_single_display_spec): Rename the
2726 display_replaced_before_p argument into display_replaced_p, to
2727 make it consistent with the commentary. Fix typos in the
2728 commentary.
2729
2730 * textprop.c (syms_of_textprop): Remove dead code.
2731 (copy_text_properties): Delete obsolete commentary about an
2732 interface that was deleted long ago. Fix typos in the description
2733 of arguments.
2734
2735 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2736 to changes in oldXMenu/XMenu.h from 2011-04-16.
2737 <menu_help_message, prev_menu_help_message>: Constify.
2738 (IT_menu_make_room): menu->help_text is now `const char **';
2739 adjust.
2740
2741 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2742 to changes in oldXMenu/XMenu.h from 2011-04-16.
2743 (struct XMenu): Declare `help_text' `const char **'.
2744
2745 * xfaces.c <Qunspecified>: Make extern again.
2746
2747 * syntax.c: Include sys/types.h before including regex.h, as
2748 required by Posix.
2749
2750 * doc.c (get_doc_string): Improve the format passed to `error'.
2751
2752 * doprnt.c (doprnt): Improve commentary.
2753
2754 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2755
2756 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2757 them with etags.
2758
2759 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2760 changes in globals.h immediately force recompilation.
2761 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2762 $(CURDIR)/s/ms-w32.h.
2763 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2764
2765 * character.c (Fchar_direction): Function deleted.
2766 (syms_of_character): Don't defsubr it.
2767 <char-direction-table>: Deleted.
2768
2769 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2770
2771 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2772 * doprnt.c: Include limits.h.
2773 (SIZE_MAX): New macro.
2774 (doprnt): Return a size_t value. 2nd arg is now size_t.
2775 Many local variables are now size_t instead of int or unsigned.
2776 Improve overflow protection. Support `l' modifier for integer
2777 conversions. Support %l conversion. Don't assume an EMACS_INT
2778 argument for integer conversions and for %c.
2779
2780 * lisp.h (doprnt): Restore prototype.
2781
2782 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2783 $(SRC)/character.h.
2784
2785 * Makefile.in (base_obj): Add back doprnt.o.
2786
2787 * deps.mk (doprnt.o): Add back prerequisites.
2788 (callint.o): Depend on character.h.
2789
2790 * eval.c (internal_lisp_condition_case): Include the handler
2791 representation in the error message.
2792 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2793 when breaking from the loop.
2794
2795 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2796
2797 * callint.c (Fcall_interactively): When displaying error message
2798 about invalid control letter, pass the character's codepoint, not
2799 a pointer to its multibyte form. Improve display of the character
2800 in octal and display also its hex code.
2801
2802 * character.c (char_string): Use %x to display the (unsigned)
2803 codepoint of an invalid character, to avoid displaying a bogus
2804 negative value.
2805
2806 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2807 `error', not SYMBOL_NAME itself.
2808
2809 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2810 character arguments to `error'.
2811
2812 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2813 to `error' in error message about FINAL_CHAR argument. Make sure
2814 FINAL_CHAR is a character, and use %c when it is passed as
2815 argument to `error'.
2816
2817 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2818
2819 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2820
2821 * w32.c: Include <time.h>.
2822 (sys_localtime): New function.
2823
2824 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2825
2826 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2827
2828 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2829
2830 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2831
2832 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2833 zombies (Bug#8467).
2834
2835 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2836
2837 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2838 gl_state.e_property when gl_state.object is Qt.
2839
2840 * insdel.c (make_gap_larger): Remove limitation of buffer size
2841 to <= INT_MAX.
2842
2843 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2844
2845 * xdisp.c (lookup_glyphless_char_display)
2846 (produce_glyphless_glyph): Handle cons cell entry in
2847 glyphless-char-display.
2848 (Vglyphless_char_display): Document it.
2849
2850 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2851 glyphless-char-display.
2852
2853 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2854
2855 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2856
2857 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2858
2859 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2860 definition for no-X builds.
2861
2862 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Static checks with GCC 4.6.0 and non-default toolkits.
2865
2866 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2867
2868 * process.c (keyboard_bit_set): Define only if SIGIO.
2869 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2870 (send_process): Repair possible setjmp clobbering.
2871
2872 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2873
2874 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2875
2876 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2877
2878 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2879 Define only if needed.
2880
2881 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2882 by pacifying GCC about it. Maybe it's time to retire it?
2883 * xfaces.c (USG, __TIMEVAL__): Likewise.
2884
2885 * dispextern.h (struct redisplay_interface): Rename param
2886 to avoid shadowing.
2887 * termhooks.h (struct terminal): Likewise.
2888 * xterm.c (xembed_send_message): Likewise.
2889
2890 * insdel.c (make_gap_smaller): Define only if
2891 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2892
2893 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2894 it.
2895
2896 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2897 so that we aren't warned about unused symbols.
2898
2899 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2900
2901 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2902
2903 * xfns.c (x_real_positions): Mark locals as initialized.
2904
2905 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2906
2907 * xterm.c: Fix problems found by static analysis with other toolkits.
2908 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2909 (x_dispatch_event): Declare static if USE_GTK, and
2910 define if USE_GTK || USE_X_TOOLKIT.
2911 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2912 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2913 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2914 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2915
2916 * xmenu.c (menu_help_callback): Pointer type fixes.
2917 Use const pointers when pointing at readonly data. Avoid pointer
2918 signedness clashes.
2919 (FALSE): Remove unused macro.
2920 (update_frame_menubar): Remove unused decl.
2921
2922 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2923
2924 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2925 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2926 (single_menu_item): Rename local to avoid shadowing.
2927
2928 * keyboard.c (make_lispy_event): Remove unused local var.
2929
2930 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2931 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2932
2933 * bitmaps: Change bitmaps from unsigned char back to the X11
2934 compatible char. Avoid the old compiler warnings about
2935 out-of-range initializers by using, for example, '\xab' rather
2936 than 0xab.
2937
2938 * xgselect.c (xgselect_initialize): Check vs interface
2939 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2940
2941 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2942
2943 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2944 to read-only memory.
2945
2946 * fns.c (vector): Remove; this old hack is no longer needed.
2947
2948 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2949 Remove unused var.
2950 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2951
2952 * xrdb.c (x_load_resources): Omit unused local.
2953
2954 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2955 (x_window): Rename locals to avoid shadowing.
2956 (USG): Use the kludged USG macro, to pacify gcc.
2957
2958 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2959 (x_term_init): Remove local to avoid shadowing.
2960
2961 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2962
2963 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2964 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2965
2966 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2967
2968 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2969
2970 Fix regex.c, syntax.c and friends for buffers > 2GB.
2971 * syntax.h (struct gl_state_s): Declare character position members
2972 EMACS_INT.
2973
2974 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2975
2976 * textprop.c (verify_interval_modification, interval_of):
2977 Declare arguments EMACS_INT.
2978
2979 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2980 EMACS_INT.
2981
2982 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2983
2984 * indent.c (Fvertical_motion): Local variable it_start is now
2985 EMACS_INT.
2986
2987 * regex.c (re_match, re_match_2, re_match_2_internal)
2988 (bcmp_translate, regcomp, regexec, print_double_string)
2989 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2990 (re_compile_pattern, re_exec): Declare arguments and local
2991 variables `size_t' and `ssize_t' and return values `regoff_t', as
2992 appropriate.
2993 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2994 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2995 <compile_stack_type>: `size' and `avail' are now `size_t'.
2996
2997 * regex.h <regoff_t>: Use ssize_t, not int.
2998 (re_search, re_search_2, re_match, re_match_2): Arguments that
2999 specify buffer/string position and length are now ssize_t and
3000 size_t. Return type is regoff_t.
3001
3002 2011-04-16 Ben Key <bkey76@gmail.com>
3003
3004 * nsfont.m: Fixed bugs in ns_get_family and
3005 ns_descriptor_to_entity that were caused by using free to
3006 deallocate memory blocks that were allocated by xmalloc (via
3007 xstrdup). This caused Emacs to crash when compiled with
3008 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3009 --enable-checking=xmallocoverrun). xfree is now used to
3010 deallocate these memory blocks.
3011
3012 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3015
3016 emacs_write: Accept and return EMACS_INT for sizes.
3017 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3018 et seq.
3019 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3020 Accept and return EMACS_INT.
3021 (emacs_gnutls_write): Return the number of bytes written on
3022 partial writes.
3023 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3024 (emacs_read, emacs_write): Remove check for negative size, as the
3025 Emacs source code has been audited now.
3026 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3027 (emacs_read, emacs_write): Use it.
3028 * process.c (send_process): Adjust to the new signatures of
3029 emacs_write and emacs_gnutls_write. Do not attempt to store
3030 a byte offset into an 'int'; it might overflow.
3031 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3032
3033 * sound.c: Don't assume sizes fit in 'int'.
3034 (struct sound_device.period_size, alsa_period_size):
3035 Return EMACS_INT, not int.
3036 (struct sound_device.write, vox_write, alsa_write):
3037 Accept EMACS_INT, not int.
3038 (wav_play, au_play): Use EMACS_INT to store sizes and to
3039 record read return values.
3040
3041 2011-04-15 Ben Key <bkey76@gmail.com>
3042
3043 * keyboard.c (Qundefined): Don't declare static since it is used
3044 in nsfns.m.
3045 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3046 static since they are used in nsfont.m.
3047
3048 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3049
3050 * process.c (Qprocessp): Don't declare static.
3051 * lisp.h (Qprocessp): Declare again.
3052
3053 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3054
3055 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3056
3057 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Improve C-level modularity by making more things 'static'.
3060
3061 Don't publish debugger-only interfaces to other modules.
3062 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3063 (verify_bytepos, count_markers): Move decls to the only modules
3064 that need them.
3065 * region-cache.h (pp_cache): Likewise.
3066 * window.h (check_all_windows): Likewise.
3067 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3068
3069 * sysdep.c (croak): Now static, if
3070 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3071 * syssignal.h (croak): Declare only if not static.
3072
3073 * alloc.c (refill_memory_reserve): Now static if
3074 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3075 * lisp.h (refill_memory_reserve): Declare only if not static.
3076
3077 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3078 Define only if USE_LUCID.
3079
3080 * xrdb.c (x_customization_string, x_rm_string): Now static.
3081
3082 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3083 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3084
3085 * xdisp.c (draw_row_with_mouse_face): Now static.
3086 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3087
3088 * window.h (check_all_windows): Mark externally visible.
3089
3090 * window.c (window_deletion_count): Now static.
3091
3092 * undo.c: Make symbols static if they're not exported.
3093 (last_undo_buffer, last_boundary_position, pending_boundary):
3094 Now static.
3095
3096 * textprop.c (interval_insert_behind_hooks): Now static.
3097 (interval_insert_in_front_hooks): Likewise.
3098
3099 * term.c: Make symbols static if they're not exported.
3100 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3101 (max_frame_lines, tty_set_terminal_modes):
3102 (tty_reset_terminal_modes, tty_turn_off_highlight):
3103 (get_tty_terminal): Now static.
3104 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3105 * termhooks.h (term_mouse_moveto): Do not declare if
3106 HAVE_WINDOW_SYSTEM.
3107 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3108 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3109
3110 * sysdep.c: Make symbols static if they're not exported.
3111 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3112 Now static.
3113 (sigprocmask_set, full_mask): Remove; unused.
3114 (wait_debugging): Mark as visible.
3115 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3116 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3117
3118 * syntax.c (syntax_temp): Define only if !__GNUC__.
3119
3120 * sound.c (current_sound_device, current_sound): Now static.
3121
3122 * search.c (searchbufs, searchbuf_head): Now static.
3123
3124 * scroll.c (scroll_cost): Remove; unused.
3125 * dispextern.h (scroll_cost): Remove decl.
3126
3127 * region-cache.h (pp_cache): Mark as externally visible.
3128
3129 * process.c: Make symbols static if they're not exported.
3130 (process_tick, update_tick, create_process, chan_process):
3131 (Vprocess_alist, proc_buffered_char, datagram_access):
3132 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3133 (deactivate_process): Mark defn as static, as well as decl.
3134 * lisp.h (create_process): Remove decl.
3135 * process.h (chan_process, Vprocess_alist): Remove decls.
3136
3137 * print.c: Make symbols static if they're not exported.
3138 (print_depth, new_backquote_output, being_printed, print_buffer):
3139 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3140 (print_interval, print_number_index, initial_stderr_stream):
3141 Now static.
3142 * lisp.h (Fprinc): Remove decl.
3143 (debug_output_compilation_hack): Mark as externally visible.
3144
3145 * sysdep.c (croak): Move decl from here to syssignal.h.
3146 * syssignal.h (croak): Put it here, so the API can be checked when
3147 'croak' is called from dissociate_if_controlling_tty.
3148
3149 * minibuf.c: Make symbols static if they're not exported.
3150 (minibuf_save_list, choose_minibuf_frame): Now static.
3151 * lisp.h (choose_minibuf_frame): Remove decl.
3152
3153 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3154
3155 * lread.c: Make symbols static if they're not exported.
3156 (read_objects, initial_obarray, oblookup_last_bucket_number):
3157 Now static.
3158 (make_symbol): Remove; unused.
3159 * lisp.h (initial_obarray, make_symbol): Remove decls.
3160
3161 * keyboard.c: Make symbols static if they're not exported.
3162 (single_kboard, recent_keys_index, total_keys, recent_keys):
3163 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3164 (this_single_command_key_start, echoing, last_auto_save):
3165 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3166 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3167 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3168 (Vlispy_mouse_stem, double_click_count):
3169 Now static.
3170 (force_auto_save_soon): Define only if SIGDANGER.
3171 (ignore_mouse_drag_p): Now static if
3172 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3173 (print_help): Remove; unused.
3174 (stop_character, last_timer_event): Mark as externally visible.
3175 * keyboard.h (ignore_mouse_drag_p): Declare only if
3176 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3177 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3178 * lisp.h (echoing): Remove decl.
3179 (force_auto_save_soon): Declare only if SIGDANGER.
3180 * xdisp.c (redisplay_window): Simplify code, to make it more
3181 obvious that ignore_mouse_drag_p is not accessed if !defined
3182 USE_GTK && !defined HAVE_NS.
3183
3184 * intervals.c: Make symbols static if they're not exported.
3185 (merge_properties_sticky, merge_interval_right, delete_interval):
3186 Now static.
3187 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3188
3189 * insdel.c: Make symbols static if they're not exported.
3190 However, leave prepare_to_modify_buffer alone. It's never
3191 called from outside this function, but that appears to be a bug.
3192 (combine_after_change_list, combine_after_change_buffer):
3193 (adjust_after_replace, signal_before_change): Now static.
3194 (adjust_after_replace_noundo): Remove; unused.
3195 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3196 (signal_before_change): Remove decls.
3197
3198 * indent.c (val_compute_motion, val_vmotion): Now static.
3199
3200 * image.c: Make symbols static if they're not exported.
3201 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3202 if USE_GTK.
3203 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3204 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3205
3206 * fringe.c (standard_bitmaps): Now static.
3207 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3208
3209 * frame.c: Make symbols static if they're not exported.
3210 (x_report_frame_params, make_terminal_frame): Now static.
3211 (get_frame_param): Now static, unless HAVE_NS.
3212 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3213 (x_get_resource_string): Remove; not used.
3214 * frame.h (make_terminal_frame, x_report_frame_params):
3215 (x_get_resource_string); Remove decls.
3216 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3217 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3218
3219 * font.c, fontset.c: Make symbols static if they're not exported.
3220 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3221 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3222 * font.c (font_close_object): Now static.
3223 * font.h (font_close_object): Remove.
3224 * fontset.c (FONTSET_OBJLIST): Remove.
3225 (free_realized_fontset) #if-0 the body, which does nothing.
3226 (face_suitable_for_char_p): #if-0, as it's never called.
3227 * fontset.h (face_suitable_for_char_p): Remove decl.
3228 * xfaces.c (face_at_string_position):
3229 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3230 since 0 is always ASCII.
3231
3232 * fns.c (weak_hash_tables): Now static.
3233
3234 * fileio.c: Make symbols static if they're not exported.
3235 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3236 (Vwrite_region_annotation_buffers): Now static.
3237
3238 * eval.c: Make symbols static if they're not exported.
3239 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3240 * lisp.h (backtrace_list): Remove decl.
3241
3242 * emacs.c: Make symbols static if they're not exported.
3243 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3244 (fatal_error_code, fatal_error_signal_hook, standard_args):
3245 Now static.
3246 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3247 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3248 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3249 * lisp.h (fatal_error_signal_hook): Remove decl.
3250 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3251
3252 * editfns.c: Move a (normally-unused) function to its only use.
3253 * editfns.c, lisp.h (get_operating_system_release): Remove.
3254 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3255 worth the hassle of breaking this out.
3256
3257 * xterm.c: Make symbols static if they're not exported.
3258 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3259 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3260 (x_destroy_window, x_delete_display):
3261 Now static.
3262 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3263 (x_mouse_leave): Remove; unused.
3264 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3265 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3266 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3267 Remove decls.
3268 (x_mouse_leave): Declare only if WINDOWSNT.
3269 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3270 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3271 USE_X_TOOLKIT.
3272
3273 * ftxfont.c: Make symbols static if they're not exported.
3274 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3275 HAVE_FREETYPE.
3276 * font.h (ftxfont_driver): Likewise.
3277
3278 * xfns.c: Make symbols static if they're not exported.
3279 (x_last_font_name, x_display_info_for_name):
3280 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3281 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3282 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3283 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3284 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3285 (last_show_tip_args): Now static.
3286 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3287 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3288 (x_screen_planes): Remove; unused.
3289 * dispextern.h (x_screen_planes): Remove decl.
3290
3291 * dispnew.c: Make symbols static if they're not exported.
3292 * dispextern.h (redraw_garbaged_frames, scrolling):
3293 (increment_row_positions): Remove.
3294 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3295 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3296 Now static.
3297 (redraw_garbaged_frames): Remove; unused.
3298
3299 * xfaces.c: Make symbols static if they're not exported.
3300 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3301 Remove decls.
3302 * xterm.h (defined_color): Remove decls.
3303 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3304 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3305 (menu_face_changed_default, defined_color, free_realized_face):
3306 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3307 (ascii_face_of_lisp_face): Remove; unused.
3308
3309 * xdisp.c: Make symbols static if they're not exported.
3310 * dispextern.h (scratch_glyph_row, window_box_edges):
3311 (glyph_to_pixel_coords, set_cursor_from_row):
3312 (get_next_display_element, set_iterator_to_next):
3313 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3314 (show_mouse_face): Remove decls
3315 * frame.h (message_buf_print): Likewise.
3316 * lisp.h (pop_message, set_message, check_point_in_composition):
3317 Likewise.
3318 * xterm.h (set_vertical_scroll_bar): Likewise.
3319 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3320 (message_buf_print, scratch_glyph_row, displayed_buffer):
3321 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3322 (get_next_display_element, show_mouse_face, window_box_edges):
3323 (frame_to_window_pixel_xy, check_point_in_composition):
3324 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3325 (glyph_to_pixel_coords): Remove; unused.
3326
3327 * dired.c (file_name_completion): Now static.
3328
3329 * dbusbind.c (xd_in_read_queued_messages): Now static.
3330
3331 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3332 * data.c (circular_list_error): Remove.
3333
3334 * commands.h (last_point_position, last_point_position_buffer):
3335 (last_point_position_window): Remove decls.
3336 * keyboard.c: Make these variables static.
3337
3338 * coding.h (coding, code_convert_region, encode_coding_gap):
3339 Remove decls.
3340 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3341 (iso_code_class, detect_coding, code_convert_region): Now static.
3342 (encode_coding_gap): Remove; unused.
3343
3344 * chartab.c (chartab_chars, chartab_bits): Now static.
3345
3346 * charset.h (charset_iso_8859_1): Remove decl.
3347 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3348 Now static.
3349
3350 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3351 * ccl.c (Vccl_program_table): Now static.
3352 (check_ccl_update): Remove; unused.
3353
3354 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3355 * category.h: ... from here.
3356 * category.c (check_category_table, set_category_set): Now static.
3357
3358 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3359 * lisp.h: Remove these decls.
3360
3361 * buffer.c (buffer_count): Remove unused var.
3362
3363 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3364 so that it's not optimized away.
3365 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3366 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3367 exported only to the debugger.
3368
3369 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3370 * atimer.h (run_all_atimers): Remove; not exported.
3371
3372 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3373 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3374 was inaccessible from Lisp.
3375 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3376 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3377
3378 alloc.c: Import and export fewer symbols, and remove unused items.
3379 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3380 is defined.
3381 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3382 it's not optimized away by whole-program optimization.
3383 (message_enable_multibyte, free_misc): Remove.
3384 (catchlist, handlerlist, mark_backtrace):
3385 Declare only if BYTE_MARK_STACK.
3386 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3387 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3388 (message_enable_multibyte): Remove decl.
3389 (free_misc, interval_free_list, float_block, float_block_index):
3390 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3391 (cons_free_list, last_marked_index):
3392 Now static.
3393 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3394 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3395 (mark_backtrace): Define only if BYTE_MARK_STACK.
3396 * xdisp.c (message_enable_multibyte): Now static.
3397
3398 Declare Lisp_Object Q* variables to be 'static' if not exported.
3399 This makes it easier for human readers (and static analyzers)
3400 to see whether these variables are used from other modules.
3401 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3402 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3403 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3404 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3405 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3406 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3407 * xmenu.c, xselect.c:
3408 Declare Q* vars static if they are not used in other modules.
3409 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3410 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3411 Remove decls of unexported vars.
3412 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3413
3414 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3415
3416 Make Emacs functions such as Fatom 'static' by default.
3417 This makes it easier for human readers (and static analyzers)
3418 to see whether these functions can be called from other modules.
3419 DEFUN now defines a static function. To make the function external
3420 so that it can be used in other C modules, use the new macro DEFUE.
3421 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3422 (Finit_image_library):
3423 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3424 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3425 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3426 Remove decls, since these functions are now static.
3427 (Funintern, Fget_internal_run_time): New decls, since these functions
3428 were already external.
3429
3430 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3431 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3432 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3433 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3434 * keyboard.c, keymap.c, lread.c:
3435 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3436 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3437 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3438 Mark functions with DEFUE instead of DEFUN,
3439 if they are used in other modules.
3440 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3441 decls for now-static functions.
3442 * buffer.h (Fdelete_overlay): Remove decl.
3443 * callproc.c (Fgetenv_internal): Mark as internal.
3444 * composite.c (Fremove_list_of_text_properties): Remove decl.
3445 (Fcomposition_get_gstring): New forward static decl.
3446 * composite.h (Fcomposite_get_gstring): Remove decl.
3447 * dired.c (Ffile_attributes): New forward static decl.
3448 * doc.c (Fdocumntation_property): New forward static decl.
3449 * eval.c (Ffetch_bytecode): New forward static decl.
3450 (Funintern): Remove extern decl; now in .h file where it belongs.
3451 * fileio.c (Fmake_symbolic_link): New forward static decl.
3452 * image.c (Finit_image_library): New forward static decl.
3453 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3454 * intervals.h (Fprevious_property_change):
3455 (Fremove_list_of_text_properties): Remove decls.
3456 * keyboard.c (Fthis_command_keys): Remove decl.
3457 (Fcommand_execute): New forward static decl.
3458 * keymap.c (Flookup_key): New forward static decl.
3459 (Fcopy_keymap): Now static.
3460 * keymap.h (Flookup_key): Remove decl.
3461 * process.c (Fget_process): New forward static decl.
3462 (Fprocess_datagram_address): Mark as internal.
3463 * syntax.c (Fsyntax_table_p): New forward static decl.
3464 (skip_chars): Remove duplicate decl.
3465 * textprop.c (Fprevious_property_change): New forward static decl.
3466 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3467 Now internal.
3468 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3469 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3470
3471 * editfns.c (Fformat): Remove unreachable code.
3472
3473 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3474
3475 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3476 change. (Bug#8496)
3477
3478 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3479
3480 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3481 when at ZV. (Bug#8487)
3482
3483 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3484
3485 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3486 (Bug#8437)
3487 * keyboard.c (parse_tool_bar_item): Likewise.
3488 * sound.c (sound_cleanup, alsa_close): Likewise.
3489 * termcap.c (tgetent): Likewise.
3490 * xfns.c (x_default_font_parameter): Likewise.
3491 * xsettings.c (read_and_apply_settings): Likewise.
3492
3493 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3494 (overrun_check_free): Protoize.
3495
3496 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3499 since callers should never pass a negative size.
3500 Change the signature to match that of plain 'read' and 'write'; see
3501 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3502 * lisp.h: Update prototypes of emacs_write and emacs_read.
3503
3504 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3505
3506 * xdisp.c (redisplay_window): Don't try to determine the character
3507 position of the scroll margin if the window start point w->startp
3508 is outside the buffer's accessible region. (Bug#8468)
3509
3510 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3511
3512 Fix write-region and its subroutines for buffers > 2GB.
3513 * fileio.c (a_write, e_write): Modify declaration of arguments and
3514 local variables to support buffers larger than 2GB.
3515 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3516
3517 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3518 argument, local variables, and return value.
3519
3520 * lisp.h: Update prototypes of emacs_write and emacs_read.
3521
3522 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3523
3524 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3527
3528 Fix more problems found by GCC 4.6.0's static checks.
3529
3530 * xdisp.c (vmessage): Use a better test for character truncation.
3531
3532 * charset.c (load_charset_map): <, not <=, for optimization,
3533 and to avoid potential problems with integer overflow.
3534 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3535 * casetab.c (set_identity, shuffle): Likewise.
3536 * editfns.c (Fformat): Likewise.
3537 * syntax.c (skip_chars): Likewise.
3538
3539 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3540 This also lets GCC 4.6.0 generate slightly better loop code.
3541
3542 * callint.c (Fcall_interactively): <, not <=, for optimization.
3543 (Fcall_interactively): Count the number of arguments produced,
3544 not the number of arguments given. This is simpler and lets GCC
3545 4.6.0 generate slightly better code.
3546
3547 * ftfont.c: Distingish more carefully between FcChar8 and char.
3548 The previous code passed unsigned char * to a functions like
3549 strlen and xstrcasecmp that expect char *, which does not
3550 conform to the C standard.
3551 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3552 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3553 char * when the C standard requires it.
3554
3555 * keyboard.c (read_char): Remove unused var.
3556
3557 * eval.c: Port to Windows vsnprintf (Bug#8435).
3558 Include <limits.h>.
3559 (SIZE_MAX): Define if the headers do not.
3560 (verror): Do not give up if vsnprintf returns a negative count.
3561 Instead, grow the buffer. This ports to Windows vsnprintf, which
3562 does not conform to C99. Problem reported by Eli Zaretskii.
3563 Also, simplify the allocation scheme, by avoiding the need for
3564 calling realloc, and removing the ALLOCATED variable.
3565
3566 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3567
3568 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3569 But keep the doprint source code for now, as we might revamp it
3570 and use it again (Bug#8435).
3571 * lisp.h (doprnt): Remove.
3572 * Makefile.in (base_obj): Remove doprnt.o.
3573 * deps.mk (doprnt.o): Remove.
3574
3575 error: Print 32- and 64-bit integers portably (Bug#8435).
3576 Without this change, on typical 64-bit hosts error ("...%d...", N)
3577 was used to print both 32- and 64-bit integers N, which relied on
3578 undefined behavior.
3579 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3580 New macro.
3581 * lisp.h (error, verror): Mark as printf-like functions.
3582 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3583 Report overflow in size calculations when allocating printf buffer.
3584 Do not truncate output string at its first null byte.
3585 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3586 Truncate the output at a character boundary, since vsnprintf does not
3587 do that.
3588 * charset.c (check_iso_charset_parameter): Convert internal
3589 character to string before calling 'error', since %c now has the
3590 printf meaning.
3591 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3592 overflow when computing char to be passed to 'error'. Do not
3593 pass Lisp_Object to 'error'; pass the integer instead.
3594 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3595 formatted with plain %d.
3596
3597 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3598
3599 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3600
3601 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3602
3603 * xterm.c (x_catch_errors): Remove duplicate declaration.
3604
3605 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3606
3607 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3608
3609 2011-04-10 Jim Meyering <meyering@redhat.com>
3610
3611 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3612 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3613 return ssize_t not "int", and use size_t as the buffer length.
3614 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3615 * gnutls.h: Update declarations.
3616 * process.c (read_process_output): Use ssize_t, to match.
3617 (send_process): Likewise.
3618
3619 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3620
3621 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3622
3623 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3624
3625 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3626 Use unsigned char, to match FcChar8 type definition.
3627
3628 * xterm.c (handle_one_xevent):
3629 * xmenu.c (create_and_show_popup_menu):
3630 * xselect.c (x_decline_selection_request)
3631 (x_reply_selection_request): Avoid type-punned deref of X events.
3632
3633 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3634
3635 Fix some uses of `int' instead of EMACS_INT.
3636 * search.c (string_match_1, fast_string_match)
3637 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3638 (scan_buffer, find_next_newline_no_quit)
3639 (find_before_next_newline, search_command, Freplace_match)
3640 (Fmatch_data): Make some `int' variables be EMACS_INT.
3641
3642 * xdisp.c (display_count_lines): 3rd argument and return value now
3643 EMACS_INT. All callers changed.
3644 (pint2hrstr): Last argument is now EMACS_INT.
3645
3646 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3647 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3648 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3649 (decode_coding_utf_16, decode_coding_emacs_mule)
3650 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3651 (decode_coding_ccl, decode_coding_charset)
3652 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3653 (decode_coding_iso_2022, decode_coding_emacs_mule)
3654 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3655 <char_offset, last_offset>: Declare EMACS_INT.
3656 (encode_coding_utf_8, encode_coding_utf_16)
3657 (encode_coding_emacs_mule, encode_invocation_designation)
3658 (encode_designation_at_bol, encode_coding_iso_2022)
3659 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3660 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3661 Declare EMACS_INT.
3662 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3663 (encode_invocation_designation): Last argument P_NCHARS is now
3664 EMACS_INT.
3665 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3666 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3667
3668 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3669 All users changed.
3670
3671 * ccl.c (Fccl_execute_on_string): Declare some variables
3672 EMACS_INT.
3673
3674 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3675
3676 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3677
3678 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3679
3680 * process.c (Fformat_network_address): Doc fix.
3681
3682 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3683
3684 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3685
3686 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3687
3688 * keyboard.c (read_char): Call Lisp function help-form-show,
3689 instead of using internal_with_output_to_temp_buffer.
3690 (Qhelp_form_show): New var.
3691 (syms_of_keyboard): Use DEFSYM macro.
3692
3693 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3694
3695 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3696
3697 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3698
3699 * process.c (Flist_processes): Remove to Lisp.
3700 (list_processes_1): Delete.
3701
3702 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3703
3704 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3705
3706 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3707
3708 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 Fix more problems found by GCC 4.6.0's static checks.
3711
3712 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3713
3714 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3715
3716 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3717
3718 * xdisp.c (vmessage): Mark as a printf-like function.
3719
3720 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3721
3722 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3723
3724 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3725 printf-like functions.
3726 (tiff_load): Add casts to remove these marks before passing them
3727 to system-supplied API.
3728
3729 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3730
3731 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3732 This avoids several warnings with gcc -Wstrict-overflow.
3733 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3734 directly, rather than having caller test rule sign. This avoids
3735 some unnecessary tests.
3736 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3737 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3738 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3739
3740 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3741 (xfont_open): Avoid unnecessary tests.
3742
3743 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3744
3745 * composite.h, composite.c (composition_gstring_put_cache):
3746 Use EMACS_INT, not int, for length.
3747
3748 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3749 breaking out part of COMPOSITION_DECODE_RULE.
3750 (COMPOSITION_DECODE_RULE): Use it.
3751 * composite.c (get_composition_id): Remove unused local vars,
3752 by using the new macro.
3753
3754 * textprop.c (set_text_properties_1): Change while to do-while,
3755 since the condition is always true at first.
3756
3757 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3758 (interval_deletion_adjustment): Return unsigned value.
3759 All uses changed.
3760
3761 * process.c (list_processes_1, create_pty, read_process_output):
3762 (exec_sentinel): Remove vars that were set but not used.
3763 (create_pty): Remove unnecessary "volatile"s.
3764 (Fnetwork_interface_info): Avoid possibility of int overflow.
3765 (read_process_output): Do adaptive read buffering even if carryover.
3766 (read_process_output): Simplify nbytes computation if buffered.
3767
3768 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3769
3770 * syntax.c (scan_words): Remove var that was set but not used.
3771 (update_syntax_table): Use unsigned instead of int.
3772
3773 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3774 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3775 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3776
3777 * print.c (print_error_message): Avoid int overflow.
3778
3779 * font.c (font_list_entities): Redo for clarity,
3780 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3781
3782 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3783 (font_score): Avoid potential overflow in diff calculation.
3784
3785 * fns.c (substring_both): Remove var that is set but not used.
3786 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3787
3788 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3789
3790 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3791 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3792 can always succeed if overflow has undefined behavior.
3793
3794 * search.c (boyer_moore, wordify): Remove vars set but not used.
3795 (wordify): Omit three unnecessary tests.
3796
3797 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3798 All callers changed. This avoids the need for an unused var.
3799
3800 * casefiddle.c (casify_region): Remove var that is set but not used.
3801
3802 * dired.c (file_name_completion): Remove var that is set but not used.
3803
3804 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3805
3806 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3807 (Finsert_file_contents): Remove unnecessary code checking fd.
3808
3809 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3810 Check for integer overflow on size calculations.
3811
3812 * buffer.c (Fprevious_overlay_change): Remove var that is set
3813 but not used.
3814
3815 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3816 Remove vars that are set but not used.
3817 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3818 (timer_check_2): Mark vars as initialized.
3819
3820 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3821
3822 * image.c (lookup_image): Remove var that is set but not used.
3823 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3824
3825 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3826 that are set but not used.
3827
3828 * xfns.c (make_invisible_cursor): Don't return garbage
3829 if XCreateBitmapFromData fails (Bug#8410).
3830
3831 * xselect.c (x_get_local_selection, x_handle_property_notify):
3832 Remove vars that are set but not used.
3833
3834 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3835 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3836
3837 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3838 Remove var that is set but not used.
3839 (scroll_bar_windows_size): Now size_t, not int.
3840 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3841 Check for overflow.
3842
3843 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3844 (map_tty_color) [!defined MSDOS]: Likewise.
3845
3846 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3847
3848 * coding.c: Remove vars that are set but not used.
3849 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3850 All callers changed.
3851 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3852 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3853 (decode_coding_charset): Remove vars that are set but not used.
3854
3855 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3856 that is set but not used.
3857
3858 * print.c (print_object): Remove var that is set but not used.
3859
3860 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3861 The gnulib version avoids calling malloc in the usual case,
3862 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3863 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3864 * filelock.c (current_lock_owner): Likewise.
3865 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3866 * sysdep.c: Include allocator.h, careadlinkat.h.
3867 (emacs_no_realloc_allocator): New static constant.
3868 (emacs_readlink): New function.
3869 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3870 ../lib/careadlinkat.h.
3871
3872 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3873
3874 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3875 first non-nil return value).
3876
3877 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3878
3879 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3880 if not defined (Bug#8403).
3881
3882 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3883
3884 * xdisp.c (display_count_lines): Remove parameter `start',
3885 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3886 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3887 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3888 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3889 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3890 and thereabouts. All callers changed.
3891 (get_per_char_metric): Remove parameter `f', unused since
3892 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3893
3894 2011-04-02 Jim Meyering <meyering@redhat.com>
3895
3896 do not dereference NULL upon failed strdup
3897 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3898 (ns_get_family): Likewise.
3899
3900 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3901
3902 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3903
3904 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3905
3906 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3907 later (Bug#8403).
3908
3909 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3910
3911 Add lexical binding.
3912
3913 * window.c (Ftemp_output_buffer_show): New fun.
3914 (Fsave_window_excursion):
3915 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3916
3917 * lread.c (lisp_file_lexically_bound_p): New function.
3918 (Fload): Bind Qlexical_binding.
3919 (readevalloop): Remove `evalfun' arg.
3920 Bind Qinternal_interpreter_environment.
3921 (Feval_buffer): Bind Qlexical_binding.
3922 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3923 Mark as dynamic.
3924 (syms_of_lread): Declare `lexical-binding'.
3925
3926 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3927
3928 * keyboard.c (eval_dyn): New fun.
3929 (menu_item_eval_property): Use it.
3930
3931 * image.c (parse_image_spec): Use Ffunctionp.
3932
3933 * fns.c (concat, mapcar1): Accept byte-code-functions.
3934
3935 * eval.c (Fsetq): Handle lexical vars.
3936 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3937 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3938 (FletX, Flet): Obey lexical binding.
3939 (Fcommandp): Handle closures.
3940 (Feval): New `lexical' arg.
3941 (eval_sub): New function extracted from Feval. Use it almost
3942 everywhere where Feval was used. Look up vars in lexical env.
3943 Handle closures.
3944 (Ffunctionp): Move from subr.el.
3945 (Ffuncall): Handle closures.
3946 (apply_lambda): Remove `eval_flags'.
3947 (funcall_lambda): Handle closures and new byte-code-functions.
3948 (Fspecial_variable_p): New function.
3949 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3950 but without exporting it to Lisp.
3951
3952 * doc.c (Fdocumentation, store_function_docstring):
3953 * data.c (Finteractive_form): Handle closures.
3954
3955 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3956 interactive spec.
3957
3958 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3959 New byte-codes.
3960 (exec_byte_code): New function extracted from Fbyte_code to handle new
3961 calling convention for byte-code-functions. Add new byte-codes.
3962
3963 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3964
3965 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3966
3967 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * xdisp.c (redisplay_internal): Fix prototype.
3970
3971 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3972
3973 * xdisp.c (SCROLL_LIMIT): New macro.
3974 (try_scrolling): Use it when setting scroll_limit.
3975 Limit scrolling to 100 screen lines.
3976 (redisplay_window): Even when falling back on "recentering",
3977 position point in the window according to scroll-conservatively,
3978 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3979
3980 (try_scrolling): When point is above the window, allow searching
3981 as far as scroll_max, or one screenful, to compute vertical
3982 distance from PT to the scroll margin position. This prevents
3983 try_scrolling from unnecessarily failing when
3984 scroll-conservatively is set to a value slightly larger than the
3985 window height. Clean up the case of PT below the margin at bottom
3986 of window: scroll_max can no longer be INT_MAX. When aggressive
3987 scrolling is in use, don't let point enter the opposite scroll
3988 margin as result of the scroll.
3989 (syms_of_xdisp) <scroll-conservatively>: Document the
3990 threshold of 100 lines for never-recentering scrolling.
3991
3992 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3993
3994 * dispextern.h (move_it_by_lines):
3995 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3996 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3997 (message_log_check_duplicate): Remove parameters `prev_bol' and
3998 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3999 (redisplay_internal): Remove parameter `preserve_echo_area',
4000 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4001
4002 * indent.c (Fvertical_motion):
4003 * window.c (window_scroll_pixel_based, Frecenter):
4004 Don't pass `need_y_p' to `move_it_by_lines'.
4005
4006 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4007
4008 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4009 steal a few bits to be more compact.
4010 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4011 Remove unneeded casts.
4012
4013 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4014
4015 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4016
4017 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4018 binding" message (bug#7967).
4019
4020 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 Fix more problems found by GCC 4.6.0's static checks.
4023
4024 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4025 Remove unused local var.
4026
4027 * editfns.c (Fmessage_box): Remove unused local var.
4028
4029 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4030 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4031 Omit unused local vars.
4032 * window.c (shrink_windows): Omit unused local var.
4033 * menu.c (digest_single_submenu): Omit unused local var.
4034 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4035 Omit unused local var.
4036
4037 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4038 Don't assume string length fits in int.
4039 (keyremap_step, read_key_sequence): Use size_t for sizes.
4040 (read_key_sequence): Don't check last_real_key_start redundantly.
4041
4042 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4043 instead of alloca (Bug#8344).
4044
4045 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4046 (Fbacktrace_frame): Don't assume nframes fits in int.
4047
4048 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4049
4050 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4051 concerns.
4052
4053 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4054
4055 * cm.c (calccost): Turn while-do into do-while, for clarity.
4056
4057 * keyboard.c (syms_of_keyboard): Use the same style as later
4058 in this function when indexing through an array. This also
4059 works around GCC bug 48267.
4060
4061 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4062
4063 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4064
4065 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4066 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4067
4068 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4069 This avoids undefined behavior on integer overflow, and is a bit
4070 more convenient anyway since it is compared to a size_t variable.
4071
4072 Variadic C functions now count arguments with size_t, not int.
4073 This avoids an unnecessary limitation on 64-bit machines, which
4074 caused (substring ...) to crash on large vectors (Bug#8344).
4075 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4077 All variadic functions and their callers changed accordingly.
4078 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4079 * data.c (arith_driver, float_arith_driver): Likewise.
4080 * editfns.c (general_insert_function): Likewise.
4081 * eval.c (struct backtrace.nargs, interactive_p)
4082 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4083 (funcall_lambda, mark_backtrace): Likewise.
4084 * fns.c (concat): Likewise.
4085 * frame.c (x_set_frame_parameters): Likewise.
4086 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4087 0 if not found, not -1. All callers changed.
4088
4089 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4090 (stack_copy_size): Now size_t, not int.
4091 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4092
4093 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4094
4095 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4096 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4097 All callers changed.
4098
4099 * lisp.h (multibyte_char_to_unibyte):
4100 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4101 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4102 * character.h (CHAR_TO_BYTE8):
4103 * cmds.c (internal_self_insert):
4104 * editfns.c (general_insert_function):
4105 * keymap.c (push_key_description):
4106 * search.c (Freplace_match):
4107 * xdisp.c (message_dolog, set_message_1): All callers changed.
4108
4109 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * keyboard.c (safe_run_hook_funcall): New function.
4112 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4113 don't set the hook to nil, but remove the offending function instead.
4114 (Qcommand_hook_internal): Remove, unused.
4115 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4116 Vcommand_hook_internal.
4117
4118 * eval.c (enum run_hooks_condition): Remove.
4119 (funcall_nil, funcall_not): New functions.
4120 (run_hook_with_args): Call each function through a `funcall' argument.
4121 Remove `cond' argument, now redundant.
4122 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4123 (Frun_hook_with_args_until_failure): Adjust accordingly.
4124 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4125
4126 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * dispextern.h (string_buffer_position): Remove declaration.
4129
4130 * print.c (strout): Remove parameter `multibyte', unused since
4131 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4132
4133 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4134 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4135 All callers changed.
4136
4137 * w32.c (_wsa_errlist): Use braces for struct initializers.
4138
4139 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4140 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4141 All callers changed.
4142 (string_buffer_position): Likewise. Also, make static (it's never
4143 used outside xdisp.c).
4144 (cursor_row_p): Remove parameter `w', unused since
4145 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4146 (decode_mode_spec): Remove parameter `precision', introduced during
4147 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4148 All callers changed.
4149
4150 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4151
4152 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4153
4154 2011-03-27 Anders Lindgren <andlind@gmail.com>
4155
4156 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4157 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4158 (ns_update_auto_hide_menu_bar): New functions.
4159 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4160 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4161 ns_constrain_all_frames.
4162 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4163 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4164
4165 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4166
4167 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4168
4169 2011-03-27 Glenn Morris <rgm@gnu.org>
4170
4171 * syssignal.h: Replace RETSIGTYPE with void.
4172 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4173 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4174 Replace SIGTYPE with void everywhere.
4175 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4176 * s/template.h (SIGTYPE): Remove commented out definition.
4177
4178 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4179
4180 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4181 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4182
4183 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * w32.c (read_unc_volume): Use parameter `henum', instead of
4186 global variable `wget_enum_handle'.
4187
4188 * keymap.c (describe_vector): Remove parameters `indices' and
4189 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4190 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4191
4192 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4193
4194 * keyboard.c (timer_check): Remove parameter `do_it_now',
4195 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4196 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4197 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4198
4199 * keyboard.c (read_char):
4200 * w32menu.c (w32_menu_display_help):
4201 * xmenu.c (show_help_event, menu_help_callback):
4202 Adjust calls to `show_help_echo'.
4203
4204 * gtkutil.c (xg_maybe_add_timer):
4205 * keyboard.c (readable_events):
4206 * process.c (wait_reading_process_output):
4207 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4208
4209 * insdel.c (adjust_markers_gap_motion):
4210 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4211 (gap_left, gap_right): Don't call it.
4212
4213 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4214
4215 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4216 incurred during fontification.
4217
4218 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4221 (DEFVAR_PER_BUFFER): Don't pass it.
4222
4223 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4224 (scrolling_window): Don't pass it.
4225
4226 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4227
4228 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4229
4230 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4231 and `suffix'.
4232 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4233 of variables specific to SELinux and computation of `encoded_absname'.
4234
4235 * image.c (XPutPixel): Remove unused variable `height'.
4236
4237 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4238
4239 * unexw32.c (get_section_info): Remove unused variable `section'.
4240
4241 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4242 (system_process_attributes): Remove unused variable `sess'.
4243 (sys_read): Remove unused variable `err'.
4244
4245 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4246 (w32_wnd_proc): Remove unused variable `isdead'.
4247 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4248 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4249 (x_create_tip_frame): Remove unused variable `tem'.
4250
4251 * w32inevt.c (w32_console_read_socket):
4252 Remove unused variable `no_events'.
4253
4254 * w32term.c (x_draw_composite_glyph_string_foreground):
4255 Remove unused variable `width'.
4256
4257 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4258
4259 * w32term.c (x_set_glyph_string_clipping):
4260 Don't pass uninitialized region to CombineRgn.
4261
4262 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4263
4264 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4265 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4266 (Fx_close_connection): Remove unused variable `i'.
4267
4268 * w32font.c (w32font_draw): Return number of glyphs.
4269 (w32font_open_internal): Remove unused variable `i'.
4270 (w32font_driver): Add missing initializer.
4271
4272 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4273 (fill_in_menu): Remove unused variable `items_added'.
4274
4275 * w32term.c (last_mouse_press_frame): Remove static global variable.
4276 (w32_clip_to_row): Remove unused variable `f'.
4277 (x_delete_terminal): Remove unused variable `i'.
4278
4279 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4280 (NOTHING): Remove unused static global variable.
4281 (uniscribe_check_otf): Remove unused variable `table'.
4282 (uniscribe_font_driver): Add missing initializers.
4283
4284 2011-03-23 Julien Danjou <julien@danjou.info>
4285
4286 * term.c (Fsuspend_tty, Fresume_tty):
4287 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4288 * window.c (temp_output_buffer_show):
4289 * insdel.c (signal_before_change):
4290 * frame.c (Fhandle_switch_frame):
4291 * fileio.c (Fdo_auto_save):
4292 * emacs.c (Fkill_emacs):
4293 * editfns.c (save_excursion_restore):
4294 * cmds.c (internal_self_insert):
4295 * callint.c (Fcall_interactively):
4296 * buffer.c (Fkill_all_local_variables):
4297 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4298 Use Frun_hooks.
4299 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4300 unconditionnaly since it does the check itself.
4301
4302 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 Fix more problems found by GCC 4.5.2's static checks.
4305
4306 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4307 the first time through the loop, since we know p0 < p1 then.
4308 This also avoids a gcc -Wstrict-overflow warning.
4309
4310 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4311 leading to a memory leak, possible in functions like
4312 load_charset_map_from_file that can allocate an unbounded number
4313 of objects (Bug#8318).
4314
4315 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4316 that could (at least in theory) be that large.
4317
4318 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4319 This is less likely to overflow, and avoids undefined behavior if
4320 overflow does occur. All callers changed. Use strtoul to scan
4321 for the unsigned long integer.
4322 (pint2hrstr): Simplify and tune code slightly.
4323 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4324
4325 * scroll.c (do_scrolling): Work around GCC bug 48228.
4326 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4327
4328 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4329 This also avoids a warning with gcc -Wstrict-overflow.
4330 (validate_x_resource_name): Simplify count usage.
4331 This also avoids a warning with gcc -Wstrict-overflow.
4332
4333 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4334 fail (Bug#8306).
4335
4336 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4337
4338 * process.c (Fmake_network_process): Use socklen_t, not int,
4339 where POSIX says socklen_t is required in portable programs.
4340 This fixes a porting bug on hosts like 64-bit HP-UX, where
4341 socklen_t is wider than int (Bug#8277).
4342 (Fmake_network_process, server_accept_connection):
4343 (wait_reading_process_output, read_process_output):
4344 Likewise.
4345
4346 * process.c: Rename or move locals to avoid shadowing.
4347 (list_processes_1, Fmake_network_process):
4348 (read_process_output_error_handler, exec_sentinel_error_handler):
4349 Rename or move locals.
4350 (Fmake_network_process): Define label "retry_connect" only if needed.
4351 (Fnetwork_interface_info): Fix pointer signedness.
4352 (process_send_signal): Add cast to avoid pointer signedness problem.
4353 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4354 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4355
4356 Make tparam.h and terminfo.c consistent.
4357 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4358 Include tparam.h instead, since it declares them.
4359 * cm.h (PC): Remove extern decl; tparam.h now does this.
4360 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4361 * terminfo.c: Include tparam.h, to check interfaces.
4362 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4363 (tparam): Adjust signature to match interface in tparam.h;
4364 this removes some undefined behavior. Check that outstring and len
4365 are zero, which they always are with Emacs.
4366 * tparam.h (PC, BC, UP): New extern decls.
4367
4368 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4369 (xftfont_open): Rename locals to avoid shadowing.
4370
4371 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4372 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4373 (OTF_TAG_SYM): Omit macro if not needed.
4374 (ftfont_list): Remove unused local.
4375 (get_adstyle_property, ftfont_pattern_entity):
4376 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4377 Rename locals to avoid shadowing.
4378
4379 * xfont.c (xfont_list_family): Mark var as initialized.
4380
4381 * xml.c (make_dom): Now static.
4382
4383 * composite.c (composition_compute_stop_pos): Rename local to
4384 avoid shadowing.
4385 (composition_reseat_it): Remove unused locals.
4386 (find_automatic_composition, composition_adjust_point): Likewise.
4387 (composition_update_it): Mark var as initialized.
4388 (find_automatic_composition): Mark vars as initialized,
4389 with a FIXME (Bug#8290).
4390
4391 character.h: Rename locals to avoid shadowing.
4392 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4393 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4394 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4395 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4396 to avoid shadowing.
4397
4398 * textprop.c (property_change_between_p): Remove; unused.
4399
4400 * intervals.c (interval_start_pos): Now static.
4401
4402 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4403
4404 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4405 Rename locals to avoid shadowing.
4406
4407 * sound.c (wav_play, au_play, Fplay_sound_internal):
4408 Fix pointer signedness.
4409 (alsa_choose_format): Remove unused local var.
4410 (wav_play): Initialize a variable to 0, to prevent undefined
4411 behavior (Bug#8278).
4412
4413 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4414
4415 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4416
4417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4418 clobbering (Bug#8298).
4419 * sysdep.c (sys_subshell): Likewise.
4420 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4421
4422 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4423 This should get cleaned up, so that child_setup has the
4424 same signature on all platforms.
4425
4426 * callproc.c (call_process_cleanup): Now static.
4427 (relocate_fd): Rename locals to avoid shadowing.
4428
4429 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4430
4431 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4432 not to be necessary, and produces flickering.
4433
4434 2011-03-20 Glenn Morris <rgm@gnu.org>
4435
4436 * config.in: Remove file.
4437
4438 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4441 are now in src/globals.h.
4442 (syms_of_minibuf): Remove spurious & from previous change.
4443
4444 2011-03-20 Leo <sdl.web@gmail.com>
4445
4446 * minibuf.c (completing-read-function): New variable.
4447 (completing-read-default): Rename from completing-read.
4448 (completing-read): Call completing-read-function.
4449
4450 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4451
4452 * xfaces.c (Fx_load_color_file):
4453 Read color file from absolute filename (bug#8250).
4454
4455 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * makefile.w32-in: Update dependencies.
4458
4459 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4460
4461 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4462
4463 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 Fix more problems found by GCC 4.5.2's static checks.
4466
4467 * process.c (make_serial_process_unwind, send_process_trap):
4468 (sigchld_handler): Now static.
4469
4470 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4471 That way, the code declares only the vars that it needs.
4472 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4473 * s/cygwin.h (PTY_ITERATION): Likewise.
4474 * s/darwin.h (PTY_ITERATION): Likewise.
4475 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4476
4477 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4478 * process.c (allocate_pty): Don't declare stb unless it's needed.
4479
4480 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4481 (CONSTANTLIM): Remove; unused.
4482 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4483 Define only if needed.
4484
4485 * unexelf.c (unexec): Name an expression,
4486 to avoid gcc -Wbad-function-cast warning.
4487 Use a different way to cause a compilation error if anyone uses
4488 n rather than nn, a way that does not involve shadowing.
4489 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4490
4491 * deps.mk (unexalpha.o): Remove; unused.
4492
4493 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4494 * unexec.h: New file.
4495 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4496 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4497 Depend on unexec.h.
4498 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4499 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4500 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4501 Change as necessary to match prototype in unexec.h.
4502
4503 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4504 shadowing.
4505 (back_comment, skip_chars): Mark vars as initialized.
4506
4507 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4508 Rename locals to avoid shadowing.
4509
4510 * lread.c (read1): Rewrite so as not to use empty "else".
4511 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4512
4513 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4514
4515 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4516 warning when compiling print.c.
4517
4518 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4519 instead of using an uninitialized var.
4520 (font_sort_entities): Mark var as initialized.
4521
4522 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4523
4524 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4525 pointers to constants.
4526 (font_parse_fcname): Remove unused vars.
4527 (font_delete_unmatched): Now static.
4528 (font_get_spec): Remove; unused.
4529 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4530 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4531 Rename or move locals to avoid shadowing.
4532
4533 * fns.c (require_nesting_list, require_unwind): Now static.
4534 (Ffillarray): Rename locals to avoid shadowing.
4535
4536 * floatfns.c (domain_error2): Define only if needed.
4537 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4538
4539 * alloc.c (mark_backtrace): Move decl from here ...
4540 * lisp.h: ... to here, so that it can be checked.
4541
4542 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4543 (Fdefvar): Rewrite so as not to use empty "else".
4544 (lisp_indirect_variable): Name an expression,
4545 to avoid gcc -Wbad-function-cast warning.
4546 (Fdefvar): Rename locals to avoid shadowing.
4547
4548 * callint.c (quotify_arg, quotify_args): Now static.
4549 (Fcall_interactively): Rename locals to avoid shadowing.
4550 Use const pointer when appropriate.
4551
4552 * lisp.h (get_system_name, get_operating_system_release):
4553 Move decls here, to check interfaces.
4554 * process.c (get_operating_system_release): Move decl to lisp.h.
4555 * xrdb.c (get_system_name): Likewise.
4556 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4557 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4558 some of which prompt warnings from gcc -Wbad-function-cast.
4559 (Fformat_time_string, Fencode_time, Finsert_char):
4560 (Ftranslate_region_internal, Fformat):
4561 Rename or remove local vars to avoid shadowing.
4562 (Ftranslate_region_internal): Mark var as initialized.
4563
4564 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4565 avoid shadowing.
4566
4567 * lisp.h (eassert): Check that the argument compiles, even if
4568 ENABLE_CHECKING is not defined.
4569
4570 * data.c (Findirect_variable): Name an expression, to avoid
4571 gcc -Wbad-function-cast warning.
4572 (default_value, arithcompare, arith_driver, arith_error): Now static.
4573 (store_symval_forwarding): Rename local to avoid shadowing.
4574 (Fmake_variable_buffer_local, Fmake_local_variable):
4575 Mark variables as initialized.
4576 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4577
4578 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4579 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4580 Rename locals to avoid shadowing.
4581 (mark_stack): Move local variables into the #ifdef region where
4582 they're used.
4583 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4584 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4585 needed otherwise.
4586 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4587 (GC_STRING_CHARS): Remove; not used.
4588 (Fmemory_limit): Cast sbrk's returned value to char *.
4589
4590 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4591 avoids undefined behavior in theory.
4592
4593 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4594
4595 Use functions, not macros, for up- and down-casing (Bug#8254).
4596 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4597 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4598 to use the following functions instead of these macros.
4599 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4600 EMACS_INT, since callers assume the returned value fits in int.
4601 (upcase1): Likewise, for UPCASE_TABLE.
4602 (uppercasep, lowercasep, upcase): New static inline functions.
4603 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4604 the race-condition problem in the old DOWNCASE.
4605
4606 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4607 Rename locals to avoid shadowing.
4608 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4609 (regex_compile, re_search_2, re_match_2_internal):
4610 Remove unused local vars.
4611 (FREE_VAR): Rewrite so as not to use empty "else",
4612 which gcc can warn about.
4613 (regex_compile, re_match_2_internal): Mark locals as initialized.
4614 (RETALLOC_IF): Define only if needed.
4615 (WORDCHAR_P): Likewise. This one is never needed, but is used
4616 only in a comment talking about a compiler bug, so put inside
4617 the #if 0 of that comment.
4618 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4619 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4620 Remove; unused.
4621
4622 * search.c (boyer_moore): Rename locals to avoid shadowing.
4623 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4624 (PREV_CHAR_BOUNDARY): Likewise.
4625
4626 * search.c (simple_search): Remove unused var.
4627
4628 * dired.c (compile_pattern): Move decl from here ...
4629 * lisp.h: ... to here, so that it can be checked.
4630 (struct re_registers): New forward decl.
4631
4632 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4633
4634 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4635 All uses changed.
4636 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4637 Rename locals to avoid shadowing.
4638 (Fvertical_motion): Mark locals as initialized.
4639
4640 * casefiddle.c (casify_object, casify_region): Now static.
4641 (casify_region): Mark local as initialized.
4642
4643 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4644
4645 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4646 New macros, so that the caller can use some names other than
4647 gcpro1, gcpro2, etc.
4648 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4649 of the new macros.
4650 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4651 argument, for consistency with GCPRO2_VAR, etc: it is now the
4652 prefix of the variable, not the variable itself. All uses
4653 changed.
4654 * dired.c (directory_files_internal, file_name_completion):
4655 Rename locals to avoid shadowing.
4656
4657 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4658 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4659 dired.c's scmp function, had undefined behavior.
4660 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4661 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4662 * buffer.h: ... to here, because these macros use current_buffer,
4663 and the new implementation with inline functions needs to have
4664 current_buffer in scope now, rather than later when the macros
4665 are used.
4666 (downcase, upcase1): New static inline functions.
4667 (DOWNCASE, UPCASE1): Reimplement using these functions.
4668 This avoids undefined behavior in expressions like
4669 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4670 from race conditions in accessing the global variables
4671 case_temp1 and case_temp2.
4672 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4673 * lisp.h (case_temp1, case_temp2): Remove their decls.
4674 * character.h (ASCII_CHAR_P): Move from here ...
4675 * lisp.h: ... to here, so that the inline functions mentioned
4676 above can use them.
4677
4678 * dired.c (directory_files_internal_unwind): Now static.
4679
4680 * fileio.c (file_name_as_directory, directory_file_name):
4681 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4682 Now static.
4683 (file_name_as_directory): Use const pointers when appropriate.
4684 (Fexpand_file_name): Likewise. In particular, newdir might
4685 point at constant storage, so make it a const pointer.
4686 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4687 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4688 signedness issues.
4689 (Fset_file_times, Finsert_file_contents, auto_save_error):
4690 Rename locals to avoid shadowing.
4691
4692 * minibuf.c (choose_minibuf_frame_1): Now static.
4693 (Ftry_completion, Fall_completions): Rename or remove locals
4694 to avoid shadowing.
4695
4696 * marker.c (bytepos_to_charpos): Remove; unused.
4697
4698 * lisp.h (verify_bytepos, count_markers): New decls,
4699 so that gcc does not warn that these functions aren't declared.
4700
4701 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4702 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4703 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4704 (copy_text): Remove unused local var.
4705
4706 * filelock.c (within_one_second): Now static.
4707 (lock_file_1): Rename local to avoid shadowing.
4708
4709 * buffer.c (fix_overlays_before): Mark locals as initialized.
4710 (fix_start_end_in_overlays): Likewise. This function should be
4711 simplified by using pointers-to-pointers, but that's a different
4712 matter.
4713 (switch_to_buffer_1): Now static.
4714 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4715 (report_overlay_modification): Rename locals to avoid shadowing.
4716
4717 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4718 Fix pointer signedness issue.
4719 (sys_subshell): Mark local as volatile if checking for lint,
4720 to suppress a gcc -Wclobbered warning that does not seem to be right.
4721 (MAXPATHLEN): Define only if needed.
4722
4723 * process.c (serial_open, serial_configure): Move decls from here ...
4724 * systty.h: ... to here, so that they can be checked.
4725
4726 * fns.c (get_random, seed_random): Move extern decls from here ...
4727 * lisp.h: ... to here, so that they can be checked.
4728
4729 * sysdep.c (reset_io): Now static.
4730 (wait_for_termination_signal): Remove; unused.
4731
4732 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4733 (copy_keymap_item, append_key, push_text_char_description):
4734 Now static.
4735 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4736 (DENSE_TABLE_SIZE): Remove; unused.
4737 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4738 (describe_map_tree):
4739 Rename locals to avoid shadowing.
4740
4741 * keyboard.c: Declare functions static if they are not used elsewhere.
4742 (echo_char, echo_dash, cmd_error, top_level_2):
4743 (poll_for_input, handle_async_input): Now static.
4744 (read_char, kbd_buffer_get_event, make_lispy_position):
4745 (make_lispy_event, make_lispy_movement, apply_modifiers):
4746 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4747 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4748 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4749 (read_key_sequence, read_char): Mark locals as initialized.
4750 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4751
4752 * keyboard.h (make_ctrl_char): New decl.
4753 (mark_kboards): Move decl here ...
4754 * alloc.c (mark_kboards): ... from here.
4755
4756 * lisp.h (force_auto_save_soon): New decl.
4757
4758 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4759 (DEFINE_DUMMY_FUNCTION): New macro.
4760 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4761 Use it.
4762 (main): Add casts to avoid warnings
4763 if GCC considers string literals to be constants.
4764
4765 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4766
4767 * dbusbind.c: Pointer signedness fixes.
4768 (xd_signature, xd_append_arg, xd_initialize):
4769 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4770 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4771 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4772 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4773
4774 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4775 if GCC considers string literals to be constants.
4776 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4777
4778 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4779
4780 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4781 (print_preprocess, print_object): New macro to fix last change.
4782
4783 * print.c (print_preprocess): Don't forget font objects.
4784
4785 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4786
4787 * emacs.c (USAGE3): Doc fixes.
4788
4789 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4790
4791 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4792 structure.
4793
4794 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4795
4796 * lisp.h (VWindow_system, Qfile_name_history):
4797 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4798 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4799 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4800
4801 * w32select.c: Don't #include "keyboard.h".
4802 (run_protected): Add extern declaration for waiting_for_input.
4803
4804 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4805 * w32console.c (detect_input_pending, read_input_pending)
4806 (encode_terminal_code):
4807 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4808 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4809 (w32_system_caret_y, Qfile_name_history):
4810 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4811 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4812 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4813 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4814 * w32proc.c (Qlocal, report_file_error):
4815 * w32term.c (Vwindow_system, updating_frame):
4816 * w32uniscribe.c (initialized, uniscribe_font_driver):
4817 Remove unneeded extern declarations.
4818
4819 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4820
4821 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4822
4823 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4824
4825 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4826 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4827 These macros can no longer be used for assignment.
4828
4829 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4830 Assign struct members directly, instead of using BUF_BEGV etc.
4831 (record_buffer_markers, fetch_buffer_markers): New functions for
4832 recording and fetching special buffer markers.
4833 (set_buffer_internal_1, set_buffer_temp): Use them.
4834
4835 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4836
4837 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4838
4839 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4840 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4841
4842 * xdisp.c (hscroll_window_tree):
4843 (reconsider_clip_changes): Use PT instead of BUF_PT.
4844
4845 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4846
4847 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4848 $(EMACS_ROOT)/lib/intprops.h.
4849
4850 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 Fix more problems found by GCC 4.5.2's static checks.
4853
4854 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4855 to unsigned char * to avoid compiler diagnostic.
4856 (xg_free_frame_widgets): Make it clear that a local variable is
4857 needed only if USE_GTK_TOOLTIP.
4858 (gdk_window_get_screen): Make it clear that this macro is needed
4859 only if USE_GTK_TOOLTIP.
4860 (int_gtk_range_get_value): New function, which avoids a diagnostic
4861 from gcc -Wbad-function-cast.
4862 (xg_set_toolkit_scroll_bar_thumb): Use it.
4863 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4864 diagnostic from gcc -Wbad-function-cast.
4865 (get_utf8_string, xg_get_file_with_chooser):
4866 Rename locals to avoid shadowing.
4867 (create_dialog): Move locals to avoid shadowing.
4868
4869 * xgselect.c (xg_select): Remove unused var.
4870
4871 * image.c (four_corners_best): Mark locals as initialized.
4872 (gif_load): Initialize transparent_p to zero (Bug#8238).
4873 Mark another local as initialized.
4874 (my_png_error, my_error_exit): Mark with NO_RETURN.
4875
4876 * image.c (clear_image_cache): Now static.
4877 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4878 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4879 (x_edge_detection): Remove unnecessary cast that
4880 gcc -Wbad-function-cast diagnoses.
4881 (gif_load): Fix pointer signedness.
4882 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4883 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4884
4885 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4886
4887 Improve quality of tests for time stamp overflow.
4888 For example, without this patch (encode-time 0 0 0 1 1
4889 1152921504606846976) returns the obviously-bogus value (-948597
4890 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4891 reports time overflow. See
4892 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4893 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4894 * editfns.c: Include limits.h and intprops.h.
4895 (TIME_T_MIN, TIME_T_MAX): New macros.
4896 (time_overflow): Move earlier, to before first use.
4897 (hi_time, lo_time): New functions, for an accurate test for
4898 out-of-range times.
4899 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4900 (Fget_internal_run_time): Don't assume time_t fits in int.
4901 (make_time): Use list2 instead of Fcons twice.
4902 (Fdecode_time): More accurate test for out-of-range times.
4903 (check_tm_member): New function.
4904 (Fencode_time): Use it, to test for out-of-range times.
4905 (lisp_time_argument): Don't rely on undefined left-shift and
4906 right-shift behavior when checking for time stamp overflow.
4907
4908 * editfns.c (time_overflow): New function, refactoring common code.
4909 (Fformat_time_string, Fdecode_time, Fencode_time):
4910 (Fcurrent_time_string): Use it.
4911
4912 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4913 * dired.c (make_time): Move to ...
4914 * editfns.c (make_time): ... here.
4915 * systime.h: Note the move.
4916
4917 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4918
4919 * fringe.c (update_window_fringes): Remove unused variables.
4920
4921 * unexmacosx.c (copy_data_segment): Also copy __got section.
4922 (Bug#8223)
4923
4924 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4925
4926 * termcap.c [MSDOS]: Include "msdos.h".
4927 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4928 Constify `char *' arguments and their references according to
4929 prototypes in tparam.h.
4930
4931 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4932
4933 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4934 Adapt all references accordingly.
4935
4936 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4937
4938 2011-03-11 Tom Tromey <tromey@redhat.com>
4939
4940 * buffer.c (syms_of_buffer): Remove obsolete comment.
4941
4942 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4943
4944 * termhooks.h (encode_terminal_code): Declare prototype.
4945
4946 * msdos.c (encode_terminal_code): Don't declare prototype.
4947
4948 * term.c (encode_terminal_code): Now external again, used by
4949 w32console.c and msdos.c.
4950
4951 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4952 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4953
4954 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4955
4956 Fix some minor problems found by GCC 4.5.2's static checks.
4957
4958 * fringe.c (update_window_fringes): Mark locals as initialized
4959 (Bug#8227).
4960 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4961
4962 * alloc.c (mark_fringe_data): Move decl from here ...
4963 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4964 to check its interface.
4965 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4966
4967 * fontset.c (free_realized_fontset): Now static.
4968 (Fset_fontset_font): Rename local to avoid shadowing.
4969 (fontset_font): Mark local as initialized.
4970 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4971
4972 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4973
4974 * xselect.c (x_disown_buffer_selections): Remove; not used.
4975 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4976 (x_own_selection, Fx_disown_selection_internal): Rename locals
4977 to avoid shadowing.
4978 (x_handle_dnd_message): Remove local to avoid shadowing.
4979
4980 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4981 so that the caller can use some name other than gcpro1.
4982 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4983 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4984 (Fx_backspace_delete_keys_p):
4985 Use them to avoid shadowing, and rename vars to avoid shadowing.
4986 (x_decode_color, x_set_name, x_window): Now static.
4987 (Fx_create_frame): Add braces to silence GCC warning.
4988 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4989 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4990 Remove unused locals.
4991 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4992 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4993 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4994 macros.
4995
4996 * xterm.h (x_mouse_leave): New decl.
4997
4998 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4999 Remove unused functions.
5000 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5001 (x_calc_absolute_position): Now static.
5002 (XTread_socket): Don't define label "out" unless it's used.
5003 Don't declare local "event" unless it's used.
5004 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5005 unless they are used.
5006 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5007 (x_fatal_error_signal): Remove; not used.
5008 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5009 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5010 (x_error_catcher, x_connection_closed, x_error_handler):
5011 (x_error_quitter, xembed_send_message, x_iconify_frame):
5012 (my_log_handler): Rename locals to avoid shadowing.
5013 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5014 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5015
5016 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5017 Rename or move locals to avoid shadowing.
5018 (tty_defined_color, merge_face_heights): Now static.
5019 (free_realized_faces_for_fontset): Remove; not used.
5020 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5021 does not deduce is never used uninitialized.
5022 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5023 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5024
5025 * terminal.c (store_terminal_param): Now static.
5026
5027 * xmenu.c (menu_highlight_callback): Now static.
5028 (set_frame_menubar): Remove unused local.
5029 (xmenu_show): Rename parameter to avoid shadowing.
5030 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5031 since they might point to immutable storage.
5032 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5033 since it's unused otherwise.
5034
5035 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5036 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5037 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5038 avoids a gcc -Wuninitialized diagnostic.
5039 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5040 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5041 does not deduce are never used uninitialized.
5042
5043 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5044
5045 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5046 * window.c (window_loop, size_window):
5047 (run_window_configuration_change_hook, enlarge_window): Likewise.
5048
5049 * window.c (display_buffer): Now static.
5050 (size_window): Mark variables that gcc -Wuninitialized
5051 does not deduce are never used uninitialized.
5052 * window.h (check_all_windows): New decl, to forestall
5053 gcc -Wmissing-prototypes diagnostic.
5054 * dispextern.h (bidi_dump_cached_states): Likewise.
5055
5056 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5057 shadowing.
5058 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5059 Include <limits.h>.
5060 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5061 and to avoid gcc -Wuninitialized warning.
5062 (load_charset_map): Mark variables that gcc -Wuninitialized
5063 does not deduce are never used uninitialized.
5064 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5065
5066 * coding.c (coding_set_source, coding_set_destination):
5067 Use "else { /* comment */ }" rather than "else /* comment */;"
5068 for clarity, and to avoid gcc -Wempty-body warning.
5069 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5070 a block, when the outer 'i' will do.
5071 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5072 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5073 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5074 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5075 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5076 Rename locals to avoid shadowing.
5077 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5078 * coding.c (emacs_mule_char, encode_invocation_designation):
5079 Now static, since they're not used elsewhere.
5080 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5081 (decode_coding_object, encode_coding_object, detect_coding_system):
5082 (decode_coding_emacs_mule): Mark variables that gcc
5083 -Wuninitialized does not deduce are never used uninitialized.
5084 (detect_coding_iso_2022): Initialize a local variable that might
5085 be used uninitialized. Leave a FIXME because it's not clear that
5086 this initialization is needed. (Bug#8211)
5087 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5088 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5089 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5090 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5091 Remove unused macros.
5092
5093 * category.c (hash_get_category_set): Remove unused local var.
5094 (copy_category_table): Now static, since it's not used elsewhere.
5095 * character.c (string_count_byte8): Likewise.
5096
5097 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5098 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5099
5100 * chartab.c (copy_sub_char_table): Now static, since it's not used
5101 elsewhere.
5102 (sub_char_table_ref_and_range, char_table_ref_and_range):
5103 Rename locals to avoid shadowing.
5104 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5105
5106 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5107 (BIDI_BOB): Remove unused macro.
5108
5109 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5110 deduce are never used uninitialized.
5111 * term.c (encode_terminal_code): Likewise.
5112
5113 * term.c (encode_terminal_code): Now static. Remove unused local.
5114
5115 * tparam.h: New file.
5116 * term.c, tparam.h: Include it.
5117 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5118 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5119 Move these decls to tparam.h, and make them agree with what
5120 is actually in tparam.c. The previous trick of using incompatible
5121 decls in different modules does not conform to the C standard.
5122 All callers of tparam changed to use tparam's actual API.
5123 * tparam.c (tparam1, tparam, tgoto):
5124 Use const pointers where appropriate.
5125
5126 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5127 * cm.h (struct cm): Likewise.
5128 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5129 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5130 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5131 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5132 (turn_on_face, init_tty): Likewise.
5133 * termchar.h (struct tty_display_info): Likewise.
5134
5135 * term.c (term_mouse_position): Rename local to avoid shadowing.
5136
5137 * alloc.c (mark_ttys): Move decl from here ...
5138 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5139
5140 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5141
5142 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5143
5144 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * search.c (compile_pattern_1): Remove argument regp, unused since
5147 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5148 (compile_pattern): Don't pass it.
5149
5150 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5151
5152 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5153 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5154 for ! HAVE_GTK3.
5155 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5156
5157 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5158
5159 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5160 gdk_window_get_screen, gdk_window_get_geometry,
5161 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5162 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5163 (xg_get_pixbuf_from_pixmap): New function.
5164 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5165 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5166 Call xg_get_pixbuf_from_pixmap instead of
5167 gdk_pixbuf_get_from_drawable.
5168 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5169 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5170 (xg_check_special_colors): Use GtkStyleContext and its functions
5171 for HAVE_GTK3.
5172 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5173 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5174 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5175 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5176 Call gtk_widget_get_preferred_size.
5177 (xg_frame_resized): gdk_window_get_geometry only takes 5
5178 parameters.
5179 (xg_win_to_widget, xg_event_is_for_menubar):
5180 Call gdk_x11_window_lookup_for_display.
5181 (xg_set_widget_bg): New function.
5182 (delete_cb): New function.
5183 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5184 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5185 (xg_set_background_color): Call xg_set_widget_bg.
5186 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5187 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5188 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5189 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5190 if ! HAVE_GTK3.
5191 (update_frame_tool_bar): Call gtk_widget_hide.
5192 (xg_initialize): Use GDK_KEY_g.
5193
5194 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5195 if ! HAVE_GTK3
5196 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5197
5198 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5199 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5200 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5201
5202 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * w32xfns.c (select_palette): Check success of RealizePalette against
5205 GDI_ERROR, not zero.
5206
5207 See ChangeLog.11 for earlier changes.
5208
5209 ;; Local Variables:
5210 ;; coding: utf-8
5211 ;; End:
5212
5213 Copyright (C) 2011 Free Software Foundation, Inc.
5214
5215 This file is part of GNU Emacs.
5216
5217 GNU Emacs is free software: you can redistribute it and/or modify
5218 it under the terms of the GNU General Public License as published by
5219 the Free Software Foundation, either version 3 of the License, or
5220 (at your option) any later version.
5221
5222 GNU Emacs is distributed in the hope that it will be useful,
5223 but WITHOUT ANY WARRANTY; without even the implied warranty of
5224 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5225 GNU General Public License for more details.
5226
5227 You should have received a copy of the GNU General Public License
5228 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.