1 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4 (CATEGORY_MEMBER): Enforce 1/0 value.
5 * category.c (_temp_category_set): Remove.
7 2012-06-16 Eli Zaretskii <eliz@gnu.org>
9 * window.c (Fdelete_other_windows_internal)
10 (Fdelete_window_internal): Don't access frame's mouse highlight
11 info of the initial frame. (Bug#11677)
13 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
15 * .gdbinit (xgetint): Fix recently-introduced paren typo.
16 Assume USE_2_TAGS_FOR_INTS.
17 (xreload): Adjust $tagmask width to match recent lisp.h change.
19 Simplify lisp.h in minor ways that should not affect code.
20 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
21 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
22 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
23 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
24 (INTTYPEBITS): New macro, for clarity.
25 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
26 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
27 now that USE_LSB_TAG is always defined.
28 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
29 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
31 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
33 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
35 2012-06-13 Glenn Morris <rgm@gnu.org>
37 * s/bsd-common.h (BSD4_3):
38 * s/usg5-4-common.h (USG5_4): No longer define; unused.
40 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
42 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
45 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
47 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
48 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
49 * alloc.c (widen_to_Lisp_Object): Removed.
50 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
51 * frame.c (delete_frame): Remove outdated comment.
52 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
54 (Fw32_unregister_hot_key): Likewise.
55 (Fw32_toggle_lock_key): Likewise.
56 * w32menu.c (add_menu_item): Likewise.
57 (w32_menu_display_help): Use XIL instead of checking
59 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
60 (init_heap): Likewise.
61 * w32term.c (w32_read_socket): Update comment.
63 2012-06-13 Glenn Morris <rgm@gnu.org>
65 * s/usg5-4-common.h, src/s/unixware.h:
66 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
68 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
70 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
72 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
73 * alloc.c (make_number) [!defined make_number]:
74 Remove, as lisp.h always defines this now.
75 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
76 (roundup_size): Verify that it is a power of 2.
77 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
78 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
79 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
80 -DUSE_LSB_TAG=0, to override the automatically-selected default.
81 USE_LSB_TAG now is always defined to be either 0 or 1.
83 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
84 code works fine either way, and efficiency is not a concern here,
85 as the union type is for debugging, not for production.
86 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
87 Use an inline function on all platforms when using the union type,
88 since this is simpler and 'static inline' can be used portably
90 (LISP_INITIALLY_ZERO): New macro.
91 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
92 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
94 2012-06-12 Glenn Morris <rgm@gnu.org>
96 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
98 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
100 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
101 Move BROKEN_SIGIO to configure.
103 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
104 Move NO_TERMIO to configure.
106 2012-06-12 Chong Yidong <cyd@gnu.org>
108 * image.c (imagemagick_load_image): Use MagickFlattenImage if
109 MagickMergeImageLayers is undefined. Use pixel pusher loop if
110 MagickExportImagePixels is undefined.
112 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
114 * image.c (imagemagick_load_image): Remove unused label.
116 2012-06-11 Glenn Morris <rgm@gnu.org>
118 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
119 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
120 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
121 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
123 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
125 * alloc.c (make_byte_code): New function.
126 (Fmake_byte_code): Use it. Don't purify here.
127 * lread.c (read1): Use it as well to avoid extra allocation.
129 2012-06-11 Chong Yidong <cyd@gnu.org>
131 * image.c (imagemagick_load_image): Implement transparency.
133 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
135 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
136 account for preceding backslashes. (Bug#11663)
138 2012-06-09 Chong Yidong <cyd@gnu.org>
140 * term.c: Support italics in capable terminals (Bug#9652).
141 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
142 (turn_on_face): Output using TS_enter_italic_mode if available.
143 Don't handle unused blinking and alt-charset cases.
144 (turn_off_face): Handle italic case; discard unused tty_blinking_p
145 and tty_alt_charset_p cases.
146 (tty_capable_p, init_tty): Support italics.
148 * termchar.h (struct tty_display_info): Add field for italics.
149 Remove unused blink field.
151 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
154 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
155 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
156 tty_alt_charset_p. Add tty_italic_p.
158 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
160 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
161 dbus_type_is_basic if available.
162 (xd_extract_signed, xd_extract_unsigned): Rename from
163 extract_signed and extract_unsigned, respectively. Adapt callers.
165 2012-06-09 Chong Yidong <cyd@gnu.org>
167 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
169 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
172 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
174 * xdisp.c (vmessage): Treat frame message as multibyte.
175 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
176 would generate the diagnostic "Making \302\247 buffer-local while
179 2012-06-08 Eli Zaretskii <eliz@gnu.org>
181 * dispnew.c (showing_window_margins_p): Undo last change, which
182 was done due to an inadvertent commit.
183 (adjust_frame_glyphs_for_frame_redisplay): Do call
184 showing_window_margins_p.
186 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
188 * eval.c (Fmake_var_non_special): New primitive.
189 (syms_of_eval): Defsubr it.
190 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
192 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
194 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
195 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
197 2012-06-08 Eli Zaretskii <eliz@gnu.org>
199 * alloc.c (allocate_vectorlike): Fix last change.
201 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
203 Block-based vector allocation of small vectors.
204 * lisp.h (struct vectorlike_header): New field `nbytes',
205 adjust comment accordingly.
206 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
207 to denote vector blocks. Adjust users (live_vector_p,
208 mark_maybe_pointer, valid_lisp_object_p) accordingly.
209 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
210 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
211 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
212 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
213 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
214 (roundup_size): New constant.
215 (struct vector_block): New data type.
216 (vector_blocks, vector_free_lists, zero_vector): New variables.
217 (all_vectors): Rename to `large_vectors'.
218 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
219 (sweep_vectors): New functions.
220 (allocate_vectorlike): Return `zero_vector' as the only vector of
221 0 items. Allocate new vector from block if vector size is less than
222 or equal to VBLOCK_BYTES_MAX.
223 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
224 (init_alloc_once): Add call to init_vectors.
226 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
228 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
230 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
232 * doprnt.c (doprnt): Truncate multibyte char correctly.
233 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
234 would mishandle a string argument "Xc" if X was a multibyte
235 character of length 2: it would truncate after X's first byte
236 rather than including all of X.
238 2012-06-06 Chong Yidong <cyd@gnu.org>
240 * buffer.c (word_wrap): Doc fix.
242 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
244 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
246 2012-06-03 Glenn Morris <rgm@gnu.org>
248 * xdisp.c (tool-bar-style): Doc fix.
250 2012-06-03 Ulrich Müller <ulm@gentoo.org>
252 * Makefile.in (PAXCTL): Define.
253 (temacs$(EXEEXT)): Disable memory randomization for the temacs
254 binary via PaX flags if the paxctl utility is available.
255 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
256 Restore PaX flags to their default. (Bug#11398)
258 2012-06-03 Chong Yidong <cyd@gnu.org>
260 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
263 2012-06-03 Chong Yidong <cyd@gnu.org>
265 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
266 (note_mode_line_or_margin_highlight): If there is no help echo,
267 use mode-line-default-help-echo. Handle the case where the mouse
268 position is past the end of the mode line string.
270 * buffer.c (buffer_local_value_1): New function, split from
271 Fbuffer_local_value; can return Qunbound.
272 (Fbuffer_local_value): Use it.
273 (Vmode_line_format): Docstring tweaks.
275 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
277 * sysdep.c (system_process_attributes): Improve comment.
279 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
281 * keyboard.c: Export real-this-command to Elisp.
282 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
283 and DEFVAR it. Update all users.
285 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
287 * minibuf.c (Fassoc_string): Remove duplicate declaration.
289 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
290 Convert pctcpu and pctmem to Lisp float properly.
291 Let the compiler fold better, as 100.0/0x8000 is exact.
293 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
295 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
298 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
300 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
302 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
304 For a 'struct window', replace some Lisp_Object fields to
305 bitfields where appropriate, remove unused fields.
306 * window.h (struct window): Remove unused 'last_mark_x' and
307 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
308 change it's type from Lisp_Object to bitfield.
309 Change type of 'force_start', 'optional_new_start',
310 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
311 fields from Lisp_Object to bitfield. Adjust users accordingly.
313 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
315 Pacify gcc -Wdouble-precision when using Xaw.
316 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
317 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
318 Use 'float' consistently, rather than 'float' in most places
319 and 'double' in a couple of places.
321 2012-05-31 Eli Zaretskii <eliz@gnu.org>
323 * xdisp.c (handle_stop): Detect whether we have overlay strings
324 loaded by testing it->current.overlay_string_index to be
325 non-negative, instead of checking whether n_overlay_strings is
326 positive. (Bug#11587)
328 2012-05-31 Chong Yidong <cyd@gnu.org>
330 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
332 * doc.c (Fsubstitute_command_keys): Doc fix.
334 2012-05-31 Eli Zaretskii <eliz@gnu.org>
336 * search.c (search_buffer): Remove calls to
337 r_alloc_inhibit_buffer_relocation, as it is now called by
338 maybe_unify_char, which was the cause of relocation of buffer text
341 2012-05-31 Eli Zaretskii <eliz@gnu.org>
343 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
344 for the duration of call to load_charset, to avoid problems with
345 callers of maybe_unify_char that access buffer text through C
348 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
349 decrement the inhibition flag, instead of just setting or
352 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
354 Remove obsolete '#define static' cruft.
355 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
356 This #undef was "temporary" in 2000; it is no longer needed
357 now that '#define static' has gone away.
358 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
359 (gray_bitmap_bits): Remove; no longer needed.
360 All uses replaced with definiens.
361 * xterm.c: Include "bitmaps/gray.xbm".
363 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
365 Clean up __executable_start, monstartup when --enable-profiling.
366 The following changes affect the code only when profiling.
367 * dispnew.c (__executable_start): Rename from safe_bcopy.
368 Define only on platforms that need it.
369 * emacs.c: Include <sys/gmon.h> when profiling.
370 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
371 (__executable_start): Remove decl, since lisp.h does it now.
372 (safe_bcopy): Remove decl; no longer has that name.
373 (main): Coalesce #if into single bit of code, for simplicity.
374 Cast pointers to uintptr_t, since standard libraries want integers
376 * lisp.h (__executable_start): New decl.
378 2012-05-31 Glenn Morris <rgm@gnu.org>
380 * image.c (Fimagemagick_types): Doc fix.
382 2012-05-30 Jim Meyering <meyering@redhat.com>
384 * callproc.c (Fcall_process_region): Include directory component
385 in mkstemp error message (Bug#11586).
387 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
389 * alloc.c, lisp.h (make_pure_vector): Now static.
391 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
393 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
395 (Fautoload): Do the hash-doc more carefully.
396 * data.c (Fdefalias): Purify definition, except for keymaps.
397 (Qdefun): Move from eval.c.
398 * lisp.h (Qdefun): Remove.
399 * lread.c (read1): Tiny simplification.
401 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
403 Do not create empty overlays with the evaporate property (Bug#9642).
404 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
405 Bug#9642, but explicitly check that the buffer the overlay would
406 be moved to is live and rearrange lines to make sure that errors
407 will not put the overlay in an inconsistent state.
408 (Fdelete_overlay): Cosmetics.
410 2012-05-28 Eli Zaretskii <eliz@gnu.org>
412 * w32term.c (my_bring_window_to_top): New function.
413 (x_raise_frame): Use handle returned by DeferWindowPos, which
414 could be different from the original one.
415 Call my_bring_window_to_top instead of my_set_foreground_window.
418 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
419 by calling BringWindowToTop.
421 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
422 (WM_EMACS_END): Increase by one.
424 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
426 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
427 This avoids undefined behavior that might cause the eassert
428 to not catch an out-of-range value.
430 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
432 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
435 2012-05-27 Eli Zaretskii <eliz@gnu.org>
437 * bidi.c (bidi_mirror_char): Fix last change.
439 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
441 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
442 when referring to sectname field in printf format.
444 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
446 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
447 Only r_alloc_inhibit_buffer_relocation needed to be added;
448 the others were already declared.
450 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
451 before checking whether it's out of range. Put the check inside
453 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
455 2012-05-27 Ken Brown <kbrown@cornell.edu>
457 * callproc.c (Fcall_process): Restore a line that was accidentally
458 commented out in the 2011-02-13 change (bug#11547).
460 2012-05-27 Eli Zaretskii <eliz@gnu.org>
462 * lisp.h [REL_ALLOC]: Add prototypes for external functions
465 * buffer.c [REL_ALLOC]: Remove prototypes of
466 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
467 they are now on lisp.h.
469 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
471 * search.c (search_buffer): Use it to inhibit relocation of buffer
472 text while re_search_2 is doing its job, because re_search_2 is
473 passed C pointers to buffer text. (Bug#11519)
475 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
478 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
479 state after an additional call to move_it_in_display_line_to, keep
480 the values of it->max_ascent and it->max_descent found for the
482 (pos_visible_p): Revert the comparison against bottom_y to what it
483 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
486 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
488 Fix coding-related core dumps with gcc -ftrapv.
489 The code was computing A - B, where A and B are pointers, and B is
490 random garbage. This can lead to core dumps on platforms that
491 have special pointer registers, and it also leads to core dumps on
492 x86-64 when compiled with gcc -ftrapv. The fix is to compute
493 A - B only when B is initialized properly.
494 * coding.c (coding_set_source, coding_set_destination): Return void.
495 (coding_change_source, coding_change_destinations): New functions,
496 with the old behaviors of coding_set_source and coding_set_destination.
497 All callers that need an offset changed to use these new functions.
499 2012-05-26 Glenn Morris <rgm@gnu.org>
501 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
503 2012-05-26 Eli Zaretskii <eliz@gnu.org>
505 Extend mouse support on W32 text-mode console.
506 * xdisp.c (draw_row_with_mouse_face):
507 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
509 * w32console.c: Include window.h.
510 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
512 (initialize_w32_display): Initialize mouse-highlight data.
514 * w32inevt.c: Include termchar.h and window.h.
515 (do_mouse_event): Support mouse-autoselect-window. When the mouse
516 moves, call note_mouse_highlight. If help_echo changed, call
517 gen_help_event to produce help-echo message in the echo area.
518 Call clear_mouse_face if mouse_face_hidden is set in the mouse
521 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
523 * lread.c (read1): Simplify slightly to avoid an overflow warning
524 with GCC 4.7.0 on x86-64.
526 2012-05-26 Eli Zaretskii <eliz@gnu.org>
528 * bidi.c (bidi_mirror_char): Revert last change: an int is
529 definitely wide enough here.
531 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
533 Fix integer width and related bugs (Bug#9874).
534 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
535 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
536 (string_bytes, check_sblock, allocate_string_data):
537 (compact_small_strings, Fmake_bool_vector, make_string)
538 (make_unibyte_string, make_multibyte_string)
539 (make_string_from_bytes, make_specified_string)
540 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
541 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 (allocate_pseudovector):
545 Use int, not EMACS_INT, where int is wide enough.
546 (inhibit_garbage_collection, Fgarbage_collect):
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
549 int might not be wide enough.
550 (bidi_cache_search, bidi_cache_find, bidi_init_it)
551 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
552 (bidi_at_paragraph_end, bidi_find_paragraph_start)
553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
554 (bidi_level_of_next_char, bidi_move_to_visually_next):
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
556 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
557 (Fkill_buffer, Fset_buffer_major_mode)
558 (advance_to_char_boundary, Fbuffer_swap_text)
559 (Fset_buffer_multibyte, overlays_at, overlays_in)
560 (overlay_touches_p, struct sortvec, record_overlay_string)
561 (overlay_strings, recenter_overlay_lists)
562 (adjust_overlays_for_insert, adjust_overlays_for_delete)
563 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
564 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
565 (Foverlay_recenter, last_overlay_modification_hooks_used)
566 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
568 (validate_region): Omit unnecessary test for b <= e,
569 since that's guaranteed by the previous test.
570 (adjust_overlays_for_delete): Avoid pos + length overflow.
571 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
572 (report_overlay_modification):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
575 Omit pointer cast, which isn't needed anyway, and doesn't work
576 after the EMACS_INT -> ptrdiff_t change.
577 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
578 * buffer.h: Adjust decls to match defn changes elsewhere.
579 (struct buffer_text, struct buffer):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 Use EMACS_INT, not int, where int might not be wide enough.
582 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
583 not int, to avoid needless 32-bit limit on 64-bit hosts.
584 (exec_byte_code): Use tighter memory-full test, one that checks
585 for alloca overflow. Don't compute the address of the object just
586 before an array, as that's not portable. Use EMACS_INT, not
587 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
588 * callint.c (Fcall_interactively):
589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
590 * callproc.c (call_process_kill, Fcall_process):
591 Don't assume pid_t fits into an Emacs fixnum.
592 (call_process_cleanup, Fcall_process, child_setup):
593 Don't assume pid_t fits into int.
594 (call_process_cleanup, Fcall_process, delete_temp_file)
595 (Fcall_process_region):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 (Fcall_process): Simplify handling of volatile integers.
598 Use int, not EMACS_INT, where int will do.
599 * casefiddle.c (casify_object, casify_region, operate_on_word)
600 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (casify_object): Avoid integer overflow when overallocating buffer.
603 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
604 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
605 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
606 * category.h (CATEGORYP): Don't assume arg is nonnegative.
607 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
608 integers are now checked earlier. All uses replaced with XINT.
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 For CCL_MapSingle, check that content and value are in int range.
612 (ccl_driver, Fregister_code_conversion_map):
613 Check that Vcode_version_map_vector is a vector.
614 (resolve_symbol_ccl_program): Check that vector header is in range.
615 Always copy the vector, so that we can check its contents reliably
616 now rather than having to recheck each instruction as it's being
617 executed. Check that vector words fit in 'int'.
618 (ccl_get_compiled_code, Fregister_ccl_program)
619 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
620 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
621 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
622 contents are in range.
623 (Fccl_execute_on_string): Check that status is in range.
624 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
625 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
626 Accept and return EMACS_INT, not int, because callers can pass values
628 (c_string_width, strwidth, lisp_string_width, chars_in_text)
629 (multibyte_chars_in_text, parse_str_as_multibyte)
630 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
631 (str_as_unibyte, str_to_unibyte, string_count_byte8)
632 (string_escape_byte8, Fget_byte):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
635 avoid mishandling large integers.
636 * character.h: Adjust decls to match defn changes elsewhere.
637 * charset.c (load_charset_map_from_file, find_charsets_in_text)
638 (Ffind_charset_region):
639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
640 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
641 (load_charset_map_from_vector, Fdefine_charset_internal):
642 Don't assume fixnum fits in int.
643 (load_charset_map_from_vector, Fmap_charset_chars):
644 Remove now-unnecessary CHECK_NATNUMs.
645 (Fdefine_charset_internal): Check ranges here, more carefully.
646 Don't rely on undefined behavior with signed left shift overflow.
647 Don't assume unsigned int fits into fixnum, or that fixnum fits
648 into unsigned int. Don't require max_code to be a valid fixnum;
649 that's not true for gb10830 4-byte on a 32-bit host. Allow
650 invalid_code to be a cons, for the same reason. Require code_offset
651 to be a character. Avoid int overflow if max_char is close
653 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
654 this is intended anyway and avoids some undefined behavior.
655 (load_charset_map): Pass unsigned, not int, as 2nd arg of
656 INDEX_TO_CODE_POINT, as that's what it expects.
657 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
658 * charset.h (DECODE_CHAR): Return int, not unsigned;
659 this is what was intended anyway, and it avoids undefined behavior.
660 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
661 integer-overflow issues.
662 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
663 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
664 where the argument is EMACS_INT, and this behavior is not intended.
665 * chartab.c (Fmake_char_table, Fset_char_table_range)
666 (uniprop_get_decoder, uniprop_get_encoder):
667 Don't assume fixnum fits in int.
668 * cmds.c (move_point): New function, that does the gist of
669 Fforward_char and Fbackward_char, but does so while checking
670 for integer overflow more accurately.
671 (Fforward_char, Fbackward_char): Use it.
672 (Fforward_line, Fend_of_line, internal_self_insert)
673 (internal_self_insert):
674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
675 Fix a FIXME, by checking for integer overflow when calculating
676 target_clm and actual_clm.
677 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
678 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
679 (ASSURE_DESTINATION, coding_alloc_by_realloc)
680 (coding_alloc_by_making_gap, alloc_destination)
681 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
682 (encode_coding_utf_16, detect_coding_emacs_mule)
683 (decode_coding_emacs_mule, encode_coding_emacs_mule)
684 (detect_coding_iso_2022, decode_coding_iso_2022)
685 (encode_invocation_designation, encode_designation_at_bol)
686 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
687 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
688 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
689 (encode_coding_ccl, encode_coding_raw_text)
690 (detect_coding_charset, decode_coding_charset)
691 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
692 (produce_composition, produce_charset, produce_annotation)
693 (decode_coding, handle_composition_annotation)
694 (handle_charset_annotation, consume_chars, decode_coding_gap)
695 (decode_coding_object, encode_coding_object, detect_coding_system)
696 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
697 (code_convert_region, code_convert_string)
698 (Fdefine_coding_system_internal)
699 (coding_set_source, coding_set_destination):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
702 (Fdefine_coding_system_internal):
703 Don't assume fixnums fit in int.
704 (decode_coding_gap, decode_coding_object, encode_coding_object)
705 (Fread_coding_system, Fdetect_coding_region)
706 (Funencodable_char_position, Fcheck_coding_systems_region)
707 (get_translation, handle_composition_annotation, consume_chars):
708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
709 (consume_chars): Rewrite to not calculate an address outside buffer.
710 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
711 Don't access memory outside of the args array.
712 (Fdefine_coding_system_internal): Check for charset-id overflow.
713 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
714 result of ENCODE_CHAR.
715 * coding.h: Adjust decls to match defn changes elsewhere.
716 (struct coding_system):
717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
718 * composite.c (get_composition_id, find_composition)
719 (run_composition_function, update_compositions)
720 (compose_text, composition_gstring_put_cache)
721 (composition_gstring_p, composition_gstring_width)
722 (fill_gstring_header, fill_gstring_body, autocmp_chars)
723 (composition_compute_stop_pos, composition_reseat_it)
724 (composition_update_it, struct position_record)
725 (find_automatic_composition, composition_adjust_point)
726 (Fcomposition_get_gstring, Ffind_composition_internal):
727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
728 (update_compositions):
729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
730 * composite.h: Adjust decls to match defn changes elsewhere.
731 (struct composition):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
734 Do not attempt to compute the address of the object just before a
735 buffer; this is not portable.
737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
738 (Faset): Use int, not EMACS_INT, where int is wide enough.
739 (Fstring_to_number): Don't assume fixnums fit in int.
740 (Frem): Don't assume arg is nonnegative.
741 * dbusbind.c (xd_append_arg): Check for integers out of range.
742 (Fdbus_call_method): Don't overflow the timeout int.
743 (extract_signed, extract_unsigned): New functions.
744 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
745 (xd_get_connection_references): Return ptrdiff_t, not int.
747 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
749 Use int, not unsigned, where the dbus API uses int.
750 (Fdbus_message_internal): Don't overflow mtype.
751 (syms_of_dbusbind): Allocate right-sized buffer for integers.
752 * dired.c (directory_files_internal, file_name_completion, scmp)
753 (file_name_completion_stat):
754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
755 (file_name_completion): Don't overflow matchcount.
756 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
757 * dispextern.h: Adjust decls to match defn changes elsewhere.
758 (struct text_pos, struct glyph, struct bidi_saved_info)
759 (struct bidi_string_data, struct bidi_it, struct composition_it)
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (struct display_pos, struct composition_it, struct it):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * dispnew.c (increment_matrix_positions)
765 (increment_row_positions, mode_line_string)
766 (marginal_area_string):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
770 (duration_to_sec_usec): New function, to check for overflow better.
771 (Fsleep_for, sit_for): Use it.
772 * doc.c (get_doc_string, store_function_docstring):
773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
774 (get_doc_string, Fsnarf_documentation):
775 Use int, not EMACS_INT, where int is wide enough.
777 Use SAFE_ALLOCA, not alloca.
778 Check for overflow when converting EMACS_INT to off_t.
780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
781 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
782 Don't assume uid_t fits into fixnum.
783 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
784 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
785 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
786 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
787 (general_insert_function)
788 (Finsert_char, make_buffer_string, make_buffer_string_both)
789 (update_buffer_properties, Fbuffer_substring)
790 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
791 (Fsubst_char_in_region, check_translation)
792 (Ftranslate_region_internal, save_restriction_restore, Fformat)
793 (transpose_markers, Ftranspose_regions):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 (clip_to_bounds): Move to lisp.h as an inline function).
796 (Fconstrain_to_field): Don't assume integers are nonnegative.
797 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
798 (Fsubst_char_in_region, Fsave_restriction):
799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
800 (Femacs_pid): Don't assume pid_t fits into fixnum.
801 (lo_time): Use int, not EMACS_INT, when int suffices.
802 (lisp_time_argument): Check for usec out of range.
803 (Fencode_time): Don't assume fixnum fits in int.
804 (Fuser_login_name, Fuser_full_name): Signal an error
805 if a uid argument is out of range, rather than relying on
807 (Fformat_time_string): Remove now-unnecessary check.
808 lisp_time_argument checks for out-of-range usec now.
809 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
810 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
811 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
812 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
813 (init_cmdargs, Fdump_emacs):
814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
815 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
816 the bottom (typically) 32 bits of the fixnum.
817 * eval.c (specpdl_size, call_debugger):
818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
819 (when_entered_debugger, Fbacktrace_debug):
820 Don't assume fixnum can fit in int.
821 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
822 the object just before a buffer; this is not portable.
823 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
824 (grow_specpdl, unbind_to):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
827 (grow_specpdl): Simplify allocation by using xpalloc.
828 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
829 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
830 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
832 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
835 (Fcopy_file, non_regular_nbytes, read_non_regular)
836 (Finsert_file_contents):
837 Use int, not EMACS_INT, where int is wide enough.
838 (READ_BUF_SIZE): Verify that it fits in int.
839 (Finsert_file_contents): Check that counts are in proper range,
840 rather than assuming fixnums fit into ptrdiff_t etc.
841 Don't assume fixnums fit into int.
842 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
843 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
844 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
845 (string_char_to_byte, string_byte_to_char)
846 (string_make_multibyte, string_to_multibyte)
847 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
848 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
849 (substring_both, Fdelete, internal_equal, Ffillarray)
850 (Fclear_string, mapcar1)
851 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
852 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
853 (larger_vector, make_hash_table, maybe_resize_hash_table)
854 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
855 (Fmaphash, secure_hash):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
857 (concat): Check for string index and length overflow.
858 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
861 (larger_vector): New API (vec, incr_min, size_max) replaces old
862 one (vec, new_size, init). This catches size overflow.
863 INIT was removed because it was always Qnil.
865 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
866 the upper bound on a hash table index size.
867 (make_hash_table, maybe_resize_hash_table): Use it.
868 (secure_hash): Computer start_byte and end_byte only after
869 they're known to be in ptrdiff_t range.
870 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
871 (Ffont_get_glyphs, Ffont_at):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
874 (Flist_fonts, Fopen_font):
875 Don't assume fixnum can fit in int.
876 (check_gstring): Don't assume index can fit in int.
877 (font_match_p): Check that fixnum is a character, not a nonnegative
878 fixnum, since the later code needs to stuff it into an int.
879 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
880 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
881 conversion overflow issues.
882 (Fopen_font): Check for integer out of range.
883 (Ffont_get_glyphs): Don't assume index can fit in int.
884 * font.h: Adjust decls to match defn changes elsewhere.
885 * fontset.c (reorder_font_vector): Redo score calculation to avoid
887 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
888 printmax_t, where ptrdiff_t is wide enough.
889 (Finternal_char_font):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
892 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
893 (Fset_frame_position, x_set_frame_parameters)
894 (x_set_line_spacing, x_set_border_width)
895 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
896 Check that fixnums are in proper range for system types.
897 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
899 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
900 Use SAFE_ALLOCA_LISP, not alloca.
901 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
902 intptr_t is wide enough.
903 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
904 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
905 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
906 Check for fixnum out of range.
907 * ftfont.c (ftfont_list): Don't assume index fits in int.
908 Check that fixnums are in proper range for system types.
909 (ftfont_shape_by_flt):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
913 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
914 Check that fixnums are in proper range for system types.
915 * gnutls.h: Adjust decls to match defn changes elsewhere.
916 * gtkutil.c (xg_dialog_run):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (update_frame_tool_bar):
919 Check that fixnums are in proper range for system types.
920 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
921 (lookup_image): Check that fixnums are in range for system types.
922 * indent.c (last_known_column, last_known_column_point):
923 (current_column_bol_cache):
924 (skip_invisible, current_column, check_display_width):
925 (check_display_width, scan_for_column, current_column_1)
926 (Findent_to, Fcurrent_indentation, position_indentation)
927 (indented_beyond_p, Fmove_to_column, compute_motion):
928 (Fcompute_motion, Fvertical_motion):
929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
930 (last_known_column_modified): Use EMACS_INT, not int.
931 (check_display_width):
933 Check that fixnums and floats are in proper range for system types.
934 (compute_motion): Don't assume index or fixnum fits in int.
935 (compute_motion, Fcompute_motion):
936 Use int, not EMACS_INT, when it is wide enough.
937 (vmotion): Omit local var start_hpos that is always 0; that way
938 we don't need to worry about overflow in expressions involving it.
939 * indent.h: Adjust decls to match defn changes elsewhere.
941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
942 Use int, not EMACS_INT, where int is wide enough.
943 Remove unused members ovstring_chars_done and tab_offset;
945 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
946 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
947 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
948 (make_gap, copy_text, insert, insert_and_inherit)
949 (insert_before_markers, insert_before_markers_and_inherit)
950 (insert_1, count_combining_before, count_combining_after)
951 (insert_1_both, insert_from_string)
952 (insert_from_string_before_markers, insert_from_string_1)
953 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
954 (adjust_after_replace, adjust_after_insert, replace_range)
955 (replace_range_2, del_range, del_range_1, del_range_byte)
956 (del_range_both, del_range_2, modify_region)
957 (prepare_to_modify_buffer, signal_before_change)
958 (signal_after_change, Fcombine_after_change_execute):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 * intervals.c (traverse_intervals, rotate_right, rotate_left)
961 (balance_an_interval, split_interval_right, split_interval_left)
962 (find_interval, next_interval, update_interval)
963 (adjust_intervals_for_insertion, delete_node, delete_interval)
964 (interval_deletion_adjustment, adjust_intervals_for_deletion)
965 (static_offset_intervals, offset_intervals)
966 (merge_interval_right, merge_interval_left, make_new_interval)
967 (graft_intervals_into_buffer, temp_set_point_both)
968 (temp_set_point, set_point, adjust_for_invis_intang)
969 (set_point_both, move_if_not_intangible, get_property_and_range)
970 (get_local_map, copy_intervals, copy_intervals_to_string)
971 (compare_string_intervals, set_intervals_multibyte_1):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 * intervals.h: Adjust decls to match defn changes elsewhere.
975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
976 * keyboard.c (this_command_key_count, this_single_command_key_start)
977 (before_command_key_count, before_command_echo_length, echo_now)
978 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
979 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
980 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
981 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
983 (last_non_minibuf_size, last_point_position, echo_truncate)
984 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
985 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
986 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
987 (stuff_buffered_input):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
989 (last_auto_save, command_loop_1, read_char):
990 Use EMACS_INT, not int, to avoid integer overflow.
991 (record_char): Avoid overflow in total_keys computation.
992 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
993 * keyboard.h: Adjust decls to match defn changes elsewhere.
994 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
995 (Fkey_description, Fdescribe_vector, Flookup_key):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 (click_position): New function, to check that positions are in range.
998 (Fcurrent_active_maps):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (Faccessible_keymaps, Fkey_description):
1002 (preferred_sequence_p):
1003 Don't assume fixnum can fit into int.
1004 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1005 Check for integer overflow in size calculations.
1006 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1007 avoid mishandling large integers.
1008 * lisp.h: Adjust decls to match defn changes elsewhere.
1009 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1010 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1011 (struct Lisp_Marker):
1012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1013 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1014 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1015 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1016 All callers changed.
1017 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1018 Assume the arg has valid form, since it always does.
1019 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1020 unsigned integer system type.
1021 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1022 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1024 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1025 (duration_to_sec_usec): New decl.
1026 * lread.c (read_from_string_index, read_from_string_index_byte)
1027 (read_from_string_limit, readchar, unreadchar, openp)
1028 (read_internal_start, read1, oblookup):
1029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1030 (Fload, readevalloop, Feval_buffer, Feval_region):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 (openp): Check for out-of-range argument to 'access'.
1033 (read1): Use int, not EMACS_INT, where int is wide enough.
1034 Don't assume fixnum fits into int.
1035 Fix off-by-one error that can read outside a buffer.
1036 (read_filtered_event): Use duration_to_sec_usec
1037 to do proper overflow checking on durations.
1038 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1039 in size calculation.
1040 (Fexecute_kbd_macro):
1041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1043 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1044 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1045 (set_marker_both, set_marker_restricted_both, marker_position)
1046 (marker_byte_position, Fbuffer_has_markers_at):
1047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1048 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1049 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1050 It now merely ensures that the menu is large enough, without
1051 necessarily growing it, as this avoids some integer overflow issues.
1052 All callers changed.
1053 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1055 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1056 Use SAFE_ALLOCA_LISP, not alloca.
1057 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1058 to EMACS_INT. Check that fixnums are in proper range for system types.
1059 * minibuf.c (minibuf_prompt_width, string_to_object)
1060 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1061 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1063 (get_minibuffer, read_minibuf_unwind):
1064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1065 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1066 this simplifies overflow checking. All callers changed.
1067 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1070 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1071 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1072 Check that fixnums are in proper range for system types.
1073 (Fx_create_frame, Fx_show_tip):
1074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1075 * nsfont.m (ns_findfonts, nsfont_list_family):
1076 Don't assume fixnum fits in long.
1077 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1081 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1083 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1084 (PRINTDECLARE, PRINTPREPARE):
1085 (strout, print_string):
1086 (print, print_preprocess, print_check_string_charset_prop)
1088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1090 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1092 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1093 (printchar, strout): Use xpalloc to catch size calculation overflow.
1094 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1095 (print_error_message): Use SAFE_ALLOCA, not alloca.
1096 (print_object): Use int, not EMACS_INT, where int is wide enough.
1097 (print_depth, new_backquote_output, print_number_index):
1098 Use ptrdiff_t, not int, where int might not be wide enough.
1099 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1100 (Fset_process_window_size, Fformat_network_address)
1101 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1103 Check that fixnums are in proper range for system types.
1104 (Fsignal_process): Simplify by avoiding a goto.
1105 Check for process-ids out of pid_t range rather than relying on
1107 (process_tick, update_tick): Use EMACS_INT, not int.
1108 (Fformat_network_address, read_process_output, send_process)
1109 (Fprocess_send_region, status_notify):
1110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1111 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1112 (wait_reading_process_output, read_process_output, exec_sentinel):
1113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1114 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1115 (Faccept_process_output): Use duration_to_sec_usec to do proper
1116 overflow checking on durations.
1117 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1118 Don't assume pid_t fits in int.
1119 * process.h (struct Lisp_Process): Members tick and update_tick
1120 are now of type EMACS_INT, not int.
1121 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1122 configured --with-wide-int.
1123 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1124 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1125 * search.c (looking_at_1, string_match_1):
1126 (fast_string_match, fast_c_string_match_ignore_case)
1127 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1128 (scan_newline, find_before_next_newline, search_command)
1129 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1130 (set_search_regs, wordify):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 (string_match_1, search_buffer, set_search_regs):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 (wordify): Check for overflow in size calculation.
1138 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1139 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1140 Check that fixnums are in proper range for system types.
1141 * sound.c (struct sound_device)
1142 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1144 (Fplay_sound_internal):
1145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1146 * syntax.c (struct lisp_parse_state, find_start_modiff)
1147 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1148 (Fparse_partial_sexp):
1149 Don't assume fixnums can fit in int.
1150 (struct lisp_parse_state, find_start_pos, find_start_value)
1151 (find_start_value_byte, find_start_begv)
1152 (update_syntax_table, char_quoted, dec_bytepos)
1153 (find_defun_start, prev_char_comend_first, back_comment):
1154 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1155 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1157 (Finternal_describe_syntax_value): Check that match_lisp is a
1158 character, not an integer, since the code stuffs it into int.
1159 (scan_words, scan_sexps_forward):
1160 Check that fixnums are in proper range for system types.
1162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1163 (scan_sexps_forward):
1164 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1165 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1166 * syntax.h: Adjust decls to match defn changes elsewhere.
1167 (struct gl_state_s):
1168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1169 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1170 MOST_POSITIVE_FIXNUM.
1171 * sysdep.c (wait_for_termination_1, wait_for_termination)
1172 (interruptible_wait_for_termination, mkdir):
1173 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1174 (emacs_read, emacs_write):
1175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1176 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1177 and double all fit in int.
1178 * term.c (set_tty_color_mode):
1179 Check that fixnums are in proper range for system types.
1180 * termhooks.h (struct input_event):
1181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1182 * textprop.c (validate_interval_range, interval_of)
1183 (Fadd_text_properties, set_text_properties_1)
1184 (Fremove_text_properties, Fremove_list_of_text_properties)
1185 (Ftext_property_any, Ftext_property_not_all)
1186 (copy_text_properties, text_property_list, extend_property_ranges)
1187 (verify_interval_modification):
1188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1189 (Fnext_single_char_property_change)
1190 (Fprevious_single_char_property_change):
1191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1192 (copy_text_properties):
1193 Check for integer overflow in index calculation.
1194 * undo.c (last_boundary_position, record_point, record_insert)
1195 (record_delete, record_marker_adjustment, record_change)
1196 (record_property_change):
1197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1198 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1201 (Fx_hide_tip, Fx_file_dialog):
1202 * w32menu.c (set_frame_menubar):
1203 Use ptrdiff_t, not int, for consistency with rest of code.
1204 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1205 (select_window, Fdelete_other_windows_internal)
1206 (window_scroll_pixel_based, window_scroll_line_based)
1207 (Frecenter, Fset_window_configuration):
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1209 (Fset_window_hscroll, run_window_configuration_change_hook)
1210 (set_window_buffer, temp_output_buffer_show, scroll_command)
1211 (Fscroll_other_window, Frecenter):
1212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1213 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1214 Don't assume fixnum fits in int.
1215 (Fset_window_scroll_bars):
1216 Check that fixnums are in proper range for system types.
1217 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1218 (string_pos, c_string_pos, number_of_chars, init_iterator)
1219 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1220 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1221 (compute_display_string_end, handle_face_prop)
1222 (face_before_or_after_it_pos, handle_invisible_prop)
1223 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1224 (display_prop_intangible_p, string_buffer_position_lim)
1225 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1226 (get_overlay_strings_1, get_overlay_strings)
1227 (iterate_out_of_display_property, forward_to_next_line_start)
1228 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1229 (get_next_display_element, set_iterator_to_next)
1230 (get_visually_first_element, compute_stop_pos_backwards)
1231 (handle_stop_backwards, next_element_from_buffer)
1232 (move_it_in_display_line_to, move_it_in_display_line)
1233 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1234 (add_to_log, message_dolog, message_log_check_duplicate)
1235 (message2, message2_nolog, message3, message3_nolog
1236 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1237 (current_message_1, truncate_echo_area, truncate_message_1)
1238 (set_message, set_message_1, store_mode_line_noprop)
1239 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1240 (text_outside_line_unchanged_p, check_point_in_composition)
1241 (reconsider_clip_changes)
1242 (redisplay_internal, set_cursor_from_row, try_scrolling)
1243 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1244 (redisplay_window, find_last_unchanged_at_beg_row)
1245 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1246 (trailing_whitespace_p, find_row_edges, display_line)
1247 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1248 (display_mode_element, store_mode_line_string)
1249 (pint2str, pint2hrstr, decode_mode_spec)
1250 (display_count_lines, display_string, draw_glyphs)
1251 (x_produce_glyphs, x_insert_glyphs)
1252 (rows_from_pos_range, mouse_face_from_buffer_pos)
1253 (fast_find_string_pos, mouse_face_from_string_pos)
1254 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1256 (safe_call, init_from_display_pos, handle_fontified_prop)
1257 (handle_single_display_spec, load_overlay_strings)
1258 (with_echo_area_buffer, setup_echo_area_for_printing)
1259 (display_echo_area, echo_area_display)
1260 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1261 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1262 (redisplay_window, dump_glyph_row, display_mode_line)
1263 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1264 (handle_display_spec, display_prop_string_p):
1265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1266 (handle_single_display_spec, build_desired_tool_bar_string)
1267 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1268 (get_specified_cursor_type):
1269 Check that fixnums are in proper range for system types.
1270 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1271 (Flookup_image_map):
1272 Don't assume fixnums fit in int.
1273 (compare_overlay_entries):
1274 Avoid mishandling comparisons due to subtraction overflow.
1275 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1276 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1277 (handle_tool_bar_click):
1278 Use int, not unsigned, since we prefer signed and the signedness
1279 doesn't matter here.
1280 (get_next_display_element, next_element_from_display_vector):
1281 Use int, not EMACS_INT, when int is wide enough.
1282 (start_hourglass): Use duration_to_sec_usec to do proper
1283 overflow checking on durations.
1284 * xfaces.c (Fbitmap_spec_p):
1285 Check that fixnums are in proper range for system types.
1286 (compare_fonts_by_sort_order):
1287 Avoid mishandling comparisons due to subtraction overflow.
1288 (Fx_family_fonts, realize_basic_faces):
1289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1291 Don't assume fixnum fits in int.
1292 Use SAFE_ALLOCA_LISP, not alloca.
1293 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1294 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1295 (face_at_buffer_position, face_for_overlay_string)
1296 (face_at_string_position):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1299 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1301 Check that fixnums are in proper range for system types.
1302 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1303 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1305 (Fx_change_window_property): Don't assume fixnums fit in int.
1306 * xfont.c (xfont_chars_supported):
1307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1308 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1309 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1311 * xml.c (parse_region):
1312 * xrdb.c (magic_file_p):
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1315 (x_get_local_selection, x_reply_selection_request)
1316 (x_handle_selection_request, wait_for_property_change):
1317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1318 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1319 short is wide enough.
1320 (x_send_client_event): Don't assume fixnum fits in int.
1321 * xterm.c (x_x_to_emacs_modifiers):
1322 Don't assume EMACS_INT overflows nicely into int.
1323 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1325 (handle_one_xevent): NATNUMP can eval its arg twice.
1326 (x_connection_closed):
1327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1328 * xterm.h: Adjust decls to match defn changes elsewhere.
1329 (struct scroll_bar): Use struct vectorlike_header
1330 rather than rolling our own approximation.
1331 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1333 2012-05-25 Glenn Morris <rgm@gnu.org>
1335 * lisp.mk (lisp): Update for more files being compiled now.
1337 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1339 * lread.c: Remove `read_pure' which makes no difference.
1340 (read_pure): Remove var.
1341 (unreadpure): Remove function.
1342 (readevalloop): Don't call read_list with -1 flag.
1343 (read1, read_vector): Don't test read_pure any more.
1344 (read_list): Simplify.
1346 * fileio.c, character.h: Minor style tweaks.
1348 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1350 * window.h (clip_changed): Remove useless declaration.
1352 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1354 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1355 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1357 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1360 This directory predates autoconf and is no longer needed nowadays.
1361 Move its few remaining bits of functionality to where they're needed.
1362 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1363 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1364 * m/template.h: Remove.
1365 * Makefile.in (M_FILE): Remove. All uses removed.
1366 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1367 * lisp.h (USE_LSB_TAG):
1368 * mem-limits.h (EXCEEDS_LISP_PTR):
1369 Use VAL_MAX, not VALBITS, in #if.
1370 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1371 (EMACS_UINT): Define unconditionally now.
1372 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1373 (BITS_PER_EMACS_INT): New constants, replacing
1374 what used to be in config.h, but not useful in #if.
1375 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1376 define them any more.
1377 (VAL_MAX): New macro.
1379 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1380 BITS_PER_EMACS_INT, in #if.
1381 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1382 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1383 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1384 * s/ms-w32.h (DATA_START):
1385 Move here from removed file m/intel386.h.
1386 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1387 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1389 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1391 Assume C89 or later.
1392 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1393 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1395 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1396 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1397 * textprop.c, tparam.c (NULL): Remove.
1398 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1399 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1400 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1401 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1402 * xterm.c (input_signal_count): Assume volatile works.
1404 2012-05-21 Ken Brown <kbrown@cornell.edu>
1406 * xgselect.c (xg_select): Fix first argument in call to 'select'
1409 2012-05-20 Ken Brown <kbrown@cornell.edu>
1411 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1412 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1414 2012-05-19 Ken Brown <kbrown@cornell.edu>
1416 * xfns.c (x_in_use): Remove `static' qualifier.
1417 * xterm.h (x_in_use): Declare.
1418 * xgselect.c: Include xterm.h.
1419 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1420 and `display_arg' (bug#9754).
1422 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1424 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1426 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1427 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1429 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1431 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1433 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1434 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1436 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1437 reference to image_cache->refcount.
1438 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1440 2012-05-17 Juri Linkov <juri@jurta.org>
1442 * search.c (Fword_search_regexp, Fword_search_backward)
1443 (Fword_search_forward, Fword_search_backward_lax)
1444 (Fword_search_forward_lax): Move functions to isearch.el
1445 (bug#10145, bug#11381).
1447 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1449 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1451 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1453 * lread.c (init_obarray): Declare Qt and Qnil as special.
1455 2012-05-14 Glenn Morris <rgm@gnu.org>
1457 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1458 Put "libexec" before "bin", for the sake of init_callproc_1.
1460 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1462 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1464 * unexaix.c: Port to more-recent AIX compilers.
1465 (report_error, report_error_1, make_hdr, copy_sym)
1466 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1467 Make arguments const char *, not char *, to avoid violations of C
1468 standard and to fix some AIX warnings reported by Gilles Pion.
1470 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1472 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1473 already have overlays loaded.
1474 (handle_single_display_spec): Before returning without displaying
1475 fringe bitmap, synchronize the bidi iterator with the main display
1476 iterator, by calling iterate_out_of_display_property.
1477 (iterate_out_of_display_property): Detect buffer iteration by
1478 testing that it->string is a Lisp string.
1479 (get_next_display_element): When the current object is exhausted,
1480 and there's something on it->stack, call set_iterator_to_next to
1481 proceed with what's on the stack, instead of returning zero.
1482 (set_iterator_to_next): If called at the end of a Lisp string,
1483 proceed to consider_string_end without incrementing string
1484 position. Don't increment display vector index past the end of
1485 the display vector. (Bug#11417)
1486 (pos_visible_p): Don't report a position visible when move_it_to
1487 stopped at the last line of window, which happens to be scanned
1488 backwards by the bidi iteration. (Bug#11464)
1490 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1492 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1493 and right-margin display specs even if the spec is invalid or we
1494 are on a TTY, and thus unable to display on the fringes.
1495 That's because the text with the property will not be displayed anyway,
1496 so we need to signal to the caller that this is a "replacing"
1497 display spec. This fixes display when the spec is invalid or we
1500 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1502 * unexaix.c (make_hdr): Fix typo in prototype.
1503 This bug broke the build on AIX. Problem reported by Gilles Pion.
1505 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1507 * keyboard.c (kbd_buffer_get_event): Read special events also in
1508 batch mode. (Bug#11415)
1510 2012-05-12 Glenn Morris <rgm@gnu.org>
1512 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1514 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1516 * lisp.mk (lisp): Add newcomment.elc.
1518 2012-05-12 Glenn Morris <rgm@gnu.org>
1520 * Makefile.in (MKDIR_P): New, set by configure.
1521 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1523 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1525 Remove unused function hourglass_started.
1526 * dispextern.h (hourglass_started):
1527 * w32fns.c (hourglass_started):
1528 * xdisp.c (hourglass_started): Remove.
1530 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1532 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1533 Update dependencies.
1535 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1537 * xgselect.c (xg_select): Put maxfds+1 into a var.
1538 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1540 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1542 2012-05-10 Dave Abrahams <dave@boostpro.com>
1544 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1545 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1547 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1549 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1550 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1551 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1552 Initialize xd_registered_buses.
1554 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1556 Untag more efficiently if USE_LSB_TAG.
1557 This is based on a proposal by YAMAMOTO Mitsuharu in
1558 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1559 For an admittedly artificial (nth 8000 longlist) benchmark on
1560 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1561 Emacs's overall text size by 1%.
1562 * lisp.h (XUNTAG): New macro.
1563 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1564 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1565 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1566 * eval.c (Fautoload):
1567 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1568 * frame.h (XFRAME): Use XUNTAG.
1570 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1571 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1572 Remove unportable assumptions about print widths of types like
1574 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1575 intptr_t when converting between pointer and integer, to avoid GCC
1576 warnings about wrong width.
1578 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1580 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1581 stack for each reader_thread, instead of defaulting to 8MB
1582 determined by the linker. This avoids failures in creating
1583 subprocesses on Windows 7, see the discussion in this thread:
1584 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1586 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1588 Fix up display of the *Minibuf-0* buffer in the mini window.
1589 * keyboard.c (read_char): Don't clear the echo area if there's no
1591 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1592 contents of *Minibuf-0*) if there's no message displayed in its stead.
1594 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1596 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1599 2012-05-06 Chong Yidong <cyd@gnu.org>
1601 * lisp.mk (lisp): Update.
1603 2012-05-05 Jim Meyering <meyering@redhat.com>
1605 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1607 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1609 * data.c (PUT_ERROR): New macro.
1610 (syms_of_data): Use it. Add new error type `user-error'.
1611 * undo.c (user_error): New function.
1612 (Fprimitive_undo): Use it.
1613 * print.c (print_error_message): Adjust print style for `user-error'.
1614 * keyboard.c (user_error): New function.
1615 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1617 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1619 Do not limit current-time-string to years 1000..9999.
1620 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1621 (Fcurrent_time_string): Support any year that is supported by the
1622 underlying localtime representation. Don't use asctime, as it
1623 has undefined behavior for years outside the range -999..9999.
1625 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1627 Fix race conditions involving setenv, gmtime, localtime, asctime.
1628 Without this fix, interrupts could mess up code that uses these
1629 nonreentrant functions, since setting TZ invalidates existing
1630 tm_zone or tzname values, and since most of these functions return
1631 pointers to static storage.
1632 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1633 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1634 Grow the critical sections to include not just invoking
1635 localtime/gmtime, but also accessing these functions' results
1636 including their tm_zone values if any, and any related TZ setting.
1637 (format_time_string): Last arg is now struct tm *, not struct tm **,
1638 so that the struct tm is saved in the critical section.
1639 All callers changed. Simplify allocation of initial buffer, partly
1640 motivated by the fact that memory allocation needs to be outside
1641 the critical section.
1643 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1645 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1646 with RESET_INTERVAL.
1648 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1649 Remove duplicated buffer name initialization.
1651 2012-05-02 Jim Meyering <jim@meyering.net>
1653 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1655 * xfns.c (x_window): Use xstrdup (Bug#11375).
1657 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1659 * xdisp.c (pos_visible_p): If already at a newline from the
1660 display string before the 'while' loop, don't walk back the glyphs
1661 from it3.glyph_row. Solves assertion violation when the display
1662 string begins with a newline (egg.el). (Bug#11367)
1664 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1666 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1669 2012-05-01 Glenn Morris <rgm@gnu.org>
1671 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1672 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1673 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1674 All were removed before 23.1.
1676 * dispnew.c: Remove HAVE_LIBNCURSES test;
1677 it is always true on relevant platforms.
1679 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1680 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1682 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1684 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1686 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1687 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1690 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1692 Do not avoid creating empty evaporating overlays (Bug#9642).
1693 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1694 That is, do not delete an evaporating overlay if it becomes
1695 empty after its bounds are adjusted to fit within its buffer.
1696 This fix caused other problems, and I'm reverting it until we get
1697 to the bottom of them.
1699 2012-04-27 Chong Yidong <cyd@gnu.org>
1701 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1703 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1705 * xdisp.c (pos_visible_p): If the window start position is beyond
1706 ZV, start the display from buffer beginning. Prevents assertion
1707 violation in init_iterator when the minibuffer window is scrolled
1710 * window.c (window_scroll_pixel_based): Likewise.
1712 2012-04-27 Chong Yidong <cyd@gnu.org>
1714 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1716 2012-04-27 Glenn Morris <rgm@gnu.org>
1718 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1719 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1721 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1723 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1724 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1726 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1728 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1729 display element, check also the underlying string or buffer
1730 character. (Bug#11341)
1732 * w32menu.c: Include w32heap.h.
1733 (add_menu_item): If the call to AppendMenuW (via
1734 unicode_append_menu) fails, disable Unicode menus only if we are
1735 running on Windows 9X/Me.
1737 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1739 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1740 (xgetint): Add missing shift for LSB tags.
1742 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1744 * keyboard.c (read_char): Don't wipe echo area for select window
1745 events: These might get delayed via `mouse-autoselect-window'
1748 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1750 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1751 manipulation of :loaded-from data.
1753 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1755 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1756 now a cons (bug#11311).
1758 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1760 Do not create empty overlays with the evaporate property (Bug#9642).
1761 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1762 if it becomes empty after its bounds are adjusted to fit within
1763 its buffer. Without this fix, in a nonempty buffer (let ((o
1764 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1765 yields an empty overlay that has the evaporate property, which is
1766 not supposed to happen.
1768 Fix minor GTK3 problems found by static checking.
1769 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1770 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1771 (struct _EmacsFixedClass, emacs_fixed_get_type):
1772 Move decls here from emacsgtkfixed.h, since they needn't be public.
1773 (emacs_fixed_get_type): Now static.
1774 (emacs_fixed_class_init): Omit unused local.
1775 (emacs_fixed_child_type): Remove; unused.
1776 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1777 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1778 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1779 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1780 (EMACS_FIXED_GET_CLASS): Remove; unused.
1781 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1783 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1784 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1786 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1788 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1789 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1790 (__malloc_size_t, __malloc_ptrdiff_t):
1791 Remove. All uses removed, replaced by the definiens if needed,
1792 since we can assume C89 or better now.
1793 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1794 (protect_malloc_state, align, get_contiguous_space)
1795 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1796 (malloc_atfork_handler_child, malloc_enable_thread)
1797 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1798 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1799 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1800 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1801 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1802 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1803 Define using prototypes, not old style.
1804 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1805 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1806 (align): Don't assume that signed integer overflow wraps around.
1807 Omit unused local var.
1808 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1809 (_free_internal_nolock, memalign, mallochook, reallochook):
1810 Omit no-longer-needed casts.
1811 (valloc): Use getpagesize, not __getpagesize.
1812 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1813 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1815 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1817 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1819 Move functions from C to Lisp. Make non-blocking method calls
1820 the default. Implement further D-Bus standard interfaces.
1822 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1823 (QCdbus_request_name_allow_replacement)
1824 (QCdbus_request_name_replace_existing)
1825 (QCdbus_request_name_do_not_queue)
1826 (QCdbus_request_name_reply_primary_owner)
1827 (QCdbus_request_name_reply_in_queue)
1828 (QCdbus_request_name_reply_exists)
1829 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1830 (QCdbus_registered_serial, QCdbus_registered_method)
1831 (QCdbus_registered_signal): New Lisp objects.
1832 (XD_DEBUG_MESSAGE): Use sizeof.
1833 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1834 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1835 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1836 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1837 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1838 (xd_signature, xd_append_arg): Allow float for integer types.
1839 (xd_get_connection_references): New function.
1840 (xd_get_connection_address): Rename from xd_initialize.
1841 Return cached address.
1842 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1843 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1845 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1846 Return number of refcounts.
1847 (Fdbus_get_unique_name): Make stronger parameter check.
1848 (Fdbus_message_internal): New defun.
1849 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1850 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1851 (Fdbus_send_signal, Fdbus_register_service)
1852 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1853 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1854 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1855 (Vdbus_compiled_version, Vdbus_runtime_version)
1856 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1857 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1858 (Vdbus_message_type_signal): New defvars.
1859 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1862 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1864 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1865 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1866 Do not assume ptrdiff_t is the same width as 'int'.
1868 * alloc.c: Handle unusual debugging option combinations.
1869 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1870 since the two debugging options are incompatible.
1871 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1873 (mem_init, mem_insert, mem_insert_fixup):
1874 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1875 (NEED_MEM_INSERT): Remove; no longer needed.
1877 2012-04-22 Leo Liu <sdl.web@gmail.com>
1879 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1881 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1883 * sysdep.c [__FreeBSD__]: Minor cleanups.
1884 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1885 Use Emacs indenting style more consistently. Avoid some casts.
1886 Use 'double' consistently rather than mixing 'float' and 'double'.
1888 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1890 * sysdep.c (list_system_processes, system_process_attributes):
1891 Add implementation for FreeBSD (Bug#5243).
1893 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1895 * lisp.mk (lisp): Update.
1897 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1899 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1900 It is never used otherwise.
1902 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1904 * print.c (print_preprocess): Only check print_depth if print-circle
1906 (print_object): Check for cycles even when print-circle is nil and
1907 print-gensym is t, but only check print_depth if print-circle is nil.
1909 2012-04-20 Chong Yidong <cyd@gnu.org>
1911 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1912 set the status to "failed" and ensure that sentinel is run.
1914 2012-04-20 Glenn Morris <rgm@gnu.org>
1916 * process.c (Fset_process_inherit_coding_system_flag)
1917 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1918 (Fmake_network_process, Fmake_serial_process): Doc fix.
1920 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1922 * xdisp.c (string_buffer_position_lim): Limit starting position to
1924 (set_cursor_from_row): If called for a mode-line or header-line
1925 row, return zero immediately.
1926 (try_cursor_movement): If inside continuation line, don't back up
1927 farther than the first row after the header line, if any.
1928 Don't consider the header-line row as "partially visible", even if
1929 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1931 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1933 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1936 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1937 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1939 configure: new option --enable-gcc-warnings (Bug#11207)
1940 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1941 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1942 (ALL_CFLAGS): Use new macros rather than old.
1943 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1944 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1945 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1946 -Wunused-result, -Wunused-variable. This should go away once
1947 the Emacs and Gnulib regex code is merged.
1948 (xmalloc, xrealloc): Now static.
1950 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1952 * dired.c (Fsystem_groups): Remove unused local.
1954 2012-04-17 Glenn Morris <rgm@gnu.org>
1956 * dired.c (Fsystem_users): Doc fix.
1958 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1960 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1961 (syms_of_dired): Add them.
1963 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1965 Fix minor alloc.c problems found by static checking.
1966 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1967 New extern decls, to avoid calling undeclared functions.
1968 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1969 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1970 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1971 (NEED_MEM_INSERT): New macro.
1972 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1973 Remove one incorrect comment and fix another.
1975 Fix minor ralloc.c problems found by static checking.
1976 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1977 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1978 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1979 (r_alloc_sbrk): Now static.
1981 Improve ralloc.c interface checking.
1982 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1983 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1984 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1985 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1986 [REL_ALLOC]: ... to here, to check interface.
1987 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1988 Remove decls. This fixes an "It stinks!".
1990 * alloc.c (which_symbols): Fix alignment issue / type clash.
1992 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1994 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1995 (struct Lisp_Misc_Any): Likewise.
1996 (struct Lisp_Free): Likewise.
1997 * alloc.c (union aligned_Lisp_Symbol): Define.
1998 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1999 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2000 (union aligned_Lisp_Misc): Define.
2001 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2002 aligned_Lisp_Misc instead of union Lisp_Misc.
2003 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2005 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2007 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2008 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2009 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2010 * s/netbsd.h, s/sol2-6.h:
2011 Remove definition of GC_MARK_STACK, since the default now works.
2012 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2013 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2014 no longer the default.
2015 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2017 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2019 * lread.c (lisp_file_lexically_bound_p):
2020 Fix hang at ";-*-\n" (bug#11238).
2022 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2024 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2025 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2027 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2029 * nsterm.m (constrainFrameRect): Always constrain when there is only
2030 one screen (Bug#10962).
2032 2012-04-13 Ken Brown <kbrown@cornell.edu>
2034 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2036 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2038 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2040 2012-04-11 Daniel Colascione <dancol@dancol.org>
2042 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2043 against is gone. It's better to use vfork now so that when Cygwin
2044 gains a new, working vfork, we use it automatically (bug#10398).
2046 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2048 * window.c (save_window_save): Obey window-point-insertion-type.
2050 2012-04-11 Glenn Morris <rgm@gnu.org>
2052 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2054 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2056 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2058 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2060 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2061 (force_quit_count): New var.
2062 (handle_interrupt): Use it.
2064 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2066 * w32.c (w32_delayed_load): Record the full path of the library
2067 being loaded (bug#10424).
2069 2012-04-09 Glenn Morris <rgm@gnu.org>
2071 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2072 not just in the obarray, before snarfing them. (Bug#11036)
2074 * Makefile.in ($(leimdir)/leim-list.el):
2075 Pass EMACS rather than BUILT_EMACS.
2077 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2079 * process.c (make_process):
2080 * process.h: Add integer `gnutls_handshakes_tried' member to
2083 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2084 Add convenience `GNUTLS_LOG2i' macro.
2086 * gnutls.c (gnutls_log_function2i): Convenience log function.
2087 (emacs_gnutls_read): Use new log functions,
2088 `gnutls_handshakes_tried' process member, and
2089 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2090 attempts per process (connection).
2092 2012-04-09 Chong Yidong <cyd@gnu.org>
2094 * eval.c (Fuser_variable_p, user_variable_p_eh)
2095 (lisp_indirect_variable): Functions deleted.
2096 (Fdefvar): Caller changed.
2098 * callint.c (Finteractive, Fcall_interactively):
2099 * minibuf.c (Fread_variable): Callers changed.
2101 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (set_cursor_from_row): If the display string appears in
2104 the buffer at position that is closer to point than the position
2105 after the display string, display the cursor on the first glyph of
2106 the display string. Fixes cursor display when a 'display' text
2107 property immediately follows invisible text. (Bug#11094)
2109 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2111 composite.c: use 'double' consistently
2112 * composite.c (get_composition_id): Use 'double' consistently
2113 instead of converting 'float' to 'double' and vice versa; this is
2114 easier to understand and avoids a GCC warning.
2116 2012-04-09 Glenn Morris <rgm@gnu.org>
2118 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2119 preparation for dumping it with emacs. (Bug#4789)
2120 (leimdir): New variable.
2121 ($(leimdir)/leim-list.el): New rule.
2122 (emacs$(EXEEXT)): Depend on leim-list.el.
2124 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2125 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2126 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2128 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2130 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2133 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2135 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2136 Remove unused local variable.
2138 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2140 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2141 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2142 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2143 objects, as mark_maybe_pointer will catch them otherwise.
2144 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2145 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2147 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2149 Fix typo that broke non-Windows builds.
2150 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2152 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2154 Support building on MS-Windows with libxml2.
2156 * makefile.w32-in (OBJ2): Add xml.$(O).
2157 (GLOBAL_SOURCES): Add xml.c.
2158 ($(BLD)/xml.$(O)): New dependency list.
2160 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2161 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2162 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2163 [!WINDOWSNT]: New macros.
2164 (init_libxml2_functions, libxml2_loaded_p): New functions.
2165 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2166 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2167 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2168 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2170 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2171 Call init_libxml2_functions before calling libxml2 functions.
2172 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2174 * emacs.c: Don't include libxml/parser.h.
2175 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2176 xmlCleanupParser directly.
2178 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2180 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2182 * indent.c (Fvertical_motion): If there is a display string at
2183 point, use it.vpos to compute how many lines to backtrack after
2184 move_it_to point. (Bug#11133)
2186 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2188 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2189 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2190 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2191 macros related to unification of CJK characters. For the details,
2192 see the discussion following the message here:
2193 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2195 2012-04-04 Chong Yidong <cyd@gnu.org>
2197 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2199 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2201 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2202 instead of alloca. (Bug#11138)
2204 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2206 * w32menu.c (is_simple_dialog): Properly check lisp types.
2209 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2211 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2212 position we get to after a call to move_it_to fails the
2213 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2214 only if we wind up in a string from display property. (Bug#11063)
2216 * window.c (Fdelete_other_windows_internal): Invalidate the row
2217 and column information about mouse highlight, so that redisplay
2218 restores it after reallocating the glyph matrices. (Bug#7464)
2220 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2221 string comes from a `display' text property, use the buffer
2222 position of that property as if we actually saw that position in
2224 (move_it_by_lines): Remove the assertion that
2225 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2226 violated when there's a before-string at the beginning of a line.
2229 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2231 * xdisp.c (append_space_for_newline): If the default face was
2232 remapped, use the remapped face for the appended newline.
2233 (extend_face_to_end_of_line): Use the remapped default face for
2234 extending the face to the end of the line.
2235 (display_line): Call extend_face_to_end_of_line when the default
2236 face was remapped. (Bug#11068)
2238 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2240 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2242 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2244 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2246 2012-03-27 Glenn Morris <rgm@gnu.org>
2248 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2251 2012-03-26 Kenichi Handa <handa@m17n.org>
2253 * dispextern.h (struct glyph): Fix previous change. Change the
2254 bit length of glyphless.ch to 25 (Bug#11082).
2256 2012-03-26 Chong Yidong <cyd@gnu.org>
2258 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2259 (command_loop_1): Use it; inhibit selection update for
2260 handle-select-window too (Bug#8996).
2262 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2264 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2266 2012-03-25 Kenichi Handa <handa@m17n.org>
2268 * dispextern.h (struct glyph): Change the bit length of
2269 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2271 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2273 * s/ms-w32.h (tzname): Include time.h before redirecting to
2274 _tzname. Fixes the MSVC build. (Bug#9960)
2276 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2278 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2281 * xterm.c (XTread_socket): Only modify handling_signal if
2282 !SYNC_INPUT. (Bug#11080)
2284 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2286 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2287 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2288 when fetching a multibyte character consumes more bytes than
2289 CHAR_BYTES returns, due to unification of CJK characters in
2290 string_char. (Bug#11073)
2292 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2294 * process.c (wait_reading_process_output): Handle pty disconnect
2295 by refraining from sending oneself a SIGCHLD (bug#10933).
2297 2012-03-22 Chong Yidong <cyd@gnu.org>
2299 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2301 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2302 Mark string as coming from a prefix property.
2303 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2304 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2306 2012-03-21 Chong Yidong <cyd@gnu.org>
2308 * xfaces.c (Vface_remapping_alist): Doc fix.
2310 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2312 * w32proc.c (Fw32_set_console_codepage)
2313 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2316 2012-03-20 Chong Yidong <cyd@gnu.org>
2318 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2319 to reflect default non-nil value of redisplay-dont-pause.
2321 2012-03-19 Kenichi Handa <handa@m17n.org>
2323 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2324 it fit in a valid range (Bug#11003).
2326 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2328 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2329 that is not from display property, accept the row as a "cursor
2330 row" if one of the string's character has a non-nil `cursor'
2331 property. Fixes cursor positioning when there are newlines in
2332 overlay strings, e.g. in icomplete.el. (Bug#11035)
2334 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2336 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2338 2012-03-12 Chong Yidong <cyd@gnu.org>
2340 * eval.c (inhibit_lisp_code): Rename from
2341 inhibit_window_configuration_change_hook; move from window.c.
2343 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2344 * window.c (run_window_configuration_change_hook)
2345 (syms_of_window): Callers changed.
2347 2012-03-11 Chong Yidong <cyd@gnu.org>
2349 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2351 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2353 2012-03-10 Chong Yidong <cyd@gnu.org>
2355 * frame.c (other_visible_frames): Don't assume the selected frame
2356 is visible (Bug#10955).
2358 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2360 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2362 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2364 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2365 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2368 2012-03-03 Glenn Morris <rgm@gnu.org>
2370 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2372 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2374 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2375 position past the first glyph_row that ends at ZV. (Bug#10902)
2376 (redisplay_window, next_element_from_string): Fix typos in
2378 (redisplay_window): Pass to move_it_vertically the margin in
2379 pixels, not in screen lines.
2381 2012-03-02 Glenn Morris <rgm@gnu.org>
2383 * buffer.c (buffer-list-update-hook): Doc fix.
2385 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2388 push_it before setting up the iterator for the first overlay
2389 string, even if we have an empty string loaded.
2390 (next_overlay_string): If there's an empty string on the iterator
2391 stack, pop the stack. (Bug#10903)
2393 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2395 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2396 Suggested by Stefan Monnier in
2397 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2398 * alloc.c (widen_to_Lisp_Object): New static function.
2399 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2400 and widening them to Lisp_Objects. This would work even if
2401 USE_LSB_TAG is defined and wide integers are used, which might
2402 happen in a future version of Emacs.
2404 2012-02-25 Chong Yidong <cyd@gnu.org>
2406 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2409 * xselect.c (Fx_selection_exists_p): Doc fix.
2410 (x_clipboard_manager_save_all): Print an informative message
2411 before saving to clipboard manager.
2413 2012-02-24 Chong Yidong <cyd@gnu.org>
2415 * keyboard.c (process_special_events): Handle all X selection
2416 requests in kbd_buffer, not just the next one (Bug#8869).
2418 2012-02-23 Chong Yidong <cyd@gnu.org>
2420 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2421 call when setting menu-bar-lines and tool-bar-lines parameters.
2422 (unwind_create_frame_1): New helper function.
2424 * window.c (inhibit_window_configuration_change_hook): New var.
2425 (run_window_configuration_change_hook): Obey it.
2426 (syms_of_window): Initialize it.
2428 2012-02-22 Chong Yidong <cyd@gnu.org>
2430 * xterm.c (x_draw_image_relief): Add missing type check for
2431 Vtool_bar_button_margin (Bug#10743).
2433 2012-02-21 Chong Yidong <cyd@gnu.org>
2435 * fileio.c (Vfile_name_handler_alist): Doc fix.
2437 * buffer.c (Fget_file_buffer): Protect against invalid file
2438 handler return value.
2440 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2442 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2443 when computing $valmask.
2445 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2446 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2447 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2448 It's useless in that case, and it can cause problems on hosts
2449 that allocate halves of EMACS_INT values separately.
2450 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2451 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2452 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2453 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2454 it avoids undefined behavior on hosts where shifting right by more
2455 than the word width has undefined behavior.
2457 2012-02-19 Chong Yidong <cyd@gnu.org>
2459 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2460 (Funhandled_file_name_directory, Ffile_name_as_directory)
2461 (Fdirectory_file_name, Fexpand_file_name)
2462 (Fsubstitute_in_file_name): Protect against invalid file handler
2463 return values (Bug#10845).
2465 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2467 * .gdbinit (pitx): Fix incorrect references to fields of the
2470 2012-02-17 Chong Yidong <cyd@gnu.org>
2472 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2474 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2476 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2477 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2479 2012-02-15 Chong Yidong <cyd@gnu.org>
2481 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2482 marked as special. Also, starting docstrings with * is obsolete.
2484 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2486 * gnutls.c (emacs_gnutls_write): Fix last change.
2488 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2490 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2493 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2495 * keymap.c (Fsingle_key_description): Handle char ranges.
2497 2012-02-12 Chong Yidong <cyd@gnu.org>
2499 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2500 as that creates a dangerous corner case.
2502 * window.c (Fdelete_window_internal): Invalidate the mouse
2503 highlight (Bug#9904).
2505 2012-02-12 Glenn Morris <rgm@gnu.org>
2507 * xselect.c (Fx_own_selection_internal)
2508 (Fx_get_selection_internal, Fx_disown_selection_internal)
2509 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2510 * nsselect.m (Fx_own_selection_internal)
2511 (Fx_disown_selection_internal, Fx_selection_exists_p)
2512 (Fx_selection_owner_p, Fx_get_selection_internal):
2513 Sync docs and argument specs with the xselect.c versions.
2515 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2517 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2519 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2521 * w32select.c (Fx_selection_exists_p): Sync doc string and
2522 argument list with xselect.c. (Bug#10783)
2524 * w16select.c (Fx_selection_exists_p): Sync doc string and
2525 argument list with xselect.c. (Bug#10783)
2527 2012-02-10 Glenn Morris <rgm@gnu.org>
2529 * fns.c (Fsecure_hash): Doc fix.
2531 2012-02-09 Kenichi Handa <handa@m17n.org>
2533 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2535 2012-02-07 Chong Yidong <cyd@gnu.org>
2537 * buffer.c (Fbuffer_local_variables)
2538 (buffer_lisp_local_variables): Handle unbound vars correctly;
2539 don't let Qunbound leak into Lisp.
2541 2012-02-07 Glenn Morris <rgm@gnu.org>
2543 * image.c (Fimagemagick_types): Doc fix.
2545 * image.c (imagemagick-render-type): Change it from a lisp object
2546 to an integer. Move the doc here from the lisp manual.
2547 Treat all values not equal to 0 the same.
2549 2012-02-06 Chong Yidong <cyd@gnu.org>
2551 * doc.c (store_function_docstring): Avoid applying docstring of
2552 alias to base function (Bug#2603).
2554 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2556 * .gdbinit (pp1, pv1): Remove redundant defines.
2559 2012-02-04 Chong Yidong <cyd@gnu.org>
2561 * nsterm.m: Declare a global (Bug#10694).
2563 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2565 * w32.c (get_emacs_configuration_options):
2566 Include --enable-checking, if specified, in the return value.
2568 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2570 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2571 after rounding frame sizes. (Bug#9723)
2573 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2575 * keyboard.c (adjust_point_for_property): Don't position point
2576 before BEGV. (Bug#10696)
2578 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2580 Handle overflow when computing char display width (Bug#9496).
2581 * character.c (char_width): Return EMACS_INT, not int.
2582 (char_width, c_string_width): Check for overflow when
2583 computing the width; this is possible now that individual
2584 characters can have unbounded width. Problem introduced
2585 by merge from Emacs 23 on 2012-01-19.
2587 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2589 * dbusbind.c (Fdbus_register_method): Mention the return value
2590 :ignore in the docstring.
2592 2012-02-02 Glenn Morris <rgm@gnu.org>
2594 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2596 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2597 Unconditionally set to t. (Bug#10673)
2598 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2599 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2600 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2602 2012-02-02 Kenichi Handa <handa@m17n.org>
2604 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2605 0, do not call append_composite_glyph.
2607 2012-02-02 Kenichi Handa <handa@m17n.org>
2609 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2611 (x_produce_glyphs): If the component of a composition is a null
2612 string, set it->pixel_width to 1 to avoid zero-width glyph.
2614 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2616 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2617 first 2 arguments are identical. This makes inserting large
2618 output from a subprocess an order of magnitude faster on
2619 MS-Windows, where all sbrk'ed memory is always contiguous.
2621 2012-01-31 Glenn Morris <rgm@gnu.org>
2623 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2624 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2625 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2627 2012-01-29 Glenn Morris <rgm@gnu.org>
2629 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2631 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2633 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2635 2012-01-28 Chong Yidong <cyd@gnu.org>
2637 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2639 2012-01-26 Chong Yidong <cyd@gnu.org>
2641 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2643 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2644 repeat counts (Bug#10507).
2646 2012-01-26 Glenn Morris <rgm@gnu.org>
2648 * lread.c (syms_of_lread): Doc fix.
2650 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2652 * coding.c (encode_designation_at_bol): Change return value to
2655 2012-01-25 Chong Yidong <cyd@gnu.org>
2657 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2659 2012-01-21 Chong Yidong <cyd@gnu.org>
2661 * floatfns.c (Fcopysign): Make the second argument non-optional,
2662 since nil is not allowed anyway.
2664 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2666 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2667 (send_process): Likewise.
2669 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2671 * window.c (save_window_save, Fcurrent_window_configuration)
2672 (Vwindow_persistent_parameters): Do not use Qstate.
2673 Rewrite doc-strings.
2675 2012-01-19 Kenichi Handa <handa@m17n.org>
2677 * character.c (char_width): New function.
2678 (Fchar_width, c_string_width, lisp_string_width):
2679 Use char_width (Bug#9496).
2681 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2683 * window.c (Vwindow_persistent_parameters): New variable.
2684 (Fset_window_configuration, save_window_save): Handle persistent
2687 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2689 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2690 thrashing the stack of the thread. (Bug#9087)
2692 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2694 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2696 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (rows_from_pos_range): Handle the case where the
2699 highlight ends on a newline. (Bug#10464)
2700 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2701 he end column for display of highlight that ends on a newline
2704 2012-01-11 Glenn Morris <rgm@gnu.org>
2706 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2707 from load-path also when installation-directory is nil. (Bug#10208)
2709 2012-01-10 Glenn Morris <rgm@gnu.org>
2711 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2713 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2714 Update template values to be closer to their typical values these days.
2716 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2718 * xdisp.c (rows_from_pos_range): Accept additional argument
2719 DISP_STRING, and accept any glyph in a row whose object is that
2720 string as eligible for mouse highlight. Fixes mouse highlight of
2721 display strings from overlays. (Bug#10464)
2723 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2725 emacs: fix an auto-save permissions race condition (Bug#10400)
2726 * fileio.c (auto_saving_dir_umask): New static var.
2727 (Fmake_directory_internal): Use it.
2728 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2729 creating the directory. The old code temporarily assigns
2730 too-generous permissions to the directory.
2731 (do_auto_save_eh): Clear it.
2732 (Fdo_auto_save): Catch all errors, not just file errors, so
2733 that the var is always cleared.
2735 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2737 * search.c (scan_buffer): Pass character positions to
2738 know_region_cache, not byte positions. (Bug#6540)
2740 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2742 * w32.c (sys_rename): Report EXDEV when rename of a directory
2743 fails because the target is on another logical disk. (Bug#10284)
2745 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2747 * xterm.c (x_embed_request_focus): New function.
2749 * xterm.h: Add prototype.
2751 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2753 2012-01-05 Glenn Morris <rgm@gnu.org>
2755 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2757 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2759 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2760 Load gnutls_transport_set_lowat only if GnuTLS version is below
2762 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2763 GnuTLS versions below 2.11.1.
2765 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2767 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2768 to the doc string advising against its use for altering the way
2769 windows are scrolled.
2771 2011-12-28 Kenichi Handa <handa@m17n.org>
2773 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2774 coding-system ASCII compatible only when it does not produce BOM
2775 on encoding (Bug#10383).
2777 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2779 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2781 (create_and_show_popup_menu): Always use menu_position_func for
2784 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2786 * callint.c (Fcall_interactively): Don't truncate prompt string.
2788 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2791 property that ends at ZV, so that the bidi iteration could be
2792 resumed from there (after widening). (Bug#10360)
2794 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2796 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2798 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2800 * nsterm.m (x_free_frame_resources):
2801 Release f->output_data.ns->miniimage.
2802 (ns_index_color): Fix indentation. Do not retain
2803 color_table->colors[i].
2805 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2808 * nsfns.m (x_set_background_color): Assign return value from
2809 ns_index_color to face-background instead of NSColor*.
2810 (ns_implicitly_set_icon_type): Fix indentation.
2811 Change assignment in for loop to comparison.
2813 * emacs.c (ns_pool): New variable.
2814 (main): Assign ns_pool.
2815 (Fkill_emacs): Call ns_release_autorelease_pool.
2817 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2818 autorelease fdesc, release fdAttrs and tdict.
2819 (ns_get_covering_families): Release charset.
2820 (ns_findfonts): Release NSFontDescriptor created with new.
2821 (ns_uni_to_glyphs): Fix indentation.
2822 (setString): Release attrStr before assigning new value.
2824 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2826 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2828 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2829 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2831 2011-12-18 David Reitter <reitter@cmu.edu>
2833 * nsterm.m (ns_term_init): Subscribe for notifications
2834 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2835 to method trackingNotification in EmacsMenu.
2837 * nsmenu.m (trackingMenu): New variable.
2838 (trackingNotification): New method (from Aquamacs).
2839 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2840 from Aquamacs (Bug#7030).
2842 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2844 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2845 (symbol_to_nsstring): Fix indentation.
2846 (ns_symbol_to_pb): New function.
2847 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2848 (Fns_rotate_cut_buffers_internal): Remove.
2849 (Fns_store_selection_internal): Rename from
2850 Fns_store_cut_buffer_internal.
2851 (ns_get_foreign_selection, Fx_own_selection_internal)
2852 (Fx_disown_selection_internal, Fx_selection_exists_p)
2853 (Fns_get_selection_internal, Fns_store_selection_internal):
2854 Use ns_symbol_to_pb and check if return value is nil.
2855 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2856 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2857 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2858 renamed to Sns_store_selection_internal.
2859 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2860 and remove this function.
2861 (ns_handle_selection_clear): Remove, never used.
2862 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2865 2011-12-17 Ken Brown <kbrown@cornell.edu>
2867 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2868 GID is unknown (Bug#10257).
2870 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2872 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2873 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2874 which caused a build failure on GNU/Linux IA-64. This problem was
2875 introduced by my 2011-10-07 patch.
2877 2011-12-15 Juri Linkov <juri@jurta.org>
2879 * image.c (imagemagick_error): New function. (Bug#10112)
2880 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2881 Use `imagemagick_error' where ImageMagick functions return
2883 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2886 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2888 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2889 fill background (Bug#8992).
2891 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2893 * window.c (Vwindow_combination_resize)
2894 (Vwindow_combination_limit): Use t instead of non-nil in
2896 (Vrecenter_redisplay): Add first sentence of doc-string on
2898 (Frecenter): Fix doc-string typo.
2900 2011-12-11 Kenichi Handa <handa@m17n.org>
2902 * coding.c (Funencodable_char_position): Pay attention to the
2903 buffer text relocation (Bug#9389).
2905 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2907 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2908 gtk_init (Bug#10100).
2910 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2912 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2913 IT->string is nil. (Bug#10263)
2915 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2917 * nsterm.h (x_free_frame_resources): Declare.
2919 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2920 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2922 * nsterm.h (ns_get_defaults_value): Declare.
2924 * nsterm.m (ns_default): Call ns_get_defaults_value.
2926 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2928 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2931 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2933 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2934 that where the value of an _OBJC_* symbol points to is in the .bss
2935 section (Bug#10240).
2937 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2939 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2940 after the loop to call ccl_driver at least once (Bug#8619).
2942 2011-12-08 Kenichi Handa <handa@m17n.org>
2944 * ftfont.c (get_adstyle_property): Fix previous change
2947 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2949 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2950 dirs from the default value of EMACSLOADPATH (bug#10208).
2952 2011-12-07 Glenn Morris <rgm@gnu.org>
2954 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2955 installation and source directories as well. (Bug#10208)
2957 2011-12-06 Chong Yidong <cyd@gnu.org>
2959 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2961 2011-12-06 Glenn Morris <rgm@gnu.org>
2963 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2964 as an error, not just -1. (Bug#10217)
2966 2011-12-05 Chong Yidong <cyd@gnu.org>
2968 * keyboard.c (process_special_events): New function.
2969 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2971 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2973 * coding.c (encode_designation_at_bol): Don't use uninitialized
2974 local variable (Bug#9318).
2976 2011-12-05 Kenichi Handa <handa@m17n.org>
2978 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2979 return Qnil (Bug#8046, Bug#10193).
2981 2011-12-05 Kenichi Handa <handa@m17n.org>
2983 * coding.c (encode_designation_at_bol): New args charbuf_end and
2984 dst. Return the number of produced bytes. Callers changed.
2985 (coding_set_source): Return how many bytes coding->source was
2987 (coding_set_destination): Return how many bytes
2988 coding->destination was relocated.
2989 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2990 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2992 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2994 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2995 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2998 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3000 The following changes are to fix Bug#9318.
3002 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3003 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3004 (encode_coding_iso_2022, encode_coding_sjis)
3005 (encode_coding_big5, encode_coding_charset): Use the above macros.
3007 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3009 * lisp.h (process_quit_flag): Fix external declaration.
3011 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3013 Don't macro-inline non-performance-critical code.
3014 * eval.c (process_quit_flag): New function.
3015 * lisp.h (QUIT): Use it.
3017 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3019 * nsfns.m (get_geometry_from_preferences): New function.
3020 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3022 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3024 * emacs.c (Qkill_emacs): Define.
3025 (syms_of_emacs): Initialize it.
3026 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3027 Qquit_flag to `kill-emacs' instead.
3028 (quit_throw_to_read_char): Add parameter `from_signal'.
3029 All callers changed. Call Fkill_emacs if requested and safe.
3030 * lisp.h (QUIT): Call Fkill_emacs if requested.
3032 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3034 * widget.c (update_wm_hints): Return if wmshell is null.
3035 (widget_update_wm_size_hints): New function.
3037 * widget.h (widget_update_wm_size_hints): Declare.
3039 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3040 widget_update_wm_size_hints (Bug#10104).
3042 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3044 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3045 before a newline, prepare the bidi iterator for consuming the
3046 newline, and keep the current paragraph direction. (Bug#10183)
3047 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3049 2011-12-02 Juri Linkov <juri@jurta.org>
3051 * search.c (Fword_search_regexp): New Lisp function created from
3052 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3053 (Fword_search_backward, Fword_search_forward)
3054 (Fword_search_backward_lax, Fword_search_forward_lax):
3055 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3056 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3058 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3060 * fileio.c (Finsert_file_contents): Move after-change-function call
3061 to before the "handled:" label, since all "goto handled" appear in
3062 cases where the *-change-functions have already been properly called
3065 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3067 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3068 waiting for input. (Bug#10169)
3070 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3072 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3073 verifies glyph row's hash code--we have just reallocated the
3074 glyphs, so their contents can be complete garbage. (Bug#10164)
3076 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3078 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3080 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3082 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3083 attributes are tested _before_ calling verify_row_hash, to protect
3084 against GCC re-ordering of the tests. (Bug#10164)
3086 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3088 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3090 * xterm.c (handle_one_xevent): Only set async_visible and friends
3091 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3092 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3093 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3095 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3097 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3098 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3099 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3100 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3101 All uses changed to use GCPRO1 etc.
3102 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3103 Revert to old implementation (i.e., before 2011-03-11).
3105 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3107 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3108 of scroll runs so as to avoid assigning disabled bogus rows and
3109 unnecessary graphics copy operations.
3111 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3113 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3114 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3115 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3116 (malloc, free, realloc, calloc): Redirect to e_* only when
3119 * lisp.h (GCTYPEBITS): Move before first use.
3120 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3121 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3122 this macro definition.
3124 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3127 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3129 * gtkutil.c (xg_create_frame_widgets):
3130 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3131 present with Gtk+ 2.0.
3133 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3135 * fileio.c (Finsert_file_contents): Undo previous change; see
3136 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3138 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3140 Rename locals to avoid shadowing.
3141 * fileio.c (Finsert_file_contents):
3142 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3143 * process.c (wait_reading_process_output):
3144 Rename inner 'proc' to 'p' to avoid shadowing.
3145 Indent for consistency with usual Emacs style.
3147 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3149 * xdisp.c (redisplay_window): If cursor row is not fully visible
3150 after recentering, and scroll-conservatively is set to a large
3151 number, scroll window by a few more lines to make the cursor fully
3152 visible and out of scroll-margin. (Bug#10105)
3153 (start_display): Don't move to the next line if the display should
3154 start at a newline that is part of a display vector or an overlay
3157 2011-11-24 Juri Linkov <juri@jurta.org>
3159 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3160 after the `MagickPingImage' call. (Bug#10112)
3162 2011-11-23 Chong Yidong <cyd@gnu.org>
3164 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3166 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3168 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3169 making another buffer current. (Bug#10114)
3171 2011-11-23 Glenn Morris <rgm@gnu.org>
3173 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3175 2011-11-23 Chong Yidong <cyd@gnu.org>
3177 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3178 using it (Bug#5984).
3180 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3182 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3183 and header-lines, as they don't have one computed for them.
3186 * .gdbinit (prow): Make displayed values more self-explaining.
3187 Add row's hash code.
3189 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3191 * process.c (wait_reading_process_output): Fix asynchrounous
3192 GnuTLS socket handling on some versions of the GnuTLS library.
3193 (wait_reading_process_output): Add comment and URL.
3195 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3197 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3199 2011-11-21 Chong Yidong <cyd@gnu.org>
3201 * window.c (Fnext_window, Fprevious_window): Doc fix.
3203 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3205 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3207 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3209 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3211 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3213 * window.c (Fset_window_combination_limit): Rename argument
3215 (Vwindow_combination_limit): Remove "status" from doc-string.
3217 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3219 * m/ibms390.h: Remove.
3220 * m/ibms390x.h: Don't include "ibms390.h".
3222 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3224 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3225 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3227 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3229 * casetab.c (Fset_case_table):
3230 * charset.c (Fcharset_after): Fix typos.
3232 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3234 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3235 Otherwise, valgrind does not work on some platforms.
3236 Problem reported by Andreas Schwab in
3237 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3238 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3239 is set, removing the need for VIRT_ADDRESS_VARIES.
3240 (PURE_P): Use a more-efficient implementation that needs just one
3241 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3242 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3243 to 4 (xorl, subq, cmpq, setbe).
3244 * alloc.c (pure): Always extern now, since that's the
3245 VIRT_ADDR_VARIES behavior.
3246 (PURE_POINTER_P): Use a single comparison, not two, for
3247 consistency with the new puresize.h.
3248 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3249 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3250 Remove VIRT_ADDR_VARIES no longer needed.
3252 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3254 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3255 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3256 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3257 behave as if the cursor position were at the window margin.
3259 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3260 and the cursor position is out of bounds, behave as if the cursor
3261 position were at the window margin. (Bug#10075)
3263 2011-11-18 Chong Yidong <cyd@gnu.org>
3265 * window.c (Fwindow_combination_limit): Make first argument
3266 non-optional, since it is meaningless for live windows like the
3269 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3271 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3273 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3275 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3276 (graft_intervals_into_buffer): Simplify.
3278 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3280 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3281 hash values of the two rows.
3282 (copy_row_except_pointers): Preserve the used[] arrays and the
3283 hash values of the two rows. (Bug#10035)
3284 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3286 * xdisp.c (row_hash): New function, body extracted from
3287 compute_line_metrics.
3288 (compute_line_metrics): Call row_hash, instead of computing the
3291 * dispnew.c (verify_row_hash): Call row_hash for computing the
3292 hash code of a row, instead of duplicating code from xdisp.c.
3294 * dispextern.h (row_hash): Add prototype.
3296 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3298 * frame.c (delete_frame): Don't delete the terminal when the last
3299 X frame is closed if emacs is built with GTK toolkit.
3301 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3303 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3305 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3307 * window.c (Vwindow_splits): Rename to
3308 Vwindow_combination_resize. Suggested by Juri Linkov.
3309 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3312 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3314 * nsfns.m (Fns_font_name):
3315 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3317 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3319 * window.h (window): Rename slot "nest" to "combination_limit".
3320 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3321 (Fset_window_nest): Rename to Fset_window_combination_limit.
3322 (Vwindow_nest): Rename to Vwindow_combination_limit.
3323 (recombine_windows, make_parent_window, make_window)
3324 (Fsplit_window_internal, saved_window)
3325 (Fset_window_configuration, save_window_save): Rename all
3326 occurrences of window_nest to window_combination_limit.
3328 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3330 * image.c (imagemagick_load_image): Fix typo.
3332 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3334 * xdisp.c (display_line): Move the call to
3335 highlight_trailing_whitespace before the call to
3336 compute_line_metrics, since the latter needs to see the final
3337 faces of all the glyphs to compute ROW's hash value.
3338 Fixes assertion violations in row_equal_p. (Bug#10035)
3340 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3342 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3343 just return (bug#10044).
3345 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3347 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3348 with user-defined heap size. Bump the default size of the temacs
3349 heap to 27MB, to avoid memory warning when running temacs.
3350 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3352 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3353 current_matrix and desired_matrix. (Bug#9990)
3354 (verify_row_hash) [XASSERTS]: New function.
3355 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3356 that the hash value of glyph rows is correct.
3358 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3360 * window.h (window): Remove splits slot.
3361 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3362 (Fdelete_other_windows_internal, make_parent_window)
3363 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3364 (Fset_window_configuration, save_window_save): Don't deal with
3365 split status of windows.
3366 (saved_window): Remove splits slot.
3367 (Vwindow_splits): Rewrite doc-string.
3369 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3371 * xfns.c (unwind_create_frame):
3372 * nsfns.m (unwind_create_frame):
3373 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3374 Vframe_list (Bug#9999).
3376 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3378 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3380 2011-11-11 Kenichi Handa <handa@m17n.org>
3382 * callproc.c (Fcall_process): Set the member dst_multibyte of
3385 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3387 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3388 avoid a crash (bug#9496).
3390 2011-11-09 Chong Yidong <cyd@gnu.org>
3392 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3393 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3395 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3397 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3399 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3401 Avoid some portability problems by eschewing 'extern inline' functions.
3402 The trivial performance wins aren't worth the portability hassles; see
3403 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3405 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3406 (window_box_width, window_box_left, window_box_left_offset)
3407 (window_box_right, window_box_right_offset): Undo previous change,
3408 by removing the "extern"s.
3409 * intervals.c (adjust_intervals_for_insertion)
3410 (adjust_intervals_for_deletion): Undo previous change,
3411 making these static again.
3412 (offset_intervals, temp_set_point_both, temp_set_point)
3413 (copy_intervals_to_string): No longer inline.
3414 * xdisp.c (window_text_bottom_y, window_box_width)
3415 (window_box_height, window_box_left_offset)
3416 (window_box_right_offset, window_box_left, window_box_right)
3417 (window_box): No longer inline.
3419 2011-11-08 Chong Yidong <cyd@gnu.org>
3421 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3422 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3423 Signal an error if not a live window.
3424 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3425 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3427 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3429 * lisp.h (syms_of_abbrev): Remove declaration.
3430 Reported by CHENG Gao <chenggao@royau.me>.
3432 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3434 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3435 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3436 of temacs in GUI mode.
3438 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3440 * window.h: Declare delete_all_child_windows instead of
3441 delete_all_subwindows.
3442 * window.c (Fwindow_nest, Fset_window_nest)
3443 (Fset_window_new_total, Fset_window_new_normal)
3444 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3445 (delete_all_subwindows): Rename to delete_all_child_windows.
3446 (Fdelete_other_windows_internal, Fset_window_configuration):
3447 Call delete_all_child_windows instead of delete_all_subwindows.
3448 * frame.c (delete_frame): Call delete_all_child_windows instead
3449 of delete_all_subwindows.
3451 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3453 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3454 This is also needed for porting to any host where GC_MARK_STACK is
3455 not GC_MAKE_GCPROS_NOOPS.
3456 (which_symbols): Use it.
3458 2011-11-07 Kenichi Handa <handa@m17n.org>
3460 * coding.c (coding_set_destination): Check coding->src_pos only
3461 when coding->src_object is a buffer (bug#9910).
3463 * process.c (send_process): Set the member src_multibyte of coding
3464 to 0 (bug#9911) when sending a unibyte text.
3466 * callproc.c (Fcall_process): Set the member src_multibyte of
3467 process_coding to 0 (bug#9912).
3469 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3471 * xmenu.c (cleanup_widget_value_tree): New function.
3472 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3473 calling free_menubar_widget_value_tree directly (Bug#9830).
3475 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3477 Fix some portability problems with 'inline'.
3478 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3479 (window_box_width, window_box_left, window_box_left_offset)
3480 (window_box_right, window_box_right_offset): Declare extern.
3481 Otherwise, these inline functions do not conform to C99 and
3482 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3483 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3484 * intervals.c (adjust_intervals_for_insertion)
3485 (adjust_intervals_for_deletion): Now extern, because otherwise the
3486 extern inline functions 'offset_intervals' couldn't refer to it.
3487 (static_offset_intervals): Remove.
3488 (offset_intervals): Rewrite using the old contents of
3489 static_offset_intervals. The old version didn't conform to C99
3490 because an extern inline function contained a reference to an
3491 identifier with static linkage.
3493 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3495 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3498 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3500 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3501 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3502 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3503 return Qleft_to_right.
3505 2011-11-06 Chong Yidong <cyd@gnu.org>
3507 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3508 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3509 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3510 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3511 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3512 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3513 (Fwindow_vscroll): Doc fix.
3514 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3515 argument, since it makes no sense to pass a live window and for
3516 consistency with window-child.
3518 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3520 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3523 2011-11-05 Jason Rumney <jasonr@gnu.org>
3525 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3526 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3528 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3529 bitwise arithmetic preventing use of unicode-sip and non-truetype
3532 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3534 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3537 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3538 initialization code to keep similarity to xfns.c after changes
3541 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3543 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3544 (unwind_create_frame): New function (Bug#9943).
3545 (Fx_create_frame): Restructure code to be more similar to the one in
3546 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3547 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3548 Move terminal->reference_count++ just before making the frame official
3551 * nsterm.m (x_free_frame_resources): New function.
3552 (x_destroy_window): Move code to x_free_frame_resources.
3554 * xfns.c (unwind_create_frame): Fix comment.
3555 (Fx_create_frame, x_create_tip_frame):
3556 Move terminal->reference_count++ just before making the frame
3557 official. Move initialization of image_cache_refcount and
3558 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3560 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3562 Support MSVC build with newer versions of Visual Studio.
3563 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3564 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3567 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3568 which are not supported by MSVC.
3569 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3570 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3572 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3574 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3576 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3578 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3580 Support MSVC build with newer versions of Visual Studio.
3581 * w32.c: Don't include w32api.h for MSVC.
3582 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3584 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3585 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3586 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3587 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3589 (alloca) [_MSC_VER]: Define to _alloca.
3591 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3593 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3595 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3597 * xdisp.c (note_mouse_highlight): If either of
3598 previous/next-single-property-change returns nil, treat that as
3599 the beginning or the end of the buffer. (Bug#9955)
3601 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3603 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3604 label is not null (Bug#9951).
3605 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3608 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3610 * window.c (Fwindow_body_size): Mention in the doc string that the
3611 return value is in frame's canonical units. (Bug#9949)
3613 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3615 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3617 * w32fns.c (unwind_create_frame): If needed, free the glyph
3618 matrices of the partially constructed frame. (Bug#9943)
3619 * xfns.c (unwind_create_frame): Likewise.
3621 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3623 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3624 Don't stop backward scan on the continuation glyph, even though
3625 its CHARPOS is positive.
3626 (mouse_face_from_buffer_pos, note_mouse_highlight):
3627 Rename cover_string to disp_string.
3629 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3631 * window.c (temp_output_buffer_show): Don't use
3632 Vtemp_buffer_show_specifiers.
3633 (Vtemp_buffer_show_specifiers): Remove unused variable.
3635 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3637 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3638 past the beginning of the current glyph matrix.
3640 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3642 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3643 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3644 HAVE_GTK3 (Bug#9869).
3646 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3647 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3649 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3651 * xterm.c: Declare x_handle_net_wm_state to return int.
3652 (handle_one_xevent): Check if we are iconified but don't have
3653 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3654 (get_current_wm_state): Return non-zero if not hidden,
3655 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3656 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3657 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3658 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3660 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3662 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3663 so that this new function doesn't get optimized away by a
3664 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3666 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3668 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3670 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3672 Fix the `xbytecode' command.
3673 * .gdbinit (xprintbytestr): New command.
3674 (xwhichsymbols): Rename from `which'; all callers changed.
3675 (xbytecode): Print the byte-code string as well.
3677 2011-10-29 Kim Storm <storm@cua.dk>
3679 * alloc.c (which_symbols): New function.
3681 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3683 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3686 2011-10-29 Glenn Morris <rgm@gnu.org>
3688 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3689 Not clear what it was for, and it causes various bugs. (Bug#9839)
3691 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3693 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3694 possible random value that matches one of those tested as
3695 condition to clear the mouse face.
3697 2011-10-28 Chong Yidong <cyd@gnu.org>
3699 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3701 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3703 * window.c (make_window): Initialize phys_cursor_on_p.
3705 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3707 * lisp.h (struct Lisp_Symbol): Update comments.
3709 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3711 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3713 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3715 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3716 <oslsachem@gmail.com> for helping to debug this.
3718 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3719 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3720 (g_b_init_get_glyph_outline_w): New static variables.
3721 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3722 (GetGlyphOutlineW_Proc): New typedefs.
3723 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3724 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3726 (w32font_open_internal, compute_metrics):
3727 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3728 instead of calling the "wide" APIs directly.
3730 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3732 * w32.h (syms_of_w32font): Add prototype.
3734 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3736 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3737 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3738 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3739 (Fmove_to_window_line): Doc fix.
3741 2011-10-27 Chong Yidong <cyd@gnu.org>
3743 * process.c (make_process): Set gnutls_state to NULL.
3745 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3746 non-NULL, regardless of GNUTLS_INITSTAGE.
3747 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3748 an error. Set process slots as soon as we allocate them.
3750 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3752 2011-10-27 Chong Yidong <cyd@gnu.org>
3754 * gnutls.c (emacs_gnutls_deinit): New function.
3755 Deallocate credentials structures as well as calling gnutls_deinit.
3756 (Fgnutls_deinit, Fgnutls_boot): Use it.
3758 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3759 (deactivate_process): Call emacs_gnutls_deinit.
3761 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3763 * image.c (x_create_x_image_and_pixmap):
3764 * w32.c (sys_rename, w32_delayed_load):
3765 * w32font.c (fill_in_logfont):
3766 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3768 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3770 * w32fns.c (w32_default_color_map): New function,
3771 extracted from Fw32_default_color_map.
3772 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3774 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3776 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3778 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3780 * keyboard.c (test_undefined): New function (bug#9751).
3781 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3783 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3785 * sysdep.c (init_sys_modes): Fix the check for the controlling
3786 terminal (Bug#6649).
3788 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3790 * dispextern.h (struct bidi_it): New member next_en_type.
3792 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3793 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3794 current character, check also for next_en_type being WEAK_EN.
3795 (bidi_resolve_weak): Don't enter the expensive loop if the current
3796 position is before next_en_pos. Record the bidi type of the first
3797 non-ET, non-BN character we find, in addition to its position.
3798 (bidi_level_of_next_char): Invalidate next_en_type when
3799 next_en_pos is over-stepped.
3801 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3803 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3804 * editfns.c: Rewrite current-time-zone so that it invokes
3805 the equivalent of (format-time-string "%Z") to get the time zone name.
3806 This fixes a bug when the time zone name contains characters that
3807 need converting from the system time locale to Emacs internal format.
3808 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3809 that patch fixed format-time-string to do the conversion, but
3810 I forgot to fix current-time-zone.
3811 (format_time_string): New function, containing most of
3812 what Fformat_time_string used to contain.
3813 (Fformat_time_string): Rewrite in terms of format_time_string.
3814 This doesn't change this function's behavior.
3815 (current-time-zone): Rewrite to use format_time_string.
3816 This fixes the bug reported by Michael Schierl in
3817 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3818 Jason Rumney's 2007-06-07 change worked around this bug, but
3820 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3822 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3824 * xdisp.c (start_display): If the character at POS is displayed
3825 via a display vector, reset IT->current.dpvec_index to zero.
3826 (try_window_reusing_current_matrix): If a line ends in a display
3827 vector or the next line starts in a display vector, continue
3828 redrawing the window even though the character position of
3829 start_row was reached.
3832 2011-10-18 Chong Yidong <cyd@gnu.org>
3834 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3835 with nobreak-char-display too.
3837 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3839 Fix part 3 of bug#9771.
3840 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3841 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3842 non-neutral characters if the current character is a paragraph
3843 separator (a.k.a. Newline). This avoids running the same
3844 expensive loop twice, once when we consume the preceding newline
3845 and the other time when the line actually needs to be displayed.
3846 Avoid the loop when we see neutrals on the base embedding level
3847 following a character whose directionality is the same as the
3848 paragraph's. This avoids running the expensive loop when a line
3849 ends in a long sequence of neutrals, like control characters.
3850 Add assertion against STRONG_AL type. Slightly rearrange code
3851 that determines the type of a neutral given the first non-neutral
3853 (bidi_level_of_next_char): Set next_en_pos to zero when
3854 invalidating its info.
3856 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3858 * xdisp.c (push_display_prop): Determine whether to record string
3859 or buffer position by IT->string, not by IT->method. Allow
3860 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3861 (move_it_vertically_backward): Don't look for character position
3862 immediately after the newline when in a continuation line.
3865 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3867 * window.c (coordinates_in_window): Rewrite and delabelize
3868 vertical border check. (Bug#5357) (Bug#9618)
3870 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3872 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3873 errors in XSetWindowBorder (bug#9310).
3875 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3877 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3878 avoid crash when xmalloc overrun checking is enabled.
3880 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3882 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3883 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3884 cursor motion with <left> and <right> arrow keys.
3886 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3887 some callers set that themselves.
3889 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3891 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3892 display string and the previous row comes from the same string and
3893 is empty. (Bug#9739) (Bug#9738)
3895 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3897 * doc.c (get_doc_string): Encode file name (bug#9735).
3899 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3901 * bidi.c (bidi_level_of_next_char):
3902 * xdisp.c (get_visually_first_element): Remove old incorrect
3903 comments regarding the Unicode Line Separator character.
3905 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3907 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3909 * alloc.c (Fgc_status): Do not access beyond zombies array
3910 boundary if nzombies > MAX_ZOMBIES.
3911 * alloc.c (dump_zombies): Add missing format specifier.
3913 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3915 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3916 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3918 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3919 Some packages use them to denote characters with modifiers.
3921 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3923 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3924 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3925 matching a pp-number. Rename parameter var to var1.
3927 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3929 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3931 2011-10-08 Glenn Morris <rgm@gnu.org>
3933 * callint.c (Fcall_interactively): Give a more explicit error for the
3934 'c' case with a non-character input. (Bug#8479)
3936 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3938 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3940 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3941 lines that are hscrolled on the left.
3943 * dispnew.c (buffer_posn_from_coords): Account for a possible
3944 presence of header-line. (Bug#4426)
3946 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3948 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3949 Don't advertise functionality which we discourage or doesn't work.
3951 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3953 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3954 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3955 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3956 this makes Emacs dump core during garbage collection on rare
3957 occasions. sizeof is obviously inferior to offsetof here, so
3958 stick with offsetof.
3959 (GC_POINTER_ALIGNMENT): New macro.
3960 (mark_memory): Omit 3rd (offset) arg; caller changed.
3961 Don't assume EMACS_INT alignment is the same as pointer alignment.
3963 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3965 * keyboard.c (read_key_sequence_remapped): New var.
3966 (read_key_sequence): Compute remapping in the right buffer.
3967 (command_loop_1): Use read_key_sequence's remapping directly.
3969 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3971 * dired.c (file_name_completion): Don't expand file name.
3972 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3973 before checking file name handler.
3975 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3976 they've been requested explicitly (bug#9591).
3978 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3980 * keymap.c (Fsingle_key_description): Use make_specified_string
3981 instead of build_string to build string from push_key_description.
3984 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3986 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3987 This fixes a Y2038 bug on 64-bit hosts.
3988 * buffer.c (reset_buffer):
3989 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3990 (Fclear_buffer_auto_save_failure):
3991 Use 0, not -1, to represent an unset failure time, since time_t
3992 might not be signed.
3994 Remove dependency on glibc malloc internals.
3995 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3996 Move back here from lisp.h, but with their new implementations.
3997 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3998 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3999 * charset.c (charset_table_init): New static var.
4000 (syms_of_charset): Use it instead of xmalloc. This removes a
4001 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4002 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4003 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4004 Move back to alloc.c.
4005 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4006 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4008 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4010 * nsterm.m (windowDidResize): Call x_set_window_size only when
4011 ns_in_resize is true. Otherwise set pixelwidth/height and
4012 call change_frame_size (Bug#9628).
4014 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4016 Port --enable-checking=all to Fedora 14 x86-64.
4017 * charset.c (syms_of_charset): Also account for glibc malloc's
4018 internal overhead when calculating the initial malloc maximum.
4020 Port --enable-checking=all to Fedora 14 x86.
4021 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4023 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4024 (overrun_check_realloc, overrun_check_free):
4025 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4026 That way, xmalloc returns a properly-aligned pointer even if
4027 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4028 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4029 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4030 into account when calculating the initial malloc maximum.
4031 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4032 Move here from alloc.c, so that charset.c can use it too.
4033 Properly align; the old code wasn't right for common 32-bit hosts
4034 when configured with --enable-checking=all.
4035 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4036 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4038 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4040 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4043 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4045 * xdisp.c (compute_display_string_end): If there's no display
4046 string at CHARPOS, return -1.
4048 * bidi.c (bidi_fetch_char): When compute_display_string_end
4049 returns a negative value, treat the character as a normal
4050 character not covered by a display string. (Bug#9624)
4052 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4054 * lread.c (Fread_from_string): Fix typo in docstring.
4056 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4058 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4059 newline, reseat the iterator instead of bidi-iterating there one
4060 character at a time. (Bug#9610)
4061 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4062 TO_CHARPOS if the bidi iterator is at base embedding level.
4064 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4066 * lread.c (readevalloop): Use correct code for NBSP.
4067 (read1): Likewise. (Bug#9608)
4069 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4071 * dbusbind.c (Fdbus_register_signal): When service is not
4072 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4074 2011-09-25 Glenn Morris <rgm@gnu.org>
4076 * buffer.c (truncate-lines): Doc fix.
4078 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4080 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4081 (Fset_window_next_buffers): Doc fix.
4083 2011-09-24 Glenn Morris <rgm@gnu.org>
4085 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4087 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4089 Fix minor problems found by static checking.
4090 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4091 * indent.c (Fvertical_motion): Fix == vs = typo.
4093 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4095 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4096 Default value is now t. Doc fix.
4098 * indent.c (Fvertical_motion): Compute and apply the overshoot
4099 logic when moving up, not only when moving down. Fix the
4100 confusing name and values of the it_overshoot_expected variable;
4101 logic changes accordingly. (Bug#9254) (Bug#9549)
4103 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4104 CHARPOS is covered by a display string which includes newlines.
4105 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4106 is covered by a display string with embedded newlines.
4108 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4110 * dbusbind.c (Fdbus_register_signal): Add match rule to
4111 Vdbus_registered_objects_table. (Bug#9581)
4112 (Fdbus_register_method, Vdbus_registered_objects_table):
4115 2011-09-24 Jim Meyering <meyering@redhat.com>
4117 do not ignore write error for any output size
4118 The previous change was incomplete.
4119 While it makes emacs --batch detect the vast majority of stdout
4120 write failures, errors were still ignored whenever the output size is
4121 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4122 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4123 && echo FAIL: ignored write error
4124 FAIL: ignored write error
4125 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4126 && echo FAIL: ignored write error
4127 FAIL: ignored write error
4128 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4130 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4132 * emacs.c (Fkill_emacs): In noninteractive mode exit
4133 non-successfully if a write error occurred on stdout. (Bug#9574)
4135 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4137 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4140 * dispextern.h (struct it): Update the comment documenting what
4143 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4145 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4146 a display string, extend search for cursor position to end of row.
4147 (find_row_edges): If the row ends in a newline from a display
4148 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4149 Handle the case of a display string with multiple newlines.
4150 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4151 non-empty line. Fixes confusing cursor motion with arrow keys at
4152 the beginning of a line that starts with whitespace.
4154 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4156 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4159 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4161 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4164 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4166 * xdisp.c (display_line): Record maximum and minimum buffer
4167 positions even if no glyphs were produced (e.g., by a zero-width
4168 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4169 buffer positions that will be removed from the glyph row because
4171 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4172 column is beyond frame width: don't subtract 1 "pixel" when
4173 computing width of the stretch.
4174 (reseat_at_next_visible_line_start): Undo the change made on
4175 2011-09-17 that saved paragraph information and restored it after
4176 the call to `reseat'. (Bug#9545)
4178 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4180 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4181 and turn window cursor on if cleared (Bug#9415).
4183 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4185 * search.c (boyer_moore): Take unibyte characters from pattern
4186 literally. (Bug#9458)
4188 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4190 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4192 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4194 Fix minor problem found by static checking.
4195 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4196 initialized, to pacify gcc -Wuninitialized.
4198 * fileio.c: Report proper errno when syscall falls.
4199 (Finsert_file_contents): Save and restore errno,
4200 so that report_file_error outputs the correct diagnostic.
4201 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4203 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4205 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4207 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4209 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4210 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4212 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4214 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4215 about the current paragraph and restore it after the call to reseat.
4217 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4218 (bidi_find_paragraph_start): Search back for paragraph beginning
4219 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4220 (bidi_move_to_visually_next): Only trigger paragraph-related
4221 computations when the last character is a newline or at EOB, not
4222 just any NEUTRAL_B. (Bug#9470)
4224 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4225 truncated lines if point is covered by a display string. (Bug#9524)
4227 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4229 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4230 (cons_to_x_long): New function.
4231 (lisp_data_to_selection_data): Use it. Correct the test for
4232 short-versus-long data; it was negated. Break out of vector
4233 loop, for efficiency, when a long datum is discovered.
4235 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4237 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4239 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4241 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4242 GCC PR/17406) by declaring this function with external scope.
4244 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4246 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4247 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4249 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4251 * editfns.c (Fformat): Correctly handle text properties on "%%".
4253 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4255 * xterm.c (x_draw_composite_glyph_string_foreground):
4256 * w32term.c (x_draw_composite_glyph_string_foreground):
4257 * term.c (encode_terminal_code):
4258 * composite.c (composition_update_it, get_composition_id):
4259 * xdisp.c (get_next_display_element)
4260 (fill_composite_glyph_string): Add comments about special meaning
4261 of TAB characters in a composition.
4263 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4265 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4266 This occurs when processing a multibyte format.
4267 Problem reported by Wolfgang Jenker.
4269 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4271 * xdisp.c (try_cursor_movement): Only check for exact match if
4272 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4274 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4276 Remove unused external symbols.
4277 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4278 * xdisp.c (calc_pixel_width_or_height): Now static.
4279 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4280 * indent.c (check_display_width):
4281 * w32term.c: Fix comment to match code.
4282 * xterm.c, xterm.h (x_catching_errors): Remove.
4284 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4286 * xselect.c: Use signed conversions more consistently (Bug#9498).
4287 (selection_data_to_lisp_data): Assume incoming selection data are
4288 signed integers, not unsigned. This is to be consistent with
4289 outgoing selection data, which was modified to use signed integers
4290 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4291 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4292 expects long, not unsigned long.
4294 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4296 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4297 computation of loop end. Reported by Johan Bockgård
4300 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4302 * frame.c (Fother_visible_frames_p): Function deleted.
4304 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4306 * indent.c (compute_motion): Process display vector front to back
4307 rather than the other way around. (Bug#2496)
4309 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4311 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4313 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4315 * minibuf.c (Fread_from_minibuffer): Doc fix.
4317 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4319 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4320 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4322 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4324 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4325 value for non-existent files.
4327 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4329 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4330 set its "size" to -1. This will set the modtime_size field of
4331 the corresponding buffer to -1, which is what
4332 verify-visited-file-modtime expects for files that do not exist.
4335 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4337 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4339 * lisp.h: ... from here. push_key_description is no longer
4340 defined in keyboard.c, so its declaration should not be in
4341 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4342 logically belongs with push_key_description.
4344 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4346 * buffer.h: Include <sys/types.h> instead of <time.h>.
4347 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4348 Problem reported by Herbert J. Skuhra.
4350 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4352 * xml.c (parse_region): Make the parsing work for
4353 non-comment-starting XML files again (bug#9144).
4355 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4357 * image.c (gif_load): Fix calculation of bottom and right corner.
4360 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4362 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4363 redisplay in small windows.
4365 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4367 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4369 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4371 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4372 Operate on live windows only.
4374 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4376 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4378 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4380 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4381 only under bidi iteration.
4383 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4385 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4387 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4389 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4390 Without this fix, the command to link temacs failed due to an
4391 undefined symbol __builtin_isnan. This is because
4392 /usr/include/iso/math_c99.h #defines isnan(x) to
4393 __builtin_isnan(x), but the bundled gcc, which identifies itself
4394 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4396 * floatfns.c (isnan): #undef, and then #define to a clone of
4398 (Fisnan): Always define, since it's always available now.
4399 (syms_of_floatfns): Always define isnan at the Lisp level.
4401 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4403 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4405 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4407 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4408 The previous code assumed that file offsets (off_t values) fit in
4409 EMACS_INT variables, which is not true on typical 32-bit hosts.
4410 The code messed up by falsely reporting buffer overflow in cases
4411 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4412 when "big" contains more than 2**29 bytes, even though this
4413 inserts just one byte and does not overflow the buffer.
4414 (Finsert_file_contents): Store file offsets as off_t
4415 values, not as EMACS_INT values. Check for overflow when
4416 converting between EMACS_INT and off_t. When checking for
4417 buffer overflow or for overlap, take the offsets into account.
4418 Don't use EMACS_INT for small values where int suffices.
4419 When checking for overlap, fix a typo: ZV was used where
4420 ZV_BYTE was intended.
4421 (Fwrite_region): Don't assume off_t fits into 'long'.
4422 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4424 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4426 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4428 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4430 sprintf-related integer and memory overflow issues (Bug#9412).
4432 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4433 (esprintf, exprintf, evxprintf): New functions.
4434 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4435 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4436 (modify_event_symbol): Do not assume that the length of
4437 name_alist_or_stem is safe to alloca and fits in int.
4438 (Fexecute_extended_command): Likewise for function name and binding.
4439 (Frecursion_depth): Wrap around reliably on integer overflow.
4440 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4441 since some callers pass EMACS_INT values.
4442 (Fsingle_key_description): Don't crash if symbol name contains more
4443 than MAX_ALLOCA bytes.
4444 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4445 (get_minibuffer): Arg is now EMACS_INT, not int.
4446 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4447 (esprintf, exprintf, evxprintf): New decls.
4448 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4450 * dbusbind.c (signature_cat): New function.
4451 (xd_signature, Fdbus_register_signal):
4452 Do not overrun buffer; instead, report string overflow.
4454 * dispnew.c (add_window_display_history): Don't overrun buffer.
4455 Truncate instead; this is OK since it's just a log.
4457 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4458 even if the time zone offset is outlandishly large.
4459 Don't mishandle offset == INT_MIN.
4461 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4462 when creating daemon; the previous buffer-overflow check was incorrect.
4464 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4465 which has the guts of the old verror function.
4467 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4468 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4470 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4471 (font_unparse_xlfd): Don't blindly alloca long strings.
4472 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4473 fits in int, when using sprintf. Use single snprintf to count
4474 length of string rather than counting it via multiple sprintfs;
4475 that's simpler and more reliable.
4476 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4477 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4478 sprintf, in case result does not fit in int.
4480 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4481 (fontset_from_font): Print it.
4483 * frame.c (tty_frame_count): Now printmax_t, not int.
4484 (make_terminal_frame, set_term_frame_name): Print it.
4485 (x_report_frame_params): In X, window IDs are unsigned long,
4486 not signed long, so print them as unsigned.
4487 (validate_x_resource_name): Check for implausibly long names,
4488 and don't assume name length fits in 'int'.
4489 (x_get_resource_string): Don't blindly alloca invocation name;
4490 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4493 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4494 (xg_check_special_colors, xg_set_geometry):
4495 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4497 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4498 Use esprintf, not sprintf, in case result does not fit in int.
4500 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4501 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4502 it as a large positive number.
4503 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4504 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4506 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4507 in case result does not fit in int.
4509 * print.c (float_to_string): Detect width overflow more reliably.
4510 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4511 buffer overrun. Don't assume list length fits in 'int'. Treat
4512 print length of 0 as 0, not as infinity; to be consistent with other
4513 uses of print length in this function. Don't overflow print length
4514 index. Don't assume hash table size fits in 'long', or that
4515 vectorlike size fits in 'unsigned long'.
4517 * process.c (make_process): Use printmax_t, not int, to format
4518 process-name gensyms.
4520 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4522 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4523 to avoid potential buffer overrun.
4525 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4526 if X resource line is longer than 512 bytes.
4528 * xfns.c (x_window): Make sprintf buffer a bit bigger
4529 to avoid potential buffer overrun.
4531 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4533 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4535 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4537 Integer overflow fixes for scrolling, etc.
4538 Without these, Emacs silently mishandles large integers sometimes.
4539 For example, "C-u 4294967297 M-x recenter" was treated as if
4540 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4542 * xdisp.c (try_window_id): Check Emacs fixnum range before
4543 converting to 'int'.
4545 * window.c (window_scroll_line_based, Frecenter):
4546 Check that an Emacs fixnum is in range before assigning it to 'int'.
4547 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4548 values converted from Emacs fixnums.
4549 (Frecenter): Don't wrap around a line count if it is out of 'int'
4550 range; instead, treat it as an extreme value.
4551 (Fset_window_configuration, compare_window_configurations):
4552 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4554 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4555 that can exceed INT_MAX. Check that EMACS_INT value is in range
4556 before assigning it to the (possibly-narrower) index.
4557 (match_limit): Don't assume that a fixnum can fit in 'int'.
4559 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4562 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4563 (Fvertical_motion): Don't wrap around LINES values that don't fit
4564 in 'int'. Instead, treat them as extreme values. This is good
4565 enough for windows, which can't have more than INT_MAX lines anyway.
4567 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4569 * Require libxml/parser.h to avoid compilation warning.
4571 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4573 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4574 since this reportedly can destroy thread storage.
4576 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4578 * syntax.c (find_defun_start): Update all cache variables if
4579 exiting early (Bug#9401).
4581 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4583 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4585 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4586 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4587 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4589 * term.c (tty_append_glyph): New function.
4590 (produce_stretch_glyph): Static function and its prototype deleted.
4592 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4595 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4597 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4598 when checking :margin (Bug#9390).
4599 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4600 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4601 so that the name doesn't mislead. All uses changed.
4603 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4605 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4608 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4610 * xdisp.c (move_it_to): Don't bail out early when reaching
4611 position beyond to_charpos, if we are scanning backwards.
4612 (move_it_vertically_backward): When DY == 0, make sure we get to
4613 the first character in the line after the newline.
4615 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4617 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4618 (ccl_driver): Do not generate an out-of-range pointer.
4619 (Fccl_execute_on_string): Remove unnecessary check for
4620 integer overflow, noted by Stefan Monnier in
4621 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4622 Remove a FIXME that didn't need fixing.
4623 Simplify the newly-introduced buffer reallocation code.
4625 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4627 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4629 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4631 Integer and memory overflow issues (Bug#9196).
4633 * doc.c (get_doc_string): Rework so that
4634 get_doc_string_buffer_size is the actual buffer size, rather than
4635 being 1 less than the actual buffer size; this makes xpalloc more
4638 * image.c (x_allocate_bitmap_record, cache_image):
4639 * xselect.c (Fx_register_dnd_atom):
4640 Simplify previous changes by using xpalloc.
4642 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4643 since either will do and ptrdiff_t is convenient with xpalloc.
4645 * charset.c (charset_table_size)
4646 (struct charset_sort_data.priority): Now ptrdiff_t.
4647 (charset_compare): Don't overflow if priorities differ greatly.
4648 (Fsort_charsets): Don't assume list length fits in int.
4649 Check for size-calculation overflow when allocating sort data.
4650 (syms_of_charset): Allocate an initial charset table that is
4651 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4653 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4655 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4656 The actual value is always <= INT_MAX, and leaving it unsigned made
4657 overflow checking harder.
4659 * dispextern.h (struct glyph_matrix.rows_allocated)
4660 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4661 with xpalloc. The values are still always <= INT_MAX.
4663 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4665 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4666 (SAFE_NALLOCA): New macro.
4668 * region-cache.c (struct boundary.pos, find_cache_boundary)
4669 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4670 (set_cache_region, invalidate_region_cache)
4671 (revalidate_region_cache, know_region_cache, region_cache_forward)
4672 (region_cache_backward, pp_cache):
4673 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4674 so that ptrdiff_t * can be passed to xpalloc.
4675 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4676 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4677 (pp_cache): Don't assume cache_len fits in int.
4678 * region-cache.h: Adjust extern decls to match.
4680 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4681 EMACS_INT, since either will do, for xpalloc.
4683 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4684 (xnmalloc, xnrealloc, xpalloc): New functions.
4686 * bidi.c (bidi_shelve_header_size): New constant.
4687 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4688 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4690 * bidi.c (bidi_cache_shrink):
4691 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4693 Don't update size of array until after memory allocation succeeds,
4694 because xmalloc/xrealloc may not return.
4695 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4696 now that we have proper integer overflow checking.
4697 (record_overlay_string, overlay_strings): Catch overflows when
4698 calculating size of overlay_str_buf.
4700 * callproc.c (Fcall_process): Check for size overflow when
4701 calculating size of args2.
4702 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4703 Normally we prefer signed values, but sticking with ptrdiff_t would
4704 require adding more-complicated checks.
4706 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4707 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4708 Redo buffer-overflow calculations to avoid integer overflow.
4709 Add a FIXME comment where memory seems to be over-allocated.
4711 * character.c (Fstring): Check for size-calculation overflow.
4713 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4714 unnecessary integer overflow. Check for size overflow.
4715 (encode_coding_object): Don't update size until xmalloc succeeds.
4717 * composite.c (get_composition_id): Check for overflow in glyph
4718 length calculations.
4720 Integer and memory overflow fixes for display code.
4721 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4722 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4723 (scrolling_window): Check for overflow in size calculations.
4724 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4725 Don't assume glyph table len fits in int.
4726 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4727 (row_table_size): Now ptrdiff_t, not int.
4728 (scrolling_window): Avoid overflow in size calculations.
4729 Don't update size until allocation succeeds.
4730 * fns.c (concat): Check for overflow in size calculations.
4731 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4732 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4733 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4735 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4736 (get_doc_string): Check for size calculation overflow.
4737 Don't update size until allocation succeeds.
4738 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4739 EMACS_INT, where ptrdiff_t will do.
4740 (Fsubstitute_command_keys): Check for string overflow.
4742 * editfns.c (set_time_zone_rule): Don't assume environment length
4744 (message_length): Now ptrdiff_t, not int.
4745 (Fmessage_box): Don't update size until allocation succeeds.
4746 Don't assume message length fits in int.
4747 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4749 * emacs.c (main): Do not reallocate argv, since there is a null at
4750 the end that can be overwritten, and this way there's no need to
4751 worry about size-calculation overflow.
4752 (sort_args): Check for size-calculation overflow.
4754 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4756 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4758 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4759 (x_set_scroll_bar_width, x_figure_window_size):
4760 Check for integer overflow.
4761 (x_set_alpha): Do not assume XINT fits in int.
4763 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4764 This is for the members text_lines, text_cols, total_lines, total_cols,
4765 where the system imposes an 'int' limit.
4767 * fringe.c (Fdefine_fringe_bitmap):
4768 Don't update size until alloc works.
4770 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4771 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4773 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4774 Check for size-calculation overflow.
4775 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4776 do, as we prefer signed integers.
4777 (id_to_widget.max_size, id_to_widget.used)
4778 (xg_store_widget_in_map, xg_remove_widget_from_map)
4779 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4780 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4781 Use and return ptrdiff_t, not int.
4782 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4783 * gtkutil.h: Change prototypes to match the above.
4785 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4786 are duplicate now that they've been promoted to lisp.h.
4787 (x_allocate_bitmap_record, x_alloc_image_color)
4788 (make_image_cache, cache_image, xpm_load):
4789 Don't update size until alloc is done.
4790 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4792 Check for size calculation overflow.
4793 (ct_colors_allocated_max): New constant.
4794 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4797 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4798 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4799 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4800 Use ptrdiff_t, not int, to count maps.
4801 (read_char_minibuf_menu_prompt): Check for overflow in size
4802 calculations. Don't update size until allocation succeeds.
4803 Redo calculations to avoid overflow.
4804 * keyboard.h: Change prototypes to match the above.
4806 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4808 (current_minor_maps): Check for size calculation overflow.
4809 * keymap.h: Change prototypes to match the above.
4811 * lread.c (read1, init_obarray): Don't update size until alloc done.
4813 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4814 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4816 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4817 Now ptrdiff_t, not int.
4818 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4819 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4821 * process.c (Fnetwork_interface_list): Check for overflow
4822 in size calculation.
4824 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4826 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4827 overflow. Don't bother calling xmalloc when xrealloc will do.
4829 * search.c (Freplace_match): Check for size calculation overflow.
4830 (Fset_match_data): Don't assume list lengths fit in 'int'.
4832 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4833 for command line length. Do not attempt to address one before the
4834 beginning of an array, as that's not portable.
4836 * term.c (max_frame_lines): Remove; unused.
4837 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4839 (encode_terminal_code, calculate_costs): Check for size
4840 calculation overflow.
4841 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4842 table lengths and related sizes. Don't update size until alloc
4843 done. Redo calculations to avoid overflow.
4844 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4846 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4847 subtracting pointers.
4848 (gobble_line): Check for overflow more carefully. Don't update size
4851 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4852 Don't update size until alloc done.
4853 Redo size calculations to avoid overflow.
4854 Check for size calculation overflow.
4855 (main) [DEBUG]: Fix typo in invoking tparam1.
4857 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4858 Use ptrdiff_t, not int, for sizes.
4859 (store_mode_line_noprop_char): Don't update size until alloc done.
4861 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4862 Use ptrdiff_t, not int, for sizes.
4863 (Finternal_make_lisp_face, cache_face):
4864 Check for size calculation overflow.
4865 (cache_face): Treat size calculation overflows as if they were
4866 memory exhaustion (the usual treatment), rather than aborting.
4868 * xfns.c (x_encode_text, x_set_name_internal)
4869 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4870 sizes, since they can exceed INT_MAX in size. Check for size
4871 calculation overflow.
4873 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4874 (xg_select): Check for size calculation overflow.
4875 Don't update size until alloc done.
4877 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4878 as sprintf is limited to int lengths.
4880 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4881 (X_LONG_MIN): New macros.
4882 Use them to make the following changes clearer.
4883 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4884 This change doesn't affect the value now, but it may help remind
4885 future maintainers not to raise the value too much later.
4886 (SELECTION_QUANTUM): Remove, replacing with ...
4887 (selection_quantum): ... new function, which avoids overflow.
4889 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4890 assumption that selection length fits in 'int'.
4891 (x_reply_selection_request, x_handle_selection_request)
4892 (x_get_window_property, receive_incremental_selection)
4893 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4894 (lisp_data_to_selection_data, clean_local_selection_data):
4895 Use ptrdiff_t, not int, to record length of selection.
4896 (x_reply_selection_request, x_get_window_property)
4897 (receive_incremental_selection, x_property_data_to_lisp):
4898 Redo calculations to avoid overflow.
4899 (x_reply_selection_request): When sending hint, ceiling it at
4900 X_LONG_MAX rather than relying on wraparound overflow to send
4902 (x_get_window_property, receive_incremental_selection)
4903 (lisp_data_to_selection_data, x_property_data_to_lisp):
4904 Check for size-calculation overflow.
4905 (x_get_window_property, receive_incremental_selection)
4906 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4907 Don't store size until memory allocation succeeds.
4908 (x_get_window_property): Plug memory leak on memory exhaustion.
4909 Don't double-block input; malloc is safe here. Don't assume 2**34
4910 - 4 fits in unsigned long. Add an xassert to check
4911 XGetWindowProperty overflow. Be more careful about overflow
4912 calculations, and distinguish size from memory overflow better.
4913 (receive_incremental_selection): When tracing, don't assume
4914 unsigned int is less than INT_MAX.
4915 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4916 harmful) conversions of unsigned short to int.
4917 (lisp_data_to_selection_data): Don't assume that integers
4918 in the range -65535 through -1 fit in an X unsigned short.
4919 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4920 result parameters unless successful. Rely on cons_to_unsigned
4921 to report problems with elements; the old code wasn't right anyway.
4922 (x_check_property_data): Check for int overflow; we cannot use
4923 a wider type due to X limits.
4924 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4926 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4928 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4929 (x_term_init): Check for size calculation overflow.
4930 (x_color_cells): Don't store size until memory allocation succeeds.
4931 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4932 Don't assume alloca size is less than MAX_ALLOCA.
4933 (x_term_init): Don't assume length fits in int (sprintf is limited
4936 Use ptrdiff_t for composition IDs.
4937 * character.c (lisp_string_width):
4938 * composite.c (composition_table_size, n_compositions)
4939 (get_composition_id, composition_gstring_from_id):
4940 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4941 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4942 * window.c (Frecenter):
4943 Use ptrdiff_t, not int, for composition IDs.
4944 * composite.c (get_composition_id): Check for integer overflow.
4945 * composite.h: Adjust prototypes to match the above changes.
4947 Use ptrdiff_t for hash table indexes.
4948 * category.c (hash_get_category_set):
4949 * ccl.c (ccl_driver):
4950 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4951 * coding.c (coding_system_charset_list, detect_coding_system):
4952 * coding.h (struct coding_system.id):
4953 * composite.c (get_composition_id, gstring_lookup_cache):
4954 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4955 * image.c (xpm_get_color_table_h):
4956 * lisp.h (hash_lookup, hash_put):
4957 * minibuf.c (Ftest_completion):
4958 Use ptrdiff_t for hash table indexes, not int (which is too
4959 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4960 32-bit --with-wide-int hosts).
4962 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4963 Add a FIXME comment about memory leaks.
4964 (syms_of_charset): Don't assume xmalloc returns.
4966 Don't assume that stated character widths fit in int.
4967 * character.c (Fchar_width, c_string_width, lisp_string_width):
4968 * character.h (CHAR_WIDTH):
4969 * indent.c (MULTIBYTE_BYTES_WIDTH):
4970 Use sanitize_char_width to avoid undefined and/or bad behavior
4971 with outlandish widths.
4972 * character.h (sanitize_tab_width): Rename from sanitize_width,
4973 now that we have two such functions. All uses changed.
4974 (sanitize_char_width): New inline function.
4976 Don't assume that tab-width fits in int.
4977 * character.h (sanitize_width): New inline function.
4978 (SANE_TAB_WIDTH): New macro.
4979 (ASCII_CHAR_WIDTH): Use it.
4980 * indent.c (sane_tab_width): Remove. All uses replaced by
4981 SANE_TAB_WIDTH (current_buffer).
4982 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4984 * fileio.c: Integer overflow issues with file modes.
4985 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4987 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4988 Remove unreachable code.
4989 (read_hex, load_charset_map_from_file): Check for integer overflow.
4991 * xterm.c: Don't go over XClientMessageEvent limit.
4992 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4993 (x_send_scroll_bar_event): Likewise. Check that the size does not
4994 exceed limits imposed by XClientMessageEvent, as well as the usual
4995 ptrdiff_t and size_t limits.
4997 * keyboard.c: Overflow, signedness and related fixes.
4998 (make_lispy_movement): Use same integer type in forward decl
4999 that is used in the definition.
5000 (read_key_sequence, keyremap_step):
5001 Change bufsize argument back to int, undoing my 2011-03-30 change.
5002 We prefer signed types, and int is wide enough here.
5003 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5004 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5005 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5006 length, not size_t. Use ptrdiff_t for index, not int.
5007 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5008 possibility of integer overflow.
5010 Overflow, signedness and related fixes for images.
5012 * dispextern.h (struct it.stack[0].u.image.image_id)
5013 (struct_it.image_id, struct image.id, struct image_cache.size)
5014 (struct image_cache.used, struct image_cache.ref_count):
5015 * gtkutil.c (update_frame_tool_bar):
5016 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5017 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5018 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5019 * nsmenu.m (update_frame_tool_bar):
5020 * xdisp.c (calc_pixel_width_or_height):
5021 * xfns.c (image_cache_refcount):
5022 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5023 on typical 64-bit hosts.
5025 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5026 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5027 Omit unnecessary casts to int.
5028 (parse_image_spec): Check that integers fall into 'int' range
5029 when the callers expect that.
5030 (image_ascent): Redo ascent calculation to avoid int overflow.
5031 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5032 (lookup_image): Remove unnecessary tests.
5033 (xbm_image_p): Locals are now of int, not EMACS_INT,
5034 since parse_image_check makes sure they fit into int.
5035 (png_load, gif_load, svg_load_image):
5036 Prefer int to unsigned where either will do.
5037 (tiff_handler): New function, combining the cores of the
5038 old tiff_error_handler and tiff_warning_handler.
5039 This function is rewritten to use vsnprintf and thereby avoid
5040 stack buffer overflows. It uses only the features of vsnprintf
5041 that are common to both POSIX and native Microsoft.
5042 (tiff_error_handler, tiff_warning_handler): Use it.
5043 (tiff_load, gif_load, imagemagick_load_image):
5044 Don't assume :index value fits in 'int'.
5045 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5046 (imagemagick_load_image): Check that crop parameters fit into
5047 the integer types that MagickCropImage accepts. Don't assume
5048 Vimagemagick_render_type has a nonnegative value. Don't assume
5049 size_t fits in 'long'.
5050 (gs_load): Use printmax_t to print the widest integers possible.
5051 Check for integer overflow when computing image height and width.
5053 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5055 * xdisp.c (redisplay_window): Don't force window start if point
5056 will be invisible in the resulting window. (Bug#9324)
5058 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5060 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5061 the display spec is of the form `(space ...)'.
5062 (handle_display_spec): Return the value returned by
5063 handle_single_display_spec, not just 1 or zero.
5064 (handle_single_display_spec): If the display spec is of the form
5065 `(space ...)', and specifies display in the text area, return 2
5067 (try_cursor_movement): Check for the need to scroll more
5068 accurately, and prefer exact match for point under bidi.
5069 Don't advance `row' beyond the last row of the window.
5071 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5072 into disp_prop; all users changed.
5074 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5075 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5076 for the text covered by the display property.
5078 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5080 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5081 Change return value to nil.
5082 (Frecord_buffer): Delete unused function.
5084 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5086 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5087 buffers, return left-to-right.
5088 (set_cursor_from_row): Consider candidate row a win if its glyph
5089 represents a newline and point is on that newline. Fixes cursor
5090 positioning on the newline at EOL of R2L text within L2R
5091 paragraph, and vice versa.
5092 (try_cursor_movement): Check continued rows, in addition to
5093 continuation rows. Fixes unwarranted scroll when point enters a
5094 continued line of R2L text within an L2R paragraph, or vice versa.
5095 (cursor_row_p): Consider the case of point being equal to
5096 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5097 from the end of a short line to the beginning of a continued line
5098 of R2L text within L2R paragraph.
5099 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5100 composed characters.
5102 * bidi.c (bidi_check_type): Use xassert.
5103 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5106 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5108 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5111 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5113 * nsfont.m (ns_otf_to_script): Fix typo.
5115 2011-08-22 Kenichi Handa <handa@m17n.org>
5117 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5118 extra slot even if the purpose is char-code-property-table.
5120 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5122 * xdisp.c (redisplay_window): When computing centering_position,
5123 account for the height of the header line. (Bug#8874)
5125 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5126 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5127 candidate is selected by the mouse, and that candidate has a
5128 composed character under the mouse.
5130 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5131 coordinates reported by pos-visible-in-window-p for a composed
5132 character in column zero.
5134 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5136 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5138 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5140 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5141 consider it a hit if to_charpos is anywhere in the range of the
5142 composed buffer positions.
5144 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5146 * image.c (gif_load): Don't assume that each subimage has the same
5147 dimensions as the base image. Handle disposal method that is
5148 "undefined" by the gif spec (Bug#9335).
5150 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5152 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5153 (Fcondition_case): Document `debug' symbol in error handler.
5155 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5157 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5158 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5159 from an Org mode buffer to a Speedbar frame.
5161 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5162 a composition, take its buffer position from IT->cmp_it.charpos.
5163 Fixes cursor positioning at the beginning of a line that begins
5164 with a composed character.
5166 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5168 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5169 character bidirectional type, use STRONG_L instead. Fixes crashes
5170 in a buffer produced by `describe-categories'.
5172 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5173 members before the level stack, so they would be saved and
5174 restored when copying iterator state. Fixes incorrect reordering
5175 around TABs covered by display properties.
5177 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5179 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5181 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5183 * eval.c (internal_condition_case, internal_condition_case_1)
5184 (internal_condition_case_2, internal_condition_case_n):
5185 Remove unnecessary aborts (Bug#9081).
5187 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5189 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5190 has no `load' handler, try opening the file locally. (Bug#9311)
5192 2011-08-16 Ken Brown <kbrown@cornell.edu>
5194 * gmalloc.c: Expand comment.
5196 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5198 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5199 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5201 2011-08-16 Ken Brown <kbrown@cornell.edu>
5203 Fix memory allocation problems in Cygwin build (Bug#9273).
5205 * unexcw.c ( __malloc_initialized): Declare external variable.
5206 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5208 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5210 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5212 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5214 [CYGWIN] (special_realloc): New function.
5215 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5216 requests to realloc storage in the static heap.
5218 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5220 * bidi.c (bidi_initialize): Remove unused local.
5222 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5225 * biditype.h: Remove file.
5226 * makefile.w32-in ($(BLD)/bidi.$(O)):
5227 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5229 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5231 * chartab.c: Improve commentary for the uniprop_table API.
5233 * bidi.c (bidi_paragraph_init): Support zero value of
5234 bidi_ignore_explicit_marks_for_paragraph_level.
5235 (bidi_initialize): Use uniprop_table instead of including
5236 biditype.h and bidimirror.h.
5238 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5239 coordinates of the iterator when restoring from ppos_it.
5242 2011-08-14 Kenichi Handa <handa@m17n.org>
5244 * process.c (create_process): Call setup_process_coding_systems
5245 after the pid of the process is set to -1 (Bug#8162).
5247 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5249 * xdisp.c (move_it_in_display_line_to): Don't invoke
5250 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5251 ppos_it. Fixes vertical cursor motion when line beginning is
5252 covered by an image. (Bug#9296)
5254 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5256 * nsterm.h (ns_run_ascript): Declare.
5257 (NSAPP_DATA2_RUNASSCRIPT): Define.
5259 * nsfns.m (as_script, as_result, as_status): New static variables.
5260 (ns_run_ascript): New function.
5261 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5262 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5263 the event loop. Get status from as_status (Bug#7276).
5265 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5266 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5267 the event loop (Bug#7276).
5269 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5271 * gnutls.c (QCgnutls_bootprop_priority)
5272 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5273 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5274 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5275 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5276 (QCgnutls_bootprop_verify_hostname_error)
5277 (QCgnutls_bootprop_callbacks_verify): Rename from
5278 Qgnutls_bootprop_..., all uses changed.
5280 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5283 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5285 * xfaces.c (Qframe_set_background_mode): Now static.
5286 * dispextern.h (Qframe_set_background_mode): Remove decl.
5288 * process.c (Fnetwork_interface_info): Declare local only if needed.
5290 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5292 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5293 (Fnetwork_interface_list): Allocate in increments of bytes instead
5294 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5295 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5297 (struct ifflag_def): notrailers is smart on OSX.
5298 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5299 Get hardware address with getifaddrs if available.
5301 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5303 * xdisp.c (iterate_out_of_display_property): xassert that
5304 IT->position is set to within IT->object's boundaries. Break from
5305 the loop as soon as EOB is reached; avoids infloops in redisplay
5306 when IT->position is set up wrongly due to some bug.
5307 Set IT->current to match the bidi iterator unconditionally.
5308 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5309 entry. Force push_it to save on the stack the current
5310 buffer/string position, to be restored by pop_it. Fix flags in
5311 the iterator structure wrt the object coming from a display
5312 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5313 properties. (Bug#9284)
5315 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5317 * fontset.c (fontset_get_font_group): Add proper type checks.
5320 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5322 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5323 and LC_VERSION_MIN_MACOSX.
5324 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5325 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5327 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5329 * xdisp.c (forward_to_next_line_start): Allow to use the
5330 no-display-properties-and-no-overlays under bidi display.
5331 Set disp_pos in the bidi iterator to avoid searches for display
5332 properties and overlays.
5334 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5336 * editfns.c (Fset_time_zone_rule): Document relationship with the
5339 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5340 the font entity extracted from the cache (Bug#8109).
5342 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5344 * composite.c (autocmp_chars): Don't reset point. That is done by
5345 restore_point_unwind (Bug#5984).
5347 2011-08-07 Juri Linkov <juri@jurta.org>
5349 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5350 to show the arg `TIME' instead of `TIMEVAL'.
5352 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5354 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5355 display property strides EOL and includes a newline, as in
5356 longlines-mode. (Bug#9254)
5357 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5358 word-wrap under bidirectional display. (Bug#9224)
5360 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5361 is non-zero, even if the data buffer is NULL. Fixes a crash in
5362 vertical-motion with longlines-mode. (Bug#9254)
5364 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5366 * bidi.c <bidi_cache_total_alloc>: Now static.
5367 (bidi_initialize): Initialize bidi_cache_total_alloc.
5369 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5372 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5373 amount allocated this far in `bidi_cache_total_alloc'.
5374 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5375 non-zero, only free the data buffer without restoring the cache
5376 contents. All callers changed.
5378 * dispextern.h (bidi_unshelve_cache): Update prototype.
5380 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5381 (move_it_in_display_line, move_it_to)
5382 (move_it_vertically_backward, move_it_by_lines): Replace the call
5383 to xfree to an equivalent call to bidi_unshelve_cache.
5384 (move_it_in_display_line_to): Fix logic of returning
5385 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5387 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5389 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5390 came from a string character with a `cursor' property. (Bug#9229)
5392 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5394 * Makefile.in (LIB_PTHREAD): New variable.
5395 (LIBES): Add LIB_PTHREAD (Bug#9216).
5397 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5398 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5400 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5402 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5404 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5406 * xterm.c (x_find_topmost_parent): New function.
5407 (x_set_frame_alpha): Find topmost parent window with
5408 x_find_topmost_parent and set the property there also (bug#9181).
5409 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5411 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5413 * callproc.c (Fcall_process): Avoid vfork clobbering
5414 the local vars buffer, coding_systems, current_dir.
5416 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5418 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5420 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5422 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5423 so that it is not optimized away.
5425 * xdisp.c (compute_display_string_pos): Remove unused local.
5427 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5429 Fix slow cursor motion and scrolling in large buffers with
5430 selective display, like Org Mode buffers. (Bug#9218)
5432 * dispextern.h (struct bidi_it): New member disp_prop_p.
5434 * xdisp.c: Remove one-slot cache of display string positions.
5435 (compute_display_string_pos): Accept an additional argument
5436 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5437 for a display string or property. If found, set DISP_PROP_P
5440 * bidi.c (bidi_fetch_char): Accept an additional argument
5441 DISP_PROP_P, and pass it to compute_display_string_pos.
5442 Only handle text covered by a display string if DISP_PROP_P is returned
5443 non-zero. All callers of bidi_fetch_char changed.
5445 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5447 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5449 2010-12-03 Don March <don@ohspite.net>
5451 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5452 last character M-[char] is translated to ESC [char] (bug#7541).
5454 2011-08-02 Kenichi Handa <handa@m17n.org>
5456 * lisp.h (uniprop_table): Extern it.
5458 * chartab.c (uniprop_table): Make it non-static.
5460 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5462 * xdisp.c (forward_to_next_line_start): Accept additional argument
5463 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5465 (reseat_at_next_visible_line_start): Use the bidi iterator state
5466 returned by forward_to_next_line_start to restore the state of
5467 it->bidi_it after backing up to previous newline. (Bug#9212)
5469 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5471 * regex.c (re_comp): Protoize.
5472 (re_exec): Fix return type.
5473 (regexec): Fix type of `ret'. (Bug#9203)
5475 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5477 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5478 This is needed if max-image-size is a floating-point number.
5480 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5482 * print.c (print_object): Print empty symbol as ##.
5484 * lread.c (read1): Read ## as empty symbol.
5486 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5488 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5489 setting frame foreground color (Bug#9175).
5490 (x_set_background_color): Likewise.
5492 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5493 contents (Bug#9176).
5494 (EmacsTooltip -init): Remove bezels and add shadows to
5497 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5498 or scroll bar (Bug#8470).
5500 * nsfont.m (nsfont_open): Remove assignment to voffset and
5501 unnecessary vars hshink, expand, hd, full_height, min_height.
5502 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5504 * nsterm.h (nsfont_info): Remove voffset field.
5506 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5508 Implement strike-through and overline on NextStep (Bug#8863).
5510 * nsfont.m (nsfont_open): Use underline position provided by font,
5511 instead of hard-coded value of 2.
5512 (nsfont_draw): Call ns_draw_text_decoration instead.
5514 * nsterm.h: Add declaration for ns_draw_text_decoration.
5516 * nsterm.m (ns_draw_text_decoration): New function for drawing
5517 underline, overline, and strike-through.
5518 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5519 ns_draw_text_decoration. Change treatment of cursor drawing to
5520 accommodate underlining, etc.
5522 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5524 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5527 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5529 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5530 Without this fix, if a signal arrives just after memory fills up,
5531 'malloc' might be invoked reentrantly.
5533 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5534 In other words, assume that every image size is allowed, on non-X
5535 hosts. This assumption is probably wrong, but it lets Emacs compile.
5537 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5539 * regex.c (re_iswctype): Convert return values to boolean.
5541 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5543 * xdisp.c (compute_display_string_pos): Don't use cached display
5544 string position if the buffer had its restriction changed.
5547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5549 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5551 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5553 Integer signedness and overflow and related fixes. (Bug#9079)
5555 * bidi.c: Integer size and overflow fixes.
5556 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5557 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5558 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5559 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5560 (bidi_find_other_level_edge):
5561 Use ptrdiff_t instead of EMACS_INT where either will do.
5562 This works better on 32-bit hosts configured --with-wide-int.
5563 (bidi_cache_ensure_space): Check for size-calculation overflow.
5564 Use % rather than repeated addition, for better worst-case speed.
5565 Don't set bidi_cache_size until after xrealloc returns, because it
5567 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5568 (bidi_cache_ensure_space): Also check that the bidi cache size
5569 does not exceed that of the largest Lisp string or buffer. See Eli
5570 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5572 * alloc.c (__malloc_size_t): Remove.
5573 All uses replaced by size_t. See Andreas Schwab's note
5574 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5576 * image.c: Improve checking for integer overflow.
5577 (check_image_size): Assume that f is nonnull, since
5578 it is always nonnull in practice. This is one less thing to
5579 worry about when checking for integer overflow later.
5580 (x_check_image_size): New function, which checks for integer
5581 overflow issues inside X.
5582 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5583 This removes the need for a memory_full check.
5584 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5585 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5586 (xbm_read_bitmap_data): Change locals back to 'int', since
5587 their values must fit in 'int'.
5588 (xpm_load_image, png_load, tiff_load):
5589 Invoke x_create_x_image_and_pixmap earlier,
5590 to avoid much needless work if the image is too large.
5591 (tiff_load): Treat overly large images as if
5592 x_create_x_image_and_pixmap failed, not as malloc failures.
5593 (gs_load): Use x_check_image_size.
5595 * gtkutil.c: Omit integer casts.
5596 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5597 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5599 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5601 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5602 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5603 would wrongly return t on a 64-bit host.
5605 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5606 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5607 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5608 and therefore cause GCC to emit a bogus diagnostic in some cases.
5610 * image.c: Integer signedness and overflow and related fixes.
5611 This is not an exhaustive set of fixes, but it's time to
5612 record what I've got.
5613 (lookup_pixel_color, check_image_size): Remove redundant decls.
5614 (check_image_size): Don't assume that arbitrary EMACS_INT values
5615 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5616 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5617 (tiff_load, imagemagick_load_image):
5618 Check for overflow in size calculations.
5619 (x_create_x_image_and_pixmap): Remove unnecessary test for
5620 xmalloc returning NULL; that can't happen.
5621 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5622 (xpm_color_bucket): Use better integer hashing function.
5623 (xpm_cache_color): Don't possibly over-allocate memory.
5624 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5625 (gif_memory_source):
5626 Use ptrdiff_t, not int or size_t, to record sizes.
5627 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5628 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5629 either works, as we prefer signed integers.
5630 (tiff_read_from_memory, tiff_write_from_memory):
5631 Return tsize_t, not size_t, since that's what the TIFF API wants.
5632 (tiff_read_from_memory): Don't fail simply because the read would
5633 go past EOF; instead, return a short read.
5634 (tiff_load): Omit no-longer-needed casts.
5635 (Fimagemagick_types): Don't assume size fits into 'int'.
5637 Improve hashing quality when configured --with-wide-int.
5638 * fns.c (hash_string): New function, taken from sxhash_string.
5639 Do not discard information about ASCII character case; this
5640 discarding is no longer needed.
5641 (sxhash-string): Use it. Change sig to match it. Caller changed.
5642 * lisp.h: Declare it.
5643 * lread.c (hash_string): Remove, since we now use fns.c's version.
5644 The fns.c version returns a wider integer if --with-wide-int is
5645 specified, so this should help the quality of the hashing a bit.
5647 * emacs.c: Integer overflow minor fix.
5648 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5649 Define only if GNU_LINUX.
5650 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5652 * dispnew.c: Integer signedness and overflow fixes.
5653 Remove unnecessary forward decls, that were a maintenance hassle.
5654 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5656 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5657 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5658 (prepare_desired_row, line_draw_cost):
5659 Use int, not unsigned, where either works.
5660 (save_current_matrix, restore_current_matrix):
5661 Use ptrdiff_t, not size_t, where either works.
5662 (init_display): Check for overflow more accurately, and without
5663 relying on undefined behavior.
5665 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5666 Remove, replacing with the new symbols in lisp.h. All uses changed.
5667 * fileio.c (make_temp_name):
5668 * filelock.c (lock_file_1, lock_file):
5669 * xdisp.c (message_dolog):
5670 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5671 Use pMd etc. instead.
5672 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5673 replacing the pWIDE etc. symbols removed from editfns.c.
5675 * keyboard.h (num_input_events): Now uintmax_t.
5676 This is (very slightly) less likely to mess up due to wraparound.
5679 * buffer.c: Integer signedness fixes.
5680 (alloc_buffer_text, enlarge_buffer_text):
5681 Use ptrdiff_t rather than size_t when either will do, as we prefer
5684 * alloc.c: Integer signedness and overflow fixes.
5685 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5686 (__malloc_size_t): Default to size_t, not to int.
5687 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5688 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5689 Prefer ptrdiff_t to size_t when either would do, as we prefer
5691 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5692 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5693 Now const. Initialize with values that are in range even if char
5695 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5696 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5697 These functions do the right thing with sizes > 2**32.
5698 (check_depth): Now ptrdiff_t, not int.
5699 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5700 Adjust to new way of storing sizes. Check for size overflow bugs
5702 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5703 slightly wrong anyway, as it missed one instance of
5704 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5705 (refill_memory_reserve): Omit needless cast to size_t.
5706 (mark_object_loop_halt): Mark as externally visible.
5708 * xselect.c: Integer signedness and overflow fixes.
5709 (Fx_register_dnd_atom, x_handle_dnd_message):
5710 Use ptrdiff_t, not size_t, since we prefer signed.
5711 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5712 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5713 x_dnd_atoms_size and x_dnd_atoms_length.
5715 * doprnt.c: Prefer signed to unsigned when either works.
5717 * doprnt.c (doprnt):
5719 * xdisp.c (vmessage):
5720 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5721 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5722 prefer signed arithmetic to avoid comparison confusion.
5723 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5724 but is a bit tricky.
5726 Assume freestanding C89 headers, string.h, stdlib.h.
5727 * data.c, doprnt.c, floatfns.c, print.c:
5728 Include float.h unconditionally.
5729 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5730 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5731 * regex.c: Likewise for stddef.h, string.h.
5732 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5733 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5734 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5735 (STDC_HEADERS): Remove obsolete defines.
5736 * sysdep.c: Include limits.h unconditionally.
5738 Assume support for memcmp, memcpy, memmove, memset.
5739 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5740 * regex.c (memcmp, memcpy):
5741 Remove; we assume C89 now.
5743 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5744 (__malloc_safe_bcopy): Remove; no longer needed.
5746 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5747 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5748 well either way, and we prefer signed to unsigned.
5750 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5752 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5753 closes the connection while we're reading (bug#9182).
5755 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5757 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5758 are specified (Bug#9168).
5760 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5762 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5763 Found by GCC static checking and --with-wide-int on a 32-bit host.
5765 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (compute_display_string_pos): Fix logic of caching
5768 previous display string position. Initialize cached_prev_pos to
5769 -1. Fixes slow-down at the beginning of a buffer.
5771 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5773 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5774 for attrs[LFACE_FONTSET_INDEX].
5776 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5778 * xml.c (parse_region): Remove unused local
5779 that was recently introduced.
5781 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5783 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5784 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5786 * xdisp.c (move_it_in_display_line_to): Record the best matching
5787 position for TO_CHARPOS while scanning the line, and restore it on
5788 exit if none of the characters scanned was an exact match.
5789 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5790 when exact match is impossible due to invisible text, and the
5791 lines are truncated.
5793 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5795 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5798 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5800 Fix a significant slow-down of cursor motion with C-n, C-p,
5801 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5802 auto-repeat under bidi redisplay in fontified buffers.
5803 * xdisp.c (compute_stop_pos_backwards): New function.
5804 (next_element_from_buffer): Call compute_stop_pos_backwards to
5805 find a suitable prev_stop when we find ourselves before
5807 (reseat): Don't look for prev_stop, as that could mean a very long
5809 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5810 <cached_disp_overlay_modiff>: Cache for last found display string
5812 (compute_display_string_pos): Return the cached position if asked
5813 about the same buffer in the same area of character positions, and
5814 the buffer wasn't changed since the time the display string
5815 position was cached.
5817 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5819 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5820 is an integer, which is important for empty lines. (Bug#9149)
5822 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5824 * frame.c (Fmodify_frame_parameters): In tty case, update the
5825 default face if necessary (Bug#4238).
5827 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5829 * editfns.c (Fstring_to_char): No need to explain what a character
5830 is in the docstring (Bug#6576).
5832 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5834 * xml.c (parse_region): Make sure we always return a tree.
5836 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5838 * xml.c (parse_region): If a document contains only comments,
5841 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5843 * xml.c (make_dom): Return comments, too.
5845 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5848 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5849 and the surrounding thread.
5850 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5851 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5852 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5854 * s/openbsd.h (BROKEN_SIGIO): Define.
5855 * unexelf.c (unexec) [__OpenBSD__]:
5856 Don't update the .mdebug section of the Alpha COFF symbol table.
5858 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5860 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5863 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5865 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5866 This fixes some race conditions on the permissions of any newly
5869 * alloc.c (valid_pointer_p): Use pipe, not open.
5870 This fixes some permissions issues when debugging.
5872 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5873 If fchown fails to set both uid and gid, try to set just gid,
5874 as that is sometimes allowed. Adjust the file's mode to eliminate
5875 setuid or setgid bits that are inappropriate if fchown fails.
5877 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5879 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5880 to compare Lisp_Objects.
5881 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5882 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5883 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5885 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5887 * lread.c (read_integer): Unread even EOF character.
5888 (read1): Likewise. Properly record start position of symbol.
5890 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5891 symbol character follows.
5893 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5895 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5896 This works around a problem with the previous change to Fcopy_file.
5897 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5898 and without this change, GCC might complain about discarding
5899 fchown's return value.
5901 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5903 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5905 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5907 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5909 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5911 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5912 it's used from the C level.
5914 * process.c: Use the same condition for POLL_FOR_INPUT in both
5915 keyboard.c and process.c (bug#1858).
5917 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5919 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5920 (Fgnutls_boot): Use it.
5922 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5924 * doc.c (Fsubstitute_command_keys): Revert last change.
5926 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5928 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5929 quotes the next character, and doesn't affect other longer
5930 sequences (bug#8935).
5932 * lread.c (syms_of_lread): Clarify that is isn't only
5933 `eval-buffer' and `eval-defun' that's affected by
5934 `lexical-binding' (bug#8460).
5936 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5938 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5939 bidi redisplay when a line includes both an image and is truncated.
5941 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5943 Fix minor problems found by static checking.
5944 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5945 (elsz): Now a signed constant, not a size_t var. We prefer signed
5946 types to unsigned, to avoid integer comparison confusion. Without
5947 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5948 "cannot optimize loop, the loop counter may overflow", a symptom
5950 * indent.c (Fvertical_motion): Mark locals as initialized.
5951 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5953 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5955 * search.c (Fre_search_backward): Mention `case-fold-search' in
5956 all the re_search_* functions (bug#8138).
5958 * keyboard.c (Fopen_dribble_file): Document when the file is
5961 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5963 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5966 Support bidi reordering of display and overlay strings.
5967 * xdisp.c (compute_display_string_pos)
5968 (compute_display_string_end): Accept additional argument STRING.
5969 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5970 (reseat_to_string): Initialize bidi_it->string.s and
5971 bidi_it->string.schars.
5972 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5973 NULL (avoids a crash in bidi_paragraph_init).
5974 Initialize itb.string.lstring.
5975 (init_iterator): Call bidi_init_it only of a valid
5976 buffer position was specified. Initialize paragraph_embedding to
5978 (reseat_to_string): Initialize the bidi iterator.
5979 (display_string): If we need to ignore text properties of
5980 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5981 original value of -1 will not work with bidi.)
5982 (compute_display_string_pos): First arg is now struct
5983 `text_pos *'; all callers changed. Support display properties on
5985 (compute_display_string_end): Support display properties on Lisp
5987 (init_iterator, reseat_1, reseat_to_string): Initialize the
5988 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5989 when iterating on a string not from display properties).
5990 (compute_display_string_pos, compute_display_string_end):
5991 Fix calculation of the object to scan. Fixes an error when using
5993 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5994 base_level_stop; instead, set base_level_stop to BEGV.
5995 Fixes crashes in vertical-motion.
5996 (next_element_from_buffer): Improve commentary for when
5997 the iterator is before prev_stop.
5998 (init_iterator): Initialize bidi_p from the default value of
5999 bidi-display-reordering, not from buffer-local value. Use the
6000 buffer-local value only if initializing for buffer iteration.
6001 (handle_invisible_prop): Support invisible properties on strings
6002 that are being bidi-reordered.
6003 (set_iterator_to_next): Support bidi reordering of C strings and
6005 (next_element_from_string): Support bidi reordering of Lisp
6007 (handle_stop_backwards): Support Lisp strings as well.
6008 (display_string): Support display of R2L glyph rows.
6009 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6010 (init_iterator): Don't initialize it->bidi_p for strings
6012 (reseat_to_string): Initialize it->bidi_p for strings here.
6013 (next_element_from_string, next_element_from_c_string)
6014 (next_element_from_buffer): Add xassert's for correspondence
6015 between IT's object being iterated and it->bidi_it.string
6017 (face_before_or_after_it_pos): Support bidi iteration.
6018 (next_element_from_c_string): Handle the case of the first string
6019 character that is not the first one in the visual order.
6020 (get_visually_first_element): New function, refactored from common
6021 parts of next_element_from_buffer, next_element_from_string, and
6022 next_element_from_c_string.
6023 (tool_bar_lines_needed, redisplay_tool_bar)
6024 (display_menu_bar): Force left-to-right direction. Add a FIXME
6025 comment for making that be controlled by a user option.
6026 (push_it, pop_it): Save and restore the state of the
6027 bidi iterator. Save and restore the bidi_p flag.
6028 (pop_it): Iterate out of display property for string iteration as
6030 (iterate_out_of_display_property): Support iteration over strings.
6031 (handle_single_display_spec): Set up it->bidi_it for iteration
6032 over a display string, and call bidi_init_it.
6033 (handle_single_display_spec, next_overlay_string)
6034 (get_overlay_strings_1, push_display_prop): Set up the bidi
6035 iterator for displaying display or overlay strings.
6036 (forward_to_next_line_start): Don't use the shortcut if
6038 (back_to_previous_visible_line_start): If handle_display_prop
6039 pushed the iterator stack, restore the internal state of the bidi
6040 iterator by calling bidi_pop_it same number of times.
6041 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6042 and we are bidi-iterating, don't decrement the iterator position;
6043 instead, set the first_elt flag in the bidi iterator, to produce
6045 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6046 (push_display_prop): xassert that we are iterating a buffer.
6047 (push_it, pop_it): Save and restore paragraph_embedding member.
6048 (handle_single_display_spec, next_overlay_string)
6049 (get_overlay_strings_1, reseat_1, reseat_to_string)
6050 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6051 correctly. Don't assume unibyte strings are not bidi-reordered.
6052 (compute_display_string_pos)
6053 (compute_display_string_end): Fix handling the case of C string.
6054 (push_it, pop_it): Save and restore from_disp_prop_p.
6055 (handle_single_display_spec, push_display_prop): Set the
6056 from_disp_prop_p flag.
6057 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6058 (pop_it): Call iterate_out_of_display_property only if we are
6059 popping after iteration over a string that came from a display
6060 property. Fix a typo in popping stretch info. Add an assertion
6061 for verifying that the iterator position is in sync with the bidi
6063 (handle_single_display_spec, get_overlay_strings_1)
6064 (push_display_prop): Fix initialization of paragraph direction for
6065 string when that of the parent object is not yet determined.
6066 (reseat_1): Call bidi_init_it to resync the bidi
6067 iterator with IT's position. (Bug#7616)
6068 (find_row_edges): If ROW->start.pos gives position
6069 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6070 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6071 Reset the from_disp_prop_p flag.
6072 (SAVE_IT, RESTORE_IT): New macros.
6073 (pos_visible_p, face_before_or_after_it_pos)
6074 (back_to_previous_visible_line_start)
6075 (move_it_in_display_line_to, move_it_in_display_line)
6076 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6077 (try_scrolling, redisplay_window, display_line): Use them when
6078 saving a temporary copy of the iterator and restoring it back.
6079 (back_to_previous_visible_line_start, reseat_1)
6080 (init_iterator): Empty the bidi cache "stack".
6081 (move_it_in_display_line_to): If iterator ended up at
6082 EOL, but we never saw any buffer positions smaller than
6083 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6084 motion in bidi-reordered lines.
6085 (move_it_in_display_line_to): Record prev_method and prev_pos
6086 immediately before the call to set_iterator_to_next. Fixes cursor
6087 motion in bidi-reordered lines with stretch glyphs and strings
6088 displayed in margins. (Bug#8133) (Bug#8867)
6089 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6091 (pos_visible_p): Support positions in bidi-reordered lines.
6092 Save and restore bidi cache.
6094 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6095 (bidi_paragraph_info): Delete unused struct.
6096 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6097 (bidi_cache_start): New variable.
6098 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6100 (bidi_cache_fetch_state, bidi_cache_search)
6101 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6102 (bidi_cache_find, bidi_peek_at_next_level)
6103 (bidi_level_of_next_char, bidi_find_other_level_edge)
6104 (bidi_move_to_visually_next): Compare cache index with
6105 bidi_cache_start rather than with zero.
6106 (bidi_fetch_char): Accept new argument STRING; all callers
6107 changed. Support iteration over a string. Support strings with
6108 display properties. Support unibyte strings. Fix the type of
6109 `len' according to what STRING_CHAR_AND_LENGTH expects.
6110 (bidi_paragraph_init, bidi_resolve_explicit_1)
6111 (bidi_resolve_explicit, bidi_resolve_weak)
6112 (bidi_level_of_next_char, bidi_move_to_visually_next):
6113 Support iteration over a string.
6114 (bidi_set_sor_type, bidi_resolve_explicit_1)
6115 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6116 can now be zero (for strings); special values 0 and -1 were
6117 changed to -1 and -2, respectively.
6118 (bidi_char_at_pos): New function.
6119 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6120 Call it instead of FETCH_MULTIBYTE_CHAR.
6121 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6122 initialized to valid values.
6123 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6125 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6126 the test for valid cached positions. Fix the logic for looking up
6127 the sentinel state in the cache. GCPRO the Lisp string we are
6129 (bidi_push_it, bidi_pop_it): New functions.
6130 (bidi_initialize): Initialize the bidi cache start stack pointer.
6131 (bidi_cache_ensure_space): New function, refactored from part of
6132 bidi_cache_iterator_state. Don't assume the required size is just
6133 one BIDI_CACHE_CHUNK away.
6134 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6135 (bidi_count_bytes, bidi_char_at_pos): New functions.
6136 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6137 always valid if bidi_cache_idx is valid.
6138 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6139 is valid if it's going to be used.
6140 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6141 (bidi_cache_fetch_state, bidi_cache_search)
6142 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6143 (bidi_cache_iterator_state, bidi_cache_find)
6144 (bidi_find_other_level_edge, bidi_cache_start_stack):
6145 All variables related to cache indices are now EMACS_INT.
6147 * dispextern.h (struct bidi_string_data): New structure.
6148 (struct bidi_it): New member `string'. Make flag members be 1-bit
6149 fields, and put them last in the struct.
6150 (compute_display_string_pos, compute_display_string_end):
6152 (bidi_push_it, bidi_pop_it): Add prototypes.
6153 (struct iterator_stack_entry): New members bidi_p,
6154 paragraph_embedding, and from_disp_prop_p.
6155 (struct it): Member bidi_p is now a bit field 1 bit wide.
6156 (bidi_shelve_cache, bidi_unshelve_cache):
6159 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6160 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6161 and vector-like objects.
6163 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6164 cache around display iteration.
6166 * window.c (Fwindow_end, window_scroll_pixel_based)
6167 (displayed_window_lines, Frecenter): Save and restore the bidi
6168 cache around display iteration.
6170 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6172 * editfns.c (Fdelete_region): Clarify the use of the named
6173 parameters (bug#6788).
6175 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6177 * indent.c (Fvertical_motion): Set and restore w->pointm when
6178 saving and restoring the window's buffer (Bug#9006).
6180 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6182 * editfns.c (Fstring_to_char): Clarify just what is returned
6183 (bug#6576). Text by Eli Zaretskii.
6185 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6187 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6189 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6191 * buffer.c (mmap_find): Fix a typo.
6193 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6195 Fix execution of x selection hooks.
6196 * xselect.c (Qx_lost_selection_functions)
6197 (Qx_sent_selection_functions): New vars.
6198 (syms_of_xselect): DEFSYM them.
6199 (x_handle_selection_request): Pass Qx_sent_selection_functions
6200 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6201 (x_handle_selection_clear,x_clear_frame_selections):
6202 Pass Qx_lost_selection_functions rather than
6203 Vx_lost_selection_functions to Frun_hook_with_args.
6205 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6207 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6208 The old code sometimes used this field without initializing it.
6210 * alloc.c (gc_sweep): Don't read past end of array.
6211 In theory, the old code could also have corrupted Emacs internals,
6212 though it'd be very unlikely.
6214 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6216 * character.c (Fcharacterp): Don't advertise optional ignored
6217 argument. (Bug#4026)
6219 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6221 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6224 * window.c (Fset_window_start): Doc fix (bug#4199).
6225 (Fset_window_hscroll): Ditto.
6227 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6229 Fix minor new problems caught by GCC 4.6.1.
6230 * term.c (init_tty): Remove unused local.
6231 * xsettings.c (store_monospaced_changed): Define this function only
6232 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6235 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6237 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6239 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6241 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6242 are the mini-buffer and the echo area (bug#3320).
6244 * term.c (init_tty): Remove support for supdup, c10 and perq
6245 terminals, which are no longer supported (bug#1482).
6247 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6249 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6251 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6253 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6254 for non-popups (Bug#3642).
6256 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6258 * alloc.c (reset_malloc_hooks): Protoize.
6259 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6260 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6261 * cm.c (losecursor): Likewise.
6262 * data.c (fmod): Likewise.
6263 * dispnew.c (swap_glyphs_in_rows): Likewise.
6264 * emacs.c (memory_warning_signal): Likewise.
6265 * floatfns.c (float_error): Likewise.
6266 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6267 (otf_open, font_otf_capability, generate_otf_features)
6268 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6270 * image.c (pbm_read_file): Likewise.
6271 * indent.c (string_display_width): Likewise.
6272 * intervals.c (check_for_interval, search_for_interval)
6273 (inc_interval_count, count_intervals, root_interval)
6274 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6275 * lread.c (defalias): Likewise.
6276 * ralloc.c (r_alloc_check): Likewise.
6277 * regex.c (set_image_of_range_1, set_image_of_range)
6278 (regex_grow_registers): Likewise.
6279 * sysdep.c (strerror): Likewise.
6280 * termcap.c (valid_filename_p, tprint, main): Likewise.
6281 * tparam.c (main): Likewise.
6282 * unexhp9k800.c (run_time_remap, save_data_space)
6283 (update_file_ptrs, read_header, write_header, calculate_checksum)
6284 (copy_file, copy_rest, display_header): Likewise.
6285 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6287 * xdisp.c (check_it): Likewise.
6288 * xfaces.c (register_color, unregister_color, unregister_colors):
6290 * xfns.c (print_fontset_result): Likewise.
6291 * xrdb.c (member, fatal, main): Likewise.
6293 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6295 Fix minor problems found by static checking (Bug#9031).
6296 * chartab.c (char_table_set_range, map_sub_char_table):
6297 Remove unused locals.
6298 (uniprop_table): Now static.
6299 * composite.c (_work_char): Remove unused static var.
6301 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6303 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6305 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6307 * gtkutil.c (qttip_cb): Remove code without function.
6309 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6311 * w32.c (pthread_sigmask): New stub.
6313 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6315 Use pthread_sigmask, not sigprocmask (Bug#9010).
6316 sigprocmask is portable only for single-threaded applications, and
6317 Emacs can be multi-threaded when it uses GTK.
6318 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6320 * callproc.c (Fcall_process):
6321 * process.c (create_process):
6322 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6323 Use pthread_sigmask, not sigprocmask.
6325 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6327 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6328 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6331 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6333 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6334 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6335 (xg_hide_tooltip): Fix comment.
6337 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6338 in registerServicesMenuSendTypes.
6339 (validRequestorForSendType): Don't check ns_return_types.
6341 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6344 2011-07-08 Jason Rumney <jasonr@gnu.org>
6346 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6347 SH_SHOW for hidden windows (Bug#5482).
6349 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6350 frame struct members of non-existent frames (Bug#6284).
6352 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6354 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6355 variable firstTime not needed on OSX >= 10.6.
6356 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6357 >= 10.5. Use setKnobProportion, setDoubleValue.
6359 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6360 (MAC_OS_X_VERSION_10_5): Define if not defined.
6361 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6362 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6363 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6365 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6366 cString and lossyCString on OSX >= 10.4
6368 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6369 sizeToFit on OSX >= 10.2.
6371 * nsimage.m (allocInitFromFile): Don't use deprecated method
6372 bestRepresentationForDevice on OSX >= 10.6.
6374 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6377 * emacs.c: Declare unexec_init_emacs_zone.
6379 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6381 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6383 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6384 on svcsMenu (Bug#8842).
6386 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6388 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6390 * nsterm.m (QUTF8_STRING): Declare.
6391 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6392 (validRequestorForSendType): Return type is (id).
6393 Change indexOfObjectIdenticalTo to indexOfObject.
6394 Check if we have local selection before returning self (Bug#8842).
6395 (writeSelectionToPasteboard): Put local selection into paste board
6396 if we have a local selection (Bug#8842).
6397 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6399 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6400 (ns_get_local_selection): Declare.
6402 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6404 * keymap.c (describe_map_tree): Don't insert a double newline at
6405 the end of the buffer (bug#1169) and return whether we inserted
6408 * callint.c (Fcall_interactively): Change "reading args" to
6409 "providing args" to try to clarify what it does (bug#1010).
6411 2011-07-07 Kenichi Handa <handa@m17n.org>
6413 * composite.c (composition_compute_stop_pos): Ignore a static
6414 composition starting before CHARPOS (Bug#8915).
6416 * xdisp.c (handle_composition_prop): Likewise.
6418 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6420 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6423 2011-07-07 Kenichi Handa <handa@m17n.org>
6425 * character.h (unicode_category_t): New enum type.
6427 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6428 (Qchar_code_property_table): New variable.
6429 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6430 (UNIPROP_COMPRESSED_FORM_P): New macros.
6431 (char_table_ascii): Uncompress the compressed values.
6432 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6433 Uncompress the compressed values.
6434 (sub_char_table_ref_and_range): Likewise.
6435 (char_table_ref_and_range): Uncompress the compressed values.
6436 (sub_char_table_set): New arg is_uniprop. Callers changed.
6437 Uncompress the compressed values.
6438 (sub_char_table_set_range): Args changed. Callers changed.
6439 (char_table_set_range): Adjuted for the above change.
6440 (map_sub_char_table): Delete args default_val and parent. Add arg
6441 top. Give decoded values to a Lisp function.
6442 (map_char_table): Adjust for the above change. Give decoded
6443 values to a Lisp function. Gcpro more variables.
6444 (uniprop_table_uncompress)
6445 (uniprop_decode_value_run_length): New functions.
6446 (uniprop_decoder, uniprop_decoder_count): New variables.
6447 (uniprop_get_decoder, uniprop_encode_value_character)
6448 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6450 (uniprop_encoder, uniprop_encoder_count): New variables.
6451 (uniprop_get_encoder, uniprop_table)
6452 (Funicode_property_table_internal, Fget_unicode_property_internal)
6453 (Fput_unicode_property_internal): New functions.
6454 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6455 Sunicode_property_table_internal, Sget_unicode_property_internal,
6456 and Sput_unicode_property_internal. Defvar_lisp
6457 char-code-property-alist.
6459 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6460 Vunicode_category_table.
6462 * font.c (font_range): Adjust for the change of
6463 Vunicode_category_table.
6465 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6467 * m/iris4d.h: Remove file, move contents ...
6468 * s/irix6-5.h: ... here.
6470 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6472 Remove unportable assumption about struct layout (Bug#8884).
6473 * alloc.c (mark_buffer):
6474 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6475 (clone_per_buffer_values): Don't assume that
6476 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6477 This isn't true in general, and it's particularly not true
6478 if Emacs is configured with --with-wide-int.
6479 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6480 New macros, used in the buffer.c change.
6482 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6484 * xsettings.c: Use both GConf and GSettings if both are available.
6485 (store_config_changed_event): Add comment.
6486 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6487 (store_tool_bar_style_changed): New functions.
6488 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6489 (struct xsettings): Move font inside HAVE_XFT.
6490 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6491 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6492 Move inside HAVE_XFT.
6493 (something_changed_gsettingsCB): Rename from something_changedCB.
6494 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6496 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6497 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6498 (something_changed_gconfCB): Rename from something_changedCB.
6499 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6500 (parse_settings): Move check for font inside HAVE_XFT.
6501 (read_settings, apply_xft_settings): Add comment.
6502 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6503 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6504 call store_font_name_changed.
6505 (xft_settings_event): Add comment.
6506 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6507 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6508 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6509 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6510 (xsettings_initialize): Call init_gsettings last.
6511 (xsettings_get_system_font, xsettings_get_system_normal_font):
6514 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6516 Random fixes. E.g., (random) never returned negative values.
6517 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6518 subseconds part to the entropy, as that's a bit more random.
6519 Prefer signed to unsigned, since the signedness doesn't matter and
6520 in general we prefer signed. When given a limit, use a
6521 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6522 latter isn't right if USE_2_TAGS_FOR_INTS.
6523 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6524 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6526 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6528 * textprop.c (text_property_stickiness):
6529 Obey Vtext_property_default_nonsticky.
6530 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6531 * w32fns.c (syms_of_w32fns):
6532 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6534 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6536 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6537 This is more efficient than Ffile_directory_p and avoids a minor race.
6539 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6541 * buffer.c (Foverlay_put): Say what the return value is
6544 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6545 is a directory before asking whether to use the file name
6547 (barf_or_query_if_file_exists): Make the "File is a directory"
6548 error be more correct.
6550 * fns.c (Frequire): Remove the mention of the .gz files, since
6551 that's installation-specific, but keep the mention of
6552 `get-load-suffixes'.
6554 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6556 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6557 Report string overflow if the output is too long.
6559 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6561 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6562 (syms_of_gnutls): Remove duplicate DEFSYM for
6563 Qgnutls_bootprop_verify_hostname_error, an error for
6564 Qgnutls_bootprop_verify_error (which is no longer used).
6566 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6567 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6568 Also (re)move comments that are misplaced or no longer relevant.
6570 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6572 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6574 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6576 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6577 and background color parameters if they have been changed.
6579 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6581 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6583 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6585 * xsettings.c (SYSTEM_FONT): Define only when used.
6586 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6588 * keymap.c (access_keymap_1): Now static.
6590 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6592 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6593 leave any prefix arg for the up event (Bug#1586).
6595 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6597 * lread.c (syms_of_lread): Mention single symbols defined by
6598 `defvar' or `defconst' (bug#7154).
6600 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6601 (Frequire): Mention get-load-suffixes.
6603 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6605 * window.h (window): Remove clone_number slot.
6606 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6608 (make_parent_window, make_window, saved_window)
6609 (Fset_window_configuration, save_window_save): Don't deal with
6611 * buffer.c (Qclone_number): Remove declaration.
6612 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6614 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6616 Add multiple inheritance to keymaps.
6617 * keymap.c (Fmake_composed_keymap): New function.
6618 (Fset_keymap_parent): Simplify.
6619 (fix_submap_inheritance): Remove.
6620 (access_keymap_1): New function extracted from access_keymap to handle
6621 embedded parents and handle lists of maps.
6622 (access_keymap): Use it.
6623 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6624 (Fcopy_keymap): Handle embedded parents.
6625 (Fcommand_remapping, define_as_prefix): Simplify.
6626 (Fkey_binding): Simplify.
6627 (syms_of_keymap): Move minibuffer-local-completion-map,
6628 minibuffer-local-filename-completion-map,
6629 minibuffer-local-must-match-map, and
6630 minibuffer-local-filename-must-match-map to Elisp.
6631 (syms_of_keymap): Defsubr make-composed-keymap.
6632 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6633 (parse_menu_item): Trivial simplification.
6635 2011-07-01 Glenn Morris <rgm@gnu.org>
6637 * Makefile.in (SETTINGS_LIBS): Fix typo.
6639 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6641 * coding.c (Fencode_coding_string): Record the last coding system
6642 used, as the function doc string says (bug#8738).
6644 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6646 * xsettings.c (store_monospaced_changed): Take new font as arg and
6647 check for change against current_mono_font.
6648 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6649 (emacs_settings_constructor, emacs_settings_get_property)
6650 (emacs_settings_set_property, emacs_settings_class_init)
6651 (emacs_settings_init, gsettings_obj): Remove.
6652 (something_changedCB): New function for HAVE_GSETTINGS.
6653 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6654 with value as argument.
6655 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6656 g_settings_new (Bug#8967). Do not create gsettings_obj.
6657 Remove calls to g_settings_bind. Connect something_changedCB to
6660 * xgselect.c: Add defined (HAVE_GSETTINGS).
6661 (xgselect_initialize): Ditto.
6663 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6664 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6667 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6669 * eval.c (struct backtrace): Simplify and port the data structure.
6670 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6671 signed bit field, as this assumption is not portable and it makes
6672 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6673 "char debug_on_exit : 1" as this is not portable either; instead,
6674 use the portable "unsigned int debug_on_exit : 1". Remove unused
6675 member evalargs. Remove obsolete comments about cc bombing out.
6677 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6679 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6680 Let HAVE_GSETTINGS override HAVE_GCONF.
6681 (store_monospaced_changed): New function.
6682 (EMACS_SETTINGS): A new type derived from GObject to handle
6683 GSettings notifications.
6684 (emacs_settings_constructor, emacs_settings_get_property)
6685 (emacs_settings_set_property, emacs_settings_class_init):
6687 (gsettings_client, gsettings_obj): New variables.
6688 (GSETTINGS_SCHEMA): New define.
6689 (something_changedCB): Call store_monospaced_changed.
6690 (init_gsettings): New function.
6691 (xsettings_initialize): Call init_gsettings.
6692 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6695 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6698 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6700 * window.c (resize_root_window, grow_mini_window)
6701 (shrink_mini_window): Rename Qresize_root_window to
6702 Qwindow_resize_root_window and Qresize_root_window_vertically to
6703 Qwindow_resize_root_window_vertically.
6705 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6707 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6709 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6711 * makefile.w32-in: Redesign dependencies so they reflect more
6712 clearly which files are directly included by each source file,
6713 and not through other includes.
6715 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6717 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6718 (sort_overlays, overlay_strings): When an overlay's clone number
6719 matches the window's clone number process the overlay even if
6720 the overlay's window property doesn't match the current window.
6722 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6723 (Fwindow_hchild): Rename to Fwindow_left_child.
6724 (Fwindow_next): Rename to Fwindow_next_sibling.
6725 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6726 (resize_window_check): Rename to window_resize_check.
6727 (resize_window_apply): Rename to window_resize_apply.
6728 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6729 (Fdelete_other_windows_internal, resize_frame_windows)
6730 (Fsplit_window_internal, Fdelete_window_internal)
6731 (grow_mini_window, shrink_mini_window)
6732 (Fresize_mini_window_internal): Fix callers accordingly.
6734 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6736 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6737 (emacs_fixed_set_min_size): Remove.
6738 (emacs_fixed_new): Take frame as argument.
6740 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6741 (_EmacsFixedPrivate): Remove minwidth/height.
6742 Add struct frame *f.
6743 (emacs_fixed_init): Initialize priv->f.
6744 (get_parent_class, emacs_fixed_set_min_size): Remove.
6745 (emacs_fixed_new): Set priv->f to argument.
6746 (emacs_fixed_get_preferred_width)
6747 (emacs_fixed_get_preferred_height): Use min_width/height from
6748 frames size_hint to set minimum and natural (Bug#8919).
6749 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6750 and use min_width/height from frames size_hint to set
6751 min_width/height (Bug#8919).
6753 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6754 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6757 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6759 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6760 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6763 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6765 * process.c (wait_reading_process_output): Bypass select if
6766 waiting for a cell while ignoring keyboard input, and input is
6767 pending. Suggested by Jan Djärv (Bug#8869).
6769 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6771 Use gnulib's dup2 module instead of rolling our own.
6772 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6774 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6776 * dispnew.c (scrolling_window): Before scrolling, turn off a
6777 mouse-highlight in the window being scrolled.
6779 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6781 Move DEFSYM to lisp.h and use everywhere.
6783 * character.h (DEFSYM): Move declaration...
6784 * lisp.h (DEFSYM): ...here.
6790 * w32select.c: Don't include character.h.
6792 * alloc.c (syms_of_alloc):
6793 * buffer.c (syms_of_buffer):
6794 * bytecode.c (syms_of_bytecode):
6795 * callint.c (syms_of_callint):
6796 * casefiddle.c (syms_of_casefiddle):
6797 * casetab.c (init_casetab_once):
6798 * category.c (init_category_once, syms_of_category):
6799 * ccl.c (syms_of_ccl):
6800 * cmds.c (syms_of_cmds):
6801 * composite.c (syms_of_composite):
6802 * dbusbind.c (syms_of_dbusbind):
6803 * dired.c (syms_of_dired):
6804 * dispnew.c (syms_of_display):
6805 * doc.c (syms_of_doc):
6806 * editfns.c (syms_of_editfns):
6807 * emacs.c (syms_of_emacs):
6808 * eval.c (syms_of_eval):
6809 * fileio.c (syms_of_fileio):
6810 * fns.c (syms_of_fns):
6811 * frame.c (syms_of_frame):
6812 * fringe.c (syms_of_fringe):
6813 * insdel.c (syms_of_insdel):
6814 * keymap.c (syms_of_keymap):
6815 * lread.c (init_obarray, syms_of_lread):
6816 * macros.c (syms_of_macros):
6817 * msdos.c (syms_of_msdos):
6818 * print.c (syms_of_print):
6819 * process.c (syms_of_process):
6820 * search.c (syms_of_search):
6821 * sound.c (syms_of_sound):
6822 * syntax.c (init_syntax_once, syms_of_syntax):
6823 * terminal.c (syms_of_terminal):
6824 * textprop.c (syms_of_textprop):
6825 * undo.c (syms_of_undo):
6826 * w32.c (globals_of_w32):
6827 * window.c (syms_of_window):
6828 * xdisp.c (syms_of_xdisp):
6829 * xfaces.c (syms_of_xfaces):
6830 * xfns.c (syms_of_xfns):
6831 * xmenu.c (syms_of_xmenu):
6832 * xsettings.c (syms_of_xsettings):
6833 * xterm.c (syms_of_xterm): Use DEFSYM.
6835 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6837 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6839 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6841 Integer and buffer overflow fixes (Bug#8873).
6843 * print.c (printchar, strout): Check for string overflow.
6844 (PRINTPREPARE, printchar, strout):
6845 Don't set size unless allocation succeeds.
6847 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6848 for sizes. Check for string overflow more accurately.
6849 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6851 * macros.c: Integer and buffer overflow fixes.
6852 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6853 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6854 Use ptrdiff_t, not int, for sizes.
6855 Don't increment bufsize until after realloc succeeds.
6856 Check for size-calculation overflow.
6857 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6859 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6861 * lread.c: Integer overflow fixes.
6862 (read_integer): Radix is now EMACS_INT, not int,
6863 to improve quality of diagnostics for out-of-range radices.
6864 Calculate buffer size correctly for out-of-range radices.
6865 (read1): Check for integer overflow in radices, and in
6866 read-circle numbers.
6867 (read_escape): Avoid int overflow.
6868 (Fload, openp, read_buffer_size, read1)
6869 (substitute_object_recurse, read_vector, read_list, map_obarray):
6870 Use ptrdiff_t, not int, for sizes.
6871 (read1): Use EMACS_INT, not int, for sizes.
6872 Check for size overflow.
6874 * image.c (cache_image): Check for size arithmetic overflow.
6876 * lread.c: Integer overflow issues.
6877 (saved_doc_string_size, saved_doc_string_length)
6878 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6879 Now ptrdiff_t, not int.
6880 (read1): Don't assume doc string length fits in int. Check for
6881 out-of-range doc string lengths.
6882 (read_list): Don't assume file position fits in int.
6883 (read_escape): Check for hex character overflow.
6885 2011-06-22 Leo Liu <sdl.web@gmail.com>
6887 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6888 Move to minibuffer.el.
6890 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6892 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6893 The following patches are for when GLYPH_DEBUG && !XASSERT.
6894 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6895 * dispnew.c (flush_stdout):
6896 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6897 Mark as externally visible.
6898 * dispnew.c (check_window_matrix_pointers): Now static.
6899 * dispnew.c (window_to_frame_vpos):
6900 * xfns.c (unwind_create_frame):
6901 * xterm.c (x_check_font): Remove unused local.
6902 * scroll.c (CHECK_BOUNDS):
6903 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6904 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6905 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6906 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6907 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6909 (debug_method_add): Use va_list and vsprintf rather than relying
6910 on undefined behavior with wrong number of arguments.
6911 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6912 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6913 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6914 since we're not interested in debugging glyphs with old libraries.
6915 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6916 GCC 4.6.0's static checking.
6918 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6920 Integer overflow and signedness fixes (Bug#8873).
6921 A few related buffer overrun fixes, too.
6923 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6925 * dispextern.h (struct face.stipple):
6926 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6927 (x_bitmap_mask, x_allocate_bitmap_record)
6928 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6929 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6930 (x_create_bitmap_from_xpm_data):
6931 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6932 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6934 * xfaces.c (load_pixmap):
6935 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6936 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6937 (.bitmaps_last, struct x_output.icon_bitmap):
6938 Use ptrdiff_t, not int, for bitmap indexes.
6939 (x_allocate_bitmap_record): Check for size overflow.
6940 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6942 Use ptrdiff_t, not int, for overlay counts.
6943 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6944 * editfns.c (overlays_around, get_pos_property):
6945 * textprop.c (get_char_property_and_overlay):
6946 * xdisp.c (next_overlay_change, note_mouse_highlight):
6947 * xfaces.c (face_at_buffer_position):
6948 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6949 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6950 (Fnext_overlay_change, Fprevious_overlay_change)
6951 (mouse_face_overlay_overlaps, Foverlays_in):
6952 Use ptrdiff_t, not int, for sizes.
6953 (overlays_at, overlays_in): Check for size-calculation overflow.
6955 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6957 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6958 (x_session_initialize): Do not assume string length fits in int.
6960 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6961 This is unlikely, but can occur if DPI is outlandish.
6963 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6964 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6966 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6967 * xrdb.c (magic_file_p, search_magic_path):
6968 Omit last arg SUFFIX; it was always 0. All callers changed.
6969 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6971 * xfont.c (xfont_match): Avoid need for strlen.
6973 * xfns.c: Don't assume strlen fits in int.
6974 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6976 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6977 not unsigned long, as we prefer signed integers. All callers changed.
6978 Detect integer overflow in repeat count.
6979 (message_dolog): Don't assume print length fits in 39 bytes.
6980 (display_mode_element): Don't assume strlen fits in int.
6982 * termcap.c: Don't assume sizes fit in int and never overflow.
6983 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6984 (gobble_line): Check for size-calculation overflow.
6986 * minibuf.c (Fread_buffer):
6987 * lread.c (intern, intern_c_string):
6988 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6989 Don't assume string length fits in int.
6991 * keyboard.c (parse_tool_bar_item):
6992 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6994 * font.c: Don't assume string length fits in int.
6995 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6996 Use ptrdiff_t, not int.
6997 (font_intern_prop): Don't assume string length fits in int.
6998 Don't assume integer property fits in fixnum.
6999 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7001 * filelock.c: Fix some buffer overrun and integer overflow issues.
7002 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7003 Reformulate so as not to need the command string.
7004 Invoke gzip -cd rather than gunzip, as it's more portable.
7005 (lock_info_type, lock_file_1, lock_file):
7006 Don't assume pid_t and time_t fit in unsigned long.
7007 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7008 (current_lock_owner): Prefer signed type for sizes.
7009 Use memcpy, not strncpy, where memcpy is what is really wanted.
7010 Don't assume (via atoi) that time_t and pid_t fit in int.
7011 Check for time_t and/or pid_t out of range, e.g., via a network share.
7012 Don't alloca where an auto var works fine.
7014 * fileio.c: Fix some integer overflow issues.
7015 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7016 Don't assume string length fits in int.
7017 (directory_file_name): Don't assume string length fits in long.
7018 (make_temp_name): Don't assume pid fits in int, or that its print
7019 length is less than 20.
7021 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7023 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7025 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7027 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7028 We prefer signed integers, even for size calculations.
7030 * emacs.c: Don't assume string length fits in 'int'.
7031 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7032 (main): Don't invoke strlen when not needed.
7034 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7035 (XD_DEBUG_MESSAGE): Don't waste a byte.
7037 * callproc.c (getenv_internal_1, getenv_internal)
7039 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7041 * lread.c (invalid_syntax): Omit length argument.
7042 All uses changed. This doesn't fix a bug, but it simplifies the
7043 code away from its former Hollerith-constant appearance, and it's
7044 one less 'int' to worry about when looking at integer-overflow issues.
7045 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7047 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7048 This didn't break anything, but it didn't help either.
7049 It's confusing to put a bogus integer in a place where the actual
7050 value does not matter.
7051 (LIST_END_P): Remove unused macro and its bogus comment.
7052 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7054 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7055 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7057 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7058 We prefer signed types, and the value cannot exceed the EMACS_INT
7059 range anyway (because otherwise the length would not be representable).
7060 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7061 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7062 This avoids a GCC warning when WIDE_EMACS_INT.
7064 * indent.c (sane_tab_width): New function.
7065 (current_column, scan_for_column, Findent_to, position_indentation)
7066 (compute_motion): Use it. This is just for clarity.
7067 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7069 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7071 * lisp.h (lint_assume): New macro.
7072 * composite.c (composition_gstring_put_cache):
7073 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7075 * editfns.c, insdel.c:
7076 Omit unnecessary forward decls, to simplify future changes.
7078 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7080 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7082 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7083 Use much-faster test for byte-length change.
7084 Don't assume string byte-length fits in 'int'.
7085 Check that character arg fits in 'int'.
7086 (mapcar1): Declare byte as byte, for clarity.
7088 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7090 * fns.c (concat): Catch string overflow earlier.
7091 Do not rely on integer wraparound.
7093 * dispextern.h (struct it.overlay_strings_charpos)
7094 (struct it.selective): Now EMACS_INT, not int.
7095 * xdisp.c (forward_to_next_line_start)
7096 (back_to_previous_visible_line_start)
7097 (reseat_at_next_visible_line_start, next_element_from_buffer):
7098 Don't arbitrarily truncate the value of 'selective' to int.
7100 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7102 * composite.c: Don't truncate sizes to 'int'.
7103 (composition_gstring_p, composition_reseat_it)
7104 (composition_adjust_point): Use EMACS_INT, not int.
7105 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7106 not EMACS_UINT, for indexes.
7108 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7110 * buffer.c: Include <verify.h>.
7111 (struct sortvec.priority, struct sortstr.priority):
7112 Now EMACS_INT, not int.
7113 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7114 (struct sortstr.size, record_overlay_string)
7115 (struct sortstrlist.size, struct sortlist.used):
7116 Don't truncate size to int.
7117 (record_overlay_string): Check for size-calculation overflow.
7118 (init_buffer_once): Check at compile-time, not run-time.
7120 2011-06-22 Jim Meyering <meyering@redhat.com>
7122 Don't leak an XBM-image-sized buffer
7123 * image.c (xbm_load): Free the image buffer after using it.
7125 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7128 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7129 that Sun C diagnosed.
7130 * fns.c (secure_hash): Fix pointer signedness issue.
7131 * intervals.c (static_offset_intervals): New function.
7132 (offset_intervals): Use it.
7134 2011-06-21 Leo Liu <sdl.web@gmail.com>
7137 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7140 * fns.c (secure_hash): Rename from crypto_hash_function and change
7141 the first arg to accept symbols.
7142 (Fsecure_hash): New primitive.
7143 (syms_of_fns): New symbols.
7145 2011-06-20 Deniz Dogan <deniz@dogan.se>
7147 * process.c (Fset_process_buffer): Clarify return value in
7150 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7152 * dispnew.c (add_window_display_history): Use BVAR.
7154 * xdisp.c (debug_method_add): Use BVAR.
7155 (check_window_end, dump_glyph_matrix, dump_glyph)
7156 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7158 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7161 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7162 check till after the cache is created in init_frame_faces.
7164 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7166 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7168 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7170 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7171 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7172 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7174 Improve buffer-overflow checking (Bug#8873).
7175 * fileio.c (Finsert_file_contents):
7176 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7177 Remove the old (too-loose) buffer overflow checks.
7178 They weren't needed, since make_gap checks for buffer overflow.
7179 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7180 The old code merely checked for Emacs fixnum overflow, and relied
7181 on undefined (wraparound) behavior. The new code avoids undefined
7182 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7184 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7185 Tune. Don't use wider integers than needed. Don't use alloca.
7186 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7188 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7190 * insdel.c, lisp.h (buffer_overflow): New function.
7191 (insert_from_buffer_1, replace_range, replace_range_2):
7192 * insdel.c (make_gap_larger):
7193 * editfns.c (Finsert_char):
7194 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7196 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7198 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7200 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7202 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7203 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7205 * fileio.c: Don't assume EMACS_INT fits in off_t.
7206 (emacs_lseek): New static function.
7207 (Finsert_file_contents, Fwrite_region): Use it.
7208 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7210 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7212 * fns.c: Don't overflow int when computing a list length.
7213 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7214 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7215 truncation on 64-bit hosts. Check for QUIT every
7216 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7217 faster and is responsive enough.
7218 (Flength): Report an error instead of overflowing an integer.
7219 (Fsafe_length): Return a float if the value is not representable
7220 as a fixnum. This shouldn't happen except in contrived situations.
7221 (Fnthcdr, Fsort): Don't assume list length fits in int.
7222 (Fcopy_sequence): Don't assume vector length fits in int.
7224 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7225 (header_size, word_size): New constants.
7226 (allocate_vectorlike): Don't check size overflow here.
7227 (allocate_vector): Check it here instead, since this is the only
7228 caller of allocate_vectorlike that could cause overflow.
7229 Check that the new vector's length is representable as a fixnum.
7231 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7232 The previous code was bogus. For example, next_almost_prime (32)
7233 returned 39, which is undesirable as it is a multiple of 3; and
7234 next_almost_prime (24) returned 25, which is a multiple of 5 so
7235 why was the code bothering to check for multiples of 7?
7237 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7239 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7241 Variadic C functions now count arguments with ptrdiff_t.
7242 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7243 Back then I didn't know that the Emacs coding style prefers signed int.
7244 Also, in the meantime I found a few more instances where arguments
7245 were being counted with int, which may truncate counts on 64-bit
7246 machines, or EMACS_INT, which may be unnecessarily wide.
7247 * lisp.h (struct Lisp_Subr.function.aMANY)
7248 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7249 Arg counts are now ptrdiff_t, not size_t.
7250 All variadic functions and their callers changed accordingly.
7251 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7252 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7253 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7254 * callint.c (Fcall_interactively): Check arg count for overflow,
7255 to avoid potential buffer overrun. Use signed char, not 'int',
7256 for 'varies' array, so that we needn't bother to check its size
7257 calculation for overflow.
7258 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7259 * eval.c (apply_lambda):
7260 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7261 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7262 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7264 * callint.c (Fcall_interactively): Don't use index var as event count.
7266 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7267 * mem-limits.h (SIZE): Remove; no longer used.
7269 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7271 Remove unnecessary casts.
7272 * xterm.c (x_term_init):
7273 * xfns.c (x_set_border_pixel):
7274 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7275 These aren't needed now that we assume ANSI C.
7277 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7278 It's more likely to cause problems (due to unsigned overflow)
7281 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7283 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7285 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7287 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7289 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7291 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7293 GLYPH_CODE_FACE returns EMACS_INT, not int.
7294 * dispextern.h (merge_faces):
7295 * xfaces.c (merge_faces):
7296 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7297 Don't assume EMACS_INT fits in int.
7299 * character.h (CHAR_VALID_P): Remove unused parameter.
7300 * fontset.c, lisp.h, xdisp.c: All uses changed.
7302 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7304 * fns.c (concat): Minor tuning based on overflow analysis.
7305 This doesn't fix any bugs. Use int to hold character, instead
7306 of constantly refetching from Emacs object. Use XFASTINT, not
7307 XINT, for value known to be a character. Don't bother comparing
7308 a single byte to 0400, as it's always less.
7310 * floatfns.c (Fexpt):
7311 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7313 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7316 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7318 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7319 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7320 incorrectly succeed when S was a string, because 4294967386 was
7321 truncated before it was used.
7323 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7324 Otherwise, an out-of-range integer could cause undefined behavior
7327 * composite.c: Use int, not EMACS_INT, for characters.
7328 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7329 EMACS_INT, for values that are known to be in character range.
7330 This doesn't fix any bugs but is the usual style inside Emacs and
7331 may generate better code on 32-bit machines.
7333 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7334 This is for reasons similar to the recent CHAR_STRING fix.
7335 * charset.c (Fencode_char): Check that character arg is actually
7336 a character. Pass an int to ENCODE_CHAR.
7337 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7338 wider than 'int', as a compile-time check to prevent future regressions
7341 * character.c (char_string): Remove unnecessary casts.
7343 Make sure a 64-bit char is never passed to CHAR_STRING.
7344 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7345 by silently ignoring the top 32 bits, allowing some values
7346 that were far too large to be valid characters.
7347 * character.h: Include <verify.h>.
7348 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7349 arguments are no wider than unsigned, as a compile-time check
7350 to prevent future regressions in this area.
7352 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7353 (Fsubst_char_in_region):
7355 * xdisp.c (decode_mode_spec_coding):
7356 Adjust to CHAR_STRING's new requirement.
7357 * editfns.c (Finsert_char, Fsubst_char_in_region):
7358 * fns.c (concat): Check that character args are actually
7359 characters. Without this test, these functions did the wrong
7360 thing with wildly out-of-range values on 64-bit hosts.
7362 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7363 These casts should not be needed on 32-bit hosts, either.
7364 * keyboard.c (read_char):
7365 * lread.c (Fload): Remove casts to unsigned.
7367 * lisp.h (UNSIGNED_CMP): New macro.
7368 This fixes comparison bugs on 64-bit hosts.
7369 (ASCII_CHAR_P): Use it.
7370 * casefiddle.c (casify_object):
7371 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7372 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7373 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7374 * dispextern.h (FACE_FROM_ID):
7375 * keyboard.c (read_char): Use UNSIGNED_CMP.
7377 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7378 not to EMACS_INT, to avoid GCC warning.
7380 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7382 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7383 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7384 isn't needed on 32-bit machines.
7386 * buffer.c (Fgenerate_new_buffer_name):
7387 Use EMACS_INT for count, not int.
7388 (advance_to_char_boundary): Return EMACS_INT, not int.
7390 * data.c (Qcompiled_function): Now static.
7392 * window.c (window_body_lines): Now static.
7394 * image.c (gif_load): Rename local to avoid shadowing.
7396 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7397 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7398 * alloc.c (make_save_value): Integer argument is now of type
7400 (mark_object): Use ptrdiff_t, not int.
7401 * lisp.h (pD): New macro.
7402 * print.c (print_object): Use it.
7404 * alloc.c: Use EMACS_INT, not int, to count objects.
7405 (total_conses, total_markers, total_symbols, total_vector_size)
7406 (total_free_conses, total_free_markers, total_free_symbols)
7407 (total_free_floats, total_floats, total_free_intervals)
7408 (total_intervals, total_strings, total_free_strings):
7409 Now EMACS_INT, not int. All uses changed.
7410 (Fgarbage_collect): Compute overall total using a double, so that
7411 integer overflow is less likely to be a problem. Check for overflow
7412 when converting back to an integer.
7413 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7414 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7415 These were 'int' variables that could overflow on 64-bit hosts;
7416 they were never used, so remove them instead of repairing them.
7417 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7418 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7419 Previously, this ceilinged at INT_MAX, but that doesn't work on
7421 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7423 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7424 (allocate_vectorlike): Check for ptrdiff_t overflow.
7425 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7426 when a (possibly-narrower) signed value would do just as well.
7427 We prefer using signed arithmetic, to avoid comparison confusion.
7429 * alloc.c: Catch some string size overflows that we were missing.
7430 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7431 for convenience in STRING_BYTES_MAX.
7432 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7433 The definition here is exact; the one in lisp.h was approximate.
7434 (allocate_string_data): Check for string overflow. This catches
7435 some instances we weren't catching before. Also, it catches
7436 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7437 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7438 and ptrdiff_t and EMACS_INT are both 64 bits.
7440 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7441 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7442 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7444 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7446 * alloc.c (Fmake_string): Check for out-of-range init.
7448 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7450 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7452 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7454 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7455 xg_get_default_scrollbar_width.
7457 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7458 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7459 (style_changed_cb): Call update_theme_scrollbar_width and call
7460 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7461 all frames (Bug#8505).
7462 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7463 Call gtk_window_set_resizable if HAVE_GTK3.
7464 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7465 and height if HAVE_GTK3 (Bug#8505).
7466 (scroll_bar_width_for_theme): New variable.
7467 (update_theme_scrollbar_width): New function.
7468 (xg_get_default_scrollbar_width): Move code to
7469 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7470 (xg_initialize): Call update_theme_scrollbar_width.
7472 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7474 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7476 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7478 * frame.c (make_frame): Call other_buffer_safely instead of
7481 * window.c (temp_output_buffer_show): Call display_buffer with
7482 second argument Vtemp_buffer_show_specifiers and reset latter
7483 immediately after the call.
7484 (Vtemp_buffer_show_specifiers): New variable.
7485 (auto_window_vscroll_p, next_screen_context_lines)
7486 (Vscroll_preserve_screen_position): Remove leading asterisks from
7489 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7491 Fix minor problems found by GCC 4.6.0 static checking.
7492 * buffer.c (Qclone_number): Remove for now, as it's unused.
7493 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7494 (record_buffer): Remove unused local.
7495 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7496 (set_frame_buffer_list): Remove; unused.
7497 * frame.h (other_visible_frames): Remove decl.
7498 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7499 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7500 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7502 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7503 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7504 Define only if HAVE_GPM.
7505 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7506 (update_hints_inhibit): Remove; never set. All uses removed.
7507 * widgetprv.h (emacsFrameClassRec): Remove decl.
7508 * window.c (delete_deletable_window): Now returns void, since it
7509 wasn't returning anything.
7510 (compare_window_configurations): Remove unused locals.
7511 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7512 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7513 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7514 the same widths as pointers. This follows up on the 2011-05-06 patch.
7515 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7516 * xterm.h: Likewise.
7517 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7519 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7521 * makefile.w32-in: Update dependencies.
7522 (LISP_H): Add lib/intprops.h.
7524 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7526 * image.c (gif_load): Add animation frame delay to the metadata.
7527 (syms_of_image): Use DEFSYM. New symbol `delay'.
7529 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7531 * window.c (delete_deletable_window): Re-add.
7532 (Fset_window_configuration): Rewrite to handle dead buffers and
7533 consequently deletable windows.
7534 (window_tree, Fwindow_tree): Remove. Supply functionality in
7536 (compare_window_configurations): Simplify code.
7538 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7540 * image.c (imagemagick_load_image): Fix type mismatch.
7541 (Fimagemagick_types): Likewise.
7543 * window.h (replace_buffer_in_windows): Declare.
7545 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7547 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7548 Qclone_number. Remove external declaration of Qdelete_window.
7549 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7551 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7552 Run Qbuffer_list_update_hook if allowed.
7553 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7554 buffer list implementation.
7555 (other_buffer_safely): New function.
7556 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7557 calls to replace_buffer_in_windows and
7558 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7560 (record_buffer): Inhibit quitting and rewrite using quittable
7561 functions. Run Qbuffer_list_update_hook if allowed.
7562 (Frecord_buffer, Funrecord_buffer): New functions.
7563 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7564 Move switch-to-buffer to window.el.
7565 (bury-buffer): Move to window.el.
7566 (Vbuffer_list_update_hook): New variable.
7568 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7571 * window.h (resize_frame_windows): Move up in code.
7572 (Fwindow_frame): Remove EXFUN.
7573 (replace_buffer_in_all_windows): Remove prototype.
7574 (replace_buffer_in_windows_safely): Add prototype.
7576 * window.c: Declare Qdelete_window static again. Move down
7577 declaration of select_count.
7578 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7579 (Fother_window): Move to window.el.
7580 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7581 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7582 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7584 (replace_buffer_in_windows): Implement by calling
7585 Qreplace_buffer_in_windows.
7586 (replace_buffer_in_all_windows): Remove with some functionality
7587 moved into replace_buffer_in_windows_safely.
7588 (replace_buffer_in_windows_safely): New function.
7589 (select_window_norecord, select_frame_norecord): Move in front
7590 of run_window_configuration_change_hook. Remove now obsolete
7592 (Fset_window_buffer): Rewrite doc-string.
7593 Call Qrecord_window_buffer.
7594 (keys_of_window): Move binding for other-window to window.el.
7596 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7598 * dispextern.h (struct image): Replace data member, whose int_val
7599 and ptr_val fields were not used by anything, with a single
7602 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7603 (gif_clear_image, gif_load, imagemagick_load_image)
7604 (gs_clear_image, gs_load): Callers changed.
7606 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7608 * buffer.h: Include <time.h>, for time_t.
7609 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7611 Fix minor problems found by static checking.
7613 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7615 Make identifiers static if they are not used in other modules.
7616 * data.c (Qcompiled_function, Qframe, Qvector):
7617 * image.c (QimageMagick, Qsvg):
7618 * minibuf.c (Qmetadata):
7619 * window.c (resize_window_check, resize_root_window): Now static.
7620 * window.h (resize_window_check, resize_root_window): Remove decls.
7622 * window.c (window_deletion_count, delete_deletable_window):
7624 (window_body_lines): Now static.
7625 (Fdelete_other_windows_internal): Mark vars as initialized.
7626 Make sure 'resize_failed' is initialized.
7627 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7628 (resize_window_apply): Remove unused local.
7629 * window.h (delete_deletable_window): Remove decl.
7631 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7632 (imagemagick_load_image): Fix pointer signedness problem by changing
7633 last arg from unsigned char * to char *. All uses changed.
7634 Also, fix a local for similar reasons.
7635 Remove unused locals. Remove locals to avoid shadowing.
7636 (fn_rsvg_handle_free): Remove; unused.
7637 (svg_load, svg_load_image): Fix pointer signedness problem.
7638 (imagemagick_load_image): Don't use garbage pointer image_wand.
7640 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7642 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7644 * image.c (gif_load): Fix omitted cast error introduced by
7647 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7649 * window.h (resize_proportionally, orig_total_lines)
7650 (orig_top_line): Remove from window structure.
7651 (set_window_height, set_window_width, change_window_heights)
7652 (Fdelete_window): Remove prototypes.
7653 (resize_frame_windows): Remove duplicate declaration.
7655 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7657 * window.h (resize_frame_windows, resize_window_check)
7658 (delete_deletable_window, resize_root_window)
7659 (resize_frame_windows): Declare prototypes.
7661 * window.c (resize_window_apply): Make definition be "static" to
7662 match the prototype.
7664 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7666 * window.c: Remove declarations of Qwindow_size_fixed,
7667 window_min_size_1, window_min_size_2, window_min_size,
7668 size_window, window_fixed_size_p, enlarge_window, delete_window.
7669 Remove static from declaration of Qdelete_window, it's
7670 temporarily needed by Fbury_buffer.
7671 (replace_window): Don't assign orig_top_line and
7673 (Fdelete_window, delete_window): Remove. Window deletion is
7674 handled by window.el.
7675 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7676 Replace Fdelete_window calls with calls to Qdelete_window.
7677 (Fdelete_other_windows): Remove. Deleting other windows is
7678 handled by window.el.
7679 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7680 handled in window.el.
7681 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7682 Window minimum sizes are handled in window.el.
7683 (shrink_windows, size_window, set_window_height)
7684 (set_window_width, change_window_heights, window_height)
7685 (window_width, CURBEG, CURSIZE, enlarge_window)
7686 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7687 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7688 handled in window.el.
7689 (make_dummy_parent): Rename to make_parent_window and give it a
7690 second argument horflag.
7691 (make_window): Don't set resize_proportionally any more.
7692 (Fsplit_window): Remove. Windows are split in window.el.
7693 (save_restore_action, save_restore_orig_size)
7694 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7695 Resize mini windows in window.el.
7696 (grow_mini_window, shrink_mini_window): Implement by calling
7697 Qresize_root_window_vertically, resize_window_check and
7698 resize_window_apply.
7699 (saved_window, Fset_window_configuration, save_window_save):
7700 Do not handle orig_top_line, orig_total_lines, and
7701 resize_proportionally.
7702 (window_min_height, window_min_width): Move to window.el.
7703 (keys_of_window): Move bindings for delete-other-windows,
7704 split-window, delete-window and enlarge-window to window.el.
7706 * buffer.c: Temporarily extern Qdelete_window.
7707 (Fbury_buffer): Temporarily call Qdelete_window instead of
7708 Fdelete_window (Fbury_buffer will move to window.el soon).
7710 * frame.c (set_menu_bar_lines_1): Remove code handling
7711 orig_top_line and orig_total_lines.
7713 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7714 set_window_height but set heights directly.
7715 (change_frame_size_1): Use resize_frame_windows.
7717 * xdisp.c (init_xdisp): Don't use set_window_height but set
7720 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7721 Use resize_frame_windows instead of change_window_heights and run
7722 run_window_configuration_change_hook.
7724 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7725 instead of change_window_heights and run
7726 run_window_configuration_change_hook.
7728 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7730 * window.c (replace_window): Rename second argument REPLACEMENT to
7731 NEW. New third argument SETFLAG. Rewrite.
7732 (delete_window, make_dummy_parent): Call replace_window with
7734 (window_list_1): Move down in code.
7735 (run_window_configuration_change_hook): Move set_buffer part
7736 before select_frame_norecord part in order to unwind correctly.
7737 Rename count1 to count.
7738 (recombine_windows, delete_deletable_window, resize_root_window)
7739 (Fdelete_other_windows_internal)
7740 (Frun_window_configuration_change_hook, make_parent_window)
7741 (resize_window_check, resize_window_apply, Fresize_window_apply)
7742 (resize_frame_windows, Fsplit_window_internal)
7743 (Fdelete_window_internal, Fresize_mini_window_internal):
7745 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7747 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7749 * window.h (window): Add some new members to window structure -
7750 normal_lines, normal_cols, new_total, new_normal, clone_number,
7751 splits, nest, prev_buffers, next_buffers.
7752 (WINDOW_TOTAL_SIZE): Move here from window.c.
7753 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7755 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7757 (make_dummy_parent): Set new members of windows structure.
7758 (make_window): Move down in code. Handle new members of window
7760 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7761 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7762 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7763 (Fset_window_prev_buffers, Fwindow_next_buffers)
7764 (Fset_window_next_buffers, Fset_window_clone_number):
7766 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7767 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7769 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7770 Argument WINDOW can be now internal window too.
7771 (Fwindow_use_time): Move up in code.
7772 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7774 (Fset_window_configuration, saved_window)
7775 (Fcurrent_window_configuration, save_window_save): Handle new
7776 members of window structure.
7777 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7778 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7779 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7780 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7781 Qget_mru_window, Qresize_root_window,
7782 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7783 Qauto_buffer_name; staticpro them.
7785 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7787 * window.c (Fwindow_total_size, Fwindow_left_column)
7788 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7789 (Fwindow_list_1): New functions.
7790 (window_box_text_cols): Replace with window_body_cols.
7791 (Fwindow_width, Fscroll_left, Fscroll_right):
7792 Use window_body_cols instead of window_box_text_cols.
7793 (delete_window, Fset_window_configuration):
7794 Call delete_all_subwindows with window as argument.
7795 (delete_all_subwindows): Take a window as argument and not a
7797 (window_loop): Remove handling of GET_LRU_WINDOW and
7799 (Fget_lru_window, Fget_largest_window): Move to window.el.
7801 * window.h: Extern window_body_cols instead of
7802 window_box_text_cols. delete_all_subwindows now takes a
7803 Lisp_Object as argument.
7805 * indent.c (compute_motion, Fcompute_motion):
7806 Use window_body_cols instead of window_box_text_cols.
7808 * frame.c (delete_frame): Call delete_all_subwindows with root
7811 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7813 * fns.c (Fputhash): Document return value.
7815 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7817 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7819 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7821 Cons<->int and similar integer overflow fixes (Bug#8794).
7823 Check for overflow when converting integer to cons and back.
7824 * charset.c (Fdefine_charset_internal, Fdecode_char):
7825 Use cons_to_unsigned to catch overflow.
7826 (Fencode_char): Use INTEGER_TO_CONS.
7827 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7828 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7829 * data.c (long_to_cons, cons_to_long): Remove.
7830 (cons_to_unsigned, cons_to_signed): New functions.
7831 These signal an error for invalid or out-of-range values.
7832 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7833 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7834 * font.c (Ffont_variation_glyphs):
7835 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7836 * lisp.h: Include <intprops.h>.
7837 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7838 (cons_to_signed, cons_to_unsigned): New decls.
7839 (long_to_cons, cons_to_long): Remove decls.
7840 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7841 (Fprimitive_undo): Use CONS_TO_INTEGER.
7842 * xfns.c (Fx_window_property): Likewise.
7843 * xselect.c: Include <limits.h>.
7844 (x_own_selection, selection_data_to_lisp_data):
7845 Use INTEGER_TO_CONS.
7846 (x_handle_selection_request, x_handle_selection_clear)
7847 (x_get_foreign_selection, Fx_disown_selection_internal)
7848 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7849 (lisp_data_to_selection_data): Use cons_to_unsigned.
7850 (x_fill_property_data): Use cons_to_signed.
7851 Report values out of range.
7853 Check for buffer and string overflow more precisely.
7854 * buffer.h (BUF_BYTES_MAX): New macro.
7855 * lisp.h (STRING_BYTES_MAX): New macro.
7856 * alloc.c (Fmake_string):
7857 * character.c (string_escape_byte8):
7858 * coding.c (coding_alloc_by_realloc):
7859 * doprnt.c (doprnt):
7860 * editfns.c (Fformat):
7862 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7863 since they may not be the same number.
7864 * editfns.c (Finsert_char):
7865 * fileio.c (Finsert_file_contents):
7866 Likewise for BUF_BYTES_MAX.
7868 * image.c: Use ptrdiff_t, not int, for sizes.
7869 (slurp_file): Switch from int to ptrdiff_t.
7871 (slurp_file): Check that file size fits in both size_t (for
7872 malloc) and ptrdiff_t (for sanity and safety).
7874 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7875 if b->modtime has its maximal value.
7877 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7879 Don't assume time_t can fit into int.
7880 * buffer.h (struct buffer.modtime): Now time_t, not int.
7881 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7882 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7884 Minor fixes for signed vs unsigned integers.
7885 * character.h (MAYBE_UNIFY_CHAR):
7886 * charset.c (maybe_unify_char):
7887 * keyboard.c (read_char, reorder_modifiers):
7888 XINT -> XFASTINT, since the integer must be nonnegative.
7889 * ftfont.c (ftfont_spec_pattern):
7890 * keymap.c (access_keymap, silly_event_symbol_error):
7891 XUINT -> XFASTINT, since the integer must be nonnegative.
7892 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7893 since it makes no difference and we prefer signed.
7894 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7895 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7898 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7900 * window.h (Fwindow_frame): Declare.
7902 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7904 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7905 (SPARE_MEMORY): Always define.
7906 (LARGE_REQUEST): Remove.
7907 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7909 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7911 * lisp.h: Move EXFUNS for Fframe_root_window,
7912 Fframe_first_window and Fset_frame_selected_window to window.h.
7914 * window.h: Move EXFUNS for Fframe_root_window,
7915 Fframe_first_window and Fset_frame_selected_window here from
7918 * frame.c (Fwindow_frame, Fframe_first_window)
7919 (Fframe_root_window, Fframe_selected_window)
7920 (Fset_frame_selected_window): Move to window.c.
7921 (Factive_minibuffer_window): Move to minibuf.c.
7922 (Fother_visible_frames_p): New function.
7924 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7926 * window.c (decode_window, decode_any_window): Move up in code.
7927 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7928 (inhibit_frame_unsplittable): Remove unused variable.
7929 (Fwindow_buffer): Move up and rewrite doc-string.
7930 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7931 (Fwindow_prev): New functions.
7932 (Fwindow_frame): Move here from frame.c. Accept any window as
7934 (Fframe_root_window, Fframe_first_window)
7935 (Fframe_selected_window): Move here from frame.c. Accept frame
7936 or arbitrary window as argument. Update doc-strings.
7937 (Fminibuffer_window): Move up in code.
7938 (Fwindow_minibuffer_p): Move up in code and simplify.
7939 (Fset_frame_selected_window): Move here from frame.c.
7941 (Fselected_window, select_window, Fselect_window): Move up in
7942 code. Minor doc-string fixes.
7944 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7946 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7947 Do not assume that spare memory exists; that assumption is valid
7948 only if SYSTEM_MALLOC.
7949 (LARGE_REQUEST): New macro, so that the issue of large requests
7950 is separated from the issue of spare memory.
7952 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7954 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7957 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7959 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7962 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7964 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7966 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7968 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7969 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7971 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7973 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7975 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7977 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7978 (x_clipboard_manager_save): Add return value.
7979 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7981 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7982 Obey Vx_select_enable_clipboard_manager. Catch errors in
7983 x_clipboard_manager_save (Bug#8779).
7984 (Vx_select_enable_clipboard_manager): New variable.
7985 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7987 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7989 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7991 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7993 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7994 in the current matrix if keep_current_p is non-zero.
7996 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7998 * bidi.c (bidi_level_of_next_char): Fix last change.
8000 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8002 Support bidi reordering of text covered by display properties.
8004 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8005 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8006 (bidi_cache_search, bidi_cache_iterator_state)
8007 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8008 (bidi_level_of_next_char, bidi_move_to_visually_next):
8009 Support character positions inside a run of characters covered by a
8011 (bidi_paragraph_init, bidi_resolve_explicit_1)
8012 (bidi_level_of_next_char): Call bidi_fetch_char and
8013 bidi_fetch_char_advance instead of FETCH_CHAR and
8015 (bidi_init_it): Initialize new members.
8016 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8018 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8019 instead of using explicit *_CHAR codes.
8020 (bidi_resolve_explicit, bidi_resolve_weak):
8021 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8022 bidirectional text is supported only in multibyte buffers.
8023 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8024 it to initialize the frame_window_p member of struct bidi_it.
8025 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8026 (bidi_resolve_explicit, bidi_resolve_weak)
8027 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8028 bidi_it->nchars is non-positive.
8029 (bidi_level_of_next_char): Don't try to lookup the cache for the
8030 next/previous character if nothing is cached there yet, or if we
8031 were just reseat()'ed to a new position.
8033 * xdisp.c (set_cursor_from_row): Set start and stop points
8034 according to the row's direction when priming the loop that looks
8035 for the glyph on which to display cursor.
8036 (single_display_spec_intangible_p): Function deleted.
8037 (display_prop_intangible_p): Reimplement to call
8038 handle_display_spec instead of single_display_spec_intangible_p.
8039 Accept 3 additional arguments needed by handle_display_spec.
8040 This fixes incorrect cursor motion across display property with complex
8041 values: lists, `(when COND...)' forms, etc.
8042 (single_display_spec_string_p): Support property values that are
8043 lists with the argument STRING its top-level element.
8044 (display_prop_string_p): Fix the condition for processing a
8045 property that is a list to be consistent with handle_display_spec.
8046 (handle_display_spec): New function, refactored from the
8047 last portion of handle_display_prop.
8048 (compute_display_string_pos): Accept additional argument
8049 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8050 value of a `display' property is a "replacing spec".
8051 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8052 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8053 the display property, but just return a value indicating whether
8054 the display property will replace the characters it covers.
8055 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8056 frame_window_p members of struct bidi_it.
8057 (compute_display_string_pos, compute_display_string_end):
8059 (push_it): Accept second argument POSITION, where pop_it should
8060 jump to continue iteration.
8061 (reseat_1): Initialize bidi_it.disp_pos.
8063 * keyboard.c (adjust_point_for_property): Adjust the call to
8064 display_prop_intangible_p to its new signature.
8066 * dispextern.h (struct bidi_it): New member frame_window_p.
8067 (bidi_init_it): Update prototypes.
8068 (display_prop_intangible_p): Update prototype.
8069 (compute_display_string_pos, compute_display_string_end):
8071 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8074 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8076 Malloc failure behavior now depends on size of allocation.
8077 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8078 * lisp.h: Change signatures accordingly.
8079 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8080 All callers changed. (Bug#8762)
8082 * gnutls.c: Use Emacs's memory allocators.
8083 Without this change, the gnutls library would invoke malloc etc.
8084 directly, which causes problems on non-SYNC_INPUT hosts, and which
8085 runs afoul of improving memory_full behavior. (Bug#8761)
8086 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8087 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8088 xfree instead of the default malloc, realloc, free.
8089 (Fgnutls_boot): No need to check for memory allocation failure,
8090 since xmalloc does that for us.
8092 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8093 * category.c (hash_get_category_set):
8094 * ccl.c (ccl_driver):
8095 * charset.c (Fdefine_charset_internal):
8096 * charset.h (struct charset.hash_index):
8097 * composite.c (get_composition_id, gstring_lookup_cache)
8098 (composition_gstring_put_cache):
8099 * composite.h (struct composition.hash_index):
8100 * dispextern.h (struct image.hash):
8101 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8102 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8103 (hashfn_equal, hashfn_user_defined, make_hash_table)
8104 (maybe_resize_hash_table, hash_lookup, hash_put)
8105 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8106 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8107 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8108 * image.c (make_image, search_image_cache, lookup_image)
8109 (xpm_put_color_table_h):
8110 * lisp.h (struct Lisp_Hash_Table):
8111 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8112 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8113 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8114 * alloc.c (allocate_vectorlike):
8115 Check for overflow in vector size calculations.
8116 * ccl.c (ccl_driver):
8117 Check for overflow when converting EMACS_INT to int.
8118 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8119 need to be updated by these changes.
8120 * fns.c (make_hash_table, maybe_resize_hash_table):
8121 Check for integer overflow with large hash tables.
8122 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8123 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8124 (SXHASH_REDUCE): New macro.
8125 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8126 Use it instead of discarding useful hash info with large hash values.
8127 (sxhash_float): New function.
8128 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8129 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8130 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8131 Rewrite to use FIXNUM_BITS, as this simplifies things.
8132 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8133 Adjust signatures to match updated version of code.
8134 (consing_since_gc): Now EMACS_INT, since a single hash table can
8135 use more than INT_MAX bytes.
8137 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8139 Make it possible to build with GCC-4.6+ -O2 -flto.
8141 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8143 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8145 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8146 Call minibuffer-inactive-mode.
8148 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8150 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8151 Update dependencies.
8153 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8155 * data.c (init_data): Remove code for UTS, this system is not
8158 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8160 Don't force ./temacs to start in terminal mode.
8162 * frame.c (make_initial_frame): Initialize faces in all cases, not
8163 only when CANNOT_DUMP is defined.
8164 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8166 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8168 * dispnew.c (add_window_display_history): Use const for the string
8169 pointer. Remove declaration, not needed.
8171 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8173 Use 'inline', not 'INLINE'.
8174 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8175 * alloc.c, fontset.c (INLINE): Remove.
8176 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8177 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8178 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8179 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8180 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8182 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8184 Make it possible to run ./temacs.
8186 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8187 syms_of_callproc does the same thing. Remove test for
8188 "initialized", do it in the caller.
8189 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8191 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8193 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8194 (read_minibuf): Use get_minibuffer.
8195 (syms_of_minibuf): Use DEFSYM.
8196 (Qmetadata): New var.
8197 * data.c (Qbuffer): Don't make it static.
8198 (syms_of_data): Use DEFSYM.
8200 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8202 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8203 (CCL_CODE_MIN): New macro.
8205 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8207 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8209 * eval.c (Qdebug): Now static.
8210 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8211 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8212 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8214 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8216 * image.c: Various fixes to ImageMagick code comments.
8217 (Fimagemagick_types): Doc fix.
8219 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8221 Minor fixes prompted by GCC 4.6.0 warnings.
8223 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8225 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8226 (x_clipboard_manager_save_all): Move extern decl to ...
8227 * xterm.h: ... here, so that it can be checked for consistency.
8229 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8231 * xselect.c (x_clipboard_manager_save_frame)
8232 (x_clipboard_manager_save_all): New functions.
8233 (Fx_clipboard_manager_save): Lisp function deleted.
8235 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8236 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8238 * xterm.h: Update prototype.
8240 2011-05-28 William Xu <william.xwl@gmail.com>
8242 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8245 2011-05-28 Jim Meyering <meyering@redhat.com>
8247 Avoid a sign-extension bug in crypto_hash_function.
8248 * fns.c (to_uchar): Define.
8249 (crypto_hash_function): Use it to convert some newly-signed
8250 variables to unsigned, to avoid sign-extension bugs. For example,
8251 without this change, (md5 "truc") would evaluate to
8252 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8253 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8254 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8256 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8258 Integer overflow fixes.
8260 * dbusbind.c: Serial number integer overflow fixes.
8261 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8262 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8263 to hold a serial number that is too large for a fixnum.
8264 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8265 Check for serial numbers out of range. Decode any serial number
8266 that was so large that it became a float. (Bug#8722)
8268 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8269 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8270 Use XFASTINT rather than XUINT when numbers are nonnegative.
8271 (xd_append_arg, Fdbus_method_return_internal):
8272 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8273 arguments, check that Lisp number is nonnegative, rather than
8274 silently wrapping negative numbers around. (Bug#8722)
8275 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8278 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8280 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8282 ccl: Add integer overflow checks.
8283 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8284 (IN_INT_RANGE): New macros.
8285 (ccl_driver): Use them to check for integer overflow when
8286 decoding a CCL program. Many of the new checks are whether XINT (x)
8287 fits in int; it doesn't always, on 64-bit hosts. The new version
8288 doesn't catch all possible integer overflows, but it's an
8289 improvement. (Bug#8719)
8291 * alloc.c (make_event_array): Use XINT, not XUINT.
8292 There's no need for unsigned here.
8294 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8295 This follows up to the 2011-05-06 change that substituted uintptr_t
8296 for EMACS_INT. This case wasn't caught back then.
8298 Rework Fformat to avoid integer overflow issues.
8299 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8300 now (part of C89). Include <verify.h>.
8301 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8302 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8303 (Fformat): Avoid the prepass trying to compute sizes; it was only
8304 approximate and thus did not catch overflow reliably. Instead, walk
8305 through the format just once, formatting and computing sizes as we go,
8306 checking for integer overflow at every step, and allocating a larger
8307 buffer as needed. Keep track separately whether the format is
8308 multibyte. Keep only the most-recently calculated precision, rather
8309 than them all. Record whether each argument has been converted to
8310 string. Use EMACS_INT, not int, for byte and char and arg counts.
8311 Support field widths and precisions larger than INT_MAX. Avoid
8312 sprintf's undefined behavior with conversion specifications such as %#d
8313 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8314 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8315 formatting out-of-range floating point numbers with int
8318 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8320 * data.c: Avoid integer truncation in expressions involving floats.
8321 * data.c: Include <intprops.h>.
8322 (arith_driver): When there's an integer overflow in an expression
8323 involving floating point, convert the integers to floating point
8324 so that the resulting value does not suffer from catastrophic
8325 integer truncation. For example, on a 64-bit host (* 4
8326 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8327 Do not rely on undefined behavior after integer overflow.
8329 merge count_size_as_multibyte, parse_str_to_multibyte
8330 * character.c, character.h (count_size_as_multibyte):
8331 Rename from parse_str_to_multibyte; all uses changed.
8332 Check for integer overflow.
8333 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8334 since it's now a duplicate of the other. This is more of
8335 a character than a buffer op, so better that it's in character.c.
8336 * fns.c, print.c: Adjust to above changes.
8338 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8340 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8342 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8344 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8345 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8346 (x_clipboard_manager_save): Now static.
8347 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8349 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8350 (crypto_hash_function): Now static.
8351 Fix pointer signedness problems. Avoid unnecessary initializations.
8353 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8355 * termhooks.h (Vselection_alist): Make it terminal-local.
8357 * terminal.c (create_terminal): Initialize it.
8359 * xselect.c: Support for clipboard managers.
8360 (Vselection_alist): Move to termhooks.h as terminal-local var.
8361 (LOCAL_SELECTION): New macro.
8362 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8363 (symbol_to_x_atom): Remove gratuitous arg.
8364 (x_handle_selection_request, lisp_data_to_selection_data)
8365 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8366 (x_own_selection, x_get_local_selection, x_convert_selection):
8367 New arg, specifying work frame. Use terminal-local Vselection_alist.
8368 (some_frame_on_display): Delete unused function.
8369 (Fx_own_selection_internal, Fx_get_selection_internal)
8370 (Fx_disown_selection_internal, Fx_selection_owner_p)
8371 (Fx_selection_exists_p): New optional frame arg.
8372 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8373 (x_handle_selection_clear): Don't treat other terminals with the
8374 same keyboard specially. Use the terminal-local Vselection_alist.
8375 (x_clear_frame_selections): Use Frun_hook_with_args.
8377 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8379 * xterm.h: Add support for those atoms.
8381 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8383 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8384 (converted_selections, conversion_fail_tag): New global variables.
8385 (x_selection_request_lisp_error): Free the above.
8386 (x_get_local_selection): Remove unnecessary code.
8387 (x_reply_selection_request): Args changed; handle arbitrary array
8388 of converted selections stored in converted_selections.
8389 Separate the XChangeProperty and SelectionNotify steps.
8390 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8391 (x_convert_selection): New function.
8392 (x_handle_selection_event): Simplify.
8393 (x_get_foreign_selection): Don't ignore incoming requests while
8394 waiting for an answer; this will fail when we implement
8395 SAVE_TARGETS, and seems unnecessary anyway.
8396 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8397 (Vx_sent_selection_functions): Doc fix.
8399 2011-05-26 Leo Liu <sdl.web@gmail.com>
8401 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8403 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8405 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8407 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8408 for fringe update if it has periodic bitmap.
8409 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8410 and fringe_bitmap_periodic_p.
8412 * fringe.c (get_fringe_bitmap_data): New function.
8413 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8414 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8415 row. Mark glyph row for fringe update if periodicity changed.
8417 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8418 for fringe update unless it has periodic bitmap.
8420 2011-05-25 Kenichi Handa <handa@m17n.org>
8422 * xdisp.c (get_next_display_element): Set correct it->face_id for
8423 a static composition.
8425 2011-05-24 Leo Liu <sdl.web@gmail.com>
8428 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8430 * fns.c (crypto_hash_function, Fsha1): New function.
8431 (Fmd5): Use crypto_hash_function.
8432 (syms_of_fns): Add Ssha1.
8434 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8436 * gnutls.c: Remove unused macros.
8437 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8438 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8439 Remove macros that are defined and never used.
8440 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8442 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8444 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8445 (Fx_get_selection_internal): Minor cleanup.
8446 (Fx_own_selection_internal): Rename arguments for consistency with
8449 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8451 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8453 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8455 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8457 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8459 * dispnew.c (scrolling_window): Don't exclude the case that the
8460 last enabled row in the desired matrix touches the bottom boundary.
8462 2011-05-21 Glenn Morris <rgm@gnu.org>
8464 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8465 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8466 and add some more files.
8468 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8470 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8471 report_file_error introduced by the change from 2011-05-07.
8473 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8475 * systime.h (Time): Define only if emacs is defined.
8476 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8477 where the include path doesn't have X11/X.h by default. See
8478 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8480 2011-05-20 Kenichi Handa <handa@m17n.org>
8482 * composite.c (find_automatic_composition): Fix previous change.
8484 2011-05-20 Glenn Morris <rgm@gnu.org>
8486 * lisp.mk: New file, split from Makefile.in.
8487 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8488 (shortlisp): Remove.
8489 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8491 2011-05-19 Glenn Morris <rgm@gnu.org>
8493 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8494 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8495 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8496 (lisp): Set the order to that of loadup.el.
8497 (shortlisp): Make it a copy of $lisp.
8498 (SOME_MACHINE_LISP): Remove.
8499 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8500 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8502 2011-05-18 Kenichi Handa <handa@m17n.org>
8504 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8505 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8506 (find_automatic_composition): Mostly rewrite for efficiency.
8508 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8510 * makefile.w32-in: Update dependencies.
8512 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8514 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8515 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8517 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8519 Fix some integer overflow issues, such as string length overflow.
8521 * insdel.c (count_size_as_multibyte): Check for string overflow.
8523 * character.c (lisp_string_width): Check for string overflow.
8524 Use EMACS_INT, not int, for string indexes and lengths; in
8525 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8526 the resulting string length overflows an EMACS_INT; instead,
8527 report a string overflow if no precision given. When checking for
8528 precision exhaustion, use a check that cannot possibly have
8529 integer overflow. (Bug#8675)
8530 * character.h (lisp_string_width): Adjust to new signature.
8532 * alloc.c (string_overflow): New function.
8533 (Fmake_string): Use it. This doesn't change behavior, but saves
8534 a few bytes and will simplify future changes.
8535 * character.c (string_escape_byte8): Likewise.
8536 * lisp.h (string_overflow): New decl.
8538 Fixups, following up to the user-interface timestamp change.
8539 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8540 for UI timestamps, instead of unsigned long.
8541 * msdos.c (mouse_get_pos): Likewise.
8542 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8543 * w32gui.h (Time): Define by including "systime.h" rather than by
8544 declaring it ourselves. (Bug#8664)
8546 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8547 * image.c (clear_image_cache): Likewise.
8549 * term.c (term_mouse_position): Don't assume time_t wraparound.
8551 Be more systematic about user-interface timestamps.
8552 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8553 and sometimes 'EMACS_UINT', to represent these timestamps.
8554 This change causes it to use 'Time' uniformly, as that's what X uses.
8555 This makes the code easier to follow, and makes it easier to catch
8556 integer overflow bugs such as Bug#8664.
8557 * frame.c (Fmouse_position, Fmouse_pixel_position):
8558 Use Time, not unsigned long, for user-interface timestamps.
8559 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8560 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8561 * keyboard.h (last_event_timestamp): Likewise.
8562 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8563 * menu.h (xmenu_show): Likewise.
8564 * term.c (term_mouse_position): Likewise.
8565 * termhooks.h (struct input_event.timestamp): Likewise.
8566 (struct terminal.mouse_position_hook): Likewise.
8567 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8568 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8569 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8570 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8572 * menu.h, termhooks.h: Include "systime.h", for Time.
8574 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8575 Don't assume that the difference between two unsigned long values
8576 can fit into an integer. At this point, we know button_down_time
8577 <= event->timestamp, so the difference must be nonnegative, so
8578 there's no need to cast the result if double-click-time is
8579 nonnegative, as it should be; check that it's nonnegative, just in
8580 case. This bug is triggered when events are more than 2**31 ms
8581 apart (about 25 days). (Bug#8664)
8583 * xselect.c (last_event_timestamp): Remove duplicate decl.
8584 (x_own_selection): Remove needless cast to unsigned long.
8586 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8587 that always fit in int. Use a sentinel instead of a counter, to
8588 avoid a temp and to allay GCC's concerns about possible int overflow.
8589 * frame.h (struct frame): Use int for menu_bar_items_used
8590 instead of EMACS_INT, since it always fits in int.
8592 * menu.c (grow_menu_items): Check for int overflow.
8594 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8596 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8597 Before, the code was not consistent. These values cannot exceed
8598 2**31 - 1 so there's no need to make them unsigned.
8599 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8600 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8601 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8603 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8605 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8606 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8607 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8608 presumably because the widths might not match.
8610 * window.c (size_window): Avoid needless test at loop start.
8612 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8614 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8616 2011-05-12 Drew Adams <drew.adams@oracle.com>
8618 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8620 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8622 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8623 `width' to `bar_area_x' and `bar_area_width', respectively.
8624 (x_scroll_run): Take account of fringe background extension.
8626 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8627 Rename local vars `left' and `width' to `bar_area_x' and
8628 `bar_area_width', respectively.
8629 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8630 background extension.
8632 2011-05-10 Jim Meyering <meyering@redhat.com>
8634 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8636 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8638 * image.c (Finit_image_library): Return t for built-in image types,
8639 like pbm and xbm. (Bug#8640)
8641 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8643 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8645 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8647 * w32console.c (Fset_screen_color): Doc fix.
8648 (Fget_screen_color): New function.
8649 (syms_of_ntterm): Defsubr it.
8651 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8652 unlink the temporary file if Fcall_process didn't create it in the
8654 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8655 child process will be redirected to a file specified with `:file'.
8656 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8657 cue to call_process_cleanup not to close that handle.
8659 2011-05-07 Ben Key <bkey76@gmail.com>
8661 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8662 one of two shell specific rules, either bootstrap-temacs-CMD or
8663 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8664 to the previous implementation of the bootstrap-temacs rule.
8665 The bootstrap-temacs-CMD rule is similar to the previous
8666 implementation of the bootstrap-temacs rule except that it
8667 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8670 These changes, along with some changes to nt/configure.bat,
8671 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8672 earlier fix to add support for --cflags and --ldflags options
8673 that include quotes so that it works whether make uses cmd or
8676 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8678 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8679 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8681 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8682 a string. Handle both cases.
8683 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8684 (Fdbus_register_method): Use Qinvalid_function.
8686 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8688 * makefile.w32-in: Update dependencies.
8689 (LISP_H): Add inttypes.h and stdin.h.
8690 (PROCESS_H): Add unistd.h.
8692 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8694 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8695 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8697 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8699 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8701 * term.c (vfatal): Remove stray call to va_end.
8702 It's not needed and the C Standard doesn't allow it here anyway.
8704 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8705 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8707 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8710 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8712 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8714 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8716 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8718 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8720 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8721 * charset.c (Fdefine_charset_internal): Don't initialize
8722 charset.code_space[15]. The value was garbage, on hosts with
8723 32-bit int (Bug#8600).
8725 * lread.c (read_integer): Be more consistent with string-to-number.
8726 Use string_to_number to do the actual conversion; this avoids
8727 rounding errors and fixes some other screwups. Without this fix,
8728 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8729 (digit_to_number): Move earlier, for benefit of read_integer.
8730 Return -1 if the digit is out of range for the base, -2 if it is
8731 not a digit in any supported base. (Bug#8602)
8733 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8735 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8736 to match comment at start of function. This also removes a
8737 GCC warning about overflow in a 32+64-bit port.
8739 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8741 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8742 Reported by Stefan Monnier in
8743 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8744 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8745 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8747 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8748 (EMACS_UINTPTR): Likewise, with uintptr_t.
8750 * lisp.h: Prefer 64-bit EMACS_INT if available.
8751 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8752 on 32-bit hosts that have 64-bit int, so that they can access
8754 However, temporarily disable this change unless the temporary
8755 symbol WIDE_EMACS_INT is defined.
8757 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8759 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8760 This removes an assumption that EMACS_INT and long are the same
8761 width as pointers. The assumption is true for Emacs porting targets
8762 now, but we want to make other targets possible.
8763 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8764 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8765 In the rest of the code, change types of integers that hold casted
8766 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8767 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8768 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8769 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8770 No need to cast type when ORing.
8771 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8772 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8773 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8774 assume EMACS_INT is the same width as char *.
8775 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8776 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8777 Remove no-longer-needed casts.
8778 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8779 (xg_tool_bar_help_callback, xg_make_tool_item):
8780 Use EMACS_INTPTR to hold an integer
8781 that will be cast to void *; this can avoid a GCC warning
8782 if EMACS_INT is not the same width as void *.
8783 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8784 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8785 (current_message_1, set_message_1):
8786 Use a local to convert to proper width without a cast.
8787 * xmenu.c (dialog_selection_callback): Likewise.
8789 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8790 Also, don't assume VALBITS / RAND_BITS is less than 5,
8791 and don't rely on undefined behavior when shifting a 1 left into
8793 * lisp.h (get_random): Change signature to match.
8795 * lread.c (hash_string): Use size_t, not int, for hash computation.
8796 Normally we prefer signed values; but hashing is special, because
8797 it's better to use unsigned division on hash table sizes so that
8798 the remainder is nonnegative. Also, size_t is the natural width
8799 for hashing into memory. The previous code used 'int', which doesn't
8800 retain enough info to hash well into very large tables.
8801 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8803 * dbusbind.c: Don't possibly lose pointer info when converting.
8804 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8805 Use XPNTR rather than XHASH, so that the high-order bits of
8806 the pointer aren't lost when converting through void *.
8808 * eval.c (Fautoload): Don't double-shift a pointer.
8810 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8812 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8814 * gnutls.c (DEF_GNUTLS_FN):
8815 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8817 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8819 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8822 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8824 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8825 New version that can reserve upto 2GB of heap space.
8827 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8829 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8831 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8833 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8834 `gnutls_certificate_set_x509_key_file'.
8836 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8838 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8839 Update dependencies.
8841 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8843 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8844 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8845 Remove unused parameter `fildes'.
8846 * process.c (read_process_output, send_process): Don't pass it.
8848 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8850 Fix previous change: the library cache is defined in w32.c.
8851 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8852 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8854 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8856 Implement dynamic loading of GnuTLS on Windows.
8858 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8859 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8860 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8863 * gnutls.c (Qgnutls_dll): Define.
8864 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8865 (gnutls_*): Declare function pointers.
8866 (init_gnutls_functions): New function to initialize function pointers.
8867 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8868 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8869 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8870 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8871 (emacs_gnutls_write, emacs_gnutls_read)
8872 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8873 (Fgnutls_available_p): New function.
8874 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8875 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8876 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8878 * image.c: Include w32.h.
8879 (Vimage_type_cache): Delete.
8880 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8881 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8882 (w32_delayed_load): Move to w32.c.
8884 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8886 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8887 (w32_delayed_load): Move from image.c. When loading a library, record
8888 its filename in the :loaded-from property of the library id.
8889 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8890 Initialize and staticpro them.
8891 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8893 * process.c: Include lisp.h before w32.h, not after.
8894 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8895 instead of gnutls_record_check_pending.
8897 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8899 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8901 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8902 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8905 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8907 * xterm.c (x_set_frame_alpha): Do not set property on anything
8908 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8910 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8912 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8914 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8916 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8917 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8918 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8919 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8920 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8921 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8922 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8923 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8924 (Qgnutls_bootprop_callbacks_verify): Make static.
8926 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8928 * callproc.c: Indentation fixup.
8930 * sysdep.c (wait_for_termination_1): Make static.
8931 (wait_for_termination, interruptible_wait_for_termination):
8932 Move after wait_for_termination_1.
8934 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8936 * sysdep.c (interruptible_wait_for_termination): New function
8937 which is like wait_for_termination, but allows keyboard
8940 * callproc.c (Fcall_process): Add (:file "file") as an option for
8942 (Fcall_process_region): Ditto.
8944 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8946 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8947 rather than `XVECTOR (FOO)->size'.
8949 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8950 inttypes.h, as a gnulib replacement is used if it not available in
8953 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8955 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8956 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8957 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8959 * coding.c (coding_alloc_by_realloc): Error out if destination
8960 will grow beyond MOST_POSITIVE_FIXNUM.
8961 (decode_coding_emacs_mule): Abort if there isn't enough place in
8962 charbuf for the composition carryover bytes. Reserve an extra
8963 space for up to 2 characters produced in a loop.
8964 (decode_coding_iso_2022): Abort if there isn't enough place in
8965 charbuf for the composition carryover bytes.
8967 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8969 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8970 aborting when %lld or %lll format is passed.
8971 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8972 %llo or %llx format is passed. (Bug#8545)
8974 * window.c (window_scroll_line_based): Use a marker instead of
8975 simple variables to record original value of point. (Bug#7952)
8977 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8978 produced by %s or %c overflows available buffer space. (Bug#8545)
8980 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8982 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8983 (SIZE_MAX): Move defn after all includes, as they might #define it.
8985 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8987 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8989 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8991 * keyboard.c (Qdelayed_warnings_hook): Define.
8992 (command_loop_1): Run `delayed-warnings-hook'
8993 if Vdelayed_warnings_list is non-nil.
8994 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8995 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8997 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8999 * doprnt.c (doprnt): Don't return value smaller than the buffer
9000 size if the message was truncated. (Bug#8545).
9002 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9004 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9005 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9007 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9009 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9011 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9013 * makefile.w32-in: Update dependencies.
9015 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9017 Improve `doprnt' and its usage. (Bug#8545)
9018 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9019 `format_end'. Remove support for %l as a conversion specifier.
9020 Don't use xrealloc. Improve diagnostics when the %l size modifier
9021 is used. Update the commentary.
9023 * eval.c (verror): Simplify calculation of size_t.
9025 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9028 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9030 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9033 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9035 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9036 This makes this file independent of the recent pseudovector change.
9038 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9040 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9042 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9043 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9044 Remove unused local.
9045 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9047 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9048 GCC 4.6.0 optimizes based on type-based alias analysis.
9049 For example, if b is of type struct buffer * and v of type struct
9050 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9051 != &v->size, and therefore "v->size = 1; b->size = 2; return
9052 v->size;" must therefore return 1. This assumption is incorrect
9053 for Emacs, since it type-puns struct Lisp_Vector * with many other
9054 types. To fix this problem, this patch adds a new type struct
9055 vectorlike_header that documents the constraints on layout of vectors
9056 and pseudovectors, and helps optimizing compilers not get fooled
9057 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9058 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9059 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9061 (XSETPVECTYPE): Rewrite in terms of new macro.
9062 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9063 This is a bit clearer, and further avoids the possibility of
9064 undesirable aliasing.
9065 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9066 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9067 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9068 since Lisp_Subr is a special case (no "next" field).
9069 (ASIZE): Now uses header.size rather than size.
9070 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9071 to avoid the hassle of writing XVECTOR (foo)->header.size.
9072 (struct vectorlike_header): New type.
9073 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9074 object, to help avoid aliasing.
9075 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9076 (SUBRP): Likewise, since Lisp_Subr is a special case.
9077 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9078 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9079 (struct Lisp_Hash_Table): Combine first two members into a single
9080 struct vectorlike_header member. All uses of "size" and "next" members
9081 changed to be "header.size" and "header.next".
9082 * buffer.h (struct buffer): Likewise.
9083 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9084 * frame.h (struct frame): Likewise.
9085 * process.h (struct Lisp_Process): Likewise.
9086 * termhooks.h (struct terminal): Likewise.
9087 * window.c (struct save_window_data, struct saved_window): Likewise.
9088 * window.h (struct window): Likewise.
9089 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9090 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9091 * buffer.c (init_buffer_once): Likewise.
9092 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9094 * process.c (Fformat_network_address): Use local var for size,
9097 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9099 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9100 * data.c (atof): Remove decl; no longer used or needed.
9101 (digit_to_number): Move to lread.c.
9102 (Fstring_to_number): Use new string_to_number function, to be
9103 consistent with how the Lisp reader treats infinities and NaNs.
9104 Do not assume that floating-point numbers represent EMACS_INT
9105 without losing information; this is not true on most 64-bit hosts.
9106 Avoid double-rounding errors, by insisting on integers when
9107 parsing non-base-10 numbers, as the documentation specifies.
9108 * lisp.h (string_to_number): New decl, replacing ...
9109 (isfloat_string): Remove.
9110 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9111 (read1): Do not accept +. and -. as integers; this
9112 appears to have been a coding error. Similarly, do not accept
9113 strings like +-1e0 as floating point numbers. Do not report
9114 overflow for integer overflows unless the base is not 10 which
9115 means we have no simple and reliable way to continue.
9116 Break out the floating-point parsing into a new
9117 function string_to_number, so that Fstring_to_number parses
9118 floating point numbers consistently with the Lisp reader.
9119 (digit_to_number): Move here from data.c. Make it static inline.
9120 (E_CHAR, EXP_INT): Remove, replacing with ...
9121 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9122 (string_to_number): New function, replacing isfloat_string.
9123 This function checks for valid syntax and produces the resulting
9124 Lisp float number too. Rework it so that string-to-number
9125 no longer mishandles examples like "1.0e+". Use strtoumax,
9126 so that overflow for non-base-10 numbers is reported only when
9127 there's no portable and simple way to convert to floating point.
9129 * textprop.c (set_text_properties_1): Rewrite for clarity,
9130 and to avoid GCC warning about integer overflow.
9132 * intervals.h (struct interval): Use EMACS_INT for members
9133 where EMACS_UINT might cause problems. See
9134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9135 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9136 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9138 (offset_intervals): Tell GCC not to worry about length overflow
9139 when negating a negative length.
9141 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9142 (overrun_check_free): Likewise.
9144 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9145 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9148 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9149 (gnutls_make_error): Rename local to avoid shadowing.
9150 (gnutls_emacs_global_deinit): ifdef out; not used.
9151 (Fgnutls_boot): Use const for pointer to readonly storage.
9152 Comment out unused local. Fix pointer signedness problems.
9154 * lread.c (openp): Don't stuff size_t into an 'int'.
9155 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9156 about possible signed overflow.
9158 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9159 (GDK_KEY_g): Don't define if already defined.
9160 (xg_prepare_tooltip): Avoid pointer signedness problem.
9161 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9163 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9164 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9166 * xfns.c (Fx_window_property): Simplify a bit,
9167 to make a bit faster and to avoid GCC 4.6.0 warning.
9168 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9170 * fns.c (internal_equal): Don't assume size_t fits in int.
9172 * alloc.c (compact_small_strings): Tighten assertion a little.
9174 Replace pEd with more-general pI, and fix some printf arg casts.
9175 * lisp.h (pI): New macro, generalizing old pEd macro to other
9176 conversion specifiers. For example, use "...%"pI"d..." rather
9177 than "...%"pEd"...".
9178 (pEd): Remove. All uses replaced with similar uses of pI.
9179 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9180 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9181 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9182 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9183 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9184 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9185 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9187 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9188 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9189 * print.c (safe_debug_print, print_object): Likewise.
9190 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9192 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9193 avoiding the 0 flag, which is not portable.
9194 * process.c (Fmake_network_process): Use pI to avoid cast.
9195 * region-cache.c (pp_cache): Likewise.
9196 * xdisp.c (decode_mode_spec): Likewise.
9197 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9198 behavior on 64-bit hosts with printf arg.
9199 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9200 (x_stop_queuing_selection_requests): Likewise.
9201 (x_get_window_property): Don't truncate byte count to an 'int'
9204 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9205 here, since it parses constructs like leading '-' and spaces,
9206 which are not wanted; and it overflows with large numbers.
9207 Instead, simply match F[0-9]+, which is what is wanted anyway.
9209 * alloc.c: Remove unportable assumptions about struct layout.
9210 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9211 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9212 (allocate_vectorlike, make_pure_vector): Use the new macros,
9213 plus offsetof, to remove unportable assumptions about struct layout.
9214 These assumptions hold on all porting targets that I know of, but
9215 they are not guaranteed, they're easy to remove, and removing them
9216 makes further changes easier.
9218 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9219 This doesn't fix a bug but makes the code clearer.
9220 (string_overrun_cookie): Now const. Use initializers that
9221 don't formally overflow signed char, to avoid warnings.
9222 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9223 can cause Emacs to crash when string overrun checking is enabled.
9224 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9225 multiple of sizeof (EMACS_INT); it need not be, if
9226 alignof(EMACS_INT) < sizeof (EMACS_INT).
9227 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9229 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9231 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9233 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9235 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9236 supposed to be handshaking. (Bug#8556)
9237 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9239 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9241 * lisp.h (Qdebug): List symbol.
9242 * eval.c (Qdebug): Restore global linkage.
9243 * keyboard.c (debug-on-event): New variable.
9244 (handle_user_signal): Break into debugger when debug-on-event
9245 matches the current signal symbol.
9247 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9249 * alloc.c (check_sblock, check_string_bytes)
9250 (check_string_free_list): Convert to standard C.
9252 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9254 * w32.c (emacs_gnutls_push): Fix typo.
9256 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9258 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9259 "cast to pointer from integer of different size".
9261 Improve doprnt and its use in verror. (Bug#8545)
9262 * doprnt.c (doprnt): Document the set of format control sequences
9263 supported by the function. Use SAFE_ALLOCA instead of always
9266 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9267 is one byte too soon. Don't use xrealloc; instead xfree and
9270 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9272 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9275 * gnutls.c: Renamed global_initialized to
9276 gnutls_global_initialized. Added internals for the
9277 :verify-hostname-error, :verify-error, and :verify-flags
9278 parameters of `gnutls-boot' and documented those parameters in the
9279 docstring. Start callback support.
9280 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9281 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9282 on error. Return error code.
9283 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9284 (emacs_gnutls_read): Likewise.
9285 (Fgnutls_boot): Return handshake error code.
9286 (emacs_gnutls_handle_error): New function.
9287 (wsaerror_to_errno): Likewise.
9289 * w32.h (emacs_gnutls_pull): Add prototype.
9290 (emacs_gnutls_push): Likewise.
9292 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9293 (emacs_gnutls_push): Likewise.
9295 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9297 * process.c (wait_reading_process_output): Check if GnuTLS
9298 buffered some data internally if no FDs are set for TLS
9301 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9302 (LIBS): Link to USER_LIBS.
9303 ($(BLD)/gnutls.$(0)): New target.
9305 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9307 * xdisp.c (handle_single_display_spec): Rename the
9308 display_replaced_before_p argument into display_replaced_p, to
9309 make it consistent with the commentary. Fix typos in the
9312 * textprop.c (syms_of_textprop): Remove dead code.
9313 (copy_text_properties): Delete obsolete commentary about an
9314 interface that was deleted long ago. Fix typos in the description
9317 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9318 to changes in oldXMenu/XMenu.h from 2011-04-16.
9319 <menu_help_message, prev_menu_help_message>: Constify.
9320 (IT_menu_make_room): menu->help_text is now `const char **';
9323 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9324 to changes in oldXMenu/XMenu.h from 2011-04-16.
9325 (struct XMenu): Declare `help_text' `const char **'.
9327 * xfaces.c <Qunspecified>: Make extern again.
9329 * syntax.c: Include sys/types.h before including regex.h, as
9332 * doc.c (get_doc_string): Improve the format passed to `error'.
9334 * doprnt.c (doprnt): Improve commentary.
9336 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9338 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9341 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9342 changes in globals.h immediately force recompilation.
9343 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9344 $(CURDIR)/s/ms-w32.h.
9345 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9347 * character.c (Fchar_direction): Function deleted.
9348 (syms_of_character): Don't defsubr it.
9349 <char-direction-table>: Deleted.
9351 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9353 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9354 * doprnt.c: Include limits.h.
9355 (SIZE_MAX): New macro.
9356 (doprnt): Return a size_t value. 2nd arg is now size_t.
9357 Many local variables are now size_t instead of int or unsigned.
9358 Improve overflow protection. Support `l' modifier for integer
9359 conversions. Support %l conversion. Don't assume an EMACS_INT
9360 argument for integer conversions and for %c.
9362 * lisp.h (doprnt): Restore prototype.
9364 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9367 * Makefile.in (base_obj): Add back doprnt.o.
9369 * deps.mk (doprnt.o): Add back prerequisites.
9370 (callint.o): Depend on character.h.
9372 * eval.c (internal_lisp_condition_case): Include the handler
9373 representation in the error message.
9374 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9375 when breaking from the loop.
9377 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9379 * callint.c (Fcall_interactively): When displaying error message
9380 about invalid control letter, pass the character's codepoint, not
9381 a pointer to its multibyte form. Improve display of the character
9382 in octal and display also its hex code.
9384 * character.c (char_string): Use %x to display the (unsigned)
9385 codepoint of an invalid character, to avoid displaying a bogus
9388 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9389 `error', not SYMBOL_NAME itself.
9391 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9392 character arguments to `error'.
9394 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9395 to `error' in error message about FINAL_CHAR argument. Make sure
9396 FINAL_CHAR is a character, and use %c when it is passed as
9397 argument to `error'.
9399 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9401 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9403 * w32.c: Include <time.h>.
9404 (sys_localtime): New function.
9406 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9408 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9410 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9412 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9414 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9417 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9419 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9420 gl_state.e_property when gl_state.object is Qt.
9422 * insdel.c (make_gap_larger): Remove limitation of buffer size
9425 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9427 * xdisp.c (lookup_glyphless_char_display)
9428 (produce_glyphless_glyph): Handle cons cell entry in
9429 glyphless-char-display.
9430 (Vglyphless_char_display): Document it.
9432 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9433 glyphless-char-display.
9435 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9437 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9439 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9441 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9442 definition for no-X builds.
9444 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9446 Static checks with GCC 4.6.0 and non-default toolkits.
9448 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9450 * process.c (keyboard_bit_set): Define only if SIGIO.
9451 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9452 (send_process): Repair possible setjmp clobbering.
9454 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9456 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9458 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9460 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9461 Define only if needed.
9463 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9464 by pacifying GCC about it. Maybe it's time to retire it?
9465 * xfaces.c (USG, __TIMEVAL__): Likewise.
9467 * dispextern.h (struct redisplay_interface): Rename param
9469 * termhooks.h (struct terminal): Likewise.
9470 * xterm.c (xembed_send_message): Likewise.
9472 * insdel.c (make_gap_smaller): Define only if
9473 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9475 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9478 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9479 so that we aren't warned about unused symbols.
9481 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9483 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9485 * xfns.c (x_real_positions): Mark locals as initialized.
9487 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9489 * xterm.c: Fix problems found by static analysis with other toolkits.
9490 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9491 (x_dispatch_event): Declare static if USE_GTK, and
9492 define if USE_GTK || USE_X_TOOLKIT.
9493 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9494 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9495 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9496 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9498 * xmenu.c (menu_help_callback): Pointer type fixes.
9499 Use const pointers when pointing at readonly data. Avoid pointer
9501 (FALSE): Remove unused macro.
9502 (update_frame_menubar): Remove unused decl.
9504 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9506 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9507 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9508 (single_menu_item): Rename local to avoid shadowing.
9510 * keyboard.c (make_lispy_event): Remove unused local var.
9512 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9513 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9515 * bitmaps: Change bitmaps from unsigned char back to the X11
9516 compatible char. Avoid the old compiler warnings about
9517 out-of-range initializers by using, for example, '\xab' rather
9520 * xgselect.c (xgselect_initialize): Check vs interface
9521 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9523 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9525 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9526 to read-only memory.
9528 * fns.c (vector): Remove; this old hack is no longer needed.
9530 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9532 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9534 * xrdb.c (x_load_resources): Omit unused local.
9536 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9537 (x_window): Rename locals to avoid shadowing.
9538 (USG): Use the kludged USG macro, to pacify gcc.
9540 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9541 (x_term_init): Remove local to avoid shadowing.
9543 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9545 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9546 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9548 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9550 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9552 Fix regex.c, syntax.c and friends for buffers > 2GB.
9553 * syntax.h (struct gl_state_s): Declare character position members
9556 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9558 * textprop.c (verify_interval_modification, interval_of):
9559 Declare arguments EMACS_INT.
9561 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9564 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9566 * indent.c (Fvertical_motion): Local variable it_start is now
9569 * regex.c (re_match, re_match_2, re_match_2_internal)
9570 (bcmp_translate, regcomp, regexec, print_double_string)
9571 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9572 (re_compile_pattern, re_exec): Declare arguments and local
9573 variables `size_t' and `ssize_t' and return values `regoff_t', as
9575 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9576 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9577 <compile_stack_type>: `size' and `avail' are now `size_t'.
9579 * regex.h <regoff_t>: Use ssize_t, not int.
9580 (re_search, re_search_2, re_match, re_match_2): Arguments that
9581 specify buffer/string position and length are now ssize_t and
9582 size_t. Return type is regoff_t.
9584 2011-04-16 Ben Key <bkey76@gmail.com>
9586 * nsfont.m: Fixed bugs in ns_get_family and
9587 ns_descriptor_to_entity that were caused by using free to
9588 deallocate memory blocks that were allocated by xmalloc (via
9589 xstrdup). This caused Emacs to crash when compiled with
9590 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9591 --enable-checking=xmallocoverrun). xfree is now used to
9592 deallocate these memory blocks.
9594 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9596 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9598 emacs_write: Accept and return EMACS_INT for sizes.
9599 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9601 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9602 Accept and return EMACS_INT.
9603 (emacs_gnutls_write): Return the number of bytes written on
9605 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9606 (emacs_read, emacs_write): Remove check for negative size, as the
9607 Emacs source code has been audited now.
9608 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9609 (emacs_read, emacs_write): Use it.
9610 * process.c (send_process): Adjust to the new signatures of
9611 emacs_write and emacs_gnutls_write. Do not attempt to store
9612 a byte offset into an 'int'; it might overflow.
9613 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9615 * sound.c: Don't assume sizes fit in 'int'.
9616 (struct sound_device.period_size, alsa_period_size):
9617 Return EMACS_INT, not int.
9618 (struct sound_device.write, vox_write, alsa_write):
9619 Accept EMACS_INT, not int.
9620 (wav_play, au_play): Use EMACS_INT to store sizes and to
9621 record read return values.
9623 2011-04-15 Ben Key <bkey76@gmail.com>
9625 * keyboard.c (Qundefined): Don't declare static since it is used
9627 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9628 static since they are used in nsfont.m.
9630 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9632 * process.c (Qprocessp): Don't declare static.
9633 * lisp.h (Qprocessp): Declare again.
9635 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9637 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9639 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9641 Improve C-level modularity by making more things 'static'.
9643 Don't publish debugger-only interfaces to other modules.
9644 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9645 (verify_bytepos, count_markers): Move decls to the only modules
9647 * region-cache.h (pp_cache): Likewise.
9648 * window.h (check_all_windows): Likewise.
9649 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9651 * sysdep.c (croak): Now static, if
9652 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9653 * syssignal.h (croak): Declare only if not static.
9655 * alloc.c (refill_memory_reserve): Now static if
9656 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9657 * lisp.h (refill_memory_reserve): Declare only if not static.
9659 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9660 Define only if USE_LUCID.
9662 * xrdb.c (x_customization_string, x_rm_string): Now static.
9664 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9665 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9667 * xdisp.c (draw_row_with_mouse_face): Now static.
9668 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9670 * window.h (check_all_windows): Mark externally visible.
9672 * window.c (window_deletion_count): Now static.
9674 * undo.c: Make symbols static if they're not exported.
9675 (last_undo_buffer, last_boundary_position, pending_boundary):
9678 * textprop.c (interval_insert_behind_hooks): Now static.
9679 (interval_insert_in_front_hooks): Likewise.
9681 * term.c: Make symbols static if they're not exported.
9682 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9683 (max_frame_lines, tty_set_terminal_modes):
9684 (tty_reset_terminal_modes, tty_turn_off_highlight):
9685 (get_tty_terminal): Now static.
9686 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9687 * termhooks.h (term_mouse_moveto): Do not declare if
9689 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9690 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9692 * sysdep.c: Make symbols static if they're not exported.
9693 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9695 (sigprocmask_set, full_mask): Remove; unused.
9696 (wait_debugging): Mark as visible.
9697 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9698 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9700 * syntax.c (syntax_temp): Define only if !__GNUC__.
9702 * sound.c (current_sound_device, current_sound): Now static.
9704 * search.c (searchbufs, searchbuf_head): Now static.
9706 * scroll.c (scroll_cost): Remove; unused.
9707 * dispextern.h (scroll_cost): Remove decl.
9709 * region-cache.h (pp_cache): Mark as externally visible.
9711 * process.c: Make symbols static if they're not exported.
9712 (process_tick, update_tick, create_process, chan_process):
9713 (Vprocess_alist, proc_buffered_char, datagram_access):
9714 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9715 (deactivate_process): Mark defn as static, as well as decl.
9716 * lisp.h (create_process): Remove decl.
9717 * process.h (chan_process, Vprocess_alist): Remove decls.
9719 * print.c: Make symbols static if they're not exported.
9720 (print_depth, new_backquote_output, being_printed, print_buffer):
9721 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9722 (print_interval, print_number_index, initial_stderr_stream):
9724 * lisp.h (Fprinc): Remove decl.
9725 (debug_output_compilation_hack): Mark as externally visible.
9727 * sysdep.c (croak): Move decl from here to syssignal.h.
9728 * syssignal.h (croak): Put it here, so the API can be checked when
9729 'croak' is called from dissociate_if_controlling_tty.
9731 * minibuf.c: Make symbols static if they're not exported.
9732 (minibuf_save_list, choose_minibuf_frame): Now static.
9733 * lisp.h (choose_minibuf_frame): Remove decl.
9735 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9737 * lread.c: Make symbols static if they're not exported.
9738 (read_objects, initial_obarray, oblookup_last_bucket_number):
9740 (make_symbol): Remove; unused.
9741 * lisp.h (initial_obarray, make_symbol): Remove decls.
9743 * keyboard.c: Make symbols static if they're not exported.
9744 (single_kboard, recent_keys_index, total_keys, recent_keys):
9745 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9746 (this_single_command_key_start, echoing, last_auto_save):
9747 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9748 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9749 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9750 (Vlispy_mouse_stem, double_click_count):
9752 (force_auto_save_soon): Define only if SIGDANGER.
9753 (ignore_mouse_drag_p): Now static if
9754 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9755 (print_help): Remove; unused.
9756 (stop_character, last_timer_event): Mark as externally visible.
9757 * keyboard.h (ignore_mouse_drag_p): Declare only if
9758 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9759 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9760 * lisp.h (echoing): Remove decl.
9761 (force_auto_save_soon): Declare only if SIGDANGER.
9762 * xdisp.c (redisplay_window): Simplify code, to make it more
9763 obvious that ignore_mouse_drag_p is not accessed if !defined
9764 USE_GTK && !defined HAVE_NS.
9766 * intervals.c: Make symbols static if they're not exported.
9767 (merge_properties_sticky, merge_interval_right, delete_interval):
9769 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9771 * insdel.c: Make symbols static if they're not exported.
9772 However, leave prepare_to_modify_buffer alone. It's never
9773 called from outside this function, but that appears to be a bug.
9774 (combine_after_change_list, combine_after_change_buffer):
9775 (adjust_after_replace, signal_before_change): Now static.
9776 (adjust_after_replace_noundo): Remove; unused.
9777 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9778 (signal_before_change): Remove decls.
9780 * indent.c (val_compute_motion, val_vmotion): Now static.
9782 * image.c: Make symbols static if they're not exported.
9783 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9785 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9786 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9788 * fringe.c (standard_bitmaps): Now static.
9789 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9791 * frame.c: Make symbols static if they're not exported.
9792 (x_report_frame_params, make_terminal_frame): Now static.
9793 (get_frame_param): Now static, unless HAVE_NS.
9794 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9795 (x_get_resource_string): Remove; not used.
9796 * frame.h (make_terminal_frame, x_report_frame_params):
9797 (x_get_resource_string); Remove decls.
9798 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9799 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9801 * font.c, fontset.c: Make symbols static if they're not exported.
9802 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9803 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9804 * font.c (font_close_object): Now static.
9805 * font.h (font_close_object): Remove.
9806 * fontset.c (FONTSET_OBJLIST): Remove.
9807 (free_realized_fontset) #if-0 the body, which does nothing.
9808 (face_suitable_for_char_p): #if-0, as it's never called.
9809 * fontset.h (face_suitable_for_char_p): Remove decl.
9810 * xfaces.c (face_at_string_position):
9811 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9812 since 0 is always ASCII.
9814 * fns.c (weak_hash_tables): Now static.
9816 * fileio.c: Make symbols static if they're not exported.
9817 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9818 (Vwrite_region_annotation_buffers): Now static.
9820 * eval.c: Make symbols static if they're not exported.
9821 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9822 * lisp.h (backtrace_list): Remove decl.
9824 * emacs.c: Make symbols static if they're not exported.
9825 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9826 (fatal_error_code, fatal_error_signal_hook, standard_args):
9828 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9829 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9830 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9831 * lisp.h (fatal_error_signal_hook): Remove decl.
9832 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9834 * editfns.c: Move a (normally-unused) function to its only use.
9835 * editfns.c, lisp.h (get_operating_system_release): Remove.
9836 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9837 worth the hassle of breaking this out.
9839 * xterm.c: Make symbols static if they're not exported.
9840 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9841 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9842 (x_destroy_window, x_delete_display):
9844 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9845 (x_mouse_leave): Remove; unused.
9846 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9847 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9848 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9850 (x_mouse_leave): Declare only if WINDOWSNT.
9851 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9852 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9855 * ftxfont.c: Make symbols static if they're not exported.
9856 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9858 * font.h (ftxfont_driver): Likewise.
9860 * xfns.c: Make symbols static if they're not exported.
9861 (x_last_font_name, x_display_info_for_name):
9862 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9863 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9864 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9865 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9866 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9867 (last_show_tip_args): Now static.
9868 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9869 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9870 (x_screen_planes): Remove; unused.
9871 * dispextern.h (x_screen_planes): Remove decl.
9873 * dispnew.c: Make symbols static if they're not exported.
9874 * dispextern.h (redraw_garbaged_frames, scrolling):
9875 (increment_row_positions): Remove.
9876 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9877 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9879 (redraw_garbaged_frames): Remove; unused.
9881 * xfaces.c: Make symbols static if they're not exported.
9882 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9884 * xterm.h (defined_color): Remove decls.
9885 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9886 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9887 (menu_face_changed_default, defined_color, free_realized_face):
9888 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9889 (ascii_face_of_lisp_face): Remove; unused.
9891 * xdisp.c: Make symbols static if they're not exported.
9892 * dispextern.h (scratch_glyph_row, window_box_edges):
9893 (glyph_to_pixel_coords, set_cursor_from_row):
9894 (get_next_display_element, set_iterator_to_next):
9895 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9896 (show_mouse_face): Remove decls
9897 * frame.h (message_buf_print): Likewise.
9898 * lisp.h (pop_message, set_message, check_point_in_composition):
9900 * xterm.h (set_vertical_scroll_bar): Likewise.
9901 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9902 (message_buf_print, scratch_glyph_row, displayed_buffer):
9903 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9904 (get_next_display_element, show_mouse_face, window_box_edges):
9905 (frame_to_window_pixel_xy, check_point_in_composition):
9906 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9907 (glyph_to_pixel_coords): Remove; unused.
9909 * dired.c (file_name_completion): Now static.
9911 * dbusbind.c (xd_in_read_queued_messages): Now static.
9913 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9914 * data.c (circular_list_error): Remove.
9916 * commands.h (last_point_position, last_point_position_buffer):
9917 (last_point_position_window): Remove decls.
9918 * keyboard.c: Make these variables static.
9920 * coding.h (coding, code_convert_region, encode_coding_gap):
9922 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9923 (iso_code_class, detect_coding, code_convert_region): Now static.
9924 (encode_coding_gap): Remove; unused.
9926 * chartab.c (chartab_chars, chartab_bits): Now static.
9928 * charset.h (charset_iso_8859_1): Remove decl.
9929 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9932 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9933 * ccl.c (Vccl_program_table): Now static.
9934 (check_ccl_update): Remove; unused.
9936 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9937 * category.h: ... from here.
9938 * category.c (check_category_table, set_category_set): Now static.
9940 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9941 * lisp.h: Remove these decls.
9943 * buffer.c (buffer_count): Remove unused var.
9945 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9946 so that it's not optimized away.
9947 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9948 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9949 exported only to the debugger.
9951 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9952 * atimer.h (run_all_atimers): Remove; not exported.
9954 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9955 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9956 was inaccessible from Lisp.
9957 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9958 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9960 alloc.c: Import and export fewer symbols, and remove unused items.
9961 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9963 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9964 it's not optimized away by whole-program optimization.
9965 (message_enable_multibyte, free_misc): Remove.
9966 (catchlist, handlerlist, mark_backtrace):
9967 Declare only if BYTE_MARK_STACK.
9968 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9969 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9970 (message_enable_multibyte): Remove decl.
9971 (free_misc, interval_free_list, float_block, float_block_index):
9972 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9973 (cons_free_list, last_marked_index):
9975 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9976 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9977 (mark_backtrace): Define only if BYTE_MARK_STACK.
9978 * xdisp.c (message_enable_multibyte): Now static.
9980 Declare Lisp_Object Q* variables to be 'static' if not exported.
9981 This makes it easier for human readers (and static analyzers)
9982 to see whether these variables are used from other modules.
9983 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9984 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9985 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9986 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9987 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9988 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9989 * xmenu.c, xselect.c:
9990 Declare Q* vars static if they are not used in other modules.
9991 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9992 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9993 Remove decls of unexported vars.
9994 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9996 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9998 Make Emacs functions such as Fatom 'static' by default.
9999 This makes it easier for human readers (and static analyzers)
10000 to see whether these functions can be called from other modules.
10001 DEFUN now defines a static function. To make the function external
10002 so that it can be used in other C modules, use the new macro DEFUE.
10003 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10004 (Finit_image_library):
10005 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10006 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10007 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10008 Remove decls, since these functions are now static.
10009 (Funintern, Fget_internal_run_time): New decls, since these functions
10010 were already external.
10012 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10013 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10014 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10015 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10016 * keyboard.c, keymap.c, lread.c:
10017 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10018 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10019 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10020 Mark functions with DEFUE instead of DEFUN,
10021 if they are used in other modules.
10022 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10023 decls for now-static functions.
10024 * buffer.h (Fdelete_overlay): Remove decl.
10025 * callproc.c (Fgetenv_internal): Mark as internal.
10026 * composite.c (Fremove_list_of_text_properties): Remove decl.
10027 (Fcomposition_get_gstring): New forward static decl.
10028 * composite.h (Fcomposite_get_gstring): Remove decl.
10029 * dired.c (Ffile_attributes): New forward static decl.
10030 * doc.c (Fdocumntation_property): New forward static decl.
10031 * eval.c (Ffetch_bytecode): New forward static decl.
10032 (Funintern): Remove extern decl; now in .h file where it belongs.
10033 * fileio.c (Fmake_symbolic_link): New forward static decl.
10034 * image.c (Finit_image_library): New forward static decl.
10035 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10036 * intervals.h (Fprevious_property_change):
10037 (Fremove_list_of_text_properties): Remove decls.
10038 * keyboard.c (Fthis_command_keys): Remove decl.
10039 (Fcommand_execute): New forward static decl.
10040 * keymap.c (Flookup_key): New forward static decl.
10041 (Fcopy_keymap): Now static.
10042 * keymap.h (Flookup_key): Remove decl.
10043 * process.c (Fget_process): New forward static decl.
10044 (Fprocess_datagram_address): Mark as internal.
10045 * syntax.c (Fsyntax_table_p): New forward static decl.
10046 (skip_chars): Remove duplicate decl.
10047 * textprop.c (Fprevious_property_change): New forward static decl.
10048 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10050 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10051 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10053 * editfns.c (Fformat): Remove unreachable code.
10055 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10057 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10060 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10062 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10063 when at ZV. (Bug#8487)
10065 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10067 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10069 * keyboard.c (parse_tool_bar_item): Likewise.
10070 * sound.c (sound_cleanup, alsa_close): Likewise.
10071 * termcap.c (tgetent): Likewise.
10072 * xfns.c (x_default_font_parameter): Likewise.
10073 * xsettings.c (read_and_apply_settings): Likewise.
10075 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10076 (overrun_check_free): Protoize.
10078 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10080 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10081 since callers should never pass a negative size.
10082 Change the signature to match that of plain 'read' and 'write'; see
10083 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10084 * lisp.h: Update prototypes of emacs_write and emacs_read.
10086 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10088 * xdisp.c (redisplay_window): Don't try to determine the character
10089 position of the scroll margin if the window start point w->startp
10090 is outside the buffer's accessible region. (Bug#8468)
10092 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10094 Fix write-region and its subroutines for buffers > 2GB.
10095 * fileio.c (a_write, e_write): Modify declaration of arguments and
10096 local variables to support buffers larger than 2GB.
10097 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10099 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10100 argument, local variables, and return value.
10102 * lisp.h: Update prototypes of emacs_write and emacs_read.
10104 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10106 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10108 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10110 Fix more problems found by GCC 4.6.0's static checks.
10112 * xdisp.c (vmessage): Use a better test for character truncation.
10114 * charset.c (load_charset_map): <, not <=, for optimization,
10115 and to avoid potential problems with integer overflow.
10116 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10117 * casetab.c (set_identity, shuffle): Likewise.
10118 * editfns.c (Fformat): Likewise.
10119 * syntax.c (skip_chars): Likewise.
10121 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10122 This also lets GCC 4.6.0 generate slightly better loop code.
10124 * callint.c (Fcall_interactively): <, not <=, for optimization.
10125 (Fcall_interactively): Count the number of arguments produced,
10126 not the number of arguments given. This is simpler and lets GCC
10127 4.6.0 generate slightly better code.
10129 * ftfont.c: Distingish more carefully between FcChar8 and char.
10130 The previous code passed unsigned char * to a functions like
10131 strlen and xstrcasecmp that expect char *, which does not
10132 conform to the C standard.
10133 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10134 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10135 char * when the C standard requires it.
10137 * keyboard.c (read_char): Remove unused var.
10139 * eval.c: Port to Windows vsnprintf (Bug#8435).
10140 Include <limits.h>.
10141 (SIZE_MAX): Define if the headers do not.
10142 (verror): Do not give up if vsnprintf returns a negative count.
10143 Instead, grow the buffer. This ports to Windows vsnprintf, which
10144 does not conform to C99. Problem reported by Eli Zaretskii.
10145 Also, simplify the allocation scheme, by avoiding the need for
10146 calling realloc, and removing the ALLOCATED variable.
10148 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10150 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10151 But keep the doprint source code for now, as we might revamp it
10152 and use it again (Bug#8435).
10153 * lisp.h (doprnt): Remove.
10154 * Makefile.in (base_obj): Remove doprnt.o.
10155 * deps.mk (doprnt.o): Remove.
10157 error: Print 32- and 64-bit integers portably (Bug#8435).
10158 Without this change, on typical 64-bit hosts error ("...%d...", N)
10159 was used to print both 32- and 64-bit integers N, which relied on
10160 undefined behavior.
10161 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10162 * lisp.h (error, verror): Mark as printf-like functions.
10163 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10164 Report overflow in size calculations when allocating printf buffer.
10165 Do not truncate output string at its first null byte.
10166 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10167 Truncate the output at a character boundary, since vsnprintf does not
10169 * charset.c (check_iso_charset_parameter): Convert internal
10170 character to string before calling 'error', since %c now has the
10172 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10173 overflow when computing char to be passed to 'error'. Do not
10174 pass Lisp_Object to 'error'; pass the integer instead.
10175 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10176 formatted with plain %d.
10178 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10180 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10182 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10184 * xterm.c (x_catch_errors): Remove duplicate declaration.
10186 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10188 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10190 2011-04-10 Jim Meyering <meyering@redhat.com>
10192 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10193 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10194 return ssize_t not "int", and use size_t as the buffer length.
10195 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10196 * gnutls.h: Update declarations.
10197 * process.c (read_process_output): Use ssize_t, to match.
10198 (send_process): Likewise.
10200 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10202 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10204 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10206 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10207 Use unsigned char, to match FcChar8 type definition.
10209 * xterm.c (handle_one_xevent):
10210 * xmenu.c (create_and_show_popup_menu):
10211 * xselect.c (x_decline_selection_request)
10212 (x_reply_selection_request): Avoid type-punned deref of X events.
10214 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10216 Fix some uses of `int' instead of EMACS_INT.
10217 * search.c (string_match_1, fast_string_match)
10218 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10219 (scan_buffer, find_next_newline_no_quit)
10220 (find_before_next_newline, search_command, Freplace_match)
10221 (Fmatch_data): Make some `int' variables be EMACS_INT.
10223 * xdisp.c (display_count_lines): 3rd argument and return value now
10224 EMACS_INT. All callers changed.
10225 (pint2hrstr): Last argument is now EMACS_INT.
10227 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10228 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10229 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10230 (decode_coding_utf_16, decode_coding_emacs_mule)
10231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10232 (decode_coding_ccl, decode_coding_charset)
10233 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10234 (decode_coding_iso_2022, decode_coding_emacs_mule)
10235 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10236 <char_offset, last_offset>: Declare EMACS_INT.
10237 (encode_coding_utf_8, encode_coding_utf_16)
10238 (encode_coding_emacs_mule, encode_invocation_designation)
10239 (encode_designation_at_bol, encode_coding_iso_2022)
10240 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10241 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10243 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10244 (encode_invocation_designation): Last argument P_NCHARS is now
10246 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10247 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10249 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10252 * ccl.c (Fccl_execute_on_string): Declare some variables
10255 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10257 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10259 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10261 * process.c (Fformat_network_address): Doc fix.
10263 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10265 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10267 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10269 * keyboard.c (read_char): Call Lisp function help-form-show,
10270 instead of using internal_with_output_to_temp_buffer.
10271 (Qhelp_form_show): New var.
10272 (syms_of_keyboard): Use DEFSYM macro.
10274 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10276 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10278 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10280 * process.c (Flist_processes): Remove to Lisp.
10281 (list_processes_1): Delete.
10283 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10285 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10287 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10289 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10291 Fix more problems found by GCC 4.6.0's static checks.
10293 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10295 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10297 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10299 * xdisp.c (vmessage): Mark as a printf-like function.
10301 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10303 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10305 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10306 printf-like functions.
10307 (tiff_load): Add casts to remove these marks before passing them
10308 to system-supplied API.
10310 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10312 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10313 This avoids several warnings with gcc -Wstrict-overflow.
10314 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10315 directly, rather than having caller test rule sign. This avoids
10316 some unnecessary tests.
10317 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10318 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10319 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10321 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10322 (xfont_open): Avoid unnecessary tests.
10324 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10326 * composite.h, composite.c (composition_gstring_put_cache):
10327 Use EMACS_INT, not int, for length.
10329 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10330 breaking out part of COMPOSITION_DECODE_RULE.
10331 (COMPOSITION_DECODE_RULE): Use it.
10332 * composite.c (get_composition_id): Remove unused local vars,
10333 by using the new macro.
10335 * textprop.c (set_text_properties_1): Change while to do-while,
10336 since the condition is always true at first.
10338 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10339 (interval_deletion_adjustment): Return unsigned value.
10342 * process.c (list_processes_1, create_pty, read_process_output):
10343 (exec_sentinel): Remove vars that were set but not used.
10344 (create_pty): Remove unnecessary "volatile"s.
10345 (Fnetwork_interface_info): Avoid possibility of int overflow.
10346 (read_process_output): Do adaptive read buffering even if carryover.
10347 (read_process_output): Simplify nbytes computation if buffered.
10349 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10351 * syntax.c (scan_words): Remove var that was set but not used.
10352 (update_syntax_table): Use unsigned instead of int.
10354 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10355 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10356 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10358 * print.c (print_error_message): Avoid int overflow.
10360 * font.c (font_list_entities): Redo for clarity,
10361 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10363 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10364 (font_score): Avoid potential overflow in diff calculation.
10366 * fns.c (substring_both): Remove var that is set but not used.
10367 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10369 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10371 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10372 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10373 can always succeed if overflow has undefined behavior.
10375 * search.c (boyer_moore, wordify): Remove vars set but not used.
10376 (wordify): Omit three unnecessary tests.
10378 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10379 All callers changed. This avoids the need for an unused var.
10381 * casefiddle.c (casify_region): Remove var that is set but not used.
10383 * dired.c (file_name_completion): Remove var that is set but not used.
10385 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10387 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10388 (Finsert_file_contents): Remove unnecessary code checking fd.
10390 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10391 Check for integer overflow on size calculations.
10393 * buffer.c (Fprevious_overlay_change): Remove var that is set
10396 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10397 Remove vars that are set but not used.
10398 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10399 (timer_check_2): Mark vars as initialized.
10401 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10403 * image.c (lookup_image): Remove var that is set but not used.
10404 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10406 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10407 that are set but not used.
10409 * xfns.c (make_invisible_cursor): Don't return garbage
10410 if XCreateBitmapFromData fails (Bug#8410).
10412 * xselect.c (x_get_local_selection, x_handle_property_notify):
10413 Remove vars that are set but not used.
10415 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10416 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10418 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10419 Remove var that is set but not used.
10420 (scroll_bar_windows_size): Now size_t, not int.
10421 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10422 Check for overflow.
10424 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10425 (map_tty_color) [!defined MSDOS]: Likewise.
10427 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10429 * coding.c: Remove vars that are set but not used.
10430 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10431 All callers changed.
10432 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10433 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10434 (decode_coding_charset): Remove vars that are set but not used.
10436 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10437 that is set but not used.
10439 * print.c (print_object): Remove var that is set but not used.
10441 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10442 The gnulib version avoids calling malloc in the usual case,
10443 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10444 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10445 * filelock.c (current_lock_owner): Likewise.
10446 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10447 * sysdep.c: Include allocator.h, careadlinkat.h.
10448 (emacs_no_realloc_allocator): New static constant.
10449 (emacs_readlink): New function.
10450 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10451 ../lib/careadlinkat.h.
10453 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10455 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10456 first non-nil return value).
10458 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10460 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10461 if not defined (Bug#8403).
10463 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10465 * xdisp.c (display_count_lines): Remove parameter `start',
10466 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10467 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10468 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10469 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10470 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10471 and thereabouts. All callers changed.
10472 (get_per_char_metric): Remove parameter `f', unused since
10473 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10475 2011-04-02 Jim Meyering <meyering@redhat.com>
10477 do not dereference NULL upon failed strdup
10478 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10479 (ns_get_family): Likewise.
10481 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10483 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10485 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10487 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10490 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10492 Add lexical binding.
10494 * window.c (Ftemp_output_buffer_show): New fun.
10495 (Fsave_window_excursion):
10496 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10498 * lread.c (lisp_file_lexically_bound_p): New function.
10499 (Fload): Bind Qlexical_binding.
10500 (readevalloop): Remove `evalfun' arg.
10501 Bind Qinternal_interpreter_environment.
10502 (Feval_buffer): Bind Qlexical_binding.
10503 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10505 (syms_of_lread): Declare `lexical-binding'.
10507 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10509 * keyboard.c (eval_dyn): New fun.
10510 (menu_item_eval_property): Use it.
10512 * image.c (parse_image_spec): Use Ffunctionp.
10514 * fns.c (concat, mapcar1): Accept byte-code-functions.
10516 * eval.c (Fsetq): Handle lexical vars.
10517 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10518 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10519 (FletX, Flet): Obey lexical binding.
10520 (Fcommandp): Handle closures.
10521 (Feval): New `lexical' arg.
10522 (eval_sub): New function extracted from Feval. Use it almost
10523 everywhere where Feval was used. Look up vars in lexical env.
10525 (Ffunctionp): Move from subr.el.
10526 (Ffuncall): Handle closures.
10527 (apply_lambda): Remove `eval_flags'.
10528 (funcall_lambda): Handle closures and new byte-code-functions.
10529 (Fspecial_variable_p): New function.
10530 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10531 but without exporting it to Lisp.
10533 * doc.c (Fdocumentation, store_function_docstring):
10534 * data.c (Finteractive_form): Handle closures.
10536 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10539 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10541 (exec_byte_code): New function extracted from Fbyte_code to handle new
10542 calling convention for byte-code-functions. Add new byte-codes.
10544 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10546 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10548 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10550 * xdisp.c (redisplay_internal): Fix prototype.
10552 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10554 * xdisp.c (SCROLL_LIMIT): New macro.
10555 (try_scrolling): Use it when setting scroll_limit.
10556 Limit scrolling to 100 screen lines.
10557 (redisplay_window): Even when falling back on "recentering",
10558 position point in the window according to scroll-conservatively,
10559 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10561 (try_scrolling): When point is above the window, allow searching
10562 as far as scroll_max, or one screenful, to compute vertical
10563 distance from PT to the scroll margin position. This prevents
10564 try_scrolling from unnecessarily failing when
10565 scroll-conservatively is set to a value slightly larger than the
10566 window height. Clean up the case of PT below the margin at bottom
10567 of window: scroll_max can no longer be INT_MAX. When aggressive
10568 scrolling is in use, don't let point enter the opposite scroll
10569 margin as result of the scroll.
10570 (syms_of_xdisp) <scroll-conservatively>: Document the
10571 threshold of 100 lines for never-recentering scrolling.
10573 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10575 * dispextern.h (move_it_by_lines):
10576 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10577 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10578 (message_log_check_duplicate): Remove parameters `prev_bol' and
10579 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10580 (redisplay_internal): Remove parameter `preserve_echo_area',
10581 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10583 * indent.c (Fvertical_motion):
10584 * window.c (window_scroll_pixel_based, Frecenter):
10585 Don't pass `need_y_p' to `move_it_by_lines'.
10587 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10589 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10590 steal a few bits to be more compact.
10591 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10592 Remove unneeded casts.
10594 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10596 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10598 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10599 binding" message (bug#7967).
10601 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10603 Fix more problems found by GCC 4.6.0's static checks.
10605 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10606 Remove unused local var.
10608 * editfns.c (Fmessage_box): Remove unused local var.
10610 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10611 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10612 Omit unused local vars.
10613 * window.c (shrink_windows): Omit unused local var.
10614 * menu.c (digest_single_submenu): Omit unused local var.
10615 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10616 Omit unused local var.
10618 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10619 Don't assume string length fits in int.
10620 (keyremap_step, read_key_sequence): Use size_t for sizes.
10621 (read_key_sequence): Don't check last_real_key_start redundantly.
10623 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10624 instead of alloca (Bug#8344).
10626 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10627 (Fbacktrace_frame): Don't assume nframes fits in int.
10629 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10631 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10634 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10636 * cm.c (calccost): Turn while-do into do-while, for clarity.
10638 * keyboard.c (syms_of_keyboard): Use the same style as later
10639 in this function when indexing through an array. This also
10640 works around GCC bug 48267.
10642 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10644 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10646 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10647 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10649 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10650 This avoids undefined behavior on integer overflow, and is a bit
10651 more convenient anyway since it is compared to a size_t variable.
10653 Variadic C functions now count arguments with size_t, not int.
10654 This avoids an unnecessary limitation on 64-bit machines, which
10655 caused (substring ...) to crash on large vectors (Bug#8344).
10656 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10657 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10658 All variadic functions and their callers changed accordingly.
10659 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10660 * data.c (arith_driver, float_arith_driver): Likewise.
10661 * editfns.c (general_insert_function): Likewise.
10662 * eval.c (struct backtrace.nargs, interactive_p)
10663 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10664 (funcall_lambda, mark_backtrace): Likewise.
10665 * fns.c (concat): Likewise.
10666 * frame.c (x_set_frame_parameters): Likewise.
10667 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10668 0 if not found, not -1. All callers changed.
10670 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10671 (stack_copy_size): Now size_t, not int.
10672 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10674 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10676 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10677 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10678 All callers changed.
10680 * lisp.h (multibyte_char_to_unibyte):
10681 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10682 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10683 * character.h (CHAR_TO_BYTE8):
10684 * cmds.c (internal_self_insert):
10685 * editfns.c (general_insert_function):
10686 * keymap.c (push_key_description):
10687 * search.c (Freplace_match):
10688 * xdisp.c (message_dolog, set_message_1): All callers changed.
10690 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10692 * keyboard.c (safe_run_hook_funcall): New function.
10693 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10694 don't set the hook to nil, but remove the offending function instead.
10695 (Qcommand_hook_internal): Remove, unused.
10696 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10697 Vcommand_hook_internal.
10699 * eval.c (enum run_hooks_condition): Remove.
10700 (funcall_nil, funcall_not): New functions.
10701 (run_hook_with_args): Call each function through a `funcall' argument.
10702 Remove `cond' argument, now redundant.
10703 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10704 (Frun_hook_with_args_until_failure): Adjust accordingly.
10705 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10707 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10709 * dispextern.h (string_buffer_position): Remove declaration.
10711 * print.c (strout): Remove parameter `multibyte', unused since
10712 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10714 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10715 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10716 All callers changed.
10718 * w32.c (_wsa_errlist): Use braces for struct initializers.
10720 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10721 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10722 All callers changed.
10723 (string_buffer_position): Likewise. Also, make static (it's never
10724 used outside xdisp.c).
10725 (cursor_row_p): Remove parameter `w', unused since
10726 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10727 (decode_mode_spec): Remove parameter `precision', introduced during
10728 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10729 All callers changed.
10731 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10733 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10735 2011-03-27 Anders Lindgren <andlind@gmail.com>
10737 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10738 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10739 (ns_update_auto_hide_menu_bar): New functions.
10740 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10741 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10742 ns_constrain_all_frames.
10743 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10744 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10746 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10748 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10750 2011-03-27 Glenn Morris <rgm@gnu.org>
10752 * syssignal.h: Replace RETSIGTYPE with void.
10753 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10754 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10755 Replace SIGTYPE with void everywhere.
10756 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10757 * s/template.h (SIGTYPE): Remove commented out definition.
10759 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10761 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10762 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10764 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10766 * w32.c (read_unc_volume): Use parameter `henum', instead of
10767 global variable `wget_enum_handle'.
10769 * keymap.c (describe_vector): Remove parameters `indices' and
10770 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10771 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10773 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10775 * keyboard.c (timer_check): Remove parameter `do_it_now',
10776 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10777 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10778 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10780 * keyboard.c (read_char):
10781 * w32menu.c (w32_menu_display_help):
10782 * xmenu.c (show_help_event, menu_help_callback):
10783 Adjust calls to `show_help_echo'.
10785 * gtkutil.c (xg_maybe_add_timer):
10786 * keyboard.c (readable_events):
10787 * process.c (wait_reading_process_output):
10788 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10790 * insdel.c (adjust_markers_gap_motion):
10791 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10792 (gap_left, gap_right): Don't call it.
10794 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10796 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10797 incurred during fontification.
10799 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10801 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10802 (DEFVAR_PER_BUFFER): Don't pass it.
10804 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10805 (scrolling_window): Don't pass it.
10807 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10809 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10811 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10813 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10814 of variables specific to SELinux and computation of `encoded_absname'.
10816 * image.c (XPutPixel): Remove unused variable `height'.
10818 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10820 * unexw32.c (get_section_info): Remove unused variable `section'.
10822 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10823 (system_process_attributes): Remove unused variable `sess'.
10824 (sys_read): Remove unused variable `err'.
10826 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10827 (w32_wnd_proc): Remove unused variable `isdead'.
10828 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10829 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10830 (x_create_tip_frame): Remove unused variable `tem'.
10832 * w32inevt.c (w32_console_read_socket):
10833 Remove unused variable `no_events'.
10835 * w32term.c (x_draw_composite_glyph_string_foreground):
10836 Remove unused variable `width'.
10838 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10840 * w32term.c (x_set_glyph_string_clipping):
10841 Don't pass uninitialized region to CombineRgn.
10843 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10845 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10846 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10847 (Fx_close_connection): Remove unused variable `i'.
10849 * w32font.c (w32font_draw): Return number of glyphs.
10850 (w32font_open_internal): Remove unused variable `i'.
10851 (w32font_driver): Add missing initializer.
10853 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10854 (fill_in_menu): Remove unused variable `items_added'.
10856 * w32term.c (last_mouse_press_frame): Remove static global variable.
10857 (w32_clip_to_row): Remove unused variable `f'.
10858 (x_delete_terminal): Remove unused variable `i'.
10860 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10861 (NOTHING): Remove unused static global variable.
10862 (uniscribe_check_otf): Remove unused variable `table'.
10863 (uniscribe_font_driver): Add missing initializers.
10865 2011-03-23 Julien Danjou <julien@danjou.info>
10867 * term.c (Fsuspend_tty, Fresume_tty):
10868 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10869 * window.c (temp_output_buffer_show):
10870 * insdel.c (signal_before_change):
10871 * frame.c (Fhandle_switch_frame):
10872 * fileio.c (Fdo_auto_save):
10873 * emacs.c (Fkill_emacs):
10874 * editfns.c (save_excursion_restore):
10875 * cmds.c (internal_self_insert):
10876 * callint.c (Fcall_interactively):
10877 * buffer.c (Fkill_all_local_variables):
10878 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10880 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10881 unconditionally since it does the check itself.
10883 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10885 Fix more problems found by GCC 4.5.2's static checks.
10887 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10888 the first time through the loop, since we know p0 < p1 then.
10889 This also avoids a gcc -Wstrict-overflow warning.
10891 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10892 leading to a memory leak, possible in functions like
10893 load_charset_map_from_file that can allocate an unbounded number
10894 of objects (Bug#8318).
10896 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10897 that could (at least in theory) be that large.
10899 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10900 This is less likely to overflow, and avoids undefined behavior if
10901 overflow does occur. All callers changed. Use strtoul to scan
10902 for the unsigned long integer.
10903 (pint2hrstr): Simplify and tune code slightly.
10904 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10906 * scroll.c (do_scrolling): Work around GCC bug 48228.
10907 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10909 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10910 This also avoids a warning with gcc -Wstrict-overflow.
10911 (validate_x_resource_name): Simplify count usage.
10912 This also avoids a warning with gcc -Wstrict-overflow.
10914 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10917 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10919 * process.c (Fmake_network_process): Use socklen_t, not int,
10920 where POSIX says socklen_t is required in portable programs.
10921 This fixes a porting bug on hosts like 64-bit HP-UX, where
10922 socklen_t is wider than int (Bug#8277).
10923 (Fmake_network_process, server_accept_connection):
10924 (wait_reading_process_output, read_process_output):
10927 * process.c: Rename or move locals to avoid shadowing.
10928 (list_processes_1, Fmake_network_process):
10929 (read_process_output_error_handler, exec_sentinel_error_handler):
10930 Rename or move locals.
10931 (Fmake_network_process): Define label "retry_connect" only if needed.
10932 (Fnetwork_interface_info): Fix pointer signedness.
10933 (process_send_signal): Add cast to avoid pointer signedness problem.
10934 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10935 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10937 Make tparam.h and terminfo.c consistent.
10938 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10939 Include tparam.h instead, since it declares them.
10940 * cm.h (PC): Remove extern decl; tparam.h now does this.
10941 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10942 * terminfo.c: Include tparam.h, to check interfaces.
10943 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10944 (tparam): Adjust signature to match interface in tparam.h;
10945 this removes some undefined behavior. Check that outstring and len
10946 are zero, which they always are with Emacs.
10947 * tparam.h (PC, BC, UP): New extern decls.
10949 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10950 (xftfont_open): Rename locals to avoid shadowing.
10952 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10953 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10954 (OTF_TAG_SYM): Omit macro if not needed.
10955 (ftfont_list): Remove unused local.
10956 (get_adstyle_property, ftfont_pattern_entity):
10957 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10958 Rename locals to avoid shadowing.
10960 * xfont.c (xfont_list_family): Mark var as initialized.
10962 * xml.c (make_dom): Now static.
10964 * composite.c (composition_compute_stop_pos): Rename local to
10966 (composition_reseat_it): Remove unused locals.
10967 (find_automatic_composition, composition_adjust_point): Likewise.
10968 (composition_update_it): Mark var as initialized.
10969 (find_automatic_composition): Mark vars as initialized,
10970 with a FIXME (Bug#8290).
10972 character.h: Rename locals to avoid shadowing.
10973 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10974 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10975 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10976 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10977 to avoid shadowing.
10979 * textprop.c (property_change_between_p): Remove; unused.
10981 * intervals.c (interval_start_pos): Now static.
10983 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10985 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10986 Rename locals to avoid shadowing.
10988 * sound.c (wav_play, au_play, Fplay_sound_internal):
10989 Fix pointer signedness.
10990 (alsa_choose_format): Remove unused local var.
10991 (wav_play): Initialize a variable to 0, to prevent undefined
10992 behavior (Bug#8278).
10994 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10996 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10998 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10999 clobbering (Bug#8298).
11000 * sysdep.c (sys_subshell): Likewise.
11001 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11003 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11004 This should get cleaned up, so that child_setup has the
11005 same signature on all platforms.
11007 * callproc.c (call_process_cleanup): Now static.
11008 (relocate_fd): Rename locals to avoid shadowing.
11010 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11012 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11013 not to be necessary, and produces flickering.
11015 2011-03-20 Glenn Morris <rgm@gnu.org>
11017 * config.in: Remove file.
11019 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11021 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11022 are now in src/globals.h.
11023 (syms_of_minibuf): Remove spurious & from previous change.
11025 2011-03-20 Leo Liu <sdl.web@gmail.com>
11027 * minibuf.c (completing-read-function): New variable.
11028 (completing-read-default): Rename from completing-read.
11029 (completing-read): Call completing-read-function.
11031 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11033 * xfaces.c (Fx_load_color_file):
11034 Read color file from absolute filename (bug#8250).
11036 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11038 * makefile.w32-in: Update dependencies.
11040 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11042 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11044 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11046 Fix more problems found by GCC 4.5.2's static checks.
11048 * process.c (make_serial_process_unwind, send_process_trap):
11049 (sigchld_handler): Now static.
11051 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11052 That way, the code declares only the vars that it needs.
11053 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11054 * s/cygwin.h (PTY_ITERATION): Likewise.
11055 * s/darwin.h (PTY_ITERATION): Likewise.
11056 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11058 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11059 * process.c (allocate_pty): Don't declare stb unless it's needed.
11061 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11062 (CONSTANTLIM): Remove; unused.
11063 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11064 Define only if needed.
11066 * unexelf.c (unexec): Name an expression,
11067 to avoid gcc -Wbad-function-cast warning.
11068 Use a different way to cause a compilation error if anyone uses
11069 n rather than nn, a way that does not involve shadowing.
11070 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11072 * deps.mk (unexalpha.o): Remove; unused.
11074 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11075 * unexec.h: New file.
11076 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11077 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11078 Depend on unexec.h.
11079 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11080 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11081 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11082 Change as necessary to match prototype in unexec.h.
11084 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11086 (back_comment, skip_chars): Mark vars as initialized.
11088 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11089 Rename locals to avoid shadowing.
11091 * lread.c (read1): Rewrite so as not to use empty "else".
11092 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11094 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11096 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11097 warning when compiling print.c.
11099 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11100 instead of using an uninitialized var.
11101 (font_sort_entities): Mark var as initialized.
11103 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11105 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11106 pointers to constants.
11107 (font_parse_fcname): Remove unused vars.
11108 (font_delete_unmatched): Now static.
11109 (font_get_spec): Remove; unused.
11110 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11111 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11112 Rename or move locals to avoid shadowing.
11114 * fns.c (require_nesting_list, require_unwind): Now static.
11115 (Ffillarray): Rename locals to avoid shadowing.
11117 * floatfns.c (domain_error2): Define only if needed.
11118 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11120 * alloc.c (mark_backtrace): Move decl from here ...
11121 * lisp.h: ... to here, so that it can be checked.
11123 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11124 (Fdefvar): Rewrite so as not to use empty "else".
11125 (lisp_indirect_variable): Name an expression,
11126 to avoid gcc -Wbad-function-cast warning.
11127 (Fdefvar): Rename locals to avoid shadowing.
11129 * callint.c (quotify_arg, quotify_args): Now static.
11130 (Fcall_interactively): Rename locals to avoid shadowing.
11131 Use const pointer when appropriate.
11133 * lisp.h (get_system_name, get_operating_system_release):
11134 Move decls here, to check interfaces.
11135 * process.c (get_operating_system_release): Move decl to lisp.h.
11136 * xrdb.c (get_system_name): Likewise.
11137 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11138 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11139 some of which prompt warnings from gcc -Wbad-function-cast.
11140 (Fformat_time_string, Fencode_time, Finsert_char):
11141 (Ftranslate_region_internal, Fformat):
11142 Rename or remove local vars to avoid shadowing.
11143 (Ftranslate_region_internal): Mark var as initialized.
11145 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11148 * lisp.h (eassert): Check that the argument compiles, even if
11149 ENABLE_CHECKING is not defined.
11151 * data.c (Findirect_variable): Name an expression, to avoid
11152 gcc -Wbad-function-cast warning.
11153 (default_value, arithcompare, arith_driver, arith_error): Now static.
11154 (store_symval_forwarding): Rename local to avoid shadowing.
11155 (Fmake_variable_buffer_local, Fmake_local_variable):
11156 Mark variables as initialized.
11157 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11159 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11160 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11161 Rename locals to avoid shadowing.
11162 (mark_stack): Move local variables into the #ifdef region where
11164 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11165 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11167 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11168 (GC_STRING_CHARS): Remove; not used.
11169 (Fmemory_limit): Cast sbrk's returned value to char *.
11171 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11172 avoids undefined behavior in theory.
11174 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11176 Use functions, not macros, for up- and down-casing (Bug#8254).
11177 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11178 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11179 to use the following functions instead of these macros.
11180 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11181 EMACS_INT, since callers assume the returned value fits in int.
11182 (upcase1): Likewise, for UPCASE_TABLE.
11183 (uppercasep, lowercasep, upcase): New static inline functions.
11184 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11185 the race-condition problem in the old DOWNCASE.
11187 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11188 Rename locals to avoid shadowing.
11189 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11190 (regex_compile, re_search_2, re_match_2_internal):
11191 Remove unused local vars.
11192 (FREE_VAR): Rewrite so as not to use empty "else",
11193 which gcc can warn about.
11194 (regex_compile, re_match_2_internal): Mark locals as initialized.
11195 (RETALLOC_IF): Define only if needed.
11196 (WORDCHAR_P): Likewise. This one is never needed, but is used
11197 only in a comment talking about a compiler bug, so put inside
11198 the #if 0 of that comment.
11199 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11200 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11203 * search.c (boyer_moore): Rename locals to avoid shadowing.
11204 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11205 (PREV_CHAR_BOUNDARY): Likewise.
11207 * search.c (simple_search): Remove unused var.
11209 * dired.c (compile_pattern): Move decl from here ...
11210 * lisp.h: ... to here, so that it can be checked.
11211 (struct re_registers): New forward decl.
11213 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11215 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11217 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11218 Rename locals to avoid shadowing.
11219 (Fvertical_motion): Mark locals as initialized.
11221 * casefiddle.c (casify_object, casify_region): Now static.
11222 (casify_region): Mark local as initialized.
11224 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11226 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11227 New macros, so that the caller can use some names other than
11228 gcpro1, gcpro2, etc.
11229 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11231 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11232 argument, for consistency with GCPRO2_VAR, etc: it is now the
11233 prefix of the variable, not the variable itself. All uses
11235 * dired.c (directory_files_internal, file_name_completion):
11236 Rename locals to avoid shadowing.
11238 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11239 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11240 dired.c's scmp function, had undefined behavior.
11241 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11242 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11243 * buffer.h: ... to here, because these macros use current_buffer,
11244 and the new implementation with inline functions needs to have
11245 current_buffer in scope now, rather than later when the macros
11247 (downcase, upcase1): New static inline functions.
11248 (DOWNCASE, UPCASE1): Reimplement using these functions.
11249 This avoids undefined behavior in expressions like
11250 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11251 from race conditions in accessing the global variables
11252 case_temp1 and case_temp2.
11253 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11254 * lisp.h (case_temp1, case_temp2): Remove their decls.
11255 * character.h (ASCII_CHAR_P): Move from here ...
11256 * lisp.h: ... to here, so that the inline functions mentioned
11257 above can use them.
11259 * dired.c (directory_files_internal_unwind): Now static.
11261 * fileio.c (file_name_as_directory, directory_file_name):
11262 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11264 (file_name_as_directory): Use const pointers when appropriate.
11265 (Fexpand_file_name): Likewise. In particular, newdir might
11266 point at constant storage, so make it a const pointer.
11267 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11268 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11270 (Fset_file_times, Finsert_file_contents, auto_save_error):
11271 Rename locals to avoid shadowing.
11273 * minibuf.c (choose_minibuf_frame_1): Now static.
11274 (Ftry_completion, Fall_completions): Rename or remove locals
11275 to avoid shadowing.
11277 * marker.c (bytepos_to_charpos): Remove; unused.
11279 * lisp.h (verify_bytepos, count_markers): New decls,
11280 so that gcc does not warn that these functions aren't declared.
11282 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11283 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11284 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11285 (copy_text): Remove unused local var.
11287 * filelock.c (within_one_second): Now static.
11288 (lock_file_1): Rename local to avoid shadowing.
11290 * buffer.c (fix_overlays_before): Mark locals as initialized.
11291 (fix_start_end_in_overlays): Likewise. This function should be
11292 simplified by using pointers-to-pointers, but that's a different
11294 (switch_to_buffer_1): Now static.
11295 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11296 (report_overlay_modification): Rename locals to avoid shadowing.
11298 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11299 Fix pointer signedness issue.
11300 (sys_subshell): Mark local as volatile if checking for lint,
11301 to suppress a gcc -Wclobbered warning that does not seem to be right.
11302 (MAXPATHLEN): Define only if needed.
11304 * process.c (serial_open, serial_configure): Move decls from here ...
11305 * systty.h: ... to here, so that they can be checked.
11307 * fns.c (get_random, seed_random): Move extern decls from here ...
11308 * lisp.h: ... to here, so that they can be checked.
11310 * sysdep.c (reset_io): Now static.
11311 (wait_for_termination_signal): Remove; unused.
11313 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11314 (copy_keymap_item, append_key, push_text_char_description):
11316 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11317 (DENSE_TABLE_SIZE): Remove; unused.
11318 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11319 (describe_map_tree):
11320 Rename locals to avoid shadowing.
11322 * keyboard.c: Declare functions static if they are not used elsewhere.
11323 (echo_char, echo_dash, cmd_error, top_level_2):
11324 (poll_for_input, handle_async_input): Now static.
11325 (read_char, kbd_buffer_get_event, make_lispy_position):
11326 (make_lispy_event, make_lispy_movement, apply_modifiers):
11327 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11328 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11329 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11330 (read_key_sequence, read_char): Mark locals as initialized.
11331 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11333 * keyboard.h (make_ctrl_char): New decl.
11334 (mark_kboards): Move decl here ...
11335 * alloc.c (mark_kboards): ... from here.
11337 * lisp.h (force_auto_save_soon): New decl.
11339 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11340 (DEFINE_DUMMY_FUNCTION): New macro.
11341 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11343 (main): Add casts to avoid warnings
11344 if GCC considers string literals to be constants.
11346 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11348 * dbusbind.c: Pointer signedness fixes.
11349 (xd_signature, xd_append_arg, xd_initialize):
11350 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11351 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11352 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11353 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11355 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11356 if GCC considers string literals to be constants.
11357 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11359 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11361 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11362 (print_preprocess, print_object): New macro to fix last change.
11364 * print.c (print_preprocess): Don't forget font objects.
11366 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11368 * emacs.c (USAGE3): Doc fixes.
11370 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11372 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11375 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11377 * lisp.h (VWindow_system, Qfile_name_history):
11378 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11379 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11380 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11382 * w32select.c: Don't #include "keyboard.h".
11383 (run_protected): Add extern declaration for waiting_for_input.
11385 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11386 * w32console.c (detect_input_pending, read_input_pending)
11387 (encode_terminal_code):
11388 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11389 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11390 (w32_system_caret_y, Qfile_name_history):
11391 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11392 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11393 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11394 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11395 * w32proc.c (Qlocal, report_file_error):
11396 * w32term.c (Vwindow_system, updating_frame):
11397 * w32uniscribe.c (initialized, uniscribe_font_driver):
11398 Remove unneeded extern declarations.
11400 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11402 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11404 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11406 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11407 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11408 These macros can no longer be used for assignment.
11410 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11411 Assign struct members directly, instead of using BUF_BEGV etc.
11412 (record_buffer_markers, fetch_buffer_markers): New functions for
11413 recording and fetching special buffer markers.
11414 (set_buffer_internal_1, set_buffer_temp): Use them.
11416 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11418 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11420 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11421 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11423 * xdisp.c (hscroll_window_tree):
11424 (reconsider_clip_changes): Use PT instead of BUF_PT.
11426 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11428 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11429 $(EMACS_ROOT)/lib/intprops.h.
11431 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11433 Fix more problems found by GCC 4.5.2's static checks.
11435 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11436 to unsigned char * to avoid compiler diagnostic.
11437 (xg_free_frame_widgets): Make it clear that a local variable is
11438 needed only if USE_GTK_TOOLTIP.
11439 (gdk_window_get_screen): Make it clear that this macro is needed
11440 only if USE_GTK_TOOLTIP.
11441 (int_gtk_range_get_value): New function, which avoids a diagnostic
11442 from gcc -Wbad-function-cast.
11443 (xg_set_toolkit_scroll_bar_thumb): Use it.
11444 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11445 diagnostic from gcc -Wbad-function-cast.
11446 (get_utf8_string, xg_get_file_with_chooser):
11447 Rename locals to avoid shadowing.
11448 (create_dialog): Move locals to avoid shadowing.
11450 * xgselect.c (xg_select): Remove unused var.
11452 * image.c (four_corners_best): Mark locals as initialized.
11453 (gif_load): Initialize transparent_p to zero (Bug#8238).
11454 Mark another local as initialized.
11455 (my_png_error, my_error_exit): Mark with NO_RETURN.
11457 * image.c (clear_image_cache): Now static.
11458 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11459 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11460 (x_edge_detection): Remove unnecessary cast that
11461 gcc -Wbad-function-cast diagnoses.
11462 (gif_load): Fix pointer signedness.
11463 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11464 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11466 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11468 Improve quality of tests for time stamp overflow.
11469 For example, without this patch (encode-time 0 0 0 1 1
11470 1152921504606846976) returns the obviously-bogus value (-948597
11471 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11472 reports time overflow. See
11473 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11474 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11475 * editfns.c: Include limits.h and intprops.h.
11476 (TIME_T_MIN, TIME_T_MAX): New macros.
11477 (time_overflow): Move earlier, to before first use.
11478 (hi_time, lo_time): New functions, for an accurate test for
11479 out-of-range times.
11480 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11481 (Fget_internal_run_time): Don't assume time_t fits in int.
11482 (make_time): Use list2 instead of Fcons twice.
11483 (Fdecode_time): More accurate test for out-of-range times.
11484 (check_tm_member): New function.
11485 (Fencode_time): Use it, to test for out-of-range times.
11486 (lisp_time_argument): Don't rely on undefined left-shift and
11487 right-shift behavior when checking for time stamp overflow.
11489 * editfns.c (time_overflow): New function, refactoring common code.
11490 (Fformat_time_string, Fdecode_time, Fencode_time):
11491 (Fcurrent_time_string): Use it.
11493 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11494 * dired.c (make_time): Move to ...
11495 * editfns.c (make_time): ... here.
11496 * systime.h: Note the move.
11498 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11500 * fringe.c (update_window_fringes): Remove unused variables.
11502 * unexmacosx.c (copy_data_segment): Also copy __got section.
11505 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11507 * termcap.c [MSDOS]: Include "msdos.h".
11508 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11509 Constify `char *' arguments and their references according to
11510 prototypes in tparam.h.
11512 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11514 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11515 Adapt all references accordingly.
11517 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11519 2011-03-11 Tom Tromey <tromey@redhat.com>
11521 * buffer.c (syms_of_buffer): Remove obsolete comment.
11523 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11525 * termhooks.h (encode_terminal_code): Declare prototype.
11527 * msdos.c (encode_terminal_code): Don't declare prototype.
11529 * term.c (encode_terminal_code): Now external again, used by
11530 w32console.c and msdos.c.
11532 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11533 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11535 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11537 Fix some minor problems found by GCC 4.5.2's static checks.
11539 * fringe.c (update_window_fringes): Mark locals as initialized
11541 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11543 * alloc.c (mark_fringe_data): Move decl from here ...
11544 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11545 to check its interface.
11546 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11548 * fontset.c (free_realized_fontset): Now static.
11549 (Fset_fontset_font): Rename local to avoid shadowing.
11550 (fontset_font): Mark local as initialized.
11551 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11553 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11555 * xselect.c (x_disown_buffer_selections): Remove; not used.
11556 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11557 (x_own_selection, Fx_disown_selection_internal): Rename locals
11558 to avoid shadowing.
11559 (x_handle_dnd_message): Remove local to avoid shadowing.
11561 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11562 so that the caller can use some name other than gcpro1.
11563 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11564 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11565 (Fx_backspace_delete_keys_p):
11566 Use them to avoid shadowing, and rename vars to avoid shadowing.
11567 (x_decode_color, x_set_name, x_window): Now static.
11568 (Fx_create_frame): Add braces to silence GCC warning.
11569 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11570 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11571 Remove unused locals.
11572 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11573 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11574 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11577 * xterm.h (x_mouse_leave): New decl.
11579 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11580 Remove unused functions.
11581 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11582 (x_calc_absolute_position): Now static.
11583 (XTread_socket): Don't define label "out" unless it's used.
11584 Don't declare local "event" unless it's used.
11585 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11586 unless they are used.
11587 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11588 (x_fatal_error_signal): Remove; not used.
11589 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11590 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11591 (x_error_catcher, x_connection_closed, x_error_handler):
11592 (x_error_quitter, xembed_send_message, x_iconify_frame):
11593 (my_log_handler): Rename locals to avoid shadowing.
11594 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11595 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11597 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11598 Rename or move locals to avoid shadowing.
11599 (tty_defined_color, merge_face_heights): Now static.
11600 (free_realized_faces_for_fontset): Remove; not used.
11601 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11602 does not deduce is never used uninitialized.
11603 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11604 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11606 * terminal.c (store_terminal_param): Now static.
11608 * xmenu.c (menu_highlight_callback): Now static.
11609 (set_frame_menubar): Remove unused local.
11610 (xmenu_show): Rename parameter to avoid shadowing.
11611 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11612 since they might point to immutable storage.
11613 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11614 since it's unused otherwise.
11616 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11617 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11618 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11619 avoids a gcc -Wuninitialized diagnostic.
11620 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11621 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11622 does not deduce are never used uninitialized.
11624 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11626 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11627 * window.c (window_loop, size_window):
11628 (run_window_configuration_change_hook, enlarge_window): Likewise.
11630 * window.c (display_buffer): Now static.
11631 (size_window): Mark variables that gcc -Wuninitialized
11632 does not deduce are never used uninitialized.
11633 * window.h (check_all_windows): New decl, to forestall
11634 gcc -Wmissing-prototypes diagnostic.
11635 * dispextern.h (bidi_dump_cached_states): Likewise.
11637 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11639 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11640 Include <limits.h>.
11641 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11642 and to avoid gcc -Wuninitialized warning.
11643 (load_charset_map): Mark variables that gcc -Wuninitialized
11644 does not deduce are never used uninitialized.
11645 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11647 * coding.c (coding_set_source, coding_set_destination):
11648 Use "else { /* comment */ }" rather than "else /* comment */;"
11649 for clarity, and to avoid gcc -Wempty-body warning.
11650 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11651 a block, when the outer 'i' will do.
11652 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11653 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11654 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11655 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11656 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11657 Rename locals to avoid shadowing.
11658 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11659 * coding.c (emacs_mule_char, encode_invocation_designation):
11660 Now static, since they're not used elsewhere.
11661 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11662 (decode_coding_object, encode_coding_object, detect_coding_system):
11663 (decode_coding_emacs_mule): Mark variables that gcc
11664 -Wuninitialized does not deduce are never used uninitialized.
11665 (detect_coding_iso_2022): Initialize a local variable that might
11666 be used uninitialized. Leave a FIXME because it's not clear that
11667 this initialization is needed. (Bug#8211)
11668 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11669 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11670 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11671 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11672 Remove unused macros.
11674 * category.c (hash_get_category_set): Remove unused local var.
11675 (copy_category_table): Now static, since it's not used elsewhere.
11676 * character.c (string_count_byte8): Likewise.
11678 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11679 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11681 * chartab.c (copy_sub_char_table): Now static, since it's not used
11683 (sub_char_table_ref_and_range, char_table_ref_and_range):
11684 Rename locals to avoid shadowing.
11685 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11687 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11688 (BIDI_BOB): Remove unused macro.
11690 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11691 deduce are never used uninitialized.
11692 * term.c (encode_terminal_code): Likewise.
11694 * term.c (encode_terminal_code): Now static. Remove unused local.
11696 * tparam.h: New file.
11697 * term.c, tparam.h: Include it.
11698 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11699 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11700 Move these decls to tparam.h, and make them agree with what
11701 is actually in tparam.c. The previous trick of using incompatible
11702 decls in different modules does not conform to the C standard.
11703 All callers of tparam changed to use tparam's actual API.
11704 * tparam.c (tparam1, tparam, tgoto):
11705 Use const pointers where appropriate.
11707 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11708 * cm.h (struct cm): Likewise.
11709 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11710 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11711 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11712 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11713 (turn_on_face, init_tty): Likewise.
11714 * termchar.h (struct tty_display_info): Likewise.
11716 * term.c (term_mouse_position): Rename local to avoid shadowing.
11718 * alloc.c (mark_ttys): Move decl from here ...
11719 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11721 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11723 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11725 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11727 * search.c (compile_pattern_1): Remove argument regp, unused since
11728 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11729 (compile_pattern): Don't pass it.
11731 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11733 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11734 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11736 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11738 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11740 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11741 gdk_window_get_screen, gdk_window_get_geometry,
11742 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11743 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11744 (xg_get_pixbuf_from_pixmap): New function.
11745 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11746 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11747 Call xg_get_pixbuf_from_pixmap instead of
11748 gdk_pixbuf_get_from_drawable.
11749 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11750 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11751 (xg_check_special_colors): Use GtkStyleContext and its functions
11753 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11754 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11755 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11756 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11757 Call gtk_widget_get_preferred_size.
11758 (xg_frame_resized): gdk_window_get_geometry only takes 5
11760 (xg_win_to_widget, xg_event_is_for_menubar):
11761 Call gdk_x11_window_lookup_for_display.
11762 (xg_set_widget_bg): New function.
11763 (delete_cb): New function.
11764 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11765 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11766 (xg_set_background_color): Call xg_set_widget_bg.
11767 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11768 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11769 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11770 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11772 (update_frame_tool_bar): Call gtk_widget_hide.
11773 (xg_initialize): Use GDK_KEY_g.
11775 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11777 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11779 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11780 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11781 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11783 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11785 * w32xfns.c (select_palette): Check success of RealizePalette against
11786 GDI_ERROR, not zero.
11788 See ChangeLog.11 for earlier changes.
11790 ;; Local Variables:
11794 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11796 This file is part of GNU Emacs.
11798 GNU Emacs is free software: you can redistribute it and/or modify
11799 it under the terms of the GNU General Public License as published by
11800 the Free Software Foundation, either version 3 of the License, or
11801 (at your option) any later version.
11803 GNU Emacs is distributed in the hope that it will be useful,
11804 but WITHOUT ANY WARRANTY; without even the implied warranty of
11805 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11806 GNU General Public License for more details.
11808 You should have received a copy of the GNU General Public License
11809 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.