]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Some more window.h fixes missing in 2011-06-10T06:55:18Z!rudalics@gmx.at.
[gnu-emacs] / src / ChangeLog
1 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2
3 * window.h (resize_proportionally, orig_total_lines)
4 (orig_top_line): Remove from window structure.
5 (set_window_height, set_window_width, change_window_heights)
6 (Fdelete_window): Remove prototypes.
7 (resize_frame_windows): Remove duplicate declaration.
8
9 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10
11 * window.h (resize_frame_windows, resize_window_check)
12 (delete_deletable_window, resize_root_window)
13 (resize_frame_windows): Declare prototypes.
14
15 * window.c (resize_window_apply): Make definition be "static" to
16 match the prototype.
17
18 2011-06-10 Martin Rudalics <rudalics@gmx.at>
19
20 * window.c: Remove declarations of Qwindow_size_fixed,
21 window_min_size_1, window_min_size_2, window_min_size,
22 size_window, window_fixed_size_p, enlarge_window, delete_window.
23 Remove static from declaration of Qdelete_window, it's
24 temporarily needed by Fbury_buffer.
25 (replace_window): Don't assign orig_top_line and
26 orig_total_lines.
27 (Fdelete_window, delete_window): Remove. Window deletion is
28 handled by window.el.
29 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
30 Fdelete_window calls with calls to Qdelete_window.
31 (Fdelete_other_windows): Remove. Deleting other windows is
32 handled by window.el.
33 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
34 handled in window.el.
35 (window_min_size_2, window_min_size_1, window_min_size): Remove.
36 Window minimum sizes are handled in window.el.
37 (shrink_windows, size_window, set_window_height)
38 (set_window_width, change_window_heights, window_height)
39 (window_width, CURBEG, CURSIZE, enlarge_window)
40 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
41 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
42 handled in window.el.
43 (make_dummy_parent): Rename to make_parent_window and give it a
44 second argument horflag.
45 (make_window): Don't set resize_proportionally any more.
46 (Fsplit_window): Remove. Windows are split in window.el.
47 (save_restore_action, save_restore_orig_size)
48 (shrink_window_lowest_first, save_restore_orig_size): Remove.
49 Resize mini windows in window.el.
50 (grow_mini_window, shrink_mini_window): Implement by calling
51 Qresize_root_window_vertically, resize_window_check and
52 resize_window_apply.
53 (saved_window, Fset_window_configuration, save_window_save): Do
54 not handle orig_top_line, orig_total_lines, and
55 resize_proportionally.
56 (window_min_height, window_min_width): Move to window.el.
57 (keys_of_window): Move bindings for delete-other-windows,
58 split-window, delete-window and enlarge-window to window.el.
59
60 * buffer.c: Temporarily extern Qdelete_window.
61 (Fbury_buffer): Temporarily call Qdelete_window instead of
62 Fdelete_window (Fbury_buffer will move to window.el soon).
63
64 * frame.c (set_menu_bar_lines_1): Remove code handling
65 orig_top_line and orig_total_lines.
66
67 * dispnew.c (adjust_frame_glyphs_initially): Don't use
68 set_window_height but set heights directly.
69 (change_frame_size_1): Use resize_frame_windows.
70
71 * xdisp.c (init_xdisp): Don't use set_window_height but set
72 heights directly.
73
74 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
75 resize_frame_windows instead of change_window_heights and run
76 run_window_configuration_change_hook.
77
78 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
79 instead of change_window_heights and run
80 run_window_configuration_change_hook.
81
82 2011-06-09 Martin Rudalics <rudalics@gmx.at>
83
84 * window.c (replace_window): Rename second argument REPLACEMENT to
85 NEW. New third argument SETFLAG. Rewrite.
86 (delete_window, make_dummy_parent): Call replace_window with
87 third argument 1.
88 (window_list_1): Move down in code.
89 (run_window_configuration_change_hook): Move set_buffer part
90 before select_frame_norecord part in order to unwind correctly.
91 Rename count1 to count.
92 (recombine_windows, delete_deletable_window, resize_root_window)
93 (Fdelete_other_windows_internal)
94 (Frun_window_configuration_change_hook, make_parent_window)
95 (resize_window_check, resize_window_apply, Fresize_window_apply)
96 (resize_frame_windows, Fsplit_window_internal)
97 (Fdelete_window_internal, Fresize_mini_window_internal): New
98 functions.
99 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
100
101 2011-06-08 Martin Rudalics <rudalics@gmx.at>
102
103 * window.h (window): Add some new members to window structure -
104 normal_lines, normal_cols, new_total, new_normal, clone_number,
105 splits, nest, prev_buffers, next_buffers.
106 (WINDOW_TOTAL_SIZE): Move here from window.c.
107 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
108
109 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
110 Remove.
111 (make_dummy_parent): Set new members of windows structure.
112 (make_window): Move down in code. Handle new members of window
113 structure.
114 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
115 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
116 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
117 (Fset_window_prev_buffers, Fwindow_next_buffers)
118 (Fset_window_next_buffers, Fset_window_clone_number): New
119 functions.
120 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
121 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
122 Doc-string fixes.
123 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
124 Argument WINDOW can be now internal window too.
125 (Fwindow_use_time): Move up in code.
126 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
127 Rewrite doc-string.
128 (Fset_window_configuration, saved_window)
129 (Fcurrent_window_configuration, save_window_save): Handle new
130 members of window structure.
131 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
132 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
133 (syms_of_window): New Lisp objects Qrecord_window_buffer,
134 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
135 Qget_mru_window, Qresize_root_window,
136 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
137 Qauto_buffer_name; staticpro them.
138
139 2011-06-07 Martin Rudalics <rudalics@gmx.at>
140
141 * window.c (Fwindow_total_size, Fwindow_left_column)
142 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
143 (Fwindow_list_1): New functions.
144 (window_box_text_cols): Replace with window_body_cols.
145 (Fwindow_width, Fscroll_left, Fscroll_right): Use
146 window_body_cols instead of window_box_text_cols.
147 (delete_window, Fset_window_configuration): Call
148 delete_all_subwindows with window as argument.
149 (delete_all_subwindows): Take a window as argument and not a
150 structure. Rewrite.
151 (window_loop): Remove handling of GET_LRU_WINDOW and
152 GET_LARGEST_WINDOW.
153 (Fget_lru_window, Fget_largest_window): Move to window.el.
154
155 * window.h: Extern window_body_cols instead of
156 window_box_text_cols. delete_all_subwindows now takes a
157 Lisp_Object as argument.
158
159 * indent.c (compute_motion, Fcompute_motion): Use
160 window_body_cols instead of window_box_text_cols.
161
162 * frame.c (delete_frame): Call delete_all_subwindows with root
163 window as argument.
164
165 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
166
167 * fns.c (Fputhash): Document return value.
168
169 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
170
171 * image.c (gif_load): Implement gif89a spec "no disposal" method.
172
173 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
174
175 Cons<->int and similar integer overflow fixes (Bug#8794).
176
177 Check for overflow when converting integer to cons and back.
178 * charset.c (Fdefine_charset_internal, Fdecode_char):
179 Use cons_to_unsigned to catch overflow.
180 (Fencode_char): Use INTEGER_TO_CONS.
181 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
182 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
183 * data.c (long_to_cons, cons_to_long): Remove.
184 (cons_to_unsigned, cons_to_signed): New functions.
185 These signal an error for invalid or out-of-range values.
186 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
187 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
188 * font.c (Ffont_variation_glyphs):
189 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
190 * lisp.h: Include <intprops.h>.
191 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
192 (cons_to_signed, cons_to_unsigned): New decls.
193 (long_to_cons, cons_to_long): Remove decls.
194 * undo.c (record_first_change): Use INTEGER_TO_CONS.
195 (Fprimitive_undo): Use CONS_TO_INTEGER.
196 * xfns.c (Fx_window_property): Likewise.
197 * xselect.c: Include <limits.h>.
198 (x_own_selection, selection_data_to_lisp_data):
199 Use INTEGER_TO_CONS.
200 (x_handle_selection_request, x_handle_selection_clear)
201 (x_get_foreign_selection, Fx_disown_selection_internal)
202 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
203 (lisp_data_to_selection_data): Use cons_to_unsigned.
204 (x_fill_property_data): Use cons_to_signed.
205 Report values out of range.
206
207 Check for buffer and string overflow more precisely.
208 * buffer.h (BUF_BYTES_MAX): New macro.
209 * lisp.h (STRING_BYTES_MAX): New macro.
210 * alloc.c (Fmake_string):
211 * character.c (string_escape_byte8):
212 * coding.c (coding_alloc_by_realloc):
213 * doprnt.c (doprnt):
214 * editfns.c (Fformat):
215 * eval.c (verror):
216 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
217 since they may not be the same number.
218 * editfns.c (Finsert_char):
219 * fileio.c (Finsert_file_contents):
220 Likewise for BUF_BYTES_MAX.
221
222 * image.c: Use ptrdiff_t, not int, for sizes.
223 (slurp_file): Switch from int to ptrdiff_t.
224 All uses changed.
225 (slurp_file): Check that file size fits in both size_t (for
226 malloc) and ptrdiff_t (for sanity and safety).
227
228 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
229 if b->modtime has its maximal value.
230
231 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
232
233 Don't assume time_t can fit into int.
234 * buffer.h (struct buffer.modtime): Now time_t, not int.
235 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
236 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
237
238 Minor fixes for signed vs unsigned integers.
239 * character.h (MAYBE_UNIFY_CHAR):
240 * charset.c (maybe_unify_char):
241 * keyboard.c (read_char, reorder_modifiers):
242 XINT -> XFASTINT, since the integer must be nonnegative.
243 * ftfont.c (ftfont_spec_pattern):
244 * keymap.c (access_keymap, silly_event_symbol_error):
245 XUINT -> XFASTINT, since the integer must be nonnegative.
246 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
247 since it makes no difference and we prefer signed.
248 * keyboard.c (record_char): Use XUINT when all the neighbors do.
249 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
250 nonnegative.
251
252 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
253
254 * window.h (Fwindow_frame): Declare.
255
256 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
257
258 * alloc.c: Simplify handling of large-request failures (Bug#8800).
259 (SPARE_MEMORY): Always define.
260 (LARGE_REQUEST): Remove.
261 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
262
263 2011-06-06 Martin Rudalics <rudalics@gmx.at>
264
265 * lisp.h: Move EXFUNS for Fframe_root_window,
266 Fframe_first_window and Fset_frame_selected_window to window.h.
267
268 * window.h: Move EXFUNS for Fframe_root_window,
269 Fframe_first_window and Fset_frame_selected_window here from
270 lisp.h.
271
272 * frame.c (Fwindow_frame, Fframe_first_window)
273 (Fframe_root_window, Fframe_selected_window)
274 (Fset_frame_selected_window): Move to window.c.
275 (Factive_minibuffer_window): Move to minibuf.c.
276 (Fother_visible_frames_p): New function.
277
278 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
279
280 * window.c (decode_window, decode_any_window): Move up in code.
281 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
282 (inhibit_frame_unsplittable): Remove unused variable.
283 (Fwindow_buffer): Move up and rewrite doc-string.
284 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
285 (Fwindow_prev): New functions.
286 (Fwindow_frame): Move here from frame.c. Accept any window as
287 argument.
288 (Fframe_root_window, Fframe_first_window)
289 (Fframe_selected_window): Move here from frame.c. Accept frame
290 or arbitrary window as argument. Update doc-strings.
291 (Fminibuffer_window): Move up in code.
292 (Fwindow_minibuffer_p): Move up in code and simplify.
293 (Fset_frame_selected_window): Move here from frame.c.
294 Marginal rewrite.
295 (Fselected_window, select_window, Fselect_window): Move up in
296 code. Minor doc-string fixes.
297
298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
299
300 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
301 Do not assume that spare memory exists; that assumption is valid
302 only if SYSTEM_MALLOC.
303 (LARGE_REQUEST): New macro, so that the issue of large requests
304 is separated from the issue of spare memory.
305
306 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
307
308 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
309 format. (Bug#8806)
310
311 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
312
313 * xfns.c (x_set_scroll_bar_default_width): Move declarations
314 before statements.
315
316 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
317
318 * gtkutil.c (xg_get_default_scrollbar_width): New function.
319
320 * gtkutil.h: Declare xg_get_default_scrollbar_width.
321
322 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
323 min width by calling x_set_scroll_bar_default_width (Bug#8505).
324
325 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
326
327 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
328
329 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
330
331 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
332 (x_clipboard_manager_save): Add return value.
333 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
334 New error handlers.
335 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
336 Obey Vx_select_enable_clipboard_manager. Catch errors in
337 x_clipboard_manager_save (Bug#8779).
338 (Vx_select_enable_clipboard_manager): New variable.
339 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
340
341 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
342
343 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
344
345 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
346
347 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
348 in the current matrix if keep_current_p is non-zero.
349
350 2011-06-04 Eli Zaretskii <eliz@gnu.org>
351
352 * bidi.c (bidi_level_of_next_char): Fix last change.
353
354 2011-06-03 Eli Zaretskii <eliz@gnu.org>
355
356 Support bidi reordering of text covered by display properties.
357
358 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
359 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
360 (bidi_cache_search, bidi_cache_iterator_state)
361 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
362 (bidi_level_of_next_char, bidi_move_to_visually_next):
363 Support character positions inside a run of characters covered by a
364 display string.
365 (bidi_paragraph_init, bidi_resolve_explicit_1)
366 (bidi_level_of_next_char): Call bidi_fetch_char and
367 bidi_fetch_char_advance instead of FETCH_CHAR and
368 FETCH_CHAR_ADVANCE.
369 (bidi_init_it): Initialize new members.
370 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
371 definitions.
372 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
373 instead of using explicit *_CHAR codes.
374 (bidi_resolve_explicit, bidi_resolve_weak):
375 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
376 bidirectional text is supported only in multibyte buffers.
377 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
378 it to initialize the frame_window_p member of struct bidi_it.
379 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
380 (bidi_resolve_explicit, bidi_resolve_weak)
381 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
382 bidi_it->nchars is non-positive.
383 (bidi_level_of_next_char): Don't try to lookup the cache for the
384 next/previous character if nothing is cached there yet, or if we
385 were just reseat()'ed to a new position.
386
387 * xdisp.c (set_cursor_from_row): Set start and stop points
388 according to the row's direction when priming the loop that looks
389 for the glyph on which to display cursor.
390 (single_display_spec_intangible_p): Function deleted.
391 (display_prop_intangible_p): Reimplement to call
392 handle_display_spec instead of single_display_spec_intangible_p.
393 Accept 3 additional arguments needed by handle_display_spec.
394 This fixes incorrect cursor motion across display property with complex
395 values: lists, `(when COND...)' forms, etc.
396 (single_display_spec_string_p): Support property values that are
397 lists with the argument STRING its top-level element.
398 (display_prop_string_p): Fix the condition for processing a
399 property that is a list to be consistent with handle_display_spec.
400 (handle_display_spec): New function, refactored from the
401 last portion of handle_display_prop.
402 (compute_display_string_pos): Accept additional argument
403 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
404 value of a `display' property is a "replacing spec".
405 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
406 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
407 the display property, but just return a value indicating whether
408 the display property will replace the characters it covers.
409 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
410 frame_window_p members of struct bidi_it.
411 (compute_display_string_pos, compute_display_string_end):
412 New functions.
413 (push_it): Accept second argument POSITION, where pop_it should
414 jump to continue iteration.
415 (reseat_1): Initialize bidi_it.disp_pos.
416
417 * keyboard.c (adjust_point_for_property): Adjust the call to
418 display_prop_intangible_p to its new signature.
419
420 * dispextern.h (struct bidi_it): New member frame_window_p.
421 (bidi_init_it): Update prototypes.
422 (display_prop_intangible_p): Update prototype.
423 (compute_display_string_pos, compute_display_string_end):
424 Declare prototypes.
425 (struct bidi_it): New members nchars and disp_pos. ch_len is now
426 EMACS_INT.
427
428 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
429
430 Malloc failure behavior now depends on size of allocation.
431 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
432 * lisp.h: Change signatures accordingly.
433 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
434 All callers changed. (Bug#8762)
435
436 * gnutls.c: Use Emacs's memory allocators.
437 Without this change, the gnutls library would invoke malloc etc.
438 directly, which causes problems on non-SYNC_INPUT hosts, and which
439 runs afoul of improving memory_full behavior. (Bug#8761)
440 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
441 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
442 xfree instead of the default malloc, realloc, free.
443 (Fgnutls_boot): No need to check for memory allocation failure,
444 since xmalloc does that for us.
445
446 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
447 * category.c (hash_get_category_set):
448 * ccl.c (ccl_driver):
449 * charset.c (Fdefine_charset_internal):
450 * charset.h (struct charset.hash_index):
451 * composite.c (get_composition_id, gstring_lookup_cache)
452 (composition_gstring_put_cache):
453 * composite.h (struct composition.hash_index):
454 * dispextern.h (struct image.hash):
455 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
456 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
457 (hashfn_equal, hashfn_user_defined, make_hash_table)
458 (maybe_resize_hash_table, hash_lookup, hash_put)
459 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
460 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
461 (Fsxhash, Fgethash, Fputhash, Fmaphash):
462 * image.c (make_image, search_image_cache, lookup_image)
463 (xpm_put_color_table_h):
464 * lisp.h (struct Lisp_Hash_Table):
465 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
466 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
467 for hashes and hash indexes, instead of 'unsigned' and 'int'.
468 * alloc.c (allocate_vectorlike):
469 Check for overflow in vector size calculations.
470 * ccl.c (ccl_driver):
471 Check for overflow when converting EMACS_INT to int.
472 * fns.c, image.c: Remove unnecessary static decls that would otherwise
473 need to be updated by these changes.
474 * fns.c (make_hash_table, maybe_resize_hash_table):
475 Check for integer overflow with large hash tables.
476 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
477 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
478 (SXHASH_REDUCE): New macro.
479 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
480 Use it instead of discarding useful hash info with large hash values.
481 (sxhash_float): New function.
482 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
483 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
484 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
485 Rewrite to use FIXNUM_BITS, as this simplifies things.
486 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
487 Adjust signatures to match updated version of code.
488 (consing_since_gc): Now EMACS_INT, since a single hash table can
489 use more than INT_MAX bytes.
490
491 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
492
493 Make it possible to build with GCC-4.6+ -O2 -flto.
494
495 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
496
497 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 * minibuf.c (get_minibuffer, read_minibuf_unwind):
500 Call minibuffer-inactive-mode.
501
502 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
503
504 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
505 Update dependencies.
506
507 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
508
509 * data.c (init_data): Remove code for UTS, this system is not
510 supported anymore.
511
512 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
513
514 Don't force ./temacs to start in terminal mode.
515
516 * frame.c (make_initial_frame): Initialize faces in all cases, not
517 only when CANNOT_DUMP is defined.
518 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
519
520 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
521
522 * dispnew.c (add_window_display_history): Use const for the string
523 pointer. Remove declaration, not needed.
524
525 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
526
527 Use 'inline', not 'INLINE'.
528 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
529 * alloc.c, fontset.c (INLINE): Remove.
530 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
531 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
532 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
533 * gmalloc.c (register_heapinfo): Use inline unconditionally.
534 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
535
536 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
537
538 Make it possible to run ./temacs.
539
540 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
541 syms_of_callproc does the same thing. Remove test for
542 "initialized", do it in the caller.
543 * emacs.c (main): Avoid calling set_initial_environment when dumping.
544
545 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
548 (read_minibuf): Use get_minibuffer.
549 (syms_of_minibuf): Use DEFSYM.
550 (Qmetadata): New var.
551 * data.c (Qbuffer): Don't make it static.
552 (syms_of_data): Use DEFSYM.
553
554 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
555
556 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
557 (CCL_CODE_MIN): New macro.
558
559 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
560
561 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
562
563 * eval.c (Qdebug): Now static.
564 * lisp.h (Qdebug): Remove decl. This reverts a part of the
565 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
566 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
567
568 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
569
570 * image.c: Various fixes to ImageMagick code comments.
571 (Fimagemagick_types): Doc fix.
572
573 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
574
575 Minor fixes prompted by GCC 4.6.0 warnings.
576
577 * xselect.c (converted_selections, conversion_fail_tag): Now static.
578
579 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
580 (x_clipboard_manager_save_all): Move extern decl to ...
581 * xterm.h: ... here, so that it can be checked for consistency.
582
583 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
584
585 * xselect.c (x_clipboard_manager_save_frame)
586 (x_clipboard_manager_save_all): New functions.
587 (Fx_clipboard_manager_save): Lisp function deleted.
588
589 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
590 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
591
592 * xterm.h: Update prototype.
593
594 2011-05-28 William Xu <william.xwl@gmail.com>
595
596 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
597 exiting (Bug#8239).
598
599 2011-05-28 Jim Meyering <meyering@redhat.com>
600
601 Avoid a sign-extension bug in crypto_hash_function.
602 * fns.c (to_uchar): Define.
603 (crypto_hash_function): Use it to convert some newly-signed
604 variables to unsigned, to avoid sign-extension bugs. For example,
605 without this change, (md5 "truc") would evaluate to
606 45723a2aff78ff4fff7fff1114760e62 rather than the expected
607 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
608 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
609
610 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
611
612 Integer overflow fixes.
613
614 * dbusbind.c: Serial number integer overflow fixes.
615 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
616 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
617 to hold a serial number that is too large for a fixnum.
618 (Fdbus_method_return_internal, Fdbus_method_error_internal):
619 Check for serial numbers out of range. Decode any serial number
620 that was so large that it became a float. (Bug#8722)
621
622 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
623 (Fdbus_call_method, Fdbus_call_method_asynchronously):
624 Use XFASTINT rather than XUINT when numbers are nonnegative.
625 (xd_append_arg, Fdbus_method_return_internal):
626 (Fdbus_method_error_internal): Likewise. Also, for unsigned
627 arguments, check that Lisp number is nonnegative, rather than
628 silently wrapping negative numbers around. (Bug#8722)
629 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
630 (Bug#8722)
631
632 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
633
634 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
635
636 ccl: add integer overflow checks
637 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
638 (IN_INT_RANGE): New macros.
639 (ccl_driver): Use them to check for integer overflow when
640 decoding a CCL program. Many of the new checks are whether XINT (x)
641 fits in int; it doesn't always, on 64-bit hosts. The new version
642 doesn't catch all possible integer overflows, but it's an
643 improvement. (Bug#8719)
644
645 * alloc.c (make_event_array): Use XINT, not XUINT.
646 There's no need for unsigned here.
647
648 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
649 This follows up to the 2011-05-06 change that substituted uintptr_t
650 for EMACS_INT. This case wasn't caught back then.
651
652 Rework Fformat to avoid integer overflow issues.
653 * editfns.c: Include <float.h> unconditionally, as it's everywhere
654 now (part of C89). Include <verify.h>.
655 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
656 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
657 (Fformat): Avoid the prepass trying to compute sizes; it was only
658 approximate and thus did not catch overflow reliably. Instead, walk
659 through the format just once, formatting and computing sizes as we go,
660 checking for integer overflow at every step, and allocating a larger
661 buffer as needed. Keep track separately whether the format is
662 multibyte. Keep only the most-recently calculated precision, rather
663 than them all. Record whether each argument has been converted to
664 string. Use EMACS_INT, not int, for byte and char and arg counts.
665 Support field widths and precisions larger than INT_MAX. Avoid
666 sprintf's undefined behavior with conversion specifications such as %#d
667 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
668 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
669 formatting out-of-range floating point numbers with int
670 formats. (Bug#8668)
671
672 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
673
674 * data.c: Avoid integer truncation in expressions involving floats.
675 * data.c: Include <intprops.h>.
676 (arith_driver): When there's an integer overflow in an expression
677 involving floating point, convert the integers to floating point
678 so that the resulting value does not suffer from catastrophic
679 integer truncation. For example, on a 64-bit host (* 4
680 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
681 Do not rely on undefined behavior after integer overflow.
682
683 merge count_size_as_multibyte, parse_str_to_multibyte
684 * character.c, character.h (count_size_as_multibyte):
685 Rename from parse_str_to_multibyte; all uses changed.
686 Check for integer overflow.
687 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
688 since it's now a duplicate of the other. This is more of
689 a character than a buffer op, so better that it's in character.c.
690 * fns.c, print.c: Adjust to above changes.
691
692 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
695
696 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
697
698 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
699 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
700 (x_clipboard_manager_save): Now static.
701 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
702
703 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
704 (crypto_hash_function): Now static.
705 Fix pointer signedness problems. Avoid unnecessary initializations.
706
707 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
708
709 * termhooks.h (Vselection_alist): Make it terminal-local.
710
711 * terminal.c (create_terminal): Initialize it.
712
713 * xselect.c: Support for clipboard managers.
714 (Vselection_alist): Move to termhooks.h as terminal-local var.
715 (LOCAL_SELECTION): New macro.
716 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
717 (symbol_to_x_atom): Remove gratuitous arg.
718 (x_handle_selection_request, lisp_data_to_selection_data)
719 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
720 (x_own_selection, x_get_local_selection, x_convert_selection):
721 New arg, specifying work frame. Use terminal-local Vselection_alist.
722 (some_frame_on_display): Delete unused function.
723 (Fx_own_selection_internal, Fx_get_selection_internal)
724 (Fx_disown_selection_internal, Fx_selection_owner_p)
725 (Fx_selection_exists_p): New optional frame arg.
726 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
727 (x_handle_selection_clear): Don't treat other terminals with the
728 same keyboard specially. Use the terminal-local Vselection_alist.
729 (x_clear_frame_selections): Use Frun_hook_with_args.
730
731 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
732
733 * xterm.h: Add support for those atoms.
734
735 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
736
737 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
738 (converted_selections, conversion_fail_tag): New global variables.
739 (x_selection_request_lisp_error): Free the above.
740 (x_get_local_selection): Remove unnecessary code.
741 (x_reply_selection_request): Args changed; handle arbitrary array
742 of converted selections stored in converted_selections.
743 Separate the XChangeProperty and SelectionNotify steps.
744 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
745 (x_convert_selection): New function.
746 (x_handle_selection_event): Simplify.
747 (x_get_foreign_selection): Don't ignore incoming requests while
748 waiting for an answer; this will fail when we implement
749 SAVE_TARGETS, and seems unnecessary anyway.
750 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
751 (Vx_sent_selection_functions): Doc fix.
752
753 2011-05-26 Leo Liu <sdl.web@gmail.com>
754
755 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
756
757 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
758
759 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
760
761 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
762 for fringe update if it has periodic bitmap.
763 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
764 and fringe_bitmap_periodic_p.
765
766 * fringe.c (get_fringe_bitmap_data): New function.
767 (draw_fringe_bitmap_1, update_window_fringes): Use it.
768 (update_window_fringes): Record periodicity of fringe bitmap in glyph
769 row. Mark glyph row for fringe update if periodicity changed.
770
771 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
772 for fringe update unless it has periodic bitmap.
773
774 2011-05-25 Kenichi Handa <handa@m17n.org>
775
776 * xdisp.c (get_next_display_element): Set correct it->face_id for
777 a static composition.
778
779 2011-05-24 Leo Liu <sdl.web@gmail.com>
780
781 * deps.mk (fns.o):
782 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
783
784 * fns.c (crypto_hash_function, Fsha1): New function.
785 (Fmd5): Use crypto_hash_function.
786 (syms_of_fns): Add Ssha1.
787
788 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
789
790 * gnutls.c: Remove unused macros.
791 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
792 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
793 Remove macros that are defined and never used.
794 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
795
796 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
797
798 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
799 (Fx_get_selection_internal): Minor cleanup.
800 (Fx_own_selection_internal): Rename arguments for consistency with
801 select.el.
802
803 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
804
805 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
806
807 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
808
809 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
810
811 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
812
813 * dispnew.c (scrolling_window): Don't exclude the case that the
814 last enabled row in the desired matrix touches the bottom boundary.
815
816 2011-05-21 Glenn Morris <rgm@gnu.org>
817
818 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
819 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
820 and add some more files.
821
822 2011-05-20 Eli Zaretskii <eliz@gnu.org>
823
824 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
825 report_file_error introduced by the change from 2011-05-07.
826
827 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
828
829 * systime.h (Time): Define only if emacs is defined.
830 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
831 where the include path doesn't have X11/X.h by default. See
832 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
833
834 2011-05-20 Kenichi Handa <handa@m17n.org>
835
836 * composite.c (find_automatic_composition): Fix previous change.
837
838 2011-05-20 Glenn Morris <rgm@gnu.org>
839
840 * lisp.mk: New file, split from Makefile.in.
841 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
842 (shortlisp): Remove.
843 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
844
845 2011-05-19 Glenn Morris <rgm@gnu.org>
846
847 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
848 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
849 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
850 (lisp): Set the order to that of loadup.el.
851 (shortlisp): Make it a copy of $lisp.
852 (SOME_MACHINE_LISP): Remove.
853 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
854 Use just $shortlisp, not $SOME_MACHINE_LISP too.
855
856 2011-05-18 Kenichi Handa <handa@m17n.org>
857
858 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
859 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
860 (find_automatic_composition): Mostly rewrite for efficiency.
861
862 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
863
864 * makefile.w32-in: Update dependencies.
865
866 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
867
868 * menu.c: Include limits.h (fixes the MS-Windows build broken by
869 revision 104625).
870
871 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
872
873 Fix some integer overflow issues, such as string length overflow.
874
875 * insdel.c (count_size_as_multibyte): Check for string overflow.
876
877 * character.c (lisp_string_width): Check for string overflow.
878 Use EMACS_INT, not int, for string indexes and lengths; in
879 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
880 the resulting string length overflows an EMACS_INT; instead,
881 report a string overflow if no precision given. When checking for
882 precision exhaustion, use a check that cannot possibly have
883 integer overflow. (Bug#8675)
884 * character.h (lisp_string_width): Adjust to new signature.
885
886 * alloc.c (string_overflow): New function.
887 (Fmake_string): Use it. This doesn't change behavior, but saves
888 a few bytes and will simplify future changes.
889 * character.c (string_escape_byte8): Likewise.
890 * lisp.h (string_overflow): New decl.
891
892 Fixups, following up to the user-interface timestamp change.
893 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
894 for UI timestamps, instead of unsigned long.
895 * msdos.c (mouse_get_pos): Likewise.
896 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
897 * w32gui.h (Time): Define by including "systime.h" rather than by
898 declaring it ourselves. (Bug#8664)
899
900 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
901 * image.c (clear_image_cache): Likewise.
902
903 * term.c (term_mouse_position): Don't assume time_t wraparound.
904
905 Be more systematic about user-interface timestamps.
906 Before, the code sometimes used 'Time', sometimes 'unsigned long',
907 and sometimes 'EMACS_UINT', to represent these timestamps.
908 This change causes it to use 'Time' uniformly, as that's what X uses.
909 This makes the code easier to follow, and makes it easier to catch
910 integer overflow bugs such as Bug#8664.
911 * frame.c (Fmouse_position, Fmouse_pixel_position):
912 Use Time, not unsigned long, for user-interface timestamps.
913 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
914 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
915 * keyboard.h (last_event_timestamp): Likewise.
916 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
917 * menu.h (xmenu_show): Likewise.
918 * term.c (term_mouse_position): Likewise.
919 * termhooks.h (struct input_event.timestamp): Likewise.
920 (struct terminal.mouse_position_hook): Likewise.
921 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
922 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
923 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
924 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
925 what it was before.
926 * menu.h, termhooks.h: Include "systime.h", for Time.
927
928 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
929 Don't assume that the difference between two unsigned long values
930 can fit into an integer. At this point, we know button_down_time
931 <= event->timestamp, so the difference must be nonnegative, so
932 there's no need to cast the result if double-click-time is
933 nonnegative, as it should be; check that it's nonnegative, just in
934 case. This bug is triggered when events are more than 2**31 ms
935 apart (about 25 days). (Bug#8664)
936
937 * xselect.c (last_event_timestamp): Remove duplicate decl.
938 (x_own_selection): Remove needless cast to unsigned long.
939
940 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
941 that always fit in int. Use a sentinel instead of a counter, to
942 avoid a temp and to allay GCC's concerns about possible int overflow.
943 * frame.h (struct frame): Use int for menu_bar_items_used
944 instead of EMACS_INT, since it always fits in int.
945
946 * menu.c (grow_menu_items): Check for int overflow.
947
948 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
949
950 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
951 Before, the code was not consistent. These values cannot exceed
952 2**31 - 1 so there's no need to make them unsigned.
953 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
954 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
955 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
956 as modifiers.
957 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
958
959 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
960 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
961 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
962 presumably because the widths might not match.
963
964 * window.c (size_window): Avoid needless test at loop start.
965
966 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
967
968 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
969
970 2011-05-12 Drew Adams <drew.adams@oracle.com>
971
972 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
973
974 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
975
976 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
977 `width' to `bar_area_x' and `bar_area_width', respectively.
978 (x_scroll_run): Take account of fringe background extension.
979
980 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
981 Rename local vars `left' and `width' to `bar_area_x' and
982 `bar_area_width', respectively.
983 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
984 background extension.
985
986 2011-05-10 Jim Meyering <meyering@redhat.com>
987
988 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
989
990 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
991
992 * image.c (Finit_image_library): Return t for built-in image types,
993 like pbm and xbm. (Bug#8640)
994
995 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
996
997 * w32menu.c (set_frame_menubar): Fix submenu allocation.
998
999 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1000
1001 * w32console.c (Fset_screen_color): Doc fix.
1002 (Fget_screen_color): New function.
1003 (syms_of_ntterm): Defsubr it.
1004
1005 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1006 unlink the temporary file if Fcall_process didn't create it in the
1007 first place.
1008 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1009 child process will be redirected to a file specified with `:file'.
1010 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1011 cue to call_process_cleanup not to close that handle.
1012
1013 2011-05-07 Ben Key <bkey76@gmail.com>
1014
1015 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1016 one of two shell specific rules, either bootstrap-temacs-CMD or
1017 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1018 to the previous implementation of the bootstrap-temacs rule.
1019 The bootstrap-temacs-CMD rule is similar to the previous
1020 implementation of the bootstrap-temacs rule except that it
1021 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1022 variable.
1023
1024 These changes, along with some changes to nt/configure.bat,
1025 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1026 earlier fix to add support for --cflags and --ldflags options
1027 that include quotes so that it works whether make uses cmd or
1028 sh as the shell.
1029
1030 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1031
1032 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1033 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1034 is a constant.
1035 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1036 a string. Handle both cases.
1037 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1038 (Fdbus_register_method): Use Qinvalid_function.
1039
1040 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1041
1042 * makefile.w32-in: Update dependencies.
1043 (LISP_H): Add inttypes.h and stdin.h.
1044 (PROCESS_H): Add unistd.h.
1045
1046 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1047
1048 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1049 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1050
1051 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1054
1055 * term.c (vfatal): Remove stray call to va_end.
1056 It's not needed and the C Standard doesn't allow it here anyway.
1057
1058 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1059 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1060
1061 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1062 bytes.
1063
1064 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1065
1066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1067
1068 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1069
1070 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1071
1072 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1073
1074 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1075 * charset.c (Fdefine_charset_internal): Don't initialize
1076 charset.code_space[15]. The value was garbage, on hosts with
1077 32-bit int (Bug#8600).
1078
1079 * lread.c (read_integer): Be more consistent with string-to-number.
1080 Use string_to_number to do the actual conversion; this avoids
1081 rounding errors and fixes some other screwups. Without this fix,
1082 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1083 (digit_to_number): Move earlier, for benefit of read_integer.
1084 Return -1 if the digit is out of range for the base, -2 if it is
1085 not a digit in any supported base. (Bug#8602)
1086
1087 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1088
1089 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1090 to match comment at start of function. This also removes a
1091 GCC warning about overflow in a 32+64-bit port.
1092
1093 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1094
1095 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1096 Reported by Stefan Monnier in
1097 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1098 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1099 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1100
1101 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1102 (EMACS_UINTPTR): Likewise, with uintptr_t.
1103
1104 * lisp.h: Prefer 64-bit EMACS_INT if available.
1105 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1106 on 32-bit hosts that have 64-bit int, so that they can access
1107 large files.
1108 However, temporarily disable this change unless the temporary
1109 symbol WIDE_EMACS_INT is defined.
1110
1111 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1112
1113 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1114 This removes an assumption that EMACS_INT and long are the same
1115 width as pointers. The assumption is true for Emacs porting targets
1116 now, but we want to make other targets possible.
1117 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1118 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1119 In the rest of the code, change types of integers that hold casted
1120 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1121 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1122 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1123 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1124 No need to cast type when ORing.
1125 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1126 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1127 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1128 assume EMACS_INT is the same width as char *.
1129 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1130 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1131 Remove no-longer-needed casts.
1132 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1133 (xg_tool_bar_help_callback, xg_make_tool_item):
1134 Use EMACS_INTPTR to hold an integer
1135 that will be cast to void *; this can avoid a GCC warning
1136 if EMACS_INT is not the same width as void *.
1137 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1138 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1139 (current_message_1, set_message_1):
1140 Use a local to convert to proper width without a cast.
1141 * xmenu.c (dialog_selection_callback): Likewise.
1142
1143 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1144 Also, don't assume VALBITS / RAND_BITS is less than 5,
1145 and don't rely on undefined behavior when shifting a 1 left into
1146 the sign bit.
1147 * lisp.h (get_random): Change signature to match.
1148
1149 * lread.c (hash_string): Use size_t, not int, for hash computation.
1150 Normally we prefer signed values; but hashing is special, because
1151 it's better to use unsigned division on hash table sizes so that
1152 the remainder is nonnegative. Also, size_t is the natural width
1153 for hashing into memory. The previous code used 'int', which doesn't
1154 retain enough info to hash well into very large tables.
1155 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1156
1157 * dbusbind.c: Don't possibly lose pointer info when converting.
1158 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1159 Use XPNTR rather than XHASH, so that the high-order bits of
1160 the pointer aren't lost when converting through void *.
1161
1162 * eval.c (Fautoload): Don't double-shift a pointer.
1163
1164 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1165
1166 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1167
1168 * gnutls.c (DEF_GNUTLS_FN):
1169 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1170
1171 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1172
1173 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1174 marker. (Bug#8610)
1175
1176 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1177
1178 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1179 New version that can reserve upto 2GB of heap space.
1180
1181 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1182
1183 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1184
1185 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1186
1187 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1188 `gnutls_certificate_set_x509_key_file'.
1189
1190 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1193 Update dependencies.
1194
1195 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1198 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1199 Remove unused parameter `fildes'.
1200 * process.c (read_process_output, send_process): Don't pass it.
1201
1202 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1203
1204 Fix previous change: the library cache is defined in w32.c.
1205 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1206 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1207
1208 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1209
1210 Implement dynamic loading of GnuTLS on Windows.
1211
1212 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1213 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1214 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1215 Declare.
1216
1217 * gnutls.c (Qgnutls_dll): Define.
1218 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1219 (gnutls_*): Declare function pointers.
1220 (init_gnutls_functions): New function to initialize function pointers.
1221 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1222 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1224 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1225 (emacs_gnutls_write, emacs_gnutls_read)
1226 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1227 (Fgnutls_available_p): New function.
1228 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1229 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1230 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1231
1232 * image.c: Include w32.h.
1233 (Vimage_type_cache): Delete.
1234 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1235 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1236 (w32_delayed_load): Move to w32.c.
1237
1238 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1239
1240 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1241 (w32_delayed_load): Move from image.c. When loading a library, record
1242 its filename in the :loaded-from property of the library id.
1243 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1244 Initialize and staticpro them.
1245 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1246
1247 * process.c: Include lisp.h before w32.h, not after.
1248 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1249 instead of gnutls_record_check_pending.
1250
1251 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1252
1253 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1254
1255 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1256 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1257 as passed in.
1258
1259 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1260
1261 * xterm.c (x_set_frame_alpha): Do not set property on anything
1262 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1263
1264 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1267
1268 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1271 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1272 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1273 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1274 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1275 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1276 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1277 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1278 (Qgnutls_bootprop_callbacks_verify): Make static.
1279
1280 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1281
1282 * callproc.c: Indentation fixup.
1283
1284 * sysdep.c (wait_for_termination_1): Make static.
1285 (wait_for_termination, interruptible_wait_for_termination):
1286 Move after wait_for_termination_1.
1287
1288 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1289
1290 * sysdep.c (interruptible_wait_for_termination): New function
1291 which is like wait_for_termination, but allows keyboard
1292 interruptions.
1293
1294 * callproc.c (Fcall_process): Add (:file "file") as an option for
1295 the STDOUT buffer.
1296 (Fcall_process_region): Ditto.
1297
1298 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1299
1300 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1301 rather than `XVECTOR (FOO)->size'.
1302
1303 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1304 inttypes.h, as a gnulib replacement is used if it not available in
1305 system headers.
1306
1307 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1308
1309 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1310 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1311 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1312
1313 * coding.c (coding_alloc_by_realloc): Error out if destination
1314 will grow beyond MOST_POSITIVE_FIXNUM.
1315 (decode_coding_emacs_mule): Abort if there isn't enough place in
1316 charbuf for the composition carryover bytes. Reserve an extra
1317 space for up to 2 characters produced in a loop.
1318 (decode_coding_iso_2022): Abort if there isn't enough place in
1319 charbuf for the composition carryover bytes.
1320
1321 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1322
1323 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1324 aborting when %lld or %lll format is passed.
1325 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1326 %llo or %llx format is passed. (Bug#8545)
1327
1328 * window.c (window_scroll_line_based): Use a marker instead of
1329 simple variables to record original value of point. (Bug#7952)
1330
1331 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1332 produced by %s or %c overflows available buffer space. (Bug#8545)
1333
1334 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1337 (SIZE_MAX): Move defn after all includes, as they might #define it.
1338
1339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1340
1341 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1342
1343 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1344
1345 * keyboard.c (Qdelayed_warnings_hook): Define.
1346 (command_loop_1): Run `delayed-warnings-hook'
1347 if Vdelayed_warnings_list is non-nil.
1348 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1349 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1350
1351 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1352
1353 * doprnt.c (doprnt): Don't return value smaller than the buffer
1354 size if the message was truncated. (Bug#8545).
1355
1356 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1357
1358 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1359 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1360
1361 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1364
1365 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * makefile.w32-in: Update dependencies.
1368
1369 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1370
1371 Improve `doprnt' and its usage. (Bug#8545)
1372 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1373 `format_end'. Remove support for %l as a conversion specifier.
1374 Don't use xrealloc. Improve diagnostics when the %l size modifier
1375 is used. Update the commentary.
1376
1377 * eval.c (verror): Simplify calculation of size_t.
1378
1379 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1380 messages.
1381
1382 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1383
1384 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1385 change.
1386
1387 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1390 This makes this file independent of the recent pseudovector change.
1391
1392 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1395
1396 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1397 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1398 Remove unused local.
1399 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1400
1401 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1402 GCC 4.6.0 optimizes based on type-based alias analysis.
1403 For example, if b is of type struct buffer * and v of type struct
1404 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1405 != &v->size, and therefore "v->size = 1; b->size = 2; return
1406 v->size;" must therefore return 1. This assumption is incorrect
1407 for Emacs, since it type-puns struct Lisp_Vector * with many other
1408 types. To fix this problem, this patch adds a new type struct
1409 vectorlike_header that documents the constraints on layout of vectors
1410 and pseudovectors, and helps optimizing compilers not get fooled
1411 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1412 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1413 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1414 the size member.
1415 (XSETPVECTYPE): Rewrite in terms of new macro.
1416 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1417 This is a bit clearer, and further avoids the possibility of
1418 undesirable aliasing.
1419 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1420 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1421 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1422 since Lisp_Subr is a special case (no "next" field).
1423 (ASIZE): Now uses header.size rather than size.
1424 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1425 to avoid the hassle of writing XVECTOR (foo)->header.size.
1426 (struct vectorlike_header): New type.
1427 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1428 object, to help avoid aliasing.
1429 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1430 (SUBRP): Likewise, since Lisp_Subr is a special case.
1431 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1432 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1433 (struct Lisp_Hash_Table): Combine first two members into a single
1434 struct vectorlike_header member. All uses of "size" and "next" members
1435 changed to be "header.size" and "header.next".
1436 * buffer.h (struct buffer): Likewise.
1437 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1438 * frame.h (struct frame): Likewise.
1439 * process.h (struct Lisp_Process): Likewise.
1440 * termhooks.h (struct terminal): Likewise.
1441 * window.c (struct save_window_data, struct saved_window): Likewise.
1442 * window.h (struct window): Likewise.
1443 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1444 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1445 * buffer.c (init_buffer_once): Likewise.
1446 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1447 special case.
1448 * process.c (Fformat_network_address): Use local var for size,
1449 for brevity.
1450
1451 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1452
1453 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1454 * data.c (atof): Remove decl; no longer used or needed.
1455 (digit_to_number): Move to lread.c.
1456 (Fstring_to_number): Use new string_to_number function, to be
1457 consistent with how the Lisp reader treats infinities and NaNs.
1458 Do not assume that floating-point numbers represent EMACS_INT
1459 without losing information; this is not true on most 64-bit hosts.
1460 Avoid double-rounding errors, by insisting on integers when
1461 parsing non-base-10 numbers, as the documentation specifies.
1462 * lisp.h (string_to_number): New decl, replacing ...
1463 (isfloat_string): Remove.
1464 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1465 (read1): Do not accept +. and -. as integers; this
1466 appears to have been a coding error. Similarly, do not accept
1467 strings like +-1e0 as floating point numbers. Do not report
1468 overflow for integer overflows unless the base is not 10 which
1469 means we have no simple and reliable way to continue.
1470 Break out the floating-point parsing into a new
1471 function string_to_number, so that Fstring_to_number parses
1472 floating point numbers consistently with the Lisp reader.
1473 (digit_to_number): Move here from data.c. Make it static inline.
1474 (E_CHAR, EXP_INT): Remove, replacing with ...
1475 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1476 (string_to_number): New function, replacing isfloat_string.
1477 This function checks for valid syntax and produces the resulting
1478 Lisp float number too. Rework it so that string-to-number
1479 no longer mishandles examples like "1.0e+". Use strtoumax,
1480 so that overflow for non-base-10 numbers is reported only when
1481 there's no portable and simple way to convert to floating point.
1482
1483 * textprop.c (set_text_properties_1): Rewrite for clarity,
1484 and to avoid GCC warning about integer overflow.
1485
1486 * intervals.h (struct interval): Use EMACS_INT for members
1487 where EMACS_UINT might cause problems. See
1488 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1489 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1490 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1491 All uses changed.
1492 (offset_intervals): Tell GCC not to worry about length overflow
1493 when negating a negative length.
1494
1495 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1496 (overrun_check_free): Likewise.
1497
1498 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1499 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1500 word size.
1501
1502 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1503 (gnutls_make_error): Rename local to avoid shadowing.
1504 (gnutls_emacs_global_deinit): ifdef out; not used.
1505 (Fgnutls_boot): Use const for pointer to readonly storage.
1506 Comment out unused local. Fix pointer signedness problems.
1507
1508 * lread.c (openp): Don't stuff size_t into an 'int'.
1509 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1510 about possible signed overflow.
1511
1512 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1513 (GDK_KEY_g): Don't define if already defined.
1514 (xg_prepare_tooltip): Avoid pointer signedness problem.
1515 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1516
1517 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1518 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1519
1520 * xfns.c (Fx_window_property): Simplify a bit,
1521 to make a bit faster and to avoid GCC 4.6.0 warning.
1522 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1523
1524 * fns.c (internal_equal): Don't assume size_t fits in int.
1525
1526 * alloc.c (compact_small_strings): Tighten assertion a little.
1527
1528 Replace pEd with more-general pI, and fix some printf arg casts.
1529 * lisp.h (pI): New macro, generalizing old pEd macro to other
1530 conversion specifiers. For example, use "...%"pI"d..." rather
1531 than "...%"pEd"...".
1532 (pEd): Remove. All uses replaced with similar uses of pI.
1533 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1534 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1535 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1536 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1537 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1538 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1539 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1540 64-bit hosts.
1541 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1542 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1543 * print.c (safe_debug_print, print_object): Likewise.
1544 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1545 to int.
1546 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1547 avoiding the 0 flag, which is not portable.
1548 * process.c (Fmake_network_process): Use pI to avoid cast.
1549 * region-cache.c (pp_cache): Likewise.
1550 * xdisp.c (decode_mode_spec): Likewise.
1551 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1552 behavior on 64-bit hosts with printf arg.
1553 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1554 (x_stop_queuing_selection_requests): Likewise.
1555 (x_get_window_property): Don't truncate byte count to an 'int'
1556 when tracing.
1557
1558 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1559 here, since it parses constructs like leading '-' and spaces,
1560 which are not wanted; and it overflows with large numbers.
1561 Instead, simply match F[0-9]+, which is what is wanted anyway.
1562
1563 * alloc.c: Remove unportable assumptions about struct layout.
1564 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1565 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1566 (allocate_vectorlike, make_pure_vector): Use the new macros,
1567 plus offsetof, to remove unportable assumptions about struct layout.
1568 These assumptions hold on all porting targets that I know of, but
1569 they are not guaranteed, they're easy to remove, and removing them
1570 makes further changes easier.
1571
1572 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1573 This doesn't fix a bug but makes the code clearer.
1574 (string_overrun_cookie): Now const. Use initializers that
1575 don't formally overflow signed char, to avoid warnings.
1576 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1577 can cause Emacs to crash when string overrun checking is enabled.
1578 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1579 multiple of sizeof (EMACS_INT); it need not be, if
1580 alignof(EMACS_INT) < sizeof (EMACS_INT).
1581 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1582
1583 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1586
1587 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1588
1589 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1590 supposed to be handshaking. (Bug#8556)
1591 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1592
1593 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1594
1595 * lisp.h (Qdebug): List symbol.
1596 * eval.c (Qdebug): Restore global linkage.
1597 * keyboard.c (debug-on-event): New variable.
1598 (handle_user_signal): Break into debugger when debug-on-event
1599 matches the current signal symbol.
1600
1601 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1602
1603 * alloc.c (check_sblock, check_string_bytes)
1604 (check_string_free_list): Convert to standard C.
1605
1606 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1607
1608 * w32.c (emacs_gnutls_push): Fix typo.
1609
1610 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1611
1612 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1613 "cast to pointer from integer of different size".
1614
1615 Improve doprnt and its use in verror. (Bug#8545)
1616 * doprnt.c (doprnt): Document the set of format control sequences
1617 supported by the function. Use SAFE_ALLOCA instead of always
1618 using `alloca'.
1619
1620 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1621 is one byte too soon. Don't use xrealloc; instead xfree and
1622 xmalloc anew.
1623
1624 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1625
1626 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1627 callbacks stage.
1628
1629 * gnutls.c: Renamed global_initialized to
1630 gnutls_global_initialized. Added internals for the
1631 :verify-hostname-error, :verify-error, and :verify-flags
1632 parameters of `gnutls-boot' and documented those parameters in the
1633 docstring. Start callback support.
1634 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1635 unless a fatal error occured. Call gnutls_alert_send_appropriate
1636 on error. Return error code.
1637 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1638 (emacs_gnutls_read): Likewise.
1639 (Fgnutls_boot): Return handshake error code.
1640 (emacs_gnutls_handle_error): New function.
1641 (wsaerror_to_errno): Likewise.
1642
1643 * w32.h (emacs_gnutls_pull): Add prototype.
1644 (emacs_gnutls_push): Likewise.
1645
1646 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1647 (emacs_gnutls_push): Likewise.
1648
1649 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1650
1651 * process.c (wait_reading_process_output): Check if GnuTLS
1652 buffered some data internally if no FDs are set for TLS
1653 connections.
1654
1655 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1656 (LIBS): Link to USER_LIBS.
1657 ($(BLD)/gnutls.$(0)): New target.
1658
1659 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (handle_single_display_spec): Rename the
1662 display_replaced_before_p argument into display_replaced_p, to
1663 make it consistent with the commentary. Fix typos in the
1664 commentary.
1665
1666 * textprop.c (syms_of_textprop): Remove dead code.
1667 (copy_text_properties): Delete obsolete commentary about an
1668 interface that was deleted long ago. Fix typos in the description
1669 of arguments.
1670
1671 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1672 to changes in oldXMenu/XMenu.h from 2011-04-16.
1673 <menu_help_message, prev_menu_help_message>: Constify.
1674 (IT_menu_make_room): menu->help_text is now `const char **';
1675 adjust.
1676
1677 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1678 to changes in oldXMenu/XMenu.h from 2011-04-16.
1679 (struct XMenu): Declare `help_text' `const char **'.
1680
1681 * xfaces.c <Qunspecified>: Make extern again.
1682
1683 * syntax.c: Include sys/types.h before including regex.h, as
1684 required by Posix.
1685
1686 * doc.c (get_doc_string): Improve the format passed to `error'.
1687
1688 * doprnt.c (doprnt): Improve commentary.
1689
1690 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1691
1692 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1693 them with etags.
1694
1695 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1696 changes in globals.h immediately force recompilation.
1697 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1698 $(CURDIR)/s/ms-w32.h.
1699 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1700
1701 * character.c (Fchar_direction): Function deleted.
1702 (syms_of_character): Don't defsubr it.
1703 <char-direction-table>: Deleted.
1704
1705 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1706
1707 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1708 * doprnt.c: Include limits.h.
1709 (SIZE_MAX): New macro.
1710 (doprnt): Return a size_t value. 2nd arg is now size_t.
1711 Many local variables are now size_t instead of int or unsigned.
1712 Improve overflow protection. Support `l' modifier for integer
1713 conversions. Support %l conversion. Don't assume an EMACS_INT
1714 argument for integer conversions and for %c.
1715
1716 * lisp.h (doprnt): Restore prototype.
1717
1718 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1719 $(SRC)/character.h.
1720
1721 * Makefile.in (base_obj): Add back doprnt.o.
1722
1723 * deps.mk (doprnt.o): Add back prerequisites.
1724 (callint.o): Depend on character.h.
1725
1726 * eval.c (internal_lisp_condition_case): Include the handler
1727 representation in the error message.
1728 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1729 when breaking from the loop.
1730
1731 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1732
1733 * callint.c (Fcall_interactively): When displaying error message
1734 about invalid control letter, pass the character's codepoint, not
1735 a pointer to its multibyte form. Improve display of the character
1736 in octal and display also its hex code.
1737
1738 * character.c (char_string): Use %x to display the (unsigned)
1739 codepoint of an invalid character, to avoid displaying a bogus
1740 negative value.
1741
1742 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1743 `error', not SYMBOL_NAME itself.
1744
1745 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1746 character arguments to `error'.
1747
1748 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1749 to `error' in error message about FINAL_CHAR argument. Make sure
1750 FINAL_CHAR is a character, and use %c when it is passed as
1751 argument to `error'.
1752
1753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1754
1755 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1756
1757 * w32.c: Include <time.h>.
1758 (sys_localtime): New function.
1759
1760 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1761
1762 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1763
1764 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1765
1766 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1767
1768 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1769 zombies (Bug#8467).
1770
1771 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1772
1773 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1774 gl_state.e_property when gl_state.object is Qt.
1775
1776 * insdel.c (make_gap_larger): Remove limitation of buffer size
1777 to <= INT_MAX.
1778
1779 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * xdisp.c (lookup_glyphless_char_display)
1782 (produce_glyphless_glyph): Handle cons cell entry in
1783 glyphless-char-display.
1784 (Vglyphless_char_display): Document it.
1785
1786 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1787 glyphless-char-display.
1788
1789 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1790
1791 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1792
1793 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1794
1795 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1796 definition for no-X builds.
1797
1798 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Static checks with GCC 4.6.0 and non-default toolkits.
1801
1802 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1803
1804 * process.c (keyboard_bit_set): Define only if SIGIO.
1805 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1806 (send_process): Repair possible setjmp clobbering.
1807
1808 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1809
1810 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1811
1812 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1813
1814 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1815 Define only if needed.
1816
1817 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1818 by pacifying GCC about it. Maybe it's time to retire it?
1819 * xfaces.c (USG, __TIMEVAL__): Likewise.
1820
1821 * dispextern.h (struct redisplay_interface): Rename param
1822 to avoid shadowing.
1823 * termhooks.h (struct terminal): Likewise.
1824 * xterm.c (xembed_send_message): Likewise.
1825
1826 * insdel.c (make_gap_smaller): Define only if
1827 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1828
1829 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1830 it.
1831
1832 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1833 so that we aren't warned about unused symbols.
1834
1835 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1836
1837 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1838
1839 * xfns.c (x_real_positions): Mark locals as initialized.
1840
1841 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1842
1843 * xterm.c: Fix problems found by static analysis with other toolkits.
1844 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1845 (x_dispatch_event): Declare static if USE_GTK, and
1846 define if USE_GTK || USE_X_TOOLKIT.
1847 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1848 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1849 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1850 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1851
1852 * xmenu.c (menu_help_callback): Pointer type fixes.
1853 Use const pointers when pointing at readonly data. Avoid pointer
1854 signedness clashes.
1855 (FALSE): Remove unused macro.
1856 (update_frame_menubar): Remove unused decl.
1857
1858 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1859
1860 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1861 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1862 (single_menu_item): Rename local to avoid shadowing.
1863
1864 * keyboard.c (make_lispy_event): Remove unused local var.
1865
1866 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1867 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1868
1869 * bitmaps: Change bitmaps from unsigned char back to the X11
1870 compatible char. Avoid the old compiler warnings about
1871 out-of-range initializers by using, for example, '\xab' rather
1872 than 0xab.
1873
1874 * xgselect.c (xgselect_initialize): Check vs interface
1875 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1876
1877 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1878
1879 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1880 to read-only memory.
1881
1882 * fns.c (vector): Remove; this old hack is no longer needed.
1883
1884 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1885 Remove unused var.
1886 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1887
1888 * xrdb.c (x_load_resources): Omit unused local.
1889
1890 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1891 (x_window): Rename locals to avoid shadowing.
1892 (USG): Use the kludged USG macro, to pacify gcc.
1893
1894 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1895 (x_term_init): Remove local to avoid shadowing.
1896
1897 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1898
1899 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1900 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1901
1902 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1903
1904 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1905
1906 Fix regex.c, syntax.c and friends for buffers > 2GB.
1907 * syntax.h (struct gl_state_s): Declare character position members
1908 EMACS_INT.
1909
1910 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1911
1912 * textprop.c (verify_interval_modification, interval_of):
1913 Declare arguments EMACS_INT.
1914
1915 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1916 EMACS_INT.
1917
1918 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1919
1920 * indent.c (Fvertical_motion): Local variable it_start is now
1921 EMACS_INT.
1922
1923 * regex.c (re_match, re_match_2, re_match_2_internal)
1924 (bcmp_translate, regcomp, regexec, print_double_string)
1925 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1926 (re_compile_pattern, re_exec): Declare arguments and local
1927 variables `size_t' and `ssize_t' and return values `regoff_t', as
1928 appropriate.
1929 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1930 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1931 <compile_stack_type>: `size' and `avail' are now `size_t'.
1932
1933 * regex.h <regoff_t>: Use ssize_t, not int.
1934 (re_search, re_search_2, re_match, re_match_2): Arguments that
1935 specify buffer/string position and length are now ssize_t and
1936 size_t. Return type is regoff_t.
1937
1938 2011-04-16 Ben Key <bkey76@gmail.com>
1939
1940 * nsfont.m: Fixed bugs in ns_get_family and
1941 ns_descriptor_to_entity that were caused by using free to
1942 deallocate memory blocks that were allocated by xmalloc (via
1943 xstrdup). This caused Emacs to crash when compiled with
1944 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1945 --enable-checking=xmallocoverrun). xfree is now used to
1946 deallocate these memory blocks.
1947
1948 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1951
1952 emacs_write: Accept and return EMACS_INT for sizes.
1953 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1954 et seq.
1955 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1956 Accept and return EMACS_INT.
1957 (emacs_gnutls_write): Return the number of bytes written on
1958 partial writes.
1959 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1960 (emacs_read, emacs_write): Remove check for negative size, as the
1961 Emacs source code has been audited now.
1962 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1963 (emacs_read, emacs_write): Use it.
1964 * process.c (send_process): Adjust to the new signatures of
1965 emacs_write and emacs_gnutls_write. Do not attempt to store
1966 a byte offset into an 'int'; it might overflow.
1967 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1968
1969 * sound.c: Don't assume sizes fit in 'int'.
1970 (struct sound_device.period_size, alsa_period_size):
1971 Return EMACS_INT, not int.
1972 (struct sound_device.write, vox_write, alsa_write):
1973 Accept EMACS_INT, not int.
1974 (wav_play, au_play): Use EMACS_INT to store sizes and to
1975 record read return values.
1976
1977 2011-04-15 Ben Key <bkey76@gmail.com>
1978
1979 * keyboard.c (Qundefined): Don't declare static since it is used
1980 in nsfns.m.
1981 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1982 static since they are used in nsfont.m.
1983
1984 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1985
1986 * process.c (Qprocessp): Don't declare static.
1987 * lisp.h (Qprocessp): Declare again.
1988
1989 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1992
1993 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Improve C-level modularity by making more things 'static'.
1996
1997 Don't publish debugger-only interfaces to other modules.
1998 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1999 (verify_bytepos, count_markers): Move decls to the only modules
2000 that need them.
2001 * region-cache.h (pp_cache): Likewise.
2002 * window.h (check_all_windows): Likewise.
2003 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2004
2005 * sysdep.c (croak): Now static, if
2006 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2007 * syssignal.h (croak): Declare only if not static.
2008
2009 * alloc.c (refill_memory_reserve): Now static if
2010 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2011 * lisp.h (refill_memory_reserve): Declare only if not static.
2012
2013 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2014 Define only if USE_LUCID.
2015
2016 * xrdb.c (x_customization_string, x_rm_string): Now static.
2017
2018 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2019 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2020
2021 * xdisp.c (draw_row_with_mouse_face): Now static.
2022 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2023
2024 * window.h (check_all_windows): Mark externally visible.
2025
2026 * window.c (window_deletion_count): Now static.
2027
2028 * undo.c: Make symbols static if they're not exported.
2029 (last_undo_buffer, last_boundary_position, pending_boundary):
2030 Now static.
2031
2032 * textprop.c (interval_insert_behind_hooks): Now static.
2033 (interval_insert_in_front_hooks): Likewise.
2034
2035 * term.c: Make symbols static if they're not exported.
2036 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2037 (max_frame_lines, tty_set_terminal_modes):
2038 (tty_reset_terminal_modes, tty_turn_off_highlight):
2039 (get_tty_terminal): Now static.
2040 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2041 * termhooks.h (term_mouse_moveto): Do not declare if
2042 HAVE_WINDOW_SYSTEM.
2043 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2044 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2045
2046 * sysdep.c: Make symbols static if they're not exported.
2047 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2048 Now static.
2049 (sigprocmask_set, full_mask): Remove; unused.
2050 (wait_debugging): Mark as visible.
2051 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2052 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2053
2054 * syntax.c (syntax_temp): Define only if !__GNUC__.
2055
2056 * sound.c (current_sound_device, current_sound): Now static.
2057
2058 * search.c (searchbufs, searchbuf_head): Now static.
2059
2060 * scroll.c (scroll_cost): Remove; unused.
2061 * dispextern.h (scroll_cost): Remove decl.
2062
2063 * region-cache.h (pp_cache): Mark as externally visible.
2064
2065 * process.c: Make symbols static if they're not exported.
2066 (process_tick, update_tick, create_process, chan_process):
2067 (Vprocess_alist, proc_buffered_char, datagram_access):
2068 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2069 (deactivate_process): Mark defn as static, as well as decl.
2070 * lisp.h (create_process): Remove decl.
2071 * process.h (chan_process, Vprocess_alist): Remove decls.
2072
2073 * print.c: Make symbols static if they're not exported.
2074 (print_depth, new_backquote_output, being_printed, print_buffer):
2075 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2076 (print_interval, print_number_index, initial_stderr_stream):
2077 Now static.
2078 * lisp.h (Fprinc): Remove decl.
2079 (debug_output_compilation_hack): Mark as externally visible.
2080
2081 * sysdep.c (croak): Move decl from here to syssignal.h.
2082 * syssignal.h (croak): Put it here, so the API can be checked when
2083 'croak' is called from dissociate_if_controlling_tty.
2084
2085 * minibuf.c: Make symbols static if they're not exported.
2086 (minibuf_save_list, choose_minibuf_frame): Now static.
2087 * lisp.h (choose_minibuf_frame): Remove decl.
2088
2089 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2090
2091 * lread.c: Make symbols static if they're not exported.
2092 (read_objects, initial_obarray, oblookup_last_bucket_number):
2093 Now static.
2094 (make_symbol): Remove; unused.
2095 * lisp.h (initial_obarray, make_symbol): Remove decls.
2096
2097 * keyboard.c: Make symbols static if they're not exported.
2098 (single_kboard, recent_keys_index, total_keys, recent_keys):
2099 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2100 (this_single_command_key_start, echoing, last_auto_save):
2101 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2102 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2103 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2104 (Vlispy_mouse_stem, double_click_count):
2105 Now static.
2106 (force_auto_save_soon): Define only if SIGDANGER.
2107 (ignore_mouse_drag_p): Now static if
2108 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2109 (print_help): Remove; unused.
2110 (stop_character, last_timer_event): Mark as externally visible.
2111 * keyboard.h (ignore_mouse_drag_p): Declare only if
2112 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2113 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2114 * lisp.h (echoing): Remove decl.
2115 (force_auto_save_soon): Declare only if SIGDANGER.
2116 * xdisp.c (redisplay_window): Simplify code, to make it more
2117 obvious that ignore_mouse_drag_p is not accessed if !defined
2118 USE_GTK && !defined HAVE_NS.
2119
2120 * intervals.c: Make symbols static if they're not exported.
2121 (merge_properties_sticky, merge_interval_right, delete_interval):
2122 Now static.
2123 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2124
2125 * insdel.c: Make symbols static if they're not exported.
2126 However, leave prepare_to_modify_buffer alone. It's never
2127 called from outside this function, but that appears to be a bug.
2128 (combine_after_change_list, combine_after_change_buffer):
2129 (adjust_after_replace, signal_before_change): Now static.
2130 (adjust_after_replace_noundo): Remove; unused.
2131 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2132 (signal_before_change): Remove decls.
2133
2134 * indent.c (val_compute_motion, val_vmotion): Now static.
2135
2136 * image.c: Make symbols static if they're not exported.
2137 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2138 if USE_GTK.
2139 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2140 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2141
2142 * fringe.c (standard_bitmaps): Now static.
2143 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2144
2145 * frame.c: Make symbols static if they're not exported.
2146 (x_report_frame_params, make_terminal_frame): Now static.
2147 (get_frame_param): Now static, unless HAVE_NS.
2148 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2149 (x_get_resource_string): Remove; not used.
2150 * frame.h (make_terminal_frame, x_report_frame_params):
2151 (x_get_resource_string); Remove decls.
2152 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2153 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2154
2155 * font.c, fontset.c: Make symbols static if they're not exported.
2156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2157 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2158 * font.c (font_close_object): Now static.
2159 * font.h (font_close_object): Remove.
2160 * fontset.c (FONTSET_OBJLIST): Remove.
2161 (free_realized_fontset) #if-0 the body, which does nothing.
2162 (face_suitable_for_char_p): #if-0, as it's never called.
2163 * fontset.h (face_suitable_for_char_p): Remove decl.
2164 * xfaces.c (face_at_string_position):
2165 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2166 since 0 is always ASCII.
2167
2168 * fns.c (weak_hash_tables): Now static.
2169
2170 * fileio.c: Make symbols static if they're not exported.
2171 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2172 (Vwrite_region_annotation_buffers): Now static.
2173
2174 * eval.c: Make symbols static if they're not exported.
2175 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2176 * lisp.h (backtrace_list): Remove decl.
2177
2178 * emacs.c: Make symbols static if they're not exported.
2179 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2180 (fatal_error_code, fatal_error_signal_hook, standard_args):
2181 Now static.
2182 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2183 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2184 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2185 * lisp.h (fatal_error_signal_hook): Remove decl.
2186 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2187
2188 * editfns.c: Move a (normally-unused) function to its only use.
2189 * editfns.c, lisp.h (get_operating_system_release): Remove.
2190 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2191 worth the hassle of breaking this out.
2192
2193 * xterm.c: Make symbols static if they're not exported.
2194 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2195 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2196 (x_destroy_window, x_delete_display):
2197 Now static.
2198 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2199 (x_mouse_leave): Remove; unused.
2200 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2201 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2202 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2203 Remove decls.
2204 (x_mouse_leave): Declare only if WINDOWSNT.
2205 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2206 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2207 USE_X_TOOLKIT.
2208
2209 * ftxfont.c: Make symbols static if they're not exported.
2210 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2211 HAVE_FREETYPE.
2212 * font.h (ftxfont_driver): Likewise.
2213
2214 * xfns.c: Make symbols static if they're not exported.
2215 (x_last_font_name, x_display_info_for_name):
2216 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2217 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2218 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2219 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2220 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2221 (last_show_tip_args): Now static.
2222 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2223 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2224 (x_screen_planes): Remove; unused.
2225 * dispextern.h (x_screen_planes): Remove decl.
2226
2227 * dispnew.c: Make symbols static if they're not exported.
2228 * dispextern.h (redraw_garbaged_frames, scrolling):
2229 (increment_row_positions): Remove.
2230 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2231 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2232 Now static.
2233 (redraw_garbaged_frames): Remove; unused.
2234
2235 * xfaces.c: Make symbols static if they're not exported.
2236 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2237 Remove decls.
2238 * xterm.h (defined_color): Remove decls.
2239 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2240 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2241 (menu_face_changed_default, defined_color, free_realized_face):
2242 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2243 (ascii_face_of_lisp_face): Remove; unused.
2244
2245 * xdisp.c: Make symbols static if they're not exported.
2246 * dispextern.h (scratch_glyph_row, window_box_edges):
2247 (glyph_to_pixel_coords, set_cursor_from_row):
2248 (get_next_display_element, set_iterator_to_next):
2249 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2250 (show_mouse_face): Remove decls
2251 * frame.h (message_buf_print): Likewise.
2252 * lisp.h (pop_message, set_message, check_point_in_composition):
2253 Likewise.
2254 * xterm.h (set_vertical_scroll_bar): Likewise.
2255 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2256 (message_buf_print, scratch_glyph_row, displayed_buffer):
2257 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2258 (get_next_display_element, show_mouse_face, window_box_edges):
2259 (frame_to_window_pixel_xy, check_point_in_composition):
2260 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2261 (glyph_to_pixel_coords): Remove; unused.
2262
2263 * dired.c (file_name_completion): Now static.
2264
2265 * dbusbind.c (xd_in_read_queued_messages): Now static.
2266
2267 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2268 * data.c (circular_list_error): Remove.
2269
2270 * commands.h (last_point_position, last_point_position_buffer):
2271 (last_point_position_window): Remove decls.
2272 * keyboard.c: Make these variables static.
2273
2274 * coding.h (coding, code_convert_region, encode_coding_gap):
2275 Remove decls.
2276 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2277 (iso_code_class, detect_coding, code_convert_region): Now static.
2278 (encode_coding_gap): Remove; unused.
2279
2280 * chartab.c (chartab_chars, chartab_bits): Now static.
2281
2282 * charset.h (charset_iso_8859_1): Remove decl.
2283 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2284 Now static.
2285
2286 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2287 * ccl.c (Vccl_program_table): Now static.
2288 (check_ccl_update): Remove; unused.
2289
2290 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2291 * category.h: ... from here.
2292 * category.c (check_category_table, set_category_set): Now static.
2293
2294 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2295 * lisp.h: Remove these decls.
2296
2297 * buffer.c (buffer_count): Remove unused var.
2298
2299 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2300 so that it's not optimized away.
2301 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2302 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2303 exported only to the debugger.
2304
2305 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2306 * atimer.h (run_all_atimers): Remove; not exported.
2307
2308 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2309 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2310 was inaccessible from Lisp.
2311 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2312 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2313
2314 alloc.c: Import and export fewer symbols, and remove unused items.
2315 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2316 is defined.
2317 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2318 it's not optimized away by whole-program optimization.
2319 (message_enable_multibyte, free_misc): Remove.
2320 (catchlist, handlerlist, mark_backtrace):
2321 Declare only if BYTE_MARK_STACK.
2322 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2323 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2324 (message_enable_multibyte): Remove decl.
2325 (free_misc, interval_free_list, float_block, float_block_index):
2326 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2327 (cons_free_list, last_marked_index):
2328 Now static.
2329 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2330 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2331 (mark_backtrace): Define only if BYTE_MARK_STACK.
2332 * xdisp.c (message_enable_multibyte): Now static.
2333
2334 Declare Lisp_Object Q* variables to be 'static' if not exported.
2335 This makes it easier for human readers (and static analyzers)
2336 to see whether these variables are used from other modules.
2337 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2338 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2339 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2340 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2341 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2342 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2343 * xmenu.c, xselect.c:
2344 Declare Q* vars static if they are not used in other modules.
2345 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2346 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2347 Remove decls of unexported vars.
2348 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2349
2350 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2351
2352 Make Emacs functions such as Fatom 'static' by default.
2353 This makes it easier for human readers (and static analyzers)
2354 to see whether these functions can be called from other modules.
2355 DEFUN now defines a static function. To make the function external
2356 so that it can be used in other C modules, use the new macro DEFUE.
2357 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2358 (Finit_image_library):
2359 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2360 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2361 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2362 Remove decls, since these functions are now static.
2363 (Funintern, Fget_internal_run_time): New decls, since these functions
2364 were already external.
2365
2366 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2367 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2368 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2369 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2370 * keyboard.c, keymap.c, lread.c:
2371 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2372 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2373 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2374 Mark functions with DEFUE instead of DEFUN,
2375 if they are used in other modules.
2376 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2377 decls for now-static functions.
2378 * buffer.h (Fdelete_overlay): Remove decl.
2379 * callproc.c (Fgetenv_internal): Mark as internal.
2380 * composite.c (Fremove_list_of_text_properties): Remove decl.
2381 (Fcomposition_get_gstring): New forward static decl.
2382 * composite.h (Fcomposite_get_gstring): Remove decl.
2383 * dired.c (Ffile_attributes): New forward static decl.
2384 * doc.c (Fdocumntation_property): New forward static decl.
2385 * eval.c (Ffetch_bytecode): New forward static decl.
2386 (Funintern): Remove extern decl; now in .h file where it belongs.
2387 * fileio.c (Fmake_symbolic_link): New forward static decl.
2388 * image.c (Finit_image_library): New forward static decl.
2389 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2390 * intervals.h (Fprevious_property_change):
2391 (Fremove_list_of_text_properties): Remove decls.
2392 * keyboard.c (Fthis_command_keys): Remove decl.
2393 (Fcommand_execute): New forward static decl.
2394 * keymap.c (Flookup_key): New forward static decl.
2395 (Fcopy_keymap): Now static.
2396 * keymap.h (Flookup_key): Remove decl.
2397 * process.c (Fget_process): New forward static decl.
2398 (Fprocess_datagram_address): Mark as internal.
2399 * syntax.c (Fsyntax_table_p): New forward static decl.
2400 (skip_chars): Remove duplicate decl.
2401 * textprop.c (Fprevious_property_change): New forward static decl.
2402 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2403 Now internal.
2404 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2405 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2406
2407 * editfns.c (Fformat): Remove unreachable code.
2408
2409 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2410
2411 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2412 change. (Bug#8496)
2413
2414 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2417 when at ZV. (Bug#8487)
2418
2419 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2420
2421 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2422 (Bug#8437)
2423 * keyboard.c (parse_tool_bar_item): Likewise.
2424 * sound.c (sound_cleanup, alsa_close): Likewise.
2425 * termcap.c (tgetent): Likewise.
2426 * xfns.c (x_default_font_parameter): Likewise.
2427 * xsettings.c (read_and_apply_settings): Likewise.
2428
2429 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2430 (overrun_check_free): Protoize.
2431
2432 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2435 since callers should never pass a negative size.
2436 Change the signature to match that of plain 'read' and 'write'; see
2437 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2438 * lisp.h: Update prototypes of emacs_write and emacs_read.
2439
2440 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2441
2442 * xdisp.c (redisplay_window): Don't try to determine the character
2443 position of the scroll margin if the window start point w->startp
2444 is outside the buffer's accessible region. (Bug#8468)
2445
2446 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2447
2448 Fix write-region and its subroutines for buffers > 2GB.
2449 * fileio.c (a_write, e_write): Modify declaration of arguments and
2450 local variables to support buffers larger than 2GB.
2451 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2452
2453 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2454 argument, local variables, and return value.
2455
2456 * lisp.h: Update prototypes of emacs_write and emacs_read.
2457
2458 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2459
2460 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2463
2464 Fix more problems found by GCC 4.6.0's static checks.
2465
2466 * xdisp.c (vmessage): Use a better test for character truncation.
2467
2468 * charset.c (load_charset_map): <, not <=, for optimization,
2469 and to avoid potential problems with integer overflow.
2470 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2471 * casetab.c (set_identity, shuffle): Likewise.
2472 * editfns.c (Fformat): Likewise.
2473 * syntax.c (skip_chars): Likewise.
2474
2475 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2476 This also lets GCC 4.6.0 generate slightly better loop code.
2477
2478 * callint.c (Fcall_interactively): <, not <=, for optimization.
2479 (Fcall_interactively): Count the number of arguments produced,
2480 not the number of arguments given. This is simpler and lets GCC
2481 4.6.0 generate slightly better code.
2482
2483 * ftfont.c: Distingish more carefully between FcChar8 and char.
2484 The previous code passed unsigned char * to a functions like
2485 strlen and xstrcasecmp that expect char *, which does not
2486 conform to the C standard.
2487 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2488 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2489 char * when the C standard requires it.
2490
2491 * keyboard.c (read_char): Remove unused var.
2492
2493 * eval.c: Port to Windows vsnprintf (Bug#8435).
2494 Include <limits.h>.
2495 (SIZE_MAX): Define if the headers do not.
2496 (verror): Do not give up if vsnprintf returns a negative count.
2497 Instead, grow the buffer. This ports to Windows vsnprintf, which
2498 does not conform to C99. Problem reported by Eli Zaretskii.
2499 Also, simplify the allocation scheme, by avoiding the need for
2500 calling realloc, and removing the ALLOCATED variable.
2501
2502 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2503
2504 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2505 But keep the doprint source code for now, as we might revamp it
2506 and use it again (Bug#8435).
2507 * lisp.h (doprnt): Remove.
2508 * Makefile.in (base_obj): Remove doprnt.o.
2509 * deps.mk (doprnt.o): Remove.
2510
2511 error: Print 32- and 64-bit integers portably (Bug#8435).
2512 Without this change, on typical 64-bit hosts error ("...%d...", N)
2513 was used to print both 32- and 64-bit integers N, which relied on
2514 undefined behavior.
2515 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2516 New macro.
2517 * lisp.h (error, verror): Mark as printf-like functions.
2518 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2519 Report overflow in size calculations when allocating printf buffer.
2520 Do not truncate output string at its first null byte.
2521 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2522 Truncate the output at a character boundary, since vsnprintf does not
2523 do that.
2524 * charset.c (check_iso_charset_parameter): Convert internal
2525 character to string before calling 'error', since %c now has the
2526 printf meaning.
2527 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2528 overflow when computing char to be passed to 'error'. Do not
2529 pass Lisp_Object to 'error'; pass the integer instead.
2530 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2531 formatted with plain %d.
2532
2533 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2534
2535 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2536
2537 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2538
2539 * xterm.c (x_catch_errors): Remove duplicate declaration.
2540
2541 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2542
2543 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2544
2545 2011-04-10 Jim Meyering <meyering@redhat.com>
2546
2547 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2548 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2549 return ssize_t not "int", and use size_t as the buffer length.
2550 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2551 * gnutls.h: Update declarations.
2552 * process.c (read_process_output): Use ssize_t, to match.
2553 (send_process): Likewise.
2554
2555 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2556
2557 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2558
2559 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2562 Use unsigned char, to match FcChar8 type definition.
2563
2564 * xterm.c (handle_one_xevent):
2565 * xmenu.c (create_and_show_popup_menu):
2566 * xselect.c (x_decline_selection_request)
2567 (x_reply_selection_request): Avoid type-punned deref of X events.
2568
2569 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2570
2571 Fix some uses of `int' instead of EMACS_INT.
2572 * search.c (string_match_1, fast_string_match)
2573 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2574 (scan_buffer, find_next_newline_no_quit)
2575 (find_before_next_newline, search_command, Freplace_match)
2576 (Fmatch_data): Make some `int' variables be EMACS_INT.
2577
2578 * xdisp.c (display_count_lines): 3rd argument and return value now
2579 EMACS_INT. All callers changed.
2580 (pint2hrstr): Last argument is now EMACS_INT.
2581
2582 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2583 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2584 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2585 (decode_coding_utf_16, decode_coding_emacs_mule)
2586 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2587 (decode_coding_ccl, decode_coding_charset)
2588 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2589 (decode_coding_iso_2022, decode_coding_emacs_mule)
2590 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2591 <char_offset, last_offset>: Declare EMACS_INT.
2592 (encode_coding_utf_8, encode_coding_utf_16)
2593 (encode_coding_emacs_mule, encode_invocation_designation)
2594 (encode_designation_at_bol, encode_coding_iso_2022)
2595 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2596 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2597 Declare EMACS_INT.
2598 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2599 (encode_invocation_designation): Last argument P_NCHARS is now
2600 EMACS_INT.
2601 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2602 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2603
2604 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2605 All users changed.
2606
2607 * ccl.c (Fccl_execute_on_string): Declare some variables
2608 EMACS_INT.
2609
2610 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2611
2612 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2613
2614 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2615
2616 * process.c (Fformat_network_address): Doc fix.
2617
2618 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2619
2620 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2621
2622 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2623
2624 * keyboard.c (read_char): Call Lisp function help-form-show,
2625 instead of using internal_with_output_to_temp_buffer.
2626 (Qhelp_form_show): New var.
2627 (syms_of_keyboard): Use DEFSYM macro.
2628
2629 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2630
2631 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2632
2633 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * process.c (Flist_processes): Remove to Lisp.
2636 (list_processes_1): Delete.
2637
2638 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2639
2640 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2641
2642 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2643
2644 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 Fix more problems found by GCC 4.6.0's static checks.
2647
2648 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2649
2650 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2651
2652 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2653
2654 * xdisp.c (vmessage): Mark as a printf-like function.
2655
2656 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2657
2658 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2659
2660 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2661 printf-like functions.
2662 (tiff_load): Add casts to remove these marks before passing them
2663 to system-supplied API.
2664
2665 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2666
2667 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2668 This avoids several warnings with gcc -Wstrict-overflow.
2669 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2670 directly, rather than having caller test rule sign. This avoids
2671 some unnecessary tests.
2672 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2673 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2674 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2675
2676 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2677 (xfont_open): Avoid unnecessary tests.
2678
2679 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2680
2681 * composite.h, composite.c (composition_gstring_put_cache):
2682 Use EMACS_INT, not int, for length.
2683
2684 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2685 breaking out part of COMPOSITION_DECODE_RULE.
2686 (COMPOSITION_DECODE_RULE): Use it.
2687 * composite.c (get_composition_id): Remove unused local vars,
2688 by using the new macro.
2689
2690 * textprop.c (set_text_properties_1): Change while to do-while,
2691 since the condition is always true at first.
2692
2693 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2694 (interval_deletion_adjustment): Return unsigned value.
2695 All uses changed.
2696
2697 * process.c (list_processes_1, create_pty, read_process_output):
2698 (exec_sentinel): Remove vars that were set but not used.
2699 (create_pty): Remove unnecessary "volatile"s.
2700 (Fnetwork_interface_info): Avoid possibility of int overflow.
2701 (read_process_output): Do adaptive read buffering even if carryover.
2702 (read_process_output): Simplify nbytes computation if buffered.
2703
2704 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2705
2706 * syntax.c (scan_words): Remove var that was set but not used.
2707 (update_syntax_table): Use unsigned instead of int.
2708
2709 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2710 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2711 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2712
2713 * print.c (print_error_message): Avoid int overflow.
2714
2715 * font.c (font_list_entities): Redo for clarity,
2716 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2717
2718 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2719 (font_score): Avoid potential overflow in diff calculation.
2720
2721 * fns.c (substring_both): Remove var that is set but not used.
2722 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2723
2724 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2725
2726 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2727 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2728 can always succeed if overflow has undefined behavior.
2729
2730 * search.c (boyer_moore, wordify): Remove vars set but not used.
2731 (wordify): Omit three unnecessary tests.
2732
2733 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2734 All callers changed. This avoids the need for an unused var.
2735
2736 * casefiddle.c (casify_region): Remove var that is set but not used.
2737
2738 * dired.c (file_name_completion): Remove var that is set but not used.
2739
2740 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2741
2742 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2743 (Finsert_file_contents): Remove unnecessary code checking fd.
2744
2745 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2746 Check for integer overflow on size calculations.
2747
2748 * buffer.c (Fprevious_overlay_change): Remove var that is set
2749 but not used.
2750
2751 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2752 Remove vars that are set but not used.
2753 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2754 (timer_check_2): Mark vars as initialized.
2755
2756 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2757
2758 * image.c (lookup_image): Remove var that is set but not used.
2759 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2760
2761 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2762 that are set but not used.
2763
2764 * xfns.c (make_invisible_cursor): Don't return garbage
2765 if XCreateBitmapFromData fails (Bug#8410).
2766
2767 * xselect.c (x_get_local_selection, x_handle_property_notify):
2768 Remove vars that are set but not used.
2769
2770 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2771 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2772
2773 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2774 Remove var that is set but not used.
2775 (scroll_bar_windows_size): Now size_t, not int.
2776 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2777 Check for overflow.
2778
2779 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2780 (map_tty_color) [!defined MSDOS]: Likewise.
2781
2782 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2783
2784 * coding.c: Remove vars that are set but not used.
2785 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2786 All callers changed.
2787 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2788 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2789 (decode_coding_charset): Remove vars that are set but not used.
2790
2791 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2792 that is set but not used.
2793
2794 * print.c (print_object): Remove var that is set but not used.
2795
2796 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2797 The gnulib version avoids calling malloc in the usual case,
2798 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2799 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2800 * filelock.c (current_lock_owner): Likewise.
2801 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2802 * sysdep.c: Include allocator.h, careadlinkat.h.
2803 (emacs_no_realloc_allocator): New static constant.
2804 (emacs_readlink): New function.
2805 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2806 ../lib/careadlinkat.h.
2807
2808 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2809
2810 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2811 first non-nil return value).
2812
2813 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2816 if not defined (Bug#8403).
2817
2818 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * xdisp.c (display_count_lines): Remove parameter `start',
2821 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2822 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2823 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2824 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2825 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2826 and thereabouts. All callers changed.
2827 (get_per_char_metric): Remove parameter `f', unused since
2828 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2829
2830 2011-04-02 Jim Meyering <meyering@redhat.com>
2831
2832 do not dereference NULL upon failed strdup
2833 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2834 (ns_get_family): Likewise.
2835
2836 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2837
2838 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2839
2840 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2843 later (Bug#8403).
2844
2845 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2846
2847 Add lexical binding.
2848
2849 * window.c (Ftemp_output_buffer_show): New fun.
2850 (Fsave_window_excursion):
2851 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2852
2853 * lread.c (lisp_file_lexically_bound_p): New function.
2854 (Fload): Bind Qlexical_binding.
2855 (readevalloop): Remove `evalfun' arg.
2856 Bind Qinternal_interpreter_environment.
2857 (Feval_buffer): Bind Qlexical_binding.
2858 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2859 Mark as dynamic.
2860 (syms_of_lread): Declare `lexical-binding'.
2861
2862 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2863
2864 * keyboard.c (eval_dyn): New fun.
2865 (menu_item_eval_property): Use it.
2866
2867 * image.c (parse_image_spec): Use Ffunctionp.
2868
2869 * fns.c (concat, mapcar1): Accept byte-code-functions.
2870
2871 * eval.c (Fsetq): Handle lexical vars.
2872 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2873 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2874 (FletX, Flet): Obey lexical binding.
2875 (Fcommandp): Handle closures.
2876 (Feval): New `lexical' arg.
2877 (eval_sub): New function extracted from Feval. Use it almost
2878 everywhere where Feval was used. Look up vars in lexical env.
2879 Handle closures.
2880 (Ffunctionp): Move from subr.el.
2881 (Ffuncall): Handle closures.
2882 (apply_lambda): Remove `eval_flags'.
2883 (funcall_lambda): Handle closures and new byte-code-functions.
2884 (Fspecial_variable_p): New function.
2885 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2886 but without exporting it to Lisp.
2887
2888 * doc.c (Fdocumentation, store_function_docstring):
2889 * data.c (Finteractive_form): Handle closures.
2890
2891 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2892 interactive spec.
2893
2894 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2895 New byte-codes.
2896 (exec_byte_code): New function extracted from Fbyte_code to handle new
2897 calling convention for byte-code-functions. Add new byte-codes.
2898
2899 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2900
2901 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2902
2903 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2904
2905 * xdisp.c (redisplay_internal): Fix prototype.
2906
2907 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2908
2909 * xdisp.c (SCROLL_LIMIT): New macro.
2910 (try_scrolling): Use it when setting scroll_limit.
2911 Limit scrolling to 100 screen lines.
2912 (redisplay_window): Even when falling back on "recentering",
2913 position point in the window according to scroll-conservatively,
2914 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2915
2916 (try_scrolling): When point is above the window, allow searching
2917 as far as scroll_max, or one screenful, to compute vertical
2918 distance from PT to the scroll margin position. This prevents
2919 try_scrolling from unnecessarily failing when
2920 scroll-conservatively is set to a value slightly larger than the
2921 window height. Clean up the case of PT below the margin at bottom
2922 of window: scroll_max can no longer be INT_MAX. When aggressive
2923 scrolling is in use, don't let point enter the opposite scroll
2924 margin as result of the scroll.
2925 (syms_of_xdisp) <scroll-conservatively>: Document the
2926 threshold of 100 lines for never-recentering scrolling.
2927
2928 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2929
2930 * dispextern.h (move_it_by_lines):
2931 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2932 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2933 (message_log_check_duplicate): Remove parameters `prev_bol' and
2934 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2935 (redisplay_internal): Remove parameter `preserve_echo_area',
2936 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2937
2938 * indent.c (Fvertical_motion):
2939 * window.c (window_scroll_pixel_based, Frecenter):
2940 Don't pass `need_y_p' to `move_it_by_lines'.
2941
2942 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2943
2944 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2945 steal a few bits to be more compact.
2946 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2947 Remove unneeded casts.
2948
2949 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2950
2951 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2952
2953 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2954 binding" message (bug#7967).
2955
2956 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 Fix more problems found by GCC 4.6.0's static checks.
2959
2960 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2961 Remove unused local var.
2962
2963 * editfns.c (Fmessage_box): Remove unused local var.
2964
2965 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2966 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2967 Omit unused local vars.
2968 * window.c (shrink_windows): Omit unused local var.
2969 * menu.c (digest_single_submenu): Omit unused local var.
2970 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2971 Omit unused local var.
2972
2973 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2974 Don't assume string length fits in int.
2975 (keyremap_step, read_key_sequence): Use size_t for sizes.
2976 (read_key_sequence): Don't check last_real_key_start redundantly.
2977
2978 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2979 instead of alloca (Bug#8344).
2980
2981 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2982 (Fbacktrace_frame): Don't assume nframes fits in int.
2983
2984 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2985
2986 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2987 concerns.
2988
2989 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2990
2991 * cm.c (calccost): Turn while-do into do-while, for clarity.
2992
2993 * keyboard.c (syms_of_keyboard): Use the same style as later
2994 in this function when indexing through an array. This also
2995 works around GCC bug 48267.
2996
2997 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2998
2999 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3000
3001 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3002 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3003
3004 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3005 This avoids undefined behavior on integer overflow, and is a bit
3006 more convenient anyway since it is compared to a size_t variable.
3007
3008 Variadic C functions now count arguments with size_t, not int.
3009 This avoids an unnecessary limitation on 64-bit machines, which
3010 caused (substring ...) to crash on large vectors (Bug#8344).
3011 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3012 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3013 All variadic functions and their callers changed accordingly.
3014 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3015 * data.c (arith_driver, float_arith_driver): Likewise.
3016 * editfns.c (general_insert_function): Likewise.
3017 * eval.c (struct backtrace.nargs, interactive_p)
3018 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3019 (funcall_lambda, mark_backtrace): Likewise.
3020 * fns.c (concat): Likewise.
3021 * frame.c (x_set_frame_parameters): Likewise.
3022 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3023 0 if not found, not -1. All callers changed.
3024
3025 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3026 (stack_copy_size): Now size_t, not int.
3027 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3028
3029 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3032 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3033 All callers changed.
3034
3035 * lisp.h (multibyte_char_to_unibyte):
3036 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3037 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3038 * character.h (CHAR_TO_BYTE8):
3039 * cmds.c (internal_self_insert):
3040 * editfns.c (general_insert_function):
3041 * keymap.c (push_key_description):
3042 * search.c (Freplace_match):
3043 * xdisp.c (message_dolog, set_message_1): All callers changed.
3044
3045 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3046
3047 * keyboard.c (safe_run_hook_funcall): New function.
3048 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3049 don't set the hook to nil, but remove the offending function instead.
3050 (Qcommand_hook_internal): Remove, unused.
3051 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3052 Vcommand_hook_internal.
3053
3054 * eval.c (enum run_hooks_condition): Remove.
3055 (funcall_nil, funcall_not): New functions.
3056 (run_hook_with_args): Call each function through a `funcall' argument.
3057 Remove `cond' argument, now redundant.
3058 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3059 (Frun_hook_with_args_until_failure): Adjust accordingly.
3060 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3061
3062 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * dispextern.h (string_buffer_position): Remove declaration.
3065
3066 * print.c (strout): Remove parameter `multibyte', unused since
3067 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3068
3069 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3070 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3071 All callers changed.
3072
3073 * w32.c (_wsa_errlist): Use braces for struct initializers.
3074
3075 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3076 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3077 All callers changed.
3078 (string_buffer_position): Likewise. Also, make static (it's never
3079 used outside xdisp.c).
3080 (cursor_row_p): Remove parameter `w', unused since
3081 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3082 (decode_mode_spec): Remove parameter `precision', introduced during
3083 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3084 All callers changed.
3085
3086 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3087
3088 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3089
3090 2011-03-27 Anders Lindgren <andlind@gmail.com>
3091
3092 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3093 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3094 (ns_update_auto_hide_menu_bar): New functions.
3095 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3096 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3097 ns_constrain_all_frames.
3098 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3099 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3100
3101 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3102
3103 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3104
3105 2011-03-27 Glenn Morris <rgm@gnu.org>
3106
3107 * syssignal.h: Replace RETSIGTYPE with void.
3108 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3109 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3110 Replace SIGTYPE with void everywhere.
3111 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3112 * s/template.h (SIGTYPE): Remove commented out definition.
3113
3114 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3115
3116 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3117 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3118
3119 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3120
3121 * w32.c (read_unc_volume): Use parameter `henum', instead of
3122 global variable `wget_enum_handle'.
3123
3124 * keymap.c (describe_vector): Remove parameters `indices' and
3125 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3126 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3127
3128 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3129
3130 * keyboard.c (timer_check): Remove parameter `do_it_now',
3131 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3132 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3133 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3134
3135 * keyboard.c (read_char):
3136 * w32menu.c (w32_menu_display_help):
3137 * xmenu.c (show_help_event, menu_help_callback):
3138 Adjust calls to `show_help_echo'.
3139
3140 * gtkutil.c (xg_maybe_add_timer):
3141 * keyboard.c (readable_events):
3142 * process.c (wait_reading_process_output):
3143 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3144
3145 * insdel.c (adjust_markers_gap_motion):
3146 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3147 (gap_left, gap_right): Don't call it.
3148
3149 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3150
3151 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3152 incurred during fontification.
3153
3154 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3157 (DEFVAR_PER_BUFFER): Don't pass it.
3158
3159 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3160 (scrolling_window): Don't pass it.
3161
3162 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3165
3166 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3167 and `suffix'.
3168 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3169 of variables specific to SELinux and computation of `encoded_absname'.
3170
3171 * image.c (XPutPixel): Remove unused variable `height'.
3172
3173 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3174
3175 * unexw32.c (get_section_info): Remove unused variable `section'.
3176
3177 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3178 (system_process_attributes): Remove unused variable `sess'.
3179 (sys_read): Remove unused variable `err'.
3180
3181 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3182 (w32_wnd_proc): Remove unused variable `isdead'.
3183 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3184 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3185 (x_create_tip_frame): Remove unused variable `tem'.
3186
3187 * w32inevt.c (w32_console_read_socket):
3188 Remove unused variable `no_events'.
3189
3190 * w32term.c (x_draw_composite_glyph_string_foreground):
3191 Remove unused variable `width'.
3192
3193 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3194
3195 * w32term.c (x_set_glyph_string_clipping):
3196 Don't pass uninitialized region to CombineRgn.
3197
3198 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3201 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3202 (Fx_close_connection): Remove unused variable `i'.
3203
3204 * w32font.c (w32font_draw): Return number of glyphs.
3205 (w32font_open_internal): Remove unused variable `i'.
3206 (w32font_driver): Add missing initializer.
3207
3208 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3209 (fill_in_menu): Remove unused variable `items_added'.
3210
3211 * w32term.c (last_mouse_press_frame): Remove static global variable.
3212 (w32_clip_to_row): Remove unused variable `f'.
3213 (x_delete_terminal): Remove unused variable `i'.
3214
3215 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3216 (NOTHING): Remove unused static global variable.
3217 (uniscribe_check_otf): Remove unused variable `table'.
3218 (uniscribe_font_driver): Add missing initializers.
3219
3220 2011-03-23 Julien Danjou <julien@danjou.info>
3221
3222 * term.c (Fsuspend_tty, Fresume_tty):
3223 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3224 * window.c (temp_output_buffer_show):
3225 * insdel.c (signal_before_change):
3226 * frame.c (Fhandle_switch_frame):
3227 * fileio.c (Fdo_auto_save):
3228 * emacs.c (Fkill_emacs):
3229 * editfns.c (save_excursion_restore):
3230 * cmds.c (internal_self_insert):
3231 * callint.c (Fcall_interactively):
3232 * buffer.c (Fkill_all_local_variables):
3233 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3234 Use Frun_hooks.
3235 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3236 unconditionnaly since it does the check itself.
3237
3238 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 Fix more problems found by GCC 4.5.2's static checks.
3241
3242 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3243 the first time through the loop, since we know p0 < p1 then.
3244 This also avoids a gcc -Wstrict-overflow warning.
3245
3246 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3247 leading to a memory leak, possible in functions like
3248 load_charset_map_from_file that can allocate an unbounded number
3249 of objects (Bug#8318).
3250
3251 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3252 that could (at least in theory) be that large.
3253
3254 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3255 This is less likely to overflow, and avoids undefined behavior if
3256 overflow does occur. All callers changed. Use strtoul to scan
3257 for the unsigned long integer.
3258 (pint2hrstr): Simplify and tune code slightly.
3259 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3260
3261 * scroll.c (do_scrolling): Work around GCC bug 48228.
3262 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3263
3264 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3265 This also avoids a warning with gcc -Wstrict-overflow.
3266 (validate_x_resource_name): Simplify count usage.
3267 This also avoids a warning with gcc -Wstrict-overflow.
3268
3269 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3270 fail (Bug#8306).
3271
3272 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3273
3274 * process.c (Fmake_network_process): Use socklen_t, not int,
3275 where POSIX says socklen_t is required in portable programs.
3276 This fixes a porting bug on hosts like 64-bit HP-UX, where
3277 socklen_t is wider than int (Bug#8277).
3278 (Fmake_network_process, server_accept_connection):
3279 (wait_reading_process_output, read_process_output):
3280 Likewise.
3281
3282 * process.c: Rename or move locals to avoid shadowing.
3283 (list_processes_1, Fmake_network_process):
3284 (read_process_output_error_handler, exec_sentinel_error_handler):
3285 Rename or move locals.
3286 (Fmake_network_process): Define label "retry_connect" only if needed.
3287 (Fnetwork_interface_info): Fix pointer signedness.
3288 (process_send_signal): Add cast to avoid pointer signedness problem.
3289 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3290 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3291
3292 Make tparam.h and terminfo.c consistent.
3293 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3294 Include tparam.h instead, since it declares them.
3295 * cm.h (PC): Remove extern decl; tparam.h now does this.
3296 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3297 * terminfo.c: Include tparam.h, to check interfaces.
3298 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3299 (tparam): Adjust signature to match interface in tparam.h;
3300 this removes some undefined behavior. Check that outstring and len
3301 are zero, which they always are with Emacs.
3302 * tparam.h (PC, BC, UP): New extern decls.
3303
3304 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3305 (xftfont_open): Rename locals to avoid shadowing.
3306
3307 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3308 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3309 (OTF_TAG_SYM): Omit macro if not needed.
3310 (ftfont_list): Remove unused local.
3311 (get_adstyle_property, ftfont_pattern_entity):
3312 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3313 Rename locals to avoid shadowing.
3314
3315 * xfont.c (xfont_list_family): Mark var as initialized.
3316
3317 * xml.c (make_dom): Now static.
3318
3319 * composite.c (composition_compute_stop_pos): Rename local to
3320 avoid shadowing.
3321 (composition_reseat_it): Remove unused locals.
3322 (find_automatic_composition, composition_adjust_point): Likewise.
3323 (composition_update_it): Mark var as initialized.
3324 (find_automatic_composition): Mark vars as initialized,
3325 with a FIXME (Bug#8290).
3326
3327 character.h: Rename locals to avoid shadowing.
3328 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3329 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3330 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3331 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3332 to avoid shadowing.
3333
3334 * textprop.c (property_change_between_p): Remove; unused.
3335
3336 * intervals.c (interval_start_pos): Now static.
3337
3338 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3339
3340 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3341 Rename locals to avoid shadowing.
3342
3343 * sound.c (wav_play, au_play, Fplay_sound_internal):
3344 Fix pointer signedness.
3345 (alsa_choose_format): Remove unused local var.
3346 (wav_play): Initialize a variable to 0, to prevent undefined
3347 behavior (Bug#8278).
3348
3349 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3350
3351 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3352
3353 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3354 clobbering (Bug#8298).
3355 * sysdep.c (sys_subshell): Likewise.
3356 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3357
3358 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3359 This should get cleaned up, so that child_setup has the
3360 same signature on all platforms.
3361
3362 * callproc.c (call_process_cleanup): Now static.
3363 (relocate_fd): Rename locals to avoid shadowing.
3364
3365 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3366
3367 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3368 not to be necessary, and produces flickering.
3369
3370 2011-03-20 Glenn Morris <rgm@gnu.org>
3371
3372 * config.in: Remove file.
3373
3374 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3375
3376 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3377 are now in src/globals.h.
3378 (syms_of_minibuf): Remove spurious & from previous change.
3379
3380 2011-03-20 Leo <sdl.web@gmail.com>
3381
3382 * minibuf.c (completing-read-function): New variable.
3383 (completing-read-default): Rename from completing-read.
3384 (completing-read): Call completing-read-function.
3385
3386 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * xfaces.c (Fx_load_color_file):
3389 Read color file from absolute filename (bug#8250).
3390
3391 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * makefile.w32-in: Update dependencies.
3394
3395 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3396
3397 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3398
3399 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3400
3401 Fix more problems found by GCC 4.5.2's static checks.
3402
3403 * process.c (make_serial_process_unwind, send_process_trap):
3404 (sigchld_handler): Now static.
3405
3406 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3407 That way, the code declares only the vars that it needs.
3408 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3409 * s/cygwin.h (PTY_ITERATION): Likewise.
3410 * s/darwin.h (PTY_ITERATION): Likewise.
3411 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3412
3413 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3414 * process.c (allocate_pty): Don't declare stb unless it's needed.
3415
3416 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3417 (CONSTANTLIM): Remove; unused.
3418 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3419 Define only if needed.
3420
3421 * unexelf.c (unexec): Name an expression,
3422 to avoid gcc -Wbad-function-cast warning.
3423 Use a different way to cause a compilation error if anyone uses
3424 n rather than nn, a way that does not involve shadowing.
3425 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3426
3427 * deps.mk (unexalpha.o): Remove; unused.
3428
3429 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3430 * unexec.h: New file.
3431 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3432 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3433 Depend on unexec.h.
3434 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3435 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3436 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3437 Change as necessary to match prototype in unexec.h.
3438
3439 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3440 shadowing.
3441 (back_comment, skip_chars): Mark vars as initialized.
3442
3443 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3444 Rename locals to avoid shadowing.
3445
3446 * lread.c (read1): Rewrite so as not to use empty "else".
3447 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3448
3449 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3450
3451 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3452 warning when compiling print.c.
3453
3454 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3455 instead of using an uninitialized var.
3456 (font_sort_entities): Mark var as initialized.
3457
3458 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3459
3460 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3461 pointers to constants.
3462 (font_parse_fcname): Remove unused vars.
3463 (font_delete_unmatched): Now static.
3464 (font_get_spec): Remove; unused.
3465 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3466 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3467 Rename or move locals to avoid shadowing.
3468
3469 * fns.c (require_nesting_list, require_unwind): Now static.
3470 (Ffillarray): Rename locals to avoid shadowing.
3471
3472 * floatfns.c (domain_error2): Define only if needed.
3473 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3474
3475 * alloc.c (mark_backtrace): Move decl from here ...
3476 * lisp.h: ... to here, so that it can be checked.
3477
3478 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3479 (Fdefvar): Rewrite so as not to use empty "else".
3480 (lisp_indirect_variable): Name an expression,
3481 to avoid gcc -Wbad-function-cast warning.
3482 (Fdefvar): Rename locals to avoid shadowing.
3483
3484 * callint.c (quotify_arg, quotify_args): Now static.
3485 (Fcall_interactively): Rename locals to avoid shadowing.
3486 Use const pointer when appropriate.
3487
3488 * lisp.h (get_system_name, get_operating_system_release):
3489 Move decls here, to check interfaces.
3490 * process.c (get_operating_system_release): Move decl to lisp.h.
3491 * xrdb.c (get_system_name): Likewise.
3492 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3493 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3494 some of which prompt warnings from gcc -Wbad-function-cast.
3495 (Fformat_time_string, Fencode_time, Finsert_char):
3496 (Ftranslate_region_internal, Fformat):
3497 Rename or remove local vars to avoid shadowing.
3498 (Ftranslate_region_internal): Mark var as initialized.
3499
3500 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3501 avoid shadowing.
3502
3503 * lisp.h (eassert): Check that the argument compiles, even if
3504 ENABLE_CHECKING is not defined.
3505
3506 * data.c (Findirect_variable): Name an expression, to avoid
3507 gcc -Wbad-function-cast warning.
3508 (default_value, arithcompare, arith_driver, arith_error): Now static.
3509 (store_symval_forwarding): Rename local to avoid shadowing.
3510 (Fmake_variable_buffer_local, Fmake_local_variable):
3511 Mark variables as initialized.
3512 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3513
3514 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3515 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3516 Rename locals to avoid shadowing.
3517 (mark_stack): Move local variables into the #ifdef region where
3518 they're used.
3519 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3520 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3521 needed otherwise.
3522 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3523 (GC_STRING_CHARS): Remove; not used.
3524 (Fmemory_limit): Cast sbrk's returned value to char *.
3525
3526 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3527 avoids undefined behavior in theory.
3528
3529 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3530
3531 Use functions, not macros, for up- and down-casing (Bug#8254).
3532 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3533 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3534 to use the following functions instead of these macros.
3535 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3536 EMACS_INT, since callers assume the returned value fits in int.
3537 (upcase1): Likewise, for UPCASE_TABLE.
3538 (uppercasep, lowercasep, upcase): New static inline functions.
3539 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3540 the race-condition problem in the old DOWNCASE.
3541
3542 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3543 Rename locals to avoid shadowing.
3544 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3545 (regex_compile, re_search_2, re_match_2_internal):
3546 Remove unused local vars.
3547 (FREE_VAR): Rewrite so as not to use empty "else",
3548 which gcc can warn about.
3549 (regex_compile, re_match_2_internal): Mark locals as initialized.
3550 (RETALLOC_IF): Define only if needed.
3551 (WORDCHAR_P): Likewise. This one is never needed, but is used
3552 only in a comment talking about a compiler bug, so put inside
3553 the #if 0 of that comment.
3554 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3555 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3556 Remove; unused.
3557
3558 * search.c (boyer_moore): Rename locals to avoid shadowing.
3559 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3560 (PREV_CHAR_BOUNDARY): Likewise.
3561
3562 * search.c (simple_search): Remove unused var.
3563
3564 * dired.c (compile_pattern): Move decl from here ...
3565 * lisp.h: ... to here, so that it can be checked.
3566 (struct re_registers): New forward decl.
3567
3568 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3569
3570 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3571 All uses changed.
3572 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3573 Rename locals to avoid shadowing.
3574 (Fvertical_motion): Mark locals as initialized.
3575
3576 * casefiddle.c (casify_object, casify_region): Now static.
3577 (casify_region): Mark local as initialized.
3578
3579 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3580
3581 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3582 New macros, so that the caller can use some names other than
3583 gcpro1, gcpro2, etc.
3584 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3585 of the new macros.
3586 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3587 argument, for consistency with GCPRO2_VAR, etc: it is now the
3588 prefix of the variable, not the variable itself. All uses
3589 changed.
3590 * dired.c (directory_files_internal, file_name_completion):
3591 Rename locals to avoid shadowing.
3592
3593 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3594 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3595 dired.c's scmp function, had undefined behavior.
3596 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3597 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3598 * buffer.h: ... to here, because these macros use current_buffer,
3599 and the new implementation with inline functions needs to have
3600 current_buffer in scope now, rather than later when the macros
3601 are used.
3602 (downcase, upcase1): New static inline functions.
3603 (DOWNCASE, UPCASE1): Reimplement using these functions.
3604 This avoids undefined behavior in expressions like
3605 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3606 from race conditions in accessing the global variables
3607 case_temp1 and case_temp2.
3608 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3609 * lisp.h (case_temp1, case_temp2): Remove their decls.
3610 * character.h (ASCII_CHAR_P): Move from here ...
3611 * lisp.h: ... to here, so that the inline functions mentioned
3612 above can use them.
3613
3614 * dired.c (directory_files_internal_unwind): Now static.
3615
3616 * fileio.c (file_name_as_directory, directory_file_name):
3617 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3618 Now static.
3619 (file_name_as_directory): Use const pointers when appropriate.
3620 (Fexpand_file_name): Likewise. In particular, newdir might
3621 point at constant storage, so make it a const pointer.
3622 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3623 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3624 signedness issues.
3625 (Fset_file_times, Finsert_file_contents, auto_save_error):
3626 Rename locals to avoid shadowing.
3627
3628 * minibuf.c (choose_minibuf_frame_1): Now static.
3629 (Ftry_completion, Fall_completions): Rename or remove locals
3630 to avoid shadowing.
3631
3632 * marker.c (bytepos_to_charpos): Remove; unused.
3633
3634 * lisp.h (verify_bytepos, count_markers): New decls,
3635 so that gcc does not warn that these functions aren't declared.
3636
3637 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3638 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3639 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3640 (copy_text): Remove unused local var.
3641
3642 * filelock.c (within_one_second): Now static.
3643 (lock_file_1): Rename local to avoid shadowing.
3644
3645 * buffer.c (fix_overlays_before): Mark locals as initialized.
3646 (fix_start_end_in_overlays): Likewise. This function should be
3647 simplified by using pointers-to-pointers, but that's a different
3648 matter.
3649 (switch_to_buffer_1): Now static.
3650 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3651 (report_overlay_modification): Rename locals to avoid shadowing.
3652
3653 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3654 Fix pointer signedness issue.
3655 (sys_subshell): Mark local as volatile if checking for lint,
3656 to suppress a gcc -Wclobbered warning that does not seem to be right.
3657 (MAXPATHLEN): Define only if needed.
3658
3659 * process.c (serial_open, serial_configure): Move decls from here ...
3660 * systty.h: ... to here, so that they can be checked.
3661
3662 * fns.c (get_random, seed_random): Move extern decls from here ...
3663 * lisp.h: ... to here, so that they can be checked.
3664
3665 * sysdep.c (reset_io): Now static.
3666 (wait_for_termination_signal): Remove; unused.
3667
3668 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3669 (copy_keymap_item, append_key, push_text_char_description):
3670 Now static.
3671 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3672 (DENSE_TABLE_SIZE): Remove; unused.
3673 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3674 (describe_map_tree):
3675 Rename locals to avoid shadowing.
3676
3677 * keyboard.c: Declare functions static if they are not used elsewhere.
3678 (echo_char, echo_dash, cmd_error, top_level_2):
3679 (poll_for_input, handle_async_input): Now static.
3680 (read_char, kbd_buffer_get_event, make_lispy_position):
3681 (make_lispy_event, make_lispy_movement, apply_modifiers):
3682 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3683 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3684 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3685 (read_key_sequence, read_char): Mark locals as initialized.
3686 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3687
3688 * keyboard.h (make_ctrl_char): New decl.
3689 (mark_kboards): Move decl here ...
3690 * alloc.c (mark_kboards): ... from here.
3691
3692 * lisp.h (force_auto_save_soon): New decl.
3693
3694 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3695 (DEFINE_DUMMY_FUNCTION): New macro.
3696 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3697 Use it.
3698 (main): Add casts to avoid warnings
3699 if GCC considers string literals to be constants.
3700
3701 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3702
3703 * dbusbind.c: Pointer signedness fixes.
3704 (xd_signature, xd_append_arg, xd_initialize):
3705 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3706 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3707 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3708 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3709
3710 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3711 if GCC considers string literals to be constants.
3712 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3713
3714 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3717 (print_preprocess, print_object): New macro to fix last change.
3718
3719 * print.c (print_preprocess): Don't forget font objects.
3720
3721 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * emacs.c (USAGE3): Doc fixes.
3724
3725 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3726
3727 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3728 structure.
3729
3730 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3731
3732 * lisp.h (VWindow_system, Qfile_name_history):
3733 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3734 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3735 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3736
3737 * w32select.c: Don't #include "keyboard.h".
3738 (run_protected): Add extern declaration for waiting_for_input.
3739
3740 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3741 * w32console.c (detect_input_pending, read_input_pending)
3742 (encode_terminal_code):
3743 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3744 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3745 (w32_system_caret_y, Qfile_name_history):
3746 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3747 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3748 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3749 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3750 * w32proc.c (Qlocal, report_file_error):
3751 * w32term.c (Vwindow_system, updating_frame):
3752 * w32uniscribe.c (initialized, uniscribe_font_driver):
3753 Remove unneeded extern declarations.
3754
3755 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3756
3757 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3758
3759 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3760
3761 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3762 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3763 These macros can no longer be used for assignment.
3764
3765 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3766 Assign struct members directly, instead of using BUF_BEGV etc.
3767 (record_buffer_markers, fetch_buffer_markers): New functions for
3768 recording and fetching special buffer markers.
3769 (set_buffer_internal_1, set_buffer_temp): Use them.
3770
3771 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3772
3773 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3774
3775 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3776 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3777
3778 * xdisp.c (hscroll_window_tree):
3779 (reconsider_clip_changes): Use PT instead of BUF_PT.
3780
3781 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3782
3783 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3784 $(EMACS_ROOT)/lib/intprops.h.
3785
3786 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3787
3788 Fix more problems found by GCC 4.5.2's static checks.
3789
3790 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3791 to unsigned char * to avoid compiler diagnostic.
3792 (xg_free_frame_widgets): Make it clear that a local variable is
3793 needed only if USE_GTK_TOOLTIP.
3794 (gdk_window_get_screen): Make it clear that this macro is needed
3795 only if USE_GTK_TOOLTIP.
3796 (int_gtk_range_get_value): New function, which avoids a diagnostic
3797 from gcc -Wbad-function-cast.
3798 (xg_set_toolkit_scroll_bar_thumb): Use it.
3799 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3800 diagnostic from gcc -Wbad-function-cast.
3801 (get_utf8_string, xg_get_file_with_chooser):
3802 Rename locals to avoid shadowing.
3803 (create_dialog): Move locals to avoid shadowing.
3804
3805 * xgselect.c (xg_select): Remove unused var.
3806
3807 * image.c (four_corners_best): Mark locals as initialized.
3808 (gif_load): Initialize transparent_p to zero (Bug#8238).
3809 Mark another local as initialized.
3810 (my_png_error, my_error_exit): Mark with NO_RETURN.
3811
3812 * image.c (clear_image_cache): Now static.
3813 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3814 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3815 (x_edge_detection): Remove unnecessary cast that
3816 gcc -Wbad-function-cast diagnoses.
3817 (gif_load): Fix pointer signedness.
3818 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3819 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3820
3821 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Improve quality of tests for time stamp overflow.
3824 For example, without this patch (encode-time 0 0 0 1 1
3825 1152921504606846976) returns the obviously-bogus value (-948597
3826 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3827 reports time overflow. See
3828 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3829 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3830 * editfns.c: Include limits.h and intprops.h.
3831 (TIME_T_MIN, TIME_T_MAX): New macros.
3832 (time_overflow): Move earlier, to before first use.
3833 (hi_time, lo_time): New functions, for an accurate test for
3834 out-of-range times.
3835 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3836 (Fget_internal_run_time): Don't assume time_t fits in int.
3837 (make_time): Use list2 instead of Fcons twice.
3838 (Fdecode_time): More accurate test for out-of-range times.
3839 (check_tm_member): New function.
3840 (Fencode_time): Use it, to test for out-of-range times.
3841 (lisp_time_argument): Don't rely on undefined left-shift and
3842 right-shift behavior when checking for time stamp overflow.
3843
3844 * editfns.c (time_overflow): New function, refactoring common code.
3845 (Fformat_time_string, Fdecode_time, Fencode_time):
3846 (Fcurrent_time_string): Use it.
3847
3848 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3849 * dired.c (make_time): Move to ...
3850 * editfns.c (make_time): ... here.
3851 * systime.h: Note the move.
3852
3853 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3854
3855 * fringe.c (update_window_fringes): Remove unused variables.
3856
3857 * unexmacosx.c (copy_data_segment): Also copy __got section.
3858 (Bug#8223)
3859
3860 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3861
3862 * termcap.c [MSDOS]: Include "msdos.h".
3863 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3864 Constify `char *' arguments and their references according to
3865 prototypes in tparam.h.
3866
3867 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3868
3869 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3870 Adapt all references accordingly.
3871
3872 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3873
3874 2011-03-11 Tom Tromey <tromey@redhat.com>
3875
3876 * buffer.c (syms_of_buffer): Remove obsolete comment.
3877
3878 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3879
3880 * termhooks.h (encode_terminal_code): Declare prototype.
3881
3882 * msdos.c (encode_terminal_code): Don't declare prototype.
3883
3884 * term.c (encode_terminal_code): Now external again, used by
3885 w32console.c and msdos.c.
3886
3887 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3888 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3889
3890 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 Fix some minor problems found by GCC 4.5.2's static checks.
3893
3894 * fringe.c (update_window_fringes): Mark locals as initialized
3895 (Bug#8227).
3896 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3897
3898 * alloc.c (mark_fringe_data): Move decl from here ...
3899 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3900 to check its interface.
3901 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3902
3903 * fontset.c (free_realized_fontset): Now static.
3904 (Fset_fontset_font): Rename local to avoid shadowing.
3905 (fontset_font): Mark local as initialized.
3906 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3907
3908 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3909
3910 * xselect.c (x_disown_buffer_selections): Remove; not used.
3911 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3912 (x_own_selection, Fx_disown_selection_internal): Rename locals
3913 to avoid shadowing.
3914 (x_handle_dnd_message): Remove local to avoid shadowing.
3915
3916 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3917 so that the caller can use some name other than gcpro1.
3918 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3919 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3920 (Fx_backspace_delete_keys_p):
3921 Use them to avoid shadowing, and rename vars to avoid shadowing.
3922 (x_decode_color, x_set_name, x_window): Now static.
3923 (Fx_create_frame): Add braces to silence GCC warning.
3924 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3925 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3926 Remove unused locals.
3927 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3928 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3929 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3930 macros.
3931
3932 * xterm.h (x_mouse_leave): New decl.
3933
3934 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3935 Remove unused functions.
3936 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3937 (x_calc_absolute_position): Now static.
3938 (XTread_socket): Don't define label "out" unless it's used.
3939 Don't declare local "event" unless it's used.
3940 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3941 unless they are used.
3942 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3943 (x_fatal_error_signal): Remove; not used.
3944 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3945 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3946 (x_error_catcher, x_connection_closed, x_error_handler):
3947 (x_error_quitter, xembed_send_message, x_iconify_frame):
3948 (my_log_handler): Rename locals to avoid shadowing.
3949 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3950 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3951
3952 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3953 Rename or move locals to avoid shadowing.
3954 (tty_defined_color, merge_face_heights): Now static.
3955 (free_realized_faces_for_fontset): Remove; not used.
3956 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3957 does not deduce is never used uninitialized.
3958 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3959 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3960
3961 * terminal.c (store_terminal_param): Now static.
3962
3963 * xmenu.c (menu_highlight_callback): Now static.
3964 (set_frame_menubar): Remove unused local.
3965 (xmenu_show): Rename parameter to avoid shadowing.
3966 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3967 since they might point to immutable storage.
3968 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3969 since it's unused otherwise.
3970
3971 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3972 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3973 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3974 avoids a gcc -Wuninitialized diagnostic.
3975 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3976 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3977 does not deduce are never used uninitialized.
3978
3979 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3980
3981 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3982 * window.c (window_loop, size_window):
3983 (run_window_configuration_change_hook, enlarge_window): Likewise.
3984
3985 * window.c (display_buffer): Now static.
3986 (size_window): Mark variables that gcc -Wuninitialized
3987 does not deduce are never used uninitialized.
3988 * window.h (check_all_windows): New decl, to forestall
3989 gcc -Wmissing-prototypes diagnostic.
3990 * dispextern.h (bidi_dump_cached_states): Likewise.
3991
3992 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3993 shadowing.
3994 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3995 Include <limits.h>.
3996 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3997 and to avoid gcc -Wuninitialized warning.
3998 (load_charset_map): Mark variables that gcc -Wuninitialized
3999 does not deduce are never used uninitialized.
4000 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4001
4002 * coding.c (coding_set_source, coding_set_destination):
4003 Use "else { /* comment */ }" rather than "else /* comment */;"
4004 for clarity, and to avoid gcc -Wempty-body warning.
4005 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4006 a block, when the outer 'i' will do.
4007 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4008 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4009 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4010 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4011 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4012 Rename locals to avoid shadowing.
4013 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4014 * coding.c (emacs_mule_char, encode_invocation_designation):
4015 Now static, since they're not used elsewhere.
4016 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4017 (decode_coding_object, encode_coding_object, detect_coding_system):
4018 (decode_coding_emacs_mule): Mark variables that gcc
4019 -Wuninitialized does not deduce are never used uninitialized.
4020 (detect_coding_iso_2022): Initialize a local variable that might
4021 be used uninitialized. Leave a FIXME because it's not clear that
4022 this initialization is needed. (Bug#8211)
4023 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4024 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4025 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4026 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4027 Remove unused macros.
4028
4029 * category.c (hash_get_category_set): Remove unused local var.
4030 (copy_category_table): Now static, since it's not used elsewhere.
4031 * character.c (string_count_byte8): Likewise.
4032
4033 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4034 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4035
4036 * chartab.c (copy_sub_char_table): Now static, since it's not used
4037 elsewhere.
4038 (sub_char_table_ref_and_range, char_table_ref_and_range):
4039 Rename locals to avoid shadowing.
4040 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4041
4042 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4043 (BIDI_BOB): Remove unused macro.
4044
4045 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4046 deduce are never used uninitialized.
4047 * term.c (encode_terminal_code): Likewise.
4048
4049 * term.c (encode_terminal_code): Now static. Remove unused local.
4050
4051 * tparam.h: New file.
4052 * term.c, tparam.h: Include it.
4053 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4054 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4055 Move these decls to tparam.h, and make them agree with what
4056 is actually in tparam.c. The previous trick of using incompatible
4057 decls in different modules does not conform to the C standard.
4058 All callers of tparam changed to use tparam's actual API.
4059 * tparam.c (tparam1, tparam, tgoto):
4060 Use const pointers where appropriate.
4061
4062 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4063 * cm.h (struct cm): Likewise.
4064 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4065 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4066 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4067 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4068 (turn_on_face, init_tty): Likewise.
4069 * termchar.h (struct tty_display_info): Likewise.
4070
4071 * term.c (term_mouse_position): Rename local to avoid shadowing.
4072
4073 * alloc.c (mark_ttys): Move decl from here ...
4074 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4075
4076 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4077
4078 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4079
4080 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4081
4082 * search.c (compile_pattern_1): Remove argument regp, unused since
4083 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4084 (compile_pattern): Don't pass it.
4085
4086 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4087
4088 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4089 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4090 for ! HAVE_GTK3.
4091 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4092
4093 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4094
4095 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4096 gdk_window_get_screen, gdk_window_get_geometry,
4097 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4098 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4099 (xg_get_pixbuf_from_pixmap): New function.
4100 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4101 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4102 Call xg_get_pixbuf_from_pixmap instead of
4103 gdk_pixbuf_get_from_drawable.
4104 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4105 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4106 (xg_check_special_colors): Use GtkStyleContext and its functions
4107 for HAVE_GTK3.
4108 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4109 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4110 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4111 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4112 Call gtk_widget_get_preferred_size.
4113 (xg_frame_resized): gdk_window_get_geometry only takes 5
4114 parameters.
4115 (xg_win_to_widget, xg_event_is_for_menubar):
4116 Call gdk_x11_window_lookup_for_display.
4117 (xg_set_widget_bg): New function.
4118 (delete_cb): New function.
4119 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4120 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4121 (xg_set_background_color): Call xg_set_widget_bg.
4122 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4123 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4124 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4125 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4126 if ! HAVE_GTK3.
4127 (update_frame_tool_bar): Call gtk_widget_hide.
4128 (xg_initialize): Use GDK_KEY_g.
4129
4130 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4131 if ! HAVE_GTK3
4132 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4133
4134 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4135 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4136 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4137
4138 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4139
4140 * w32xfns.c (select_palette): Check success of RealizePalette against
4141 GDI_ERROR, not zero.
4142
4143 See ChangeLog.11 for earlier changes.
4144
4145 ;; Local Variables:
4146 ;; coding: utf-8
4147 ;; End:
4148
4149 Copyright (C) 2011 Free Software Foundation, Inc.
4150
4151 This file is part of GNU Emacs.
4152
4153 GNU Emacs is free software: you can redistribute it and/or modify
4154 it under the terms of the GNU General Public License as published by
4155 the Free Software Foundation, either version 3 of the License, or
4156 (at your option) any later version.
4157
4158 GNU Emacs is distributed in the hope that it will be useful,
4159 but WITHOUT ANY WARRANTY; without even the implied warranty of
4160 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4161 GNU General Public License for more details.
4162
4163 You should have received a copy of the GNU General Public License
4164 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.