]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* src/callproc.c (Fcall_process): Restore a line that was accidentally commented...
[gnu-emacs] / src / ChangeLog
1 2012-05-24 Ken Brown <kbrown@cornell.edu>
2
3 * callproc.c (Fcall_process): Restore a line that was accidentally
4 commented out in the 2011-02-13 change (bug#11547).
5
6 2012-05-23 Eli Zaretskii <eliz@gnu.org>
7
8 * lisp.h [REL_ALLOC]: Add prototypes for external functions
9 defined on ralloc.c.
10
11 * buffer.c [REL_ALLOC]: Remove prototypes of
12 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
13 they are now on lisp.h.
14
15 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
16
17 * search.c (search_buffer): Use it to inhibit relocation of buffer
18 text while re_search_2 is doing its job, because re_search_2 is
19 passed C pointers to buffer text. (Bug#11519)
20
21 2012-05-21 Eli Zaretskii <eliz@gnu.org>
22
23 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
24 Update value to 24.
25
26 2012-05-19 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
29 state after an additional call to move_it_in_display_line_to, keep
30 the values of it->max_ascent and it->max_descent found for the
31 entire line.
32 (pos_visible_p): Revert the comparison against bottom_y to what it
33 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
34 (Bug#11464)
35
36 2012-05-15 Eli Zaretskii <eliz@gnu.org>
37
38 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
39
40 2012-05-13 Eli Zaretskii <eliz@gnu.org>
41
42 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
43 already have overlays loaded.
44 (handle_single_display_spec): Before returning without displaying
45 fringe bitmap, synchronize the bidi iterator with the main display
46 iterator, by calling iterate_out_of_display_property.
47 (iterate_out_of_display_property): Detect buffer iteration by
48 testing that it->string is a Lisp string.
49 (get_next_display_element): When the current object is exhausted,
50 and there's something on it->stack, call set_iterator_to_next to
51 proceed with what's on the stack, instead of returning zero.
52 (set_iterator_to_next): If called at the end of a Lisp string,
53 proceed to consider_string_end without incrementing string
54 position. Don't increment display vector index past the end of
55 the display vector. (Bug#11417)
56 (pos_visible_p): Don't report a position visible when move_it_to
57 stopped at the last line of window, which happens to be scanned
58 backwards by the bidi iteration. (Bug#11464)
59
60 2012-05-11 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
63 and right-margin display specs even if the spec is invalid or we
64 are on a TTY, and thus unable to display on the fringes. That's
65 because the text with the property will not be displayed anyway,
66 so we need to signal to the caller that this is a "replacing"
67 display spec. This fixes display when the spec is invalid or we
68 are on a TTY.
69
70 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
71
72 * unexaix.c (make_hdr): Fix typo in prototype.
73 This bug broke the build on AIX. Problem reported by Gilles Pion.
74
75 2012-05-05 Eli Zaretskii <eliz@gnu.org>
76
77 * w32proc.c (new_child): Force Windows to reserve only 64KB of
78 stack for each reader_thread, instead of defaulting to 8MB
79 determined by the linker. This avoids failures in creating
80 subprocesses on Windows 7, see the discussion in this thread:
81 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
82
83 2012-05-02 Jim Meyering <meyering@redhat.com>
84
85 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
86
87 2012-04-29 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (pos_visible_p): If already at a newline from the
90 display string before the 'while' loop, don't walk back the glyphs
91 from it3.glyph_row. Solves assertion violation when the display
92 string begins with a newline (egg.el). (Bug#11367)
93
94 2012-04-24 Chong Yidong <cyd@gnu.org>
95
96 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
97
98 2012-04-23 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (pos_visible_p): If the window start position is beyond
101 ZV, start the display from buffer beginning. Prevents assertion
102 violation in init_iterator when the minibuffer window is scrolled
103 via the scroll bar.
104
105 * window.c (window_scroll_pixel_based): Likewise.
106
107 2012-04-23 Chong Yidong <cyd@gnu.org>
108
109 * keymap.c (where_is_internal): Doc fix (Bug#10872).
110
111 2012-04-20 Glenn Morris <rgm@gnu.org>
112
113 * fileio.c (Fcopy_file, Fset_file_selinux_context):
114 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
115
116 2012-04-20 Eli Zaretskii <eliz@gnu.org>
117
118 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
119 overrun array limits of glyph row's used[] array. (Bug#11288)
120
121 2012-04-20 Chong Yidong <cyd@gnu.org>
122
123 * process.c (wait_reading_process_output): If EIO occurs on a pty,
124 set the status to "failed" and ensure that sentinel is run.
125
126 2012-04-18 Glenn Morris <rgm@gnu.org>
127
128 * process.c (Fset_process_inherit_coding_system_flag)
129 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
130 (Fmake_network_process, Fmake_serial_process): Doc fix.
131
132 2012-04-17 Eli Zaretskii <eliz@gnu.org>
133
134 * xdisp.c (string_buffer_position_lim): Limit starting position to
135 BEGV.
136 (set_cursor_from_row): If called for a mode-line or header-line
137 row, return zero immediately.
138 (try_cursor_movement): If inside continuation line, don't back up
139 farther than the first row after the header line, if any. Don't
140 consider the header-line row as "partially visible", even if
141 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
142
143 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
144
145 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
146
147 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
148
149 * process.c (make_process):
150 * process.h: Add integer `gnutls_handshakes_tried' member to
151 process struct.
152
153 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
154 Add convenience `GNUTLS_LOG2i' macro.
155
156 * gnutls.c (gnutls_log_function2i): Convenience log function.
157 (emacs_gnutls_read): Use new log functions,
158 `gnutls_handshakes_tried' process member, and
159 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
160 attempts per process (connection).
161
162 2012-04-09 Eli Zaretskii <eliz@gnu.org>
163
164 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
165 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
166
167 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
168
169 * nsterm.m (constrainFrameRect): Always constrain when there is only
170 one screen (Bug#10962).
171
172 2012-04-06 Eli Zaretskii <eliz@gnu.org>
173
174 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
175 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
176 about subtle differences between FETCH_CHAR* and STRING_CHAR*
177 macros related to unification of CJK characters. For the details,
178 see the discussion following the message here:
179 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
180
181 2012-04-04 Chong Yidong <cyd@gnu.org>
182
183 * keyboard.c (Vdelayed_warnings_list): Doc fix.
184
185 2012-04-01 Eli Zaretskii <eliz@gnu.org>
186
187 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
188 instead of alloca. (Bug#11138)
189
190 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
191
192 * w32menu.c (is_simple_dialog): Properly check lisp types.
193 (Bug#11141)
194
195 2012-03-31 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
198 position we get to after a call to move_it_to fails the
199 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
200 only if we wind up in a string from display property. (Bug#11063)
201
202 * window.c (Fdelete_other_windows_internal): Invalidate the row
203 and column information about mouse highlight, so that redisplay
204 restores it after reallocating the glyph matrices. (Bug#7464)
205
206 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
207 string comes from a `display' text property, use the buffer
208 position of that property as if we actually saw that position in
209 the row's glyphs.
210 (move_it_by_lines): Remove the assertion that
211 "it->current_x == 0 && it->hpos == 0" which can be legitimately
212 violated when there's a before-string at the beginning of a line.
213 (Bug#11063)
214
215 2012-03-30 Eli Zaretskii <eliz@gnu.org>
216
217 * xdisp.c (append_space_for_newline): If the default face was
218 remapped, use the remapped face for the appended newline.
219 (extend_face_to_end_of_line): Use the remapped default face for
220 extending the face to the end of the line.
221 (display_line): Call extend_face_to_end_of_line when the default
222 face was remapped. (Bug#11068)
223
224 2012-03-29 Eli Zaretskii <eliz@gnu.org>
225
226 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
227
228 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
229
230 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
231
232 2012-03-27 Glenn Morris <rgm@gnu.org>
233
234 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
235 Doc fixes.
236
237 2012-03-26 Kenichi Handa <handa@m17n.org>
238
239 * dispextern.h (struct glyph): Fix previous change. Change the
240 bit length of glyphless.ch to 25 (Bug#11082).
241
242 2012-03-26 Chong Yidong <cyd@gnu.org>
243
244 * keyboard.c (Vselection_inhibit_update_commands): New variable.
245 (command_loop_1): Use it; inhibit selection update for
246 handle-select-window too (Bug#8996).
247
248 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
249
250 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
251
252 2012-03-25 Kenichi Handa <handa@m17n.org>
253
254 * dispextern.h (struct glyph): Change the bit length of
255 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
256
257 2012-03-24 Eli Zaretskii <eliz@gnu.org>
258
259 * s/ms-w32.h (tzname): Include time.h before redirecting to
260 _tzname. Fixes the MSVC build. (Bug#9960)
261
262 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
263
264 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
265 characters.
266
267 * xterm.c (XTread_socket): Only modify handling_signal if
268 !SYNC_INPUT. (Bug#11080)
269
270 2012-03-23 Eli Zaretskii <eliz@gnu.org>
271
272 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
273 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
274 when fetching a multibyte character consumes more bytes than
275 CHAR_BYTES returns, due to unification of CJK characters in
276 string_char. (Bug#11073)
277
278 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
279
280 * process.c (wait_reading_process_output): Handle pty disconnect
281 by refraining from sending oneself a SIGCHLD (bug#10933).
282
283 2012-03-22 Chong Yidong <cyd@gnu.org>
284
285 * dispextern.h (struct it): New member string_from_prefix_prop_p.
286
287 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
288 Mark string as coming from a prefix property.
289 (handle_face_prop): Use default face for prefix strings (Bug#4281).
290 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
291
292 2012-03-21 Chong Yidong <cyd@gnu.org>
293
294 * xfaces.c (Vface_remapping_alist): Doc fix.
295
296 2012-03-20 Eli Zaretskii <eliz@gnu.org>
297
298 * w32proc.c (Fw32_set_console_codepage)
299 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
300 Doc fixes.
301
302 2012-03-20 Chong Yidong <cyd@gnu.org>
303
304 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
305 to reflect default non-nil value of redisplay-dont-pause.
306
307 2012-03-19 Kenichi Handa <handa@m17n.org>
308
309 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
310 it fit in a valid range (Bug#11003).
311
312 2012-03-18 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
315 that is not from display property, accept the row as a "cursor
316 row" if one of the string's character has a non-nil `cursor'
317 property. Fixes cursor positioning when there are newlines in
318 overlay strings, e.g. in icomplete.el. (Bug#11035)
319
320 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
321
322 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
323
324 2012-03-12 Chong Yidong <cyd@gnu.org>
325
326 * eval.c (inhibit_lisp_code): Rename from
327 inhibit_window_configuration_change_hook; move from window.c.
328
329 * xfns.c (unwind_create_frame_1, Fx_create_frame):
330 * window.c (run_window_configuration_change_hook)
331 (syms_of_window): Callers changed.
332
333 2012-03-11 Chong Yidong <cyd@gnu.org>
334
335 * keymap.c (Fkey_description): Doc fix (Bug#9700).
336
337 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
338
339 2012-03-10 Chong Yidong <cyd@gnu.org>
340
341 * frame.c (other_visible_frames): Don't assume the selected frame
342 is visible (Bug#10955).
343
344 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
345
346 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
347
348 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
349
350 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
351 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
352 zero (Bug#10954).
353
354 2012-03-03 Glenn Morris <rgm@gnu.org>
355
356 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
357
358 2012-03-02 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
361 position past the first glyph_row that ends at ZV. (Bug#10902)
362 (redisplay_window, next_element_from_string): Fix typos in
363 comments.
364 (redisplay_window): Pass to move_it_vertically the margin in
365 pixels, not in screen lines.
366
367 2012-03-02 Glenn Morris <rgm@gnu.org>
368
369 * buffer.c (buffer-list-update-hook): Doc fix.
370
371 2012-02-29 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
374 push_it before setting up the iterator for the first overlay
375 string, even if we have an empty string loaded.
376 (next_overlay_string): If there's an empty string on the iterator
377 stack, pop the stack. (Bug#10903)
378
379 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
380
381 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
382 Suggested by Stefan Monnier in
383 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
384 * alloc.c (widen_to_Lisp_Object): New static function.
385 (mark_memory): Also mark Lisp_Objects by fetching pointer words
386 and widening them to Lisp_Objects. This would work even if
387 USE_LSB_TAG is defined and wide integers are used, which might
388 happen in a future version of Emacs.
389
390 2012-02-25 Chong Yidong <cyd@gnu.org>
391
392 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
393 Doc fix.
394
395 * xselect.c (Fx_selection_exists_p): Doc fix.
396 (x_clipboard_manager_save_all): Print an informative message
397 before saving to clipboard manager.
398
399 2012-02-24 Chong Yidong <cyd@gnu.org>
400
401 * keyboard.c (process_special_events): Handle all X selection
402 requests in kbd_buffer, not just the next one (Bug#8869).
403
404 2012-02-23 Chong Yidong <cyd@gnu.org>
405
406 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
407 call when setting menu-bar-lines and tool-bar-lines parameters.
408 (unwind_create_frame_1): New helper function.
409
410 * window.c (inhibit_window_configuration_change_hook): New var.
411 (run_window_configuration_change_hook): Obey it.
412 (syms_of_window): Initialize it.
413
414 2012-02-22 Chong Yidong <cyd@gnu.org>
415
416 * xterm.c (x_draw_image_relief): Add missing type check for
417 Vtool_bar_button_margin (Bug#10743).
418
419 2012-02-21 Chong Yidong <cyd@gnu.org>
420
421 * fileio.c (Vfile_name_handler_alist): Doc fix.
422
423 * buffer.c (Fget_file_buffer): Protect against invalid file
424 handler return value.
425
426 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
427
428 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
429 when computing $valmask.
430
431 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
432 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
433 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
434 It's useless in that case, and it can cause problems on hosts
435 that allocate halves of EMACS_INT values separately.
436 Reported by Dan Horák. Diagnosed by Andreas Schwab in
437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
438 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
439 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
440 it avoids undefined behavior on hosts where shifting right by more
441 than the word width has undefined behavior.
442
443 2012-02-19 Chong Yidong <cyd@gnu.org>
444
445 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
446 (Funhandled_file_name_directory, Ffile_name_as_directory)
447 (Fdirectory_file_name, Fexpand_file_name)
448 (Fsubstitute_in_file_name): Protect against invalid file handler
449 return values (Bug#10845).
450
451 2012-02-18 Eli Zaretskii <eliz@gnu.org>
452
453 * .gdbinit (pitx): Fix incorrect references to fields of the
454 iterator stack.
455
456 2012-02-17 Chong Yidong <cyd@gnu.org>
457
458 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
459
460 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
461
462 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
463 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
464
465 2012-02-15 Chong Yidong <cyd@gnu.org>
466
467 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
468 marked as special. Also, starting docstrings with * is obsolete.
469
470 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
471
472 * gnutls.c (emacs_gnutls_write): Fix last change.
473
474 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
475
476 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
477 send_process.
478
479 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
480
481 * keymap.c (Fsingle_key_description): Handle char ranges.
482
483 2012-02-12 Chong Yidong <cyd@gnu.org>
484
485 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
486 as that creates a dangerous corner case.
487
488 * window.c (Fdelete_window_internal): Invalidate the mouse
489 highlight (Bug#9904).
490
491 2012-02-12 Glenn Morris <rgm@gnu.org>
492
493 * xselect.c (Fx_own_selection_internal)
494 (Fx_get_selection_internal, Fx_disown_selection_internal)
495 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
496 * nsselect.m (Fx_own_selection_internal)
497 (Fx_disown_selection_internal, Fx_selection_exists_p)
498 (Fx_selection_owner_p, Fx_get_selection_internal):
499 Sync docs and argument specs with the xselect.c versions.
500
501 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
502
503 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
504
505 2012-02-11 Eli Zaretskii <eliz@gnu.org>
506
507 * w32select.c (Fx_selection_exists_p): Sync doc string and
508 argument list with xselect.c. (Bug#10783)
509
510 * w16select.c (Fx_selection_exists_p): Sync doc string and
511 argument list with xselect.c. (Bug#10783)
512
513 2012-02-10 Glenn Morris <rgm@gnu.org>
514
515 * fns.c (Fsecure_hash): Doc fix.
516
517 2012-02-09 Kenichi Handa <handa@m17n.org>
518
519 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
520
521 2012-02-07 Chong Yidong <cyd@gnu.org>
522
523 * buffer.c (Fbuffer_local_variables)
524 (buffer_lisp_local_variables): Handle unbound vars correctly;
525 don't let Qunbound leak into Lisp.
526
527 2012-02-07 Glenn Morris <rgm@gnu.org>
528
529 * image.c (Fimagemagick_types): Doc fix.
530
531 * image.c (imagemagick-render-type): Change it from a lisp object
532 to an integer. Move the doc here from the lisp manual.
533 Treat all values not equal to 0 the same.
534
535 2012-02-06 Chong Yidong <cyd@gnu.org>
536
537 * doc.c (store_function_docstring): Avoid applying docstring of
538 alias to base function (Bug#2603).
539
540 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
541
542 * .gdbinit (pp1, pv1): Remove redundant defines.
543 (pr): Use pp.
544
545 2012-02-04 Chong Yidong <cyd@gnu.org>
546
547 * nsterm.m: Declare a global (Bug#10694).
548
549 2012-02-04 Eli Zaretskii <eliz@gnu.org>
550
551 * w32.c (get_emacs_configuration_options):
552 Include --enable-checking, if specified, in the return value.
553
554 2012-02-04 Martin Rudalics <rudalics@gmx.at>
555
556 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
557 after rounding frame sizes. (Bug#9723)
558
559 2012-02-04 Eli Zaretskii <eliz@gnu.org>
560
561 * keyboard.c (adjust_point_for_property): Don't position point
562 before BEGV. (Bug#10696)
563
564 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
565
566 Handle overflow when computing char display width (Bug#9496).
567 * character.c (char_width): Return EMACS_INT, not int.
568 (char_width, c_string_width): Check for overflow when
569 computing the width; this is possible now that individual
570 characters can have unbounded width. Problem introduced
571 by merge from Emacs 23 on 2012-01-19.
572
573 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
574
575 * dbusbind.c (Fdbus_register_method): Mention the return value
576 :ignore in the docstring.
577
578 2012-02-02 Glenn Morris <rgm@gnu.org>
579
580 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
581
582 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
583 Unconditionally set to t. (Bug#10673)
584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
585 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
586 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
587
588 2012-02-02 Kenichi Handa <handa@m17n.org>
589
590 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
591 0, do not call append_composite_glyph.
592
593 2012-02-02 Kenichi Handa <handa@m17n.org>
594
595 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
596 NULL (Bug#6988).
597 (x_produce_glyphs): If the component of a composition is a null
598 string, set it->pixel_width to 1 to avoid zero-width glyph.
599
600 2012-02-01 Eli Zaretskii <eliz@gnu.org>
601
602 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
603 first 2 arguments are identical. This makes inserting large
604 output from a subprocess an order of magnitude faster on
605 MS-Windows, where all sbrk'ed memory is always contiguous.
606
607 2012-01-31 Glenn Morris <rgm@gnu.org>
608
609 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
610 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
611 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
612
613 2012-01-29 Glenn Morris <rgm@gnu.org>
614
615 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
616
617 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
618
619 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
620
621 2012-01-28 Chong Yidong <cyd@gnu.org>
622
623 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
624
625 2012-01-26 Chong Yidong <cyd@gnu.org>
626
627 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
628
629 * search.c (Fsearch_forward, Fsearch_backward): Document negative
630 repeat counts (Bug#10507).
631
632 2012-01-26 Glenn Morris <rgm@gnu.org>
633
634 * lread.c (syms_of_lread): Doc fix.
635
636 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
637
638 * coding.c (encode_designation_at_bol): Change return value to
639 EMACS_INT.
640
641 2012-01-25 Chong Yidong <cyd@gnu.org>
642
643 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
644
645 2012-01-21 Chong Yidong <cyd@gnu.org>
646
647 * floatfns.c (Fcopysign): Make the second argument non-optional,
648 since nil is not allowed anyway.
649
650 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
651
652 * process.c (read_process_output): Use p instead of XPROCESS (proc).
653 (send_process): Likewise.
654
655 2012-01-19 Martin Rudalics <rudalics@gmx.at>
656
657 * window.c (save_window_save, Fcurrent_window_configuration)
658 (Vwindow_persistent_parameters): Do not use Qstate.
659 Rewrite doc-strings.
660
661 2012-01-19 Kenichi Handa <handa@m17n.org>
662
663 * character.c (char_width): New function.
664 (Fchar_width, c_string_width, lisp_string_width):
665 Use char_width (Bug#9496).
666
667 2012-01-16 Martin Rudalics <rudalics@gmx.at>
668
669 * window.c (Vwindow_persistent_parameters): New variable.
670 (Fset_window_configuration, save_window_save): Handle persistent
671 window parameters.
672
673 2012-01-14 Eli Zaretskii <eliz@gnu.org>
674
675 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
676 thrashing the stack of the thread. (Bug#9087)
677
678 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
679
680 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
681
682 2012-01-11 Eli Zaretskii <eliz@gnu.org>
683
684 * xdisp.c (rows_from_pos_range): Handle the case where the
685 highlight ends on a newline. (Bug#10464)
686 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
687 he end column for display of highlight that ends on a newline
688 before a R2L line.
689
690 2012-01-11 Glenn Morris <rgm@gnu.org>
691
692 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
693 from load-path also when installation-directory is nil. (Bug#10208)
694
695 2012-01-10 Glenn Morris <rgm@gnu.org>
696
697 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
698
699 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
700 Update template values to be closer to their typical values these days.
701
702 2012-01-09 Eli Zaretskii <eliz@gnu.org>
703
704 * xdisp.c (rows_from_pos_range): Accept additional argument
705 DISP_STRING, and accept any glyph in a row whose object is that
706 string as eligible for mouse highlight. Fixes mouse highlight of
707 display strings from overlays. (Bug#10464)
708
709 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
710
711 emacs: fix an auto-save permissions race condition (Bug#10400)
712 * fileio.c (auto_saving_dir_umask): New static var.
713 (Fmake_directory_internal): Use it.
714 (do_auto_save_make_dir): Set it, instead of invoking chmod after
715 creating the directory. The old code temporarily assigns
716 too-generous permissions to the directory.
717 (do_auto_save_eh): Clear it.
718 (Fdo_auto_save): Catch all errors, not just file errors, so
719 that the var is always cleared.
720
721 2012-01-07 Eli Zaretskii <eliz@gnu.org>
722
723 * search.c (scan_buffer): Pass character positions to
724 know_region_cache, not byte positions. (Bug#6540)
725
726 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
727
728 * w32.c (sys_rename): Report EXDEV when rename of a directory
729 fails because the target is on another logical disk. (Bug#10284)
730
731 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
732
733 * xterm.c (x_embed_request_focus): New function.
734
735 * xterm.h: Add prototype.
736
737 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
738
739 2012-01-05 Glenn Morris <rgm@gnu.org>
740
741 * emacs.c (emacs_copyright): Update short copyright year to 2012.
742
743 2012-01-01 Eli Zaretskii <eliz@gnu.org>
744
745 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
746 Load gnutls_transport_set_lowat only if GnuTLS version is below
747 2.11.1.
748 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
749 GnuTLS versions below 2.11.1.
750
751 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
752
753 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
754 to the doc string advising against its use for altering the way
755 windows are scrolled.
756
757 2011-12-28 Kenichi Handa <handa@m17n.org>
758
759 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
760 coding-system ASCII compatible only when it does not produce BOM
761 on encoding (Bug#10383).
762
763 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
764
765 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
766 can scroll.
767 (create_and_show_popup_menu): Always use menu_position_func for
768 Gtk3 (Bug#10361).
769
770 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
771
772 * callint.c (Fcall_interactively): Don't truncate prompt string.
773
774 2011-12-23 Eli Zaretskii <eliz@gnu.org>
775
776 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
777 property that ends at ZV, so that the bidi iteration could be
778 resumed from there (after widening). (Bug#10360)
779
780 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
781
782 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
783
784 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
785
786 * nsterm.m (x_free_frame_resources):
787 Release f->output_data.ns->miniimage.
788 (ns_index_color): Fix indentation. Do not retain
789 color_table->colors[i].
790
791 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
792 before returning.
793
794 * nsfns.m (x_set_background_color): Assign return value from
795 ns_index_color to face-background instead of NSColor*.
796 (ns_implicitly_set_icon_type): Fix indentation.
797 Change assignment in for loop to comparison.
798
799 * emacs.c (ns_pool): New variable.
800 (main): Assign ns_pool.
801 (Fkill_emacs): Call ns_release_autorelease_pool.
802
803 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
804 autorelease fdesc, release fdAttrs and tdict.
805 (ns_get_covering_families): Release charset.
806 (ns_findfonts): Release NSFontDescriptor created with new.
807 (ns_uni_to_glyphs): Fix indentation.
808 (setString): Release attrStr before assigning new value.
809
810 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
811
812 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
813 and NS_IMPL_COCOA.
814 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
815 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
816
817 2011-12-18 David Reitter <reitter@cmu.edu>
818
819 * nsterm.m (ns_term_init): Subscribe for notifications
820 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
821 to method trackingNotification in EmacsMenu.
822
823 * nsmenu.m (trackingMenu): New variable.
824 (trackingNotification): New method (from Aquamacs).
825 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
826 from Aquamacs (Bug#7030).
827
828 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
829
830 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
831 (symbol_to_nsstring): Fix indentation.
832 (ns_symbol_to_pb): New function.
833 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
834 (Fns_rotate_cut_buffers_internal): Remove.
835 (Fns_store_selection_internal): Rename from
836 Fns_store_cut_buffer_internal.
837 (ns_get_foreign_selection, Fx_own_selection_internal)
838 (Fx_disown_selection_internal, Fx_selection_exists_p)
839 (Fns_get_selection_internal, Fns_store_selection_internal):
840 Use ns_symbol_to_pb and check if return value is nil.
841 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
842 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
843 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
844 renamed to Sns_store_selection_internal.
845 (ns_handle_selection_request): Move code to Fx_own_selection_internal
846 and remove this function.
847 (ns_handle_selection_clear): Remove, never used.
848 (Fx_own_selection_internal): Move code from ns_handle_selection_request
849 here.
850
851 2011-12-17 Ken Brown <kbrown@cornell.edu>
852
853 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
854 GID is unknown (Bug#10257).
855
856 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
857
858 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
859 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
860 which caused a build failure on GNU/Linux IA-64. This problem was
861 introduced by my 2011-10-07 patch.
862
863 2011-12-15 Juri Linkov <juri@jurta.org>
864
865 * image.c (imagemagick_error): New function. (Bug#10112)
866 (imagemagick_load_image): Comment out `MagickSetResolution' call.
867 Use `imagemagick_error' where ImageMagick functions return
868 `MagickFalse'.
869 (Fimagemagick_types): Add `Fnreverse' to return the list in the
870 proper order.
871
872 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
873
874 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
875 fill background (Bug#8992).
876
877 2011-12-13 Martin Rudalics <rudalics@gmx.at>
878
879 * window.c (Vwindow_combination_resize)
880 (Vwindow_combination_limit): Use t instead of non-nil in
881 doc-strings.
882 (Vrecenter_redisplay): Add first sentence of doc-string on
883 separate line.
884 (Frecenter): Fix doc-string typo.
885
886 2011-12-11 Kenichi Handa <handa@m17n.org>
887
888 * coding.c (Funencodable_char_position): Pay attention to the
889 buffer text relocation (Bug#9389).
890
891 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
892
893 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
894 gtk_init (Bug#10100).
895
896 2011-12-10 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
899 IT->string is nil. (Bug#10263)
900
901 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
902
903 * nsterm.h (x_free_frame_resources): Declare.
904
905 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
906 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
907
908 * nsterm.h (ns_get_defaults_value): Declare.
909
910 * nsterm.m (ns_default): Call ns_get_defaults_value.
911
912 2011-12-09 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
915 (Bug#10170)
916
917 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
918
919 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
920 that where the value of an _OBJC_* symbol points to is in the .bss
921 section (Bug#10240).
922
923 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
924
925 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
926 after the loop to call ccl_driver at least once (Bug#8619).
927
928 2011-12-08 Kenichi Handa <handa@m17n.org>
929
930 * ftfont.c (get_adstyle_property): Fix previous change
931 (Bug#10233).
932
933 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
934
935 * w32.c (init_environment): If no_site_lisp, remove site-lisp
936 dirs from the default value of EMACSLOADPATH (bug#10208).
937
938 2011-12-07 Glenn Morris <rgm@gnu.org>
939
940 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
941 installation and source directories as well. (Bug#10208)
942
943 2011-12-06 Chong Yidong <cyd@gnu.org>
944
945 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
946
947 2011-12-06 Glenn Morris <rgm@gnu.org>
948
949 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
950 as an error, not just -1. (Bug#10217)
951
952 2011-12-05 Chong Yidong <cyd@gnu.org>
953
954 * keyboard.c (process_special_events): New function.
955 (swallow_events, Finput_pending_p): Use it (Bug#10195).
956
957 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
958
959 * coding.c (encode_designation_at_bol): Don't use uninitialized
960 local variable (Bug#9318).
961
962 2011-12-05 Kenichi Handa <handa@m17n.org>
963
964 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
965 return Qnil (Bug#8046, Bug#10193).
966
967 2011-12-05 Kenichi Handa <handa@m17n.org>
968
969 * coding.c (encode_designation_at_bol): New args charbuf_end and
970 dst. Return the number of produced bytes. Callers changed.
971 (coding_set_source): Return how many bytes coding->source was
972 relocated.
973 (coding_set_destination): Return how many bytes
974 coding->destination was relocated.
975 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
976 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
977
978 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
979
980 * coding.c (CODING_CHAR_CHARSET_P): New macro.
981 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
982 macro (Bug#9318).
983
984 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
985
986 The following changes are to fix Bug#9318.
987
988 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
989 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
990 (encode_coding_iso_2022, encode_coding_sjis)
991 (encode_coding_big5, encode_coding_charset): Use the above macros.
992
993 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
994
995 * lisp.h (process_quit_flag): Fix external declaration.
996
997 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
998
999 Don't macro-inline non-performance-critical code.
1000 * eval.c (process_quit_flag): New function.
1001 * lisp.h (QUIT): Use it.
1002
1003 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1004
1005 * nsfns.m (get_geometry_from_preferences): New function.
1006 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1007
1008 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1009
1010 * emacs.c (Qkill_emacs): Define.
1011 (syms_of_emacs): Initialize it.
1012 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1013 Qquit_flag to `kill-emacs' instead.
1014 (quit_throw_to_read_char): Add parameter `from_signal'.
1015 All callers changed. Call Fkill_emacs if requested and safe.
1016 * lisp.h (QUIT): Call Fkill_emacs if requested.
1017
1018 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1019
1020 * widget.c (update_wm_hints): Return if wmshell is null.
1021 (widget_update_wm_size_hints): New function.
1022
1023 * widget.h (widget_update_wm_size_hints): Declare.
1024
1025 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1026 widget_update_wm_size_hints (Bug#10104).
1027
1028 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1029
1030 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1031 before a newline, prepare the bidi iterator for consuming the
1032 newline, and keep the current paragraph direction. (Bug#10183)
1033 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1034
1035 2011-12-02 Juri Linkov <juri@jurta.org>
1036
1037 * search.c (Fword_search_regexp): New Lisp function created from
1038 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1039 (Fword_search_backward, Fword_search_forward)
1040 (Fword_search_backward_lax, Fword_search_forward_lax):
1041 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1042 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1043
1044 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1045
1046 * fileio.c (Finsert_file_contents): Move after-change-function call
1047 to before the "handled:" label, since all "goto handled" appear in
1048 cases where the *-change-functions have already been properly called
1049 (bug#10117).
1050
1051 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1054 waiting for input. (Bug#10169)
1055
1056 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1057
1058 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1059 verifies glyph row's hash code--we have just reallocated the
1060 glyphs, so their contents can be complete garbage. (Bug#10164)
1061
1062 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1065
1066 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1067
1068 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1069 attributes are tested _before_ calling verify_row_hash, to protect
1070 against GCC re-ordering of the tests. (Bug#10164)
1071
1072 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1073
1074 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1075
1076 * xterm.c (handle_one_xevent): Only set async_visible and friends
1077 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1078 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1079 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1080
1081 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1084 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1085 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1086 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1087 All uses changed to use GCPRO1 etc.
1088 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1089 Revert to old implementation (i.e., before 2011-03-11).
1090
1091 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1092
1093 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1094 of scroll runs so as to avoid assigning disabled bogus rows and
1095 unnecessary graphics copy operations.
1096
1097 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1098
1099 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1100 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1101 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1102 (malloc, free, realloc, calloc): Redirect to e_* only when
1103 compiling Emacs.
1104
1105 * lisp.h (GCTYPEBITS): Move before first use.
1106 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1107 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1108 this macro definition.
1109
1110 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1111 _MSC_VER.
1112
1113 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1114
1115 * gtkutil.c (xg_create_frame_widgets):
1116 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1117 present with Gtk+ 2.0.
1118
1119 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * fileio.c (Finsert_file_contents): Undo previous change; see
1122 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1123
1124 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 Rename locals to avoid shadowing.
1127 * fileio.c (Finsert_file_contents):
1128 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1129 * process.c (wait_reading_process_output):
1130 Rename inner 'proc' to 'p' to avoid shadowing.
1131 Indent for consistency with usual Emacs style.
1132
1133 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (redisplay_window): If cursor row is not fully visible
1136 after recentering, and scroll-conservatively is set to a large
1137 number, scroll window by a few more lines to make the cursor fully
1138 visible and out of scroll-margin. (Bug#10105)
1139 (start_display): Don't move to the next line if the display should
1140 start at a newline that is part of a display vector or an overlay
1141 string. (Bug#10119)
1142
1143 2011-11-24 Juri Linkov <juri@jurta.org>
1144
1145 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1146 after the `MagickPingImage' call. (Bug#10112)
1147
1148 2011-11-23 Chong Yidong <cyd@gnu.org>
1149
1150 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1151
1152 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1153
1154 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1155 making another buffer current. (Bug#10114)
1156
1157 2011-11-23 Glenn Morris <rgm@gnu.org>
1158
1159 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1160
1161 2011-11-23 Chong Yidong <cyd@gnu.org>
1162
1163 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1164 using it (Bug#5984).
1165
1166 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1167
1168 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1169 and header-lines, as they don't have one computed for them.
1170 (Bug#10098)
1171
1172 * .gdbinit (prow): Make displayed values more self-explaining.
1173 Add row's hash code.
1174
1175 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1176
1177 * process.c (wait_reading_process_output): Fix asynchrounous
1178 GnuTLS socket handling on some versions of the GnuTLS library.
1179 (wait_reading_process_output): Add comment and URL.
1180
1181 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1182
1183 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1184
1185 2011-11-21 Chong Yidong <cyd@gnu.org>
1186
1187 * window.c (Fnext_window, Fprevious_window): Doc fix.
1188
1189 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1190
1191 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1192
1193 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1196
1197 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1198
1199 * window.c (Fset_window_combination_limit): Rename argument
1200 STATUS to LIMIT.
1201 (Vwindow_combination_limit): Remove "status" from doc-string.
1202
1203 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1204
1205 * m/ibms390.h: Remove.
1206 * m/ibms390x.h: Don't include "ibms390.h".
1207
1208 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1209
1210 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1211 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1212
1213 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * casetab.c (Fset_case_table):
1216 * charset.c (Fcharset_after): Fix typos.
1217
1218 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1221 Otherwise, valgrind does not work on some platforms.
1222 Problem reported by Andreas Schwab in
1223 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1224 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1225 is set, removing the need for VIRT_ADDRESS_VARIES.
1226 (PURE_P): Use a more-efficient implementation that needs just one
1227 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1228 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1229 to 4 (xorl, subq, cmpq, setbe).
1230 * alloc.c (pure): Always extern now, since that's the
1231 VIRT_ADDR_VARIES behavior.
1232 (PURE_POINTER_P): Use a single comparison, not two, for
1233 consistency with the new puresize.h.
1234 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1235 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1236 Remove VIRT_ADDR_VARIES no longer needed.
1237
1238 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1239
1240 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1241 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1242 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1243 behave as if the cursor position were at the window margin.
1244
1245 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1246 and the cursor position is out of bounds, behave as if the cursor
1247 position were at the window margin. (Bug#10075)
1248
1249 2011-11-18 Chong Yidong <cyd@gnu.org>
1250
1251 * window.c (Fwindow_combination_limit): Make first argument
1252 non-optional, since it is meaningless for live windows like the
1253 selected window.
1254
1255 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1258
1259 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1260
1261 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1262 (graft_intervals_into_buffer): Simplify.
1263
1264 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1265
1266 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1267 hash values of the two rows.
1268 (copy_row_except_pointers): Preserve the used[] arrays and the
1269 hash values of the two rows. (Bug#10035)
1270 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1271
1272 * xdisp.c (row_hash): New function, body extracted from
1273 compute_line_metrics.
1274 (compute_line_metrics): Call row_hash, instead of computing the
1275 hash code inline.
1276
1277 * dispnew.c (verify_row_hash): Call row_hash for computing the
1278 hash code of a row, instead of duplicating code from xdisp.c.
1279
1280 * dispextern.h (row_hash): Add prototype.
1281
1282 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1283
1284 * frame.c (delete_frame): Don't delete the terminal when the last
1285 X frame is closed if emacs is built with GTK toolkit.
1286
1287 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1288
1289 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1290
1291 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1292
1293 * window.c (Vwindow_splits): Rename to
1294 Vwindow_combination_resize. Suggested by Juri Linkov.
1295 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1296 of Vwindow_splits.
1297
1298 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * nsfns.m (Fns_font_name):
1301 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1302
1303 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1304
1305 * window.h (window): Rename slot "nest" to "combination_limit".
1306 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1307 (Fset_window_nest): Rename to Fset_window_combination_limit.
1308 (Vwindow_nest): Rename to Vwindow_combination_limit.
1309 (recombine_windows, make_parent_window, make_window)
1310 (Fsplit_window_internal, saved_window)
1311 (Fset_window_configuration, save_window_save): Rename all
1312 occurrences of window_nest to window_combination_limit.
1313
1314 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * image.c (imagemagick_load_image): Fix typo.
1317
1318 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (display_line): Move the call to
1321 highlight_trailing_whitespace before the call to
1322 compute_line_metrics, since the latter needs to see the final
1323 faces of all the glyphs to compute ROW's hash value.
1324 Fixes assertion violations in row_equal_p. (Bug#10035)
1325
1326 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1329 just return (bug#10044).
1330
1331 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1332
1333 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1334 with user-defined heap size. Bump the default size of the temacs
1335 heap to 27MB, to avoid memory warning when running temacs.
1336 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1337
1338 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1339 current_matrix and desired_matrix. (Bug#9990)
1340 (verify_row_hash) [XASSERTS]: New function.
1341 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1342 that the hash value of glyph rows is correct.
1343
1344 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1345
1346 * window.h (window): Remove splits slot.
1347 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1348 (Fdelete_other_windows_internal, make_parent_window)
1349 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1350 (Fset_window_configuration, save_window_save): Don't deal with
1351 split status of windows.
1352 (saved_window): Remove splits slot.
1353 (Vwindow_splits): Rewrite doc-string.
1354
1355 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1356
1357 * xfns.c (unwind_create_frame):
1358 * nsfns.m (unwind_create_frame):
1359 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1360 Vframe_list (Bug#9999).
1361
1362 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1365
1366 2011-11-11 Kenichi Handa <handa@m17n.org>
1367
1368 * callproc.c (Fcall_process): Set the member dst_multibyte of
1369 process_coding.
1370
1371 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1372
1373 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1374 avoid a crash (bug#9496).
1375
1376 2011-11-09 Chong Yidong <cyd@gnu.org>
1377
1378 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1379 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1380
1381 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1384
1385 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 Avoid some portability problems by eschewing 'extern inline' functions.
1388 The trivial performance wins aren't worth the portability hassles; see
1389 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1390 et seq.
1391 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1392 (window_box_width, window_box_left, window_box_left_offset)
1393 (window_box_right, window_box_right_offset): Undo previous change,
1394 by removing the "extern"s.
1395 * intervals.c (adjust_intervals_for_insertion)
1396 (adjust_intervals_for_deletion): Undo previous change,
1397 making these static again.
1398 (offset_intervals, temp_set_point_both, temp_set_point)
1399 (copy_intervals_to_string): No longer inline.
1400 * xdisp.c (window_text_bottom_y, window_box_width)
1401 (window_box_height, window_box_left_offset)
1402 (window_box_right_offset, window_box_left, window_box_right)
1403 (window_box): No longer inline.
1404
1405 2011-11-08 Chong Yidong <cyd@gnu.org>
1406
1407 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1408 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1409 Signal an error if not a live window.
1410 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1411 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1412
1413 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1414
1415 * lisp.h (syms_of_abbrev): Remove declaration.
1416 Reported by CHENG Gao <chenggao@royau.me>.
1417
1418 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1419
1420 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1421 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1422 of temacs in GUI mode.
1423
1424 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1425
1426 * window.h: Declare delete_all_child_windows instead of
1427 delete_all_subwindows.
1428 * window.c (Fwindow_nest, Fset_window_nest)
1429 (Fset_window_new_total, Fset_window_new_normal)
1430 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1431 (delete_all_subwindows): Rename to delete_all_child_windows.
1432 (Fdelete_other_windows_internal, Fset_window_configuration):
1433 Call delete_all_child_windows instead of delete_all_subwindows.
1434 * frame.c (delete_frame): Call delete_all_child_windows instead
1435 of delete_all_subwindows.
1436
1437 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1440 This is also needed for porting to any host where GC_MARK_STACK is
1441 not GC_MAKE_GCPROS_NOOPS.
1442 (which_symbols): Use it.
1443
1444 2011-11-07 Kenichi Handa <handa@m17n.org>
1445
1446 * coding.c (coding_set_destination): Check coding->src_pos only
1447 when coding->src_object is a buffer (bug#9910).
1448
1449 * process.c (send_process): Set the member src_multibyte of coding
1450 to 0 (bug#9911) when sending a unibyte text.
1451
1452 * callproc.c (Fcall_process): Set the member src_multibyte of
1453 process_coding to 0 (bug#9912).
1454
1455 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1456
1457 * xmenu.c (cleanup_widget_value_tree): New function.
1458 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1459 calling free_menubar_widget_value_tree directly (Bug#9830).
1460
1461 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 Fix some portability problems with 'inline'.
1464 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1465 (window_box_width, window_box_left, window_box_left_offset)
1466 (window_box_right, window_box_right_offset): Declare extern.
1467 Otherwise, these inline functions do not conform to C99 and
1468 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1469 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1470 * intervals.c (adjust_intervals_for_insertion)
1471 (adjust_intervals_for_deletion): Now extern, because otherwise the
1472 extern inline functions 'offset_intervals' couldn't refer to it.
1473 (static_offset_intervals): Remove.
1474 (offset_intervals): Rewrite using the old contents of
1475 static_offset_intervals. The old version didn't conform to C99
1476 because an extern inline function contained a reference to an
1477 identifier with static linkage.
1478
1479 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1482 GC.
1483
1484 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1485
1486 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1487 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1488 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1489 return Qleft_to_right.
1490
1491 2011-11-06 Chong Yidong <cyd@gnu.org>
1492
1493 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1494 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1495 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1496 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1497 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1498 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1499 (Fwindow_vscroll): Doc fix.
1500 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1501 argument, since it makes no sense to pass a live window and for
1502 consistency with window-child.
1503
1504 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1505
1506 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1507 support MSVC.
1508
1509 2011-11-05 Jason Rumney <jasonr@gnu.org>
1510
1511 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1512 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1513 fonts (Bug#6029).
1514 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1515 bitwise arithmetic preventing use of unicode-sip and non-truetype
1516 opentype fonts.
1517
1518 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1519
1520 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1521 "emacs"-only part.
1522
1523 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1524 initialization code to keep similarity to xfns.c after changes
1525 from 2011-11-05.
1526
1527 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1528
1529 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1530 (unwind_create_frame): New function (Bug#9943).
1531 (Fx_create_frame): Restructure code to be more similar to the one in
1532 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1533 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1534 Move terminal->reference_count++ just before making the frame official
1535 (Bug#9943).
1536
1537 * nsterm.m (x_free_frame_resources): New function.
1538 (x_destroy_window): Move code to x_free_frame_resources.
1539
1540 * xfns.c (unwind_create_frame): Fix comment.
1541 (Fx_create_frame, x_create_tip_frame):
1542 Move terminal->reference_count++ just before making the frame
1543 official. Move initialization of image_cache_refcount and
1544 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1545
1546 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1547
1548 Support MSVC build with newer versions of Visual Studio.
1549 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1550 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1551 nt/gmake.defs.
1552
1553 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1554 which are not supported by MSVC.
1555 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1556 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1557 bitfields.
1558 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1559 types in bitfields.
1560 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1561
1562 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1563
1564 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1565
1566 Support MSVC build with newer versions of Visual Studio.
1567 * w32.c: Don't include w32api.h for MSVC.
1568 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1569
1570 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1571 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1572 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1573 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1574 e_* cousins.
1575 (alloca) [_MSC_VER]: Define to _alloca.
1576
1577 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1578
1579 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1580
1581 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1582
1583 * xdisp.c (note_mouse_highlight): If either of
1584 previous/next-single-property-change returns nil, treat that as
1585 the beginning or the end of the buffer. (Bug#9955)
1586
1587 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1588
1589 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1590 label is not null (Bug#9951).
1591 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1592 may be NULL.
1593
1594 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1595
1596 * window.c (Fwindow_body_size): Mention in the doc string that the
1597 return value is in frame's canonical units. (Bug#9949)
1598
1599 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1602
1603 * w32fns.c (unwind_create_frame): If needed, free the glyph
1604 matrices of the partially constructed frame. (Bug#9943)
1605 * xfns.c (unwind_create_frame): Likewise.
1606
1607 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1610 Don't stop backward scan on the continuation glyph, even though
1611 its CHARPOS is positive.
1612 (mouse_face_from_buffer_pos, note_mouse_highlight):
1613 Rename cover_string to disp_string.
1614
1615 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1616
1617 * window.c (temp_output_buffer_show): Don't use
1618 Vtemp_buffer_show_specifiers.
1619 (Vtemp_buffer_show_specifiers): Remove unused variable.
1620
1621 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1624 past the beginning of the current glyph matrix.
1625
1626 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1627
1628 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1629 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1630 HAVE_GTK3 (Bug#9869).
1631
1632 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1633 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1634
1635 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1636
1637 * xterm.c: Declare x_handle_net_wm_state to return int.
1638 (handle_one_xevent): Check if we are iconified but don't have
1639 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1640 (get_current_wm_state): Return non-zero if not hidden,
1641 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1642 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1643 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1644 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1645
1646 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1649 so that this new function doesn't get optimized away by a
1650 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1651
1652 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1653
1654 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1655
1656 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1657
1658 Fix the `xbytecode' command.
1659 * .gdbinit (xprintbytestr): New command.
1660 (xwhichsymbols): Rename from `which'; all callers changed.
1661 (xbytecode): Print the byte-code string as well.
1662
1663 2011-10-29 Kim Storm <storm@cua.dk>
1664
1665 * alloc.c (which_symbols): New function.
1666
1667 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1668
1669 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1670 line. (Bug#9903)
1671
1672 2011-10-29 Glenn Morris <rgm@gnu.org>
1673
1674 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1675 Not clear what it was for, and it causes various bugs. (Bug#9839)
1676
1677 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1680 possible random value that matches one of those tested as
1681 condition to clear the mouse face.
1682
1683 2011-10-28 Chong Yidong <cyd@gnu.org>
1684
1685 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1686
1687 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1688
1689 * window.c (make_window): Initialize phys_cursor_on_p.
1690
1691 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1692
1693 * lisp.h (struct Lisp_Symbol): Update comments.
1694
1695 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1698
1699 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1700
1701 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1702 <oslsachem@gmail.com> for helping to debug this.
1703
1704 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1705 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1706 (g_b_init_get_glyph_outline_w): New static variables.
1707 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1708 (GetGlyphOutlineW_Proc): New typedefs.
1709 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1710 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1711 New functions.
1712 (w32font_open_internal, compute_metrics):
1713 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1714 instead of calling the "wide" APIs directly.
1715
1716 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1717
1718 * w32.h (syms_of_w32font): Add prototype.
1719
1720 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1721
1722 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1723 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1724 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1725 (Fmove_to_window_line): Doc fix.
1726
1727 2011-10-27 Chong Yidong <cyd@gnu.org>
1728
1729 * process.c (make_process): Set gnutls_state to NULL.
1730
1731 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1732 non-NULL, regardless of GNUTLS_INITSTAGE.
1733 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1734 an error. Set process slots as soon as we allocate them.
1735
1736 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1737
1738 2011-10-27 Chong Yidong <cyd@gnu.org>
1739
1740 * gnutls.c (emacs_gnutls_deinit): New function.
1741 Deallocate credentials structures as well as calling gnutls_deinit.
1742 (Fgnutls_deinit, Fgnutls_boot): Use it.
1743
1744 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1745 (deactivate_process): Call emacs_gnutls_deinit.
1746
1747 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * image.c (x_create_x_image_and_pixmap):
1750 * w32.c (sys_rename, w32_delayed_load):
1751 * w32font.c (fill_in_logfont):
1752 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1753
1754 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * w32fns.c (w32_default_color_map): New function,
1757 extracted from Fw32_default_color_map.
1758 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1759
1760 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1763
1764 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * keyboard.c (test_undefined): New function (bug#9751).
1767 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1768
1769 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1770
1771 * sysdep.c (init_sys_modes): Fix the check for the controlling
1772 terminal (Bug#6649).
1773
1774 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1775
1776 * dispextern.h (struct bidi_it): New member next_en_type.
1777
1778 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1779 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1780 current character, check also for next_en_type being WEAK_EN.
1781 (bidi_resolve_weak): Don't enter the expensive loop if the current
1782 position is before next_en_pos. Record the bidi type of the first
1783 non-ET, non-BN character we find, in addition to its position.
1784 (bidi_level_of_next_char): Invalidate next_en_type when
1785 next_en_pos is over-stepped.
1786
1787 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1790 * editfns.c: Rewrite current-time-zone so that it invokes
1791 the equivalent of (format-time-string "%Z") to get the time zone name.
1792 This fixes a bug when the time zone name contains characters that
1793 need converting from the system time locale to Emacs internal format.
1794 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1795 that patch fixed format-time-string to do the conversion, but
1796 I forgot to fix current-time-zone.
1797 (format_time_string): New function, containing most of
1798 what Fformat_time_string used to contain.
1799 (Fformat_time_string): Rewrite in terms of format_time_string.
1800 This doesn't change this function's behavior.
1801 (current-time-zone): Rewrite to use format_time_string.
1802 This fixes the bug reported by Michael Schierl in
1803 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1804 Jason Rumney's 2007-06-07 change worked around this bug, but
1805 didn't fix it.
1806 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1807
1808 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1809
1810 * xdisp.c (start_display): If the character at POS is displayed
1811 via a display vector, reset IT->current.dpvec_index to zero.
1812 (try_window_reusing_current_matrix): If a line ends in a display
1813 vector or the next line starts in a display vector, continue
1814 redrawing the window even though the character position of
1815 start_row was reached.
1816 (Bug#9771, part 2)
1817
1818 2011-10-18 Chong Yidong <cyd@gnu.org>
1819
1820 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1821 with nobreak-char-display too.
1822
1823 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1824
1825 Fix part 3 of bug#9771.
1826 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1827 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1828 non-neutral characters if the current character is a paragraph
1829 separator (a.k.a. Newline). This avoids running the same
1830 expensive loop twice, once when we consume the preceding newline
1831 and the other time when the line actually needs to be displayed.
1832 Avoid the loop when we see neutrals on the base embedding level
1833 following a character whose directionality is the same as the
1834 paragraph's. This avoids running the expensive loop when a line
1835 ends in a long sequence of neutrals, like control characters.
1836 Add assertion against STRONG_AL type. Slightly rearrange code
1837 that determines the type of a neutral given the first non-neutral
1838 that follows it.
1839 (bidi_level_of_next_char): Set next_en_pos to zero when
1840 invalidating its info.
1841
1842 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (push_display_prop): Determine whether to record string
1845 or buffer position by IT->string, not by IT->method. Allow
1846 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1847 (move_it_vertically_backward): Don't look for character position
1848 immediately after the newline when in a continuation line.
1849 (Bug#9771, part 1)
1850
1851 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1852
1853 * window.c (coordinates_in_window): Rewrite and delabelize
1854 vertical border check. (Bug#5357) (Bug#9618)
1855
1856 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1859 errors in XSetWindowBorder (bug#9310).
1860
1861 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1864 avoid crash when xmalloc overrun checking is enabled.
1865
1866 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1867
1868 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1869 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1870 cursor motion with <left> and <right> arrow keys.
1871
1872 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1873 some callers set that themselves.
1874
1875 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1876
1877 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1878 display string and the previous row comes from the same string and
1879 is empty. (Bug#9739) (Bug#9738)
1880
1881 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1882
1883 * doc.c (get_doc_string): Encode file name (bug#9735).
1884
1885 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1886
1887 * bidi.c (bidi_level_of_next_char):
1888 * xdisp.c (get_visually_first_element): Remove old incorrect
1889 comments regarding the Unicode Line Separator character.
1890
1891 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1892
1893 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1894
1895 * alloc.c (Fgc_status): Do not access beyond zombies array
1896 boundary if nzombies > MAX_ZOMBIES.
1897 * alloc.c (dump_zombies): Add missing format specifier.
1898
1899 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1902 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1903
1904 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1905 Some packages use them to denote characters with modifiers.
1906
1907 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1908
1909 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1910 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1911 matching a pp-number. Rename parameter var to var1.
1912
1913 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1914
1915 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1916
1917 2011-10-08 Glenn Morris <rgm@gnu.org>
1918
1919 * callint.c (Fcall_interactively): Give a more explicit error for the
1920 'c' case with a non-character input. (Bug#8479)
1921
1922 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1925 lines.
1926 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1927 lines that are hscrolled on the left.
1928
1929 * dispnew.c (buffer_posn_from_coords): Account for a possible
1930 presence of header-line. (Bug#4426)
1931
1932 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1933
1934 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1935 Don't advertise functionality which we discourage or doesn't work.
1936
1937 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1940 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1941 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1942 this makes Emacs dump core during garbage collection on rare
1943 occasions. sizeof is obviously inferior to offsetof here, so
1944 stick with offsetof.
1945 (GC_POINTER_ALIGNMENT): New macro.
1946 (mark_memory): Omit 3rd (offset) arg; caller changed.
1947 Don't assume EMACS_INT alignment is the same as pointer alignment.
1948
1949 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1950
1951 * keyboard.c (read_key_sequence_remapped): New var.
1952 (read_key_sequence): Compute remapping in the right buffer.
1953 (command_loop_1): Use read_key_sequence's remapping directly.
1954
1955 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1956
1957 * dired.c (file_name_completion): Don't expand file name.
1958 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1959 before checking file name handler.
1960
1961 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1962 they've been requested explicitly (bug#9591).
1963
1964 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1965
1966 * keymap.c (Fsingle_key_description): Use make_specified_string
1967 instead of build_string to build string from push_key_description.
1968 (Bug#5193)
1969
1970 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1973 This fixes a Y2038 bug on 64-bit hosts.
1974 * buffer.c (reset_buffer):
1975 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1976 (Fclear_buffer_auto_save_failure):
1977 Use 0, not -1, to represent an unset failure time, since time_t
1978 might not be signed.
1979
1980 Remove dependency on glibc malloc internals.
1981 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1982 Move back here from lisp.h, but with their new implementations.
1983 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1984 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1985 * charset.c (charset_table_init): New static var.
1986 (syms_of_charset): Use it instead of xmalloc. This removes a
1987 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1988 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1989 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1990 Move back to alloc.c.
1991 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1992 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1993
1994 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1995
1996 * nsterm.m (windowDidResize): Call x_set_window_size only when
1997 ns_in_resize is true. Otherwise set pixelwidth/height and
1998 call change_frame_size (Bug#9628).
1999
2000 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 Port --enable-checking=all to Fedora 14 x86-64.
2003 * charset.c (syms_of_charset): Also account for glibc malloc's
2004 internal overhead when calculating the initial malloc maximum.
2005
2006 Port --enable-checking=all to Fedora 14 x86.
2007 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2008 Move to lisp.h.
2009 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2010 (overrun_check_realloc, overrun_check_free):
2011 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2012 That way, xmalloc returns a properly-aligned pointer even if
2013 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2014 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2015 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2016 into account when calculating the initial malloc maximum.
2017 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2018 Move here from alloc.c, so that charset.c can use it too.
2019 Properly align; the old code wasn't right for common 32-bit hosts
2020 when configured with --enable-checking=all.
2021 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2022 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2023
2024 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2025
2026 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2027 use EDOM.
2028
2029 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2030
2031 * xdisp.c (compute_display_string_end): If there's no display
2032 string at CHARPOS, return -1.
2033
2034 * bidi.c (bidi_fetch_char): When compute_display_string_end
2035 returns a negative value, treat the character as a normal
2036 character not covered by a display string. (Bug#9624)
2037
2038 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2039
2040 * lread.c (Fread_from_string): Fix typo in docstring.
2041
2042 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2043
2044 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2045 newline, reseat the iterator instead of bidi-iterating there one
2046 character at a time. (Bug#9610)
2047 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2048 TO_CHARPOS if the bidi iterator is at base embedding level.
2049
2050 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2051
2052 * lread.c (readevalloop): Use correct code for NBSP.
2053 (read1): Likewise. (Bug#9608)
2054
2055 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2056
2057 * dbusbind.c (Fdbus_register_signal): When service is not
2058 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2059
2060 2011-09-25 Glenn Morris <rgm@gnu.org>
2061
2062 * buffer.c (truncate-lines): Doc fix.
2063
2064 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2065
2066 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2067 (Fset_window_next_buffers): Doc fix.
2068
2069 2011-09-24 Glenn Morris <rgm@gnu.org>
2070
2071 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2072
2073 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 Fix minor problems found by static checking.
2076 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2077 * indent.c (Fvertical_motion): Fix == vs = typo.
2078
2079 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2080
2081 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2082 Default value is now t. Doc fix.
2083
2084 * indent.c (Fvertical_motion): Compute and apply the overshoot
2085 logic when moving up, not only when moving down. Fix the
2086 confusing name and values of the it_overshoot_expected variable;
2087 logic changes accordingly. (Bug#9254) (Bug#9549)
2088
2089 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2090 CHARPOS is covered by a display string which includes newlines.
2091 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2092 is covered by a display string with embedded newlines.
2093
2094 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2095
2096 * dbusbind.c (Fdbus_register_signal): Add match rule to
2097 Vdbus_registered_objects_table. (Bug#9581)
2098 (Fdbus_register_method, Vdbus_registered_objects_table):
2099 Fix docstring.
2100
2101 2011-09-24 Jim Meyering <meyering@redhat.com>
2102
2103 do not ignore write error for any output size
2104 The previous change was incomplete.
2105 While it makes emacs --batch detect the vast majority of stdout
2106 write failures, errors were still ignored whenever the output size is
2107 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2108 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2109 && echo FAIL: ignored write error
2110 FAIL: ignored write error
2111 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2112 && echo FAIL: ignored write error
2113 FAIL: ignored write error
2114 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2115
2116 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2117
2118 * emacs.c (Fkill_emacs): In noninteractive mode exit
2119 non-successfully if a write error occurred on stdout. (Bug#9574)
2120
2121 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2122
2123 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2124 the xassert test.
2125
2126 * dispextern.h (struct it): Update the comment documenting what
2127 can it->OBJECT be.
2128
2129 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2130
2131 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2132 a display string, extend search for cursor position to end of row.
2133 (find_row_edges): If the row ends in a newline from a display
2134 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2135 Handle the case of a display string with multiple newlines.
2136 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2137 non-empty line. Fixes confusing cursor motion with arrow keys at
2138 the beginning of a line that starts with whitespace.
2139
2140 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2141
2142 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2143 (bug#9493).
2144
2145 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2146
2147 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2148 boolean (Bug#9154).
2149
2150 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2151
2152 * xdisp.c (display_line): Record maximum and minimum buffer
2153 positions even if no glyphs were produced (e.g., by a zero-width
2154 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2155 buffer positions that will be removed from the glyph row because
2156 they don't fit.
2157 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2158 column is beyond frame width: don't subtract 1 "pixel" when
2159 computing width of the stretch.
2160 (reseat_at_next_visible_line_start): Undo the change made on
2161 2011-09-17 that saved paragraph information and restored it after
2162 the call to `reseat'. (Bug#9545)
2163
2164 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2165
2166 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2167 and turn window cursor on if cleared (Bug#9415).
2168
2169 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2170
2171 * search.c (boyer_moore): Take unibyte characters from pattern
2172 literally. (Bug#9458)
2173
2174 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2175
2176 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2177
2178 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 Fix minor problem found by static checking.
2181 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2182 initialized, to pacify gcc -Wuninitialized.
2183
2184 * fileio.c: Report proper errno when syscall falls.
2185 (Finsert_file_contents): Save and restore errno,
2186 so that report_file_error outputs the correct diagnostic.
2187 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2188
2189 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2190
2191 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2192
2193 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2194
2195 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2196 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2197
2198 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2199
2200 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2201 about the current paragraph and restore it after the call to reseat.
2202
2203 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2204 (bidi_find_paragraph_start): Search back for paragraph beginning
2205 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2206 (bidi_move_to_visually_next): Only trigger paragraph-related
2207 computations when the last character is a newline or at EOB, not
2208 just any NEUTRAL_B. (Bug#9470)
2209
2210 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2211 truncated lines if point is covered by a display string. (Bug#9524)
2212
2213 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2216 (cons_to_x_long): New function.
2217 (lisp_data_to_selection_data): Use it. Correct the test for
2218 short-versus-long data; it was negated. Break out of vector
2219 loop, for efficiency, when a long datum is discovered.
2220
2221 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2222
2223 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2224
2225 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2226
2227 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2228 GCC PR/17406) by declaring this function with external scope.
2229
2230 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2233 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2234
2235 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2236
2237 * editfns.c (Fformat): Correctly handle text properties on "%%".
2238
2239 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2240
2241 * xterm.c (x_draw_composite_glyph_string_foreground):
2242 * w32term.c (x_draw_composite_glyph_string_foreground):
2243 * term.c (encode_terminal_code):
2244 * composite.c (composition_update_it, get_composition_id):
2245 * xdisp.c (get_next_display_element)
2246 (fill_composite_glyph_string): Add comments about special meaning
2247 of TAB characters in a composition.
2248
2249 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2252 This occurs when processing a multibyte format.
2253 Problem reported by Wolfgang Jenker.
2254
2255 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2256
2257 * xdisp.c (try_cursor_movement): Only check for exact match if
2258 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2259
2260 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 Remove unused external symbols.
2263 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2264 * xdisp.c (calc_pixel_width_or_height): Now static.
2265 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2266 * indent.c (check_display_width):
2267 * w32term.c: Fix comment to match code.
2268 * xterm.c, xterm.h (x_catching_errors): Remove.
2269
2270 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2271
2272 * xselect.c: Use signed conversions more consistently (Bug#9498).
2273 (selection_data_to_lisp_data): Assume incoming selection data are
2274 signed integers, not unsigned. This is to be consistent with
2275 outgoing selection data, which was modified to use signed integers
2276 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2277 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2278 expects long, not unsigned long.
2279
2280 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2281
2282 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2283 computation of loop end. Reported by Johan Bockgård
2284 <bojohan@gnu.org>.
2285
2286 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2287
2288 * frame.c (Fother_visible_frames_p): Function deleted.
2289
2290 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2291
2292 * indent.c (compute_motion): Process display vector front to back
2293 rather than the other way around. (Bug#2496)
2294
2295 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2296
2297 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2298
2299 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2300
2301 * minibuf.c (Fread_from_minibuffer): Doc fix.
2302
2303 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2304
2305 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2306 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2307
2308 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2309
2310 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2311 value for non-existent files.
2312
2313 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2314
2315 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2316 set its "size" to -1. This will set the modtime_size field of
2317 the corresponding buffer to -1, which is what
2318 verify-visited-file-modtime expects for files that do not exist.
2319 (Bug#9139)
2320
2321 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2324 here ...
2325 * lisp.h: ... from here. push_key_description is no longer
2326 defined in keyboard.c, so its declaration should not be in
2327 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2328 logically belongs with push_key_description.
2329
2330 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 * buffer.h: Include <sys/types.h> instead of <time.h>.
2333 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2334 Problem reported by Herbert J. Skuhra.
2335
2336 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2337
2338 * xml.c (parse_region): Make the parsing work for
2339 non-comment-starting XML files again (bug#9144).
2340
2341 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2342
2343 * image.c (gif_load): Fix calculation of bottom and right corner.
2344 (Bug#9468)
2345
2346 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2349 redisplay in small windows.
2350
2351 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2352
2353 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2354
2355 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2356
2357 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2358 Operate on live windows only.
2359
2360 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2363
2364 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2365
2366 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2367 only under bidi iteration.
2368
2369 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2370
2371 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2372
2373 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2376 Without this fix, the command to link temacs failed due to an
2377 undefined symbol __builtin_isnan. This is because
2378 /usr/include/iso/math_c99.h #defines isnan(x) to
2379 __builtin_isnan(x), but the bundled gcc, which identifies itself
2380 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2381 a __builtin_isnan.
2382 * floatfns.c (isnan): #undef, and then #define to a clone of
2383 what's in data.c.
2384 (Fisnan): Always define, since it's always available now.
2385 (syms_of_floatfns): Always define isnan at the Lisp level.
2386
2387 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2390
2391 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2394 The previous code assumed that file offsets (off_t values) fit in
2395 EMACS_INT variables, which is not true on typical 32-bit hosts.
2396 The code messed up by falsely reporting buffer overflow in cases
2397 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2398 when "big" contains more than 2**29 bytes, even though this
2399 inserts just one byte and does not overflow the buffer.
2400 (Finsert_file_contents): Store file offsets as off_t
2401 values, not as EMACS_INT values. Check for overflow when
2402 converting between EMACS_INT and off_t. When checking for
2403 buffer overflow or for overlap, take the offsets into account.
2404 Don't use EMACS_INT for small values where int suffices.
2405 When checking for overlap, fix a typo: ZV was used where
2406 ZV_BYTE was intended.
2407 (Fwrite_region): Don't assume off_t fits into 'long'.
2408 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2409
2410 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2411
2412 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2413
2414 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 sprintf-related integer and memory overflow issues (Bug#9412).
2417
2418 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2419 (esprintf, exprintf, evxprintf): New functions.
2420 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2421 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2422 (modify_event_symbol): Do not assume that the length of
2423 name_alist_or_stem is safe to alloca and fits in int.
2424 (Fexecute_extended_command): Likewise for function name and binding.
2425 (Frecursion_depth): Wrap around reliably on integer overflow.
2426 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2427 since some callers pass EMACS_INT values.
2428 (Fsingle_key_description): Don't crash if symbol name contains more
2429 than MAX_ALLOCA bytes.
2430 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2431 (get_minibuffer): Arg is now EMACS_INT, not int.
2432 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2433 (esprintf, exprintf, evxprintf): New decls.
2434 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2435
2436 * dbusbind.c (signature_cat): New function.
2437 (xd_signature, Fdbus_register_signal):
2438 Do not overrun buffer; instead, report string overflow.
2439
2440 * dispnew.c (add_window_display_history): Don't overrun buffer.
2441 Truncate instead; this is OK since it's just a log.
2442
2443 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2444 even if the time zone offset is outlandishly large.
2445 Don't mishandle offset == INT_MIN.
2446
2447 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2448 when creating daemon; the previous buffer-overflow check was incorrect.
2449
2450 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2451 which has the guts of the old verror function.
2452
2453 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2454 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2455
2456 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2457 (font_unparse_xlfd): Don't blindly alloca long strings.
2458 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2459 fits in int, when using sprintf. Use single snprintf to count
2460 length of string rather than counting it via multiple sprintfs;
2461 that's simpler and more reliable.
2462 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2463 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2464 sprintf, in case result does not fit in int.
2465
2466 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2467 (fontset_from_font): Print it.
2468
2469 * frame.c (tty_frame_count): Now printmax_t, not int.
2470 (make_terminal_frame, set_term_frame_name): Print it.
2471 (x_report_frame_params): In X, window IDs are unsigned long,
2472 not signed long, so print them as unsigned.
2473 (validate_x_resource_name): Check for implausibly long names,
2474 and don't assume name length fits in 'int'.
2475 (x_get_resource_string): Don't blindly alloca invocation name;
2476 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2477 not fit in int.
2478
2479 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2480 (xg_check_special_colors, xg_set_geometry):
2481 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2482
2483 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2484 Use esprintf, not sprintf, in case result does not fit in int.
2485
2486 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2487 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2488 it as a large positive number.
2489 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2490 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2491
2492 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2493 in case result does not fit in int.
2494
2495 * print.c (float_to_string): Detect width overflow more reliably.
2496 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2497 buffer overrun. Don't assume list length fits in 'int'. Treat
2498 print length of 0 as 0, not as infinity; to be consistent with other
2499 uses of print length in this function. Don't overflow print length
2500 index. Don't assume hash table size fits in 'long', or that
2501 vectorlike size fits in 'unsigned long'.
2502
2503 * process.c (make_process): Use printmax_t, not int, to format
2504 process-name gensyms.
2505
2506 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2507
2508 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2509 to avoid potential buffer overrun.
2510
2511 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2512 if X resource line is longer than 512 bytes.
2513
2514 * xfns.c (x_window): Make sprintf buffer a bit bigger
2515 to avoid potential buffer overrun.
2516
2517 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2518
2519 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2520
2521 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 Integer overflow fixes for scrolling, etc.
2524 Without these, Emacs silently mishandles large integers sometimes.
2525 For example, "C-u 4294967297 M-x recenter" was treated as if
2526 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2527
2528 * xdisp.c (try_window_id): Check Emacs fixnum range before
2529 converting to 'int'.
2530
2531 * window.c (window_scroll_line_based, Frecenter):
2532 Check that an Emacs fixnum is in range before assigning it to 'int'.
2533 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2534 values converted from Emacs fixnums.
2535 (Frecenter): Don't wrap around a line count if it is out of 'int'
2536 range; instead, treat it as an extreme value.
2537 (Fset_window_configuration, compare_window_configurations):
2538 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2539
2540 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2541 that can exceed INT_MAX. Check that EMACS_INT value is in range
2542 before assigning it to the (possibly-narrower) index.
2543 (match_limit): Don't assume that a fixnum can fit in 'int'.
2544
2545 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2546 exceed INT_MAX.
2547
2548 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2549 (Fvertical_motion): Don't wrap around LINES values that don't fit
2550 in 'int'. Instead, treat them as extreme values. This is good
2551 enough for windows, which can't have more than INT_MAX lines anyway.
2552
2553 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2554
2555 * Require libxml/parser.h to avoid compilation warning.
2556
2557 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2558
2559 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2560 since this reportedly can destroy thread storage.
2561
2562 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2563
2564 * syntax.c (find_defun_start): Update all cache variables if
2565 exiting early (Bug#9401).
2566
2567 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2568
2569 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2570
2571 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2572 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2573 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2574
2575 * term.c (tty_append_glyph): New function.
2576 (produce_stretch_glyph): Static function and its prototype deleted.
2577
2578 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2579 Add prototypes.
2580
2581 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2584 when checking :margin (Bug#9390).
2585 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2586 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2587 so that the name doesn't mislead. All uses changed.
2588
2589 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2590
2591 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2592 set_tty_hooks.
2593
2594 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2595
2596 * xdisp.c (move_it_to): Don't bail out early when reaching
2597 position beyond to_charpos, if we are scanning backwards.
2598 (move_it_vertically_backward): When DY == 0, make sure we get to
2599 the first character in the line after the newline.
2600
2601 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2604 (ccl_driver): Do not generate an out-of-range pointer.
2605 (Fccl_execute_on_string): Remove unnecessary check for
2606 integer overflow, noted by Stefan Monnier in
2607 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2608 Remove a FIXME that didn't need fixing.
2609 Simplify the newly-introduced buffer reallocation code.
2610
2611 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2614
2615 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 Integer and memory overflow issues (Bug#9196).
2618
2619 * doc.c (get_doc_string): Rework so that
2620 get_doc_string_buffer_size is the actual buffer size, rather than
2621 being 1 less than the actual buffer size; this makes xpalloc more
2622 convenient.
2623
2624 * image.c (x_allocate_bitmap_record, cache_image):
2625 * xselect.c (Fx_register_dnd_atom):
2626 Simplify previous changes by using xpalloc.
2627
2628 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2629 since either will do and ptrdiff_t is convenient with xpalloc.
2630
2631 * charset.c (charset_table_size)
2632 (struct charset_sort_data.priority): Now ptrdiff_t.
2633 (charset_compare): Don't overflow if priorities differ greatly.
2634 (Fsort_charsets): Don't assume list length fits in int.
2635 Check for size-calculation overflow when allocating sort data.
2636 (syms_of_charset): Allocate an initial charset table that is
2637 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2638
2639 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2640
2641 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2642 The actual value is always <= INT_MAX, and leaving it unsigned made
2643 overflow checking harder.
2644
2645 * dispextern.h (struct glyph_matrix.rows_allocated)
2646 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2647 with xpalloc. The values are still always <= INT_MAX.
2648
2649 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2650
2651 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2652 (SAFE_NALLOCA): New macro.
2653
2654 * region-cache.c (struct boundary.pos, find_cache_boundary)
2655 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2656 (set_cache_region, invalidate_region_cache)
2657 (revalidate_region_cache, know_region_cache, region_cache_forward)
2658 (region_cache_backward, pp_cache):
2659 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2660 so that ptrdiff_t * can be passed to xpalloc.
2661 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2662 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2663 (pp_cache): Don't assume cache_len fits in int.
2664 * region-cache.h: Adjust extern decls to match.
2665
2666 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2667 EMACS_INT, since either will do, for xpalloc.
2668
2669 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2670 (xnmalloc, xnrealloc, xpalloc): New functions.
2671
2672 * bidi.c (bidi_shelve_header_size): New constant.
2673 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2674 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2675
2676 * bidi.c (bidi_cache_shrink):
2677 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2678 (overlay_strings):
2679 Don't update size of array until after memory allocation succeeds,
2680 because xmalloc/xrealloc may not return.
2681 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2682 now that we have proper integer overflow checking.
2683 (record_overlay_string, overlay_strings): Catch overflows when
2684 calculating size of overlay_str_buf.
2685
2686 * callproc.c (Fcall_process): Check for size overflow when
2687 calculating size of args2.
2688 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2689 Normally we prefer signed values, but sticking with ptrdiff_t would
2690 require adding more-complicated checks.
2691
2692 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2693 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2694 Redo buffer-overflow calculations to avoid integer overflow.
2695 Add a FIXME comment where memory seems to be over-allocated.
2696
2697 * character.c (Fstring): Check for size-calculation overflow.
2698
2699 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2700 unnecessary integer overflow. Check for size overflow.
2701 (encode_coding_object): Don't update size until xmalloc succeeds.
2702
2703 * composite.c (get_composition_id): Check for overflow in glyph
2704 length calculations.
2705
2706 Integer and memory overflow fixes for display code.
2707 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2708 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2709 (scrolling_window): Check for overflow in size calculations.
2710 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2711 Don't assume glyph table len fits in int.
2712 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2713 (row_table_size): Now ptrdiff_t, not int.
2714 (scrolling_window): Avoid overflow in size calculations.
2715 Don't update size until allocation succeeds.
2716 * fns.c (concat): Check for overflow in size calculations.
2717 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2718 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2719 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2720
2721 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2722 (get_doc_string): Check for size calculation overflow.
2723 Don't update size until allocation succeeds.
2724 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2725 EMACS_INT, where ptrdiff_t will do.
2726 (Fsubstitute_command_keys): Check for string overflow.
2727
2728 * editfns.c (set_time_zone_rule): Don't assume environment length
2729 fits in int.
2730 (message_length): Now ptrdiff_t, not int.
2731 (Fmessage_box): Don't update size until allocation succeeds.
2732 Don't assume message length fits in int.
2733 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2734
2735 * emacs.c (main): Do not reallocate argv, since there is a null at
2736 the end that can be overwritten, and this way there's no need to
2737 worry about size-calculation overflow.
2738 (sort_args): Check for size-calculation overflow.
2739
2740 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2741 alloc succeeds.
2742 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2743
2744 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2745 (x_set_scroll_bar_width, x_figure_window_size):
2746 Check for integer overflow.
2747 (x_set_alpha): Do not assume XINT fits in int.
2748
2749 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2750 This is for the members text_lines, text_cols, total_lines, total_cols,
2751 where the system imposes an 'int' limit.
2752
2753 * fringe.c (Fdefine_fringe_bitmap):
2754 Don't update size until alloc works.
2755
2756 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2757 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2758
2759 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2760 Check for size-calculation overflow.
2761 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2762 do, as we prefer signed integers.
2763 (id_to_widget.max_size, id_to_widget.used)
2764 (xg_store_widget_in_map, xg_remove_widget_from_map)
2765 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2766 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2767 Use and return ptrdiff_t, not int.
2768 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2769 * gtkutil.h: Change prototypes to match the above.
2770
2771 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2772 are duplicate now that they've been promoted to lisp.h.
2773 (x_allocate_bitmap_record, x_alloc_image_color)
2774 (make_image_cache, cache_image, xpm_load):
2775 Don't update size until alloc is done.
2776 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2777 (x_detect_edges):
2778 Check for size calculation overflow.
2779 (ct_colors_allocated_max): New constant.
2780 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2781 overflow.
2782
2783 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2784 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2785 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2786 Use ptrdiff_t, not int, to count maps.
2787 (read_char_minibuf_menu_prompt): Check for overflow in size
2788 calculations. Don't update size until allocation succeeds.
2789 Redo calculations to avoid overflow.
2790 * keyboard.h: Change prototypes to match the above.
2791
2792 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2793 to count maps.
2794 (current_minor_maps): Check for size calculation overflow.
2795 * keymap.h: Change prototypes to match the above.
2796
2797 * lread.c (read1, init_obarray): Don't update size until alloc done.
2798
2799 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2800 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2801
2802 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2803 Now ptrdiff_t, not int.
2804 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2805 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2806
2807 * process.c (Fnetwork_interface_list): Check for overflow
2808 in size calculation.
2809
2810 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2811
2812 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2813 overflow. Don't bother calling xmalloc when xrealloc will do.
2814
2815 * search.c (Freplace_match): Check for size calculation overflow.
2816 (Fset_match_data): Don't assume list lengths fit in 'int'.
2817
2818 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2819 for command line length. Do not attempt to address one before the
2820 beginning of an array, as that's not portable.
2821
2822 * term.c (max_frame_lines): Remove; unused.
2823 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2824 not int.
2825 (encode_terminal_code, calculate_costs): Check for size
2826 calculation overflow.
2827 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2828 table lengths and related sizes. Don't update size until alloc
2829 done. Redo calculations to avoid overflow.
2830 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2831
2832 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2833 subtracting pointers.
2834 (gobble_line): Check for overflow more carefully. Don't update size
2835 until alloc done.
2836
2837 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2838 Don't update size until alloc done.
2839 Redo size calculations to avoid overflow.
2840 Check for size calculation overflow.
2841 (main) [DEBUG]: Fix typo in invoking tparam1.
2842
2843 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2844 Use ptrdiff_t, not int, for sizes.
2845 (store_mode_line_noprop_char): Don't update size until alloc done.
2846
2847 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2848 Use ptrdiff_t, not int, for sizes.
2849 (Finternal_make_lisp_face, cache_face):
2850 Check for size calculation overflow.
2851 (cache_face): Treat size calculation overflows as if they were
2852 memory exhaustion (the usual treatment), rather than aborting.
2853
2854 * xfns.c (x_encode_text, x_set_name_internal)
2855 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2856 sizes, since they can exceed INT_MAX in size. Check for size
2857 calculation overflow.
2858
2859 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2860 (xg_select): Check for size calculation overflow.
2861 Don't update size until alloc done.
2862
2863 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2864 as sprintf is limited to int lengths.
2865
2866 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2867 (X_LONG_MIN): New macros.
2868 Use them to make the following changes clearer.
2869 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2870 This change doesn't affect the value now, but it may help remind
2871 future maintainers not to raise the value too much later.
2872 (SELECTION_QUANTUM): Remove, replacing with ...
2873 (selection_quantum): ... new function, which avoids overflow.
2874 All uses changed.
2875 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2876 assumption that selection length fits in 'int'.
2877 (x_reply_selection_request, x_handle_selection_request)
2878 (x_get_window_property, receive_incremental_selection)
2879 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2880 (lisp_data_to_selection_data, clean_local_selection_data):
2881 Use ptrdiff_t, not int, to record length of selection.
2882 (x_reply_selection_request, x_get_window_property)
2883 (receive_incremental_selection, x_property_data_to_lisp):
2884 Redo calculations to avoid overflow.
2885 (x_reply_selection_request): When sending hint, ceiling it at
2886 X_LONG_MAX rather than relying on wraparound overflow to send
2887 something.
2888 (x_get_window_property, receive_incremental_selection)
2889 (lisp_data_to_selection_data, x_property_data_to_lisp):
2890 Check for size-calculation overflow.
2891 (x_get_window_property, receive_incremental_selection)
2892 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2893 Don't store size until memory allocation succeeds.
2894 (x_get_window_property): Plug memory leak on memory exhaustion.
2895 Don't double-block input; malloc is safe here. Don't assume 2**34
2896 - 4 fits in unsigned long. Add an xassert to check
2897 XGetWindowProperty overflow. Be more careful about overflow
2898 calculations, and distinguish size from memory overflow better.
2899 (receive_incremental_selection): When tracing, don't assume
2900 unsigned int is less than INT_MAX.
2901 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2902 harmful) conversions of unsigned short to int.
2903 (lisp_data_to_selection_data): Don't assume that integers
2904 in the range -65535 through -1 fit in an X unsigned short.
2905 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2906 result parameters unless successful. Rely on cons_to_unsigned
2907 to report problems with elements; the old code wasn't right anyway.
2908 (x_check_property_data): Check for int overflow; we cannot use
2909 a wider type due to X limits.
2910 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2911
2912 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2913
2914 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2915 (x_term_init): Check for size calculation overflow.
2916 (x_color_cells): Don't store size until memory allocation succeeds.
2917 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2918 Don't assume alloca size is less than MAX_ALLOCA.
2919 (x_term_init): Don't assume length fits in int (sprintf is limited
2920 to int size).
2921
2922 Use ptrdiff_t for composition IDs.
2923 * character.c (lisp_string_width):
2924 * composite.c (composition_table_size, n_compositions)
2925 (get_composition_id, composition_gstring_from_id):
2926 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2927 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2928 * window.c (Frecenter):
2929 Use ptrdiff_t, not int, for composition IDs.
2930 * composite.c (get_composition_id): Check for integer overflow.
2931 * composite.h: Adjust prototypes to match the above changes.
2932
2933 Use ptrdiff_t for hash table indexes.
2934 * category.c (hash_get_category_set):
2935 * ccl.c (ccl_driver):
2936 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2937 * coding.c (coding_system_charset_list, detect_coding_system):
2938 * coding.h (struct coding_system.id):
2939 * composite.c (get_composition_id, gstring_lookup_cache):
2940 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2941 * image.c (xpm_get_color_table_h):
2942 * lisp.h (hash_lookup, hash_put):
2943 * minibuf.c (Ftest_completion):
2944 Use ptrdiff_t for hash table indexes, not int (which is too
2945 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2946 32-bit --with-wide-int hosts).
2947
2948 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2949 Add a FIXME comment about memory leaks.
2950 (syms_of_charset): Don't assume xmalloc returns.
2951
2952 Don't assume that stated character widths fit in int.
2953 * character.c (Fchar_width, c_string_width, lisp_string_width):
2954 * character.h (CHAR_WIDTH):
2955 * indent.c (MULTIBYTE_BYTES_WIDTH):
2956 Use sanitize_char_width to avoid undefined and/or bad behavior
2957 with outlandish widths.
2958 * character.h (sanitize_tab_width): Rename from sanitize_width,
2959 now that we have two such functions. All uses changed.
2960 (sanitize_char_width): New inline function.
2961
2962 Don't assume that tab-width fits in int.
2963 * character.h (sanitize_width): New inline function.
2964 (SANE_TAB_WIDTH): New macro.
2965 (ASCII_CHAR_WIDTH): Use it.
2966 * indent.c (sane_tab_width): Remove. All uses replaced by
2967 SANE_TAB_WIDTH (current_buffer).
2968 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2969
2970 * fileio.c: Integer overflow issues with file modes.
2971 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2972
2973 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2974 Remove unreachable code.
2975 (read_hex, load_charset_map_from_file): Check for integer overflow.
2976
2977 * xterm.c: Don't go over XClientMessageEvent limit.
2978 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2979 (x_send_scroll_bar_event): Likewise. Check that the size does not
2980 exceed limits imposed by XClientMessageEvent, as well as the usual
2981 ptrdiff_t and size_t limits.
2982
2983 * keyboard.c: Overflow, signedness and related fixes.
2984 (make_lispy_movement): Use same integer type in forward decl
2985 that is used in the definition.
2986 (read_key_sequence, keyremap_step):
2987 Change bufsize argument back to int, undoing my 2011-03-30 change.
2988 We prefer signed types, and int is wide enough here.
2989 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2990 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2991 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2992 length, not size_t. Use ptrdiff_t for index, not int.
2993 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2994 possibility of integer overflow.
2995
2996 Overflow, signedness and related fixes for images.
2997
2998 * dispextern.h (struct it.stack[0].u.image.image_id)
2999 (struct_it.image_id, struct image.id, struct image_cache.size)
3000 (struct image_cache.used, struct image_cache.ref_count):
3001 * gtkutil.c (update_frame_tool_bar):
3002 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3003 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3004 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3005 * nsmenu.m (update_frame_tool_bar):
3006 * xdisp.c (calc_pixel_width_or_height):
3007 * xfns.c (image_cache_refcount):
3008 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3009 on typical 64-bit hosts.
3010
3011 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3012 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3013 Omit unnecessary casts to int.
3014 (parse_image_spec): Check that integers fall into 'int' range
3015 when the callers expect that.
3016 (image_ascent): Redo ascent calculation to avoid int overflow.
3017 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3018 (lookup_image): Remove unnecessary tests.
3019 (xbm_image_p): Locals are now of int, not EMACS_INT,
3020 since parse_image_check makes sure they fit into int.
3021 (png_load, gif_load, svg_load_image):
3022 Prefer int to unsigned where either will do.
3023 (tiff_handler): New function, combining the cores of the
3024 old tiff_error_handler and tiff_warning_handler.
3025 This function is rewritten to use vsnprintf and thereby avoid
3026 stack buffer overflows. It uses only the features of vsnprintf
3027 that are common to both POSIX and native Microsoft.
3028 (tiff_error_handler, tiff_warning_handler): Use it.
3029 (tiff_load, gif_load, imagemagick_load_image):
3030 Don't assume :index value fits in 'int'.
3031 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3032 (imagemagick_load_image): Check that crop parameters fit into
3033 the integer types that MagickCropImage accepts. Don't assume
3034 Vimagemagick_render_type has a nonnegative value. Don't assume
3035 size_t fits in 'long'.
3036 (gs_load): Use printmax_t to print the widest integers possible.
3037 Check for integer overflow when computing image height and width.
3038
3039 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3040
3041 * xdisp.c (redisplay_window): Don't force window start if point
3042 will be invisible in the resulting window. (Bug#9324)
3043
3044 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3045
3046 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3047 the display spec is of the form `(space ...)'.
3048 (handle_display_spec): Return the value returned by
3049 handle_single_display_spec, not just 1 or zero.
3050 (handle_single_display_spec): If the display spec is of the form
3051 `(space ...)', and specifies display in the text area, return 2
3052 rather than 1.
3053 (try_cursor_movement): Check for the need to scroll more
3054 accurately, and prefer exact match for point under bidi.
3055 Don't advance `row' beyond the last row of the window.
3056
3057 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3058 into disp_prop; all users changed.
3059
3060 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3061 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3062 for the text covered by the display property.
3063
3064 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3065
3066 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3067 Change return value to nil.
3068 (Frecord_buffer): Delete unused function.
3069
3070 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3073 buffers, return left-to-right.
3074 (set_cursor_from_row): Consider candidate row a win if its glyph
3075 represents a newline and point is on that newline. Fixes cursor
3076 positioning on the newline at EOL of R2L text within L2R
3077 paragraph, and vice versa.
3078 (try_cursor_movement): Check continued rows, in addition to
3079 continuation rows. Fixes unwarranted scroll when point enters a
3080 continued line of R2L text within an L2R paragraph, or vice versa.
3081 (cursor_row_p): Consider the case of point being equal to
3082 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3083 from the end of a short line to the beginning of a continued line
3084 of R2L text within L2R paragraph.
3085 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3086 composed characters.
3087
3088 * bidi.c (bidi_check_type): Use xassert.
3089 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3090 members.
3091
3092 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3093
3094 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3095 a character.
3096
3097 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3098
3099 * nsfont.m (ns_otf_to_script): Fix typo.
3100
3101 2011-08-22 Kenichi Handa <handa@m17n.org>
3102
3103 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3104 extra slot even if the purpose is char-code-property-table.
3105
3106 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3107
3108 * xdisp.c (redisplay_window): When computing centering_position,
3109 account for the height of the header line. (Bug#8874)
3110
3111 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3112 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3113 candidate is selected by the mouse, and that candidate has a
3114 composed character under the mouse.
3115
3116 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3117 coordinates reported by pos-visible-in-window-p for a composed
3118 character in column zero.
3119
3120 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3121
3122 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3123
3124 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3125
3126 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3127 consider it a hit if to_charpos is anywhere in the range of the
3128 composed buffer positions.
3129
3130 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3131
3132 * image.c (gif_load): Don't assume that each subimage has the same
3133 dimensions as the base image. Handle disposal method that is
3134 "undefined" by the gif spec (Bug#9335).
3135
3136 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3139 (Fcondition_case): Document `debug' symbol in error handler.
3140
3141 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3142
3143 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3144 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3145 from an Org mode buffer to a Speedbar frame.
3146
3147 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3148 a composition, take its buffer position from IT->cmp_it.charpos.
3149 Fixes cursor positioning at the beginning of a line that begins
3150 with a composed character.
3151
3152 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3153
3154 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3155 character bidirectional type, use STRONG_L instead. Fixes crashes
3156 in a buffer produced by `describe-categories'.
3157
3158 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3159 members before the level stack, so they would be saved and
3160 restored when copying iterator state. Fixes incorrect reordering
3161 around TABs covered by display properties.
3162
3163 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3164
3165 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3166
3167 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * eval.c (internal_condition_case, internal_condition_case_1)
3170 (internal_condition_case_2, internal_condition_case_n):
3171 Remove unnecessary aborts (Bug#9081).
3172
3173 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3174
3175 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3176 has no `load' handler, try opening the file locally. (Bug#9311)
3177
3178 2011-08-16 Ken Brown <kbrown@cornell.edu>
3179
3180 * gmalloc.c: Expand comment.
3181
3182 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3183
3184 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3185 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3186
3187 2011-08-16 Ken Brown <kbrown@cornell.edu>
3188
3189 Fix memory allocation problems in Cygwin build (Bug#9273).
3190
3191 * unexcw.c ( __malloc_initialized): Declare external variable.
3192 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3193
3194 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3195 New variables.
3196 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3197 dumped emacs.
3198 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3199 in the static heap.
3200 [CYGWIN] (special_realloc): New function.
3201 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3202 requests to realloc storage in the static heap.
3203
3204 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 * bidi.c (bidi_initialize): Remove unused local.
3207
3208 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3209
3210 * bidimirror.h:
3211 * biditype.h: Remove file.
3212 * makefile.w32-in ($(BLD)/bidi.$(O)):
3213 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3214
3215 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3216
3217 * chartab.c: Improve commentary for the uniprop_table API.
3218
3219 * bidi.c (bidi_paragraph_init): Support zero value of
3220 bidi_ignore_explicit_marks_for_paragraph_level.
3221 (bidi_initialize): Use uniprop_table instead of including
3222 biditype.h and bidimirror.h.
3223
3224 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3225 coordinates of the iterator when restoring from ppos_it.
3226 (Bug#9296)
3227
3228 2011-08-14 Kenichi Handa <handa@m17n.org>
3229
3230 * process.c (create_process): Call setup_process_coding_systems
3231 after the pid of the process is set to -1 (Bug#8162).
3232
3233 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (move_it_in_display_line_to): Don't invoke
3236 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3237 ppos_it. Fixes vertical cursor motion when line beginning is
3238 covered by an image. (Bug#9296)
3239
3240 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * nsterm.h (ns_run_ascript): Declare.
3243 (NSAPP_DATA2_RUNASSCRIPT): Define.
3244
3245 * nsfns.m (as_script, as_result, as_status): New static variables.
3246 (ns_run_ascript): New function.
3247 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3248 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3249 the event loop. Get status from as_status (Bug#7276).
3250
3251 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3252 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3253 the event loop (Bug#7276).
3254
3255 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3256
3257 * gnutls.c (QCgnutls_bootprop_priority)
3258 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3259 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3260 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3261 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3262 (QCgnutls_bootprop_verify_hostname_error)
3263 (QCgnutls_bootprop_callbacks_verify): Rename from
3264 Qgnutls_bootprop_..., all uses changed.
3265
3266 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3267 uses changed.
3268
3269 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3270
3271 * xfaces.c (Qframe_set_background_mode): Now static.
3272 * dispextern.h (Qframe_set_background_mode): Remove decl.
3273
3274 * process.c (Fnetwork_interface_info): Declare local only if needed.
3275
3276 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3277
3278 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3279 (Fnetwork_interface_list): Allocate in increments of bytes instead
3280 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3281 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3282 sockaddr.
3283 (struct ifflag_def): notrailers is smart on OSX.
3284 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3285 Get hardware address with getifaddrs if available.
3286
3287 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3288
3289 * xdisp.c (iterate_out_of_display_property): xassert that
3290 IT->position is set to within IT->object's boundaries. Break from
3291 the loop as soon as EOB is reached; avoids infloops in redisplay
3292 when IT->position is set up wrongly due to some bug.
3293 Set IT->current to match the bidi iterator unconditionally.
3294 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3295 entry. Force push_it to save on the stack the current
3296 buffer/string position, to be restored by pop_it. Fix flags in
3297 the iterator structure wrt the object coming from a display
3298 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3299 properties. (Bug#9284)
3300
3301 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3302
3303 * fontset.c (fontset_get_font_group): Add proper type checks.
3304 (Bug#9172)
3305
3306 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3307
3308 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3309 and LC_VERSION_MIN_MACOSX.
3310 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3311 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3312
3313 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (forward_to_next_line_start): Allow to use the
3316 no-display-properties-and-no-overlays under bidi display.
3317 Set disp_pos in the bidi iterator to avoid searches for display
3318 properties and overlays.
3319
3320 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3321
3322 * editfns.c (Fset_time_zone_rule): Document relationship with the
3323 setenv function.
3324
3325 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3326 the font entity extracted from the cache (Bug#8109).
3327
3328 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * composite.c (autocmp_chars): Don't reset point. That is done by
3331 restore_point_unwind (Bug#5984).
3332
3333 2011-08-07 Juri Linkov <juri@jurta.org>
3334
3335 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3336 to show the arg `TIME' instead of `TIMEVAL'.
3337
3338 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3339
3340 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3341 display property strides EOL and includes a newline, as in
3342 longlines-mode. (Bug#9254)
3343 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3344 word-wrap under bidirectional display. (Bug#9224)
3345
3346 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3347 is non-zero, even if the data buffer is NULL. Fixes a crash in
3348 vertical-motion with longlines-mode. (Bug#9254)
3349
3350 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3351
3352 * bidi.c <bidi_cache_total_alloc>: Now static.
3353 (bidi_initialize): Initialize bidi_cache_total_alloc.
3354
3355 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3356 cache. (Bug#9221)
3357
3358 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3359 amount allocated this far in `bidi_cache_total_alloc'.
3360 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3361 non-zero, only free the data buffer without restoring the cache
3362 contents. All callers changed.
3363
3364 * dispextern.h (bidi_unshelve_cache): Update prototype.
3365
3366 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3367 (move_it_in_display_line, move_it_to)
3368 (move_it_vertically_backward, move_it_by_lines): Replace the call
3369 to xfree to an equivalent call to bidi_unshelve_cache.
3370 (move_it_in_display_line_to): Fix logic of returning
3371 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3372
3373 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3374
3375 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3376 came from a string character with a `cursor' property. (Bug#9229)
3377
3378 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * Makefile.in (LIB_PTHREAD): New variable.
3381 (LIBES): Add LIB_PTHREAD (Bug#9216).
3382
3383 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3384 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3385
3386 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3387
3388 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3389
3390 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3391
3392 * xterm.c (x_find_topmost_parent): New function.
3393 (x_set_frame_alpha): Find topmost parent window with
3394 x_find_topmost_parent and set the property there also (bug#9181).
3395 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3396
3397 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3398
3399 * callproc.c (Fcall_process): Avoid vfork clobbering
3400 the local vars buffer, coding_systems, current_dir.
3401
3402 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3403
3404 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3405
3406 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3409 so that it is not optimized away.
3410
3411 * xdisp.c (compute_display_string_pos): Remove unused local.
3412
3413 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3414
3415 Fix slow cursor motion and scrolling in large buffers with
3416 selective display, like Org Mode buffers. (Bug#9218)
3417
3418 * dispextern.h (struct bidi_it): New member disp_prop_p.
3419
3420 * xdisp.c: Remove one-slot cache of display string positions.
3421 (compute_display_string_pos): Accept an additional argument
3422 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3423 for a display string or property. If found, set DISP_PROP_P
3424 non-zero.
3425
3426 * bidi.c (bidi_fetch_char): Accept an additional argument
3427 DISP_PROP_P, and pass it to compute_display_string_pos.
3428 Only handle text covered by a display string if DISP_PROP_P is returned
3429 non-zero. All callers of bidi_fetch_char changed.
3430
3431 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3434
3435 2010-12-03 Don March <don@ohspite.net>
3436
3437 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3438 last character M-[char] is translated to ESC [char] (bug#7541).
3439
3440 2011-08-02 Kenichi Handa <handa@m17n.org>
3441
3442 * lisp.h (uniprop_table): Extern it.
3443
3444 * chartab.c (uniprop_table): Make it non-static.
3445
3446 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xdisp.c (forward_to_next_line_start): Accept additional argument
3449 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3450 on the newline.
3451 (reseat_at_next_visible_line_start): Use the bidi iterator state
3452 returned by forward_to_next_line_start to restore the state of
3453 it->bidi_it after backing up to previous newline. (Bug#9212)
3454
3455 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3456
3457 * regex.c (re_comp): Protoize.
3458 (re_exec): Fix return type.
3459 (regexec): Fix type of `ret'. (Bug#9203)
3460
3461 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3464 This is needed if max-image-size is a floating-point number.
3465
3466 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * print.c (print_object): Print empty symbol as ##.
3469
3470 * lread.c (read1): Read ## as empty symbol.
3471
3472 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3473
3474 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3475 setting frame foreground color (Bug#9175).
3476 (x_set_background_color): Likewise.
3477
3478 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3479 contents (Bug#9176).
3480 (EmacsTooltip -init): Remove bezels and add shadows to
3481 tooltip windows.
3482
3483 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3484 or scroll bar (Bug#8470).
3485
3486 * nsfont.m (nsfont_open): Remove assignment to voffset and
3487 unnecessary vars hshink, expand, hd, full_height, min_height.
3488 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3489
3490 * nsterm.h (nsfont_info): Remove voffset field.
3491
3492 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3493
3494 Implement strike-through and overline on NextStep (Bug#8863).
3495
3496 * nsfont.m (nsfont_open): Use underline position provided by font,
3497 instead of hard-coded value of 2.
3498 (nsfont_draw): Call ns_draw_text_decoration instead.
3499
3500 * nsterm.h: Add declaration for ns_draw_text_decoration.
3501
3502 * nsterm.m (ns_draw_text_decoration): New function for drawing
3503 underline, overline, and strike-through.
3504 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3505 ns_draw_text_decoration. Change treatment of cursor drawing to
3506 accommodate underlining, etc.
3507
3508 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3509
3510 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3511 default.
3512
3513 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3516 Without this fix, if a signal arrives just after memory fills up,
3517 'malloc' might be invoked reentrantly.
3518
3519 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3520 In other words, assume that every image size is allowed, on non-X
3521 hosts. This assumption is probably wrong, but it lets Emacs compile.
3522
3523 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * regex.c (re_iswctype): Convert return values to boolean.
3526
3527 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3528
3529 * xdisp.c (compute_display_string_pos): Don't use cached display
3530 string position if the buffer had its restriction changed.
3531 (Bug#9184)
3532
3533 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3536
3537 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 Integer signedness and overflow and related fixes. (Bug#9079)
3540
3541 * bidi.c: Integer size and overflow fixes.
3542 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3543 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3544 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3545 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3546 (bidi_find_other_level_edge):
3547 Use ptrdiff_t instead of EMACS_INT where either will do.
3548 This works better on 32-bit hosts configured --with-wide-int.
3549 (bidi_cache_ensure_space): Check for size-calculation overflow.
3550 Use % rather than repeated addition, for better worst-case speed.
3551 Don't set bidi_cache_size until after xrealloc returns, because it
3552 might not return.
3553 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3554 (bidi_cache_ensure_space): Also check that the bidi cache size
3555 does not exceed that of the largest Lisp string or buffer. See Eli
3556 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3557
3558 * alloc.c (__malloc_size_t): Remove.
3559 All uses replaced by size_t. See Andreas Schwab's note
3560 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3561
3562 * image.c: Improve checking for integer overflow.
3563 (check_image_size): Assume that f is nonnull, since
3564 it is always nonnull in practice. This is one less thing to
3565 worry about when checking for integer overflow later.
3566 (x_check_image_size): New function, which checks for integer
3567 overflow issues inside X.
3568 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3569 This removes the need for a memory_full check.
3570 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3571 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3572 (xbm_read_bitmap_data): Change locals back to 'int', since
3573 their values must fit in 'int'.
3574 (xpm_load_image, png_load, tiff_load):
3575 Invoke x_create_x_image_and_pixmap earlier,
3576 to avoid much needless work if the image is too large.
3577 (tiff_load): Treat overly large images as if
3578 x_create_x_image_and_pixmap failed, not as malloc failures.
3579 (gs_load): Use x_check_image_size.
3580
3581 * gtkutil.c: Omit integer casts.
3582 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3583 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3584
3585 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3586
3587 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3588 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3589 would wrongly return t on a 64-bit host.
3590
3591 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3592 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3593 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3594 and therefore cause GCC to emit a bogus diagnostic in some cases.
3595
3596 * image.c: Integer signedness and overflow and related fixes.
3597 This is not an exhaustive set of fixes, but it's time to
3598 record what I've got.
3599 (lookup_pixel_color, check_image_size): Remove redundant decls.
3600 (check_image_size): Don't assume that arbitrary EMACS_INT values
3601 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3602 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3603 (tiff_load, imagemagick_load_image):
3604 Check for overflow in size calculations.
3605 (x_create_x_image_and_pixmap): Remove unnecessary test for
3606 xmalloc returning NULL; that can't happen.
3607 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3608 (xpm_color_bucket): Use better integer hashing function.
3609 (xpm_cache_color): Don't possibly over-allocate memory.
3610 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3611 (gif_memory_source):
3612 Use ptrdiff_t, not int or size_t, to record sizes.
3613 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3614 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3615 either works, as we prefer signed integers.
3616 (tiff_read_from_memory, tiff_write_from_memory):
3617 Return tsize_t, not size_t, since that's what the TIFF API wants.
3618 (tiff_read_from_memory): Don't fail simply because the read would
3619 go past EOF; instead, return a short read.
3620 (tiff_load): Omit no-longer-needed casts.
3621 (Fimagemagick_types): Don't assume size fits into 'int'.
3622
3623 Improve hashing quality when configured --with-wide-int.
3624 * fns.c (hash_string): New function, taken from sxhash_string.
3625 Do not discard information about ASCII character case; this
3626 discarding is no longer needed.
3627 (sxhash-string): Use it. Change sig to match it. Caller changed.
3628 * lisp.h: Declare it.
3629 * lread.c (hash_string): Remove, since we now use fns.c's version.
3630 The fns.c version returns a wider integer if --with-wide-int is
3631 specified, so this should help the quality of the hashing a bit.
3632
3633 * emacs.c: Integer overflow minor fix.
3634 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3635 Define only if GNU_LINUX.
3636 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3637
3638 * dispnew.c: Integer signedness and overflow fixes.
3639 Remove unnecessary forward decls, that were a maintenance hassle.
3640 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3641 All uses changed.
3642 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3643 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3644 (prepare_desired_row, line_draw_cost):
3645 Use int, not unsigned, where either works.
3646 (save_current_matrix, restore_current_matrix):
3647 Use ptrdiff_t, not size_t, where either works.
3648 (init_display): Check for overflow more accurately, and without
3649 relying on undefined behavior.
3650
3651 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3652 Remove, replacing with the new symbols in lisp.h. All uses changed.
3653 * fileio.c (make_temp_name):
3654 * filelock.c (lock_file_1, lock_file):
3655 * xdisp.c (message_dolog):
3656 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3657 Use pMd etc. instead.
3658 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3659 replacing the pWIDE etc. symbols removed from editfns.c.
3660
3661 * keyboard.h (num_input_events): Now uintmax_t.
3662 This is (very slightly) less likely to mess up due to wraparound.
3663 All uses changed.
3664
3665 * buffer.c: Integer signedness fixes.
3666 (alloc_buffer_text, enlarge_buffer_text):
3667 Use ptrdiff_t rather than size_t when either will do, as we prefer
3668 signed integers.
3669
3670 * alloc.c: Integer signedness and overflow fixes.
3671 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3672 (__malloc_size_t): Default to size_t, not to int.
3673 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3674 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3675 Prefer ptrdiff_t to size_t when either would do, as we prefer
3676 signed integers.
3677 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3678 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3679 Now const. Initialize with values that are in range even if char
3680 is signed.
3681 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3682 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3683 These functions do the right thing with sizes > 2**32.
3684 (check_depth): Now ptrdiff_t, not int.
3685 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3686 Adjust to new way of storing sizes. Check for size overflow bugs
3687 in rest of code.
3688 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3689 slightly wrong anyway, as it missed one instance of
3690 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3691 (refill_memory_reserve): Omit needless cast to size_t.
3692 (mark_object_loop_halt): Mark as externally visible.
3693
3694 * xselect.c: Integer signedness and overflow fixes.
3695 (Fx_register_dnd_atom, x_handle_dnd_message):
3696 Use ptrdiff_t, not size_t, since we prefer signed.
3697 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3698 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3699 x_dnd_atoms_size and x_dnd_atoms_length.
3700
3701 * doprnt.c: Prefer signed to unsigned when either works.
3702 * eval.c (verror):
3703 * doprnt.c (doprnt):
3704 * lisp.h (doprnt):
3705 * xdisp.c (vmessage):
3706 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3707 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3708 prefer signed arithmetic to avoid comparison confusion.
3709 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3710 but is a bit tricky.
3711
3712 Assume freestanding C89 headers, string.h, stdlib.h.
3713 * data.c, doprnt.c, floatfns.c, print.c:
3714 Include float.h unconditionally.
3715 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3716 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3717 * regex.c: Likewise for stddef.h, string.h.
3718 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3719 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3720 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3721 (STDC_HEADERS): Remove obsolete defines.
3722 * sysdep.c: Include limits.h unconditionally.
3723
3724 Assume support for memcmp, memcpy, memmove, memset.
3725 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3726 * regex.c (memcmp, memcpy):
3727 Remove; we assume C89 now.
3728
3729 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3730 (__malloc_safe_bcopy): Remove; no longer needed.
3731
3732 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3733 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3734 well either way, and we prefer signed to unsigned.
3735
3736 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3737
3738 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3739 closes the connection while we're reading (bug#9182).
3740
3741 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3742
3743 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3744 are specified (Bug#9168).
3745
3746 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3749 Found by GCC static checking and --with-wide-int on a 32-bit host.
3750
3751 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3752
3753 * xdisp.c (compute_display_string_pos): Fix logic of caching
3754 previous display string position. Initialize cached_prev_pos to
3755 -1. Fixes slow-down at the beginning of a buffer.
3756
3757 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3760 for attrs[LFACE_FONTSET_INDEX].
3761
3762 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 * xml.c (parse_region): Remove unused local
3765 that was recently introduced.
3766
3767 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3768
3769 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3770 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3771
3772 * xdisp.c (move_it_in_display_line_to): Record the best matching
3773 position for TO_CHARPOS while scanning the line, and restore it on
3774 exit if none of the characters scanned was an exact match.
3775 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3776 when exact match is impossible due to invisible text, and the
3777 lines are truncated.
3778
3779 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3780
3781 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3782 for OSX >= 10.7.
3783
3784 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3785
3786 Fix a significant slow-down of cursor motion with C-n, C-p,
3787 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3788 auto-repeat under bidi redisplay in fontified buffers.
3789 * xdisp.c (compute_stop_pos_backwards): New function.
3790 (next_element_from_buffer): Call compute_stop_pos_backwards to
3791 find a suitable prev_stop when we find ourselves before
3792 base_level_stop.
3793 (reseat): Don't look for prev_stop, as that could mean a very long
3794 run.
3795 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3796 <cached_disp_overlay_modiff>: Cache for last found display string
3797 position.
3798 (compute_display_string_pos): Return the cached position if asked
3799 about the same buffer in the same area of character positions, and
3800 the buffer wasn't changed since the time the display string
3801 position was cached.
3802
3803 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3804
3805 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3806 is an integer, which is important for empty lines. (Bug#9149)
3807
3808 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3809
3810 * frame.c (Fmodify_frame_parameters): In tty case, update the
3811 default face if necessary (Bug#4238).
3812
3813 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3814
3815 * editfns.c (Fstring_to_char): No need to explain what a character
3816 is in the docstring (Bug#6576).
3817
3818 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3819
3820 * xml.c (parse_region): Make sure we always return a tree.
3821
3822 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3823
3824 * xml.c (parse_region): If a document contains only comments,
3825 return that, too.
3826
3827 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828
3829 * xml.c (make_dom): Return comments, too.
3830
3831 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 Port to OpenBSD.
3834 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3835 and the surrounding thread.
3836 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3837 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3838 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3839 timer goes off.
3840 * s/openbsd.h (BROKEN_SIGIO): Define.
3841 * unexelf.c (unexec) [__OpenBSD__]:
3842 Don't update the .mdebug section of the Alpha COFF symbol table.
3843
3844 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3845
3846 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3847 (bug#8460).
3848
3849 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3852 This fixes some race conditions on the permissions of any newly
3853 created file.
3854
3855 * alloc.c (valid_pointer_p): Use pipe, not open.
3856 This fixes some permissions issues when debugging.
3857
3858 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3859 If fchown fails to set both uid and gid, try to set just gid,
3860 as that is sometimes allowed. Adjust the file's mode to eliminate
3861 setuid or setgid bits that are inappropriate if fchown fails.
3862
3863 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3864
3865 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3866 to compare Lisp_Objects.
3867 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3868 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3869 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3870
3871 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3872
3873 * lread.c (read_integer): Unread even EOF character.
3874 (read1): Likewise. Properly record start position of symbol.
3875
3876 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3877 symbol character follows.
3878
3879 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3882 This works around a problem with the previous change to Fcopy_file.
3883 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3884 and without this change, GCC might complain about discarding
3885 fchown's return value.
3886
3887 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3888
3889 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3890
3891 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3894
3895 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3896
3897 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3898 it's used from the C level.
3899
3900 * process.c: Use the same condition for POLL_FOR_INPUT in both
3901 keyboard.c and process.c (bug#1858).
3902
3903 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3904
3905 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3906 (Fgnutls_boot): Use it.
3907
3908 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3909
3910 * doc.c (Fsubstitute_command_keys): Revert last change.
3911
3912 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3913
3914 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3915 quotes the next character, and doesn't affect other longer
3916 sequences (bug#8935).
3917
3918 * lread.c (syms_of_lread): Clarify that is isn't only
3919 `eval-buffer' and `eval-defun' that's affected by
3920 `lexical-binding' (bug#8460).
3921
3922 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3923
3924 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3925 bidi redisplay when a line includes both an image and is truncated.
3926
3927 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 Fix minor problems found by static checking.
3930 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3931 (elsz): Now a signed constant, not a size_t var. We prefer signed
3932 types to unsigned, to avoid integer comparison confusion. Without
3933 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3934 "cannot optimize loop, the loop counter may overflow", a symptom
3935 of the confusion.
3936 * indent.c (Fvertical_motion): Mark locals as initialized.
3937 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3938
3939 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3940
3941 * search.c (Fre_search_backward): Mention `case-fold-search' in
3942 all the re_search_* functions (bug#8138).
3943
3944 * keyboard.c (Fopen_dribble_file): Document when the file is
3945 closed (bug#8056).
3946
3947 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3948
3949 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3950 bidi_cache_idx.
3951
3952 Support bidi reordering of display and overlay strings.
3953 * xdisp.c (compute_display_string_pos)
3954 (compute_display_string_end): Accept additional argument STRING.
3955 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3956 (reseat_to_string): Initialize bidi_it->string.s and
3957 bidi_it->string.schars.
3958 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3959 NULL (avoids a crash in bidi_paragraph_init).
3960 Initialize itb.string.lstring.
3961 (init_iterator): Call bidi_init_it only of a valid
3962 buffer position was specified. Initialize paragraph_embedding to
3963 L2R.
3964 (reseat_to_string): Initialize the bidi iterator.
3965 (display_string): If we need to ignore text properties of
3966 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3967 original value of -1 will not work with bidi.)
3968 (compute_display_string_pos): First arg is now struct
3969 `text_pos *'; all callers changed. Support display properties on
3970 Lisp strings.
3971 (compute_display_string_end): Support display properties on Lisp
3972 strings.
3973 (init_iterator, reseat_1, reseat_to_string): Initialize the
3974 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3975 when iterating on a string not from display properties).
3976 (compute_display_string_pos, compute_display_string_end):
3977 Fix calculation of the object to scan. Fixes an error when using
3978 arrow keys.
3979 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3980 base_level_stop; instead, set base_level_stop to BEGV.
3981 Fixes crashes in vertical-motion.
3982 (next_element_from_buffer): Improve commentary for when
3983 the iterator is before prev_stop.
3984 (init_iterator): Initialize bidi_p from the default value of
3985 bidi-display-reordering, not from buffer-local value. Use the
3986 buffer-local value only if initializing for buffer iteration.
3987 (handle_invisible_prop): Support invisible properties on strings
3988 that are being bidi-reordered.
3989 (set_iterator_to_next): Support bidi reordering of C strings and
3990 Lisp strings.
3991 (next_element_from_string): Support bidi reordering of Lisp
3992 strings.
3993 (handle_stop_backwards): Support Lisp strings as well.
3994 (display_string): Support display of R2L glyph rows.
3995 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3996 (init_iterator): Don't initialize it->bidi_p for strings
3997 here.
3998 (reseat_to_string): Initialize it->bidi_p for strings here.
3999 (next_element_from_string, next_element_from_c_string)
4000 (next_element_from_buffer): Add xassert's for correspondence
4001 between IT's object being iterated and it->bidi_it.string
4002 structure.
4003 (face_before_or_after_it_pos): Support bidi iteration.
4004 (next_element_from_c_string): Handle the case of the first string
4005 character that is not the first one in the visual order.
4006 (get_visually_first_element): New function, refactored from common
4007 parts of next_element_from_buffer, next_element_from_string, and
4008 next_element_from_c_string.
4009 (tool_bar_lines_needed, redisplay_tool_bar)
4010 (display_menu_bar): Force left-to-right direction. Add a FIXME
4011 comment for making that be controlled by a user option.
4012 (push_it, pop_it): Save and restore the state of the
4013 bidi iterator. Save and restore the bidi_p flag.
4014 (pop_it): Iterate out of display property for string iteration as
4015 well.
4016 (iterate_out_of_display_property): Support iteration over strings.
4017 (handle_single_display_spec): Set up it->bidi_it for iteration
4018 over a display string, and call bidi_init_it.
4019 (handle_single_display_spec, next_overlay_string)
4020 (get_overlay_strings_1, push_display_prop): Set up the bidi
4021 iterator for displaying display or overlay strings.
4022 (forward_to_next_line_start): Don't use the shortcut if
4023 bidi-iterating.
4024 (back_to_previous_visible_line_start): If handle_display_prop
4025 pushed the iterator stack, restore the internal state of the bidi
4026 iterator by calling bidi_pop_it same number of times.
4027 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4028 and we are bidi-iterating, don't decrement the iterator position;
4029 instead, set the first_elt flag in the bidi iterator, to produce
4030 the same effect.
4031 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4032 (push_display_prop): xassert that we are iterating a buffer.
4033 (push_it, pop_it): Save and restore paragraph_embedding member.
4034 (handle_single_display_spec, next_overlay_string)
4035 (get_overlay_strings_1, reseat_1, reseat_to_string)
4036 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4037 correctly. Don't assume unibyte strings are not bidi-reordered.
4038 (compute_display_string_pos)
4039 (compute_display_string_end): Fix handling the case of C string.
4040 (push_it, pop_it): Save and restore from_disp_prop_p.
4041 (handle_single_display_spec, push_display_prop): Set the
4042 from_disp_prop_p flag.
4043 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4044 (pop_it): Call iterate_out_of_display_property only if we are
4045 popping after iteration over a string that came from a display
4046 property. Fix a typo in popping stretch info. Add an assertion
4047 for verifying that the iterator position is in sync with the bidi
4048 iterator.
4049 (handle_single_display_spec, get_overlay_strings_1)
4050 (push_display_prop): Fix initialization of paragraph direction for
4051 string when that of the parent object is not yet determined.
4052 (reseat_1): Call bidi_init_it to resync the bidi
4053 iterator with IT's position. (Bug#7616)
4054 (find_row_edges): If ROW->start.pos gives position
4055 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4056 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4057 Reset the from_disp_prop_p flag.
4058 (SAVE_IT, RESTORE_IT): New macros.
4059 (pos_visible_p, face_before_or_after_it_pos)
4060 (back_to_previous_visible_line_start)
4061 (move_it_in_display_line_to, move_it_in_display_line)
4062 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4063 (try_scrolling, redisplay_window, display_line): Use them when
4064 saving a temporary copy of the iterator and restoring it back.
4065 (back_to_previous_visible_line_start, reseat_1)
4066 (init_iterator): Empty the bidi cache "stack".
4067 (move_it_in_display_line_to): If iterator ended up at
4068 EOL, but we never saw any buffer positions smaller than
4069 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4070 motion in bidi-reordered lines.
4071 (move_it_in_display_line_to): Record prev_method and prev_pos
4072 immediately before the call to set_iterator_to_next. Fixes cursor
4073 motion in bidi-reordered lines with stretch glyphs and strings
4074 displayed in margins. (Bug#8133) (Bug#8867)
4075 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4076 TO_CHARPOS.
4077 (pos_visible_p): Support positions in bidi-reordered lines.
4078 Save and restore bidi cache.
4079
4080 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4081 (bidi_paragraph_info): Delete unused struct.
4082 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4083 (bidi_cache_start): New variable.
4084 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4085 to zero.
4086 (bidi_cache_fetch_state, bidi_cache_search)
4087 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4088 (bidi_cache_find, bidi_peek_at_next_level)
4089 (bidi_level_of_next_char, bidi_find_other_level_edge)
4090 (bidi_move_to_visually_next): Compare cache index with
4091 bidi_cache_start rather than with zero.
4092 (bidi_fetch_char): Accept new argument STRING; all callers
4093 changed. Support iteration over a string. Support strings with
4094 display properties. Support unibyte strings. Fix the type of
4095 `len' according to what STRING_CHAR_AND_LENGTH expects.
4096 (bidi_paragraph_init, bidi_resolve_explicit_1)
4097 (bidi_resolve_explicit, bidi_resolve_weak)
4098 (bidi_level_of_next_char, bidi_move_to_visually_next):
4099 Support iteration over a string.
4100 (bidi_set_sor_type, bidi_resolve_explicit_1)
4101 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4102 can now be zero (for strings); special values 0 and -1 were
4103 changed to -1 and -2, respectively.
4104 (bidi_char_at_pos): New function.
4105 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4106 Call it instead of FETCH_MULTIBYTE_CHAR.
4107 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4108 initialized to valid values.
4109 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4110 values.
4111 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4112 the test for valid cached positions. Fix the logic for looking up
4113 the sentinel state in the cache. GCPRO the Lisp string we are
4114 iterating.
4115 (bidi_push_it, bidi_pop_it): New functions.
4116 (bidi_initialize): Initialize the bidi cache start stack pointer.
4117 (bidi_cache_ensure_space): New function, refactored from part of
4118 bidi_cache_iterator_state. Don't assume the required size is just
4119 one BIDI_CACHE_CHUNK away.
4120 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4121 (bidi_count_bytes, bidi_char_at_pos): New functions.
4122 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4123 always valid if bidi_cache_idx is valid.
4124 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4125 is valid if it's going to be used.
4126 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4127 (bidi_cache_fetch_state, bidi_cache_search)
4128 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4129 (bidi_cache_iterator_state, bidi_cache_find)
4130 (bidi_find_other_level_edge, bidi_cache_start_stack):
4131 All variables related to cache indices are now EMACS_INT.
4132
4133 * dispextern.h (struct bidi_string_data): New structure.
4134 (struct bidi_it): New member `string'. Make flag members be 1-bit
4135 fields, and put them last in the struct.
4136 (compute_display_string_pos, compute_display_string_end):
4137 Update prototypes.
4138 (bidi_push_it, bidi_pop_it): Add prototypes.
4139 (struct iterator_stack_entry): New members bidi_p,
4140 paragraph_embedding, and from_disp_prop_p.
4141 (struct it): Member bidi_p is now a bit field 1 bit wide.
4142 (bidi_shelve_cache, bidi_unshelve_cache):
4143 Declare prototypes.
4144
4145 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4146 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4147 and vector-like objects.
4148
4149 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4150 cache around display iteration.
4151
4152 * window.c (Fwindow_end, window_scroll_pixel_based)
4153 (displayed_window_lines, Frecenter): Save and restore the bidi
4154 cache around display iteration.
4155
4156 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
4158 * editfns.c (Fdelete_region): Clarify the use of the named
4159 parameters (bug#6788).
4160
4161 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4162
4163 * indent.c (Fvertical_motion): Set and restore w->pointm when
4164 saving and restoring the window's buffer (Bug#9006).
4165
4166 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167
4168 * editfns.c (Fstring_to_char): Clarify just what is returned
4169 (bug#6576). Text by Eli Zaretskii.
4170
4171 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4174
4175 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4176
4177 * buffer.c (mmap_find): Fix a typo.
4178
4179 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4180
4181 Fix execution of x selection hooks.
4182 * xselect.c (Qx_lost_selection_functions)
4183 (Qx_sent_selection_functions): New vars.
4184 (syms_of_xselect): DEFSYM them.
4185 (x_handle_selection_request): Pass Qx_sent_selection_functions
4186 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4187 (x_handle_selection_clear,x_clear_frame_selections):
4188 Pass Qx_lost_selection_functions rather than
4189 Vx_lost_selection_functions to Frun_hook_with_args.
4190
4191 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4194 The old code sometimes used this field without initializing it.
4195
4196 * alloc.c (gc_sweep): Don't read past end of array.
4197 In theory, the old code could also have corrupted Emacs internals,
4198 though it'd be very unlikely.
4199
4200 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4201
4202 * character.c (Fcharacterp): Don't advertise optional ignored
4203 argument. (Bug#4026)
4204
4205 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4206
4207 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4208 key" (bug#4257).
4209
4210 * window.c (Fset_window_start): Doc fix (bug#4199).
4211 (Fset_window_hscroll): Ditto.
4212
4213 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4214
4215 Fix minor new problems caught by GCC 4.6.1.
4216 * term.c (init_tty): Remove unused local.
4217 * xsettings.c (store_monospaced_changed): Define this function only
4218 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4219 not used otherwise.
4220
4221 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4222
4223 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4224
4225 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4226
4227 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4228 are the mini-buffer and the echo area (bug#3320).
4229
4230 * term.c (init_tty): Remove support for supdup, c10 and perq
4231 terminals, which are no longer supported (bug#1482).
4232
4233 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4234
4235 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4236
4237 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4238
4239 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4240 for non-popups (Bug#3642).
4241
4242 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4243
4244 * alloc.c (reset_malloc_hooks): Protoize.
4245 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4246 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4247 * cm.c (losecursor): Likewise.
4248 * data.c (fmod): Likewise.
4249 * dispnew.c (swap_glyphs_in_rows): Likewise.
4250 * emacs.c (memory_warning_signal): Likewise.
4251 * floatfns.c (float_error): Likewise.
4252 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4253 (otf_open, font_otf_capability, generate_otf_features)
4254 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4255 Likewise.
4256 * image.c (pbm_read_file): Likewise.
4257 * indent.c (string_display_width): Likewise.
4258 * intervals.c (check_for_interval, search_for_interval)
4259 (inc_interval_count, count_intervals, root_interval)
4260 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4261 * lread.c (defalias): Likewise.
4262 * ralloc.c (r_alloc_check): Likewise.
4263 * regex.c (set_image_of_range_1, set_image_of_range)
4264 (regex_grow_registers): Likewise.
4265 * sysdep.c (strerror): Likewise.
4266 * termcap.c (valid_filename_p, tprint, main): Likewise.
4267 * tparam.c (main): Likewise.
4268 * unexhp9k800.c (run_time_remap, save_data_space)
4269 (update_file_ptrs, read_header, write_header, calculate_checksum)
4270 (copy_file, copy_rest, display_header): Likewise.
4271 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4272 Likewise.
4273 * xdisp.c (check_it): Likewise.
4274 * xfaces.c (register_color, unregister_color, unregister_colors):
4275 Likewise.
4276 * xfns.c (print_fontset_result): Likewise.
4277 * xrdb.c (member, fatal, main): Likewise.
4278
4279 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4280
4281 Fix minor problems found by static checking (Bug#9031).
4282 * chartab.c (char_table_set_range, map_sub_char_table):
4283 Remove unused locals.
4284 (uniprop_table): Now static.
4285 * composite.c (_work_char): Remove unused static var.
4286
4287 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4290
4291 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4292
4293 * gtkutil.c (qttip_cb): Remove code without function.
4294
4295 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4296
4297 * w32.c (pthread_sigmask): New stub.
4298
4299 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Use pthread_sigmask, not sigprocmask (Bug#9010).
4302 sigprocmask is portable only for single-threaded applications, and
4303 Emacs can be multi-threaded when it uses GTK.
4304 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4305 (LIBES): Use it.
4306 * callproc.c (Fcall_process):
4307 * process.c (create_process):
4308 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4309 Use pthread_sigmask, not sigprocmask.
4310
4311 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4312
4313 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4314 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4315 wrong (Bug#8591).
4316
4317 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4320 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4321 (xg_hide_tooltip): Fix comment.
4322
4323 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4324 in registerServicesMenuSendTypes.
4325 (validRequestorForSendType): Don't check ns_return_types.
4326
4327 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4328 ns_return_type.
4329
4330 2011-07-08 Jason Rumney <jasonr@gnu.org>
4331
4332 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4333 SH_SHOW for hidden windows (Bug#5482).
4334
4335 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4336 frame struct members of non-existent frames (Bug#6284).
4337
4338 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4339
4340 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4341 variable firstTime not needed on OSX >= 10.6.
4342 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4343 >= 10.5. Use setKnobProportion, setDoubleValue.
4344
4345 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4346 (MAC_OS_X_VERSION_10_5): Define if not defined.
4347 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4348 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4349 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4350
4351 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4352 cString and lossyCString on OSX >= 10.4
4353
4354 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4355 sizeToFit on OSX >= 10.2.
4356
4357 * nsimage.m (allocInitFromFile): Don't use deprecated method
4358 bestRepresentationForDevice on OSX >= 10.6.
4359
4360 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4361 to avoid warning.
4362
4363 * emacs.c: Declare unexec_init_emacs_zone.
4364
4365 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4366
4367 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4368
4369 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4370 on svcsMenu (Bug#8842).
4371
4372 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4373 ns_return_types.
4374 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4375
4376 * nsterm.m (QUTF8_STRING): Declare.
4377 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4378 (validRequestorForSendType): Return type is (id).
4379 Change indexOfObjectIdenticalTo to indexOfObject.
4380 Check if we have local selection before returning self (Bug#8842).
4381 (writeSelectionToPasteboard): Put local selection into paste board
4382 if we have a local selection (Bug#8842).
4383 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4384
4385 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4386 (ns_get_local_selection): Declare.
4387
4388 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4389
4390 * keymap.c (describe_map_tree): Don't insert a double newline at
4391 the end of the buffer (bug#1169) and return whether we inserted
4392 something.
4393
4394 * callint.c (Fcall_interactively): Change "reading args" to
4395 "providing args" to try to clarify what it does (bug#1010).
4396
4397 2011-07-07 Kenichi Handa <handa@m17n.org>
4398
4399 * composite.c (composition_compute_stop_pos): Ignore a static
4400 composition starting before CHARPOS (Bug#8915).
4401
4402 * xdisp.c (handle_composition_prop): Likewise.
4403
4404 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4405
4406 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4407 (Bug#9015)
4408
4409 2011-07-07 Kenichi Handa <handa@m17n.org>
4410
4411 * character.h (unicode_category_t): New enum type.
4412
4413 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4414 (Qchar_code_property_table): New variable.
4415 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4416 (UNIPROP_COMPRESSED_FORM_P): New macros.
4417 (char_table_ascii): Uncompress the compressed values.
4418 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4419 Uncompress the compressed values.
4420 (sub_char_table_ref_and_range): Likewise.
4421 (char_table_ref_and_range): Uncompress the compressed values.
4422 (sub_char_table_set): New arg is_uniprop. Callers changed.
4423 Uncompress the compressed values.
4424 (sub_char_table_set_range): Args changed. Callers changed.
4425 (char_table_set_range): Adjuted for the above change.
4426 (map_sub_char_table): Delete args default_val and parent. Add arg
4427 top. Give decoded values to a Lisp function.
4428 (map_char_table): Adjust for the above change. Give decoded
4429 values to a Lisp function. Gcpro more variables.
4430 (uniprop_table_uncompress)
4431 (uniprop_decode_value_run_length): New functions.
4432 (uniprop_decoder, uniprop_decoder_count): New variables.
4433 (uniprop_get_decoder, uniprop_encode_value_character)
4434 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4435 New functions.
4436 (uniprop_encoder, uniprop_encoder_count): New variables.
4437 (uniprop_get_encoder, uniprop_table)
4438 (Funicode_property_table_internal, Fget_unicode_property_internal)
4439 (Fput_unicode_property_internal): New functions.
4440 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4441 Sunicode_property_table_internal, Sget_unicode_property_internal,
4442 and Sput_unicode_property_internal. Defvar_lisp
4443 char-code-property-alist.
4444
4445 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4446 Vunicode_category_table.
4447
4448 * font.c (font_range): Adjust for the change of
4449 Vunicode_category_table.
4450
4451 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4452
4453 * m/iris4d.h: Remove file, move contents ...
4454 * s/irix6-5.h: ... here.
4455
4456 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4457
4458 Remove unportable assumption about struct layout (Bug#8884).
4459 * alloc.c (mark_buffer):
4460 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4461 (clone_per_buffer_values): Don't assume that
4462 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4463 This isn't true in general, and it's particularly not true
4464 if Emacs is configured with --with-wide-int.
4465 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4466 New macros, used in the buffer.c change.
4467
4468 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4469
4470 * xsettings.c: Use both GConf and GSettings if both are available.
4471 (store_config_changed_event): Add comment.
4472 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4473 (store_tool_bar_style_changed): New functions.
4474 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4475 (struct xsettings): Move font inside HAVE_XFT.
4476 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4477 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4478 Move inside HAVE_XFT.
4479 (something_changed_gsettingsCB): Rename from something_changedCB.
4480 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4481 also.
4482 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4483 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4484 (something_changed_gconfCB): Rename from something_changedCB.
4485 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4486 (parse_settings): Move check for font inside HAVE_XFT.
4487 (read_settings, apply_xft_settings): Add comment.
4488 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4489 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4490 call store_font_name_changed.
4491 (xft_settings_event): Add comment.
4492 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4493 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4494 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4495 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4496 (xsettings_initialize): Call init_gsettings last.
4497 (xsettings_get_system_font, xsettings_get_system_normal_font):
4498 Add comment.
4499
4500 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 Random fixes. E.g., (random) never returned negative values.
4503 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4504 subseconds part to the entropy, as that's a bit more random.
4505 Prefer signed to unsigned, since the signedness doesn't matter and
4506 in general we prefer signed. When given a limit, use a
4507 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4508 latter isn't right if USE_2_TAGS_FOR_INTS.
4509 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4510 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4511
4512 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4513
4514 * textprop.c (text_property_stickiness):
4515 Obey Vtext_property_default_nonsticky.
4516 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4517 * w32fns.c (syms_of_w32fns):
4518 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4519
4520 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4523 This is more efficient than Ffile_directory_p and avoids a minor race.
4524
4525 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4526
4527 * buffer.c (Foverlay_put): Say what the return value is
4528 (bug#7835).
4529
4530 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4531 is a directory before asking whether to use the file name
4532 (bug#7564).
4533 (barf_or_query_if_file_exists): Make the "File is a directory"
4534 error be more correct.
4535
4536 * fns.c (Frequire): Remove the mention of the .gz files, since
4537 that's installation-specific, but keep the mention of
4538 `get-load-suffixes'.
4539
4540 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4541
4542 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4543 Report string overflow if the output is too long.
4544
4545 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4546
4547 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4548 (syms_of_gnutls): Remove duplicate DEFSYM for
4549 Qgnutls_bootprop_verify_hostname_error, an error for
4550 Qgnutls_bootprop_verify_error (which is no longer used).
4551
4552 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4553 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4554 Also (re)move comments that are misplaced or no longer relevant.
4555
4556 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4557
4558 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4559
4560 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4561
4562 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4563 and background color parameters if they have been changed.
4564
4565 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4566
4567 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4568
4569 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 * xsettings.c (SYSTEM_FONT): Define only when used.
4572 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4573
4574 * keymap.c (access_keymap_1): Now static.
4575
4576 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4577
4578 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4579 leave any prefix arg for the up event (Bug#1586).
4580
4581 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4582
4583 * lread.c (syms_of_lread): Mention single symbols defined by
4584 `defvar' or `defconst' (bug#7154).
4585
4586 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4587 (Frequire): Mention get-load-suffixes.
4588
4589 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4590
4591 * window.h (window): Remove clone_number slot.
4592 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4593 Remove.
4594 (make_parent_window, make_window, saved_window)
4595 (Fset_window_configuration, save_window_save): Don't deal with
4596 clone numbers.
4597 * buffer.c (Qclone_number): Remove declaration.
4598 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4599
4600 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4601
4602 Add multiple inheritance to keymaps.
4603 * keymap.c (Fmake_composed_keymap): New function.
4604 (Fset_keymap_parent): Simplify.
4605 (fix_submap_inheritance): Remove.
4606 (access_keymap_1): New function extracted from access_keymap to handle
4607 embedded parents and handle lists of maps.
4608 (access_keymap): Use it.
4609 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4610 (Fcopy_keymap): Handle embedded parents.
4611 (Fcommand_remapping, define_as_prefix): Simplify.
4612 (Fkey_binding): Simplify.
4613 (syms_of_keymap): Move minibuffer-local-completion-map,
4614 minibuffer-local-filename-completion-map,
4615 minibuffer-local-must-match-map, and
4616 minibuffer-local-filename-must-match-map to Elisp.
4617 (syms_of_keymap): Defsubr make-composed-keymap.
4618 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4619 (parse_menu_item): Trivial simplification.
4620
4621 2011-07-01 Glenn Morris <rgm@gnu.org>
4622
4623 * Makefile.in (SETTINGS_LIBS): Fix typo.
4624
4625 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4626
4627 * coding.c (Fencode_coding_string): Record the last coding system
4628 used, as the function doc string says (bug#8738).
4629
4630 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4631
4632 * xsettings.c (store_monospaced_changed): Take new font as arg and
4633 check for change against current_mono_font.
4634 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4635 (emacs_settings_constructor, emacs_settings_get_property)
4636 (emacs_settings_set_property, emacs_settings_class_init)
4637 (emacs_settings_init, gsettings_obj): Remove.
4638 (something_changedCB): New function for HAVE_GSETTINGS.
4639 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4640 with value as argument.
4641 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4642 g_settings_new (Bug#8967). Do not create gsettings_obj.
4643 Remove calls to g_settings_bind. Connect something_changedCB to
4644 "changed".
4645
4646 * xgselect.c: Add defined (HAVE_GSETTINGS).
4647 (xgselect_initialize): Ditto.
4648
4649 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4650 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4651 xg_select.
4652
4653 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 * eval.c (struct backtrace): Simplify and port the data structure.
4656 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4657 signed bit field, as this assumption is not portable and it makes
4658 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4659 "char debug_on_exit : 1" as this is not portable either; instead,
4660 use the portable "unsigned int debug_on_exit : 1". Remove unused
4661 member evalargs. Remove obsolete comments about cc bombing out.
4662
4663 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4666 Let HAVE_GSETTINGS override HAVE_GCONF.
4667 (store_monospaced_changed): New function.
4668 (EMACS_SETTINGS): A new type derived from GObject to handle
4669 GSettings notifications.
4670 (emacs_settings_constructor, emacs_settings_get_property)
4671 (emacs_settings_set_property, emacs_settings_class_init):
4672 New functions.
4673 (gsettings_client, gsettings_obj): New variables.
4674 (GSETTINGS_SCHEMA): New define.
4675 (something_changedCB): Call store_monospaced_changed.
4676 (init_gsettings): New function.
4677 (xsettings_initialize): Call init_gsettings.
4678 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4679 to NULL.
4680
4681 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4682 GCONF_CFLAGS/LIBS.
4683
4684 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4685
4686 * window.c (resize_root_window, grow_mini_window)
4687 (shrink_mini_window): Rename Qresize_root_window to
4688 Qwindow_resize_root_window and Qresize_root_window_vertically to
4689 Qwindow_resize_root_window_vertically.
4690
4691 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4694
4695 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * makefile.w32-in: Redesign dependencies so they reflect more
4698 clearly which files are directly included by each source file,
4699 and not through other includes.
4700
4701 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4702
4703 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4704 (sort_overlays, overlay_strings): When an overlay's clone number
4705 matches the window's clone number process the overlay even if
4706 the overlay's window property doesn't match the current window.
4707
4708 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4709 (Fwindow_hchild): Rename to Fwindow_left_child.
4710 (Fwindow_next): Rename to Fwindow_next_sibling.
4711 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4712 (resize_window_check): Rename to window_resize_check.
4713 (resize_window_apply): Rename to window_resize_apply.
4714 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4715 (Fdelete_other_windows_internal, resize_frame_windows)
4716 (Fsplit_window_internal, Fdelete_window_internal)
4717 (grow_mini_window, shrink_mini_window)
4718 (Fresize_mini_window_internal): Fix callers accordingly.
4719
4720 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4723 (emacs_fixed_set_min_size): Remove.
4724 (emacs_fixed_new): Take frame as argument.
4725
4726 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4727 (_EmacsFixedPrivate): Remove minwidth/height.
4728 Add struct frame *f.
4729 (emacs_fixed_init): Initialize priv->f.
4730 (get_parent_class, emacs_fixed_set_min_size): Remove.
4731 (emacs_fixed_new): Set priv->f to argument.
4732 (emacs_fixed_get_preferred_width)
4733 (emacs_fixed_get_preferred_height): Use min_width/height from
4734 frames size_hint to set minimum and natural (Bug#8919).
4735 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4736 and use min_width/height from frames size_hint to set
4737 min_width/height (Bug#8919).
4738
4739 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4740 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4741 Fix indentation.
4742
4743 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4744
4745 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4746 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4747 called at ZV.
4748
4749 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4750
4751 * process.c (wait_reading_process_output): Bypass select if
4752 waiting for a cell while ignoring keyboard input, and input is
4753 pending. Suggested by Jan Djärv (Bug#8869).
4754
4755 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 Use gnulib's dup2 module instead of rolling our own.
4758 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4759
4760 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4761
4762 * dispnew.c (scrolling_window): Before scrolling, turn off a
4763 mouse-highlight in the window being scrolled.
4764
4765 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4766
4767 Move DEFSYM to lisp.h and use everywhere.
4768
4769 * character.h (DEFSYM): Move declaration...
4770 * lisp.h (DEFSYM): ...here.
4771
4772 * gnutls.c:
4773 * minibuf.c:
4774 * w32menu.c:
4775 * w32proc.c:
4776 * w32select.c: Don't include character.h.
4777
4778 * alloc.c (syms_of_alloc):
4779 * buffer.c (syms_of_buffer):
4780 * bytecode.c (syms_of_bytecode):
4781 * callint.c (syms_of_callint):
4782 * casefiddle.c (syms_of_casefiddle):
4783 * casetab.c (init_casetab_once):
4784 * category.c (init_category_once, syms_of_category):
4785 * ccl.c (syms_of_ccl):
4786 * cmds.c (syms_of_cmds):
4787 * composite.c (syms_of_composite):
4788 * dbusbind.c (syms_of_dbusbind):
4789 * dired.c (syms_of_dired):
4790 * dispnew.c (syms_of_display):
4791 * doc.c (syms_of_doc):
4792 * editfns.c (syms_of_editfns):
4793 * emacs.c (syms_of_emacs):
4794 * eval.c (syms_of_eval):
4795 * fileio.c (syms_of_fileio):
4796 * fns.c (syms_of_fns):
4797 * frame.c (syms_of_frame):
4798 * fringe.c (syms_of_fringe):
4799 * insdel.c (syms_of_insdel):
4800 * keymap.c (syms_of_keymap):
4801 * lread.c (init_obarray, syms_of_lread):
4802 * macros.c (syms_of_macros):
4803 * msdos.c (syms_of_msdos):
4804 * print.c (syms_of_print):
4805 * process.c (syms_of_process):
4806 * search.c (syms_of_search):
4807 * sound.c (syms_of_sound):
4808 * syntax.c (init_syntax_once, syms_of_syntax):
4809 * terminal.c (syms_of_terminal):
4810 * textprop.c (syms_of_textprop):
4811 * undo.c (syms_of_undo):
4812 * w32.c (globals_of_w32):
4813 * window.c (syms_of_window):
4814 * xdisp.c (syms_of_xdisp):
4815 * xfaces.c (syms_of_xfaces):
4816 * xfns.c (syms_of_xfns):
4817 * xmenu.c (syms_of_xmenu):
4818 * xsettings.c (syms_of_xsettings):
4819 * xterm.c (syms_of_xterm): Use DEFSYM.
4820
4821 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4822
4823 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4824
4825 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4826
4827 Integer and buffer overflow fixes (Bug#8873).
4828
4829 * print.c (printchar, strout): Check for string overflow.
4830 (PRINTPREPARE, printchar, strout):
4831 Don't set size unless allocation succeeds.
4832
4833 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4834 for sizes. Check for string overflow more accurately.
4835 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4836
4837 * macros.c: Integer and buffer overflow fixes.
4838 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4839 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4840 Use ptrdiff_t, not int, for sizes.
4841 Don't increment bufsize until after realloc succeeds.
4842 Check for size-calculation overflow.
4843 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4844
4845 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4846
4847 * lread.c: Integer overflow fixes.
4848 (read_integer): Radix is now EMACS_INT, not int,
4849 to improve quality of diagnostics for out-of-range radices.
4850 Calculate buffer size correctly for out-of-range radices.
4851 (read1): Check for integer overflow in radices, and in
4852 read-circle numbers.
4853 (read_escape): Avoid int overflow.
4854 (Fload, openp, read_buffer_size, read1)
4855 (substitute_object_recurse, read_vector, read_list, map_obarray):
4856 Use ptrdiff_t, not int, for sizes.
4857 (read1): Use EMACS_INT, not int, for sizes.
4858 Check for size overflow.
4859
4860 * image.c (cache_image): Check for size arithmetic overflow.
4861
4862 * lread.c: Integer overflow issues.
4863 (saved_doc_string_size, saved_doc_string_length)
4864 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4865 Now ptrdiff_t, not int.
4866 (read1): Don't assume doc string length fits in int. Check for
4867 out-of-range doc string lengths.
4868 (read_list): Don't assume file position fits in int.
4869 (read_escape): Check for hex character overflow.
4870
4871 2011-06-22 Leo Liu <sdl.web@gmail.com>
4872
4873 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4874 Move to minibuffer.el.
4875
4876 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4879 The following patches are for when GLYPH_DEBUG && !XASSERT.
4880 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4881 * dispnew.c (flush_stdout):
4882 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4883 Mark as externally visible.
4884 * dispnew.c (check_window_matrix_pointers): Now static.
4885 * dispnew.c (window_to_frame_vpos):
4886 * xfns.c (unwind_create_frame):
4887 * xterm.c (x_check_font): Remove unused local.
4888 * scroll.c (CHECK_BOUNDS):
4889 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4890 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4891 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4892 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4893 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4894 Now static.
4895 (debug_method_add): Use va_list and vsprintf rather than relying
4896 on undefined behavior with wrong number of arguments.
4897 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4898 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4899 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4900 since we're not interested in debugging glyphs with old libraries.
4901 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4902 GCC 4.6.0's static checking.
4903
4904 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4905
4906 Integer overflow and signedness fixes (Bug#8873).
4907 A few related buffer overrun fixes, too.
4908
4909 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4910
4911 * dispextern.h (struct face.stipple):
4912 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4913 (x_bitmap_mask, x_allocate_bitmap_record)
4914 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4915 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4916 (x_create_bitmap_from_xpm_data):
4917 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4918 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4919 (.bitmaps_last):
4920 * xfaces.c (load_pixmap):
4921 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4922 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4923 (.bitmaps_last, struct x_output.icon_bitmap):
4924 Use ptrdiff_t, not int, for bitmap indexes.
4925 (x_allocate_bitmap_record): Check for size overflow.
4926 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4927
4928 Use ptrdiff_t, not int, for overlay counts.
4929 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4930 * editfns.c (overlays_around, get_pos_property):
4931 * textprop.c (get_char_property_and_overlay):
4932 * xdisp.c (next_overlay_change, note_mouse_highlight):
4933 * xfaces.c (face_at_buffer_position):
4934 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4935 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4936 (Fnext_overlay_change, Fprevious_overlay_change)
4937 (mouse_face_overlay_overlaps, Foverlays_in):
4938 Use ptrdiff_t, not int, for sizes.
4939 (overlays_at, overlays_in): Check for size-calculation overflow.
4940
4941 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4942
4943 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4944 (x_session_initialize): Do not assume string length fits in int.
4945
4946 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4947 This is unlikely, but can occur if DPI is outlandish.
4948
4949 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4950 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4951
4952 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4953 * xrdb.c (magic_file_p, search_magic_path):
4954 Omit last arg SUFFIX; it was always 0. All callers changed.
4955 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4956
4957 * xfont.c (xfont_match): Avoid need for strlen.
4958
4959 * xfns.c: Don't assume strlen fits in int.
4960 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4961
4962 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4963 not unsigned long, as we prefer signed integers. All callers changed.
4964 Detect integer overflow in repeat count.
4965 (message_dolog): Don't assume print length fits in 39 bytes.
4966 (display_mode_element): Don't assume strlen fits in int.
4967
4968 * termcap.c: Don't assume sizes fit in int and never overflow.
4969 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4970 (gobble_line): Check for size-calculation overflow.
4971
4972 * minibuf.c (Fread_buffer):
4973 * lread.c (intern, intern_c_string):
4974 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4975 Don't assume string length fits in int.
4976
4977 * keyboard.c (parse_tool_bar_item):
4978 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4979
4980 * font.c: Don't assume string length fits in int.
4981 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4982 Use ptrdiff_t, not int.
4983 (font_intern_prop): Don't assume string length fits in int.
4984 Don't assume integer property fits in fixnum.
4985 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4986
4987 * filelock.c: Fix some buffer overrun and integer overflow issues.
4988 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4989 Reformulate so as not to need the command string.
4990 Invoke gzip -cd rather than gunzip, as it's more portable.
4991 (lock_info_type, lock_file_1, lock_file):
4992 Don't assume pid_t and time_t fit in unsigned long.
4993 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4994 (current_lock_owner): Prefer signed type for sizes.
4995 Use memcpy, not strncpy, where memcpy is what is really wanted.
4996 Don't assume (via atoi) that time_t and pid_t fit in int.
4997 Check for time_t and/or pid_t out of range, e.g., via a network share.
4998 Don't alloca where an auto var works fine.
4999
5000 * fileio.c: Fix some integer overflow issues.
5001 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5002 Don't assume string length fits in int.
5003 (directory_file_name): Don't assume string length fits in long.
5004 (make_temp_name): Don't assume pid fits in int, or that its print
5005 length is less than 20.
5006
5007 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5008
5009 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5010
5011 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5012
5013 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5014 We prefer signed integers, even for size calculations.
5015
5016 * emacs.c: Don't assume string length fits in 'int'.
5017 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5018 (main): Don't invoke strlen when not needed.
5019
5020 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5021 (XD_DEBUG_MESSAGE): Don't waste a byte.
5022
5023 * callproc.c (getenv_internal_1, getenv_internal)
5024 (Fgetenv_internal):
5025 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5026
5027 * lread.c (invalid_syntax): Omit length argument.
5028 All uses changed. This doesn't fix a bug, but it simplifies the
5029 code away from its former Hollerith-constant appearance, and it's
5030 one less 'int' to worry about when looking at integer-overflow issues.
5031 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5032
5033 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5034 This didn't break anything, but it didn't help either.
5035 It's confusing to put a bogus integer in a place where the actual
5036 value does not matter.
5037 (LIST_END_P): Remove unused macro and its bogus comment.
5038 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5039
5040 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5041 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5042 implementation.
5043 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5044 We prefer signed types, and the value cannot exceed the EMACS_INT
5045 range anyway (because otherwise the length would not be representable).
5046 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5047 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5048 This avoids a GCC warning when WIDE_EMACS_INT.
5049
5050 * indent.c (sane_tab_width): New function.
5051 (current_column, scan_for_column, Findent_to, position_indentation)
5052 (compute_motion): Use it. This is just for clarity.
5053 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5054
5055 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5056
5057 * lisp.h (lint_assume): New macro.
5058 * composite.c (composition_gstring_put_cache):
5059 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5060
5061 * editfns.c, insdel.c:
5062 Omit unnecessary forward decls, to simplify future changes.
5063
5064 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5065
5066 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5067
5068 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5069 Use much-faster test for byte-length change.
5070 Don't assume string byte-length fits in 'int'.
5071 Check that character arg fits in 'int'.
5072 (mapcar1): Declare byte as byte, for clarity.
5073
5074 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5075
5076 * fns.c (concat): Catch string overflow earlier.
5077 Do not rely on integer wraparound.
5078
5079 * dispextern.h (struct it.overlay_strings_charpos)
5080 (struct it.selective): Now EMACS_INT, not int.
5081 * xdisp.c (forward_to_next_line_start)
5082 (back_to_previous_visible_line_start)
5083 (reseat_at_next_visible_line_start, next_element_from_buffer):
5084 Don't arbitrarily truncate the value of 'selective' to int.
5085
5086 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5087
5088 * composite.c: Don't truncate sizes to 'int'.
5089 (composition_gstring_p, composition_reseat_it)
5090 (composition_adjust_point): Use EMACS_INT, not int.
5091 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5092 not EMACS_UINT, for indexes.
5093
5094 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5095
5096 * buffer.c: Include <verify.h>.
5097 (struct sortvec.priority, struct sortstr.priority):
5098 Now EMACS_INT, not int.
5099 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5100 (struct sortstr.size, record_overlay_string)
5101 (struct sortstrlist.size, struct sortlist.used):
5102 Don't truncate size to int.
5103 (record_overlay_string): Check for size-calculation overflow.
5104 (init_buffer_once): Check at compile-time, not run-time.
5105
5106 2011-06-22 Jim Meyering <meyering@redhat.com>
5107
5108 Don't leak an XBM-image-sized buffer
5109 * image.c (xbm_load): Free the image buffer after using it.
5110
5111 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 Port to Sun C.
5114 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5115 that Sun C diagnosed.
5116 * fns.c (secure_hash): Fix pointer signedness issue.
5117 * intervals.c (static_offset_intervals): New function.
5118 (offset_intervals): Use it.
5119
5120 2011-06-21 Leo Liu <sdl.web@gmail.com>
5121
5122 * deps.mk (fns.o):
5123 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5124 sha512.h.
5125
5126 * fns.c (secure_hash): Rename from crypto_hash_function and change
5127 the first arg to accept symbols.
5128 (Fsecure_hash): New primitive.
5129 (syms_of_fns): New symbols.
5130
5131 2011-06-20 Deniz Dogan <deniz@dogan.se>
5132
5133 * process.c (Fset_process_buffer): Clarify return value in
5134 docstring.
5135
5136 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5137
5138 * dispnew.c (add_window_display_history): Use BVAR.
5139
5140 * xdisp.c (debug_method_add): Use BVAR.
5141 (check_window_end, dump_glyph_matrix, dump_glyph)
5142 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5143
5144 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5145 Likewise.
5146
5147 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5148 check till after the cache is created in init_frame_faces.
5149
5150 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5151
5152 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5153
5154 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5157 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5158 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5159
5160 Improve buffer-overflow checking (Bug#8873).
5161 * fileio.c (Finsert_file_contents):
5162 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5163 Remove the old (too-loose) buffer overflow checks.
5164 They weren't needed, since make_gap checks for buffer overflow.
5165 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5166 The old code merely checked for Emacs fixnum overflow, and relied
5167 on undefined (wraparound) behavior. The new code avoids undefined
5168 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5169
5170 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5171 Tune. Don't use wider integers than needed. Don't use alloca.
5172 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5173
5174 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5175
5176 * insdel.c, lisp.h (buffer_overflow): New function.
5177 (insert_from_buffer_1, replace_range, replace_range_2):
5178 * insdel.c (make_gap_larger):
5179 * editfns.c (Finsert_char):
5180 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5181
5182 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5183
5184 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5185
5186 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5187
5188 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5189 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5190
5191 * fileio.c: Don't assume EMACS_INT fits in off_t.
5192 (emacs_lseek): New static function.
5193 (Finsert_file_contents, Fwrite_region): Use it.
5194 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5195
5196 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5197
5198 * fns.c: Don't overflow int when computing a list length.
5199 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5200 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5201 truncation on 64-bit hosts. Check for QUIT every
5202 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5203 faster and is responsive enough.
5204 (Flength): Report an error instead of overflowing an integer.
5205 (Fsafe_length): Return a float if the value is not representable
5206 as a fixnum. This shouldn't happen except in contrived situations.
5207 (Fnthcdr, Fsort): Don't assume list length fits in int.
5208 (Fcopy_sequence): Don't assume vector length fits in int.
5209
5210 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5211 (header_size, word_size): New constants.
5212 (allocate_vectorlike): Don't check size overflow here.
5213 (allocate_vector): Check it here instead, since this is the only
5214 caller of allocate_vectorlike that could cause overflow.
5215 Check that the new vector's length is representable as a fixnum.
5216
5217 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5218 The previous code was bogus. For example, next_almost_prime (32)
5219 returned 39, which is undesirable as it is a multiple of 3; and
5220 next_almost_prime (24) returned 25, which is a multiple of 5 so
5221 why was the code bothering to check for multiples of 7?
5222
5223 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5224
5225 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5226
5227 Variadic C functions now count arguments with ptrdiff_t.
5228 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5229 Back then I didn't know that the Emacs coding style prefers signed int.
5230 Also, in the meantime I found a few more instances where arguments
5231 were being counted with int, which may truncate counts on 64-bit
5232 machines, or EMACS_INT, which may be unnecessarily wide.
5233 * lisp.h (struct Lisp_Subr.function.aMANY)
5234 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5235 Arg counts are now ptrdiff_t, not size_t.
5236 All variadic functions and their callers changed accordingly.
5237 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5238 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5239 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5240 * callint.c (Fcall_interactively): Check arg count for overflow,
5241 to avoid potential buffer overrun. Use signed char, not 'int',
5242 for 'varies' array, so that we needn't bother to check its size
5243 calculation for overflow.
5244 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5245 * eval.c (apply_lambda):
5246 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5247 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5248 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5249
5250 * callint.c (Fcall_interactively): Don't use index var as event count.
5251
5252 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5253 * mem-limits.h (SIZE): Remove; no longer used.
5254
5255 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5256
5257 Remove unnecessary casts.
5258 * xterm.c (x_term_init):
5259 * xfns.c (x_set_border_pixel):
5260 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5261 These aren't needed now that we assume ANSI C.
5262
5263 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5264 It's more likely to cause problems (due to unsigned overflow)
5265 than to cure them.
5266
5267 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5268
5269 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5270
5271 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5272
5273 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5274
5275 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5276
5277 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5278
5279 GLYPH_CODE_FACE returns EMACS_INT, not int.
5280 * dispextern.h (merge_faces):
5281 * xfaces.c (merge_faces):
5282 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5283 Don't assume EMACS_INT fits in int.
5284
5285 * character.h (CHAR_VALID_P): Remove unused parameter.
5286 * fontset.c, lisp.h, xdisp.c: All uses changed.
5287
5288 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5289
5290 * fns.c (concat): Minor tuning based on overflow analysis.
5291 This doesn't fix any bugs. Use int to hold character, instead
5292 of constantly refetching from Emacs object. Use XFASTINT, not
5293 XINT, for value known to be a character. Don't bother comparing
5294 a single byte to 0400, as it's always less.
5295
5296 * floatfns.c (Fexpt):
5297 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5298
5299 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5300 for characters.
5301
5302 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5303
5304 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5305 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5306 incorrectly succeed when S was a string, because 4294967386 was
5307 truncated before it was used.
5308
5309 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5310 Otherwise, an out-of-range integer could cause undefined behavior
5311 on a 64-bit host.
5312
5313 * composite.c: Use int, not EMACS_INT, for characters.
5314 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5315 EMACS_INT, for values that are known to be in character range.
5316 This doesn't fix any bugs but is the usual style inside Emacs and
5317 may generate better code on 32-bit machines.
5318
5319 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5320 This is for reasons similar to the recent CHAR_STRING fix.
5321 * charset.c (Fencode_char): Check that character arg is actually
5322 a character. Pass an int to ENCODE_CHAR.
5323 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5324 wider than 'int', as a compile-time check to prevent future regressions
5325 in this area.
5326
5327 * character.c (char_string): Remove unnecessary casts.
5328
5329 Make sure a 64-bit char is never passed to CHAR_STRING.
5330 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5331 by silently ignoring the top 32 bits, allowing some values
5332 that were far too large to be valid characters.
5333 * character.h: Include <verify.h>.
5334 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5335 arguments are no wider than unsigned, as a compile-time check
5336 to prevent future regressions in this area.
5337 * data.c (Faset):
5338 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5339 (Fsubst_char_in_region):
5340 * fns.c (concat):
5341 * xdisp.c (decode_mode_spec_coding):
5342 Adjust to CHAR_STRING's new requirement.
5343 * editfns.c (Finsert_char, Fsubst_char_in_region):
5344 * fns.c (concat): Check that character args are actually
5345 characters. Without this test, these functions did the wrong
5346 thing with wildly out-of-range values on 64-bit hosts.
5347
5348 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5349 These casts should not be needed on 32-bit hosts, either.
5350 * keyboard.c (read_char):
5351 * lread.c (Fload): Remove casts to unsigned.
5352
5353 * lisp.h (UNSIGNED_CMP): New macro.
5354 This fixes comparison bugs on 64-bit hosts.
5355 (ASCII_CHAR_P): Use it.
5356 * casefiddle.c (casify_object):
5357 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5358 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5359 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5360 * dispextern.h (FACE_FROM_ID):
5361 * keyboard.c (read_char): Use UNSIGNED_CMP.
5362
5363 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5364 not to EMACS_INT, to avoid GCC warning.
5365
5366 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5367
5368 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5369 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5370 isn't needed on 32-bit machines.
5371
5372 * buffer.c (Fgenerate_new_buffer_name):
5373 Use EMACS_INT for count, not int.
5374 (advance_to_char_boundary): Return EMACS_INT, not int.
5375
5376 * data.c (Qcompiled_function): Now static.
5377
5378 * window.c (window_body_lines): Now static.
5379
5380 * image.c (gif_load): Rename local to avoid shadowing.
5381
5382 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5383 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5384 * alloc.c (make_save_value): Integer argument is now of type
5385 ptrdiff_t, not int.
5386 (mark_object): Use ptrdiff_t, not int.
5387 * lisp.h (pD): New macro.
5388 * print.c (print_object): Use it.
5389
5390 * alloc.c: Use EMACS_INT, not int, to count objects.
5391 (total_conses, total_markers, total_symbols, total_vector_size)
5392 (total_free_conses, total_free_markers, total_free_symbols)
5393 (total_free_floats, total_floats, total_free_intervals)
5394 (total_intervals, total_strings, total_free_strings):
5395 Now EMACS_INT, not int. All uses changed.
5396 (Fgarbage_collect): Compute overall total using a double, so that
5397 integer overflow is less likely to be a problem. Check for overflow
5398 when converting back to an integer.
5399 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5400 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5401 These were 'int' variables that could overflow on 64-bit hosts;
5402 they were never used, so remove them instead of repairing them.
5403 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5404 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5405 Previously, this ceilinged at INT_MAX, but that doesn't work on
5406 64-bit machines.
5407 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5408
5409 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5410 (allocate_vectorlike): Check for ptrdiff_t overflow.
5411 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5412 when a (possibly-narrower) signed value would do just as well.
5413 We prefer using signed arithmetic, to avoid comparison confusion.
5414
5415 * alloc.c: Catch some string size overflows that we were missing.
5416 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5417 for convenience in STRING_BYTES_MAX.
5418 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5419 The definition here is exact; the one in lisp.h was approximate.
5420 (allocate_string_data): Check for string overflow. This catches
5421 some instances we weren't catching before. Also, it catches
5422 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5423 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5424 and ptrdiff_t and EMACS_INT are both 64 bits.
5425
5426 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5427 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5428 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5429
5430 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5431
5432 * alloc.c (Fmake_string): Check for out-of-range init.
5433
5434 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5435
5436 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5437
5438 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5439
5440 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5441 xg_get_default_scrollbar_width.
5442
5443 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5444 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5445 (style_changed_cb): Call update_theme_scrollbar_width and call
5446 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5447 all frames (Bug#8505).
5448 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5449 Call gtk_window_set_resizable if HAVE_GTK3.
5450 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5451 and height if HAVE_GTK3 (Bug#8505).
5452 (scroll_bar_width_for_theme): New variable.
5453 (update_theme_scrollbar_width): New function.
5454 (xg_get_default_scrollbar_width): Move code to
5455 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5456 (xg_initialize): Call update_theme_scrollbar_width.
5457
5458 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5459
5460 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5461
5462 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5463
5464 * frame.c (make_frame): Call other_buffer_safely instead of
5465 other_buffer.
5466
5467 * window.c (temp_output_buffer_show): Call display_buffer with
5468 second argument Vtemp_buffer_show_specifiers and reset latter
5469 immediately after the call.
5470 (Vtemp_buffer_show_specifiers): New variable.
5471 (auto_window_vscroll_p, next_screen_context_lines)
5472 (Vscroll_preserve_screen_position): Remove leading asterisks from
5473 doc-strings.
5474
5475 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 Fix minor problems found by GCC 4.6.0 static checking.
5478 * buffer.c (Qclone_number): Remove for now, as it's unused.
5479 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5480 (record_buffer): Remove unused local.
5481 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5482 (set_frame_buffer_list): Remove; unused.
5483 * frame.h (other_visible_frames): Remove decl.
5484 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5485 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5486 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5487 if HAVE_GPM.
5488 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5489 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5490 Define only if HAVE_GPM.
5491 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5492 (update_hints_inhibit): Remove; never set. All uses removed.
5493 * widgetprv.h (emacsFrameClassRec): Remove decl.
5494 * window.c (delete_deletable_window): Now returns void, since it
5495 wasn't returning anything.
5496 (compare_window_configurations): Remove unused locals.
5497 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5498 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5499 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5500 the same widths as pointers. This follows up on the 2011-05-06 patch.
5501 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5502 * xterm.h: Likewise.
5503 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5504
5505 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5506
5507 * makefile.w32-in: Update dependencies.
5508 (LISP_H): Add lib/intprops.h.
5509
5510 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5511
5512 * image.c (gif_load): Add animation frame delay to the metadata.
5513 (syms_of_image): Use DEFSYM. New symbol `delay'.
5514
5515 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5516
5517 * window.c (delete_deletable_window): Re-add.
5518 (Fset_window_configuration): Rewrite to handle dead buffers and
5519 consequently deletable windows.
5520 (window_tree, Fwindow_tree): Remove. Supply functionality in
5521 window.el.
5522 (compare_window_configurations): Simplify code.
5523
5524 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5525
5526 * image.c (imagemagick_load_image): Fix type mismatch.
5527 (Fimagemagick_types): Likewise.
5528
5529 * window.h (replace_buffer_in_windows): Declare.
5530
5531 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5532
5533 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5534 Qclone_number. Remove external declaration of Qdelete_window.
5535 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5536 code.
5537 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5538 Run Qbuffer_list_update_hook if allowed.
5539 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5540 buffer list implementation.
5541 (other_buffer_safely): New function.
5542 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5543 calls to replace_buffer_in_windows and
5544 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5545 if allowed.
5546 (record_buffer): Inhibit quitting and rewrite using quittable
5547 functions. Run Qbuffer_list_update_hook if allowed.
5548 (Frecord_buffer, Funrecord_buffer): New functions.
5549 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5550 Move switch-to-buffer to window.el.
5551 (bury-buffer): Move to window.el.
5552 (Vbuffer_list_update_hook): New variable.
5553
5554 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5555 section.
5556
5557 * window.h (resize_frame_windows): Move up in code.
5558 (Fwindow_frame): Remove EXFUN.
5559 (replace_buffer_in_all_windows): Remove prototype.
5560 (replace_buffer_in_windows_safely): Add prototype.
5561
5562 * window.c: Declare Qdelete_window static again. Move down
5563 declaration of select_count.
5564 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5565 (Fother_window): Move to window.el.
5566 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5567 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5568 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5569 window.el.
5570 (replace_buffer_in_windows): Implement by calling
5571 Qreplace_buffer_in_windows.
5572 (replace_buffer_in_all_windows): Remove with some functionality
5573 moved into replace_buffer_in_windows_safely.
5574 (replace_buffer_in_windows_safely): New function.
5575 (select_window_norecord, select_frame_norecord): Move in front
5576 of run_window_configuration_change_hook. Remove now obsolete
5577 declarations.
5578 (Fset_window_buffer): Rewrite doc-string.
5579 Call Qrecord_window_buffer.
5580 (keys_of_window): Move binding for other-window to window.el.
5581
5582 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5583
5584 * dispextern.h (struct image): Replace data member, whose int_val
5585 and ptr_val fields were not used by anything, with a single
5586 lisp_val object.
5587
5588 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5589 (gif_clear_image, gif_load, imagemagick_load_image)
5590 (gs_clear_image, gs_load): Callers changed.
5591
5592 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5593
5594 * buffer.h: Include <time.h>, for time_t.
5595 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5596
5597 Fix minor problems found by static checking.
5598
5599 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5600
5601 Make identifiers static if they are not used in other modules.
5602 * data.c (Qcompiled_function, Qframe, Qvector):
5603 * image.c (QimageMagick, Qsvg):
5604 * minibuf.c (Qmetadata):
5605 * window.c (resize_window_check, resize_root_window): Now static.
5606 * window.h (resize_window_check, resize_root_window): Remove decls.
5607
5608 * window.c (window_deletion_count, delete_deletable_window):
5609 Remove; unused.
5610 (window_body_lines): Now static.
5611 (Fdelete_other_windows_internal): Mark vars as initialized.
5612 Make sure 'resize_failed' is initialized.
5613 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5614 (resize_window_apply): Remove unused local.
5615 * window.h (delete_deletable_window): Remove decl.
5616
5617 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5618 (imagemagick_load_image): Fix pointer signedness problem by changing
5619 last arg from unsigned char * to char *. All uses changed.
5620 Also, fix a local for similar reasons.
5621 Remove unused locals. Remove locals to avoid shadowing.
5622 (fn_rsvg_handle_free): Remove; unused.
5623 (svg_load, svg_load_image): Fix pointer signedness problem.
5624 (imagemagick_load_image): Don't use garbage pointer image_wand.
5625
5626 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5627
5628 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * image.c (gif_load): Fix omitted cast error introduced by
5631 2011-06-06 change.
5632
5633 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5634
5635 * window.h (resize_proportionally, orig_total_lines)
5636 (orig_top_line): Remove from window structure.
5637 (set_window_height, set_window_width, change_window_heights)
5638 (Fdelete_window): Remove prototypes.
5639 (resize_frame_windows): Remove duplicate declaration.
5640
5641 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5642
5643 * window.h (resize_frame_windows, resize_window_check)
5644 (delete_deletable_window, resize_root_window)
5645 (resize_frame_windows): Declare prototypes.
5646
5647 * window.c (resize_window_apply): Make definition be "static" to
5648 match the prototype.
5649
5650 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5651
5652 * window.c: Remove declarations of Qwindow_size_fixed,
5653 window_min_size_1, window_min_size_2, window_min_size,
5654 size_window, window_fixed_size_p, enlarge_window, delete_window.
5655 Remove static from declaration of Qdelete_window, it's
5656 temporarily needed by Fbury_buffer.
5657 (replace_window): Don't assign orig_top_line and
5658 orig_total_lines.
5659 (Fdelete_window, delete_window): Remove. Window deletion is
5660 handled by window.el.
5661 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5662 Replace Fdelete_window calls with calls to Qdelete_window.
5663 (Fdelete_other_windows): Remove. Deleting other windows is
5664 handled by window.el.
5665 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5666 handled in window.el.
5667 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5668 Window minimum sizes are handled in window.el.
5669 (shrink_windows, size_window, set_window_height)
5670 (set_window_width, change_window_heights, window_height)
5671 (window_width, CURBEG, CURSIZE, enlarge_window)
5672 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5673 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5674 handled in window.el.
5675 (make_dummy_parent): Rename to make_parent_window and give it a
5676 second argument horflag.
5677 (make_window): Don't set resize_proportionally any more.
5678 (Fsplit_window): Remove. Windows are split in window.el.
5679 (save_restore_action, save_restore_orig_size)
5680 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5681 Resize mini windows in window.el.
5682 (grow_mini_window, shrink_mini_window): Implement by calling
5683 Qresize_root_window_vertically, resize_window_check and
5684 resize_window_apply.
5685 (saved_window, Fset_window_configuration, save_window_save):
5686 Do not handle orig_top_line, orig_total_lines, and
5687 resize_proportionally.
5688 (window_min_height, window_min_width): Move to window.el.
5689 (keys_of_window): Move bindings for delete-other-windows,
5690 split-window, delete-window and enlarge-window to window.el.
5691
5692 * buffer.c: Temporarily extern Qdelete_window.
5693 (Fbury_buffer): Temporarily call Qdelete_window instead of
5694 Fdelete_window (Fbury_buffer will move to window.el soon).
5695
5696 * frame.c (set_menu_bar_lines_1): Remove code handling
5697 orig_top_line and orig_total_lines.
5698
5699 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5700 set_window_height but set heights directly.
5701 (change_frame_size_1): Use resize_frame_windows.
5702
5703 * xdisp.c (init_xdisp): Don't use set_window_height but set
5704 heights directly.
5705
5706 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5707 Use resize_frame_windows instead of change_window_heights and run
5708 run_window_configuration_change_hook.
5709
5710 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5711 instead of change_window_heights and run
5712 run_window_configuration_change_hook.
5713
5714 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5715
5716 * window.c (replace_window): Rename second argument REPLACEMENT to
5717 NEW. New third argument SETFLAG. Rewrite.
5718 (delete_window, make_dummy_parent): Call replace_window with
5719 third argument 1.
5720 (window_list_1): Move down in code.
5721 (run_window_configuration_change_hook): Move set_buffer part
5722 before select_frame_norecord part in order to unwind correctly.
5723 Rename count1 to count.
5724 (recombine_windows, delete_deletable_window, resize_root_window)
5725 (Fdelete_other_windows_internal)
5726 (Frun_window_configuration_change_hook, make_parent_window)
5727 (resize_window_check, resize_window_apply, Fresize_window_apply)
5728 (resize_frame_windows, Fsplit_window_internal)
5729 (Fdelete_window_internal, Fresize_mini_window_internal):
5730 New functions.
5731 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5732
5733 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5734
5735 * window.h (window): Add some new members to window structure -
5736 normal_lines, normal_cols, new_total, new_normal, clone_number,
5737 splits, nest, prev_buffers, next_buffers.
5738 (WINDOW_TOTAL_SIZE): Move here from window.c.
5739 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5740
5741 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5742 Remove.
5743 (make_dummy_parent): Set new members of windows structure.
5744 (make_window): Move down in code. Handle new members of window
5745 structure.
5746 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5747 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5748 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5749 (Fset_window_prev_buffers, Fwindow_next_buffers)
5750 (Fset_window_next_buffers, Fset_window_clone_number):
5751 New functions.
5752 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5753 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5754 Doc-string fixes.
5755 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5756 Argument WINDOW can be now internal window too.
5757 (Fwindow_use_time): Move up in code.
5758 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5759 Rewrite doc-string.
5760 (Fset_window_configuration, saved_window)
5761 (Fcurrent_window_configuration, save_window_save): Handle new
5762 members of window structure.
5763 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5764 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5765 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5766 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5767 Qget_mru_window, Qresize_root_window,
5768 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5769 Qauto_buffer_name; staticpro them.
5770
5771 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5772
5773 * window.c (Fwindow_total_size, Fwindow_left_column)
5774 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5775 (Fwindow_list_1): New functions.
5776 (window_box_text_cols): Replace with window_body_cols.
5777 (Fwindow_width, Fscroll_left, Fscroll_right):
5778 Use window_body_cols instead of window_box_text_cols.
5779 (delete_window, Fset_window_configuration):
5780 Call delete_all_subwindows with window as argument.
5781 (delete_all_subwindows): Take a window as argument and not a
5782 structure. Rewrite.
5783 (window_loop): Remove handling of GET_LRU_WINDOW and
5784 GET_LARGEST_WINDOW.
5785 (Fget_lru_window, Fget_largest_window): Move to window.el.
5786
5787 * window.h: Extern window_body_cols instead of
5788 window_box_text_cols. delete_all_subwindows now takes a
5789 Lisp_Object as argument.
5790
5791 * indent.c (compute_motion, Fcompute_motion):
5792 Use window_body_cols instead of window_box_text_cols.
5793
5794 * frame.c (delete_frame): Call delete_all_subwindows with root
5795 window as argument.
5796
5797 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5798
5799 * fns.c (Fputhash): Document return value.
5800
5801 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5802
5803 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5804
5805 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5806
5807 Cons<->int and similar integer overflow fixes (Bug#8794).
5808
5809 Check for overflow when converting integer to cons and back.
5810 * charset.c (Fdefine_charset_internal, Fdecode_char):
5811 Use cons_to_unsigned to catch overflow.
5812 (Fencode_char): Use INTEGER_TO_CONS.
5813 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5814 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5815 * data.c (long_to_cons, cons_to_long): Remove.
5816 (cons_to_unsigned, cons_to_signed): New functions.
5817 These signal an error for invalid or out-of-range values.
5818 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5819 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5820 * font.c (Ffont_variation_glyphs):
5821 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5822 * lisp.h: Include <intprops.h>.
5823 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5824 (cons_to_signed, cons_to_unsigned): New decls.
5825 (long_to_cons, cons_to_long): Remove decls.
5826 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5827 (Fprimitive_undo): Use CONS_TO_INTEGER.
5828 * xfns.c (Fx_window_property): Likewise.
5829 * xselect.c: Include <limits.h>.
5830 (x_own_selection, selection_data_to_lisp_data):
5831 Use INTEGER_TO_CONS.
5832 (x_handle_selection_request, x_handle_selection_clear)
5833 (x_get_foreign_selection, Fx_disown_selection_internal)
5834 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5835 (lisp_data_to_selection_data): Use cons_to_unsigned.
5836 (x_fill_property_data): Use cons_to_signed.
5837 Report values out of range.
5838
5839 Check for buffer and string overflow more precisely.
5840 * buffer.h (BUF_BYTES_MAX): New macro.
5841 * lisp.h (STRING_BYTES_MAX): New macro.
5842 * alloc.c (Fmake_string):
5843 * character.c (string_escape_byte8):
5844 * coding.c (coding_alloc_by_realloc):
5845 * doprnt.c (doprnt):
5846 * editfns.c (Fformat):
5847 * eval.c (verror):
5848 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5849 since they may not be the same number.
5850 * editfns.c (Finsert_char):
5851 * fileio.c (Finsert_file_contents):
5852 Likewise for BUF_BYTES_MAX.
5853
5854 * image.c: Use ptrdiff_t, not int, for sizes.
5855 (slurp_file): Switch from int to ptrdiff_t.
5856 All uses changed.
5857 (slurp_file): Check that file size fits in both size_t (for
5858 malloc) and ptrdiff_t (for sanity and safety).
5859
5860 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5861 if b->modtime has its maximal value.
5862
5863 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5864
5865 Don't assume time_t can fit into int.
5866 * buffer.h (struct buffer.modtime): Now time_t, not int.
5867 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5868 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5869
5870 Minor fixes for signed vs unsigned integers.
5871 * character.h (MAYBE_UNIFY_CHAR):
5872 * charset.c (maybe_unify_char):
5873 * keyboard.c (read_char, reorder_modifiers):
5874 XINT -> XFASTINT, since the integer must be nonnegative.
5875 * ftfont.c (ftfont_spec_pattern):
5876 * keymap.c (access_keymap, silly_event_symbol_error):
5877 XUINT -> XFASTINT, since the integer must be nonnegative.
5878 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5879 since it makes no difference and we prefer signed.
5880 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5881 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5882 nonnegative.
5883
5884 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5885
5886 * window.h (Fwindow_frame): Declare.
5887
5888 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5889
5890 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5891 (SPARE_MEMORY): Always define.
5892 (LARGE_REQUEST): Remove.
5893 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5894
5895 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5896
5897 * lisp.h: Move EXFUNS for Fframe_root_window,
5898 Fframe_first_window and Fset_frame_selected_window to window.h.
5899
5900 * window.h: Move EXFUNS for Fframe_root_window,
5901 Fframe_first_window and Fset_frame_selected_window here from
5902 lisp.h.
5903
5904 * frame.c (Fwindow_frame, Fframe_first_window)
5905 (Fframe_root_window, Fframe_selected_window)
5906 (Fset_frame_selected_window): Move to window.c.
5907 (Factive_minibuffer_window): Move to minibuf.c.
5908 (Fother_visible_frames_p): New function.
5909
5910 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5911
5912 * window.c (decode_window, decode_any_window): Move up in code.
5913 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5914 (inhibit_frame_unsplittable): Remove unused variable.
5915 (Fwindow_buffer): Move up and rewrite doc-string.
5916 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5917 (Fwindow_prev): New functions.
5918 (Fwindow_frame): Move here from frame.c. Accept any window as
5919 argument.
5920 (Fframe_root_window, Fframe_first_window)
5921 (Fframe_selected_window): Move here from frame.c. Accept frame
5922 or arbitrary window as argument. Update doc-strings.
5923 (Fminibuffer_window): Move up in code.
5924 (Fwindow_minibuffer_p): Move up in code and simplify.
5925 (Fset_frame_selected_window): Move here from frame.c.
5926 Marginal rewrite.
5927 (Fselected_window, select_window, Fselect_window): Move up in
5928 code. Minor doc-string fixes.
5929
5930 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5933 Do not assume that spare memory exists; that assumption is valid
5934 only if SYSTEM_MALLOC.
5935 (LARGE_REQUEST): New macro, so that the issue of large requests
5936 is separated from the issue of spare memory.
5937
5938 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5939
5940 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5941 format. (Bug#8806)
5942
5943 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5944
5945 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5946 before statements.
5947
5948 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5949
5950 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5951
5952 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5953
5954 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5955 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5956
5957 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5958
5959 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5960
5961 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5962
5963 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5964 (x_clipboard_manager_save): Add return value.
5965 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5966 New error handlers.
5967 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5968 Obey Vx_select_enable_clipboard_manager. Catch errors in
5969 x_clipboard_manager_save (Bug#8779).
5970 (Vx_select_enable_clipboard_manager): New variable.
5971 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5972
5973 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5974
5975 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5976
5977 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5978
5979 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5980 in the current matrix if keep_current_p is non-zero.
5981
5982 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5983
5984 * bidi.c (bidi_level_of_next_char): Fix last change.
5985
5986 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5987
5988 Support bidi reordering of text covered by display properties.
5989
5990 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5991 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5992 (bidi_cache_search, bidi_cache_iterator_state)
5993 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5994 (bidi_level_of_next_char, bidi_move_to_visually_next):
5995 Support character positions inside a run of characters covered by a
5996 display string.
5997 (bidi_paragraph_init, bidi_resolve_explicit_1)
5998 (bidi_level_of_next_char): Call bidi_fetch_char and
5999 bidi_fetch_char_advance instead of FETCH_CHAR and
6000 FETCH_CHAR_ADVANCE.
6001 (bidi_init_it): Initialize new members.
6002 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6003 definitions.
6004 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6005 instead of using explicit *_CHAR codes.
6006 (bidi_resolve_explicit, bidi_resolve_weak):
6007 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6008 bidirectional text is supported only in multibyte buffers.
6009 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6010 it to initialize the frame_window_p member of struct bidi_it.
6011 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6012 (bidi_resolve_explicit, bidi_resolve_weak)
6013 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6014 bidi_it->nchars is non-positive.
6015 (bidi_level_of_next_char): Don't try to lookup the cache for the
6016 next/previous character if nothing is cached there yet, or if we
6017 were just reseat()'ed to a new position.
6018
6019 * xdisp.c (set_cursor_from_row): Set start and stop points
6020 according to the row's direction when priming the loop that looks
6021 for the glyph on which to display cursor.
6022 (single_display_spec_intangible_p): Function deleted.
6023 (display_prop_intangible_p): Reimplement to call
6024 handle_display_spec instead of single_display_spec_intangible_p.
6025 Accept 3 additional arguments needed by handle_display_spec.
6026 This fixes incorrect cursor motion across display property with complex
6027 values: lists, `(when COND...)' forms, etc.
6028 (single_display_spec_string_p): Support property values that are
6029 lists with the argument STRING its top-level element.
6030 (display_prop_string_p): Fix the condition for processing a
6031 property that is a list to be consistent with handle_display_spec.
6032 (handle_display_spec): New function, refactored from the
6033 last portion of handle_display_prop.
6034 (compute_display_string_pos): Accept additional argument
6035 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6036 value of a `display' property is a "replacing spec".
6037 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6038 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6039 the display property, but just return a value indicating whether
6040 the display property will replace the characters it covers.
6041 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6042 frame_window_p members of struct bidi_it.
6043 (compute_display_string_pos, compute_display_string_end):
6044 New functions.
6045 (push_it): Accept second argument POSITION, where pop_it should
6046 jump to continue iteration.
6047 (reseat_1): Initialize bidi_it.disp_pos.
6048
6049 * keyboard.c (adjust_point_for_property): Adjust the call to
6050 display_prop_intangible_p to its new signature.
6051
6052 * dispextern.h (struct bidi_it): New member frame_window_p.
6053 (bidi_init_it): Update prototypes.
6054 (display_prop_intangible_p): Update prototype.
6055 (compute_display_string_pos, compute_display_string_end):
6056 Declare prototypes.
6057 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6058 EMACS_INT.
6059
6060 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6061
6062 Malloc failure behavior now depends on size of allocation.
6063 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6064 * lisp.h: Change signatures accordingly.
6065 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6066 All callers changed. (Bug#8762)
6067
6068 * gnutls.c: Use Emacs's memory allocators.
6069 Without this change, the gnutls library would invoke malloc etc.
6070 directly, which causes problems on non-SYNC_INPUT hosts, and which
6071 runs afoul of improving memory_full behavior. (Bug#8761)
6072 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6073 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6074 xfree instead of the default malloc, realloc, free.
6075 (Fgnutls_boot): No need to check for memory allocation failure,
6076 since xmalloc does that for us.
6077
6078 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6079 * category.c (hash_get_category_set):
6080 * ccl.c (ccl_driver):
6081 * charset.c (Fdefine_charset_internal):
6082 * charset.h (struct charset.hash_index):
6083 * composite.c (get_composition_id, gstring_lookup_cache)
6084 (composition_gstring_put_cache):
6085 * composite.h (struct composition.hash_index):
6086 * dispextern.h (struct image.hash):
6087 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6088 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6089 (hashfn_equal, hashfn_user_defined, make_hash_table)
6090 (maybe_resize_hash_table, hash_lookup, hash_put)
6091 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6092 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6093 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6094 * image.c (make_image, search_image_cache, lookup_image)
6095 (xpm_put_color_table_h):
6096 * lisp.h (struct Lisp_Hash_Table):
6097 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6098 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6099 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6100 * alloc.c (allocate_vectorlike):
6101 Check for overflow in vector size calculations.
6102 * ccl.c (ccl_driver):
6103 Check for overflow when converting EMACS_INT to int.
6104 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6105 need to be updated by these changes.
6106 * fns.c (make_hash_table, maybe_resize_hash_table):
6107 Check for integer overflow with large hash tables.
6108 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6109 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6110 (SXHASH_REDUCE): New macro.
6111 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6112 Use it instead of discarding useful hash info with large hash values.
6113 (sxhash_float): New function.
6114 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6115 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6116 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6117 Rewrite to use FIXNUM_BITS, as this simplifies things.
6118 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6119 Adjust signatures to match updated version of code.
6120 (consing_since_gc): Now EMACS_INT, since a single hash table can
6121 use more than INT_MAX bytes.
6122
6123 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6124
6125 Make it possible to build with GCC-4.6+ -O2 -flto.
6126
6127 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6128
6129 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6130
6131 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6132 Call minibuffer-inactive-mode.
6133
6134 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6135
6136 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6137 Update dependencies.
6138
6139 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6140
6141 * data.c (init_data): Remove code for UTS, this system is not
6142 supported anymore.
6143
6144 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6145
6146 Don't force ./temacs to start in terminal mode.
6147
6148 * frame.c (make_initial_frame): Initialize faces in all cases, not
6149 only when CANNOT_DUMP is defined.
6150 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6151
6152 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6153
6154 * dispnew.c (add_window_display_history): Use const for the string
6155 pointer. Remove declaration, not needed.
6156
6157 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6158
6159 Use 'inline', not 'INLINE'.
6160 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6161 * alloc.c, fontset.c (INLINE): Remove.
6162 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6163 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6164 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6165 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6166 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6167
6168 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6169
6170 Make it possible to run ./temacs.
6171
6172 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6173 syms_of_callproc does the same thing. Remove test for
6174 "initialized", do it in the caller.
6175 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6176
6177 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6178
6179 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6180 (read_minibuf): Use get_minibuffer.
6181 (syms_of_minibuf): Use DEFSYM.
6182 (Qmetadata): New var.
6183 * data.c (Qbuffer): Don't make it static.
6184 (syms_of_data): Use DEFSYM.
6185
6186 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6187
6188 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6189 (CCL_CODE_MIN): New macro.
6190
6191 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6192
6193 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6194
6195 * eval.c (Qdebug): Now static.
6196 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6197 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6198 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6199
6200 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6201
6202 * image.c: Various fixes to ImageMagick code comments.
6203 (Fimagemagick_types): Doc fix.
6204
6205 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6206
6207 Minor fixes prompted by GCC 4.6.0 warnings.
6208
6209 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6210
6211 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6212 (x_clipboard_manager_save_all): Move extern decl to ...
6213 * xterm.h: ... here, so that it can be checked for consistency.
6214
6215 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6216
6217 * xselect.c (x_clipboard_manager_save_frame)
6218 (x_clipboard_manager_save_all): New functions.
6219 (Fx_clipboard_manager_save): Lisp function deleted.
6220
6221 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6222 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6223
6224 * xterm.h: Update prototype.
6225
6226 2011-05-28 William Xu <william.xwl@gmail.com>
6227
6228 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6229 exiting (Bug#8239).
6230
6231 2011-05-28 Jim Meyering <meyering@redhat.com>
6232
6233 Avoid a sign-extension bug in crypto_hash_function.
6234 * fns.c (to_uchar): Define.
6235 (crypto_hash_function): Use it to convert some newly-signed
6236 variables to unsigned, to avoid sign-extension bugs. For example,
6237 without this change, (md5 "truc") would evaluate to
6238 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6239 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6240 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6241
6242 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6243
6244 Integer overflow fixes.
6245
6246 * dbusbind.c: Serial number integer overflow fixes.
6247 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6248 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6249 to hold a serial number that is too large for a fixnum.
6250 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6251 Check for serial numbers out of range. Decode any serial number
6252 that was so large that it became a float. (Bug#8722)
6253
6254 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6255 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6256 Use XFASTINT rather than XUINT when numbers are nonnegative.
6257 (xd_append_arg, Fdbus_method_return_internal):
6258 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6259 arguments, check that Lisp number is nonnegative, rather than
6260 silently wrapping negative numbers around. (Bug#8722)
6261 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6262 (Bug#8722)
6263
6264 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6265
6266 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6267
6268 ccl: Add integer overflow checks.
6269 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6270 (IN_INT_RANGE): New macros.
6271 (ccl_driver): Use them to check for integer overflow when
6272 decoding a CCL program. Many of the new checks are whether XINT (x)
6273 fits in int; it doesn't always, on 64-bit hosts. The new version
6274 doesn't catch all possible integer overflows, but it's an
6275 improvement. (Bug#8719)
6276
6277 * alloc.c (make_event_array): Use XINT, not XUINT.
6278 There's no need for unsigned here.
6279
6280 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6281 This follows up to the 2011-05-06 change that substituted uintptr_t
6282 for EMACS_INT. This case wasn't caught back then.
6283
6284 Rework Fformat to avoid integer overflow issues.
6285 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6286 now (part of C89). Include <verify.h>.
6287 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6288 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6289 (Fformat): Avoid the prepass trying to compute sizes; it was only
6290 approximate and thus did not catch overflow reliably. Instead, walk
6291 through the format just once, formatting and computing sizes as we go,
6292 checking for integer overflow at every step, and allocating a larger
6293 buffer as needed. Keep track separately whether the format is
6294 multibyte. Keep only the most-recently calculated precision, rather
6295 than them all. Record whether each argument has been converted to
6296 string. Use EMACS_INT, not int, for byte and char and arg counts.
6297 Support field widths and precisions larger than INT_MAX. Avoid
6298 sprintf's undefined behavior with conversion specifications such as %#d
6299 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6300 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6301 formatting out-of-range floating point numbers with int
6302 formats. (Bug#8668)
6303
6304 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6305
6306 * data.c: Avoid integer truncation in expressions involving floats.
6307 * data.c: Include <intprops.h>.
6308 (arith_driver): When there's an integer overflow in an expression
6309 involving floating point, convert the integers to floating point
6310 so that the resulting value does not suffer from catastrophic
6311 integer truncation. For example, on a 64-bit host (* 4
6312 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6313 Do not rely on undefined behavior after integer overflow.
6314
6315 merge count_size_as_multibyte, parse_str_to_multibyte
6316 * character.c, character.h (count_size_as_multibyte):
6317 Rename from parse_str_to_multibyte; all uses changed.
6318 Check for integer overflow.
6319 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6320 since it's now a duplicate of the other. This is more of
6321 a character than a buffer op, so better that it's in character.c.
6322 * fns.c, print.c: Adjust to above changes.
6323
6324 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6325
6326 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6327
6328 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6329
6330 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6331 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6332 (x_clipboard_manager_save): Now static.
6333 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6334
6335 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6336 (crypto_hash_function): Now static.
6337 Fix pointer signedness problems. Avoid unnecessary initializations.
6338
6339 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6340
6341 * termhooks.h (Vselection_alist): Make it terminal-local.
6342
6343 * terminal.c (create_terminal): Initialize it.
6344
6345 * xselect.c: Support for clipboard managers.
6346 (Vselection_alist): Move to termhooks.h as terminal-local var.
6347 (LOCAL_SELECTION): New macro.
6348 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6349 (symbol_to_x_atom): Remove gratuitous arg.
6350 (x_handle_selection_request, lisp_data_to_selection_data)
6351 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6352 (x_own_selection, x_get_local_selection, x_convert_selection):
6353 New arg, specifying work frame. Use terminal-local Vselection_alist.
6354 (some_frame_on_display): Delete unused function.
6355 (Fx_own_selection_internal, Fx_get_selection_internal)
6356 (Fx_disown_selection_internal, Fx_selection_owner_p)
6357 (Fx_selection_exists_p): New optional frame arg.
6358 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6359 (x_handle_selection_clear): Don't treat other terminals with the
6360 same keyboard specially. Use the terminal-local Vselection_alist.
6361 (x_clear_frame_selections): Use Frun_hook_with_args.
6362
6363 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6364
6365 * xterm.h: Add support for those atoms.
6366
6367 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6368
6369 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6370 (converted_selections, conversion_fail_tag): New global variables.
6371 (x_selection_request_lisp_error): Free the above.
6372 (x_get_local_selection): Remove unnecessary code.
6373 (x_reply_selection_request): Args changed; handle arbitrary array
6374 of converted selections stored in converted_selections.
6375 Separate the XChangeProperty and SelectionNotify steps.
6376 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6377 (x_convert_selection): New function.
6378 (x_handle_selection_event): Simplify.
6379 (x_get_foreign_selection): Don't ignore incoming requests while
6380 waiting for an answer; this will fail when we implement
6381 SAVE_TARGETS, and seems unnecessary anyway.
6382 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6383 (Vx_sent_selection_functions): Doc fix.
6384
6385 2011-05-26 Leo Liu <sdl.web@gmail.com>
6386
6387 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6388
6389 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6390
6391 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6392
6393 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6394 for fringe update if it has periodic bitmap.
6395 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6396 and fringe_bitmap_periodic_p.
6397
6398 * fringe.c (get_fringe_bitmap_data): New function.
6399 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6400 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6401 row. Mark glyph row for fringe update if periodicity changed.
6402
6403 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6404 for fringe update unless it has periodic bitmap.
6405
6406 2011-05-25 Kenichi Handa <handa@m17n.org>
6407
6408 * xdisp.c (get_next_display_element): Set correct it->face_id for
6409 a static composition.
6410
6411 2011-05-24 Leo Liu <sdl.web@gmail.com>
6412
6413 * deps.mk (fns.o):
6414 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6415
6416 * fns.c (crypto_hash_function, Fsha1): New function.
6417 (Fmd5): Use crypto_hash_function.
6418 (syms_of_fns): Add Ssha1.
6419
6420 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6421
6422 * gnutls.c: Remove unused macros.
6423 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6424 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6425 Remove macros that are defined and never used.
6426 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6427
6428 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6429
6430 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6431 (Fx_get_selection_internal): Minor cleanup.
6432 (Fx_own_selection_internal): Rename arguments for consistency with
6433 select.el.
6434
6435 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6436
6437 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6438
6439 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6440
6441 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6442
6443 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6444
6445 * dispnew.c (scrolling_window): Don't exclude the case that the
6446 last enabled row in the desired matrix touches the bottom boundary.
6447
6448 2011-05-21 Glenn Morris <rgm@gnu.org>
6449
6450 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6451 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6452 and add some more files.
6453
6454 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6455
6456 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6457 report_file_error introduced by the change from 2011-05-07.
6458
6459 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6460
6461 * systime.h (Time): Define only if emacs is defined.
6462 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6463 where the include path doesn't have X11/X.h by default. See
6464 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6465
6466 2011-05-20 Kenichi Handa <handa@m17n.org>
6467
6468 * composite.c (find_automatic_composition): Fix previous change.
6469
6470 2011-05-20 Glenn Morris <rgm@gnu.org>
6471
6472 * lisp.mk: New file, split from Makefile.in.
6473 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6474 (shortlisp): Remove.
6475 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6476
6477 2011-05-19 Glenn Morris <rgm@gnu.org>
6478
6479 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6480 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6481 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6482 (lisp): Set the order to that of loadup.el.
6483 (shortlisp): Make it a copy of $lisp.
6484 (SOME_MACHINE_LISP): Remove.
6485 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6486 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6487
6488 2011-05-18 Kenichi Handa <handa@m17n.org>
6489
6490 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6491 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6492 (find_automatic_composition): Mostly rewrite for efficiency.
6493
6494 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6495
6496 * makefile.w32-in: Update dependencies.
6497
6498 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6499
6500 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6501 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6502
6503 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6504
6505 Fix some integer overflow issues, such as string length overflow.
6506
6507 * insdel.c (count_size_as_multibyte): Check for string overflow.
6508
6509 * character.c (lisp_string_width): Check for string overflow.
6510 Use EMACS_INT, not int, for string indexes and lengths; in
6511 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6512 the resulting string length overflows an EMACS_INT; instead,
6513 report a string overflow if no precision given. When checking for
6514 precision exhaustion, use a check that cannot possibly have
6515 integer overflow. (Bug#8675)
6516 * character.h (lisp_string_width): Adjust to new signature.
6517
6518 * alloc.c (string_overflow): New function.
6519 (Fmake_string): Use it. This doesn't change behavior, but saves
6520 a few bytes and will simplify future changes.
6521 * character.c (string_escape_byte8): Likewise.
6522 * lisp.h (string_overflow): New decl.
6523
6524 Fixups, following up to the user-interface timestamp change.
6525 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6526 for UI timestamps, instead of unsigned long.
6527 * msdos.c (mouse_get_pos): Likewise.
6528 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6529 * w32gui.h (Time): Define by including "systime.h" rather than by
6530 declaring it ourselves. (Bug#8664)
6531
6532 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6533 * image.c (clear_image_cache): Likewise.
6534
6535 * term.c (term_mouse_position): Don't assume time_t wraparound.
6536
6537 Be more systematic about user-interface timestamps.
6538 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6539 and sometimes 'EMACS_UINT', to represent these timestamps.
6540 This change causes it to use 'Time' uniformly, as that's what X uses.
6541 This makes the code easier to follow, and makes it easier to catch
6542 integer overflow bugs such as Bug#8664.
6543 * frame.c (Fmouse_position, Fmouse_pixel_position):
6544 Use Time, not unsigned long, for user-interface timestamps.
6545 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6546 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6547 * keyboard.h (last_event_timestamp): Likewise.
6548 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6549 * menu.h (xmenu_show): Likewise.
6550 * term.c (term_mouse_position): Likewise.
6551 * termhooks.h (struct input_event.timestamp): Likewise.
6552 (struct terminal.mouse_position_hook): Likewise.
6553 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6554 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6555 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6556 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6557 what it was before.
6558 * menu.h, termhooks.h: Include "systime.h", for Time.
6559
6560 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6561 Don't assume that the difference between two unsigned long values
6562 can fit into an integer. At this point, we know button_down_time
6563 <= event->timestamp, so the difference must be nonnegative, so
6564 there's no need to cast the result if double-click-time is
6565 nonnegative, as it should be; check that it's nonnegative, just in
6566 case. This bug is triggered when events are more than 2**31 ms
6567 apart (about 25 days). (Bug#8664)
6568
6569 * xselect.c (last_event_timestamp): Remove duplicate decl.
6570 (x_own_selection): Remove needless cast to unsigned long.
6571
6572 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6573 that always fit in int. Use a sentinel instead of a counter, to
6574 avoid a temp and to allay GCC's concerns about possible int overflow.
6575 * frame.h (struct frame): Use int for menu_bar_items_used
6576 instead of EMACS_INT, since it always fits in int.
6577
6578 * menu.c (grow_menu_items): Check for int overflow.
6579
6580 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6581
6582 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6583 Before, the code was not consistent. These values cannot exceed
6584 2**31 - 1 so there's no need to make them unsigned.
6585 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6586 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6587 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6588 as modifiers.
6589 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6590
6591 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6592 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6593 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6594 presumably because the widths might not match.
6595
6596 * window.c (size_window): Avoid needless test at loop start.
6597
6598 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6599
6600 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6601
6602 2011-05-12 Drew Adams <drew.adams@oracle.com>
6603
6604 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6605
6606 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6607
6608 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6609 `width' to `bar_area_x' and `bar_area_width', respectively.
6610 (x_scroll_run): Take account of fringe background extension.
6611
6612 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6613 Rename local vars `left' and `width' to `bar_area_x' and
6614 `bar_area_width', respectively.
6615 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6616 background extension.
6617
6618 2011-05-10 Jim Meyering <meyering@redhat.com>
6619
6620 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6621
6622 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6623
6624 * image.c (Finit_image_library): Return t for built-in image types,
6625 like pbm and xbm. (Bug#8640)
6626
6627 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6628
6629 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6630
6631 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6632
6633 * w32console.c (Fset_screen_color): Doc fix.
6634 (Fget_screen_color): New function.
6635 (syms_of_ntterm): Defsubr it.
6636
6637 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6638 unlink the temporary file if Fcall_process didn't create it in the
6639 first place.
6640 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6641 child process will be redirected to a file specified with `:file'.
6642 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6643 cue to call_process_cleanup not to close that handle.
6644
6645 2011-05-07 Ben Key <bkey76@gmail.com>
6646
6647 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6648 one of two shell specific rules, either bootstrap-temacs-CMD or
6649 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6650 to the previous implementation of the bootstrap-temacs rule.
6651 The bootstrap-temacs-CMD rule is similar to the previous
6652 implementation of the bootstrap-temacs rule except that it
6653 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6654 variable.
6655
6656 These changes, along with some changes to nt/configure.bat,
6657 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6658 earlier fix to add support for --cflags and --ldflags options
6659 that include quotes so that it works whether make uses cmd or
6660 sh as the shell.
6661
6662 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6663
6664 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6665 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6666 is a constant.
6667 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6668 a string. Handle both cases.
6669 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6670 (Fdbus_register_method): Use Qinvalid_function.
6671
6672 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6673
6674 * makefile.w32-in: Update dependencies.
6675 (LISP_H): Add inttypes.h and stdin.h.
6676 (PROCESS_H): Add unistd.h.
6677
6678 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6679
6680 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6681 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6682
6683 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6684
6685 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6686
6687 * term.c (vfatal): Remove stray call to va_end.
6688 It's not needed and the C Standard doesn't allow it here anyway.
6689
6690 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6691 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6692
6693 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6694 bytes.
6695
6696 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6697
6698 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6699
6700 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6701
6702 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6703
6704 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6705
6706 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6707 * charset.c (Fdefine_charset_internal): Don't initialize
6708 charset.code_space[15]. The value was garbage, on hosts with
6709 32-bit int (Bug#8600).
6710
6711 * lread.c (read_integer): Be more consistent with string-to-number.
6712 Use string_to_number to do the actual conversion; this avoids
6713 rounding errors and fixes some other screwups. Without this fix,
6714 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6715 (digit_to_number): Move earlier, for benefit of read_integer.
6716 Return -1 if the digit is out of range for the base, -2 if it is
6717 not a digit in any supported base. (Bug#8602)
6718
6719 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6720
6721 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6722 to match comment at start of function. This also removes a
6723 GCC warning about overflow in a 32+64-bit port.
6724
6725 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6726
6727 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6728 Reported by Stefan Monnier in
6729 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6730 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6731 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6732
6733 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6734 (EMACS_UINTPTR): Likewise, with uintptr_t.
6735
6736 * lisp.h: Prefer 64-bit EMACS_INT if available.
6737 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6738 on 32-bit hosts that have 64-bit int, so that they can access
6739 large files.
6740 However, temporarily disable this change unless the temporary
6741 symbol WIDE_EMACS_INT is defined.
6742
6743 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6744
6745 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6746 This removes an assumption that EMACS_INT and long are the same
6747 width as pointers. The assumption is true for Emacs porting targets
6748 now, but we want to make other targets possible.
6749 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6750 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6751 In the rest of the code, change types of integers that hold casted
6752 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6753 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6754 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6755 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6756 No need to cast type when ORing.
6757 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6758 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6759 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6760 assume EMACS_INT is the same width as char *.
6761 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6762 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6763 Remove no-longer-needed casts.
6764 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6765 (xg_tool_bar_help_callback, xg_make_tool_item):
6766 Use EMACS_INTPTR to hold an integer
6767 that will be cast to void *; this can avoid a GCC warning
6768 if EMACS_INT is not the same width as void *.
6769 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6770 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6771 (current_message_1, set_message_1):
6772 Use a local to convert to proper width without a cast.
6773 * xmenu.c (dialog_selection_callback): Likewise.
6774
6775 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6776 Also, don't assume VALBITS / RAND_BITS is less than 5,
6777 and don't rely on undefined behavior when shifting a 1 left into
6778 the sign bit.
6779 * lisp.h (get_random): Change signature to match.
6780
6781 * lread.c (hash_string): Use size_t, not int, for hash computation.
6782 Normally we prefer signed values; but hashing is special, because
6783 it's better to use unsigned division on hash table sizes so that
6784 the remainder is nonnegative. Also, size_t is the natural width
6785 for hashing into memory. The previous code used 'int', which doesn't
6786 retain enough info to hash well into very large tables.
6787 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6788
6789 * dbusbind.c: Don't possibly lose pointer info when converting.
6790 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6791 Use XPNTR rather than XHASH, so that the high-order bits of
6792 the pointer aren't lost when converting through void *.
6793
6794 * eval.c (Fautoload): Don't double-shift a pointer.
6795
6796 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6797
6798 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6799
6800 * gnutls.c (DEF_GNUTLS_FN):
6801 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6802
6803 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6804
6805 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6806 marker. (Bug#8610)
6807
6808 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6809
6810 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6811 New version that can reserve upto 2GB of heap space.
6812
6813 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6814
6815 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6816
6817 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6818
6819 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6820 `gnutls_certificate_set_x509_key_file'.
6821
6822 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6823
6824 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6825 Update dependencies.
6826
6827 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6830 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6831 Remove unused parameter `fildes'.
6832 * process.c (read_process_output, send_process): Don't pass it.
6833
6834 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6835
6836 Fix previous change: the library cache is defined in w32.c.
6837 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6838 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6839
6840 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6841
6842 Implement dynamic loading of GnuTLS on Windows.
6843
6844 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6845 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6846 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6847 Declare.
6848
6849 * gnutls.c (Qgnutls_dll): Define.
6850 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6851 (gnutls_*): Declare function pointers.
6852 (init_gnutls_functions): New function to initialize function pointers.
6853 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6854 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6855 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6856 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6857 (emacs_gnutls_write, emacs_gnutls_read)
6858 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6859 (Fgnutls_available_p): New function.
6860 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6861 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6862 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6863
6864 * image.c: Include w32.h.
6865 (Vimage_type_cache): Delete.
6866 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6867 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6868 (w32_delayed_load): Move to w32.c.
6869
6870 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6871
6872 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6873 (w32_delayed_load): Move from image.c. When loading a library, record
6874 its filename in the :loaded-from property of the library id.
6875 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6876 Initialize and staticpro them.
6877 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6878
6879 * process.c: Include lisp.h before w32.h, not after.
6880 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6881 instead of gnutls_record_check_pending.
6882
6883 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6884
6885 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6886
6887 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6888 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6889 as passed in.
6890
6891 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6892
6893 * xterm.c (x_set_frame_alpha): Do not set property on anything
6894 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6895
6896 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6897
6898 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6899
6900 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6903 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6904 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6905 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6906 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6907 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6908 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6909 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6910 (Qgnutls_bootprop_callbacks_verify): Make static.
6911
6912 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6913
6914 * callproc.c: Indentation fixup.
6915
6916 * sysdep.c (wait_for_termination_1): Make static.
6917 (wait_for_termination, interruptible_wait_for_termination):
6918 Move after wait_for_termination_1.
6919
6920 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6921
6922 * sysdep.c (interruptible_wait_for_termination): New function
6923 which is like wait_for_termination, but allows keyboard
6924 interruptions.
6925
6926 * callproc.c (Fcall_process): Add (:file "file") as an option for
6927 the STDOUT buffer.
6928 (Fcall_process_region): Ditto.
6929
6930 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6931
6932 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6933 rather than `XVECTOR (FOO)->size'.
6934
6935 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6936 inttypes.h, as a gnulib replacement is used if it not available in
6937 system headers.
6938
6939 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6940
6941 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6942 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6943 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6944
6945 * coding.c (coding_alloc_by_realloc): Error out if destination
6946 will grow beyond MOST_POSITIVE_FIXNUM.
6947 (decode_coding_emacs_mule): Abort if there isn't enough place in
6948 charbuf for the composition carryover bytes. Reserve an extra
6949 space for up to 2 characters produced in a loop.
6950 (decode_coding_iso_2022): Abort if there isn't enough place in
6951 charbuf for the composition carryover bytes.
6952
6953 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6954
6955 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6956 aborting when %lld or %lll format is passed.
6957 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6958 %llo or %llx format is passed. (Bug#8545)
6959
6960 * window.c (window_scroll_line_based): Use a marker instead of
6961 simple variables to record original value of point. (Bug#7952)
6962
6963 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6964 produced by %s or %c overflows available buffer space. (Bug#8545)
6965
6966 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6969 (SIZE_MAX): Move defn after all includes, as they might #define it.
6970
6971 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6974
6975 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6976
6977 * keyboard.c (Qdelayed_warnings_hook): Define.
6978 (command_loop_1): Run `delayed-warnings-hook'
6979 if Vdelayed_warnings_list is non-nil.
6980 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6981 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6982
6983 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6984
6985 * doprnt.c (doprnt): Don't return value smaller than the buffer
6986 size if the message was truncated. (Bug#8545).
6987
6988 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6991 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6992
6993 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6996
6997 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * makefile.w32-in: Update dependencies.
7000
7001 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7002
7003 Improve `doprnt' and its usage. (Bug#8545)
7004 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7005 `format_end'. Remove support for %l as a conversion specifier.
7006 Don't use xrealloc. Improve diagnostics when the %l size modifier
7007 is used. Update the commentary.
7008
7009 * eval.c (verror): Simplify calculation of size_t.
7010
7011 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7012 messages.
7013
7014 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7015
7016 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7017 change.
7018
7019 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7020
7021 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7022 This makes this file independent of the recent pseudovector change.
7023
7024 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7025
7026 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7027
7028 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7029 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7030 Remove unused local.
7031 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7032
7033 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7034 GCC 4.6.0 optimizes based on type-based alias analysis.
7035 For example, if b is of type struct buffer * and v of type struct
7036 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7037 != &v->size, and therefore "v->size = 1; b->size = 2; return
7038 v->size;" must therefore return 1. This assumption is incorrect
7039 for Emacs, since it type-puns struct Lisp_Vector * with many other
7040 types. To fix this problem, this patch adds a new type struct
7041 vectorlike_header that documents the constraints on layout of vectors
7042 and pseudovectors, and helps optimizing compilers not get fooled
7043 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7044 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7045 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7046 the size member.
7047 (XSETPVECTYPE): Rewrite in terms of new macro.
7048 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7049 This is a bit clearer, and further avoids the possibility of
7050 undesirable aliasing.
7051 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7052 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7053 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7054 since Lisp_Subr is a special case (no "next" field).
7055 (ASIZE): Now uses header.size rather than size.
7056 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7057 to avoid the hassle of writing XVECTOR (foo)->header.size.
7058 (struct vectorlike_header): New type.
7059 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7060 object, to help avoid aliasing.
7061 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7062 (SUBRP): Likewise, since Lisp_Subr is a special case.
7063 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7064 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7065 (struct Lisp_Hash_Table): Combine first two members into a single
7066 struct vectorlike_header member. All uses of "size" and "next" members
7067 changed to be "header.size" and "header.next".
7068 * buffer.h (struct buffer): Likewise.
7069 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7070 * frame.h (struct frame): Likewise.
7071 * process.h (struct Lisp_Process): Likewise.
7072 * termhooks.h (struct terminal): Likewise.
7073 * window.c (struct save_window_data, struct saved_window): Likewise.
7074 * window.h (struct window): Likewise.
7075 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7076 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7077 * buffer.c (init_buffer_once): Likewise.
7078 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7079 special case.
7080 * process.c (Fformat_network_address): Use local var for size,
7081 for brevity.
7082
7083 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7084
7085 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7086 * data.c (atof): Remove decl; no longer used or needed.
7087 (digit_to_number): Move to lread.c.
7088 (Fstring_to_number): Use new string_to_number function, to be
7089 consistent with how the Lisp reader treats infinities and NaNs.
7090 Do not assume that floating-point numbers represent EMACS_INT
7091 without losing information; this is not true on most 64-bit hosts.
7092 Avoid double-rounding errors, by insisting on integers when
7093 parsing non-base-10 numbers, as the documentation specifies.
7094 * lisp.h (string_to_number): New decl, replacing ...
7095 (isfloat_string): Remove.
7096 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7097 (read1): Do not accept +. and -. as integers; this
7098 appears to have been a coding error. Similarly, do not accept
7099 strings like +-1e0 as floating point numbers. Do not report
7100 overflow for integer overflows unless the base is not 10 which
7101 means we have no simple and reliable way to continue.
7102 Break out the floating-point parsing into a new
7103 function string_to_number, so that Fstring_to_number parses
7104 floating point numbers consistently with the Lisp reader.
7105 (digit_to_number): Move here from data.c. Make it static inline.
7106 (E_CHAR, EXP_INT): Remove, replacing with ...
7107 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7108 (string_to_number): New function, replacing isfloat_string.
7109 This function checks for valid syntax and produces the resulting
7110 Lisp float number too. Rework it so that string-to-number
7111 no longer mishandles examples like "1.0e+". Use strtoumax,
7112 so that overflow for non-base-10 numbers is reported only when
7113 there's no portable and simple way to convert to floating point.
7114
7115 * textprop.c (set_text_properties_1): Rewrite for clarity,
7116 and to avoid GCC warning about integer overflow.
7117
7118 * intervals.h (struct interval): Use EMACS_INT for members
7119 where EMACS_UINT might cause problems. See
7120 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7121 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7122 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7123 All uses changed.
7124 (offset_intervals): Tell GCC not to worry about length overflow
7125 when negating a negative length.
7126
7127 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7128 (overrun_check_free): Likewise.
7129
7130 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7131 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7132 word size.
7133
7134 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7135 (gnutls_make_error): Rename local to avoid shadowing.
7136 (gnutls_emacs_global_deinit): ifdef out; not used.
7137 (Fgnutls_boot): Use const for pointer to readonly storage.
7138 Comment out unused local. Fix pointer signedness problems.
7139
7140 * lread.c (openp): Don't stuff size_t into an 'int'.
7141 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7142 about possible signed overflow.
7143
7144 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7145 (GDK_KEY_g): Don't define if already defined.
7146 (xg_prepare_tooltip): Avoid pointer signedness problem.
7147 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7148
7149 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7150 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7151
7152 * xfns.c (Fx_window_property): Simplify a bit,
7153 to make a bit faster and to avoid GCC 4.6.0 warning.
7154 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7155
7156 * fns.c (internal_equal): Don't assume size_t fits in int.
7157
7158 * alloc.c (compact_small_strings): Tighten assertion a little.
7159
7160 Replace pEd with more-general pI, and fix some printf arg casts.
7161 * lisp.h (pI): New macro, generalizing old pEd macro to other
7162 conversion specifiers. For example, use "...%"pI"d..." rather
7163 than "...%"pEd"...".
7164 (pEd): Remove. All uses replaced with similar uses of pI.
7165 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7166 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7167 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7168 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7169 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7170 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7171 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7172 64-bit hosts.
7173 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7174 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7175 * print.c (safe_debug_print, print_object): Likewise.
7176 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7177 to int.
7178 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7179 avoiding the 0 flag, which is not portable.
7180 * process.c (Fmake_network_process): Use pI to avoid cast.
7181 * region-cache.c (pp_cache): Likewise.
7182 * xdisp.c (decode_mode_spec): Likewise.
7183 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7184 behavior on 64-bit hosts with printf arg.
7185 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7186 (x_stop_queuing_selection_requests): Likewise.
7187 (x_get_window_property): Don't truncate byte count to an 'int'
7188 when tracing.
7189
7190 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7191 here, since it parses constructs like leading '-' and spaces,
7192 which are not wanted; and it overflows with large numbers.
7193 Instead, simply match F[0-9]+, which is what is wanted anyway.
7194
7195 * alloc.c: Remove unportable assumptions about struct layout.
7196 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7197 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7198 (allocate_vectorlike, make_pure_vector): Use the new macros,
7199 plus offsetof, to remove unportable assumptions about struct layout.
7200 These assumptions hold on all porting targets that I know of, but
7201 they are not guaranteed, they're easy to remove, and removing them
7202 makes further changes easier.
7203
7204 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7205 This doesn't fix a bug but makes the code clearer.
7206 (string_overrun_cookie): Now const. Use initializers that
7207 don't formally overflow signed char, to avoid warnings.
7208 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7209 can cause Emacs to crash when string overrun checking is enabled.
7210 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7211 multiple of sizeof (EMACS_INT); it need not be, if
7212 alignof(EMACS_INT) < sizeof (EMACS_INT).
7213 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7214
7215 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7216
7217 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7218
7219 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7220
7221 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7222 supposed to be handshaking. (Bug#8556)
7223 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7224
7225 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7226
7227 * lisp.h (Qdebug): List symbol.
7228 * eval.c (Qdebug): Restore global linkage.
7229 * keyboard.c (debug-on-event): New variable.
7230 (handle_user_signal): Break into debugger when debug-on-event
7231 matches the current signal symbol.
7232
7233 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7234
7235 * alloc.c (check_sblock, check_string_bytes)
7236 (check_string_free_list): Convert to standard C.
7237
7238 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7239
7240 * w32.c (emacs_gnutls_push): Fix typo.
7241
7242 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7243
7244 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7245 "cast to pointer from integer of different size".
7246
7247 Improve doprnt and its use in verror. (Bug#8545)
7248 * doprnt.c (doprnt): Document the set of format control sequences
7249 supported by the function. Use SAFE_ALLOCA instead of always
7250 using `alloca'.
7251
7252 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7253 is one byte too soon. Don't use xrealloc; instead xfree and
7254 xmalloc anew.
7255
7256 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7257
7258 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7259 callbacks stage.
7260
7261 * gnutls.c: Renamed global_initialized to
7262 gnutls_global_initialized. Added internals for the
7263 :verify-hostname-error, :verify-error, and :verify-flags
7264 parameters of `gnutls-boot' and documented those parameters in the
7265 docstring. Start callback support.
7266 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7267 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7268 on error. Return error code.
7269 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7270 (emacs_gnutls_read): Likewise.
7271 (Fgnutls_boot): Return handshake error code.
7272 (emacs_gnutls_handle_error): New function.
7273 (wsaerror_to_errno): Likewise.
7274
7275 * w32.h (emacs_gnutls_pull): Add prototype.
7276 (emacs_gnutls_push): Likewise.
7277
7278 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7279 (emacs_gnutls_push): Likewise.
7280
7281 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7282
7283 * process.c (wait_reading_process_output): Check if GnuTLS
7284 buffered some data internally if no FDs are set for TLS
7285 connections.
7286
7287 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7288 (LIBS): Link to USER_LIBS.
7289 ($(BLD)/gnutls.$(0)): New target.
7290
7291 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7292
7293 * xdisp.c (handle_single_display_spec): Rename the
7294 display_replaced_before_p argument into display_replaced_p, to
7295 make it consistent with the commentary. Fix typos in the
7296 commentary.
7297
7298 * textprop.c (syms_of_textprop): Remove dead code.
7299 (copy_text_properties): Delete obsolete commentary about an
7300 interface that was deleted long ago. Fix typos in the description
7301 of arguments.
7302
7303 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7304 to changes in oldXMenu/XMenu.h from 2011-04-16.
7305 <menu_help_message, prev_menu_help_message>: Constify.
7306 (IT_menu_make_room): menu->help_text is now `const char **';
7307 adjust.
7308
7309 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7310 to changes in oldXMenu/XMenu.h from 2011-04-16.
7311 (struct XMenu): Declare `help_text' `const char **'.
7312
7313 * xfaces.c <Qunspecified>: Make extern again.
7314
7315 * syntax.c: Include sys/types.h before including regex.h, as
7316 required by Posix.
7317
7318 * doc.c (get_doc_string): Improve the format passed to `error'.
7319
7320 * doprnt.c (doprnt): Improve commentary.
7321
7322 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7323
7324 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7325 them with etags.
7326
7327 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7328 changes in globals.h immediately force recompilation.
7329 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7330 $(CURDIR)/s/ms-w32.h.
7331 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7332
7333 * character.c (Fchar_direction): Function deleted.
7334 (syms_of_character): Don't defsubr it.
7335 <char-direction-table>: Deleted.
7336
7337 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7338
7339 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7340 * doprnt.c: Include limits.h.
7341 (SIZE_MAX): New macro.
7342 (doprnt): Return a size_t value. 2nd arg is now size_t.
7343 Many local variables are now size_t instead of int or unsigned.
7344 Improve overflow protection. Support `l' modifier for integer
7345 conversions. Support %l conversion. Don't assume an EMACS_INT
7346 argument for integer conversions and for %c.
7347
7348 * lisp.h (doprnt): Restore prototype.
7349
7350 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7351 $(SRC)/character.h.
7352
7353 * Makefile.in (base_obj): Add back doprnt.o.
7354
7355 * deps.mk (doprnt.o): Add back prerequisites.
7356 (callint.o): Depend on character.h.
7357
7358 * eval.c (internal_lisp_condition_case): Include the handler
7359 representation in the error message.
7360 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7361 when breaking from the loop.
7362
7363 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7364
7365 * callint.c (Fcall_interactively): When displaying error message
7366 about invalid control letter, pass the character's codepoint, not
7367 a pointer to its multibyte form. Improve display of the character
7368 in octal and display also its hex code.
7369
7370 * character.c (char_string): Use %x to display the (unsigned)
7371 codepoint of an invalid character, to avoid displaying a bogus
7372 negative value.
7373
7374 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7375 `error', not SYMBOL_NAME itself.
7376
7377 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7378 character arguments to `error'.
7379
7380 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7381 to `error' in error message about FINAL_CHAR argument. Make sure
7382 FINAL_CHAR is a character, and use %c when it is passed as
7383 argument to `error'.
7384
7385 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7386
7387 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7388
7389 * w32.c: Include <time.h>.
7390 (sys_localtime): New function.
7391
7392 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7393
7394 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7395
7396 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7397
7398 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7399
7400 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7401 zombies (Bug#8467).
7402
7403 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7404
7405 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7406 gl_state.e_property when gl_state.object is Qt.
7407
7408 * insdel.c (make_gap_larger): Remove limitation of buffer size
7409 to <= INT_MAX.
7410
7411 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7412
7413 * xdisp.c (lookup_glyphless_char_display)
7414 (produce_glyphless_glyph): Handle cons cell entry in
7415 glyphless-char-display.
7416 (Vglyphless_char_display): Document it.
7417
7418 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7419 glyphless-char-display.
7420
7421 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7422
7423 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7424
7425 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7426
7427 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7428 definition for no-X builds.
7429
7430 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7431
7432 Static checks with GCC 4.6.0 and non-default toolkits.
7433
7434 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7435
7436 * process.c (keyboard_bit_set): Define only if SIGIO.
7437 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7438 (send_process): Repair possible setjmp clobbering.
7439
7440 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7441
7442 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7443
7444 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7445
7446 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7447 Define only if needed.
7448
7449 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7450 by pacifying GCC about it. Maybe it's time to retire it?
7451 * xfaces.c (USG, __TIMEVAL__): Likewise.
7452
7453 * dispextern.h (struct redisplay_interface): Rename param
7454 to avoid shadowing.
7455 * termhooks.h (struct terminal): Likewise.
7456 * xterm.c (xembed_send_message): Likewise.
7457
7458 * insdel.c (make_gap_smaller): Define only if
7459 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7460
7461 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7462 it.
7463
7464 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7465 so that we aren't warned about unused symbols.
7466
7467 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7468
7469 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7470
7471 * xfns.c (x_real_positions): Mark locals as initialized.
7472
7473 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7474
7475 * xterm.c: Fix problems found by static analysis with other toolkits.
7476 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7477 (x_dispatch_event): Declare static if USE_GTK, and
7478 define if USE_GTK || USE_X_TOOLKIT.
7479 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7480 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7481 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7482 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7483
7484 * xmenu.c (menu_help_callback): Pointer type fixes.
7485 Use const pointers when pointing at readonly data. Avoid pointer
7486 signedness clashes.
7487 (FALSE): Remove unused macro.
7488 (update_frame_menubar): Remove unused decl.
7489
7490 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7491
7492 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7493 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7494 (single_menu_item): Rename local to avoid shadowing.
7495
7496 * keyboard.c (make_lispy_event): Remove unused local var.
7497
7498 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7499 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7500
7501 * bitmaps: Change bitmaps from unsigned char back to the X11
7502 compatible char. Avoid the old compiler warnings about
7503 out-of-range initializers by using, for example, '\xab' rather
7504 than 0xab.
7505
7506 * xgselect.c (xgselect_initialize): Check vs interface
7507 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7508
7509 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7510
7511 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7512 to read-only memory.
7513
7514 * fns.c (vector): Remove; this old hack is no longer needed.
7515
7516 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7517 Remove unused var.
7518 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7519
7520 * xrdb.c (x_load_resources): Omit unused local.
7521
7522 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7523 (x_window): Rename locals to avoid shadowing.
7524 (USG): Use the kludged USG macro, to pacify gcc.
7525
7526 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7527 (x_term_init): Remove local to avoid shadowing.
7528
7529 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7530
7531 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7532 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7533
7534 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7535
7536 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7537
7538 Fix regex.c, syntax.c and friends for buffers > 2GB.
7539 * syntax.h (struct gl_state_s): Declare character position members
7540 EMACS_INT.
7541
7542 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7543
7544 * textprop.c (verify_interval_modification, interval_of):
7545 Declare arguments EMACS_INT.
7546
7547 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7548 EMACS_INT.
7549
7550 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7551
7552 * indent.c (Fvertical_motion): Local variable it_start is now
7553 EMACS_INT.
7554
7555 * regex.c (re_match, re_match_2, re_match_2_internal)
7556 (bcmp_translate, regcomp, regexec, print_double_string)
7557 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7558 (re_compile_pattern, re_exec): Declare arguments and local
7559 variables `size_t' and `ssize_t' and return values `regoff_t', as
7560 appropriate.
7561 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7562 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7563 <compile_stack_type>: `size' and `avail' are now `size_t'.
7564
7565 * regex.h <regoff_t>: Use ssize_t, not int.
7566 (re_search, re_search_2, re_match, re_match_2): Arguments that
7567 specify buffer/string position and length are now ssize_t and
7568 size_t. Return type is regoff_t.
7569
7570 2011-04-16 Ben Key <bkey76@gmail.com>
7571
7572 * nsfont.m: Fixed bugs in ns_get_family and
7573 ns_descriptor_to_entity that were caused by using free to
7574 deallocate memory blocks that were allocated by xmalloc (via
7575 xstrdup). This caused Emacs to crash when compiled with
7576 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7577 --enable-checking=xmallocoverrun). xfree is now used to
7578 deallocate these memory blocks.
7579
7580 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7581
7582 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7583
7584 emacs_write: Accept and return EMACS_INT for sizes.
7585 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7586 et seq.
7587 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7588 Accept and return EMACS_INT.
7589 (emacs_gnutls_write): Return the number of bytes written on
7590 partial writes.
7591 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7592 (emacs_read, emacs_write): Remove check for negative size, as the
7593 Emacs source code has been audited now.
7594 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7595 (emacs_read, emacs_write): Use it.
7596 * process.c (send_process): Adjust to the new signatures of
7597 emacs_write and emacs_gnutls_write. Do not attempt to store
7598 a byte offset into an 'int'; it might overflow.
7599 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7600
7601 * sound.c: Don't assume sizes fit in 'int'.
7602 (struct sound_device.period_size, alsa_period_size):
7603 Return EMACS_INT, not int.
7604 (struct sound_device.write, vox_write, alsa_write):
7605 Accept EMACS_INT, not int.
7606 (wav_play, au_play): Use EMACS_INT to store sizes and to
7607 record read return values.
7608
7609 2011-04-15 Ben Key <bkey76@gmail.com>
7610
7611 * keyboard.c (Qundefined): Don't declare static since it is used
7612 in nsfns.m.
7613 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7614 static since they are used in nsfont.m.
7615
7616 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7617
7618 * process.c (Qprocessp): Don't declare static.
7619 * lisp.h (Qprocessp): Declare again.
7620
7621 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7622
7623 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7624
7625 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7626
7627 Improve C-level modularity by making more things 'static'.
7628
7629 Don't publish debugger-only interfaces to other modules.
7630 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7631 (verify_bytepos, count_markers): Move decls to the only modules
7632 that need them.
7633 * region-cache.h (pp_cache): Likewise.
7634 * window.h (check_all_windows): Likewise.
7635 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7636
7637 * sysdep.c (croak): Now static, if
7638 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7639 * syssignal.h (croak): Declare only if not static.
7640
7641 * alloc.c (refill_memory_reserve): Now static if
7642 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7643 * lisp.h (refill_memory_reserve): Declare only if not static.
7644
7645 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7646 Define only if USE_LUCID.
7647
7648 * xrdb.c (x_customization_string, x_rm_string): Now static.
7649
7650 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7651 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7652
7653 * xdisp.c (draw_row_with_mouse_face): Now static.
7654 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7655
7656 * window.h (check_all_windows): Mark externally visible.
7657
7658 * window.c (window_deletion_count): Now static.
7659
7660 * undo.c: Make symbols static if they're not exported.
7661 (last_undo_buffer, last_boundary_position, pending_boundary):
7662 Now static.
7663
7664 * textprop.c (interval_insert_behind_hooks): Now static.
7665 (interval_insert_in_front_hooks): Likewise.
7666
7667 * term.c: Make symbols static if they're not exported.
7668 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7669 (max_frame_lines, tty_set_terminal_modes):
7670 (tty_reset_terminal_modes, tty_turn_off_highlight):
7671 (get_tty_terminal): Now static.
7672 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7673 * termhooks.h (term_mouse_moveto): Do not declare if
7674 HAVE_WINDOW_SYSTEM.
7675 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7676 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7677
7678 * sysdep.c: Make symbols static if they're not exported.
7679 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7680 Now static.
7681 (sigprocmask_set, full_mask): Remove; unused.
7682 (wait_debugging): Mark as visible.
7683 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7684 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7685
7686 * syntax.c (syntax_temp): Define only if !__GNUC__.
7687
7688 * sound.c (current_sound_device, current_sound): Now static.
7689
7690 * search.c (searchbufs, searchbuf_head): Now static.
7691
7692 * scroll.c (scroll_cost): Remove; unused.
7693 * dispextern.h (scroll_cost): Remove decl.
7694
7695 * region-cache.h (pp_cache): Mark as externally visible.
7696
7697 * process.c: Make symbols static if they're not exported.
7698 (process_tick, update_tick, create_process, chan_process):
7699 (Vprocess_alist, proc_buffered_char, datagram_access):
7700 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7701 (deactivate_process): Mark defn as static, as well as decl.
7702 * lisp.h (create_process): Remove decl.
7703 * process.h (chan_process, Vprocess_alist): Remove decls.
7704
7705 * print.c: Make symbols static if they're not exported.
7706 (print_depth, new_backquote_output, being_printed, print_buffer):
7707 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7708 (print_interval, print_number_index, initial_stderr_stream):
7709 Now static.
7710 * lisp.h (Fprinc): Remove decl.
7711 (debug_output_compilation_hack): Mark as externally visible.
7712
7713 * sysdep.c (croak): Move decl from here to syssignal.h.
7714 * syssignal.h (croak): Put it here, so the API can be checked when
7715 'croak' is called from dissociate_if_controlling_tty.
7716
7717 * minibuf.c: Make symbols static if they're not exported.
7718 (minibuf_save_list, choose_minibuf_frame): Now static.
7719 * lisp.h (choose_minibuf_frame): Remove decl.
7720
7721 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7722
7723 * lread.c: Make symbols static if they're not exported.
7724 (read_objects, initial_obarray, oblookup_last_bucket_number):
7725 Now static.
7726 (make_symbol): Remove; unused.
7727 * lisp.h (initial_obarray, make_symbol): Remove decls.
7728
7729 * keyboard.c: Make symbols static if they're not exported.
7730 (single_kboard, recent_keys_index, total_keys, recent_keys):
7731 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7732 (this_single_command_key_start, echoing, last_auto_save):
7733 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7734 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7735 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7736 (Vlispy_mouse_stem, double_click_count):
7737 Now static.
7738 (force_auto_save_soon): Define only if SIGDANGER.
7739 (ignore_mouse_drag_p): Now static if
7740 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7741 (print_help): Remove; unused.
7742 (stop_character, last_timer_event): Mark as externally visible.
7743 * keyboard.h (ignore_mouse_drag_p): Declare only if
7744 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7745 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7746 * lisp.h (echoing): Remove decl.
7747 (force_auto_save_soon): Declare only if SIGDANGER.
7748 * xdisp.c (redisplay_window): Simplify code, to make it more
7749 obvious that ignore_mouse_drag_p is not accessed if !defined
7750 USE_GTK && !defined HAVE_NS.
7751
7752 * intervals.c: Make symbols static if they're not exported.
7753 (merge_properties_sticky, merge_interval_right, delete_interval):
7754 Now static.
7755 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7756
7757 * insdel.c: Make symbols static if they're not exported.
7758 However, leave prepare_to_modify_buffer alone. It's never
7759 called from outside this function, but that appears to be a bug.
7760 (combine_after_change_list, combine_after_change_buffer):
7761 (adjust_after_replace, signal_before_change): Now static.
7762 (adjust_after_replace_noundo): Remove; unused.
7763 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7764 (signal_before_change): Remove decls.
7765
7766 * indent.c (val_compute_motion, val_vmotion): Now static.
7767
7768 * image.c: Make symbols static if they're not exported.
7769 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7770 if USE_GTK.
7771 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7772 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7773
7774 * fringe.c (standard_bitmaps): Now static.
7775 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7776
7777 * frame.c: Make symbols static if they're not exported.
7778 (x_report_frame_params, make_terminal_frame): Now static.
7779 (get_frame_param): Now static, unless HAVE_NS.
7780 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7781 (x_get_resource_string): Remove; not used.
7782 * frame.h (make_terminal_frame, x_report_frame_params):
7783 (x_get_resource_string); Remove decls.
7784 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7785 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7786
7787 * font.c, fontset.c: Make symbols static if they're not exported.
7788 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7789 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7790 * font.c (font_close_object): Now static.
7791 * font.h (font_close_object): Remove.
7792 * fontset.c (FONTSET_OBJLIST): Remove.
7793 (free_realized_fontset) #if-0 the body, which does nothing.
7794 (face_suitable_for_char_p): #if-0, as it's never called.
7795 * fontset.h (face_suitable_for_char_p): Remove decl.
7796 * xfaces.c (face_at_string_position):
7797 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7798 since 0 is always ASCII.
7799
7800 * fns.c (weak_hash_tables): Now static.
7801
7802 * fileio.c: Make symbols static if they're not exported.
7803 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7804 (Vwrite_region_annotation_buffers): Now static.
7805
7806 * eval.c: Make symbols static if they're not exported.
7807 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7808 * lisp.h (backtrace_list): Remove decl.
7809
7810 * emacs.c: Make symbols static if they're not exported.
7811 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7812 (fatal_error_code, fatal_error_signal_hook, standard_args):
7813 Now static.
7814 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7815 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7816 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7817 * lisp.h (fatal_error_signal_hook): Remove decl.
7818 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7819
7820 * editfns.c: Move a (normally-unused) function to its only use.
7821 * editfns.c, lisp.h (get_operating_system_release): Remove.
7822 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7823 worth the hassle of breaking this out.
7824
7825 * xterm.c: Make symbols static if they're not exported.
7826 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7827 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7828 (x_destroy_window, x_delete_display):
7829 Now static.
7830 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7831 (x_mouse_leave): Remove; unused.
7832 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7833 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7834 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7835 Remove decls.
7836 (x_mouse_leave): Declare only if WINDOWSNT.
7837 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7838 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7839 USE_X_TOOLKIT.
7840
7841 * ftxfont.c: Make symbols static if they're not exported.
7842 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7843 HAVE_FREETYPE.
7844 * font.h (ftxfont_driver): Likewise.
7845
7846 * xfns.c: Make symbols static if they're not exported.
7847 (x_last_font_name, x_display_info_for_name):
7848 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7849 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7850 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7851 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7852 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7853 (last_show_tip_args): Now static.
7854 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7855 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7856 (x_screen_planes): Remove; unused.
7857 * dispextern.h (x_screen_planes): Remove decl.
7858
7859 * dispnew.c: Make symbols static if they're not exported.
7860 * dispextern.h (redraw_garbaged_frames, scrolling):
7861 (increment_row_positions): Remove.
7862 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7863 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7864 Now static.
7865 (redraw_garbaged_frames): Remove; unused.
7866
7867 * xfaces.c: Make symbols static if they're not exported.
7868 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7869 Remove decls.
7870 * xterm.h (defined_color): Remove decls.
7871 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7872 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7873 (menu_face_changed_default, defined_color, free_realized_face):
7874 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7875 (ascii_face_of_lisp_face): Remove; unused.
7876
7877 * xdisp.c: Make symbols static if they're not exported.
7878 * dispextern.h (scratch_glyph_row, window_box_edges):
7879 (glyph_to_pixel_coords, set_cursor_from_row):
7880 (get_next_display_element, set_iterator_to_next):
7881 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7882 (show_mouse_face): Remove decls
7883 * frame.h (message_buf_print): Likewise.
7884 * lisp.h (pop_message, set_message, check_point_in_composition):
7885 Likewise.
7886 * xterm.h (set_vertical_scroll_bar): Likewise.
7887 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7888 (message_buf_print, scratch_glyph_row, displayed_buffer):
7889 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7890 (get_next_display_element, show_mouse_face, window_box_edges):
7891 (frame_to_window_pixel_xy, check_point_in_composition):
7892 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7893 (glyph_to_pixel_coords): Remove; unused.
7894
7895 * dired.c (file_name_completion): Now static.
7896
7897 * dbusbind.c (xd_in_read_queued_messages): Now static.
7898
7899 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7900 * data.c (circular_list_error): Remove.
7901
7902 * commands.h (last_point_position, last_point_position_buffer):
7903 (last_point_position_window): Remove decls.
7904 * keyboard.c: Make these variables static.
7905
7906 * coding.h (coding, code_convert_region, encode_coding_gap):
7907 Remove decls.
7908 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7909 (iso_code_class, detect_coding, code_convert_region): Now static.
7910 (encode_coding_gap): Remove; unused.
7911
7912 * chartab.c (chartab_chars, chartab_bits): Now static.
7913
7914 * charset.h (charset_iso_8859_1): Remove decl.
7915 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7916 Now static.
7917
7918 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7919 * ccl.c (Vccl_program_table): Now static.
7920 (check_ccl_update): Remove; unused.
7921
7922 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7923 * category.h: ... from here.
7924 * category.c (check_category_table, set_category_set): Now static.
7925
7926 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7927 * lisp.h: Remove these decls.
7928
7929 * buffer.c (buffer_count): Remove unused var.
7930
7931 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7932 so that it's not optimized away.
7933 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7934 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7935 exported only to the debugger.
7936
7937 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7938 * atimer.h (run_all_atimers): Remove; not exported.
7939
7940 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7941 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7942 was inaccessible from Lisp.
7943 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7944 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7945
7946 alloc.c: Import and export fewer symbols, and remove unused items.
7947 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7948 is defined.
7949 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7950 it's not optimized away by whole-program optimization.
7951 (message_enable_multibyte, free_misc): Remove.
7952 (catchlist, handlerlist, mark_backtrace):
7953 Declare only if BYTE_MARK_STACK.
7954 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7955 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7956 (message_enable_multibyte): Remove decl.
7957 (free_misc, interval_free_list, float_block, float_block_index):
7958 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7959 (cons_free_list, last_marked_index):
7960 Now static.
7961 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7962 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7963 (mark_backtrace): Define only if BYTE_MARK_STACK.
7964 * xdisp.c (message_enable_multibyte): Now static.
7965
7966 Declare Lisp_Object Q* variables to be 'static' if not exported.
7967 This makes it easier for human readers (and static analyzers)
7968 to see whether these variables are used from other modules.
7969 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7970 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7971 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7972 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7973 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7974 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7975 * xmenu.c, xselect.c:
7976 Declare Q* vars static if they are not used in other modules.
7977 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7978 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7979 Remove decls of unexported vars.
7980 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7981
7982 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7983
7984 Make Emacs functions such as Fatom 'static' by default.
7985 This makes it easier for human readers (and static analyzers)
7986 to see whether these functions can be called from other modules.
7987 DEFUN now defines a static function. To make the function external
7988 so that it can be used in other C modules, use the new macro DEFUE.
7989 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7990 (Finit_image_library):
7991 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7992 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7993 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7994 Remove decls, since these functions are now static.
7995 (Funintern, Fget_internal_run_time): New decls, since these functions
7996 were already external.
7997
7998 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7999 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8000 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8001 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8002 * keyboard.c, keymap.c, lread.c:
8003 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8004 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8005 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8006 Mark functions with DEFUE instead of DEFUN,
8007 if they are used in other modules.
8008 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8009 decls for now-static functions.
8010 * buffer.h (Fdelete_overlay): Remove decl.
8011 * callproc.c (Fgetenv_internal): Mark as internal.
8012 * composite.c (Fremove_list_of_text_properties): Remove decl.
8013 (Fcomposition_get_gstring): New forward static decl.
8014 * composite.h (Fcomposite_get_gstring): Remove decl.
8015 * dired.c (Ffile_attributes): New forward static decl.
8016 * doc.c (Fdocumntation_property): New forward static decl.
8017 * eval.c (Ffetch_bytecode): New forward static decl.
8018 (Funintern): Remove extern decl; now in .h file where it belongs.
8019 * fileio.c (Fmake_symbolic_link): New forward static decl.
8020 * image.c (Finit_image_library): New forward static decl.
8021 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8022 * intervals.h (Fprevious_property_change):
8023 (Fremove_list_of_text_properties): Remove decls.
8024 * keyboard.c (Fthis_command_keys): Remove decl.
8025 (Fcommand_execute): New forward static decl.
8026 * keymap.c (Flookup_key): New forward static decl.
8027 (Fcopy_keymap): Now static.
8028 * keymap.h (Flookup_key): Remove decl.
8029 * process.c (Fget_process): New forward static decl.
8030 (Fprocess_datagram_address): Mark as internal.
8031 * syntax.c (Fsyntax_table_p): New forward static decl.
8032 (skip_chars): Remove duplicate decl.
8033 * textprop.c (Fprevious_property_change): New forward static decl.
8034 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8035 Now internal.
8036 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8037 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8038
8039 * editfns.c (Fformat): Remove unreachable code.
8040
8041 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8042
8043 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8044 change. (Bug#8496)
8045
8046 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8047
8048 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8049 when at ZV. (Bug#8487)
8050
8051 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8052
8053 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8054 (Bug#8437)
8055 * keyboard.c (parse_tool_bar_item): Likewise.
8056 * sound.c (sound_cleanup, alsa_close): Likewise.
8057 * termcap.c (tgetent): Likewise.
8058 * xfns.c (x_default_font_parameter): Likewise.
8059 * xsettings.c (read_and_apply_settings): Likewise.
8060
8061 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8062 (overrun_check_free): Protoize.
8063
8064 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8065
8066 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8067 since callers should never pass a negative size.
8068 Change the signature to match that of plain 'read' and 'write'; see
8069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8070 * lisp.h: Update prototypes of emacs_write and emacs_read.
8071
8072 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8073
8074 * xdisp.c (redisplay_window): Don't try to determine the character
8075 position of the scroll margin if the window start point w->startp
8076 is outside the buffer's accessible region. (Bug#8468)
8077
8078 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8079
8080 Fix write-region and its subroutines for buffers > 2GB.
8081 * fileio.c (a_write, e_write): Modify declaration of arguments and
8082 local variables to support buffers larger than 2GB.
8083 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8084
8085 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8086 argument, local variables, and return value.
8087
8088 * lisp.h: Update prototypes of emacs_write and emacs_read.
8089
8090 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8091
8092 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8093
8094 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8095
8096 Fix more problems found by GCC 4.6.0's static checks.
8097
8098 * xdisp.c (vmessage): Use a better test for character truncation.
8099
8100 * charset.c (load_charset_map): <, not <=, for optimization,
8101 and to avoid potential problems with integer overflow.
8102 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8103 * casetab.c (set_identity, shuffle): Likewise.
8104 * editfns.c (Fformat): Likewise.
8105 * syntax.c (skip_chars): Likewise.
8106
8107 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8108 This also lets GCC 4.6.0 generate slightly better loop code.
8109
8110 * callint.c (Fcall_interactively): <, not <=, for optimization.
8111 (Fcall_interactively): Count the number of arguments produced,
8112 not the number of arguments given. This is simpler and lets GCC
8113 4.6.0 generate slightly better code.
8114
8115 * ftfont.c: Distingish more carefully between FcChar8 and char.
8116 The previous code passed unsigned char * to a functions like
8117 strlen and xstrcasecmp that expect char *, which does not
8118 conform to the C standard.
8119 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8120 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8121 char * when the C standard requires it.
8122
8123 * keyboard.c (read_char): Remove unused var.
8124
8125 * eval.c: Port to Windows vsnprintf (Bug#8435).
8126 Include <limits.h>.
8127 (SIZE_MAX): Define if the headers do not.
8128 (verror): Do not give up if vsnprintf returns a negative count.
8129 Instead, grow the buffer. This ports to Windows vsnprintf, which
8130 does not conform to C99. Problem reported by Eli Zaretskii.
8131 Also, simplify the allocation scheme, by avoiding the need for
8132 calling realloc, and removing the ALLOCATED variable.
8133
8134 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8135
8136 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8137 But keep the doprint source code for now, as we might revamp it
8138 and use it again (Bug#8435).
8139 * lisp.h (doprnt): Remove.
8140 * Makefile.in (base_obj): Remove doprnt.o.
8141 * deps.mk (doprnt.o): Remove.
8142
8143 error: Print 32- and 64-bit integers portably (Bug#8435).
8144 Without this change, on typical 64-bit hosts error ("...%d...", N)
8145 was used to print both 32- and 64-bit integers N, which relied on
8146 undefined behavior.
8147 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8148 * lisp.h (error, verror): Mark as printf-like functions.
8149 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8150 Report overflow in size calculations when allocating printf buffer.
8151 Do not truncate output string at its first null byte.
8152 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8153 Truncate the output at a character boundary, since vsnprintf does not
8154 do that.
8155 * charset.c (check_iso_charset_parameter): Convert internal
8156 character to string before calling 'error', since %c now has the
8157 printf meaning.
8158 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8159 overflow when computing char to be passed to 'error'. Do not
8160 pass Lisp_Object to 'error'; pass the integer instead.
8161 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8162 formatted with plain %d.
8163
8164 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8165
8166 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8167
8168 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8169
8170 * xterm.c (x_catch_errors): Remove duplicate declaration.
8171
8172 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8173
8174 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8175
8176 2011-04-10 Jim Meyering <meyering@redhat.com>
8177
8178 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8179 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8180 return ssize_t not "int", and use size_t as the buffer length.
8181 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8182 * gnutls.h: Update declarations.
8183 * process.c (read_process_output): Use ssize_t, to match.
8184 (send_process): Likewise.
8185
8186 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8187
8188 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8189
8190 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8191
8192 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8193 Use unsigned char, to match FcChar8 type definition.
8194
8195 * xterm.c (handle_one_xevent):
8196 * xmenu.c (create_and_show_popup_menu):
8197 * xselect.c (x_decline_selection_request)
8198 (x_reply_selection_request): Avoid type-punned deref of X events.
8199
8200 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8201
8202 Fix some uses of `int' instead of EMACS_INT.
8203 * search.c (string_match_1, fast_string_match)
8204 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8205 (scan_buffer, find_next_newline_no_quit)
8206 (find_before_next_newline, search_command, Freplace_match)
8207 (Fmatch_data): Make some `int' variables be EMACS_INT.
8208
8209 * xdisp.c (display_count_lines): 3rd argument and return value now
8210 EMACS_INT. All callers changed.
8211 (pint2hrstr): Last argument is now EMACS_INT.
8212
8213 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8214 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8215 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8216 (decode_coding_utf_16, decode_coding_emacs_mule)
8217 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8218 (decode_coding_ccl, decode_coding_charset)
8219 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8220 (decode_coding_iso_2022, decode_coding_emacs_mule)
8221 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8222 <char_offset, last_offset>: Declare EMACS_INT.
8223 (encode_coding_utf_8, encode_coding_utf_16)
8224 (encode_coding_emacs_mule, encode_invocation_designation)
8225 (encode_designation_at_bol, encode_coding_iso_2022)
8226 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8227 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8228 Declare EMACS_INT.
8229 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8230 (encode_invocation_designation): Last argument P_NCHARS is now
8231 EMACS_INT.
8232 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8233 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8234
8235 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8236 All users changed.
8237
8238 * ccl.c (Fccl_execute_on_string): Declare some variables
8239 EMACS_INT.
8240
8241 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8242
8243 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8244
8245 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8246
8247 * process.c (Fformat_network_address): Doc fix.
8248
8249 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8250
8251 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8252
8253 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8254
8255 * keyboard.c (read_char): Call Lisp function help-form-show,
8256 instead of using internal_with_output_to_temp_buffer.
8257 (Qhelp_form_show): New var.
8258 (syms_of_keyboard): Use DEFSYM macro.
8259
8260 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8261
8262 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8263
8264 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8265
8266 * process.c (Flist_processes): Remove to Lisp.
8267 (list_processes_1): Delete.
8268
8269 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8270
8271 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8272
8273 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8274
8275 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8276
8277 Fix more problems found by GCC 4.6.0's static checks.
8278
8279 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8280
8281 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8282
8283 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8284
8285 * xdisp.c (vmessage): Mark as a printf-like function.
8286
8287 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8288
8289 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8290
8291 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8292 printf-like functions.
8293 (tiff_load): Add casts to remove these marks before passing them
8294 to system-supplied API.
8295
8296 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8297
8298 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8299 This avoids several warnings with gcc -Wstrict-overflow.
8300 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8301 directly, rather than having caller test rule sign. This avoids
8302 some unnecessary tests.
8303 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8304 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8305 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8306
8307 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8308 (xfont_open): Avoid unnecessary tests.
8309
8310 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8311
8312 * composite.h, composite.c (composition_gstring_put_cache):
8313 Use EMACS_INT, not int, for length.
8314
8315 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8316 breaking out part of COMPOSITION_DECODE_RULE.
8317 (COMPOSITION_DECODE_RULE): Use it.
8318 * composite.c (get_composition_id): Remove unused local vars,
8319 by using the new macro.
8320
8321 * textprop.c (set_text_properties_1): Change while to do-while,
8322 since the condition is always true at first.
8323
8324 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8325 (interval_deletion_adjustment): Return unsigned value.
8326 All uses changed.
8327
8328 * process.c (list_processes_1, create_pty, read_process_output):
8329 (exec_sentinel): Remove vars that were set but not used.
8330 (create_pty): Remove unnecessary "volatile"s.
8331 (Fnetwork_interface_info): Avoid possibility of int overflow.
8332 (read_process_output): Do adaptive read buffering even if carryover.
8333 (read_process_output): Simplify nbytes computation if buffered.
8334
8335 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8336
8337 * syntax.c (scan_words): Remove var that was set but not used.
8338 (update_syntax_table): Use unsigned instead of int.
8339
8340 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8341 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8342 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8343
8344 * print.c (print_error_message): Avoid int overflow.
8345
8346 * font.c (font_list_entities): Redo for clarity,
8347 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8348
8349 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8350 (font_score): Avoid potential overflow in diff calculation.
8351
8352 * fns.c (substring_both): Remove var that is set but not used.
8353 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8354
8355 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8356
8357 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8358 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8359 can always succeed if overflow has undefined behavior.
8360
8361 * search.c (boyer_moore, wordify): Remove vars set but not used.
8362 (wordify): Omit three unnecessary tests.
8363
8364 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8365 All callers changed. This avoids the need for an unused var.
8366
8367 * casefiddle.c (casify_region): Remove var that is set but not used.
8368
8369 * dired.c (file_name_completion): Remove var that is set but not used.
8370
8371 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8372
8373 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8374 (Finsert_file_contents): Remove unnecessary code checking fd.
8375
8376 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8377 Check for integer overflow on size calculations.
8378
8379 * buffer.c (Fprevious_overlay_change): Remove var that is set
8380 but not used.
8381
8382 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8383 Remove vars that are set but not used.
8384 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8385 (timer_check_2): Mark vars as initialized.
8386
8387 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8388
8389 * image.c (lookup_image): Remove var that is set but not used.
8390 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8391
8392 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8393 that are set but not used.
8394
8395 * xfns.c (make_invisible_cursor): Don't return garbage
8396 if XCreateBitmapFromData fails (Bug#8410).
8397
8398 * xselect.c (x_get_local_selection, x_handle_property_notify):
8399 Remove vars that are set but not used.
8400
8401 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8402 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8403
8404 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8405 Remove var that is set but not used.
8406 (scroll_bar_windows_size): Now size_t, not int.
8407 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8408 Check for overflow.
8409
8410 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8411 (map_tty_color) [!defined MSDOS]: Likewise.
8412
8413 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8414
8415 * coding.c: Remove vars that are set but not used.
8416 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8417 All callers changed.
8418 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8419 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8420 (decode_coding_charset): Remove vars that are set but not used.
8421
8422 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8423 that is set but not used.
8424
8425 * print.c (print_object): Remove var that is set but not used.
8426
8427 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8428 The gnulib version avoids calling malloc in the usual case,
8429 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8430 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8431 * filelock.c (current_lock_owner): Likewise.
8432 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8433 * sysdep.c: Include allocator.h, careadlinkat.h.
8434 (emacs_no_realloc_allocator): New static constant.
8435 (emacs_readlink): New function.
8436 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8437 ../lib/careadlinkat.h.
8438
8439 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8440
8441 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8442 first non-nil return value).
8443
8444 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8445
8446 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8447 if not defined (Bug#8403).
8448
8449 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8450
8451 * xdisp.c (display_count_lines): Remove parameter `start',
8452 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8453 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8454 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8455 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8456 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8457 and thereabouts. All callers changed.
8458 (get_per_char_metric): Remove parameter `f', unused since
8459 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8460
8461 2011-04-02 Jim Meyering <meyering@redhat.com>
8462
8463 do not dereference NULL upon failed strdup
8464 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8465 (ns_get_family): Likewise.
8466
8467 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8468
8469 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8470
8471 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8472
8473 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8474 later (Bug#8403).
8475
8476 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8477
8478 Add lexical binding.
8479
8480 * window.c (Ftemp_output_buffer_show): New fun.
8481 (Fsave_window_excursion):
8482 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8483
8484 * lread.c (lisp_file_lexically_bound_p): New function.
8485 (Fload): Bind Qlexical_binding.
8486 (readevalloop): Remove `evalfun' arg.
8487 Bind Qinternal_interpreter_environment.
8488 (Feval_buffer): Bind Qlexical_binding.
8489 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8490 Mark as dynamic.
8491 (syms_of_lread): Declare `lexical-binding'.
8492
8493 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8494
8495 * keyboard.c (eval_dyn): New fun.
8496 (menu_item_eval_property): Use it.
8497
8498 * image.c (parse_image_spec): Use Ffunctionp.
8499
8500 * fns.c (concat, mapcar1): Accept byte-code-functions.
8501
8502 * eval.c (Fsetq): Handle lexical vars.
8503 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8504 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8505 (FletX, Flet): Obey lexical binding.
8506 (Fcommandp): Handle closures.
8507 (Feval): New `lexical' arg.
8508 (eval_sub): New function extracted from Feval. Use it almost
8509 everywhere where Feval was used. Look up vars in lexical env.
8510 Handle closures.
8511 (Ffunctionp): Move from subr.el.
8512 (Ffuncall): Handle closures.
8513 (apply_lambda): Remove `eval_flags'.
8514 (funcall_lambda): Handle closures and new byte-code-functions.
8515 (Fspecial_variable_p): New function.
8516 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8517 but without exporting it to Lisp.
8518
8519 * doc.c (Fdocumentation, store_function_docstring):
8520 * data.c (Finteractive_form): Handle closures.
8521
8522 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8523 interactive spec.
8524
8525 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8526 New byte-codes.
8527 (exec_byte_code): New function extracted from Fbyte_code to handle new
8528 calling convention for byte-code-functions. Add new byte-codes.
8529
8530 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8531
8532 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8533
8534 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8535
8536 * xdisp.c (redisplay_internal): Fix prototype.
8537
8538 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8539
8540 * xdisp.c (SCROLL_LIMIT): New macro.
8541 (try_scrolling): Use it when setting scroll_limit.
8542 Limit scrolling to 100 screen lines.
8543 (redisplay_window): Even when falling back on "recentering",
8544 position point in the window according to scroll-conservatively,
8545 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8546
8547 (try_scrolling): When point is above the window, allow searching
8548 as far as scroll_max, or one screenful, to compute vertical
8549 distance from PT to the scroll margin position. This prevents
8550 try_scrolling from unnecessarily failing when
8551 scroll-conservatively is set to a value slightly larger than the
8552 window height. Clean up the case of PT below the margin at bottom
8553 of window: scroll_max can no longer be INT_MAX. When aggressive
8554 scrolling is in use, don't let point enter the opposite scroll
8555 margin as result of the scroll.
8556 (syms_of_xdisp) <scroll-conservatively>: Document the
8557 threshold of 100 lines for never-recentering scrolling.
8558
8559 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8560
8561 * dispextern.h (move_it_by_lines):
8562 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8563 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8564 (message_log_check_duplicate): Remove parameters `prev_bol' and
8565 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8566 (redisplay_internal): Remove parameter `preserve_echo_area',
8567 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8568
8569 * indent.c (Fvertical_motion):
8570 * window.c (window_scroll_pixel_based, Frecenter):
8571 Don't pass `need_y_p' to `move_it_by_lines'.
8572
8573 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8574
8575 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8576 steal a few bits to be more compact.
8577 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8578 Remove unneeded casts.
8579
8580 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8581
8582 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8583
8584 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8585 binding" message (bug#7967).
8586
8587 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8588
8589 Fix more problems found by GCC 4.6.0's static checks.
8590
8591 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8592 Remove unused local var.
8593
8594 * editfns.c (Fmessage_box): Remove unused local var.
8595
8596 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8597 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8598 Omit unused local vars.
8599 * window.c (shrink_windows): Omit unused local var.
8600 * menu.c (digest_single_submenu): Omit unused local var.
8601 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8602 Omit unused local var.
8603
8604 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8605 Don't assume string length fits in int.
8606 (keyremap_step, read_key_sequence): Use size_t for sizes.
8607 (read_key_sequence): Don't check last_real_key_start redundantly.
8608
8609 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8610 instead of alloca (Bug#8344).
8611
8612 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8613 (Fbacktrace_frame): Don't assume nframes fits in int.
8614
8615 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8616
8617 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8618 concerns.
8619
8620 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8621
8622 * cm.c (calccost): Turn while-do into do-while, for clarity.
8623
8624 * keyboard.c (syms_of_keyboard): Use the same style as later
8625 in this function when indexing through an array. This also
8626 works around GCC bug 48267.
8627
8628 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8629
8630 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8631
8632 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8633 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8634
8635 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8636 This avoids undefined behavior on integer overflow, and is a bit
8637 more convenient anyway since it is compared to a size_t variable.
8638
8639 Variadic C functions now count arguments with size_t, not int.
8640 This avoids an unnecessary limitation on 64-bit machines, which
8641 caused (substring ...) to crash on large vectors (Bug#8344).
8642 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8643 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8644 All variadic functions and their callers changed accordingly.
8645 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8646 * data.c (arith_driver, float_arith_driver): Likewise.
8647 * editfns.c (general_insert_function): Likewise.
8648 * eval.c (struct backtrace.nargs, interactive_p)
8649 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8650 (funcall_lambda, mark_backtrace): Likewise.
8651 * fns.c (concat): Likewise.
8652 * frame.c (x_set_frame_parameters): Likewise.
8653 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8654 0 if not found, not -1. All callers changed.
8655
8656 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8657 (stack_copy_size): Now size_t, not int.
8658 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8659
8660 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8661
8662 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8663 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8664 All callers changed.
8665
8666 * lisp.h (multibyte_char_to_unibyte):
8667 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8668 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8669 * character.h (CHAR_TO_BYTE8):
8670 * cmds.c (internal_self_insert):
8671 * editfns.c (general_insert_function):
8672 * keymap.c (push_key_description):
8673 * search.c (Freplace_match):
8674 * xdisp.c (message_dolog, set_message_1): All callers changed.
8675
8676 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8677
8678 * keyboard.c (safe_run_hook_funcall): New function.
8679 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8680 don't set the hook to nil, but remove the offending function instead.
8681 (Qcommand_hook_internal): Remove, unused.
8682 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8683 Vcommand_hook_internal.
8684
8685 * eval.c (enum run_hooks_condition): Remove.
8686 (funcall_nil, funcall_not): New functions.
8687 (run_hook_with_args): Call each function through a `funcall' argument.
8688 Remove `cond' argument, now redundant.
8689 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8690 (Frun_hook_with_args_until_failure): Adjust accordingly.
8691 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8692
8693 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8694
8695 * dispextern.h (string_buffer_position): Remove declaration.
8696
8697 * print.c (strout): Remove parameter `multibyte', unused since
8698 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8699
8700 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8701 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8702 All callers changed.
8703
8704 * w32.c (_wsa_errlist): Use braces for struct initializers.
8705
8706 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8707 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8708 All callers changed.
8709 (string_buffer_position): Likewise. Also, make static (it's never
8710 used outside xdisp.c).
8711 (cursor_row_p): Remove parameter `w', unused since
8712 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8713 (decode_mode_spec): Remove parameter `precision', introduced during
8714 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8715 All callers changed.
8716
8717 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8718
8719 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8720
8721 2011-03-27 Anders Lindgren <andlind@gmail.com>
8722
8723 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8724 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8725 (ns_update_auto_hide_menu_bar): New functions.
8726 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8727 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8728 ns_constrain_all_frames.
8729 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8730 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8731
8732 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8733
8734 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8735
8736 2011-03-27 Glenn Morris <rgm@gnu.org>
8737
8738 * syssignal.h: Replace RETSIGTYPE with void.
8739 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8740 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8741 Replace SIGTYPE with void everywhere.
8742 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8743 * s/template.h (SIGTYPE): Remove commented out definition.
8744
8745 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8746
8747 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8748 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8749
8750 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8751
8752 * w32.c (read_unc_volume): Use parameter `henum', instead of
8753 global variable `wget_enum_handle'.
8754
8755 * keymap.c (describe_vector): Remove parameters `indices' and
8756 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8757 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8758
8759 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8760
8761 * keyboard.c (timer_check): Remove parameter `do_it_now',
8762 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8763 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8764 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8765
8766 * keyboard.c (read_char):
8767 * w32menu.c (w32_menu_display_help):
8768 * xmenu.c (show_help_event, menu_help_callback):
8769 Adjust calls to `show_help_echo'.
8770
8771 * gtkutil.c (xg_maybe_add_timer):
8772 * keyboard.c (readable_events):
8773 * process.c (wait_reading_process_output):
8774 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8775
8776 * insdel.c (adjust_markers_gap_motion):
8777 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8778 (gap_left, gap_right): Don't call it.
8779
8780 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8781
8782 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8783 incurred during fontification.
8784
8785 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8786
8787 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8788 (DEFVAR_PER_BUFFER): Don't pass it.
8789
8790 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8791 (scrolling_window): Don't pass it.
8792
8793 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8794
8795 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8796
8797 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8798 and `suffix'.
8799 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8800 of variables specific to SELinux and computation of `encoded_absname'.
8801
8802 * image.c (XPutPixel): Remove unused variable `height'.
8803
8804 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8805
8806 * unexw32.c (get_section_info): Remove unused variable `section'.
8807
8808 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8809 (system_process_attributes): Remove unused variable `sess'.
8810 (sys_read): Remove unused variable `err'.
8811
8812 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8813 (w32_wnd_proc): Remove unused variable `isdead'.
8814 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8815 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8816 (x_create_tip_frame): Remove unused variable `tem'.
8817
8818 * w32inevt.c (w32_console_read_socket):
8819 Remove unused variable `no_events'.
8820
8821 * w32term.c (x_draw_composite_glyph_string_foreground):
8822 Remove unused variable `width'.
8823
8824 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8825
8826 * w32term.c (x_set_glyph_string_clipping):
8827 Don't pass uninitialized region to CombineRgn.
8828
8829 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8830
8831 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8832 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8833 (Fx_close_connection): Remove unused variable `i'.
8834
8835 * w32font.c (w32font_draw): Return number of glyphs.
8836 (w32font_open_internal): Remove unused variable `i'.
8837 (w32font_driver): Add missing initializer.
8838
8839 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8840 (fill_in_menu): Remove unused variable `items_added'.
8841
8842 * w32term.c (last_mouse_press_frame): Remove static global variable.
8843 (w32_clip_to_row): Remove unused variable `f'.
8844 (x_delete_terminal): Remove unused variable `i'.
8845
8846 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8847 (NOTHING): Remove unused static global variable.
8848 (uniscribe_check_otf): Remove unused variable `table'.
8849 (uniscribe_font_driver): Add missing initializers.
8850
8851 2011-03-23 Julien Danjou <julien@danjou.info>
8852
8853 * term.c (Fsuspend_tty, Fresume_tty):
8854 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8855 * window.c (temp_output_buffer_show):
8856 * insdel.c (signal_before_change):
8857 * frame.c (Fhandle_switch_frame):
8858 * fileio.c (Fdo_auto_save):
8859 * emacs.c (Fkill_emacs):
8860 * editfns.c (save_excursion_restore):
8861 * cmds.c (internal_self_insert):
8862 * callint.c (Fcall_interactively):
8863 * buffer.c (Fkill_all_local_variables):
8864 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8865 Use Frun_hooks.
8866 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8867 unconditionally since it does the check itself.
8868
8869 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8870
8871 Fix more problems found by GCC 4.5.2's static checks.
8872
8873 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8874 the first time through the loop, since we know p0 < p1 then.
8875 This also avoids a gcc -Wstrict-overflow warning.
8876
8877 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8878 leading to a memory leak, possible in functions like
8879 load_charset_map_from_file that can allocate an unbounded number
8880 of objects (Bug#8318).
8881
8882 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8883 that could (at least in theory) be that large.
8884
8885 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8886 This is less likely to overflow, and avoids undefined behavior if
8887 overflow does occur. All callers changed. Use strtoul to scan
8888 for the unsigned long integer.
8889 (pint2hrstr): Simplify and tune code slightly.
8890 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8891
8892 * scroll.c (do_scrolling): Work around GCC bug 48228.
8893 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8894
8895 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8896 This also avoids a warning with gcc -Wstrict-overflow.
8897 (validate_x_resource_name): Simplify count usage.
8898 This also avoids a warning with gcc -Wstrict-overflow.
8899
8900 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8901 fail (Bug#8306).
8902
8903 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8904
8905 * process.c (Fmake_network_process): Use socklen_t, not int,
8906 where POSIX says socklen_t is required in portable programs.
8907 This fixes a porting bug on hosts like 64-bit HP-UX, where
8908 socklen_t is wider than int (Bug#8277).
8909 (Fmake_network_process, server_accept_connection):
8910 (wait_reading_process_output, read_process_output):
8911 Likewise.
8912
8913 * process.c: Rename or move locals to avoid shadowing.
8914 (list_processes_1, Fmake_network_process):
8915 (read_process_output_error_handler, exec_sentinel_error_handler):
8916 Rename or move locals.
8917 (Fmake_network_process): Define label "retry_connect" only if needed.
8918 (Fnetwork_interface_info): Fix pointer signedness.
8919 (process_send_signal): Add cast to avoid pointer signedness problem.
8920 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8921 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8922
8923 Make tparam.h and terminfo.c consistent.
8924 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8925 Include tparam.h instead, since it declares them.
8926 * cm.h (PC): Remove extern decl; tparam.h now does this.
8927 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8928 * terminfo.c: Include tparam.h, to check interfaces.
8929 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8930 (tparam): Adjust signature to match interface in tparam.h;
8931 this removes some undefined behavior. Check that outstring and len
8932 are zero, which they always are with Emacs.
8933 * tparam.h (PC, BC, UP): New extern decls.
8934
8935 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8936 (xftfont_open): Rename locals to avoid shadowing.
8937
8938 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8939 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8940 (OTF_TAG_SYM): Omit macro if not needed.
8941 (ftfont_list): Remove unused local.
8942 (get_adstyle_property, ftfont_pattern_entity):
8943 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8944 Rename locals to avoid shadowing.
8945
8946 * xfont.c (xfont_list_family): Mark var as initialized.
8947
8948 * xml.c (make_dom): Now static.
8949
8950 * composite.c (composition_compute_stop_pos): Rename local to
8951 avoid shadowing.
8952 (composition_reseat_it): Remove unused locals.
8953 (find_automatic_composition, composition_adjust_point): Likewise.
8954 (composition_update_it): Mark var as initialized.
8955 (find_automatic_composition): Mark vars as initialized,
8956 with a FIXME (Bug#8290).
8957
8958 character.h: Rename locals to avoid shadowing.
8959 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8960 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8961 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8962 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8963 to avoid shadowing.
8964
8965 * textprop.c (property_change_between_p): Remove; unused.
8966
8967 * intervals.c (interval_start_pos): Now static.
8968
8969 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8970
8971 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8972 Rename locals to avoid shadowing.
8973
8974 * sound.c (wav_play, au_play, Fplay_sound_internal):
8975 Fix pointer signedness.
8976 (alsa_choose_format): Remove unused local var.
8977 (wav_play): Initialize a variable to 0, to prevent undefined
8978 behavior (Bug#8278).
8979
8980 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8981
8982 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8983
8984 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8985 clobbering (Bug#8298).
8986 * sysdep.c (sys_subshell): Likewise.
8987 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8988
8989 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8990 This should get cleaned up, so that child_setup has the
8991 same signature on all platforms.
8992
8993 * callproc.c (call_process_cleanup): Now static.
8994 (relocate_fd): Rename locals to avoid shadowing.
8995
8996 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8997
8998 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8999 not to be necessary, and produces flickering.
9000
9001 2011-03-20 Glenn Morris <rgm@gnu.org>
9002
9003 * config.in: Remove file.
9004
9005 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9006
9007 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9008 are now in src/globals.h.
9009 (syms_of_minibuf): Remove spurious & from previous change.
9010
9011 2011-03-20 Leo Liu <sdl.web@gmail.com>
9012
9013 * minibuf.c (completing-read-function): New variable.
9014 (completing-read-default): Rename from completing-read.
9015 (completing-read): Call completing-read-function.
9016
9017 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9018
9019 * xfaces.c (Fx_load_color_file):
9020 Read color file from absolute filename (bug#8250).
9021
9022 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9023
9024 * makefile.w32-in: Update dependencies.
9025
9026 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9027
9028 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9029
9030 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9031
9032 Fix more problems found by GCC 4.5.2's static checks.
9033
9034 * process.c (make_serial_process_unwind, send_process_trap):
9035 (sigchld_handler): Now static.
9036
9037 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9038 That way, the code declares only the vars that it needs.
9039 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9040 * s/cygwin.h (PTY_ITERATION): Likewise.
9041 * s/darwin.h (PTY_ITERATION): Likewise.
9042 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9043
9044 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9045 * process.c (allocate_pty): Don't declare stb unless it's needed.
9046
9047 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9048 (CONSTANTLIM): Remove; unused.
9049 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9050 Define only if needed.
9051
9052 * unexelf.c (unexec): Name an expression,
9053 to avoid gcc -Wbad-function-cast warning.
9054 Use a different way to cause a compilation error if anyone uses
9055 n rather than nn, a way that does not involve shadowing.
9056 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9057
9058 * deps.mk (unexalpha.o): Remove; unused.
9059
9060 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9061 * unexec.h: New file.
9062 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9063 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9064 Depend on unexec.h.
9065 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9066 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9067 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9068 Change as necessary to match prototype in unexec.h.
9069
9070 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9071 shadowing.
9072 (back_comment, skip_chars): Mark vars as initialized.
9073
9074 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9075 Rename locals to avoid shadowing.
9076
9077 * lread.c (read1): Rewrite so as not to use empty "else".
9078 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9079
9080 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9081
9082 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9083 warning when compiling print.c.
9084
9085 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9086 instead of using an uninitialized var.
9087 (font_sort_entities): Mark var as initialized.
9088
9089 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9090
9091 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9092 pointers to constants.
9093 (font_parse_fcname): Remove unused vars.
9094 (font_delete_unmatched): Now static.
9095 (font_get_spec): Remove; unused.
9096 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9097 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9098 Rename or move locals to avoid shadowing.
9099
9100 * fns.c (require_nesting_list, require_unwind): Now static.
9101 (Ffillarray): Rename locals to avoid shadowing.
9102
9103 * floatfns.c (domain_error2): Define only if needed.
9104 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9105
9106 * alloc.c (mark_backtrace): Move decl from here ...
9107 * lisp.h: ... to here, so that it can be checked.
9108
9109 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9110 (Fdefvar): Rewrite so as not to use empty "else".
9111 (lisp_indirect_variable): Name an expression,
9112 to avoid gcc -Wbad-function-cast warning.
9113 (Fdefvar): Rename locals to avoid shadowing.
9114
9115 * callint.c (quotify_arg, quotify_args): Now static.
9116 (Fcall_interactively): Rename locals to avoid shadowing.
9117 Use const pointer when appropriate.
9118
9119 * lisp.h (get_system_name, get_operating_system_release):
9120 Move decls here, to check interfaces.
9121 * process.c (get_operating_system_release): Move decl to lisp.h.
9122 * xrdb.c (get_system_name): Likewise.
9123 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9124 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9125 some of which prompt warnings from gcc -Wbad-function-cast.
9126 (Fformat_time_string, Fencode_time, Finsert_char):
9127 (Ftranslate_region_internal, Fformat):
9128 Rename or remove local vars to avoid shadowing.
9129 (Ftranslate_region_internal): Mark var as initialized.
9130
9131 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9132 avoid shadowing.
9133
9134 * lisp.h (eassert): Check that the argument compiles, even if
9135 ENABLE_CHECKING is not defined.
9136
9137 * data.c (Findirect_variable): Name an expression, to avoid
9138 gcc -Wbad-function-cast warning.
9139 (default_value, arithcompare, arith_driver, arith_error): Now static.
9140 (store_symval_forwarding): Rename local to avoid shadowing.
9141 (Fmake_variable_buffer_local, Fmake_local_variable):
9142 Mark variables as initialized.
9143 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9144
9145 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9146 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9147 Rename locals to avoid shadowing.
9148 (mark_stack): Move local variables into the #ifdef region where
9149 they're used.
9150 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9151 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9152 needed otherwise.
9153 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9154 (GC_STRING_CHARS): Remove; not used.
9155 (Fmemory_limit): Cast sbrk's returned value to char *.
9156
9157 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9158 avoids undefined behavior in theory.
9159
9160 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9161
9162 Use functions, not macros, for up- and down-casing (Bug#8254).
9163 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9164 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9165 to use the following functions instead of these macros.
9166 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9167 EMACS_INT, since callers assume the returned value fits in int.
9168 (upcase1): Likewise, for UPCASE_TABLE.
9169 (uppercasep, lowercasep, upcase): New static inline functions.
9170 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9171 the race-condition problem in the old DOWNCASE.
9172
9173 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9174 Rename locals to avoid shadowing.
9175 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9176 (regex_compile, re_search_2, re_match_2_internal):
9177 Remove unused local vars.
9178 (FREE_VAR): Rewrite so as not to use empty "else",
9179 which gcc can warn about.
9180 (regex_compile, re_match_2_internal): Mark locals as initialized.
9181 (RETALLOC_IF): Define only if needed.
9182 (WORDCHAR_P): Likewise. This one is never needed, but is used
9183 only in a comment talking about a compiler bug, so put inside
9184 the #if 0 of that comment.
9185 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9186 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9187 Remove; unused.
9188
9189 * search.c (boyer_moore): Rename locals to avoid shadowing.
9190 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9191 (PREV_CHAR_BOUNDARY): Likewise.
9192
9193 * search.c (simple_search): Remove unused var.
9194
9195 * dired.c (compile_pattern): Move decl from here ...
9196 * lisp.h: ... to here, so that it can be checked.
9197 (struct re_registers): New forward decl.
9198
9199 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9200
9201 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9202 All uses changed.
9203 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9204 Rename locals to avoid shadowing.
9205 (Fvertical_motion): Mark locals as initialized.
9206
9207 * casefiddle.c (casify_object, casify_region): Now static.
9208 (casify_region): Mark local as initialized.
9209
9210 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9211
9212 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9213 New macros, so that the caller can use some names other than
9214 gcpro1, gcpro2, etc.
9215 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9216 of the new macros.
9217 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9218 argument, for consistency with GCPRO2_VAR, etc: it is now the
9219 prefix of the variable, not the variable itself. All uses
9220 changed.
9221 * dired.c (directory_files_internal, file_name_completion):
9222 Rename locals to avoid shadowing.
9223
9224 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9225 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9226 dired.c's scmp function, had undefined behavior.
9227 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9228 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9229 * buffer.h: ... to here, because these macros use current_buffer,
9230 and the new implementation with inline functions needs to have
9231 current_buffer in scope now, rather than later when the macros
9232 are used.
9233 (downcase, upcase1): New static inline functions.
9234 (DOWNCASE, UPCASE1): Reimplement using these functions.
9235 This avoids undefined behavior in expressions like
9236 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9237 from race conditions in accessing the global variables
9238 case_temp1 and case_temp2.
9239 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9240 * lisp.h (case_temp1, case_temp2): Remove their decls.
9241 * character.h (ASCII_CHAR_P): Move from here ...
9242 * lisp.h: ... to here, so that the inline functions mentioned
9243 above can use them.
9244
9245 * dired.c (directory_files_internal_unwind): Now static.
9246
9247 * fileio.c (file_name_as_directory, directory_file_name):
9248 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9249 Now static.
9250 (file_name_as_directory): Use const pointers when appropriate.
9251 (Fexpand_file_name): Likewise. In particular, newdir might
9252 point at constant storage, so make it a const pointer.
9253 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9254 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9255 signedness issues.
9256 (Fset_file_times, Finsert_file_contents, auto_save_error):
9257 Rename locals to avoid shadowing.
9258
9259 * minibuf.c (choose_minibuf_frame_1): Now static.
9260 (Ftry_completion, Fall_completions): Rename or remove locals
9261 to avoid shadowing.
9262
9263 * marker.c (bytepos_to_charpos): Remove; unused.
9264
9265 * lisp.h (verify_bytepos, count_markers): New decls,
9266 so that gcc does not warn that these functions aren't declared.
9267
9268 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9269 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9270 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9271 (copy_text): Remove unused local var.
9272
9273 * filelock.c (within_one_second): Now static.
9274 (lock_file_1): Rename local to avoid shadowing.
9275
9276 * buffer.c (fix_overlays_before): Mark locals as initialized.
9277 (fix_start_end_in_overlays): Likewise. This function should be
9278 simplified by using pointers-to-pointers, but that's a different
9279 matter.
9280 (switch_to_buffer_1): Now static.
9281 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9282 (report_overlay_modification): Rename locals to avoid shadowing.
9283
9284 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9285 Fix pointer signedness issue.
9286 (sys_subshell): Mark local as volatile if checking for lint,
9287 to suppress a gcc -Wclobbered warning that does not seem to be right.
9288 (MAXPATHLEN): Define only if needed.
9289
9290 * process.c (serial_open, serial_configure): Move decls from here ...
9291 * systty.h: ... to here, so that they can be checked.
9292
9293 * fns.c (get_random, seed_random): Move extern decls from here ...
9294 * lisp.h: ... to here, so that they can be checked.
9295
9296 * sysdep.c (reset_io): Now static.
9297 (wait_for_termination_signal): Remove; unused.
9298
9299 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9300 (copy_keymap_item, append_key, push_text_char_description):
9301 Now static.
9302 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9303 (DENSE_TABLE_SIZE): Remove; unused.
9304 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9305 (describe_map_tree):
9306 Rename locals to avoid shadowing.
9307
9308 * keyboard.c: Declare functions static if they are not used elsewhere.
9309 (echo_char, echo_dash, cmd_error, top_level_2):
9310 (poll_for_input, handle_async_input): Now static.
9311 (read_char, kbd_buffer_get_event, make_lispy_position):
9312 (make_lispy_event, make_lispy_movement, apply_modifiers):
9313 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9314 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9315 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9316 (read_key_sequence, read_char): Mark locals as initialized.
9317 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9318
9319 * keyboard.h (make_ctrl_char): New decl.
9320 (mark_kboards): Move decl here ...
9321 * alloc.c (mark_kboards): ... from here.
9322
9323 * lisp.h (force_auto_save_soon): New decl.
9324
9325 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9326 (DEFINE_DUMMY_FUNCTION): New macro.
9327 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9328 Use it.
9329 (main): Add casts to avoid warnings
9330 if GCC considers string literals to be constants.
9331
9332 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9333
9334 * dbusbind.c: Pointer signedness fixes.
9335 (xd_signature, xd_append_arg, xd_initialize):
9336 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9337 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9338 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9339 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9340
9341 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9342 if GCC considers string literals to be constants.
9343 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9344
9345 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9346
9347 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9348 (print_preprocess, print_object): New macro to fix last change.
9349
9350 * print.c (print_preprocess): Don't forget font objects.
9351
9352 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9353
9354 * emacs.c (USAGE3): Doc fixes.
9355
9356 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9357
9358 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9359 structure.
9360
9361 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9362
9363 * lisp.h (VWindow_system, Qfile_name_history):
9364 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9365 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9366 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9367
9368 * w32select.c: Don't #include "keyboard.h".
9369 (run_protected): Add extern declaration for waiting_for_input.
9370
9371 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9372 * w32console.c (detect_input_pending, read_input_pending)
9373 (encode_terminal_code):
9374 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9375 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9376 (w32_system_caret_y, Qfile_name_history):
9377 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9378 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9379 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9380 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9381 * w32proc.c (Qlocal, report_file_error):
9382 * w32term.c (Vwindow_system, updating_frame):
9383 * w32uniscribe.c (initialized, uniscribe_font_driver):
9384 Remove unneeded extern declarations.
9385
9386 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9387
9388 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9389
9390 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9391
9392 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9393 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9394 These macros can no longer be used for assignment.
9395
9396 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9397 Assign struct members directly, instead of using BUF_BEGV etc.
9398 (record_buffer_markers, fetch_buffer_markers): New functions for
9399 recording and fetching special buffer markers.
9400 (set_buffer_internal_1, set_buffer_temp): Use them.
9401
9402 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9403
9404 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9405
9406 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9407 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9408
9409 * xdisp.c (hscroll_window_tree):
9410 (reconsider_clip_changes): Use PT instead of BUF_PT.
9411
9412 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9413
9414 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9415 $(EMACS_ROOT)/lib/intprops.h.
9416
9417 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9418
9419 Fix more problems found by GCC 4.5.2's static checks.
9420
9421 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9422 to unsigned char * to avoid compiler diagnostic.
9423 (xg_free_frame_widgets): Make it clear that a local variable is
9424 needed only if USE_GTK_TOOLTIP.
9425 (gdk_window_get_screen): Make it clear that this macro is needed
9426 only if USE_GTK_TOOLTIP.
9427 (int_gtk_range_get_value): New function, which avoids a diagnostic
9428 from gcc -Wbad-function-cast.
9429 (xg_set_toolkit_scroll_bar_thumb): Use it.
9430 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9431 diagnostic from gcc -Wbad-function-cast.
9432 (get_utf8_string, xg_get_file_with_chooser):
9433 Rename locals to avoid shadowing.
9434 (create_dialog): Move locals to avoid shadowing.
9435
9436 * xgselect.c (xg_select): Remove unused var.
9437
9438 * image.c (four_corners_best): Mark locals as initialized.
9439 (gif_load): Initialize transparent_p to zero (Bug#8238).
9440 Mark another local as initialized.
9441 (my_png_error, my_error_exit): Mark with NO_RETURN.
9442
9443 * image.c (clear_image_cache): Now static.
9444 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9445 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9446 (x_edge_detection): Remove unnecessary cast that
9447 gcc -Wbad-function-cast diagnoses.
9448 (gif_load): Fix pointer signedness.
9449 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9450 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9451
9452 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9453
9454 Improve quality of tests for time stamp overflow.
9455 For example, without this patch (encode-time 0 0 0 1 1
9456 1152921504606846976) returns the obviously-bogus value (-948597
9457 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9458 reports time overflow. See
9459 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9460 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9461 * editfns.c: Include limits.h and intprops.h.
9462 (TIME_T_MIN, TIME_T_MAX): New macros.
9463 (time_overflow): Move earlier, to before first use.
9464 (hi_time, lo_time): New functions, for an accurate test for
9465 out-of-range times.
9466 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9467 (Fget_internal_run_time): Don't assume time_t fits in int.
9468 (make_time): Use list2 instead of Fcons twice.
9469 (Fdecode_time): More accurate test for out-of-range times.
9470 (check_tm_member): New function.
9471 (Fencode_time): Use it, to test for out-of-range times.
9472 (lisp_time_argument): Don't rely on undefined left-shift and
9473 right-shift behavior when checking for time stamp overflow.
9474
9475 * editfns.c (time_overflow): New function, refactoring common code.
9476 (Fformat_time_string, Fdecode_time, Fencode_time):
9477 (Fcurrent_time_string): Use it.
9478
9479 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9480 * dired.c (make_time): Move to ...
9481 * editfns.c (make_time): ... here.
9482 * systime.h: Note the move.
9483
9484 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9485
9486 * fringe.c (update_window_fringes): Remove unused variables.
9487
9488 * unexmacosx.c (copy_data_segment): Also copy __got section.
9489 (Bug#8223)
9490
9491 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9492
9493 * termcap.c [MSDOS]: Include "msdos.h".
9494 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9495 Constify `char *' arguments and their references according to
9496 prototypes in tparam.h.
9497
9498 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9499
9500 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9501 Adapt all references accordingly.
9502
9503 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9504
9505 2011-03-11 Tom Tromey <tromey@redhat.com>
9506
9507 * buffer.c (syms_of_buffer): Remove obsolete comment.
9508
9509 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9510
9511 * termhooks.h (encode_terminal_code): Declare prototype.
9512
9513 * msdos.c (encode_terminal_code): Don't declare prototype.
9514
9515 * term.c (encode_terminal_code): Now external again, used by
9516 w32console.c and msdos.c.
9517
9518 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9519 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9520
9521 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9522
9523 Fix some minor problems found by GCC 4.5.2's static checks.
9524
9525 * fringe.c (update_window_fringes): Mark locals as initialized
9526 (Bug#8227).
9527 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9528
9529 * alloc.c (mark_fringe_data): Move decl from here ...
9530 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9531 to check its interface.
9532 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9533
9534 * fontset.c (free_realized_fontset): Now static.
9535 (Fset_fontset_font): Rename local to avoid shadowing.
9536 (fontset_font): Mark local as initialized.
9537 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9538
9539 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9540
9541 * xselect.c (x_disown_buffer_selections): Remove; not used.
9542 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9543 (x_own_selection, Fx_disown_selection_internal): Rename locals
9544 to avoid shadowing.
9545 (x_handle_dnd_message): Remove local to avoid shadowing.
9546
9547 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9548 so that the caller can use some name other than gcpro1.
9549 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9550 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9551 (Fx_backspace_delete_keys_p):
9552 Use them to avoid shadowing, and rename vars to avoid shadowing.
9553 (x_decode_color, x_set_name, x_window): Now static.
9554 (Fx_create_frame): Add braces to silence GCC warning.
9555 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9556 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9557 Remove unused locals.
9558 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9559 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9560 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9561 macros.
9562
9563 * xterm.h (x_mouse_leave): New decl.
9564
9565 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9566 Remove unused functions.
9567 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9568 (x_calc_absolute_position): Now static.
9569 (XTread_socket): Don't define label "out" unless it's used.
9570 Don't declare local "event" unless it's used.
9571 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9572 unless they are used.
9573 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9574 (x_fatal_error_signal): Remove; not used.
9575 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9576 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9577 (x_error_catcher, x_connection_closed, x_error_handler):
9578 (x_error_quitter, xembed_send_message, x_iconify_frame):
9579 (my_log_handler): Rename locals to avoid shadowing.
9580 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9581 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9582
9583 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9584 Rename or move locals to avoid shadowing.
9585 (tty_defined_color, merge_face_heights): Now static.
9586 (free_realized_faces_for_fontset): Remove; not used.
9587 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9588 does not deduce is never used uninitialized.
9589 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9590 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9591
9592 * terminal.c (store_terminal_param): Now static.
9593
9594 * xmenu.c (menu_highlight_callback): Now static.
9595 (set_frame_menubar): Remove unused local.
9596 (xmenu_show): Rename parameter to avoid shadowing.
9597 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9598 since they might point to immutable storage.
9599 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9600 since it's unused otherwise.
9601
9602 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9603 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9604 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9605 avoids a gcc -Wuninitialized diagnostic.
9606 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9607 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9608 does not deduce are never used uninitialized.
9609
9610 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9611
9612 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9613 * window.c (window_loop, size_window):
9614 (run_window_configuration_change_hook, enlarge_window): Likewise.
9615
9616 * window.c (display_buffer): Now static.
9617 (size_window): Mark variables that gcc -Wuninitialized
9618 does not deduce are never used uninitialized.
9619 * window.h (check_all_windows): New decl, to forestall
9620 gcc -Wmissing-prototypes diagnostic.
9621 * dispextern.h (bidi_dump_cached_states): Likewise.
9622
9623 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9624 shadowing.
9625 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9626 Include <limits.h>.
9627 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9628 and to avoid gcc -Wuninitialized warning.
9629 (load_charset_map): Mark variables that gcc -Wuninitialized
9630 does not deduce are never used uninitialized.
9631 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9632
9633 * coding.c (coding_set_source, coding_set_destination):
9634 Use "else { /* comment */ }" rather than "else /* comment */;"
9635 for clarity, and to avoid gcc -Wempty-body warning.
9636 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9637 a block, when the outer 'i' will do.
9638 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9639 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9640 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9641 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9642 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9643 Rename locals to avoid shadowing.
9644 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9645 * coding.c (emacs_mule_char, encode_invocation_designation):
9646 Now static, since they're not used elsewhere.
9647 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9648 (decode_coding_object, encode_coding_object, detect_coding_system):
9649 (decode_coding_emacs_mule): Mark variables that gcc
9650 -Wuninitialized does not deduce are never used uninitialized.
9651 (detect_coding_iso_2022): Initialize a local variable that might
9652 be used uninitialized. Leave a FIXME because it's not clear that
9653 this initialization is needed. (Bug#8211)
9654 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9655 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9656 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9657 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9658 Remove unused macros.
9659
9660 * category.c (hash_get_category_set): Remove unused local var.
9661 (copy_category_table): Now static, since it's not used elsewhere.
9662 * character.c (string_count_byte8): Likewise.
9663
9664 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9665 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9666
9667 * chartab.c (copy_sub_char_table): Now static, since it's not used
9668 elsewhere.
9669 (sub_char_table_ref_and_range, char_table_ref_and_range):
9670 Rename locals to avoid shadowing.
9671 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9672
9673 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9674 (BIDI_BOB): Remove unused macro.
9675
9676 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9677 deduce are never used uninitialized.
9678 * term.c (encode_terminal_code): Likewise.
9679
9680 * term.c (encode_terminal_code): Now static. Remove unused local.
9681
9682 * tparam.h: New file.
9683 * term.c, tparam.h: Include it.
9684 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9685 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9686 Move these decls to tparam.h, and make them agree with what
9687 is actually in tparam.c. The previous trick of using incompatible
9688 decls in different modules does not conform to the C standard.
9689 All callers of tparam changed to use tparam's actual API.
9690 * tparam.c (tparam1, tparam, tgoto):
9691 Use const pointers where appropriate.
9692
9693 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9694 * cm.h (struct cm): Likewise.
9695 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9696 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9697 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9698 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9699 (turn_on_face, init_tty): Likewise.
9700 * termchar.h (struct tty_display_info): Likewise.
9701
9702 * term.c (term_mouse_position): Rename local to avoid shadowing.
9703
9704 * alloc.c (mark_ttys): Move decl from here ...
9705 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9706
9707 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9708
9709 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9710
9711 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9712
9713 * search.c (compile_pattern_1): Remove argument regp, unused since
9714 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9715 (compile_pattern): Don't pass it.
9716
9717 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9718
9719 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9720 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9721 for ! HAVE_GTK3.
9722 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9723
9724 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9725
9726 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9727 gdk_window_get_screen, gdk_window_get_geometry,
9728 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9729 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9730 (xg_get_pixbuf_from_pixmap): New function.
9731 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9732 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9733 Call xg_get_pixbuf_from_pixmap instead of
9734 gdk_pixbuf_get_from_drawable.
9735 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9736 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9737 (xg_check_special_colors): Use GtkStyleContext and its functions
9738 for HAVE_GTK3.
9739 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9740 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9741 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9742 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9743 Call gtk_widget_get_preferred_size.
9744 (xg_frame_resized): gdk_window_get_geometry only takes 5
9745 parameters.
9746 (xg_win_to_widget, xg_event_is_for_menubar):
9747 Call gdk_x11_window_lookup_for_display.
9748 (xg_set_widget_bg): New function.
9749 (delete_cb): New function.
9750 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9751 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9752 (xg_set_background_color): Call xg_set_widget_bg.
9753 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9754 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9755 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9756 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9757 if ! HAVE_GTK3.
9758 (update_frame_tool_bar): Call gtk_widget_hide.
9759 (xg_initialize): Use GDK_KEY_g.
9760
9761 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9762 if ! HAVE_GTK3
9763 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9764
9765 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9766 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9767 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9768
9769 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9770
9771 * w32xfns.c (select_palette): Check success of RealizePalette against
9772 GDI_ERROR, not zero.
9773
9774 See ChangeLog.11 for earlier changes.
9775
9776 ;; Local Variables:
9777 ;; coding: utf-8
9778 ;; End:
9779
9780 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9781
9782 This file is part of GNU Emacs.
9783
9784 GNU Emacs is free software: you can redistribute it and/or modify
9785 it under the terms of the GNU General Public License as published by
9786 the Free Software Foundation, either version 3 of the License, or
9787 (at your option) any later version.
9788
9789 GNU Emacs is distributed in the hope that it will be useful,
9790 but WITHOUT ANY WARRANTY; without even the implied warranty of
9791 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9792 GNU General Public License for more details.
9793
9794 You should have received a copy of the GNU General Public License
9795 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.