]> code.delx.au - gnu-emacs/blob - src/ChangeLog
merge from upstream
[gnu-emacs] / src / ChangeLog
1 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4 is an integer, which is important for empty lines. (Bug#9149)
5
6 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7
8 * frame.c (Fmodify_frame_parameters): In tty case, update the
9 default face if necessary (Bug#4238).
10
11 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
12
13 * editfns.c (Fstring_to_char): No need to explain what a character
14 is in the docstring (Bug#6576).
15
16 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
17
18 * xml.c (parse_region): Make sure we always return a tree.
19
20 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
21
22 * xml.c (parse_region): If a document contains only comments,
23 return that, too.
24
25 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
26
27 * xml.c (make_dom): Return comments, too.
28
29 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
30
31 Port to OpenBSD.
32 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
33 and the surrounding thread.
34 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
35 rather than fgets, and retry after EINTR. Otherwise, 'emacs
36 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
37 timer goes off.
38 * s/openbsd.h (BROKEN_SIGIO): Define.
39 * unexelf.c (unexec) [__OpenBSD__]:
40 Don't update the .mdebug section of the Alpha COFF symbol table.
41
42 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
43
44 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
45 (bug#8460).
46
47 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
48
49 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
50 This fixes some race conditions on the permissions of any newly
51 created file.
52
53 * alloc.c (valid_pointer_p): Use pipe, not open.
54 This fixes some permissions issues when debugging.
55
56 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
57 If fchown fails to set both uid and gid, try to set just gid,
58 as that is sometimes allowed. Adjust the file's mode to eliminate
59 setuid or setgid bits that are inappropriate if fchown fails.
60
61 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
62
63 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
64 to compare Lisp_Objects.
65 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
66 global_gnutls_log_level, don't mistake it for a Lisp_Object.
67 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
68
69 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
70
71 * lread.c (read_integer): Unread even EOF character.
72 (read1): Likewise. Properly record start position of symbol.
73
74 * lread.c (read1): Read `#:' as empty uninterned symbol if no
75 symbol character follows.
76
77 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
78
79 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
80 This works around a problem with the previous change to Fcopy_file.
81 Recent glibc declares fchown with __attribute__((warn_unused_result)),
82 and without this change, GCC might complain about discarding
83 fchown's return value.
84
85 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
86
87 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
88
89 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
90
91 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
92
93 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
94
95 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
96 it's used from the C level.
97
98 * process.c: Use the same condition for POLL_FOR_INPUT in both
99 keyboard.c and process.c (bug#1858).
100
101 2011-07-09 Lawrence Mitchell <wence@gmx.li>
102
103 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
104 (Fgnutls_boot): Use it.
105
106 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
107
108 * doc.c (Fsubstitute_command_keys): Revert last change.
109
110 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
111
112 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
113 quotes the next character, and doesn't affect other longer
114 sequences (bug#8935).
115
116 * lread.c (syms_of_lread): Clarify that is isn't only
117 `eval-buffer' and `eval-defun' that's affected by
118 `lexical-binding' (bug#8460).
119
120 2011-07-15 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
123 bidi redisplay when a line includes both an image and is
124 truncated.
125
126 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
127
128 Fix minor problems found by static checking.
129 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
130 (elsz): Now a signed constant, not a size_t var. We prefer signed
131 types to unsigned, to avoid integer comparison confusion. Without
132 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
133 "cannot optimize loop, the loop counter may overflow", a symptom
134 of the confusion.
135 * indent.c (Fvertical_motion): Mark locals as initialized.
136 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
137
138 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
139
140 * search.c (Fre_search_backward): Mention `case-fold-search' in
141 all the re_search_* functions (bug#8138).
142
143 * keyboard.c (Fopen_dribble_file): Document when the file is
144 closed (bug#8056).
145
146 2011-07-14 Eli Zaretskii <eliz@gnu.org>
147
148 * bidi.c (bidi_dump_cached_states): Fix format of displaying
149 bidi_cache_idx.
150
151 Support bidi reordering of display and overlay strings.
152 * xdisp.c (compute_display_string_pos)
153 (compute_display_string_end): Accept additional argument STRING.
154 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
155 (reseat_to_string): Initialize bidi_it->string.s and
156 bidi_it->string.schars.
157 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
158 NULL (avoids a crash in bidi_paragraph_init). Initialize
159 itb.string.lstring.
160 (init_iterator): Call bidi_init_it only of a valid
161 buffer position was specified. Initialize paragraph_embedding to
162 L2R.
163 (reseat_to_string): Initialize the bidi iterator.
164 (display_string): If we need to ignore text properties of
165 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
166 original value of -1 will not work with bidi.)
167 (compute_display_string_pos): First arg is now struct
168 `text_pos *'; all callers changed. Support display properties on
169 Lisp strings.
170 (compute_display_string_end): Support display properties on Lisp
171 strings.
172 (init_iterator, reseat_1, reseat_to_string): Initialize the
173 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
174 when iterating on a string not from display properties).
175 (compute_display_string_pos, compute_display_string_end): Fix
176 calculation of the object to scan. Fixes an error when using
177 arrow keys.
178 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
179 base_level_stop; instead, set base_level_stop to BEGV. Fixes
180 crashes in vertical-motion.
181 (next_element_from_buffer): Improve commentary for when
182 the iterator is before prev_stop.
183 (init_iterator): Initialize bidi_p from the default value of
184 bidi-display-reordering, not from buffer-local value. Use the
185 buffer-local value only if initializing for buffer iteration.
186 (handle_invisible_prop): Support invisible properties on strings
187 that are being bidi-reordered.
188 (set_iterator_to_next): Support bidi reordering of C strings and
189 Lisp strings.
190 (next_element_from_string): Support bidi reordering of Lisp
191 strings.
192 (handle_stop_backwards): Support Lisp strings as well.
193 (display_string): Support display of R2L glyph rows. Use
194 IT_STRING_CHARPOS when displaying from a Lisp string.
195 (init_iterator): Don't initialize it->bidi_p for strings
196 here.
197 (reseat_to_string): Initialize it->bidi_p for strings here.
198 (next_element_from_string, next_element_from_c_string)
199 (next_element_from_buffer): Add xassert's for correspondence
200 between IT's object being iterated and it->bidi_it.string
201 structure.
202 (face_before_or_after_it_pos): Support bidi iteration.
203 (next_element_from_c_string): Handle the case of the first string
204 character that is not the first one in the visual order.
205 (get_visually_first_element): New function, refactored from common
206 parts of next_element_from_buffer, next_element_from_string, and
207 next_element_from_c_string.
208 (tool_bar_lines_needed, redisplay_tool_bar)
209 (display_menu_bar): Force left-to-right direction. Add a FIXME
210 comment for making that be controlled by a user option.
211 (push_it, pop_it): Save and restore the state of the
212 bidi iterator. Save and restore the bidi_p flag.
213 (pop_it): Iterate out of display property for string iteration as
214 well.
215 (iterate_out_of_display_property): Support iteration over strings.
216 (handle_single_display_spec): Set up it->bidi_it for iteration
217 over a display string, and call bidi_init_it.
218 (handle_single_display_spec, next_overlay_string)
219 (get_overlay_strings_1, push_display_prop): Set up the bidi
220 iterator for displaying display or overlay strings.
221 (forward_to_next_line_start): Don't use the shortcut if
222 bidi-iterating.
223 (back_to_previous_visible_line_start): If handle_display_prop
224 pushed the iterator stack, restore the internal state of the bidi
225 iterator by calling bidi_pop_it same number of times.
226 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
227 and we are bidi-iterating, don't decrement the iterator position;
228 instead, set the first_elt flag in the bidi iterator, to produce
229 the same effect.
230 (reseat_1): Remove redundant setting of string_from_display_prop_p.
231 (push_display_prop): xassert that we are iterating a buffer.
232 (push_it, pop_it): Save and restore paragraph_embedding member.
233 (handle_single_display_spec, next_overlay_string)
234 (get_overlay_strings_1, reseat_1, reseat_to_string)
235 (push_display_prop): Set up the `unibyte' member of bidi_it.string
236 correctly. Don't assume unibyte strings are not bidi-reordered.
237 (compute_display_string_pos)
238 (compute_display_string_end): Fix handling the case of C string.
239 (push_it, pop_it): Save and restore from_disp_prop_p.
240 (handle_single_display_spec, push_display_prop): Set the
241 from_disp_prop_p flag.
242 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
243 (pop_it): Call iterate_out_of_display_property only if we are
244 popping after iteration over a string that came from a display
245 property. Fix a typo in popping stretch info. Add an assertion
246 for verifying that the iterator position is in sync with the bidi
247 iterator.
248 (handle_single_display_spec, get_overlay_strings_1)
249 (push_display_prop): Fix initialization of paragraph direction for
250 string when that of the parent object is not yet determined.
251 (reseat_1): Call bidi_init_it to resync the bidi
252 iterator with IT's position. (Bug#7616)
253 (find_row_edges): If ROW->start.pos gives position
254 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
255 (handle_stop, back_to_previous_visible_line_start, reseat_1):
256 Reset the from_disp_prop_p flag.
257 (SAVE_IT, RESTORE_IT): New macros.
258 (pos_visible_p, face_before_or_after_it_pos)
259 (back_to_previous_visible_line_start)
260 (move_it_in_display_line_to, move_it_in_display_line)
261 (move_it_to, move_it_vertically_backward, move_it_by_lines)
262 (try_scrolling, redisplay_window, display_line): Use them when
263 saving a temporary copy of the iterator and restoring it back.
264 (back_to_previous_visible_line_start, reseat_1)
265 (init_iterator): Empty the bidi cache "stack".
266 (move_it_in_display_line_to): If iterator ended up at
267 EOL, but we never saw any buffer positions smaller than
268 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
269 motion in bidi-reordered lines.
270 (move_it_in_display_line_to): Record prev_method and prev_pos
271 immediately before the call to set_iterator_to_next. Fixes cursor
272 motion in bidi-reordered lines with stretch glyphs and strings
273 displayed in margins. (Bug#8133) (Bug#8867)
274 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
275 TO_CHARPOS.
276 (pos_visible_p): Support positions in bidi-reordered lines. Save
277 and restore bidi cache.
278
279 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
280 (bidi_paragraph_info): Delete unused struct.
281 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
282 (bidi_cache_start): New variable.
283 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
284 to zero.
285 (bidi_cache_fetch_state, bidi_cache_search)
286 (bidi_cache_find_level_change, bidi_cache_iterator_state)
287 (bidi_cache_find, bidi_peek_at_next_level)
288 (bidi_level_of_next_char, bidi_find_other_level_edge)
289 (bidi_move_to_visually_next): Compare cache index with
290 bidi_cache_start rather than with zero.
291 (bidi_fetch_char): Accept new argument STRING; all callers
292 changed. Support iteration over a string. Support strings with
293 display properties. Support unibyte strings. Fix the type of
294 `len' according to what STRING_CHAR_AND_LENGTH expects.
295 (bidi_paragraph_init, bidi_resolve_explicit_1)
296 (bidi_resolve_explicit, bidi_resolve_weak)
297 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
298 iteration over a string.
299 (bidi_set_sor_type, bidi_resolve_explicit_1)
300 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
301 can now be zero (for strings); special values 0 and -1 were
302 changed to -1 and -2, respectively.
303 (bidi_char_at_pos): New function.
304 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
305 Call it instead of FETCH_MULTIBYTE_CHAR.
306 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
307 initialized to valid values.
308 (bidi_init_it): Don't initialize charpos and bytepos with invalid
309 values.
310 (bidi_level_of_next_char): Allow the sentinel "position" to pass
311 the test for valid cached positions. Fix the logic for looking up
312 the sentinel state in the cache. GCPRO the Lisp string we are
313 iterating.
314 (bidi_push_it, bidi_pop_it): New functions.
315 (bidi_initialize): Initialize the bidi cache start stack pointer.
316 (bidi_cache_ensure_space): New function, refactored from part of
317 bidi_cache_iterator_state. Don't assume the required size is just
318 one BIDI_CACHE_CHUNK away.
319 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
320 (bidi_count_bytes, bidi_char_at_pos): New functions.
321 (bidi_cache_search): Don't assume bidi_cache_last_idx is
322 always valid if bidi_cache_idx is valid.
323 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
324 is valid if it's going to be used.
325 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
326 (bidi_cache_fetch_state, bidi_cache_search)
327 (bidi_cache_find_level_change, bidi_cache_ensure_space)
328 (bidi_cache_iterator_state, bidi_cache_find)
329 (bidi_find_other_level_edge, bidi_cache_start_stack): All
330 variables related to cache indices are now EMACS_INT.
331
332 * dispextern.h (struct bidi_string_data): New structure.
333 (struct bidi_it): New member `string'. Make flag members be 1-bit
334 fields, and put them last in the struct.
335 (compute_display_string_pos, compute_display_string_end): Update
336 prototypes.
337 (bidi_push_it, bidi_pop_it): Add prototypes.
338 (struct iterator_stack_entry): New members bidi_p,
339 paragraph_embedding, and from_disp_prop_p.
340 (struct it): Member bidi_p is now a bit field 1 bit wide.
341 (bidi_shelve_cache, bidi_unshelve_cache): Declare
342 prototypes.
343
344 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
345 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
346 and vector-like objects.
347
348 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
349 cache around display iteration.
350
351 * window.c (Fwindow_end, window_scroll_pixel_based)
352 (displayed_window_lines, Frecenter): Save and restore the bidi
353 cache around display iteration.
354
355 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
356
357 * editfns.c (Fdelete_region): Clarify the use of the named
358 parameters (bug#6788).
359
360 2011-07-14 Martin Rudalics <rudalics@gmx.at>
361
362 * indent.c (Fvertical_motion): Set and restore w->pointm when
363 saving and restoring the window's buffer (Bug#9006).
364
365 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
366
367 * editfns.c (Fstring_to_char): Clarify just what is returned
368 (bug#6576). Text by Eli Zaretskii.
369
370 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
371
372 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
373
374 2011-07-13 Eli Zaretskii <eliz@gnu.org>
375
376 * buffer.c (mmap_find): Fix a typo.
377
378 2011-07-13 Johan Bockgård <bojohan@gnu.org>
379
380 Fix execution of x selection hooks.
381 * xselect.c (Qx_lost_selection_functions)
382 (Qx_sent_selection_functions): New vars.
383 (syms_of_xselect): DEFSYM them.
384 (x_handle_selection_request): Pass Qx_sent_selection_functions
385 rather than Vx_sent_selection_functions to Frun_hook_with_args.
386 (x_handle_selection_clear,x_clear_frame_selections):
387 Pass Qx_lost_selection_functions rather than
388 Vx_lost_selection_functions to Frun_hook_with_args.
389
390 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
391
392 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
393 The old code sometimes used this field without initializing it.
394
395 * alloc.c (gc_sweep): Don't read past end of array.
396 In theory, the old code could also have corrupted Emacs internals,
397 though it'd be very unlikely.
398
399 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
400
401 * character.c (Fcharacterp): Don't advertise optional ignored
402 argument. (Bug#4026)
403
404 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
405
406 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
407 key" (bug#4257).
408
409 * window.c (Fset_window_start): Doc fix (bug#4199).
410 (Fset_window_hscroll): Ditto.
411
412 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
413
414 Fix minor new problems caught by GCC 4.6.1.
415 * term.c (init_tty): Remove unused local.
416 * xsettings.c (store_monospaced_changed): Define this function only
417 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
418 not used otherwise.
419
420 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
421
422 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
423
424 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
425
426 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
427 are the mini-buffer and the echo area (bug#3320).
428
429 * term.c (init_tty): Remove support for supdup, c10 and perq
430 terminals, which are no longer supported (bug#1482).
431
432 2011-07-10 Johan Bockgård <bojohan@gnu.org>
433
434 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
435
436 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
437
438 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
439 for non-popups (Bug#3642).
440
441 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
442
443 * alloc.c (reset_malloc_hooks): Protoize.
444 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
445 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
446 * cm.c (losecursor): Likewise.
447 * data.c (fmod): Likewise.
448 * dispnew.c (swap_glyphs_in_rows): Likewise.
449 * emacs.c (memory_warning_signal): Likewise.
450 * floatfns.c (float_error): Likewise.
451 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
452 (otf_open, font_otf_capability, generate_otf_features)
453 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
454 Likewise.
455 * image.c (pbm_read_file): Likewise.
456 * indent.c (string_display_width): Likewise.
457 * intervals.c (check_for_interval, search_for_interval)
458 (inc_interval_count, count_intervals, root_interval)
459 (adjust_intervals_for_insertion, make_new_interval): Likewise.
460 * lread.c (defalias): Likewise.
461 * ralloc.c (r_alloc_check): Likewise.
462 * regex.c (set_image_of_range_1, set_image_of_range)
463 (regex_grow_registers): Likewise.
464 * sysdep.c (strerror): Likewise.
465 * termcap.c (valid_filename_p, tprint, main): Likewise.
466 * tparam.c (main): Likewise.
467 * unexhp9k800.c (run_time_remap, save_data_space)
468 (update_file_ptrs, read_header, write_header, calculate_checksum)
469 (copy_file, copy_rest, display_header): Likewise.
470 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
471 Likewise.
472 * xdisp.c (check_it): Likewise.
473 * xfaces.c (register_color, unregister_color, unregister_colors):
474 Likewise.
475 * xfns.c (print_fontset_result): Likewise.
476 * xrdb.c (member, fatal, main): Likewise.
477
478 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
479
480 Fix minor problems found by static checking (Bug#9031).
481 * chartab.c (char_table_set_range, map_sub_char_table):
482 Remove unused locals.
483 (uniprop_table): Now static.
484 * composite.c (_work_char): Remove unused static var.
485
486 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
487
488 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
489
490 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
491
492 * gtkutil.c (qttip_cb): Remove code without function.
493
494 2011-07-09 Eli Zaretskii <eliz@gnu.org>
495
496 * w32.c (pthread_sigmask): New stub.
497
498 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
499
500 Use pthread_sigmask, not sigprocmask (Bug#9010).
501 sigprocmask is portable only for single-threaded applications, and
502 Emacs can be multi-threaded when it uses GTK.
503 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
504 (LIBES): Use it.
505 * callproc.c (Fcall_process):
506 * process.c (create_process):
507 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
508 Use pthread_sigmask, not sigprocmask.
509
510 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
511
512 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
513 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
514 wrong (Bug#8591).
515
516 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
517
518 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
519 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
520 (xg_hide_tooltip): Fix comment.
521
522 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
523 in registerServicesMenuSendTypes.
524 (validRequestorForSendType): Don't check ns_return_types.
525
526 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
527 ns_return_type.
528
529 2011-07-08 Jason Rumney <jasonr@gnu.org>
530
531 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
532 frame struct members of non-existent frames (Bug#6284).
533
534 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
535
536 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
537 variable firstTime not needed on OSX >= 10.6.
538 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
539 >= 10.5. Use setKnobProportion, setDoubleValue.
540
541 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
542 (MAC_OS_X_VERSION_10_5): Define if not defined.
543 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
544 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
545 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
546
547 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
548 cString and lossyCString on OSX >= 10.4
549
550 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
551 sizeToFit on OSX >= 10.2.
552
553 * nsimage.m (allocInitFromFile): Don't use deprecated method
554 bestRepresentationForDevice on OSX >= 10.6.
555
556 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
557 to avoid warning.
558
559 * emacs.c: Declare unexec_init_emacs_zone.
560
561 * nsgui.h: Fix compiler warning about gnulib redefining verify.
562
563 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
564
565 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
566 on svcsMenu (Bug#8842).
567
568 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
569 ns_return_types.
570 (Fns_list_services): Just return Qnil on 10.6, code not working there.
571
572 * nsterm.m (QUTF8_STRING): Declare.
573 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
574 (validRequestorForSendType): Return type is (id).
575 Change indexOfObjectIdenticalTo to indexOfObject.
576 Check if we have local selection before returning self (Bug#8842).
577 (writeSelectionToPasteboard): Put local selection into paste board
578 if we have a local selection (Bug#8842).
579 (syms_of_nsterm): DEFSYM QUTF8_STRING.
580
581 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
582 (ns_get_local_selection): Declare.
583
584 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
585
586 * keymap.c (describe_map_tree): Don't insert a double newline at
587 the end of the buffer (bug#1169) and return whether we inserted
588 something.
589
590 * callint.c (Fcall_interactively): Change "reading args" to
591 "providing args" to try to clarify what it does (bug#1010).
592
593 2011-07-07 Kenichi Handa <handa@m17n.org>
594
595 * composite.c (composition_compute_stop_pos): Ignore a static
596 composition starting before CHARPOS (Bug#8915).
597
598 * xdisp.c (handle_composition_prop): Likewise.
599
600 2011-07-07 Eli Zaretskii <eliz@gnu.org>
601
602 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
603 (Bug#9015)
604
605 2011-07-07 Kenichi Handa <handa@m17n.org>
606
607 * character.h (unicode_category_t): New enum type.
608
609 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
610 (Qchar_code_property_table): New variable.
611 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
612 (UNIPROP_COMPRESSED_FORM_P): New macros.
613 (char_table_ascii): Uncompress the compressed values.
614 (sub_char_table_ref): New arg is_uniprop. Callers changed.
615 Uncompress the compressed values.
616 (sub_char_table_ref_and_range): Likewise.
617 (char_table_ref_and_range): Uncompress the compressed values.
618 (sub_char_table_set): New arg is_uniprop. Callers changed.
619 Uncompress the compressed values.
620 (sub_char_table_set_range): Args changed. Callers changed.
621 (char_table_set_range): Adjuted for the above change.
622 (map_sub_char_table): Delete args default_val and parent. Add arg
623 top. Give decoded values to a Lisp function.
624 (map_char_table): Adjusted for the above change. Give decoded
625 values to a Lisp function. Gcpro more variables.
626 (uniprop_table_uncompress)
627 (uniprop_decode_value_run_length): New functions.
628 (uniprop_decoder, uniprop_decoder_count): New variables.
629 (uniprop_get_decoder, uniprop_encode_value_character)
630 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
631 New functions.
632 (uniprop_encoder, uniprop_encoder_count): New variables.
633 (uniprop_get_encoder, uniprop_table)
634 (Funicode_property_table_internal, Fget_unicode_property_internal)
635 (Fput_unicode_property_internal): New functions.
636 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
637 Sunicode_property_table_internal, Sget_unicode_property_internal,
638 and Sput_unicode_property_internal. Defvar_lisp
639 char-code-property-alist.
640
641 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
642 Vunicode_category_table.
643
644 * font.c (font_range): Adjusted for the change of
645 Vunicode_category_table.
646
647 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
648
649 * m/iris4d.h: Remove file, move contents ...
650 * s/irix6-5.h: ... here.
651
652 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
653
654 Remove unportable assumption about struct layout (Bug#8884).
655 * alloc.c (mark_buffer):
656 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
657 (clone_per_buffer_values): Don't assume that
658 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
659 This isn't true in general, and it's particularly not true
660 if Emacs is configured with --with-wide-int.
661 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
662 New macros, used in the buffer.c change.
663
664 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
665
666 * xsettings.c: Use both GConf and GSettings if both are available.
667 (store_config_changed_event): Add comment.
668 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
669 (store_tool_bar_style_changed): New functions.
670 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
671 (struct xsettings): Move font inside HAVE_XFT.
672 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
673 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
674 Move inside HAVE_XFT.
675 (something_changed_gsettingsCB): Renamed from something_changedCB.
676 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
677 also.
678 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
679 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
680 (something_changed_gconfCB): Renamed from something_changedCB.
681 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
682 (parse_settings): Move check for font inside HAVE_XFT.
683 (read_settings, apply_xft_settings): Add comment.
684 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
685 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
686 call store_font_name_changed.
687 (xft_settings_event): Add comment.
688 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
689 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
690 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
691 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
692 (xsettings_initialize): Call init_gsettings last.
693 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
694 comment.
695
696 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
697
698 Random fixes. E.g., (random) never returned negative values.
699 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
700 subseconds part to the entropy, as that's a bit more random.
701 Prefer signed to unsigned, since the signedness doesn't matter and
702 in general we prefer signed. When given a limit, use a
703 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
704 latter isn't right if USE_2_TAGS_FOR_INTS.
705 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
706 not 0..VALMASK. Don't discard "excess" bits that random () returns.
707
708 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * textprop.c (text_property_stickiness):
711 Obey Vtext_property_default_nonsticky.
712 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
713 * w32fns.c (syms_of_w32fns):
714 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
715
716 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
717
718 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
719 This is more efficient than Ffile_directory_p and avoids a minor race.
720
721 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * buffer.c (Foverlay_put): Say what the return value is
724 (bug#7835).
725
726 * fileio.c (barf_or_query_if_file_exists): Check first if the file
727 is a directory before asking whether to use the file name
728 (bug#7564).
729 (barf_or_query_if_file_exists): Make the "File is a directory"
730 error be more correct.
731
732 * fns.c (Frequire): Remove the mention of the .gz files, since
733 that's installation-specific, but keep the mention of
734 `get-load-suffixes'.
735
736 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
737
738 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
739 Report string overflow if the output is too long.
740
741 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
742
743 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
744 (syms_of_gnutls): Remove duplicate DEFSYM for
745 Qgnutls_bootprop_verify_hostname_error, an error for
746 Qgnutls_bootprop_verify_error (which is no longer used).
747
748 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
749 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
750 Also (re)move comments that are misplaced or no longer relevant.
751
752 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
753
754 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
755
756 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
757
758 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
759 and background color parameters if they have been changed.
760
761 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
762
763 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
764
765 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
766
767 * xsettings.c (SYSTEM_FONT): Define only when used.
768 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
769
770 * keymap.c (access_keymap_1): Now static.
771
772 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
773
774 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
775 leave any prefix arg for the up event (Bug#1586).
776
777 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
778
779 * lread.c (syms_of_lread): Mention single symbols defined by
780 `defvar' or `defconst' (bug#7154).
781
782 * fns.c (Frequire): Mention .el.gz files (bug#7314).
783 (Frequire): Mention get-load-suffixes.
784
785 2011-07-02 Martin Rudalics <rudalics@gmx.at>
786
787 * window.h (window): Remove clone_number slot.
788 * window.c (Fwindow_clone_number, Fset_window_clone_number):
789 Remove.
790 (make_parent_window, make_window, saved_window)
791 (Fset_window_configuration, save_window_save): Don't deal with
792 clone numbers.
793 * buffer.c (Qclone_number): Remove declaration.
794 (sort_overlays, overlay_strings): Don't deal with clone numbers.
795
796 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
797
798 Add multiple inheritance to keymaps.
799 * keymap.c (Fmake_composed_keymap): New function.
800 (Fset_keymap_parent): Simplify.
801 (fix_submap_inheritance): Remove.
802 (access_keymap_1): New function extracted from access_keymap to handle
803 embedded parents and handle lists of maps.
804 (access_keymap): Use it.
805 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
806 (Fcopy_keymap): Handle embedded parents.
807 (Fcommand_remapping, define_as_prefix): Simplify.
808 (Fkey_binding): Simplify.
809 (syms_of_keymap): Move minibuffer-local-completion-map,
810 minibuffer-local-filename-completion-map,
811 minibuffer-local-must-match-map, and
812 minibuffer-local-filename-must-match-map to Elisp.
813 (syms_of_keymap): Defsubr make-composed-keymap.
814 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
815 (parse_menu_item): Trivial simplification.
816
817 2011-07-01 Glenn Morris <rgm@gnu.org>
818
819 * Makefile.in (SETTINGS_LIBS): Fix typo.
820
821 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
822
823 * coding.c (Fencode_coding_string): Record the last coding system
824 used, as the function doc string says (bug#8738).
825
826 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
827
828 * xsettings.c (store_monospaced_changed): Take new font as arg and
829 check for change against current_mono_font.
830 (EMACS_TYPE_SETTINGS): Remove this and related defines.
831 (emacs_settings_constructor, emacs_settings_get_property)
832 (emacs_settings_set_property, emacs_settings_class_init)
833 (emacs_settings_init, gsettings_obj): Remove.
834 (something_changedCB): New function for HAVE_GSETTINGS.
835 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
836 with value as argument.
837 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
838 g_settings_new (Bug#8967). Do not create gsettings_obj.
839 Remove calls to g_settings_bind. Connect something_changedCB to
840 "changed".
841
842 * xgselect.c: Add defined (HAVE_GSETTINGS).
843 (xgselect_initialize): Ditto.
844
845 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
846 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
847 xg_select.
848
849 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
850
851 * eval.c (struct backtrace): Simplify and port the data structure.
852 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
853 signed bit field, as this assumption is not portable and it makes
854 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
855 "char debug_on_exit : 1" as this is not portable either; instead,
856 use the portable "unsigned int debug_on_exit : 1". Remove unused
857 member evalargs. Remove obsolete comments about cc bombing out.
858
859 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
860
861 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
862 Let HAVE_GSETTINGS override HAVE_GCONF.
863 (store_monospaced_changed): New function.
864 (EMACS_SETTINGS): A new type derived from GObject to handle
865 GSettings notifications.
866 (emacs_settings_constructor, emacs_settings_get_property)
867 (emacs_settings_set_property, emacs_settings_class_init):
868 New functions.
869 (gsettings_client, gsettings_obj): New variables.
870 (GSETTINGS_SCHEMA): New define.
871 (something_changedCB): Call store_monospaced_changed.
872 (init_gsettings): New function.
873 (xsettings_initialize): Call init_gsettings.
874 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
875 to NULL.
876
877 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
878 GCONF_CFLAGS/LIBS.
879
880 2011-06-29 Martin Rudalics <rudalics@gmx.at>
881
882 * window.c (resize_root_window, grow_mini_window)
883 (shrink_mini_window): Rename Qresize_root_window to
884 Qwindow_resize_root_window and Qresize_root_window_vertically to
885 Qwindow_resize_root_window_vertically.
886
887 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
888
889 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
890
891 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
892
893 * makefile.w32-in: Redesign dependencies so they reflect more
894 clearly which files are directly included by each source file,
895 and not through other includes.
896
897 2011-06-27 Martin Rudalics <rudalics@gmx.at>
898
899 * buffer.c (Qclone_number): Declare static and DEFSYM it.
900 (sort_overlays, overlay_strings): When an overlay's clone number
901 matches the window's clone number process the overlay even if
902 the overlay's window property doesn't match the current window.
903
904 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
905 (Fwindow_hchild): Rename to Fwindow_left_child.
906 (Fwindow_next): Rename to Fwindow_next_sibling.
907 (Fwindow_prev): Rename to Fwindow_prev_sibling.
908 (resize_window_check): Rename to window_resize_check.
909 (resize_window_apply): Rename to window_resize_apply.
910 (Fresize_window_apply): Rename to Fwindow_resize_apply.
911 (Fdelete_other_windows_internal, resize_frame_windows)
912 (Fsplit_window_internal, Fdelete_window_internal)
913 (grow_mini_window, shrink_mini_window)
914 (Fresize_mini_window_internal): Fix callers accordingly.
915
916 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
917
918 * emacsgtkfixed.h: State that this is only used with Gtk+3.
919 (emacs_fixed_set_min_size): Remove.
920 (emacs_fixed_new): Take frame as argument.
921
922 * emacsgtkfixed.c: State that this is only used with Gtk+3.
923 (_EmacsFixedPrivate): Remove minwidth/height.
924 Add struct frame *f.
925 (emacs_fixed_init): Initialize priv->f.
926 (get_parent_class, emacs_fixed_set_min_size): Remove.
927 (emacs_fixed_new): Set priv->f to argument.
928 (emacs_fixed_get_preferred_width)
929 (emacs_fixed_get_preferred_height): Use min_width/height from
930 frames size_hint to set minimum and natural (Bug#8919).
931 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
932 and use min_width/height from frames size_hint to set
933 min_width/height (Bug#8919).
934
935 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
936 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
937 Fix indentation.
938
939 2011-06-26 Eli Zaretskii <eliz@gnu.org>
940
941 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
942 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
943 called at ZV.
944
945 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
946
947 * process.c (wait_reading_process_output): Bypass select if
948 waiting for a cell while ignoring keyboard input, and input is
949 pending. Suggested by Jan Djärv (Bug#8869).
950
951 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
952
953 Use gnulib's dup2 module instead of rolling our own.
954 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
955
956 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
957
958 * dispnew.c (scrolling_window): Before scrolling, turn off a
959 mouse-highlight in the window being scrolled.
960
961 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
962
963 Move DEFSYM to lisp.h and use everywhere.
964
965 * character.h (DEFSYM): Move declaration...
966 * lisp.h (DEFSYM): ...here.
967
968 * gnutls.c:
969 * minibuf.c:
970 * w32menu.c:
971 * w32proc.c:
972 * w32select.c: Don't include character.h.
973
974 * alloc.c (syms_of_alloc):
975 * buffer.c (syms_of_buffer):
976 * bytecode.c (syms_of_bytecode):
977 * callint.c (syms_of_callint):
978 * casefiddle.c (syms_of_casefiddle):
979 * casetab.c (init_casetab_once):
980 * category.c (init_category_once, syms_of_category):
981 * ccl.c (syms_of_ccl):
982 * cmds.c (syms_of_cmds):
983 * composite.c (syms_of_composite):
984 * dbusbind.c (syms_of_dbusbind):
985 * dired.c (syms_of_dired):
986 * dispnew.c (syms_of_display):
987 * doc.c (syms_of_doc):
988 * editfns.c (syms_of_editfns):
989 * emacs.c (syms_of_emacs):
990 * eval.c (syms_of_eval):
991 * fileio.c (syms_of_fileio):
992 * fns.c (syms_of_fns):
993 * frame.c (syms_of_frame):
994 * fringe.c (syms_of_fringe):
995 * insdel.c (syms_of_insdel):
996 * keymap.c (syms_of_keymap):
997 * lread.c (init_obarray, syms_of_lread):
998 * macros.c (syms_of_macros):
999 * msdos.c (syms_of_msdos):
1000 * print.c (syms_of_print):
1001 * process.c (syms_of_process):
1002 * search.c (syms_of_search):
1003 * sound.c (syms_of_sound):
1004 * syntax.c (init_syntax_once, syms_of_syntax):
1005 * terminal.c (syms_of_terminal):
1006 * textprop.c (syms_of_textprop):
1007 * undo.c (syms_of_undo):
1008 * w32.c (globals_of_w32):
1009 * window.c (syms_of_window):
1010 * xdisp.c (syms_of_xdisp):
1011 * xfaces.c (syms_of_xfaces):
1012 * xfns.c (syms_of_xfns):
1013 * xmenu.c (syms_of_xmenu):
1014 * xsettings.c (syms_of_xsettings):
1015 * xterm.c (syms_of_xterm): Use DEFSYM.
1016
1017 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1018
1019 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1020
1021 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 Integer and buffer overflow fixes (Bug#8873).
1024
1025 * print.c (printchar, strout): Check for string overflow.
1026 (PRINTPREPARE, printchar, strout):
1027 Don't set size unless allocation succeeds.
1028
1029 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1030 for sizes. Check for string overflow more accurately.
1031 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1032
1033 * macros.c: Integer and buffer overflow fixes.
1034 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1035 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1036 Use ptrdiff_t, not int, for sizes.
1037 Don't increment bufsize until after realloc succeeds.
1038 Check for size-calculation overflow.
1039 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1040
1041 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1042
1043 * lread.c: Integer overflow fixes.
1044 (read_integer): Radix is now EMACS_INT, not int,
1045 to improve quality of diagnostics for out-of-range radices.
1046 Calculate buffer size correctly for out-of-range radices.
1047 (read1): Check for integer overflow in radices, and in
1048 read-circle numbers.
1049 (read_escape): Avoid int overflow.
1050 (Fload, openp, read_buffer_size, read1)
1051 (substitute_object_recurse, read_vector, read_list, map_obarray):
1052 Use ptrdiff_t, not int, for sizes.
1053 (read1): Use EMACS_INT, not int, for sizes.
1054 Check for size overflow.
1055
1056 * image.c (cache_image): Check for size arithmetic overflow.
1057
1058 * lread.c: Integer overflow issues.
1059 (saved_doc_string_size, saved_doc_string_length)
1060 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1061 Now ptrdiff_t, not int.
1062 (read1): Don't assume doc string length fits in int. Check for
1063 out-of-range doc string lengths.
1064 (read_list): Don't assume file position fits in int.
1065 (read_escape): Check for hex character overflow.
1066
1067 2011-06-22 Leo Liu <sdl.web@gmail.com>
1068
1069 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1070 Move to minibuffer.el.
1071
1072 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1075 The following patches are for when GLYPH_DEBUG && !XASSERT.
1076 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1077 * dispnew.c (flush_stdout):
1078 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1079 Mark as externally visible.
1080 * dispnew.c (check_window_matrix_pointers): Now static.
1081 * dispnew.c (window_to_frame_vpos):
1082 * xfns.c (unwind_create_frame):
1083 * xterm.c (x_check_font): Remove unused local.
1084 * scroll.c (CHECK_BOUNDS):
1085 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1086 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1087 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1088 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1089 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1090 Now static.
1091 (debug_method_add): Use va_list and vsprintf rather than relying
1092 on undefined behavior with wrong number of arguments.
1093 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1094 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1095 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1096 since we're not interested in debugging glyphs with old libraries.
1097 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1098 GCC 4.6.0's static checking.
1099
1100 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Integer overflow and signedness fixes (Bug#8873).
1103 A few related buffer overrun fixes, too.
1104
1105 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1106
1107 * dispextern.h (struct face.stipple):
1108 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1109 (x_bitmap_mask, x_allocate_bitmap_record)
1110 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1111 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1112 (x_create_bitmap_from_xpm_data):
1113 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1114 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1115 (.bitmaps_last):
1116 * xfaces.c (load_pixmap):
1117 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1118 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1119 (.bitmaps_last, struct x_output.icon_bitmap):
1120 Use ptrdiff_t, not int, for bitmap indexes.
1121 (x_allocate_bitmap_record): Check for size overflow.
1122 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1123
1124 Use ptrdiff_t, not int, for overlay counts.
1125 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1126 * editfns.c (overlays_around, get_pos_property):
1127 * textprop.c (get_char_property_and_overlay):
1128 * xdisp.c (next_overlay_change, note_mouse_highlight):
1129 * xfaces.c (face_at_buffer_position):
1130 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1131 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1132 (Fnext_overlay_change, Fprevious_overlay_change)
1133 (mouse_face_overlay_overlaps, Foverlays_in):
1134 Use ptrdiff_t, not int, for sizes.
1135 (overlays_at, overlays_in): Check for size-calculation overflow.
1136
1137 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1138
1139 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1140 (x_session_initialize): Do not assume string length fits in int.
1141
1142 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1143 This is unlikely, but can occur if DPI is outlandish.
1144
1145 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1146 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1147
1148 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1149 * xrdb.c (magic_file_p, search_magic_path):
1150 Omit last arg SUFFIX; it was always 0. All callers changed.
1151 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1152
1153 * xfont.c (xfont_match): Avoid need for strlen.
1154
1155 * xfns.c: Don't assume strlen fits in int.
1156 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1157
1158 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1159 not unsigned long, as we prefer signed integers. All callers changed.
1160 Detect integer overflow in repeat count.
1161 (message_dolog): Don't assume print length fits in 39 bytes.
1162 (display_mode_element): Don't assume strlen fits in int.
1163
1164 * termcap.c: Don't assume sizes fit in int and never overflow.
1165 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1166 (gobble_line): Check for size-calculation overflow.
1167
1168 * minibuf.c (Fread_buffer):
1169 * lread.c (intern, intern_c_string):
1170 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1171 Don't assume string length fits in int.
1172
1173 * keyboard.c (parse_tool_bar_item):
1174 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1175
1176 * font.c: Don't assume string length fits in int.
1177 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1178 Use ptrdiff_t, not int.
1179 (font_intern_prop): Don't assume string length fits in int.
1180 Don't assume integer property fits in fixnum.
1181 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1182
1183 * filelock.c: Fix some buffer overrun and integer overflow issues.
1184 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1185 Reformulate so as not to need the command string.
1186 Invoke gzip -cd rather than gunzip, as it's more portable.
1187 (lock_info_type, lock_file_1, lock_file):
1188 Don't assume pid_t and time_t fit in unsigned long.
1189 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1190 (current_lock_owner): Prefer signed type for sizes.
1191 Use memcpy, not strncpy, where memcpy is what is really wanted.
1192 Don't assume (via atoi) that time_t and pid_t fit in int.
1193 Check for time_t and/or pid_t out of range, e.g., via a network share.
1194 Don't alloca where an auto var works fine.
1195
1196 * fileio.c: Fix some integer overflow issues.
1197 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1198 Don't assume string length fits in int.
1199 (directory_file_name): Don't assume string length fits in long.
1200 (make_temp_name): Don't assume pid fits in int, or that its print
1201 length is less than 20.
1202
1203 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1204
1205 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1206
1207 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1208
1209 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1210 We prefer signed integers, even for size calculations.
1211
1212 * emacs.c: Don't assume string length fits in 'int'.
1213 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1214 (main): Don't invoke strlen when not needed.
1215
1216 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1217 (XD_DEBUG_MESSAGE): Don't waste a byte.
1218
1219 * callproc.c (getenv_internal_1, getenv_internal)
1220 (Fgetenv_internal):
1221 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1222
1223 * lread.c (invalid_syntax): Omit length argument.
1224 All uses changed. This doesn't fix a bug, but it simplifies the
1225 code away from its former Hollerith-constant appearance, and it's
1226 one less 'int' to worry about when looking at integer-overflow issues.
1227 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1228
1229 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1230 This didn't break anything, but it didn't help either.
1231 It's confusing to put a bogus integer in a place where the actual
1232 value does not matter.
1233 (LIST_END_P): Remove unused macro and its bogus comment.
1234 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1235
1236 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1237 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1238 implementation.
1239 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1240 We prefer signed types, and the value cannot exceed the EMACS_INT
1241 range anyway (because otherwise the length would not be representable).
1242 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1243 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1244 This avoids a GCC warning when WIDE_EMACS_INT.
1245
1246 * indent.c (sane_tab_width): New function.
1247 (current_column, scan_for_column, Findent_to, position_indentation)
1248 (compute_motion): Use it. This is just for clarity.
1249 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1250
1251 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1252
1253 * lisp.h (lint_assume): New macro.
1254 * composite.c (composition_gstring_put_cache):
1255 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1256
1257 * editfns.c, insdel.c:
1258 Omit unnecessary forward decls, to simplify future changes.
1259
1260 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1261
1262 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1263
1264 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1265 Use much-faster test for byte-length change.
1266 Don't assume string byte-length fits in 'int'.
1267 Check that character arg fits in 'int'.
1268 (mapcar1): Declare byte as byte, for clarity.
1269
1270 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1271
1272 * fns.c (concat): Catch string overflow earlier.
1273 Do not rely on integer wraparound.
1274
1275 * dispextern.h (struct it.overlay_strings_charpos)
1276 (struct it.selective): Now EMACS_INT, not int.
1277 * xdisp.c (forward_to_next_line_start)
1278 (back_to_previous_visible_line_start)
1279 (reseat_at_next_visible_line_start, next_element_from_buffer):
1280 Don't arbitrarily truncate the value of 'selective' to int.
1281
1282 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1283
1284 * composite.c: Don't truncate sizes to 'int'.
1285 (composition_gstring_p, composition_reseat_it)
1286 (composition_adjust_point): Use EMACS_INT, not int.
1287 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1288 not EMACS_UINT, for indexes.
1289
1290 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1291
1292 * buffer.c: Include <verify.h>.
1293 (struct sortvec.priority, struct sortstr.priority):
1294 Now EMACS_INT, not int.
1295 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1296 (struct sortstr.size, record_overlay_string)
1297 (struct sortstrlist.size, struct sortlist.used):
1298 Don't truncate size to int.
1299 (record_overlay_string): Check for size-calculation overflow.
1300 (init_buffer_once): Check at compile-time, not run-time.
1301
1302 2011-06-22 Jim Meyering <meyering@redhat.com>
1303
1304 Don't leak an XBM-image-sized buffer
1305 * image.c (xbm_load): Free the image buffer after using it.
1306
1307 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 Port to Sun C.
1310 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1311 that Sun C diagnosed.
1312 * fns.c (secure_hash): Fix pointer signedness issue.
1313 * intervals.c (static_offset_intervals): New function.
1314 (offset_intervals): Use it.
1315
1316 2011-06-21 Leo Liu <sdl.web@gmail.com>
1317
1318 * deps.mk (fns.o):
1319 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1320 sha512.h.
1321
1322 * fns.c (secure_hash): Rename from crypto_hash_function and change
1323 the first arg to accept symbols.
1324 (Fsecure_hash): New primitive.
1325 (syms_of_fns): New symbols.
1326
1327 2011-06-20 Deniz Dogan <deniz@dogan.se>
1328
1329 * process.c (Fset_process_buffer): Clarify return value in
1330 docstring.
1331
1332 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1333
1334 * dispnew.c (add_window_display_history): Use BVAR.
1335
1336 * xdisp.c (debug_method_add): Use BVAR.
1337 (check_window_end, dump_glyph_matrix, dump_glyph)
1338 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1339
1340 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1341 Likewise.
1342
1343 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1344 check till after the cache is created in init_frame_faces.
1345
1346 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1347
1348 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1349
1350 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1353 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1354 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1355
1356 Improve buffer-overflow checking (Bug#8873).
1357 * fileio.c (Finsert_file_contents):
1358 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1359 Remove the old (too-loose) buffer overflow checks.
1360 They weren't needed, since make_gap checks for buffer overflow.
1361 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1362 The old code merely checked for Emacs fixnum overflow, and relied
1363 on undefined (wraparound) behavior. The new code avoids undefined
1364 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1365
1366 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1367 Tune. Don't use wider integers than needed. Don't use alloca.
1368 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1369
1370 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1371
1372 * insdel.c, lisp.h (buffer_overflow): New function.
1373 (insert_from_buffer_1, replace_range, replace_range_2):
1374 * insdel.c (make_gap_larger):
1375 * editfns.c (Finsert_char):
1376 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1377
1378 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1379
1380 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 Integer overflow and signedness fixes (Bug#8873).
1383
1384 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1385 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1386
1387 * fileio.c: Don't assume EMACS_INT fits in off_t.
1388 (emacs_lseek): New static function.
1389 (Finsert_file_contents, Fwrite_region): Use it.
1390 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1391
1392 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1393
1394 * fns.c: Don't overflow int when computing a list length.
1395 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1396 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1397 truncation on 64-bit hosts. Check for QUIT every
1398 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1399 faster and is responsive enough.
1400 (Flength): Report an error instead of overflowing an integer.
1401 (Fsafe_length): Return a float if the value is not representable
1402 as a fixnum. This shouldn't happen except in contrived situations.
1403 (Fnthcdr, Fsort): Don't assume list length fits in int.
1404 (Fcopy_sequence): Don't assume vector length fits in int.
1405
1406 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1407 (header_size, word_size): New constants.
1408 (allocate_vectorlike): Don't check size overflow here.
1409 (allocate_vector): Check it here instead, since this is the only
1410 caller of allocate_vectorlike that could cause overflow.
1411 Check that the new vector's length is representable as a fixnum.
1412
1413 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1414 The previous code was bogus. For example, next_almost_prime (32)
1415 returned 39, which is undesirable as it is a multiple of 3; and
1416 next_almost_prime (24) returned 25, which is a multiple of 5 so
1417 why was the code bothering to check for multiples of 7?
1418
1419 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1420
1421 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1422
1423 Variadic C functions now count arguments with ptrdiff_t.
1424 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1425 Back then I didn't know that the Emacs coding style prefers signed int.
1426 Also, in the meantime I found a few more instances where arguments
1427 were being counted with int, which may truncate counts on 64-bit
1428 machines, or EMACS_INT, which may be unnecessarily wide.
1429 * lisp.h (struct Lisp_Subr.function.aMANY)
1430 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1431 Arg counts are now ptrdiff_t, not size_t.
1432 All variadic functions and their callers changed accordingly.
1433 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1434 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1435 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1436 * callint.c (Fcall_interactively): Check arg count for overflow,
1437 to avoid potential buffer overrun. Use signed char, not 'int',
1438 for 'varies' array, so that we needn't bother to check its size
1439 calculation for overflow.
1440 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1441 * eval.c (apply_lambda):
1442 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1443 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1444 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1445
1446 * callint.c (Fcall_interactively): Don't use index var as event count.
1447
1448 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1449 * mem-limits.h (SIZE): Remove; no longer used.
1450
1451 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1452
1453 Remove unnecessary casts.
1454 * xterm.c (x_term_init):
1455 * xfns.c (x_set_border_pixel):
1456 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1457 These aren't needed now that we assume ANSI C.
1458
1459 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1460 It's more likely to cause problems (due to unsigned overflow)
1461 than to cure them.
1462
1463 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1464
1465 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1466
1467 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1468
1469 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1470
1471 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1472
1473 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1474
1475 GLYPH_CODE_FACE returns EMACS_INT, not int.
1476 * dispextern.h (merge_faces):
1477 * xfaces.c (merge_faces):
1478 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1479 Don't assume EMACS_INT fits in int.
1480
1481 * character.h (CHAR_VALID_P): Remove unused parameter.
1482 * fontset.c, lisp.h, xdisp.c: All uses changed.
1483
1484 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1485
1486 * fns.c (concat): Minor tuning based on overflow analysis.
1487 This doesn't fix any bugs. Use int to hold character, instead
1488 of constantly refetching from Emacs object. Use XFASTINT, not
1489 XINT, for value known to be a character. Don't bother comparing
1490 a single byte to 0400, as it's always less.
1491
1492 * floatfns.c (Fexpt):
1493 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1494
1495 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1496 for characters.
1497
1498 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1499
1500 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1501 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1502 incorrectly succeed when S was a string, because 4294967386 was
1503 truncated before it was used.
1504
1505 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1506 Otherwise, an out-of-range integer could cause undefined behavior
1507 on a 64-bit host.
1508
1509 * composite.c: Use int, not EMACS_INT, for characters.
1510 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1511 EMACS_INT, for values that are known to be in character range.
1512 This doesn't fix any bugs but is the usual style inside Emacs and
1513 may generate better code on 32-bit machines.
1514
1515 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1516 This is for reasons similar to the recent CHAR_STRING fix.
1517 * charset.c (Fencode_char): Check that character arg is actually
1518 a character. Pass an int to ENCODE_CHAR.
1519 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1520 wider than 'int', as a compile-time check to prevent future regressions
1521 in this area.
1522
1523 * character.c (char_string): Remove unnecessary casts.
1524
1525 Make sure a 64-bit char is never passed to CHAR_STRING.
1526 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1527 by silently ignoring the top 32 bits, allowing some values
1528 that were far too large to be valid characters.
1529 * character.h: Include <verify.h>.
1530 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1531 arguments are no wider than unsigned, as a compile-time check
1532 to prevent future regressions in this area.
1533 * data.c (Faset):
1534 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1535 (Fsubst_char_in_region):
1536 * fns.c (concat):
1537 * xdisp.c (decode_mode_spec_coding):
1538 Adjust to CHAR_STRING's new requirement.
1539 * editfns.c (Finsert_char, Fsubst_char_in_region):
1540 * fns.c (concat): Check that character args are actually
1541 characters. Without this test, these functions did the wrong
1542 thing with wildly out-of-range values on 64-bit hosts.
1543
1544 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1545 These casts should not be needed on 32-bit hosts, either.
1546 * keyboard.c (read_char):
1547 * lread.c (Fload): Remove casts to unsigned.
1548
1549 * lisp.h (UNSIGNED_CMP): New macro.
1550 This fixes comparison bugs on 64-bit hosts.
1551 (ASCII_CHAR_P): Use it.
1552 * casefiddle.c (casify_object):
1553 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1554 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1555 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1556 * dispextern.h (FACE_FROM_ID):
1557 * keyboard.c (read_char): Use UNSIGNED_CMP.
1558
1559 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1560 not to EMACS_INT, to avoid GCC warning.
1561
1562 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1563
1564 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1565 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1566 isn't needed on 32-bit machines.
1567
1568 * buffer.c (Fgenerate_new_buffer_name):
1569 Use EMACS_INT for count, not int.
1570 (advance_to_char_boundary): Return EMACS_INT, not int.
1571
1572 * data.c (Qcompiled_function): Now static.
1573
1574 * window.c (window_body_lines): Now static.
1575
1576 * image.c (gif_load): Rename local to avoid shadowing.
1577
1578 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1579 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1580 * alloc.c (make_save_value): Integer argument is now of type
1581 ptrdiff_t, not int.
1582 (mark_object): Use ptrdiff_t, not int.
1583 * lisp.h (pD): New macro.
1584 * print.c (print_object): Use it.
1585
1586 * alloc.c: Use EMACS_INT, not int, to count objects.
1587 (total_conses, total_markers, total_symbols, total_vector_size)
1588 (total_free_conses, total_free_markers, total_free_symbols)
1589 (total_free_floats, total_floats, total_free_intervals)
1590 (total_intervals, total_strings, total_free_strings):
1591 Now EMACS_INT, not int. All uses changed.
1592 (Fgarbage_collect): Compute overall total using a double, so that
1593 integer overflow is less likely to be a problem. Check for overflow
1594 when converting back to an integer.
1595 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1596 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1597 These were 'int' variables that could overflow on 64-bit hosts;
1598 they were never used, so remove them instead of repairing them.
1599 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1600 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1601 Previously, this ceilinged at INT_MAX, but that doesn't work on
1602 64-bit machines.
1603 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1604
1605 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1606 (allocate_vectorlike): Check for ptrdiff_t overflow.
1607 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1608 when a (possibly-narrower) signed value would do just as well.
1609 We prefer using signed arithmetic, to avoid comparison confusion.
1610
1611 * alloc.c: Catch some string size overflows that we were missing.
1612 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1613 for convenience in STRING_BYTES_MAX.
1614 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1615 The definition here is exact; the one in lisp.h was approximate.
1616 (allocate_string_data): Check for string overflow. This catches
1617 some instances we weren't catching before. Also, it catches
1618 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1619 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1620 and ptrdiff_t and EMACS_INT are both 64 bits.
1621
1622 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1623 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1624 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1625
1626 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1627
1628 * alloc.c (Fmake_string): Check for out-of-range init.
1629
1630 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1631
1632 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1633
1634 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1635
1636 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1637 xg_get_default_scrollbar_width.
1638
1639 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1640 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1641 (style_changed_cb): Call update_theme_scrollbar_width and call
1642 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1643 all frames (Bug#8505).
1644 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1645 Call gtk_window_set_resizable if HAVE_GTK3.
1646 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1647 and height if HAVE_GTK3 (Bug#8505).
1648 (scroll_bar_width_for_theme): New variable.
1649 (update_theme_scrollbar_width): New function.
1650 (xg_get_default_scrollbar_width): Move code to
1651 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1652 (xg_initialize): Call update_theme_scrollbar_width.
1653
1654 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1655
1656 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1657
1658 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1659
1660 * frame.c (make_frame): Call other_buffer_safely instead of
1661 other_buffer.
1662
1663 * window.c (temp_output_buffer_show): Call display_buffer with
1664 second argument Vtemp_buffer_show_specifiers and reset latter
1665 immediately after the call.
1666 (Vtemp_buffer_show_specifiers): New variable.
1667 (auto_window_vscroll_p, next_screen_context_lines)
1668 (Vscroll_preserve_screen_position): Remove leading asterisks from
1669 doc-strings.
1670
1671 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 Fix minor problems found by GCC 4.6.0 static checking.
1674 * buffer.c (Qclone_number): Remove for now, as it's unused.
1675 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1676 (record_buffer): Remove unused local.
1677 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1678 (set_frame_buffer_list): Remove; unused.
1679 * frame.h (other_visible_frames): Remove decl.
1680 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1681 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1682 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1683 if HAVE_GPM.
1684 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1685 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1686 Define only if HAVE_GPM.
1687 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1688 (update_hints_inhibit): Remove; never set. All uses removed.
1689 * widgetprv.h (emacsFrameClassRec): Remove decl.
1690 * window.c (delete_deletable_window): Now returns void, since it
1691 wasn't returning anything.
1692 (compare_window_configurations): Remove unused locals.
1693 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1694 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1695 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1696 the same widths as pointers. This follows up on the 2011-05-06 patch.
1697 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1698 * xterm.h: Likewise.
1699 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1700
1701 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1702
1703 * makefile.w32-in: Update dependencies.
1704 (LISP_H): Add lib/intprops.h.
1705
1706 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1707
1708 * image.c (gif_load): Add animation frame delay to the metadata.
1709 (syms_of_image): Use DEFSYM. New symbol `delay'.
1710
1711 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1712
1713 * window.c (delete_deletable_window): Re-add.
1714 (Fset_window_configuration): Rewrite to handle dead buffers and
1715 consequently deletable windows.
1716 (window_tree, Fwindow_tree): Remove. Supply functionality in
1717 window.el.
1718 (compare_window_configurations): Simplify code.
1719
1720 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1721
1722 * image.c (imagemagick_load_image): Fix type mismatch.
1723 (Fimagemagick_types): Likewise.
1724
1725 * window.h (replace_buffer_in_windows): Declare.
1726
1727 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1728
1729 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1730 Qclone_number. Remove external declaration of Qdelete_window.
1731 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1732 code.
1733 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1734 Qbuffer_list_update_hook if allowed.
1735 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1736 buffer list implementation.
1737 (other_buffer_safely): New function.
1738 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1739 calls to replace_buffer_in_windows and
1740 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1741 if allowed.
1742 (record_buffer): Inhibit quitting and rewrite using quittable
1743 functions. Run Qbuffer_list_update_hook if allowed.
1744 (Frecord_buffer, Funrecord_buffer): New functions.
1745 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1746 switch-to-buffer to window.el.
1747 (bury-buffer): Move to window.el.
1748 (Vbuffer_list_update_hook): New variable.
1749
1750 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1751 section.
1752
1753 * window.h (resize_frame_windows): Move up in code.
1754 (Fwindow_frame): Remove EXFUN.
1755 (replace_buffer_in_all_windows): Remove prototype.
1756 (replace_buffer_in_windows_safely): Add prototype.
1757
1758 * window.c: Declare Qdelete_window static again. Move down
1759 declaration of select_count.
1760 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1761 (Fother_window): Move to window.el.
1762 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1763 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1764 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1765 window.el.
1766 (replace_buffer_in_windows): Implement by calling
1767 Qreplace_buffer_in_windows.
1768 (replace_buffer_in_all_windows): Remove with some functionality
1769 moved into replace_buffer_in_windows_safely.
1770 (replace_buffer_in_windows_safely): New function.
1771 (select_window_norecord, select_frame_norecord): Move in front
1772 of run_window_configuration_change_hook. Remove now obsolete
1773 declarations.
1774 (Fset_window_buffer): Rewrite doc-string. Call
1775 Qrecord_window_buffer.
1776 (keys_of_window): Move binding for other-window to window.el.
1777
1778 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1779
1780 * dispextern.h (struct image): Replace data member, whose int_val
1781 and ptr_val fields were not used by anything, with a single
1782 lisp_val object.
1783
1784 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1785 (gif_clear_image, gif_load, imagemagick_load_image)
1786 (gs_clear_image, gs_load): Callers changed.
1787
1788 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * buffer.h: Include <time.h>, for time_t.
1791 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1792
1793 Fix minor problems found by static checking.
1794
1795 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1796
1797 Make identifiers static if they are not used in other modules.
1798 * data.c (Qcompiled_function, Qframe, Qvector):
1799 * image.c (QimageMagick, Qsvg):
1800 * minibuf.c (Qmetadata):
1801 * window.c (resize_window_check, resize_root_window): Now static.
1802 * window.h (resize_window_check, resize_root_window): Remove decls.
1803
1804 * window.c (window_deletion_count, delete_deletable_window):
1805 Remove; unused.
1806 (window_body_lines): Now static.
1807 (Fdelete_other_windows_internal): Mark vars as initialized.
1808 Make sure 'resize_failed' is initialized.
1809 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1810 (resize_window_apply): Remove unused local.
1811 * window.h (delete_deletable_window): Remove decl.
1812
1813 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1814 (imagemagick_load_image): Fix pointer signedness problem by changing
1815 last arg from unsigned char * to char *. All uses changed.
1816 Also, fix a local for similar reasons.
1817 Remove unused locals. Remove locals to avoid shadowing.
1818 (fn_rsvg_handle_free): Remove; unused.
1819 (svg_load, svg_load_image): Fix pointer signedness problem.
1820 (imagemagick_load_image): Don't use garbage pointer image_wand.
1821
1822 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1823
1824 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * image.c (gif_load): Fix omitted cast error introduced by
1827 2011-06-06 change.
1828
1829 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1830
1831 * window.h (resize_proportionally, orig_total_lines)
1832 (orig_top_line): Remove from window structure.
1833 (set_window_height, set_window_width, change_window_heights)
1834 (Fdelete_window): Remove prototypes.
1835 (resize_frame_windows): Remove duplicate declaration.
1836
1837 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1838
1839 * window.h (resize_frame_windows, resize_window_check)
1840 (delete_deletable_window, resize_root_window)
1841 (resize_frame_windows): Declare prototypes.
1842
1843 * window.c (resize_window_apply): Make definition be "static" to
1844 match the prototype.
1845
1846 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1847
1848 * window.c: Remove declarations of Qwindow_size_fixed,
1849 window_min_size_1, window_min_size_2, window_min_size,
1850 size_window, window_fixed_size_p, enlarge_window, delete_window.
1851 Remove static from declaration of Qdelete_window, it's
1852 temporarily needed by Fbury_buffer.
1853 (replace_window): Don't assign orig_top_line and
1854 orig_total_lines.
1855 (Fdelete_window, delete_window): Remove. Window deletion is
1856 handled by window.el.
1857 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1858 Fdelete_window calls with calls to Qdelete_window.
1859 (Fdelete_other_windows): Remove. Deleting other windows is
1860 handled by window.el.
1861 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1862 handled in window.el.
1863 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1864 Window minimum sizes are handled in window.el.
1865 (shrink_windows, size_window, set_window_height)
1866 (set_window_width, change_window_heights, window_height)
1867 (window_width, CURBEG, CURSIZE, enlarge_window)
1868 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1869 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1870 handled in window.el.
1871 (make_dummy_parent): Rename to make_parent_window and give it a
1872 second argument horflag.
1873 (make_window): Don't set resize_proportionally any more.
1874 (Fsplit_window): Remove. Windows are split in window.el.
1875 (save_restore_action, save_restore_orig_size)
1876 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1877 Resize mini windows in window.el.
1878 (grow_mini_window, shrink_mini_window): Implement by calling
1879 Qresize_root_window_vertically, resize_window_check and
1880 resize_window_apply.
1881 (saved_window, Fset_window_configuration, save_window_save): Do
1882 not handle orig_top_line, orig_total_lines, and
1883 resize_proportionally.
1884 (window_min_height, window_min_width): Move to window.el.
1885 (keys_of_window): Move bindings for delete-other-windows,
1886 split-window, delete-window and enlarge-window to window.el.
1887
1888 * buffer.c: Temporarily extern Qdelete_window.
1889 (Fbury_buffer): Temporarily call Qdelete_window instead of
1890 Fdelete_window (Fbury_buffer will move to window.el soon).
1891
1892 * frame.c (set_menu_bar_lines_1): Remove code handling
1893 orig_top_line and orig_total_lines.
1894
1895 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1896 set_window_height but set heights directly.
1897 (change_frame_size_1): Use resize_frame_windows.
1898
1899 * xdisp.c (init_xdisp): Don't use set_window_height but set
1900 heights directly.
1901
1902 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1903 resize_frame_windows instead of change_window_heights and run
1904 run_window_configuration_change_hook.
1905
1906 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1907 instead of change_window_heights and run
1908 run_window_configuration_change_hook.
1909
1910 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1911
1912 * window.c (replace_window): Rename second argument REPLACEMENT to
1913 NEW. New third argument SETFLAG. Rewrite.
1914 (delete_window, make_dummy_parent): Call replace_window with
1915 third argument 1.
1916 (window_list_1): Move down in code.
1917 (run_window_configuration_change_hook): Move set_buffer part
1918 before select_frame_norecord part in order to unwind correctly.
1919 Rename count1 to count.
1920 (recombine_windows, delete_deletable_window, resize_root_window)
1921 (Fdelete_other_windows_internal)
1922 (Frun_window_configuration_change_hook, make_parent_window)
1923 (resize_window_check, resize_window_apply, Fresize_window_apply)
1924 (resize_frame_windows, Fsplit_window_internal)
1925 (Fdelete_window_internal, Fresize_mini_window_internal): New
1926 functions.
1927 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1928
1929 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1930
1931 * window.h (window): Add some new members to window structure -
1932 normal_lines, normal_cols, new_total, new_normal, clone_number,
1933 splits, nest, prev_buffers, next_buffers.
1934 (WINDOW_TOTAL_SIZE): Move here from window.c.
1935 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1936
1937 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1938 Remove.
1939 (make_dummy_parent): Set new members of windows structure.
1940 (make_window): Move down in code. Handle new members of window
1941 structure.
1942 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1943 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1944 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1945 (Fset_window_prev_buffers, Fwindow_next_buffers)
1946 (Fset_window_next_buffers, Fset_window_clone_number): New
1947 functions.
1948 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1949 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1950 Doc-string fixes.
1951 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1952 Argument WINDOW can be now internal window too.
1953 (Fwindow_use_time): Move up in code.
1954 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1955 Rewrite doc-string.
1956 (Fset_window_configuration, saved_window)
1957 (Fcurrent_window_configuration, save_window_save): Handle new
1958 members of window structure.
1959 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1960 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1961 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1962 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1963 Qget_mru_window, Qresize_root_window,
1964 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1965 Qauto_buffer_name; staticpro them.
1966
1967 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1968
1969 * window.c (Fwindow_total_size, Fwindow_left_column)
1970 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1971 (Fwindow_list_1): New functions.
1972 (window_box_text_cols): Replace with window_body_cols.
1973 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1974 window_body_cols instead of window_box_text_cols.
1975 (delete_window, Fset_window_configuration): Call
1976 delete_all_subwindows with window as argument.
1977 (delete_all_subwindows): Take a window as argument and not a
1978 structure. Rewrite.
1979 (window_loop): Remove handling of GET_LRU_WINDOW and
1980 GET_LARGEST_WINDOW.
1981 (Fget_lru_window, Fget_largest_window): Move to window.el.
1982
1983 * window.h: Extern window_body_cols instead of
1984 window_box_text_cols. delete_all_subwindows now takes a
1985 Lisp_Object as argument.
1986
1987 * indent.c (compute_motion, Fcompute_motion): Use
1988 window_body_cols instead of window_box_text_cols.
1989
1990 * frame.c (delete_frame): Call delete_all_subwindows with root
1991 window as argument.
1992
1993 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1994
1995 * fns.c (Fputhash): Document return value.
1996
1997 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1998
1999 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2000
2001 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 Cons<->int and similar integer overflow fixes (Bug#8794).
2004
2005 Check for overflow when converting integer to cons and back.
2006 * charset.c (Fdefine_charset_internal, Fdecode_char):
2007 Use cons_to_unsigned to catch overflow.
2008 (Fencode_char): Use INTEGER_TO_CONS.
2009 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2010 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2011 * data.c (long_to_cons, cons_to_long): Remove.
2012 (cons_to_unsigned, cons_to_signed): New functions.
2013 These signal an error for invalid or out-of-range values.
2014 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2015 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2016 * font.c (Ffont_variation_glyphs):
2017 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2018 * lisp.h: Include <intprops.h>.
2019 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2020 (cons_to_signed, cons_to_unsigned): New decls.
2021 (long_to_cons, cons_to_long): Remove decls.
2022 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2023 (Fprimitive_undo): Use CONS_TO_INTEGER.
2024 * xfns.c (Fx_window_property): Likewise.
2025 * xselect.c: Include <limits.h>.
2026 (x_own_selection, selection_data_to_lisp_data):
2027 Use INTEGER_TO_CONS.
2028 (x_handle_selection_request, x_handle_selection_clear)
2029 (x_get_foreign_selection, Fx_disown_selection_internal)
2030 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2031 (lisp_data_to_selection_data): Use cons_to_unsigned.
2032 (x_fill_property_data): Use cons_to_signed.
2033 Report values out of range.
2034
2035 Check for buffer and string overflow more precisely.
2036 * buffer.h (BUF_BYTES_MAX): New macro.
2037 * lisp.h (STRING_BYTES_MAX): New macro.
2038 * alloc.c (Fmake_string):
2039 * character.c (string_escape_byte8):
2040 * coding.c (coding_alloc_by_realloc):
2041 * doprnt.c (doprnt):
2042 * editfns.c (Fformat):
2043 * eval.c (verror):
2044 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2045 since they may not be the same number.
2046 * editfns.c (Finsert_char):
2047 * fileio.c (Finsert_file_contents):
2048 Likewise for BUF_BYTES_MAX.
2049
2050 * image.c: Use ptrdiff_t, not int, for sizes.
2051 (slurp_file): Switch from int to ptrdiff_t.
2052 All uses changed.
2053 (slurp_file): Check that file size fits in both size_t (for
2054 malloc) and ptrdiff_t (for sanity and safety).
2055
2056 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2057 if b->modtime has its maximal value.
2058
2059 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2060
2061 Don't assume time_t can fit into int.
2062 * buffer.h (struct buffer.modtime): Now time_t, not int.
2063 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2064 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2065
2066 Minor fixes for signed vs unsigned integers.
2067 * character.h (MAYBE_UNIFY_CHAR):
2068 * charset.c (maybe_unify_char):
2069 * keyboard.c (read_char, reorder_modifiers):
2070 XINT -> XFASTINT, since the integer must be nonnegative.
2071 * ftfont.c (ftfont_spec_pattern):
2072 * keymap.c (access_keymap, silly_event_symbol_error):
2073 XUINT -> XFASTINT, since the integer must be nonnegative.
2074 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2075 since it makes no difference and we prefer signed.
2076 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2077 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2078 nonnegative.
2079
2080 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * window.h (Fwindow_frame): Declare.
2083
2084 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2087 (SPARE_MEMORY): Always define.
2088 (LARGE_REQUEST): Remove.
2089 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2090
2091 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2092
2093 * lisp.h: Move EXFUNS for Fframe_root_window,
2094 Fframe_first_window and Fset_frame_selected_window to window.h.
2095
2096 * window.h: Move EXFUNS for Fframe_root_window,
2097 Fframe_first_window and Fset_frame_selected_window here from
2098 lisp.h.
2099
2100 * frame.c (Fwindow_frame, Fframe_first_window)
2101 (Fframe_root_window, Fframe_selected_window)
2102 (Fset_frame_selected_window): Move to window.c.
2103 (Factive_minibuffer_window): Move to minibuf.c.
2104 (Fother_visible_frames_p): New function.
2105
2106 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2107
2108 * window.c (decode_window, decode_any_window): Move up in code.
2109 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2110 (inhibit_frame_unsplittable): Remove unused variable.
2111 (Fwindow_buffer): Move up and rewrite doc-string.
2112 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2113 (Fwindow_prev): New functions.
2114 (Fwindow_frame): Move here from frame.c. Accept any window as
2115 argument.
2116 (Fframe_root_window, Fframe_first_window)
2117 (Fframe_selected_window): Move here from frame.c. Accept frame
2118 or arbitrary window as argument. Update doc-strings.
2119 (Fminibuffer_window): Move up in code.
2120 (Fwindow_minibuffer_p): Move up in code and simplify.
2121 (Fset_frame_selected_window): Move here from frame.c.
2122 Marginal rewrite.
2123 (Fselected_window, select_window, Fselect_window): Move up in
2124 code. Minor doc-string fixes.
2125
2126 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2129 Do not assume that spare memory exists; that assumption is valid
2130 only if SYSTEM_MALLOC.
2131 (LARGE_REQUEST): New macro, so that the issue of large requests
2132 is separated from the issue of spare memory.
2133
2134 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2135
2136 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2137 format. (Bug#8806)
2138
2139 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2140
2141 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2142 before statements.
2143
2144 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2145
2146 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2147
2148 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2149
2150 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2151 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2152
2153 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2156
2157 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2158
2159 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2160 (x_clipboard_manager_save): Add return value.
2161 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2162 New error handlers.
2163 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2164 Obey Vx_select_enable_clipboard_manager. Catch errors in
2165 x_clipboard_manager_save (Bug#8779).
2166 (Vx_select_enable_clipboard_manager): New variable.
2167 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2168
2169 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2170
2171 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2172
2173 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2174
2175 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2176 in the current matrix if keep_current_p is non-zero.
2177
2178 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2179
2180 * bidi.c (bidi_level_of_next_char): Fix last change.
2181
2182 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2183
2184 Support bidi reordering of text covered by display properties.
2185
2186 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2187 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2188 (bidi_cache_search, bidi_cache_iterator_state)
2189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2190 (bidi_level_of_next_char, bidi_move_to_visually_next):
2191 Support character positions inside a run of characters covered by a
2192 display string.
2193 (bidi_paragraph_init, bidi_resolve_explicit_1)
2194 (bidi_level_of_next_char): Call bidi_fetch_char and
2195 bidi_fetch_char_advance instead of FETCH_CHAR and
2196 FETCH_CHAR_ADVANCE.
2197 (bidi_init_it): Initialize new members.
2198 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2199 definitions.
2200 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2201 instead of using explicit *_CHAR codes.
2202 (bidi_resolve_explicit, bidi_resolve_weak):
2203 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2204 bidirectional text is supported only in multibyte buffers.
2205 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2206 it to initialize the frame_window_p member of struct bidi_it.
2207 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2208 (bidi_resolve_explicit, bidi_resolve_weak)
2209 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2210 bidi_it->nchars is non-positive.
2211 (bidi_level_of_next_char): Don't try to lookup the cache for the
2212 next/previous character if nothing is cached there yet, or if we
2213 were just reseat()'ed to a new position.
2214
2215 * xdisp.c (set_cursor_from_row): Set start and stop points
2216 according to the row's direction when priming the loop that looks
2217 for the glyph on which to display cursor.
2218 (single_display_spec_intangible_p): Function deleted.
2219 (display_prop_intangible_p): Reimplement to call
2220 handle_display_spec instead of single_display_spec_intangible_p.
2221 Accept 3 additional arguments needed by handle_display_spec.
2222 This fixes incorrect cursor motion across display property with complex
2223 values: lists, `(when COND...)' forms, etc.
2224 (single_display_spec_string_p): Support property values that are
2225 lists with the argument STRING its top-level element.
2226 (display_prop_string_p): Fix the condition for processing a
2227 property that is a list to be consistent with handle_display_spec.
2228 (handle_display_spec): New function, refactored from the
2229 last portion of handle_display_prop.
2230 (compute_display_string_pos): Accept additional argument
2231 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2232 value of a `display' property is a "replacing spec".
2233 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2234 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2235 the display property, but just return a value indicating whether
2236 the display property will replace the characters it covers.
2237 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2238 frame_window_p members of struct bidi_it.
2239 (compute_display_string_pos, compute_display_string_end):
2240 New functions.
2241 (push_it): Accept second argument POSITION, where pop_it should
2242 jump to continue iteration.
2243 (reseat_1): Initialize bidi_it.disp_pos.
2244
2245 * keyboard.c (adjust_point_for_property): Adjust the call to
2246 display_prop_intangible_p to its new signature.
2247
2248 * dispextern.h (struct bidi_it): New member frame_window_p.
2249 (bidi_init_it): Update prototypes.
2250 (display_prop_intangible_p): Update prototype.
2251 (compute_display_string_pos, compute_display_string_end):
2252 Declare prototypes.
2253 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2254 EMACS_INT.
2255
2256 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 Malloc failure behavior now depends on size of allocation.
2259 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2260 * lisp.h: Change signatures accordingly.
2261 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2262 All callers changed. (Bug#8762)
2263
2264 * gnutls.c: Use Emacs's memory allocators.
2265 Without this change, the gnutls library would invoke malloc etc.
2266 directly, which causes problems on non-SYNC_INPUT hosts, and which
2267 runs afoul of improving memory_full behavior. (Bug#8761)
2268 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2269 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2270 xfree instead of the default malloc, realloc, free.
2271 (Fgnutls_boot): No need to check for memory allocation failure,
2272 since xmalloc does that for us.
2273
2274 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2275 * category.c (hash_get_category_set):
2276 * ccl.c (ccl_driver):
2277 * charset.c (Fdefine_charset_internal):
2278 * charset.h (struct charset.hash_index):
2279 * composite.c (get_composition_id, gstring_lookup_cache)
2280 (composition_gstring_put_cache):
2281 * composite.h (struct composition.hash_index):
2282 * dispextern.h (struct image.hash):
2283 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2284 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2285 (hashfn_equal, hashfn_user_defined, make_hash_table)
2286 (maybe_resize_hash_table, hash_lookup, hash_put)
2287 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2288 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2289 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2290 * image.c (make_image, search_image_cache, lookup_image)
2291 (xpm_put_color_table_h):
2292 * lisp.h (struct Lisp_Hash_Table):
2293 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2294 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2295 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2296 * alloc.c (allocate_vectorlike):
2297 Check for overflow in vector size calculations.
2298 * ccl.c (ccl_driver):
2299 Check for overflow when converting EMACS_INT to int.
2300 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2301 need to be updated by these changes.
2302 * fns.c (make_hash_table, maybe_resize_hash_table):
2303 Check for integer overflow with large hash tables.
2304 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2305 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2306 (SXHASH_REDUCE): New macro.
2307 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2308 Use it instead of discarding useful hash info with large hash values.
2309 (sxhash_float): New function.
2310 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2311 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2312 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2313 Rewrite to use FIXNUM_BITS, as this simplifies things.
2314 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2315 Adjust signatures to match updated version of code.
2316 (consing_since_gc): Now EMACS_INT, since a single hash table can
2317 use more than INT_MAX bytes.
2318
2319 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2320
2321 Make it possible to build with GCC-4.6+ -O2 -flto.
2322
2323 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2324
2325 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2326
2327 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2328 Call minibuffer-inactive-mode.
2329
2330 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2333 Update dependencies.
2334
2335 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2336
2337 * data.c (init_data): Remove code for UTS, this system is not
2338 supported anymore.
2339
2340 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2341
2342 Don't force ./temacs to start in terminal mode.
2343
2344 * frame.c (make_initial_frame): Initialize faces in all cases, not
2345 only when CANNOT_DUMP is defined.
2346 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2347
2348 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2349
2350 * dispnew.c (add_window_display_history): Use const for the string
2351 pointer. Remove declaration, not needed.
2352
2353 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 Use 'inline', not 'INLINE'.
2356 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2357 * alloc.c, fontset.c (INLINE): Remove.
2358 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2359 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2360 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2361 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2362 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2363
2364 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2365
2366 Make it possible to run ./temacs.
2367
2368 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2369 syms_of_callproc does the same thing. Remove test for
2370 "initialized", do it in the caller.
2371 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2372
2373 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2374
2375 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2376 (read_minibuf): Use get_minibuffer.
2377 (syms_of_minibuf): Use DEFSYM.
2378 (Qmetadata): New var.
2379 * data.c (Qbuffer): Don't make it static.
2380 (syms_of_data): Use DEFSYM.
2381
2382 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2385 (CCL_CODE_MIN): New macro.
2386
2387 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2390
2391 * eval.c (Qdebug): Now static.
2392 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2393 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2394 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2395
2396 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2397
2398 * image.c: Various fixes to ImageMagick code comments.
2399 (Fimagemagick_types): Doc fix.
2400
2401 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 Minor fixes prompted by GCC 4.6.0 warnings.
2404
2405 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2406
2407 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2408 (x_clipboard_manager_save_all): Move extern decl to ...
2409 * xterm.h: ... here, so that it can be checked for consistency.
2410
2411 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2412
2413 * xselect.c (x_clipboard_manager_save_frame)
2414 (x_clipboard_manager_save_all): New functions.
2415 (Fx_clipboard_manager_save): Lisp function deleted.
2416
2417 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2418 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2419
2420 * xterm.h: Update prototype.
2421
2422 2011-05-28 William Xu <william.xwl@gmail.com>
2423
2424 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2425 exiting (Bug#8239).
2426
2427 2011-05-28 Jim Meyering <meyering@redhat.com>
2428
2429 Avoid a sign-extension bug in crypto_hash_function.
2430 * fns.c (to_uchar): Define.
2431 (crypto_hash_function): Use it to convert some newly-signed
2432 variables to unsigned, to avoid sign-extension bugs. For example,
2433 without this change, (md5 "truc") would evaluate to
2434 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2435 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2436 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2437
2438 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 Integer overflow fixes.
2441
2442 * dbusbind.c: Serial number integer overflow fixes.
2443 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2444 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2445 to hold a serial number that is too large for a fixnum.
2446 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2447 Check for serial numbers out of range. Decode any serial number
2448 that was so large that it became a float. (Bug#8722)
2449
2450 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2451 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2452 Use XFASTINT rather than XUINT when numbers are nonnegative.
2453 (xd_append_arg, Fdbus_method_return_internal):
2454 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2455 arguments, check that Lisp number is nonnegative, rather than
2456 silently wrapping negative numbers around. (Bug#8722)
2457 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2458 (Bug#8722)
2459
2460 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2461
2462 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2463
2464 ccl: add integer overflow checks
2465 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2466 (IN_INT_RANGE): New macros.
2467 (ccl_driver): Use them to check for integer overflow when
2468 decoding a CCL program. Many of the new checks are whether XINT (x)
2469 fits in int; it doesn't always, on 64-bit hosts. The new version
2470 doesn't catch all possible integer overflows, but it's an
2471 improvement. (Bug#8719)
2472
2473 * alloc.c (make_event_array): Use XINT, not XUINT.
2474 There's no need for unsigned here.
2475
2476 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2477 This follows up to the 2011-05-06 change that substituted uintptr_t
2478 for EMACS_INT. This case wasn't caught back then.
2479
2480 Rework Fformat to avoid integer overflow issues.
2481 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2482 now (part of C89). Include <verify.h>.
2483 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2484 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2485 (Fformat): Avoid the prepass trying to compute sizes; it was only
2486 approximate and thus did not catch overflow reliably. Instead, walk
2487 through the format just once, formatting and computing sizes as we go,
2488 checking for integer overflow at every step, and allocating a larger
2489 buffer as needed. Keep track separately whether the format is
2490 multibyte. Keep only the most-recently calculated precision, rather
2491 than them all. Record whether each argument has been converted to
2492 string. Use EMACS_INT, not int, for byte and char and arg counts.
2493 Support field widths and precisions larger than INT_MAX. Avoid
2494 sprintf's undefined behavior with conversion specifications such as %#d
2495 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2496 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2497 formatting out-of-range floating point numbers with int
2498 formats. (Bug#8668)
2499
2500 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2501
2502 * data.c: Avoid integer truncation in expressions involving floats.
2503 * data.c: Include <intprops.h>.
2504 (arith_driver): When there's an integer overflow in an expression
2505 involving floating point, convert the integers to floating point
2506 so that the resulting value does not suffer from catastrophic
2507 integer truncation. For example, on a 64-bit host (* 4
2508 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2509 Do not rely on undefined behavior after integer overflow.
2510
2511 merge count_size_as_multibyte, parse_str_to_multibyte
2512 * character.c, character.h (count_size_as_multibyte):
2513 Rename from parse_str_to_multibyte; all uses changed.
2514 Check for integer overflow.
2515 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2516 since it's now a duplicate of the other. This is more of
2517 a character than a buffer op, so better that it's in character.c.
2518 * fns.c, print.c: Adjust to above changes.
2519
2520 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2523
2524 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2527 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2528 (x_clipboard_manager_save): Now static.
2529 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2530
2531 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2532 (crypto_hash_function): Now static.
2533 Fix pointer signedness problems. Avoid unnecessary initializations.
2534
2535 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2536
2537 * termhooks.h (Vselection_alist): Make it terminal-local.
2538
2539 * terminal.c (create_terminal): Initialize it.
2540
2541 * xselect.c: Support for clipboard managers.
2542 (Vselection_alist): Move to termhooks.h as terminal-local var.
2543 (LOCAL_SELECTION): New macro.
2544 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2545 (symbol_to_x_atom): Remove gratuitous arg.
2546 (x_handle_selection_request, lisp_data_to_selection_data)
2547 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2548 (x_own_selection, x_get_local_selection, x_convert_selection):
2549 New arg, specifying work frame. Use terminal-local Vselection_alist.
2550 (some_frame_on_display): Delete unused function.
2551 (Fx_own_selection_internal, Fx_get_selection_internal)
2552 (Fx_disown_selection_internal, Fx_selection_owner_p)
2553 (Fx_selection_exists_p): New optional frame arg.
2554 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2555 (x_handle_selection_clear): Don't treat other terminals with the
2556 same keyboard specially. Use the terminal-local Vselection_alist.
2557 (x_clear_frame_selections): Use Frun_hook_with_args.
2558
2559 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2560
2561 * xterm.h: Add support for those atoms.
2562
2563 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2564
2565 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2566 (converted_selections, conversion_fail_tag): New global variables.
2567 (x_selection_request_lisp_error): Free the above.
2568 (x_get_local_selection): Remove unnecessary code.
2569 (x_reply_selection_request): Args changed; handle arbitrary array
2570 of converted selections stored in converted_selections.
2571 Separate the XChangeProperty and SelectionNotify steps.
2572 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2573 (x_convert_selection): New function.
2574 (x_handle_selection_event): Simplify.
2575 (x_get_foreign_selection): Don't ignore incoming requests while
2576 waiting for an answer; this will fail when we implement
2577 SAVE_TARGETS, and seems unnecessary anyway.
2578 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2579 (Vx_sent_selection_functions): Doc fix.
2580
2581 2011-05-26 Leo Liu <sdl.web@gmail.com>
2582
2583 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2584
2585 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2586
2587 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2588
2589 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2590 for fringe update if it has periodic bitmap.
2591 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2592 and fringe_bitmap_periodic_p.
2593
2594 * fringe.c (get_fringe_bitmap_data): New function.
2595 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2596 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2597 row. Mark glyph row for fringe update if periodicity changed.
2598
2599 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2600 for fringe update unless it has periodic bitmap.
2601
2602 2011-05-25 Kenichi Handa <handa@m17n.org>
2603
2604 * xdisp.c (get_next_display_element): Set correct it->face_id for
2605 a static composition.
2606
2607 2011-05-24 Leo Liu <sdl.web@gmail.com>
2608
2609 * deps.mk (fns.o):
2610 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2611
2612 * fns.c (crypto_hash_function, Fsha1): New function.
2613 (Fmd5): Use crypto_hash_function.
2614 (syms_of_fns): Add Ssha1.
2615
2616 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * gnutls.c: Remove unused macros.
2619 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2620 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2621 Remove macros that are defined and never used.
2622 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2623
2624 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2625
2626 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2627 (Fx_get_selection_internal): Minor cleanup.
2628 (Fx_own_selection_internal): Rename arguments for consistency with
2629 select.el.
2630
2631 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2634
2635 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2636
2637 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2638
2639 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2640
2641 * dispnew.c (scrolling_window): Don't exclude the case that the
2642 last enabled row in the desired matrix touches the bottom boundary.
2643
2644 2011-05-21 Glenn Morris <rgm@gnu.org>
2645
2646 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2647 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2648 and add some more files.
2649
2650 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2651
2652 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2653 report_file_error introduced by the change from 2011-05-07.
2654
2655 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * systime.h (Time): Define only if emacs is defined.
2658 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2659 where the include path doesn't have X11/X.h by default. See
2660 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2661
2662 2011-05-20 Kenichi Handa <handa@m17n.org>
2663
2664 * composite.c (find_automatic_composition): Fix previous change.
2665
2666 2011-05-20 Glenn Morris <rgm@gnu.org>
2667
2668 * lisp.mk: New file, split from Makefile.in.
2669 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2670 (shortlisp): Remove.
2671 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2672
2673 2011-05-19 Glenn Morris <rgm@gnu.org>
2674
2675 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2676 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2677 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2678 (lisp): Set the order to that of loadup.el.
2679 (shortlisp): Make it a copy of $lisp.
2680 (SOME_MACHINE_LISP): Remove.
2681 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2682 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2683
2684 2011-05-18 Kenichi Handa <handa@m17n.org>
2685
2686 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2687 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2688 (find_automatic_composition): Mostly rewrite for efficiency.
2689
2690 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2691
2692 * makefile.w32-in: Update dependencies.
2693
2694 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2695
2696 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2697 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2698
2699 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 Fix some integer overflow issues, such as string length overflow.
2702
2703 * insdel.c (count_size_as_multibyte): Check for string overflow.
2704
2705 * character.c (lisp_string_width): Check for string overflow.
2706 Use EMACS_INT, not int, for string indexes and lengths; in
2707 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2708 the resulting string length overflows an EMACS_INT; instead,
2709 report a string overflow if no precision given. When checking for
2710 precision exhaustion, use a check that cannot possibly have
2711 integer overflow. (Bug#8675)
2712 * character.h (lisp_string_width): Adjust to new signature.
2713
2714 * alloc.c (string_overflow): New function.
2715 (Fmake_string): Use it. This doesn't change behavior, but saves
2716 a few bytes and will simplify future changes.
2717 * character.c (string_escape_byte8): Likewise.
2718 * lisp.h (string_overflow): New decl.
2719
2720 Fixups, following up to the user-interface timestamp change.
2721 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2722 for UI timestamps, instead of unsigned long.
2723 * msdos.c (mouse_get_pos): Likewise.
2724 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2725 * w32gui.h (Time): Define by including "systime.h" rather than by
2726 declaring it ourselves. (Bug#8664)
2727
2728 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2729 * image.c (clear_image_cache): Likewise.
2730
2731 * term.c (term_mouse_position): Don't assume time_t wraparound.
2732
2733 Be more systematic about user-interface timestamps.
2734 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2735 and sometimes 'EMACS_UINT', to represent these timestamps.
2736 This change causes it to use 'Time' uniformly, as that's what X uses.
2737 This makes the code easier to follow, and makes it easier to catch
2738 integer overflow bugs such as Bug#8664.
2739 * frame.c (Fmouse_position, Fmouse_pixel_position):
2740 Use Time, not unsigned long, for user-interface timestamps.
2741 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2742 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2743 * keyboard.h (last_event_timestamp): Likewise.
2744 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2745 * menu.h (xmenu_show): Likewise.
2746 * term.c (term_mouse_position): Likewise.
2747 * termhooks.h (struct input_event.timestamp): Likewise.
2748 (struct terminal.mouse_position_hook): Likewise.
2749 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2750 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2751 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2752 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2753 what it was before.
2754 * menu.h, termhooks.h: Include "systime.h", for Time.
2755
2756 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2757 Don't assume that the difference between two unsigned long values
2758 can fit into an integer. At this point, we know button_down_time
2759 <= event->timestamp, so the difference must be nonnegative, so
2760 there's no need to cast the result if double-click-time is
2761 nonnegative, as it should be; check that it's nonnegative, just in
2762 case. This bug is triggered when events are more than 2**31 ms
2763 apart (about 25 days). (Bug#8664)
2764
2765 * xselect.c (last_event_timestamp): Remove duplicate decl.
2766 (x_own_selection): Remove needless cast to unsigned long.
2767
2768 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2769 that always fit in int. Use a sentinel instead of a counter, to
2770 avoid a temp and to allay GCC's concerns about possible int overflow.
2771 * frame.h (struct frame): Use int for menu_bar_items_used
2772 instead of EMACS_INT, since it always fits in int.
2773
2774 * menu.c (grow_menu_items): Check for int overflow.
2775
2776 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2777
2778 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2779 Before, the code was not consistent. These values cannot exceed
2780 2**31 - 1 so there's no need to make them unsigned.
2781 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2782 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2783 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2784 as modifiers.
2785 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2786
2787 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2788 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2789 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2790 presumably because the widths might not match.
2791
2792 * window.c (size_window): Avoid needless test at loop start.
2793
2794 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2795
2796 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2797
2798 2011-05-12 Drew Adams <drew.adams@oracle.com>
2799
2800 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2801
2802 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2803
2804 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2805 `width' to `bar_area_x' and `bar_area_width', respectively.
2806 (x_scroll_run): Take account of fringe background extension.
2807
2808 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2809 Rename local vars `left' and `width' to `bar_area_x' and
2810 `bar_area_width', respectively.
2811 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2812 background extension.
2813
2814 2011-05-10 Jim Meyering <meyering@redhat.com>
2815
2816 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2817
2818 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * image.c (Finit_image_library): Return t for built-in image types,
2821 like pbm and xbm. (Bug#8640)
2822
2823 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2824
2825 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2826
2827 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2828
2829 * w32console.c (Fset_screen_color): Doc fix.
2830 (Fget_screen_color): New function.
2831 (syms_of_ntterm): Defsubr it.
2832
2833 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2834 unlink the temporary file if Fcall_process didn't create it in the
2835 first place.
2836 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2837 child process will be redirected to a file specified with `:file'.
2838 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2839 cue to call_process_cleanup not to close that handle.
2840
2841 2011-05-07 Ben Key <bkey76@gmail.com>
2842
2843 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2844 one of two shell specific rules, either bootstrap-temacs-CMD or
2845 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2846 to the previous implementation of the bootstrap-temacs rule.
2847 The bootstrap-temacs-CMD rule is similar to the previous
2848 implementation of the bootstrap-temacs rule except that it
2849 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2850 variable.
2851
2852 These changes, along with some changes to nt/configure.bat,
2853 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2854 earlier fix to add support for --cflags and --ldflags options
2855 that include quotes so that it works whether make uses cmd or
2856 sh as the shell.
2857
2858 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2859
2860 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2861 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2862 is a constant.
2863 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2864 a string. Handle both cases.
2865 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2866 (Fdbus_register_method): Use Qinvalid_function.
2867
2868 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2869
2870 * makefile.w32-in: Update dependencies.
2871 (LISP_H): Add inttypes.h and stdin.h.
2872 (PROCESS_H): Add unistd.h.
2873
2874 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2875
2876 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2877 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2878
2879 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2880
2881 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2882
2883 * term.c (vfatal): Remove stray call to va_end.
2884 It's not needed and the C Standard doesn't allow it here anyway.
2885
2886 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2887 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2888
2889 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2890 bytes.
2891
2892 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2893
2894 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2895
2896 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2897
2898 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2899
2900 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2901
2902 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2903 * charset.c (Fdefine_charset_internal): Don't initialize
2904 charset.code_space[15]. The value was garbage, on hosts with
2905 32-bit int (Bug#8600).
2906
2907 * lread.c (read_integer): Be more consistent with string-to-number.
2908 Use string_to_number to do the actual conversion; this avoids
2909 rounding errors and fixes some other screwups. Without this fix,
2910 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2911 (digit_to_number): Move earlier, for benefit of read_integer.
2912 Return -1 if the digit is out of range for the base, -2 if it is
2913 not a digit in any supported base. (Bug#8602)
2914
2915 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2916
2917 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2918 to match comment at start of function. This also removes a
2919 GCC warning about overflow in a 32+64-bit port.
2920
2921 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2922
2923 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2924 Reported by Stefan Monnier in
2925 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2926 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2927 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2928
2929 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2930 (EMACS_UINTPTR): Likewise, with uintptr_t.
2931
2932 * lisp.h: Prefer 64-bit EMACS_INT if available.
2933 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2934 on 32-bit hosts that have 64-bit int, so that they can access
2935 large files.
2936 However, temporarily disable this change unless the temporary
2937 symbol WIDE_EMACS_INT is defined.
2938
2939 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2940
2941 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2942 This removes an assumption that EMACS_INT and long are the same
2943 width as pointers. The assumption is true for Emacs porting targets
2944 now, but we want to make other targets possible.
2945 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2946 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2947 In the rest of the code, change types of integers that hold casted
2948 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2949 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2950 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2951 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2952 No need to cast type when ORing.
2953 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2954 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2955 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2956 assume EMACS_INT is the same width as char *.
2957 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2958 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2959 Remove no-longer-needed casts.
2960 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2961 (xg_tool_bar_help_callback, xg_make_tool_item):
2962 Use EMACS_INTPTR to hold an integer
2963 that will be cast to void *; this can avoid a GCC warning
2964 if EMACS_INT is not the same width as void *.
2965 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2966 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2967 (current_message_1, set_message_1):
2968 Use a local to convert to proper width without a cast.
2969 * xmenu.c (dialog_selection_callback): Likewise.
2970
2971 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2972 Also, don't assume VALBITS / RAND_BITS is less than 5,
2973 and don't rely on undefined behavior when shifting a 1 left into
2974 the sign bit.
2975 * lisp.h (get_random): Change signature to match.
2976
2977 * lread.c (hash_string): Use size_t, not int, for hash computation.
2978 Normally we prefer signed values; but hashing is special, because
2979 it's better to use unsigned division on hash table sizes so that
2980 the remainder is nonnegative. Also, size_t is the natural width
2981 for hashing into memory. The previous code used 'int', which doesn't
2982 retain enough info to hash well into very large tables.
2983 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2984
2985 * dbusbind.c: Don't possibly lose pointer info when converting.
2986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2987 Use XPNTR rather than XHASH, so that the high-order bits of
2988 the pointer aren't lost when converting through void *.
2989
2990 * eval.c (Fautoload): Don't double-shift a pointer.
2991
2992 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2993
2994 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * gnutls.c (DEF_GNUTLS_FN):
2997 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2998
2999 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3000
3001 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3002 marker. (Bug#8610)
3003
3004 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3005
3006 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3007 New version that can reserve upto 2GB of heap space.
3008
3009 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3010
3011 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3012
3013 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3014
3015 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3016 `gnutls_certificate_set_x509_key_file'.
3017
3018 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3021 Update dependencies.
3022
3023 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3026 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3027 Remove unused parameter `fildes'.
3028 * process.c (read_process_output, send_process): Don't pass it.
3029
3030 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3031
3032 Fix previous change: the library cache is defined in w32.c.
3033 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3034 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3035
3036 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3037
3038 Implement dynamic loading of GnuTLS on Windows.
3039
3040 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3041 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3042 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3043 Declare.
3044
3045 * gnutls.c (Qgnutls_dll): Define.
3046 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3047 (gnutls_*): Declare function pointers.
3048 (init_gnutls_functions): New function to initialize function pointers.
3049 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3050 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3051 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3052 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3053 (emacs_gnutls_write, emacs_gnutls_read)
3054 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3055 (Fgnutls_available_p): New function.
3056 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3057 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3058 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3059
3060 * image.c: Include w32.h.
3061 (Vimage_type_cache): Delete.
3062 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3063 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3064 (w32_delayed_load): Move to w32.c.
3065
3066 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3067
3068 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3069 (w32_delayed_load): Move from image.c. When loading a library, record
3070 its filename in the :loaded-from property of the library id.
3071 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3072 Initialize and staticpro them.
3073 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3074
3075 * process.c: Include lisp.h before w32.h, not after.
3076 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3077 instead of gnutls_record_check_pending.
3078
3079 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3080
3081 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3082
3083 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3084 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3085 as passed in.
3086
3087 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3088
3089 * xterm.c (x_set_frame_alpha): Do not set property on anything
3090 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3091
3092 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3093
3094 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3095
3096 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3097
3098 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3099 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3100 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3101 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3102 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3103 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3104 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3105 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3106 (Qgnutls_bootprop_callbacks_verify): Make static.
3107
3108 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3109
3110 * callproc.c: Indentation fixup.
3111
3112 * sysdep.c (wait_for_termination_1): Make static.
3113 (wait_for_termination, interruptible_wait_for_termination):
3114 Move after wait_for_termination_1.
3115
3116 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3117
3118 * sysdep.c (interruptible_wait_for_termination): New function
3119 which is like wait_for_termination, but allows keyboard
3120 interruptions.
3121
3122 * callproc.c (Fcall_process): Add (:file "file") as an option for
3123 the STDOUT buffer.
3124 (Fcall_process_region): Ditto.
3125
3126 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3127
3128 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3129 rather than `XVECTOR (FOO)->size'.
3130
3131 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3132 inttypes.h, as a gnulib replacement is used if it not available in
3133 system headers.
3134
3135 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3136
3137 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3138 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3139 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3140
3141 * coding.c (coding_alloc_by_realloc): Error out if destination
3142 will grow beyond MOST_POSITIVE_FIXNUM.
3143 (decode_coding_emacs_mule): Abort if there isn't enough place in
3144 charbuf for the composition carryover bytes. Reserve an extra
3145 space for up to 2 characters produced in a loop.
3146 (decode_coding_iso_2022): Abort if there isn't enough place in
3147 charbuf for the composition carryover bytes.
3148
3149 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3150
3151 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3152 aborting when %lld or %lll format is passed.
3153 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3154 %llo or %llx format is passed. (Bug#8545)
3155
3156 * window.c (window_scroll_line_based): Use a marker instead of
3157 simple variables to record original value of point. (Bug#7952)
3158
3159 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3160 produced by %s or %c overflows available buffer space. (Bug#8545)
3161
3162 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3163
3164 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3165 (SIZE_MAX): Move defn after all includes, as they might #define it.
3166
3167 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3168
3169 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3170
3171 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * keyboard.c (Qdelayed_warnings_hook): Define.
3174 (command_loop_1): Run `delayed-warnings-hook'
3175 if Vdelayed_warnings_list is non-nil.
3176 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3177 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3178
3179 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3180
3181 * doprnt.c (doprnt): Don't return value smaller than the buffer
3182 size if the message was truncated. (Bug#8545).
3183
3184 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3185
3186 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3187 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3188
3189 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3192
3193 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3194
3195 * makefile.w32-in: Update dependencies.
3196
3197 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3198
3199 Improve `doprnt' and its usage. (Bug#8545)
3200 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3201 `format_end'. Remove support for %l as a conversion specifier.
3202 Don't use xrealloc. Improve diagnostics when the %l size modifier
3203 is used. Update the commentary.
3204
3205 * eval.c (verror): Simplify calculation of size_t.
3206
3207 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3208 messages.
3209
3210 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3211
3212 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3213 change.
3214
3215 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3218 This makes this file independent of the recent pseudovector change.
3219
3220 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3223
3224 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3225 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3226 Remove unused local.
3227 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3228
3229 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3230 GCC 4.6.0 optimizes based on type-based alias analysis.
3231 For example, if b is of type struct buffer * and v of type struct
3232 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3233 != &v->size, and therefore "v->size = 1; b->size = 2; return
3234 v->size;" must therefore return 1. This assumption is incorrect
3235 for Emacs, since it type-puns struct Lisp_Vector * with many other
3236 types. To fix this problem, this patch adds a new type struct
3237 vectorlike_header that documents the constraints on layout of vectors
3238 and pseudovectors, and helps optimizing compilers not get fooled
3239 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3240 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3241 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3242 the size member.
3243 (XSETPVECTYPE): Rewrite in terms of new macro.
3244 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3245 This is a bit clearer, and further avoids the possibility of
3246 undesirable aliasing.
3247 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3248 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3249 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3250 since Lisp_Subr is a special case (no "next" field).
3251 (ASIZE): Now uses header.size rather than size.
3252 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3253 to avoid the hassle of writing XVECTOR (foo)->header.size.
3254 (struct vectorlike_header): New type.
3255 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3256 object, to help avoid aliasing.
3257 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3258 (SUBRP): Likewise, since Lisp_Subr is a special case.
3259 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3260 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3261 (struct Lisp_Hash_Table): Combine first two members into a single
3262 struct vectorlike_header member. All uses of "size" and "next" members
3263 changed to be "header.size" and "header.next".
3264 * buffer.h (struct buffer): Likewise.
3265 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3266 * frame.h (struct frame): Likewise.
3267 * process.h (struct Lisp_Process): Likewise.
3268 * termhooks.h (struct terminal): Likewise.
3269 * window.c (struct save_window_data, struct saved_window): Likewise.
3270 * window.h (struct window): Likewise.
3271 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3272 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3273 * buffer.c (init_buffer_once): Likewise.
3274 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3275 special case.
3276 * process.c (Fformat_network_address): Use local var for size,
3277 for brevity.
3278
3279 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3280
3281 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3282 * data.c (atof): Remove decl; no longer used or needed.
3283 (digit_to_number): Move to lread.c.
3284 (Fstring_to_number): Use new string_to_number function, to be
3285 consistent with how the Lisp reader treats infinities and NaNs.
3286 Do not assume that floating-point numbers represent EMACS_INT
3287 without losing information; this is not true on most 64-bit hosts.
3288 Avoid double-rounding errors, by insisting on integers when
3289 parsing non-base-10 numbers, as the documentation specifies.
3290 * lisp.h (string_to_number): New decl, replacing ...
3291 (isfloat_string): Remove.
3292 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3293 (read1): Do not accept +. and -. as integers; this
3294 appears to have been a coding error. Similarly, do not accept
3295 strings like +-1e0 as floating point numbers. Do not report
3296 overflow for integer overflows unless the base is not 10 which
3297 means we have no simple and reliable way to continue.
3298 Break out the floating-point parsing into a new
3299 function string_to_number, so that Fstring_to_number parses
3300 floating point numbers consistently with the Lisp reader.
3301 (digit_to_number): Move here from data.c. Make it static inline.
3302 (E_CHAR, EXP_INT): Remove, replacing with ...
3303 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3304 (string_to_number): New function, replacing isfloat_string.
3305 This function checks for valid syntax and produces the resulting
3306 Lisp float number too. Rework it so that string-to-number
3307 no longer mishandles examples like "1.0e+". Use strtoumax,
3308 so that overflow for non-base-10 numbers is reported only when
3309 there's no portable and simple way to convert to floating point.
3310
3311 * textprop.c (set_text_properties_1): Rewrite for clarity,
3312 and to avoid GCC warning about integer overflow.
3313
3314 * intervals.h (struct interval): Use EMACS_INT for members
3315 where EMACS_UINT might cause problems. See
3316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3317 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3318 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3319 All uses changed.
3320 (offset_intervals): Tell GCC not to worry about length overflow
3321 when negating a negative length.
3322
3323 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3324 (overrun_check_free): Likewise.
3325
3326 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3327 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3328 word size.
3329
3330 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3331 (gnutls_make_error): Rename local to avoid shadowing.
3332 (gnutls_emacs_global_deinit): ifdef out; not used.
3333 (Fgnutls_boot): Use const for pointer to readonly storage.
3334 Comment out unused local. Fix pointer signedness problems.
3335
3336 * lread.c (openp): Don't stuff size_t into an 'int'.
3337 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3338 about possible signed overflow.
3339
3340 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3341 (GDK_KEY_g): Don't define if already defined.
3342 (xg_prepare_tooltip): Avoid pointer signedness problem.
3343 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3344
3345 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3346 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3347
3348 * xfns.c (Fx_window_property): Simplify a bit,
3349 to make a bit faster and to avoid GCC 4.6.0 warning.
3350 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3351
3352 * fns.c (internal_equal): Don't assume size_t fits in int.
3353
3354 * alloc.c (compact_small_strings): Tighten assertion a little.
3355
3356 Replace pEd with more-general pI, and fix some printf arg casts.
3357 * lisp.h (pI): New macro, generalizing old pEd macro to other
3358 conversion specifiers. For example, use "...%"pI"d..." rather
3359 than "...%"pEd"...".
3360 (pEd): Remove. All uses replaced with similar uses of pI.
3361 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3362 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3363 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3364 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3365 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3366 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3367 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3368 64-bit hosts.
3369 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3370 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3371 * print.c (safe_debug_print, print_object): Likewise.
3372 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3373 to int.
3374 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3375 avoiding the 0 flag, which is not portable.
3376 * process.c (Fmake_network_process): Use pI to avoid cast.
3377 * region-cache.c (pp_cache): Likewise.
3378 * xdisp.c (decode_mode_spec): Likewise.
3379 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3380 behavior on 64-bit hosts with printf arg.
3381 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3382 (x_stop_queuing_selection_requests): Likewise.
3383 (x_get_window_property): Don't truncate byte count to an 'int'
3384 when tracing.
3385
3386 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3387 here, since it parses constructs like leading '-' and spaces,
3388 which are not wanted; and it overflows with large numbers.
3389 Instead, simply match F[0-9]+, which is what is wanted anyway.
3390
3391 * alloc.c: Remove unportable assumptions about struct layout.
3392 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3393 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3394 (allocate_vectorlike, make_pure_vector): Use the new macros,
3395 plus offsetof, to remove unportable assumptions about struct layout.
3396 These assumptions hold on all porting targets that I know of, but
3397 they are not guaranteed, they're easy to remove, and removing them
3398 makes further changes easier.
3399
3400 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3401 This doesn't fix a bug but makes the code clearer.
3402 (string_overrun_cookie): Now const. Use initializers that
3403 don't formally overflow signed char, to avoid warnings.
3404 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3405 can cause Emacs to crash when string overrun checking is enabled.
3406 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3407 multiple of sizeof (EMACS_INT); it need not be, if
3408 alignof(EMACS_INT) < sizeof (EMACS_INT).
3409 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3410
3411 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3414
3415 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3416
3417 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3418 supposed to be handshaking. (Bug#8556)
3419 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3420
3421 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3422
3423 * lisp.h (Qdebug): List symbol.
3424 * eval.c (Qdebug): Restore global linkage.
3425 * keyboard.c (debug-on-event): New variable.
3426 (handle_user_signal): Break into debugger when debug-on-event
3427 matches the current signal symbol.
3428
3429 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3430
3431 * alloc.c (check_sblock, check_string_bytes)
3432 (check_string_free_list): Convert to standard C.
3433
3434 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3435
3436 * w32.c (emacs_gnutls_push): Fix typo.
3437
3438 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3439
3440 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3441 "cast to pointer from integer of different size".
3442
3443 Improve doprnt and its use in verror. (Bug#8545)
3444 * doprnt.c (doprnt): Document the set of format control sequences
3445 supported by the function. Use SAFE_ALLOCA instead of always
3446 using `alloca'.
3447
3448 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3449 is one byte too soon. Don't use xrealloc; instead xfree and
3450 xmalloc anew.
3451
3452 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3453
3454 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3455 callbacks stage.
3456
3457 * gnutls.c: Renamed global_initialized to
3458 gnutls_global_initialized. Added internals for the
3459 :verify-hostname-error, :verify-error, and :verify-flags
3460 parameters of `gnutls-boot' and documented those parameters in the
3461 docstring. Start callback support.
3462 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3463 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3464 on error. Return error code.
3465 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3466 (emacs_gnutls_read): Likewise.
3467 (Fgnutls_boot): Return handshake error code.
3468 (emacs_gnutls_handle_error): New function.
3469 (wsaerror_to_errno): Likewise.
3470
3471 * w32.h (emacs_gnutls_pull): Add prototype.
3472 (emacs_gnutls_push): Likewise.
3473
3474 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3475 (emacs_gnutls_push): Likewise.
3476
3477 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3478
3479 * process.c (wait_reading_process_output): Check if GnuTLS
3480 buffered some data internally if no FDs are set for TLS
3481 connections.
3482
3483 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3484 (LIBS): Link to USER_LIBS.
3485 ($(BLD)/gnutls.$(0)): New target.
3486
3487 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3488
3489 * xdisp.c (handle_single_display_spec): Rename the
3490 display_replaced_before_p argument into display_replaced_p, to
3491 make it consistent with the commentary. Fix typos in the
3492 commentary.
3493
3494 * textprop.c (syms_of_textprop): Remove dead code.
3495 (copy_text_properties): Delete obsolete commentary about an
3496 interface that was deleted long ago. Fix typos in the description
3497 of arguments.
3498
3499 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3500 to changes in oldXMenu/XMenu.h from 2011-04-16.
3501 <menu_help_message, prev_menu_help_message>: Constify.
3502 (IT_menu_make_room): menu->help_text is now `const char **';
3503 adjust.
3504
3505 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3506 to changes in oldXMenu/XMenu.h from 2011-04-16.
3507 (struct XMenu): Declare `help_text' `const char **'.
3508
3509 * xfaces.c <Qunspecified>: Make extern again.
3510
3511 * syntax.c: Include sys/types.h before including regex.h, as
3512 required by Posix.
3513
3514 * doc.c (get_doc_string): Improve the format passed to `error'.
3515
3516 * doprnt.c (doprnt): Improve commentary.
3517
3518 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3519
3520 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3521 them with etags.
3522
3523 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3524 changes in globals.h immediately force recompilation.
3525 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3526 $(CURDIR)/s/ms-w32.h.
3527 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3528
3529 * character.c (Fchar_direction): Function deleted.
3530 (syms_of_character): Don't defsubr it.
3531 <char-direction-table>: Deleted.
3532
3533 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3534
3535 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3536 * doprnt.c: Include limits.h.
3537 (SIZE_MAX): New macro.
3538 (doprnt): Return a size_t value. 2nd arg is now size_t.
3539 Many local variables are now size_t instead of int or unsigned.
3540 Improve overflow protection. Support `l' modifier for integer
3541 conversions. Support %l conversion. Don't assume an EMACS_INT
3542 argument for integer conversions and for %c.
3543
3544 * lisp.h (doprnt): Restore prototype.
3545
3546 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3547 $(SRC)/character.h.
3548
3549 * Makefile.in (base_obj): Add back doprnt.o.
3550
3551 * deps.mk (doprnt.o): Add back prerequisites.
3552 (callint.o): Depend on character.h.
3553
3554 * eval.c (internal_lisp_condition_case): Include the handler
3555 representation in the error message.
3556 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3557 when breaking from the loop.
3558
3559 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3560
3561 * callint.c (Fcall_interactively): When displaying error message
3562 about invalid control letter, pass the character's codepoint, not
3563 a pointer to its multibyte form. Improve display of the character
3564 in octal and display also its hex code.
3565
3566 * character.c (char_string): Use %x to display the (unsigned)
3567 codepoint of an invalid character, to avoid displaying a bogus
3568 negative value.
3569
3570 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3571 `error', not SYMBOL_NAME itself.
3572
3573 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3574 character arguments to `error'.
3575
3576 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3577 to `error' in error message about FINAL_CHAR argument. Make sure
3578 FINAL_CHAR is a character, and use %c when it is passed as
3579 argument to `error'.
3580
3581 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3582
3583 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3584
3585 * w32.c: Include <time.h>.
3586 (sys_localtime): New function.
3587
3588 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3589
3590 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3591
3592 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3593
3594 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3595
3596 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3597 zombies (Bug#8467).
3598
3599 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3600
3601 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3602 gl_state.e_property when gl_state.object is Qt.
3603
3604 * insdel.c (make_gap_larger): Remove limitation of buffer size
3605 to <= INT_MAX.
3606
3607 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3608
3609 * xdisp.c (lookup_glyphless_char_display)
3610 (produce_glyphless_glyph): Handle cons cell entry in
3611 glyphless-char-display.
3612 (Vglyphless_char_display): Document it.
3613
3614 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3615 glyphless-char-display.
3616
3617 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3618
3619 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3620
3621 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3622
3623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3624 definition for no-X builds.
3625
3626 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 Static checks with GCC 4.6.0 and non-default toolkits.
3629
3630 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3631
3632 * process.c (keyboard_bit_set): Define only if SIGIO.
3633 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3634 (send_process): Repair possible setjmp clobbering.
3635
3636 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3637
3638 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3639
3640 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3641
3642 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3643 Define only if needed.
3644
3645 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3646 by pacifying GCC about it. Maybe it's time to retire it?
3647 * xfaces.c (USG, __TIMEVAL__): Likewise.
3648
3649 * dispextern.h (struct redisplay_interface): Rename param
3650 to avoid shadowing.
3651 * termhooks.h (struct terminal): Likewise.
3652 * xterm.c (xembed_send_message): Likewise.
3653
3654 * insdel.c (make_gap_smaller): Define only if
3655 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3656
3657 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3658 it.
3659
3660 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3661 so that we aren't warned about unused symbols.
3662
3663 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3664
3665 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3666
3667 * xfns.c (x_real_positions): Mark locals as initialized.
3668
3669 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3670
3671 * xterm.c: Fix problems found by static analysis with other toolkits.
3672 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3673 (x_dispatch_event): Declare static if USE_GTK, and
3674 define if USE_GTK || USE_X_TOOLKIT.
3675 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3676 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3677 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3678 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3679
3680 * xmenu.c (menu_help_callback): Pointer type fixes.
3681 Use const pointers when pointing at readonly data. Avoid pointer
3682 signedness clashes.
3683 (FALSE): Remove unused macro.
3684 (update_frame_menubar): Remove unused decl.
3685
3686 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3687
3688 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3689 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3690 (single_menu_item): Rename local to avoid shadowing.
3691
3692 * keyboard.c (make_lispy_event): Remove unused local var.
3693
3694 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3695 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3696
3697 * bitmaps: Change bitmaps from unsigned char back to the X11
3698 compatible char. Avoid the old compiler warnings about
3699 out-of-range initializers by using, for example, '\xab' rather
3700 than 0xab.
3701
3702 * xgselect.c (xgselect_initialize): Check vs interface
3703 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3704
3705 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3706
3707 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3708 to read-only memory.
3709
3710 * fns.c (vector): Remove; this old hack is no longer needed.
3711
3712 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3713 Remove unused var.
3714 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3715
3716 * xrdb.c (x_load_resources): Omit unused local.
3717
3718 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3719 (x_window): Rename locals to avoid shadowing.
3720 (USG): Use the kludged USG macro, to pacify gcc.
3721
3722 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3723 (x_term_init): Remove local to avoid shadowing.
3724
3725 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3726
3727 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3728 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3729
3730 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3731
3732 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3733
3734 Fix regex.c, syntax.c and friends for buffers > 2GB.
3735 * syntax.h (struct gl_state_s): Declare character position members
3736 EMACS_INT.
3737
3738 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3739
3740 * textprop.c (verify_interval_modification, interval_of):
3741 Declare arguments EMACS_INT.
3742
3743 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3744 EMACS_INT.
3745
3746 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3747
3748 * indent.c (Fvertical_motion): Local variable it_start is now
3749 EMACS_INT.
3750
3751 * regex.c (re_match, re_match_2, re_match_2_internal)
3752 (bcmp_translate, regcomp, regexec, print_double_string)
3753 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3754 (re_compile_pattern, re_exec): Declare arguments and local
3755 variables `size_t' and `ssize_t' and return values `regoff_t', as
3756 appropriate.
3757 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3758 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3759 <compile_stack_type>: `size' and `avail' are now `size_t'.
3760
3761 * regex.h <regoff_t>: Use ssize_t, not int.
3762 (re_search, re_search_2, re_match, re_match_2): Arguments that
3763 specify buffer/string position and length are now ssize_t and
3764 size_t. Return type is regoff_t.
3765
3766 2011-04-16 Ben Key <bkey76@gmail.com>
3767
3768 * nsfont.m: Fixed bugs in ns_get_family and
3769 ns_descriptor_to_entity that were caused by using free to
3770 deallocate memory blocks that were allocated by xmalloc (via
3771 xstrdup). This caused Emacs to crash when compiled with
3772 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3773 --enable-checking=xmallocoverrun). xfree is now used to
3774 deallocate these memory blocks.
3775
3776 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3777
3778 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3779
3780 emacs_write: Accept and return EMACS_INT for sizes.
3781 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3782 et seq.
3783 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3784 Accept and return EMACS_INT.
3785 (emacs_gnutls_write): Return the number of bytes written on
3786 partial writes.
3787 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3788 (emacs_read, emacs_write): Remove check for negative size, as the
3789 Emacs source code has been audited now.
3790 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3791 (emacs_read, emacs_write): Use it.
3792 * process.c (send_process): Adjust to the new signatures of
3793 emacs_write and emacs_gnutls_write. Do not attempt to store
3794 a byte offset into an 'int'; it might overflow.
3795 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3796
3797 * sound.c: Don't assume sizes fit in 'int'.
3798 (struct sound_device.period_size, alsa_period_size):
3799 Return EMACS_INT, not int.
3800 (struct sound_device.write, vox_write, alsa_write):
3801 Accept EMACS_INT, not int.
3802 (wav_play, au_play): Use EMACS_INT to store sizes and to
3803 record read return values.
3804
3805 2011-04-15 Ben Key <bkey76@gmail.com>
3806
3807 * keyboard.c (Qundefined): Don't declare static since it is used
3808 in nsfns.m.
3809 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3810 static since they are used in nsfont.m.
3811
3812 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3813
3814 * process.c (Qprocessp): Don't declare static.
3815 * lisp.h (Qprocessp): Declare again.
3816
3817 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3818
3819 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3820
3821 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Improve C-level modularity by making more things 'static'.
3824
3825 Don't publish debugger-only interfaces to other modules.
3826 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3827 (verify_bytepos, count_markers): Move decls to the only modules
3828 that need them.
3829 * region-cache.h (pp_cache): Likewise.
3830 * window.h (check_all_windows): Likewise.
3831 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3832
3833 * sysdep.c (croak): Now static, if
3834 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3835 * syssignal.h (croak): Declare only if not static.
3836
3837 * alloc.c (refill_memory_reserve): Now static if
3838 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3839 * lisp.h (refill_memory_reserve): Declare only if not static.
3840
3841 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3842 Define only if USE_LUCID.
3843
3844 * xrdb.c (x_customization_string, x_rm_string): Now static.
3845
3846 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3847 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3848
3849 * xdisp.c (draw_row_with_mouse_face): Now static.
3850 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3851
3852 * window.h (check_all_windows): Mark externally visible.
3853
3854 * window.c (window_deletion_count): Now static.
3855
3856 * undo.c: Make symbols static if they're not exported.
3857 (last_undo_buffer, last_boundary_position, pending_boundary):
3858 Now static.
3859
3860 * textprop.c (interval_insert_behind_hooks): Now static.
3861 (interval_insert_in_front_hooks): Likewise.
3862
3863 * term.c: Make symbols static if they're not exported.
3864 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3865 (max_frame_lines, tty_set_terminal_modes):
3866 (tty_reset_terminal_modes, tty_turn_off_highlight):
3867 (get_tty_terminal): Now static.
3868 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3869 * termhooks.h (term_mouse_moveto): Do not declare if
3870 HAVE_WINDOW_SYSTEM.
3871 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3872 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3873
3874 * sysdep.c: Make symbols static if they're not exported.
3875 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3876 Now static.
3877 (sigprocmask_set, full_mask): Remove; unused.
3878 (wait_debugging): Mark as visible.
3879 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3880 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3881
3882 * syntax.c (syntax_temp): Define only if !__GNUC__.
3883
3884 * sound.c (current_sound_device, current_sound): Now static.
3885
3886 * search.c (searchbufs, searchbuf_head): Now static.
3887
3888 * scroll.c (scroll_cost): Remove; unused.
3889 * dispextern.h (scroll_cost): Remove decl.
3890
3891 * region-cache.h (pp_cache): Mark as externally visible.
3892
3893 * process.c: Make symbols static if they're not exported.
3894 (process_tick, update_tick, create_process, chan_process):
3895 (Vprocess_alist, proc_buffered_char, datagram_access):
3896 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3897 (deactivate_process): Mark defn as static, as well as decl.
3898 * lisp.h (create_process): Remove decl.
3899 * process.h (chan_process, Vprocess_alist): Remove decls.
3900
3901 * print.c: Make symbols static if they're not exported.
3902 (print_depth, new_backquote_output, being_printed, print_buffer):
3903 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3904 (print_interval, print_number_index, initial_stderr_stream):
3905 Now static.
3906 * lisp.h (Fprinc): Remove decl.
3907 (debug_output_compilation_hack): Mark as externally visible.
3908
3909 * sysdep.c (croak): Move decl from here to syssignal.h.
3910 * syssignal.h (croak): Put it here, so the API can be checked when
3911 'croak' is called from dissociate_if_controlling_tty.
3912
3913 * minibuf.c: Make symbols static if they're not exported.
3914 (minibuf_save_list, choose_minibuf_frame): Now static.
3915 * lisp.h (choose_minibuf_frame): Remove decl.
3916
3917 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3918
3919 * lread.c: Make symbols static if they're not exported.
3920 (read_objects, initial_obarray, oblookup_last_bucket_number):
3921 Now static.
3922 (make_symbol): Remove; unused.
3923 * lisp.h (initial_obarray, make_symbol): Remove decls.
3924
3925 * keyboard.c: Make symbols static if they're not exported.
3926 (single_kboard, recent_keys_index, total_keys, recent_keys):
3927 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3928 (this_single_command_key_start, echoing, last_auto_save):
3929 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3930 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3931 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3932 (Vlispy_mouse_stem, double_click_count):
3933 Now static.
3934 (force_auto_save_soon): Define only if SIGDANGER.
3935 (ignore_mouse_drag_p): Now static if
3936 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3937 (print_help): Remove; unused.
3938 (stop_character, last_timer_event): Mark as externally visible.
3939 * keyboard.h (ignore_mouse_drag_p): Declare only if
3940 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3941 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3942 * lisp.h (echoing): Remove decl.
3943 (force_auto_save_soon): Declare only if SIGDANGER.
3944 * xdisp.c (redisplay_window): Simplify code, to make it more
3945 obvious that ignore_mouse_drag_p is not accessed if !defined
3946 USE_GTK && !defined HAVE_NS.
3947
3948 * intervals.c: Make symbols static if they're not exported.
3949 (merge_properties_sticky, merge_interval_right, delete_interval):
3950 Now static.
3951 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3952
3953 * insdel.c: Make symbols static if they're not exported.
3954 However, leave prepare_to_modify_buffer alone. It's never
3955 called from outside this function, but that appears to be a bug.
3956 (combine_after_change_list, combine_after_change_buffer):
3957 (adjust_after_replace, signal_before_change): Now static.
3958 (adjust_after_replace_noundo): Remove; unused.
3959 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3960 (signal_before_change): Remove decls.
3961
3962 * indent.c (val_compute_motion, val_vmotion): Now static.
3963
3964 * image.c: Make symbols static if they're not exported.
3965 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3966 if USE_GTK.
3967 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3968 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3969
3970 * fringe.c (standard_bitmaps): Now static.
3971 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3972
3973 * frame.c: Make symbols static if they're not exported.
3974 (x_report_frame_params, make_terminal_frame): Now static.
3975 (get_frame_param): Now static, unless HAVE_NS.
3976 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3977 (x_get_resource_string): Remove; not used.
3978 * frame.h (make_terminal_frame, x_report_frame_params):
3979 (x_get_resource_string); Remove decls.
3980 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3981 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3982
3983 * font.c, fontset.c: Make symbols static if they're not exported.
3984 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3985 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3986 * font.c (font_close_object): Now static.
3987 * font.h (font_close_object): Remove.
3988 * fontset.c (FONTSET_OBJLIST): Remove.
3989 (free_realized_fontset) #if-0 the body, which does nothing.
3990 (face_suitable_for_char_p): #if-0, as it's never called.
3991 * fontset.h (face_suitable_for_char_p): Remove decl.
3992 * xfaces.c (face_at_string_position):
3993 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3994 since 0 is always ASCII.
3995
3996 * fns.c (weak_hash_tables): Now static.
3997
3998 * fileio.c: Make symbols static if they're not exported.
3999 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4000 (Vwrite_region_annotation_buffers): Now static.
4001
4002 * eval.c: Make symbols static if they're not exported.
4003 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4004 * lisp.h (backtrace_list): Remove decl.
4005
4006 * emacs.c: Make symbols static if they're not exported.
4007 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4008 (fatal_error_code, fatal_error_signal_hook, standard_args):
4009 Now static.
4010 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4011 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4012 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4013 * lisp.h (fatal_error_signal_hook): Remove decl.
4014 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4015
4016 * editfns.c: Move a (normally-unused) function to its only use.
4017 * editfns.c, lisp.h (get_operating_system_release): Remove.
4018 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4019 worth the hassle of breaking this out.
4020
4021 * xterm.c: Make symbols static if they're not exported.
4022 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4023 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4024 (x_destroy_window, x_delete_display):
4025 Now static.
4026 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4027 (x_mouse_leave): Remove; unused.
4028 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4029 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4030 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4031 Remove decls.
4032 (x_mouse_leave): Declare only if WINDOWSNT.
4033 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4034 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4035 USE_X_TOOLKIT.
4036
4037 * ftxfont.c: Make symbols static if they're not exported.
4038 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4039 HAVE_FREETYPE.
4040 * font.h (ftxfont_driver): Likewise.
4041
4042 * xfns.c: Make symbols static if they're not exported.
4043 (x_last_font_name, x_display_info_for_name):
4044 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4045 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4046 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4047 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4048 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4049 (last_show_tip_args): Now static.
4050 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4051 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4052 (x_screen_planes): Remove; unused.
4053 * dispextern.h (x_screen_planes): Remove decl.
4054
4055 * dispnew.c: Make symbols static if they're not exported.
4056 * dispextern.h (redraw_garbaged_frames, scrolling):
4057 (increment_row_positions): Remove.
4058 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4059 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4060 Now static.
4061 (redraw_garbaged_frames): Remove; unused.
4062
4063 * xfaces.c: Make symbols static if they're not exported.
4064 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4065 Remove decls.
4066 * xterm.h (defined_color): Remove decls.
4067 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4068 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4069 (menu_face_changed_default, defined_color, free_realized_face):
4070 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4071 (ascii_face_of_lisp_face): Remove; unused.
4072
4073 * xdisp.c: Make symbols static if they're not exported.
4074 * dispextern.h (scratch_glyph_row, window_box_edges):
4075 (glyph_to_pixel_coords, set_cursor_from_row):
4076 (get_next_display_element, set_iterator_to_next):
4077 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4078 (show_mouse_face): Remove decls
4079 * frame.h (message_buf_print): Likewise.
4080 * lisp.h (pop_message, set_message, check_point_in_composition):
4081 Likewise.
4082 * xterm.h (set_vertical_scroll_bar): Likewise.
4083 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4084 (message_buf_print, scratch_glyph_row, displayed_buffer):
4085 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4086 (get_next_display_element, show_mouse_face, window_box_edges):
4087 (frame_to_window_pixel_xy, check_point_in_composition):
4088 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4089 (glyph_to_pixel_coords): Remove; unused.
4090
4091 * dired.c (file_name_completion): Now static.
4092
4093 * dbusbind.c (xd_in_read_queued_messages): Now static.
4094
4095 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4096 * data.c (circular_list_error): Remove.
4097
4098 * commands.h (last_point_position, last_point_position_buffer):
4099 (last_point_position_window): Remove decls.
4100 * keyboard.c: Make these variables static.
4101
4102 * coding.h (coding, code_convert_region, encode_coding_gap):
4103 Remove decls.
4104 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4105 (iso_code_class, detect_coding, code_convert_region): Now static.
4106 (encode_coding_gap): Remove; unused.
4107
4108 * chartab.c (chartab_chars, chartab_bits): Now static.
4109
4110 * charset.h (charset_iso_8859_1): Remove decl.
4111 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4112 Now static.
4113
4114 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4115 * ccl.c (Vccl_program_table): Now static.
4116 (check_ccl_update): Remove; unused.
4117
4118 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4119 * category.h: ... from here.
4120 * category.c (check_category_table, set_category_set): Now static.
4121
4122 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4123 * lisp.h: Remove these decls.
4124
4125 * buffer.c (buffer_count): Remove unused var.
4126
4127 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4128 so that it's not optimized away.
4129 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4130 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4131 exported only to the debugger.
4132
4133 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4134 * atimer.h (run_all_atimers): Remove; not exported.
4135
4136 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4137 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4138 was inaccessible from Lisp.
4139 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4140 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4141
4142 alloc.c: Import and export fewer symbols, and remove unused items.
4143 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4144 is defined.
4145 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4146 it's not optimized away by whole-program optimization.
4147 (message_enable_multibyte, free_misc): Remove.
4148 (catchlist, handlerlist, mark_backtrace):
4149 Declare only if BYTE_MARK_STACK.
4150 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4151 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4152 (message_enable_multibyte): Remove decl.
4153 (free_misc, interval_free_list, float_block, float_block_index):
4154 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4155 (cons_free_list, last_marked_index):
4156 Now static.
4157 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4158 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4159 (mark_backtrace): Define only if BYTE_MARK_STACK.
4160 * xdisp.c (message_enable_multibyte): Now static.
4161
4162 Declare Lisp_Object Q* variables to be 'static' if not exported.
4163 This makes it easier for human readers (and static analyzers)
4164 to see whether these variables are used from other modules.
4165 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4166 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4167 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4168 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4169 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4170 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4171 * xmenu.c, xselect.c:
4172 Declare Q* vars static if they are not used in other modules.
4173 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4174 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4175 Remove decls of unexported vars.
4176 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4177
4178 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4179
4180 Make Emacs functions such as Fatom 'static' by default.
4181 This makes it easier for human readers (and static analyzers)
4182 to see whether these functions can be called from other modules.
4183 DEFUN now defines a static function. To make the function external
4184 so that it can be used in other C modules, use the new macro DEFUE.
4185 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4186 (Finit_image_library):
4187 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4188 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4189 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4190 Remove decls, since these functions are now static.
4191 (Funintern, Fget_internal_run_time): New decls, since these functions
4192 were already external.
4193
4194 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4195 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4196 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4197 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4198 * keyboard.c, keymap.c, lread.c:
4199 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4200 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4201 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4202 Mark functions with DEFUE instead of DEFUN,
4203 if they are used in other modules.
4204 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4205 decls for now-static functions.
4206 * buffer.h (Fdelete_overlay): Remove decl.
4207 * callproc.c (Fgetenv_internal): Mark as internal.
4208 * composite.c (Fremove_list_of_text_properties): Remove decl.
4209 (Fcomposition_get_gstring): New forward static decl.
4210 * composite.h (Fcomposite_get_gstring): Remove decl.
4211 * dired.c (Ffile_attributes): New forward static decl.
4212 * doc.c (Fdocumntation_property): New forward static decl.
4213 * eval.c (Ffetch_bytecode): New forward static decl.
4214 (Funintern): Remove extern decl; now in .h file where it belongs.
4215 * fileio.c (Fmake_symbolic_link): New forward static decl.
4216 * image.c (Finit_image_library): New forward static decl.
4217 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4218 * intervals.h (Fprevious_property_change):
4219 (Fremove_list_of_text_properties): Remove decls.
4220 * keyboard.c (Fthis_command_keys): Remove decl.
4221 (Fcommand_execute): New forward static decl.
4222 * keymap.c (Flookup_key): New forward static decl.
4223 (Fcopy_keymap): Now static.
4224 * keymap.h (Flookup_key): Remove decl.
4225 * process.c (Fget_process): New forward static decl.
4226 (Fprocess_datagram_address): Mark as internal.
4227 * syntax.c (Fsyntax_table_p): New forward static decl.
4228 (skip_chars): Remove duplicate decl.
4229 * textprop.c (Fprevious_property_change): New forward static decl.
4230 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4231 Now internal.
4232 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4233 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4234
4235 * editfns.c (Fformat): Remove unreachable code.
4236
4237 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4238
4239 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4240 change. (Bug#8496)
4241
4242 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4245 when at ZV. (Bug#8487)
4246
4247 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4248
4249 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4250 (Bug#8437)
4251 * keyboard.c (parse_tool_bar_item): Likewise.
4252 * sound.c (sound_cleanup, alsa_close): Likewise.
4253 * termcap.c (tgetent): Likewise.
4254 * xfns.c (x_default_font_parameter): Likewise.
4255 * xsettings.c (read_and_apply_settings): Likewise.
4256
4257 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4258 (overrun_check_free): Protoize.
4259
4260 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4263 since callers should never pass a negative size.
4264 Change the signature to match that of plain 'read' and 'write'; see
4265 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4266 * lisp.h: Update prototypes of emacs_write and emacs_read.
4267
4268 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xdisp.c (redisplay_window): Don't try to determine the character
4271 position of the scroll margin if the window start point w->startp
4272 is outside the buffer's accessible region. (Bug#8468)
4273
4274 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4275
4276 Fix write-region and its subroutines for buffers > 2GB.
4277 * fileio.c (a_write, e_write): Modify declaration of arguments and
4278 local variables to support buffers larger than 2GB.
4279 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4280
4281 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4282 argument, local variables, and return value.
4283
4284 * lisp.h: Update prototypes of emacs_write and emacs_read.
4285
4286 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4287
4288 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4291
4292 Fix more problems found by GCC 4.6.0's static checks.
4293
4294 * xdisp.c (vmessage): Use a better test for character truncation.
4295
4296 * charset.c (load_charset_map): <, not <=, for optimization,
4297 and to avoid potential problems with integer overflow.
4298 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4299 * casetab.c (set_identity, shuffle): Likewise.
4300 * editfns.c (Fformat): Likewise.
4301 * syntax.c (skip_chars): Likewise.
4302
4303 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4304 This also lets GCC 4.6.0 generate slightly better loop code.
4305
4306 * callint.c (Fcall_interactively): <, not <=, for optimization.
4307 (Fcall_interactively): Count the number of arguments produced,
4308 not the number of arguments given. This is simpler and lets GCC
4309 4.6.0 generate slightly better code.
4310
4311 * ftfont.c: Distingish more carefully between FcChar8 and char.
4312 The previous code passed unsigned char * to a functions like
4313 strlen and xstrcasecmp that expect char *, which does not
4314 conform to the C standard.
4315 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4316 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4317 char * when the C standard requires it.
4318
4319 * keyboard.c (read_char): Remove unused var.
4320
4321 * eval.c: Port to Windows vsnprintf (Bug#8435).
4322 Include <limits.h>.
4323 (SIZE_MAX): Define if the headers do not.
4324 (verror): Do not give up if vsnprintf returns a negative count.
4325 Instead, grow the buffer. This ports to Windows vsnprintf, which
4326 does not conform to C99. Problem reported by Eli Zaretskii.
4327 Also, simplify the allocation scheme, by avoiding the need for
4328 calling realloc, and removing the ALLOCATED variable.
4329
4330 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4331
4332 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4333 But keep the doprint source code for now, as we might revamp it
4334 and use it again (Bug#8435).
4335 * lisp.h (doprnt): Remove.
4336 * Makefile.in (base_obj): Remove doprnt.o.
4337 * deps.mk (doprnt.o): Remove.
4338
4339 error: Print 32- and 64-bit integers portably (Bug#8435).
4340 Without this change, on typical 64-bit hosts error ("...%d...", N)
4341 was used to print both 32- and 64-bit integers N, which relied on
4342 undefined behavior.
4343 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4344 New macro.
4345 * lisp.h (error, verror): Mark as printf-like functions.
4346 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4347 Report overflow in size calculations when allocating printf buffer.
4348 Do not truncate output string at its first null byte.
4349 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4350 Truncate the output at a character boundary, since vsnprintf does not
4351 do that.
4352 * charset.c (check_iso_charset_parameter): Convert internal
4353 character to string before calling 'error', since %c now has the
4354 printf meaning.
4355 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4356 overflow when computing char to be passed to 'error'. Do not
4357 pass Lisp_Object to 'error'; pass the integer instead.
4358 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4359 formatted with plain %d.
4360
4361 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4362
4363 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4364
4365 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4366
4367 * xterm.c (x_catch_errors): Remove duplicate declaration.
4368
4369 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4370
4371 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4372
4373 2011-04-10 Jim Meyering <meyering@redhat.com>
4374
4375 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4376 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4377 return ssize_t not "int", and use size_t as the buffer length.
4378 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4379 * gnutls.h: Update declarations.
4380 * process.c (read_process_output): Use ssize_t, to match.
4381 (send_process): Likewise.
4382
4383 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4384
4385 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4386
4387 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4388
4389 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4390 Use unsigned char, to match FcChar8 type definition.
4391
4392 * xterm.c (handle_one_xevent):
4393 * xmenu.c (create_and_show_popup_menu):
4394 * xselect.c (x_decline_selection_request)
4395 (x_reply_selection_request): Avoid type-punned deref of X events.
4396
4397 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4398
4399 Fix some uses of `int' instead of EMACS_INT.
4400 * search.c (string_match_1, fast_string_match)
4401 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4402 (scan_buffer, find_next_newline_no_quit)
4403 (find_before_next_newline, search_command, Freplace_match)
4404 (Fmatch_data): Make some `int' variables be EMACS_INT.
4405
4406 * xdisp.c (display_count_lines): 3rd argument and return value now
4407 EMACS_INT. All callers changed.
4408 (pint2hrstr): Last argument is now EMACS_INT.
4409
4410 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4411 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4412 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4413 (decode_coding_utf_16, decode_coding_emacs_mule)
4414 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4415 (decode_coding_ccl, decode_coding_charset)
4416 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4417 (decode_coding_iso_2022, decode_coding_emacs_mule)
4418 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4419 <char_offset, last_offset>: Declare EMACS_INT.
4420 (encode_coding_utf_8, encode_coding_utf_16)
4421 (encode_coding_emacs_mule, encode_invocation_designation)
4422 (encode_designation_at_bol, encode_coding_iso_2022)
4423 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4424 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4425 Declare EMACS_INT.
4426 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4427 (encode_invocation_designation): Last argument P_NCHARS is now
4428 EMACS_INT.
4429 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4430 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4431
4432 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4433 All users changed.
4434
4435 * ccl.c (Fccl_execute_on_string): Declare some variables
4436 EMACS_INT.
4437
4438 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4439
4440 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4441
4442 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4443
4444 * process.c (Fformat_network_address): Doc fix.
4445
4446 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4447
4448 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4449
4450 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4451
4452 * keyboard.c (read_char): Call Lisp function help-form-show,
4453 instead of using internal_with_output_to_temp_buffer.
4454 (Qhelp_form_show): New var.
4455 (syms_of_keyboard): Use DEFSYM macro.
4456
4457 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4458
4459 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4460
4461 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4462
4463 * process.c (Flist_processes): Remove to Lisp.
4464 (list_processes_1): Delete.
4465
4466 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4467
4468 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4469
4470 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4471
4472 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 Fix more problems found by GCC 4.6.0's static checks.
4475
4476 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4477
4478 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4479
4480 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4481
4482 * xdisp.c (vmessage): Mark as a printf-like function.
4483
4484 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4485
4486 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4487
4488 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4489 printf-like functions.
4490 (tiff_load): Add casts to remove these marks before passing them
4491 to system-supplied API.
4492
4493 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4494
4495 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4496 This avoids several warnings with gcc -Wstrict-overflow.
4497 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4498 directly, rather than having caller test rule sign. This avoids
4499 some unnecessary tests.
4500 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4501 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4502 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4503
4504 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4505 (xfont_open): Avoid unnecessary tests.
4506
4507 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4508
4509 * composite.h, composite.c (composition_gstring_put_cache):
4510 Use EMACS_INT, not int, for length.
4511
4512 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4513 breaking out part of COMPOSITION_DECODE_RULE.
4514 (COMPOSITION_DECODE_RULE): Use it.
4515 * composite.c (get_composition_id): Remove unused local vars,
4516 by using the new macro.
4517
4518 * textprop.c (set_text_properties_1): Change while to do-while,
4519 since the condition is always true at first.
4520
4521 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4522 (interval_deletion_adjustment): Return unsigned value.
4523 All uses changed.
4524
4525 * process.c (list_processes_1, create_pty, read_process_output):
4526 (exec_sentinel): Remove vars that were set but not used.
4527 (create_pty): Remove unnecessary "volatile"s.
4528 (Fnetwork_interface_info): Avoid possibility of int overflow.
4529 (read_process_output): Do adaptive read buffering even if carryover.
4530 (read_process_output): Simplify nbytes computation if buffered.
4531
4532 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4533
4534 * syntax.c (scan_words): Remove var that was set but not used.
4535 (update_syntax_table): Use unsigned instead of int.
4536
4537 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4538 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4539 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4540
4541 * print.c (print_error_message): Avoid int overflow.
4542
4543 * font.c (font_list_entities): Redo for clarity,
4544 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4545
4546 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4547 (font_score): Avoid potential overflow in diff calculation.
4548
4549 * fns.c (substring_both): Remove var that is set but not used.
4550 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4551
4552 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4553
4554 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4555 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4556 can always succeed if overflow has undefined behavior.
4557
4558 * search.c (boyer_moore, wordify): Remove vars set but not used.
4559 (wordify): Omit three unnecessary tests.
4560
4561 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4562 All callers changed. This avoids the need for an unused var.
4563
4564 * casefiddle.c (casify_region): Remove var that is set but not used.
4565
4566 * dired.c (file_name_completion): Remove var that is set but not used.
4567
4568 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4569
4570 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4571 (Finsert_file_contents): Remove unnecessary code checking fd.
4572
4573 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4574 Check for integer overflow on size calculations.
4575
4576 * buffer.c (Fprevious_overlay_change): Remove var that is set
4577 but not used.
4578
4579 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4580 Remove vars that are set but not used.
4581 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4582 (timer_check_2): Mark vars as initialized.
4583
4584 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4585
4586 * image.c (lookup_image): Remove var that is set but not used.
4587 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4588
4589 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4590 that are set but not used.
4591
4592 * xfns.c (make_invisible_cursor): Don't return garbage
4593 if XCreateBitmapFromData fails (Bug#8410).
4594
4595 * xselect.c (x_get_local_selection, x_handle_property_notify):
4596 Remove vars that are set but not used.
4597
4598 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4599 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4600
4601 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4602 Remove var that is set but not used.
4603 (scroll_bar_windows_size): Now size_t, not int.
4604 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4605 Check for overflow.
4606
4607 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4608 (map_tty_color) [!defined MSDOS]: Likewise.
4609
4610 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4611
4612 * coding.c: Remove vars that are set but not used.
4613 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4614 All callers changed.
4615 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4616 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4617 (decode_coding_charset): Remove vars that are set but not used.
4618
4619 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4620 that is set but not used.
4621
4622 * print.c (print_object): Remove var that is set but not used.
4623
4624 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4625 The gnulib version avoids calling malloc in the usual case,
4626 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4627 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4628 * filelock.c (current_lock_owner): Likewise.
4629 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4630 * sysdep.c: Include allocator.h, careadlinkat.h.
4631 (emacs_no_realloc_allocator): New static constant.
4632 (emacs_readlink): New function.
4633 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4634 ../lib/careadlinkat.h.
4635
4636 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4637
4638 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4639 first non-nil return value).
4640
4641 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4642
4643 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4644 if not defined (Bug#8403).
4645
4646 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * xdisp.c (display_count_lines): Remove parameter `start',
4649 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4650 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4651 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4652 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4653 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4654 and thereabouts. All callers changed.
4655 (get_per_char_metric): Remove parameter `f', unused since
4656 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4657
4658 2011-04-02 Jim Meyering <meyering@redhat.com>
4659
4660 do not dereference NULL upon failed strdup
4661 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4662 (ns_get_family): Likewise.
4663
4664 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4667
4668 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4669
4670 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4671 later (Bug#8403).
4672
4673 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4674
4675 Add lexical binding.
4676
4677 * window.c (Ftemp_output_buffer_show): New fun.
4678 (Fsave_window_excursion):
4679 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4680
4681 * lread.c (lisp_file_lexically_bound_p): New function.
4682 (Fload): Bind Qlexical_binding.
4683 (readevalloop): Remove `evalfun' arg.
4684 Bind Qinternal_interpreter_environment.
4685 (Feval_buffer): Bind Qlexical_binding.
4686 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4687 Mark as dynamic.
4688 (syms_of_lread): Declare `lexical-binding'.
4689
4690 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4691
4692 * keyboard.c (eval_dyn): New fun.
4693 (menu_item_eval_property): Use it.
4694
4695 * image.c (parse_image_spec): Use Ffunctionp.
4696
4697 * fns.c (concat, mapcar1): Accept byte-code-functions.
4698
4699 * eval.c (Fsetq): Handle lexical vars.
4700 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4701 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4702 (FletX, Flet): Obey lexical binding.
4703 (Fcommandp): Handle closures.
4704 (Feval): New `lexical' arg.
4705 (eval_sub): New function extracted from Feval. Use it almost
4706 everywhere where Feval was used. Look up vars in lexical env.
4707 Handle closures.
4708 (Ffunctionp): Move from subr.el.
4709 (Ffuncall): Handle closures.
4710 (apply_lambda): Remove `eval_flags'.
4711 (funcall_lambda): Handle closures and new byte-code-functions.
4712 (Fspecial_variable_p): New function.
4713 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4714 but without exporting it to Lisp.
4715
4716 * doc.c (Fdocumentation, store_function_docstring):
4717 * data.c (Finteractive_form): Handle closures.
4718
4719 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4720 interactive spec.
4721
4722 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4723 New byte-codes.
4724 (exec_byte_code): New function extracted from Fbyte_code to handle new
4725 calling convention for byte-code-functions. Add new byte-codes.
4726
4727 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4728
4729 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4730
4731 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4732
4733 * xdisp.c (redisplay_internal): Fix prototype.
4734
4735 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4736
4737 * xdisp.c (SCROLL_LIMIT): New macro.
4738 (try_scrolling): Use it when setting scroll_limit.
4739 Limit scrolling to 100 screen lines.
4740 (redisplay_window): Even when falling back on "recentering",
4741 position point in the window according to scroll-conservatively,
4742 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4743
4744 (try_scrolling): When point is above the window, allow searching
4745 as far as scroll_max, or one screenful, to compute vertical
4746 distance from PT to the scroll margin position. This prevents
4747 try_scrolling from unnecessarily failing when
4748 scroll-conservatively is set to a value slightly larger than the
4749 window height. Clean up the case of PT below the margin at bottom
4750 of window: scroll_max can no longer be INT_MAX. When aggressive
4751 scrolling is in use, don't let point enter the opposite scroll
4752 margin as result of the scroll.
4753 (syms_of_xdisp) <scroll-conservatively>: Document the
4754 threshold of 100 lines for never-recentering scrolling.
4755
4756 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4757
4758 * dispextern.h (move_it_by_lines):
4759 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4760 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4761 (message_log_check_duplicate): Remove parameters `prev_bol' and
4762 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4763 (redisplay_internal): Remove parameter `preserve_echo_area',
4764 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4765
4766 * indent.c (Fvertical_motion):
4767 * window.c (window_scroll_pixel_based, Frecenter):
4768 Don't pass `need_y_p' to `move_it_by_lines'.
4769
4770 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4771
4772 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4773 steal a few bits to be more compact.
4774 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4775 Remove unneeded casts.
4776
4777 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4778
4779 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4780
4781 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4782 binding" message (bug#7967).
4783
4784 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4785
4786 Fix more problems found by GCC 4.6.0's static checks.
4787
4788 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4789 Remove unused local var.
4790
4791 * editfns.c (Fmessage_box): Remove unused local var.
4792
4793 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4794 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4795 Omit unused local vars.
4796 * window.c (shrink_windows): Omit unused local var.
4797 * menu.c (digest_single_submenu): Omit unused local var.
4798 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4799 Omit unused local var.
4800
4801 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4802 Don't assume string length fits in int.
4803 (keyremap_step, read_key_sequence): Use size_t for sizes.
4804 (read_key_sequence): Don't check last_real_key_start redundantly.
4805
4806 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4807 instead of alloca (Bug#8344).
4808
4809 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4810 (Fbacktrace_frame): Don't assume nframes fits in int.
4811
4812 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4813
4814 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4815 concerns.
4816
4817 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4818
4819 * cm.c (calccost): Turn while-do into do-while, for clarity.
4820
4821 * keyboard.c (syms_of_keyboard): Use the same style as later
4822 in this function when indexing through an array. This also
4823 works around GCC bug 48267.
4824
4825 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4826
4827 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4828
4829 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4830 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4831
4832 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4833 This avoids undefined behavior on integer overflow, and is a bit
4834 more convenient anyway since it is compared to a size_t variable.
4835
4836 Variadic C functions now count arguments with size_t, not int.
4837 This avoids an unnecessary limitation on 64-bit machines, which
4838 caused (substring ...) to crash on large vectors (Bug#8344).
4839 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4840 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4841 All variadic functions and their callers changed accordingly.
4842 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4843 * data.c (arith_driver, float_arith_driver): Likewise.
4844 * editfns.c (general_insert_function): Likewise.
4845 * eval.c (struct backtrace.nargs, interactive_p)
4846 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4847 (funcall_lambda, mark_backtrace): Likewise.
4848 * fns.c (concat): Likewise.
4849 * frame.c (x_set_frame_parameters): Likewise.
4850 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4851 0 if not found, not -1. All callers changed.
4852
4853 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4854 (stack_copy_size): Now size_t, not int.
4855 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4856
4857 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4858
4859 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4860 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4861 All callers changed.
4862
4863 * lisp.h (multibyte_char_to_unibyte):
4864 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4865 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4866 * character.h (CHAR_TO_BYTE8):
4867 * cmds.c (internal_self_insert):
4868 * editfns.c (general_insert_function):
4869 * keymap.c (push_key_description):
4870 * search.c (Freplace_match):
4871 * xdisp.c (message_dolog, set_message_1): All callers changed.
4872
4873 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4874
4875 * keyboard.c (safe_run_hook_funcall): New function.
4876 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4877 don't set the hook to nil, but remove the offending function instead.
4878 (Qcommand_hook_internal): Remove, unused.
4879 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4880 Vcommand_hook_internal.
4881
4882 * eval.c (enum run_hooks_condition): Remove.
4883 (funcall_nil, funcall_not): New functions.
4884 (run_hook_with_args): Call each function through a `funcall' argument.
4885 Remove `cond' argument, now redundant.
4886 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4887 (Frun_hook_with_args_until_failure): Adjust accordingly.
4888 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4889
4890 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * dispextern.h (string_buffer_position): Remove declaration.
4893
4894 * print.c (strout): Remove parameter `multibyte', unused since
4895 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4896
4897 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4898 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4899 All callers changed.
4900
4901 * w32.c (_wsa_errlist): Use braces for struct initializers.
4902
4903 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4904 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4905 All callers changed.
4906 (string_buffer_position): Likewise. Also, make static (it's never
4907 used outside xdisp.c).
4908 (cursor_row_p): Remove parameter `w', unused since
4909 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4910 (decode_mode_spec): Remove parameter `precision', introduced during
4911 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4912 All callers changed.
4913
4914 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4915
4916 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4917
4918 2011-03-27 Anders Lindgren <andlind@gmail.com>
4919
4920 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4921 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4922 (ns_update_auto_hide_menu_bar): New functions.
4923 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4924 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4925 ns_constrain_all_frames.
4926 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4927 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4928
4929 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4930
4931 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4932
4933 2011-03-27 Glenn Morris <rgm@gnu.org>
4934
4935 * syssignal.h: Replace RETSIGTYPE with void.
4936 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4937 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4938 Replace SIGTYPE with void everywhere.
4939 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4940 * s/template.h (SIGTYPE): Remove commented out definition.
4941
4942 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4943
4944 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4945 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4946
4947 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4948
4949 * w32.c (read_unc_volume): Use parameter `henum', instead of
4950 global variable `wget_enum_handle'.
4951
4952 * keymap.c (describe_vector): Remove parameters `indices' and
4953 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4954 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4955
4956 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4957
4958 * keyboard.c (timer_check): Remove parameter `do_it_now',
4959 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4960 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4961 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4962
4963 * keyboard.c (read_char):
4964 * w32menu.c (w32_menu_display_help):
4965 * xmenu.c (show_help_event, menu_help_callback):
4966 Adjust calls to `show_help_echo'.
4967
4968 * gtkutil.c (xg_maybe_add_timer):
4969 * keyboard.c (readable_events):
4970 * process.c (wait_reading_process_output):
4971 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4972
4973 * insdel.c (adjust_markers_gap_motion):
4974 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4975 (gap_left, gap_right): Don't call it.
4976
4977 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4978
4979 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4980 incurred during fontification.
4981
4982 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4983
4984 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4985 (DEFVAR_PER_BUFFER): Don't pass it.
4986
4987 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4988 (scrolling_window): Don't pass it.
4989
4990 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4991
4992 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4993
4994 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4995 and `suffix'.
4996 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4997 of variables specific to SELinux and computation of `encoded_absname'.
4998
4999 * image.c (XPutPixel): Remove unused variable `height'.
5000
5001 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5002
5003 * unexw32.c (get_section_info): Remove unused variable `section'.
5004
5005 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5006 (system_process_attributes): Remove unused variable `sess'.
5007 (sys_read): Remove unused variable `err'.
5008
5009 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5010 (w32_wnd_proc): Remove unused variable `isdead'.
5011 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5012 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5013 (x_create_tip_frame): Remove unused variable `tem'.
5014
5015 * w32inevt.c (w32_console_read_socket):
5016 Remove unused variable `no_events'.
5017
5018 * w32term.c (x_draw_composite_glyph_string_foreground):
5019 Remove unused variable `width'.
5020
5021 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * w32term.c (x_set_glyph_string_clipping):
5024 Don't pass uninitialized region to CombineRgn.
5025
5026 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5029 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5030 (Fx_close_connection): Remove unused variable `i'.
5031
5032 * w32font.c (w32font_draw): Return number of glyphs.
5033 (w32font_open_internal): Remove unused variable `i'.
5034 (w32font_driver): Add missing initializer.
5035
5036 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5037 (fill_in_menu): Remove unused variable `items_added'.
5038
5039 * w32term.c (last_mouse_press_frame): Remove static global variable.
5040 (w32_clip_to_row): Remove unused variable `f'.
5041 (x_delete_terminal): Remove unused variable `i'.
5042
5043 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5044 (NOTHING): Remove unused static global variable.
5045 (uniscribe_check_otf): Remove unused variable `table'.
5046 (uniscribe_font_driver): Add missing initializers.
5047
5048 2011-03-23 Julien Danjou <julien@danjou.info>
5049
5050 * term.c (Fsuspend_tty, Fresume_tty):
5051 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5052 * window.c (temp_output_buffer_show):
5053 * insdel.c (signal_before_change):
5054 * frame.c (Fhandle_switch_frame):
5055 * fileio.c (Fdo_auto_save):
5056 * emacs.c (Fkill_emacs):
5057 * editfns.c (save_excursion_restore):
5058 * cmds.c (internal_self_insert):
5059 * callint.c (Fcall_interactively):
5060 * buffer.c (Fkill_all_local_variables):
5061 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5062 Use Frun_hooks.
5063 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5064 unconditionnaly since it does the check itself.
5065
5066 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 Fix more problems found by GCC 4.5.2's static checks.
5069
5070 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5071 the first time through the loop, since we know p0 < p1 then.
5072 This also avoids a gcc -Wstrict-overflow warning.
5073
5074 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5075 leading to a memory leak, possible in functions like
5076 load_charset_map_from_file that can allocate an unbounded number
5077 of objects (Bug#8318).
5078
5079 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5080 that could (at least in theory) be that large.
5081
5082 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5083 This is less likely to overflow, and avoids undefined behavior if
5084 overflow does occur. All callers changed. Use strtoul to scan
5085 for the unsigned long integer.
5086 (pint2hrstr): Simplify and tune code slightly.
5087 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5088
5089 * scroll.c (do_scrolling): Work around GCC bug 48228.
5090 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5091
5092 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5093 This also avoids a warning with gcc -Wstrict-overflow.
5094 (validate_x_resource_name): Simplify count usage.
5095 This also avoids a warning with gcc -Wstrict-overflow.
5096
5097 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5098 fail (Bug#8306).
5099
5100 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5101
5102 * process.c (Fmake_network_process): Use socklen_t, not int,
5103 where POSIX says socklen_t is required in portable programs.
5104 This fixes a porting bug on hosts like 64-bit HP-UX, where
5105 socklen_t is wider than int (Bug#8277).
5106 (Fmake_network_process, server_accept_connection):
5107 (wait_reading_process_output, read_process_output):
5108 Likewise.
5109
5110 * process.c: Rename or move locals to avoid shadowing.
5111 (list_processes_1, Fmake_network_process):
5112 (read_process_output_error_handler, exec_sentinel_error_handler):
5113 Rename or move locals.
5114 (Fmake_network_process): Define label "retry_connect" only if needed.
5115 (Fnetwork_interface_info): Fix pointer signedness.
5116 (process_send_signal): Add cast to avoid pointer signedness problem.
5117 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5118 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5119
5120 Make tparam.h and terminfo.c consistent.
5121 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5122 Include tparam.h instead, since it declares them.
5123 * cm.h (PC): Remove extern decl; tparam.h now does this.
5124 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5125 * terminfo.c: Include tparam.h, to check interfaces.
5126 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5127 (tparam): Adjust signature to match interface in tparam.h;
5128 this removes some undefined behavior. Check that outstring and len
5129 are zero, which they always are with Emacs.
5130 * tparam.h (PC, BC, UP): New extern decls.
5131
5132 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5133 (xftfont_open): Rename locals to avoid shadowing.
5134
5135 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5136 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5137 (OTF_TAG_SYM): Omit macro if not needed.
5138 (ftfont_list): Remove unused local.
5139 (get_adstyle_property, ftfont_pattern_entity):
5140 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5141 Rename locals to avoid shadowing.
5142
5143 * xfont.c (xfont_list_family): Mark var as initialized.
5144
5145 * xml.c (make_dom): Now static.
5146
5147 * composite.c (composition_compute_stop_pos): Rename local to
5148 avoid shadowing.
5149 (composition_reseat_it): Remove unused locals.
5150 (find_automatic_composition, composition_adjust_point): Likewise.
5151 (composition_update_it): Mark var as initialized.
5152 (find_automatic_composition): Mark vars as initialized,
5153 with a FIXME (Bug#8290).
5154
5155 character.h: Rename locals to avoid shadowing.
5156 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5157 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5158 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5159 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5160 to avoid shadowing.
5161
5162 * textprop.c (property_change_between_p): Remove; unused.
5163
5164 * intervals.c (interval_start_pos): Now static.
5165
5166 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5167
5168 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5169 Rename locals to avoid shadowing.
5170
5171 * sound.c (wav_play, au_play, Fplay_sound_internal):
5172 Fix pointer signedness.
5173 (alsa_choose_format): Remove unused local var.
5174 (wav_play): Initialize a variable to 0, to prevent undefined
5175 behavior (Bug#8278).
5176
5177 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5178
5179 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5180
5181 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5182 clobbering (Bug#8298).
5183 * sysdep.c (sys_subshell): Likewise.
5184 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5185
5186 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5187 This should get cleaned up, so that child_setup has the
5188 same signature on all platforms.
5189
5190 * callproc.c (call_process_cleanup): Now static.
5191 (relocate_fd): Rename locals to avoid shadowing.
5192
5193 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5194
5195 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5196 not to be necessary, and produces flickering.
5197
5198 2011-03-20 Glenn Morris <rgm@gnu.org>
5199
5200 * config.in: Remove file.
5201
5202 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5205 are now in src/globals.h.
5206 (syms_of_minibuf): Remove spurious & from previous change.
5207
5208 2011-03-20 Leo <sdl.web@gmail.com>
5209
5210 * minibuf.c (completing-read-function): New variable.
5211 (completing-read-default): Rename from completing-read.
5212 (completing-read): Call completing-read-function.
5213
5214 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * xfaces.c (Fx_load_color_file):
5217 Read color file from absolute filename (bug#8250).
5218
5219 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * makefile.w32-in: Update dependencies.
5222
5223 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5224
5225 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5226
5227 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5228
5229 Fix more problems found by GCC 4.5.2's static checks.
5230
5231 * process.c (make_serial_process_unwind, send_process_trap):
5232 (sigchld_handler): Now static.
5233
5234 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5235 That way, the code declares only the vars that it needs.
5236 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5237 * s/cygwin.h (PTY_ITERATION): Likewise.
5238 * s/darwin.h (PTY_ITERATION): Likewise.
5239 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5240
5241 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5242 * process.c (allocate_pty): Don't declare stb unless it's needed.
5243
5244 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5245 (CONSTANTLIM): Remove; unused.
5246 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5247 Define only if needed.
5248
5249 * unexelf.c (unexec): Name an expression,
5250 to avoid gcc -Wbad-function-cast warning.
5251 Use a different way to cause a compilation error if anyone uses
5252 n rather than nn, a way that does not involve shadowing.
5253 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5254
5255 * deps.mk (unexalpha.o): Remove; unused.
5256
5257 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5258 * unexec.h: New file.
5259 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5260 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5261 Depend on unexec.h.
5262 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5263 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5264 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5265 Change as necessary to match prototype in unexec.h.
5266
5267 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5268 shadowing.
5269 (back_comment, skip_chars): Mark vars as initialized.
5270
5271 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5272 Rename locals to avoid shadowing.
5273
5274 * lread.c (read1): Rewrite so as not to use empty "else".
5275 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5276
5277 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5278
5279 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5280 warning when compiling print.c.
5281
5282 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5283 instead of using an uninitialized var.
5284 (font_sort_entities): Mark var as initialized.
5285
5286 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5287
5288 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5289 pointers to constants.
5290 (font_parse_fcname): Remove unused vars.
5291 (font_delete_unmatched): Now static.
5292 (font_get_spec): Remove; unused.
5293 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5294 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5295 Rename or move locals to avoid shadowing.
5296
5297 * fns.c (require_nesting_list, require_unwind): Now static.
5298 (Ffillarray): Rename locals to avoid shadowing.
5299
5300 * floatfns.c (domain_error2): Define only if needed.
5301 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5302
5303 * alloc.c (mark_backtrace): Move decl from here ...
5304 * lisp.h: ... to here, so that it can be checked.
5305
5306 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5307 (Fdefvar): Rewrite so as not to use empty "else".
5308 (lisp_indirect_variable): Name an expression,
5309 to avoid gcc -Wbad-function-cast warning.
5310 (Fdefvar): Rename locals to avoid shadowing.
5311
5312 * callint.c (quotify_arg, quotify_args): Now static.
5313 (Fcall_interactively): Rename locals to avoid shadowing.
5314 Use const pointer when appropriate.
5315
5316 * lisp.h (get_system_name, get_operating_system_release):
5317 Move decls here, to check interfaces.
5318 * process.c (get_operating_system_release): Move decl to lisp.h.
5319 * xrdb.c (get_system_name): Likewise.
5320 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5321 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5322 some of which prompt warnings from gcc -Wbad-function-cast.
5323 (Fformat_time_string, Fencode_time, Finsert_char):
5324 (Ftranslate_region_internal, Fformat):
5325 Rename or remove local vars to avoid shadowing.
5326 (Ftranslate_region_internal): Mark var as initialized.
5327
5328 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5329 avoid shadowing.
5330
5331 * lisp.h (eassert): Check that the argument compiles, even if
5332 ENABLE_CHECKING is not defined.
5333
5334 * data.c (Findirect_variable): Name an expression, to avoid
5335 gcc -Wbad-function-cast warning.
5336 (default_value, arithcompare, arith_driver, arith_error): Now static.
5337 (store_symval_forwarding): Rename local to avoid shadowing.
5338 (Fmake_variable_buffer_local, Fmake_local_variable):
5339 Mark variables as initialized.
5340 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5341
5342 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5343 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5344 Rename locals to avoid shadowing.
5345 (mark_stack): Move local variables into the #ifdef region where
5346 they're used.
5347 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5348 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5349 needed otherwise.
5350 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5351 (GC_STRING_CHARS): Remove; not used.
5352 (Fmemory_limit): Cast sbrk's returned value to char *.
5353
5354 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5355 avoids undefined behavior in theory.
5356
5357 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5358
5359 Use functions, not macros, for up- and down-casing (Bug#8254).
5360 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5361 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5362 to use the following functions instead of these macros.
5363 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5364 EMACS_INT, since callers assume the returned value fits in int.
5365 (upcase1): Likewise, for UPCASE_TABLE.
5366 (uppercasep, lowercasep, upcase): New static inline functions.
5367 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5368 the race-condition problem in the old DOWNCASE.
5369
5370 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5371 Rename locals to avoid shadowing.
5372 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5373 (regex_compile, re_search_2, re_match_2_internal):
5374 Remove unused local vars.
5375 (FREE_VAR): Rewrite so as not to use empty "else",
5376 which gcc can warn about.
5377 (regex_compile, re_match_2_internal): Mark locals as initialized.
5378 (RETALLOC_IF): Define only if needed.
5379 (WORDCHAR_P): Likewise. This one is never needed, but is used
5380 only in a comment talking about a compiler bug, so put inside
5381 the #if 0 of that comment.
5382 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5383 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5384 Remove; unused.
5385
5386 * search.c (boyer_moore): Rename locals to avoid shadowing.
5387 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5388 (PREV_CHAR_BOUNDARY): Likewise.
5389
5390 * search.c (simple_search): Remove unused var.
5391
5392 * dired.c (compile_pattern): Move decl from here ...
5393 * lisp.h: ... to here, so that it can be checked.
5394 (struct re_registers): New forward decl.
5395
5396 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5397
5398 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5399 All uses changed.
5400 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5401 Rename locals to avoid shadowing.
5402 (Fvertical_motion): Mark locals as initialized.
5403
5404 * casefiddle.c (casify_object, casify_region): Now static.
5405 (casify_region): Mark local as initialized.
5406
5407 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5408
5409 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5410 New macros, so that the caller can use some names other than
5411 gcpro1, gcpro2, etc.
5412 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5413 of the new macros.
5414 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5415 argument, for consistency with GCPRO2_VAR, etc: it is now the
5416 prefix of the variable, not the variable itself. All uses
5417 changed.
5418 * dired.c (directory_files_internal, file_name_completion):
5419 Rename locals to avoid shadowing.
5420
5421 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5422 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5423 dired.c's scmp function, had undefined behavior.
5424 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5425 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5426 * buffer.h: ... to here, because these macros use current_buffer,
5427 and the new implementation with inline functions needs to have
5428 current_buffer in scope now, rather than later when the macros
5429 are used.
5430 (downcase, upcase1): New static inline functions.
5431 (DOWNCASE, UPCASE1): Reimplement using these functions.
5432 This avoids undefined behavior in expressions like
5433 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5434 from race conditions in accessing the global variables
5435 case_temp1 and case_temp2.
5436 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5437 * lisp.h (case_temp1, case_temp2): Remove their decls.
5438 * character.h (ASCII_CHAR_P): Move from here ...
5439 * lisp.h: ... to here, so that the inline functions mentioned
5440 above can use them.
5441
5442 * dired.c (directory_files_internal_unwind): Now static.
5443
5444 * fileio.c (file_name_as_directory, directory_file_name):
5445 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5446 Now static.
5447 (file_name_as_directory): Use const pointers when appropriate.
5448 (Fexpand_file_name): Likewise. In particular, newdir might
5449 point at constant storage, so make it a const pointer.
5450 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5451 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5452 signedness issues.
5453 (Fset_file_times, Finsert_file_contents, auto_save_error):
5454 Rename locals to avoid shadowing.
5455
5456 * minibuf.c (choose_minibuf_frame_1): Now static.
5457 (Ftry_completion, Fall_completions): Rename or remove locals
5458 to avoid shadowing.
5459
5460 * marker.c (bytepos_to_charpos): Remove; unused.
5461
5462 * lisp.h (verify_bytepos, count_markers): New decls,
5463 so that gcc does not warn that these functions aren't declared.
5464
5465 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5466 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5467 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5468 (copy_text): Remove unused local var.
5469
5470 * filelock.c (within_one_second): Now static.
5471 (lock_file_1): Rename local to avoid shadowing.
5472
5473 * buffer.c (fix_overlays_before): Mark locals as initialized.
5474 (fix_start_end_in_overlays): Likewise. This function should be
5475 simplified by using pointers-to-pointers, but that's a different
5476 matter.
5477 (switch_to_buffer_1): Now static.
5478 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5479 (report_overlay_modification): Rename locals to avoid shadowing.
5480
5481 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5482 Fix pointer signedness issue.
5483 (sys_subshell): Mark local as volatile if checking for lint,
5484 to suppress a gcc -Wclobbered warning that does not seem to be right.
5485 (MAXPATHLEN): Define only if needed.
5486
5487 * process.c (serial_open, serial_configure): Move decls from here ...
5488 * systty.h: ... to here, so that they can be checked.
5489
5490 * fns.c (get_random, seed_random): Move extern decls from here ...
5491 * lisp.h: ... to here, so that they can be checked.
5492
5493 * sysdep.c (reset_io): Now static.
5494 (wait_for_termination_signal): Remove; unused.
5495
5496 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5497 (copy_keymap_item, append_key, push_text_char_description):
5498 Now static.
5499 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5500 (DENSE_TABLE_SIZE): Remove; unused.
5501 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5502 (describe_map_tree):
5503 Rename locals to avoid shadowing.
5504
5505 * keyboard.c: Declare functions static if they are not used elsewhere.
5506 (echo_char, echo_dash, cmd_error, top_level_2):
5507 (poll_for_input, handle_async_input): Now static.
5508 (read_char, kbd_buffer_get_event, make_lispy_position):
5509 (make_lispy_event, make_lispy_movement, apply_modifiers):
5510 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5511 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5512 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5513 (read_key_sequence, read_char): Mark locals as initialized.
5514 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5515
5516 * keyboard.h (make_ctrl_char): New decl.
5517 (mark_kboards): Move decl here ...
5518 * alloc.c (mark_kboards): ... from here.
5519
5520 * lisp.h (force_auto_save_soon): New decl.
5521
5522 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5523 (DEFINE_DUMMY_FUNCTION): New macro.
5524 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5525 Use it.
5526 (main): Add casts to avoid warnings
5527 if GCC considers string literals to be constants.
5528
5529 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5530
5531 * dbusbind.c: Pointer signedness fixes.
5532 (xd_signature, xd_append_arg, xd_initialize):
5533 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5534 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5535 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5536 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5537
5538 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5539 if GCC considers string literals to be constants.
5540 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5541
5542 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5543
5544 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5545 (print_preprocess, print_object): New macro to fix last change.
5546
5547 * print.c (print_preprocess): Don't forget font objects.
5548
5549 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5550
5551 * emacs.c (USAGE3): Doc fixes.
5552
5553 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5554
5555 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5556 structure.
5557
5558 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5559
5560 * lisp.h (VWindow_system, Qfile_name_history):
5561 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5562 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5563 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5564
5565 * w32select.c: Don't #include "keyboard.h".
5566 (run_protected): Add extern declaration for waiting_for_input.
5567
5568 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5569 * w32console.c (detect_input_pending, read_input_pending)
5570 (encode_terminal_code):
5571 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5572 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5573 (w32_system_caret_y, Qfile_name_history):
5574 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5575 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5576 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5577 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5578 * w32proc.c (Qlocal, report_file_error):
5579 * w32term.c (Vwindow_system, updating_frame):
5580 * w32uniscribe.c (initialized, uniscribe_font_driver):
5581 Remove unneeded extern declarations.
5582
5583 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5584
5585 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5586
5587 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5588
5589 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5590 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5591 These macros can no longer be used for assignment.
5592
5593 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5594 Assign struct members directly, instead of using BUF_BEGV etc.
5595 (record_buffer_markers, fetch_buffer_markers): New functions for
5596 recording and fetching special buffer markers.
5597 (set_buffer_internal_1, set_buffer_temp): Use them.
5598
5599 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5600
5601 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5602
5603 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5604 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5605
5606 * xdisp.c (hscroll_window_tree):
5607 (reconsider_clip_changes): Use PT instead of BUF_PT.
5608
5609 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5610
5611 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5612 $(EMACS_ROOT)/lib/intprops.h.
5613
5614 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5615
5616 Fix more problems found by GCC 4.5.2's static checks.
5617
5618 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5619 to unsigned char * to avoid compiler diagnostic.
5620 (xg_free_frame_widgets): Make it clear that a local variable is
5621 needed only if USE_GTK_TOOLTIP.
5622 (gdk_window_get_screen): Make it clear that this macro is needed
5623 only if USE_GTK_TOOLTIP.
5624 (int_gtk_range_get_value): New function, which avoids a diagnostic
5625 from gcc -Wbad-function-cast.
5626 (xg_set_toolkit_scroll_bar_thumb): Use it.
5627 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5628 diagnostic from gcc -Wbad-function-cast.
5629 (get_utf8_string, xg_get_file_with_chooser):
5630 Rename locals to avoid shadowing.
5631 (create_dialog): Move locals to avoid shadowing.
5632
5633 * xgselect.c (xg_select): Remove unused var.
5634
5635 * image.c (four_corners_best): Mark locals as initialized.
5636 (gif_load): Initialize transparent_p to zero (Bug#8238).
5637 Mark another local as initialized.
5638 (my_png_error, my_error_exit): Mark with NO_RETURN.
5639
5640 * image.c (clear_image_cache): Now static.
5641 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5642 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5643 (x_edge_detection): Remove unnecessary cast that
5644 gcc -Wbad-function-cast diagnoses.
5645 (gif_load): Fix pointer signedness.
5646 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5647 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5648
5649 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5650
5651 Improve quality of tests for time stamp overflow.
5652 For example, without this patch (encode-time 0 0 0 1 1
5653 1152921504606846976) returns the obviously-bogus value (-948597
5654 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5655 reports time overflow. See
5656 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5657 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5658 * editfns.c: Include limits.h and intprops.h.
5659 (TIME_T_MIN, TIME_T_MAX): New macros.
5660 (time_overflow): Move earlier, to before first use.
5661 (hi_time, lo_time): New functions, for an accurate test for
5662 out-of-range times.
5663 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5664 (Fget_internal_run_time): Don't assume time_t fits in int.
5665 (make_time): Use list2 instead of Fcons twice.
5666 (Fdecode_time): More accurate test for out-of-range times.
5667 (check_tm_member): New function.
5668 (Fencode_time): Use it, to test for out-of-range times.
5669 (lisp_time_argument): Don't rely on undefined left-shift and
5670 right-shift behavior when checking for time stamp overflow.
5671
5672 * editfns.c (time_overflow): New function, refactoring common code.
5673 (Fformat_time_string, Fdecode_time, Fencode_time):
5674 (Fcurrent_time_string): Use it.
5675
5676 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5677 * dired.c (make_time): Move to ...
5678 * editfns.c (make_time): ... here.
5679 * systime.h: Note the move.
5680
5681 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5682
5683 * fringe.c (update_window_fringes): Remove unused variables.
5684
5685 * unexmacosx.c (copy_data_segment): Also copy __got section.
5686 (Bug#8223)
5687
5688 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5689
5690 * termcap.c [MSDOS]: Include "msdos.h".
5691 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5692 Constify `char *' arguments and their references according to
5693 prototypes in tparam.h.
5694
5695 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5696
5697 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5698 Adapt all references accordingly.
5699
5700 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5701
5702 2011-03-11 Tom Tromey <tromey@redhat.com>
5703
5704 * buffer.c (syms_of_buffer): Remove obsolete comment.
5705
5706 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5707
5708 * termhooks.h (encode_terminal_code): Declare prototype.
5709
5710 * msdos.c (encode_terminal_code): Don't declare prototype.
5711
5712 * term.c (encode_terminal_code): Now external again, used by
5713 w32console.c and msdos.c.
5714
5715 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5716 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5717
5718 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 Fix some minor problems found by GCC 4.5.2's static checks.
5721
5722 * fringe.c (update_window_fringes): Mark locals as initialized
5723 (Bug#8227).
5724 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5725
5726 * alloc.c (mark_fringe_data): Move decl from here ...
5727 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5728 to check its interface.
5729 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5730
5731 * fontset.c (free_realized_fontset): Now static.
5732 (Fset_fontset_font): Rename local to avoid shadowing.
5733 (fontset_font): Mark local as initialized.
5734 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5735
5736 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5737
5738 * xselect.c (x_disown_buffer_selections): Remove; not used.
5739 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5740 (x_own_selection, Fx_disown_selection_internal): Rename locals
5741 to avoid shadowing.
5742 (x_handle_dnd_message): Remove local to avoid shadowing.
5743
5744 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5745 so that the caller can use some name other than gcpro1.
5746 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5747 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5748 (Fx_backspace_delete_keys_p):
5749 Use them to avoid shadowing, and rename vars to avoid shadowing.
5750 (x_decode_color, x_set_name, x_window): Now static.
5751 (Fx_create_frame): Add braces to silence GCC warning.
5752 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5753 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5754 Remove unused locals.
5755 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5756 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5757 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5758 macros.
5759
5760 * xterm.h (x_mouse_leave): New decl.
5761
5762 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5763 Remove unused functions.
5764 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5765 (x_calc_absolute_position): Now static.
5766 (XTread_socket): Don't define label "out" unless it's used.
5767 Don't declare local "event" unless it's used.
5768 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5769 unless they are used.
5770 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5771 (x_fatal_error_signal): Remove; not used.
5772 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5773 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5774 (x_error_catcher, x_connection_closed, x_error_handler):
5775 (x_error_quitter, xembed_send_message, x_iconify_frame):
5776 (my_log_handler): Rename locals to avoid shadowing.
5777 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5778 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5779
5780 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5781 Rename or move locals to avoid shadowing.
5782 (tty_defined_color, merge_face_heights): Now static.
5783 (free_realized_faces_for_fontset): Remove; not used.
5784 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5785 does not deduce is never used uninitialized.
5786 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5787 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5788
5789 * terminal.c (store_terminal_param): Now static.
5790
5791 * xmenu.c (menu_highlight_callback): Now static.
5792 (set_frame_menubar): Remove unused local.
5793 (xmenu_show): Rename parameter to avoid shadowing.
5794 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5795 since they might point to immutable storage.
5796 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5797 since it's unused otherwise.
5798
5799 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5800 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5801 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5802 avoids a gcc -Wuninitialized diagnostic.
5803 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5804 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5805 does not deduce are never used uninitialized.
5806
5807 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5808
5809 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5810 * window.c (window_loop, size_window):
5811 (run_window_configuration_change_hook, enlarge_window): Likewise.
5812
5813 * window.c (display_buffer): Now static.
5814 (size_window): Mark variables that gcc -Wuninitialized
5815 does not deduce are never used uninitialized.
5816 * window.h (check_all_windows): New decl, to forestall
5817 gcc -Wmissing-prototypes diagnostic.
5818 * dispextern.h (bidi_dump_cached_states): Likewise.
5819
5820 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5821 shadowing.
5822 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5823 Include <limits.h>.
5824 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5825 and to avoid gcc -Wuninitialized warning.
5826 (load_charset_map): Mark variables that gcc -Wuninitialized
5827 does not deduce are never used uninitialized.
5828 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5829
5830 * coding.c (coding_set_source, coding_set_destination):
5831 Use "else { /* comment */ }" rather than "else /* comment */;"
5832 for clarity, and to avoid gcc -Wempty-body warning.
5833 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5834 a block, when the outer 'i' will do.
5835 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5836 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5837 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5838 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5839 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5840 Rename locals to avoid shadowing.
5841 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5842 * coding.c (emacs_mule_char, encode_invocation_designation):
5843 Now static, since they're not used elsewhere.
5844 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5845 (decode_coding_object, encode_coding_object, detect_coding_system):
5846 (decode_coding_emacs_mule): Mark variables that gcc
5847 -Wuninitialized does not deduce are never used uninitialized.
5848 (detect_coding_iso_2022): Initialize a local variable that might
5849 be used uninitialized. Leave a FIXME because it's not clear that
5850 this initialization is needed. (Bug#8211)
5851 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5852 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5853 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5854 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5855 Remove unused macros.
5856
5857 * category.c (hash_get_category_set): Remove unused local var.
5858 (copy_category_table): Now static, since it's not used elsewhere.
5859 * character.c (string_count_byte8): Likewise.
5860
5861 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5862 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5863
5864 * chartab.c (copy_sub_char_table): Now static, since it's not used
5865 elsewhere.
5866 (sub_char_table_ref_and_range, char_table_ref_and_range):
5867 Rename locals to avoid shadowing.
5868 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5869
5870 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5871 (BIDI_BOB): Remove unused macro.
5872
5873 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5874 deduce are never used uninitialized.
5875 * term.c (encode_terminal_code): Likewise.
5876
5877 * term.c (encode_terminal_code): Now static. Remove unused local.
5878
5879 * tparam.h: New file.
5880 * term.c, tparam.h: Include it.
5881 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5882 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5883 Move these decls to tparam.h, and make them agree with what
5884 is actually in tparam.c. The previous trick of using incompatible
5885 decls in different modules does not conform to the C standard.
5886 All callers of tparam changed to use tparam's actual API.
5887 * tparam.c (tparam1, tparam, tgoto):
5888 Use const pointers where appropriate.
5889
5890 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5891 * cm.h (struct cm): Likewise.
5892 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5893 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5894 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5895 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5896 (turn_on_face, init_tty): Likewise.
5897 * termchar.h (struct tty_display_info): Likewise.
5898
5899 * term.c (term_mouse_position): Rename local to avoid shadowing.
5900
5901 * alloc.c (mark_ttys): Move decl from here ...
5902 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5903
5904 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5905
5906 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5907
5908 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * search.c (compile_pattern_1): Remove argument regp, unused since
5911 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5912 (compile_pattern): Don't pass it.
5913
5914 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5915
5916 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5917 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5918 for ! HAVE_GTK3.
5919 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5920
5921 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5922
5923 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5924 gdk_window_get_screen, gdk_window_get_geometry,
5925 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5926 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5927 (xg_get_pixbuf_from_pixmap): New function.
5928 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5929 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5930 Call xg_get_pixbuf_from_pixmap instead of
5931 gdk_pixbuf_get_from_drawable.
5932 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5933 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5934 (xg_check_special_colors): Use GtkStyleContext and its functions
5935 for HAVE_GTK3.
5936 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5937 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5938 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5939 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5940 Call gtk_widget_get_preferred_size.
5941 (xg_frame_resized): gdk_window_get_geometry only takes 5
5942 parameters.
5943 (xg_win_to_widget, xg_event_is_for_menubar):
5944 Call gdk_x11_window_lookup_for_display.
5945 (xg_set_widget_bg): New function.
5946 (delete_cb): New function.
5947 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5948 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5949 (xg_set_background_color): Call xg_set_widget_bg.
5950 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5951 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5952 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5953 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5954 if ! HAVE_GTK3.
5955 (update_frame_tool_bar): Call gtk_widget_hide.
5956 (xg_initialize): Use GDK_KEY_g.
5957
5958 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5959 if ! HAVE_GTK3
5960 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5961
5962 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5963 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5964 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5965
5966 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5967
5968 * w32xfns.c (select_palette): Check success of RealizePalette against
5969 GDI_ERROR, not zero.
5970
5971 See ChangeLog.11 for earlier changes.
5972
5973 ;; Local Variables:
5974 ;; coding: utf-8
5975 ;; End:
5976
5977 Copyright (C) 2011 Free Software Foundation, Inc.
5978
5979 This file is part of GNU Emacs.
5980
5981 GNU Emacs is free software: you can redistribute it and/or modify
5982 it under the terms of the GNU General Public License as published by
5983 the Free Software Foundation, either version 3 of the License, or
5984 (at your option) any later version.
5985
5986 GNU Emacs is distributed in the hope that it will be useful,
5987 but WITHOUT ANY WARRANTY; without even the implied warranty of
5988 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5989 GNU General Public License for more details.
5990
5991 You should have received a copy of the GNU General Public License
5992 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.