]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* image.c: Fix minor problems reported by GCC 4.6.0.
[gnu-emacs] / src / ChangeLog
1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c: Fix minor problems reported by GCC 4.6.0.
4 (gif_load, svg_load_image): Rename locals to avoid shadowing.
5 (imagemagick_load_image): Fix pointer signedness problem by changing
6 last arg from unsigned char * to char *. All uses changed.
7 Also, fix a local for similar reasons.
8 Remove unused locals. Remove locals to avoid shadowing.
9 (fn_rsvg_handle_free): Remove; unused.
10 (svg_load, svg_load_image): Fix pointer signedness problem.
11
12 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13
14 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
15
16 * image.c (gif_load): Fix omitted cast error introduced by
17 2011-06-06 change.
18
19 2011-06-10 Martin Rudalics <rudalics@gmx.at>
20
21 * window.h (resize_proportionally, orig_total_lines)
22 (orig_top_line): Remove from window structure.
23 (set_window_height, set_window_width, change_window_heights)
24 (Fdelete_window): Remove prototypes.
25 (resize_frame_windows): Remove duplicate declaration.
26
27 2011-06-10 Eli Zaretskii <eliz@gnu.org>
28
29 * window.h (resize_frame_windows, resize_window_check)
30 (delete_deletable_window, resize_root_window)
31 (resize_frame_windows): Declare prototypes.
32
33 * window.c (resize_window_apply): Make definition be "static" to
34 match the prototype.
35
36 2011-06-10 Martin Rudalics <rudalics@gmx.at>
37
38 * window.c: Remove declarations of Qwindow_size_fixed,
39 window_min_size_1, window_min_size_2, window_min_size,
40 size_window, window_fixed_size_p, enlarge_window, delete_window.
41 Remove static from declaration of Qdelete_window, it's
42 temporarily needed by Fbury_buffer.
43 (replace_window): Don't assign orig_top_line and
44 orig_total_lines.
45 (Fdelete_window, delete_window): Remove. Window deletion is
46 handled by window.el.
47 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
48 Fdelete_window calls with calls to Qdelete_window.
49 (Fdelete_other_windows): Remove. Deleting other windows is
50 handled by window.el.
51 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
52 handled in window.el.
53 (window_min_size_2, window_min_size_1, window_min_size): Remove.
54 Window minimum sizes are handled in window.el.
55 (shrink_windows, size_window, set_window_height)
56 (set_window_width, change_window_heights, window_height)
57 (window_width, CURBEG, CURSIZE, enlarge_window)
58 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
59 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
60 handled in window.el.
61 (make_dummy_parent): Rename to make_parent_window and give it a
62 second argument horflag.
63 (make_window): Don't set resize_proportionally any more.
64 (Fsplit_window): Remove. Windows are split in window.el.
65 (save_restore_action, save_restore_orig_size)
66 (shrink_window_lowest_first, save_restore_orig_size): Remove.
67 Resize mini windows in window.el.
68 (grow_mini_window, shrink_mini_window): Implement by calling
69 Qresize_root_window_vertically, resize_window_check and
70 resize_window_apply.
71 (saved_window, Fset_window_configuration, save_window_save): Do
72 not handle orig_top_line, orig_total_lines, and
73 resize_proportionally.
74 (window_min_height, window_min_width): Move to window.el.
75 (keys_of_window): Move bindings for delete-other-windows,
76 split-window, delete-window and enlarge-window to window.el.
77
78 * buffer.c: Temporarily extern Qdelete_window.
79 (Fbury_buffer): Temporarily call Qdelete_window instead of
80 Fdelete_window (Fbury_buffer will move to window.el soon).
81
82 * frame.c (set_menu_bar_lines_1): Remove code handling
83 orig_top_line and orig_total_lines.
84
85 * dispnew.c (adjust_frame_glyphs_initially): Don't use
86 set_window_height but set heights directly.
87 (change_frame_size_1): Use resize_frame_windows.
88
89 * xdisp.c (init_xdisp): Don't use set_window_height but set
90 heights directly.
91
92 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
93 resize_frame_windows instead of change_window_heights and run
94 run_window_configuration_change_hook.
95
96 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
97 instead of change_window_heights and run
98 run_window_configuration_change_hook.
99
100 2011-06-09 Martin Rudalics <rudalics@gmx.at>
101
102 * window.c (replace_window): Rename second argument REPLACEMENT to
103 NEW. New third argument SETFLAG. Rewrite.
104 (delete_window, make_dummy_parent): Call replace_window with
105 third argument 1.
106 (window_list_1): Move down in code.
107 (run_window_configuration_change_hook): Move set_buffer part
108 before select_frame_norecord part in order to unwind correctly.
109 Rename count1 to count.
110 (recombine_windows, delete_deletable_window, resize_root_window)
111 (Fdelete_other_windows_internal)
112 (Frun_window_configuration_change_hook, make_parent_window)
113 (resize_window_check, resize_window_apply, Fresize_window_apply)
114 (resize_frame_windows, Fsplit_window_internal)
115 (Fdelete_window_internal, Fresize_mini_window_internal): New
116 functions.
117 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
118
119 2011-06-08 Martin Rudalics <rudalics@gmx.at>
120
121 * window.h (window): Add some new members to window structure -
122 normal_lines, normal_cols, new_total, new_normal, clone_number,
123 splits, nest, prev_buffers, next_buffers.
124 (WINDOW_TOTAL_SIZE): Move here from window.c.
125 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
126
127 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
128 Remove.
129 (make_dummy_parent): Set new members of windows structure.
130 (make_window): Move down in code. Handle new members of window
131 structure.
132 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
133 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
134 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
135 (Fset_window_prev_buffers, Fwindow_next_buffers)
136 (Fset_window_next_buffers, Fset_window_clone_number): New
137 functions.
138 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
139 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
140 Doc-string fixes.
141 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
142 Argument WINDOW can be now internal window too.
143 (Fwindow_use_time): Move up in code.
144 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
145 Rewrite doc-string.
146 (Fset_window_configuration, saved_window)
147 (Fcurrent_window_configuration, save_window_save): Handle new
148 members of window structure.
149 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
150 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
151 (syms_of_window): New Lisp objects Qrecord_window_buffer,
152 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
153 Qget_mru_window, Qresize_root_window,
154 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
155 Qauto_buffer_name; staticpro them.
156
157 2011-06-07 Martin Rudalics <rudalics@gmx.at>
158
159 * window.c (Fwindow_total_size, Fwindow_left_column)
160 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
161 (Fwindow_list_1): New functions.
162 (window_box_text_cols): Replace with window_body_cols.
163 (Fwindow_width, Fscroll_left, Fscroll_right): Use
164 window_body_cols instead of window_box_text_cols.
165 (delete_window, Fset_window_configuration): Call
166 delete_all_subwindows with window as argument.
167 (delete_all_subwindows): Take a window as argument and not a
168 structure. Rewrite.
169 (window_loop): Remove handling of GET_LRU_WINDOW and
170 GET_LARGEST_WINDOW.
171 (Fget_lru_window, Fget_largest_window): Move to window.el.
172
173 * window.h: Extern window_body_cols instead of
174 window_box_text_cols. delete_all_subwindows now takes a
175 Lisp_Object as argument.
176
177 * indent.c (compute_motion, Fcompute_motion): Use
178 window_body_cols instead of window_box_text_cols.
179
180 * frame.c (delete_frame): Call delete_all_subwindows with root
181 window as argument.
182
183 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
184
185 * fns.c (Fputhash): Document return value.
186
187 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
188
189 * image.c (gif_load): Implement gif89a spec "no disposal" method.
190
191 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
192
193 Cons<->int and similar integer overflow fixes (Bug#8794).
194
195 Check for overflow when converting integer to cons and back.
196 * charset.c (Fdefine_charset_internal, Fdecode_char):
197 Use cons_to_unsigned to catch overflow.
198 (Fencode_char): Use INTEGER_TO_CONS.
199 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
200 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
201 * data.c (long_to_cons, cons_to_long): Remove.
202 (cons_to_unsigned, cons_to_signed): New functions.
203 These signal an error for invalid or out-of-range values.
204 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
205 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
206 * font.c (Ffont_variation_glyphs):
207 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
208 * lisp.h: Include <intprops.h>.
209 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
210 (cons_to_signed, cons_to_unsigned): New decls.
211 (long_to_cons, cons_to_long): Remove decls.
212 * undo.c (record_first_change): Use INTEGER_TO_CONS.
213 (Fprimitive_undo): Use CONS_TO_INTEGER.
214 * xfns.c (Fx_window_property): Likewise.
215 * xselect.c: Include <limits.h>.
216 (x_own_selection, selection_data_to_lisp_data):
217 Use INTEGER_TO_CONS.
218 (x_handle_selection_request, x_handle_selection_clear)
219 (x_get_foreign_selection, Fx_disown_selection_internal)
220 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
221 (lisp_data_to_selection_data): Use cons_to_unsigned.
222 (x_fill_property_data): Use cons_to_signed.
223 Report values out of range.
224
225 Check for buffer and string overflow more precisely.
226 * buffer.h (BUF_BYTES_MAX): New macro.
227 * lisp.h (STRING_BYTES_MAX): New macro.
228 * alloc.c (Fmake_string):
229 * character.c (string_escape_byte8):
230 * coding.c (coding_alloc_by_realloc):
231 * doprnt.c (doprnt):
232 * editfns.c (Fformat):
233 * eval.c (verror):
234 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
235 since they may not be the same number.
236 * editfns.c (Finsert_char):
237 * fileio.c (Finsert_file_contents):
238 Likewise for BUF_BYTES_MAX.
239
240 * image.c: Use ptrdiff_t, not int, for sizes.
241 (slurp_file): Switch from int to ptrdiff_t.
242 All uses changed.
243 (slurp_file): Check that file size fits in both size_t (for
244 malloc) and ptrdiff_t (for sanity and safety).
245
246 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
247 if b->modtime has its maximal value.
248
249 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
250
251 Don't assume time_t can fit into int.
252 * buffer.h (struct buffer.modtime): Now time_t, not int.
253 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
254 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
255
256 Minor fixes for signed vs unsigned integers.
257 * character.h (MAYBE_UNIFY_CHAR):
258 * charset.c (maybe_unify_char):
259 * keyboard.c (read_char, reorder_modifiers):
260 XINT -> XFASTINT, since the integer must be nonnegative.
261 * ftfont.c (ftfont_spec_pattern):
262 * keymap.c (access_keymap, silly_event_symbol_error):
263 XUINT -> XFASTINT, since the integer must be nonnegative.
264 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
265 since it makes no difference and we prefer signed.
266 * keyboard.c (record_char): Use XUINT when all the neighbors do.
267 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
268 nonnegative.
269
270 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
271
272 * window.h (Fwindow_frame): Declare.
273
274 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
275
276 * alloc.c: Simplify handling of large-request failures (Bug#8800).
277 (SPARE_MEMORY): Always define.
278 (LARGE_REQUEST): Remove.
279 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
280
281 2011-06-06 Martin Rudalics <rudalics@gmx.at>
282
283 * lisp.h: Move EXFUNS for Fframe_root_window,
284 Fframe_first_window and Fset_frame_selected_window to window.h.
285
286 * window.h: Move EXFUNS for Fframe_root_window,
287 Fframe_first_window and Fset_frame_selected_window here from
288 lisp.h.
289
290 * frame.c (Fwindow_frame, Fframe_first_window)
291 (Fframe_root_window, Fframe_selected_window)
292 (Fset_frame_selected_window): Move to window.c.
293 (Factive_minibuffer_window): Move to minibuf.c.
294 (Fother_visible_frames_p): New function.
295
296 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
297
298 * window.c (decode_window, decode_any_window): Move up in code.
299 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
300 (inhibit_frame_unsplittable): Remove unused variable.
301 (Fwindow_buffer): Move up and rewrite doc-string.
302 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
303 (Fwindow_prev): New functions.
304 (Fwindow_frame): Move here from frame.c. Accept any window as
305 argument.
306 (Fframe_root_window, Fframe_first_window)
307 (Fframe_selected_window): Move here from frame.c. Accept frame
308 or arbitrary window as argument. Update doc-strings.
309 (Fminibuffer_window): Move up in code.
310 (Fwindow_minibuffer_p): Move up in code and simplify.
311 (Fset_frame_selected_window): Move here from frame.c.
312 Marginal rewrite.
313 (Fselected_window, select_window, Fselect_window): Move up in
314 code. Minor doc-string fixes.
315
316 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
317
318 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
319 Do not assume that spare memory exists; that assumption is valid
320 only if SYSTEM_MALLOC.
321 (LARGE_REQUEST): New macro, so that the issue of large requests
322 is separated from the issue of spare memory.
323
324 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
325
326 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
327 format. (Bug#8806)
328
329 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
330
331 * xfns.c (x_set_scroll_bar_default_width): Move declarations
332 before statements.
333
334 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
335
336 * gtkutil.c (xg_get_default_scrollbar_width): New function.
337
338 * gtkutil.h: Declare xg_get_default_scrollbar_width.
339
340 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
341 min width by calling x_set_scroll_bar_default_width (Bug#8505).
342
343 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
344
345 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
346
347 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
348
349 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
350 (x_clipboard_manager_save): Add return value.
351 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
352 New error handlers.
353 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
354 Obey Vx_select_enable_clipboard_manager. Catch errors in
355 x_clipboard_manager_save (Bug#8779).
356 (Vx_select_enable_clipboard_manager): New variable.
357 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
358
359 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
360
361 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
362
363 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
364
365 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
366 in the current matrix if keep_current_p is non-zero.
367
368 2011-06-04 Eli Zaretskii <eliz@gnu.org>
369
370 * bidi.c (bidi_level_of_next_char): Fix last change.
371
372 2011-06-03 Eli Zaretskii <eliz@gnu.org>
373
374 Support bidi reordering of text covered by display properties.
375
376 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
377 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
378 (bidi_cache_search, bidi_cache_iterator_state)
379 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
380 (bidi_level_of_next_char, bidi_move_to_visually_next):
381 Support character positions inside a run of characters covered by a
382 display string.
383 (bidi_paragraph_init, bidi_resolve_explicit_1)
384 (bidi_level_of_next_char): Call bidi_fetch_char and
385 bidi_fetch_char_advance instead of FETCH_CHAR and
386 FETCH_CHAR_ADVANCE.
387 (bidi_init_it): Initialize new members.
388 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
389 definitions.
390 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
391 instead of using explicit *_CHAR codes.
392 (bidi_resolve_explicit, bidi_resolve_weak):
393 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
394 bidirectional text is supported only in multibyte buffers.
395 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
396 it to initialize the frame_window_p member of struct bidi_it.
397 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
398 (bidi_resolve_explicit, bidi_resolve_weak)
399 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
400 bidi_it->nchars is non-positive.
401 (bidi_level_of_next_char): Don't try to lookup the cache for the
402 next/previous character if nothing is cached there yet, or if we
403 were just reseat()'ed to a new position.
404
405 * xdisp.c (set_cursor_from_row): Set start and stop points
406 according to the row's direction when priming the loop that looks
407 for the glyph on which to display cursor.
408 (single_display_spec_intangible_p): Function deleted.
409 (display_prop_intangible_p): Reimplement to call
410 handle_display_spec instead of single_display_spec_intangible_p.
411 Accept 3 additional arguments needed by handle_display_spec.
412 This fixes incorrect cursor motion across display property with complex
413 values: lists, `(when COND...)' forms, etc.
414 (single_display_spec_string_p): Support property values that are
415 lists with the argument STRING its top-level element.
416 (display_prop_string_p): Fix the condition for processing a
417 property that is a list to be consistent with handle_display_spec.
418 (handle_display_spec): New function, refactored from the
419 last portion of handle_display_prop.
420 (compute_display_string_pos): Accept additional argument
421 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
422 value of a `display' property is a "replacing spec".
423 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
424 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
425 the display property, but just return a value indicating whether
426 the display property will replace the characters it covers.
427 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
428 frame_window_p members of struct bidi_it.
429 (compute_display_string_pos, compute_display_string_end):
430 New functions.
431 (push_it): Accept second argument POSITION, where pop_it should
432 jump to continue iteration.
433 (reseat_1): Initialize bidi_it.disp_pos.
434
435 * keyboard.c (adjust_point_for_property): Adjust the call to
436 display_prop_intangible_p to its new signature.
437
438 * dispextern.h (struct bidi_it): New member frame_window_p.
439 (bidi_init_it): Update prototypes.
440 (display_prop_intangible_p): Update prototype.
441 (compute_display_string_pos, compute_display_string_end):
442 Declare prototypes.
443 (struct bidi_it): New members nchars and disp_pos. ch_len is now
444 EMACS_INT.
445
446 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
447
448 Malloc failure behavior now depends on size of allocation.
449 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
450 * lisp.h: Change signatures accordingly.
451 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
452 All callers changed. (Bug#8762)
453
454 * gnutls.c: Use Emacs's memory allocators.
455 Without this change, the gnutls library would invoke malloc etc.
456 directly, which causes problems on non-SYNC_INPUT hosts, and which
457 runs afoul of improving memory_full behavior. (Bug#8761)
458 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
459 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
460 xfree instead of the default malloc, realloc, free.
461 (Fgnutls_boot): No need to check for memory allocation failure,
462 since xmalloc does that for us.
463
464 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
465 * category.c (hash_get_category_set):
466 * ccl.c (ccl_driver):
467 * charset.c (Fdefine_charset_internal):
468 * charset.h (struct charset.hash_index):
469 * composite.c (get_composition_id, gstring_lookup_cache)
470 (composition_gstring_put_cache):
471 * composite.h (struct composition.hash_index):
472 * dispextern.h (struct image.hash):
473 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
474 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
475 (hashfn_equal, hashfn_user_defined, make_hash_table)
476 (maybe_resize_hash_table, hash_lookup, hash_put)
477 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
478 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
479 (Fsxhash, Fgethash, Fputhash, Fmaphash):
480 * image.c (make_image, search_image_cache, lookup_image)
481 (xpm_put_color_table_h):
482 * lisp.h (struct Lisp_Hash_Table):
483 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
484 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
485 for hashes and hash indexes, instead of 'unsigned' and 'int'.
486 * alloc.c (allocate_vectorlike):
487 Check for overflow in vector size calculations.
488 * ccl.c (ccl_driver):
489 Check for overflow when converting EMACS_INT to int.
490 * fns.c, image.c: Remove unnecessary static decls that would otherwise
491 need to be updated by these changes.
492 * fns.c (make_hash_table, maybe_resize_hash_table):
493 Check for integer overflow with large hash tables.
494 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
495 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
496 (SXHASH_REDUCE): New macro.
497 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
498 Use it instead of discarding useful hash info with large hash values.
499 (sxhash_float): New function.
500 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
501 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
502 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
503 Rewrite to use FIXNUM_BITS, as this simplifies things.
504 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
505 Adjust signatures to match updated version of code.
506 (consing_since_gc): Now EMACS_INT, since a single hash table can
507 use more than INT_MAX bytes.
508
509 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
510
511 Make it possible to build with GCC-4.6+ -O2 -flto.
512
513 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
514
515 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
516
517 * minibuf.c (get_minibuffer, read_minibuf_unwind):
518 Call minibuffer-inactive-mode.
519
520 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
521
522 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
523 Update dependencies.
524
525 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
526
527 * data.c (init_data): Remove code for UTS, this system is not
528 supported anymore.
529
530 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
531
532 Don't force ./temacs to start in terminal mode.
533
534 * frame.c (make_initial_frame): Initialize faces in all cases, not
535 only when CANNOT_DUMP is defined.
536 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
537
538 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
539
540 * dispnew.c (add_window_display_history): Use const for the string
541 pointer. Remove declaration, not needed.
542
543 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
544
545 Use 'inline', not 'INLINE'.
546 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
547 * alloc.c, fontset.c (INLINE): Remove.
548 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
549 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
550 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
551 * gmalloc.c (register_heapinfo): Use inline unconditionally.
552 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
553
554 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
555
556 Make it possible to run ./temacs.
557
558 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
559 syms_of_callproc does the same thing. Remove test for
560 "initialized", do it in the caller.
561 * emacs.c (main): Avoid calling set_initial_environment when dumping.
562
563 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
564
565 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
566 (read_minibuf): Use get_minibuffer.
567 (syms_of_minibuf): Use DEFSYM.
568 (Qmetadata): New var.
569 * data.c (Qbuffer): Don't make it static.
570 (syms_of_data): Use DEFSYM.
571
572 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
573
574 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
575 (CCL_CODE_MIN): New macro.
576
577 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
578
579 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
580
581 * eval.c (Qdebug): Now static.
582 * lisp.h (Qdebug): Remove decl. This reverts a part of the
583 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
584 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
585
586 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
587
588 * image.c: Various fixes to ImageMagick code comments.
589 (Fimagemagick_types): Doc fix.
590
591 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
592
593 Minor fixes prompted by GCC 4.6.0 warnings.
594
595 * xselect.c (converted_selections, conversion_fail_tag): Now static.
596
597 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
598 (x_clipboard_manager_save_all): Move extern decl to ...
599 * xterm.h: ... here, so that it can be checked for consistency.
600
601 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
602
603 * xselect.c (x_clipboard_manager_save_frame)
604 (x_clipboard_manager_save_all): New functions.
605 (Fx_clipboard_manager_save): Lisp function deleted.
606
607 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
608 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
609
610 * xterm.h: Update prototype.
611
612 2011-05-28 William Xu <william.xwl@gmail.com>
613
614 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
615 exiting (Bug#8239).
616
617 2011-05-28 Jim Meyering <meyering@redhat.com>
618
619 Avoid a sign-extension bug in crypto_hash_function.
620 * fns.c (to_uchar): Define.
621 (crypto_hash_function): Use it to convert some newly-signed
622 variables to unsigned, to avoid sign-extension bugs. For example,
623 without this change, (md5 "truc") would evaluate to
624 45723a2aff78ff4fff7fff1114760e62 rather than the expected
625 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
626 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
627
628 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
629
630 Integer overflow fixes.
631
632 * dbusbind.c: Serial number integer overflow fixes.
633 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
634 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
635 to hold a serial number that is too large for a fixnum.
636 (Fdbus_method_return_internal, Fdbus_method_error_internal):
637 Check for serial numbers out of range. Decode any serial number
638 that was so large that it became a float. (Bug#8722)
639
640 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
641 (Fdbus_call_method, Fdbus_call_method_asynchronously):
642 Use XFASTINT rather than XUINT when numbers are nonnegative.
643 (xd_append_arg, Fdbus_method_return_internal):
644 (Fdbus_method_error_internal): Likewise. Also, for unsigned
645 arguments, check that Lisp number is nonnegative, rather than
646 silently wrapping negative numbers around. (Bug#8722)
647 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
648 (Bug#8722)
649
650 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
651
652 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
653
654 ccl: add integer overflow checks
655 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
656 (IN_INT_RANGE): New macros.
657 (ccl_driver): Use them to check for integer overflow when
658 decoding a CCL program. Many of the new checks are whether XINT (x)
659 fits in int; it doesn't always, on 64-bit hosts. The new version
660 doesn't catch all possible integer overflows, but it's an
661 improvement. (Bug#8719)
662
663 * alloc.c (make_event_array): Use XINT, not XUINT.
664 There's no need for unsigned here.
665
666 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
667 This follows up to the 2011-05-06 change that substituted uintptr_t
668 for EMACS_INT. This case wasn't caught back then.
669
670 Rework Fformat to avoid integer overflow issues.
671 * editfns.c: Include <float.h> unconditionally, as it's everywhere
672 now (part of C89). Include <verify.h>.
673 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
674 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
675 (Fformat): Avoid the prepass trying to compute sizes; it was only
676 approximate and thus did not catch overflow reliably. Instead, walk
677 through the format just once, formatting and computing sizes as we go,
678 checking for integer overflow at every step, and allocating a larger
679 buffer as needed. Keep track separately whether the format is
680 multibyte. Keep only the most-recently calculated precision, rather
681 than them all. Record whether each argument has been converted to
682 string. Use EMACS_INT, not int, for byte and char and arg counts.
683 Support field widths and precisions larger than INT_MAX. Avoid
684 sprintf's undefined behavior with conversion specifications such as %#d
685 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
686 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
687 formatting out-of-range floating point numbers with int
688 formats. (Bug#8668)
689
690 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
691
692 * data.c: Avoid integer truncation in expressions involving floats.
693 * data.c: Include <intprops.h>.
694 (arith_driver): When there's an integer overflow in an expression
695 involving floating point, convert the integers to floating point
696 so that the resulting value does not suffer from catastrophic
697 integer truncation. For example, on a 64-bit host (* 4
698 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
699 Do not rely on undefined behavior after integer overflow.
700
701 merge count_size_as_multibyte, parse_str_to_multibyte
702 * character.c, character.h (count_size_as_multibyte):
703 Rename from parse_str_to_multibyte; all uses changed.
704 Check for integer overflow.
705 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
706 since it's now a duplicate of the other. This is more of
707 a character than a buffer op, so better that it's in character.c.
708 * fns.c, print.c: Adjust to above changes.
709
710 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
711
712 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
713
714 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
715
716 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
717 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
718 (x_clipboard_manager_save): Now static.
719 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
720
721 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
722 (crypto_hash_function): Now static.
723 Fix pointer signedness problems. Avoid unnecessary initializations.
724
725 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
726
727 * termhooks.h (Vselection_alist): Make it terminal-local.
728
729 * terminal.c (create_terminal): Initialize it.
730
731 * xselect.c: Support for clipboard managers.
732 (Vselection_alist): Move to termhooks.h as terminal-local var.
733 (LOCAL_SELECTION): New macro.
734 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
735 (symbol_to_x_atom): Remove gratuitous arg.
736 (x_handle_selection_request, lisp_data_to_selection_data)
737 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
738 (x_own_selection, x_get_local_selection, x_convert_selection):
739 New arg, specifying work frame. Use terminal-local Vselection_alist.
740 (some_frame_on_display): Delete unused function.
741 (Fx_own_selection_internal, Fx_get_selection_internal)
742 (Fx_disown_selection_internal, Fx_selection_owner_p)
743 (Fx_selection_exists_p): New optional frame arg.
744 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
745 (x_handle_selection_clear): Don't treat other terminals with the
746 same keyboard specially. Use the terminal-local Vselection_alist.
747 (x_clear_frame_selections): Use Frun_hook_with_args.
748
749 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
750
751 * xterm.h: Add support for those atoms.
752
753 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
754
755 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
756 (converted_selections, conversion_fail_tag): New global variables.
757 (x_selection_request_lisp_error): Free the above.
758 (x_get_local_selection): Remove unnecessary code.
759 (x_reply_selection_request): Args changed; handle arbitrary array
760 of converted selections stored in converted_selections.
761 Separate the XChangeProperty and SelectionNotify steps.
762 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
763 (x_convert_selection): New function.
764 (x_handle_selection_event): Simplify.
765 (x_get_foreign_selection): Don't ignore incoming requests while
766 waiting for an answer; this will fail when we implement
767 SAVE_TARGETS, and seems unnecessary anyway.
768 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
769 (Vx_sent_selection_functions): Doc fix.
770
771 2011-05-26 Leo Liu <sdl.web@gmail.com>
772
773 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
774
775 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
776
777 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
778
779 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
780 for fringe update if it has periodic bitmap.
781 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
782 and fringe_bitmap_periodic_p.
783
784 * fringe.c (get_fringe_bitmap_data): New function.
785 (draw_fringe_bitmap_1, update_window_fringes): Use it.
786 (update_window_fringes): Record periodicity of fringe bitmap in glyph
787 row. Mark glyph row for fringe update if periodicity changed.
788
789 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
790 for fringe update unless it has periodic bitmap.
791
792 2011-05-25 Kenichi Handa <handa@m17n.org>
793
794 * xdisp.c (get_next_display_element): Set correct it->face_id for
795 a static composition.
796
797 2011-05-24 Leo Liu <sdl.web@gmail.com>
798
799 * deps.mk (fns.o):
800 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
801
802 * fns.c (crypto_hash_function, Fsha1): New function.
803 (Fmd5): Use crypto_hash_function.
804 (syms_of_fns): Add Ssha1.
805
806 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
807
808 * gnutls.c: Remove unused macros.
809 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
810 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
811 Remove macros that are defined and never used.
812 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
813
814 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
815
816 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
817 (Fx_get_selection_internal): Minor cleanup.
818 (Fx_own_selection_internal): Rename arguments for consistency with
819 select.el.
820
821 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
822
823 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
824
825 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
826
827 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
828
829 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
830
831 * dispnew.c (scrolling_window): Don't exclude the case that the
832 last enabled row in the desired matrix touches the bottom boundary.
833
834 2011-05-21 Glenn Morris <rgm@gnu.org>
835
836 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
837 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
838 and add some more files.
839
840 2011-05-20 Eli Zaretskii <eliz@gnu.org>
841
842 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
843 report_file_error introduced by the change from 2011-05-07.
844
845 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
846
847 * systime.h (Time): Define only if emacs is defined.
848 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
849 where the include path doesn't have X11/X.h by default. See
850 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
851
852 2011-05-20 Kenichi Handa <handa@m17n.org>
853
854 * composite.c (find_automatic_composition): Fix previous change.
855
856 2011-05-20 Glenn Morris <rgm@gnu.org>
857
858 * lisp.mk: New file, split from Makefile.in.
859 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
860 (shortlisp): Remove.
861 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
862
863 2011-05-19 Glenn Morris <rgm@gnu.org>
864
865 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
866 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
867 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
868 (lisp): Set the order to that of loadup.el.
869 (shortlisp): Make it a copy of $lisp.
870 (SOME_MACHINE_LISP): Remove.
871 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
872 Use just $shortlisp, not $SOME_MACHINE_LISP too.
873
874 2011-05-18 Kenichi Handa <handa@m17n.org>
875
876 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
877 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
878 (find_automatic_composition): Mostly rewrite for efficiency.
879
880 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
881
882 * makefile.w32-in: Update dependencies.
883
884 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
885
886 * menu.c: Include limits.h (fixes the MS-Windows build broken by
887 revision 104625).
888
889 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
890
891 Fix some integer overflow issues, such as string length overflow.
892
893 * insdel.c (count_size_as_multibyte): Check for string overflow.
894
895 * character.c (lisp_string_width): Check for string overflow.
896 Use EMACS_INT, not int, for string indexes and lengths; in
897 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
898 the resulting string length overflows an EMACS_INT; instead,
899 report a string overflow if no precision given. When checking for
900 precision exhaustion, use a check that cannot possibly have
901 integer overflow. (Bug#8675)
902 * character.h (lisp_string_width): Adjust to new signature.
903
904 * alloc.c (string_overflow): New function.
905 (Fmake_string): Use it. This doesn't change behavior, but saves
906 a few bytes and will simplify future changes.
907 * character.c (string_escape_byte8): Likewise.
908 * lisp.h (string_overflow): New decl.
909
910 Fixups, following up to the user-interface timestamp change.
911 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
912 for UI timestamps, instead of unsigned long.
913 * msdos.c (mouse_get_pos): Likewise.
914 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
915 * w32gui.h (Time): Define by including "systime.h" rather than by
916 declaring it ourselves. (Bug#8664)
917
918 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
919 * image.c (clear_image_cache): Likewise.
920
921 * term.c (term_mouse_position): Don't assume time_t wraparound.
922
923 Be more systematic about user-interface timestamps.
924 Before, the code sometimes used 'Time', sometimes 'unsigned long',
925 and sometimes 'EMACS_UINT', to represent these timestamps.
926 This change causes it to use 'Time' uniformly, as that's what X uses.
927 This makes the code easier to follow, and makes it easier to catch
928 integer overflow bugs such as Bug#8664.
929 * frame.c (Fmouse_position, Fmouse_pixel_position):
930 Use Time, not unsigned long, for user-interface timestamps.
931 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
932 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
933 * keyboard.h (last_event_timestamp): Likewise.
934 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
935 * menu.h (xmenu_show): Likewise.
936 * term.c (term_mouse_position): Likewise.
937 * termhooks.h (struct input_event.timestamp): Likewise.
938 (struct terminal.mouse_position_hook): Likewise.
939 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
940 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
941 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
942 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
943 what it was before.
944 * menu.h, termhooks.h: Include "systime.h", for Time.
945
946 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
947 Don't assume that the difference between two unsigned long values
948 can fit into an integer. At this point, we know button_down_time
949 <= event->timestamp, so the difference must be nonnegative, so
950 there's no need to cast the result if double-click-time is
951 nonnegative, as it should be; check that it's nonnegative, just in
952 case. This bug is triggered when events are more than 2**31 ms
953 apart (about 25 days). (Bug#8664)
954
955 * xselect.c (last_event_timestamp): Remove duplicate decl.
956 (x_own_selection): Remove needless cast to unsigned long.
957
958 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
959 that always fit in int. Use a sentinel instead of a counter, to
960 avoid a temp and to allay GCC's concerns about possible int overflow.
961 * frame.h (struct frame): Use int for menu_bar_items_used
962 instead of EMACS_INT, since it always fits in int.
963
964 * menu.c (grow_menu_items): Check for int overflow.
965
966 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
967
968 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
969 Before, the code was not consistent. These values cannot exceed
970 2**31 - 1 so there's no need to make them unsigned.
971 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
972 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
973 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
974 as modifiers.
975 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
976
977 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
978 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
979 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
980 presumably because the widths might not match.
981
982 * window.c (size_window): Avoid needless test at loop start.
983
984 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
985
986 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
987
988 2011-05-12 Drew Adams <drew.adams@oracle.com>
989
990 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
991
992 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
993
994 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
995 `width' to `bar_area_x' and `bar_area_width', respectively.
996 (x_scroll_run): Take account of fringe background extension.
997
998 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
999 Rename local vars `left' and `width' to `bar_area_x' and
1000 `bar_area_width', respectively.
1001 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1002 background extension.
1003
1004 2011-05-10 Jim Meyering <meyering@redhat.com>
1005
1006 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1007
1008 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1009
1010 * image.c (Finit_image_library): Return t for built-in image types,
1011 like pbm and xbm. (Bug#8640)
1012
1013 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1016
1017 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1018
1019 * w32console.c (Fset_screen_color): Doc fix.
1020 (Fget_screen_color): New function.
1021 (syms_of_ntterm): Defsubr it.
1022
1023 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1024 unlink the temporary file if Fcall_process didn't create it in the
1025 first place.
1026 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1027 child process will be redirected to a file specified with `:file'.
1028 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1029 cue to call_process_cleanup not to close that handle.
1030
1031 2011-05-07 Ben Key <bkey76@gmail.com>
1032
1033 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1034 one of two shell specific rules, either bootstrap-temacs-CMD or
1035 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1036 to the previous implementation of the bootstrap-temacs rule.
1037 The bootstrap-temacs-CMD rule is similar to the previous
1038 implementation of the bootstrap-temacs rule except that it
1039 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1040 variable.
1041
1042 These changes, along with some changes to nt/configure.bat,
1043 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1044 earlier fix to add support for --cflags and --ldflags options
1045 that include quotes so that it works whether make uses cmd or
1046 sh as the shell.
1047
1048 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1049
1050 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1051 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1052 is a constant.
1053 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1054 a string. Handle both cases.
1055 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1056 (Fdbus_register_method): Use Qinvalid_function.
1057
1058 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * makefile.w32-in: Update dependencies.
1061 (LISP_H): Add inttypes.h and stdin.h.
1062 (PROCESS_H): Add unistd.h.
1063
1064 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1065
1066 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1067 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1068
1069 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1072
1073 * term.c (vfatal): Remove stray call to va_end.
1074 It's not needed and the C Standard doesn't allow it here anyway.
1075
1076 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1077 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1078
1079 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1080 bytes.
1081
1082 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1083
1084 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1085
1086 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1087
1088 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1089
1090 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1091
1092 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1093 * charset.c (Fdefine_charset_internal): Don't initialize
1094 charset.code_space[15]. The value was garbage, on hosts with
1095 32-bit int (Bug#8600).
1096
1097 * lread.c (read_integer): Be more consistent with string-to-number.
1098 Use string_to_number to do the actual conversion; this avoids
1099 rounding errors and fixes some other screwups. Without this fix,
1100 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1101 (digit_to_number): Move earlier, for benefit of read_integer.
1102 Return -1 if the digit is out of range for the base, -2 if it is
1103 not a digit in any supported base. (Bug#8602)
1104
1105 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1106
1107 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1108 to match comment at start of function. This also removes a
1109 GCC warning about overflow in a 32+64-bit port.
1110
1111 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1112
1113 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1114 Reported by Stefan Monnier in
1115 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1116 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1117 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1118
1119 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1120 (EMACS_UINTPTR): Likewise, with uintptr_t.
1121
1122 * lisp.h: Prefer 64-bit EMACS_INT if available.
1123 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1124 on 32-bit hosts that have 64-bit int, so that they can access
1125 large files.
1126 However, temporarily disable this change unless the temporary
1127 symbol WIDE_EMACS_INT is defined.
1128
1129 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1130
1131 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1132 This removes an assumption that EMACS_INT and long are the same
1133 width as pointers. The assumption is true for Emacs porting targets
1134 now, but we want to make other targets possible.
1135 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1136 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1137 In the rest of the code, change types of integers that hold casted
1138 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1139 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1140 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1141 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1142 No need to cast type when ORing.
1143 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1144 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1145 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1146 assume EMACS_INT is the same width as char *.
1147 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1148 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1149 Remove no-longer-needed casts.
1150 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1151 (xg_tool_bar_help_callback, xg_make_tool_item):
1152 Use EMACS_INTPTR to hold an integer
1153 that will be cast to void *; this can avoid a GCC warning
1154 if EMACS_INT is not the same width as void *.
1155 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1156 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1157 (current_message_1, set_message_1):
1158 Use a local to convert to proper width without a cast.
1159 * xmenu.c (dialog_selection_callback): Likewise.
1160
1161 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1162 Also, don't assume VALBITS / RAND_BITS is less than 5,
1163 and don't rely on undefined behavior when shifting a 1 left into
1164 the sign bit.
1165 * lisp.h (get_random): Change signature to match.
1166
1167 * lread.c (hash_string): Use size_t, not int, for hash computation.
1168 Normally we prefer signed values; but hashing is special, because
1169 it's better to use unsigned division on hash table sizes so that
1170 the remainder is nonnegative. Also, size_t is the natural width
1171 for hashing into memory. The previous code used 'int', which doesn't
1172 retain enough info to hash well into very large tables.
1173 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1174
1175 * dbusbind.c: Don't possibly lose pointer info when converting.
1176 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1177 Use XPNTR rather than XHASH, so that the high-order bits of
1178 the pointer aren't lost when converting through void *.
1179
1180 * eval.c (Fautoload): Don't double-shift a pointer.
1181
1182 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1183
1184 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * gnutls.c (DEF_GNUTLS_FN):
1187 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1188
1189 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1190
1191 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1192 marker. (Bug#8610)
1193
1194 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1195
1196 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1197 New version that can reserve upto 2GB of heap space.
1198
1199 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1200
1201 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1202
1203 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1204
1205 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1206 `gnutls_certificate_set_x509_key_file'.
1207
1208 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1211 Update dependencies.
1212
1213 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1216 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1217 Remove unused parameter `fildes'.
1218 * process.c (read_process_output, send_process): Don't pass it.
1219
1220 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1221
1222 Fix previous change: the library cache is defined in w32.c.
1223 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1224 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1225
1226 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1227
1228 Implement dynamic loading of GnuTLS on Windows.
1229
1230 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1231 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1232 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1233 Declare.
1234
1235 * gnutls.c (Qgnutls_dll): Define.
1236 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1237 (gnutls_*): Declare function pointers.
1238 (init_gnutls_functions): New function to initialize function pointers.
1239 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1240 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1241 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1242 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1243 (emacs_gnutls_write, emacs_gnutls_read)
1244 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1245 (Fgnutls_available_p): New function.
1246 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1247 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1248 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1249
1250 * image.c: Include w32.h.
1251 (Vimage_type_cache): Delete.
1252 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1253 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1254 (w32_delayed_load): Move to w32.c.
1255
1256 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1257
1258 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1259 (w32_delayed_load): Move from image.c. When loading a library, record
1260 its filename in the :loaded-from property of the library id.
1261 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1262 Initialize and staticpro them.
1263 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1264
1265 * process.c: Include lisp.h before w32.h, not after.
1266 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1267 instead of gnutls_record_check_pending.
1268
1269 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1270
1271 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1272
1273 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1274 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1275 as passed in.
1276
1277 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1278
1279 * xterm.c (x_set_frame_alpha): Do not set property on anything
1280 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1281
1282 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1285
1286 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1287
1288 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1289 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1290 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1291 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1292 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1293 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1294 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1295 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1296 (Qgnutls_bootprop_callbacks_verify): Make static.
1297
1298 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1299
1300 * callproc.c: Indentation fixup.
1301
1302 * sysdep.c (wait_for_termination_1): Make static.
1303 (wait_for_termination, interruptible_wait_for_termination):
1304 Move after wait_for_termination_1.
1305
1306 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1307
1308 * sysdep.c (interruptible_wait_for_termination): New function
1309 which is like wait_for_termination, but allows keyboard
1310 interruptions.
1311
1312 * callproc.c (Fcall_process): Add (:file "file") as an option for
1313 the STDOUT buffer.
1314 (Fcall_process_region): Ditto.
1315
1316 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1317
1318 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1319 rather than `XVECTOR (FOO)->size'.
1320
1321 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1322 inttypes.h, as a gnulib replacement is used if it not available in
1323 system headers.
1324
1325 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1326
1327 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1328 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1329 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1330
1331 * coding.c (coding_alloc_by_realloc): Error out if destination
1332 will grow beyond MOST_POSITIVE_FIXNUM.
1333 (decode_coding_emacs_mule): Abort if there isn't enough place in
1334 charbuf for the composition carryover bytes. Reserve an extra
1335 space for up to 2 characters produced in a loop.
1336 (decode_coding_iso_2022): Abort if there isn't enough place in
1337 charbuf for the composition carryover bytes.
1338
1339 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1340
1341 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1342 aborting when %lld or %lll format is passed.
1343 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1344 %llo or %llx format is passed. (Bug#8545)
1345
1346 * window.c (window_scroll_line_based): Use a marker instead of
1347 simple variables to record original value of point. (Bug#7952)
1348
1349 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1350 produced by %s or %c overflows available buffer space. (Bug#8545)
1351
1352 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1355 (SIZE_MAX): Move defn after all includes, as they might #define it.
1356
1357 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1360
1361 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * keyboard.c (Qdelayed_warnings_hook): Define.
1364 (command_loop_1): Run `delayed-warnings-hook'
1365 if Vdelayed_warnings_list is non-nil.
1366 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1367 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1368
1369 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1370
1371 * doprnt.c (doprnt): Don't return value smaller than the buffer
1372 size if the message was truncated. (Bug#8545).
1373
1374 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1375
1376 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1377 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1378
1379 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1382
1383 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * makefile.w32-in: Update dependencies.
1386
1387 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1388
1389 Improve `doprnt' and its usage. (Bug#8545)
1390 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1391 `format_end'. Remove support for %l as a conversion specifier.
1392 Don't use xrealloc. Improve diagnostics when the %l size modifier
1393 is used. Update the commentary.
1394
1395 * eval.c (verror): Simplify calculation of size_t.
1396
1397 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1398 messages.
1399
1400 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1401
1402 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1403 change.
1404
1405 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1408 This makes this file independent of the recent pseudovector change.
1409
1410 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1413
1414 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1415 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1416 Remove unused local.
1417 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1418
1419 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1420 GCC 4.6.0 optimizes based on type-based alias analysis.
1421 For example, if b is of type struct buffer * and v of type struct
1422 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1423 != &v->size, and therefore "v->size = 1; b->size = 2; return
1424 v->size;" must therefore return 1. This assumption is incorrect
1425 for Emacs, since it type-puns struct Lisp_Vector * with many other
1426 types. To fix this problem, this patch adds a new type struct
1427 vectorlike_header that documents the constraints on layout of vectors
1428 and pseudovectors, and helps optimizing compilers not get fooled
1429 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1430 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1431 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1432 the size member.
1433 (XSETPVECTYPE): Rewrite in terms of new macro.
1434 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1435 This is a bit clearer, and further avoids the possibility of
1436 undesirable aliasing.
1437 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1438 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1439 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1440 since Lisp_Subr is a special case (no "next" field).
1441 (ASIZE): Now uses header.size rather than size.
1442 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1443 to avoid the hassle of writing XVECTOR (foo)->header.size.
1444 (struct vectorlike_header): New type.
1445 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1446 object, to help avoid aliasing.
1447 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1448 (SUBRP): Likewise, since Lisp_Subr is a special case.
1449 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1450 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1451 (struct Lisp_Hash_Table): Combine first two members into a single
1452 struct vectorlike_header member. All uses of "size" and "next" members
1453 changed to be "header.size" and "header.next".
1454 * buffer.h (struct buffer): Likewise.
1455 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1456 * frame.h (struct frame): Likewise.
1457 * process.h (struct Lisp_Process): Likewise.
1458 * termhooks.h (struct terminal): Likewise.
1459 * window.c (struct save_window_data, struct saved_window): Likewise.
1460 * window.h (struct window): Likewise.
1461 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1462 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1463 * buffer.c (init_buffer_once): Likewise.
1464 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1465 special case.
1466 * process.c (Fformat_network_address): Use local var for size,
1467 for brevity.
1468
1469 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1470
1471 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1472 * data.c (atof): Remove decl; no longer used or needed.
1473 (digit_to_number): Move to lread.c.
1474 (Fstring_to_number): Use new string_to_number function, to be
1475 consistent with how the Lisp reader treats infinities and NaNs.
1476 Do not assume that floating-point numbers represent EMACS_INT
1477 without losing information; this is not true on most 64-bit hosts.
1478 Avoid double-rounding errors, by insisting on integers when
1479 parsing non-base-10 numbers, as the documentation specifies.
1480 * lisp.h (string_to_number): New decl, replacing ...
1481 (isfloat_string): Remove.
1482 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1483 (read1): Do not accept +. and -. as integers; this
1484 appears to have been a coding error. Similarly, do not accept
1485 strings like +-1e0 as floating point numbers. Do not report
1486 overflow for integer overflows unless the base is not 10 which
1487 means we have no simple and reliable way to continue.
1488 Break out the floating-point parsing into a new
1489 function string_to_number, so that Fstring_to_number parses
1490 floating point numbers consistently with the Lisp reader.
1491 (digit_to_number): Move here from data.c. Make it static inline.
1492 (E_CHAR, EXP_INT): Remove, replacing with ...
1493 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1494 (string_to_number): New function, replacing isfloat_string.
1495 This function checks for valid syntax and produces the resulting
1496 Lisp float number too. Rework it so that string-to-number
1497 no longer mishandles examples like "1.0e+". Use strtoumax,
1498 so that overflow for non-base-10 numbers is reported only when
1499 there's no portable and simple way to convert to floating point.
1500
1501 * textprop.c (set_text_properties_1): Rewrite for clarity,
1502 and to avoid GCC warning about integer overflow.
1503
1504 * intervals.h (struct interval): Use EMACS_INT for members
1505 where EMACS_UINT might cause problems. See
1506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1507 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1508 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1509 All uses changed.
1510 (offset_intervals): Tell GCC not to worry about length overflow
1511 when negating a negative length.
1512
1513 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1514 (overrun_check_free): Likewise.
1515
1516 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1517 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1518 word size.
1519
1520 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1521 (gnutls_make_error): Rename local to avoid shadowing.
1522 (gnutls_emacs_global_deinit): ifdef out; not used.
1523 (Fgnutls_boot): Use const for pointer to readonly storage.
1524 Comment out unused local. Fix pointer signedness problems.
1525
1526 * lread.c (openp): Don't stuff size_t into an 'int'.
1527 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1528 about possible signed overflow.
1529
1530 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1531 (GDK_KEY_g): Don't define if already defined.
1532 (xg_prepare_tooltip): Avoid pointer signedness problem.
1533 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1534
1535 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1536 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1537
1538 * xfns.c (Fx_window_property): Simplify a bit,
1539 to make a bit faster and to avoid GCC 4.6.0 warning.
1540 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1541
1542 * fns.c (internal_equal): Don't assume size_t fits in int.
1543
1544 * alloc.c (compact_small_strings): Tighten assertion a little.
1545
1546 Replace pEd with more-general pI, and fix some printf arg casts.
1547 * lisp.h (pI): New macro, generalizing old pEd macro to other
1548 conversion specifiers. For example, use "...%"pI"d..." rather
1549 than "...%"pEd"...".
1550 (pEd): Remove. All uses replaced with similar uses of pI.
1551 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1552 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1553 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1554 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1555 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1556 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1557 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1558 64-bit hosts.
1559 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1560 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1561 * print.c (safe_debug_print, print_object): Likewise.
1562 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1563 to int.
1564 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1565 avoiding the 0 flag, which is not portable.
1566 * process.c (Fmake_network_process): Use pI to avoid cast.
1567 * region-cache.c (pp_cache): Likewise.
1568 * xdisp.c (decode_mode_spec): Likewise.
1569 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1570 behavior on 64-bit hosts with printf arg.
1571 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1572 (x_stop_queuing_selection_requests): Likewise.
1573 (x_get_window_property): Don't truncate byte count to an 'int'
1574 when tracing.
1575
1576 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1577 here, since it parses constructs like leading '-' and spaces,
1578 which are not wanted; and it overflows with large numbers.
1579 Instead, simply match F[0-9]+, which is what is wanted anyway.
1580
1581 * alloc.c: Remove unportable assumptions about struct layout.
1582 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1583 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1584 (allocate_vectorlike, make_pure_vector): Use the new macros,
1585 plus offsetof, to remove unportable assumptions about struct layout.
1586 These assumptions hold on all porting targets that I know of, but
1587 they are not guaranteed, they're easy to remove, and removing them
1588 makes further changes easier.
1589
1590 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1591 This doesn't fix a bug but makes the code clearer.
1592 (string_overrun_cookie): Now const. Use initializers that
1593 don't formally overflow signed char, to avoid warnings.
1594 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1595 can cause Emacs to crash when string overrun checking is enabled.
1596 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1597 multiple of sizeof (EMACS_INT); it need not be, if
1598 alignof(EMACS_INT) < sizeof (EMACS_INT).
1599 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1600
1601 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1604
1605 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1606
1607 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1608 supposed to be handshaking. (Bug#8556)
1609 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1610
1611 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1612
1613 * lisp.h (Qdebug): List symbol.
1614 * eval.c (Qdebug): Restore global linkage.
1615 * keyboard.c (debug-on-event): New variable.
1616 (handle_user_signal): Break into debugger when debug-on-event
1617 matches the current signal symbol.
1618
1619 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1620
1621 * alloc.c (check_sblock, check_string_bytes)
1622 (check_string_free_list): Convert to standard C.
1623
1624 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1625
1626 * w32.c (emacs_gnutls_push): Fix typo.
1627
1628 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1629
1630 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1631 "cast to pointer from integer of different size".
1632
1633 Improve doprnt and its use in verror. (Bug#8545)
1634 * doprnt.c (doprnt): Document the set of format control sequences
1635 supported by the function. Use SAFE_ALLOCA instead of always
1636 using `alloca'.
1637
1638 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1639 is one byte too soon. Don't use xrealloc; instead xfree and
1640 xmalloc anew.
1641
1642 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1643
1644 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1645 callbacks stage.
1646
1647 * gnutls.c: Renamed global_initialized to
1648 gnutls_global_initialized. Added internals for the
1649 :verify-hostname-error, :verify-error, and :verify-flags
1650 parameters of `gnutls-boot' and documented those parameters in the
1651 docstring. Start callback support.
1652 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1653 unless a fatal error occured. Call gnutls_alert_send_appropriate
1654 on error. Return error code.
1655 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1656 (emacs_gnutls_read): Likewise.
1657 (Fgnutls_boot): Return handshake error code.
1658 (emacs_gnutls_handle_error): New function.
1659 (wsaerror_to_errno): Likewise.
1660
1661 * w32.h (emacs_gnutls_pull): Add prototype.
1662 (emacs_gnutls_push): Likewise.
1663
1664 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1665 (emacs_gnutls_push): Likewise.
1666
1667 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1668
1669 * process.c (wait_reading_process_output): Check if GnuTLS
1670 buffered some data internally if no FDs are set for TLS
1671 connections.
1672
1673 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1674 (LIBS): Link to USER_LIBS.
1675 ($(BLD)/gnutls.$(0)): New target.
1676
1677 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (handle_single_display_spec): Rename the
1680 display_replaced_before_p argument into display_replaced_p, to
1681 make it consistent with the commentary. Fix typos in the
1682 commentary.
1683
1684 * textprop.c (syms_of_textprop): Remove dead code.
1685 (copy_text_properties): Delete obsolete commentary about an
1686 interface that was deleted long ago. Fix typos in the description
1687 of arguments.
1688
1689 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1690 to changes in oldXMenu/XMenu.h from 2011-04-16.
1691 <menu_help_message, prev_menu_help_message>: Constify.
1692 (IT_menu_make_room): menu->help_text is now `const char **';
1693 adjust.
1694
1695 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1696 to changes in oldXMenu/XMenu.h from 2011-04-16.
1697 (struct XMenu): Declare `help_text' `const char **'.
1698
1699 * xfaces.c <Qunspecified>: Make extern again.
1700
1701 * syntax.c: Include sys/types.h before including regex.h, as
1702 required by Posix.
1703
1704 * doc.c (get_doc_string): Improve the format passed to `error'.
1705
1706 * doprnt.c (doprnt): Improve commentary.
1707
1708 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1709
1710 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1711 them with etags.
1712
1713 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1714 changes in globals.h immediately force recompilation.
1715 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1716 $(CURDIR)/s/ms-w32.h.
1717 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1718
1719 * character.c (Fchar_direction): Function deleted.
1720 (syms_of_character): Don't defsubr it.
1721 <char-direction-table>: Deleted.
1722
1723 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1724
1725 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1726 * doprnt.c: Include limits.h.
1727 (SIZE_MAX): New macro.
1728 (doprnt): Return a size_t value. 2nd arg is now size_t.
1729 Many local variables are now size_t instead of int or unsigned.
1730 Improve overflow protection. Support `l' modifier for integer
1731 conversions. Support %l conversion. Don't assume an EMACS_INT
1732 argument for integer conversions and for %c.
1733
1734 * lisp.h (doprnt): Restore prototype.
1735
1736 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1737 $(SRC)/character.h.
1738
1739 * Makefile.in (base_obj): Add back doprnt.o.
1740
1741 * deps.mk (doprnt.o): Add back prerequisites.
1742 (callint.o): Depend on character.h.
1743
1744 * eval.c (internal_lisp_condition_case): Include the handler
1745 representation in the error message.
1746 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1747 when breaking from the loop.
1748
1749 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1750
1751 * callint.c (Fcall_interactively): When displaying error message
1752 about invalid control letter, pass the character's codepoint, not
1753 a pointer to its multibyte form. Improve display of the character
1754 in octal and display also its hex code.
1755
1756 * character.c (char_string): Use %x to display the (unsigned)
1757 codepoint of an invalid character, to avoid displaying a bogus
1758 negative value.
1759
1760 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1761 `error', not SYMBOL_NAME itself.
1762
1763 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1764 character arguments to `error'.
1765
1766 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1767 to `error' in error message about FINAL_CHAR argument. Make sure
1768 FINAL_CHAR is a character, and use %c when it is passed as
1769 argument to `error'.
1770
1771 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1772
1773 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1774
1775 * w32.c: Include <time.h>.
1776 (sys_localtime): New function.
1777
1778 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1779
1780 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1781
1782 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1783
1784 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1785
1786 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1787 zombies (Bug#8467).
1788
1789 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1790
1791 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1792 gl_state.e_property when gl_state.object is Qt.
1793
1794 * insdel.c (make_gap_larger): Remove limitation of buffer size
1795 to <= INT_MAX.
1796
1797 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1798
1799 * xdisp.c (lookup_glyphless_char_display)
1800 (produce_glyphless_glyph): Handle cons cell entry in
1801 glyphless-char-display.
1802 (Vglyphless_char_display): Document it.
1803
1804 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1805 glyphless-char-display.
1806
1807 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1808
1809 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1810
1811 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1812
1813 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1814 definition for no-X builds.
1815
1816 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 Static checks with GCC 4.6.0 and non-default toolkits.
1819
1820 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1821
1822 * process.c (keyboard_bit_set): Define only if SIGIO.
1823 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1824 (send_process): Repair possible setjmp clobbering.
1825
1826 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1827
1828 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1829
1830 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1831
1832 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1833 Define only if needed.
1834
1835 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1836 by pacifying GCC about it. Maybe it's time to retire it?
1837 * xfaces.c (USG, __TIMEVAL__): Likewise.
1838
1839 * dispextern.h (struct redisplay_interface): Rename param
1840 to avoid shadowing.
1841 * termhooks.h (struct terminal): Likewise.
1842 * xterm.c (xembed_send_message): Likewise.
1843
1844 * insdel.c (make_gap_smaller): Define only if
1845 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1846
1847 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1848 it.
1849
1850 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1851 so that we aren't warned about unused symbols.
1852
1853 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1854
1855 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1856
1857 * xfns.c (x_real_positions): Mark locals as initialized.
1858
1859 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1860
1861 * xterm.c: Fix problems found by static analysis with other toolkits.
1862 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1863 (x_dispatch_event): Declare static if USE_GTK, and
1864 define if USE_GTK || USE_X_TOOLKIT.
1865 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1866 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1867 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1868 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1869
1870 * xmenu.c (menu_help_callback): Pointer type fixes.
1871 Use const pointers when pointing at readonly data. Avoid pointer
1872 signedness clashes.
1873 (FALSE): Remove unused macro.
1874 (update_frame_menubar): Remove unused decl.
1875
1876 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1877
1878 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1879 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1880 (single_menu_item): Rename local to avoid shadowing.
1881
1882 * keyboard.c (make_lispy_event): Remove unused local var.
1883
1884 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1885 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1886
1887 * bitmaps: Change bitmaps from unsigned char back to the X11
1888 compatible char. Avoid the old compiler warnings about
1889 out-of-range initializers by using, for example, '\xab' rather
1890 than 0xab.
1891
1892 * xgselect.c (xgselect_initialize): Check vs interface
1893 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1894
1895 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1896
1897 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1898 to read-only memory.
1899
1900 * fns.c (vector): Remove; this old hack is no longer needed.
1901
1902 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1903 Remove unused var.
1904 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1905
1906 * xrdb.c (x_load_resources): Omit unused local.
1907
1908 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1909 (x_window): Rename locals to avoid shadowing.
1910 (USG): Use the kludged USG macro, to pacify gcc.
1911
1912 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1913 (x_term_init): Remove local to avoid shadowing.
1914
1915 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1916
1917 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1918 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1919
1920 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1921
1922 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1923
1924 Fix regex.c, syntax.c and friends for buffers > 2GB.
1925 * syntax.h (struct gl_state_s): Declare character position members
1926 EMACS_INT.
1927
1928 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1929
1930 * textprop.c (verify_interval_modification, interval_of):
1931 Declare arguments EMACS_INT.
1932
1933 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1934 EMACS_INT.
1935
1936 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1937
1938 * indent.c (Fvertical_motion): Local variable it_start is now
1939 EMACS_INT.
1940
1941 * regex.c (re_match, re_match_2, re_match_2_internal)
1942 (bcmp_translate, regcomp, regexec, print_double_string)
1943 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1944 (re_compile_pattern, re_exec): Declare arguments and local
1945 variables `size_t' and `ssize_t' and return values `regoff_t', as
1946 appropriate.
1947 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1948 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1949 <compile_stack_type>: `size' and `avail' are now `size_t'.
1950
1951 * regex.h <regoff_t>: Use ssize_t, not int.
1952 (re_search, re_search_2, re_match, re_match_2): Arguments that
1953 specify buffer/string position and length are now ssize_t and
1954 size_t. Return type is regoff_t.
1955
1956 2011-04-16 Ben Key <bkey76@gmail.com>
1957
1958 * nsfont.m: Fixed bugs in ns_get_family and
1959 ns_descriptor_to_entity that were caused by using free to
1960 deallocate memory blocks that were allocated by xmalloc (via
1961 xstrdup). This caused Emacs to crash when compiled with
1962 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1963 --enable-checking=xmallocoverrun). xfree is now used to
1964 deallocate these memory blocks.
1965
1966 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1969
1970 emacs_write: Accept and return EMACS_INT for sizes.
1971 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1972 et seq.
1973 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1974 Accept and return EMACS_INT.
1975 (emacs_gnutls_write): Return the number of bytes written on
1976 partial writes.
1977 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1978 (emacs_read, emacs_write): Remove check for negative size, as the
1979 Emacs source code has been audited now.
1980 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1981 (emacs_read, emacs_write): Use it.
1982 * process.c (send_process): Adjust to the new signatures of
1983 emacs_write and emacs_gnutls_write. Do not attempt to store
1984 a byte offset into an 'int'; it might overflow.
1985 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1986
1987 * sound.c: Don't assume sizes fit in 'int'.
1988 (struct sound_device.period_size, alsa_period_size):
1989 Return EMACS_INT, not int.
1990 (struct sound_device.write, vox_write, alsa_write):
1991 Accept EMACS_INT, not int.
1992 (wav_play, au_play): Use EMACS_INT to store sizes and to
1993 record read return values.
1994
1995 2011-04-15 Ben Key <bkey76@gmail.com>
1996
1997 * keyboard.c (Qundefined): Don't declare static since it is used
1998 in nsfns.m.
1999 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2000 static since they are used in nsfont.m.
2001
2002 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * process.c (Qprocessp): Don't declare static.
2005 * lisp.h (Qprocessp): Declare again.
2006
2007 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2010
2011 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 Improve C-level modularity by making more things 'static'.
2014
2015 Don't publish debugger-only interfaces to other modules.
2016 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2017 (verify_bytepos, count_markers): Move decls to the only modules
2018 that need them.
2019 * region-cache.h (pp_cache): Likewise.
2020 * window.h (check_all_windows): Likewise.
2021 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2022
2023 * sysdep.c (croak): Now static, if
2024 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2025 * syssignal.h (croak): Declare only if not static.
2026
2027 * alloc.c (refill_memory_reserve): Now static if
2028 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2029 * lisp.h (refill_memory_reserve): Declare only if not static.
2030
2031 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2032 Define only if USE_LUCID.
2033
2034 * xrdb.c (x_customization_string, x_rm_string): Now static.
2035
2036 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2037 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2038
2039 * xdisp.c (draw_row_with_mouse_face): Now static.
2040 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2041
2042 * window.h (check_all_windows): Mark externally visible.
2043
2044 * window.c (window_deletion_count): Now static.
2045
2046 * undo.c: Make symbols static if they're not exported.
2047 (last_undo_buffer, last_boundary_position, pending_boundary):
2048 Now static.
2049
2050 * textprop.c (interval_insert_behind_hooks): Now static.
2051 (interval_insert_in_front_hooks): Likewise.
2052
2053 * term.c: Make symbols static if they're not exported.
2054 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2055 (max_frame_lines, tty_set_terminal_modes):
2056 (tty_reset_terminal_modes, tty_turn_off_highlight):
2057 (get_tty_terminal): Now static.
2058 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2059 * termhooks.h (term_mouse_moveto): Do not declare if
2060 HAVE_WINDOW_SYSTEM.
2061 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2062 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2063
2064 * sysdep.c: Make symbols static if they're not exported.
2065 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2066 Now static.
2067 (sigprocmask_set, full_mask): Remove; unused.
2068 (wait_debugging): Mark as visible.
2069 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2070 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2071
2072 * syntax.c (syntax_temp): Define only if !__GNUC__.
2073
2074 * sound.c (current_sound_device, current_sound): Now static.
2075
2076 * search.c (searchbufs, searchbuf_head): Now static.
2077
2078 * scroll.c (scroll_cost): Remove; unused.
2079 * dispextern.h (scroll_cost): Remove decl.
2080
2081 * region-cache.h (pp_cache): Mark as externally visible.
2082
2083 * process.c: Make symbols static if they're not exported.
2084 (process_tick, update_tick, create_process, chan_process):
2085 (Vprocess_alist, proc_buffered_char, datagram_access):
2086 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2087 (deactivate_process): Mark defn as static, as well as decl.
2088 * lisp.h (create_process): Remove decl.
2089 * process.h (chan_process, Vprocess_alist): Remove decls.
2090
2091 * print.c: Make symbols static if they're not exported.
2092 (print_depth, new_backquote_output, being_printed, print_buffer):
2093 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2094 (print_interval, print_number_index, initial_stderr_stream):
2095 Now static.
2096 * lisp.h (Fprinc): Remove decl.
2097 (debug_output_compilation_hack): Mark as externally visible.
2098
2099 * sysdep.c (croak): Move decl from here to syssignal.h.
2100 * syssignal.h (croak): Put it here, so the API can be checked when
2101 'croak' is called from dissociate_if_controlling_tty.
2102
2103 * minibuf.c: Make symbols static if they're not exported.
2104 (minibuf_save_list, choose_minibuf_frame): Now static.
2105 * lisp.h (choose_minibuf_frame): Remove decl.
2106
2107 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2108
2109 * lread.c: Make symbols static if they're not exported.
2110 (read_objects, initial_obarray, oblookup_last_bucket_number):
2111 Now static.
2112 (make_symbol): Remove; unused.
2113 * lisp.h (initial_obarray, make_symbol): Remove decls.
2114
2115 * keyboard.c: Make symbols static if they're not exported.
2116 (single_kboard, recent_keys_index, total_keys, recent_keys):
2117 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2118 (this_single_command_key_start, echoing, last_auto_save):
2119 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2120 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2121 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2122 (Vlispy_mouse_stem, double_click_count):
2123 Now static.
2124 (force_auto_save_soon): Define only if SIGDANGER.
2125 (ignore_mouse_drag_p): Now static if
2126 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2127 (print_help): Remove; unused.
2128 (stop_character, last_timer_event): Mark as externally visible.
2129 * keyboard.h (ignore_mouse_drag_p): Declare only if
2130 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2131 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2132 * lisp.h (echoing): Remove decl.
2133 (force_auto_save_soon): Declare only if SIGDANGER.
2134 * xdisp.c (redisplay_window): Simplify code, to make it more
2135 obvious that ignore_mouse_drag_p is not accessed if !defined
2136 USE_GTK && !defined HAVE_NS.
2137
2138 * intervals.c: Make symbols static if they're not exported.
2139 (merge_properties_sticky, merge_interval_right, delete_interval):
2140 Now static.
2141 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2142
2143 * insdel.c: Make symbols static if they're not exported.
2144 However, leave prepare_to_modify_buffer alone. It's never
2145 called from outside this function, but that appears to be a bug.
2146 (combine_after_change_list, combine_after_change_buffer):
2147 (adjust_after_replace, signal_before_change): Now static.
2148 (adjust_after_replace_noundo): Remove; unused.
2149 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2150 (signal_before_change): Remove decls.
2151
2152 * indent.c (val_compute_motion, val_vmotion): Now static.
2153
2154 * image.c: Make symbols static if they're not exported.
2155 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2156 if USE_GTK.
2157 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2158 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2159
2160 * fringe.c (standard_bitmaps): Now static.
2161 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2162
2163 * frame.c: Make symbols static if they're not exported.
2164 (x_report_frame_params, make_terminal_frame): Now static.
2165 (get_frame_param): Now static, unless HAVE_NS.
2166 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2167 (x_get_resource_string): Remove; not used.
2168 * frame.h (make_terminal_frame, x_report_frame_params):
2169 (x_get_resource_string); Remove decls.
2170 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2171 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2172
2173 * font.c, fontset.c: Make symbols static if they're not exported.
2174 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2175 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2176 * font.c (font_close_object): Now static.
2177 * font.h (font_close_object): Remove.
2178 * fontset.c (FONTSET_OBJLIST): Remove.
2179 (free_realized_fontset) #if-0 the body, which does nothing.
2180 (face_suitable_for_char_p): #if-0, as it's never called.
2181 * fontset.h (face_suitable_for_char_p): Remove decl.
2182 * xfaces.c (face_at_string_position):
2183 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2184 since 0 is always ASCII.
2185
2186 * fns.c (weak_hash_tables): Now static.
2187
2188 * fileio.c: Make symbols static if they're not exported.
2189 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2190 (Vwrite_region_annotation_buffers): Now static.
2191
2192 * eval.c: Make symbols static if they're not exported.
2193 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2194 * lisp.h (backtrace_list): Remove decl.
2195
2196 * emacs.c: Make symbols static if they're not exported.
2197 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2198 (fatal_error_code, fatal_error_signal_hook, standard_args):
2199 Now static.
2200 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2201 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2202 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2203 * lisp.h (fatal_error_signal_hook): Remove decl.
2204 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2205
2206 * editfns.c: Move a (normally-unused) function to its only use.
2207 * editfns.c, lisp.h (get_operating_system_release): Remove.
2208 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2209 worth the hassle of breaking this out.
2210
2211 * xterm.c: Make symbols static if they're not exported.
2212 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2213 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2214 (x_destroy_window, x_delete_display):
2215 Now static.
2216 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2217 (x_mouse_leave): Remove; unused.
2218 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2219 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2220 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2221 Remove decls.
2222 (x_mouse_leave): Declare only if WINDOWSNT.
2223 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2224 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2225 USE_X_TOOLKIT.
2226
2227 * ftxfont.c: Make symbols static if they're not exported.
2228 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2229 HAVE_FREETYPE.
2230 * font.h (ftxfont_driver): Likewise.
2231
2232 * xfns.c: Make symbols static if they're not exported.
2233 (x_last_font_name, x_display_info_for_name):
2234 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2235 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2236 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2237 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2238 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2239 (last_show_tip_args): Now static.
2240 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2241 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2242 (x_screen_planes): Remove; unused.
2243 * dispextern.h (x_screen_planes): Remove decl.
2244
2245 * dispnew.c: Make symbols static if they're not exported.
2246 * dispextern.h (redraw_garbaged_frames, scrolling):
2247 (increment_row_positions): Remove.
2248 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2249 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2250 Now static.
2251 (redraw_garbaged_frames): Remove; unused.
2252
2253 * xfaces.c: Make symbols static if they're not exported.
2254 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2255 Remove decls.
2256 * xterm.h (defined_color): Remove decls.
2257 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2258 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2259 (menu_face_changed_default, defined_color, free_realized_face):
2260 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2261 (ascii_face_of_lisp_face): Remove; unused.
2262
2263 * xdisp.c: Make symbols static if they're not exported.
2264 * dispextern.h (scratch_glyph_row, window_box_edges):
2265 (glyph_to_pixel_coords, set_cursor_from_row):
2266 (get_next_display_element, set_iterator_to_next):
2267 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2268 (show_mouse_face): Remove decls
2269 * frame.h (message_buf_print): Likewise.
2270 * lisp.h (pop_message, set_message, check_point_in_composition):
2271 Likewise.
2272 * xterm.h (set_vertical_scroll_bar): Likewise.
2273 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2274 (message_buf_print, scratch_glyph_row, displayed_buffer):
2275 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2276 (get_next_display_element, show_mouse_face, window_box_edges):
2277 (frame_to_window_pixel_xy, check_point_in_composition):
2278 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2279 (glyph_to_pixel_coords): Remove; unused.
2280
2281 * dired.c (file_name_completion): Now static.
2282
2283 * dbusbind.c (xd_in_read_queued_messages): Now static.
2284
2285 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2286 * data.c (circular_list_error): Remove.
2287
2288 * commands.h (last_point_position, last_point_position_buffer):
2289 (last_point_position_window): Remove decls.
2290 * keyboard.c: Make these variables static.
2291
2292 * coding.h (coding, code_convert_region, encode_coding_gap):
2293 Remove decls.
2294 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2295 (iso_code_class, detect_coding, code_convert_region): Now static.
2296 (encode_coding_gap): Remove; unused.
2297
2298 * chartab.c (chartab_chars, chartab_bits): Now static.
2299
2300 * charset.h (charset_iso_8859_1): Remove decl.
2301 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2302 Now static.
2303
2304 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2305 * ccl.c (Vccl_program_table): Now static.
2306 (check_ccl_update): Remove; unused.
2307
2308 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2309 * category.h: ... from here.
2310 * category.c (check_category_table, set_category_set): Now static.
2311
2312 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2313 * lisp.h: Remove these decls.
2314
2315 * buffer.c (buffer_count): Remove unused var.
2316
2317 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2318 so that it's not optimized away.
2319 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2320 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2321 exported only to the debugger.
2322
2323 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2324 * atimer.h (run_all_atimers): Remove; not exported.
2325
2326 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2327 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2328 was inaccessible from Lisp.
2329 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2330 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2331
2332 alloc.c: Import and export fewer symbols, and remove unused items.
2333 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2334 is defined.
2335 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2336 it's not optimized away by whole-program optimization.
2337 (message_enable_multibyte, free_misc): Remove.
2338 (catchlist, handlerlist, mark_backtrace):
2339 Declare only if BYTE_MARK_STACK.
2340 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2341 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2342 (message_enable_multibyte): Remove decl.
2343 (free_misc, interval_free_list, float_block, float_block_index):
2344 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2345 (cons_free_list, last_marked_index):
2346 Now static.
2347 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2348 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2349 (mark_backtrace): Define only if BYTE_MARK_STACK.
2350 * xdisp.c (message_enable_multibyte): Now static.
2351
2352 Declare Lisp_Object Q* variables to be 'static' if not exported.
2353 This makes it easier for human readers (and static analyzers)
2354 to see whether these variables are used from other modules.
2355 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2356 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2357 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2358 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2359 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2360 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2361 * xmenu.c, xselect.c:
2362 Declare Q* vars static if they are not used in other modules.
2363 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2364 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2365 Remove decls of unexported vars.
2366 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2367
2368 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2369
2370 Make Emacs functions such as Fatom 'static' by default.
2371 This makes it easier for human readers (and static analyzers)
2372 to see whether these functions can be called from other modules.
2373 DEFUN now defines a static function. To make the function external
2374 so that it can be used in other C modules, use the new macro DEFUE.
2375 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2376 (Finit_image_library):
2377 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2378 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2379 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2380 Remove decls, since these functions are now static.
2381 (Funintern, Fget_internal_run_time): New decls, since these functions
2382 were already external.
2383
2384 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2385 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2386 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2387 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2388 * keyboard.c, keymap.c, lread.c:
2389 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2390 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2391 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2392 Mark functions with DEFUE instead of DEFUN,
2393 if they are used in other modules.
2394 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2395 decls for now-static functions.
2396 * buffer.h (Fdelete_overlay): Remove decl.
2397 * callproc.c (Fgetenv_internal): Mark as internal.
2398 * composite.c (Fremove_list_of_text_properties): Remove decl.
2399 (Fcomposition_get_gstring): New forward static decl.
2400 * composite.h (Fcomposite_get_gstring): Remove decl.
2401 * dired.c (Ffile_attributes): New forward static decl.
2402 * doc.c (Fdocumntation_property): New forward static decl.
2403 * eval.c (Ffetch_bytecode): New forward static decl.
2404 (Funintern): Remove extern decl; now in .h file where it belongs.
2405 * fileio.c (Fmake_symbolic_link): New forward static decl.
2406 * image.c (Finit_image_library): New forward static decl.
2407 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2408 * intervals.h (Fprevious_property_change):
2409 (Fremove_list_of_text_properties): Remove decls.
2410 * keyboard.c (Fthis_command_keys): Remove decl.
2411 (Fcommand_execute): New forward static decl.
2412 * keymap.c (Flookup_key): New forward static decl.
2413 (Fcopy_keymap): Now static.
2414 * keymap.h (Flookup_key): Remove decl.
2415 * process.c (Fget_process): New forward static decl.
2416 (Fprocess_datagram_address): Mark as internal.
2417 * syntax.c (Fsyntax_table_p): New forward static decl.
2418 (skip_chars): Remove duplicate decl.
2419 * textprop.c (Fprevious_property_change): New forward static decl.
2420 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2421 Now internal.
2422 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2423 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2424
2425 * editfns.c (Fformat): Remove unreachable code.
2426
2427 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2428
2429 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2430 change. (Bug#8496)
2431
2432 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2433
2434 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2435 when at ZV. (Bug#8487)
2436
2437 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2438
2439 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2440 (Bug#8437)
2441 * keyboard.c (parse_tool_bar_item): Likewise.
2442 * sound.c (sound_cleanup, alsa_close): Likewise.
2443 * termcap.c (tgetent): Likewise.
2444 * xfns.c (x_default_font_parameter): Likewise.
2445 * xsettings.c (read_and_apply_settings): Likewise.
2446
2447 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2448 (overrun_check_free): Protoize.
2449
2450 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2453 since callers should never pass a negative size.
2454 Change the signature to match that of plain 'read' and 'write'; see
2455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2456 * lisp.h: Update prototypes of emacs_write and emacs_read.
2457
2458 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2459
2460 * xdisp.c (redisplay_window): Don't try to determine the character
2461 position of the scroll margin if the window start point w->startp
2462 is outside the buffer's accessible region. (Bug#8468)
2463
2464 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2465
2466 Fix write-region and its subroutines for buffers > 2GB.
2467 * fileio.c (a_write, e_write): Modify declaration of arguments and
2468 local variables to support buffers larger than 2GB.
2469 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2470
2471 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2472 argument, local variables, and return value.
2473
2474 * lisp.h: Update prototypes of emacs_write and emacs_read.
2475
2476 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2477
2478 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2481
2482 Fix more problems found by GCC 4.6.0's static checks.
2483
2484 * xdisp.c (vmessage): Use a better test for character truncation.
2485
2486 * charset.c (load_charset_map): <, not <=, for optimization,
2487 and to avoid potential problems with integer overflow.
2488 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2489 * casetab.c (set_identity, shuffle): Likewise.
2490 * editfns.c (Fformat): Likewise.
2491 * syntax.c (skip_chars): Likewise.
2492
2493 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2494 This also lets GCC 4.6.0 generate slightly better loop code.
2495
2496 * callint.c (Fcall_interactively): <, not <=, for optimization.
2497 (Fcall_interactively): Count the number of arguments produced,
2498 not the number of arguments given. This is simpler and lets GCC
2499 4.6.0 generate slightly better code.
2500
2501 * ftfont.c: Distingish more carefully between FcChar8 and char.
2502 The previous code passed unsigned char * to a functions like
2503 strlen and xstrcasecmp that expect char *, which does not
2504 conform to the C standard.
2505 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2506 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2507 char * when the C standard requires it.
2508
2509 * keyboard.c (read_char): Remove unused var.
2510
2511 * eval.c: Port to Windows vsnprintf (Bug#8435).
2512 Include <limits.h>.
2513 (SIZE_MAX): Define if the headers do not.
2514 (verror): Do not give up if vsnprintf returns a negative count.
2515 Instead, grow the buffer. This ports to Windows vsnprintf, which
2516 does not conform to C99. Problem reported by Eli Zaretskii.
2517 Also, simplify the allocation scheme, by avoiding the need for
2518 calling realloc, and removing the ALLOCATED variable.
2519
2520 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2521
2522 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2523 But keep the doprint source code for now, as we might revamp it
2524 and use it again (Bug#8435).
2525 * lisp.h (doprnt): Remove.
2526 * Makefile.in (base_obj): Remove doprnt.o.
2527 * deps.mk (doprnt.o): Remove.
2528
2529 error: Print 32- and 64-bit integers portably (Bug#8435).
2530 Without this change, on typical 64-bit hosts error ("...%d...", N)
2531 was used to print both 32- and 64-bit integers N, which relied on
2532 undefined behavior.
2533 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2534 New macro.
2535 * lisp.h (error, verror): Mark as printf-like functions.
2536 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2537 Report overflow in size calculations when allocating printf buffer.
2538 Do not truncate output string at its first null byte.
2539 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2540 Truncate the output at a character boundary, since vsnprintf does not
2541 do that.
2542 * charset.c (check_iso_charset_parameter): Convert internal
2543 character to string before calling 'error', since %c now has the
2544 printf meaning.
2545 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2546 overflow when computing char to be passed to 'error'. Do not
2547 pass Lisp_Object to 'error'; pass the integer instead.
2548 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2549 formatted with plain %d.
2550
2551 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2552
2553 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2554
2555 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2556
2557 * xterm.c (x_catch_errors): Remove duplicate declaration.
2558
2559 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2560
2561 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2562
2563 2011-04-10 Jim Meyering <meyering@redhat.com>
2564
2565 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2566 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2567 return ssize_t not "int", and use size_t as the buffer length.
2568 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2569 * gnutls.h: Update declarations.
2570 * process.c (read_process_output): Use ssize_t, to match.
2571 (send_process): Likewise.
2572
2573 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2574
2575 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2576
2577 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2578
2579 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2580 Use unsigned char, to match FcChar8 type definition.
2581
2582 * xterm.c (handle_one_xevent):
2583 * xmenu.c (create_and_show_popup_menu):
2584 * xselect.c (x_decline_selection_request)
2585 (x_reply_selection_request): Avoid type-punned deref of X events.
2586
2587 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2588
2589 Fix some uses of `int' instead of EMACS_INT.
2590 * search.c (string_match_1, fast_string_match)
2591 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2592 (scan_buffer, find_next_newline_no_quit)
2593 (find_before_next_newline, search_command, Freplace_match)
2594 (Fmatch_data): Make some `int' variables be EMACS_INT.
2595
2596 * xdisp.c (display_count_lines): 3rd argument and return value now
2597 EMACS_INT. All callers changed.
2598 (pint2hrstr): Last argument is now EMACS_INT.
2599
2600 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2601 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2602 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2603 (decode_coding_utf_16, decode_coding_emacs_mule)
2604 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2605 (decode_coding_ccl, decode_coding_charset)
2606 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2607 (decode_coding_iso_2022, decode_coding_emacs_mule)
2608 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2609 <char_offset, last_offset>: Declare EMACS_INT.
2610 (encode_coding_utf_8, encode_coding_utf_16)
2611 (encode_coding_emacs_mule, encode_invocation_designation)
2612 (encode_designation_at_bol, encode_coding_iso_2022)
2613 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2614 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2615 Declare EMACS_INT.
2616 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2617 (encode_invocation_designation): Last argument P_NCHARS is now
2618 EMACS_INT.
2619 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2620 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2621
2622 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2623 All users changed.
2624
2625 * ccl.c (Fccl_execute_on_string): Declare some variables
2626 EMACS_INT.
2627
2628 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2629
2630 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2631
2632 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2633
2634 * process.c (Fformat_network_address): Doc fix.
2635
2636 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2637
2638 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2639
2640 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2641
2642 * keyboard.c (read_char): Call Lisp function help-form-show,
2643 instead of using internal_with_output_to_temp_buffer.
2644 (Qhelp_form_show): New var.
2645 (syms_of_keyboard): Use DEFSYM macro.
2646
2647 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2648
2649 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2650
2651 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * process.c (Flist_processes): Remove to Lisp.
2654 (list_processes_1): Delete.
2655
2656 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2657
2658 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2659
2660 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2661
2662 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Fix more problems found by GCC 4.6.0's static checks.
2665
2666 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2667
2668 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2669
2670 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2671
2672 * xdisp.c (vmessage): Mark as a printf-like function.
2673
2674 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2675
2676 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2677
2678 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2679 printf-like functions.
2680 (tiff_load): Add casts to remove these marks before passing them
2681 to system-supplied API.
2682
2683 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2684
2685 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2686 This avoids several warnings with gcc -Wstrict-overflow.
2687 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2688 directly, rather than having caller test rule sign. This avoids
2689 some unnecessary tests.
2690 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2691 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2692 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2693
2694 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2695 (xfont_open): Avoid unnecessary tests.
2696
2697 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2698
2699 * composite.h, composite.c (composition_gstring_put_cache):
2700 Use EMACS_INT, not int, for length.
2701
2702 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2703 breaking out part of COMPOSITION_DECODE_RULE.
2704 (COMPOSITION_DECODE_RULE): Use it.
2705 * composite.c (get_composition_id): Remove unused local vars,
2706 by using the new macro.
2707
2708 * textprop.c (set_text_properties_1): Change while to do-while,
2709 since the condition is always true at first.
2710
2711 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2712 (interval_deletion_adjustment): Return unsigned value.
2713 All uses changed.
2714
2715 * process.c (list_processes_1, create_pty, read_process_output):
2716 (exec_sentinel): Remove vars that were set but not used.
2717 (create_pty): Remove unnecessary "volatile"s.
2718 (Fnetwork_interface_info): Avoid possibility of int overflow.
2719 (read_process_output): Do adaptive read buffering even if carryover.
2720 (read_process_output): Simplify nbytes computation if buffered.
2721
2722 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2723
2724 * syntax.c (scan_words): Remove var that was set but not used.
2725 (update_syntax_table): Use unsigned instead of int.
2726
2727 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2728 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2729 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2730
2731 * print.c (print_error_message): Avoid int overflow.
2732
2733 * font.c (font_list_entities): Redo for clarity,
2734 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2735
2736 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2737 (font_score): Avoid potential overflow in diff calculation.
2738
2739 * fns.c (substring_both): Remove var that is set but not used.
2740 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2741
2742 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2743
2744 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2745 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2746 can always succeed if overflow has undefined behavior.
2747
2748 * search.c (boyer_moore, wordify): Remove vars set but not used.
2749 (wordify): Omit three unnecessary tests.
2750
2751 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2752 All callers changed. This avoids the need for an unused var.
2753
2754 * casefiddle.c (casify_region): Remove var that is set but not used.
2755
2756 * dired.c (file_name_completion): Remove var that is set but not used.
2757
2758 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2759
2760 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2761 (Finsert_file_contents): Remove unnecessary code checking fd.
2762
2763 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2764 Check for integer overflow on size calculations.
2765
2766 * buffer.c (Fprevious_overlay_change): Remove var that is set
2767 but not used.
2768
2769 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2770 Remove vars that are set but not used.
2771 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2772 (timer_check_2): Mark vars as initialized.
2773
2774 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2775
2776 * image.c (lookup_image): Remove var that is set but not used.
2777 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2778
2779 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2780 that are set but not used.
2781
2782 * xfns.c (make_invisible_cursor): Don't return garbage
2783 if XCreateBitmapFromData fails (Bug#8410).
2784
2785 * xselect.c (x_get_local_selection, x_handle_property_notify):
2786 Remove vars that are set but not used.
2787
2788 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2789 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2790
2791 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2792 Remove var that is set but not used.
2793 (scroll_bar_windows_size): Now size_t, not int.
2794 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2795 Check for overflow.
2796
2797 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2798 (map_tty_color) [!defined MSDOS]: Likewise.
2799
2800 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2801
2802 * coding.c: Remove vars that are set but not used.
2803 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2804 All callers changed.
2805 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2806 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2807 (decode_coding_charset): Remove vars that are set but not used.
2808
2809 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2810 that is set but not used.
2811
2812 * print.c (print_object): Remove var that is set but not used.
2813
2814 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2815 The gnulib version avoids calling malloc in the usual case,
2816 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2817 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2818 * filelock.c (current_lock_owner): Likewise.
2819 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2820 * sysdep.c: Include allocator.h, careadlinkat.h.
2821 (emacs_no_realloc_allocator): New static constant.
2822 (emacs_readlink): New function.
2823 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2824 ../lib/careadlinkat.h.
2825
2826 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2827
2828 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2829 first non-nil return value).
2830
2831 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2832
2833 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2834 if not defined (Bug#8403).
2835
2836 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2837
2838 * xdisp.c (display_count_lines): Remove parameter `start',
2839 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2840 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2841 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2842 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2843 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2844 and thereabouts. All callers changed.
2845 (get_per_char_metric): Remove parameter `f', unused since
2846 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2847
2848 2011-04-02 Jim Meyering <meyering@redhat.com>
2849
2850 do not dereference NULL upon failed strdup
2851 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2852 (ns_get_family): Likewise.
2853
2854 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2855
2856 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2857
2858 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2859
2860 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2861 later (Bug#8403).
2862
2863 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2864
2865 Add lexical binding.
2866
2867 * window.c (Ftemp_output_buffer_show): New fun.
2868 (Fsave_window_excursion):
2869 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2870
2871 * lread.c (lisp_file_lexically_bound_p): New function.
2872 (Fload): Bind Qlexical_binding.
2873 (readevalloop): Remove `evalfun' arg.
2874 Bind Qinternal_interpreter_environment.
2875 (Feval_buffer): Bind Qlexical_binding.
2876 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2877 Mark as dynamic.
2878 (syms_of_lread): Declare `lexical-binding'.
2879
2880 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2881
2882 * keyboard.c (eval_dyn): New fun.
2883 (menu_item_eval_property): Use it.
2884
2885 * image.c (parse_image_spec): Use Ffunctionp.
2886
2887 * fns.c (concat, mapcar1): Accept byte-code-functions.
2888
2889 * eval.c (Fsetq): Handle lexical vars.
2890 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2891 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2892 (FletX, Flet): Obey lexical binding.
2893 (Fcommandp): Handle closures.
2894 (Feval): New `lexical' arg.
2895 (eval_sub): New function extracted from Feval. Use it almost
2896 everywhere where Feval was used. Look up vars in lexical env.
2897 Handle closures.
2898 (Ffunctionp): Move from subr.el.
2899 (Ffuncall): Handle closures.
2900 (apply_lambda): Remove `eval_flags'.
2901 (funcall_lambda): Handle closures and new byte-code-functions.
2902 (Fspecial_variable_p): New function.
2903 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2904 but without exporting it to Lisp.
2905
2906 * doc.c (Fdocumentation, store_function_docstring):
2907 * data.c (Finteractive_form): Handle closures.
2908
2909 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2910 interactive spec.
2911
2912 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2913 New byte-codes.
2914 (exec_byte_code): New function extracted from Fbyte_code to handle new
2915 calling convention for byte-code-functions. Add new byte-codes.
2916
2917 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2918
2919 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2920
2921 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2922
2923 * xdisp.c (redisplay_internal): Fix prototype.
2924
2925 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2926
2927 * xdisp.c (SCROLL_LIMIT): New macro.
2928 (try_scrolling): Use it when setting scroll_limit.
2929 Limit scrolling to 100 screen lines.
2930 (redisplay_window): Even when falling back on "recentering",
2931 position point in the window according to scroll-conservatively,
2932 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2933
2934 (try_scrolling): When point is above the window, allow searching
2935 as far as scroll_max, or one screenful, to compute vertical
2936 distance from PT to the scroll margin position. This prevents
2937 try_scrolling from unnecessarily failing when
2938 scroll-conservatively is set to a value slightly larger than the
2939 window height. Clean up the case of PT below the margin at bottom
2940 of window: scroll_max can no longer be INT_MAX. When aggressive
2941 scrolling is in use, don't let point enter the opposite scroll
2942 margin as result of the scroll.
2943 (syms_of_xdisp) <scroll-conservatively>: Document the
2944 threshold of 100 lines for never-recentering scrolling.
2945
2946 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2947
2948 * dispextern.h (move_it_by_lines):
2949 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2950 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2951 (message_log_check_duplicate): Remove parameters `prev_bol' and
2952 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2953 (redisplay_internal): Remove parameter `preserve_echo_area',
2954 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2955
2956 * indent.c (Fvertical_motion):
2957 * window.c (window_scroll_pixel_based, Frecenter):
2958 Don't pass `need_y_p' to `move_it_by_lines'.
2959
2960 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2961
2962 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2963 steal a few bits to be more compact.
2964 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2965 Remove unneeded casts.
2966
2967 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2968
2969 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2970
2971 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2972 binding" message (bug#7967).
2973
2974 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Fix more problems found by GCC 4.6.0's static checks.
2977
2978 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2979 Remove unused local var.
2980
2981 * editfns.c (Fmessage_box): Remove unused local var.
2982
2983 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2984 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2985 Omit unused local vars.
2986 * window.c (shrink_windows): Omit unused local var.
2987 * menu.c (digest_single_submenu): Omit unused local var.
2988 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2989 Omit unused local var.
2990
2991 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2992 Don't assume string length fits in int.
2993 (keyremap_step, read_key_sequence): Use size_t for sizes.
2994 (read_key_sequence): Don't check last_real_key_start redundantly.
2995
2996 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2997 instead of alloca (Bug#8344).
2998
2999 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3000 (Fbacktrace_frame): Don't assume nframes fits in int.
3001
3002 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3003
3004 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3005 concerns.
3006
3007 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3008
3009 * cm.c (calccost): Turn while-do into do-while, for clarity.
3010
3011 * keyboard.c (syms_of_keyboard): Use the same style as later
3012 in this function when indexing through an array. This also
3013 works around GCC bug 48267.
3014
3015 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3016
3017 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3018
3019 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3020 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3021
3022 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3023 This avoids undefined behavior on integer overflow, and is a bit
3024 more convenient anyway since it is compared to a size_t variable.
3025
3026 Variadic C functions now count arguments with size_t, not int.
3027 This avoids an unnecessary limitation on 64-bit machines, which
3028 caused (substring ...) to crash on large vectors (Bug#8344).
3029 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3030 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3031 All variadic functions and their callers changed accordingly.
3032 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3033 * data.c (arith_driver, float_arith_driver): Likewise.
3034 * editfns.c (general_insert_function): Likewise.
3035 * eval.c (struct backtrace.nargs, interactive_p)
3036 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3037 (funcall_lambda, mark_backtrace): Likewise.
3038 * fns.c (concat): Likewise.
3039 * frame.c (x_set_frame_parameters): Likewise.
3040 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3041 0 if not found, not -1. All callers changed.
3042
3043 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3044 (stack_copy_size): Now size_t, not int.
3045 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3046
3047 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3050 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3051 All callers changed.
3052
3053 * lisp.h (multibyte_char_to_unibyte):
3054 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3055 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3056 * character.h (CHAR_TO_BYTE8):
3057 * cmds.c (internal_self_insert):
3058 * editfns.c (general_insert_function):
3059 * keymap.c (push_key_description):
3060 * search.c (Freplace_match):
3061 * xdisp.c (message_dolog, set_message_1): All callers changed.
3062
3063 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3064
3065 * keyboard.c (safe_run_hook_funcall): New function.
3066 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3067 don't set the hook to nil, but remove the offending function instead.
3068 (Qcommand_hook_internal): Remove, unused.
3069 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3070 Vcommand_hook_internal.
3071
3072 * eval.c (enum run_hooks_condition): Remove.
3073 (funcall_nil, funcall_not): New functions.
3074 (run_hook_with_args): Call each function through a `funcall' argument.
3075 Remove `cond' argument, now redundant.
3076 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3077 (Frun_hook_with_args_until_failure): Adjust accordingly.
3078 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3079
3080 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * dispextern.h (string_buffer_position): Remove declaration.
3083
3084 * print.c (strout): Remove parameter `multibyte', unused since
3085 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3086
3087 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3088 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3089 All callers changed.
3090
3091 * w32.c (_wsa_errlist): Use braces for struct initializers.
3092
3093 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3094 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3095 All callers changed.
3096 (string_buffer_position): Likewise. Also, make static (it's never
3097 used outside xdisp.c).
3098 (cursor_row_p): Remove parameter `w', unused since
3099 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3100 (decode_mode_spec): Remove parameter `precision', introduced during
3101 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3102 All callers changed.
3103
3104 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3105
3106 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3107
3108 2011-03-27 Anders Lindgren <andlind@gmail.com>
3109
3110 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3111 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3112 (ns_update_auto_hide_menu_bar): New functions.
3113 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3114 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3115 ns_constrain_all_frames.
3116 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3117 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3118
3119 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3120
3121 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3122
3123 2011-03-27 Glenn Morris <rgm@gnu.org>
3124
3125 * syssignal.h: Replace RETSIGTYPE with void.
3126 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3127 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3128 Replace SIGTYPE with void everywhere.
3129 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3130 * s/template.h (SIGTYPE): Remove commented out definition.
3131
3132 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3133
3134 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3135 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3136
3137 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3138
3139 * w32.c (read_unc_volume): Use parameter `henum', instead of
3140 global variable `wget_enum_handle'.
3141
3142 * keymap.c (describe_vector): Remove parameters `indices' and
3143 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3144 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3145
3146 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3147
3148 * keyboard.c (timer_check): Remove parameter `do_it_now',
3149 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3150 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3151 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3152
3153 * keyboard.c (read_char):
3154 * w32menu.c (w32_menu_display_help):
3155 * xmenu.c (show_help_event, menu_help_callback):
3156 Adjust calls to `show_help_echo'.
3157
3158 * gtkutil.c (xg_maybe_add_timer):
3159 * keyboard.c (readable_events):
3160 * process.c (wait_reading_process_output):
3161 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3162
3163 * insdel.c (adjust_markers_gap_motion):
3164 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3165 (gap_left, gap_right): Don't call it.
3166
3167 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3170 incurred during fontification.
3171
3172 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3173
3174 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3175 (DEFVAR_PER_BUFFER): Don't pass it.
3176
3177 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3178 (scrolling_window): Don't pass it.
3179
3180 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3181
3182 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3183
3184 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3185 and `suffix'.
3186 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3187 of variables specific to SELinux and computation of `encoded_absname'.
3188
3189 * image.c (XPutPixel): Remove unused variable `height'.
3190
3191 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3192
3193 * unexw32.c (get_section_info): Remove unused variable `section'.
3194
3195 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3196 (system_process_attributes): Remove unused variable `sess'.
3197 (sys_read): Remove unused variable `err'.
3198
3199 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3200 (w32_wnd_proc): Remove unused variable `isdead'.
3201 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3202 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3203 (x_create_tip_frame): Remove unused variable `tem'.
3204
3205 * w32inevt.c (w32_console_read_socket):
3206 Remove unused variable `no_events'.
3207
3208 * w32term.c (x_draw_composite_glyph_string_foreground):
3209 Remove unused variable `width'.
3210
3211 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * w32term.c (x_set_glyph_string_clipping):
3214 Don't pass uninitialized region to CombineRgn.
3215
3216 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3219 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3220 (Fx_close_connection): Remove unused variable `i'.
3221
3222 * w32font.c (w32font_draw): Return number of glyphs.
3223 (w32font_open_internal): Remove unused variable `i'.
3224 (w32font_driver): Add missing initializer.
3225
3226 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3227 (fill_in_menu): Remove unused variable `items_added'.
3228
3229 * w32term.c (last_mouse_press_frame): Remove static global variable.
3230 (w32_clip_to_row): Remove unused variable `f'.
3231 (x_delete_terminal): Remove unused variable `i'.
3232
3233 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3234 (NOTHING): Remove unused static global variable.
3235 (uniscribe_check_otf): Remove unused variable `table'.
3236 (uniscribe_font_driver): Add missing initializers.
3237
3238 2011-03-23 Julien Danjou <julien@danjou.info>
3239
3240 * term.c (Fsuspend_tty, Fresume_tty):
3241 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3242 * window.c (temp_output_buffer_show):
3243 * insdel.c (signal_before_change):
3244 * frame.c (Fhandle_switch_frame):
3245 * fileio.c (Fdo_auto_save):
3246 * emacs.c (Fkill_emacs):
3247 * editfns.c (save_excursion_restore):
3248 * cmds.c (internal_self_insert):
3249 * callint.c (Fcall_interactively):
3250 * buffer.c (Fkill_all_local_variables):
3251 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3252 Use Frun_hooks.
3253 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3254 unconditionnaly since it does the check itself.
3255
3256 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 Fix more problems found by GCC 4.5.2's static checks.
3259
3260 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3261 the first time through the loop, since we know p0 < p1 then.
3262 This also avoids a gcc -Wstrict-overflow warning.
3263
3264 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3265 leading to a memory leak, possible in functions like
3266 load_charset_map_from_file that can allocate an unbounded number
3267 of objects (Bug#8318).
3268
3269 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3270 that could (at least in theory) be that large.
3271
3272 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3273 This is less likely to overflow, and avoids undefined behavior if
3274 overflow does occur. All callers changed. Use strtoul to scan
3275 for the unsigned long integer.
3276 (pint2hrstr): Simplify and tune code slightly.
3277 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3278
3279 * scroll.c (do_scrolling): Work around GCC bug 48228.
3280 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3281
3282 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3283 This also avoids a warning with gcc -Wstrict-overflow.
3284 (validate_x_resource_name): Simplify count usage.
3285 This also avoids a warning with gcc -Wstrict-overflow.
3286
3287 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3288 fail (Bug#8306).
3289
3290 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3291
3292 * process.c (Fmake_network_process): Use socklen_t, not int,
3293 where POSIX says socklen_t is required in portable programs.
3294 This fixes a porting bug on hosts like 64-bit HP-UX, where
3295 socklen_t is wider than int (Bug#8277).
3296 (Fmake_network_process, server_accept_connection):
3297 (wait_reading_process_output, read_process_output):
3298 Likewise.
3299
3300 * process.c: Rename or move locals to avoid shadowing.
3301 (list_processes_1, Fmake_network_process):
3302 (read_process_output_error_handler, exec_sentinel_error_handler):
3303 Rename or move locals.
3304 (Fmake_network_process): Define label "retry_connect" only if needed.
3305 (Fnetwork_interface_info): Fix pointer signedness.
3306 (process_send_signal): Add cast to avoid pointer signedness problem.
3307 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3308 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3309
3310 Make tparam.h and terminfo.c consistent.
3311 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3312 Include tparam.h instead, since it declares them.
3313 * cm.h (PC): Remove extern decl; tparam.h now does this.
3314 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3315 * terminfo.c: Include tparam.h, to check interfaces.
3316 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3317 (tparam): Adjust signature to match interface in tparam.h;
3318 this removes some undefined behavior. Check that outstring and len
3319 are zero, which they always are with Emacs.
3320 * tparam.h (PC, BC, UP): New extern decls.
3321
3322 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3323 (xftfont_open): Rename locals to avoid shadowing.
3324
3325 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3326 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3327 (OTF_TAG_SYM): Omit macro if not needed.
3328 (ftfont_list): Remove unused local.
3329 (get_adstyle_property, ftfont_pattern_entity):
3330 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3331 Rename locals to avoid shadowing.
3332
3333 * xfont.c (xfont_list_family): Mark var as initialized.
3334
3335 * xml.c (make_dom): Now static.
3336
3337 * composite.c (composition_compute_stop_pos): Rename local to
3338 avoid shadowing.
3339 (composition_reseat_it): Remove unused locals.
3340 (find_automatic_composition, composition_adjust_point): Likewise.
3341 (composition_update_it): Mark var as initialized.
3342 (find_automatic_composition): Mark vars as initialized,
3343 with a FIXME (Bug#8290).
3344
3345 character.h: Rename locals to avoid shadowing.
3346 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3347 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3348 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3349 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3350 to avoid shadowing.
3351
3352 * textprop.c (property_change_between_p): Remove; unused.
3353
3354 * intervals.c (interval_start_pos): Now static.
3355
3356 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3357
3358 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3359 Rename locals to avoid shadowing.
3360
3361 * sound.c (wav_play, au_play, Fplay_sound_internal):
3362 Fix pointer signedness.
3363 (alsa_choose_format): Remove unused local var.
3364 (wav_play): Initialize a variable to 0, to prevent undefined
3365 behavior (Bug#8278).
3366
3367 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3368
3369 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3370
3371 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3372 clobbering (Bug#8298).
3373 * sysdep.c (sys_subshell): Likewise.
3374 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3375
3376 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3377 This should get cleaned up, so that child_setup has the
3378 same signature on all platforms.
3379
3380 * callproc.c (call_process_cleanup): Now static.
3381 (relocate_fd): Rename locals to avoid shadowing.
3382
3383 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3384
3385 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3386 not to be necessary, and produces flickering.
3387
3388 2011-03-20 Glenn Morris <rgm@gnu.org>
3389
3390 * config.in: Remove file.
3391
3392 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3393
3394 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3395 are now in src/globals.h.
3396 (syms_of_minibuf): Remove spurious & from previous change.
3397
3398 2011-03-20 Leo <sdl.web@gmail.com>
3399
3400 * minibuf.c (completing-read-function): New variable.
3401 (completing-read-default): Rename from completing-read.
3402 (completing-read): Call completing-read-function.
3403
3404 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3405
3406 * xfaces.c (Fx_load_color_file):
3407 Read color file from absolute filename (bug#8250).
3408
3409 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * makefile.w32-in: Update dependencies.
3412
3413 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3414
3415 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3416
3417 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 Fix more problems found by GCC 4.5.2's static checks.
3420
3421 * process.c (make_serial_process_unwind, send_process_trap):
3422 (sigchld_handler): Now static.
3423
3424 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3425 That way, the code declares only the vars that it needs.
3426 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3427 * s/cygwin.h (PTY_ITERATION): Likewise.
3428 * s/darwin.h (PTY_ITERATION): Likewise.
3429 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3430
3431 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3432 * process.c (allocate_pty): Don't declare stb unless it's needed.
3433
3434 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3435 (CONSTANTLIM): Remove; unused.
3436 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3437 Define only if needed.
3438
3439 * unexelf.c (unexec): Name an expression,
3440 to avoid gcc -Wbad-function-cast warning.
3441 Use a different way to cause a compilation error if anyone uses
3442 n rather than nn, a way that does not involve shadowing.
3443 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3444
3445 * deps.mk (unexalpha.o): Remove; unused.
3446
3447 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3448 * unexec.h: New file.
3449 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3450 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3451 Depend on unexec.h.
3452 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3453 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3454 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3455 Change as necessary to match prototype in unexec.h.
3456
3457 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3458 shadowing.
3459 (back_comment, skip_chars): Mark vars as initialized.
3460
3461 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3462 Rename locals to avoid shadowing.
3463
3464 * lread.c (read1): Rewrite so as not to use empty "else".
3465 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3466
3467 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3468
3469 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3470 warning when compiling print.c.
3471
3472 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3473 instead of using an uninitialized var.
3474 (font_sort_entities): Mark var as initialized.
3475
3476 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3477
3478 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3479 pointers to constants.
3480 (font_parse_fcname): Remove unused vars.
3481 (font_delete_unmatched): Now static.
3482 (font_get_spec): Remove; unused.
3483 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3484 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3485 Rename or move locals to avoid shadowing.
3486
3487 * fns.c (require_nesting_list, require_unwind): Now static.
3488 (Ffillarray): Rename locals to avoid shadowing.
3489
3490 * floatfns.c (domain_error2): Define only if needed.
3491 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3492
3493 * alloc.c (mark_backtrace): Move decl from here ...
3494 * lisp.h: ... to here, so that it can be checked.
3495
3496 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3497 (Fdefvar): Rewrite so as not to use empty "else".
3498 (lisp_indirect_variable): Name an expression,
3499 to avoid gcc -Wbad-function-cast warning.
3500 (Fdefvar): Rename locals to avoid shadowing.
3501
3502 * callint.c (quotify_arg, quotify_args): Now static.
3503 (Fcall_interactively): Rename locals to avoid shadowing.
3504 Use const pointer when appropriate.
3505
3506 * lisp.h (get_system_name, get_operating_system_release):
3507 Move decls here, to check interfaces.
3508 * process.c (get_operating_system_release): Move decl to lisp.h.
3509 * xrdb.c (get_system_name): Likewise.
3510 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3511 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3512 some of which prompt warnings from gcc -Wbad-function-cast.
3513 (Fformat_time_string, Fencode_time, Finsert_char):
3514 (Ftranslate_region_internal, Fformat):
3515 Rename or remove local vars to avoid shadowing.
3516 (Ftranslate_region_internal): Mark var as initialized.
3517
3518 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3519 avoid shadowing.
3520
3521 * lisp.h (eassert): Check that the argument compiles, even if
3522 ENABLE_CHECKING is not defined.
3523
3524 * data.c (Findirect_variable): Name an expression, to avoid
3525 gcc -Wbad-function-cast warning.
3526 (default_value, arithcompare, arith_driver, arith_error): Now static.
3527 (store_symval_forwarding): Rename local to avoid shadowing.
3528 (Fmake_variable_buffer_local, Fmake_local_variable):
3529 Mark variables as initialized.
3530 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3531
3532 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3533 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3534 Rename locals to avoid shadowing.
3535 (mark_stack): Move local variables into the #ifdef region where
3536 they're used.
3537 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3538 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3539 needed otherwise.
3540 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3541 (GC_STRING_CHARS): Remove; not used.
3542 (Fmemory_limit): Cast sbrk's returned value to char *.
3543
3544 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3545 avoids undefined behavior in theory.
3546
3547 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3548
3549 Use functions, not macros, for up- and down-casing (Bug#8254).
3550 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3551 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3552 to use the following functions instead of these macros.
3553 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3554 EMACS_INT, since callers assume the returned value fits in int.
3555 (upcase1): Likewise, for UPCASE_TABLE.
3556 (uppercasep, lowercasep, upcase): New static inline functions.
3557 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3558 the race-condition problem in the old DOWNCASE.
3559
3560 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3561 Rename locals to avoid shadowing.
3562 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3563 (regex_compile, re_search_2, re_match_2_internal):
3564 Remove unused local vars.
3565 (FREE_VAR): Rewrite so as not to use empty "else",
3566 which gcc can warn about.
3567 (regex_compile, re_match_2_internal): Mark locals as initialized.
3568 (RETALLOC_IF): Define only if needed.
3569 (WORDCHAR_P): Likewise. This one is never needed, but is used
3570 only in a comment talking about a compiler bug, so put inside
3571 the #if 0 of that comment.
3572 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3573 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3574 Remove; unused.
3575
3576 * search.c (boyer_moore): Rename locals to avoid shadowing.
3577 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3578 (PREV_CHAR_BOUNDARY): Likewise.
3579
3580 * search.c (simple_search): Remove unused var.
3581
3582 * dired.c (compile_pattern): Move decl from here ...
3583 * lisp.h: ... to here, so that it can be checked.
3584 (struct re_registers): New forward decl.
3585
3586 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3587
3588 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3589 All uses changed.
3590 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3591 Rename locals to avoid shadowing.
3592 (Fvertical_motion): Mark locals as initialized.
3593
3594 * casefiddle.c (casify_object, casify_region): Now static.
3595 (casify_region): Mark local as initialized.
3596
3597 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3598
3599 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3600 New macros, so that the caller can use some names other than
3601 gcpro1, gcpro2, etc.
3602 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3603 of the new macros.
3604 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3605 argument, for consistency with GCPRO2_VAR, etc: it is now the
3606 prefix of the variable, not the variable itself. All uses
3607 changed.
3608 * dired.c (directory_files_internal, file_name_completion):
3609 Rename locals to avoid shadowing.
3610
3611 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3612 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3613 dired.c's scmp function, had undefined behavior.
3614 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3615 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3616 * buffer.h: ... to here, because these macros use current_buffer,
3617 and the new implementation with inline functions needs to have
3618 current_buffer in scope now, rather than later when the macros
3619 are used.
3620 (downcase, upcase1): New static inline functions.
3621 (DOWNCASE, UPCASE1): Reimplement using these functions.
3622 This avoids undefined behavior in expressions like
3623 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3624 from race conditions in accessing the global variables
3625 case_temp1 and case_temp2.
3626 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3627 * lisp.h (case_temp1, case_temp2): Remove their decls.
3628 * character.h (ASCII_CHAR_P): Move from here ...
3629 * lisp.h: ... to here, so that the inline functions mentioned
3630 above can use them.
3631
3632 * dired.c (directory_files_internal_unwind): Now static.
3633
3634 * fileio.c (file_name_as_directory, directory_file_name):
3635 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3636 Now static.
3637 (file_name_as_directory): Use const pointers when appropriate.
3638 (Fexpand_file_name): Likewise. In particular, newdir might
3639 point at constant storage, so make it a const pointer.
3640 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3641 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3642 signedness issues.
3643 (Fset_file_times, Finsert_file_contents, auto_save_error):
3644 Rename locals to avoid shadowing.
3645
3646 * minibuf.c (choose_minibuf_frame_1): Now static.
3647 (Ftry_completion, Fall_completions): Rename or remove locals
3648 to avoid shadowing.
3649
3650 * marker.c (bytepos_to_charpos): Remove; unused.
3651
3652 * lisp.h (verify_bytepos, count_markers): New decls,
3653 so that gcc does not warn that these functions aren't declared.
3654
3655 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3656 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3657 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3658 (copy_text): Remove unused local var.
3659
3660 * filelock.c (within_one_second): Now static.
3661 (lock_file_1): Rename local to avoid shadowing.
3662
3663 * buffer.c (fix_overlays_before): Mark locals as initialized.
3664 (fix_start_end_in_overlays): Likewise. This function should be
3665 simplified by using pointers-to-pointers, but that's a different
3666 matter.
3667 (switch_to_buffer_1): Now static.
3668 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3669 (report_overlay_modification): Rename locals to avoid shadowing.
3670
3671 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3672 Fix pointer signedness issue.
3673 (sys_subshell): Mark local as volatile if checking for lint,
3674 to suppress a gcc -Wclobbered warning that does not seem to be right.
3675 (MAXPATHLEN): Define only if needed.
3676
3677 * process.c (serial_open, serial_configure): Move decls from here ...
3678 * systty.h: ... to here, so that they can be checked.
3679
3680 * fns.c (get_random, seed_random): Move extern decls from here ...
3681 * lisp.h: ... to here, so that they can be checked.
3682
3683 * sysdep.c (reset_io): Now static.
3684 (wait_for_termination_signal): Remove; unused.
3685
3686 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3687 (copy_keymap_item, append_key, push_text_char_description):
3688 Now static.
3689 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3690 (DENSE_TABLE_SIZE): Remove; unused.
3691 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3692 (describe_map_tree):
3693 Rename locals to avoid shadowing.
3694
3695 * keyboard.c: Declare functions static if they are not used elsewhere.
3696 (echo_char, echo_dash, cmd_error, top_level_2):
3697 (poll_for_input, handle_async_input): Now static.
3698 (read_char, kbd_buffer_get_event, make_lispy_position):
3699 (make_lispy_event, make_lispy_movement, apply_modifiers):
3700 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3701 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3702 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3703 (read_key_sequence, read_char): Mark locals as initialized.
3704 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3705
3706 * keyboard.h (make_ctrl_char): New decl.
3707 (mark_kboards): Move decl here ...
3708 * alloc.c (mark_kboards): ... from here.
3709
3710 * lisp.h (force_auto_save_soon): New decl.
3711
3712 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3713 (DEFINE_DUMMY_FUNCTION): New macro.
3714 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3715 Use it.
3716 (main): Add casts to avoid warnings
3717 if GCC considers string literals to be constants.
3718
3719 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3720
3721 * dbusbind.c: Pointer signedness fixes.
3722 (xd_signature, xd_append_arg, xd_initialize):
3723 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3724 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3725 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3726 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3727
3728 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3729 if GCC considers string literals to be constants.
3730 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3731
3732 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3733
3734 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3735 (print_preprocess, print_object): New macro to fix last change.
3736
3737 * print.c (print_preprocess): Don't forget font objects.
3738
3739 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * emacs.c (USAGE3): Doc fixes.
3742
3743 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3744
3745 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3746 structure.
3747
3748 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3749
3750 * lisp.h (VWindow_system, Qfile_name_history):
3751 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3752 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3753 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3754
3755 * w32select.c: Don't #include "keyboard.h".
3756 (run_protected): Add extern declaration for waiting_for_input.
3757
3758 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3759 * w32console.c (detect_input_pending, read_input_pending)
3760 (encode_terminal_code):
3761 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3762 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3763 (w32_system_caret_y, Qfile_name_history):
3764 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3765 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3766 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3767 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3768 * w32proc.c (Qlocal, report_file_error):
3769 * w32term.c (Vwindow_system, updating_frame):
3770 * w32uniscribe.c (initialized, uniscribe_font_driver):
3771 Remove unneeded extern declarations.
3772
3773 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3774
3775 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3776
3777 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3778
3779 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3780 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3781 These macros can no longer be used for assignment.
3782
3783 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3784 Assign struct members directly, instead of using BUF_BEGV etc.
3785 (record_buffer_markers, fetch_buffer_markers): New functions for
3786 recording and fetching special buffer markers.
3787 (set_buffer_internal_1, set_buffer_temp): Use them.
3788
3789 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3790
3791 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3792
3793 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3794 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3795
3796 * xdisp.c (hscroll_window_tree):
3797 (reconsider_clip_changes): Use PT instead of BUF_PT.
3798
3799 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3800
3801 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3802 $(EMACS_ROOT)/lib/intprops.h.
3803
3804 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 Fix more problems found by GCC 4.5.2's static checks.
3807
3808 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3809 to unsigned char * to avoid compiler diagnostic.
3810 (xg_free_frame_widgets): Make it clear that a local variable is
3811 needed only if USE_GTK_TOOLTIP.
3812 (gdk_window_get_screen): Make it clear that this macro is needed
3813 only if USE_GTK_TOOLTIP.
3814 (int_gtk_range_get_value): New function, which avoids a diagnostic
3815 from gcc -Wbad-function-cast.
3816 (xg_set_toolkit_scroll_bar_thumb): Use it.
3817 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3818 diagnostic from gcc -Wbad-function-cast.
3819 (get_utf8_string, xg_get_file_with_chooser):
3820 Rename locals to avoid shadowing.
3821 (create_dialog): Move locals to avoid shadowing.
3822
3823 * xgselect.c (xg_select): Remove unused var.
3824
3825 * image.c (four_corners_best): Mark locals as initialized.
3826 (gif_load): Initialize transparent_p to zero (Bug#8238).
3827 Mark another local as initialized.
3828 (my_png_error, my_error_exit): Mark with NO_RETURN.
3829
3830 * image.c (clear_image_cache): Now static.
3831 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3832 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3833 (x_edge_detection): Remove unnecessary cast that
3834 gcc -Wbad-function-cast diagnoses.
3835 (gif_load): Fix pointer signedness.
3836 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3837 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3838
3839 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Improve quality of tests for time stamp overflow.
3842 For example, without this patch (encode-time 0 0 0 1 1
3843 1152921504606846976) returns the obviously-bogus value (-948597
3844 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3845 reports time overflow. See
3846 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3847 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3848 * editfns.c: Include limits.h and intprops.h.
3849 (TIME_T_MIN, TIME_T_MAX): New macros.
3850 (time_overflow): Move earlier, to before first use.
3851 (hi_time, lo_time): New functions, for an accurate test for
3852 out-of-range times.
3853 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3854 (Fget_internal_run_time): Don't assume time_t fits in int.
3855 (make_time): Use list2 instead of Fcons twice.
3856 (Fdecode_time): More accurate test for out-of-range times.
3857 (check_tm_member): New function.
3858 (Fencode_time): Use it, to test for out-of-range times.
3859 (lisp_time_argument): Don't rely on undefined left-shift and
3860 right-shift behavior when checking for time stamp overflow.
3861
3862 * editfns.c (time_overflow): New function, refactoring common code.
3863 (Fformat_time_string, Fdecode_time, Fencode_time):
3864 (Fcurrent_time_string): Use it.
3865
3866 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3867 * dired.c (make_time): Move to ...
3868 * editfns.c (make_time): ... here.
3869 * systime.h: Note the move.
3870
3871 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3872
3873 * fringe.c (update_window_fringes): Remove unused variables.
3874
3875 * unexmacosx.c (copy_data_segment): Also copy __got section.
3876 (Bug#8223)
3877
3878 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3879
3880 * termcap.c [MSDOS]: Include "msdos.h".
3881 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3882 Constify `char *' arguments and their references according to
3883 prototypes in tparam.h.
3884
3885 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3886
3887 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3888 Adapt all references accordingly.
3889
3890 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3891
3892 2011-03-11 Tom Tromey <tromey@redhat.com>
3893
3894 * buffer.c (syms_of_buffer): Remove obsolete comment.
3895
3896 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3897
3898 * termhooks.h (encode_terminal_code): Declare prototype.
3899
3900 * msdos.c (encode_terminal_code): Don't declare prototype.
3901
3902 * term.c (encode_terminal_code): Now external again, used by
3903 w32console.c and msdos.c.
3904
3905 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3906 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3907
3908 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Fix some minor problems found by GCC 4.5.2's static checks.
3911
3912 * fringe.c (update_window_fringes): Mark locals as initialized
3913 (Bug#8227).
3914 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3915
3916 * alloc.c (mark_fringe_data): Move decl from here ...
3917 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3918 to check its interface.
3919 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3920
3921 * fontset.c (free_realized_fontset): Now static.
3922 (Fset_fontset_font): Rename local to avoid shadowing.
3923 (fontset_font): Mark local as initialized.
3924 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3925
3926 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3927
3928 * xselect.c (x_disown_buffer_selections): Remove; not used.
3929 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3930 (x_own_selection, Fx_disown_selection_internal): Rename locals
3931 to avoid shadowing.
3932 (x_handle_dnd_message): Remove local to avoid shadowing.
3933
3934 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3935 so that the caller can use some name other than gcpro1.
3936 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3937 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3938 (Fx_backspace_delete_keys_p):
3939 Use them to avoid shadowing, and rename vars to avoid shadowing.
3940 (x_decode_color, x_set_name, x_window): Now static.
3941 (Fx_create_frame): Add braces to silence GCC warning.
3942 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3943 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3944 Remove unused locals.
3945 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3946 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3947 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3948 macros.
3949
3950 * xterm.h (x_mouse_leave): New decl.
3951
3952 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3953 Remove unused functions.
3954 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3955 (x_calc_absolute_position): Now static.
3956 (XTread_socket): Don't define label "out" unless it's used.
3957 Don't declare local "event" unless it's used.
3958 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3959 unless they are used.
3960 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3961 (x_fatal_error_signal): Remove; not used.
3962 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3963 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3964 (x_error_catcher, x_connection_closed, x_error_handler):
3965 (x_error_quitter, xembed_send_message, x_iconify_frame):
3966 (my_log_handler): Rename locals to avoid shadowing.
3967 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3968 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3969
3970 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3971 Rename or move locals to avoid shadowing.
3972 (tty_defined_color, merge_face_heights): Now static.
3973 (free_realized_faces_for_fontset): Remove; not used.
3974 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3975 does not deduce is never used uninitialized.
3976 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3977 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3978
3979 * terminal.c (store_terminal_param): Now static.
3980
3981 * xmenu.c (menu_highlight_callback): Now static.
3982 (set_frame_menubar): Remove unused local.
3983 (xmenu_show): Rename parameter to avoid shadowing.
3984 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3985 since they might point to immutable storage.
3986 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3987 since it's unused otherwise.
3988
3989 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3990 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3991 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3992 avoids a gcc -Wuninitialized diagnostic.
3993 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3994 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3995 does not deduce are never used uninitialized.
3996
3997 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3998
3999 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4000 * window.c (window_loop, size_window):
4001 (run_window_configuration_change_hook, enlarge_window): Likewise.
4002
4003 * window.c (display_buffer): Now static.
4004 (size_window): Mark variables that gcc -Wuninitialized
4005 does not deduce are never used uninitialized.
4006 * window.h (check_all_windows): New decl, to forestall
4007 gcc -Wmissing-prototypes diagnostic.
4008 * dispextern.h (bidi_dump_cached_states): Likewise.
4009
4010 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4011 shadowing.
4012 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4013 Include <limits.h>.
4014 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4015 and to avoid gcc -Wuninitialized warning.
4016 (load_charset_map): Mark variables that gcc -Wuninitialized
4017 does not deduce are never used uninitialized.
4018 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4019
4020 * coding.c (coding_set_source, coding_set_destination):
4021 Use "else { /* comment */ }" rather than "else /* comment */;"
4022 for clarity, and to avoid gcc -Wempty-body warning.
4023 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4024 a block, when the outer 'i' will do.
4025 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4026 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4027 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4028 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4029 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4030 Rename locals to avoid shadowing.
4031 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4032 * coding.c (emacs_mule_char, encode_invocation_designation):
4033 Now static, since they're not used elsewhere.
4034 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4035 (decode_coding_object, encode_coding_object, detect_coding_system):
4036 (decode_coding_emacs_mule): Mark variables that gcc
4037 -Wuninitialized does not deduce are never used uninitialized.
4038 (detect_coding_iso_2022): Initialize a local variable that might
4039 be used uninitialized. Leave a FIXME because it's not clear that
4040 this initialization is needed. (Bug#8211)
4041 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4042 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4043 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4044 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4045 Remove unused macros.
4046
4047 * category.c (hash_get_category_set): Remove unused local var.
4048 (copy_category_table): Now static, since it's not used elsewhere.
4049 * character.c (string_count_byte8): Likewise.
4050
4051 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4052 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4053
4054 * chartab.c (copy_sub_char_table): Now static, since it's not used
4055 elsewhere.
4056 (sub_char_table_ref_and_range, char_table_ref_and_range):
4057 Rename locals to avoid shadowing.
4058 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4059
4060 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4061 (BIDI_BOB): Remove unused macro.
4062
4063 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4064 deduce are never used uninitialized.
4065 * term.c (encode_terminal_code): Likewise.
4066
4067 * term.c (encode_terminal_code): Now static. Remove unused local.
4068
4069 * tparam.h: New file.
4070 * term.c, tparam.h: Include it.
4071 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4072 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4073 Move these decls to tparam.h, and make them agree with what
4074 is actually in tparam.c. The previous trick of using incompatible
4075 decls in different modules does not conform to the C standard.
4076 All callers of tparam changed to use tparam's actual API.
4077 * tparam.c (tparam1, tparam, tgoto):
4078 Use const pointers where appropriate.
4079
4080 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4081 * cm.h (struct cm): Likewise.
4082 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4083 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4084 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4085 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4086 (turn_on_face, init_tty): Likewise.
4087 * termchar.h (struct tty_display_info): Likewise.
4088
4089 * term.c (term_mouse_position): Rename local to avoid shadowing.
4090
4091 * alloc.c (mark_ttys): Move decl from here ...
4092 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4093
4094 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4095
4096 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4097
4098 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4099
4100 * search.c (compile_pattern_1): Remove argument regp, unused since
4101 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4102 (compile_pattern): Don't pass it.
4103
4104 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4105
4106 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4107 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4108 for ! HAVE_GTK3.
4109 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4110
4111 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4112
4113 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4114 gdk_window_get_screen, gdk_window_get_geometry,
4115 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4116 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4117 (xg_get_pixbuf_from_pixmap): New function.
4118 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4119 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4120 Call xg_get_pixbuf_from_pixmap instead of
4121 gdk_pixbuf_get_from_drawable.
4122 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4123 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4124 (xg_check_special_colors): Use GtkStyleContext and its functions
4125 for HAVE_GTK3.
4126 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4127 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4128 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4129 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4130 Call gtk_widget_get_preferred_size.
4131 (xg_frame_resized): gdk_window_get_geometry only takes 5
4132 parameters.
4133 (xg_win_to_widget, xg_event_is_for_menubar):
4134 Call gdk_x11_window_lookup_for_display.
4135 (xg_set_widget_bg): New function.
4136 (delete_cb): New function.
4137 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4138 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4139 (xg_set_background_color): Call xg_set_widget_bg.
4140 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4141 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4142 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4143 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4144 if ! HAVE_GTK3.
4145 (update_frame_tool_bar): Call gtk_widget_hide.
4146 (xg_initialize): Use GDK_KEY_g.
4147
4148 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4149 if ! HAVE_GTK3
4150 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4151
4152 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4153 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4154 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4155
4156 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * w32xfns.c (select_palette): Check success of RealizePalette against
4159 GDI_ERROR, not zero.
4160
4161 See ChangeLog.11 for earlier changes.
4162
4163 ;; Local Variables:
4164 ;; coding: utf-8
4165 ;; End:
4166
4167 Copyright (C) 2011 Free Software Foundation, Inc.
4168
4169 This file is part of GNU Emacs.
4170
4171 GNU Emacs is free software: you can redistribute it and/or modify
4172 it under the terms of the GNU General Public License as published by
4173 the Free Software Foundation, either version 3 of the License, or
4174 (at your option) any later version.
4175
4176 GNU Emacs is distributed in the hope that it will be useful,
4177 but WITHOUT ANY WARRANTY; without even the implied warranty of
4178 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4179 GNU General Public License for more details.
4180
4181 You should have received a copy of the GNU General Public License
4182 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.